ci: change codecov threshold to 1

/lgtm

/cc

/meow

/meow caturday

/meow caturday

/pony

/pony

@shilinlee:

In response to this:

/pony

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/meow caturday

@shilinlee:

In response to this:

/meow caturday

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/pony

@shilinlee:

In response to this:

/pony

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/meow caturday

@shilinlee:

In response to this:

/meow caturday

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/test

/cc

@shilinlee: GitHub didn't allow me to request PR reviews from the following users: shilinlee.
Note that only shilinlee members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/assign

/cc shilinlee-bot

/lgtm

@shilinlee: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shilinlee, shilinlee-bot
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [shilinlee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

New changes are detected. LGTM label has been removed.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shilinlee, shilinlee-bot
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [shilinlee,shilinlee-bot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shilinlee, shilinlee-bot
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [shilinlee,shilinlee-bot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: shilinlee, shilinlee-bot
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [shilinlee,shilinlee-bot]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve

/lgtm

@shilinlee: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

New changes are detected. LGTM label has been removed.

/lgtm

@shilinlee: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/pony


Ignore iterm2.

  <replacementname>MY_IGNORE_APPS</replacementname>
  <replacementvalue>ITERM2</replacementvalue>
  </replacementdef>

I have the above setting to ignore iterm2 while running karabiner. Is there anything wrong with it? I don't seem to see my setting name after reload private.xml.

I notice that there is no <replacementdef> start tag? Like, I would expect it to read:
<replacementdef>
  <replacementname>MY_IGNORE_APPS</replacementname>
  <replacementvalue>ITERM2</replacementvalue>
</replacementdef>

@ethus3h I actually have <replacementdef> start tag. Missed it when pasting.

Update:
<root>
  <appdef>
    <appname>TERMINAL</appname>
    <equal>com.apple.Terminal</equal>
  </appdef>
  <replacementdef>
  <replacementname>MY_IGNORE_APPS</replacementname>
  <replacementvalue>TERMINAL</replacementvalue>
  </replacementdef>
</root>

I've changed the xml to the above, still didn't work.

Hmm, afraid I'm stumped then without further reading :)

<?xml version="1.0"?>
<root>

   <appdef>
     <appname>iterm2</appname>
     <equal>com.googlecode.iterm2</equal>
   </appdef>

   <item>
     <name>Disable all settings in iterm2</name>
     <identifier>private.disable_in_iterm2</identifier>
     <only>iterm2</only>
     <autogen>__PassThrough__</autogen>
   </item>

</root>

The above code works.


SabreSwap docstring fix

Summary
Fixes #4936
Details and comments
Changed the absolute sign to the absolute parenthesis. Used multi-line breaker to continue the equation in the next line

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Thank you!


Build downloads proprietary .NET SDK package

When building MSBuild from source, a proprietary .NET SDK package is downloaded, which may be unsuitable in some environments.
Solution: Allow to use system .NET implementation or use Mono.

That's the .NET Core SDK and it is as proprietary of Microsoft and MSBuild itself is. We have no plans to remove this dependency.


fix: opensearch mapping update error

Feature or Bugfix

Bugfix

Fixes mapping update error due to mapping being created with a different type on the 1st ingested document:
opensearchpy.helpers.errors.BulkIndexError: ('1 document(s) failed to index.', [{'index': {'_index': 'test_index_csv_local_20c32d5a', '_id': '4c988c9e-6519-4cd7-8467-f7fce41e5173', 'status': 400, 'error': {'type': 'illegal_argument_exception', 'reason': 'mapper [business_phone_number] cannot be changed from type [float] to [long]'}, 'data': {'business_address': '2162 24th Ave', 'business_city': 'San Francisco', 'business_id': 5794, 'business_latitude': 37.747228, 'business_location': {'lon': -122.481299, 'lat': 37.747228}, 'business_longitude': -122.481299, 'business_name': 'Soup-or-Salad', 'business_postal_code': 94116, 'business_state': 'CA', 'inspection_date': '2016-09-07T00:00:00.000', 'inspection_id': '5794_20160907', 'inspection_score': 96, 'inspection_type': 'Routine - Unscheduled', 'risk_category': 'Low Risk', 'violation_description': 'Unapproved or unmaintained equipment or utensils', 'violation_id': '5794_20160907_103144', 'business_phone_number':<PHONE_NUMBER>0}}}])

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: 886ccb4b3d4e85ff3b7ccf98c0b7d7fdcb2ba453
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: 886ccb4b3d4e85ff3b7ccf98c0b7d7fdcb2ba453
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
Commit ID: b182ab65088eaa4484d2992c42d30b53a404a641
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

AWS CodeBuild CI Report

CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
Commit ID: b182ab65088eaa4484d2992c42d30b53a404a641
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository


Strange behaviour after continuing training after crash

After Exception happens, for whatever reason, the ep_raw_mean and ep_len_mean are much higher than usual. Are we properly reseting the environment before restarting the training? Or is there a more important issue? Perhaps the opponents are reset to their poorest state, meaning that after restarting we are playing against easier opponents?
Note that after a while it goes down to a similar level that it was before the crash.
This is the prompt that i got around the Exception:
----------------------------------------
| rollout/                |            |
|    ep_len_mean          | 72.6       |
|    ep_rew_mean          | 13.8       |
| time/                   |            |
|    fps                  | 105        |
|    iterations           | 300        |
|    time_elapsed         | 5833       |
|    total_timesteps      | 614400     |
| train/                  |            |
|    approx_kl            | 0.06014028 |
|    clip_fraction        | 0.185      |
|    clip_range           | 0.2        |
|    entropy_loss         | -0.407     |
|    explained_variance   | 0.6        |
|    learning_rate        | 0.0003     |
|    loss                 | 1.53       |
|    n_updates            | 48400      |
|    policy_gradient_loss | -0.0404    |
|    value_loss           | 9.12       |
----------------------------------------
Exception: get_idx < pet-hedgehog 10-1 status-honey-bee 2-1 > not found
-----------------------------------------
| rollout/                |             |
|    ep_len_mean          | 92.7        |
|    ep_rew_mean          | 33.1        |
| time/                   |             |
|    fps                  | 123         |
|    iterations           | 1           |
|    time_elapsed         | 16          |
|    total_timesteps      | 2048        |
| train/                  |             |
|    approx_kl            | 0.043567862 |
|    clip_fraction        | 0.208       |
|    clip_range           | 0.2         |
|    entropy_loss         | -0.48       |
|    explained_variance   | 0.68        |
|    learning_rate        | 0.0003      |
|    loss                 | 5.09        |
|    n_updates            | 48410       |
|    policy_gradient_loss | -0.0425     |
|    value_loss           | 9.02        |
-----------------------------------------
-----------------------------------------
| rollout/                |             |
|    ep_len_mean          | 83.9        |
|    ep_rew_mean          | 24.1        |
| time/                   |             |
|    fps                  | 116         |
|    iterations           | 2           |
|    time_elapsed         | 35          |
|    total_timesteps      | 4096        |
| train/                  |             |
|    approx_kl            | 0.041116748 |
|    clip_fraction        | 0.179       |
|    clip_range           | 0.2         |
|    entropy_loss         | -0.366      |
|    explained_variance   | 0.631       |
|    learning_rate        | 0.0003      |
|    loss                 | 5.58        |
|    n_updates            | 48420       |
|    policy_gradient_loss | -0.0446     |
|    value_loss           | 16.3        |
-----------------------------------------
-----------------------------------------
| rollout/                |             |
|    ep_len_mean          | 83          |
|    ep_rew_mean          | 21.3        |
| time/                   |             |
|    fps                  | 114         |
|    iterations           | 3           |
|    time_elapsed         | 53          |
|    total_timesteps      | 6144        |
| train/                  |             |
|    approx_kl            | 0.056923926 |
|    clip_fraction        | 0.187       |
|    clip_range           | 0.2         |
|    entropy_loss         | -0.404      |
|    explained_variance   | 0.585       |
|    learning_rate        | 0.0003      |
|    loss                 | 3.17        |
|    n_updates            | 48430       |
|    policy_gradient_loss | -0.043      |
|    value_loss           | 12.3        |
-----------------------------------------
----------------------------------------
| rollout/                |            |
|    ep_len_mean          | 83.6       |
|    ep_rew_mean          | 21.4       |
| time/                   |            |
|    fps                  | 112        |
|    iterations           | 4          |
|    time_elapsed         | 72         |
|    total_timesteps      | 8192       |
| train/                  |            |
|    approx_kl            | 0.05702912 |
|    clip_fraction        | 0.185      |
|    clip_range           | 0.2        |
|    entropy_loss         | -0.42      |
|    explained_variance   | 0.476      |
|    learning_rate        | 0.0003     |
|    loss                 | 3.65       |
|    n_updates            | 48440      |
|    policy_gradient_loss | -0.0412    |
|    value_loss           | 14.4       |
----------------------------------------
---------------------------------------
| rollout/                |           |
|    ep_len_mean          | 77.3      |
|    ep_rew_mean          | 16.2      |
| time/                   |           |
|    fps                  | 112       |
|    iterations           | 5         |
|    time_elapsed         | 91        |
|    total_timesteps      | 10240     |
| train/                  |           |
|    approx_kl            | 0.0575137 |
|    clip_fraction        | 0.185     |
|    clip_range           | 0.2       |
|    entropy_loss         | -0.396    |
|    explained_variance   | 0.469     |
|    learning_rate        | 0.0003    |
|    loss                 | 4.42      |
|    n_updates            | 48450     |
|    policy_gradient_loss | -0.0437   |
|    value_loss           | 13.3      |
---------------------------------------
-----------------------------------------
| rollout/                |             |
|    ep_len_mean          | 78.6        |
|    ep_rew_mean          | 17.3        |
| time/                   |             |
|    fps                  | 112         |
|    iterations           | 6           |
|    time_elapsed         | 109         |
|    total_timesteps      | 12288       |
| train/                  |             |
|    approx_kl            | 0.077249065 |
|    clip_fraction        | 0.219       |
|    clip_range           | 0.2         |
|    entropy_loss         | -0.47       |
|    explained_variance   | 0.525       |
|    learning_rate        | 0.0003      |
|    loss                 | 2.23        |
|    n_updates            | 48460       |
|    policy_gradient_loss | -0.0489     |
|    value_loss           | 9.37        |
-----------------------------------------
-----------------------------------------
| rollout/                |             |
|    ep_len_mean          | 78.3        |
|    ep_rew_mean          | 17.8        |
| time/                   |             |
|    fps                  | 112         |
|    iterations           | 7           |
|    time_elapsed         | 127         |
|    total_timesteps      | 14336       |
| train/                  |             |
|    approx_kl            | 0.048610996 |
|    clip_fraction        | 0.182       |
|    clip_range           | 0.2         |
|    entropy_loss         | -0.408      |
|    explained_variance   | 0.645       |
|    learning_rate        | 0.0003      |
|    loss                 | 2.42        |
|    n_updates            | 48470       |
|    policy_gradient_loss | -0.041      |
|    value_loss           | 11.6        |
-----------------------------------------
----------------------------------------
| rollout/                |            |
|    ep_len_mean          | 77.4       |
|    ep_rew_mean          | 17.6       |
| time/                   |            |
|    fps                  | 111        |
|    iterations           | 8          |
|    time_elapsed         | 147        |
|    total_timesteps      | 16384      |
| train/                  |            |
|    approx_kl            | 0.04007852 |
|    clip_fraction        | 0.202      |
|    clip_range           | 0.2        |
|    entropy_loss         | -0.448     |
|    explained_variance   | 0.687      |
|    learning_rate        | 0.0003     |
|    loss                 | 2.07       |
|    n_updates            | 48480      |
|    policy_gradient_loss | -0.0456    |
|    value_loss           | 12         |
----------------------------------------
-----------------------------------------
| rollout/                |             |
|    ep_len_mean          | 76.6        |
|    ep_rew_mean          | 17.3        |
| time/                   |             |
|    fps                  | 111         |
|    iterations           | 9           |
|    time_elapsed         | 165         |
|    total_timesteps      | 18432       |
| train/                  |             |
|    approx_kl            | 0.056452066 |
|    clip_fraction        | 0.186       |
|    clip_range           | 0.2         |
|    entropy_loss         | -0.419      |
|    explained_variance   | 0.539       |
|    learning_rate        | 0.0003      |
|    loss                 | 5.39        |
|    n_updates            | 48490       |
|    policy_gradient_loss | -0.043      |
|    value_loss           | 17.7        |
-----------------------------------------
-----------------------------------------
| rollout/                |             |
|    ep_len_mean          | 75.7        |
|    ep_rew_mean          | 17.1        |
| time/                   |             |
|    fps                  | 110         |
|    iterations           | 10          |
|    time_elapsed         | 184         |
|    total_timesteps      | 20480       |
| train/                  |             |
|    approx_kl            | 0.043880884 |
|    clip_fraction        | 0.188       |
|    clip_range           | 0.2         |
|    entropy_loss         | -0.453      |
|    explained_variance   | 0.543       |
|    learning_rate        | 0.0003      |
|    loss                 | 6.02        |
|    n_updates            | 48500       |
|    policy_gradient_loss | -0.0444     |
|    value_loss           | 14.9        |
-----------------------------------------

ep_rew_mean and ep_len_mean are calculated by averaging corresponding values over the last 100 episodes. These information is stored in a buffer (ep_info_buffer). When you restart the training it is possible that the buffer is emptied and thus they are not the true mean over 100 episodes.

Emptying the buffer seems like the correct thing to do, as we start a completely new training and have no real control of the interaction between these, unless we handle this ourselves.
A much better solution would be if the training just worked - that we could train forever without any errors.
There seem to be issues at multiple levels, and quite challenging to debug what is causing all these, but I would presume there is something wrong in sapai-gym. However, I added a method to catch if any errors happened inside the step method in sapai-gym:
https://github.com/andreped/sapai-gym/commit/7443f36944466316efbb5f0c35d91593cc7a50e5
To my surprise I still got some errors, so I believe there might be something wrong in the sapai engine. Not sure really.


fix(vmware_vcenter): json routing

Description of Changes
Our initial routing still captured the <134>1 ... format syslogs, made check more explicit and it's working now.
Please check that the PR fulfills these requirements

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)
[ ] CI passes

Thanks for the screenshot Keith. That shows proper parsing of syslog format, here is an example showing output from a netcat command since we can't replicate the json output:

screenshot


Running in multi-container/node/zone deployment

Hello, I'm new with strapi and it looks very interesting for many of our projects. One thing that I'm struggling with is how to run containerized strapi with multi-container/multi-node deployment (k8s, ecs etc.). The issues/questions I've discovered so far:

each container needs local volume to install plugins and dependencies, is it safe to run multiple containers mounted in same volume? Wouldn't it break if all containers try to start at once and install dependencies?
i think the best scenario would be running the container without any volumes, no problem with node_modules installation (in custom image), but is it possible to do this with plugins (preinstall plugins and possibly disable installation from administration) so the app starts much quicker and it's no problem to drop container and start another one?
is the strapi app ok with running same app in multiple instances/containers behind load balancer? For example after updating the model, the app restarts. Can't imagine how to do that with multiple instances.

Thanks for any answer/s.

Any news regarding this? Also interested.

Interested in this, I'm also aiming to deploy Strapi on K8S cluster and expect it to be able to run on multiple pods/containers.
One more point is Strapi is causing downtime on configuration changes (code changes), this's awkward on production.

@lucaperret @msgeissler @synth3tk any insights?

Hm, I don't have any experience with K8S and only minimal experience with running stuff in (docker) clusters.
For the strapi-container you should basically follow the normal strapi-cluster setup first. Sadly I cannot find any documentation for that. So I do not know what kind of settings and setup strapi itself expects in a cluster environment.
As far as volumes go, I would also go with the idea to create a custom "final / production" image that already has everything installed. That way you can test your final image, you get faster start times and you can make sure (unless strapi does some fancy under the hood auto-updates) that all instances run the same version. Otherwise a new node / pod might suddenly download a newer plugin version and behave differently. That way there is also no need to mount an external volume so you do not run into any problems with the mount point not existing on a node / not being persistent (so it has to re-download everything) / or having to mount it on all nodes (and re-use the same for all pods, which I do not think is a good idea). I currently cannot remember if strapi requires a persistent storage for media uploads though, as I haven't used it in a while. That might require a cluster-ready persistent storage (whatever strapi supports, NFS, S3 etc. and support from strapi itself for concurrent access).
But I would need more info on strapi-clustering itself first to help more. If anyone has a link please post it, I was not able to find one quickly. :)

So at first thought, this will almost certainly require some core changes. I believe the server restart for model/plugin changes will be the biggest pain point, as others have pointed out. If Container A updates a model, it's saved in the database for others to see, but Container B doesn't. Same with the plugins. I'm not familiar with how other CMSes handle this in a container.
I haven't touched alpha-14 yet, but I think that may have taken care of running it behind a loadbalancer via strapi/strapi#1813. I'm sure there are other challenges on top of these, too. After November 4th I'll be free to start working on my Strapi project again, so I'll make a note to research it a bit more in-depth then, if no one else has started.

Looks like @msgeissler replied before I had a chance to post my comment (I thought GitHub autoloaded comments). Anyway, I wasn't familiar with a Strapi cluster mode, but that sounds like it's a step in the right direction.
I also agree that installing plugins and creating a "golden" image might be a good way to take care of the plugins side of the equation. We'd still need to address models, though. Hopefully that's what this cluster mode will allow.
As for file uploads, that's easily taken care of by using a storage plugin for network storage (cloud or local). However, and I'm new to k8s, I believe having a persistent volume claim could also solve this? k8s would take care of where it goes (S3, Azure, NFS, etc) and you'd just add the claim to the pods.

I really haven't worked with strapi too long. :-D
I completely forgot about the models, I was thinking only of strapi and node plugins.
Models might be a problem if they should be changeable at runtime, but I think that can only be solved by a proper cluster mode and possibly API in strapi itself first. Maybe they have to be stored in the database as well and created from there (they still have corresponding JavaScript code right?), otherwise you might run into problems with models being changed while containers are running and new ones being created after that (how do they know about the change?).
Sharing the models folder between the containers / pods might not work either, as strapi has to know that it should reload them but also has to allow other instances to change them at any time.
I also don't know how other CMS systems handle that.

@synth3tk I feel little bit confused. Could you clarify what you mean by "cluster mode". All what I was able to find about strapi and cluster is node cluster module support (not sure if this will do any good for this issue) and issue about MongoDB cluster :)

@jakubknejzlik I was referencing @msgeissler's comment. I don't recall hearing about it, either, so I was curious if it was something introduced since I stopped working on my project.

I was just mentioning it because I think it would be a requirement to get proper multi-container support. If strapi does not support a cluster environment, neither can strapi in a container. But as I mentioned earlier, I also was not able to find any documentation on that. So for now, I assume that it does not exist yet. The problems mentioned above would most likely be stuff that such a cluster-mode would fix / have to deal with (including many other things probably).

Hi guys,
I'm also new with Strapi, and my first idea was to make my Strapi container immutable as much as I can by developing locally and commit the model changes that trigger a new build (container).
It works well at the moment if I build for the same environment, but I can't reuse the same container for all the environment because it needs to rebuild the plugins with the npm run setup (https://strapi.io/documentation/3.x.x/guides/deployment.html#_2-setup-optional) because I use a different path for the admin on staging and production.
For the database, I use mLab, but I will try MongoDB Atlas before my first release in production.
For the files/media, I will use the S3 plugin also to share most as I can between all the containers.
I don't like to have a container for each environment because that means more testing instead of using only the environment variables to change the behaviour of a unique container, but at the moment, I see only this way to release a Strapi app under a container :(

@Aurelsicoko imho that's very good architecture (better than black-boxing the source codes in some magically loaded dependencies). But there's no easy/possible way how to create final container that I want to distribute...or is there anything like that?
Currently I'm using the UI to generate my model, install plugins, configure the backend stuff etc. If I can do this locally, then wrap the whole generated code and use it to build docker image which will be distributed, we are half way there. But I'm not sure, if this flow is even possible.

No idea, I don't know how this can be done with Docker. We've hired a new lead back-end developer, he'll certainly find a way to solve this issue 👍

@Aurelsicoko I am also interested in this, but I can help too.
I have been a enterprise architect for years, I am an expert in docker and kubernetes and I have also done startups.
I can have a call with your backend developer (if it helps) to come up with a solution that will work with docker and kubernetes. (message me if interested)
My interest is only that I want to use it in docker/kubernetes.

@vinayagg it would be awesome if I can join this call too (if it happens). We are using kubernetes in large portion of our project and this is the only issue that discourage us from using the strapi.

HI,
We just released a full rebuild of our docker image 🎉
We are closing the issues and open PRs to start fresh.
If you feel like something is missing or want to add things feel free to open new PRs ! 💯

@alexandrebodin thanks for update 🎉 . As this comment has been added to multiple recently closed issues, would you mind adding link/explanation how issues mentioned in this conversation are resolved? 🙏

@alexandrebodin may i know where PR? im facing the same issue too, strapi needed to deploy docker/kubernetes, there is no persistent storage at all, so when user create a new content type, it will generate code for the API, but if somehow we restart the docker, everything are gone, how do we solve?

As a Systems Administrator and DEVOPS, I have some knowledge of Docker and Kubernetes and would be happy to team with someone with Strapi experience to achieve the goal of multi-node, self-healing, auto-scaling Strapi on K8S.


GO:0003712    transcription coregulator activity/missing parent

GO:0003712    transcription coregulator activity
Definition (GO:0003712 GONUTS page)
A transcription regulator activity that modulates the transcription of specific gene sets via binding to a DNA-bound DNA-binding transcription factor, either on its own or as part of a complex. Coregulators often act by altering chromatin structure and modifications. For example, one class of transcription coregulators modifies chromatin structure through covalent modification of histones. A second class remodels the conformation of chromatin in an ATP-dependent fashion. A third class modulates interactions of DNA-bound DNA-binding transcription factors with other transcription coregulators. PMID:10213677 PMID:16858867 PMID:24203923 PMID:25957681
is no longer a descendent of
GO:0140110    transcription regulator activity?
I'm guessing that is unintentional?

This was intentional, see https://github.com/geneontology/go-ontology/issues/20862#issuecomment-778089309

But "transcription coregulator activity" is defined as a "A transcription regulator activity"?????

I thought you wanted to move "transcription regulator" from under "molecular function regulator"

Right - the next parent is the root.

I've added the BP 'part of' transcription for coregulator activity.
Is there anything else we should do? I am not sure we can always say that a regulator is a MF regulator.
@colinlog Is this right ?

Actually transcription regulator activity IS NOT a molecular function regulator, it is part_of regulation of transcription. I did this too fast before. I will put the relation back coTF is_a GO:0140110 transcription regulator activity.
see #20862

ha ha, was just going to comment!


Translating RISC-V programs directly from ELF files.

There are many advantages in using standard assemblers and linkers, like:

maturity;
more complete support of assembly language, which in turn allows for support to more high level languages and compilers;
link-time optimizations;
no need to deal with language edge cases (our assembler and linker deals with a number of rust stuff, but it would need even more to support std).

But it comes with a cost, as we need to lift references to text data back into labels, (because powdr operates on a higher abstraction level), and to do that, we need the ELF file to either be a PIE (Position Independent Executable), or to still have the linkage relocation tables (option --emit-relocs of GNU and LLVM linkers).

TODO:

[ ] Add an option in the compile command to select either asm path or elf path;
[ ] Run all tests via elf path, too;
[ ] Bring elf to feature parity with asm, in particular, load debug symbols;
[ ] Add at least one specific test translating from PIE elf, since there is the code path to support it.

CI failing

The other thing that's lost are labels, which I assume are useful for the profiler? @pacheco
For example, for the trivial test we get via asm:
    main:
    trivial_dash_be3334ad2e9c9ee9___dot_Lfunc_begin0:
    .debug loc 338 7 17;
    tmp1 <== jump_dyn(x1);

and via elf:
    main:
    tmp1 <== jump_dyn(x1);


Package.getStylesheetsPath is deprecated.

Store package style sheets in the styles/ directory instead of stylesheets/ in the merge-conflicts package
Package.getStylesheetsPath (/usr/share/atom/resources/app.asar/src/package.js:460:9)
Package.getStylesheetPaths (/usr/share/atom/resources/app.asar/src/package.js:471:32)
Package.loadStylesheets (/usr/share/atom/resources/app.asar/src/package.js:453:38)
<unknown> (/usr/share/atom/resources/app.asar/src/package.js:185:19)
Package.measure (/usr/share/atom/resources/app.asar/src/package.js:165:15)
Package.load (/usr/share/atom/resources/app.asar/src/package.js:179:12)

Atom version 1.0

What version of merge-conflicts are you using? This was fixed in 1.3.0 (#132).


[add-resource] New Skeleton - Open Matter MultiCourse Hub Site

I would like to add this new skeleton package to the Grav Repository, which is also being built using the fantastic new GitHub Actions build script (thank you!).
Here are the project details: https://github.com/hibbitts-design/grav-skeleton-multicourse-hub
Thanks very much,
Paul

Added


import { ThemeProvider, createMuiTheme } from '@material-ui/core' not work

This may be a type related issue.
import { ThemeProvider, createMuiTheme } from '@material-ui/core' cause this error:
ERROR in ./src/app.tsx
Module not found: Error: Can't resolve '@material-ui/core/esm/ThemeProvider' in '\path\to\myproject\packages\bbs\src'
 @ ./src/app.tsx 1:0-65 16:150-164
 @ ./src/index.tsx

ERROR in ./src/app.tsx
Module not found: Error: Can't resolve '@material-ui/core/esm/createMuiTheme' in '\path\to\myproject\packages\bbs\src'
 @ ./src/app.tsx 3:0-67 9:12-27
 @ ./src/index.tsx

And I dig into the source code of @material-ui/core/index.js, I found ThemeProvider and createMuiTheme are not exported. But they are listed in the type file.

[x] The issue is present in the latest release.
[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯

import { ThemeProvider, createMuiTheme } from '@material-ui/core' not work
Expected Behavior 🤔

import { ThemeProvider, createMuiTheme } from '@material-ui/core' works
Steps to Reproduce 🕹

Steps:

code like title.
compile.

Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.10.2

TypeScript
3.9.5

That's not a support request. I'm getting the issue too.

Not sure if this helps but the docs here say you should be importing like this import { ThemeProvider, createMuiTheme } from '@material-ui/core/styles' . Have you tried including the /styles on the end of your import path?

Use import { createTheme } from '@material-ui/core/styles' instead.
And this will solve the issue;
Here is a pieces of code of my project:
const customTheme = createTheme({   palette:{     secondary:purple   } })

@yellowspaceboots  @AyemunHossain
What if I have in code
import { MuiThemeProvider, createMuiTheme } from '@material-ui/core/styles';
but it doesn't get rid me from this error :(
npm -v
8.1.0
node -v
v16.13.0


investigate TinyLlama running on iOS

https://github.com/fdchiu/llamaFramework
iOS:  the app takes 4 seconds to generate one word (token)
Lamma 7B: size  4 GB  MEM: 8 GB

https://github.com/guinmoon/LLMFarm

not applicable to integrate LLM now, will do it in future


[BUG] Jenkins web disappeared

The Jenkins Website somehow got an Unexpected Error upon trying to visit.
Is there a way to upload Lexicon's New Build on TSPG anytime soon?

Hello. This is not a bug at all but I can address this here (hence the invalid lable)
For more context however, Jenkins was hosted on the TSPG server box. It was using up a ton of resources so it was later shut down.
I will be hosting the Jenkins instance elsewhere when the time comes. As for a new version the current version is what is uploaded already on TSPG. There is no new build currently as we have been rebuilding the project from the ground up.
As for an ETA? Soon. Could use more people to help with the building process however to speed things up though!


allowedVendorIds - empty

Hi! I can't understand why or what I do wrong!
const consentData = {
    allowedPurposeIds: [ 1, 2, 3 ],
    allowedVendorIds: [1,2,3,66,77,88,98,415,534],
    cmpId: 7,
    cmpVersion: 1,
    consentLanguage: 'es',
    consentScreen: 3,
    created: new Date(Date.now()),
    lastUpdated: new Date(Date.now()),
    maxVendorId: 747,
    vendorListVersion: 196,
    version: 1,
};

I use method for creating consent string
encodeConsentString(consentData)
I got it but when i use this consent stirng i have no allowedVendorIds
I decode created string and I saw array is empty
here is screenshot

oh my! I'm looking at your code and saw that I'm not sent vendors!


Add AC target temperature adjustment and current temp sensor

Can you please add target temperature adjustment for the AC units?
Currently I can only change the mode but not the target temperature.
Can you also add the temperature sensor so we can see the current temperature?
This would help as I currently the unit just goes back to the last set temperature on the unit and I'd like to be able to schedule different temperatures and different modes depending on time of day.

I would also appreciate this feature. I have a comprehensive passive/active climate control system and can’t complete it without the ability to set target temperature.

The AC unit already support this, if you don't see the option it could be that data is provided in unknown format. Attach integration diagnostic so that I can analyze it.

Home Assistant shows temperature set point and appears to work, however the set point doesn’t change and HA will eventually revert to original set point. I have enabled debug logging. Where do I find the log file?--MichaelOn Mar 19, 2024, at 5:32 PM, ollo69 @.***> wrote:
The AC unit already support this, if you don't see the option it could be that data is provided in unknown format. Attach integration diagnostic so that I can analyze it.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you commented.Message ID: @.***>

I found the diagnostic file (attached)

On Mar 19, 2024, at 6:10 PM, Michael Stein @.***> wrote:
Home Assistant shows temperature set point and appears to work, however the set point doesn’t change and HA will eventually revert to original set point.
I have enabled debug logging. Where do I find the log file?
--Michael

On Mar 19, 2024, at 5:32 PM, ollo69 @.***> wrote:

The AC unit already support this, if you don't see the option it could be that data is provided in unknown format. Attach integration diagnostic so that I can analyze it.
—
Reply to this email directly, view it on GitHub https://github.com/ollo69/ha-smartthinq-sensors/issues/574#issuecomment-2008340876, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASALG6OKN7H5FRPOK4ZAYQDYZDDI7AVCNFSM6AAAAAA24QV576VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBYGM2DAOBXGY.
You are receiving this because you commented.

￼


Gnome-terminal shortcuts

Do you know how to get cltr+enter and cltr+shift+enter to work in gnome-terminal?
seems I need to do something like this but not sure what I'm looking for
https://github.com/joouha/euporie#key-remapping
I confirmed that all three enter, cltr+enter and shift+cltr+enter return the same thing by running showkey -a and they all return ^M or the 0x0d which is the \r character

Hi
I'm afraid I can't find a way to do this in gnome-terminal. You can use Ctrl+r to run cells instead.

cool that worked instead of ctrl+enter, any idea how to get cltr+shift+enter?

I've added this in 0.1.12. I've made the fallback shortcuts match those used in nbterm for consistency, so if you update to 0.1.12 you can use the following:

Key Binding
Command

ctrl-e
Run cell

ctrl-r
Run then select next cell


How to visualize the test results？

How to visualize the test results？

I have the same problem @AceCoooool
how to solve it?


Different prompts would break filepaths_string

I'm using the GPT-3.5-turbo model, and different prompts would cause it to break as GPT3.5 would give different types of responses to the file paths prompt.
The change below appears to get it to behave consistently now.
The default prompt.md that comes with the distribution worked, though when I created a default custom prompt it failed.  When I reduced it to a one sentence prompt, it worked.  making the change below works and adds pretty neat documentation as well.
I tried several different modifications, though if the prompt returned a directory structure it broke (though these file paths support nested directories).  If it returned a description next to each file, it broke too.
"""You are an AI developer who is trying to write a program that will generate code for the user based on their intent.
When given their intent, create a complete, exhaustive list of filepaths that the user would write to make the program.
create at least one filepath for overview, installation, configuration and usage documentation

only list the filepaths you would write, and return them as a python list of strings.
do not add any other explanation, notes, headers or comments, only return one python list of strings.

Do not prefix the list with "Filepaths:"
"""

I was having the same issue. This is what works best for me:
You are an AI developer who is trying to write a program that will generate code for the user based on their intent.

    When given their intent, create a complete, exhaustive list of filepaths that the user would write to make the program.

    only list the filepaths you would write, and return them as a python list of strings to be evaluated by the ast.literal_eval function.
    This is important: do not add any other explanation or notes, only return a python list of strings.

`"""You are an AI developer who is trying to write a program that will generate code for the user based on their intent.
When given their intent, create a complete, exhaustive list of filepaths that the user would write to make the program.

only list the filepaths you would write, and return them as a python list of strings.
[
    "filepath/to/file1",
    "filepath/to/file2",
    etc
]

do not add any other explanation only return a python list of strings.
""`


ReplicationController, ReplicaSet, Deployment, etc. support for Kubernetes SD

I looked through the documentation, but there doesn't seem to be a way to get the desired size of a RC, RS, etc. The API server exports that. Basically, I want to use that number in alerts (is the expected number of pods up?), without having to hard-code the value in Prometheus configuration files.
More in general, the discovery code supports entities such as pods, nodes and services, but has nothing about the new ones added in recent versions of Kubernetes.

Discovery just discovers targets to scrape & ingest metrics from. There is nothing currently exposing these metrics ATM. Sounds like you need a kubernetes exporter that will expose the metrics you require.

Would it be in scope at some point in the future for SD to grab information like that and export it directly, if the configuration requests it? With Borgmon, you'd use the Shardinfo data from BNS:
https://docs.google.com/presentation/d/1X1rKozAUuF2MVc1YXElFWq9wkcWv3Axdldl8LOH9Vik/view#slide=id.g598ef96a6_0_118
This is a basic piece of information for a Kubernetes cluster that it doesn't make a lot of sense to have it as an external component requiring additional maintenance, configuration and meta-monitoring.

Unless it's exposed by the SD as a target, it doesn't belong in SD.

So, the only choice is... a new endpoint or set of metrics on the Kubernetes API server? I can't think of other places that don't involve an exporter.
I guess everyone hardcodes expected shard count in their configurations.

That, or a separate exporter.
Coming from another direction if you alert on having no instance, and on errors/latency being okay that'd also cover you in many cases.

That is how I've set stuff up, alert on service latencies rather than pod count. Going by the recommendations on alerting on what effects UX rather than e.g. arbitrary numbers of pods.

Latency, which needs to be monitored anyway, works in many cases, but there are others where it doesn't apply or isn't easily instrumented, especially infrastructure pods and/or DaemonSets (DNS and, ahem... fluentd).

All information about the state of Kubernetes need improved instrumentation within Kubernetes itself. Since Kubernetes is already using Prometheus for instrumentation, exporters are merely a workaround for a problem that should be fixed elsewhere.
We are currently trying to figure out whether this finds support within the Kubernetes team and will hopefully get to working on it soon.

It would be nice to be able to discover ingresses for the purposes of probing via the blackbox_exporter (much like how services can be used now).

@tcolgate Maybe let's file ingress discovery as a separate issue, it seems more clear-cut as a useful addition.

I believe the new k8 SD covers all this.


Supported Connectors

I would like to know if there is a list of supported connectors for Azure AD Connect.
I know there are several connectors that are available in AAD Connect but if you use them you become not supported.
is SQL connector now supported?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 653f79c0-27ad-1c43-e78d-1db38feadb8c
Version Independent ID: a2c4ab07-2ab5-9172-89bb-e1776a135f79
Content: Connectors in the Azure AD Synchronization Service Manager UI
Content Source: articles/active-directory/hybrid/how-to-connect-sync-service-manager-ui-connectors.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

@amel00 Thanks for your feedback! We will investigate and update as appropriate.

@amel00 I am not aware if there is any list of supported connectors for Azure AD connect.
@billmath Can you please guide if any list supported connectors are available ?

Yes, you can see the supported configurations here:  https://docs.microsoft.com/en-us/azure/active-directory/hybrid/plan-hybrid-identity-design-considerations-tools-comparison#on-premises-to-cloud-synchronization
Currently the only supported connectors are the Azure AD connector and the generic LDAP connector under specific conditions.  Additional connectors are planned but are currently only supported on FIM or MIM.  Thanks!

#please-close

@amel00 We will now proceed to close this thread. If there are further questions regarding this matter, please tag me in your reply. We will gladly continue the discussion and we will reopen the issue..


Can't quit pools when reward account is non-empty

Context

Information
-

Version
All

Platform
All

Installation
Sources

Steps to Reproduce

Join a pool
Wait until there's some reward in the reward account.
Quit the pool

Expected behavior

To be clarified. The wallet should either return a clear error explaining that the reward account must be emptied first. Or, the reward should be automatically redeemed when quitting. The latter is perhaps a little nicer in terms of user experience (although quite implicit) but also require more work to fix.
Actual behavior

The server returns a 500 Internal Server Error after getting an error from the ledger.

Resolution

QA

Reminder to whoever is working on this - uncomment the second part of the "STAKE_POOLS_JOIN_04 - Rewards accumulate and stop" test scenario once this is fixed.

@rvl yes and no :s.
In order to "fix" this, I am going to:

Wrap up the work on #1821, so that rewards can be turned into UTxO
Make the server fail with a proper error "you need to consume your reward before quitting".

Then, being able to automatically consume the rewards when quitting will be done as part of a next U/S. Note that we are currently discussing the existence of this "quit" endpoint, which in essence, is against the protocol. Instead, it would probably end-up being merged with the migration endpoint, so that quitting only happens behind the scene AND, only when a user is migrating his wallet (because we don't want to de-register stake key under normal circumstances).

When quitting the pool and having rewards earned there is now following error being shown:
Code = 403,
Message = {"code":"non_null_rewards","message":"It seems that you're trying to retire from delegation although you've unspoiled rewards in your rewards account! Make sure to withdraw your 33080446 lovelace first."}

One is able to join another pool even if he earned rewards :ok_hand: .


cluster: user ClusterInfo instead of Ping to find live node.

This check is much stricter since it verifies that node at least knows how to handle CLUSTER INFO command.

LGTM


Make minutes uneditable

A user does not have a feature to have a greyed out :00 on the graphic, to avoid entering minutes if they don't want to.
Also the user needs to press tab several times to jump to the next component.

thank you for your feedback
I will work on them to fix the problem of tabs.
but for minute input I have some questions:
1- how do you expect minutes to be placed in value if the user did not input it? 12 or 12:00
2- how do you want the user to see his inputted value in the input box? 12 or 12:00

Thank you for your response. I would like it to be 12 on the clock but
12:00 on the input box.
Would it also be possible to get numbers to say '06' instead of 6?
On Mon, 21 Nov 2022 at 19:44, mohammad javad bathaei <
@.***> wrote:

thank you for your feedback
I will work on them to fix the problem of tabs.
but for minute input I have some questions:
1- how do you expect minutes to be placed in value if the user did not
input it? 12 or 12:00
2- how do you want the user to see his inputted value in the input box? 12
or 12:00
—
Reply to this email directly, view it on GitHub
https://github.com/javadbat/jb-time-input/issues/4#issuecomment-1322561999,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A3KPKVBDLC5JA2XK5QFKKKTWJPGLTANCNFSM6AAAAAARCS7IAE
.
You are receiving this because you authored the thread.Message ID:
@.***>

yes of course

first adding frontal zero to time-picker
https://github.com/javadbat/jb-time-picker/commit/54763cdabc0afcc62bbdc80b74bbe1011722d936

add optional time unit
https://github.com/javadbat/jb-time-picker/commit/f55fc03009d8ead1c529f54999d2f7428a0c1a8c

Thank you so much for this. Would it be possible to publish this to npm?

ofcourse, its just need more work to do and need testing, but I will publish it as soon as possible

you can use frontalZero and optionalUnits as written on documentation


About backend

Is this linked to backend, like receiving the messages and storing somewhere and respondimg to the request.

It is only the client ui and related interaction functionalities. In the demo app, it is client side generated data. No backend linked.


How do I upgrade .compile and .toService to finch 0.34?

Previously I had this code:
// ServerState is a custom class of mine
class ServerState { /* ... */ }

def getEndpoints(state: ServerState) =
  foo(state) :+: bar(state) :+: baz(state) /* and many more */

def getCompiledOverallEndpoint(state: ServerState): Endpoint.Compiled[IO] = {
  Bootstrap[IO]
    .serve[Application.Json](getEndpoints(state))
    .compile // ERROR: .compile doesn't exist
}

def getServiceForState(state: ServerState): Service[Request, Response] = {
  val filters = Function.chain(Seq(exceptionLogging, logging))
  Endpoint.toService(filters(getCompiledOverallEndpoint(state))) // ERROR: .toService doesn't exist
}

However, after updating to finch 0.34.1 the .compile and toService methods seem to no longer exist. How do I upgrade my code?

I think those changes are from 0.34.0: https://github.com/finagle/finch/releases/tag/v0.34.0

You can call filter and toService directly on Bootstrap now:
Bootstrap[IO]
    .serve[Application.Json](getEndpoints(state))
    .filter(Function.chain(Seq(exceptionLogging, logging)))
    .toService

And it returns a Resource. Those changes were necessary to update to Cats Effect 3.


Autoplay video doesn't autoplay

Describe the bug
Hi! When lazyloading a video with the autoplay attribute set the video doesn't always autoplay. For me in testing this reliably doesn't play on iOS 12, Safari.
When reviewing your sample code below I can also sometimes get it to autoplay, sometimes not in Google Chrome Version 78.0.3904.87 and never in Safari Version 13.0.3 (146<IP_ADDRESS>.1)
https://www.andreaverlicchi.eu/lazyload/demos/video.html
Thanks.
To Reproduce
Steps to reproduce the behavior:

Go to https://www.andreaverlicchi.eu/lazyload/demos/video.html
Scroll down
Video doesn't autoplay

LazyLoad version

Version 12.3.0, with no polyfill.

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: iPhone 8
OS: iOS 12
Browser Safari

Additional context
Can see the first frame of the video load as the poster, and the .loaded CSS class is added.
On you text page in the console I can see:
1573219149303 "🚪 EXITED" "https://archive.org/download/BigBuckBunny_124/Content/big_buck_bunny_720p_surround.mp4"
video.html:80<PHONE_NUMBER>451 "🔑 ENTERED" "https://archive.org/download/BigBuckBunny_124/Content/big_buck_bunny_720p_surround.mp4"
video.html:80<PHONE_NUMBER>453 "👁 REVEALED" "https://archive.org/download/BigBuckBunny_124/Content/big_buck_bunny_720p_surround.mp4"
video.html:80<PHONE_NUMBER>126 "👍 LOADED" "https://archive.org/download/BigBuckBunny_124/Content/big_buck_bunny_720p_surround.mp4"
video.html:80<PHONE_NUMBER>127 "✔ FINISHED" null

After a bit more testing, was oddly that the playsinline attribute seems to be required for reliable playback.


bug: terminal: pasting a command with a \n at end messes up cursor when scrolling thru previous commands

Describe the bug
See title
To Reproduce
Steps to reproduce the behavior:

Copy a command, e.g., from Kinode book, with a newline at the end of it.
Paste into terminal.
.
Scroll up to command history.
Note cursor is bound to far left until you hit .

Expected behavior
Not sure. Maybe show the line + newline with cursor on second line?

fixed in #288


Story layout breaks for subcomponents with a CSS Grid parent

Describe the bug
I know, awkward title.
If Component has an element with display: grid, that style is retained for the .Component div created when rendering stories for Component/Subcomponent. However, because Storybook places the "Story Source" area  as a sibling of Subcomponent, "Story Source" ends up being put into the next empty grid cell.
Cheers.
To Reproduce
Steps to reproduce the behavior:

Create Component with an empty div, apply display: grid, and create a few rows/columns
Create Component/Subcomponent and a story for it
Open Subcomponent's story.

Expected behavior
"Story Source" should retain its usual width, filling the "middle" panel. It definitely should not, IMO, be put inside any DOM created for rendering the story.
Screenshots
"Story Source" is put into the container's grid:

DOM layout - I've marked the parent component, the currently-storied subcomponent, and the "Story Source" div:

Code Snippets
.Component {
  display: grid;
  height: 300px;
  width: 600px;
  grid-template-rows: 24px 1fr;
  grid-template-columns: 150px 450px;
  grid-template-areas:
    "header header"
    "list   content";
}

----
Component.jsx renders:

{this.renderHeader()}

{this.renderList()}

{this.renderContent()}

System:

OS: Ubuntu 18.04
Device: ASUS laptop
Browser: Chrome, Firefox - both fairly recent versions
Framework: React
Version: Storybook 4.1.1

Never mind, it was an issue with a custom decorator we're using. Sorry for the noise.


fatal error: azure_c_shared_utility/xlogging.h: No such file or directory (same issue as #18981)

Using simulated data
-- Configuring done
-- Generating done
-- Build files have been written to: /home/pi/src/iot-hub-c-raspberrypi-client-app
Scanning dependencies of target app
[ 20%] Building C object CMakeFiles/app.dir/main.c.o
/home/pi/src/iot-hub-c-raspberrypi-client-app/main.c:9:45: fatal error: azure_c_shared_utility/xlogging.h: No such file or directory
#include <azure_c_shared_utility/xlogging.h>
^
compilation terminated.
CMakeFiles/app.dir/build.make:62: recipe for target 'CMakeFiles/app.dir/main.c.o' failed
make[2]: *** [CMakeFiles/app.dir/main.c.o] Error 1
CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/app.dir/all' failed
make[1]: *** [CMakeFiles/app.dir/all] Error 2
Makefile:83: recipe for target 'all' failed
make: *** [all] Error 2
pi@raspberrypi:~/src/iot-hub-c-raspberrypi-client-app $

@xsqian Hello, we are willing to help. Could you please share the document you are referring to for this issue? Thank you.

@xsqian we will close for now. If you are still having issues please open a new issue and share the doc you are having troubles with.


Add basic tests for all predefined steps

Codecov Report
Base: 74.87% // Head: 85.04% // Increases project coverage by +10.17% :tada:

Coverage data is based on head (d00d4fa) compared to base (59468b4).
Patch coverage: 99.54% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #1       +/-   ##
===========================================
+ Coverage   74.87%   85.04%   +10.17%
===========================================
  Files          37       48       +11
  Lines        1417     1605      +188
  Branches      199      216       +17
===========================================
+ Hits         1061     1365      +304
+ Misses        301      174      -127
- Partials       55       66       +11

Impacted Files
Coverage Δ

src/dwas/predefined/_twine.py
88.88% <66.66%> (+32.63%)
:arrow_up:

src/dwas/predefined/_black.py
92.85% <100.00%> (+0.54%)
:arrow_up:

src/dwas/predefined/_isort.py
100.00% <100.00%> (+41.66%)
:arrow_up:

src/dwas/predefined/_pylint.py
100.00% <100.00%> (+46.15%)
:arrow_up:

src/dwas/predefined/_unimport.py
92.85% <100.00%> (+0.54%)
:arrow_up:

tests/__init__.py
100.00% <100.00%> (ø)

tests/_utils.py
100.00% <100.00%> (ø)

tests/conftest.py
100.00% <100.00%> (ø)

tests/predefined/mixins.py
100.00% <100.00%> (ø)

tests/predefined/test_black.py
100.00% <100.00%> (ø)

... and 26 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Return exit(1) after a failed krakend check command

The krakend check command does not return a status 1 when the configuration is invalid.
(moved from https://github.com/devopsfaith/krakend/issues/236)

duplicated by #2


更新 advisor, advice, ObjectProxyFactory

resolved https://github.com/Exodia/aop/issues/4

resolved https://github.com/Exodia/aop/issues/6


Add Sphinx documentation skeleton.

You can see the built documentation at https://hpy.readthedocs.io/en/feature-add-sphinx-docs/.

LGTM


Deploy Fails When Trigger is of Type Pull Request

I am getting a "Not Found" error when using the Github Action to kick off a deploy when using the pull request trigger. Here is the output I'm seeing (modified feature branch name and sha to make sure I'm not giving away any unnecessary information):
set environment for vercel cli
set env variable : VERCEL_ORG_ID
set env variable : VERCEL_PROJECT_ID
##[debug]head : [object Object]
##[debug]The head ref is: feature/example-branch
##[debug]The head sha is: example-sha
Error: Not Found

and here is the code from my workflow file:
name: Pull Request Opened, Synchronized, or Reopened

on:
  pull_request

jobs:
  buildAndDeploy:
    # Using Vercel's Github Action to kick off deployments
    # Documentation here: https://github.com/marketplace/actions/vercel-action
    name: Build & Deploy
    runs-on: ubuntu-latest
    steps:
      - name: Checkout the current branch
        uses: actions/checkout@v2
      - uses: amondnet/vercel-action@v20
        with:
          vercel-token: ${{ secrets.VERCEL_TOKEN }}
          github-token: ${{ secrets.ACTIONS_TOKEN }}
          vercel-org-id: ${{ secrets.VERCEL_ORG_ID }}
          vercel-project-id: ${{ secrets.VERCEL_PROJECT_ID }}
          scope: ${{ secrets.VERCEL_ORG_ID }}
          github-comment: false

Yeah, this happened to me as well, did you find a solution?

This happened to me, as well, and ended up being because my GitHub Actions secrets were not properly set up.  Maybe verify that you've got all the correct secrets.

This can happen if you're using a private repo and your Github token doesn't have the necessary scopes.


Incorrectly rendered markdown in IdentityBinaryExpression

Description of the problem / feature request:
IdentityBinaryExpression markdown still includes java {.good} and java {.bad}. These tags were supposed to be removed in issue #962 (commit - e43a577723a52de9d000f18b553bc55616d9e5df). This leads to the markdown rendering incorrectly.
http://errorprone.info/bugpattern/IdentityBinaryExpression

Feature requests: what underlying problem are you trying to solve with this feature?
Fix the IdentityBinaryExpression markdown so the example is rendered correctly.
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
IdentityBinaryExpression includes java {.good} and java {.bad} tags. This causes issues rendering the markdown.
What version of Error Prone are you using?
I'm not using Error Prone. This is about the errorprone.info documentation.
Have you found anything relevant by searching the web?
Yes. I found the related issue #962 and commit (e43a577723a52de9d000f18b553bc55616d9e5df). The commit (e43a577723a52de9d000f18b553bc55616d9e5df) does not include changes to IdentityBinaryExpression.md.

This has been fixed: https://github.com/google/error-prone/blob/0a645f95de5942ec0e389e16d3c4217b20f31e40/bugpattern/IdentityBinaryExpression.md


kepler:kepler: not working for grafana dashboard

kepler:kepler: are not working for the grafana dashboard in hack/dashboard/assets/kepler/dashboard.json,
When I replace "kepler:kepler:"with  a single "kepler:" it will work.
example:
Wrong
"expr": "kepler:kepler:container_joules_total:consumed:24h:all * $watt_per_second_to_kWh",
Right
"expr": "kepler:container_joules_total:consumed:24h:all * $watt_per_second_to_kWh",

@fnoorden Are you using operator's release-0.9.2? If yes then the latest dashboard.json might not work as expected since we updated the expression to contain Kepler instance name as well i.e kepler:<instance_name>:container_joules_total....

@vprashar2929  That's correct, I am using kepler-operator v0.9.2 from dev-preview channel.
Should I use a different version of the operator?

For configuring Grafana as of now you can checkout v0.9.2 and setup till the time we have the new operator release

Thx a lot


Create ltib

@rarespescripturi lib/domains/ro/ltib: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@rarespescripturi First stage of verification passed, official domain is ltib.ro as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@rarespescripturi Thank you for your patience while waiting for a review and processing your request. Pull request merged.


invoke_sync method throws an error

Hello, I am trying to run below snippet, it is throwing an error.
from starknet_py.contract import Contract
from starknet_py.net.client import Client
client = Client("testnet")
contract_address = "0x01336fa7c870a7403aced14dda865b75f29113230ed84e3a661f7af70fe83e7b"
key = 12345678
contract = Contract.from_address_sync(contract_address, client)
invocation = contract.functions["set_value"].invoke_sync(key, 7, max_fee=500)
invocation.wait_for_acceptance_sync()
_Got BadRequest while trying to access https://alpha4.starknet.io/gateway/add_transaction. Status code: 500; text: {"code": "StarknetErrorCode.UNSUPPORTED_SELECTOR_FOR_FEE", "message": "All transactions should go through the execute entrypoint."}.
Traceback (most recent call last):
File "/home/iodishar/.local/lib/python3.8/site-packages/services/external_api/client.py", line 121, in _send_request raise BadRequest(status_code=response.status, text=text)
services.external_api.client.BadRequest: HTTP error ocurred. Status: 500. Text: {"code": "StarknetErrorCode.UNSUPPORTED_SELECTOR_FOR_FEE", "message": "All transactions should go through the execute entrypoint."}
Traceback (most recent call last):
File "app/test.py", line 10, in
invocation = contract.functions["set_value"].invoke_sync(key, 7, max_fee=500)
File "/home/iodishar/.local/lib/python3.8/site-packages/starknet_py/utils/sync/sync.py", line 15, in impl
return sync_fun(*args, **kwargs)
File "/home/iodishar/.local/lib/python3.8/site-packages/asgiref/sync.py", line 218, in call
return call_result.result()
File "/usr/lib/python3.8/concurrent/futures/_base.py", line 437, in result
return self.__get_result()
File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
raise self._exception
File "/home/iodishar/.local/lib/python3.8/site-packages/asgiref/sync.py", line 284, in main_wrap
result = await self.awaitable(*args, **kwargs)
File "/home/iodishar/.local/lib/python3.8/site-packages/starknet_py/contract.py", line 354, in invoke
return await prepared_call.invoke(max_fee=max_fee, auto_estimate=auto_estimate)
File "/home/iodishar/.local/lib/python3.8/site-packages/starknet_py/contract.py", line 241, in invoke
response = await self._client.add_transaction(tx=tx)
File "/home/iodishar/.local/lib/python3.8/site-packages/starknet_py/net/client.py", line 248, in add_transaction
return await self._gateway.add_transaction(tx, token)
File "/home/iodishar/.local/lib/python3.8/site-packages/starkware/starknet/services/api/gateway/gateway_client.py", line 16, in add_transaction
raw_response = await self._send_request(
File "/home/iodishar/.local/lib/python3.8/site-packages/services/external_api/client.py", line 121, in send_request
raise BadRequest(status_code=response.status, text=text)
services.external_api.client.BadRequest: HTTP error ocurred. Status: 500. Text: {"code": "StarknetErrorCode.UNSUPPORTED_SELECTOR_FOR_FEE", "message": "All transactions should go through the execute entrypoint."}

Hello, to send transactions with max_fee > 0 you should use AccountClient instead of Client.

Thanks for getting back.  I have created a testnet account in ArgentX. I would like to use that account to interact with StarkNet, though starknetpy.  This is what I have tried:
from starknet_py.net import AccountClient
private_key =<PHONE_NUMBER>109126366631341857992198869776879917929289470748436139290217987122
acc_client = AccountClient.create_account_sync(net="testnet", private_key=private_key)
print(acc_client.get_balance_sync()) # this prints 0. Instead of 0.04ETH, so something is off...
contract_address = "0x01336fa7c870a7403aced14dda865b75f29113230ed84e3a661f7af70fe83e7b"
contract = Contract.from_address_sync(contract_address, acc_client)
invocation = contract.functions["set_value"].invoke_sync(key, 7, max_fee=500)
invocation.wait_for_acceptance_sync()
Is this the right way to do it? It would be supper helpful if you can provide short snippet on how to interact with StarkNet, using existing ArgentX accounts. View calls work fine, but I am unable to call invoke functions... Thanks!

We should definitely update the docs.
Here is how to create an AccountClient if it is already deployed:

AccountClient(
address=address,
key_pair=KeyPair.from_private_key(private_key),
net=net,
chain=chain)

You can create key_pair this way or if you have a private and public key:
key_pair = KeyPair(private_key, public_key)
In your case net is "testnet" and chain is StarknetChainId.TESTNET
The rest of your code seems fine, so it should work.

Thank you. I was able to initialize the existing account.
from starknet_py.contract import Contract
from starknet_py.net import AccountClient
from starknet_py.net.models import StarknetChainId
from starknet_py.net.signer.stark_curve_signer import KeyPair
private_key = 0x7B2B0A883AE59D5DFB31B7256F3064961BE7C3C54179E26F30AFE4964F8BC32
account_address = 0x06C55071C86BC33C0C8D95A03190941641E664C43C228E0B0389F6566BDF0965
key_pair = KeyPair.from_private_key(private_key)
acc_client = AccountClient(
address=account_address,
net="testnet",
chain=StarknetChainId.TESTNET,
key_pair=key_pair,
)
print(acc_client.get_balance_sync()) #this now prints 0.04ETH as expected!
But I still have a problem with the second part, when I try to call invoke_sync.  set_value method exists on the contract and I am able to call it directly from voyager.
contract_address = 0x01336FA7C870A7403ACED14DDA865B75F29113230ED84E3A661F7AF70FE83E7B
key = 1234
contract = Contract.from_address_sync(contract_address, acc_client)
invocation = contract.functions["set_value"].invoke_sync(key, 7, max_fee=500)
invocation.wait_for_acceptance_sync()
Here is the error. Thanks again for your help.
File "app/test.py", line 27, in
invocation = contract.functions["set_value"].invoke_sync(key, 7, max_fee=500)
File "/home/.local/lib/python3.8/site-packages/starknet_py/utils/sync/sync.py", line 15, in impl
return sync_fun(*args, **kwargs)
File "/home/.local/lib/python3.8/site-packages/asgiref/sync.py", line 218, in call
return call_result.result()
File "/usr/lib/python3.8/concurrent/futures/_base.py", line 437, in result
return self.__get_result()
File "/usr/lib/python3.8/concurrent/futures/_base.py", line 389, in __get_result
raise self._exception
File "/home/iodishar/.local/lib/python3.8/site-packages/asgiref/sync.py", line 284, in main_wrap
result = await self.awaitable(*args, **kwargs)
File "/home/.local/lib/python3.8/site-packages/starknet_py/contract.py", line 354, in invoke
return await prepared_call.invoke(max_fee=max_fee, auto_estimate=auto_estimate)
File "/home/.local/lib/python3.8/site-packages/starknet_py/contract.py", line 241, in invoke
response = await self._client.add_transaction(tx=tx)
File "/home/.local/lib/python3.8/site-packages/starknet_py/net/account/account_client.py", line 159, in add_transaction
return await super().add_transaction(await self._sign_transaction(tx))
File "/home/.local/lib/python3.8/site-packages/starknet_py/net/account/account_client.py", line 135, in _sign_transaction
execute_tx = await self._prepare_execute_transaction(tx)
File "/home/.local/lib/python3.8/site-packages/starknet_py/net/account/account_client.py", line 117, in _prepare_execute_transaction
[execute_abi] = [a for a in abi if a["name"] == "execute"]
ValueError: not enough values to unpack (expected 1, got 0)

so looks like ArgentX use proxy contracts that point to actual OpenZeppelin contract implementation.  Does Starknet_py support this type of setup for ClientAccount?

Thanks for the information. We checked it and now it is working properly. If you want to use it you can wait until the next release, or take it from our development branch.

ok thanks! I will wait for the release. I found a work around meanwhile.


Figure out the output section

Deliverables:

[ ] Output window basically has 2 components, a pie chart and a message, implement pie chart first, use the data from Expense context
[ ] implement the final message as to whi owes whom how much

okk


Probes don't support trailing slash

When the probe endpoints are accessed with a trailing slash (i.e. /startup/), the request gets a 404. Without trailing slash (i.e. /startup) they work. I think we should support trailing slash.

fixed in 0.9.2


feat: add release-it and commitlint

add release-it and commitlint to auto generate changelog

Thanks!


Compile Error " XXX has no member named ‘GetFHE’"

I encountered an error:
error: ‘using element_type = class lbcrypto::SchemeBase<lbcrypto::DCRTPolyImpl<bigintdyn::mubintvec<bigintdyn::ubint<long unsigned int> > > >’ {aka ‘class lbcrypto::SchemeBase<lbcrypto::DCRTPolyImpl<bigintdyn::mubintvec<bigintdyn::ubint<long unsigned int> > > >’} has no member named ‘GetFHE’
  386 | derivedPtr = dynamic_cast<FHECKKSRNS*>(context->GetScheme()->GetFHE().get());

while compiling the project. It seems the GetFHE method does not exist. I was wondering if it is due to the mismatch between the OpenFHE lib (v1.1.3) and the one that was used during dev since the OpenFHE is still under heavy dev.

Hello,
thank you very much for opening the issue.
Indeed, I used a custom forked version of OpenFHE in order to have access to GetFHE() function.
I commented those two lines in the last commit, they were supposed to clear from memory some bootstrapping pre computations ($\approx 1$GB of data), it should now work with any OpenFHE instance.
Feel free to close the issue if you are able to compile.

Thanks for your reply. It could compile successfully now.


Added category field

What is the change?
Added category input in /compose route, filtering method in homepage and /category route for displaying the filtered categories. Also I have intended code and added comments in category.ejs file
Related issue?
close: #224
Old PR: #417
How was it tested?
Tested thoroughly in localhost and is UI is responsive.
Checklist:
Before you create this PR, confirm all the requirements listed below by checking the checkboxes [x]:

[x] Have you followed the Contribution Guidelines while contributing.
[x] Have you checked there aren't other open Pull Requests for the same update/change?
[] Have you made corresponding changes to the documentation?
[x] Your submission doesn't break any existing feature.
[x] Have you tested the code before submission?

Screenshots or Video:
Add a screenshot or demo video if appropriate.

change base branch to develop

Ive made that change now👍


V2 imports fix

Updated the import paths, and the tests pass.
Could you run the tests on this aswell?

The tests passed here too.

I also tried to create project with both v1 and v2, that it worked.
V1
go get<EMAIL_ADDRESS>
V2
go get<EMAIL_ADDRESS>

Thanks again @DagW!


Add fractions library

Looks like we had the same idea at the same time: https://github.com/Araq/Nim/pull/1840

I guess I should've been more persistent :) Araq/Nim#1825. Do you want me to merge this into your pull request?

I don't know if the pull request will even be accepted.

Still want me to merge this? If so, merge with origin/master please.

Let's wait until Araq/Nim#1840 gets resolved - if it gets merged into Nim, then I don't see any reason to keep this package and we can close the pull request, but if it gets rejected then it should be merged in.

Araq/Nim#1840 was merged, so this package is irrelevant.


OPENIG-xxx Test using IG snapshot as the underlying docker image

Test using IG snapshot, buit by PIT1_TEST PR as the underlying IG docker image (then tested via SAPIG unit tests).

This is not to be merged...


Add assert.isEnumerable/assert.isNotEnumerable macro

Sometimes you define properties using Object.defineProperty and set the enumerable flag to false.
For this I would like to have an assertion that checks whether a specific property is enumerable.
ATM I am using a custom function that Object.keys(o) and tests whether the specified key is available but it would be nice to have it readily available in vows as well.
Here is the coffee-script version I am currently using
assert.isEnumerable = (obj, key, message = null) ->

    if obj is undefined or obj is null

        throw new TypeError 'obj is null or undefined'

    if key is undefined or key is null or key == ''

        throw new TypeError 'key is undefined or null or the empty string'

    if not (key in Object.keys obj)

        assert.fail null, null, message || "key '#{key}' is not enumerable", "isEnumerable", assert.isEnumerable

assert.isNotEnumerable = (obj, key, message = null) ->

    if obj is undefined or obj is null

        throw new TypeError 'obj is null or undefined'

    if key is undefined or key is null or key == ''

        throw new TypeError 'key is undefined or null or the empty string'

    if key in Object.keys obj

        assert.fail null, null, message || "key '#{key}' is enumerable", "isNotEnumerable", assert.isNotEnumerable

TIA

Since this was already integrated I will close the issue, if you don't mind.

Not a problem @silkentrance! Will respond to all your other issues / PRs soon. Very busy week for me :8ball:


External login source becomes disabled every now and then

Gitea version (or commit ref): 1.14.2 (Docker image)
Git version: (Whatever's included in the Docker image, does not seem to be relevant)
Operating system: Linux (Docker)

Database (use [x]):

[ ] PostgreSQL
[X] MySQL
[ ] MSSQL
[ ] SQLite

Can you reproduce the bug at https://try.gitea.io:

[ ] Yes (provide example URL)
[X] No

Log gist:

Did not find any mention in log, but this was running at production without debugging logs turned on. Can turn them on for a while if desired.
Description

For some reason, is_activated is sometimes reset to 0 for our primary login_source. Although I cannot rule out external causes completely (i.e. some weird issue with MySQL replication) my suspicion is that Gitea makes this change (e.g. when the login source is temporarily unavailable?).
Screenshots

This is what login_source looks like after the source was deactivated (the first two sources are deliberately disabled, the 'bouncer' login source is the one that becomes disabled every now and then):

Is there a SQL log to change the table?

Not in the current logs (I disabled detailed SQL logging a while ago). Will check logs when it happens again. Anyone an idea about places in Gitea code that might make this change? (I could then check these..)

I suspect this is intentional on behalf of Gitea, in 1.14 there was a change that instead of failing via panic when an oidc auth source is not available on startup, Gitea would instead just disable the auth source (to at least allow the binary to start).

Hm, any idea how (or where in the code) it checks this? Why does it need OIDC auth on startup and could that check be disabled?

I am experiencing the same issue, probably when a node restarts and gitea startup is faster than keycloak (no redundancy). So this would follow the scenario described by techknowlogick. I am also interested to know if this check can be disabled.

@pixelspark @vosdim-supportsquare the disabling occurs as part of #14802.
Prior to this Gitea would simply Fatal and die.
Given that scenario disabling is clearly better.

I think a different approach is possible (re-attempt registration at time of login) but it means we will need to add locking to our oauth2 provider implementation otherwise there will be serious data races. (Some of which are already present but this means that they're actually more likely to cause trouble.)
I am currently in the middle of refactoring the login sources for 1.16 so having now seen these races I will be able to add changes in to ameliorate them - but backporting will be difficult.

I would also note that no-one has told us the contents of the Critical log entry when Gitea explains that it is disabling the login source.
It would be helpful to see it.


Generic return type not respected

The following example illustrates how generic return type information is lost:
// @flow
type Vehicle = {
    name:string;
}

type ClassReference<T> = {
    id: string;
}

function loadIt<T>(ref: ClassReference<T>):T {
    return ({name: 'Ford'}:any)
}

let VehicleClassRef : ClassReference<Vehicle> = {id: 'vehicle'}

let loaded = loadIt(VehicleClassRef)
loaded.nonExisting

let loadedAsVehicle: Vehicle = loadIt(VehicleClassRef)
loadedAsVehicle.nonExisting

An error should occur at loaded.nonExisting. However, the error only occurs at the last line (where the variable has been casted explicitely).

Types declared with type are structural, not nominal, so compatibility between them is considered on the basis of their properties. Since you didn't use T in any of the properties of ClassReference, T has no effect on the typing, and the type of loadIt is effectively loadIt<T>(ref: {id: string}): T which is a function that literally gives you whatever you want (which is a little nonsensical).
Classes are nominal, so if you want T to have an effect on typing even though it doesn't occur in any properties or methods, use a class instead. This works, for example:
type Vehicle = {
    name:string;
}

class ClassReference<T> {
    constructor(id: string) {}
}

function loadIt<T>(ref: ClassReference<T>):T {
    return ({name: 'Ford'}:any)
}

let VehicleClassRef : ClassReference<Vehicle> = new ClassReference('vehicle')

let loaded = loadIt(VehicleClassRef)
loaded.nonExisting

let loadedAsVehicle: Vehicle = loadIt(VehicleClassRef)
loadedAsVehicle.nonExisting

@jesseschalken Thanks for these detailed insights! We just switched to classes and everything works as expected.


Consider how we might show failed hosts/containers/etc

Right now failed nodes don't appear in scope. We could consider something along the lines of showing greyed out containers for hosts that have gone away (keeping the last report from a host), but to us it will be hard to differentiate a host failing from a host being turned down.

This would also help prevent the UI going blank when report generation takes too long, such as when the host is under heavy load.


Bug Report: image_from_key

Describe the bug
I have an unique ID of an image. And want to get some properties of this image. As documentation described, I use the image_from_key('1104069130447934')  function. But this return 'NoneType' object is not iterable. However, when I put the url https://www.mapillary.com/map/im/1104069130447934, I got the image.  What should I do？
To Reproduce
import mapillary.interface as mly
my_token = 'MLY|5175886149161658|4099af83a040b4c64a3891bdcc8314cf'
mly.set_access_token(my_token)
mly.image_from_key('1104069130447934')
 'NoneType' object is not iterable

Expected behavior
A clear and concise description of what you expected to happen
Screenshots

Additional context
Add any other context about the problem here

Hi, @neverland-haha! You seemed to have closed this issue. Was this resolved for you? What was the fix? Any way I can help you over this?
Let me know and thanks!

Sorry for commenting on a close issue. I had the same issue and I think the issue is that fields is set to None by default.
https://github.com/mapillary/mapillary-python-sdk/blob/904942b446bc94c3d5247af3119b542a90a2b400/src/mapillary/interface.py#L907C45-L907C49
It should be [] instead of None


Performance improvement

this branch will track whatever performance improvements I can come up with and depends on #14 .
I will only add here changes that provably improve the performance in the tests available to me.
I will also later add the tests in a separate branch, including the setup to check performance.

this is an ongoing PR I think I have a lot to contribute in terms of performance stuff :) I am trying to understand the characteristics of the performance. so far it seems like parallelizing does not add any speed. I have had a local version that did that and really even on huge tests the bottleneck is the test file parsing. there must be better ways to improve the speed before resorting to parallelism even if it is quite easy to implement.

I will add some changes that add tests, some performance metrics :)

Could you rebase this? A lot of the changes seem out of date (copies of your first PR?) and some new stuff has been added.

the changes in this branch were merged already... would have been easier to track if merge policy was a bit different ;-)


💡 Feature: Enable video fullscreen

Type of Feature
No response
Current Behavior
Currently, the video player has the fullscreen option display in the UI but it does not make the video full screen.
Suggested solution
Implement video fullscreen, so that we can visualize the video on the entire application window.
Additional Context
No response

move to Gahara-Editor/gahara


code

请问什么时候能公布代码？
When will the code be made public？

请问什么时候能公布代码？
When will the code be made public?

Next week! Please wait for a while.


Add pydantic type for validating and deserializing S3FF values

This library currently provides the s3_file_field.rest_framework.S3FileSerializerField for downstreams to use with Django Rest Framework. However, some downstreams are now using pydantic instead of DRF serializers, e.g. when using django-ninja for REST APIs.
This PR provides the pydantic equivalent serialization helper, to be used by downstreams as follows:
from pydantic import BaseModel
from s3_file_field.pydantic import S3FileFieldValue

class MyModel(BaseModel):
    my_file_field: S3FileFieldValue

When instantiated, this model's my_file_field value will be validated and converted such that it can be passed directly into an S3FileField Django model field.

Yikes, guess this approach only works in Python 3.9+.


Split integer and value check into separate if statements

Remove the possibility that a comparison will be done between a string and an integer by failing earlier
Fixes:
2015-10-07 09:42:19,045 ERROR [puppet-server] Puppet Evaluation Error: Comparison of: String < Integer, is not possible. Caused by 'A String is not comparable to a non String'.

Closes https://github.com/arioch/puppet-keepalived/issues/79

@arioch can we get a merge on this? We're unable to use this module with puppet 4 until this is resolved.

This PR did not work for me as is on puppet 4. I had to nest the second if statements into the previous one. ie:
  if (!is_integer($virtual_router_id)) {
    fail('virtual_router_id must be an integer >= 1 and <= 255')
    if ($virtual_router_id < 1 or $virtual_router_id > 255) {
      fail('virtual_router_id must be an integer >= 1 and <= 255')
    }
  }

Could you rebase that onto current HEAD?

Not sure if this was what you meant @arioch. Either typecasting or my approach resolves the problem

yeah, I think that now that it's type cast we don't need this -- is that correct @erikanderson?

Yeah, the fix already committed works for puppet 3 and 4


Static mode

It would be nice to be able to switch on "static mode" for the VM, which basically just ensures that no state writes occur/that there are no side effects from a program execution. For now I think it's sufficient to make sure that in static mode we don't use certain host calls, such as write_storage and spawn. Ideally this could be switched on for a single execute() call, and it should be persistent: when switched on, all subsequent stack frames should be in static mode until we return to the place where it was switched on.
One place this would be useful is when the host calls certain methods, including Verify and MaxSpend, which it currently assumes are static--it would be good to have additional assurances of this from the VM.
It's also likely we'll want to introduce something like EVM's STATICCALL at some point.

Why not have this mode entirely in the host? I.e. the host would know the state (static/not static) and allow only certain operations depending on the mode.

I think that's fine. The only catch is that, if we introduce a STATICCALL opcode/host call in future, we'll need a way for the VM to signal to the host that it should enable static mode.


[IZPACK-1660] enableOverrideArtifact broken since 5.1.3

This change means that if you would want to attach with default artifactId no matter how finalName looks like by setting enableAttachArtifact=true then it will require you to set a classifier even you do not want it.

This change means that if you would want to attach with default artifactId no matter how finalName looks like by setting enableAttachArtifact=true then it will require you to set a classifier even you do not want it.

Can you please give an example? In the current implementation (of 5.1.3) also, you need to specify classifier (please refer to https://izpack.atlassian.net/browse/IZPACK-1717).

This change means that if you would want to attach with default artifactId no matter how finalName looks like by setting enableAttachArtifact=true then it will require you to set a classifier even you do not want it.

@mezmerize, can you please give an example? In the current implementation (of 5.1.3) also, you need to specify classifier (please refer to https://izpack.atlassian.net/browse/IZPACK-1717).

I don't have any example from 5.2.0-SNAPSHOT, but it works with latest 5.1.3 release, when default of enableAttachArtifact is true even when classifier is not specified, we use it in our izpack maven projects.

This change means that if you would want to attach with default artifactId no matter how finalName looks like by setting enableAttachArtifact=true then it will require you to set a classifier even you do not want it.

@mezmerize, can you please give an example? In the current implementation (of 5.1.3) also, you need to specify classifier (please refer to https://izpack.atlassian.net/browse/IZPACK-1717).

I don't have any example from 5.2.0-SNAPSHOT, but it works with latest 5.1.3 release, when default of enableAttachArtifact is true even when classifier is not specified, we use it in our izpack maven projects. I can imagine the problem in issue IZPACK-1717 is that there is already attached an artifact with the same id in the reactor, then they should use classifier to avoid the collisions or separate the modules in maven project if they don't want to use them. But in my opinion this is a normal practice when you want to have output of several artifacts from single module.

BTW, there is no change in 5.2.0 code. I tried a simple installer with 5.1.3 without classifier but it fails. Can you please share your installer POM file? Thanks.

@mezmerize, please refer to my comment in https://izpack.atlassian.net/browse/IZPACK-1660 and let me know if you have any different thought process. I think we don't need enableOverrideArtifact or enableAttachArtifact. I have taken out both of them.

@hiteshbosamiya could you once more rebase?
@akuhtz can you take a look into that PR afterwards?

@akuhtz & @reinhapa, I am closing this PR as output, a deprecated parameter which I removed causes tests to fail. Will bring it back and re-raise PR.


Connection lines

Any plans to add connection lines between resources?
thanks!

Yes, Currently supports a straight line between resources. The start and end points of the line specify the location as the 16-wind rose of the resource (e.g. NNW). https://github.com/awslabs/diagram-as-code/blob/main/doc/links.md
The documentation is not comprehensive enough, and I will work on adding more details later.
Additionally, I would like to implement features such as curves, dotted, arrows, and orthogonal lines, but I haven't implemented them yet.

Awesome! thank you!


Next

Proposed Changes
Makes significant changes to the build pipeline by introducing Prettier and the Airbnb style guide to the code base. Also verified support for Node v10 and v18. Makes significant additions to CONTRIBUTING.md. Removes unnecessary files from distribution.
Pull Request Checklist
Please check if your PR fulfills the following requirements:

[x] I have read the CONTRIBUTING guidelines
[x] My commits follow the appropriate guidance
[x] I certify that I have the appropriate permissions to add these changes to the repository
[x] An issue is open for the changes proposed
[ ] I have added/updated tests for new code changes (if applicable)
[x] Documentation has been added/updated (if applicable)
[x] I built (npm run build) locally and pushed all changes

Issues Addressed: #20, #21, #22, #23
Other Information
None

:tada: This PR is included in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


retry, retry interval(sec) are not independent

Describe the bug
click on action setting
fill retry 5
fill retry interval 10
Expected behavior
retry=5
retry interval=10
before
Screenshots

after :10 10

Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

This issue is fixed.


HPPCRT-37: API changes and internal code refactorings from HPPC v0.7.0

This is a meta-issue tracking what I may add in HPPC-RT from HPPC v0.7.0 master.
What is already done:
HPPC-101 : All current benchmarks are JMH or ad-hoc ones.
HPPC-97 : Use unallocated slot marker key instead of an explicit allocation table for hash containers
HPPC-106 : Drop Guava adapter (and dependency)
HPPC-119 : Make the default hashing strategy an intrinsic (through the generic inlining mechanism)
HPPC-113 : Cleaned up API transitioning from capacity to expected elements. Already more or less HPPC-RT principle, RT has also capacity() method.
What I'll add for next release: (strikethrough means now done)
HPPC-115 and HPPC-103 : Return of the lost perturbation. I'll roll my own vision here with [HPPCRT-35] (https://github.com/vsonnier/hppc/issues/38) without any customization for simplification.
HPPC-111:Drop identity(map|set) specialization and add overrideable comparator. Easy enough by subclassing CustomHashMap, done through HPPCRT-36
HPPC-116 +  HPPC-104 : Replace lset, lget, lkey and other methods which require a memory write
HPPC-117: API simplifications and changes. For me, just newInstanceXXX() renamed into newInstance() with proper overrides.
HPPC-120: Rework entry shifting routine to be less hairy
HPPC-121: Rename remove{All|First|Last}Occurrence(s) to remove{All|First|Last}(key)
HPPC-108: Rename IntDoubleLinkedSet to DoubleLinkedIntSet
HPPC-125: equals should not compare with subclasses of itself.
This is mostly already done,  with some modifications: all containers with overridable criteria for equality or order are already compared against their overridable criteria. So add  getClass()  test instead of instanceof  to prevent comparison with subclasses.
On the other hand, all lists have an implicit order independent of the nature of elements, so finally all KTypeIndexedContainer  are comparable with each other.
What I won't add:
HPPC-112: Add ensureCapacity(elements) to containers
HPPC-114: Buffer resizing and allocation should be throwing non-assertion mode exceptions.
==> The code is already as complex as it is.
The HPPC-RT philosophy is to use preallocated sizes if the user wants zero-garbage behaviour.
In both situations HPPC-99 may be indeed useful as debugging feature using plugable strategies that reports the reallocations. (old size, new size, and so on)
As for OOM situations, they are explicit enough and a HPPC-99 properly logged should be able answer all the questions about the source of such accident.

All the remaining enhancements are now treated as part of https://github.com/vsonnier/hppcrt/issues/42

Closed in https://github.com/vsonnier/hppcrt/commit/8fa586d0924e34972c2ae7a68a3fd7429737a266

Re-open for additional fixes:
HPPC-130: removeAll(KTypeLookupContainer) had an incorrect generic signature
HPPC-131: retainAll(KTypeLookupContainer) had an incorrect generic signature
HPPC-133: KTypeContainer.toArray(Class) can return incorrect array type

HPPC v0.71 is released, this issue can be closed now


how to use plugin in ionic 3?

Hi guys, I'm having awful trouble getting this plugin to work in ionic 3. I'm trying to build a beacon app. I don't know how to link everything together. I was following this tutorial on youtube: https://www.youtube.com/watch?v=-v0Bs7VyotU&t=545s. I see he declares things under the declarations.d.ts file but that file doesn't exist anymore.  Any help would be appreciated. Thanks

I second this. The cordova-eddystone plugin seems to be the only route for using a beacon for an ionic app and no one seems to be able to get it working in ionic v3?


OOD 1.0.0 Release

Ah so with GitFlow we create the release branch first, fix it to our liking, and then when we are ready for the world to see it, we merge that once into master. So I'll close this as well.


Change default Start Time?

Hi Dave, excellent script, it's very useful. I'm using it to block my Airbnb calendar. However, if I put start date (for example January 1st) the Date/time format make it January 1, 12am. Can I modify the script to make it always start at 2pm?

I think this is a limitation of calendar. It assumes an all day event starts at midnight. I think you'd have to specify the start date with a time, like Jan 1, 2pm.