"RangeError: Maximum call stack size exceeded" with default V8ScriptEngine constructor

We are using ClearScript to run some JavaScript on the back end of our web service, however for a small portion of the calls (<1%) it is throwing "RangeError: Maximum call stack size exceeded" when we are creating the V8ScriptEngine with its default constructor. Does anyone know what might be going wrong or how it could be resolved?
Unhandled Exception: Microsoft.ClearScript.ScriptEngineException: RangeError: Maximum call stack size exceeded
    at V8Exception.ThrowScriptEngineException(V8Exception* )
    at Microsoft.ClearScript.V8.V8ContextProxyImpl.Execute(DocumentInfo documentInfo, String gcCode, Boolean evaluate)
    at Microsoft.ClearScript.V8.V8ScriptEngine.<>c__DisplayClass71_0.<Execute>b__0()
    at Microsoft.ClearScript.ScriptEngine.ScriptInvokeInternal[T](Func`1 func)
    at Microsoft.ClearScript.V8.V8ScriptEngine.<>c__DisplayClass76_1`1.<ScriptInvoke>b__0()
    at Microsoft.ClearScript.V8.?A0xb8863588.LockCallback(Void* pvArg)
    at Microsoft.ClearScript.V8.V8ContextProxyImpl.InvokeWithLock(Action gcAction)
    at Microsoft.ClearScript.V8.V8ScriptEngine.ScriptInvoke[T](Func`1 func)
    at Microsoft.ClearScript.V8.V8ScriptEngine.Execute(DocumentInfo documentInfo, String code, Boolean evaluate)
    at Microsoft.ClearScript.ScriptEngine.Evaluate(DocumentInfo documentInfo, String code, Boolean marshalResult)
    at Microsoft.ClearScript.ScriptEngine.Evaluate(DocumentInfo documentInfo, String code)
    at Microsoft.ClearScript.ScriptEngine.Evaluate(String documentName, Boolean discard, String code)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(V8Runtime runtime, String name, V8RuntimeConstraints constraints, V8ScriptEngineFlags flags, Int32 debugPort)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(String name, V8RuntimeConstraints constraints, V8ScriptEngineFlags flags, Int32 debugPort)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(String name, V8RuntimeConstraints constraints, V8ScriptEngineFlags flags)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(String name, V8RuntimeConstraints constraints)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor()
    ...

Hi @acatr,
The V8ScriptEngine constructor runs a small script to set up some data for internal use, and it looks like V8 is detecting a stack overflow while executing that script.
We haven't encountered this behavior and can only guess at its cause. Some questions:

What ClearScript version are you using?
Are you using a public NuGet package, or did you build ClearScript yourself?
You posted a partial stack above. Is the full stack unusually long?
Can you estimate the number of V8ScriptEngine instances your application uses concurrently?
Are you constructing V8ScriptEngine in a 32-bit process?
Can you post a minimal code sample that reproduces the issue?

Thanks!

Version 5.5.5
The public NuGet package
No, it wasn't unusually long, I just cut it off to what I thought was applicable. Here is the full stack:

    at V8Exception.ThrowScriptEngineException(V8Exception* )
    at Microsoft.ClearScript.V8.V8ContextProxyImpl.Execute(DocumentInfo documentInfo, String gcCode, Boolean evaluate)
    at Microsoft.ClearScript.V8.V8ScriptEngine.<>c__DisplayClass71_0.<Execute>b__0()
    at Microsoft.ClearScript.ScriptEngine.ScriptInvokeInternal[T](Func`1 func)
    at Microsoft.ClearScript.V8.V8ScriptEngine.<>c__DisplayClass76_1`1.<ScriptInvoke>b__0()
    at Microsoft.ClearScript.V8.?A0xb8863588.LockCallback(Void* pvArg)
    at Microsoft.ClearScript.V8.V8ContextProxyImpl.InvokeWithLock(Action gcAction)
    at Microsoft.ClearScript.V8.V8ScriptEngine.ScriptInvoke[T](Func`1 func)
    at Microsoft.ClearScript.V8.V8ScriptEngine.Execute(DocumentInfo documentInfo, String code, Boolean evaluate)
    at Microsoft.ClearScript.ScriptEngine.Evaluate(DocumentInfo documentInfo, String code, Boolean marshalResult)
    at Microsoft.ClearScript.ScriptEngine.Evaluate(DocumentInfo documentInfo, String code)
    at Microsoft.ClearScript.ScriptEngine.Evaluate(String documentName, Boolean discard, String code)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(V8Runtime runtime, String name, V8RuntimeConstraints constraints, V8ScriptEngineFlags flags, Int32 debugPort)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(String name, V8RuntimeConstraints constraints, V8ScriptEngineFlags flags, Int32 debugPort)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(String name, V8RuntimeConstraints constraints, V8ScriptEngineFlags flags)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor(String name, V8RuntimeConstraints constraints)
    at Microsoft.ClearScript.V8.V8ScriptEngine..ctor()
    at Callbacks.Services.ClearScriptService..ctor(HttpRequestMessage request)
    at lambda_method(Closure , IBuilderContext )
    at Microsoft.Practices.ObjectBuilder2.DynamicBuildPlanGenerationContext.<>c__DisplayClass1.<GetBuildMethod>b__0(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.DynamicMethodBuildPlan.BuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.BuildPlanStrategy.PreBuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.StrategyChain.ExecuteBuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.BuilderContext.NewBuildUp(NamedTypeBuildKey newBuildKey)
    at Microsoft.Practices.Unity.ObjectBuilder.NamedTypeDependencyResolverPolicy.Resolve(IBuilderContext context)
    at lambda_method(Closure , IBuilderContext )
    at Microsoft.Practices.ObjectBuilder2.DynamicBuildPlanGenerationContext.<>c__DisplayClass1.<GetBuildMethod>b__0(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.DynamicMethodBuildPlan.BuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.BuildPlanStrategy.PreBuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.StrategyChain.ExecuteBuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.BuilderContext.NewBuildUp(NamedTypeBuildKey newBuildKey)
    at Microsoft.Practices.Unity.ObjectBuilder.NamedTypeDependencyResolverPolicy.Resolve(IBuilderContext context)
    at lambda_method(Closure , IBuilderContext )
    at Microsoft.Practices.ObjectBuilder2.DynamicBuildPlanGenerationContext.<>c__DisplayClass1.<GetBuildMethod>b__0(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.DynamicMethodBuildPlan.BuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.BuildPlanStrategy.PreBuildUp(IBuilderContext context)
    at Microsoft.Practices.ObjectBuilder2.StrategyChain.ExecuteBuildUp(IBuilderContext context)
    at Microsoft.Practices.Unity.UnityContainer.DoBuildUp(Type t, Object existing, String name, IEnumerable`1 resolverOverrides)
    --- End of inner exception stack trace ---
    at Microsoft.Practices.Unity.UnityContainer.DoBuildUp(Type t, Object existing, String name, IEnumerable`1 resolverOverrides)
    at Microsoft.Practices.Unity.UnityContainer.DoBuildUp(Type t, String name, IEnumerable`1 resolverOverrides)
    at Microsoft.Practices.Unity.UnityContainer.Resolve(Type t, String name, ResolverOverride[] resolverOverrides)
    at Microsoft.Practices.Unity.UnityContainerExtensions.Resolve(IUnityContainer container, Type t, ResolverOverride[] overrides)
    at Unity.WebApi.UnityDependencyScope.GetService(Type serviceType)
    at System.Web.Http.Dispatcher.DefaultHttpControllerActivator.GetInstanceOrActivator(HttpRequestMessage request, Type controllerType, Func`1& activator)
    at System.Web.Http.Dispatcher.DefaultHttpControllerActivator.Create(HttpRequestMessage request, HttpControllerDescriptor controllerDescriptor, Type controllerType)
    --- End of inner exception stack trace ---
    at System.Web.Http.Dispatcher.DefaultHttpControllerActivator.Create(HttpRequestMessage request, HttpControllerDescriptor controllerDescriptor, Type controllerType)
    at System.Web.Http.Controllers.HttpControllerDescriptor.CreateController(HttpRequestMessage request)
    at System.Web.Http.Dispatcher.HttpControllerDispatcher.<SendAsync>d__15.MoveNext()

Most of the time it should be a fairly small amount (<10), but getting up to 100 is possible.
Yes, it is a 32 bit process.
Unfortunately we haven't been able to intentionally reproduce it, we just see it occasionally in our logs. Here is a simple example of what our code looks though:

using System.Net;
using System.Net.Http;
using System.Threading;
using System.Threading.Tasks;
using System.Web.Http;
using Microsoft.ClearScript.V8;
using Microsoft.Practices.Unity;
using Unity.WebApi;

namespace WebApplication
{
    public class WebApiApplication : System.Web.HttpApplication
    {
        protected void Application_Start()
        {
            GlobalConfiguration.Configure(WebApiConfig.Register);
        }
    }

    public static class WebApiConfig
    {
        public static void Register(HttpConfiguration config)
        {
            var unityContainer = new UnityContainer();
            unityContainer.RegisterType<IFooService, FooService>();
            config.DependencyResolver = new UnityDependencyResolver(unityContainer);
            config.MessageHandlers.Add(new RequestRegistrationHandler());
            config.MapHttpAttributeRoutes();
        }
    }

    public class RequestRegistrationHandler : DelegatingHandler
    {
        protected override Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
        {
            var unityContainer = (IUnityContainer)request.GetDependencyScope().GetService(typeof(IUnityContainer));
            unityContainer.RegisterInstance(request);
            return base.SendAsync(request, cancellationToken);
        }
    }

    public class FooController : ApiController
    {
        private IFooService service;

        public FooController(IFooService service)
        {
            this.service = service;
        }

        [HttpGet, Route("foo")]
        public HttpResponseMessage Foo()
        {
            var result = service.Foo();
            return Request.CreateResponse(HttpStatusCode.OK, result.ToString());
        }
    }

    public interface IFooService
    {
        object Foo();
    }

    public class FooService : IFooService
    {
        V8ScriptEngine scriptEngine;

        public FooService(HttpRequestMessage request)
        {
            scriptEngine = new V8ScriptEngine();
            request.RegisterForDispose(scriptEngine);
        }

        public object Foo()
        {
            return scriptEngine.Evaluate("1+1");
        }
    }
}

Unfortunately updating to 5.5.6 did not help, we are still seeing the issue.

Hi @acatr,
Hmm. We've used a 32-bit test program to create millions of V8ScriptEngine instances and run a small script in each, but we still can't reproduce this issue.
Can you estimate how often this happens, on average? That is, how many scripts does your application run successfully before encountering this issue?
Also, does your application recover from this situation? Can it run scripts after encountering the exception?
Thanks!

We have had it happen on 349 out of 189,710 calls the past 30 days. No real pattern that we can see for when it happens (every n calls, high traffic, high cpu, high memory usage).
It does recover in the sense that subsequent calls to the endpoint succeed, but the calls that get the exception are not able to recover. We tried adding a try/catch for it and retry a couple times with a small sleep between but that didn't help.
We are running on AWS t3.large instances if that might trigger any other thoughts about what might be happening.
I do appreciate the help with this, I know it's not easy when I'm not able to give you a way to reproduce the issue.

Hi @acatr,

We tried adding a try/catch for it and retry a couple times with a small sleep between but that didn't help.

Please clarify. Do you mean that retrying V8ScriptEngine construction threw the same exception? If so, how did you recover? Did you have to recycle the process, or were you able to abandon the current request or operation and continue successfully?
Thanks!

During a request we will try to construct the V8ScriptEngine up to three times with a 50 ms sleep between but all the retries throw the same exception. These requests just end up responding with a 500 while other requests can continue to be handled successfully during this time.

Hi @acatr,

These requests just end up responding with a 500 while other requests can continue to be handled successfully during this time.

Do subsequent requests succeed within the same process?
A few more questions if you don't mind:

Is the exception always thrown from the V8ScriptEngine constructor, as opposed to the Evaluate method?
Do you always evaluate JavaScript from source code, or do you use compiled scripts?
Your code sample above indicates that you use a new V8ScriptEngine instance to process each request. Is that always the case?
How do you prepare each instance for script execution?

Sorry about all these questions, but with no known way to reproduce the issue, any information could help us diagnose this issue.
Thanks!

Yes, subsequent requests succeed within the same process.

Yes, we only see the exception coming from the constructor.
We do not use the Compile method. We are only calling Execute, Evaluate, and AddHostObject. And then we also set MaxRuntimeStackUsage to 200,000 once we successfully construct the V8ScriptEngine.
Yes, each request will always create its own V8ScriptEngine.
For each request, we execute some of our scripts (~10,000 lines of js) for initial setup and then add ~30 functions that will call back into our C# code. Then we just Execute whatever the request is calling for. This always seems to work fine once we make it there, it is just the rare exceptions during construction that are giving us issues.

@acatr Thanks, that's very useful info. Apparently multiple instantiation attempts fail, but only when issued from the same thread/stack environment as the original failure. Once you abandon the operation and let the stack unwind, subsequent attempts succeed, as do operations being processed on other threads. Is that correct?
Also, are you aware of any scenarios in which your application re-enters V8? That is, does your application expose host APIs that synchronously run other scripts?

Apparently multiple instantiation attempts fail, but only when issued from the same thread/stack environment as the original failure. Once you abandon the operation and let the stack unwind, subsequent attempts succeed, as do operations being processed on other threads. Is that correct?

Yes, that is correct.

Also, are you aware of any scenarios in which your application re-enters V8? That is, does your application expose host APIs that synchronously run other scripts?

Yes, this does happen, on pretty much every request.

Also, are you aware of any scenarios in which your application re-enters V8? That is, does your application expose host APIs that synchronously run other scripts?

Yes, this does happen, on pretty much every request.

Interesting! When this happens, does the application re-enter the same V8ScriptEngine instance, or does it create another one?
Also, you mentioned that you set MaxRuntimeStackUsage after instantiating V8ScriptEngine. Do you ever change it thereafter?

Hi @acatr,
We've identified a set of conditions that leads to the behavior you're seeing. We believe the root cause is a V8 bug that we've reported here.
Unfortunately, because we can't reproduce your issue, we don't know whether fixing that bug would resolve it. If you'd like to test a potential fix and wouldn't mind building ClearScript yourself, please let us know.
Thanks again for reporting this issue!

Yeah, we can test the potential fix.

Hi @acatr,
We've committed a potential fix here.
If you haven't built ClearScript before, please see the instructions here.
If you've already built ClearScript, pull the fix, rerun V8Update without the /N flag, and do a full rebuild of ClearScript.sln.
Please let us know if this fix works for you.
Thank you!

Been a bit busy but I was finally able to get everything built and consumed in our service. We haven't seen the issue yet so it looks good so far. We want to give it a few more days of testing to truly confirm that it is fixed though. I'll reply back back with our results sometime next week.

Everything is still looking good so it does seem to be fixed. Thanks for the work on this.
Do you have an estimated date for when a new version of the NuGet package will be published?

Hi @acatr,
Thank you very much for testing the fix! ClearScript 5.6.0 should be out later this month.
Cheers!

Awesome, thanks again.

ClearScript 5.6 incorporates this patch.


RestrictedExecution.lua:431

Macro isn't firing. The button:1 is on the macro itself. This was literally just working before servers went down.

This is a fix your macro thing.  You need to reduce the size of your loops or remove some actions.


Adding native library

Hi.
I import the code and run at that time it will giving error something link that.
[2016-03-15 17:46:58 - ip-messaging-demo-android-gcm] The library 'twilio-ip-messaging-android.jar' contains native libraries that will not run on the device.
[2016-03-15 17:46:58 - ip-messaging-demo-android-gcm] Additionally some of those libraries will interfer with the installation of the application because of their location in lib/
[2016-03-15 17:46:58 - ip-messaging-demo-android-gcm] lib/ is reserved for NDK libraries.
[2016-03-15 17:46:58 - ip-messaging-demo-android-gcm] The following libraries were found:
[2016-03-15 17:46:58 - ip-messaging-demo-android-gcm]  - lib/armeabi-v7a/libtwilio-rtd-native.so
i also follow all the step you have written in that.
please help me to solve this issue.
Thanks.

What is your device CPU architecture?

Closing this as outdated, please reopen if it still happens.


developed the entire landing page excluding the footer

🛠 Fixes Issue
closes #2

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

@CyberGeni  the navigation are not working when it's on mobile view and the footer is also not includes

@ingressive4good i've fixed it, it works now. the footer was detached to a standalone issue

i don't know why, but the images aren't showing on the netlify preview, so the hamburger menu can't be clicked. i'll see if i can look into why it isn't displaying

@CyberGeni kindly resolve your conflict to allow merging of your PR

@ingressive4good i've resolved the merge conflict

@CyberGeni Please fix the conflict on your PR

@ingressive4good fixed merge conflict, again


Feature Request: Language Server

I'd love to see language server support getting added to this! As far as I can tell the most promising LS so far is sqls and it seems to also support several DBMS.
I'm also partial to postgres_lsp but that still seems to be in a very early stage of development and is limited to Postgres which is probably not ideal for this extension.
(There is also a node-based SQL LS which I assume is what vscode uses, but that involves pulling down yet another version of the node runtime, which I'm not a huge fan of)

Hi, thanks for reaching out! I'll take a look and see if I can get the lsp integration implemented this or next week, i've created a PR that you can follow and contribute to if you'd wish. 👌

https://github.com/evrsen/zed-sql/pull/3


Locality-aware backup description edit for node locality

Fixes DOC-9612
This PR adds further detail on locality-aware backups and clarifies some behavior, (refer to the links for rendered previews):

Technical description updated on the Back Architecture page. Along with a short section calling out the differences in Serverless behavior here.
Edits to top of Locality-aware backup page. Namely clarifying the language to reflect behavior and adding a warning to the top of the page. Plus the addition of the serverless callout.
Clarification to the Unsupported Features in CockroachDB Serverless page.
Remaining edits are small clarifications in language + additional sentence to describe how regions work for managed CRDB backups.

Note/question:  We do not currently mention l-a backups in our data domiciling docs or multi-region docs, so this PR does not change anything there yet.

Thanks, Kathryn. I like the approach you've taken with this PR in terms of clear but subtle warnings that users consider the current behavior carefully if they have data domiciling requirements.


Accordion Print Styles

How does one force all collapsed elements in an accordion to expand for printing?
Example code below:

Customer Support

 How do I contact Customer Support?

                    NEED TO SEE THIS WHEN PRINTED

My CSS for this is:
@media print {
    .panel-collapse,
    .panel-collapse .collapse {
        height: auto !important;
    }
}

This doesn't seem to work. Any ideas?

In the print view, I'm getting parentheses inside the accordion-heading tag right after the title.
Does anyone know where this is coming from?

@patriciomas could you please post this as a new issue, instead of commenting on a closed 4 year old separate issue?


Snippets have stopped working for Markdown files

Does this issue occur when all extensions are disabled?: Yes

VS Code Version: 1.73.0
OS Version: Windows 10.0.19044

Steps to Reproduce:

Run VSCode
Edit a markdown file
Type snippet prefix and hit CTRL+space. Autocompletion suggestions no longer include snippets — only spelling suggestions. All snippets are gone from the CTRL+space list.

Snippets do still appear to work in JS files. But, snippets that have “markdown” assigned for “scope” aren’t available any more when editing a markdown file.
This was working before I applied the update.

Does this reproduce in the latest VS Code insiders build with all extensions disabled?

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!

Please share a screenshot of the editor when this happens. This may be have clues on what is going on because I can't reproduce this
/gifPlease

Thanks for reporting this issue! Unfortunately, it's hard for us to understand what issue you're seeing. Please help us out by providing a screen recording showing exactly what isn't working as expected. While we can work with most standard formats, .gif files are preferred as they are displayed inline on GitHub. You may find https://gifcap.dev helpful as a browser-based gif recording tool.
If the issue depends on keyboard input, you can help us by enabling screencast mode for the recording (Developer: Toggle Screencast Mode in the command palette). Lastly, please attach this file via the GitHub web interface as emailed responses will strip files out from the issue.
Happy coding!

I’ve actually been able to reduce the issue down to a very narrow case.
Add the following to your user snippets:
“H6 heading”: {
  “prefix”: “h6”,
  “scope”: “markdown”,
  “body”: [
    “###### ${0}”,
  ],
  “description”: “Stub out an H6 heading.”
}

Then do the following:

Create a new markdown document
Add a line of text
On a subsequent line, invoke the Trigger Suggest command. You should see the H6 snippet and be able to invoke it.
On a subsequent line, add some more text, being sure to begin the line with a dollar sign, such as:
$someVariable
(But, no backticks. The dollar sign must be the first character on the line.)
Now, invoke Trigger Suggest again. The suggestion for the snippet will not be there.

In short, when a dollar sign is the first character on a line in a Markdown file, markdown scoped snippets will not work after that line of text. They will work fine before that line and they will work fine in other markdown files. But, a $ at the beginning of a line appears to break snippets for the remainder of the file.
Hope this helps.
Thanks.

Thanks @lhoff!
This actually is expected with our math support in markdown. $ at the start of a line starts is the start of a math block. To avoid this, you can either:

Escape the $: \$abc
Disable the built-in markdown math extension (search @builtin math in the extension view to do this)

This doesn't happen if the $ is not the first character in the line since than we only match inline equation, instead of math blocks


rtcstats: move ws connection to external module

and pass trace function

I'm curious about the reason of this change, but anyway LGTM :)

make it reusable by https://github.com/fippo/webrtc-externals ;-)


GEODE-6529: Use EntryEventFactory instead of factory methods

allows easier testing of LocalRegion

Co-authored-by: Michael Oleske<EMAIL_ADDRESS>Co-authored-by: Dale Emery<EMAIL_ADDRESS>Co-authored-by: Kirk Lund<EMAIL_ADDRESS>Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[ ] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[ ] Is your initial contribution a single, squashed commit?

[ ] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

@demery-pivotal and @mhansonp please review too :)


[Bug] 进入再退出设置页面后，memory prompt按钮会变成下拉按钮

Describe the bug
在网页端，当一个对话页面对话数量没有占满一页时，点击设置再退出设置页面，对话框上方原本的contextual and memory prompt按钮会变成"拉到底端"按钮并且无法还原，除非点击别的对话后再重新进入此对话。
To Reproduce
Steps to reproduce the behavior:

Create a new chat, or go to any chat with short conversations (haven't filling one page yet).
Click on setting button.
Exist setting page.
The prompt button becomes to bottom button and cannot be reverted.

Expected behavior
The prompt button should stay there before and after entering/exiting the setting page.
Screenshots

Deployment

[ ] Docker
[x] Vercel
[ ] Server

Desktop (please complete the following information):

OS: [Mac M1]
Browser [Edge]
Version [111.0.1661.51]

Additional Logs
Add any logs about the problem here.

#1103


Exceptions thrown in parsing numbers

Compiler.CompileNumber uses double.Parse and long.Parse, which will thrown ArgumentNullException , FormatException, or OverflowException. (https://docs.microsoft.com/en-us/dotnet/api/system.double.parse?redirectedfrom=MSDN&view=netframework-4.7.2#System_Double_Parse_System_String_)
I think better is to TryParse(), and then thrown your own exception. This will allow programs that call Lizzie to trap execution issues better.

Hmm, yet again the exception issue. This one is more easy to agree with by default I think ...

Fixed (in repo)!


Investigate if comparison's speed can be improved.

Using bit fields fixes all the performance issues.

Tried a number of things, using slightly different comparison functions and implementing bitfields (exists in a branch) performance is absolutely the same.

Tried:
proc cmpStrings*(a, b: String): int =
  if not isLong(a) and not isLong(b):
    result = cmpMem(addr a.short.data[0], addr b.short.data[0], sizeof(String))
  else:
    let minLen = min(len(a), len(b))
    if minLen > 0:
      result = cmpMem(a.data, b.data, minLen)
      if result == 0:
        result = len(a) - len(b)
    else:
      result = len(a) - len(b)

Still short strings are inexplicably slow. Let's try if a power of two number of bytes make cmpMem faster.


Why isn't newtype-generics included in the new nightly with GHC-8.4.1?

newtype-generics builds and tests cleanly with nightly-2018-03-13.

I wanted to get a nightly out there quickly, even if it is much smaller than usual. I used some rough heuristics and removed wide swaths of packages. Much too wide, but I was aware of this. We will be working on re-enabling as many packages as possible over the next few days.

Oh, ok. I'll leave this open so other package maintainers will also see your explanation.

newtype-generics builds and tests cleanly with nightly-2018-03-13.

Turns out I missed a non-zero exit code and tested with lts-10! :)
Here's how stack init fails with the new nightly:
$ stack init --resolver nightly --force
Looking for .cabal or package.yaml files to use to init the project.
Using cabal packages:
- ./

Selected resolver: nightly-2018-03-13
Selected resolver: nightly-2018-03-13
The following packages specified by flags or options are not found: persistent-sqlite yaml

Not sure if this is stack bug or an problem with the snapshot.

I'm also seeing that failure (re: persistent-sqlite).

The following packages specified by flags or options are not found: persistent-sqlite yaml

This was fixed in https://github.com/commercialhaskell/stack/pull/3916.

A stack minor release is underway, but the impatient can tell stack to upgrade itself from source.
stack upgrade --git --git-branch stable

Note that newtype-generics still hasn't made a release to hackage with bounds that allow for base-4.11. That seems to be the only reason for its exclusion at this point. I've opened an issue: https://github.com/jcristovao/newtype-generics/issues/21

Note that newtype-generics still hasn't made a release to hackage with bounds that allow for base-4.11.

Oh, that's a bit embarassing! :/
I've uploaded a new release!

It's in the build plan now; I expect it to appear in the next nightly.

Thanks a lot for your work, @DanBurton! :)


Add files via upload

@goldminer2015 domains/ca/kingschristian.txt: this request has an incorrect file path format, please ensure that you are familiar with     this repository rules located at the bottom of this page and change     your request accordingly. If you don't know how to change request, close it and open a new one.     If you are not able to make the pull request according the instructions, please send us an email to<EMAIL_ADDRESS>Please mention this request URL in the message.

@goldminer2015 First stage of verification passed, official domain for King's Christian Collegiate is kingschristian.ca as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.


Support objc generics from extern types.

This is based on the generics population that already existed with the java generator
Currently the default is "false" to preserve backwards compatability

This PR fails due to the code format check, on reason to worry.
You can simply format all the files by running sbt scalafmtAll
It's a good idea always doing so before a commit or before pushing changes up to a PR.
Please see https://github.com/cross-language-cpp/djinni-generator/blob/main/docs/developer-guide.md#code-formatting for more information.

@a4z @jothepro I took a stab at adding a test, which also exposed a bug I had, so it should all work now =)

The array was just the simplest way to show the example.
Ways that we will be using it is to expose an ordered maps and sets ( where iteration is based on the order items were inserted) which need to map to custom NSDictionary/java.util.Map and NSSet/java.util.Set implementations.
We could build a custom type w/o this but on Objc we would not have the strung typing exposed (but would on the java side).
Another use would be to expose an outcome type, snapchats for has this, but it has to be implemented in the generator. With this PR those kinds of types can be implemented purely as external types.

.... With this PR those kinds of types can be implemented purely as external types.
This sounds very interesting

yes, I am all for getting into a testing state where we do not just compare generated text, but also have something executing. Optimally not just in a series of asserts,  but also in a way that it can be used as documentation, but this is an extra story.
To start with, adding something into support lib is a good begin, but will remind us on that https://github.com/cross-language-cpp/djinni-generator/discussions/94
--
btw, does this PR mean, that at least for  Objective-C and Java , this, https://github.com/cross-language-cpp/djinni-generator/discussions/92, is actually implemented ?

@a4z Yes this extends the existing "generics" support to Objective-C and would partially (depending if on what languages they needed it for) address https://github.com/cross-language-cpp/djinni-generator/discussions/92.
I have the working changes to extend it to C#, let me put those up as well

do you want to make that in this PR or in an extra one after this is merged?

we probably should merge that one first, and then have the C# thing extra
can you press the apply button for the type fix, the we merge this, and the C# becomes some extra PR ?

Didn't see your note.
I just pushed the C# changes as well.
But I reworked the test to to show the full intention a little better. It now modeled after the vendor/date example in the support-lib, showing that you can fully support "list" as an external type

Great that this is now in main , thanks a lot @eakoli for the contribution and our patience!

@eakoli : sorry if I did not quite understand this PR/issue ; I am the guy who asked for #92 and I am still very much interested in getting some generic support for djinni, but I am not 100% how far this PR goes with respect to what I ideally need as a user :)
So, let's say I have a the following C++ type: template <typename T> MyType {...};
Is this PR able to make this type available to java/objc? If so, what do I need to do to expose it?
Does it mean in my djinni files I can then use MyType<i32> or MyType<AnotherDjinniType> ?
If so, you totally made my day!

@delaitre-manfrotto I answered in the referenced discussion


Azure Monitor vs SCK

What’s a better approach for grabbing logs from managed k8s and Openshift clusters on Azure?
Azure provides their own fluentd agent which run on our nodes and sends data to Azure Monitor. The agent supports container and infrastructure  log collection.
Are there any constraints to deploying the Splunk add-on for Azure Monitor to pull in the data compared with the SCK agent? I know the SCK will strip out any JSON.

In my experience with customers thus far, managed Openshift does not allow you to implement cluster level logging.
They only provided 2 option, Option 1: File-based sidecar, Option 2: Streaming-based sidecar.
I am hoping that they change that and allow Splunk configs to run like we would in other cloud providers, as a native option.


Vizor2 teaser page

First version of Vizor 2 teaser site. Served from /vizor2teaser for now.
Test deployment here: https://jouko.vizor.lol/vizor2teaser
Things still missing:

Mobile nav menu
Proper  and meta tags
Browser testing and some finishing touches

happy to get a mobile version in a separate PR

hero container could use a user-select: none there

@gmarinov I didn't quite catch that. The intended behavior is that user can select the text, but clicking anywhere outside the text will pan the camera.
Do you think that's wrong?

@joukosaastamoinen

looks good to me - we just have to make sure both vizor.io and patches.vizor.io work off this same code. see https://github.com/vizorvr/vizor/blob/develop/app.js#L268


Create new branch dedicated to generic enhancements

This branch will be used to code enhancements for already existing code while having other active branches dedicated to specific devs.

Completed.


fix: avoid memory leaks due to undisposed promise resources

Most Promise async resources require a separate promiseResolve event listener. See the inline comments for more details.

@ofrobots I have added tests. They fail when the source changes are not applied.


⚠ Bofrost.de has degraded performance

In 8a4eb27, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1465 ms

Resolved: Bofrost.de performance has improved in 3e62268.


[BUG] The Recent Stats shows the word "Latest" twice.

Describe the bug encountered
After fetching the statistics, under the Recent Stats section, instead of "Last Day", or "Last Week" it shows "Last Last Day", and "Last Last Week".
To Reproduce
Steps to reproduce the behaviour:

Type in any package name and hit Submit.
The redundancy can be found under the "Recent Stats section"

Screenshots

@Pinak-Datta I think the issue is resolved, as I do not see this error:

Try clearing your cache.

Yup!
Apparently, the latest commit changes is only reflected after restarting the app on streamlit cloud!
Thanks!


Wrong capitalized character while typing fast

This issue is faced with any type of field.
While typing fast (normal messaging speed for a daily user) second character, sometimes the third one too, is wrongly capitalized.
Here is an example video of the issue:
https://github.com/KeyboardKit/KeyboardKit/assets/57370718/74108e43-bdab-4ea0-867e-dd98841627e3
SDK Version: 8.0.7
iOS Version: Multiple iOS 17 & iOS 16 versions

@TalhaSelimhan I have tried to reproduce this, but am unable to. Do you still see this problem?

I can reproduce this by rapidly tapping two keys. The autocapitalization should consider the previous character as well.

I can no longer reproduce this in the 8.8.6 patch, which contains the new gesture engine.
Feel free to reopen this bug if you can still reproduce the error.


"Check for Update" goes to stable version even while on beta

Describe the bug
When using the Check for Update button on a beta, AdvantageScope will correctly recognize that there is a new beta available. However, when you click on download, it will go to https://github.com/Mechanical-Advantage/AdvantageScope/releases/latest, which ignores pre-releases and shows v3.2.1 (the latest non-prerelease).
To Reproduce
Steps to reproduce the behavior:

On macOS, go into the AdvantageScope menu in the menu bar. Not sure where the Check for Update button is on Windows and Linux.
Click Check for Update
Click Download
See that it opens v3.2.1 instead of the beta

Expected behavior
Beta release is shown
Version (required):
Version: 4.0.0-beta-1
Distributor: FRC 6328
Platform: darwin-arm64
Build Date: 9/26/2024, 24:41:47 UTC
Electron: 32.0.2
Chromium: 128.0.6613.84
Node: 20.16.0

Thanks for reporting! This is actually one of the fixes that's part of the second beta release, so it should link to the correct page when you upgrade to the third release.


Angular2CookieLawService compatibility with Angular Universal pt. 2

Same code from #30 that fixes #29 but with fixes to make sure it doesn't break the build.

👍


Creating non-integer EDOs

Before the last update, it was possible to create non-integer EDOs, such as 52.99683 EDO instead of 53 EDO, 18.94809 EDO instead of 19 EDO, etc.
For context, 18.94809(...) EDO is very slightly more optimal tuning than 19 EDO, according to Riemann-Zeta tuning method

I think of such tunings as having a stretched octave/equave.
Workarounds:

Create an equal temperament with the equave pre-stretched (replace 2/1 with 1202.3 etc.).
Use the stretch/compress modifier after creating the scale.

Feature proposal:
Disable the relative steps and absolute degrees boxes when the user tries to create non-integer EDO, but let the generation go through.

I will also have to clarify that it was possible to create such tunings before the last update, so it should not take a lot to re-add this feature

Unfortunately the whole application was re-written from scratch so implementing this incidental feature will be pushed to version 2.1.0.
Meanwhile you can use the old version if non-integer EDOs are critical to your workflow: https://sevish.com/scaleworkshop1/

I think it's ambiguous how many notes a non-integer EDO scale should have. Version 1 breaks when you try to divide the octave into 0.5 parts even though the step-size is well-defined.
I suggest that non-integer scales are implemented as a single step only. They should sound the same as version 1 for divisions >= 1.

Core functionality done... https://github.com/xenharmonic-devs/scale-workshop-core
... but let's go with the single step approach.

Single step approach would surely work, as long as it's not hard to set the non-integer size of an EDO. Thanks for taking time on this!


TypeError: this.adapter.addAll is not a function

Hello @elegantmonkeys
Socket io updated the version and added addAll method for join multiple rooms.
Also google cloud version bumped to 0.48.0 too.
Current version of socket.io-pubsub not peer with google-cloud version 0.48.0 and not working with latest version of socket.io server.
Have a great day!

Hi @centrual ,
Would it be possible for you to submit a PR?
Thanks for your contribution!

Information is not correct, let i fix:

Github version of socket.io not working with socket.io-pubsub
google-cloud updated to 0.48.0, socket.io-pubsub working with 0.47.0

I'll check it soon, currently it is working with 1.7.3

google-cloud version fix:
https://github.com/elegantmonkeys/socket.io-pubsub/pull/5


Updated Spanish translations

Added Spanish (ES) translation for the comments.json file.
One extra commit was made to update from a more formal spanish (usted) to a more informal one (tu) as I saw that style was used in the other translations.
Hope it helps.

Hey, I just re merged to update the branch as some tests failed (and I wasn't sure why). Let me know if I can help. Thanks!

Thanks @GabGB! 🙂


[HUDI-7662] Add a metadata config to enable or disable functional index

Change Logs
Add a metadata config to enable or disable functional index. Note that this is an uber config to disable all functional indexes. To build or drop each functional index individually, users still need to use CREATE/DROP INDEX SQL commands.
Impact
Ease of use, users can easily disable func index with a simple toggle.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change. If not, put "none".

The config description must be updated if new configs are added or the default value of the configs are changed
Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
ticket number here and follow the instruction to make
changes to the website.

Contributor's checklist

[ ] Read through contributor's guide
[ ] Change Logs and Impact were stated clearly
[ ] Adequate tests were added if applicable
[ ] CI passed

uber config

What do you mean? Not the company right?

uber config

What do you mean? Not the company right?

No i meant like a super config for func indexes. Sorry for the confusion. I have rephrased.

uber config

What do you mean? Not the company right?

No i meant like a super config for func indexes. Sorry for the confusion. I have rephrased.

normally wouldn't be confusing, but Uber is pretty involved with Hudi 😂

Still have the question about:

In the test lines 468-479 you disable the functional index and verify the query still works. What happens if you

disable index
do write
enable index
check query result
Will the query still be correct?

Yes, the query result will be correct. Just that, data skipping may not be very efficient (skipping ratio might be lower). I have added a query with predicates including values when functional index was disabled and enabled, and we see correct results.


read playlists on every build

Resolves updated playlist not reflected in index upon automatic build through watch.

Looks good. Also confirmed that it handles new playlists and deleted playlists automatically

One minor bug is when playlist contain error in filename, then the whole builder will crash instead of gracefully crash and continue watching. I'll fix this if necessary, a try catch should do the trick.


Download tar.gz archives for Gitlab

Signed-off-by: Jingchao Zhang<EMAIL_ADDRESS>Hey, I just made a Pull Request!
This pull request changes the format for downloading archives for Gitlab from the zip to tar.gz to solve #5997
:heavy_check_mark: Checklist

[x] A changeset describing the change and affected packages. (more info)
[ ] Added or updated documentation
[ ] Tests for new functionality and regression tests for bug fixes
[ ] Screenshots attached (for UI changes)
[x] All your commits have a Signed-off-by line in the message. (more info)

Nice work @Jerry4013! Small typo in GitLab but looks good overall 👍

yeah you want it to be "GitLab", and then you probably want to put `readTree` in backticks like that

I made vale happy and pushed - let's just wait for green light then 🚢

@freben Great! Thanks!


Fix a regression when running Foodcritic as a Rake task

The Output classes' initializers now require
an output stream argument.
Signed-off-by: Jonathan Hartman<EMAIL_ADDRESS>

Shipped at 10.3.1


[Update Package] Microsoft.VisualStudioCode: version 1.56.0: update installer URL

Microsoft.VisualStudioCode: version 1.61.2: update installer URL
This PR is part of a bulk update.
resolves #201587
Microsoft Reviewers: Open in CodeFlow

Hi @lszomoru,
Do you approve of these changes?
(Automated response - build 931.)


Make join_game less generic.

People can press it after the specified game has started, which leads to variables not being set; thus causing it to crash the bot.

fixed


Full screen feature

Is your feature request related to a problem? Please describe.
not
Describe the solution you'd like
Full screen feature was removed on beta version, but this feature are very helpful to me because help with the concentration
Describe alternatives you've considered
that feature could be disable for default

Is your feature request related to a problem? Please describe.
not
Describe the solution you'd like
Full screen feature was removed on beta version, but this feature are very helpful to me because help with the concentration
Describe alternatives you've considered
that feature could be disable for default

I'm sorry about that @jedsonmelo. I'm very busy lately and had no time to write proper documentation of the apps new features and changes.
Fullscreen Feature is being moved to Strict Mode Feature due to some users request.
I already updated README.md for some overview of changes and new features of the app.
Please read it if you have time. Thank you for your patience. Good day!

I understend. Thanks for the amazing app.

Hi
What was the old way to handle this ?
I like the strict mode to have the fullscreen when it's tile to take a break but I also need to be able to interrupt timer if I'm away for x minutes.


Enhance documentation

Refined project documentation and added comments during an in-depth review to map out the project's architecture and component interactions.
@urvishp80 I would appreciate if you can review and verify that my attempt to explain the flow and what each script does is correct. Also, I prefixed a few comments with @?, those are questions that I have and I thought that it would be easier to discuss/answer them in-line. I will delete them (or transform them to @TODO) before merging this.
The cron-jobs are also documented on the sequence diagram that I created for Bitcoin Search & friends. I would also appreciate a review of that one.

@urvishp80 I rebased and converted my observations to TODOs
During rebase, I also modified a comment based on my observation here.


fix(security): fixing possible xss issue in parsed objects

To handle potential security issues with XSS - the following PR introduces:

refactoring the user object that gets populated in the server-side to achieve: 1. a pre-defined sub-set of the user object will be passed to the client side for usage; 2. escaping possible malicious XSS strings such as username, displayName, etc.

Fixes #1106

With this fix, there is still some meddling required on the angular side though.
For example, check out the edit profile view:

I started playing around with this branch, and noticed a couple of issues..

The Authentication service will need to be updated to check that we have a populated user object. Currently, it assigns the user from $window.user which will exist even when there's no user logged in; thus, the application thinks the user is logged in. We may want to change some of the logic around this service.

In Chrome, if not logged in & I navigate to the articles list, the browser's user object gets set to my previously logged in user. Firefox doesn't behave this way. Fixing the first issue should help with this, but I still find it concerning (& confusing) that this is happening.

Test this with both logged in users, and non authenticated user, to see these behaviors.
As for the issue of injecting that script into the username field, we can add some validation logic using Angular, right?

@mleanos I didn't get your 2nd bullet about seeing another user's session when not logged in... sounds very bad. Can you explain better?
Also, you can go ahead and commit to my branch all the changes concerning the angular part.

@lirantal Regarding my 2nd point..
I was monitoring what the browser's user object was getting set to, by viewing the source of the page. When I wasn't logged in, I navigated to the Articles list view & viewed the page source. The user object was set to my previously logged in user. My guess, is that it pulled it from the browser cookie.
I only experienced this in Chrome, and not Firefox; I only tested with these two browsers.
Can you try to reproduce?

@lirantal Also, what changes do you see needed on the Angular side of things? I'm more than happy to submit them to your branch.
Some of these changes could include the following..

Update Authentication service to account for new empty object structure in $window.user
Add client-side validation that would prohibit malicious field data. I may need guidance on this, as to what these guidelines should be (and what potential data is malicious.) Is it merely removing anything that has >script and similar?

Anything else?

@lirantal @mleanos I know the second was an issue in the past but I was under the impression that we fixed that a while back.

@mleanos about the actual changes required - I refactored so that the change is only happening in the server-side, including the sanitizing before echo'ing back to the frontend to render.
I also left the original null value to be returned and not an empty object because that really messed things up with the tests and the UI.
On the Angular part - see my screenshot above - it requires "re-encoding" the data back on the view layer so that it doesn't show the HTML entities decoded.

@codydaig @mleanos as to the other weird issue reported - I'm able to reproduce this:

login with user to meanjs
browse some stuff, then press CTRL+F5 to re-load the page
browse reloads the page from scratch and shows user as anonymous, but for some reason the user object is still populated on the page

any ideas?

@lirantal Nice. Yea, keeping the changes on the server-side is the best way to go. Also, so much of the framework expects null (or undefined) for the user object when not logged in. It will take some work to refactor everything to expect an empty object. If we decide an empty object is better, we can tackle that in a new PR.
I've re-synced to your latest change, and tested. I can verify the E2E tests are passing now. And now there's no need to refactor the Authentication service.
I'm about to try to reproduce your issue. Did you have any success reproducing what I reported above?

@lirantal I wasn't able to reproduce the issue you described. I was experiencing odd-ish behavior with the user object on the page, and it appeared to be related to previous browsing history. I cleared my cookies & browsing history for my local meanjs host. After that, the odd behavior went away. Perhaps try to do the same, and see if you still experience your issue.
After removing history/cookies in Chrome, I'm still seeing the same behavior I reported above. However, once I do a hard refresh (CTRL+F5) of the page, the data isn't there anymore. It's weird tho, that even after clearing the cookies, the data would still be there until I do the hard refresh.
I think we can chalk these issues up to browser (cache) issues. WDYT?
@codydaig

Thanks for the feedback @mleanos
About the validation you're right, it's not yet complete and I will update the rest of the fields too to be escaped properly.

@mleanos addressed changes.

LGTM, other than the coverage. It looks like we just don't have tests specifically for the core server controller; the little coverage that file has is coming from other tests.

@ilanbiala try this: https://coveralls.io/builds/4587050 and scroll down to click on the actual controller file

@ilanbiala try this: https://coveralls.io/builds/4587050 and scroll down to click on the actual controller file

@ilanbiala @lirantal I'm getting the same error "Source not available" even with @lirantal's other link.

@ilanbiala @lirantal I'm getting the same error "Source not available" even with @lirantal's other link.

Strangely, this link works. https://coveralls.io/builds/4594977/source?filename=..%2Fmodules%2Fcore%2Fserver%2Fcontrollers%2Fcore.server.controller.js

Strangely, this link works. https://coveralls.io/builds/4594977/source?filename=..%2Fmodules%2Fcore%2Fserver%2Fcontrollers%2Fcore.server.controller.js

For these statements, can't we actually make a request and test the header and content-type? Then it will test these lines, no?

For these statements, can't we actually make a request and test the header and content-type? Then it will test these lines, no?

That's really odd, about not being able to see the coverage on that file.
@ilanbiala I think you're right. We can just a request, and test the header & content-type. We'll need to have tests for both logged in users, and non-authenticated users.
I think renderServerError will be a little more tricky, but we should still be able increase converage, without testing the server error method.

The server-side route tests simply don't touch these areas, I don't think it's related to header or content-type.
I'll try to work on adding these for these areas too.

Merging fix for now.


Increase speed of adapter layer initialization

Feature request
We are working on increasing the speed of adapter layer initialization. The first step towards this is #887, which tackles linear LoRA layers, which are arguably the most important ones. As discussed with @pacman100, after that PR, there are still some TODOs:

[x] apply to Embedding and Conv2d layers (#915)
[x] apply to compressed layer types, like Linear4bit, Linear8bit (#994)
[ ] init LoRA modules (A, B) right on target device, not CPU (won't fix for the time being, seems pretty fast already with all the other changes)
[x] same for AdaLora (#1106)
[x] same for IA³ (#1106)
[x] Init in merge_and_unload (#1106)

Motivation
Initial testing showed ~10x increase in speed with the optimized initialization.
Your contribution
#887 is the first step.

Not stale

Hi guys, I am trying to load a meta-llama/Meta-Llama-3-70B-Instruct PEFT model with LoraConfig(init_lora_weights="pissa", 16, 0.1, 64, none", CAUSAL_LM", target_modules="all-linear") and I noticed that it is very slow in initializing the layers. To be precise, it's the for key in key_list loop in peft.tuners.tuners_utils.BaseTuner.inject_adapter that is very slow.
Should this issue be actually fixed with these PR's? Because if it should be, than it does not work for meta-llama/Meta-Llama-3-70B-Instruct with the above LoraConfig.

Thanks for reporting this. Is it still slow when you remove init_lora_weights="pissa" from the config?

Actually if I use the default method, it is very fast. Switching to init_lora_weights="pissa_niter_32" also made it very fast. I just notice that if I use this initialization with a multi-gpu deepspeed setup, it again takes a couple of hours, maybe due to some concurrency issues.

It is expected that using the default init or PiSSA with n_iter is faster than just pissa. However, a couple of hours still sounds excessive. Does it finish after a couple of hours or do you just cancel the process at that point?


Extend over V2 branch with a new idea

This is an extension to #16 , except I am putting it here separately for now. If deemed good enough once finished, it will likely go into the v2 branch.

I have fixed some identified bugs and I think this iteration is better than what is in v2 branch. As such, I plan on merging it and further polishing can continue there or in other PRs.


[Feature]: Use 'Toss Product Sans' font

Package Scope
etc
Description
As Suspensive is joining the Toss organization's library, what do you think about using the Toss Product Sans font for the documentation as well?
Possible Solution
No response
etc.
No response

I want to disagree this. because this project should be standalone with Toss's brand to support all world project not only Toss product. Our role is not representative of Toss. The React team approaches fonts not as a way to brand Facebook, but as a utility for React itself. Fonts imply branding, so I want our docs to be accessible in a purely default font.

Thank you for your response! I agree with your opinion. Closing the issue.


error

Hello sir,
TypeError: Cannot read property 'active' of null
at c:\bitcot\pencilblue\include\service\entities\section_service.js:211:38
at c:\bitcot\pencilblue\node_modules\node-promise\promise.js:159:27
at process._tickDomainCallback (node.js:463:13)
What's going wrong to get the error ....
Please help me.

http://bit.ly/UIR-SOF


#208: DevTools: add the FunctionEditor feature

TaskList

[x] Highlight code in code preview
[x] Generated UI preview
[x] Bug: default value removal has no effect
[ ] arbitrary metaparams addition (e.g., meta.key: value)
[x] Bug: type choosing combobox dissapears
[x] Add the semantic type choice
[x] Remove CodeMirror & RxJS from dependencies
[x] Bug: when the language is changed, the text is doubled
[ ] Replace view creation by view changing
[x] UI fixes
[ ] Interactive CodePreview
[ ] Docs
[ ] Tests
[ ] Blog post

Context
The only way to create DG script now is to copy-paste it into the editor and add the DG headers with all the metadata.
Problem
It is important to give an opportunity to edit the DG headers visually. The visual way is more intuitive and makes the experimenting easier.
Proposal
Add the visual DG headers editor that covers effectively all the combinations of headers. The FunctionEditor should generate DG headers with no internal conflicts.
It can be visualized as something like this:

This view must be available from any script editor.

More sketches from Dima:

MVP deployed: https://github.com/datagrok-ai/public/commit/f3ca420cf981801653956a7f2f1cd8d754c731a7
Moved from Compute to DevTools.

TaskList

[ ] Highlight code in code preview
[ ] Generated UI preview
[ ] Bug: default value removal has no effect
[ ] arbitrary metaparams addition (e.g., meta.key: value)
[ ] Bug: type choosing combobox dissapears
[ ] Add the semantic type choice

This issue has been mirrored in Jira: https://reddata.atlassian.net/browse/GROK-14770

Done with DevTools package


Device

add linuxdevice full test case

@wangkirin I just wondering when you did the linuxdevices test, do you need to start a runtime?

@liangchenye  you mean start a container like runc? yes , all of our test should start a runtime, because there is no dameon program. :)

Got it.
I'm working on a bundle validator, it also needs to test the existence of the mount points. Just want to sure if we were doing the same thing.
Thanks for clarify.


Unable to reproduce results

Hi, thanks for providing this model. I'm struggling with replicating the results using the files provided in the repository. Some of the paths do not seem to exist (e.g. the pseudo-labels), and the final model weights used in the paper don't seem to be available. Would you be able to upload these and add a short tutorial on how to reproduce everything?

Yeah, can't get the pseudolabelling to work. From where do the long/short preds/stds come from? The format doesn't match the output of predict.py, so I'm lost. @Shujun-He are you able to help?

Hi @supersubscript! Did you come up with a solution in the end? I am trying to replicate the work as well right now. Would appreciate any insights, if I come up with a solution in the meantime I will share it.

Hi, @f-krause! I had to spend quite a bit of time refactoring the code-base to get something running, but I couldn't replicate the stated performance in the end. The authors have published some new work - you may be interested in looking at https://github.com/Shujun-He/RibonanzaNet

Thanks for the hint @supersubscript! I will check it out. Would you mind sharing the (probably predict.py) file you refactored to obtain the pseudo labels?

Err, I had a look, but I don't think I have that code around still. I did a pretty massive rehaul of the code though, so not just predict.py. The pseudolabelling part in particular is not well documented, so in some instances I had to make assumptions.
Sorry I can't help more than this. I think looking at the ribonanzanet code may set you off in the right direction though.
Best of luck!

No worries, your input is very much appreciated! Thanks! :)
I now constructed some way to create the pseudo labels but also making several assumptions. If results get close to the paper, I might create a PR here to provide a possible solution to this issue.

Sounds great. If it's of any help I think my reactivity R2 for the main dataset was around 0.59, but I didn't spend much time trying to push it, and I can't quite remember whether that was with CV or not

I created a PR with my work on replicating the results in the paper. By making my own assumptions on how to generate the pseudo labels, I could obtain very similar results to He et al.
Feel free to check out my PR #5.

Thanks for this, @f-krause - great work! :)


Melee misclicks are a bit too punishing

Consider:

Clicking yourself does full damage. If you're a dragon or some other animated / large entity it's very to misclick yourself and people can dance under you. While funny in ss13 we have mob stacking and don't have mob collisions so think it should be turned off, but I'd also settle for heavily reducing the damage (like 1/10 or 1/5) to be far less punishing than it is.

I think hitting wires doesn't shock you anymore(?) which is good, at least when I tried on dev map, coz that was also brutally punishing.

unrobust players should punish themselves, its a self solving issue really

What if everything was left as-is, except mobs stacked on top of you would be prioritized by hovering.
Maybe give them an artificially larger 2nd hitbox so they show on top of your sprite even if your mouse cursor isn't directly on top.
It kinda solves the mobstacking issue and still allows for the big silly and a higher skill ceiling.

cap gloves are insuls and im pretty sure hitting wires, with unlucky budgets at least, still shocks you as of like yesterday

also i dont think dragon/fish/tick/etc should be able to bite itself it makes no sense

Self hitting is annoying and its only use in self cauterizing with a welder
It just punishes mobs without wide swing even harder


Fix typo "it's" -> "its".

See: http://grammarist.com/spelling/its-its/

By analyzing the blame information on this pull request, we identified @spicyj and @foghina to be potential reviewers.

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at<EMAIL_ADDRESS>Thanks!

@facebook-github-bot shipit

I cannot do that @foghina, because @follower does not have an active CLA on file.

FYI I'm not going to sign the CLA for this change.

Sorry about this. We don't really need a CLA for trivial changes but I guess the bot is more aggressive.


Handle out of memory panics at a global level?

Talking with Paul quickly, it sounds like this might be possible. Is there a way we can wrap the server process and catch these so that the server returns a 500 instead of dying?
Example stack trace:
[query] 2015/09/24 13:10:50 SELECT * FROM "analytics"."default"./.*/
fatal error: runtime: out of memory

runtime stack:
runtime.throw(0xc58a40, 0x16)
	/home/philip/.gvm/gos/go1.5/src/runtime/panic.go:527 +0x90
runtime.sysMap(0xc853e00000, 0x100000, 0x195d00, 0x10235f8)
	/home/philip/.gvm/gos/go1.5/src/runtime/mem_linux.go:143 +0x9b
runtime.mHeap_SysAlloc(0x1003980, 0x100000, 0x0)
	/home/philip/.gvm/gos/go1.5/src/runtime/malloc.go:423 +0x160
runtime.mHeap_Grow(0x1003980, 0x8, 0x0)
	/home/philip/.gvm/gos/go1.5/src/runtime/mheap.go:628 +0x63
runtime.mHeap_AllocSpanLocked(0x1003980, 0x1, 0x7fa916d1b0a0)
	/home/philip/.gvm/gos/go1.5/src/runtime/mheap.go:532 +0x5f1
runtime.mHeap_Alloc_m(0x1003980, 0x1, 0x7f0000000013, 0x7fa916d1b0a0)

You would have to trap the panic at the entry point to the program (effectively main.go for cmd/influxd).  You can't catch a panic in a defer/recover for a process that you didn't spawn.

Or I guess we could wrap our query engine in a defer/recover (or parts of it) and let it return an error when it panics.

@corylanou -- can you trap "fatal" errors? This doesn't look like a panic.

ah, nope, fatal is effectively panic() + os.Exit() doh!

OK, then a diaper pattern sounds doable.
http://mike.pirnat.com/2009/05/09/the-diaper-pattern-stinks/

Oh, @corylanou when you said "effectively" you didn't mean "actually is". I misread your comment.

correct, so as far as I know, this can't be done.  See this example: http://play.golang.org/p/_Jf1FL8J6r

log.Fatal goes through a different path than runtime fatal errors.
Runtime fatal errors cannot be caught. The defers will be run, but after a recover, the process exits

Also hitting this very regularly - similar stack trace as the first post above.
In our case WAL flushes trigger OOM - similar to OOM during bulk load issues reported else where.
Eg:
[wal] 2015/09/25 11:41:21 Flush due to memory. Flushing 118163 series with 617864 points and 10503688 bytes from partition 1
[wal] 2015/09/25 11:41:23 write to index of partition 1 took 4.093154367s
fatal error: runtime: out of memory

runtime stack:
runtime.throw(0xc58a40, 0x16)
        /home/philip/.gvm/gos/go1.5/src/runtime/panic.go:527 +0x90
runtime.sysMap(0xc957460000, 0x100000, 0x2acaf31f7000, 0x10235f8)
        /home/philip/.gvm/gos/go1.5/src/runtime/mem_linux.go:143 +0x9b
runtime.mHeap_SysAlloc(0x1003980, 0x100000, 0x0)
        /home/philip/.gvm/gos/go1.5/src/runtime/malloc.go:423 +0x160
<snip>

Even if we could catch OOM errors, there's not much we could do since handling them would probably involve creating at least one object which would, in turn, cause an OOM.
@pkittenis how much RAM are you running with? Also, how long is influx running before the OOM occurs?

16GB RAM on the server, influxdb using ~8GB resident. DB size is ~34GB at the moment but OOM happens even on a new DB.
  PID USER      PR  NI  VIRT  RES  SHR S %CPU %MEM    TIME+  COMMAND
18710 influxdb  20   0 49.4g 7.7g 3.0g S 11.7 49.4  51:26.49 influxd```

Run time is anything from a few minutes to a few hours before it OOM. Seems to be triggered by a spike of incoming metrics that cause a WAL flush due to memory, as above stack trace.

Latest OOM just now after 3 hours of run time.
[wal] 2015/09/25 14:14:23 Flush due to memory. Flushing 120522 series with 618329 points and 10511593 bytes from partition 1
[wal] 2015/09/25 14:14:23 Flush due to idle. Flushing 141 series with 141 points and 4413 bytes from partition 1
[wal] 2015/09/25 14:14:23 write to index of partition 1 took 645.136527ms
fatal error: runtime: out of memory

runtime stack:
runtime.throw(0xc58a40, 0x16)
        /home/philip/.gvm/gos/go1.5/src/runtime/panic.go:527 +0x90
runtime.sysMap(0xc955a10000, 0x100000, 0x195d00, 0x10235f8)
        /home/philip/.gvm/gos/go1.5/src/runtime/mem_linux.go:143 +0x9b
runtime.mHeap_SysAlloc(0x1003980, 0x100000, 0x0)
        /home/philip/.gvm/gos/go1.5/src/runtime/malloc.go:423 +0x160
runtime.mHeap_Grow(0x1003980, 0x8, 0x0)
        /home/philip/.gvm/gos/go1.5/src/runtime/mheap.go:628 +0x63

Even if we could catch OOM errors, there's not much we could do since handling them would probably involve creating at least one object which would, in turn, cause an OOM.

It's not unheard of to set aside a "rainy day fund" at the beginning of a program, and then free it in an OOM scenario to better handle the error. It may not be enough free memory to allow you to fully recover from the OOM, but it could potentially be enough to dump a bit more information about what went wrong.

@pkittenis A memory profile would be great! You can run:
$ go tool pprof -svg -output heap.svg /path/to/influxd http://localhost:6060/debug/pprof/heap

Then just send the heap.svg file that's output.
@mark-rushakoff a rainy day fund works for C but it seems difficult to do with a GC language like Go.

@benbjohnson I try to run this to dig into my OOM issues on a new install and get:
Fetching profile from http://localhost:8086/debug/pprof/heap
parsing profile: unexpected number of sample values: got 0, want 6

@benbjohnson Here is a SVG for my setup, single node (r3.xlarge), 96% memory usage, ~4GB of data with 20M/s being send to server (according to AWS). Currently takes 5 minutes to restart db. One a fresh database everything is fast but eventually OOM about 6 hours in. On restart, it doesn't stay up for long.
http://imgh.us/heap.svg

Hi,
Here is heap SVG a few seconds before the process OOM.
[wal] 2015/09/29 16:09:17 write to index of partition 1 took 7.737877299s
[wal] 2015/09/29 16:09:17 write to index of partition 1 took 7.415779513s
[wal] 2015/09/29 16:09:17 write to index of partition 1 took 713.386871ms
[wal] 2015/09/29 16:09:17 write to index of partition 1 took 7.482164418s
[wal] 2015/09/29 16:09:19 Flush due to memory. Flushing 120432 series with 618795 points and 10519515 bytes from partition 1
[wal] 2015/09/29 16:09:20 Flush due to idle. Flushing 83 series with 84 points and 1428 bytes from partition 1
[wal] 2015/09/29 16:09:20 write to index of partition 1 took 12.886874ms
fatal error: runtime: out of memory

We can't handle OOM like this, co closing.


Preview window does not respect --color fg bg values

[x] I have read through the manual page (man fzf)
[x] I have the latest version of fzf
[x] I have searched through the existing issues

Info

OS

[ ] Linux
[x] Mac OS X
[ ] Windows
[ ] Etc.

Shell

[ ] bash
[x] zsh
[ ] fish

Problem / Steps to reproduce
I'm not sure whether this is a regression, or by design change (MAN page is not clear on this), but --color no longer respects values set in fg, bg.
The following example used to produce the desired result:
fzf -n 1 --preview 'echo {}' --preview-window wrap --ansi --color dark,fg:246,bg:235,bg+:236 --no-height --border=rounded

With the latest version (0.4.0) it no longer does, and the following is required:
fzf -n 1 --preview 'echo {}' --preview-window wrap --ansi --color dark,preview-fg:246,preview-bg:235,bg+:236 --no-height --border=rounded

Here's an example how this used to work in vim-go: https://github.com/fatih/vim-go/blob/master/autoload/fzf/decls.vim?plain=1#L137
Please close if it's expected behavior. I'll file an issue to vim-go then.

I went as far back as 0.26.0 which might have been the first version where build was supported on arm64. Did not manage to reproduce the original behavior. So I'm quite confused now about how this ever worked (in which I'm pretty sure it did).

The following example used to produce the desired result:

What do you expect from the command? What is different from your expectation?
The two commands work as expected. I don't see anything strange.

This is what I see:

This is what I expect:

And if I set --color dark,fg:246,bg:235,preview-fg:246,preview-bg:235,bg+:236 I see (having toggled the preview window on):

I've figured out that the colors passed to the fzf command are actually wrong. When I post hex values I get the expected result. So all good with fzf, sorry (:


Add cargo-rdme to supported tools

The change in https://github.com/taiki-e/install-action/pull/265/commits/6b8955b3299acaef59f0307929e4d6eb7947375c uses the release zip files instead of the zst files (which CI seems to choke on)

zst files

To use tar.zst, you have to add *.tar.zst branch to this case block.

zst files

To use tar.zst, you have to add *.tar.zst case to this case block.

I noticed that - figured I'd try to avoid it instead, not sure why the bin location was broken in the previous CI run, but figure it's better to just add zstd instead.

Whew - got some green now at least :D Still failing a few OSes though.

Removed the zstd code as it was incompatible with macos-11, alpine, almalinux, centos (using bz2 and zip files from cargo-rdme instead). I'm sure there's a way to get that going, but my goal was not to make zstd work for install-action, it was to just get cargo-rdme available as a tool for CI.
Last change was fixing the tidy dictionary for rdme.

Finally all the checks are passing on this (I love when CI servers make me feel like the biggest noob :)) I've rebased the PR on main in the last push to make it easy to merge.

Published in 2.21.0.


fix sublists in changelog [ci skip]

sublists did not render properly with GitHub-flavoured Markdown

:+1:
https://github.com/znc/znc/pull/856/files?short_path=e705c8f#diff-e705c8fadf1193ab59443a5e6c8cbe8b shows the difference clearly.

:+1:

https://github.com/znc/znc/commit/c5ab7337d2a2503e6c3b20e4b081c19914ac082e


Server-Time difference.

I hosted the stkPush, but it will not work, unless you have this:
date_default_timezone_set('Africa/Nairobi');
Right before getting the TimeStamp.
This is notorious when working with offshore servers that are a day behind.

Fixed, Thanks for pointing out.

my code is returning my access_token key. any help please?
On Fri, 15 Mar 2019 at 22:36, Ben Njunge<EMAIL_ADDRESS>wrote:

Fixed, Thanks for pointing out.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bnjunge/MPESA-API-Tutorial/issues/1#issuecomment-473416001,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AY5QT0eKa-BO2UroyPAXoKk_O4WUE8nnks5vW_Y8gaJpZM4baW6f
.


Scan  xcodebuild -list timed-out after 10 seconds

New Issue Checklist

[x] Updated fastlane to the latest version
[x] I have read the Contribution Guidelines

Issue Description
I used Scan for running my XCUI Tests. On the one mac mini i have an error " xcodebuild -list timed-out after 10 seconds. You might need to recreate the user schemes. You can override the timeout value with the environment variable FASTLANE_XCODE_LIST_TIMEOUT". I tried to set env var by export (I can see this var by printenv)
, but it doesn't help me. Should I
a)somehow set FastFile or
b) set this variable as param of scan like "scan -p 'FASTLANE_XCODE_LIST_TIMEOUT=120'" or
c) need to necessarily use fastlane for that (i do not wanna provide apple ID for that)
Complete output when running fastlane, including the stack trace and command used
scan -s 'MyScheme'
[!] xcodebuild -list timed-out after 10 seconds. You might need to recreate the user schemes. You can override the timeout value with the environment variable FASTLANE_XCODE_LIST_TIMEOUT

Configuration Files
Please copy the complete content of your Fastfile and any other configuration files you use below:
Fastfile:
# INSERT CONTENT HERE

Environment
fastlane version (run fastlane -v): scan 0.11.3
Do you use bundler to execute fastlane (i.e. bundle exec fastlane)? no
Do you use a Ruby environment manager (e.g. chruby, rbenv, rvm)? no

Hi @n4me1ess Here is an example lane with env setup:
  lane :my_app_continuous do
    ENV['APP'] = "ch.my.app.name"
    ENV['FASTLANE_XCODE_LIST_TIMEOUT'] = '600'
    ENV['FL_UNLOCK_KEYCHAIN_PATH'] = 'login.keychain'
    ENV['FL_UNLOCK_KEYCHAIN_PASSWORD'] = 'password'
    unlock_keychain
  end

Tnx, @TKBurner . Maybe it will help smb, I decide my problem by  fastlane scan1, my Fastfile:
desc "Runs all the tests"
 lane :scan1 do
  ENV["FASTLANE_XCODE_LIST_TIMEOUT"] = "120"
  scan(scheme: "MyScheme")
 end


fix plot's aspect ratio to fit all labels

@wanqqq31 I found that the completion rate plots cannot show labels when more than ~5 priorities are in the target list. I made a quick fix (you can see the screenshot in the "File changed" section). Do you mind if this change is merged? I think you have some thoughts when you made the original plots.

Thanks for the revision. I personally do not like to extend the height of plots that much.. I made some revisions to separate the legend into two columns. Now I think all P0-9 label can be seen. But please let me know you have any concerns.

Thanks! I didn't know about these options for the legend configuration. I further made micro-adjustments.

legend_columns is 1 if the number of priorities is less than 6.
put a small space between the plot and legend to avoid overlapping with axis labels.

The screenshot in the document is also updated.

Thanks! It looks good.


Modernize bililiteRange

The edge branch is where I am working on updating bililiteRange into the modern world.
Still to do:

[x] Factor toolbar, history, and keymap into their own projects
[x] Remove IE support
[x] Use Qunit 3 for testing
[x] Use modern input events including inputType, and add a complete diff to allow for unod/redo
[x] Refactor find into bounds
[x] Undo should use History
[x] bounds start and end for words, lines, paragraphs, sections
[x] add magic option for regexp
[x] ex should use data.stdout and data.stderr for messages (with options for statusbar)
[x] ex should use localstorage (read/write commands) (with options for $.ajax). Still need tests for save status and errors.
[x] Concede that I will never finish vi, and adapt ex map for keymap and toolbar commands.


ListBox and ListBoxItem was not found in 'react-yandex-maps'

export 'ListBox' was not found in 'react-yandex-maps'
export 'ListBoxItem' was not found in 'react-yandex-maps'
version 2.1.0
react-yandex-maps/es/index.js
export { YMaps } from './YMaps';
export { Map } from './Map';

export { GeoObject } from './GeoObject';
export { ObjectManager } from './ObjectManager';
export { Clusterer } from './Clusterer';
export { Control } from './Control';

export { Placemark, Polyline, Rectangle, Polygon, Circle } from './Helpers';

export { Button, FullscreenControl, GeolocationControl, RouteEditor, RulerControl, SearchControl, TrafficControl, TypeSelector, ZoomControl } from './Helpers';

Hi @Dictory
Something went wrong during release, thanks for noticing! Should be fixed in 2.1.1, could you check and report back?

@gribnoysup, yup, that work. Thanks.


feat: add rancher RKE2 support

Enable installation on RKE2.
I would like to add this feature also to the Go rewrite, but I didn't understand how the distribution detection mechanism works.

It seems the failure is unrelated with my PR :(

Thanks for the PR @flavio, RKE2 support is great!
The go installer doesn't have K8s distribution detection yet, so you can't find it yet 😊.
The build pipeline issue is fixed. Could you please rebase your commit?
What do you consider the easiest way to set up and test an RKE2 cluster?

@0xE282B0 I've rebased :)
Thanks for the explanation about the go-rewrite branch

Thank you @flavio, LGTM!


Fix draw polygons for mouse events on devices with touch screens.

https://github.com/Leaflet/Leaflet.draw/issues/624

Executed 12 of 12 SUCCESS (0.051 secs / 0.015 secs)

This can be tested here https://b3ncr.github.io/docs/examples/full.html

I'm closing this for the reasons mentioned in the comments above. I'm replacing it with this...
https://github.com/Leaflet/Leaflet.draw/pull/640


Add a wiki: CookieWiki

Link to origin wiki: https://cookie.fandom.com/zh
Link to destination (independent) wiki: https://cookie.wiki/

Thank you for the submission! Added in v3.7.0 (now available for Chrome, release pending for Firefox).


[Event-Request] Codeunit 5857 "Copy Invt. Document Mgt." - OnBeforeFindFromInvtRcptLine

Describe the request
Please add event OnBeforeFindFromInvtRcptLine() in Codeunit 5857 "Copy Invt. Document Mgt." in procedure CopyItemDoc before FromInvtRcptLine.Find('-') on 226 row:
OnBeforeFindFromInvtRcptLine(FromInvtRcptLine);
if FromInvtRcptLine.Find('-') then
repeat
FromInvtDocLine.TransferFields(FromInvtRcptLine);
CopyInvtDocLine(
ToInvtDocHeader, ToInvtDocLine, FromInvtDocHeader, FromInvtDocLine,
NextLineNo, LinesNotCopied, LinesSkipApplies);
until FromInvtRcptLine.Next() = 0;

[IntegrationEvent(false, false)]
local procedure OnBeforeFindFromInvtRcptLine(var FromInvtRcptLine: Record "Invt. Receipt Line")
begin
end;

Additional context
We need this event to CalcFields in Invt. Receipt Line before loop
Internal work item: AB#554333

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. Please do not reply to this, as we do not monitor closed issues. If you have follow-up questions or requests, please create a new issue where you reference this one.
Build ID: 25639.


logs search hitting OOM

drc-discord-1  |
drc-discord-1  | <--- Last few GCs --->
drc-discord-1  |
drc-discord-1  | [1:0xe80e5c0]   265448 ms: Mark-sweep 2023.3 (2077.6) -> 2006.8 (2074.6) MB, 1818.4 / 0.0 ms  (average mu = 0.247, current mu = 0.179) task scavenge might not succeed
drc-discord-1  | [1:0xe80e5c0]   267660 ms: Mark-sweep 2028.1 (2082.6) -> 2009.7 (2077.3) MB, 2079.4 / 0.0 ms  (average mu = 0.157, current mu = 0.060) task scavenge might not succeed
drc-discord-1  | [1:0xe80e5c0]   269780 ms: Mark-sweep 2030.6 (2084.7) -> 2012.5 (2080.1) MB, 1999.8 / 0.0 ms  (average mu = 0.109, current mu = 0.057) task scavenge might not succeed
drc-discord-1  |
drc-discord-1  |
drc-discord-1  | <--- JS stacktrace --->
drc-discord-1  |
drc-discord-1  | FATAL ERROR: Ineffective mark-compacts near heap limit Allocation failed - JavaScript heap out of memory
drc-discord-1  |  1: 0xaf5310 node::Abort() [node]
drc-discord-1  |  2: 0xa1ea88 node::FatalError(char const*, char const*) [node]
drc-discord-1  |  3: 0xcbc7e0 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [node]
drc-discord-1  |  4: 0xcbc96c v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [node]
drc-discord-1  |  5: 0xe6a2e0 v8::internal::Heap::EnsureFromSpaceIsCommitted() [node]
drc-discord-1  |  6: 0xe6ad30  [node]
drc-discord-1  |  7: 0xe78c08  [node]
drc-discord-1  |  8: 0xe79408 v8::internal::Heap::CollectGarbage(v8::internal::AllocationSpace, v8::internal::GarbageCollectionReason, v8::GCCallbackFlags) [node]
drc-discord-1  |  9: 0xed6784 v8::internal::ScavengeJob::Task::RunInternal() [node]
drc-discord-1  | 10: 0xd7f73c non-virtual thunk to v8::internal::CancelableTask::Run() [node]
drc-discord-1  | 11: 0xb57610 node::PerIsolatePlatformData::RunForegroundTask(std::unique_ptr<v8::Task, std::default_delete<v8::Task> >) [node]
drc-discord-1  | 12: 0xb59380 node::PerIsolatePlatformData::FlushForegroundTasksInternal() [node]
drc-discord-1  | 13: 0x14b0ff4  [node]
drc-discord-1  | 14: 0x14c23c8  [node]
drc-discord-1  | 15: 0x14b1990 uv_run [node]
drc-discord-1  | 16: 0xa44f1c node::SpinEventLoop(node::Environment*) [node]
drc-discord-1  | 17: 0xb2ef80 node::NodeMainInstance::Run() [node]
drc-discord-1  | 18: 0xabff0c node::Start(int, char**) [node]
drc-discord-1  | 19: 0xffff80956d24 __libc_start_main [/lib/aarch64-linux-gnu/libc.so.6]
drc-discord-1  | 20: 0xa435b4  [node]
drc-discord-1 exited with code 133

Resolved by converting them to SQLite


feat(atomic): breadcrumb accessibility

https://coveord.atlassian.net/browse/KIT-237
Same aria-labels JSUI has

The X should be clickable.

The  $btn-focus-box-shadow: ''; shouldn't be transparent, so when a user uses the keyboard, he sees which breadcrumb is focused.


change speech emotes

About the PR

This PR makes vocal emotes slightly more like ss13's.
My only complaint? ALL OF THIS could be fixed with some kind of String.includes in EmoteSystem. I'm genuinely surprised this was missed in reviews, and I'm not going to change it because any conceivable way I'd fix it would be improper and against the coding style.
P.S. WHY ARE THESE NOT IN .FTLS!?

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl: router

tweak: Made sound emotes not abhorrent. You can now add some punctuation marks after emotes.

Can you link me the original PR.

Can you link me the original PR.

#12708

This will do until someone moves them to ftl


Multiple AWS credentials

I used one AWS credential for multiple S3 buckets, just a quick question for someone who may work around the issue that the helm chart allows to use different AWS S3 credentials for different buckets?

/triage support

I am not aware of a workaround, but we have a feature request open here https://github.com/awslabs/mountpoint-s3-csi-driver/issues/136. Please give it a thumbs up if it is important to you. Closing this issue and will track the enhancement request under the other ticket.


Added new --heading CLI option to change ADR page heading.

Changes:

Added new --heading option to change ADR page heading
Fixed missing  --template-dir option from README.md

Issues Fixed:

#4

@mrwilson - request to merge these completed PRs.....


Split problem_data.json

The problem_data.json file is very big. It's hard to edit it. Wouldn't it be easier if the problems were split across files? Each olympiad could have a folder and each year it's own separate file.

Makes total sense – our original plan was that as well. For now, I've created folders for each olympiad containing files for each year and a corresponding script to combine that data into the original problem_data.json. Instructions have been added to the README as well. We'll soon eliminate the requirement of running the script and make the webapp pull from the folders directly.
Hope this helps!


show node feature (request+ simple implementation)

Feature description:
An API function that, given a node inside the SVG diagram will pan and zoom to show this element  (ie. show area around its bounding box).

Reasons for adopting new feature
It is useful when showing SVG for things such as diagrams, maps, etc..  you would programmatically allow the developer to select a node (eg. by using svg.getElementById or other DOM API) and show it to the user by doing something like  panzoom.showNode(node)

Is this a breaking change? (How will this affect existing functionality)
Not a breaking change at all. It introduces easier panning/zooming to a node which is compatible with the existing panning API.

I needed this feature so implemented it myself,  I don't have the time to do a proper pull-request -  so I'm dropping it here if someone needs something similar,  or wants to pick-up the work and do a PR.
    function showNode(node) {
            const bbox = node.getBBox();

            // pan so the node is at the center
            const { width, height, realZoom } = this.getSizes()
            this.pan({
              x: -realZoom * (bbox.x - width / (realZoom * 2) + bbox.width / 2),
              y: -realZoom * (bbox.y - height / (realZoom * 2) + bbox.height / 2)
            })

            // we want to zoom in to see just around the node -
            const relativeZoom = this.getZoom();
             // this formula below could be improved... I found it worked nicely for my usecases but maybe it should controlled by a 2nd parameter to this function
            const desiredWidth = 50 * Math.sqrt(bbox.width / 25) * 11 * realZoom;
            this.zoom(relativeZoom * width / desiredWidth)
     }

+1 this is such a nice feature

Hi there! Can anybody tell me how to use the function above? I'm still learning JavaScript.
I have a SVG mind map with a bunch of groups. On click of each groups its children are revealed. Now I want to use this function in order to center the clicked group. So I have copied the code above into my JS, then on the event-click-handler of the group I call shownode();
Sadly it is not working and in the console it says: Cannot read properties of undefined (reading 'getBBox')
Any help would be appreciated! :)


Install the Python modules with setup.py

Currently the compiled Python modules are installed into a directory, PYTHON_DEST, which must be prepended to PYTHONPATH.
Modules are loaded as
import pGadgetron
import pStir
...

and it all goes fine. However, we should really be creating a sirf package, which can fit into a site-packages structure (system or conda). The consequence is that imports will look different
from sirf import pGadgetron
from sirf import pStir
...

This would be backward-incompatible. We could provide separate pGadgetron and pStir packages which depend on each other. We could also make these aliases for sirf.pGadgetron/pStir, thus remaining backward-compatible

Note that this should probably be a SIRF issue as well. (Should there be a setup.py in SIRF?) Similar STIR issue is https://github.com/UCL/STIR/issues/5.
Note that this won't solve the problem of needing to set the LD_LIBRARY_PATH (or a similar variable for your OS) to find shared libraries at run-time.

Actually setup.py can handle that too (if by shared libs you mean the swig-generated python ones eg _py*.so)

great, but also gadgetron, ismrmrd, boost, ...

@paskino,@casperdcl, this issue can be closed?

closed by https://github.com/CCPPETMR/SIRF/pull/163 (related: #109, #112)


Is there a way to have a daily breakdown?

hi! thank you for this awesome script, but I'm having issues recreating a "simple" report: what I want to do is get four columns, Day, Campaign Name, Click, Amount Spent.
Day and Campaign Name would be the "breakdowns" and Click and Amount Spent the "fields" or "metrics".
But I don't see anything in the documentation to add simple Day and Campaign Name breakdowns. Am I missing something?

ok, never mind, just realized that's what the TIME_INCREMENT param does for the specified date_range.


i can't create discord appeal :c

Did you follow the steps outline in the README?

[x] Yes I did
[ ] No, I found them confusing

Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

Browser [e.g. chrome, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

ZKSYNC server or whatever it is, didn't fully configured the application and therefor, it's showing you this link. Your best way to reach out would be through social media.


Disallow empty binding patterns

It's currently being discussed whether or not an empty binding pattern should be an early error.
See https://github.com/tc39/ecma262/issues/97

Note: Outcome in linked bug was to continue to allow empty binding patterns.
That said, we should think carefully about how this ought to work in TypeScript since we have more user-side syntactic ambiguity and might want to make this an error.

Consider #5586 while discussing this.

If ES6 was willing to justify this, we're OK with it too.


I can build and start the project in macosx's termial, but it can't run correct in my chrome, it throw the error as can't get app-xxxx.js and vendor-xxxx.js

What are you doing to run it ? Are you running
npm install
npm start

and then go to localhost:3000. I'm using it on OSX and Chrome and it is working

Unfortunately, I cannot reproduce this. If you can provide more details I'd be happy to help. Thanks!


modifyEager sometimes causes eager results not to be returned

The simple eager query works well and includes all of the results. But when sometimes modifyEager causes an empty eager array to be returned;
Simple Example works well:
const users = await User.query()
    .eager('[roles, log_auth]')

[
    {
      "id": 1,
      "email"<EMAIL_ADDRESS>      "roles": [
        {
          "id": 2,
          "slug": "member-subscripted",
          "name": "Member with a paid subscription",
          "group": "MEMBER",
        }...
      ],
      "log_auth": [
        {
          "id": 1,
          "created_at": "2017-02-23T23:54:35.000Z",
          "user_id": 1
        }...
      ]
    }
  ]

Sometimes modifyEager works:
const users = await User.query()
    .eager('[roles, log_auth]')
    .modifyEager('roles', builder => {
      builder.select('roles.slug');
    })

[
    {
      "id": 1,
      "email"<EMAIL_ADDRESS>      "roles": [
        {
          "slug": "member-subscripted"
        }...
      ],
      "log_auth": [
        {
          "id": 1,
          "created_at": "2017-02-23T23:54:35.000Z",
          "user_id": 1
        }...
      ]
    }
  ]

But other times it doesn't:
const users = await User.query()
    .eager('[roles, log_auth]')
    .modifyEager('log_auth', builder => {
      builder.select('log_auth.created_at');
    })

[
    {
      "id": 1,
      "email"<EMAIL_ADDRESS>      "roles": [
        {
          "id": 2,
          "slug": "member-subscripted",
          "name": "Member with a paid subscription",
          "group": "MEMBER",
        }...
      ],
      "log_auth": []
    }
  ]

environment info:
<EMAIL_ADDRESS><EMAIL_ADDRESS>mysql server version 5.7

Can you include the relation defintion from the User to the roles and log_auth?
I've experienced issues like this when I don't select columns necessary to make the relation connection...Usually this involves omitting the id or foreign key from the select.
Maybe this is your issue?

That was definitely the issue. Roles is a ManyToManyRelation while log_auth is a HasManyRelation and I had been excluding the foreign key column.
Thanks for looking at this and pointing me in the right direction. The only other JS ORM I'd used was such a bad experience that I've been building JS apps with raw sql queries for years now. I'm still just starting with it but Objection has been a breath of fresh air so far.  Out of curiosity though, is there a reason the necessary join columns are not forced under the hood?

@lucascolvin glad that was it and I could help...and yes, I'm really liking Objection a lot as well!
I think there are a few things at play here. As specified in the docs, the default eagerAlgorithm used in a an eager is not a JOIN, but actually n number of additional SQL calls made using where x in (...) to get the related records of those found during the SELECT on the Parent object/table. Typically the results from these queries are parsed, converted into instances and added onto the Parent record appropriately. But, as we've experienced, not selecting the required column(s) (usually id) from the Parent will leave Objection unable to create an appropriate WHERE x IN (...) for the related queries.  But that doesn't mean it won't still try 😄 Look at this info I found after setting Knex debug to true and trying to eager load a relation called broadcasts off of the parent Campaign after explicitly not selecting the id column from the campaigns table:
{ method: 'select',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 'CAMXXXXXXXXXXXXXX ],
  __knexQueryUid: 'be49bb67-8298-4d52-b7ab-e872b5fcadd4',
  sql: 'select "type" from "campaigns" where "id" = ?' }
{ method: 'select',
  options: {},
  timeout: false,
  cancelOnTimeout: false,
  bindings: [ 0 ],
  __knexQueryUid: 'd52f54d4-29ec-4b64-914c-10bf9d7cffc7',
  sql: 'select * from "broadcasts" where 1 = ?' }

(Side note - This is an unusual 2nd query as I believe it ends up as: select * from "broadcasts" where 1 = 0? Why even bother to run that query? Any clue what's going on with this one, @koskimas ?)
My first thought on why Objection was not ensuring the necessary fields that define a relation between two Models were part of the SELECT on the Parent Model was that Objection didn't like the idea of going against the developer's explicit wishes: i.e. "select this/these and only this/these, even if I'm (unintentionally) making it impossible to join relations because of it". However, when I modified the code to use the JoinEagerAlgorithm, things worked just fine (though I had some "ambiguity" errors I needed to address that were unexpected). Here's the knex debug:
{ method: 'select',
options: {},
timeout: false,
cancelOnTimeout: false,
bindings: [ 'CAMXXXXXXXXXXXXXX' ],
__knexQueryUid: 'c8dc9486-6dd9-479c-81ae-afd5668e92d1',
sql: 'select "campaigns"."type", "campaigns"."id" as "id", "campaigns"."type" as "type", "broadcasts"."id" as "broadcasts:id", "broadcasts"."type" as "broadcasts:type", "broadcasts"."content" as "broadcasts:content" from "campaigns" as "campaigns" left join (select "id", "type", "content", "campaign_id" from "broadcasts") as "broadcasts" on "broadcasts"."campaign_id" = "campaigns"."id" where "campaigns"."id" = ?' }

As you can see there, Objection is not shy about adding the necessary "campaigns"."id" to the SELECT. So I'm left thinking it's a bug and hoping that @koskimas can shed some light?

@newhouse I can definitely respect the reasoning that Objection shouldn't be adding too much unneeded "helpfulness". As you say though, it does seem odd that some kinds of relations prioritize the relation and others prioritize the column filter.
Thanks for digging into it though. At very lease, knowing about it I can work around with some array.map filters after the query. Not as beautiful as having it baked in but its workable.

I'm not sure overloading toJSON is a good thing, it's not public API AFAIK. I personally overload $formatJson in my base model:
const { omit } = require('lodash')
class BaseModel extends objection.Model {
  $formatJson (json, options) {
    json = super.$formatJson(json, options)
    if (this.constructor.hiddenColumns)
      json = omit(json, this.constructor.hiddenColumns)
    return json
  }
}

And if I want to hide something, I define a static array onto said model:
class User extends BaseModel {
  static get hiddenColumns () {
    return ['password']
  }
}

This is a really common issue. I'll take a look if we could automatically select and then strip the join columns just like @lucascolvin suggested.
The JoinEagerAlgorithm already does this because I was aware of this issue when I wrote it. It was designed to easily work like this. That's the only reason why they work differently.
@newhouse where 1 = 0 happens when you call .whereIn('blaa', []) on knex.