Build new generator that uses https://www.gharchive.org/ S3 tarballs to generate sitemap for a whole week previous

Cheaper than BQ, Actions make storage expensive but CPU/MEM/BW are cheap!

Completed by https://github.com/nelsonjchen/github-wiki-see-rs-sitemaps/commit/db963cf56e20e6c5168f6326e342b7027589575b


fix: quote host parameter for HeidiSQL and prevent argument double quoting

The Issue
When launching HeidiSQL via ddev heidisql there is an additional double quote at the end of each database connection name. If you remove the double quotes from the arguments the host parameter must be written in double quotes as the documentation suggests it (Docu: https://www.heidisql.com/help.php#commandline).
How This PR Solves The Issue
This PR removes the double quotes at the end of the string and adds them to the host parameter.
Manual Testing Instructions
Runddev heidisql to start HeidiSQL from WSL2 with correct name.
Automated Testing Overview

Related Issue Link(s)
Release/Deployment Notes

Thanks for the contribution!
We would have reopened this for you, you didn't have to delete it, just needed the title adjusted :)
From the other PR:

Last I tested this it worked OK. What is the symptom that you encountered?

OK didn't know that 🙂
The command itself worked fine but in the connection manager of HeidiSQL shows an additional double quote at the end (have a look at the screenshot). And this happens because of the quotation of $arguments than HeidiSQL adds the last double quote to the database description name.

Additionally I found at that the host parameter need to be embedded in double quotes according to documentation of HeidiSQL.


feat: add swift 5.10

Proposed Changes

Added swift 5.10 to CI

Checklist

[ ] CHANGELOG.md updated
[x] Rebased/mergeable
[x] swift test completes successfully
[x] Commit messages are conventional
[x] Sign CLA (if not already signed)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 65.09%. Comparing base (4b7e4b9) to head (dbe487e).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #66       +/-   ##
===========================================
+ Coverage   42.31%   65.09%   +22.77%
===========================================
  Files         145       17      -128
  Lines       10473     1338     -9135
===========================================
- Hits         4432      871     -3561
+ Misses       6041      467     -5574

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Pressure testing is over, but RPS and Users still have data

Prerequisites

[X] I am using the latest version of Locust
[X] I am reporting a bug, not asking a question

Description
As shown in the figure below, when the pressure measurement stops, but RPS and Users still have data, only RT does not.

Command line
locust -f gloria_test.py --reset-stats --master --web-login && locust -f gloria_test.py --reset-stats --worker --web-login
Locustfile contents
Nothing to do with content, the simplest will reproduce

Python version
3.11.0
Locust version
2.31.3
Operating system
amzn2023.x86_64

I noticed this as well. @andrewbaldwin44 can you have a look? Its not urgent so maybe after next weeks meetings..


find_if is not a member of std::ranges and more

googled it and alas no results at all. tried including algorithm, redoing includes doesnt fix it

update your MSVC to latest version to support c++20 preview functions


Regular polygon confusing alignment behavior

The alignment behavior for RegularPolygon seems to be different than for other objects. From what I can see most objects get aligned by bounding box. However if you ask for RegularPolygon to be centered it gets aligned according to the circumscribed circle.
The left image is what happens if you give align = Align.CENTER while the right is what would normally happen.

Is this intended? The docs do not mention this but there are tests enforcing this behavior: https://github.com/gumyr/build123d/blob/47814adfa6b07ae85f69b98582560ef0c3ab94f8/tests/test_build_sketch.py#L296-L303
edit: this test is enforcing this behavior as the default arg for align is (Align.CENTER, Align.CENTER)

This is intentional behavior and we are unlikely to change it. This is documented on this page of the docs, including one example specifically for triangles. https://build123d.readthedocs.io/en/latest/center.html
As mentioned on that page, there is even an enum to control this: CenterOf.

Fair enough, dunno how I missed that page in the docs.


Make static content paths in proxy exports absolute

Changes
See context in this discussion.
Currently, I've made the new behaviour here the only option, although we may want to put this behind a config toggle. Some further discussion on this would be a good idea.
Testing
This change was tested on the minimal reproduction repo linked in the discussion. Not sure if we want a unit test created for this functionality, since there doesn't seem to have been one before it. If we do want one though, I can contribute one.
Docs
Public documentation has not been updated, since this change is largely an internal one that most users won't notice, although if we do place this change behind a config toggle, we should document that.

Any update on this? It's been a while, and this issue is preventing me from using Snowpack in my projects :sweat_smile:

I also am interested in this one - we've linked to it in the single-spa docs as a pending PR to get better support for single-spa microfrontends + snowpack: https://single-spa.js.org/docs/ecosystem-snowpack. We're open to an alternative approach - the goal is just to load static assets cross site when doing local dev.

I've come up with a much simpler and nicer way to solve this issue, and that's to make the proxy files look like the following:
export default new URL("/path/to/static/file.png", import.meta.url).href;

The same thing is achieved, however it no longer relies on the value of baseUrl at build time, and instead uses import.meta.url to determine what the correct base URL is at runtime. Using a new URL ensures that the two parts are stuck together correctly. I'm still open to discussions regarding putting this behind a config option - I think we should, and I'm open to ideas as to what the option should be.

Are you using import.meta.url at runtime in production builds? If so, wouldn't that approach break things for people using the webpack builder, or not using ES modules in production, since import.meta.url is only defined in some browsers and only is defined within ES modules?

Are you using import.meta.url at runtime in production builds? If so, wouldn't that approach break things for people using the webpack builder, or not using ES modules in production, since import.meta.url is only defined in some browsers and only is defined within ES modules?

Wouldn't the webpack bundler handle this functionality with its own loaders anyway, bypassing these proxies?

Webpack converts import.meta.url into the file path of the current file. In webpack, the public path is the URL path that should be used as a prefix to load code splits and other assets.
With that said, I'm not sure the order of operations here - if the import.meta.url is not included in the webpack bundle, then that's fine. But if it is included in the bundle, then it won't point to the correct URL since it refers to a build-time file path rather than a runtime URL.

I'm also very keen on being able to serve assets cross-site during development in order to support having the index.html served by a Django devserver.
Is there anything we can do to move this forward?

Webpack converts import.meta.url into the file path of the current file. In webpack, the public path is the URL path that should be used as a prefix to load code splits and other assets.
With that said, I'm not sure the order of operations here - if the import.meta.url is not included in the webpack bundle, then that's fine. But if it is included in the bundle, then it won't point to the correct URL since it refers to a build-time file path rather than a runtime URL.

Just ran a test locally with a single-spa microfrontend bundled with webpack and systemjs - no issues. As I expected, file-loader in webpack takes care of making static assets work the way the should. The proxy files do exist in the build output, but the bundle never references them, and they're not included in the bundle either.

I have hit the same issue using single-spa + Snowpack. Keen to get this merged, anything I can do to help?

Sorry for dropping this, yall! This project has definitely grown past the point of me being able to singularly maintain it all myself :) Thanks for your patience as I work back through this backlog. Definitely looking forward to picking this one back up.

So one issue is that they are currently relative to get around issues with baseUrl. Since many users forget to set this and it all works fine via relative URL, it would be a breaking change to add this support to Snowpack.
I'd still love to get this merged, but maybe in a more powerful way. I'll add it to my list of things to re-introduce when we start thinking about v4.0 (hopefully in the next month or so, when Node.js v10 support is dropped) and would love your help if you're still interested then. Until then, Snowpack won't be able to support this use-case.

Do note: we should still support most users with our current feature set. When you run snowpack build, we respect whatever baseUrl that you have set in your config.
So if you set baseUrl, your import should become export default "$BASE_URL/dist/assets/image.svg". You can try npm install snowpack@next to confirm that this is working on the latest v3.1 pre-release.

Ah, that's unfortunate. I'd really like this functionality in the dev server, but since it's a breaking change, I get it. Keep me in the loop - I'd definitely be interested in working on this for a future 4.0 release :slightly_smiling_face:


Even more float cast tests, compile-fail test organization

Copy a bunch of float cast tests from https://github.com/WebAssembly/testsuite/blob/master/conversions.wast.

@bors r+

:pushpin: Commit 8f142ce54cc238637fcac392042013ea0b227d52 has been approved by RalfJung

@bors r+

:pushpin: Commit b2bf4ec2f5e6938dfcebe0690beabbef22652afb has been approved by RalfJung

:hourglass: Testing commit b2bf4ec2f5e6938dfcebe0690beabbef22652afb with merge 8c396609d077ae94f290aceebfbf2f39bdbec9d2...

:sunny: Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing 8c396609d077ae94f290aceebfbf2f39bdbec9d2 to master...


Pass DOM element to selection functions

Currently the context of a function passed to selection.attr (and its sibling operations) is set to the DOM element of the selection. Things get tricky when you want to both use the outer this and do something with the DOM element. Of course, a var self = this; before the function solves this.
var self = this;

d3.select('#some-element')
    // Completely contrived example of using both this and self:
    .attr('class', function() {
        return (self.highlightA && this.dataset.a) ? 'highlight' : 'normal';
    });

What would be more convenient is if the DOM element was available as a parameter to the function, i.e. (d, i, element). This would allow you to use ES6's arrow functions, which ignore the function's context.
d3.select('#some-element')
    // Completely contrived example of using both this and self:
    .attr('class', (d, i, elem) => (this.highlightA && elem.dataset.a) ? 'highlight' : 'normal');

To be clear, I'm not proposing that the context be changed to something else, only that it be possible to get the relevant DOM element without it.
Regarding backwards compatibility, adding an additional argument shouldn't break anyone's code, unless they're for some reason relying on arguments being a particular length (though if my assumption is mistaken and such a change would indeed be a breaking one, it should probably be left until version 4).

Related: ES6’s fat arrow syntax uses a lexical binding for this.  In other words, you cannot access the this context that D3 passes to callbacks if you’re using the fat arrow syntax.  The solution: don’t use the fat arrow syntax, or alternatively, we may need to consider something like the suggestion above for version 4.0.

@mminer Part of what makes this tricky is that functions are actually passed three arguments (not counting this); the third is the index in the current group. An expert feature, but sometimes an indispensable one. I'd hate to throw a DOM element between these indices.

That's understandable. I don't suppose that adding it as the fourth argument would be acceptable? I recognize at this point though that it gets into argument-overload territory.

If you add it as the fourth argument, then everyone has to know about j (and write it in the argument list) . I won't deny that this can be a headscratcher, but it's hardly the only JavaScript "feature" that D3 has turned to its advantage.

@mgold I'd suggest pushing the 3rd argument (index in current group) back to be the 4th parameter, inserting the DOM element in between. Ordinarily I wouldn't advocate such a breaking move, but as it's not mentioned in the API docs it's likely to be an infrequently used feature on the whole.
The sort of code that I'd like to be writing is similar (not using arrow functions) like:
d3,selectAll("circle")
    .on("click", this.click.bind(this));

this.click = function(d, i, domElement) {
   // Now I can call this.someFunc as this has been preserved
   this.someExtraFunc();
}

Would an alternative be to use (abuse?) another JavaScript feature and make the node available as d3.node within the function?

Allows use with ES6 arrow functions.

Follows an existing convention (d3.event).

Is a bit of an edge case (in the same way as d3.event) and so a slightly unusual syntax is more acceptable.

Is compatible with the new parent data changes.

Looks odd.

Our options are:

Pass the node as a new argument at the beginning of the list.
Pass the node as a new argument at the end of the list.
Temporarily set a global while the function is being evaluated.

Passing the selected node at the beginning is bad because there are many times where you don’t need the selected node. This is especially true when you want to pass in another function that operates on your data. For example, if your data is numbers, you might apply a scale to set an attribute like so:
d3.selectAll("circle")
    .data([0, 1, 2])
    .attr("cx", d3.scale.linear()
        .domain([0, 10])
        .range([0, width]));

If the first argument is now the selected node, you’d have to say:
var x = d3.scale.linear()
    .domain([0, 10])
    .range([0, width]);

d3.selectAll("circle")
    .data([0, 1, 2])
    .attr("cx", function(node, d) { return x(d); }); // Blech!

This pattern of passing a function to a selection method is also common with formatting numbers.
Passing the selected node at the end also doesn’t work very well because it requires you to know how many arguments are being passed to your function. In D3 3.x, that is typically three values: d, the datum; i, the index; and j, the group index. (See How Selections Work and Nested Selections.) But people might assume only d and i, since those are used most commonly. Also there a handful of methods that don’t pass the group index (#2413)…
In D3 4.0, the call pattern will likely change slightly. Selections in 4.0 are arbitrary hierarchies rather than limited to one level of grouping: the arguments for a flat selection a dre and i; the arguments for a singly-grouped selection are d, i, p and j, where p is the parent datum; for further grouping, there are correspondingly more arguments. Thus it’s awkward to access the selected node as the last argument because the position depends on the grouping. And technically, you can already access the selected node without this via the indexes, but it’s similarly awkward and you must use the semi-private _root field:
selection.each(function(d, i, p, j) {
  this === selection._root[i][j]; // true!
});

Setting the selected node as a global (d3.node) is also a bit icky, but it’s similar to how we set d3.event during an event handler. @wil93’s example would look like this:
d3.selectAll(".region").each(d => {
  d3.select(d3.node).style("fill", this.computeColor(…));
});

A variation on this idea is a new d3.activeSelection (or d3.selectActive?) method, in the same vein as d3.activeTransition as described in d3/d3-transition#15. It is similar to d3.select(d3.node), although I expect it should retain the same level of grouping as the context selection. For example:
d3.selectAll(".region").each(d => {
  d3.activeSelection().style("fill", this.computeColor(…));
});

(Though, note that d3.activeTransition as proposed in the other issue takes a node as argument; that would presumably go away if it could infer the active element automatically.)
If we go the global route, we might also take that approach for setting the current index, and then remove those pesky i and j arguments. That has some nice properties. Or maybe we can abandon the indexes entirely now?

I’ve standardized d3-selection and d3-transition on the current datum d, the group index i, and the group nodes array. This is intended to mimic array methods such as array.forEach. The this is the current element.


Analysis and refinement of epic for address lookup.

Description
Perform an analysis and refinement of epic #203.

Moving issue back to Pri 2 until we're ready to continue with the resource filter workflows.


Hydrate views, reactions and comments using JS

These are currently 'baked' in at build time. Feel like I could use svelte actions for this?

Done for views, unsure whether its worth doing for reactions and comments


Use non-default python when creating virtualenv

[x] I have searched the issues of this repo and believe that this is not a duplicate.
[x] I have searched the documentation and believe that my question is not covered.

Feature Request
I want to use non-default python for virtualenv, my current workaround:
mkvirtualenv -p python3.7 app
poetry install

It would be cool for poetry to do two things:

check if python specified in pyproject.toml is available and use it
provide -p path/to/python switch

Now it just fails with a confusing message.

check if python specified in pyproject.toml is available and use it

Poetry will likely never become a Python version manager, see https://github.com/sdispater/poetry/issues/439#issuecomment-42357492.

provide -p path/to/python switch

I believe that functionality is available in the 1.0 alpha releases: https://github.com/sdispater/poetry/pull/731

I don't suggest managing python versions, I only suggest using appropriate python if it's already available in PATH. As far as I see poetry env use creates virtualenv, so am I supposed to execute:
poetry env use python3.7
poetry install

to use system Python3.7?

My logic behind this feature request is - one should be able to supply python when creating virtualenv, which poetry install does, thus -p switch. But if python version is defined in pyproject.toml and we have needed python available in PATH we should not require manual -p use.

What works for me:
pythonx.y `which poetry` shell
poetry install

Would that work for you?

But if python version is defined in pyproject.toml and we have needed python available in PATH we should not require manual -p use.

I'd like to second this request. I suspect I'm not alone in encountering Poetry, reading the docs, and being surprised when:
[tool.poetry.dependencies]
python = "~3.6.*"

Didn't lead to a Poetry created venv based on that declaration, but:
[RuntimeError]
The current Python version (2.7.10) is not supported by the project (~3.6)
Please activate a compatible Python version.

When the docs state:
When you execute the install command (or any other "install" commands like add or remove), Poetry will check if it's currently inside a virtualenv and, if not, will use an existing one or create a brand new one for you to always work isolated from your global Python installation.

I assumed that:
To create the virtualenv for the current project, Poetry will use the currently activated Python version.

Simply meant that, in the absence of a pyproject.toml, this would be the behavior, but that if it was declared, that would be used to create the venv..
I'd really love that to be the case, but if it isn't, second-best would be to more explicitly address that in the docs.
Though given the frequent plugs for pyenv, perhaps integrating that as a dependency and handling  pyenv transparently in the event of a .toml python declaration wouldn't be a bad idea.

Poetry will likely never become a Python version manager.

And nor should it!  I completely agree with that thinking.
However, since a virtualenv is already being created, checking the path for a [tool.poetry.dependencies] declared python version or alternatively, and likely ideal given potential issues with the dependency declaration, an entry in [build-system] for the preferred virtual environment python version. If that check fails, issue a warning and fall back to the established behavior.
[build-system]
requires = ["poetry==0.12.11"]
preferred_python = ["~3.6"]
build-backend = "poetry.masonry.api"

Given how many projects and teams are now implementing Poetry and beginning to depend on it to provide a common environment, and the fact that Poetry already creates a virtual env, this seems like a reasonable feature to expect.
Not at all a step towards package management nor python management. Simply an attempt to used a declared python version, if it exists, when creating the virtual environment that Poetry already creates.

I probably should clarify my use case: I use system pythons and virtualenvwrapper and try to swap the latter to poetry. I never used pyenv nor I want to.

Additionally, having the Python version explicitly in the command ensures that it is used for that one execution only. If all you want to do is run a one-shot command it is cumbersome to do:
> source env/bin/activate
> python run-my-comand
> deactivate

instead of
> ./env/bin/python run-my-comand

This is especially true for automated CI pipelines where one job is not necessarily running in the same context as another. Having the ability to add the env-path as a command-line argument makes this explicit in the job definition and it also helps the reader of the CI definition file.

@Suor:

It would be cool for poetry to do two things:

check if python specified in pyproject.toml is available and use it
provide -p path/to/python switch

@sdispater solved your second point, by introducing a new poetry env command in the merged PR https://github.com/sdispater/poetry/pull/731, which allows users explicitly creating virtual environments with a specified Python interpreter before running the previous commands. This great feature will be released in Poetry 1.0.0.
However he did not solve your first point, the implicit way is still broken. Poetry should implicitly create a built-in virtual environment with the Python version specified by the tool.poetry.dependencies.python property of the pyproject.toml file, not the Python version resolved by the #!/usr/bin/env python shebang line of the ~/.poetry/bin/poetry script.

This is still relevant.

This has been fixed in the latest beta releases of the 1.0.0 version.

As mentioned in https://github.com/sdispater/poetry/issues/988#issuecomment-532618972, I think half of this is fixed by #731. The other half is the subject of #1386, so maybe this issue should be closed and discussion continue there?

@matthijskooijman #1386 has been addressed in https://github.com/sdispater/poetry/pull/1477


[Added] PULL_REQUEST_TEMPLATE.md

Closes https://github.com/openebs/litmus/issues/17
Signed-off-by: Utarsh Gupta<EMAIL_ADDRESS>

CC: @NisantaSahoo @kmova.


Unexpected server shut-down when accessing Django-admin

When running the server locally, I tried to access individual chants in Django-admin (e.g., http://<IP_ADDRESS>:3122/admin/main_app/chant/705019/change/). The page wouldn't load, and the server, which was supposed to keep running locally, would stop on its own.

This is not urgent because the user should always use the "real" chant-edit page (e.g., http://<IP_ADDRESS>:3122/edit-volpiano/702611?pk=705019) to make changes.
Nonetheless, we should still figure out why this is happening.

some notes on this: apparently, a similar issue occurred around when Django 3 was released: Trying to access certain pages in the admin panel would cause the server to crash. Rolling back to 2 was one approach that solved the problem for many people. For others, upgrading their python version did the trick.
Locally, I've tried upgrading Django from 4.0.3 to 4.0.7 . I've also tried upgrading python from 3.8 to 3.10. Neither resolves the issue.

this hasn't re-emerged as a problem. closing.


Review and update exceptions system

Overview
For now exception system is legacy partially. Especially the InvalidCastError branch (we use convert term now). So It should be reviewed and updated before v1 because all exception are part of the API.

MERGED #80


FIX: results will be nil for invalid queries

Previous to this change invalid searches would break the command.

GPT likes to invent search terms like: order:first_posted and so on, these are stripped out of the search term leading to a blank one.
Our core api just return nil for any blank search...


Use React 15 for the website (client-side)

It doesn't use v15 for the server-side generation. That requires changes to react-page-middleware and I just wanted to get this up quickly.
Fixes #323

@facebook-github-bot shipit


Group operation resolved to the wrong patch path

Describe the bug
In a project, i ran a dbt-meshify group operation that added a bunch of models to a group. For some staging models, meshify wrote new entries to the default filepath, even though there were existing entries for those models in an existing file.
Steps to reproduce

document models in your project
run the group command
see group command adds yml to the wrong place in the project.

Expected results
Single yml entries for models

\
System information
Which database are you using dbt with?

[ ] postgres
[ ] redshift
[ ] bigquery
[x] snowflake
[ ] other (specify: ____________)

false alarm -- this looks like it may have been some parse issue in core -- after upgrading my dbt version and reparsing, the manifest had the correct patch_path, and meshify behaved as expected


Generating a nonce for a proof request

Right now, It not really possible to generate a nonce, via proofService.generateNonceForProofRequest() without a lot of hassle because you need to instantiate the proofService.
We should add a way to generate this nonce without instantiating this whole class, or we should create it for the user if nothing is provided in the options of the constructor for the proofRequest class.

Too much as changed, not really relevant anymore


Using

I'm wondering about the utility of the static methods contributed to Observable via add/observable. I can't seem to get them to work as expected.
main.js
require('rxjs/add/observable/fromArray)';
var observable = require('rxjs/observable');

observable.Observable.fromArray([0,1,2,3]).subscribe(console.log);

Running this file via node gives
TypeError: observable.Observable.fromArray is not a function
    at Object.<anonymous> (/Users/ovangle/WebstormProjects/center_stage/sandbox/main.js:4:28)
    at Module._compile (module.js:398:26)
    at Object.Module._extensions..js (module.js:405:10)
    at Module.load (module.js:344:32)
    at Function.Module._load (module.js:301:12)
    at Function.Module.runMain (module.js:430:10)
    at startup (node.js:141:18)
    at node.js:980:3

Am I missing something? The exports from add/operators work as expected, but none of contributed functions from add/observable seem to work.

I fixed the problem, there was a typo in one of the requires, it should have been
var observable = require('rxjs/Observable');


AP-2853: Remove legacy ingress values

What
Link to story
Updated the uat_deploy script to remove the LEGACY_RELEASE_HOST value and leave the ingress.hosts value as an array to avoid refactoring the ingress.yaml file and leave us able to add further hosts in the future if needed
Checklist
Before you ask people to review this PR:

Tests and rubocop should be passing: bundle exec rake
Github should not be reporting conflicts; you should have recently run git rebase main.
There should be no unnecessary whitespace changes. These make diffs harder to read and conflicts more likely.
The PR description should say what you changed and why, with a link to the JIRA story.
You should have looked at the diff against main and ensured that nothing unexpected is included in your changes.
You should have checked that the commit messages say why the change was made.

👍 is the same logic applicable across the repos for UAT?

Yes, but the other repos will also require the values files for staging and prod changed too as they don't have service urls


fix(nuxt): Nuxt 3 does not respect layouts in separate folders (#14275)

fix(nuxt): Nuxt 3 does not respect layouts in separate folders (#14275)
🔗 Linked issue
Issue: #14275
❓ Type of change

[ ] 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
[x] 🐞 Bug fix (a non-breaking change that fixes an issue)
[ ] 👌 Enhancement (improving an existing functionality like performance)
[ ] ✨ New feature (a non-breaking change that adds functionality)
[ ] 🧹 Chore (updates to the build process or auxiliary tools and libraries)
[ ] ⚠ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description
Fix the issue of not being able to create layouts in different directories, as specified in Issue #14275.
Now, we can define layouts in the following format:
For example:

File
Layout name

~/layouts/desktop/default.vue
'desktop-default'

~/layouts/desktop-base/base.vue
'desktop-base'

~/layouts/desktop/index.vue
'desktop'

<template>
    <NuxtLayout name="desktop-base">
      <NuxtPage />
    </NuxtLayout>
</template>

📝 Checklist

[x] I have linked an issue or discussion.
[ ] I have updated the documentation accordingly.

@pi0 / @danielroe / @Atinux
anybody to validate this usefull PR ?

I have already reviewed and requested a change.

Looks good to me, would be nice to update the documentation about it (can be done later)


Race condition with Istio sidecar prevents KIC to startup correctly

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
This is similar to what is observed in #4207 .
Due to the new controller startup logic described here and in this PR, if the network is not available when the ingress-controller container starts and it can't connect to the k8s control plane then all the controllers are disabled.
When the ingress-controller container starts and attempts to get k8s resources before the envoy sidecar is ready, it fails and the no routes are added to the Kong proxy instances.
Expected Behavior
The controller should retry or fail (restart) when the control plane is unavailable at boot.
Steps To Reproduce
- Deploy Kong with Istio sidecar. For example deploy using the Helm chart annotating the namespace with istio injection.
- Wait for the race condition to happen

Kong Ingress Controller version
Tested positive on 2.10.x.
Unable to reproduce with 2.7.x.
Should happen on 2.8.x and up.

Kubernetes version
Tested on 1.23 and 1.26.

Anything else?
Sample logs. Check timestamps.
Istio sidecard (extract):
2023-09-04T17:49:40.380745Z    info    Envoy proxy is ready

Ingress controller container logs (extract):
{"level":"info","logger":"controllers.crdCondition","msg":"Disabling controller for Group=configuration.konghq.com/v1beta1, Resource=udpingresses due to missing CRD","time":"2023-09-04T17:49:37Z"}
{"level":"info","logger":"controllers.crdCondition","msg":"Disabling controller for Group=configuration.konghq.com/v1beta1, Resource=tcpingresses due to missing CRD","time":"2023-09-04T17:49:37Z"}
{"level":"info","logger":"controllers.crdCondition","msg":"Disabling controller for Group=configuration.konghq.com/v1, Resource=kongingresses due to missing CRD","time":"2023-09-04T17:49:37Z"}

This issue seems to be tracked here in Istio. One of the proposed solutions here is the use of postStart lifecycle hooks.
Maybe the KIC can implement either:

a retry logic when the control plane is unavailable
a fail logic (distinguish CRD not present from API call failed)

Or if that is not possible maybe the helm chart can add support for lifecycle hooks for the ingress-controller container like it does for the proxy container.

https://github.com/Kong/kubernetes-ingress-controller/issues/4618 might be a better solution than trying to implement it in the chart.

Having the retry logic in the controller would be ideal. It would help in this Istio case and any other case of network outage/delay at pod start.
The container lifecycle hook is just a workaround and it has proven to be ineffective in some cases.
Thank you for looking into this.


Readme runall example

While I was working with terraforming for the first time I was also using git to track changes to my .tf and tfstate files. I noticed that after I ran the export all example that it had also deleted large portions of my local git repository.
This update accomplishes two goals:

Updates the find command in the example to only find files that match the '*.tf*' glob
Adds an example for generating tfstate files along with the intial tf files.

I didn't bump the version in version.rb though since it's just a doc change, I'll leave that up to your discretion if you agree with this change.

Coverage remained the same at 97.352% when pulling a96e5a3211125ba66c0dd505d4896d3c4f109114 on joshlove:readme_runall_example into 72c96ee039b9382267ee388760895fbabd4fab87 on dtan4:master.


Dice game using Javascript

I would like to add this project in web development folder for hacktoberfest. Can you please assign this to me.

Hi , Kindly please assign this issue to me .


Add httpmock from cli/cli

The mock Registry and friends from https://github.com/cli/cli/tree/trunk/pkg/httpmock would be very useful for testing extensions.

I like this idea and I think we should do it. I already have migrated it to go-gh so it really just needs to be moved from the internal folder to export it.
Before making it widely available there are a couple changes I would like to see to the interface while we still can:

Should the name change to something like TransportMock or RoundTripperMock?
Stubs should have names when they are registered with Register. This will allow for better error messaging directly referencing the stub name.
We should remove the more obscure responders that are not used in go-gh, for example FileResponse and ScopesResponder. Perhaps there are others there that we can remove.

These will require changes to the go-gh test suit so I think approaching it as making the interfaces changes first and then exporting the package in a second PR is the right way to go here.

I like TransportMock a bit better. Seems more obvious and discoverable.
👍
While we're at it, would be nice to define a pattern for taking a string vs. object or map to marshal. I had started some changes like this for one of my recent PRs since I already had an object in test I could marshal, and construction of it is more straight forward in some cases. Certainly just a preformatted JSON response string in other cases is great. For HTTP this already exists, but something similar for GraphQL would be nice. Maybe some pattern like {protocol}{"Request"|"Response"}({"String"|"JSON"}) e.g., "HTTPRequest", "HTTPResponseString", "GraphQLRequest", or "GraphQLResponseJSON".

Great, TransportMock it is.
I also had thoughts on defining a naming scheme for responders as well. I think our responders can be smarter than they currently are. In my opinion each should be able to handle both a string and a struct, if it is not a string we will try to marshal it to a JSON string. In this scenario we don't need to figure out a naming scheme for what takes in a string or a struct. I wrote up some code below on how I am envisioning the responders. Let me know what you think.
func HTTPResponse(status int, header map[string][]string, body interface{}, cb func(*http.Request)) Responder {
	return func(req *http.Request) (*http.Response, error) {
		var b io.Reader
		if s, ok := body.(string); ok {
			b = bytes.NewBufferString(s)
		} else {
			s, _ := json.Marshal(body)
			b = bytes.NewBuffer(s)
		}

		if cb != nil {
			cb(req)
		}

		return httpResponse(status, header, b, req), nil
	}
}

func RESTResponse(body interface{}, cb func(map[string]interface{})) Responder {
	return func(req *http.Request) (*http.Response, error) {
		var b io.Reader
		if s, ok := body.(string); ok {
			b = bytes.NewBufferString(s)
		} else {
			s, _ := json.Marshal(body)
			b = bytes.NewBuffer(s)
		}

		bodyData := make(map[string]interface{})

		err := decodeJSONBody(req, &bodyData)
		if err != nil {
			return nil, err
		}

		if cb != nil {
			cb(bodyData)
		}

		return httpResponse(200, map[string][]string{}, b, req), nil
	}
}

func GQLMutation(body interface{}, cb func(map[string]interface{})) Responder {
	return func(req *http.Request) (*http.Response, error) {
		var b io.Reader
		if s, ok := body.(string); ok {
			b = bytes.NewBufferString(s)
		} else {
			s, _ := json.Marshal(body)
			b = bytes.NewBuffer(s)
		}

		var bodyData struct {
			Variables struct {
				Input map[string]interface{}
			}
		}

		err := decodeJSONBody(req, &bodyData)
		if err != nil {
			return nil, err
		}

		if cb != nil {
			cb(bodyData.Variables.Input)
		}

		return httpResponse(200, map[string][]string{}, b, req), nil
	}
}

func GQLQuery(body interface{}, cb func(string, map[string]interface{})) Responder {
	return func(req *http.Request) (*http.Response, error) {
		var b io.Reader
		if s, ok := body.(string); ok {
			b = bytes.NewBufferString(s)
		} else {
			s, _ := json.Marshal(body)
			b = bytes.NewBuffer(s)
		}

		var bodyData struct {
			Query     string
			Variables map[string]interface{}
		}

		err := decodeJSONBody(req, &bodyData)
		if err != nil {
			return nil, err
		}

		if cb != nil {
			cb(bodyData.Query, bodyData.Variables)
		}

		return httpResponse(200, map[string][]string{}, b, req), nil
	}
}

func httpResponse(status int, header map[string][]string, body io.Reader, req *http.Request) *http.Response {
	if _, ok := header["Content-Type"]; !ok {
		header["Content-Type"] = []string{"application/json; charset=utf-8"}
	}

	return &http.Response{
		StatusCode: status,
		Header:     header,
		Body:       io.NopCloser(body),
		Request:    req,
	}
}

Overall, I like it, but have a couple thoughts:

It's not always true that a REST response returns 200. Sure, someone could use the HTTP response (which are mostly RESTful anyway), but maybe don't imply a format protocol through HTTP or REST. Maybe HTTPResponse or HTTPResponseWithStatus?
For RESTResponse, couldn't you avoid the performance hit and memory (granted, they're tests, so maybe 🤷♂) by only decoding a string body and just using the given body as the bodyData otherwise?

True. I am open to naming changes this was just quickly what I put together. I chose the current names as they matched the various clients that go-gh offers.
That would be a good improvement.

@heaths As part of the process of exporting httpmock we did an investigation on other http mocking packages out there and the team concluded that moving forward with using the gock package was the right approach for us instead of continuing using our home made httpmock package. With that decision, we are also advocating using gock or another third-party package for http mocking when testing gh extensions so I am going to close this issue out.

@samcoe having had a change to use gock in https://github.com/heaths/gh-projects, there are some positive aspects (simple to set up and no hooks needed if using net/http), but some areas that could be improved - maybe even here or in a separate package. Or just contributed back to gock - something I'm considering but would love to brainstorm ideas.
The main issue that is lacking is trying to match a request. With your httpmock you can match a GraphQL request with just a substring - like a query name, which I do for this very purpose - but then a callback (or any way to assert) for variables. In gock all I've found is Mock.Body or Mock.BodyString which requires getting the query exactly right - newlines and all - and the variables sorted, though I guess the latter is document and cannot reasonably be changed.

@heaths You're right that matching on the entire query string would likely lead to brittle tests. Would it be possible to define a custom Request matcher with gock that extracts the GraphQL query name and matches on that?

@heaths I am not sure that we necessarily need to include this functionality in go-gh. I
went ahead and wrote a function that does what you want and it turned out to be only ~30 lines which seems like something an extension author could implement themselves. The only tricky part which isn't exactly clear is using the TeeReader for reading the body so that any subsequent matchers can also read the body if they need to.
func matchGQLRequest(query string, vars map[string]string) func(*http.Request, *gock.Request) (bool, error) {
	return func(req *http.Request, ereq *gock.Request) (bool, error) {
		var bodyData struct {
			Query     string
			Variables map[string]string
		}
		bodyCopy := &bytes.Buffer{}
		r := io.TeeReader(req.Body, bodyCopy)
		req.Body = io.NopCloser(bodyCopy)
		b, err := io.ReadAll(r)
		if err != nil {
			return false, err
		}
		err = json.Unmarshal(b, &bodyData)
		if err != nil {
			return false, err
		}
		if query != "" && query != bodyData.Query {
			return false, nil
		}
		if len(vars) != 0 {
			for k, v := range vars {
				bv := bodyData.Variables[k]
				if v != bv {
					return false, nil
				}
			}
		}
		return true, nil
	}
}

It can be used like this:
func TestGQLClient(t *testing.T) {
	stubConfig(t, testConfig())
	t.Cleanup(gock.Off)

	gock.New("https://api.github.com").
		Post("/graphql").
		MatchHeader("Authorization", "token abc123").
		AddMatcher(matchGQLRequest("QUERY", map[string]string{"var": "test"})).
		Reply(200).
		JSON(`{"data":{"viewer":{"login":"hubot"}}}`)

	client, err := GQLClient(nil)
	assert.NoError(t, err)

	vars := map[string]interface{}{"var": "test"}
	res := struct{ Viewer struct{ Login string } }{}
	err = client.Do("QUERY", vars, &res)
	assert.NoError(t, err)
	assert.True(t, gock.IsDone(), printPendingMocks(gock.Pending()))
	assert.Equal(t, "hubot", res.Viewer.Login)
}


sigma-cli: 1.0.1 -> 1.0.2

Diff: https://github.com/SigmaHQ/sigma-cli/compare/refs/tags/v1.0.1...v1.0.2
Changelog: https://github.com/SigmaHQ/sigma-cli/releases/tag/v1.0.2
Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 312399 run on x86_64-linux 1

2 packages built:

sigma-cli
sigma-cli.dist


Avoid exceeding maximum allowed buffer size

I'm already protecting against loading models that won't fit in memory (https://github.com/ml-explore/mlx-swift-examples/issues/70) and checking if the prompt exceeds the model's context window, but long prompts that fit in the context window can still exceed the maximum allowed buffer size:
libc++abi: terminating due to uncaught exception of type std::runtime_error: Attempting to allocate<PHONE_NUMBER> bytes which is greater than the maximum allowed buffer size of<PHONE_NUMBER> bytes.

  if (size > device_->maxBufferLength()) {
    std::ostringstream msg;
    msg << "Attempting to allocate " << size << " bytes which is greater than"
        << " the maximum allowed buffer size of " << device_->maxBufferLength()
        << " bytes.";
    throw std::runtime_error(msg.str());
  }

Is there a way to estimate the buffer length required by a given prompt to guard against this fatal error?

I am not sure about estimating other than measuring yourself with some token lengths and see how much it uses.
#93 has some things that, once built, should help with memory use -- potentially capping the amount of memory used.

What exactly do I need to measure? Is it GPU.activeMemory? This seems to fluctuate quite a bit during generation, and the peak values can even be significantly above the recommendedMaxWorkingSetSize of the Metal device without the app crashing, so I'm not sure how to approach this.

In your case the largest buffer is from the scores for self-attention. That will be during the SDPA computation which will use seq_len^2 *  n_heads * 2 bytes (assuming quantized/fp16/ bf16). For example if n_heads = 32 and the sequence length is 5000 then SDPA will need about 1.5 GB. So you can estimate that.
You can get the maximum allowed buffer size from the deviceInfo struct.
However just because you can allocate the buffer doesn't mean it's a good idea to run with such a large sequence length. It will probably still use up a lot of memory and run very slowly.
I think a better medium term course of action is to pull in the prompt splitting from #93 which will substantially reduce the memory needed for the SDPA.

Thanks, @awni, that's very helpful. Is only num_attention_heads from the model's config.json relevant here, or does num_key_value_heads also need to be taken into account?

num_attention_heads is the relevant one because it's what dictates the maximum size of the scores. The largest array you make for long prompts (in the current setup, this will probably change in the future) are the scores which have shape [batch, num_heads, sequence, sequence] (batch is 1 here).


Hgw parameter docs

This updates docs and examples for parameter observing and iteration ( #442). It also documents wait_ready behaviour in the vehicle class and connect method.
The changes are recorded in the migration guide which is now linked from the home/index page. I also added some missing doc here for the changes to missions.
I think it is all sane.Getting weary though!
@tcr3dr please review and merge!

@hamishwillee Looks good. Make one small modification, but we are set.

@tcr3dr Thanks very much . Might be worth rebuilding the docs on our site?


Readme could include more information

Readme should tell what is this repository for.

I agree.

#8


JS course button "Reset All Code" should probably be called "Reset This Lesson" instead

Describe the Issue
In the JS course (such as the Basic Javascript course), the button to "Reset All Code" leads to a dialog titled "Reset This Lesson" which contains a button titled "Reset this lesson".
I believe that "Reset this lesson" is a clearer and truer description of what clicking on "Reset All Code" is meant to do so I opened this issue to discuss that. I've also heard feedback before on the forum where someone was afraid to press on "Reset All Code" button because they thought it would delete all their progress.
For this reason and for the reason for having a consistent and predictable user-interface, I suggest the button "Reset All Code" be renamed to match the dialog "Reset This Lesson"
Affected Page
all js course pages
Steps to Reproduce
click on the button in any of the JS course steps to see the dialog
Expected behavior
please see the description of the issue
Screenshots

System
laptop devices and other large screens
Additional context
No response

Agreed. I have heard that feedback as well.

Sounds good to me.
That is located here. There's a few spots in the lower jaw we should probably change as well.
We can just change them to use the existing reset-lesson key

I agree, the current accessible name on the restart icon button in the steps is "Reset All Code", so that needs to change as well. But since we refer to theses lessons as "Steps" then I think it makes more sense to use "Reset this step" instead of "Reset this lesson".

hmm, I suppose I agree there - although, the modal still says "lesson" on those steps. Perhaps we should just fix the older challenge types (like in the screen shot) for this issue, and make another one to change the lower jaw button and the reset modal to use "step" for the new style challenges.

although, the modal still says "lesson" on those steps

Good catch, I didn't notice that (that will teach me for not actually clicking the button). Funny how these things are always more involved than they first appear to be.
I have no opinion on whether to split these into two issues. If I were going to fix this I would just do it in one PR. But if you were thinking these would be first timer issues than perhaps it would make more sense to split them.

It really doesn't matter. To clarify then, we want to...

Change the older style challenges to say "Reset this lesson" using the reset-lesson key.

Change the newer style challenges to say "Reset this step". We will need to add at least two new keys in the translations, one that says "Reset this step", and one or more for the reset modal that use "step" instead of "lesson". The current modal uses the keys here

Then change the button in the lower jaw
And we will need to conditionally change the reset modal text based on the type of challenge or something and use "step" if it's the newer style

That sound about right @bbsmooth?

I think you've covered everything!

Assign it to me

We don't typically assign issues @mashinsp. The first PR to fix the issue will be accepted. Feel free to make a PR that fixes one or both of those things mentioned. Let us know if you need any assistance.


Email notifications

Every day I have to keep unchecking email notifications.

Thanks for filing the bug. I found the culprit! There was a 'checked' inside the HTML element, so every time I deployed a change to the platform that would appear.

oh thanks! I'm still getting them though :/


Allow room margins to specify less than 1.

The room margins are required to be 2 or more, but this should be supported so that dungeons can be created with margins of 1 or less.
部屋の余白は2以上であることを要求しているが、これを1以下でもダンジョンを生成できるように対応する。

The smallest room margin can be set to 1. I verified no margin, but decided against supporting it because there are situations where it is not possible to create a passage when a room is enclosed.


NSLayoutConstraint warnings in 0.2.2

Just updated to version 0.2.2 to fix issue #195. Using Xcode 9.2 and using a Deployment Target of iOS 9.3, I'm getting a lot (91) of build warnings of the form:
<mypath/to/product>/Pods/CLImageEditor/CLImageEditor/ViewController/_CLImageEditorViewController.m:190:12: warning: 'NSLayoutConstraint' is partial: introduced in iOS 6.0 [-Wunguarded-availability]
+(NSArray <NSLayoutConstraint *>*)setConstraintsLeading:(NSNumber *)leading
           ^
In module 'UIKit' imported from <mypath/to/product>/Pods/Target Support Files/CLImageEditor/CLImageEditor-prefix.pch:2:
/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk/System/Library/Frameworks/UIKit.framework/Headers/NSLayoutConstraint.h:96:12: note: 'NSLayoutConstraint' has been explicitly marked partial here
@interface NSLayoutConstraint : NSObject
           ^

These are warnings and the library still builds and works but it would be great to eliminate the warnings. BTW, thanks for building such a great library!

I couldn't find warnings using same settings. Did Clean project  not work?

Clean project did not change the production of warnings.

It was easy to reproduce the warnings:

Create a new iOS Single View App Obj-C project in Xcode 9.2
Set the Deployment Target to 9.3 in Targets>General
Close project
pod install 'CLImageEditor'
Open the new .xcworkspace
Attempt to comple/run

CLDrawToolSample.zip

@mjswan What version of cocoapods do you use? In 1.2.1, such warnings do not appear.

'pod --version' produces '1.3.1'.
I'm closing this issue since seemingly spontaneously Xcode asked me to update the CLImageEditor pod project to the latest settings. Once I updated the project, all the warnings went away. I don't know what happened to trigger the update request. @yackle : thank you for your interest.

NP 👍


fix(secrets): Always add secretFor to remotesecret labels

Fixes
https://issues.redhat.com/browse/RHTAPBUGS-916

Description
Always add the ui.appstudio.redhat.com/secret-for label to remotesecret labels.

Type of change

[ ] Feature
[x] Bugfix
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

Screen shots / Gifs for design review
https://github.com/openshift/hac-dev/assets/20013884/5387d1d4-2841-4a35-b6da-39a42f7d23b1

How to test or reproduce?
Add a deployment secret using secrets form.

Browser conformance:

[ ] Chrome
[x] Firefox
[ ] Safari
[ ] Edge

/cc @karthikjeeyar

/approve
/lgtm

/retest


Need Help With PRETRAIN_TYPE=Autoencoder

Hello!
You wrote:
"You need to train an auto encoder-decoder model by RNNSharp at first, and then use this pretrained model for your task"
But I do not see how to do it.
Finaly what do you mean by "pretrained model is trained by RNNSharp itself"?

Hi @bill3code ,
The previous description may nit clearly, so I updated it to:
#For 'Autoencoder', the pretrained model is trained by RNNSharp itself.  For sequence-to-sequence task, "Autoencoder" is required, since source sequence needs to be encoded by this model at first, and then target sequence would be generated by decoder.
So, it means that you need to run RNNSharp to build autoencoder model at first, and then use it as one of input to build decoder model for your sequence-to-sequence task.

Thank you!


Add get accessor for default schedule store

const resonate = new Resonate();

resonate.schedules.create(...);
resonate.schedules.get(...);
resonate.schedules.delete(...);

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a4bc908) 59.20% compared to head (33ddaee) 59.05%.

Files
Patch %
Lines

lib/resonate.ts
0.00%
2 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   59.20%   59.05%   -0.16%
==========================================
  Files          16       16
  Lines         782      784       +2
  Branches      190      190
==========================================
  Hits          463      463
- Misses        292      294       +2
  Partials       27       27

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


angular-language-server: init at 18.2.0

EDIT:
Packaging the angular language server from source turns out to be tricky because it uses a combination of nodejs and bazel (and bazel is known to not play well together with nixpkgs https://github.com/NixOS/nixpkgs/issues/224446). The main problem is that bazel downloads a separate nodejs binary and then uses the pnpm lock file to transform all dependencies. Unfortunately, we cannot use that separate nodejs binary because it escapes the sandbox and probably will not even execute on nixos (e.g. nix-ld problem).
I tried the following three approaches before I gave up and packged is as binary in https://github.com/NixOS/nixpkgs/pull/350257:

https://github.com/NixOS/nixpkgs/pull/349521/commits/904f6667eb32381113bc007952659dc60f2dacce) was the start but I only realized afterwards that this only works without the sandbox on darwin.  On linux and darwin with the sandbox this fails because Bazel downloads its own nodejs binary which is not allowed in the buildPhase (no network access allowed).
As a next step I tried to combine the yarn hooks with the buildBazelPackage function in https://github.com/NixOS/nixpkgs/pull/349521/commits/2e418c7d752e7e0938cc507599622e5b114c626f but that still failed because the downloaded nodejs binary still escapes the sandbox somehow. I then tried to manipulate the bazel files to inject the nix nodejs but then I got a bazel cycle dependency problem and since I am no bazel expert I stopped there.
Finally, in https://github.com/NixOS/nixpkgs/pull/349521/commits/b1a395d84f0e1e6f99e3d2521ec9cdadbd8472ec I tried to replicate the esbuild bazel rules manually with the esbuild cli command but it still failed with some errors. I then gave up because this approach basically builds its own build script which will diverge in the future from upstream and does not seem maintainable to me. Besides you still need to be a bazel expert to continue transforming the upstream bazel build files to esbuild commands.

Continues on https://github.com/NixOS/nixpkgs/pull/343326.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Hm, I see that the build fails using the sandbox because during the buildPhase we switch from yarn to bazel. Since we don't have any internet access in the build phase this package becomes a lot more difficult to package. I don't have any experience with bazel, so any inputs are highly appreciated.
Maybe a double mkDerivation, e.g first derivation for the yarn deps to execute tsc -b and then a second mkDerivation for Bazel?
Pinging @lelgenio and @dotlambda for help.

I don't know much about bazel too, but I think you should be able to use buildBazelPackage in conjunction with the yarnHooks:
buildBazelPackage rec {
  pname = "angular-language-server";
  version = "18.2.0";

  src = fetchFromGitHub {
    owner = "angular";
    repo = "vscode-ng-language-service";
    rev = "refs/tags/v${version}";
    hash = "sha256-9+WWKvy/Vu4k0BzJwPEme+9+eDPI1QP0+Ds1CbErCN8=";
  };

  # yarn
  offlineCache = fetchYarnDeps {
    yarnLock = src + "/yarn.lock";
    hash = "sha256-N0N0XbNQRN7SHkilzo/xNlmn9U/T/WL5x8ttTqUmXl0=";
  };

  # bazel
  fetchAttrs.hash = "sha256-AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA=";

  nativeBuildInputs = [
    yarnConfigHook
    typescript
  ];

  bazel = bazel_5;

  buildAttrs.preBuild = ''
    tsc ....
  '';
  };
}

I haven't seen be used, and I'm not sure it would be acceptable, but a cursed alternative is to do the same thing as node2nix/nodePackages: Fetch the "pre-compiled" package from npmjs.com or yarnpkg.com

If that works that would be awesome. We don't want to use node2nix, though.

@SuperSandro2000 @lelgenio @NotAShelf I gave up on packaging this from source and tried to document the encountered challenges  here https://github.com/NixOS/nixpkgs/pull/349521#issue-2597323661 for others who might start the same journey in the future.
In the meantime, I opened another pull request which packages it as a binary so that it is still availabe in nixpkgs over here: https://github.com/NixOS/nixpkgs/pull/350257.
What do you think?

Fine for me, that's often the fate for bazel projects. Trash build system.


Format URLs as Slack links

If you want to send URLs in Slack, you need to format them as such so they are clickable. Without that, they are just plain text.
LinkFormatter already does markdown and html links, so that is a logical place to put it. I've been trying to figure out how to do this, but the hard part is that you need to regex to match the URL but not match an html or markdown link that's been converted already.
I've found that you can use   uri_regexp = URI.regexp(['http', 'https']) to get a uri regexp. I'm not sure if this includes fragments though, ie # on the end.

It took reading the Regexp documentation around anchors and lookahead/behinds, but I found a way to do it. Basically, process markdown and html links first, then use negative lookahead and lookbehind to make sure it's not matching brackets for links that have been added already.
    .gsub(/(?<!<)(#{uri_regexp})(?!>)/) do |match|
      "<#{$1}>"
    end

Reading the docs (https://api.slack.com/docs/formatting#parsing_modes) and testing slack will already auto-detect bare urls. Are you running into cases where that isn't happening?
Modified integration test for example:
notifier = Slack::Notifier.new ENV['SLACK_WEBHOOK_URL'], username: 'notifier'
notifier.ping "hello/こんにちは from notifier test script on ruby: #{RUBY_VERSION}\225"
notifier.ping "[so](http://example.com) many http://links.com"

@stevenosloan I'm actually using Slack::Notifier::LinkFormatter on its own to format text for a Slack export (ie something that is compatible when you export a team, in order to import it). It's outside of the normal use case, so I'm okay with closing if it works as expected for notifying slack.

oh ic, that makes sense. I think it'd be worth adding, but only run if you pass a flag to the ::format -- lets say autolink just to match redcarpet. So using it could look something like:
text = "I <3 http://placekitten.com/ > http://placehold.it"
Slack::Notifier::LinkFormatter.format text, autolink: true
# => "I <3 <http://placekitten.com/> > <http://placehold.it>"

Sorry @technicalpickles, I was hopping to get this out tonight. I realized that adding the link formatter options should really be a 2.0 feature, and include things like setting escaping (https://github.com/stevenosloan/slack-notifier/pull/35).
That said, depending on how the day job goes, hopefully won't be too far off for that. But let me know if you need any help w/ getting a LinkFormatter post-process for this in place. Any knowledge gained there will help for adding it to the gem.
cheers,
steven


Lint all CSS and JS code

This adds initial test automation in the form of CSS and JS linting, enforcing a code style as well as scanning for potential bugs and vulnerabilities. If we have any immediate preferences for which coding standards to enforce, we can update this PR before we merge it. Otherwise we can easily do so later, because both linters can automatically make our code comply with any configured coding standard, which I hooked up together under npm run fix.

@clotoro @pmor80 Do you have any concrete concerns that mean we should not merge this right now?


input group in navbar in Chrome

When you have an input-group (I've only tested it with a button) inside a navbar the form doesn't align and makes the navbar height way longer.

Successor bug against Bootstrap v4: #18751


Could we have a place to talk about implementations related to armorUI ? Like a #Freenode

Hi,
Basically I have been merging a lot of your work lately because I am developing in parallel and adding a couple of things(actually implemented a version of parenting but I prefer your implementation and have a working text area and a new ElementGroup element) and just wanted to know if there could be a communication channel in which you could express the things you want to be done and your preference on implementation( for example to stay away from certain things that we can do in haxe that are not static friendly).  I will make a pull request for the things I changed but its quite big and I guess you would probably prefer small pull requests ?.
Good day,

Hello!
Hm sorry it's my bad, did not expect much PRs here. On top that the editor is stuffed into a single .hx source, will try to organize it properly to ease the collaboration. Once done I will also open issues here about the planned features, so we do not end up working on the same thing.
Yes smaller PRs preferable.:) I will try to stay up more at gitter for chat.


pull request for e2e test at 12/28/2016 14:45:06

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Update TypeScript color to match official branding

Description
The current TypeScript color is close to, but not exactly, the official "TypeScript Blue" color. This PR updates it to match exactly.
Checklist:

[x] I am changing the color associated with a language

[x] I have obtained agreement from the wider language community on this color change.

https://github.com/microsoft/TypeScript/issues/49389
Official website CSS

https://github.com/microsoft/TypeScript/issues/49389 dropping the original issue here for tracking

Lets gooo :sparkles:

I don't like this so much personally because now TypeScript and Python projects don't differentiate because their colors are very similar

Hm yeah the change was definitely noticeable.


host: Remove default max procs limit

The nprocs rlimit limits the process count of the user id of the process
it is applied to. This makes it useless currently, as most jobs end up
running as either root or nobody, resulting in errors like:
fork: Resource temporarily unavailable

When there are more than nproc process running for a specific uid. In
practice, this can happen when scaling a single app to a dozen or so
instances.
The long-term solution is to make sure every job has a different uid,
but this is a complex undertaking, so for now we’ll just remove the
default limit.

LGTM


feat: Add OpenAPI spec

This PR adds an openAPI spec (and generated swagger doc at /docs/openapi) for all endpoints. It uses the schema-to-code approach that we also use in the API.
The src/openapi subdirectory is completely new and contains all the responses and schemas related to openAPI.
The general setup was done in concert with @olav, but some of the types have been added in later.
The most important file is to check out src/unleash-proxy, which uses the new annotations. The openapi directory can be consulted for the details of the models.
Discussion points
There's a few things I'd like to get some input around:
Exporting types from other packages
Today, two endpoints return types (partially) from other packages. They are:

POST /metrics: If the schema doesn't match, we return a Joi.ValidationError
GET /proxy/client/features, which returns the list of features as kept on the UnleashClient.

What should we do about these? I've created schemas (sometimes simplified) for them in this case, but I'm not sure what the best way forward is. It'd be nice if they could be generated or otherwise imported somehow. Maybe Typebox would be a good solution here?
Multiple validation layers
When we specify the request body (as in POST /proxy), we get validation for free via the OpenAPI package (🥳). However, we're still validating via Joi: should we keep both?
Validation return types
And interestingly: they do not return the same errors. Joi returns a JSON payload (or we return Joi's validation result), whereas OpenAPI seems to return a HTML page. Can OpenAPI return a JSON response somehow?
Screenshots

@thomasheartman

Today, two endpoints return types (partially) from other packages.

Seems like we'll have to create the schemas manually, keeping the proxy schemas separate from the client types. Maybe a separate specs package would make sense at some point. :thinking:

However, we're still validating via Joi: should we keep both?

Maybe we could remove Joi from places where it's doing duplicate work, and keep Joi in standout cases where we can't easily spec its logic?

And interestingly: they do not return the same errors. Joi returns a JSON payload (or we return Joi's validation result), whereas OpenAPI seems to return a HTML page. Can OpenAPI return a JSON response somehow?

Good point, should always return JSON. Probably need to catch the OpenAPI errors:

https://github.com/Unleash/unleash/blob/main/src/lib/services/openapi-service.ts#L49-L61
https://github.com/Unleash/unleash/blob/main/src/lib/app.ts#L137

Maybe a similar handler could catch Joi errors and make sure they're all formatted the same?

@olav There's another thing that we should try and figure out somehow: the proxy allows you to override which headers carry the client key. By default it's authorization, but you can set it to whatever you want. If you do change it: is it possible to make the generated OpenAPI spec use this header instead? It's a runtime configuration option, so it seems tricky, but there may be a way around it 🤔

There's another thing that we should try and figure out somehow: the proxy allows you to override which headers carry the client key. By default it's authorization, but you can set it to whatever you want. If you do change it: is it possible to make the generated OpenAPI spec use this header instead?

Good idea. Maybe we could pass the custom header name config to createOpenApiSchema, and rename the header there?
Looks like there's a way to rename the auth header at least: https://swagger.io/docs/specification/authentication/api-keys/


Add unit tests for containerInspect

Wrote a unit test for ContainerInspect 🐨 based on the current one (ContainerStart).
I was wondering if I should split it into 3 tests or not (my heads tells me it should be 3 unit tests, my finger were lazy :sweat_smile:).
/cc @calavera
🐸
Signed-off-by: Vincent Demeester<EMAIL_ADDRESS>

Yea they should be separate, but then you have to have three mocks.

That's what I'm talking about. I like it like that. Inlined and everything.
LGTM.

LGTM


DOC: removed a triple f in Difffusion.

There were 2 typos where the word Diffusion was written as Difffusion.

Merci!

Note: I think the TRAVIS test failed because we have secret keys (for AWS-S3) configurated in our Travis setup, which PRs from external accounts don't have access too. I first need to merge it in another (non-master) branch in our repo, and then merge that branch to master.

#309


 These variants are some kind of extension objects, which are stored as 'program' (object type PROG in TADIR), but which are named ...=====VC (where the 'VC' is at position 31 and 32 of the program name), e.g.

This caused an error ("error from INSERT REPORT") since INSERT REPORT by default can not handle such extensions, e.g. programs with names longer than 30 characters. However, it works using the internal addition EXTENSION TYPE, see http://help.sap.com/abapdocu_751/en/abapinsert_report_internal.htm#!ABAP_ADDITION_1<EMAIL_ADDRESS>(There, type group SREXT is referenced for allowed extension types, but VC is not in it. Seems that the suffix of the program name corresponds to the required value for exttype of the addition EXTENSION TYPE.
This pull request contains a fix for this issue, thus I was able to clone the repository, also the code inspector variant was successfully imported.

FYI, not really a program but some data... Here's an example


Config: Make preset config aware of cpu/memory

Preset property is bound with cpu/memory/bundle and have default
values for it but our set function doesn't have map around those
settings and a user can do following without any error message.
$ crc config set preset microshift
$ crc config set cpus 2
$ crc config set preset openshift

and when user try to perform crc start then error message shown.
With this PR we are making the set function bit self aware of the
preset and it's bound properties (cpu/memory) and make sure if those
property doesn't validated for the preset then unset those so default
values going to take over.
with this PR following now works as expected.
$ curl -X POST -d '{"properties":{"preset": "microshift"}}' --unix-socket ~/.crc/crc-http.sock http:/c/api/config
{"Properties":["preset"]}
$ curl -X POST -d '{"properties":{"cpus": "3"}}' --unix-socket ~/.crc/crc-http.sock http:/c/api/config
{"Properties":["cpus"]}
$ curl -X POST -d '{"properties":{"preset": "openshift"}}' --unix-socket ~/.crc/crc-http.sock http:/c/api/config
{"Properties":["preset"]}
$ curl -X GET --unix-socket ~/.crc/crc-http.sock http:/c/api/config | jq .
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   894  100   894    0     0  56924      0 --:--:-- --:--:-- --:--:-- 59600
{
  "Configs": {
    "bundle": "/Users/prkumar/.crc/cache/crc_vfkit_4.12.13_arm64.crcbundle",
    "consent-telemetry": "no",
    "cpus": 4,
    "disable-update-check": true,
    "disk-size": 31,
    "enable-cluster-monitoring": false,
    "enable-experimental-features": false,
    "enable-shared-dirs": true,
    "host-network-access": false,
    "http-proxy": "",
    "https-proxy": "",
    "ingress-http-port": 80,
    "ingress-https-port": 443,
    "kubeadmin-password": "",
    "memory": 9216,

[...]

Started with:
{
  "consent-telemetry": "yes",
  "cpus": 2,
  "preset": "openshift"
}

PS> crc config set cpus 4

cleared the default:
{
  "consent-telemetry": "yes",
  "preset": "openshift"
}

Note: the default preset remains (?)
PS> crc config set preset microshift

changed the preset:
{
  "consent-telemetry": "yes",
  "preset": "microshift"
}

PS> crc config set cpus 1

Value '1' for configuration property 'cpus' is invalid, reason: requires CPUs >= 2

PS> crc config set cpus 2

does not add the value (as matches default)
PS> crc config set cpus 2

{
  "consent-telemetry": "yes",
  "cpus": 3,
  "preset": "microshift"
}

Now changing to OpenShift again:
PS> crc config set preset openshift

{
  "consent-telemetry": "yes"
}

SO this looks good... though here the default preset was cleared. Earlier it didn't.
Feedback this happened would be appreciated, not high priority... we have #3636.

Found this reference to some interesting historical fact:
https://github.com/crc-org/crc/pull/2888/files#r770370496

Will need some follow-up work https://github.com/crc-org/crc/issues/3652


NPM not loading after docker container update.

Checklist

Have you pulled and found the error with jc21/nginx-proxy-manager:latest docker image?

Yes

Are you sure you're not using someone else's docker image?

Yes

Have you searched for similar issues (both open and closed)?

Yes

Describe the bug
Just update today and I see this error message in Logs:
/run/s6/basedir/scripts/rc.init: warning: s6-rc failed to properly bring all the services up! Check your logs (in /run/uncaught-logs/current if you have in-container logging) for more information.
Nginx Proxy Manager Version

I can not load NPM web interface.
To Reproduce
Steps to reproduce the behavior:

Just try to load webpage...

Expected behavior

Load webpage
Screenshots

Operating System
Ubuntu 22.04 with docker
Additional context
It was working perfectly since last update.

This suggestion fixed this issue for me. #2774

This suggestion fixed this issue for me. #2774

Hi guy,
I am not using mysql, just npm container.
I did a rollback to 2752 and it worked. Stop updating image until hace clear.

Exact same problem here with the latest docker package update, I have to do docker restart to have NPM up and running correctly. I'm on Raspberry Pi 4, each time the Rapsberry reboots, I have to restart NPM manually.

Hi @CanonCan I am using the latest tag (build 2.10.2) and everything remains operational

I'm on 2.10.2 as well. I can finally get to the web gui with the internal IP, my container was set to use port 81 for the interface but it was trying to use 80 for some reason I changed it to 181 and now I can get to the interface but all my reverse proxy stuffs gives me a cloud flare. 521 error
Sincerely,
Michael

On Apr 11, 2023 at 07:16, Dan Knight  @.***>  wrote:
Hi  @CanonCan  I am using the latest tag (build 2.10.2) and everything remains operational
—
Reply to this email directly,   view it on GitHub, or   unsubscribe.
You are receiving this because you were mentioned.Message ID:  @.***>

I had a similar issue after updating to v2.11.1. I do not know if it may be a regression or a new bug, but it is similar enough.
It started working, but after setting up 3 proxies it started hanging up, as in totally hanging up the web server. The most basic proxy did not cause problems: phpmyadmin, a proxy HTTP to HTTP did not cause any problems, but portainer or owncloud (HTTPS to HTTPS , or HTTPS to HTTP) caused it to fail after some time.
Both the GUI and the redirections worked for a few minutes, and then suddently stopped responding, and the only solution was to delete the data volume and recreate the docker to force a full reset. Restarting the dockers did nothing. The health-check stalled too, until the health failures started showing.
Because the proxy stalled, there where no logs about why it failed. And even then, because I needed to delete the log files, it seems it failed to recreate them and start logging data after that.
Going back toward v2.10.4 and resetting the configuration allowed me to keep setting them up completly, until they kept worked without stalling.

It would be nice to add some extra functionality to the startup script to verify the existence and integrity of the log files.

The command line healthcheck is miss-documented, it is located at /bin/check-health, not /usr/bin/check-health.

As a feature request:
a.  when creating a new redirection/proxy/whatever, a quick check verfying that a A, AAAA or CNAME register exists showing as a checkmark or badge, would prevent errors due to typing mistakes.
b. Likewise when writing the target of the proxy, a checkmark showing that the configuration written matches with the target would be nice (ex: checking that the "portainer" docker with target HTTPS://local_IP:9433 it is really an HTTPS and not an HTTP listening port.
Given that you can't read the logs from the GUI, that would prevent some of the most basic mistakes.


Use gzip insted of unzip

On some sites with gzipped xml I got decompressing: incorrect header check. The problem was in detection type of archive. Gzip encoder will find it automatically.

@evanderkoogh Could you, please, review it&publish? I dont want to upload new package with such small edition. Thank you.

Absolutely will. 7am here in Australia now. After I had a shower and some coffee 😂

On 21 Feb 2019, at 06:46, Max Frai<EMAIL_ADDRESS>wrote:
@evanderkoogh Could you, please, review it&publish? I dont want to upload new package with such small edition. Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.


Update scripts.nix

Issue

the script should change its path in to the state directory (e.g. state-node-mainnet) as logs files are placed in the current directory and scripts that analyse those expect them to find in the state dir.

This PR results/does not result in breaking changes to upstream dependencies.

Checklist

[x] This PR contains all the work required to resolve the linked issue.

[ ] The work contained has sufficient documentation to describe what it does and how to do it.

[ ] The work has sufficient tests and/or testing.

[ ] I have committed clear and descriptive commits. Be considerate as somebody else will have to read these.

[x] I have added the appropriate labels to this PR.

verified the script locally. it outputs the analysis of the run again.
the nightly job should run again smoothly.
https://buildkite.com/input-output-hk/cardano-node-nightly-sync

bors r+


incomplete vendor directory

Despite having a vendor directory, in the Homebrew formula we still have to fetch golang.org/x/net manually, or the build fails, as follows:
==> go build -o /usr/local/Cellar/leaps/0.6.1/bin/leaps github.com/jeffail/leaps/cmd/leaps
src/github.com/jeffail/leaps/vendor/github.com/amir/raidman/raidman.go:19:2: cannot find package "golang.org/x/net/proxy" in any of:
	/private/tmp/leaps-20170517-24817-1xfnewq/src/github.com/jeffail/leaps/vendor/golang.org/x/net/proxy (vendor tree)
	/usr/local/Cellar/go/1.8.1/libexec/src/golang.org/x/net/proxy (from $GOROOT)
	/private/tmp/leaps-20170517-24817-1xfnewq/src/golang.org/x/net/proxy (from $GOPATH)
src/github.com/jeffail/leaps/lib/http/websocket.go:37:2: cannot find package "golang.org/x/net/websocket" in any of:
	/private/tmp/leaps-20170517-24817-1xfnewq/src/github.com/jeffail/leaps/vendor/golang.org/x/net/websocket (vendor tree)
	/usr/local/Cellar/go/1.8.1/libexec/src/golang.org/x/net/websocket (from $GOROOT)
	/private/tmp/leaps-20170517-24817-1xfnewq/src/golang.org/x/net/websocket (from $GOPATH)
/usr/local/Homebrew/Library/Homebrew/debrew.rb:11:in `raise'
BuildError: Failed executing: go build -o /usr/local/Cellar/leaps/0.6.1/bin/leaps github.com/jeffail/leaps/cmd/leaps

It would be great if the vendor directory were complete, so that we can remove the one remaining go_resource block, which would make downstream maintenance easier. In particular, we have to look up the latest git commit of golang.org/x/net and update the formula with it, which interferes with automation of the updates.
Thanks!

Hey @ilovezfs,
Done as of https://github.com/Jeffail/leaps/commit/578f42522a56b5da4bd4b932f199b212eeb38e0b. I'll tag it as v0.6.2. Thanks for updating the Homebrew formula.

Thanks for updating the Homebrew formula.

Done as of 578f425.

Thanks. That's a big help.

I'll tag it as v0.6.2.

Perfect.

I've opened https://github.com/Homebrew/homebrew-core/pull/13644 for 0.6.2


Reuse pred buf to reduce memory

Signed-off-by: xrayleigh2000<EMAIL_ADDRESS>

Thank you for looking into this.
Did you have a look at the performance? Especially the INTER task is great for parallelization, and we used to rely very much on it (we didn't reevaluate the architecture in quite some time tho, and a lot changed since).
Overall this would save around 60MB for UHD decoding indepdent of threading, right? (two full frames of Pel)
Because of some upcoming dates (CES/vacation) we will only be able to properly have a look at this towards the end of January, so please be patient. If you could in the meantime provide some additional data like memory savings, performance impact, it would be highly appreciated.
Also, the CI seems broken, please have a look.

Thank you for looking into this.
Did you have a look at the performance? Especially the INTER task is great for parallelization, and we used to rely very much on it (we didn't reevaluate the architecture in quite some time tho, and a lot changed since).
Overall this would save around 60MB for UHD decoding indepdent of threading, right? (two full frames of Pel)
Because of some upcoming dates (CES/vacation) we will only be able to properly have a look at this towards the end of January, so please be patient. If you could in the meantime provide some additional data like memory savings, performance impact, it would be highly appreciated.
Also, the CI seems broken, please have a look.

Hi @xrayleigh2000, thanks for the PR.
I had a quick look into it and tested it on my machine. As @adamjw24 expected, it is much slower than the original implementation, because it significantly reduces parallelism. On my machine running with 10 to 20 threads decoding FullHD content was 1.3 to 1.4 times slower.

Hi @adamjw24 @K-os, Thanks for your reply.
Under the current architecture, pred buf is difficult to modify to CU-level size. I am going to close this pull request. For subsequent optimization, I will submit new pull requests and provide more test data.


Call lambda code using python runtime

Hello,
I'm trying to configure appsync-serverless-emulator to run AppSync and to call some local lambdas.
At this moment the serverless is configured to use python3.6 runtime for the function that I'm trying to call. But, for instance, when I call my Query on GraphQL which should call the respective Lambda, debugging the appsync-emulator-serverless shows that is trying to call a NodeJS version of it. How can I configure the emulator to run also Python code? Or this implementation doesn't work in that way?
And it is possible to call deployed lambdas with the appsync-serverless-emulator offline?
Thanks,

Currently, the emulator only supports calling nodejs lambda methods.  However, it will not be difficult to implement a python implementation of lambda.
Could I interest you in putting up a PR to implement a python solution?  I will gladly assist on the way.
Currently, the node implementation is here: https://github.com/ConduitVC/aws-utils/blob/master/packages/appsync-emulator-serverless/lambdaRunner.js
Here is where the lambda method is called.

I add a WIP here:
https://github.com/ConduitVC/aws-utils/pull/56
can you check?

Can I close this issue?


Feature/own library usage footer

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
usage of my own library instead of self contained footer in the starter

What is the current behavior? (You can also link to an open issue here)
FooterComponent implements the footer of the page in the app

What is the new behavior (if this is a feature change)?
FooterComponent that implements the footer of the page in the app is now taken in an external library "ma-librairie". This library has not been published on npmjs, only in my sinopia registry.
Should be possible to change dependency to "ma-librairie" and use dependency to the corresponding github repository instead.

Other information:

woooops sorry guys I made a mistake I thought I was doing the PR on my own fork of this project. Please cancel my PR and forget it !


fix: remove react-medium-image-zoom

:pencil: Description

This is unused right now so removing it

:tada: This PR is included in version 1.0.2 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Slice.subslice

This extends the new slice API with a new subslice function extracting to &s[a..b] in Rust.

cc @tahina-pro


Release 2.1.0

This release breaks the Custom Matcher api (assertOrder and doAssert are merged) therefore the minor version bump.
@cs-rafael-toledo

:+1:


copy the default config into docker image

I found that if I'm using the environment variables to configure the docker instance I still need to copy in the default config, this just saves a step when deploying.

This is fine, and I sincerely doubt this command would ever break anything. So I'm just going to merge it in.


Create MWP

Creating minimal working program.

Minimal program works. Mistake in a commit message. Manually closed.


Add Gopala-Sai-Krishna's

created a branch, created a file and made a commit, and opened a pull request

good


Use Java 7 as the minimum required Java version

Now that the vote to upgrade the minimal required Java version has been passed[1], the commit here upgrades the version to Java 7.
[1]<EMAIL_ADDRESS>

merged


feat(cli): parsing Union Type

Describe the bug
This is rather a feature, where parsing configuration should support union type.
TODO:

convert union to correct click type. This probably will involve writing custom Click type called UnionType.

To reproduce
No response
Logs
No response
Environment
No response

not planned


New Release

@JuliaRegistrator register

Registration pull request created: JuliaRegistries/General/93918
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.1 -m "<description of version>" ed47f361ece394747aeb4787d9fe05da52abcda9
git push origin v1.0.1

@JuliaRegistrator register

Registration pull request updated: JuliaRegistries/General/93918
After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.
This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:
git tag -a v1.0.1 -m "<description of version>" f8d93171c5986c0bd8694d55b65426e8bd04b163
git push origin v1.0.1


#8 Delete Service

Value Proposition
As a User
I want to delete a Services
So that I can make sure that outdated services will not be used anymore.
Description

Acceptance Criteria

[ ] When a Service is clicked the User will be redirected on a new Page to see the Service
[ ] The user gets to see the whole service Form
[ ] There is a Delete Button displayed
[ ] On click the Service will be deleted
[ ] the user will be redirected on the Services Page

Tasks

[ ] Create a new feature Branch
[ ] Create Delete Button
[ ] On click delete the service
[ ] Redirect the User on Services page

Complexity
M

"On click the Service will be deleted"
💭 I think you mean to say that "On click the selected Service will be deleted"?
"Redirect the User on Services page"
💭 By doing what? More specificity.
➡ "Redirect the User to Services page upon clicking the delete-button"

Hey Petros,
Your scribble contains elements which are not part of your app & user story yet (e.g. hamburger menu, profile picture). Please adjust your scribble.
Will the user need to confirm deleting the service or will it be deleted instantly? 🙂


allowDynamicBackends(); has no affect on Dynamic Backends.

Using v3.15.0 of js-compute on Fastly, with Dynamic Backend support enabled:

Setting allowDynamicBackends(false); at a global scope, does nothing.  Dynamic backends still work fine.
Setting allowDynamicBackends(true); at a global scope, and allowDynamicBackends(false); at local scope, also does nothing.  Dynamic backends still work fine.
Setting allowDynamicBackends(false); in both global and local scope, does nothing. Dynamic backends still work fine.
Completely omitting calling allowDynamicBackends(); does nothing. Dynamic backends still work fine.

It seems allowDynamicBackends(false); or allowDynamicBackends(true); do nothing.

With allowDynamicBackends(false) all calls to fetch must have a backend property provided. If you are finding this is not the case, can you share a code example of how you are able to achieve this?

Here's a Fiddle:  https://fiddle.fastly.dev/fiddle/a1152147
Note that the Fiddle works as it's supposed to.  No backend is setup when allowDynamicBackends(false);  But I find that when I actually upload the Compute code, this value is ignored.
Let me know if you're able to replicate.

@alex8bitw when you say "ignored" do you mean that the application you've provided in the fiddle works correctly on compute instead of failing?

I went over the code, and I believe I see the issue.
I was setting allowDynamicBackends(false) in a global scope, but I was also setting the following in a local scope:
allowDynamicBackends({
connectTimeout: global_connectTimeout,
firstByteTimeout: global_firstByteTimeout,
betweenBytesTimeout: global_betweenBytesTimeout,
});
The dynamic timeout config overrides the allowDynamicBackends(false), this seems to be by design.

That is correct, the default behaviour is for dynamic backends to be disabled. When calling allowDynamicBackends with a value other than false, they are enabled.


Add _Cel.loader.nodejs.js to fix build error in webpack

When building a webpack project which includes wikiapi as a dependency, webpack fails to build the project due to wikiapi.js requiring _CeL.loader.nodejs.js in a try/catch block, which doesn't exist in the wikiapi project folder.
One easy solution to this problem is to simply include the file so that builds don't fail. Another solution is to remove the require altogether.

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   77.22%   77.22%
=======================================
  Files           1        1
  Lines         101      101
=======================================
  Hits           78       78
  Misses         23       23

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930358f...6e4cdfc. Read the comment docs.

Hi. Thank you very much for using the module.
I used _CeL.loader.nodejs.js only for debugging locally:
https://github.com/kanasimi/wikiapi/blob/930358f2f8e15d4df05cc1562303d49deeaa31cd/wikiapi.js#L7-L11
And if possible, I think it is better using CeL = require('cejs') instead of _CeL.loader.nodejs.js.
May you show me the example code using wikiapi? Thank you.

@jalavosus Thank you for your testing. If no other issues, this request will be closed.


Fixed typo in variable name

There was a typo in setTags in the filesystem adapter.

@webimpress You're right, this would've been caught if there was a test case that passes an empty array for tags. I'm off today, but I'll add a test case this evening or tomorrow for this.
Off topic: I made a Redis adapter that supports tags for one of our projects. Should I make a PR?

@ptodorov0123

but I'll add a test case

Cool, thanks 👍

I made a Redis adapter that supports tags for one of our projects. Should I make a PR?

Sure, create PR 😄

Thanks, @ptodorov0123!


BibClassify: ontology cache check improvement

Fixes an issue in the ontology cache checking where the wrong file
path was being checked.

Signed-off-by: Jan Aage Lavik<EMAIL_ADDRESS>Master version of #2671

Reviewed-by: Tibor Simko<EMAIL_ADDRESS>Thanks, amended commit log message and merged as 2ad9e80b1832eb9cc6cf7f4ea0393c373a7416e1.


Change the region check method and add new region checks into cms_*.js files

I was testing (node.js env) some alternatives to the region check method and came up with the function bellow:
	function createPackage(name) {
		var packageNames = name.split('.');
		var parent = in_window;
		var fullLoadedPackage = '';
		for (var i = 0; i<packageNames.length; i++) {
			if(typeof parent[packageNames[i]] === "undefined")
				parent[packageNames[i]] = {};
			else
			{
				if(typeof parent[packageNames[i]] !== "object")
				{

					throw new Error("Name " + fullLoadedPackage + packageNames[i] + " already exists and it's not an object");
				}
			}
			parent = parent[packageNames[i]];
			fullLoadedPackage += packageNames[i] + '.';
		}
		return fullLoadedPackage.substr(0, fullLoadedPackage.length - 1);
	}

also add the checking of the x509 packages into those files (for node, it only worked after adding those packages):

cms_simpl.js

	createPackage('org.pkijs.simpl.cms');
	createPackage('org.pkijs.simpl.x509');

cms_schema.js

	createPackage('org.pkijs.schema.cms');
	createPackage('org.pkijs.schema.x509');

Also, a quick tip to import all the required libs (I've added common and asn1 into pkijs folders):
var extend = require("extend");

var pkijs_libs = [
  "pkijs/org/pkijs/common"
  ,"pkijs/org/pkijs/asn1"
  ,"pkijs/org/pkijs/x509_schema"
  ,"pkijs/org/pkijs/x509_simpl"
  ,"pkijs/org/pkijs/cms_schema"
  ,"pkijs/org/pkijs/cms_simpl"
];

// #region Merging function/object declarations for ASN1js and PKIjs
var pkijs = {};
for (var i = 0, len = pkijs_libs.length; i < len; i++) {
  extend(true, pkijs, require(pkijs_libs[i]));
};
// #endregion

Main idea of PKIjs code is making a code "transparent" to any evironment. In PKIjs there are no code worring about Node.js, any package manager or whatever. Instead of it each developer using PKIjs need to worry about the eviromnent he/she is using.
As a conclusion: I do not recommend to include information about Node.js in PKIjs files. Instead you should import PKIjs object from Node.js files, as it shown in README. Regarding your code with require("extend"): it was long time ago and I do not remember all things, but I had problems with "extend" package and do recommend to use "node.extend".

I understand that you don't want to add any dependency or relation to node.js. But the idea of the createPackage function was only to try to extract a repeated task into a method and call it in a more readable way.
Still, I'm having problems running the test app (main idea is to create a P7S Viewer). But when I try to read the P7S I get some wired error (even thought that the same signed file works if I use the CMS Signed Copmlex example. I'm debugging to check what's wrong with my code (even having in mind that it has less than 10 lines) and with the use of PKIjs on a Node.js env.

Try to use "node.extend" instead of "extend" - its might help you.

I have even put all the content into a single file but it didn't help.

Try to local in code line with "Wrong parameter: input_buffer has zero length" and put any additional debug messages there.
Since this is not a PKIjs bug and I have no plans to change "cms_*.js" I have closed the issue.


Enable CSV download globally

Guidelines
Please note that GitHub issues are only meant for bug reports/feature requests.
Feature request template
Is your feature request related to a problem? Please describe.
I find it annoying to have to select the "enable csv download" button on all dashboard panels as I end up enabling this on all dashboard panels.
Describe the solution you'd like
I would like you to add "enable csv download" to the global settings for the dashboard.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

I second that.
Would also be handy for image download and full screen: include in global settings and possibility to override in individual reports.


Automatic error report

<!---