Message list doesn't scroll to bottom

Message list doesn't automatically scroll to bottom, even if there are no unread messages in the particular stream.

Please elaborate.
Does it happen always? Is it just for streams? For topics? For direct messages too?

Reproduction Steps:

Go to a stream where you have unread messages, quickly click on 'mark stream as read' button.
Scroll down to the bottom.
Then exit the stream.
Then hop in back to the stream

I've verified this.
The position of last read message is same as when you had the unread messages.

Fixed by #2082


Post AGU Updates

Additions

Local Environment setup instructions
Added EWT and ET cloud-optimized GeoTIFFs generated for the workshop to repository
Added list of required granules/scenes to execute notebooks
Added workshop slides.md

Changes

Updated earthaccess search to use concept-id for Notebook 1
Implemented downloading of required scenes for Notebooks 2-5 into a cell in Notebook 1
Made minor changes to Notebook 5 to fix cloud/local compatibility issues
Fixed implementation of ewt_detection_limit threshold in ewt_calc.py
Improved description of ewt_detection_limit in Notebook 3
misc typos/syntax fixes

note to self, fix projection of ECOSTRESS scenes in notebook 2

Notes for Review of VITALS:
- The Change Log needs to be updated: https://github.com/nasa/VITALS/blob/post_agu_updates/CHANGE_LOG.md
- Recommend putting something in the README that says something like "To run the notebooks locally, check out the Repository Setup Instructions (link to: https://github.com/nasa/VITALS/tree/post_agu_updates/setup)
- In the first notebook, there is an explanation:
	You may have noticed that the date format is similar for ECOSTRESS and EMIT, but the ECOSTRESS data also includes fractional seconds. If using the recommended lpdaac_vitals Windows environment, you will need to pass the format='ISO8601'argument to the to_datetime function, as shown in the commented-out line.
	Question: Where it says "Windows environment" should that actually say "Python environment"?
- First Notebook:
	"In the figure above, you can zoom in and out, click and drag to reposition the legend, and add or remove layers using the layer control in the top right."
		"click and drag to reposition the legend"--this did not work for me locally (or maybe there just isn't a legend anymore?)
	○ Final cell of first notebook: polygon = gpd.read_file('../data/Sedgwick_Boundary/Sedgwick_Boundary.shp').to_crs("EPSG:4326") <- this file does not exist in the repo
- Second Notebook:
	○ Background section could possibly be omitted since it is already included in the first notebook?
	○ "Note that here we don't use tiles -- there seems to be a bug preventing this." <- is this still true? Seems like the visualization below has tiles set to ESRI
- The issue outlined below still exists for the second notebook
	1. notice I added rio.reproject("EPSG:4326") and it looks good around the edges

Vs. The original:
3. I think hvplot is a bit wonky in its reprojection along the edges
(would need to update this a bit too: The underlying functions will recognize the CRS and reproject the scene for our visualization with an ESRI imagery RBG background tile.)

I've made all the recommended changes.


Fix for OpenerService not Checking for onCommand Events

This PR fixes #9120.
In my mind, there are 2 ways to solve that particular bug:
Option 1: Change the resource-deployment extension's activation events back to *
Option 2: Investigate why the OpenerService was failing quickly when an extension-contributed command whose activation events were only onCommand events
I went with option 2. If anyone strongly disagrees, please let me know. If folks agree, I can take this change to vscode and try to merge it in there.
From the Welcome page, if we clicked on "New Deployment..." and the resource-deployment extension wasn't yet loaded, users would see nothing happen, and an error in the console was logged that the command could not be found.
In the OpenerService, the CommandsRegistry was being checked for a given command id. In the CommandService, there is very similar code (where the CommandsRegistry is being checked), but there is also a check for extensions that should be activated by that particular command id. Since the OpenerService calls into the CommandService here, this premature check of the CommandsRegistry is duplicate, causing our scenario to fail.

VS Code's markdown implementation blocks command scheme URIs by introducing 'vscode-resource' as the scheme, so this problem does not exist there. On their welcome page, they only have commands that are workbench actions.
For us, here's what we have in the welcome page:

${escape(localize('welcomePage.newDeployment', "New Deployment…"))}

@anthonydresser do you have any other ideas for how we can address this?

Could you activate the extension when the welcome page is opened?

Or if this is already basically built into the core (the command string is in the core code). register a workbench action that you use instead.


Use/Allow system defined ssh over nix packaged one.

Describe the bug
When running nixos-anywhere, the script will use the nixpkgs version of openssh. This is problematic on non-NixOS based systems such as Fedora 37. Where openssh is packaged with extra features, leading to a crash loop due to the feature-sets clashing inside the system's packaged openssh.config files.
% nix run nixpkgs#openssh --<EMAIL_ADDRESS>/etc/crypto-policies/back-ends/openssh.config: line 3: Bad configuration option: gssapikexalgorithms
/etc/crypto-policies/back-ends/openssh.config: line 7: Bad configuration option: rsaminsize
/etc/crypto-policies/back-ends/openssh.config: terminating, 2 bad configuration options

To Reproduce
Steps to reproduce the behavior:

Install an operating system such as Fedora 37.
Install nix trough the official means or through nix-community/nix-installers.
Attempt to run nix run nixpkgs#openssh on the system.
Similarly, the nix run github:numtide/nixos-anywhere breaks similarly due to the above package.

Expected behavior
It runs correctly as if it was on NixOS.

System information
Operating System: Fedora Linux 37 (Workstation Edition)
          Kernel: Linux 6.1.7-200.fc37.x86_64
    Architecture: x86-64

Additional context

None.

Running the openssh_gssapi version also breaks, but without the gssapi related error:
% nix run nixpkgs#openssh_gssapi<EMAIL_ADDRESS>/etc/crypto-policies/back-ends/openssh.config: line 7: Bad configuration option: rsaminsize
/etc/crypto-policies/back-ends/openssh.config: terminating, 1 bad configuration options

Another solution may be to upstream a fix to nixpkgs, but i do not know what the best approach would be to do so.

In nixpkgs, they decided to not hard-code the ssh binary in git: https://github.com/NixOS/nixpkgs/issues/160527 and https://github.com/NixOS/nixpkgs/pull/166334/commits/cae8d1a2ed7ee3bd0a3f029b452ce6ef25537278
This likely also means Apple's ssh config is also affected by this.
A workaround I figured out under Fedora 37 using IgnoreUnknown can be helpful for today:
$ cat /etc/ssh/ssh_config.d/10-nixpkgs-support.conf
Match all
    IgnoreUnknown "rsaminsize,gssapikexalgorithms"

So the choice would be:

Normalize including a file similar to /etc/ssh/ssh_config.d/10-nixpkgs-support.conf for support.
Take from how git inside nixpkgs solved this.
Take from git, but use GIT_SSH as the preferred binary if available.

see https://github.com/numtide/nixos-anywhere/pull/66


Global reset

Add global option to reset command

@lukesampson ?

To me, reset doesn't make much sense for global apps. Global apps are for every user on the system. The reset command is for switching between different versions of an app, and that could cause chaos if an administrator is switching versions on everyone. I think this is the sort of thing you want to control just for yourself as a developer.

I'd be interested to know the use case in which wanting to reset a global app comes up. Perhaps @sestegra can shed some light on this?

should be handled some way, currently installing ruby & ruby19 globally works but switching wont work. you should either allow installing both and allow global switching or disallow install both versions


ADX | batch vs. streaming

"Data received from batch in the shared database will appear between a few seconds to a few minutes on the data consumer side. Data received from streaming could take up to 24 hours to appear on the data consumer side."
Seems the other way around

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: afc77dcb-f4ee-7b26-9e40-6fc0009361ef
Version Independent ID: 41bdf970-6dae-7d9d-1676-83953c44b9e7
Content: Supported data stores in Azure Data Share
Content Source: articles/data-share/supported-data-stores.md
Service: data-share
GitHub Login: @joannapea
Microsoft Alias: joanpo

Thank you for your detailed feedback.  We are looking into the issue, and we will respond when we have more information.

@joannapea Can you please take a look at this?

I confirmed with the developers that the original documented statement is correct. Because the streaming ingestion data is stored in row store, it can take up to 24 hours to get the data to the column store and then its visible to the follower cluster. See also: https://docs.microsoft.com/en-us/azure/data-explorer/ingest-data-streaming
Thanks, Jason
#please-close


merge from template-sync/template

.github/workflows/ci.yml

chore: (jobs.test-node.steps)
chore: (jobs.release.steps)

.github/workflows/codeql_analysis.yml

chore(actions): merge from template .github/workflows/codeql_analysis.yml

.github/workflows/update_package_lock.yml

chore(actions): merge from template .github/workflows/update_package_lock.yml

.github/workflows/update_readme_api.yml

chore(actions): merge from template .github/workflows/update_readme_api.yml

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 95.161%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
54

Relevant Lines:
56

💛  - Coveralls


nologger option could be clearer

Just from reading the documentation:
"nologger, If you're debugging or whatever, turn off logging. Defaults to false (leave logging on)."
The double negative is a bit confusing.  Something like "logger" or "logging" with "defaults to true" would be clearer.

I'd like to deprecate nologger in the next release or two; marking as "near future"


How does it works ?

following the discussion here: https://github.com/brummer10/jalv_select/pull/7 , I'm just wondering what is the recommended way to install it given I'm on a Debian Jessie (stable) system ?

@trebmuh should work fine on any distribution. I have just tested it on a debian jessie, works as intended.
The debian jessie I have access to ships zyn 2.4.3, which ships no LV2 plugin.
I thus assume you got your zyn 2.5.3 from elsewhere or complied it yourself...
Just clone, configure, build and install (will go to /usr/local/lib/lv2/zyn_ext_gui.lv2 by default)
sudo apt-get install git cmake lv2core libuv-dev git clone https://github.com/ventosus/zyn_ext_gui.git cd zyn_ext_gui mkdir build cd build ccmake .. make sudo make install
If you don't feel like compiling it yourself, here a compiled binary for x86_64: just extract and drop it in /usr/lib/lv2; /usr/local/lib/lv2 or ~/.lv2
zyn_ext_gui-lv2-x86_64-linux.zip

binaries for x86_64, i686, armv7h can now also be found at:
https://github.com/ventosus/zyn_ext_gui/releases/tag/2.5.3


OpenSSL conflict with node 6.3

So we need to bump OpenSSL to the latest x.2 anyways (I believe its h), but as of node 6.3, some sort of exports in windows are conflicting with our OpenSSL bundling.
In order to get PRs running again I've temporarily capped all builds at 6.2 here: https://github.com/nodegit/nodegit/commit/7cfcf9956ef87973aed98f65656dc24f9b559d74
@implausible and I are going to try to bump OpenSSL and if that doesn't fix it, we'll dive into what exports are conflicting so we can get builds back on track

@maxkorp @implausible what did you guys find out?

Haven't gotten to touch this :/

Very much related: https://github.com/nodejs/node/issues/7608
This is going to end up with some bizarre gypfile tomfoolery

Does not look good, in particular related to electron >.<
https://github.com/nodejs/node-gyp/issues/874

Ooh, possibly related
https://github.com/electron/electron/pull/6585/commits/e8c03f2555f5c4ac0b867cf20dc13160836b7c8a

Ha, that worked!

So bumping openssl actually breaks node 0.12 though. I'll make an issue for that

Also related
https://github.com/nodejs/node/issues/4932

https://github.com/nodejs/help/issues/254

This<PHONE_NUMBER>4f68fe1e5a34a3ea2f04257fe931fe improve build. Or it is not full correctly?

dd


Fixed Issue #552

This PR implements the fix proposed in the issue:

Created a small script to convert Dockerfile into Singularity.def in a way that avoids the %files command.
Used said script to generate Singularity.def (tested on the cluster, works)
Updated README docs.

Note that the PR also includes the generated Singularity.def file. This refactoring IMO has several advantages for the end user:

They don't need to install spython, one dependency less
Less steps: also no need to generate the recipe
The recipe itself is known to work (at least in our cluster)
If users wish to customize their image creation, they can use the newly provided script as a starting point, much more flexible than the previous command.

Let me know if you have any comments!
Cheers
Andres

recheck

recheck

I'm not sure I'm doing the CLA right... sorry for the noise, I'll check again tomorrow.

Hi @runame thanks for checking it out.
I've just submitted the signed CLA form to the admins, and pushed the quotation mark fix. Sorry about that one.
Let me know if there is anything else needed from my side to get this PR through.

Alright, now isort should not complain, and resolved the README conflict.
Let me know if any further actions are needed!

Hi Andres, there is a merge conflict left on this PR after we reorganized the documentation. Can you move your documentation updates to the GETTING_STARTED.md under the section Using Singularity Instead of Docker please? link to section

Dear @priyakasimbeg, thanks for taking another look into this. I see that you've moved some of the README contents into GETTING_STARTED. This seemed to include 100% of the merge conflict, so I've:

Deleted all merge conflict contents from the README, leaving it exactly as it is on your current main branch. No conflicts should remain.
Updated  the singularity section from GETTING_STARTED with the contents of this PR, plus some minor phrasing updates.

Let me know if this looks OK, and thanks again!


Update ReadTheDocs with instructions that make use of the CLI

The CLI is good. The documentation should be updated to direct users towards it.

oh this is done already in the (now rendering properly) docs


Release/0.4.0

Github Issue: #3
Description
net2cog is ready for production check in

Updated https://wiki.earthdata.nasa.gov/display/HARMONY/Transformation+service+availability+and+compliance
Added regression test notebook https://github.com/nasa/harmony-regression-tests/blob/main/test/net2cog/net2cog_Regression.ipynb
Production readiness check-in scheduled for 2024/09/05

Overview of work done
Setup harmony service, umm-s record, ci/cd, unit tests, regression tests
Overview of verification done
Executed the service locally. All unit tests pass
Overview of integration done
Deployed 0.4.0-rc.2 to UAT and tested with request
curl --location 'http://harmony.uat.earthdata.nasa.gov/C1234410736-POCLOUD/ogc-api-coverages/1.0.0/collections/sss_smap/coverage/rangeset?format=image%2Ftiff&forceAsync=true&maxResults=1&granuleId=G1234601650-POCLOUD'
PR checklist:

[x] Linted
[x] Updated unit tests
[x] Updated changelog
[x] Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

Approved for ops release during production readiness review.
Recording: https://wiki.earthdata.nasa.gov/download/attachments/168039791/net2cog_Production_Readiness_Check-In.mp4?version=1&modificationDate=1725577666728&api=v2
Slides: https://wiki.earthdata.nasa.gov/download/attachments/168039791/net2cog Production Readiness Check-In.pdf?version=1&modificationDate=1725900943577&api=v2


Debugger

Type: Bug
The debugger is not functioning well, it flashes wierdly on the current executed line, from time to time and when i want to write in the terminal, it makes me write into the code instead
Extension version: 2023.8.0
VS Code version: Code 1.78.0 (252e5463d60e63238250799aef7375787f68b4ee, 2023-05-03T20:09:00.748Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: Yes

System Info

Item
Value

CPUs
11th Gen Intel(R) Core(TM) i7-1185G7 @ 3.00GHz (8 x 2995)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: enabled_onopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: enabled

Load (avg)
undefined

Memory (System)
15.71GB (5.64GB free)

Process Argv
--crash-reporter-id 8125296c-14b0-4b41-b5fc-e3480da720d1

Screen Reader
no

VM
0%

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
vserr242cf:30382550
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593cf:30376535
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012:30540252
pynewext54:30695312
azure-dev_surveyone:30548225
vscccc:30610679
3biah626:30602489
pyind779:30671433
f6dab269:30613381
vscrpc:30673769
pythonsymbol12:30671437
2i9eh265:30646982
showlangstatbar:30730054
vsctsb:30705553
azdwalk:30721579
pythonms35:30701012
pythonfmttext:30731395
pythoncmv:30731968
fixhidewlkth:30730051
hidesbindicator:30730055
pythongtdpathcf:30731979

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.78.1. Please try upgrading to the latest version and checking whether this issue remains.
Happy Coding!

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


[release-4.7] Enable SNAT and disable Squid - default behavior

This is an automated cherry-pick of #276
/assign yussufsh

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ltccci
To complete the pull request process, please assign bpradipt after the PR has been reviewed.
You can assign the PR to them by writing /assign @bpradipt in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, ltccci
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bpradipt, ltccci, yussufsh
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [bpradipt,yussufsh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


any plans to upgrade wechat client

any plans to upgrade wechat client

any plans to upgrade wechat client

It is under consideration, but there is no definite time point.

Now it supports the v<IP_ADDRESS> version of the wechat client, update to the latest npm package to experience it.


Maybe create docker-compose like the archimate doc

databases may be started with the APIs not the infra

it will be done (almost thanks to microservices dockers) with #162


Errors in Example codes and Troubleshooting

Description
The example code at https://nteract.gitbooks.io/hydrogen/docs/Usage/Examples.html#interactive-plots-using-plotly shows Matplotlib's deprecation warning
C:\Users\Pulkit\AppData\Local\Programs\Python\Python37\lib\site-packages\plotly\matplotlylib\mpltools.py:368: MatplotlibDeprecationWarning:

The is_frame_like function was deprecated in Matplotlib 3.1 and will be removed in 3.3.

Screenshots

@Purukitto feel free to create a PR for this

Will do

@wadethestealth
My editor keeps crashing everytime I try to run this example
https://nteract.gitbooks.io/hydrogen/docs/Usage/Examples.html#html

https://nteract.gitbooks.io/hydrogen/docs/Usage/Examples.html#interactive-plots-using-matplotlib

Is this supposed to open in a new window only? Also see the error popup on the right

@wadethestealth

I have never seen that error before.

Should I start a separate issue for the HTML error?

Also for the crash one we are going to need an error log instead if a screenshot.

The error was gone once I restarted atom

ATOM DUMP.zip

Also for the crash one we are going to need an error log instead if a screenshot.

Attached the Dump file for the crash, not sure if it has to do anything with Atom or Hydrogen in particular  but maybe we can change the example accordingly a bit

@wadethestealth I found out the Issue with the HTML page error.
After some research I found

IFrame is the better way to do that same
The URLs should end in .html viz. be in Unicode

Eg.

@Purukitto So after some reading I think the best thing to do here is use a different demo of HTML rather than our website in the display HTML module.
I can reproduce the warning, but not the crash. I think we should make the current example use IFrame and then create a separate example for html usage.
haven't had time to test matplotlib yet


Can't map ctrl slash in nightly gVIM build on Windows

Steps to reproduce
I tried both noremap <C-/> and `noremap <C-_>' to map ctrl slash but neither worked. Press Ctrl+V followed by Ctrl+/ in insert mode does nothing.
Expected behaviour
Map ctrl slash
Version of Vim
v8.2.4501 64 bit windows installer from https://github.com/vim/vim-win32-installer/releases
Environment
Windows
Logs and stack traces
No response

Press Ctrl+V followed by Ctrl+/ in insert mode does nothing.

Which terminal are you using?
Do you get the same result in the terminal?  Execute a cat(1) command then press Ctrl+/.
Can you reproduce without config (vim -Nu NONE)?

Which terminal are you using?

Ah my bad, your issue is in the GUI.

FWIW, on Ubuntu, I can map <C-/> like this:
nnoremap <C-S-/> <Cmd>echomsg "Ctrl-/ was hit"<CR>

Test:
$ vim -Nu NONE -g +'nnoremap <C-S-/> <Cmd>echomsg "Ctrl-/ was hit"<CR>'

Note that I need to specify the shift modifier in the lhs of the mapping because I need to press it to produce a slash with my keyboard layout.  But your keyboard layout might be different and not require shift.

Did it work in the past, and broke at some point?  If so bisecting the regression might help.

Also, make sure to do a test without any config.  If you can still reproduce, and nothing is inserted when you press Ctrl-V followed by Ctrl-/, then it might be that the keypress is intercepted before reaching Vim, by some other program (window manager, OS, ...).

Did it work in the past, and broke at some point?  If so bisecting the regression might help.

If it's a regression, it might have been caused by the patch 8.2.4502.

If it's a regression, it might have been caused by the patch 8.2.4502.

Never mind, that patch can't be the issue, because your Vim version is 8.2.4501.

Thank you for the prompt reply. I launched gVIM using `gvim --clean' and still didn't see anything after pressing Ctrl+V followed by Ctrl+/. I presume my keyboard is working fine since Ctrl+/ works in Visual Studio, I could be wrong though.

This must be a Windows specific issue, on Linux it works fine.  Without mapping CTRL-/ inserts a slash.

still didn't see anything after pressing Ctrl+V followed by Ctrl+/

If Vim doesn't receive any keycode, then it can't do anything.  The only explanation I can see is that something else intercepts the keypress.
Can you reproduce the issue in a terminal?
If so, try to get a log file:
$ vim --clean -g +'call ch_logfile("/tmp/logfile", "w")'

I can map Ctrl+/ using vim launched through cmd.exe. I think it's a gVIM specific issue.

I cannot use ctrl+/ in either cmd vim nor in gvim. Could that be a windows specific issue? perhaps you need to configure windows keyboard language?

also please see the following: https://vimhelp.org/vim_faq.txt.html#faq-20.5

As far as I looked this,  is not possible to handle with WM_CHAR or WM_SYSCHAR. Only WM_KEYUP can handle this.
diff --git a/src/gui_w32.c b/src/gui_w32.c
index 584e4ef3e..d088cf7a9 100644
--- a/src/gui_w32.c
+++ b/src/gui_w32.c
@@ -4635,6 +4635,18 @@ _WndProc(
 	}
 	break;

+    case WM_KEYUP:
+	// handle CTRL-/
+	if ((GetKeyState(VK_CONTROL) & 0x8000) != 0 && (wParam == 0xBF)) {
+	    char_u string[4];
+	    string[0] = CSI;
+	    string[1] = KS_MODIFIER;
+	    string[2] = 4;
+	    string[3] = 0x2F;
+	    add_to_input_buf(string, 4);
+	}
+	return 0L;
+
     case WM_CHAR:
 	// Don't use HANDLE_MSG() for WM_CHAR, it truncates wParam to a single
 	// byte while we want the UTF-16 character value.

At the least, <c-_> insert some thing characters (^_), it is different issue from <c-/>.
Issue of <c-/> fixes with https://github.com/vim/vim/pull/10141

fixed by https://github.com/vim/vim/commit/e08fde007308fffec818b4ad6eccf573f54bed5b

Thank you @mattn and @chrisbra for fixing it, I confirm it works.

With current version 9.1.0781, seems brocken again

https://github.com/vim/vim/blob/7d755d8ef328a3eced18c57ea1b569898cc448a2/runtime/doc/version9.txt#L41658-L41659

https://github.com/vim/vim/blob/7d755d8ef328a3eced18c57ea1b569898cc448a2/runtime/doc/version9.txt#L41658-L41659

Thanks. I've find this.


Players can have a negative star count

This leads to a Collection not getting imported. So the schema needs to adjusted accordingly.

Fixed with v1.5.2


Outline view

Generic issue for outline view improvements.

In the current version, you should see the list of variables / parameters, events, procedures, methods and functions. If the LS is up and running of course.


remove option to read config from current directory

This feature seems to be more trouble than it's worth

Here's a similar conversation from the last PR:
https://github.com/ZcashFoundation/zebra/pull/714#discussion_r458529306
https://github.com/ZcashFoundation/zebra/pull/714#discussion_r458529306
Using the current directory for the config is non-standard. And it seems to be more confusing than I expected.
I think it will be simpler for users to put a config in the one default location, or -c config.toml.
Originally posted by @teor2345 in https://github.com/ZcashFoundation/zebra/pull/974#discussion_r480717880

For more context, @yaahc and I both struggled to remember why we chose the original priority order - and we expect users will struggle to remember which order the configs are read in.
So let's just have one default config, and -c explicit-config.toml


prevent the agent to throw an error

This is equivalent to improve agent ux with chatgpt #1474 in the py project.
If the tool does not have any proper output, assume this is the last one and return the response of the llm.

we didnt merge this one in the python project, because its probably not the best solution
have you tried this agent: https://hwchase17.github.io/langchainjs/docs/modules/agents/chat_mrkl

Thanks a lot, I was just looking for a quick fix. It was my first ever PR
so immediately the lid on the nose :-). I'll do more research next time.
Your solution is of course the way to go. Thanks again.
Ronald
Op zo 12 mrt 2023 om 00:57 schreef Harrison Chase @.***

:

we didnt merge this one in the python project, because its probably not
the best solution
have you tried this agent:
https://hwchase17.github.io/langchainjs/docs/modules/agents/chat_mrkl
—
Reply to this email directly, view it on GitHub
https://github.com/hwchase17/langchainjs/pull/292#issuecomment-1465052580,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAEIVI6NLVVIPZWARLKTCF3W3UGOJANCNFSM6AAAAAAVXTLISQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

--
Vriendelijke groet,
Ronald


Adopt MIMA

I'd like to propose for this library to adopt MIMA and delegate "maven like" behavior to it. Current landscape of libraries and apps using Aether/Resolver (without Maven but "as in Maven") is very rough, and almost all the apps retry to do the same thing: mimic Maven, and usually they do it wrongly. MIMA offers solution to this.
https://github.com/maveniverse/mima/tree/main
MIMA is Java 8 library, makes use of latest Resolver versions and makes available all the latest features of it (remote repository filtering, local repository locking, new transport that cuts request count in half and many more).
Basic usage in short: make MIMA context module compile time dependency and use it like this:
        ContextOverrides overrides = ... build it using ContextOverrides.Builder
        try (Context context = Runtimes.INSTANCE.getRuntime().create(overrides)) {
          // use resolver: context carries resolverSystem, resolverSystemSession, remoteRepositories
        }

To make it work, add any MIMA runtime as runtime-only dependencies you need (you don't need them compile time).
There are 3 runtimes:

embedded-maven - used when running "embedded"
standalone-sisu - used when running "standalone", uses Eclipse Sisu/Guice DI (as in Maven)
standalone-static - used when running "standalone", replacement for deprecated ServiceLocator

Naturally, you only need one "standalone-*" runtime, no need for both, while "embedded-maven" may be always present, as it does not stir any water (does not have any transitive dependencies and "activates" itself ONLY when inside Maven).
As Resolver (not MIMA) uses SLF4J for logging, you also need to provide a back-end for it at runtime.
By using that pattern above, your code is transportable between all use cases and is simply oblivious where it runs: it will run transparently inside or outside of Maven.
PS: to get rid of build-time warnings of latest maven-plugin-plugin, best is to exclude "standalone-" runtimes when your library using MIMA is used within Mojo, as otherwise maven-plugin-plugin will detect maven artifacts in "wrong scope" (not in provided scope).

Adoption of MIMA should solve:

https://github.com/ops4j/org.ops4j.pax.url/issues/397

Sounds cool! Originally I thought of aether doing exactly this.
If MiMa (love the name Mini Maven) is the thing to go for in 2023 then you are probably right.
Thanks, @cstamas ! Will look into this if no one else picks this up earlier.

Aether alone as we know is not enough. Hence, anything that Aether would provide would be (and is) incomplete (as one have to "tie in" things like models and missing components, mostly from maven-resolver-provider). But even then, things are incomplete, as settings.xml discovery, potential decryption of it and many more logic (present in Maven) is not yet there, hence more code needed. All the projects using Resolver I saw is duplicating all these efforts (and in the process doing questionable decisions).
MiMa is just a "glue" that brings these things together, and it only helps you to grab reference to repoSystem and session configured as you want. After it, it does NOT interfere in any way. Still, since Resolver 1.9.x a repoSystem shutdown is must (and in 1.10.x session close is coming as well) so it offers simple means (Closeable) to handle and clean up Aether properly, taking all of these burden off from you.
Due incompleteness above, we plan to deprecate Guice modules as well, but ServiceLocator is on our eyesight since long time, as it's presence forces Resolver components to be coded in "good ol Plexus DI way", so components must have default ctor, no ctor injection possible, and many circumvention is needed at source level in Resolver itself to make it work, So in 2023 please do NOT touch SL anymore, as MIMA "standalone-static" provides full (and much better) replacement for it with all the whistle and bells.

Thanks @cstamas, I'll have a look, because it's about time to move away from aether. Give me some time to check the impact in things like Pax Web and Karaf (karaf-maven-plugin uses pax-url-aether underneath).

One remark: when you are using MIMA, all these (from "proper" resolver) applies:

"be a good citizen": https://maven.apache.org/resolver/api-compatibility.html
you have access to all these (via "user properties" or "config properties"): https://maven.apache.org/resolver/configuration.html
MiMa intentionally shields you from Maven Models, so you should NOT tamper with Settings etc. If you want to mangle them (ie, in a test), you can still create own Settings, store it on disk and point MiMa at it.

Thanks - it's still on my radar ;)

Fixed with #417 (I did some direct usage of org.ops4j.pax.url.mvn.internal.PaxRepositorySystemSupplier, but I also use as much as I could (I was in quite a hurry) from MiMa).

I've played a bit with MIMA in another project and got it working for basic use case of scanning remote repositories for snapshots/releases. Beyond supplying initial list of repositories and storage path I didn't have to worry much about all other setup tasks needed to get resolver running. From usage point of view it is quite ok.


Poor contrast in diff files highlighting

This is a great theme! My favorite so far. But it has an important issue. Contrast in Diff files is very poor.

If you can fix this it would be great! Thanks!

@sveggiani What is the file format? Is this a json file?

hi @mischah is a YAML .yml file: https://yaml.org/
Thanks!

hi @mischah, I'm having this issue in PHP files as well...
It is somewhat hard to read:

Do you have any plans on updating it?

@mischah, I've submitted a pull request with these colors.
I hope you like it :) Feel free to edit!


Updating AzureDeploy.Json to allow RBAC Subscriptions owners to deploy to Azure App Service.

The existing template gives an error when users who are owners on the subscription try to deploy.
Users who are in this state would see this message in the activity log.
This change updates the API versions and moves the App Settings into the main site properties.
This allows both the RBAC create to succeed and also to have the SourceControls element get the Project hint  from App Settings to build correctly in Kudu.

STATUSMESSAGE{
"error": {
"code": "BadRequest",
"message": ""
}
}


1.7.1 Installer Error + Workaround

Technical details

YOURLS version: 1.7.1
PHP version: 5
MySQL 5.5.52-cll

Reproducible Bug Summary
I had a site running YOURLS v1.6 but could not install a second site running 1.7.1

Follow instruction steps, including making appropriate config.php changes; set DEBUG to true
Go to http://mydomain.co/admin and tail the error_log
Receive an error page indicating too many redirects; error log reads: Table 'databasename.options' doesn't exist SELECT option_name, option_value FROM options WHERE 1=1 in /path/...//includes/ezSQL/ez_sql_pdo.php on line 165

After a fair amount of trial and error I copied the 1.6 admin directory to my new site, and it worked.
So I don't know the specific issue in the installer, but it seems that the 1.7.1 installer was not actually building the tables, but the 1.6 installer did.

Definitely cannot reproduce, and I think if the installer was broken the issue would have been raised a couple dozens of thousands installs earlier...
"After a fair amount of trial and error" makes this report invalid, though, since we don't know what happened and what you did.
For the record, getting a notice about "databasename.options doesn't exist" during first install is completely normal and expected.


Recommendation for Go language broken

Issue Type: Bug
Seems that the the recommendation for package @id:ms-vscode.go is no longer working.
It seems that it's been changed to @id:golang.go

VS Code version: Code 1.45.1 (5763d909d5f12fe19f215cbfdd29a91c0fa9208a, 2020-05-14T08:33:47.663Z)
OS version: Darwin x64 19.5.0
Extensions (15)

Extension
Author (truncated)
Version

ng-template
Ang
0.901.9

vscode-eslint
dba
2.1.5

gitlens
eam
10.2.1

EditorConfig
Edi
0.15.1

vscode-npm-script
eg2
0.3.12

prettier-vscode
esb
5.0.0

Go
gol
0.14.4

scuri-code
gpa
1.2.1

angular-essentials
joh
9.0.1

Angular2
joh
9.1.2

vscode-peacock
joh
3.7.2

vscode-typescript-tslint-plugin
ms-
1.2.3

material-icon-theme
PKi
4.1.0

psi-header
psi
1.11.1

vscodeintellicode
Vis
1.2.8

(1 theme extensions excluded)

This should be fixed with our next release.


multiple key vault support

Describe the solution you'd like
[A clear and concise description of what you want to happen.]
The ability to specify multiple Azure Key Vaults/SecretProviderClasses for the same service in the same namespace.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
Looked into a few ways of trying to specify this. kustomize build path/to/dev/ yields valid yaml but overrides to just (1) single SecretProviderClass definition.
Environment:

Secrets Store CSI Driver version: (use the image tag): secrets-store.csi.x-k8s.io/v1
Azure Key Vault provider version: (use the image tag):
Kubernetes version: (use kubectl version): 1.26
Cluster type: (e.g. AKS, aks-engine, etc): AKS

I'd say that this is currently supported. I mean, just name them differently and mount the one by one into your workload


Issues: Readme file update

The readme file requires update to match the copyedited version.

issues resolved with pull request #28


⚠ PrivateHD has degraded performance

In d46cd28, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 6183 ms

Resolved: PrivateHD performance has improved in e223147.


Safari support

Thought it would work for multiple browsers, does it currently only work for Chrome ?
Chrome is reading the clipboard correctly, Safari returns an empty string.

It uses more than one clipboard API, so it should work for more than just Chrome, but Safari is not officially supported, as I am a Windows developer. I would welcome a pull request for support.

@CDAracena Which version of Safari was that? use-clippy does work for me in Safari (Version 13.1 ). I am having another issue where I am having a paste prompt when setClipboard is called, if I select paste then the data is copied to the clipboard.

@CharlesStover I would be interested in submitting a PR, but what are the local testing instructions?

There are shamefully no tests. This was a PoC I made for either a Reddit or Twitter user to show how to make a native browser API stateful. It ended up being pretty powerful, so I just published it as-is.
It's kind of difficult to test native browser APIs in a Node test environment, but it should be done nonetheless.
I will close this issue as you have verified that Safari works, which is what I would expect given the different clipboard APIs supported by this hook.
I'd also be willing to help your issue with your paste prompt, but please open another issue so I may tag it as support instead of a feature request.
What PR are you considering submitting (given Safari is supported)?


Scripted NPCs cause crashing

When a scripted NPC is moving (such as the one that takes you to Brock's gym), after it is done taking you, it will be forced back to its original location and cause a crash of the game. Need a way to determine how to prevent units from being touched if they are doing scripted movements (they can always be moved back after the script is done).

One option is to create a blacklist of NPCs that are never controlled by synching. This, at the very least, would prevent crashing issues until a better solution comes.

I think between wNPCMovementScriptSpriteOffset which tells which NPC the script is controlling and wd730 which, for bit 0, tells if the npc is being controlled by a script, can determine which NPCs not to touch (if wNPCMovementScriptSpriteOffset changes. Only issue is if it changes this multiple times between each frame, which would mean I would have to listen for changes on each write to wNPCMovementScriptSpriteOffset and record it for that frame.


[Question] Every end of month option supported?

I see I get no errors when using
0 0 14 L * ? *
just curious if anyone has tested?
Thank you

failed to parse int from L: strconv.Atoi: parsing "L"


Bug: not all profiles have default-routes with slug

Currently there are certain profiles that have a default permalink with their ID (original Rails Routing), e.g. https://speakerinnen.org/de/profiles/25. This is the route used in the search result.
The permalinks with slugs https://speakerinnen.org/de/profiles/firstname-lastname should be referenced by default and the routing with ID should be possible as well.
Check why this happens and fix.

Might have sth to do with this: https://github.com/rubymonsters/speakerinnen_liste/issues/531

is working now - one profile that has no slug has empty name fields


[WIP] Hl group for each line !

thanks extmarks :)
wip because we might want to disable that feature by default, it's a little bit heavy on the eyes.

@steelsojka i'm not sure i placed stuff in the right place, i've scripted that in a very small amount of time so tell me if you have refactorings suggestion.
Also should we make a command to enable/disable it or a keymap ?

@kyazdani42 I think a keybinding would be fine for disable/enable. I have no preference either way. If we can toggle it on or off then I don't think we need an enable/disable option. Just have it disabled by default and just toggle on with the keybinding.

I'm done, make your review and i'll add the docs altogether with the requested changes :)


Documentation failed to compile

I fixed the documentation replacing \subpage with \ref such that it could compile.
\subpage can only be used one for establishing a tree; \ref is used to reference a page
@oleg-alexandrov please re-arrange the tree in this PR if you don't like this configuration :)
@rsoussan reminder to put new documentation (calibration) inside a tree or else it will appear in the first page of the documentation and not under tools. If it was intended, please revert my changes

Looks good. Based on the gen html I had assumed \subpage makes links, which it does, and I verified that the links were usable, but yeah, I guess that was the wrong way of doing things.

Looks good. Based on the gen html I had assumed \subpage makes links, which it does, and I verified that the links were usable, but yeah, I guess that was the wrong way of doing things.

It's not a problem if you do \subpage the first time and \ref the others (given that you want the page to be a child of the referring page). The way it was, the doxygen would freeze and never compile because it couldn't parse the tree.


[no-object-mutation] Prevent object mutation methods

Prevent use of:
Object.defineProperties(object, props);
Object.defineProperty(object, "prop", descriptor);
Object.setPrototypeOf(object, prototype);

Should probably also prevent setting Object.prototype.valueOf.
i.e. Prevent this:
const foo = {
  valueOf: () => 42
};

Not sure if Symbol.toPrimitive should be prevent as well.


Retrieving feature values of knn query results C++ API

Hi,
I am using a k-nearest-neighbor model to find the closest neighbor for a point I am querying. What I really care about is a specific feature of the nearest neighbor. How can I retrieve that information from the model? I have the reference label from the output sframe of the query function.
I am using the C++ API. I do not have access to the source from which the KNN model is created. Is there any way to retrieve that information from the model itself?
Thanks

Hey @gitturi, if you do a join on the result of the nearest neighbor query, you can get an SFrame with the feature you want, you'll be able to retrieve that feature.  Something like
result_2 = result.join(X[["id", "feature_of_interest"]], on="id")
``
should give you what you want.

Hey @gitturi, this isn't available at the time. The original data isn't really saved in its original form with the model.  We can definitely look at this as a possible feature in the future.


The eq method is not escaping the / character

Here a snippet:
SearchStream searchStream = entityStream.of(MeetingDetailDocument.class)
if (organizingEntity != null) {
stream.filter(MeetingDetailDocument$.ORGANIZING_ENTITY.eq(organizingEntity));
}
organizing entity is a String (TAG).
if we pass"a/b" to eq method, the / is not escaped and return false, because in Redis we have "a/b" value.

@fabrizio-cannizzaro could you test on your end?

Thank you @bsbodden. In which version will you release the fix?

@fabrizio-cannizzaro sorry I'll be out on v.0.9.0-SNAPSHOT waiting to add a few more things before I push it out


Use decodeURIComponent

Use decodeURIComponent instead of current makeshift url encoding.

:tada: This issue has been resolved in version 1.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Inconsistency between partial and total cross sections?

The partial photoelectric cross sections respect the supplied binding energies, but the total mass attenuation coefficients have the last word.
In the figure below, the data correspond to lead with a)  the total mass attenuation coefficient using EADL binding energies, b) corresponds to the total photoelectric cross section using the PyMca binding energies and c) the K-shell partial photoelectric cross section using the same binding energies as in b).

The original intention is that provided total photoelectric cross sections, one could calculate the probability to excite a particular shell using the partial cross-sections.
One should provide a method to adjust a set of total photoelectric cross sections to a different set of binding energies than the ones implicitly used by it.

The problem, as described above, is seen in current development branch hypermet.
The released version does indeed respect the provided binding energies.

The used code for the examples.
import os
import numpy
import fisx
from fisx import Elements

ele = "Pb"
ene = 80.0 + numpy.arange(1000)/100.

bindings = os.path.join(os.path.dirname(fisx.__file__),
                        "fisx_data", "EADL97_BindingEnergies.dat")

e1 = Elements(os.path.dirname(bindings), bindings)
m1 = e1.getMassAttenuationCoefficients(ele, ene)

bindings = os.path.join(os.path.dirname(fisx.__file__),
                        "fisx_data", "BindingEnergies.dat")
e2 = Elements(os.path.dirname(bindings), bindings)
m2 = e2.getMassAttenuationCoefficients(ele, ene)

from PyMca5.PyMcaGui import PyMcaQt as qt
from PyMca5.PyMcaGui.pymca import ScanWindow

app = qt.QApplication([])
w = ScanWindow.ScanWindow()

w.addCurve(ene, m1["total"], "EPDL Total")
w.addCurve(ene, m2["total"], "Binding Total")
w.addCurve(ene, m2["K"], "Binding K")

w.show()
app.exec()


Hotfix schema validation

Fixes configuration injection
Fixes Schema Store request headers
Adds timeout config param to config
[patch]

Codecov Report

Merging #7 into main will decrease coverage by 0.11%.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main       #7      +/-   ##
============================================
- Coverage     98.98%   98.87%   -0.12%
+ Complexity      724      721       -3
============================================
  Files            89       88       -1
  Lines          1774     1774
  Branches        131      133       +2
============================================
- Hits           1756     1754       -2
  Misses            7        7
- Partials         11       13       +2

Impacted Files
Coverage Δ
Complexity Δ

.../yippeekijson/core/config/entities/HttpConfig.java
100.00% <ø> (ø)
9.00 <0.00> (+1.00)

...kijson/core/config/entities/SchemaStoreConfig.java
100.00% <ø> (ø)
8.00 <0.00> (ø)

...yippeekijson/core/http/impl/DefaultHttpClient.java
89.28% <50.00%> (-6.87%)
11.00 <0.00> (ø)

...ore/supplier/SchemaStoreSchemaContentSupplier.java
100.00% <100.00%> (ø)
11.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67135df...b5bbe8e. Read the comment docs.


Lockdown functionality

Implement Channel/ Guild lockdown as a mod command

Completed in commit cfe8f6dc6ec70d44165d1c65b7b51513ab029265, Possible improvement could be to not hard set functions


Two tests started failing on csp in r[33397:33409]

pkg/polymer/test/noscript_test
pkg/polymer/test/js_interop_test
See
http://build.chromium.org/p/client.dart/builders/dart2js-drt-linux-csp-be/builds/979/steps/dart2js-drt tests --csp failures/logs/stdio
Assigning to polymer, but feel free to reasign

This issue has been moved to dart-lang/polymer-dart#126.


Fix clickthrough menu bar problem

This fixes the problem described in #536. Adding a z-index prevent the event handler of kana buttons to catch the event when clicking on buttons in the menu bar.

Thanks for fixing this!


DDC interop: allow me to control which APIs are exported from a module

When I'm using DDC to compile a module for use as a JavaScript module, I want to be able to control exactly what API is exposed, just as I would be able to if I were writing JavaScript natively. I don't want to expose all Dart types and fields that are transitively used by my module.
I propose that a flag, --entrypoint-only be added to DDC. This flag causes the generated module to export only those names that are exported by the Dart library(s) passed directly to the dev compiler, without any extra prefixes. It could also cause the compiler not to emit a summary file, since this JS module won't be able to be imported by other DDC-generated modules.
For example, consider the following two files:
// test1.dart
export 'test2.dart' show bar;
final foo = "foo";

// test2.dart
final bar = "bar";
final baz = "baz";

Currently, dartdevc --modules es6 -o test1.dart.js test1.dart emits
export const test1 = Object.create(null);
export const test2 = Object.create(null);
import { core, dart, dartx } from 'dart_sdk';
test1.foo = "foo";
test2.bar = "bar";
test1.bar = test2.bar;
test2.baz = "baz";

I'd like dartdevc --modules es6 -o test1.dart.js --entrypoint-only test1.dart to emit something like:
const test1 = Object.create(null);
export default test1;
const test2 = Object.create(null);
import { core, dart, dartx } from 'dart_sdk';
test1.foo = "foo";
test2.bar = "bar";
test1.bar = test2.bar;
test2.baz = "baz";

Eventually, this could also be used to seed tree-shaking for the module in question.

this is a great idea. We absolutely need a way to expose APIs directly on the module (instead of prefixed via library). I think in ES6 it will end up as the "default export" (https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/export)

Currently I'm working around this by writing something like the following:
// # bin/sass.dart
export 'package:sass/src/executable.dart'
    if (node) 'package:sass/src/node.dart';

// #  lib/src/executable.dart
void main(List<String> args) {
  // ...
}

// # lib/src/node.dart
import 'package:js/js.dart';

import 'executable.dart' as executable;

@JS()
class _Exports {
  external set run_(function);
  // ...
}

@JS()
external _Exports get exports;

void main() {
  exports.run_ = allowInterop(executable.main);
  // ...
}

// # sass.js
var index = require('./sass.dart.js');

index.run_(process.argv.slice(2));

However, this seems to make the entire app run about 10% slower across the board than just directly compiling and running lib/src/executable.dart. That's a pretty serious perf hit for us.

However, this seems to make the entire app run about 10% slower across the board than just directly compiling and running lib/src/executable.dart. That's a pretty serious perf hit for us.

that's with dart2js?

that's with dart2js?

Yes, but it turns out to be a false alarm: it was just #28632 causing the output file to bloat on later compilations.


edit view so that author urls correctly link

Hi Lucian! I love your site! it's got so many incredible resources! I noticed that the links on the people(author) #show pages don't have a value in their href attribute so I am making a pull request for those links to have @author.siteUrl, @author.githubUrl, @author.twitterUrl populate in the appropriate places. I hope that's alright and I hope this can be merged into main

Thank you @whatnotery, for this contribution and for noticing the problem with missing authors URLs in the Author pages.


Refactor Text Edit menu context actions

Use UIEditMenuInteraction for iOS 16+ for context menus in text fields.
Fix crash when using UIMenuController for iOS 12.
Solution
Move all Edit Menu code to Objc lib to:

hide UIEditMenuInteraction from KMM to prevent crash on launch
keep simple and convenient interface for Edit Menu

Is there no equivalent to @available that can be used in Kotlin code?


[LIVE-1167] Type libraries implementation in ledger-live-common

📝 Description
Gaetan started the work by creating those 3 type libraries:

@ledgerhq/types-live
@ledgerhq/types-cryptoassets
@ledgerhq/types-devices

The goal of this PR is to update them (it evolved in 6 months !) and use them in ledger-live-common, CLI, LLD, and LLM.
Kind of out of scope of the PR but done anyway :

Removal of balanceHistory attribute (portfolio v1 related)

❓ Context

Impacted projects: ledger-live-desktop, ledger-live-mobile, cli
Linked resource(s): https://ledgerhq.atlassian.net/browse/LIVE-1167

✅ Checklist

[ ] Test coverage
[ ] Atomic delivery :grimacing:
[ ] No breaking changes

📸 Demo

🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.

CI issues to continue fixing. doc to regenerate too.


configure deployment.

cf. https://github.com/2011-fakebook-project3/notifications/pull/33, https://github.com/2011-fakebook-project3/profile/pull/20, and especially https://github.com/2011-fakebook-project3/ng/pull/37
routes /api/posts and /api/comments are currently sent to this api per the ng deployment PR.
there is a dockerfile for the database. it will look for migrations and generate a script to apply them. that script will run when the container starts. this includes any seed data configured using HasData in the context. this removes the need to do things like Database.EnsureCreated(). the context here is not configured in the Startup class yet, so that docker build fails, and is marked as allowed to fail in the pipeline; this should be changed when it is ready.

@nodeJayS wrong assumption, i wasn't ready to merge this yet. it's not a big deal though

@nodeJayS wrong assumption, i wasn't ready to merge this yet. it's not a big deal though


How to install torchdrug in conda without updating too many dependencies?

Hi,
I've installed torchdrug via conda. The installation updates already installed pytorch and pytorch_scatter. I don't know the backside of torchdrug yet, but it seems like to me maybe install (or update) too many the packages. Wouldn't it be safer, if some of the dependencies are already installed, for such dependencies not to update while installing torchdrug?

Hi! I think this is a general question to conda install and not specific to torchdrug.
As far as I know, you can use conda install -c conda-forge -c milagraph torchdrug --freeze-installed to prevent updating existing libraries as many as possible.


Function evaluation

And-ing patterns: I hope that Data.Kore.ASTUtils.SmartConstructors would make this easier after #137 gets submitted.


{Core} Add a hint message for --query error by an invalid JMESPATH

Description

This PR provides support for printing a hint message below when a [--query JMESPATH] value error occurs.
To learn more about [--query JMESPATH] usage in AzureCLI, visit https://aka.ms/CLIQuery

As a manual hint, the message will be printed behind the command usage and before the ai-did-you-mean-this recommendations (if there).

Testing Guide

Any commands with the [--query] argument that can raise an error by an invalid JMESPATH

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

--query error

Please update the PR description to include a real-life example.

Please update the PR description to include a real-life example.

update the PR description.

Update the function parameters to not use kwargs at current time. Investigate #13764, here the error in this PR is raised by Knack and will be caught by the argparse, will not be caught by the exception handler in #13764.


pombase slim changes

add BP
lipoprotein biosynthetic process (GO:0042158)
remove disease
obsolete monogenic disease (obsolete MONDO:0000275) | MONDO:0000275 | 0

I've changed the config and I'll check the result in the morning.

The changes worked.


Cannot search from FindInput

Hi, your description implies that your extension will search text in the FindInput if that has focus, however I find it always searches only the selected text in the editor (via keyboard shortcut).
Fantastic extension btw, thank you for building it.

Thank you for the report! You're right, that's indeed the case. If you could create a pull request to fix it, that would be much appreciated.


Cannot read property 'length' of undefined

When parsing an image node the length assignment breaks.
This is how the node looks like:
{
    alt: "img description"
    position: Position {start: {…}, end: {…}, indent: Array(0)}
    title: null
    type: "image"
    url: "/img/…"
}

And it breaks here:
children = 'length' in node ? node : node.children
length = children.length

As children is undefined.
A posible solution could be just add an if validation for the undefined children and return an empty array. Don't know if it's the appropriate thing to do.
children = 'length' in node ? node : node.children
if(!children) return ''
length = children.length

image isn"t a nlcst node type. https://github.com/syntax-tree/nlcst
Could you provide sample code/config/content?

@NormanPerrin Hi there, thanks for the question and welcome to unified!
What you are passing is an mdast node, not as Christian points out an nlcst node.
As we’re dealing with mdast, you can fix this issue by using mdast-util-to-string.


[Bug]: Cannot Hit Evolved Creeper Boss

Forge Version
<IP_ADDRESS>60
Galacticraft Version
dev
Log or Crash Report
fml-client-latest.log
Reproduction steps

spawn the entity Evolved Creeper Boss
see that you can't hit it + the entity cant attack you

Its intended , you can only hit the bos (by click on these own projectiles) while targetting the player like a Ghast(but you can hit a ghast with another things)


Standardize virtual env creation Python Functions

Python 3.7 should be supported soon and we might not want to create a virtual environment any more. See: https://github.com/Azure/azure-functions-core-tools/issues/923

With https://github.com/Azure/azure-functions-core-tools/issues/1023 closed and released, there shouldn't be any need to create a virtual environment anymore. :)


Add keyword advanced filter for Search

Details

Fixed Issues

$https://github.com/Expensify/App/issues/46027
PROPOSAL:
Tests

visit root /search/filters

test keyword filter and whether navigation behaves correctly

[x] Verify that no errors appear in the JS console

Offline tests

QA Steps

Same steps as Tests

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/3ad5c154-214d-4102-b772-ebb63e494920

Android: mWeb Chrome

https://github.com/user-attachments/assets/cc239692-a015-4d33-bd17-7ec01223f572

iOS: Native

https://github.com/user-attachments/assets/2d98295b-6022-46b7-87c3-d38c85e73d55

iOS: mWeb Safari

https://github.com/user-attachments/assets/8776e7f2-509a-44cf-b04e-32d201ac55c6

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/8c130508-bdb9-434c-80c4-ea1b76b051fa

MacOS: Desktop

https://github.com/user-attachments/assets/2ee7e74f-9c0d-40f4-ad62-b6e4e1244509

@luacmartins ready for review!

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[ ] I verified that all the inputs inside a form are aligned with each other.
[ ] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

[!note]

The implementation only works as expected with 1 keyword, if we add 2 or more -> we get infinite loading.

⚠ I completed the ✅ PR Reviewer Checklist, but I found one main issue with the functionality which manifests in 3 different ways which I see as possible blockers for this PR:
Note: The main issue has to do with using more than 1 keyword with different separators in between (comma, space).

[ ] 1. Filters label issues and infinite loading when using comma separated keywords
Notes:

This happens on all platforms.
Notice the Filters labels and how there are 2 issues there:

each keyword appears separately as its own keyword
the , (comma) is seen as a separate keyword
.

Videos / Screenshots
https://github.com/user-attachments/assets/018aa00e-524f-48e7-b709-23b70d59a8bb

MacOS: Web

[ ] 2. Page not found when using semicolon separated keywords
Notes:

This happens on all platforms.
.

Video
https://github.com/user-attachments/assets/8a47960f-b35b-4613-bea2-5905334263ee

[ ] 3. Infinite loading when using 2 or more space separated keywords
Note: This happens on all platforms.

Video
https://github.com/user-attachments/assets/ca4b00bd-9c8f-4fe5-af3a-e930d5dc13f9

[!important]

I noticed the Filters category Capitalizing the keywords - I reported the issue before in #46477 (comment) which was resolved by @luacmartins in #46477 (comment) as "will be fixed in a follow-up PR". Just wanted to mention this again!
I think the infinite loading issues might be addressed in PR #46804 as I've reported them before in #46566 (comment) and the issue was addressed in #46566 (comment).

ℹ Note: I think it would be useful from a UI / UX POV to have a subtitle on the keyword input that mentions a certain separator can be used i case the user wants to have multiple keywords (cc @Expensify/design) and possible look at ways to make sure other separators / symbols won't show page not found or infinite loading when used.

@Kicu Please let me know if these are within the scope of this PR and if they should be addressed before moving forward. There are some conflicts as well. Once all of these are addressed, I will be able to 🟢 Approve.

Would love a video/screenshot to see how this looks with some weird string examples like:

multiple words
symbols characters
emoji

@dubielzyk-expensify 👋 I dropped 3 videos in the https://github.com/Expensify/App/pull/46799#issuecomment-2270045899 above, are you now able to see them ?
They are related to the following scenarios:

using comma separator
using semicolon separator
using space separator

Didn't try emojis yet.

FYI the keyword filter is not yet supported in the backend and is throwing this error. I'm working on a PR to fix that.

with the newest main merged (good job @289Adam289) we should no longer be seeing multiple keyword:xxx keyword:yyy within the results page query that we display to the user - this was a bug that is solved. For every multivalue filter we want to see category:XXX,YYY keyword:1,2,3 etc.

That being said...
I believe it is worth for someone from Expensify team to describe exactly what should happen in these cases:

user types several words separated with space into keyword (ex Las Vegas bill)
user types several words separated with comma into keyword (ex Las,Vegas,bill)
user types words with mix of spaces and commas

For each of these what should be the final value of keyword filter that is being sent to backend? @luacmartins

PR to handle keyword filter in review

I think for now, we should treat space and commas as separators and do an OR search on each word, i.e.:

user types several words separated with space into keyword input (ex Las Vegas bill)

would search for Las OR Vegas OR bill

user types several words separated with comma into keyword input (ex Las,Vegas,bill)

would search for Las OR Vegas OR bill

user types words with mix of spaces and commas  Las, Vegas, casino bill

would search for Las OR Vegas OR casino OR bill
The keyword filter is one that we'll have to refine over time, e.g. drop common words like a, of, etc, fix typos, synonyms, etc but the behavior above should be a good starting point. cc @JmillsExpensify @trjExpensify for thoughts

From @ikevin127 's third example, when the user types in CAR RON TESLA:

The filter title spits it out as three separate keywords:

Why is that? Even if we are searching three separate words, it feels weird to the user that the string got chopped up. Can we just use keywords:CAR RON TESLA in the title?

Can we just use keywords:CAR RON TESLA in the title?

✅ That was fixed after another PR was recently merged and is now fixed on this one as well after sync w/ main:

In summary, to callback to the issues found (https://github.com/Expensify/App/pull/46799#issuecomment-2270045899), what's needed here in order to move forward with Approval and merge:

From #46799 (comment) -> we're looking at deciding what's the best way to go for the first iteration of this (to be improved in future follow-ups) and based on decision, changes will be pushed to this PR.
Regarding the infinite loading, NAB I think for now (?!) as Carlos mentioned that the keyword search is not yet supported in BE so it's expected to get the infinite loading when using more than 1 keyword ? @luacmartins
Which leaves the issue number (2.) Page not found when using semicolon separated keywords to be addressed.

Hmm I still think, as a user, I would expect to see keywords:CAR RON TESLA and not keyword:CAR,RON,TESLA

Agree with you Shawn. Cause it's be weird if you add comma in your string, then see double commas.

I agree. I think we need to change the grammar to combine all filters with the same key.

@ikevin127 2. Page not found using semicolon problem comes up in multiple filters. After discussing it with team and @luacmartins we agreed to handle it as a follow up. Carlos have you had a chance to create a issue for that? If not would you mind? Thanks!

Why is that? Even if we are searching three separate words, it feels weird to the user that the string got chopped up. Can we just use keywords:CAR RON TESLA in the title?

I agree with Shawn here. 👍

@ikevin127 2. Page not found using semicolon problem comes up in multiple filters. After discussing it with team and @luacmartins we agreed to handle it as a follow up. Carlos have you had a chance to create a issue for that? If not would you mind? Thanks!

@289Adam289 created issue here

@289Adam289 it seems like we still need to address some comments on how we display the filters to the user.

Much better!

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Created issue to update parser grammar here

FYI I believe this was deployed to prod yesterday, from this checklist - https://github.com/Expensify/App/issues/47219


[COM-31] Allow changing of the workspace URL

Is this issue related to an issue?.
Currently, when you create a workspace, System Initiative believes that the URL of the workspace is localhost:8080. This isn't always the case as you could be running System Initiative on a server that others within your org are using to try it
Describe the outcome you'd like from us
Have a way to be able to change the URL associated with a workspace - this would then potentially allow the auth portal to not always be checking that localhost:8080 was alive before reporting that a workspace was healthy
Describe alternatives you've considered
We updated the record in the database for my user workspace to have the new URL and the auth portal immediately updated so we know this works as expected when we can give it the correct URL
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Additional context
I was able to run System Initiative on an ec2 instance by binding the web containers to <IP_ADDRESS> and access the web UI via the public IP of the AWS instance. This allowed me to get to the auth portal but the auth portal never allowed me to get back to the ec2 instance IP as it was hard coded to localhost:8080
COM-31

Should be able to get to it this week :) Open to collaborating if you are so inclined.

This is now out there and working as expected


Add prometheus, open-telemetry, zabbix as labels

[ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
[ ] Update the CHANGES log.

We are ready for the metrics from these 3 ecosystems now.

@kezhenxu94 This seems not running in skip mode. All CIs are really running.

@kezhenxu94 This seems not running in skip mode. All CIs are really running.

Well. I missed .asf.yaml, it was not considered in skip action

asf.yaml

I added in this PR.

Only working after merge?

Only working after merge?

Because you also modify action.yaml , which should not be skipped.


Added Pencil Cursor for Canvas on Sketch page

Fixes #915
Made the cursor a pencil (in the form of inline svg) for the canvas on the sketch page and made crosshair the fallback cursor

Reduce the size of the pencil by 50% please

Reduced the cursor size from 48x48px to 24x24px


Full scan algorithm

Added implementation of FullScanAlgorithm and test.
Added tests for 3- and 1-tuple inequalities to splitter_test.go
@dumbunny note that I didn't bother optimizing the parenthesis-placement further. So for the scalar case (tuples with only one element), splitquery will return select * from t where (:start <= id) and (:end <= id).
I felt like it's not worth the extra complexity introduced into the code.
Let me know if you object.

@dumbuny can you take a look ? Thanks!

Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

@dumbunny PTAL. Thanks!

Review status: 0 of 9 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from the review on Reviewable.io

LGTM


[docs] NextJS installation docs need some adjustments

Summary
Firstly, thanks for building the appkit.
Note: I'm more than happy to send a PR for these documentation updates if someone can point me to the repo for the docs.

In the first wagmi config section http isn't used and can be removed

In the ContextProvider section modal isn't used. It can be
createAppKit({

instead of
const modal = createAppKit({

It's the same in the react docs

Lastly, I would add a section about supporting custom chains to all of the docs. viem supports a lot of chains. Reown only supports a dozen or so out of the box. I was under the impression that other chains wouldn't work until I saw [feature] How to support the BLAST network?
Link to the related docs page
https://docs.reown.com/appkit/next/core/installation

next.js modal variable fixed here-> https://github.com/reown-com/reown-docs/pull/77/files
custom chain will be soon online ... we are doing some changes in how we are going to use chains.
Thanks


[Request] PHP7.2 rather than PHP7.0

Currently unable to create a stack with PHP 7.2 installed and the default version.
I have to manually upgrade to 7.2 after stack creation is complete.

Edited web.yaml and mastervpc.yaml parameters

Hi,
How have you been able to do that? I'm trying to do the same, but the installation fails every time as the autoscalinggroups receive FAILURE signal.
I've added the following part after the WebLauncConfiguration72, and added the necessary parameters (and condition) to activate that:
  WebLaunchConfiguration72:
    Condition: PHP72
    Type: AWS::AutoScaling::LaunchConfiguration
    Metadata:
      AWS::CloudFormation::Init:
        configSets:
          deploy_webserver:
            - install_webserver
            - build_cacheclient
            - build_wordpress
            - build_opcache
            - download_aws_ini
            - install_aws_ini
            - install_cacheclient
            - install_wordpress
            - install_opcache
            - start_webserver
        install_webserver:
          packages:
            yum:
              awslogs: []
              httpd24: []
              mysql56: []
              php72: []
              php72-mysqlnd: []
          files:
            /tmp/create_site_conf.sh:
              content:
                !Join [
                  "",[
                    "#!/bin/bash -xe\n",
                    "if [ ! -f /etc/httpd/conf.d/", !Ref WPDirectory, ".conf ]; then\n",
                    "   touch /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "   echo 'ServerName <IP_ADDRESS>:80' >> /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "   echo 'DocumentRoot /var/www/wordpress/", !Ref WPDirectory, "' >> /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "   echo '<Directory /var/www/wordpress/", !Ref WPDirectory, ">' >> /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "   echo '  Options Indexes FollowSymLinks' >> /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "   echo '  AllowOverride All' >> /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "   echo '  Require all granted' >> /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "   echo '</Directory>' >> /etc/httpd/conf.d/", !Ref WPDirectory, ".conf\n",
                    "fi\n"
                  ]
                ]
              mode: 000500
              owner: root
              group: root
          commands:
            create_site_conf:
              command: ./create_site_conf.sh
              cwd: /tmp
              ignoreErrors: false
        build_cacheclient:
          packages:
            yum:
              gcc-c++: []
          files:
            /tmp/install_cacheclient.sh:
              content:
                !Sub |
                  #!/bin/bash -xe
                  wget -P /tmp/ https://github.com/awslabs/aws-elasticache-cluster-client-memcached-for-php/files/1993851/AmazonElasticacheClusterClient-PHP72-64bit-libmemcached-1.0.8.tar.gz
                  tar -xf '/tmp/AmazonElasticacheClusterClient-PHP72-64bit-libmemcached-1.0.8.tar.gz
                  cp '/tmp/amazon-elasticache-cluster-client.so' /usr/lib64/php/7.2/modules/
                  if [ ! -f /etc/php-7.2.d/50-memcached.ini ]; then
                      touch /etc/php-7.2.d/50-memcached.ini
                  fi
                  sed -i '3i extension=/usr/lib64/php/7.2/modules/amazon-elasticache-cluster-client.so;' /etc/php-7.2.d/50-memcached.ini
                  sed -i '3i extension=igbinary.so;' /etc/php-7.2.d/50-memcached.ini
              mode: 000500
              owner: root
              group: root
        build_opcache:
          packages:
            yum:
              php72-opcache: []
          files:
            /tmp/install_opcache.sh:
              content:
                !Sub |
                  #!/bin/bash -xe
                  # create hidden opcache directory locally & change owner to apache
                  if [ ! -d /var/www/.opcache ]; then
                      mkdir -p /var/www/.opcache
                  fi
                  # enable opcache in /etc/php-7.0.d/10-opcache.ini
                  sed -i 's/;opcache.file_cache=.*/opcache.file_cache=\/var\/www\/.opcache/' /etc/php-7.2.d/10-opcache.ini
                  sed -i 's/opcache.memory_consumption=.*/opcache.memory_consumption=512/' /etc/php-7.2.d/10-opcache.ini
                  download opcache-instance.php to verify opcache status
                  if [ ! -f /var/www/wordpress/${WPDirectory}/opcache-instanceid.php ]; then
                      wget -P /var/www/wordpress/${WPDirectory}/ https://s3.amazonaws.com/aws-refarch/wordpress/latest/bits/opcache-instanceid.php
                  fi
              mode: 000500
              owner: root
              group: root
        build_wordpress:
          files:
            /tmp/install_wordpress.sh:
              content:
                !Join [
                  "",[
                    "#!/bin/bash -xe\n",
                    "\n",
                    "# install wp-cli\n",
                    "if [ ! -f /bin/wp/wp-cli.phar ]; then\n",
                    "   curl -o /bin/wp https://raw.githubusercontent.com/wp-cli/builds/gh-pages/phar/wp-cli.phar\n",
                    "   chmod +x /bin/wp\n",
                    "fi\n",
                    "\n",
                    "# make site directory\n",
                    "if [ ! -d /var/www/wordpress/", !Ref WPDirectory, " ]; then\n",
                    "   mkdir -p /var/www/wordpress/", !Ref WPDirectory, "\n",
                    "\n",
                    "   cd /var/www/wordpress/", !Ref WPDirectory, "\n",
                    "   # install wordpress if not installed\n",
                    "   # use public alb host name if wp domain name was empty\n",
                    "   if ! $(wp core is-installed --allow-root); then\n",
                    "       wp core download --version='", !Ref WPVersion, "' --locale='", !Ref WPLocale, "' --allow-root\n",
                    "       wp core config --dbname='", !Ref DatabaseName, "' --dbuser='", !Ref DatabaseMasterUsername, "' --dbpass='", !Ref DatabaseMasterPassword, "' --dbhost='", !Ref DatabaseClusterEndpointAddress, "' --dbprefix=wp_ --allow-root\n",
                    "       wp core install --url=", !If [ NoWPDomainName, !Ref PublicAlbHostname, !Join [ "", [ "'http://www.", !Ref WPDomainName, "'" ] ] ], " --title='", !Ref WPTitle, "' --admin_user='", !Ref WPAdminUsername, "' --admin_password='", !Ref WPAdminPassword, "' --admin_email='", !Ref WPAdminEmail, "' --skip-email --allow-root\n",
                    "       sed -i \"/$table_prefix = 'wp_';/ a \\define('WP_HOME', 'http://' . \\$_SERVER['HTTP_HOST']); \" /var/www/wordpress/", !Ref WPDirectory, "/wp-config.php\n",
                    "       sed -i \"/$table_prefix = 'wp_';/ a \\define('WP_SITEURL', 'http://' . \\$_SERVER['HTTP_HOST']); \" /var/www/wordpress/", !Ref WPDirectory, "/wp-config.php\n",
                    "       # enable HTTPS in wp-config.php if ACM Public SSL Certificate parameter was not empty\n",
                            !If [ NoSslCertificate, !Join [ '', [ "       sed -i \"/$table_prefix = 'wp_';/ a \\# No ACM Public SSL Certificate \" /var/www/wordpress/", !Ref WPDirectory, "/wp-config.php\n" ] ] , !Join [ '', [ "       sed -i \"/$table_prefix = 'wp_';/ a \\$_SERVER['HTTPS'] = 'on';\" /var/www/wordpress/", !Ref WPDirectory, "/wp-config.php\n" ] ] ],
                    "\n",
                    "       # set permissions of wordpress site directories\n",
                    "       chown -R apache:apache /var/www/wordpress/", !Ref WPDirectory, "\n",
                    "       chmod u+wrx /var/www/wordpress/", !Ref WPDirectory, "/wp-content/*\n",
                    "       if [ ! -f /var/www/wordpress/", !Ref WPDirectory, "/opcache-instanceid.php ]; then\n",
                    "         wget -P /var/www/wordpress/", !Ref WPDirectory, "/ https://s3.amazonaws.com/aws-refarch/wordpress/latest/bits/opcache-instanceid.php\n",
                    "       fi\n",
                    "   fi\n",
                    "   RESULT=$?\n",
                    "   if [ $RESULT -eq 0 ]; then\n",
                    "       touch /var/www/wordpress/", !Ref WPDirectory, "/wordpress.initialized\n",
                    "         else\n",
                    "       touch /var/www/wordpress/", !Ref WPDirectory, "/wordpress.failed\n",
                    "   fi\n",
                    "fi\n"
                  ]
                ]
              mode: 000500
              owner: root
              group: root
        download_aws_ini:
          files:
            /tmp/download_aws_ini.sh:
              content:
                !Join [
                  "",[
                    "#!/bin/bash -x\n",
                    "\n",
                    "wget -P /etc/php-7.2.d/ ", !Ref PHPIniOverride, "\n"
                  ]
                ]
              mode: 000500
              owner: root
              group: root
        install_aws_ini:
          commands:
            install_aws_ini:
              command: ./download_aws_ini.sh
              cwd: /tmp
              ignoreErrors: true
        install_wordpress:
          commands:
            install_wordpress:
              command: ./install_wordpress.sh
              cwd: /tmp
              ignoreErrors: false
        install_cacheclient:
          commands:
            install_cacheclient:
              command: ./install_cacheclient.sh
              cwd: /tmp
              ignoreErrors: false
        install_opcache:
          commands:
            install_opcache:
              command: ./install_opcache.sh
              cwd: /tmp
              ignoreErrors: false
        start_webserver:
          services:
            sysvinit:
              httpd:
                enabled: true
                ensureRunning: true
    Properties:
      IamInstanceProfile: !Ref WebInstanceProfile
      ImageId: !FindInMap [ RegionMap, !Ref 'AWS::Region', AMI ]
      InstanceMonitoring: true
      InstanceType: !Ref WebInstanceType
      KeyName: !Ref EC2KeyName
      SecurityGroups:
      - !Ref WebSecurityGroup
      UserData:
        "Fn::Base64":
          !Sub |
            #!/bin/bash -xe
            yum update -y
            mkdir -p /var/www/wordpress
            mount -t nfs4 -o nfsvers=4.1,rsize=1048576,wsize=1048576,hard,timeo=600,retrans=2 ${ElasticFileSystem}.efs.${AWS::Region}.amazonaws.com:/ /var/www/wordpress
            /opt/aws/bin/cfn-init --configsets deploy_webserver --verbose --stack ${AWS::StackName} --resource WebLaunchConfiguration72 --region ${AWS::Region}
            /opt/aws/bin/cfn-signal --exit-code $? --stack ${AWS::StackName} --resource WebAutoScalingGroup --region ${AWS::Region}

@Nipazz did you edit the  PHPVersion in the parameters section of the master-newvpc.yaml template?
Also within the master-vpc.yaml template you have to make sure the TemplateURL for the web.yaml template is pointing to your S3 bucket because it will fail if its pointed to the AWS bucket due to their template not containing PHPversion 7.2.

Yeah, I've edited the Master to point to the correct template and I've also added the parameter to both templates. I think I've missed something, so if you could share your working templates that would be great :)

I was missing an apostrophe. I've updated my previous message, so if anyone want to install the website with PHP7.2 you can use that as a reference.
In the future, "ignoreErrors: true" helps a lot at debugging!