New package: Torch_jll v1.4.0+0

Autogenerated JLL package registration

Registering JLL package Torch_jll.jl
Repository: https://github.com/JuliaBinaryWrappers/Torch_jll.jl
Version: v1.4.0+0

It's known this will fail to load for the time being.


Expose writable()

Right now, tokio-seqpacket exposes send(), but not writable(). This causes issues for applications that want to do low-level sending using the file descriptor (e.g. with https://docs.rs/nix/latest/nix/sys/socket/fn.sendmsg.html) with APIs that aren't async. In particular, the only way to replicate UdpSocket::writable that I can think of is to busy loop, which defeats the point of an async API.

Happy to work on this myself :) if I don't have it done today I should have it working tomorrow.

Hey! I see your point. Correct use of readable() and writable() is a bit tricky, but that's no reason not to allow it.
But maybe we could just add as_async_fd() and return a &tokio::AsyncFd. Then whatever tokio decides to add to it later is automatically available.

Oh wow, I didn't know about AsyncFd! That looks perfect, thanks so much :) I'll make a PR for that today.


'next' (vue 3) version misses fixes from v2

Reproduction Link
eg v2 includes id in events:
https://github.com/shentao/vue-multiselect/blob/731be35ca4172995d85524f18cbb5441e57734e4/src/multiselectMixin.js#L397
vs
https://github.com/shentao/vue-multiselect/blob/5ed71c107e3d9477e8d5a30c5b6556d228492eac/src/multiselectMixin.js#L389
Steps to reproduce
Expected behaviour
Actual behaviour

Curious if anyone has merged in the changes from vue2 yet?    I am running into an odd issue that is only affecting one of many deployments and I am running the alpha.2 release and wondering if there will be another release

A new version with the latest patches from V2 has just been published on the next release


New 'send(byte[] data)', getBufferedAmount, getReadyState and more

This pull request covers different things, and it's easier to look at the list of commits to get what I'm doing.
Also, I added rules to .gitingore to avoid having the "dist", "build" and "doc" directory in the repo: whoever clones it can just run ant and generate it on the spot. No need to take space here.

@TooTallNate There you go. I got rid of the doc and dist directory too: leaving the files there would have made little sense, given that would mistmatch the new code.

Hahahaha, I meant revert your commits changing them (i.e. git revert), not deleting them entirely. The diff is just as noisy as-is :p

I got that, but this means we would maintain the doc that is currently there.
I took the opportunity to get rid of it completely: maintaining a directory with outdated doc would be even more pointless than having the doc in the repository in the first place. No?

@detro We would recompile the docs and jar afterwards, or you could even do that in a separate pull request afterwards. The point was to have a minimal diff for this pull request.

Isn't a pull request a collection of commits? The minimal diff are the commits.

Ivan De Marino
Coder, Technologist, Cook, Italian
Sent on the move
On 24 Feb 2012, at 18:26, Nathan Rajlich
<EMAIL_ADDRESS>wrote:

@detro We would recompile the docs and jar afterwards, or you could even do that in a separate pull request afterwards. The point was to have a minimal diff for this pull request.

Reply to this email directly or view it on GitHub:
https://github.com/TooTallNate/Java-WebSocket/pull/72#issuecomment-4162221

Sorry, yesterday I was on the move so my answer was short.
But the essence is the same: this is not a big pull request at all! Ignore the anwything in "doc/" and focus on the 4(!) .java files and the build.xml. I didn't make any major modification to this.
I really like this project (minimal and focused): I don't want to keep a personal fork of this that will only be a reflection of my personal tuning.
If you still feel like we need to have dist/ and doc/, you (or I) can always generate a new one and recommit. My aim was to save github free quota too: it's a waste if the user can just clone and launch ant!

@detro thank you very much for your efforts and goodwill!
Unfortunately this pull request is unmergable... viewing the diff causes my browser to hang!!
Imagine how a this delete would let the repository size explode, if we put the updated files in place afterwards...
While figuring out how to deal with all those contradictions i could have committed them by myself.
For the future i suggest that you leave the maintenances to repo owner.
However a clear improvements or new features like #29 are obviously more than welcome.
Furthermore i hope that you keep your opinion about this project so that we can benefit from your relevant source code modifications.
Feel free to visit the irc channel linked in the readme for further discussion or clarification.

@Davidiusdadi I don't think we should re-commit stuff afterwards: removing /doc/ and /dist/ from the repo is a good thing. Having the build.xml to generate was a great move you guys made from the start.
I don't see a contradiction here: after this, the amount of files is smaller. Hence, easier for anyone to get their head around it. Yes, the removed stuff will be part of the history, bit so is now: nothing major will change. Plus is plain text and Git GC does a good compression job.
Discussing about "maintenance for the repo owner" when the project is so young and small seems a bit "excessive" to me. I don't want to "step on anyone toes", but it's not like I made a major change to the code, driving the project in a different direction.
I really have no clue what you mean about beautifications in CodeFormatterProfile.xml: I might have missed a couple of spaces here and there, but I generally followed the way the rest of the code was done. Small "hiccups" are easy to fix. If you have a specific code guideline that would like people to follow, I suggest you document it in a wiki page or a readme file.
But again, for a project of this size? Sounds like an overkill.
I must admit, I feel a bit "pushed back" here: this is a small project and you guys seem to be making a big deal out of this. And all I'm doing at the moment is try to help making it as conforming as possible to the W3C specs (yet, maintaining a java-ish style).
I'll keep putting my work on my own fork for now.
If you want to join forces, let me know.

Looking at the commits i see either minor beautifications or arguably deletions.
It should not be a problem to delete latter just in your working copy. Further discussions about that should take place in a separate issue.

Discussing about "maintenance for the repo owner" when the project is so young and small seems a bit "excessive" to me.

Since i am not a native english speaker i hope that you excuse my "excessive" manner of expression.
"specific code guideline" for such a project might be overkill...i agree with that but
on the other hand what else that "hiccups" did you fix?

I must admit, I feel a bit "pushed back" here: this is a small project and you guys seem to be making a big deal out of this.

The big deal about this small project is absolute W3C compatibility, good usability and performance.
And we will only achieve that by putting a lot of effort into it.
We got quite far yet but we are not done.
There is a lot to document, there is ssl support to come, there is room for performance improvements... .

And all I'm doing at the moment is try to help making it as conforming as possible to the W3C specs (yet, maintaining a java-ish style).

If you find any issues regarding W3C conformance let us know, or fix them yourself.
That would be a reason to join forces.
Also i wont merge this pull request i will probably take over the send* methods you added/overwrote after taking a closer look at tham.
I wish you good luck for your work and am looking forward to join forces in the future.

If you ask me, what should have happened here was:

merge the pull request
fix what you think I didn't do right (so that next time I could be better and more conforming to your guidelines)

Just a note: I'm pretty sure you guys are doing a great deal of work to be conforming to the W3C specs - indeed this is THE ONLY implementation I could find, able to deal with different WebSockets protocol implementation (KUDOS for that!).
What I added in terms of functionality was merely:

send(bytes)
readyState
bufferedAmount

and fixed some var name that made javadoc complain.
Everything else was decorative or less.
Ivan

puh That took some doing so far.
I for myself never had to use fetching and cherry picking in the past (guess why).
But i wanted to take a closer look at that anyway.
i will borrow @Subito's git book :)
Certainly i wont have time to do anything before next Friday though.
@detro You could comply with this pull request by mastering the black art of cherry picking and  whatever else is needed yourself.
No pressure :)


Issues with the withCallState addon

Hey there!
After playing around with the withCallState addon to the SignalStore, I've wound up in a situation where I wanted the call state for multiple subslices of my state. I've found out that in order to set loading, error or loaded, I'd have to use the callback implementation of the patchState, as patching directly would throw errors that "NamedCallStateSlice<'myState'> | CallStateSlice" would not be assignable to the updater (defined as Array<Partial<State & {}> | PartialStateUpdater<State & {}>>). By converting to callback updater, I was able make it work like this:
patchState(store, (state) => ({ ...state, ...setLoading(state) }))

I think that this DX is pretty cumbersome to see in code, hence why I suggest improving it. Perhaps further investigating the mismatch between the result of setLoading and others, or making a factory that exports these functions and the call state with the name in them already. These are just some high level things, I haven't really looked very deeply into what's causing that mismatch, seeing that the unnamed call state doesn't have any issues.
Best regards!

Hi Antim, thanks for letting us know. You know how it is with Open Source projects ;) if you could contribute and improve the current state, that would be great and speed up things.
Maybe you want to connect with @andersfgraneng. He has opened https://github.com/angular-architects/ngrx-toolkit/pull/16

I think we encountered the same issue. I think the PR mentioned by rainerhahnekamp will solve it. You should then be able to use patchState(store, setLoading('myState')) without typescript complaining. Its because the function return type is as you mentioned: NamedCallStateSlice<'myState'> | CallStateSlice, which can be narrowed down based on the parameter. If you coincidentally use withCallState() and withCallState(myState`) when defining your store typescript wont complain, since then your store satisfies the return types. You could try to pull the changes and see if it solves your issue?

I think we encountered the same issue. I think the PR mentioned by rainerhahnekamp will solve it. You should then be able to use patchState(store, setLoading('myState')) without typescript complaining. Its because the function return type is as you mentioned: NamedCallStateSlice<'myState'> | CallStateSlice, which can be narrowed down based on the parameter. If you coincidentally use withCallState() and withCallState('myState') when defining your store typescript wont complain, since then your store satisfies the return types. You could try to pull the changes and see if it solves your issue?

Hi Anders, pulled it and gave it a try. Everything seems to work fine now. Great work :)

This issue has been fixed thanks to @andersfgraneng and is available in version 0.0.7.
@antimprisacaru I've added some basic tests, but if you have some other tests to add, that would be great.


Added Docker build env.

Issue: #38
Окружение для сборки проекта из исходников.
Собранные библиотеки для Lua 5.3 Quik 8.5+ 64bit находятся в каталоге built/

Pull Request Test Coverage Report for Build 114

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.81%

Totals

Change from base Build 107:
0.0%

Covered Lines:
138

Relevant Lines:
315

💛  - Coveralls


Auto logout if account is nonexistent

Description

If the account referenced in cookie is nonexistent, auto redirect the user to log out

Checklist

[ ] Created tests which fail without the change (if possible)
[ ] Extended the README / documentation, if necessary

Issue(s)

LGTM! have you tested it? It seems like it would work right.

Tested it locally. That's how I realized I can't redirect on logout page.


MX without A records

I write a plugin to forward some email  to another email according database.
the code simplest like the following:
exports.hook_rcpt = function (next, connection, params) {
var rcpt = params[0];

    if (rcpt.host == "xxx.com") {
        it.logwarn("====skdlf");
        var address = // get address from database according rcpt.user
        var toAddress = new Address('<' + address + '>');
    connection.transaction.rcpt_to.pop();
    connection.transaction.rcpt_to.push(toAddress);
    connection.relaying = true
    next(OK);
    return;
    }
   next(DENYSOFT, "not found user account");
}

but, it seem the server never run into any code in the above.
and i get the following error :
[INFO] [38A98778-D1E0-4064-AF11-0A54720063A8] [access] pass:unlisted(conn)
[INFO] [38A98778-D1E0-4064-AF11-0A54720063A8] [access] pass:unlisted(conn), connect:any
[ERROR] [38A98778-D1E0-4064-AF11-0A54720063A8] [dnsbl] no zones
[INFO] [38A98778-D1E0-4064-AF11-0A54720063A8] [access] pass:unlisted(conn), connect:any, helo:any
[ERROR] [38A98778-D1E0-4064-AF11-0A54720063A8] [helo.checks] forward_dns(Error: queryA ESERVFAIL smtpbg63.qq.com.)
[INFO] [38A98778-D1E0-4064-AF11-0A54720063A8.1] [access] pass:unlisted(mail)
[INFO] [38A98778-D1E0-4064-AF11-0A54720063A8.1] [access] pass:unlisted(conn), connect:any, helo:any, mf/rt:any
[INFO] [38A98778-D1E0-4064-AF11-0A54720063A8.1] [core] hook=mail plugin=mail_from.is_resolvable function=hook_mail<EMAIL_ADDRESS>retval=DENY msg="MX without A records"
[NOTICE] [38A98778-D1E0-4064-AF11-0A54720063A8.1] [core] sender<EMAIL_ADDRESS>code=DENY msg="MX without A records"
[NOTICE] [38A98778-D1E0-4064-AF11-0A54720063A8.1] [core] disconnect ip=<IP_ADDRESS> rdns="smtpbg63.qq.com" helo="smtpbg63.qq.com" relay=N early=N esmtp=Y tls=N pipe=N txns=1 rcpts=0/0/0 msgs=0/0/0 bytes=0 lr="550 MX without A records" time=10.166
[NOTICE] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A] [core] connect ip=<IP_ADDRESS> port=38176 local_ip=:: local_port=25
[INFO] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A] [access] pass:unlisted(conn)
[INFO] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A] [access] pass:unlisted(conn), connect:any
[ERROR] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A] [dnsbl] no zones
[INFO] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A] [access] pass:unlisted(conn), connect:any, helo:any
[ERROR] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A] [helo.checks] forward_dns(Error: queryA ESERVFAIL smtpbg326.qq.com.)
[INFO] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A.1] [access] pass:unlisted(mail)
[INFO] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A.1] [access] pass:unlisted(conn), connect:any, helo:any, mf/rt:any
[INFO] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A.1] [core] hook=mail plugin=mail_from.is_resolvable function=hook_mail<EMAIL_ADDRESS>retval=DENY msg="MX without A records"
[NOTICE] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A.1] [core] sender<EMAIL_ADDRESS>code=DENY msg="MX without A records"
[NOTICE] [5EE4F7EA-7003-4E28-80BC-26A0E0B1CB1A.1] [core] disconnect ip=<IP_ADDRESS> rdns="smtpbg326.qq.com" helo="smtpbg326.qq.com" relay=N early=N esmtp=Y tls=N pipe=N txns=1 rcpts=0/0/0 msgs=0/0/0 bytes=0 lr="550 MX without A records" time=10.901

sorry for lack of the knowledge about email server, but what's the key point to solve the problem, I hope to create a forward server
thank you.

Your DNS configuration is broken.  A lookup of qq.com is returning SERVFAIL.

thank you
In fact, when i change to another server, this error was not display, may be I change something else
However I still never understand it, why my dns configuration will afect the lookup of qq.com, my dns was something about my domain


fix: Refactor menus app: significant time saving (queries and cpu)

Description
Menu creation takes significant time for installations with a large number of pages. This PR reduces time needed for creating the menu and rendering the menu. Measurements were done on a test installation with ~55,000 pages (SQLite db).
Improvement 1: Generating the navigation node list
Creation of menu nodes is cached. So, this is a one-time gain after, say, adding a page.
The efficiency gain comes from identifying the relevant page content object only once per page object when translating the page list into a menu node list.
Improvement 2: Rendering the menu
The second angle of attack are the menu template tags: They depend on the cut_levels implementation, which was very inefficient. Especially, the extra_inactive parameter indicating how many inactive children should be present in the navigation had a computational time of O(n) with n being the number of pages/menu entries. The PR makes reduces this O(1).
Improvement 3: Versioning-induced db hits
An N+1 issue is introduced when generating the menu nodes through djangocms-versioning. Each menu node is checked against the home page to check if it needs to be cut. For this, the home page needs to be not in the navigation. Since, "not in navigation" is a page content property, this check triggers a database hit to find the relevant page content version. This PR only checks once if the home page is in the menu.
Additional improvement potential

No partial update of cached node lists.

@jrief Can you help to test this in a realistic environment?
Related resources

#7805
#7933 (one key argument being here building the menu)

Checklist

[x] I have opened this pull request against develop-4
[x] I have added or modified the tests when changing logic
[x] I have followed the conventional commits guidelines to add meaningful information into the changelog
[x] I have read the contribution guidelines  and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun

@jrief Can you help to test this in a realistic environment?

on our system, this merge request now is running in production and a huge relief for our customers, especially those which are not superusers.


Hostboot build fails with ENABLE_CHECKSTOP_ANALYSIS set in Palmetto config

When I set ENABLE_CHECKSTOP_ANALYSIS in the hostboot palmetto config I get the following build failure:
exception caught: Could not find symbol _ZNK4PRDF17PnorFirDataReader7getScomEPN9TARGETING6TargetEmRm
make[4]: *** [../img/hbirt.bin] Error 255
make[4]: *** Waiting for unfinished jobs....
exception caught: Could not find symbol _ZNK4PRDF17PnorFirDataReader7getScomEPN9TARGETING6TargetEmRm
make[4]: *** [../img/hbirt_test.bin] Error 255
make[3]: *** [_BUILD/PASSES/IMAGE/BODY] Error 2
make[2]: *** [_BUILD/SUBDIR/IMAGE/src] Error 2
make[1]: *** [_BUILD/PASSES/IMAGE/POST] Error 2
My op build is pointing to HB commit 3593853a4323d9ec7de1ad6502e22b3e66af03ae

I'm pretty sure they currently also need HBRT_PRD with ENABLE_CHECKSTOP_ANALYSIS.  It isn't currently marked in the HBconfig file.

@dcrowell77 - Can you mention this issue to Zane and have him look into it?  He doesn't have a github account right now that I know of.

@sbroylesibm You are missing 1b488dc and daf669b, which are required for the checkstop analysis to work. However, this should not prevent it from compiling. Continuing investigation.


raftstore-v2: adaptive apply

What is changed and how it works?
Issue Number: Ref #12842
What's Changed:
Make apply adaptive to reduce high tail latency.

Check List
Tests

Unit test
Integration test

Release note
None

/merge


Update egui to 1.16.1

Covers making bevy_egui compile and that's about it. I didn't add Event::Zoom from the egui changelog

Looks great! Thank you for the help. I'll publish a new release soon.

Looks great! Thank you for the help. I'll publish a new release soon.


Fixed generators to work from a mountable Rails engine

Added Rails engine "namespace" to asset paths when installing CASino. Added migrations generator to copy migrations because the built-in rake railties:install:migrations does not work when running the command on a Rails engine. It's a simple fix to copy the files.
Given, we may have a special case where we're mounting CASino in another mountable Rails engine.

Thanks for your PR. How can I reproduce the problem you are facing with the current implementation? Does this change the behavior of the most comment use case? Do we have to migrate existing installations?

@pencil you can test this by creating a mountable Rails engine, and mounting CASino. Then (from the rails engine root) try running the generator rails g casino:install or the Rake command rake casino:install:migrations. It doesn't seem to work (with the old code), but works now with this new generator.

Does this change anything for existing installations? Are the commands still the same?

Coverage remained the same at 97.201% when pulling fed06268949fbc50d695d0b27060599cdd32073f on identification-io:master into fed06268949fbc50d695d0b27060599cdd32073f on rbCAS:master.


Android Installation?

How does this installation work? I ran it with the Readme but I'm stuck. Any help?

Hi JarrettFritz,
Can you show me what's the system saying when you got stuck?

It's more to run it I guess. It says to type exit. Don't know what to do next

Ok, now you have installed kahoot-hack on your device. You need to restart the by typing exit and open the app again. The way to use the hack is typing go run kahoot/[hack-name.go].
Example:
go run kahoot/flood.go

And the system will show you about the usage message:
Usage: flood <game pin> <nickname prefix> <count>
       flood <game pin> <name_list.txt>

In this case I will show you how to use flood.go:
go run kahoot/flood.go 537837 Bot 20

The number 537837 is the game pin. The text Bot is the nickname prefix. And the number 20 is the amout of bots.

Thank you!


Hugo Deploy concurrency issue

### Tasks
- [ ] update `flow-hugo-publish.yaml` so that `build` and `deploy` are capitalized to match the rest of the workflow jobs
- [ ] ensure `Deploy Hugo sites to Pages` does not pick up `Unit Test Results - Linux`, `Unit Test Results - Windows`.  and `E2E Test Report`, see screenshots and links below...

https://github.com/hashgraph/solo/actions/runs/11255769974

https://github.com/hashgraph/solo/actions/runs/11255712886

I dont' understand why Unit test steps showing up in the hugo work flow
https://github.com/hashgraph/solo/actions/runs/11273683958
But I checked artffact, no any unit test results were included.

I manually kicked off huge page workflow,
it did not show any unit test steps at all
https://github.com/hashgraph/solo/actions/runs/11278658135

I know, weird right!  I think it only happens when there are multiple PRs and/or main running at the same time.  it must be sharing something.

:tada: This issue has been resolved in version 0.31.1 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This issue has been resolved in version 0.31.1 :tada:
The release is available on:

npm package (@release-0.31.x dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


feat(headers): Add Content-Disposition header

fixes #561
This is fairly extensive and would benefit from some review.
It does not try to interpret language-tags (rfc 5646) but rather accepts any string (for now).

@mikedilger indeed, this is a lot of work! awesome!
I've reviewed the code, though I must say, I'm not too familiar with this header, so I may have missed something.

I think I have addressed everything above except using url::percent_encoding, which depends on PR servo/rust-url#134

Seems a new version is needed of the url crate?

Precisely.   I'm in no hurry to get this PR merged as I can use raw headers in the meantime.  But if you like things tidy, @SimonSapin would have to make a release.

I just published url v0.3.0 on crates.io which includes https://github.com/servo/rust-url/pull/134. Publishing is easy but I sometimes forget to do it. Feel free to ask for it in PRs!

@mikedilger I see it's passing now. Awesome!
Could you rebase this into a single commit, feat(headers): add Content-Disposition ...? The current commits will make the changelog confusing (fixing bugs that were never released, etc).

Ok, rebased onto master and collapsed into a single commit

Seems another PR updated the Cargo.toml to bump the url version already, making a conflict here.

Ok, rebased again.

\o/


can we use different tag to match different python tag?

like tag 3.8 to match CPython3.8? This will be good for tracing the new code.

Hi @jiamo
So far the build system can be used to compile any version of python from 2.7.3 to 2.7.14, and also 3.5.1 to 3.5.2.
These are the version whose checksum are explicitly listed in the top-level CMakeLists.txt
It also possible to pass -DSRC_DIR:PATH=/path/to/Python-3.8 source and the build system will do its best to build it (not tested yet)
All of that said, it may be good to have to branch 2.x and 3.x, that way we would simplify the build system overall.

xref https://github.com/python-cmake-buildsystem/python-cmake-buildsystem/pull/214


how to make sql like "where aid&2=1"

$database->select($tablename, ["*",], ["And"=>[ "isok"=>0,"aid&2"=>1]]);
like this is not support?

Check out the new feature raw object https://medoo.in/api/raw.


bug: the total lines button does not working

Describe the bug
the total lines button among the README button does not work.
To Reproduce
Steps to reproduce the behavior:

Go to README

Expected behavior
displays this repo has how many lines.
Screenshots

temporarily, I'll remove the button.


question on defaults for argon2

Are the defaults for argon2 in pwdlib documented anywhere? I can't seem to find them in docs or source code.
from pwdlib import PasswordHash
password_hash = PasswordHash.recommended()
password_hash.hash("herminetincture")

example output structure: $argon2id$v=19$m=65536,t=3,p=4$<hashedpw>
^ from the above I assume version=19; memory=65536 kibibytes; iterations=3; parallelism=4. Is this correct?

The defaults are actually pulled directly from Argon2 implementation:
https://github.com/frankie567/pwdlib/blob/17fd0c6a2f4b18cdc5fe6d8115844b7aea4cbfce/pwdlib/hashers/argon2.py#L15-L23
Which are defined there, and corresponds to the "low memory" profile of the RFC:
https://github.com/hynek/argon2-cffi/blob/0805dbdded04dc3c4bc8573236c80be50ff30113/src/argon2/profiles.py#L30-L38


Updated political organisation config

This is part of preparation for the July 2024 general election.
This list was generated by using the below command in the Whitehall integration environment, as per the documentation at the top of the config file.
puts Organisation.where(political: true).order(:name).map { |o| "- '#{o.content_id}' # #{o.name}" }.join("\n")

Tested on integration and it seems to do the trick. Once the document has been resynced the political status is updated


Bosco status not showing the service/repo name which has uncommitted changes

Whey you try bosco status and a repo has uncommitted changes, it just shows you that repo has changes and there is no way to find which repo.

@cliftonc hope this was the issue https://github.com/tes/bosco/commit/49dc4569877ce67df737b520b305fd61485d9990

Lgtm!


Is it possible to guarantee to get a fixed number of video frames per tick using overclock?

Without this, using different overclock cannot give the equivalent video streams.
It will be better if the video frames can be exactly aligned with each tick.

Minecraft's render speed varies hugely depending on the machine's capabilities and the scene that is currently being rendered. (Frame rate drops substantially while things are exploding, for example.) While the render can be throttled to a maximum fps, it's impossible to enforce a minimum. Even without varying the overclocking, you're unlikely to get precisely equivalent video streams from run to run, due to the stochasticity in the system.
The best approach seems to be for Malmo to push out frames as fast as possible, and have the user match the frames and actions themselves. Some of the python samples contain example code for this - see robust_frames.py, for instance.

Is it possible to control the advance of each tick in Minecraft? This way can have precise control over the observations.

Deepmind's Lab environment allows the precise control over the number of frames using step() function (https://github.com/deepmind/lab/blob/master/docs/python_api.md). With continuous movement and complex environment, it's very difficult to do what robust_frames.py does. With manual control of the advancement of each frame, we don't need to worry about the timing of frames and observations.
I really like Minecraft as a learning environment because of its generality. But currently, its non-deterministic behavior makes me uneasy.

I kinda agree, but on the other hand - in actual robotics you cannot "step
the environment". You have to take into account that time is passing by and
if your calculations take too long, you might crash in meantime. Or
sometimes your sensors are laggy or noisy. Minecraft prepares you for that.
On Fri, Jan 6, 2017 at 3:04 PM, emailweixu<EMAIL_ADDRESS>wrote:

Deepmind's Lab environment allows the precise control over the number of
frames using step() function (https://github.com/deepmind/
lab/blob/master/docs/python_api.md). With continuous movement and complex
environment, it's very difficult to do what robust_frames.py does. With
manual control of the advancement of each frame, we don't need to worry
about the timing of frames and observations.
I really like Minecraft as a learning environment because of its
generality. But currently, its non-deterministic behavior makes me uneasy.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/malmo/issues/437#issuecomment-271034308,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADo7grPE3fcz0tALvfyFZwQ22MY3N9ziks5rPsh2gaJpZM4LbOFv
.

It's true for running in the real physical world or real game. But for simulation, we want to train as fast as possible, and possibly with multiple minecraft instances on one single machine. With current overclocking mechanism, it's really hard to control the frame rate.

The way I do it:
https://github.com/tambetm/gym-minecraft/blob/master/gym_minecraft/envs/minecraft_env.py#L277-L285
Basically I wait till at least one observation is available. If there isn't I wait for 1ms and try again. I run Minecraft with 5ms ticks and getting 150-160 fps. Why not 200 as supposed with 5ms ticks? Firstly if episode ends, resetting takes time and draws down the fps. But occasionally I also miss an observation. This hasn't prevented learning though (using recurrent policy).
Also when running with 5ms ticks you should also increase the maxFps in options.txt, as suggested here. If you set maxFps 200, then you nicely get one frame per observation, most of the time. In other times I just return the previous frame. Also setting video resolution to 40x30 helps to keep rendering costs low. Again, hasn't prevented from learning.

Eliminating all non-determinism from Minecraft would be a significant engineering effort - if it's even possible at all - and I'm not sure how useful the resulting platform would be: adding code to enforce deterministic behaviour is only going to make everything slower, and Minecraft is already a heavy-weight environment, even when over-clocked.
I'm going to close this issue - it may be that we revisit the idea of adding a step() function at some point in the future, but for now you'll just have to cope with the non-determinism using the sort of workarounds that @tambetm suggests.


docs(readme): integrations section

Summary
This change introduces an "integrations" section of the documentation. Welcoming feedback or change requests.

@adamhenson thanks for the suggestion, but I'm a bit hesitant to add a PR for an integrations section because there are already a lot of integrations with Web Vitals and it would be hard to capture them all in a single README.
Regarding this specific tool, I do have a couple of suggestions though:

It's called "Automated Lighthouse Check" but (at least upon initial inspection) it doesn't seem to integrate with Lighthouse at all. Keep in mind that Lighthouse is a lab tool and this library tracks Web Vitals metrics in the field. We don't want to imply to developers that these terms our synonymous.
The code sample you provide on this page checks to see if the metric is final before sending it. That's not a good idea as you'll likely lose a lot of CLS data if you wait until the metric is final (you should be reporting it any time the visibility state changes to hidden).
The example uses fetch(), but it'd be better to use sendBeacon() (or fetch() with the keep-alive flag). Using fetch as is might block other network activity.

@philipwalton thanks for the feedback in the 2nd and 3rd bullet. The first bullet is quite incorrect however. In fact Automated Lighthouse Check is listed as an integration in the Lighthouse GitHub project. I thought it would make sense to mirror it in this project (by having an “integrations” section). I’m disappointed in your decision to dismiss this PR. I understand your perspective, but by having this type of section it adds a small bit of support for all the dedicated developers that are supporting you. It would be a nice way to give back. As an engineer representing Google I’d recommend being a bit more thoughtful to support the community with decisions like these.

(chiming in just as a watcher of this repo)
FWIW I agree that it doesn't make sense to add an integrations section to this project's readme.  IMO that kinda content isn't too typical for OSS projects, we just happen to do it in the lighthouse readme.
And let's be real, adding a link to your site above the API documentation is a ballsy move.

it adds a small bit of support for all the dedicated developers that are supporting you. It would be a nice way to give back

speaking in general as an open source maintainer.. i think there's a big distinction between a project's users and its supporters. i wouldn't say most users of my projects are "supporting" the project. and as the projects grow large, it gets considerably harder to scale one's time and attention to 1) deal with all filed issues and 2) do so thoughtfully.
IMO philip's response was hugely thoughtful, even pointing out two suggestions. And he's fully justified in this decision.

Fair enough, I appreciate having more than one opinion. I wasn't sure where to place the integrations section but was hoping to get feedback about it. I understand the perspectives here and can empathize. I am deeply familiar and respect your work... going way back. Hope this didn't come across as unappreciative. And I'm content knowing that you at least entertained my perspective and that we had more than one core contributor opinion on this. I'm going to sit down now... before I'm banished from the JS community 😆

I just meant "support" in the sense that I'm a fan and follower and one of the zillions of developers that click that star. I'm one of the developers paying up the big bucks to go to the next conference you speak at. I'm the one linking to your projects driving traffic to your work... to build your brand and Google's. I'm the one talking about that article you just wrote. I was fishing for some fan appreciation, but I get it... I understand where ya'll stand.


CocoaPods installation

Is there any reason why the library doesn't have a Podspec and is not released on CocoaPods yet?

It's currently still a pre-release. Once I'm happy with the library I'll mark a release as live and add it to CocoaPods.

This will probably be soon, possibly before next week.

@Qata Great news, thank you!

@Qata Here you go 😉 https://github.com/ReSwift/ReactiveReSwift/pull/6

I think we can close it now.


Numpydoc validation

Add the following directives to the validation configuration:

[ ] RT05 - Return value description should finish with "."
[ ] ...

Hi @CollinHough , @jleonatti ,
Is this issue still in progress?
Thanks

Hi @Samuelopez-ansys, I no longer directly contribute to this project, so there has not been any work related to this issue from me.

@Samuelopez-ansys I will add the directive suggested by @jleonatti .
We already have some of them checked.

@MaxJPRey Is this issue fixed?


Update C4 graphs according to new implementation

DESC

need to be updated because of new documentation requirements

TODOs

[x] rework raw files
[x] update images
[x] rework web view at technical documentation

implemented


Authenticated Webview

https://developers.home-assistant.io/docs/en/app_integration_webview.html

Is blocked by https://github.com/home-assistant/home-assistant-polymer/issues/3575


map-pin-home

Icon Request

Icon name: map-pin-home
Use case: When you want to select your location for your home, or for pinning a location related to a home, house or building.
Screenshots of similar icons:

There's a lot of different icons similar to this out there. Here's a few more: https://thenounproject.com/browse/icons/term/pin-home/
Code of similar icon (the first one):
<svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" viewBox="0 0 24 24" fill="none">
  <path d="M9 13H11V10.25H13V13H15V8.25L12 6.25L9 8.25V13ZM12 19.35C14.0333 17.4833 15.5417 15.7875 16.525 14.2625C17.5083 12.7375 18 11.3833 18 10.2C18 8.38333 17.4208 6.89583 16.2625 5.7375C15.1042 4.57917 13.6833 4 12 4C10.3167 4 8.89583 4.57917 7.7375 5.7375C6.57917 6.89583 6 8.38333 6 10.2C6 11.3833 6.49167 12.7375 7.475 14.2625C8.45833 15.7875 9.96667 17.4833 12 19.35ZM12 21.325C11.7667 21.325 11.5333 21.2833 11.3 21.2C11.0667 21.1167 10.8583 20.9917 10.675 20.825C9.59167 19.825 8.63333 18.85 7.8 17.9C6.96667 16.95 6.27083 16.0292 5.7125 15.1375C5.15417 14.2458 4.72917 13.3875 4.4375 12.5625C4.14583 11.7375 4 10.95 4 10.2C4 7.7 4.80417 5.70833 6.4125 4.225C8.02083 2.74167 9.88333 2 12 2C14.1167 2 15.9792 2.74167 17.5875 4.225C19.1958 5.70833 20 7.7 20 10.2C20 10.95 19.8542 11.7375 19.5625 12.5625C19.2708 13.3875 18.8458 14.2458 18.2875 15.1375C17.7292 16.0292 17.0333 16.95 16.2 17.9C15.3667 18.85 14.4083 19.825 13.325 20.825C13.1417 20.9917 12.9333 21.1167 12.7 21.2C12.4667 21.2833 12.2333 21.325 12 21.325Z" fill="#002A11"/>
</svg>

This is rather detailed to work well with our guidelines, I think something like these would be the best we could do, but I'm not sure any of these truly makes the cut:

Oh, I only just now see your reply, this issue was left open in my browser.
Your house shape is better than mine, although I think we would have to lose the chimney, and maybe add a bit of rounding:

Can we use the original house svg perhaps?
https://lucide.dev/icons/home

Looks okey when it's small too:

Perhaps the roof can extend a bit past the walls so that it's more clear?
If we add a door like in the Home icon to the image you posted I think it looks quite a bit better @karsa-mistmere :

The door violates one of our design guidelines I'm afraid, there must be a 2px gap between all elements.

Sounds like a good rule in general, but bummer that it makes this design unviable.
I also think @jguddas design looks good though

New idea:
Open lucide studio


remove incorrect option

#1136

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@MSFTTracyP - PR has been copy edited and is ready for final review. This is based on issue #1136.
Thank you.
cc: @kenwith


Dependencies

I used to use this plugin which has 3 dependencies: https://build.phonegap.com/plugins/1682
Does this version have dependencies or can I just include thiscode in my PGB config.xml file and I'm done?
<gap:plugin name="cordova-plugin-apprate" source="npm" />

As you can see in the plugin.xml we only have dependencies to:
<dependency id="cordova-plugin-dialogs"/>
<dependency id="cordova-plugin-globalization"/>

I hope this helps.

These seem to be added to my project automatically by PGB. Great job to them :)
Not sure the plugin works though.


Use standard 1px window borders on NC Island Window

Summary of the Pull Request
I put the standard Windows window borders on the Windows Terminal window (can you read that?).
(It's only on the left, bottom and right though, on the top I had to use a hack because of the title bar)
Light mode, color in title bar disabled:

Light mode, color in title bar enabled:

Dark mode, color in title bar disabled:

Dark mode, color in title bar enabled:

High contrast mode (with Settings app on right to compare):

Note: the title bar should probably be purple like in Win32 apps but it isn't either in the UWP apps (Settings, classic Edge, …) so I don't really know.

References

PR Checklist

[x] Closes #3064, closes #1307, closes #3136, closes #1897, closes #3222, closes #1859, closes #2268 and maybe more?
[x] CLA signed. If not, go over here and sign the CLA
[ ] Tests added/passed
[ ] Requires documentation to be updated
[ ] I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Detailed Description of the Pull Request / Additional comments
We take the standard window frame except that we remove the top part (see NonClientIslandWindow::_OnNcCalcSize), then we put little 1 pixel wide top border back in the client area using DwmExtendFrameIntoClientArea and then we put the XAML island and the drag bar on top.
Most of this PR is comments to explain how the code works and also removing complex code that was needed to handle the weird cases when the borders were custom.
I've also refactored a little bit the NonClientIslandWindow class.

Validation Steps Performed

For now there is no resize handle directly on top of the tab row.

I don't know enough about the non-client area and XAML stuff to go through this. @DHowett-MSFT is the non-client expert and @zadjii-msft is the current UI king. So I'll let them stab first.

Note: the big purple top border is missing when high contrast is activated on Windows because I hardcoded its size as 1 pixel * DPI scale. But it's also missing on UWP apps so I guess the people at Microsoft who did the UWP apps had the same problem but couldn't fix it so maybe there is no easy solution?

Please 😢

This is a lot to digest, but I think I like where it's going.  I'll need to give it a closer review, but it seems like a more refined version of the work I was doing to achieve the same goal. :smile:

Ok so in the before last commit I fixed a bug where the theme is taken from the system settings and not the settings.json. But because the theme was not originally passed to NonClientIslandWindow, I had to change a few files like App.h, App.cpp, AppHost.cpp, etc. Please check this.

I'd be most comfortable merging this without the dark theme fix (which I know will cause there to be white borders around the entire window instead of just at the bottom) and then bringing in the dark theme changes when the other fix has flowed back down from Windows.

I'm not sure if I understand this correctly. I rolled back src/interactivity/win32/windowtheme.cpp to master and removed the code in the function to set dark mode in ThemeUtils (now it doesn't do anything). Also I renamed the function to be more generic because apparently it's no longer a DWM window attribute to set the frame to dark theme.

(which I know will cause there to be white borders around the entire window instead of just at the bottom)

There was no white border at the bottom, I removed the hack with DwmExtendFrameIntoClientArea.

One thing I've noticed - the behaviour for when title bar colours are disabled doesn't actually line up with the current/expected behaviour seen with other apps.
As an example, here's Settings while inactive and with title bar colours disabled.
Zooming in on the left border here, you can see the border is actually a transparent shade;

When I focus the Settings window, the border remains transparent;

As far as I can see, your borders are solid colour. It's a small thing, but might be best fixed before merging 🙂 ✨

It looks like it depends on the app.

Paint has it too:

But conhost.exe doesn't:

Neither does regedit:

Explorer and Paint are two apps that modify their title bar to add additional buttons in it (explorer to open file properties and create a new folder; paint to save or go back/forward). So maybe the window border turns white automatically for some reason when you remove the title bar? Then I don't know how the Settings app does it because it has a dark border on my system but it ALSO has a custom its title bar.

Interesting, it's probably something to do with UWP vs non UWP apps?

Ok so I found a bug where the title bar is not included in the initial height when showTabsInTitlebar is on so if you set initialCols to 10 for example it ends up being less than that (and it can even crash if you set it to 1 because the size is too small). The bug was there before the PR but I've updated a TODO in 48cd3801c3b1df22bf809314ad4696eb0441ad03 to tell what needs to be done to fix bug (because it should probably be done in another PR). Should I make a GitHub issue for it? Because the TODO says MSFT so it's not on GitHub.
@DHowett-MSFT I initially assumed that DWM would scale the borders based on the DPI but I tried changing my DPI and the top border stays 1 pixel exactly on apps like explorer.exe so I've removed the code to scale the top border according to the DPI. It will probably fix the bug with the thick borders.

@greg904 That might actually be #2061, if not it's definitely related. I'd probably just leave it as-is, and fix it as a part of #2061.

Ok, I've reverted the TODO change to leave it as-is.

/azp run

bravo!

So...any way to color this new 1px border? I don't think there is a setting in Windows to color inactive window borders differently anymore, is there?

I'd be most comfortable merging this without the dark theme fix (which I know will cause there to be white borders around the entire window instead of just at the bottom) and then bringing in the dark theme changes when the other fix has flowed back down from Windows.

I couldn't find more details about this here, so does this mean the white border will be fixed with a new release or does the fix need to come from Windows, i.e. we would have to get 20H1 for the fix?

@Stanzilla The border behaves the same way as other windows. When it is active it will be either the accent color that you chose in Windows Settings if "Show accent color on the following surfaces -> Title bars and windows borders" is checked or a gray color otherwise. When it is inactive, it will always be gray. I don't think that there is a setting to color inactive window borders in Windows.
@adrianghc 20H1 changed the way to make the border dark. I think it is possible to detect if 20H1 is running and use the new way and if it's older than 20H1, use the old way to make the border dark so it could be fixed without waiting for 20H1 if this is done.

Well yeah, I don't really want to use my accent color on every window, was just wondering if there is a way to overwrite. But if that is black in 20H1 I'm okay with that

In addition to the bottom white border, I now have 3 more borders, making the issue officially 4 times worse 😂

Yes indeed, the border in dark mode is still white I've noticed, which is quite bothersome to look at.

Version 0.9 has rolled out and my Windows Terminal still has this problem. Any ideas as to what the status of this issue is?

Yes, see #3425 and maybe PR #4577.

Thanks @greg904, so it sounds like its not a stable solution yet correct? Wondering if it might be best to sit tight a little longer until a new version of WT fixes this, or if it's worthwhile to attempt your solution in #4577

If you run the fix:

you are running the dev or master version which is not stable and can have bugs
on top of it you are running my fix which is not very tested (I made it quickly because I, too, want that bright border to go away :))

If you wait:

last release was 2 days ago so I'm guessing the new release won't come in a few days
maybe more stable

BTW, just to be clear:
With the fix, if you disable:

You get this:

And if you enable it, you will have a border but now it will be blue:

So there still is a blue border but it is just like other apps:


Bumping Moshi and Json Versions

See main common PR for description: https://github.com/AzureAD/microsoft-authentication-library-common-for-android/pull/2210

Bumping to Moshi 1.14.0, since this version doesn't contain Kotlin 1.8 yet (some downstream consumers are not able to take dependencies with Kotlin 1.8 yet).


update postal install script to set correct dns config

Install script and docs have mixed use of postal.yourdomain.com and postal.example.com. This causes a configuration issue on initial setup. The install script takes in a hostname, copies the examples/postal.yml, and then uses sed to update some placeholders in that the file with the user-specified domain name.
examples/postal.yml has placehoders of postal.example.com, but the script replaces occurences of postal.yourdomain.com which do not actually occur in that file. As a result, a setup that uses the documentation will still have all the DNS settings still pointing to postal.example.com.
The impact of this is that the in-app instructions to setup DNS are incorrect. E.g. the app will tell me to create a TXT record like v=spf1 a mx include:spf.postal.burnerlogin.com ~all which of course is not correct. It also appears that the DNS checker will test against the wrong domain
I update the script to replace both example.com and mydomain.com in the example configs. I also add a check to prevent someone from accidentally using the bootstrap script with the placeholder domain (e.g. if they copy-paste the command directly in the console without modifying)

@willpower232

IMHO it would be better to correct the main/examples/postal.yml file instead but it may be that the current one makes more sense

This has now been fixed.


demo-rails app -> Endpoint request timed out

Checklist

[x] Upgrade Jets: Are you using the latest version of Jets? This allows Jets to fix issues fast. There's a jets upgrade command that makes this a simple task. There's also an Upgrading Guide: http://rubyonjets.com/docs/upgrading/
[x] Reproducibility: Are you reporting a bug others will be able to reproduce and not asking a question. If you're unsure or want to ask a question, do so on https://community.rubyonjets.com
[x] Code sample: Have you put together a code sample to reproduce the issue and make it available?  Code samples help speed up fixes dramatically. If it's an easily reproducible issue, then code samples are not needed. If you're unsure, please include a code sample.

My Environment

Software
Version

Operating System
UBUNTU 18.04

Jets
2.3.15

Ruby
2.5.3

Expected Behaviour
I have followed jets-afterburner-serverless-rails-on-aws-lambda-in-5-minutes and try to deploy the demo rails application with jets deploy command.
Every thing seems to work as I don't get any error in the cloudwatch logs but upon hitting the endpoint returned from the after deploy command, it should load the demo rails site.
Current Behavior
After hitting the Endpoint https://lo4lne31h5.execute-api.us-east-1.amazonaws.com/dev/, instead of loading the content, it displays the following message:

{
message: "Endpoint request timed out"
}

CloudWatch Logs

Code Sample
I have used the existing demo-rails repo in my project and code can be found here: my-rails-demo-app
Solution Suggestion
I have shared the logs above and found no issues, but still it is timeout. No idea whats going on here. Kindly suggest.

@tongueroo This is kind of an urgent issue that needs to be fix. Can you help me out here. I have checked and verified my DATABASE_URL on local and it is connecting and working fine.
I really don't understand where the issue is as cloudwatch is not telling me any issue.

@hamza-sondermarketing This is not urgent. It's a demo app.
This is more of a usage question. Please review the issue guidelines again. Like these other issues: #456 #460 #463 Keeping questions on the forum helps keep the signal-to-noise ratio higher.
Responded to the community post with some tips: https://community.rubyonjets.com/t/could-not-find-a-javascript-runtime-see-https-github-com-rails-execjs-for-a-list-of-available-runtimes-execjs-runtimeunavailable/440


fix: Updated Tooltip Text Error on Social Links in Footer Section

Fixes Issue
Closes #1919

Changes proposed

Added and Modified title attribute text means Valid Tooltip Text merging with Social Links existed attributes.

Screenshots

Checklist

[x] You've linked this PR to the correct issue.
[x] You have checked that the code is working correctly.
[x] You ⭐ the repository!

Note to reviewers

Hi @Souravvmishra . Please review on this PR and add Valid Labels under GSSOC'23

Great Work


Sort Default

Sort default should be set to something like yards.

I am not sure what to do here thought I could just set this. Will research and come back to it.


[cleanup] Remove tracer shutdown

Remove no-op shutdown function, move initialization into the one-time group

Could I get some context on why we don't need shutdown?

Init only initializes static state, and can be done cleanly multiple times.
There's no resources to release (and the tracer_shutdown function has been empty for some time)


Serverside alt.Blip.routeColor throws invalid baseobject error

Description of the problem
Serverside static getter alt.Blip.routeColor throws baseobject error
Reproduction steps
try{ alt.Blip.routeColor } catch(e) { console.error(e) }

Expected behaviour
No error.
Additional context
No response
Operating system
Windows 10
Version
dev/7.0-dev13
Scope
server

I checked and routeColor is not static.


Display of Date in Dashboard

Hi MoH Team,
I recognized that dashboard changed to a new website: https://data.moh.gov.my/covid
However, the new display is a little vague on which date is these data referring to. There is only 'Last updated' time for each part, but no 'Data as of'.

I believe the 'Last udpdated' date does not refer to the actual reference date. Could you also include the reference date for these data?
Thanks!

Thank you for the feedback - we have now updated all pages to show a "Last Updated" timestamp (for the page deployment) as well as a "Data as of" timestamp.


Only open list if it isn't already open

Additionally, only fire the didOpen action after the list has been opened

Seems reasonable, 🚢


New subscription for each call to fetchMore

Hello,
I have a problem with fetchMore function of watchQuery.
I have implemented a infinite scroll for my app, when i call to fechMore function of my watchQuery is created a new Subscription, i can see on "Apollo Dev Tools".
The problem is i can't unsubscribe of this new subscriptions because i don't have any reference about them.
This is the watchQuery function:
this.query = this.apollo.watchQuery<{ Customers: Array<Customer> }> ({
      query: gql`
        query Customers ($orderBy: String, $first: Int, $skip: Int) {
          Customers: allCustomers(
            orderBy: $orderBy
            first: $first
            skip: $skip
          ) {
            ...customerListFragment
          }
        }
        ${ customerListFragment }
      `,
      variables: { orderBy: "firstName_ASC", first: 20, skip: 0 },
    });

and with the reference of this i call to fetchMore:
this.query.fetchMore({
      variables: { skip: 20 },
      updateQuery: (prev, { fetchMoreResult }) => {
          if (!fetchMoreResult) return prev;
          return Object.assign({}, prev, {
            Customers: [...prev.Customers, ...fetchMoreResult.Customers],
          });
        },
    });

Each time when i call this function for feachMore results is created a new subscription.
Is the expected behavior? How i can unsubscribe for this new subscriptions?
Thank you!

I think it's on the apollo-client side but give me some time to check it.

@kamilkisiela Did you have a chance to look at this one?

Hi @kamilkisiela Did you have some update?

I can confirm this leak happens. Is there a fix for this?

Any new about this issue?

Does anyone want to take a look at this? I could help and answer all questions about Apollo if needed.

I'm closing in favor of this one apollographql/apollo-client#2286


[Bug] Missing lakes inside countries.

See also here.

To solve the problem we need to subtract from:
http://data.openstreetmapdata.com/simplified-land-polygons-complete-3857.zip
these 2:
http://data.openstreetmapdata.com/lakes-polygons-reduced-3857.zip
http://data.openstreetmapdata.com/river-polygons-reduced-3857.zip

thats not only a bug but also a feature. I'm really happy for my current project to have your lake-free data because lakes and all the small islands would make too much noise.
So maybe you can add a "inland_water_bodies" version but not replace the current?

@indus May I ask you why 'countries-maritime' is not appropriate for your project if you can accept waters bodies?

In the moment it is appropriate for my project. But I thought from the title of this issue you are going to change it so it also includes lakes inside country. After that change it wouldn't be appropriate anymore. So i just wanted to ask you to keep both versions: with and without lakes inside countries.

@indus Yes, we will keep both, maybe I'll rename it.
world-land will be a land-only map (without lakes, rivers, oceans and seas)
world-coast will be the current world-land.
What do you think??
Just an you provide us an use case for this kind of map?
Thank You!!

The map in my project is just the background reference to drop some informations on. For design reasons I only want to show the outline of the world and not a solid filled landmass. By doing so all the wholes (aka lakes) would distract from the information on top because only having the lines of a polygon with wholes give the viewer some challange of what is inside and what is outside - what is land and what is water. Right now I'm using mapboxs vectordata but even on the lowest zoom level it shows Great Lakes, Lake Victoria, Lake Baikal, etc. Now I want to use one of your low resolution geojsons instead.

I've reread your comment and I wonder what land-only without oceans would look like?Am 24.11.2017 9:24 vorm. schrieb Simone Primarosa notifications@github.com:@indus Yes, we will keep both, maybe I'll rename it.
world-land will be a land-only map (without lakes, rivers, oceans and seas)
world-coast will be the current world-land.
What do you think??
Just an you provide us an use case for this kind of map?
Thank You!!
—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

You can see the work here https://github.com/simonepri/geo-maps/pull/12

Version 0.6.0 is here with 78 new maps 🎉


flutter web support?

Any idea if this project will support Flutter web?
thanks,

Hi,
Sorry, I have no plans to support Web


Selection in dictionary value panel makes value hardly readable due to the light blue background

Description

DBeaver Version
DBeaver 22.1.5
Operating System
Windows 10
Database and driver
No response
Steps to reproduce

Open value panel for foreign key column.
Select an item.
Put cursor on the selected item. The background becomes light blue, but the font remains white.

#12141

Can't reproduce on DBeaver 23.1.3 on Windows 11.


Angular 14 the compiler generates all the cache files over again on saving change

Command
build
Is this a regression?

[X] Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was
13
Description
After upgrading the project from Angular 11 into 14, the compiler starts to generate the cache file again and again when I save any file. I noticed there was a discussion about it in [Angular 13](https://github.com/angular/angular-cli/issues/22323) however it should work properly now.
Minimal Reproduction
Ctrl + Save
Exception or Error
No response
Your Environment
_                      _                 ____ _     ___
    / \   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|
   / △ \ | '_ \ / _` | | | | |/ _` | '__|   | |   | |    | |
  / ___ \| | | | (_| | |_| | | (_| | |      | |___| |___ | |
 /_/   \_\_| |_|\__, |\__,_|_|\__,_|_|       \____|_____|___|
                |___/

Angular CLI: 14.2.8
Node: 19.0.0 (Unsupported)
Package Manager: npm 8.19.2
OS: win32 x64

Angular: 14.2.8
... animations, cli, common, compiler, compiler-cli, core
... elements, forms, localize, platform-browser
... platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1402.8
@angular-devkit/build-angular   14.2.8
@angular-devkit/core            14.2.8
@angular-devkit/schematics      14.2.8
@angular/cdk                    14.2.6
@angular/material               14.2.6
@schematics/angular             14.2.8
rxjs                            7.5.7
typescript                      4.8.4

As per https://github.com/angular/angular-cli/issues/22323#issuecomment-991081570 there is an underlying Webpack issue which is still open (https://github.com/webpack/webpack/issues/14946)
Unfortunately, this is not actionable for our end as this is something has been to be address upstream by the Webpack team


Added ByToken#getAll, see parsingdata/metal#22.

Current coverage is 90.30%

Merging #23 into master will decrease coverage by -0.91% as of 61d8e97

@@            master    #23   diff @@
=====================================
  Files           67     68     +1
  Stmts          717    753    +36
  Branches       146    159    +13
  Methods          0      0
=====================================
+ Hit            654    680    +26
  Partial         26     26
- Missed          37     47    +10

Review entire Coverage Diff as of 61d8e97

Powered by Codecov. Updated on successful CI builds.


hdmedians is not available from conda-forge for windows

hdmedians is unavailable from conda-forge on windows. Adding windows support is a goal of scikit-bio over the next year. Currently hdmedians is only used in a single function in skbio:  _permdisp._config_med().
We may consider implementing hdmedians within skbio, as hdmedians has the Apache 2.0 license which may be compatible with our own license. Alternatively we may consider replacing hdmedians with another package which is available on conda-forge for windows and more actively maintained.
@qiyunzhu had this idea initially. @wasade and @mortonjt what are your thoughts?

Looking at the source code, it actually looks pretty minimal. The only
possible concern is porting the extra cython code from hdmedians - we’d
need to make sure that the cython code also ports to windows
On Tue, Mar 26, 2024 at 6:14 PM Matt Aton @.***> wrote:

hdmedians https://github.com/daleroberts/hdmedians is unavailable from
conda-forge on windows. Adding windows support is a goal of scikit-bio over
the next year. Currently hdmedians is only used in a single function in
skbio: _permdisp._config_med().
We may consider implementing hdmedians within skbio, as hdmedians has the
Apache 2.0 license which may be compatible with our own license.
Alternatively we may consider replacing hdmedians with another package
which is available on conda-forge for windows and more actively maintained.
@qiyunzhu https://github.com/qiyunzhu had this idea initially. @wasade
https://github.com/wasade and @mortonjt https://github.com/mortonjt
what are your thoughts?
—
Reply to this email directly, view it on GitHub
https://github.com/scikit-bio/scikit-bio/issues/1996, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA75VXOEJ2H4NAGUEMLYVE3Y2HXM5AVCNFSM6AAAAABFJYYZ6KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIYDSNBTGYYDEMI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@mataton This is great to know! Thanks! Yes let's port hdmedians.
The relevant hdmedians function is geomedian, which in turn calls geomedian_axis_one. I think that geomedian_axis_one is the only function we need to port (along with any utility functions it calls, like dist_euclidean and norm_euclidean).

Looks good, would stats/distance/_utils.py be a good place to put these?

Closed with PR #2003.


Create brunts.txt

@MrFrank2716 First stage of verification passed, official domain is evolvetrust.org as far as I verified. This is just an informational note. Pull request is still in the review. I appreciate your patience while waiting for the final decision.

@MrFrank2716 Thank you for your patience while waiting for a review and processing your request. Pull request merged.


Rails ujs causing problems when it's already initialised in application.js

Describe the bug
When rails-ujs is started via application.js of main rails app, when I go to /admin and go back, the following js error is triggered:
Error: rails-ujs has already been loaded!
    start rails-ujs.js:740
    <anonymous> application.js:13
    Webpack 3
        n
        <anonymous>
        <anonymous>
application.js:15:10

This is also causing trix to being loaded twice as well, generating a bunch of weird errors on the frontend size.
Reproduction steps
rails 7 app with activestorage, webpacker and rails admin installed, then this code added in app/javascript/packs/application.js:
require("@rails/ujs").start()

Expected behavior
not sure, but I believe rails-ujs should only be initialised once, probably on the rails app side.
Additional context

rails version: 7.0.1
rails_admin version: 3.0.0.rc3`
full stack trace (if there's an exception)

Add any other context about the problem here.

Actually, the problem is not only with rails-ujs, but also with the same javascript libraries loaded both by the main app and the rails admin engine. Not sure how to fix this, tbh.

Pushed the fix to the new branch 3.0-stable, could you try?
gem 'rails_admin', github: 'railsadminteam/rails_admin', branch: '3.0-stable'

Normally the main Rails application and RailsAdmin have independent JavaScript assets, but navigating via Turbo Drive between them didn't clear the loaded JavaScripts, hence this issue.
The fix solves this by moving out from the RailsAdmin with data: {turbo: 'false'} to perform the ordinary(non Turbo-Drive) transition, and setting data: {'turbo-track': 'reload'} to assets to recover from a situation where users are moving in to RailsAdmin via Turbo Drive.

I'll give it a shot and report back.

@mshibuya after moving to 3.0-stable branch, we got this error:
/home/local-user/.rvm/gems/ruby-3.1.0@ark/bundler/gems/rails_admin-e38eb46ffe79/lib/rails_admin/engine.rb:73:in `block in <class:Engine>'
 : uninitialized constant RailsAdmin::Version (NameError)

      RailsAdmin::Version.warn_with_js_version
                ^^^^^^^^^
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/activesupport-<IP_ADDRESS>/lib/active_support/lazy_load_hooks.rb:68:in `block in execute_hook'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/activesupport-<IP_ADDRESS>/lib/active_support/lazy_load_hooks.rb:61:in `with_execution_control'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/activesupport-<IP_ADDRESS>/lib/active_support/lazy_load_hooks.rb:66:in `execute_hook'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/activesupport-<IP_ADDRESS>/lib/active_support/lazy_load_hooks.rb:52:in `block in run_load_hooks'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/activesupport-<IP_ADDRESS>/lib/active_support/lazy_load_hooks.rb:51:in `each'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/activesupport-<IP_ADDRESS>/lib/active_support/lazy_load_hooks.rb:51:in `run_load_hooks'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/application/finisher.rb:85:in `block in <module:Finisher>'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `instance_exec'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:32:in `run'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:61:in `block in run_initializers'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:228:in `block in tsort_each'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:350:in `block (2 levels) in each_strongly_connected_component'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:431:in `each_strongly_connected_component_from'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:349:in `block in each_strongly_connected_component'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:347:in `each'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:347:in `call'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:347:in `each_strongly_connected_component'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:226:in `tsort_each'
    from /home/local-user/.rvm/rubies/ruby-3.1.0/lib/ruby/3.1.0/tsort.rb:205:in `tsort_each'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/initializable.rb:60:in `run_initializers'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/application.rb:372:in `initialize!'
    from /home/local-user/Documents/Avlos/ark/app/config/environment.rb:5:in `<top (required)>'
    from config.ru:3:in `require_relative'
    from config.ru:3:in `block in <main>'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/rack-2.2.3/lib/rack/builder.rb:116:in `eval'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/rack-2.2.3/lib/rack/builder.rb:116:in `new_from_string'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/rack-2.2.3/lib/rack/builder.rb:105:in `load_file'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/rack-2.2.3/lib/rack/builder.rb:66:in `parse_file'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/rack-2.2.3/lib/rack/server.rb:349:in `build_app_and_options_from_config'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/rack-2.2.3/lib/rack/server.rb:249:in `app'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/rack-2.2.3/lib/rack/server.rb:422:in `wrapped_app'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:76:in `log_to_stdout'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:36:in `start'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:143:in `block in perform'
    from <internal:kernel>:90:in `tap'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/commands/server/server_command.rb:134:in `perform'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/thor-1.2.1/lib/thor/command.rb:27:in `run'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/thor-1.2.1/lib/thor/invocation.rb:127:in `invoke_command'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/thor-1.2.1/lib/thor.rb:392:in `dispatch'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/command/base.rb:87:in `perform'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/command.rb:48:in `invoke'
    from /home/local-user/.rvm/gems/ruby-3.1.0@ark/gems/railties-<IP_ADDRESS>/lib/rails/commands.rb:18:in `<top (required)>'
    from bin/rails:4:in `require'
    from bin/rails:4:in `<main>'

after fixing it by adding require_relative './version' to engine.rb, it definitely works and the js libraries no longer collide 🥳 .
I'll keep an eye on the fix for the version thing.

Thanks for confirming, just pushed the fix for the error.
Then closing this!


my stage isn't showing up in the chart editor

I added the line of code for it into PlayState.hx, and i made it's own file thingy using the template, but it isn't showing up. The only thing i really did that might be causing this was editing "override function countdownTick(count: BaseStage.Countdown, num:Int)" to "override function countdownTick(count:Countdown, num:Int)", and i did that because it was showing me an error with it still there

Are you modding a build from source or with Lua?
Source
What is your build target?
Windows x64
Did you edit anything in this build? If so, mention or summarize your changes.
i edited TeaCall to just Tea, and changed some of the fonts, i also added the line of code for my stage into playstate and it's own source

did you put it on the stage list?

did you put it on the stage list?

i'm an idiot, thank you for telling me this


test(plonky2): Allow automated regression testing of the PLONKY2 output

This change allows plonky2_prove_success tests to (optionally) include a file, called 'plonky2.expected_output.txt' in the test directory. In case this file exists, its contents are compared against the PLONKY2 output, produced by the compiler (via the '--plonky2-print-file' option). The test fails, if the files differ.

Thanks for the PR. How about we create a new top-level testing directory for show-plonky2 tests (maybe plonky2_show_plonky2_regression) so that we don't lose track of which tests do what? This way, each test would be focusing on testing a specific aspect of the system for the price of some duplication.
We could symlink the actual test body (Nargo.toml, src/main.nr, etc.), like we do elsewhere (for example, test_programs/plonky2_trace:
 ╰─➤ ls test_programs/plonky2_trace/1_mul/ -l                                                10:17:16 2024-07-17 (Wed)
Permissions  Size User Date Modified Git Name
lrwxrwxrwx      - stan 16 Jul 12:43   --  proofs -> ../../execution_success/1_mul/proofs
lrwxrwxrwx      - stan 16 Jul 12:43   --  src -> ../../execution_success/1_mul/src
.rw-r--r--  2.6Ki stan 16 Jul 18:59   --  expected_trace.json
lrwxrwxrwx      - stan 16 Jul 12:43   --  Nargo.toml -> ../../execution_success/1_mul/Nargo.toml
lrwxrwxrwx      - stan 16 Jul 12:43   --  Prover.toml -> ../../execution_success/1_mul/Prover.toml

)
Later, we could put all plonky2 tests in one directory and come up with some reuse in the testing scaffolding code.

Sorry for the back-and-forth, but I'd prefer it if we don't pollute the symlinked directory. Then we could easily remove the "daughter" test if we wanted to, by deleting the dir in plonky2_..._regression and there would be no trace that it existed in plonky2_prove_success.
I know deleting tests is not what we should be optimizing for, but I do think that it would make the tests more decoupled/separated.
That's what I meant with the example I quoted in my previous comment: see ls test_programs/plonky2_trace/1_mul/ -l.
What do you think?


Feature request: Allow null values in child or children[] collections to signal that an element should not be drawn

Often I have the problem how to solve toggling the existence of a widget on a screen, like you have a column and you add one child by calling a function that will decide if this child should be added or not. Currently the only solution for this is to return an empty container.
like in this example
              child: Stack(
                children: [
                  Container(
                    child: content,
                  ),
                  buildCloseButton()
                ],

Where buildCloseButton() not will all a Closebutton widget
So I propose that if a null value is found in a child or a children  this is allowed and interpreted that this element should not be drawn.
What do you think?
Cheers and many thanks for your awesome work!

I am not sure the description here is "right".

So I propose that if a null value is found in a child or a children this is allowed and interpreted that this element should not be drawn.
I get this, but "element should not be drawn" is not the correct term. I think this should be that null is allowed as a Widget reference and is ignored.

@slightfoot you are right, ignored is better than not been drawn.
Thanks for clarification

I found out that we can achieve this feature by modifying a line in MultiChildRenderObjectWidget class, something like this:
abstract class MultiChildRenderObjectWidget extends RenderObjectWidget {

  MultiChildRenderObjectWidget({ Key key, List<Widget> children: const <Widget>[] })
    : assert(children != null),
      children = children.where((child) => child != null).toList(), // -> filter and remove null widget
      super(key: key);

  final List<Widget> children;

  @override
  MultiChildRenderObjectElement createElement() => new MultiChildRenderObjectElement(this);
}

But I don't think it's a good idea to do because we have to run a loop to filter out null widgets whenever we create a MultiChildRenderObjectElement widget. Using such a List<Widget> (that contains nullable element) is not common case, so we should do filter job in our own code, for example:
@override
Widget build(BuildContext context) {
   return new Stack(
     children: <Widget>[
        ....
        _buildWidgetIfNeed(),
        ....
        ].where((child) => child != null).toList(),
   );
}

Widget _buildWidgetIfNeed() {
   return (condition) ? new Container(....) : null;
}

I agree it's a bit annoying but I think it's better API design to ensure proper parameter values at the API boundary instead of the requirement to check on multiple places in the implementation if a value is null.
I hope extension methods will make it into Dart eventually, then this should be much cleaner than .where((child) => child != null).toList().

I suspect we're more likely to change the language to allow optional additions to list literals than we are to allow nulls.

How could that look like?

@escamoteur I guess something like #16253. Not sure how this would include filtering nulls though, but I'm sure the Dart and Flutter team will work closely together when they tackle this issue.

@escamoteur, it could look like https://github.com/flutter/flutter/issues/3783#issuecomment-217597619. @munificent began a more in-depth investigation over in https://github.com/munificent/ui-as-code/blob/master/ideas/control-flow-elements.md.

Like @Hixie says, I hope we can solve this in the language and not resort to filtering out nulls. The problem with the latter is that it you have some incorrect code that returns null when you expect it to return a widget, instead of getting an early error that draws your attention correctly to the location of the bug, you just silently get nothing on screen.

I m happy with any improvement putting it in the language will be helpful in other places too.

I don't think to allow null children is good.
Flutter is quite different to react in how it handles components. I doubt there's an easy solution to handle null cases everywhere at once. Worse, it could require user-created widgets to handle null-cases too.
I think Hixie's suggestion is a very good alternative.
In the mean-time, sync* functions can be a pretty good alternative:
@override
Widget build(BuildContext context) {
  return Row(
    children: buildChildren(context).toList(),
  );
}

Iterable<Widget> buildChildren(BuildContext context) sync* {
  yield Container();

  if (myVariable == 42) {
    yield Text("Hello World");
  }
}

@ahmadmarafa Center should allow a null child. Many (if not most) single-child widgets do, such as SizedBox, DecoratedBox, Padding, etc. So you can do Center(child: loading ? CircularProgressIndicator() : null). That said, if Center is part of a child list, then it itself cannot be elided.
@rrousselGit using sync* is a cool idea! I haven't thought of that.

Yeah using yield that way is pretty neat. Maybe a shorthand could be developed to represent it, something like:
  return Row(
    children: sync* <Widget>[
      yield Container();
      if (myVariable == 42)
        yield Text('Hello World');
    ],
  );

...or some such. cc @munificent in case this idea is useful.

Actually I don't think that using yield improves readability. Best is to create the List upfront with .add
Still I think allowing null for single childs instead of passing a SizedBox would be helpful

@escamoteur Well, it allows for everything to be in place. And we get access to a spread operator:
List<Widget> foo;

List<Widget> children = List.from(() sync* {
  yield Text("Foo");
  yield* foo;
  yield Text("Bar");
}());

true but the yield and  sync*don't increase readability

@escamoteur, yield and sync* could be elided if the contents of the list are constructed as comma-separated expressions as opposed to statements. Here's @Hixie's example rewritten:
  return Row(
    children: <Widget>[
      Container(),
      if (myVariable == 42) {
        yield Text('Hello World');
      },
    ],
  );

The yield would still be needed inside the if block because it's just a block of imperative code (i.e. a list of statements). You can do all kinds of things inside it, e.g.:
  return Row(
    children: <Widget>[
      Container(),
      if (myVariable == 42) {
        yield Text('Hello');
        if (isEarth)
          yield Text('Earth');
        else
          yield Text('Mars');
      },
    ],
  );

Taking this further, we could allow unconditional imperative blocks inside list literals, e.g.:
  return Row(
    children: <Widget>[
      Container(),
      {
        yield Text('Hello');
        if (isEarth)
          yield Text('Earth');
        else
          yield Text('Mars');
      },
    ],
  );

Yeah this looks great

That would require modifying every single MultiChildRenderObjectWidget to add that parameter to their constructors.
Tedious, with a very minimal gain.
This would also make migration harder for when we'll have non-nullable types.
sync* functions or a List<T> filterNull<T>(Iterable<T> iterable) function seems like a better compromise.

That would require modifying every single MultiChildRenderObjectWidget to add that parameter to their constructors.

So what? It does not cause performance problems yet it improves readability tremendously.

Tedious, with a very minimal gain.

Improves readability tremendously (the opposite of minimal gain).

This would also make migration harder for when we'll have non-nullable types.
sync* functions or a List filterNull(Iterable iterable) function seems like a better compromise.

I don't see the problem, default removeNullChild to false and it behaves like now, set it to true and it does the null removal for you. All with better readability and no performance hit.

What do you dislike with the following?
children: filterNull([
  ...
])

This is both readable and concise.

This is both readable and concise.

Yes but how would you know that function exists? People will write their own or do the inline monstrosity. As another parameter on the widget constructor, you can't miss it ;)

Even though the proposal here ( #dart-lang/language/issues/47) supports 'null-aware spread' operator, you still need to support single null value removal here.

For single value, you could do something like ...foo, where foo is a list of either 1 or 0 items. e.g. in the original example of buildCloseButton, have that return a list of one widget or an empty list instead of returning a widget or null.

Sure but that complicates things; you basically add the artificial restriction that simple variables can not be used where it makes perfect sense to use them. Simple variables can not be used because they can be null.
If everything now is a list, why not go further and remove the child & children distinction? I mean there is no child just children and when children is a list of 1 that's a child.

I've been experimenting with these If and Empty widgets:
import 'package:flutter/widgets.dart';

typedef Widget WidgetFunction();

class If extends StatelessWidget {
  final bool condition;
  final WidgetFunction then;
  final WidgetFunction or;

  If(this.condition, {@required this.then, this.or});

  @override
  Widget build(BuildContext context) {
    if (condition) {
      return then();
    }

    if (or != null) {
      return or();
    }

    return Empty();
  }
}

class Empty extends Widget {
  @override
  Element createElement() => EmptyElement(this);
}

class EmptyElement extends Element {
  EmptyElement(Widget widget) : super(widget);

  @override
  void forgetChild(Element child) {}

  @override
  void performRebuild() {}
}

Example:
class IfExample extends StatelessWidget {
  final condition = true;

  @override
  Widget build(BuildContext context) {
    return Column(
      children: [
        If(
          condition,
          then: () => Text("You can see me."),
          or: () => Text("I'm not here."),
        ),
        Text("I'm always here."),
        If(
          !condition,
          then: () => Text("You can't see me."),
          or: () => Text("I'm here."),
        )
      ],
    );
  }
}

Any Flutter experts notice anything unnecessary or potentially bad (for performance)?

There is currently a feature being implemented in Dart for the sole purpose of this: https://github.com/dart-lang/language/issues/78
Which basically allows if and for within array declarations.
This is infinitely better than all the other proposed solutions, both in performance and syntax.

Any Flutter experts notice anything unnecessary or potentially bad (for performance)?

Definitely worse than a if.
This has many memory allocations and instructions, including creating a Widget, 2 closures, and an Element and managing all of these.
That's a lot of computation when opposed to a single instruction.

The Empty is already doable without editing Flutter. It's a LeafRenderObjectWidget with a RenderObject that does nothing (besides hit testing).
The gain is unnnoticiable when opposed to a const SizedBox() though.

Ok, for future readers, don't do what I did. Listen to @rrousselGit and use sync* while waiting for Dart improvements.

Control flow collections has landed in Dart and should be available in Flutter either now or shortly.
We may just need documentation at this point illustrating how to use these features to acheive the request in this bug.

Control flow collections does not fit perfectly. It is not possible to check the return value of the function without a temporary variable:
final closeButton = buildCloseButton();
Stack(
    children: [
        Container(child: content),
        if (closeButton != null) closeButton,
    ]
)

It would be great if Dart had a syntax for excluding nulls in array literals, something like:
Stack(
    children: [
        Container(child: content),
        ?buildCloseButton(),
    ]
)

It is not possible to check the return value of the function without a temporary variable

See dart-lang/language#323

Control flow collections has landed in Dart and should be available in Flutter either now or shortly.

Just tested it on my project and Control flow collections is available in flutter

Flutter 1.5.4-hotfix.2 • channel beta • https://github.com/flutter/flutter.git
Framework • revision 7a4c33425d (4 days ago) • 2019-04-29 11:05:24 -0700
Engine • revision 52c7a1e849
Tools • Dart 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)

I would really like this feature too, but Dart now has a new feature called collection if (see http://dart-lang.github.io/linter/lints/prefer_if_elements_to_conditional_expressions.html) that may help in some cases:
childen: [
   ...
   if (condition) widget,
   ...
]

This of course does not help when you want to use myButton(), where myButton is a function returning a widget or null.  I sometimes use myButton() ?? Container() for these cases (probably pretty inefficient too), but this can not always be used, e.g. not when you use a Row of Column with space between elements, e.g. with MainAxisAlignment.spaceBetween.

Additional comment: note that my main concern is that it is not allowed to have null values in widget lists (e.g. children parameters).  I can imagine that allowing null values for every widget in any place (e.g. child parameters) is technically much more complex.  Doing .where((x) => x != null).toList() after a list looks ugly and I'm also wondering how efficient this is.

This of course does not help when you want to use myButton(), where myButton is a function returning a widget or null. I sometimes use myButton() ?? Container() for these cases (probably pretty inefficient too), but this can not always be used, e.g. not when you use a Row of Column with space between elements, e.g. with MainAxisAlignment.spaceBetween.

That's also true for StreamBuilders that does not return a widget for every value of the stream.

I wonder if we can close this issue. As discussed above, this issue is the reason we now have if in Dart's collection literals. I understand this is not the full solution (comment) but that corner case is being tracked over at https://github.com/dart-lang/language/issues/323.
Solving this with null seems increasingly unlikely as Flutter and Dart converge on Non-nullability by default. Having that feature basically means Flutter will have to always check for null for every element in a children lists, which erases the benefits of NNBD for this particular (and very common) case.

I agree the ifs are awesome

I understand this is not the full solution (comment) but that corner case is being tracked over at dart-lang/language#323.

To be fair, that specific case should probably be transformed into:
[
  if (condition)
    buildSomething(),
]

instead of having buildSomething return null.

Now you can handle null value
Row(
mainAxisAlignment: MainAxisAlignment.center,
crossAxisAlignment: CrossAxisAlignment.center,
children: [
Center(child: Text('data1')),
...o.map((element) {
if (element != 4) return Text('yes');
return null;
}),
Center(child: Text('data4')),
].where((element) => element != null).toList()),


[SRCLIC] Add License statement to beginnings of source code files

You know the drill. All the source code files I upload should be prepended with some statement pointing to the appropriate license.

Found more stray non-licensed files in GUITAR XML reading/writing source code.


Add HpToolsLauncher support for Jenkins plugin's integration with MC.

1,Support MC connection Info, including MC server address, username and password, proxy related and ssl related.
2,Support mobile test related info, including device info, application info, launch data and terminate data.

approved


doesn't work

it doesn't work

I kinda need more context

https://www.youtube.com/watch?v=ocChXH73dEA


Add a field for national ID number

Include a field for things like national ID numbers, social security numbers.
Such numbers uniquely identify people in many countries and can assist emergency services to search national databases of medical records, addresses, telephone numbers more easily to find contacts, allergy, medication, etc. (with the person's consent)
In some countries this is regarded as secret information, in others not.  For instance it is not regarded as sensitive information in Norway, see https://www.datatilsynet.no/rettigheter-og-plikter/personopplysninger/fodselsnummer/

this could prob be added to #25 as a first pass until we come up with solid ux rules for adding new fields


Client() constructor results in 400 error if no locale is specified

Issue: When using the Client() constructor without specifying a locale, the underlying request to the Riot API results in a 400 error. It seems the Riot API expects a locale parameter, and not having one causes this error.
Steps to Reproduce:

Initialize the client without specifying a locale:

client = valorant.Client(YOUR_API_KEY)

Observe the 400 error.

Expected Behavior: The library should either provide a default locale (if applicable) or raise a more descriptive error guiding the user to provide the necessary locale parameter.
Temporary Workaround: Specifying locale=None when initializing the client appears to prevent this error:
client = valorant.Client(YOUR_API_KEY, locale=None)

Thanks for opening an issue. This might be a more recent change to their API endpoints because this has never raised any errors before. I'll look into this later tonight and get back to you.


prometheus-cups-exporter: This shouldn't be packaged

This exporter is outdated, broken by design and simply shouldn't be packaged.
Motivation for this change
There is no point in having this garbage version as a package. For peace of mind I want it gone.
Things done
Deleted the according .nix file created in #67634

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Some comments:

You need to remove it from pkgs/top-level/all-packages.nix.
You should add an alias to pkgs/top-level/aliases.nix stating why it was removed.
If it were me, I'd reword the commit to be prometheus-cups-exporter: remove or ...: drop.

@cole-h Thanks for the remarks, I fixed these points.


Need to address what impact on D365 Services going into maintenance mode has

Maintenance mode has a number of consequences. However, this page does not talk about what impact on D365 services like DXF and Batch services maintenance mode has. Please include this information.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 91ae449b-ec59-28d4-1934-6909e77ee4f3
Version Independent ID: df6ae442-3466-4c69-aa11-ed35e20a629f
Content: Maintenance mode - Finance & Operations | Dynamics 365
Content Source: articles/fin-ops-core/dev-itpro/sysadmin/maintenance-mode.md
Service: dynamics-ax-platform
Product: ****
Technology: ****
GitHub Login: @laneswenka
Microsoft Alias: laswenka

@ronsonntag54, thanks for the feedback.
@laneswenka, please review.

Bug 541330 logged to track this issue.

Bug 541330 logged to track this issue.

@ronsonntag54 what impacts are you referring to?  I am not readily aware of any adverse impact by turning maintenance mode on and then off again, that would continue to affect batch or DIXF.  The article does state "While maintenance mode is on, only system administrators and users who have the Maintenance mode user role can sign in to the system"

Sorry, this is so long ago that I don't remember the context. Might as well close this if there are no consequences.


[KBM] Shortcuts remapped to Win key fail to open start menu sometimes

ℹ Computer information

PowerToys version: 0.23/master
PowerToy Utility: KBM
Running PowerToys as Admin: No
Windows build number: [run "winver"] 2004

📝 Provide detailed reproduction steps (if any)

Remap Ctrl+D->Win(left)
Press Ctrl+D and release D
Press and release D several times

✔ Expected result
What is the expected result of the above steps?
Start menu should open and close consistently
❌ Actual result
What is the actual result of the above steps?
Start menu does not open sometimes or flashes sometimes.
📷 Screenshots
Are there any useful screenshots? WinKey+Shift+S and then just paste them directly into the form

@crutkas @ryanbodrug-microsoft @saahmedm I'm adding the P0 tag on this since it's broken functionality and I've found a potential fix which I need to test a bit more.

Added in 0.25.  https://github.com/microsoft/PowerToys/releases/tag/v0.25.0


maude: 3.3.1 -> 3.4

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 331988 run on x86_64-linux 1

1 package failed to build:

tamarin-prover

1 package built:

maude

Seems to be caused by https://github.com/tamarin-prover/tamarin-prover/blob/7b79a738b75c6fc8825614c23e3dc43381d3a203/src/Main/Console.hs#L176

Result of nixpkgs-review pr 331988 run on x86_64-linux 1
1 package failed to build:
1 package built:
Seems to be caused by https://github.com/tamarin-prover/tamarin-prover/blob/7b79a738b75c6fc8825614c23e3dc43381d3a203/src/Main/Console.hs#L176

Thanks for the information. I created a pull request to update Maude in the tamarin-prover.

Once my pull request to tamarin-prover is merged and the package is updated, it should work.

Mark it as draft then please, so we don't spend time on this yet.

My pull request to tamarin-prover was merged. They aim for a release in mid-September, which would include my fix.
I will wait with this pull request until a new release of the prover, which then becomes compatible with the new Maude version.

Tamarin 1.10 is out. See #352371.

Looks good. When that is merged we can move forward with this pull-request.

Tamarin 1.10 is merged so the tests should not fail anymore.

@GrahamcOfBorg maude tamarin-prover