eslint-config-react-native-community package need to update

Description
Problem
There are many no-shadow and no-undef lint errors while using<EMAIL_ADDRESS>Description
<EMAIL_ADDRESS>has updated @typescript-eslint/parser to 4.33.0. And there are some behaviors have been changed since<EMAIL_ADDRESS>so @react-native-community/eslint-config need to update.
For example. no-undef is recommended to be off after<EMAIL_ADDRESS>but this rule in<EMAIL_ADDRESS>is missing.
And I notice that these new rules are actually existed in current file already. So I think the problem will be resolved if you just publish a new version that includes the new rules.
Version
0.63.3
Output of npx react-native info
System:
OS: macOS 11.3.1
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 1.55 GB / 16.00 GB
Shell: 5.8 - /bin/zsh
Binaries:
Node: 14.17.3 - ~/.nvm/versions/node/v14.17.3/bin/node
Yarn: 1.22.17 - /usr/local/bin/yarn
npm: 6.14.13 - ~/.nvm/versions/node/v14.17.3/bin/npm
Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
Managers:
CocoaPods: 1.10.1 - /usr/local/bin/pod
SDKs:
iOS SDK:
Platforms: iOS 14.5, DriverKit 20.4, macOS 11.3, tvOS 14.5, watchOS 7.4
Android SDK: Not Found
IDEs:
Android Studio: Not Found
Xcode: 12.5.1/12E507 - /usr/bin/xcodebuild
Languages:
Java: Not Found
Python: 2.7.16 - /usr/bin/python
npmPackages:
@react-native-community/cli: Not Found
react: 16.13.1 => 16.13.1
react-native: 0.63.3 => 0.63.3
react-native-macos: Not Found
npmGlobalPackages:
react-native: Not Found
Steps to reproduce

install<EMAIL_ADDRESS>and<EMAIL_ADDRESS>
yarn add<EMAIL_ADDRESS><EMAIL_ADDRESS>-D

extends @react-native-community in your eslint config file.

// .eslintrc.js
module.exports = {
  extends: '@react-native-community',
}

run lint script.

eslint -c --ext .js,.ts,.tsx  src/

Snack, code example, screenshot, or link to a repository
Code
export interface Props {
  children: React.ReactElement;
}

Error
11:34  error  'React' is not defined  no-undef

Temporary fix in your package.json (if you are using Yarn):
  "resolutions": {
    "@typescript-eslint/eslint-plugin": "5.15.0",
    "@typescript-eslint/parser": "5.15.0"
  },

to force @react-native-community/eslint-config to use 5.15.0 typescript eslint parser.

Looks like the necessary changes have already been merged: https://github.com/facebook/react-native/pull/32800
Just missing npm publish

Any updates on this?

Just missing npm publish

Just published 👍

@cortinico  Why still 7?
https://github.com/facebook/react-native/blob/763dc5238721a21847b6d6670b5fa268e3bf2ed4/packages/eslint-config-react-native-community/package.json#L28

@cortinico Hi, a new PR (https://github.com/facebook/react-native/commit/f3db6cc52792e3006a16408df4ae40f3aee19a86) has landed that updates this package to work with ESLint 8. Would it be possible to publish a new release of this package?
I was going to submit a separate PR to upgrade the version of this package used in the template, but thought it might be more worthwhile to wait until the ESLint 8 support has been finalised first.

Doing it here:

https://github.com/facebook/react-native/pull/34307

Just pulished on NPM 👍

Thanks so much @cortinico! I'm just testing it now with ESLint 8 and so far all looking great. If all goes well, I'll submit a PR to update the dependencies in the template.


Add image dithering filter to build low-tech websites

It would be great to be able to select a filter to dither image and reduce final website size in image processing. The lowtech magazine use a filter to dither images. We could have the same in hugo by using this library and it could be selecting in image processing filters.

We could add this if we could do it by not adding another dependency. I think the standard library has a simple dithering filter, which I think should be good enough for this.

I want to solve this issue

hi @bep
Is there any documentation for debugging and testing for hugo project? I have changed in filter.go add add some file. But after I run mage install, the change does not work. Is I miss something?

Ok, Please explain the features of the dithering image. If any input and output images will be very helpful.

I don't have any stake in this other than that I'll most likely end up maintaining what's added. But I was originally thinking about using draw.FloydSteinberg ... but I haven't researched this.
https://golang.org/pkg/image/draw/

https://github.com/disintegration/gift/issues/25

hi bep, Could I use draw.FloydSteinberg (but I modified it) to implement gift.Filter?
Or Is there another approach?
thanks


Updated MCVE to reprex to mirror StackOverflow's changes

Related to issue #127. Not sure if we'd also want to change the permalink and file name.

@WillSullivan Looks fine. Shall we merge this?


[feature request] RENAME FIELD

From https://github.com/influxdb/influxdb/issues/828#issuecomment-83224779
e.g. RENAME FIELD foo TO bar ON measurement
Would have to update all CQs, too.

+1, this would actually be useful

+1

+1

Consider the case where I am downsampling data to another database using a back reference.
SELECT MEAN(*) INTO "db_history"."autogen".:MEASUREMENT FROM /.*/ WHERE time <= now()-10d GROUP BY time(1h)
The field that was previously named value will now be mean_value. This makes it even harder to create dashboards since the field name is always different.
Alternatively it would be even better to just not generate a name but allow a 'AS' operator on the select.
SELECT MEAN(*) AS "value" INTO "db_history"."autogen".:MEASUREMENT FROM /.*/ WHERE time <= now()-10d GROUP BY time(1h)

What about fields with multiple types?
In my opinion allowing something like
RENAME FIELD foo::float TO bar ON measurement
would be a cool addition, which could also help a lot if actually only one type was intended but the ambiguity was introduced by default.

Please reopen as it's not been implemented. Thanks.
https://github.com/influxdata/influxdb/issues/828#issuecomment-1013723202

mind numbing lack of basic functionality


Expose ScriptEditor::edit to scripting

Exposes a method in EditorInterface to open scripts on a specified line and column.
This method handles if the internal or the external editor should be used.
Without this method, users can only use EditorInterface::edit_resource to open scripts but can't specify a line and/or column position.
Closes #52294.

would be very nice to back port to 3.4 when is approved.

Thanks!

Cherry-picked for 3.5.

Cherry-picked for 3.4.1.


Move library to newest ReactNative / React version

If you start using a new navigation library, you want to be using the newest RN version anyway.

Done!


Configure credentials using Pulumi secrets

Hello!

Vote on this issue by adding a 👍 reaction
If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details
It would be nice if it was possible to set the Akamai configuration as Pulumi secrets in the stack config file. From what I can tell, it's only possible to authenticate against Akamai using an .edgerc-file, or having the equivalent properties set as environment variables.
It would help in keeping the credentials more secure when working with Pulumi in the local dev environment.
Affected area/feature
?

This is enabled (but doesn't work): https://github.com/pulumi/pulumi-akamai/issues/339.


[false positive] bitbucket.org blocked

Hi,
bitbucket.org, a code-sharing platform like github.com, is being blocked.
Entry is listed here https://github.com/hectorm/hmirror/blob/890839365d7350aa1babfdcad62de67ba178f5c8/data/digitalside-threat-intel/list.txt#L6
This is clearly a false positive. Can this entry be removed please?

I see that the problem is already reported upstream (davidonzo/Threat-Intel#20) and I've released a new hBlock version removing this list.
I don't have much more to do on my side so I'm going to close this issue.
Thanks for the notice!

Domain whitelested.
Please, wait some minutes until the lists will be generated and published.
Thanks for the notice.

You're welcome! :grin:


Added pthread for correct build with gtest on linux

On linux build error
../../deps/googletest/build/googlemock/gtest/libgtest.a(gtest-all.cc.o): In function `testing::internal::ThreadLocal<testing::TestPartResultReporterInterface*>::~ThreadLocal()':
gtest-all.cc:(.text._ZN7testing8internal11ThreadLocalIPNS_31TestPartResultReporterInterfaceEED2Ev[_ZN7testing8internal11ThreadLocalIPNS_31TestPartResultReporterInterfaceEED5Ev]+0x24): undefined reference to `pthread_getspecific'
gtest-all.cc:(.text._ZN7testing8internal11ThreadLocalIPNS_31TestPartResultReporterInterfaceEED2Ev[_ZN7testing8internal11ThreadLocalIPNS_31TestPartResultReporterInterfaceEED5Ev]+0x39): undefined reference to `pthread_key_delete'

You shouldn't use pthreads directly. Probably it's enough to replace this line:
PRIVATE ${CMAKE_THREAD_LIBS_INIT}

With this one:
PRIVATE Threads::Threads

In test/CMakeLists.txt. Does it work for you?

Added travis support (see c8a5f7a) on master. On linux everything compiles just fine.
I cannot accept this PR as it is. Feel free to reopen it if you have any update.
Thank you.


CCMv2 support in EU Control Plane

Hello again,
We are trying to provision the CDP environment via the Ansible collection (https://cloudera-labs.github.io/cloudera.cloud/env.html ) and failing miserably with the following error. We are using the tunnel option set to true since this is how we understood that CCM is enabled.
FreeIpa creation operation failed. Reason: 'com.sequenceiq.cloudbreak.ccm.exception.CcmException: MinaSshdManagementService acquireMinaSshdService gRPC call failed: UNAVAILABLE: Unable to resolve host thunderhead-clusterconnectivitymanagement.thunderhead-clusterconnectivitymanagement.svc.cluster.local'

I will take a leap of faith and assume the following : the Ansible code wants to use (via the Python REST API) CCMv1 and this is not available in the EU Control Plane, as per https://docs.cloudera.com/cdp-public-cloud/cloud/requirements-aws/topics/cdp-control-plane-regions.html. Was looking a bit into the Python REST API to see if we could implement this ourselves https://cloudera.github.io/cdp-dev-docs/api-docs/environments/index.html#_createawsenvironmentrequest but could not see much around how to specify that even via the REST API.
Can you please tell me if my assumption is correct ? Any ideas on how we can keep using CCM in the EU region?

I believe this issue has been resolved with updates to the CDP control plane (the REST API). We will test this further and will reopen the ticket if we run into issues.


pull request for e2e test at 12/02/2016 04:26:31

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


[A11y] Make aria-hidden elements not focusable

Addresses https://github.com/NuGet/NuGetGallery/issues/9299

Tested in dev environment. The prefix reserved icon and title are no longer focused on when traversing the page via the tab key.


(MODULES-8172) Sensitive fixes across versions

Builds on #387

Puppet 5 agents connected to Puppet 6 masters and Puppet 6 agents
connected to Puppet 5 masters don't properly deserialize Sensitive
values from catalogs.
The type generation template has been updated with the inclusion
of support to fix this.
This commit includes the same fixes in the generated types.

Note: Due to issues with the build process, the rake tasks were not
run over the existing content to produce these files.
Instead, a regex search replace was performed using the following:
search pattern:
(?s)(validate_MSFT_Credential.*?end)
replacement:
$1\n    munge do |value|\n      PuppetX::Dsc::TypeHelpers.munge_sensitive_hash!(value)\n    end

Since there are a lot of matches, we can just do a count, knowing that for every call to validate_MSFT_Credential should also have a call to munge_sensitive_hash!
Validations:
cat lib/puppet/type/* | grep -c validate_MSFT_Credential
720

Munges:
cat lib/puppet/type/* | grep -c munge_sensitive_hash!
720

It's a match!


Question: saving audio files

Less of an issue, more of a question.
The plugin works great. However I am struggling to find where the audio files save to, is it a temporary location for playback? Or do these files get put somewhere special? Playback is working fine but I'm wondering where it is playing from.
Should I be using something like react-native-fs for saving the file?

Hey !
This plugin offers an AudioUtils object that exposes directories in which you can save.
Android
MainBundlePath
CachesDirectoryPath
DocumentDirectoryPath
LibraryDirectoryPath
PicturesDirectoryPath
MusicDirectoryPath
DownloadsDirectoryPath

iOS
MainBundlePath
CachesDirectoryPath
DocumentDirectoryPath
LibraryDirectoryPath

This component should be enough if you just want to save the file locally :
import { AudioUtils, AudioRecorder, AudioPlayer } from 'react-native-audio';
const myAudioRecorder = {
  record(audioFileName){
    const audioPath = AudioUtils.DocumentDirectoryPath+audioFileName;
    AudioRecorder.prepareRecordingAtPath(audioPath, {
      SampleRate: 22050,
      Channels: 1,
      AudioQuality: "Low",
      AudioEncoding: "aac"
    });
  }
  play(audioFileName){
    const audioPath = AudioUtils.DocumentDirectoryPath+audioFileName;
    // Promise only in android for now.
    AudioPlayer.play(audioPath).then(play => {
        }).catch((err)=>{
          console.warn(err);});
        })
  }
};

If you want to upload and download voice files then using react-native-fs would be a great idea.
Cheers !

Will this show up when browsing the file system? The files are perfect for playback but I can't seem to find them anywhere?
Thank you.

Fixed the example I forgot to add startRecording.
After recording it creates the file at AudioUtils.DocumentDirectoryPath+audioFileName
Log the variable to check where the file is stored.

Thank you sooooo much! I found them with ease. I struggled with finding the files when browsing using the computer's file browser but when I checked on the phone with a file explorer there it was sitting there. Thanks a ton.

You're welcome :)
Cheers !

@RakanNimer, are you sure MainBundlePath is working for Android? https://github.com/jsierles/react-native-audio/blob/9d5e36e31831a2ef1ae7272d4c3141c945dfd89b/android/src/main/java/com/rnim/rn/audio/AudioRecorderManager.java#L63


compile new protobufs

looks like existing *_pb.rb files are missing sorted set APIs

https://github.com/momentohq/client-sdk-ruby/pull/135


#388 migrate org.jpeek.web to junit 5

Resolve puzzle in #388

This pull request #391 is assigned to @fanifieiev/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@fanifieiev ping

@paulodamaso good to merge

@paulodamaso ping

@HDouss please solve conflicts

@paulodamaso Done!

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@hdouss @paulodamaso Oops, I failed. You can see the full log here (spent 2min)
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export 'MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ MAVEN_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export 'JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ JAVA_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export head=git@github.com:yegor256/jpeek.git
+ head=git@github.com:yegor256/jpeek.git
+ export pull_id=391
+ pull_id=391
+ export fork=git@github.com:HDouss/jpeek.git
+ fork=git@github.com:HDouss/jpeek.git
+ export fork_branch=#388
+ fork_branch='#388'
+ export head_branch=master
+ head_branch=master
+ export 'pull_title=#388 migrate org.jpeek.web to junit 5'
+ pull_title='#388 migrate org.jpeek.web to junit 5'
+ export author=paulodamaso
+ author=paulodamaso
+ sudo -i gem install pdd -v 0.20.5
Fetching pdd-0.20.5.gem
Fetching nokogiri-1.10.3.gem
Fetching slop-4.6.1.gem
Fetching mini_portile2-2.4.0.gem
Fetching rainbow-3.0.0.gem
Successfully installed mini_portile2-2.4.0
Building native extensions. This could take a while...
Successfully installed nokogiri-1.10.3
Successfully installed rainbow-3.0.0
Successfully installed slop-4.6.1
Successfully installed pdd-0.20.5
Parsing documentation for mini_portile2-2.4.0
Installing ri documentation for mini_portile2-2.4.0
Parsing documentation for nokogiri-1.10.3
Installing ri documentation for nokogiri-1.10.3
Parsing documentation for rainbow-3.0.0
Installing ri documentation for rainbow-3.0.0
Parsing documentation for slop-4.6.1
Installing ri documentation for slop-4.6.1
Parsing documentation for pdd-0.20.5
Installing ri documentation for pdd-0.20.5
Done installing documentation for mini_portile2, nokogiri, rainbow, slop, pdd after 3 seconds
5 gems installed
+ sudo -i gem install xcop
Fetching differ-0.1.2.gem
Fetching xcop-0.6.gem
Successfully installed differ-0.1.2
Successfully installed xcop-0.6
Parsing documentation for differ-0.1.2
Installing ri documentation for differ-0.1.2
Parsing documentation for xcop-0.6
Installing ri documentation for xcop-0.6
Done installing documentation for differ, xcop after 0 seconds
2 gems installed
+ pdd -f /dev/null
/home/r/script.sh: line 9: pdd: command not found
container 434ebb211e2fe852b2819be0ee915f7160296e72697767a7ca5c206b0c38b507 is dead
Wed Feb 26 15:19:23 CET 2020

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@hdouss @paulodamaso Oops, I failed. You can see the full log here (spent 2min)
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export 'MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ MAVEN_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export 'JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ JAVA_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export head=git@github.com:yegor256/jpeek.git
+ head=git@github.com:yegor256/jpeek.git
+ export pull_id=391
+ pull_id=391
+ export fork=git@github.com:HDouss/jpeek.git
+ fork=git@github.com:HDouss/jpeek.git
+ export fork_branch=#388
+ fork_branch='#388'
+ export head_branch=master
+ head_branch=master
+ export 'pull_title=#388 migrate org.jpeek.web to junit 5'
+ pull_title='#388 migrate org.jpeek.web to junit 5'
+ export author=paulodamaso
+ author=paulodamaso
+ sudo -i gem install pdd -v 0.20.5
Fetching nokogiri-1.10.3.gem
Fetching pdd-0.20.5.gem
Fetching mini_portile2-2.4.0.gem
Fetching slop-4.6.1.gem
Fetching rainbow-3.0.0.gem
Successfully installed mini_portile2-2.4.0
Building native extensions. This could take a while...
Successfully installed nokogiri-1.10.3
Successfully installed rainbow-3.0.0
Successfully installed slop-4.6.1
Successfully installed pdd-0.20.5
Parsing documentation for mini_portile2-2.4.0
Installing ri documentation for mini_portile2-2.4.0
Parsing documentation for nokogiri-1.10.3
Installing ri documentation for nokogiri-1.10.3
Parsing documentation for rainbow-3.0.0
Installing ri documentation for rainbow-3.0.0
Parsing documentation for slop-4.6.1
Installing ri documentation for slop-4.6.1
Parsing documentation for pdd-0.20.5
Installing ri documentation for pdd-0.20.5
Done installing documentation for mini_portile2, nokogiri, rainbow, slop, pdd after 3 seconds
5 gems installed
+ sudo -i gem install xcop
Fetching differ-0.1.2.gem
Fetching xcop-0.6.gem
Successfully installed differ-0.1.2
Successfully installed xcop-0.6
Parsing documentation for differ-0.1.2
Installing ri documentation for differ-0.1.2
Parsing documentation for xcop-0.6
Installing ri documentation for xcop-0.6
Done installing documentation for differ, xcop after 0 seconds
2 gems installed
+ pdd -f /dev/null
/home/r/script.sh: line 9: pdd: command not found
container d54473dfbd25b649fee760537e02b3ac42beef564f62805fbab7967eab77f7e6 is dead
Wed Feb 26 15:31:56 CET 2020

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@hdouss @paulodamaso Oops, I failed. You can see the full log here (spent 2min)
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export 'MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ MAVEN_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export 'JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ JAVA_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export head=git@github.com:yegor256/jpeek.git
+ head=git@github.com:yegor256/jpeek.git
+ export pull_id=391
+ pull_id=391
+ export fork=git@github.com:HDouss/jpeek.git
+ fork=git@github.com:HDouss/jpeek.git
+ export fork_branch=#388
+ fork_branch='#388'
+ export head_branch=master
+ head_branch=master
+ export 'pull_title=#388 migrate org.jpeek.web to junit 5'
+ pull_title='#388 migrate org.jpeek.web to junit 5'
+ export author=paulodamaso
+ author=paulodamaso
+ sudo -i gem install pdd -v 0.20.5
Fetching nokogiri-1.10.3.gem
Fetching pdd-0.20.5.gem
Fetching mini_portile2-2.4.0.gem
Fetching rainbow-3.0.0.gem
Fetching slop-4.6.1.gem
Successfully installed mini_portile2-2.4.0
Building native extensions. This could take a while...
Successfully installed nokogiri-1.10.3
Successfully installed rainbow-3.0.0
Successfully installed slop-4.6.1
Successfully installed pdd-0.20.5
Parsing documentation for mini_portile2-2.4.0
Installing ri documentation for mini_portile2-2.4.0
Parsing documentation for nokogiri-1.10.3
Installing ri documentation for nokogiri-1.10.3
Parsing documentation for rainbow-3.0.0
Installing ri documentation for rainbow-3.0.0
Parsing documentation for slop-4.6.1
Installing ri documentation for slop-4.6.1
Parsing documentation for pdd-0.20.5
Installing ri documentation for pdd-0.20.5
Done installing documentation for mini_portile2, nokogiri, rainbow, slop, pdd after 3 seconds
5 gems installed
+ sudo -i gem install xcop
Fetching differ-0.1.2.gem
Fetching xcop-0.6.gem
Successfully installed differ-0.1.2
Successfully installed xcop-0.6
Parsing documentation for differ-0.1.2
Installing ri documentation for differ-0.1.2
Parsing documentation for xcop-0.6
Installing ri documentation for xcop-0.6
Done installing documentation for differ, xcop after 0 seconds
2 gems installed
+ pdd -f /dev/null
/home/r/script.sh: line 9: pdd: command not found
container 810c1ce34f1164e6ec4118d27efea81225f37399a889300c46e7f4c07acaf6cf is dead
Wed Feb 26 15:49:47 CET 2020

@paulodamaso Are you sure rultor is taking its config from master, and not from this branch? If you are sure your modifications in 801486c are the solution, I can remerge master.

@paulodamaso merged again. Could you please try to merge again?

@paulodamaso ping

@fanifieiev/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

@rultor merge

@rultor merge

@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here

@rultor merge

@hdouss @paulodamaso Oops, I failed. You can see the full log here (spent 2min)
+ export HOME=/home/r
+ HOME=/home/r
+ cd /home/r/repo
+ export 'MAVEN_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ MAVEN_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export 'JAVA_OPTS=-XX:MaxPermSize=256m -Xmx1g'
+ JAVA_OPTS='-XX:MaxPermSize=256m -Xmx1g'
+ export head=git@github.com:yegor256/jpeek.git
+ head=git@github.com:yegor256/jpeek.git
+ export pull_id=391
+ pull_id=391
+ export fork=git@github.com:HDouss/jpeek.git
+ fork=git@github.com:HDouss/jpeek.git
+ export fork_branch=#388
+ fork_branch='#388'
+ export head_branch=master
+ head_branch=master
+ export 'pull_title=#388 migrate org.jpeek.web to junit 5'
+ pull_title='#388 migrate org.jpeek.web to junit 5'
+ export author=paulodamaso
+ author=paulodamaso
+ sudo -i gem install pdd -v 0.20.5
Fetching pdd-0.20.5.gem
Fetching rainbow-3.0.0.gem
Fetching nokogiri-1.10.3.gem
Fetching slop-4.6.1.gem
Fetching mini_portile2-2.4.0.gem
Successfully installed mini_portile2-2.4.0
Building native extensions. This could take a while...
Successfully installed nokogiri-1.10.3
Successfully installed rainbow-3.0.0
Successfully installed slop-4.6.1
Successfully installed pdd-0.20.5
Parsing documentation for mini_portile2-2.4.0
Installing ri documentation for mini_portile2-2.4.0
Parsing documentation for nokogiri-1.10.3
Installing ri documentation for nokogiri-1.10.3
Parsing documentation for rainbow-3.0.0
Installing ri documentation for rainbow-3.0.0
Parsing documentation for slop-4.6.1
Installing ri documentation for slop-4.6.1
Parsing documentation for pdd-0.20.5
Installing ri documentation for pdd-0.20.5
Done installing documentation for mini_portile2, nokogiri, rainbow, slop, pdd after 3 seconds
5 gems installed
+ sudo -i gem install xcop
Fetching xcop-0.6.gem
Fetching differ-0.1.2.gem
Successfully installed differ-0.1.2
Successfully installed xcop-0.6
Parsing documentation for differ-0.1.2
Installing ri documentation for differ-0.1.2
Parsing documentation for xcop-0.6
Installing ri documentation for xcop-0.6
Done installing documentation for differ, xcop after 0 seconds
2 gems installed
+ pdd -f /dev/null
/home/r/script.sh: line 9: pdd: command not found
container 7dcd002cb7ca4e12521e2be1cb74523bb22358a146ab13f160a1f6bc993445eb is dead
Thu Feb 27 03:55:15 CET 2020

@paulodamaso Could we merge this also?

@sereshqua/z please review this job completed by @fanifieiev/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

@fanifieiev please make sure you will try to find at least 3 issues during next CR, thanks

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @paulodamaso/z

@fanifieiev please make sure you will try to find at least 3 issues during next CR, thanks

@sereshqua Got it! Sorry for making that happen again and again.

@0crat quality acceptable

Order was finished, quality is "acceptable": +15 point(s) just awarded to @fanifieiev/z

Quality review completed: +4 point(s) just awarded to @sereshqua/z


DEV: Screen is flickering while opening Timezone Page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:
1 Open app
2 Go Settings > Security > Profile > Timezone
Expected Result:
no flickering while opening Timezone Page
Actual Result:
flickering while opening Timezone Page
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android / native
[ ] Android / Chrome
[ ] iOS / native
[ ] iOS / Safari
[x] MacOS / Chrome / Safari
[ ] MacOS / Desktop

Version Number:  Dev
Reproducible in staging?: Main
Reproducible in production?: Main
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
https://github.com/Expensify/App/assets/43996225/1e78e661-5ffa-4a3e-8bfe-ca7ca1a296a4
Expensify/Expensify Issue URL:
Issue reported by: @narzullome
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1687244449128499
View all open jobs on GitHub

Proposal
Screen flickering while opening Timezone Page
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The issue of screen flickering while opening the Timezone Page is caused by the re-rendering of the component in TimezoneSelectpage.js  due to the state update in the componentDidUpdate method of the TimezoneSelectPage component.
What changes do you think we should make in order to solve the problem?
To resolve the flickering issue, The Code can optimize  by updating the state only when necessary, avoiding unnecessary re-rendering. Here's an updated version of the componentDidUpdate method that addresses the issue
To update code this changes are required
`componentDidUpdate(prevProps) {
const prevUserTimezone = this.getUserTimezone(prevProps.currentUserPersonalDetails);
const currentUserTimezone = this.getUserTimezone(this.props.currentUserPersonalDetails);
if (prevUserTimezone !== currentUserTimezone) {
    this.updateTimezoneOptions(currentUserTimezone);
}

}
updateTimezoneOptions(timezone) {
const selectedTimezone = timezone.selected;
const filteredTimezones = _.filter(this.allTimezones, (tz) =>
tz.text.toLowerCase().includes(selectedTimezone.trim().toLowerCase())
);
this.setState({
    timezoneInputText: selectedTimezone,
    timezoneOptions: filteredTimezones,
});

}`
By comparing the previous user timezone with the current user timezone in componentDidUpdate, we can determine whether the timezone options need to be updated. If there's a difference, the updateTimezoneOptions function is called to filter the timezones and update the state accordingly.

Proposal
Screen flickering while opening Timezone Page
Please re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
The issue of screen flickering while opening the Timezone Page is caused by the re-rendering of the component in TimezoneSelectpage.js  due to the state update in the componentDidUpdate method of the TimezoneSelectPage component.
What changes do you think we should make in order to solve the problem?
To resolve the flickering issue, The Code can optimize  by updating the state only when necessary, avoiding unnecessary re-rendering. Here's an updated version of the componentDidUpdate method that addresses the issue
To update code this changes are required
`componentDidUpdate(prevProps) {
const prevUserTimezone = this.getUserTimezone(prevProps.currentUserPersonalDetails);
const currentUserTimezone = this.getUserTimezone(this.props.currentUserPersonalDetails);
if (prevUserTimezone !== currentUserTimezone) {
    this.updateTimezoneOptions(currentUserTimezone);
}

}
updateTimezoneOptions(timezone) {
const selectedTimezone = timezone.selected;
const filteredTimezones = _.filter(this.allTimezones, (tz) =>
tz.text.toLowerCase().includes(selectedTimezone.trim().toLowerCase())
);
this.setState({
    timezoneInputText: selectedTimezone,
    timezoneOptions: filteredTimezones,
});

}`
By comparing the previous user timezone with the current user timezone in componentDidUpdate, we can determine whether the timezone options need to be updated. If there's a difference, the updateTimezoneOptions function is called to filter the timezones and update the state accordingly.

@kavimuru - will you clarify the testing steps outlined in the OP? I'm not able to reproduce this on main when i do the following:

click settings
click into the security tab
click back to settings
click profile
click timezone
change timezone

https://github.com/Expensify/App/assets/38016013/ea87fc78-cd0b-42d4-a65a-c504f2cb4461

@maddylewis on the video u attached - here new expensify - can u check on local host dev as its reproducible there

hiya @thienlnam - i do not have a dev environment set up so adding the eng label to see if you can reproduce this one (going off of this comment here https://expensify.slack.com/archives/C01SKUP7QR0/p1675251726213049?thread_ts=1675251470.410809&cid=C01SKUP7QR0).
if you can repro, i will go through the normal BZ steps and unassign you from the issue. i appreciate the assistance!

I can't reproduce this locally in dev!


Allow more flexible field access in recover blocks: local fields and sendable writes

I should have opened this ages ago, but this change always allows simple assignments with variables defined locally:
x.y = e, x.y.z.q = e
Soundness can be seen because this functionality is possible today using methods, it is just very cumbersome.
This also includes a change to enable field-writes to non-local variables when the destination is sendable (this is slightly less than the most general: which would include writing a sendable expression to any field; but that requires adding more check logic). The current checks had very strange logic, and don't seem to be necessary: We only need to maintain isolation of the recover region, so it's perfectly fine to move sendable items in or out without restriction, since they cannot violate the guarantees. See https://github.com/ponylang/ponyc/pull/1057 for context of those original changes.
Fixes https://github.com/ponylang/ponyc/issues/3069

That's why I never opened this, I didn't rigorously test deep field accesses: they won't work with the unnecessary block on assignment. I had only checked them without it and never made the unit test

May need to add/remove/merge unit tests still to ensure the right behavior is covered, but this is set to review.

Windows CI is failing because of one variable which is used in a single case branch, complaining that it's not initialized elsewhere, which is technically true, but missing the point

I don't know this code at all. I'm leaving this in @jemc's hands as I consider him the "domain expert".

@jasoncarr0 can you rebase this against master?

For a moment I was excited at how easy the suggestions feature made it and then I realized I still needed to change the callsite :sweat_smile:

@jasoncarr0 can you add public facing release notes to https://github.com/ponylang/ponyc/issues/3605 for this?


Bug: Fixed wrong paid by Name in Reimbursement

Related issue #133
Default selected user was getting updated in paid-by field, even by user select a normal reimbursement transaction.
Working Demo
https://www.loom.com/share/20b999695b23402a8a313350084cf2ca?sid=eedd3056-e1df-4c83-81ec-ddca16257ccd

Thanks @sahilmhr 💯


coding standard == PSR ?

composer require "squizlabs/php_codesniffer=*"

dopo aver messo a posto l'indentazione per liberarsi dei banali Line indented incorrectly; expected 0 spaces, found 4 per PSR-1 ottengo:
./vendor/squizlabs/php_codesniffer/bin/phpcs --standard=PSR1 spid-php.php
...
---------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
 1 | WARNING | A file should declare new symbols (classes, functions, constants, etc.) and
   |         | cause no other side effects, or it should execute logic with side effects,
   |         | but should not do both. The first symbol is defined on line 5 and the first
   |         | side effect is on line 3.
 5 | ERROR   | Each class must be in a namespace of at least one level (a top-level vendor
   |         | name)
 5 | ERROR   | Class name "SPID_PHP" is not in camel caps format
---------------------------------------------------------------------------------------------

e con PSR2:
./vendor/squizlabs/php_codesniffer/bin/phpcs --standard=PSR2 spid-php.php
---------------------------------------------------------------------------------------------
FOUND 13 ERRORS AND 2 WARNINGS AFFECTING 12 LINES
---------------------------------------------------------------------------------------------
  1 | WARNING | [ ] A file should declare new symbols (classes, functions, constants, etc.)
    |         |     and cause no other side effects, or it should execute logic with side
    |         |     effects, but should not do both. The first symbol is defined on line 5
    |         |     and the first side effect is on line 3.
  5 | ERROR   | [ ] Each class must be in a namespace of at least one level (a top-level
    |         |     vendor name)
  5 | ERROR   | [ ] Class name "SPID_PHP" is not in camel caps format
  5 | ERROR   | [x] Opening brace of a class must be on the line after the definition
  8 | ERROR   | [ ] Visibility must be declared on method "__construct"
  8 | ERROR   | [x] Opening brace should be on a new line
 12 | ERROR   | [x] Opening brace should be on a new line
 16 | ERROR   | [x] Opening brace should be on a new line
 20 | ERROR   | [x] Opening brace should be on a new line
 24 | ERROR   | [x] Opening brace should be on a new line
 28 | ERROR   | [x] Opening brace should be on a new line
 33 | ERROR   | [x] Opening brace should be on a new line
 37 | ERROR   | [x] Opening brace should be on a new line
 43 | WARNING | [ ] Line exceeds 120 characters; contains 128 characters
 54 | ERROR   | [x] A closing tag is not permitted at the end of a PHP file
---------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 10 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------

d'altronde simplesamlphp stesso non è PSR-x compliant ... anche se ci provano
noi che facciamo ?

Rendiamolo compliant.
Grazie

Hi @simevo!
The SimpleSAMLphp-project strives for PSR-2 compliancy and we've made great efforts on master over the past few months.. Remaining issues are mostly camelCase-issues that require refactoring, so they will have to wait for 2.0...

https://github.com/italia/spid-php/commit/d8002f443e4afed0aa0e9f03b6b25d82b0ac3f0e fixed CS on setup script class


[page] for tags

Hello,
this feature may be very good to be on this template. having different pages (pagination) for tags pages. For example I have posted 60 .md posts with a "hello" hashtag, if I go to mywebsite.com/tags/hello, I see all those 60 posts in one page , which may takes a long time to load.

60 article titles and descriptions would probably contain fewer words than one blog post. Since everything is created at build time, I won't worry about page load speed. Nonetheless, if you wish to implement a paginated version you can adapt the code from blog/page/[page].js

60 article titles and descriptions would probably contain fewer words than one blog post. Since everything is created at build time, I won't worry about page load speed. Nonetheless, if you wish to implement a paginated version you can adapt the code from blog/page/[page].js

thanks, however I am displaying post feature images under the titles, so indeed it takes a long time to load the images.

I see, in that case do look at copying over the code from blog/page/[page].js

I see, in that case do look at copying over the code from blog/page/[page].js

Thanks! I will try.


Add shortcut to install cassandra schema on startup

Followup to https://github.com/uber/cadence/pull/438
This is something we have to do often, adding a make target for it to make it easier.

Coverage decreased (-0.006%) to 65.853% when pulling dafd2623d4101aa978ed89e8d5ea32eedc6737f1 on shortcut into 9968ec6cb949e45d706c37be9065100a0e2d8947 on master.


Composite entity labelling parse error with ludown

Tool
Name: Ludown
Version: 1.3.0
OS: Windows 10
Describe the bug
It appears that the parsed output of my labelled composite and simple entity is incorrect. The text field seems out of order, and the startPos/endPos for the composite entity seems off as well.
To Reproduce
Steps to reproduce the behavior:
Consider the utterance "I want to order a shirt please". I want to create a composite entity "order a shirt" that maps to "productOrder". Inside that composite entity, I want to create a simple entity "shirt" that maps to "product".
First, create a labelled utterance file, test.lu, with the following:
 # Order
 - I want to {productOrder = buy a {product = shirt}} please
Second, parse the file by running:
ludown parse ToLuis --in test.lu
Third, open the output file, test.json, and observe the following in particular:
  "text": "I want to shirtbuy a please",
  "intent": "Order",
  "entities": [
    {
      "entity": "product",
      "startPos": 10,
      "endPos": 14
    },
    {
      "entity": "productOrder",
      "startPos": 10,
      "endPos": 19
    }
  ]

Expected behavior
I would have expected the following:
  "text": "I want to buy a shirt please",
  "intent": "Order",
  "entities": [
    {
      "entity": "product",
      "startPos": 16,
      "endPos": 20
    },
    {
      "entity": "productOrder",
      "startPos": 10,
      "endPos": 20
    }
  ]

Screenshots
n/a
Additional context
n/a
[bug]

Fixed via #1130 ; should be available shortly via the botbuilder myget feed and pushed up to npm on the next publishing cycle.


Authentication failed

I am getting an error connecting. I use FreePBX. I tried adding a user to Admin>Administrators. I also tried the user/secert from manager.conf
The error:
Fail: Authentication failed

   at AsterNET.Manager.ManagerConnection.login(Int32 timeout) in e:\Projects\Github\AsterNET\Asterisk.2013\Asterisk.NET\Manager\ManagerConnection.cs:line 1410

   at AsterNET.Manager.ManagerConnection.Login() in e:\Projects\Github\AsterNET\Asterisk.2013\Asterisk.NET\Manager\ManagerConnection.cs:line 1713

   at DialerAstro.Form1.Connect(String host, Int32 port, String user, String password) in C:\Users\Jeff\Documents\Visual Studio 2010\Projects\DialerAstro\DialerAstro\Form1.cs:line 47

using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

using AsterNET;
using AsterNET.Manager;
using AsterNET.Manager.Action;
using AsterNET.Manager.Response;

namespace DialerAstro
{
    public partial class Form1 : Form
    {

        private ManagerConnection manager = null;
        private String curChannel;
        public string phoneExtension="5000";
        public Form1()
        {
            InitializeComponent();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            MessageBox.Show(Connect("<IP_ADDRESS>", 5038, "admin", "1234"));   //"test", "1234"
            manager.NewChannel += manager_NewChannel; //event handler
            //Handle manager.NewChannel event
        }

        private string Connect(string host, int port, string user, string password)
        {
            manager = new ManagerConnection(host, port, user, password);

            manager.NewChannel += manager_NewChannel;

            manager.PingInterval = 0;

            try
            {
                manager.Login();
                return "Success";
            }
            catch (Exception ex)
            {
                manager.Logoff();
                return "Fail: " + ex.Message + "\n\n\n" + ex.StackTrace;
            }
        }

        void manager_NewChannel(object sender, AsterNET.Manager.Event.NewChannelEvent e)
        {
            if (e.CallerIdNum != phoneExtension)//userrow.number)
                return;

            curChannel = e.Channel;

        }

        void origionate(string extension, string callerID)
        {

            OriginateAction oc = new OriginateAction();

            oc.Priority = "1";
            oc.Exten = extension;  // extension to connect to
            oc.CallerId = callerID;
            oc.Context = "from-internal"; // in context
            oc.Channel = "SIP/peer/20005427"; // this is the channel and dialled first! Try this also: "SIP/401",
            oc.Timeout = 15000;
            oc.Async = true;
            ManagerResponse originateResponse = manager.SendAction(oc, oc.Timeout);
        }
    }
}

I tried adding this to manager_custom.conf and rebooting and using this code to sign in:
MessageBox.Show(Connect("<IP_ADDRESS>", 5038, "abc", "123"));
Here is the manager_custom.conf:
[abc]
secret = 123
deny = <IP_ADDRESS>/<IP_ADDRESS>
permit = <IP_ADDRESS>/<IP_ADDRESS>
permit = <IP_ADDRESS>/<IP_ADDRESS>
read = system,call,log,verbose,command,agent,user,config,command,dtmf,reporting,cdr,dialplan,originate
write = system,call,log,verbose,command,agent,user,config,command,dtmf,reporting,cdr,dialplan,originate

I found the answer. I added a user to Settings>asterixmanager
Added permissions for my network:
<IP_ADDRESS>/<IP_ADDRESS>

How to set it?
I don't quite understand.

@snailg, please read the official Asterisk documentation about how to configure the Manager.conf file.
https://wiki.asterisk.org/wiki/display/AST/Asterisk+GUI#AsteriskGUI-Configuration


No Search results displayed

Hello,
When I press the F5 key, the program launches my browser and then I enter a search query like "sharepoint" and I get the exception as attached. I have a couple of documents on my development site and I'm entering a query based on those documents

Please help.

@BamideleAriwodola
Thanks for raising this issue. If you don't get a response in a few days, you might try emailing the sample's author<EMAIL_ADDRESS>


Pagination buttons at bottom dont seem to work

Back button doesnt do anything and I think the forward button is using an old API call or something

Ahhh I see this is for pagination of the proposals my bad


[VL] add isnan support

What changes were proposed in this pull request?
Add isnan support. Now only double is supported by velox, it should be an easy change to support float also.
How was this patch tested?
UT.

https://github.com/facebookincubator/velox/pull/8272

@zhli1142015, this pr should be pending until the velox pr is merged. Right?

Hi @zhli1142015, this pr should be pending until the velox pr is merged. Right?

I thought this can be merged to support double type only first, but I found different null behavior for double type input also, let's wait the velox pr merged.
Thanks.

@PHILO-HE , could you help review this PR?


Variables in Kotlin: Android Basics with Compose

URL of codelab
https://developer.android.com/codelabs/basic-android-kotlin-compose-variables?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-variables#2
In which task and step of the codelab can this issue be found?
Second line of the page  has spelling mistake "Define versus use a variable."

Describe the problem
It is a simple spelling mistake to be corrected.

Where is the spelling mistake?

I believe this sentence doesn't convey the meaning accurately " Define
versus use a variable ".
https://developer.android.com/codelabs/basic-android-kotlin-compose-variables?continue=https%3A%2F%2Fdeveloper.android.com%2Fcourses%2Fpathways%2Fandroid-basics-compose-unit-1-pathway-1%23codelab-https%3A%2F%2Fdeveloper.android.com%2Fcodelabs%2Fbasic-android-kotlin-compose-variables#2
On Sun, May 14, 2023 at 5:40 PM User202379 @.***> wrote:

Where is the spelling mistake?
—
Reply to this email directly, view it on GitHub
https://github.com/google-developer-training/basic-android-kotlin-compose-birthday-card-app/issues/315#issuecomment-1546882292,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A7ZHTB4WQRS6PMURMOQJT7TXGDB4PANCNFSM6AAAAAAX7FA52Q
.
You are receiving this because you authored the thread.Message ID:
<google-developer-training/basic-android-kotlin-compose-birthday-card-app/issues/315/1546882292
@github.com>

Hi @harshivsah
Thank you for writing in with your comment regarding the lesson wording.
Your observation is being passed along to the team so they can review and make changes as necessary.
Hope you are enjoying the course!
Regards.


Adding 'Type' to ResultError struct

I'm trying to create custom error messages for a JSON API in this format:
"error": {
   "field": "firstName",
   "code": 50001,
   "message": "First name is required"
}

The idea is I need to convert validation errors on my JSON schema to a specific error format. It could be an error code, a custom message, or anything else really.
What do you think of adding a 'Type' field to the ResultError struct? The context already has the field name, but other than having a string there is no way to know which error occurred. I put together an example here: https://github.com/cristiangraz/gojsonschema
Essentially you would have values like: enum, missing, less_than, unique, invalid_type, greater_than, less_than, etc to know which error occurred on each field. From there, it gives the developer more options to create customized error messages. Another option would be to change the locales to be these values that you could check against, but I don't see an easy way to overwrite the locale without forking and I think there is value in knowing the error type and still having a human-readable error message.
Open to other suggestions/ideas ways of accomplishing this if there is interest.

There is definitely room for improvements with locales in error handling and it is something i have been "struggling" with when writing the library. The main difficulty is i guess to find a way to handle all errors, those that imply one field, those implying two fields etc... Which might result in dealing with different kinds of structures for each error type.
Also this is going to be some kind of archeology work for now :) Making sure all errors are taken in account ( schema creation ones + validation ones ).
I honestly dont know what is the best solution but here are some thoughts:

We must keep the standard locales modes, forcing the library user to implements all kinds of errors before being able to use it is quite repulsive.

Allowing the user to override the locales in a Printf fashion can be a good solution. ex : SetErrorLocale( Type, "%field Must be greater than %value" )

We could provide interfaces and default implementations for all types of errors. So that the user can use the default ones or write/update his own versions. This may also allow them to write their own formatters, a good thing when dealing with JSON APIs for example.

If there is a single way to represent all kinds of errors, i mean using the same structure, i guess the Type system works. If not, I am afraid the user will have to perform some big ugly switch to handle all types and output the appropriate error.

Thanks for the thoughts. There are definitely several different layers of accomplishing this.
The example I put together is the simplest I could think of: Add a new Type field to the struct and identify the error. Then each developer can work with that in their own library to implement their own responses (should they need to) like the example I gave above. The idea here is to just add more context to the ResultError, which is only used for validation - so I did not do anything with schema errors.
The locales currently can't be overwritten because they are constants... I left that as is.
The user also would not have implement anything to use and this would be backwards compatible. They would just receive an additional Type field on the errors with a string like "invalid_type", "enum", etc. If there are multiple errors, there would be multiple ResultError structs returned, and each of those would have the new Type field so it would still address that use case.
I'm curious to get your thoughts just given the limited scope. What I'm going for is something similar to https://github.com/xeipuuv/gojsonschema/pull/6 which just adds more context to the error without breaking BC.
As a more long-term solution, I think allowing library users to create a locale struct or map[string]string and pass that into the library... otherwise the default locale will be used. This would do away with the locale constants. Each error should contain error details that are specific to that error. For example: invalid type might contain details: { "expected": "string", "given": TYPE_BOOLEAN} which can then be converted into the string replacements %expected% and %given%. GTE might contain ErrorDetails{"min": 10}. The locales would then return a string like: "%field% must be a %expected%, %given% given" and the library will handle the replacements. Each error would be it's own type (i.e. InvalidTypeError and still have a type field for easy comparison).
addError would then be called like this:
result.addError(ErrorTypeInvalid, context, currentNode, ErrorDetails{"expected": currentSubSchema.types.String(), "given": TYPE_STRING})

which would return an error struct that looks like this:
InvalidTypeError {
	Type:       "invalid_type",
	Context:     *jsonContext,
	Description: "firstName should be a string, boolean given"
	Value:       value,
	Details:     ErrorDetails{
            "expected": "string"
            "given": "boolean"
        }
}

And as a string:
(root).firstName firstName should be a string, boolean given
Schema errors could be handled the same way, but the call to errors.New() would just be a string that is generated in the same way as validation errors.

I'm actually working through a prototype of the second-half of my last comment. I'll just submit as a PR in the next day or two to get your thoughts.

Just realized I didn't link to this discussion in my PR. Here's the link the PR: https://github.com/xeipuuv/gojsonschema/pull/52


fix typo:highter

What is the purpose of the change
#1662
Brief changelog
XX
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage decreased (-0.2%) to 50.464% when pulling b3d93a0c89b1204956e197684b5b47808db74186 on LiosWong:develop into f8f6fbe4aa7f5dee937e688322628c366b12a552 on apache:develop.

@LiosWong Looks like CI failed because coverage decreased. However, your code change doesn't look like will result this. I submitted a pr(https://github.com/apache/rocketmq/pull/1667) days ago and met the same problem. It is even more strange because my code change is to add more unit tests. Really hope someone can shed some light on this.

@LiosWong Looks like CI failed because coverage decreased. However, your code change doesn't look like will result this. I submitted a pr(#1667) days ago and met the same problem. It is even more strange because my code change is to add more unit tests. Really hope someone can shed some light on this.

yeah,thank you


feat: versioned timeouts

Closes https://github.com/celestiaorg/celestia-app/issues/3859 though is in progress!

Should GoalBlockTime = time.Second * 6 on pkg/appconsts/consensus_consts.go?
Linking discussion from my PR which I plan to close: https://github.com/celestiaorg/celestia-app/pull/3953/files#r1794435786

the knuu cluster is on the fritz, and @rach-id 's local devnet tool comes to the rescue again! here are the timestamps from the logs
15D71B38D250F6D2CB0ADD7E711A8658FD63DA993EE4939E77","total":1}},"height":49,"pol_round":-1,"round":0,"signature":"AVp2K3YL3zxlwbROldfOCbLalitHc5DNU9Q7kZzfFxMZMoy30IsCq3tXaXpCs42GakLe2yWhGtsmFQEGpbzhCg==","timestamp":"2024-10-15T22:21:01.230269104Z"} proposer=12C509ED04EA103C84944017B9E7ADE494D486A3
10:21PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"5A9EDAE7C7F68A36D4D4604693F997C00DFC399D007AC8DDEA48C6E0BC649756","parts":{"hash":"DD427A879508A4D6D3EB497071F437AC0938EB0E5DFB78D1569A5D2CFFA149A4","total":1}},"height":50,"pol_round":-1,"round":0,"signature":"3BzjkhFr/sVGlzWc1yfQyFH1fC3McGKBFdJV00pYG+cyviBjLvCoS6CAqCA7SmVJKlcSshzL+7hPCd98I24FBA==","timestamp":"2024-10-15T22:21:12.783355131Z"} proposer=223467FF1BD29B323D8CF4AFCFECD5ED1C0D4383
10:21PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"ED5731ADB3F97BD54515C3C0B5CBE0E1F95AE79312DDEFC3DA98AC10B32581A1","parts":{"hash":"CDD6126E7D55BA813BAA811637355CC57037E74B278AA453FAAF681EC998E2AC","total":1}},"height":51,"pol_round":-1,"round":0,"signature":"tIyE8v9HPbuA/ZRVJMobBiC1WwCU62aSkKlgmbT2NfhJ26AZxu6RXx8XctuhwU0ompYVOdRoQWGHh2KuMrAJBw==","timestamp":"2024-10-15T22:21:24.202601875Z"} proposer=BC381AF58CB970ACAF795A003461EE02057C5F92
10:21PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"5A95DDAEE62A7DAAA2997E604D513A6B7063C332E8138C2908B6D705DF0B8E11","parts":{"hash":"1580CCD32169396E8DFBB2AD55C3D50A111ADBE8F84E586990A40D723A64A9D0","total":1}},"height":52,"pol_round":-1,"round":0,"signature":"VC1F7OHMIaLxAcwsgjLRUgUNYdNWFPQBjHwDdnJFQvW0V9Njd3YI3XN1KoriwXA42aqbt3xmOCKLAqNqBkyLDQ==","timestamp":"2024-10-15T22:21:35.613200507Z"} proposer=E0B63563D528BDA8AA3D26A703FC8EAAD1556016
10:21PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"E6325454000B16A6CB1963B76F0AF12ED03FE89AC47A8B677C140AD432416862","parts":{"hash":"A72AF13D9118850C4B5904CDABAD78022FAE2B8554E503915493C8F51C84B9C5","total":1}},"height":53,"pol_round":-1,"round":0,"signature":"+sXsU+NF1iNEvaJElb8ax9nXPHh951aVeLNr4hzvCt2TUZKg60HZtvLEBXoFAiKnlM/n3KO+bu/xrmc75A9lAQ==","timestamp":"2024-10-15T22:21:47.032329431Z"} proposer=12C509ED04EA103C84944017B9E7ADE494D486A3
10:21PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"960877E0053D87126B3D3E2991066F1D9D9BA1110CFC811D2C5E9A0864A71F91","parts":{"hash":"7F7D31404FF5AF5C3F52BDE7E769CDE6B00C498EDA7A02FDA0C8DAB9D9AB307B","total":1}},"height":54,"pol_round":-1,"round":0,"signature":"x10mNLY9SZMYTTEpAait+9PZrxW08/k/t2begQiPX9jrHkRlNnRjBVDwYeDQEx655iMTT6xDB3IgDhKhnEadBQ==","timestamp":"2024-10-15T22:21:51.747512718Z"} proposer=223467FF1BD29B323D8CF4AFCFECD5ED1C0D4383
10:21PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"6BF50B6FA84A6CEB80F48E6EBE2344EDAE394B14802D1A5F3F9F3DD13D364540","parts":{"hash":"AF1A821BF5CEA6DC96BCECF65678E07444196050F8034D7336DB59C36179E9FE","total":1}},"height":55,"pol_round":-1,"round":0,"signature":"+v33QJhJ4rJYn/JKzmarV3PZU1MHpKKDWUTO6K5YMNC6Ne5XJJbaMX89lQK8tK39fffP7JnYocSVn28tDSWhCg==","timestamp":"2024-10-15T22:21:56.356056546Z"} proposer=BC381AF58CB970ACAF795A003461EE02057C5F92
10:22PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"AB963F8637A4183BAB94A1AA5016FFC6DE7550D7118928C91C34FE919F412578","parts":{"hash":"964C27E0F75BD14570B1EE2433712B6048667E92A5BECDCB5F407A156814E398","total":1}},"height":56,"pol_round":-1,"round":0,"signature":"T850ryJPbgrtGeDmrHkFtUVopAb+OBSEFiWZO5uueXnbzi7R/U287447BBZH/9wEp+5+UGHPvWKt6t8vROIpBQ==","timestamp":"2024-10-15T22:22:00.964394091Z"} proposer=E0B63563D528BDA8AA3D26A703FC8EAAD1556016
10:22PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"2760E8C5A57C9D9C5BC87ED2D4BCB9F81C2065B3560849FBE6DD7F3EF7C7A570","parts":{"hash":"4C0EF005E86D3274B75353C0B37099B9DCE6E0013BE412ADCDEABC7E4A4E23C5","total":1}},"height":57,"pol_round":-1,"round":0,"signature":"opOXXP6M2PMhZ1pNXniOaJUKinCMJ/dnmhoDIHJpoPxrURvH4TToEWYg3bYtpyqdaGTmPXeu1kDvEwVUqjjTCw==","timestamp":"2024-10-15T22:22:05.484655108Z"} proposer=12C509ED04EA103C84944017B9E7ADE494D486A3
10:22PM INF received proposal module=consensus proposal={"Type":32,"block_id":{"hash":"27861014C6F14575F1C75DCE134BBE7A1B4D3B56885207A78992EA51C2454026","parts":{"hash":"82C556A57098F168F0E71E3A7D9361B654BE2182F0D33610D3592B2D2E2E666C","total":1}},"height":58,"pol_round":-1,"round":0,"signature":"o3Bcw/bfS79fTT3AiWgTBBDuBdhTOAdB42Iut2UKgXwHvIprn7EDiy75l1JqWf7WwxMBCf76VBmYGRHic8VhBA==","timestamp":"2024-10-15T22:22:10.202010713Z"} proposer=223467FF1BD29B323D8CF4AFCFECD5ED1C0D4383

the upgrade works as expected and the timeouts are overwritten. therefore, we can create a release in core and merge.

Can we just create a follow up issue to fix the v3 upgrade test such that we don't need a fixed commit tag

ahh good catch https://github.com/celestiaorg/celestia-app/issues/3981

[question] now that TimeoutPropose and TimeoutCommit are versioned constants, should they be removed from consensus constants here?

Yeah they probably can be

In the future, would be nice if PR description contained a testing section so reviewers know how this change was manually tested

@rootulp good idea, added a link to the comment and we can also test in knuu now. it appears to pass if a I manually log it and check, but there's an rpc that keeps failing that seems unrelated


demo is broken

deployed version still broken

Fixed

Aleksey Guryanov<EMAIL_ADDRESS>February 26, 2016 at 5:47 AM
deployed version still broken
—
Reply to this email directly or view it on GitHub
https://github.com/STRML/react-resizable/issues/28#issuecomment-189000984.
Aleksey Guryanov<EMAIL_ADDRESS>February 25, 2016 at 8:23 PM
https://camo.githubusercontent.com/e887fdc33ce6e7cd0e5e05ae03aaf22bed74597d/687474703a2f2f692e696d6775722e636f6d2f6569654438745a2e706e67
—
Reply to this email directly or view it on GitHub
https://github.com/STRML/react-resizable/issues/28.


Feature request: Prop vs-icon to tabs

Is your feature request related to a problem? Please describe.
This feature request is to add a new prop icon inside each <vs-tab> component.
Describe the solution you'd like
When passed a material-icon string, the icon is displayed in the left of the tab. The color is the same as the tab.
Describe alternatives you've considered
No icons if you don't think it's a good idea.
Additional context
I have the code already. See the docs updated below:

I can not see vs-icon prop in vuesax code or on the docs???

@jsinhSolanki Hello. The PR for this issue is not merged yet. It's under review. See at #361 .


Modified Caesar Cipher test description

Pre-Submission Checklist

[x] Your pull request targets the staging branch of FreeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm run test-challenges. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #9842

Description

Removed quotes from the test case description as discussed.

@sahilkhurana19 Please rebase your branch against the staging branch, resolve the conflicts and push again.

Thanks for contributing :+1:
:tada:


SnapOffsetForItem not working with relative fillParentMaxWidth

Describe the bug
Using fillParentMaxWith(fraction) doesn't seem to be taken into account when calculating the offset:
This is the code:
    val lazyListState = rememberLazyListState()

    LazyRow(
        state = lazyListState,
        contentPadding = PaddingValues(dimensionResource(id = R.dimen.spacing_16)),
        horizontalArrangement = Arrangement.spacedBy(dimensionResource(id = R.dimen.spacing_16)),
        flingBehavior = rememberSnapperFlingBehavior(
            snapOffsetForItem = SnapOffsets.Center,
            lazyListState = lazyListState,
        )
    ) {
        items(items) { item ->
            Surface(
                modifier = Modifier
                    .fillParentMaxWidth(0.9f)
                    .height(150.dp)
                    .clip(Shapes.RoundedCorner.Regular),
                shape = Shapes.RoundedCorner.Regular,
                color = CuvvaTheme.color.surface,
            ) {
                // content redacted
            }
        }
    }

And this is how it looks:

The offset is not quite centered:

To Reproduce
See attached code on previous section to reproduce.
Expected behavior
We were expecting the cards to be centered with a relative size of 0.9f.
Environment:

Android OS version: Android API 30
Device: Emulator
Library version: 0.1.0

This is likely because you're not passing the content padding into rememberSnapperFlingBehavior(). See here.

OMG, you are so right :sweat_smile:  works like a charm now. Classic case of "did not read the manual".

@pablisco can you share your code snippet by chance. Curious on what the final result ended up looking like.


New blankslate hoc with error

Proposed Changes

Potential Breaking Changes

Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

Codecov Report

Merging #1330 into new-blankslates-HOC will decrease coverage by <.01%.
The diff coverage is 93.75%.

@@                   Coverage Diff                   @@
##           new-blankslates-HOC    #1330      +/-   ##
=======================================================
- Coverage                99.43%   99.42%   -0.01%
=======================================================
  Files                      367      368       +1
  Lines                     9184     9199      +15
  Branches                  2167     2168       +1
=======================================================
+ Hits                      9132     9146      +14
- Misses                      52       53       +1

Impacted Files
Coverage Δ

...vapor/src/components/blankSlate/BlankSlatesHOC.tsx
100% <100%> (ø)
:arrow_up:

...act-vapor/src/components/blankSlate/BlankSlate.tsx
100% <100%> (ø)
:arrow_up:

.../src/components/blankSlate/BlankSlateWithError.tsx
90% <90%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d5036f...e55d293. Read the comment docs.


Android setup doesnt work (RN 0.44)

Expected behavior
follow the setup steps and the project builds and recognises the bugsnag library
Observed behavior
crashes app
Steps to reproduce
just followed the setup steps
Version
RN 0.44

Thanks for the report @soapcreativegithub. What version of bugsnag-react-native are you using?

Hi, I got the same issue. Did you solved this problem?
RN version: 0.44,
Bugsnag version: 2.3.2
And I found out that there is no bugsnag package in MainApplication.java file after I typed react-native link.
Thanks for your reply.

I found the solution for this issue.
Add "BugsnagReactNative.getPackage()" into getPackages() list as below:
protected List getPackages() {
return Arrays.asList(
new MainReactPackage(),
BugsnagReactNative.getPackage()
);
}

 Android setup doesnt work (RN 0.44)

Closing as I've been unable to reproduce and more information would be needed to investigate this issue. Feel free to reopen if it persists.


Feature Request: Undo movement.

With this new cool feature to remember movement made in a current turn it would be super helpfull for a DM to have an "undo" option if a player moved by mistake. So it would reset both movement and the position of a token.

Until this is implemented into Drag Ruler you can use this Macro to reset the movement of the token that has the currently has it's turn. This macro can be executed by both the GM or the players (but will only work if a gm is connected):
const combat = game.combats.active;
const combatant = combat.turns[combat.turn];
const flags = {trackedRound: 0, rulerState: null};
import("/modules/drag-ruler/src/socket.js").then(module => module.updateCombatantDragRulerFlags(combat, combatant, flags));

This is implemented in 70b166d8


Fixes links to Chessie

Links were pointing to FSharpx.Async gh repo, issues, readme and license.

thanks!


Provide a new NGramTokenizer with minGram and maxGram support

Fix #349

I was not able to do the UTF8 tests because it seems that my laptop setup doesn't recognize the chinese/japanese characters.
However, I don't think they are really needed.

I tried to add utf8 test, but there is some wrong :thinking:, I will try other approach with preg_split

I definitely needs help on that, thanks :-)

One more thing, I want to implement it in this way: https://www.elastic.co/guide/en/elasticsearch/reference/current/analysis-ngram-tokenizer.html

@drupol please review changes and let me know what you think?

Use my package guys :p
On Sun, Feb 10, 2019, 17:17 Arkadiusz Kondas<EMAIL_ADDRESS>wrote:

@akondas commented on this pull request.
In src/Tokenization/NGramTokenizer.php
https://github.com/php-ai/php-ml/pull/350#discussion_r255344057:

{

   if ($minGram < 1 || $maxGram < 1 || $minGram > $maxGram) {

       throw new InvalidArgumentException(sprintf('Invalid (%s, %s) minGram and maxGram value combination', $minGram, $maxGram));

   }

   $this->minGram = $minGram;

   $this->maxGram = $maxGram;

}

/**

* {@inheritdoc}

*/

public function tokenize(string $text): array

{

   $words = [];

   preg_match_all('/\w\w+/u', $text, $words);

There was a reason for that 🤔
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/php-ai/php-ml/pull/350#discussion_r255344057, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAPYio9daXvNtQDcrMSfuvCWHgP6jQAKks5vMEX9gaJpZM4airRq
.

I won't comment here on this, I leave the decision up to you guys. I was thinking that using drupol/phpngrams was a good idea because it's fully tested and reliable.
Besides that, phpngrams uses generators already, and it's gentle with the memory.
I was thinking that going that way was a step forward into the adoption of Iterators and Generators.
Anyway, I'm sure you'll do the right choice in the end.

@drupol Your package unfortunately  doesn't support utf-8 ... i tried to add it, but much simpler for me was write simple class. The more that support was needed for min and max gram.

@drupol Your package unfortunately doesn't support utf-8 ... i tried to add it, but much simpler for me was write simple class. The more that support was needed for min and max gram.

I just updated the README file in order to deal with UTF8 strings.
Example:
$string = 'hello world';

// Better use preg_split() than str_split() in case of UTF8 strings.
$chars = preg_split('/(?!^)(?=.)/u', $string);

$ngrams = (new NGrams())->ngrams($chars, 3);

@drupol let the metrics decide:
Time consumption:
2 subjects, 10 iterations, 2,000 revs, 0 rejects, 0 failures, 0 warnings
(best [mean mode] worst) = 231.944 [973.234 974.686] 234.549 (μs)
⅀T: 9,732.344μs μSD/r 3.344μs μRSD/r: 0.357%
The Consumation of Time
=======================

suite: 13414047e6bb3695b6c6a203d7a5625c7c36e7de, date: 2019-02-12, stime: 08:07:12
+----------------------+-------------+-------------+--------+-------+
| subject              | mode        | mean        | rstdev | diff  |
+----------------------+-------------+-------------+--------+-------+
| benchSimpleTokenizer | 232.612μs   | 232.959μs   | 0.38%  | 1.00x |
| benchDrupolTokenizer | 1,716.759μs | 1,713.510μs | 0.34%  | 7.36x |
+----------------------+-------------+-------------+--------+-------+

Memory consumption:
2 subjects, 10 iterations, 2,000 revs, 0 rejects, 0 failures, 0 warnings
(best [mean mode] worst) = 234.356 [981.255 977.479] 236.921 (μs)
⅀T: 9,812.554μs μSD/r 5.609μs μRSD/r: 0.495%
The Memory Usage
================

suite: 1341404cc4ef87cd6321174dccbb32f05fb6546c, date: 2019-02-12, stime: 08:08:59
+----------------------+------------+------------+------------+-------+
| subject              | mem_real   | mem_final  | mem_peak   | diff  |
+----------------------+------------+------------+------------+-------+
| benchSimpleTokenizer | 6,291,456b | 4,824,536b | 5,229,248b | 1.00x |
| benchDrupolTokenizer | 6,291,456b | 4,857,120b | 5,229,248b | 1.00x |
+----------------------+------------+------------+------------+-------+

Even with 1MB text file, memory consumption was the same for both approach.
I have added performance test, you can check on your own.

Hi @akondas,
I let you decide and I'll follow your decision on this.
If it was me, I would have chosen phpngrams, so you delegate tests and code in another package, which is, IMO a good idea.
I won't be offended if we chose one or the other solution :-)

@drupol Thanks for help :+1: I appreciate your contribution and I hope that this decision will not change your attitude. I prefer a faster and simpler solution.

No problem mate 😁


Query Drawing

I am trying to add a function which will query a ticker for draw lines.  The endpoint
https://quotes-gw.webullbroker.com:443/api/draw/quote/charts/queryDraw?tickerId={tickerId}&versionId=139
endpoints.py
    class urls :
        def __init__(self) :
            self.base_draw_gw_url = 'https://quotes-gw.webullbroker.com/api'
    ...
    def queryDraw(self, stock):
        return f'{self.base_draw_gw_url}/draw/quote/charts/queryDraw?tickerId={stock}&versionId=139'

webull.py
    def get_line(self,tickerId=None):
        headers = self.build_req_headers()
        r = requests.get(self._urls.queryDraw(tickerId), headers=headers,stream=True)
        print(r.content)
        return r.json()

b'{"config":"\\u001F\xc2\x8b\\b\\u0000\\u0000\\u0000\\u0000\\u0000\\u0000\\u0000\xc3\x8d[K\xc2\x8f\\u001C8\\u0011\xc3\xbe+h\xc3\x8e\xc3\xab\xc2\x96\xc3\x8bU\xc3\xa5\xc2\xb2sE\xc3\x9c\xc3\xa0\xc2\x86\xc3\x84a\xc3\x85\xc3\x81O\\u0011\\u00116(\\u0019\\u001E\xc3\x8b\xc2\x8a\xc3\xbf\xc3\x8e\xc3\xa7\\u000EQ<!\xc3\xad\xc2\xa5\xc3\x83L\xc3\x84J\xc3\x89f\xc2\x92L\xc2\xb5]\xc2\xae\xc3\xba\\u001Ee\xc3\xa7\xc3\xbb\xc2\x9f\\u001E^\xc3\xb7\xc2\x87W\\u000F\xc3\x9eg3\\u0012v\xc2\xb1Zu\xc3\xa2Sw5\xc2\xb6\xc3\xa0T\xc3\x95scM}\xc2\x96\xc2\x87\xc3\xaf\\u001E\xc3\x9e\xc2\x94\xc3\xb7\xc2\x8f\xc2\xbfy\xc3\x9b_\xc3\x8f\\u001F\x7f\xc3\xbb\xc3\xbaO\xc3\xa3\xc3\xa1\\u0015\xc3\x85\xc3\xa0\xc2\x89%\xc2\xa7\xc2\x9c)\xc3\xbf\xc3\xb3\xc2\xbb_|\xc2\x8c\\u0016\xc2\xba\xc3\x86P\xc2\xa2+Q\xc2\xbc\xc2\x93H\xc3\x83\xc2\xa5\xc2\x90\xc2\x8b\xc2\xab\xc2\x9a\\u001B\xc3\xb9\\\\e\xc3\x86v\xc2\x8a\xc2\xa6\xc3\x9e\xc3\xb6h,\\u001A\\u000B\xc2\x8f\xc3\x99\xc2\xa6\xc2\x90&\xc2\x9b\\\\\xc2\xa5\xc3\xb4\xc2\xa1#$\xc2\xa1\\u0010\xc3\x97\xc2\xba^\xc3\xbf\xc3\xb08\xc3\x9e\xc3\xbd\xc2\xb5\xc2\xbc\xc3\x81\xc3\x9f\xc3\xbe\\u0013\xc2\xad\xc2\xaf\xc3\x9f\xc3\xbf\xc3\xbam\xc3\xbb\xc3\xa3\xc3\x80w\xc3\x8f\xc3\xb2\xc3\xa6\xc3\xbd\xc2\xb8\xc3\xb1Q\xc3\x8aF\xc3\x84\xc2\x9c\xc3\xb1\xc3\x87\xc2\xaf\x7f\\u0018\xc2\xbf|\xc3\xbb\xc3\xa6\xc3\xad\xc2\xbb\xc2\x87W\xc3\xbc\xc3\xa1\xc2\xab\xc3\x9f\xc2\xbd\xc3\xae\xc2\x8f\x7f@\xc2\xb8\xc2\xbf\xc2\xad\xc3\xbf\xc2\xaf\xc2\x90\x7f~\xc2\x8b\\u000Fy\xc3\xbf\xc3\xb0\xc3\xaa\xc3\xbb\xc2\x9f\\u001E\xc3\xbe\xc3\xbe\xc3\xaf\xc3\xaf\xc2\x97\xc2\xa8\xc3\x81\xc3\xa3\xc2\xbf\xc3\xaf\\u001E~|x\xc2\xa5\xc2\x97\xc2\x94\\u0003\xc3\x96\xc3\x8d\xc2\x898\\u0005\xc3\x8a\xc3\xb2\xc3\x8f\xc3\x9f\x7f\xc3\xb7\xc3\xb0\xc3\xbe\xc3\xb1\xc3\x877\xc3\xb8\xc2\xb4\xc2\x87\xc3\xbe\xc3\xb6\xc3\xb1q\xc3\xb4\\u0015\xc3\xa6\xc3\xb1\xc3\x87?\xc2\xaf\xc3\x9f\xc3\xb8\xc3\x83\xc3\x9bw\xc2\xaf\xc3\xbf\xc3\xb1\xc3\xb6\xc2\x87G,y\xc

I am not able to decode the response no matter what I try.  I have tried decompressing gzip, br, and deflate nothing works for either utf-8 or unicode.  Honestly I can't even tell if the response is decompressed or in just another charset like chinese.  Any thoughts on how to solve this?

I can't seem to get any valid information from this endpoint, is returning [].

That's interesting. Off the top of my head, the response you show appears to have 2 different encodings (which may not be unusual). May take a look this weekend to see if we can't decode it - no promises though. But how did you get that response? I also just get back an empty {} from that endpoint

Pinging here. Sorry, I didn't get the time to look at this and forgot. Did you come up with anything @jasonbrisbin?

I have not made any new progress on it

I was sorta able to reproduce, though mine looks even weirder.
{"config":"\u001F\b\u0000\u0000\u0000\u0000\u0000\u0000\u0000uP;kÃ0\u0010þ+åf©èy:yíÜ-Ð!d°#¹\u00158V°L[\u0013üß+\u0014Ú¡·\u001C|Oø7H\u0001:°VÊñèÌMpÓè<\u001FÉ \r~<\u0007\u001FÁÔõ94ntÐIÔX]B\u0018%%u»V\u0010øºÄRR\u000FK¯¬ÛÔ§ôæøÂúV±öå\u001D|ÊS^Z.kNóZ ;Þàó§IhÇ`Nk÷(³;û%°\u001Aÿ\n¤!-¤ÖÖÆýÄ Æå½jóEÁÎ\u001Eî\u000B\f>VÜCnÆ^qR^ñj\u001C¤G\u0012Ø\u000Fÿ.Dè$í§/¾Ü2«P\u0001\u0000\u0000","version":3}

I believe it's supposed to be charset=UTF-8 encoding (my client already tried to decode, replacing all the chars that start with \x) but it's impure... mixed with some unicode(?)
The saveDraw POST request that should have created the config above had a payload that looked like:
{"tickerId":913323997,"config":"[{\"id\":\"55084127-b88c-4d73-8f79-f8465d9fcd9d\",\"lastModifyTime\":1636127004211,\"type\":\"regressionTrend\",\"style\":\"solid\",\"lineWidth\":\"width1\",\"lineColor\":16,\"points\":[{\"x\":1636120800000,\"y\":337.0075},{\"x\":1636125360000,\"y\":337.01483013357836}],\"interval\":\"m2\"}]"}

which is perfectly parsable and readable. I don't know how/why it's converted to that mess before.
Sorry, I don't know how to be of more help. Out of curiousity though, why would you want to have a query draw method (seemingly only visual use cases) in a API library (that's not visual at all)?


Support spatie/laravel-schemaless-attributes for json fields

Currently in backpack json fields need to be cast as array or object to work with some field types or columns
However many of us uses spatie/laravel-schemaless-attributes where we will get SchemalessAttributes when doing $model->json_field due to the getter method:
public function getExtraAttributesAttribute(): SchemalessAttributes
{
   return SchemalessAttributes::createForModel($this, 'extra_attributes');
}

Where we can still access attributes by $model->json_field['field1'] or $model->json_field->field1
Since spatie packages are hugely popular in the Laravel community. I think it will be good if support for it can be considered as well. So don't just check for is_array() and is_object(). Check for if it is SchemalessAttributes type too for determining if it is a json field
https://github.com/spatie/laravel-schemaless-attributes
Thank you

Hi @ziming ,
Thanks for the suggestion - sounds like we can add schemaless-attributes support pretty easily, and it might be a good idea - but the idea itself doesn’t look very popular - nobody commented so far. Also, I see this Spatie package isn’t very popular either, it only has 22k downloads - which is not a lot by their standards.
Let’s see if this proposal gathers any more support - we’ll provide SchemalessAttributes support if more people ask for it. Until then, I’m going to close this - I know people who search for this will definitely find it - your issue is well-written and has all the keywords it needs. Thanks again!
Out of curiosity - where did Backpack stumble when working with schemaless attributes? How did you work around it?
Cheers!
TLDR: If you want support for schemaless-attributes please reply to this issue and say so, and we’ll reopen the issue and consider it.

I created the json editor field pull request earlier. You can check it out

I only comment on that to show you where it stumble and how my field handles that

Yup - as I expected, such an easy fix :-) Thank you!

I would like support for json fields to be added as part of the core


Tighter verification of external-boot-image

Only import if the correct image.

Can you explain the fix ? Its not clear to me

Only import /etc/external-boot-image.tar if the image name in the tar file is docker.io/lfedge/eve-external-boot-image.

Why would that not be the case ? I thought the tar file is created during build and should always contain the external-boot-image


Fix broken links in readme

Changes:

Update the link to the Helix editor (they moved the doc to this new page).
Fix the # in the other link in erlang doc (the - at the end was wrong, so the fragment identifier in the URL don't land in the function)
Also format the table in the readme.

Thanks


trivial fix for verify_checksum() in case of a stupid error

verify_checksum() had a flaw - if one forgot to do %256 on checksum but the checksum itself is correct but just >256 then verify was returning true incorrectly

If one would use a correct data type from the very beginning then no need to to extra operations at all.
CheckSum > 255 does not make sense and verify_checksum should return false. One should fix a problem on their side instead ;)

but we better reject CheckSum > 255 messages right? it could be not on our side but counter party sending crazy number

That could be the case indeed


Allow vcpkg overlays to be specified as CMake variables

Currently projects using cesium-native set VCPKG_OVERLAY_PORTS and VCPKG_OVERLAY_TRIPLETS as environment variables. This PR allows you to instead set them as regular CMake variables, like what we do for VCPKG_TRIPLET.
@jherico would this be a welcome change to bring back into https://github.com/jherico/ezvcpkg?

@lilleyse I'll investigate.  I haven't actually done anything overlay specific with ezvcpkg or vcpkg in general yet, so I have little experience.  This change seems straightforward enough though.  If you want to create a PR I'll likely merge it quickly.

@azrogers the compiler argument code in compiler.cmake shouldn't be uncommented, because compiler options added in that way will apply globally, but just to cesium-native libraries. This isn't so much a problem in cesium-native, because everything outside cesium-native is built by vcpkg, which will not be affected. But other projects that use cesium-native can and do have third-party libraries, and we don't want to mess with their compiler flags.
The cmake code that sets the warnings for just the cesium-native libraries is here:
https://github.com/CesiumGS/cesium-native/blob/f646271fa40ace3ecb0392ec42c01b1c2b4ee4ff/cmake/macros/configure_cesium_library.cmake#L3


[Tracking issue] Quantized TFLite operators

As part of https://github.com/apache/tvm/pull/9165, we recently enabled support for quantized operators in the TFLite frontend "unary element-wise" function, that does generic support for a few operators.
That opens the door for more operators to be supported easily, just pending the addition of tests and logically unlocking the conditional block that is keeping the quantised version of the operator to be unsupported. See the example as implemented in  https://github.com/apache/tvm/pull/9165.
This is a tracking issue for new unary element-wise operators to be supported:

[ ] GREATER
[ ] EQUAL
[x] CEIL #10566 by @leeexyz
[x] ROUND #10566 by @leeexyz
[x] FLOOR #10566 by @leeexyz
[x] EXP #10566 by @leeexyz
[x] LOG #10566 by @leeexyz
[x] SIN #9478 by @onkar-sima-ai
[x] TAN #10566 by @leeexyz
[x] COS #10566 by @leeexyz
[x] SQRT #9258 by @elinx
[x] RSQRT #9165 by @ophirfrish
[x] NEG #9404 by @ophirfrish

For each operator above, there are actions to be taken:

Remove the conditional block if self.is_quantized(op): ...
Implement unit tests
ask any committer in the project to update this issue, reflecting the PR to support the operators on the list above

#9165 can be used as an example.
Resources:

TFlite frontend: https://github.com/apache/tvm/blob/main/python/tvm/relay/frontend/tflite.py

Hi @leandron can you please update this issue and if possible review the PR for qunatized SIN operator?
I have followed the instruction in this issue to write the test cases.
Please let me know if I need to do any changes.
Thanks for posting, Happy to contribute.

Hi @leandron can you please update this issue and if possible review the PR for qunatized SIN operator? I have followed the instruction in this issue to write the test cases.
Please let me know if I need to do any changes. Thanks for posting, Happy to contribute.

Done! thanks @onkar-sima-ai

Hi @leandron I am interested in getting to know the source code better. Is the list of operators up to date? I might try implementing the GREATER operator using #9165 as a template. Thanks!

Hi @leandron I am interested in getting to know the source code better. Is the list of operators up to date? I might try implementing the GREATER operator using https://github.com/apache/tvm/pull/9165 as a template. Thanks!

Sorry I missed your message. I've just updated the list of operator.
To your question: yes, you can use #9165 as a template.

Thanks @dchauhan-arm @leeexyz @onkar-sima-ai @elinx @ophirfrish for the contributions towards this effort! Closing as it is now complete.


Add Jest tests and Prettier support

What
This commit adds support for Jest and writes a few simple tests as proof. Adding a test is as easy as adding a file that ends in .test.js next to the file you want to test. Any file that matches that pattern should have access to Jest functions. The whole test suite can be run with npm run test.
I also added support for Prettier. Running npm run format should run Prettier on any staged changes. I thought about adding Husky (or something equivalent) to automatically run Prettier as a pre-commit hook, but it seems as though Husky requires git v2.13 which would require me upgrading Git.
Why
Having a way to test JavaScript changes is a pretty crucial part to helping validate new PRs. It'll give maintainers confidence in changes, and will give contributors a way to prove that their code works as expected.
Additional concerns
There's a lot more we could be doing, like relying on a package manager to get some of our vendor libraries added rather than committing them to the repo, but that's out of scope for this ticket.
I didn't add support for ESLint yet since I figured that may be a slightly more involved conversation — Prettier seems to be generally uncontroverical and is generally only slightly configurable, whereas ESlint is highly configurable and behaves however we want it to.

Ran make test after 2nd commit.  LGTM
make test
go test github.com/hound-search/hound/...
ok  	github.com/hound-search/hound/ansi	(cached)
?   	github.com/hound-search/hound/api	[no test files]
ok  	github.com/hound-search/hound/client	(cached)
?   	github.com/hound-search/hound/cmds/hound	[no test files]
?   	github.com/hound-search/hound/cmds/houndd	[no test files]
ok  	github.com/hound-search/hound/codesearch/index	(cached)
ok  	github.com/hound-search/hound/codesearch/regexp	(cached)
?   	github.com/hound-search/hound/codesearch/sparse	[no test files]
ok  	github.com/hound-search/hound/config	(cached)
ok  	github.com/hound-search/hound/index	(cached)
?   	github.com/hound-search/hound/searcher	[no test files]
?   	github.com/hound-search/hound/ui	[no test files]
ok  	github.com/hound-search/hound/vcs	(cached)
?   	github.com/hound-search/hound/web	[no test files]
npm test

><EMAIL_ADDRESS>test /home/dschott/go/src/github.com/hound-search/hound
> jest

 PASS  .build/ui/js/common.test.js
 PASS  ui/assets/js/common.test.js

Test Suites: 2 passed, 2 total
Tests:       4 passed, 4 total
Snapshots:   0 total
Time:        1.92s, estimated 2s
Ran all test suites.


[REQUEST] Add support for docker container as soon openbullet 2 (Web) works fine

It will be nice to have openbullet to have support for docker container just to not have to install dependencies on the host directly.
Kind regards

I don't understand why you post OB2 ideas on the OB1 repo. Docker support is already planned.

I'm not able to register on the forum it says
Email domain not accepted
Also with my company mail, prontomail, and Gmail

Thanks for letting me know, I think I fixed the issue. Could you try again please?

No same issue 😢

I fixed it for real now, had to restart the forum in order for the changes to take effect. Sorry about it!


need your help regarding WAF

Hello,
I need to set in waf, if the 1000 request come in 15 minute per IP address, waf block the ip
I have configured WAF with cloudfarmation its working fine but the time is 1 min to count the request I need to set it 15 min
Could you please advise any Help URl

I actually wanted to say that I have an idea how to do that and wanted to provide a PR but a look at the code tells me that it might be even easier. I don't use the plugin but check Athena for a query called 'logParserQuery'. I guess that one contains the limitation to get the events for the last minute (60 seconds) only.
It should (/may, as I'm not able to reproduce and test it) work to just increase the value here.

closing the old ticket due to inactivity


Renaming a project in Go breaks everything that relies on it

Previous project was: github.com/newrelic/go-agent
This project now returns a 404
new project is https://github.com/newrelic/newrelic-client-go
ANY golang project that relies the go-agent is now broken.

Hi @zbintliff, thank you for the report.  I don't think this is quite right, though.  This repo wasn't renamed to my knowledge, and looking in the history, seems to confirm this.  But to dig in to the root of your issue, I don't know where that repo went.  I have a checkout of it locally, but I've not fetched in well over a year, so can't confirm the status.  It does look like the repo is back now, perhaps they were just moving things around.  Let me know if I can help further.

You're right, I just assumed it was renamed. I worked with NR support to fix and restore the original repo.
Thanks!


Fix test observability server upload on main

I forgot that GITHUB_BASE_REF and GITHUB_HEAD_REF are only set for builds triggered by pull requests.

Merging this PR with only the one approval as the fix is clear and it unblocks CI state for default branch (main).


import/no-internal-modules forbid option is not validated

Hi guys! I see you have committed for the rule import/no-internal-modules a forbid option. But it looks like in the latest 2.22.1 it has not been released -<EMAIL_ADDRESS>And now it fires the error:

related to https://github.com/benmosher/eslint-plugin-import/issues/1842

Yes, it's not been released. On any github project, you should be reading the docs from the latest release tag: https://github.com/benmosher/eslint-plugin-import/blob/v2.22.1/docs/rules/no-internal-modules.md
The next release, which has no scheduled time, will contain that option and allow you to use it.


[docs] Fix Chakra UI theme scoping typo

Just fixing a small typo discovered when trying to repro https://github.com/mui/material-ui/issues/36910
Proof that it works: https://codesandbox.io/s/chakra-material-forked-qsbpog?file=/src/App.tsx

I'm confused by the API:
    <ChakraProvider theme={chakraTheme} resetCSS>
      <MaterialThemeProvider theme={{ [THEME_ID]: materialTheme }}>

Since ChakraProvider and MaterialThemeProvider I think that most developers should expect { [THEME_ID]: materialTheme } to override chakraTheme. Did we consider this API instead?

    <ChakraProvider theme={chakraTheme} resetCSS>
      <MaterialThemeProvider theme={{ [THEME_ID]: materialTheme }} mergeParentTheme>

or

    <ChakraProvider theme={chakraTheme} resetCSS>
      <MaterialThemeProvider theme={materialTheme} themeId={THEME_ID}>

@oliviertassinari Agree, (2) looks better and it should simplify the types.


CRI-O pause image and pause command runtime modification clashes with package defaults

Right now, the PauseImage derives from skuba.ImageRepository:
https://github.com/SUSE/skuba/blob/d69c2e894e4112cfa2c23526486ae663fd38aecd/pkg/skuba/actions/cluster/init/init.go#L62
Since skuba is not able to change the CRI-O's pause_command option, it could be possible to have an invalid set of configuration parameters which fails during runtime.
I see two ways to solve this:

Either: Don't write the CRI-O configuration in skuba any more and provide different configuration packages in IBS/OBS, which work out of the box (preferred)
Or: Add the pause_command option to be changed by skuba, too

What do you think?
Relates (somehow) to: https://github.com/SUSE/avant-garde/issues/858

Isn't there a third option? We could leave crio configuration untouched (unless until it supports a crio.conf.d configuration folder), and use a systemd drop-in unit file where we could override certain parameters (like --pause-image and/or --pause-command -- --pause-command wasn't added because I don't think we found anything different than /pause, but I might be mistaken).
Since this issue is more about pause_command than anything else, have we spotted on the wild this specific problem?

Since this issue is more about pause_command than anything else, have we spotted on the wild this specific problem?

The config in the devel:kubic package uses /usr/bin/pause since some time, so we discovered that possible pitfall when migrating the config to the latest changes.

Can we leave this to the entrypoint? Would --pause-command="" work, running the entrypoint defined in the image?

Can we leave this to the entrypoint? Would --pause-command="" work, running the entrypoint defined in the image?

Unfortunately not right now, the entrypoint will not taken into account. I follow-up on this topic on https://github.com/cri-o/cri-o/pull/2881

Follow up PR was merged I assume this can be closed.
https://github.com/cri-o/cri-o/pull/2881


Reduce Unnecessary Scrolling in Memory Tile Game

🔴 Description: Resized game tiles to reduce scrolling and improve visibility, ensuring smoother gameplay without disrupting user experience.
🔴 Images/Videos:
Before:
before-tiles.webm
After:

@iamrahulmahato please review this PR once and if suitable merge it so that I can work on the another issue of same repo as it is causing clashes


ss88/easy_unsubscribe: package version disagreement between packagist and Roundcube Plugin Repository

The plugin ss88/easy_unsubscribe is listed at:

https://plugins.roundcube.net/#/packages/ss88/easy_unsubscribe and
https://packagist.org/packages/ss88/easy_unsubscribe

and both web frontends display https://github.com/SS88UK/roundcube-easy-unsubscribe/commit/3970c082f61c1bfbcad04fb86f881aab62189499 as the latest dev-master commit.
However, when using composer to install it, the information at https://plugins.roundcube.net/p/ss88/easy_unsubscribe%243eca1312a1595c6ebfe5e178c043d8ac8348a541df6381c8a9aea41b9f62b0d9.json is referenced by composer, which is outdated and lists d09f442 from 2019 as the latest commit.
There must be something weird going on for the Roundcube Plugins web frontend and its actual hosted json version information to disagree.
Because of this, I've found it impossible to install the latest version through composer.

I guess this is related to https://roundcube.net/news/2020/04/11/changes-in-roundcubes-plugin-repository

We’d like to make the switch on May 17th 2020. On this day, the repository data of plugins.roundcube.net will be frozen

It goes on to say

Once a plugin is listed at packagist.org, Roundcube’s plugin repository will no longer list it in order to make packagist.org the only source.

but may be something went wrong? by now all plugins should be listed on packagist.org so if you remove https://plugins.roundcube.net from the repositories list in your composer.json then may be that will solve your issue.

 Removing this section from my composer.json:
"repositories": [
    {
        "type": "composer",
        "url": "https://plugins.roundcube.net"
    }
],

does the trick and updates easy_unsubscribe to the latest commit (with no ill side-effects I noticed).
But then why is that repo still part of the official composer.json-dist? 🤔

Roundcube hast removes https://plugins.roundcube.net from its composer.json now: https://github.com/roundcube/roundcubemail/commit/6ace57e8e1cb3f408e09478d8c57433d2c5ad57c … so I guess this problem will go away in time :)


add memory quota configuration

cc tikv/tikv#5524

https://github.com/tikv/tikv/blob/release-3.0/etc/config-template.toml
The master branch does not have this parameter and may need to add another pr to the release-3.0 branch.


chore: use release/renovate-lib.json

Signed-off-by: davidko<EMAIL_ADDRESS>Which issue(s) this PR fixes:

Issue #
What this PR does / why we need it:
Special notes for your reviewer:
Additional documentation or context

@coderabbitai pause


Invalid manifest problem on quay.io releases

Hi,
We're using Helium's official Docker repo for our base images and doing multi-architecture deployments (amd64 and arm64). Therefore current releases are perfect fit for us. But we can't pin our images to a tag directly as newly built image doesn't contain the correct architecture base image and gives error about architecture mismatch. Hence we have to pin base images with their specific architecture SHA and obviously this creates problems with multi architecture deployments.

My hunch says these two unknown entities could be the issue, but of course I'm not sure. What could be done to workaround this issue?

@MuratUrsavas could you post the exact error you are getting back?

@isergieienkov do you have a similar problem?

Are you using docker buildx?

Are you using docker buildx?

Yes we are

Are you using docker buildx?

The two ghost architectures seem to be causing issues

an actual error message would be helpful

@madninja Here's the error container is throwing at start:
standard_init_linux.go:219: exec user process caused: exec format error

This happens with architecture mismatch.

@madninja Here's the error container is throwing at start:
standard_init_linux.go:219: exec user process caused: exec format error

This happens with architecture mismatch.

thanks for the report.. LongAP pointed out there appear to be two additional manifests in the docker image that not all docker systems are apparently able to deal with. We'll get this fixed.. cc @JayKickliter

Canyon try the most recent test-image? I got rid of the problematic manifests.

Fixed with #412

Working well for us now.
Thanks for the quick resolution 😁

Just FYI you can also solve this by using a platform tag in GitHub actions docker build (if building a new container based on the helium one)...
      - name: Build and push
        id: docker_build
        uses: docker/build-push-action@v3
        with:
          push: true
          platforms: linux/arm64

This then correctly pulls the image.
See here for reference: https://github.com/NebraLtd/hm-gatewayrs/blob/6881bf6e472e5239065487c4be72af71ba5f35d0/.github/workflows/compile-docker.yml#L51


Visualize service metrics

#116 added a way to track message ingestion. Can track total number of users and messages over time.

Okay so the badge I just created counts the total history of messages sent. Maybe it's worthwhile to also emit some stat like messages per month (running 30 day count).


wrong URL in samples/09-download-build-use-jsoncpp/install_script.cmake

set(uri "ttps://github.com/open-source-parsers/jsoncpp...
missing 'h'

yeah I have that fixed already.  I need to redo some samples because I changed the dependency management system quite a bit.  I will be able to merge it soon.