Guarded columns are not refreshed when a DB schema is changed

Guarded columns are not refreshed when a DB schema is changed

Laravel Version: v6.18.35
PHP Version: v7.3.18
Database Driver & Version: MariaDB 10.2.31

Description:
Guarded columns are not refreshed when a DB schema is changed. It is broken by commit https://github.com/laravel/framework/commit/897d107775737a958dbd0b2f3ea37877c7526371
It is a problem for data seeding in migrations.
Steps To Reproduce:
Model Setting.php
class Setting extends Model
{
    /** @var array */
    public $guarded = ['id'];
}

Migration 2020_01_01_000000_create_table_settings.php
public function up()
    {
        Schema::create('settings', function (Blueprint $table) {
            $table->increments('id');
            $table->string('key');
            $table->text('value');
        });

        Setting::query()->firstOrCreate(
            [
                'key' => 'min_password_length',
            ], [
                'value' => '10',
            ],
        );
    }

Migration 2020_02_02_000000_add_module_to_table_settings.php
public function up()
    {
        Schema::table('settings', function (Blueprint $table) {
            $table->string('module')->default('system');
        });

        Setting::query()->firstOrCreate(
            [
                'module' => 'eshop',
                'key' => 'max_order_weight',
            ], [
                'value' => '100',
            ],
        );
    }

The result is that in Laravel v6.18.35 is model (key: 'max_order_weight', module: 'system'), but in versions <v6.18.35 is model (key: 'max_order_weight', module: 'eshop').
It is because static::$guardableColumns[get_class($this)] is now filled in first migration and is not longer reflecting schema changes.

Don't put eloquent models in your migrations. Use the DB facade.

We have about ~500 migrations. So we need get through each migration and rewrite every use of any model?
All because of this bug? Really?

I really don't recommend using any app-logic in your migrations. Simply because it's changeable and you're hard wiring your app layer to your database model. This leads to this kinds of problems. More changes could happen in the future to Laravel or your app that could lead to you having to update your migrations regardless.
Migrations are also something you run just once against your production data. When your data has been migrated you usually don't need any logic in your migrations anymore that modify data because it's already been updated. You can safely discard code in those migrations afterwards.
Laravel 8 will come with a schema:dump command btw allowing you to squash previous migrations so you don't need to update them. It'll be out in a little under a month.

I agree that we are using migrations probably wrongly. But this is BC break and should be in major version, not in patch version.
We can not discard this code from migration due that settings are required for feature tests :slightly_smiling_face:

This was a security vulnerability fix. So this doesn't counts to a BC promise. We try to avoid that as much as possible but sometimes, like now, we didn't have a choice.

We can not discard this code from migration due that settings are required for feature tests 🙂

Sounds like you need seeders/factories for this instead? If you hop onto discord I'd be happy to take a look at an example if you have one. hmu in #help

Ok, thank you for your patience :slightly_smiling_face:
For now i've put a composer.json conflict with Laravel >= v6.18.35 to our testing package and create high priority backlog task for refactoring migrations.

@driesvints This is a SUPER old issue, but I'm wondering if your stance on not having model logic inside a migration has changed since the introduction of foreignIdFor in Laravel 8.x.
It strikes me a bit odd that Eloquent\Concerns\GuardsAttributes is responsible for "caching" a table's schema, and not Schema\Builder's getColumnListing method. Even if this overall GH issue isn't a desired use-case, could it make sense to move this logic into Builder? — and if so, exposing a way to reset the Builder's cache wouldn't seem that far off in my opinion.
getColumnListing seems like a pretty critical underpinning of how Laravel talks to the database, so I wouldn't be surprised if I'm making a major oversight here.


Occurrence mutation should validate the start time against enrolment

PT-934. As a provider when I mutate occurrence to API, it should validate the start time against enrolment
Enrolment summary enrolments are ordered by status to get same snapshot every time when running pytest.
NOTE: New design for occurrences could be waited before resolving this pull request, because it's been already talked that occurrence start and end time fields could be changing.  They should not affect on API, but who knows...

After some clarifications and discussions, this should be good to be merged.


Enable Callblock for DECT Phones

Hello,
Is it possible with ha-fritzbox-tools to enable/disable Callblock for specific DECT Phones ?
So you can do something like a do not disturb button in Home Assistant to disable all ringing ?

+1
i would love to enable/disable dnd for phones by arming/disarming the house-alarm

+1
i would love to enable/disable dnd for phones by arming/disarming the house-alarm

Heyho,
Just a question is there any plan to integrate that sooner or later?
Just curious no pressure ^^

This custom integration is soon fully ported into Home Assistant Core.
New feature might be added directly to core, then.
Personally, I'm not motivated to implement it, because I have no DECT devices. But PRs are always welcomed.

Wow thanks for the quick reply.
Where do I have to submit the PR then? Is this still enough?

This is the ported HA core integration: https://github.com/home-assistant/core/tree/dev/homeassistant/components/fritz
However, I recommend you wait until the following PR is merged, because it will integrate the first switches into the integration: https://github.com/home-assistant/core/pull/51610

This custom integration is now deprecated because is fully merged into HomeAssistant core.
I would suggest you configure the new integration and retest your issue; if still present then open a issue on HomeAssistant Core repository.
Simone


Can save an 'error' step in workflow without a 'message' argument

Steps to reproduce

Create a workflow
Add an 'error' step
Add a message
Save the workflow
Remove the message
The workflow is saved successfully

Expected behaviour
I think we should either make it mandatory to always require an argument or remove the requirement
Note
If we decide to remove the requirement, we should check if a 'message' argument is provided. If it's not, we shouldn't add a semi-column at the end of the toast error message and error workflow step title

Don't see a point in doing this anymore. The user should be able to choose whether to provide an error message or not. The title in the error step can be changed via the UI and the syntax of the error message is the same as any error message.


Validation error doesn't appear due to missing id in input field when altInput is enabled

I understand that when the altInput is enabled a second input field is created but without an id but since that is the visible one now, it breaks frontend validation
So i have this to ask.
if it is an easy fix and it doesn't cause too much trouble is it possible to move the id to the new input when the altInput is enabled ?
thanks
alex
<div class="input-group">
  <input name="patient_info[dob]" id="patient_info_dob" data-wpl-datepicker="" required="true" type="hidden" class="flatpickr-input">
  <input class="flatpickr-input form-control input error" placeholder="" required="" tabindex="0" type="text" readonly="readonly" aria-describedby="-error -error" aria-invalid="true">
</div>

https://jsfiddle.net/wgc6b1mk/1/
Environment

flatpickr version used: v4.5.2
Browser name and version: Version 71.0.3578.98 (Official Build) (64-bit)
OS and version: ubuntu 18

Same problem here, when altInput is set to true, the original field containing the id changes to type: hidden so no validation library can actually bind to it.

Any news on this?


Only top message is shown, exception message with helpful information is not visible

I have AirBrake integrated with NLog. When I run code similar to the provided below and then go to AirBrake website to see the logged error, I only see the top message ("foo"). I would also like to see exception.Message ("bar") and exception.InnerException.Message ("baz"), but they are not there.
var message = "foo";
var innerMessage = "bar";
var innerInnerMessage = "baz";
try
{
    try
    {
        throw new Exception(innerInnerMessage);
    }
    catch(Exception ex)
    {
        throw new Exception(innerMessage, ex);
    }
}
catch (Exception exception)
{
    //NLOG
    _logger.Error(exception, message);
}

@realnickivanov, a message provided to log method is replacing first exception message. Messages from inner exceptions you can find in Backtrace section of error log.


Reorganise documentation

This PR closes #275 and # by reorganising the documentation. Note that many of the files are placeholders and need content (and also issues to drive content creation).

[!WARNING]
I haven't tested this locally so it may ping off the CI a few times as I update it.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.18%. Comparing base (3624ca0) to head (57979e5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #320   +/-   ##
=======================================
  Coverage   93.18%   93.18%
=======================================
  Files          50       50
  Lines         528      528
=======================================
  Hits          492      492
  Misses         36       36

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@SamuelBrand1 what do you think of this so far?
Any thoughts as to why the build function is having problems? As far as I can tell nothing has changed here that should be causing the pathing error it is throwing and yet...

Looks like you need to move the underlying data? Missing dir/file is causing the documenter CI fail.

I think this should now build. Note I did some reorganisation vs before. The issue was in the @contents call. It looks like using the side bar panels has some confusing bugs that are hard to pin down. The main issue was that even commenting them out didn't do away with the. bug


swaybar eats a lot of memory

Coming back to my laptop after a few days away (swaylock running), I had to hard kill swaybar as it was using more than half of my available memory. My swaybar is just using the straight i3status configuration.
I'd be glad to contribute more information.

A fix for this is in tomorrow's release.


The latest version is failing on iOS

The latest version of nativescript-menu is failing on iOS. Just yesterday the menu was showing fine on both iPad and iPhone but today after I updated it, the menu doesn't show.
Can you please check.
P.S It works fine on Android. I've tested it extensively.

@ibnYusrat can you tell me what error message

Yes when I tap the button that brings up the menu I get this:

CONSOLE LOG file:///app/0.js:120:20: Select group for searching called. CONSOLE ERROR [native code]: ERROR TypeError: undefined is not a function (near '...nativescript_menu__WEBPACK_IMPORTED_MODULE_4__["Menu"].popup...') CONSOLE ERROR [native code]: ERROR CONTEXT { "view": { "def": { "nodeFlags": 16793745, "rootNodeFlags": 17, "nodeMatchedQueries": 6, "flags": 0, "nodes": [ { "nodeIndex": 0, "parent": null, "renderParent": null, "bindingIndex": 0, "outputIndex": 0, "checkIndex": -1, "flags": 16, "childFlags": 0, "directChildFlags": 0, "childMatchedQueries": 0, "matchedQueries": {}, "matchedQueryIds": 0, "references": {}, "ngContentIndex": -1, "childCount": 0, "bindings": [], "bindingFlags": 0, "outputs": [], "element": null, "provider": { "deps": [] }, "text": null, "query": null, "ngContent": null }, { "nodeIndex": 1, "parent": null, "renderParent": null, "bindingIndex":<\M-b\M^@\M-&> removing all entries config 0x282c40cc0 TIC TCP Conn Cancel [14:0x28192b0c0]
And my function looks something like this:

i-e:
selectGroupForSearching() {         console.log('Select group for searching called.');         Menu.popup({             view: this.page.getViewById('menuLabl'),             actions: [{id: '', title: localize('all_groups_label')}, ...this.companyGroups]         }).then(value => {             if (value) {                 this.currentlySelectedSearchGroup = value;             }         }).catch(console.log);     }
This does work just fine on Android by the way.

I'll fix it soon

Thank you very much. This is really strange because if I do something like
if (Menu.popup){ console.log('Menu.popup is Defined.'); } else { console.log('Menu.popup is undefined.'); }
I actually get Menu.popup is DEFINED on Android and Menu.popup is undefined. on iOS...
Strange.. 🤔

I fix it
the error come because I forget define popup as static method in iOS

📦<EMAIL_ADDRESS>available now


GH-8 update resolver required field error message to use directive keys

As per GH-8 this PR updates the resolver error message when a required field is missing to provide the directive keys which can be used to satisfy the constraint without knowing the implementation's golang struct Field names.

Closed since #10 was merged to address this issue. Which gives the opportunity to the lib users to override the default error handler used by http.NewInput middleware. And a new field Directives has been added to InvalidationFieldError, which should be useful for customizing user specific errors.


Add contextSize test parameter to enlarge the scope of a diff

As per description, this PR introduces a contextSize overridable suite parameter that control the number of lines around the reported diff in case of a mismatch ( ala grep -A <n> -B <n>)
Ofc the normal behaviour was kept identical to the actual, and there's no change in the user API (at least for the methods used via Assertions)

Hmm, given that a lot of the stuff in Diff is effectively exposed the mima check screams with 11 compatibility errors. I'll try to figure out a better encoding for the content of this PR, so don't take it too seriously for the moment 😇

Shouldn't this be a parameter to the runner https://github.com/scalameta/munit/blob/8b63f0e7f8574cd7910816d171d98bbf2507d672/munit/js-native/src/main/scala/munit/internal/junitinterface/JUnitFramework.scala#L110 ?

Shouldn't this be a parameter to the runner
https://github.com/scalameta/munit/blob/8b63f0e7f8574cd7910816d171d98bbf2507d672/munit/js-native/src/main/scala/munit/internal/junitinterface/JUnitFramework.scala#L110
?

Interesting question. Going further: should it just be a parameter or also a parameter?

I think just a parameter since it doesn't really change the test logic, but how the test is being displayed. Potentially we could have runner defaults for a specific suite as a separate thing.

btw. MiMa is not a huge issue here, we would need to do 1.1.x next so that it's automatically picked up as possible incompatibility

I think just a parameter since it doesn't really change the test logic, but how the test is being displayed. Potentially we could have runner defaults for a specific suite as a separate thing.

Okay, this seems reasonable. I'll try to rework it. I'll also try to add documentation about that flag maybe here: https://scalameta.org/munit/docs/troubleshooting.html


fix #1703 Changing the comparison project related and not UPath related

PR Details
The Comparison was wrong as the UPath always fits the main Project.
It will never reach the other Projects
So i changed the Comparison to be Project related and not UPath related
Description
Related Issue

Motivation and Context
that bug was annoying.
Each change in a sub project didnt get reloaded.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

The check for when the modified file was in the obj directory was to not reload the project in case a generated file was modified (what other .cs files are there in obj?).
Why that check? And why was this check making the reload to fail?
Also, this hardcoded obj directory name is brittle. Maybe we should (in other PR) make the project system use the MSBuild variables like $(IntermediateOutputDir).

Why that check? And why was this check making the reload to fail?
it failed because the obj path is always in the main project as it includes all others
so if you change your sub project. it detects that the obj path has changed, so it will report that assembly to be reloaded and at that point it doesnt care anymore which file changed.
so it will always report your mian assembly to relaod, it cant ever possible reload the sub project

I see. Then the changed files should be tracked at a solution level, then decide to which project it belongs, and reload it.

you can detect the Project which it belongs to by not comparing with the obj path
change incomming => obj path change => project file change
thats the order of changes
with my comparison i skip the obj path so i only watch project file changes and these i can find with the documents of the assembly
and all in all it works EXCEPT renaming.. which im currently tracking down
create,
alter,
delete works

uhhh to be fair... renaming doesnt work in the main project either
hmmm.. so my thing fulfills what is currently "working" in the main project.. which doesnt include renaming

@Ethereal77 thanks for mentioning that i search through the documents and not the root path of the dir.
Now renaming and deleting and creating works in sub projects.
you get a popup after renaming "files have changed" but it reloads then correctly
i tested it for now .. would be nice if someone else could test it

what doesnt work is deleting through game studio a file and get a reload as it doesnt trigger the projectwatcher
because it doesnt delete the file at all, it just excludes it so that is intentional i assume and wanted to be.
If you create a script asset in a sub project it should reload right after adding it and you should have the new class available

from my tests this PR works...  if someone else could check it out it would be nice as i doubt that i can cover everything
there are no unit tests for this and i doubt that im able to write them as i barely understand broadcasting with async

it doesnt matter which source does it.
If game studio really deletes it then it will trigger the project watcher
but the studio doesnt do it so it wont trigger the watcher
i dont know how this is integrated and i didnt watch into that, i first wanted to fix the project watcher that it handles the developement in VS correctly
trying to delete for this test from gamestudio was the first time i used that functionality

used it now for a few days and couldnt find any side effects, would be still good if someone else could test it additionally

I'm getting a couple of issues after creating a new script from the asset view,
A popup shows up with:
Game Studio can't auto-reload the project file MyGame3.csproj because you have local changes such as new or deleted scripts.
Click OK to keep reloading or Cancel to keep the current version.

And the build output shows the following:
[CSC(0,0)]: Error: Cannot open 'D:\Documents\Stride Projects\MyGame3\MyGame3\obj\Debug\net6.0-windows\MyGame3.pdb' for writing -- 'The process cannot access the file 'D:\Documents\Stride Projects\MyGame3\MyGame3\obj\Debug\net6.0-windows\MyGame3.pdb' because it is being used by another process.'

Pressing the reload button after this does work though.

i cant recreate that issue.
how did you open stride and VS?

i opened stride
launched through solution explorer VS
create async script in asset view

and this didnt give me an error. How did you do it?

It works fine if I don't launch in debug mode through VS, so probably my VS messing with it. Do you have time to try this out @manio143 ?

Nah, I don't have it enabled either

I can confirm that when GameStudio is launched in Debug mode through VS there's something broken with the reloading and locking the pdb file. That happens on save inside GameStudio.
If you afterwards click manually the assembly reload button it works without issue, which suggests the problem is at the point where recompiling is triggered.
When running GameStudio from the launcher I was getting a crash on loading freetype DLL. Not caused by this ofc, but something to look at later.
Running GameStudio from debug bin folder directly (rather than through VS) worked fine.

Another thought I had though - in the code we now check that the file path starts with the project folder path. This can be a problem for files explicitly included in the project with <Compile Include="../Shared.cs" />, right?

Another thought I had though - in the code we now check that the file path starts with the project folder path. This can be a problem for files explicitly included in the project with <Compile Include="../Shared.cs" />, right?

ive tried it
here the problem is that the normal stride and my PR dont cover that case for reloading as the project watcher doesnt cover such a file
you dont get the reload assembly notification in neither stride versions... so there is a problem with the project watcher which is a problem for another PR

so the summary is:
the locked pdb file also appears in master
project watcher doesnt cover it in master or my PR


Update CHAIRS.md

Creating an official open slot on July 1st as that is my last day being a co-chair.
Please do not merge until after July 1.
Signed-off-by: Chris Short<EMAIL_ADDRESS>

/hold

Dag nabbit DCO


Twitter report: Warn others does not work "Es konnte keine Übermittlungs-TAN erstellt werden."

Avoid duplicates

[X] Bug is not mentioned in the FAQ
[X] Bug is specific for Android only, for general issues / questions that apply to iOS and Android please raise them in the documentation repository
[X] Bug is not already reported in another issue

Technical details

Device name: Pixel 4a
Android version: 12
App version: 2.17.2

Describe the bug
The Twitter user requested a TAN via the TAN hotline, entered it in the app and stepped through the "Warn others" process. However, at the very end, he sees this error message:

Steps to reproduce the issue

Request a TAN at the hotline
Enter the TAN
Step through the Warn others process
See the error at the end of the process

Expected behaviour
No error.
Additional context
Clicking on "Details" reveals this stack trace:
Ursache:
de.rki.coronawarnapp.exception.TanPairingException: Tan has been retrieved before for this registration token
	at de.rki.coronawarnapp.playbook.DefaultPlaybook.submit(DefaultPlaybook.kt:29)
	at de.rki.coronawarnapp.playbook.DefaultPlaybook$submit$1.invokeSuspend(Unknown Source:12)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:4)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:18)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:1)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:10)
Caused by: de.rki.coronawarnapp.exception.http.BadRequestException: Error during web request: code=400 message= body='
	at de.rki.coronawarnapp.http.HttpErrorParser.intercept(HttpErrorParser.kt:36)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:14)
	at de.rki.coronawarnapp.http.interceptor.RetryInterceptor.intercept(RetryInterceptor.kt:3)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:14)
	at okhttp3.logging.HttpLoggingInterceptor.intercept(HttpLoggingInterceptor.kt:5)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:14)
	at de.rki.coronawarnapp.http.interceptor.WebSecurityVerificationInterceptor.intercept(WebSecurityVerificationInterceptor.kt:3)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:14)
	at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:25)
	at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:12)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:920)

This is a Twitter report
The information in this report is based on the feedback from a Twitter user: https://twitter.com/kaugummiheld/status/1491100030589345792?s=20&t=4awuiciEbF56ti451dKT6Q. He said the TAN was entered into the app 2 minutes after he got it from the hotline.

Internal Tracking ID: EXPOSUREAPP-11782

It looks to be the same problem, that has already been reported one year ago. Because at that time the error dialog wasn't specific enough, the dialog was enhanced in https://github.com/corona-warn-app/cwa-app-android/pull/2161 .
What I understood from @mtwalli 's explanation is, that a user got a TAN from hotline, but when CWA tried to retrieve a token for that into CWA entered TAN from the web server, the web server couldn't find such a token.
It's unclear why the token can't be retrieved, but it looks like, CWA can't do anything about it.
Personally I would think it would be worth to try again after 5 or 10 minutes (maybe there is just a delay in the server infrastructure), but if it fails again, a new TAN would need to be generated by the hotline.

Internal Tracking ID: EXPOSUREAPP-11782

@vaubaehn
He tried it multiple times on different dates. Should I suggest to get a new TAN?

@Ein-Tim
In that case, I recommended to do so.
Hope there's not much waiting time in the hotline...

@dsarkar @mtwalli
The dialog text recommends to call the technical helpline... What is supposed how they can help in that case?

@vaubaehn
Okay, I suggested to call the hotline again. Is there really nothing what the app can do in this case?

@vaubaehn
Okay, I suggested to call the hotline again. Is there really nothing what the app can do in this case?

@Ein-Tim
I don't think that anything on CWA side can be done technically (although it's worth to re-evaluate the dialog text/whether the technical help line can actually help), but I would forward this question to @mtwalli to be sure.

@dsarkar
Do you know wether there is a plausibility-check of the entered TAN-code (like a one-digit 'Prüfsumme' inside the TAN-code itself) before CWA trying to retrieve the corresponding token on the server? If there is no such check, a simple typo (or misunderstood letter/number when read by the call center agent to the user) could cause this error, couldn't it?

@vaubaehn
Probably, all what the technical hotline can do to help you, is redirect you to the verification hotline.

Cause:
de.rki.coronawarnapp.exception.TanPairingException: Tan has been retrieved before for this registration token
at de.rki.coronawarnapp.playbook.DefaultPlaybook.wrapException(DefaultPlaybook.kt:131)
at de.rki.coronawarnapp.playbook.DefaultPlaybook.submit(DefaultPlaybook.kt:114)
at de.rki.coronawarnapp.playbook.DefaultPlaybook$submit$1.invokeSuspend(Unknown Source:15)
at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:571)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:678)
at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:665)
Caused by: de.rki.coronawarnapp.exception.http.BadRequestException: Error during web request: code=400 message= body='
at de.rki.coronawarnapp.http.HttpErrorParser.intercept(HttpErrorParser.kt:80)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at de.rki.coronawarnapp.http.interceptor.RetryInterceptor.intercept(RetryInterceptor.kt:15)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.logging.HttpLoggingInterceptor.intercept(HttpLoggingInterceptor.kt:154)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at de.rki.coronawarnapp.http.interceptor.WebSecurityVerificationInterceptor.intercept(WebSecurityVerificationInterceptor.kt:11)
at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
at okhttp3.internal.connection.RealCall$AsyncCall.run(RealCall.kt:517)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
at java.lang.Thread.run(Thread.java:923)

@svengabr @dsarkar @thomasaugsten @larswmh
Do we have an incident here?
Also see a Twitter user reporting this: https://twitter.com/timm_1991/status/1504100365171634179?s=21
FYI @fynngodau

@vaubaehn
Probably, all what the technical hotline can do to help you, is redirect you to the verification hotline.

After 20 minutes waiting in the hotline someone picked up and immediately hang up.

Another Twitter user having the same problem: https://twitter.com/_derTheoretiker/status/1514536930494623750?s=20&t=KQceXEF8eDkHhoJylWdcPg
He already tried it with separate TANs issued from the hotline but always receives this error. I asked him for an error log.
@thomasaugsten FYI

Here's the error log:
CWA Log 2022-04-14 18_33_24.372.txt

@mlenkeit Hey Maximilian, just a friendly reminder, maybe you or the team could take a look at the error log I shared above.

@Ein-Tim error log forwarded to internal ticket. Thanks!

@Ein-Tim thanks for sharing the log! I'm afraid the timeframe that is covered by the log is too short. We would need a log that captures what a sufficient amount of time before the error occurs. Ideally, the entire time frame from when the positive test result is received until the errors occurs. Realistically, this means users would need to turn error logging on before registering a test.

Here's another report on this: #5248.
The strack trace @FrederikP shared via https://github.com/corona-warn-app/cwa-app-android/issues/5248#issuecomment-1142016804 looks very similar to the one I posted in the OP.

@Ein-Tim  @FrederikP Thanks, case linked in internal ticket.

@mlenkeit
This seems to be a quite common problem:

https://twitter.com/count_tofu/status/1534923746359771138?s=21&t=rmW6bZnxXiCpYFICMUE1bg
https://twitter.com/wasserspeierdd1/status/1534930834326704128?s=21&t=rmW6bZnxXiCpYFICMUE1bg

Here are some related PRs for cwa-server:

https://github.com/corona-warn-app/cwa-server/pull/1849
https://github.com/corona-warn-app/cwa-server/pull/1854

Did the app already warn others or should I call the TAN hotline to get a TAN?

@Ein-Tim it depends on the details of the missing internet connection error message. From this information it's difficult to tell.
With a TAN from the TAN hotline, we would ensure that the warning is shared (given that the upload goes through then).

@mlenkeit
The stack trace of the missing internet connection message is lost, sadly.
I'll tell the user to delete the old test and request a TAN at the hotline, just to be on the safe side.
Thanks for your fast response.

FYI This PR is intended to improve the situation: https://github.com/corona-warn-app/cwa-app-android/pull/5335

Another PR somewhat related to this problem is #5384

We hope that https://github.com/corona-warn-app/cwa-app-android/pull/5335 fixes this issue for good. The fix will most likely be included in 2.26.

I can't verify the fix myself bug I assume the bug was fixed successfully.


Baseball Game LeetCode

Hi @sainik-khaddar, Please assign this issue to me. I want to work on it.

Hi @sainik-khaddar  can you please assign the issue to me? I want to code it in C++.
Thank You.

Hi @sainik-khaddar can you please assign this to me


Monitor Start Date

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
API, UI Feature, Other
🔖 Feature description
Making the start date feature would help making "Push"/"Heartbeat" checking be better.
Such as cron job checking, let's say a cron job will run daily at 00:01. if the kuma server restarted the checking time will be different -this happened for my cron job checking-.
✔ Solution
An input in Add/Edit monitor to specify the datetime value with timezone if possible.
Date format:
YYYY-MM-DD HH:ii:ss
example:
2022-12-20 20:41:11
❓ Alternatives
No response
📝 Additional Context
No response

I think this is a duplicate of https://github.com/louislam/uptime-kuma/issues/1482
If you agree, could you please close this Issue, as duplicates only create immortal zombies and are really hard to issue-manage?
If not, what makes this issue unique enough to require an additional issue? (Could this be integrated into the issue linked above?) ^^

I think this is a duplicate of #1482 If you agree, could you please close this Issue, as duplicates only create immortal zombies and are really hard to issue-manage? If not, what makes this issue unique enough to require an additional issue? (Could this be integrated into the issue linked above?) ^^

This is not a duplicate of the mentioned issue, the mentioned issue suggests a cron monitor, while what i'm suggesting is just a start date field. It can work with cron monitoring or not.

You could encode the start-date using, for example, https://crontab.guru/#0_1_8-12
Yes, this would be limited, but it would reduce visual clutter

@m-primo
What do you think about above proposal?
Is a monitor start date still nessesary or can this FR be merged into #1482 or #1723?

@m-primo What do you think about above proposal? Is a monitor start date still nessesary or can this FR be merged into #1482 or #1723?

It's not necessary but it would be great to have it, yes it can be encoded to a cron value, but still not like cron.
I understand that you want to avoid the visual clutter, but it's also great to have many options that would match individual use cases.
I hope you understand what I mean.


newTree.optimize is not a function

My package.json file
  "name": "testapp",
  "version": "0.0.0",
  "scripts": {
    "ng": "ng",
    "start": "ng serve",
    "build": "ng build",
    "test": "ng test",
    "lint": "ng lint",
    "e2e": "ng e2e"
  },
  "private": true,
  "dependencies": {
    "@angular-devkit/core": "^11.2.9",
    "@angular-devkit/schematics": "^11.2.9",
    "@angular/animations": "~11.2.9",
    "@angular/common": "~11.2.9",
    "@angular/compiler": "~11.2.9",
    "@angular/core": "~11.2.9",
    "@angular/forms": "~11.2.9",
    "@angular/platform-browser": "~11.2.9",
    "@angular/platform-browser-dynamic": "~11.2.9",
    "@angular/router": "~11.2.9",
    "@ng-toolkit/universal": "^1.1.21",
    "@schematics/angular": "^11.2.9",
    "rxjs": "~6.6.0",
    "tslib": "^2.0.0",
    "zone.js": "~0.11.3"
  },
  "devDependencies": {
    "@angular-devkit/build-angular": "~0.1102.8",
    "@angular/cli": "~11.2.8",
    "@angular/compiler-cli": "~11.2.9",
    "@types/jasmine": "~3.6.0",
    "@types/node": "^12.11.1",
    "codelyzer": "^6.0.0",
    "jasmine-core": "~3.6.0",
    "jasmine-spec-reporter": "~5.0.0",
    "karma": "~6.1.0",
    "karma-chrome-launcher": "~3.1.0",
    "karma-coverage": "~2.0.3",
    "karma-jasmine": "~4.0.0",
    "karma-jasmine-html-reporter": "^1.5.0",
    "protractor": "~7.0.0",
    "ts-node": "~8.3.0",
    "tslint": "~6.1.0",
    "typescript": "~4.1.5"
  }
}

I am getting error while installing @ng-toolkit/universal via ng add @ng-toolkit/universal command

Hey, the library is not yet upgraded to work with angular 9+ versions, and chances are it will not be in the near future. Read #826 for more information.
Thanks!


Icarl reproducible cl

Add iCaRL experiment

All the review are done :)

Great, thank you @rudysemola , I'll merge this :)


remove stacks error

Description
stack name prefix is 【docker-api_】，remove error
Steps to reproduce the issue:

resolve
update  v1.15.0

Hello @wo10378931
Sorry to up this closed issue but did you find a way to workaround this error and remove the stack anyway?

I have the same problem, running Portainer 1.16.4. There is just 1 stack which I cannot remove, although "docker stack ls" does not list it.

@peterforeman could you give us some reproduction steps?

Same issue here, I just created a docker-flow-proxy stack, updated it and decided to delete it too soon I think. Clicked remove and now I get "Unable to remove the stack" and "Unable to retrieve stack details". Initially the stack was physically in docker when I got "Unable to remove the stack" so I removed it manually because I was already getting the "Unable to retrieve stack details" error. This seems to be an orphan entry now in the DB. Not sure how to better describe it.

@khelkun
@peterforeman
I used potainer api to del stack。
Forgive my bad English ~~

@wo10378931
Confirmed, removed despite a 404 returned. :)

@wo10378931
I tried, but I still get a 404. I'm just gonna open the SQL lite DB file later and remove the entry manually...

I can't even open the DB. It doesn't seem to be SQL lite. I give up, a day of failures today.
Even my docker test swarm is corrupted because I was fighting with it trying to release the ports after the containers were removed.
Gonna remove the VMs and start again.

Our DB is Bolt, not SQLLite..

@mateuszdrab
must be login ~  can use postman

@wo10378931
I did login, got the auth token and submitted it with each request.
Other functions work fine.

@mateuszdrab clean your browser cache and then access Portainer UI again, some data might still be persisted.

Ctrl Shift R to force a refresh
Rgds,
Neil Cresswell
On 3/04/2018, at 10:13 AM, Anthony Lapenna <notifications<EMAIL_ADDRESS>wrote:
@mateuszdrabhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mateuszdrab&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=6y8o1T1bt6414RVu0bvfNaw8AujEvXQ942U-m1Aod-Y&s=RVso4wiRkFvLfzEaQATodjIubDbp9PPHxP927S5IEPo&e= clean your browser cache and then access Portainer UI again, some data might still be persisted.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_portainer_portainer_issues_1571-23issuecomment-2D378063047&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=6y8o1T1bt6414RVu0bvfNaw8AujEvXQ942U-m1Aod-Y&s=uNTN7vX_Q7LjPPHdnpjyYXfMd3aV6RERoP-oqV7z3Lw&e=, or mute the threadhttps://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AWGrlXFJ0vAZdEeCzhlVB6s02FZlgPP5ks5tkqKdgaJpZM4RhQ7F&d=DwMCaQ&c=euGZstcaTDllvimEN8b7jXrwqOf-v5A_CdpgnVfiiMM&r=0fx0h4vB56iTLpw2McH1ZD6TqG_QGpbggVOB-PfMJpM&m=6y8o1T1bt6414RVu0bvfNaw8AujEvXQ942U-m1Aod-Y&s=FGvy7e8LiJ8jKNNOYDGkM2xVLq5VqYr0natTsZDqQGI&e=.

Upgraded to 1.16.5 and removal worked this time. Seems fixed.


Bug:  DS 1.5 Fiori components display error when dragged onto canvas

When a Fiori App Header, Fiori Bar, Fiori Toolbar and Launchpad component are dragged and dropped onto the design canvas, the following error message is displayed:

looks like is corrected already by Mike, release of today does not have this bug any more


oscap: add oscap scanning of inspected image

This is mostly based on https://github.com/OpenSCAP/openscap/tree/maint-1.2/utils/oscap_docker_python

@enoodle please move the openscap to a separate file.

@enoodle I merged #2. Now you should be able to test this an easier way.

@simon3z backward comp for image inspector client: Should there be an api version bump?

@enoodle do not pollute the target image with the results. The results should be stored outside of the image root and served through a specific api endpoint e.g. /api/v1/openscap (not inside content).

@simon3z backward comp for image inspector client: Should there be an api version bump?

In this case (since we're adding), it's not strictly required.

@enoodle @isimluk running:
$ sudo ./image-inspector --image=docker.io/richxsl/rhel7 --path=/tmp/image-content
2016/04/04 23:27:19 Image docker.io/richxsl/rhel7 is available, skipping image pull
2016/04/04 23:27:19 Extracting image docker.io/richxsl/rhel7 to /tmp/image-content

I get that the image is both oval:org.open-scap.cpe.rhel:def:6 and oval:org.open-scap.cpe.rhel:def:7:
# export OSCAP_PROBE_ROOT=/tmp/image-content
# export OSCAP_PROBE_ARCHITECTURE=x86_64
# export OSCAP_PROBE_OS_NAME=Linux
# export OSCAP_PROBE_OS_VERSION=version
# export OSCAP_PROBE_PRIMARY_HOST_NAME=localhost

# oscap oval eval --id oval:org.open-scap.cpe.rhel:def:6 /usr/share/openscap/cpe/openscap-cpe-oval.xml
Definition oval:org.open-scap.cpe.rhel:def:6: true
Evaluation done.

# oscap oval eval --id oval:org.open-scap.cpe.rhel:def:7 /usr/share/openscap/cpe/openscap-cpe-oval.xml
Definition oval:org.open-scap.cpe.rhel:def:7: true
Evaluation done.

@isimluk is this the correct behavior?
If so @enoodle should update this PR to reflect the fact that we have to run multiple sets of rules.

It is bug in OpenSCAP. It has been recently fixed in OpenSCAP/openscap ticket #348. Release should go out soon.

@enoodle you need to rebase

@enoodle actually now that I think of it... probably also for @pweil-'s use case the openscap flag should define where the ARF report should be placed, e.g.
# image-inspector --image=fedora:20 --path=/tmp/image-content --openscap-results-arf=/tmp/image-report.xml

@pweil- can you review? Thanks!

minor nits, LGTM :+1:

@enoodle @pweil- schedule is getting tight so let's give this PR the priority, which means:
@enoodle please address all comments (either fix the code or reply to the comment).
@pweil- I am going to queue any other PR you have behind this.

@pweil- @simon3z Looks to me like we addressed all the comments on this PR, What do you think?

all my feedback has been addressed.  LGTM

I added tests for image-inspector's scanImage.

@enoodle have you tested this with ManageIQ? How much are you confident that this is final?

@simon3z if the user doesnt give any path dir ae create a random one, do we want that for the scan results dir as well?

@enoodle yeah seems reasonable. Maybe you can extract/reuse the same code (with different paths).

@simon3z I think I know how to improve on the tests for createOutputDir, I will add that tomorrow morning.

@simon3z I got it. path and scan-results-dir will now act similarly.


Extract the screen image and export it through the API

Getting the image from the game is already implemented by @zemaria2000 now it's only needed to send it through the API.

Some links with methods that could be useful for this particular task:
https://maven.fabricmc.net/docs/yarn-1.17-rc1+build.1/net/minecraft/client/util/ScreenshotRecorder.html
https://maven.fabricmc.net/docs/yarn-1.16.4+build.1/net/minecraft/client/MinecraftClient.html#currentScreen

This feature was implemented.


Manual Entry window broken

Going to the logging window, selecting Manual Entry, and attempting to enter roasting data by hand in the table view does not work. As the feature exists right now, there's very little reason to keep it as it was never well integrated, accessing that through a window that generally depends on being connected to something that can log roasting data automatically makes very little sense, and people have not been trying to use this feature.
It does, however, make sense to provide a way to manually enter batch data into the roasting log in order to use Typica's database for some of the surrounding functionality. Sample roasting is a major example as many use sample roasters with designs that effectively prevent meaningful instrumentation. Investing in hardware retrofits just for being able to use Typica on a machine that would not generate useful roasting data is a poor value proposition and with some machines would not be practical even if it were affordable. This would also provide a way for people to try using more of Typica's features before investing in hardware for automated logging on machines where that would make more sense.
A manual log entry option also seems like a good place to provide hooks for importing roasting data collected by other programs.

Fixed for 1.8.


New Game Tool spec preview not working

Looks like displaying system specs is broken when selecting different templates in the new game tool.

This is fixed.


executing vscode in wsl throws error

VS Code Version: 1.81.1
OS Version: windows_NT x64 10.0.22621

"Ubuntu 22.04.2 LTS (WSL)

Steps to Reproduce:

run code .
get

(yesterday it still worked)

🤔 is that the wrong executable ?

small update the code binary over at C:\Program Files\Microsoft VS Code\bin\code is the one calling the Code.exe

This is a WSL issue: https://github.com/microsoft/WSL/issues/9905


Is there a plan to add more flexible methods for setting quantization configs

There are some scenarios require more flexible and powerful methods for setting quantization configs, for examples:

Setting different quantization bits for the same type of operator: Taking conv as an example, in the first few layers of the model, it is usually necessary to set conv to qint16 to improve model accuracy, and then set it to qint8 to improve model performance
Operator fusion: In the scenario of conv+bn, it is usually necessary to remove the conv fused with bn to improve deployment performance on NPUs
Heuristic setting of quantization configuration, such as OpA ->OpB. If OpB can be both int8 input and int16 input, then it is best for OpB's input type to be consistent with OpA's input type to avoid quantization and improve performance

Most of the above features require the compute graph(aka. fx.Graph), but the README highlight that quanto is based on the eager mode. May I ask how the above problems were considered?

Setting different quantization bits for the same type of operator: Taking conv as an example, in the first few layers of the model, it is usually necessary to set conv to qint16 to improve model accuracy, and then set it to qint8 to improve model performance
You can do that already: just call quantize multiple times on the specified layers instead of calling it once for the whole model.

Operator fusion: In the scenario of conv+bn, it is usually necessary to remove the conv fused with bn to improve deployment performance on NPUs

quanto is a quantization toolkit, no more, no less. Graph rewriting is out-of-scope, as we want to avoid "mission-creep".
But we hope quanto is versatile enough to be combined with other tools.

Heuristic setting of quantization configuration, such as OpA ->OpB. If OpB can be both int8 input and int16 input, then it is best for OpB's input type to be consistent with OpA's input type to avoid quantization and improve performance

This already supported: https://github.com/huggingface/quanto/blob/9192ef865fe3dfe05bc867a6aa2f1e2276e7d6f8/quanto/calibrate.py#L30.

FYI, I did not need to use the fx graph because I used a custom DispatchMode to "observe" the actual graph myself directly.

@dacorvo To my knowledge, with the DispatchMode, operators can only access info of other operators exactly before and after them, but not larger scope information(If wrong, please feel free to correct me). However, for the performance optimization (e.g. to avoid heavy requantization), sometimes access to larger scope information is necessary."

@shuokay yes you're right, but it is a bit smarter than that thanks to the tensor subclasses: I can track where they come from, which allows for more global heuristics.
Anyway, this is for straightforward optimization: advanced algorithms should use pattern matching an graph traversal using dynamo. I am not so sure it should be part of quanto though.

@dacorvo  I have worked on an quantization framework that based on fx.Graph before,  it worked well in most cases, but it is hard for users to debug if the model accuracy is not as expected, so I guess quanto is a good try. What's more, if we make quanto compatible with dynamo which I think is one of quanto's targets, it is not very hard to add support for graph rewrite.


Splash screen duration

I was using  https://pub.dev/packages/flutter_i18n  fir translations in my app, due to a black screen after splash screen I had tried this plugin. It’s working well but my splash screen display duration went from 2 seconds to 6 seconds. Why is it so long? I tried with and empty project and it’s the same time

@duduf15
This doesn't sound like something related to flutter_i18n but something else that you changed or added to your project. Check the git history/diff and try to find out why.

Thank you I will check


Missing "reference" substatement in "revision" statement

Validating the Core IM 1.4.1 with pyang --lint core-model.yang
results in
core-model-1-4.yang:34: error: RFC 8407: 4.8: statement "revision" must have a "reference" substatement

In UML2YANG tool , the pruning and refactoring section of core-model is having the neccessary code changes to include the "reference" substatement

 revision 2019-11-27 {
    description
      "Package equipment-specification has been deleted,
       because of wrong key statements and overall grouping never applied.";
    reference
      "ONF-TR-512, RFC 6020 and RFC 6087";
  }

We also generated a ReleaseCandidate#1 for the core-model and able to see the "reference" substatement.
This will be available if we generate and publish a new release of the core-model-1-4.

Implemented as decided.


Check i18n plural rules

See https://regisphilibert.com/blog/2018/08/hugo-multilingual-part-2-i18n-string-localization/

If the current language is English, your “Mice count” is 0, and you set the zero plural tag to This story has no Mouse, you’ll still end up with the other string, This story has 0 Mice.

For the zero string to show, the current language would have to be Arabic or any other one which supports the zero plural tag

The above looks like a very odd restriction to me. I must admit I haven't tested this, but If I define a zero for a string in Norwegian, then I know what I'm doing -- I don't see how some "i18n plural ruleset" could do better than me?
/cc @nicksnyder @regisphilibert

I don't see how some "i18n plural ruleset" could do better than me?

If you decide Hugo should allow zero and two plural tags in any languages, and therefor adopt its own plural rule set rather than the universally accepted one, I would support you, but again I am no professional linguist and may miss something big here.

The current design of go-i18n relies on CLDR categories. These categories are abstract because zero, one, two does not mean 0, 1, 2 in all languages. For example, the zero category is not used in English and matches more that just 0 in Prussian.
If your application wants to have a special case for a specific number (e.g. 0), then it shouldn’t rely on CLDR categories. Instead, the special case needs to be its own translation id and you need to handle that in application logic.
if mouseCount == 0 {
    // special message for 0
} else {
    // regular message
}

See also: https://github.com/nicksnyder/go-i18n/issues/112
I don’t know if “just add an if/else in Go code” works for Hugo users. If it does then that is the right solution. If not then this is essentially a feature request.
Naively allowing users to define zero for languages that don’t have that category would only mask the problem for those languages. If the application had both English and Prussian (for example), it would appear to work for English but it wouldn’t be possible to have the special case work in Prussian. This would also only work for 0, 1, 2 unless we allowed users to define their own categories.
A general solution might involve allowing users to specify numeric translation keys for exact matches (instead of overloading the names of CLDR categories). I have not thought through the implications of this.


Chore/logbooks view model selectors

Description
Replaces individual selectors for logbooks views with page view selector.
Motivation
Background on use case, changes needed
Changes:

Create new selector selectLogbooksDashboardPageViewModel
Replace individual selectors in logbooks dashboard with new selector

Tests included/Docs Updated?

[x] Included for each change/fix?
[x] Passing? (Merge will not be approved unless this is checked)
[ ] Docs updated?
[ ] New packages used/requires npm install?
[ ] Toggle added for new features?
[ ] Requires update of catamel API?

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

7 of 7 (100.0%)  changed or added relevant lines in 3 files are covered.
3 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.06%) to 73.605%

Files with Coverage Reduction
New Missed Lines
%

src/app/logbooks/logbooks-dashboard/logbooks-dashboard.component.ts
3
80.49%

Totals

Change from base Build<PHONE_NUMBER>:
0.06%

Covered Lines:
3555

Relevant Lines:
4446

💛  - Coveralls


Added v2_03_22 attributes

lib/lvm/attributes/2.03.22(2)/lvs.yaml    | 384 ++++++++++++++++++++++++++++++
lib/lvm/attributes/2.03.22(2)/lvsseg.yaml | 214 +++++++++++++++++
lib/lvm/attributes/2.03.22(2)/pvs.yaml    | 121 ++++++++++
lib/lvm/attributes/2.03.22(2)/pvsseg.yaml |  16 ++
lib/lvm/attributes/2.03.22(2)/vgs.yaml    | 144 +++++++++++
5 files changed, 879 insertions(+)
Description
Describe what this change achieves
Issues Resolved
List any existing issues this PR resolves
Check List

[ ] A summary of changes made is included in the CHANGELOG under ## Unreleased
[ ] New functionality includes testing.
[ ] New functionality has been documented in the README if applicable.

Thanks @Stromweld!
Could you please create also a release tag for this change?


Information loss with current variable name binding model (JSON -> Json)

Environment

Elixir & Erlang/OTP versions (elixir --version): Erlang/OTP 26, Elixir 1.16.2
Operating system: Windows 10
How have you started Livebook (mix phx.server, livebook CLI, Docker, etc): mix phx.server
Livebook version (use git rev-parse HEAD if running with mix): cb11b26cdc0ed06ea9b62f07bc8ba661c22ae30c
Browsers that reproduce this bug (the more the merrier): All

Current behavior
Some background: I wanted to write an all-Erlang livebook, to check this project out, and to experiment with live documentation for a project of mine.
That project is a JSON parser, and so I used the variable name "JSON" for a binary with data that any reader could quickly edit.
However, I ran into an issue where the "JSON" term would disappear after one cell. I figured this had to do with the variable name normalization between Elixir and Erlang, and I've now checked the code to confirm those suspicions.
First: A simple test case.
<!-- livebook:{"default_language":"erlang"} -->

# Untitled notebook

## Section

```erlang
JSON = "[1,2,3]".
```

```erlang
JSON.
```

I hoped this would be an easy fix, but I took a look at the code, and it seems like variable names are always remembered in the Elixir form even if you only have Erlang blocks in a document.
Of course, when you convert "JSON" to "json", you have no idea what the capitalization is supposed to be when you turn it back. "JSON" or "Json"? In this case, Livebook chooses "Json".

So it's not an easy fix, it's a bit of a head scratcher and to me, being new to your codebase, this is out of my league.
I would like to hear your thoughts on the matter.

Thank you for the report. Maybe we will need to keep a mapping in the evaluator to know how to handle those. I also can't think of alternatives. :(

Good catch. There is more to it, the current conversion maps JsON and JsOn to the same Elixir name, so if both names were to be defined it can actually break the semantics.
I think we really need an unambiguous mapping. My vote is to convert JSON to j_s_o_n, this is not pretty, but only matters if the user writes both Erlang and Elixir. Besides, one may argue the variable should be Json anyway :) @josevalim wdyt?

I think we don’t need to worry about multiple Elixir vars converting to the same Erlang one, that’s fine. Just change your Elixir var name. But Erlang vars should go back and forth without issues.

Just change your Elixir var name.

Ideally we should not have conflicts in the conversion, I think that's confusing.
My point is that with an unambiguous mapping we achieve both and it seems like the simples approach.
There are a couple more cases, because technically Erlang env vars can also have underscores. But I think the following would be unambiguous:

Toggle the first char case
_x <-> X

And this results in:
Erlang <-> Elixir

# Usual
Json <-> json
JSON <-> j_s_o_n
JsOn <-> js_on
JsON <-> js_o_n

# Mostly irrelevant edge cases
J_s_o_n <-> jSON
Js__on <-> js_On
Js__o_n <-> js_ON
JsO_N <-> js_oN
Js_on <-> jsOn

regardless of what I said, that’s by far the simplest option, so I agree. :)


[BUG]: Cannot chat with Gemini API key.

How are you running AnythingLLM?
AnythingLLM desktop app
What happened?

When using the API key from Gemini and adding that to the Workspace LLM Provider, I get this error - [GoogleGenerativeAI Error]: Error fetching from https://generativelanguage.googleapis.com/v1beta/models/gemini-1.5-pro-latest:streamGenerateContent?alt=sse: Cannot convert argument to a ByteString because the character at index 486 has a value of 8211 which is greater than 255.
Are there known steps to reproduce?
Add Gemini API key in Workspace LLM Provider and chat with it.

Does this occur on a workspace with no documents embedded in it?

Happens either way.
On Tue, 18 Jun, 2024, 2:26 am Timothy Carambat, @.***>
wrote:

Does this occur on a workspace with no documents embedded in it?
—
Reply to this email directly, view it on GitHub
https://github.com/Mintplex-Labs/anything-llm/issues/1689#issuecomment-2174409176,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AUHZN55IGI6XFNNCNBAHSXTZH5EQVAVCNFSM6AAAAABJLLEGOWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUGQYDSMJXGY
.
You are receiving this because you authored the thread.Message ID:
@.***>

I am unable to reproduce this with our key(s). You do have access to 1.5 Pro, correct? We have some contacts who exclusively use Gemini so if this was a pervasive bug i'd be getting emails from all of them. 🤔


on_key actually is in the base class

The README says: Event handlers in Textual are defined by convention, not by inheritance (so you won't find an on_key method in the base class)..
However, App.on_key actually is there.

Clarified a little:

Event handlers in Textual are defined by convention, not by inheritance (there's no base class with all the handlers defined).


Chinese translation

It's totally my bad, but can you update it to include the spelling change I made in https://github.com/TTWNO/gitea/commit/d7ed9b08cb963151294a16beb16def0648bc42dd
Thanks!


Did you consider using XSLT for transforming XML?

What is your use case? We didn´t think about that.

Not 100% related, but we might want to make the file extensions for the XML FileProcessor configurable, to also allow covering .xsl files or other XML files.


Frontend Transformer optimisation

Note: To manage the complexity of what became quite a complex operation, I'm separating the simple steps of PR #234 into a separate PR.
This PR improves the way we deal with comments and multi-line pragmas in the frontend sanitization steps. Following the previous example, we now also do comment inlining with a one-pass transformer and make all the respective transformers use inplace=True.
The PR also includes a small fix to the previously introduced utility transformers, where we forgot to strip None and empty tuples from the resulting IR. I also needed to adjust the IR graph test - not quite sure why, but it seems safe to me.

Confirmed clean with ec-physics regression.


Merging the PRs

The mantis PRs should be merged in this order after testing:

[x] Registration #102
[ ] Stabilization #108
[ ] Segmentation #106
[ ] Merging datasets #107
[ ] Illumination correction and denoising #109

The pytorch implementation of denoising models: https://github.com/dl4mia/02_regression/blob/main/02_Noise2Void/n2v_solution.ipynb


fix: Reset target position on destroy

Closes #56

:tada: This PR is included in version 2.7.3 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Amazing!Thanks for your generous help.;)

@GoldenSupremeSaltedFish - Pull request can be closed without merged, since origin branch will be deleted.


runtime: ThreadSanitizer failed to allocate / CHECK failed

What version of Go are you using (go version)?

$ go version
go version go1.14 linux/amd64

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/nfs/users/nfs_s/sb10/.cache/go-build"
GOENV="/nfs/users/nfs_s/sb10/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/nfs/users/nfs_s/sb10/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/software/vertres/installs/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/software/vertres/installs/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="0"
GOMOD="/nfs/users/nfs_s/sb10/src/go/github.com/VertebrateResequencing/wr/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build484982129=/tmp/go-build -gno-record-gcc-switches"
$ free -m
total        used        free      shared  buff/cache   available
Mem:         135359       19962       78221          28       37175      114236
Swap:        223231          38      223193

What did you do?

git clone https://github.com/sb10/wr.git
cd wr
git checkout ThreadSanitizer
CGO_ENABLED=1 go test -p 1 -tags netgo -race --count 1 -gcflags=all=-d=checkptr=0 ./jobqueue -run TestJobqueueRunners -v

What did you expect to see?
Tests should pass cleanly the same way they do without race (go test -p 1 -tags netgo --count 1 ./jobqueue -run TestJobqueueRunners -v).
What did you see instead?
Variations on:

ERROR: ThreadSanitizer failed to allocate 0x28000 (163840) bytes of sync allocator (error code: 12)
FATAL: ThreadSanitizer CHECK failed: ./gotsan.cpp:7064 "((0 && "unable to mmap")) != (0)" (0x0, 0x0)

Which exits the test. It happens during a seemingly random test each attempt.
Additional info:

As mentioned, no problems with race detection disabled.
Problem also happens with go1.13.8, didn't check other versions.
Problem goes away if I revert usage of github.com/sasha-s/go-deadlock back to sync, but I want to run go-deadlock in production to catch deadlock bugs that my tests aren't finding.

As a bad interaction between go-deadlock and the go race detector, I have no idea how to debug this.

/cc @aclements @rsc @randall77 @dvyukov

It seems that you run out of memory on the machine. Errno 12 is ENOMEM. Maybe you disable overcommit/swap/set ulimit -v/use memcg.

It turns out I only have this problem on a machine where processes have a 5GB per process limit enforced.
Though LSF reports that peak memory when using race is less than 2GB, average 980MB. Peak memory without race is reported as 800MB, average 300MB.
Is this difference in memory usage expected? Could there be a very brief >5GB heap allocation with race that LSF doesn't detect in its peak memory usage report?

What exactly is that -m? Are you sure you restrict and measure the same memory? RSS? Virtual? Allocated? Locked? Accounted? There are lots of them :)

$ ulimit -a
core file size          (blocks, -c) 0
data seg size           (kbytes, -d) unlimited
scheduling priority             (-e) 0
file size               (blocks, -f) unlimited
pending signals                 (-i) 541143
max locked memory       (kbytes, -l) 16384
max memory size         (kbytes, -m) 5000000
open files                      (-n) 131072
pipe size            (512 bytes, -p) 8
POSIX message queues     (bytes, -q) 819200
real-time priority              (-r) 0
stack size              (kbytes, -s) 8192
cpu time               (seconds, -t) unlimited
max user processes              (-u) 541143
virtual memory          (kbytes, -v) 5000000
file locks                      (-x) unlimited

So -m is "max memory size". I don't know how LSF measures memory usage. But in any case, it seems that a lot more memory is being used than normal, that it hits this limit.

Memory use increase under race detector is very much expected, see:
https://golang.org/doc/articles/race_detector.html#Runtime_Overheads
So I would say increase/don't set the limits. If you set limits, at some point normal program will crash as well. It's not possible to achieve that any program works with any limits.

Sure, I expect some memory usage increase, the question is, is this much of an increase a possible bug? Is there a bad interaction between go-deadlock and the go race detector that uncovers some unexpected run-away memory usage? Or is the memory usage legitimate?
If there's no easy way to answer this question, I guess this issue can be closed.

Sure, I expect some memory usage increase, the question is, is this much of an increase a possible bug?

This has some reference numbers:
https://golang.org/doc/articles/race_detector.html#Runtime_Overheads
Is memory consumption increase way above these numbers?

Is there a bad interaction between go-deadlock and the go race detector that uncovers some unexpected run-away memory usage?

I don't know. You are filing the bug, so I assume you have answers :)
Does memory usage grow infinitely under race detector whereas it does not grow in normal build?

hello, I'm seeing this issue too on the github actions runner: https://github.com/benitogf/level/runs/2772001793?check_suite_focus=true only on windows though


nixos/frp: init frp module with a test

Description of changes

Supersedes #235419.
Adding a frp module.
The original author doesn't seem to be responding to the reviewer's comments, so I'll take over updating that PR.
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[x] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

dependencies on the network(-online).target

The original author marked this issue as solved, so I missed this comment. I'll correct it later.

redundant hardening options implied by DynamicUser (On, why do you remove DynamicUser?  Please add it back.  It should be used if possible.)

Oh, I misunderstood what you meant in the original PR, and I will modify the hardening options later.

services.frp-client and services.frp-server are almost the same.  It would be great to merge them into one module.

Good idea, but if I refactor the frp module, do I need to create a new PR or update it to this PR?

if I refactor the frp module, do I need to create a new PR or update it to this PR

I do not see the need for a new PR.

The original author doesn't seem to be responding to the reviewer's comments, so I'll take over updating that PR.

Thank you for doing this, to be honest I kinda forgot about it :see_no_evil:

link the test to the package https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#linking-nixos-module-tests-to-a-package

rebase your commits into one or two: one for adding the module and another for adding the test

Both are done. Please check it again.


"The SDK 'Godot.NET.Sdk/4.1.0' specified could not be found."

Godot version
4.1.0
System information
Windows 11
Issue description
I cannot build C# project and I am recieving these two errors
D:\Dev\FPS\FPS.csproj(0,0): Could not resolve SDK "Godot.NET.Sdk". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.
D:\Dev\FPS\FPS.csproj(0,0): The SDK 'Godot.NET.Sdk/4.1.0' specified could not be found.
Yes, I have seen other github issues like this one, I have tried to create a nuget.config file in my godot project folder, did not solve the issue.
Steps to reproduce
This is a semi-fresh install of godot 4.1.0
Minimal reproduction project
N/A

I had a similar error when building the Godot Engine from source:
HelloWorld.csproj(0,0): Could not resolve SDK "Godot.NET.Sdk". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.

I opened the *.csproj file and at the top there's a line that looked like:
<Project Sdk="Godot.NET.Sdk/4.2.0-dev">

On the nuget page, we see: https://www.nuget.org/packages/Godot.NET.Sdk/
I noticed that there is no such package as 4.2.0-dev, so I changed my csproj file to use 4.2.0.-dev.5 instead:
<Project Sdk="Godot.NET.Sdk/4.2.0-dev.5">

Now the build works!
In your case, it's kind of weird because 4.1.0 is actually available on nuget. Maybe try changing it to one of the other versions to see if it helps?
I think the Godot C# documentation needs to highlight this roadblock. I imagine it happens once in a while, and it really gives a poor impression to the C# developer who is new to Godot (I imagine there are many of those in recent days).

I discovered a bug in that when I launch Godot Engine (built from today's head revision), I recreates the *.csproj file and overwrites the one that I hand edited.
So even if I changed it to <Project Sdk="Godot.NET.Sdk/4.2.0-dev.5"> to make it build correctly, Godot will overwrite it with <Project Sdk="Godot.NET.Sdk/4.2.0-dev"> and my .NET build fails again.
For now, I'll try to keep Godot editor open, but it's annoying that it blows away my csproj file when I launch it.

@akien-mga I followed those directions and ran the ./modules/mono/build_scripts/build_assemblies.py with the --push-nupkgs-local flag for a local nuget directory. I'm still getting the same error after relaunching Godot.
TestProj.csproj(0,0): Could not resolve SDK "Godot.NET.Sdk". Exactly one of the probing messages below indicates why we could not resolve the SDK. Investigate and resolve that message to correctly specify the SDK.

I won't file a separate bug since I'm sure it's just a "user error" on my part. I just wish this process were more fool proof. I'm so close.... I'm sure I'll figure it out at some point. :-) I feel like other C# devs will run into this issue at some point too.

I think this is an error not so related to godot itself. I tried running godot as an administrator and it was fine (although previously it wasn't working when my normal account was an administrator)
It might just be my computer being a bit pricky because I get a simular error when I try to create a visual studio solution (as a non-administrator) and when I try to install the Godot.NET.Sdk/4.1.0 manually (as a non-adminstrator)
I will post a full solution to this issue when I get it fully figured out and I will close the issue after that.

When I was attempting to install the Godot.NET.Sdk/4.1.0 package mannualy using Visual Studio, I was getting an error along the lines of "Access to path C:\Users\georg.nuget\packages[something else]"
Turns out there wasn't even a .nuget folder because nuget wasn't allowed to touch it or do anything with it.
In my case, I went to C:\Users\ and right clicked properties>security and then ticked the "Full control" option for "Authenticated users".
sorry if my instructions were a bit unaccurate, I am too lazy to reproduce the issue to tell persisely what errors I was getting.

Any resolution to this?  I'm getting the exact same error... very frustrating.


Zero secure memory on allocation

This destroys the free list pointers that would otherwise be present in the returned memory block. This in turn helps prevent information leakage from the secure memory area.
Manual port of #7011

[x] tests are added or updated

Merged, thanks.


WSL Kernel FIPS mode

Is your feature request related to a problem? Please describe.
The WSL kernel appears to be designed to prevent FIPS 140-2 enforcement.
Describe the solution you'd like
The ability to turn on FIPS mode in the kernel using "fips=1" as with a standard Linux kernel.
Describe alternatives you've considered
Merely including openssl-fips or other packages isn't enough to satisfy testing protocols. We work in software development for government systems and the ability to test our code on systems that will be like those we deploy on is a must. Without fips mode enabled on the kernel, WSL distros are unable to be setup like a deployment STIG'd environment for testing.
Additional context
Federal Information Processing Standard (FIPS) 140-2 requires the use of certain validated algorithms for encryption and hashing. The standard Linux kernel enables enforcement of these algorithms through the "fips" kernel directive as long as CONFIG_CRYPTO_FIPS has been set to "y" during compilation. The WSL kernel does not include the fips directive and does not allow for CONFIG_CRYPTO_FIPS to be enabled during kernel compilation. We recently discovered a situation where our code ran fine on WSL, but was failing on a STIG'd Linux machine that we traced to FIPS enforcement.

Some info here...
The kernel builds just fine after changing some of the configs.
CRYPTO_MANAGER_DISABLE_TESTS=n (so enable the testing)
CRYPTO_ANSI_CPRNG=y
MODULE_SIG=y (even though there isn't really any modules for the kernel)
CONFIG_CRYPTO_DRBG_MENU=y
CONFIG_CRYPTO_DRBG_HMAC=y
Then FIPS shows up in the menuconfig for selection and you can hit
CONFIG_FIPS=y
The build works fine, but I'm still working through debugging why it's not booting...

Almost there...
[root@DAD101 ~]# uname -r
<IP_ADDRESS>-microsoft-standard-WSL2+
[root@DAD101 ~]# zgrep FIPS /proc/config.gz
CONFIG_CRYPTO_FIPS=y
[root@DAD101 ~]# fips-mode-setup --check
FIPS mode is enabled.
Initramfs fips module is disabled.
The current crypto policy (FIPS) is based on the FIPS policy.
Inconsistent state detected.
[root@DAD101 ~]#

Forgot this check...
[root@DAD101 ~]# cat /proc/cmdline
initrd=\initrd.img WSL_ROOT_INIT=1 panic=-1 nr_cpus=24 bonding.max_bonds=0 dummy.numdummies=0 fb_tunnels=none swiotlb=force earlycon=uart8250,io,0x3f8,115200 console=hvc0 debug pty.legacy_count=0 loop.max_part=8 fips=1
[root@DAD101 ~]#

Running into this as well where a pyspark application works fine in WSL but fails on a FIPS compliant deployment environment.  Is FIPS compliant WSL available?


Doc: Install pcan drivers linux

Sunlink Pull Request Description

Added section in README.md to explain how to install PCAN Linux Drivers.
Monday Link

Effected Components

[ ] Link Telemetry
[ ] Parser
[ ] Influx
[ ] Grafana
[ ] DBC
[ ] Sunlink environment
[ ] Tools
[ ] Tests
[ ] Docs

Testing

[ ] Vehicle testing
[ ] Randomizer testing
[ ] Other
[ ] N/A

Started with working copy of drivers.

Fully uninstalled them:

Followed README.md I made word for word and installed them (evidenced by no Cannot find device "cano0" error

Fully confirmed successful installation by running candump on fake messages coming from MCB

Sanity check

CAN ID table / DBC updated
gitignore updated and commited
[ ] Steps confirmed

Sources

All good just a little typo here Followed README.md I made word for word and installed them (evidenced by no Cannot find device "cano0" error  I believe it should be can0


Set the _tenantid

[Would love to see an example of how the _tenantid is set]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: b7c9bd3e-4b99-9acf-48d8-e47bc53eb54e
Version Independent ID: 220e0a6c-d227-956a-d27a-7c88804f770c
Content: Global Query Filters - EF Core
Content Source: entity-framework/core/querying/filters.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @maumar
Microsoft Alias: avickers

Duplicate of #1361 and #96


Make feather stores read incrementally

This changes feather stores not to use the official Apache Feather reader anymore, but rather use its lower-level building blocks to do reads incrementally. This means that loading a feather store should not take any time anymore; the actual reading only happens on demand as batches are accessed. This is implemented in a way that the store caches already read batches so they're not read again for concurrent queries.
NB: This technically drops support for reading Apache Feather V1 files, but VAST never wrote them to begin with and we never officially said we support that.

I was left wondering why this "issue" only concern Feather. Can you add a sentence about the relationship to Parquet? Most readers will be more familiar with this format.

I added a note at the bottom that we plan to make the same improvement for our Parquet stores.


Live Chart is not rendering on Azure.

Hi,
I have followed the below mentioned link to generate an image of live graph in my application and it is working fine on my local machine but when I deploy it on azure it is not doing anything. I am getting an empty image that does not contains graph in it further I have checked in logs no error or exception is being thrown. It seems that it is not working on Azure.
https://github.com/beto-rodriguez/Live-Charts/blob/develop/Examples/Wpf/CartesianChart/Chart to Image/ChartToImageSample.xaml.cs
Can anybody help me please?

I can reproduce the issue on my local environment now by just commenting the following line of code:
myChart.Update(true, true); //force chart redraw
viewbox.UpdateLayout();
It seems that control cannot be updated on Azure. I have also tried to update the controls through "Dispatcher" but still getting the same issue on Azure.
Please help me to resolve this issue.


Default sort to desc, not asc

Noticed this today after adding a new company and they're not on the homepage

Thanks @yordis 🎉

Not having the best luck with the merge queue functionality but going to give it another shot with this one


支持 pinia 自动导入支持类型推导

Clear and concise description of the problem
我开启了 pinia 的自动导入

但是会出现以下类型错误提示

直接导入后消失

Suggested solution
我并不懂这中间发生了什么，导致无法正确的推导类型。
Alternative
No response
Additional context
No response
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guide.
[X] Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

defineStore auto-import works for me with this plugin.
Are you sure that you are importing the generated .d.ts file correctly in your tsconfig?

defineStore auto-import works for me with this plugin. defineStore 自动导入对我来说适用于这个插件。

您好！我是这样配置的，应该没有什么问题。

We temporarily closed this due to the lack of enough information. We could not identify whether it was a bug or a userland misconfiguration with the given info.
Please provide a minimal reproduction to reopen the issue.
Thanks.

Why reproduction is required


Improve routing - routes order

If routes /foo/bar and /foo/{var} are defined then route /foo/bar should always match for /foo/bar url, no matter in which order are controllers registered. We should also check for collisions.
See also swagger docs

Also /foo and /foo/{bar}/baz should work.
Order should be corrected during Schema building, solving that in SimpleRouter would cause performance decrease.
It would be also nice to replace this with endpoints grouping to reduce schema lookups


Cannot build gradle classpath

Using neovim version NVIM v0.1.3-244-g3e0fab6, Arch Linux, gnome-terminal, I am getting the following errors when opening this Java project: https://github.com/TestFX/TestFX.
Messages maintainer: Bram Moolenaar<EMAIL_ADDRESS>"~/dev/testfx/subprojects/testfx-core/src/main/java/org/testfx/matcher/control/TableViewMatchers.java" 97L, 3920C
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
FAILURE: Build failed with an exception.
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
* What went wrong:
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
Failed to notify build listener.
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
> java.lang.NullPointerException (no error message)
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
> java.lang.NullPointerException (no error message)
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
> java.lang.NullPointerException (no error message)
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
* Try:
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
Failed to build gradle classpath

Can confirm in my case as well (Neovim 0.1.2, OS X 10.11), with the following messages:
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
FAILURE: Build failed with an exception.
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
* Where:
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
Script '/Users/vvlasov/.vim/bundle/vim-javacomplete2/classpath.gradle' line: 24
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
* What went wrong:
Error detected while processing function javacomplete#classpath#gradle#BuildClasspathHandler:
line   33:
Execution failed for task ':classpath'.

Plugin works perfectly for Vim (7.4.1525).

Hm, cannot reproduce with 0.1.3-340. Can you get what exactly happened with gradle execution?

Sure, how does one do that?

I can not reprodue this issue.
echo g:JavaComplete_Libpath
show me
./home/wsdjeg/.gradle/caches/modules-2/files-2.1/com.google.guava/guava/18.0/cce0823396aa693798f8882e64213b1772032b09/guava-18.0.jar:/home/wsdjeg/.grad
le/caches/modules-2/files-2.1/org.controlsfx/openjfx-dialogs/1.0.2/c53eb044b9cc2a22365da7272ec8f32960b1b6df/openjfx-dialogs-1.0.2.jar:/home/wsdjeg/fork
s/TestFX/subprojects/testfx-junit/src/main/java:/home/wsdjeg/forks/TestFX/subprojects/testfx-core/src/main/java:/home/wsdjeg/forks/TestFX/subprojects/t
estfx-legacy/src/main/java:/home/wsdjeg/.gradle/caches/modules-2/files-2.1/org.controlsfx/controlsfx/8.20.8/62647327dc0c0853596738caea794f132912f747/co
ntrolsfx-8.20.8.jar:/home/wsdjeg/forks/TestFX/subprojects/testfx-legacy/src/test/java:/home/wsdjeg/.gradle/caches/modules-2/files-2.1/junit/junit/4.12/
2973d150c0dc1fefe998f834810d68f278ea58ec/junit-4.12.jar:/home/wsdjeg/forks/TestFX/subprojects/testfx-core/build/libs/testfx-core-4.0.2-alpha.jar:/home/
wsdjeg/.gradle/caches/modules-2/files-2.1/org.hamcrest/hamcrest-all/1.3/63a21ebc981131004ad02e0434e799fd7f3a8d5a/hamcrest-all-1.3.jar:/home/wsdjeg/fork
s/TestFX/subprojects/testfx-core/src/test/java:/home/wsdjeg/forks/TestFX/subprojects/testfx-junit/src/test/java:/home/wsdjeg/.gradle/caches/modules-2/f
iles-2.1/org.mockito/mockito-all/1.9.5/79a8984096fc6591c1e3690e07d41be506356fa5/mockito-all-1.9.5.jar:/home/wsdjeg/.gradle/caches/modules-2/files-2.1/o
rg.testfx/openjfx-monocle/1.8.0_20/9859038affe2fd08c40c43ca19790687a5d56107/openjfx-monocle-1.8.0_20.jar
Press ENTER or type command to continue

@brcolow you can try enable g:JavaComplete_ShowExternalCommandsOutput to see output.

It seems that this is not an issue with Javacomplete2 itself, but with gradle. Because, if I run:
gradle classpath build process --debug --stacktrace in root project directory of TestFX project, I get an error. So, it is not Javacomplete2's problem I think. For reference here is the (very long) stack trace.

sorry.as Shougo says.most people use gradle as default.so we change to gradle

If a gradle wrapper has been included in a project, the expectation is that the wrapper will be used instead of the system binary.

so you means ./gradlew should be default if it is exist?
from my phone
-------- 原始邮件 --------
主题：Re: [vim-javacomplete2] Cannot build gradle classpath (#219)
发件人：Donnie West
收件人：artur-shaik/vim-javacomplete2
抄送：Wang Shidong
If a gradle wrapper has been included in a project, the expectation is that the wrapper will be used instead of the system binary.

Reply to this email directly or view it on GitHub:
https://github.com/artur-shaik/vim-javacomplete2/issues/219#issuecomment-196113242

Correct, if a user has a ./gradlew in their project then that is intentional. It's done that way so that the same version of Gradle can be used regardless of what is installed on a machine (For CI or keep your software team on the same version of Gradle)

So, should we give priority to local executable ./gradlew?

we make the change because @Shougo ask me this question in gitter.im,so if we change the default value,I think maybe he should know about it.

If this change works in Android project properly, :+1:

thanks for reply,I will try to add this feature after #222 be merged.

@artur-shaik I need to use the absolute path of ./gradlew because maybe some people do not use vim-rooter. I think maybe that is why @Shougo get freeze when open an java file.

May be in this case you can use g:JavaComplete_GradlePath?
On 03-14 (06:38), Wang Shidong wrote:

[1]@artur-shaik I need to use the absolute path of ./gradlew because maybe
some people do not use vim-rooter. I think maybe that is why [2]@Shougo
get freeze when open an java file.
—
Reply to this email directly or [3]view it on GitHub.
Reverse link: [4]unknown
References
Visible links

https://github.com/artur-shaik
https://github.com/Shougo
https://github.com/artur-shaik/vim-javacomplete2/issues/219#issuecomment-196313731
https://github.com/artur-shaik/vim-javacomplete2/issues/219#issuecomment-196313731

--
Best regards,
Artur Shaikhullin

Done

@brcolow in gitter.im,you want me testting https://github.com/elastic/elasticsearch.git , but it is too lager to clone.after read the PRs, I found a GOOD reason for do not use gradle wapper.https://github.com/elastic/elasticsearch/pull/13744.
and I do not know whether javacomplete2 works well with maven submodule project or gradle submodule project.if JC2 only put all submodule project's classpath together,it will be very slow.


CMS doesn't work with Rails 3.1 asset pipeline

When running in production, even after a rake assets:precompile, when layouts/cms_admin/_head.html.erb is rendered, the app blows up with an AssetNotPrecompiled error.
The only solution I’ve found so far is to enable fall-back to the asset pipeline in the production environment so CMS works, which sucks as it defeats the whole purpose.

Here is the specific error:
Showing /home/zenith/ruby/ruby-1.9.2-p290/gems/gems/comfortable_mexican_sofa-1.5.8/app/views/layouts/cms_admin/_head.html.erb where line #14 raised:
comfortable_mexican_sofa/wymeditor/jquery.wymeditor.pack.js isn't precompiled

Extracted source (around line #14):
11:
12:     <%= stylesheet_link_tag 'comfortable_mexican_sofa/application' %>
13:     <%= javascript_include_tag 'comfortable_mexican_sofa/application' %>
14:     <%= javascript_include_tag 'comfortable_mexican_sofa/wymeditor/jquery.wymeditor.pack.js' %>
15:     <%= javascript_include_tag 'comfortable_mexican_sofa/wymeditor/jquery.wymeditor.cms.js' %>
16:
17:   <% else %>

Rails 3.1.1, comfortable_mexican_sofa 1.5.8

I am being told that adding something like this in your application.rb should do it:
config.assets.precompile += [
  'comfortable_mexican_sofa/wymeditor/jquery.wymeditor.pack.js',
  'comfortable_mexican_sofa/wymeditor/jquery.wymeditor.cms.js',
]

Not exactly sure what that does.
I'm killing off wymeditor with next release so perhaps it won't be an issue in the future.

Glad to hear it the news about wymeditor!
However, the code above is not a solution according to this: http://guides.rubyonrails.org/asset_pipeline.html#adding-assets-to-your-gems
The other assets from comfortable_mexican_sofa get picked up correctly, for what it's worth, but running rake assets:precompile only creates the wymeditor directory and the iframe directory in it, but does not put any of the files in.

It seems about right though. It seems that it automatically compiles application.js but whatever else you might have (like jquery.wymeditor.pack.js) will get ignored. So that config.assets.precompile should do the trick.
Unfortunately wymeditor requires its js to be separate from application.js so that's why it's like that. One of the reasons why it's getting replaced.

 When using Rails 3.1, the application manifest should include the files that are a part of the asset bundle. Since https://github.com/twg/comfortable-mexican-sofa/blob/master/app/views/layouts/cms_admin/_head.html.erb#L13-15 are three separate javascript_include_tags, it doesn't know that the wymeditor files are a part of the bundle so they don't get compiled.
If it's getting removed it may be a moot point, but the way to extract the code from https://github.com/twg/comfortable-mexican-sofa/blob/master/app/assets/javascripts/comfortable_mexican_sofa/application.js into a separate file, and use application.js as a manifest only (then it can load the code that's currently in application.js, and wymeditor and it should work).
Thanks for looking into this and for CMS!

Wymeditor requires for

why is this closed? CMS is broken for me in production as a result of this bug, and whatever editor you switch to, we need to include some javascript in a way that works...
are you just planning to add those files to comofortable_mexican_sofa/application.js?
btw, I'm looking at the elrte (do you pronounce that like "alert"?) editor, it looks fairly nice, but i'm afraid to give my users access to font sizes, colors, faces, padding, etc...
I sort of liked that wym gave you more semantic markup out.

by the way, that precompile line works for me. does it make sense to add that to the gem somehow?

As I explained I can't put those files into application.js because wymeditor won't function. Right now you gotta go with precompile thing. Don't think I can do anything from CMS end to enable it by default.
In any case I'll have some time next week to finish editor replacement. That will clear up this issue.
I won't enable all buttons under the sun for elrte, don't worry. Just the basic alignment, formatting and image insertion (big thing for the next version). I'd also be scared to give users ability to create Geocities webpages.

I'll close this issue with next version release.

1.6 is out. Wymeditor is gone. All js/css is declared in the application file so there should be no issues with asset pipeline anymore.


New comment by joe

Dear human,
Here's a new entry for your approval. :tada:
Merge the pull request to accept it, or close it to send it away.
:heart: Your friend Staticman :muscle:

Field
Content

message
how do you like me now?

name
joe

email
914f9285d372d2ce0c41670026518051

url

hidden

date
2019-07-08T15:24:53.896Z

this was only a test


file: add option to skip reading magic bytes

This PR adds an option to skip reading magic bytes at the beginning of parquet files. The PAR1 prefix is a useful indicator that the application is working with parquet files, but it is often unnecessary to read when we can trust the underlying data.
In scenarios like #188, this also likely removes one round trip to the storage layer, since we only need to read the footer to decode a parquet file schema and metadata.

Thanks for the review!

Love this change. We do this already with a wrapper around the io.ReaderAt that detects the magic bytes read and returns them but this is much nicer.

We do the same :)
https://github.com/grafana/tempo/blob/60780f7ff878d86e0e23179fc65f2c3ed9832e9d/tempodb/encoding/vparquet4/readers.go#L98-L108


Avoid having an explicit node typings requirement

We also don't need the minimist @typings in dependencies, because it isn't in the compiled .d.ts file.
cc @jasongrout

Superseded by #249


Datastore emulator fails to start without project id property

Environment details

GCloud datastore emulator 2.1.0
Google Cloud SDK 327.0.0
OS type and version: NAME="Ubuntu" VERSION="18.04.4 LTS (Bionic Beaver)"  / MacOS Catalina 10.15.7 (19H15)
Java version: OpenJDK Runtime Environment AdoptOpenJDK (build 11.0.8+10) / OpenJDK Runtime Environment (build 11.0.7+10)
Libs:

https://github.com/GoogleCloudPlatform/spring-cloud-gcp: org.springframework.cloud:spring-cloud-gcp-starter-data-datastore:1.2.5.RELEASE, I checked - same with the latest
google-cloud-datastore:1.104.0
google-cloud-core:1.93.7

Steps to reproduce
This version emulator fails to start without --project property

gcloud beta emulators datastore start

ERROR: (gcloud.beta.emulators.datastore.start) The required property [project] is not currently set.
You may set it for your current workspace by running:

  $ gcloud config set project VALUE

or it can be set temporarily by the environment variable [CLOUDSDK_CORE_PROJECT]

Starting emulator with Java code like this:
LocalDatastoreHelper.create(settings.getConsistency(), settings.getPort());

Causes: no messages in logs, the application failed to call the Datastore then with I/O exceptions, i.e. curl doesn't work.
Workaround
Set env variable: CLOUDSDK_CORE_PROJECT with the projectId value
Questions

Why LocalDatastoreHelper doesn't pass --project on startup and doesn't expect this from the builder?
Shouldn't LocalDatastoreHelper #start fail to start on this kind of errors?

Besides the outcomes of these questions, I would expect this class to fail to start or log something.

I wonder if this is an issue with out-dated documentation — https://cloud.google.com/sdk/gcloud/reference/beta/emulators/datastore/start also declares that the--project flag isn't required, but maybe it is now. Are you setting the variables re: the env-init command? It seems like it's expecting a variable like this: DATASTORE_PROJECT_ID=my-project-id (as per this page: https://cloud.google.com/datastore/docs/tools/datastore-emulator#automatically_setting_the_variables).

@meredithslota I question here particularly LocalDatastoreHelper class and troubleshooting on its start-up issues.
Consider it starts in an isolated environment without any env variable predefined, then LocalDatastoreHelper starts finishes but the method caller never knows that it failed to start due to missing an env variable, there is no log message.
As well there is no method in builder to pass the project id explicitly

I propose:

add a method to the builder to pass the project id (if project id is optional it's still good to let you class consumers to pass its value)
log when it fails to start due to missing env variable with a reasoning message

It will make it clear as right now there is no clue to know why it failed to start when no env variable has been provided.

There's a similar issue with the LocalDatastoreHelper #302 — @prash-mi can you include this with your investigation of the other issue?

@artemptushkin , Thanks for reporting this.
We have fixed this issue in this PR and is up for review. You can find the explanation and fix in the PR itself.


Extend XTKS hours to 15:30

Workflow to modify an existing Exchange Calendar

[x] Modify calendar class as required.
[x] Modify the test resources file (e.g tests/resources/{Exchange MIC}.csv), either manually or by executing python etc/make_exchange_calendar_test_csv.py {Exchange MIC}.
[x] Check if any of the fixtures in tests/test_{Exchange MIC}_calendar.py need updating to reflect your changes.
[x] Add references to any new/modified holidays in exchange_calendars/exchange_calendar_{Exchange MIC}.py.

Closes #432

See:

https://www.jpx.co.jp/english/corporate/news/news-releases/1030/20230920-01.html
https://www.jpx.co.jp/english/corporate/news/news-releases/1030/uorii50000002f2a-att/pressrelease_extension_of_trading_hours_en.pdf

I see that there is already an open PR to resolve this, but the tests are failing and it hasn't been merged: https://github.com/gerrymanoim/exchange_calendars/pull/429 so I've created this new one that is ready to be merged.

Can I also request that if this is merged, that we release a new version of the package relatively soon after so that everybody has the updated hours for XTKS ASAP given that this change is already live.

Thanks - will cut a new release when this lands.


Extension host terminated

Need to investigate the cause of this issue and why it affects Live Share users

#2999