Husky pre-commit hooks 🐶

Description
Husky is a tool that has Git hooks which allows to automatically do stuff (ie: lint) before committing/pushing. This ensures a higher bar for code quality for anything that makes it to GitHub.
Acceptance Criteria
We should automatically be running the format:fix and lint:fix command for any files that are staged (ie: lint-staged) before committing.
Additional Context
We don't currently have a format/format:fix command in the codebase, so we'll need to add that first.

Will handle this on 4/4

No rush!


Policy adjustments

Well, nice pull request... I'll pull this branch, review changes and merge into developer.


Fix all_walking_costs_from by properly accounting for the distance be…

…tween sidewalk endpoints and building paths.
This fixes problem 1 from #669. That bug describes the problem better. I tested by clicking different starting buildings and checking the tooltip of others, carefully making sure that the cost increases as we get farther from the start.
@tnederlof

Very cool! Later this afternoon I will pull it down and check out the changes line by line, I feel like I will learn a lot.

@dabreegster I pulled this down and tested it on some maps and it LGTM, everything increases as I would expect.


Fix consumes test/plain

fixes acacode/swagger-typescript-api#312
The real changes are in

index.d.ts
src/schema-parser/schema-routes.js
templates/default/procedure-call.ejs
templates/modular/procedure-call.ejs
tests/schemas/v2.0/api-with-examples.yaml
templates/base/http-clients/axios-http-client.ejs
templates/base/http-clients/fetch-http-client.ejs

The other changed files are the newly generated snapshots

@JochenDiekenbrock thank you for your PR!


[QNEBE-384] Validate python source and main function arguments in application source

@animeshaltran I don't know for sure, but when app_config is a required (first) parameter for main (Bart should know how it is called by the sims), please also add a check for that.

Added the check for app_config. Bart confirmed that it is a required parameter and can be before/after/between the application inputs (order)


sign Git tags

Signed Git tags allow to verify that the source code was not tampered with. Currently only release binaries can be verified.

Implemented starting with v0.3.0


DDRIT: Razor Code Actions

Big Rock: https://github.com/dotnet/aspnetcore-tooling/issues/4499

Closing this to be tracked by https://github.com/dotnet/razor-tooling/issues/5681.


When a Python version isn't installed, nox fails (without going on to the next session)

I have a nox.py file for testing my project, and I want to specify all of the Python versions I support. That's easy enough, and works fine for CI. But when running nox on my local PC, I don't have all those Python versions installed. As a result, I get RuntimeError: Unable to locate Python interpreter "python3.5". when I run plain nox, and the run stops there.
Two things would be a huge improvement:

Respect the --stop-on-first-error setting, and by default skip sessions that can't be created because the Python interpreter isn't installed.
Avoid the ugly traceback, and simply print an error "Python interpreter XXX not installed - skipping".

Manually specifying just the environments I want to run isn't really practical (apart from anything else, the syntax for specifying a parametrised environment is much more verbose than tox's -e py36).

This is a great idea, and should be pretty easy to do. I'm cool with both 1 and 2.

Seems that making Nox imperative fixed this. :)
What it looks like now:

Let me know if there's more I can do here, @pfmoore!


Updated jackson bom dependency

Signed-off-by: Asif Sohail Mohammed<EMAIL_ADDRESS>Description

Updates all jackson dependencies to latest version 2.14.1
Doesn't fix any CVE's related to snakeyaml 1.30, 1.31 and 1.32 but updates it to 1.33 which still has CVE-2022-41854.

Issues Resolved
#2060
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.

[ ] New functionality has javadoc added

[ ] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Codecov Report

Merging #2068 (f654abf) into main (6ff24a4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main    #2068   +/-   ##
=========================================
  Coverage     94.05%   94.05%
- Complexity     1602     1603    +1
=========================================
  Files           200      200
  Lines          4662     4662
  Branches        355      355
=========================================
  Hits           4385     4385
  Misses          194      194
  Partials         83       83

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


[HELP] Converting Variant to Godot type.

I have the following code:
impl DrawCollisions {
    #[export]
    fn _draw(&self, owner: &Node) {
        for variant in owner.get_children().iter() {
            // Here
        }
    }
}

How can I convert variant from a Variant to a CollisionShape2D?

https://docs.rs/gdnative/0.9.3/gdnative/core_types/struct.Variant.html#method.try_to_object_with_error

We also have this covered in the User Guide.
If you feel that there are any other points missing from how to use this feature, please open an issue in User Guide Project so that we can help with any points that need additional clarification.


Add -c flag to wget to continue downloading

While setting up the cluster I had some download timeout or break in process and had to redownload all the files from storage.googleapis.com by hand.
This patch would save time and check if files have been downloaded completely.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@iMelnik - this looks sensible to me.  I won't be able to merge until you've signed the CLA.  Note that you may have done this already, but we modified the CLA to apply across all projectcalico/ repositories the other day which reset a number of CLAs.
Thanks!

Also, looks like there are some conflicts to sort out.

@iMelnik - Any chance of getting the conflicts on this PR sorted out?  I'd like to merge if possible :)

@caseydavenport sure :)


OpenCollective

Investigate and start the process, before the festival.
Understand

What problem are we trying to solve?
What other options do we have?
What's in it for us?
What are the downsides?
What will it look like?

Plan

What do we have to do to get this process started?
What is the time line?
How do we consult with the community?

Do it

Who's doing it?
Execute

Review

Report
Publicize

@bjoyce3 do you have some time to investigate this in the next few days?

@alex-r-bigelow set up a test collective. Thank you!
Do you mind inviting @bjoyce3 as well?

Re: What do we have to do to get this process started?

Decide whether we want to create one for Tucson or all Arizona (I lean just Tucson? Probably better to leave the nomenclature open for Tempe / Flagstaff to do their own thing)
Pick a collective name (Tucson Research Bazaar?)
Invite initial admins
Pick someone's bank account (or, better: pick and apply to a Fiscal Host)

Open Collective Foundation looks like the main one...

We're a good fit for their eligibility requirements as far as I can tell
Their application form is pretty simple

Time to hear back whether we're accepted may vary by host

Fill out the OC profile as best we can
Doesn't look required, but we should probably add a basic governance doc?

Re: What is the time line?
Before (?) the festival

Create a collective
Apply to Open Collective Foundation (?)

Once we're accepted

Link to our collective on our webpage
Donate the initial Beer Fund jar

If we're accepted before the festival starts

Document any festival expenditures
Can start asking Library, DSI, etc. to send funds or document expenses that way

If we aren't accepted to a Fiscal Host before the festival

Can still document expenditures, receipts, etc made on our behalf

After (?) the festival

Add / finish governance docs, elect real admins

@bjoyce3 just sent an invite to your @arizona.edu account... which I'm guessing is ancient. LMK if you have a better address to send to

More reading: https://docs.opencollective.foundation/faq/is-ocf-right-for-you

Progress: Spoke to Mike Strode from the Open Collective Foundation, but they indefinitely paused new project applications.
Still looking for alternatives.

https://www.oscollective.org/ for "Open Source Adjacent Communities" could be an option:

Open Source Adjacent Communities
We also consider applications from communities with a strong link to free and open source software. We use the following criteria:

[ ] Your project must be strongly affiliated with or related to open source, not proprietary technology or any other topics.

Meetups, conferences and other groups

[ ] should have at least 50 members,
[ ] should have organized at least 2 events previously,
[ ] should be able to show a history of activity by members.

As further evidence, you agree to send photo/video documentation of your first event after joining Open Source Collective.

https://blog.opencollective.com/open-collective-official-statement-ocf-dissolution/

Dear Open Collective Community,
It is with sad hearts that we have heard the news about Open Collective Foundation decision to dissolve, effective December 31. The full content of their announcement, which came as a surprise to us, can be found here, and they have also created an FAQ. We are still grappling with the realities of this decision, which has sent subsequent shock waves through the Open Collective ecosystem and community.

... read the rest at the link above.
I found out about it via an email from OSC.

Other options:

https://fiscalsponsordirectory.org/?page_id=1330
https://www.fiscalsponsors.org/member-directory

This looks interesting: https://hackclub.com/hcb/


Variables from_dttm and to_dttm are not compatible with timestamps from trino

Bug description
When i'm using
WHERE timestamp > '{{from_dttm}}' AND timestamp < '{{to_dttm}}'
with enabling ENABLE_TEMPLATE_PROCESSING on data from trino, i'm receiving:
Error: TrinoUserError(type=USER_ERROR, name=TYPE_MISMATCH, message="line 7:21: Cannot apply operator: timestamp(3) with time zone < varchar(19)", query_id=20240322_121113_00025_2wtqh)
I expect that  from_dttm and to_dttm variables should be in timestamp format, not in varchar.
It works well with all another datasources, only appears when trino datasource is using.
It can be fixed by:
WHERE timestamp > parse_datetime('{{from_dttm}}','YYYY-MM-dd''T''HH:mm:ss') AND timestamp < parse_datetime('{{to_dttm}}','YYYY-MM-dd''T''HH:mm:ss')
but it looks awkward and a little ugly.
Also the timestamp column is set to 'Is temporal' and 'Default datetime' in dataset
How to reproduce the bug

Setup a connection to a Trino instance
Setup a filter inside the virtual dataset using from_dttm and to_dttm variables
Visualize a table with a timestamp or date column
Try to apply a date or timestamp filter
See error

Screenshots/recordings

Superset version
3.1.1
Python version
3.10
Node version
16
Browser
Chrome
Additional context
A similar problem is described here https://github.com/apache/superset/issues/16223
Checklist

[x] I have searched Superset docs and Slack and didn't find a solution to my problem.
[ ] I have searched the GitHub issue tracker and didn't find a similar bug report.
[ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.

I don't think this is a bug IMHO, we can't know the target type of the column you might be using in your virtual dataset, the only thing we can to is better document what you should expect to come out of from_dttm and to_dttm (ISO) so that you can CAST it properly. Given jinja2 is a text templating framework, we have to output something as text here.

Closing this as probably-not-a-bug and stale even if it is. Happy to re-open if a counter-argument is raised :D

FYI @dinoel93 there's a new better feature for handling temporal filters in Jinja that'll be landing in 5.0 (forthcoming). See the new get_time_filter() Jinja function introduced here: #30323


怎么操作应用呢

Hi @Louis24, for desktop apps, you can use visual automation by providing images to click on and to type into. Or use x,y coordinates on the screen. Or use keyboard() step. You can also use OCR. See more at this section
https://github.com/tebelorg/RPA-Python?tab=readme-ov-file#element-identifiers
And example here - https://github.com/tebelorg/RPA-Python/blob/master/sample.py

I'll close issue for now but will look out for your reply


Expansion of cell output windows

It would be fantastic if the notebook editor could provide expanded output cells, such that scrolling the individual cell windows would not be required. This is currently an option in Jupyter notebooks by double-clicking the side of the window to toggle expanded/compact.
Could be an toggle feature similar to that, a setting to apply to all, etc.

Python › Data Science

I cannot find this setting anywhere. Do I need to literally write down "python.DataScience.EnableScrollingForCellOutputs": false in the settings json file?
Thanks!

Amazing cheers!

Closing as additional considerations for this issue are covered by other bugs such as #7096 and microsoft/vscode#131574


Front camera orientation

Hi there, I've a app with only portrait orientation, when use the lib to capture from front face camera, it not rotate the image, as happens with back camera... Is there a way to workaround this? Thanks a lot!!!

Same here - YPImagePicker does not rotate the front-camera image correctly (as YPImagePicker does correctly with the rear-camera image).  Landscape with front-camera (acquired with "didFinishPicking" delegate method) does show correct width and height.
The photo.image (or photo.originalImage) delivered by "didFinishPicking" for Landscape-aquired fotos from front-camera are corrupt (90 degree rotated).
Can you please tell us how to overcome this problem.

I am also facing the same problem.
I have debug and realized that after flip orientation is up, so image will not transform.
I try to fix, flip image after reset orientation. It looks like below:
DispatchQueue.main.async { [self] in
    let noOrietationImage = image.resetOrientation()
    // Flip image if taken form the front camera.
    if let device = self?.photoCapture.device,
       device.position == .front,
       let flippedImage = self?.flipImage(image: image) {
        image = flippedImage
    }
    self?.capturedPhotos.append(noOrietationImage.resizedImageIfNeeded())
}

But I think it should be done after the library is updated instead of doing it like above.

There is 2022 year outside🎉 Old outdated issues are closing. Please search if there are already existing issues with the same problem before opening new ☮


Fix docs generation for Vector2i/Vector3i/Rect2i

Added rest of the docs for these classes and enabled the generation of them in code + its also fixed usage of empty constructions like:

var v = Vector2i()
print(v[0])

I've already have a pr #39091 which could be closed if this merged.

I've already have a pr #39091 which could be closed if this merged.

Indeed, sorry for missing it. It's the exact same fix but @Chaosus's PR also adds documentation, so let's merge this one.


feat: add a key for CP to get a task from LagrangeDAO server

Description:
the server will allow CP to write its own key and then use that key when it is assigned to a task.

some reference about the design here:
https://docs.lagrangedao.org/lagrange-dao/security/access-tokens#external-access-tokens


Release 10.1.0

Is on the way.
Staged changes:
https://github.com/ctrlplusb/react-universally/issues?q=label%3Astaged+is%3Aclosed

Released.


Rendering Issue (Offset incorrectly)

I think I am having issues with the  viewbox attribute. When adding the file to the projects demo it renders at the bottom of the SVGImageView. When rendering it using the SVGLayer directly I get the same result.
The SVG in question has the attribute viewBox="271 652 587 400". I don't see this taken into account in the code.
Reproduction Steps:

Load the SVG: https://s3.amazonaws.com/music-provider-logos/AmazonMusic.svg
Set contentsGravity = kCAGravityResizeAspect.
Render the SVGLayer or display the SVGImageView.
The SVG is offset to the bottom of the context / view.

The basic gist of what I am trying follows:
SVGLayer *testLayer = [[SVGLayer alloc] initWithContentsOfURL:@"https://s3.amazonaws.com/music-provider-logos/AmazonMusic.svg"];
testLayer.contentsGravity = kCAGravityResizeAspect;
testLayer.frame = CGRectMake(0, 0, 300, 300);

UIGraphicsImageRendererFormat *format = [UIGraphicsImageRendererFormat defaultFormat];
format.scale = 1;

UIGraphicsImageRenderer *renderer = [[UIGraphicsImageRenderer alloc] initWithSize:CGSizeMake(300, 300) format:format];

UIImage *scaledImage = [renderer imageWithActions:^(UIGraphicsImageRendererContext * _Nonnull rendererContext) {
    // the SVG is white so a dark background is helpful.
    CGContextSetRGBFillColor(rendererContext.CGContext, 0, 0, 0, 1);
    [rendererContext fillRect:CGRectMake(0, 0, 300, 300)];

    [testLayer renderInContext:rendererContext.CGContext];
};

At this point I grab a PNGRepresentation of the scaledImage but I don't think that is relevant since adding the SVG reference above to the demo also renders at the bottom of the screen not centered.
Notes:

If I check testLayer.preferredFrameSize it returns roughly CGSize(839, 1026)
Opening the SVG in GIMP defaults to the "correct" resolution of 587x400 as defined in the viewbox attribute.
The image I get out looks like this:

Specifications

PocketSVG Version: Master
Xcode Version: 10.2.1
iOS Version: 12.2

viewbox is not taken into account. PocketSVG simply reads the paths as CGPaths. You'll have to process the svg to get rid of the offset.


Migration Guide - Create React App

Hello hello @sarah11918, this is (incredibly) late considering I said I was going to submit this PR on Thursday but here we are!!
What kind of changes does this PR include?
This is the migration guide from CRA that I had talked about with Sarah. I took a lot of the existing information from the Next migration guide especially since there was quite a few similarities (thank you, Corbin).
I was debating whether or not to mention CSS Modules since that's a possible use-case with some of the people who are migrating from CRA??? But I wanted to get your perspective.
I did end up finding a CRA logo (the SVG from their original docs) and added that to the necessary folder so it shows up.
Let me know where I may need to refine it!

Amazing contribution @LadyBluenotes ! I'm going to get to this soon! :raised_hands:

@sarah11918 I made some edits based on some comments you gave me. I did end up removing a lot of the repetition that was similar to what was in the NextJS page.
Let me know what you think!!

No idea what this is going to look like (:sweat_smile: ) but I took the helpful stuff here and tweaked the formula a bit, knowing that we want to emphasize, Look! Just drop in! For this particular migration guide.
Tried reframing as a two-parter: ADD your existing app, then CONVERT your app. Just mostly a re-org, so still needs work, but seeing how we like this general flow!

Hey @LadyBluenotes - I think the react-router-dom is a GREAT call out and an excellent inclusion. Lemme ask you, do you think this page can be (even initially) helpful without it, or would you consider that essential?  (Would let us be able to publish this first, to get it live in docs, then make another PR that focuses on React Router.) But if like 95% of people are going to need the react router stuff, then we don't want to prematurely anger people.  :sweat_smile:

@sarah11918 I don't have a really rough gauge on who uses the react-router-dom package (I wish the NPM site allowed you to check the relationship between 2 packages). I vaguely remember when writing my CRA app there was a lot of pressure with regards to using it - blogs, posts, etc. were chatting about it quite frequently and it almost made me wonder why they weren't integrated together already (which is funny looking back because of Next lol).
I'd probably say it could be added through its own PR, assuming we could get it out sooner vs later. Depending on how popular the migration is from CRA to Astro, it could lead to an influx in questions / comments. I do think they have a really strong relationship with one another, I just don't have a clue as to how strong it is.


[Feature #4542] : simple nav unify api/datasource (WIP)

WIP

Testing is in progress, minor UI updates are expected

Description
Simplifies the navigation experience of a user when creating new integrations by unifying apis/datasources tabs.
Fixes # (issue)
#4542
#5029
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested? (WIP)
manual

Cypress tests are yet to be updated.

Checklist: (WIP)

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:green_circle: Total coverage has increased
// Code coverage diff between base branch:release and head branch: feature/simple-nav-unify-api-datasource

Status
File
% Stmts
% Branch
% Funcs
% Lines

:green_circle:
total
53.35 (0.01)
35.3 (-0.03)
31.92 (-0.02)
53.91 (0.04)

:red_circle:
app/client/src/components/ads/Dropdown.tsx
63.01 (0.51)
63.53 (-3.58)
36.84 (0)
59.7 (0.61)

:red_circle:
app/client/src/components/ads/Tabs.tsx
22.92 (-4.58)
18.18 (-21.82)
0 (0)
22.92 (-4.58)

:green_circle:
app/client/src/components/editorComponents/ActionCreator.tsx
36.51 (1.84)
22.37 (-0.85)
24.27 (2.05)
35.66 (1.98)

:green_circle:
app/client/src/components/editorComponents/ApiResponseView.tsx
54.17 (1.31)
37.5 (2.02)
0 (0)
55.71 (1.3)

:green_circle:
app/client/src/components/editorComponents/Debugger/helpers.tsx
82 (0.87)
77.78 (0)
41.67 (3.21)
83.72 (1.5)

:green_circle:
app/client/src/components/editorComponents/form/fields/DropdownFieldWrapper.tsx
21.05 (4.38)
0 (0)
0 (0)
23.53 (4.78)

:sparkles: :new:
app/client/src/components/utils/CollapseComponent.tsx
42.86
20
0
50

:red_circle:
app/client/src/constants/routes.ts
81.88 (-1.05)
40.82 (-1.86)
63.16 (-1.55)
79.83 (-1.3)

:red_circle:
app/client/src/icons/MenuIcons.tsx
62.16 (-2.7)
100 (0)
17.65 (-5.88)
62.16 (-2.7)

:green_circle:
app/client/src/pages/Editor/routes.tsx
39.71 (0.9)
22.22 (0)
6.67 (0)
44.07 (0.97)

:green_circle:
app/client/src/pages/Editor/APIEditor/ProviderTemplates.tsx
35.29 (0)
40.82 (3.08)
4.76 (0)
37.63 (0)

:red_circle:
app/client/src/pages/Editor/APIEditor/index.tsx
30.77 (-0.36)
3.64 (0.13)
5 (0)
33.33 (-0.35)

:red_circle:
app/client/src/pages/Editor/DataSourceEditor/index.tsx
27.84 (-0.58)
0 (0)
11.76 (0)
29.07 (0)

:green_circle:
app/client/src/pages/Editor/Explorer/Actions/ActionEntityContextMenu.tsx
38.89 (3.41)
0 (0)
0 (0)
40 (3.33)

:red_circle:
app/client/src/pages/Editor/Explorer/Actions/helpers.tsx
46.77 (-8.61)
35.85 (-2.93)
20 (-11.82)
49.06 (-7.08)

:green_circle:
app/client/src/pages/Editor/Explorer/PluginGroup/PluginGroup.tsx
88.46 (0.46)
61.4 (0)
60 (0)
88 (0.5)

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/ActiveDataSource.tsx
47.73
47.06
11.11
57.14

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/AddDatasourceSecurely.tsx
90.91
100
0
90.91

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/DatasourceCard.tsx
60.98
55.56
0
60.98

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/DatasourceHome.tsx
55.26
53.33
11.11
60.61

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/IntegrationsHomeScreen.tsx
32.41
20.83
7.14
33.66

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/NewApi.tsx
63.64
66.67
0
65.63

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/NewQuery.tsx
54.55
100
16.67
68.75

:sparkles: :new:
app/client/src/pages/Editor/IntegrationEditor/index.tsx
62.5
100
0
62.5

:red_circle:
app/client/src/pages/Editor/QueryEditor/EditorJSONtoForm.tsx
45.52 (-2.99)
45.71 (-2.77)
0 (0)
47.83 (-2.95)

:red_circle:
app/client/src/pages/Editor/QueryEditor/index.tsx
32.18 (-0.77)
12.12 (0.69)
7.69 (0)
34.18 (-0.82)

:green_circle:
app/client/src/pages/Editor/SaaSEditor/DatasourceForm.tsx
36.08 (0.66)
19.05 (0)
6.25 (0)
38.2 (0.7)

:green_circle:
app/client/src/sagas/ActionSagas.ts
12.06 (0.05)
1.1 (0.04)
4.55 (0)
14.66 (0.07)

:green_circle:
app/client/src/sagas/ApiPaneSagas.ts
15.57 (0.29)
1.87 (0)
7.41 (0)
17.49 (0.29)

:red_circle:
app/client/src/sagas/DatasourcesSagas.ts
13.91 (-0.05)
2.11 (0)
9.52 (0)
16.36 (-0.08)

:green_circle:
app/client/src/selectors/entitiesSelector.ts
47.51 (2.26)
5.56 (0)
19.51 (3.66)
45.4 (3.07)

:x:
app/client/src/actions/collectionAction.ts
75
100
0
66.67

:x:
app/client/src/pages/Editor/APIEditor/ApiHomeScreen.tsx
37.04
24.32
3.57
37.4

:x:
app/client/src/pages/Editor/DataSourceEditor/DatasourceHome.tsx
56.52
52.63
10
58.14

:x:
app/client/src/pages/Editor/QueryEditor/AddDatasourceSecurely.tsx
91.67
100
0
91.67

:x:
app/client/src/pages/Editor/QueryEditor/DatasourceCard.tsx
58.97
52.94
0
58.97

:x:
app/client/src/pages/Editor/QueryEditor/QueryHomeScreen.tsx
41.07
42.11
8.33
44.9

/ok-to-test sha=64bbcd3

Approved for tests.

Approved for tests.

/ok-to-test sha=7aba024

/ok-to-test sha=6e93a4e

/ok-to-test sha=a75c5fa

/ok-to-test sha=25e2380

/ok-to-test sha=3d79e2f

I think we updated this icon in the omnibar search, we should keep the old one, also we could the same one for actions within property pane
@pranavkanade

I think we updated this icon in the omnibar search, we should keep the old one, also we could the same one for actions within property pane
@pranavkanade

@rishabhsaxena now using red api icon in global search and action selector

/ok-to-test sha=027ad64

/ok-to-test sha=0c44691

@rishabhsaxena
Added fixes for both mentioned instances

Tests failed due to mock data resources are not up yet. Deployment is in progress for release BE. Will rerun the flow once the expected BE changes are up

/ok-to-test sha=d54734a

/ok-to-test sha=1b2819f

@pranavkanade I suppose should also confirm it the api itself doesn't throw an error for self hosted instances


Error in language_row.py module

Hello, I have been snapping this app, but at the end, I'm getting this error.
Traceback (most recent call last):
  File "/snap/frog/x1/usr/bin/frog", line 59, in <module>
    from frog import main
  File "/snap/frog/x1/usr/lib/python3/dist-packages/frog/main.py", line 46, in <module>
    from .window import FrogWindow
  File "/snap/frog/x1/usr/lib/python3/dist-packages/frog/window.py", line 38, in <module>
    from .language_dialog import LanguageItem
  File "/snap/frog/x1/usr/lib/python3/dist-packages/frog/language_dialog.py", line 33, in <module>
    from .language_row import LanguageRow
  File "/snap/frog/x1/usr/lib/python3/dist-packages/frog/language_row.py", line 8, in <module>
    class LanguageRow(Gtk.Overlay):
  File "/snap/frog/x1/usr/lib/python3/dist-packages/frog/language_row.py", line 13, in LanguageRow
    progress_bar: Gtk.ProgressBar = Gtk.Template.Child()
  File "/snap/frog/x1/gnome-platform/usr/lib/python3/dist-packages/gi/overrides/__init__.py", line 32, in __getattr__
    return getattr(self._introspection_module, name)
  File "/snap/frog/x1/gnome-platform/usr/lib/python3/dist-packages/gi/module.py", line 173, in __getattr__
    interfaces = tuple(interface for interface in get_interfaces_for_object(info)
  File "/snap/frog/x1/gnome-platform/usr/lib/python3/dist-packages/gi/module.py", line 95, in get_interfaces_for_object
    interfaces.append(getattr(module, name))
  File "/snap/frog/x1/gnome-platform/usr/lib/python3/dist-packages/gi/overrides/__init__.py", line 32, in __getattr__
    return getattr(self._introspection_module, name)
  File "/snap/frog/x1/gnome-platform/usr/lib/python3/dist-packages/gi/module.py", line 213, in __getattr__
    wrapper = metaclass(name, bases, dict_)
  File "/snap/frog/x1/gnome-platform/usr/lib/python3/dist-packages/gi/types.py", line 247, in __init__
    register_interface_info(cls.__info__.get_g_type())
TypeError: must be an interface

Can you please help me fix this.

@soumyaDghosh sry for the late response. Not sure what happened inside the snap. Maybe the GTK version is a bit odd or there are not enough .gir files. Could you point me to the snap file to check it locally?

Sorry, forgot to inform you. The snap is working and in the store now

Currently there are 85 active users. But, I guess it can increase if this is added in your repo
Markdown
[![Get it from the Snap Store](https://snapcraft.io/static/images/badges/en/snap-store-black.svg)](https://snapcraft.io/frog)

HTML


Set up testing for sorting by data attribute.

This would require making change to test/table.js and test/table.test.js to write some tests.

Completed in commit: 88fae66


RemoteFile: unlink tempfile when using cache control shows unchanged

We can get back a nil tempfile from the streaming downloader which means
that we need to clean up our own tempfile since the base file provider
will not do it for us.

should probably write a spec for this


[Mac Installation] 404 Error in downloading atlas.tgz

Running python atlas_installer.py on a Macbook gives the following error:
Cannot download the installation package from https://github.com/dessa-oss/atlas/releases/download/0.1.1.dev3/atlas.tgz.. I downloaded the atlas_installer.py from https://github.com/dessa-oss/atlas/releases

Hey @cbalaf ! We are working on fixing this issue, in the meanwhile here is a quick workaround:

Open up atlas_installer.py and change the version 0.1.1.dev3 to 0.1.1

Thanks for the quick reply! I changed line 18 of atlas_installer.py to 0.1.1 but, unfortunately, I'm getting the same error

It should be 0.1.0.

That did it - thanks so much!


It happened  error after i add ElementUiResolver

This does not seem to be a problem with this plugin.
Please go to the element-plus repo to create an issue and provide a reproduction link. Without it, we can give any help to you.


gmail refresh token

hi
I use gmail for sending development emails and its access_token will expire after one hour.
How can I use refresh_token for refreshing access token in swoosh?
thanks

Hi @thantez please take a look at this comment https://github.com/swoosh/swoosh/pull/342#issuecomment-461260398
We don't have an implementation to help refresh the access token.


Init not showing in console

May just be me doing something wrong but when trying to get auth info init doesnt show in the network/xhr tab, I even tried firefox and its not there either. Possible onlyfans networking update or am i just dumb?

if you filter the network requests with onlyfans and you should get a good hit
you should get a hit with the required information

Example with github

Please don't take this example literally
of course on onlyfans you would search for onlyfans, and look for  request url with onlyfans, typically api.onlyfans
but the idea remains the same between the two examples

closing


rerevert grid cleanup

Convert GridMetricCalculator, GridRange, GridUtils to TypeScript (#302)
Fix the calculation for visibleRowHeights/visibleColumnWidths

@mattrunyon @spasovski It would be easiest to review this just by looking at the second change.


how can I find out information about which body part the observation belongs to?

similar to the OpenAI mujoco tasks where they have documentation detailing which dimension of the state corresponds to which part of the physical body, it would be good to be able to have something similar for DMC. If I look at e.g. walker-walk all I get from the time step is an observation with 'orientations', 'height' and 'velocity'. Can I at least find this information out by looking at the source code?

@davidireland3 were you able to figure out how to get the joint sensor level information?

@pvskand kind of. I had to look at the source code when observations were created. I managed for walker but a more complex environment such as quadruped was not as easy, especially when trying to figure out which action related to which actuator.

I see. If it's possible could you share the sensor/joint level information and which index does it correspond to in the observation orientations and velocity? (height is a 1-dim quantity so that is trivial).
Thanks in advance!

I have this for walker:
    "walker-walk": {
        "body_ids": {
            'torso': np.array([0, 1, 14]),
            'rthigh': np.array([2, 3, 15]),
            'rleg': np.array([4, 5, 16]),
            'rfoot': np.array([6, 7, 17]),
            'lthigh': np.array([8, 9, 18]),
            'lleg': np.array([10, 11, 19]),
            'lfoot': np.array([12, 13, 20]),
        }

where the indices correspond to a state vector obtained by doing np.concatenate([v.flatten() for v in self._time_step.observation.values()])
I didn't break down whether they correspond to orientations or velocity, I was just interested which aspect of the state corresponds to which body parts.


Feature Request - sort by most voted

We'd love to be able to sort comments by most voted (reddit style, or stackoverflow).  Is this in the roadmap?

There is a tab "popular" which sorts the comments by most voted.


Sync vs refresh

Dev Home version
0.1701.597.0
Windows build number
10.0.22631.4112
Other software
OS Build Version: 10.0.22631.4112.amd64fre.ni_release.220506-1250
.NET Version: .NET 8.0.7
Steps to reproduce the bug
On the environments page there is a sync button. That is an interesting verb choice. Sync usually communicates aligning content across two sources.
I would have expected this verb to be more like "Refresh"
Expected result
Refresh button
Actual result
Sync button

Included System Information
CPU: Intel(R) Core(TM) Ultra 7 165H
Physical Memory: 31.64GB (11.94GB free)
Processor Architecture: x64
Included Extensions Information
Extensions:
Microsoft.Windows.DevHome_0.1701.597.0_x64__8wekyb3d8bbwe (Core Widget Extension)
Microsoft.Windows.DevHome_0.1701.597.0_x64__8wekyb3d8bbwe (Hyper-V Extension)
Microsoft.Windows.DevHome_0.1701.597.0_x64__8wekyb3d8bbwe (Windows Subsystem for Linux Extension)
Microsoft.Windows.DevHome_0.1701.597.0_x64__8wekyb3d8bbwe (Git)
Microsoft.Windows.DevHomeGitHubExtension_0.1700.597.0_x64__8wekyb3d8bbwe (Dev Home GitHub Extension (Preview))
Microsoft.Windows.DevHomeAzureExtension_0.1200.597.0_x64__8wekyb3d8bbwe (Dev Home Azure Extension (Preview))
Widget Service:
MicrosoftWindows.Client.WebExperience_524.23700.10.0_x64__cw5n1h2txyewy

Closing as duplicate of #3355


24px - infinity

#159
https://www.figma.com/file/2rjsQp42uKvzPXzLZIqOeA/Octicons-v2-Source?node-id=723%3A1704

I made this 1px taller than @ashygee 's version so it would scale without aliasing.


interferences_with_ray usage

Hello,
I'm trying to use interferences_with_ray but I'm completely unable to find anything. I'm probably doing something wrong, but I cannot find out what. In this test I'm adding a ball with 0.5 radius in the coordinates (1, 1, 1) and I'm casting a ray from (0, 0, 0) looking towards (1, 1, 1). I think the ball should interfere with the ray.
When I run the test I get the following result
---- geometry::interferences_with_ray::interferences_with_ray stdout ----
thread 'geometry::interferences_with_ray::interferences_with_ray' panicked at 'Expected 1 collision, got 0', build/ncollide3d/tests/geometry/interferences_with_ray.rs:35:5

use std::f32;

use na::{Isometry3, Translation3, UnitQuaternion, Vector3, Point3};
use ncollide3d::{
    query::Ray,
    shape::{Ball, ShapeHandle},
    world::{CollisionGroups, CollisionWorld, GeometricQueryType},
};

#[test]
fn interferences_with_ray() {
    let mut world = CollisionWorld::new(0.01);

    let shape = ShapeHandle::new(Ball::new(0.5f32));
    let groups = CollisionGroups::new();
    let query = GeometricQueryType::Contacts(0.0, 0.0);

    let tra = Translation3::new(1.0, 1.0, 1.0);
    let rot = UnitQuaternion::from_scaled_axis(Vector3::y() * f32::consts::PI);
    let iso = Isometry3::from_parts(tra, rot);

    world.add(iso, shape.clone(), groups, query, ());

    let num_collision_objects = world.collision_objects().into_iter().collect::<Vec<_>>().len();
    assert!(
        num_collision_objects  == 1,
        format!("Expected 1 collision object, got {}", num_collision_objects),
    );

    let ray = Ray::new(Point3::new(0.0, 0.0, 0.0), Vector3::new(1.0, 1.0, 1.0));
    let groups = CollisionGroups::new();
    let interferences = world.interferences_with_ray(&ray, &groups);

    let num_collisions = interferences.into_iter().collect::<Vec<_>>().len();
    assert!(
        num_collisions  == 1,
        format!("Expected 1 collision, got {}", num_collisions),
    );
}

Thanks!

So... apparently I had to call update for the collisions objects to be actually inserted.


Add script to cleanup redundant BCD overrides

This PR adds a script that removes the compat_features overrides from web-features files when the overrides' data matches the data that comes from BCD tags.

Ack, my top-of-review comment got lost:
Cool! I have some suggestions to make this safer to run and to improve maintainability, but I like the overall shape of this.


how to pass an array to never

$ cat morula.yml
before-all: ""
after-all: ""
always: ""
never:
  - ".idea"
color: true

$ morula all test
running test in subproject .idea ...

subproject .idea has issues

$ cat morula.yml
before-all: ""
after-all: ""
always: ""
never: ".idea"
color: true

$ morula all test
running test in subproject apps ...

subproject apps has issues

Strange. We have tests for both of your use cases: https://github.com/Originate/morula/blob/master/features/never.feature
Do you have the latest version (0.1.1) installed?

I did a go get but that doesn't update the code base if it exists. I'll check again later, thanks for the swift reply

morula version tells you the version in case its unclear  :)

version shows "Morula v0.1", even after go get -u, but the issue is resolved :)


Recognizable key names

I was thinking something like RFC 1751 or pgpwordlist would make it easier for users to notice any problems with keys, should they occur.

I'm skeptical, but it would be great to find better ways of storing keys. Is there much review/research on how well these systems were received?

I couldn't find much for using them as verification tools rather than entry tools - IMO it's much better suited to the former.
There are definitely other options for display, but they all involve keeping a mapping of name to key somewhere.

For verification we have the TUF structure. I don't think we need to add anything there. I was much more interested in this as a way for delegates to "transport" their keys.

Along the same lines, https://github.com/kaepora/miniLock generates keys based on long passphrases - so the key is not stored, you just have to remember the passphrase.  https://pypi.org/project/deadlock/ is a CLI tool for minilock.


Integrate Real-Time Superfluid Donation Stream Ticker in User Profiles for Collectives

Business Description
The initiative aims to elevate user engagement on our platform by integrating a real-time ticker in user profiles. This innovative feature will display live updates of Superfluid donation streams for chosen collectives, offering users an immersive and informative way to track their ongoing contributions.

Key Features and Benefits

Interactive Donation Tracking: The real-time ticker will provide users with a dynamic view of their Superfluid donation streams. This enhances user interaction by allowing them to visually track the flow of their contributions to various collectives.

Live Balance Updates: Utilizing real-time streaming data, the ticker will continuously calculate and update the current balance of donations. This feature provides users with an immediate and accurate representation of their financial impact.

Seamless UI Integration: The ticker is designed to be visually intuitive and will be integrated harmoniously within the existing user profile interface. This ensures that the feature is not only informative but also enhances the overall aesthetic of the user profile.

Data Accuracy and Real-Time Analysis: The feature will leverage Superfluid tools for accurate, real-time data fetching. This ensures that the displayed information is both current and reliable.

Enhanced User Experience: By providing a transparent, real-time visualization of financial contributions, this feature is expected to significantly improve user engagement and satisfaction.

Technical Implementation
To enhance user engagement, we aim to implement a real-time ticker in user profiles that displays the Superfluid donation streams for specific collectives. This ticker will dynamically calculate and show the current balance of donations based on real-time streaming data, offering users a more immersive and informative experience in tracking their contributions.
Details

Feature Development: Integrate a live ticker within user profiles to show ongoing Superfluid donation streams for selected collectives. This ticker will not only display the flow rate but also dynamically calculate the current balance based on the flow data.
Dynamic Balance Calculation: Utilize the insights from the Superfluid stream query results to calculate the current balance.

Starting Balance: Use a known starting balance of both the sender (user) and receiver (collective) as the reference point.
Flow Rate Analysis: Continuously fetch the currentFlowRate from inflows and outflows (if any) in the user's donation stream.
Time-Based Calculation: Calculate the duration each flow has been active using createdAtTimestamp and flowUpdatedEvents timestamps.
Balance Update: Multiply the duration by currentFlowRate for each flow to determine the total flow amount. Update the ticker's displayed balance by adding these amounts to the starting balance.
Example querying the Superfluid subgraph on Celo:

query ($id: ID = "") {
  account(id: $id) {
    inflows {
      id,
      sender {
        id
      }
      currentFlowRate
      flowUpdatedEvents {
        flowRate
        oldFlowRate
        timestamp
      }
      createdAtTimestamp
      updatedAtTimestamp
    }
    outflows {
      id,
      currentFlowRate
      flowUpdatedEvents {
        flowRate
        oldFlowRate
        timestamp
      }
      createdAtTimestamp
      updatedAtTimestamp
    }
  }
}

User Interface: Design the ticker to be visually intuitive and harmoniously integrated within the existing profile UI, ensuring clear visibility and understanding of the donation streams and their current balances.
Dependencies: Successful feature implementation is dependent on the integration with the Superfluid JavaScript library and/or subgraph for accessing real-time streaming data.
Note: The approach outlined here assumes a consistent flow rate and no external transactions affecting the balance outside of the Superfluid stream.

Expected Outcome

Users will have a live, interactive view of their Superfluid donation streams, including the ability to see the dynamically calculated current balance of their donations in real-time.
This feature is expected to significantly enhance user interaction and engagement with the platform by providing a transparent, real-time visualization of financial contributions to collectives.

Estimate

Requirement Analysis and Planning (3-5 hours): Understanding the requirements and technical specifications, including any nuances related to the Superfluid integration and the real-time aspect of the feature.

Implementation (20-30 hours):

Integrating Real-Time Data Fetching (8-12 hours): Implementing the logic to fetch real-time data from the Superfluid streams using the GraphQL queries, and handling inflows and outflows.
Dynamic Balance Calculation (6-10 hours): Developing the logic to calculate the current balance dynamically, considering the flow rates, timestamps, and starting balance.
UI Development (6-8 hours): Actual development of the ticker feature in the user profile, ensuring it is responsive and matches the design prototype.

Testing and Debugging (10-15 hours): Conducting thorough testing to ensure data accuracy, real-time updates, and seamless integration. This includes handling edge cases and potential discrepancies in data streaming.

Review and Refinement (4-6 hours): Addressing any feedback and refining the feature as needed.

Documentation (3-5 hours): Documenting the feature implementation

Adding these up, the total estimated time could be around 40-61 hours. This estimate assumes that the developer has a good understanding of the technologies involved and that there are no significant roadblocks or external dependencies that could delay the project.

Hi @benefacto!

The business description sounds accurate - there is nothing in there that looks new or incongruent with the prototype and requirements shared prior.
Superfluid has this ticker as part of their widget - my understanding was that we simply needed to implement their widget with maybe some UI configurations and tell it where to point (subgraph mapping). IE we should not be building a new ticker UI component from scratch.
@sirpy or @L03TJ3 can help point you to the documentation and code base for this widget.
It also looks like the Estimates are a bit off - for example the low end should be 37 hours (if I add up all of the low-end of your estimates).

@sirpy I guess that is you who has this source?
did we (or you) already implement this widget somewhere?

@benefacto @L03TJ3
Not aware of any specific widgets, you can either look at superfluid widget code to see how they do it
or use some kind of other react-native component for a counter.
but it is just a simple counter that increases the number according to the flow rate. so basically the number displayed is
current balance + (secondsPassed * flowRate)

@decentralauren to get documentation for this. (or @sirpy :)

@decentralauren @patpedrosa
need to redefine how we show the real-time ticker right?

@decentralauren @patpedrosa need to redefine how we show the real-time ticker right?

Is it fair to say this issue is completed on my end? All of the donation values are displayed as real-time flows using the method provided by @decentralauren .

@sirpy @krisbitney
What can be the reason for a difference between ticker on app and amount shown on contract?
what is the default interval (was not able to find it yet, we don't pass any down ourselves)

@krisbitney @sirpy There is a difference between what is shown on the app for the Current Pool and the current balance of the pool contract.  Can y'all explain why this is / how we reconcile?

https://explorer.celo.org/mainnet/address/0x11F18E8f2a27d54A605Cf10486B3d4c5aEeBa81F

It looks like there is something wrong with the flowing balance calculation. I'm looking into it now.

@decentralauren @sirpy I found and fixed the problem. I'll have a PR up soon.

Fixed in https://github.com/GoodDollar/GoodCollective/pull/131

Thanks @krisbitney !! @vldkhh can you retest?

@krisbitney @decentralauren 31 G$ difference, @decentralauren are we ok with that?

@krisbitney @decentralauren 31 G$ difference, @decentralauren are we ok with that?

Is that possibly due to lag or do you think it's a calculate error?

no issue closing, small delay in celoscan / explorer to update the active value (it does not update every millisecond)


Confirm that datasette.yaml environment variables work like they did in metadata.yaml

From looking at this code I think they'll work the same:
https://github.com/simonw/datasette/blob/5d21057cf1e4171bc2741d3d8d9da83aee1165b5/datasette/app.py#L701-L708
Need to be sure though, and possibly update documentation in a few places.

This is already documented correctly: https://docs.datasette.io/en/latest/plugins.html#secret-configuration-values


Can I add number guessing effect with sound effects |HTML|CSS|JS

please assign me this under hactoberfest 2023 @DhanushNehru

Sure @Khushi-74

thank you @DhanushNehru #213 completed

Please assign me with this issue I want to contribute @DhanushNehru


hopefully fixes equalization

makes the for loop ignore the last element like monstermos originally intended

it doesn't but more accurate to the original code is better and less likely to cause problems so


Add break properties fallback

break-inside, break-before, break-after properties should fallback to page-break- alias.
This fallback has removed from autoprefixer https://github.com/postcss/autoprefixer/issues/972
I made postcss-page-break plugin for this and want to add it to postcss-preset-env. But first, break- feature should be added to css-db.

Sorry, wrong repo


Update README.md

update broken link

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1326cd4) 91.19% compared to head (30f5595) 90.36%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #143      +/-   ##
==========================================
- Coverage   91.19%   90.36%   -0.84%
==========================================
  Files          11       11
  Lines         409      498      +89
  Branches       79      107      +28
==========================================
+ Hits          373      450      +77
- Misses         31       39       +8
- Partials        5        9       +4

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Document power management and capacity planning feature

We should document the latest new feature: "Implement power management and capacity planning".

closing because of https://github.com/threefoldtech/tfchain/issues/551


ReferencesCrossMultiModule test fails

Passes with https://github.com/Microsoft/python-language-server/pull/82


Stackoverflow error with multiple nested NULLIF and/or COALESCE

Transpiling to every current target (Redshift, Spark, Trino) results in a stackoverflow error when there are multiple nested NULLIF and/or COALESCEs.
E.g.
-- Transpiling (8 nested COALESCEs):
COALESCE(COALESCE(COALESCE(COALESCE(COALESCE(COALESCE(COALESCE(COALESCE(1))))))))

or
-- Transpiling (8 nested NULLIFs):
NULLIF(NULLIF(NULLIF(NULLIF(NULLIF(NULLIF(NULLIF(NULLIF(0,0),0),0),0),0),0),0),0)

both result in a stackoverflow error when converting from the AST to text.
I believe this is due to the current modeling of NULLIF and COALESCE in the partiql logical plan, which converts both to the case when expression equivalent as defined by the SQL spec. The nesting can be seen with a simple query:
COALESCE(COALESCE(COALESCE(1)))

which results in
CASE WHEN NOT (CASE WHEN NOT (CASE WHEN NOT (1 IS NULL) THEN 1 ELSE CAST(NULL AS INT) END IS NULL) THEN CASE WHEN NOT (1 IS NULL) THEN 1 ELSE CAST(NULL AS INT) END ELSE CAST(NULL AS INT) END IS NULL) THEN CASE WHEN NOT (CASE WHEN NOT (1 IS NULL) THEN 1 ELSE CAST(NULL AS INT) END IS NULL) THEN CASE WHEN NOT (1 IS NULL) THEN 1 ELSE CAST(NULL AS INT) END ELSE CAST(NULL AS INT) END ELSE CAST(NULL AS INT) END

Through some investigation, there are two key problems

asts that are large enough may cause a stackoverflow in SqlDialect, specifically for the call to SqlBlock.sql(layout) since each SqlBlock, corresponding to one token will be pushed on the stack

To resolve, we can look into changing the recursive call structure to prevent such large call stacks as this could be an issue for other large asts

converting COALESCE and NULLIF into CASE WHEN expressions as per the SQL rewrite can result in a large plan and thus large ast with a lot of repeated expressions

To resolve this, we can either

Add a conversion of CASE WHENs that match the rewrite back into COALESCE and NULLIF. This approach can be seen in #29.
Change the modeling of COALESCE and NULLIF in the logical plan to have separate nodes in the plan rather than rewrite to use CASE WHEN

The stackoverflow issue related to the AST printing of COALESCE and NULLIF was fixed in the short-term w/ https://github.com/partiql/partiql-scribe/pull/29.
This issue should be resolved with the long-term fixes:

https://github.com/partiql/partiql-scribe/pull/30
https://github.com/partiql/partiql-lang-kotlin/pull/1404

Once the new partiql-lang-kotlin version is released and Scribe pulls it in, this issue should be resolved.


navigator.epubReadingSystem

fixes #120

Just a note:
Interestingly, @types/node is v10 as a sub-dependency (for other NPM packages) in package-lock.json, whereas readium-desktop (as well as all the r2-xxx-js packages) must stick to v8 (see:
https://github.com/edrlab/readium-desktop/blob/011a75e8663c6d58df6a5f4d298bce2eb99603c9/package.json#L158 ), otherwise TypeScript compilation fails (notably: because of the URL typings).
Thankfully, NPM node_module organisation + resolving algorithm means that our own v8 devDependency gets a higher priority.
To be precise, v9 is still compatible, but v8 is logically aligned with Electron's NodeJS runtime v8.2.1: https://github.com/electron/electron/blob/v1.8.6/.node-version


update CCF to branch: shane/duckplayer/shorts

Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1203249713006009/1204911763532130/f
iOS PR: N/a (yet)
macOS PR: https://github.com/duckduckgo/macos-browser/pull/1309
What kind of version bump will this require?: Patch
Optional:
Tech Design URL:
CC:
Description:
Another bug-fix for Duck Player - see the Asana task

Steps to test this PR:

Duck Player should work as expected
Overlays should not show on Shorts

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12

Internal references:
Software Engineering Expectations
Technical Design Template

Approved on macos + ios - merging and cutting a new release


adding additional markdown functionality:  ==highlight== and underline

@soffes first (well first as far as i know) introduced these features into redcarpet. he talks about them here. I'm using marked in conjunction with strapdown to generate my blog, and i really wanted these features incorporated.
tests are included.
you can read my blog post about it here.
let me know if there's anything you need/feel i should do/change. :)

Closing due to staleness, does not seem to fit with the two specifications we are focusing on, and merge conflicts. See #956


VBA - No limit for the number of digits for SSN in the personal info page

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Action Performed:

Launch the app
Log in with expensiafail account
Go to Setting - Preferences
Enable the Secure Staging Server
Go to any Workspace - Connect Bank Sccount
Tap Connect online with Plaid
Select Wells Fargo Bank Account
Put username: user_good, password: pass_good
Tap Submit
Tap on Plaid Saving - Save and continue
Put all necessary information in Compony Information Page
12 Tap Save and Continue
In SSN box start typing as many number you are want

Expected Result:
User not allowed to enter more than 4 digits for SSN
Actual Result:
No limit of digits for the SSN box in Personal Information Page
Workaround:
Unknown
Platform:

Where is this issue occurring?

Web
iOS
Android
Desktop App
Mobile Web

Version Number: 1.1.35-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Expensify/Expensify Issue URL:
Issue reported by:  Applause
Slack conversation:
View all open jobs on GitHub

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

Triggered auto assignment to @aldo-expensify (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

Confirmed that this is broken now

This was caused by this PR, specifically by adding the maxLength: PropTypes.number in here  https://github.com/Expensify/App/blob/47ec8f4ae0598e55c4d75b275ef4feeec8f14d6e/src/components/TextInput/baseTextInputPropTypes.js#L49-L50
Because that prop is now there, it gets removed here:
https://github.com/Expensify/App/blob/47ec8f4ae0598e55c4d75b275ef4feeec8f14d6e/src/components/TextInput/BaseTextInput.js#L147
And doesn't continue down as it did before


Feature/test

Description
Fix to support card details grid in the accordion
Fixes # 19188
Overview of Changes

binding variable in the html was incorrect

Type of change - UI
Please delete options that are not relevant.

[ ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

Additional Notes
Please add any additional notes regarding this pull request here.

You did it @sandeepmantha!
Thank you for signing the Anthem Opensource Software CLA.


Crawlera credentials in README

scrapy-crawlera README tells users to set Crawlera user and password. Haven't we changed Crawlera authentication to be done with an API Key?

yes, it also support API Key inside crawlera_user, changing readme


⚠ Fortnite has degraded performance

In ee17cf8, Fortnite (https://fortnite.com) experienced degraded performance:

HTTP code: 200
Response time: 1561 ms

Resolved: Fortnite performance has improved in 8432cf2.


MODE-2425 Fixed PATH() queries with SET criteria.

amended the commit

Do the tests still work?

yes, why ?

You changed it quickly, and I didn't know if you re-ran the tests.

I only re-ran the JcrQueryManagerTest test case, but I don't really expect other test to fail because of the change.

Ok, great. Looks great.


[$250] mWeb - Chat - Entering multi line text by tapping enter key, cursor goes down instead of next line

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.29
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4919668
Issue reported by: Applause - Internal Team
Action Performed:

Go to https://staging.new.expensify.com/home
Open a chat
Copy the url and paste in compose
Send the message
Edit the message by long pressing the message
Remove url text and try to enter multi line text by tapping enter key

Expected Result:
Entering multi line text by tapping enter key, cursor must go to next line
Actual Result:
Entering multi line text by tapping enter key, cursor goes down instead of next line
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/user-attachments/assets/a732486b-d5d7-46c8-a265-a1434259fe77
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021831319729138132205
Upwork Job ID:<PHONE_NUMBER>138132205
Last Price Increase: 2024-09-04

Issue OwnerCurrent Issue Owner: @Ollyws

Production:
https://github.com/user-attachments/assets/10cd64e4-eb21-4e85-9ddd-0eaefefb24a4

when I long-press the message, the option to "Copy URL to clipboard" appears instead of the "Edit" option. How can I resolve this issue and enable message editing?
here is the video
screen-capture.webm

@Gonals can we get your feedback here? Thanks!

@Gonals @lanitochka17 when I long-press the message, the option to "Copy URL to clipboard" appears instead of the "Edit" option. How can I resolve this issue and enable message editing? here is the video
screen-capture.webm

Don't press directly on top of the URL. Just the general message.

@Ollyws when you get a chance, can you review these proposals? Thanks!

Open for proposals here

@Ollyws when long press on any text message, It shows all the option to edit the message, but when trying to edit URL message or link. It doesn't show edit comment option. It shows only Copy URL. You can find attached image.

Waiting for proposals here

Still open here

It is not overdue; we are open to proposals here.

The composer is focused before the context menu disappears, causing issues with the focus trap and React event system. PR https://github.com/Expensify/App/pull/48973 will fix this by adding a delay.

The PR has been merged, and this issue is no longer reproducible.
https://github.com/user-attachments/assets/8d60896d-5979-43cf-a4b4-63652ef68401

Closing - it looks like this one was fixed in another GH. Thanks for the update.


Observability update for powerscale and powerflex

Description
Observability update for powerscale and powerflex
GitHub Issues
List the GitHub issues impacted by this PR:

GitHub Issue #

https://github.com/dell/csm/issues/1012

Checklist:

[X] I have performed a self-review of my own code to ensure there are no formatting, vetting, linting, or security issues
[ ] I have verified that new and existing unit tests pass locally with my changes
[X] I have not allowed coverage numbers to degenerate
[ ] I have maintained at least 90% code coverage
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[X] I have maintained backward compatibility

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

[ ] Test A
[ ] Test B

We can remove v1.4.0 of observability https://github.com/dell/csm-operator/tree/main/operatorconfig/moduleconfig/observability/v1.4.0 as we support only n-2 versions.

removed


@-prefixed variables / data keywords broken?

Helpers like @index, @first etc. are not working for me. I see tests for this are passing, so I am not sure what the issue is. Using ember 1.13.9, ember-cli-emblem 0.3.1. Something very basic:
each foo in foos
  p index: #{@index}

Will be empty. Something like if @index won't even compile. Is there something I am missing here?
Original implementation: https://github.com/machty/emblem.js/pull/150
Tests (passing): https://github.com/machty/emblem.js/blob/master/tests/integration/vanilla-handlebars-support-test.js#L70-L76

This functionality was removed in the push to 0.5.0 (the big change where Emblem outputs Handlebars code rather than brittle Handlebars AST); it shouldn't be a lot of work to add it back, but given most people use Emblem with Ember, there hasn't been a big community need for it. I don't have the time to add this feature back, but it shouldn't be too difficult, and I'd happily accept a PR that got these tests passing again.

Closing as this is now fixed on master (release forthcoming)


Determine array sizes for passed-in arrays in DAQ

What does this Pull Request accomplish?
Determines array size and passes that in automatically.
Note that this is just a proof of concept - I have not looked through the rest of the DAQmx functions to see which other ones could take advantage of this. This will hopefully let us get a sense for how hard this is and how much value it provides.
Why should this Pull Request be merged?
Eases the burden on clients to have to pass in the array size and removes the possibility that a wrong size will be passed in, which can cause memory corruption.
What testing has been done?
Added an automated test.

@harsha-bhushan @gregstoll
This is a similar issue to #311 but this time for array inputs instead of array outputs.
Compared to that issue:

How annoying is it when the customer does it right? -> Equally annoying (they have to pass in a size param).
How bad is it when the customer does it wrong? -> Worse if they pass in a too-large size (causes undefined behavior) the same if they forget to pass a size.
How hard is it to fix later? -> This one is easier. We can deprecate the size field and basically ignore it and the behavior will be unchanged for normal usages (if they were passing in a non-zero too-large or too-small size, the behavior will change). We might need more code do "something reasonable" when the user passes in a size (return error, use size if smaller, etc)
How easy is it to detect all usages? -> Probably the same. We'll have to find all array inputs and figure out what their size param is. Mostly that is straightforward and there are common patterns of array/size pairs.

Thanks for the detailed comparison. This looks promising and improves usability.
Please get this reviewed by an expert from DAQmx team to identify all usages & (if any places this can cause issues) also the behavior when size is passed.


Using multi_scorer raises AttributeError

Traceback (most recent call last)
/opt/anaconda3/envs/<my_env>/lib/python3.10/site-packages/inspect_ai/_eval/task/run.py:182 in task_run
/opt/anaconda3/envs/<my_env>/lib/python3.10/site-packages/inspect_ai/_eval/task/results.py: 27 in eval_results
/opt/anaconda3/envs/<my_env>/lib/python3.10/site-packages/inspect_ai/_util/registry.py:179  in registry_info

AttributeError: 'function' object has no attribute '__registry_info__'

Quick fix:
Adding:
@scorer(metrics=[accuracy(), bootstrap_std()])

above line 19 in inspect_ai/scorer/_multi.py:
def multi_scorer(scorers: list[Scorer], reducer: ScoreReducer) -> Scorer:

I think you just need do to this: scorer=custom_multi_scorer() (i.e. call the custom_multi_scorer() function)

That does indeed work! Thanks


let's merge these pr's?

#70
#71
anyone with write access can help me?

Sorry, they have been merged. Thank you for your contributions!


fix compilation on win32

Fix for #215
Signed-off-by: ax1oma<EMAIL_ADDRESS>

@highemhigh  Thank you Andrey! Sorry for being so late! I hope you don't mind, I made some stylish changes to your branch, combining the two commits of you into one, and extended the commit message. While I did a rebase, I did not make any code changes to your proposed fix.

looks good to me


Beautify on save adding extra character(s) to results

Description
I have been using this add on for a while. Occasionally it adds extra characters (usually closing brackets but occasionally whole words). It recently picked up. Changing from js-beautify to pretty-diff didn't stop the issues.
Expected Results
The beautified code should have looked like:
module.exports = {
    start: start
}

but produces
module.exports = {
    start: start
}
}
}

and ocassionaly stuff like this:
module.exports = {
    start: start
}
rt: start }
}

Steps to Reproduce

Add code to Atom editor
Run command Atom Beautify: Beautify Editor
This beautified code does not look right!

Debug
Here is a link to the debug.md Gist: https://gist.github.com/anonymous/ccd9cc18973fc63eee2ade737be9f631
Checklist

[x] I have tried uninstalling and reinstalling Atom Beautify to ensure it installed properly
[x] I have reloaded (or restarted) Atom to ensure it is not a caching issue
[x] Searched for existing Atom Beautify Issues at https://github.com/Glavin001/atom-beautify/issues
so I know this is not a duplicate issue
[x] Generated debugging information and added link for debug.md Gist to this issue

Would you mind generating the debug.md file?  This really helps us to reproduce the problem so that we can direct targeted guidance to all concerned parties.  https://github.com/Glavin001/atom-beautify/blob/master/docs/troubleshooting.md

https://gist.github.com/anonymous/ccd9cc18973fc63eee2ade737be9f631
here you go. Its a good one, where its more then just adding brackets. Took a bit to happen on a file that didn't have corporate info

I am looking at this and I see extra characters at the bottom of the original code sample that don't appear related to the above code:
module.exports = {
    create: create
}
e
}

}

are you asking me about the above? It does that alot..
Here is another example I just got...
module.exports = {
    upload_obj_to_db: upload_obj_to_db
}
j_to_db
}

@chevalierc When I looked at the debug.md file the original code sample already had the extra characters at the bottom.  That source sample is code that exists before the beautification operation, which means the defect is elsewhere.

module.exports = {
    upload_obj_to_db: upload_obj_to_db
}
_db: upload_obj_to_db
}
_db: upload_obj_to_db
}

I'll create a new debug next time. I'm very confident it is from this package. I only have 2 3rd party packages installed on my two machines and the odd out package is different for each machine. Ill try disabling that package as well.

I recommend creating a small snippet of code that can reproduce this issue, generating the debug.md Gist and sharing it here, and also temporarily disabling Atom-Beautify, reloading Atom, and see if that fixes it.
It likely is Atom-Beautify. If so, we need a clean debug.md Gist and then we can tackle this issue.
Although I say "we" but it will probably be @prettydiff 😜

First wanted to say I greatly appreciate your guys package. Has made writing code so much more enjoyable.
Did some debugging this morning. I was thinking maybe the NPM package nodemon was causing the issue but disabling it did not stop the symptoms.
Disabling beautify for an hour I didn't have an issues unfortunately. I usually have the issue pop up around 20 minutes to some times immediately following removing the past mistake.
I keep creating debugs and they have the extra characters in the original code.
Another piece of info, I have tried the different JS engines but they surprisingly causes identical issues. The issue has never append in HTML files.
I'll keep looking for pasterns in errors and try and capture some useful info for @prettydiff . Keeping the package regardless as it is very valuable.

First wanted to say I greatly appreciate your guys package. Has made writing code so much more enjoyable.

Awesome to hear 😄 . Thank you!

I usually have the issue pop up around 20 minutes to some times immediately following removing the past mistake.

Could you elaborate on this? Was there a typo/mistake in your previous code and when you saved Atom-Beautify executed and created the extra brace.
This could be a Beautify On Save only issue. If you enable Atom-Beautify, disable beautify_on_save for the language(s), and test around, can this be reproduced? I think it may be an issue with how beautify on save code is loading the file and passing it to beautifiers.
Even saving twice without delay in between could cause the issues shown above.
If removing Beautify On Save results this issue then I think it is something that will be addressed with Atom-Beautify v1 and when #1174 is complete. I am going to completely rewrite the Beautify On Save implementation and think more about how to prevent issues like this.

immediately following removing the past mistake.

After saving a file, it would add the extra characters. I would remove the extra character, then save, but It would again add the extra characters during the save.

If you enable Atom-Beautify, disable beautify_on_save for the language(s), and test around, can this be reproduced?

Will do. Hadn't thought of that.

Both @chevalierc and @ikeamanual are experiencing extra characters being added after beautify on save. Unfortunately, I have 3 midterms coming up and a new work project, so my time is limited and also I have not yet reproduced this so I may not be much help, yet. I am confident we have narrowed it down to beautify on save being the culprit, now we need to figure out how to fix it.
If you could both change Logger Level to verbose and when it occurs look at the Atom Developer Console and check the Atom-Beautify logs. Unfortunately we can not see what is going on using the Help Debug Editor tool so instead we will have to look for helpful information within the logs. Let me know if you find anything useful and please submit a Pull Request if you develop a solution! Thank you!

I attach the debug log here, and a screenshot. This is from duplicate issue #1236 which was closed.
To generate this log I started with correct html, an href with a " at the end.

clear console
Ctrl-S
remove the second "
Ctrl-S
The extra > appears.

Note that the extra > does not appear in the log, only on the screen. But see the screenshot...
Also note that the extra > is actually saved to disk in my html file, I see it with "cat piet.html".
-1475339288479.txt

Note that the extra > does not appear in the log, only on the screen.

If you were to Ctrl-S (save and run beautify again) does the extra > appear now (since it is shown in the TextEditor)? I expect this to be Yes, however just want to be sure. If you do not change anything and repeated beautify on save, does that create even more extra >?
I'm fairly confident there is something wrong with how the beautification results are being set for the TextEditor: https://github.com/Glavin001/atom-beautify/blob/master/src/beautify.coffee#L111-L119
Note that the beautifiers are asynchronous and Atom's TextEditor saving implementation is synchronous so there could be some racing going on. See https://github.com/Glavin001/atom-beautify/blob/master/src/beautify.coffee#L558-L572 for details.
It could also be another package making changes to the TextEditor while Atom-Beautify is off processing and then comes back and attempts to update the already changed TextEditor. If this were the case, even something as simple as highlighting/selecting the all of the text (Ctrl-A / Command-A) in the TextEditor and then saving could cause problems if beautifyEntireFileOnSave option was set to false (which it is not: https://gist.github.com/anonymous/2ce03368bcc78bad7660e11ef186282f#package-settings ) and therefore the resulting beautified text was saved using setTextInBufferRange: https://github.com/Glavin001/atom-beautify/blob/master/src/beautify.coffee#L111-L115.
Maybe https://github.com/atom/atom/issues/477 would help with this.

I attach the debug log here

Also is your Logger Level set to verbose? I only see debug logs. I expect to see even more logs than usual beautification because this is for beautify on save: https://github.com/Glavin001/atom-beautify/blob/master/src/beautify.coffee#L557-L564

This is a great start. Could you verify you are using verbose logging and try some more and longer tests and report back? Thanks!

I changed the log level from debug to verbose.
Yes, if I do another Ctrl-S right after I first see the extra > then the > is show in the log.
Here are the actions for this log:

start with clean formatted valid html
remove the last "
Ctrl-S   ( no extra > appears... code is beautified )
add the last "
Ctrl-S   ( no extra > appears, code is formatted )
remove the last "
Ctrl-S  ( extra > appears! )
Ctrl-S  ( the one extra > remains. I now als see the extra > in the log file )

-1475398398097.txt

Note that if I repeatedly do Ctrl-S, no extra > keep adding.
Also, if I add a newline between   and  and do Ctrl-S, the code is beautified ( extra newline removed ) and no extra > is added.
To get the beaitifier to add extra >>>> i first have to create some invalid html. Adding a extra newline is not invalid html.
So if I fix the html bu adding the last ", then do Ctrl-S, then create invalid html by removing the last ", then do Ctrl-S, then I get a second extra > at the end of my file.
So the bug seems to be trigged by invalid html, not just removing spacing...

@ikeamanual If you change beautifiers and attempt to repeat this experiment do you continue to get the extra characters?  Both issues used the same beautifier even if the languages are different.

If I configure Pretty Diff and do the same thing the code is actually chopped off behind the <a.
see screendump and log file.

-1475424185478.txt

Note that I cannot reproduce this on a Windows 10 laptop.

Yep, that is a reproducible limitation of Pretty Diff.  This suggests the problem could be related to the specific beautifier or its relationship to Atom Beautify.

Just stopping into say I have been using with beautify on-save for the past week and haven't had any of the relevant issues. Ill read the rest of this thread soon, to see how else I can help?

I have two classrooms of 30 that have had to disable it due to a number of issues, one of which is extra characters being added.

@dalelotts Do you know which beautifiers your students where using when the extra characters were generated?

@prettydiff All are set to the default. JS Beautify.

+1 also experiencing this intermittently using jsbeautify
In my attempt to fix this, I have now broken beautify on save for JS files, other files still beautify on save :(

I've had to disable this plugin for the same reason. I've been using with with js and at times it adds a block around 10 lines long at the end on each save!

+1. Also happening for me.

I do not fully understand why disabling the plugin is required course of action, as this issue appears only with Beautify On Save enabled -- correct me if I am wrong -- and Beautify On Save can simply be disabled -- and is disabled by default -- therefore still providing value using quick keyboard shortcuts.
Regardless, I do want to resolve this bug.
Questions for anyone able to reproduce this bug:

[ ] @ikeamanual suggested this happens from invalid code. Can each you of please provide sample code of what is breaking?
[ ] Confirm it only occurs with beautify on save. I think it is an Atom-Beautify bug not with a specific beautifier.

[ ] Does this occur when you save multiple times, possibly too quickly?

[ ] Do you have any code selected when you save?
[ ] Is it always at the end of the file the extra character(s) are added?

[ ] Is it always the last part of the file which is added?

Please provide a debug.md Gist so we know your configurations of Atom-Beautify as well. Since it appears the issue is beautify on save related, I do not expect to be able to use this debug.md to see a reproducible case, however it may still provide some insights into common configurations.
Ideally, someone who is able to reproduce this issue will debug a little and hopefully be able to submit a Pull Request solving this issue. I think the applicable code to start looking at is https://github.com/Glavin001/atom-beautify/blob/master/src/beautify.coffee#L115-L119
It could be something like selectedBufferRange is set and the beautified code is replacing only a portion of the file instead of the entire file. Or it could be a race condition as a result of Atom's on save event only allowing synchronous handlers and Atom-Beautify being asynchronous. See https://github.com/Glavin001/atom-beautify/blob/master/src/beautify.coffee#L533-L547 for more details.

I get this issue all the time with atom-beautify and it's quite annoying.

@Simon-Payne Could you provide us with your debug.md when this happens.  We need evidence of the problem in order to properly investigate and solve the defect.

I'm having this problem too.. with both html and js files. (never had it with php or anything else).
It just happens randomly and breaks my code.
Disabling beautify on save for now.

I have disabled "Beautify on save" to continue using this package.
I don't think it's a problem with any beautifier or Whitespace package. To me it adds a new line at the end and erases it many times. Until the undo stack becomes unusable.

Has this happened to anyone in the last few months?  If so, can you provide further details.

Yep, tonight I just scrambled my c code up good using beautify on save (with clang). It will be fun to sort out since I added a nig chunk since my last commit. This critical issue has been open long enough that you might assume it was fixed but someone just forgot to hit the close button. Anyhow... disabling and moving on.


Incognito suppport

Is it disabled?

@nonyy Not exactly, but yes... AWS Lambda only gives us one CPU, which means we are forced to use the --single-process argument. On the other hand, incognito mode won't work in --single-process mode.

@alixaxel can you elaborate please regarding single-process?
lambda with more than 1.5GB (or 2GB?) have access to 2 vCores
Dose it means we will be able to run it without single-process?
Why can't more than one process on a single core?
Thank you for that amazing project

@Bnaya This was the very first thing I tested when AWS announced 3GB Lambdas with multi-core support.

Why can't more than one process on a single core?

This is just the design of Chromium itself, back in the day this was a major win compared to Firefox.

Dose it means we will be able to run it without single-process?

Unfortunately no, if you try to launch without --single-process on a 3GB Lambda:
browser = await puppeteer.launch({
  args: chromium.args.filter((arg) => arg !== '--single-process'),
  defaultViewport: chromium.defaultViewport,
  executablePath: await chromium.executablePath,
  headless: chromium.headless,
});

You'll get a timeout:

Task timed out after 30.03 seconds

Looking at /proc/cpuinfo on the same Lambda:
processor: 0
vendor_id: GenuineIntel
cpu family: 6
model: 62
model name: Intel(R) Xeon(R) Processor @ 2.50GHz
stepping: 4
microcode: 0x1
cpu MHz: 2500.010
cache size: 33792 KB
physical id: 0
siblings: 2
core id: 0
cpu cores: 2
apicid: 0
initial apicid: 0
fpu: yes
fpu_exception: yes
cpuid level: 13
wp: yes
flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 cx16 pcid sse4_1 sse4_2 x2apic popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm cpuid_fault pti ibrs ibpb fsgsbase tsc_adjust smep erms mpx avx512dq smap clflushopt clwb avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves arat pku ospke arch_capabilities
bugs: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf
bogomips: 5000.02
clflush size: 64
cache_alignment: 64
address sizes: 46 bits physical, 48 bits virtual
power management:

processor: 1
vendor_id: GenuineIntel
cpu family: 6
model: 62
model name: Intel(R) Xeon(R) Processor @ 2.50GHz
stepping: 4
microcode: 0x1
cpu MHz: 2500.010
cache size: 33792 KB
physical id: 0
siblings: 2
core id: 1
cpu cores: 2
apicid: 1
initial apicid: 1
fpu: yes
fpu_exception: yes
cpuid level: 13
wp: yes
flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx rdtscp lm constant_tsc rep_good nopl xtopology nonstop_tsc cpuid tsc_known_freq pni pclmulqdq ssse3 cx16 pcid sse4_1 sse4_2 x2apic popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm cpuid_fault pti ibrs ibpb fsgsbase tsc_adjust smep erms mpx avx512dq smap clflushopt clwb avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves arat pku ospke arch_capabilities
bugs: cpu_meltdown spectre_v1 spectre_v2 spec_store_bypass l1tf
bogomips: 5000.02
clflush size: 64
cache_alignment: 64
address sizes: 46 bits physical, 48 bits virtual
power management:

We can indeed see 2 CPU cores, but it still doesn't work.

So i believe we can assume its not (only) the cores number but also something else on Lambda?
any ideas how to try and debug it?
I will play with it again when lambda node 10 support is ready :)

@Bnaya These related issues might be helpful, this one particularly: https://github.com/GoogleChrome/puppeteer/issues/2608#issuecomment-393419208

I'm following these issues for long time :)
They even say that we might loose --single-proccess, maybe without notice, because its not really maintained anymore


Full reactivity fix for #5

related to #5
My sublime text was configured to beautify on save, so sorry about some indentation changes.

This is solved in the 1.0 release, now out. Although I went in a different direction, I used this PR as inspiration, so thanks! The main difference is I wanted to keep the two-tiered approach (two publications) so that overriding the document publication is easy. This way you only ever have to deal with a simple list of IDs, and all the complexity of dealing with sort, skip, limit, counts, etc. is hidden in the other built-in publication.

@aldeed i'm glad it became useful.


The plus sign disappears when dragged file is brought  to dropzone

        Drag and drop your file here or browse

provide more information, steps to reproduce


App crash in  iOS with takephoto()🐛

What were you trying to do?
iOS app crashing if i'm using  1) enableAutoStabilization:true 2) enableAutoDistortionCorrection:true
this two options below added code for takephoto() and Camera component.
   const photo = await this.cameraRef.current.takePhoto({
      qualityPrioritization:'quality',
      enableAutoStabilization:true,
      enableAutoDistortionCorrection:true
    });

and in Camera component :
    <Camera
              style={StyleSheet.absoluteFill}
              device={Device}
              ref={this.cameraRef}
              isActive={isactive}
              photo={true}
              enableHighQualityPhotos={true}
            />

Reproduceable Code
No response
What happened instead?
The app crash with this error : AVFCapture: -[AVCapturePhotoOutput capturePhotoWithSettings:delegate:] + 752
Relevant log output
No response
Device
iPhone 13 Pro
VisionCamera Version
2.15.4
Additional information

[ ] I am using Expo
[X] I have read the Troubleshooting Guide
[X] I agree to follow this project's Code of Conduct
[X] I searched for similar issues in this repository and found none.

@mrousavy i am not sure yet if this the cause on our side too but whenever user tries to take photo app will crash and show "Signal 6 was raised (null)" on iPhone.

After pushing new update for testers in production iOS, removing enableAutoStabilization and enableAutoDistortionCorrection prevents the crash, i guess its same issue as this opened issue, any fix anyone ?

Hmm maybe you need to check if the camera device in useCameraDevices actually supports stabilization ?

Yes removing enableAutoStabilization &  enableAutoDistortionCorrection prevents the crash
In ios quality is poor in android its fine.

Yes removing enableAutoStabilization & enableAutoDistortionCorrection prevents the crash In ios quality is poor in android its fine.

yep i agree quality is bad on iOS

Yes removing enableAutoStabilization & enableAutoDistortionCorrection prevents the crash In ios quality is poor in android its fine.

yep i agree quality is bad on iOS

Any solution to improve quality?

Closing as this is a stale issue - this might have been fixed with the full rewrite in VisionCamera V3 (🥳) - if not, please create a new issue.
If your issue has been fixed, consider sponsoring me on GitHub to say thanks 💖


[bug]: Why Denoising Strength in UI when doing txt2img?

Is there an existing issue for this problem?

[X] I have searched the existing issues

Operating system
Windows
GPU vendor
Nvidia (CUDA)
GPU model
RTX 3060
GPU VRAM
12GB
Version number
5.0.0
Browser
Edge 128.0.2739.79 (Official build) (64-bit)
Python dependencies
No response
What happened
When doing regular txt2img generation (not img2img from a pre-existing image), why does the denoising strength slider show and is active in the UI? It doesn't seem to do anything in that mode (changing it has no effect), so why does it show or be active?
What you expected to happen
When doing txt2img, it seems the denoising strength slider should not show in the UI (or perhaps be deactivated or grayed out like when seed is on random), as it doesn't have any functionality in that mode, especially when sending directly to the gallery. Only when doing img2img functions on the canvas (when the bounding box overlaps a pre-existing image) does it seem like denoising strength should show up in the UI. Of course, you'd need to detect when the bounding box overlaps a pre-existing image on the canvas in order to enable this in the UI, but it seems like it would be more intuitive to only show or activate the denoising strength when it will actually affect the refining or editing of a pre-existing image. When generating from scratch (sending direct to gallery or on a blank part of the canvas), it seems that slider should not appear or be active in the UI.
How to reproduce the problem
No response
Additional context
No response
Discord username
No response

Maybe this is more of an enhancement than a bug? (Although the slider is really functionless when doing txt2img, so kind of a bug?)

We don't know if the canvas is going to do txt2img, img2img, inpaint or outpaint until the user clicks the Invoke button, so we need to show all controls, even if some might be ignored.
As you intuited, calculating the generation mode requires we check the contents of the bbox. This causes a brief UI lag/stutter. Doing this while drawing - even if debounced - introduces unacceptable stutters because the operation blocks the main thread. We might be able to improve this, but it's not a high priority item for us right now.
FWIW, this is unchanged from earlier releases.

We could consider other ways to handle it, but think it might involve moving the position/tying it to layers, which might confuse folks.


Block and throw on create election form if some election has already ongoing

Currently election committee can cerate many running election per time but in real life the election can only running only one. Add check on form and API to block if there are already running election.

Solved in #37


optionally blocking tracking code

A typical website can easily have over ten tracking code embedded, and each will need to have its own connection to server. Similar to ads blocking, if those tracking code can be blocked, it will be helpful to reduce network load and improve performance.
This feature can be controlled in uproxy preference setting. User can choose if they want to keep tracking code or not.

@iislucas I'm strongly inclined to close this, what do you think?

+1 we can leave that for other extensions.


KAFKA-3131: enable error level for SSLException logs

@ijuma @rajinisivaram  this is an attempt to enable error logs for SSL exceptions. most of the times, users misconfigure SSL and don't get any clue about underlying errors. error logs may help in those scenarios. let me know your thoughts on this.

Closing this PR in favor of KAFKA-5920 and related changes


Sync errors reported in console

No longer seeing this error in latest version of Web5 JS SDK. Closing out.


sink(cdc): fallback when preparing statements meets error

What problem does this PR solve?
Issue Number: ref #8508
What is changed and how it works?
Fallback to normal SQL executor when preparing statements meets error.
Check List
Tests

No code

Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note
None

/merge

/run-engine-integration-test


Always generate validation report

closes #427
Summary:
This PR provides support to always generate a validation result report
Expected behavior:
Validation result report should always be generated, even when the validator crashes on exception

[x] handle exceptions gracefully

[x] always generate validation result report

[x] implement DatasetTooBigNotice

notice is generated and added to the result repo as an error when zip input is too big

[x] implement OutOfMemoryNotice:

notice is generated and added to the result repo as an error when too many notices were generated OR when dataset was too big (in this case this means that the threshold for dataset size should be re-assessed).

[x] implement ValidatorCrashNotice:

notice is generated and added to the result repo as an error when an unknown exception/error is thrown by the validator.

[x] persist all validation report in CI: see https://github.com/MobilityData/gtfs-validator/actions/runs/358457765

[x] additional unit tests:

[x] notice export
[x] use cases

[x] DownloadArchiveFromNetwork
[x] HandleFatalCrash

[x] getNoticeCount
[x] getErrorNoticeCount
[x] getInfoNoticeCount
[x] getWarningNoticeCount

[x] update javadoc

In the case dataset was too big to be processed, the validation report will be named as __timestamp of validation.json

Please make sure these boxes are checked before submitting your pull request - thanks!

[x] Run the unit tests with gradle test to make sure you didn't break anything
~[ ] Format the title like "Fix #<issue_number> - " (for example - "Fix #1111 - Check for null value before using field")~
[x] Linked all relevant issues
[x] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@maximearmstrong what are your thoughts on implementing a --debug option: the goal is to enable developers to track debug exceptions from there IDE/console?


Added new folders to gitignore and added a CONTRIBUTING.md

Added a CONTRIBUTING.md with a set of guidelines someone should follow to contribute to the project.
Closes #2

Seems fine to me, did we specify which C++ version do we use somewhere?

Seems fine to me, did we specify which C++ version do we use somewhere?

I will include that the C++ version used is C++ 20, since I think some feature included in that version was pretty useful, I will include it and I think after that you can accept the review.

Added a line about C++ version.


documentation  need to improve

Need to show anyone how to use or download utilities
Add photos or a teaser for the project
System analysis and design

Thank you for your comment!
However we have the opened issue on the documentation already. I'll transfer your comment there and close the issue.


there is something wrong?

when I define 1M bytes in stack,kernel has something wrong.
like this:
void main() {
char str[1024*1024];
....
}
so I change the code in boot/switch_pm.asm
[bits 32]
init_pm: ; we are now using 32-bit instructions
....
mov ebp, 0x900000 ; <----------change 0x90000 to 0x900000
mov esp, ebp
...
then kernel run successed.
this is a bug?

The stack grows downwards, so if the stack pointer is at 0x90000 initially, its size is at most 576KB, and a 1MB array would not fit in it. Changing esp to 0x900000 increases the size of the stack to up to 9MB, which solves this problem.

The stack grows downwards, so if the stack pointer is at 0x90000 initially, its size is at most 576KB, and a 1MB array would not fit in it. Changing esp to 0x900000 increases the size of the stack to up to 9MB, which solves this problem.

yeah,you are right, I think the kernel stack size should be bigger than 1MB,so esp shoule be set 0x900000 in the boot/switch_pm.asm `file.
init_pm: ; we are now using 32-bit instructions
....
mov ebp, 0x900000 ; <----------change 0x90000 to 0x900000
mov esp, ebp
...

The stack grows downwards, so if the stack pointer is at 0x90000 initially, its size is at most 576KB, and a 1MB array would not fit in it. Changing esp to 0x900000 increases the size of the stack to up to 9MB, which solves this problem.

yeah,you are right, I think the kernel stack size should be bigger than 1MB,so esp shoule be set 0x900000 in the boot/switch_pm.asm file.

Yes that is correct. The stack can be anywhere in between those points but if you want the most space, then you should leave it there, since you don't have a memory map, you don't know what memory is safe.

since you don't have a memory map
I think that should be the next tutorial: using the BIOS to get a memory map and how to interpret it.

Yeah. In my os (https://github.com/Menotdan/DripOS) I just switched to GRUB cuz I ran out of space (increasing ah before the read did not help), and because free boot information.

Yeah, that's what you should do when you have a more serious OS, but this tutorial is meant for begginers, so I think it's fine for it to stick with regular legacy BIOS boot

Yeah, that's what you should do when you have a more serious OS, but this tutorial is meant for begginers, so I think it's fine for it to stick with regular legacy BIOS boot

The funny thing-i literally learned C from this tutorial
I did python for like 2 years before that
and then I just started an OS from this tutorial
and I learned C from this tutorial
and now im decent at it


Github action documentation refers to 'options' instead of 'args'

https://docs.astral.sh/ruff/integrations/#github-actions says:

ruff-action accepts optional configuration parameters via with:, including:

version: The Ruff version to install (default: latest).
options: The command-line arguments to pass to Ruff (default: "check").
src: The source paths to pass to Ruff (default: ".").

I think 'options' here should be 'args' to match the example code:
- uses: chartboost/ruff-action@v1
  with:
    src: "./src"
    version: 0.0.259
    args: --select B

as using options gives:
Warning: Unexpected input(s) 'options', valid inputs are ['args', 'src', 'version']

Thanks; you're right. This should be args, according to the GitHub action's documentation. Would you be interested PRing a fix for the documentation?

Thank you!