🐛 firebase-analytics-ktx - Adding Firebase Analytics dependency to fresh project causes immediate crash.

Bug report
Describe the bug
The app loads up on an android emulator for a second and immediately crashes.
Steps to reproduce
Steps to reproduce the behavior:

Create a new flutter app. Create a new firebase project and follow the prompts and add the necessary build.gradle changes.

implementation platform('com.google.firebase:firebase-bom:32.1.0')
implementation 'com.google.firebase:firebase-analytics-ktx'

I also changed the minSdkVersion minSdkVersion 19.

Run the app on an android emulator.
App self terminates.

Expected behavior
I expect it to not crash.

Additional context
Tried on Pixel 6 API 34, as well as Pixel 3a API 34/

Flutter doctor
Run flutter doctor and paste the output below:
Click To Expand
Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel stable, 3.10.4, on macOS 13.4 22F66 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 14.3.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 2022.2)
[✓] VS Code (version 1.79.1)
[✓] Connected device (4 available)
[✓] Network resources

Flutter dependencies
Run flutter pub deps -- --style=compact and paste the output below:
Click To Expand
Dart SDK 3.0.3
Flutter SDK 3.10.4
testapp 1.0.0+1

dependencies:
- cupertino_icons 1.0.5
- flutter 0.0.0 [characters collection js material_color_utilities meta vector_math sky_engine]

dev dependencies:
- flutter_lints 2.0.1 [lints]
- flutter_test 0.0.0 [flutter test_api path fake_async clock stack_trace vector_math async boolean_selector characters collection js matcher material_color_utilities meta source_span stream_channel string_scanner term_glyph]

transitive dependencies:
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- characters 1.3.0
- clock 1.1.1
- collection 1.17.1
- fake_async 1.3.1 [clock collection]
- js 0.6.7 [meta]
- lints 2.1.1
- matcher 0.12.15 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.2.0
- meta 1.9.1
- path 1.8.3
- sky_engine 0.0.99
- source_span 1.9.1 [collection path term_glyph]
- stack_trace 1.11.0 [path]
- stream_channel 2.1.1 [async]
- string_scanner 1.2.0 [source_span]
- term_glyph 1.2.1
- test_api 0.5.1 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph matcher]
- vector_math 2.1.4

@protonforest Thanks for the report.

implementation platform('com.google.firebase:firebase-bom:32.1.0')
implementation 'com.google.firebase:firebase-analytics-ktx'

These don't seem to be required / mandatory for Flutter, as I don't see in the documentation. For Android, it seems to be required. You can check the documentation for flutter and also the plugin example wherein, these are not used.
Curious to know the reason behind you are adding those in your project ?

@darshankawar It seems that you are suggesting the instructions are sharing via that link are explicit to Flutter, and that I should not use the android setup sdk instructions. I will try following those instructions instead.
What is confusing is that I was following another tutorial and they added these dependencies exactly this way when they added the firebase dependencies to their flutter project, albeit it is an older tutorial.

Thanks for the update and feedback @protonforest
If you want to create a Firebase app and integrate with Flutter, you can do so using flutterfire configure CLI tool which writes the native config files to respective platform folders so you don't need to go through Firebase console and UI to create one.
That way once you create and integrate the project, you can take a look if the parameters in question are being used or not.
You can read more about the CLI tool here if you haven't done so already: https://firebase.google.com/docs/flutter/setup?platform=ios

@darshankawar I followed the tutorial you suggested and got it working. Since I'm adding those dependencies to the Flutter pubspec.yaml file, and checking both the build.gradle files, I see the above-mentioned dependencies are not necessary. I think having the Firebase console recommend adding those dependencies to get it working with an android app only for it to break is problematic. How and maybe where should I recommend making a change ?

So I tried using the tool, and it did not update my build.gradle files. I expected to see a gradle plugin or something firebase related and I didnt. It seems my issue is the same as this one. .
I get this error when I run the flutter app on an android emulator. I'm assuming its because the necessary dependencies werent added by flutterfire.
E/FA      ( 5429): Missing google_app_id. Firebase Analytics disabled. See https://goo.gl/NAOOOI

E/FA ( 5429): Missing google_app_id. Firebase Analytics disabled. See https://goo.gl/NAOOOI

See this and underlying comments and check if they help in your case.

i had to completely remove analytics from my app to stop it from crashing on android startup.
Fatal Exception: java.lang.ExceptionInInitializerError:
       at com.google.android.gms.measurement.internal.zzik.<init>(zzik.java:34)
       at com.google.android.gms.measurement.internal.zzgd.<init>(zzgd.java:183)
       at com.google.android.gms.measurement.internal.zzgd.zzp(zzgd.java:58)
       at com.google.android.gms.measurement.internal.AppMeasurementDynamiteService.initialize(AppMeasurementDynamiteService.java:17)
       at com.google.android.gms.internal.measurement.zzcx.zza(zzcx.java:108)
       at com.google.android.gms.internal.measurement.zzdu.run(zzdu.java:12)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:923)

any updates?

This same issue is happening to me as well on different devices and only on release version

Hey @protonforest. We need more information to resolve this issue but there hasn't been an update in 7 weekdays. I'm marking the issue as stale and if there are no new updates in the next 7 days I will close it automatically.
If you have more information that will help us get to the bottom of this, just add a comment!

Can you be more specific ? What are you looking for? Theres 2 issues here. The Google Firebase portal setup crashes a new Flutter app.  Also, the suggested tool to fix the build.gradle files is broken, as suggested in the referenced link.

@protonforest
Does removing -ktx help ?

@protonforest Does removing -ktx help ?

No

a temporary solution in my case was adding -keep class com.google.** { *; } to the end of my proguard rules file.


Adds Disclaimers on Challenges for CSS ID Selector and Inline Styling

Added disclaimers on challenges requiring ID selectors and inline styling to indicate that these are not best practices.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

Closes #16874
I tried to keep the language on the disclaimer somewhat similar to that in the guide at https://github.com/freeCodeCamp/freeCodeCamp/blob/master/guide/english/css/id-selector/index.md

Makes sense to me. How's the new wording look to you?

Done -- thanks for writing that up.

@ezioda004 What do you think about @lasjorg's suggestion?

We haven't heard from @soph-iest for a couple months so I'm closing this as stale.

Apologies, I've been very busy and haven't been monitoring my GitHub very closely.
I personally prefer the former of @lasjorg 's suggestions, but I'm good with either.


运行demo.py不出结果？

楼主
运行demo.py，结果如下：
root@145f47f2e811:/data/chinese_ocr# python demo.py
2018-05-11 06:01:19.437201: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.1 instructions, but these are available on your machine and could speed up CPU computations.
2018-05-11 06:01:19.437315: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use SSE4.2 instructions, but these are available on your machine and could speed up CPU computations.
2018-05-11 06:01:19.437474: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX instructions, but these are available on your machine and could speed up CPU computations.
2018-05-11 06:01:19.437667: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use AVX2 instructions, but these are available on your machine and could speed up CPU computations.
2018-05-11 06:01:19.437881: W tensorflow/core/platform/cpu_feature_guard.cc:45] The TensorFlow library wasn't compiled to use FMA instructions, but these are available on your machine and could speed up CPU computations.
Tensor("Placeholder:0", shape=(?, ?, ?, 3), dtype=float32)
Tensor("conv5_3/conv5_3:0", shape=(?, ?, ?, 512), dtype=float32)
Tensor("rpn_conv/3x3/rpn_conv/3x3:0", shape=(?, ?, ?, 512), dtype=float32)
/usr/local/lib/python2.7/dist-packages/h5py/init.py:36: FutureWarning: Conversion of the second argument of issubdtype from float to np.floating is deprecated.
Restoring from ./ctpn/checkpoints/VGGnet_fast_rcnn_iter_50000.ckpt...
done
Using TensorFlow backend.
Killed
在相应目录没产生结果，请教怎么回事？

我能问一下吗？上述问题您是怎么解决的呢，我也遇到了同样的问题

我没用楼主提供的ctpn,我使用https://github.com/eragonruan/text-detection-ctpn这个重新编译了一下，再替换楼主的ctpn目录,就OK了

@squallzhong 我也替换了但是出现错误
Traceback (most recent call last):
File "demo.py", line 3, in
import ocr
File "/data/nextcloud/dbc2017/files/jupyter/chinese_ocr/ocr.py", line 12, in
from ctpn.text_detect import text_detect
ModuleNotFoundError: No module named 'ctpn'
这个请问怎么解决呢？


Editing a TXT file. Result in a Python view???

Describe the bug
Edit a TXT file, it will show as a python code?
which is funny
Reproduction

image is self explanetory lol
Logs
-

System Info
-

I moved the issue to this repo as it is not huggingface_hub related.
@sneedgers you would prefer no linting at all I presume ?

There is an internal issue on this at https://github.com/huggingface/moon-landing/issues/3489 (cc @gary149 @beurkinger )

There is an internal issue on this at https://github.com/huggingface/moon-landing/issues/3489 (cc @gary149 @beurkinger )

Its actually backend issue. because its an issue inside the docker!
it was working fine !

This is fixed! :fire:


Version 2.0.0 may crash on Android when a notification is received

There seems to be an incompatibility between Pushy and NativeScript since Pushy's 1.0.49 SDK which I bumped beyond for 2.0.0.
So I'll release a 2.0.1 which sticks to Pushy SDK 1.0.48 for now, because that's the highest version I tested that did not have this issue. Note that prior to 2.0.0 we used Pushy SDK 1.0.43 so it's still a decent bump........

e062a550fde35866530d9253b204890c475caac3


Set device id programmatically

Hi, couldn't see if this has already been asked - is there an xla api for setting the device id for compilation & run? I have tried setting visible devices, but I still see all available GPUs being exposed, and Jax defaults to id 0 where another Jax process is running & has already preallocated memory. I want to run multiple trials in parallel on separate GPUs.
import os
os.environ["CUDA_DEVICE_ORDER"]="PCI_BUS_ID"
os.environ["CUDA_VISIBLE_DEVICES"]="1"  # specify which GPU(s) to be used

from jax.lib import xla_bridge
print(xla_bridge.get_backend().devices())
>>[GpuDevice(id=0), GpuDevice(id=1), GpuDevice(id=2), GpuDevice(id=3)]
...
out_shape, net_params = net_init(rng, in_shape)
>>RuntimeError: CUDA operation failed: out of memory

Is there a way to do this or a different workaround?

Please see https://jax.readthedocs.io/en/latest/faq.html#controlling-data-and-computation-placement-on-devices. Does this do what you want?

Right - must have missed that. Thanks!

Hello, After reading these related issues, I have not got an effective way, can you share me how you solved your problems?

Right - must have missed that. Thanks!

Hello, After reading these related issues, I have not got an effective way, can you share me how you solved your problems?

@choltz95, could you, please, elaborate on how you solved the issue?
I tried
jax.default_device = jax.devices('gpu')[gpu_num]

and set gpu_num differently, but it did not work. I am getting:
RuntimeError: jaxlib/cusolver_kernels.cc:44: operation cusolverDnCreate(&handle) failed: cuSolver internal error

The versions I am using are:
$ pip list | grep jax
jax                        0.2.25
...
jaxlib                     0.1.73+cuda11.cudnn82
...

When I look at nvidia-smi, I see that the same Python process is running on all the devices:
+-----------------------------------------------------------------------------+
| Processes:                                                                  |
|  GPU   GI   CI        PID   Type   Process name                  GPU Memory |
|        ID   ID                                                   Usage      |
|=============================================================================|
|    0   N/A  N/A      2885      G   /usr/lib/xorg/Xorg                 28MiB |
|    0   N/A  N/A      8747      C   python                          10257MiB |
|    0   N/A  N/A     10949      G   /usr/bin/gnome-shell                8MiB |
|    1   N/A  N/A      8747      C   python                            153MiB |
|    2   N/A  N/A      8747      C   python                            153MiB |
|    3   N/A  N/A      8747      C   python                            153MiB |
+-----------------------------------------------------------------------------+

The issue is solved after I do
import os
os.environ["CUDA_DEVICE_ORDER"] = "PCI_BUS_ID"
os.environ["CUDA_VISIBLE_DEVICES"] = gpu_id

at the beginning of the script (i.e., before any jax or jax-related imports).


How will the Material Design Components change MaterializeCSS?

So, Google now has their own official Components (called MDC-Web) with CSS codes and JavaScript and all that for Material Design.
Link is here.
How is this going to affect MaterializeCSS? Will it stop developing? Or is MDC-Web something that's not entirely in the same category as what MaterializeCSS is?

Well, I prefer materialize because I found BEM Ugly and verbose

MDC-Web is a framework just like MaterializeCSS. They aren't synonymous, they both just implement the material design philosophies put forth by google. That is to say they follow these same guidelines.
However, they are both seperate frameworks. Kind of like Material Design Lite or Material UI
My guess is, nothing will change what so ever. MDC-Web is just a framework by Google that implements the guidelines I linked to above.. And I agree with @fega , it's a bit too verbose.
Materialize is quite simple.

I agree with @Native-Coder and @fega here


Update dia_umpire_se

Allow for use without dia_umpire_quant.
Add test to dia_umpire_se.xml  using smallest mzXML that would produce
any MGF output.

@bgruening   I only updated dia_umpire_se.xml   I don't think anyone is interested in the dia_umpire_quant application anymore.  Perhaps we can delete that tool, and remove the dia_umpire.ser output from dia_umpire_se.xml  along with the datatype.xml

@bgruening I only updated dia_umpire_se.xml I don't think anyone is interested in the dia_umpire_quant application anymore. Perhaps we can delete that tool, and remove the dia_umpire.ser output from dia_umpire_se.xml along with the datatype.xm

Sounds good. But maybe we move it into the deprecated folder and not remove it completely?
Thanks for working on it!

@jj-umn thanks a lot!


Issue training on ud-treebanks

Trying to train a treebank against ud-treebanks-v2.3/UD_English-EWT/en_ewt-ud-dev.conllu and I've noticed that all rows that have a head field with the value _ panic.
Any ideas on how to deal with this data within the library? 	PUNCT	.	_	4	punct	4:punct	_```

I think this is relevant, but @ work so I can't verify it's the case. If it is, I'll see if I can extend lingo to deal with gapping entries.

Since these are "empty nodes", isn't the expedient thing to simply skip word lines with an unspecified (_) head?

possibly - I believe (from what I can remember) that they're actually implied in the sentence. Not sure if giving up that fidelity is worth it.

I am so sorry for not responding. apparently this library escaped my notifications. So I wasn't notified of incoming PRs and issues.


fix store flag example typo

Was looking at the docs for the --store flag and noticed this typo.

This change is

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/c8a04ef838f99d4d2222c8ae3d257044c703e3d5/


fix menu error

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2449
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

@ffey Please clean up your commit message. Refer to our contributing guide.

sorry, It's my fault. I will change it .


feat(settings): make the settings page remember where you were

What this PR does 📖

go to the settings page, should init to Profile.
click on a different settings page.
leave the settings page
return to the settings page - should remember where you left off.

Which issue(s) this PR fixes 🔨

Resolve #

Special notes for reviewers 🗒
Additional comments 🎤

cc @sdwoodbury


No HTML generated for SVG files

[x] I tried updating to the latest version.

[x] I can't, there is an issue.

[ ] I Am on Windows
[ ] I Am on Bash on Windows
[x] I Am on Linux
[ ] I Am on OS X

Description
SVG files do not generate an <img> tag in the HTML output anymore. This is something introduced with the very latest changes (possibly here), since it used to work just fine until v3.0.3.
Steps
{% asset filename.svg %}
Output
The asset is being processed into the output folder, but no HTML is printed out.

It is, because it's "image/svg+xml" which the regexp doesn't accept.

I am currently having this issue. I am using 3.0.5.


Is the 1.2.0 release planned?

Is the 1.2.0 release planned?
The 1.1.5 release contains a requirement for the max Timex dependency version of 3.7.2, which is pretty old.

If there's a clear list of things todo, perhaps you need help to make 1.2.0 possible?

I've sat on it long enough :) I'll get one one today.

Released 1.2.0
Please give it a go and let me know how it goes

I have not run into any issues, thanks a lot for your work 🙂


db3 indexer phase 1: add indexer subscribe db3 event message

Resolve part of the work of #446
Problem / Goal
this is a initial of db3 indexer by adding a indexer service to listen/watch db3 event message and print them on console.
Changes

cmd db3 indexer to start db3 indexer
indexer support subscribe db3 network
the indexer won't affect current functionality.

Demo

PR-Codex overview
This PR adds a new IndexerImpl struct to the codebase, which subscribes to events from the db3 network and handles them.
Detailed summary

Adds IndexerImpl struct to handle db3 network events
Implements subscribe_event_message method in StoreSDK
Adds handle_event method to IndexerImpl to process events
Adds start method to IndexerImpl to start the indexer
Adds Indexer command to DB3Command enum in command.rs to run the indexer as a standalone program

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

log with mutation event status
[Indexer] start indexer ...
[Indexer] subscribe event from db3 network
listen and handle event message
[Indexer] receive mutation:Deliveried	24	0x84b0bd55e7ad979b7cb92a56f561190de8f68403		41118AE61671584EAA898B02E1FE9D44BD9C7E582DA0B0D9873D4A0B75774FB9	[]
[Indexer] receive mutation:Deliveried	24	0x84b0bd55e7ad979b7cb92a56f561190de8f68403	0xf6aa0b7330d699e89c48fc3f61179a726474e86d	EA379B85CB82133DD58B1CDD45D11E93C802A60EB170FC519FCCB91817E90428	[]
[Indexer] receive mutation:Deliveried	26	0x84b0bd55e7ad979b7cb92a56f561190de8f68403	0xf6aa0b7330d699e89c48fc3f61179a726474e86d	D22F1CF87B7EAA2CD85282581E400F7FD338F2823A1F6DD318C9EA5AB5BEB5EA	[]
[Indexer] receive mutation:Deliveried	28	0x84b0bd55e7ad979b7cb92a56f561190de8f68403	0xf6aa0b7330d699e89c48fc3f61179a726474e86d	E1D84161F87331EAD0DD6D5DF9BDC6F781F53493206C90F9691575CB8F6F6B2F	["test_books"]
[Indexer] receive mutation:Deliveried	30	0x84b0bd55e7ad979b7cb92a56f561190de8f68403	0xf6aa0b7330d699e89c48fc3f61179a726474e86d	E4AFD9B4354845E8BDED065E951AD474AB4CC2CC536C76DBE7F8E5EB4D7D0177	["test_books"]
[Indexer] receive mutation:Deliveried	31	0x84b0bd55e7ad979b7cb92a56f561190de8f68403	0xf6aa0b7330d699e89c48fc3f61179a726474e86d	8B41C34A4A425BC5BA3F94A2DB1E209A02E66B16F3A544F9CE81D6617E15C867	["test_books"]
[Indexer] receive mutation:Deliveried	33	0x84b0bd55e7ad979b7cb92a56f561190de8f68403	0xf6aa0b7330d699e89c48fc3f61179a726474e86d	3A13B0FAD8D57FB3FD71974B5FAC757415497B3335BA7C072E638600BC8C103F	["test_books"]

Codecov Report

Merging #445 (c239320) into main (0562ba7) will decrease coverage by 0.47%.
The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main     #445      +/-   ##
==========================================
- Coverage   64.98%   64.52%   -0.47%
==========================================
  Files          56       57       +1
  Lines       10734    10812      +78
==========================================
  Hits         6976     6976
- Misses       3758     3836      +78

Flag
Coverage Δ

rust
64.52% <0.00%> (-0.47%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

src/node/src/command.rs
40.06% <0.00%> (-1.62%)
:arrow_down:

src/node/src/indexer_impl.rs
0.00% <0.00%> (ø)

src/sdk/src/store_sdk.rs
76.30% <0.00%> (-0.64%)
:arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imotai new revision was publised to solve comment. future work related to Block fetch will be implemented in the next PR


Broken contact us form

Contact Us form has the following issues which are needed to be fixed  :

On clicking send, it reloads the page.
Email is not being sent.

Kindly assign me this issue to resolve

Any Updates ?

Hey @anuragverma108 , if @Ankesh2004 is not working on this issue, can you please assign this to me.

Assigned! @jinx-vi-0
Make sure to attach before & after screenshot in your PR.
Make sure to star the repo before working on it! Happy open-source contributing!

Hey @anuragverma108, just a heads up, it would be great if we could make the confirmation message for sent messages a bit more user-friendly. Instead of an alert, let's consider having a simple message displayed below the contact form. This way, it feels more integrated with the overall user experience.

Okay go ahead!

hey @anuragverma108 , I have created a pr please check it and let me know for any feedback.

can you please assign this issue to me #16

can you please assign this issue to me #16

I have already solved this issue and submitted a pr.


Update on rollout of setting Pre-warmed Instances?

According to the list of known issues of the public preview plan, with regards to setting the number of pre-warmed instances, "[t]he fix is scheduled to roll out in May."
It is now May 30th, and I'd like to inquire as to the status of this functionality.
As of now, I am currently unable to adjust the number of pre-warmed instances in any way. The slider on the UI simply doesn't exist as shown in the documentation images. Through Azure CLI, the "az functionapp config set" and "az resource update" methods of updating the number of pre-warmed instances both fail with 400 Bad Request errors. My resource's configuration currently shows: "properties.preWarmedInstanceCount=null".

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3847e16b-92ae-0202-c7e1-ca9a8474e65f
Version Independent ID: a25b6b5b-05ab-b3b2-616c-5d06eadb928d
Content: Azure Functions Premium plan (preview)
Content Source: articles/azure-functions/functions-premium-plan.md
Service: azure-functions
GitHub Login: @jeffhollan
Microsoft Alias: jehollan

Hi @sawatsky Thank you for your feedback! We will review and update as appropriate.


Update ClearBtn.js

Issue: #74
As a developer my goal is to created the clear button function and added the functionality to it that whenever user click it, it will clear all the text from the feedback box.
Acceptance Criteria:
Creat a clear button component in React.js
Estimated time of completion:
Research: 2/2 hrs
Code and Development: 3 hrs
Documentation: 1/2 hrs
Time spent on Activities:
Review and Research requirements for Clear button component using React.js:  2/2hrs
Development of Clear button component and added some of the task that should be added: 4/2hrs

Was blocking my PR, but got to approvals so I merged to development.


0.1 checklist

[ ] nested example groups
[ ] before blocks
[ ] filter examples by description ( cargo run descriptor -d 'foo' regex matches any examples that have foo in their full description path)
[ ] print failed examples with files and line numbers at end of suite run

@sgrif: anything else you think should exist here?

Worth relicensing to Apache 2/MIT dual for better interop with the rest of the Rust community


Add tf_copts to XLA libraries

Split from #14531
Required by #15213
To fix a build error in //tensorflow/compiler/xla:util
There is a name conflict in  xla_data.pb.h
enum PrimitiveType {
  PRIMITIVE_TYPE_INVALID = 0,
  PRED = 1,
  S8 = 2,
  S16 = 3,
  S32 = 4,
  S64 = 5,
  U8 = 6,
  U16 = 7,
  U32 = 8,
  U64 = 9,
  F16 = 10,
  F32 = 11,
  BF16 = 16,
  F64 = 12,
  C64 = 15,
  TUPLE = 13,
  OPAQUE = 14,
  PrimitiveType_INT_MIN_SENTINEL_DO_NOT_USE_ = ::google::protobuf::kint32min,
  PrimitiveType_INT_MAX_SENTINEL_DO_NOT_USE_ = ::google::protobuf::kint32max
};

However, OPAQUE is already defined in wingdi.h as:
#define OPAQUE              2

So, "/DNOGDI“ compiler flag  is a must for who includes this file.
@rongjiecomputer
@jhseu

Can one of the admins verify this patch?

This might be a brittle fix. If a new rule is added that forgets to add tf_copts, then it'll break again. @gunan not sure who owns this build rule. Should we do this more generally by adding a new library rule?
@snnn I'm not sure from your description why this doesn't build. The enum should be under a separate namespace. See xla_data.proto.

I am also not fond of this solution. I think us redefining the cc_library rule will  be better, if we have to add tf_copts to these rules.
That is unless @mhlopko has a better recommendation for us.

Though we can create a new macro like tf_cc_library, it doesn't mean I could change fewer lines.
As this change is huge, you may want to do it internally.

Hi @jhseu
Yes,  The enum is under a separate namespace. But, OPAQUE in Windows.h is a macro. macro comes first. It's like:
#define NOGDI 1
enum something{
  a,
  b,
  NOGDI,  //here, you will get an error, no matter which namespace the enum lives
};

Another alternative is to #undef OPAQUE where Windows.h is included. That seems preferable.

@jhseu windows.h is included in a lot of places, trying to track down all these files an #undef OPAQUE right after windows.h can be difficult. If a new file includes windows.h and forgot to undef macros again, it will break again.
windows.h is known as one of the most namespace/macro polluting header file for a reason.

Hi @jhseu,
Then you just solved one of these problems.  Please take a look at #15302
Instead of adding
#include "tensorflow/core/platform/cpu_info.h"

I could do
#if defined(PLATFORM_WINDOWS)
#include "tensorflow/core/platform/windows/cpu_info.h"
#endif

Then BYTE_ORDER  will remain undefined if PLATFORM_WINDOWS is not defined (because of lacking tf_copts)
However, we have code like
https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/framework/numeric_types.h#L55
#if __BYTE_ORDER__ == __ORDER_BIG_ENDIAN__
    value = p[0];
#else
    value = p[1];
#endif

Who includes this file will get a silent error.

The problem is even more tricky for cc_tests.
Every cc_test is binary exe on Windows, it may either link to tf framework libraries statically or dynamically.
For link statically, you should define TF_COMPILE_LIBRARY, otherwise, you must be care of not defining it.
For every cc file under tensorflow/core, we need to define TF_COMPILE_LIBRARY while compiling.
For every cc file under tensorflow/contrib, we need to undefine TF_COMPILE_LIBRARY while compiling.
To accomplish that,  we have to add tf_copts everywhere.

@melodyguan
Any suggestion?

@meteorcloudy, any suggestion?

Yeah, perhaps let's just create a tf_cc_library and add the copts there, and modify all of these to use tf_cc_library.

Got it. I will do it

Hi @jhseu
How about this #15466 ?


Adjust builder to validate that JSON in Dockerfiles are arrays of strings and nothing else to match how we describe them to people (and what all our existing tests already assumed)

This also adds more tests to help verify this, including unicode and nonprintable characters (hence the commit switching to strconv.Quote).
As a bonus, this fixes a subtle bug where [] was turned into [""] and then turned back into [] (and thus [""] was impossible to actually round-trip correctly in a Dockerfile).
In the process, I replaced the custom QuoteString function with the equivalent (but with more special cased characters) strconv.Quote in Node.Dump(), and simplified the builder TestTestData a little by using ioutil.ReadFile directly instead of os.Open followed immediately by ioutil.ReadAll.

You should probably make Node values take string only now instead of interface. Should speed the builder up.

I'm not sure what you mean?
https://github.com/docker/docker/blob/b2ab733c993ee6124c164defceac6996206d69fa/builder/parser/parser.go#L25
Aren't they already?

sorry I misread some of the above code, it's been a while since I was in here.

LGTM but maybe just a single type assertion like @icecrime suggested :)

Updated type switch to be just a type assertion instead. :+1:

lgtm

I think we are just waiting on @tiborvass

@duglin feel free to review and merge at your convenience :)

What should:  RUN [ "-e foo" ]
result in?  I get different results from the shell vs docker(this pr).
Should this PR have fixed this ambiguity?

@duglin that's a valid JSON array of strings, and there's no way for us to detect that it should be parsed by the shell as-is instead, so that becomes the literal command -e foo (which very likely won't exist in PATH)

Which is the current behavior without this PR, too:
$ docker build -
FROM busybox
RUN [ "-e foo" ]
Sending build context to Docker daemon 2.048 kB
Sending build context to Docker daemon
Step 0 : FROM busybox
 ---> 4986bf8c1536
Step 1 : RUN -e foo
 ---> Running in 439e68f47660
/bin/sh: illegal option -
INFO[0006] The command [/bin/sh -c -e foo] returned a non-zero code: 2

Although it's strange that we're getting /bin/sh there when we shouldn't be...

what was the conclusion here?

@jfrazelle that json sucks, but this PR has 2 l.g.t.m.s already :)

Nice JSON related issue: https://github.com/docker/docker/issues/10097

i dont know eriks was not all caps

IHERDAT


cancel / accept offer

Cancelling offer

Cancel offer is the same button as for unfollow, without hover effect, just the cursor pointer
Accept offer

more details cc @exezbcz

added accept offer

updated in figma:
https://www.figma.com/design/JXNtryaNYhY0XJNArzvPQx/Handoff?node-id=11027-1025&t=xJkvYJfCeC2BLVk2-11
button has no hover


Translate docs/grpc/client-py page into Korean

/area documentation
/kind content
/kind translation
What would you like to be added:
Translate docs/grpc/client-py page into Korean
Why is this needed:
No Korean doc for docs/grpc/client-py page

/assign

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/falcosecurity/community.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

@poiana: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.
Provide feedback via https://github.com/falcosecurity/community.
/close

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.


Dedicated server crash

Crash report: https://www.toptal.com/developers/hastebin/zuwamipaso.rb

Another instance of server not starting up after updating dungeon gears
latest.log

We are aware of the issue and intend to release a fix tomorrow.

Fixed in 3.1.9-beta


Renamed metric doesn't show up

Kubernetes v1.11.3
Adapter image: directxman12/k8s-prometheus-adapter-amd64
In prometheus I have metric:
MKWEB_exec_time_seconds_max{app="springbootweb",host="MYHOST",instance="<IP_ADDRESS>:7070",job="kubernetes-pods",namespace="default",pod="springbootweb-7c5998fdd-ktnw5",pod_template_hash="371554988",region="us-east-1"}
I want to rename it in my adapter.
In my config I've added new rule:

    - seriesQuery: 'MKWEB_exec_time_seconds_max{namespace!="",pod!=""}'
      resources:
        overrides:
          kubernetes_namespace: {resource: "namespace"}
          kubernetes_pod_name: {resource: "pod"}
      name:
        matches: "^(.*)_max"
        as: "${1}_max_x1"
      metricsQuery: 'sum(rate(<<.Series>>{<<.LabelMatchers>>}[2m])) by (<<.GroupBy>>)'

Problem is that after adding this new rule I can see only original metric pods/MKWEB_exec_time_seconds_max not new one pods/MKWEB_exec_time_seconds_max_x1
Can you tell what is wrong with my configuration ?

do you still have the old rule in place?

In my config for yhis issue i have your rules and added new rule palced above.

rules must not overlap, so if one of the existing rules also matches, you're dealing with undefined behavior territory.


Add scrollbar to the recycleView

Add the Scrollbar to the recycleView

@Chromicle  I'll work on this issue.


Toast options object for time-out causes toasts to stay open, like 0

http://plnkr.co/edit/EsExTjP1IJcT6zZquXvF?p=preview
Setting the options for the time-out using the object (so you can have separate settings per class), results in the toast message staying open.  See plunker forked from your example.  The top warning message should have closed after 2 seconds.
<toaster-container toaster-options="{'close-button':false, 'time-out':{ 'toast-warning': 2000, 'toast-error': 0 } }"></toaster-container>

You are using an outdated version of the library.  If you see my fork using version 2.1.0, it works just fine: http://plnkr.co/edit/Esrdbl5S6hcmhiVmSjiF?p=preview

You might want to replace the ‘Simple demo’ plunker you use in your README.md file with one that uses the latest version to avoid this kind of confusion in the future.
Thanks for the help.
From: Stabzs<EMAIL_ADDRESS>Sent: Wednesday, February 01, 2017 6:55 PM
To: jirikavi/AngularJS-Toaster<EMAIL_ADDRESS>Cc: Bill Braun<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: Re: [jirikavi/AngularJS-Toaster] Toast options object for time-out causes toasts to stay open, like 0 (#255)
Closed #255https://github.com/jirikavi/AngularJS-Toaster/issues/255.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/jirikavi/AngularJS-Toaster/issues/255#event-945733830, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AYJzvTF0mBCwVwfTWSBEtrgOEPH7Y9iTks5rYSlLgaJpZM4L0kWk.
**************************************************************************************** This e-mail may contain information that is confidential, privileged or otherwise protected from disclosure. If you are not an intended recipient of this e-mail, do not duplicate or redistribute it by any means. Please delete it and any attachments and notify the sender that you have received it in error. Unless specifically indicated, this e-mail is not an offer to buy or sell or a solicitation to buy or sell any commodities, financial risk management products, or other physical or financial product or service, an official confirmation of any transaction, or an official statement of EDF Trading Limited, EDF Trading Markets Limited, EDF Trading North America, LLC, or any of the EDF Group family of companies. Any views or opinions presented are solely those of the author and do not necessarily represent those of the foregoing entities. EDF Trading Markets Limited is authorized and regulated by the Financial Services Authority. VAT number: GB 735 5479 07. EDF Trading Markets Limited and EDF Trading North America, LLC are members of the EDF Group of companies. EDF Trading Markets Limited maintains its registered office at 80 Victoria Street, 3rd Floor, Cardinal Place, London, SW1E 5JL. A Company registered in England No. 4255974. EDF Trading North America, LLC is headquartered in the United States at 4700 W. Sam Houston Pkwy., Suite 250, Houston, TX 77041 ***************************************************************************************

I can't edit that particular plunker since it is owned by the repo's owner, but I'll be happy to fork it over to a new plunker and update the documentation to point to the fork instead.

Doc url for the simple demo has been updated to a new, current plunker.


Explore the concept of Assets, Fungible and Non Fungible Tokens in relation to SushiChain

In order to fully support dApps it would be helpful to have the concept of Assets. In Ethereum they started with fungible tokens and last year introduced non fungible tokens which form the basis for most of the collectables type applications.
In SushiChain we don't have the same type of token as Ethereum since we don't have smart contracts and in Ethereum token are tightly related to smart contracts via several ERC implementations such as ERC20 etc

My current thinking is to have all tokens as fungible and introduce Assets as non-fungible items with an auction system. So someone can create an Asset and put it up for auction where people can bid for it and the person can accept whichever bid they like

this is superseded by Smart Assets


Cascade operator

I couldn't find this request in the issue backlog, so I'd like to request support for method and property cascades, e.g. via the .. operator, familiar from other languages like Dart.
While this is merely syntactic sugar, it's very convenient - take the following example:
function request(method: string, url: string, body?: string) : Promise<XMLHttpRequest> {
    return new Promise<XMLHttpRequest>(function (resolve, reject) {
        var xhr = new XMLHttpRequest()

        xhr.open(method, url)

        xhr.onload = function () {
            if (this.status >= 200 && this.status < 300) {
                resolve(xhr)
            } else {
                reject(xhr)
            }
        }

        xhr.onerror = function () {
            reject(new Error(`unable to complete ${method} request for: ${url}`))
        }

        xhr.send(body)
    })
}

We can discard the intermediary variable and references to it, so the above becomes:
function request(method: string, url: string, body?: string) : Promise<XMLHttpRequest> {
    return new Promise<XMLHttpRequest>(function (resolve, reject) {
        new XMLHttpRequest()
            ..open(method, url)
            ..onload = function () {
                if (this.status >= 200 && this.status < 300) {
                    resolve(xhr)
                } else {
                    reject(xhr)
                }
            }
            ..onerror = function () {
                reject(new Error(`unable to complete ${method} request for: ${url}`))
            }
            ..send(body)
    })
}

Dart having a very similar syntax, I believe this feature can basically be referenced 1:1 from Dart?

Duplicate of #8536


Nuget Package Creation - v1.9.17

Nuget package creation - v1.9.17.
Gmail API dependency update ('<IP_ADDRESS>17' -> '<IP_ADDRESS>31').

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (849d03f) 99.48% compared to head (d17020f) 99.48%.
Report is 65 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #66   +/-   ##
=======================================
  Coverage   99.48%   99.48%
=======================================
  Files           1        1
  Lines         781      781
  Branches      183      183
=======================================
  Hits          777      777
  Misses          2        2
  Partials        2        2

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Consumer API: Reject identity deletion process

Readiness checklist

[X] I added/updated unit tests.
[ ] I added/updated integration tests.
[X] I ensured that the PR title is good enough for the changelog.
[X] I labeled the PR.

Description
Implemented the rejection of an identity deletion process (started by a support employee) during its approval period.

Summary by CodeRabbit

New Features

Introduced a new feature for rejecting deletion processes of identities, enhancing control over identity management.

Bug Fixes

Not applicable.

Documentation

Not applicable.

Refactor

Not applicable.

Style

Not applicable.

Tests

Added tests for the new feature of rejecting deletion processes, ensuring robustness and reliability.

Chores

Implemented database migrations to support new rejection process properties.

Revert

Not applicable.

@coderabbitai review

In response to this comment - I updated the code like so:
    // Arrange
    SystemTime.Set(DateTime.Parse("2020-01-01"));
    var identity = CreateIdentityWithDeletionProcessWaitingForApproval();
    identity.Devices.Add(new Device(identity));
    var deviceId = identity.Devices[0].Id;

I need to set the current time because I am making such an assertion audit log:
    auditLogEntry.CreatedAt.Should().Be(SystemTime.UtcNow);

In response to this comment - I updated the code like so:
    // Arrange
    SystemTime.Set(DateTime.Parse("2020-01-01"));
    var identity = CreateIdentityWithDeletionProcessWaitingForApproval();
    identity.Devices.Add(new Device(identity));
    var deviceId = identity.Devices[0].Id;

I need to set the current time because I am making such an assertion audit log:
    auditLogEntry.CreatedAt.Should().Be(SystemTime.UtcNow);

Okay 👍


chore: add missing peer dep testing-library/dom

Avoid warning during yarn install:
warning " ><EMAIL_ADDRESS>has unmet peer dependency "<EMAIL_ADDRESS>

Thank you! :+1:


Adjust installation instructions to load conf.py settings

@willingc I'm not sure if this is the right way to upstream conf.py settings, but it was the first solution that came to mind.  The end projects would import all of the variables from the jupyter-sphinx-theme, see the adjusted readme.md in this PR.

pycrypto is throwing an error on building for me. I think its a fabric dependency. In general, we should use pip install cryptography for any crypto stuff (better maintained).
I'm going to merge this as is. We can iterate if needed. Thanks @jdfreder


Move all ES5 style classes into ES6+ style class

Targeting release 5.0.0 we should complete the ES6+ migration by transforming all ES5-style classes into ES6+ style class constructs.
This currently applies to the following classes:

[ ] AbstractGrantType #227
[ ] BearerTokenType #227
[ ] MacTokenType #227
[ ] AuthenticateHandler  #227
[ ] AuthorizeHandler  #227
[ ] TokenHandler  #227
[x] TokenModel #223
[ ] CodeResponseType #225
[ ] TokenResponseType #225
[ ] Request #225
[ ] Response #225
[ ] OAuth2Server #227

@jankapunkt In your issue you said that these PR's should be targeted for the 5.0.0 release.
I'm a bit confused because #223 was merged in development.
Is the development branch for future 4.x releases and if so how are we keeping release-5.0.0 and development in sync?

@jorenvandeweyer sorry my mistake, development is correct as we will merge development and 5.0.0 anyway


⚠ ClamAV has degraded performance

In 39a1edb, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 217 ms

Resolved: ClamAV performance has improved in b6ffab9.


allow broadcasting empty message

👍  cc @mafintosh

bump

Thanks for the reminder! 4.8.0

@jwerle you wanna help maintain this?

@mafintosh no problem! yeah definitely!


Added newer Variant types to typed_array.h

Fixes #87991
This intentionally omits Object for reasons mentioned in the discussion of the original issue.

If it's ok, you could leave a comment mentioning the omission intentionally

If it's ok, you could leave a comment mentioning the omission intentionally with reasoning.

Good idea, I'll make that change.

If the PR is a draft it cannot be considered ready for review, but the PR looks pretty "ready" to me. Are you sure this is still work in progress?

If the PR is a draft it cannot be considered ready for review, but the PR looks pretty "ready" to me. Are you sure this is still work in progress?

Yes, sorry, just needed to head home for the day yesterday — wanted to actually build it and test it after adding the INFO lines before taking it out of draft. (I put it back into draft when I realized I forgot to update these INFO lines). I plan to have this back in review in about 4 or 5 hours when I’m back in the office and can build again :)

No worries! There's no rush, of course. I just wanted to make sure this was not a mistake.

Thanks for the feedback! I'll make a note next time I leave something hanging -- I expect that it's not entirely unheard of for a PR to be left in a mergable state.
I don't think I've a good job testing the MAKE_TYPED_ARRAY_INFO lines, but they at least build fine. I'll move this back out of draft.

Thanks!


influxdb integration (for testing)

Instead of using .csv for storing values, we will be using a time-series database (InfluxDB) for its better storage efficiency and enhanced ability to do data processing and analysis. However, do note that this is just a test script to test out polling ADS values to a influxdb.
An added bonus is that we can use grafana to generate sick dashboard for better monitoring:

But the main purpose of this is so that we can set a proper monitoring system to collect data from washers/dryers hopefully in the coming weeks, and subsequently use data recorded in influxdb as testing data for our software to detect when a washer/dryer is in or not in operation.

Running the script
In order to prevent poll_to_influx.py from "clogging" up the terminal, it would be best to run it in the background:
python3 poll_to_influx.py &

Take note of the PID that will be displayed, so that you can kill it


Checking python ipv6 support

If Python is built without ipv6 support, pyghmi still can detect ipv6, then socket.bind will fail with "bad family" error.

Thank you for contributing to openstack/pyghmi!
openstack/pyghmi uses Gerrit for code review.
If you have never contributed to OpenStack before make sure you have read the
getting started documentation:
http://docs.openstack.org/infra/manual/developers.html#getting-started
Otherwise please visit
http://docs.openstack.org/infra/manual/developers.html#development-workflow
and follow the instructions there to upload your change to Gerrit.


Add donate button somewhere

Please add donate button into readme.

I have added a link to my “buy me a coffee” account in the README file :)


Analytics for debugger errors

Description
Analytics events for debugger errors.

An event when error gets added
An event when an error gets resolved.

Additional data includes

Plugin name(for actions)
Widget type(for widgets)
Property path(with plugin name or widget type prefixed)
Errors

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Manually
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Test coverage results :test_tube:
:red_circle: Total coverage has decreased
// Code coverage diff between base branch:release and head branch: feat/debugger-errors-analytics

Status
File
% Stmts
% Branch
% Funcs
% Lines

:red_circle:
total
53.91 (-0.03)
35.85 (-0.19)
32.55 (0.01)
54.5 (-0.03)

:red_circle:
app/client/src/actions/debuggerActions.ts
77.27 (-1.68)
100 (0)
28.57 (-4.76)
88.89 (-11.11)

:red_circle:
app/client/src/sagas/DebuggerSagas.ts
22.22 (-1.25)
4.76 (-5.58)
33.33 (-4.17)
23.68 (-1.59)

:green_circle:
app/client/src/sagas/EvaluationsSaga.ts
17.87 (0.54)
1.1 (-0.2)
3.7 (0)
20.79 (0.56)

:green_circle:
app/client/src/selectors/debuggerSelectors.tsx
100 (33.33)
100 (0)
100 (100)
100 (0)

/ok-to-test sha=ef36fec


APEXMALHAR-2183 - Documentation for CsvFormatter Operator

APEXMALHAR-2183 Added documentation for CsvFormatter Operator

@venkateshkottapalli Please take care of 2 new comments. Rest all looks fine to me. Once you take care of the comments, please rebase. If there are no further comments, will merge the PR in a day


Parallel check is missing issues

With our production code base, running with parallel processes on the same config misses issues:
$ phan -j 1 | wc -l ; phan -j 4 | wc -l
       9
       0

This seems likely to be a very complex issue.  What can we do that would be helpful to troubleshoot it?

https://github.com/etsy/phan/wiki/Different-Issue-Sets-On-Different-Numbers-of-CPUs#what-to-do-about-it describes this issue and mentions several workarounds

This limitation of PHP and Phan is a big bummer, and there isn't much I can say to make it better.

Also, the setting consistent_hashing_file_order (to true) (See src/Phan/Config.php) may help a bit in making the issue sets predictable


Multi-message support for join/leave messages and custom commands

The intended use case is to diversify the messages to avoid fatigue. It's more fun if it's mixed up a little. ;-)
Please note that there is no UI to let the user know they have exceeded the message limits. The limit is meant to be generous so I opted for simplicity.

Ah very nice, I'm gonna go through it more in depth and possibly merge it in the weekend.

Looks good, nice work, i do wanna add to this later to do more than just random responses though!


[image_picker] Improve image_picker for iOS to handle more image types

Changes iOS image picker (iOS 14+) to use NSItemProvider's method loadDataRepresentationForTypeIdentifier:completionHandler: instead of loadObjectOfClass:completionHandler:.
The loadObjectOfClass method is unable to convert some image types directly into a UIImage. For example, WebP and ProRaw images return an error of Could not coerce an item to class UIImage. However, loadDataRepresentationForTypeIdentifier is able to load all image types that conform to UTTypeImage (UTTypeHEIC, UTTypeHEIF, UTTypeLivePhoto, UTTypeICO, UTTypeICNS, UTTypePNG, UTTypeGIF, UTTypeJPEG, UTTypeWebP, UTTypeTIFF, UTTypeBMP, UTTypeSVG, UTTypeRAWImage) into NSData, which can then be converted into a UIImage.
Fixes https://github.com/flutter/flutter/issues/92100.
Fixes https://github.com/flutter/flutter/issues/95885.
Pre-launch Checklist

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
[x] I signed the CLA.
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I listed at least one issue that this PR fixes in the description above.
[x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
[x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
[x] I updated/added relevant documentation (doc comments with ///).
[x] I added new tests to check the change I am making, or this PR is test-exempt.
[x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

This is much needed, thank you much @vashworth

Needs formatting:
patch -p1 <<DONE
diff --git a/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m b/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m
index 7cc50791a..16c205012 100644
--- a/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m
+++ b/packages/image_picker/image_picker_ios/ios/Classes/FLTPHPickerSaveImageToPathOperation.m
@@ -102,7 +102,8 @@ typedef void (^GetSavedPath)(NSString *);
                                     UIImage *image = [[UIImage alloc] initWithData:data];
                                     [self processImage:image];
                                   } else {
-                                    os_log_error(OS_LOG_DEFAULT, "Could not process image: %@", error);
+                                    os_log_error(OS_LOG_DEFAULT, "Could not process image: %@",
+                                                 error);
                                   }
                                 }];
     }

DONE

I just tested vashworth:image_picker_images_not_loading branch and it doesn't seems to be working properly.
I have couple of RAW files in my real iPhone13 Pro device and  it does not complete the future and throws error next time when I'm about tho pick file.(which was the ultimate problem with this package)
I just simply ran image_picker/plugins/packages/image_picker/image_picker_ios/example/main.dart file
here is logs I get

[claims]  grantAccessClaim reply is an error: Error Domain=NSCocoaErrorDomain Code=4097 "Couldn’t communicate with a helper application." UserInfo={NSUnderlyingError=0x283995c50 {Error Domain=NSCocoaErrorDomain Code=4097 "connection from pid 9395 on anonymousListener or serviceListener" UserInfo={NSDebugDescription=connection from pid 9395 on anonymousListener or serviceListener}}}
Could not process image: Error Domain=NSItemProviderErrorDomain Code=-1000 "Cannot load representation of type com.adobe.raw-image" UserInfo={NSLocalizedDescription=Cannot load representation of type com.adobe.raw-image, NSUnderlyingError=0x283995fe0 {Error Domain=NSCocoaErrorDomain Code=4097 "Couldn’t communicate with a helper application." UserInfo={NSUnderlyingError=0x283995c50 {Error Domain=NSCocoaErrorDomain Code=4097 "connection from pid 9395 on anonymousListener or serviceListener" UserInfo={NSDebugDescription=connection from pid 9395 on anonymousListener or serviceListener}}}}}

Also strangely it does work on some of RAW the file but for some RAW files it does.
FYI: I've ran on iOS 16.1.3 iPhone 13 Pro

I have couple of RAW files in my real iPhone13 Pro device and it does not complete the future and throws error("Cancelled by a second request") next time when I'm about tho pick file.(which was the ultimate problem with this package)

The canceled by a second request issue is tracked with https://github.com/flutter/flutter/issues/82602, which I'm working on now. However the underlying problem is that it can't load the image:

Could not process image: Error Domain=NSItemProviderErrorDomain Code=-1000 "Cannot load representation of type com.adobe.raw-image" UserInfo={NSLocalizedDescription=Cannot load representation of type com.adobe.raw-image, NSUnderlyingError=0x283995fe0 {Error Domain=NSCocoaErrorDomain Code=4097 "Couldn’t communicate with a helper application."

There are other Apple dev threads complaining about the same: https://developer.apple.com/forums/thread/672379 and https://developer.apple.com/forums/thread/661834.
I wonder if trying again works, or if it perma-fails for a given image once it's decided it can't be accessed.

Talked with @vashworth about this one, we decided to merge even with the inconsistent selection of the RAW files since this change is still better than what we had before--it's supporting a lot more image formats.  Plus there are reports of this happening on Apple developer forums which makes me think the Cannot load representation of type is an iOS bug.  Asked @vashworth to file a new issue for that to see if we can come up with a workaround.

As @jmagman mentioned we decided to merge this. I was able to reproduce the issue @LabN36 had, and created a new issue for it with my findings: https://github.com/flutter/flutter/issues/117240


Accessory distance issue

I am running poppunk on a large set of sequences that essentially lack any accessory gene content.  I can complete the first step fo generating the DB, but when trying to run an initial model fit, I get numerous warnings: Accessory outlier at a= ..., and a final output that "Distances failed quality control (change QC options to run anyway).  Can you suggest what such QC options changes should be made?  I have tried adding --ignore-length and --core-only with the same end results. Thanks for the software and any assistance.
Best regards,
Stephen Beres

Hi Stephen - what version of the software are you using? The most recent versions have a --qc-filter continue flag to prevent runs halting at the database creation stage; the --max-a-dist 1.0 will prevent such filtering at the distance estimation stage. Hopefully those will help!

Hello Nicholas,
I hope you are doing well and staying safe – I got my first dose of Covid19 vaccine about an hour ago.  I had some difficulty in getting popunk to install using the “conda install” process.  On one linux/ubuntu 18.04 workstation conda only wanted to install an early version 1 variant.  I ended up putting poppunk on a second ubuntu 18.04 workstation where conda accepted version 2.0.2 for install.  Initially after install I was getting an error message indicating a problem with biopython and Bio.Alphabet but that was because I needed a newer version of python3.  After updating python to 3.8.6, poppunk then ran without throwing error messages.  I have not yet mastered the process of setting up different environments to isolate different version of perl and python from each other to illuminate running/package/library conflicts.
SBB
From: nickjcroucher<EMAIL_ADDRESS>Reply-To: johnlees/PopPUNK<EMAIL_ADDRESS>Date: Thursday, December 17, 2020 at 09:55
To: johnlees/PopPUNK<EMAIL_ADDRESS>Cc: Work<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [johnlees/PopPUNK] John and Nicholas (#135)
Hi Stephen - what version of the software are you using? The most recent versions have a --qc-filter continue flag to prevent runs halting at the database creation stage; the --max-a-dist 1.0 will prevent such filtering at the distance estimation stage. Hopefully those will help!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/johnlees/PopPUNK/issues/135*issuecomment-747528066__;Iw!!Jm49CwcP98D83js1EA!rRV_7xaC5JGX0aRO1pUOlIVOF93EvqYdTEvF7mG5mTOEekLLqyZRWwFnopWa6_0lPOThgQ$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMAJPUI7HLGQMXXWADHEN4LSVISXXANCNFSM4U7VY4RQ__;!!Jm49CwcP98D83js1EA!rRV_7xaC5JGX0aRO1pUOlIVOF93EvqYdTEvF7mG5mTOEekLLqyZRWwFnopWa6_2A6hkDmw$.
Houston Methodist. Leading Medicine. Houston Methodist is ranked by U.S. News & World Report as the No. 1 hospital in Texas for patient care and safety and one of the top 20 hospitals in the nation. In addition, we are nationally ranked in 11 specialties, the most in the state, and have been national leaders throughout the COVID-19 pandemic in research, offering innovative treatments and surpassing CDC safety standards. For more than 100 years, Houston Methodist has provided the best — and safest — clinical care, advanced technology and patient experience. That is our promise of leading medicine.
houstonmethodist.org
twitter.com/MethodistHosp
facebook.com/HoustonMethodist CONFIDENTIALITY NOTICE This e-mail is the property of Houston Methodist and/or its relevant affiliates and may contain restricted and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender and delete all copies of the message. Thank you.

Congratulations on getting the vaccine so quickly! The conda version should be 2.2.0 at the moment, though we are hopeful of upgrading this in the next couple of days.

If you cannot get 2.2.0, please make sure all your input is alphabetically sorted. See:
https://poppunk.readthedocs.io/en/latest/troubleshooting.html#when-i-look-at-my-clusters-on-a-tree-they-make-no-sense
Ideally you should upgrade to the most recent version, but I appreciate conda can be a pain to get right. My advice would be:

Make a totally clean conda install
Never install anything in the base environment
Make a new environment with conda create -n poppunk_env poppunk>=2.2.0 and then use it with conda activate poppunk_env

Also make sure the channel order is correct (conda-forge -> bioconda -> defaults) and see the advice here if there are problems: https://conda-forge.org/docs/user/tipsandtricks.html#using-multiple-channels>

Nick,
Early access to the vaccine comes as a consequence of working in a large medical center.  The Musser lab has sequenced over 20,000 SarCov2 patient isolates as part of the ongoing epidemiology and evolution analysis of the virus, with no end of the patient isolate sequencing likely in the near future.  I will try building poppunk from source to see if I can get the latest version installed.  And also try the hints that John just sent.  Plan to attend the upcoming Lancefield 2021 meeting and hope to see you there and get a chance to buy you your libation of choice.
Sincerely,
SBB

Stephen B. Beres Ph.D.
Professor of Pathology and Genomic Medicine,
Institute for Academic Medicine
Director of Microbial Informatics,
Center for Molecular and Translational Human Infectious Disease Research
Houston Methodist Research Institute
6670 Bertner Ave.
Houston, TX 77030
MS RIB R6-111
(713) 441-5067
<EMAIL_ADDRESS>From: nickjcroucher<EMAIL_ADDRESS>Reply-To: johnlees/PopPUNK<EMAIL_ADDRESS>Date: Thursday, December 17, 2020 at 10:38
To: johnlees/PopPUNK<EMAIL_ADDRESS>Cc: Work<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [johnlees/PopPUNK] Accessory distance issue (#135)
Congratulations on getting the vaccine so quickly! The conda version should be 2.2.0 at the moment, though we are hopeful of upgrading this in the next couple of days.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/johnlees/PopPUNK/issues/135*issuecomment-747555371__;Iw!!Jm49CwcP98D83js1EA!uUZ_JHkaemkidVt5WcWsHi5R59hoYJNCyfSQ6e1uQvgdQm7BzNbw7tT8wRbu-V2cFjWC8w$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMAJPUI5V2XSUWA4NENLBF3SVIXUFANCNFSM4U7VY4RQ__;!!Jm49CwcP98D83js1EA!uUZ_JHkaemkidVt5WcWsHi5R59hoYJNCyfSQ6e1uQvgdQm7BzNbw7tT8wRbu-V1eyjDkqw$.
Houston Methodist. Leading Medicine. Houston Methodist is ranked by U.S. News & World Report as the No. 1 hospital in Texas for patient care and safety and one of the top 20 hospitals in the nation. In addition, we are nationally ranked in 11 specialties, the most in the state, and have been national leaders throughout the COVID-19 pandemic in research, offering innovative treatments and surpassing CDC safety standards. For more than 100 years, Houston Methodist has provided the best — and safest — clinical care, advanced technology and patient experience. That is our promise of leading medicine.
houstonmethodist.org
twitter.com/MethodistHosp
facebook.com/HoustonMethodist CONFIDENTIALITY NOTICE This e-mail is the property of Houston Methodist and/or its relevant affiliates and may contain restricted and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender and delete all copies of the message. Thank you.

John,
Pursuant to my initial request for assistance with getting poppunk installed:
I am running poppunk on a large set of sequences that essentially lack any accessory gene content. I can complete the first step of generating the DB, but when trying to run an initial model fit, I get numerous warnings: Accessory outlier at a= ..., and a final output that "Distances failed quality control (change QC options to run anyway). Can you suggest what such QC options changes should be made? I have tried adding --ignore-length and --core-only with the same end results. Thanks for the software and any assistance.
I have gotten the latest version of poppunk 2.2.0 installed and have run it a couple of times on a large set of 27,000 sequences using different values of K:
➜  27065x442708_fna-files poppunk --fit-model --distances 27065x442708/27065x442708.dists --output 27065x442708 --full-db --ref-db 27065x442708 --K 2 --threads 54
Graph-tools OpenMP parallelisation enabled: with 54 threads
PopPUNK (POPulation Partitioning Using Nucleotide Kmers)
(with backend: sketchlib v1.5.3
sketchlib: /home/bioinfo-4/anaconda3/lib/python3.8/site-packages/pp_sketchlib.cpython-38-x86_64-linux-gnu.so)
Mode: Fitting model to reference database
Fit summary:
Avg. entropy of assignment          0.0003
Number of components used      2
Scaled component means:
[0.8505769  0.60737495]
[0.03222048 0.01719254]
Network summary:
Components       294
Density 0.1041
Transitivity          0.9998
Score     0.8957
Done
➜  27065x442708_fna-files poppunk --fit-model --distances 27065x442708/27065x442708.dists --output 27065x442708 --full-db --ref-db 27065x442708 --K 3 --threads 54
Graph-tools OpenMP parallelisation enabled: with 54 threads
PopPUNK (POPulation Partitioning Using Nucleotide Kmers)
(with backend: sketchlib v1.5.3
sketchlib: /home/bioinfo-4/anaconda3/lib/python3.8/site-packages/pp_sketchlib.cpython-38-x86_64-linux-gnu.so)
Mode: Fitting model to reference database
Fit summary:
Avg. entropy of assignment          0.0001
Number of components used      3
Scaled component means:
[0.86022602 0.60916511]
[0.02274602 0.00908855]
[0.35283459 0.28778643]
Network summary:
Components       1065
Density 0.0893
Transitivity          0.9834
Score     0.8956
Done
The model fit values seem to be pretty good, but the number of components determined using K= 2 is closer to my expectations.  I would now like to try running poppunk clustering at different fixed threshold distances, but I get the following error messages:
➜  27065x442708_fna-files poppunk --threshold 0.05 --distances 27065x442708/27065x442708.dists --output 27065x442708 --full-db --ref-db 27065x442708 --threads 54
Graph-tools OpenMP parallelisation enabled: with 54 threads
PopPUNK (POPulation Partitioning Using Nucleotide Kmers)
(with backend: sketchlib v1.5.3
sketchlib: /home/bioinfo-4/anaconda3/lib/python3.8/site-packages/pp_sketchlib.cpython-38-x86_64-linux-gnu.so)
Mode: Applying a core distance threshold
Traceback (most recent call last):
File "/home/bioinfo-4/anaconda3/bin/poppunk", line 10, in
sys.exit(main())
File "/home/bioinfo-4/anaconda3/lib/python3.8/site-packages/PopPUNK/main.py", line 476, in main
assignments = new_model.apply_threshold(distMat, args.threshold)
File "/home/bioinfo-4/anaconda3/lib/python3.8/site-packages/PopPUNK/models.py", line 653, in apply_threshold
y = self.assign(X)
File "/home/bioinfo-4/anaconda3/lib/python3.8/site-packages/PopPUNK/models.py", line 749, in assign
y = pp_sketchlib.assignThreshold(X/self.scale, 0, self.core_boundary, 0, cpus)
TypeError: assignThreshold(): incompatible function arguments. The following argument types are supported:
1. (distMat: numpy.ndarray[numpy.float32[m, n], flags.writeable, flags.c_contiguous], slope: int, x_max: float, y_max: float, num_threads: int = 1) -> numpy.ndarray[numpy.float32[m, 1]]
Invoked with: array([[2.50596058e-04, 1.74374913e-03],
[1.93757660e-04, 1.56915467e-03],
[2.35754022e-04, 1.51339627e-03],
...,
[1.06428655e-04, 4.23902558e-04],
[8.54968166e-05, 1.78980772e-04],
[8.96912243e-05, 1.83410230e-04]]), 0, 0.05, 0, 1
I have checked all of the listed poppunk dependencies and all are in place and exceed the minimum versions.  As the error messages seem to indicate an incompatibility with numpy, I have installed numpy 1.19.4.
I appreciate any assistance or addit5ional guidance you can provide.
Happy Holidays,
SBB
From: John Lees<EMAIL_ADDRESS>Reply-To: johnlees/PopPUNK<EMAIL_ADDRESS>Date: Thursday, December 17, 2020 at 10:46
To: johnlees/PopPUNK<EMAIL_ADDRESS>Cc: Work<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [johnlees/PopPUNK] Accessory distance issue (#135)
Also make sure the channel order is correct (conda-forge -> bioconda -> defaults) and see the advice here if there are problems: https://conda-forge.org/docs/user/tipsandtricks.html#using-multiple-channels>https://urldefense.com/v3/__https:/conda-forge.org/docs/user/tipsandtricks.html*using-multiple-channels*3E__;IyU!!Jm49CwcP98D83js1EA!oIxHn4NtkCqp5AfSvsQ53JU28_MDqRf7RlVlN4_YxYLCRk5Gh7SGiZoKfQxTI4T-TYtr9w$
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/johnlees/PopPUNK/issues/135*issuecomment-747560149__;Iw!!Jm49CwcP98D83js1EA!oIxHn4NtkCqp5AfSvsQ53JU28_MDqRf7RlVlN4_YxYLCRk5Gh7SGiZoKfQxTI4QJ3gNSYg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMAJPUKENRVK34KXBVC5ZHTSVIYUZANCNFSM4U7VY4RQ__;!!Jm49CwcP98D83js1EA!oIxHn4NtkCqp5AfSvsQ53JU28_MDqRf7RlVlN4_YxYLCRk5Gh7SGiZoKfQxTI4Tw1gMjSg$.
Houston Methodist. Leading Medicine. Houston Methodist is ranked by U.S. News & World Report as the No. 1 hospital in Texas for patient care and safety and one of the top 20 hospitals in the nation. In addition, we are nationally ranked in 11 specialties, the most in the state, and have been national leaders throughout the COVID-19 pandemic in research, offering innovative treatments and surpassing CDC safety standards. For more than 100 years, Houston Methodist has provided the best — and safest — clinical care, advanced technology and patient experience. That is our promise of leading medicine.
houstonmethodist.org
twitter.com/MethodistHosp
facebook.com/HoustonMethodist CONFIDENTIALITY NOTICE This e-mail is the property of Houston Methodist and/or its relevant affiliates and may contain restricted and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender and delete all copies of the message. Thank you.

Hi Stephen,
A quick look suggests that --max-a-dist 1 may solve your first issue, though be sure to take a look at your distanceDistribution.png and other output plots as well as the command line output.
The second issue may be a bug at our end, it was previously reported here too: https://github.com/johnlees/PopPUNK/issues/106
I will have to take a look at this in more detail after we reopen in January. Will update you when I've had more of a chance to check

I have just released a new version of PopPUNK. Could you try updating by running conda install poppunk==2.3.0 pp-sketchlib==1.6.0 in your conda environment?
The --threshold command works on my tests in PopPUNK 2.3.0 w/ pp-sketchlib 1.6.0. Its format has changed slightly, so in your case would be:
poppunk --fit-model threshold --threshold 0.05 --distances 27065x442708/27065x442708.dists --output 27065x442708 --full-db --ref-db 27065x442708 --threads 54

(see https://poppunk.readthedocs.io/en/latest/model_fitting.html#threshold)
If that still doesn't work, perhaps you could share your .h5 file with me so I can see if I can replicate your issue?

I have just released a new version of PopPUNK. Could you try updating by running conda install poppunk==2.3.0 pp-sketchlib==1.6.0 in your conda environment?
The --threshold command works on my tests in PopPUNK 2.3.0 w/ pp-sketchlib 1.6.0. Its format has changed slightly, so in your case would be:
poppunk --fit-model threshold --threshold 0.05 --distances 27065x442708/27065x442708.dists --output 27065x442708 --full-db --ref-db 27065x442708 --threads 54

(see https://poppunk.readthedocs.io/en/latest/model_fitting.html#threshold)
If that still doesn't work, perhaps you could share your .h5 file with me so I can see if I can replicate your issue?

John,
Happy New Year and Brexit to you.  Thanks for the update, it may take me a few days.  Both of my big linux workstations are busy running a RAxML alignment and a Mauve alignment and have been doing so for the last 3 days.  I do not know how long it will be until they finish, but when/if they do, I will give it a shot.
Best,
SBB
From: John Lees<EMAIL_ADDRESS>Reply-To: johnlees/PopPUNK<EMAIL_ADDRESS>Date: Tuesday, January 5, 2021 at 06:50
To: johnlees/PopPUNK<EMAIL_ADDRESS>Cc: Work<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [johnlees/PopPUNK] Accessory distance issue (#135)
I have just released a new version of PopPUNK. Could you try updating by running conda install poppunk==2.3.0 pp-sketchlib==1.6.0 in your conda environment?
The --threshold command works on my tests in PopPUNK 2.3.0 w/ pp-sketchlib 1.6.0. Its format has changed slightly, so in your case would be:
poppunk --fit-model threshold --threshold 0.05 --distances 27065x442708/27065x442708.dists --output 27065x442708 --full-db --ref-db 27065x442708 --threads 54
(see https://poppunk.readthedocs.io/en/latest/model_fitting.html#thresholdhttps://urldefense.com/v3/__https:/poppunk.readthedocs.io/en/latest/model_fitting.html*threshold__;Iw!!Jm49CwcP98D83js1EA!tnF3HvpB7XoqHoEgy465U7fJ6w41i9CuMDWr8VrC0l1SSdfqTQGunZ_kxT5V6yk3_IUUWQ$)
If that still doesn't work, perhaps you could share your .h5 file with me so I can see if I can replicate your issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/johnlees/PopPUNK/issues/135*issuecomment-754615938__;Iw!!Jm49CwcP98D83js1EA!tnF3HvpB7XoqHoEgy465U7fJ6w41i9CuMDWr8VrC0l1SSdfqTQGunZ_kxT5V6ykMzLDrcg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMAJPUOW26WZRQDQRR2P3MTSYMDJDANCNFSM4U7VY4RQ__;!!Jm49CwcP98D83js1EA!tnF3HvpB7XoqHoEgy465U7fJ6w41i9CuMDWr8VrC0l1SSdfqTQGunZ_kxT5V6ykW_qJAkQ$.
Houston Methodist. Leading Medicine. Houston Methodist is ranked by U.S. News & World Report as the No. 1 hospital in Texas for patient care and safety and one of the top 20 hospitals in the nation. In addition, we are nationally ranked in 11 specialties, the most in the state, and have been national leaders throughout the COVID-19 pandemic in research, offering innovative treatments and surpassing CDC safety standards. For more than 100 years, Houston Methodist has provided the best — and safest — clinical care, advanced technology and patient experience. That is our promise of leading medicine.
houstonmethodist.org
twitter.com/MethodistHosp
facebook.com/HoustonMethodist CONFIDENTIALITY NOTICE This e-mail is the property of Houston Methodist and/or its relevant affiliates and may contain restricted and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender and delete all copies of the message. Thank you.

John,
Happy New Year and Brexit to you.  Thanks for the update, it may take me a few days.  Both of my big linux workstations are busy running a RAxML alignment and a Mauve alignment and have been doing so for the last 3 days.  I do not know how long it will be until they finish, but when/if they do, I will give it a shot.
Best,
SBB
From: John Lees<EMAIL_ADDRESS>Reply-To: johnlees/PopPUNK<EMAIL_ADDRESS>Date: Tuesday, January 5, 2021 at 06:50
To: johnlees/PopPUNK<EMAIL_ADDRESS>Cc: Work<EMAIL_ADDRESS>Author<EMAIL_ADDRESS>Subject: [EXTERNAL] Re: [johnlees/PopPUNK] Accessory distance issue (#135)
I have just released a new version of PopPUNK. Could you try updating by running conda install poppunk==2.3.0 pp-sketchlib==1.6.0 in your conda environment?
The --threshold command works on my tests in PopPUNK 2.3.0 w/ pp-sketchlib 1.6.0. Its format has changed slightly, so in your case would be:
poppunk --fit-model threshold --threshold 0.05 --distances 27065x442708/27065x442708.dists --output 27065x442708 --full-db --ref-db 27065x442708 --threads 54
(see https://poppunk.readthedocs.io/en/latest/model_fitting.html#thresholdhttps://urldefense.com/v3/__https:/poppunk.readthedocs.io/en/latest/model_fitting.html*threshold__;Iw!!Jm49CwcP98D83js1EA!tnF3HvpB7XoqHoEgy465U7fJ6w41i9CuMDWr8VrC0l1SSdfqTQGunZ_kxT5V6yk3_IUUWQ$)
If that still doesn't work, perhaps you could share your .h5 file with me so I can see if I can replicate your issue?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://urldefense.com/v3/__https:/github.com/johnlees/PopPUNK/issues/135*issuecomment-754615938__;Iw!!Jm49CwcP98D83js1EA!tnF3HvpB7XoqHoEgy465U7fJ6w41i9CuMDWr8VrC0l1SSdfqTQGunZ_kxT5V6ykMzLDrcg$, or unsubscribehttps://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/AMAJPUOW26WZRQDQRR2P3MTSYMDJDANCNFSM4U7VY4RQ__;!!Jm49CwcP98D83js1EA!tnF3HvpB7XoqHoEgy465U7fJ6w41i9CuMDWr8VrC0l1SSdfqTQGunZ_kxT5V6ykW_qJAkQ$.
Houston Methodist. Leading Medicine. Houston Methodist is ranked by U.S. News & World Report as the No. 1 hospital in Texas for patient care and safety and one of the top 20 hospitals in the nation. In addition, we are nationally ranked in 11 specialties, the most in the state, and have been national leaders throughout the COVID-19 pandemic in research, offering innovative treatments and surpassing CDC safety standards. For more than 100 years, Houston Methodist has provided the best — and safest — clinical care, advanced technology and patient experience. That is our promise of leading medicine.
houstonmethodist.org
twitter.com/MethodistHosp
facebook.com/HoustonMethodist CONFIDENTIALITY NOTICE This e-mail is the property of Houston Methodist and/or its relevant affiliates and may contain restricted and privileged material for the sole use of the intended recipient(s). Any review, use, distribution or disclosure by others is strictly prohibited. If you are not the intended recipient (or authorized to receive for the recipient), please contact the sender and delete all copies of the message. Thank you.

Hi there,
just wanted to add to this discussion: I had to resort to using --max-a-dist 1 on my own data because of the little conservation of genome between some strains. however this led me to get a warning that there was a division by zero attempted, which I assume happened because some strains had indeed a distances equal to zero:
/lustre/scratch118/infgen/team216/fl4/miniconda3/envs/poppunk230/lib/python3.8/site-packages/PopPUNK/sketchlib.py:732: RuntimeWarning: divide by zero encountered in log
  args=(klist, np.log(pairwise)),
Fitting k-mer curve failed: Residuals are not finite in the initial point.
With mash input [0.0079,0.0007,0.0005,0.0003,0.0002,0.    ]
Check for low quality input genomes

I found that a good workaround was to use --max-a-dist 0.99, which led to filter out quite a few genome pairs in the fitting run, but worked.
Florent


Integrate or link GraphQL API documentation into main documentation

This is getting superseded by the new admin API: #3057


[Incomplete!] iOS implementation

This is just an uncleaned preview to check with you guys if that solution would work for y'all.
I ended-up rewriting the camera preview rendering into a proper GLKView/GLKViewController so we can access the video frames and apply CIFilter.
It seems to be super fast and I believe that this'll be a great basis for more involved video stuff. However, the plugin logic still needs a lot of cleanup before it's mergeable..

Ok, in the process of cleaning up the code, I realized that it was prolly better to start from scratch. All the image capture logic doesn't have to be bound to a view.
I've created a CameraSessionManager class to handle all session operations. It is there that capturing full image should take place. For preview image, GLKView has a nice snapshot method that will do the trick.
Likewise, hide/show plugin logic can be pushed down to the GTKView.
The current PR has the basic functionalities that I need for my app. I can finish wiring up the remaining plugin functionalities if you guys are cool with this rewrite.

That would be really great! I was looking for way to rewrite the code for take the preview snapshot without the view workaround. That's the case for Android as well, which has the same approach.

Sweet. I'm almost done with implementing the plugin features. I'm confused about one tho: does takePicture have to save to disk or is it just intended to pass back to the registered callback?

I was thinking in two options for it.
First write the picture to disk and pass back the paths, like it's already implemented.
Second, because the picture could be very large to pass the bytes to the callback, would be create to insert a resize feature:
takePicture({picWidth: 200, picHeight: 200}, ResultType.BYTES)
takePicture({picWidth: 200, picHeight: 200}, ResultType.PATHS)
And then the registered listener would receive the parameters based on the ResultType
What do you think?

Hi toots, please tell me in what part are you working on. So I can help code what's missing.

I'm almost done I'll push the final changes tonight.
On Jan 22, 2015 1:43 PM, "Marcel Barbosa Pinto"<EMAIL_ADDRESS>wrote:

Hi toots, please tell me in what part are you working on. So I can help
code what's missing.
—
Reply to this email directly or view it on GitHub
https://github.com/mbppower/CordovaCameraPreview/pull/9#issuecomment-71014889
.

Actually I just did.. This fully functional and doesn't seem to crash. I'm not sure what to do with orientation so I've let that for you to decide. Otherwise, I think it is ready for review/merge.

That's awesome, I'll test. Thanks.

This is done. I've got some performance issues when running the preview on iPhone 4 though. I need to find a way to render all the transforms using the GPU through a texture 2d. Thanks for your work toots!


Replace rowsToMatrix with rowsToMatrixIter

This is safer for handling empty partitions.
cc @ericmjonas @Vaishaal

Note: I tried to replace all uses of rowsToMatrix in src/main. The only uses I haven't been able to replace are ones which operate locally (i.e. after sample or collect is called). A full list is pasted below
nodes/learning/GaussianMixtureModelEstimator.scala:    val X = MatrixUtils.rowsToMatrix(samples)
nodes/learning/Gradient.scala:      val dataMatrix = MatrixUtils.rowsToMatrix(data)
nodes/learning/Gradient.scala:      val labelsMatrix = MatrixUtils.rowsToMatrix(labels)
nodes/learning/KMeansPlusPlus.scala:    val X = MatrixUtils.rowsToMatrix(data.collect())
nodes/learning/LinearDiscriminantAnalysis.scala:    val featuresByClass = dataAndLabels.groupBy(_._1).values.map(x => MatrixUtils.rowsToMatrix(x.map(_._2)))
nodes/learning/LinearDiscriminantAnalysis.scala:    val features = MatrixUtils.rowsToMatrix(dataAndLabels.map(_._2))
pipelines/images/cifar/RandomPatchCifar.scala:        val baseFilterMat = Stats.normalizeRows(MatrixUtils.rowsToMatrix(baseFilters), 10.0)

@shivaram There are some merge conflicts here, likely from the cosine random features PR I just merged. Do you mind fixing these? Otherwise this LGTM

Did the merge and fixed it up.

Alright, LGTM, merging this.

Thanks @shivaram !!


lib: remove deprecation warning for nixpkgsVersion

Motivation for this change
Why was this renamed? I have similar concerns as https://github.com/NixOS/nixpkgs/pull/44107 about this. Either way lib.version doesn't even exist in 18.03 yet, it shouldn't be deprecated yet.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Fits CONTRIBUTING.md.

if the majority of maintainers is against this then it's fine and we can revert this. As stated in the commit message this was a suggestion by reviewers of the original PR (which I personally agreed on).
But for the future, please notify the folks whose commits are about to get reverted, I openend a PR myself and it would be great if we could avoid duplicated work in such cases :)

This isn't relevant anymore.


[DOCS] Add support for @idempotent tag parsing to docs-gen

:page_facing_up: Documentation Request
What were you doing?
I was documenting @daffodil/category.
Expected behavior
I'd like to introduce a special jsdoc tag that allows for idempotence metadata to be added to a function.
Existing Documentation
None, but this tag should likely be handled in daff.io as well.

After review, I don't think this is useful.


Using self instead of that

Foo.method = function() {
var that = this;
function test() {
// Use that instead of this here
}
test();
}
The word "that" is the opposite of "this" - when referring to itself, "self" seems to be clearer. Seems like "that" would refer to some other object. For example, if I was working on a car, if I said "this" car you would know I was talking about the one I was working on, but if I said that car it would be some other car that I was not working on.

Agreed, PR will be accepted.
On Sat, Feb 7, 2015 at 3:53 PM, Chris Anderson<EMAIL_ADDRESS>wrote:

Foo.method = function() {
var that = this;
function test() {
// Use that instead of this here
}
test();
}
The word "that" is the opposite of "this" - when referring to itself,
"self" seems to be clearer. Seems like "that" would refer to some other
object. For example, if I was working on a car, if I said "this" car you
would know I was talking about the one I was working on, but if I said that
car it would be some other car that I was not working on.
—
Reply to this email directly or view it on GitHub
https://github.com/BonsaiDen/JavaScript-Garden/issues/269.

"self" has more explicit meaning than "that" and is used in other languages such as python. But use of "that" is a common convention in javascript, that was introduced in 'JavaScript The Good Part'.
I think that use of "that" has some good reasons and is a convention, so it's not good to use "self" instead of "that".

I think the issue is that 'this' and 'that' are used to refer to two different things in English language. While 'this' and 'self' have roughly the same intent in an OO context.
It's not really a big deal though, once you understand the concept, it's just a word. We could clarify the convention of using self and that when we first use it in Javascript Garden.

I agree that it's not a big deal and it's just a convention.
this and self are roughly the same meaning as you mentioned. But IMHO, that has more meaning than self. that is naturally understood as the alternative of this and reminds "in this scope, this is not the same this of outer scope, so another variable name is used here instead of this."
So I prefer that to self. But again, I agree that it's just a convention.

@peterjwest please listen to @fediev this and that definitely make much more sense in context of scopes

I think self is more widely adopted in JS.

I'm going to close this issue. We've already previously accepted a PR to standardise on self rather than that, there are arguments for both sides, and it's not a big issue so we're going to stick with self.

An argument that wasn't made previously here is that in browsers, self is already an alias for window; then again, it is very rare to use it for this purpose, and in the pattern you're using it in, the global self is merely shadowed rather than overwritten.

Interesting, good to know!


feat(gax): generate error_details.proto

Used our code generator to generate 99% of this change.
It would be nice to eventually create some new templates to automate this. I had to rename the file and fix some of the crate type refs -- 5-10 LoC.


just a normal query

May I ask if write_verilog produces verilog code from the RTLIL representation? If so, how do I input the RTLIL representation for a specific design?
I looked in the manual and tried to get the verilog code for a simple verilog input code :
module top
  (
   input CLK,
   input RST,
   input enable,
   input [31:0] value,
   output [7:0] led
  );
  reg [31:0] count;
  reg [7:0] state;
  assign led = count[23:16];
  always @(posedge CLK) begin
    if(RST) begin
      count <= 0;
      state <= 0;
    end else begin
      if(state == 0) begin
        if(enable) state <= 1;
      end else if(state == 1) begin
        state <= 2;
      end else if(state == 2) begin
        count <= count + value;
        state <= 0;
      end
    end
  end

But the output is jargon; I don't understand anything. Please help.

May I ask if write_verilog produces verilog code from the RTLIL representation?

Yes it does.

If so, how do I input the RTLIL representation for a specific design?

What?

But the output is jargon; I don't understand anything. Please help.

You don't quote the output. You don't say what commands you are running. All you say is that you do some undisclosed thing with this design and that you do not understand the output.
 What exactly is your expectation? That someone will magically read your mind? How do you expect anyone to help you if you do not even provide sufficient information to reproduce whatever you are seeing, nor say what it is that you are seeing?

I thought I might try this myself.  You can see the results and the script I used here.
Looking over the output file, I find that it does indeed appear to use the set of elements given.  It's not "jargon"--I think the original poster didn't understand the meaning of that word.  I think the OP was expecting something else, perhaps something he might turn into his instructor rather than what it is--the computer output of synthesized verilog code.  As computer output, it shows how the yosys program assigned various logic stages to the "hardware" elements it was given and required to create logic from.  This is what I would expect of the output.  I see nothing unexpected there.
I do think it's rather strange that the OP would use an 8-bit state variable to record 3 states.  Looks like yosys caught that and trimmed it down nicely as well.
I'm going to recommend closing this issue.

I would ask the OP to open a discussion on IRC

By the way, it's also possible to do that on stackoverflow.

IMO that was unnecessarily aggressive.

Have a nice day everyone!

Please accept my apology everyone; I actually do understand it was my fault I wanted help without providing you guys the pertinent information you needed.
#1.         I saw ZipCPU changed the alignment and some names of the source code like :
module top
(
input CLK,
input RST,
input enable,
input [31:0] value,
output [7:0] led
);
into
module top(input wire i_clk, input wire i_reset, input wire i_enable,
input wire [31:0] i_value, output wire [7:0] o_led);
So basically adding i as a prefix for inputs and o for outputs; are these necessary? If so which section of the manual covers this if I may ask?
#2.  I get this output if I don't give the synth command in between, that is :
read_verilog code.v
write_verilog code.v
(* src = "new.v:1" )
module top(i_clk, i_reset, i_enable, i_value, o_led);
( src = "new.v:9" )
reg [31:0] 0;
( src = "new.v:9" )
reg [7:0] 1;
( src = "new.v:24" )
wire [31:0] 2;
( src = "new.v:16" )
wire 3;
( src = "new.v:20" )
wire 4;
( src = "new.v:22" )
wire 5;
( src = "new.v:4" )
reg [31:0] count;
( src = "new.v:1" )
input i_clk;
( src = "new.v:1" )
input i_enable;
( src = "new.v:1" )
input i_reset;
( src = "new.v:2" )
input [31:0] i_value;
( src = "new.v:2" )
output [7:0] o_led;
( src = "new.v:5" )
reg [7:0] state;
assign 2 = count + ( src = "new.v:24" ) i_value;
assign 3 = state == ( src = "new.v:16" ) 32'd0;
assign 4 = state == ( src = "new.v:20" ) 32'd1;
assign 5 = state == ( src = "new.v:22" ) 32'd2;
always @ begin
0 = count;
1 = state;
casez (i_reset)
1'h1:
begin
0 = 32'd0;
1 = 8'h00;
end
default:
casez (3)
1'h1:
casez (i_enable)
1'h1:
1 = 8'h01;
default:
/* empty /;
endcase
default:
casez (4)
1'h1:
1 = 8'h02;
default:
casez (5)
1'h1:
begin
0 = 2;
1 = 8'h00;
end
default:
/ empty */;
endcase
endcase
endcase
endcase
end
always @(posedge i_clk) begin
count <= 0;
state <= 1;
end
assign o_led = count[23:16];
endmodule
May I ask if yosys is trying to get back to the source code here? And if so is it intended to go there with the given set of commands or write_verilog is only written for post-synthesis?
Apologies again.

The differences in identifier names is my own personal preference.  I made the change because it helped me understand more about what your code was doing.  Such prefixes are not required.
I think what you are misunderstanding is that yosys is not attempting to return the original source code.  Instead, yosys has transformed your original source code by mapping your code onto particular hardware elements that exist in the system it has been synthesized for.  The verilog that is returned is a module that only uses those source code elements.  For example, had you synthesized for an iCE40, the design would now reference each iCE40 element and its configuration.  No, it isn't all that legible.  If you wanted legible, you'd stick with what you started with.  Instead, the names and logic reflect the internal synthesis structures--identifiers are generated internally and designed for computer understanding, not human understanding.  If you want the original source file, relax, you've still got it.

May I ask if I have the option of changing the particular hardware element Yosys maps/synthesizes my code for?

Sure!  But expect a different output file if you do so.  The Verilog output is very dependent upon which hardware type you choose.
Dan

Two more questions if I may :
So write_verilog transfers the intermediate RTLIL information of a source code to synthesizing according to the platform intended.
But suppose I wanted to see the RTLIL step for the code, capture it and edit some of it and then synthesize it, would it be possible with this tool?
I suppose I can see the RTLIL of any code with the dump_ast1 or dump_ast2 but can I make any changes to them before the synthesize step?
Also, which AST format: ast1 or ast2 or ILANG is the most strongest i.e. doesn't lose any information?
Thanks for all the answers, everyone. Much obliged.

Anybody, please ?

This is the wrong forum for such questions.  This is the forum for reporting if you find something broken with yosys.  See above for other some other forums where you might ask your question: the #yosys channel on IRC (be prepared to wait 24hrs or more for your answer), stackoverflow, or reddit (answers sometimes take a week or so).

@ZipCPU
Hi ZipCPU,
Could you tell me how to synthesize a source code for different platforms? In the manual, it's mentioned we can convert source code into different netlists according to different FPGAs like Xilinx, Gowing, etc.
Is there any specific flag for that? Please help.


Add the initial working page for Socials

Add the initial draft for the socials page (#27) inspired by ICLR's page.
Currently, the schedule is directly hard-coded in the socials.yml file, need to update once the format of input data is finalized.

Corresponding PR for sitedata_acl2020: https://github.com/acl-org/acl-2020-virtual-conference-sitedata/pull/16

Thank you both!