docs: pwa support

Description

Add partital PWA support (only service worker caching) for the docs website.
It's not necessary to add full PWA support for a docs website, I think.
In addition, you may need to provide bitmap icons (like icon_256x256.png...) for this application.
Linked Issues
closes #110
Additional context

There's a problem on https://unplugin-vue-macros-f0fwu9z6n-sxzz.vercel.app/macros/define-render. And then refresh the page.

There's a problem on https://unplugin-vue-macros-f0fwu9z6n-sxzz.vercel.app/macros/define-render. And then refresh the page.

Ok, Fixed.


statistics needs to show more information

I get a memory resource error after some time and I try to understand what's happening with statistcs/0. But it seems that not all memory areas are listed. As an artificial example, consider
ulrich@TU-Wien:~/vv$ /opt/gupu/new-trealla/tpl -f
Trealla Prolog (c) Infradig 2020-2023, v2.20.27
?- G_0 = findall(I,(statistics,between(1,1000000,I);G_0),_),G_0.
Goals 3, Matches 0, Max frames 0, choices 2, trails 0, slots 0, heap: 97.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 2000005, Matches 0, Max frames 0, choices 3, trails 0, slots 0, heap: 169.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 4000007, Matches 0, Max frames 0, choices 4, trails 0, slots 0, heap: 241.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 6000009, Matches 0, Max frames 0, choices 5, trails 0, slots 0, heap: 313.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 8000011, Matches 0, Max frames 0, choices 6, trails 0, slots 0, heap: 385.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 10000013, Matches 0, Max frames 0, choices 7, trails 0, slots 0, heap: 457.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 12000015, Matches 0, Max frames 0, choices 8, trails 0, slots 0, heap: 529.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 14000017, Matches 0, Max frames 0, choices 9, trails 0, slots 0, heap: 601.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 16000019, Matches 0, Max frames 0, choices 10, trails 0, slots 0, heap: 673.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 18000021, Matches 0, Max frames 0, choices 11, trails 0, slots 0, heap: 745.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 20000023, Matches 0, Max frames 0, choices 12, trails 0, slots 0, heap: 817.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 22000025, Matches 0, Max frames 0, choices 13, trails 0, slots 0, heap: 889.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 24000027, Matches 0, Max frames 0, choices 14, trails 0, slots 0, heap: 961.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 26000029, Matches 0, Max frames 0, choices 15, trails 0, slots 0, heap: 1033.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 28000031, Matches 0, Max frames 0, choices 16, trails 0, slots 0, heap: 1105.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
tpl: src/bags.c:42: fn_iso_findall_3: Assertion `q->st.qnbr < MAX_QUEUES' failed.
Aborted (core dumped)
ulrich@TU-Wien:~/vv$ ulimit -v
50000

So there is no hint whatsoever that space is allocated for the solutions found by findall/3. Also the heap is much too small.
And below, where is the space for this extremely long list of solutions?

ulrich@TU-Wien:~/vv$ ulimit -v
50000
Trealla Prolog (c) Infradig 2020-2023, v2.20.27
?- findall(I,(statistics,between(1,1000000,I);statistics),L),statistics.
Goals 2, Matches 0, Max frames 0, choices 1, trails 0, slots 0, heap: 32.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 2000003, Matches 0, Max frames 0, choices 2, trails 0, slots 0, heap: 32.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0 unexpected
Segmentation fault (core dumped)

How is it possible that the second statistics is called, this means that all 1000000 solutions must have found a place somewhere. Or do you do some very clever compression?

Solutions are stored independently of normal Prolog memory, in a queue
area.
On Wed, 28 June 2023, 23:04 UWN, @.***> wrote:

I get a memory resource error after some time and I try to understand
what's happening with statistcs/0. But it seems that not all memory areas
are listed. As an artificial example, consider
@.:~/vv$ /opt/gupu/new-trealla/tpl -f
Trealla Prolog (c) Infradig 2020-2023, v2.20.27
?- G_0 = findall(I,(statistics,between(1,1000000,I);G_0),_),G_0.
Goals 3, Matches 0, Max frames 0, choices 2, trails 0, slots 0, heap: 97.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 2000005, Matches 0, Max frames 0, choices 3, trails 0, slots 0, heap: 169.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 4000007, Matches 0, Max frames 0, choices 4, trails 0, slots 0, heap: 241.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 6000009, Matches 0, Max frames 0, choices 5, trails 0, slots 0, heap: 313.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 8000011, Matches 0, Max frames 0, choices 6, trails 0, slots 0, heap: 385.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 10000013, Matches 0, Max frames 0, choices 7, trails 0, slots 0, heap: 457.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 12000015, Matches 0, Max frames 0, choices 8, trails 0, slots 0, heap: 529.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 14000017, Matches 0, Max frames 0, choices 9, trails 0, slots 0, heap: 601.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 16000019, Matches 0, Max frames 0, choices 10, trails 0, slots 0, heap: 673.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 18000021, Matches 0, Max frames 0, choices 11, trails 0, slots 0, heap: 745.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 20000023, Matches 0, Max frames 0, choices 12, trails 0, slots 0, heap: 817.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 22000025, Matches 0, Max frames 0, choices 13, trails 0, slots 0, heap: 889.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 24000027, Matches 0, Max frames 0, choices 14, trails 0, slots 0, heap: 961.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 26000029, Matches 0, Max frames 0, choices 15, trails 0, slots 0, heap: 1033.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
Goals 28000031, Matches 0, Max frames 0, choices 16, trails 0, slots 0, heap: 1105.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0
tpl: src/bags.c:42: fn_iso_findall_3: Assertion `q->st.qnbr < MAX_QUEUES' failed.
Aborted (core dumped)
@.:~/vv$ ulimit -v
50000
So there is no hint whatsoever that space is allocated for the solutions
found by findall/3. Also the heap is much too small.
And below, where is the space for this extremely long list of solutions?
@.*:~/vv$ ulimit -v
50000
Trealla Prolog (c) Infradig 2020-2023, v2.20.27
?- findall(I,(statistics,between(1,1000000,I);statistics),L),statistics.
Goals 2, Matches 0, Max frames 0, choices 1, trails 0, slots 0, heap: 32.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0Goals 2000003, Matches 0, Max frames 0, choices 2, trails 0, slots 0, heap: 32.
Backtracks 0, TCOs:0, Recovered frames: 0, slots: 0 unexpected
Segmentation fault (core dumped)
How is it possible that the second statistics is called, this means that
all 1000000 solutions must have found a place somewhere. Or do you do
some very clever compression?
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/223, or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSERMWK2ZFWDQVHY4MDDXNQTV5ANCNFSM6AAAAAAZXDHFG4
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Just to make clear that I am still after it. The last statistics before tpl goes berserk looks harmless, but granularity is 10000 test cases.
Goals<PHONE_NUMBER>8, Matches<PHONE_NUMBER>3, Max frames 175103796, choices 87551855, trails 201584593, slots 963070724, heap: 8589.
Backtracks<PHONE_NUMBER>, TCOs:0, Recovered frames: 0, slots: 0, Queue: 0

Where does the space go?
Goals<PHONE_NUMBER>8, Matches<PHONE_NUMBER>, Max frames 90247104, choices 45123500, trails 113391334, slots 496358868, heap: 2539.
Backtracks<PHONE_NUMBER>, TCOs:0, Recovered frames: 0, slots: 0, Queue: 0

g1:~> ps -u | grep tpl
ulrich    667453 95.9 30.2 47670532 39851176 pts/24 S+ 04:55  93:00 /opt/gupu/new-trealla/tpl
ulrich    669074  0.1  0.0  28060 15796 pts/26   T    06:24   0:00 /opt/gupu/new-trealla/tpl
ulrich    670578  0.0  0.0   6476  2264 pts/26   S+   06:32   0:00 grep tpl

So this is a process running for more than an hour compared to a newly started (and stopped one). So there is something using up space that is not shown in the statistics.

The newly started says:
Goals 1096718, Matches 662921, Max frames 153, choices 39, trails 0, slots 671, heap: 1130.
Backtracks 214250, TCOs:0, Recovered frames: 0, slots: 0, Queue: 0

The last moments of its death, taking ps u -PID every second:
...
ulrich    667453 92.3 58.5 86255608 77215600 pts/24 D+ 04:55 109:59 /opt/gupu/new-trealla/tpl
ulrich    667453 92.3 58.5 86255608 77216580 pts/24 D+ 04:55 110:00 /opt/gupu/new-trealla/tpl
ulrich    667453 92.2  0.0      0     0 pts/24   R+   04:55 110:03 [tpl]
ulrich    667453 92.2  0.0      0     0 pts/24   R+   04:55 110:04 [tpl]
ulrich    667453 92.2  0.0      0     0 pts/24   R+   04:55 110:05 [tpl]
ulrich    667453 92.3  0.0      0     0 pts/24   R+   04:55 110:06 [tpl]

What means choices and trails? (I thought it meant, choicepoints created, but it probably means choicepoints currently active..) so there may be a leak out there. Idem trails: Sounds like trails performed, but probably means tcurrent rail entries on the trail stack.

Yes, it's currently active.
On Sat, Jul 1, 2023 at 7:45 PM UWN @.***> wrote:

What means choices and trails? (I thought it meant, choicepoints created,
but it probably means choicepoints currently active..) so there may be a
leak out there. Idem trails: Sounds like trails performed, but probably
means tcurrent rail entries on the trail stack.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/223#issuecomment-1615800595,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEWFPKUK2PVXTF47XJTXN7WTRANCNFSM6AAAAAAZXDHFG4
.
You are receiving this because you commented.Message ID:
@.***>

Retract that: frames, choices, trails & slots are high-water marks. Heap is
current heap cells. I need to update stats to show both high-water &
active. Although come to think of it maybe high-water is not that
interesting.
On Sat, Jul 1, 2023 at 7:45 PM UWN @.***> wrote:

What means choices and trails? (I thought it meant, choicepoints created,
but it probably means choicepoints currently active..) so there may be a
leak out there. Idem trails: Sounds like trails performed, but probably
means tcurrent rail entries on the trail stack.
—
Reply to this email directly, view it on GitHub
https://github.com/trealla-prolog/trealla/issues/223#issuecomment-1615800595,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AFNKSEWFPKUK2PVXTF47XJTXN7WTRANCNFSM6AAAAAAZXDHFG4
.
You are receiving this because you commented.Message ID:
@.***>


enable custom theme support

enable custom theme support from out side so that it is easy to custom the progress bar style

Also we use this progress bar into our app, while the requirement is that no dim background when the progress bar is circling, so I update the codes to enable the out-side theme so that it can support more cases.


The simplest problems spotted.

I'll go look for others eventually

oh hey it autoupdates with my changes

Alright, looks good. Thanks for getting these in.


Fix uppercase in GUI validator

Hello @shopline.
Thank you for your contribution.
Your PR merged into our dev repository.
It will be available in master as soon as possible.


⚠ ClamAV has degraded performance

In 7ff6acf, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 448 ms

Resolved: ClamAV performance has improved in 09691df after 5 minutes.


Enable long-term statistics in home assistant

Modify the MQTT discovery sections of the devices to capture long-term statistics in HA.
This will allow the entities to capture usage data over time within HA.

Curious to which sensors you are thinking of?
Assume you mean adding "stat_cla": "measurement", to some sensors?
I am testing this already by adding "stat_cla": "measurement", to some sensors, such as the Smart Plug+
{
    "mdl": "Smart Plug+",
    "mdlpn": "MIHO005",
    "parameters": [
       {
          "id": "switch",
          "component": "switch",
          "stat_t": "~@/state",
          "cmd_t": "~@/command",
          "config": {
             "dev_cla": "outlet",
             "icon": "mdi:power-socket-uk",
             "opt": false
          }
       },
       {
          "id": "REAL_POWER",
          "component": "sensor",
          "stat_t": "~@/state",
          "config": {
             "stat_cla": "measurement",
             "dev_cla": "power",
             "unit_of_meas": "W"
          }
       },
       {
          "id": "REACTIVE_POWER",
          "component": "sensor",
          "stat_t": "~@/state",
          "config": {
             "stat_cla": "measurement",
             "dev_cla": "reactive_power",
             "unit_of_meas": "var"
          }
       },
       {
          "id": "FREQUENCY",
          "component": "sensor",
          "stat_t": "~@/state",
          "config": {
             "stat_cla": "measurement",
             "val_tpl": "{{ value|round(2) }}",
             "dev_cla": "frequency",
             "unit_of_meas": "Hz",
             "en": "false"
          }
       },
       {
          "id": "VOLTAGE",
          "component": "sensor",
          "stat_t": "~@/state",
          "config": {
             "stat_cla": "measurement",
             "dev_cla": "voltage",
             "unit_of_meas": "V",
             "en": "false"
          }
       }
    ]
 }

I have been trying it with eTRV temperatures, by creating a separate sensor for the Room Temperature
       {
         "id": "Room_Temperature",
         "component": "sensor",
         "stat_t": "~TEMPERATURE/state",
         "config": {
             "stat_cla": "measurement",
             "dev_cla": "temperature",
             "unit_of_meas": "°C"
         }
     }

Curious to which sensors you are thinking of?

The Current Temperature and Humidity.

I have been trying it with eTRV temperatures, by creating a separate sensor for the Room Temperature

@genestealer Did you try adding them to the Climate entity?  Or does it need to be kept separate?

@Achronite The issue is, that Climate entity is not a "sensor" as such, so has no option to enable it's state_class to measurement enabling its long-term statistics.
The only option at present is to create standalone sensors for Current Temperature and Humidity, with the state_class of measurement .

@Achronite are you planning to add Room Temperature to the eTRV for long-term statistics?
   {
     "id": "Room_Temperature",
     "component": "sensor",
     "stat_t": "~TEMPERATURE/state",
     "config": {
         "stat_cla": "measurement",
         "dev_cla": "temperature",
         "unit_of_meas": "°C"
     }
 }


Fix hlint hints

Problem Description
This is from XMonad.Doc.Developing

Code should be free of any warnings or errors from the Hlint tool; use your best judgment on some warnings like eta-reduction or bracket removal, though.

Currently, there are 1008 hints generated with the default hlint settings. Here's the (HTML) report: https://gist.github.com/TheMC47/ca419fc5c45da224e2ac0a1da2493f1b. I think we should make a list of hints that we want to apply, push the fixes, and make hlint part of the pipeline (maybe have it run on diffs when creating a PR)
@geekosaur @slotThe @liskin  what do you think?
related: #524
Checklist

[x] I've read CONTRIBUTING.md

~- [ ] I tested my configuration with xmonad-testing~

I'd start with GHC warnings first. :-)
(I think I mentioned this before.)

I'd start with GHC warnings first. :-)

Should be done

Should be done

Awesome!
Thanks for taking the initiative.

Kudos @slotThe  :tada:

Whoever feels up for applying (some of) the hlint nits, I suggest they use something like apply-refact

It might be worth it to first discuss what exactly we want to fix

It might be worth it to first discuss what exactly we want to fix

Fair enough. Here's what we can do: Once I port the CI refactors from X11/xmonad to xmonad-contrib, we can try enabling hlint in the haskell-ci workflow and see what comes out of it, and we'll have something tangible to discuss.

According to the overview that @TheMC47 linked at the start, this is
the complete list:

The complete list

Warning: Avoid lambda (3)
Warning: Avoid reverse (1)
Warning: Eta reduce (67)
Warning: Evaluate (2)
Warning: Fuse mapM_/map (2)
Warning: Monad law, left identity (1)
Warning: Redundant bracket (97)
Warning: Redundant do (5)
Warning: Redundant flip (1)
Warning: Redundant if (2)
Warning: Redundant lambda (4)
Warning: Redundant return (1)
Warning: Unused LANGUAGE pragma (52)
Warning: Use .   Contentious ones are perhaps

Warning: Eta reduce (67)         (could hamper readability)
Warning: Redundant bracket (97)  (could hamper readability)

Most suggestions are also seem very sensible.  However, some may change
strictness behaviour (Use newtype instead of data, though a "more
strict" version is usually what one wants) or result in less-readable
code; e.g.:
  XMonad/Actions/TagWindows.hs:186:16: Suggestion: Use <$>
  Found

  gets (concat . map (integrate' . stack) . workspaces . windowset)
    >>= mapM getTags
    >>= return . nub . concat

  Perhaps

  (nub . concat)
    <$>
      (gets (concat . map (integrate' . stack) . workspaces . windowset)
         >>= mapM getTags)

In my opinion, the current version is much easier to read.  It would
perhaps be better to use
  gets (concat . map (integrate' . stack) . workspaces . windowset)
    >>= mapM getTags
    <&> return . nub . concat

but since this can't be automated I wonder if it's worth it.  We should
probably go through the suggestions more carefully and decide which ones
we actually want to enforce.

Thanks for summarizing the report into something more readable.
Regarding the Eta reductions, I think we should apply this one and locally disable it when we think it's harmful. I also think applying fixes to redundant brackets is also beneficial (not sure if there's an example where brackets are better).
Regarding <$>, I think you make a good point, the second version is worse... There are only 15 of them, so I could probably go through them manually

This should be fixed by a combination of bd5b969d9ba24236c0d5ef521c0397390dbc4b37 and 402d29b306950b9f74664b7652d2b9f3bfa40895 so I'm closing this.
I suppose we can still use this to discuss whether we want to enforce some hints that hlint does not enable by default (can't think of any right now, but this came up in IRC today)

I noticed a GHC warning while building today, and I decided it might be a good idea to also run hlint.  I got a bunch of suggestions.  I'm wondering if I should submit a pull request for this?

The problem with both of those is that we support old ghc versions, and there is no way to silence either of those without breaking compatibility with those old versions.

However, provided that the test run through on older version do feel free to submit a pull request with changes :)

Also note that we have hlint in our CI: https://github.com/xmonad/xmonad-contrib/actions/workflows/hlint.yaml and it's green, so if you're getting additional suggestions that's either because it's a different version of hlint (⇒ the PR should bump the version we run in CI) or because we configured those suggestions to be ignored (⇒ the PR should unignore the suggestions that it fixes).


Question: customize the servers in provisioners

I do have a question about the customization of worker nodes in the Karpenter provider. In case of EC2 instances with local storage in AWS I would like to auto format and mount the NVME ephemeral volumes.
https://aws.amazon.com/blogs/containers/optimizing-spark-performance-on-kubernetes/
Is there a way to insert script like this into the provider's configuration?
preBootstrapCommands:
      - IDX=1
      - for DEV in /dev/disk/by-id/nvme-Amazon_EC2_NVMe_Instance_Storage_*-ns-1; do  mkfs.xfs ${DEV};mkdir -p /local${IDX};echo ${DEV} /local${IDX} xfs defaults,noatime 1 2 >> /etc/fstab; IDX=$((${IDX} + 1)); done
      - mount -a

Is an existing page relevant?

What karpenter features are relevant?

How should the docs be improved?

Community Note

Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
If you are interested in working on this issue or have submitted a pull request, please leave a comment

Yes the design looks great. In my case I do not want to mess around with kubelet args just modify the system. I vote for Option 3 in case AL2.

Closing this, as we're working on it. Feel free to reach out to @suket22 who's working on this.


Multiline strings generate invalid Julia syntax

#define S "abc"\
          "def"

generates
const S = ("abc")("def")

which is not valid.


'hpc-coveralls': command not found

Hello, thank you for this project. I've modified .travis.yml file according to instructions given in readme file: https://github.com/mrkkrp/megaparsec/commit/05c92cb0552f014e8349bad14925bbab566bbafe
However, the command hpc-coveralls is not available, although package hpc-coveralls seems to be installed successfully: https://travis-ci.org/mrkkrp/megaparsec/jobs/73749896#L692
Can you tell what may be wrong and how to fix it?

OK, I've exported PATH so it can find it: https://travis-ci.org/mrkkrp/megaparsec/jobs/73844122#L693
But as you can it doesn't work this way as well... I've read several .travis.yml files of various projects that "work", but I cannot find any difference.

Some comment would be much appreciated.

Sorry for the delay in my response.
I'm going to investigate as soon as I can.

I had a quick look at the build log of your project on Travis CI, and it looks like the problem is not about finding the hpc-coveralls executable, but rather the .mix files.
From what I see, it is very likely to be the same problem as the one tracked by the issue #44, which should soon be fixed.

@guillaume-nargeot, thank you for your response. Please note that I had to export new value of PATH, without it Travis cannot find hpc-coveralls anyway. If you think it's OK, please add instructions to your README.md file so people know that they need to export PATH manually. However, other projects don't seem to need to do this, so I wonder if this is just a manifestation of another problem.

Thank you for reporting this, I will investigate further what is different in your project setup that makes Travis unable to find hoc-coveralls without export its PATH

@guillaume-nargeot I don't want to seem impatient, but is there any update on this issue?

I'm wondering if this could be due to the fact that your travis config uses language: c instead of language: haskell (which may add ~/.cabal/bin to the PATH behind the scene).

@guillaume-nargeot, since Megaparsec requires GHC 7.10 to work, I couldn't use built-in solutions provided by Travis CI. Common practice is to use https://github.com/hvr/multi-ghc-travis in this case, which provides GHC 7.10 and can be used to test several combinations of GHC/Cabal. It even supports testing with development version of GHC.
So, I took example .travis.yml file as base and edited it to suit needs of our project. As you can see the file contains the following lines:
# NB: don't set `language: haskell` here
language: c

Maybe language: haskell would cause some sort of conflict with built-in functionality?

Hi, @guillaume-nargeot, I've changed language setting to language: haskell and it improved the situation. You should probably include a note about language: haskell in your README.md file or something.
However, it still doesn't work: https://travis-ci.org/mrkkrp/megaparsec/jobs/77906944#L819
It says:
hpc-coveralls: can not find megap_KmgWkNOHHG00KMntE4AAGg/Text.Megaparsec.String in ["dist/hpc/vanilla/mix/megap_KmgWkNOHHG00KMntE4AAGg/"]

Text.Megaparsec.String is a module in library, I use it as a helper in tests too (definitions from the module are used), but I don't test function in it. So, HPC doesn't create directory for it or something. I've tried this:
after_script:
 - cabal install hpc-coveralls
 - hpc-coveralls --coverage-mode=StrictlyFullLines
                 --exclude-dir=tests
                 --exclude-dir=old-tests
                 --exclude-dir=benchmarks
                 --exclude-dir=Text/Megaparsec/ByteString
                 --exclude-dir=Text/Megaparsec/Text
                 tests old-tests

without success. Can you advise something?

Now it works, close the issue if you consider the problem solved.

I think it must have been solved by fixing the issue #44.
Happy to see that it finally works for you!

@guillaume-nargeot, Thanks for your support!


Added Common CSS File

Fix : #49
Hey @ankitapuri @LegendSumeet Please Review

@Atif0604 can we add css for navbar and footer in it. Since its common in whole website

Navbar and footer at this time doesn't require any css
they are all done by the bootstrap classes
@arpit456jain

Ok then we should remove this common css from all other css files right? @Atif0604

Yup We can do the replace for almost all files except for feature.css(it has 1 css class diff) and css-> basic.css(it has a 2 css class diff)

Ok then do that we can check the project by its deploy preview
https://deploy-preview-50--coding-easy.netlify.app
Just do one thing
Make changes one by one commit them and push them and check its hosted preview if everything fine then do this for other files

Sure

Hey @arpit456jain Can you please check about the failed checks
Is it good to go?

There is a bug in Deployment check if its working fine local sys or not check every page responsiveness and push again

There is a bug in Deployment check if its working fine local sys or not check every page responsiveness and push again

Yeah I have pushed for only 1 page
In the local server it was good to go
@arpit456jain
so should do i for all at once?

There is a bug in Deployment check if its working fine local sys or not check every page responsiveness and push again

Yeah I have pushed for only 1 page In the local server it was good to go @arpit456jain
so should i do it for all at once?

Yeah do it one more page and push it

@Atif0604 come on discord channel

@Atif0604 come on discord channel

Yeah i have replied to you on discord @arpit456jain

Hey @ankitapuri @LegendSumeet Please Review

@arpit456jain it seems fine to me

yes its fine


Optimise lint and compile workflow

This should make the action run faster and more efficiently.

Combining the lint and compile steps into the same job/runner is more economical, but the implications to the usability of the GitHub UI are not so favourable as things stand.
The "Checks" tab label suggests there is only one check, and the two separates steps are only revealed when clicking down to the last layer.
Since we don't necessarily have to share data between the two steps, we'll leave this workflow as is (at the cost of having to set up another job/runner). We can and should revisit this if the project grows or GitHub makes changes to the UI which would visualise this differently.


NU1202: Version 3.1.2 is not compatible with netcoreapp2.2

I cannot install the latest version of the versioning package as VS2019 is saying:

NU1202: Package Microsoft.AspNetCore.Mvc.Versioning 3.1.2 is not compatible with netcoreapp2.2 (.NETCoreApp,Version=v2.2). Package Microsoft.AspNetCore.Mvc.Versioning 3.1.2 does not support any target frameworks.

However, it is possible to instal 3.1.1 without errors. How can I fix that and install the 3.1.2?

Hmmm... that seems very strange since 3.1.2 is just a patch over 3.1.1.
Visual Studio does occasionally give me grief on package restore. You might try:

Edit the project and manually change the package version to 3.1.2
Open the Developer Command Prompt for VS2019 in the project location
Run dotnet restore or msbuild -v:m -t:Restore; they should both have the same net effect
Go back to Visual Studio and try building again

If package restore is still failing on the command-line, then something else is wrong. All of the test and sample projects target netcoreapp2.2 so 3.1.2 is definitely compatible.
Try that first and if it doesn't work, we can dig into other details.

Were you able to resolve this issue and get things working?

@commonsensesoftware I was able to fix it with your checklist. Thanks! I guess upgrading packages must have messed up nuget catches or something.

I upgraded to aspnetcore 3.1 https://docs.microsoft.com/en-us/aspnet/core/migration/22-to-30?view=aspnetcore-3.1&tabs=visual-studio-mac
The issue gets resolved.


ghc: Fix otool and install_name_tool paths not set in settings

Description of changes
Fixes #267250
Diff between the original and the new settings file:
--- /nix/store/yj3jx0yappw3fnwkvasg09niqvdxzcw9-ghc-9.6.3/lib/ghc-9.6.3/lib/settings	1970-01-01 01:00:01.000000000 +0100
+++ /nix/store/rr1qknbr8qxih1nw8hil15a970mp1ira-ghc-9.6.3/lib/ghc-9.6.3/lib/settings	1970-01-01 01:00:01.000000000 +0100
@@ -19,8 +19,8 @@
 ,("ar supports at file", "YES")
 ,("ar supports -L", "NO")
 ,("ranlib command", "/nix/store/vpnp0c420cjmx82g05jq3nm5skdrblvk-cctools-binutils-darwin-16.0.6-973.0.1/bin/ranlib")
-,("otool command", "otool")
-,("install_name_tool command", "install_name_tool")
+,("otool command", "/nix/store/vpnp0c420cjmx82g05jq3nm5skdrblvk-cctools-binutils-darwin-16.0.6-973.0.1/bin/otool")
+,("install_name_tool command", "/nix/store/ydcx9rj4gf3dxm1kc0lx7l5d5vrjdwp2-cctools-binutils-darwin-wrapper-16.0.6-973.0.1/bin/install_name_tool")
 ,("touch command", "touch")
 ,("dllwrap command", "/bin/false")
 ,("windres command", "/bin/false")

Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Priorities
Add a :+1: reaction to pull requests you find important.

I've cherry-picked your change as 2af613b58c9401fd7b4d270a46f22a755990fd43 and adjusted some minor things, namely to prevent a rebuild on platforms that don't use cctools.
It is on haskell-updates, the branch we use to test haskell related changes. You can track our progress via #268652 and of course also test things on that branch!


Add a "witnessed" column to the facility summary tests table

Requested by Steve A: A column with a simple yes/no indicating whether a source test was witnessed.

Closed in https://github.com/gaepdit/airbranch-db/commit/0de6e78ad599bb9420ab6a1c634e42eb4e2e1bd1


wrong uuid ?

managed to get it installed
for me using atxx firmware it doesnt do anything
"{"id":"a4c13875e821","address":"a4:c1:38:75:e8:21","addressType":"public","connectable":true,"advertisement":{"localName":"ATC_75E821","serviceData":[{"uuid":"181a","data":{"type":"Buffer","data":[164,193,56,117,232,33,0,236,37,75,11,64,19]}}],"serviceUuids":[],"solicitationServiceUuids":[],"serviceSolicitationUuids":[]},"rssi":-84,"mtu":null,"state":"disconnected"}"
this is the output from my sensors
i note the uuid is wrong from your filter ?

got it. it was set only to atc broadcast mode


[WTF] Don't add unneeded context

https://github.com/jupeter/clean-code-php#dont-add-unneeded-context
What did you try to show in this code?
$car = [
    'carMake'  => 'Honda',
    'carModel' => 'Accord',
    'carColor' => 'Blue',
];

function paintCar(&$car) {
    $car['carColor'] = 'Red';
}

What relation has the name of the variable to the prefixes of the keys of the array?
Why do you change the array by reference?
Why do not you use classes to describe the structure?
Maybe you meant something like this:
class Car
{
    public $carMake;
    public $carModel;
    public $carColor;

    public function paint($color)
    {
        $this->carColor = $color;
    }
}

and
class Car
{
    public $make;
    public $model;
    public $color;

    public function paint($color)
    {
        $this->color = $color;
    }
}

I agree with @peter-gribanov that the class example is better. Although, I feel the function is completely pointless and obscure the point of this example.
class Car
{
    public $carMake;
    public $carModel;
    public $carColor;

    //...
}

And
class Car
{
    public $make;
    public $model;
    public $color;

    //...
}

Would suffice.

Thx for contributing.
I agree with you - could you create PR with fix?

Closed by #34


Composite Operations

Working with sObjects using composite requests
Create record with child records in same request
Create record and retrieve record with ID in same request
Combine collection requests into one

https://developer.salesforce.com/docs/atlas.en-us.api_rest.meta/api_rest/requests_composite.htm

Some composite operations are already available, as they were created alongside function intended for inserting, updating, etc sobject collections


OAuth signature generation is sensitive to URL case.

Andy,
We discovered what I think is a bug, in that the generated signature varies as the case of the URL varies. This caused us issues (in some special diagnostic support we've built for our LTI stuff).
I found this info that suggests it's a bug and that the URL should always be forced to lower case prior to generating a signature:
http://oauth.net/core/1.0/#sig_url
Thanks.

In case this issue is confirmed, could it please be fixed in a backward compatible way? (E.g. accept buggy and correct signatures)
Our company and our partners make extensive use of your library, so having to synchronize an upgrade is nigh impossible.
Thanks in advance,

@Korporal are you planning to submit a pull request?

Hi, not unless this is agreed/confirmed. There are differing opinions on whether URLs should be treated in a case sensitive or insensitive manner, "fixing" the code could - conceivably - break stuff already out there so I'm not clear on whether we should or shouldn't make such a change.

I don't want to generalize, but I assume that since this is a .Net library the majority of the users/commenters are almost exclusively Microsoft/IIS. I have been watching this library for a little bit now with the intent on using it shortly, so I don't have any comment on the library.
However I can offer this insight into the case sensitivity. We are also a 100% Microsoft shop, however when dealing with Linux-based servers their URLs are case sensitive.
http://api.mysite.com/myresource
is not the same as
http://api.mysite.com/MyResource
and will result in a 404 or some other mapped response.
So the need to have the library treat URLs as case-sensitive is an artifact of how more than half of the webservers actually work. I would urge NOT applying any case changing to supplied URLs.

@webatxcent @jeroenhabets - Since this would only affect the signature base string, I should only impact the signature. However, the signature is calculated on both sides (TC and TP), and there is a chance that the partners you have been working with are also incorrectly calculating the signature base string. So when LtiLibrary is fixed, interoperability with those partners will be broken.

@Korporal - I think the current code, based on https://tools.ietf.org/html/rfc5849#section-<IP_ADDRESS>, is correct.

@Korporal - I'm going to close this issue, but if you find out that most implementations of LTI are using http://oauth.net/core/1.0/#sig_url instead of https://tools.ietf.org/html/rfc5849#section-<IP_ADDRESS>, please let me know.


使用多个物种的拉丁名导入时报错

i Use spec() to retrieve the full column specification for this data.
i Specify the column types or set show_col_types = FALSE to quiet this message.
Joining with by = join_by(name)
Error in while (testid != "1") { : argument is of length zero
In addition: There were 31 warnings (use warnings() to see them)
使用多个物种的拉丁名导入时报错

抱歉未能及时回复。您可关注农心生信工作室微信公众号，我们后台详细交流下问题。


Lab 1 & 2 - Let tests run without server

Use supertest.

Won't fix because Docker Compose can be used on GitHub.


Dont claim NODE_NETWORK support in stealth mode unless the node supports it

Pruned node would show NODE_NETWORK service bit when in stealth mode.

@dagurval You were right.  With the change I pushed for here, #109 plus this change would send NODE_BLOOM in combination with an invalid protocol version.  Your original version of this wouldn't have that problem IIRC.

Nice catch. Easier to maintain a whitelist then a blacklist :-). Back to whitelist it is.

Needs rebase.

Rebased.


C#

There is no code showing how to get the attachments, I don't care about the number of attachments, I need to be able to save the attachments.
https://sendgrid.com/docs/Integrate/Code_Examples/Webhook_Examples/csharp.

Hello @jwisener,Thanks for your suggestion or question! In an attempt to clear out our backlog,                                              we are closing out issues over 90 days old.                                             If this is still an issue, please feel free to reopen it.                                             Team SendGrid DX-Docs

You can completely remove as no one ever responded In a year. We decided to
use another provider.
On Wed, Jun 7, 2017 at 6:54 PM Elmer Thomas<EMAIL_ADDRESS>wrote:

Closed #1658 https://github.com/sendgrid/docs/issues/1658.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sendgrid/docs/issues/1658#event-1114632347, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAISThGNhGbCvt6mVRqpU1UmTLkoRJMLks5sBzgugaJpZM4H1hS4
.


operator pelorus-operator (0.0.7)

pelorus-operator files for version 0.0.7
This pull request was created automatically after merging new version of Pelorus
Please review it

@etsauer
@KevinMGranger
@mateusoliveira43
@mpryc
@weshayutin

After review, comment /unhold in This PR to merge it.

/hold

/retest

/hold

/retest

/hold

/test 4.9-deploy-operator-on-openshift

/merge possible

/lgtm

/unhold

/merge possible


FileFactory calls to fileset.files.first instead of fileset.original_file

In set_removed_filesets and update_filesets, FileFactory makes calls to fileset.files.first that should probably be fileset.original_file.  If the FileSet has multiple files associated under different uses -- say, original_file and extracted_text, calling .first grabs one at random, and might erroneously replace the extracted text with a new image file.

need to see if this is still an issue in the bulkrax repo.


Request: Allow terraform as a human-friendly alias for tf tool

Is your feature request related to a problem? Please describe.
Not a problem as much as just a wee bit of ambiguity.
As I'm moving between Tofu and Terraform frequently (for testing compatibility, migrations paths, and the likes), I've come to appreciate explicit distinction when referencing both tools in various workflows, often simultaneously.
Describe the solution you'd like
As a result, it'd be splendid if tenv would support aliases for the tool names.
While this request is specifically to allow terraform as an alias for tf, I'm equally fond of adding human-friendly aliases for the others as well. For example:

tool
env vars
description

tofu (or opentofu)
TOFUENV_
OpenTofu

tf   (or terraform)
TFENV_
Terraform

tg   (or terragrunt)
TG_
Terragrunt

Describe alternatives you've considered
The simple workaround is to just use the specified tool name, adapting it as and when required. That being said, I believe this would be a nice-to-have feature that would make the tool more user-friendly.
Additional context
Big thanks to @kvendingoldo for identifying tenv as a good fit for DevSecTop/TF-via-PR-Comments GH Action workflow!

I think it's not a problem to create an alias. @dvaumoron as I understand correctly, we just need to add additional binaries like terraform.go or tofu.go, yep?

I think it's not a problem to create an alias. @dvaumoron as I understand correctly, we just need to add additional binaries like terraform.go or tofu.go, yep?

That seem strange to me, why create copies of the binaries ? They would be exactly the sames, why a shell alias doesn't work ?

Hey @dvaumoron, you're absolutely right in that terraform is more letters to type than tf. With that said, this request is for additional alias(es) only, which would be available for use on top of the existing tf option, not instead of it.
As for why a longer name would be preferred, that's a fair ask.
To share more context, I tend to provision OpenTofu/Terraform via CI automation like GitHub Actions. And when I see a line like tenv tf install latest, it's not immediately obvious to me which tool it's in reference to. Especially now, when frequently moving/testing between OTF and TF -- all the while using .tf files -- I think we can agree there's a wee bit of ambiguity here.
And that's not getting into the inconsistency of tool/proxy naming. For example, one would tofu init so tenv tofu install latest makes total sense as a 1:1 match. Whereas, it's terraform init so tenv tf install latest has me pausing for a moment to check that correlates with the correct tool.
Though I was hoping there might be a more shell-oriented route for managing aliases. I have to agree that spinning off whole entire additional binaries just to support aliases seems like a heavy solution. Though I don't have a better one to offer in its place.

Ok, I get it. It is easy to add sub command aliases in tenv command (the project does not use separate binaries for that, as I said, the other binaries are proxy to the managed tools).

Many thanks on such a swift turnaround, and even going beyond the request! 🙌

@RDhar, I forgot to mention that once tenv installed, a terraform init is enough (the proxy is able to download a version if there is none, the default strategy will be latest-allowed when there is no .terraform-version file)

Nice one, that's convenient!
Although, the default ubuntu-latest GH Action runner ships with its own software, including Terraform, which means tenv gets ignored unless explicitly called first. 🫤
Down the line, Terraform might be phased out of open-source default packages, as we see with: GitLab, Brew and Alpine Linux. In which case, tenv becomes even more valuable!

Ah, as it happens, tenv being over-riden by GH Action runner's default terraform binary just became a problem in #93. Despite installing/using a specific version of Terraform, the runner's in-built binary is used instead, as demonstrated here:
$ tenv terraform use 1.6.1
$ terraform --version
...
Installation of Terraform 1.6.1 successful
Written 1.6.1 in /home/runner/.tenv/Terraform/version
Terraform v1.7.5
on linux_amd64


DIODE working with a folder

DIODE should work with more than one file, and be able to be part of a Python workflow with saving files.

[x] Remove "saved projects"
[ ] Save SDFGs directly to folder
[x] Save files on ctrl-s
[ ] Pane to view files in folder / subfolders
[ ] Save pane layout in folder
[ ] Use local configuration
[ ] View multiple SDFGs? One at a time?
[ ] Reload file if changed on disk

Superseded by dace-vscode.
@phschaad Please see if there is anything interesting here.


Graduate +cmdline_info, +byteoff, +linebreak

All combined these adds very little to the resulting filesize, between 12K and 20K depending on the compile flags:

-O0
-O2
-Os

master
1795496 1.8M
1638240 1.6M
1199456 1.2M

this patch
1816152 +20K
1654688 +16K
1211808 +12K

Looking at the code, there's a bit of extra runtime overhead in terms of memory and CPU, but that seems tiny as well.

All combined these adds very little to the resulting filesize, between
12K and 20K depending on the compile flags:

-O0
-O2
-Os

master
1795496 1.8M
1638240 1.6M
1199456 1.2M

this patch
1816152 +20K
1654688 +16K
1211808 +12K

Looking at the code, there's a bit of extra runtime overhead in terms
of memory and CPU, but that seems tiny as well.

I do not really want to add +byteoff to the tiny version.  I do not
think the functionality is used much, and it adds runtime overhead,
keeping track of byte offsets.  Especially what happens in
ml_updatechunk().
The linebreak stuff is quite advanced and complicated.  Graduating it
does help to get rid of the #ifdefs, but it also makes updating the
display more complicated.  Gut feeling is that it doesn't belong in the
tiny version.
The command line info, 'ruler' and 'showcmd' are more basic features
that could indeed be added in the tiny version.
--
[clop clop]
ARTHUR:  Old woman!
DENNIS:  Man!
ARTHUR:  Man, sorry.  What knight lives in that castle over there?
DENNIS:  I'm thirty seven.
ARTHUR:  What?
DENNIS:  I'm thirty seven -- I'm not old!
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

I rebased on master, dropping the +byteoff commit.

The linebreak stuff is quite advanced and complicated.  Graduating it does help to get rid of the #ifdefs, but it also makes updating the display more complicated.  Gut feeling is that it doesn't belong in the tiny version.

My thinking is that the complicated code is there regardless, whether it's guarded by an #ifdef or not, and as long as it doesn't add any significant performance cost (in terms of disk size, memory, or CPU) I don't see why not include it in the tiny build.

I rebased on master, dropping the +byteoff commit.

The linebreak stuff is quite advanced and complicated.  Graduating
it does help to get rid of the #ifdefs, but it also makes updating
the display more complicated.  Gut feeling is that it doesn't belong
in the tiny version.

My thinking is that the complicated code is there regardless, whether
it's guarded by an #ifdef or not, and as long as it doesn't add any
significant performance cost (in terms of disk size, memory, or CPU) I
don't see why not include it in the tiny build.

I don't think it involves a performance cost, so long as 'linebreak' is
off the extra code should not be executed.  It does require calling
get_showbreak_value() to see if 'showbreak' is empty, but it should be
fast.
This one feature itself may not be a lot of code, but there are several
like this, and all together it starts becoming quite a chunk of code.
And when we graduate this one, then why not the other ones...
As I said, it is more a gut feeling that this functionality has no place
in the tiny version than the amount of code.  Keep in mind that the tiny
build doesn't have the eval feature or syntax highlighting, thus
'linebreak' and 'showbreak' seem out of place.
The ruler is more a basic editing feature, thus that does have a place
in the tiny version.
--
ARTHUR:  Then who is your lord?
WOMAN:   We don't have a lord.
ARTHUR:  What?
DENNIS:  I told you.  We're an anarcho-syndicalist commune.  We take it in
turns to act as a sort of executive officer for the week.
The Quest for the Holy Grail (Monty Python)
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

Keep in mind that the tiny build doesn't have the eval feature or syntax highlighting, thus 'linebreak' and 'showbreak' seem out of place.

I like 'linebreak' so that it breaks words, rather than having the very jarring breaks in the middle of a word. I can go without a lot of bells and whistles just fine, but this is one I always miss every time I'm on a machine with busybox vi, nvi, or tiny Vim I really miss it. But maybe that's just me...
'showbreak' is probably a bit less "basic"; and indeed doesn't make much sense without +syntax. Maybe putting that behind +syntax and enabling the rest in tiny would make sense?

This one feature itself may not be a lot of code, but there are several like this, and all together it starts becoming quite a chunk of code. And when we graduate this one, then why not the other ones...

Yes, why not? :-)
I did some testing the other day, and this is a rough overview of what the features add (with -O2):
                                  Size          Diff       In Feature     Num #ifdef (approx, quick grep)

tiny:                         1654688
    VIM_BACKTICK:             1654688        +0  0K    NORMAL               8
    FEAT_MULTI_LANG:          1658832     +4144  4K    NORMAL              73
    FEAT_VARTABS:             1662880     +8192  8K    HUGE                81
    FEAT_FIND_ID:             1662976     +8288  8K    NORMAL              47
    FEAT_STL_OPT:             1671152    +16464 16K    NORMAL              54
    FEAT_DIGRAPHS:            1671296    +16608 16K    NORMAL              30
    FEAT_VIMINFO:             1679776    +25088 24K    NORMAL              64
    FEAT_CRYPT:               1692144    +37456 36K    NORMAL             131
    FEAT_FOLDING:             1695968    +41280 40K    NORMAL             332
    FEAT_DIFF:                1716784    +62096 60K    NORMAL             308
    FEAT_SPELL:               1783024   +128336 125K   NORMAL             119

    FEAT_EVAL, FEAT_SYN_HL:   2554760   +900072 878K   NORMAL             1127, 276 (depend on each other)
        FEAT_CONCEAL:         2564136     +9376   9K   NORMAL             108
        FEAT_SEARCH_EXTRA:    2575528    +20768  20K   NORMAL             103
        FEAT_QUICKFIX:        2621384    +66624  65K   NORMAL             216
        FEAT_PROP_POPUP       2554760        +0        NORMAL             297

+eval and +syntax add the most, +spell, +diff, +folding, +crypt a bit, but most ... not all that much. Even ~50K extra is still only a ~3% increase in file size for the tiny version. Even the original vi is ~320K; nvi is ~470K.
Some features like +byteoff and +vartabs also add some runtime overhead of course, but things like FEAT_FIND_ID, FEAT_STL_OPT, etc. don't really as far as I can tell, and certainly not when you don't use or enable them.

Keep in mind that the tiny build doesn't have the eval feature or
syntax highlighting, thus 'linebreak' and 'showbreak' seem out of
place.

I like 'linebreak' so that it breaks words, rather than having the
very jarring breaks in the middle of a word. I can go without a lot of
bells and whistles just fine, but this is one I always miss every time
I'm on a machine with busybox vi, nvi, or tiny Vim I really miss it.
But maybe that's just me...
'showbreak' is probably a bit less "basic"; and indeed doesn't make
much sense without +syntax. Maybe putting that behind +syntax and
enabling the rest in tiny would make sense?

Since we don't have actual usage statistics, I go on my own judgement.
One disadvantage of 'linebreak' is that it has had so many bugs (and now
heavily interferes with 'smoothscroll'), although much of that is
related to 'breakindent', which is in the same feature.

This one feature itself may not be a lot of code, but there are
several like this, and all together it starts becoming quite a chunk
of code. And when we graduate this one, then why not the other
ones...

Yes, why not? :-)

You left out FEAT_CMDL_INFO, which is the one from you PR that I think
we could include.

I did some testing the other day, and this is a rough overview of what
the features add (with -O2):

It's not just the size, it also has to make sense in the build.  We
don't want a random selection of features.  You don't sort books by
their size, right?
--
Be nice to your kids...  they'll be the ones choosing your nursing home.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

You left out FEAT_CMDL_INFO, which is the one from you PR that I think we could include.

Yeah, I only included the things not in this patch, so I could see what other potential candidates there might be for graduation.
So the decision is to only graduate FEAT_CMDL_INFO for now and leave everything else as-is (including the ones listed in my previous message)?

You don't sort books by their size, right?

Useful when used to prop up the monitor, thrown as a projectile, deciding what book assignments to read in school, etc. ;-)

Rebased again, dropping the +linebreak commit.

You left out FEAT_CMDL_INFO, which is the one from you PR that I
think we could include.

Yeah, I only included the things not in this patch, so I could see
what other potential candidates there might be for graduation.
So the decision is to only graduate FEAT_CMDL_INFO for now and leave
everything else as-is (including the ones listed in my previous
message)?

Yes, I think that is the best right now.

You don't sort books by their size, right?

Useful when used to prop up the monitor, thrown as a projectile,
deciding what book assignments to read in school, etc. ;-)

I know people who sort books by their color...
--
It's not hard to meet expenses, they're everywhere.
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

CI error: drawline.c:2697:25: error: ‘on_last_col’ undeclared (first use in this function)

Oops, I had fixed that already but forgot to push.

Oops, I had fixed that already but forgot to push.

I found one extra line in feature.h that must have been left over from
trying out things.  I deleted it.
Otherwise looks OK now.
--
ARTHUR:   Ni!
BEDEVERE: Nu!
ARTHUR:   No.  Ni!  More like this. "Ni"!
BEDEVERE: Ni, ni, ni!
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- @.*** -- http://www.Moolenaar.net   \
///                                                                      \
\\        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///


Question: Any updates around the Cache busting issue?

I've read your medium article about cache busting in angular-cli. Thanks for putting it together!
I see that the issue and pr you created are now closed and merged respectively.
I'm wondering if with those issues now solved the process has been simplified a bit.
Also; I noticed that you hardcoded .template in this relative asset plugin. Any chance we could pass it as a parameter? I think most people tend to use .tpl.html instead.
Thanks!

@jonnysamps Please added feature to pass a parameter. :) So, I can change .template to .html and so on..
Thank you very much
This repo is cool 💃

I'm happy to review and merge a PR if but I'm not able to work on this for another couple of weeks.

No worries I'll do it on Monday at work.

Have you tried this plugin with LESS  or SASS pre-processors? For some reason it can't find the .css file in the tmp folder.
Any chance you'd have a working sample project on Github?

Angular CLI will compile less and sass files to css... I haven't had any problem with it. @ghpabs

I am having the same issue @ghpabs. Seems like the Plugin throws an exception at the first file with an .scss exception.
Error Message: http://pastebin.com/xYdf7NSm

@riscie I think the best thing to do is to wait for the new angular-cli release with webpack. It seems like cache busting feature will come out-of-the-box.

Ya, you really shouldn't bother with this as the webpack stuff is already in alpha.


Bump default E2E K8s version from 1.28 to 1.29

We’ll need a newer kind release with 1.29 images before this can work. Note that the default E2E GHA relies on Shipyard’s default; see https://github.com/submariner-io/shipyard/pull/1538.


Only one method per scenario

Now, only one method is processed by scenario.

I think there are two main issues we need to tackle:
* If we have 3 methods, then we compute three times the federated training `fl_training.compute_test_score_with_scenario()` for nothing.

That is a good point.
Actually we don't have to compute the multi-partner collaborative training when we want to compare contributivity measurements. I think we just took the habit of computing it every time we launch an experiment, because we became interested in the score of the multi-partner collaborative training.
This thing forces us to take one step back and re-think the Experiment and Scenario definitions / roles. We might need a third level. For example Experiment > Scenario > Comparisons:

Experiment: a set of different scenarios
Scenario: a given multi-partner scenario (dataset, data amounts, split option, etc.)

Learning Comparison: different multi-partner collaborative learning methods applied to the same scenario
Contributivity Measurement Comparison: different contributivity measurement methods (for a given learning method passed as parameter)

Probably it would make more sense to save results of Learning Comparisons and Contributivity Measurement Comparisons in different result files.
Does this seem to make sense?

* If we have 3 methods, then we will have 3 scenario ids in the result file. The result analysis will be way harder if we need to reconstruct a posteriori the "original" scenario id.

In the approach described above we would have:

Each 'Learning Comparison' would have a dedicated id under the umbrella of the same Experiment id + Scenario id
Each 'Contributivity Measurement Comparison' would have a dedicated id under the umbrella of the same Experiment id + Scenario id

So now that we have implemented the extra multi-partner learning methods, we have a clearer view of what really makes sense. And it turns out the current implementation is pretty cool: in a given scenario there is 1 multi-partner learning approach and multiple contributivity methods. This is what is most natural (I now think).
I would say, as a consequence, that we should probably drop this ongoing PR.

So now that we have implemented the extra multi-partner learning methods, we have a clearer view of what really makes sense. And it turns out the current implementation is pretty cool: in a given scenario there is 1 multi-partner learning approach and multiple contributivity methods. This is what is most natural (I now think).
I would say, as a consequence, that we should probably drop this ongoing PR.

Is it ok @celinejacques @RomainGoussault that would stop and delete this PR?

So now that we have implemented the extra multi-partner learning methods, we have a clearer view of what really makes sense. And it turns out the current implementation is pretty cool: in a given scenario there is 1 multi-partner learning approach and multiple contributivity methods. This is what is most natural (I now think).
I would say, as a consequence, that we should probably drop this ongoing PR.

Is it ok @celinejacques @RomainGoussault that would stop and delete this PR?

I agree


impl Sync & Send for DBRateLimiter

fix issue https://github.com/pingcap/tikv/issues/2598

I don't think it's going to work. Raw pointers are neither sync nor send, it has nothing to do with DBRateLimiter itself.

So is this the problem of the compiler, regarding that issue?

Can you reproduce the issue? You can't control raw pointers, but you can control the struct that use raw pointers.

I tried with the same rust version, the compilation is fine on my machine.


Integration tests for the file discovery backend

Problem
Integration tests for the file discovery backend
Solution
Write integration tests to verify the file discovery backend is working correctly

#dibs

#dibs

@groob any progess about this? If not, would you mind if I take over this one?

@chanwit go ahead, I ran out of steam.

Thanks @groob ! Review is very welcome.

@abronan @aluzzardi This issue can be closed for now.


Improve FreeBSD rc script

mackerel-agent is now available as FreeBSD ports.  Here's a feedback on rc script from a FreeBSD developer.

Add some comment
Do not spit out logs on stdout but use syslog when run as daemon
Use the same config file path as well as other distro (mackerel-agent subdir)
Run as supervisor mode

CC: @owatan

@susisu I've totally rewritten the README.


SystemChrome API on Android 12: Interaction with Splash Screen API

Steps to Reproduce

Added this Gradle dependency on app build.gradle

implementation 'androidx.core:core-splashscreen:1.0.0-beta02'

Override onCreate on MainActivity.java/MainActivity.kt and added Splash Screen installation instructions (see Code sample). The Activity class is currently extending FlutterFragmentActivity, not tested with FlutterActivity since I was using local_auth plugin which demands extending the Fragment variant.
Execute flutter run on the code sample
If SystemUIMode.manual with overlays set to [SystemUiOverlay.bottom] is not used, the unwanted Status Bar shows up, sticks on the screen, and pushed other Widgets down on Android 12, due to Splash Screen Installation.
Although it worked, but if I swiped downward on the top edge of the screen, it showed the Status Bar and it's not removing itself after a certain duration/any gestures. But I hacked around it by calling SystemChrome.restoreSystemUIOverlays() but it caused a brief dismissing animation of the Status Bar initially.

Expected results:
Calling SystemChrome.setEnabledSystemUIMode(SystemUiMode.manual, overlays: [ SystemUiOverlay.bottom, ],) should dismiss the Status Bar and prevents the sticky behavior. I think it would be nice to have an additional flag to disable the swipe gesture.
Actual results:
The Status Bar behaves like a Sticky View/Widget on the top of the screen, and requires additional hack to dismiss on Android 12 above.

Code sample

Splash Screen Installation
import androidx.core.splashscreen.SplashScreen.Companion.installSplashScreen

// Under class MainActivity: FlutterFragmentActivity {
override fun onCreate(savedInstanceState: Bundle?, persistentState: PersistableBundle?) {
    if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
        val splashScreen = installSplashScreen()
        splashScreen.setOnExitAnimationListener {
            it.remove()
        }
    }
    super.onCreate(savedInstanceState, persistentState)
}

styles.xml (v-31)
<?xml version="1.0" encoding="utf-8"?>
<resources>
    <style name="PostLaunchTheme" parent="@android:style/Theme.Material.NoActionBar">
        <item name="android:windowActionBar">false</item>
        <item name="android:windowNoTitle">true</item>
    </style>

    <style name="LaunchTheme" parent="Theme.SplashScreen">
        <!-- Show a splash screen on the activity. Automatically removed when
             Flutter draws its first frame -->
        <item name="android:windowSplashScreenBackground">@color/whiteSnowDark</item>
        <item name="android:windowSplashScreenIconBackgroundColor">@color/whiteSnowDark</item>
        <item name="android:windowSplashScreenBrandingImage">@drawable/splash_license</item>

        <item name="postSplashScreenTheme">@style/PostLaunchTheme</item>
    </style>
</resources>

Removing the unwanted Status Bar
import 'package:device_info_plus/device_info_plus.dart';

void main() async {
  // Required to initialize dependencies
  WidgetsFlutterBinding.ensureInitialized();
  await Future.wait(
    [
      SystemChrome.setPreferredOrientations(
        [
          DeviceOrientation.portraitUp,
        ],
      ),
      if (Platform.isAndroid)
        Future(
          () async {
            final androidInfo = await DeviceInfoPlugin().androidInfo;
            final sdkInt = androidInfo.version.sdkInt;
            if (kDebugMode) {
              log(
                sdkInt?.toString() ?? 'Not found',
                name: 'Android SDK Level'
              );
            }
            if (sdkInt != null && sdkInt >= 31) {
              // SystemChrome.setSystemUIOverlayStyle(
              //   SystemUiOverlayStyle(
              //     statusBarColor: Colors.transparent,
              //     statusBarBrightness: Brightness.dark,
              //   ),
              // );
              // Remove the lingering ActionBar
              await SystemChrome.setEnabledSystemUIMode(
                SystemUiMode.manual,
                overlays: [
                  SystemUiOverlay.bottom,
                ],
              );
              SystemChrome.setSystemUIChangeCallback(
                (systemOverlaysAreVisible) async {
                  if (kDebugMode) {
                    log(
                      "$systemOverlaysAreVisible",
                      name: "SystemChrome.setSystemUIChangeCallback.systemOverlaysAreVisible",
                    );
                  }
                  // SystemChrome.setEnabledSystemUIMode(
                  //   SystemUiMode.manual,
                  //   overlays: [
                  //     SystemUiOverlay.bottom,
                  //   ],
                  // );
                  SystemChrome.restoreSystemUIOverlays();
                },
              );
            }
          },
        ),
    ],
  );
  // other app initializing codes
}

Logs

The plugin `screen` uses a deprecated version of the Android embedding.
To avoid unexpected runtime failures, or future build failures, try to see if this plugin supports the Android V2 embedding. Otherwise, consider removing it since a future release of Flutter will remove
these deprecated APIs.
If you are plugin author, take a look at the docs for migrating the plugin to the V2 embedding: https://flutter.dev/go/android-plugin-migration.
Analyzing MobileOVIP...
No issues found! (ran in 21.8s)

[✓] Flutter (Channel stable, 3.3.2, on macOS 12.5.1 21G83 darwin-x64, locale en)
    • Flutter version 3.3.2 on channel stable at /Users/neruno/development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision e3c29ec00c (2 weeks ago), 2022-09-14 08:46:55 -0500
    • Engine revision a4ff2c53d8
    • Dart version 2.18.1
    • DevTools version 2.15.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
    • Android SDK at /Users/neruno/Library/Android/sdk
    • Platform android-33, build-tools 33.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jre/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 13F100
    • CocoaPods version 1.11.3

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2021.2)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)

[✓] VS Code (version 1.70.2)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.46.0

[✓] Connected device (3 available)
    • SM A225F (mobile) • RR8R908DQ3N • android-arm64  • Android 12 (API 31)
    • macOS (desktop)   • macos       • darwin-x64     • macOS 12.5.1 21G83 darwin-x64
    • Chrome (web)      • chrome      • web-javascript • Google Chrome 105.0.5195.125

[✓] HTTP Host Availability
    • All required HTTP hosts are available

• No issues found!

Hi @nsNeruno please provide a completed and minimal reproducible code sample so that we may verify this. In this case, it's related to Android native configuration, please push the code into a repository (maybe Github) and make it public, so that we can pull and run the sample code.
Also, does this issue only happen when integrating Splash Screen API into app? Could you please also retry on the latest Flutter master channel to see if the issue is reproducible?
Thank you!


Add Blacklist word Filter for Registration

Implement a blacklist word filter during the domain registration process to screen for explicit language, in both Thai and English.
In cases where inappropriate domain names are discovered post-registration, add them to a blacklist at the Web 2.0 API level only.
There must not be a function to burn NFTs.

https://www.npmjs.com/package/bad-words

[ ]  Add KV for blacklist word
[ ]  Add worker to act as an intermediary between jns app and kv. (to avoid exposing kv)
[ ]  Filter name from jnsjs
[ ]  Optional (Filter name from subgraph)


Release 0.41.0

Prepping for 0.41.0 release. 🎉
Release checklist:

[x] run integration tests on this branch
[x] merge this PR
[ ] run integration tests on master
[ ] publish new crates
[ ] tag new releases

Running integration tests on master now.


Update Tour De Sun 22 program information

Problem
The current documentation includes outdated information about the Tour De Sun 22 program, which is now closed to new applicants. This could cause confusion for users who are trying to participate in the program.
Summary of Changes

Updated the Tour De Sun 22 section to indicate that the program is winding down and applications are now closed.
Added information that March 2024 was the final month of the program.
Included a link to the official blog post announcing the end of Tour De Sun 22 for further details.

Fixes #

Just incase - I see you merged a commit, but I don't see any actual differences / the commit you pushed is empty. And by the way, it could be a line ending issue for why the extra lines are showing up at the end of the diff. Are you editing on a Windows machine ?

I have edited the PR. Kindly check if it looks correct now.


Dependabot/docker/dotnet/core/sdk 3.1.404

new

No idea what you are trying to do here.

No idea what you are trying to do here.


[20.03] backport brave: 1.5.112 -> 1.5.115

Update the checkum and the version
(cherry picked from commit fa5fc4993e1e8bb58183cc076ac786cb7c959452)
Reason: Browser must be kept up-to-date

Motivation for this change
Keep the browser up-to-date for release 19.09
Backport PR #83343
Things done
Update checksum and version.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

LGTM


use same env variable as application

Signed-off-by: Riccardo Piccoli<EMAIL_ADDRESS>
[x] Chart version not bumped (the versions are all bumped and released at the same time)
[ ] README.md updated with any new values or changes
[ ] Updated template tests in ${CHART}/tests/*.py
[ ] Updated integration tests in ${CHART}/examples/*/test/goss.yaml

It appears that env vars used by kibana are ELASTICSEARCH_USERNAME and ELASTICSEARCH_PASSWORD, but readiness uses ELASTIC_USERNAME and ELASTIC_PASSWORD. This causes kibana to be unready, unless we also configure ELASTIC_ vars.

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

jenkins test this please

jenkins test this please

jenkins test this please


Protobuf 4.24.0 break tensorflow and causes segfault with TF 2.12

Issue type
Build/Install
Have you reproduced the bug with TensorFlow Nightly?
No
Source
source
TensorFlow version
TF 2.12
Custom code
No
OS platform and distribution
Linux,Ubuntu
Mobile device
No response
Python version
3.8
Bazel version
No response
GCC/compiler version
No response
CUDA/cuDNN version
No response
GPU model and memory
No response
Current behavior?
With source build as well as pip install TF execution models fails with segfaults and the root cause seems to be because of protobuf version 4.24.0. It works fine till protobuf 4.23.4. adding a constraint in setup.py can be an immediate fix.
Standalone code to reproduce the issue
Any CNN model execution causes the workflow to fail.

Relevant log output
2023-08-14 08:01:56.274633: I tensorflow/compiler/mlir/mlir_graph_optimization_pass.cc:353] MLIR V1 optimization pass is not enabled
WARNING:tensorflow:From /home/anaconda3/envs/test/lib/python3.8/site-packages/tensorflow/python/tools/strip_unused_lib.py:84: extract_sub_graph (from tensorflow.python.framework.graph_util_impl) is deprecated and will be removed in a future version.
Instructions for updating:
This API was designed for TensorFlow v1. See https://www.tensorflow.org/guide/migrate for instructions on how to migrate your code to TensorFlow v2.
scripts/benchmark_CNN.sh: line 243: 1488387 Segmentation fault

Hi @naruto-raj ,
Thanks for reaching out. I tried building and training a CNN model with TF prebuilt binary of 2.12v with Protobuf 4.24.0 version but the code executes fine with no such segmentation problem as reported. Please refer to attached gist.
Could you please check and confirm with exact code snippet with which you have tested.

Protobuf_issue.zip
Notebook to reproduce the issue. I was using optimise_for_inference api and it seems to cause the issue.

I can reproduce this issue too, using the following code (see below, it is a very simple CNN model).
It runs fine with protobuf==4.23.1 but fails with protobuf==4.24.0 (Segmentation fault).
It looks like the segfault happens before writing the .pb file (other assets like variables seems to be written).
import sys
import os

nclasses=6

def my_model(x):

  # input patches: 16x16x4
  conv1 = tf.layers.conv2d(inputs=x, filters=16, kernel_size=[5,5], padding="valid", activation=tf.nn.relu)
  pool1 = tf.layers.max_pooling2d(inputs=conv1, pool_size=[2, 2], strides=2)
  conv2 = tf.layers.conv2d(inputs=pool1, filters=16, kernel_size=[3,3], padding="valid",  activation=tf.nn.relu)
  pool2 = tf.layers.max_pooling2d(inputs=conv2, pool_size=[2, 2], strides=2)
  conv3 = tf.layers.conv2d(inputs=pool2, filters=32, kernel_size=[2,2], padding="valid",  activation=tf.nn.relu)

  # Features
  features = tf.reshape(conv3, shape=[-1, 32], name="features")

  # Neurons for classes
  estimated = tf.layers.dense(inputs=features, units=nclasses, activation=None)
  estimated_label = tf.argmax(estimated, 1, name="prediction")

  return estimated, estimated_label

""" Main """
if len(sys.argv) != 2:
  print("Usage : <output directory for SavedModel>")
  sys.exit(1)

# Create the TensorFlow graph
with tf.Graph().as_default():

  # Placeholders
  x = tf.placeholder(tf.float32, [None, None, None, 4], name="x")
  y = tf.placeholder(tf.int32  , [None, None, None, 1], name="y")
  lr = tf.placeholder_with_default(tf.constant(0.0002, dtype=tf.float32, shape=[]),  shape=[], name="lr")

  # Output
  y_estimated, y_label = my_model(x)

  # Loss function
  cost = tf.losses.sparse_softmax_cross_entropy(labels=tf.reshape(y, [-1, 1]),  logits=tf.reshape(y_estimated, [-1, nclasses]))

  # Optimizer
  optimizer = tf.train.AdamOptimizer(learning_rate=lr, name="optimizer").minimize(cost)

  # Initializer, saver, session
  init = tf.global_variables_initializer()
  saver = tf.train.Saver( max_to_keep=20 )
  sess = tf.Session()
  sess.run(init)

  # Create a SavedModel
  create_savedmodel(sess, ["x:0", "y:0"], ["features:0", "prediction:0"], sys.argv[1])


Link with button on top still triggers

Reproduction
https://github.com/WillSmithTE/remix-playground-10
https://github.com/remix-run/remix/assets/26863411/0e6cc564-e804-411f-a339-50a4f6ac1790

Open a Button which opens a Dialog (both components from shadcn). The button sits on top of a Link
The dialog opens correctly
On closing the dialog, the Link hits

I have no idea if this is a remix thing, but it works with an anchor tag. The test case looks weird but it's based on a real example, e.g. like a reddit thread where the thread is the anchor tag but the upvote button sits on top

System Info
System:
    OS: macOS 14.1
    CPU: (11) arm64 Apple M3 Pro
    Memory: 97.73 MB / 18.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.11.0 - ~/.nvm/versions/node/v20.11.0/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 10.2.4 - ~/.nvm/versions/node/v20.11.0/bin/npm
    Watchman: 2<IP_ADDRESS> - /usr/local/bin/watchman
  Browsers:
    Brave Browser: <IP_ADDRESS>
    Chrome: 121.0.6167.184
    Safari: 17.1
  npmPackages:
    @remix-run/dev: ^2.7.2 => 2.7.2
    @remix-run/express: ^2.7.2 => 2.7.2
    @remix-run/node: ^2.7.2 => 2.7.2
    @remix-run/react: ^2.7.2 => 2.7.2
    vite: ^5.1.0 => 5.1.4

Used Package Manager
npm
Expected Behavior
The Link doesn't do anything
Actual Behavior
The Link triggers after closing the dialog

Looks like improper composition, i.e. nothing to do with Remix. You put dialog as well the button inside the Link, so any interaction will trigger the link.

yeah if your button/dialog are inside the link then clicks will propagate like any other DOM event.  You probably just need to stop propagation: https://developer.mozilla.org/en-US/docs/Web/API/Event/stopPropagation

@brophdawg11 i should've mentioned, i'm stopping propagation and default in the onClick
https://github.com/WillSmithTE/remix-playground-10/blob/main/app/routes/_index.tsx#L23
just added a codesandbox
https://codesandbox.io/p/github/WillSmithTE/remix-playground-10/main?import=true

I see it in the openDialog handler, but not on the close dialog code.  I added it to a click handler on DialogPrimitive.Close and it fixes the issue?

ahhhh thanks. i exposed the radix overlay props to the shadcn dialog and can stop it that way with the onClick. thank you!
https://github.com/WillSmithTE/remix-playground-10/commit/a4549ecee34ed38d11e8794c81f62aef9f4caf73#diff-8bd8555c577836673951723e36b75ebd6b5ffbb87f0220c01a5b1149c8c7f525R42

Unsure why you insist on composing it the way you do, because it's simply incorrect, as per my original comment. You only end up getting to have to remedy it with all kind of hacks that shouldn't be necessary in the first.

can you explain more what you mean? like this?
const [showDialog, setShowDialog] = useState(false);
return (

      <Link to="/blog" className="p-20 bg-blue-600">
        <Button onClick={openDialog} variant="outline">
          Edit Profile
        </Button>
    </Link>
    <Dialog open={showDialog} onOpenChange={setShowDialog}>
          <DialogContent
            className="sm:max-w-[425px]"
            overlayProps={{
              onClick: (e) => {
                e.stopPropagation();
                setShowDialog(false);
              },
            }}
          >
            <DialogHeader>
              <DialogTitle>Edit profile</DialogTitle>
              <DialogDescription>
                Make changes to your profile here. Click save when you're done.
              </DialogDescription>
            </DialogHeader>

some stuff

            <DialogFooter>
              <Button type="submit">Save changes</Button>
            </DialogFooter>
          </DialogContent>
        </Dialog>

  );

avoid nesting interactable elements as you have originally, especially if they have different intents

this would be nice, but i'm not going to change the UI to suit the tech. it's a pretty common pattern, e.g. see the reddit screenshot from the original post
For the dialog, i did experiment with moving it outside the Link, but the Button and Link are separated by 2 levels of component heirarchy. i don't want to pass a bunch of props around, and this button is also in various places. it "owns" the dialog, so it feels right to have it in the same place.
i also experimented with a "global" dialog triggered by a hook shared through the whole app, but i don't love that, and i still have to stopPropagation onClick anyway, just not onClose then, so i don't think the tradeoff is worthwhile. it's not like the dialog is within the anchor in the dom anyway because of the portal

this would be nice, but i'm not going to change the UI to suit the tech. it's a pretty common pattern, e.g. see the reddit screenshot from the original post

This is what you are trying to do, i.e. placing a button that does one thing (opening a dialog) inside a link that does entirely something else (navigate to a url) and then for some reason trying to prevent the link from doing something in certain situation. It has nothing to do with Remix or React for that matter.
https://jsitor.com/_4esuHO2uS
It's hard to tell what's happening from the screenshot since we don't know how the HTML is composed, but I am confident they don't have the buttons insides anchors.

For the dialog, i did experiment with moving it outside the Link, but the Button and Link are separated by 2 levels of component heirarchy. i don't want to pass a bunch of props around, and this button is also in various places. it "owns" the dialog, so it feels right to have it in the same place.

Not knowing what kind of props you are trying to pass around and why makes it difficult to recommend something, it does however seem like you should rethink the architecture of your React components (again, nothing to do with Remix).
At the end of the day it's up to you how you compose your application. So I will leave it at that.


Fixed wrong working directory in cocoapods.error_callback call

Checklist

[x] I've run bundle exec rspec from the root directory to see all new and existing tests pass
[x] I've followed the fastlane code style and run bundle exec rubocop -a to ensure the code style is valid
[x] I've read the Contribution Guidelines
[x] I've updated the documentation if necessary.

Motivation and Context
See the issue: https://github.com/fastlane/fastlane/issues/10308
Description
I'm just changing directory to default fastlane folder before calling error_callback. Also I'm not sure: maybe it should be fixed at global level in sh_helper.rb:sh_control_output method?

I signed it!

@ohayon Thanks for review! Just fixed the issue.

Thanks @SiarheiFedartsou !! 🚀 !!


Finish API and stuff

I suggest we deprecate update_log and get_session_key because it doesn't make sense on TLSv1.3 when (1) there are multiple sessions, and (2) OpenSSL keylog callback will be used instead of extracting session key manually. I think users should stick to the hook_ API. WDYT?
I've also added a hook_socket function that hooks a single socket (for cases not covered by server or agent) and hook_all which hooks TLSSocket constructor to hook all sockets, ever. It patches an internal function, so if you don't agree I'll exclude that from the PR.
The rest is just pending things (tests, examples, README, changelog, add warning for Node.JS version), I think I'm not forgetting anything.

Thanks! I'll check everything later today. So far sounds good.

Thanks :)

Thanks for the code (I'm especially glad to see more tests and docs!).

It patches an internal function, so if you don't agree I'll exclude that from the PR.

No problem, because it's "developer's tool". It's good that it's mentioned in README.

I suggest we deprecate update_log and get_session_key because it doesn't make sense on TLSv1.3 when (1) there are multiple sessions, and (2) OpenSSL keylog callback will be used instead of extracting session key manually.

We'll never have OpenSSL keylog callback available in Node 10.x, and 10.x is LTS, so it's important to support compatibility - which means we'll have to use some form of get_session_key internally anyway (but it can be hidden by our API for consistency). Isn't it too early to deprecate it? Let's think again about deprecation during implementing support for TLS 1.3; may be it will become more obvious - because we'll have to keep compatibility with TLS 1.2 as well..
I like idea of hook* API, it makes things a lot simpler. Also, let's switch to camelCase for new API (leaving c_style_function_names as aliases, if required). Should look more familiar for Node programmers.
Also, I think that with new API we need some way to allow user to set own handler for logging secrets (for example, to keep only chosen secrets on a high-load server). I didn't yet think enough how to implement in simple/consistent way. May be optional second argument to hook* (user-specified handler). May be something else. Suggestions are welcome.

Totally agree with switching to camelCase!

We'll never have OpenSSL keylog callback available in Node 10.x, and 10.x is LTS, so it's important to support compatibility - which means we'll have to use some form of get_session_key internally anyway (but it can be hidden by our API for consistency). Isn't it too early to deprecate it? Let's think again about deprecation during implementing support for TLS 1.3; may be it will become more obvious - because we'll have to keep compatibility with TLS 1.2 as well..

Yes, what I meant by deprecating set_update_log was just hiding it from the public API. It'll still be used internally, of course, because we need to provide compatibility with Node < 11.10. But if users switch to the hook* API, we can implement TLSv1.3 support transparently in a future release.

Also, I think it'd be good to call appendFile instead of the sync version, so we don't block the event loop.
Appends are atomic, so it makes no harm to begin another append when one hasn't finished. The only risk is keylog lines ending  up in different order, but this shouldn't matter to Wireshark (every index is unique).

About letting the user provide his own handler, I'd vote on leaving that to be implemented in future releases (as an optional second parameter to hook* as you said).

Do I understand correctly that you suggest to remove get_session_key() from exports and from documentation, without providing an alternative? Why? This will restrict user from implementing his own logic for key logging - which can be important on high-load server.
About appendFile - I agree that it would be better than appendFileSync, so let's do it. Actually, I don't really care about performance of update_log because it was meant to serve as example; that's why README shows full usage of get_session_key and then just mentions update_log. In real life you would not want to open/close file on every call (like appendFile[Sync] does), and you'll probably want to implement some buffering.. But changing it to async version would not harm, of course :)
About cameCase - glad that we agree.

Hi, do you think we should merge this? I think that it would be better to integrate polyfill first (which already includes hook* functions), then merge things from this PR (especially docs), and then I review everything again and will publish npm. Also, if you don't object, I'd like to add you to README as co-author - you contributed a LOT of important code, thanks!

I agree, let's merge pollyfill first :)

Back to this! A lot of things no longer apply, so I've made the commits again.
If I understood correctly from #9, we're now moving in the direction of the polyfill. So, I have:

Rewritten index.js to implement the hook* API without depending on the native module
Removed update_log and get_session_key, and removed 'basic' test
Skipped building native module if not needed

Other things:

Added extra tests, and modified the code to mark TLSv1.3 test as skipped (as said in #4)
Renamed the API to camelCase (as discussed above)
Added documentation about how to use this module as a polyfill.

Seems good! Thank you a lot. I'm going to publish npm today/tomorrow after additional review; I think now it deserves to be 1.0.0 version because of API breaking changes and a huge rework.

Yeah, I agree :)


x/website: "Advanced Go Concurrency Patterns"

At this link https://go.dev/doc/ section "Advanced Go Concurrency Patterns", the content of YouTube video (year 2013 is too old, current year is 2023), should remove it or update it.
redirect to https://www.youtube.com/watch?v=QDDwwePbDtw&ab_channel=GoogleDevelopers

what about the content is old?

for {
	if s.closed {
		close(s.updates)
		return
	}
	items, next, err := s.fetcher.Fetch()
	if err != nil {
		s.err = err
		time.Sleep(10 * time.Second)
		continue
	}

	for _, item := range items {
		s.updates <- item
	}

	if now := time.Now(); next.After(now){
		time.Sleep(next.Sub(now))
	}
}

working as intended


fix typo in spinnaker

What this PR does / why we need it:
Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Special notes for your reviewer:

/ok-to-test
/lgtm

/retest

/retest

@mattfarina  E2E test timeout . Is this environment problem? Help to confirm. Thanks :)

/retest

retest

/retest


gyp configure error

any help please?
i followed this https://github.com/nodejs/node-gyp but im stuck
i need help please !!!!!

You need to run node-gyp configure in the directory in which the project you are trying to build is (i.e. where a binding.gyp file is, that’s what the error message here complains about).
This is not a bug, and not a problem with node-gyp itself, so I’m closing this, and I would suggest to re-open this as an issue on nodejs/help instead (but please try to give a bit more information about what you’re trying to do).


Iroha schema doesn't take into account serde transparent structures.

There is a bug with both Metadata and EvaluatesTo classes in Iroha python. The schema should expose all necessary info for client API generation.

Upon further investigation, it has been determined that the problem with serde transparent structures in the Iroha Python schema has been addressed manually. Upon further review, we believe that the underlying concerns about the Iroha schema, particularly with the serde transparent structures in Python, can be holistically addressed by the more comprehensive improvements proposed in Issue #3535. The latter issue aims to enhance the clarity and explicitness of the data-model schema, which will, in turn, make it easier for developers to work with the schema and reduce the likelihood of similar problems arising in the future.


Add test for rendering a component with text nodes

The implementation of h suggests that textual children of components should not be merged. However, there is no test coverage of this behavior. So I added some!
Is that actually the case? And if so, why are text nodes of components not merged?

Coverage remained the same at 100.0% when pulling e53e306125e18da15b46c6c756abba6b1382e501 on braddunbar:h-component-test into e5c7f1df40501597990d636b018f916e81e26700 on developit:master.

This changed in 8. I'm actually wondering if we could bring back at least some of the behavior (assuming perf & size don't bloat as a result), since your other issue (foo {0} -> ["foo ", 0]) is kinda awkward to work around.  We need to gather some input, and maybe check what React does in this case.  I looked into this a while back and I believe they just pass children through without any normalization, which is why I made that switch in 8.

Coverage remained the same at 100.0% when pulling 02f98c556964d7e18c0f69fe5ae20a7ad5106165 on braddunbar:h-component-test into 5d6a2c4cacd17fbe0bba9c9aecaaa32544046ca9 on developit:master.

👍👍


Check install process

I've been working with @sc0tts on packaging Permamodel, so I thought I'd check the install process here. And, oops, it was broken! I was trying to be clever and get version information from the package definition file, but in af066cd7d3afdedc62ace5dc39d7aca54084c2fe, I added an import from bmi_dakota, which includes an import from basic_modeling_interface, which may not be installed at the point where the version information is used in setup.py. So, this motivated the series of minor updates in this PR.

Coverage decreased (-0.001%) to 97.056% when pulling bda210767534e1650c52eb02fabc1babdc1d4fc3 on mdpiper/check-install-process into eb605f713e9f1c7e55a41b8d098af0b393a35b25 on master.