Add 'notes' feature flag; move Timeline to its own tab

Context
In preparation for adding the 'Provider user adds notes against an application choice' flow, we need to move the Timeline to its own tab/view and add a notes feature flag.
Changes proposed in this pull request
This PR refactors provider_interface/application_choices_controller.rb and associated views to use:

a separate view for the timeline component,
a common _application_choice_header.html partial, for banners, status tags and newly introduced SubNavigationComponent, and
a controller before_action setting @application_choice and @sub_navigation_items

Page title and breadcrumbs are still set within the corresponding views. The before_action checks notes and timeline feature flags, so it's possible for the single application view to look like this:

Guidance to review

Should I have created a new notes_controller.rb? I thought about it, but notes will only be attached to application_choices and it's easier to reuse controller code and partials across the three views/tabs ([Application, Notes, Timeline]) if they are all part of application_choices_controller. Furthermore, if we decide to attach notes to other things, chances are the relevant views will be custom to these contexts, so a scoped pattern like .../application_choices/1970/notes makes sense.
Do the adjusted page titles and breadcrumbs make sense? I've kept the Application title and breadcrumbs the same, but 'Notes' or 'Timeline' are appended to both title and breadcrumbs when a provider user navigates to these views (see image).

Link to Trello card
https://trello.com/c/mscEDZr5
Things to check

[x] This code doesn't rely on migrations in the same Pull Request
[x] If this code includes a migration adding or changing columns, it also backfills existing records for consistency
[x] API release notes have been updated if necessary
[x] New environment variables have been added to the Azure config

@mnacos looks like the alignment is off between the contents of timeline tab and the timeline content itself.

@mnacos looks like the alignment is off between the contents of timeline tab and the timeline content itself. The timeline doesn't need to be wrapped in a govuk-grid-row :)

Fixed, thanks for spotting.


Add Norde Source to category Icons Tools

Checklist

[x] I made something good today 💐.
[x] I put links in the correct format: [Tool](link) — description.
[x] My description starts with the lower-case letter and ends with the full stop.
[x] I put the tool in the alphabetical order.

Optional

[x] I added the appropriate labels: free, open-source or mac.
[x] I put the tool only to one category.
[x] I followed Contribution Guidelines.

thanks, @gillisig for submitting!

And thank you @LisaDziuba for maintaining this list :)


Reverting removal of HTML tag in this test.

As per discussion elsewhere. Putting this back so then we can a release out 👍 . Let me know when it's up on NuGet so I can update my proj to latest. Ta.

Thanks added to the contributions section of the home page:


Typescript Apollo Next Fullstack

This will be a fullstack implementation of real world app -- backend in Apollo server and frontend in Next Apollo. The language chosen is Typescript.
Status
https://github.com/abs-zero/typescript-apollo-next-fullstack-realworld-example-app

[x] :checkered_flag: Fork the starter repo & post the link in this issue
[ ] :art: Create logo for repo & update issue status (@EricSimons)
[ ] :hammer: Implement all of Conduit's functionality per the spec & API
[ ] :eyes: Move repo to main org & Peer review final codebase by admins/community (RFC)
[ ] :tada: Tag v1 release and officially list it on the README!

Hello we are currently moving all work in progress to Github Discussions.
I'll close this issue by now, you can find instruction to open a discussion there : https://github.com/gothinkster/realworld/discussions/633
Thanks for your contribution !


Synctos compatibility with sync-gateway-adminui

Hi Folks,
So after the latest fix, I am able to upload the sync function through admin ui but looks like the admin ui code is completely unstable.
After adding few docs I refreshed the admin console. It try to rerun the sync-function on page refresh and throws error around immutable fields saying onChange failed because of sync function rejection to update immutable fields. This is weird because i am not even making an update call, I am just refreshing the page.
How do you guys deploy sync function in production, and how do you test it? Is there a way to stay away from this admin UI console?

There's not much that synctos can do to deal with glitchy behaviour in the Sync Gateway admin UI. As I noted in issue #116, the admin UI web app does not seem to be well supported by Couchbase at this point. However, based on the description of your problem, it seems likely that the admin UI is automatically creating/updating a document every time the view is loaded, which apparently doesn't play well with synctos' support for immutable documents and fields. If you are determined to use the admin UI, then as an alternative, you might try removing the immutable, cannotReplace and cannotDelete constraints from your document types and instead make each of the affected document types' fields immutable, or perhaps better yet, immutableWhenSet, to prevent modifications while allowing the admin UI to continue functioning. Alternatively, you might try using curl or Postman to construct the Sync Gateway API document PUT and DELETE calls.
With regards to testing sync functions generated by synctos, the built in test-helper module is the tool of choice. I suggest reading the Testing section of the README for help getting started.
As for deployment, we at Kashoo store our document definitions in a Git repo and we have internal scripts that invoke synctos to generate sync functions from those document definitions and then inject them into a Sync Gateway configuration file. Starting in staging, we perform functional testing on the updated Sync Gateway configuration by exercising our web and mobile apps and then deploy the configuration file to production if that goes well. Every time we need to make changes to our "schema", we modify the underlying document definitions and then repeat the process.

Thanks a lot for the explanation @OldSneerJaw.


refactor: icon to icons for controls

SUMMARY
This pr migrates the old icon components to icons  in the datasource panel, datelabel and collection control.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS
All three of these controls can be tested in a filterbox chart. The icons that were migrated are labeled above.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Includes DB Migration (follow approval process in SIP-59)

[ ] Migration is atomic, supports rollback & is backwards-compatible
[ ] Confirm DB migration upgrade and downgrade tested
[ ] Runtime estimates and downtime expectations provided

[ ] Introduces new feature or API
[ ] Removes existing feature or API

/testenv up

I think the question of whether or not we should render the relevant icon for the particular dataset is an interesting one. I can see both sides of the argument.
However this is not the intent of this PR! And it's clearly a bit contentious. We're waging a war to migrate to a new component, and this PR hits the mark. I agree the change we're discussing is worth the discussion... but maybe we should do that on an Issue/slack/zoom/etc, and open a separate PR if we want to pursue it after further discussion.
Merging this one for now... baby steps :D


Use the OS_KERNEL_CMDLINE from meta-balena to ensure cursor is not present on hdmi

meta-balena added this variable in https://github.com/balena-os/meta-balena/pull/1465 , which we need to integrate here.

[shaunmulligan] This issue has attached support thread https://jel.ly.fish/#/support-thread~51e9fa5a-5b15-4a8c-9757-ac7754dcc2e7


appeals(test/e2e): refactor time selectors

Describe your changes
Refactor to reduce the amount of duplicate code in the dateTimeSection.js page object
I've re-run all the e2e tests and they're passing
Type of change 🧩

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update
[x] Other (please explain in the description section above)

Checklist before requesting a review

[x] I have performed a self-review of my own code
[x] I have double checked this work does not include any hardcoded secrets or passwords
[ ] I have made corresponding changes to the documentation
[x] I have provided details on how I have tested my code
[ ] I have referenced the ticket number above
[ ] I have provided a description of the ticket
[ ] I have included unit tests to cover any testable code changes

Do we still want to get this in? I think the only problem here is the commit message format


e_day_imp without value

Hi,
I have a GW3600-EH inverter and all the entities are properly popullated, but the e_day_imp does not. I mainly use the library directly on HomeAssistant, but I also tried it as standalone.
Is there any way to find why this happens? How can I share with you more data to debug this?
Thanks!

There's nothing to fix, values are just taken from inverter registers.
However the e_day_imp is most likely not the value you think it is.
AFAIK, it does not represent daily import from grid (measured by meter), but daily import of inverter to its system, i.e. amount of imported grid energy stored into battery.
Fro the real grid import, there is no daily sensor, only the meter_e_total_imp


ValueError: Batch does not contain any data (None). At the end of all iterable data available before expected stop iteration.

Hey @loubnabnl,
Thanks for this repo - I've learned a lot from what you implemented here.
 At the end of all iterable data available before expected stop iteration.

I hit this error when I pass through the 0.1 mark of the epoch:
{'loss': 0.2896, 'learning_rate': 4.9e-05, 'epoch': 0.1}
{'loss': 0.2095, 'learning_rate': 4.9500000000000004e-05, 'epoch': 0.1}
{'loss': 0.291, 'learning_rate': 5e-05, 'epoch': 0.1}
Traceback (most recent call last):
  File "../santacoder-finetuning/train.py", line 289, in <module>

  File "../santacoder-finetuning/train.py", line 279, in main
    run_training(args, train_dataset, eval_dataset)
  File "../santacoder-finetuning/train.py", line 268, in run_training
    trainer.train()
  File " /lib/python3.10/site-packages/transformers/trainer.py", line 1556, in train
    return inner_training_loop(
  File " /lib/python3.10/site-packages/transformers/trainer.py", line 1930, in _inner_training_loop
    self._maybe_log_save_evaluate(tr_loss, model, trial, epoch, ignore_keys_for_eval)
  File " /lib/python3.10/site-packages/transformers/trainer.py", line 2257, in _maybe_log_save_evaluate
    metrics = self.evaluate(ignore_keys=ignore_keys_for_eval)
  File " /lib/python3.10/site-packages/transformers/trainer.py", line 2982, in evaluate
    output = eval_loop(
  File " /lib/python3.10/site-packages/transformers/trainer.py", line 3161, in evaluation_loop
    for step, inputs in enumerate(dataloader):
  File " /lib/python3.10/site-packages/accelerate/data_loader.py", line 582, in __iter__
    raise ValueError(
ValueError: Batch does not contain any data (`None`). At the end of all iterable data available before expected stop iteration.

My dataset train and test is small and looks like this:
Size of the train set: 295. Size of the validation set: 2
 74%|█████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████▉                                                 | 295/400 [00:00<00:00, 452.00it/s]
The character to token ratio of the dataset is: 3.90

Do you have any thoughts here what I need to do to adjust the training loop?  Is it because my train set is too small?
Thanks!
Adam

This means you have a smaller training dataset than what would be 1000 batches, which makes sense since your training set is only 295 items. You should set --max_steps to be less

Thanks @muellerzr  for your quick response... so you you think this looks more optimal below:
        --data_column "content" \
        --split="train" \
        --seq_length 2048 \
        --max_steps 100 \
        --batch_size 2 \
        --gradient_accumulation_steps 4 \
        --learning_rate 5e-5 \
        --num_warmup_steps 10 \
        --eval_freq 10 \
        --save_freq 10 \
        --log_freq 1 \
        --bf16 \
        --fim_rate 0.5 \
        --fim_spm_rate 0.5

I kept batch_size=2, but when I decreased the max_steps=100 it still fails with the same error.  Is that what you meant, lower the max_steps number to a lower value than total train samples?

Well.... I just ran it, and it looks like it went fine for this dataset.  It is very strange.  I don't understand why it went just fine for this dataset and not mine.
        --model_path="bigcode/santacoder" \
        --dataset_name="bigcode/the-stack-dedup" \
        --subset="data/python" \
		--output_dir "./checkpoints/santacoder-the-stack-dedup-python-debug-298-samples" \
        --data_column "content" \
        --split="train[0:298]" \
        --seq_length 2048 \
        --max_steps 1000 \
        --batch_size 2 \
        --gradient_accumulation_steps 8 \
        --learning_rate 5e-5 \
        --num_warmup_steps 10 \
        --eval_freq 100 \
        --save_freq 100 \
        --log_freq 1 \
        --bf16 \
        --fim_rate 0.5 \
        --fim_spm_rate 0.5

do you have any words of wisdom on this?  is there any way to unit test this piece with my data so i can understand the root case.  I do not understand why the batch is None when it gets to your updated code adjustment.


Skill Name
LlamaIndex
Why?
Framework for building LLM applications.
Website Link
Reference Image

Code of Conduct Acknowledgment

[X] I have read and agree to the Code of Conduct.

https://github.com/LelouchFR/skill-icons/blob/main/assets/llamaindex-auto.svg

@LuluW8071 llamaindex is already in the project, I think there is only missing in the readme, strange, going to look into that, but still, the icon is useable, try things out before opening an issue, thanks :)


[Feature Request] Test browser notification on Realtime Stream

It would be useful to have a button to trigger a test notification on https://steamdb.info/realtime/, ideally with a few seconds delay after clicking it.
I wanted to see how these notifications work on my phone, but I see no way of doing this -- other than of course waiting for some Watched app update, and praying that a notification will actually work on my device.

Notifications definitely won't work on mobile phone due to browser limitations.

I have added a button to test notifications and extra checks.

Woah, you're fast, thanks a lot!
And so bigger changes making it into a ServiceWorker notification would be needed then for mobile support (this demo for example works on mobile)? Hope that can happen in future, for mobile notifications, but thanks again for the test button :)

I have added serviceworker notifications. Do keep in mind that the websocket has to be alive for update to come through and notification to appear.


rustler::resource! no longer warning-free with 1.83

warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item
  --> src/zip.rs:22:5
   |
21 | pub fn load(env: Env, _: Term) -> bool {
   | -------------------------------------- move the `impl` block outside of this function `load`
22 |     rustler::resource!(WriterResource, env);
   |     ^^^^^^^^^^^^^^^^^^^--------------^^^^^^
   |     |                  |
   |     |                  `WriterResource` is not local
   |     `ResourceTypeProvider` is not local
   |
   = note: the macro `rustler::resource` defines the non-local `impl`, and may need to be changed
   = note: the macro `rustler::resource` may come from an old version of the `rustler` crate, try updating your dependency with `cargo update -p rustler`
   = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl`
   = note: `#[warn(non_local_definitions)]` on by default
   = note: this warning originates in the macro `rustler::resource` (in Nightly builds, run with -Z macro-backtrace for more info)

The macro likely should be deprecated and a new version added to define a function and the top-level impl block separately.

There is already a solution for this since 0.34, see https://github.com/rusterlium/rustler/blob/master/UPGRADE.md#033---034.


[GTPU] GTP-U support

Hi,
I'm trying set up a controller for GTP-U traffic but when running ryu-manager tunnel_gtpu.py I'm facing with the following error:
TunnelGTPU: Exception occurred during handler processing. Backtrace from offending handler [switch_features_handler] servicing event [EventOFPSwitchFeatures] follows. Traceback (most recent call last):   File "/home/user/.local/lib/python2.7/site-packages/ryu/base/app_manager.py", line 290, in _event_loop     handler(ev)   File "/home/user/ryu-lagopus-ext/ryu/app/tunnel_gtpu.py", line 21, in switch_features_handler     type_eth  = (ofp.OFPHTN_ONF << 16) | ofp.OFPHTO_ETHERNET AttributeError: 'module' object has no attribute 'OFPHTN_ONF'
OFPHTN_ONF is defined in ofproto_v1_5.py but this controller is using ofproto_v1_3.py. If I force the controller to use ofproto_v1_5 instead of ofproto_v1_3, there are no compatible versions between them:
no compatible version found: switch versions set([4]) controller version 0x6, the negotiated version is 0x4, but no usable version found. If possi ble, set the switch to use one of OF version [6] on datapath ('<IP_ADDRESS>', 46702)
Any suggestion about how to handle this situation?
Regards,
Ginés.

Ok, I've finally solve the issue. Althought in the readme of https://github.com/lagopus/ryu-lagopus-ext the option of installing ryu via pip is proposed,  you must to install it by using the setup.py file in order to have all the extended files correctly loaded.


Skype background blur no longer works

Describe the bug
Skype for linux provides an option to blur the webcam background. This used to work in previous versions but now it doesn't work (the relevant button is greyed out, nothing happens). Flatpak Skype does not have this issue and works correctly.

Skype (nix) version: <IP_ADDRESS>
Skype (flatpak) version: <IP_ADDRESS>

Steps To Reproduce
Steps to reproduce the behavior:

Open Skype
Go to Tools -> Audio & Video Settings...
Try to activate "blur my background" under Camera

Expected behavior
Background blur should be working.
Screenshots
N/A
Additional context
N/A
Notify maintainers
@panaeon @jraygauthier
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.15.2, NixOS, 21.11 (Porcupine)`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.5pre20211007_844dd90`
 - channels(bogdb): `"nixos-21.11pre292520.540dccb2aea"`
 - channels(root): `"nixos-21.11pre331460.931ab058daa"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixos`

[user@system:~]$ neofetch
OS: NixOS 21.11 (Porcupine) x86_64
Host: X570 AORUS MASTER -CF
Kernel: 5.15.2
Uptime: 22 mins
Packages: 1675 (nix-system), 5190 (nix-user), 2 (nix-default), 11 (flatpak)
Shell: bash 5.1.8
Resolution: 2560x1440, 3840x2160
DE: LXQt 1.0.0
WM: i3
Theme: Materia-dark-compact [GTK2/3]
Icons: oxygen [GTK2/3]
Terminal: tilix
CPU: AMD Ryzen 9 5950X (32) @ 3.400GHz
GPU: AMD ATI Radeon RX 5600 OEM/5600 XT / 5700/5700 XT
Memory: 4683MiB / 64306MiB

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
# a list of nixos modules affected by the problem
module: skype

@foolnotion : Please try latest <IP_ADDRESS>. Background blur worked fine for me with this version.

@jraygauthier Thanks, background blur works again with <IP_ADDRESS>.

Happy that it helped ;)


Crouton translucent status bar position.

Hello i am using translucent statusbar in my app without using fitsSystemBar.
I am using system tint bar lib for adding top padding to android.R.id.content, but Crouton place under actionbar + this padding. This is screenshot

See README for further info.


Add templateOverride field to override the default workflowTemplate

Description
This PR adds a new field templateOverride to TinkerbellMachine CRD to override the default CAPT workflow template https://github.com/tinkerbell/cluster-api-provider-tinkerbell/blob/main/internal/templates/templates.go#L56-L122
Why is this needed
Currently, the workflow template for Tinkerbell machines is hardcoded and there isn't a way to provide a custom template. If a user wants to provide a customized template with different actions, CAPT currently doesn't provide a way to do that.
How Has This Been Tested?
Tested the changes by passing a custom template using the templateOverride field and verified that the custom template works properly and provisions a CAPT cluster.
I tested the changes on bare-metal nodes and added some custom actions along with the default ones in the template.
How are existing users impacted? What migration steps/scripts do we need?
This change doesn't impact existing users. The templateOverride field is optional and if a user doesn't specify it, the default CAPT template is used instead.
Checklist:
I have:

[ ] updated the documentation and/or roadmap (if required)
[ ] added unit or e2e tests
[ ] provided instructions on how to upgrade

Thank you for submitting this PR and apologies for the long turnaround on review my github notifications are a bit of a mess right now 😬.
Outside of the comments I made on the PR I do have a few other questions, mostly about how you believe this feature would be used in practice.

Would you expect it be common for users to want to override the template on only a subset of Machines, or would it also be likely for users to want to override the template for all Machines in a given Cluster?
Do you see this as more of a full rip/replace of the created template, or do you think users would likely want to add additional actions at pre-defined extension points (for example additionalVolumes, preStreamImage, postStreamImage, preKexec, etc)?

Hi @detiber, thanks for the review!

That will depend on the use case. Users may want to have different template actions for control plane and worker nodes so having that flexibility would be nice. For example, users may want to mount custom certificates for private registry just in the worker nodes so their workloads can pull the images from it.
My plan for this change was to give users the ability to replace this whole template entirely with their own custom templates. The default template is nice for say POC but power users may want to configure more things

additional actions at pre-defined extension points (for example additionalVolumes, preStreamImage, postStreamImage, preKexec, etc)

I was thinking of initially doing that but there are also some other things that users may want to change in the default template as well like use image2disk to stream the image instead of oci2disk.
So, with templateOverride, they can provide the entire template itself where they will be able to add custom actions
as well as customize the default actions.
Also, I have made it so that templateOverride is optional and if a user does not want to mess around with it, they can just leave it and CAPT would work the same way as it did before

@Mergifyio refresh


Nuxt generator release

API Platform version(s) affected: any
Description:
There is documentation added for Nuxt generator in the official API Platform docs and there are code changes in the repository from a few weeks. When is this going to be released for use since the documentation says it can already be used, but it actually can't be?
How to reproduce:
npx @api-platform/client-generator --generator nuxt http://webserver/api src/
Results in:
(0 , _generators.default)(...) is not a function

Thanks for reporting @v-radev, this should be fixed now

Awesome, thank you for the quick response.

@alOneh When can you start using it?
Get this error message with this cmd
npx @api-platform/client-generator --generator nuxt  https://localhost:8443 .
var generator = (0, _generators["default"])(_commander["default"].generator)({
                                                                            ^

TypeError: (0 , _generators.default)(...) is not a function


Isolate potential NFT loading exceptions

Sometimes loading an individual NFT in My Mints will thrown an exception; this PR ensures that the rest of the NFTs can load properly.

Instead of this I think the change should be made on the repository code to return null instead of throwing

Or return a better data structure representing the issue that occured in the repo and then the view model can appropriately handle the error or ignore in this case


[SPARK-18617][CORE][STREAMING] Close "kryo auto pick" feature for Spark Streaming

What changes were proposed in this pull request?
#15992 provided a solution to fix the bug, i.e. receiver data can not be deserialized properly. As @zsxwing said, it is a critical bug, but we should not break APIs between maintenance releases. It may be a rational choice to close auto pick kryo serializer for Spark Streaming in the first step. I will continue #15992 to optimize the solution.
How was this patch tested?
existing ut

Test build #69300 has started for PR 16052 at commit e4416bd.

cc @zsxwing

Test build #69300 has finished for PR 16052 at commit e4416bd.

This patch fails to build.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69300/
Test FAILed.

Test build #69303 has started for PR 16052 at commit d205ebd.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69303/
Test FAILed.

Test build #69323 has started for PR 16052 at commit cd7e595.

Test build #69323 has finished for PR 16052 at commit cd7e595.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69323/
Test PASSed.

@uncleGen Could you add the following test to StreamingContextSuite? Otherwise, LGTM.
  test("SPARK-18560 Receiver data should be deserialized properly.") {
    // Start a two nodes cluster, so receiver will use one node, and Spark jobs will use the
    // other one. Then Spark jobs need to fetch remote blocks and it will trigger SPARK-18560.
    val conf = new SparkConf().setMaster("local-cluster[2,1,1024]").setAppName(appName)
    sc = new SparkContext(conf)
    ssc = new StreamingContext(sc, Milliseconds(100))
    val input = ssc.receiverStream(new TestReceiver)
    input.count().foreachRDD { rdd =>
      // Make sure we can read from BlockRDD
      if (rdd.collect().headOption.getOrElse(0L) > 0) {
        // Stop StreamingContext to unblock "awaitTerminationOrTimeout"
        new Thread() {
          setDaemon(true)
          override def run(): Unit = {
            ssc.stop(stopSparkContext = true, stopGracefully = true)
          }
        }.start()
      }
    }
    ssc.start()
    ssc.awaitTerminationOrTimeout(60000)
  }

OK

Test build #69380 has started for PR 16052 at commit 39b4867.

Test build #69380 has finished for PR 16052 at commit 39b4867.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
class FakeByteArrayReceiver extends Receiver[Array[Byte]](StorageLevel.MEMORY_ONLY) with Logging

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/69380/
Test PASSed.

Merging in master/branch-2.1.

This doesn't merge cleanly into branch-2.0. @uncleGen can you submit a pull request for branch-2.0?

@rxin OK, I will backport it to branch-2.0


Test request: IONOS Dedicated Servers

Test request: IONOS Dedicated Servers
Most options have 2 SATA disks.
https://www.ionos.com/servers/dedicated-servers
recovery console info, linux-based
https://www.ionos.com/help/server-cloud-infrastructure/server-administration-dedicated-servers/booting-the-dedicated-server-to-the-linux-rescue-system/
older recovery console info, linux-based
https://www.ionos.com/help/server-cloud-infrastructure/dedicated-server-for-servers-purchased-before-102818/rescue-and-recovery/working-with-the-linux-rescue-system/

Minimum contract term 24 months


Latest release broke compatibility with solidus_social

Not sure which gem needs a fix because I haven't found the problem yet.

I'm suspecting it has something to do with the major bump to Devise.

If solidus_social is incompatible with the latest devise that should be declared there. I also don't think the issues there are related to devise or solidus_auth_devise.


Fix spelling in readme

@timoniq r

No, thank you. Your PR changes some parts that are already okay.

;-;

No, thank you. Your PR changes some parts that are already okay.

A most fast?

No, thank you. Your PR changes some parts that are already okay.

A most fast?

It is.

@prostomarkeloff hey!

@prostomarkeloff hey!


Scalability FAQs

Pete's answer to question in Google Group:
Hi Dorian,
On Sun, Jun 12, 2016 at 11:17 AM, Dorian Hoxha<EMAIL_ADDRESS>wrote:
So::
1. max number of nodes in a cluster (ex: rethinkdb supports up to ideally 20)

CockroachDB is designed to scale to hundreds and even thousands of nodes. In practice, 10s of nodes is more realistic at this time. We're working hard at making larger clusters work smoothly.

1.1. Does the scalability increase by 1 with each node (assuming even usage on all ranges) or something <1 like in postgresql-xl ?

The scalability depends on your workload, but the short answer is that you're going to see <1 performance increase for each additional node if you have any sort of realistic schema with multiple tables and indexes. I don't have a more concrete answer for you at this time, but agree it would be good to provide guidance here.

2. max storage per node (some kind of limit on the lower storage layer, ex like pg has)

Postgres has a limit on the disk storage it will use? There is no hardcoded limit in CockroachDB.

3. max rows/kv per node/range/table

There is no limit on the number of rows/kvs per node or table. Ranges hold up to 64MB of row/kv data, but will split automatically. The 64MB size is configurable, but you shouldn't set it larger right now as larger ranges have some problems which we're working to resolve (i.e. certain operations use memory proportional to the range size). This also implies that row/kv data should be significantly smaller than a range.

4. max number of columns in a table (ex: we store column-id as 1-byte so 256 max or something similar)

There is no hardcoded limit. Column IDs are 32-bit variable length encoded integers.

5. max number of tables (ex: more than x tables it's an antipattern since each table has overhead in ram)

There is no hardcoded limit, though each table will consume a small amount of memory (a few KB) on every node.

6. max number of ranges (each range has overhead, does each node know the position of each range, or only range.ranges?)

There is no hardcoded limit. The range indexing information is cached on demand. The design here is similar to BigTable/HBase and is intended to scale to very large numbers of ranges.

These I think should also be in the faq/docs ?

 Agreed that the above should be in faq/docs.

Added to forum: https://forum.cockroachlabs.com/t/scalability-questions/57

Closing in favor of https://github.com/cockroachdb/docs/issues/1830.


[485638]: Vector Functionality Implementation

Sub comment added and commits were squashed.

Hu @TomasJani, pls check your travis, it is passing but with 0 tests being executed.

Hi @TomasJani, pls check your Travis, it is passing but with 0 tests being executed.

It should be fine now.


Feature/palette

Colors Library for calculating and storing colors so you can easily access them in your project.
The library comes with 8 different colors; white, black, red, green, blue, yellow, cyan, and magenta.
Getting a color from the Palette is as easy as getting an asset with the Utils api. For example:
Colors.get('white')
If your want your white color to have some opacity / alpha your can use the following:
Colors.get('white', 0.4)
The other options to modify your color are, lighten and darken. For example:
Colors.get('white', {darken: 0.3})
If you want to darken AND alpha you can use:
Colors.get('white', {darken: 0.3, alpha: 0.3})
Customizing
If you wish to store and use your own colors you can use the following function:
Colors.add({     focus: '#444444',     background: '#222222' });
Mixing
You can also mix to different colors:
Colors.mix('white', 'black', 0.5)

Reopening since the PR was closed by accident when deleting the dev branch 😀


69 - first implementation of relationships

I would suggest some changes

Renaming:
CommonRelationship --> ERDRelationship
GraphNodesRelationships --> GraphRelationships
begin --> source
end --> target

Exclude "is_identifying", "cardinality" from required properties in CommonRelationship

begin_dataset_field_oddrn and end_dataset_field_oddrn of CommonRelationship should be required properties and be both either lists of stings or a map of strings to handle composite keys.

One more my suggestion would be to change the way we mention "direction" in case of Graph modeling to exclude confusion. If we assume that there could be directed graphs (relationship has a direction and in our case it should be from "source" node to "target" node) or the graph could be undirected (it means that relationship doesn't have any direction). With that said I would propose to change "DirectionType" property with values LEFT, RIGHT, NONE to a boolean value is_directed (so if the value is "true" we treat the relationship as an "arrow" from source to target, if the value is "false" there is no additional difference between source and target part and the relationship is not directed). We should also leave a possibility to not mention the value of is_directed (make this property optional) in that case there will be no information if the relationship directed or not directed.


LOGIN AUTH next handler should unconditionally succeed if more is false

Description
Looking at the following code portions:

AUTH LOGIN Next (go-mail)
AUTH PLAIN Next (go stdlib)
Client Auth (go stdlib)

It appears to me that when the more is false, then the authentication should be considered successful. Let me give my reasoning step by step:
1, Next is called here if err is nil.
2. The err var is only potentially set here as non-nil as it was prechecked here
3. Here are the possible codes (334 and 235) which are NOT an error and this seems to align with the spec
4. Here we see that more is set true if code is 334, so we can assume a 235 if it's not set and the Next implementation was called.
To Reproduce
Use a SMTP Server which doesn't respond with the suffix Authentication successful and instead uses something like Authentication succeeded. Example ProtonMail Bridge.
Expected behaviour
If a server responds with an irregular response as long as the response follows the spec that it's dealt with accordingly.
I'm happy to fix this, but wanted to see what you thought first and maybe there's a reason this has been done that I'm no aware of, the SMTP landscape is a bit wild west.
Screenshots
No response
Attempted Fixes
func (a *loginAuth) Next(fromServer []byte, more bool) ([]byte, error) {
	if more {
		switch string(fromServer) {
		case ServerRespUsername:
			return []byte(a.username), nil
		case ServerRespPassword:
			return []byte(a.password), nil
		default:
			return nil, fmt.Errorf("unexpected server response: %s", string(fromServer))
		}
	}

	return nil, nil
}

Additional context
Introduced In:

d0f04353a278126a74d998a7b48f35e4acb62a2c
6a446bd4bd12fa0275f184ac84b397ffaa16dad5

I wish Next included the SMTP code for starters, and that SMTP servers used the examples in the spec.. but officially a 235 indicates a successful response. See RFC2554 Section 4

Thanks for the bug report James. I'll have a closed look and prepare a fix tomorrow (given you already provided code, the fix should be quick ;) ).

I  think the revert to what it was prior should work. I direct messaged you so if you need me to test it I can

You were completely right James. I've reverted the change accordingly and tested with my usual test server as well as ProtonMail Bridge. Both work as expected now. I believe the change was made by me trying to be overly smart with the server responses, expecting that all servers would respond in a standardized way, which if of course foolish in the the SMTP world (as you call it "wild west" 😄 ). Sorry for causing the trouble with that and thanks again for the thorough report. I would normaly not release a new version for such a small change, but given that Authelia users are actively affected, I'll create a new release today.

No drama at all. I went from handling all of this (multipart, auth, proper encoding detection, etc) in Authelia because the go stdlib was lacking to using this lib. So I'm fully aware it's very hard to get 100% right!
Also no rush on a release as we're probably not releasing for about a week as we're in a feature release cycle. I can just use the HEAD commit to test if you're not ready.

Edit: Side note, the fact stdlib doesn't return the status codes and it's completely frozen may turn out to be a reason to fork it later, though I have no specific knowledge that would confirm that other than it being the wild west.

Agreed. The frozen part made me thinking about exactly that already as well.


Fix AoE modal continue button

Related Issue or Background Info

Issue #784

Changes Proposed
The "buggy" button at the top of the AoE modal was submitting a default/empty patientResponse object no matter what. This makes sense if the user hasn't made an initial selection (QR code vs. verbal completion). However, if the user has made a selection, it should either (a) For QR code: close the form without submitting responses, or (b) For verbal: submit the form responses and not an empty/default object.
The form lives in a child component and the data submittal is accomplished using the form onSubmit handler. The easiest way to hook into that process with the parent's "Continue" button was to use a ref and pass it from the child to the parent, triggering a submit event when the "Continue" button is clicked.
Additional Information

We already have tests of the AoE Form component, but nothing of this modal. I'd like to do a full RTL test of adding a user and verbal test, but not sure if it's worth the time right now. (I usually regret it when I decide testing is not worth the time)

Thanks for re-adding this. For some context, I'm doing a bit of research on the UX of this button layout, b/c I have some accessibility and usability concerns about having the submit button before the form.

Thanks for re-adding this. For some context, I'm doing a bit of research on the UX of this button layout, b/c I have some accessibility and usability concerns about having the submit button before the form.

@maya totally agree with you on this. I actually find that form (or at least the initial part of it) very unintuitive. I don't think an option select should kick off the creation of a record—if we need to do that to get the QR code generated then it should probably be a button, after which you can't toggle back (or, if you can, maybe another button that is "change to verbal questionnaire"). I also find it weird that, after you've selected "Complete on smartphone" you still have the option to hit "Cancel," but it doesn't actually cancel anything (just closes the modal).

Some good points @nickscialli-usds:
An update: we'll be moving to a sticky footer design and remove that header button in the end #887

I don't think an option select should kick off the creation of a record—if we need to do that to get the QR code generated then it should probably be a button, after which you can't toggle back (or, if you can, maybe another button that is "change to verbal questionnaire").

Yeah, I think that was the issue, tagging @nullflux @ClydeDroid in case they have anything to add about the technical implementation. About the UX: the designers wanted a really easy way to do this, but will tag them in any case to review your suggestions @katiealoisi @hmyers-cms

I also find it weird that, after you've selected "Complete on smartphone" you still have the option to hit "Cancel," but it doesn't actually cancel anything (just closes the modal).

Agree, wonder if we can use a close button instead. An earlier design had it this way.

Finally, your choice of completing it via smartphone or questionnaire doesn't seem to persist if you re-open the modal (maybe this is a bug)?

Not sure, @katiealoisi @hmyers-cms, what's the expected behavior?


Create a FAM role for the FOM Access Administrator

As a FOM access administrator, I want to have roles that I can assign users to on FOM, so that I am able to provision access.
AC:
Use an Insert statement to create "FOM Access Administrator"

follow steps identified here to create:

an alembic migration
from the alembic migration create the flyway migration
verify the flyway migration sql

@gormless87 This is a duplicate of 155 (subset actually)

Duplicate of #155


Enable definition of all fields in JointTrajectory message when using test node.

This PR extends test node for JTC to enable definition of all fields in JointTrajectory message when testing a hardware.
This enables velocity, acceleration, and effort only inputs that JTC can handle but test node was unable to until now.
The goal of this work is to simplify testing of a controller for a specific hardware in a specific scenario.

Codecov Report

Merging #389 (ef74a75) into master (e7f9962) will decrease coverage by 5.79%.
The diff coverage is 20.43%.

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
- Coverage   35.78%   29.98%   -5.80%
==========================================
  Files         189        7     -182
  Lines       17570      737   -16833
  Branches    11592      422   -11170
==========================================
- Hits         6287      221    -6066
+ Misses        994      161     -833
+ Partials    10289      355    -9934

Flag
Coverage Δ

unittests
29.98% <20.43%> (-5.80%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...de/diff_drive_controller/diff_drive_controller.hpp
100.00% <ø> (ø)

...ontroller/test/test_load_diff_drive_controller.cpp
12.50% <0.00%> (ø)

diff_drive_controller/src/odometry.cpp
42.16% <11.11%> (ø)

...ive_controller/test/test_diff_drive_controller.cpp
17.62% <12.08%> (ø)

diff_drive_controller/src/speed_limiter.cpp
46.55% <13.33%> (ø)

...troller/include/diff_drive_controller/odometry.hpp
20.00% <20.00%> (ø)

...iff_drive_controller/src/diff_drive_controller.cpp
32.67% <24.59%> (ø)

...test/test_load_joint_group_velocity_controller.cpp

...ler/test/test_load_joint_trajectory_controller.cpp

..._state_broadcaster/src/joint_state_broadcaster.cpp

... and 192 more


Updated projects page (no links), gallery grid, and contact page buttons.

(I wasn't sure if my pull request from before was sent properly). I started work on my projects page (in progress), as well as gallery and contact.

Done! I pushed those changes along with some other updates.


Unable to access public assets (image in my case) when running module from relative location

Tech trace:
Node: v8.12.0
Json-server: 0.14.2
OS: Windows 10
Step to reproduce:

Create project work space

Project

mock-server

json-server.js
db.json

public

test.png

//json-server.js
const jsonServer = require('json-server')
const server = jsonServer.create()
const router = jsonServer.router('.db.json')
const middlewares = jsonServer.defaults()

server.use(middlewares)
server.use(router)
server.listen(3000, () => {
  console.log('JSON Server is running')
})

// db.json
{
  "posts": [
    { "id": 1, "title": "json-server", "author": "typicode" }
  ],
  "comments": [
    { "id": 1, "body": "some comment", "postId": 1 }
  ],
  "profile": { "name": "typicode" }
}

Navigate to project folder and run below command

node ./mocke-server/json-server.js

Open browser and hit below url

http://localhost:3000/test.png

Actual behavior:
NO image is rendering over browser
GET /test.png 404 6.290 ms - 2

Expected behavior:
Respective image should render over browser
GET /test.png 200 6.390 ms - 2

But if i am running module in step 2). as below then every thing is working perfectly fine
cd .\mock-server\
node .\test.js

As i have to run json-server from gradle.build file so i have to run json-server from work space not from absolute location.

@typicode any workaround for above issue?

Hey @typicode it is urgent will you please look into it?


x/tools/go/analysis/passes: opt: skip each ast.File that doesn't import the package of interest

Many go/analysis checkers start by inspecting the import map of the package, and making an early return if a specific package of interest is not found, for example:
	if !analysisutil.Imports(pass.Pkg, "sync/atomic") {
		return nil, nil // doesn't directly import sync/atomic
	}

This check is a substantial optimization. Indeed, in recent experiments we discovered that all the traversals done by static checkers can be quite significant relative to type checking---so much so that gopls' separation of analyzer sets into "all" (for root packages) and "fact-only" (for dependencies) is well worth doing.
We could take it a step further by skipping individual files if they don't import the package of interest. That's easy when the traversal uses ast.Inspect, but harder if it uses the Inspector, since the latter searches all files of the package.
The task of this issue is to try to find a convenient way to skip traversal of files that lack the necessary import, and measure the benefit.

harder if it uses the Inspector, since the latter searches all files of the package.

Two approaches come to mind:

extend Inspector with a new function that is a version of Preorder but with a list of given Nodes to traverse within. A plausible contract is to consider the Nodes a list of token.Pos [begin, end) pairs and to allow pre-order traversal starting from any node in the inspector that is contained by some root (basically have an new outer loop for Preorder). This then enables a 2 pass solution to first find the relevant *ast.Files and then traverse only these.
switch the Inspector.Preorder to Inspector.Nodes to allow for skipping, add *ast.File to the node filter, and add a utility function to determine if an *ast.File should be skipped.

Both approaches would need to rely on *ast.ImportSpect.Path. There might be some subtle differences to types.Package.Path() ?
The breakeven for 1.4x slowdown for Preorder->Nodes is skipping >30% of files. I guess the empirical question underlying this issue is whether once we know a package is imported >= 1 times, then how frequently will it not be imported in some files in the package? For example, my intuition is that if "slog" is imported once, it is imported in most files. My intuition is that is not true for "sort" though. I guess we just need to experiment? (@zpavlinovic thoughts?)
2cents: this is really about speeding up analysis of static calls. There is a related and plausible direction for optimization of enabling more checkers that consider static methods to skip more packages by doing something like !analysisutil.Imports(pass.Pkg, "foo"). Right now this test is still imperfect for static method calls as "foo" does not need to be directly imported for its methods to be called. If one adds the check, there is a risk of missing some reports (e.g. "httpresponse"). But it also does seem plausible that a significant majority of packages can be skipped safely for these checkers (e.g. "slog"), but that seems to require a new fact pass of some kind (my WiP).

The breakeven for 1.4x slowdown for Preorder->Nodes is skipping >30% of files. I guess the empirical question underlying this issue is whether once we know a package is imported >= 1 times, then how frequently will it not be imported in some files in the package? For example, my intuition is that if "slog" is imported once, it is imported in most files. My intuition is that is not true for "sort" though. I guess we just need to experiment? (@zpavlinovic thoughts?)

I don't see a reason why we couldn't make this experiment on the analysis pipeline.


can't sign in to pump19 invalid csrf token

when i try to sign in through twitch i get the error 401 "invalid csrf token", i would appreciate it if you guys could fix it

There indeed appear to be some issues. I guess I might have missed some API change.
I'll try to get it working again one of these days

We should be using the new API now, please try logging in again if you get the chance

i still get the error

From what the internet tells me, this might be an issue with your Twitch session/cookies/cache. I reset all the sessions on our end, but you might have to clear your cache/cookies for Twitch as well. You could also try linking your account in Incognito mode

clearing the cache and cookies worked great
From: Kevin Perry
Sent: Sunday, September 22, 2019 9:21 AM
To: pump19/pump19
Cc: coolbond1 ; Author
Subject: Re: [pump19/pump19] can't sign in to pump19 invalid csrf token (#6)
From what the internet tells me, this might be an issue with your Twitch session/cookies/cache. I reset all the sessions on our end, but you might have to clear your cache/cookies for Twitch as well. You could also try linking your account in Incognito mode
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHubhttps://github.com/pump19/pump19/issues/6?email_source=notifications&email_token=AKQB6VUTMXEDKGIVRROAP2TQK4MH5A5CNFSM4IYPFZRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7JACQI#issuecomment-533856577, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AKQB6VSP2FO3Q2B2C2B3L23QK4MH5ANCNFSM4IYPFZRA.

neat
if only all issues were that easy to solve


Speeding up acceptance tests locally by using kind cluster pool

Closes: #388

What changed?
Ability to use fresh kind clusters locally when running acceptance tests

Why?
To speed up the run of acceptance tests.
To increase fault-proof by avoiding cleaning up one single cluster.

How did you test it?
Manually locally

Release notes

Documentation Changes

Run with: ginkgo --randomizeSuites -v -nodes=2 --stream --focus="Weave GitOps App Add Tests" ./test/acceptance/test/...
These are the docker settings I used but it should work properly with >= 8 CPUs and >= 20G Memory:

Gantt Chart describing how this works:

@josecordaz The description of this issue says it closes #388 which is a Pull Request. Please double check that to ensure we close the right issue.

I pulled this down and tried to run with similar docker settings. It ran for 10 min then stopped putting any more info in the logs. Then after 20 min I canceled the test. Only 3 tests showed passed in the time before it froze on me.
[2] Ran 3 of 3 Specs in 1968.584 seconds
[2] FAIL! -- 3 Passed | 0 Failed | 0 Pending | 0 Skipped

The other issue that I see is that the logs are going to be harder to debug from. The output is mixed between the two clusters like so
[1] ► installing components in wego-system namespace
[2] error: no matching resources found
[2] time="2021-09-30T10:37:58-06:00" level=info msg="Waiting for GitRepositories/wego-test-app-92db5i3i in namespace: wego-system... : 5 second(s) passed of 30 seconds timeout"
[1] ◎ verifying installation
[2] time="2021-09-30T10:38:03-06:00" level=info msg="Waiting for GitRepositories/wego-test-app-92db5i3i in namespace: wego-system... : 10 second(s) passed of 30 seconds timeout"

The last comment I have is now that cluster and cluster 2 have been combined it would make sense to be able to dynamically create more or less clusters when running the tests. I didnt see anything for that but I could have missed it.

Does it work well

One issue that I see is that the logs are going to be harder to debug from. The output is mixed between the two clusters like so
[1] ► installing components in wego-system namespace
[2] error: no matching resources found
[2] time="2021-09-30T10:37:58-06:00" level=info msg="Waiting for GitRepositories/wego-test-app-92db5i3i in namespace: wego-system... : 5 second(s) passed of 30 seconds timeout"
[1] ◎ verifying installation
[2] time="2021-09-30T10:38:03-06:00" level=info msg="Waiting for GitRepositories/wego-test-app-92db5i3i in namespace: wego-system... : 10 second(s) passed of 30 seconds timeout"

The last comment I have is now that cluster and cluster 2 have been combined it would make sense to be able to dynamically create more or less clusters when running the tests. I didnt see anything for that but I could have missed it.

Cluster creation is happening dynamically. Cluster are created on node 1 ([1]). This mix you mention is because we are running tests in parallel. One simple way to simplify debugging is to append the logs to a file and then you can run something like tail -f MYLOGFILE | grep '[2]' to print out the logs from node 2 in order, just to mention an example.

Thanks @josecordaz for doing the hard work there. I have a couple of questions

Could you please share the time difference with and without the above changes, picture attached on top doesn't give me a clear comparison (with the same set of docker resources)?

As most of relies on the CI for the run, would it make it a bit more complicated to maintain this suite for often used simple scenarios? So is it the right trade-off?

Thanks @josecordaz for doing the hard work there. I have a couple of questions
1. Could you please share the time difference with and without the above changes, picture attached on top doesn't give me a clear comparison (with the same set of docker resources)?

At the time of writing this, CI took 37min (without parallelism), it takes 30min using parallelism locally. But what it's more important than time is that every single test used a brand new cluster. Which gives more accuracy to the results of the tests because the cluster clean-up functionality is not 100% fail-proof.

2. As most of relies on the CI for the run, would it make it a bit more complicated to maintain this suite for often used simple scenarios? So is it the right trade-off?

Would you mind being more descriptive in how this would make maintenance harder?. This code does not affect how things run in CI. CI will keep running tests as it always has been running them.


Constant 'Synchronizing' Notification

Here  it is. It's constantly running in the background.

I see this every once in a while. I suspect that some requests are not going through / are stale.
This forces me to kill the app every few hours.
Possible duplicates:

https://github.com/vector-im/riot-android/issues/2629
https://github.com/vector-im/riot-android/issues/2256

Maybe a duplicate of https://github.com/vector-im/riot-android/issues/2418

Duplicate of https://github.com/vector-im/riot-android/issues/2844

Problem is still around, I got one in the notification tray for now two days uninterrupted.


net/http: possible flaky test [freebsd-amd64]

Seen while doing 1.8beta1 release:
--- FAIL: TestServerKeepAlivesEnabled_h2 (0.00s)
        clientserver_test.go:50: Get https://<IP_ADDRESS>:38064: http2: server sent GOAWAY and closed the connection; LastStreamID=1, ErrCode=NO_ERROR, debug="

/cc @bradfitz

Dup of #18083


Allow users to control the TLS unwrapping behaviour.

Motivation:
In some highly unusual protocol situations it is possible that TLS
unwrapping may want to time out without taking out the TCP connection.
This is most common when interoperating with peers that don't send
CLOSE_NOTIFY messages. It's a useful tool to be able to request that
timeouts don't take out the TCP connection.
Modifications:

Added NIOSSLHandler.UnwrappingBehaviour.
Added support for passing this to stopTLS.

Result:
Users can control unwrapping behaviour.

Thanks @glbrntt, both addressed.

Ok, this patch has been substantially rewritten. Instead of adding new API surface, we now just fire an error down the pipeline and don't close when the unwrap timeout fires. This gives users the same control with less API surface.

The approval is subject to the CI passing, of course 😃

@swift-nio-bot test this please


made all items alphabetical

🛠 Fixes Issue

👨💻 Changes proposed

✔ Check List (Check all the applicable boxes)

[x] My code follows the code style of this project.
[x] This PR does not contain plagiarized content.
[x] The title of my pull request is a short description of the requested changes.

📄 Note to reviewers

📷 Screenshots

check to make sure all items are arranged alphabetically


Add browser compatibility

Look into Browserify for making this also work in the browser.

Waiting for API CORS-headers to be implemented.


[Recommendations list table] Add the Category column

[x] The Category column is rendered and displays all the categories that are related to each rule
[x] Tests are written

@doruskova, I would need your advice for the "Fault Tolerance" category icon. This category is not used in the RHEL Advisor. Thus, I tried to guess a tentative icon and chose SyncAltIcon (https://www.patternfly.org/v4/guidelines/icons/). Could you please confirm or suggest a better version?

@Fewwy, PTAL 🔍

@gkarat Looks good to me!


Linux Support

You probably don't use linux, but I tried this with fightcade2 (3rd strike) and when I press left and right simultaneously, it just outputted left. So I don't think it works through wine.

I use linux a lot, just don't game on linux as much as I used to. I really doubt wine implements low level keyboard hooks, yeah. Supporting linux and mac is something I have on my backburner, but it's like way down in my todo list.
I'll leave this issue opened to state my intention to support Linux in the future though :)


Statistics show all nodes, also the ones that were disconnected

See attachment:

mainnet statistics shows 402 nodes but only 111 are online.
testnet statistics shows 181 nodes but only 18 are online (a lot of nodes have already been migrated to mainnet).

So ALL the statistics need only to take up what is available online, not the history.

Moved from: https://circles.threefold.me/project/test-tfgrid3/issue/155

@georgeconstantinou should be good now. please reopen if you find further issues with this


HAWQ-175. Update PXF version to 3.1.0

Would be useful if we can mention the higher level changes in the jira HAWQ-175 for future reference.

+1


chore: Install cypress dependencies, add coverage

Implements https://issues.redhat.com/browse/ESSNTL-3947.

Codecov Report
Base: 47.50% // Head: 47.21% // Decreases project coverage by -0.28% :warning:

Coverage data is based on head (cfdb47f) compared to base (eff01d6).
Patch coverage: 0.00% of modified lines in pull request are covered.

 Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Make CodeIgniter::context nullable to handle access before initialization

@kenjis this is to handle context is accessed before initialized as decribed at https://github.com/codeigniter4/CodeIgniter4/pull/5650#issuecomment-1045365872 on composer update && php spark serve, tested in php 8.1
php builds development
composer update
php spark serve

Before
CodeIgniter v4.1.8 Command Line Tool - Server Time: 2022-02-18 17:42:23 UTC-06:00

An uncaught Exception was encountered

Type:        Error
Message:     Typed property CodeIgniter\CodeIgniter::$context must not be accessed before initialization
Filename:    /Users/samsonasik/www/ci4-prj/vendor/codeigniter4/codeigniter4/system/CodeIgniter.php
Line Number: 308

        Backtrace:
                                                -48 - /Users/samsonasik/www/ci4-prj/vendor/codeigniter4/codeigniter4/system/CLI/Console.php::run
                                                                -57 - /Users/samsonasik/www/ci4-prj/spark::run

After
CodeIgniter v4.1.8 Command Line Tool - Server Time: 2022-02-18 17:47:40 UTC-06:00

An uncaught Exception was encountered

Type:        AssertionError
Message:     Context must be set before run() is called. If you are upgrading from 4.1.x, you need to merge `public/index.php` and `spark` file from `vendor/codeigniter4/framework`.
Filename:    /Users/samsonasik/www/ci4-vue/vendor/codeigniter4/codeigniter4/system/CodeIgniter.php
Line Number: 309

        Backtrace:
                                                -309 - /Users/samsonasik/www/ci4-vue/vendor/codeigniter4/codeigniter4/system/CodeIgniter.php::assert
                                                                -48 - /Users/samsonasik/www/ci4-vue/vendor/codeigniter4/codeigniter4/system/CLI/Console.php::run
                                                                -57 - /Users/samsonasik/www/ci4-vue/spark::run

Checklist:

[x] Securely signed commits

I am merging early so user that uses develop version can immediately see the clue in the error message.

@samsonasik Thank you!


Ignore the prefix and suffix in the SpinBox expression

Follow-up to #31781.
This fixes a regression caused by 86a31e9e385c7909a0cdd24a5ee790c3dca03b98.

Thanks!


Is there a way to redirect incoming traffic to https without typing https:// ?

Hey Jason, loved your tutorial it really helped and wanted to start off by saying thank you. Aiside from that, whenever I want to open up one of my node apps that I deployed using your technique, I have to enter the https://example.com instead of just example.com which gives me an error. This is just because I don't want people trying to view my work and then have an error pop up! Any way to make that work? Or just stick to typing in the https:// ?? Thaaaanks.

Hey, @devMattO — there's a bit of config in teh Nginx step that will redirect all non-HTTPS traffic to the secure URL. Check out this section of the article and compare it to your config to make sure it's working: https://code.lengstorf.com/deploy-nodejs-ssl-digitalocean/#make-sure-all-traffic-is-secure
Thanks!

Hmm, I believe you’re right, this was my first time going through your tutorial and I guess I took the redirect out for some reason…. lol >.<
Thank you for the speedy response, I really appreciate it!

On Feb 21, 2017, at 7:59 AM, Jason Lengstorf<EMAIL_ADDRESS>wrote:
Hey, @devMattO https://github.com/devMattO — there's a bit of config in teh Nginx step that will redirect all non-HTTPS traffic to the secure URL. Check out this section of the article and compare it to your config to make sure it's working: https://code.lengstorf.com/deploy-nodejs-ssl-digitalocean/#make-sure-all-traffic-is-secure https://code.lengstorf.com/deploy-nodejs-ssl-digitalocean/#make-sure-all-traffic-is-secure
Thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/jlengstorf/tutorial-deploy-nodejs-ssl-digitalocean-app/issues/11#issuecomment-281386948, or mute the thread https://github.com/notifications/unsubscribe-auth/AP21C4A7oRXI_BM7qRCWmp9PVpE8fDPXks5rewn2gaJpZM4MHeZ1.


Debug mode: Request body and headers were not displayed when HTTP sen…

…d returned 400 HTTP response code. Fixed.

Coverage decreased (-0.5%) to 99.31% when pulling d6e79adb09ac14160ba28a5173374330b7ef9a20 on debug_exception_reply into 02a6e43fcba4eedd8b03a8859909bea4dab22098 on v4.1.

@freethan check please


Simplify vsphere templater and ssh key defaults

Description of changes
While integrating the template builder with the full cluster lifecycle controller, I faced some issues. I started unraveling the code and I ended up with this. It's not perfect by any means but it does simplify the code a little bit and reduces coupling, which makes reusing the template builder easier.

This avoids modifying user's API input by moving SSH key normalization to the template builder level as opposed to defaulting. It's a good practice and makes the template builder more reusable, specially from controllers. This is the main behavioral change: if users include the user@host comment in the ssh key, this will be kept in the eks-a vsphere machine config and just removed from the vsphere machine template.

It simplifies template builder by making use of the API structs in the cluster.Config instead of maintaining its own specs. This also reduces the coupling between provider and template builder.

It also reduces the use of internal provider pointers to API structs. It doesn't completely remove them, but at least now the tests don't depend on the internal private members of the provider.

Finally, it removes the provider members to maintain SSH keys. The purpose wasn't clear, it coupled some public methods together and it didn't seem necessary.

Testing

Unit tests
Run create/upgrade e2e test manually

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/lgtm
🙌

/woof

/approve


Update @polkadot/apps-config

While trying to update the @polkadot/apps-config package some warnings were found in regards to mismatching versions in the yarn.lock file.
This PR reverted the commit that locked the versions of the dependency resolutions because we need to keep the dependencies up to date and delegate that chore to dependabot .
Also we should be careful about deleting the lock file as a means to upgrading the project dependencies. Probably we should not do it in a production project and let dependabot take care of it.

@jdomingos

I've checked that the APIs broken by previous updates work under this set of packages versions

I am not sure what you mean by this.

If we do it like you did, since we don't have any regression tests on APIs, a simple update of the packages might break some APIs that depend on these packages.

Yes. That's what the lock file is for. It helps us maintain latest stable version of the project. The upgrade will cause problem if we delete the lock file. The scenario you are mentioning that can also happen when trying to setup the project in a new machine and the lock file helps in preventing that. And as a next step if we delegate the chore to dependabot, it will open PRs in specific time intervals and we can decide to merge them carefully.

I've checked that the APIs broken by previous updates work under this set of packages versions

I am not sure what you mean by this.

@ishrak-imam, last time the package updates broke the parachains APIs.
But checked with the changes on this PR and I've confirmed that these APIs are working in local.


Cmdtop2

Issue Ref: Fixed minor issue noted in PR 823
Description: Added a status field to the kubeless function top command output that displays a Function does not expose metrics message when functions do not expose metrics. Added a message field to the JSON and YAML formatted results.
TODOs:

[X] Ready to review
[X] Automated Tests
[ ] Docs

thanks for the follow up PR @tkeech1 ! The test are failing because it's needed to rebase master so it's fine to merge this.


[enhancement] support for multiple og properties with the same key

I'm submitting a ...  (check one with "x")
[ ] bug report => check the README and search github for a similar issue or PR before submitting
[ ] support request => check the README and search github for a similar issue or PR before submitting
[X] feature request

Current behavior
@nglibs/meta does support multiple og properties with the same key.
Expected/desired behavior
It should support multiple og properties with the same key.
For example:
<meta property="og:image" content="http://example.com/rock.jpg" />
<meta property="og:image:width" content="300" />
<meta property="og:image:height" content="300" />
<meta property="og:image" content="http://example.com/rock2.jpg" />
<meta property="og:image" content="http://example.com/rock3.jpg" />
<meta property="og:image:height" content="1000" />

Could have been provided by @nglibs/meta
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

Angular version: 2.0.X

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Language: [all | TypeScript X.X | ES6/7 | ES5]

Node (for AoT issues): node --version =

Doesn't the knew meta service support that?

When @nglibs/meta was initially released, there was no Meta service in the Angular core. As of version 4, they introduced it - and yes, the Meta service from Angular core supports that feature.
For this reason, I branched the repo into two (master and v0.2.x) while the v0.4.x consumes the Meta service from Angular core, the v0.2.x contains these features internally.
However the main thing in @nglibs/meta is, the ability to render page title and meta titles from route definitions - helping separation of different concerns a bit while improving code cleanliness.

Right now is there a workaround for this without using direct DOM interpolation in order to being compatible with Angular Universal?

@HighSoftWare96 sorry for the delay, had busy times. feel free to fire a PR and i'll approve.


Log stop working after file was overwritten

require "log"

Log.builder.bind("*", level: "debug", backend: Log::IOBackend.new("log.txt", "a"))
9.times do |i|
    mess = "test #{i}"
    puts mess
    Log.info {mess}
    sleep 10
end

Wait the program to run 2 or 3 times, then open the file log.txt, modify something then save. The logger now does nothing.
Can I detect whether the file was overwritten and catch exception, or tell the logger just "don't care" and keep writing?
FYI, the former logger still write to file after overwritten.

Well I guess what happened is that your editor used an atomic save implementation, which usually boils down to
File.write(filename+"new", content)
File.delete(filename)
File.rename(filename+"new", filename)

So the original file is in fact gone and there's a new file with the same name. The crystal process still has the file descriptor of the old file though and continues writing to it. It's just that the underlying file has no representation in the filesystem index anymore.
I'm not sure if we can reasonably detect this in Log::IOBackend. Or whether we should. Note this is a common problem and the reason why things like logrotate offer the truncation option, where it  makes a copy of the current logfile and then truncates the original one, rather than just renaming the current logfile and creating a new one of the same name.

FYI, I used geany editor on Fedora to open & save log file.
With the former logger, in the terminal I can do this:
echo "foo" > log.txt

The logger still can write to log after that.

If I used Enki (version 19.10.0) to edit log.txt, the crystal log write normally.

I don't think there's anything we should do here. Do you know any other logging software that detects and reopens a replaced logfile?

As you can see here: https://askubuntu.com/questions/682446/how-does-logrotate-work
It's a general logical issue and not related to Crystal specifically.
There are smart logrotate solutions that can handle those kind of things.


hemaia util

This PR introduces the hemaia/util.py. The aim of this dedicated script is to increase the level of automation during rtl generation and house the small function that retrieves information from cfg and irrelevant to rtl code.
Possible usage:

Generate targets for Bender
Generate filelist for FPGA / Backend flow
Generate runtime software

OK!
A few thoughts that you might want to consider.

Maybe call it hemaia_util.py so that it's not too generic hehe. Also the idea is, just in case someone calls their modules util.py at least ours is a unique name. I'll leave it up to you if you want to change.
Would you mind if I add later, a listing CI? I will also teach you how to use pre-commits for formatting. Haha let me know if you want this feature then I will try to add it.

It is in hemaia folder, so I think it is still fine😃😃
What is the listing CI? I don't know it. By the way, I had spent too many time on the Makefile to generate targets dynamically... I suggest we move rtl target to Python😭😭

@IveanEx I will do the CI thing in a different PR. I think this is a nice first step.
I also agree. I don't like how we need to comply with Makefiles... I mean there's a Python generation that is easier to do.
The Makefile thing is only useful for C builds and so. But to generate RTL, make some filelists and all... they should not be in Makefiles. It only makes things more difficult...


convert_tflite.py CUDA_ERROR_UNKNOWN: unknown error

Hello. First of all, thanks for the repo. I'm trying to convert a normal yolov4 weights to a tf model. I can run the first command, with 'save_model.py'. However, the simple 'python convert_tflite.py' command produces the following error:
F tensorflow/stream_executor/lib/statusor.cc:34] Attempting to fetch value instead of handling error Internal: failed to get device attribute 13 for device 0: CUDA_ERROR_UNKNOWN: unknown error
After the error, the execution is aborted and does not finish.
Do you know what might be the cause? Thanks.

Update: I still get the error on my own computer, but managed to get it working on google colab with tensorflow 2.3.0.
However, now I found an error related to int8 quantization of yolov4-tiny on the default dataset. Might create a new issue later


Cross build for Scala 2.12.1

Looking good! Happy to merge as is, or if you want to break out to a seperate artifact can wait.

Hi Scott, I finally found some time to look at it again. To properly separate curator from the rest change would be quite big. I don't think it is worth it, at least for me. So if everything is working fine for you, please merge ;)

thanks! will publish a snapshot to oss.sonatype.org shortly

published!, let me know if it works as expected and i will cut an 0.1.9

I tested it again and it looks like I was initially testing against some self signed but accepted locally certificate so it was working fine, when I tried to run HTTP request against newly generated SSL certificate it failed.
Fixes are here: https://github.com/sclasen/akka-zk-cluster-seed/pull/23


Code 505 Error when updating mods

Receiving a Code 505 error when a mod needs to be updated:
Checking for update of mod bobgreenhouse...
  Already up-to-date.
Checking for update of mod bobinserters...
Downloading...
  Download failed: Code 505.
Checking for update of mod boblibrary...
  Already up-to-date.

Thanks for the issue. The mod updater's release was a bit rushed and I will take a look at this the next days and fix it.

Can't reproduce that. Did you check if the token is correct?

Looks like I didn't match the case when using the variable TOKEN or USERNAME.  Resolving that seems to allow it to connect, but now I'm running into the issue where each file is giving me an SHA1 mismatch.  Log file attached.
Factorio.txt

I already noticed this while testing and a fix for that will be pushed today. I close this for now. If you have any more trouble feel free to comment on this issue.

I think the issue is either on the factorio end or your network.
assuming the webserver isn't lying 505 is a bad gateway so something might be broken in theirproducing. now what I think is happening is a auth error which redirects to a login page hence the mismatch.
can you update mods on the client and is the server on the same network?
has this recently stopped working?

I tested it with one mod today on the server and that worked. If the issue I would suggest your write Factorio support if it is happening on the web and in the game itself, too.

Just for the case that somebody else runs into the same issue again. For me this error was caused by a simple space at the end of the token within the server-settings.json file.


BlockSync provider

Summary of changes
Changes introduced in this pull request:
BlockSync "provider" - the logic to run for an incoming BlockSync libp2p request.
Test notes
It was somewhat hard to test this MR. I've added a unit test prepopulating MemoryDB with some chain data (thanks @austinabell  for generating file for me), and compared the response with FilFox, see comments in the test.
Reference issue to close (if applicable)

Closes #673
Other information and links

Thanks so much for this contribution! Looks generally good, and happy to help with any of the changes or suggestions if you would like :)


Error message pops up at startup since updating spyder to 5.2.2 from 5.1.5

Description
What steps will reproduce the problem?

This happens at startup, no actions taken so far.
Traceback
Exception in thread Thread-10:
Traceback (most recent call last):
  File "C:\Users\marku\Anaconda3\envs\NormAndSpacy\lib\threading.py", line 926, in _bootstrap_inner
    self.run()
  File "C:\Users\marku\Anaconda3\envs\NormAndSpacy\lib\site-packages\jupyter_client\threaded.py", line 218, in run
    self.ioloop.start()
  File "C:\Users\marku\Anaconda3\envs\NormAndSpacy\lib\site-packages\tornado\platform\asyncio.py", line 199, in start
    self.asyncio_loop.run_forever()
  File "C:\Users\marku\Anaconda3\envs\NormAndSpacy\lib\site-packages\nest_asyncio.py", line 72, in run_forever
    self._run_once()
  File "C:\Users\marku\Anaconda3\envs\NormAndSpacy\lib\site-packages\nest_asyncio.py", line 106, in _run_once
    event_list = self._selector.select(timeout)
  File "C:\Users\marku\Anaconda3\envs\NormAndSpacy\lib\selectors.py", line 323, in select
    r, w, _ = self._select(self._readers, self._writers, [], timeout)
  File "C:\Users\marku\Anaconda3\envs\NormAndSpacy\lib\selectors.py", line 314, in _select
    r, w, x = select.select(r, w, w, timeout)
OSError: [WinError 10038] An operation was attempted on something that is not a socket

Versions

Spyder version: 5.2.2
Python version: 3.7.13
Qt version: 5.9.7
PyQt5 version: 5.9.2
Operating System: Windows 10

Dependencies
# Mandatory:
atomicwrites >=1.2.0          :  1.4.0 (OK)
chardet >=2.0.0               :  4.0.0 (OK)
cloudpickle >=0.5.0           :  2.0.0 (OK)
cookiecutter >=1.6.0          :  1.7.3 (OK)
diff_match_patch >=20181111   :  20200713 (OK)
intervaltree >=3.0.2          :  3.1.0 (OK)
IPython >=7.6.0;<8.0.0        :  7.31.1 (OK)
jedi >=0.17.2;<0.19.0         :  0.18.1 (OK)
jellyfish >=0.7               :  0.9.0 (OK)
jsonschema >=3.2.0            :  4.4.0 (OK)
keyring >=17.0.0              :  23.4.0 (OK)
nbconvert >=4.0               :  6.4.4 (OK)
numpydoc >=0.6.0              :  1.4.0 (OK)
paramiko >=2.4.0              :  2.8.1 (OK)
parso >=0.7.0;<0.9.0          :  0.8.3 (OK)
pexpect >=4.4.0               :  4.8.0 (OK)
pickleshare >=0.4             :  0.7.5 (OK)
psutil >=5.3                  :  5.9.0 (OK)
pygments >=2.0                :  2.11.2 (OK)
pylint >=2.5.0                :  2.9.6 (OK)
pyls_spyder >=0.4.0           :  0.4.0 (OK)
pylsp >=1.3.2;<1.4.0          :  1.3.3 (OK)
pylsp_black >=1.0.0           :  1.0.0 (OK)
qdarkstyle =3.0.2             :  3.0.2 (OK)
qstylizer >=0.1.10            :  0.1.10 (OK)
qtawesome >=1.0.2             :  1.0.3 (OK)
qtconsole >=5.2.1;<5.3.0      :  5.2.2 (OK)
qtpy >=1.5.0                  :  2.0.1 (OK)
rtree >=0.9.7                 :  0.9.7 (OK)
setuptools >=49.6.0           :  61.2.0 (OK)
sphinx >=0.6.6                :  5.0.2 (OK)
spyder_kernels >=2.2.1;<2.3.0 :  2.2.1 (OK)
textdistance >=4.2.0          :  4.2.1 (OK)
three_merge >=0.1.1           :  0.1.1 (OK)
watchdog >=0.10.3             :  2.1.6 (OK)
zmq >=17                      :  23.2.0 (OK)

# Optional:
cython >=0.21                 :  0.29.30 (OK)
matplotlib >=2.0.0            :  3.5.1 (OK)
numpy >=1.7                   :  1.21.5 (OK)
pandas >=1.1.1                :  1.3.5 (OK)
scipy >=0.17.0                :  1.7.3 (OK)
sympy >=0.7.3                 :  1.10.1 (OK)

Hey @Markus-Kruger. thanks for reporting. Please open the Anaconda Prompt, run the following command there
conda list

and post its output here.
I think this problem is caused by one of the Spyder-kernel dependencies, but I have to take a look at your packages to be sure about it.

Thank you Carlos, here is the output:
Conda list output.xlsx

I think this is fixed in a more recent version of Jupyter-client, but unfortunately you have the latest one available in Anaconda. So please try to update to our latest version (5.3.2) from Conda-forge, which will pull it.
Since it's still not available in Anaconda, you need to create a new environment. For that, please close Spyder, open the Anaconda Prompt and run the following commands there:
    conda create -n spyder-cf -c conda-forge spyder
    conda activate spyder-cf
    spyder

Let us know if it works for you.

Thank you Carlos, I get no more issues at startup, only this message in the command prompt: "fromIccProfile: failed minimal tag size sanity"
Spyder seems to be working without issues so far.

only this message in the command prompt: "fromIccProfile: failed minimal tag size sanity"

Don't worry about it. That's an inoffensive warning that you can simply ignore.

Spyder seems to be working without issues so far.

Great! Thanks for letting us know about it.


Suggestion:  Add Archive button to mail view

My by far most used action in K9 is Archive.  Once I read an email, I almost always Archive it.  And since GMail, archive over delete is a pretty common practice.  I know on some smaller devices there might not be room for more buttons, but would it be possible to add an Archive button at the top of the screen for quicker access than Overflow->Refile->Archive ?
K-9 Mail version: 5.700
Android version: 10 (Stock)
Phone:  Pixel 3 XL
Account type: IMAP

Isn't there already an archive button at the top of the screen?   Settings->General->Display, Visible message actions.  It's there, I just missed it.  :(


Add new solution version that directly returns

In this case (that is quite typical) more complicated
language features are not necessary.

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi @matkoniecz. I tested the solution you added and it works for me. I'm merging your PR. Thank you for contributing ❤


Switch VEDA staging hub from EFS to jupyter-home-nfs server

Changes include:

Switch storage provider of VEDA staging hub from EFS to the in-cluster NFS server provided by jupyter-home-nfs
Upgrade jupyter-home-nfs to the latest version

the new version supports specifying the parent path of the home directories for enforcing storage quota. (earlier the quota enforcement path was hard-coded to be /export/). For the staging hub, we set it to /export/staging.
The new version adds 'nfs' to k8s resource names, no longer relying only on Helm release names for identification

@sunu I don't know if you want to make changes here or just merge it and make a new PR for figuring out the NFS filepath mount. You have merge rights so I'll leave it up to you :)

@sgibson91 I've added a few more changes here. Added a note to the top comment describing the changes. Could you take another quick look please?


SCB-1349 support nacos discovery

Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Make sure there is a JIRA issue filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful subject line and body.
[ ] Format the pull request title like [SCB-XXX] Fixes bug in ApproximateQuantiles, where you replace SCB-XXX with the appropriate JIRA issue.
[ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[ ] Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Coverage increased (+0.04%) to 89.349% when pulling 02d83391c1f313ddc90ebece9eeffba541236292 on cmonkey:feature/SCB-1349 into bcf978dfc1bde47a97e2591bd20e34ca78034f50 on apache:master.

Yeah, it's great we have multiple service registry support here.


add cli option to skip pre-termination checks

tested in lab both with and without flag

mmm hold up i think i misunderstood the spec. will update soon.


docs: Indicate latest Zulip version in installation and upgrade docs.

Fixes #19695.
@timabbott, @alya: FYI :)

Merged, after various minor edits; thanks for figuring out how to do this @eeshangarg!
I'm also backporting this to the 4.x branch.

Awesome, thanks @eeshangarg , @timabbott !


Any trigger have for _refreshAccessToken request failed?

Hi!
I can't handle Refresh Token 401 response. Have any solution for this situation?
I looking oauth2-password-grant.js file and there is no trigger.
Regards,
Themesama

We solved this by overloading the _scheduleAccessTokenRefresh function (copy paste the original implementation) and add an catch block to the this._refreshAccessToken in the run.later call.


Wrong Date return from the DayView

New Issue Checklist

[x] Use the latest version of CalendarKit
[x] I've read the Contribution Guidelines
[x] I've searched for existing GitHub issues

Issue Description
Wrong date returned using
self.calendarDetailsView.state?.selectedDate
after assigning date using
self.calendarDetailsView.state?.move(to: selectedDate)
Code I'm using with CalendarKit

func calendar(_ calendar: FSCalendar, didSelect date: Date, at monthPosition: FSCalendarMonthPosition) {

        //self.dateSelected = Date(year: date.year, month: date.month, day: date.day)

        let selectedDate = date.addingTimeInterval(TimeInterval(TimeZone.current.secondsFromGMT(for: date)))
        NSLog("1. Selected Date: \(selectedDate)")
        self.fromCalendar = true
        self.calendarDetailsView.state?.move(to: selectedDate)
        NSLog("Calendar Date: \(self.calendarDetailsView.state?.selectedDate)")

    }

func eventsForDate(_ date: Date) -> [EventDescriptor] {

        let selectedDate =  date.addingTimeInterval(TimeInterval(-TimeZone.current.secondsFromGMT(for: date)))
        NSLog("Date: \(date)")
        NSLog("Date String: \(date.format(with: "yyyy-MM-dd"))")
        NSLog("2. Selected Date: \(selectedDate)")
        NSLog("3. Selected Date: \(selectedDate.getShortDateString())")

        let dateString = date.getShortDateString()
        var events = [Event]()

        for i in 0...47 {

            let event = Event()
            let timeString = dateString + CommonString.COMMON_WHITE_SPACE + schedule[i]
            let eventDate = Date(dateString: timeString, format: "yyyy-MM-dd HH:mm", timeZone: TimeZone(abbreviation: "EST")!)
            //NSLog("Event Date: \(eventDate.toLocalTime())")
            let duration = 20
            let datePeriod = TimePeriod(beginning: eventDate,
                                        chunk: TimeChunk.dateComponents(minutes: duration))

            event.startDate = datePeriod.beginning!
            event.endDate = datePeriod.end!

            var info = data[Int(arc4random_uniform(UInt32(data.count)))]
            let timezone = TimeZone.current
            info.append(datePeriod.beginning!.format(with: "YYYY-MM-dd", timeZone: timezone))
            info.append("\(datePeriod.beginning!.format(with: "HH:mm", timeZone: timezone)) - \(datePeriod.end!.format(with: "HH:mm", timeZone: timezone))")
            event.text = info.reduce("", {$0 + $1 + CommonString.COMMON_WHITE_SPACE})
            //NSLog("Event: \(event.text)")
            event.isAllDay = false

            events.append(event)
            event.userInfo = String(i)
        }

        if !self.fromCalendar {
            self.calendar.select(selectedDate)
        }

        self.fromCalendar = false

        return events
    }

I trying to use this together with other API.
The issue is clearly at DayView (self.calendarDetailsView. is an instance of DayView)
and here are the logs
2019-07-31 21:48:16.473307-0400 Tello EHR[30832:2391275] 1. Selected Date: 2019-08-15 00:00:00 +0000
2019-07-31 21:48:16.480253-0400 Tello EHR[30832:2391275] Date: 2019-08-14 04:00:00 +0000
2019-07-31 21:48:16.480602-0400 Tello EHR[30832:2391275] Date String: 2019-08-14
2019-07-31 21:48:16.480709-0400 Tello EHR[30832:2391275] 2. Selected Date: 2019-08-14 08:00:00 +0000
2019-07-31 21:48:16.480947-0400 Tello EHR[30832:2391275] 3. Selected Date: 2019-08-14
2019-07-31 21:48:16.555629-0400 Tello EHR[30832:2391275] Calendar Date: Optional(2019-08-14 04:00:00 +0000)

As you can see, the date I tried to assign was 2019-07-19 00:00:00 +0000.  However, the DayView returned to me with the different one. (To be exact, it is one day behind what I want)
Result I am trying to achieve

What I am trying to achieve is something like this:
2019-07-31 21:48:16.473307-0400 Tello EHR[30832:2391275] 1. Selected Date: 2019-08-15 00:00:00 +0000
2019-07-31 21:48:16.480253-0400 Tello EHR[30832:2391275] Date: 2019-08-15 00:00:00 +0000
2019-07-31 21:48:16.480602-0400 Tello EHR[30832:2391275] Date String: 2019-08-15
2019-07-31 21:48:16.480709-0400 Tello EHR[30832:2391275] 2. Selected Date: 2019-08-15 00:00:00 +0000
2019-07-31 21:48:16.480947-0400 Tello EHR[30832:2391275] 3. Selected Date: 2019-08-15 00:00:00 +0000
2019-07-31 21:48:16.555629-0400 Tello EHR[30832:2391275] Calendar Date: Optional(2019-08-15 00:00:00 +0000)

As you can see with the image bellow, I am trying to select August 15, 2019 and I am pretty sure that I passed the 2019-08-15 00:00:00 +0000 to DayView instance.  However, the DayView showed me the 2019-08-14 calendar not the 2019-08-15.

replace the format date string 00:00:00  with 12:00:00, then transform the string to date

Hi, this issue should be fixed now.
DayViewState removes all the time information from the Date, so that it should be set at midnight in the timezone of the DayView's calendar.
Therefore, of course, the date set to the DayViewState would be different from the one queried and that's normal.
If you still have this issue with the latest version of the CalendarKit, feel free to reopen this issue. Alternatively, you could remove the time information from the date before assigning it to the DayViewState to ensure it would be then same when queried.


Missing github actions default environment variable

What is the current behavior?
Page is missing GITHUB_JOB
The equivalent context is on this page
What changes are you suggesting?
Add the missing variable.
You can see it is present and public by looking at this code

Hope merged
Sent from Yahoo Mail on Android

Sent from Yahoo Mail on Android

Viva my serene

https://linksharing.samsungcloud.com/ucRLqvHxx5OvValid until Apr 15, 2021Sent from my Galaxy

Shared from Word for Androidhttps://office.com/getwordSent from my Galaxy

Sent from my Galaxy


Compatibility with .NET framework 4.5

Is your feature request related to a problem? Please describe.
To orchestrate a legacy system on .NET framework 4.5 (.NET standard 1.1) using Camunda 8 Enterprise.
The Zeebe csharp client only support .NET framework 4.6.1 and above (.NET standard 2.0)
Describe the solution you'd like
Backward compatibility with .NET framework 4.5
Describe alternatives you've considered
Upgrading the legacy system won't be an option due to time and cost constraint.

We migrated to .net 7.0, we will likely not support .net standard 1.1, I will close this issue as won't fix.
Please consider creating a separate project or fork this, and adjust it to your needs. I'm not able to support this due to time constraints and work on other projects.


Upgrade to 1.8.1 release

This change upgrades to upstream 1.8.1. One major change is that the package now builds against the vanilla ragel package in f29, which is really nice.
Here is the build I did on Koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=30399967 . Note that pp64le and s390x architectures fail because they are missing a luaji-devel package. I think the spec file could be updated with some more macros to fix this if someone is sufficiently interested in using rspamd on those architectures by not enabling the luajit cmake build option.

Thanks!


Handle same tensor value being used in multiple hal.interface.store_tensor ops

HLOToLinalgOnBuffers didnt handle the case of the same tensor SSA
value being used as operands in multiple hal.interface.store_tensor
ops. Fix for this is to maintain a separate map from
hal.interace.store_tensor -> iree.placeholder and use this to decide
if a copy is needed or not.

THanks @hanhanW for the example. That is indeed working poorly. Will take a look and address the issue with this PR if possible.

@hanhanW : I looked into this a bit more. Your example threw some interesting things. They need to be addressed. In the meantime if the PR as is, helps your use case (and there are no other issues) let merge this. I will fix the issues with the examples you have.

Updated the PR with changes to handle this case too. This passes all tests locally.


Fix a bug which prevents opening a WebSocket.

This fixed a bug where it couldn't open a WebSocket:
DOMException: Failed to construct 'WebSocket': The URL 'ws://blynk-cloud.com:8082undefined' is invalid.

I tried your repository but it still gives me the same error


[SPARK-29284][SQL] Adaptive query execution works correct…

What changes were proposed in this pull request?

spark.sql("SET spark.sql.adaptive.enabled=true")
spark.sql("SET spark.sql.shuffle.partitions=1")
val result = spark.range(0).distinct().count
or spark.table("empty table").distinct.count

throw java.util.NoSuchElementException: next on empty iterator
Why are the changes needed?

Fix bug.
Does this PR introduce any user-facing change?

No
How was this patch tested?

Add UT :org.apache.spark.sql.execution.ExchangeCoordinatorSuite

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Thank you @hn5092 Please verify if the issue still exist in master branch.

Thank you @hn5092 Please verify if the issue still exist in master branch.

master not exist this issue

OK. Thank you. Could we close this?

2.4.x needn't fix this bug?

@hn5092, please identify which PR fixed this, and see if it's feasible to backport.

@hn5092, please identify which PR fixed this, and see if it's feasible to backport.

The new AE fix this bug but we can't cherry-pick to branch 2.4