DirectionalLight create cropped shadow for Sprite3D close to the sprite

Godot version
3.3.4 stable
System information
GLES3 and GLES2
Issue description
DirectionalLight create cropped shadow for Sprite3D close to the sprite.
OmniLight and SpotLight create proper shadow.
Steps to reproduce
With a simple light setup with shadow enabled, the issue seem to be only with DirectionalLight. The issue occur even with the light shadow bias property set to 0.
To enable the shadow with alpha transparency on the Sprite3D, we need to go in section Flags the property "Alpha Cut" and select the option "Opaque Pre-Pass". The issue occur with all Flags "Billboard" options selected.

Minimal reproduction project
DirectionalLight_Sprite3D_Shadow_cropped_bug.zip

This is likely some combination of settings. Try fiddling with bias, shadow range, and normal bias and see if you can get something a little bit better.

This is likely due to shadow peter-panning caused by the bias values being too high. Try adjusting the DirectionalLight's shadow bias and normal bias values, but note that you won't get a "perfect" result no matter what you do
.
This is fixed in 4.0 thanks to the introduction of shadow normal offset bias and shadow pancaking.

DirectionalLight doesn't have a shadow range. I tried a negative bias of -0.2, I can get something that look better, however if I rotate the light, the bias value doesn't work anymore. If I play with the "Contact" value for the shadow the result I get doesn't look good.
I even tried to create a duplicate Sprite3D only to cast the shadow as suggested on the page below. However having a separate Sprite3D only to cast the shadow from a different position doesn't work once the camera move.
Y-Billboard Sprite3D does not cast shadows : https://github.com/godotengine/godot/issues/27738

DirectionalLight doesn't have a shadow range.

There's a Max Distance property under the Directional Shadow section:

Thanks, that I played with the Directional Shadow settings. It didn't removed completely the cropped shadow, however now the space between the shadow and the Sprite3D is smaller and it look much better.


API-11368 UI style

When in "refactored UI" mode, UI is similar in style to staging.va.gov
When not in "refactored UI" mode, UI style is unchanged

[ ] button spacing is larger than VA.gov
[ ] login.gov button font is different than login.gov
[ ] "signing in" link points to staging VA.gov
[ ] VA.gov uses hover pseudo classes to change button color

UI is very close to matching VA.gov for desktop viewing.  Button SVG's and spacing all looking good with the latest updates.

However when I switched to mobile rendering, the styling runs into issues.

Versus staging.va.gov

This also changes the style of the non-refactored page. The login buttons are larger and the create-account button is misaligned. The old page needs to be unaffected.

It was determined that a lighter touch refactor was a safer change for lighthouse.


Convert Fixnum to AS::Duration before calling 'ago'.

Rails 4 removed 'ago' monkey patch from Fixnum.
Fixes #3523

There's a number of these similar configuration patterns for purging throughout the code.  Can you find the rest and fix them as well?  I'll merge this one for now unless you want to fix them too.

I won't get to all of them right now.  Let's merge this when green to fix this one.

:+1:


Add Filebeat v5 Support

This will capture #40 and #43

It looks like Fielebeat v5 has been released.

I still need to add a parameter so that the module can support both versions, but I want it to detect what it can (why I've added the filebeat_version fact).
The filebeat5 branch has what I've pushed so far. Using it with the right config template parameter set should work today if you want to try it out before it's all finished.

Good work so far. I guess the most of us (at least me) can live with a "legacy" branch for older filebeat versions >5
Autodetection or a config value might be great but not required from my side

It looks like the repository location for 5.x changed as well, so we'll need to manage that in addition to the template. In a way this makes things easier since there is less detection that we'll need to do.
I'm hoping that I get something more substantial pushed up later today

I still need to update the docs, but some early testing would very much be appreciated before I roll a release out.
The quick and dirty version of the docs:
If you use this module on a system with filebeat 1.x installed, and you keep your current parameters nothing will change by default. Setting major_version to '5' will modify the configuration template and update package repositories, but won't update the package itself. To update the package use the package_ensure parameter (the current is 5.0.0).


add optional headers to file backend

First step before https://github.com/HeavyHorst/remco/issues/34.
I didn't want to change the logic of GetValues, so I opted for a custom transport that will attach any optional headers for us. Alternatively, I was thinking maybe we could split out the remote file functionality out of file into its own http backend? It doesn't feel necessary right now, but I feel if more options are ever added, it might be.
Advice on how I might write some tests for this would be appreciated! I looked through the other backends, and noticed their options aren't really tested either though, so idk if you're cool with just this.

Thanks! I like the solution with the custom transport.
We could use the httptest package to test this.
Here is an example from https://golang.org/pkg/net/http/httptest/#Server:
package main

import (
	"fmt"
	"io/ioutil"
	"log"
	"net/http"
	"net/http/httptest"
)

func main() {
	ts := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		fmt.Fprintln(w, "Hello, client")
	}))
	defer ts.Close()

	res, err := http.Get(ts.URL)
	if err != nil {
		log.Fatal(err)
	}
	greeting, err := ioutil.ReadAll(res.Body)
	res.Body.Close()
	if err != nil {
		log.Fatal(err)
	}

	fmt.Printf("%s", greeting)
}

We could create a handler that returns the http headers as json and test if they match our provided ones.

Added a test to have it parse its own headers. That's a pretty cool idea. Thank you! :-) Coverage for the file backend went up a bit too

LGTM! Thanks again.


Ignore case when checking zip extension

Resolved / Related Issues
Items resolved / related issues by this PR.

Closes #6495
Closes #6491
Test fix for #6605
Fixes<PHONE_NUMBER>u
Fixes<PHONE_NUMBER>u
Fixes<PHONE_NUMBER>u

Details of Changes
Add details of changes here.

Added try-catch when extracting files
Compare zip extension ignoring case
Regenerate file tags json file if invalid

Validation
How did you test these changes?

[x] Built and ran the app

/azp run

Thank you!


Getting error while running run.py from whisper examples

Traceback (most recent call last):
File "/code/tensorrt_llm/examples/whisper/run.py", line 336, in
model = WhisperTRTLLM(args.engine_dir, args.debug, args.assets_dir)
File "/code/tensorrt_llm/examples/whisper/run.py", line 218, in init
self.decoder = WhisperDecoding(engine_dir,
File "/code/tensorrt_llm/examples/whisper/run.py", line 121, in init
self.decoder_generation_session = self.get_session(
File "/code/tensorrt_llm/examples/whisper/run.py", line 153, in get_session
decoder_generation_session = tensorrt_llm.runtime.GenerationSession(
File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 457, in init
self.runtime = _Runtime(engine_buffer, mapping)
File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 150, in init
self.__prepare(mapping, engine_buffer)
File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 170, in __prepare
address = CUASSERT(cudart.cudaMalloc(self.engine.device_memory_size))[0]
File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 99, in CUASSERT
raise RuntimeError(
RuntimeError: CUDA ERROR: 2, error code reference: https://nvidia.github.io/cuda-python/module/cudart.html#cuda.cudart.cudaError_t
Exception ignored in: <function _Runtime.del at 0x7fb94d845360>
Traceback (most recent call last):
File "/usr/local/lib/python3.10/dist-packages/tensorrt_llm/runtime/generation.py", line 266, in del
cudart.cudaFree(self.address)  # FIXME: cudaFree is None??
AttributeError: '_Runtime' object has no attribute 'address'

Hi. Could you share the command line to reproduce the issue, please? As well as tell us more about your environment, please? Thanks a lot.

First I created model.engine by running command
python3 build.py --output_dir whisper_large_v2_bm5 --model_name large-v2  --max_batch_size 16 --max_beam_width 5 --use_gpt_attention_plugin --use_gemm_plugin --use_layernorm_plugin  --use_bert_attention_plugin
after this I simply run python3 run.py


Added a Contains method to EventContext.

There is currently no way to see if a particular key has already been added to the EventContext. There are a few use cases where this can be useful and it feels like a reasonable thing to add without breaking any encapsulation.
This also contains some Visual Studio artifacts which seemed to be missing.

merged!


All struct parameters should name match models

Currently we have either:

names that don't full match
names that match but have a _prior tag

I don't think the latter adds anything as it being in the prior should be clear its the prior model.
I think we should standardise so that all parameters in the model are defined with the same name in the structs. As this may be a fairly disruptive refactor I think we should do this at the same time as making everything a submodel (i.e #372).

Hard agree.


ambiguous_with cannot be used to configure system sets

Bevy version
0.14.1
What you did
Called app.configure_sets(MySchedule, MySet.ambiguous_with(MySet).
What went wrong
MySet doesn't implement IntoSystem, so the code did not compile.

Nope, I can't reproduce this. No idea what was going wrong.


No loot. Try to change targets/ports/protocol.

Scanning for camera doesn't seem to work
root@localhost:~/cansleep# python3 cansleep.py  -s nmap --target <IP_ADDRESS>/24  -m all
[2023-10-14 23:43:22,830] [INFO] [NMAP] Start scanning. Please wait...
[2023-10-14 23:43:23,332] [INFO] [DAHUA] Start checking targets
[2023-10-14 23:43:23,675] [INFO] [DAHUA] Start brutting credentials
[2023-10-14 23:43:23,678] [INFO] [DAHUA] Start snapshoting
[2023-10-14 23:43:23,679] [WARNING] [DAHUA] No loot. Try to change targets/ports/protocol.
[2023-10-14 23:43:23,680] [INFO] [HIKKA] Start checking connection
[2023-10-14 23:43:23,707] [INFO] [HIKKA] Start brutting credentials
[2023-10-14 23:43:23,709] [INFO] [HIKKA] Start snapshoting
[2023-10-14 23:43:23,711] [WARNING] [HIKKA] No loot. Try to change targets/ports/protocol.
[2023-10-14 23:43:23,711] [INFO] [RTSP] Start checking routes
[2023-10-14 23:43:54,291] [INFO] [RTSP] Start brutting credentials
[2023-10-14 23:43:54,294] [INFO] [RTSP] Start snapshoting cameras
[2023-10-14 23:43:54,297] [WARNING] [RTSP] No loot. Try to change targets/ports/protocol.

And brute forcing

root@localhost:~/cansleep# python3 cansleep.py  --combo wordlist/usernames.txt:wordlist/passlist.txt -s nmap --target <IP_ADDRESS>  -m all --debug
[2023-10-14 23:52:26,991] [INFO] [NMAP] Start scanning. Please wait...
[2023-10-14 23:52:27,249] [INFO] [DAHUA] Start checking targets
[2023-10-14 23:52:27,319] [INFO] [DAHUA] Target <IP_ADDRESS>:37777 success checked
[2023-10-14 23:52:27,324] [INFO] [DAHUA] Target <IP_ADDRESS>:80 success checked
[2023-10-14 23:52:30,299] [DEBUG] [DAHUA] Target <IP_ADDRESS>:554 failed checked
[2023-10-14 23:52:30,301] [INFO] [DAHUA] Start brutting credentials
[2023-10-14 23:52:35,425] [DEBUG] [DAHUA] [80] Unable to login: <IP_ADDRESS>:80 with admin:admin
[2023-10-14 23:52:35,426] [DEBUG] [DAHUA] [37777] Unable to login: <IP_ADDRESS>:37777 with admin:admin
[2023-10-14 23:52:35,427] [INFO] [DAHUA] Start snapshoting
[2023-10-14 23:52:35,431] [WARNING] [DAHUA] No loot. Try to change targets/ports/protocol.
[2023-10-14 23:52:35,431] [INFO] [HIKKA] Start checking connection
[2023-10-14 23:52:35,834] [DEBUG] [HIKKA] Target <IP_ADDRESS>:80 failed checked
[2023-10-14 23:52:37,197] [DEBUG] [HIKKA] Target <IP_ADDRESS>:554 failed checked
[2023-10-14 23:52:38,477] [DEBUG] [HIKKA] Target <IP_ADDRESS>:37777 failed checked
[2023-10-14 23:52:38,478] [INFO] [HIKKA] Start brutting credentials
[2023-10-14 23:52:38,481] [INFO] [HIKKA] Start snapshoting
[2023-10-14 23:52:38,484] [WARNING] [HIKKA] No loot. Try to change targets/ports/protocol.
[2023-10-14 23:52:38,484] [INFO] [RTSP] Start checking routes
[2023-10-14 23:52:38,524] [INFO] [RTSP] Route found for: rtsp://<IP_ADDRESS>:554/
[2023-10-14 23:52:38,525] [INFO] [RTSP] Route found for: rtsp://<IP_ADDRESS>:554/
[2023-10-14 23:52:38,527] [INFO] [RTSP] Route found for: rtsp://<IP_ADDRESS>:554/
[2023-10-14 23:52:38,528] [INFO] [RTSP] Start brutting credentials
[2023-10-14 23:52:38,880] [DEBUG] [RTSP] Creds not found for: rtsp://<IP_ADDRESS>:554/
[2023-10-14 23:52:38,917] [DEBUG] [RTSP] Creds not found for: rtsp://<IP_ADDRESS>:554/
[2023-10-14 23:52:38,919] [DEBUG] [RTSP] Creds not found for: rtsp://<IP_ADDRESS>:554/
[2023-10-14 23:52:38,920] [INFO] [RTSP] Start snapshoting cameras
[2023-10-14 23:52:38,924] [DEBUG] [RTSP] Failed make snapshoot None
[2023-10-14 23:52:38,924] [DEBUG] [RTSP] Failed make snapshoot None
[2023-10-14 23:52:38,925] [DEBUG] [RTSP] Error: [Errno 2] No such file or directory: 'None'
[2023-10-14 23:52:38,925] [DEBUG] [RTSP] Failed make snapshoot None
[2023-10-14 23:52:38,926] [DEBUG] [RTSP] Error: [Errno 2] No such file or directory: 'None'
[2023-10-14 23:52:38,926] [DEBUG] [RTSP] Error: [Errno 2] No such file or directory: 'None'
[2023-10-14 23:52:38,928] [WARNING] [RTSP] No loot. Try to change targets/ports/protocol.


Attempt to look up serviceaccount token

If no auth configuration is provided, attempt to look up the default
serviceaccount token. This token will be present if logstash is running
in a Pod in Kubernetes, has a serviceaccount, and the Pod and/or
serviceaccount are set to automount the token.
This patch is similar to one that I'm running in our Kubernetes clusters right now, except that we seem to be running an older version of the plugin, so the code looks slightly different on my side.
This is the first time I've ever written Ruby, so I took the shortest path to the goal. Possible improvements, if reviewers don't mind helping me get there:

Currently the plugin will try to read the token file every time, rather than reading it once and caching the token. Should it try to read the token once and cache it on init? Is there an appropriate reload hook for it to retry looking up the token that I could hook into?
Currently the plugin always looks up the token if no other auth options are specified, which is a change in behavior. Previously, if no other auth was configured, the plugin would proceed without auth. I could instead add a new configuration option for using the service account, if that seems appropriate. I'm open to suggestions.

Ping. It's been just over a year. Any chance this can be merged?


Switch to asynciterators

There's a lot of streaming inside quadstore that could benefit from asynciterator's leaner approach.

See

https://github.com/Level/abstract-leveldown#abstractleveldown_iteratoroptions
https://github.com/Level/memdown/blob/master/memdown.js#L211
https://github.com/rubenverborgh/AsyncIterator

Cleaning up old issues, will reopen a new one if needed.


Update README & CONTRIBUTING

Fix broken links for Dev Chat that point to broken gitter.im room.
This was partially fixed here but a few were missed: https://github.com/gohugoio/hugo/commit/fbb25014e1306ce7127d53e5fc4fc49867790336
Remove lines about mage vendor target that is no longer available.
mage vendor was removed in https://github.com/gohugoio/hugo/commit/fdf3c3b8234ed340f40a85fb76d96ae3a9ccf195
Remove broken table of contents links for headings in CONTRIBUTING.md

Thanks. Very much appreciated.


Problems with loading/using script

I'm running   newest ternjs:
https://github.com/marijnh/tern/commit/c06155785601679e8ef52d647f608a63e9b17bfd
Express plugin is installed in tern directory using npm install (/tern/node_modules/tern-node-express).
When in .tern-project I add "node-express: to plugins and start tern I get this error:
module.js:340
throw err;
^
Error: Cannot find module 'tern/lib/infer'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:364:17)
at require (module.js:380:17)
at infer.registerFunction.arg (/home/johndoe/install/tern/node_modules/tern-node-express/node-express.js:3:16)
at Object. (/home/johndoe/install/tern/node_modules/tern-node-express/node-express.js:7:3)
at Module._compile (module.js:456:26)
at Object.Module._extensions..js (module.js:474:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
If I modify paths in node-express.js to point to place where infer and tern are located /home/johndoe/install/tern/lib/infer instead of just tern/lib/infer tern does not report error. Unfortunately even though tern does not report a problem completion in this simple program does not work:
http://expressjs.com/starter/hello-world.html
Tern does not provide any completion for app/res/req.

For using tern-node-express with last version you must use the code which is hosted in the github (and not use npm install) because of https://github.com/marijnh/tern/issues/641
I'm waiting for tha tern is released to publish tern-node-express.

@johndoe1234 I have published node-express which uses now tern 0.16.0. Could you retry please?

Error does not appear any more.

Cool I close this issue.


Unit tests for cleanup function

Description

Unit tests for cleanup function
100% code coverage for tested function
Over 83% total code coverage

Fixes https://issues.redhat.com/browse/CCXDEV-11410
Type of change

Unit tests (no changes in the code)

Testing steps
To be checked on CI.
Checklist

[ ] make before_commit passes
[ ] updated documentation wherever necessary
[ ] added or modified tests if necessary
[ ] updated schemas and validators in insights-data-schemas in case of input/output change

Codecov Report
Patch coverage has no change and project coverage change: +1.74 :tada:

Comparison is base (331094b) 81.99% compared to head (c6e6ff1) 83.74%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
+ Coverage   81.99%   83.74%   +1.74%
==========================================
  Files           3        3
  Lines         572      572
==========================================
+ Hits          469      479      +10
+ Misses         86       77       -9
+ Partials       17       16       -1

see 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Ability to speficy Postgres version

Info:

Docker version ($ docker --version): Docker version 1.12.6, build 78d1802
Laradock commit ($ git rev-parse HEAD): 01c358b6bc76333f4960a7da582d3bdbc33b9155
System info (Mac, PC, Linux): Linux
System info disto/version: Ubuntu 17.04

Issue:
Docker installs latest Postgres version

Expected behavior:
Beeing able to speficy Postgres version  in .env file

Reproduce:
docker-compose up -d postgres

Relevant Code:
FROM postgres:latest

docker tag postgres:10 postgres

How do I downgrade the version? I tried docker tag postgres:9.6 postgres but it didn't recognise the tag

Inside postgres/Dockerfile change
FROM postgres:alpine
to
FROM postgres:<version>  e.g.  FROM postgres:9.6


Create test-pr2

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Hi @JCarosella, I was wondering what led you to open this pull request?

Hey! That was a mistake of mine, I'm really sorry. I got confused with the original repo and my fork.

Okay, no problem!


[Report] Data preview onComplete return undefined

unable to get the data the csv import

Thanks for the report, I will investigate shortly.


Added some descriptive text to make a good ReadMe file.

Added some descriptive text to make a good ReadMe.md file.

Please I am sorry for all the trouble we have caused you but count it all joy. Your PR is about to be merged and you will be able to see your name on this url.
To enable me to do this, READ the README again carefully, update your code with the latest and push the update. I am here for you for the next 6 hours before I close the PR so you can initiate a fresh PR which will be easier to merge.


Distribute WebView2 FixedRuntime: Incorrect code snippet

https://docs.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution#details-about-the-fixed-version-runtime-distribution-mode
Closing tag for CopyToOutputDirectory is malformed
<Content Include="FixedRuntime\(version number)\\**\*.*">
<CopyToOutputDirectory>PreserveNewest<CopyToOutputDirector>
</Content>

Also might be more helpful to have include the ItemGroup:
<ItemGroup>
<Content Include="FixedRuntime\(version number)\\**\*.*">
	<CopyToOutputDirectory>
		PreserveNewest
	</CopyToOutputDirectory>
</Content>
</ItemGroup>

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8a805f15-55ba-4ef4-aeda-22188a040c66
Version Independent ID: 88de0955-526f-a4c9-efcc-d952281850e1
Content: Distribute a WebView2 app and the WebView2 Runtime - Microsoft Edge Development
Content Source: microsoft-edge/webview2/concepts/distribution.md
Product: microsoft-edge
Technology: webview
GitHub Login: @MSEdgeTeam
Microsoft Alias: msedgedevrel

Scroll up above section https://review.docs.microsoft.com/en-us/microsoft-edge/webview2/concepts/distribution?branch=main#known-issues-for-fixed-version
It now reads:
<ItemGroup>
  <Content Include="FixedRuntime\(version number)\\**\*.*">
    <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
  </Content>
</ItemGroup>

Thank you @ottah for reporting the issue! Let's close it now since @mikehoffms says it's fixed.


Yikes I downloaded the repo itself by mistake...Too much JS has made my brain numb


Request Headers are being Cached/Saved on HttpContext from Previous Requests.

Issue Title
When Accessing the HttpContext.Request.Headers values are cached/saved/magic appear in different and independent requests.
General
ASP.NET Core 2
I am sending the Bearer token (JWT) to authenticate the requests from the FE to the API.
Some requests did not send a token as they required no authentication.
So the code was like this.
  if (!String.IsNullOrEmpty(token))    {      client.DefaultRequestHeaders.Authorization = new AuthenticationHeaderValue("Bearer", token);     }
When a route needed to get info about the User it checked the JWT
context.Request.Headers.TryGetValue("Authorization", out var accessToken);
if I did not send a token and a previous request from different browser send a token, then that token was used.
My Solution
I now always send a Request Header Authorization.
Why does this happen? Here is the API startup file
https://gist.github.com/drakoumel/2a36f10607170cbb92e36caa286c315f

Issue found with my code.


[WIP] Static link MKL-DNN library

Description
(Brief description on what this PR is about)
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at https://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

@Taolv could you give a simple summary of the reason for this change and any possible impacts?

@pengzhao-intel , sure, PR description is added.

@szha @lanking520 @perdasilva @marcoabreu Could you please review, especially the parts about CD and packaging?

@pengzhao-intel , sure, PR description is added.

Very great explanation.  Ping me when your PR is ready to merge.

Wait for the internal testing results. Let's know if you have any comments or concerns.
I will merge the PR after we get the internal validation results.

@szha @lanking520 @perdasilva @marcoabreu Call for review :)

Have you tried?
source tools/staticbuild/build.sh mkl pip

@lanking520 Attached the build log. Please take a look. Thanks!
build_mkl_pip.txt

Merging now


added ref so to work with this.refs

I added a ref on the input so that when you want to "jump" through inputs, it's possible.
something like:
focusNextField = (nextField) => {
        this.refs[nextField].focus();
    };

<FloatLabelTextField
   ref={'inputOne'}
   returnKeyType={'next'}
   onSubmitEditing={() => this.focusNextField('inputTwo')}
... />

<FloatLabelTextField
   ref={'inputTwo'}
   returnKeyType={'next'}
   onSubmitEditing={() => this.focusNextField('inputThree')}
... />

<FloatLabelTextField
   ref={'inputThree'}
   returnKeyType={'next'}
   onSubmitEditing={() => this.submit()}
... />

@rodrigocuriel Merged & published.
Thanks!


[SPARK-9370][SQL] Add DecimalType support in UnsafeRow

JIRA: https://issues.apache.org/jira/browse/SPARK-9370
Add DecimalType support in UnsafeRow.

Merged build triggered.

Merged build started.

Test build #38812 has started for   PR 7744 at commit f2810f6.

@viirya Thanks for working on this. It seems that your patch only works for precision <= 18, we should support the full range (0 < precision <= 38).
Because we always know the DataType (it's DecimalType, having precision and scale), so we could change the getter and setter to
  def getDecimal(i: Int, precision: Int, scale: Int): Decimal
  def setDecimal(i: Int, value: Decimal, precision: Int)

For UnsafeRow, we could have different representation for precision <= 18 (using long) and 18 < precision <= 38 (serialize the BigDecimal into bytes).

Test build #38812 has finished for   PR 7744 at commit f2810f6.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
 public static class DecimalWriter

Merged build finished. Test FAILed.

We must change these getter/setter interfaces?
ISTM that setDecimal(i: ordinal, value: Decimal) serializes the value with the precision/scale that the input decimal value has, and getDecimal(i: ordinal) simply read the value as-is.
The decimal format could be as follows;
(1-bit flag, precision, scale, 4-byte offset) is packed in a 8-byte fixed part.
The flag represents a following format in a variable-length part.
If 0,  'precision <= 18' and the format is [long].
If 1, '18 < precision <= 38' and the format is [size in long][byte array of BigDecimal].
Any other compact representations?


Investigate using libsamplerate for audio conversion

Currently we rely on using FFmpeg for converting the audio in files to a format supported by the audio device. This seems to work fairly well, but since FFmpeg is a large dependency it might be nice to investigate alternative approaches like libsamplerate.

Some additional notes here:
https://github.com/OpenTimelineIO/raven/issues/15#issuecomment-1574060741

BTW, mrv2's tlRender branch now supports resampling on FPS (speed) change both forwards and backwards.  Let me know if you want me to clean it for a PR.

Thanks, but I need to spend some time refactoring the audio code before adding any new functionality. Hopefully I will have some time in a few weeks.

I experimented using libsamplerate for audio conversion but ran into a few issues:

The converted audio had pops (which was likely my fault).
libsamplerate only does frequency conversion. FFmpeg's swresample library does both frequency conversion and channel conversion which is nice.
libsamplerate only works on floating point data. FFmpeg's swresample library works on both floating point and integer data which is nice.

It still might be nice to use libsamplerate since it has a more permissive license and can be staticly linked.


Exclude applied to root, when used with pre-commit

Files are not checked with Ruff running in pre-commit, if the git repository is inside a build directory.
Steps to reproduce
The setup is very basic.
Create a directory build.
Initialize git inside this directory.
Create a Python file, which is violating Ruff rules.
Install pre-commit hook (with the pre-commit Python package).
Run pre-commit on all files -> the Python file will not be checked.
Project structure
build
    |- .git
    |- .pre-commit-config.yaml
    |- test.py

Executed commands:
> mkdir build
> cd build
> git init
# Add .pre-commit-config.yaml and test.py to git
> python -m pre_commit install
> python -m pre_commit run --all-files --verbose
ruff.....................................................................Passed
- hook id: ruff
- duration: 0s

warning: No Python files found under the given path(s)
> python -m ruff check .
test.py:3:8: F401 [*] `ruff` imported but unused
Found 1 error.
[*] 1 fixable with the `--fix` option.

Files
test.py
#!/usr/bin/env python3

import ruff

def main():
    pass

if __name__ == '__main__':
    main()

.pre-commit-config.yaml
repos:
- repo: https://github.com/astral-sh/ruff-pre-commit
  rev: v0.1.6
  hooks:
  - id: ruff
    types: [python]

Versions
pre-commit==3.5.0
ruff==0.1.7

Can you try it with the official pre-commit hook as mentioned in the documentation?

Same result with the official pre-commit hook. Files are not checked and the violation is not detected.

Also, can you provide the output for the command python -m pre_commit run --all-files --verbose?

> python -m pre_commit run --all-files --verbose
ruff.....................................................................Passed
- hook id: ruff
- duration: 0.01s

warning: No Python files found under the given path(s)

I'm pretty sure this is the same problem that I brought up here https://github.com/astral-sh/ruff/discussions/6191

Are the files correctly checked if you add a ruff.toml to the root of the build directory?

Are the files correctly checked if you add a ruff.toml to the root of the build directory?

No. Same result if a ruff.toml exists in the root.
The files are checked if ruff is called directly:
> python -m ruff check .
test.py:3:8: F401 [*] `ruff` imported but unused
Found 1 error.
[*] 1 fixable with the `--fix` option.

With the pre-commit hook, they are not checked:
> python -m pre_commit run --all-files --verbose
ruff.....................................................................Passed
- hook id: ruff
- duration: 0s

warning: No Python files found under the given path(s)

Directory structure:
build
    |- .git
    |- .pre-commit-config.yaml
    |- test.py
    |- ruff.toml

Oh sorry, I missed that this is specifically when using --all-files (at least, I assume?). That I can at least explain. Presumedly, pre-commit is passing the root directory to Ruff, like ruff check . (from the directory containing build). In that case, when we start to iterate over files in that root directory, we use Ruff's default settings, and see the build directory, which is excluded by default, and skip it. (If we pass paths to files within build directly, Ruff will correctly use the settings within build.)
This is confusing in this case, but changing the behavior would also be confusing. Imagine that instead of build, your directory was .venv. It would be strange if we linted files within .venv in such a case, right?

If pre-commit provides the files in relative paths, would the problem be resolved?

Oh sorry, I missed that this is specifically when using --all-files (at least, I assume?). That I can at least explain. Presumedly, pre-commit is passing the root directory to Ruff, like ruff check . (from the directory containing build). In that case, when we start to iterate over files in that root directory, we use Ruff's default settings, and see the build directory, which is excluded by default, and skip it. (If we pass paths to files within build directly, Ruff will correctly use the settings within build.)

I think there is a misunderstanding between us.
There is no directory named build in the project. The root directory is named build.
If we are using strictly relative paths, no path will contain build.
The current behavior is not consistent between pre-commit and directly using Ruff.
Ruff is working as expected when called directly:
> cd /home/user/build
> ruff .
test.py:3:8: F401 [*] `ruff` imported but unused
Found 1 error.
[*] 1 fixable with the `--fix` option.
> ruff /home/user/build/test.py
test.py:3:8: F401 [*] `ruff` imported but unused
Found 1 error.
[*] 1 fixable with the `--fix` option.

Running it with pre-commit has a different behavior:
> python -m pre_commit run --all-files --verbose
ruff.....................................................................Passed
- hook id: ruff
- duration: 0.05s

warning: No Python files found under the given path(s)

If we check the documentation here. https://docs.astral.sh/ruff/settings/#exclude

Single-path patterns, like .mypy_cache (to exclude any directory named .mypy_cache in the tree), foo.py (to exclude any file named foo.py), or foo_.py (to exclude any file matching foo_.py ).

Ruff will exclude any directory named build in the tree.
I expect it to check only the tree starting from root (the build directory in our case).
Therefore the tree would look like this:
./
├─ .git/
├─ .pre-commit-config.yaml
├─ test.py
├─ ruff.toml


[TASK] Contract page does not look good with dark mode

Estimated story points: 3
Description

Acceptance criteria

time: 2.5h


Outputting information to aide particle concatenation

To efficiently particle files, we need to know the total number of particles.
Currently, that means we load every file once before in order to allocate space in the resulting file (which can be very slow). It would be faster if we recorded the total number of particles when writing outputs.
In fact, it would actually be even better if we recorded the total number of particles per file in one centralized location (maybe just in file 0). That way, we could better parallelize concatenation (when using an arbitrary number of processes for concatenation that is totally unrelated to the number of processes used in the original simulation)

as far as I remember, the header of each file has the number of local particles, this means that you just need to read that value from the header of each file and not the entire data to compute the total number of particles. This shouldn't be a significant overhead.

Your recollection is correct about what is stored. That is exactly what we do.
With that said, standard posix file operations can be extremely slow on parallel file systems. The overhead of simply opening and closing a file can be shockingly large (especially when other people are using the file system). This is most problematic when you have many thousands of files.
In my experience, the parallel systems on the Oakridge systems usually aren't bad. But I have had awful experiences with the LUSTRE system on Frontera

I see. I haven't had the pleasure of using Frontera, but I always hear lovely things about it.
In that case, I agree that doing an MPI_Allreduce to get n_particles_total when writing the header of the output files is a good idea.


Bugfix: COVID-19 India Tests data.

Previous Discussion: 335

Take the last value of the day
Keep the ISO code as it is

Thanks for the fix!


monitoring: make it optional

We now allow the user to choose if she wants monitoring or not.
The templates are becoming a bit complex, but unfortunately I don't think there's a magic solution: if we want flexibility for our users, we need a lot of templated ifs...

This change is

Reviewed 11 of 11 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable


Printing "Hello World" outputs this error: Error compiling to JavaScript: XMLHttpRequest error

So I'm Trying to print "Hello World" using dartpad, but error is displayed: Error compiling to JavaScript:
XMLHttpRequest error.
Browser: Chrome
OS: windows

Thanks for opening an issue!
Could you provide us with the full code you are using?
I just tried:
void main() {
  print('Hello world!');
}

and it worked as expected: https://dartpad.dev/?id=571b1f6e6611e62fa55fe04f04b527bc

void main() {
print('Hello');
}

I tried your code and I got same error

Thanks for the information.
Could you try opening the Chrome DevTools Console and letting us know what shows up when you try running the code?
It could be your network blocking access. Consider trying at https://dartpad.cn and seeing if that works.

Here's a screenshot of network: https://prnt.sc/xCWnjC11LPpH
and I tried other link and worked perfectly
Thanks

This is working for me, so it doesn't appear to be a server-side issue. That leaves one of the thirty of so middleboxes between your browser and our server, and that's a hard issue to debug from here.
I'd suggest trying alternate networks to see if you can find one that works.

If you are in Egypt, this seems to have been a recurring issue with some Egypt ISPs for many sites.
For now, try other networks as domesticmouse mentioned or use https://dartpad.cn if those don't work. You can also Get Dart or Get Flutter to run code on your own machine too :D

Thanks again for the report! I'm going to close this issue as stale, as it is likely a local network setup issue or an ISP level problem.
If someone is still experiencing similar issues, please open a new issue with reproduction details and network information. Thanks again :)


No container found for ico_1

docker-compose up -d
backend-ico-dashboard-develop_mongo_1 is up-to-date
backend-ico-dashboard-develop_redis_1 is up-to-date
backend-ico-dashboard-develop_rpc_1 is up-to-date
backend-ico-dashboard-develop_auth_1 is up-to-date
backend-ico-dashboard-develop_verify_1 is up-to-date
Starting backend-ico-dashboard-develop_ico_1 ... done

then...

docker-compose exec ico npm i && docker-compose exec ico npm run build
ERROR: No container found for ico_1

?? why getting this error?

I hope you closed this issue because you figure out the way to avoid this error. In case someone else will look for the solution I'd like to add that you have to run docker-compose build in order to build required containers.


Uncaught SyntaxError: Identifier 'InputAdapter' has already been declared

This appears on load in the console:

I know...

It's because Input Expressions and Monster Blocks share some code. And I've been incredibly lazy about de-duplication.


Add publish-firefox-extension to CI workflow

Use https://github.com/marketplace/actions/firefox-addon-action to publish the extension to Firefox addons in the CI workflow.
Before we can test this we need to

[ ] set two secrets FIREFOX_API_KEY and FIREFOX_API_SECRET.
[ ] get or set the guid. See https://mozilla.github.io/addons-server/topics/api/addons.html#put-create-or-edit

@antelle I'm unable to publish the extension myself.

Your add-on failed validation with 1 error.
Duplicate add-on ID found.

Can you add me as an author? My email for my Firefox account is<EMAIL_ADDRESS>https://extensionworkshop.com/documentation/publish/add-on-ownership/

I wonder how. My Firefox account with that extension is deleted, so I can’t anymore

Secrets are not shared with PRs from forks :facepalm: so opening a new PR


On windows, include paths do not work as expected

On mac/linux, including a file using e.g. {% extends '../common/templates/index.twig' %} works as intended: the path is resolved relative to the template being processed.
On windows, the path seems to be resolved relative to the Gruntfile, which means that while the above works fine everywhere else, it breaks when executed there.

Hi! As grunt-twig-render is just a wrapper around twig.js and you are referencing the extends-tag in your issue, the problem seems to be an issue with twig.js itself, doesn't it?

+1, please accept SonicGD's pull request. :)

Hi, I have now debugged this issue and found out that it indeed is related to twig.js.
See my pull-request here at https://github.com/justjohn/twig.js/pull/252

Thanks @stefanullinger! Looking forward to twig.js merging your PR.

The PR has finally been merged into twig.js: https://github.com/justjohn/twig.js/pull/300


Errors with Mix with install under L5.4?

I tried creating a fresh install of Quarx using the Simple Setup method on a clean Laravel 5.4 installation and run into errors when running the last step, npm run dev:
npm run dev
ERROR  Failed to compile with 3 errors
error  in ./resources/assets/sass/app.scss
Module build failed:
@import "node_modules/bootstrap-sass/assets/stylesheets/bootstrap";
^
      File to import not found or unreadable: node_modules/bootstrap-sass/assets/stylesheets/bootstrap.
Parent style sheet: /{my-file-path}/resources/themes/default/assets/sass/_theme.scss
      in /{my-file-path}/resources/themes/default/assets/sass/_theme.scss (line 7, column 1)
 @ ./resources/assets/sass/app.scss 4:14-248
 @ multi ./resources/assets/js/app.js ./resources/assets/sass/app.scss
Any ideas why this might be happening?
Thank you!

did you do npm install first?

Hi @mlantz, yes, absolutely. The install portions runs as expected. Just to be sure I did try it a few times from scratch just in case... but it failed the same way each time.

try publishing the default theme then running the npm run dev, it may be something broken on the theme publishing

Good call, thank you! That seems to have solved it.


copy files or folders, can't paste to remote Windows server

Hi there,
I'm using mac to connect my Windows 7 server, can't use +clipboard, had to use shared folders...Is there any way to make clipboard function work normally? Please help~~ ;) , thank you!!
To Reproduce
Steps to reproduce the behavior:

CMD: xfreerdp +clipboard /v:xxx /u:xxx /p:xxx /device:shared,/path/to/folders
Copy any files or folders on Finder,
Checkout RDP session,
Rightclick paste can't be used.

Expected behavior
Copy(command+c) files or folders on Finder; Paste on server.
Application details

Version of FreeRDP: Homebrew prebuilt version 2.0.0-rc4
Command line used: OS X terminal
output of /buildconfig:
This is FreeRDP version 2.0.0-rc4 (n/a)
Build configuration: BUILD_TESTING=OFF BUILTIN_CHANNELS=ON HAVE_AIO_H=1 HAVE_EXECINFO_H=1 HAVE_FCNTL_H=1 HAVE_FLAG_SEARCH_PATHS_FIRST=1 HAVE_INTTYPES_H=1 HAVE_MATH_C99_LONG_DOUBLE=1 HAVE_POLL_H=1 HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIB= HAVE_PTHREAD_MUTEX_TIMEDLOCK_LIBS= HAVE_PTHREAD_MUTEX_TIMEDLOCK_SYMBOL= HAVE_SYSLOG_H=1 HAVE_SYS_EVENTFD_H= HAVE_SYS_FILIO_H=1 HAVE_SYS_MODEM_H= HAVE_SYS_SELECT_H=1 HAVE_SYS_SOCKIO_H=1 HAVE_SYS_STRTIO_H= HAVE_SYS_TIMERFD_H= HAVE_TM_GMTOFF=1 HAVE_UNISTD_H=1 HAVE_XI_TOUCH_CLASS=1 WITH_CCACHE=ON WITH_CHANNELS=ON WITH_CLIENT=ON WITH_CLIENT_AVAILABLE=1 WITH_CLIENT_CHANNELS=ON WITH_CLIENT_CHANNELS_AVAILABLE=1 WITH_CLIENT_COMMON=ON WITH_CLIENT_INTERFACE=OFF WITH_CUPS=OFF WITH_DEBUG_ALL=OFF WITH_DEBUG_CAPABILITIES=OFF WITH_DEBUG_CERTIFICATE=OFF WITH_DEBUG_CHANNELS=OFF WITH_DEBUG_CLIPRDR=OFF WITH_DEBUG_DVC=OFF WITH_DEBUG_KBD=OFF WITH_DEBUG_LICENSE=OFF WITH_DEBUG_MUTEX=OFF WITH_DEBUG_NEGO=OFF WITH_DEBUG_NLA=OFF WITH_DEBUG_NTLM=OFF WITH_DEBUG_RAIL=OFF WITH_DEBUG_RDP=OFF WITH_DEBUG_RDPDR=OFF WITH_DEBUG_RDPEI=OFF WITH_DEBUG_REDIR=OFF WITH_DEBUG_RFX=OFF WITH_DEBUG_RINGBUFFER=OFF WITH_DEBUG_SCARD=OFF WITH_DEBUG_SND=OFF WITH_DEBUG_SVC=OFF WITH_DEBUG_SYMBOLS=OFF WITH_DEBUG_THREADS=OFF WITH_DEBUG_TIMEZONE=OFF WITH_DEBUG_TRANSPORT=OFF WITH_DEBUG_TSG=OFF WITH_DEBUG_TSMF=OFF WITH_DEBUG_WND=OFF WITH_DEBUG_X11=OFF WITH_DEBUG_X11_CLIPRDR=OFF WITH_DEBUG_X11_LOCAL_MOVESIZE=OFF WITH_DEBUG_XV=OFF WITH_DSP_EXPERIMENTAL=OFF WITH_FAAC=OFF WITH_FAAD2=OFF WITH_FFMPEG=OFF WITH_GFX_H264=OFF WITH_GPROF=OFF WITH_GSM=OFF WITH_GSSAPI=OFF WITH_GSTREAMER_0_10=OFF WITH_GSTREAMER_1_0=OFF WITH_ICU=OFF WITH_JPEG=OFF WITH_LAME=OFF WITH_LIBRARY_VERSIONING=ON WITH_LIBSYSTEMD=OFF WITH_MACAUDIO=ON WITH_MACAUDIO_AVAILABLE=1 WITH_MANPAGES=ON WITH_MBEDTLS=OFF WITH_OPENH264=OFF WITH_OPENSSL=ON WITH_PCSC=OFF WITH_PROFILER=OFF WITH_PULSE=OFF WITH_SAMPLE=OFF WITH_SANITIZE_ADDRESS=OFF WITH_SANITIZE_ADDRESS_AVAILABLE=1 WITH_SANITIZE_MEMORY=OFF WITH_SANITIZE_MEMORY_AVAILABLE=1 WITH_SANITIZE_THREAD=OFF WITH_SANITIZE_THREAD_AVAILABLE=1 WITH_SERVER=OFF WITH_SERVER_INTERFACE=ON WITH_SMARTCARD_INSPECT=OFF WITH_SOXR=OFF WITH_SSE2=ON WITH_THIRD_PARTY=OFF WITH_VALGRIND_MEMCHECK=OFF WITH_VALGRIND_MEMCHECK_AVAILABLE=1 WITH_X11=ON WITH_X264=OFF WITH_XCURSOR=ON WITH_XEXT=ON WITH_XFIXES=ON WITH_XI=ON WITH_XINERAMA=ON WITH_XKBFILE=ON WITH_XRANDR=ON WITH_XRENDER=ON WITH_XSHM=ON WITH_XV=ON WITH_ZLIB=ON
Build type:          Release
CFLAGS:               -Wno-unused-parameter -Wno-unused-macros -Wno-padded -Wno-c11-extensions -Wno-gnu -Wno-unused-command-line-argument -Wno-deprecated-declarations -DWINPR_DLL
Compiler:            Clang, <IP_ADDRESS>00033
Target architecture: x64
OS version connecting to: Windows 7

OS: macOS Catalina
Version 10.15.3

sounds like an issue with mac and X11, file copy on linux (X11 and XWayland) work fine. Does it maybe not announce the formats properly?

what formats?

Clipboard formats (atoms)
https://www.uninformativ.de/blog/postings/2017-04-02/0/POSTING-en.html
Has a nice explanation of x11 clipboard.

I use this format -- CLIPBOARD: The “Ctrl+C clipboard”... I don't konw if this format was properly announce or not... Is there any way that I can be sure?

I don't know how mac x11 announces it has files in the clipboard (or if it does at all)
Does it work with the mac client?

I can copy & paste files in mac itself... if that's what you meant... I not sure I understand...


Collection of loss of knowledge

Description
This issue collects the cases of "loss of knowledge": Because programmers come and go, when a project has been ongoing for quite a long time, the knowledge of some part of the code may get lost along the way.
It needs further evaluation to see if this is caused by lack of good documentation, but usually that means the implemented feature is not important in practice so nobody really cares.

xorg.conf: VIDEOADAPTOR section
See xorg.conf: VIDEOADAPTOR SECTION:

Nobody wants to say how this works. Maybe nobody knows ...

The screenshot:


Add parser support for middle names and suffix

I had to remove support for spaces in last names as its impossible to tell them apart from middle names, middle initial, or a suffix.
In the following example Mc will now be omitted as the middle name (verified it is not needed to look up reservations):
Steve Mc Lovin's 12/25 Boston Logan trip (ABC123)
Any ideas on how to solve both?
I made quite a few changes, let me know if you want me to revert anything :)

Thanks @ScottBishop! I cleaned up the regex a bit, and I'll reopen the issue for matching names like "Mc Lovin" for now. No need to try and fix it all now... the new email formats may even join the two parts.
#50


sql/mysql_db: Make the update counter atomic in order to not race on reads and writes of it.

Superseded by #1904


Typo in selection operator definition produces segfault on CLI

--male-selector tournamen:2  (missing t) segfaults
--male-selector tournament:2 works
Expected: better error message, that the selection operator cannot be found.

thanks!


Request: newOpenFolderDialog()

Similar to newOpenFileDialog() but which allows the user to select a folder, such as for the destination for a series of files to be saved.
At present I believe the only way to do so is to get them to select a file in the target directory and extract the directory from that file path.

@WilliamDraco Here you are :) Hope this works for you.


Add diagnostics sidecar and support for zipkin in deployed apps

Adds a diagnostics sidecar and the ability to push distributed traces to zipkin for deployed applications.
The sidecar uses the same diagnostics sink code we use for local run, so we can easily add support for providers to each one. The one delta is that the diagnostics code can use service discovery, so in local run we have to provide diagnostics with a URI/key/etc, and in deployed applications that can come from service discovery.
From this point it will be really easy for us to add anything push-based for diagnostics. The main blockers have been worked out 👍

We really shouldn’t point to your random docker hub image

Yeah, I'll log an issue :)


[Idea] Lazy / deferred processing of rules requiring parent / next / previous

Hi,
this is just an idea about possible approach to solve the problem that some rules, and only in some situations (ie. when various previous skipIf checks don't stop the rule processing for other reasons) require the parent / next / previous attributes from NodeConnectingVisitor, but enabling it for all files causes significant increase in memory use.

When any rule tries to access such property, mark it for deferred processing with NodeConnectingVisitor enabled and continue to next file
Process the files marked for deferred processing with NodeConnectingVisitor enabled

The advantage is that you would solve the problem for all such rules at once, without the need to rewrite them using custom node visitors, which might end up clogging the performance too, eventually, if there is a lot of them written for a lot of specific rules..
WDYT?

Hi,
I'm not sure how it would exactly work, but please give it a go. If you can make this lazy and performant, I'd love to use such algorithm here.

Thanks for the feedback - I will try to take a look at this. Maybe this is something which should be introduced on phpstan level - lazy node visitors. I will ask them what they think about such idea, maybe it will help inform the right approach. I will keep this thread updated.

One month later I'm checking issues here.

Maybe this is something which should be introduced on phpstan level

I think that's the case, or at least a PHPStan extension. One way or another, I think Symplify is not right place for this, as we work with axiom the nodes are connected. I'd love to see this feature in PHPStan or extension though :+1:


self.driftwood unneeded in classes

"Driftwood" is already set as a builtin pointing to the engine instance at startup. Other class instances do not need to receive a reference to it as self.driftwood, as they can simply use the builtin.

Nevermind actually. Code-wise, it is probably cleaner to trace back to the class through internal variables whenever we can.


Packal support

Hey man, just wanted to thank you for putting together this workflow. I use font awesome quite a bit and its a real life saver. One (hopefully small) feature request. Would you consider adding the workflow to Packal? Its quite handy to grab all ones workflows from the Packal repository in one fell swoop. Just a thought, and thanks again.

Sorry, no thanks.


Sending an activity inside a Prompt Validator doesn't fire the Retry Prompt message

Version
netcore 2.1, SKD 4.0
Describe the bug
I have an imput prompt (TextPrompt, ConfirmationPrompt) with an associated promptValidator method and a PromptOptions object with a RetryPrompt.
If inside the PromptValidator method (that returns a Task<bool>) i send an activity, the RetryPrompt from PromptOptions is never sent.
To Reproduce
Steps to reproduce the behavior:

Have a custom prompt validator method for any prompt.
Have a retry prompt message on said prompt.
Send an activity from inside the custom prompt validator method.
See that the activity from inside the prompt validator is sent but the retry prompt is not.

Expected behavior
I expect to be able to send an error message from inside the prompt validator while still being able to send the retry prompt if the validation fails.
Screenshots
If applicable, add screenshots to help explain your problem.
private async Task<DialogTurnResult> AskEmailStepAsync(WaterfallStepContext stepContext, CancellationToken cancellationToken)
{
    var promptOptions = new PromptOptions
    {
        Prompt = MessageFactory.Text("Please enter your username (email)"),
        RetryPrompt = MessageFactory.Text("This email does not exist. Please try again. You can cancel anytime.")
    };

    return await stepContext.PromptAsync("EmailValidator", promptOptions, cancellationToken);
}

private async Task<bool> ValidateEmailAsync(PromptValidatorContext<string> promptContext, CancellationToken cancellationToken)
{
    var email = promptContext.Context.Activity.Text;

    var userCollection = await PrestashopApi.GetCustomerByEmail(email);

    if(userCollection.Elements.Count == 0)
    {
        await promptContext.Context.SendActivityAsync("Send some other message");
        return await Task.FromResult(false);
    }

    return await Task.FromResult(true);
}

If I comment out the SendActivityAsync line, the RetryPrompt is sent as expected.

[bug]

Interesting.. I just found that in the library, they check this:
https://github.com/microsoft/botbuilder-dotnet/blob/4df966c2a1904b2f72365dbdbd0ab12f4a356a66/libraries/Microsoft.Bot.Builder.Dialogs/Prompts/Prompt.cs#L160
So it seems to be the designed behavior, but I am not sure.

I see... The obvious workaround which is setting Responded to false after sending the activity in the PromptContext is not possible because Responded is readonly.
So is the Responded flag set to true even if it's the bot and not the user who "responded" the previous activity? I don't get why should it be that way.

@fcapallera I think it means that when developer sends something, it suppresses the original RetryPrompt automatically.
So in your scenario, you should also send promptContext.Options.RetryPrompt after "Send some other message".

Thanks, I didn't think about that! I'll close the issue since it wasn't a bug.


feat(goal_planner): do not decelerate before path candidates generation

Description

prevent decelerate before path candidates generation

after
https://github.com/autowarefoundation/autoware.universe/assets/39142679/8dd82f2a-80cd-4128-92e8-957347699ed4
Related links

https://tier4.atlassian.net/browse/RT1-4130
Tests performed

psim
evaluator_description: feat/decel
2023/10/25 https://evaluation.tier4.jp/evaluation/reports/15bdc237-bcbb-565e-aae6-8e5d88161709/?project_id=prd_jt
Notes for reviewers

none
Interface changes

none
Effects on system behavior

none
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.

[ ] I've confirmed the contribution guidelines.
[ ] The PR follows the pull request guidelines.

In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.

[ ] The PR follows the pull request guidelines.
[ ] The PR has been properly tested.
[ ] The PR has been reviewed by the code owners.

Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.

[ ] There are no open discussions or they are tracked via tickets.
[ ] The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.


Navigation bar isTranslucent = false is not working correctly

this pod makes navigation translucent automatically but if you want to use it not translucent your collection views section header will be under navigationBar.

Yes, sticky collection view headers don't work when navigation bar isTranslucent is set to false. When set to true, the section header also hides along with the navigation bar.

@andreamazz


⚠ ClamAV has degraded performance

In dda2e43, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 666 ms

Resolved: ClamAV performance has improved in e751b3e after 535 days, 0 hours, 14 minutes.


Adding advanced settings

This PR is updating deployment state by adding advancedSettings which provide batch size and subscriptions.
Example of request:
{
  "version": "d62369346370689935ad68db1c970302e7243b60",
  "endpoint": "",
  "dictEndpoint": "",
  "indexerImageVersion": "v0.33.0",
  "queryImageVersion": "v0.14.1",
  "type": "stage",
  "subFolder": "",
  "advancedSettings": {
    "@subql/node": {
      "batchSize": 30,
      "subscription": false
    },
    "@subql/query": {
      "subscription": false
    }
  }
}

Hello @fewensa !
Could you check my PR? I haven't access to add the Reviewers.

Hi @stepanLav , I'm already add you to collaborators for this repository, If you are interested. You can accept the invitation.

https://github.com/fewensa/subquery-cli/releases/tag/v0.2.6


Extract SyntaxError position comparison as a utility.

We have code that wants to assert that a some error happened at some position, we should write a function to do this versus forcing the pattern matching boilerplate at the call site.

Similar to the other code--this probably suggests we should extract this out now that I think about it.
Originally posted by @almann in https://github.com/partiql/partiql-lang-rust/pull/15#discussion_r630733972

No matter what we do for #18, we probably want some kind of utility to do this.  E.g.
fn eq_without_message(&self, other: &ParserError) -> bool { ... }

I actually think this is rather ergonomically possible today in a more general manner with:
assert!(matches!(
    error,
    ParserError::syntax_error(_, Position::at(12, 3))
)


Should not start in untrusted Attempting to start a server because of preload conditions

Validated. Turned on preload in a new workspace. Tried with both ZMQ on and ZMQ off. No preload when opening a notebook:


Auto increase textarea box according to message in message box

In message board the input box should auto expand but scroller should not be visible

Sure

@SubodhDahal nice work, thanks!


[MB-8311] Set move status to approvals requested when customer uploads amended orders

Description
As a TOO
When a customer uploads a new set of orders
Then I need the move to be transitioned to the Approvals Requested status
So that I can notice and process changes to the move
Reviewer Notes
The upload amended order functionality is not yet done, as best I am aware. As best I understand, though, this will cover the functionality we need to route a move to approvals requested status when a customer submits a move with amended orders. The status of that resubmitted move should still be "approved," and so I just used the existing function to set the status to approvals requested, but renamed it to make it more generic.
Setup
make server_test

Maybe there is a better way to validate this, pending other work? Maybe I'm wrong and this can be verified in a different way?
Code Review Verification Steps

[ ] If the change is risky, it has been tested in experimental before merging.
[ ] Code follows the guidelines for Logging
[ ] The requirements listed in Querying the Database Safely have been satisfied.
Any new migrations/schema changes:

[ ] Follow our guidelines for zero-downtime deploys (see Zero-Downtime Deploys)
[ ] Have been communicated to #g-database
[ ] Secure migrations have been tested following the instructions in our docs

[ ] There are no aXe warnings for UI.
[ ] This works in Supported Browsers and their phone views (Chrome, Firefox, IE, Edge).
[ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
[ ] User facing changes have been reviewed by design.
[ ] Request review from a member of a different team.
[ ] Have the Jira acceptance criteria been met for this change?

References

Jira story for this change

Messages

:book:
:link: MB-8311

  Generated by :no_entry_sign: dangerJS against 3bf47ceac39c236f3ac4e4dbe306f056abf56514


aws-network-topology-operator deletion blocked (finalizer not removed)

Bug description
Same situation as https://github.com/giantswarm/roadmap/issues/3383 – a CAPA WC that was deleted very soon after creation.
The network-topology.finalizers.giantswarm.io finalizer remained on the AWSCluster object and the operator happily says it's done:
aws-network-topology-operator-658cfb4948-d57ss aws-network-topology-operator 2024-04-04T12:34:52.740366913+02:00 2024-04-04T10:34:52Z	INFO	Reconciling delete	{"controller": "cluster", "controllerGroup": "cluster.x-k8s.io", "controllerKind": "Cluster", "cluster": {"name":"tsa03","namespace":"org-adidas"}, "namespace": "org-adidas", "name": "tsa03", "reconcileID": "1a2478bb-2f87-43eb-980b-9e09e661ac68"}
aws-network-topology-operator-658cfb4948-d57ss aws-network-topology-operator 2024-04-04T12:34:52.740370039+02:00 2024-04-04T10:34:52Z	INFO	Done reconciling	{"controller": "cluster", "controllerGroup": "cluster.x-k8s.io", "controllerKind": "Cluster", "cluster": {"name":"tsa03","namespace":"org-adidas"}, "namespace": "org-adidas", "name": "tsa03", "reconcileID": "1a2478bb-2f87-43eb-980b-9e09e661ac68"}

At first glance, it looks like the operator's reconcileDelete function is not removing the finalizer at all:
https://github.com/giantswarm/aws-network-topology-operator/blob/6e6fbd7e3103e4460888314b83771ec460ec8173/controllers/networktopology.go#L131-L151
There's no defer-ede patch/update of the object, as seems to be in reconcileNormal. Likely we didn't catch this blatant bug ever since this code was introduced, or I'm wrong with this first look into the code 🤷.
Designed behavior
Deletion works and removes the finalizer once done
Reproduction Steps
See above
Technical information
aws-network-topology-operator v1.7.0

This operator has been archived and merged with https://github.com/giantswarm/aws-resolver-rules-operator. It is not part of the collection and shouldn't be deployed at all

Seems the operator was left over somehow and the app wasn't reconciled anymore. I've removed it manually.


feat: make typing notifier compatible with popout chat logs

Also works with the Popout! module.

Thanks for this.  Well coded and works great!


Allow Pydantic 1.10.13 to mitigate security risk

A new CVE was published (link), in which Pydantic versions below 1.10.13 have a denial of service vulnerability.
Switching to that version causes this:
The conflict is caused by:
    The user requested pydantic>=1.10.13
    ormar 0.12.2 depends on pydantic!=1.7, !=1.7.1, !=1.7.2, !=1.7.3, !=1.8, !=1.8.1, <1.10.9 and >=1.6.1

I think Ormar 0.12.2 will work just fine with Pydantic 1.10.13, and it's a minor version bump and I think Ormar has an automated test suite anyway. We should release a new Ormar minor version, probably 0.12.3, which allows Pydantic 1.10.13 because not everyone can switch to Ormar 2.0.0 right now.
@collerek I think this is urgent since it's a security issue in one of Ormar's dependencies itself.

Pubished 0.12.3. Sorry for long reaction time and thank you for monitoring!


Fix link to vim source

The codemirror vim module has moved into its own github repo. This updates the README link to the new location.

Thank you for this!


Suggestion: don't set default map click listeners other than OnMapClickListener

MapView use a layer approach to handle click on map element. If a click is not handled by a high layer, a lower layer will be able to handle it. For exemple, when a click on a POI occurs, the POI layer will invoke OnPoiClickListener if it is set. If it isn't set the OnMapClickListener will be called.
(Note: I'm not sure of the exact implementation details, I just described what I think it is)
GoogleMap() composable always set   OnPoiClickListener,  OnMyLocationClickListener,  so the fallback to OnMapClickListener and the associate onMapClick callback is never called and you are forced to implement onPOIClick to handle the click even if you don't care about the POI.  MapView also has a default behavior for the onMapClick if you don't set OnMapClickListener that you may want to preserve

@fbarthelery Thank you for opening this issue. 🙏
Please check out these other resources that might be applicable:

Support Console - If you have a support contract.
Discord - chat with other developers
StackOverflow - use the google-maps tag
Google Maps Platform issue trackers

This is an automated message, feel free to ignore.

Thanks for reporting this issue. Maps Compose should mirror the same behavior as the underlying SDK so this should definitely be integrated.

I think even OnMapClickListener should not be set by default. The current implementation prevents clicks on a parent composable.
For example:
Box(Modifier.clickable { foo() }) {
  GoogleMap()
}

foo() will never be called on a click

Thanks @fbarthelery for making this suggestion and @romainpiel for offering a fix! We're validating some of the behaviors reported here.

Hi, this is also a usability issue, because it prevents users from clicking on markers they are standing directly in front of. onMyLocationClick is not nullable, so it always sets a OnMyLocationClickListener on the underlying MapView, which causes the "my location" layer to intercepts clicks.


deb/rpm packaging

Thanks you for this amazing solution/service; I can see a million use cases where I can get a good mileage out of it.
Installing binaries with curl | sh has a bad rep, although this is the easiest way to go and I use it for my project as well. But I would suggest looking at providing rpm/deb packages that can be uploaded to gemfury.com deb/apt repo for free.
Supply chain issue would rather demand having a non-curl-based installation option with a potential gpg signing of the repo and artifacts. This might be way ahead of time, since sshx has just been released, but I'd like to see it mature and look into alternative installation options.
Thanks again, you rock!

Thank you! I'll definitely take a look going forward. Thinking about packaging is a good problem to have out of the space of all problems; my biggest worry upon release was actually about my code, and that my software engineering wouldn't hold up to a lot of traffic :')

Of course deb/rpm would be top notch... But brew or similar would also be a nice step forward.

Hey @ekzhang I have already packed my own rust program, so maybe you can copy from me. I will paste the configuration here:
Cargo.toml
[package.metadata.deb]
copyright = "No Copyright"
maintainer-scripts = "scripts"
priority = "optional"
section = "misc"
extended-description = "<some description>"
license-file = "LICENSE"
name = "<binary name>"

Github Action I used:
  build_linux_x86:
    name: Linux x86_64
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v2
      - uses: actions-rs/toolchain@v1
        with:
          toolchain: stable
          target: x86_64-unknown-linux-gnu
          override: true
      - uses: actions-rs/cargo@v1
        name: Build Release
        with:
          use-cross: true
          command: build
          args: --target x86_64-unknown-linux-gnu --release --all-features
      - uses: actions-rs/cargo@v1
        name: Build Debug
        with:
          use-cross: true
          command: build
          args: --target x86_64-unknown-linux-gnu --all-features
      - name: Rust Cargo Deb Package Build (amd64, Debian)
        run: |
          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y
          source $HOME/.cargo/env
          cargo install cargo-deb
          cargo deb --target=x86_64-unknown-linux-gnu
      - name: Copy binaries
        run: |
          mv target/x86_64-unknown-linux-gnu/release/würfeln ./wuerfeln
          mv target/x86_64-unknown-linux-gnu/debug/würfeln ./wuerfeln-debug
          mv target/x86_64-unknown-linux-gnu/debian/*.deb ./
      - uses: actions/upload-artifact@v2
        with:
          name: wuerfeln-x86_64-unknown-linux-gnu
          path: |
            wuerfeln
            wuerfeln-debug
            *.deb

I also have a postrm script which is in the scripts directory, you should take a look at that too. Although I think it's optional


Docs docusaurus migration

Summary
A docusaurus build of the deno docs
Testing
you can clone and run it locally! cd docs and npm i and npm run start
Requirements

[X] I've read and understood the Contributing Guidelines and have done my best effort to follow them.
[X] I've read and agree to the Code of Conduct.
[ ] I've ran deno task test after making the changes.

no longer implementing this idea -- only open sourcing markdown files


Using streams in Hazelcast, MongoDb and Redis ticket registries

Closes no issues
Following the discussion in #2779, I have migrated this 3 registries to use streams.
Iin the MongoDb one, please review the ToDo annotation and also, previously tickets were being decoded twice

Excellent work my friends, as always. Thank you.

by the way when I merge things, since I have commit access to your repo do you want me to delete the branch too? Or would you rather keep them around and self-clean?

Don't worry about it mate, I will take care of it :)


Use ic_admin fallback till compatibility fixed

Tests can be re-run until they pass, although enforcing fallback should make tests pass, otherwise this is not having effect.

I think this i not needed anymore?  Please reopen if I am wrong.


ValueObject equality and nulls

I have a class (well several classes) that are Value Objects and in my tests, I need to test that some value object is null and my IDE is complaining "Possible null reference argument for parameter 'a' in 'Ardalis.SharedKernel.ValueObject.operator =='"
I fixed the problem by adding to my class:
    public override bool Equals(object? obj) => base.Equals(obj);

    public static bool operator ==(MyValueObject? a, MyValueObject? b)
    {
        if (a is null && b is null)
        {
            return true;
        }

        if (a is null || b is null)
        {
            return false;
        }

        return a.Equals(b);
    }

    public static bool operator !=(MyValueObject? a,MyValueObject? b) => !(a == b);

Which resolved the compile errors. I could always disble the error with a pragma but that always gives me the heebie jeebies.
Would this be a case where you would want compiler flags to provide the nullable and non-nullable versions for the different frameworks?

I missed "this isn't supported, you should make your own", which is what I'll do :)


[SPARK-21981][PYTHON][ML] Added Python interface for ClusteringEvaluator

What changes were proposed in this pull request?
Added Python interface for ClusteringEvaluator
How was this patch tested?
Manual test, eg. the example Python code in the comments.
cc @yanboliang

Can one of the admins verify this patch?

Jenkins, test this please.

Thanks @WeichenXu123, I added it.

ok to test

Test build #81727 has finished for PR 19204 at commit 5a6f9b4.

This patch fails Python style tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81727/
Test FAILed.

Test build #81729 has started for PR 19204 at commit cd84d66.

Test build #81729 has finished for PR 19204 at commit cd84d66.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81729/
Test FAILed.

Test build #81732 has started for PR 19204 at commit e684dbb.

Test build #81732 has finished for PR 19204 at commit e684dbb.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81732/
Test PASSed.

Test build #81777 has started for PR 19204 at commit 7e8bcc7.

Test build #81777 has finished for PR 19204 at commit 7e8bcc7.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81777/
Test PASSed.

Thank you for your review and help @WeichenXu123!

Test build #81858 has started for PR 19204 at commit a980e6b.

Test build #81858 has finished for PR 19204 at commit a980e6b.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/81858/
Test PASSed.

Test build #82040 has started for PR 19204 at commit 8735c4c.

Test build #82040 has finished for PR 19204 at commit 8735c4c.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/82040/
Test PASSed.

Merged into master, thanks.


Release actions enforce artifacts names

🔍 Before submitting the issue

[X] I have searched among the existing issues
[X] I am using a Python virtual environment

🐞 Description of the bug
In the hidden action ```` we can see:
    - name: "Download the library artifacts from build-library step"
      uses: actions/download-artifact@v3
      with:
        name: ${{ inputs.library-name }}-artifacts
        path: ${{ inputs.library-name }}-artifacts

The name of the artifacts can't be specified.
If we want to wider the pyansys actions user base, we need to be more flexible.
📝 Steps to reproduce
Allow optional downloading actions
💻 Which operating system are you using?
Windows
🐍 Which Python version are you using?
3.7
📦 Installed packages
NA

Some actions has skip-install which depending on the action can do just the pip install (i.e. doc-build action) or also the checkout, python install and project install (i.e. check-license action).
We should probably be consistent with its usage.

The goal here is to use the release-* actions right after the build-library and build-wheelhouse. Again, this is related with the philosophy of the actions: if you do not follow the conventions of pyansys/actions you simply can not bennefit from them.
Regarding this comment:

Some actions has skip-install which depending on the action can do just the pip install (i.e. doc-build action) or also the checkout, python install and project install (i.e. check-license action).

The skip-install parameter decides whether to run python -m pip install . or not. The checkout parameter avoids cloning the repo or not doing so.
Both are differnt because you may want to perform other actoins on the repository rather than installing it. For example, you need to check out a pure documentation repository but you can not install it.
Hence, I am closing this issue sicne after checking the usage of skip-install and checkout, both parameters are used in a consistent manner.


make dashboard buttons full width on smaller screens

fixes #1636
not sure how you feel about using a media query like this. but below 490px is where things start getting misaligned and looking odd.

Works for me 👍


MicroBuild v2: changes to project files and build scripts to enable building in MBv2, and PGO builds of ChakraCore; add nuspec for ChakraCore.

Thanks to @Cellule for helping with the PGO configurations.
Includes initial work on NuGet as requested in issue #85

This change is

@Cellule @tcare @digitalinfinity I'd like to get this in ASAP to unblock internal builds. Can you give a quick review?

LGTM, please wait for @digitalinfinity's signoff.

I saw changes to sign ChakraCore.dll, does ch.exe needs that change as well to be signed ?

Reviewed 41 of 41 files at r1.
Review status: all files reviewed at latest revision, 7 unresolved discussions.

bin/ChakraCore/ChakraCore.vcxproj, line 80 [r1] (raw file):
Tom and I determined yesterday that this is indeed a mistake. It should be PGOptimize

Build/Microsoft.ChakraCore.nuspec, line 20 [r1] (raw file):
Why not publish arm binaries as well ?

Build/scripts/finalize_build.ps1, line 1 [r1] (raw file):
When is this run exactly ? Is it once for all flavors or do all flavors run this ?

Build/scripts/post_pgi.cmd, line 6 [r1] (raw file):
Update or remove this comment

Build/scripts/post_pgo.cmd, line 6 [r1] (raw file):
update or remove this comment

Build/scripts/pre_pgi.cmd, line 6 [r1] (raw file):
update or remove comment

Build/scripts/pre_pgo.cmd, line 6 [r1] (raw file):
Update or remove comment

Comments from Reviewable

This nuspec will be used for MyGet packages and should include a ch.exe because we are interested in people being able to easily try the latest features. We will have a separate spec for NuGet which only includes the signed ChakraCore.dll files because it is intended for people to take a dependency on and including the ch.exe host is not productive there.
As for signing ch.exe for the MyGet package, I will follow up with @edmaurer about our exact plan here. It will be easy to add signing to additional binaries if/when we determine we would like to.

Review status: all files reviewed at latest revision, 7 unresolved discussions.

bin/ChakraCore/ChakraCore.vcxproj, line 80 [r1] (raw file):
Thanks. I'm fixing this.
The other location has <LinkTimeCodeGeneration Condition="'$(POGO_TYPE)'=='PGO'">PGOptimization</LinkTimeCodeGeneration>
Is it PGOptimization or PGOptimize?

Build/Microsoft.ChakraCore.nuspec, line 20 [r1] (raw file):
We don't officially support an ARM build at this time for various reasons including because we don't have full test coverage. We should talk about this offline.

Build/scripts/finalize_build.ps1, line 1 [r1] (raw file):
Every flavor runs this. It only deals with creating and deleting files that are used to track the status of just this flavor. There will be a different release configuration that handles running any tasks that involve composing the whole build.

Build/scripts/post_pgi.cmd, line 6 [r1] (raw file):
This is more for documentation for me, so I've removed it from all files (and wrote down the corrected version.)

Build/scripts/post_pgo.cmd, line 6 [r1] (raw file):
Done.

Build/scripts/pre_pgi.cmd, line 6 [r1] (raw file):
Done.

Build/scripts/pre_pgo.cmd, line 6 [r1] (raw file):
Done.

Comments from Reviewable

:+1:

I meant the change you did in ChakraCore.vcxproj
</ItemGroup>
  <!-- Conditionally include the group of files to sign because MBv2 knows what to do with this but the old build definition gets confused. -->
  <ItemGroup Condition="'$(VSO_MICROBUILD_V2)'=='True'">
    <FilesToSign Include="$(OutDir)\ChakraCore.dll">
      <Authenticode>Microsoft</Authenticode>
    </FilesToSign>
  </ItemGroup>

If this is only for MyGet packages then nevermind, but it looks like an instruction to tell microbuildv2 to sign this binary.

Review status: all files reviewed at latest revision, 3 unresolved discussions, some commit checks failed.

bin/ChakraCore/ChakraCore.vcxproj, line 80 [r1] (raw file):
I wasn't able to confirm, but I think it fine as it is.

Comments from Reviewable

Yes, that's right. That ItemGroup tells MBv2 to sign the files included in that group. After discussing offline with @digitalinfinity we've decided that it's best to sign all binaries we release publically in any form as per corp guidelines. The set of files we include in which package is a different issue, and we will probably stick to including both files in MyGet and only ChakraCore.dll/.pdb in the NuGet.

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

bin/ChakraCore/ChakraCore.vcxproj, line 80 [r1] (raw file):
Okay I'm changing PGOnstrument to PGOptimization here.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

bin/ChakraCore/ChakraCore.vcxproj, line 80 [r1] (raw file):
PGOptimize not PGOptimization

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

bin/ChakraCore/ChakraCore.vcxproj, line 80 [r1] (raw file):
Okay I'm changing this one to PGOptimize. Should the other one stay as PGOptimization?

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

Build/scripts/init_build.ps1, line 6 [r1] (raw file):
Done.

Comments from Reviewable

Review status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.

bin/ChakraCore/ChakraCore.vcxproj, line 80 [r1] (raw file):
I need to verify, but leave it like this at this time

Comments from Reviewable

@digitalinfinity @Cellule
Added a new commit to address comments:
Addressed review comments: pgo script folder, sign ch.exe, generalize parameters, create packages.config files dynamically, doc comments.
Does everything look alright?

Reviewed 17 of 38 files at r2.
Review status: all files reviewed at latest revision, 4 unresolved discussions.

Comments from Reviewable

Review status: all files reviewed at latest revision, 1 unresolved discussion.

Build/scripts/pogo_training.ps1, line 24 [r1] (raw file):
Okay, Michael. I'll keep an eye out for that change. For now, this will do.

Comments from Reviewable


Default project fails on eslint.

Brief issue description
es_lint.js does not ignore node_modules, therefore load time of app can be hude
Test case example (desirable)
Create app.js
const Quadro = require('quadro');
Quadro();

npm install
node app.js test

Expected outcome
Application is loaded successfully. node_modules are not linted .
Actual outcome
Nothing. Black terminal. node_modules are linted .

If I remove es_lint.js. Everything is executed correctly.
let report = cli.executeOnFiles([app.appDir])

is blocking execution

It works perfectly fine if I place app.js into app

So by definition eslint ignores node_modules/** only in case that .eslintignore file exists.... if not.. it tests everything (facepalm)
In addition to any patterns in a .eslintignore file, ESLint always ignores files in node_modules/**.

For example, placing the following .eslintignore file in the current working directory will ignore all of node_modules, any files with the extensions .ts.js or .coffee.js extension that might have been transpiled, and anything in the build/ directory except build/index.js:

https://eslint.org/docs/user-guide/configuring

@igorshapiro i suggest at least crate a .eslintignore in example/app so not everyone is facing this issue from example


[SPARK-10887] [SQL] Build HashedRelation outside of HashJoinNode.

This PR refactors HashJoinNode to take a existing HashedRelation. So, we can reuse this node for both ShuffledHashJoin and BroadcastHashJoin.
https://issues.apache.org/jira/browse/SPARK-10887

Merged build triggered.

Merged build started.

Test build #43140 has started for   PR 8953 at commit 0cf8d44.

Test build #43140 has finished for   PR 8953 at commit 0cf8d44.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43140/
Test PASSed.

I think we still need to have a 2-way hash join node that takes two LocalNodes as children. It will internally use the refactored hash join node.

Merged build triggered.

Merged build started.

Test build #43187 has started for   PR 8953 at commit f262b36.

Test build #43187 has finished for   PR 8953 at commit f262b36.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BinarydHashJoinNode(
case class BroadcastHashJoinNode(

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43187/
Test FAILed.

Merged build finished. Test FAILed.

test this please

Merged build triggered.

Merged build started.

Test build #43189 has started for   PR 8953 at commit f262b36.

test this please

Merged build triggered.

Merged build started.

Test build #43201 has started for   PR 8953 at commit f262b36.

Test build #43201 has finished for   PR 8953 at commit f262b36.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BinarydHashJoinNode(
case class BroadcastHashJoinNode(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43201/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #43223 has started for   PR 8953 at commit b9d5bc9.

Test build #43223 has finished for   PR 8953 at commit b9d5bc9.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BinaryHashJoinNode(
case class BroadcastHashJoinNode(

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43223/
Test PASSed.

Merged build triggered.

Merged build started.

Test build #43282 has started for   PR 8953 at commit e8a3d17.

Test build #43282 has finished for   PR 8953 at commit e8a3d17.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BinaryHashJoinNode(
case class BroadcastHashJoinNode(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43282/
Test FAILed.

Merged build triggered.

Merged build started.

Test build #43283 has started for   PR 8953 at commit 65c6a50.

Test build #43283 has finished for   PR 8953 at commit 65c6a50.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BinaryHashJoinNode(
case class BroadcastHashJoinNode(

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43283/
Test PASSed.

Merged build finished. Test PASSed.

As discussed offline, we should explore alternatives where we don't have to wrap local nodes to avoid the wrapping logic. Right now we need to worry about the initialization / prepare / close order and it's easy to miss something there.

@andrewor14 I have made HashJoinNode a trait.

Merged build triggered.

Merged build started.

Test build #43340 has started for   PR 8953 at commit ecbd1d0.

Test build #43340 has finished for   PR 8953 at commit ecbd1d0.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43340/
Test PASSed.

@yhuai thanks, this looks much simpler. My remaining comments are mainly concerned with comments and tests.

Merged build triggered.

Merged build started.

Test build #43352 has started for   PR 8953 at commit 081e331.

LGTM will merge pending tasks. Thanks for addressing the comments so quickly.

Test build #43352 has finished for   PR 8953 at commit 081e331.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BinaryHashJoinNode(
case class BroadcastHashJoinNode(
trait HashJoinNode

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43352/
Test FAILed.

Merged build finished. Test FAILed.

retest this please

Merged build triggered.

Merged build started.

Test build #43366 has started for   PR 8953 at commit 081e331.

Test build #43366 has finished for   PR 8953 at commit 081e331.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class BinaryHashJoinNode(
case class BroadcastHashJoinNode(
trait HashJoinNode

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/43366/
Test PASSed.


After running /time set 0, a player rejoining the server will cause the timer to jump forward

Describe the bug
After running /time set 0, any player rejoining will set the timer as if the command was never ran.
To Reproduce
Steps to reproduce the behavior:

Open a server with SpeedrunIGT
Join the server
After waiting a bit, run /time set 0 to restart the timer
Rejoin the world or have any other player join
The timer should jump forwards as if the command was never ran

Expected behavior
Only the first player joining should start the timer, and then the timer should restart on /time set 0. There should be no other cases that the timer restarts or changes.
Screenshots or logs
Video showing the issue
Versions info :

MC Version: 1.15.2
SpeedRunIGT Version: 10.0
Fabric Loader Version: 0.13.3

Additional context
This issue is a major setback for any 5-9 or 10+ category, as rejoins are frequent, whether they intentional or not.

fixed in 10.1 :)


Feat/158119/rec user login info

Great getting this over the line - make sure to squash commits when all checks have passed..


dma: Enable support on stm32wb, memory to memory mode

Enable memory to memory dma operations on STM32WB series.
Tested on nucleo_wb55rg with dma tests loop_transfer and chan_blen_transfer.
Based  on https://github.com/zephyrproject-rtos/zephyr/pull/20543

LGTM, this focuses on dts changes, so I checked some basic parameters and it seems like everything is fine.

LGTM, this focuses on dts changes, so I checked some basic parameters and it seems like everything is fine.

@cybertale Can you approve the change then ?

@FRASTM should I close this one? I think it is supersede by your work.

Yes, this PR is now covered by the #20825

@FRASTM, thanks for confirming. Let me close this one.


confirm / provide Request encryption public key

Hi, I want to confirm the request to provide a encryption public key with synpress, but I could not find it as a custom command. Is there a way to confirm arbitrary requests to metamask independent of the type via puppeteer?

I tried to implement a new custom command for it, but I am stuck getting puppeteer to find the right buttons.
I tried adding following element to notivication-page.js
const confirmEncryptionPublicKeyButton = `${notificationPage} .request-encryption-public-key__footer__sign-button`;
const rejectEncryptionPublicKeyButton = `${notificationPage} .request-encryption-public-key__footer__cancel-button`;
module.exports.encryptionPublicKeyPageElements = {
  confirmEncryptionPublicKeyButton,
  rejectEncryptionPublicKeyButton,
};

based on the class of both buttons

I also created the new command both in metamask.js and in added it to cypress as a custom command in index.js
  confirmDecryptionRequest: async () => {
    const notificationPage = await puppeteer.switchToMetamaskNotification();
    await puppeteer.waitAndClick(
      decryptPageElements.confirmEncryptionPublicKeyButton,
      notificationPage,
    );
    await puppeteer.metamaskWindow().waitForTimeout(3000);
    return true;
  },

    confirmMetamaskDecryptionRequest: async () => {
      const confirmed = await metamask.confirmDecryptionRequest();
      return confirmed;
    },

@maxhoheiser included in this release<EMAIL_ADDRESS>Thanks for contribution!


Terminal bash shell has job control disabled

Does this issue occur when all extensions are disabled?: Yes

VS Code Version:  1.78.2
OS Version: OSX 10.14.6

GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin18)
Copyright (C) 2007 Free Software Foundation, Inc.

Version: 1.78.2
Commit: b3e4e68a0bc097f0ae7907b217c1119af9e03435
Date: 2023-05-10T14:44:45.204Z (2 days ago)
Electron: 22.5.2
Chromium: 108.0.5359.215
Node.js: 16.17.1
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 18.7.0
Sandboxed: Yes

Steps to Reproduce:

start vscode with "code --disable-extensions"
Open bash terminal

Message displayed:
bash: no job control in this shell

Does not happen using OSX Terminal
No changes made to OS environment/packages etc.  Seems to be new in VSCode
Discovered at least one other user reporting this issue on SO
In that thread, user stated, that rollback to 1.77.3 does not have issue.

استطيع حل المشكلة

/duplicate https://github.com/microsoft/vscode/issues/181939

I also have issues "bash: no job control in this shell" after the VS Code auto updated in 5 days ago (1.78.2). I have no idea how get it works again.

I also have issues "bash: no job control in this shell" after the VS Code auto updated in 5 days ago (1.78.2). I have no idea how get it works again.

The issue was closed because it has already been fixed in the next release.  You can issue a set -m in your bash shell to turn on job control manually while you wait for the next release, or you can download and install the vscode insiders release, where the fix should have already been made.

vscode insiders release 也是不行

I also have issues "bash: no job control in this shell" after the VS Code auto updated in 5 days ago (1.78.2). I have no idea how get it works again.

The issue was closed because it has already been fixed in the next release. You can issue a set -m in your bash shell to turn on job control manually while you wait for the next release, or you can download and install the vscode insiders release, where the fix should have already been made.

Hello I am having this issue and I have downloaded the vscode insiders release. Still at the top of each new  terminal "bash: no job control in this shell" and ctrl c will not work. I have also tried set -m to no avail either. Any help greatly appreciated


Better end biome ClassCastException

Describe the bug
When i try to go to the end island for the biomes it crashes and there is no grass or foliage, better nether some biomes and most grass/moss blocks wont spawn in
Steps to reproduce

...
Logs
The game crashed whilst feature placement
Error: java.lang.ClassCastException: class org.betterx.bclib.api.v2.levelgen.biomes.BCLBiome cannot be cast to class org.betterx.betterend.world.biome.cave.EndCaveBiome (org.betterx.bclib.api.v2.levelgen.biomes.BCLBiome is in module<EMAIL_ADDRESS>of loader 'TRANSFORMER' @28ee882c; org.betterx.betterend.world.biome.cave.EndCaveBiome is in module<EMAIL_ADDRESS>of loader 'TRANSFORMER' @28ee882c)
No response
Additional context
I don’t know if this is happening for everyone but i hope there is a fix for this

sad

Same Issues as described, attached error log
crash-2023-08-24_12.56.11-server.txt