Missing locations while the app is in the background

Describe the bug
I'm using this plugin in my app and it generally works great. Thanks for all the effort you put into it!
Having said that, I noticed in my last recording that there was a place where there were no locations updates for 6 minutes when the app was in the background and after that the GPS seems to trying to reposition itself as the accuracy went down from 120 meters to around 10 in a few seconds.
This can be seen in the following image (I was walking on the blue trail):

I can share the recoding of this session or the log file my app collected if needed.
My question/request is to understand how to better debug these kind of glitches to better understand what went wrong in this case - was the service killed/stopped/paused? the GPS from the phone stopped sending signals? Capacitor stopped receiving messages? etc...
In some cases the OS kills the app, but it doesn't look like it in this case as the app's log doesn't show boot-up messages.
To Reproduce
Steps to reproduce the behavior:

Start location tracking
Go to the background
Return from background
Expect some GPS signal to be collected while in the background - this doesn't happen all the time, and on a trip of around 3 hours it only happened once, while the app went to the background for multiple times for varying time spans.

Expected behavior
Get locations updates while in the background
Screenshots
See above
Smartphone (please complete the following information):

Device: [e.g. iPhone6] Samsung S20
OS: [e.g. iOS8.1] Android
Browser [e.g. stock browser, safari] chrome webview
Version [e.g. 22] 12

Additional context
I think it might prove beneficial to store some logging information in the native code and allow fetching this info when required for better debugging? IDK, any insight and thought will be helpful.
If you think there's something I can push forward in terms of PR please let me know.
This plugin is a core capability of my app and I'm willing to invest the time needed to improve this plugin to better support my needs.

I test this plugin using the example app. If you can reproduce your problem using the example app, then there is a problem with the plugin.
To debug problems, I litter the code with print statements and then walk around with my phone plugged into my laptop, and a debugger open. The relevant Android code is in BackgroundGeolocation.java and BackgroundGeolocationService.java.

Thanks for the super fast response!
I don't think I'll have an easy time reproducing the issue. As I said, I walked for 3 hours and it only happened once.
In most cases I can't walk around with my laptop plugged to my phone to allow debugging so I believe a better debugging option is needed.
This might complicate things a bit but the previous plugin I used had the logs written to an sqlite DB and allowed fetching those when needed.
I really like the simplicity of this plugin and I don't want to return to the old one since its too complicated, but still had some nice features...
I also prefer not to create a fork and have this code available for others.
Let me know how you would like to proceed.

Was your phone locked the entire time? Or just for the short time when it stopped recording?
You could modify the plugin to write to a log file on disk, that would be much simpler than writing to a database. You could also modify your application to write to a separate log file. Then, the log files can be compared.

Ah, yes, disk log file is a lot simpler.
The phone was locked from time to time, not all the time.
In the time this glitch happened (the straight line) it was locked and the positions afterwards are from when it was open and the app in the front. After that and before that it was locked again from time to time without any issues.

Would you be interested in a PR which writes some app logs to file and allowing to retrieve the file's content from capacitor js code?

No, sorry. I intend to keep this plugin as simple as possible. But if you find a way to reliably reproduce the problem I will take a look at it.
Keep in mind that GPS is not super reliable - satellites are constantly moving, and the device must work to maintain a fix. We have found that in certain places, at certain times, with certain devices, or even in certain cars (interference?) GPS can be extremely flakey.

Actually, I'm thinking that this might be a good idea. What about something like this?
BackgroundGeolocation.addWatcher(
    {
        ...

        // In addition to being delivered to the callback, locations can be
        // appended to a file. Locations that have been written to disk are
        // more likely to survive a crash. Each location is JSON encoded and
        // appended to the file as a single line.

        // The "file" option, if specified, is a string containing the URI to a
        // writable file. The file is created if it does not exist.
        file: "file:///path/to/my_locations.txt"

        ...

This is a very simple and elegant solution! I like it.
The only question I have is who manages this file, i.e. can the app delete it? If so, how will the plugin avoid file corruption? Or more to the point when can this file be deleted? Any time? Just when not "watching locations".
Also the file path stuff is super complicated between ios, Android and how capacitor works.
I saw the same problem in sqlite capacitor plugin where giving a location to a file is complicated.
But, nevertheless, I find this as a good improvement where I can later on debug the difference between what I got from the callback and what's in the file. It will help me makes things more robuts, hopefully.
Thanks for considering it!

It is up to the app to delete the file, if it wants to, and it can do any at any time. If at any time the file does not exist and the plugin wants to write a location to it, then a new file will first be created. Why would there be file corruption?

I see. I don't know, if you delete while writing?
In any case, if this is handled by the OS then there's no problem.

If the file is deleted partway through a write (which might be possible if each happen on a different thread) then:

the write operation might fail with an exception, and
the file will end in a partial line.

We can handle the exception, of course, but I think we can leave it up to the consumer of the file to ignore any lines that can not be parsed as JSON.
In practice, I think there will be minimal opportunity for corruption.

I see, you're probably right. I'm in 😄

Would you like to build it?

Whatever works for you. I can give it a go.

Yes please.

I have an initial POC that works on my android device.
I write to the file in the BG service to make sure that I'm writing it in the closest point to when I get the location signal.
I'm pretty sure I don't support cdv:// stuff correctly, not sure how to do that, so currently I only support file://....
Do you think I need to support iOS as well? I feel like these issues mainly exists on android, but I might be wrong, input is welcomed here.
Currently I use location.toString() which actually does a good job of writing all the parameters, if it's critical to write is as a json let me know and I'll move the formatLocation function to the service instead of being in the "controller" class.
Are there tests I need to write? If so I'll need some info on how to do that.

I think it would be a useful feature on iOS because the WKWebView is so prone to crashing.
I imagine file:// is sufficient, I'm not familiar with the cdv:// scheme. A file:// URL is always returned by Filesystem.getUri, right?
I think the file should contain the same format that is delivered to the callback, so yes, JSON please.
There are no tests, but you could modify the example app to make use of this feature.

I had the same problem today twice when I recorded a route.
In both cases the problem occurred after doing a "break" in my route - meaning I was in the same location for a few minutes and the app in the background, the GPS returned to show the current location only when I opened the screen and returned to the app, a straight orange line can be seen in the image below (blue line is the planned route):

the problem might be with the "start sticky" return value (I saw it in a SO question somewhere):
https://github.com/HaylLtd/cordova-background-geolocation-plugin/blob/c5687db452a598008590d1c5dfc6cf628592c15a/android/common/src/main/java/com/marianhello/bgloc/service/LocationServiceImpl.java#L275
The other option might be to use the GPS provider and not the fused location which I was using in the past (which is more noisy but basically what you want to have here - get the data from the GPS):
https://github.com/HaylLtd/cordova-background-geolocation-plugin/blob/c5687db452a598008590d1c5dfc6cf628592c15a/android/common/src/main/java/com/marianhello/bgloc/provider/RawLocationProvider.java#L39
Unfortunately, I didn't have the log PR in my app so I have no more info besides the observation I wrote above.
If you are able to reproduce this, please let me know.
I'll continue investigating this, but I believe there's a real issue here.

I did see similar problems on iOS when taking photos during tracking. So yes, the geo app is in background, but taking a photo shifts the problem rate to about 80% of the tests.
Andreas

i remarks that GPS does not work when the device has no network. Perhaps it is your case.
Instead receive the event with coordinates  i see the log "Location not available".
Easily to reproduce, enable/disable plane mode.

I'm not sure this is the cause in my case, but reception shouldn't matter for in theory, might be another issue...

Facing the same issue on android.

Has anyone encountered the problem where the app ceases to track geolocation while recording a video through the camera, especially when the app is running in the background?


Make the profile builder easier to use and document how to use it

We need a push-button solution for the profile builder, perhaps a script, that makes it super easy to use.  Also document the different ways we invoke it (e.g. example command lines).

Last week I was reading an old blog post about the generate command. How would you feel, @jhendrixMSFT, about me adding files into the profiles directory so that keeping the profiles up-to-date is as easy as running go generate?

I like it.  Presumably we can add something top-level so we only have to invoke it once and it spews out all the profiles?

Exactly :)


emacs environment variables not being detected problem in: (lorri+direnv+emacs-direnv) configuration?

hello there, i integrated lorri with emacs, and i'm having an issue where emacs is not detecting some environment variables: here's the r/nixos reddit post: https://www.reddit.com/r/NixOS/comments/g8jv8k/emacs_environment_variables_not_being_detected/

also, i'm guessing ghcide is not able to detect the haskell Modules like Yesod in the yesod package, because emacs is not detecting the environment variables?

at this point, i have no idea how to fix this problem

Would you please move the issue description from reddit to this issue? Thank you.

i have (lorri+direnv+emacs-direnv) setup which works great. when i open up emacs, it detects my user's shell environment variables(from home.nix's shell) like it's supposed to, but when i cd into a project that has been initialized by lorri, the isolated shell's shellHook environment variables in the shell.nix of the project are not being detected(running: M-x getenv on environment variables returns nothing), so as a workaround, i placed: export EDITOR="$(emacs)" in the shellHook, then in a terminal i cd'd into the directory of that project which is initialized by lorri, then executed the nix-shell command, which then opened emacs with everything working correctly(with both my user's global (home.nix's shell) environment variables and the isolated project's local(shell.nix shell(shellHook)) environment variables being detected by emacs.
(the people in the #emacs channel told me that you can have only one emacs process per altered environment)
so my question is:
is there something that i can setup, so that i can just open up emacs, cd into a directory with a project that's been initialized by lorri, where emacs will automatically detect the environment variables of the associated shellHook in the shell.nix file of the project directory, so that emacs will have both the global and local environment variables?
that would save me from having to manually do those other steps over and over again
(note: ghcide is not detecting modules like Yesod from the haskell package yesod, which i'm guessing also corresponds with environment variables not being detected by emacs)
thanks in advance for the help
i have bash shell enabled in home.nix, and here's my shell.nix file which generates a new shell in isolation:
let
pkgs = import  {};
in
with pkgs;
mkShell
{
buildInputs = with pkgs;
[
(haskell.packages.ghc865.ghcWithHoogle (hpkgs: with hpkgs;
[
control
text
yesod
]))
ghcide-nix installation:
(import (builtins.fetchTarball "https://github.com/cachix/ghcide-nix/tarball/master") {}).ghcide-ghc865
]; # end of buildInputs
shellHook =
''
export EDITOR="$(emacs)"
export HIE_HOOGLE_DATABASE="$(cat $(which hoogle) | sed -n -e 's|.--database \(.\.hoo\).*|\1|p')";
export NIX_GHC="$(which ghc)";
export NIX_GHCPKG="$(which ghc-pkg)";
export NIX_GHC_DOCDIR="$NIX_GHC/../../share/doc/ghc/html";
export NIX_GHC_LIBDIR="$(ghc --print-libdir)";
'';
} # end of mkShell

@Profpatsch , ok, i pasted my issue here, it's a hassle always having to manually run nix-shell to open up emacs with shellHook's environment variables correctly detected by emacs.
so, is there a simple way to fix this issue or automate these steps?
let me know,
thanks in advance !!!

lorri direnv runs the shell hook, but inside of a nix build, not the user shell.
You can work around this by adding the environment setup you want to do in your .envrc file instead.
I opened a documentation issue in https://github.com/target/lorri/issues/390

@Profpatsch , thanks for the help, after running lorri shell, everything seems to be working correctly. apologies i did not see lorri shell in the documentation, i stumbled upon it when running lorri, in which i saw lorri shell towards the bottom of the documentation.
go ahead and close this issue.

@zeta-00 wrote:

go ahead and close this issue.


Goob Coin (Server Currency)

Adds server currency to Goob.
TODO:

[ ] Database

[x] Currency
[ ] Owned Items

[ ]  Systems

[ ] Currency
[ ] Shop

[ ] Payouts

[ ] Surving Rounds
[ ] Greentexting
[ ] Achievements (separate PR for achievement system soon :tm:)
[ ] Patreon Benefit (wait for SimpleStation patreon system?)
[x] Admin Events (commands for admins to add currency, ingame event rewards, and contests like "make lobby art, top 3 get currency")
[ ] Player Gifting (Send other players currency, also allows more complex things like github bounty issues.)
[ ] Challenges (equip a trait that has negative effects for the player, if they survive the round with it, give them extra currency)

[ ] Purchasables

[ ] Loadout Cosmetics / Minor Items (Nothing pay to win, no armor, items will be stuff like lighters and at MOST, an extra medipen or something like that)
[ ] OOC Name Colors/Decorations/Icons (NO FULL MESSAGE COLORING, admins only)
[ ] Github Bounties (Allow players to make issues requesting a feature/content offering currency to the player who completes it)

what's that currency supposed to do

what's that currency supposed to do

funny things

based

what's that currency supposed to do

Well, going off the source, which is monkestation from 13:

Can be used for purchasing things from loadouts, such as cosmetic items (would be more effective with EE loadouts though)
Can also be used for buying other misc cosmetics that you would want to lock behind playtime, like say, a toy Blood Red Hardsuit costume.
Can be traded across players as a form of payment for things... which ends up driving a non insignificant amount of contributions over at MonkeStation.

Theres other things you can do or get with it, such as round start gimmicks like joining by being dropped in a washing machine, or starting with X amounts of maints pills. But thats more WYCI stuff.

what's that currency supposed to do

I've clarified it further in the PR.

Please add gambling

Please add gambling

I'll think about it

now make it a real cryptocurrency :godmode:

gobux

Got a good bit in and realized "huh, saving and writing to the database constantly probably isn't good, and forces me to use async shit, which I hate, so I'll add caches"
6 hours later we have virtually the same exact functionality but now its not Shitcode :tm: !

Condensed scope of this PR so i can get it added it and get an idea of how fast people earn coins before I add the shop

if it works it works
also would be funny to buy antag tokens with them :trollface:

no

epic test fail


Merge to live!

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

.openpublishing.publish.config.json
:white_check_mark:Succeeded

.openpublishing.redirection.json
:white_check_mark:Succeeded

README.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-aspnet.md
:white_check_mark:Succeeded

docs/develop/create-sso-office-add-ins-nodejs.md
:white_check_mark:Succeeded

docs/develop/implementation-details.md
:white_check_mark:Succeeded

docs/develop/office-js-versioning.md
:white_check_mark:Succeeded

docs/develop/office-versions.md
:white_check_mark:Succeeded

docs/develop/troubleshoot-sso-in-office-add-ins.md
:white_check_mark:Succeeded

docs/develop/understanding-the-javascript-api-for-office.md
:white_check_mark:Succeeded

docs/excel/co-authoring-in-excel-add-ins.md
:white_check_mark:Succeeded

docs/excel/custom-functions-overview.md
:white_check_mark:Succeeded

docs/images/excel-tutorial-create-chart.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-create-table.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-filter-and-sort-table.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-freeze-header.png
:white_check_mark:Succeeded

docs/images/excel-tutorial-ribbon-with-protection-on.png
:white_check_mark:Succeeded

docs/toc.yml
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-chart.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-create-table.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-filter-and-sort-table.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-freeze-header.md
:white_check_mark:Succeeded

docs/tutorials/excel-tutorial-protect-worksheet.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


FancyZones is not working right after booting

Microsoft PowerToys version
0.41.4
Running as admin

[X] Yes

Area(s) with issue?
FancyZones
Steps to reproduce
Right after computer boots, screen gets grey and error message pop-ups; "FancyZones is not working".
✔ Expected Behavior
No response
❌ Actual Behavior
FancyZones is not working right after booting
Other Software
No response

@LeeSH825 can you please attach a bug report? Right-click on the PowerToys tray icon, Report Bug. Thanks!

@LeeSH825 if you restart PowerToys manually, does FancyZones work?

PowerToysReport_2021-07-27-20-51-13.zip
Oh sorry. I forget to attach the bug report...
No. Restarting PowerToys doesn't help at all. I can't even open layout editor.

@LeeSH825 according to logs, it looks similar to https://github.com/microsoft/PowerToys/issues/12251.
Would you be able to install a private unsigned build to help us troubleshoot the issue? I added logs to localize the problem.
To help you should

Uninstall PowerToys
Install https://github.com/SeraphimaZ/PowerToys/blob/crash_logs/private_build/PowerToysSetup-0.0.1-x64.exe
Upload the bug report after the issue is reproduced

Thank you!

It works fine with one you've attached. Thank you.

It works fine with new release.! Thank you!!


About pop up

A screen reader can navigate to the "about" menu, but the pop up is not accessible.

Apparently, the about dialog was broken in Quorum Studio in a number of annoying ways. This is now fixed.


a very simple loop based outgoingEnqueueCombi base

I've just noticed that there are no test for outgoingEnqueueCombi, can you add them in another PR?

Sure, I should update aedes-persistence tests

https://github.com/mcollina/aedes-persistence/pull/15 @mcollina

The tests added in aedes-persistence 5.0.1 fails here, I can't release.

let me check it

I was trying to use aedes' fastparallel instance! However I think I should create one here

https://github.com/mcollina/aedes-cached-persistence/pull/10 @mcollina


Add a summary of important choices on the filing failed screen, along with "some debugging information"

Highlight the specific error, such as "Unknown filing codes are not allowed"
Show the filing category, type, and subtype
Show the parties and their roles'

I think this will speed up our testing in the next couple of weeks

I think 9a18154 is good enough for now


Fix build of downstream packages.

Fixed libpointmatcher_ros build in catkin workspace.

LGTM. Thanks!  :+1:

The pkgconfig files are definitely still wrong as they have no way to expand the generator expressions. But I'll leave that to others as my interest is in the CMake config files.
Could you please require that contributors (or Jenkins) do a more complex test than "hey, this library builds alone" before doing such substantial changes to the project?

Could you please require that contributors (or Jenkins) do a more complex test than "hey, this library builds alone" before doing such substantial changes to the project?

If I remember well, the Jenkins pipeline passed for the original PR. Another user also tested and said that it solved the issues with libnabo.
Can you provide more info about your setup and how you tested it? Based on that feedback we could improve the tests.

@peci1 thanks for being quick to solve the dependency issues. We should converge soon ;)

If I remember well, the Jenkins pipeline passed for the original PR. Another user also tested and said that it solved the issues with libnabo.

Yes, but the author of the PR also said that he only tested in build-space. Testing install-space is what's probably missing.
It seems to me that a good way to test the integration would be to have some kind of integration builds which would build all the things down to e.g. ethzasl_icp_mapper (actually doing make install for each repo). This way, you could be sure that changes in the lower-level libraries do not break downstream (or at least some downstream :) ). However, I can imagine such build could also fail when downstream packages get problems, so it probably shouldn't be a hard requirement for accepting PRs to libnabo/pm... Or you could create dummy test packages which would just try to find libnabo/pm via CMake and via pkgconfig and link some super-simple programs utilizing these libraries (ideally requiring the transitive dependency on libnabo via pm).

Could you also have a look at https://github.com/ethz-asl/laser_slam/tree/master/sensor_drivers/velodyne_assembler ? I get the following error:
/usr/bin/ld: /media/data/subt/mapper/devel/lib/libpointmatcher.a(OctreeGrid.cpp.o): undefined reference to symbol 'pthread_create@@GLIBC_2.2.5'
/lib/x86_64-linux-gnu/libpthread.so.0: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status
tradr-laser-slam/sensor_drivers/velodyne_assembler/CMakeFiles/velodyne_assembler_node.dir/build.make:157: recipe for target '/media/data/subt/ws/devel/lib/velodyne_assembler/velodyne_assembler_node' failed
make[2]: *** [/media/data/subt/ws/devel/lib/velodyne_assembler/velodyne_assembler_node] Error 1
CMakeFiles/Makefile2:32852: recipe for target 'tradr-laser-slam/sensor_drivers/velodyne_assembler/CMakeFiles/velodyne_assembler_node.dir/all' failed
make[1]: *** [tradr-laser-slam/sensor_drivers/velodyne_assembler/CMakeFiles/velodyne_assembler_node.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

@peci1 The above issue has been pointed out before by other colleagues. The Octree Grid filter might be missing a pthread depend, which can be fixed easily by linking against pthread.

Okay. Is that something you're about to fix in libpm?

@peci1 I'll take a look during the day and tag you in the PR.
Out of curiosity: what is your build chain?

We use ROS melodic and build ethzasl_icp_mapper with catkin tools.

Which version of gcc/clang?
Target platform x86?
@peci1 PR: https://github.com/ethz-asl/libpointmatcher/pull/417

gcc 7.5.0 (I think bionic default), building for amd64 (but soon we'll also need arm64)


Nil handler bug fix

#100
Matcha no longer panics when route with 'nil' handler is matched, instead throws HTTP status code 501, Not Implemented. Test added to include coverage for this edge case.

Thanks for your pull request, aritt! Apologies for the CI failure; when the org name changed, I had to update to a new Coveralls project, and forgot to re-set the values for failure threshold. It was set to fail on any test coverage drop. This has now been fixed, so your next commit should pass as long as tests pass.
I'm adding some additional comments in code review--please give them a look when you're able!

Thanks for the updates! Merging now.


NOISSUE - Fix docs

What does this do?
Update docs and fix mqtt-bench missing timeout command option

Codecov Report

Merging #952 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
- Coverage   83.75%   83.69%   -0.07%
==========================================
  Files          75       75
  Lines        5288     5244      -44
==========================================
- Hits         4429     4389      -40
+ Misses        590      588       -2
+ Partials      269      267       -2

Impacted Files
Coverage Δ

things/api/things/http/requests.go
87.5% <0%> (-1.39%)
:arrow_down:

things/api/things/http/transport.go
93.77% <0%> (-0.29%)
:arrow_down:

things/api/things/http/responses.go
97.56% <0%> (-0.2%)
:arrow_down:

things/postgres/things.go
79.62% <0%> (-0.19%)
:arrow_down:

things/redis/streams.go
92.18% <0%> (-0.13%)
:arrow_down:

things/api/things/http/endpoint.go
98.54% <0%> (-0.05%)
:arrow_down:

things/postgres/channels.go
81.3% <0%> (+1.45%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 894e1b8...2b9c09a. Read the comment docs.


CI: K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Tests NodePort with Maglev Tests NodePort

CI failure
Hit on PR #13248
/home/jenkins/workspace/Cilium-PR-K8s-1.12-net-next/src/github.com/cilium/cilium/test/ginkgo-ext/scopes.go:514
Can not connect to service "http://<IP_ADDRESS>:30997" from outside cluster
Expected command: kubectl exec -n kube-system log-gatherer-r9dp7 -- curl --path-as-is -s -D /dev/stderr --fail --connect-timeout 5 --max-time 20 http://<IP_ADDRESS>:30997 -w "time-> DNS: '%{time_namelookup}(%{remote_ip})', Connect: '%{time_connect}',Transfer '%{time_starttransfer}', total '%{time_total}'"
To succeed, but it failed:
Exitcode: 28
Err: exit status 28
Stdout:
 	 time-> DNS: '0.000035()', Connect: '0.000000',Transfer '0.000000', total '5.001044'
Stderr:
 	 command terminated with exit code 28

/home/jenkins/workspace/Cilium-PR-K8s-1.12-net-next/src/github.com/cilium/cilium/test/k8sT/Services.go:559

c6cabf88_K8sServicesTest_Checks_service_across_nodes_Tests_NodePort_BPF_Tests_with_direct_routing_Tests_NodePort_with_Maglev_Tests_NodePort.zip
https://jenkins.cilium.io/job/Cilium-PR-K8s-1.12-net-next/552/testReport/junit/Suite-k8s-1/12/K8sServicesTest_Checks_service_across_nodes_Tests_NodePort_BPF_Tests_with_direct_routing_Tests_NodePort_with_Maglev_Tests_NodePort/

Haven't been able to reproduce locally so far (@brb)


Fix mode timer in mode

fixes #373

Coverage remained the same at 90.151% when pulling acc87afe565e0b248ac512df271652a78313d041 on fix_mode_timer_in_mode into f01a45473405d62b0f0a1a9a3c5b060b3d519d8c on dev.

Coverage remained the same at 90.151% when pulling 5e4ccf34785f5dc27550f3e823b2532de0bf26f7 on fix_mode_timer_in_mode into f01a45473405d62b0f0a1a9a3c5b060b3d519d8c on dev.


Have two renderers: Robotskirt / Markdown-It, use DOM-Compare in tests, JSHint linting

Public API after this Pull-Request will be:

renderHtml
renderRobotskirtHtml

uriPolicy is exposed for possible further usage in tests if need be

Looks good for me


Wrong number of death from /germany/history/deaths/:days

Hi
The number of death from histroy data is not correct. See image.
For 24.1.21 the number must be  349 but is 4.
For 23.1.21 the number must be  879 but is 10. (See daily report from RKI https://www.rki.de/DE/Content/InfAZ/N/Neuartiges_Coronavirus/Situationsberichte/Jan_2021/2021-01-24-de.pdf?__blob=publicationFile)
In the /germany reqeust the number is right..
Regards Carsten

Duplicate of #64

Duplicate of #64

Hello @CarstenGorkow
The number of new deaths does not reflect the new deaths on a particular day. The new deaths are all new deaths in the last time that got registered yesterday. There are always delays between the health departments and the RKI.

Hello @CarstenGorkow
The number of new deaths does not reflect the new deaths on a particular day. The new deaths are all new deaths in the last time that got registered yesterday. There are always delays between the health departments and the RKI.


Generators show no useful output

When running any generator, I just get the Ignite header:

I should see a progress bar and completion like ignite add.
Question: is this the plugin's responsibility? I'd think this would be provided by ignite-cli's generator.js.

Note that the generator in question worked fine. I ran it twice though because I didn't think it worked.

#805 fixes this.  CopyBatch wasn't printing anything.  It will now.


chore(main): release 1.2.2

:robot: I have created a release beep boop
1.2.2 (2024-08-28)
Dependencies

update dependencies (#8) (3d724ef)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/aimeerivers/watchthis-home-service/releases/tag/v1.2.2 :sunflower:


Non-SSL includes

Mtgify loads data from non-https sources.

I believe this warning occurs when Gatherer is used as source. Gatherer itself is not the problem but the http link. This might be easily fixable by changing http to https.
Here, the browser does not complain (only https links to scryfall), and here it does (http links to gatherer).
This warning also appears on https://mtgify.org/. I assume, this is the same issue.

Worked perfectly, thanks!


Sample App - the Bluetooth 1MB transfer is done on the Main thread

The problem is the MainActivity methods SayAck / sayHi / sayItWithBigBuffer all call the BTConnectedThread method write.  You can't simply call a method within a thread class (from a second thread) - the only method in a thread class that is on the thread is the overridden run() method.
To see this, add a Log output in the BTConnectedThread.write method:
Log.d(TAG, "Starting write on Thread " + Thread.currentThread());
A solution to this is to make it a HandlerThread instead of Thread - and assign a dedicated Handler and Looper... and have the Bluetooth write be triggered by a message to the HnadlerThread instead of invoking a method directly from outside thread.

Hi,
Thanks for the input! This project is not currently - and hasn't been for awhile - maintained. The new app is located @ https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/tree/master/NativeTestApp
Br,
Tomi

Thank you for the follow-up.  Got it working in a matter of minutes.
I revised the NativeTestApp to have the PeerList show the method of discovery. Feel free to use: https://github.com/RoundSparrow/Thali_CordovaPlugin_BtLibrary/commit/f8f1858b630c7a64b27b8c3faa526681885a27e7

Thanks! Looks good. I'll consider merging you changes the next time I need to do work on the library.

is there a separate library one can use to call methods for the bluetooth
transfer on another app
SmileCs past3.com.ng
On 7 Mar 2016 10:28, "Tomi Paananen"<EMAIL_ADDRESS>wrote:

Thanks! Looks good. I'll consider merging you changes the next time I need
to do work on the library.
—
Reply to this email directly or view it on GitHub
https://github.com/thaliproject/BTConApp/issues/7#issuecomment-193178083
.

The library is here: https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/tree/master/BtConnectorLib
You don't have to build it yourself, but you can get it from Bintray: https://bintray.com/thali/Thali/btconnectorlib2/0.2.6/view
Unfortunately there is little documentation how to use the library at the moment, but you can check the native test app (https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/tree/master/NativeTestApp) although it is quite a handful.

thanks
SmileCs past3.com.ng
On 7 Mar 2016 10:36, "Tomi Paananen"<EMAIL_ADDRESS>wrote:

The library is here:
https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/tree/master/BtConnectorLib
You don't have to build it yourself, but you can get it from Bintray:
https://bintray.com/thali/Thali/btconnectorlib2/0.2.6/view
Unfortunately there is little documentation how to use the library at the
moment, but you can check the native test app (
https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/tree/master/NativeTestApp)
although it is quite a handful.
—
Reply to this email directly or view it on GitHub
https://github.com/thaliproject/BTConApp/issues/7#issuecomment-193180629
.

btconlibrary gradle script not resolving from bintray
SmileCs
past3 software and design studio
past3.com.ng
On 7 Mar 2016 10:38, "egbai mmumene"<EMAIL_ADDRESS>wrote:

thanks
SmileCs past3.com.ng
On 7 Mar 2016 10:36, "Tomi Paananen"<EMAIL_ADDRESS>wrote:

The library is here:
https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/tree/master/BtConnectorLib
You don't have to build it yourself, but you can get it from Bintray:
https://bintray.com/thali/Thali/btconnectorlib2/0.2.6/view
Unfortunately there is little documentation how to use the library at the
moment, but you can check the native test app (
https://github.com/thaliproject/Thali_CordovaPlugin_BtLibrary/tree/master/NativeTestApp)
although it is quite a handful.
—
Reply to this email directly or view it on GitHub
https://github.com/thaliproject/BTConApp/issues/7#issuecomment-193180629
.


[Refactor] timm backbone

Motivation
Some of timm models have different name of classifier. For example vision transformer's classifier name is head.
And timm has 'reset_classifier' to fix classifier. So it looks better to use it.
Modification
Using reset_classifier to make unused parameters nn.Identity.
Add test to check global_pool and classifier is nn.Identity.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
No.
Checklist
Before PR:

[x] Pre-commit or other linting tools are used to fix the potential lint issues.
[x] Bug fixes are fully covered by unit tests, the case that causes the bug should be added in the unit tests.
[x] The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
[x] The documentation has been modified accordingly, like docstring or example tutorials.

After PR:

[x] If the modification has potential influence on downstream or other related projects, this PR should be tested with those projects, like MMDet or MMSeg.
[x] CLA has been signed and all committers have signed the CLA in this PR.

Thanks for your contribution, we will review it recently.


fixes https://github.com/360EntSecGroup-Skylar/excelize/issues/856

PR Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

[ ] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

Codecov Report

Merging #857 (baace20) into master (d932e62) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #857   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files          31       31
  Lines       10840    10843    +3
=======================================
+ Hits        10562    10565    +3
  Misses        155      155
  Partials      123      123

Impacted Files
Coverage Δ

calc.go
97.90% <100.00%> (+<0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d932e62...baace20. Read the comment docs.

LGTM, thanks @jaby.


Adds support to allow Htmx compatibility

I've been playing with HTMX and djdt and I wanted to get them working better together. HTMX is like turbolinks, in that it loads html from the server and then inserts it into the page without reloading the page as a whole. Unlike turbolinks, it has a lot of support for html fragments, to allow loading chunks of the page in place. There are three modes of use with HTMX - the first page load, an htmx fragment load, and a boosted <a> tag.
Here's what I'm thinking for the three differnt modes of operation:

First page load
Nothing needs to change here. This works exactly like any existing page load.

Fragments
The goal here is to append the toolbar content to the end of the request and allow htmx use the hx-oob (https://htmx.org/attributes/hx-swap-oob/) attribute to just swap out the content. The attribute can be added with the setting value ROOT_TAG_EXTRA_ATTRS

This needs a little more consideration. The issues I've found so far:
- The fragments coming from the server don't have a consistent wrapper. It could be as simple as <p>hey<p> So to update the debug info we can't have a consistent string to look for to decide where to insert the toolbar content.
- The javascript on the page needs to be disabled to prevent multiple click handlers
- The javascript on the page needs to be re-inited after the content is swapped in
- The javascript and css that normally come with the response shouldn't be included

Boosted a tag
This works like turbolinks, and I've been able to get this working pretty well using the same strategy used for turbolinks (https://github.com/jazzband/django-debug-toolbar/issues/1179). The fly in the ointment is that unlike the fragment case, this case should NOT include the hx-oob attribute as it's not piggybacking on another request. So I need a way to conditionally include the ROOT_TAG_EXTRA_ATTRS values. Additionally since in this case we've already loaded the css/js we should also exclude those.

An example use of these changes is here: https://github.com/Lightmatter/generic-django-conf/commit/031d4ce49d4b8c5c942690b2f03c56b9450b7923#diff-bed13003085067d79e49d240de44a575e7c9c57073f67710eeb0a59fc32bf21aR31

I don't really like the idea of adding the toolbar HTML to fragment responses. The toolbar HTML will massively outweigh the fragment size.
The "History" panel can already be used to inspect fragments responses, no?

The "History" panel can already be used to inspect fragments responses, no?

Yes, it should be captured there.

I don't really like the idea of adding the toolbar HTML to fragment responses. The toolbar HTML will massively outweigh the fragment size.

I'm open to another approach, but I really like DX of the oob approach. Can you help me understand what cases the html size would be a consideration in?

The "History" panel can already be used to inspect fragments responses, no?

Yes and no - Although it can capture the response, It can't "in the moment". You'll have to refresh the page and then use the history to move back to it, making it much less useful.
I've put up an example of this at https://sampleapp-w4bl.onrender.com/  - it's on the free tier so it's slow.

Can you help me understand what cases the html size would be a consideration in?

🤷♂ I don't have concrete evidence, but it feels wrong. Certain htmx patterns may fetch many small fragment responses, e.g. for autocompletes. Attaching all the toolbar HTML for every response will massively increase the work done by the browser.

You'll have to refresh the page and then use the history to move back to it, making it much less useful.

The history panel has a "refresh" button which allows you to view new requests without reloading the page. IMO a better approach would be to enhance the history panel functionality, perhaps by making it auto-refresh when opened, or even adding an "auto refresh" mode.
(I tried the refresh button on your demo app and it's broken there, perhaps due to this PR?)

I don't really like the idea of adding the toolbar HTML to fragment responses. The toolbar HTML will massively outweigh the fragment size.

I dont see this as a valid reason.  The debug toolbar is only used during development and debugging.  Why is size important in this context?  OOB makes sense to me.

The "History" panel can already be used to inspect fragments responses, no?

No.  Its not working for me with fragments.  In fact its throwing errors:
Uncaught (in promise) TypeError: inner.previousElementSibling is null
    init http://localhost:8000/static/debug_toolbar/js/toolbar.js:45
    promise callback*init/< http://localhost:8000/static/debug_toolbar/js/toolbar.js:44
    on http://localhost:8000/static/debug_toolbar/js/utils.js:6
    on http://localhost:8000/static/debug_toolbar/js/utils.js:3
    init http://localhost:8000/static/debug_toolbar/js/toolbar.js:14
    <anonymous> http://localhost:8000/static/debug_toolbar/js/toolbar.js:307
toolbar.js:45:29
    init http://localhost:8000/static/debug_toolbar/js/toolbar.js:45
    (Async: promise callback)
    init http://localhost:8000/static/debug_toolbar/js/toolbar.js:44
    on http://localhost:8000/static/debug_toolbar/js/utils.js:6
    (Async: EventListener.handleEvent)
    on http://localhost:8000/static/debug_toolbar/js/utils.js:3
    init http://localhost:8000/static/debug_toolbar/js/toolbar.js:14
    <anonymous> http://localhost:8000/static/debug_toolbar/js/toolbar.js:307
    InnerModuleEvaluation self-hosted:2388
    evaluation self-hosted:2349

Certain htmx patterns may fetch many small fragment responses, e.g. for autocompletes. Attaching all the toolbar HTML for every response will massively increase the work done by the browser

Simply update the toolbar after every response.  Sure with autocomplete this will slow the browser down.  But remember.  Were debugging here.  Why does it need to be fast?

We could always defend against browser overload by debouncing or something IF it becomes a problem.

Ok Initial PoC for auto refresh mode.
I would love any feedback/suggestions but the core changes to get this working:

The response that is switchable will now contains headers that contain the store id, signature and url to get data from (https://github.com/jazzband/django-debug-toolbar/pull/1569/files#diff-4c34c65dc0e8564d6d1b67b93a2099a4a8f7a5264cded1f09de5eb724bb6523dR24)
The javascript around the switching function has been broken out so that you can switch through the history panel's button or by passing a store id/data (https://github.com/jazzband/django-debug-toolbar/pull/1569/files#diff-b62b57713c8d077f5a638ab38f847bbc0b6711016acaf14c1f9ec1f8ff100605R130)
An annotation for the XHR prototype that watches all ajax requests and updates the toolbar when appropriate (https://github.com/jazzband/django-debug-toolbar/pull/1569/files#diff-ec4138914976be8d39d9780b045095caba36dfae38e8f8e671279b0d41e3aad6R323)

I would love any feedback about the approach!
Some open questions I have from working through this:
Why are we signing the request for the switch request? We don't sign loading the panel so I'm wondering if this can be removed or if it serves a purpose
I am calling toolbar.store twice: https://github.com/jazzband/django-debug-toolbar/pull/1569/files#diff-4c34c65dc0e8564d6d1b67b93a2099a4a8f7a5264cded1f09de5eb724bb6523dR27 and in the main render call. Can we remove the second one? The comment there says it's being doing for the purpose of the history panel.
This is not in a merge ready state and I have some clean up to do. Some of the changes from the prior approach I need to discard as they no longer matter, and some of them are still important for the boosted case.
Making a todo list for myself:

[ ] Fix git rebase snafoo
[ ] Come up with Better names for the headers
[ ] remove functionality we longer need
[ ] Properly wrap the js prototype annotation into the DJDT namespace, and initialize in the template
[ ] Property wrap the the prototype initialization around a setting value
[ ] Test
[ ] documentation
[ ] BUG: https://github.com/jazzband/django-debug-toolbar/pull/1569/files#diff-9544c759ef64d0c6ba09293b8398aa6a00311339b47afec022bc66af161e6312L25 breaks the historical panel behavior. I'm planning on popping the value client side to get the old behavior, but I could also update the view to take an optional form key to make the decision server side. LMK if there's a preference
[ ] BUG: When switching between pages (htmx boosted mode) a panel that was already loaded in a prior page doesn't have it's scripts reinitialized when loading in the new page

Closing this in favor of #1577 which I think is a more fundamental case. I'll reopen this once that's got a clear way forward and this can focus on just htmx stuff (I think just the boosted link case)


gm fails silently when missing dependencies on mac

Crate
Gaiad Manager gm
Summary of Bug
If an external prerequisites is missing when running gm, the script will fail silently on mac os x.
Version
v0.0.6
Steps to Reproduce
Remove a dependency, e.g. stoml, or change the check in enforce_requirements to something nonsensical, e.g. STOML="$(which stoml12345)" .
Run gm. The informational error messages that are in enforce_requirements does not seem to get printed.
Acceptance Criteria
Receive a helpful message stating which dependency is missing.

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate milestone (priority) applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

Nice find @haasted ! The fix is in progress.


Caching doesn't work for me

I wanted to rebuilt everything from scratch because i've made changes to the desktop application so i just tried the current php file together with the testings.php
Now it says:

Parse error: syntax error, unexpected '[' in /home/u834577974/public_html/call/FileSystemCache.php on line 69

Is that my fault? did i miss downloading anything etc.?

Looks like a PHP 5.4 problem. http://php.net/manual/en/migration54.new-features.php
it's the shortened array syntax. I should probably change that to the traditional one which would allow 5.3 support (which is already required to run this library).

try this: https://github.com/kevinohashi/php-riot-api/commit/1040d2a5d879fb93f26d5a2c0cb91b35c141126a should be good to go

Works perfectly :) Thx for the fast reply!


AvatarStack no longer accepts styled props

See https://github.com/github/primer/issues/296
Merge checklist

[ ] Added/updated tests
[x] Added/updated documentation
[x] Tested in Chrome
[ ] Tested in Firefox
[ ] Tested in Safari
[ ] Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

Hmm, looks like prop documentation isn't working 😢

Hmm, looks like prop documentation isn't working 😢

How strange... it's working locally. I'll investigate!


Pagination not working

Hey,
I've added the footable plugin. The basics work including sortable.
However, pagination isn't working. When I load the page, pagination is not added. After I click one of the sortable-columns, the order changes, and the pagination is added including the pagination-box (with page-numbers).
How's this possible? Am I the only one here?
Greetz

same issue for me , i dont know how manage this.i guess is because the data is injected after the object was built for this reason the pagination dont know how much items have.

same issue for me too.. anyone have a solution?

I found a solution with this couple lines.
$('#tablate').append(html).trigger('footable_redraw');
where tablate is my grid  i put this after the data is loaded and semm like
a fast refresh and the paginations works fine
surhosting.com http://surhosting.com
Especialistas en Web Hosting
<EMAIL_ADDRESS><EMAIL_ADDRESS>Telefono:1 791 5877
CEL:     99 912 3838
2015-09-07 14:22 GMT-05:00 JorgeCLN<EMAIL_ADDRESS>
same issue for me too.. anyone have a solution?
—
Reply to this email directly or view it on GitHub
https://github.com/ziscloud/angular-footable/issues/3#issuecomment-138362718
.

@surnetworks I add a setTimeout to make sure that redraw after ng-repeat
setTimeout(function() {$('#tblOrders').trigger('footable_redraw');}, 1000)

Same here, @xwendotnet solution worked.

This solution worked here also, @xwendotnet

You should  write a directive which waits until data is loaded, then runs $('.footable').trigger('footable_redraw');
There is a fully explained post here : https://www.codetutorial.io/angular-jquery-after-render/


Country dataset

cc @pmeier

@pmeier Thank you for your kind review. Let me check and correct it soon :)

@pmeier  I resend PR with your suggestion and test code.
But there are errors, could you advise me about how to resolve this.

@pmeier I resend the PR with your review.
But I don't exactly understand how to implement by inheriting ImageFolderDataset.
May I ask for your help with this.

@pmeier Really thanks to your review and re-creation of my humble code.
Hope to contribute with better code in next time.


Failed Test PR #11 - Unhandled error in background task

Summary and Screenshots
After starting the strategy, an error message is shown from the log pane.

2023-04-03 14:30:15,987 - 12769 - hummingbot.core.utils.async_utils - ERROR - Unhandled error in background task: [<class 'decimal.InvalidOperation'>]
Traceback (most recent call last):
  File "/Users/admin/pr12-client/hummingbot/core/utils/async_utils.py", line 9, in safe_wrapper
    return await c
  File "/Users/admin/pr12-client/hummingbot/strategy/amm_arb/amm_arb.py", line 213, in main
    profitable_arb_proposals: List[ArbProposal] = [
  File "/Users/admin/pr12-client/hummingbot/strategy/amm_arb/amm_arb.py", line 215, in <listcomp>
    if t.profit_pct(
decimal.InvalidOperation: [<class 'decimal.InvalidOperation'>]

Steps To Reproduce

Clone and install the gateway repo and dev branch of Hummingbot OSS
Connect the client to gateway
Create AMM_Arbritage strategy
Start the bot

Expected Results
The bot will start without any errors
Test Result Comparison
N/A, already in dev branch
Attachments
ZigZag.zip

@mrhzysbl I fixed this. pls confirm.

Confirmed working after commit d518c63


spec: fix links to value commitments section

Oops, missed this. Fine to merge as-is. I've got https://github.com/penumbra-zone/penumbra/pull/2824 that does a bit more, but I'll rebase. Deferring CI changes for now, but nice to have a new tool in the pocket. :sparkles:


gpt4all integration

so I use gpt4all which gets imported as
from langchain.llms import GPT4All
I want to know if I can import from TOT as
from tree_of_thoughts import GPT4ALL
as i use models from GPT4ALL pipeline

You could rename the package: “from … import ABC as ABC_1”

Hey @ProxyAyush can you explain deeper?
If you want you can use GPT4ALL by defining an custom abstract language class that adheres to the following guidelines:
class CustomLanguageModel(AbstractLanguageModel):
    def __init__(self, model):
        self.model = model

    def generate_thoughts(self, state, k):
        #implement the thought generation logic using self.model
        pass

    def evaluate_states(self, states):
        #implement state evaluation logic using self.model
        pass


Does DrupalVM work with Xdebug v3 installed on host?

Issue Type

Bug Report / Support Request

Your Environment

Vagrant 2.2.19
VirtualBox 2.1.26

Your OS

macOS (Big Sur)

Full console output

Summary
Xdebug does not work at all. Is there a way to make DrupalVM upgrade to Xdebug v3 or do I have to downgrade my version of xdebug on my host machine?

Yes, have a way to upgrade but you will need to create a patch for that.
in drupal-vm/provisioning/roles/geerlingguy.php-xdebug/templates/xdebug.ini.j2 you will need to update the fields that you will use according to the xdebug upgrading documentation (https://xdebug.org/docs/upgrade_guide). After that in your box config file you will fill with the variables that you update in xdebug.ini.j2

I managed to get xdebug 3.1.0 working with Drupal-vm & Phpstorm by adding these lines to the xdebug.ini.j2 file, as Guilherme Barbosa suggests:
xdebug.mode={{ php_xdebug_mode }}
xdebug.client_host={{ php_xdebug_client_host }}
xdebug.client_port={{ php_xdebug_client_port }}

Then in config.yml of drupal-vm, append these lines to your other xdebug settings:
php_xdebug_version: 3.1.0
php_xdebug_mode: debug
php_xdebug_client_host: <IP_ADDRESS>
php_xdebug_client_port: 9003


Allow composition

My original idea was to provide ability to composite sphinx configuration from classes instead of declaring it line by line.
You can view example in CompositionTest.
Sorry, I introduced many public api changes. Some of them was must — e.g. add* should accept instance, not create one. Some of them was not — e.g. renames of iterate*.
Also, I separated some (de)serialization logic, because concerns solving logic should be separated.
I hope you understood my original idea besides introducing major api changes.
Please tell me what do you think about such a big rewrite.
Also I leaved some todo comments with my thoughts, please comment them too.

Another thing such composition allows:
abstract class BaseIndex extends Index
{
    public function __construct(Configuration $configuration, $name, $inheritance = null)
    {
        parent::__construct($configuration, $this->getIndexName(), $inheritance);

        $this->addOption(eIndexOption::MORPHOLOGY(), 'lemmatize_ru_all, lemmatize_en_all');
        // any other common index configuration
    }

    /**
     * This method must return index name
     *
     * @return string
     */
    abstract protected function getIndexName(): string;
}

class RealIndex1 extends BaseIndex
{}
class RealIndex2 extends BaseIndex
{}

We can not accept this pull because backward compatibility is lost because of changes in the public api and we are using this library in production.
Also in our code rules we don't use strict types.

Sad to hear. Have you considered releasing new major version?

No, we have no plans to develop this library at the moment. Now it covers all the business requirements that we need. However, it is distributed by the MIT license, so you can fork it and use it as you want.


secretObjects not working as expected

Firstly, apologies if this is a misconfiguration on my end and not a bug.
I have the following Secrets Manager object:
{
  "username": "admin",
  "password": "abc123",
}

And the following SecretProviderClass:
apiVersion: secrets-store.csi.x-k8s.io/v1alpha1
kind: SecretProviderClass
metadata:
  name: database-secrets
spec:
  provider: aws
  secretObjects:
  - secretName: db-creds
    type: Opaque
    data:
    - objectName: database-secrets
      key: username
    - objectName: database-secrets
      key: password
  parameters:
    objects: |
        - objectName: "database-secrets"
          objectType: "secretsmanager"
          jmesPath:
              - Path: "username"
                ObjectAlias: "username"
              - Path: "password"
                ObjectAlias: "password"

This does create a secret with the correct fields, but the data inside them is always the full JSON object, and not the individual value (secret decoded for readability):
apiVersion: v1
data:
  password: {"username":"admin","password":"abc123"}
  username: {"username":"admin","password":"abc123"}
kind: Secret
metadata:
  name: db-creds
type: Opaque

I expected:
apiVersion: v1
data:
  password: "abc123"
  username: "admin"
kind: Secret
metadata:
  name: db-creds
type: Opaque

Versions:

k8s: 1.21
secrets-store-csi-driver-provider-aws: 1.0.r2-2<IP_ADDRESS>.34-linux-amd64
secrets-store-csi-driver: v0.2.0

@fert-f you are almost there.  Try something like this
apiVersion: secrets-store.csi.x-k8s.io/v1alpha1
kind: SecretProviderClass
metadata:
  name: csi-poc-aws-secrets
  namespace: kube-public
spec:
  secretObjects:
  - secretName: csi-poc
    type: Opaque
    labels:
      provider: "csi-driver"
    data:
    - objectName: csi-poc-username
      key: username
    - objectName: csi-poc-password
      key: password
  provider: aws
  parameters:
    objects: |
        - objectName: "/secrets/xxx/csi-poc"
          objectType: "secretsmanager"
          objectVersionLabel: "AWSCURRENT"
          objectAlias: csi-poc
          jmesPath:
          - path: "username"
            objectAlias: "csi-poc-username"
          - path: "password"
            objectAlias: "csi-poc-password"

Notice that rather than defining the secret twice, the secret is only defined a single time, just with two data items in it.

I am almost there, but now I have separate file with correct credentials, but when I call my code, the env variables still have the full Json object:
apiVersion: secrets-store.csi.x-k8s.io/v1alpha1 kind: SecretProviderClass metadata:   name: aws-secret-application spec:   provider: aws   secretObjects:     - secretName: csi-secrets       type: Opaque       labels:                                            provider: "csi-driver"       data:         - objectName: postgresql_database           key: main_database         - objectName: postgresql_host           key: main_host         - objectName: postgresql_user           key: main_username         - objectName: postgresql_password           key: main_password   parameters:     objects: |       - objectName: "rds-secrets"         objectType: "secretsmanager"         objectAlias: csi-secrets         jmesPath:            - path: "main_database"             objectAlias: "postgresql_database"           - path: "main_host"             objectAlias: "postgresql_host"           - path: "main_username"             objectAlias: "postgresql_user"           - path: "main_password"             objectAlias: "postgresql_password"
Which generates the files with correct values from each key:
# ls -ltr /mnt/secrets-store/ total 20 -rw-r--r-- 1 root root   8 Aug 31 21:16 postgresql_user  # has the value of postgresql_user key -rw-r--r-- 1 root root  20 Aug 31 21:16 postgresql_password  # has the value of postgresql_password key -rw-r--r-- 1 root root  48 Aug 31 21:16 postgresql_host  # has the value of postgresql_host key -rw-r--r-- 1 root root   7 Aug 31 21:16 postgresql_database  # has the value of postgresql_database key -rw-r--r-- 1 root root 156 Aug 31 21:16 csi-secrets  # contains full JSON object with all the key/values
When I call them in my Deploy, i still get each env variable that contains the full json:
postgresql_host={"main_database":"value","main_host":"value","main_password":"value","main_username":"value"} postgresql_database={"main_database":"value","main_host":"value","main_password":"value","main_username":"value"} postgresql_user={"main_database":"value","main_host":"value","main_password":"value","main_username":"value"}
deployment code:
      volumes:         - name: api-secret           csi:             driver: secrets-store.csi.k8s.io             readOnly: true             volumeAttributes:               secretProviderClass: "aws-secret-application"       containers:         - name: api           image: "{{ .Values.images.api.image.repository }}"           imagePullPolicy: Always           ports:             - containerPort: 80           volumeMounts:             - name: api-secret               mountPath: "/mnt/secrets-store"               readOnly: true           env:             - name: postgresql_database               valueFrom:                 secretKeyRef:                   name: postgresql_database                   key: main_database             - name: postgresql_host               valueFrom:                 secretKeyRef:                   name: postgresql_host                   key: main_host             - name: postgresql_user               valueFrom:                 secretKeyRef:                   name: ngs-rds-secrets                   key: main_username             - name: postgresql_password               valueFrom:                 secretKeyRef:                   name: ngs-rds-secrets                   key: main_password
Not sure what else do try... or how to call those values from each file in the env

@oyamin, I think you env should reference secret created by SecretProviderClass. Not sure where ngs-rds-secrets came from:
          env:
            - name: postgresql_database
              valueFrom:
                secretKeyRef:
                  name: csi-secrets
                  key: main_database
            - name: postgresql_host
              valueFrom:
                secretKeyRef:
                  name: csi-secrets
                  key: main_host
            - name: postgresql_user
              valueFrom:
                secretKeyRef:
                  name: csi-secrets
                  key: main_username
            - name: postgresql_password
              valueFrom:
                secretKeyRef:
                  name: csi-secrets
                  key: main_password

@fert-f That was the old value from the original code. But all names where the same. It would not even deploy if the name in secretKeyRef didn't exist.

I was having the same issues as @oyamin but I got it to work. There were multiple issues. First, commenting out the env parts in my deployment (to avoid downstream errors), I noticed the files were not getting mounted into the filesystem as per file named in jmesPath.objectAlias as they were in another cluster where secrets were working properly. I was able to resolve this by uninstalling/reinstalling the csi-secrets-store to their latest versions. Make sure all the csi related pods in the kube-system namespace roll over.
e.g.
helm -n kube-system uninstall csi-secrets-store
kubectl -n kube-system delete daemonsets/csi-secrets-store-provider-aws

Then:
$ helm repo add secrets-store-csi-driver https://raw.githubusercontent.com/kubernetes-sigs/secrets-store-csi-driver/master/charts
$ helm -n kube-system upgrade -i csi-secrets-store secrets-store-csi-driver/secrets-store-csi-driver --set syncSecret.enabled=true
$ curl -s https://raw.githubusercontent.com/aws/secrets-store-csi-driver-provider-aws/main/deployment/aws-provider-installer.yaml | kubectl apply -f -

After that, when I rolled over my application pods, they did have the mounted but the env variables were still  wrong. This was also visible with kubectl describe secrets/<myappsecrets>. Eventually I thought to remove the secret and sure enough when I reinstalled my Helm chart/reapplied my configs, it was corrected.

Found with similar issue recently.
I found that "jmesPath" should not contain any special characters like "-".
For example "main**-database" wont work. But "main_**database" will work.

I have spent a bit on this too and its it looks like jmesPath is not working as expected. It will not make each json key/value into its own file or separate it into a value thats useable in the env variables. it's just plain broken

#66

Faced with similar issue recently - and spend couple of hours to find out.. I found that "jmesPath" should not contain any special characters like "-". For example "main-database" wont work. But "main_database" will work.

in my case that was /, though, - worked
somebody definitely should doc up this one moment


fetchurl: strip query from filename

Motivation for this change
When fetching url like https://bug-220081-attachments.webkit.org/attachment.cgi?id=416707&action=diff&format=raw , the filename contains query separator & which is invalid as path name in Nix. In fact, since it's not part of path according to URI syntax, we can simply strip the whole query component.
Things done
Manually fetchpatch the patch mention above and it works.

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[x] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[x] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

Please target staging.

I just wrote the related NixOS/rfcs#84, where I intentionally pointed out that all fetchers should use the same name, so that the store path can be reused between them. In this case, we also have nix-prefetch-url which currently fails with the same error as pkgs.fetchurl, builtins.fetchurl or <nix/fetchurl.nix>. This PR would make pkgs.fetchurl not fail where nix-prefetch-url, builtins.fetchurl and <nix/fetchurl.nix> still would.
I think let's first see where the discussion in NixOS/rfcs#84 goes, because depending on that, this PR might not be necessary, or this PR's behavior could also be applied to all other URL fetchers.


Hard coded files (mostly missing)

pan:dukes wf$grep Users/jpoint/Repositories $(find . -name *.java)
./boss-hogg/src/main/java/nl/vaneijndhoven/dukes/bosshogg/BossHogg.java://        vertx.eventBus().sendObservable(Characters.DAISY.getCallsign() + "lane.start", new JsonObject().put("source", "file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/full_run.mp4"));
./daisy/src/main/java/nl/vaneijndhoven/opencv/video/StartLightDetectionController.java:            this.capture.open("file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/startlamp2.m4v");
./daisy/src/main/java/nl/vaneijndhoven/opencv/video/LaneDetectionGUI.java://             this.capture.open("file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/stopzone2.m4v");
./daisy/src/main/java/nl/vaneijndhoven/opencv/video/LaneDetectionGUI.java:             this.capture.open("file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/full_run.mp4");
./duke-farm/src/main/java/nl/vaneijndhoven/dukes/dukefarm/DukeFarm.java://                vertx.eventBus().send(Events.STREAMADDED.name(), new JsonObject().put("source", "file://Users/jpoint/Repositories/dukes/daisy/src/main/resources/videos/full_run.mp4"));
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/CameraMatrixTest.java:        Files.newDirectoryStream(Paths.get("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/cameramatrix"),
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/CameraMatrixTest.java:        Mat image = Imgcodecs.imread("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/cameramatrix/test_image.jpg");
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/CameraMatrixTest.java:        Imgcodecs.imwrite("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/cameramatrix/debug.jpg", undistorted);
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java://        Files.newDirectoryStream(Paths.get("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift"),
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java:        Mat original = Imgcodecs.imread("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift/screen_shot.png");
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java:        Imgcodecs.imwrite("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift/debug.jpg", image);
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java:        Imgcodecs.imwrite("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift/debug2.jpg", shifted);
./uncle-jesse/src/main/java/nl/vaneijndhoven/dukes/unclejesse/StartLightDetectionController.java://            this.capture.open("file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/startlamp2.m4v");
./uncle-jesse/src/main/java/nl/vaneijndhoven/dukes/unclejesse/LaneDetectionGUI.java:////             this.capture.open("file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/stopzone2.m4v");
./uncle-jesse/src/main/java/nl/vaneijndhoven/dukes/unclejesse/LaneDetectionGUI.java://             this.capture.open("file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/full_run.mp4");

@timve do you still have these files used in the tests? If you, can you add them (or put them on WeTransfer or something so @WolfgangFahl can add them and test)

file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/full_run.mp4
file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/startlamp2.m4v
file://Users/jpoint/Repositories/opencv-playground/src/main/resources/videos/stopzone2.m4v
These are large files, probably not wise to add to the source tree? I have uploaded them to WeTransfer https://we.tl/t-SfjUujW45G
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/CameraMatrixTest.java:        Files.newDirectoryStream(Paths.get("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/cameramatrix"),
This uses files from test resources which are present in source control, should be present in the target/test-classes dir after compilation of test sources (path will be different of course)
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/CameraMatrixTest.java:        Mat image = Imgcodecs.imread("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/cameramatrix/test_image.jpg");
Same as the previous comment.
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/CameraMatrixTest.java:        Imgcodecs.imwrite("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/cameramatrix/debug.jpg", undistorted);
This is debug output (it is generated when the test runs).
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java://        Files.newDirectoryStream(Paths.get("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift")
This uses files from test resources which are present in source control, should be present in the target/test-classes dir after compilation of test sources (path will be different of course)
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java:        Mat original = Imgcodecs.imread("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift/screen_shot.png");
Same as above
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java:        Imgcodecs.imwrite("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift/debug.jpg", image);
This is debug output (it is generated when the test runs).
./cooter/src/test/java/nl/vaneijndhoven/dukes/cooter/PerspectiveShiftTest.java:        Imgcodecs.imwrite("/Users/jpoint/Repositories/dukes/cooter/target/test-classes/perspectiveshift/debug2.jpg", shifted);
This is debug output (it is generated when the test runs).

Some file can now be found on the BITPlan wiki:

http://wiki.bitplan.com/videos/full_run.mp4
http://wiki.bitplan.com/videos/startlamp2.m4v
http://wiki.bitplan.com/videos/stopzone2.m4v


Dummy code (Not to be merged)

This is in regards to my comment on #169.

Codecov Report

Merging #193 into dev will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##              dev     #193      +/-   ##
==========================================
+ Coverage   82.99%   83.03%   +0.04%
==========================================
  Files          31       31
  Lines        1970     1975       +5
==========================================
+ Hits         1635     1640       +5
  Misses        335      335

Impacted Files
Coverage Δ

src/resampling.jl
87.61% <100%> (+0.29%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2d4d3f...ad093d9. Read the comment docs.

Am closing this now.


Use Galera in default KUTTL assertion

Galera is now the default for install_yamls and thus for the KUTTL tests it executes.  This fixes the default sample assertion for KUTTL to look for a Galera CR and its associated StatefulSet instead of a MariaDB CR and its associated Pod.
I tested this locally with MARIADB_KUTTL_DIR=/home/abays/rh/mariadb-operator/tests/kuttl/tests make keystone_kuttl (which uses the MariaDB KUTTL targets).  Without my changes there was the expected failure, but with them the test succeeded.

Thanks Andrew for spotting this.
We should also update how the file is linked to the tests directory. Now the file is used in mariadb_deploy but we should use it in galera_deploy.
$ ls -lah tests/kuttl/tests/*_deploy/
tests/kuttl/tests/galera_deploy/:
total 28K
drwxr-xr-x. 1 tkajinam tkajinam  274 May 30 12:44 .
drwxr-xr-x. 1 tkajinam tkajinam   54 May 30 12:44 ..
lrwxrwxrwx. 1 tkajinam tkajinam   31 May 30 12:44 00-create-secret.yaml -> ../../common/create_secret.yaml
-rw-r--r--. 1 tkajinam tkajinam 1.9K Jun 26 20:20 01-assert.yaml
-rw-r--r--. 1 tkajinam tkajinam  196 May 30 12:44 01-deploy_galera.yaml
-rw-r--r--. 1 tkajinam tkajinam  445 Jun 26 20:19 02-assert.yaml
-rw-r--r--. 1 tkajinam tkajinam  191 May 30 12:44 02-scale_down_galera.yaml
-rw-r--r--. 1 tkajinam tkajinam  288 May 30 12:44 03-cleanup_galera.yaml
-rw-r--r--. 1 tkajinam tkajinam  755 May 30 12:44 03-errors.yaml
drwxr-xr-x. 1 tkajinam tkajinam   36 May 30 12:44 deploy

tests/kuttl/tests/mariadb_deploy/:
total 20K
drwxr-xr-x. 1 tkajinam tkajinam 200 May 30 12:44 .
drwxr-xr-x. 1 tkajinam tkajinam  54 May 30 12:44 ..
lrwxrwxrwx. 1 tkajinam tkajinam  31 May 30 12:44 00-create-secret.yaml -> ../../common/create_secret.yaml
lrwxrwxrwx. 1 tkajinam tkajinam  42 Jan 19 17:19 01-assert.yaml -> ../../common/assert_sample_deployment.yaml
-rw-r--r--. 1 tkajinam tkajinam 197 May 30 12:44 01-deploy-mariadb.yaml
-rw-r--r--. 1 tkajinam tkajinam 171 May 30 12:44 02-cleanup-mariadb.yaml
-rw-r--r--. 1 tkajinam tkajinam 292 May 30 12:44 02-errors.yaml
drwxr-xr-x. 1 tkajinam tkajinam  36 May 30 12:44 deploy

@kajinamit is right, we have two test cases for mariadb, one with galera and the other with mariadb, we should switch the new assert_common_deployment.yaml to point to the galera one, and keep the old contents to the mariadb_deploy test case

Thanks guys.  I will make the suggested changes.

Thanks guys. I will make the suggested changes.

Galera's 01-assert.yaml now links to common/assert-sample-deployment.yaml.  MariaDB's 01-assert.yaml now contains the old content of common/assert-sample-deployment.yaml and is thus no longer a symlink.


Output shape of conv2D transpose with "VALID incorrect

inputs = tf.placeholder(name='foo', shape=[None, 4, 4, 256],dtype=tf.float32)
snt.Conv2DTranspose(output_channels=256, kernel_shape=4, stride=[1, 2], padding="VALID")(inputs)

--> yields shape (?,7,11,256)
tf.layers.conv2d_transpose(inputs, filters=256, kernel_size=4, strides=[1, 2], padding='valid')`

--> yields shape (?,7,10,256)
Why?

It is because the shape of the output can be anywhere within a range instead of being an exact value. Within the tensorflow layers they have chosen to use the minimum default shape wheras in Sonnet we have chosen the maximal.
Within Sonnet you can change the output shape (to any valid shape falling within the range) by using the  output_shape kwargs. To get the equivalent in your case use
snt.Conv2DTranspose(output_channels=256, kernel_shape=4, stride=[1, 2], padding="VALID", output_shape=[7, 10])(inputs)


Problems with ccd files generated from audio CDs

When I use the Plextor PX-760A to dump an audio CD, the cue file is correct, but the ccd file is incorrect. Only the last entry is incorrect. When dumped with HLDS WH16NS58DUP (firmware is Asus BW-16D1HT 3.02), both cue and ccd files get the correct result. This can be verified by mounting the cue or ccd file to a virtual drive and using CUERipper to see if it matches CUETools DB or AccurateRip.
dic760d8.ccd.txt
dichlds.ccd.txt

My report is that if you process the exact same audio CD on different drives, an incomplete ccd file may be generated.
Among the files generated by DIC, I decided to upload the files that showed obvious differences.
dic760d8_disc.txt
dic760d8_mainInfo.txt
dichlds_disc.txt
dichlds_mainInfo.txt

Among the CloneCD files, img and sub files are exactly the same at the binary level. Only the ccd file is a little different, which is the cause of the problem.

Only the ccd file is a little different, which is the cause of the problem.

Related issue #294, #42
Try to dump it by CloneCD and compare CloneCD's ccd and DIC's ccd.

I also tried dumping it with CloneCD. The same thing is happening with CloneCD. The ccd file is incorrect. In addition, the cue file is also incorrect in CloneCD. In DIC, the cue file is correct.
ccd760.ccd.txt
ccd760.cue.txt
I also tried it with Alcohol 120%. The situation was similar.
a120760.ccd.txt
By the way, there is a software similar to CloneCD called CD Manipulator. This software can successfully generate ccd and cue files on the PX-760.
cdm760.ccd.txt
cdm760.cue.txt
http://www.storeroom.info/cdm/

By the way, there is a software similar to CloneCD called CD Manipulator. This software can successfully generate ccd and cue files on the PX-760.

It's weird. DIC uses SCSI Pass Through Interface (SPTI, in Windows), while CDM uses Advanced SCSI Programming Interface (ASPI). By the way, CCD uses ElbyCDIO (It's proprietary) and A120% uses SCSI Pass-Through Direct (It's proprietary).
The following tests should be performed to isolate the problem.

If Full Toc is correct in Linux or macOS using PX-760 and DIC, this is Windows SPTI problem. If not so, this may be a PX-760 issue when SPTI is used.
If Full Toc is correct using DIC and other PX-760, this may be your PX-760 problem. But CDM can get a correct Full Toc, so it may be unlikely.

Isn't CDM 2.70 Final compatible with SPTI? Since I'm using  Windows 11, I don't think the ASPI driver is installed.

I have a dual installation of Windows and Ubuntu, so I switched to Ubuntu, made DIC, and tried running. UGREEN's adapter is also working on real Ubuntu. The result is the same as in Windows. The values in the last three lines of entry 13 are equally incorrect.
For DIC & PX-760
[Entry 13]
Session=1
Point=0x0b
ADR=0x01
Control=0x00
TrackNo=0
AMin=0
ASec=0
AFrame=0
ALBA=-150
Zero=0
PMin=58
PSec=0
PFrame=0
PLBA=260850
For CDM & PX-760, DIC & other drives
[Entry 13]
Session=1
Point=0x0b
ADR=0x01
Control=0x00
TrackNo=0
AMin=0
ASec=0
AFrame=0
ALBA=-150
Zero=0
PMin=58
PSec=8
PFrame=20
PLBA=261470

Isn't CDM 2.70 Final compatible with SPTI? Since I'm using Windows 11, I don't think the ASPI driver is installed.

Ah, sorry. CDM supports SPTI.

I recalled that this problem was reported in 2017. http://forum.redump.org/post/55534/#p55534
I don't know the cause, but I changed the fulltoc buffer size anyway.
DiscImageCreator_test.zip

On my PX-760, it was the same when I ripped a music CD with DAEMON Tools. I don't know if it's a problem with the model or just the individual I have, but it's difficult to use this regularly for ripping music CDs. It's an excellent drive, though.

Regarding CDM, in the case of the PX-760, the correct ccd file cannot be obtained unless the "Analyze Sub Code(Get Accurately TOC)" is checked in the option settings. There may be a hint here.

I confirmed it by the source code that fulltoc is overwritten by the sub Q channel when "Analyze Sub Code" is enabled.

To resolve this problem, fulltoc must be overwritten. CDM uses sub Q, but I’ll implement the code that fulltoc is overwritten by TOC.

DiscImageCreator_test.zip
added /toc option
/toc    Full TOC is overwritten by TOC

My problem has just been solved!! I made a fuss. It looks like there was a problem with UGREEN's adapter that converts IDE to USB. The product was compatible with optical drives, but it seems that the IDE was not perfect. Instead, I connected it with TIMELY's Groovy UD-500SA, and both DIC and other software worked perfectly!! The UD series of this company has sold a total of more than 1.2 million units, and has a proven track record. UGREEN's product is USB 3.0 and this one is USB 2.0, but it should be enough for an optical drive.
Now that the issue has been resolved, I would like to close this thread. Thank you very much.

It looks like there was a problem with UGREEN's adapter that converts IDE to USB. The product was compatible with optical drives, but it seems that the IDE was not perfect. Instead, I connected it with TIMELY's Groovy UD-500SA, and both DIC and other software worked perfectly!!

Thanks good info. I am glad to have solved a long-standing problem.


performance in horizontal scrolling

Hello! I use this great component with a lot items. Sometimes more than 1000.
http://prntscr.com/g6nmvj
To get a normal performance i added lazy load component for vertical scrolling:
title:
                          <LazyLoad height={862} offsetVertical={100}>
                              <UserItem user={user}
                                        drivers={props.drivers}
                                        updateData={updateData}
                                        handleOpen={handleOpen}
                                        handleClose={handleClose}
                                        getUserData={getUserData}
                              />
                          </LazyLoad>

Partially it resolve my problem. But horizontal scrolling still not smoothly.I didn't understand how to wrap lazyload to items?

Is it possible for you to post working code via sandbox or other means? It would greatly help us troubleshoot this problem.
You can use this as a starting point:
https://codesandbox.io/s/x3ql17x204

Is there any update here? In terms of performance and virtualization?


"No README" showing up in Atom

Prerequisites

[X] Put an X between the brackets on this line if you have done all of the following:

Reproduced the problem in Safe Mode: http://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
Followed all applicable steps in the debugging guide: http://flight-manual.atom.io/hacking-atom/sections/debugging/
Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

Steps to Reproduce

Go into the packages settings
Search and select the about package

Expected behavior: The Readme shows a description of the package’s use. Most likely the text would be the same text as this repository’s README.md.
Actual behavior: It says "No README"
Reproduces how often: every time
Versions
Atom 1.28.0 on Linux_x64
Atom 1.29.0 on MacOS

This issue was moved to atom/settings-view#1069


upgrade superset to 0.35.2

what

upgrade superset to 0.35.2

@maximmi @goruha I think this PR broke the init_file feature as you changed the command/args from calling the (customizable) init script to hardcoded gunicorn command
(also, this fork of the stable repo misses this useful commit https://github.com/helm/charts/commit/4b82dae876d95e87b05b52d157cd6866169f992a#diff-495faa156d3cbd19c35e19428202227b9b49ba8ed3e96c7794a392ca0f10474c  that allows passing any extra args that can then be utilized in the custom init script)


Ensure that we build only with java 1.7

Every time I release collins, I build it with the wrong version of java.
I'm updating the package.sh script to require that you build with 1.7, just so I don't keep making this mistake on releases.
@tumblr/collins

bump @tumblr/collins

LGTM, but i apparently cant give a 👍 ?


Fix expected data type when decoding RLP in PeersConnection

Fill free to look at the discussion that led to this issue. When decoding RLP data, we should be expecting a particular type of data, so the type should be matched as well, instead of using _vsn.

We do handle types, I don't think we should care about versions really, just have the latest version for the different messages

When you use TYPE.rlp_decode or Serialization.rlp_decode_only so the type is checked.

I think what currently is missing is some more checks if the data decoded from RLP matches what we are expecting. For sure in some places we will accept a list, where binary is expected.

We do handle types, I don't think we should care about versions really, just have the latest version for the different messages.

I partially agree that we don't really need care about versions now, because whenever we make a change we remove support for old version. But I did small preparations in my code to handle different versions when that will be necessary. (You can add deserialization for different version numbers in all structures handled by Aecore.Utils.Serializable) That will come useful after minenet launch, but is not important now.

I guess there was a misunderstanding on my part here. I was talking for the versions, but maybe as you say it's not that vital to pattern-match them ATM. @cytadela8 Maybe you could decide to either have this as low_priority or closing the issue.

I'm confused. This issue is about adding checks that version is correct when we decode? We already do that for all Aecore.Utils.Serializable structures. Where is it missing?

I was referring to places in PeerConnection like this one. Maybe it's not needed to match it.

@gspasov @cytadela8 so we need to check rlp versions when decoding for PeerConnection?

World won't explode (nothing horrible will happen) if we don't, but it's just a simple check that should be done. If the version mismatches then we are trying to talk with a node that's incompatible with us. (that's what the version is for)

okay thanks, was unsure if this is still todo


[DVC-5168] feat: add location call to proxy server

call methods and format return values

assumptions:

the call will only be made on client and user at the moment,
callbacks not yet supported
the POST /location call is being on a function that exists on the type
entityType just shows object, will be accurate after all object types are well defined

Tested on the following test data:
    const testClientData = [
    {
      "clientId": 1,
      "sdkKey": "<SDKKEY>",
      "options": {},
    },
    {
      clientId: 2,
      sdkKey: "<SDKKEY>",
      options: {},
    }
  ]

  const testUserData = [
    {
      "user_id": "1",
      "name": "user1",
      isAnonymous: false,
    },
    {
      "user_id": "2",
      "name": "user2",
      isAnonymous: false,
    }
  ]
  testClientData.forEach(async (clientData) => {
    const client = await initialize(clientData.sdkKey, clientData.options).onClientInitialized()
    data.clients[clientData.clientId] = client
  })
  testUserData.forEach(async (userData) => {
    const user = <DVCUser>userData
    const userId = Object.keys(data.users).length
    data.users[userId] = user
  })

using the following call:
POST localhost:3000/client/2
body : {
  command: variable
  params:[{"location": "user/1"},{"value": "variable-key"},{"value":"defaultValue"},{"callbackURL": "call back url string here"}]
}

added the saving of commandResult in the data global object.
New Test method:
make these calls in this order

POST /client

clientId:1
sdkKey:<SDKKEY>

check for Location header to be client/1

POST /user

user_id:123
name:testUser

check for Location header to be user/0

POST /client/1  :location call

command:variable
params:[{"location": "user/0"},{"value": "variable key"},{ "value" : "default user"},{"callbackURL": "call back url string here"}]
isAsync:true

check for Location header to be command/variable/0

the data object at the end of these calls is

{
  clients: {
    '1': DVCClient {
      initialized: true,
      environmentKey: '<SDKKEY>',
      logger: [Object],
      onInitialized: [Promise],
      configHelper: [EnvironmentConfigManager],
      eventQueue: [EventQueue]
    }
  },
  users: { '0': { user_id: '123', name: 'testUser' } },
  commandResults: { variable: { '0': [DVCVariable] } }
}


[4.0.0-beta.12] index theme color does not match --ion-color-primary

Bug Report
Ionic Info

Ionic:

   ionic (Ionic CLI)          : 4.2.0 (C:\Users\Dylan van der Merwe\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.12
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.8
   @ionic/schematics-angular  : 1.0.6

Cordova:

   cordova (Cordova CLI) : not installed
   Cordova Platforms     : android 7.0.0
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 2.1.4, (and 12 other plugins)

System:

   NodeJS : v8.11.3 (C:\Program Files\nodejs\node.exe)
   npm    : 6.4.1
   OS     : Windows 10

Describe the Bug
When you create a blank project, the following files are added:

manifest.json
variables.scss
index.html

In index.html there is a theme-color tag that does not match the new --ion-color-primary variable.
  <meta name="theme-color" content="#1976d2">

Thank you for the issue! Could you tell me what steps you're taking to get this?
I tried reproducing but I am seeing the following when creating a blank starter using v3:
<meta name="theme-color" content="#4e8ef7">

and I am not seeing this entry at all in v4, which matches the index file here: https://github.com/ionic-team/starters/blob/master/angular/base/src/index.html

Hmmm, this must come from the ng add @angular/pwa command then.

Hmmm, this must come from the ng add @angular/pwa command then.

Yes, this files were generated by @angular/pwa because they are needed for a PWA and in the meta tag you have to use a valid css color -> https://developers.google.com/web/updates/2014/11/Support-for-theme-color-in-Chrome-39-for-Android


[Refactor] Accessing private variables from model

In qadence-protocol to do twirl readout error mitigation I need to access the following,

model._circuit
model._measurement
model._noise
model._backed_name

Can we rename them without _ ?

@dominikandreasseitz @jpmoutinho Nothing prevents us from doing this ?

We cant since the equivalents without an underscore correspond to merhods in Backend

We cant since the equivalents without an underscore correspond to merhods in Backend

Hm, that's true for the circuit only ?

Ok 'observable' was not in that list i see. I mean sure..but the semantics would be inconsistent if we suddenly name something with and without..atm with underscore refers to objects and without means methdods

@rajaiitp It appears this could be too inconvenient for us. Closing but keeping in mind for our refactor of the block system.


Question about the algorithm speed

Hi, Thank you for your excellent work.
I have test your work on kitti-dataset and my custom dataset. I achieved similar results as you. But I have some doubts about the calculation of the speed.
I just  run python test.py --cfg_file cfgs/kitti_models/IA-SSD.yaml --batch_size 16 --ckpt IA-SSD.pth --set MODEL.POST_PROCESSING.RECALL_MODE 'speed'    to get the following result:
......
2022-03-28 16:49:37,358   INFO  *************** Performance of EPOCH no_number *****************
2022-03-28 16:49:37,359   INFO  Generate label finished(sec_per_example: 0.0138 second).
2022-03-28 16:49:37,359   INFO  recall_roi_0.3: 0.000000
2022-03-28 16:49:37,359   INFO  recall_rcnn_0.3: 0.000000
2022-03-28 16:49:37,359   INFO  recall_roi_0.5: 0.000000
2022-03-28 16:49:37,359   INFO  recall_rcnn_0.5: 0.000000
2022-03-28 16:49:37,359   INFO  recall_roi_0.7: 0.000000
2022-03-28 16:49:37,359   INFO  recall_rcnn_0.7: 0.000000
2022-03-28 16:49:37,362   INFO  Average predicted number of objects(3769 samples): 7.685
2022-03-28 16:50:04,217   INFO  Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP:96.2632, 90.1455, 89.4070
bev  AP:90.3738, 88.7840, 87.0682
3d   AP:89.3510, 79.5290, 78.5040
aos  AP:96.22, 90.04, 89.22
Car<EMAIL_ADDRESS>0.70, 0.70:
bbox AP:97.8414, 95.2234, 92.6498
bev  AP:94.8053, 91.3833, 88.8623
3d   AP:91.8502, 83.3872, 80.4255
aos  AP:97.80, 95.08, 92.43

But when I change the batchsize to 1,  I got the the result; sec_per_example: 0.0529 second. My machine is NVIDIA V100S .  I also use demo.py to test the speed. the average time for network inference is about 48ms.
I want to know how can I achieve 85FPS use the work.  Generally, when the algorithm is used in actual scenarios, such as automatic driving, the batch size is always 1.  It would be great if it could also reach 85FPS with the batchsize = 1.

Thanks for your interest in our work! To clarify, as mentioned in the caption of Figure 1, we follow the common practice [1][2] to calculate the FPS with the full utilization of GPU memory. As such, the 80+ FPS is achieved with a batch size of 16 in the RTX 2080Ti GPU. This result may vary slightly due to the differences in CPU, IO, or other hardware configurations.
As for the case of batch size =1, we suppose this is usually called ``latency'' in literature. In our paper, we also report the results in Table 6 when the batch size is set to 1. Specifically, 23/48 fps can be achieved depending on whether dividing the scene into four parallel parts to speed up the first sampling layer. Regarding the detailed implementation, what you need to do is to set the corresponding sampling method in the MODEL.BACKBONE_3D.SA_CONFIG.SAMPLE_METHOD_LIST to "ry_FPS" or "ds-FPS" in the *.yaml config file.
Hope this clarification would be helpful for you.
[1] Z. Yang, Y. Sun, S. Liu, and J. Jia, “3dssd: Point-based 3d single stage object detector,” in CVPR, 2020, pp. 11040–11048.
[2] C. Chen, Z. Chen, J. Zhang, and D. Tao, “SASA: Semantics-Augmented Set Abstraction for Point-based 3D Object Detection,” in AAAI, 2022.

Hi, yifanzhang713, thank you for your excellent work. I have read the awesome paper, and I have a confusion about Table 6.
The speed 83FPS and the Mem. 102MB are both calculated when fully utilizing the GPU memory. But why 83FPS is achieved with 16 batch size, and 102MB is achieved with 100 frames?


Read GitHub token from git-credentials file

According to this comment in pwr project I'd like to finish and move code here.
Before that I'd like to ask if I can count on a relatively fast merge, because this project has not been changed for a long time.

Hey, if you could re-make this issue on my fork that would be nice. This project's dead, and having these issues on my fork will make things easier on me :)

Hey, if you could re-make this issue on my fork that would be nice. This project's dead, and having these issues on my fork will make things easier on me :)

@OpticFusion1 OK - I'll move it - I posted it quit long time ago here and need to recall my needs  :)

@OpticFusion1 OK - I'll move it - I posted it quit long time ago here and need to recall my needs  :)