Bug: ImageHandler has no reality checks

Describe the bug
ImageHandler does not do any verification that it has a valid image loaded, which can lead to some errors with unhelpful descriptions. E.g. fit() will try to calculate the aspect ration with a null value, so $xRatio = $width / $origWidth; results in "Division by zero".
I don't know where validation should happen - withFile() is maybe the best bet but doesn't catch instances where developers forget to use it before calling other methods.
CodeIgniter 4 version
develop
Affected module(s)
Image Manipulation Class

withFile makes sense to me.
Anytime the developer forgot to do a step it should crash loudly so they can catch it...

So errors like "division by zero" are okay if they skip withFile() and call fit() directly?

Actually to take it one step deeper... Image is actually just an extension of File with the additional methods copy() and getProperties() (and some properties) but no constructor... Should Image have its own constructor to verify the file is an image?

Deeper still... getProperties() relies on PHP's getimagesize that has the following note in the manual:

Caution This function expects filename to be a valid image file. If a non-image file is supplied, it may be incorrectly detected as an image and the function will return successfully, but the array may contain nonsensical values.
Do not use getimagesize() to check that a given file is a valid image. Use a purpose-built solution such as the Fileinfo extension instead.

I'm thinking we either need a lot more involvement or just some way of failing more explicitly.

In general yes. Every example in the docs show that you have to use withFile(). That library is not intended for general image creation, only manipulating existing images. At that point, it's a developer error and an exception should be thrown so they can locate the error during their testing.
I suppose we could give a more helpful exception message (that an image is required), but that would require a check on pretty much every function.
The File constructor already has the option to check if a file exists, but that's an optional check. In the BaseHandller, though we do check the file exists. That requires the user has actually used withFile, though...

Hmm this is tricky.
On the one hand, it seems like a valid $path and valid image at that path are requirements for the handlers, and presupposed for every method - that makes me think it should be part of the constructor (but keep withFile() to make handling multiple files easy).
On the other hand having the handlers be handler classes makes them easy to use with the service, but creates this situation where it is easy to mess up.

Floating an idea... Since all the methods use $this->image and require it to be a valid file & image, we replace that with $this->image() (or getImage() or whatever) that makes a one-time check (reset by withFile()) to do validate path and image and then return the Image instance, and it can handle throwing appropriate messages.


better logging for IP Check policy

It will be great to have in policy log what rule was used to block/allow which IP.

Unfortunately, this information is not exposed by the library we use: https://github.com/hamishforbes/lua-resty-iputils
You give it a list of CIDR blocks and it gives you true/false if that IP is in the range or not.


Updating Skyblock Joining & Leaving Logic, Fixed Location updates, Added Logging.

This updated code is for a new bit of logic where Detection is based on what the active scoreboard name is, rather than the old system of updating based on reading a line from the scoreboard (which broke during SKIBLOCK).
How it works:
Joining to a Hypixel lobby gives us for example Prototype as a new name. Telling us that the client no longer is within Skyblock.
Joining into Skyblock, we receive two Scoreboards, one named health and the other SBScoreboard, this also goes along with transferring islands, we also receive this set of packets.
We ignore health as this can lead to false positives for other gamemodes (As it is a common name for scoreboard names)
Next, we check for if it contains SBScoreboard and if it does, then we interact with the event, and we are officially "on Skyblock"
lastly, we check for any other Scoreboard, if we do not find SBScoreboard but another one, we interact with the Leave Skyblock event, and are "off Skyblock"
Currently known edge cases
One edge case of this code is that if we go straight to limbo (skipping any hub/lobby) The "leave" code is never activated, and we continue to think we are still on Skyblock, even if we leave and go to another server without a scoreboard or to a singleplayer world without a scoreboard.
So, this would affect a very minor subset of servers/singleplayer worlds, however, can be fixed with a simple IP check for *.hypixel.net (Not implemented) which would then only affect people who get booted straight to limbo. Please let me know if anyone has any solutions to this.
Location Changes
Updated the location change code to the function of onScoreboardDisplay, as it needs to update on every single Scoreboard update currently.
Logging Changes
Added logging for new Location change code, along with the join/leave Skyblock code.
In the future, this should be behind a toggle for developers for simply debugging if anything goes wrong with this code.

Looks fine for the join and leave detection, given it works ofcourse. But for the logging, wouldn't devs just register a listener themselves to get a debug message like that? And furthermore, putting the actual message between "{}" doesn't make a whole lot of sense as those are generally used to log objects. Also when using the LOGGER object, the message is already prefixed with "(skyblockcore)" (the modid), so adding the name of the mod again also does not make that much sense.

Looks fine for the join and leave detection, given it works ofcourse.

Haha, forgot to mention, I did some basic testing with Dungeons, Skyblock hub, Personal island, Main Lobby, and Prototype lobby and it worked flawlessly for the logic on the ones I tested here. However I need a bit more testing to make sure Kuudra, Rift, Straight to limbo, and all other Skyblock islands work, but I did not have time for those today.

But for the logging, wouldn't devs just register a listener themselves to get a debug message like that?

Yes, but also, if its just built in, that allows people reporting issues/developers trying to find out why their mods not working with the core mod to do it without recompiling and re-logging into Hypixel.

And furthermore, putting the actual message between "{}" doesn't make a whole lot of sense as those are generally used to log objects.

Only did this for visibility sake temporarily while writing this. In the future, I'd like to have something more professional yes.

Also when using the LOGGER object, the message is already prefixed with "(skyblockcore)" (the modid), so adding the name of the mod again also does not make that much sense.

It in fact did not prefix my logs with that. Examples below:
[23:44:17] [Render thread/INFO]: [SkyblockCore] {SKYBLOCK SB "Joined SB"} SBScoreboard
[23:44:17] [Render thread/INFO]: [SkyblockCore] {Health Scoreboard "Ignored"} health
[23:44:17] [Render thread/INFO]: [SkyblockCore] {Location Changed from: null to: Your Island}
[23:45:26] [Render thread/INFO]: [SkyblockCore] {Other Scoreboard, "Quit SB"} Prototype
As to why it did not. I have no clue. Wasn't due to anything special that I am aware of either in the development environment/client testing I did there. (And yes, I was hoping it would actually prefix it, but since it didn't, I made this change to be able to spot it within my logs for the time being.)

didnt mean to even push here but
chAnGeS
Changes

Not working command handling for /sbcore dev handler thing yeah
Formatting for the logs (it looks nice I was planning to make dev toggle then push but HERE WE ARE!)

Added better formatting for logs
Changes

Changed all of the formatting of joining/leaving skyblock and zone changes to be a bit more simplified
Added a dev mode (currently there is no way to toggle this, to turn this off go to src\main\...\SkyblockCore.java\ it is currently set to TRUE
@wiviw5 and I talked about adding some sort of ingame command and config, I have been working on this and the pr should come soon enough

I have verifed that I am commiting to pr/12
I have checked and tested my code and it has launched and dev mode has worked both on TRUE and FALSE

I fixed the last bit of formatting here, its of course still temporary. But now looks better for transitions between locations.

I fixed the last bit of formatting here, its of course still temporary. But now looks better for transitions between locations.

Thanks! I actually fixed it but when i was re-pr'ing it somehow got deleted

If you want you can start working on the command (or anyone else) since I can probably finish the config

that's crazy

👍 my phone vibrated for you, good job!

got an email for that, good job!

Added a config file, and formatting
Additions

Config creator and handler in JSON
Added a dev toggle and location toggle

Changes

Merged formatting used in the last commit in this pr from @wiviw
Changed a few logging things to include MODID

I have tested my code and it has launched with all toggles tested
I have changed where I am commiting
I have added information on how to add a config option in ModConfig.java
TODO for this pr

Add a command ingame to toggle
at some point documentation...

Fixed some config file shenanigans & tested out a new command. (made sure that when checking if developer/location feedback mode was enabled was actually respected.)
Additions
Added a local only command to do testing with, and to eventually give users feedback.
Currently looking at:
/skyblockcore <subcommand>
With the subcommands being:

reload (For hot reloading of the file if manually edited.)
nbt (Currently not implemented, for future nbt grabbing from items/entities.)
dev (Not implemented, for future enable & disable of developer feedback logs.)
location (Not implemented, for future enable & disable of developer feedback logs.)

Changes

Changed a few bits of config checking to make sure changes to the config were respected when reloaded.
Made sure config loading & Command registration was done at the proper times in loading.

TODO

Better feedback to the player on the commands. (Optimally, I would like every single thing we send to the players chat window in translatable text.)
Implementation of the commands

Fixes requested by Ascynx included fixing the loggers in separate classes, some spelling, removal of GSON (provided by fabric already), and questions on logger reasoning.

Oh that's odd, I think my IDE complained without it... but yeah you're right it shouldn't be nullable

If you want @Harry282 you can commit a fix

Fixed the (sub-island) location listener.
It used to listen only for objective updates, but the location isn't actually an objective name - instead it's a team name.
Now we only update the location when we actually receive a team update packet from Hypixel with the location character (U+23E3) as the first character (excluding whitespace).
Works very reliably, and updates instantly when the player location changes in scoreboard. Added bonus effect of partial location updates as Hypixel partially updates the location (but these only persist for a few milliseconds until Hypixel sends the full update).

Changes

Made the TITLE string public
Made scoreboard strings public
Removed the private versions of ^
Removed some random lines blankness
Formatted a tiny bit of logging and changed a few things

Additions

Commands now have ingame replies (No color yet, and just basic they still dont do stuff)

TODO

Make commands do stuff
Add color to commands
change around some logging
Fix config being nullable
add a time calc for reloading config
add a way to reload config
fix all of the headaches with LOGGER sometimes showing weird stuff
Fix issues with location

I have checked that my code works in developer launch and normal minecraft

Fixed up player checks.

Changed around format of getting whether the user has joined or left Skyblock.
This removes a single string comparison now that we check for anything but specific strings associated with Skyblock.

Additions

Made a new class for config stuff to remove it from the main class
io.github.skyblockcore.event.ConfigManager
Made all the commands (aside from NBT) do stuff

Changes

Changed all old config uses to use the new method

Known issues

I somehow caused see image

Additions

Log filtering
log filter toggle command
log filter config lines
test command!
cute catboys

Changes

Removed the femboys from an old update as it was ruining the motivation of the team

I have tested this and it has launched and built in dev and in minecraft
TODO

Fix config not allowing new code to be printed without hard reset
colors 🌈 🏳🌈 🏳⚧ 👑 💅 💅 💅 💅 👄 💋 💄

Is this ready for reviews?


router: proxy support for HTTP CONNECT

Support CONNECT request based proxying for Go RPC over HTTP.
/cc @bgentry

We're not going to implement this. Instead, gRPC support will be added to the next version of the router.


Bump minor version number

ms-rest-azure-js changes necessary for https://github.com/Azure/autorest.typescript/issues/94.

suggest also mentioning/auto-updating this version in autorest.typescript README

Lgtm


Mobile view messed up

Browsing a blog article with a long title on the Pixel 3 shows a broken layout.

Fixed in #195.


Add Default layout

WIP, but I noticed the Footer component was used in each view. We can use a layout, which is a component with a default slot. The default slot gets the component being rendered in the view. This way we can define a base set of components common to all views (e.g. NavBar, Footer, etc).
Only having small issues with Tailwindcss now, so WIP for now :+1:

🎇 Valid pull request
Changes made

Move flex sizing to layout
Add Default layout


Expose key and service creation, message unpacking

This will allow a client to process messages sent to an unmediated endpoint service.
Signed-off-by: Miroslav Kovar<EMAIL_ADDRESS>

Codecov Report

Merging #639 (ad3db92) into main (2df64b6) will increase coverage by 5.66%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   58.57%   64.24%   +5.66%
==========================================
  Files         213      215       +2
  Lines       20040    20190     +150
  Branches     4543     4606      +63
==========================================
+ Hits        11739    12971    +1232
- Misses       3770     3786      +16
+ Partials     4531     3433    -1098

Flag
Coverage Δ

unittests-aries-vcx
64.04% <0.00%> (+5.58%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

aries_vcx/src/indy/crypto.rs
0.00% <0.00%> (ø)

...x/src/indy/primitives/revocation_registry_delta.rs
48.88% <0.00%> (ø)

...otocols/proof_presentation/prover/state_machine.rs
65.29% <0.00%> (+0.22%)
:arrow_up:

aries_vcx/src/error.rs
12.46% <0.00%> (+0.31%)
:arrow_up:

messages/src/did_doc/mod.rs
52.84% <0.00%> (+0.31%)
:arrow_up:

messages/src/error.rs
6.08% <0.00%> (+0.43%)
:arrow_up:

messages/src/a2a/mod.rs
58.33% <0.00%> (+0.49%)
:arrow_up:

...vcx/src/protocols/issuance/issuer/state_machine.rs
68.94% <0.00%> (+0.66%)
:arrow_up:

...ls/revocation_notification/sender/state_machine.rs
56.03% <0.00%> (+0.86%)
:arrow_up:

aries_vcx/src/indy/primitives/credential_schema.rs
28.08% <0.00%> (+1.12%)
:arrow_up:

... and 66 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Handle other cases of unintialized RegExp objects

Hopefully fixes GH-377 for good
/cc @benvinegar

:+1:


Add better-exceptions for the development

Proposed Changes
Add better-exceptions for the development.
This can be added to development/nautobot_config.py:
try:
    import better_exceptions
    better_exceptions.hook()
except ImportError:
    pass

Justification
better-exceptions helps with the debugging process. It shows the stack trace in a more readable way, and it also shows the values of the variables in the stack trace.
Project GitHub pages

Not interested in making this a system dependancy. As you note, this can easily be implemented in a developer's environment if they so choose.


Process for debugging main

Describe the issue / bug.
The FAQ only mentions debugging the render process - but my issues appear to be in the main process
Is there guidance on a best practice (or any practice) how to debug main?

I'm dumb:
Main Process
When running your application in development you may have noticed a message from the main process mentioning a remote debugger. Ever since the release of<EMAIL_ADDRESS>remote debugging over the Inspect API was introduced and can be easily accessed by opening the provided link with Google Chrome or through another debugger that can remotely attach to the process using the default port of 5858, such as Visual Studio Code.
┏ Electron -------------------
Debugger listening on port 5858.
Warning: This is an experimental feature and could change at any time.
To start debugging, open the following URL in Chrome:
chrome-devtools://devtools/bundled/inspector.html?experiments=true&v8only=true&ws=<IP_ADDRESS>:5858/22271e96-df65-4bab-9207-da8c71117641
┗ ----------------------------

https://stackoverflow.com/questions/48091899/electron-main-and-renderer-process-debug-configuration/50787937#50787937


Remove Stanford deployment instructions

These have been moved to a private repository. This does not delete them from the Git history, but since they don't contain any secrets, it should be okay.
Addresses #77

Recreating this PR due to conflicts.


3DS Freezes

When I try to access Nintendo DS Connections on Internet settings is this normal or did I mess up something? On AL9H firmware is updated to 11, and also when I was updating my system from 9.2 I kept getting an error and had to retry for like 10 time before it updated is that normal?

I need a detailed account of what you did.

I followed the guide step by step on my 2DS ver. 6.0.0U then on part 3 Section IV - Restoring the System i got a blackscreen and tried all the steps and troubleshooting but nothing worked so I did a 9.2.0 CTRtransfer and got it working, then updated my firmware to 11.0 (it failed alot of times), everything is working fine I mean I have installed CIA's and played them, then I was tinkering with my settings and came upon this freeze while trying to access DS connections

As mentioned in the closed issue, this also affects me.
I started on 7.1.0-16E but had to ctrtransfer to 9.2.0 at the same point as RayMafnas due to black screen.
I then upgraded to 11.0.0-33E without issue via settings and system transferred my NNID from another 3ds
I hadn't checked Nintendo DS settings until a few minutes ago

Just to be sure, did you both used Gateway software in the past?

This could be caused by some leftovers from MSET of some sort (Gateway or otherwise).

In my case, it was an (almost) vanilla console. I had previously used ninjhax 1.1b to boot homebrew launcher without doing much else but look at the cool cube demo.

Hmmm... Ninjhax 1.1b can mess some things up on 9.3+ systems because it used rohax, which was patched in 9.3 so that could be causing it.

My 2DS was straight otta the box.. just make me a lil nervous that it might be a ticking bomb or something, (paranoid)

Did you ever open Nintendo DS connections before the downgrade? It could be that you just never initialized the save data for the application, or that if you opened it on 6.X (which has MSET capability) and then updated with A9LH, so new save data isn't created because there is save data from 6.X that the system is trying to load but can't because Nintendo DS connections was updated? I don't really know. I haven't gone through the process of getting A9LH (old guide or new guide) on a <9.3 system, so I'm not sure.

No I didnt open Nintendo DS connections before the downgrade. I will try to access ds connections with a game

It could be a save data initialization problem. I assume there would be a specific folder to delete to test this?
As for deleting ninjhax 1.1b, I don't understand the logic here. Since I have A9LH, I have no need for ninjhax of any sort.
It is safely there on my sky3ds for using homebrew on old systems.
I just tried to use a DS game - Pokemon Black - to test the connection settings menu there, but I find I black screen on this too, suggesting a TWL_FIRM issue as mentioned.
(note that the DS game test was performed on 9.2.0 A9LH after I restored my 7.1.0 and ctrtransferred again.
I will go full vanilla and retest

Same issues here tested a game Mario Kart DS  managed to get into the game running on 11.0 freeze when I try to set up a connection or go online

Have you tried booting DS connections through FBI?

I tried what I think is DS connections via FBI but got a black screen.
I also tried Zelda Four Swords (DSi mode title) and Legends of Exidia via both home menu and FBI and black screened on both.

I'm no expert on this, but could this thread on GBATemp help you @Plailect ? (http://gbatemp.net/threads/ctrnand-transfer-also-transfers-other-consoles-ticket-db-etc-it-can-remove-your-bad-tickets.439802/#post-6641039)

3 Days and still no advise by Plailect, I just want to start over and follow the old guide even though its longer does anyone here any the complete guide? its no longer available in this page, im really new to this but I have installed AL9H on an O3DS and that one seems to be working fine with no hiccups, could someone walk me through how to uninstall a9lh or start anew?

It is available here: https://github.com/Plailect/Guide_RedNAND/wiki
On Tue, Aug 30, 2016, 8:28 PM RayMafnas<EMAIL_ADDRESS>wrote:

3 Days and still no advise by Plailect, I just want to start over and
follow the old guide even though its longer does anyone here any the
complete guide? its no longer available in this page, im really new to this
but I have installed AL9H on an O3DS and that one seems to be working fine
with no hiccups, could someone walk me through how to uninstall a9lh or
start anew?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/Plailect/Guide/issues/412#issuecomment-243623425, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ADd1uJ8UUWrYE36YD9C_5KBrgPl9KmeLks5qlMqagaJpZM4Ju1RA
.

thank you dark-samus!

@RayMafnas don't be impatient. Plailect is looking for the source of this problem, since you're not the only one. Even if you do the old guide, DS Modde will probably still be messed up. So, stop. Don't do anything until Plailect finds a solution.

Consolidating into https://github.com/Plailect/Guide/issues/438

Its all working now, just installed the CIA on two 2DS and both are playing DSi games and stuff! :D thanks guys


PHP Fatal error

[error] 22078#22078: *1 FastCGI sent in stderr: "PHP message: PHP Fatal error:  Uncaught Slim\Exception\HttpNotFoundException: Not found. in /var/www/html/vendor/slim/slim/Slim/Middleware/RoutingMiddleware.php:91

Could you please provide some context that lead to this exception? Did you install dependencies with php composer?

Did you install dependencies with php composer?

Yes, I did. Using PHP 8.1.

I cannot replicate the issue. Works fine on my Gentoo linux machine with PHP 8.1

[error] 22078#22078: *1 FastCGI sent in stderr: "PHP message: PHP Fatal error: Uncaught Slim\Exception\HttpNotFoundException: Not found. in /var/www/html/vendor/slim/slim/Slim/Middleware/RoutingMiddleware.php:91
Is the problem persisting after #14 ?

Closing because no response and this is an irrelevant issue. Create a new issue if you still have problems.


Update sbt-pgp to 2.2.0

Updates com.github.sbt:sbt-pgp from 2.1.2 to 2.2.0.
GitHub Release Notes - Version Diff
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Files still referring to the old version number
The following files still refer to the old version number (2.1.2).
You might want to review and update them manually.
modules/frontroute/yarn.lock
website/yarn.lock

Adjust future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "com.github.sbt", artifactId = "sbt-pgp" } ]

Or, add this to slow down future updates of this dependency:
dependencyOverrides = [{
  pullRequests = { frequency = "@monthly" },
  dependency = { groupId = "com.github.sbt", artifactId = "sbt-pgp" }
}]

labels: sbt-plugin-update, early-semver-minor, semver-spec-minor, old-version-remains, commit-count:1

Superseded by #140.


chore(ci): add trigger for terraform-google-conversion

The trigger configurations are copied from terraform validator, and only the names are changed.

This has been applied

@apeabody added our regular group so you should have access in the future!


Made a mistake on my tool, counter starts fr0m 0

I was basing it off of https://imgur.com/Nlq0oPB.png where tehre was no chunk 0 (some systems do start at 1, like matlab)
Problem is this cuts off the first 20 items
https://github.com/td512/Humble-Trove-Downloader/blob/54d71d04ef0967b637f19b7dbc3ccebe8fc80995/Humble Trove Downloader/Form1.vb#L10

Fixed. CDN purge could take a couple seconds.


ADS citation search link broken

Hellon,
ADS citation search link is broken
see for example http://depsy.org/package/python/windrose
Based on term searches in ADS (1)
It raises an HTTP error code 500 (Internal Server Error) and displays
WARNING: this service will be deprecated in the coming months.
Please consider using ADS Classic or Bumblebee
Error! Search service error: Error communicating with search service
Well, this is embarrassing.
The application has generated an error.
We logged the error and we will read it soon, but if you want us to know about it immediately, please send us an email.
Please, be patient with this application: it's still in "alpha" stage. We are working hard on making improvements.
Kind regards

Fixed!  Thanks a lot for the bug report :)


https://github.com/mozilla/global-sprint/issues/172 Add project to Mozilla Pulse

https://www.mozillapulse.org/entry/686


Turso Quickstart GO tutorial outdated

The installation of the Quickstart for Go still references the old url:
go get github.com/libsql/go-libsql

Running the command throws the following output:
go: downloading github.com/libsql/go-libsql v0.0.0-20240306141008-c20f26b667e5
go: github.com/libsql/go-libsql@upgrade (v0.0.0-20240306141008-c20f26b667e5) requires<EMAIL_ADDRESS>parsing go.mod:
        module declares its path as: github.com/tursodatabase/go-libsql
                but was required as: github.com/libsql/go-libsql

Simply changing it to:
go get github.com/tursodatabase/go-libsql

would solve the error

@notrab @xinnks FYI

This is now fixed @renatillas
Btw, all pages of our docs are in this repo. You can always submit a PR with any improvements, we'd be happy to review them 🙏🏻

@haaawk I don't have permission to close this issue.


dfx optimize and bump dfx to version 0.14.0

I think it would be good to merge this so that we can measure performance improvements beyond wasm-opt and not reimplement optimizations already included in the optimizer.
For future reference: https://github.com/dfinity/sdk/pull/3090

wasm-opt is scrambling internal function names, which is messing with the wasm_profiling() primitive in ic-repl that specifies which function to profile.

Ah right. The name section is missing after wasm-opt. Maybe we can disable wasm-opt for the GC benchmarks?

Just ran a test. The names are still in the flamegraphs

Hey Yan, I'm just getting back to this now.
The benchmark change in the garbage collector cases seem to be from the bump in dfx version.
See here: https://github.com/dfinity/canister-profiling/pull/53
Not quite sure why yet.
Will look into the name section next.

Update: #54 should resolve the GC cases anomalies

https://github.com/dfinity/ic-wasm/pull/34
Added a change to preserve the name sections for profiling.
This changed is used in #55. Once #55 is merged, I will close this PR.


Download big file to temp one to avoid possible download failure and use corrupted file.

Download big file may failed, such as running sample as following :
 {Mobius}\build\localmode\RunSamples.cmd
This will download several files including one big file (like 266M  spark-1.6.2-bin-hadoop2.6.tgz) which will take a long time especially if network's slow.
And if download failed (or killed/canceled), next time run "RunSamples.cmd" again, it'll use the corrupted tgz file (to decompress and use), and consequently cause problem like following (using corrupted jar) :
Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/spark/launcher/SparkSubmitArgumentsParser
        at java.lang.ClassLoader.defineClass1(Native Method)
        at java.lang.ClassLoader.defineClass(ClassLoader.java:792)

It's a common way to download to a temp position and rename it, as it's easy and cost little.

[Current coverage][cc-pull] is 82.23%

Merging [#490][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.41%

@@             master       #490   diff @@
==========================================
  Files            48         48
  Lines          5101       5101
  Methods         978        978
  Messages          0          0
  Branches        649        649
==========================================
- Hits           4216       4195    -21
- Misses          598        619    +21
  Partials        287        287

Powered by Codecov. Last updated by [db95eb5...859192f][cc-compare]
[cc-base-branch]: https://codecov.io/gh/Microsoft/Mobius/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/Microsoft/Mobius/compare/db95eb5de8520959b2e8c17ba2d142badad05a35...859192fd42f4f31774ecf53355a6fd885ee77948
[cc-pull]: https://codecov.io/gh/Microsoft/Mobius/pull/490?src=pr

LGTM

LGTM. Thanks @qualiu


BGM does not play

No error messages. Running bgm script shows a track playing but I do not hear anything. I have tried 3 different mp3s that I've downloaded from Youtube.

Something was wrong with the files I was using.


Unable to connect to localhost minutes after opening wrapper

For some reason, wrapper offline will be unable to save my video or generate TTS clips after a few minutes of the program being open. TTS will be stuck on "generating" and when saving a video I will get an error saying something like there was a problem. When i go to reopen the video list, I get an error message saying that the localhost refused to connect.

Are you sure you are using the latest stable version of wrapper (1.2.3)? I recommend you re download it if you're not. That should fix it.

i have confirmed I am using version 1.2.3. typically the issue will occur a few minutes after at least 1 TTS message has been generated.

I ran wrapper with verbose mode on and this is what I got:

<EMAIL_ADDRESS>start C:\Users\HP\Downloads\wrapper-offline-1.2.3\wrapper-offline-1.2.3\wrapper
node main.js

(node:8788) UnhandledPromiseRejectionWarning: Error: Could not connect
at Socket.onerror (C:\Users\HP\Downloads\wrapper-offline-1.2.3\wrapper-offline-1.2.3\wrapper\node_modules\discord-rpc\src\transports\ipc.js:32:16)
at Object.onceWrapper (events.js:422:26)
at Socket.emit (events.js:315:20)
at emitErrorNT (internal/streams/destroy.js:92:8)
at emitErrorAndCloseNT (internal/streams/destroy.js:60:3)
at processTicksAndRejections (internal/process/task_queues.js:84:21)
(node:8788) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag --unhandled-rejections=strict (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:8788) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
(node:8788) Warning: Setting the NODE_TLS_REJECT_UNAUTHORIZED environment variable to '0' makes TLS connections and HTTPS requests insecure by disabling certificate verification.
C:\Users\HP\Downloads\wrapper-offline-1.2.3\wrapper-offline-1.2.3\wrapper\node_modules\brotli\build\encode.js:3
1<process.argv.length?process.argv[1].replace(/\/g,"/"):"unknown-program");b.arguments=process.argv.slice(2);"undefined"!==typeof module&&(module.exports=b);process.on("uncaughtException",function(a){if(!(a instanceof y))throw a;});b.inspect=function(){return"[Emscripten Module object]"}}else if(x)b.print||(b.print=print),"undefined"!=typeof printErr&&(b.printErr=printErr),b.read="undefined"!=typeof read?read:function(){throw"no read() available (jsc?)";},b.readBinary=function(a){if("function"===
^
SyntaxError: Unexpected end of JSON input
at JSON.parse ()
at IncomingMessage. (C:\Users\HP\Downloads\wrapper-offline-1.2.3\wrapper-offline-1.2.3\wrapper\tts\load.js:237:45)
at IncomingMessage.emit (events.js:327:22)
at endReadableNT (_stream_readable.js:1221:12)
at processTicksAndRejections (internal/process/task_queues.js:84:21)
npm ERR! code ELIFECYCLE
npm ERR! errno 7
npm ERR<EMAIL_ADDRESS>start: node main.js
npm ERR! Exit status 7
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>start script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.
npm ERR!      C:\Users\HP\AppData\Roaming\npm-cache_logs\2021-07-01T00_07_18_275Z-debug.log

2021-07-01T00_07_18_275Z-debug.log

with a little more troubleshooting and isolation, I've narrowed down the issue to being just certain voices. I've not gone through all of them, but the voices include the "will" variations


Support for updating Entry

Hi there.
Does this SDK support updating an entry yet? If not, is there plan and estimate of supporting it?
Thanks,

Thanks for writing us @gurban-h,
This SDK is for the content delivery APIs, So it does not provide support for entry updates. Hence we are closing the issue

Note: We have a plan to release SDK that supports content management APIs.

Thanks @ishaileshmishra . Do you have timeline for releasing "SDK that supports content management API"?


Database migration fails: there can be only one auto column and it must be defined as a key

I have used Core Updater for adjusting like 200 lines. It seems to work like a charm, but two rows lead to an error:
1. Different primary key in table ps_page_cache
Incorrect table definition; there can be only one auto column and it must be defined as a key
2. Column ps_page_type.name should use character set utf8mb4/utf8mb4_unicode_ci instead of utf8/utf8_general_ci
Index column size too large. The maximum column size is 767 bytes
I don't know this objects well and I am using my live store. But I doubt, that I have changed this tables my own.

The first issue is valid, core updater should be able to perform multistep table migration to prevent this kind of errors.
Second issue is not valid, though. This is server misconfiguration. If you tried to install thirty bees from scratch on this mysql server, you would get the same error message.

You are right. Only the first issue is real...

Closing as duplicate of #12


docs: adjusting typo in csrf

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]

Thanks can you merge main and fix DCO?
/wait

sure I can, will do asap

@EvertonSA the guide for fixing DCO is here https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#dco-sign-your-work

@EvertonSA the guide for fixing DCO is here https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#dco-sign-your-work


Custom signed CA certificates on GitHub Enterprise Server instance

Hi
We're running GitHub Enterprise Server 3.7, and trying to enable dependabot updates as github actions on self-hosted runners.
Currently these are failing because we have a custom CA that our github instance TLS is signed behind, and github updater is unable to communicate with.
I cannot see any method for configuring the custom CAs to be deployed with the dependabot github action, to allow communication. If I have missed it, could you please point me at it? I can see webproxy environment settings are passed through to the docker image.
Example log:
INFO <job_18> Connectivity check starting
  proxy | 2022/11/17 16:45:31 [002] GET [https://<ourinstance>:443/api/v3/repos/<org>/<repo>](https://<ourinstance>/api/v3/repos/<org>/<repo>)
2022/11/17 16:45:31 [002] * authenticating git server request (host: <ourinstance>)
  proxy | 2022/11/17 16:45:31 [002] WARN: Cannot read TLS response from mitm'd server x509: certificate signed by unknown authority
updater | ERROR <job_18> Connectivity check failed: end of file reached

Thanks,

So it turns out you just need configuration in the github runner, not to pass through to dependabot:
in .env
NODE_EXTRA_CA_CERTS=
CUSTOM_CA_PATH=

Thanks for circling back on this!


Build & Deploy Window Fixes

Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/688 Building only for D3D. Now uses build settings.
Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/685 Added Support for MSBuild 15+ while keeping backwards compatibility.
Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/615
Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/612
Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/601 Fixed Build Failure due to App Name with Space.
Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/583 Added UWP SDK pop up so users can choose sdk version in build window.
Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/255 Fixed issue with bad builds returning error code 0.
Fixes https://github.com/Microsoft/HoloToolkit-Unity/issues/189 Added ability to select a certificate and input password (Users can only create new certs from the Player Settings Window).
Added workaround to unity bug where project.json and project.lock.json are not copied correctly to the target build path. (See UwpBuildTest)
Added Scrollbar for APPX package list.
Added checks for SLN existing before attempting to make APPX.
Disabled buttons if HoloLens is not detected via usb.
Merged changes from RS2_MixedReality branch that specifically addressed changes to Build Window.
Changed Build Configuration from a string field to an enum popup.
Added a button to open the appx packages location.

Okay It's ready

It looks like you've merged some changes from the RS2 branch without bringing them in via the original (mostly massive) commits. How will we know when all the changes are in, if we do it this way?

There won't be conflicts or changes.

If anyone has suggestions on how to make the Build process run on a new thread, I'm all ears.

I ran into an issue where Build SLN, Build APPX, and then Install button does not trigger an install.
Watch for an update!

Could I get some reviews for this?  I was hoping to have it in before making the next release.

@keveleigh, we can either patch, or cherry pick the commits in either direction. I tried doing this already without much success. Ultimately the real way to know that the change are in is if there aren't any merge conflicts and if there are, checking if there are differences.  Hopefully by the end, they'll be happy.

@keveleigh, I was able to include the history for the RS2 branch.


Fix env/docker/py3.yml

[2020-08-24T23:38:24.969Z] Traceback (most recent call last):

[2020-08-24T23:38:24.969Z]   File "docs/md2ipynb.py", line 5, in <module>

[2020-08-24T23:38:24.969Z]     import nbformat

[2020-08-24T23:38:24.969Z] ImportError: No module named 'nbformat'

looks like notedown is missing in the docker for batch job.

The batch job doesn't make use of the conda environment anymore for some reason. Initially nbformat was missing, and it only becomes available via https://github.com/dmlc/gluon-nlp/pull/1325/commits/f2b23627afeaadf38f9137bd5c7aa175a1119513
Including nbformat into the conda yml file didn't help

Failed due to

2020-09-01 12:22:07
Pip subprocess error:
2020-09-01 12:22:07
ERROR: Could not find a version that satisfies the requirement numpy==1.19.1 (from -r /gluon-nlp/env/docker/condaenv._m5hzn7e.requirements.txt (line 1)) (from versions: 1.3.0, 1.4.1, 1.5.0, 1.5.1, 1.6.0, 1.6.1, 1.6.2, 1.7.0, 1.7.1, 1.7.2, 1.8.0, 1.8.1, 1.8.2, 1.9.0, 1.9.1, 1.9.2, 1.9.3, 1.10.0, 1.10.0.post2, 1.10.1, 1.10.2, 1.10.3, 1.10.4, 1.11.0b3, 1.11.0rc1, 1.11.0rc2, 1.11.0, 1.11.1rc1, 1.11.1, 1.11.2rc1, 1.11.2, 1.11.3, 1.12.0b1, 1.12.0rc1, 1.12.0rc2, 1.12.0, 1.12.1rc1, 1.12.1, 1.13.0rc1, 1.13.0rc2, 1.13.0, 1.13.1, 1.13.3, 1.14.0rc1, 1.14.0, 1.14.1, 1.14.2, 1.14.3, 1.14.4, 1.14.5, 1.14.6, 1.15.0rc1, 1.15.0rc2, 1.15.0, 1.15.1, 1.15.2, 1.15.3, 1.15.4, 1.16.0rc1, 1.16.0rc2, 1.16.0, 1.16.1, 1.16.2, 1.16.3, 1.16.4, 1.16.5, 1.16.6, 1.17.0rc1, 1.17.0rc2, 1.17.0, 1.17.1, 1.17.2, 1.17.3, 1.17.4, 1.17.5, 1.18.0rc1, 1.18.0, 1.18.1, 1.18.2, 1.18.3, 1.18.4, 1.18.5, 1.19.0rc1)
2020-09-01 12:22:07
ERROR: No matching distribution found for numpy==1.19.1 (from -r /gluon-nlp/env/docker/condaenv._m5hzn7e.requirements.txt (line 1))
2020-09-01 12:22:07
CondaEnvException: Pip failed

Job PR-1325/7 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1325/7/index.html

Job PR-1325/8 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1325/8/index.html

Job PR-1325/10 is complete.
Docs are uploaded to http://gluon-nlp-staging.s3-accelerate.dualstack.amazonaws.com/PR-1325/10/index.html


update logo link + dimensions

See https://github.com/cert-manager/csi-driver/pull/80 for change justifications

/test pull-cert-manager-istio-csr-ca-rotation


Create ticket templates

Adding a structured ticket templates to describe unpcoming tickets in concise and clear way

@sunchao @viirya @parthchandra


comparison with cbor

Trying to understand the difference between this and cbor. Looks like both use some pre-defined values to represent their content. Wondering what is the difference, and if there are any cost/performance pros/cons.
Not to mention, this multicodec also supports cbor as one of the types in the tables. That sounds like a double / duplicate content description (first one telling the rest of the content is 'cbor', and then 'cbor' telling that the rest of the content is, say ip-address or url or binary etc.). Not sure why would one want to use such duplicated representation, unnecessarily increasing the content length.
Would cbor be not equal to something like multihash rather ? wondering which one is more preferred for future-proof and storing content into DB.

Multicodec is just a prefix for your data. When you read the Multicodec first, you know how to process the subsequent data. So when you store binary data in your database, you could store it in any format you like (e.g. CBOR or MessagePack) and identify how it was stored by just readin the Multicodec.
Another good example of how Multicodec can be used is CIDs.
PS: There's currently #134 open, let me know if you find whether that version of the README would be clearer.

Thank you @vmx
I am trying to understand in what situations I would pick multicodec and in what situations I would be picking cbor.
Maybe someone can correct me, but my understanding from the notes and the above reply is:
If I come across any serialized binary data, and I do not know what exactly the data contains, then I can use multicodec to safely deserialize it correctly, unlike cbor which expects me to have all the tags that may have been used inside it to be present with me.
Is that accurate? Are there any situations where I can not deserialize any multicodec encoded data that I receive (without having to know something about that data). That is, would it work with completely zero-knowledge about the coded data, 100% always?

I am trying to understand in what situations I would pick multicodec and in what situations I would be picking cbor.

If CBOR is good enough, just use CBOR. If you want to have more flexibility to use any possible data, use Multicodec.

That is, would it work with completely zero-knowledge about the coded data, 100% always?

If you come across any serialized binary data, you won't/can't know how to interpret this data, there's no way that you could know. It could be random data, it could be CBOR, it could be a video file. You need some indication.
That indication will come from the system you are building. One way, to support any data format would be Multicodec. But before you even look at the data, you would need to know/make sure that the binary data you are reading is actually Multicodec prefixed.
If CBOR is a good enough format for all your data, you can just make sure that all your data is actually CBOR and you are good (just as you made sure all your data is Multicodec prefixed).

The use case is similar to the scheme in a URL. A domain name alone tells you where to connect on the internet and if you’re only ever going to use HTTP you don’t need a scheme, you would just always connect to port 80. But since we want to future-proof addresses for future protocol changes, we have a scheme, and now you know if someone wants a domain name over HTTP or HTTPS.
It’s the same thing here, you’re handed an “address” (a hash) for binary data. The hash is enough of an identifier to grab the data, but it’s not enough to know how to interpret it. If you only ever support CBOR then you just try to parse all data using CBOR, but if you want to future proof for other data types, or you just want to be able to link to blocks of raw binary data as well as CBOR, you’ll need to put something in the address that tells you how to interpret the data.
Hope that helps.

Thank you @mikeal . That is helpful.
The follow-up question then is: given that cbor is also a schema + data representation, much like multicodec, wondering what was the reason for creating a new spec (multicodec), instead of chosing to use cbor. Any drawbacks with cbor (or for that matter any of its equivalents, such as msgpack etc.)? They all pack the (data + how to read the data) in a similar way.
I am just trying to understand the whole scenario of where each of these tools fit exactly, and any such background information would greatly help the understanding.
What I am seeing is, on the decoding side the multi-codec, cbor, msgpack etc. they all are equivalent (unless I am missing some point, learning of which is the whole goal of this thread). They all know how exactly to decode the data.
For CIDs I am already using multi-codec and its peers. But the problem oftentimes I faced is, you have to encode the data first (eg. buffer -> base64 / hex / base58 etc.) and then multi-code it. And choosing which exact coding method you want to use (e.g. hex, base64 etc.), is upto you. Whereas with likes of cbor it seems you just give the data, and you get back "coded" representation already. No need to worry about choosing between base64, hex, base58 etc. (trust me, making that choice is not easy and I have come across long threads where people argue over hex vs base58 vs base52, and what not).
Multi-codec nicely solves the problem of telling which codec was used for an already coded data. But it does not help with "choosing" the right codec for any given uncoded data. Given that as a user I still have to decide which codec to use (to encode it), this is where the likes of cbor deviate from the multi-codec. I guess multi-codec does not specify the input codec, while the likes of cbor decide it for the user.
In one sense, multi-codec offers the freedom of chosing your own input codec - which is both a bless and curse. Bless if you want to share the coded data with others. Curse, if the data is just for internal storage and you do not know which codec is best for your purpose + you have to write additional encoding code.
Is this some valid line of thought? or Am I missing something?

@KrishnaPG Multicodec is just a table of numbers you can prefix your data with. You could then use unsigned-varint to encode that prefix.
When your data has such a prefix, it's easy to determine what it is. Is is CBOR, msgpack or a Git Object?
Let's say you want to store a Git Object, which consists of the bytes 0x01, 0x02, 0x03.
When you use Multicodec as a prefix of your binary data, you would varint encode that identifier and append the binary data. So the encoded data would be 0x78 0x01 0x02 0x03. That's 4 bytes of payload.
If you don't like varints, you could also use CBOR for it. You would probably encode it as a two element array, where the first element is the identifier what the binary data is about (you would probably use Multicodec for this, so that you don't need to introduce your own table) and the second one the actual data. Your encoded data would then look like that:
82           # array(2)
   18 78     # unsigned(120)
   43        # bytes(3)
      010203 # "\x01\x02\x03"

The total payload is 7 bytes.
In both examples you need some kind of table to indicate which data you're actually storing. That table is Multicodec.

@KrishnaPG the goal of multicodec is to create as small a representation as possible. Remember that, since these are addresses, they end up being embedded as links in other data structures and passed around in applications, so every byte counts.
If you created a CBOR based wrapper for this meta information the resulting cbor object would be significantly larger than a CID, and that would result in much larger blocks containing links and incredibly large (possibly too large) URL parameters and the like.

@mikeal the size of the output being larger for CBOR makes sense. Thank you - that is helpful.


Adding status and removing failedExperimentPoint from clientlib

Removed failedExperimentPoint from js client side SDK
Added status parameter inside markExperimentPoint with default value marked. Accepted values are

applied
not-applied
marked

Experiment user is excluded if status is not-applied

@jreddig Sounds like it should be fine to merge it in. We can always roll it back out if needed. Normally, I'd suggest we check with @jerith666 , but he's on vacation for the rest of the week.

@jerith666 PR now includes your feedback.


New PR to test SignCLA at 2020-05-07 11:10:33.089982749 -0700 PDT m=+7.992391581

Body of PR

unsigned-fail-fork-staging: test succeeded


Edit documentation to add supported browser versions

Select one ...  (check one with "x")
[ ] bug
[ ] feature request
[X] enhancement

Expected behavior
Add text in the browser support section of getting started, we should add "Last two versions of each browser except IE".
Actual behavior
We currently just have the browser names.
Reproduction of behavior
https://vmware.github.io/clarity/get-started#browserSupport
Environment details

Angular version: 2.0.X

Clarity version:

OS and version:

Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

The change for this has been pushed to the website branch. It will be resolved the next time we push the website.
https://github.com/vmware/clarity/commit/a7c343cdfbc0a336ba346944cb2e45989d999178


[BUG] tortoise_tts.py fails on deepspeed/pydantic error

Describe the bug
When running ./scripts/tortoise_tts.py it fails in deepspeed/runtime/config_utils.py from what looks like a pyndantic conflict.
To Reproduce
Install as per instructions
run ./scripts/tortoise_tts.py
Expected behavior
non-fatal output
ds_report output
ds_report
/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/pydantic/_internal/_config.py:334: UserWarning: Valid config keys have changed in V2:

'allow_population_by_field_name' has been renamed to 'populate_by_name'
'validate_all' has been renamed to 'validate_default'
warnings.warn(message, UserWarning)
/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/pydantic/_internal/fields.py:160: UserWarning: Field "model_persistence_threshold" has conflict with protected namespace "model".

You may be able to resolve this warning by setting model_config['protected_namespaces'] = ().
warnings.warn(
Traceback (most recent call last):
File "/home/jw/miniforge3/envs/TTSF/bin/ds_report", line 3, in
from deepspeed.env_report import cli_main
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/init.py", line 16, in
from . import module_inject
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/module_inject/init.py", line 6, in
from .replace_module import replace_transformer_layer, revert_transformer_layer, ReplaceWithTensorSlicing, GroupQuantizer, generic_injection
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/module_inject/replace_module.py", line 732, in
from ..pipe import PipelineModule
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/pipe/init.py", line 6, in
from ..runtime.pipe import PipelineModule, LayerSpec, TiedLayerSpec
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/pipe/init.py", line 6, in
from .module import PipelineModule, LayerSpec, TiedLayerSpec
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/pipe/module.py", line 19, in
from ..activation_checkpointing import checkpointing
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/activation_checkpointing/checkpointing.py", line 25, in
from deepspeed.runtime.config import DeepSpeedConfig
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/config.py", line 28, in
from .zero.config import get_zero_config, ZeroStageEnum
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/zero/init.py", line 6, in
from .partition_parameters import ZeroParamType
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 569, in
class Init(InsertPostInitMethodToModuleSubClasses):
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/zero/partition_parameters.py", line 571, in Init
param_persistence_threshold = get_config_default(DeepSpeedZeroConfig, "param_persistence_threshold")
File "/home/jw/miniforge3/envs/TTSF/lib/python3.10/site-packages/deepspeed/runtime/config_utils.py", line 116, in get_config_default
field_name).required, f"'{field_name}' is a required field and does not have a default value"
AttributeError: 'FieldInfo' object has no attribute 'required'. Did you mean: 'is_required'?
Screenshots
If applicable, add screenshots to help explain your problem.
System info (please complete the following information):

OS: Debian GNU/Linux 12
GPU 1 Nvidia GeForce RTX 4090Ti
Python 3.10.14
Running in a conda env dedicated to tortoise-tts-fastest

This was a fresh install into a new environment.
I have seen related issues (https://github.com/microsoft/DeepSpeed/issues/4105), but the solution of downgrading pedantic to <2.0.0 does not work as it creates a slew of other errors.
Currently running
pydantic                  2.7.3
pydantic_core             2.18.4
deepspeed                 0.9.0

Hi @tholonia - we don't quite support pydantic 2+ yet, that is listed in our requirements file, are you able to run with pydantic 1?

Hi @tholonia - our latest release, v0.15.0 supports pydantic 2, so please try again with that.  Closing this issue but if you are still hitting problems, please comment and we can re-open.


Claims request had header "Connection: close" when header is "Connection: keep-alive"

Steps to reproduce:
$ cat <<EOF | unix2dos | nc httpbin.org 80
> POST /post HTTP/1.1
> Host: httpbin.org
> Content-Length: 0
> Connection: keep-alive
>
> POST /post HTTP/1.1
> Host: httpbin.org
> Content-Length: 0
> Connection: close
>
> EOF
HTTP/1.1 200 OK
Connection: keep-alive
Server: meinheld/0.6.1
Date: Tue, 27 Mar 2018 21:13:16 GMT
Content-Type: application/json
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
X-Powered-By: Flask
X-Processed-Time: 0
Content-Length: 249
Via: 1.1 vegur

{
  "args": {},
  "data": "",
  "files": {},
  "form": {},
  "headers": {
    "Connection": "close",
    "Content-Length": "0",
    "Host": "httpbin.org"
  },
  "json": null,
  "origin": "<IP_ADDRESS>",
  "url": "http://httpbin.org/post"
}
HTTP/1.1 200 OK
Connection: close
Server: meinheld/0.6.1
Date: Tue, 27 Mar 2018 21:13:15 GMT
Content-Type: application/json
Access-Control-Allow-Origin: *
Access-Control-Allow-Credentials: true
X-Powered-By: Flask
X-Processed-Time: 0
Content-Length: 249
Via: 1.1 vegur

{
  "args": {},
  "data": "",
  "files": {},
  "form": {},
  "headers": {
    "Connection": "close",
    "Content-Length": "0",
    "Host": "httpbin.org"
  },
  "json": null,
  "origin": "<IP_ADDRESS>",
  "url": "http://httpbin.org/post"
}

Notice that the first HTTP response sent back has this section:
"headers": {
    "Connection": "close",
    ...

This is not correct; it should say:
"headers": {
    "Connection": "keep-alive",
    ...

As an HTTP server, httpbin seems to obey the Connection header correctly. However, the JSON body does not return the headers that were sent.

Hi @jameshfisher, this is a duplicate of a number of other issues, the most recent being #432. Please be sure to check closed issues before opening new ones in the future. Thank you!


Support Xcode 12

Xcode 12 bumps minimum iOS deployment target to iOS 9. Several changes have been made to go along with this:

platforms removed from Package.swift. Those platforms only specify minimum deployment target, if it is higher than minimum SPM deployment target. Thus if they are omitted, Swift Package will automatically support all platforms supported by current tools.
iOS deployment target in CocoaPods bumped to iOS 9
iOS deployment target in Xcode project bumped to iOS 9.

Removing platforms from Package.swift removes the minimum deployment target, but the other changes seem like they would needlessly drop iOS 8 support from the library.

I would disagree that this is needless. Xcode 12 shows a warning for iOS 8 regardless of installation method, and I wouldn't be surprised if this warning turned into error in the nearest future.
Of course, there is still a workaround at least for CocoaPods, described here, but future-proofing seems like a good idea in this case, since if you need iOS 8, you can easily use previous SwiftyJSON releases.

I suggest adding Swift 5.3 specific package in order to keep the iOS 8 support. Check this article for reference.

@kristiyandobrev Hey, thanks for suggestion!
I think it is a possible solution, but I personally don't recommend going this way. There are several reasons to this:

It would require a separate Package.swift file every time a change like this occurs.
This feature is very loosely documented, and SwiftPM developers do not recommend to use it unless absolutely required, here's a quote from official documentation:

This feature is intended for use in cases where a package wishes to maintain compatibility with multiple Swift project versions, but requires a substantively different manifest file for this to be viable (e.g., due to changes in the manifest API).
It is not expected the packages would ever use this feature unless absolutely necessary to support existing clients. Specifically, packages should not adopt this syntax for tagging versions supporting the latest GM Swift version.

Whatever decided for Package.swift files and SPM, CocoaPods and Carthage installation methods still need to be handled. And support for iOS 8 is not being dropped - you can easily install previous release, or even depend on branch/commit with any of package managers.

That being said, ultimately it should be a repo maintainer decision on how to proceed with this, and I can provide another PR, or redo current one, if decision will be different then proposed currently. @wongzigii maybe you have a bit of time to chime on on this?

+1
@DenTelezhkin You could update the README where it specifies the minimum required iOS version.

@Zandor300 Sure, but let's wait until repo maintainers respond to current changes and see if those changes suit them.


DEMO-1 Remove irrelevant line from README

I pushed a bad commit to the README file in main earlier. This PR fixes that
TEST: N/A
See DEMO-1 for details.

:shipit:


Include/exclude by topic or tag

It's nice to be able use say a github topic to include/exclude

Heya - yea I could see this fitting into the config as something like the following:
{
    "$schema": "./schemas/v2/index.json",
    "repos": [
        {
            "type": "github",
            // Include repositories that have at least one of the following topics.
            "topics": [
                "topic-1",
                "topic-2"
            ],
            "exclude": {
                // Exclude repositories that have at least one of the following topics.
                "topics": [
                    "topic-3"
                ]
            }
        }
    ]
}

// result: index repositories that have either topic-1 or topic-2 (or both) and do not have topic-3

GitLab has the same concept, so we could support it there as well.


Kernel parameters not applied on boot/reboot

I am trying to harden a K3s installation and according to the documentation I need to provide some kernel parameters.
The current image config has the following parameters:
operatingSystem:
  kernelArgs:
    - fips=1
    - vm.panic_on_oom=0
    - vm.overcommit_memory=1
    - kernel.panic=10
    - kernel.panic_on_oops=1

When booting the image the kernel  parameters seem not to be applied. They seem not to be set when checking with sysctl -a | grep <param>
$ sysctl -a | grep kernel.panic
kernel.panic = 0 # expect 10
kernel.panic_on_oops = 0 # expect 1

However the params are nicely in the /proc/cmdline
$ cat /proc/cmdline
BOOT_IMAGE=/boot/vmlinuz-5.14.21-150500.55.19-default root=UUID=e2935bc6-aa22-443b-8331-578c5c575ac7 rd.timeout=60 console=ttyS0,115200 console=tty0 security=selinux selinux=1 quiet net.ifnames=0 ignition.firstboot dasd_mod.dasd=autodetect ignition.platform.id=metal fips=1 vm.panic_on_oom=0 vm.overcommit_memory=1 kernel.panic=10 kernel.panic_on_oops=1

I wonder what I am doing wrong?

Hey @mpas - unlike fips=1, the parameters you're trying to change are sysctl values (not kernel cmdline arguments), which you don't set as part of the kernel cmdline. These need to go into a file in /etc/sysctl.d/, e.g. /etc/sysctl.d/hardening.conf. See: https://documentation.suse.com/sles/15-SP5/html/SLES-all/cha-sec-sysctl.html for further details.
If you wanted to apply these via EIB, what I'd do is the following (in your EIB build directory):
% mkdir -p custom/scripts custom/files

% cat << EOF > custom/files/hardening.conf
vm.panic_on_oom=0
vm.overcommit_memory=1
kernel.panic=10
kernel.panic_on_oops=1
EOF

% cat << EOF > custom/scripts/60-sysctl.sh
#!/usr/bin/env bash
cp hardening.conf /etc/sysctl.d/
EOF

% chmod a+x custom/scripts/60-sysctl.sh

Then, when the system boots up, you should have the values you require:
localhost:~ # cat /proc/cmdline
BOOT_IMAGE=/boot/vmlinuz-5.14.21-150500.55.19-default root=UUID=ba0a3c19-afc9-4ae1-9ff5-524c78b93d3a rd.timeout=60 console=ttyS0,115200 console=tty0 security=selinux selinux=1 quiet net.ifnames=0 ignition.firstboot dasd_mod.dasd=autodetect ignition.platform.id=metal fips=1

localhost:~ # sysctl -a | grep kernel.panic
kernel.panic = 10
kernel.panic_on_io_nmi = 0
kernel.panic_on_oops = 1
kernel.panic_on_rcu_stall = 0
kernel.panic_on_unrecovered_nmi = 0
kernel.panic_on_warn = 0
kernel.panic_print = 0

Please let us know if you need any further help!

@rdoxenham Thanks for the extensive reply! Learned something new (again 😄) I was tricked by the K3s hardening guide that mentions these values are kernels parameters. So that is why I had the impression it had to go into kernelArgs section of EIB.

With pleasure @mpas!


[FEATURE REQUEST] Implement worker nodes downscale

Is your feature request related to a problem? Please describe.
This request is the result of #1497 spike. At the moment Epiphany has no ability to scale down worker nodes correctly, this ability should be added. Such task existed previously - #1202, that work should be continued.
Describe the solution you'd like
When count of k8s worker nodes is decreased in config file and new configuration applied, all necessary work, such as cordon/drain nodes should be done before node removal by Terraform.
Describe alternatives you've considered
No
Additional context

Documentation about scaling process should be updated.
Should work for all cloud providers.

DoD checklist

Changelog

[ ] updated
[ ] not needed

COMPONENTS.md

[ ] updated
[ ] not needed

Schema

[ ] updated
[ ] not needed

Backport tasks

[ ] created
[ ] not needed

Documentation

[ ] added
[ ] updated
[ ] not needed

[ ] Feature has automated tests
[ ] Automated tests passed (QA pipelines)

[ ] apply
[ ] upgrade
[ ] backup/restore

[ ] Idempotency tested
[ ] All conversations in PR resolved
[ ] Solution meets requirements and is done according to design doc
[ ] Usage compliant with license

Not going todo anymore feature requests for Epiphany.


feat: add Scroll Sepolia testnet

Following up on #112, adding Scroll Sepolia testnet addresses. Faucet fixes applied in #133 already applied.
Updates viem to support Scroll Sepolia's chain info.
Address Output:
https://gist.github.com/dghelm/7fe68f0a524f30846e1142721c081d84
Contracts verified on Blockscout.

FYI @sakulstra : The contract addresses for everything (except the faucet) match Scroll Alpha, in case that helps make review quicker.

@dghelm any idea where the yarn lock changes are coming from? seems like the package source has changed which is a bit weird (looks okay as it's now yarnpkg but the change is still awkward)

@sakulstra  -- I think it comes from me trying to fix merge conflicts and maybe just deleting and regenerating the yarn.lock to make sure I didn't mess anything up.
Updating the viem package will change something there, but so many diffs from an outside contributor is not a good look for a security-critical package!
Let me raise a new PR.

Actually, I don't think there's a good way to avoid this unless I just don't commit the changes on the yarn.lock file.
Just tried a fresh branch and just running yarn is going to make this happen. I can run yarn install --frozen-lockfile before yarn add<EMAIL_ADDRESS>but the additional changes to the lock file still occur.
That said, running yarn why on a few packages shows a bit more what packages have triggered them:
❯ yarn why fsevents
yarn why v1.22.5
[1/4] Why do we have the module "fsevents"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Reasons this module exists
   - "tsup#chokidar" depends on it
   - Hoisted from "tsup#chokidar#fsevents"
   - Hoisted from "tsup#rollup#fsevents"

❯ yarn why @esbuild/android-arm64
yarn why v1.22.5
[1/4] Why do we have the module<EMAIL_ADDRESS>[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found "<EMAIL_ADDRESS>info Reasons this module exists
   - "tsup#esbuild" depends on it
   - Hoisted from "tsup#esbuild#@esbuild#android-arm64"

Any guidance on the best path forward? Also, do I need to be worrying about package-lock.json?

@dghelm didn't notice there was such a mess on our side :(
resolved here: https://github.com/bgd-labs/aave-address-book/pull/213, you you rebase on that (also updated viem so no changes should be needed on your side. Sorry for the mess)

@sakulstra Thanks for taking care of it in the main branch! To clean things up, I've moved to #215 and will close this thread.


set cors to false to enable booleanism on the command-line

I missed cors in the default list, which was the whole reason behind the first patch!
With this patch:
$ ecstatic --cors public/ -p 8000

will finally work.

Published as 1.1.3
Thanks!


L515 LiDAR not working

librealsense
2.50.0 RELEASE

OS
Windows

Hi Intel staff,
After a recent WIN10 re-installation, L515 cannot be correctly loaded (USB2.1, instead of USB3.0 is shown as the connection) and depth data cannot be acquired, i.e. depth sensor cannot be turned on in the Viewer (v.2.50.0). However, the RGB cam & IMU are functioning.
Could you please help me with this issue?
Many thanks

Hi @fortuitousanonymous   Could you first unplug the micro-sized end of the USB cable from the base of the camera, reverse the connector's orientation and plug it back into the camera, please (USB-C cables are two-way insertion at the micro-sized end).
Does doing so make any difference?

Thanks Marty for the prompt reply.
I restored the depth camera partially. I updated the firmware using Viewer
v2.40. However, it still shows that it is connecting via USB2.1. I can
only run the depth camera at the lowest resolution.
Any advice?
Many thanks,
Dahe
On Thu, Dec 23, 2021 at 6:04 PM MartyG-RealSense @.***>
wrote:

Hi @fortuitousanonymous https://github.com/fortuitousanonymous Could
you first unplug the micro-sized end of the USB cable from the base of the
camera, reverse the connector's orientation and plug it back into the
camera, please (USB-C cables are two-way insertion at the micro-sized end).
Does doing so make any difference?
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/10098#issuecomment-1000090093,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APYVDXTHTURACOS4K7KD7NTUSLCZBANCNFSM5KT752HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--

Dr. Dahe Gu
Ph.D., B.E. (Hons)
Mobile: +61 430 188 278
E-mail: @.***

The symptoms that you describe can occur when the USB connector in the base of the camera is inserted in a certain direction.  Can you confirm please whether flipping the insertion direction of the micro-sized end of the connector in the camera base resolves the problem, please?

I flipped the insertion direction and the other direction results in no
detection of L515 by the Viewer at all. I repeated this by three times.
On Thu, Dec 23, 2021 at 6:16 PM MartyG-RealSense @.***>
wrote:

The symptoms that you describe can occur when the USB connector in the
base of the camera is inserted in a certain direction. Can you confirm
please whether flipping the insertion direction of the micro-sized end of
the connector in the camera base resolves the problem, please?
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/10098#issuecomment-1000095306,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APYVDXQMV3EXVZC4SUSL37DUSLEDLANCNFSM5KT752HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--

Dr. Dahe Gu
Ph.D., B.E. (Hons)
Mobile: +61 430 188 278
E-mail: @.***

Furthermore, on my laptop, I used L515 3 days ago at full resolution and
nothing changed between back then and now.
I have used L515 since May 2021 and this is the first time I encountered
this issue.
On Thu, Dec 23, 2021 at 6:17 PM Dahe Gu @.***> wrote:

I flipped the insertion direction and the other direction results in no
detection of L515 by the Viewer at all. I repeated this by three times.
On Thu, Dec 23, 2021 at 6:16 PM MartyG-RealSense @.***>
wrote:

The symptoms that you describe can occur when the USB connector in the
base of the camera is inserted in a certain direction. Can you confirm
please whether flipping the insertion direction of the micro-sized end of
the connector in the camera base resolves the problem, please?
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/10098#issuecomment-1000095306,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APYVDXQMV3EXVZC4SUSL37DUSLEDLANCNFSM5KT752HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--

Dr. Dahe Gu
Ph.D., B.E. (Hons)
Mobile: +61 430 188 278
E-mail: @.***

--

Dr. Dahe Gu
Ph.D., B.E. (Hons)
Mobile: +61 430 188 278
E-mail: @.***

Thanks very much for testing the connector.
Next, please open the Windows Device Manager and go to the Cameras category.  There should be two drivers listed, RGB and Depth, when the L515 is plugged in.
Right-click on each of them and select Uninstall device from the menu until both drivers are removed.  Then unplug the camera from the USB port, wait a couple of seconds and re-insert it.  The drivers should automatically re-install and be listed again in the Device Manager.
Does this resolve the problem?

Thanks again Marty.
I did that and also flipped the connector. The problem still persists -
USB2.1 and flip does not work.
Cheers,
Dahe
On Thu, Dec 23, 2021 at 6:31 PM MartyG-RealSense @.***>
wrote:

Thanks very much for testing the connector.
Next, please open the Windows Device Manager and go to the Cameras
category. There should be two drivers listed, RGB and Depth, when the L515
is plugged in.
Right-click on each of them and select Uninstall device from the menu
until both drivers are removed. Then unplug the camera from the USB port,
wait a couple of seconds and re-insert it. The drivers should automatically
re-install and be listed again in the Device Manager.
Does this resolve the problem?
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/10098#issuecomment-1000101737,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APYVDXWDO7OL6PRNOEFTDLDUSLF3VANCNFSM5KT752HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--

Dr. Dahe Gu
Ph.D., B.E. (Hons)
Mobile: +61 430 188 278
E-mail: @.***

Thanks for your continued patience.  Next, could you try installing the SDK on Windows again using the Intel.RealSense.SDK-WIN10 automated installer file in the 'Assets' list of the SDK Releases page?  As installing with this method completely overwrites the previous SDK installation made using this method, it can correct problems that might have ocurred during the previous SDK installation.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.50.0

Still the same problem, unfortunately.
Could it be the problem w/ my WIN10 OS as it has recently been upgraded?
Strange enough that 3 days ago, it worked ... Same setup and conditions
that I am aware of ... Could it be a WIN update killed it?
Cheers,
Dahe
On Thu, Dec 23, 2021 at 6:55 PM MartyG-RealSense @.***>
wrote:

Thanks for your continued patience. Next, could you try installing the SDK
on Windows again using the Intel.RealSense.SDK-WIN10 automated
installer file in the 'Assets' list of the SDK Releases page? As
installing with this method completely overwrites the previous SDK
installation made using this method, it can correct problems that might
have ocurred during the previous SDK installation.
https://github.com/IntelRealSense/librealsense/releases/tag/v2.50.0
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/10098#issuecomment-1000112447,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APYVDXXZZUO6XLA4Q65UPTLUSLIWHANCNFSM5KT752HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--

Dr. Dahe Gu
Ph.D., B.E. (Hons)
Mobile: +61 430 188 278
E-mail: @.***

Windows updates can sometimes cause conflicts with RealSense cameras that worked fine before the update, yes.

Any suggestion that I could revert back? Many thanks
On Thu, 23 Dec 2021 at 8:08 pm, MartyG-RealSense @.***>
wrote:

Windows updates can sometimes cause conflicts with RealSense cameras that
worked fine before the update, yes.
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/10098#issuecomment-1000152123,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APYVDXWYCX2NVVJGWZA2EHTUSLRKNANCNFSM5KT752HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--
—————————————————————
Dr. Dahe Gu
Ph.D., B.E. (Aerospace) (Hons)
Mobile: 0430 188 278
Email: @.***

If your PC has got enabled the saving of recovery points (which are created when updates are performed) then you can roll Windows back to a time before the update.
https://www.windowscentral.com/how-use-system-restore-windows-10

Thanks Marty. Problem solved, I re-installed WIN10. Interestingly, this
time one side of the USB is 2.1 and another is 3.1.
Many thanks,
Dahe
On Thu, Dec 23, 2021 at 8:22 PM MartyG-RealSense @.***>
wrote:

If your PC has got enabled the saving of recovery points (which are
created when updates are performed) then you can roll Windows back to a
time before the update.
https://www.windowscentral.com/how-use-system-restore-windows-10
—
Reply to this email directly, view it on GitHub
https://github.com/IntelRealSense/librealsense/issues/10098#issuecomment-1000160310,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/APYVDXQF3NJJGJIUIF3XYILUSLS5JANCNFSM5KT752HQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

--

Dr. Dahe Gu
Ph.D., B.E. (Hons)
Mobile: +61 430 188 278
E-mail: @.***

That's excellent news, @fortuitousanonymous
Don't worry about the 2.1 / 3.1 status when flipping the camera end of the USB connector.  That is a known hardware trait of the L515 model.

How to perform hand eye calibration on the realsense L515 camera, with the eyes in hand？


[Agent APIs] Do not log query parameters, fix to also log non-existing endpoints

What does this PR do?

Fix logging added by https://github.com/DataDog/datadog-agent/pull/22072 to only print the query path, in particular not the parameters.
Also move the handler to run on every request to the API instead of in each mux separately.
Also print the host part of the query following suggestion.
Motivation

The query parameters could contain secrets.
It didn't log when hitting an endpoint which didn't exist, moving the handler higher in the handler chain allows to also have logs for non-existing endpoints (which were otherwise filtered by the mux itself).
Additional Notes

Also improved testing, eg. tested that even when using http.StringPrefix the full path is printed.
Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Done with unit tests.
Can be tested manually with
curl -k -H "authorization: Bearer $(cat dev/dist/auth_token)" "https://localhost:5001/agent/ver?mysecret=qwertyuiop"

It will print
2024-01-22 12:34:54 CET | CORE | WARN | (comp/api/api/apiimpl/utils/observability.go:29 in func1) | CMD API Server: GET /agent/ver from <IP_ADDRESS>:64515 to localhost:5001 took 9.875µs and returned http code 404

Reviewer's Checklist

[ ] If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
[ ] Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
[ ] A release note has been added or the changelog/no-changelog label has been applied.
[ ] Changed code has automated tests for its functionality.
[ ] Adequate QA/testing plan information is provided. Except if the qa/skip-qa label, with required either qa/done or qa/no-code-change labels, are applied.
[ ] At least one team/.. label has been applied, indicating the team(s) that should QA this change.
[ ] If applicable, docs team has been notified or an issue has been opened on the documentation repo.
[ ] If applicable, the need-change/operator and need-change/helm labels have been applied.
[ ] If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
[ ] If applicable, the config template has been updated.

/merge


Maya: Loader sometimes doesn't refresh when assets are changed

Problem
Client reported issue when using  Loader in Maya that sometimes subset part of asset loader window doesn't refresh when another asset is selected, leading to loading wrong subsets to scene.

Couldn't reproduce, is there more information in what state this occurred?

Nope, it never happened to me. One client reported it multiple times.

I'm closing this. Never occured again and can't be reproduced


[Ionic v4] ie11 arrow function problem

Bug Report
Ionic Info
   ionic (Ionic CLI)          : 4.0.1
   Ionic Framework            : @ionic/angular 4.0.0-beta.0
   @angular-devkit/core       : 0.7.0-rc.3
   @angular-devkit/schematics : 0.7.0-rc.3
   @angular/cli               : 6.0.8
   @ionic/ng-toolkit          : 1.0.0
   @ionic/schematics-angular  : 1.0.0
Cordova:
   cordova (Cordova CLI) : not installed
   Cordova Platforms     : android 7.0.0
System:
   Android SDK Tools : 26.1.1
   NodeJS            : v8.11.3 (C:\Program Files\nodejs\node.exe)
   npm               : 5.6.0
   OS                : Windows 10

Describe the Bug
Opening page in Internet Explorer gives syntax error on =>
Steps to Reproduce
Add arrow function to your code, run ionic serve and open page in Internet Explorer 11
Additional Context
I have also enabled IE polyfills in polyfills.ts and I have es5 as target in compiler options in tsconfig.json.

i have the same problem.
it looks like it does not compile ionic to es5?


fix link in README on line "See full example here"

now there is 404 NOT FOUND

Thank you! Fixed!


Add am62xx install instructions

Readiness

[x ] Merge (pending reviews)
[ ] Merge after date or event
[ ] Draft

Overview
Why merge this PR? What does it solve?
Checklist
Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

[ ] Run spelling and grammar check, preferably with linter.
[ ] Avoid changing any header associated with a link/reference.
[ ] Step through instructions (or ask someone to do so).
[ ] Review for wordiness
[ ] Match tone and style of page/section.
[ ] Run make linkcheck.
[ ] View HTML in a browser to check rendering.
[ ] Use semantic newlines.
[ ] follow best practices for commits.

[ ] Descriptive title written in the imperative.
[ ] Include brief overview of QA steps taken.
[ ] Mention any related issues numbers.
[ ] End message with sign off/DCO line (-s, --signoff).
[ ] Sign commit with your gpg key (-S, --gpg-sign).
[ ] Squash commits if needed.

[ ] Request PR review by a technical writer and at least one peer.

Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

Docs for c6cd59d15f2c41f43396230e6e9e2d0994430135 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/1979/docs/artifacts/html/index.html


Fix the problem that sve functions cannot be debugged by gdb

fix issues #125

Thanks @chenxuqiang. Anyone from ARM that can review this?

This change makes sense to me.
Without explicit specify a '.text' section in .S files, it will leave this decision to GNU as's default behavior. Actually, default behavior cannot make sure the code always be put into section '.text'. Such as this file ( what @chenxuqiang modified)
 sm3_mb/aarch64/sm3_mb_sve.S , everything was put into '.rodata.cst16' section, because '.rodata.cst16'  is declared in sm3_mb_common.S, which is #includeed by 'sm3_mb_sve.S', right before the start of its code section.
In conclusion, adding a '.text' section is a good catch.
For safety reasons, probably we should explicitly add '.text' in all .S assembly files.
Eg. here we can list all such files:
 find . -depth -type f -path '*aarch64*' -name '*S'  -exec sh -c 'grep -q "\.text" "$1" || echo "$1"' sh {} \;

so, @chenxuqiang would you mind to modify the commit's subject to make it more accurate?
"Fix the problem that sve functions cannot be debugged by gdb" is misleading in my humble opinion. The issue can happen in all .S files if missing '.text' declaration.

Hi @chenxuqiang. Could you update this PR to address @docularxu comments? Adding .text in all .S files sounds like a good idea.

This is now merged, but @chenxuqiang, could you look into the other files and open another PR addressing @docularxu comments?

Closing this PR, as this code is merged. Feel free to open another one with more fixes.


Multiples config files ?

Hi,
We choose to mix our spec files and regular files in the same directories.
We would like to have separate eslint configuration for *.spec.js files and other *.js files.
Is that possible with this extension ? with eslint we use 2 differents config files and run 2 separate command line to lint our codebase

This is currently not possible.

thanks,
is this feature a good thing ? should we implement it here ? or elsewhere ?

Yes, the right place to implement this is here. What needs to be done is to have a setting that allows to point to different configuration files for different file patterns. But I am not sure how to best then pass this to the ESLint npm module.

something need the config pattern of lint-staged project maybe ?
{
".js": ".eslintrc.json",
".spec.js": ".eslintrc.spec.json",
}

Seems like we may have this is eslint already
https://eslint.org/docs/user-guide/configuring#configuration-based-on-glob-patterns

Closing to investigate if this can be solve using eslint

@clakech thanks. I wasn't aware of this one either.

I tested this and now I can activte eslint in vscode, the proper
configuration is used depending of the pattern of the files
names/directories . It rocks !
Le ven. 13 oct. 2017 à 13:17, Dirk Bäumer<EMAIL_ADDRESS>a
écrit :

@clakech https://github.com/clakech thanks. I wasn't aware of this one
either.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode-eslint/issues/308#issuecomment-336423946,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABHXhvCVfdoaxAOTgZP568mcP5iz2VEgks5sr0bTgaJpZM4PuqPI
.

--
Cyril Lakech

Cool to know.


"Render on change" sporadically displayed in status bar

I haven't figured out exact repro steps for this yet, but occasionally on startup I've seen "Render on change" in the status bar:

It usually seems to be with an unsaved buffer on startup, but I'm not sure.
Atom 0.192.0

Some vague repro steps:

Open blank Atom window (with new, unsaver buffer) by clicking on the Atom icon in the dock with no windows open.
Render on change will appear in the status bar.

Updates: definitely a package - doesn't appear in "safe" mode ("safe" = manually disabling all community packages, since I could only reproduce this by clicking on the dock icon).


Release Pipeline to local docker container (CICD)

Do you have any guidance/reference for using a release pipeline to a local container (not Azure/Saas)?
The Deploy-App.ps1 script only has "deploymentType" options for AzureVM and onlineTenant.  Would I have to add a new deploymentType and use logic similar to the Invoke-WebRequest logic found in the "onlineTenant" deployment options?
Is there an easier way?

Maybe set the reusecontainer to false - and then use the build container?
But basically, what you want to do is to create a container and use publish-bccontainerapp to publish the app including -sync and -install.

Thank you @freddydk it turned out to be fairly simple for a local Docker container (from where the Pipeline/agent is).
Next step is for me to test release to an AzureVM with a local install (no container).

On the DVD you will find some PowerShell Cmdlets for publishing and installing apps.


Add index page for notebook examples

For now, will use normal notebook hyperlinks to develop an index landing page that categorizes examples.
In the future, may want to move to something more like Jupyter{book}.

Yeah, the static site publishing target is good goal, but it takes some work to make kernel-less linked visualizations work: a lot of stuff would have to be made to work with ipywidgets.jslink.
Another intermediate approach:
https://github.com/deathbeds/wxyz/blob/master/notebooks/index.ipynb
This uses importnb to treat the landing page load up all the demo applications. By importing the other example notebooks:

your "landing page" can put the best content up front (ideally just one a one-line code cell to import and show each example)
imported notebooks need to stay in a "restart-run-all"-able state... this is a blessing and a curse, as the index will serve as a good smoke test before running "heavy" notebooks
eventually, this helps move towards packaged notebooks, to make finding things more convenient.


Documentation missing type information.

I am having trouble with SetCurrent and I noticed it didn't mention what the units or data types are. It throws an error when I try to use a float, but float is what I would want to use. Integer values don't seem to work either.
I noticed on dutycycle the example shows a value of 255, which makes me wonder if that is a 0-255 type of value rather than the float the docs suggest.

I haven't used this message and I didn't write it but I was talking with @ottopasuuna and I believe this should be an integer in mA (ie. 0.6A should be given as int(600)). I'll update the documentation once I we figure out how it was supposed to be passed.
If that doesn't work could you post the error message and the call stack?

Update:
Yes the units for SetCurrent are milliamps and the type should be an integer. Sorry about the confusion.
For example this should work:
current = 1300 # [mA]
msg = pyvesc.SetCurrent(current)
pyvesc.encode(msg)
b'\x02\x05\x06\x00\x00\x05\x14`\xc5\x03'

@tlalexander Let me know if you have any further problems with this.
Relevant VESC code:
https://github.com/vedderb/bldc_uart_comm_stm32f4_discovery/blob/master/bldc_interface.c#L532
https://github.com/vedderb/bldc_uart_comm_stm32f4_discovery/blob/3cef7bab0a85100f2442f5652731b7e56a6051ac/buffer.c#L55

Awesome, thanks for the quick reply! Excited to test now as current mode works better for me. I tried it up to SetCurrent(100) but not high enough that it should have done anything. I will test this week and re open the issue if I have further problems.


Starting with --local then turning off local mode crashes

Since you're never prompted to login & choose your accountId, you don't get that nor apitToken in the session, and you get this error
❯ npx wrangler dev index.js --local
⎔ Starting a local server...
⬣ Listening at http://localhost:8787

  ERROR  accountId is required

 node_modules/wrangler/wrangler-dist/index_node.js:98573:29

 98570:   }, []);
 98571: }
 98572: function Remote(props) {
 98573:   (0, import_assert.default)(props.accountId, "accountId is required");
 98574:   (0, import_assert.default)(props.apiToken, "apiToken is required");
 98575:   const token = useWorker({
 98576:     name: props.name,

 - Remote (node_modules/wrangler/wrangler-dist/index_node.js:98573:29)
 - renderWithHooks (node_modules/wrangler/wrangler-dist/index_node.js:18265:26)
 - mountIndeterminateComponent (node_modules/wrangler/wrangler-dist/index_node.js:20385:21)
 - beginWork (node_modules/wrangler/wrangler-dist/index_node.js:21172:22)
 - Object.invokeGuardedCallbackProd (node_modules/wrangler/wrangler-dist/index_node.js:22163:19)
 - invokeGuardedCallback (node_modules/wrangler/wrangler-dist/index_node.js:22250:39)
 - beginWork$1 (node_modules/wrangler/wrangler-dist/index_node.js:25088:15)
 - performUnitOfWork (node_modules/wrangler/wrangler-dist/index_node.js:24314:20)
 - workLoopSync (node_modules/wrangler/wrangler-dist/index_node.js:24265:13)
 - renderRootSync (node_modules/wrangler/wrangler-dist/index_node.js:24240:15)

⎔ Shutting down local server.

A similar problem when passing --host, or routes, is that the zone id won't be available when starting from local and moving to remote mode.

Steps
mkdir sampleworker
cd sampleworker
npx wrangler@2 init -y
npx wrangler@2 dev --local
# press l

Node v16.7 // npm 7.20.3
Wrangler v2

Error
accountId is required
node_modules/wrangler/wrangler-dist/cli.js:108881:35

If it needs an account id, maybe should error out if wrangler.toml is missing account_id per https://developers.cloudflare.com/workers/wrangler/configuration/

Note that this is still an issue with version 2.0.7, and even if I previously logged in with wranger, AND actually specify an account_id in the wrangler.toml file (I also tried accountId).


Updated tool to create clinical annotations worklist

The tool now accepts an optional file as input that can be used to filter which ROIs annotations will be used to create the clinical annotations worklist

It also adds a few more features which I had forgotten about :)


Fix setting label selection spinbox dtype

Description

Add get_dtype label utility to get dtype of labels data, accounting for multiscale labels
Fix setting QtLargeIntSpinbox dtype in QtLabelsControls

Type of change

[x] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References
Closes #2678
How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

Thanks @DragaDoncila
This is an excellent example of us needing a "layer data interface".  We (and more importantly, plugins) should be able to ask standard things (like dtype and shape) of layer.data without needing lots of conditionals

should be able to ask standard things (like dtype and shape) of layer.data without needing lots of conditionals

@tlambert03 totally agree, tbh this definitely didn't feel like a util but should be a Labels.data attribute instead. Do you think I should move it in to be a Labels attribute in the mean time?

Nah, I think you took the right approach for now (we have similar conditionals scattered throughout image layer too).  I think we should maybe have a DataProtocol type that checks for a certain interface, and then a few data wrappers for nonstandard things like multiscale data that can adapt them to our declared interface

I'm also a little surprised this wasn't caught by tests.  Can you maybe check to see whether adding a multi-scale labels layer to the napari._tests.utils.layer_test_data list would have caused a failure without this fix?


fix: grammar/typos

Fixed up the README and added some formatting
Renamed the LICENSENS folder to LICENSES

Looks like you really approved eh

I thaught I had to do it per file, but apparently is was for all 😅


"Schedule for Later" Calendar highlights the wrong date

Issue Summary
When selecting a date in the publish page (after selecting "schedule send for later"), the date in the date picker is shown as one day prior to the day actually selected.
Already made this issue as #21634, but linear bot closed it for some reason.
Steps to Reproduce
See above
Ghost Version
5.101.2
Node.js Version
18
How did you install Ghost?
Ubuntu 22.04 LTS
Database type
MySQL 8
Browser & OS version
Chrome & macOS Sequoia
Relevant log / error output
No response
Code of Conduct

[X] I agree to be friendly and polite to people in this repository

I think it was fixed in https://github.com/TryGhost/Ghost/pull/21657

Hey @ShrootBuck, thanks for the report! Confirming what @vikaspotluri123 said, we've had multiple reports of this issue and it has now been fixed in https://github.com/TryGhost/Ghost/pull/21657. The fix will be part of the next Ghost release, planned for Friday 22, Nov 2024

ah ok, my bad


Set CWD to the current file's directory to pick up configs

Set CWD to the current file's directory to pick up configs
ocp-indent looks for .ocp-indent in the current directory and
ancestors, so this will cause configuration to be picked up
correctly:
https://www.typerex.org/ocp-indent.html#configuration-file

Note: My first stab at this set CWD to the current project, but since ocp-indent automatically looks up the directory chain, setting it to the current file's folder is better.