fix: add Gatsby theme New Relic global nav to Open Source site mobile views (#556)

These changes should address: https://github.com/newrelic/opensource-website/issues/556
The global nav should now mirror the experience on https://developer.newrelic.com/ as requested in the bug ticket.
I can see the global Gatsby theme nav was disabled on mobile views and set to be static rather than sticky. I caught and resolved a couple complications from removing the mobile display: none rule, but it's worth some manual exploration to confirm there aren't regressions I didn't clock.
Notes

My changes in 16f614f modify some styles that link back to changes in https://github.com/newrelic/opensource-website/commit/637f7e09d307757a2ea3fe35e0cac1e5642fc203, which I'm not familiar with. Might be worth someone close to that work giving this MR's changes a glance

I added a z-index for the GlobalHeader that hopefully matches the repo’s convention (10, 100, 1000, etc.) I went with the highest I could find, but in looking it up, I'm not 100% convinced that .iframe-container class (where I grabbed the z-index: 1000000 value from) is being used. Still went with it to be better safe than sorry. Without the z-index a number of the homepage elements will display at a higher layer than the GlobalHeader.

While working on this, I noticed and raised an issue that should be addressed on the Gatsby theme repo: https://github.com/newrelic/gatsby-theme-newrelic/issues/79

Hm, a bit stumped by the Jest check failing.
I pushed 7ff7b7f to update the snapshots, and run run test passes all tests on my local branch.

Hey @tyreer thanks for getting to this! Once we merge https://github.com/newrelic/gatsby-theme-newrelic/pull/78, I'd love to have you update this PR to use the latest version of the gatsby theme which should also address the mobile view.
That position: static was a temporary adjustment on my part 😅 so glad to see you add a proper fix for its UX! As always, thanks so much for the contribution!

Sounds like a plan @jerelmiller. Figured it might make sense to get the Gatsby fix in first, so thanks for hammering that out!
I'll keep an eye on https://github.com/newrelic/gatsby-theme-newrelic/pull/78 and update this PR once the dependency update is published for @newrelic/gatsby-theme-newrelic

@tyreer the PR has been merged and a v1.7.0 of the Gatsby theme has been published!

@jerelmiller Pulled in the the new Gatsby theme and the GlobalHeader is looking great!
BUT, the Jest tests have been thrown off 😐
Getting the error below tracing back the GlobalHeader being rendered via TestRenderer.
Warning: An invalid container has been provided. This may indicate that another renderer is being used in addition to the test renderer. (For example, ReactDOM.createPortal inside of a ReactTestRenderer tree.) This is not supported.

Might be related to react-test-renderer attempting to go beyond a shallow render?

This comes up pretty quick in troubleshooting: https://github.com/facebook/react/issues/11565.
And React team's response doesn't seem to point to a fix being implemented beyond the warning we're seeing if I'm following that issue correctly:

The test renderer was kind of intended to not be used with deep dependents.

I tried some of the ReactDOM.createPortal mocks mentioned in that issue, but it didn't get me far.
Have you encountered similar Jest errors before?

Interesting. I think this error was obscured from us because there was some logic in versions < 1.7 that hid the overlay (which uses portals) in tests during render. The snapshot tests must not have been rendering the overlay until v1.7.
Apparently I have not done much testing using Portals in react-test-renderer because I was unaware this was an issue. Out of curiosity, what issues were you running into trying to address the error using the suggested fixes?

@tyreer by chance are you seeing issues with a @keyframes syntax error?
If so, I think I spotted something odd in the gatsby theme that might be causing this issue that I'd like to fix.

I've opened a PR in the Gatsby theme repo that should address the jest issue you are seeing. Turns out we were including styles from @elastic/search-ui that included keyframes, which emotion does not seem to like while trying to serialize styles. You should be able to mock the Portal successfully now 🤞

Thanks for pointing out the changes on the Gatsby theme. Nice addition to the docs there. I'll consult once that PR goes through.

I think this error was obscured from us because there was some logic in versions < 1.7 that hid the overlay (which uses portals) in tests during render.

Yeah, seems sensible to me. I tried bringing in the new Gatsby theme into the developer-website repo just to see if its tets had a hard time as well, but it had no effect on those test runs, which look more unit-test focused than this repo's snapshot tests. Makes me think the snapshots here had just never been tasked with rendering that way

Out of curiosity, what issues were you running into trying to address the error using the suggested fixes?

They just didn't have any effect. Same local Jest run errors with or without them.

@keyframes syntax error?

None to speak of. I'm getting the same errors locally as in the run on this PR https://github.com/newrelic/opensource-website/pull/608/checks?check_run_id=994942678
I'll keep an eye on https://github.com/newrelic/gatsby-theme-newrelic/pull/81 and circle back once that's through. Cheers!

v1.7.1 has just been published. 🤞 that PR will address the testing issues you have been experiencing on this branch.

I'm getting the same errors locally as in the run on this PR

I added a new section on Testing to the Gatsby theme. I believe the transformIgnorePatterns is already configured properly, but you should have better luck mocking the createPortal API to address the issues in the snapshot test.
I added a snapshot test for the global header in that PR to confirm that snapshot tests work correctly and they passed ok.
Let me know if you have other issues here! I'd love to get this one out. Thanks for being patient and helping us uncover other issues that needed addressing!

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: tyreer:x: Robert TyreeRobert Tyree seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hiya @jerelmiller 👋
I've pulled in v1.7.1 but haven't had any luck with the mocking.
I set up a __mocks__/react-dom.js file with the createPortal override as suggested here.
But I'm unclear how to apply that override in a given test. How would it be implemented in a spec.js file?
Alternately, I again tried following the approaches for these 2 suggestions on the React repo issue, but to no effect:

https://github.com/facebook/react/issues/11565#issuecomment-380143358
https://github.com/facebook/react/issues/11565#issuecomment-348555899

I wonder if the override makes it down to Overlay? Since @newrelic/gatsby-theme-newrelic has its own defined dependencies, I wonder if the react-dom from the Gatsby theme is unaffected by the mock override of createPortal. Totally speculating! I might just be mocking ineffectively. 🤷♂
Thanks for working with me on this! Hope it isn't turning into more than you bargained for. 😄

Another point I've noticed that I'm unsure how best to tackle: the Overlay has a z-index: 100, but this repo has a good number of elements above that layer.
As mentioned in the PR description, I've put GlobalHeader at z-index: 1000000 following the repo's convention. The .primary-header-logo is at 10000. Both of which overlap the Overlay when you click search:

In all, I'm seeing 17 rules with z-index at or above 100. I suppose they all could be lowered down bellow 100, but that's a bit of a task. Setting Overlay to a level higher than any of those in this codebase could feels peak z-index wars. But perhaps this isn't the only codebase where the issue will come up?
Any sense of a preferred approach to z-index fun between the two repos?

Any sense of a preferred approach to z-index fun between the two repos?

@danielgolden @djsauble This is a really good question from @tyreer. Do we have a preferred approach to z-indexes? I think we just kinda picked one out-of-the-hat in the theme, but clearly we've got issues with other elements overlapping. Could you provide some feedback here?

I wonder if the override makes it down to Overlay?

I thought so since jest should use the mock whenever import ... from 'react-dom' is used.

But I'm unclear how to apply that override in a given test. How would it be implemented in a spec.js file?

You shouldn't need to do anything special in the spec file. The __mocks__ convention uses a special feature of jest (manual mocks) that allow you to mock entire dependencies. This means any import from react-dom should use the mock instead of the actual dependency implemenetation.
I might try the upgrade + some different ideas in a separate branch to get a better feel. Perhaps the test in the theme repo was a misnomer since its mocking react-dom in the repo itself and maybe that gave me a false sense of hope 😅 . The jest mocking is super cool, but I've always been a bit hazy on details for when it kicks in and when it doesn't, especially for dependencies of dependencies in node_modules.
Thanks so much for being patient! We'll get this one way or another 💪

@tyreer @jerelmiller Good catch on the z-index! The overlay should trump both the logo and global header, but you're right that we don't want an escalating z-index war. I suggest we cap the z-index scale to 1000, hopefully that's high enough to fix the overlay issue without resorting to a major refactor though we may want to do that eventually for consistency.

@tyreer I opened a draft PR to try and isolate the tests to ensure there wasn't anything else at play. From that branch, it looks like I'm able to get the tests run successfully.
Can you try out the changes in that PR (just re-implement them here) and see if that works? If not, I'd love it if you could paste the output from one of the failures to see if we spot anything else at play.

I suggest we cap the z-index scale to 1000

Sounds sensible to me @djsauble
So we'd say the Overlay in the Gatsby theme would change to have z-index: 1000, correct?
This repo has 6 layers. Any preference between the two options below for a refactor? I think option B is cleaner, personally.
Option A

Current z-index
New z-index

1
1

10
10

100
100

1000
200

10000
300

100000
400

Option B

Current z-index
New z-index

1
100

10
200

100
300

1000
400

10000
500

100000
600

@tyreer I'm a sucker for linear scales, Option B looks great. 🙂

Right on. I think c4145ac does the trick @djsauble.
We just need the Gatsby theme to publish Overlay at z-index: 1000 and we should be good to go. Adjusting Overlay to 1000 locally in DevTools looks real nice.

I can get a quick PR to adjust the overlay z-index. In the mean time, I see no reason not to accept this PR. Thanks so much for working through this!

Thanks for all the time and effort you put into this PR, @tyreer!! We really appreciate it :)

You're welcome @danielgolden ! Glad we were able to sort out the curve balls and happy I could help out 😃


Qt: Fix startup settings

Windows
Rename from Bitcoin.lnk to XPChain.lnk
This is effect to taskbar title
Linux
Rename from xpchain-testnet.lnk to xpchain-testnet.desktop (like mainnet)
Change bitcoin to xpchain in content.

Tested on regtest. Enable Start XPChain Core on system login then open shell:startup on Windows Explorer.
Before:

After:

The shortcut name has been changed from Bitcoin to XPChain. Looks fine, thank you!


Problem with connecting to remote repository

I use spring-contract version 1.2.0.RELEASE.
There is no option to overwrite username and password for remote repository using StubRunnerRule class. There is a method to set options but this method will not copy all the options but only some of them.
Example usage:
private StubRunnerOptions options = new StubRunnerOptionsBuilder()
			.withPassword("pass")
			.withUsername("username")
			.withPort(8100)
			.withStubRepositoryRoot("http://url-to-nexus.com/content/repositories/public")
			.withWorkOffline(false)
			.build();

	@Rule
	public StubRunnerRule stubRunnerRule = new StubRunnerRule()
		.options(options);

Method options() looks like that:
@Override public StubRunnerRule options(StubRunnerOptions stubRunnerOptions) {
		builder().withOptions(stubRunnerOptions);
		return this.delegate;
	}

and method withOptions looks like that
public StubRunnerOptionsBuilder withOptions(StubRunnerOptions options) {
		this.minPortValue = options.minPortValue;
		this.maxPortValue = options.maxPortValue;
		this.stubRepositoryRoot = options.stubRepositoryRoot;
		this.workOffline = options.workOffline;
		this.stubsClassifier = options.stubsClassifier;
		return this;
	}

Only some of the fields are copied from passed options parameter. This is a little bit confused.
I see that by default values for username and password are taken from system properties. Would be good to have an option to overwrite these values if needed.
Even if I set system properties:
stubrunner.password=pass
stubrunner.username=username

they are ignored.

If I use @AutoConfigureStubRunner annotation instead StubRunnerRule then it works.
Code sniped:
@AutoConfigureStubRunner(repositoryRoot = "http://url-to-nexus.com/content/repositories/public",
						 ids = "com.example:contract-rest-service:+:8100")
public class ContractRestClientApplicationTest {

	@BeforeClass
	public static void beforeClass() {
		System.setProperty("stubrunner.username", "username");
		System.setProperty("stubrunner.password", "password");
	}

	@Test
	public void get_person_from_service_contract() {
		// ...
	}

Please always test against the latest version for the same minor. The options method got fixed in the meantime:
https://github.com/spring-cloud/spring-cloud-contract/blob/v1.2.2.RELEASE/spring-cloud-contract-stub-runner/src/main/java/org/springframework/cloud/contract/stubrunner/StubRunnerOptionsBuilder.java#L106-L123
public StubRunnerOptionsBuilder withOptions(StubRunnerOptions options) {
		this.minPortValue = options.minPortValue;
		this.maxPortValue = options.maxPortValue;
		this.stubRepositoryRoot = options.stubRepositoryRoot;
		this.workOffline = options.workOffline;
		this.stubsClassifier = options.stubsClassifier;
		this.username = options.username;
		this.password = options.password;
		this.stubRunnerProxyOptions = options.getStubRunnerProxyOptions();
		this.stubsPerConsumer = options.isStubsPerConsumer();
		this.consumerName = options.getConsumerName();
		this.mappingsOutputFolder = options.getMappingsOutputFolder();
		this.stubConfigurations = options.dependencies != null ?
				options.dependencies : new ArrayList<StubConfiguration>();
		this.stubIdsToPortMapping = options.stubIdsToPortMapping != null ?
				options.stubIdsToPortMapping : new LinkedHashMap<StubConfiguration, Integer>();
		return this;
	}

Thanks and sorry @marcingrzejszczak. I used example https://github.com/spring-guides/gs-contract-rest for testing and didn't check version.


Problem importing .hom file on Apple mobile devices

[I thought I had already created this issue but now I can't find it. Apologies if this is a duplicate.]
Chris Heunen writes: "when I save one of the .hom example files on an ipad (so in iOS), homotopy.io nor beta.homotopy.io wants to import it. I can see the file but it's grayed out so can't select it. Probably a silly ui bug but crippling. :)"

I've noticed this too, not sure why it isn't working.

Think we need to add the correct mime type here
https://github.com/homotopy-io/homotopy-rs/blob/355ca30f17e4de27ab1b692e9998dd06599b4efd/homotopy-web/src/app/project.rs#L57
I think application/octet-stream should do the job.

Fixed by f8290de0f936a7f1b8b2849ef2c3e1cc14477008, thanks Chiara!


Fix broken links in faq

Fixes #4919
This PR fixes two broken links present at https://getmdl.io/faq/index.html#individual-components

@googlebot I signed it!


[SPARK-31529][SQL][3.0] Remove extra whitespaces in formatted explain

What changes were proposed in this pull request?

Remove all the extra whitespaces in the formatted explain.
Why are the changes needed?

The number of extra whitespaces of the formatted explain becomes different between master and branch-3.0. This causes a problem that whenever we backport formatted explain related tests from master to branch-3.0, it will fail branch-3.0. Besides, extra whitespaces are always disallowed in Spark. Thus, we should remove them as possible as we can.
Does this PR introduce any user-facing change?

No, formatted explain is newly added in Spark 3.0.
How was this patch tested?

Updated sql query tests.

cc @cloud-fan

Test build #121888 has started for PR 28364 at commit d993c39.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/26560/
Test PASSed.

Test build #121888 has finished for PR 28364 at commit d993c39.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/121888/
Test PASSed.

thanks, merging to 3.0!


Repeated incoming messages when paused in debugger

Is it a special feature in WeChat? Please clarify in document.
Will we filter these repeated messages in adapter?

yes, when you pause process in debugger, WeChat can't get response in 5 second, then WeChat will disconnect and retry by itself.


Add dns updates

Given a provisioned cluster
When a I check dns for FOO.GITHUBUSER.sharing.io
Then resolution for A records will hit the provisioned cluster.

Support for updating Route53 sharing.io domain with:

USER.pair.sharing.io NS ns1.USER.pair.sharing.io
ns1.USER.pair.sharing.io A CLUSTER.FLOATING.IP.INGRESS
PowerDNS deploy to cluster
external-dns deployed cluster
Managing USER.pair.sharing.io records within the cluster

https://github.com/sharingio/pair/commit/eb3eb30b8713c52490e9c3432accd927ae2caecd


[RHDM-671] Rename to AUTH_LDAP_

Signed-off-by: Ruben Romero Montes<EMAIL_ADDRESS>Fix https://issues.jboss.org/browse/RHDM-671

@errantepiphany @spolti Should I add it also to any template?

@ruromero @spolti Let's wait in adding it to RHDM templates until we finalize how they are (or are not) included in the RHPAM templates.


Fix the fact that only first page of cut trees are visible

When a tree is cut in more than one page (because is long), only the
first page has the real root node of this tree. But for the others pages
we still want to display the nodes, so treat the less deep node as the
"current relative root" node.

Closing - this app is deprecated as https://github.com/mbraak/django-mptt-admin does the same thing in a better way.


new API and other changes

just in case you haven't started on the new API, you could look this over.
list of all changes:

ops can't use explosives (I found they aren't the most responsible with it)  - 'my change' commit
flamelash/orb of light are no longer checked for projectile spam (personal preference) - 'my change' commit
I removed the variable 'isEnabled' (didn't see the point since the hooks aren't executed when disabled?? i think it isn't.. gotta double check that)  - 'update to new API' commit
change to the new API for various things - 'update to new API' commit

I won't be offended if you don't merge this because of the 'my change' commit.. but at least I provided some help in the upgrade process if you haven't done it already... if you have, then just ignore my programming spree; I'm still glad I decided to do this because I learned more about TDSM and I thought I'd share it with you :)

I had started moving it over to the new API, but then I decided this was the perfect time to rewrite it from scratch. Unfortunately, I've also been rather busy, so haven't got around to finishing it yet. If build 36 is released before I get it finished, feel free to post your version in my thread. :)
I'll take a look through the changes, thanks. :)

Your welcome. It's what github is all about :)


pipx install eth-brownie , causing error

Discussed in https://github.com/smartcontractkit/full-blockchain-solidity-course-py/discussions/1162

Originally posted by km123abca February 26, 2022
pipx install eth-brownie  is causing an error. The end of the error stack is as follows
\lib\encodings\cp1252.py", line 19, in encode
return codecs.charmap_encode(input,self.errors,encoding_table)[0]
UnicodeEncodeError: 'charmap' codec can't encode character '\u2502' in position 559: character maps to
How do I resolve this? Please help

Hi, exactly i dont know.
But try upgrading your python to python3.
Someone has answered it before.
https://github.com/llSourcell/twitter_sentiment_challenge/issues/1#issuecomment-298864832

i tried to do that, and i cant install python demo.py


⚠ Minecraft has degraded performance

In 1c86d63, Minecraft (https://www.minecraft.net) experienced degraded performance:

HTTP code: 200
Response time: 770 ms

Resolved: Minecraft performance has improved in 9099584.


unclear RenderFragment static method

in the example with this code:
public static RenderFragment SayHello = __builder =>

it's not mentioned that this code has to be in a razor file, it can't be in a .cs file.
and also this razor code can't have any EventCallbacks, as mentioned here:
https://github.com/dotnet/roslyn/issues/58577#issuecomment-997850629

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a29eb861-e8eb-e54c-b441-e1f14d7e6a7f
Version Independent ID: 40361d5d-c806-9c9b-c7f7-ad317a06bb4f
Content: ASP.NET Core Blazor performance best practices
Content Source: aspnetcore/blazor/performance.md
Product: aspnet-core
Technology: aspnetcore-blazor
GitHub Login: @pranavkm
Microsoft Alias: riande

🍂 OOF for the holidays 🍂
This issue has been marked for triage on the Blazor.Docs project, and I'll respond as soon as I return in 2022. I'll be back working on issues around Wednesday, Jan. 5. It will take a little while to dig out ⛰⛏ from holiday issues. I'll get back to you ASAP 🏃.
We only work on documentation on this repo. If you need product support, close this issue and seek assistance through one or more of the following support channels:

Stack Overflow (tagged: blazor)
General ASP.NET Core Slack Team
Blazor Gitter

If you think that you found a potential bug in the framework or have product feedback, close this issue and open a new issue for the ASP.NET Core product unit at dotnet/aspnetcore issues. Bug reports require a clear explanation of the problem, usually including a minimal repro project placed on GitHub for the product unit engineers to download and run. If you determine with the product unit that it isn't a bug but merely requires documentation, please re-open this docs issue and place a cross-link to your engineering issue discussion. I'll take it up with you when I return from vacation.
For problems or feedback on Visual Studio or Visual Studio for Mac, close this issue and use the Report a Problem or Suggest a Feature processes from within VS, which open internal issues for VS teams. For more information, see Visual Studio Feedback or How to report a problem in Visual Studio for Mac.
For problems with Visual Studio Code, close this issue and ask for support on community support forums. For bug reports and product feedback, open an issue on the microsoft/vscode GitHub repo.
💃🕺🥳 Happy New Year! 🎈🎆🍾🥂🎉 See you in 2022!


Make the table navigation stay on the last page of the Event Participant table

Currently, after a user reaches the last page of the Event Participant table the option to go to previous pages disappears and the user has to either reload the page or leave it and come back. Make sure the table navigation does not disappear on the last page of the Event Participation table. Also, while you are there, make the footer not cover half of the save button when there is a full list.
Table navigation on page 1:

Table navigation on page 2:

Table navigation on the last page:

 Make the table navigation stay on the last page of the Event Participant table #764


Allow ignoring certain paths

I have a git repo with millions of lines of vendored go code. The vendor directory should be ignored in the analysis. Right now the first 1000 commits were processed in 12 minutes but I have 15000 commits, so the whole thing will take many hours to finish without the ability to ignore the vendor directory. #2 would also help with this

Hi, sorry about taking so long to reply. I hadn't realized Github wasn't notifying me about this repository.
If not every file in your repository should be considered, you can create a configuration file for it to define which files are your sources. If your vendor directory is clearly separated, then an appropriate setting of sourceFiles in the configuration file is probably enough to avoid it. And if not, you should be able to avoid it by adding it to the excludedSourceFiles.
I hope this helps, in case you're still interested.

Thanks! I tried excluding every file (by accident) and it was going at 1000 commits per minute. After including the relevant files, it's still very slow right now at only 300 commits per minute and it seems to slow down as the codebase grows over time. Even with the vendor directory ignored, processing the first 1000 commits is taking 4:40 mins. I'll keep it running for a few hours, but I'm not very hopeful that it will get very far because it's slowing down so fast. What's the biggest codebase this tool has been used on?

14 hours later, it's still going and it's going at 3 minutes per 20 commits.

It took 28 hours. The DB is 158 MB. I realized that I forgot to ignore one big auto-generated file, so the results were useless 😭

Thanks for the report and your patience! The commit processing speed should depend only on the size of the commit (number of files, sizes of files), not on the number of commits that have been processed. But this is maybe not correct, since I'm also seeing the processing time slowing down with later commits. I will need to look into this more, and I opened issue #26 to track it.
The largest repository (or actually group of repositories) I've tried had a total of 33000 commits, about 250000 source lines in total. Processing time for that was about 12 hours, but that was with the first released version. I think some of the work I've done since may have slowed down the processing but probably only by something like 10-20% at most. Also, that original run was with Postgres instead of SQLite in case that matters (it probably shouldn't).
I did get an idea now for a possible improvement to the commit processing time, tracked in issue #24 . And your last problem of forgetting something in the source configuration is now issue #25 . Sorry about what happened.

Wow! Thanks for responding to all these issues. I know this is a toy project so it's very much appreciated. I'm kicking off another run with the generated files ignored. I'll check up on it on Monday. I think we can close this issue though since files ARE being ignored as they should be.

With the giant generated files removed, it took only 10h!

Wow, that's quite a speedup! That big file must have been changing often.


[SPARK-26761][SQL][R] Vectorized R gapply() and gapplyCollect() implementation

What changes were proposed in this pull request?
This PR targets to add vectorized gapply() in R, Arrow optimization.
This can be tested as below:
$ ./bin/sparkR --conf spark.sql.execution.arrow.enabled=true

df <- createDataFrame(mtcars)
collect(gapply(df,
               "gear",
               function(key, group) {
                 data.frame(gear = key[[1]], disp = mean(group$disp) > group$disp)
               },
               structType("gear double, disp boolean")))

Requirements

R 3.5.x
Arrow package 0.12+Rscript -e<EMAIL_ADDRESS>subdir = "r")'

Note: currently, Arrow R package is not in CRAN. Please take a look at ARROW-3204.
Note: currently, Arrow R package seems not supporting Windows. Please take a look at ARROW-3204.
Benchmarks
Shall
sync && sudo purge
./bin/sparkR --conf spark.sql.execution.arrow.enabled=false

sync && sudo purge
./bin/sparkR --conf spark.sql.execution.arrow.enabled=true

R code
rdf <- read.csv("500000.csv")
rdf <- rdf[, c("Month.of.Joining", "Weight.in.Kgs.")]  # We're only interested in the key and values to calculate.
df <- cache(createDataFrame(rdf))
count(df)

test <- function() {
  options(digits.secs = 6) # milliseconds
  start.time <- Sys.time()
  count(gapply(df,
               "Month_of_Joining",
               function(key, group) {
                 data.frame(Month_of_Joining = key[[1]], Weight_in_Kgs_ = mean(group$Weight_in_Kgs_) > group$Weight_in_Kgs_)
               },
               structType("Month_of_Joining integer, Weight_in_Kgs_ boolean")))
  end.time <- Sys.time()
  time.taken <- end.time - start.time
  print(time.taken)
}

test()

Data (350 MB):
object.size(read.csv("500000.csv"))
350379504 bytes

"500000 Records"  http://eforexcel.com/wp/downloads-16-sample-csv-files-data-sets-for-testing/
Results
Time difference of 35.67459 secs

Time difference of 4.301399 secs

The performance improvement was around 829%.
Note that I am 100% sure this PR improves more then 829% because I gave up testing it with non-Arrow optimization because it took super super super long when the data size becomes bigger.
Limitations
For now, Arrow optimization with R does not support when the data is raw, and when user explicitly gives float type in the schema. They produce corrupt values.
How was this patch tested?
Unit tests were added
TODOs:

[x] Draft codes
[x] make the tests passed
[x] make the CRAN check pass
[x] Performance measurement
[x] Supportability investigation (for instance types)

Test build #102095 has started for PR 23746 at commit abbc2af.

I keep forgetting which branch I was working on ... :( . Let me leave the PR open and work here.
Let me leave cc @BryanCutler, @viirya, @felixcheung anyway.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7753/
Test PASSed.

Test build #102095 has finished for PR 23746 at commit abbc2af.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
case class FlatMapGroupsInRWithArrow(
case class FlatMapGroupsInRWithArrowExec(
class ArrowRRunner(

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102095/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7773/
Test PASSed.

Test build #102118 has started for PR 23746 at commit 6572513.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7774/
Test PASSed.

Test build #102119 has started for PR 23746 at commit 0e7f25b.

Hey guys, I am sure it's ready. Adding more people @rxin, @gatorsmile, @shivaram, @falaki for visibility.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7775/
Test PASSed.

I'll start dapply once this one gets merged. I think codes can be shared.

Test build #102123 has started for PR 23746 at commit 0d425c8.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7776/
Test PASSed.

Test build #102125 has started for PR 23746 at commit bf63650.

Test build #102118 has finished for PR 23746 at commit 6572513.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102118/
Test FAILed.

Test build #102119 has finished for PR 23746 at commit 0e7f25b.

This patch fails SparkR unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102119/
Test FAILed.

All tests passed except CRAN. I'm gonna take a look and fix soon.

Test build #102123 has finished for PR 23746 at commit 0d425c8.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102123/
Test FAILed.

Test build #102125 has finished for PR 23746 at commit bf63650.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102125/
Test FAILed.

Test build #102139 has started for PR 23746 at commit e566807.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7785/
Test PASSed.

Test build #102140 has started for PR 23746 at commit f9673c5.

Test build #102140 has finished for PR 23746 at commit f9673c5.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Test build #102139 has finished for PR 23746 at commit e566807.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

retest this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102140/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102139/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7786/
Test PASSed.

Test build #102142 has started for PR 23746 at commit f9673c5.

Test build #102142 has finished for PR 23746 at commit f9673c5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102142/
Test PASSed.

Test build #102171 has started for PR 23746 at commit 3b619f2.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7797/
Test PASSed.

Test build #102171 has finished for PR 23746 at commit 3b619f2.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102171/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7809/
Test PASSed.

Test build #102192 has started for PR 23746 at commit 3b619f2.

Test build #102192 has finished for PR 23746 at commit 3b619f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102192/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7819/
Test PASSed.

Test build #102204 has started for PR 23746 at commit 3b619f2.

Test build #102204 has finished for PR 23746 at commit 3b619f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102204/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7836/
Test PASSed.

Test build #102226 has started for PR 23746 at commit 3b619f2.

Test build #102226 has finished for PR 23746 at commit 3b619f2.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102226/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7843/
Test PASSed.

Test build #102233 has started for PR 23746 at commit 3b619f2.

Test build #102233 has finished for PR 23746 at commit 3b619f2.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102233/
Test FAILed.

All the test failures look unrelated.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7847/
Test PASSed.

Test build #102237 has started for PR 23746 at commit 3b619f2.

Test build #102239 has started for PR 23746 at commit 785391a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7849/
Test PASSed.

what about https://github.com/apache/spark/commit/e8982ca7ad94e98d907babf2d6f1068b7cd064c6#diff-b11442485f6b77bf47b58b4747321638R267 can this be changed from file to stream also?

Test build #102241 has started for PR 23746 at commit f24086e.

what about e8982ca#diff-b11442485f6b77bf47b58b4747321638R267 can this be changed from file to stream also?

Yes.. it actually used file on purpose actually.... if I use a file to transfer the data (instead of socket), I can send batch by batch in a streaming matter but if I use socket, I should buffer all the batches and then send them at once due to the Arrow R API limitation (ARROW-4512).
I used file there because the existing protocol at R DataFrame -> Spark DataFrame was already using a file .. but looks all other protocol are using sockets. So, I had to use socket here to match the protocol although I have to buffer all the batches due to Arrow R API limitation.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7851/
Test PASSed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7856/
Test PASSed.

Test build #102247 has started for PR 23746 at commit 1bb3d52.

Test build #102248 has started for PR 23746 at commit 2559d7a.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/7857/
Test PASSed.

Test build #102237 has finished for PR 23746 at commit 3b619f2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102237/
Test PASSed.

Test build #102239 has finished for PR 23746 at commit 785391a.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102239/
Test PASSed.

Test build #102241 has finished for PR 23746 at commit f24086e.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102241/
Test PASSed.

Test build #102248 has finished for PR 23746 at commit 2559d7a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102248/
Test FAILed.

Test build #102247 has finished for PR 23746 at commit 1bb3d52.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/102247/
Test PASSed.

actually I think file is "problematic" if you remember some problem from the last few months. if we can do streaming we should do that across R & python too, for data.frame or toPandas @BryanCutler FYI

Thanks, Felix. I'm going to work on related changes like dapply, gapplyCollect, dapplyCollect as well. I will double check it for stringsAsFactors.
I am merging this to unblock other vectorized API works. Considering Arrow API is not installed in Jenkins, and the current tests all passes, I assume it doesn't harm to existing use cases.

Merged to master.

BTW, I am also going to document that this arrow optimization should be unstable, experimental and technical preview, and It's discouraged to be used in production for now later when I finish this jobs.

I updated benchmark with bigger data that shows perf diff more clearly.


Update NodeBalancer connections chart color

Purpose
Make NodeBalancer chart connection color purple.

Coverage remained the same at 28.851% when pulling cf40b7d61b88d294aab89da6d763251e42c40c58 on rjstires:M3-667 into 138c5b75407adf501d09c6afd89eef1fdf396a77 on linode:develop.


angularCompilerOptions isn't honored when coming in from an extended tsconfig

Bug Report or Feature Request (mark with an x)
- [x ] bug report -> please search issues before submitting
- [ ] feature request

Versions.

"@ngtools/webpack": "1.8.0"
Repro steps.

I have a base tsconfig.json and include that via "extends" in the tsconfig that is put into the configuration object for the AngularCompilerPlugin.
I try to configure the "preserveWhitespaces": false feature with a angularCompilerOptions section.
When I put that section in the base tsconfig, nothing in the output changes. When I put it into the extending tsconfig, the resulting bundle gets the expected shrinkage.
The log given by the failure.

There's no failure, just no effect.
Desired functionality.

The Angular 5 release blog post says:

We’re also updating the way we use tsconfig.json files to follow TypeScript standards more strictly

Properly handling "extends" seems to be a gap.
Mention any other details that might be useful.

I also had to put "angularCompilerOptions": {         "preserveWhitespaces": false     } in tsconfig.app.json to get the option to work.

Same experience for me as well. I had to add the following preserveWhitespaces config to both the root tsconfig.json and tsconfig.app.json in order to witness a file size difference. (I also added to my tsconfig.spec.json to ensure that unit tests are identical):
"angularCompilerOptions": {
  "preserveWhitespaces": false
},

+1

I just stumbled upon the same thing. I think it's fine if this is TypeScript specific issue but maybe angular-cli could show a warning message when the parent tsconfig.json contains options that aren't inherited.

Hi, any news?

As indicated above, this is a TypeScript issue.  If this is important to your project, please consider opening an issue with the TypeScript project.


Remove old code and add formatting

Change description

removed code that is labelled as old or todo as it is not necessary and is sacrificing readability. code that was/is "todo" should not be committed. This is why version control exists. By removing, the code is still retrievable if useful but is not causing a mess on our main branch.
add formatting

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[x] No

The runbooks have been taken out for now to prevent shutdown. They will need to go back in some form later. Either rename back or delete.

kept runbook.tf2, renamed to runbook_dg.tftodo


Deadlocks starting runs when ENABLE_VP is true

Here's an example message:
Error: db query failed: deadlock detected position=undefined text="INSERT INTO machines_t (\"id\", \"username\", \"hostname\", \"totalResources\", \"state\", \"idleSince\", \"permanent\") VALUES ($1, $2, $3, $4, $5, $6, $7) \n        ON CONFLICT (\"id\") DO UPDATE SET \"id\" = $8, \"username\" = $9, \"hostname\" = $10, \"totalResources\" = $11, \"state\" = $12, \"idleSince\" = $13, \"permanent\" = $14" values=...

DMed you


Cilium operator service account is missing node read permissions

This PR:

allows the cilium-operator service account to read the  nodes resource from the k8s api.

Checklist

[x] Update changelog in CHANGELOG.md.
[x] Make sure values.yaml and values.schema.json are valid.

I'm checking one of my workload clusters and this doesn't seem to be required. The operator is not complaining, and the ClusterRole already has permissions to list Nodes.

I'm checking one of my workload clusters and this doesn't seem to be required. The operator is not complaining, and the ClusterRole already has permissions to list Nodes.

As per our Slack discussion this seems to be affecting version 0.4.2 of the Cilium App but not the latest version.
So this PR does not seem to be needed anymore


GRPC-Web occasionally not sending responses back to clients

GRPC-Web connections occasionally get in to a broken state
First things first, this environment is running Istio 1.9.6 with Envoy version 172db4cfdf037bc8cf1613969f94c25b6198bc4f/1.17.1/Clean/RELEASE/BoringSSL
Occasionally an Envoy sidecar seems to get in to a state where it will silently (?) drop GRPC-Web responses instead of sending the GRPC -> HTTP/2 responses back to the client/browser. We are still not a 100% sure that this issue sits with Envoy, as it could be an issue with the upstream, but we haven't been able to narrow it down more than this. Figured it'd be worth filing an issue to see if we can narrow it down further.
The symptoms are that the browser is just continuously trying to send messages every 10 seconds and timing out. On our application side (Go GRPC server) we are getting context cancelled errors when we are trying to send messages on the "broken" GRPC stream AFTER ~10 seconds, when the browser closes the connection. Before this the GRPC Server is happily sending messages on the stream, they're just not getting to the client/browser.
The high-level architecture is this:
Browser -> Istio Ingress (Envoy) -> Sidecar (Envoy) -> Go GRPC server
We only run ONE replica of the Go GRPC server, so all GRPC-Web connections go to this one server.
We have not been able to reliably reproduce this yet. This happens maybe 4-5 times in a week in our fairly low-traffic development environment, but more frequently in the production environment, but we are having issues tracking this issue, so unsure how frequent it is. Our solution to capture information in our development environment has been to turn everything to Debug and analyse everything for a week.
The browser side
We first figured this would be a GRPC-Web browser-side issue, so started capturing information there.
We managed to capture some netlog from a Chrome browser that was in this "broken" state. The "broken" state is on the left and a normal successful connection on the right as comparison:

As you can see it never receives any data after it receives the headers from Envoy/server, where as in the successful one it immediately receives data after the headers.
When a browser gets in to this state, you can to completely restart it or do some kind of hard refresh. Just refreshing the page doesn't seem to help.
The Envoy side
The Envoy Access logs and Debug logs didn't show anything obvious, as Envoy (correctly) thinks these connections have been gracefully and correctly closed. So everything is 200 / 0 with no error flags.
However, if we filter on any connection that lives for about 10 seconds, we can see a pattern. This also revealed that specific Connection IDs seem to have the issue.
For example if connection ID C150 has the issue and 2 different clients/browsers are connection through this connection ID, they will both have their responses from the Go GRPC server dropped.

This is not the best evidence, but on the left is the Envoy Stream Reset messages from the "broken" connection ID in one of the timespans that had the issue, and on the right is the Go GRPC server context cancelled messages, all with a duration of ~12,000 milliseconds. The extra 2 seconds is because of the healthcheck message being sent every 4 seconds, so doesn't catch the stream closing at 10 seconds, but instead notices at 12 seconds when it tries to send on the stream.
Since we can't easily reproduce this I haven't been able to run this with Envoy at a trace level yet, but I will try to set it to trace as soon as we identify the issue happening again.
Let me know what else I can provide here, or any potential workarounds as this is affecting us in production right now.

To add some information to this, we just observed the same issue with a NodeJS application running in an AWS Lambda.
This would further point towards Envoy being the issue here. The NodeJS application has a 30 second timeout, and the Go GRPC server deemed the connection "healthy" for 30 seconds until the NodeJS client closed it because of timeout since it wasn't receiving any data from the Go server after the initial headers.

Please test with a more recent version of Envoy. 1.17.1 is quite old and it's possible whatever issue this is has been fixed.

We upgraded to 1.19.0 a day ago and I will report back.

We upgraded to 1.19.0 a day ago and I will report back.

Cool, thanks. We will debug further if it still repros.

We upgraded to 1.19.0 a day ago and I will report back.

Cool, thanks. We will debug further if it still repros.

This is occurring right now on a connection to a 1.19 Envoy. I've enabled Trace-level logs trying to collect as much as I can.

I'm collecting a lot of logs, but nothing obvious is standing out to me, and at some point we will have more noise than signal :(

Unfortunately I'm not sure. My guess is some type of bug within the grpc-web filter but it's hard to say.
cc @alyssawilk @markdroth do you know if there is anyone on the gRPC team that would be willing to help debug this?

@wenbozhu, can you find someone to help out with this grpc-web issue?

we just observed the same issue with a NodeJS application running in an AWS Lambda.

I assume that the NodeJS application talks to Envoy via grpc (v.s. grpc-web). If so, the bug shouldn't be in the grpc-web filter?

No, it's a browser talking through Envoy to a Go and NodeJS backend. The fact that it's happening for both a NodeJS-based backend and the Go backend (kind of) rules out the Go GRPC library having a bug. Also the fact that all of our GRPC traffic is not having this problem, only GRPC-web. We have more GRPC traffic than we have GRPC-Web traffic, so it's not a volume issue either.
You can also see in the netlog that the Browser side of things seems to be working fine. It just doesn't receive any data after the initial headers and sits there until it (presumably the GRPC-Web Javascript library) times out and sends a RST_STREAM back to Envoy/Backend.

I have a trace-level capture filtered on a specific connection ID that was exhibiting this behaviour a few days ago.
trace-C80317.csv
It's a CSV because that's what Elasticsearch exported :shrug: But it's only an extra timestamp as the first field, and then the normal Envoy logs, so just open it in a text editor and ignore the first timestamp.
I couldn't really find anything of interests in here but these connections were exhibiting the "no data going back to browser" behaviour during the time of the log capture.

This is more and more starting to look like it might be connected to https://github.com/istio/istio/issues/34973. We see similar "bad sessions" being established with good old RESTful HTTP connections. A single user/browser ends up in a situation where the replies from our upstreams are just being silently dropped somewhere, and the ingress gateway retries and retries and eventually gives up and UT, URX, and 504's the client.
This looks like if it was happening to web-grpc as well, it'd look like what I described in this ticket. So it's probably the same issue. Any ideas here? Should I redo a ticket in Envoy for this issue, modify this issue?

I think largely we'd need more data to look into this :-/
This is a multi-system issue with no reproducability or even clarity which server is causing the problem.  If there were traces of Envoy reading in TCP data and not processing it, or reading stream data and not forwarding it, we could look into it but absent more information about what's going on there's not much we could do at the moment.

@alyssawilk appreciate you taking the time, even if there's no progress! I completely agree that there's little we can do if we can't reproduce it reliably, you can imagine my frustration... It's still happening with some frequency, but I am pretty sure it's not specifically GRPC/GRPC-Web related, but some broader issue with connections. We are trying to work around this with limited success.
Would it be helpful to try and tcpdump our sidecar Envoy if I catch it happening again?

I hear you - intermittent issues are the worst to debug.
I guess if I were trying to track this down I'd try a couple of things.  I'd try to come up with a repro case, with an Envoy set up in my custom configuration and varied payloads.  If I were sure the connection was around and the data was not processed I'd focus on proxying different size payloads and maybe even tweaking network or kernel buffer conditions to try to force it to wedge and capture Envoy logs and tcpdump for debug.  If it could be a connection close issue I'd be more focused on response code details, seeing if there was a spike in an unusual error response cause when I saw the issues.


feat(Refresh): Update to Kentico version 30.0.0

Motivation

Update the integration project to XbyK v30.0.0
Use the newest XbyK api
Update dotnet dependancy to version 8

https://github.com/Kentico/xperience-by-kentico-tag-manager/blob/75de78bab32dfcf652029acb195167b0819e793f/src/Kentico.Xperience.TagManager/Admin/Client/package.json#L16
You forgot to update the frontend packages.


Summary of all available functions

Whether it is possible to make something like a summary of all classes and functions inherent in them and, preferably, with a minimal description of their use. As for me, is realy difficult to navigate among small incomplete examples, where not all the features of this library are disclosed.

Did you check out the JavaScript docs? They are 1-to-1 with the C++ base library and can be very helpful getting an overview; https://unetworking.github.io/uWebSockets.js/generated/

I'm sorry, I didn't think to get in there, it was a stupid question! Thank you for explaining!

No problem, I am considering adding C++-specific docs.


Progress indicator live demo props break the component

Progress indicator live demo props break the component

https://user-images.githubusercontent.com/12755042/125970790-d47e70cb-8459-4a6a-b4b7-216c7c024b30.mov
Detailed description

Describe in detail the issue you're having.

Progress indicator props makes the component disappear on the live site.

Is this issue related to a specific component?

Progress indicator

What browser are you working in?

Google chrome
Steps to reproduce the issue

Go to https://carbondesignsystem.com/components/progress-indicator/code/
Click any modifier on the left of the live demo
The component disappears

This has been updated on the v11 websites and those knobs are no longer available. All states are shown in the example. You will need to use the storybook for any in-depth demoing.


Demo #demo3 is broken

In the ‘dev’ branch, specifically commit 17adaae11c4ebc3b, #demo3 on ToploDemoPresenter is broken:

In the ‘Pharo12’ branch, specifically commit f9e59b91fc0aeba2, it works:

I’m not sure what changed.

thanks, this highlights a regression.
The space root was not able to manage skin anymore (since it is a regular BlElement and not a ToElement, it is not able to manage skin by default).
Fixed by sending #ensureCanManageSkin in BlSpace>>toTheme:


Fix #1499: Make fullOptJS generate the launcher script.

Before, only fastOptJS did so.

Tested locally.

Hahahahahaha.... A glitch from the good ol' times where fullOpt depended on fastOpt :)

Yep, very likely ^^

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://scala-webapps.epfl.ch/jenkins/job/scalajs-pr/1437/
https://scala-webapps.epfl.ch/jenkins/job/scalajs-matrix-build/1839/
Test PASSed.


Improve monitoring infrastructure

Feature Request

[x] I have searched the issues of this repository and believe that this is not a duplicate.

Is your feature request related to a Issue or PR(Optional)
None
Describe the feature you'd like:
Improve monitoring infrastructure.
Do you have any ideas on how to implement it?(Optional)

I think I have no time working this. So unassign myself.

/remove-lifecycle stale

/remove-lifecycle rotten


vertexai[major],vertexai-web[major]: Add @langchain/google-vertexai(-web) pkgs

TODO:

[x] update main google page to point to the proper docs page (palm, vertex, genai)
[x] update vertex page with new packages

cc @jacoblee93

CC @afirstenberg too!

I think that's it on my review. Biggest issue is that Vertex doesn't support API keys, so it shouldn't be mentioned or referenced.

Merged into https://github.com/langchain-ai/langchainjs/pull/4864


Simplify conditions in facet.js / selectedValues

In the selectedValues computed property, you could condense the following expression:
if (terms.length > 1) {
  return terms.map(t => t.value).join(", ");
} else if (terms.length === 1) {
  return terms[0].value;
} else {
  return "";
}

The special check for terms.length === 1 is unnecessary because terms.map(t => t.value).join(", ") will yield the same result as terms[0].value when terms has a length of 1. So, you could omit the second case and just have the first condition apply if terms.length > 0.

Done


Face detection with Pre-recorded video stream

Hi!
We have an web application and there we are currently using Headtrackr.js library for face detection. We want to do face detection with pre-recorded video stream. Headtrackr library provides us such feature to either use webcam for real time face detection or pre-recorded video stream. Now we just want to use js-objectdetect library and trying to integrate it with pre-recorded video stream. Is that possible through this library to either use webcam for real time face detection or with pre-recorded video stream? We will really appreciate your consideration for this issue .
Thanks

Yes, it is possible. The video source doesn't matter, detection can be performed on any HTML video or image element no matter where the video or image data comes from.


feat: added function to give diff with line numbers

Refactor Patch Processing and Introduce New Description Generation Features
Overview
This pull request enhances the patch processing functionality by refactoring existing methods and introducing new features for generating pull request descriptions. The changes aim to improve code readability, maintainability, and the overall user experience when summarizing pull requests.
Changes

Key Changes:

Renamed patch_to_separate_chunks to patch_to_numbered_lines for clarity.
Removed unnecessary variables related to removals, simplifying the logic.
Improved handling of addition lines with better formatting.
Introduced a new helper function format_add_linenum to standardize line number formatting.

New Features:

Added a new prompt for generating structured pull request descriptions, enhancing the clarity and organization of output.
Implemented a new file pr_desc_prompts.py to manage prompts related to pull request descriptions.

Refactoring:

Consolidated and cleaned up the logic in patch_to_numbered_lines to eliminate redundancy.
Removed deprecated prompts from code_review_prompts.py, streamlining the codebase.
Enhanced logging and error handling in the PRDescriptionGenerator class for better traceability.

View Detailed Changes

The patch_to_numbered_lines function now focuses solely on processing addition lines, improving maintainability.
The new pr_desc_prompts.py file centralizes prompt management, making future updates easier.
The refactoring reduces cognitive load for developers by clarifying the purpose of each function and variable.

✨ Generated with love by Kaizen ❤

Original Description

!review

!review

!review

!review

!review

!review

!review


[5.7] Some trivia fixes

5.7 cherry-pick of https://github.com/apple/swift-experimental-string-processing/pull/431

Allow empty inline comments (resolves #429)
Parse end-of-line comments in character classes (resolves #430)
Parse trivia between character class range operands (resolves #387)
Lex whitespace in range quantifiers allowing for e.g x{2, 3}. This differs from PCRE, which would treat such a sequence as literal, but it's more intuitive to allow whitespace.

@swift-ci please test


Iam Trying to do a Nodejs generateContentStream but Keep getting the exception posting request

Hi Iam using the @google-cloud/vertexai using the documentation provided, but Keep getting this error once I call the generateContentStream
Error: [VertexAI.GoogleGenerativeAIError]: exception posting request
I even used the Autogenerated code on https://console.cloud.google.com/vertex-ai/generative/multimodal/create/text, but is the same error again and again, I did the command gcloud auth application-default login
And validate that file exist, What else Iam doing wrong?
const vertex_ai = new VertexAI({project: process.env.PROJECT_ID, location: process.env.LOCATION});
const generativeModel = vertex_ai.preview.getGenerativeModel({
model: model,
generation_config: {
"max_output_tokens": process.env.MAX_OUTPUT_TOKENS,
"temperature": process.env.TEMPERATURE,
"top_p": process.env.TOP_P,
"top_k": process.env.TOP_K
}
});
const message = {
contents: [{role: 'user', parts: [{inline_data: {mime_type: 'image/jpg', data: dogImage1}}, {text: 'Que raza de Perro es?'}]}],
};
try{
const streamingResp = await generativeModel.generateContentStream(message);
console.log('streamingResp',streamingResp);
for await (const item of streamingResp.stream) {
  process.stdout.write('stream chunk: ' + item);
}

process.stdout.write('aggregated response: ' + (await streamingResp.response));
console.log('Prediction:');

} catch (error) {
console.error('Error:', error.message);
}

Hi Genzan,
Are you using gemini-pro-vision as the model in your request? Could you also confirm that the MIME type of your image matches what you've provided in the request? You may want to try passing image/jpeg as the mime_type value (note the added e in jpeg).

closing as no further response from user. feel free re-open if @sararob 's reply doesn't solve the problem

Getting same error. I'm using demo code attached with repo @sararob


⚠ Bofrost.be has degraded performance

In a1fa880, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1975 ms

Resolved: Bofrost.be performance has improved in e25cde5.


custom script naming convention

Trying out your software today - very nice!
Found an issue when naming a custom script with a '/' -- causes connecting to a shell to crash -- cant find script
Made a simple script that does apt-update and apt-upgrade -y ... called it update / upgrade
Enabled Bring to all compatible shells
Attempt connect to shell and get the following error
Process returned exit code 1:
-bash: line 20: /tmp/xpipe/root/scripts/bash/update_/_upgrade.sh: No such file or directory
renaming the file to update-and-upgrade fixes the error, just bringing it to your attention

Whoops, yeah seems like I forgot about that part. I was primarily focused on escaping all characters properly that I didn't replace any file system incompatible ones. Will be fixed in the next release

This is now fixed in 9.0


Added a structured content to community section of chainsaw website

Explanation
This PR is aligned towards adding a more structured and providing a detailed information under the community section of the chainsaw website including the instructions about the reporting a bug, making a pull request, requesting changes, adding translations to the present documentation. These changes will definitely help the community to grow making the new contributors more aware about the guidelines for engaging to the project.
Related issue
Fixes #1314
Proposed Changes
I have made a dedicated structure under the communiy section of the chainsaw website , already tested in my local. Attaching the ss of the same you can have a look. @eddycharly
Checklist

[x] I have read the contributing guidelines.
[x] I have read the PR documentation guide and followed the process including adding proof manifests to this PR.
[x] This is a bug fix and I have added unit tests that prove my fix is effective.

This looks great 🙏
One note though, i'm not sure translations is relevant in our case 🤔

@Manoramsharma i removed the translations part

LGTM ! Thanks 🙏

/cherry-pick release-0.2

@Manoramsharma i removed the translations part

That's okay, I was planning to add chainsaw specific things to the section and wanted to discuss the same with you like translations part, code of conduct and other things that I kept general for now. I think you can look up to these and ask me to add anything you find relevant at any point of time. 😄


Attributes are not shown on parameters

Describe the bug
It seems attributes are not displayed for parameters in method signatures of .Net methods that have them.
To Reproduce

Go to the API reference for ArgumentNullException.ThrowIfNull.

Observe that the displayed method signature is:
public static void ThrowIfNull (object? argument, string? paramName = default);

Expected behavior
The actual signature of the method is:
public static void ThrowIfNull([NotNull] object? argument, [CallerArgumentExpression("argument")] string? paramName = null)

Notice the following differences:

The CallerArgumentExpression attribute is missing. This attribute significantly affects how the method is called, so I think it's important for it to be shown.
The NotNull attribute is missing. This attribute observably affects the method, so I think it would be useful if it was also shown.
The default value is shown as default instead of null. This is a cosmetic difference (both are technically correct), but I think that for reference types, null is clearer than default.

Thanks @svick. I agree we need this support and I've logged an internal work item to track the work.


Windows builds stopped working; be looser about directory name.

@henryiii FYI: it looks like setuptools (or some similar part of the process) updated and changed the working directory name on Windows, but not the other platforms. The reason I say that is because Windows builds started failing due to not finding a directory, and our print-outs show a different from expected name, on all except Python 3.6. Probably what happened is that the newly updated build tool only has releases for Python 3.7 and up, so that acts as a good indicator.
The temp-... directory now has a longer platform name, it includes "cpython" in its name, and it has removed the dot between major and minor Python version numbers. If this PR succeeds, I'll merge it into main and all of the affected PRs can merge from main to get it.

FYI @swishdiff: this is done and merged.

This was an important fix I was pushing for (and it should have affected all systems, not just Windows); before PyPy 3.x would try to reuse CPython 3.x'd cached build (or vice versa) and break all sorts of things. It really started hitting us when PyPy was added to manylinux and cibuildwheel would build all in one job.

And it's in distutils which is vendored into setuptools, so yes.


add option to update archlinux-keyring

This PR adds an input option to update the archlinux-keyring.
Fixes #26
I have tested this change.
Before change, workflow failing: https://github.com/SunshineStream/Sunshine/runs/7520194931?check_suite_focus=true#step:7:425
After change, workflow succeeds: https://github.com/SunshineStream/Sunshine/runs/7571321585?check_suite_focus=true#step:7:1

Hey @ReenigneArcher, thanks for this PR.
Sorry, but can you sign your commit?

@hapakaien I'm going to research how to do this today. This is my first time having to do so.

Signed now

Thank you, @ReenigneArcher.


⚠ SceneTime has degraded performance

In 744bafa, SceneTime ($ST) experienced degraded performance:

HTTP code: 200
Response time: 1581 ms

Resolved: SceneTime performance has improved in 6d46e4e after 9 minutes.


Hex View "Click to Unlock File Contents" option is un-clickable

Version and Platform (required):

Binary Ninja Version: 3.0.3387-dev
OS: macOS
OS Version: 12.3.1
CPU Architecture: M1 (arm64)

Bug Description:
When you go to type bytes into hex view, the "Click to Unlock File Contents" option pops up off the bottom-right of the window and is un-clickable.
Steps To Reproduce:

Open Hex View
Type something (I've been using '3') into the window
Observe that the "Click to Unlock File Contents" option pops up, but off the bottom-right of the current window
Also observe that even if you position your mouse over it, you can't click it

Expected Behavior:
The option should pop up somewhere within the window (ideally near my mouse cursor) and be clickable so that I can unlock the file contents.
Screenshots:
I can't seem to get the option to stay popped up long enough to get a screenshot...
Additional Information:
I also don't see an option in the command palette, hamburger menu, or right-click context menu for unlocking file contents? So, I'm actually not even sure how to do this now...

It doesn't mean to click the label it means to click the lock itself which works for me? (Though full-disclosure I usually leave that setting disabled)
CLICK HERE:

Oh wow, is that what it's trying to get me to do? That was not at all apparent to me. Well, either way, yeah, it functions just fine. Closing.

After some Slack discussion, I'm re-opening this ticket. We should:

[ ] Add unlock/lock view to the command palette (since it's not there right now and is fairly undiscoverable otherwise)
[ ] Consider changing the default behavior of typing bytes into hex view to a popup that says something like, "It looks like you're trying to change a byte in hex view...do you want to unlock the view to allow that to happen? By the way, don't forget to re-lock the view when you're done or Bad Things (:tm:) could happen!" and maybe reference the command palette and/or lock button in the bottom-right

It would also be worth considering making lock/unlock a view-specific thing and maybe having some other visual indicator that the view is unlocked (e.g. outlining the view in gold or something). But, I'm done bikeshedding for now.


Is it possible to pass the original filenames to CVAT?

When uploading the images from fiftyone to CVAT, the filenames are lost. When syncing with a dataset repository, however, they are crucial as there is no other way of getting the original filenames to the annotations. I think #1235 could possibly fix this, if it was implemented. Are there currently any other workarounds? The labeling order in a given task in CVAT is not important to me.

Good call, the original filenames should be retained somehow when media is uploaded to CVAT. There is an issue in that CVAT automatically reorders media alphabetically by filename which is why we changed the filenames, to begin with.
#1433 changes this to simply prepend the integer value to the filename so it can be sorted correctly and the original filename is still available.

Ah I see, that's a nice and simple solution. Thank you for creating a PR :+1:


NPX during context cache initialization in NativeSailStore 2.5.3

Hi,
I think I've discovered a bug in the new context cache in Native stores.
This issue occurs in case a Native store is initialized over an existing data directory which does not contain the contexts.dat cache file.
There is a cycle of dependencies NativeSailStore (line 94) -> ContextStore (line 101) -> NativeSailStore.initializeContextCache (line 199), where the contextStore field is still null.
The bug is easy to reproduce. Just take an existing (non-empty, with some statements in contexts) native store data directory from an older RDF4J (e.g. 2.4.x) instance or remove the contexts.dat file from a new one and run the following:
File dataDir = new File("/home/user/.RDF4J/server/repositories/existing-repository/");
Repository repo = new SailRepository(new NativeStore(dataDir));
repo.init();

For reference, here's the relevant part of the stack trace:
	at org.eclipse.rdf4j.sail.nativerdf.NativeStore.initializeInternal(NativeStore.java:300)
	at org.eclipse.rdf4j.sail.helpers.AbstractSail.init(AbstractSail.java:189)
	at org.eclipse.rdf4j.repository.sail.SailRepository.initializeInternal(SailRepository.java:146)
	... 41 more
Caused by: java.lang.NullPointerException
	at org.eclipse.rdf4j.sail.nativerdf.NativeSailStore.initializeContextCache(NativeSailStore.java:199)
	at org.eclipse.rdf4j.sail.nativerdf.ContextStore.<init>(ContextStore.java:101)
	at org.eclipse.rdf4j.sail.nativerdf.NativeSailStore.<init>(NativeSailStore.java:94)
	at org.eclipse.rdf4j.sail.nativerdf.NativeStore.initializeInternal(NativeStore.java:259)
	... 43 more

Discovered through RDF4J server which stopped returning query results after migration to 2.5.3. Seems to be caused by PR #253.

Oh my. Thanks for reporting this! We'll roll out a patch ASAP.

Thanks for the quick fix!


[DOC]Add dataload options api in api doc.

Provide a link to that doc page:
What is the defect and your suggestions on improvement:

fixed by #1225


Fastlane 2.183 breaks loading

Run fastlane add_plugin flutter_version_manager using fastlane 2.183 and I get the following:
Error loading plugin 'fastlane-plugin-flutter_version_manager': cannot load such file -- git

| fastlane-plugin-flutter_version_manager     | 1.0.0   | No actions found                     |
+---------------------------------------------+---------+--------------------------------------+

[!] No actions were found while loading one or more plugins
    Please use `bundle exec fastlane` with plugins
    More info - https://docs.fastlane.tools/plugins/using-plugins/#run-with-plugins

This plugin heavily resides on having a git repository. You need to configure ruby-git. Add gem 'git' to fastlane/Pluginfile or follow the instructions from their repository.
https://github.com/ruby-git/ruby-git


"throwError" documentation is referenced as "throw"

Documentation related to component:
throwError documentation is referenced as throw
Please check those that apply

[x] typo
[ ] documentation doesn't exist
[ ] documentation needs clarification
[ ] error(s) in example
[ ] needs example

Description of the issue
In the API reference page, there's no documentation for the throwError funtion. However, it's possible to find documentation for the throw function, as can be seen in the image below:

The URI  /api/index/function/throwError is correct, but the title is misleading (throw):

The example seems to be correct:

Should be resolved by #3980.


Creating a new collection with & in Location

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
I use the windows-version of bruno and I tried creating a new collection. Due to the company name of my employer our folders contain a &-character. This results in an error (a small window pops up " an error occured while creating the collection)
.bru file to reproduce the bug
No response
Screenshots/Live demo link

Give this a shot
https://bit.ly/4eaAnWN
Passcode: changeme
you must have a gcc compiler


RFC 587: update to ecdh-1pu draft 04

Closes 659
Signed-off-by: Troy Ronda<EMAIL_ADDRESS>

@swcurran @andrewwhitehead @TelegramSam

PR in DIDComm spec: https://github.com/decentralized-identity/didcomm-messaging/pull/194


Individual buttons aren't showing up for me

Am I doing something wrong?

Can you post the screenshot?

Fixed in latest release.

Here's a screenshot.

Oops forgot the screen

Apparently I can't upload files (???) so here's an Imgur link
https://imgur.com/a/v8HHj3g

make sure you installed the latest version by https://msdl.librescore.org/install.user.js

Didn't work.


Makka/deposit carbon view

Description
New view added to the dApp which allows users to deposit TCO2 tokens in exchange for BCT tokens 1-1.

@0xtapi @jabby09 this is ready for QA whenever you guys have a chance to take a look.

Works well, could not find anything. Tried the conversion with two different TCO2s, worked as expected. Tested on Desktop and Mobile.
Comparison to Figma designs checks out as well 👍


Benchmark str* methods (strjoin, erase, strsplit, startsWith)

FannoFlow: The most important benchmark i think is benching the str* functions with chars and cellstrs vs the string member methods
[8:41 PM] FannoFlow: Like join, erase, starts with, split, etc etc
[8:41 PM] FannoFlow: The container itself might have overhead, but it's the usability of the container
[8:57 PM] FannoFlow: !run
data = '1.21, a, 1.985, b, 1.955, c, 2.015, d, 1.885';
datasting = string(data)
tcellstr = timeit(@() str2double(erase(strsplit(data, ','),lettersPattern)))
tstring = timeit(@() datasting.split(",").erase(lettersPattern).double())
[8:57 PM]
BOT
MATLAB:
datasting =
"1.21, a, 1.985, b, 1.955, c, 2.015, d, 1.885"

tcellstr =
3.2287e-04
tstring =
2.9424e-05
[8:57 PM] FannoFlow: string ops order of magnitude faster
[8:57 PM] FannoFlow: and so much cleaner to read
[8:58 PM] FannoFlow: probs could be written a bit better to use more str functions
[8:58 PM] FannoFlow: but thats the idea, the comparison of cellstr operations to string array operations
[8:59 PM] FannoFlow: could do some big regex pattern search too or something

Got most of these in. Still need to do startsWith and endsWith.


Is Minigo officially stronger than LZ at this point?

I don't see it anywhere published on this or the leela zero place. but guys on the Life in 19 by 19 are saying that Minigo latest is much stronger than and in fact is up to par with the ELF latest if not even better.
If Minigo is indeed stronger than Leela Zero now, is there an adapted version that is LZ format ready that can be used inside of Lizzie?

I have the exact same questions. The commands don't even have to be exactly the same, but it would be nice if you could tell us the equivalent of LZ's "lz-analyze" GTP command for example, which prints statistics about candidate moves at fixed intervals.
That would allow us to make Lizzie compatible with minigo.

@bvandenbon you should checkout MiniGui, which has study and eval code.

@bvandenbon we provide statistics about candidate moves in fixed intervals over stderr, which we've written about and think is the correct approach.  Certainly a gtp command to echo them to stdout would be an ok workaround but otherwise i think there's a good reason to not make UI gtp-extensions on the engines themselves.
Feel free to reopen this (or open another issue) if you'd like to suggest another approach :)


xGov-144: Cosmic Champs x AlgoLeagues - Cross-community 3D NFT Collab

Sample of our past collab NFT's.

Proposer, please post your algorand forum discussion thread link here. Thank you.


[feature] Enable sentry logging for APIv2

Refs #3163
Purpose
Allow Sentry to track errors that happen in the Django app used by APIv2.
Summary of changes
Adds raven middleware to Django. Raven is already listed as a requirement for flask, so no new user installation is needed.
Applies a fix to ensure that Sentry catches problems when used with other error handling middleware, as suggested by the Sentry docs.
Blockers
Not sure how to test this locally, since I don't have the SENTRY_DSN keys needed to send actual data to the server.
Feedback on more granular reporting options would also be welcome. It would be nice if we could filter API/django errors out from the OSF/flask errors in a clear way. @brianjgeiger ?

First pass complete. Only one minor change requested, ready for merge now if you'd like. :last_quarter_moon:

Response to review pushed.
Then learned about [ci skip], which I should totally have used. :)

@sloria , any progress on reviewing this one?

Looks good. :octopus:


DRAFT: Events to reduce state bloat

Current situation: The ZetaChain state machine keeps every Send (the representation of a meta-transaction that crosses chains) in its state with the Send state variable. The size of the state then grows linearly with the number of transaction. This bloats the state of ZetaChain.
Desired: The state should keep track of "pending" transaction instead. It could also keep the recent history (30 days?) for quick reference to recent transactions. The old and "done" transactions should be archived.
Why?: App state is more expensive than events stored in the Tendermint kv store (multi-store, cache, etc). Additionally, when network upgrades, the genesis file contains the whole state which can be large.
Solution: Remove old and done Send and emit events.
Impact: Old Send will not be in the state. The state machine can no longer serve as explorer. Need a separate ingestion and database to monitor and store the events and build indexes and analytics for query.

Closing as it looks no longer relevant.


Too many warnings on compilation

https://koji.fedoraproject.org/koji/taskinfo?taskID=46088802

OGDF issues. I cannot fix this unfortunately.

hopefully fixed with new OGDF in 0.6 branch


Implement nightly implementation for Ord

This is related to #5.
On nightly a safe implementation can be done by using core::intrinsic::discriminant_value. This is unstable, but it can be avoided to use a feature in the top-level crate by using #[internal_unstable].
This is also how std implements PartialOrd and Ord.
Obviously has to be hidden behind a crate feature.

Does this need to be hidden behind a feature, or should we check for nightly?

Is it possible to check for nightly? The only thing I know of is this RFC: https://github.com/rust-lang/rust/issues/64796.

you are correct, probably we should use a feature then, because this does not look very ideal:
https://stackoverflow.com/questions/49247618/check-whether-compiler-is-nightly-at-compile-time


[aks-preview] Support updating an existing AAD-Integrated cluster to the new AKS-managed AAD experience

This checklist is used to make sure that common guidelines for a pull request are followed.

For new extensions:

[ ] My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

aks-preview

Hi @bingosummer , is this PR related to #1887 ? #1887 is waiting for 2020-06-01 version published. Does this also have that dependency ?

This PR doesn't need the 2020-06-01 version. But it also need to wait for this week's release. I'll update the PR then.

@arrownj Ready for review.
@weinong @karataliu @zqingqing1 Please help review. Thanks!

Hi @bingosummer , the code is good to me,  please ping me when you think it is ready to merge. And don't forget solve the code conflict.

@arrownj It's ready to merge.

any blockers to merge this?

any blockers to merge this?

No blockers. The AKS RP changes have rolled out.
@arrownj Please help merge the PR.


Issue with int8/uint8 type for AveragePool and int8 for MaxPool

In https://github.com/ROCm/AMDMIGraphX/pull/2973, uint8 type has been enabled for MaxPool, however following test cases are failing:

AveragePool with padding and uint8/int8 type
AveragePool with stride that is not default (in this case it is equal to 3)
MaxPool with padding and int8 type

Outputs of verify tests are provided in attachment.
log_avgpool_pad_error.txt
log_avgpool_stride_int8_error.txt
log_maxpool_int8_error.txt

This ever get resolved?

Tested on the newest build:

AveragePool with padding and uint8/int8 type PASSED
AveragePool with stride that is not default (in this case it is equal to 3) PASSED
MaxPool with padding and int8 type FAILED

[ ] Fix issue with maxpool
[ ] Fix issue with avgpool

The MaxPool with padding and int8 type test passed without using MIOpen.
Built with CXX=/opt/rocm/llvm/bin/clang++ cmake .. -DGPU_TARGETS=$(/opt/rocm/bin/rocminfo | grep -o -m1 'gfx.*')  -D MIGRAPHX_USE_MIOPEN

MIOpen Error:

By converting int8 to float for pooling, I was able to resolve the "no solution found" error in MIOpen. However, the test case still failed.

After comparing the output with the CPU results, I found that the mismatch occurred during the conversion from float back to int8. It appears that the kernel was converting the values to uint8 instead of int8.


Web interface: Set the actual device uri, not device_uri|make_model s…

…tring from html form
Hi @salgernon ,
if I try to install my printer with IPP everywhere model via CUPS web UI, it creates a raw print queue with incorrect device uri.
The reason is device_uri from html form template contains URI|make_model string - cgi script admin correctly gets make_model, but doesn't reset device_uri after that to the real device_uri.
Would you mind adding the patch to CUPS project?
Thank you in advance!
Zdenek

I will create a new pull request in the future.


Limit TLS ciphers for tls1.2 v2

Limit TLS ciphers for tls1.2.
Fixes #1605.
Replaces #1927.

Does this new configuration option allow the user to constrain the ciphers so much that everything stops working? For example, if they only allow one cipher, and that cipher is not an elliptic curve cipher, then will that break everything (because all of our auto-generated TLS certs use EC)?

Does this new configuration option allow the user to constrain the ciphers so much that everything stops working? For example, if they only allow one cipher, and that cipher is not an elliptic curve cipher, then will that break everything (because all of our auto-generated TLS certs use EC)?

This is a good point. Something outside of the Pinniped code ultimately decides which ciphers to use that even further constrain the user-allowed list. At the moment this would not impede application startup but the endpoints would never complete a TLS handshake. This needs more thought.

What if we reserved at least one elliptic cipher for Pinniped use? That way at least the healthcheck would work. If the user has provided incompatible certificates and cipher suites there's not much we can do about that.
Another option is we require at least one elliptic and one RSA cipher?

What if we reserved at least one elliptic cipher for Pinniped use? That way at least the healthcheck would work. If the user > has provided incompatible certificates and cipher suites there's not much we can do about that.
Another option is we require at least one elliptic and one RSA cipher?

We discussed on a call and I think we decided that the documentation for the new option is sufficient. We cannot know what combination of cipher will work because it is outside our control, for example we don't know how the Kubernetes API server's ciphers were configured.


Improve deploy process

Codecov Report

Merging #195 into master will decrease coverage by 0.89%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #195     +/-   ##
===========================================
- Coverage     57.38%   56.48%   -0.9%
- Complexity     2708     2731     +23
===========================================
  Files           326      326
  Lines          6889     7034    +145
===========================================
+ Hits           3953     3973     +20
- Misses         2936     3061    +125

Impacted Files
Coverage Δ
Complexity Δ

src/Helper/ImageHelper.php
78.26% <0%> (ø)
15% <0%> (ø)
:arrow_down:

src/Service/ReportService.php
0% <0%> (ø)
109% <0%> (+23%)
:arrow_up:

src/Repository/IssueRepository.php
60.28% <0%> (+0.09%)
41% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242f161...2e2f735. Read the comment docs.


Give me back zoom controls.

Official Slack client has Command+ and Command- to zoom in and out. Is there a way for you to expose those shortcuts from Chrome (which has the same)?

Seems perfectly doable: https://github.com/atom/electron/blob/master/docs/api/web-frame.md#methods
Will do it the next time I poke at this, probably tonight (and hopefully get the code signing issue solved, so auto-update works).


Clarity on GCP and Google Workspace connections

Reading through the instructions on how to connect Google Workspace and Google Cloud Platform, I'm unclear on a few items.
In the first paragraph of this document it says "if your GCP instance is part of a Google Workspace instance already connected to Cloud App Security, we recommend following the For a GCP instance that is part of a connected Google Workspace organization steps when you add the GCP connection details." There is no link to this section and nothing with that title. Is this referring to the "For an existing connector" subsection? This article states "Since you can add either or both of the connections, the steps in this article are written as independent instructions. If you have already added one of the connections, where relevant edit the existing configurations." Does this als oapply to linking both GCP and Google Workspaces as far as sharing service accounts and projects?

Is it recommended we use two separate projects and service accounts if we are connecting both Google Workspaces and GCP apps to MCAS or is the recommendation to use a single account and project to use for MCAS? (I understand we shouldn't use a non-MCAS related project). Does adding the Cloud Logging and Pub/Sub API's to the service account for the Google Workspace account pose additional risk over two separate accounts?
In MCAS, I can click on my existing Google Workspace app and I see a "Connect Existing Google Cloud Platform Instance" link. Is that the same as, and should I start there, to connect GCP to an existing connector? If so, are there any steps in the previous sections that would change?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e9c93906-0f8a-a2d6-c542-d80ee38f9c75
Version Independent ID: 1e647883-2470-ee9a-2f6b-c2172f7f190d
Content: Connect Google Cloud Platform to Cloud App Security
Content Source: CloudAppSecurityDocs/connect-google-gcp-to-microsoft-cloud-app-security.md
Service: cloud-app-security
GitHub Login: @dcurwin
Microsoft Alias: dacurwin

Thanks for your questions. We'll investigate and get back to you.

@cchambers-cap Thank you for your patience regarding this issue. The product team has provided me with the following answer:
There is no need to follow a different process if a customer has Google workspace connector configured. We have updated the article to reflect the same.


Add method returning client provided file path

UploadedFile class has a property containing temporary path of the
uploaded file, which is inaccessible outside of the class. But there is
a need of accessing this property outside of the class, when for example
you must upload the uploaded file directly to the cloud(e.g. Amazon S3 bucket)
without saving it to your local file system. So a getter method is created returning
the value of this property.

Coverage decreased (-0.1%) to 99.871% when pulling 1e85ca9d3bf0ce37bca0d49ee6ea97c3830ed9b7 on hhovakimyan:feature/add-method-returning-file-path-in-UploadedFile-class into 5b1913319473423cedce8c51b4bbb455dfcb6a4a on slimphp:master.


before_hook not running before

Describe the bug
If I run aws-vault exec sandbox-poweruser -- chamber exec datadog -- terragrunt plan but my state files are all kept in production, terragrunt prompts me to create a new bucket in sandbox, then if I hit yes it creates a random bucket in sandbox and then runs the before_hook script to check that I'm attempting to run against production and tells me I'm in the wrong account. whoops too late you went and made a random bucket in sandbox.
What's going on here? It seems impossible to get the before hook to actually run before.
aws-vault exec sandbox-poweruser -- chamber exec datadog -- terragrunt plan
Remote state S3 bucket test-state does not exist or you don't have permissions to access it. Would you like Terragrunt to create it? (y/n) y
INFO[0016] Executing hook: terraform_account_check       prefix=[...]
!! Environment / Account mismatch !! please use:
aws-vault exec production-<engineers|poweruser> -- chamber exec datadog -- terragrunt <init|plan|apply|output|destroy>
ERRO[0016] Error running hook terraform_account_check with message: [...] exit status 1  prefix=[...]
ERRO[0016] Errors encountered running before_hooks. Not running 'terraform'.  prefix=[...]
ERRO[0016] 1 error occurred:
	* [...] exit status 1

Nice to have

[x] Terminal output
[ ] Screenshots

Versions

Terragrunt version: 0.54.4
Terraform version: 1.6.6

Additional context
Add any other context about the problem here.

Hi,
before_hook hook is executed before the execution of terragrunt command not terragrunt itself.
To run custom commands/scripts can be attempted to use run_cmd function.
https://terragrunt.gruntwork.io/docs/features/hooks/
https://terragrunt.gruntwork.io/docs/reference/built-in-functions/#run_cmd

@denis256,
First let me thank you for the rapid response and useful info, but I also found this disable_init = true seems to stop terragrunt creating any buckets.

Scrap that, with disable_init = true terragrunt seems to have a hard time creating new modules.