[Feature] Move white-listed applications to the first available empty desktop

Certain applications have annoying initialization processes in that they bring up & tear down several windows before the application is ready (e.g. steam, slack).  This causes some painful behavior in scenarios like the following:
As a user, given this desktop setup (bold desktops are occupied):
1, 2, 3
I want to open steam in the third desktop so I switch to 3, launch steam, and switch back to 1.  Desktop config now becomes:
1, 2, 3, 4
After the first steam window closes, desktop 3 is removed and the new steam windows are pulled up in desktop 1.  I now have to manually move all steam windows to desktop 3 until steam is fully initialized.
To help with this scenario, it would be nice to have a certain applications open in the background, or the first available empty desktop.  With this change, I could launch steam from desktop 1 and ensure that the steam windows get moved automatically to desktop 3 without any user intervention.  Desktop 3 will get removed & added as steam windows are brought up and removed, but since this is happening in the background, I shouldn't be disrupted.

OpenSCAD has this too, very annoying. You launch it in a new desktop, it opens the "New or existing" dialog, you select something, it closes the dialog and launches the main process which ends up on the previous desktop (since the dialog closed?)


Trace persist fire n forget

The idea behind the PR is that tracing persistence right now throws the error, which causes downstream unhandled promise rejection.
So i just implemented tracing as fire and forget, in this case if tracing fails and error is recorded but does not blow up the actual logic

Hi, i do have some comments about your PR.
I will get back to it as soon as i have the time!
Thank you!


Why might AKS service principal not have access to ACR registry?

The docs state "In some instances, the service principal being used by AKS cannot be scoped to the ACR registry."
What instances?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ed59d472-ac33-5c03-dbb7-0e86e88c7dd8
Version Independent ID: 69e1ad8c-2dd3-cc1b-2b31-996a5d866cc0
Content: Authenticate with Azure Container Registry from Azure Kubernetes Service
Content Source: articles/container-registry/container-registry-auth-aks.md
Service: container-service
GitHub Login: @mmacy
Microsoft Alias: marsma

Hi @jobevers, this is referring to organizational restrictions within your Azure AD. For example, within your directory, you might not have sufficient permission to assign the required role to the service principal that was created automatically when the cluster was created. In this case, you can fallback to the second method of creating a new service principal and using the K8s image pull secret. I'll work on clarifying the wording a bit on this.
#in-progress

@jobevers I've added additional clarification to the line in question as well as a few clarifications in other parts of the doc. Thanks for the input!
Authenticate with Azure Container Registry from Azure Kubernetes Service


EFCache Clear All Items method

Hi,
I use nopCommerce with EFCache. But i can't clear all items with a method.
I need registrable ICache object for Dependency Injection and Clear methods.

I have not used nopCommerce so I don't quite understand the challenge here and how it can be solved in/by EFCache.

You should be able to call the Purge method to clear the cache on the InMemoryCache instance.


Added Spanish (es_es) language

@KnightMiner Hi! How are you? I hope it's ok. I have completed the Spanish translation, could you merge the changes? When you have time! Regards!

Having time is the big problem. Pretty busy with other projects and real life, so Inspirations is low priority at this time.

Having time is the big problem. Pretty busy with other projects and real life, so Inspirations is low priority at this time.

No rush, take your time friend! regards!


Getting java.util.ConcurrentModificationException when running bloopInstall, Scala 2.12

Describe the bug
Hello, when executing bloopInstall in a big mono-repo project, mainly Scala, the command fails with the following:
➜  project git:(main) ✗ ./gradlew bloopInstall

Task :module:sub-module:bloopInstall FAILED
FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':module:sub-module:bloopInstall'.
java.util.ConcurrentModificationException (no error message)

I can confirm that with gradle-bloop 1.5.6 this doesn't happen.
Expected behavior
The bloopInstall command exports the gradle build correctly.
Operating system
Linux
Version of Gradle
7.5.1
Version of gradle-bloop
1.5.8, 1.6.0
Version of Bloop
1.5.6

One more information, I believe this error is related to bloop 1.5.6, as it seems to be working with bloop 1.5.5

Thank you, the import will be so slow, for now I'll use 1.5.6 and forget about vs code

Likely the same as https://github.com/scalacenter/gradle-bloop/issues/32 and should be fixed. I don't think there's been a release since.

I can go ahead and cut a release. It's been quite some time.


Running on GCP VM

Hi I setup opendatacam on a virtual machine and I am able to see the video stream and  detection json stream via reverse proxy but for the app I get 500| Internal server error.
Default port mapping is 8080:8080 8070:8070 and 8090:8090, I tried changing it to 8008:8080 but that didn't help. darknet streams are working fine but not sure what needs to be done for the app to work on my local machine.
It will be great if someone can help in this regard.

Hey @yasirderq sorry for the long pause. Could you share some logs to help me pin point the issue.

Closed due to inactivity


get rid of endpoint type indicators

The app stopped paying attention to these some time ago.
Removing them shrinks reports by 3-10%.

I had forgotten that we don't check procspied to match connections by container IP. LGTM


Bluebird.map : fs.access doesn't promisify

Please answer the questions the best you can:

What version of bluebird is the issue happening on?

3.5.0

What platform and version? (For example Node.js 0.12 or Google Chrome 32)

platform: Windows x64
node : v6.10.3

Did this issue happen with earlier version of bluebird?

Don't know but probably yes

The problem :

I am currently working on an ES6 class that have a method called addNewPath.
This method will add paths if only the params are valid and readable.
As you probably know, fs.exists is deprecated so I used the only way I found inside node fs module :  fs.access
The code :
addNewPath(...paths) {
        // the user should provide us at lest a path
        if (paths.length === 0)
            return missingParam();

        let that = this;
        return new PromiseLib(function (resolve, reject) {

            PromiseLib.map(paths, function (path) {
                return access(path, FsConstants.F_OK | FsConstants.R_OK);
            }).then(function () {
                // keep only unique paths
                that.paths = uniq([...that.paths, ...paths]);
                resolve("All paths were added!");
            }).catch(e => {
                reject(e);
            })

        });

    }

The imports :
import {access} from 'fs';
import PromiseLib from 'bluebird'
import {
    constants as FsConstants
} from 'fs'

When I run this code, I got this error message (from the line where I used fs.access)  :
callback argument must be a function

Can you help me to find out a workaround ?
Thanks for your work.
PS: It looks like this issue : https://github.com/petkaantonov/bluebird/issues/418. Same fate ?

Just reopened it to provide you my workaround way :
function promisifiedAccess(path) {
    return new PromiseLib(function (resolve,reject) {
        access(path, FsConstants.F_OK | FsConstants.R_OK, (err) => {
           if (err) reject(err);
           resolve();
        });
    })
}


Add celery_worker and celery_beat services to docker-compose

Change gitlab set up script to work with existing user
In case "houston" already exists, the docker entrypoint script can still
create a personal access token.
Also skip creating the group "test" if the group already exists.

Add celery_worker and celery_beat services to docker-compose
Both celery_worker and celery_beat are clones of the houston service.
The only difference is they don't run the web application, instead
celery_beat runs celery beat which is necessary for triggering periodic
tasks and celery_worker is necessary for running background and periodic
tasks.

@hwindsor docker-compose up -d celery_worker celery_beat should run separate services so there's no need to do docker-compose exec houston celery ... etc anymore.

/rebase

/rebase


chore: update libp2p dep

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #137   +/-   ##
=======================================
  Coverage   91.66%   91.66%
=======================================
  Files           2        2
  Lines          24       24
=======================================
  Hits           22       22
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7805a...e8b257f. Read the comment docs.


Add Cuda 12.5

With update of VS compiler in github actions it now requires 12.5 to compile. Would be great to get support for 12.5
I tried to fork and update, but my ts skills is not adequate :)
My attempt: https://github.com/xnorpx/cuda-toolkit/commit/05dd9b7904ae5e475a0874035d43f372c3db7c9d
  C:\Program Files\NVIDIA GPU Computing Toolkit\CUDA\v12.1\include\crt/host_config.h(153): fatal error C1189: #error:  -- unsupported Microsoft Visual Studio version! Only the versions between 2017 and 2022 (inclusive) are supported! The nvcc flag '-allow-unsupported-compiler' can be used to override this version check; however, using an unsupported host compiler may cause compilation failure or incorrect run time execution. Use at your own risk.

Added in v0.2.16

Thanks!


Bump Spring Boot cross-version to 3.2.0-RC2

RC1 on main and RC2 here fail due to spring-projects/spring-boot#38186


Question about delete action

I would like to know if there is a setting for disabling the delete action?
Thank you

For default actions, we focus on the policies of the model:  https://orchid.software/en/docs/packages/crud/#policies


Dependabot selects incorrect prerelease version for Go

Is there an existing issue for this?

[X] I have searched the existing issues

Package ecosystem
Go
Package manager version
go version go1.22.4
Language version
1.22.4
Manifest location and content before the Dependabot update
https://github.com/bufbuild/buf/blob/e54a2e87034b1679a7117e85c94534bb224a611b/go.mod#L8
dependabot.yml content
https://github.com/bufbuild/buf/blob/e54a2e87034b1679a7117e85c94534bb224a611b/.github/dependabot.yml#L11-L23
Updated dependency
buf.build/gen/go/bufbuild/registry/protocolbuffers/go, from 1.34.1-20240606161333-696c2cfeae8c.1 to 1.34.2-20240610164129-660609bc46d3.1. (see https://github.com/bufbuild/buf/pull/3084)
What you expected to see, versus what you actually saw
It should bump from 1.34.1-20240606161333-696c2cfeae8c.1 to 1.34.2-20240610164129-660609bc46d3.2 (note the final .2). Instead, it bumped from 1.34.1-20240606161333-696c2cfeae8c.1 to 1.34.2-20240610164129-660609bc46d3.1 (note the final .1).
Native package manager behavior
It selects the correct version:
$ go get -u buf.build/gen/go/bufbuild/registry/protocolbuffers/go@latest
go: downloading buf.build/gen/go/bufbuild/registry/protocolbuffers/go v1.34.2-20240610164129-660609bc46d3.2
go: downloading buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.34.2-20240401165935-b983156c5e99.2
go: upgraded buf.build/gen/go/bufbuild/protovalidate/protocolbuffers/go v1.34.1-20240508200655-46a4cf4ba109.1 => v1.34.2-20240401165935-b983156c5e99.2
go: upgraded buf.build/gen/go/bufbuild/registry/protocolbuffers/go v1.34.1-20240606161333-696c2cfeae8c.1 => v1.34.2-20240610164129-660609bc46d3.2

I believe that under the covers, Go modules use the x/mod/semver package, which compares these versions correctly: https://go.dev/play/p/HBimGqCMLPJ
Images of the diff or a link to the PR, issue, or logs
https://github.com/bufbuild/buf/pull/3084
Smallest manifest that reproduces the issue
No response

FWIW, I think what may be going on is that the .split on the prerelease is only assigning the initial section of the version to @prerelease; the .split should probably be limited to only two components, so it's ensured to get everything after the initial -.
irb(main):002:0> version, prerelease = "1.2.3-20201021035429-234234.1".split("-")
=> ["1.2.3", "20201021035429", "234234.1"]
irb(main):003:0> version
=> "1.2.3"
irb(main):004:0> prerelease
=> "20201021035429"
irb(main):007:0> version, prerelease = "1.2.3-20201021035429-234234.1".split("-", 2)
=> ["1.2.3", "20201021035429-234234.1"]
irb(main):008:0> prerelease
=> "20201021035429-234234.1"


feature:  Negative event pattern match

Did you check the docs?

[X] I have read all the lazy.nvim docs

Is your feature request related to a problem? Please describe.
I was looking through a way to add an event which would match against a negative pattern, in other words, to lazy load a spec only when the pattern does not match. However having tried the suggested ways it does not seem to work. While the pattern itself does work as i did try to manually create an autocmd to check if it is triggered.
    local ignore_fts = "*\\(log\\|txt\\|qf\\|help\\|fzf\\|diff\\|git*\\|Neogit*\\|Diffview*\\)\\@<!"

    {
        "nvim-treesitter/nvim-treesitter",
        config = require("user.treesitter"),
        lazy = true, build = ":TSUpdate",
        event = "FileType " .. ignore_fts,
    },

When opening the :Lazy ui however even when i simply start nvim without any file or directory whatsoever, treesitter is reported as loaded.
Describe the solution you'd like
I suppose it is supported, i might be missing something however.
Describe alternatives you've considered
Manually defining the event.
Additional context
No response

Never mind, it seems that opening the :Lazy window itself was triggering the treesitter plugin, since it was not in the ignore patterns, and the lazy popup has a ft.


Added MSSQL Driver and Adapter to README

:heart: :green_heart: :blue_heart: :yellow_heart: :purple_heart:


Not working on macOS

Describe the bug
It looks like after simply following the github wiki, I can't get zmap to work on macOS.
CLI Arguments
zmap -B 10M -p 80 -n 10000 -o results.csv
Oct 10 08:26:25.314 [FATAL] zmap: could not detect GW MAC address for <IP_ADDRESS> on utun2. Try setting default gateway mac address (-G), or run "arp <gateway_ip>" in terminal.

Expected behavior
Expect zmap to port scan and write results to results.csv
Environment:

OS: MacOS Catalina version 10.15.4
Version: zmap 2.1.1 installed with brew

Additional context
I think I'm just dumb. After setting gateway, still issues.
netstat -nr | grep default
default            <IP_ADDRESS>        UGSc           en0

zmap -B 10M -p 80 -n 10000 -G <IP_ADDRESS> -o results.csv

zmap: invalid MAC address `<IP_ADDRESS>'

You need to set the MAC address of the gateway, not the IP address. ZMap operates on L2 not L3. The error provided is correct.

You are absolutely right.
This worked for me
zmap -p 80 -o results.csv --verbosity=5 --disable-syslog -G <MAC_ADDRESS> -i en0


feat: Creating Gardener Cluster CR as part of cluster provisioning

Description
Changes proposed in this pull request:

Creating Gardener Cluster CR as next stage of Provisioning
Validation of labels on provided Runtime CR:
Required labels:

- kyma-project.io/instance-id
- kyma-project.io/runtime-id
- kyma-project.io/region
- kyma-project.io/kyma-name
- kyma-project.io/broker-plan-id
- kyma-project.io/broker-plan-name
- kyma-project.io/global-account-id
- kyma-project.io/subaccount-id

State machine optimisation

Testing:

Unit tests for State machine are not fully implemented
Integration tests are in progress

Related issue(s)
https://github.com/kyma-project/infrastructure-manager/issues/282

Verification update
After some time, GardenerCluster CR transited to Error state (described as:
Status:
  Conditions:
    Last Transition Time:  2024-07-18T12:28:14Z
    Message:               Failed to create secret. Error: secrets "kubeconfig-059dbc39-fd2b-4186-b0e5-8a1bc8ede5b8" already exists
    Reason:                ConditionReasonFailedToCreateSecret
    Status:                False
    Type:                  KubeconfigManagement
  State:                   Error
Events:                    <none>

While the Runtime CR is described as:
Status:
  Conditions:
    Last Transition Time:  2024-07-18T12:09:51Z
    Message:               Runtime processing completed successfully
    Reason:                ConfigurationCompleted
    Status:                True
    Type:                  Provisioned
    Last Transition Time:  2024-07-18T12:10:19Z
    Message:               Gardener Cluster CR is ready.
    Reason:                GardenerClusterCRReady
    Status:                True
    Type:                  KubeconfigReady
  State:                   Ready
Events:
  Type    Reason                    Age   From                Message
  ----    ------                    ----  ----                -------
  Normal  Initialised               38m   runtime-controller  Runtime initialized: kcp-system/kim-md2
  Normal  Pending                   38m   runtime-controller  Shoot is pending: kcp-system/kim-md2
  Normal  Pending                   37m   runtime-controller  Shoot creation in progress: kcp-system/kim-md2
  Normal  ShootCreationCompleted    30m   runtime-controller  Shoot creation completed: kcp-system/kim-md2
  Normal  GardenerClusterCRCreated  29m   runtime-controller  Gardener Cluster CR created, waiting for readiness: kcp-system/kim-md2
  Normal  GardenerClusterCRReady    29m   runtime-controller  Gardener Cluster CR is ready.: kcp-system/kim-md2
  Normal  ConfigurationCompleted    29m   runtime-controller  Runtime processing completed successfully: kcp-system/kim-md2

I would expect the following instead:

KIM will not try to create Gardener Cluster CR for the second time resulting in an error in Gardener Cluster CR
(I'm not sure about this) Even if Gardener Cluster CR will moved from Ready to Error, the status change should be reflected in Runtime CR condition as well (currently it says that it GardneerCluster CR is Ready)

Probably that's the fix https://github.com/koala7659/infrastructure-manager/pull/2/files. However as @koala7659 is on vacation, I will merge this PR and work on a follow-up.


Use Terminal to print output instead of println in the project info command

Current behavior
The project info command is using println to print the command's output, which is a strategy that is being deprecated.
Desired behavior
Instead, the Terminal struct should be used to handle the output of every command.
Implementation details
The following snippet should be refactored:
https://github.com/build-trust/ockam/blob/140a8bd71183754d70ec1e4bc1a5c962062fa0a9/implementations/rust/ockam/ockam_command/src/project/info.rs#L54
You have to use the Terminal struct as follows to print the command output:
opts.terminal
    .stdout()
    .plain(info.output()?)
    .json(serde_json::to_string_pretty(&info))
    .write_line()?;

Some tips for newcomers:

Create a new branch for the issue you are working on (don't push directly to your fork's develop branch)
Run cargo fmt. You can configure the editor to run it automatically everytime a file is saved
Run cargo clippy to make sure the code compiles + follows rust standards/best practices
You don't need to keep your branch updated with develop until there is a merge conflict. If you still want to update it, use git rebase develop instead of gir merge develop

We love helping new contributors! ❤
If you have questions or need help as you explore, please join us on Discord. If you're looking for other issues to contribute to, please checkout our good first issues.

Hi @adrianbenavides I would like to work on this issue

All yours!


Implicit team re-add member after reset

Added a test and changed change membership sig generation to include is_implicit for implicit teams.

Weird CI error there, in kbfs and not kbfs-server: https://ci.keyba.se/job/kbfs/job/master/10180/execution/node/181/log/

Thank you! I'll try to rebase and try again

Nevermind, now it fails with:
2017-08-24 18:09:42.8294536 +0200 CEST util.go:442: [D] - TeamLoader#load2(4823d31c4d465155346a0c3d5f374724) -> appending 1->2: Implicit team operation not allowed: illegal membership change [time=0s] [tags:LT=PCII4wCGbSZ_]
        Error Trace:    team_reset_test.go:372
	Error:		Received unexpected error:
			appending 1->2: Implicit team operation not allowed: illegal membership change

after I try to load team again after the change (silly me for not doing that in the first place :S).

I think I got it right this time. Unfortunately needs a re-review cause the changes are much more broad now. Summarized in 02a6995 commit message:
New API for readding member to a team: TeamReAddMemberAfterReset

It will post the readd change_membership sig, e.g.
{ owners: ["ffd8cddfc91d6aa162ef2dfd571fbe19%6"],
  none: ["ffd8cddfc91d6aa162ef2dfd571fbe19%1"] }

Some changes were needed for this to work:
- memberSet.loadGroup does not skip reset users if storeRecipient is
  false.
- getDowngradedUsers does not return deleted user as a canditate for
  downgrade, so we don't try to get a downgrade lease for the 'none' UV.

Changed the test to try reset twice and try to load team chain on every
step, to make sure it's still correct from client point of view.


docs: fix gif

The cool new gif that captures the gist of Miden can not be rendered with the GitHubPages standard renderer.
The problem here is that Markdown on GitHub.com is rendered with our CommonMark-compatible renderer, but Pages by default uses kramdown. See here https://github.com/github/markup/issues/1215

I think this animation is cool - but it may be too complex for this specific place (but we can probably use it in other places). For this place, I actually thinking of this animation:


Update FileLinkMetricsMaintenanceTask to include metric info for valid file paths broken down by type (i.e. schema name)

Rationale
The related PR added support for a better app user experience for assay imports that includes File fields at the results domain. With that, we want to track a metric counting the valid file paths for these fields. This PR adds that to the existing FileLinkMetricsMaintenanceTask which was already setup to check for missing file paths.
Related Pull Requests

https://github.com/LabKey/platform/pull/5533

Changes

Update FileLinkMetricsMaintenanceTask to include metric info for valid file paths broken down by type (i.e. schema name)
doMissingFilesCheck to only track paths for the per container action (otherwise just tracking counts)


Added footer

This needs to be merged after the other PR as it contains font awesome icons and those are implemented yet.
Resolves #17

Blocked by PR #39.


python,go/adbc/driver/snowflake: returning Snowflake query ID

I'm starting to explore the adbc snowflake driver for python.  Is there a way for the adbc cursor to return the Snowflake query id, like the cursor from the snowflake python connector does, after executing a query?  Or do I have to run
SELECT LAST_QUERY_ID()
after I execute my SQL query?  I'm not seeing anything in the documentation or in the code

You will have to do that for now.
gosnowflake does support this so if someone wants to contribute support for exposing this, that would be welcome. I think it would be:

Add a statement option that when read, gives the last query ID
In the Python bindings for the Snowflake driver, subclass the Cursor class and add a utility method to fetch that option explicitly (just as a convenience)

Ok, it looks like this isn't quite possible in the API we use. If we want to support this, someone will have to make a request upstream to gosnowflake first.
Roughly: we use QueryArrowStream which returns a snowflakeArrowStreamChunkDownloader. Internally QueryArrowStream gets a execResponseData which has the QueryID, however, it does not copy the value to the result snowflakeArrowStreamChunkDownloader and throws it away. So we have no way of getting the query ID.


Panic when network connection is lost

While network maintenance was being performed the following error popped-up:
 thread 'main' panicked at
'called `Option::unwrap()` on a `None` value':
...../sqlx-core-0.5.13/src/postgres/listener.rs:165

Unfortunately I was unable to reproduce this issue in a lab environment. Looking at the code however, I would imagine the culprit is:
https://github.com/launchbadge/sqlx/blob/bd40cc9a2fc4946bfb86d4947f915b16a13ec4b4/sqlx-core/src/postgres/listener.rs#L260

It's likely due to any one of these methods being called immediately after a disconnect: https://github.com/launchbadge/sqlx/blob/main/sqlx-core/src/postgres/listener.rs#L95-L145
An easy fix would look like this:

for .listen() and .listen_all(), be sure to call .reconnect_if_needed().await? first
for .unlisten() and .unlisten_all(), use if let Some(connection) = &mut self.connection instead of self.connection()

They should still delete from self.channels though

Oh, and this should probably be fixed in the Executor methods too: https://github.com/launchbadge/sqlx/blob/main/sqlx-core/src/postgres/listener.rs#L328-L374
.fetch_many() could probably do something like
use futures_util::TryFutureExt;

Box::pin(async move {
    self.reconnect_if_needed().await?;

    Ok(self.connection().fetch_many(query))
}.try_flatten_stream())

While network maintenance was being performed the following error popped-up:
 thread 'main' panicked at
'called `Option::unwrap()` on a `None` value':
...../sqlx-core-0.5.13/src/postgres/listener.rs:165

Unfortunately I was unable to reproduce this issue in a lab environment. Looking at the code however, I would imagine the culprit is:
https://github.com/launchbadge/sqlx/blob/bd40cc9a2fc4946bfb86d4947f915b16a13ec4b4/sqlx-core/src/postgres/listener.rs#L260


Desktop file not running on reboot

(Fedora Workstation 36) I felt like this fix was too small to discuss in a PR so I'm just stating the problem then proposing my solution to help others who may find this. I ran the install.sh then ran
update-desktop-database

to update mime database I think and it worked I can see the desktop file appear in gnome tweaks.
I also had to add python3 infront of the file path in the exec line.

@BinaryGenius if the script in exec line has executable flag (chmod +x) and correct shebang on the first line, the python3 before the path should not be needed. I might be wrong, but if you have time, please try :)


Removing TEST_true check as it has no impact

"EVP_MD_up_ref(md)" function always return value 1 so the condition "if (!TEST_true(EVP_MD_up_ref(md)))" never seems to get TRUE and code "goto err;" will never be executed.
CLA: trivial

Checklist

[ ] documentation is added or updated
[ ] tests are added or updated

This looks more like a problem in EVP_MD_up_ref() since the call to CRYPTO_UP_REF can fail.

This looks more like a problem in EVP_MD_up_ref() since the call to CRYPTO_UP_REF can fail.

CRYPTO_UP_REF function is internally calling atomic_fetch_add function which in case seems to be not getting failed.

CRYPTO_UP_REF function is internally calling atomic_fetch_add function which in case seems to be not getting failed.

CRYPTO_UP_REF has a number of different implementations depending on the platform. One of those implementations is based on CRYPTO_atomic_add which itself has different implementations depending on the platform. The "fallback" implementation for pthreads (used on platforms where there is no atomic support) can fail.

CRYPTO_UP_REF

Yes, I agree there is a need to update CRYPTO_UP_REF as for each of its definition current code is returning 1.

Yes, I agree there is a need to update CRYPTO_UP_REF as for each of its definition current code is returning 1.

My point was that one of the current definitions does not necessarily return 1.

This is not a correct fix. Closing.

This is not a correct fix as explained by @mattcaswell. Closing.

I understand fix is not correct.. But there is a problem in the code mentioned in my first comment which can be corrected until the code for CRYPTO_REF_FREE is not corrected permanently...


daemon, install/kubernetes: fix typo in DNS policy rule unload flag/value doc

Fixes: 708873d06934 ("daemon: allow unloading DNS policy rules on graceful shutdown")
Fixes: f602a58d874e ("install/kubernetes: expose DNS policy rule unload agent flag as helm value")

This is a simple typo fix, one review should be sufficient and smoke tests passed. Only the optional checkpatch workflow failed due to the subject length of the commit message, which is begnin. Marked as ready to merge.


request path contains full URL

This looks like a regression in 1.1.
When I request / through the proxy, the upstream receives:
GET http://<IP_ADDRESS>:8000/ HTTP/1.1

The expected request would be:
GET / HTTP/1.1

hmm this sounds like something i screwed up with #17 that somehow didn't surface in my testing. Let me dig into this more

@ipmb can you verify that this patch works for you too?

Yep it works. :dancer:
Thanks!


React element Refs

It would be good to be able to work with the normal React component refs on elements, since those are quite useful for cases like mounting charting libraries, playing/pausing audio elements, etc.

What about wrapping those on the JS side and then bringing them in using the FFI?
I think I'd prefer to have a well-understood subset of functionality here, and we had enough problems with refs in purescript-react before that I'd rather exclude them if they're only used in a small number of cases.

You mean wrapping whole components that use refs? I'd really not want to.
I use refs fairly frequently in my own code though, but not exposing refs directly and providing a StrMap bound on the instance would be nicer than trying to expose the guts of it.

You mean wrapping whole components that use refs? I'd really not want to.

I mean encapsulating whatever state needs refs in one React component, and then using that from other components which are defined using this library.

Just ran into this.. it'd be a shame to build a whole FFI component for one line of code, but I'm not sure how to fit this into the building blocks we have.
input = react
  { displayName: "Input"
  , initialState: { indeterminate: false }
  , receiveProps: \props state setState ->
      when $ props.indeterminate /= state.indeterminate do
        setState \_ -> { indeterminate: props.indeterminate }
        -- inputNode <- // ReactDOM.findDOMNode(this)
        setIndeterminate props.indeterminate inputNode
  , render
  }

Added a Ref component to our internal library. Might make sense to move it here or another library of utility components, but here it is since I'm not sure when we'll get to that.
https://gist.github.com/spicydonuts/12725096894c8d95431cf0608a5b5b31

In addition to the pattern above, you can also access a the dom node at the root level of your component using the v2 API:
import React.Basic.DOM (findDOMNode)

...
  receiveProps { instance_ } = do
    rootNode <- findDOMNode instance_


C <-> C# interop

Based on questions which was raised in #55 I think it is time to discuss mapping between C types and C# types, which then would be moved to documentation.
Base types

C type
C# type

char
ushort

signed char
short

char *
byte*

const char *
byte

int
int

unsigned
uint

unsigned int
uint

long
long

unsigned long
ulong

float
float

double
double

long double
double

void
void

_Bool
bool

Pointer types in C# would be represented as base type + * except char * which is byte * because we want UTF-8.

I propose a number of changes to this system.

C type
C# type

char
ushort byte

signed char
short sbyte

const char *
byte byte* (this one was just a typo, I think?)

A couple of important types you forgot:

C type
C# type

unsigned char
byte

long long
long

Here, by char, I assume you really mean char type, like char x;, and not a character literal like 'a', which is a different story in C (sizeof 'a' is commonly 4, as you might know, which is even different between C and C++).


[Feature Request]: Download an image from the url

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
I want to add snippets to download an image from an url
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

I'm actually working on gssoc extended. Please provide me with suitable labels.


Update component to adhere to Commodore component best practices

Context
We've documented some best practices for Commodore components regarding how container images and Helm charts should be configured in the component defaults (see https://syn.tools/syn/explanations/commodore-components/container-images.html and https://syn.tools/syn/explanations/commodore-components/helm-charts.html).
The component currently doesn't adhere to the documented best practices.

Helm chart version specifications use the legacy format which may not be supported in future versions of Commodore Renovate (cf. https://github.com/projectsyn/commodore-renovate/tree/master/src/commodore-helm): https://github.com/projectsyn/component-keycloak/blob/a11a34c2b9c3c68c90537727627b4915382d844b/class/defaults.yml#L42-L44
The container images are specified partially in the component defaults: https://github.com/projectsyn/component-keycloak/blob/a11a34c2b9c3c68c90537727627b4915382d844b/class/defaults.yml#L162-L164 https://github.com/projectsyn/component-keycloak/blob/a11a34c2b9c3c68c90537727627b4915382d844b/class/defaults.yml#L301-L302

Proposed changes
Migrate to a component structure which completely adheres to the best practices. This introduces a breaking change because the charts parameter structure will change.
Additionally, to make the Renovate PRs for the resulting structure useful, we'll want to add package rules to group the Helm chart and container image versions for Keycloak and PostgresQL respectively.
Acceptance criteria

The component defaults adhere to the container image and Helm chart best practices
New component version is released

Alternatives
Don't make changes, and accept that this component is different.

Image versions: #206 206


Page sometimes deformats when user presses back button in browser

testing notes

steps to reproduce:

load the archive search
make a change that updates results without reloading the page (any search or filter)
click on a link to navigate away
use browser back button to go back to archive search results

See screenshot. This seems to happen -only sometimes- when you do a keyword search, click on the title to get to the item detail page, and then press the back button. Do we need to build in a "Back" button within the site to return to the results page?

Edit: not only when you do a keyword search. I got this by filtering by collection, clicking on a title and then clicking back.
dev notes

[ ] send appropriate vary header (we have done this on winthrop)

Did steps multiple times with various form changes and it seems to be fine now.


Safari on macOS cant show uploaded image in test image website

I have upload photo but it doesn't display on website in Safari but chrome.
like photo.
!(image)[]

Thanks for the reporting issue, we will fix it in some of the next releases


Add "slow" standard tag

see https://github.com/opentracing-contrib/java-jdbc/pull/99#issue-487826199

You do not need a new semantic convention to add a custom tag. This tag is redundant, you can derive the same from already existing data on the span, e.g. duration.


Provisioning freezes during ansible playbook launch

Provisioning freezes during ansible playbook (method) launch. It doesn't even launch/run the ansible-playbook command.
Any new provisioning requests also gets frozen. This issue exists on Morphy and Lasker.

 It works fine when its just a single provisioning but when multiple VM counts are set, it freezes after the playbook options.

[----] I, [2022-07-12T03:46:21.172005 #309:2abe5625b964]  INFO -- automation: Q-task_id([r821_miq_provision_2088]) Ansible job with ref 44049 was created.

If I restart the Docker instance, the rest of the provisioning continues.

@kbrock Can you take a look at this one?

@Fryguy  @kbrock  This is still persist and it happens when you provisioning more than 1 VM. Playbook executes and provisioning continues when provisioning only 1 VM but we try 2 or 3 VM then the provisioning gets stuck.

This is still an issue. Sometimes ansible job launches and sometimes it doesn't and other jobs ends up as either stuck in active state or ends up pending even if approved.

@kTipSSIoYv what do you see for the playbook stdout?
pp ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job.find_by(:ems_ref => "66694")raw_stdout_json

@agrare Is there a typo in the command? I see a syntax error.
SyntaxError ((irb):12: syntax error, unexpected local variable or method, expecting `end')
..._ref => "66694")row_stdout_json
...                ^~~~~~~~

Updated, you need the .

irb(main):016:0> pp ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job.find_by(:ems_ref => "66694").raw_stdout_json
Traceback (most recent call last):
       15: from bin/rails:4:in `<main>'
       14: from bootsnap (1.11.1) lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
       13: from bootsnap (1.11.1) lib/bootsnap/load_path_cache/core_ext/kernel_require.rb:30:in `require'
       12: from railties (<IP_ADDRESS>) lib/rails/commands.rb:18:in `<main>'
       11: from railties (<IP_ADDRESS>) lib/rails/command.rb:46:in `invoke'
       10: from railties (<IP_ADDRESS>) lib/rails/command/base.rb:69:in `perform'
        9: from thor (1.2.1) lib/thor.rb:392:in `dispatch'
        8: from thor (1.2.1) lib/thor/invocation.rb:127:in `invoke_command'
        7: from thor (1.2.1) lib/thor/command.rb:27:in `run'
        6: from railties (<IP_ADDRESS>) lib/rails/commands/console/console_command.rb:102:in `perform'
        5: from railties (<IP_ADDRESS>) lib/rails/commands/console/console_command.rb:19:in `start'
        4: from railties (<IP_ADDRESS>) lib/rails/commands/console/console_command.rb:70:in `start'
        3: from (irb):15
        2: from (irb):16:in `rescue in irb_binding'
        1: from activemodel (<IP_ADDRESS>) lib/active_model/attribute_methods.rb:429:in `method_missing'
NoMethodError (private method `raw_stdout_json' called for #<ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job:0x000055fe95d4a050>)
Did you mean?  raw_stdout
irb(main):017:0> pp ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job.find_by(:ems_ref => "66694").raw_stdout
""
=> ""

Okay someone who actually knows embedded Ansible is going to have to help you sorry @kTipSSIoYv

@agrare Now the other jobs are running.

What did the stdout show? What changed to make it work?

@kTipSSIoYv do you mean they're working, or the older ones timed out and now the latest is hung

@agrare after running the pp ManageIQ::Providers::EmbeddedAnsible::AutomationManager::Job.find_by(:ems_ref => "66694").raw_stdout command other stuck jobs started to work.

@kTipSSIoYv is that reproducible?

@agrare Yea its reproduceable. Usually when you launch multiple count of servers using a single catalog it gets stuck.

@Fryguy In the latest version of Narjdorf Ansible job isn't launching at all.

Since i ran into this issue when deleting more than one embedded ansible playbook services. I tried also creating two embedded ansible services in the service UI at the same time, which resulted in the above issue. I used the current quinteros-2.1 image from dockerhub.
I tried to decrease the current worker count to 1 and experienced the same issue with only one service, either creating or retireing didnt't matter.
So i increased them again and it appears you always need 1 more manageiq worker than the embedded ansible services you either request or retire at the same time. Since 2 are default, starting 1 embedded ansible job looked fine. To retire 2 ansible services at the same time 3 manageiq worker are needed and so on.
Hence it might be not the embedded ansible implementation, but maybe the queue/worker handling the issue here?


[Bug] The SnarkOS client panics syncing the ledger

🐛 Bug Report
The SnarkOS client panics syncing the ledger with the testnet3:

End: `new` took 836.708µs
2022-09-15T19:35:14.722878Z  INFO Synced up to block 1784 of 24872 - 7% complete (est. 21 minutes remaining)
2022-09-15T19:35:14.722919Z TRACE Requesting block 1884 of 24872
thread 'tokio-runtime-worker' panicked at 'called `Result::unwrap()` on an `Err` value: Invalid block version', /Users/pablo/.cargo/git/checkouts/snarkos-749b83f411366d36/19181b1/snarkos/ledger/mod.rs:323:81
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: JoinError::Panic(Id(2602), ...)', /Users/pablo/.cargo/git/checkouts/snarkos-749b83f411366d36/19181b1/snarkos/ledger/mod.rs:344:22

Steps to Reproduce
clone this repo (in the default branch testnet3) and run:
cargo run --release
Your Environment

snarkOS rev: 19181b1b529cfbc9a5b74ab5bf41fac1bf5cfafe
Rust 1.63
MacOS 12.6

This should be #1873.

Closing as duplicate of https://github.com/AleoHQ/snarkOS/issues/1873.


ANYWHERE we use regexes must pass a timeout

From this GitHub comment
ANYWHERE we use regexes (including docs) must pass a timeout. Regexes that process untrusted input like URLs can be trivial DOS vectors.
I added the following to my doc
> [!WARNING]
> When using <xref:System.Text.RegularExpressions> to process untrusted input, pass a timeout. A malicious user can provide input to `RegularExpressions` causing a [Denial-of-Service attack](https://www.us-cert.gov/ncas/tips/ST04-015).

cc @guardrex  @scottaddie
Should I make the preceding an include?

@Rick-Anderson I think so on the INCLUDES. Do you want me to work URL Rewriting and RP conventions as "addresses" this issue? There are perhaps another couple of spots, but those aren't in topics that I wrote.

@guardrex just list the topics that need the warning, I can update them.

I think ... IIRC 🤔 ... they are ...

Routing, but you have that here.
Razor Pages Conventions - https://docs.microsoft.com/en-us/aspnet/core/razor-pages/razor-pages-conventions?view=aspnetcore-3.1
URL Rewriting - https://docs.microsoft.com/en-us/aspnet/core/fundamentals/url-rewriting?view=aspnetcore-3.1

I don't recall others. Regex is apparently in jQuery, but I guess we're not warning off of that.


Windows contains older version of std filesystem (still experimental)

Thanks @bfjelds for the contribution.
I have 2 questions regarding filesystem on Windows:

The MSDN filesystem page shows a v1 namespace under the filesystem namespace: using namespace std::experimental::filesystem::v1;. Do you know if this is still necessary (we're targeting VS2015 update 3 and MSVC 19.0.24215.1 at the moment) ?
Is including <filesystem> necessary of is <experimental/filesystem> enough ? I see that we're including only the latter in other places of the codebase that we will need to update accordingly if Windows requires to include both.

I'll let @wjwwood review this as well as he's been the one implementing this filesystem helper.

These are great questions...I was focused on getting pluginlib to build 8n the context of implementing laser_filters, but was using VS2017.
I'll investigate further in about a week and see if I can't get some definitive answers :)

The v1 is an inline namespace (new to me!) ... if we wanted to refer specifically to v1, we could, but it isn't required.
<experimental/filesystem> is a wrapper around at this point, so either would work.  I went with experimental/filesystem to be consistent with the namespace.
This was all verified on VS2015 Update 3 and VS2017.

I rebased this branch and added the change I suggested regarding the version check on this branch https://github.com/ros/pluginlib/tree/ros_ros2_mikael.
@bfjelds would you mind confirming that this will allow you to build your plugins ? If so I'll push the changes to this branch and merge it

Confirmed that it builds...looks great, thanks!!


Matrix multiplication support

Edit: outdated, see https://github.com/ivarflakstad/metal-rs for current state.
Leaving open for visibility.
Hey! Gave this a go.
Output from running cargo run --release --example mps-matrix-multiplication --features=mps
Correctness:
[=================================================] ✅

Performance:
Generating input matrices: (f32 4096x4096 and f16 4096x4096)
Running with transpose left: false, transpose right: false, alpha: 1, beta: 0
[=================================================] ✅
Avg GFLOPS: 2714.017354808345
Total time: 2.534734497s
Avg time: 50.694689ms

Running with transpose left: true, transpose right: false, alpha: 1, beta: 0
[=================================================] ✅
Avg GFLOPS: 2544.2273256244875
Total time: 2.702094294s
Avg time: 54.041885ms

Running with transpose left: false, transpose right: true, alpha: 1, beta: 0
[=================================================] ✅
Avg GFLOPS: 2696.778482443825
Total time: 2.550065042s
Avg time: 51.0013ms

Running with transpose left: false, transpose right: false, alpha: 0.5, beta: 0
[=================================================] ✅
Avg GFLOPS: 2668.0019304379844
Total time: 2.577410417s
Avg time: 51.548208ms

Running with transpose left: false, transpose right: false, alpha: 1, beta: 0.5
[=================================================] ✅
Avg GFLOPS: 2667.1376704607605
Total time: 2.578379166s
Avg time: 51.567583ms

@cwfitzgerald (Sorry for the ping if you're not the correct person).
We're iterating quite a bit on this here -> https://github.com/ivarflakstad/metal-rs
We would love some feedback if upstreaming here makes sense or not.

Fair enough 😊
Maybe you know who does?

@kvark Do you know who might be involved with metal-rs?

@Wumpf  Maybe ?
After having matured a bit this and implemented the Matrix in https://github.com/huggingface/candle/ I feel like this PR should be trimmed down to only get the MPSMatrix support and remove the rest of the sugar (being more aligned with the rest of the crate).
Ofc having maintainer advice would be helpful.
Also in order to be able to publish on our side, we're likely going to fork metal-rs for the time being to have access to those objects.
We might return to metal-rs once we get rid of MPSMatrix dependency (if we can using metal-flash-attention, which seems faster, but currently isn't  as widely portable as MPSMatrix since it doesn't work on first gen m1).
Either that or when this PR gets included.


Issue with record input type containing methods

Is there an existing issue for this?

[X] I have searched the existing issues

Describe the bug
Getting HotChocolate.SchemaException when there is a record with Methods.
I expect HotChocolate to ignore methods contained in InputTypes.
Steps to reproduce

Create record containing methods
Use the record as an InputType for a QueryType
Exception thrown when schema is being built

Relevant log output
HotChocolate.SchemaException: For more details look at the `Errors` property.

1. Unable to cast object of type 'System.Reflection.RuntimeMethodInfo' to type 'System.Reflection.PropertyInfo'. (HotChocolate.Types.InputObjectType<Stats.StatsFilterInput>)

Source: HotChocolate.Types
StackTrace:
   at HotChocolate.Configuration.TypeInitializer.DiscoverTypes()
   at HotChocolate.Configuration.TypeInitializer.Initialize()
   at HotChocolate.SchemaBuilder.Setup.InitializeTypes(SchemaBuilder builder, IDescriptorContext context, IReadOnlyList`1 types)
   at HotChocolate.SchemaBuilder.Setup.Create(SchemaBuilder builder, LazySchema lazySchema, IDescriptorContext context)
   at HotChocolate.SchemaBuilder.Create(IDescriptorContext context)
   at HotChocolate.SchemaBuilder.HotChocolate.ISchemaBuilder.Create(IDescriptorContext context)
   at HotChocolate.Execution.RequestExecutorResolver.<CreateSchemaAsync>d__15.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at HotChocolate.Execution.RequestExecutorResolver.<CreateSchemaServicesAsync>d__14.MoveNext()
   at HotChocolate.Execution.RequestExecutorResolver.<GetRequestExecutorNoLockAsync>d__11.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at HotChocolate.Execution.RequestExecutorResolver.<GetRequestExecutorAsync>d__10.MoveNext()
   at System.Threading.Tasks.ValueTask`1.get_Result()
   at HotChocolate.Execution.RequestExecutorProxy.<GetRequestExecutorAsync>d__15.MoveNext()
   at HotChocolate.AspNetCore.HttpPostMiddlewareBase.<HandleRequestAsync>d__9.MoveNext()
   at HotChocolate.AspNetCore.HttpPostMiddlewareBase.<InvokeAsync>d__8.MoveNext()
   at Microsoft.AspNetCore.Builder.EndpointRouteBuilderExtensions.<>c__DisplayClass20_0.<<UseCancellation>b__1>d.MoveNext()
   at Microsoft.AspNetCore.Routing.EndpointMiddleware.<<Invoke>g__AwaitRequestTask|6_0>d.MoveNext()
   at Microsoft.AspNetCore.ResponseCaching.ResponseCachingMiddleware.<Invoke>d__10.MoveNext()

### Additional Context?

_No response_

### Product

Hot Chocolate

### Version

13.0.0-preview.73

Do you have a repro for this? a small project that we can use to see what the issue is?

@michaelstaib Sorry for the late reply.
I should have provided an example, Here it is and if a full reproduction is needed I might be able to provide it at a later date.
But basically what I'm assuming is that it's throwing the exception because the input has methods.

[ExtendObjectType(typeof(Queries))]
public class Stats
{
    public IQueryable<EntityStat> GetStats(AppDbContext db, StatsFilterInput input) => input.ApplyFilter(db.Set<EntityStat>());

    public record StatsFilterInput(string?[]? Labels, DateTimeOffset? From, DateTimeOffset? To)
    {
        public IQueryable<T> ApplyFilter<T, TK>(IQueryable<T> q)
            where TK : notnull
            where T : Entity<TK>, IHasLabels
        {
            return ApplyLabelsFilter(ApplyDateFilter<T, TK>(q));
        }

        public IQueryable<T> ApplyDateFilter<T, TK>(IQueryable<T> q)
            where TK : notnull
            where T : Entity<TK>
        {
            /*  Apply custom filter */
            return q;
        }

        public IQueryable<T> ApplyLabelsFilter<T>(IQueryable<T> q)
            where T : IHasLabels
            => Labels is { Length: > 0 } ? /*  Apply custom filter */ q : q;
    }
}

This should be fixed already with the newest preview. Can you retest and close the issue if it's fixed. Otherwise report back.

Yes, It's been fixed already.


Manager.get_or_create handles IntegrityError

Protection for the concurrently world

Well it seems like you change peewee-async for you rare case. And you force to use transaction all users of peewee in get_or_create method which is not good. I doubt that somebody needs it you can just use it on your own.  Looks like it is exactly that you need.


Reduce size of libnimble (2nd try)

Prior to release of 0.6-7, we experimented with a script called from CppCode/GNUmakefile that copied the R installation's Makeconf,  modified it by removing -g flags, and then used it for building libnimble.  This massively reduced the size of libnimble (.a or .dll) and hence the whole package binary.
Unfortunately the modified Makeconf remained in CppCode when a binary was built for distribution, which means that R's configure-generated system-specific Makeconf from the build machine would have persisted in CppCode in our binary distribution.  Although this was easy to solve, no one had bandwidth to deal with it at the time, so we did not include any of this in 0.6-7.
Now I'm making a try at cleaning up the approach.  In each of the two make targets in GNUmakefile, the last line now invokes another script to remove the local Makeconf.  This prevents it from being included in a binary built for distribution.
@paciorek will you give this a try?

Apparently debugging information can reduce performance if the compiler withholds optimizations in order to keep debugging information sane: https://stackoverflow.com/questions/24117063/is-a-program-compiled-with-g-gcc-flag-slower-than-the-same-program-compiled-wit

Was Dirk's suggested approach relevant here?
http://dirk.eddelbuettel.com/blog/2017/08/14/#009_compact_shared_libraries
http://dirk.eddelbuettel.com/blog/2017/08/20/#010_stripping_shared_libraries
I'm putting on my todo to do various checks on this.

I'm not sure if Dirk's approaches are relevant or not.  Our problem is libnimble, which is built in CppCode by our config process outside the typical R steps that do compilation in src.  We could try the -Wl,-S in the Makevars in CppCode.  I don't know if that would succeed more universally or if stripping -g manually would do so.  I think in a normal R build process one wouldn't want to consider the latter because it would involve a customized set of build steps managed by a configure which would be a pain to set up... except we are in that situation anyway.  But by all means feel free to experiment with other solutions.

Just tried rhub. I seem to get the same Windows and CentOS issues as before when we tried this July 26 (issue #516, issue #515).
https://builder.r-hub.io/status/nimble_0.6-7.tar.gz-b842992dc7144d93b67c1738775fe861
https://builder.r-hub.io/status/nimble_0.6-7.tar.gz-6473f13259a645c0aa49e73c61fbc53c

One other comment, in the case where we don't strip out -g flags, we are seeing a growth in package size that seems primarily related to libnimble.
0.6-5: 12 MB on my Ubuntu machine
0.6-6: 14 MB
devel: 22 MB
Stripping the -g of course helps a lot, but just wanted to flag this in case worth further investigation.

@paciorek I made one small change that is worth trying.  Instead of replacing "-g" with "", we should replace "-g " with " ", because there could be an option "-g<more_text>".
It is possible this will alleviate an unintended corruption of Makeconf.
Beyond that, I don't know what to do about the problems if they are caused by removing "-g".  I am not sure but I think Dirk's suggestion of adding a flag (-Wl,S) is a platform-specific flag, but we need a platform-independent solution.  The "-g " might not be platform-independent, but my hope is that if it appears it means the same thing, and if it doesn't appear, then the stripping operation will do nothing.
Otherwise I'm not sure what to do.  Maybe check for certain common compilers for which we can safely manipulate the Makeconf and otherwise do nothing?  But I hate to start building in compiler-specific behavior.

The errors I saw yesterday seemed to be the same issue as we saw in July - errors resulting from the build machine's Makeconf being used on the machine where the install was being done. But of course avoiding that situation was what your recent fixes were supposed to deal with. So I'm confused.
Could you and @NLMichaud test the build process on a Windows machine? That and CentOS were where the problems were arising.

I see at least one source of why this caused problems on Windows.  There may be more to it, but anyway what I did is disable the removal of "-g" on Windows.  It doesn't seem to make a ridiculously big libnimble_x64 anyway. @NLMichaud can you try installing from this branch on your Windows machine?

I got intrigued so spent a bit of time on the CentOS issue. Somehow a Makeconf is being put into CppCode at the time of R CMD build. So that explains why the rhub problem is happening - it's getting the Makeconf from my Ubuntu machine.
I just spent a chunk of time figuring out what Duncan told us back in July:
"The call to R CMD build calls the cleanup script. That in turn calls make in inst/CppCode and the GNUmakefile automatically creates the Makeconf.
I believe if inst/CppCode/Makeconf is actually wanted, it should be created at configure time."
Alternatively Duncan's suggestion 7/26/17 was:
file.copy(packageMakeconfFile, 'Makeconf', overwrite = TRUE)
So I think we should do one or the other. The idea of creating the Makeconf via customizeMakeConf.R at configure time seems cleaner than passing around a problematic Makeconf with the package tarball and then overwriting. I think we could do it at line 199 of configure.ac. Have to run for now...

Thanks.  I'll try setting it up do be done at configure time.  That point about R CMD build invoking make clean had slipped past me.

This might reveal my ignorance about configure...
Why don't we just run the customizeMakeConf.R directly from configure rather than invoking Make, which then runs customizeMakeConf.R?

OK, I've implemented a system driven from configure.  One part is yes, as you suggested, running customizeMakeconf.R from configure.  I did this via setting up a separate GNUmakefile_customizeMakeconf to run this script and then later to remove the local Makeconf.  But there is another step, which is that a line in the regular CppCode/GNUmakefile needs to include either the local Makeconf or R's default Makeconf.  So I made a CppCode/GNUmakefile.in from which configure generates CppCode/GNUmakefile with the proper line.
I added an option --enable-debugging to allow regular debugging flags to go through as provide by R.  This is ignored on Windows.
To test it: R CMD install --configure-args="--enable-debugging" nimble_0.6-7.tar.gz
I also modified configure.win so it will generate CppCode/GNUmakefile but never use the customization step.  Actually, that customization step might work on Windows now, but it doesn't seem necessary since debugging information appears to be disabled by default on Windows, at least on mine.

Ok, making progress. After fixing a typo (so please pull the latest on the branch), the CentOS install works via rhub.
On Windows we're still seeing a failure - it fails to build libnimble_x64.a:
https://builder.r-hub.io/status/nimble_0.6-7.tar.gz-9fbd5c64c48e4308af36e54b5ccc6a2a
In contrast under devel, libnimble_x64.a is built:
https://builder.r-hub.io/status/nimble_0.6-7.tar.gz-145db7ab79be41d8a932329a6a4be20c

I'm fairly puzzled by the Windows failure.  The configure.win script should render the GNUmakefile and subsequent processing essentially identical to what was on devel.  Also I can't reproduce the error.  I did remove one possibly extraneous / from a path.  Maybe that mattered.  If it passes tests, do you want to try it on rhub?

Well, the Windows build on r-hub looks ok now. So I think we're ok now.

Well, the Windows build on r-hub looks ok now. So I think we're ok now.


Add loadSessionWithoutDispatching to type definitions

loadSessionWithoutDispatching is a public method on Botbuilder but not added to the types, so it throws a type error when called

Closing this PR because the code for this repository has been moved to https://github.com/Microsoft/BotBuilder-V3  If you think this PR is still relevant, please re-submit on the new repository.


Updated Docs/Added Build Script

Added API Docs
Added $[taskcat_foo] docs and examples
Update color scheme
Added do_docs_generate.sh for easy integration into release pipelines

https://aws-quickstart.github.io/taskcat/docs/apidocs/taskcat/index.html#taskcat.Config.create
Your local paths are making it into the API docs

The docstrings in the generated API docs need some readability help.

Latest iterations reflected in:

https://aws-quickstart.github.io/taskcat/index.html

/do-e2e-tests


[Markdown] - Jest SyntaxError: Invalid or unexpected token

Issue Description

The markdown package imports CSS assets for matching githubs's markdown. The import causes jests testing to fail with the following error.
  ● Test suite failed to run

    /Users/user/terra/terra-core/packages/terra-doc-template/node_modules/terra-props-table/node_modules/terra-markdown/node_modules/github-markdown-css/github-markdown.css:1
    ({"Object.<anonymous>":function(module,exports,require,__dirname,__filename,global,jest){@font-face {
                                                                                ^

    SyntaxError: Invalid or unexpected token

      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runner/node_modules/jest-runtime/build/script_transformer.js:305:17)
      at Object.<anonymous> (packages/terra-doc-template/node_modules/terra-props-table/node_modules/terra-markdown/lib/Markdown.js:19:1)
      at Object.<anonymous> (packages/terra-doc-template/node_modules/terra-props-table/lib/PropsTable.js:20:22)

The CSS files should already be proxied in the jest config but that doesn't seem to solve the issue:
https://github.com/cerner/terra-core/blob/master/jestconfig.json
https://facebook.github.io/jest/docs/en/webpack.html#mocking-css-modules
Issue Type

[ ] New Feature
[ ] Enhancement
[X] Bug
[ ] Other

Expected Behavior

Jest tests should be unaffected from assets.
Current Behavior

Jest tests importing a reference to a file containing terra-markdown will fail with the error shown above.

Steps to Reproduce

Import terra-markdown into a component
Import the component into a Jest test. import Component from '../../src/Component'
Run the jest tests for the package.
Observe the tests fail with the error posted above.

The main issue is that our Jest configuration only mocks out files that explicitly end with .css or .scss. For this component, the styles are imported like this.
import 'github-markdown-css';

Jest doesn't know how to directly import a css file if it doesn't have an explicit extension, so it either has to be mocked like this in your package.json file (https://github.com/cerner/terra-dev-site/blob/master/package.json#L36), or terra-markdown needs to be refactored so that it pulls in the css file as opposed to the main entry point of github-markdown-css.

I'm not that happy with the solution I provided, so I'm going to modify terra-markdown to import straight css to match our mocks. Essentially, this will be our import
import 'github-markdown-css/github-markdown.css';


Clic Action on a received notification

Hi!
We want to run a windev mobile function from a handler declared as ObjectiveC in the xCode at the click of a notification received from OneSignal. Note that the NotificationOpenedIOS function call a Windev Mobile procedure. The problem is that when user a user click on a notification, the application crash at this point on that function IExternalCall* call = AllocExternalCall(0x18ee67c624224f33ll,1);
What i'm doing wrong? Thank you very much!
in WDAppDelegate.mm
#include "WDObjectiveC.h"
#import "WDAppDelegate.h"
#import <OneSignal/OneSignal.h>

(BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
bBackground = NO;
[self RunApplication :launchOptions];
[OneSignal initWithLaunchOptions:launchOptions appId:@"xxxx" handleNotificationReceived:nil handleNotificationAction:^(OSNotificationOpenedResult *result) {
  // This block gets called when the user reacts to a notification received
  OSNotificationPayload* payload = result.notification.payload;
  if (payload.additionalData) {
      NotificationOpenedIOS(payload.additionalData[@"WX_PROP_CONTENU"]);
  }

} settings:@{kOSSettingsKeyInFocusDisplayOption:@(OSNotificationDisplayTypeNotification),kOSSettingsKeyInAppAlerts:@false,kOSSettingsKeyAutoPrompt:@false}];

return YES;
}
in WDObjectiveC.mm
class INativeCall
{
public :
virtual void** Params()      = 0;
virtual void   Return(void*) = 0;
};
class IExternalCall
{
public :
virtual void	Push	(int,void*,uint32_t) = 0;
virtual void*	Call	() = 0;
virtual void	Release	() = 0;
};
IExternalCall* AllocExternalCall(uint64_t,int);
int NotificationOpenedIOS(NSString* p0)
{
//The application crashed here
IExternalCall* call = AllocExternalCall(0x18ee67c624224f33ll,1);
call->Push(0,&p0,16);
int r = (int)call->Call();
call->Release();
return r;
}
In WDObjectiveC.h
#ifndef WDObjectiveC_h
#define WDObjectiveC_h
#include <stdint.h>
#import <Foundation/Foundation.h>
#import <UIKit/UIKit.h>
#import <OneSignal/OneSignal.h>
int NotificationOpenedIOS(NSString*);
#endif /* WDObjectiveC_h */

Hi @guilabonte , Could you share a repo with your code?

I'm sorry, I can't, making my source code publicly available goes against my company's Privacy Policy. There is some code source I can post here to help my cause.

If you could share it with me privately with my email on my profile, i'd might be able to help. Otherwise, it would be very hard to do so without reproducing your issue.


Better solution for #15

margin: auto on the vertical axis works on IE11 if the flex container has align-items: flex-start. This provides safe centering and is thus a better solution.

In my version vertical centering works without align-items: flex-start on parent container. What do you mean about "safe centering"?


[FEATURE] Annotation support

Add support for annotations:

@addMethod(Class)
@replaceMethod(Class)
@replaceMethod
@wrapMethod(Class)

Things to do:

[x] Add annotations to the AST
[x] Add syntax highlighting for annotations
[x] Add annotated symbols
[x] Handle creation of annotated symbols
[x] Handle the "wrappedMethod" identifier thing
[x] Handle "go to" for annotated
[x] Handle hover for annotated
[x] Handle document symbols for annotated

Added diagnostics:

[x] invalid-annotation
[x] invalid-annotation-placement
[x] missing-annotation-argument
[x] incompatible-annotation
[x] global-scope-var-decl
[x] same-content-annotation

Added diagnostics:

[ ] invalid-annotation
[ ] invalid-annotation-placement
[ ] missing-annotation-argument
[ ] incompatible-annotation
[ ] global-scope-var-decl
[ ] same-content-annotation

Shipped in #43


Playback restarts without user interaction after a while

Issue type
Incorrect behavior
Description of the problem
Our testers reported a strange behaviour: The previous playback in paused mode, restarted without a user action.

And one time it starts playing by magic, the mobile was on the table and starts playing. My phone was located at the table and starts playing I was 3m away. I will have an eye on it.

Auto start playing... I had this strange behavior several times. I always thought it was my fault, by touching my AppleWatch which started the playing. If you do not have an AppleWatch, it becomes interesting...

I added similar issues few weeks ago. A livestream (RTS La 1ère) in pause mode, restarted I don't know how, in the pocket.
Environment information

Application version: 3.1.0 or more
iOS version: users reported on iOS 13.x
Device: iPhones

We should get more information, like Bluetooth connected devices, or other applications playing sounds or videos. It could be related to Audio Session Interruptions.
Reproducibility
Difficult to reproduce
Steps to reproduce
It would be nice to find a way to reproduce it.

I can see the same behavior on iPhone Xr for video and audio playback. Restarting playback happens every time the iPhone is unlocked for the first time in the day near the Plantronics Bluetooth headset that is on standby on the cradle. The iPhone is not connected to the headset at this time. However, I suspect that information is then exchanged between the devices because the iPhone immediately uses the headset as an audio input and output device as soon as it is removed from the cradle.
I hope this helps to get to the source of the problem.

I hope this helps to get to the source of the problem.

Thank you very much for your input. I'll have a look at BT headsets as well.
I also identified an issue with network interruptions, which explains most complaints we receive since iOS 14 was released.

@GrimbiXcode I don't have the kind of headset model you have, so I tested with my own Bluetooth devices (AirPods and Bose QC II). The behavior I usually expect is correct:

Disconnecting the Bose headset or putting AirPods back into their case pauses playback.
Putting AirPods or connecting the Bose headset afterwards does not automatically resumes playback.
Unlocking or waking up the phone in presence of any of these devices does not resume playback either.

I experienced the same behavior with Apple Music app (which I use as reference in such cases).
I therefore conjecture that the unexpected restarts your encountered might be related to the problem mentioned above. This problem leads to playback restarting in case of network drops, maybe this is what happens in your case as well at this very specific time in the day.
We'll deliver a fix for the unexpected restarts in the next version 3.1.4. I invite you to see whether you still experience this issue with this version.
Thanks again for your feedback, we'll keep an eye on it.


Don't expose metrics on production port

/metrics endpoint is now exposed via port 9191 only. This closes #13.
Remove some duplicate code in case of /metrics request.
Reorder if clause to match as early as possible.

Okay but separating the port from 5555 to 9191 doesn't provide any extra security or auth (now anyone simply fetch the metrics from 9191), does it?

One would simply not expose port 9191 to the outside world. So only cluster internal systems (like prometheus) can get those metrics.

okay fine, that should be documented (readme.md?) and it should also be mentioned that this security method only works if the fetching client (e.g. prometheus) is not "outside".


'Make use of x' or 'use x', but not 'make use x'

Before requesting or performing a merge in upstream:

[X] Verify that your pull request is following our PR quality criteria (items that apply to All and Learn):
https://review.learn.microsoft.com/help/contribute/contribute-how-to-write-pull-request-quality-criteria?branch=main
[X] Verify your PR has a useful title that reflects what it is for.

As noted in the Readme, we don't accept pull requests into this repository. If you would like to submit feedback about learning content, please use the feedback link on the page on learn.microsoft.com.

As noted in the Readme, we don't accept pull requests into this repository. If you would like to submit feedback about learning content, please use the feedback link on the page on learn.microsoft.com.


Question regarding carrier-grade NAT

Hello, I'd like to ask if support for Carrier-grade NAT and PCP are included in this implementation. I'm asking this because I've been trying to use Open.NAT to port-forward a device that I own and the external IP I'm getting from Open.NAT is different from the one I'm getting if I search for my IP in a browser. The uPnP rule is added to my router, but the port seems closed ( It probably has to do with the two IPs being different, which prompted me to ask for Carrier-grade NAT).
Any ideas on how to counter this? (Perhaps the ISP does something different than carrier-grade NAT, but it's 100% sure that the WAN IP the device has is different than the public IP the world is seeing)

No sure I understand the question. Are you asking if you can open a port in somebody else's routing infrastructure as your ISP or your ISP's ISP? In that case the answer is: no, you can only operate on your own infrastructure components.

I just found that in some cases, the public IP and the WAN IP are different. The WAN IP of my computer is a private one and I read that Carrier-grade NAT is probably behind. Though port-forwarding works, the computer is not accessible through the internet since it's behind a private WAN. I read that the PCP (Port Control Protocol) or its predecessor the NAT-PMP could solve this problem and I posted to ask if anyone knew about this problem.
In computers that don't hide behind a private WAN, everything works fine of course.


overflow issue with the recent visibility change

fixed by https://github.com/dart-lang/dart-pad/commit/ebe31c31aea098496100519254a9fc16126e67e2


BlueprintCircuit should build whenever data is required

Coming from https://quantumcomputing.stackexchange.com/questions/13937/why-is-circuit-inverse-not-working-for-efficientsu2 I think users expect that BlueprintCircuit are automatically built when internal _data is required. This happens in same situation (like with print) but not always (like with inverse):
This works:
var_form = EfficientSU2(6, entanglement="linear")
print(var_form)

This raises TypeError:
var_form = EfficientSU2(6, entanglement="linear")
var_form.inverse()

It seems like a reasonable expectation to me that _build should happen always that  _data is required but not there yet.

Going through QuantumCircuit methods i only see compose and inverse using _data without BlueprintCircuit asserting a previous call on _build.

This used to work, therefore tagging as bug


setting a different direction indexes is impossible

CouchDB with Hyperledger fabric seems not support setting a index with multiple fields with different directions.
Expected Behavior

I think CouchDB supports multiple directions find and indexing
Current Behavior

I cannot make complex index with two fields, one direction is asc and another is desc.
This is my stackoverflow question
Possible Solution

Steps to Reproduce (for bugs)

Context

I need to complex sorting logic to my hyperledger application to implements different direction sorting supported by other NoSQL like Mongodb.
Your Environment

Version used: 2.1.1
Browser Name and version: Chrome
Operating System and version (desktop or mobile): Hyperledger fabric(1.2) couchDB
Link to your project: n/a

Hi, That's correct, CouchDB indexes only support a single sort order, hence the accurate error message you received.


Allow AppSpecs to define a custom LockoutPanel component

Hoist P/R Checklist
Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

[x] Caught up with develop branch as of last change.
[x] Added CHANGELOG entry, or determined not required.
[x] Reviewed for breaking changes, added breaking-change label + CHANGELOG if so.
[x] Updated doc comments / prop-types, or determined not required.
[x] Reviewed and tested on Mobile, or determined not required.
[x] Created Toolbox branch / PR, or determined not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

Thanks for taking a look! Re: elementFromContent - I didn't use it because we weren't modifying the props, but I agree that there's no reason not to use it and that it gives us a bit more flexibility. I've updated the branch.

Thanks for taking a look! Re: elementFromContent - I didn't use it because we weren't modifying the props, but I agree that there's no reason not to use it and that it gives us a bit more flexibility. I've updated the branch.

Great thanks - appreciate it.  I realize that the jsdoc for this and the preexisting idlePanel config should both likely be updated to remove the Class type - looking yet again at the react types to see if there is a better option I feel comfortable taking, but will merge this either way. 👍


Fleet UI replaces + with   in user email address

What version of fleet are you using (fleet version --full)?
I'm using the docker image kolide/fleet:2.0.0
What operating system are you using?
I'm using the docker image kolide/fleet:2.0.0
What did you do?
Added a user with an email of<EMAIL_ADDRESS>What did you expect to see?
The user's email to be<EMAIL_ADDRESS>What did you see instead?
The user's email to be foo<EMAIL_ADDRESS>Using the + feature of gmail is very useful for any automation users.

Are you using the web UI? Does this reproduce in 2.0.2? I was able to add users with + in the email.

I haven't tried with 2.0.2 yet. But, I was able to determine that the issue came from the parameters that were populated in the url on sign up. My staging environment is stuck with a space, but for my production environment, I replaced the + in the url with a url encoded plus and everything worked.
For some reason, I was not able to change the email address when it had a space in it. Every time I tried to update it, it appeared to work until I reloaded the page. But, I also haven't spent much time on this.

I tried to reproduce in the initial signup flow as well and found that I could create a user with + in the email. I'm going to close this issue, but can reopen if you find it still reproduces for you in 2.0.2.
If upgrading to 2.0.2 doesn't allow you to fix the stuck user through the UI, please consider doing an update to the users table in MySQL.


GeoJSON + Pop-up data additions

Add attractions hours, if applicable
Add DECC contact information and hours

Added attraction hours, see commit 8f07a000bae7b19aa9e83b80970599d0887b4ff5

Added DECC hours and website, see commit 692999636bec91aa8c5a443f830bae3403a5c752


sublime-music: 0.11.10 -> 0.11.11

This upgrade includes a switch from setuptools to poetry for the build. It also converts to using the test suite provided by the Sublime Music upstream project rather than just the import check.

Motivation for this change
https://gitlab.com/sublime-music/sublime-music/-/releases/v0.11.11
Things done
$ nix-shell -p nixpkgs-review --run "nixpkgs-review rev ad6389e618987a29371cb5e506208400248868b9"
...
[nix-shell ...] $ sublime-music

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@albakham would you be able to review this as well?


Universal Group Player plays media but not powered on

What version of Music Assistant has the issue?
2.0.0b106
What version of the Home Assistant Integration have you got installed?
2024.2.0
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
When playing media through a Universal Group Player after upgrading to 2.0.0b106, the media plays but the player group isn't powered on. This means that although music is playing, no artist/song information is displayed in the front-end of music assistant or displayed on the associated media_player entity. If you power on the group, nothing appears to happen. However, if you power on the group via the media_player entity, it does seem to then power on the group and associated song/artist info is shown.
How to reproduce

Ensure all players are turned off
Create a Universal Group Player and add two slim proto players
Power on the Universal Group Player, notice that the devices are powered on but the group isn't
Play media on the Universal Group Player. Notice that music plays, but no song/artist info is shown
Check the players and see that the Universal Group Player is still powered off. Try powering it on again and refresh the page - it stays off.
Power on the group via the media_player entity, notice it now powers on and song/artist info is shown

Music Providers
Spotify
Player Providers
Universal Group Player, Slimproto
Relevant log output
`2024-03-13 11:21:13.553 INFO (MainThread) [music_assistant] Starting Music Assistant Server (d04764398e1f48bba45fa6c07719f84e) version 2.0.0b108 - uvloop: False
2024-03-13 11:21:13.561 INFO (MainThread) [music_assistant.cache] Initializing cache controller...
2024-03-13 11:21:13.570 INFO (MainThread) [music_assistant.webserver] Starting server on  <IP_ADDRESS>:8095 - base url: http://<IP_ADDRESS>:8095
2024-03-13 11:21:13.654 INFO (MainThread) [music_assistant.music] Using a sync interval of 180 minutes.
2024-03-13 11:21:13.827 INFO (MainThread) [music_assistant.streams] Detected ffmpeg version 5.1.4 with libsoxr support
2024-03-13 11:21:13.827 INFO (MainThread) [music_assistant.streams] Starting server on  <IP_ADDRESS>:8096 - base url: http://<IP_ADDRESS>:8096
2024-03-13 11:21:14.528 ERROR (MainThread) [asyncio] Task exception was never retrieved
future: <Task finished name='Task-55' coro=<ArtistsController.add_item_to_library() done, defined at /usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/media/artists.py:60> exception=InvalidFieldValue('provider_mappings', set[music_assistant.common.models.media_items.ProviderMapping], {'item_id': '500', 'provider_domain': 'library', 'provider_instance': 'library', 'available': True}, <class 'music_assistant.common.models.media_items.Artist'>)>
Traceback (most recent call last):
File "", line 39, in mashumaro_from_dict
File "", line 39, in
File "", line 31, in mashumaro_from_dict
ValueError: Argument for music_assistant.common.models.media_items.ProviderMapping.mashumaro_from_dict method should be a dict instance
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.11/site-packages/music_assistant/server/controllers/media/artists.py", line 68, in add_item_to_library
item = Artist.from_item_mapping(item)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/lib/python3.11/site-packages/music_assistant/common/models/media_items.py", line 285, in from_item_mapping
return cls.from_dict(
^^^^^^^^^^^^^^
File "", line 41, in mashumaro_from_dict
mashumaro.exceptions.InvalidFieldValue: Field "provider_mappings" of type set[ProviderMapping] in Artist has invalid value {'item_id': '500', 'provider_domain': 'library', 'provider_instance': 'library', 'available': True}
2024-03-13 11:21:14.867 INFO (MainThread) [music_assistant] Loaded player provider SONOS
2024-03-13 11:21:14.867 INFO (MainThread) [music_assistant] Loaded metadata provider MusicBrainz Metadata provider
2024-03-13 11:21:14.868 INFO (MainThread) [music_assistant] Loaded player provider Universal Group Player
2024-03-13 11:21:14.868 INFO (MainThread) [music_assistant] Loaded metadata provider fanart.tv Metadata provider
2024-03-13 11:21:14.868 INFO (MainThread) [music_assistant] Loaded player provider Chromecast
2024-03-13 11:21:14.868 INFO (MainThread) [music_assistant] Loaded music provider URL
2024-03-13 11:21:14.871 INFO (MainThread) [music_assistant] Loaded metadata provider TheAudioDB Metadata provider
2024-03-13 11:21:14.871 INFO (MainThread) [aioslimproto.server] Starting SLIMProto server on port 3483
2024-03-13 11:21:14.872 INFO (MainThread) [music_assistant] Loaded player provider UPnP/DLNA Player provider
2024-03-13 11:21:14.925 INFO (MainThread) [music_assistant.players] Player registered: ugp_2/All House Player
2024-03-13 11:21:14.925 INFO (MainThread) [music_assistant.players] Player registered: ugp_n4eux9gq/Kitchen Visual Player
2024-03-13 11:21:14.931 INFO (MainThread) [music_assistant.music] Sync task for URL completed
2024-03-13 11:21:14.987 INFO (MainThread) [aioslimproto.server.cli] Starting (legacy/telnet) SLIMProto CLI on port 9090
2024-03-13 11:21:15.037 INFO (MainThread) [aioslimproto.server.cli] Starting SLIMProto JSON RPC CLI on port 9000
2024-03-13 11:21:15.044 INFO (MainThread) [music_assistant] Loaded player provider Slimproto
2024-03-13 11:21:15.398 INFO (MainThread) [music_assistant] Loaded player provider Airplay
2024-03-13 11:21:15.849 INFO (MainThread) [music_assistant.providers.spotify] Successfully logged in to Spotify as dezmond95
2024-03-13 11:21:15.849 INFO (MainThread) [music_assistant] Loaded music provider Spotify
2024-03-13 11:21:16.068 INFO (MainThread) [music_assistant.players] Player registered: 73d21ff8-02fa-4ef0-ff18-667188d6d572/Del SHIELD
2024-03-13 11:21:16.511 INFO (MainThread) [music_assistant] Loaded music provider RadioBrowser
2024-03-13 11:21:17.219 INFO (MainThread) [music_assistant.providers.slimproto] Player squeezeplay: 02:42:ac:14:00:02 connected
2024-03-13 11:21:17.224 INFO (MainThread) [music_assistant.players] Player registered: 02:42:ac:14:00:02/2140bdf31e69
2024-03-13 11:21:17.264 INFO (MainThread) [music_assistant.providers.slimproto] Player squeezeplay: d8:3a:dd:39:05:a2 connected
2024-03-13 11:21:17.266 INFO (MainThread) [music_assistant.players] Player registered: d8:3a:dd:39:05:a2/squeezeplay: d8:3a:dd:39:05:a2
2024-03-13 11:21:17.283 INFO (MainThread) [music_assistant.providers.slimproto] Player squeezeplay: d8:3a:dd:70:ce:87 connected
2024-03-13 11:21:17.285 INFO (MainThread) [music_assistant.players] Player registered: d8:3a:dd:70:ce:87/squeezeplay: d8:3a:dd:70:ce:87
2024-03-13 11:21:23.008 INFO (MainThread) [music_assistant.music] Sync task for Spotify completed
2024-03-13 11:21:23.009 INFO (MainThread) [music_assistant.music] Sync task for RadioBrowser completed`
Additional information
This started occuring after upgrading to b106.
What version of Home Assistant Core are your running
2024.2.5
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Please check if this is still an issue in b109

Seems resolved for me on latest. Thanks!


Production Host and Port

Everything in dev mode is working perfectly. But I have a problem when build app in production mode.
I edited the environment constants in /config/webpack.prod.js to this:
const ENV = 'production';
const HOST = 'https://example.com';
const PORT = 3050;
const METADATA = webpackMerge(commonConfig.metadata, {
  host: HOST,
  port: PORT,
  ENV: ENV,
  HMR: false
});

But when I run npm run build:prod and npm run server:prod, in the console display this:
Starting up http-server, serving dist
Available on:
  http://<IP_ADDRESS>:8080
  http://xxx.xxx.xxx.xxx:8080
Hit CTRL-C to stop the server

It's still running as default config, how to make the new config run exactly as I want?
Thanks!!!

sorry, this isn't clear to the developer. you would add the options here
https://github.com/AngularClass/angular2-webpack-starter/blob/master/package.json#L49
the config and options are here https://www.npmjs.com/package/http-server

If you have the time can you make a PR or add this to the FAQ or a wiki page?

L49 says:  "version": "npm run build",
how can I configure the port with that?


Suppress multiple identical frogbot comments on PRs

Is your feature request related to a problem? Please describe.
When a PR is opened, and changes are requested by approvers, there can be quite a few additional commits to the PR branch. This results in many repeating frogbot comments on the PR
Describe the solution you'd like to see
Check if comment is a duplicate and suppress in that case.
Describe alternatives you've considered
Open to suggestions...
Additional context
Add any other context or screenshots about the feature request here.

hi, do you have any plans to fix this? this gets really annoying quite fast, when people are working on a MR intensively. We are now having MRs with 15+ frogbot comments, which makes it very difficult to review user comments. At best, just always override the same comment. There is not even need to track changes (e.g. changes from red to green, etc.). For example, Sonarqube analysis will always override the same comment upon every commit/re-analysis, providing a very good overview for users.

Hi @tomhmc and @ivanmrva, I apologize for the delayed response. We greatly appreciate your feedback on Frogbot functionality, and we recognize the importance of addressing this request. I want to assure you that improving the user experience is a priority for us, and this request is definitely on our near-term roadmap.
Based on your feedback, it seems that removing the latest Frogbot comment and replacing it with a newly added updated comment could be a viable approach. We would appreciate hearing your thoughts on this proposed solution. What do you think?

Hi @tomhmc and @ivanmrva, I apologize for the delayed response. We greatly appreciate your feedback on Frogbot functionality, and we recognize the importance of addressing this request. I want to assure you that improving the user experience is a priority for us, and this request is definitely on our near-term roadmap.
Based on your feedback, it seems that removing the latest Frogbot comment and replacing it with a newly added updated comment could be a viable approach. We would appreciate hearing your thoughts on this proposed solution. What do you think?

+1 Please 👌
Really need this feature

Hey @ivanmrva, @neatcoder, @mpwmc, and @tomhmc,
I wanted to inform you that we have implemented the feature discussed earlier. The changes are included in the following pull request:
https://github.com/jfrog/frogbot/pull/400
Once the PR gets approved, the feature will be included in the upcoming release. I will make sure to keep you all updated on its status. Thank you for your valuable feedback; it has been instrumental in improving our work. Feel free to reach out if you have any further questions or suggestions. Thanks again!

Hi @ivanmrva, @neatcoder, @mpwmc, and @tomhmc,
The issue has been fixed in Frogbot v2.11.3. Thank you all once again for reporting this issue to us. Please let us know if you have any further questions.


Remove ansibleVars from the NodeSet node spec

In an effort to simplify the dataplane samples. We will remove this from the sample file, which renders this kustomize operation unnecessary. See for reference:
https://github.com/openstack-k8s-operators/dataplane-operator/pull/501

The actual change is ok, even though it's a little hard to completely tell 😄
Can you not adjust the style of the whole script as well? Maybe your editor did it automatically, but it doesn't match the existing style of the other scripts even. If that is something you'd like to do, I'd do it in a separate PR, and consistently across all scripts so we can gather feedback on it.

Ah damn, yeah I think it was a LSP auto edit on save there. I'll amend that.

recheck


Fix invalid unreachable code error following a panic statement in unreachable block

Purpose
$title
Fixes #36916
Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

[x] Read the Contributing Guide
[ ] Updated Change Log
[ ] Checked Tooling Support (#)
[x] Added necessary tests

[x] Unit Tests
[ ] Spec Conformance Tests
[ ] Integration Tests
[ ] Ballerina By Example Tests

[ ] Increased Test Coverage
[ ] Added necessary documentation

[ ] API documentation
[ ] Module documentation in Module.md files
[ ] Ballerina By Examples

function fn(float? v) returns int {
    if v is () {
        return 1;
    } else if v is float {
        return 2;
    } else {
        string message = "err!";
        panic error(message);
    }
}

seems to result in an extra this function must return a result error now. We could maybe fix this separately since there's unreachable code anyway.

We need to send a PR to master with these changes too.

PR to master - https://github.com/ballerina-platform/ballerina-lang/pull/36940


Unable to locate executable file: 'D:\a_tasks\Sample_59e31f9a-3597-43e6-bb4b-1f0a4e21d1b5\0.2.112\modules\TestResultsPublisher.exe'. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also verify the file has a valid extension for an executable file.

I am trying to create a VSTS extension by modifying PublishTestResultsV2. But when published and added to build definition, it gives me below error.
Unable to locate executable file: 'D:\a_tasks\Sample_59e31f9a-3597-43e6-bb4b-1f0a4e21d1b5\0.2.112\modules\TestResultsPublisher.exe'. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also verify the file has a valid extension for an executable file.

Hi @AbinsC seems like you are missing TestResultsPublisher.exe dependency when you are building , if you are doing it outside the repo. then you have to manually download the dependency https://publishtestresults.blob.core.windows.net/publishtestresults/9421537/PublishTestResults.zip
this is done in our repo. here ->
https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/PublishTestResultsV2/make.json
https://github.com/microsoft/azure-pipelines-tasks/blob/master/make.js


'process is not defined'  when using process as a global

https://github.com/browserify/browser-resolve/blob/master/index.js#L11 uses the global process. Im not sure if this is intended but this crashes my bundle at runtime because process is not defined. I do have the fs, path and process shimmed but that only replaces the imports not the variable reference.
I propose to add an explicit require to support this case:
var process = require('process');

Well my PR would fix it in this wrapper, but the resolve pacakge requires something like rollup-plugin-node-globals anyway. Since that package is not made with the browser in mind i'll leave it up to you guys if this should be merged

Well my PR would fix it in this wrapper, but the resolve pacakge requires something like rollup-plugin-node-globals anyway. Since that package is not made with the browser in mind i'll leave it up to you guys if this should be merged

process is a node core module, so any properly functioning node module bundler will provide a shim for it.
If rollup (like webpack 5) fails to do this by default, I'd file a bug.

process is a node core module, so any properly functioning node module bundler will provide a shim for it.
If rollup (like webpack 5) fails to do this by default, I'd file a bug.

This issue is not about the module process but about the usage of the global process. I indeed fixed it with a plugin that looks for usages of these globals and replaces them with references to my supplied shim.
Since this is a widely used pattern in the ecosystem this PR is pointless. I do find it ironic that if everyone used require('process') instead of relying on global variables this pattern would have looked differnt.

This issue is not about the module process but about the usage of the global process. I indeed fixed it with a plugin that looks for usages of these globals and replaces them with references to my supplied shim.
Since this is a widely used pattern in the ecosystem this PR is pointless. I do find it ironic that if everyone used require('process') instead of relying on global variables this pattern would have looked differnt.

Right. I'm saying the global itself must be polyfilled by a node module bundler, or else it's broken.

Right. I'm saying the global itself must be polyfilled by a node module bundler, or else it's broken.

Ah like that. Yeah with some extra configuration i managed to work it out.

Ah like that. Yeah with some extra configuration i managed to work it out.


可否考虑添加期刊的投稿截止日期？

感谢，毕竟会议要线下参加相较于期刊多少不太方便

Sorry for the late reply. Different from conferences, most journals do not have call paper deadlines. Therefore, this repo does not include journals. However, our wechat applet maintains such info for those interested in.


[2.0-wip] Grid System

"The default grid system provided as part of Bootstrap is a 940px-wide, 12-column grid."
If you hover over the "12" area, 1170px is shown. Maybe you should add something like "it's similar to the 960 grid system".

The docs are responsive, so at a wide enough viewport, the column widths jump up to fill the viewport better. Scroll down to the responsive section to read more.

true. but it looks a bit weired saying 940px width and showing 1170px in the same section. Maybe a reference is required in the text.

It mentions responsive right underneath it:

The default grid system provided as part of Bootstrap is a 940px-wide, 12-column grid.
It also has three responsive variations for various devices and resolutions: phone, tablet, and large widescreen desktops.

ehm... :-)
ok, then maybe adding a link in the word "variations"..

I think we're good here :). I did update the language a bit to reflect that we actually have 4 variations, but that's it.

HI Mark, sry to bring up old history, the grid variables are likely to confuse folks, maybe a note that these are not really used in responsive mode would help:
// Default 940px grid
@gridColumns:             12;
@gridColumnWidth:         60px;
@gridGutterWidth:         20px;