Volumes don't get created until you try to start a container.

Volumes don't get created until you try to start a container. Of course trying to start container volumes generally doesn't work. So we need a sane way to deal with this.

This was fixed in docker 1.4.something.


Import new tmRNA data

This adds a parser for tmRNA data along with some tests and docs. This should be ready to go, but could you use a quick sanity check. I've run a simple test on parsing the current data file we have and that doesn't fail.

I sorted the imports, which is what led to that moving. Pretty silly and I will avoid that in the future.


feat: add phone call alert channel [gh-775]

I hereby confirm that I followed the code guidelines found at engineering guidelines
Affected Components

[x] CLI
[ ] Create CLI
[ ] Test
[ ] Docs
[ ] Examples
[ ] Other

Notes for the Reviewer
Add new PhoneCallAlertChannel construct for phone call alert channel

Resolves #gh-775

@maxigimenez is the BE already there?

@maxigimenez is the BE already there?

@umutuzgur Yes


How Can I use the Bootstrap Modal in bootgrid Command button

I am trying open bootstrap modal in command edit and delete button.

It doesn't work
data-toggle="modal" data-target="#confirmation"
Here my jQuery Code
$( document ).ready(function() {
$("#grid-plant").bootgrid({
caseSensitive: false,
columnSelection: false,
        formatters: {
            "commands": function (column, row) {
                return "<button type=\"button\" class=\"btn btn-xs btn-default command-edit\"  data-toggle=\"modal\" data-target=\"#confirmation\"></button> " +
                    "<button type=\"button\" class=\"btn btn-xs btn-default command-delete\" ></button>";
            }
        }
    })
    });

http://stackoverflow.com/questions/29030352/jquery-bootgrid-modal-dialog

Finally Got :) it is working.
Opening Bootstrap Modal on Click Event.
         .on("loaded.rs.jquery.bootgrid", function () {
         /* Executes after data is loaded and rendered */
         $(this).find(".command-delete").click(function (e) {
        $($(this).attr("data-target")).modal("show");
    });
});

Full jQuery Code Here:
        $( document ).ready(function() {
        $("#grid-plant").bootgrid({
        caseSensitive: false,
        columnSelection: false,

        formatters: {
            "commands": function (column, row) {
                return "<button type=\"button\" class=\"btn btn-xs btn-default command-edit\"  data-toggle=\"modal\" data-target=\"#confirmation\"></button> " +
                    "<button type=\"button\" class=\"btn btn-xs btn-default command-delete\" ></button>";
            }
        }
    }).on("loaded.rs.jquery.bootgrid", function () {
        /* Executes after data is loaded and rendered */
        $(this).find(".command-delete").click(function (e) {
            $($(this).attr("data-target")).modal("show");
        });
    });
    });

Can you tell me how you passed the record id to the delete button so you could delete the record?  I have my modal working as per your code above I just need to pass the record id to the modal so I can do the PHP and delete the record from my MySQL database.  Thank you!

.on("loaded.rs.jquery.bootgrid", function(){  grid .find(".command-edit")  .on("click", function(e)   {         console.log( e.currentTarget );         $($(e.currentTarget).attr("data-target")).modal("show"); })

Thank you I got it working a long time ago but I appreciate your response, I should have posted back the resolution to the issue I was having.
Thank you

Hi Everyone, I am new to this and so far I manage to run a jquery.bootgrid and data is displayed nicely with edit and delete buttons, however I am struggling to open a modal window and on.click of edit the select record.
Please can someone help.
here is my ajax.js script code.  further down is a fetchrecord.php file, which i would like to display in a modal window with save and close button.
$(document).ready(function(){

 var employeeTable = $('#employee_grid').bootgrid({
  ajax: true,
  rowSelect: true,
  post: function()
  {
   return{
    id: "b0df282a-0d67-40e5-8558-c9e93b7befed"
   };
  },
  url: "fetch_data.php",
  formatters: {
   "commands": function(column, row)
   {

    return "<button type=\"button\" class=\"btn btn-xs btn-default command-edit\" data-row-id=\"" + row.emp_id + "\"></button> " +
		                "<button type=\"button\" class=\"btn btn-xs btn-default command-delete\" data-row-id=\"" + row.emp_id + "\"></button>";
	}
			}
												});

// On load of document, pick row-id and perform crud operations.
// This is where I am having problems.

 $(document).on("loaded.rs.jquery.bootgrid", function () {
   //Remove event handlers
   $(this).find(".command-edit").off();
   $(this).find(".command-delete").off();
   $(this).find(".command-add").off();

   $(this).find(".command-edit").on("click", function (e) {
     alert("You pressed edit on row: " + $(this).data("row-id"));
   }).end().find(".command-delete").on("click", function (e) {
     alert("You pressed delete on row: " + $(this).data("row-id"));
   }).end().find(".command-add").on("click", function (e) {
     /* Yout button logic */
   });
});
});

My php fetchsinglerecord.php code.
<?php
//fetch_single.php

include_once("db_connect.php");

if(isset($_POST["eid"]))
{
 $output = array" ";

 $query = "SELECT * FROM employee WHERE id =      '".$_POST["eid"]."'";
 $result = mysqli_query($connection, $query);
 while($row = mysqli_fetch_array($result))
 {
  $output["id"] = $row["id"];
  $output["employee_name"] = $row["employee_name"];
  $output["employee_salary"] = $row["employee_salary"];
  $output["employee_age"] = $row["employee_age"];

 }
 echo json_encode($output);
}
echo json_encode($output);
?>

How do i get this record from fetchsingle.php in a modal window.  Please helpl


[release/1.7] Prepare for v1.7.15 release

Notes need to be recreated once #10037 merges. Fixes #10036 for release/1.7

is the release automated?
once this merge we'll have a 1.7.15?

@aojea not automated, release tags are signed by a maintainer. Notes are generated with https://github.com/containerd/release-tool and the Github release is automated once the signed tag is pushed.
If this release is primarily fixing a regression, I think we should mention that in the tag line instead of the normal various fixes.

containerd 1.7.15
Welcome to the v1.7.15 release of containerd!
The fifteenth patch release for containerd 1.7 contains various fixes and updates.
Highlights

Adds mediatype to OCI index record on export (#9990)

Runtime

Fix runc shim to only defer init process exits (#10037)

Please try out the release binaries and report any issues at
https://github.com/containerd/containerd/issues.
Contributors

Phil Estes
Derek McGowan
Austin Vazquez
Laura Brehm
Sebastiaan van Stijn
Talon

Changes
11 commits

93ed659c9 Prep v1.7.15 release
Fix runc shim to only defer init process exits (#10037)

21df46766 runc-shim: only defer init process exits

Fix compile from version control system (source) use case (#10012)

2a054213e Fix compile from version control system (source) use case

Adds mediatype to OCI index record on export (#9990)

6605c47a4 adds mediatype to oci index record

vendor: google.golang.org/protobuf 1.33.0, github.com/golang/protobuf v1.5.4 (#9975)

e6d91d843 vendor: github.com/golang/protobuf v1.5.4
2d136c5f5 build(deps): bump google.golang.org/protobuf from 1.32.0 to 1.33.0
a1a7af7a3 build(deps): bump google.golang.org/protobuf from 1.31.0 to 1.32.0

Dependency Changes

github.com/golang/protobuf  v1.5.3 -> v1.5.4
google.golang.org/protobuf  v1.31.0 -> v1.33.0

Previous release can be found at v1.7.14

Thanks @dmcgowan I was trying to get an idea of how long it can take , if was just after merging I will wait a bit more to update the kubernetes jobs before signing off today 😄

Thanks @dmcgowan I was trying to get an idea of how long it can take , if was just after merging I will wait a bit more to update the kubernetes jobs before signing off today 😄

At this point it is all up to how fast the hamster wheels can run on the github action runners to generate the release :-} and hopefully no errors 😅

there is no rush at all, just selfishly asking before I go out for some :beers , weekend is starting here ;)


extension add kettle plugins to write doris

Proposed changes
add kettle plugins to write doris
Implementation principle:

Receive data from upstream
Serialize it into data that can be written by Doris
Cache this data in the memory buffer
After reaching the threshold of Maximum rows/bytes, write it to Doris through Stream Load.

run buildall

run buildall

run buildall

run buildall

run buildall


feat(Algebra/Polynomial/Laurent): Lifting maps to ring of Laurent polynomials

This PR defines LaurentPolynomial.lift and provides basic API for it. This was mentioned unter "future work" in the comments.

The "large-import" label seems to be due to the fact that I changed Laurent.isLocalization to use the abbreviation IsLocalization.Away and therefore needed to import RingTheory.Localization.Away.Basic. This is not strictly needed and can be reverted if necessary.

Two quick comments: (1) The map in question seems more like an eval than a lift, since you are evaluating a Laurent polynomial at a unit.  (2) Do you really need S to be commutative?

S needs to be commutative because IsLocalization.lift is only defined if all the rings involved are commutative. As for the name, I wasn't sure how to call it either, because it's a "lift of an eval", so I think both names would make sense. The thing with eval is that for standard polynomial rings, there are multiple different variants like Polynomial.eval (which goes R → R[X]), Polynomial.eval₂ (R[X] → S) as well as Polynomial.evalRingHom (R[X] →+* R) and Polynomial.eval₂RingHom (R[X] →+* S). To fit in with that naming convention, I would have to call mine LaurentPolynomial.eval₂RingHom, which I didn't like because I don't have the other variants (and it wouldn't really make sense to have the non-RingHom variants, since IsLocalization.lift works natively with ring homs).
Admittedly, this is minor point and I would be okay with just calling it LaurentPolynomial.eval.

Now that I think about it more, lift is fine. I have an eval PR under construction for less structured contexts.


Less jumping around due to folds when opening comment threads during review

Issue Description
Type: feature request
Describe what happened (or what feature you want)
When reviewing a PR, in the file diff view, I find it a bit hard to follow all the jumping around that folds are causing when moving cursor over a line which has a comment thread.
The root cause for this is that the other window of the split (most often the left window in my case) is replaced by the comment thread view, so the diff view stops showing its colors + the folds are automatically open, causing a lot of visual noise IMO.
There is also the annoyance of the thread window going away if I move around the file, when sometimes I am writing/reading a comment and want to check something 20 lines above.
Describe what you expected to happen

First, I would like an option to only trigger  comment thread display through a dedicated command, to prevent jumps when just moving around the file. Inside the comment thread buffer, q in normal mode would close the buffer and go back to diff view (this could/should be bindable to let users chose their keybinds)

To go even further, we could maybe make use of nvim's floating windows ? Something like lsp hover windows where hovering over a line with comments, to avoid covering up the other part of the diff. I am less sure about this.

I have a more or less working version of step 1 that disables the autocommand that shows threads and adds support for manually opening/closing the thread buffer. I could open a PR, I am opening this issue to gauge interest.
Cheers

Yeah the fold jumping was disorienting to me too. Unfortunately, doing :set diffopt-=closeoff doesn't help either. I found that completely disabling folds is a better experience for me than the current behavior:
vim.api.nvim_create_autocmd("BufEnter", {
  pattern = "octo://*",
  command = "if &diff | set nofoldenable | fi",
})

But that's just a temporary workaround, I think your suggestions are great long term solutions.


Update Links “tiktok-21”

Automatically generated by Netlify CMS

👷 Deploy Preview for distracted-hoover-7b89cc processing.
🔨 Explore the source changes: 268ec6d9819097b0a263f19ab13f7002a76fcd17
🔍 Inspect the deploy log: https://app.netlify.com/sites/distracted-hoover-7b89cc/deploys/614bbcfae4b86f00076dd507


fixed bug where hashkey fields in attribute_exists conditions weren't…

… handled

This fixes the ZOS CI failures ... https://zeroci.dop.sfdc.net/job/salesforce-zero/job/zero-object-service/job/master/77/

Pull Request Test Coverage Report for Build 185

54 of 67 (80.6%)  changed or added relevant lines in 3 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage decreased (-0.4%) to 85.926%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/main/java/com/salesforce/dynamodbv2/mt/mappers/sharedtable/impl/MtAmazonDynamoDbBySharedTable.java
30
43
69.77%

Files with Coverage Reduction
New Missed Lines
%

src/main/java/com/salesforce/dynamodbv2/mt/mappers/sharedtable/impl/MtAmazonDynamoDbBySharedTable.java
1
83.94%

Totals

Change from base Build 166:
-0.4%

Covered Lines:
1447

Relevant Lines:
1684

💛  - Coveralls


Exec tachikoma update<PHONE_NUMBER>3337

:hamster::hamster::hamster:   Strategy none
Powered by Interval Pull Request as a Service - Tachikoma.io Announcement: 2015-06-28 Updated permissions - Tachikoma.io

Coverage remained the same at 68.0% when pulling 9c29d56a94802dfaf0effbdacde648e7de11b85c on pazjacket:tachikoma/update-20160807163337 into 391307db508f29cde46957edf9baba38c7a2933e on sanemat:master.


document "ls-remote with version filtering support" in --help

nvm help gives us:
  nvm ls                                    List installed versions
  nvm ls <version>                          List versions matching a given description
  nvm ls-remote                             List remote versions available for install

Often when upgrading our build machine I do checks with ls-remote to see if updated versions are available. And the output of ls-remote is loooong, meaning I need to grep the output to see the major version I'm interested in.
Since nvm ls can take an extra <version> filter, why not add the same to ls-remote as nvm ls-remote <version>?

It actually already does! It's just not documented in nvm help.
I'll edit the title and leave this open in case someone wants to PR that in.

It doesn't actually use the version pattern exactly the same way though, example:
$ nvm ls 5
->       v5.5.0
$ nvm ls-remote 5
         v5.0.0
         v5.1.0
         v5.1.1
         v5.2.0
         v5.3.0
         v5.4.0
         v5.4.1
->       v5.5.0

So simple 5 pattern works.
$ nvm ls 5.
->       v5.5.0
$ nvm ls-remote 5.
            N/A

But 5. pattern only works on local ls.
(That was what I tried before reporting and thought it's not supported.)

In that case that's likely a specific thing I added to nvm ls that I forgot to add to nvm ls-remote. That's worth a PR also :-)

ccde2898f8bc992639140aec4a5dee573ec8e343 should cover the help text - but the "dot" part is still worth fixing.

@ljharb This commit ignores trailing dots in the version. Could this work? Or should  nvm ls-remote 5 and nvm ls-remote 5. give different results?
https://github.com/gitburd/nvm/commit/259679b5d1855e4e1f787b90d08d4e1fe73d8e96

Yes, given that nvm ls 5 and nvm ls 5. are identical, I would expect the same from nvm ls-remote.


Bandset

Codecov Report

Merging #22 (7e92dd3) into main (102c3aa) will decrease coverage by 8.51%.
The diff coverage is 47.88%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   35.47%   26.97%   -8.51%
==========================================
  Files          20       19       -1
  Lines         451      456       +5
==========================================
- Hits          160      123      -37
- Misses        291      333      +42

Impacted Files
Coverage Δ

src/Bandsets/DESIS.jl
0.00% <0.00%> (ø)

src/Bandsets/landsat7.jl
0.00% <0.00%> (ø)

src/RemoteSensingToolbox.jl
100.00% <ø> (ø)

src/preprocessing.jl
0.00% <0.00%> (-24.45%)
:arrow_down:

src/Bandsets/interface.jl
23.52% <23.52%> (ø)

src/Bandsets/utils.jl
31.25% <31.25%> (ø)

src/Bandsets/Bandsets.jl
55.55% <55.55%> (ø)

src/Bandsets/landsat8.jl
56.25% <56.25%> (ø)

src/Bandsets/sentinel2.jl
65.00% <65.00%> (ø)

src/utils.jl
53.19% <67.85%> (-7.34%)
:arrow_down:

... and 2 more

... and 4 files with indirect coverage changes


Show  title in tab's title

@rauchg  Is this still the case in the curent master?

I don't think we do this yet @ppot

Webview support is gone in v2.
It should be done as a plugin


Typo in Readme example

source    = "github.com/gearnode/terraform-kubernetes-get-secret?ref=0.2.0"
Should be
source    = "github.com/gearnode/terraform-kubernetes-get-secret?ref=v0.2.0"

Here the fix #5


Webpack bundle single test file

Closes #179

https://github.com/webpack/karma-webpack#alternative-usage

When I allowed node more memory:
node --max_old_space_size=8000 ./node_modules/.bin/karma start karma.conf.js

It used up 2-3Gb of memory. With this change, it huddles around 6-700Mb. This could still increase down the line and we can always resort to adjusting the default space-size from 1.4Gb to 2Gb/4Gb/8Gb, etc.

Coverage decreased (-49.008%) to 44.691% when pulling 6000dfdcdd34ecd3cd37e5e055ac48ad787be705 on eatonphil:fix/bundle-single-test-file into 78fac4d23750f5c9b57e8a5ebd4235ef566dafe4 on linode:master.

Coverage decreased (-49.008%) to 44.691% when pulling 6000dfdcdd34ecd3cd37e5e055ac48ad787be705 on eatonphil:fix/bundle-single-test-file into 78fac4d23750f5c9b57e8a5ebd4235ef566dafe4 on linode:master.

Coverage remained the same at 93.699% when pulling 6000dfdcdd34ecd3cd37e5e055ac48ad787be705 on eatonphil:fix/bundle-single-test-file into 78fac4d23750f5c9b57e8a5ebd4235ef566dafe4 on linode:master.


[fix] Do no replace invalid body with an empty JSON object

Describe the bug
Node.js version: v18.8.0
OS version:
Description: SuperTest doesn't seem to pass the body as is. In particular, if it is invalid, it sends an empty JSON object to the endpoint.
Is this intended? It seems like it would be useful to accept invalid bodies to test the behaviour in those cases.
Actual behavior
ie.
let res = await request.post('/hello/').send('bye');
Endpoint receives a request that has a body of {}
Expected behavior
let res = await request.post('/hello/').send('bye');
Endpoint receives a request that has a body of 'bye', even if it is technically invalid.
Code to reproduce
Behaviour seems similar to what was reported here too: https://github.com/ladjs/supertest/issues/189#issuecomment-826861224
It may be of note that the endpoint receives an empty JSON object when the request body is being parsed by a middleware (both body-parser or express' parser).
Checklist

[x] I have searched through GitHub issues for similar issues.
[x] I have completely read through the README and documentation.
[x] I have tested my code with the latest version of Node.js and this package and confirmed it is still not working.

tldr:  set 'Content-Type' before you send  data 'bye'.

const request = require('supertest')
const express = require('express')
const app = express()
const bodyParser = require('body-parser')
app.use(bodyParser.text())

app.post('/hello', (req, res) => {
  res.end(req.body)
})

describe('/hello', function(){
  it('Send Normal Text', function(done) {
    request(app).post('/hello').set('Content-Type', 'text/plain').send('bye').expect(200, 'bye', done)
  })
})


Main deprecations

🎉 New feature
Summary
While this is fresh on my mind from renaming and releasing gz-common5, I wanted to get the deprecations done for main
Checklist

[ ] Signed all commits for DCO
[ ] Added tests
[ ] Added example and/or tutorial
[ ] Updated documentation (as needed)
[ ] Updated migration guide (as needed)
[ ] Consider updating Python bindings (if the library has them)
[ ] codecheck passed (See contributing)
[ ] All tests passed (See test coverage)
[ ] While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The DEM tests on Windows are a known flake: #432


Extra bytes on files uploaded using s3fs.open(..., 'wb')

I upload about 80 GB of files nightly (about 60-130 MB each) to S3 using S3FS. This week, I've found that about 1% of these files have some amount of extra data-- between about 8k and 15k, based on the size reported by S3 as compared to the size reported by the FTP server. The files are gzips and thus corrupted and unreadable. When this occurs, rerunning the upload again for the same file almost always succeeds and yields valid data.
This is odd because my client code has not changed in 5 months and this issue just started to occur this week. I'm unfortunately not sure whether it's S3FS itself, S3 behaving oddly, some interaction between the two, or something else entirely. Any help would be appreciated, and I'm happy to do some experiments to narrow it down if you can recommend any to try.
As a complication the data I'm moving to S3 is ultimately coming from an FTP server and so I'm moving the data with the following code:
with fs.open(s3_path, 'wb') as fh:
   ftp_conn.retrbinary(f'RETR {remote_path}', fh.write)

After some experimentation, some things I do know fix the problem:

Remove S3FS and write to a local-mounted EBS volume.

with open(local_path, 'wb') as fh:
   ftp_conn.retrbinary(f'RETR {remote_path}', fh.write)

Replace S3FS and ftplib with ftputil and direct boto3, e.g.

url = urllib3.util.parse_url(s3_path)
bucket = url.host
key = url.path[1:]
with ftputil.FTPHost(...) as host:
    with host.open(remote_path, 'rb'):
          boto3.resource('s3').Bucket(bucket).upload_fileobj(fh, key)

I tested two package configurations and got the same behavior:
Config 1:
s3fs 0.4.0
boto3 1.10.39
botocore 1.13.39
s3transfer 0.2.1
Config 2:
s3fs 0.4.2
boto3 1.14.12
botocore 1.17.12
s3transfer 0.3.3
Again I find this puzzling, I'm not even really sure it's an issue with S3FS since this code has been working so long-- but the fact that cutting S3FS out of the loop eliminates the issue leads me to think it may be related. I'd really appreciate any suggestions for how I can help investigate.
Environment:

Python version: 3.6.10
Operating System: Amazon Linux
Install method (conda, pip, source): pip

Have you tried ftputil with s3fs by any chance?
In theory, you should be able to assert the length or md5 of the uploaded file with S3FileSystem(..., consistency=), which, if things pass, would suggest that s3fs was given extra bytes to write (probably).

Thanks Martin. At your suggestion I tried ftputil + s3fs using the following code. It gave the same results as ftplib + s3fs (some files too big):
import shutil
with ftputil.FTPHost(...) as host:
    with host.open(remote_path, 'rb') as rfh:
        with fs.open(s3_path, 'wb') as wfh:
            shutil.copyfileobj(remote_path, s3_path)

I haven't yet tried the consistency= kwarg. I'll give that a try and see what comes up.

Shouldn't it be shutil.copyfileobj(rfh, wfh)?
Also, instead of shutil.copyfileobj, you might want to be low level:
while True:
    chunk = rfh.read(10*2**20)
    if not chunk:
        break
    wfh.write(chunk)

Sorry, yes, Typo after the copy.
I'll try the lowlevel instead of shutil. IIRC shutil's chunksize is 16K and ftplib's default block size is just 8K, and I see you're reading 10 MiB chunks so I imagine this will work somewhat differently (perhaps more efficiently).

Did you manage to dig anything up?


Fix capitalization error

"Desktop Settings" becomes "Desktop settings" to match the rest of the sidebar.
Just a little quirk that's been irking me.

Review status: 0 of 1 files reviewed at latest revision, 1 unresolved discussion.

Google Play Music/Resources/JS/custom-interface.js, line 83 [r1] ([raw file](https://github.com/marshallofsound/google-play-music-desktop-player-unofficial-/blob/6e607c276c5392c2f0e9e1ef9e088a629449a3a9/Google Play Music/Resources/JS/custom-interface.js#L83)):
In the future can we avoid these line ending changes, they are normally caused by an IDE but excluding from the GIT commit would be great :)

Comments from the review on Reviewable.io

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from the review on Reviewable.io


fix(action): build package-operator image for amd64, arm64

Closes #237
📑 Description
I adjusted the goreleaser configuration as well as the action definitions to build multiarch images, at the moment for linux/amd64 and linux/arm64.
The resulting image runs on Apple Silicon architectures, I double-checked.
Further Remarks
If you want to see the updated action in action (pun intended), have a look at my fork, and/or pull the resulting images from here.

Thanks Daniel for you PR on the first glance everything looks good, If we have additional feedback we will provide it by Monday.


added .stop() to SpacialSink

As pointed out in this issue https://github.com/tomaka/rodio/issues/184, SpatialSink is missing the stop() method Sink has. Ad-Hoc, I couldn't think of a reason to let this out on purpose, so here is my proposed fix :)
PS: Are there any contributing guidelines for new contributors?
I'm looking for an open source project to contribute to and I really like rodios design and would be very happy if i could help

Thanks for the PR! Looks good.

PS: Are there any contributing guidelines for new contributors?
I'm looking for an open source project to contribute to and I really like rodios design and would be very happy if i could help

There is no contributor guidelines, but I'd be glad to get help!


Bad performance

Integration with Material UI has awfull performance in comparison with bare Formik fields.
Demo:
https://codesandbox.io/s/confident-boyd-6lhw0

@SQReder The performance is about what I expect with Material-ui. It can't really match native. The missing fast field is more of an issue. I have opened an issue on the formik repo to get some more information

Please link the related issue here, or mention this one in the Formik repo

@SQReder - https://github.com/jaredpalmer/formik/issues/2263

@SQReder I have reverted the changes using useField - https://github.com/stackworx/formik-material-ui/issues/111#issuecomment-584861266
You can try using FastField to see if you get any performance gains but I am going to close this out anyway as Material-UI will never be as fast as a native component


No module named path

"Neural-Photo-Editor-master/GANcheckpoints.py", line 7, in
from path import Path
ImportError: No module named path

sudo pip install path.py


Re-add a previously erroneously removed PUT API for /networkConfig/VirtualNetwork

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Changelog
Please ensure to add changelog with this PR by answering the following questions.

What's the purpose of the update?

[ ] new service onboarding
[ ] new API version
[x] update existing version for new feature
[ ] update existing version to fix swagger quality issue in s360
[ ] Other, please clarify

When you are targeting to deploy new service/feature to public regions? Please provide date, or month to public if date is not available yet. Unknown
When you expect to publish swagger? Please provide date, or month to public if date is not available yet. Unknown
If it's an update to existing version,  please select SDKs of specific language and CLIs that require refresh after swagger is published.

[ ] SDK of .NET (need service team to ensure code readiness)
[ ] SDK of Python
[ ] SDK of Java
[ ] SDK of Js
[ ] SDK of Go
[ ] PowerShell
[ ] CLI
[ ] Terraform
[x] No, no need to refresh for updates in this PR

Contribution checklist:

[x] I commit to follow the Breaking Change Policy of "no breaking changes"
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
[ ] Ensure to copy the existing version into new directory structure for first commit (including refactoring) and then push new changes including version updates in separate commits. This is required to review the changes efficiently.
Adding a new service

[x] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from Breaking Change Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[x] Updating API in stable or public preview version with Breaking Change Validation errors
[ ] Updating API(s) in public preview over 1 year (refer to Retirement of Previews)

Action: to initiate an evaluation of the breaking change, create a new intake using the template for breaking changes. Addition details on the process and office hours are on the Breaking change Wiki.
Please follow the link to find more details on PR review process.

Breaking change request submitted https://msazure.visualstudio.com/One/_workitems/edit/9766573
This isn't actually a breaking change, the API has existed for years but went missing in Swagger a while ago.

For python, the breaking change is ok

@weidongxu-microsoft , @msyyc Can you please review again. Apparently, api-version 2020-12-01 had introduced some breaking changes in .NET SDK because of property ordering. We had to bring those changes in so we can release .NET SDK  for api-version 2020-12-01
For reference:
https://github.com/Azure/azure-sdk-for-net/pull/20300

ARM API review is not required for this PR, please follow the process given @ https://dev.azure.com/azure-sdk/internal/_wiki/wikis/internal.wiki/212/Swagger-PR-Review

@weidongxu-microsoft Please review and help merge.

I am Ok with the change. However you have breaking changes in PR, please check guidance https://github.com/Azure/azure-rest-api-specs/pull/14018#issuecomment-825279941
At least you need to notify Jeffrey and get approval.

@JeffreyRichter Can you please review and approve?

@naveedaz
Let me know when it need merged.


API [bug]: registerTextEditorCommand clears redo stack even if no edits are made

Steps to Reproduce:

In an extension, register a command with vscode.commands.registerTextEditorCommand that does nothing.
Load extension, undo several times, run the command, and try to redo.

You'll see that redo does not work.
A workaround is to use vscode.commands.registerCommand instead, but I don't think this should be necessary.

Wow, that was fast. Thanks!


Remove subclass feature

Part of gtk-rs/gtk#887
The second commit is for a better dox support.
cc @sdroege @EPashkin

👍

:+1:

@GuillaumeGomez I think examples are missing and then these can all go in


Missing function in Javascript Math plugin

It appears that the javascript plugin for the math library is missing the RoundToNearestInteger function which is affecting certain calculations in the DataFrame.

fbaa0f4f0719fa07a8b5f00e0143e2fa0c1d8812
Fixed in this commit


How to send the amount of people queued to the bot

This is not an issue, but I need to know how to put the amount of people queued to apply it to this bot. If you know how I could include it, I would appreciate it. I have no knowledge of js so I do not, thanks.
I am trying to apply it in this bot: https://forum.cfx.re/t/release-fivem-discord-server-status-bot/809972
Use a system that looks for the var Queue but I can't think of to create that variable and link it with lua

Simply add this to a manifest file
dependency "connectqueue"
server_script<EMAIL_ADDRESS>
and put this in a server side script
CreateThread(function()
    while true do
        Wait(10000)
        if Queue.IsReady() then
            SetConvarServerInfo("Queue", "Queue Enabled | Count: " .. Queue.Exports:GetSize())
        end
    end
end)

It will update the queue count every 10 seconds

One thing to note is that the queue commands will not work because setting this convars name to Queue creates a conflict with the command prefix queue

Thank you very match, today i test it and i tell you if work


world-scale: animate the scene view in

world-scale: animate the scene view in

With the default animation speed it looks pretty much like a jump-in rather than a fade-in though.

Good point. I slowed it down. Please re-review.


How best to ensure entire image is always visible?

Hello, first, thank you for developing such a great tool.  I'm not a programmer, and this was so easy to implement.
I'm hoping to set it up so that my entire image is visible on the screen (horizontally AND vertically).  Using the "large-12" class in the outer  it uses (almost) all the width, but the image is too tall, so extends off the bottom of the screen.  Any suggestions on the best way to have it fit so the entire image is showing?
Thanks!

with CSS you can set the image to have a max-height: 100vh and max-width: 100vw this will work for all modern browsers for some older it wont constrain it but it wont break it either.


Crash when multiple mesh in one object

Some object use multiple models.
When there is two (maybe more) the program crash.
Some lod object use two mesh.

Example : x64i.rpf/levels/gta5/_citye/downtown_01/dt1_lod.rpf/dt1_lod_slod3.ydr

Do you mean multiple LOD levels?
Please upload these models (files) somewhere.

In openIV  it's referenced as model in the geometries tab (Model viewer > [More Info])
Here is the file http://www.mediafire.com/download/8y3r7m934frwyjs/dt1_lod_slod3.ydr

Fixed in https://github.com/DK22Pac/v2saconv/commit/4afec26eebc068c59ffb59fc94b990b74d3aab9a

I can't reproduce this issue.
There was a problem with texture names, and it is already fixed in https://github.com/DK22Pac/v2saconv/commit/4afec26eebc068c59ffb59fc94b990b74d3aab9a
Try the new version and report if a bug still appears.


Define relying party object

Define an object for a relying party to be used in server API.
Having defined object in API is more strict solution which prevents errors in typos when compared to passing a dictionary. It may also provide further validation and other functions.
Also the functions from rpid module may be converted to methods of RelyingParty class.

I just wanted to let you know that I'm travelling this week, and won't be able to look at this until I'm back next week.

Thanks, I like having a relying party object and want to merge this, but the to_data method doesn't really fit with the rest of the code. Moving the code from the to_data method to Fido2Server's register_begin is probably the easiest route. We will probably need some kind of machinery to convert objects to basic data structures, but we need to think about it a bit more. Would you mind updating the PR with the to_data method removed?

I'm fine with that for now, but I hope it's going to improve in future. I'm in favor of solution where objects themselves know how they should be serialized. That would allow for fairly straightforward customization.

Fixed and rebased.

Merged, thanks.


Add PSP view

We should add a view for the Pod Security Policies, under the security tab, using the link
/apis/policy/v1beta1/podsecuritypolicies .

PSPs are deprecated as of k8s 1.21: https://kubernetes.io/docs/concepts/policy/pod-security-policy/
Closing.


Finish models

We have finished the models, created all the references, and created the seeds. We also ended up implementing the references without using any polymorphic associations.

 Create and connect other models

 Create and connect other models


Export Multilayer and deep data

Hi,
I tried Export Multilayer with and without deep and the result is the same in Nuke :

The primary beauty exr works
The multilayer exr return only black datas and nan (with or without deep)

Without using Export Multilayer, all the passes are good and readable but no deep datas.
In attachment :

The blend file setuped in Export Multilayer and Use Deep Data
The two exr files from this setup
Somes screenshot with a strange warning from Local queue

If you have an idea to output a dtex file, I get it in waiting of a fix or a retake from your side on my setup (in blender or nuke) ;)
Best Regards,
Matt

images.zip
test_deep.zip

Can you include the scene RIB file?  Renderman isn't liking something about the channel display declaration.

Hi,
Of courses, here in attachment ;)
You've :

all the rib datas freshly created
The output image (with multilayer "on" but only one frame output this time, forget to say it prevously, quite random)
An other screenshot from the setup that output all this datas
And the blend file that output this freshly datas

Tell me if you need others datas
A++
Matt

test_deep.zip
test_deep_blend.zip

Yeah somethings going wrong with the display channel declaration and it isn't matching up with the image output declaration.  That equals unhappy Renderman.  I'll take a look at it.

Try it now.  Hopefully should be fixed


The requested package skyscanner/jsonpath <IP_ADDRESS> could not be found

I'm trying to follow the installation instructions, so I've added this ...
"require": {
    "skyscanner/jsonpath": "dev-master"
}

in my composer.json and then I've tried
composer update
but my system (Ubuntu 15.10), says ...
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - The requested package skyscanner/jsonpath <IP_ADDRESS> could not be found.

Potential causes:
 - A typo in the package name
 - The package is not available in a stable-enough version according to your minimum-stability setting
   see <https://groups.google.com/d/topic/composer-dev/_g3ASeIFlrc/discussion> for more details.

Read <https://getcomposer.org/doc/articles/troubleshooting.md> for further common problems.

I can't find that file in the repo .... Suggestions?
Cesare

I can't reproduce in my Ubuntu installation. What I did:
mkdir test
cd test
echo '{"require":{"skyscanner/jsonpath":"dev-master"}}' > composer.json
composer update

I got the output:
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 1 install, 0 updates, 0 removals
  - Installing skyscanner/jsonpath (dev-master 71c4ce3): Cloning 71c4ce39f8 from cache
Writing lock file
Generating autoload files

Did you check https://getcomposer.org/doc/articles/troubleshooting.md#package-not-found ?

Did you manage to get it installed?

Hi Galbar .... following your suggestion I've installed (I think .... ), anyway I've the code now.
I'm quite a newbie in PHP so sorry for the trivial question .... I've tried to build a little example but it doesn't work .... Here you're how I'm organizing my code

and here you're my code for test ...
<?php
    ini_set('display_errors', 'On');
    error_reporting(E_ALL);

    use JsonPath\JsonObject

    $theJson = '{
      	"codiciColore": [{
      		"id": 2,
      		"descrizione": "Giallo",
      		"rgb": "FFFF00",
      		"priorita": 2,
      		"situazionePazienti": {
      			"numeroPazienti": 9,
      			"numeroPazientiInVisita": 9,
      			"mediaAttesa": "00:22",
      			"numeroPazientiInAttesa": 0
      		}
      	}, {
      		"id": 3,
      		"descrizione": "Verde",
      		"rgb": "00FF00",
      		"priorita": 3,
      		"situazionePazienti": {
      			"numeroPazienti": 16,
      			"numeroPazientiInVisita": 9,
      			"mediaAttesa": "03:03",
      			"numeroPazientiInAttesa": 7
      		}
      	}]
   }';

   $jsonObject = new JsonObject();

?>

When I try to execute it using php testSkyScanner.php I obtain this error ...
PHP Fatal error:  Class 'JsonPath\JsonObject' not found in /var/www/html/Test/tmp/MyTestSkyScanner/testSkyScanner.php on line 33
Any suggestion will be appreciated ... thank you in advance!
Cesare

There is ad error in my code ...
use JsonPath\JsonObject
probably must be
use JsonPath/JsonObject
In thy way the error is
PHP Warning:  The use statement with non-compound name 'JsonPath' has no effect in /var/www/html//Test/tmp/MyTestSkyScanner/testSkyScanner.php on line 7
PHP Parse error:  syntax error, unexpected '/', expecting ',' or ';' in /var/www/html/Test/tmp/MyTestSkyScanner/testSkyScanner.php on line 7

Hi! There is one supported and recommended way to install the library: using composer.
composer  will create a vendor/ folder with all the dependencies installed with it. Inside the vendor folder there will also be a autoload.php file.
Now imagine we have the following file distribution:
.
├── app.php
└── composer.json

composer.json contains the following:
{
    "require": {
        "php": ">=5.4",
        "skyscanner/jsonpath": "dev-master"
    }
}

If we run composer install in this directory it will create the vendor/ directory.
Now lets look at app.php's contents:
<?php
include "vendor/autoload.php";

use JsonPath\JsonObject;

$jsonObject = new JsonObject();
$jsonObject->{"$.hello"} = "world";
echo $jsonObject;

If we now run php app.php we get the output {"hello":"world"}.
Notice that I included the autoload.php file before the use ... line. That file is what allows the usage of use to import modules and classes.
I hope this helps!

Thanks! I'll try to follow your example ad adapt it at my code!!

I've tried and now I can replicate your very clear example but I've still some problems .... .
I've tried to execute yout test.php and all works fine but if I try to use this code (that is quite similar ....)
<?php
    ini_set('display_errors', 'On');
    error_reporting(E_ALL);

    include "vendor/autoload.php";

   $theJson =
   '{ "store": {
        "book": [
          { "category": "reference",
            "author": "Nigel Rees",
            "title": "Sayings of the Century",
            "price": 8.95,
            "available": true
          },
          { "category": "fiction",
            "author": "Evelyn Waugh",
            "title": "Sword of Honour",
            "price": 12.99,
            "available": false
          },
          { "category": "fiction",
            "author": "Herman Melville",
            "title": "Moby Dick",
            "isbn": "0-553-21311-3",
            "price": 8.99,
            "available": true
          },
          { "category": "fiction",
            "author": "J. R. R. Tolkien",
            "title": "The Lord of the Rings",
            "isbn": "0-395-19395-8",
            "price": 22.99,
            "available": false
          }
        ],
        "bicycle": {
          "color": "red",
          "price": 19.95,
          "available": true
        }
      },
      "authors": [
        "Nigel Rees",
        "Evelyn Waugh",
        "Herman Melville",
        "J. R. R. Tolkien"
      ]
    }';

   $jsonObject = new JsonPath\JsonObject();

   $jsonPathExpr =<EMAIL_ADDRESS>== 'fiction' and @.price < 10 or @.color == \"red\")].price";

   $r = $jsonObject->get($jsonPathExpr);

   print json_encode($r)

?>

from command line php testSkyScanner.php the result is false.
How may I specify the json path expression in my code?
Thanks!!!

I've tried to follow your clear instructions and now all work fine!
Thanks!


Search engine suggestions don't appear in omnibar

OS/Platform
Windows
Installed
https://ungoogled-software.github.io/ungoogled-chromium-binaries/
Version
108.0.5359.99
Have you tested that this is not an upstream issue or an issue with your configuration?

[X] I have tried reproducing this issue in Chrome and it could not be reproduced there
[ ] I have tried reproducing this issue in vanilla Chromium and it could not be reproduced there
[ ] I have tried reproducing this issue in ungoogled-chromium with a new and empty profile and it could not be reproduced there

Description
Search engine suggestions don't appear in omnibar
How to Reproduce?

Type 'bing.com cat' in omnibar

Actual behaviour
Only suggestions based on your history appear.
Expected behaviour
In Chrome, you would see e.g. "caterpillar".
Relevant log output
No response
Additional context
No response

It seems you need to enable this option.

Thanks.
For Google, you need to set 'Suggestions URL with %s in place of query' to, for example, 'https://www.google.com/complete/search?client=chrome&q=%s'.


Feedback from flutter create is a little misleading, or, creating emulators for our users

Here's what you see after you run "flutter run":

All done! In order to run your application, type:

  $ cd myflutterapp
  $ flutter run

Your main program file is lib/main.dart in the myflutterapp directory.

The phrase "in order to run your app, type flutter run" isn't exactly correct. You need to have a device or emulator installed. "flutter run" doesn't fire up an emulator for you.
Suggestion:
Check if we can detect if Simulator, Hardware, or Android Emulator is installed or available to run. If so, give the user instructions for how to run the simulator or android emulator.
If we can't detect any way to run the app, suggest the user install either Simulator, Android Emulator, or plug in a device, and then type flutter run.
Thanks!

This might be useful: https://developer.android.com/studio/run/emulator-commandline.html
Here are commands to create new VMs: http://stackoverflow.com/questions/4974568/how-do-i-launch-the-android-emulator-from-the-command-line

Agree we should do this; I have this listed in the 'first hour doc', and did similar research to the one above a quarter ago, but for some reason can't find the bug for it.

@devoncarew did you look more into this? You mentioned recently that you had found some issue wrt. creating emulator instances? (Launching existing ones is a separate issue that I know we are are attacking in M15).

I had researched this a few weeks ago but haven't looked at it since then. No real updates :( I think this is captured in the first hour doc, but a sketch of this might be:

add support into flutter_tools for enumerating and launching ios simulator and android emulators
expose this through IntelliJ

and, as a follow-up:

add support in flutter_tools for creating emulators
expose in a flutter setup command ?
expose in IntelliJ

Closing this bug: We are now tracking this in https://github.com/flutter/flutter/issues/13379.


Divide Functions metrics from other App Services

Currently the set of Functions metrics is different from other App Services.
I divided these sets into two sections.

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@johnkemnetz Please review these proposed changes. Thanks.

These are the metrics of Functions.

And the metrics of other App Services, such as Web Apps.

Currently these metrics are written in one section, and that confuses the customers.

Can we add notes under Microsoft.Web/sites section, which states that Azure Functions supports only seven metrics?
Or we can't modify any contents manually on this document?
My customer strongly hopes to fix this article, in order that they explain to other customers.
I would like to help them, but do you have any idea?

#sign-off


MS Azure Storage Explorer freezes when I delete a blob

Storage Explorer Version: 1.3.0
Platform/OS Version: Windows 10
Architecture: ia32/x64
Build Number: 20180706.3
Commit: 5319bc48
Regression From: Not a regression
Regression From:
Steps to Reproduce:

Added a blob to a blob container (tried folders, plain text, pdf, images, video)
Deleted blob
Software froze, and remained for ~30 mins, and had to be force quit.

Expected Experience:
The blob to be deleted.
Actual Experience:
Step 3.

Jake-Breaks-Stuff,
Uninstalled and Reinstalled but same issue. I regret "upgrading" to a product that was not tested comprehensively.

I'm having the same issue here. Confused as to why it's closed with no resolution.

@vcjdmartinez @nyoiks @Jake-Breaks-Stuff  are any of y'all still having this issue in the latest version of Storage Explorer?


Remove the build path after the build finish to reduce image size

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM, thanks!


Undefined variable: "$golden".

When trying to run the ember server or ember build, I get this error:
File: /home/jan/code/veltro/tmp/tree_merger-tmp_dest_dir-sT8QHAtg.tmp/app/styles/settings/_grid.scss (7)
Undefined variable: "$golden".
Error: Undefined variable: "$golden".
    at options.error (/home/jan/code/veltro/node_modules/ember-cli-sass/node_modules/broccoli-sass-source-maps/node_modules/node-sass/lib/index.js:276:32)

jan@ubuntu:~/code/veltro$ ember v
version: 1.13.1
node: 2.3.0
npm: 2.12.1

I'm not sure whether this is a problem with your addon or the upstream neat package.

Probably related: https://github.com/thoughtbot/neat/issues/360

Setting $golden: 1.618; before importing neat fixes the error. However, I don't know yet, if there are more dependencies on bourbon or if it's just this one variable.

I suppose you also installed ember-cli-bourbon. Maybe that info could be added to the README. :wink:


ddl execution will not display inserted/deleted/update cnt on command…

Changes proposed in this pull request
Displaying update count only when statement issued from the shell is update/delete/insert.
Patch testing
manual and store precheckin in progress.
ReleaseNotes changes
Not required.
Other PRs
None.

Took care of all the review comments.


Specify different compute_flavour for ocs

When deploying into IBM ROKS vpc with ocs there is only a single choice for the OpenShift compute_flavour which by default is bx2.16x64
However this type only has a 100G local disk for ephemeral container images and suffers from 'disk pressure' easily when running lots of pods.  CP4D documentation requires >300G local disk.
There is an alternate flavour mx2.16x128.2000gb that has a 2TB local disk to avoid this issue for the worker nodes, but if used for OpenShift this also applies to the ocs nodes who could still use the original bx2.16x64 with 100G disk to keep costs down.
There is no way currently to specify the compute_flavour for the ocs node pool
It should be possible to specify a flavour for the ocs node pool, that by default is bx2.16x64

Just performed a new install using the compute_flavour mx2.16x128.2000gb and deployer installed the ocs-storage pool using bx2.16x64 which is just the behaviour I wanted!
Seems the flavour is hard coded for the ocs nodes, so this can be closed.

discovered that the deployer is hard coded to use bx2.16x64 as the storage pool which is the desired behaviour.

I think it would make sense for deployer allowing to choose the server flavour. Will make that change and default to bx2.16x64.


Fix action chain runner not including result for tasks / actions which failed during param rendering phase

This pull request fixes a bug in the action chain runner - if the action failed during parameter rendering phase (before we actually scheduled and ran it), LiveActionDB and ActionExecutionDB object were never created and the result object didn't contain item in the tasks attribute for the failed action.

Parameter rendering = poor input by user. It is a failure at the highest level and not at any specific execution. Heck infact an execution was not even created.
I am -1 to this change.

I think the error should be on the ActionChain main execution and the top level workflow should fail.

Discussed this offline with @manasdk - we decided we should go with a different approach where we treat parameter rendering as a top level action chain failure.
Now if the parameter rendering fails, we abort and fail the whole chain and propagate the error to the user in the top-level error result attribute.


Custom Handlebars helper

Hi,
We would like to add a custom Handlebars helper in order to create the CSS rules names. If the meta.name contains "-hover", it will be translated to ":hover". With this little trick sprity will create automatically all the hover clases, so no need to create it manually and no CSS rules that will never be used are created (all that ends with -hover, included in filenames).
We achieved this adding the following code in your lib/style.js, after cssesc, escimage and baseDim helpers, but how can we add this custom Handlebars without modifying the core file? Where can we add custom Handlebars for sprity?
Handlebars.registerHelper('itemClassName', function (className, metaName) {
  return !metaName.search(/.*-hover$/) ? className  + '-' + metaName.replace(/-hover$/, ':hover') : className + '-' + metaName;
});

The code to use in the template is:
.{{itemClassName ../classname meta.name}} {

I think its very useful, maybe you can add this or similar helper on future releases.
Best,

possibly my PR could help with this #70


Make git SCM provider aware of terminal operations

Start drafting a commit in the SCM input box
Finish committing from the terminal
:bug: the SCM view doesn't know the commit has already happened and displays the stale tracked changes until explicitly refreshed

It would be great if the SCM view could use terminal shell integration to figure out that a commit has already happened and trigger a refresh in this scenario.

Should be easy to accomplish after https://github.com/microsoft/vscode/issues/145234 is done. You will be able to subscribe to certain commands and just refresh after git*, hub*, etc. happens


Fatal error: Default value for parameters with a class type hint can only be NULL in C:\wamp64\www\laravel-blog\app\Helpers\date.php on line 8

For configuration or updating questions please read the README and UPGRADE documentation,
or visit: https://gitter.im/PHP-CS-Fixer
When reporting an issue (bug) please provide the following information:
The PHP version you are using ($ php -v):
=> ....................................
PHP CS Fixer version you are using ($ php-cs-fixer -V):
=> ....................................
The command you use to run PHP CS Fixer:
=> ....................................
The configuration file you are using, if any:
=> ....................................

If applicable, please provide minimum samples of PHP code (as plain text, not screenshots):

before running PHP CS Fixer (no changes):

=> ....................................

with unexpected changes applied when running PHP CS Fixer:

=> ....................................

with the changes you expected instead:

=> ....................................

Hi @dean2017 ,
Im sorry but your error report doesn't give us enough details to work on.
Can you fill out the details so we can help you?

Closing as we don't have enough information to work, happy to reopen if we have the details needed to continue.


GAIL tests on minigrid

Need to decide 2-3 base tests where ONLY gail and consequently wgail is tested.

Test 1:
Env:  simple cartpole
dummy test, should work as it is mainly a control task


npm install fails on M1 MBP

Apparently due to gifencoder dependency. Perhaps doesn't work on apple silicon?

https://github.com/Automattic/node-canvas/issues/1825

npm install --only=prod is a workaround that just skips that gifencoder dependency


style: change the arrow color and resize when hovered

The arrow should be colored when the selection is active:

Plus:
Raise the scale to 1.5 when the component is hovered, then back to 1 when deactivated

Hey @0xneves  that task should be moved to swaplace-frontend
Closed in PR -> https://github.com/blockful-io/swaplace-frontend/pull/33


Rename admin columns 224

Coverage decreased (-95.0%) to 3.65% when pulling 8ef1d8c6fc8a1a5805e7c3c295a4b6545e294fa0 on rename_admin_columns_224 into 8508877e5e2f6da043a4d66f2398b7e1cce0fd4c on production.

Coverage remained the same at 98.618% when pulling 23eb804f6704d5c4580d1808cfc3e25def215c84 on rename_admin_columns_224 into 8508877e5e2f6da043a4d66f2398b7e1cce0fd4c on production.

@jszwedko thanks for catching the updated_at/created_at mistakes
I rolled back that migration and added labels as you suggested.
Fyi, I deleted the last pull request and created this one since I was receiving failed Travis CI builds. Turns out the issue was just a spacing issue in the script I edited.
Thanks!

:+1: looks good @jafowler49

@jszwedko @jeanwalshie Has this been integrated to the live site? If not, what are the Heroku credentials I would need in order to do that?
Also, how does someone become an Admin for the Adopt-a-Drain website from the front-end? I did it on my local system by changing the database field via the Postgres client.
Thanks

@jafowler49 this is live now. I can add you as a collaborator on Heroku as well as an admin in adopt-a-drain if you want to give me the e-mail you used for each (either here or via e-mail).
I'm also thinking we could change the branching structure and rely on TravisCI to make it more obvious what is deployed, i.e. with a staging branch that would automatically deploy to the staging server and we could re-purpose the production branch to deploy to production. I'll think on that a bit more.

thanks @jszwedko ... my email for both is<EMAIL_ADDRESS>that build process you proposed sounds good

@jafowler49 apologies, just circling back to this now, but I've added you as an admin in adopt-a-drain and as a collaborator on the Heroku projects (the latter I used your @sfgov.org address for).


Please make sure to add a preprocessor (most likely ember-cli-babel) to in dependencies (NOT devDependencies) in ember-app-scheduler's package.json

Seeing this in my project which uses ember-app-scheduler.

<EMAIL_ADDRESS>has the correct dependencies set, can you confirm that you are using the latest version?

Looks like we're using an older version by way of https://github.com/dollarshaveclub/ember-router-scroll/blob/master/package.json, whoops!
Thank you 🙏


https://win32subsystem.live/supermium don't opening in Russia

On November 6, 2024, Roskomnadzor blocked the SNI protocol used by Cloudflare (https://habr.com/ru/news/856344), which is why the official Supermium browser website https://win32subsystem.live/supermium stopped opening in Russia. win32ss, please do something.

The workaround is use VPN, or GoodbyeDPI.

The workaround is use VPN, or GoodbyeDPI.

Firstly, BrowSec VPN on free proxy servers downloads files very slowly. And secondly, GoodbyeDPI is incompatible with Windows XP, Windows Server 2003 and Windows Vista.

The workaround is use VPN, or GoodbyeDPI.

Windows XP does not have WFP

Article (in Russian) on HOW to disable ECH (Encrypted-Client-Hello) on one's Cloudflare account:
https://habr.com/ru/articles/856602/
And yes. it has been enabled on www.win32subsystem.live :

response
{
  "Status": 0,
  "TC": false,
  "RD": true,
  "RA": true,
  "AD": false,
  "CD": false,
  "Question": [
    {
      "name": "www.win32subsystem.live.",
      "type": 65
    }
  ],
  "Answer": [
    {
      "name": "www.win32subsystem.live.",
      "type": 65,
      "TTL": 300,
      "data": "1 . alpn=h3,h2 ipv4hint=<IP_ADDRESS>,<IP_ADDRESS> ech=AEX+DQBBPgAgACCNP+n8tzXKkxwsN0FCl58LJ5ik5dpjMSUVW34XGDuGPwAEAAEAAQASY2xvdWRmbGFyZS1lY2guY29tAAA= ipv6hint=2a06:98c1:3120::9,2a06:98c1:3121::9"
    }
  ],
  "Comment": "Response from <IP_ADDRESS>."
}

Maintainer of the site here. For what it's worth, this isn't an issue for users visiting the site in older browsers since they won't be connecting through TLS 1.3 anyway. We're also still seeing quite a good amount of traffic from Russia to the site. However it is an issue for those connecting from newer browsers, so I went ahead and turned off the ECH for now.

However it is an issue for those connecting from newer browsers, so I went ahead and turned off the ECH for now.

... Can confirm :+1: :
https://dns.google/resolve?name=www.win32subsystem.live&type=HTTPS =>

Response
{
  "Status": 0,
  "TC": false,
  "RD": true,
  "RA": true,
  "AD": false,
  "CD": false,
  "Question": [
    {
      "name": "www.win32subsystem.live.",
      "type": 65
    }
  ],
  "Answer": [
    {
      "name": "www.win32subsystem.live.",
      "type": 65,
      "TTL": 300,
      "data": "1 . alpn=h3,h2 ipv4hint=<IP_ADDRESS>,<IP_ADDRESS> ipv6hint=2a06:98c1:3120::7,2a06:98c1:3121::7"
    }
  ],
  "Comment": "Response from <IP_ADDRESS>."
}

@EgorKuzevanov , are you now able again to access
https://win32subsystem.live/supermium
with Supermium from your Russian location?
If affirmative, this issue should be closed...

I think it should be able to open in at least IE6 (vanilla install)

For such old browser engines, the Supermium team used to provide a "legacy fallback" iteration:
https://www.win32subsystem.live/supermium/legacy/
and that URL used to load in Supermium itself, too, but now my bookmark of it just redirects back to the standard URL:
https://www.win32subsystem.live/supermium/
and the same happens with Vista's IE9 ; @ChaoticWolf , any insight, please :smile: ?

For such old browser engines, the Supermium team used to provide a "legacy fallback" iteration

The legacy site still exists, it just doesn't redirect the user to another page anymore. The site will render the legacy layout to the user if a legacy browser is detected, otherwise the default will be rendered.

https://github.com/URenko/Accesser
If you can useing high version python

Roskomnadzor blocked

Temporary solutions are not effective: today this is blocked, tomorrow something else is blocked.
A good solution is to use a VPN, or, for example, TorBrowser. This should always be at the ready so as not to lose access to the necessary sites at the most inopportune moment.


Digital Ocean support

As we are running Kubernetes workshops on Digital Ocean it made sense to add DO provisioner and use it to orchestrate VMs for the workshops that way.

@sashajeltuhin Do you mind removing commented out code and binary files from the checkin? Thanks

No problem.
Don't you want to provide support for provisioning from windows? That was the idea behind the win binary.

@sashajeltuhin We should not be checking in binaries inside the source repository. We can add windows support by enabling that in our build pipeline.

@alexbrand Just a heads up, the PR is updated per your comments. There is one open question I need your opinion on.

Hey @sashajeltuhin, I am not sure which question you were referring to. Can you link me to it? Thanks!

@alexbrand The question was about the bootstrap init file. So here is how it is addressed per the updated doc. See below. I also cleaned up the unused places. Let me know what you think: Optionally creates a bootstrap node to run the orchestration of Kubernetes 		cluster from. If the bootstrap node is requested, the provisioner will download kismatic executables and kubectl during the process  		of VM initialization. By default, it will place the downloaded packages in the /ket/ folder. The default location can be overwritten 		by setting an environmental variable 'DO_KET_INSTALL_DIR'. If the bootstrap node is not requested, the Kismatic and Kubectl packages  		will have to be downloaded manually. See digitalocean/scripts/bootinit.sh for details.

@alexbrand As discussed, added the option for the script file for bootstrap initialization. Left the default script file in the repo as a reference.


Rework migrations

Closes #
WIP work, but I've been blocking for too long already on this.
This is a new take on acceptance tests:

They're run as subprocess, as before
But in a dedicated venv
And can be run with multiple configuration (but the same tests will run)

As a start, I created 4 tests:

Normal conditions (current code, all migrations)
Run on the last release of procrastinate with just the pre-migrations (currently failing! @medihack, see below)
Run on the current code with just the pre-migrations
Normal conditions but use aiopg (currently not working, due to not specifying that we need the aiopg extra in the venv)

What's missing:

Fix the 2 failing test
Add some other combinations ?
The operations we run on each test are very minimal, we should test a few more things (see existing acceptance tests)
Remove acceptance tests once we test (mostly?) everything in the new tests. and remove this ugly "2" in the folder name
Add LATEST_TAG envvar in the CI to avoid reading the latest tag from the git tags during the tests. I don't trust our CI git clone to do it properly. Instead use gh releases something
Add a Readme explaining what the hell this whole thing is and how to contribute

Successful PR Checklist:

[ ] Tests

[ ] (not applicable?)

[ ] Documentation

[ ] (not applicable?)

PR label(s):

[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A breaking 💥
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A feature ⭐
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A bugfix 🕵
[x] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A miscellaneous 👾
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A dependencies 🤖
[ ] https://github.com/procrastinate-org/procrastinate/labels/PR type%3A documentation 📚

The interesting error we got on running procrastinate 2.x with pre-migrations:
E           tests.acceptance2.utils.SubprocessException: Subprocess failed (code 1) with stdout:  and stderr: Launching a job: app.t1(a=1)
E           function procrastinate_defer_job_v1(unknown, unknown, smallint, unknown, unknown, jsonb, unknown) does not exist
E           LINE 1: SELECT procrastinate_defer_job_v1($1, $2, $3, $4, $5, $6, $7...
E                          ^
E           HINT:  No function matches the given name and argument types. You might need to add explicit type casts.
E           Database error.

Woo, it's green in the CI! Promising :) Thank you for the pair @medihack !

For using nox, I started working in a new branch and also a new PR #1245


Add minio container to mock s3 locally

Extends docker-compose.yml to also launch an container with minio, backed by a persistent volume.
Closes #463
It seems to work, but I can't test it reliably due this other issue I'm having right now: https://github.com/rust-lang/docs.rs/pull/594#issuecomment-583657798

TODO:

automatically create the bucket rust-docs-rs

Open questions:

Should we expose port 9000? This serves a webpage on which you can browse through the buckets/files.
We don't expose the port of the database, so this would not be consistent.

Should we remove the code that can fallback to the database if S3 is not available?

Should we expose port 9000? This serves a webpage on which you can browse through the buckets/files.

You currently have it exposed. I kind of like this, I would find it very helpful for debugging.

Should we remove the code that can fallback to the database if S3 is not available?

That would make it harder to work on docs.rs without using docker ... Do you know if minio is easy to get set up on Windows?

That would make it harder to work on docs.rs without using docker ... Do you know if minio is easy to get set up on Windows?

I would imagine you could also use Docker on Windows?
There are instructions to install minio on your local machine, but I haven't tried them myself: https://docs.min.io/docs/minio-quickstart-guide.html

Yes, but you can't run cargo test with docker.

Since port 9000 is open, you could run cargo test and let the tests connect to the minio instance from the docker-compose.
I have done something similar for tests that requires the database (you have to expose the port and set the correct environment variables).
But then we would also have to look at cleaning up the bucket after the tests have run...
--> seems like a good next PR: integrate S3/minio in test::TestEnvironment so we can test with S3Client as well :)
I think for now it is best to keep this code. If we find out no-one uses this fallback mechanism anymore we can clean it up.

Wow, browsing s3 locally is super helpful. Thanks for working on this!

Can you add instructions to the README for how to access this locally? Just 'navigate to localhost:9000` in your browser' is fine.

@jyn514 done! Rendered: https://github.com/koenaad/docs.rs/blob/mock_s3/README.md


Experimental switch to our codecov-action wrapper

Codecov Report

Merging #202 (f465ed4) into main (3931a06) will increase coverage by 3.72%.
The diff coverage is n/a.

:exclamation: Current head f465ed4 differs from pull request most recent head 140aac8. Consider uploading reports for the commit 140aac8 to get more accurate results

@@            Coverage Diff             @@
##             main     #202      +/-   ##
==========================================
+ Coverage   36.13%   39.85%   +3.72%
==========================================
  Files         115      115
  Lines        7788     7795       +7
==========================================
+ Hits         2814     3107     +293
+ Misses       4974     4688     -286

Flag
Coverage Δ

unittests
39.85% <ø> (+3.72%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

...es/PostgresNIO/New/PSQLBackendMessageDecoder.swift
94.07% <0.00%> (+0.74%)
:arrow_up:

...urces/PostgresNIO/New/Data/Array+PSQLCodable.swift
94.94% <0.00%> (+1.01%)
:arrow_up:

...rces/PostgresNIO/New/Extensions/Logging+PSQL.swift
19.60% <0.00%> (+1.42%)
:arrow_up:

Sources/PostgresNIO/New/PSQLConnection.swift
31.55% <0.00%> (+1.94%)
:arrow_up:

...s/PostgresNIO/Message/PostgresMessageDecoder.swift
95.45% <0.00%> (+2.27%)
:arrow_up:

Sources/PostgresNIO/New/Data/Int+PSQLCodable.swift
20.26% <0.00%> (+2.61%)
:arrow_up:

...urces/PostgresNIO/New/Messages/ErrorResponse.swift
32.30% <0.00%> (+3.07%)
:arrow_up:

...urces/PostgresNIO/New/Data/Float+PSQLCodable.swift
76.66% <0.00%> (+3.33%)
:arrow_up:

Sources/PostgresNIO/New/PSQLBackendMessage.swift
96.44% <0.00%> (+3.55%)
:arrow_up:

...urces/PostgresNIO/New/BufferedMessageEncoder.swift
96.00% <0.00%> (+4.00%)
:arrow_up:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3931a06...140aac8. Read the comment docs.


add offsite ga link tracking events

Add the code for GA to track external link tracks in preparation for the DIF application form button being added which we want to track.
We don't have cooperation from vendor to do conversion tracking yet so this is just generic offsite link events

Added new menu url for DIF to this PR. Will wait to merge this until we are going live with the new DIF page at the new url

Per note above this PR contains updates to the site menu to use new DIF page url which is not yet published so it should NOT be merged until the new DIF page is published by the content team.

After new DIF page is published we also need to add a redirect to reach the new url from /dif. There are already redirects in the AWS S3 bucket static site settings. This new item can be added to the json array of existing redirects:
,
    {
        "Condition": {
            "HttpErrorCodeReturnedEquals": "404",
            "KeyPrefixEquals": "digital-innovation-fund/"
        },
        "Redirect": {
            "HostName": "digital.ca.gov",
            "HttpRedirectCode": "302",
            "Protocol": "https",
            "ReplaceKeyPrefixWith": "data-and-innovation-fund/"
        }
    }


Generate-hugging

mostly the stream_lit app
sorry this branch is where I do everything.

lgtm. good stuff with the clearer terminology!


Allow the use of the autoconfig client

This patch allows to use the AutoConfigClient of snakebite. This is important when using kerberos.
This is the first patch to fix this issue a follow up patch will also allow the manual config to do this, but snakebite needs to be updated first.

Brrrr you are absolutely right. The horrors of merging :). Should be fixed now.

travis failure has nothing to do with the build

yeah coveralls.io was choking this morning, I just restarted the build...

:+1:

hi @bolkedebruin , are you working on a patch to allow users to pass in hdfs_namenode_principal when they are not using auto-config? If not, I can probably submit a patch.
Thanks for the awesome work :)

@garthcn It would be great if you could submit one. I dont have one ready right now. It is probably quite small anyway.


drop implicit ret-wrapping

This mirrors changes from https://github.com/memoryleak47/minirust-tooling/commit/08f6874162c3c8fb208733ac589e030a8ec390b7.

The README also needs to be adjusted to the new reality.


Allow conversion if md is already parsed, include top-level parameters

The conversion was leaving out path-level parameters. Feel free to steal tests from https://github.com/lucybot/api-spec-converter

LGTM. I'll check the repository later. Thanks!


Enhanced IPV6 handling in astats

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/incubator-trafficcontrol-PR-trafficops-test/22/

@serDrem Can you please fix your conflicts so we can review this PR? Thanks!

Functionality already added to astats with commit
https://github.com/apache/trafficcontrol/commit/1283a52e04d1019c095ea0bda2036caaff9392e7#diff-42ee9311e27e95151959e3950de3b134


Token frequency API route for plots

This pull request enables a new API call, termFreq, which can return counts, percentage-of-corpus, or log-transformed counts for any token field in the index. You can now retrieve the available fields through corpusInfo to make this less error-prone. You can also specify a min and max rank for the request, and order by alphanumeric order or by frequency (with an option to reverse).

Thanks, Gus. I didn't intend those formatting changes. I must have auto-indented the whole file instead of the part of the code I was editing.

I figured.  I think we should add Scalafmt as a plugin, decide on a config, and add the formatting as an CI hook to enforce a consistent style across the repo.


[dataflows] revisit loading multiple sheets with one load step

see https://github.com/datahq/dataflows/pull/110
@roll

Thanks @cschloer
I'll take a look

Hi @cschloer,

The only thing left is integrating goodtables into dataflows/datapackage pipelines.

Does this mean that this issue is not needed anymore?

This would still be great, but as I said in the linked issue we already have the "batch load" concept in our custom load step. And I guess since you said you didn't think the tabulator.Collections solution would be possible in this stage of the pilot, maybe it makes sense to remove it?

Yes, I think it's better to remove it from this stage. I think in a few months it will be ready so you will be able to rebase from your custom processor


Connection details to Azure SQL

A good note that I did not see and for people not used to Azure SQL is that you need to use the syntax <server>.database.windows.net  when connecting to Azure SQL with the SQL manager tool.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 3436fbc8-5bdd-dcdc-f5d3-51caf7b6cd76
Version Independent ID: af78d3ef-b329-11e9-896a-aa3394f6c77c
Content: Copy Finance and Operations databases from Azure SQL Database to SQL Server environments - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/dev-itpro/database/copy-database-from-azure-sql-to-sql-server.md
Service: dynamics-ax-platform
GitHub Login: @laneswenka
Microsoft Alias: laswenka

I will take a look at this today!

Bug 270379 has been logged to track this issue.

This was resolved with the release of Self-service Export


fix: Enable scannerV4 in ACS

Recommended configuration after reaching out the ACS team regarding RHTAPBUGS-1316

/retest

/retest


Documentation of modules in data

We need a documentation for the modules in data package.

Closing the issue. Solved in #28


Add built-in key-value store tools to persist data locally between gptscript invocations

Description
Add built-in tools that can store and retrieve arbitrary key-value pairs to/from disk on my local machine.
Motivation
If I want a tool to be able to reference info from a previous run of gptscript, the tool needs to persist that data somewhere. Today, I believe the onus of how and where to store and retrieve that data is placed on the tool author; e.g. I write another custom tool that writes to a specific file in some arbitrary format. Having a first class way to store key-value pairs would (probably) help me avoid rewriting such a tool every time.

I'm going to classify this as medium primarily bc both Bill and Darren 👍 ed it. That tells me there's some validity (or was at some point), but I'm not sure it's still valid based on how gptscript has evolved. make sure @thedadams and @ibuildthecloud agree on this before implementing.


Add image-cleaner

Simple python script that watches for inode utilization,
and cleans out docker images when inodes are getting too full.

LGTM - I restarted travis

cool. I'm still working out some bugs in it.
re: Prometheus, it's a little complex because binderhub itself doesn't
depend on prometheus. We only have prometheus on mybinder.org, so something
that depends on prometheus shouldn't be here. But in general, having
something that can go 'prometheus metric changed in fashion X, I am going
to perform action Y' would be great.
On Fri, Apr 13, 2018 at 2:38 PM, Chris Holdgraf<EMAIL_ADDRESS>wrote:

LGTM - I restarted travis
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jupyterhub/binderhub/pull/523#issuecomment-381266986,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB23uVkZ6Y7fOnu_MjfHk-vRtG36EYIks5toRrRgaJpZM4TULiN
.

--
Yuvi Panda T
http://yuvi.in/blog

(though FWIW, travis is happy now)

This is ready for review now I think.

Seems good to me - just left a few comments, I'd be +1 on giving it a shot and seeing how the cluster responds.

🎉


Optional base class for PyTree objects

Instead of requiring users to explicitly call register_pytree_node(), we could supply a base class that lets them instead define a pair of special methods for flattening/unflattening.
This looks slightly cleaner than calling functions on classes, but still avoids the evils of implementation inheritance.
Here's a working example, adapted from the pytree docs:
import jax
from jax import tree_util

# baseclass that should go in tree_util.py

def _generic_flatten(tree):
  aux, children = tree.tree_flatten()
  return children, (type(tree), aux)

def _generic_unflatten(type_and_aux_data, children):
  cls, aux_data = type_and_aux_data
  return cls.tree_unflatten(aux_data, children)

# https://stackoverflow.com/questions/18126552/how-to-run-code-when-a-class-is-subclassed
class _AutoRegister(type):
  def __init__(cls, *args, **kwargs):
    tree_util.register_pytree_node(cls, _generic_flatten, _generic_unflatten)
    super().__init__(*args, **kwargs)

class PyTree(metaclass=_AutoRegister):
  def tree_flatten(self):
    """Returns aux_data and children."""
    raise NotImplemented

  @classmethod
  def tree_unflatten(cls, aux_data, children):
    """Returns a new PyTree."""
    raise NotImplemented

# example user code

class Special(PyTree):
  def __init__(self, x, y):
    self.x = x
    self.y = y

  def __repr__(self):
    return "Special(x={}, y={})".format(self.x, self.y)

  def tree_flatten(self):
    return (None, (self.x, self.y))

  @classmethod
  def tree_unflatten(cls, aux_data, children):
    return cls(*children)

# example usage

def show_example(structured):
  flat, tree = jax.tree_flatten(structured)
  unflattened = jax.tree_unflatten(tree, flat)
  print("structured={}\n  flat={}\n  tree={}\n  unflattened={}".format(
      structured, flat, tree, unflattened))

show_example(Special(1, 2))
# outputs:
# structured=Special(x=1, y=2)
#   flat=[1, 2]
#   tree=PyTreeDef(<class '__main__.Special'>[(<class '__main__.Special'>, None)], [*,*])
#   unflattened=Special(x=1, y=2)

Interesting experiment!
I disagree that calling functions on classes is bad, especially since the action being undertaken is to register a dispatch handler for a type.
I don't think we want to grow the pytree API.
Here's a simple convenience wrapper one-liner that avoids the metaclass stuff or adding the PyTree class to the pytree API:
from jax import tree_util

def register_pytree_node_class(cls):
  flatten = operator.methodcaller('tree_flatten')
  return tree_util.register_pytree_node(cls, flatten, cls.tree_unflatten)

# example user code

class Special:
  def __init__(self, x, y):
    self.x = x
    self.y = y

  def __repr__(self):
    return "Special(x={}, y={})".format(self.x, self.y)

  def tree_flatten(self):
    return ((self.x, self.y), None)

  @classmethod
  def tree_unflatten(cls, aux_data, children):
    return cls(*children)

register_pytree_node_class(Special)

The example usage behavior is the same. Any user who doesn't like to call registration functions on types can of course write their own subclassing magic wrapper on top!
I'm going to close this issue because it's not something we want to add to the pytree API right now.

I like register_pytree_node_class. If it returns cls, we could use it as a decorator, too, e.g.,
@register_pytree_node_class
class Special:
  ...

It also avoids the API expansion of adding a base class that can be type checked.

Whoa, decorator is so clever. Want to make it a PR?
 I'm trying to get our issues under control, since I've neglected them for too long.
Is that decorator version of register_pytree_node_class useful? If so, either you or I could make a PR.

No worries on the fast close, I appriecate your diligence here!
Lets reopen to consider the decorator proposal, which is definitely a better design. I should have thought of this earlier, since it's what flax.struct uses. I think some users would find this to be a nicer model, since the class provides a nice logical grouping for these methods.
One concern is whether we should adopt the existing pytree interface, or try to fix the inconsistent order of aux_data/children between flatten/unflatten first.

I think we should keep register_pytree_node_class consistent with register_pytree_node, since the former is just a tiny wrapper around the latter. If someone changes the order of register_pytree_node then both will be fixed automatically.
I don't want to keep this issue open, so I'll make the PR right now. I won't update the docs, though.


[WIP] Don't stop redirect stdout/stderr after startup is done.

Requires #1066 for verification/tests as we need to get logs after shutdown. Needs perf tests and functional tests.
Based on some offline discussion with @mikeharder and @pakrym that stdout redirection is dangerous to change after managed has started.
The goal is to not change what stdout and stderr point to after managed code has started. Today, we have to call Console.SetOut(CreateStreamWriter(Console.OpenStandardOutput())); in managed due to redirecting stdout and stderr after startup. On top of there being a race between setting the handles in managed/native (native sets them first, then managed reads them), the overall state of System.Console will be different as we redirected stdout/stderr. So instead of closing stdout and stderr, we will continue to read stdout and throw it away.

Is the code in PipeOutputManager::StopOutputRedirection() still needed?  If so, why?

Perf is the same.
Commands
 dotnet run -- -s http://asp-perf-win:5001 -c http://asp-perf-load:5002 -n plaintext --webHost IISInProcess -j ../Benchmarks/benchmarks.plaintext.json
dotnet run -- -s http://asp-perf-win:5001 -c http://asp-perf-load:5002 -n plaintext --webHost IISInProcess -j ../Benchmarks/benchmarks.plaintext.json --outputFile aspnetcorev2_inprocess.dll --outputFile Microsoft.AspNetCore.Server.IIS.dll
with a modified plaintext app that calls Console.WriteLine 10 times.
Without change
[05:02:12.122] RequestsPerSecond:           790
[05:02:12.122] Max CPU (%):                 5403
[05:02:12.123] WorkingSet (MB):             156
[05:02:12.123] Avg. Latency (ms):           0
[05:02:12.124] Startup (ms):                516
[05:02:12.124] First Request (ms):          422.2
[05:02:12.124] Latency (ms):                0.7
[05:02:12.125] Total Requests:              11,933
[05:02:12.125] Duration: (ms)               15,100
[05:02:12.125] Socket Errors:               551
[05:02:12.126] Bad Responses:               0
[05:02:12.126] SDK:                         2.1.301
[05:02:12.126] Runtime:                     2.2.0-preview1-26618-02
[05:02:12.127] ASP.NET Core:                2.2.0-preview1-34665
[05:02:12.128] Stopping scenario Plaintext on benchmark server...
[05:02:14.140] Deleting scenario Plaintext on benchmark server...

With change

[04:59:29.905] RequestsPerSecond:           791
[04:59:29.905] Max CPU (%):                 7274
[04:59:29.907] WorkingSet (MB):             157
[04:59:29.907] Avg. Latency (ms):           0
[04:59:29.908] Startup (ms):                514
[04:59:29.908] First Request (ms):          409.9
[04:59:29.909] Latency (ms):                0.7
[04:59:29.909] Total Requests:              11,927
[04:59:29.909] Duration: (ms)               15,090
[04:59:29.910] Socket Errors:               545
[04:59:29.910] Bad Responses:               0
[04:59:29.911] SDK:                         2.1.301
[04:59:29.911] Runtime:                     2.2.0-preview1-26618-02
[04:59:29.911] ASP.NET Core:                2.2.0-preview1-34665
[04:59:29.912] Stopping scenario Plaintext on benchmark server...
[04:59:31.919] Deleting scenario Plaintext on benchmark server...

Actually something seems wrong with the data as there are a good number of socket errors. I'll rerun it.

Updated perf numbers with just one Console.Writeline(). Perf is the same.
[10:23:02.569] RequestsPerSecond:           3,518
[10:23:02.569] Max CPU (%):                 5351
[10:23:02.570] WorkingSet (MB):             379
[10:23:02.570] Avg. Latency (ms):           268.8
[10:23:02.570] Startup (ms):                506
[10:23:02.571] First Request (ms):          519.4
[10:23:02.571] Latency (ms):                0.7
[10:23:02.572] Total Requests:              53,077
[10:23:02.572] Duration: (ms)               15,090
[10:23:02.573] Socket Errors:               0
[10:23:02.573] Bad Responses:               0
[10:23:02.574] SDK:                         2.1.301
[10:23:02.574] Runtime:                     2.2.0-preview1-26618-02
[10:23:02.574] ASP.NET Core:                2.2.0-preview1-34664

[10:46:45.686] RequestsPerSecond:           3,517
[10:46:45.686] Max CPU (%):                 3210
[10:46:45.687] WorkingSet (MB):             355
[10:46:45.687] Avg. Latency (ms):           322.3
[10:46:45.688] Startup (ms):                502
[10:46:45.688] First Request (ms):          516
[10:46:45.688] Latency (ms):                0.6
[10:46:45.688] Total Requests:              53,047
[10:46:45.688] Duration: (ms)               15,080
[10:46:45.689] Socket Errors:               0
[10:46:45.689] Bad Responses:               0
[10:46:45.689] SDK:                         2.1.301
[10:46:45.689] Runtime:                     2.2.0-preview1-26618-02
[10:46:45.690] ASP.NET Core:                2.2.0-preview1-34664
[10:46:45.690] Stopping scenario Plaintext on benchmark server...

CheckShutdownEventLogMessage was the failure. I believe it is flaky.

@dotnet-bot test this please


Listing Page Template

Overview
The theme needs a listing page template with supporting Listing Result Card. This page template would support archive, search results, and blog pages.
NOTE
I think we need designs for a listing result card but will look to @julie-lesseg to confirm.

@jamacon36 Listing cards are here in the base file and here in a listing block view with filters and here in a full page example.


missing null check during TestUtils initialization

in this method https://github.com/apache/incubator-openwhisk/blob/37ce9b86048dafb0f369a5a5b05caa0136a26ef4/tests/src/test/scala/common/WhiskProperties.java#L297 there's a missing null check:
public static File getVCAPServicesFile() {
        String vcapServices = whiskProperties.getProperty("vcap.services.file");
        if (vcapServices.startsWith(File.separator)) {
            return new File(vcapServices);
        } else {
            return WhiskProperties.getFileRelativeToWhiskHome(vcapServices);
        }
    }

@jasonpet the vcap property does not appear to be used anymore in this repo:
https://github.com/apache/incubator-openwhisk/blob/9e5cec1f0e4b98c59e584d453b06a741be4a8c3b/tests/src/test/scala/common/TestUtils.java#L79
(per git blame https://github.com/apache/incubator-openwhisk/commit/f9b4f4841543ab27f4a7e974355802a811140483) is this used in the providers only now - if so i'm wondering if we can move it this code out.

in this method https://github.com/apache/incubator-openwhisk/blob/37ce9b86048dafb0f369a5a5b05caa0136a26ef4/tests/src/test/scala/common/WhiskProperties.java#L297 there's a missing null check:
public static File getVCAPServicesFile() {
        String vcapServices = whiskProperties.getProperty("vcap.services.file");
        if (vcapServices.startsWith(File.separator)) {
            return new File(vcapServices);
        } else {
            return WhiskProperties.getFileRelativeToWhiskHome(vcapServices);
        }
    }

@jasonpet the vcap property does not appear to be used anymore in this repo:
https://github.com/apache/incubator-openwhisk/blob/9e5cec1f0e4b98c59e584d453b06a741be4a8c3b/tests/src/test/scala/common/TestUtils.java#L79
(per git blame f9b4f48) is this used in the providers only now - if so i'm wondering if we can move it this code out.

providers do not use getVCAPServicesFile(), but do use getVCAPcredentials()

not sure if any other openwhisk repos use vcap outside of providers.  maybe catalog or runtimes?

fwiw, I have pretty much all the repos cloned locally.  Here's what I see with some recursive finds.  Fairly limited downstream usage.
daves-mbp:openwhisk dgrove$ qfind getVCAPServices
./openwhisk/tests/src/test/scala/common/WhiskProperties.java
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/TestUtils.java
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/WhiskProperties.java
daves-mbp:openwhisk dgrove$ qfind getVCAPcredentials
./openwhisk-package-cloudant/tests/src/test/scala/system/CloudantUtil.java
./openwhisk-catalog/tests/src/test/scala/packages/weather/WeatherTests.scala
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsDb2CloudTests.scala
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsActionCloudantTests.scala
./ibm-functions-runtime-nodejs/tests/src/test/scala/runtime/integration/CredentialsIBMNodeJsActionWatsonTests.scala
./openwhisk-devtools/docker-compose/openwhisk-src/tests/src/test/scala/common/TestUtils.java
./ibm-functions-runtime-python/tests/build/tmp/scala/compilerAnalysis/compileTestScala.analysis
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonDb2CloudTests.scala
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonWatsonTests.scala
./ibm-functions-runtime-python/tests/src/test/scala/integration/CredentialsIBMPythonCloudantTests.scala
./ibm-functions-runtime-swift/tests/build/tmp/scala/compilerAnalysis/compileTestScala.analysis
./ibm-functions-runtime-swift/tests/src/test/scala/runtime/integration/CredentialsIBMSwiftActionWatsonTests.scala
```

Downstream Apache repos mix getCredentials and getVCAPcredentials. I did not check IBM or other external repos, obviously.
My plan was to move the parameter reading into the downstream repos that needed it. Given the wider use, I'm incline to leave it as is until after 1.0.
https://github.com/apache/openwhisk-catalog/search?q=getCredentials&unscoped_q=getCredentials
https://github.com/apache/openwhisk-catalog/search?q=getVCAPcredentials&unscoped_q=getVCAPcredentials
https://github.com/apache/openwhisk-package-pushnotifications/search?q=getVCAPcredentials&unscoped_q=getVCAPcredentials
https://github.com/apache/openwhisk-package-cloudant/search?q=getVCAPcredentials&unscoped_q=getVCAPcredentials
https://github.com/apache/openwhisk-package-kafka/search?q=getCredentials&unscoped_q=getCredentials


Add an endpoint to return the running git revision fingerprint

This will allow us to be certain of what version of the backend is actually running on a given server

Question about this:  when we eventually have deployment scripts going on the server, git will be installed on the server and the scripts will git pull and then run the setup commands etc, right?
So a solution which involves the following: -- from inside the running backend, creating a subprocess that just calls git to ask about the git revision hash -- is appropriate?  E.g., https://stackoverflow.com/a/21901260
If that seems appropriate, I think I could try to do this.

Yes, git is installed on the server, and the code to run is loaded onto the server via git pull. Remember now that we have a test harness in place, a PR for this issue should document the new endpoint and provide a test of the new endpoint. Thanks!

@gwhitney wrote "I recommend a single endpoint that returns the version number and the latest git commit id."  What do you mean by "version number" -- version number of what?

Also, another question, how can I test the new endpoint?  the hash is always different

Ok, I'm stuck on deciding what to do for testing, but I committed my changes so you can see them.  Here's the beginning of a test: https://github.com/katestange/backscope/blob/githash/flaskr/nscope/test/test_get_hash.py
Maybe @Vectornaut has suggestions.

@gwhitney wrote "I recommend a single endpoint that returns the version number and the latest git commit id." What do you mean by "version number" -- version number of what?

Oh! Most python projects have a "pyproject.toml" file (see https://packaging.python.org/en/latest/tutorials/packaging-projects/) that specifies a current version number of the project. That's updated (manually) when a new release of the project is made. But I see that backscope has no such thing. So I guess the current git hash is the best one can do at the moment.

Also, another question, how can I test the new endpoint? the hash is always different. I could just test that it returns appropriately formatted JSON and ignore the actual hash.

Well, I think the test should just grab the hash, too, and match it against what it gets from the endpoint...

Yeah, you're testing that the server can deliver the hash.


Update Download page

Use tab interaction to display each Windows, Mac, and Linux download button & installation instruction
Include text content of latest version, right aligned to the end of the line
Include name of Windows, Mac, or Linux in the download button in their dedicated tab. (For example 'Download for Windows'. (Google material Icon name is 'save_alt')
Include installation instructions below per tab.

Installation Instructions text for Windows:

Download thenewboston
Click on the downloaded file
You will get a modal that says ‘Windows protected your PC’. Click More info
Then click Run anyway

Installation Instructions text for Mac:

Download thenewboston
Click on the downloaded file
Drag and drop the app to the Applications folder
Open the app

Installation Instructions text for Linux:

Download thenewboston
To run thenewboston, make it executable
($ sudo chmod a+x TNB-Account-Manager-1.0.0-alpha.20-linux*.AppImage)
Run!
($ ./TNB-Account-Manager-1.0.0-alpha.20-linux*.AppImage)

https://www.figma.com/file/ChyT88EmP2Rmzx35I9erCL/Marketing-Site?node-id=500%3A1096

Hi @kristykjlee could you please assign this to me.i would like to work on it this weekend:))

@leelatanniru Hi Leela, you can pick up any ticket without my permission 🙂 You can just comment and say you're taking the ticket. It's all yours!


Feature/email notification

Created Email notification to be sent when a new user sign up
Added smtp js script file to the folder
Added Social Media Icons in the footer
Added Order Page and Link
Updated Header and Footer and its styling

Also added favicon files


Configuration.IgnoreInlineComments is ignored

As mentioned in issue #60, Configuration.IgnoreInlineComments ignored as of 3.2.3.
This is caused by the ConfigurationReader, which ignores the value of Configuration.IgnoreInlineComments once an inline comment is found. Example:
Params=param1;param2;param3

Params.StringValue will become "param1" instead of "param1;param2;param3", regardless of what value is set on Configuration.IgnoreInlineComments.

Fixed with version 3.2.4.

Reading works great again, thanks!
Is it possible to do the following change also (added a check for IgnoreInlineComments upon writing)?:
    private static string GetValueForOutput(string rawValue)
    {
      if (rawValue.StartsWith("{") && rawValue.EndsWith("}"))
        return rawValue;

      if (rawValue.StartsWith("\"") && rawValue.EndsWith("\""))
        return rawValue;

      if (
        (rawValue.IndexOf(" ") >= 0) ||
        ((rawValue.IndexOfAny(Configuration.ValidCommentChars) >= 0) && !(Configuration.IgnoreInlineComments)))
      {
        rawValue = "\"" + rawValue + "\"";
      }

      return rawValue;
    }

In this way I think reading/writing stuff with inline comments ignored is more consistent.

Good catch, that's correct. I'll put another hotfix up soon.