Missing isort configuration to work with black.

Associated Template/Command/Core
cookietemple create -> cli -> python
Describe the bug
When running the pre-commit hooks, isort may conflict with black. The problem is that isort sometimes reorders differently than black. This leads to failure of the pre-commit test because the change that is made by black is immediately reversed by isort.
In the end, no file has been changed but the test thinks it failed.
This behaviour can be circumvented by forcing isort to be cautious about changes made by black.
One can add --profile black.
This could either be done in .pre-commit-config.yaml:
repos:
     ...
     - repo: https://github.com/pycqa/isort
       rev: 5.8.0
       hooks:
          - id: isort
            name: isort (python)
            args: ["--profile", "black"]  # new code
     ...

or adding this to pyproject.toml in the default TEMPLATE:
[tool.isort]
profile = "black"

Further information: https://black.readthedocs.io/en/stable/guides/using_black_with_other_tools.html
To Reproduce
Steps to reproduce the behavior:
Not sure how to reproduce it exactly as I cannot remember what caused the conflict in my case.
But this issue provides an example: https://github.com/PyCQA/isort/issues/1518
Expected behavior
Black and isort should both agree and agree at all times when executing the pre-commit hooks.
System [please complete the following information]:

OS: Debian 11
Python: 3.8 / 3.9
Virtual environment: conda
cookietemple: 1.3.11

Additional context

Great, thank you!
Would you be willing the submit a PR?
You can find the file here: https://github.com/cookiejar/cookietemple/blob/development/cookietemple/create/templates/cli/cli_python/{{ cookiecutter.project_slug_no_hyphen }}/.pre-commit-config.yaml


Change length of specific grid line?

Hi,
first of all I would like to say that chartist.js is amazing library and it's real pleasure to work with.
I'm interested is it possible to change length of the specific grid line? In my case it's the first horizonal grid line that should go over offset and padding area.
I would also like to know is it possible to create a full height vertical line that's going to be used as an separator for years between months?
Best regards.

Thats possible using the draw event of chartist. Just search in the github repo for draw event and check the issues. You'll find plenty of examples. We're also tracking documentation with #90


Issue with curl and "cannot parse client hello"

Hi there, and thanks for your project!
But I have a bizarre (for me) issue, that can be simply reproduced:
$ docker run --rm nineseconds/mtg:2.1.6 generate-secret <IP_ADDRESS>.nip.io
7q6BM33vVLydrR4EXDkfMAkxMjcuMC4wLjIubmlwLmlv

$ docker run --rm -p "443:443" nineseconds/mtg:2.1.6 simple-run -d -p 443 <IP_ADDRESS>:443 7q6BM33vVLydrR4EXDkfMAkxMjcuMC4wLjIubmlwLmlv

$ curl -k -v https://<IP_ADDRESS>:443/ # or https://<IP_ADDRESS>.nip.io/ - it does not matter
*   Trying <IP_ADDRESS>:443...
* TCP_NODELAY set
* Connected to <IP_ADDRESS> (<IP_ADDRESS>) port 443 (#0)
* ALPN, offering h2
* ALPN, offering http/1.1
* successfully set certificate verify locations:
*   CAfile: /etc/ssl/certs/ca-certificates.crt
  CApath: /etc/ssl/certs
* TLSv1.3 (OUT), TLS handshake, Client hello (1):
* Operation timed out after 60000 milliseconds with 0 out of 0 bytes received
* Closing connection 0
curl: (28) Operation timed out after 60000 milliseconds with 0 out of 0 bytes received

In the docker logs:
{"level":"debug","configuration":{"debug":true,"allowFallbackOnUnknownDc":true,"secret":"7q6BM33vVLydrR4EXDkfMAkxMjcuMC4wLjIubmlwLmlv","bindTo":"<IP_ADDRESS>:443","preferIp":"prefer-ipv6","domainFrontingPort":443,"tolerateTimeSkewness":"","concurrency":8192,"defense":{"antiReplay":{"enabled":true,"maxSize":"1mib","errorRate":0},"blocklist":{"enabled":false,"downloadConcurrency":0,"urls":null,"updateEach":""},"allowlist":{"enabled":false,"downloadConcurrency":0,"urls":null,"updateEach":""}},"network":{"timeout":{"tcp":"10s","http":"10s","idle":"10s"},"dohIp":"<IP_ADDRESS>","proxies":null},"stats":{"statsd":{"enabled":false,"address":"","metricPrefix":"","tagFormat":""},"prometheus":{"enabled":false,"bindTo":"","httpPath":"","metricPrefix":""}}}
,"logger":"","timestamp":1660290772743,"message":"configuration"}
{"level":"info","logger":"allowlist.ipblocklist.firehol","timestamp":1660290772744,"message":"ip list was updated"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"-Q7t0-z6u-e-Lrr-d6VMbw","logger":"proxy","timestamp":1660290775558,"message":"Stream has been started"}
{"level":"info","logger":"proxy","error":"bad digest","timestamp":1660290775563,"message":"cannot parse client hello"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"rI0H4p-cb2EGM3WrRi5_TA","logger":"proxy","timestamp":1660290775808,"message":"Stream has been started"}
{"level":"info","logger":"proxy","error":"bad digest","timestamp":1660290775808,"message":"cannot parse client hello"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"dDrYwVY1Rpb25cUgBWUdRA","logger":"proxy","timestamp":1660290775809,"message":"Stream has been started"}
{"level":"info","logger":"proxy","error":"bad digest","timestamp":1660290775809,"message":"cannot parse client hello"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"Y2OVgRfJdeNdiSIoORpGQQ","logger":"proxy","timestamp":1660290775809,"message":"Stream has been started"}
{"level":"info","logger":"proxy","error":"bad digest","timestamp":1660290775809,"message":"cannot parse client hello"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"uvg-P8uMKMJx6IRhV2d3Lw","logger":"proxy","timestamp":1660290775810,"message":"Stream has been started"}
{"level":"info","logger":"proxy","error":"bad digest","timestamp":1660290775810,"message":"cannot parse client hello"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"S_mGV5f4msq3LRX-ftmdNQ","logger":"proxy","timestamp":1660290775810,"message":"Stream has been started"}
# ...many-many times...
{"level":"info","ip":"<IP_ADDRESS>","logger":"proxy","timestamp":1660290776624,"message":"connection was concurrency limited"}
{"level":"debug","client-ip":"<IP_ADDRESS>","stream-id":"MXsjpwrEkGPn3_wnXFK7sQ","logger":"proxy.domain-fronting","timestamp":1660291418199,"message":"telegram -> client has been finished"}
{"level":"debug","client-ip":"<IP_ADDRESS>","stream-id":"u1NM2Jz-7WeDC8j-HirKNA","logger":"proxy.domain-fronting","timestamp":1660291418199,"message":"client -> telegram has been finished"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"MXsjpwrEkGPn3_wnXFK7sQ","logger":"proxy","timestamp":1660291418199,"message":"Stream has been finished"}
{"level":"debug","client-ip":"<IP_ADDRESS>","stream-id":"u1NM2Jz-7WeDC8j-HirKNA","logger":"proxy.domain-fronting","timestamp":1660291418199,"message":"telegram -> client has been finished"}
{"level":"debug","client-ip":"<IP_ADDRESS>","stream-id":"sy4XmCL0VDzrc3zkPMEppA","logger":"proxy.domain-fronting","timestamp":1660291418199,"message":"client -> telegram has been finished"}
{"level":"info","client-ip":"<IP_ADDRESS>","stream-id":"u1NM2Jz-7WeDC8j-HirKNA","logger":"proxy","timestamp":1660291418199,"message":"Stream has been finished"}
# ...many-many times...

It looks like some kind of looping... And in my production, together with flooding in logs (CPU and memory actively used in this time) - containers orchestrator kills the container with ran mtg. So, any who knows a sub-domain with mtg can kill it using one simple HTTP (curl) request or by opening a domain in the browser.

Telegram can communicate with mtg without any issues at the same time.

Expected behavior: simple 404 HTTP response with an invalid TLS "Page not found".

I'm not sure about the loop. Could you please carve out some logs with the same stream-id. Actually, there is no way how it could loop so I'm really curious what is happening here.
Do you suggest to return a custom page with 404 status code? I'm strictly against it because it contradicts a whole idea of being a domain fronted. mtg has to react as a website it cloaks and there should be no difference between accessing a real website with the same TCP packets and mtg.

Could you please make an attempt to reproduce the described behavior on your side?

I do not see a loop of any kind from my side. I see that Telegram is trying to reconnect but that's all. If you see this issue with curl, it could be that upstream is not responding 🤷

Ok, I close this issue as non-reproducible. Thanks anyway!


Manual approval required for workflow run<PHONE_NUMBER>: Release t0rn refs/tags/v1.15.1-rc.0

Please approve runtime upgrade with github release t0rn v1.15.1-rc.0
Runtime upgrade dry run output:
💈 Script started at 1882265 block in t0rn chain

🐡 Running with dryrun flag!

🐙 checking out v1.15.1-rc.0...
✅ tag checked out

🔎 making sure runtime version got updated...
✅ runtime versions updated

🫧 check WASM artifact...
🔢 WASM blake2_256 hash: 0x5a9629d1ea677ea76395c334f8fd8a53f19ef48de74e5906fabdbbe6269c7f47
🔢 WASM blake2_256 hash fetched from release: 0x5a9629d1ea677ea76395c334f8fd8a53f19ef48de74e5906fabdbbe6269c7f47
✅ WASM blake2_256 hash is matching
⚙ set_code runtime upgrade... dry
✅ runtime upgrade executed... dry

Workflow is pending manual review.
URL: https://github.com/t3rn/t3rn/actions/runs/4872619472
Required approvers: [AwesomeIbex MaciejBaj chiefbiiko petscheit palozano]
Respond "approved", "approve", "lgtm", "yes" to continue workflow or "denied", "deny", "no" to cancel.

Workflow cancelled, closing issue.


strndup implementation for Windows

Hopefully fixes #4132.

Ping for a review: @bkeepers, @lildude?

Thank you!

Hmmm, I'm not sure why this is suddenly a problem, but testing locally (macOS) for me is now failing with:

cd tmp/x86_64-darwin17/linguist/2.4.3
/usr/bin/make
compiling ../../../../ext/linguist/strndup.c
../../../../ext/linguist/strndup.c:14:31: error: unknown type name 'size_t'
char *strndup(const char *s1, size_t n)
                              ^
../../../../ext/linguist/strndup.c:16:16: warning: implicitly declaring library function 'calloc' with type 'void *(unsigned long, unsigned long)' [-Wimplicit-function-declaration]
  char *copy = calloc(n + 1, sizeof(char));
               ^
../../../../ext/linguist/strndup.c:16:16: note: include the header <stdlib.h> or explicitly provide a declaration for 'calloc'
../../../../ext/linguist/strndup.c:17:3: warning: implicitly declaring library function 'memcpy' with type 'void *(void *, const void *, unsigned long)' [-Wimplicit-function-declaration]
  memcpy(copy, s1, n);
  ^
../../../../ext/linguist/strndup.c:17:3: note: include the header <string.h> or explicitly provide a declaration for 'memcpy'
2 warnings and 1 error generated.
make: *** [strndup.o] Error 1
rake aborted!
Command failed with status (2): [/usr/bin/make...]

... which appears to be related to the changes in this PR.

The failure and warnings are resolved with:
--- a/ext/linguist/strndup.c
+++ b/ext/linguist/strndup.c
@@ -1,3 +1,7 @@
+#include <stddef.h>
+#include <stdlib.h>
+#include <string.h>
+
 #if defined(_WIN32) || defined(_WIN64)
 #include <math.h>
 char *strndup(const char *s1, size_t n)

... though I'm not a C expert so I'm not sure if this is the correct or best approach to take.

Ugh, gross! I think that change might not necessarily be sound — it's unclear how it would affect the Windows build, and I still (sigh) don't have a working Windows build system.
Even simpler fix:
diff --git a/ext/linguist/strndup.c b/ext/linguist/strndup.c
index 49128cf0..8a7879b9 100644
--- a/ext/linguist/strndup.c
+++ b/ext/linguist/strndup.c
@@ -8,13 +8,3 @@ char *strndup(const char *s1, size_t n)
        return copy;
 }
 #endif
-
-
-#if defined(__APPLE__)
-char *strndup(const char *s1, size_t n)
-{
-  char *copy = calloc(n + 1, sizeof(char));
-  memcpy(copy, s1, n);
-  return copy;
-}
-#endif

I'll open a PR!

→ #4175


Remove enchantment level description (?)

Hi! as the tittle says... Its possibel to remove the enchantment level description? (I, II, III, IV, V...)
Like this... ^^
• From:

• To:

Just for make something like this. (Example :S)

Greetings!

There is no option to make the level disappear as it is needed to know what level the enchantment is.


Fixes to the CSS Scroll Snap article

What's changed, or what was fixed?
In the Well-Controlled Scrolling with CSS Scroll Snap article,

Added missing determiners.
Fixes some typos.
Added missing commas.
Added backticks around 15vh.

CC: @petele

:tada: This has been pushed live to https://developers.google.com/web/


neomutt: 20200417 -> 20200424

Motivation for this change
https://github.com/neomutt/neomutt/releases/tag/20200424
Please note that I'd wait with updating the package until https://github.com/neomutt/neomutt/issues/2295 is fixed since using neomutt to read a local maildir (synced with another tool from an IMAP server) is a rather common use-case IMHO.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@Ma27 with https://github.com/neomutt/neomutt/issues/2295 being closed, WDYT about this?

As there's a simple workaround, I'd be fine with merging, however we shouldn't backport this since this release seems to "break" existing configurations.

I need to admit, I only use virtual folders. Let's ask @andir ;-)

On 15:43 24.04.20, Florian Klink wrote:

I need to admit, I only use virtual folders. Let's ask @andir ;-)

Including the question in the message would help with receiving an
answer.

It's in the PR description and previous comments.

Alright, let's merge this, but not backport.

The issue has been fixed in the end btw: https://github.com/neomutt/neomutt/commit/f073a70cf363cec518315ba0b1230d373b118210

@Ma27 given the fix is now part neomutt-20200501, do you want to bump 20.03 to it, or should we keep it?

I don't see a reason not to, the last two releases mostly contained bugfixes.

Ported to stable as 78332acf45f9d1fb35cd20fdd54cd896ea87f61c


The Dapr System service dashboard do not have docs describing how to read the information.

The docs do not describe what the Dapr system service dashboards are useful for either here
https://docs.dapr.io/operations/monitoring/grafana/ or here https://github.com/dapr/dapr/tree/master/grafana.
The operations sections instead should have a topics called "Configuring Dapr system service dashboards" and "How To: Use the Dapr system service dashboards" to explain what is useful on them.
These dashboards

Also we should be clear listing all the dashboards for Dapr, given that there is also an application dashboard that is installed via the CLI.

Dashboard panel has its self-description note when a user hovers i icon. Therefore I am not sure we need to document it separately. We can move this metrics list doc to docs repo.

Here is my suggestion:

Move this metrics list doc from dapr/dapr to dapr/docs
Describe how to see the description note on grafana dashboard.

@msfussell Any thoughts?


Refactoring

[x] Move gateways to their own namespace (done in #30)
[x] Cleanup the abstract gateway and contracts (done in #30)
[ ] Move to my laravel 5 manager package and cleanup
[ ] Move laravel integration to another repo
[ ] Move each gateway to their own repo

Replaces #7 and #15. // cc @jbrooksuk, @joecohens, @frankdejonge

Question - do we need a larave4 bridge and a laravel5 bridge, or should we just move forward with L5?

Both for now. We can deprecate in the future.

Should we name them laravel4-notifyme and laravel5-notifyme?

notifyme-laravel4?

or just "laravel4"

Going for just laravel4 and laravel5.

Yeah both for now


parameter --use_nms is not used

Hi,
Thank you very much for sharing the codes. It's great!
For the --use_nms parameter defined here https://github.com/cjw2021/QAHOI/blob/main/main.py#L138,
it looks like it is not used.

Thanks for your interest in our work.
NMS process is used during evaluation. So the --use_nms option is used when the evaluator is initialized.
See this line https://github.com/cjw2021/QAHOI/blob/bb7f5fd79e2f33980a41190f9f37460f7c22e67b/engine.py#L119


Update debian package versions

Update versions of debian packages according to our package version
convention.  For global-node-modules, update to the latest since it's
the first tagged version, and correct one place where a version was
floating.

We shouldn't upgrade packages here. Let's put that in a separate commit and keep this PR entirely related to versioning the existing code.

Fixed.  Tagged existing version as 0.9.0

Bypassing CI - bug reported with CI team


Tagging of unsupported netbox objects?

Hey, we have implemented netbox-sync and we get a lot of the following messages (with various Platforms, Manufacturers, and the clusters) on every run:
INFO: Platform 'Debian GNU/Linux 10 (64-bit)' attribute 'tags' changed from '[]' to '['NetBox-synced', 'Source: vcenter01']'
INFO: Manufacturer 'Dell' attribute 'tags' changed from '[]' to '['NetBox-synced', 'Source: vcenter01']'
INFO: Cluster type 'VMware ESXi' attribute 'tags' changed from '[]' to '['NetBox-synced', 'Source: vcenter01']'
INFO: Cluster group 'Main Cluster' attribute 'tags' changed from '[]' to '['NetBox-synced', 'Source: vcenter01']'

If i'm not mistaken those objects don't support tags in the netbox data model, so maybe they should be excluded from the tagging?

Hi @Apfelwurm,
which version of NetBox are you using?
NetBox 3.3.X supports tags for:

/dcim/platforms/
/dcim/manufacturers/
/virtualization/cluster-types/
virtualization/cluster-groups/

You can check it here: https://demo.netbox.dev/api/docs/

Hi,
Any updates on that?

Hi @bb-Ricardo, thanks for your fast reply!
Seems like our automatic update broke and therfore we are currently on 3.0.11, so this is expected.
Sorry for the false error report and thanks for pointing that out :D

Hi @bb-Ricardo, thanks for your fast reply! Seems like our automatic update broke and therfore we are currently on 3.0.11, so this is expected. Sorry for the false error report and thanks for pointing that out :D

No worries, thanks for getting back


Feature request: Unix socket support

Hi,
Do you have a plan to include unix socket support?
I think, it would be great for in-memory and dockerized versions with shared socket instead of linked containers.
I was playing with this option and created  unix socket factory for OrientDB which uses Java JNA.
Here's the working sample https://github.com/tommys-place/orientdb_unixsocket_driver with instructions how to install and use with OrientJS from NodeJS.
What do you think?!

@tommys-place nice contribution! What dependencies does it need?

Thx,
Only jna.jar lib, but it is already included in OrientDB lib. So, in IDE is enough to include jars from OrientDB/lib. THere is no additional libs.

@tommys-place So we could also support this in the core, right? WDYT about creating a Pull Request for "2.2.x" branch?

You can use it in the server mode.
For Pull request, some parts are forks from other GitHub projects. Forks are listed under Credits at the end of Readme (all have Apache license) but reading terms and conditions for contributing at https://github.com/orientechnologies/orientdb/blob/master/CONTRIBUTING.md , maybe you will need clearance from them ?

Please see this link
http://programmers.stackexchange.com/questions/56927/what-are-the-real-life-implications-for-an-apache-2-license
I was thinking, if those parts are under Apache 2.0, basically I can use it and modify it but have to keep their author names in code parts. So, possibly there is no problem?! I was not aware of possible license issue until I tried to made pull request.

Hi @tommys-place, if you can do the PR I can see the contributed files.

Hi,
It's done here... https://github.com/kohlschutter/junixsocket/issues/17
I will wait him for review and comments before making pull request here.
Stay tuned :)

Cool, thanks.

Not relevant anymore. Closing it.


output "leaner" CSS (include only what is needed)

If I click Download as Presentation (.html) in Jupyter, I get 11000 lines of CSS; is there any way to just include the .css that is actually used? Somehow this seems excessive.

Yeah. You are getting this any time you use the notebook on, say, nbviewer... it just does it in multiple files. Among the challenges: one of the goals of nbpresent is to end up with archival, offline assets. So we are stuck putting the style in the file. Further, since notebooks are so dynamic, we basically have to ship something as close to the authoring environment as possible.
Confounding this, the notebook doesn't make every user install a front-end asset build chain (css, js, etc.) so we pretty much have to ship the whole kitchen sink. Doing "live" builds would theoretically make this better. It seems increasingly likely that a future notebook/nbconvert may include several transpilers that would more capable of performing these calculations, but for now, I don't think it's going to change!


qt: Disable requests context menu actions when appropriate

The recent requests table will allow you to copy data points even if they do not exist. This PR implements checks to disable the copy label, copy message, and copy amount context menu actions if the respective fields are empty. This brings the recent requests table context menu behavior closer to the behavior seen in the transaction view.
On a payment request entry which does not have a value for label, message, or amount:

Master
PR

copy URI never needs to be disabled as an entry in the recent requests table must have a URI even if it doesn't have a label, message, or amount. #213 will add a copy address context menu action. This also does not need a check as an entry must be associated with an address.
Below are some more examples of how this PR will behave:
Has Label, Message, and Amount

Has Label and Amount, but no Message

utACK 69915b80ccf853b66345b3d612d24eddd3411a2a - I guess comparing against zero for an "empty" amount is acceptable here.

utACK 69915b8 - I guess comparing against zero for an "empty" amount is acceptable here.

Comparing against zero is what's used to determine (no amount requested) in recentrequeststablemodel.cpp Line 84

Concept ACK.

updated 69915b8 -> 336a643
Addressed @Talkless suggestions, thanks for the review!
Changes:

variables that can be const are made const
refactor context menu action disable logic from using setEnabled with negations to using setDisabled without negations

Concept ACK.

updated from 336a643  -> 3f83f05f52be8f3bac2267d447b5037409cde17d, thanks @hebasto @MarcoFalke for the review
Changes:

Adhere to clang-format
req is made to be a const reference as that makes more sense

🐙 This pull request conflicts with the target branch and needs rebase.
Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".

Updated from 3f83f05 -> bb3da8f
Changes: Resolve conflict with #213


"onVisibleBehindCanceled" is deprecated in Android O

Hi,
I notice the file "ExoPlayerActivity.kt" overrides "onVisibleBehindCanceled", which is deprecated in Android O (link). As the official document says, "onVisibleBehindCanceled" cannot get chance to execute since Android O and will be removed in the future release.
So you may prevent putting some important operations in it.
Hope the information can help you. :)

Hi,
thank you for the hint. I saw that myself, but copied it from another project in order to make Amazon happy during 34C3. Luckily, I found another way to resolve problems the Amazon testers were having with the App. On develop it is already gone and as far as I remember it is also gone since the stable 2.0.0 release.


Issue with launching multiple accounts at once

Recently whenever i want to launch 3 of my accounts they only get launched 1 by 1 (in sequence basically) , what that means?
I have account A,B,C and when I run A other 2 will not run until I close A, after closing A, B account will open but C won't etc..
I tried uninstalling, resetting all LB settings and re adding accounts but still same issue occurs.
I'm using arcpds and d912pxy.

Forgot to mention.
First time running 3 at once they show up in Task Manager but they don't show up in Start menu Taskbar.

Duplicate with #230 . :)


Cannot import Camera2Formats using Android Studio

Camera2Formats seems to depend on "Common" which is not available when you import it through the Android Studio "New -> Import Sample..." dialog.
Repro:

open Android Studio
New -> Import Sample... -> Camera2Formats
Try to build

Expected:

it builds

Observed:

"Unable to resolve dependency for ':app@debug/compileClasspath': Could not resolve project :common"

A temporary workaround is to clone the Github repo instead, so it's not currently a blocker for developers. We will investigate how to fix importing directly from Android Studio.


Correct encryption test dependencies

Grrr - this is misbehaving in travis, where it didn't locally. Will fix.

Superceded


Bug

https://pastebin.com/raw/e6UPe5Gw

that pastebin is not available.

Does this one work?
https://paste.ee/p/7gjRg


[Catalog] Meshery.io site builds with errors of malformatted YAML in catalog content

Description
Meshery.io site builds with errors of malformed YAML in catalog content
Expected Behavior
No error during build.
Screenshots
Use `bundle info [gemname]` to see where a bundled gem is installed.
Configuration file: /Users/lee/code/meshery.io/_config.yml
            Source: /Users/lee/code/meshery.io
       Destination: /Users/lee/code/meshery.io/_site
 Incremental build: enabled
      Generating...
             Error: YAML Exception reading /Users/lee/code/meshery.io/collections/_catalog/deployment/d6a40cd8-3c13-4920-a96c-b6278836565e.md: (<unknown>): did not find expected key while parsing a block mapping at line 2 column 1
      Sort warning: 'patternId' not defined in _catalog/deployment/d6a40cd8-3c13-4920-a96c-b6278836565e.md
      Sort warning: 'patternId' not defined in _catalog/deployment/d6a40cd8-3c13-4920-a96c-b6278836565e.md
      Sort warning: 'patternId' not defined in _catalog/deployment/d6a40cd8-3c13-4920-a96c-b6278836565e.md
      Sort warning: 'patternId' not defined in _catalog/deployment/d6a40cd8-3c13-4920-a96c-b6278836565e.md
      Sort warning: 'patternId' not defined in _catalog/deployment/d6a40cd8-3c13-4920-a96c-b6278836565e.md
       Jekyll Feed: Generating feed for posts
                    done in 6.878 seconds.
 Auto-regeneration: enabled for '/Users/lee/code/meshery.io'
LiveReload address: http://<IP_ADDRESS>:35729
    Server address: http://<IP_ADDRESS>:4000/
  Server running... press ctrl-c to stop.

Enviroment:

OS: Mac Linux Windows
Browser: Chrome Safari Firefox
Version:
Device: Desktop Mobile

Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the master branch.

📚 See the Contributing to Meshery.io Website section of the readme.md and other contributing instructions, too.
🎨 Wireframes and designs for Meshery UI in Figma (open invite)
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

@leecalcote Can I work on this issue?

@Yashsharma1911, @dusdjhyeon, is this still an issue?


bump airplay2  version

This upgrades Shairport version.
https://github.com/mikebrady/shairport-sync/releases

@vipulgupta2048 any chance you could approve this PR ?
I tried it on a fleet and it runs without issue.
I had to update the build step as it was failing for me.


Abort in coex_init in ESP-IDF 4.1-beta2 (IDFGH-3467)

Hello there!
During Wi-Fi start in client mode, after BLE starts working in peripheral mode (Nimble) abort occurs.
When software coexistence switched off in sdkconfig everything is ok.
As far as I understand, this is some kind of bug.
sdkconfig.zip
Backtrace: 0x40094e70:0x3ffd1490 0x40095221:0x3ffd14b0 0x4016a6aa:0x3ffd14d0 0x400d4fd5:0x3ffd14f0 0x400d5239:0x3ffd1520 0x40176374:0x3ffd1560 0x4017643d:0x3ffd1580 0x401766c2:0x3ffd15a0 0x4017357e:0x3ffd15c0 0x4018b37a:0x3ffd15e0
0x40094e70: invoke_abort at .../esp-idf/components/esp32/panic.c:1590x40095221: abort at .../esp-idf/components/esp32/panic.c:174
0x4016a6aa: coex_init at ??:?
0x400d4fd5: esp_phy_rf_init at .../esp-idf/components/esp_wifi/src/phy_init.c:269
0x400d5239: esp_phy_load_cal_and_init at .../esp-idf/components/esp_wifi/src/phy_init.c:747
0x40176374: wifi_rf_phy_enable at ??:?
0x4017643d: wifi_hw_start at ??:?
0x401766c2: wifi_start_process at ??:?
0x4017357e: ieee80211_ioctl_process at ??:?
0x4018b37a: ppTask at ??:?

For the record, the issue is present in ESP-IDF v4.0.1 as well. Relevant log snippet:
I (1260) wifi:wifi driver task: 3ffda244, prio:23, stack:6656, core=1
I (1270) wifi:wifi firmware version: aa5336b
I (1270) wifi:config NVS flash: enabled
I (1270) wifi:config nano formating: disabled
I (1270) wifi:Init dynamic tx buffer num: 32
I (1270) wifi:Init data frame dynamic rx buffer num: 32
I (1280) wifi:Init management frame dynamic rx buffer num: 32
I (1280) wifi:Init management short buffer num: 32
I (1290) wifi:Init static rx buffer size: 1600
I (1290) wifi:Init static rx buffer num: 10
I (1300) wifi:Init dynamic rx buffer num: 32
I (1310) wifi:Set ps type: 0

abort() was called at PC 0x400f36f2 on core 1

ELF file SHA256: 33ef24acd6fe3ee2

Backtrace: 0x4008e76c:0x3ffda060 0x4008eb45:0x3ffda080 0x400f36f2:0x3ffda0a0 0x400d2758:0x3ffda0c0 0x400d28fc:0x3ffda0f0 0x400dd6c4:0x3ffda120 0x400dd78d:0x3ffda140 0x400dda1e:0x3ffda160 0x400da90a:0x3ffda180 0x4009a552:0x3ffda1a0

Rebooting...

Decoding stack results
0x4008e76c: invoke_abort at /usr/src/esp-idf/components/esp32/panic.c line 157
0x4008eb45: abort at /usr/src/esp-idf/components/esp32/panic.c line 172
0x400d2758: esp_phy_rf_init at /usr/src/esp-idf/components/esp_wifi/src/phy_init.c line 239
0x400d28fc: esp_phy_load_cal_and_init at /usr/src/esp-idf/components/esp_wifi/src/phy_init.c line 711

The issue does not show up when software control of WiFi/Bluetooth coexistence is disabled in the SDK config.

Thanks for reporting and updates, really sorry for slow turnaround, we will look into.

@thecashit @Alvin1Zhang @francescolavra I have faced the same issue
During enabled Software control WiFi/Ble coexisting when my phone tries to connect to device error occures:
LE connection complete. handle=0 role=1 paddrtype=1 addr=6d.77.b5.d5.54.40 local_rpa=<IP_ADDRESS>.0.0 peer_rpa=<IP_ADDRESS>.0.0 itvl=39 latency=0 spvn_tmo=500 mca=1
0x40 0x54 0xd5 0xb5 0x77 0x6d
connection established; status=0 handle=0 our_ota_addr_type=0 our_ota_addr=30:ae:a4:dd:9b:ee our_id_addr_type=0 our_id_addr=30:ae:a4:dd:9b:ee peer_ota_addr_type=1 peer_ota_addr=6d:77:b5:d5:54:40 peer_id_addr_type=1 peer_id_addr=6d:77:b5:d5:54:40 conn_itvl=39 conn_latency=0 supervision_timeout=500 encrypted=0 authenticated=0 bonded=0

ble_hs_hci_cmd_send: ogf=0x08 ocf=0x0007 len=0
0x07 0x20 0x00
Command complete: cmd_pkts=5 ogf=0x8 ocf=0x7 status=0
ble_hs_hci_cmd_send: ogf=0x08 ocf=0x0008 len=32
0x08 0x20 0x20 0x17 0x02 0x01 0x06 0x03 0x03 0x11 0x18 0x0c 0x09 0x73 0x74 0x75 0x66 0x66 0x2d 0x65 0x73 0x70 0x33 0x32 0x02 0x0a 0x03 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00
Command complete: cmd_pkts=5 ogf=0x8 ocf=0x8 status=0
GAP procedure initiated: advertise; disc_mode=2 adv_channel_map=0 own_addr_type=0 adv_filter_policy=0 adv_itvl_min=0 adv_itvl_max=0
ble_hs_hci_cmd_send: ogf=0x08 ocf=0x0006 len=15
0x06 0x20 0x0f 0x30 0x00 0x60 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x00 0x07 0x00
Command complete: cmd_pkts=5 ogf=0x8 ocf=0x6 status=0
ble_hs_hci_cmd_send: ogf=0x08 ocf=0x000a len=1
0x0a 0x20 0x01 0x01
Command complete: cmd_pkts=5 ogf=0x8 ocf=0xa status=0
ble_hs_hci_cmd_send: ogf=0x08 ocf=0x0016 len=2
0x16 0x20 0x02 0x00 0x00
Command Status: status=0 cmd_pkts=5 ocf=0x16 ogf=0x8
LE Remote Used Features. handle=0 feat=ff 00 00 00 00 00 00 00
LE Remote Connection Parameter Request. handle=0 min_itvl=6 max_itvl=6 latency=0 timeout=500
ble_hs_hci_cmd_send: ogf=0x08 ocf=0x0020 len=14
0x20 0x20 0x0e 0x00 0x00 0x06 0x00 0x06 0x00 0x00 0x00 0xf4 0x01 0x00 0x00 0x00 0x00
Command complete: cmd_pkts=5 ogf=0x8 ocf=0x20 status=0
ble_hs_hci_evt_acl_process(): conn_handle=0 pb=2 len=11 data=0x07 0x00 0x04 0x00 0x10 0x01 0x00 0xff 0xff 0x00 0x28
rxed att command: read group type req; conn=0 start_handle=0x0001 end_handle=0xffff
txed att command: read group type rsp; conn=0 length=6
host tx hci data; handle=0 length=24
ble_hs_hci_acl_tx(): 0x00 0x00 0x18 0x00 0x14 0x00 0x04 0x00 0x11 0x06 0x01 0x00 0x05 0x00 0x00 0x18 0x06 0x00 0x09 0x00 0x01 0x18 0x0a 0x00 0x0e 0x00 0x00 0x18
D (10445) CurrentSensor: count >= 1000: _voltage = 78mV

D (10449) NimBleGattChar: Connection handle: 0, Value handle: 24
GATT procedure initiated: notify; att_handle=24
txed att command: notify req; conn=0 handle=0x0018
host tx hci data; handle=0 length=15
ble_hs_hci_acl_tx(): 0x00 0x00 0x0f 0x00 0x0b 0x00 0x04 0x00 0x1b 0x18 0x00 0x4e 0x00 0x00 0x00 0x00 0x00 0x00 0x00
Number of Completed Packets: num_handles=1
handle:0 pkts:1
ble_hs_hci_evt_acl_process(): conn_handle=0 pb=2 len=11 data=0x07 0x00 0x04 0x00 0x10 0x0f 0x00 0xff 0xff 0x00 0x28
rxed att command: read group type req; conn=0 start_handle=0x000f end_handle=0xffff
Guru Meditation Error: Core 0 panic'ed (LoadProhibited). Exception was unhandled.

Core 0 register dump:
PC : 0x4018fb33 PS : 0x00060530 A0 : 0x800e8b6b A1 : 0x3ffe2e80
A2 : 0x00000000 A3 : 0x00000000 A4 : 0x00000000 A5 : 0x3ffdbb90
A6 : 0x00000000 A7 : 0x00000000 A8 : 0x800ebe80 A9 : 0x3ffe2e80
A10 : 0x3ffdbb90 A11 : 0x00000000 A12 : 0x3ffdbba8 A13 : 0x00000000
A14 : 0x00000000 A15 : 0x00000000 SAR : 0x00000008 EXCCAUSE: 0x0000001c
EXCVADDR: 0x00000000 LBEG : 0x4000c349 LEND : 0x4000c36b LCOUNT : 0xffffffff

Backtrace:0x4018fb30:0x3ffe2e80 0x400e8b68:0x3ffe2ea0 0x400ed82e:0x3ffe2ec0 0x400edc01:0x3ffe2f00 0x400ede12:0x3ffe2f30 0x400edefe:0x3ffe2f80 0x400eec33:0x3ffe2ff0 0x400e2645:0x3ffe3040 0x400e1b7e:0x3ffe3070 0x400e107d:0x3ffe30a0 0x400e108f:0x3ffe30c0 0x400ebc82:0x3ffe30e0 0x400d9712:0x3ffe3100 0x4008e741:0x3ffe3120

I have also mentioned this issue in the forum https://www.esp32.com/viewtopic.php?f=13&t=6707&start=50 and https://www.esp32.com/viewtopic.php?f=20&t=7450
@Alvin1Zhang When it will be fixed ? Is there any update on this issue ?

@Alvin1Zhang In 4.2-beta2 I do not see crash and seems like Ble and WiFi works simultaneously, but service discovery does not work and I cannot know available services on device

Hello @thecashit @francescolavra , In coex, we should enable Wi-FI power save mode, and it seems like that you have close it with esp_wifi_set_ps(WIFI_PS_NONE);. Please make sure that Wi-FI power save mode is enabled and test again. Thanks.

Hello @redchenjs, your issue seems like different, could you please provide you .elf file?

😅Oops!

Hello @redchenjs, your issue seems like different, could you please provide you .elf file?

@blueMoods Unfortunately I cannot provide the .elf currently ... just try WiFi joinSta and Ble with all coex options enabled

Hello @thecashit @francescolavra , In coex, we should enable Wi-FI power save mode, and it seems like that you have close it with esp_wifi_set_ps(WIFI_PS_NONE);. Please make sure that Wi-FI power save mode is enabled and test again. Thanks.

@blueMoods What option should be ? esp_wifi_set_ps(WIFI_PS_MAX); ?

Hello @thecashit @francescolavra , In coex, we should enable Wi-FI power save mode, and it seems like that you have close it with esp_wifi_set_ps(WIFI_PS_NONE);. Please make sure that Wi-FI power save mode is enabled and test again. Thanks.

@blueMoods What option should be ? esp_wifi_set_ps(WIFI_PS_MAX); is it proper value ?

WIFI_PS_MIN_MODEM and WIFI_PS_MAX_MODEM are both OK.

Hello @thecashit @francescolavra , In coex, we should enable Wi-FI power save mode, and it seems like that you have close it with esp_wifi_set_ps(WIFI_PS_NONE);. Please make sure that Wi-FI power save mode is enabled and test again. Thanks.

@blueMoods What option should be ? esp_wifi_set_ps(WIFI_PS_MAX); is it proper value ?

WIFI_PS_MIN_MODEM and WIFI_PS_MAX_MODEM are both OK.

@blueMoods Okay, I will try but last time when I tried these values it does not work for me. Bluetooth discovery did not work at that time

Hello @thecashit @francescolavra , In coex, we should enable Wi-FI power save mode, and it seems like that you have close it with esp_wifi_set_ps(WIFI_PS_NONE);. Please make sure that Wi-FI power save mode is enabled and test again. Thanks.

@blueMoods What option should be ? esp_wifi_set_ps(WIFI_PS_MAX); is it proper value ?

WIFI_PS_MIN_MODEM and WIFI_PS_MAX_MODEM are both OK.

@blueMoods I've checked, I've already have enabled esp_wifi_set_ps(WIFI_PS_MAX); on join STA, but service discovery does not work ... When I remove join STA code, service discovery works

I can confirm this issue, happening if BLE and WiFi operate in coex mode, but does not happen if BLE stacked is unused.
15:39:40.223 > [I][main.cpp:438] setup(): Starting Wifi...
15:39:40.257 > abort() was called at PC 0x40171cb6 on core 0
15:39:41.022 >
15:39:41.022 > ELF file SHA256:<PHONE_NUMBER>000000
15:39:41.022 >
15:39:41.022 > Backtrace: 0x400956b8:0x3ffe1060 0x40095931:0x3ffe1080 0x40171cb6:0x3ffe10a0 0x4017838c:0x3ffe10c0 0x401785ea:0x3ffe10f0 0x401874ec:0x3ffe1120
0x401875b9:0x3ffe1140 0x4018760b:0x3ffe1160 0x40184742:0x3ffe1190 0x401b6202:0x3ffe11b0 0x4009698a:0x3ffe11e0
15:39:41.022 >   #0  0x400956b8:0x3ffe1060 in invoke_abort at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp32/panic.c:715
15:39:41.022 >   #1  0x40095931:0x3ffe1080 in abort at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp32/panic.c:715
15:39:41.022 >   #2  0x40171cb6:0x3ffe10a0 in coex_init at ??:?
15:39:41.022 >   #3  0x4017838c:0x3ffe10c0 in esp_phy_rf_init at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp32/phy_init.c:524
15:39:41.022 >   #4  0x401785ea:0x3ffe10f0 in esp_phy_load_cal_and_init at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/esp32/phy_init.c:673
15:39:41.022 >   #5  0x401874ec:0x3ffe1120 in wifi_rf_phy_enable at ??:?
15:39:41.022 >   #6  0x401875b9:0x3ffe1140 in wifi_hw_start at ??:?
15:39:41.022 >   #7  0x4018760b:0x3ffe1160 in wifi_set_promis_process at ??:?
15:39:41.022 >   #8  0x40184742:0x3ffe1190 in ieee80211_ioctl_process at ??:?
15:39:41.022 >   #9  0x401b6202:0x3ffe11b0 in ppTask at ??:?
15:39:41.022 >   #10 0x4009698a:0x3ffe11e0 in vPortTaskWrapper at /home/runner/work/esp32-arduino-lib-builder/esp32-arduino-lib-builder/esp-idf/components/freertos/port.c:355 (discriminator 1)
15:39:41.022 >
15:39:41.022 > Rebooting...

Hello!
I experience the same isse on esp-idf v4.2.2, calling esp_wifi_set_ps(WIFI_PS_MIN_MODEM) does not solve/hide the issue.
Are there any solution for this crash ? When CONFIG_ESP32_WIFI_SW_COEXIST_ENABLE is disabled, the crash does not happen, however based on https://docs.espressif.com/projects/espressif-esp-faq/en/latest/software-framework/coexistence.html it is advised to enable it, isn't it ?

avoids this issue, so could be used as workaround - but i assume lowering power on wifi will have side effects

@cyberman54 esp_wifi_set_ps(WIFI_PS_MIN_MODEM) is used to set Wi-Fi power save mode, instead of  lowering power.


%5Btool_crash%5D StateError%3A Bad state%3A No context with the running Dart application.

%23%23 Command%0A%60%60%60%0Aflutter run%0A%60%60%60%0A%0A%23%23 Steps to Reproduce%0

Hi @wellintj ,
When opening an issue, please try to provide all or some of the information indicated in the template.

Issue Template
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
- https://flutter.dev/
- https://api.flutter.dev/
- https://stackoverflow.com/questions/tagged/flutter?sort=frequent

If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports

Steps to Reproduce

Please tell us exactly how to reproduce the problem you are running into.

Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.

If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.

1. ...
2. ...
3. ...

Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?

Target Platform:
Target OS version/browser:
Devices:

Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.

Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.

Finally, paste the output of running `flutter doctor -v` here.

Closing this issue, since no information has been provided.
Thank you.


Remove invalid include

Not sure what the purpose of this was, but removed as it causes errors to appear in the TextMate logs when parsed.

@shadanan Did you get a chance to look into this? It's also causing errors when compiling for GitHub.com (see github/linguist#3924 for further information).

Sorry, I didn't see this message. I no longer maintain this repo, but I merged your change.

@shadanan Thanks!


ScreenSize

Trying .xshow screensize
only get value of X not give value of Y.

confirmed it seems to return always 0

I tried with client 5.0 and it works, so something in the packet with clients above 7.0

Fix sent, more resolution can be added if needed. I think it should works fine.


Git completion causes unkown option  error

Currently, enabling git completion with git<2.18 installed results in this:
unknown option: --list-cmds
usage: git [--version] [--help] [-C <path>] [-c <name>=<value>]
           [--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
           [-p | --paginate | --no-pager] [--no-replace-objects] [--bare]
           [--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
           <command> [<args>]

See e.g.: https://apple.stackexchange.com/questions/327817/git-completion-bash-producing-error-on-macos-sierra-10-12-6

That's probably caused by an update to the Git completion here in Bash-it. One reason why I'm not a huge fan of these completions here. For things like Git completion, I prefer to rely on the system's autocompletion scripts, which can be enabled through the system-completion plugin. Doing this ensures that the Git autocomplete script refers to the installed version of Git on your system.

@con-f-use can you show me the git version? I am the one updated the completion on the latest git version. I'm using use both mac and linux, the conflicts are rising with different git distributions and versions. So, I agree with @nwinkler to use system-completion.

Sure, it's git version 2.17.1 which is the stock that the current long-term support version of Ubuntu comes with.

The version I updated is git version 2.21.0 as my pull request.  I always use the latest stable, that's the problem, you should use system-completion, If you're using Ubuntu, you can check the content of /etc/profile.d/bash_completion.sh, you can see sources of bash completions.

To solve this, we can create formulas like homebrew, it will solve versioning, so solve the license problem in #512

@con-f-use , I installed git by apt installed -y git on a docker image of ubuntu:18.04 and check what bash completion ubuntu provide for git, unfortunately only git-prompt is provided
root@cefb47b88692:/etc# cd bash_completion.d/
root@cefb47b88692:/etc/bash_completion.d# ll
total 16
drwxr-xr-x 2 root root 4096 May  1 06:28 ./
drwxr-xr-x 1 root root 4096 May  1 06:28 ../
-rw-r--r-- 1 root root  439 Nov 26 14:20 git-prompt

Could you this of any other source of bash completion for git?

This issue is very stale, so I close it. Thanks for contributing and posting!


HHH-13129 (5.3) Cascaded merge fails for detached bytecode-enhanced entity with uninitialized ToOne

https://hibernate.atlassian.net/browse/HHH-13129

Merged.


Fix typeerror exception when importing dynamic data of synchronous machines

Issue #23

@martinmoraga could you please add the dco sign off? Then this can be merged.

Has this been fixed in CIMgen? Fixing it just here wont help anybody in the long run as the changes will get lost when the code gets regenerated.

Has this been fixed in CIMgen? Fixing it just here wont help anybody in the long run as the changes will get lost when the code gets regenerated.

I agree. My intention was to create an issue in cimgen when merging this so that we don’t forget this issue.

@martinmoraga could you please add the dco sign off? Then this can be merged.

@m-mirz Done!
But the pipeline fails now with the error:
Branch "23-typeerror-exception-when-importing-dynamic-data-of-synchronous-machines" is not allowed to deploy to github-pages due to environment protection rules.

But the pipeline fails now with the error

Okay, thats my fault. Sorry I will have a look

This is covered in #39 and also fixed in cimgen thanks to @tom-hg57


Update to 1.21.1?

I just want to use this with some other mods that mysteriously skipped 1.21

That would be because 1.21.1 was a hotfix version for Minecraft. It made no significant changes to the code, and is therefore compatible with 99.9% of mods.
Only reason Interactic isn't denoted 1.21+ is because it never needed a patch since that release

Ah. Well, the Modrinth app is finicky about versioning, is there a way to just mark the existing files as 1.21.1 compatible? Not a huge issue, but it was going to made me switch mods because I didn’t know.


Add license header check workflow

Description
Adds license header check for all files.
Here's the workflow running on my fork -- https://github.com/harshavamsi/opensearch-py/actions/runs/3069009234
The PR also updates the license headers according to the current standard -- https://github.com/opensearch-project/.github/blob/main/CONTRIBUTING.md#python-ruby-shell
Issues Resolved
Closes #200
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Thank you for adding this @harshavamsi! I might be missing something here but there is a script in utils/license-headers.py which also checks for licenses. Do we need the new script as well or can be combined into one?

@VachaShah I took a look at that. I am not sure why it does not trigger a failure run when licenses are not present. I wanted to bring in a workflow across all clients with this.

Got it. Can we see if it is not used anymore since you added this workflow? If the same work is done by the new workflow, maybe we can remove it?

@harshavamsi Want to finish this?

I see we're rolling out our own shell scripts? Is there really no good python library to check headers? e.g. https://pypi.org/project/license-header-check/?

@harshavamsi should we close this?


RPP OpenMP threads update

@kiritigowda @rrawther This PR needs to be merged together with an upcoming PR in MIVisionX for ToT to be in sync.
The MIVisionX PR will be issued in the next few days. The RPP#143 and MIVisionX PRs can be tested merged after that.
Adds numThreads as a parameter in RPP handle for HOST backend functionalities.
Modifies all BatchPD and Tensor functionalities with a common change to use this numThreads parameter

@r-abishek does this PR break functionality/build with the current version of MIVisionX? if yes, can we update the version to 1.1.0?

@kiritigowda Yes, the numThreads needs to be passed to RPP functions from MIVisionX, and that will be a separate PR in MIVisionX. We'll run tests and confirm compatibility next week before merging either PRs.

@kiritigowda This PR can be merged along with PR1060 in MIVisionX


error

Please describe what you were doing when this error happened.
Specifications

OS: darwin
IPFS Desktop Version: 0.9.7
Electron Version: 6.0.12
Chrome Version: 76.0.3809.146

Error
Error: net::ERR_NETWORK_IO_SUSPENDED

Please upgrade to v0.13.2, feel free to reopen if the problem still occurs.


Define component (footer/header) styles

Ideate what header/nav/footer styles can look like for PDS
Work with Anil to converge on a solution
Create in Figma

Anil and Edward have pro figma account and work on the same project.
Eddie can access the project.
Some objects are available there but the PDS design is not pushed on these objects yet. Will be done next.

Header consists of:

Done on Edward side but waiting for validation from IMG node.

Propagate in Figma decision made last sprint.

We would need to discuss how the first release of the design system will be delivered and how the later updates will be done.
This was still unclear to Edward and myself during the planning meeting today and Edward said the github integration will require more work than the 1 week discussed yesterday.
One alternativate could be to have releases in dedicated workspace in FIGMA. Developpers (Eddie, Catherine) would use this workspace as input for their developments.

@edwardbarraza prepared delivery for @c-suh
Some cleaning going on in sigma but on track, should be completed later today.

@edwardbarraza have you been able to complete this task ? It sounds like it is done except maybe the extract to github for communication purpose.

Hey @tloubrieu-jpl this is done. I created a dedicated workspace for the app bar deliverable and gave Catherine and Eddie access. I also looked in to Relay for Figma (continuous delivery) - still have to set it up.

I created a new ticket for Relay for Figma (https://github.com/NASA-PDS/PDS.nasa.gov-UX/issues/54).
Close this one


trail

fixed issue

Thanks @Suyash-Purwar for your detailed review. Looks like the contributor is not in contact for a long time.
I will change the link and merge it for now.

Thanks @Suyash-Purwar for your detailed review. Looks like the contributor is not in contact for a long time.
I will change the link and merge it for now.

Glad to know I was of help! Looking forward to contribute further. 😀

Glad to know I was of help! Looking forward to contribute further. 😀


[Feature] Add on transactions window the transactions received too

Feature description
Add on transactions window the transactions received too. For now only appear the transactions we sent.

@reneaaron @rolznz wdyt?

@lujakob Yes, this is a feature we are currently planning. Happy to get your help with that! 🙌
As we are currently thinking about unifying the incoming / outgoing transactions I think this page could be a good fit to implement this as a proof of concept before changing the Home screen to the unified view as well.
For the unified transaction lists we would need to introduce some "+" and "-" icons to recognize incoming and outgoing transactions respectively.
Also we could think of filtering the outgoing transactions on an account basis as the account id is now also saved for outgoing payments.
To summarize:

Load the incoming transactions on the transactions page, too
Filter the outgoing transactions per account
Some minor UI changes to make it obvious which transactions are incoming / outgoing

Does that sound like a plan to you @lujakob?

@reneaaron Sounds good.
The list of transactions "unified" means there is only one list showing all transactions. To separate outgoing/incoming we would add +/- icons. (I remember someone talking about tabs for incoming/outgoing. This idea is discarded I guess?)
Can I already get started on this, or we have dependencies or waiting for further design details?

@reneaaron @escapedcat  I checked the code. Some thoughts on the approach of unifying transactions, as it is relevant to pagination. To unify incoming and outgoing transactions I have to get entities from two sources. Outgoing transactions are IndexDB transactions and incoming transactions are invoices from the connector. The connector invoices are unpaginated and come altogether. The IndexDB payments could be paginated, however I think it could be tricky to integrate the two sources and have a feasible paginated source. The easy way would be to get all payments, all invoices, combine and sort them, and send only the relevant "page" as a response to the component. However this would render the IndexDB performance improvement irrelevant. Only the UX improvement of a pagination for the user would be left. (Showing e.g. 100 transactions at a time) I guess as the data from IndexDB doesn't come from a slow network request, but from a local memory source, it could still be fast enough. If not, getting reliable paginated data from two sources could get pretty tricky. What do you think?

@reneaaron @escapedcat At which part of the code should the integration/aggregation of the two sources happen? I would suggest to create a folder extension/background-script/actions/transactions/list.ts. Even though the transactions are an aggregated source of entities from extension/background-script/actions/ln/invoices.ts and extension/background-script/actions/payments/all.ts I think it makes sense, because from a frontend/component point of view I want to request the data in the same way as I request any other entity source using the api interface. At least I would not aggregate/integrate the data in the component, as this might be reused. What do you think?

The list of transactions "unified" means there is only one list showing all transactions. To separate outgoing/incoming we would add +/- icons. (I remember someone talking about tabs for incoming/outgoing. This idea is discarded I guess?)

Yes. The bigger plan is to unify them. We'll have to see if that works out as there are some problems that need to be solved for that.

Can I already get started on this, or we have dependencies or waiting for further design details?

I don't think there are many new things in here (except for the icons) so I think we can go ahead.
Pagination
After some more thoughts that could really be a tricky problem. We would need to fetch and fill the unified array from the two sources until we have enough transactions to return. 🤔 I also think that this should be done in a central place, there should be one method that allows you get unified transaction data that is sorted & can be paginated.

However this would render the IndexDB performance improvement irrelevant.

Which improvement do you mean here?

I think it makes sense, because from a frontend/component point of view I want to request the data in the same way as I request any other entity source using the api interface. At least I would not aggregate/integrate the data in the component, as this might be reused. What do you think?

+1 for creating some new apis and not doing that in the component. The Home view will hopefully also be able to use this data soon.

However this would render the IndexDB performance improvement irrelevant.

Which improvement do you mean here?

One reason in favour of paginated data is it improves time loading data. In normal SPA it improves network request time if data is fetched paginated. In our case we don't have network requests, but query the IndexDB. I cannot paginate the IndexDB payments however, because I need to merge the results with invoices. If a page has 100 transactions, and sorted by createdAt it will consist of 87 payments from IndexDB and 13 invoices from the connector, this ratio can only be known after merging and sorting the data. So the information for querying paginated data (pageSize, currentPage) will vary for each page and is very hard to keep track of and calculate for each new page. For this reason we have to fetch all payments, merge with invoices and return a paginated result set. You know what I mean? Any opinions on this?

@reneaaron thanks for your proposals, but your suggestion does't help me. But it got me knew ideas, and new problems.
First of all, I did some further research and a lot of connectors don't provide getInvoices functionality and show an error instead. I checked the docs for Lightning Core and they do not provide pagination yet. I created an issue and apparently there is a workaround, but not sure if it's possible. Another problem is, the enable a proper pagination component, the total amount of invoices is necessary. Afaik, this is not provided. I think for Core Lightning connector we're not able to provide it yet.
Regarding LND, it is possible to receive paginated data, however it is not possible to get the total number of invoices. Without, I am able to have a "load more" style pagination, but it's not possible to know and display the total number of pages.
Second: even though we might have all data and params to paginate invoices, still we have the issue of combining the data. And from my understanding of it there is a problem I cannot overcome (yet). I am talking about the backend-script/actions part here.
The first challenge is, the ratio of numbers of payments and invoices is not predictable for each page. For the first page this is irrelevant. Assuming a pageSize of 100, I just request 100 payments and 100 invoices, join the results, order by date and pick the first 100. Then I know I have e.g. 70 payments and 30 invoices in it. So in the response to the UI I send the first 100 transactions and pass along the offsets separately. The invoicesOffset is 30 and the paymentsOffset is 70. For page 2 I pass those in the request and I can just do the same thing again, getting 100 each starting with the relevant offset. So for the second result set of 200 (100 payments and 100 invoices) I sort by date and pick the first 100 and find 60 payments and 40 invoices. I add those to the offset from before to have a new invoiceOffset of 70 (30 + 40) and a paymentsOffset of 130 (70 + 60).
So this is no problem if I go from one page to the next. The problem however is, if I want to jump from page 1 to any other page than the next. So if I jump from page 1 to let's say page 4, I cannot now what each offset is, because they are not predictable. I can only build them up one after the other. Usually in a pagination of a single source I can tell the offset for page 4 with pageSize 100 is 4 * 100 = 400. But with two varying sources I cannot predict. Also navigating back would be a problem I guess.
To make it work I would need to combine the whole transactions data (payments and invoices) sort them, and from this source get the paginated data.
So we could for example on page load or connector change get the first page and in the background iterate over all invoices requests. Once finished combine them with payments and hold this in the Zustand state. Once this is done, show the paginator. This is already quite complex. I already don't really like it. But then what happens on account change? The connector changes, all invoices get loaded again. This has some delays. I'm not really happy with this.
So I don't see a good solution. What do you guys think?


Built-In Marker Interfaces

Since now, the generated events, commands, and rejections are marked with EventMessage, CommandMessage, and RejectionMessage marker interfaces respectively.

@armiol, PTAL.


release.json: bump last stable version

What does this PR do?
Bumps the last stable version

Motivation
Ensuring our package size checks are based on the latest release

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

/merge


Allow creating or updating in batches

API Docs: https://developers.hubspot.com/docs/methods/contacts/batch_create_or_update

Love it! Can't wait to see it merged!

Why this hasn't been merged yet?
Given Hubspot 10K/day limit, this feature would make this gem AWESOME!

@adimichele I've fixed the conflicts

@dan987 @adimichele I've fixed the conflicts


advanced cucumber report fix

The advanced cucumber reports are not getting generated due to the verify goal changes, which was added earlier in the GCS copy PR. The issue is also observed in google cloud tests. Hence removing this change.

The change contains removal of a goal to generate advanced cucumber reports, merging the PR.


WebP Type Plugin

Would be nice!
    Unsupported MIME type: image/webp

:(

Totally agree. If there's a library out there than can read it and return it as an RGBA bitmap array then it's totally got a home here.

@oliver-moran you could mark it as help wanted

Same issue^^, let's hope the library coming

How difficult could it be to encapsulate libWebP as Node.js addon?

@aurium https://github.com/webmproject/libwebp libwebp on github
https://github.com/lovell/sharp uses libwebp.
There`s also this project https://github.com/Intervox/node-webp

Nice @webcaetano! I could not fast discover how sharp uses libwebp, however it looks to be the path...
About node-webp, sadly is only a wrapper for cwebp and dwebp binaries and it can't return pixel buffer.

https://github.com/lovell/sharp uses libvips.

Wouldn't adding those native addons as dependencies break browser support? Jimp couldn't use those as dependencies and still claim its self as "An image processing library written entirely in JavaScript for Node, with zero external or native dependencies."

If you are using Jimp in the frontend, then you're right. I don't know if the author of Jimp intends for it to be supported by browsers -- "for Node" to me means to be run on the server. Regardless, I'm doing an experimental migration to Sharp, since I don't have a concern of browsers.

would still break the "zero native dependencies"  part of the goal. The native APIs switch often, I believe it is an asset to have a library like this that does not depend on them.

well i intend to use that on server side and do NOT want to use sharp, as it's too bloated and requires compilation upon installation which poses a risk when deploying to production.
all i want is a small and fast library able to convert webp and png images to jpeg. that's it. nothing else. nothing fancy, no compilation of any native stiff. how come it's still hard in 2018? :)

@binarykitchen feel free to write a JS library the decode/encodes webP! Could be a really cool project

here's the spec https://developers.google.com/speed/webp/docs/riff_container

and here is the c++ code for the decoder in libwebp https://github.com/webmproject/libwebp/blob/master/src/dec/webp_dec.c
I'd be interested in doing this project with someone if they want to.

or we could try to use web assembly

https://medium.com/@kennethrohde/on-the-fly-webp-decoding-using-wasm-and-a-service-worker-33e519d8c21e

any update?

it would be perfect to get WebP on Jimp, any updates?

I also support implementing WebP on Jimp. Bumping after six months.

feel free to write a JS library the decode/encodes webP! Could be a really cool project

Since there is still no JS-based webP encoder/decoder, this still cannot be accomplished. The only way this happens is if we start to use a WASM port of the webP encoder/decoder. Happy to accept PRs, but I cannot devote the time to this endeavor myself.
I think the best path forwards to enabling webP + fixing all the memory and size issues is rewriting all the encoders/decoders to use the wasm compliled binaries of the original image type implementation (webp, jpeg, png). I tried to do this a few months ago and hit roadblocks. I might be able to try again in a few months, but no time soon

There may be a solution to the WebP problem. I have found a workaround which, although not the most graceful method, gets the job done and allows jimp to use WebP images by converting them to png format using the webp-converter npm module. I'm not sure how this could be implemented into the jimp code though
return new Promise(async (resolve, reject) => {
    // Check if .webp, requires additional handling
    if(imgUrl.match(/(\.webp)/gi)) {
        // Get .webp image
        const file = fs.createWriteStream(__dirname+"/tmp.webp");
        const request = http.get(imgUrl, async function(response) {
            await response.pipe(file); // Save to tmp.webp
            let result = await webp.dwebp(__dirname+"/tmp.webp", __dirname+"/tmp.png", "-o"); // Convert to tmp.webp -> tmp.png
            let img = await readURL(__dirname+'/tmp.png'); // Read tmp.png for jimp
            fs.unlink(__dirname+"/tmp.webp", () => {}); // Remove tmp.webp
            fs.unlink(__dirname+"/tmp.png", () => {}); // Remove tmp.png
            resolve(img); // Resolve image converted to image/png
        });
        } else {
        // Read image type supported by jimp
        Jimp.read(imgUrl).then(async img => {
            resolve(img) // Resolve image
        });
    }
});

Also I know that saving files can be an issue but in the context of the project I'm working on it's not a problem so if someone can find a way to allow it to depend solely on buffers rather than saving images that would be brilliant.
(Here is the npm link for webp-converter)

Can we please support this?

Bump, becoming more and more important with the amount of websites using webp now.

https://www.npmjs.com/package/@saschazar/wasm-webp seems like good pure js converter, I might try that.

Jimp definitely needs to support WebP, since it's becoming very popular lately.

It seems like I have to use webp-converter.

Please add WebP support. This issue was opened in 2016. Eight years have passed, and WebP has become quite mainstream. Thanks!

! I don't think a converter is needed anymore, as every modern browser supports extracting an image from canvas with the image/webp mimetype nowadays.

For most users that's definitely a win, but browsers are not the only runtime; mobile apps, backends, lambdas, etc. I don't know what the jimp policy is about support, but one could add this feature only for browsers is the support is as good as you say.

++ for WebP support!

Another ++ for webp support

Lol, no updates since 2016. This plugin is dead

Still better than canvas, at least you can easily mask with images here

I think there is actually hope here. I was searching npm and there are in fact encoder/decorders that we could use now!
If someone want to contribute a plugin using one of them I'd be open to it

:rocket: Issue was released in v1.2.0 :rocket:


Baseline assess visibility of sites

Hey MB!
Another stair-step of a PR in creating some architecture for siteSR. This is the initial architecture for determining whether or not a site is RS-visible, where the threshold is that the site must be >= 30m from a shoreline to be considered RS-visible This is also some MVP code...
Known issues:

#21 this currently excludes rivers (which would be associated with flowlines, not waterbodies), I need a quick matchup dataset for another project, so really just laying down some basic code
This is intentionally only run for sites that fall within waterbodies within HUCs that we've been able to track down to reduce run time and headaches. When #17 is fixed, we can re-pull.

Please review (by Friday?) for general style guide/functionality/efficiency.
Thank you!

@matthewross07 closing this after chatting with MR a bit. Will tag you in on a different PR shortly.


Bump version to 1.2.4

I have a couple of changes in 1.2.x that I would like to get out before we plan to release 1.3

The mac failure is #9935. The bazel basic build failure is #10553. The portability and linux failures are #10548. The performance failure is #9993.


Add reworked TemporalProblem tutorial based on pancreas dataset

hmm also the driver feature analysis reveals similar results, but not exactly the same ones. I will think about how to address that. We might have to look into the two different versions, and see where the discrepancy comes from.

Yes all values are identical

View entire conversation on ReviewNB

Yes, all are identical

View entire conversation on ReviewNB


Implement wallet custom errors

Description
This PR includes the implementation of the custom errors allowing us to know better what happened when invoking it
Closes #16
Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my code
[x] I have commented on my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my change

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

14 of 14 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
277

Relevant Lines:
277

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

14 of 14 (100.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
277

Relevant Lines:
277

💛  - Coveralls


Error using standalone image inference

hey there,
training worked fine, also making the inference models was no problem. I then build for standalone use, which gives me no errors.
But when I try using standalone inference on images as described in deploy/segmentation, I get the following C++ error:
Predicting image: ../train/tasks/segmentation/dataset/504-896/rgb/rgb-cropped/
terminate called after throwing an instance of 'std::out_of_range'
  what():  basic_string::substr: __pos (which is 140) > this->size() (which is 0)
Aborted (core dumped)

Since I dont yet have any idea of C++ whatsoever, I thought maybe someone has a chance to see the problem directly. In the following I'll add the whole console output for my infer_img execution, aswell as the config of the model. I would appreciate any clue. Thx for looking!
My example is called with tensor rt, but I get the same error with pytorch aswell. I first thought it was about image dimensions, remade the inference models with new dimensions etc., but did not get there yet.
The full console output:
developer@olli:/home/olli/Code/XxxXxxx/bonnetal/deploy$ ./devel/lib/bonnetal_segmentation_standalone/infer_img -p ../train/tasks/segmentation/mystuff/deployed/best_darknet_leaf -i ../train/tasks/segmentation/dataset/504-896/rgb/rgb-cropped/ -b tensorrt
================================================================================
image: ../train/tasks/segmentation/dataset/504-896/rgb/rgb-cropped/
path: ../train/tasks/segmentation/mystuff/deployed/best_darknet_leaf/
backend: tensorrt
verbose: 0
================================================================================
Setting verbosity to: true
Trying to open model
Trying to deserialize previously stored: ../train/tasks/segmentation/mystuff/deployed/best_darknet_leaf//model.trt
Successfully found TensorRT engine file ../train/tasks/segmentation/mystuff/deployed/best_darknet_leaf//model.trt
Successfully created inference runtime
No DLA selected.
Successfully allocated 122542320 for model.
Successfully read 122542320 to modelmem.
INFO: Glob Size is 122257600 bytes.
INFO: Added linear block of size 173408256
INFO: Added linear block of size 173408256
INFO: Added linear block of size 28901376
INFO: Added linear block of size 28901376
INFO: Added linear block of size 14450688
INFO: Added linear block of size 7225344
INFO: Deserialize required 1790698 microseconds.
Created engine!
Successfully deserialized Engine from trt file
Binding: 0, type: 0
[Dim 3][Dim 504][Dim 896]
Binding: 1, type: 3
[Dim 1][Dim 504][Dim 896]
Successfully create binding buffer
================================================================================
Predicting image: ../train/tasks/segmentation/dataset/504-896/rgb/rgb-cropped/
terminate called after throwing an instance of 'std::out_of_range'
  what():  basic_string::substr: __pos (which is 140) > this->size() (which is 0)
Aborted (core dumped)

And the config
backbone:
  OS: 8
  bn_d: 0.01
  dropout: 0.01
  extra:
    darknet: darknet53
  name: darknet
  train: true
dataset:
  color_map:
    0:
    - 0
    - 0
    - 0
    1:
    - 255
    - 0
    - 0
    2:
    - 0
    - 0
    - 255
  img_means:
  - 0.4148446751432425
  - 0.5053385609354691
  - 0.45907718096515426
  img_prop:
    depth: 3
    height: 504
    width: 896
  img_stds:
  - 0.14722864867881855
  - 0.16334236156069035
  - 0.17758600209156641
  labels:
    0: ground
    1: carrot
    2: weed
  labels_w:
    0: 1.0
    1: 1.0
    2: 1.0
  location: dataset/leaf_moreweed/
  name: leaf_moreweed
  workers: 12
decoder:
  bn_d: 0.01
  dropout: 0.01
  extra:
    aspp_channels: 256
    last_channels: 32
    skip_os:
    - 4
    - 2
  name: aspp_residual
  train: true
head:
  dropout: 0.01
  name: segmentation
train:
  avg_N: 3
  batch_size: 2
  crop_prop:
    height: 480
    width: 480
  down_epochs: 100
  final_decay: 0.995
  loss: xentropy
  max_epochs: 100
  max_lr: 0.0001
  max_momentum: 0.95
  min_lr: 1.0e-05
  min_momentum: 0.9
  report_batch: 1
  report_epoch: 1
  save_imgs: false
  save_summary: true
  up_epochs: 0.5
  w_decay: 0.0001

best regards, olli

@ohad-denh
hi,professor:
i want to test bonnet c++ tensorrt, i download one pretrained model like: persons-erfnet-512-88.tar.gz
then ubpack it, i got:

but c++ program need *.trt model , so what can i do it?
oh,please help me!


Path based lifting (Graph to Combinatorial)

We implement the path based lift approach to lift graphs to combinatorial complexes (CC).

Hello @SalvishGoomanee! Thank you for your submission. As we near the end of the challenge, I am collecting participant info for the purpose of selecting and announcing winners. Please email me (or have one member of your team email me) at<EMAIL_ADDRESS>so I can share access to the voting form. In your email, please include:

your first and last name (as well as any other team members)
the title of the method you implemented
the input domain of the method you implemented
the output domain of the method you implemented
your pull request number (#43)

Before July 12, make sure that your submission respects all Submission Requirements laid out on the challenge page. Any submission that fails to meet this criteria will be automatically disqualified.

Hello Guillermo,
Thanks you for your email.
Here are the details as requested:
First name: SALVSIH , Last name: GOOMANEE
Title: Path based lifting (Graph to Combinatorial)
Input domain: Graph
Output domain: Path based Combinatorial Complex (Hypergraph)
PR number: 43
Regards,
Salvish

Le 9 juil. 2024 à 19:50, Guillermo Bernárdez @.***> a écrit :
Hello @SalvishGoomanee https://github.com/SalvishGoomanee! Thank you for your submission. As we near the end of the challenge, I am collecting participant info for the purpose of selecting and announcing winners. Please email me (or have one member of your team email me) at @.*** @.***> so I can share access to the voting form. In your email, please include:
your first and last name (as well as any other team members)
the title of the method you implemented
the input domain of the method you implemented
the output domain of the method you implemented
your pull request number (#43 https://github.com/pyt-team/challenge-icml-2024/pull/43)
Before July 12, make sure that your submission respects all Submission Requirements laid out on the challenge page https://pyt-team.github.io/packs/challenge.html. Any submission that fails to meet this criteria will be automatically disqualified.
—
Reply to this email directly, view it on GitHub https://github.com/pyt-team/challenge-icml-2024/pull/43#issuecomment-2218315758, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTHT6YKV2YGHN4YBSPWFODZLQPF5AVCNFSM6AAAAABKTIPBT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGMYTKNZVHA.
You are receiving this because you were mentioned.


feat(FDS-345): [Cascara] - Replace ErrorBoundary with Boundaries

Replace ErrorBoundary with Boundaries
Resolves FDS-345.
Replaces old ErrorBoundary component with the new Boundaries component.

@brianespinosa I updated the branch 👍


flaps, googols

This pull request was generated by the 'mq' tool
[test]
flake rate: 0.4
logical conflict every: 5
sleep for: 300s
[pullrequest]
requests per hour: 30
deps=[f,g]

/trunk merge


Feature Request:Enabling the RTC and standby battery

Enabling the RTC and standby battery

Done, thanks!


Is this possible to calculate from stored results?

Hello everyone,
I am trying to use MFEM as a solid solver to simulate fluid-structure interactions. However, I encountered a problem.
The results (positions and velocities) have to be stored so that they can be used for last time step. From ex.10 the mesh and velocity will be stored in "deformed.mesh" and "velocity.sol".
The next thing to do is to read the mesh and velocity from the files. It is easy to read the mesh file by using "./ex10 -m deformed.mesh".
To read the velocity I write the codes as follows,
  ifstream ifilev("velocity.sol");
  char linev[100];
   int linenumv=0;
   while(ifilev.good())
    {
        	ifilev.getline(linev,100);
        	//puts(line);
        	istringstream iss(linev);
		if(linenumv>=5) iss>>v[linenumv-5];
       	 	linenumv++;
    }
    //cout<<"linenumv "<<linenumv<<endl;
    ifilev.close();
    cout<<"linenumv "<<v[1]<<endl;
    v.SetTrueVector();

By doing so, I can also read the velocity.
However, I find that the result is incorrect.
If two time steps are calculated by once one time step, the result is
    lucky@NjustQin:/media/lucky/Matters/FSI/qin/mfem-master/examples$ ./ex10 -m deformed.mesh
    linenumv 0
    step 0, t = 1, EE = 8.3969e-11, KE = 3.47423e-08, ΔTE = 3.48262e-08
    lucky@NjustQin:/media/lucky/Matters/FSI/qin/mfem-master/examples$ ./ex10 -m deformed.mesh
    linenumv -7.50197e-07
    step 0, t = 1, EE = 2.59793e-10, KE = 1.38731e-07, ΔTE = 1.04248e-07

If two time steps are calculated only once, the result is
    lucky@NjustQin:/media/lucky/Matters/FSI/qin/mfem-master/examples$ ./ex10 -m deformed.mesh
    linenumv 0
    step 0, t = 1, EE = 8.3969e-11, KE = 3.47423e-08, ΔTE = 3.48262e-08
    step 1, t = 2, EE = 1.02622e-09, KE = 2.33867e-07, ΔTE = 2.34893e-07

Since the results are inconsistent, there must be sth wrong. I wish someone can give me some suggestions on how to solve this.
Thank you for your time.
Best,
Jianhua

Hello, Jianhua,
I haven't tried this myself but I may have a useful suggestion.  There is a GridFunction constructor that seems to be designed to read the files created by the GridFunction::Save() method.
Perhaps you could try the following:
ifstream ifilev("velocity.sol");
GridFunction new_v(mesh, ifilev);
ifilev.close();
Best wishes,
Mark

#Hi Mark,
@mlstowell Thank you for your suggestion! It is much more convenient to read the velocity now.
U

Hello @tzanio and @mlstowell ,
I tried to solve this problem and I find it is caused by using the incorrect ODE solver,
I used int ode_solver_type = 15; in order to save time.
Now int ode_solver_type = 3; is chosen and the inconsistent results is negliable.
Thank you again for your help! Sorry for disturbing you.
Best wishes,
Jianhua

Hello everyone,
I tested the code again and I think the problem still exists.
If an implicit solver is used, then the information (position and velocity) from last time step will have influence on the results. That's why I can't stop the calculation and start again.
However, if an explicit solver (e.g. ForwardEulerSolver) is chosen, I may only use the information in the current time step. Therefore, it should be possible to continue the calculation and get the same results.
By the way, if I can't solve this problem, is there any other ways to add time-dependent external force?
The external force is obtained from my own fluid solver. This means MFEM and the fluid solver exchanges data mutually.
Best,
Jianhua

Hi Jianhua,
In ex10, if you want to restart the computation you will need to save and load the initial, stress free configuration, i.e. the initial mesh. Actually, that is what HyperelasticOperator assumes: the stress free configuration is given by the Mesh while the current deformation is represented by the second component of the solution vector (the first component is the velocity).
Veselin

@v-dobrev
Thank you for the suggestion, everything works perfectly now! I think it's time to close this issue!
Thanks again!
Jianhahua


Simplifying the system

We need to simplify the system for now to go live with V 1.0
so we need to hide the requests icon from the left on the main page

Closed as fixed, please if you notice that the issue still exists open it again.


JS ERROR TypeError: null is not an object (evaluating 'err.description')

I'm playing with the demo and connect to a test node sse server:
const SSE = require("sse-node"),
    app = require("express")();

app.get("/", (req, res) => {
    const client = SSE(req, res);
    client.send("Hello world!");
    client.onClose(() => console.log("Bye client!"));
});
app.listen(8000);

If for any reason the connection is closed (stopping nodejs server) I get this error:
file:///app/tns_modules/nativescript-sse/sse.js:31:31: JS ERROR TypeError: null is not an object (evaluating 'err.description')
The plugin version is 2.0.0

Also, I never get messages.

I will test and let you know because my demo worked last time i tested

https://github.com/triniwiz/nativescript-sse/commit/129db1fe1361d9510a0b2d1eec4ca5ae82786353


Hash key collisions on castling, En passant, and side to move

Consider the following code snippet:
int main() {
    initialise_all_databases();
    zobrist::initialise_zobrist_keys();
    Position p;
    Position::set("r3k2r/p1ppqpb1/bn2pnp1/3PN3/1p2P3/2N2Q1p/PPPBBPPP/R3K2R w KQkq -", p);
    std::cout << p;
    Position p2;
    Position::set("r3k2r/p1ppqpb1/bn2pnp1/3PN3/1p2P3/2N2Q1p/PPPBBPPP/R3K2R b - -", p2);
    std::cout << p2;
    return 0;
  }

The two positions end up having the same hash key. The two positions share placement of pieces on the board, but they do not represent the same game state: the side-to-move is different, so is castling availability. Some key collisions are inevitable, but ideally they would happen between entirely different board positions, rather than the ones that are superficially similar.
I believe the classic solution to this is to have an extra number of Zobrist keys to represent game state parameters such as 'white to move', 'black can castle on queen side', 'en passant available on c-file', and so on.
... Thoughts?

Thanks for spotting this (and sorry for the long delay, I've returned after quite a while). You are absolutely correct regarding the special state zobrist keys, I had put those off until the Position::set function worked completely correctly (it currently doesn't, see https://github.com/nkarve/surge/issues/17). I will try and implement this soon, exactly as you suggest (4 keys for castling, 1 for side to play and 8 for EP file).


Use authentication enabled docker for integration test

Description

For task test-integration-mongodb, the image mongodb_secured is used which has authentication and authorization enable. It already has an user created in docker.
Calling setup.SetupWithOpts(t, &setup.SetupOpts{SetupUser: true}) creates an user with root authorization permission at the beginning of the test, use that authenticated user for the test and drops the user at the end. Since all test share the users in admin.system.users database, the unique username is used for each test.
For task test-integration-postgresql and task test-integration-sqlite the listener is created within setup, and each test creates its own independent postgresql database or sqlite directory, so no other test accesses it.
Calling setup.SetupWithOpts(t, &setup.SetupOpts{SetupUser: true}) creates an user using local exception at the beginning of the test, and entire postgresql database is dropped at the end of the test.

postgresql example postgres://username@<IP_ADDRESS>:5432/testcommandsauthenticationlogoutauthenticateduser
sqlite example file:../tmp/sqlite-tests/testcommandsauthenticationlogoutauthenticateduser/

Closes #4100.
Readiness checklist

[ ] I added/updated unit tests (and they pass).
[x] I added/updated integration/compatibility tests (and they pass).
[ ] I added/updated comments and checked rendering.
[x] I made spot refactorings.
[ ] I updated user documentation.
[ ] I ran task all, and it passed.
[x] I ensured that PR title is good enough for the changelog.
[x] (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
[x] I marked all done items in this checklist.

I will check the security workflow failure


SPDX22SBOM Component type detecting unwanted info

#766 Introduced a change that opens up sbom's and parses their "Packages" section and they end up showing up as SPDX22SBOM components. The actual expected behavior is for SPDX22SBOM Components to just be SBOMs detected in the scan. This is affecting the https://github.com/microsoft/sbom-tool repo. Can we revert this change?
Created #825 for this.
AB#2110019

closed by #825


Undo and redo should not affect Pixly input fields

Undo and redo should not affect Pixly input fields such as the Pixly name.

By itself, it seems like undo and redo do not change the name input field. However, if you draw some pixels, type a name, and then hit undo, the name gets cleared. Similar issues occur with redo.


Use a specific subband when the network's subband is unknown

Is there a way to make a device use a specific subband when the network's (or gateway's) operating subband is unknown before joining? For example in the US915 region, if no subband is specified (US915::new()), then the device will randomly hop across the 64 available channels.
Here is an interesting use case: when first attempting to join, the device tries an OTAA join request on random channels until one is accepted. Is there a way to then restrict the device to then only use the subband on which it successfully joined? Or at least manually change the region/subband of a created Device?
Forgive my ignorance; I'm pretty new to LoRaWAN. Is it common for networks to all operate on the same subband, or are gateways allowed to operate on different subbands?

This kind of behavior is possible and I believe it would remain within spec.
I previously wanted to implement it and would phrase it: "Upon successful join, send the first data frame on the same sub-band as the successful join". Then, I assume you're hoping for your first data frame response (ie: the downlink) to contain the ADR command with the channel mask that provides the appropriate channel restrictions for your network.
However, you should know, that if your LNS implements the newer CFList for US Regions (I think introduced in 1.0.4), you can leverage that instead; that is ultimately why I never implemented the approach above. The CFList is contained in the JoinResponse and contains the ChannelMask
I never got around to absorbing the ChannelMask from the CFList appropriately, but some of the pieces are there. I think the next step would be doing something with it here.
Also, just know that the current "random channel selection logic" doesn't map onto the ChannelMask stuff very well so there'd likely need to be some changes there. The current implementation is very "sub-band" focused when, in fact, there's no notion of sub-bands in the spec and it's just 72 channels and users happen to discuss things in terms of sub-bands. That is to say, the ChannelMask disables arbitrary channels with no notion of sub-band.
And just for the sake of clarity, the wildly out of spec US::set_subband(&mut self, subband: u8) is available when initializing the stack; I admit that I make use of it but it is very inappropriate for anything remotely close to production. The major downfall is that you're basically out of luck if you ever want the device to work on a different sub-band.

Thanks for the super detailer writeup. The JoinResponse CFList approach does seem like it makes sense to me. I might be interested in having a go at implementing it when I find some time, and I'm more familiar with this codebase. Some follow-up questions:

As described in #91, it seems like the current ChannelMask implementation may be wrong; is this something that would prevent such an implementation from working correctly?
If the newer JoinResponse CFList is implemented, does this mean that this stack would need to conform to the whole of LoRaWAN 1.0.4? Or can the LNS be made to operate spec version 1.0.4, and we may choose piecemeal which newer features we want to implement? Currently it seems like the project conforms to 1.0.2 (and I'm just saying this because I got that info from the README).

Hi @jbeaurivage - sorry for the delay in my response.

As described in https://github.com/ivajloip/rust-lorawan/issues/91, it seems like the current ChannelMask implementation may be wrong; is this something that would prevent such an implementation from working correctly?

Yes, I believe so, yes. I'll try to take a look at that issue.

If the newer JoinResponse CFList is implemented, does this mean that this stack would need to conform to the whole of LoRaWAN 1.0.4? Or can the LNS be made to operate spec version 1.0.4, and we may choose piecemeal which newer features we want to implement? Currently it seems like the project conforms to 1.0.2 (and I'm just saying this because I got that info from the README).

The whole device stack is experimental  and is only a partial LoRaWAN implementation as is. In my opinion, it's fine to selectively implement 1.0.4 features and I don't foresee any performance downsides or LNS errors in doing so, but I could be wrong about that.

@jbeaurivage I took a look at things #91 and wrote a response. I created #95 which should make leveraging ChannelMask in the fixed channel plans CFList more straightforward.

@jbeaurivage you might want to check out and/or test #96
Leveraging CfList in JoinAccept is supported and the channel selection logic is spec compliant. From here, "biasing" the stack to start with a specific subband while remaining compliant seems possible.


Operator does not generate opsgenie_config with api_key from VMAlertmanagerConfig

The operator does not generate api_key from secret with kind VMAlertmanagerConfig
VMAlertmanagerConfig:
apiVersion: operator.victoriametrics.com/v1beta1
kind: VMAlertmanagerConfig
metadata:
  name: test
  namespace: infra
  labels:
    alertmanager: yes
spec:
  receivers:
  - name: opsgenie
    opsgenie_configs:
    - api_key:
        key: opsgenieApiKey
        name: alertmanager
      send_resolved: true

Resulted config in alertmanager:
- name: infra-test-opsgenie
  opsgenie_configs:
  - send_resolved: true

resolves in https://github.com/VictoriaMetrics/operator/pull/464


Correct timezone?

Google stores it's data in UTC yet all of my pictures would be PST, is there a way to convert the dates accordingly?

Figured it out, I just subtracted 28800 (3600*8) from the timestamp in read-photo-taken-time-from-google-json.js
line 16 const photoTakenTimestamp = parseInt(googleJsonMetadata.photoTakenTime.timestamp, 10) - 28800


Detect if tiller is running in hosted mode for Helm commands.

Partially addresses https://github.com/kubernetes/helm/issues/2124
What is done?

helm init will create the service before deployment. This will result in error for clusters using hosted tiller and will avoid installing the deployment.
Upgrade will ignore if hosted tiller is used.
Uninstall works as before. So, users will be able to uninstall a hosted tiller and do a helm init to run tiller in incluster mode.
setupConnection will use the externalName if it detects the hosted mode tiller and will not open the tunnel.

I am assuming that cluster operators (like AppsCode) will create the Tiller service in the default Tiller namespace when a cluster is provisioned. helm init only installs tiller in incluster mode.
What's next:

Once this pr is merged, my pr for tiller auth will send kube api server host address in header to Tiller if usesHostedTiller is true.

cc: @technosophos @adamreese

Closing, since to reivew for a long time.

This change is


Logger process does not respond during the installation

This pull request must fix the following bugs:

The logger process kept crashing when attempting to spawn the already installed server
The chosen target path was not updated after the user selected one
The newly installed server weren't able to retrieve a response in time when launched at the end of the process

Closing this has been solved by executing installation in background thread.