Bias correction failure

RavenPy version: master
Python version: 3.10
Operating System: Ubuntu

Description
Running the test suite with an updated xarray yields a failure:
FAILED tests/test_bias_correction.py::TestBiasCorrect::test_bias_correction - ValueError: dqm_adjust failed on block with coords : Coordinates:

What I Did

Xclim version?

0.45

xarray: 2023.10.1

I made a forced upgrade in my env, so this may be  just it.

Downgrading to xarray 2023.1.0 solves the problem.


new antennas or Extensions cables?

I bought a BCM943602CS and an m2 adaptor for the card (saldy I don't have access to taobao), should I buy new antennas and place them under the battery as i saw in this git hub, or should i buy extension cables and plug the card to the already existing antennas used by the intel chip as shown in this guide?
Xiaomi Mi Notebook Pro BROADCOM WiFi Installation Guide v0.3.pdf

Hi, both ways are ok. It is easier to put new antennas under the battery, but if you want better signal quality, extensional cables are recommended.

Hi, both ways are ok. It is easier to put new antennas under the battery, but if you want better signal quality, extensional cables are recommended.
Just a remind, if you use extensional cables and plug them to existing antennas, the origin intel chip may fail to work as well as before.

do you think these antennas would fit? https://www.amazon.it/gp/product/B074TVS9YX/ref=ox_sc_saved_title_3?smid=A77LRTOOHXPP2&psc=1

I can say that I'm using Broadcom Wi-Fi card with extension cables and it
plays quite well, it may be a bit of a problem to find Windows drivers tho,
but @stevezhengshiqi shared them in his repository. All is working fine on
my side, didn't soldered Bluetooth yet tho, I'm afraid I will spoil
everything :D
On Sat, Feb 9, 2019, 3:29 PM artemis77799<EMAIL_ADDRESS>wrote:

Hi, both ways are ok. It is easier to put new antennas under the battery,
but if you want better signal quality, extensional cables are recommended.
Just a remind, if you use extensional cables and plug them to existing
antennas, the origin intel chip may fail to work as well as before.
do you think these antennas would fit?
https://www.amazon.it/gp/product/B074TVS9YX/ref=ox_sc_saved_title_3?smid=A77LRTOOHXPP2&psc=1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/daliansky/XiaoMi-Pro/issues/154#issuecomment-462040421,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ApNk80ILlNsZa6EG8igA2iJLGAlKkqDtks5vLr8ZgaJpZM4ax9Uj
.

I can say that I'm using Broadcom Wi-Fi card with extension cables and it plays quite well, it may be a bit of a problem to find Windows drivers tho, but @stevezhengshiqi shared them in his repository. All is working fine on my side, didn't soldered Bluetooth yet tho, I'm afraid I will spoil everything :D
…

sounds really cool, how many extension cables i need for the BCM943602CS?

Use these: https://www.ebay.com/itm/2pcs-MHF4-Male-to-MHF4-Cable-Antenna-Extension-Female-PCI-Card-0-81-NGFF-/202338735245?hash=item2f1c54148d
Adding internal antenna will give you poor signal results as the signal will be blocked by the housing.

I got two extension cables (actually they came inside the package, but TaoBao seller doesn't seem to provide "Xiaomi Mi Notebook Pro package 3" which I was ordering. In my case third antenna came with small cable itself and was just taped into the area with nearest speaker.

@influenist they seem too short...

BCM943602CS has 3 connectors for antennas, will it work even with only 2 connected? sorry for the dumb question this is a first for me lol

Actually I didn't tried, but connecting third antenna was really easy, so I don't think it's a huge problem. You may try though, but I don't know the answer.

@FallenChromium contact the seller to get a custom size. I ordered 40 cm from him for my Air 12.5.
@artemis77799 correct. 2 you need to expand to your build in antena. BT (if you use it) needs to be custom wired inside the housing.

@FallenChromium contact the seller to get a custom size. I ordered 40 cm from him for my Air 12.5.
@artemis77799 correct. 2 you need to expand to your build in antena. BT (if you use it) needs to be custom wired inside the housing.

do you know which connection is bluetooth and which one is wifi 2,4 and 5ghz? my card has j0, j1, j2 connectors, I need to figure out which are for wifi


Clarification: CheckConfirmedGracePeriodOrders

Presumably, you may also want to pass stoppingToken to CheckConfirmedGracePeriodOrders function so that it can use it to gracefully interrupt any pending calls to query database and publishing messages to queues and rollback things cleanly?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d49a03c0-a844-26eb-48a5-33a612dd3ead
Version Independent ID: 0707865f-9db7-0d71-42a5-bc1a1e89680a
Content: Implement background tasks in microservices with IHostedService and the BackgroundService class
Content Source: docs/architecture/microservices/multi-container-microservice-net-applications/background-tasks-with-ihostedservice.md
Product: dotnet
Technology: dotnet-ebooks
GitHub Login: @nishanil
Microsoft Alias: nanil

//cc @mvelosop

Hi @shoorik, you could do it for sure.
Since handling the cancellation token also adds complexity, you just have to consider up to what point you're going to do it.
This is a simplified sample so it's not that important.
You might want to take a look at a more refined way to handle integration events publishing, by using the OutBox pattern, which is explained in the Subscribing to events section in this guide and can be "seen" in the log traces.
Hope this helps.

Can anyone point me to source code of CheckConfirmedGracePeriodOrders?

Hi @maulik-modi, I'm sorry for the delay, you can find the code here: https://github.com/dotnet-architecture/eShopOnContainers/blob/dev/src/Services/Ordering/Ordering.BackgroundTasks/Tasks/GracePeriodManagerTask.cs

Closing this issue now as the original question was answered, but feel free to comment, will reopen if needed.


Bypassing external link page in footers

Example from MZ: When I visit http://localhost:8000/pt/external-link/... (due to clicking on some external link), external footer links become direct links:

Usually, the footer links Visita o website do UNICEF and Segue o UNICEF no Facebook lead me to the external link redirect page. In this case however, they lead directly to the respective site.

@geoo89 the reason external link conversion doesn't work on the "transition page" is to avoid conversion of "Continue to external site"  to another external link (loop).


Empty files on export. / Save as .zip/.jar fails if procyon can't decompile a class file

When exporting (Save all...) a large project, most of the files produced in the zip file are 0 bytes in size.

Merged #42 as it seems that there is still an issue. This is difficult to test as Procyon becomes better at decompiling and handling it's exceptions.

Same issue right now.

Still an issue on released build for Windows 0.5.4  procyon 0.5.36
Workaround posted by 1volt works thanks.
java -jar procyon-decompiler-0.5.36.jar --jar-file %1 -o ./output


I want to achieve an upgraded function.

I want to achieve an upgraded function.
According to the target key, add and delete obj. without changing value.
It's OK to add obj in this way. But once erase, it's wrong.
if i ues json::diff(), if the target value is different, he will update the value. I don't want him to update the value.

void SysBase::upDateJson(json &source, const json &target)
{
    if (source.type() == target.type())
        switch (source.type())
        {
            case json::value_t::object:
            {
                //第一遍：遍历机器人文件的的元素
                for (auto it = source.begin(); it != source.end(); ++it)
                {
                    if (target.find(it.key()) != target.end())
                    {
                        //递归调用以比较对象的对象值
                        upDateJson(it.value(), target[it.key()]);
                    }
                    else
                    {
                        //找到一个不在o中的键 ->删除它
                        source.erase(it);
                        logger->debug({"删除: ", it.key()});
                    }
                }
                //第二遍：遍历用户数据里的元素
                for (auto it = target.begin(); it != target.cend(); ++it)
                {
                    if (source.find(it.key()) == source.end()) //如果机器人文件没找到和目标文件里同名的元素
                    {
                        //添加他
                        source[it.key()] = it.value();
                        logger->debug({"添加: ", it.key()});
                    }
                }
                break;
            }
            default:
                break;
        }
    return;
}

You are modifying the container during iteration; changing the contianer and expecting that the iterators stay valid is tricky and you have to be very careful doing that. In particular, you should consider using the return value of "it = source.erase(it)" instead of expecting that "++it" is still a valid operation.


Handle partial verses

These are (sometimes) marked up with the \v tag (and sometimes marked up using \vp which means they are invisible to Paratext versification.) It doesn't seem that the current users of Proskomma are concerned about alignment using partial verses, but we should still render them.
I think that Proskomma will currently produce scopes something like verse/2b which may or may not work as expected downstream.
My proposal is to use a specific scope class for partial verses, and to treat them like vp.

Also need to do something with partial verse mappings in vrs files.


Add tests and CI for optional pyarrow module

Which issue does this PR close?
Closes #1635.
Rationale for this change
The build was reported as broken, so we should test it.
In addition, datafusion-contrib/datafusion-python#21 will benefit from the completed implementation of roundtrip conversion.
What changes are included in this PR?

Adds a new CI job to tests pyarrow module.
Completes to_pyarrow implementation for ScalarValue
Adds unit tests to pyarrow conversion logic.

Are there any user-facing changes?
ScalarValue.to_pyarrow will no longer throw a not implemented error. Does that count as an API change?

cc @alamb @kszucs

@wjones127 looks like the newly added CI job is failing.

@wjones127 looks like the newly added CI job is failing.

@houqp Thanks. I got it passing now in my branch: https://github.com/wjones127/arrow-datafusion/runs/5008841849?check_suite_focus=true

Thank you for the contribution @wjones127  ❤

Any thoughts @wjones127 ?

TBH, I get this too on my local. It seems to be using your homebrew Python 3.9 but not the version of Python that you've installed pyarrow in. (On my local, I was trying to use a pyenv-installed Python, but it didn't seem to want to use that.) To get it to pass, I set PYO3_PYTHON to the path of my Homebrew-installed Python (basically gave up on my Pyenv installs).
At the very least, it seems to work in CI without much configuration.
I assumed this is specific to my Mac OS + PyEnv setup, and that PYO3_PYTHON=$(which python) would cover other cases. But on second thought, maybe in all cases where that command would find the right Python, PyO3 will already do the right thing. So perhaps I need to change the instructions? Something like Try setting PYO3_PYTHON=<full-path-to-python>?

I also
PYO3_PRINT_CONFIG=1 PYO3_PYTHON=$(which python) cargo test --features=pyarrow -p datafusion -- pyarrow
error: failed to run custom build command for `pyo3 v0.15.1`

Caused by:
  process didn't exit successfully: `/Users/alamb/Software/arrow-datafusion/target/debug/build/pyo3-0d2dc5a0a08d5a5d/build-script-build` (exit status: 101)
  --- stdout
  cargo:rerun-if-env-changed=PYO3_CROSS
  cargo:rerun-if-env-changed=PYO3_CROSS_LIB_DIR
  cargo:rerun-if-env-changed=PYO3_CROSS_PYTHON_VERSION
  cargo:rerun-if-env-changed=PYO3_PRINT_CONFIG

  -- PYO3_PRINT_CONFIG=1 is set, printing configuration and halting compile --
  implementation=CPython
  version=3.9
  shared=true
  abi3=false
  lib_name=python3.9
<EMAIL_ADDRESS>  executable=/Users/alamb/Software/virtual_envs/arrow_dev/bin/python
  pointer_width=64
  build_flags=WITH_THREAD
  suppress_build_script_link_lines=false

So it seems like maybe pyo3 is picking up the right executable (my virtual env) but not the correct libdir 🤔

So it seems like maybe pyo3 is picking up the right executable (my virtual env) but not the correct libdir 🤔

Have you checked that your virtualenv has the python3.9.lib file? I think some installations just have the Python binary and no libraries.
Otherwise, I do think there is something on MacOS about shared libraries vs the Frameworks folder libraries that I don't yet comprehend, but might be key here.

So it seems like maybe pyo3 is picking up the right executable (my virtual env) but not the correct libdir 🤔

@alamb Actually this seems to be a known issue: https://github.com/PyO3/pyo3/issues/1741#issuecomment-958198336. Python doesn't seem to do the virtual environment path computation for embedded systems on Mac OS. A workaround is to extract that into PYTHON_PATH like so:
export PYTHONPATH=$(python -c "import sys; print(sys.path[-1])")

This is orthogonal to the original issue I had, which is that you must use a framework based Python install. That's default in Homebrew and Python.org installers, but not in pyenv.
I have updated the error help to reflect these two issues.

Sorry -- I missed this one -- I just started CI again. When that passes I'll plan to merge it in. Thanks again @wjones127


Chapter 5: Age/gender prediction notebook not found in colab

The link to the colab of the notebook age_gender_prediction.ipynb and age_gender_torch_snippets.ipynb from chapter 5 does not longer work.

The links are fixed in the respective notebooks now.


General rewrites. Refactoring for more readable module structure.

I'd love if someone could test this if it actually performs as intended. These rewrites should be purely semantic and should not change the behaviour itself.
I'd test it myself, but flask is currently refusing to work for me.

Looks great! Fixed two small issues and merged the rest.
Thanks! :)


[NTR] New Term Request: terminal glia cell + lamellar cells

Preferred term label
terminal glia cell
Synonyms (add reference(s), please)
TGC, end-organ-glia
Definition
A neuroglial cell of the peripheral nervous system located in the terminal part of nerves. Cells of this kind are present in both neuromuscular junctions and sensory corpuscles.
References:
The Lamellar Cells of Vertebrate Meissner and Pacinian Corpuscles: Development, Characterization, and Functions
PMID:35356056
Parent cell type term (check the hierarchy here Cell Ontology CL)
Schwann cell
CL IDs: CL_0002573
Anatomical structure where the cell type is found (check Uberon for anatomical structures: Uberon Ontology)
nerve ending
Uberon IDs: UBERON_0012453
Your ORCID
https://orcid.org/0000-0003-2473-2313
Additional notes or concerns
The draft for this request was autogenerated from Wikidata. For more details, see the Wikidata item or the source script.
Also, the current term for terminal Schwann cell (http://purl.obolibrary.org/obo/CL_0000692) will likely need a more precise main label.

Preferred term label
lamellar cell
Synonyms
sensory corpuscle lamellar cell,  sensory corpuscle TGC, terminal glia cell of sensory corpuscle
Definition
A terminal glia cell that is part of sensory corpuscles. These cells form lamellae around the neuronal terminus and have been reportedly able to transduce mechanical stimuli.
References:
The Lamellar Cells of Vertebrate Meissner and Pacinian Corpuscles: Development, Characterization, and Functions
PMID:35356056
Parent cell type term
terminal glia cell (above)
Anatomical structure where the cell type is found (check Uberon for anatomical structures: Uberon Ontology)
sensory corpuscle:

https://github.com/obophenotype/uberon/issues/3290

Your ORCID
https://orcid.org/0000-0003-2473-2313
Additional notes or concerns
The draft for this request was autogenerated from Wikidata. For more details, see the Wikidata item or the source script.

Preferred term label
Pacinian corpuscle lamellar cell
Synonyms (add reference(s), please)
Definition
A lamellar cell that is part of a Pacinian corpuscle
References:
The Lamellar Cells of Vertebrate Meissner and Pacinian Corpuscles: Development, Characterization, and Functions
PMID:35356056
Parent cell type term (check the hierarchy here Cell Ontology CL)
lamellar cell
Anatomical structure where the cell type is found (check Uberon for anatomical structures: Uberon Ontology)
Pacinian corpuscle
Uberon IDs: UBERON:0003719
Your ORCID
https://orcid.org/0000-0003-2473-2313
Additional notes or concerns
The draft for this request was autogenerated from Wikidata. For more details, see the Wikidata item or the source script.

Preferred term label
Meissner's corpuscle lamellar cell
Synonyms (add reference(s), please)
Definition (free text, with reference(s), please. PubMed ID format is PMID:XXXXXX)
A lamellar cell that is part of a Meissner's corpuscle.
References:
The Lamellar Cells of Vertebrate Meissner and Pacinian Corpuscles: Development, Characterization, and Functions
PMID:35356056
Parent cell type term (check the hierarchy here Cell Ontology CL)
lamellar cell
Anatomical structure where the cell type is found (https://www.ebi.ac.uk/ols4/ontologies/uberon))
Meissner's corpuscle
Uberon IDs: UBERON:0012450
Your ORCID
https://orcid.org/0000-0003-2473-2313
Additional notes or concerns
The draft for this request was autogenerated from Wikidata. For more details, see the Wikidata item or the source script.


go/runtime/host/sandbox: Prevent restart storm after 10m

Defaults bite again.

Is there anywhere else we are doing this, and if so should we have helpers so this doesn't happen again?

Is there anywhere else we are doing this, and if so should we have helpers so this doesn't happen again?

Good idea, added our own helper and made sure we use it everywhere.


Optimize unnecessary extra array allocation and conversion for raw derived column during segment reload

We added support for generating raw derived columns during segment reload recently in https://github.com/apache/pinot/pull/13037.
An optimization was pointed out where we could avoid an unnecessary extra array allocation and conversion from arrays of primitive wrapper classes to primitive arrays.
This patch adds the optimization and also adds derived numeric MV columns to the existing integration test for segment reload so that these additional code paths are covered (they previously had no test coverage).
Note that we can't simply use primitive arrays unconditionally because the dictionary case does cast it into an Object[] which isn't possible for primitive arrays.

Codecov Report
Attention: Patch coverage is 0% with 70 lines in your changes are missing coverage. Please review.

Project coverage is 0.00%. Comparing base (59551e4) to head (3ec3168).
Report is 421 commits behind head on master.

Files
Patch %
Lines

...loader/defaultcolumn/BaseDefaultColumnHandler.java
0.00%
44 Missing :warning:

...impl/stats/DoubleColumnPreIndexStatsCollector.java
0.00%
6 Missing :warning:

.../impl/stats/FloatColumnPreIndexStatsCollector.java
0.00%
6 Missing :warning:

...or/impl/stats/IntColumnPreIndexStatsCollector.java
0.00%
6 Missing :warning:

...r/impl/stats/LongColumnPreIndexStatsCollector.java
0.00%
6 Missing :warning:

.../impl/stats/AbstractColumnStatisticsCollector.java
0.00%
2 Missing :warning:

Additional details and impacted files
@@              Coverage Diff              @@
##             master   #13115       +/-   ##
=============================================
- Coverage     61.75%    0.00%   -61.76%
=============================================
  Files          2436     2439        +3
  Lines        133233   134243     +1010
  Branches      20636    20792      +156
=============================================
- Hits          82274        0    -82274
- Misses        44911   134243    +89332
+ Partials       6048        0     -6048

Flag
Coverage Δ

custom-integration1
?

integration
0.00% <0.00%> (-0.01%)
:arrow_down:

integration1
?

integration2
0.00% <0.00%> (ø)

java-11
?

java-21
0.00% <0.00%> (-61.63%)
:arrow_down:

skip-bytebuffers-false
?

skip-bytebuffers-true
0.00% <0.00%> (-27.73%)
:arrow_down:

temurin
0.00% <0.00%> (-61.76%)
:arrow_down:

unittests
?

unittests1
?

unittests2
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Dataset security usability improvements

Rationale
We fixed a number of issues with dataset security for 21.3; as we're implementing and testing these changes, we might as well address some usability concerns with the "Manage Dataset Security" page:

Issue 42670: When setting dataset group security would be helpful to warn about cohorts, aliases or other dependent datasets
Issue 42667: Some UI/Usability Issues with Dataset Security Page

Related Pull Requests

https://github.com/LabKey/platform/pull/2057

Changes to "Manage Data Security" page

Highlight datasets that might warrant special attention, such as the cohort and alternate ID datasets
Dirty handling - warn when navigating away with unsaved changes
Cancel buttons

Looks good.  I did get to experience the guests/per dataset exception.


How to use the DMD checkpoint?

Dear author:
The DMD model gives impressive results in your paper. I'm confused about how to use the checkpoint of the DMD model. In train_scripts/train_pixart_dmd.py, you load them by:
https://github.com/PixArt-alpha/PixArt-sigma/blob/b20e77ec45f544e860195b47ed6f3ad3ab38a8c6/train_scripts/train_pixart_dmd.py#L205-L207
And in the config file, you seem to choose another model_id:
https://github.com/PixArt-alpha/PixArt-sigma/blob/b20e77ec45f544e860195b47ed6f3ad3ab38a8c6/configs/pixart_app_config/PixArt-DMD_xl2_img512_internalms.py#L16
which is not the same diffusers model you have provided. So I wonder what is the right way to load your DMD model?

Oh, it's a little bug here. Replace
 load_from = "output/pretrained_models/pixart_alpha_512px_284000_diffusers"

with
 load_from = "PixArt-alpha/PixArt-XL-2-512x512"

Thanks for noticing.

Thanks for your quick answer. Another question is how to load the pre-trained DMD model you have released. You did not mention how to download the DMD model in asset/docs. Should I directly change the config.load_from to PixArt-alpha/PixArt-Alpha-DMD-XL-2-512x512 and it will automatically download from huggingface?

`mport torch
from diffusers import ConsistencyDecoderVAE, PixArtAlphaPipeline, Transformer2DModel, DDPMScheduler
import json
weight_dtype = torch.float16
T5_token_max_length = 120
model_path = "{DMD_PATH}"
pipeline_load_from = "{ORIGINAL_ALPHA_PATH}"
pipe = PixArtAlphaPipeline.from_pretrained(
pipeline_load_from,
transformer=None,
torch_dtype=weight_dtype,
)
pipe.transformer = Transformer2DModel.from_pretrained(model_path, subfolder="transformer", torch_dtype=weight_dtype)
pipe.scheduler = DDPMScheduler.from_pretrained(model_path, subfolder="scheduler")
pipe.to("cuda")
speed-up T5
pipe.text_encoder.to_bettertransformer()
image_save_path = ""
prompt = ""
images = pipe(
prompt=prompt,
timesteps=[400],
width=512,
height=512,
guidance_scale=1,
num_inference_steps=1,
num_images_per_prompt=4,
use_resolution_binning=True,
output_type="pil",
max_sequence_length=T5_token_max_length,
).images[0]
images.save(img_save_path)`
It works.

`mport torch
from diffusers import ConsistencyDecoderVAE, PixArtAlphaPipeline, Transformer2DModel, DDPMScheduler
import json
weight_dtype = torch.float16
T5_token_max_length = 120
model_path = "{DMD_PATH}"
pipeline_load_from = "{ORIGINAL_ALPHA_PATH}"
pipe = PixArtAlphaPipeline.from_pretrained(
pipeline_load_from,
transformer=None,
torch_dtype=weight_dtype,
)
pipe.transformer = Transformer2DModel.from_pretrained(model_path, subfolder="transformer", torch_dtype=weight_dtype)
pipe.scheduler = DDPMScheduler.from_pretrained(model_path, subfolder="scheduler")
pipe.to("cuda")
pipe.text_encoder.to_bettertransformer()
image_save_path = ""
prompt = ""
images = pipe(
prompt=prompt,
timesteps=[400],
width=512,
height=512,
guidance_scale=1,
num_inference_steps=1,
num_images_per_prompt=4,
use_resolution_binning=True,
output_type="pil",
max_sequence_length=T5_token_max_length,
).images[0]
images.save(img_save_path)`
It works.

`  mport torch
from diffusers import ConsistencyDecoderVAE, PixArtAlphaPipeline, Transformer2DModel, DDPMScheduler
import json
weight_dtype = torch.float16
T5_token_max_length = 120
model_path = "{DMD_PATH}"
pipeline_load_from = "{ORIGINAL_ALPHA_PATH}"
pipe = PixArtAlphaPipeline.from_pretrained(
pipeline_load_from,
transformer=None,
torch_dtype=weight_dtype,
)
pipe.transformer = Transformer2DModel.from_pretrained(model_path, subfolder="transformer", torch_dtype=weight_dtype)
pipe.scheduler = DDPMScheduler.from_pretrained(model_path, subfolder="scheduler")
pipe.to("cuda")
speed-up T5
pipe.text_encoder.to_bettertransformer()
image_save_path = ""
prompt = ""
images = pipe(
prompt=prompt,
timesteps=[400],
width=512,
height=512,
guidance_scale=1,
num_inference_steps=1,
num_images_per_prompt=4,
use_resolution_binning=True,
output_type="pil",
max_sequence_length=T5_token_max_length,
).images[0]
images.save(img_save_path)  `
It works.

Thanks for your quick answer. Another question is how to load the pre-trained DMD model you have released. You did not mention how to download the DMD model in asset/docs. Should I directly change the config.load_from to PixArt-alpha/PixArt-Alpha-DMD-XL-2-512x512 and it will automatically download from huggingface?

For training from base model you should use the PixArt-alpha/PixArt-XL-2-512x512 I mentioned above.
For finetuning, you can directly use the PixArt-alpha/PixArt-Alpha-DMD-XL-2-512x512.
Both of them will be automatically downloaded.


Image pre-trained model for transfer learning

Hi,
I have a relatively small image dataset and would like to utilize transfer learning to get better results. I could not find much details related to transfer learning online, and the only mention of it is in the update post here related to BERT: https://eng.uber.com/ludwig-v0-2/.
I am still unsure about how to perform image transfer learning as is possible with using pretrained models on imageNet etc.
Is it possible? if so how would the model definition look for this? as the model starting weights would be different to my reduced classes at output?
Thanks

At the moment there areno pretrained image models importable in Ludwig, from version 0.3 on we will start to add them. I'll consider this a feature reqeust.
Also let me know if you would be interested in collaborating in adding this feature, it would be pretty easy.

Id be happy to work on this.
Ive never contributed to any repo before but let me know what I need to do and I'll do my best :)

Id be happy to work on this.
how can I help?

Great! Thank you for being willing to help.
We are now orking a lot on porting to TF2, so any contribution should start from the tf2_porting branch.
Ludwig has this concept of encoders for input features that makes it easy to add  new pretrained image encoders.
If you look at the features/image_feature.py you'll find a disctionary of encoder associated with the input feature.
Ideally you may want to add a pretrained model there, giving it a name and implementing the class. Classes for image encoders are in model/modules/image_encoders.py.
Basically one need to implement an object with an __init__ function that contains the parameters (maybe in this case the path to the pretrained model) and a call function that takes as inputs tensors of chape [batch, h, w, c] and return either [batch, h', w', c']or just a[batch, hidden]` tensord, depending where you cut the original preprocessed model, if before or after flattening.
Let me know if these instructions are clear for you or if you have additional questions.

Hey there!
Is anybody still working on this? I would love to help.

@rajatsahay thank you for being willing to help! The instructions in my previous message, combined with the instructions in the developer guide should be a good starting point. Let me know if after reading them you still have doubts :)


Arguments with type generics are not properly verified using any()

Describe the bug
I have the following code:
class Service {
  Future<void> method<T>(Argument<T> argument) async {
    return;
  }
}

class Argument<T> extends Equatable {
  Argument(this.value);

  final T value;

  @override
  List<Object?> get props => [value];
}

class MockService extends Mock implements Service {}

and then the following test:
test('should verify the call to method', () async {
  registerFallbackValue(Argument(''));
  final service = MockService();
  when(() => service.method(Argument('value'))).thenAnswer((_) async {});

  await service.method(Argument('value'));
  verify(() => service.method(any())).called(1);
});

This test throws an error
No matching calls. All calls: MockService.method<String>(Argument<String>(value))
(If you called `verify(...).called(0);`, please instead use `verifyNever(...);`.)

If I change the test to instead verify like that:
  verify(() => service.method(Argument('value'))).called(1);

It starts matching the call correctly.
I would imagine matcher any() should match the same way as Argument('value').
Also, the issue goes away if I remove the type generic parameter from the service's method declaration.
If I try to change the mocking to
when(() => service.method(any())).thenAnswer((_) async {});

Then I get this error
type 'Null' is not a subtype of type 'Future<void>'

To Reproduce
Run the tests with the provided code.
Expected behavior
verify(() => service.method(any())).called(1); should correctly match the call to the mocked service method.
Additional context
Running on flutter stable 3.3.6, with the latest mocktail version 0.3.0

Thanks for opening an issue @lukaszdebowski .
I believe this is happening when the type of any can't be inferred.

 Sample issue
import 'package:mocktail/mocktail.dart';
import 'package:test/test.dart';

class _MockFoo extends Mock implements _Foo {}

class _Foo {
  T doSomething<T>(T value) => value;
}

void main() {
  setUp(() {
    registerFallbackValue(1);
  });

  test('should verify the call to method', () async {
    final foo = _MockFoo();
    // The type of any can't be inferred.
    when(() => foo.doSomething(any())).thenAnswer((_) => 1);
    foo.doSomething(1);
    verify(() => foo.doSomething(any())).called(1);
  });
}

You need to specify the generic type, either to the any<T>() or to the method being stubbed doSomething<T> so it can be inferred.

 With any generic
import 'package:mocktail/mocktail.dart';
import 'package:test/test.dart';

class _MockFoo extends Mock implements _Foo {}

class _Foo {
  T doSomething<T>(T value) => value;
}

void main() {
  setUp(() {
    registerFallbackValue(1);
  });

  test('should verify the call to method', () async {
    final foo = _MockFoo();
    // Generic is now inferred.
    when(() => foo.doSomething(any<int>())).thenAnswer((_) => 1);
    foo.doSomething(1);
    verify(() => foo.doSomething(any<int>())).called(1);
  });
}

What can we do if the type T is not used in the arguments?
Example:
import 'package:flutter_test/flutter_test.dart';
import 'package:mocktail/mocktail.dart';

class _MockFoo extends Mock implements _Foo {}

class _Foo {
  void doSomething<T>() {
    // Des something
  }
}

void main() {
  setUp(() {
    registerFallbackValue(1);
  });

  test('should verify the call to method', () async {
    final foo = _MockFoo();
    var count = 0;
    when(() => foo.doSomething<dynamic>()).thenAnswer((_) {
      print("Mock is doing something");
      count++;
    });
    foo.doSomething<String>();
    foo.doSomething<int>();
    expect(count, 2); // reality: 0
  });
}

The only option is to call when(()... for every possible type. It would be great if I would have to call it only once. In my case, it is for hive boxes (openBox).
Do i miss something?

You'll need to create stub for each generic type that you care about for a given test. Hope that helps!


Add a convenience member function to call value_to

Hi, first of all thanks for the great library fast yet easy to use.
I'm currently writing tag_invoke functions to convert JSON values from/to a class, and I have something like this:
MyClass{json.at("superint1").to_number<int>(),
        json.at("superint2").to_number<int>(),
        json.at("superbool").as_bool(),
        json.at("superstring").as_string(),
        boost::json::value_to<std::vector<int>>(json.at("supervectorofint"))}

It's a class with private values and a constructor, so I cant just rely on Boost Describe for this.
If there was a to<T>() member function (just calling boost::json::value_to under the hood), I could have arguably more consistent code:
MyClass{json.at("superint1").to_number<int>(),
        json.at("superint2").to_number<int>(),
        json.at("superbool").as_bool(),
        json.at("superstring").as_string(),
        json.at("supervectorofint").to<std::vector<int>>()}

And it could also allow something ever better (to my eyes that is!):
MyClass{json.at("superint1").to<int>(),
        json.at("superint2").to<int>(),
        json.at("superbool").to<bool>(),
        json.at("superstring").to<std::string>(),
        json.at("supervectorofint").to<std::vector<int>>()}

I like the fact that there is a fixed set of as_* functions, guaranteeing direct access to the underlying value; but value_to seems to be the "do whatever you need but get me this" convenience method I usually want.
Related to #418.

You can still use Describe if you declare an intermediate struct holding the parameters.

On second thought, isn't
MyClass{json.at("superint1").to<int>(),
        json.at("superint2").to<int>(),
        json.at("superbool").to<bool>(),
        json.at("superstring").to<std::string>(),
        json.at("supervectorofint").to<std::vector<int>>()}

possible to write today as
MyClass{
        value_to<int>(json.at("superint1")),
        value_to<int>(json.at("superint2")),
        value_to<bool>(json.at("superbool")),
        value_to<std::string>(json.at("superstring")),
        value_to<std::vector<int>>(json.at("supervectorofint"))
}

?

It is. I think, @kiwixz considers that syntax too cumbersome.
To be honest, I'm not fond of adding just another way to call value_to.

I didn't think of using namespace here which helps a lot.
It still feels weird to me to use it as a free function, especially when we have to_number as a member.

True, butmaking an equivalent of value_to  member function of value is much more intrusive.


Very small max_transition

The RAMs have a very small max_transition of 0.04, e.g. https://github.com/efabless/sky130_sram_macros/blob/c2333394e0b0b9d9d71185678a8d8087715d5e3b/sky130_sram_1kbyte_1rw1r_32x256_8/sky130_sram_1kbyte_1rw1r_32x256_8_TT_1p8V_25C.lib#L188
Most of the stdcells have a value of 1.5 in hd and 1.0 in hs for comparison.  Is this value correct?

@mguthaus Please comment.

The tech file has a .04ns slew rate as seen here:
https://github.com/VLSIDA/OpenRAM/blob/f66aac3264598eeae31225c62b6a4af52412d407/technology/sky130/tech/tech.py#L704
It seems that this was just an arbitrary value.
The default slew corners are .25, 1, and 8x this value and max slew is the
last.
The values in the .lib files are from analytical characterization and are
pretty arbitrary... They are not based on simulation.
On Thu, Dec 30, 2021, 20:32 Matt Liberty @.***> wrote:

@mguthaus https://github.com/mguthaus Please comment.
—
Reply to this email directly, view it on GitHub
https://github.com/efabless/sky130_sram_macros/issues/9#issuecomment-1003265547,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC67SL375X2VMEJMV67YTNDUTUW5NANCNFSM5LAYBD3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

Correction: .005ns
On Thu, Dec 30, 2021, 20:47 Matt Guthaus @.***> wrote:

The tech file has a .04ns slew rate as seen here:
https://github.com/VLSIDA/OpenRAM/blob/f66aac3264598eeae31225c62b6a4af52412d407/technology/sky130/tech/tech.py#L704
It seems that this was just an arbitrary value.
The default slew corners are .25, 1, and 8x this value and max slew is the
last.
The values in the .lib files are from analytical characterization and are
pretty arbitrary... They are not based on simulation.
On Thu, Dec 30, 2021, 20:32 Matt Liberty @.***> wrote:

@mguthaus https://github.com/mguthaus Please comment.
—
Reply to this email directly, view it on GitHub
<
https://github.com/efabless/sky130_sram_macros/issues/9#issuecomment-1003265547
,
or unsubscribe
<
https://github.com/notifications/unsubscribe-auth/AC67SL375X2VMEJMV67YTNDUTUW5NANCNFSM5LAYBD3Q
.
Triage notifications on the go with GitHub Mobile for iOS
<
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
<
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub
.
You are receiving this because you were mentioned.Message ID:
@.***>

—
Reply to this email directly, view it on GitHub
https://github.com/efabless/sky130_sram_macros/issues/9#issuecomment-1003267878,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC67SL6UIO47PTLQUUCSR63UTUYVTANCNFSM5LAYBD3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

@RTimothyEdwards @mkkassem what do you see as typical slew values for sky130?  5ps seems very small to me.  It feels like we should pick better values and recharacterize.

@RTimothyEdwards @mkkassem what do you see as typical slew values for sky130?  5ps seems very small to me.  It feels like we should pick better values and recharacterize.

I'd like to stress that these models are not characterized data. It is an
Elmore delay model estimate which is independent of slew.
Matt
On Fri, Dec 31, 2021, 21:02 Matt Liberty @.***> wrote:

@RTimothyEdwards https://github.com/RTimothyEdwards @mkkassem
https://github.com/mkkassem what do you see as typical slew values for
sky130? 5ps seems very small to me. It feels like we should pick better
values and recharacterize.
—
Reply to this email directly, view it on GitHub
https://github.com/efabless/sky130_sram_macros/issues/9#issuecomment-1003506086,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC67SL3STEPS2K74JQW5RDTUT2DGRANCNFSM5LAYBD3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

I'd like to stress that these models are not characterized data. It is an
Elmore delay model estimate which is independent of slew.
Matt
On Fri, Dec 31, 2021, 21:02 Matt Liberty @.***> wrote:

@RTimothyEdwards https://github.com/RTimothyEdwards @mkkassem
https://github.com/mkkassem what do you see as typical slew values for
sky130? 5ps seems very small to me. It feels like we should pick better
values and recharacterize.
—
Reply to this email directly, view it on GitHub
https://github.com/efabless/sky130_sram_macros/issues/9#issuecomment-1003506086,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AC67SL3STEPS2K74JQW5RDTUT2DGRANCNFSM5LAYBD3Q
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you were mentioned.Message ID:
@.***>

I think the underlying issue is some confusion about the semantics of liberty max_transition.
The ram libraries appear to be using it to prevent extrapolation in the table model.
Note that the table model that has constant values.
This means preventing extrapolation is pointless because extrapolation will return the same value as the constant in the table model.
The "fakeram" generator used by openroad flow scripts suffered from the same problem.
I changed the models to use scalar instead of a table because it more accurately reflects the non-slew dependency of the timing model. Using an artificially small technology independent max_transition directs physical optimization
to try to reduce the slew to a value that is impossible to achieve in a slower technology.

I think the underlying issue is some confusion about the semantics of liberty max_transition.
The ram libraries appear to be using it to prevent extrapolation in the table model.
Note that the table model that has constant values.
This means preventing extrapolation is pointless because extrapolation will return the same value as the constant in the table model.
The "fakeram" generator used by openroad flow scripts suffered from the same problem.
I changed the models to use scalar instead of a table because it more accurately reflects the non-slew dependency of the timing model. Using an artificially small technology independent max_transition directs physical optimization
to try to reduce the slew to a value that is impossible to achieve in a slower technology.


Unable to retrieve stats is this container running?

Description

Steps to reproduce the issue:

I removed portainer and added it back again.  Using:
docker run -d -p 9000:9000 -v /var/run/docker.sock:/var/run/docker.sock portainer/portainer
The dashboard does not load any info just spinning cog wheel forever.

Any other info e.g. Why do you consider this to be a bug? What did you expect to happen instead?
Technical details:

Portainer version: 1.10.2
Target Docker version (the host/cluster you manage): Docker 1.6.2
Target Swarm version (if applicable):
Platform (windows/linux): Debian Jessie
Browser: Firefox 50.0.2

Issue has been resolved by remove jessie backport repo removing all traces of docker and installing docker from getdocker sh script.


add patch

https://github.com/mfellner/koa-router-rx/issues/5

Coverage decreased (-1.5%) to 85.965% when pulling d54af2b776db31e4d699405c3e141179566cdf39 on beckend:add-patch into fb7cafc6e66569b054d4c1eb755bee65d957e317 on mfellner:master.

Coverage increased (+2.0%) to 89.474% when pulling b163db0ec3bd74503b5cafed6ad7bd5de62fb7a2 on beckend:add-patch into fb7cafc6e66569b054d4c1eb755bee65d957e317 on mfellner:master.

@mfellner done.

Coverage decreased (-1.5%) to 85.965% when pulling b79cacaba91538e98498cabab345dc714d1c691c on beckend:add-patch into fb7cafc6e66569b054d4c1eb755bee65d957e317 on mfellner:master.


[Request] update the wiki pls

the wiki is very outdated and lacks a lot of documentation...
a way to fix this is by letting volunteers edit and add on to the wiki
fyi last info of the wiki is for AR 1.4, now its AR 1.6

see zmaster587/AdvancedRocketryDoc

but how do i know if any new features about this is added?

Anything on there would be in the latest alpha in the game. Z updates that as its added to the game.
Sent from my iPhone

On Sep 22, 2019, at 8:34 PM, Archilyte<EMAIL_ADDRESS>wrote:

but how do i know if any new features about this is added?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.

As well, that's just the changelog. Not necessarily the content-added log

Wiki just got an enormous update.


Added RPS command

Closes #613
Description
Added Rock paper scissors command which allows players to play it with bot.
Format
.rps <option_name>
where option_name can be any of r, p, s, rock, scissor, paper in any case.
Did you:

[x] Join the Python Discord Community?
[x] Read all the comments in this template?
[x] Ensure there is an issue open, or link relevant discord discussions?
[x] Read the contributing guidelines?

@Shivansh-007 Thanks a lot for reviewing I have made changes you requested and resolved all the flake8 errors the PR faced.
Just a small review of changes done:

Merged Game class and cog class
Added Doc strings in all the methods
Capitalised static variables
Added missing types
Removed dead code
Changed @commands.groups to @commands.command
Changed variable name to appropriate meaningful name(i.e. arg => move)
Checked linting on local machine and tested bot in my server

Thanks, please let me know if more changes are required.

It might be better to add some logical spacing here to facilitate reading :D

@Objectivitix yeah that will give better readability indeed!
Great! I'll update it soon!

@Objectivitix made required changes.!

We should be using await ctx.send() instead of await channel.send().

Yeah I think we can do that as this is kinda 1 time command. Great, I'll change it asap and recheck.

Thanks for the PR!


Do not consider empty string as a change

What does this PR do?
Fixes the agent changelog command
Motivation
If there's not change bewteen two agent releases, everything was considered as a change
Review checklist

[ ] PR has a meaningful title or PR has the no-changelog label attached
[ ] Feature or bugfix has tests
[ ] Git history is clean
[ ] If PR impacts documentation, docs team has been notified or an issue has been opened on the documentation repo
[ ] If PR adds a configuration option, it has been added to the configuration file.

Codecov Report

Merging #2771 into master will decrease coverage by 11.08%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master    #2771       +/-   ##
===========================================
- Coverage   84.73%   73.64%   -11.09%
===========================================
  Files         657       21      -636
  Lines       37482      664    -36818
  Branches     4506       77     -4429
===========================================
- Hits        31759      489    -31270
+ Misses       4404      148     -4256
+ Partials     1319       27     -1292


cascaded multicheckbox using formlyBootstrap and data from backend

Hello everybody,
I'm using angular formly with spring data rest to get data from backend.
I have a little bit of trouble to find out how can i populate data from backend in a multicheckbox after checking another one.
In my first multichebox named modules i'm getting my data so everything is good but with my second multicheckbox who is using data ID from the first one, nothing populate after i click on my first checkbox  from the first multicheckbox and i think the second requete doesn't run thats why.
A help will be great. thank you in advance guys.
 fields: FormlyFieldConfig[] = [
    {
      key: 'modules',
      type: 'multicheckbox',
      templateOptions: {
        label: 'Modules',
        options:  this.typeRequete.getData('modules?projection=ModulesForBaliseSelect&sort=moduleName, ASC').pipe(map(data => {
  return data['content'];
}
)),  valueProp: 'id',
        labelProp: 'moduleName',
      },
    },
    {
      key: 'roles',
      type: 'multicheckbox',
      templateOptions: {
        label: 'Roles',
        options: [],
      },
      expressionProperties: {
        'templateOptions.options': this.typeRequete.getData('modules/model.modules/roles?projection=RolesFromModuleIdForBalise').pipe(map(data => {
        return data['content'];
        })),
       },
    },

  ];

How can also get the id from the checked checkbox from my first multicheckbox?  is it correct that i'm using model.modules to get it ?
I don't know what i am missing here.

check the demo example https://ngx-formly.github.io/ngx-formly/examples/other/cascaded-select which show exactly your scenario by updating options whenever the first one changes

i already tried it but i think there is a problem with the version i'm using<EMAIL_ADDRESS>) because in my example  i followed the same example but i always get the error

just added the demo for V4 version which you may check https://ngx-formly.github.io/ngx-formly/v4/examples/other/cascaded-select

i tried to follow the example and change it so i can get what i'm looking for. but my main issue is that i don't know how to get the value of the checked one.
 fields: FormlyFieldConfig[] = [
    {
      key: 'sport',
      type: 'multicheckbox',
      templateOptions: {
        label: 'Sport',
        options: [
          { id: '1', name: 'Soccer' },
          { id: '2', name: 'Basketball' },
        ],
        valueProp: 'id',
        labelProp: 'name',
      },
    },
    {
      key: 'team',
      type: 'multicheckbox',
      templateOptions: {
        label: 'Team',
        options: [],
        valueProp: 'id',
        labelProp: 'roleName',
      },
      hooks: {
        onInit: (field) => {
          const form = field.parent.formControl;
          form.get('sport').valueChanges.pipe(
            takeUntil(this.onDestroy$),
            startWith(form.get('sport').value),
            tap(sportId => {
              if(sportId) {
                console.log(sportId);
                field.templateOptions.options =  this.typeRequete.getData('modules/' + sportId+ '/roles?projection=RolesFromModuleIdForBalise').pipe(map(data => {
                  return data['content'];
                }))
              }
            }),
          ).subscribe();
        },
      },
    },
    ];

when i checked on my multicheckbox i get the value like this {1:true}  which is an object. i tried to get only the value 1 by using sportId.key, sportId.id, sportId.value and sportId[0] but it's not working.
how can i get the sportId to only get me the value of the checked one not an object of the values (1 in my example).
Also  if i checked on the first one and checked on the second one after i get the object like this {1: false, 2: true }.
Is there a way to only get the value 1 or 2 as a response ?
Thank you for your help

Pass type array throughout templateOptions, and you'll get an array of the selected items instead.
templateOptions: {
  type: 'array',
  ...
},

didn't know about this parameter, thank you sir for your help.


the logs of python module has error information.

repro on :  amd64 /amd64.debug
Windows10:
step:

set python version in VSCode settings
"azure-iot-edge.version.pythonmodule": "arm64-preview"
create python module
build and run python module in simulator
check the logs of python module
it has error in python module,

C:\Users\iotedge>docker logs SampleModulePython
IoT Hub Client for Python
transport.connect raised error
Traceback (most recent call last):
File "/usr/local/lib/python3.7/site-packages/azure/iot/device/common/mqtt_transport.py", line 252, in connect
rc = self._mqtt_client.connect(host=self._hostname, port=8883)
File "/usr/local/lib/python3.7/site-packages/paho/mqtt/client.py", line 839, in connect
return self.reconnect()
File "/usr/local/lib/python3.7/site-packages/paho/mqtt/client.py", line 962, in reconnect
sock = socket.create_connection((self._host, self._port), source_address=(self._bind_address, 0))
File "/usr/local/lib/python3.7/socket.py", line 727, in create_connection
raise err
File "/usr/local/lib/python3.7/socket.py", line 716, in create_connection
sock.connect(sa)
ConnectionRefusedError: [Errno 111] Connection refused

The above exception was the direct cause of the following exception:

Known issue for Python SDK. This is because EdgeHub is not ready for connect when custom module starts and SDK will throw error in this case. Edge runtime will restart the custom module to retry.


Delete orphan Data, Ord instances for MetadataMap.

Which are both upstream.

thank you!

You're welcome!

@riz0id Are these failures catching this bug? https://github.com/awakesecurity/grpc-mqtt/blob/4dbf3df65be462e31a125a4993fda51ce911b728/test/Test/Service.hs#L165

@riz0id Are these failures catching this bug?
https://github.com/awakesecurity/grpc-mqtt/blob/4dbf3df65be462e31a125a4993fda51ce911b728/test/Test/Service.hs#L165
And are they legit failures or existing failures?

Rerunning CI produced a different error, let me see if tasty is running test groups concurrently since -N4 is set in the RTS options. Multiple tests running with different remote clients on the same broker could cause the both issues here.

The client timeout exception is a symptom of using replicateConcurrently inside withMQTTGRPCClient. I don't believe withMQTTGRPCClient was intended to be used this way. If clients should support managing multiple threads each publishing to a remote client, then clearly some work needs to be done to enable that and more tests need to be added to figure out why that doesn't work currently.
After removing replicateConcurrently in the "LongBytes" test, the "Test.Service.ClientStream.Unbatched" test inconsistently throws the following error which is raised here:
ClientErrorNoParse (EmbeddedError "decoding field #2 \"options\" of record \"Request\" raised" (Just (EmbeddedError "decoding Network.GRPC.MQTT.Option.ProtoOptions raised" (Just (WireTypeError "expected 3 varints, got 0")))))

I can't reproduce this failure locally. @rkaippully mentioned that there was some strange Test.Service test failures in CI that he encountered. I'll be doing more testing tomorrow in order to reproduce this CI failure locally.

I had to adjust a few timeout values to get it working: https://github.com/awakesecurity/grpc-mqtt/pull/44/files#diff-e6b6d13ab02f568493ea0bb896278386f83ebb64b8844149aea75eb490e68144. Tests passed after that.

The client timeout exception is a symptom of using replicateConcurrently inside withMQTTGRPCClient. I don't believe withMQTTGRPCClient was intended to be used this way.

@riz0id This is correct. A given MQTTGRPCClient is not thread-safe. Maybe we should add a comment somewhere to make that clear.

I see @Friede80. Should the parallelism in the test be removed, then?

I see @Friede80. Should the parallelism in the test be removed, then?

I've remove the concurrent senders in the tests for this PR already. I will create a separate PR branching off fixing the proto serialization issue shortly.

@jsoo1 Okay, the issue was in slight differences between in how ProtoOptions are serialized vs. how they are parsed (packedVarints vs packedVarintsV). I opened PR #49 which fixes this. I can't seem to merge that PR into this one for whatever reason, do you want to merge into that PR and I can merge it to main after it gets approval?

@riz0id I think this one can be closed in favor of #49

Okay. Thanks again and sorry this got in the way of your changes.

No worries! Thank you for the quick response!


[cudamapper] Fixes issue #133

When adding anchors to anchors vector iterator was not being updated
and old anchors were being overwritten. This commit fixes that issue.

Changes max buffer size definition from GB to MiB, for better
granularity.

Can you add a utittest which covers this bug? (looks like something which could be covered with a unittest with a few anchors)
Does this also affect overlapper_naive?

Will do. It does not affect overlapper_naive because overlapper_naive does not use the order of anchors.


running reports with neurostore reference dataset takes a lot of memory

Summary

Additional details

NiMARE version:

What were you trying to do?
What did you expect to happen?
What actually happened?
Reproducing the bug

Did you see this high memory issue with CBMA of IBMA?

CBMA

@jdkent The peak memory usage comes from the last interactive plot:
https://github.com/neurostuff/NiMARE/blob/67cda9792e44e4d890f8895bf6036a371bc58e38/nimare/reports/base.py#L291
Should we set that to optional? We can define a parameter advanced=False that controls whether to show those in the report.

could this line be changed to a lower resolution?
https://github.com/neurostuff/NiMARE/blob/67cda9792e44e4d890f8895bf6036a371bc58e38/nimare/reports/figures.py#L273
this is the figure for someone to navigate the statistical results, correct?
not the interactive surface viewer for the coordinates.

let's see what happens if we change the resolution to 2mm, potentially halves the memory consumption.


In emulator only sound cuts out after two sound 1,31,322 commands.

The floats tracking the position in the sound in gfx.cpp were converted to integer before being scaled by the sound channel frequency. Fixed Linux/Windows


mermaid - Browser Support issue

Hai all,
          I am in need of using this JS but this is not working in IE9, can anyone help me on this. It is very urgent.

Thanks in advance

We are sorry but we have no plan to support IE 9


feat: drag and drop extension for tiptap editor

Loom
https://www.loom.com/share/d03606a9a2454e4e9a0dba0c60880615?sid=2c2ba4a5-6daf-401c-b37c-9bf107f44340
Found this cool https://github.com/pierre-lgb/slashwriter, which implements tiptap's experimental global drag handler
added it as an extension to Novel

Incredible work  👏
Merging this now but will cut a new release along with #131


Removing the backticks to fix the problem of #3987

Removing the backticks of title and meta so it will not be rendered as <code> in the sidebar nav, as opened on the issue https://github.com/sveltejs/kit/issues/3987
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

[X] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
[X] This message body should clearly illustrate what problems it solves.
[ ] Ideally, include a test that fails without this PR but passes with it.

Tests

[ ] Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

[ ] If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

thanks, this was fixed separately in #4011


Error: Cannot find module 'commander'

When I try to run htmlhint, I get following error message:
$ node .npm/htmlhint/0.9.8/package/bin/htmlhint

module.js:340
    throw err;
          ^
Error: Cannot find module 'commander'
    at Function.Module._resolveFilename (module.js:338:15)
    at Function.Module._load (module.js:280:25)
    at Module.require (module.js:364:17)
    at require (module.js:380:17)
    at Object.<anonymous> (/home/AD/tf128/.npm/htmlhint/0.9.8/package/bin/htmlhint:3:15)
    at Module._compile (module.js:456:26)
    at Object.Module._extensions..js (module.js:474:10)
    at Module.load (module.js:356:32)
    at Function.Module._load (module.js:312:12)
    at Function.Module.runMain (module.js:497:10)

$ aptitude show nodejs
Package: nodejs
State: installed
Automatically installed: yes
Version: 0.10.25~dfsg2-2ubuntu1
Priority: extra
Section: universe/web
Maintainer: Ubuntu Developers<EMAIL_ADDRESS>Architecture: amd64
Uncompressed Size: 3,116 k
Depends: libc-ares2 (>= 1.8.0), libc6 (>= 2.14), libssl1.0.0 (>= 1.0.1), libstdc++6 (>= 4.1.1), libv8-3.14.5, zlib1g (>= 1:1.1.4)
Conflicts: nodejs
Description: evented I/O for V8 javascript
 Node.js is a platform built on Chrome's JavaScript runtime for easily building fast, scalable network applications. Node.js uses an event-driven, non-blocking I/O model that makes it lightweight and efficient, perfect for data-intensive real-time applications that run
 across distributed devices.

 Node.js is bundled with several useful libraries to handle server tasks:

 System, Events, Standard I/O, Modules, Timers, Child Processes, POSIX, HTTP, Multipart Parsing, TCP, DNS, Assert, Path, URL, Query Strings.
Homepage: http://nodejs.org/
$ node --version
v0.10.25
$ npm install htmllint
...
<EMAIL_ADDRESS>node_modules/htmlhint
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS><EMAIL_ADDRESS>└──<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>
I am actually trying to get https://github.com/AtomLinter/linter-htmlhint to work.

Try to update node to new version v4.1.2, then try reinstall htmlhint again.
npm install htmllint -g

Ok. Do you know of any Ubuntu PPA that has Node v4.1.2 packaged? The only one I found is not much further advanced than Ubuntu Trusty itself.

It seems your nodejs is not instal well,so the dependencie cannot finded.

My NodeJS installation is just the original package from Ubuntu. I did not modify anything.

@devurandom according to this page on nodejs.org there used to be an up-to-date PPA (Chris Lea's), but it's now transitioned into the NodeSource process, which I'm not sure how it works (it seems to be removing the PPA but not adding a new one). Anyway, if you follow the instructions on the nodejs.org page linked above, it should allow you to update node. You might have to remove your current installation first, or maybe NodeSource takes care of that. Try it out and see if it works for you :)

@waldyrious Thanks! After installing the current version of NodeJS, uninstalling all modules with npm uninstall and rm -fr ~/.npm, then reinstalling htmlhint, it appears to work.

@devurandom great to hear :) you can close this issue then.


Release notes for Client libraries for Preview 1

We are not going to ship Certs as part of Preview 1, so I didn't bother to change it...


REPO NO LONGER MAINTAINED - USE LINKED FORK INSTEAD - STOP LOGGING ISSUES

Thanks @yishanhe for finding a good and maintained fork:

Really appreciate that @skygragon contributed such a great tool.
But since it is not got maintained for more than half year.
I drilled down the fork network and found https://github.com/leetcode-tools/leetcode-cli is
very active and is maintained by the @jdneo who is the author of vscode-leetcode.
Maybe it is time to move on. But it is always better if we can avoid divergence.

https://github.com/skygragon/leetcode-cli/issues/173

@shyal sorry for my reply lately... the truth is, I got a new job last year and honestly it does cost all my energy and time due to the well-known 996 pressure...
However I'm glad you guys like @jdneo are helping around during my absence. Also I'm thinking of a better way to keep this project more active/responsive. I guess friends here are students mostly or working guys that seeking a job, eventually they will have new focus and move on. While I'd like to keep this project alive forever, and sincerely welcome more maintainers to make this happen.

Echo for @skygragon. So far I was just making some workaround to the leetcode-cli in the fork. But it's not recommended to take that fork as a final solution. I'm still hoping the vscode-leetcode can directly use the original cli to provide features to the users.
It will be great if anyone is volunteer to be a maintainer for this great project.

@skygragon great to hear from you. My suggestion is to designate a team of maintainers to evaluate and approve pull requests. In my case, i've fixed issues in my branch that already have pull requests that were never merged.
It's totally understandable that you're busy with your job. My guess is this repo will remain is good health if some maintainers are allowed to merge into it.

Can we close this issue or at least modify the title so it is not so misleading?

Is this repo still maintained by no one?
If so, I think the best fix is to create an organization and put this repo under it.
If not, just close it, please. It is misleading.


add shm-size parameter for bigger import to docs

Since implementing the Postgres tuning the container can run into shared-memory constraints.
Importing bigger datasets (eg Europe) with the default settings I run into the error:
psycopg2.errors.DiskFull: could not resize shared memory segment "/PostgreSQL.489086426" to 50438144 bytes: No space left on device
This happens because the default size of /dev/shm in a docker container is 64M, on the host it typically is set to RAM_SIZE/2. Therefore you can increase the size by adding  --shm-size= as a parameter to the run command.

LGTM, particularly since it's only documentation.


stake-pool: Stake pool deserializer

This PR allows successful deserialisation of StakePool and ValidatorList account data. I wrote Borsh.js schema and Typescript bindings in schema.ts, and some helper functions in index.ts to try out the bindings.
For consistency, I've used the same Prettier settings as the one used in token/.
NOTE: We want to get borsh-js to release a new version ASAP (the one that includes the u128/u256/u512 methods by @joncinque), because currently the import in package.json relies on having borsh on your local machine, which is really not ideal:
"borsh": "file:../../../solana-repos/borsh-js",

I've incorporated all of the requested changes from Jon:

Removed extraneous .js files
Changed schema
Stopped using a.account.data.length and instead filtered on the first byte to distinguish between StakePool and ValidatorList
Wrote individual functions to get a single StakePool or ValidatorList account

And a few of my own:

Added two helper interfaces, decodedStakePool and decodedValidatorList.
Wrote helper functions to pretty print public keys and decoded accounts
Cleaned up the code

Looking close, just a few more comments! Then we'll need to wait for the borsh stuff to be integrated, let me ping on that side

Fix borshjs import (blocking: if the near folks don't release a new version, we may have to publish our own package)
Write unit and integration tests
Fill in fields in package.json

@joncinque , it looks like near still hasn't released a new version -- what do we have to do?

They actually did release their new version!  And it was integrated with the newest web3.js in https://github.com/solana-labs/solana/pull/17239, so you can go ahead and use all of the newest stuff

I've upgraded the borsh import, wrote tests to verify correctness of schema.decode, and filled in fields in package.json. I think I'm ready to merge.

Used new version of borsh.js in PR https://github.com/solana-labs/solana/pull/17620 (thanks @joncinque)
Refactored type names
Add new testOnDevnet test
Upgrade web3js version

  schema.decode
    StakePoolAccount
      ✓ should successfully decode StakePoolAccount account data
    ValidatorListAccount
      ✓ should successfully decode ValidatorListAccount account data
      ✓ should successfully decode ValidatorListAccount with nonempty ValidatorInfo

  index.ts/PrettyPrintPubkey
    ✓ should successfully pretty print a pubkey

  testOnDevnet
    ✓ should successfully decode all validators from devnet (476ms)

  5 passing (862ms)

All right, let's get this in!  We can do more tweaks for the updated fields and integrate CI in later work.  Thanks for your contribution!


Remove terraform.tfvars from source control

Moves terraform.tfvars -> terraform.tfvars.template, the readme
already tells folks to run make init on setup.
Adds tfvars to gitignore, to prevent accidental committing of secrets

LGTM


[Marker.io] Double up of key features

Prezzee Business Portal Page
Tried to screens shot both.

Reported by: Holly<EMAIL_ADDRESS>- Contact via Marker.io
Source URL: https://na13-prezzee.webflow.io/en-us/corporate-gifting-solutions/business-portal
Issue details: Open in Marker.io
Device typedesktopBrowserChrome <IP_ADDRESS>Screen Size2048 x 1152OSOS X 14.7.1Viewport Size1987 x 941Pixel Ratio@2x

🤖 Marker.io bot - This issue was marked as ✅ Resolved in Marker.io


.scss files not processed from index.html

Bug Report
.scss files aren't processed to css when included via link tag in index.html
(this would be useful for global styles: e.g. styling the body as this doesn't seem to work in the default app.component.css)
Expected Behavior
.scss files are processed to css if they are included via a link tag in the index.html file.
Actual Behavior
.scss files aren't processed in index.html
Reproduction

Create a new project

ng new project-name --prefix pn

Add .scss support

ng set defaults.styleExt scss

Add link to index.html

<head>
<!-- other things -->

<!-- This could work if webpack were configured to check if theme.css exists; if not, then check for theme.scss and process that -->
<link rel="stylesheet" type="text/css" href="theme.css">

<!-- This doesn't work either.
<link rel="stylesheet" type="text/css" href="theme.scss">
-->
</head>

Create theme.scss

@import './variables'

body {
background-color: $bg-color;
}

Create variables.scss

$bg-color: red;

Serve

ng serve
Version details:
OS: Windows 10
node: 6.3.1
<EMAIL_ADDRESS>

can you copy and paste your component code?

@PiusNyakoojo sass will not compile your styles when including them that way. you can only link stylesheets that way if they are static assets. In the current master of the cli you can point to a main stylesheet which can be sass.

if you have a global static stylesheet you want to include you can put it in the public folder. Or if using master in src/assets

I've tried to put a .scss file in the public folder and it doesn't see the styles.

see #1459

@sirajc Thanks.
This PR addresses my concern: https://github.com/angular/angular-cli/pull/1633
In short:
When this request is merged to the main branch (when the angular-cli team releases the next version of the cli), we can add "styles": "our.style.scss" to angular-cli.json as part of the apps[0] metadata.
Concretely:
"apps": [
    {
      "main": "src/main.ts",
      "tsconfig": "src/tsconfig.json",
      "mobile": false,
      "styles": "src/our.style.scss" // Available in next version of angular-cli
    }
  ],

Hello,
sorry to comment an already closed issue, but I need to clarify myself with.
My config OS: Windows 10 node: 6.3.1<EMAIL_ADDRESS>If i create in [myproject]/src/app/style.scss this file is ignored by angular-cli and it's not compiled and published alongside the other files?
Just scss in components are parsed when calling ng serve (or ng build)?
Thanks for any clarifications!

@kennyrulez here are a few things you could check
1. Did you create this project with
ng project-name --style=sass
No? Then did you add sass support with
ng set defaults.styleExt scss
2. Is style.scss referenced in one of your components?
// for example

@Component({
  templateUrl: './app.component.html',
  stylesUrl: ['./style.scss']
});

3. Are you trying to style the body tag? For this, you may want to make the stylesheet global
// reference your styles in angular-cli.json

"apps": [
   {
       // ... other stuff
      "styles": [
         "./src/style.scss" // reference your style sheet here
      ]
   }
]

ng serve is just ng build + watching your files for changes then rebuilding and reloading page

@PiusNyakoojo thanks for your response. Number 3 is exactly what i want to achieve.
I modified angular-cli.json as you suggest
"apps": [
    {
      "main": "src/main.ts",
      "tsconfig": "src/tsconfig.json",
      "mobile": false,
	   "styles": [
         "./src/app/app.scss"
      ]
    }

and referenced in index.html as
<link rel="stylesheet" type="text/css" href="app/app.css">
No way of getting it working. It seems is not compiling it nor bundling it.
Thanks for your help!

I hope you don't have mind to join to your conversation.
Currently Im struggling with global _variables.scss` file.
My project is using sass and  I want to create one scss file with all variable of my project (something like an global scss). When I am including this _variables.scss file into my app.component.ts or importing into app.component.scss only the stylesheets  for app.component are seeing this variables..
When I`m trying to use some variable in another scss I am receiving an error:

Module build failed:   xxx xxx Undefined variable: "xxx".

Is it possible to have a _variable.scss and use it variables without including it in every single component?

See response by filipesilva in #1780.
Apparently the global styles configuration is the way to go, but it made it into the documentation before the actual release, so you have to wait for the next webpack release for it to actually work.
"apps": [
   {
       // ... other stuff
      "styles": [
         "./src/style.scss" // reference your style sheet here
      ]
   }
]


Support for Slim 2.6 version

Hey, thanks for great addition to Slim!
Any plans to update this package to use Slim 2.6+ version (https://github.com/slimphp/Slim/releases)?
Thanks!

I am also interested in

I've updated the slim dependency to be 2.* in slimcontroller version 0.4.3.
This will allow you to use newer versions of slim including 2.6.2.


tagged_with returns duplicates on a model with two different types of tags

I have a model like this
  class Listing
   acts_as_taggable_on :user_tags
   acts_as_taggable_on :automatic_tags
  end

"user_tags" are those that the creator of the Listing assigns and "automatic_tags" are those that a backend system computes and adds to the model.
If I create a listing and add the same tag to each list....
 l = Listing.new
 l.user_tag_list = "interesting"
 l.automatic_tag_list = "interesting"
 l.save!

And then I do a tagged_with query...
 Listing.tagged_with("interesting")

The same Listing is returned twice because the query doesn't contain a DISTINCT clause.  If you use :any => true you can get the right behavior for one tag however if you want multiple tags and you really want AND behavior it doesn't work.  :match_all also doesn't work because it is exclusive (i.e. it'll only return Listings that ONLY HAVE the specified tags and nothing more).
For my particularly problem I can get around it like this...
 Listing.tagged_with('interesting').select("DISTINCT listings.*")

but that feels a bit hacky and made me wonder...  How come DISTINCT is added in the :any case but NOT in the default.
Sorry I didn't have time to create patch/pull request.

:+1:

+1

+1

AppServiceProvider
Relation::morphMap([
'boo' => \App\boo::class || \App\Admin\boo::class,
]);


Fake DOM element has no getBoundingClientRect method

To reproduce, select a react-faux-dom div with D3, append an svg, and then call a behavior, e.g.:
import d3 from 'd3';
import ReactDOM from 'react-dom';
import { createElement } from 'react-faux-dom';

const target = createElement('div');
d3.select(target).append('svg').call(d3.behavior.drag());
ReactDOM.render(target.toReact(), document.getElementById('render-target'));

The browser throws an error when you click/drag the svg element:
d3.js: Uncaught TypeError: x.getBoundingClientRect is not a function
Similar code using a real DOM element throws no error:
const target = document.createElement('div');
d3.select(target).append('svg').call(d3.behavior.drag());
document.getElementById('render-target').appendChild(target);

The desired behavior is that the fake element supports getBoundingClientRect, like a real DOM element.

adding getBoundingClientRect to the Element api  would be GREAT as its all that's keeping a bunch of ported code from running!!

+1

All thanks to @alexyuly, v2.7.0 contains this feature. I hope everything works well for you all, feel free to open issues if you encounter... issues.

Thanks for merging @Olical!


Bump go version to 1.10.2 for travis for release-9.0

Travis is broken on release-9.0. This PR fixes it and unblocks other direct PRs to this repo on release-9.0.
See https://github.com/kubernetes/client-go/pull/467 - similar PR for master for more details.

/assign @sttts
/cc @dims

/assign @liggitt
for approval since @sttts is out

@liggitt can you also /approve?

/approve


Define single entry point to tweet generator

The entry point should be usable by both bots and by developers with the use of command line options.
Inputs:

Number of headlines to generate
Custom grammar origin

Outputs:

Array of headline objects:

Text
Array of image files/buffers

Success/Failure state

For local developers, the text will print on the console, the image file locations will be logged.
For the bot, the text and images will get posted to twitter.

Goals:

Reduce duplication of code
Improve the detection of errors before deploying to the twitter bot
Improve the use of this bot as a CLI tool

In progress: https://github.com/mdiehr/mtgnewsbot/pull/91


Never complete ViewModel.stateFlow

There are three reasons of this change:

It's very likely that CoroutineStateStore will be backed by SharedFlow once it will be released. SharedFlow never completes, so it's good to make this decision now to avoid behavior change in the future.
@gpeal and me didn't find good usecases for completeable stateFlow. But we found a case when it's better to have a flow that never completes - for example: viewModel.stateFlow.first { // condition } may complete exceptionally if Store's scope cancelled before condition.
It also matches behavior from mvrx 1.x - there was no .onComplete() call in RealMvRxStateStore. (There was no similar api to stateFlow though, but anyway).

Reminder: CI checks do not run for my PRs, locally I ran gradlew testDebugUnitTest detekt assembleDebug

@denis-bezrukov Three are still some failing tests such as PureReducerValidationTest

@gpeal are you sure?
it works to me in both AS and gradle:

Gradle:

2020-10-07T01:34:47.863+0400 [DEBUG] [TestEventLogger] com.airbnb.mvrx.PureReducerValidationTest > shouldBeAbleToUsePrivateProps PASSED
2020-10-07T01:34:47.888+0400 [DEBUG] [TestEventLogger] com.airbnb.mvrx.PureReducerValidationTest > pureReducerShouldNotFail PASSED
2020-10-07T01:34:47.917+0400 [DEBUG] [TestEventLogger] com.airbnb.mvrx.PureReducerValidationTest > impureReducerWithPrivatePropShouldFail PASSED
2020-10-07T01:34:47.942+0400 [DEBUG] [TestEventLogger] com.airbnb.mvrx.PureReducerValidationTest > impureReducerShouldFail PASSED
2020-10-07T01:34:47.943+0400 [DEBUG] [TestEventLogger] com.airbnb.mvrx.PureReducerValidationTest PASSED

Could it be local execute issue? (e.g. with robolectric initialization?), could you repro this via ./gradlew clean testDebugUnitTest --rerun-tasks? What kind of error do you see?

@denis-bezrukov I think you're right. They passed for me.


Unclear state when https connection terminated - Android

Describe the bug

Attempt to load any https website with with invalid https (selfsigned /expired cert or cert for wrong domain/etc)
Nothing happens

This can lead to misleading scenarios as the urlbar will still say that the current URL is the https one.
This also means there's no warning that you were trying to access a website which then got denied.
How to Reproduce
Misleading Scenario:

Go to a website with invalid https over http http://eusprig.org/horror-stories.htm or http://neverssl.com
Edit url to be https scheme rather than http https://eusprig.org/horror-stories.htm or https://neverssl.com
See that the original website is still visible

Visited http, then attempted to visit https which didn't work. http page still rendered but url bar says "https"

Clicking on the privacy report correctly says that the website was http

Lack of a warning that anything's wrong

Go to an invalid https website
Nothing happens or changes

Expected behavior
A warning of some kind to be emitted when the connection was aborted due to invalid https server.
The current screen to be cleared, the previous page shouldn't be rendered while the url is display the new (invalid) page location
Smartphone (please complete the following information):

DDG App Version: 5.67.0 sc (56700)
Device: Oneplus 5
OS: Android 9, OxygenOS version 9.0.11

Thanks for reporting.
I've been taking a look at the code to understand the issue here.
Turns out that when visiting a site with an invalid certificate after the user has visited a valid site, the WebView loads again the previous site. So in this case, the issue here is that we are not updating correctly the URL.
For the record, we update the URL bar when:

we detect a new site being loaded
a site updating the URL (user forwarded or similar)
from a user input

In this case, the URL bar gets updated by a user input event. Because the site submitted has an invalid certificate, WebView loads again the previous site, we don't detect that as a "new site being loaded", and we don't update properly the URL bar.
Since we are not currently handling invalid certificates, the proper fix for the issue is to detect that the previous page has been loaded again and update the URL bar.

We are tracing this issue internally: https://app.asana.com/0/414730916066338/1198486065923453/f

Thanks for getting back to me.
That would certainly be an improvement, but I do think there should be some level of warning when a connection is stopped due to invalid certs. What you're proposing would put someone back to the previous page every time, which feels unexpected to me.

Yes, I do agree with you. We should show some kind of warning if we detect any issue related to an invalid certificate.

What you're proposing would put someone back to the previous page every time, which feels unexpected to me.

Yes, it was unexpected for me too. I didn't explain it correctly. That's WebView's default behavior. If WebView is moving the user back to the previous site, we should update the URL bar accordingly (at least as a quick fix). But that doesn't mean that we will not work on showing a warning when an invalid certificate is found too.

I've created another internal task proposing to warn users about invalid certificates: https://app.asana.com/0/414730916066338/1198502707847229/f

Closing this stall issue. This doesn’t apply anymore.

The behaviour is still present and occurring with 5.160.0
It can be tested with http://neverssl.com rather than the previously supplied domain above.

Mind reopening @malmstein ?


Remove pins of flake8 linter packages

Description
Remove pins of flake8 linter packages
Checklist

[ ] I have added screenshots above for all UI changes.
[ ] I have added e2e tests for all UI changes.
[ ] Documentation was updated if it was needed.

Codecov Report

Merging #2328 (5ac4977) into main (7b7054f) will decrease coverage by 6.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2328      +/-   ##
==========================================
- Coverage   88.53%   82.51%   -6.02%
==========================================
  Files         133       21     -112
  Lines        7581      429    -7152
==========================================
- Hits         6712      354    -6358
+ Misses        869       75     -794

Flag
Coverage Δ

unittests
82.51% <ø> (-6.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
see 112 files with indirect coverage changes


Artist’s artworks overview incorrect number of works.

Consider the artist ‘Jim Krantz’. He is listed to have 18 artworks on Artsy, which on the web is correct. On the iPhone app, however, I count 28 works.

Could be you're an admin and seeing the unpublished works

Fixed by #497.


copy/paste not working

There's no way to select chunks of disassembly (or IL), nor do the copy/paste menu choices work.

Potentially related - in hex view, when the hex side is selected, Command+C inputs 0xc. Command+v pastes the contents of the clipboard.
If you select a range, Command+C works as expected.

Fixed in dev (multiselect is not done, see #91)


Update README.md

update some of the badges on the github repo front page

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (967fe94) 100.00% compared to head (17068c4) 100.00%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##              main       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            2         2
  Lines            6         6
=========================================
  Hits             6         6

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

going to update with a new pull request so all checks pass


windows_certificate: add support for obtaining pfx certiifcate data from a certificate store

Signed-off-by: John McCrae<EMAIL_ADDRESS>

Is this something we can do with a property that changes the type vs. an action? The action still seems to be fetch here. Adding a new action per cert type seems to break our overall UX in chef.

This was merged in #11405


tbody error!

Line 234 to line 235
Element tbody not allowed as child of element table in this context.
In /index.html

It isn't? I'm a little bothered by the tfoot being above the tbody, as my understanding is that that order isn't allowed any more in HTML5 (although browsers appear to generally still support it). I don't see why the tbody wouldn't be allowed there though.
Not a maintainer of this or anything, just stumbled here and am curious.


Use matrix to store interactions?

Right now, the interactions are stored inside BTreeMap associating particles types and a vector of interactions. Using a 2D (for pairs and bonds), 3D (for angles) or 4D (for dihedrals) matrix could make the interactions access faster.
This would use more memory, and fill the CPU cache with garbage. So benchmarks are needed!

Decide how many atomic types we would get in the worst and standard case.
Also check sparse matrix storage, which may mitigate the memory requirement;

Another possibility would be to use a map based on a sorted vector, something like this:
struct SortedMap<K, V> {
    data: Vec<K, V>
}

// keep data sorted with respect to K on insertion, and use binary search on lookup

Anyway, benchmarks are needed!

I tries this a few times, and did not see improvements


Replace atlas config JSON with BIDS-Atlas datasets

Summary
Just a thought. Related to https://github.com/PennLINC/xcp_d/issues/1226 and #12.

This wouldn't be too hard of a change. We might need to keep a repo of the mids style metadata for the parcellations somewhere until templateflow is willing to host them

Should have been closed by #123.


Asteroid class

Based on advice from this comment, asteroids are now a class rather than a "PackedScene".
I was initially planning to implement "asteroid speed is inversely proportional to size" in this branch, but it appears we already do that. See here. So, I'm left with a branch that just does some refactoring. 😅
The direction range for asteroids is also narrowed down, as we discussed. It didn't seem worth having its own PR for this change 😄
When I first tested this change I realised that I'd broken it so that asteroids didn't deal or take damage. Then I learned about "groups" in Godot. Still getting my head around the idea but I think that since an object can be a member of any number of groups it might make sense to define groups based on functionality rather than based on entity type. And since the asteroid and enemy groups are functionally equivalent I went ahead and merged them into one group. I'd be happy to roll this change back if you see things differently. But saying an asteroid is an "enemy" feels right, doesn't it? 😄

Everything looks fine. I agree that asteroids are enemies and it gets rid of some "duplicate code". There was one conflict in the project.godot file that i have resolved manually... only time will tell if it breaks the game!


Leaking file descriptors

When doing http requests in golang, you need to close body or it will leave open socket connections.
https://github.com/iamatypeofwalrus/logspout-loggly/blob/master/loggly/loggly.go#L106
The limit of open files on linux is 1024.
The issue can be verified using lsof util.
Fix is very simple
https://github.com/kirillrdy/logspout-loggly/commit/5cf3073428805c751038d510a0a27884fbabcd68
For references:
https://golang.org/pkg/net/http/
The client must close the response body when finished with it:

You only need to defer resp.Body.Close() if you actually open and use the body. The code only uses Status code which is on the Response struct
From the http docs:
resp, err := http.Get("http://example.com/")
if err != nil {
	// handle error
}
defer resp.Body.Close()

// Body is actually being used
body, err := ioutil.ReadAll(resp.Body)
// ...

Examples of requests where body is not accessed and thus not closed
resp, err := http.Get("http://example.com/")
...
resp, err := http.Post("http://example.com/upload", "image/jpeg", &buf)
...
resp, err := http.PostForm("http://example.com/form",
	url.Values{"key": {"Value"}, "id": {"123"}})

Hi,
I can reproduce the issue with this small go app.
It should be equivalent to what your are doing in your code.
Here is my env:
go version
go version go1.4.3 linux/amd64

uname -a
Linux yao-local 4.2.3-300.fc23.x86_64 #1 SMP Mon Oct 5 15:42:54 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux

ulimit -a
1024

Limit of open files per process on linux is 1024
package main

import (
	"bytes"
	"log"
	"net/http"
)

func pan(err error) {
	if err != nil {
		log.Fatal(err)
	}
}

func doRequest() {
	js := []byte{1, 2, 3, 4, 5}
	req, err := http.NewRequest("POST", "http://google.com/", bytes.NewBuffer(js))
	pan(err)
	_, err = client.Do(req)
	pan(err)
}

var client http.Client

func main() {
	for i := 0; i < 2015; i++ {
		log.Println(i)
		doRequest()
	}
}

End of output:
2016/02/11 09:05:21 986
2016/02/11 09:05:21 987
2016/02/11 09:05:21 988
2016/02/11 09:05:21 989
2016/02/11 09:05:21 990
2016/02/11 09:05:22 991
2016/02/11 09:05:27 992
2016/02/11 09:05:27 993
2016/02/11 09:05:27 994
2016/02/11 09:05:27 995
2016/02/11 09:05:32 996
2016/02/11 09:05:33 997
2016/02/11 09:05:33 998
2016/02/11 09:05:33 999
2016/02/11 09:05:33 1000
2016/02/11 09:05:33 1001
2016/02/11 09:05:34 1002
2016/02/11 09:05:34 1003
2016/02/11 09:05:34 1004
2016/02/11 09:05:34 1005
2016/02/11 09:05:34 1006
2016/02/11 09:05:35 1007
2016/02/11 09:05:35 1008
2016/02/11 09:05:35 1009
2016/02/11 09:05:35 1010
2016/02/11 09:05:35 1011
2016/02/11 09:05:36 1012
2016/02/11 09:05:36 1013
2016/02/11 09:05:36 1014
2016/02/11 09:05:36 1015
2016/02/11 09:05:36 1016
2016/02/11 09:05:37 1017
2016/02/11 09:05:37 1018
2016/02/11 09:05:37 1019
2016/02/11 09:05:37 1020
2016/02/11 09:05:37 Post http://google.com/: dial tcp: lookup google.com: too many open files

You can also see number of open files growing using lsof util.

Confirmed via your code along with this link and this other one. Will patch tonight along with your other issue.
Thanks for these!

fixed in https://github.com/iamatypeofwalrus/logspout-loggly/commit/8943d7745b2a5b3458617969d67308413bc8af82


Fix small typo in data-sources.md

There is a minor type in the following sentence: "This integrates with the Log Analytics agent to collects discovered data about processes running on the virtual machine and external process dependencies."
I have changed collects to collect.

@liammoat : Thanks for your contribution! The author, @bwren, has been notified to review your proposed change.

#sign-off


Julti Wall - Lock icon sometimes doesn't load

work-around by restarting wall window (alt+f4 it)

Closing because Julti Wall is no longer the focus. In the future I look to make OBS setup even easier.


feat(grid): remove viewportIndex and only rely on viewportId

Context
During the development of OHIF, the reliance on viewport index has proven to be problematic. This issue has seen in several ways:

Inconsistent Viewport Indexing with Layout Changes: A change from a 2x2 to a 3x3 grid alters the viewport index, causing unnecessary re-rendering, even though the display sets remain the same. This has resulted in a lack of optimization in grid rendering during stage and layout changes.

Viewport Movement Problems: for moving a viewport (similar to moving a person's window in Zoom, which we have in plan to support in future), the change in viewport index forces React to re-render the whole grid (as right now we have the key as viewportIndex). While the element itself hasn't changed, the viewport index change causes a problematic full re-render.

Changes Made

Removed Viewport Index: All occurrences of the viewport index have been replaced with viewportId. This prevents the above issues related to the inconsistency of the viewport index.
Changed Viewport Grid State: The viewport grid state has been modified from an array to a map, using viewport IDs as keys. This provides a more stable mapping of viewports.

Testing
The implemented changes have been tested, and the following features are working as expected:

Rendering a default viewport
Rendering a TMTV
Rendering segmentation and RT struct
Enabling double-click on a thumbnail
Changing layout, going MPR, adding measurements
Toggle One Up works
Viewport Labels (ABCD) works
Presentation States is preserved
Change from 2x2 to 3x3 works

Cheers

@jbocce can you try again? I can't reproduce it

I don't understand haha, can you try in cognito or something else?
https://github.com/OHIF/Viewers/assets/7490180/3aef504b-2359-47b4-814e-2c5a5df8170d

I don't understand haha, can you try in cognito or something else?

I just tried incognito, Firefox and Edge. ALL show the same problem.

Ok i will look

@wayfarer3130 @jbocce I fixed the reported bugs and a handful of more bugs and tests, can you look again?

A couple more things I found...

I noted this in the cornerstone commandsModule file, but I confirmed that the bug fixed by PR #3560 is broken now.
For PET SUV, when I change the patient weight and click Reload Data, I get the following exception in the console...

Uncaught (in promise) ReferenceError: viewportIndex is not defined
    at Object.callback (OHIFCornerstoneViewport.tsx:270:11)
    at pubSubServiceInterface.js:85:16
    at Array.forEach (<anonymous>)
    at W.c [as _broadcastEvent] (pubSubServiceInterface.js:84:31)
    at W.setDisplaySetMetadataInvalidated (DisplaySetService.ts:159:10)
    at onClick (PanelPetSUV.tsx:142:23)
    at onClick (Button.tsx:93:7)
    at Object.je (react-dom.production.min.js:52:317)
    at Qe (react-dom.production.min.js:52:471)
    at react-dom.production.min.js:53:35

@jbocce Thanks for thorough review, applied/fixed based on your comment

Great work fixing the issues I found! Thanks so much.
I think the following comments should be discussed and/or addressed...

https://github.com/OHIF/Viewers/pull/3591#discussion_r1303091533
https://github.com/OHIF/Viewers/pull/3591#discussion_r1304321413
https://github.com/OHIF/Viewers/pull/3591#discussion_r1304284150

@jbocce applied all three comments

@jbocce I think I got it

@jbocce I think I got it working for the double click too

Yes. Thank you for that. See my comments.


  Please see the screenshot from api - demo page
What is the current behavior?
What are the steps to reproduce?
Providing a Plunker (or similar) is the best way to get the team to see your issue.
Plunker template: https://goo.gl/DlHd6U
What is the use-case or motivation for changing an existing behavior?
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Is there anything else we should know?

Fix already in master via https://github.com/angular/material2/pull/4696

@willshowell is correct, this is fixed in master.

I still have this problem with the latest release.


Sync. issue

there is a sync. issue
whenever I try to add the dependency, it gives an error "failed linking resources", along with 3 other errors
I have attached a snapshots to show where the error points

I am new to android studio
please help

Thank you for adding your issue
We have reviewed the problem and discovered the issue
This error arises when the compileSdkVersion or targetSdkVersion is less than 28
This issue can be removed by setting them to 28 in your build.gradle(Module:app) of your project
Please let us know if the issue is resolved
regards