SC4S not parsing "Host" field from RSA SecurityID log source

Hello,
We are sending logs from one RSA Authentication Manger server using syslog method to SC4S. I have installed "Splunk Add-on for RSA SecurID" But its not able to parse Timestamp and Host information from syslog message.  It is picking up hostname of intermediate forwarder as "Host"  although actual source hostname in available in syslog message.
sample payload:
X.!.&......<14>2020-08-20 13:38:39,933, .prod.local, audit.runtim                                                                                e.com.rsa.ims.authn.impl.AuthenticationBrokerImpl, INFO, 0bb6fd74cdbdec0a468e20f                                                                                b4e040edd,0cc85ed7cdbdec0a7b3e64f332e9b9de,X.X.X.X,X.X.X.X,AUTHN_LO                                                                                GIN_EVENT,13002,SUCCESS,AUTHN_METHOD_SUCCESS,0b170579cdbdec0a1d5a96a8569e7277-kC                                                                                1JoZYTCbUl,694b0f4819b98d3f24c3ec8fd9001c01,000000000000000000001000d0011000,aea                                                                                32e6419b98d3f1aa6c6087db17e44,BEB_1149250_JEFFK118,<user,name>,fdb12d8c19b98d3f1                                                                                9eddac3049ed56f,000000000000000000001000e0011000,X.X.X.X,LRK1*****.p                                                                                rod.local,7,000000000000000000002000f1022000,SecurID_Native,,,AUTHN_LOGIN_EVENT,                                                                                5,1,,,,,f24358ae19b98d3f199b08cd28cd9bd6,000160187505,,
I can see SC4S error:
dtparse: Expected: %Y-%m-%d %H:%M:%S,%f; Actual: 13:56:50 555 |  -- | --

Any update on this?

Looks like a slight variation of what we expected will address in the next build

Thanks Ryan!


Added search and banner endpoints. Created KB processing.

Description
Endpoints added:

'/search/' returns a flat dict of results matching
'/search/' returns all datasets on scicrunch
'/banner/<dataset_id>' return url locations of banners from
Blacfkfynn

Additional processing added:
Added a function to flatten nested dictionaries for easier processing in javascript
Type of change
Delete those that don't apply.

[ x ] New feature (non-breaking change which adds functionality)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have added unit tests that prove my fix is effective or that my feature works

Look good, I will merge it in.


Describe our Business

User Story-
I want to create a comprehensive description of our business that effectively communicates our mission, values, products/services, and unique selling points to various stakeholders, ensuring a clear and compelling representation of our brand.
Actions-
Determine the unique selling points that set our business apart from competitors, emphasizing what makes our products/services valuable and desirable.
Results-
Deliver a well-crafted business description that provides a clear and compelling overview of the company, fostering understanding and connection with stakeholders.

My business is a basketball website where we specialize in selling basketballs. The brand archetype is is a hero archetype with methods of persuasion of reciprocity, social proof, and scarcity. My persona is "Max" and Max is a high school student who participates in many activities along with Varsity Basketball. Outside of practice, he focuses on his academics and basketball workouts throughout the rest of his evenings. Max is interested in buying a basketball that is affordable no matter the condition just to practice on his own.


Make a static build of the viewer

Making a static build could allow to implement all-in-browser views of worlds and schematics. It could be useful for websites to offer a preview for their downloads.
For building a static view, all files in https://github.com/PrismarineJS/prismarine-viewer/blob/master/lib/common.js must be generated.

index.js
worker.js
texture.png => depends on the version, but can be worked around by generating it for every versions
blocksStates.json => same as texture.png

Then we could decide to keep or not the dynamic generation (it depends if generating/storing textures and blocksStates for all versions is expensive or not).
While implementing that it may be the time to try webpack instead of browserify.

Related to this issue, we should investigate ways to reduce the file sizes of the js files.
Here are the js file sizes for the 2 main files in development:

index.js : 1.63 MB
worker.js : 16.9 MB

And production:

index.js : 741 KB
worker.js : 10.7 MB

The big size of worker.js is likely due to the embedding of mcdata, used to get the blocks for every version (while pviewer actually use only one).
For a typical speed of 1MB/s this is way too much to guarantee interactive load time.

An other issue is related to the project structure. In node, users can make their project depends on prismarine-viewer and use it with a simple require(). If we use wepack, we can generate client side code and resources at installation time. But how to integrate user code into the browser view ? The user project would have to do the build itself, using webpack or a similar tool.

What's the size of worker.js compressed ? The browser always use gzip.
The built front can be included in npm
On Wed, Dec 9, 2020, 20:55 Karang<EMAIL_ADDRESS>wrote:

An other issue is related to the project structure. In node, users can
make their project depends on prismarine-viewer and use it with a simple
require(). If we use wepack, we can generate client side code and
resources at installation time. But how to integrate user code into the
browser view ? The user project would have to do the build itself, using
webpack or a similar tool.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/PrismarineJS/prismarine-viewer/issues/69#issuecomment-742011373,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAR437XOTFHBAH36VI6DD3LST7I3PANCNFSM4UT43L3Q
.

Yeah ok for the size, I recall now that we already checked that and the solution was to enable compression on the webserver. In the end I think it was fine.
For the front, if you include it you still need to build it in the user project.

For the front, if you include it you still need to build it in the user project.

what is the user project? do you mean a front end project including pviewer and adding things ? if yes then sure
if it's a mineflayer bot including pviewer i don't see why that would be necessary to rebuild

yeah by user project i meant a front end project, the other cases are working already as it is.

Yeah ok that's fine then, they would just do an import of prismarine-viewer, maybe call a build function if necessary ?

Webpack or browserify handle dependencies fine


Do not bother retrieving the root zcap if the expectedRootCapability does not match

We should check expectedRootCapability (a capability ID or an array of capability IDs) against the ID of the root zcap before we retrieve it. There's no reason to bother retrieving the root zcap if it doesn't match one of the given capability IDs. We should only retrieve it once it does match and to confirm that the invocation target in the root capability matches one of the expected targets.

Closing as another path is taken by #73.


Electron FCast Reciever - Long (multi-line) captions get cut off

If a single caption spans longer than one line, it seems to go off the bottom edge of the window:

Example is from a Tsoding Daily video, where captions are used to optionally display Twitch chat messages
Receiver version: 2.0.0
OS: Linux x64

Thanks for reporting, fix will be available in next version.
https://github.com/futo-org/fcast/commit/565579d202d3ea7830f729aae3bf335504174deb


WiP: Towards ScientificData-compliant output

This PR aims to eventually address all outstanding issues (see those listed below for a summary of what needs to be accomplished). As most of them are heavily inter-dependent this will be approached in one go. No intermediate commit should break existing functionality.

[x] #3
[x] #4
[x] #5
[x] #6
[x] #7
[x] #8
[x] #9
[x] #10
[x] #11
[x] #12
[x] #13

Please don't merge while still titled "WiP: ...". Please comment on this at any point.

All initially identified issues have been addressed -- now waiting for review.


Plausible Analytics

This PR integrates the Plausible Analytics script.

:tada: This PR is included in version 1.14.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Helpful-Material page style

The design does not look like index.html or contribution.html

I'll take this


Install instructions with respect to $HOME/.terraform.d/plugins/ or $HOME/.terraform.d/plugins-cache/

At the moment the install instructions dont mention that you have to create a throwaway terraform directory, put files referencing the provider you intend to use, then execute terraform init, all to just put some files in the plugin directory $HOME/.terraform.d/plugins/.
I realise this is mostly the terraform developers fault for not properly solving https://github.com/hashicorp/terraform/issues/15801 but following the install instructions for using a package manager basically dumped me strait down a rabbit hole and nerd sniped me. To help protect future nerds from getting sniped and wasting an hour fruitlessly searching for a solution it would be good to document/warn users here.
TLDR: It would be good to document this requirement, provide a workaround if possible, and perhaps explain that a proper solution is at the mercy of Hashicorp perhaps linking to the closed issue that didn't actually get solved. https://github.com/hashicorp/terraform/issues/15801
P.S. If this comes across as snarky, I apologise. The way that the linked issue ticket was handled got under my skin after spending an hour hunting for solutions, so I've done my best to share evidence of my frustrations as the example why this should be fixed without using language that is too loaded, but its a fine art at times. 😅
Edit: After running into a bug unrelated to this, I went to look at installing from source to get the fixes and I just discovered the install from source documentation covers most of this issue 🤦♂ Its probably worth rearranging the docs a bit so that people reading the package manager docs cant miss it like I did.

Thanks for raising the issue. Looking at the tool from developer’s perspective is a little bit different...
I agree, that’s a good idea to rearrange the documentation. Along with that it would be great to split the documentation of the supported resources from the rest of readme. In its current form, with everything in one big blob, it’s hard to find anything.

I've just installed Terraformer from releases (Linux) with the provided four line snippet. When running against AWS I receive the following message.
2020/04/08 14:38:27 open /home/user/.terraform.d/plugins/linux_amd64: no such file or directory

At first sight, this seems related to your remark on the install instructions. Now, I'd like to know what the subsequent steps are I need to take to make this running because the README doesn't make that clear to me.

@GaramNick Yup. Even I faced the same issue with plugins. Had to install using init.tf to solve the problem. README might need to be updated.

not stale

Not stale!!

Same here and still haven't figured out what I have to do:
$ terraformer google list
2021/05/17 14:58:42 unknown command "google" for ""
$ terraformer list google
2021/05/17 14:58:50 unknown command "list" for ""
$ terraformer google import --help
2021/05/17 14:59:31 unknown command "google" for ""

Do I need to have terraform installed? If so, this should probs be stated in the README.
I installed terraformer via homebrew - what else do I have to do now? Do I have to put one of these somewhere? Do I have to add a versions.tf and terraform init? (and why?)
Also, if terraform is a prerequisite the brew formula should have it as dependency :)

There are a number of issues that have gone stale, regarding failure to correctly discover plugins, and the issue has been complicated by the addition of newer versions of terraform not using the .terraform.d/plugins/ folder, in fact they can break if you use that folder wrong. The recommended plugin-cache location should be searched in addition to the currently searched paths. https://www.terraform.io/docs/cli/config/config-file.html#provider-plugin-cache

https://github.com/GoogleCloudPlatform/terraformer/issues/590
https://github.com/GoogleCloudPlatform/terraformer/issues/592
https://github.com/GoogleCloudPlatform/terraformer/pull/608 ( Still has people commenting on it with issues )

Here's my procedure for getting terraform to populate the plugins cache so that terraformer can find it:
echo 'plugin_cache_dir = "$HOME/.terraform.d/plugins"' >> ~/.terraformrc
mkdir -p ~/.terraform.d/plugins

Since terraform caches the plugins by default in the .terraform subdirectory of the project root, rename or delete this directory so that the plugins need to be reinstalled. Finally
terraform init

Not stale, still have this issue with tf 0.14 and terraformer v0.8.18

Definitely not stale, so bumping

bumping yet again, this issue still persists

This problem will still arise now
OS: Linux64
terraform: v1.2.3
terraformer: v0.8.21

Same issue on Windows. Terraform init did not fix.

the issue is still there.
the fix that worked for me was:

initiating a new terraform  project ('temp_project') for the cloud provider  i need with 'terraform init' (in my case google)
cp temp_project/.terraform/providers/registry.terraform.io/hashicorp/google/5.20.0/linux_amd64/*   ~/.terraform.d/plugins/linux_amd64/
chmod 644  ~/.terraform.d/plugins/linux_amd64/terraform-provider-google_v5.20.0_x5

Not stale

I'm running terraformer to reverse-engineer some work done in an AWS environment, and this worked for me at first startup
mkdir force_terraform_to_download_plugins
cd force_terraform_to_download_plugins
echo 'provider "aws" {}' > main.tf
terraform init
mkdir -p ~/.terraform.d/plugins/linux_amd64/
cp .terraform/providers/registry.terraform.io/hashicorp/aws/*/linux_amd64/* ~/.terraform.d/plugins/linux_amd64/
cd ..
rm -rf force_terraform_to_download_plugins
terraformer import aws --resources="*"


Ophyd-async devices give bad error when not able to connect

If I have an ophyd-async device where one of the PVs cannot connect I get the following error when I run the system tests (i.e. through make_all_devices):
Traceback (most recent call last):
  File "/scratch/ffv81422/hyperion/dodal/tests/system_tests/test_i03_system.py", line 23, in <module>
    make_all_devices(i03)
  File "/scratch/ffv81422/hyperion/dodal/src/dodal/utils.py", line 125, in make_all_devices
    devices: dict[str, AnyDevice] = invoke_factories(factories, **kwargs)
  File "/scratch/ffv81422/hyperion/dodal/src/dodal/utils.py", line 150, in invoke_factories
    devices[dependent_name] = factories[dependent_name](**params, **kwargs)
  File "/scratch/ffv81422/hyperion/dodal/src/dodal/beamlines/i03.py", line 160, in smargon
    return device_instantiation(
  File "/scratch/ffv81422/hyperion/dodal/src/dodal/utils.py", line 98, in wrapper
    return func(*args, **kwds)
  File "/scratch/ffv81422/hyperion/dodal/src/dodal/beamlines/beamline_utils.py", line 105, in device_instantiation
    _wait_for_connection(device_instance, sim=fake)
  File "/scratch/ffv81422/hyperion/dodal/src/dodal/beamlines/beamline_utils.py", line 51, in _wait_for_connection
    call_in_bluesky_event_loop(
  File "/scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/bluesky/run_engine.py", line 2649, in call_in_bluesky_event_loop
    return fut.result(timeout=timeout)
  File "/dls_sw/apps/python/miniforge/4.10.0-0/envs/python3.10/lib/python3.10/concurrent/futures/_base.py", line 460, in result
    raise TimeoutError()
concurrent.futures._base.TimeoutError
Task was destroyed but it is pending!
task: <Task pending name='Task-2' coro=<Device.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/device.py:48> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-1' coro=<wait_for_connection() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/utils.py:26> wait_for=<Future pending cb=[Task.task_wakeup()]> cb=[_chain_future.<locals>._call_set_state() at /dls_sw/apps/python/miniforge/4.10.0-0/envs/python3.10/lib/python3.10/asyncio/futures.py:392]>
Task was destroyed but it is pending!
task: <Task pending name='Task-5' coro=<Device.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/device.py:48> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-27' coro=<Signal.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/_signal/signal.py:59> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-28' coro=<Signal.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/_signal/signal.py:59> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-29' coro=<Signal.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/_signal/signal.py:59> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-30' coro=<Signal.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/_signal/signal.py:59> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-31' coro=<Signal.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/_signal/signal.py:59> wait_for=<Future pending cb=[Task.task_wakeup()]>>
Task was destroyed but it is pending!
task: <Task pending name='Task-32' coro=<Signal.connect() done, defined at /scratch/ffv81422/hyperion/hyperion/.venv/lib/python3.10/site-packages/ophyd_async/core/_device/_signal/signal.py:59> wait_for=<Future pending cb=[Task.task_wakeup()]>>

In this case there was a Motor that had an incorrect PV. The error has two issues:

It contains no hint of which signal failed
It has a bunch of later errors around task not being destroyed that confuse things (less important)

Note this could be an error internal to ophyd-async
Acceptance Criteria

The error is better in this case

FYI @coretl, this might stop us from using ophyd-async on the beamline as we won't be able to diagnose things

This needs @callumforrester and @rosesyrett as well. I don't know what the factories in dodal do with device connection. In DeviceCollector in ophyd-async there is some knowledge for pretty-printing the signals that didn't connect, but it may have some issues that @callumforrester identified, and the generalised version of it was going to make it into dodal at some point...

The system tests don't actually run through pytest. They don't enable any specific logging either. Even if we get additional logs I don't think that fixes the issue though? I feel like the Exception still needs to contain what timed out

Tom and I discussed, see linked issue above


Can’t get it to work with Vue 3 + Vite

Hello, I'm trying to get particles to work in my Vue 3 + Vite project (with poor results)
Could I just ask for a codesandbox with Vue 3 and possibly Vite? Even the most basic configuration would do.
Thanks a lot in advance
Which version are you using?
1.9.2
Is the latest version affected?
You can checkout latest version here

[x] Yes
[ ] No

Which library are you using?

[ ] Vanilla JS (tsparticles)
[ ] React (react-tsparticles)
[ ] Vue.js 2.x (particles.vue)
[x] Vue.js 3.x (particles.vue3)
[ ] Angular (ng-particles)
[ ] Svelte (svelte-particles)
[ ] Preact (preact-particles)
[ ] Inferno (inferno-particles)
[ ] jQuery (jquery-particles)

tsParticles Configuration
/* add your config here */

Can you give more details about how to create a Vite + Vue3 app? So I can start from that.
Have you got any error or it’s just not working?

I successfully used particles.vue3 in a Vite project.
Steps:
npm i particles.vue3
Edited main.ts with this line
import Particles from "particles.vue3"
and edited the createApp line like this:
createApp(App).use(Particles).mount('#app')
Edited shim-due.d.ts adding this line
declare module 'particles.vue3'
Now the <Particles> component is ready to be used like in the samples.
I added this to App.vue
<Particles
    id="tsparticles"
    :particlesInit="particlesInit"
    :particlesLoaded="particlesLoaded"
    :options="{
      background: {
        color: {
          value: '#0d47a1',
        },
      },
      fullScreen: {
        enable: true
      },
      fpsLimit: 60,
      interactivity: {
        detectsOn: 'canvas',
        events: {
          onClick: {
            enable: true,
            mode: 'push',
          },
          onHover: {
            enable: true,
            mode: 'repulse',
          },
          resize: true,
        },
        modes: {
          bubble: {
            distance: 400,
            duration: 2,
            opacity: 0.8,
            size: 40,
          },
          push: {
            quantity: 4,
          },
          repulse: {
            distance: 200,
            duration: 0.4,
          },
        },
      },
      particles: {
        color: {
          value: '#ffffff',
        },
        links: {
          color: '#ffffff',
          distance: 150,
          enable: true,
          opacity: 0.5,
          width: 1,
        },
        collisions: {
          enable: true,
        },
        move: {
          direction: 'none',
          enable: true,
          outMode: 'bounce',
          random: false,
          speed: 6,
          straight: false,
        },
        number: {
          density: {
            enable: true,
            value_area: 800,
          },
          value: 80,
        },
        opacity: {
          value: 0.5,
        },
        shape: {
          type: 'circle',
        },
        size: {
          random: true,
          value: 5,
        },
      },
      detectRetina: true,
    }"
  />

Thanks for the blazing fast response.  It's now working! :)


Margin styling

Hi, thank you for creating this library. It has been very helpful in my development.
This is a question, hopefully you can help:
Can we use this for other properties, like font-size, marginTop, marginBottom, marginLeft, marginRight, borderWidth and other numeric properties? How would we use the library if we can?
Also - would we need to use flex as well? And how is flex even used properly? What's the difference between flex 1 and 68 in your article?
Thanks!

Hi @mozamonkey,
thanks for communicating that the library has been very helpful for you! It's my first open source package and I'm really glad to be able to help fellow developers :smiley:
Now regarding your questions, I believe both of them are answered in the Usage section of the README, but maybe i not clearly enough or there are not enough examples ?! I would like your feedback on that.
So regarding the 1st question, I will quote the 3rd bullet of Usage/Readme:

Methods widthPercentageToDP and heightPercentageToDP can be used for any style (CSS) property that accepts DP as value ... Use the exposed methods for all of the type number properties used in your app in order to make your app fully responsive for all screen sizes.

So yes you can do that, I do it all the time for font-size and maybe margin, padding etc, if I need to. Font-size is a good example and I implement it like that: I receive the design delivered and I use percentage values (i.e. widthPercentageToDP('3%')) to achieve the same visual result. I usually do all the app's font-sizes with only one method (either the width one of the height one) and that makes it very easy to have a reference among screens and different size cases. After a while I get accustomed and it becomes easy to config a new font size. please elaborate on that.
Regarding your 2nd question I will quote the 5th bullet:

The package methods can be used with or without flex depending on what you want to do and how you choose to implement it.

When I develop a RN UI, I always use flex. It's the suggested approach from RN anyways, so I combine them. I use flex for aligning things and percentages wherever I need DP values and flex cannot work as I would like to. I.e. my containers are always flex: 1. And probably it's better to go with flex if possible - but it can't do anything. Now on how to use it properly that's kind of another topic, but I can share a couple of specific examples if you would like to.
I'm sorry but I don't understand the question about my article. where do I write about 68? Can you elaborate on that?
BTW can you share some info/screenshots over the app you are working on? I would like to have a section where I will showcase apps that use this package! Thanks

I'll address everything you've written very soon! Thanks for your detailed response!
Can I use width or height for styling like margins, fontSize, etc? From what you wrote it sounds like it doesn't matter. Why wouldn't it matter for scaling? Like if my fontSize: 30, then its scaled to either 8% if its an iPhone 6 and 4.497751% if i calculate using height dp. Does whether or not I use wp or hp matter?
I'm currently rendering the app off a iPhone 6 but when I simulate on an iPhone X the sizing is off. I'm using your library to improve sizing. For the dp values, googling them is okay right? For example the iPhone 6 is 375 (w) and 667 (h) correct?
And if I wanted to convert my entire project, I have to just do the math manually correct (or make a function, etc)?
Thank you for your time.

No worries, glad to have this conversation and improve things from my side as well if needed.
Maybe I didn't explain it properly. It does mater to use the lib instead of having raw DP, especially for scaling. And as I said, I always use it for font-size. But regarding other CSS properties, like margin, padding you may want to use "normal" percentage with a relative value to the parent element (if this is the use case). Or you may prefer to achieve your end goal with flex. And yes try to avoid the raw DP as much as possible if you want the "scale" effect over your UI across devices.
You can do the conversion with the way you propose but to get the screen's width/height i do it with RN API instead of Googling. I do it like that in the 1st screen of my app. You can console.log the values..
  const deviceScale = Dimensions.get('window').scale;
  const deviceWidth = Dimensions.get('window').width;
  const deviceHeight = Dimensions.get('window').height;

But now to convert from a specific device, we need to take into consideration the scale factor. You need to include this in your calculations. And then you have:
const scaledWidth = ${Math.round(deviceWidth) * scale}
const scaledHeight = ${Math.round(deviceHeight) * scale}

So now these are the final width/height that you need to use to calculate your percentage values. So if you have a font size of 30 DP already and you use height, then your percentage becomes 30 / scaledHeight .

Thanks! That makes lots of sense. Just for some more clarity:
const deviceScale = Dimensions.get('window').scale;
What value does deviceScale collect?
And if we're scaling fontSize: 30, does it matter whether we called the wp or hp function?

I have many properties like marginTop, marginBottom, marginLeft, padding, shadowRadius, elevation, and shadowOpacity. Could I apply hp/wp to these?
I'm quoting:

You may want to use "normal" percentage with a relative value to the parent element (if this is the use case). Or you may prefer to achieve your end goal with flex.

This means I could use your library for these properties effectively correct? Thanks for all the help.

Hey,

deviceScale is the device's scale factor. It is a number, that represents how many screen pixels the device is using to represent 1 independent pixel. You can have a more extensive read about it and links to other sources to this article of mine.

If you are scaling fontSize, it doesn't matter if you are using hp pr wp. I just stick to 1 of them (i.e. hp) for consistency and reference across the app.

I am using the lib for margin, padding properties myself as well. For shadowRadius, elevation, and shadowOpacity properties I haven't used it but all these properties accept numeric values, so you can use the lib for them as well. I would like to see a css example of yours after implementing it :smiley:

No worries, glad to help! Looking forward to your complete reply on my 1st reposnse!

Hey @mozamonkey,
I hope you found my replies helpful. I will be closing this issue if there is no objection.
Is it possible that you share some info/screenshots over the app you are working on? I would like to have a section where I will showcase apps that use this package! You can always email at<EMAIL_ADDRESS>Thanks

Closing issue, since this is answered.
@mozamonkey, I would still love to get your feedback.
Thanks,
Tasos


Dialog overlay is too light in dark mode

This isn't really a bug but something that has come up quite a bit with the global navigation rollout. Users expect the side panel overlays (which are built with Primer::Alpha::Dialog) to darken the page contents, but in dark mode, the overlay actually lightens the contents:

I think most people expect the overlay to be darker, like the one behind GitHub's command palette, for example:

I'm sure part of it is a matter of preference but I wanted to drop this issue here since we've been hearing this quite a bit both internally and from external users. If for some reason we don't want to change the overlay color, would it be possible to make the overlay color configurable on a per-dialog basis?

cc @langermank @lukasoppermann - this seems like something that can be addressed in Primitives.

We're about to start testing a new set of colors for all of Primer, and we refined the backdrop value a bit. Here's a comparison:

before
after

It still gets a little lighter, but not as drastically. Would it make sense for it to be darker in a dark theme? Generally things are opposite in light/dark (so it darkens in light mode and lightens in dark mode).
@lukasoppermann should we fix this now, or wait for it to be fixed in the test? In the legacy tokens, the component is using a non component token of color-neutral-muted so we can't change the value, we have to add a new token. Fixing it now would look like:

Adding a new token to the old build with this value
Updating the CSS for PVC to use the new-old value as a fallback for the new-new value 😅

This has been addressed behind our color feature flag, so I'm going to close it (it will hit GA someday).


tests: Refactor TestBundle and LoadTracking

Refactor TestBundle and RTATestBundle to split the test aspects from
the from_testenv aspect. This is needed for some tests that create a
collection of bundles.

Refactor the *Invariance test in load_tracking to enable test_slack
and avoid code duplication

Out of band discussion with @douglas-raillard-arm: We can get rid of the TestBundle split and have FrequencyInvarianceItems be full-fledged RTATestBundle. The class bundling them up together (one per freq) can be a regular TestBundle.

Yet another victim of the "close and comment" button that looks like the "comment" one...

I'm reviewing the code right now, but something came to mind - could you update the devlib subtree as well? That way we get the fixes to governor switching.


Align URI encoding with SPHN efforts

This seems to suggest an existing way of encoding UCUM codes are URIs
https://sphn-semantic-framework.readthedocs.io/en/latest/external_resources/ucum.html
e.g
ucum:kg a owl:NamedIndividual,
      ucum:UCUM ;
  rdfs:label "kg" ;
  rdfs:comment "kilogram" .

but it's not clear what the encoding is for derived units
cc @deepakunni3

@cmungall Yes, currently in SPHN we represent UCUM units as URIs. Ideally, we should be using URL encoding to ensure that the URIs are safe for all scenarios (but this comes at the risk of readability). While it is true that inferring the definition of a resource from its URI is not ideal, we took a naive approach to ensure some level of readability on the side of the data providers and data users.
For example, the "microgram per kilogram" unit would be represented like so:
ucum:ugperkg a owl:NamedIndividual,
        ucum:UCUM ;
    rdfs:label "ug/kg" ;
    rdfs:comment "microgram per kilogram" .

We translate commonly encountered characters, like /, [, ], {, }, (, ), with a textual alternative:

Character
Corresponding substitution

/
per

[
sbl

]
sbr

{
cbl

}
cbr

(
rbl

)
rbr

Such an approach has worked for us so far due to the limited scope of units we are working with. In the fullness of time, we would have to look at something that is more scalable and can support a wider variety of units (especially those that can be complex in its string representation).

Once UOM is completely finished SPHN could use the URLS and rdf code UOM generates if desired, however, currently we are missing a few cases such as UCUM annotations. Contributions to the project are welcome however, if anyone has scope to work on it now.

The URL has changed to https://sphn-semantic-framework.readthedocs.io/en/latest/external_terminologies/external_terminologies.html#external-terminologies-ucum


Update KES

Content
This PR includes updates the KES dependency to version 0.2.0. The breaking changes were that the library now uses a reference to a mutable slice of u8 as the secret key. This forces the library user to allocate a buffer of bytes when creating a secret key.
(we will do a version bump with a few crypto changes)
Pre-submit checklist

Branch

[x] Commit sequence broadly makes sense
[x] Key commits have useful messages

PR

[x] No clippy warnings in the CI
[x] Self-reviewed the diff
[x] Useful pull request description
[x] Reviewer requested

Ok, will bump versions. I'll bump minor versions.


Provide access to module inputs as .inputs property

Currently I have several modules where I would like to re-access the inputs and I re-output them.
Seeing as the information is already available, it would be useful to be able to access module inputs as a .inputs property on the module.

Would you mind sharing a quick code sample just to get a better idea of the use case?

I have a module storage.bicep that defines a storage account by name, and the name is computed when I reference the module. I'd like to be able to access that name in other parts of the template, without declaring a separate variable.
Instead I'm just doing:
var storageAccountName = '${namePrefix}deployment'
module storageAccountModule 'storage.bicep' = {
  name: '${namePrefix}-deploymentstorageaccountmodule'
  params: {
    accountName: storageAccountName
    allowSharedKeyAccess: true
  }
}

I'd like to instead elide the variable and simply reference storageAccountModule.inputs.accountName.
As I said in the first post, I was simply adding an output that re-output the input, but I actually think that pattern is especially bad because it evidently triggers this bug in what-if https://github.com/Azure/arm-template-whatif/issues/157

I think we would just need to make the module params read/write instead of write-only in the schema and fix up the codegen so the property access is emitted correctly. If we do end up taking this, the property would be called params to match the module body.

Might be a good one to take care of when we allow resources from a module to be exposed as an output

https://docs.microsoft.com/en-us/rest/api/resources/deployments/get#parameterslink calls it parameters not params.


🐛 Bug Report: Backstage 1.16 have a critical vulnerability for tough-cookie 2.5.0 in Cypress and @backstage/backend-common modules

📜 Description
After upgrading to Backstage 1.16 we still have a critical vulnerabiity for tough-cookie 2.5.0. When we trace it through
 yarn why tough-cookie

we see that the 2.5.0 version is being referenced in 2 places like below:
yarn why tough-cookie
yarn why v1.22.17
[1/4] Why do we have the module "tough-cookie"...?
[2/4] Initialising dependency graph...
[3/4] Finding dependency...
[4/4] Calculating file sizes...
=> Found<EMAIL_ADDRESS>info Has been hoisted to "tough-cookie"
info Reasons this module exists

"workspace-aggregator-29dc2367-ed34-4cdd-ae81-ed1b0258236e" depends on it
**- Hoisted from "project#app#cypress#@cypress#request#tough-cookie"
Hoisted from "project#backend#@backstage#backend-common#@kubernetes#client-node#request#tough-cookie"**
info Disk size without dependencies: "104KB"
info Disk size with unique dependencies: "620KB"
info Disk size with transitive dependencies: "620KB"
info Number of shared dependencies: 2
=> Found<EMAIL_ADDRESS>info This module exists because "project#@backstage#cli#jest-environment-jsdom#jsdom" depends on it.
info Disk size without dependencies: "132KB"
info Disk size with unique dependencies: "744KB"
info Disk size with transitive dependencies: "788KB"
info Number of shared dependencies: 5
=> Found<EMAIL_ADDRESS>info Reasons this module exists
"project#app#@backstage#plugin-api-docs#@asyncapi#react-component#isomorphic-dompurify#jsdom" depends on it
Hoisted from "project#app#@backstage#plugin-api-docs#@asyncapi#react-component#isomorphic-dompurify#jsdom#tough-cookie"
info Disk size without dependencies: "132KB"
info Disk size with unique dependencies: "744KB"
info Disk size with transitive dependencies: "788KB"
info Number of shared dependencies: 5
Done in 1.57s.

Cypress and @backstage/backend-common. Can some one tell us how to make these modules use the latest tough-cookie v4.1.3? Or is this something that needs an update the owners of Cypress and @backstage/backend-common modules?
👍 Expected behavior
Cypress and @backstage/backend-common should include the latest version of tough-cookie as a dependency
👎 Actual Behavior with Screenshots
Cypress and @backstage/backend-common includes the latest a vulnerable version of tough-cookie (2.5.0) as a dependency
👟 Reproduction steps
In the project, run
yarn audit

yarn why tough-cookie

📃 Provide the context for the Bug.
Tried upgrading backstage to the latest 1.16 version
🖥 Your Environment
No response
👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
Yes I am willing to submit a PR!

Hi @bbasu, in this case this is not a direct dependency of Backstage packages but of other packages used by Backstage. In this case you there are tools like Renovate, Dependabot, or Snyk that would help identify and upgrade for you.

We're bringing in a vulnerable version of tough-cookie due to @kubernetes/client-node, which in turn depends on the deprecated request package. There's a migration ongoing: https://github.com/kubernetes-client/javascript/issues/754.
The latest version of jsdom no longer depends on a vulnerable version of tough-cookie, so you'll be able to bump that version on your end.
I would imagine that there's no actual expose to the vulnerability in tough-cookie in practice, as it seems to be related only to the cookie jar, and I'd be surprised if that was used in @kubernetes/client-node. It's not something I've verified though.

Would you say this is a duplicate of https://github.com/backstage/backstage/issues/18742 ?
If yes, should we close it?
Thanks!


Craftable Tiles

About the PR
Made a lot of in-game tiles craftable in the crafting menu:
-eight steel, dark, and white tile variants
-arcade, clown and lino carpets
-shuttle tiles
-mosaic wood tile
-three techmaint tiles
-two circuit tiles
Media

[X] I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog

:cl:Alekshhh

add: Added a lot of in-game tiles into the crafting menu. Get creative!

this is absurd item bloat, the steel tiles should really be a single entity that you can switch the appearance of with the right click menu or activate key.

that's beyond me code wise sadly


Form values mock-up using prototypicla getters and setters

...that are able to maintain valid values if the form value is dependent on other form values.

We may have a slightly different question to answer at the moment - React is functional in nature. With values that are dependent on other values, where do the dependent values get their needed information? How do they keep up to date with the most recent version of the client object?

Retiring this considering new issues on the table, though parts of this may be used.


Make the url feature default

We're using this on tg right now with https://github.com/tgstation/tgstation/pull/60190, and it appears to be much faster and has not yet caused issues.
SpaceManiac has brought it up, and I've agreed for a long time, that having all these individual features was a mistake--I'd eventually like to get rid of them once they're all on by default.

Let's see if lummoxes improvement beats this


Fix apply format command

related to #137

/format

/format

/format

/format

/format

/format

@gdevillele I think we need a secret or a bot account so the workflow can push to the repo

@gdevillele I think we need a secret or a bot account so the workflow can push to the repo

We could, indeed, but I think we can do without.
With act on our machines, we absolutely need a GITHUB_TOKEN (see https://github.com/nektos/act#github_token) but in a regular GitHub action, running on Github, the token of the user doing the /format command will be provided (from my understanding).

/format


Simplify destination for CC docs

Previously, we would build the CC pages to _site/cockroachcloud
and then have Netlify move the pages to _site/docs/cockroachcloud.
Instead, we should use the latter as the destination directly in the
_config_cockroachcloud.yml.
This is important for Algolia auto-indexing.
cc @lnhsingh

Closed by https://github.com/cockroachdb/docs/pull/6515.


Jalarcon-addfields

The Security Hub Collector currently provides results with active security hub findings daily. We've been able to develop an AWS QuickSight dashboard to view the overall daily trend for the active findings count, but it could be beneficial to add two more date columns and gain insight on which security findings are brand new (perhaps build a daily trend for these as well).
Per the API docs:

{CreatedAt} Indicates when the security-findings provider created the potential security issue that a finding captured.
{UpdatedAt} Indicates when the security-findings provider last updated the finding record.

Testing:

Ran collector locally to view the new date fields successfully
Ran security_hub_collector_tect_.go with new field format expectation

Congrats on your first pull request, Jose! The code changes look good, but the PR description could use a little work. To me, good descriptions serve 2 purposes: they set the reviewer up with context and relevant info for your change, and they provide a record for anyone else who is curious (possibly another dev, or even you yourself some time in the future when you've forgotten all about the change!) about the change.
For small changes like this, it can seem a bit like overkill, but if you get in the habit of writing good descriptions it becomes very helpful for larger, more complex reviews.
Some GitHub repos have PR templates set up to prompt you for your description. This one doesn't, but here are some that I think make for a good description:

What changed:  this can be a high-level summary of the change in complete sentences. If there's a ticket for the change you can include a link.
Why:  provide any context for why the change was made.  E.g. in this case, why do we care about these fields when we didn't before?
Automated testing: it doesn't hurt to mention this, though many repos (including this one) run automated tests automatically and gate merges to master on them
Manual testing:  any testing you did outside of updating automated tests.  This is helpful for the reviewer since it provides them confidence that your change does what you expect it to do.

Thanks for the information @ben-harvey! I've added a more in-depth description for the pull request so others can understand the reasoning for this change.


Get / search records by name

Adding methods for search location/vpnCredentials/User record based on the name rather that id.

Thanks for your comments, Mitch! I will update the Pull Request shortly.

Merging into feature branch to finish for next release.


Feature 52 conda env

Pull Request Testing

[ ] Describe testing already performed for these changes:

[ ] Recommend testing for the reviewer to perform, including the location of input datasets:

[ ] Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:

[ ] After merging, should the reviewer DELETE the feature branch from GitHub? [Yes or No]

Pull Request Checklist
See the METplus Workflow for details.

[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow.
Select: Reviewer(s), Project(s), and Milestone
[ ] After submitting the PR, select Linked Issues with the original issue number.

I just saw the dependabot message about the requests package.  I'll bump it
up to the suggested 2.20 version (up from the current 2.12 version)
Regards,
Minna
Minna Win
National Center for Atmospheric Research
Developmental Testbed Center
Phone:<PHONE_NUMBER>
Fax:<PHONE_NUMBER>
Pronouns: she/her
On Thu, Oct 15, 2020 at 9:32 AM Hank Fisher<EMAIL_ADDRESS>wrote:

@fisherhucar approved this pull request.
Tested it with what I am using and it works fine.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dtcenter/METplotpy/pull/53#pullrequestreview-509509565,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA4UJHXY3SLKOTJKHKN3GPDSK4IZXANCNFSM4SRGPB6Q
.


Scala.js's sbt plugin improperly ignored jsDependencies for Runtime configuration

// jQuery dependency will be packaged for both test and compile configuration, which is good
jsDependencies += "org.webjars.bower" % "jquery" % "3.1.1" % Compile / "dist/jquery.js" minified "dist/jquery.min.js"

// jQuery dependency will be packaged for only test configuration, which is good
jsDependencies += "org.webjars.bower" % "jquery" % "3.1.1" % Test / "dist/jquery.js" minified "dist/jquery.min.js"

// jQuery dependency should be packaged for only compile configuration
// However, sbt simply ignored this setting
jsDependencies += "org.webjars.bower" % "jquery" % "3.1.1"  % Runtime / "dist/jquery.js" minified "dist/jquery.min.js"

That's intentional. There is no notion of Runtime configuration in Scala.js. The file produced by (compile:)fastOptJS is for the Compile configuration.
What would be the rationale for it to behave like that?

@sjrd Is there any approach to create jsDependencies for Compile configuration but not for Test configuration, like Runtime for JVM's libraryDependencies.

No, there isn't, because it does not make sense. Test depends on Compile, so anything that Compile depends on, Test must also transitively depend on it. This is the same for libraryDependencies.
The Runtime config of sbt does not give you a dependency only in Compile. It gives it to you specifically and only in the run task. Note that it does not emit any kind of file or product for that. It's only a manipulation of the classpath. In Scala.js, for -jsdeps.js generation, which an actual product, that does not make sense.
It's unclear to me why would you want a dependency in Compile but not in Test anyway? That sounds a bit fishy. Maybe there is a better solution.

Closing as "as-designed", unless and until someone can point me to some authoritative source that would motivate this.


Support for overriding config with agent options

Please answer these questions before submitting pull request

Why submit this pull request?

[ ] Bug fix

[x] New feature provided

[ ] Improve performance

Related issues

#1881

New feature or improvement

Describe the details and related test reports.

I wrote a unit test for parsing options, it's hard to do unit testing for the agent, so i confirm the config result through local integration test:
$ java -javaagent:./agent/skywalking-agent.jar=agent.application_code=ui,collector.backend_service=<IP_ADDRESS>:11800,logging.level=info -Xms256M -Xmx512M -jar ./webapp/skywalking-webapp.jar
DEBUG 2018-11-06 18:58:48:780 AgentPackagePath :  The beacon class location is jar:file:*/dist/apache-skywalking-apm-incubating/agent/skywalking-agent.jar!/org/apache/skywalking/apm/agent/core/boot/AgentPackagePath.class.
INFO 2018-11-06 18:58:48:781 SnifferConfigInitializer :  Config file found in */dist/apache-skywalking-apm-incubating/agent/config/agent.config.
INFO 2018-11-06 18:58:48:793 SnifferConfigInitializer :  Agent options is: agent.application_code=ui,collector.backend_service=<IP_ADDRESS>:11800,logging.level=info

We can veirfy this manually.
Consider you are from mobike, right? Could you send a pull request to add mobike into our user list? https://github.com/apache/incubator-skywalking/blob/master/docs/powered-by.md
It is goos for project and community.

Another thing, you should add this into setting override document to let people know how to use, right?

Coverage increased (+0.03%) to 12.226% when pulling 61c58da398cb67e7c673aabd2a8689065101796c on ScienJus:agent-options into 926911700eb4c891d65124e95ddf4932d12d91a3 on apache:master.

Take you time. We usually face this situation, just remind every user that, announce using in public is important to the community. We even encourage people to speech at conference about their experience. Such as dangdang.com and daocloud.
No pressure.🙃😄

Codes look good to me, just make sure CI works, and document added. Then need @ascrutae to verify this PR.

CI fails :) Please check

You are facing code style issue, now

my bad, I should build it on my local env first.


Clip and spread is broken on TFA and ARC9 weapons

Someone reported that even without modifiers, TFA weapons can spawn with an extreme number of bullets in its clip, even though the max size of the clip was unaffected. Bullet spread also doesn't work on ARC9.

Resolved via commit b32219ed26177be451add5bd0fb6e5daebfbbba2.

Apparently this is still broken for certain weapons.

Seems that Manual Weapon Pickup is causing this issue.

Resolved via commit 926f7548e87331fb45dd8a9667ec0e975040ae2a.


GroupQ should maybe be called GroupRingQ

Since Mathematica already has group objects and GroupQ returns False for these...

done


ESP32: Enable extended discovery feature.

Problem

ESP32 did not have an extended discovery feature

Change overview

Add CONFIG option to enable/disable extended discovery.

Testing

Using Chip-tool
If an extended discovery option is enabled, then the chip tool discovers the mdns service, even after commissioning is complete.

(python_env) sweety@sweety-ThinkPad-T490:~/Espressif/connectedhomeip$ ./out/chip-tool discover commissionables
[1634552950.055830][113504:113504] CHIP:CTL: Generating NOC
[1634552950.055918][113504:113504] CHIP:CTL: Generating ICAC
[1634552950.057402][113504:113504] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT START ====
[1634552950.057409][113504:113504] CHIP:DL: AUDIT: * Validate buf1 and buf2 are <<<different every run/boot!>>>
[1634552950.057411][113504:113504] CHIP:DL: AUDIT: * Validate r1 and r2 are <<<different every run/boot!>>>
[1634552950.057414][113504:113504] CHIP:DL: AUDIT: * buf1: 5C79AC9CA773EB517B703D7267BFB90A
[1634552950.057416][113504:113504] CHIP:DL: AUDIT: * buf2: E800AFBC39DF89879D94E929060F583F
[1634552950.057421][113504:113504] CHIP:DL: AUDIT: * r1: 0xE27CECCA r2: 0x957661E0
[1634552950.057422][113504:113504] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT END ====
[1634552950.057520][113504:113504] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-2kOXpP)
[1634552950.057625][113504:113504] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634552950.057633][113504:113504] CHIP:DL: NVS set: chip-counters/reboot-count = 68 (0x44)
[1634552950.057727][113504:113504] CHIP:DL: Got Ethernet interface: enp0s31f6
[1634552950.057767][113504:113504] CHIP:DL: Found the primary Ethernet interface:enp0s31f6
[1634552950.057808][113504:113504] CHIP:DL: Got WiFi interface: wlp0s20f3
[1634552950.059216][113504:113504] CHIP:DL: Found the primary WiFi interface:wlp0s20f3
[1634552950.059226][113504:113504] CHIP:IN: UDP::Init bind&listen port=5541
[1634552950.059238][113504:113504] CHIP:IN: UDP::Init bound to port=5541
[1634552950.059242][113504:113504] CHIP:IN: UDP::Init bind&listen port=5541
[1634552950.059250][113504:113504] CHIP:IN: UDP::Init bound to port=5541
[1634552950.059253][113504:113504] CHIP:IN: TransportMgr initialized
[1634552950.059262][113504:113504] CHIP:DIS: Init fabric pairing table with server storage
[1634552950.059382][113504:113504] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-oQKrQN)
[1634552950.064928][113504:113504] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634552950.064944][113504:113504] CHIP:DL: NVS set: chip-counters/GlobalMCTR = 68000 (0x109A0)
[1634552950.064970][113504:113504] CHIP:CTL: System State Initialized...
[1634552950.065103][113504:113504] CHIP:DL: MDNS failed to join multicast group on enp0s31f6 for address type IPv4: ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:426: Inet Error 0x00000110: Address not found
[1634552950.065258][113504:113504] CHIP:ZCL: Using ZAP configuration...
[1634552950.065433][113504:113504] CHIP:DIS: Verifying the received credentials
[1634552950.065844][113504:113504] CHIP:DIS: Added new fabric at index: 1, Initialized: 1
[1634552950.065849][113504:113504] CHIP:DIS: Assigned compressed fabric ID: 0xCDF427F5D65BC128, node ID: 0x000000000001B669
[1634552950.065854][113504:113504] CHIP:CTL: Joined the fabric at index 1. Compressed fabric ID is: 0xCDF427F5D65BC128
[1634552950.065962][113504:113509] CHIP:DL: CHIP task running
[1634552950.066024][113504:113509] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634552950.066067][113504:113509] CHIP:DIS: mDNS broadcast success
[1634552950.066086][113504:113509] CHIP:DIS: mDNS broadcast success
[1634552950.066099][113504:113509] CHIP:DIS: mDNS broadcast success
[1634552950.066107][113504:113509] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634552950.539027][113504:113509] CHIP:DIS: Discovered Node:
[1634552950.539079][113504:113509] CHIP:DIS: 	Host name:		240AC4C11B5C
[1634552950.539091][113504:113509] CHIP:DIS: 	Port:			5540
[1634552950.539102][113504:113509] CHIP:DIS: 	Long discriminator:	3840
[1634552950.539112][113504:113509] CHIP:DIS: 	Vendor ID:		9050
[1634552950.539122][113504:113509] CHIP:DIS: 	Product ID:		17729
[1634552950.539145][113504:113509] CHIP:DIS: 	Commissioning Mode	0
[1634552950.539158][113504:113509] CHIP:DIS: 	Device Type		0
[1634552950.539174][113504:113509] CHIP:DIS: 	Device Name
[1634552950.539186][113504:113509] CHIP:DIS: 	Rotating Id		00007C5F6E176CD40F68685D100A1CF8A98B
[1634552950.539208][113504:113509] CHIP:DIS: 	Pairing Instruction
[1634552950.539244][113504:113509] CHIP:DIS: 	Pairing Hint		0x21
[1634552950.539270][113504:113509] CHIP:DIS: 	Address 0:		fe80::260a:c4ff:fec1:1b5c
[1634552950.539294][113504:113509] CHIP:DIS: 	Address 1:		2409:4042:2d11:5839:260a:c4ff:fec1:1b5c
[1634552950.539314][113504:113509] CHIP:DIS: 	Address 2:		<IP_ADDRESS>

If extended discovery is disabled then device stops responding to mdns, after commissioning complete
(python_env) sweety@sweety-ThinkPad-T490:~/Espressif/connectedhomeip$ ./out/chip-tool discover commissionables
[1634555569.222943][124865:124865] CHIP:CTL: Generating NOC
[1634555569.223032][124865:124865] CHIP:CTL: Generating ICAC
[1634555569.224446][124865:124865] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT START ====
[1634555569.224452][124865:124865] CHIP:DL: AUDIT: * Validate buf1 and buf2 are <<<different every run/boot!>>>
[1634555569.224454][124865:124865] CHIP:DL: AUDIT: * Validate r1 and r2 are <<<different every run/boot!>>>
[1634555569.224457][124865:124865] CHIP:DL: AUDIT: * buf1: E61A4964E267D3C37B9011A769B94CC8
[1634555569.224459][124865:124865] CHIP:DL: AUDIT: * buf2: 896850578A67A7961BA1777CE6D66094
[1634555569.224464][124865:124865] CHIP:DL: AUDIT: * r1: 0xF8DDAD4C r2: 0x189B5660
[1634555569.224466][124865:124865] CHIP:DL: AUDIT: ===== RANDOM NUMBER GENERATOR AUDIT END ====
[1634555569.224564][124865:124865] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-NzECnV)
[1634555569.224682][124865:124865] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634555569.224693][124865:124865] CHIP:DL: NVS set: chip-counters/reboot-count = 75 (0x4B)
[1634555569.224816][124865:124865] CHIP:DL: Got Ethernet interface: enp0s31f6
[1634555569.224874][124865:124865] CHIP:DL: Found the primary Ethernet interface:enp0s31f6
[1634555569.224926][124865:124865] CHIP:DL: Got WiFi interface: wlp0s20f3
[1634555569.226191][124865:124865] CHIP:DL: Found the primary WiFi interface:wlp0s20f3
[1634555569.226205][124865:124865] CHIP:IN: UDP::Init bind&listen port=5541
[1634555569.226219][124865:124865] CHIP:IN: UDP::Init bound to port=5541
[1634555569.226223][124865:124865] CHIP:IN: UDP::Init bind&listen port=5541
[1634555569.226232][124865:124865] CHIP:IN: UDP::Init bound to port=5541
[1634555569.226236][124865:124865] CHIP:IN: TransportMgr initialized
[1634555569.226248][124865:124865] CHIP:DIS: Init fabric pairing table with server storage
[1634555569.226420][124865:124865] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-VUn3ET)
[1634555569.232007][124865:124865] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634555569.232043][124865:124865] CHIP:DL: NVS set: chip-counters/GlobalMCTR = 75000 (0x124F8)
[1634555569.232092][124865:124865] CHIP:CTL: System State Initialized...
[1634555569.232274][124865:124865] CHIP:DL: MDNS failed to join multicast group on enp0s31f6 for address type IPv4: ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:426: Inet Error 0x00000110: Address not found
[1634555569.232434][124865:124865] CHIP:ZCL: Using ZAP configuration...
[1634555569.232628][124865:124865] CHIP:DIS: Verifying the received credentials
[1634555569.233056][124865:124865] CHIP:DIS: Added new fabric at index: 1, Initialized: 1
[1634555569.233061][124865:124865] CHIP:DIS: Assigned compressed fabric ID: 0xCDF427F5D65BC128, node ID: 0x000000000001B669
[1634555569.233064][124865:124865] CHIP:CTL: Joined the fabric at index 1. Compressed fabric ID is: 0xCDF427F5D65BC128
[1634555569.233197][124865:124870] CHIP:DL: CHIP task running
[1634555569.233273][124865:124870] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634555569.233353][124865:124870] CHIP:DIS: mDNS broadcast success
[1634555569.233390][124865:124870] CHIP:DIS: mDNS broadcast success
[1634555569.233411][124865:124870] CHIP:DIS: mDNS broadcast success
[1634555569.233420][124865:124870] CHIP:DIS: Attempt to mDNS broadcast failed:  ../examples/chip-tool/third_party/connectedhomeip/src/inet/IPEndPointBasis.cpp:741: OS Error 0x02000065: Network is unreachable
[1634555599.233443][124865:124865] CHIP:-: ../examples/chip-tool/commands/common/CHIPCommand.cpp:121: CHIP Error 0x00000032: Timeout at ../examples/chip-tool/commands/common/CHIPCommand.cpp:80
[1634555599.233497][124865:124865] CHIP:TOO: Run command failure: ../examples/chip-tool/commands/common/CHIPCommand.cpp:121: CHIP Error 0x00000032: Timeout
[1634555599.288401][124865:124865] CHIP:CTL: Shutting down the System State, this will teardown the CHIP Stack
[1634555599.288523][124865:124865] CHIP:DL: writing settings to file (/tmp/chip_counters.ini-Juo7CU)
[1634555599.288722][124865:124865] CHIP:DL: renamed tmp file to file (/tmp/chip_counters.ini)
[1634555599.288738][124865:124865] CHIP:DL: NVS set: chip-counters/total-operational-hours = 0 (0x0)
[1634555599.288743][124865:124865] CHIP:DL: Inet Layer shutdown
[1634555599.288817][124865:124865] CHIP:DL: BLE layer shutdown
[1634555599.288822][124865:124865] CHIP:DL: System Layer shutdown

@sweetymhaiske Please add the output of the commands you have tested

Added

@sweetymhaiske Can you please rebase and check if the CI Darwin test passes

I rebased it. But it is still failing.

@woody-apple Can we merge this?


Docs broken on Firefox

Just an FYI, and not sure whether it's only on my system, but Firefox doesn't finish loading the documentation pages. Anytime it runs into the

I've posted a question about this on Stack Overflow, because I honestly have no idea what's going wrong at this point.

Nevermind, turns out it was because I marked the script as async when there wasn't an src. See: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/script#attr-defer


Query are sending INSERT request with back_propagate

I am not sure this is a bug or not, but it seems strange that launching a query would send an INSERT request.
Here is a repository to replicate the bug. https://github.com/Noezor/example_flask_sqlalchemy_bug/
Expected Behavior
For the models :
from config import db

class Parent(db.Model):
    __tablename__ = "parent"

    id = db.Column(db.Integer(), primary_key  = True)
    name = db.Column(db.String, unique = True)

    children = db.relationship("Child", back_populates="parent")

class Child(db.Model):
    __tablename__ = "child"

    id = db.Column(db.Integer(), primary_key = True)

    name = db.Column(db.String(32), unique = True)

    parent_id = db.Column(db.Integer, db.ForeignKey("parent.id"))
    parent = db.relationship("Parent", back_populates="children")

And now the testscript.
from config import db
from model import Child, Parent

parent = Parent(name='John')
if not Parent.query.filter(Parent.name == parent.name).one_or_none():
    db.session.add(parent)
    db.session.commit()
else :
    parent = Parent.query.filter(Parent.name == parent.name).one_or_none()

child1 = Child(name="Toto",parent = parent)

if not Child.query.filter(Child.name == "Toto").one_or_none() :
    db.session.add(child1)
    db.session.commit()
else :
    child1 = Child.query.filter(Child.name == "Toto").one_or_none()

print("success")

At first launch, the problem should work fine. At second launch, once the database is populated, there should not be problem either as the query will detect that the database already contains added elements.
Actual Behavior
At first launch, everything is working fine. On the other hand, at second launch, it seems that line "if not Child.query.filter(Child.name == "Toto").one_or_none() :" is sending an INSERT request.
2020-02-01 15:23:28,552 INFO sqlalchemy.engine.base.Engine SELECT CAST('test plain returns' AS VARCHAR(60)) AS anon_1
2020-02-01 15:23:28,552 INFO sqlalchemy.engine.base.Engine ()
2020-02-01 15:23:28,553 INFO sqlalchemy.engine.base.Engine SELECT CAST('test unicode returns' AS VARCHAR(60)) AS anon_1
2020-02-01 15:23:28,554 INFO sqlalchemy.engine.base.Engine ()
2020-02-01 15:23:28,555 INFO sqlalchemy.engine.base.Engine BEGIN (implicit)
2020-02-01 15:23:28,556 INFO sqlalchemy.engine.base.Engine SELECT parent.id AS parent_id, parent.name AS parent_name
FROM parent
WHERE parent.name = ?
2020-02-01 15:23:28,557 INFO sqlalchemy.engine.base.Engine ('John',)
2020-02-01 15:23:28,560 INFO sqlalchemy.engine.base.Engine SELECT parent.id AS parent_id, parent.name AS parent_name
FROM parent
WHERE parent.name = ?
2020-02-01 15:23:28,560 INFO sqlalchemy.engine.base.Engine ('John',)
**2020-02-01 15:23:28,567 INFO sqlalchemy.engine.base.Engine INSERT INTO child (name, parent_id) VALUES (?, ?)**
2020-02-01 15:23:28,568 INFO sqlalchemy.engine.base.Engine ('Toto', 1)
2020-02-01 15:23:28,569 INFO sqlalchemy.engine.base.Engine ROLLBACK
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1182, in _execute_context
    context)
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/default.py", line 470, in do_execute
    cursor.execute(statement, parameters)
sqlite3.IntegrityError: UNIQUE constraint failed: child.name

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/home/pionn/.vscode-insiders/extensions/ms-python.python-2020.1.58038/pythonFiles/ptvsd_launcher.py", line 43, in <module>
    main(ptvsdArgs)
  File "/home/pionn/.vscode-insiders/extensions/ms-python.python-2020.1.58038/pythonFiles/lib/python/old_ptvsd/ptvsd/__main__.py", line 432, in main
    run()
  File "/home/pionn/.vscode-insiders/extensions/ms-python.python-2020.1.58038/pythonFiles/lib/python/old_ptvsd/ptvsd/__main__.py", line 316, in run_file
    runpy.run_path(target, run_name='__main__')
  File "/usr/lib/python3.6/runpy.py", line 263, in run_path
    pkg_name=pkg_name, script_name=fname)
  File "/usr/lib/python3.6/runpy.py", line 96, in _run_module_code
    mod_name, mod_spec, pkg_name, script_name)
  File "/usr/lib/python3.6/runpy.py", line 85, in _run_code
    exec(code, run_globals)
  **File "/home/pionn/minimum_bug_sqlalchemy/test.py", line 13, in <module>
    if not Child.query.filter(Child.name == "Toto").one_or_none() :**
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/query.py", line 2784, in one_or_none
    ret = list(self)
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/query.py", line 2854, in __iter__
    self.session._autoflush()
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/session.py", line 1407, in _autoflush
    util.raise_from_cause(e)
  File "/usr/lib/python3/dist-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/lib/python3/dist-packages/sqlalchemy/util/compat.py", line 187, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/session.py", line 1397, in _autoflush
    self.flush()
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/session.py", line 2171, in flush
    self._flush(objects)
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/session.py", line 2291, in _flush
    transaction.rollback(_capture_exception=True)
  File "/usr/lib/python3/dist-packages/sqlalchemy/util/langhelpers.py", line 66, in __exit__
    compat.reraise(exc_type, exc_value, exc_tb)
  File "/usr/lib/python3/dist-packages/sqlalchemy/util/compat.py", line 187, in reraise
    raise value
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/session.py", line 2255, in _flush
    flush_context.execute()
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/unitofwork.py", line 389, in execute
    rec.execute(self)
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/unitofwork.py", line 548, in execute
    uow
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/persistence.py", line 181, in save_obj
    mapper, table, insert)
  File "/usr/lib/python3/dist-packages/sqlalchemy/orm/persistence.py", line 835, in _emit_insert_statements
    execute(statement, params)
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 945, in execute
    return meth(self, multiparams, params)
  File "/usr/lib/python3/dist-packages/sqlalchemy/sql/elements.py", line 263, in _execute_on_connection
    return connection._execute_clauseelement(self, multiparams, params)
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1053, in _execute_clauseelement
    compiled_sql, distilled_params
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1189, in _execute_context
    context)
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1402, in _handle_dbapi_exception
    exc_info
  File "/usr/lib/python3/dist-packages/sqlalchemy/util/compat.py", line 203, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "/usr/lib/python3/dist-packages/sqlalchemy/util/compat.py", line 186, in reraise
    raise value.with_traceback(tb)
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/base.py", line 1182, in _execute_context
    context)
  File "/usr/lib/python3/dist-packages/sqlalchemy/engine/default.py", line 470, in do_execute
    cursor.execute(statement, parameters)
sqlalchemy.exc.IntegrityError: (raised as a result of Query-invoked autoflush; consider using a session.no_autoflush block if this flush is occurring prematurely) (sqlite3.IntegrityError) UNIQUE constraint failed: child.name [SQL: 'INSERT INTO child (name, parent_id) VALUES (?, ?)'] [parameters: ('Toto', 1)]

I believe it happends through back_propagate as, if removed, the "bug" dissapears. Same if I don't specify a parent for the child.
Environment

Operating system: Ubuntu 18.14
Python version: 3.6.3
Flask-SQLAlchemy version: 2.4.1
SQLAlchemy version: 1.3.12

This appears to be an issue with SQLAlchemy, not Flask-SQLAlchemy.


fix fix group_commit error in logstash

Proposed changes
Do not set label when group_commit is set in headers.

run buildall


Operator catalog is created but now shown in the OLM UI

Steps to recreate:
Start up an OS4 cluster
Create a CatalogSource:
cat devconsole.operatorsource.catalog.yamlapiVersion: operators.coreos.com/v1
kind: CatalogSourceConfig
metadata:
  name: devconsole-operator-catalog
  namespace: openshift-operators
spec:
  targetNamespace: local-operators
  packages: devconsole-operator
  displayName: Red Hat Devconsole Operator
  publisher: Red Hat

Apply the CatalogSource:
kubectl apply -f devconsole.operatorsource.catalog.yamlcatalogsourceconfig "devconsole-operator-catalog" configured

Verify the CatalogSource in the CLI:
kubectl get CatalogSourceConfig devconsole-operator-catalog -n openshift-operators -o=yaml
apiVersion: operators.coreos.com/v1
kind: CatalogSourceConfig
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operators.coreos.com/v1","kind":"CatalogSourceConfig","metadata":{"annotations":{},"name":"devconsole-operator-catalog","namespace":"openshift-operators"},"spec":{"displayName":"Red Hat Devconsole Operator","packages":"devconsole-operator","publisher":"Red Hat","targetNamespace":"local-operators"}}
  creationTimestamp: 2019-04-25T17:19:11Z
  generation: 1
  name: devconsole-operator-catalog
  namespace: openshift-operators
  resourceVersion: "41007"
  selfLink: /apis/operators.coreos.com/v1/namespaces/openshift-operators/catalogsourceconfigs/devconsole-operator-catalog
  uid: 3e1a55ff-677e-11e9-8124-06472ef5fc02
spec:
  displayName: Red Hat Devconsole Operator
  packages: devconsole-operator
  publisher: Red Hat
  targetNamespace: local-operators

But - the CatalogSource is not displayed in the UI:

kubectl apply -f devconsole.operatorsource.catalog.yaml
The odd thing is that the catalog seems to be created - but it is not showing up in the UI:
kubectl get CatalogSourceConfig devconsole-operator-catalog -n openshift-operators -o=yaml
apiVersion: operators.coreos.com/v1
kind: CatalogSourceConfig
metadata:
  annotations:
    kubectl.kubernetes.io/last-applied-configuration: |
      {"apiVersion":"operators.coreos.com/v1","kind":"CatalogSourceConfig","metadata":{"annotations":{},"name":"devconsole-operator-catalog","namespace":"openshift-operators"},"spec":{"csDisplayName":"Red Hat Devconsole Operator","csPublisher":"Red Hat","packages":"devconsole-operator","targetNamespace":"local-operators"}}
  creationTimestamp: 2019-04-24T17:46:04Z
  generation: 1
  name: devconsole-operator-catalog
  namespace: openshift-operators
  resourceVersion: "60420"
  selfLink: /apis/operators.coreos.com/v1/namespaces/openshift-operators/catalogsourceconfigs/devconsole-operator-catalog
  uid: d4d2d887-66b8-11e9-a787-0a44d6fe60be
spec:
  csDisplayName: Red Hat Devconsole Operator
  csPublisher: Red Hat
  packages: devconsole-operator
  targetNamespace: local-operators

The error shown above seems to be intermittent - I am seeing it about 25% of the time after creating a new cluster - even if no catalogsources are installed.
When this error is not seen, installing any catalog source (e.g., https://github.com/redhat-developer/devconsole-operator/blob/master/test/e2e/catalog_source_OS4.yaml) also fails to be shown in the UI.

@ldimaggi According to https://github.com/operator-framework/operator-marketplace#catalogsourceconfig CatalogSource instance is supposed to be created behind the scenes from the CataloSourceConfig.
I cannot see that happen, see the following sequence:
(operator-test-env)➜  oc project openshift-operators
Already on project "openshift-operators" on server "https://api.pmacik.devcluster.openshift.com:6443".

Verify that no CatalogSoruce is not present:
(operator-test-env)➜  oc get catsrc
No resources found.

Verify that no CatalogSourceConfig is  not present:
(operator-test-env)➜  oc get csc
No resources found.

Create a CatalogSourceConfig:
(operator-test-env)➜  cat devconsole.operatorsource.catalog.yaml

apiVersion: operators.coreos.com/v1
kind: CatalogSourceConfig
metadata:
  name: devconsole-operator-catalog
  namespace: openshift-operators
spec:
  targetNamespace: local-operators
  packages: devconsole-operator
  displayName: "Red Hat Devconsole Operator"
  publisher: "Red Hat"

(operator-test-env)➜  oc apply -f devconsole.operatorsource.catalog.yaml
catalogsourceconfig.operators.coreos.com/devconsole-operator-catalog created

Verify that the CatalogSourceConfig is present:
(operator-test-env)➜  oc get csc -o=yaml

apiVersion: v1
items:
- apiVersion: operators.coreos.com/v1
  kind: CatalogSourceConfig
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"operators.coreos.com/v1","kind":"CatalogSourceConfig","metadata":{"annotations":{},"name":"devconsole-operator-catalog","namespace":"openshift-operators"},"spec":{"displayName":"Red Hat Devconsole Operator","packages":"devconsole-operator","publisher":"Red Hat","targetNamespace":"local-operators"}}
    creationTimestamp: "2019-04-26T06:49:37Z"
    generation: 1
    name: devconsole-operator-catalog
    namespace: openshift-operators
    resourceVersion: "423576"
    selfLink: /apis/operators.coreos.com/v1/namespaces/openshift-operators/catalogsourceconfigs/devconsole-operator-catalog
    uid: 75150c85-67ef-11e9-8c03-0a9fcb887e7c
  spec:
    displayName: Red Hat Devconsole Operator
    packages: devconsole-operator
    publisher: Red Hat
    targetNamespace: local-operators
kind: List
metadata:
  resourceVersion: ""
  selfLink: ""

Check for the CatalogSoucre:
(operator-test-env)➜  oc get catsrc
No resources found.

As you can the CatalogSource instance (that is supposed to be created from the CatalogSourceConfig) is not created.

I just realized, that the CatalogSourceConfig should probably be placed in the operatoror-marketplace namespace:
(operator-test-env)➜   oc get csc --all-namespaces
NAMESPACE               NAME                  STATUS      MESSAGE                                       AGE
openshift-marketplace   certified-operators   Succeeded   The object has been successfully reconciled   29h
openshift-marketplace   community-operators   Succeeded   The object has been successfully reconciled   29h
openshift-marketplace   redhat-operators      Succeeded   The object has been successfully reconciled   29h

(operator-test-env)➜   oc get catsrc --all-namespaces
NAMESPACE                              NAME                  NAME                  TYPE       PUBLISHER   AGE
openshift-marketplace                  certified-operators   Certified Operators   grpc       Red Hat     29h
openshift-marketplace                  community-operators   Community Operators   grpc       Red Hat     29h
openshift-marketplace                  redhat-operators      Red Hat Operators     grpc       Red Hat     29h
openshift-operator-lifecycle-manager   olm-operators         OLM Operators         internal   Red Hat     30h

(operator-test-env)➜   oc get opsrc --all-namespaces
NAMESPACE               NAME                  TYPE          ENDPOINT              REGISTRY              DISPLAYNAME           PUBLISHER   STATUS      MESSAGE                                       AGE
openshift-marketplace   certified-operators   appregistry   https://quay.io/cnr   certified-operators   Certified Operators   Red Hat     Succeeded   The object has been successfully reconciled   30h
openshift-marketplace   community-operators   appregistry   https://quay.io/cnr   community-operators   Community Operators   Red Hat     Succeeded   The object has been successfully reconciled   30h
openshift-marketplace   redhat-operators      appregistry   https://quay.io/cnr   redhat-operators      Red Hat Operators     Red Hat     Succeeded   The object has been successfully reconciled   30h

https://github.com/redhat-developer/devconsole-operator/pull/135#issuecomment-487046991 is related

Closing as not a bug - the approach followed was not correct.


Rock, paper, scissors game

2 player support

Should be completed with 0694bcf9547cdaf3f4bd98654e30db24704f41c6 but just to make sure it needs to be tested

Should be completed with 0694bcf9547cdaf3f4bd98654e30db24704f41c6 but just to make sure it needs to be tested


fix(module:input-number): fix style with prefix and suffix (#5690)

PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5690
What is the new behavior?
Does this PR introduce a breaking change?
[ ] Yes
[x] No

Other information

Could you help review this pull request? @vthinkxie


Most errors highlight the wrong line, not the line with the error.

Forget to type a ":" and look at the error message:
error(14,0): ':' expected at end of line.
Except that it is not expected at the end of line 14, it is expected at the end of line 13. This error needs to highlight the previous line then it currently does. I am teaching others how to use goDotEngine and the highlighted line having nothing to do with the error is a constant source of frustration.

not neccesarily, i fyou forget : at the end of say, an if (), the parser
will assume the expression continues on the next line (similar to python),
so in practice it is expected in the next line
On Mon, Jan 12, 2015 at 4:43 PM, RefinedSoftwareLLC <
<EMAIL_ADDRESS>wrote:

Forget to type a ":" and look at the error message:
error(14,0): ':' expected at end of line.
Except that it is not expected at the end of line 14, it is expected at
the end of line 13. This error needs to highlight the previous line then it
currently does. I am teaching others how to use goDotEngine and the
highlighted line having nothing to do with the error is a constant source
of frustration.
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1197.

Then highlight them both!

makes sense, since one is able to tell an expression started in one line
and ended on other.
or actually i think for the specific error of missing : , it makes sense
that it shows the first line, you are right
On Mon, Jan 12, 2015 at 4:48 PM, RefinedSoftwareLLC <
<EMAIL_ADDRESS>wrote:

Then highlight them both!
—
Reply to this email directly or view it on GitHub
https://github.com/okamstudio/godot/issues/1197#issuecomment-69632988.

Multi-line conditions have to be wrapped between "(" and ")" right? so if there is no "(" then it should not assume the next line has anything to do with it.

The error message should probably also say that multi-line if/thens must be wrapped in "()" for those not knowing why it isn't working.

100 if true == false
101 >>    and true == false:
currently this shows:
error(101:0): ':' expected at end of line.
But it should show this instead:
error(100:0): ':' expected at end of line 100 or multi-line Boolean expression should be wrapped in "()"

I confirm the issue and it's true that it can be misleading, especially since adding ":" on the designated line does not solve the issue, nor trigger another one, e.g. this code will still produce the same error:
101     print("oops")::::::::

error(101:0): ':' expected at end of line.

Fixed by #2955.


Upgrade to React 18

PLIP (Plone Improvement Proposal)
Responsible Persons
Proposer: Víctor Fernández de Alba (@sneridagh)
Seconder:
Abstract
Upgrade the codebase to use React 18. Some PoCs were done back in the day, but they should be updated and reviewed.
Motivation
React 18 is out there since almost two years and it's time to upgrade. The move should not be painful and use only the most basic things compatible with 17 mode.
Assumptions
No preconditions.
Proposal & Implementation
PoCs:

[ ] https://github.com/plone/volto/pull/3221
[ ] https://github.com/plone/volto/pull/3370

Deliverables
Updated codebase with React 18.
Comprehensive upgrade guide (if needed).
Risks
No risks.
Participants

Can I work on this?

@ganpatsundesha please read and follow Contributing to Plone and First-time contributors, especially Things not to do.

Done in #3221


Analyzer has no compatible package:test version while developing 0.30.0.

Because analyzer and test are interdependent, there is no good way of writing a pubspec for 0.30.0-dev...
because no test version accepts 0.30.0 of the analyzer.
Disabling pkgbuild/pkg/analyzer until 0.30.0 lands and a compatible test version is released and in DEPS.
Please remove this status change, and close issue, then.
@bwilkerson @stereotype441 @keertip @munificent

@nex3

Can you use dependency_overrides?

I tried using dependency_overrides (for test, in analyzer's pubspec), but it didn't seem to work.  It should be the correct solution - could you try and make it work?  Maybe I just didn't know how.

When I add
dependency_overrides:
  test: "^0.12.0"

to pkg/analyzer/pubspec.yaml and run pub get, it completes successfully. If it's not working on the package bots, I think that's probably an infrastructure issue.

This one is happily behind us.  Closing as stale.


Keyword extraction -- fetch author titles from dblp

Fetch titles of papers from an author dblp page by using the author profile page link

merged into issue #14


vid: remove pixel formats RGB555 and RGB565

proposal to remove pixel formats with low bit depth

I was using VID_FMT_RGB565 in my Android app.  With what format should I replace it?

I tried with VID_FMT_RGB32 and VID_FMT_YUV444P.  With VID_FMT_RGB32 there was colorful garbage on the screen and with VID_FMT_YUV444P screen stayed black.  Please bring the removed format back unless a working alternative is found.
The code where I use the format goes like this:
int opengles_display(struct vidisp_st *st, const char *title, const struct vidframe *frame, uint64_t timestamp)
{
    (void)title;
    (void)timestamp;
    int err;

    /* This is hack to make sure that context is initialised on the same thread */
    if (!st->context) {
        err = context_initialize(st);
        if (err) {
            LOGW("Renderer context init failed with error %d\n", err);
            return err;
        }
    }

    if (!st->vf) {
        if (frame->size.w & 3) {
            LOGW("opengles_display: frame width must be multiple of 4\n");
            return EINVAL;
        }

        err = vidframe_alloc(&st->vf, VID_FMT_RGB565, &frame->size);
        if (err) {
            LOGW("opengles_display: vidframe_alloc failed\n");
            return err;
        }
    }

    vidconv(st->vf, frame, NULL);

    opengles_render(st);

    err = eglSwapBuffers(st->display, st->surface);
    if (!err)
        LOGW("eglSwapBuffers() returned error %s\n", egl_error(eglGetError()));

    return err;
}

Tried all formats bpp >= 16 and all of them failed to work.

With VID_FMT_YUV444P I get errors:
03-12 11:38:58.176  3737  3805 D Baresip+ Lib: vidconv: no pixel converter found for yuv420p -> yuv444p

And with VID_FMT_YUV420P I see the screen split into 4 colorful garbage windows.

Looks like these are the only supported formats on android:
https://developer.android.com/reference/android/graphics/Bitmap.Config
If I interpret the documention correctly the prefered one is:
https://developer.android.com/reference/android/graphics/Bitmap.Config#ARGB_8888
https://developer.android.com/reference/android/graphics/Bitmap.Config#RGB_565
Says This configuration can produce slight visual artifacts depending on the configuration of the source

Can you try VID_FMT_ARGB?

With VID_FMT_ARGB I get black screen and lots of these to log:
03-12 13:22:02.818  6879  6975 D Baresip+ Lib: vidconv: no pixel converter found for yuv420p -> argb
03-12 13:22:02.854  6879  6975 D Baresip+ Lib: vidconv: no pixel converter found for yuv420p -> argb
03-12 13:22:02.869  6879  6975 D Baresip+ Lib: vidconv: no pixel converter found for yuv420p -> argb

Am I missing some module that does the conversion?

I see, we have no conversion function:
https://github.com/baresip/rem/blob/main/src/vidconv/vconv.c#L644-L661

So best would be to add support for ARGB_8888 or (if it takes long or cannot be done at all) restore support for VID_FMT_RGB565.

There has been reports on the net that ARGB_8888 performance can be very bad.  So better to stick to VID_FMT_RGB565.


[add] Cesar Chavez Day is optional holiday in Colorado

Proposed change

Add Cesar Chavez Day as optional holiday on March 31 in Colorado (same as in Texas), starting in 2001

Source:

https://denverite.com/2023/12/04/how-cesar-chavez-park-tennyson-street-denver-got-its-name/
https://www.westword.com/news/denver-traded-for-cesar-chavez-day-but-colorado-legislature-still-honors-columbus-11282490
https://www.9news.com/article/news/local/city-offices-closed-for-cesar-chavez-day/73-344931490

Type of change

[x] New country/market holidays support (thank you!)
[ ] Supported country/market holidays update (calendar discrepancy fix, localization)
[ ] Existing code/documentation/test/process quality improvement (best practice, cleanup, refactoring, optimization)
[ ] Dependency update (version deprecation/upgrade)
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] Breaking change (a code change causing existing functionality to break)
[ ] New feature (new python-holidays functionality in general)

Checklist

[x] I've followed the contributing guidelines
[x] I've run make pre-commit, it didn't generate any changes
[x] I've run make test, all tests passed locally

 Quality Gate failed
Failed conditions
B Maintainability Rating on New Code (required ≥ A)
See analysis details on SonarCloud
 Catch issues before they fail your Quality Gate with our IDE extension  SonarLint

^ I'm not in any position to follow that code smell suggestion and make a constant for the holiday. Seems there's multiple places in the same file where the same raw string is used multiple times (e.g. "Lincoln's Birthday"), so clearly this isn't an actual "problem". Hopefully the CI failure doesn't prevent this from being reviewed and adopted.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
10221

Relevant Lines:
10221

💛  - Coveralls

^ I'm not in any position to follow that code smell suggestion and make a constant for the holiday. Seems there's multiple places in the same file where the same raw string is used multiple times (e.g. "Lincoln's Birthday"), so clearly this isn't an actual "problem". Hopefully the CI failure doesn't prevent this from being reviewed and adopted.

Yeah - ignore that one for now; the actual  test_cesar_chavez_day(self) in \tests\countries\test_united_states.py could definitely use some update though :)
    def test_cesar_chavez_day(self):
        name = "Cesar Chavez Day"
        self.assertNoHolidayName(name)
        self.assertHolidayName(
            name, self.state_hols["CA"], (f"{year}-03-31" for year in range(1995, 2050))
        )
        self.assertNoHolidayName(name, self.state_hols["CA"], range(1865, 1995))
        obs_dt = (
            "1996-04-01",
            "2002-04-01",
            "2013-04-01",
            "2019-04-01",
        )
        self.assertHolidayName(f"{name} (Observed)", self.state_hols["CA"], obs_dt)
        self.assertNoNonObservedHolidayName(
            f"{name} (Observed)", UnitedStates(subdiv="CA", observed=False), obs_dt
        )
        self.assertHolidayName(
            name, self.state_hols["CO"], (f"{year}-03-31" for year in range(2001, 2050))
        )
        self.assertNoHolidayName(name, self.state_hols["CO"], range(1865, 2001))
        self.assertHolidayName(
            name, self.state_hols["TX"], (f"{year}-03-31" for year in range(2000, 2050))
        )
        self.assertNoHolidayName(name, self.state_hols["TX"], range(1865, 2000))


Remote RELOAD is sometimes sent multiple times

This is caused by storing which servers we've checked rather than to which locations we've sent. But we have to do that because JELP RELOAD uses SIDs rather than server masks. I think I need to send out a single RELOAD with a server mask or maybe with a list of SIDs. And of course, only send it to the matching server(s).

See #36. Once I switch this over to use ->fire_command(), I can make it so multiple parameters are allowed, one for each SID. And it will be sent only to the locations with paths to one or more of the destination servers.

Actually I had a neat idea that might be better. Currently these global commands use a $SID format, which ->lookup_server_mask() recognizes. This method, when passed wildcards, is capable of returning multiple values. So perhaps it would be neat if the $SID syntax worked to match multiple servers. For example `$pool->lookup_server_mask('$0$1') would yield the servers by SID 0 and SID 1 in list context and the server with SID 0 in scalar context.


mssql分页临时解决

gdb_mssql.go 129行的
sql = fmt.Sprintf("SELECT * FROM "+"(SELECT ROW_NUMBER() OVER (ORDER BY %s) as ROWNUMBER_, %s ) as TMP_ "+"WHERE TMP_.ROWNUMBER_ > %d AND TMP_.ROWNUMBER_ <= %d",orderStr, selectStr, first, limit,)

替换成
orderBy:=strings.Split(strings.Trim(orderbyStr," ")," ")
if len(orderBy)>1{
	sql = fmt.Sprintf("SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY QUOTENAME(%s) %s) as ROWNUMBER_, %s   ) as TMP_ WHERE TMP_.ROWNUMBER_ > %d AND TMP_.ROWNUMBER_ <= %d", orderBy[0],orderBy[1], selectStr, first, first+limit)
}else{
	sql = fmt.Sprintf("SELECT * FROM (SELECT ROW_NUMBER() OVER (ORDER BY QUOTENAME(%s)) as ROWNUMBER_, %s   ) as TMP_ WHERE TMP_.ROWNUMBER_ > %d AND TMP_.ROWNUMBER_ <= %d", orderbyStr, selectStr, first, first+limit)
}

这样就能用limit和ForPage不过需要配合OrderBy方法
//1页20条
g.DB().Table(...).ForPage(1, 20).OrderBy("id desc").Structs(...)

@wenzi1 蚊子有时间看看么？

#575


Create a test to certify a clean install

Originally posted by @eulertour in https://github.com/ManimCommunity/manim/issues/9#issuecomment-631002056

Basically something to dry-run a Scene, ensure that the bare minimum to render successfully is actually installed, and give a helpful error like LaTeX/FFmpeg isn't installed, media directory isn't writable, etc.

Having done this, the correct way to install manim would be pip install manim, and then pytest test_install.py. (Or the equivalent in the testing library that we end up using.)
This would flag issues about system dependencies such as latex, ffmpeg, etc.

Could probably be automated with travis or something as well

As @leotrs  pointed out,  we will have to be aware in the tests that Latex is optional. See #11

Closed since #28 #97 are on this (and more up-to-date)

@huguesdevimeux While this can be done with what we currently have, I don't think this has been implemented. To clarify, I meant a "test to certify a clean install" that a user could run after installation, and it would be part of the installation instructions. So the installation instructions would have this as the last instruction: "Finally, run some_command on your terminal. If it finishes without error, then your install of manim is complete. If it shows an error, then please refer to the FAQ/Troubleshooting section".
So I guess all that's missing in order to get that is documentation.

@leotrs Oh ok I see, this is a good idea.
But is your idea to do it with pytest ? If yes I think this will be implemented soon.
If not,  I think that just telling the user to run SquareToCircle might be enough.
But you're totally right, at least a mention of a such command (potentially with SquareToCircle, I don't know) is missing in the Readme.

I have to agree with @leotrs that this isn't finished yet, and it would ideally be something done through pytest. It'd be much better to have a command which gives clear error messages and covers as many potential pitfalls as it can than to run SquareToCircle. As an example, the latter wouldn't test latex.

Will a batch/shell script do? Or it should be done with purest?

@naveen521kk all tests should be done via pytest, as much as possible.

@naveen521kk all tests should be done via pytest, as much as possible.

Hmm are you sure about that ? I mean, this test is meant to be run by a standard user, not a contributor.
I think a shell script is better as there is much more trouble to set up.
What do you think ?

So in the PR I just requested (#324), there are instructions embedded in the installation instructions to certify the installation is clean. For example, after installing latex, it instructs the reader to try it out by executing latex on the console. Would this be a poor man's fix for this issue?

Why can't we ask them to use pytest, like you suggested?
Heck, we could have a script in /scripts/ install pytest for them, run the tests, make sure they're fine, and uninstall pytest on the way out.

I mean, we can :man_shrugging:

I think this issue went off the rails a little bit. The original idea is to provide a way for end users to test whether or not their installation is clean. They usually don't have pytest installed. I think having a script that ships with the library, or even a subcommand manim certify-install is the way to go.
OTOH, the documentation already includes instructions on how to certify the installation of each dependency. I think it's safe to close this issue for now. @Aathish04 ?

I think the current documentation does a good job at guiding the user through the whole installation process.
I think this issue has ran its course.


Tidy

clean up a couple of things

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
71

Relevant Lines:
71

💛  - Coveralls

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

2 of 2 (100.0%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
71

Relevant Lines:
71

💛  - Coveralls


Collapsable top table in job view

highlighted blue here.
It would be helpful if the top div was resizable to maximize usable screen space.

@aswarren These divs are position absolute, so whoever works on it will need to edit the workspace widget to add a toggle, and the main div needs to be set as height 800px, top 0px
to toggle it back it would be
height: 544px
top: 238px
this is the div where the report gets placed
class="dijitContentPane FileViewer-child FileViewer-dijitContentPane FileViewerPane dijitAlignCenter"
id="dijit_layout_ContentPane_6"

#2156 described the same issue. Closing this one.