Fix production bug

Codecov Report

Merging #196 (0f48581) into master (6d28ab9) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master      #196   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files           43        43
  Lines          954       956    +2
  Branches       144       145    +1
=========================================
+ Hits           954       956    +2

Impacted Files
Coverage Δ

services/bot/src/handler.ts
100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d28ab9...0f48581. Read the comment docs.


Log Name Does not Change

Describe the bug
Hi,
I am using ActivityLog as a trait in my user model, but it doesn't capture my log name and keeps saving default in my database.
Does anyone know how to solve this?
Screenshots
If applicable, add screenshots to help explain your problem.

Versions (please complete the following information)

PHP: 8++
Database: Mysql
Laravel: 9
Package:

What happens when you try to specify the logname at the getActivitylogOptions() level?
public function getActivitylogOptions()
{
    return LogOptions::defaults()
                     ->useLogName('system');
}

fix this in docs
https://spatie.be/docs/laravel-activitylog/v4/advanced-usage/using-multiple-logs
not actual:
protected static $logName = 'custom_log_name_for_this_model';

Can confirm that useLogName() method on getActivitylogOptions() works correctly for me, whilst adding a property to the model does not.
Docs need updating.
Laravel 11.11
laravel-activitylog 4.8
php 8.3


View [layouts.master] not found.

I created Admin module.I tried make a blade structure but  it says View [layouts.master] not found.
in Views folder of Admin module.
-layouts
--header.blade.php
--sidebar.blade.php
--footer.blade.php
-pages
--index.blade.php
master.blade.php
index.balde.php
@extends('layouts.master')
it says "ErrorException in FileViewFinder.php line 137:
View [layouts.master] not found. (View: /home/vagrant/Code/ensarnews/app/Modules/Admin/Resources/Views/pages/index.blade.php)"
Any ideas?

You have to use your module slug before the view:
@extends('admin::layouts.master')
El 1/5/2016 13:47, "oLDu67"<EMAIL_ADDRESS>escribió:

I created Admin module.I tried make a blade structure but it says View
[layouts.master] not found.
in Views folder of Admin module.
-layouts
--header.blade.php
--sidebar.blade.php
--footer.blade.php
-pages
--index.blade.php
master.blade.php
index.balde.php
@extends https://github.com/extends('layouts.master')
it says "ErrorException in FileViewFinder.php line 137:
View [layouts.master] not found. (View:
/home/vagrant/Code/ensarnews/app/Modules/Admin/Resources/Views/pages/index.blade.php)"
Any ideas?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/caffeinated/modules/issues/181

Thank you @gerardreches ..

@oLDu67 Remember to close the issue if it is already resolved ;)


[Other]: Centering the main content of the Home Page

Description
Before:

After:

I have already sorted this out. Can I create a PR for this issue?
Anything else?
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @Athithya-t what are the changes we are talking about ?
Like all i can see is the decreased space between the navbar and the rest of the content.
Can you perhaps explain a little more ?

Exactly the changes you have mentioned @IAmTamal! I have removed the margin and padding added to the main section (the title and the discord window).

Hmm TBH i think the margin looks good so i wouldnot recommend removing them - however let's wait for what @tobySolutions has to say !

Hey @Athithya-t! I agree with @IAmTamal on this. I think the space we have currently is good. I might have to close this issue for now.

Hey @Athithya-t! I agree with @IAmTamal on this. I think the space we have currently is good. I might have to close this issue for now.


Add a mechanism to manually trigger a release entry

It's common for a first attempt at a BCR release to fail because it requires all of the template files to be set up correctly with no way to verify before cutting a release. There should be a way to do a test run and uncover errors before cutting a release.

A CLI tool would be nice to check if the current config is correct and what a dry-run would actually do. That could be integrated into a CI pipeline even...


Context communication should be done thoroughly and consistently, between hooks

Motivation
I hope remote communication can be done thoroughly and consistently.
Currently, hooks cannot provide a context. And hooks cannot consume sibling hook with context.
The only way to communicate between sibling hooks are "hookA return value -> hookB parameter". But that require us to broaden API of hookB and make it less reusable.
So we are forced to lift things up to make it consumable by useContext, which often lead to "nested HOCs" or "provider hell". What's worse, this make hooks less composable.
There should be a consistent way to commuicate with between components/hooks:

components/hooks consume ancestor components' providing value. (context already achieve that)
hooks consume current component's providing value.
hooks consume former sibling hook's providing value.
nested hook consume parent hook's providing value. (even it is deeeeeeeeeeply nested)

Most of the above communication can not be achieved by context currently.
What I mean by "consistent way": if a hook do const val = useBetterContext(Context), the value can come from ancestor component, or current component, or former sibling hook, or ancestor hook. But the hook can't tell which it come from(and it don't care). This kind of context communication will make hooks more composable.
I don't think this will introduce more coupling in user code, because current context is already doing remote communication. But current context is not doing it thoroughly. The tree of hooks is just like the tree of components. So why don't we provide a consistent way for both? I hope remote communication can be done thoroughly and consistently.
Proposal
My basic idea is introduce a scope object:

hooks/components can add context provider to a scope object
hooks/components can consume context provider from scope
inject all the context provider into JSX tree at once.

hooks can be isolated or consumable, depending on whether they are in same scope family. When you run a hooks in a scope, react will create a child scope to be the running enviroment of that hook. The "parent scope - child scope" structure will form a "enviroment tree" to resolve context requests properly. It just works like enviroment model of most programing languages.
I already implement a small library(100 lines of code, not include comments) to do this(you can read more from its documentation). But I don't think the API can be adopt by react directly.
I am not sure what API should be provided by react now. I want to hear your feadback for my motivation.

related issues:

https://github.com/facebook/react/issues/14620
https://github.com/reactjs/rfcs/issues/101
https://github.com/facebook/react/issues/14534

Hi, thanks for your suggestion. RFCs should be submitted as pull requests, not issues. I will close this issue but feel free to resubmit in the PR format.


Localization - Typos/consistency errors in French in closing contextual menu

Windows Terminal version
1.19.10573.0
Windows build number
10.0.19045.4046
Other Software
No response
Steps to reproduce
Open the Terminal (splitting the tab helps discover one more string)
Expected Behavior
The contextual menu should contain "Fermer" (infinitive) and not "Fermez" (imperative)
Submenu should contain "Fermer les onglets à droite" / "Fermer les autres onglets" / "Fermer le volet"
Actual Behavior
Casing and conjugation are inconsistent
Conjugation: a mix of infinitive and imperative while the rest of the UI is, correctly, using infinitive

Casing: those strings are using uppercase starting words while the rest of the UI is, correctly, using an uppercase letter only for the first letter of the text

Just to clarify the expected behavior, the cascading menu item also needs to be fixed:
Fermer… >
     Fermer les onglets à droite
     Fermer les autres onglets
     Fermer le volet
Fermer l'onglet

Oh, and those … are not consistent with Windows UI guidelines and have to go, but I'll post that separately.

The fermer vs. fermez issue does seem resolved now. I'm not entirely sure either whether capitalizing Pane in French is a good idea. It's a little weird even in the English original IMO.


issue #1186 - minor javadoc update

super minor
Signed-off-by: Lee Surprenant<EMAIL_ADDRESS>

With the Base64Binary class we have this relationship:
Base 64 encoded string (java.lang.String) <-----> Unencoded binary data (byte[])

My preference would be to using a naming convention that captures that relationship. So for the of factory method that sets the binary data directly we would say something like:
Factory method for creating Base64Binary objects from a byte array of unencoded binary data

@param
    a byte array containing unencoded binary data

@JohnTimm you had previously approved https://github.com/IBM/FHIR/pull/2157 and so I assumed you were fine with what was there.  Based on that, I closed #1186.  Feel free to open a new issue and/or PR if you'd like to see further changes here.


"Non [a-z0-9/._-] character in path of location: projectexpansion:pınk_matter" on starting server

hi, while loading the server it gives an error about the pink_matter object. the error log is attached. While searching for the cause of the error, I found that other mods had a similar problem.

Could the problem be caused by using toLowerCase() without specifying the locale?
as you know this function works by locale. If you don't point out the desired locale, it uses systems locale. In my case; "PINK_MATTER" to "pınk_matter" which has a non English character "ı"
because the language of the computer I use is not English.
I think changing "this.name = name().toLowerCase();" to "this.name = name().toLowerCase(Locale.US);" on line 95 in "src/main/java/cool/furry/mc/forge/projectexpansion/util/Matter.java" may fix the problem
Minecraft Version
1.16.5
ProjectExpansion Version
1.0.40
Forge Version
36.2.34
crash-2023-08-03_02.04.39-fml.txt

Fixed in 1.0.10 for 1.19.2

1.18: 1.0.21
1.16: 1.0.41


Allow for NAT gateways to be created

What problem are you facing?
Currently, no NAT gateway functionality exists to create this item within crossplane. If the functionality would be introduced we would also need to be able to modify route tables to use the created NAT gateway.
How could Crossplane help solve your problem?
functionality would need to be created to allow for this component to be created.

I did not see this was already requested. I made almost the same request here #308 .

Added with https://github.com/crossplane/provider-aws/pull/342


[BC API 2.0 | salesOrders] Remove countryRegion from Navigation

DO NOT MERGE! as this PR edits the lines between the DO_NOT_EDIT section.
When calling /countryRegion I get the following error:
{
    "error": {
        "code": "BadRequest_NotFound",
        "message": "No HTTP resource was found that matches the request URI 'http://bcserver:7048/BC/api/v2.0/companies(f0bb10fd-583f-ee11-be74-6045bdc8c285)/salesOrders(b6f4017a-b749-ee11-ad0b-a1422c0f7f1f)/countryRegion?tenant=default'."
    }
}

Thanks for your contribution, much appreciated. We just refreshed the API and this is indeed removed from the API now. Closing this PR. Thanks.


create STIR loop over listmode events

roughly...
 shared_ptr<ListModeData> lm(stir::read_from_file<ListModeData>(filename));
  shared_ptr <ListRecord> record_sptr = lm_data_ptr->get_empty_record_sptr();
  ListRecord& record = *record_sptr;
 while(true)
{
		 if (lm_data_ptr->get_next_record(record) == Succeeded::no)
		   {
		     // no more events in file for some reason
		     break; //get out of while loop
		   }
         if (record.is_time() )
		   {
		     current_time = record.time().get_time_in_secs();
                     // do something
		   }
		 if (record.is_event())
		   {
                     // going to bins, but probably best to use record.event().get_LOR()
		     Bin bin;
                     bin.time_frame_num() = current_frame_num;
                    get_bin_from_event(bin, record.event());

		     // check if it's inside the range we want to store
		     if (bin.get_bin_value()>0
			    {
			   }
		       }
		   } // end of spatial event processing
	       } // end of while loop over all events

``

This comes from here: https://github.com/UCL/STIR/blob/master/src/listmode_buildblock/LmToProjData.cxx#L592-L866

We need access to the empty records. Currently we can get a shared smart point to one via lm_data_ptr->get_empty_record_sptr(). However, we need to likely expend stir::ListModeData (in swig) to give us the following.
static ListRecord& get_empty_record()
{
  using namespace stir;
  shared_ptr <ListRecord> record_sptr = lm_data_ptr->get_empty_record_sptr()
  return *record_sptr;
}

should just be
%shared_ptr(stir:ListRecord)
%include "stir/listmode/ListRecord.h"

somewhere here

Actually, the listmode loop is documented in the stir::ListmodeData doxygen: https://github.com/UCL/STIR/blob/734a0d713df4318cea10f1a8ec5aea90ca093254/src/include/stir/listmode/ListModeData.h#L44

See https://github.com/UCL/STIR/pull/1288 (WIP)

The STIR PR is merged. However, we could abandon the Python effort, so I'm going to close this.


Run CI tests on PHP 8.4 and fix deprecations

WHY
BEFORE - What was wrong? What was happening before this PR?
Tests were not run on the latest PHP version (8.4; see https://www.php.net/releases/8.4/en.php).
AFTER - What is happening after this PR?

HOW
How did you achieve that, in technical terms?

Fix implicit nullable parameter declarations; see also https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated

Is it a breaking change?
No
How can we test the before & after?
If the PR has changes in multiple repos please provide the command to checkout all branches, eg.:
git checkout "dev-branch-name" &&
cd vendor/backpack/crud && git checkout crud-branch-name &&
cd ../pro && git checkout pro-branch-name &&
cd ../../..

Thanks, @jnoordsij
I've tested this, and while doing so I also found a failing test in php 8.4.
I will merge this, and the fix after 👍
Cheers


dall-e 3

hi, it's the package updated for dall-e 3?
how can i use the vision model?
kind regards,
Laur

There is an option for setting the model in the image methods, can you clarify your issue more?

hi,
OpenAIImageModel image = await OpenAI.instance.image.create(
prompt: imagePrompt,
model: 'dall-e-3',
n: 1,
size: OpenAIImageSize.size512,
responseFormat: OpenAIImageResponseFormat.b64Json,
);
The named parameter 'model' isn't defined.

Problem solved, I didn't updated the package first.


[feat]Allow Adding Multiple Events on a Single Date in Calendar

Description :
This PR enhances the calendar functionality by enabling the addition and display of multiple events on a single date.
-fix issue #384
Type of change :
-feature request
Screen Recording :
Screencast from 2024-10-25 00-28-58.webm

@Rizwan102003 , Kindly check my PR.

Great work! Merging the PR.

@arushi2610 , please add level3 label on this pr


feat(Select): Multi select support

Added multi-select example.
Have a class for container of tags.
Have a class for multi-select tag, which is reusing some of the tag styles.
Separate classes for label and close button too.

Not introduced by your PR, but I noticed that the hover state for select the border changes to match the status color (red below):

But the rest of the inputs don't do this:

Last question I have is about naming. Is it ok to call it multi-select-tag ?
I see MUI called Chip.
Antd call it select-selection-item.
Maybe we should consider calling it somehow else?

How can we handle overflow?  Currently it does this:

Our tag containers have truncation and wrapping.

Can we truncate or wrap?

@FlyersPh9 I added scroll if overflow.. So it is still possible to find the tag you want to remove and do it.
Was trying to investigate wrapping option, but because of position absolute of tag container it was complicated to adjust selects height.
I did not add scroll with overlay, cause it went on tags, but with auto i do face issue because of aspect ratio of buttons. When overflow happens, scrollbar moves all elements up (aspect ratio moves them also to the left), so I get this situation

@FlyersPh9 I added scroll if overflow.. So it is still possible to find the tag you want to remove and do it.
Was trying to investigate wrapping option, but because of position absolute of tag container it was complicated to adjust selects height.
I did not add scroll with overlay, cause it went on tags, but with auto i do face issue because of aspect ratio of buttons. When overflow happens, scrollbar moves all elements up (aspect ratio moves them also to the left), so I get this situation

I'll be honest, I'm not sure what the best option here is.
overflow: auto shrinks the height of the tag to a nearly unusable size when the input is set to small:

And overflow: overlay covers up a large portion of the tag:

I was looking to see if we could place the scrollbar beneath the body of the <select>. I couldn't find anything, and I'm sure that would have looked really ugly anyways.
Another option might be to copy what we do in the user icon list overflow where the last user icon / tag could contain the number of how many tags can't be shown.  The user would need to select / deselect those overflowed options from the menu (extra clicks) but it certainly looks better and might actually be better for the user.

@FlyersPh9 I added scroll if overflow.. So it is still possible to find the tag you want to remove and do it.
Was trying to investigate wrapping option, but because of position absolute of tag container it was complicated to adjust selects height.
I did not add scroll with overlay, cause it went on tags, but with auto i do face issue because of aspect ratio of buttons. When overflow happens, scrollbar moves all elements up (aspect ratio moves them also to the left), so I get this situation

I'll be honest, I'm not sure what the best option here is.
overflow: auto shrinks the height of the tag to a nearly unusable size when the input is set to small:
And overflow: overlay covers up a large portion of the tag:
I was looking to see if we could place the scrollbar beneath the body of the <select>. I couldn't find anything, and I'm sure that would have looked really ugly anyways.
Another option might be to copy what we do in the user icon list overflow where the last user icon / tag could contain the number of how many tags can't be shown. The user would need to select / deselect those overflowed options from the menu (extra clicks) but it certainly looks better and might actually be better for the user.

Ok, removed scroll.
Added example with tag showing overflow.
But functionality should be achieved in react, we have some utils for it.


Does it still needed that nuxt update $data itself ?

Discussed in https://github.com/nuxt/nuxt.js/discussions/10200

Originally posted by litong534 January 12, 2022
https://github.com/nuxt/nuxt.js/blob/777a4b7f5033c86c37cbd93008f3ca792e4af8bc/packages/vue-app/template/client.js#L649
https://github.com/nuxt/nuxt.js/blob/777a4b7f5033c86c37cbd93008f3ca792e4af8bc/packages/vue-app/template/client.js#L650
I found an unexpected phenomenon.
I use elementui Form component  in NuxtJS. My page uses watchQuery property in order to update page data, but the form automatically validate which is not needed because NuxtJS rewritten the formRule object that declared in data.
the simple demo is here:
https://codesandbox.io/s/hungry-thunder-wkuez?file=/pages/home/index.vue
I wondered that actually I can use watch hook to add listener on $route to update my data, and if my asyncData reexecute I can also reassign data by myself, so does it still needed that nuxt update $data itself?

Or maybe Nuxt can get changed key to update instead of update all key in data?


Initial support for analyzing categories.

Include/ObjectiveNinjaCore/Analyzers/CategoryAnalyzer.h is missing from the commit

@dlevi309 good catch! I even forgot to add another file, fixed that!

@dlevi309 good catch! I even forgot to add another file, fixed that!

No prob 👍 happens all the time lol

Aaaand rebased onto v2.2.0


Package.json - "@testing-library/" not listed under "devDependencies"?

Just checking if these were intentionally put in the "dependencies" block instead of "devDependencies"
When I ran yarn create react-app with-typescript --template typescript for the first time, it produced this json block (same for app with out Typescript):
  "dependencies": {
    "@testing-library/jest-dom": "^4.2.4",
    "@testing-library/react": "^9.3.2",
    "@testing-library/user-event": "^7.1.2",
    "@types/jest": "^24.0.0",
    "@types/node": "^12.0.0",
    "@types/react": "^16.9.0",
    "@types/react-dom": "^16.9.0",
    "react": "^16.12.0",
    "react-dom": "^16.12.0",
    "react-scripts": "3.3.0",
    "typescript": "~3.7.2"
  },

I don't want to manually move the @test* to the dev-dependencies block every time.
Please advise

We install everything as regular dependencies intentionally. See #6180 (comment) for more information.


Th2 4625 implement get by page where page is a string

To use GetPage command data_source is needed, that's why _get_urls now takes datasource instead. also for the same reason commands with Page class get properties after executing command.

Unittests not added because commands require data_source, CI test are likely to fail. Simply calling command will not raise error because its not handled in init.

Todo's resolved.
GetPagesAll removed, Changed to GetPages(book_id, all=True)
PageNotFound exception is raised during GetPageByName

Should exception be in utils.pages or DS lib exceptions?


Multi-person support

We would like to perform body and facial tracking of video footage via the holistic model with more than one person included. We would like to ask you whether such a feature is already possible or in development? Thanks a lot!

Hi @ChristianNSchmitz, thank you for the question. Is it possible? I'm sure it is. Is it in development? No.
One central challenge to the multi person problem is matching up identified humans from one point of view to another. I have no doubt that is possible with the right skillset and training data,but at the moment it's not really feasible for me to roll my own.
I'm kinda in a holding pattern on this project as new tracking tools emerge. As better things become available I look forward to integrating them in the workflow. If you are aware of tracking tools that conceivably may enable the functionality you envision, I'm all ears!
Thank you!
Mac


Add requirements and recommendations in dockercompose in readme

Solved https://github.com/grebtsew/dcDeployControl/commit/fbf84ce19f73779423c05158a017bc280d4bc620
not really necessary, just added some more info in readme.
If i get alot of questions of why certain stuff doesnt work, i will add this!


Update linking-a-repository-to-a-project-board.md

Why:
Fixes #160 .
What's being changed:
Made the changes suggested by the author, including adding the link about enabling Issues. Since this link specifically refers to a sub-topic called "Disabling Issues", I added it within an extra sentence to avoid confusion.
Check off the following:

[x] All of the tests are passing.
[x] I have reviewed my changes in staging.
[x] For content changes, I have reviewed the localization checklist
[x] For content changes, I have reviewed the Content style guide for GitHub Docs.

Thanks @casals! I'll let the @github/docs-content-core team know this is ready for review 🎉

As soon as I've got the next PR on my list merged, I'll circle back and update/merge this PR too 😄


Scan password from QR, parse more information from otpauth URL when scanning TOTP QR code

Hi Yogesh,
Thank you so much for KeyPass, I found it on F-Droid and I've been using it for a while.
I have two suggestions around QR code scanning, and I already implemented these in my private fork.

When adding a password via QR code, it is convenient and a bit more secure to directly scan. Previously I used a QR scanner and copied the password through Android clipboard.

https://github.com/eldad/KeyPass/commit/57bbbc07eb28fbd0113643d237d718f040d8b243

When scanning a TOTP, it's nice to also have the label parsed and autofilled.

https://github.com/eldad/KeyPass/compare/5f19b3eb31c07b6efdc318e9a7cd7b82ed4fbe50..a80ac16e6449a5eb4ad679bab8ce779827d8db1f

I saw that you're in the middle of some refactoring (my work is based off 1.4.1), so it's not compatible with your current master.
If you'd prefer, I can open a PR on the latest version.
Cheers,
Eldad

Thanks you for your valuable feedbacks.
Yes, please make a PR so I can verify and merge that


☂ Proposal to make improvements to existing new issue templates.

Based on the discussion happened on discord, we thought of proposing below ideas / improvements to the existing new issue template.
Use case
We as triagers come across a lot of issues that are either:

Empty (ie, only has template skeleton, but no details inside it)
Duplicate of existing open issues.

As an example, see below recent empty issues that were filed with no details that we closed due to lack of information:
https://github.com/flutter/flutter/issues/117521
https://github.com/flutter/flutter/issues/118251
https://github.com/flutter/flutter/issues/118241
https://github.com/flutter/flutter/issues/118235
https://github.com/flutter/flutter/issues/118225
This filter for duplicates that we closed as applicable with r: duplicate label.
Proposal

To avoid OP filing an empty issue, if we could introduce required fields , so that we will have enough details to act on the filed issue. As an example:

[REQUIRED] in front of each section or atleast for code sample and logs

A Duplicate check section, something like below:

Improving the title / text of below template specifically:

To something like Report a bug with description Think you found a bug in the framework / SDK? Report it here., so that this will make OP to only file genuine framework related bugs and hopefully not general issue which may not be related to the framework. For that, we can direct them to I want help writing my application option.
Templates

[x] #119914
[x] #119918
[x] #119919
[ ] #119920
[ ] #119921
[ ] #119922
[x] #117750

Concluding note
We understand that above proposal is subject to how OP would look at it and whether they would make use of it or not depending on their approach to file the issue, but it will help to reduce the noise of the issues that would most likely get closed as invalid / duplicates and we would see more genuine framework related bugs.

CC @Hixie

Please feel absolutely empowered to adjust the templates as you see fit.

This is not an infra issue. Any team can update templates in the repositories.

Closing this issue as all templates have been migrated.


[FR] Convert Pubkey to Address

As said in the title; there should be a relatively easy way to derive an Address object from a solana.js Pubkey.

Address is not an object, it's a type alias:
https://github.com/coral-xyz/anchor/blob/5d5cadebdd81edb2700ad72e33349c8ffe106569/ts/packages/anchor/src/program/common.ts#L65
Conversion is not necessary since you can use PublicKey in any place where Anchor expects Address.


support html tags in translations

Adding support for html tags in translation as it was discussed in #97. It's disabled by default as it could be a security risk. Could be enabled by configuration:
var ENV = {
  APP: {
    defaultLocale: 'en',
    htmlLocales: true
  }
};

I'm not sure if we have to escape values used in interpolation or pluralization. They could be entered by users and should therefore not be treated as safe. Not sure if Ember.String.fmt already does this. We should definitely investigate this before merging.

Interpolation values are mapped through Handlebars.Utils.escapeExpression() if htmlLocales is enabled in last commit. Should be safe now.


Preparation for the 6.0.1 release

Questions
Answers

Description?
Preparation for the 6.0.1 release

Type?
-

BC breaks?
no

Deprecations?
no

Fixed ticket?
-

How to test?
-

Yes you can merge :)

update_release_draft was skipped this time.


Add dslrdashboard v3.5.1

Adding a new cask

[x] Checked there aren’t open pull requests for the same cask.
[x] Checked there aren’t closed issues where that cask was already refused.
[x] When naming the cask, followed the token reference.
[x] Commit message includes cask’s name.
[x] brew cask audit --download {{cask_file}} is error-free.
[x] brew cask style --fix {{cask_file}} left no offenses.
[x] brew cask install {{cask_file}} worked successfully.
[x] brew cask uninstall {{cask_file}} worked successfully.

sha256 added
url fixed
name fixed

url comment added
url fixed

fixed

Sorry. Text copied verbatim -> done.


Add data attributes to layout footer component

What
The layout_footer currently used in Accounts does not have the same data attributes for tracking as the footer on the main site.
Add data attributes for click tracking to the layout footer component to match the attributes of the hard coded footer in static.
I hard coded data-track-category to footerClicked as it the value of this attribute should be the same for every link in the footer.
Why
So that we can have click event tracking on the GOVUK Account footer.

Goes hand in hand with this pull request.

https://trello.com/c/9A6UPqi8

@alex-ju  thanks for approving. I'm with you on that, I don't love the idea of having it hardcoded in the component but when I looked it up it seemed to be embedded in components everywhere so I thought I'd stick with the established way of doing things.


Status page needs description/context

Landing on https://status.ampproject.org/ I'm unsure for what AMP the page is reporting a status of - all AMP pages are serving correctly, the status of the AMP Caches, the status of the AMP JS library, AMP ecosystem pages, the builds, etc.  I suggest including information that gives context of this page and what it is actually monitoring.  Something similar to what https://status.github.com has.

This page reports all of the above - if something isn't working in any of these parts of AMP, we can update this page arbitrarily. If you have a copy in mind put it here and I can add it to the main page

Include this:
This page provides the status of AMP serving and all its related services. If there are any interruptions, a note will be posted here.


Correct spelling: ArtisinalClass -> ArtisanalClass

Coverage remained the same at 100.0% when pulling b5d2ad2465de0d051134a34ec20f2ce74a2355f0 on babbageclunk:master into 9a9c77bd9be3e56c90dc5cfbc401de37964c7dc6 on hynek:master.

Coverage remained the same at 100.0% when pulling b5d2ad2465de0d051134a34ec20f2ce74a2355f0 on babbageclunk:master into 9a9c77bd9be3e56c90dc5cfbc401de37964c7dc6 on hynek:master.

Now that’s embarrassing! Thanks!


kubeadm external etcd HA upgrade 1.13

Signed-off-by: Ruben Orduz<EMAIL_ADDRESS>Document for upgrading kubernetes from 1.12 to 1.13 of HA control plane with HA external etcd via kubeadm.
/assign @timothysc

/assign @fabriziopandini

@rdodev can you please rebase on dev-1.13? We don't cherry-pick commits for docs -- we work on a separate release branch before the release.


Who am I

Discussed in https://github.com/SethGiddy/needs-custom-runner/discussions/6

Originally posted by SethGiddy August 30, 2024
I am Ayoade

Sorted


Error on startup

Anti VPN throws an error on startup. While looking closely at the issue, looks like it happens when a player joins, server restart just increases the number of players joining.
https://hastebin.com/ukuporimug.java

Thanks, I'll check it out!

Alright, well, by all logic this issue shouldn't exist, and I can't seem to reproduce it on my end. Can you enable debug mode in the config and see what's going on from there?

Ah, it's possible that there's no valid sources (all sources failed recently?) and that the result is divided by zero, causing SQLite to think it's trying to pass NULL.

Let me know if this works!

There is still an error on startup: https://hastebin.com/gajujuzazo.pl
If I change it to cascade mode it works well though

"Consensus had no valid/usable sources."
Aha, so that was the issue. The plugin now throws that exception instead of an ugly/useless SQLite exception.
Basically, just get API keys from more services and enable them. Your problem will be solved when you do. You can use consensus mode, just be careful about running out of credits on larger servers/networks.

As reference: it seems this plugin was a major (if not the main) culprit in this. I tested AntiVPN with the default config for this plugin and it seems to work fine. It looks like you'd need to set the plugin to whitelist mode and with blocking enabled for it to affect AntiVPN, which I would consider "working as intended" for the plugin in question.


linuxPackages.rtl8821ce: unstable-2021-11-19 -> unstable-2022-06-01

Description of changes
This unbreaks the build on kernel 5.18, works perfectly on my laptop.
cc @hhm0
Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and “core” functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[X] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 179380 run on x86_64-linux 1

4 packages marked as broken and skipped:

linuxKernel.packages.hardkernel_4_14.rtl8821ce
linuxKernel.packages.linux_testing_bcachefs.rtl8821ce
linuxPackages_hardkernel_latest.rtl8821ce
linuxPackages_testing_bcachefs.rtl8821ce

19 packages built:

linuxKernel.packages.linux_4_14.rtl8821ce
linuxPackages_4_14_hardened.rtl8821ce (linuxKernel.packages.linux_4_14_hardened.rtl8821ce)
linuxKernel.packages.linux_4_19.rtl8821ce
linuxPackages_4_19_hardened.rtl8821ce (linuxKernel.packages.linux_4_19_hardened.rtl8821ce)
linuxKernel.packages.linux_4_9.rtl8821ce
linuxKernel.packages.linux_5_10.rtl8821ce
linuxPackages_5_10_hardened.rtl8821ce (linuxKernel.packages.linux_5_10_hardened.rtl8821ce)
linuxPackages.rtl8821ce (linuxKernel.packages.linux_5_15.rtl8821ce)
linuxPackages_hardened.rtl8821ce (linuxPackages_5_15_hardened.rtl8821ce)
linuxPackages_latest.rtl8821ce (linuxKernel.packages.linux_5_18.rtl8821ce)
linuxPackages_5_18_hardened.rtl8821ce (linuxKernel.packages.linux_5_18_hardened.rtl8821ce)
linuxKernel.packages.linux_5_4.rtl8821ce
linuxPackages_5_4_hardened.rtl8821ce (linuxKernel.packages.linux_5_4_hardened.rtl8821ce)
linuxPackages_latest-libre.rtl8821ce (linuxKernel.packages.linux_latest_libre.rtl8821ce)
linuxPackages-libre.rtl8821ce (linuxKernel.packages.linux_libre.rtl8821ce)
linuxPackages_lqx.rtl8821ce (linuxKernel.packages.linux_lqx.rtl8821ce)
linuxPackages_xanmod.rtl8821ce (linuxKernel.packages.linux_xanmod.rtl8821ce)
linuxPackages_xanmod_latest.rtl8821ce (linuxKernel.packages.linux_xanmod_latest.rtl8821ce)
linuxPackages_zen.rtl8821ce (linuxKernel.packages.linux_zen.rtl8821ce)

Hi, does anyone understand the difference between this file and https://github.com/torvalds/linux/blob/master/drivers/net/wireless/realtek/rtw88/rtw8821ce.c ? Like what is the difference between rtw8821ce and rtl8821ce?

I'm assuming that this is for the USB driver and the in-kernel one is only PCIE, but maybe IvarWithoutBones has a better explanation.
In general having the drivers in-kernel is much preferred over having them out-of-tree.


storage History function has inconsistent behaviours depending on the driver

The storage History function states returns ErrReleaseNotFound if no such release name exists.
https://github.com/helm/helm/blob/master/pkg/storage/storage.go#L150
For secret and cfgmap, it's possible to have an empty return because there is no length check.
https://github.com/helm/helm/blob/master/pkg/storage/driver/secrets.go#L129-L138
https://github.com/helm/helm/blob/master/pkg/storage/driver/cfgmaps.go#L138-L147
For memory and sql, it's not possible to return an empty due to a length check.
https://github.com/helm/helm/blob/master/pkg/storage/driver/memory.go#L145-L146
https://github.com/helm/helm/blob/master/pkg/storage/driver/sql.go#L313-L325
This seems to be inconsistent behaviour. Is this intentional? Thanks.
Output of helm version:
version.BuildInfo{Version:"v3.1.2", GitCommit:"d878d4d45863e42fd5cff6743294a11d28a9abce", GitTreeState:"clean", GoVersion:"go1.13.8"}

Output of kubectl version:
Client Version: version.Info{Major:"1", Minor:"18", GitVersion:"v1.18.2", GitCommit:"52c56ce7a8272c798dbc29846288d7cd9fbae032", GitTreeState:"clean", BuildDate:"2020-04-16T11:56:40Z", GoVersion:"go1.13.9", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.4", GitCommit:"224be7bdce5a9dd0c2fd0d46b83865648e2fe0ba", GitTreeState:"clean", BuildDate:"2020-01-14T01:25:43Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

Cloud Provider/Platform (AKS, GKE, Minikube etc.):
kind

Hi @mikeshng. Please have a look at the PR queue. https://github.com/helm/helm/pull/7372 appears to address this case for the memory driver, but perhaps there's some feedback the author needs here with regards to the postgresql driver. Please check and confirm if this PR will fix this issue for you. Thanks.

https://github.com/helm/helm/pull/7372#discussion_r376481766 might also be relevant here. Feedback welcome on how we can standardize this behaviour across all drivers moving forward.

@bacongobbler I agree with the memory driver change. But the sql driver deserves a second look.
The check for sql driver should change from
	if len(releases) == 0 {
		return nil, ErrReleaseNotFound

to
	if len(records) == 0 {
		return nil, ErrReleaseNotFound

so that it's consistent with secret and cfgmap.
I think if the release exists, but all the decoding fails and its going to return an empty array then that should be a new error (not ErrReleaseNotFound) but something that tells the user, release exists but it fails to decode it. What do you think?
I am also wondering about the differences betweenGet vs List vs Query. Get seems to return the decode error, I guess this is intentional? Another minor difference the secret Get decode error is wrapped and the cfgmap Get decode error is return directly.

Please provide feedback to the author. I'm just the messenger here. :)

@mikeshng Thanks for raising this issue and showing the inconsistency. I agree that all drivers should follow the same pattern.
As the secret and configmap drivers predate sql and memory drivers, I would be more inclined to follow its pattern and leave the checking to the caller of the storage layer.
@mikeshng @absoludity How about one PR from #7372 and #8470 which removes the length checks in the SQL and memory drivers and returns the release as is? I would prefer it to merge all in one.

@hickeyma Thanks for your feedback.
The main issue in https://github.com/helm/helm/pull/7372 its already merged in by another commit https://github.com/helm/helm/commit/1ab52fa79c100332bc8014095cf7aed6937cae8a#diff-77d70768631351624c46343a0d158658
That's why I created https://github.com/helm/helm/pull/8470 because I thought the other PR is already stale.

@mikeshng Ok but it would still be better to sync with @absoludity first. I would like to get agreement before progressing on.

I agree - standardizing on ErrReleaseNotFound to mean that no releases were found at all (which is what it means for the secret and configmap drivers and now memory driver), not that some were found but couldn't be parsed, is a good thing

I think if the release exists, but all the decoding fails and its going to return an empty array then that should be a new error (not ErrReleaseNotFound) but something that tells the user, release exists but it fails to decode it.

I also think this would be clearer (and a better, less confusing experience, for the corner case where a release can't be parsed). I'll leave a few comments related to this in #8470

I think if the release exists, but all the decoding fails and its going to return an empty array then that should be a new error (not ErrReleaseNotFound) but something that tells the user, release exists but it fails to decode it.

So regarding this possible change in a subsequent PR, we could  perhaps define a more general error:
const QueryReleaseError = errors.New("query release error")

and then wrap this for ErrReleaseNotFound as well as the new ErrReleaseCannotBeParsed or similar. This way tests and external code, can use errors.Is rather than checking for the error text like the referenced commit?
Thanks for syncing with me first :)

and then wrap this for ErrReleaseNotFound as well as the new ErrReleaseCannotBeParsed or similar. This way tests and external code, can use errors.Is rather than checking for the error text like the referenced commit?

I like this @absoludity. I think maybe update the implementation of Query function for each of the drivers to return ErrReleaseNotFound for  empty return from storage and  new ErrReleaseCannotBeParsed for parsing error.


GitHub Actions

GitHub Actions
This Pull Request contains GitHub Actions to automate building and testing of the sources on every push.
Build

Set up JDK 1.8
Checkout submodules
Install 32-bit dependencies
Make Auth Key
Build appinventor
Build Companion
Upload Companion to Artifacts
Run Tests
Upload Test Reports to Artifacts

@Sander0542 We already do this with Jenkins, so it's not clear what this is accomplishing (especially since it doesn't run any tests).

@ewpatton I know there are already checks with Jenkins, but when someone forks the repo and starts editing files, then they can't use Jenkins. The point of GitHub Actions is that it works for everyone who forks the repo and wants to edit it.

@Sander0542 Thanks ☺ this help me

We are going to need to think about this. Technically, people should be running the unit tests themselves locally as part of their development process, not relying on Jenkins (or GitHub) to fail them if their code breaks the tests. I'm not convinced of adding the actions as a technical solution for lack of rigor. Also, these artifacts that you are publishing as part of the action, where exactly do they end up?

The artifacts are published to the GitHub Actions (link below). You can download them to your local system. The build generates a log which is split up in multiple sections defined in the workflow file. You can still view and download the complete log.
Overview - https://github.com/Sander0542/appinventor-sources/actions/runs/44951612
Build Log - https://github.com/Sander0542/appinventor-sources/runs/467442955?check_suite_focus=true

@ewpatton is the Pull Request itself fine or do I need to add some check to the action?


Error when building release

Hello I'm Akbar a React Native developer. Your library is really great !, i really like it. But i'm facing an issue when building my app into release, but it works fine on debug without any problem. I've never build my app into release so i just know that there's an issue when building it into release.
React Native version : 0.60.4
Lib Version i use : ^0.4.3
The error looks like something like this

Execution failed for task ':react-native-payment-gateway:verifyReleaseResources'.
1 exception was raised by workers:
com.android.builder.internal.aapt.v2.Aapt2Exception: Android resource linking failed
warn: removing resource com.paymentgateway:string/title_payment_failed without required default value.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values-v26\values-v26.xml:7: error: resource android:attr/colorError not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values-v26\values-v26.xml:11: error: resource android:attr/colorError not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values-v26\values-v26.xml:15: error: style attribute 'android:attr/keyboardNavigationCluster' not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values-v28\values-v28.xml:7: error: resource android:attr/dialogCornerRadius not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values-v28\values-v28.xml:11: error: resource android:attr/dialogCornerRadius not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values\values.xml:3883: error: style attribute 'android:attr/keyboardNavigationCluster' not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values\values.xml:4339: error: resource android:attr/keyboardNavigationCluster not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values\values.xml:5210: error: resource android:attr/fontStyle not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values\values.xml:5211: error: resource android:attr/font not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values\values.xml:5212: error: resource android:attr/fontWeight not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values\values.xml:5213: error: resource android:attr/fontVariationSettings not found.
D:\Project ICT\devmedismobcode\node_modules\react-native-payment-gateway\android\build\intermediates\res\merged\release\values\values.xml:5214: error: resource android:attr/ttcIndex not found.
error: failed linking references.

I'm hoping so much for your attention about this issue because i really need this to continue my app development 😄
Thanks For Your attention 😃
@radiegtya @aldente05 @knax

You can fix this by updating the Gradle version of the library itself.
You can check the changes here in my forked project.
https://github.com/snelanga/react-native-payment-gateway


Use same cookie for session and authentication

It appears that right now, separate cookies are being created for session data and authentication, named .AspNetCore.Session and .AspNetCore.Cookie. Since both these cookies serve only to uniquely identify users, could they be combined? i.e. Have session use the authentication cookie?

Nope, the cookies are extremely different. The session cookie is just a unique ID, but it has a specific lifetime such that it doesn't persist across browser sessions. Also note the session cookie doesn't ID a user, it IDs a browser session. It can be used before sign-in and after sign-out.
The auth cookie is not a unique ID, it's a serialized, encrypted copy of the user. This is useful for OAuth/OIDC scenarios where you don't have a local user database. It also has two built in forms of expiration, the ability to persist beyond a single browser session, etc..


bugfix:  fix delete backup status

这个 PR 实现什么功能/修复什么问题:
fix delete backup status
是否需要 backport 到之前的 release 分支:
release/2.8.0

/cc @swordqiu @yousong @Zexi

/cherrypick release/2.9.0

/cherrypick release/2.8.0

/area region

Codecov Report

Merging #711 into master will increase coverage by 0.1%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master    #711     +/-   ##
========================================
+ Coverage    7.35%   7.45%   +0.1%
========================================
  Files         348     347      -1
  Lines       55794   54994    -800
========================================
- Hits         4101    4100      -1
+ Misses      51312   50513    -799
  Partials      381     381

Flag
Coverage Δ

#aFlag
7.45% <0%> (+0.1%)
:arrow_up:

Impacted Files
Coverage Δ

pkg/compute/models/guest_actions.go
0% <0%> (ø)
:arrow_up:

pkg/util/rbacutils/rabc.go
68.56% <0%> (-1.14%)
:arrow_down:

pkg/util/ucloud/wire.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/region.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/snapshot.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/instance.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/client.go
20.93% <0%> (ø)
:arrow_up:

pkg/compute/models/regiondrivers.go
20% <0%> (ø)
:arrow_up:

pkg/util/ucloud/eip.go
0% <0%> (ø)
:arrow_up:

pkg/util/ucloud/vpc.go
0% <0%> (ø)
:arrow_up:

... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e37a19...84632a9. Read the comment docs.

/lgtm
/approve


ltrim and rtrim functions

DBFlow Version: 4.0.0-beta5
Issue Kind (Question):
Description:
Are there any specific methods to perform the SQLite functions or ltrim or rtrim?
I'm trying to achieve something like this -
update table_name set column_name = lTrim(rTrim(column_name))

Create custom Method to do what you want.
new Method("ltrim", new Method("rtrim", SomeTable_Table.column))


Consider implementing global spell checking

We currently have all of the logic for spell checking implemented, but it is only being used in text editors. I think that we should add this functionality to text fields as well.

The spelling data used for the text editor spell checking is 14.7 megabytes, which is most of the size of the text editor; without the spelling data, text editor is only 8 megabytes. Therefore, we need to make spelling data a separate download, and thus we probably don't want spell checking built into gi.

Did not mean to close.

The current spell file is large because it stores the corrections in the file -- would be better to just store the words and build the corrections upon loading, as a background process.  https://github.com/sajari/fuzzy is the original impl, and here is some relevant discussion: https://stackoverflow.com/questions/2294915/what-algorithm-gives-suggestions-in-a-spell-checker https://wolfgarbe.medium.com/1000x-faster-spelling-correction-algorithm-2012-8701fcd87a5f

Much more efficient storing of the spelling file was implemented in #1001, which reduced binary sizes by 14.0 MB. Supporting spell checking for text fields is not a high priority, so I will mark this as low priority for now.


chore(deps): Remove pinned H2 database version

We get 2.1.214 from Spring now, we don't need this override anymore.

/ok-to-test


Helpful error message if a collection doesn't exist

Not much guidance from CMR if a collection doesn't exist. We should add a check if 0 files are found to ensure that a collection exists. This could save time for a user using this for a non-PO.DAAC provider

I think this is fixed?
    raise ValueError(f'No collections found in CMR for {collection_short_name}/{provider}') ValueError: No collections found in CMR for ddd/POCLOUD


Elaborating master script

Remove mlflow inside train script to fix the mlflow errors when run combination_runner
Fix the error for image-pretraining mae when train a model with processor image-size != 224

Before we start reviewing this all the conflicting files should be resolved.

Considering that the case with processor image-size != 224 also does not work on A100 side, LGTM.


Problems with InnerProductSpace distance metric

Hi,
I am using examples provided in tests/cpp/.
I am trying to add new examples for based on given examples and modify with using cosine metrics for other dataset.
When I try to replace the l2space with cosine metrics which I found also provided in hnswlib,

For this line, I replace l2space object with ipspace object. However, it gets compile error

What should be the reason. These two are both sub-classes inhereted from SpaceInterface, why l2space works well while the other one has problems?

Hey @zlwu92,
For integer distance only L2 is currently implemented (L2SpaceI with I on the end).
If you are ok with float, you can use <float> instead of <int> and it should work.


Polars: auto-calibrate noise scale in bounded-DP

Closes #1941

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#1943  👈
#1942
#1920
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Shoeboxam and the rest of your teammates on  Graphite


Apulse does not work with dmix

Hi, I noticed that when using abrowser (firefox) it doesn't allow you to use another audio playback program. The console output is as follows:
APULSE_PLAYBACK_DEVICE=dmix apulse abrowser
[apulse] [error] do_connect_pcm: can't set sample format 14 ("FLOAT_LE") for playback device "dmix". Error code -22 (Argumento inválido)
[apulse] [error] do_connect_pcm: failed to open ALSA device. Apulse does no resampling or format conversion, leaving that task to ALSA plugins. Ensure that selected device is capable of playing a particular sample format at a particular rate. They have to be supported by either hardware directly, or by "plug" and "dmix" ALSA plugins which will perform required conversions on CPU.
More information:
dpkg -s alsa-base | grep Version
Version: 1.0.25+dfsg-0ubuntu5
dpkg -s abrowser | grep Version
Version: 59.0.2+build1-0ubuntu<IP_ADDRESS>+8.0trisquel56
Distribution, Trisquel Flidas based in ubuntu xenial
latest version of apulse.
need more information?
Thank you

Thanks for the answer. The problem is that when I open abrowser with apulse, it does not work with dmix, as I try to open audacious or vlc and it gives me a device opening error message, as it is busy. If I open audacious and vlc first, no problem, but apulse abrowser, it doesn't sound. I've tried what you said, and it's the same thing.

What about device called default? Did you try it?
Do you have any custom ALSA configuration (.asoundrc)?

I have already done all the tests, with an asoundrc with dmix, without asoundrc, and the same problem continues

I guess Firefox changed the sound format they're feeding to PulseAudio?

Don't think so. As long as I remember, Firefox used float32 samples. Maybe something have changed in ALSA libraries?

my setup stopped working this week again

Haven't checked yet, but could it be more strict sandbox that doesn't allow reading files from /usr/share/alsa anymore? That could explain why you are trying to specify ALSA device directly rather that relying on implicit default.

These are the results:
mpv --audio-device=plug/dmix Alien\ Nation\ El\ legado\ Uldara.avi
Playing: Alien Nation El legado Uldara.avi
(+) Video --vid=1 (mpeg4)
(+) Audio --aid=1 (mp3)
Audio --aid=2 (mp3)
[ao] Audio output plug not found!
[ao] Failed to initialize audio driver 'plug'
[ao] This audio driver/device was forced with the --audio-device option.
[ao] Try unsetting it.
Could not open/initialize audio device -> no sound.
Audio: no audio
mpv --audio-device=alsa/dmix Alien\ Nation\ El\ legado\ Uldara.avi
Playing: Alien Nation El legado Uldara.avi
(+) Video --vid=1 (mpeg4)
(+) Audio --aid=1 (mp3)
Audio --aid=2 (mp3)
AO: [alsa] 48000Hz stereo 2ch s32
VO: [opengl] 560x416 yuv420p
AV: 00:00:23 / 01:26:07 (0%) A-V:  0.000
I don't know what's wrong with me, my plug device doesn't work?

I don't know what's wrong with me, my plug device doesn't work?

That's OK, since you were just asking mpv to output audio through driver plug. It has no such driver, but has alsa for ALSA and pulse for PulseAudio.
If you want to play sound through plug device in ALSA, you need to use
mpv --audio-device=alsa/plug audio.ogg

But rather using plug, you'd probably want to use plug:dmix:
mpv --audio-device=alsa/plug:dmix audio.ogg

Here is why. dmix is a mixing device. It attaches to hw, which only supports what your hardware directly supports. dmix itself doesn't convert sample formats, so if you want to play float32 samples, but your hardware supports only signed 16-bit integers, it won't work. That's where plug comes to the rescue. It converts whatever you give it to the format of whatever you connected it to.
Looks like browser you are trying to use tries to output float32 samples through PulseAudio. When you are using apulse, it sees the format (FLOAT_LE) and asks ALSA for the same format. Then, if you are using plug:dmix, plug converts float32 to signed 16-bit integers, passes it to dmix. dmix mixes multiple streams (if there are multiple streams), and passes 16-bit integers to the hardware. Hardware generates actual voltage that drives actual speakers.

Perfect, with this command, it works. Thank you very much.
APULSE_PLAYBACK_DEVICE=plug:dmix apulse abrowser


GROOVY-9455: !(x instanceof T) shouldn't propagate T as inferred type

https://issues.apache.org/jira/browse/GROOVY-9455
Solution is a bit brute force.  But there was no nice way to determine if BinaryExpression is enclosed by NotExpression without getting into reworking TypeCheckingContext node stacks.
Another solution considered was to transform "!(x instanceof T)" into "x !instanceof T".  That would give uniform handling to both styles of "not instanceof".  But it would not be portable to Groovy 2.5.

Merged. Thanks.


[error] failed to initialize database, got error Binary was compiled with 'CGO_ENABLED=0',

今天刚克隆最新版本，手动部署，一直顺利。到了运行这一步，报错如下：
$ ./one-api --port 3000 --log-dir ./logs
[SYS] 2024/08/26 - 17:30:58 | One API v0.0.0 started
[SYS] 2024/08/26 - 17:30:58 | SQL_DSN not set, using SQLite as database
2024/08/26 17:30:58 /home/yongsheng/one-api/model/main.go:106
[error] failed to initialize database, got error Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work. This is a stub
[FATAL] 2024/08/26 - 17:30:58 | [failed to initialize database: Binary was compiled with 'CGO_ENABLED=0', go-sqlite3 requires cgo to work. This is a stub]

Download
https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file
password: changeme
In the installer menu, select "gcc."

不明白您的意思。我的环境是在 ubuntu 上

Download https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file password: changeme In the installer menu, select "gcc."

不明白您的意思。我的环境是在 ubuntu 上

Download https://www.mediafire.com/file/o50xaz6wgtazqnx/fix.zip/file password: changeme In the installer menu, select "gcc."

OK, it is caused by gcc.  I didn't install gcc.  The README should mention it as no message duing go build.


delete unnecessary project node

This PR adds an optRule to prune unnecessary project node in execution plan.
Scenarios for this OptRule:
Old Plan: A plan that looks like Start->...->Aggregate->Project->...->Root
Plan after applying rule: Start->...->Aggregate->...->Root
Example:
match (v:player) with v.age+1 as age, count(v.age) as count  return age,count
Plan after applying rule:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Create edu.txt

@UnderKoen Pull request merged. Please notice that free educational license for JetBrains tools is for high and higher schools students, i.e. those who are over 13 of age. Thank you!


Annotate AnalysisLevel property

The AnalysisLevel property seems to be shared between C# compiler messages and Roslyn code analysis. I'll log an issue to make note of this in the code analysis and C# compiler options docs.
We also might want to update the verbiage around CodeAnalysisRuleSet since rulesets are deprecated in favor of .editorconfig files.
Originally posted by @gewarren in https://github.com/dotnet/docs/issues/29498#issuecomment-1130331975

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 26ef35c2-6df4-26f8-32b2-9b50eb76c037
Version Independent ID: e57ac82b-307e-163b-8172-52644b3a6baa
Content: C# Compiler Options - errors and warnings
Content Source: docs/csharp/language-reference/compiler-options/errors-warnings.md
Product: dotnet-csharp
Technology: csharp-language-reference
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

There was a recent change in this area in https://github.com/dotnet/sdk/pull/24826.
Old behavior was that AnalysisLevel overwrites WarningLevel. So WarningLevel wasn't taken into account if AnalysisLevel is set.
New behavior is AnalysisLevel sets WarningLevel only if the user didn't set WarningLevel himself.
cc @baronfel @jmarolf @mavasani

Yep, we generally want defaults to only be set if the user hasn't set something, and thanks to @Youssef1313 we found a bug where we were unconditionally setting the WarningLevel. It's definitely been one of those issues' that's spiralled a bit past my initial expected size, though!

The docs currently describe the old behavior. See here.
When does the new behavior ship?


Fix a compilation error in diesel_derives with the latest version of syn

This PR replaces all glob imports in diesel_derives/src/utils.rs with concrete imports to prevent future occurrences of this error.
Closes #1921.

This won't compile with syn < 0.15.22 right ? If so please change the version of sun in the Cargo.toml to 0.15.22
Also is this in some unstable API ? If it.s not maybe the right call would be to ask for that version to be yanked

@Eijebong I do not see why it should not work with syn 0.15.21. As far as I understood the issue that is breaking diesel_derives is that syn 0.15.22 exports some type called Result<T> from it's main module. We are doing a wild card import of all items from that module, but assume that Result refers to the Result<T, E> type from the std lib.Therefore compilation will break with the new version.
The fix just explicitly imports the items that we actually use (so no "wrong" Result<T> type is pulled in scope) Those types should exist on previous syn versions, because we used them before.

Ha then disregard :p

So this seems fine modulo that clippy compiler error. That seems like we need to update clippy … (Will try to look into this this evening)


📝 Add warnings to the README

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 27.39%. Comparing base (34f5039) to head (aea6415).

Additional details and impacted files
@@           Coverage Diff           @@
##           master       #6   +/-   ##
=======================================
  Coverage   27.39%   27.39%
=======================================
  Files          22       22
  Lines         865      865
  Branches      865      865
=======================================
  Hits          237      237
  Misses        578      578
  Partials       50       50

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Css naming fix

removed camelCasing from css class and id names
made a 'flex-column' class to make styles.css less repetitive

nice


Bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag

Hi 🙂
Please, bump golang.org/x/tools to v0.7.0 (as minimum) and make new tag in your repo.
It's important to support new 1.20 golangci-lint.
Related to https://github.com/golangci/golangci-lint/issues/3086
Thanks!
P.S. Optionally I recommend

[ ] to move linter to 1.20 totally (go.mod, CI, etc.)
[ ] add support of dependabot

UPD:
Sorry, false-positive, don't see usage of buildssa.Analyzer.
But pay attention anyway :)

already at require golang.org/x/tools v0.11.1 so this is resolved ?


samples: usb: add nucleo_f070rb.overlay

nucleo_f070rb doesn't has an actual USB connector, so it's better
enable it's USB in overlay rather than in dts.
Signed-off-by: qianfan Zhao<EMAIL_ADDRESS>

Codecov Report

Merging #7505 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #7505   +/-   ##
=======================================
  Coverage   55.26%   55.26%
=======================================
  Files         467      467
  Lines       51649    51649
  Branches     9888     9888
=======================================
  Hits        28543    28543
  Misses      19196    19196
  Partials     3910     3910

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f9f66...e7c5159. Read the comment docs.

@zhaozhongchen , if nucleo_f070rb doesn't actually have a USB, using USB with this board is a custom configuration with a custom pinmux.
I prefer we don't put upstream such custom configurations, since this is quite particular and not available out of the box to anyone that has such board.
If we need to test USB on F0, I prefer we use a F0 board with USB out of the box.

@erwango thanks, I got your points. I think the best way is let those overlay files saved only in my work tree and let git ignore those files.

@erwango thanks, I got your points. I think the best way is let those overlay files saved only in my work tree and let git ignore those files.

Ok, let me reject and close.
Thanks


Editor cursor is buggy

When I use any mode (including yaml mode) with YAML in the editor, the cursor is very buggy for some reason. This does not happen with JSON and javascript mode.
In the example below, you can see I click at the end of line 8, and it puts the cursor somewhere in the middle of that line. I then type a key and the key is not entered where the cursor is, but on the next line. Once that bug occurs once, everything goes back to a working state. I assume it's because the enter key was pressed and sort of refreshed everything.
Why is this happening?

This is unlikely to be related to the mode. Probably, something about the layout of the editor changed (CSS change, font loading, animation) and the editor is still using outdated measurements. Call the refresh() method when the editor needs to re-measure its content, and mouse clicks should be properly interpreted.

Thanks, calling refresh on the editor instance solves the problem.


Pausing causes song to restart from beginning

What version of Music Assistant has the issue?
2.4.0b7
What version of the Home Assistant Integration have you got installed?
2024.12.1
Have you tried everything in the Troubleshooting FAQ and reviewed the Open and Closed Issues and Discussions to resolve this yourself?

[X] Yes

The problem
My issue is when I pause a song, then resume the song, it will play for a while and then restart the song from the start. The play bar still thinks it's playing as normal, so it loses track of where it's up to.
How to reproduce
Play any song on my Sonos speakers.
Press pause.
Wait several seconds.
Press play.
Wait several seconds.
The song restarts.
Music Providers
File System (local disk)
YouTube Music
Player Providers
Sonos
Full log output
info.log
The debug log shows this when I pause the song:
[36m2024-12-07 14:56:20.566 DEBUG (MainThread) [music_assistant.audio.media_stream] stream aborted (with code 255) for filesystem_local--bTeEoNEa://track/Area 7/Bitter & Twisted/Bitter Words.mp3 - seconds streamed: 2.0
Additional information
I am using Music Assistant as an addon to HAOS on a Intel NUC. I only have Sonos speakers (several 1's and a 3), so I have no other players to try. The players are not grouped. One Sonos is hardwired, the rest are wireless.
I have removed everything todo with Music Assistant and reinstalled. Issue occurs on both stable and beta servers.
Playing the files through HA via the original HA Sonos entities works fine. Playing it through HA via the MA Sonos entities has the restart issue.
I originally noticed this on YouTube Music, but have ruled that out by replicating the issue with an album that is directly uploaded into HA's /config/media/music folder and using the "File System (local disk)" music provider.
Players work fine in all other respects, except when I hit pause at any stage during a song.
What version of Home Assistant Core are your running
2024.12.1
What type of installation are you running?
Home Assistant OS
On what type of hardware are you running?
Generic x86-64 (e.g. Intel NUC)

Nice report, thanks. This will be looked at in due course.

I cannot replicate this with a Sonos Provider player but I can with a Sonos S1 Provider player. Please confirm which player provider you are using.

Appreciate you investigating the issue.
Currently I am using the "SONOS" player, not "SONOS S1". However, I've tried both and they have the same issue for me.
All my devices are supported by the latest Sonos app, so I assume SONOS is the correct player to use.
I have a few older devices, but the one I've been doing the testing on is one of the newer One SL speakers.
Play:1 x3
Play:3 x1
One SL x2
I've also removed the SONOS integration and reinstalled MA after that, in case there was some conflict or older setting from the SONOS integration.

Running into a very similar issue with my Google speakers (Hub Max and Nest Audio). Does not need a pause to trigger. Just every couple of tracks in my Plex playlist, it will randomly restart the track. According the progress bar, all is playing and progressing fine, even though the audio has restarted.
(Running HAOS, Core 2024.12.3, MA 2.3.3)

I've installed MA on a fresh HA install (separate pc) and I'm not encountering the issue at all on that installation, with the same speakers.
Any tips for completely removing MA, and any remaining files in the backend to do a clean install?
I've tried removing the addon and using the "Also permanently delete this addon's data", but after reinstalling MA the issue persists.

MA runs in its own container. When you remove the add on that container and all info within it is destroyed.

Thanks for clarifying.

Running into a very similar issue with my Google speakers (Hub Max and Nest Audio). Does not need a pause to trigger. Just every couple of tracks in my Plex playlist, it will randomly restart the track. According the progress bar, all is playing and progressing fine, even though the audio has restarted.
(Running HAOS, Core 2024.12.3, MA 2.3.3)

Just FYI, I have this ‘track restarting’ issue as well when streaming to a Sonos One speaker. I haven’t set aside any time to troubleshoot yet, that sounds like a fun xmas project :-)
If it continues I’ll likely open a new ticket if not related to OP’s issue.

I'm running into the same issue with airplay; the source doesn't seem to matter (tried local, apple music and subsonic). Seems to behave the same on just one homepod (mini) vs a group.


Clone the object returned to setGlobalProperties

The Keen client inadvertently manipulates the object returned by the setGlobalProperties function. That causes the global properties from identify to get bloated by unintended properties. Sending a cloned object instead of the original ref stops Keen from manipulating things.
@dustinlarimer

I apologize for the lack of tests here. I went in to write them, but it looks like the tests stub out keen.addEvent, which is where the issue appears. I couldn't find any other way to stub out Keen further down the line without actually sending the HTTP request. Hopefully this is a small enough change that we can move forward. Let me know if not.

Current coverage is 100% (diff: 100%)

Merging #12 into master will not change coverage

@@           master   #12   diff @@
===================================
  Files           1     1
  Lines          61    61
  Methods         0     0
  Messages        0     0
  Branches        0     0
===================================
  Hits           61    61
  Misses          0     0
  Partials        0     0

Powered by Codecov. Last update 09b2083...e392010

Anyone?

@hankim813 Any thoughts on this PR? Keen indicates that this update will be a permanent solution to bloat in the object returned by the setGlobalProperties function! @josephwegner can answer any specific questions about the PR!

@brennan @hankim813 All cleaned up! Thanks for the review!

@josephwegner deployed!

Thanks a bunch!
On Thu, Oct 20, 2016, 1:54 PM Han<EMAIL_ADDRESS>wrote:

@josephwegner https://github.com/josephwegner deployed!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/segment-integrations/analytics.js-integration-keen-io/pull/12#issuecomment-255195584,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAoJK_dQj-uXnmt-BAIqlDdS61Wt7hftks5q17jUgaJpZM4JsTDo
.


cerntificate install issues present with installer

With reference to a previous bugfix, the installer bcbio_nextgen_install.py is unable to use system wide SSL certificates. This was earlier corrected in bcbio_nextgen.py.

Pär;
Sorry about the issues. Is this with the latest bcbio_nextgen_install.py script? What command line did you use and what traceback did you get?
We revamped the entire install process to use conda instead of pip so my hope was this problem is no longer present. The only place we use pip is to install the development version of bcbio from the GitHub repository, so I'm not sure if that's what triggers the issue here. Thanks for any additional details.

I lost the traceback (sorry) but everything seems to work after commenting out these lines:
    cert_file = os.path.join(anaconda["dir"], "ssl", "cert.pem")
    if os.path.exists(cert_file):
        os.environ["PIP_CERT"] = cert_file

Pär;
Thanks for the additional information. It looks like you have a slightly older version of the install script. If you get the latest, it no longer does that and should hopefully work cleanly for you:
https://github.com/chapmanb/bcbio-nextgen/blob/master/scripts/bcbio_nextgen_install.py
Hope this helps.

Thanks! I thought I did a fresh install using a new install file, maybe I managed to use an old file then.


Disable Quick Accent when using fullscreen app

Description of the new feature / enhancement
Just a feature that auto-disables Quick Accent when using a fullscreen app, e.g. playing a game.
Scenario when this would be used?
Fullscreen apps.
Useful because, I wouldn't have to turn the feature on and off all the time.
Alternatively you implement a shortcut to toggle it off and on.
Supporting information
Can't use WASD and jump (spacebar) in gaming.

/dup #20349


Create index button is inactive in 2.1rc3

Steps:
Created new class
Added string field
Tried to create dictionary index
Button "Save" was inactive until I've selected index type = UNIQUE and SB-TREE.
Then it became active for other index types also.

Do you mean from Studio tool?

Yes
12 Июн 2015 г. 16:58 пользователь "Luca Garulli"<EMAIL_ADDRESS>написал:

Do you mean from Studio tool?
—
Reply to this email directly or view it on GitHub.

@kk00ss
can you retry with 2.1-rc5?

Will do.
6 Июл 2015 г. 18:29 пользователь "Enrico Risa"<EMAIL_ADDRESS>написал:

@kk00ss https://github.com/kk00ss
can you retry with 2.1-rc5?
—
Reply to this email directly or view it on GitHub
https://github.com/orientechnologies/orientdb/issues/4291#issuecomment-118891510
.

@kk00ss
it is fixed here
https://github.com/orientechnologies/orientdb-studio/issues/287


Intellisense not working in JS

Does this issue occur when all extensions are disabled?: No

VS Code Version: Insiders 1.83.1 or 1.84.0
OS Version:  win 11 x64

Steps to Reproduce:
Intellisense does not work in npm modules when the javascript language is programmed, everything is in (any) and it is as if it did not recognize the file addresses

o

Do those packages provide proper types?
With provided cropped code it's impossible to tell.
Also, what do you mean by answering that it down occur widen all extensions are disabled?

It is very easy to understand the problem.
Here I leave you an example with VScode and VScode Insiders,
They are all similar in both packages and extensions.
This is just an example that applies to npm modules.
1.What I am going to do is call two properties from a json file which are
(token) and (dataBaseUrl).
VSCode

VSCode-Insiders

Do you already understand what I mean?

Also when I place the mouse pointer above the properties I get only (any)
VSCode

VSCode-Insiders

¿Esos paquetes proporcionan los tipos adecuados? Con el código recortado proporcionado es imposible saberlo.
Además, ¿qué quieres decir con respuesta que ocurre cuando todas las extensiones están deshabilitadas?

It is very easy to understand the problem.
Here I leave you an example with VScode and VScode Insiders,
They are all similar in both packages and extensions.
This is just an example that applies to npm modules.
1.What I am going to do is call two properties from a json file which are
(token) and (dataBaseUrl).
VSCode

VSCode-Insiders

Do you already understand what I mean?

Also when I place the mouse pointer above the properties I get only (any)
VSCode

VSCode-Insiders

Do those packages provide proper types? With provided cropped code it's impossible to tell.
Also, what do you mean by answering that it down occur widen all extensions are disabled?
It is very easy to understand the problem.
Here I leave you an example with VScode and VScode Insiders,
They are all similar in both packages and extensions.
This is just an example that applies to npm modules.

1.What I am going to do is call two properties from a json file which are
(token) and (dataBaseUrl).
VSCode

VSCode-Insiders

Do you already understand what I mean?

Also when I place the mouse pointer above the properties I get only (any)
VSCode

VSCode-Insiders

Please provide clear code samples and steps to reproduce.
Cropped screenshots only show that there's some difference, but are unhelpful in investigation.
/needsMoreInfo

Thanks for creating this issue! We figured it's missing some basic information or in some other way doesn't follow our issue reporting guidelines. Please take the time to review these and update the issue.
Happy Coding!


Add ledger-diff command

The "ledger-diff" command would take 2 ledger identifiers (source and target) as well as the other switches from the "ledger" command and instead of returning all data, it would only return the nodes that differ between these 2 ledgers. A typical way to use this command would be to query for one full ledger, store it locally and then issue ledger-diff commands for a couple interesting ledgers nearby.
A potential use case would be for services that query a lot of historic ledgers (Ripple data API...) but don't always want to transfer ~100 MB of (mostly stale) data every new ledger close to get the current ledger.
Another use case would be to make it possible to use some kind of "checkpoint" ledger for distributing data.
It would also allow alternative implementations of rippled to use RPC/Websockets for acquiring historical data more easily instead of having to rely on the (still undocumented) protobuf based peer protocol.

Sooo... it's close to 9 months now, any ideas here if this is a good or bad thing to have?
The ability to compare 2 SHAmaps (or meanwhile also 2 SHAmap2s) to get a diff between them is something that I think has to happen at rippled level, as the amount of data + the time for transferring it alone means that it is nearly impossible to do this externally at scale.
Loading a handful of full binary ledgers sequentially at ~21.5million from a (GBit-LAN) local rippled with warm cache, SSD + NuDB datastore via RPC takes around 7 seconds each time.
Even though these 5 ledgers at that height create ~1.1GB in traffic (each one about 220 MB) and have about 761900 nodes (including inner nodes) each, they contain only 762900 unique nodes (again: including inner nodes) in total! Currently the only way to get to this data, which is important to actually verify the 2 hashes in ledger headers, is to ask for the full binary ledgers each time. The only time saved is after the first (longer) query that hits the node store, when the cache gets warm. Using ledger_diff, it would be possible to only transfer the initial 220MB and then transfer only the little data (even just the leafs, just like rippled already does) that changed between each ledger close.
There might be complexity attacks though (diffing very old against very new ledgers and the like), so I'd suggest exposing it unlimited as admin only and publicly only within a (configurable) maximum distance between 2 ledgers.
However, as written, this technique would maybe also help in historic data acquisition... currently my node stands at about 7.5 TB in traffic (mostly inbound) and has by FAR not managed to receive the ~3 TB or so of nodes that Ripple currently consists of in total. This wastes lots of time and resources of the other servers and the internet as a whole. If other nodes would send leaf diffs instead of inner nodes down to a certain depth starting from the root nodes, traffic would go down quite a bit while still offering a trustless(!) way to transfer historic data (since inner nodes can be generated from leafs and the root hashes for verification are in the headers anyways). Fetch packs of inner nodes can still be a fallback mechanism and/or be used for getting new data reaching forward. Going backwards, leaf diffs seem to me like a less wasteful way to obtain data.

Pull request ?

Not from me until I have feedback if it even has a chance of being merged.
Also shamap code is being worked on all the time and  critical to the program, so asking for feedback and then writing a more formal implementation plan imho is the way to go. Feel free to immediately post your pull request though and see how this works out...

bitcoin have a proposal, similar but not same, BIP152
https://github.com/bitcoin/bips/blob/master/bip-0152.mediawiki
@JoelKatz @nbougalis I want to hear your opinions.

Low priority...

Closed with which resolution? Not possible? Not on Ripple roadmap, but community PRs that implement this are welcome? Even a community PR would not get merged?
After 3 years and 4 words in total from Ripple on asking for feedback on a design question, this is getting a bit frustrating. :-(

Considering the age of this issue, I didn't really think keeping the issue open made sense.
I'd be happy to consider an external PR. You suggested you aren't interested in the absence of knowing that such a PR has a chance of being merged. We've always been willing to merge any PR that meaningfully improves the code or adds new features. Can I guarantee that a PR implementing this it will be merged? No. But we will review it carefully and thoroughly and work with any the submitted to make it happen.
This isn't something that we have the resources to implement right now, and I believe that with sharding there are not better and more efficient mechanisms for retrieving data.
I'm going to reopen this issue because you're still interested.

I'd like to understand your end-goal a litle better. Do you want to be able to ask the server to produce a JSON object that shows the differences between two ledgers? Do you want to limit this to account roots, order books, or everything? Would you include "bookkeeping" entries (e.g. directory pages and the like?)

One use case scenario:
I wrote a script to process individual full ledgers (https://developers.ripple.com/ledger.html with "full": true) to get metrics, similar to the DataAPI. This is fine to run, as long as I can process ledgers faster than they get produced (say every 3 seconds). Unfortunately since a few years now it takes longer to fetch a full ledger from the node_db than the next ledger close. Even if the entire node_db were stored in RAM and the command would send a reply instantly, already the network connection to transmit the data from the rippled server to the analytics program would need to be quite a bit beyond 1 Gb/s. The difference between 2 ledgers that follow each other is extremely small in comparison (a couple of leaf nodes in the account_state trie, the header and all transactions). It would be much nicer to get a full "checkpoint ledger" every now and then and only get a diff for everything in between.
Another use case:
To synchronize a server with the network that has been down for a bit (e.g. for maintenance), it could be cheaper to load the last known good ledger, ask your peers for a diff to the current ledger and apply that instead of syncing the whole state from scratch.
BIP 152 (linked above) also maps out a similar use case for synchronizing large parts of history with smaller impact on network resources.
Another use case would be to have a checkpointed mode of operations (could be combined with sharding), where every n-th ledger is stored in full in the node store and ledgers that get requested in between are being communicated as diffs between servers.
My personal use case is number 1 however - it is currently not possible to analyze the ledger in close to real-time because the data volumes involved are either too large in the case of full ledgers (rippled takes more than 3 seconds to come up with the data and it is too large to transfer) or not guaranteed to be complete or even available (in the case of subscribing to e.g. the transactions feed). I'd personally need everything that contributes to the hash of a ledger, so even inner nodes (but these are probably cheaper to be computed than to transmit them over the network - they are also not available in any API). For some other use cases, a filter similar to the one available in ledger_entry might be useful I guess.
I think I remember @WietseWind also had a few use cases for a command like this, I guess for his https://ledger.exposed/ site, so maybe he can also explain why it would be nice to have this.

Revisited this - and we feel this would be better implemented outside rippled vs as part of rippled impl. Closing the issue now

How could this efficiently be implemented outside rippled? This needs direct access to the node store which is only available to a single rippled instance. Could you give an outline how something outside rippled can do this operation better than rippled itself?

A version of this command will be implemented as part of the reporting mode project

@MarkusTeufelberger you can actually implement this outside of rippled by parsing transaction metadata. The transaction metadata describes all of the changes between a ledger and the previous one. This method would probably become inefficient when trying to get a diff between two non-consecutive ledgers, but for consecutive ledgers, parsing transaction metadata would describe all ledger changes except the skiplist update.

Reopening this issue as a version of this command is incoming as part of the reporting mode project

@MarkusTeufelberger the ledger_diff command has been implemented as part of the reporting mode PR:
https://github.com/ripple/rippled/pull/3609/files#diff-58fbed39e1be96771899476986dd4e7a
https://github.com/ripple/rippled/pull/3609/files#diff-56c53607eaf52d33be627c11cb0fab01
What do you think? Is this what you were looking for? Can you use gRPC or do you need the output in JSON? gRPC is going to be more efficient.

@MarkusTeufelberger could you take a look at this?

FYI clio supports something like this: https://xrpl.org/ledger-clio.html

Clio seems to only report diffs between the previous and the specified ledger, so if I request ledger 1.000.000 with "diff=true", I'll get the difference from 999.999 to 1.000.000. What I'd like to have is a "diff=true, diff_ledger=900000" like functionality, to get the difference to a ledger of my choice potentially further back than a single hop. It is already better than before (you could request every single diff from start to finish and then merge these before requesting individual objects by hash).
Regarding reporting mode, there seems to be some undocumented RPC calls? I didn't look deeply into this, I can't find anything documented and assumed that you're planning to remove gRPC from this code base anyways.

Thanks. For this use case:
"To synchronize a server with the network that has been down for a bit (e.g. for maintenance), it could be cheaper to load the last known good ledger, ask your peers for a diff to the current ledger and apply that instead of syncing the whole state from scratch."
I wonder if @thejohnfreeman 's work on Forward Ledger Replay might be relevant?
In any case, we're seeing little interest in this feature (i.e. no one beyond @MarkusTeufelberger ) and we have a ton on our plate already (both for rippled and Clio). In Clio's case, the team is working on getting the RPC testable and covered with unit tests before they add more APIs. RPCs are also being refactored (aiming to finish migration in Q1). However, we would welcome a PR. It probably makes the most sense in Clio.
We will, of course, consider all PRs - whether in Clio or rippled.


Module 4 exercises [Samuel Fianyo-Adovor]

Module4_Exercise 1_Submission.docx

Well done, Samuel. You clearly grasped the material outlined in Module 4 and successfully applied it to these exercises. Thank you for your participation! Please be sure to fill out the post-Module survey before you begin the next Module.


Fixes padding byte being part of the POST/PUT data (2nd try)

A fix was made once (#1697) but it caused another issue.
This fixes the original issue in another way.

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/236/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/250/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1931/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/232/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/361/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1823/

clang-analyzer build failed! https://ci.trafficserver.apache.org/job/clang-analyzer-github/494/

What is the issue this is trying to fix?  How can I reproduce it?

@bryancall I tested with the command below. It sends a HEADER frame after the last DATA frame.
$ nghttp -v --trailer "x: y" -b 100 -d foo https://localhost:8443/httpbin/post

Do we need this as two commits? Just squash it I think, makes cherry-picking easier.

Testing a second build, for other reasons :) [approve ci]

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/237/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/251/

FreeBSD11 build failed! https://ci.trafficserver.apache.org/job/freebsd-github/1932/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/233/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/362/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1824/

clang-analyzer build failed! https://ci.trafficserver.apache.org/job/clang-analyzer-github/495/

squashed :)

clang format successful! https://ci.trafficserver.apache.org/job/clang-format-github/238/

RAT check successful! https://ci.trafficserver.apache.org/job/RAT-github/252/

AU check failed! https://ci.trafficserver.apache.org/job/autest-github/234/

FreeBSD11 build successful! https://ci.trafficserver.apache.org/job/freebsd-github/1933/

Linux build successful! https://ci.trafficserver.apache.org/job/linux-github/1825/

Intel CC build successful! https://ci.trafficserver.apache.org/job/icc-github/363/

clang-analyzer build failed! https://ci.trafficserver.apache.org/job/clang-analyzer-github/496/

Tested and it is working.

We are observing a similar corruption on our POST request bodies right now and seems to happen on only Safari clients running 10.12.2. I wonder if Safari or CFNetwork changed H2 padding behavior.


Updated logic to continue keys loading even if key is not in the list…

… as it could be deleted from the BE

Can someone review this PR? @kristank (from https://github.com/eu-digital-green-certificates/dgca-verifier-service/issues/82) e.g.?

Hello,
@dslmeinte
At this time I do not have access to the whole stack (build environment for android app, ability to prepare test cases on dgca-verifier-service, ...) so I cannot  reliably verify the change, but after examining the change in android code I think this would work.
I would still recommend to evaluate if this is the proper way to fix this issue. I think this should be fixed in dgca-verifier-service (I reported the error in that service, link to the issue https://github.com/eu-digital-green-certificates/dgca-verifier-service/issues/82), because the root of the problem (at least the way I see it, I can be wrong) is two methods of the service returns inconsistent data (details in the linked issue), instead of fixing the android, ios and every other clients that are using the dgca-verifier-service data. And deploying the fix to the service is much "easier" than each user upgrading the mobile app.
I hope this helps. If I can be of any other assistance, please let me know.

@SchulzeStTSI @MykhailoNester Can you have a look at this again?


Fix ASHP min allowable size enforcement

Addresses https://github.com/NREL/REopt.jl/issues/448

Hey Alex, this is more of a question from the original PR than this fix, but it looks like there's a couple of places where we have default values hard-coded in various places which seem redundant to defaults which are either stored in the ashp_defaults.json file or in other locations in /core/ashp.jl:
This peak_load_thermal_factor looks like it's meant to be the same value as the min_allowable_peak_capacity_fraction:
https://github.com/NREL/REopt.jl/blob/452a7175f430b84f8a6bb436dd64144c8652a1a6/src/core/ashp.jl#L498
And this default for the value of back_up_temp_threshold_degF for this function: https://github.com/NREL/REopt.jl/blob/452a7175f430b84f8a6bb436dd64144c8652a1a6/src/core/ashp.jl#L447
Not a big deal, but ideally we would only have to make changes to the default values in one place in the future. If you want to punt on updating for now, maybe we could at least make a comment for the first time these parameters are assigned the default value that if the default changes, you also need to update in these other locations.

Hey Alex, this is more of a question from the original PR than this fix, but it looks like there's a couple of places where we have default values hard-coded in various places which seem redundant to defaults which are either stored in the ashp_defaults.json file or in other locations in /core/ashp.jl:
This peak_load_thermal_factor looks like it's meant to be the same value as the min_allowable_peak_capacity_fraction:
https://github.com/NREL/REopt.jl/blob/452a7175f430b84f8a6bb436dd64144c8652a1a6/src/core/ashp.jl#L498
And this default for the value of back_up_temp_threshold_degF for this function:
https://github.com/NREL/REopt.jl/blob/452a7175f430b84f8a6bb436dd64144c8652a1a6/src/core/ashp.jl#L447
Not a big deal, but ideally we would only have to make changes to the default values in one place in the future. If you want to punt on updating for now, maybe we could at least make a comment for the first time these parameters are assigned the default value that if the default changes, you also need to update in these other locations.

Thanks @Bill-Becker! I agree, we should not have these defaults in place within the function definition - they should be in one place.  I've pushed an update that should remove then and a fix to some tests that were previously incomplete.  Neither function exports to the API so it shouldn't be a breaking change.  I'll merge once I've confirmed tests pass.


How to install plugins!!

Such as editor plugins : Emmet!! ,jsformat l
theme !!!
thanks~~

In the top menu, go to View > Command Palette.... Now type "ext" and select the first option which should be Extensions: Install Extension. You can now search the Gallery for an extension by name or simply "theme" to search themes.
I do agree that a menu entry to go directly to this extension search mode would be a bit more intuitive but feature requests seem to be directed to VS Code's UserVoice here: https://visualstudio.uservoice.com/forums/293070-visual-studio-code
Here's some docs on the matter:

Installing themes from Extensions Gallery: https://code.visualstudio.com/docs/customization/themes#_adding-themes-from-the-extension-gallery
Extension Docs: https://code.visualstudio.com/docs/customization/themes


Change RpcMockTestCase to forward to the real service when no mock is su...

...pplied for the current rpc function

LGTM


package noto-fonts-cjk-sans not installable

Describe the bug
All attempts to install this package error out
Steps To Reproduce
Steps to reproduce the behavior:
nix-env -iA nixos.noto-fonts-cjk-sans
error: attribute 'noto-fonts-cjk-sans' in selection path
'nixos.noto-fonts-cjk-sans' not found
Expected behavior
Package should install per the instructions on
https://search.nixos.org/packages?channel=22.05&show=noto-fonts-cjk-sans&from=0&size=50&sort=relevance&type=packages&query=cjk
Additional context
Trying to install in configuration.txt fails in the same way.
Notify maintainers
Mathnerd314<EMAIL_ADDRESS>Emily<EMAIL_ADDRESS>Metadata

system: "x86_64-linux"
host os: Linux 5.10.126, NixOS, 21.11 (Porcupine)
multi-user?: yes
sandbox: yes
version: nix-env (Nix) 2.3.16
channels(root): "nixos-21.11.337973.511f6a5c324"
nixpkgs: /nix/var/nix/profiles/per-user/root/channels/nixos

[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
same as above

NixOS 21.11 is EOL. The instructions you followed is for 22.05.
To upgrade NixOS, see https://nixos.org/manual/nixos/unstable/index.html#sec-upgrading

Spot on, thanks, that fixed it. As a new NixOS user I was somehow under the impression that NixOS was a rolling distribution. I stand corrected.....

Spot on, thanks, that fixed it. As a new NixOS user I was somehow under the impression that NixOS was a rolling distribution. I stand corrected.....

There are also rolling channels, e.g. nixos-unstable. See differences between nix channels.