Docs: Validation jmespath functions link

What were you searching in the docs?
Searching for validation,
events or responses that contain non-encoded JSON, where  decoding before validating is needed.
Is this related to an existing documentation section?
https://awslabs.github.io/aws-lambda-powertools-python/2.4.0/utilities/validation/#built-in-jmespath-functions
How can we improve?
The Link https://awslabs.github.io/utilities/jmespath_functions
responses back as page not found .
So the correct link is needed to designate the reader to right direction.
Got a suggestion in mind?
I think that this link has the potential to be the correct one: https://awslabs.github.io/aws-lambda-powertools-python/2.4.0/utilities/jmespath_functions/
Acknowledgment

[X] I understand the final update might be different from my proposed suggestion, or refused.

Ugh, another doc we haven't managed to refactor it yet completely - thank you so much for flagging that @niko-achilles ;)
Sending a fix shortly

Just rebuilt the latest docs with the fix ;) Thank you again Niko for helping us improve everyone's experience.
https://awslabs.github.io/aws-lambda-powertools-python/2.4.0/utilities/validation/#validating-custom-formats


[NEW ALGORITHM] KADANE algorithm to find the maximum subarray sum in a given array

Issue will be closed if:

You mention more than one algorithm. You can create a separate issue for each algorithm once the current one is completed.
You propose an algorithm that is already present or has been mentioned in a previous issue.
You create a new issue without completing your previous issue.

Note: These actions will be taken seriously. Failure to follow the guidelines may result in the immediate closure of your issue.

Name:
[NEW ALGORITHM]
About:
Propose a new algorithm to be added to the repository

Labels:
new algorithm, gssoc-ext, hacktoberfest, level1

Assignees:

[x] Contributor in GSSoC-ext
[x] Want to work on it

please allow me to work on this algorithm.


Not possible on existing notes?

Hi again,
I don't see a way of making the plugin add the PDF text to existing notes. Is there one?
If no, would it be difficult to add?
The could be handled with two tags:
one tag which you assign to your note(s) when you want the plugin to work on your existing note(s),
and one tag which the plugin would assign itself to a note when it has finished its work (and remove the first tag)
you could default the two tags to "athena_work" and "athena_finished" and/or make them editable in the settings of the plugin
The plugin could check your notes regularly if it finds any notes with the "athena_work" (or whatever) tag and if it does, process the found notes. Or alternatively, You could create a menu entry to make the plugin process the notes. I had a rough look at your code. Wouldn't that process be a bit similar to the migration code from V1 to V2?
Kind Regards,
Nadine (also from Germany btw :-) )

Ok that is a new requirement.
I do not considered this so far but could be possible.
To clarify the idea is I do have a note and start the import of any file to a note or the other way I have a note with a pdf attached ( with text ) and the new feature add the text and meta data at the end of the note?
Best regards Sebastian

Hi Sebastian,
Thanks for asking for the clarification.
I want to use it on existing notes which already have a PDF (with text)
attached, and I would like to add the PDF text to the end of the note.
Nadine
Sebastian @.***> schrieb am Fr., 16. Dez. 2022, 20:14:

Ok that is a new requirement.
I do not considered this so far but could be possible.
To clarify the idea is I do have a note and start the import of any file
to a note or the other way I have a note with a pdf attached ( with text )
and the new feature add the text and meta data at the end of the note?
Best regards Sebastian
—
Reply to this email directly, view it on GitHub
https://github.com/makaanneo/joplin-plugin-athena/issues/12#issuecomment-1355454828,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGBFCOU4MCNF2Y4NLKPMVRTWNS5QDANCNFSM6AAAAAATAFN72I
.
You are receiving this because you authored the thread.Message ID:
@.***>

Additional info: My use case for this functionality is the migration of my
notes from Evernote to Joplin. I have already all these notes with PDF
attachments (exported from Evernote in ENEX format and imported into
Joplin). Evernote was able to search the PDF contents on its own, but
Joplin isn't, so I need to add the PDF text to the notes.
Nadine Brinkmann @.***> schrieb am So., 18. Dez.
2022, 01:25:

Hi Sebastian,
Thanks for asking for the clarification.
I want to use it on existing notes which already have a PDF (with text)
attached, and I would like to add the PDF text to the end of the note.
Nadine
Sebastian @.***> schrieb am Fr., 16. Dez. 2022, 20:14:

Ok that is a new requirement.
I do not considered this so far but could be possible.
To clarify the idea is I do have a note and start the import of any file
to a note or the other way I have a note with a pdf attached ( with text )
and the new feature add the text and meta data at the end of the note?
Best regards Sebastian
—
Reply to this email directly, view it on GitHub
https://github.com/makaanneo/joplin-plugin-athena/issues/12#issuecomment-1355454828,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AGBFCOU4MCNF2Y4NLKPMVRTWNS5QDANCNFSM6AAAAAATAFN72I
.
You are receiving this because you authored the thread.Message ID:
@.***>

Hi Nadine,
ok, yes, I am on it, take a while ... may this week.
May in the future to search in PDFs content will be built into Joplin.
I take some assumption:

a Note has more than one resource attached (any type)
the feature will create the metadata block (with content) for each resource.
The function will be useable similar to the migrate feature

Best
Regards
Sebastian

Great! Thanks a lot! 👍 😃

@EnidanBri I did some work a new version is there (2.2.0) may it will take some time to see it in Joplin plugin overview.


Problem: Hare miniprovisioner init, test section uses hardcoded path for CDF file, also arguments like '--config' or '--init' should be just 'config' and 'init' respectively

I have addressed https://github.com/Seagate/cortx-hare/issues/1482 and https://jts.seagate.com/browse/EOS-17172
Solution: Support added for init and test to take cdf file path as input and modified code to use sub-commands to handle miniprovisioner related commands

@knekrasov @mssawant Please review

@mssawant @knekrasov I have done code changes related to #1482.
Please review.

@mssawant @knekrasov Please have a look

Just a minor comment, no further review is required. Kindly rebase and resolve the conflicts then we can merge.
Thank you.

@mssawant I have done rebase.


Fix readOnly argument

@aidy thank you for the PR and I'm sorry for late reply. Could you rebase this branch?

@jewertow Done

@aidy Thank you for this PR. What issue does it solve? (I'd like to file it in our Jira)

/ok-to-test


FIX 7262: ckdtree crashes in query_knn.

This was because a loosen check on j >= 0 in the branches. The loop
was not carefully written. It has been replaced with a version that
is easier to understand.
Also added the docstring warning that if k is not sorted the result
is undefined. We can worry about adding a sorting wrapper in cython
later if there is a demand.
This fixes #7262

I am not sure I understand the purpose of all these checks. In the original code that @aarchiba  and I wrote we had this:
/* fill output arrays with sorted neighbors */
    for (i=neighbors.n-1; i>=0; --i) {
        neighbor = neighbors.pop();
        result_indices[i] = neighbor.contents.intdata;
        if (NPY_LIKELY(p == 2.0))
            result_distances[i] = std::sqrt(-neighbor.priority);
        else if ((p == 1.) || (p == infinity))
            result_distances[i] = -neighbor.priority;
        else
            result_distances[i] = std::pow((-neighbor.priority),(1./p));
    }

The heap is already sorted, so we just needed to pop them off. What has changed?

Why not do something like this?
It should also avoid undefined results if the list k of neighbor indices is unsorted.
    /* heapsort */
    std::vector<heapitem> sorted_neighbors(kmax);
    npy_intp j = 0;
    for(i = neighbors.n - 1; i >=0; --i) {
        sorted_neighbors[j++] = neighbors.pop();
    }

    /* fill output arrays with sorted neighbors */
    for (i = 0; i < nk; ++i) {
        neighbor = sorted_neighbors[k[i] - 1];
        result_indices[i] = neighbor.contents.intdata;
        if (NPY_LIKELY(p == 2.0))
            result_distances[i] = std::sqrt(-neighbor.priority);
        else if ((p == 1.) || (ckdtree_isinf(p)))
            result_distances[i] = -neighbor.priority;
        else
            result_distances[i] = std::pow((-neighbor.priority),(1./p));
    }

Yes. It is cleaner. We still want to check if k[i] is greater than neighbours.n. The current undefined values are defined in cython. Shall we move them here?

Shall I run valgrind on the entire test suite?

Something like this?
    /* heapsort */
    std::vector<heapitem> sorted_neighbors;
    sorted_neighbors.reserve(kmax)
    for(i = neighbors.n - 1; i >=0; --i) {
        sorted_neighbors.push_back(neighbors.pop());
    }

    /* fill output arrays with sorted neighbors */
    for (i = 0; i < nk; ++i) {
        const npy_intp j = k[i];
        if (j > sorted_neighbors.size()) continue; /* missing neighbor */
        neighbor = sorted_neighbors[j - 1];
        result_indices[i] = neighbor.contents.intdata;
        if (NPY_LIKELY(p == 2.0))
            result_distances[i] = std::sqrt(-neighbor.priority);
        else if ((p == 1.) || (ckdtree_isinf(p)))
            result_distances[i] = -neighbor.priority;
        else
            result_distances[i] = std::pow((-neighbor.priority),(1./p));
    }

The "missing neighbor" values are prefilled in Cython, so we can just ignore them in C++ I guess.

Well I moved the handling to C++, since we have to do a branching there anyways.

Wasn't clear to me from reading gh-7262 if this needs a backport to 0.19.x?

Judging from the code, the bug is in 0.19.x as well. It was the introduction of a list of k values that did this.
@rainwoodman needs to address my two comments before this can be merged. I.e. remove the typo line from the docstring and add an ``NPY_UNLIKELY``` at the final branch.

@rgommers Change the label to defect. This is a bug.

Looks good. Time to merge and backport?

Yes. I am all in to get this bug fixed sooner than later since I introduced it.
Valgrind was green on my computer.
Is it possible set up a valgrind test on travis to catch this sort of bugs? We can focus on the modules that are mostly written in C/C++ to speed it up.

Looks good. Time to merge and backport?

Allright, in it goes. Thanks @rainwoodman, @sturlamolden

Change the label to defect. This is a bug.

This is the regular labeling - the issue gets labelled "defect" and the PR "maintenance".
Added the backport label as well. Will get onto that soon.


Conflicting 'Set-OrganizationConfig' advice

This assertion:

If you run the Set-OrganizationConfig -AutoExpandingArchive command to enable auto-expanding archiving for your organization, you don't have to run the Enable-Mailbox -AutoExpandingArchive on individual mailboxes.

Seems to conflict with this statement:

Running the Set-OrganizationConfig cmdlet to enable auto-expanding archiving for your organization doesn't change the AutoExpandingArchiveEnabled property on user mailboxes to True.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6a7c1600-c310-fb7f-7976-2025ee9256f3
Version Independent ID: 9241081b-eabb-78a8-af86-2c0f27e7e671
Content: Enable unlimited archiving — Admin Help - Microsoft 365 Compliance
Content Source: microsoft-365/compliance/enable-unlimited-archiving.md
Service: o365-seccomp
GitHub Login: @markjjo
Microsoft Alias: markjjo

@ntw2 The point the second statement is trying to make is if you enable auto-expanding archiving for your entire org, the setting on the mailbox is ignored (in otherwords, the mailbox property isn't set to True). So if AutoExpandingArchive  is set to True for the org, it's enabled for all mailboxes, auto-expanding archiving is enabled even if the AutoExpandArchive mailbox property (Get-Mailbox | FL AutoExpandArchive) equals False. Please submit a PR with any suggested change to make this clearer.


Questions about configuring kube-scheduler in "Scheduler Configuration" section

Hello, I've been learning Kubernetes for a while and recently wanted to implement a custom scheduler.
And there're 4 ways to achieve:

clone and modify source code
run a separate scheduler along with default scheduler
scheduler extender
scheduling framework (recommend)

When I'm working on the 4th method, I find Scheduler Configuration. It says:

For each extension point, you could disable specific default plugins or enable your own. For example:

kind: KubeSchedulerConfiguration
profiles:
  - plugins:
      score:
        disabled:
        - name: NodeResourcesLeastAllocated
        enabled:
        - name: MyCustomPluginA
          weight: 2
        - name: MyCustomPluginB
          weight: 1

This means we can use default plugins or plugins implemented by ourselves to configure different stages of scheduling in the kube-scheduler. In the code snippet above, a default plugins is disabled and two custom plugins are enabled during score extension point.
However, I searched a lot but failed to find any ways to implement a plugin, which can configure the default scheduler. Is there any ways to achieve this? Thanks : )

I know that the common way is to use Scheduling Framework to write a custom scheduler, and register some plugins on extension points.
Following is an example: (comes from this repo)
    kind: KubeSchedulerConfiguration
    profiles:
      - plugins:
          filter:
            enabled:
              - name: yoda
                weight: 0
          score:
            enabled:
              - name: yoda
                weight: 300
        schedulerName: yoda-scheduler2

The author use Scheduling Framework to write a scheduler called "yoda-scheduler2", and register a plugin called "yoda" on filter and score extension point to achieve custom schedule logic.
Implementing a scheduler by myself would be more flexible, but I'm wondering whether it is feasible to implement a plugin and use it to control the scheduling process of the default scheduler?

@Alpenbelieve , GitHub is not the right place for support requests.
You can instead post your question on the Kubernetes Slack or the Discuss Kubernetes forum.
Another options is Stack Overflow.
/kind support

@sftim Thank you for your suggestions. And I find there's a blog which may be helpful. It requires us to modify main() method and build kube-scheduler.


Error saving new config

HAPROXY-WI v3.4 with HAPROXY 1.8.4
When saving a new config, I got the following error on the web page:
Some errors: sudo: haproxy: command not found
In the Apache error log:
[Mon Dec 10 10:43:52.676596 2018] [cgi:error] [pid 6116] [client xx.xx.xx.xx:30195] AH01215: dos2unix: converting file /var/www/haproxy-wi/configs/hap_config/<IP_ADDRESS>-2018-12-10.09:43:51.cfg to Unix format ..., referer: http://s-eacea-rh7-haproxywi:8080/app/config.py?serv=yy.yy.yy.yy&open=open
Can you please help?

See https://github.com/Aidaho12/haproxy-wi/issues/80


oldest_cpu: Bottling architecture of ARM is armv6

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew tests with your changes locally?

This PR is required for brew portable-bottle ruby on 32-bit ARM.

armv6 is the oldest supported 32-bit ARM architecture
armv8-a is the oldest 64-bit ARM architecture.
See https://gcc.gnu.org/onlinedocs/gcc/ARM-Options.html
and https://gcc.gnu.org/onlinedocs/gcc/AArch64-Options.html

Thanks again @sjackman!

No worries at all. Thanks for the quick merge, Mike!


Required changes for the repo rename

Changed all the import lines from,
'github.com/monstorak/monstorak/' to 'github.com/monstorak/monstorak-operator'
in order to reflect the github repo name change.
Signed-off-by: aruniiird<EMAIL_ADDRESS>

This is a pure rename of all files containing 'monstorak/monstorak/' import lines.


An error  with your deployment FUNCTION INVOCATION TIMEOLJT

when deployed on vercel. I encounter error popup "An error  with your deployment FUNCTION INVOCATION TIMEOLJT" after two conversation round.  please fix it. Thanks.

This error is caused by the timeout of Vercel serverless function: https://vercel.com/guides/what-can-i-do-about-vercel-serverless-functions-timing-out

You can reduce the size of the uploaded file. If your upload time exceeds 10 seconds, it will trigger the Vercel timeout limit, or you can upgrade to Vercel Pro to increase the timeout to 30s.

我是在上传时没有报错，对话时弹窗报错，supabase的向量也保存成功了。就很奇怪。


Not able to install any version of SIFT into WSL

I'm following option 2B to install SIFT into WSL:
https://www.sans.org/tools/sift-workstation/
I'm seeing an issue with the install where the hashes are not matching:
Error: Hashes for sift-saltstack-v2022.01.22.tar.gz do not match. Expected: 12d4be3e4b31690c17ed7675b11540c77b25d1c8b5a1bd5a8a15122f51984b9e  /tmp/sift-saltstack-v2022.01.22.tar.gz
, Actual: 965fec26ed59639aef325526e0f27e65c20c68d431abbe9b1b1acdc9fad0d139  /tmp/sift-saltstack-v2022.01.22.tar.gz

What's odd is that I've manually downloaded the tar.gz file from 3 different systems and on all 3 systems, the sha256sum I see matches the "Actual" version not the "Expected".
I repeated this step for every version in 2021-2022 and experienced the same result. Namely, sift-cli installer errors due to hash mismatches. However, when I inspect the hash manually (on 3 systems on 3 different networks), I see the Actual hash reported and not the Expected.

Hi @wilczekj , are you perhaps operating behind a proxy or appliance which could interfere with unauthorized file types (ie antivirus appliance of the like)?
This is the most common reason for the hashes not matching, as the file may be incomplete or blocked from completing a successful download.
If you are operating behind a proxy, can you retry the process by either adding an exception or pass thru, or try it on a machine not behind the proxy?

Hello @digitalsleuth. I understand the issues that could be caused by proxies or other inline network appliances. However, I tested the download from 3 different locations, 3 different networks and none are behind a proxy or any appliance that could inspect/modify the traffic.

There is a known issue currently with GitHub archives not matching hashes. They are rolling back the change.

Hi @wilczekj , I've confirmed the hash value for the release on several machines and devices and they all come back with the expected value.
Can you tell me which version of the CLI you're using to install? Also, could it be possible you're experiencing network connectivity issues? One hash failure would be reasonable, but for your downloads to be the wrong hash from that many different machines seems extraordinary.
The releases are all hashed and signed prior to upload, then the CLI pulls down the release and signature and compares the download to the signature. It would be one thing for the CLI to fail, but I fear there may be a system or network issue at play here.

@digitalsleuth did you see the response from @ekristen ?
I'm using the latest version of the CLI v1.14.0-rc1
I don't think there was any way its network connectivity related. Three different networks, three different computers, two different time zones all experiencing network connectivity issues at the roughly same time? All three reporting the EXACT same hash of the tar.gz downloaded (which didn't match)?

No I hadn't seen it. The post just came in on my phone with your reply just now. Since there is an issue on GitHub's end, that makes much more sense.

I think this was all related to the GitHub Archive issue. Please also note that sift-cli is being deprecated in favor of cast once https://github.com/teamdfir/sift-saltstack/pull/80 is closed.


Why do some RV.rvs(1) functions return arrays while others return floats?

Is this intended behavior?
Reproducing code example:
>>> scipy.stats.norm().rvs(1), scipy.stats.multivariate_normal().rvs(1)
array, float

Scipy/Numpy/Python version information:
1.4.1 1.18.1 sys.version_info(major=3, minor=7, micro=6, releaselevel='final', serial=0)

Both return arrays for me on scipy 1.4.1.
[~]
|12> import scipy

[~]
|13> scipy.__version__
'1.4.1'

[~]
|14> from scipy import stats

[~]
|15> stats.norm().rvs(1)
array([-1.23192364])

[~]
|16> stats.norm().rvs(1)
array([-0.17702427])

Can you copy-and-paste the precise inputs and outputs that demonstrate the behavior?

If you saw a previous comment from me hit your inbox, please ignore it, as it was complete nonsense that I've deleted.
multivariate_normal, being a multivariate distribution, implements a lot of the same interface of the univariate distributions, but doesn't actually share much implementation with them. As such, the logic for determining the shape of the output of an rvs() draw is a little different. In particular, it squeezes the shape of the output (i.e. dropping any part of the shape that is 1), I assume to get the effect of returning an N-vector when just rvs() (no size argument) is called. This would be to match the behavior of norm.rvs() (again, no size argument), which returns a scalar. However, the implementer of multivariate_normal didn't take into account the case where the user explicitly requested size=1, which should return an array of length 1 with the contents of a single draw to be consistent with the behavior of the univariate distributions, in my opinion. I would consider this a bug, but perhaps one that will have to be lived with since it's been in the wild for so long.

Thanks for that thorough look through, @rkern. I hadn't realized I could do .rvs() instead of '.rvs(1)so I'll switch to that (instead of.rvs(1)[0]fornorm()`)
Just to provide more context, the issue that brought me here was actually the following:
>>> A = scipy.stats.norm()
>>> B = scipy.stats.multivariate_normal(np.zeros(5), np.eye(5))

>>> a = A.rvs(1)
>>> b = B.rvs(1)

>>> A.pdf(a), B.pdf(b)
array, float

Thanks for reporting this @alexlenail. It looks like this answered your question. Would you consider the issue closed or would you like us to change something in a backwards compatible way (e.g. mention in documentation)?

@mdhaber I'm satisfied as is. @rkern ?

OK, thanks @alexlenail. It sounded to me like @rkern thought we would need to live with this, so I'll close. If someone thinks this deserves more discussion, please re-open and add the "need-decision" label.


use random_state and not random seed for reproducibility

it looks like we use random state:
https://github.com/jonescompneurolab/hnn-core/blob/08daf2024467b46e4efc447efd935645b4fd0aca/hnn_core/drives.py#L173
so closing


Firebase: How to create an ID field with the same key?

Hello,
I would like to have a field called ID with the same value as the key, how could I do this?

my react-native code:

@dzucchi
You can get the key of the pushed item before it is actually written using .push() (passing no object):
const snap = db.ref(`/users/${currentUser.uid}/series`).push();
const key = snap.key;
serie.id = key;
await snap.ref.set(serie);

@dzucchi
You can get the key of the pushed item before it is actually written using .push() (passing no object):
const snap = db.ref(`/users/${currentUser.uid}/series`).push();
const key = snap.key;
serie.id = key;
await snap.ref.set(serie);

Thankss.


Cleanup various repository documentation files

Reformat logo license as a plain text file.
Fix outdated links or references to SFC or Visual Script.
Tweak contents of CONTRIBUTING.md to highlight contributor docs more prominently, and make it easier to parse.
Tweak formatting and contents in thirdparty/README.md for consistency.

Fixes #82495.
Supersedes #82989.
Supersedes #83073.
Supersedes #83090.
This docs PR should be merged alongside: https://github.com/godotengine/godot-docs/pull/8215

Can we add a line about updating to the latest version to the reporting section?
Because been quite a few bug reports from 4.1.0 for bugs solved in 4.1.1 already


dataset pull

Sometimes, when the internet connection fails, the dataset is not pulled properly. A more robust implementation is needed.

This issue still needs to be properly reproduced


Can't figure out how to block flow until certain action is fired

Can someone tell me where my mistake is? It would be much appreciated :)
I would like to wait for an active socket connection (SOCKET_ON) before anything else is triggered:
function* waitForSocketConnection() {
  yield take(SOCKET_ON);
  yield all([
    fork(initChannelDelta),
    fork(initChannelFull),
    takeEvery(REQUEST_ITEMS, requestItems),
  ]);
}

export default function* rootSaga() {
  yield all([
    fork(waitForSocketConnection),
    takeEvery(REQUEST_SOCKET, requestSocket),
  ]);
}

But the order is:
REQUEST_SOCKET
START_CHANNEL_DELTA
RECEIVE_SOCKET
SOCKET_ON

I would expect START_CHANNEL_DELTA after SOCKET_ON.

I think what you need is call effect.  You can use yield call(waitForSocketConnection) in your rootSaga.
By the way, using fork or takeEvery inside all makes no sense. You can just do as follows:
-yield all([
-  fork(initChannelDelta),
-  fork(initChannelFull),
-  takeEvery(REQUEST_ITEMS, requestItems),
-]);
+yield fork(initChannelDelta)
+yield fork(initChannelFull)
+yield takeEvery(REQUEST_ITEMS, requestItems)

I changed it now to:
function* waitForSocketConnection() {
  yield take(SOCKET_ON);

  fork(initChannelDelta);
  fork(initChannelFull);

  takeEvery(REQUEST_ITEMS, requestItems);
}

export default function* rootSaga() {
  yield all([
    call(waitForSocketConnection),
    takeEvery(REQUEST_SOCKET, requestSocket),
  ]);
}

I figured it out, it was a brain fart on my site.


Refactor (partly discussed in lecture + other minor things)

Coverage remained the same at 100.0% when pulling 06b782086eae43dba4c657a193cb8672ffc8d753 on refactor into c373007dca57e622b4cc877c357352fc4d082282 on dev.

Coverage remained the same at 100.0% when pulling 8ca2af629f4e98e9a0d50d272ca42027eea49459 on refactor into 910150e6fa9ae89c7b7e500e033222f6ba3773fd on dev.

Coverage remained the same at 100.0% when pulling 46720d4710cc31ed8cd371785e1b9e4db966491d on refactor into 168a4ce05b0301a51be9442902e29d18fa75c742 on dev.


Search: Search doesn't show results on master

Oni Version: 0.3.7 (master)
Operating System: Windows
Issue:
Search functionality doesn't seem to be working on master. When I run a search over Oni, I get a quick spinner in the sidebar and then no results show up.
Steps to reproduce:

Build master build of Oni
Open the search pane with Control+Shift+f
Type 'Neovim'

Expected: Should see search results
Actual: No search results are displayed

It looks like this code that was responsible for it in src/Services/Search/index.ts was removed:
        query.onSearchCompleted.subscribe(result => {
            this._onSearchCompleted.dispatch()
            const visualizer = new QuickFixSearchResultsViewer(this._editorManager)	                this._onSearchCompleted.dispatch()
            visualizer.showResult(result)

As part of this commit of the new find-in-files functionality.
@TalAmuyal - should we have an alternate way to bubble up search results in this case? Or does it make sense to just remove the search pane and pivot to your new strategy on master?

(cc @jonasws)

Assigned myself.

Should be fixed now in master (see #2489).


[FLINK-6695] Activate strict checkstyle in flink-contrib

This PR activates the strict checkstyle for most modules in flink-contrib; flink-tweet-inputformat is not included due to proposal to remove it in FLINK-6710.

@greghogan fixed.

@greghogan fixed.

@greghogan did another attempt at fixing the issues.

+1!

YES! :D merging this.


clippy fixes

Description of changes
Automatically applied clippy fixes
Issue #, if available
Checklist for requesting a review
The change in this PR is (choose one, and delete the other options):

[x] A change "invisible" to users (e.g., documentation, changes to "internal" crates like cedar-policy-core, cedar-validator, etc.)

I confirm that this PR (choose one, and delete the other options):

[x] Does not update the CHANGELOG because my change does not significantly impact released code.

I confirm that cedar-spec (choose one, and delete the other options):

[x] Does not require updates because my change does not impact the Cedar Dafny model or DRT infrastructure.

Disclaimer
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

It seems the CedarJava failure is caused by this change: https://github.com/cedar-policy/cedar/actions/runs/7465002067/job/20313236263?pr=577

Nvm, the issue is a property test that will fail non-deterministically (as Victor noticed here: https://github.com/cedar-policy/cedar-java/pull/72#discussion_r1437156141). Unrelated to this PR.


[Feature Request]: Server-to-Client Waypoint Marking with Custom Text Descriptions

Hey, can you add a feature that will bring sending pings with custom texts? To mark server side locations like spawn, npc, etc.

Hey, I understand your request as some sort of waypoint system, which I was not planning to implement since there are mods that do a really good job on that. Please elaborate on the functionality you are thinking of in terms of "custom text pings".

What mods are you thinking about? I meant for example marking a boss for all players.

For waypoints I'm thinking of minimap mods such as Xaero's. Can you explain how you expect to ping a boss differently from the current ping system? I don't understand the idea with custom text.

Server -> client waypoints? Marking server side location with a text, then sending them to client, after joining a world, dynamically etc.

I totally get where you're coming from!
This feature seems very fitting for client-side waypoint mods. They could integrate server-side waypoints like the Points of Interest from Bluemap for example.
However, this concept doesn't seem to fit with the purpose of Ping Wheel, which is aimed towards temporary, on-the-fly communication rather than persistent map features.

So there's no mod for that and you don't want to add that? :/

Really sorry, but I just feel like this belongs more into other mods. I am not sure if the functionality exists in another mod... I just know of the afforementioned server/client map mods

Would be nice, but if you say so


fix(deps): pin dependencies

This PR contains the following updates:

Package
Type
Update
Change

@semantic-release/changelog
dependencies
pin
^6.0.1 -> 6.0.1

@semantic-release/exec
dependencies
pin
^6.0.3 -> 6.0.3

@semantic-release/git
dependencies
pin
^10.0.1 -> 10.0.1

@semantic-release/github
dependencies
pin
^8.0.4 -> 8.0.4

Add the preset :preserveSemverRanges to your config if you don't want to pin your dependencies.

Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

[ ] If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

:tada: This PR is included in version 1.0.5 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


webmachine style content_types_accepted

this patch changes content_types_accepted to accept webmachine style mimetypes (<<"text/plain">>, <<"application/json">>, ...).
i've changed parsing to use the cowboy_http:content_type and removed the try/catch. failure mode is now idiomatic for REST handlers.

Merged, thanks!


Unclear default values

A user asked on the default value of is_cluster_definer. The db schema says NULL; I guess we should either change this to FALSE or find another solution to point out defaults
https://github.com/INTERPOL-Innovation-Centre/TagPackConverters/issues/30

Additionally, an update to the documentation https://github.com/graphsense/graphsense-tagpacks/wiki/GraphSense-TagPacks#mapping-attribution-tags-to-utxo-clusters

I have updated the documentation, see revision 6 (https://github.com/graphsense/graphsense-tagpacks/wiki/GraphSense-TagPacks/1da6e77650c4fe5bc4d70d6ea151dccde6d9c161)

Thanks, I have also added my notes from our discussion to the wiki. If @behas is also content with the documentation, we can close this issue.
https://github.com/graphsense/graphsense-tagpacks/wiki/GraphSense-TagPacks#mapping-attribution-tags-to-utxo-clusters


Add tabokie.github.io

Important: Please read all instructions carefully.
Select the appropriate category for what this PR is about
This PR is:

[x] Adding a new domain
[ ] Updating existing domain size
[ ] Changing domain name
[ ] Removing existing domain from list
[ ] Website code changes (512kb.club site)
[ ] Other not listed

Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

[x] I used the uncompressed size of the site
[x] I have included a link to the GTMetrix report
[x] The domain is in the correct alphabetical order
[x] This site is not a ultra lightweight site
[x] The following information is filled identical to the data file

- domain: tabokie.github.io
  url: https://tabokie.github.io/
  size: 164
  last_checked: 2022-01-30

GTMetrix Report: https://gtmetrix.com/reports/tabokie.github.io/IsgJosq1/

Qualifies as ultra-minimal/link only page. Won't be merging.


SDK add same header and footer as .com + GH stars

as discussed in the leadership call we agreed to look into adding consistent heads across all our web entities (.com, sdk, hub, docs, maybe handbook).
Why do this:

User experience
No dead ends- lost opportunity
Consistency + branding
Give people a clearer picture of the Meltano ecosystem

My suggestion would be to start by just adding the header and footer from the .com pages (above) if that is even possible. If this is not possible, I would create a paired-down version for this purpose.
Must haves at a min:

always linking back to home page
always has star us- link to github
slack link
social links are a nice to have

https://github.com/meltano/hub/issues/709

https://github.com/meltano/internal-general/issues/436

@aaronsteers @alexmarple related to the other header/footer one - what's the complexity on this? It's a completely different theme but we still want some consistency.

@tayloramurphy and @emilylucie - I think this is relatively low complexity (probably a4 weight) but there's too much left missing in the spec, which we need to resolve before we start.
The header has things that don't really make sense for the SDK site and the Footer likewise feels odd for the SDK context.

E.g. - if we replace "Hub" with "SDK", does this meet requirements for footer?

For the header, should we start with what we have in https://docs.meltano.com below and remove all the headers (that would be, removing Home  |  Guides  |  Concepts  |  Tutorials  |  Reference  |  Contribute  |  Get Help - since all of those titles have an incorrect inference of where they would land releative to the SDK.)

Removing all the headers seems to leave the rest quite bare - and might not be appropriate with the all-blue and same-colored left-hand sidebar.

Another approach that might be less disruptive would be to keep the overall layout we have today...

...

And fit these requirements into the existing layout (adapted from @emilylucie's comment above):

linking back to home page in top-left header
star us-link in top-right (sdk repo though, not meltano, yes?)
slack link in bottom-right footer
social links in bottom-right footer, modeled after Hub footer

@aaronsteers I chatted with @afolson and she'll be taking the Docs and SDK one. So we'll just need to have Alex focus on https://github.com/meltano/hub/issues/709 which, for the most part I think we can do a drop-in of the current state from the main Meltano site and take a few iterations from there.


Short solution needed: "Drop table example" (clickhouse)

Please help us write most modern and shortest code solution for this issue:
Drop table example (technology: clickhouse)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Drop table example


Modify go-mod-core-security to support per-service Vault tokens

Please add to https://github.com/edgexfoundry/edgex-go/projects/13
Changes:

SecretConfig needs to have reasonable, overridable defaults
Ensure that Vault certificate is verified by default
Read an environment variable, VAULT_TOKEN_URL, that contains the URL to that services' Vault token
Any file:// URLs should be handled internally, by reading a JSON file at the indicated path and parsing out the 'token' and 'token_accessor' fields
Start a goroutine that ensures that the Vault token doesn't go stale, since we have no way of reissuing file:// tokens without rebooting
Needs to ensure that the security service is all the way up. (See #1710)

Should this be an issue in go-mod-secrets rather than edgex-go?

If you tell me we can do a cross-project reference in a GitHub project/kanban, then I will move it.  If not the answer is not clear cut and I will just do what I'm told.

Yes -- You can link any number of issues from various repos to issues in a single Kanban board. Here's an example
https://github.com/edgexfoundry/edgex-go/projects/12
As I write this, there are issues from docker-edgex-mongo in In Progress status and issues from go-mod-secrets in Done status.

Moved to https://github.com/edgexfoundry/go-mod-secrets/issues/14


i can't write A a letter

Type: Bug
soo, i am writing code and after sometimes i am not able to write A a letter why? it's showing (A) was pressed. Waiting for a second key of chord... and it also showing this The key combination (A, A) is not a command. Please help me VS Code team please..
VS Code version: Code 1.72.0 (64bbfbf67ada9953918d72e1df2f4d8e537d340e, 2022-10-04T23:20:39.912Z)
OS version: Windows_NT x64 10.0.22000
Modes:
Sandboxed: No

System Info

Item
Value

CPUs
AMD 3020e with Radeon Graphics                  (2 x 1198)

GPU Status
2d_canvas: enabledcanvas_oop_rasterization: disabled_offdirect_rendering_display_compositor: disabled_off_okgpu_compositing: enabledmultiple_raster_threads: disabled_offopengl: enabled_onrasterization: enabledraw_draw: disabled_off_okskia_renderer: enabled_onvideo_decode: enabledvideo_encode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabledwebgpu: disabled_off

Load (avg)
undefined

Memory (System)
3.38GB (0.50GB free)

Process Argv
--crash-reporter-id 12532e9e-c526-4777-9a76-391eadcc06d0

Screen Reader
no

VM
0%

Extensions (29)

Extension
Author (truncated)
Version

bracket-pair-colorizer
Coe
1.0.62

doxdocgen
csc
1.4.0

python-preview
don
0.0.4

vsc-material-theme
Equ
33.5.0

vsc-material-theme-icons
equ
2.4.0

auto-rename-tag
for
0.1.10

code-runner
for
0.11.8

better-cpp-syntax
jef
1.16.1

cmake-language-support-vscode
jos
0.0.4

vscode-language-babel
mgm
0.0.36

vscode-dotnet-runtime
ms-
1.5.0

python
ms-
2022.16.0

vscode-pylance
ms-
2022.10.10

jupyter
ms-
2022.9.1002791758

jupyter-keymap
ms-
1.0.0

jupyter-renderers
ms-
1.0.10

vscode-jupyter-cell-tags
ms-
0.1.6

vscode-jupyter-slideshow
ms-
0.1.5

cmake-tools
ms-
1.12.27

cpptools
ms-
1.12.4

cpptools-extension-pack
ms-
1.3.0

material-icon-theme
PKi
4.21.0

developer-theme-dark
Raj
5.0.0

LiveServer
rit
5.7.9

bootstrap-product-icons
rub
1.0.2

code-spell-checker
str
2.10.1

cmake
twx
0.0.17

vscode-icons
vsc
11.20.0

html-css-class-completion
Zig
1.20.0

(2 theme extensions excluded)

A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythonvspyl392:30443607
vserr242:30382549
pythontb:30283811
vsjup518:30340749
pythonptprofiler:30281270
vshan820:30294714
vstes263:30335439
vscorecescf:30445987
pythondataviewer:30285071
vscod805:30301674
binariesv615:30325510
bridge0708:30335490
bridge0723:30353136
cmake_vspar411:30581797
vsaa593:30376534
pythonvs932:30410667
cppdebug:30492333
vsclangdc:30486549
c4g48928:30535728
dsvsc012cf:30540253
azure-dev_surveyone:30548225
2144e591:30553903
pyindex848cf:30577861
nodejswelcome1cf:30583748
fc301958:30573243

Please check your keyboard shortcuts. You (or one of your extensions) have apparently assigned a two-character shortcut to a command, with A as the first character.

It looks like this is caused by a keybinding you might have defined. To remove all your keybindings, you can click on the gear icon, choose Keyboard Shortcuts, then press the Open Keyboard Shortcuts (JSON) button, and finally comment out all of the keybinding rules you have previously defined. You can then proceed to add back the keybinding rules which you want, uncommenting them:
https://user-images.githubusercontent.com/5047891/194806279-a9c10b8a-61a0-4f86-a9fc-c6884ace0053.mp4

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.
Happy Coding!


Some missing packages

Should either add these packages to the package.json or list them in the README.md as packages you would like to be globally installed.

Thanks Folashade! :+1:


Dependency Injection for base classes

First Check

[X] I added a very descriptive title to this issue.
[X] I used the GitHub search to find a similar issue and didn't find it.
[X] I searched the FastAPI documentation, with the integrated search.
[X] I already searched in Google "How to X in FastAPI" and didn't find any information.
[X] I already read and followed all the tutorial in the docs and didn't find an answer.
[X] I already checked if it is not related to FastAPI but to Pydantic.
[X] I already checked if it is not related to FastAPI but to Swagger UI.
[X] I already checked if it is not related to FastAPI but to ReDoc.

Commit to Help

[X] I commit to help with one of those options 👆

Example Code
# JUST SIMPLE EXAMPLE WITH AFFECTED CLASSES - NO ANY DOMAIN LOGIC PROVIDED

async def connection_factory():
	return 'connection object'

class DBService:
	def __init__(self, connection_factory = Depends(connection_factory)):
		self.conn_factory = connection_factory

	async def get_connection(self):
		return self.conn_factory()

class SimpleServiceOne:
	def __init__(self):
		print('SimpleServiceOne.__init__() called')

class SimpleServiceTwo:
	def __init__(self):
		print('SimpleServiceTwo.__init__() called')

class BaseUserService:
	def __init__(self, db_service: DBService = Depends()) -> None:
		self.db_service = db_service

	async def checkAuth(self, id: int):
		return f'BaseUserService.checkAuth() called'

	async def validateCache(self, id: int):
		return f'BaseUserService.validateCache() called'

class UserService(BaseUserService):
	def __init__(self,
		simple_dep_one: SimpleServiceOne = Depends(),
		simple_dep_two: SimpleServiceTwo = Depends(),
	) -> None:
		super().__init__()

		# this would print: Depends(NoneType)
		# but i expect DBService instance injected for __init__ from the base class BaseUserService
		print(f'SETTLED FROM BASE: self.db_service: {self.db_service}')

		self.simple_dep_one = simple_dep_one
		self.simple_dep_two = simple_dep_two

Description
Is it possible to provide (inject) dependency into base class using Depends()?
in the code example in the constructor i receive deps for simple_dep_one & simple_dep_two but db_service contains self.db_service: Depends(NoneType)
Its possible to use alternative approach, smtn like:
class UserService(BaseUserService):
	def __init__(self,
		db_service: DBService = Depends(),	# base class dep
		simple_dep_one: SimpleServiceOne = Depends(),
		simple_dep_two: SimpleServiceTwo = Depends(),
	) -> None:
		super().__init__(db_service)

but this is very ugly and fastapi's IoC Container should manage all the deps for all the inheritance hierarchy by himself
so, what's the correct way to inject all required dependencies for all possible base classes using fastapi's Depends() ?
Operating System
Linux
Operating System Details
No response
FastAPI Version
0.75.0
Python Version
3.10
Additional Context
No response

you can use injectable

you can use injectable

well, if we gonna talk about external libraries, obviously i'll choose Dependency Injector (which already has support for FastAPI too), but FastAPI by himself has basic IoC capabilities and IMO it would be much better not to use any external deps but advance FastAPI's "native" features... this is very basic and simple mod why do i have to use external deps


Inquiry

how  does okdownload handle a situation where i request a file to be downlaoded using 5 thread (or generally multipart download) but the server does not support multipart download... will the download fallback to using one thread?

where i request a file to be downlaoded using 5 thread
You can feel free to use one of the following features to handle your request:

The easiest way: DownloadTask.Builder#setConnectionCount, which has been written on the wiki.
The harder way, implement your own DownloadStrategy and overwrite determineBlockCount method, and provide your own DownloadStrategy to OkDownload through: OkDownload.Builder

but the server does not support multipart download... will the download fallback to using one thread?
If the backend doesn't support multipart download, okdownload will alter use one connection to download automatically, please feel free to use OkDownload, it will make sense.


network.fit() does not work with scale > 1?

The doc states that network.fit() works for scale from 0 to 1, but that's not what I would expect. I failed to make a simple solution for autofit on load (and resize) for all my networks. Trying to set maxZoomLevel like this did not help:
network.fit({maxZoomLevel: 1000.0});
This issue seems to refer to the same functionality without an easy solution. I managed making something like this, but it feels like this should be much simpler.
I'm using vis-network 8.3.2 and Chrome 85.0.4183.102.

Hi @pettno,
fit's max zoom level option was implemented in 8.5.0, this functionality is not and is never going to be available in older versions.


Documentation for Planktos API

The public API is quite simple; however, it is not clear what our contracts to the user are.
For example:

getSnapshot not only gets the latest snapshot, but it also seeds the file if it wasn't being seeded before
getSnapshot can only be called after update
fetch and getFile have the same side effects and constraints as getSnapshot

Some of this may be a problem with our API; however, documentation is necessary regardless of whether or not these are issues.

Api documentation is now on the wiki and the api problems were fixed in #51 😄


KAFKA-2652: integrate new group protocol into partition grouping

@guozhangwang

added PartitionGrouper (abstract class)
This class is responsible for grouping partitions to form tasks.
Users may implement this class for custom grouping.
added DefaultPartitionGrouper
our default implementation of PartitionGrouper
added KafkaStreamingPartitionAssignor
We always use this as PartitionAssignor of stream consumers.
Actual grouping is delegated to PartitionGrouper.
TopologyBuilder
added topicGroups()

This returns groups of related topics according to the topology

added copartitionSources(sourceNodes...)

This is used by DSL layer. It asserts the specified source nodes must be copartitioned.

added copartitionGroups()

This returns groups of copartitioned topics

KStream layer
keep track of source nodes to determine copartition sources when steams are joined
source nodes are set to null when partitioning property is not preserved (ex. map(), transform()), and this indicates the stream is no longer joinable

LGTM except one minor comment.


Get read-only access key for S3 store where nova db dump is

SSIA

What is blocking this?

Getting the keys from Justin. I'm currently using keys that have broader permissions, so this is not a blocker.

@jtriley what needs to happen to provide an access key for the S3 store where the nova db dump goes?


[Nextra 3] Search box doesn't respond to Home and End keys

In Nextra 3 the search box doesn't seem to respect Home and End keys.
The default behavior (on linux) is that in a textbox, when there is text, pressing Home will set your cursor to the start of the text and pressing End will set your cursor to the end of the text. It appears that Nextra is grabbing all keystrokes and not allowing the OS to handle the Home/End keypresses.

It appears that it is a headlessui issue. Hopefully it can be fixed soon.


Add setting to enable new solver

Many people do not want to turn on and adjust several FFlags and be up to date with the latest FFlags (primarily through having to be in a Discord server..) just to make the new solver work correctly. This mitigates the issue by just adding one setting for it.

Also please update changelog


Unhandled exception Win32 when creating two and more windows

Describe the bug
Visual Studio 2022 17.7 shows "Unhandled exception Win32" when I run debuging the MultiWindowError project that creates two window after update Microsoft.WindowsAppSDk from 1.2.230217.4 to 1.4.230913002.
Using "Try catch" on OnLaunched does not cath any error as well as UnhandledException. The MultiWindowError works correctly when I run it without debugging
I could not able to check Win32 exception, because Visual Studio stucks when I try to detach current debagger and attach another one. I also found hard fix. When I adding a delay between creating windows 200ms and more, the application debug run without exception.
m_window = new MainWindow();
m_window.Activate();

await Task.Delay(200);

m_window1 = new MainWindow();
m_window1.Activate();

Steps to reproduce the bug

Clone repo https://github.com/steam3d/MultiWindowError/
Run debugging session

Expected behavior
Application will be debugging without exception how it was on  Microsoft.WindowsAppSDk from 1.2.230217.4
Screenshots
https://github.com/microsoft/WindowsAppSDK/assets/30986874/1053dd66-8a4c-4c45-8657-6578be6361c7
NuGet package version
Windows App SDK 1.4.1: 1.4.230913002
Packaging type
No response
Windows version
No response
IDE
No response
Additional context
No response

Try disabling the Xaml In App Toolbar. I remember there being a problem with this toolbar that can cause crashes.

@DarranRowe it is disabled

I also tired disable this

If you haven't changed any settings, then your video shows that it is enabled. It is that little tool bar that shows up by default at the top of your application window's Xaml content.

To disable this, you need to open the Live Visual Tree tool window in Visual Studio while your Xaml application is running and disable the tool bar there.

This tool window only shows up while an application with a Xaml host is running.

@DarranRowe  Yes. When this option is turned off everything fine. When I enable it the app immediately crashes


feat: utilize database

This PR combines the two client libraries into a new single library - additional clients will be added soon (KEV, EPSS, etc.). Additionally, a open-vulnerability-store library was added that can transform both the GHSA and NVD CVE data into a single model and store the results in a SQLite database using Hibernate.
However, instead of using the suggested target CLI option the vulnz CLI now has a database command.

resolves #23


Put explicit snyk scan workflow back

This replaces the webhook, because the webhook does the
wrong thing:

You can't get the code scan to run using the webhook.
You also can't get snyk to look up go dependencies properly using the
webhook (it uses go mod graph, which lists lots of packages that
aren't part of your build, whereas the CLI uses go list, which only
lists ones that are)

Thus, run all the checks manually.
Rather than putting them in a separate scan workflow, just put it into
an appropriate part of the overall PR workflow - that is:

The static check for all checks that don't require a built docker image
A bit of extra logic dunked at the end of the docker build to scan
the built image
A new, post-merge job that uploads all the things.

Unfortunately, you can't (as far as I can tell) make github actions
depend on a status, only jobs, so while these jobs have to run, their
results aren't actually mandatory.

reviewed and discussed 👍🏻


Windows support

The README states that IHaskell won't work on Windows except in a VM. Is that just because it hasn't been done/doesn't have a maintainer, or is there a fundamental reason it won't work?
I ask only because I'm tempted to try, and would like to know ahead of time if there's some fatal blocker that people know about.

It uses the Unix library to do pipe duplicating and redirecting. I don't know Windows well so don't know if this is a blocker or if another library could be used. If the latter I'm happy to provide as much support as necessary to get Windows support.

Thanks; I'll look into it and update this issue.
On Jul 17, 2015 5:23 PM, "Andrew Gibiansky"<EMAIL_ADDRESS>wrote:

It uses the Unix library to do pipe duplicating and redirecting. I don't
know Windows well so don't know if this is a blocker or if another library
could be used. If the latter I'm happy to provide as much support as
necessary to get Windows support.
—
Reply to this email directly or view it on GitHub
https://github.com/gibiansky/IHaskell/issues/528#issuecomment-122459970.

Great. If you find there's a reason that this is a blocker, it'd be great if you could describe why, and it can be added (by you or me) to the README.

I'm closing this for the time being due to inactivity and since I personally do not have any intention to tackle this right now. That said, I'm more than happy to re-open on any sign of activity. I'd love to get Windows support but I just don't have the knowledge, time, or resources to do it.

The main issue with Windows support is the IHaskell.Eval.Evaluate module, here. You can look at all the imports from System.Posix.IO, which I believe are not available on Windows. They are mainly used in capturedEval, which is a function that runs Haskell code and intercepts stdout. You'll see it needs some intercept code interpreted dynamically; the imports for that are in requiredGlobalImports. There's an especially tricky bit here, where we bring a pipe from the interactive context into the compiled context using some very unsafe transformations.
If anyone looks at this and has questions, let me know and I'm happy to elaborate as much as needed.

It seems that the only part statically needed by this module (after conditional compilation is taken into account) is just a replacement for the System.Posix.IO.createProcess :: IO (Handle, Handle) function? That part seems easy enough.
But then this also dynamically creates code which itself depends on the System.Posix.IO module, and that's the tricky part? Do we know which functions from that module are needed? IOW what would be the minimal list of identifiers where it could say import System.Posix.IO (...) on that line and it would still work?
But then I'm confused, because the tricky bit is back in static code, and only uses the POSIX module for fdToHandle?
(With apologies if these are poor questions, just getting started here.)

Good questions.
There are a few things going on here:

We use createProcess statically, and that would need to be replaced.
Dynamically, we use a variety of functions, and you can see what they are because they are explicitly qualified in capturedEval. (First there is an import, "import qualified System.Posix.IO as IHaskellIO", then IHaskellIO is used dynamically here, with createPipe, dup, dupTo, stdout, and closeFd.
There is a bridge between the dynamic and static part, where we return the dynamically created value and bring it into the static context using unsafeCoerce and hscStmt, and then convert it to a handle using fdToHandle.

Those are the three bits that need to be fixed. 1) The static context. 2) The dynamic context. 3) The bridge between them.
Does that answer the questions? (Please keep asking questions as you have them -- this code is convoluted and non-idiomatic because it does some weird stuff to work around GHC's behaviour.)

Closing this due to lack of activity. Happy to re-open if anyone wants to tackle it (I do not know enough about windows to implement it and do not have windows).

Sorry Andrew. I gave it a go, but it's over my head at this point. Thanks for the help! :)

for these fixes, will they be cut and dry or will there be a lot of plumbing that needs to taken care of as well? i.e. will i need to make a lot of changes other places in the code or will they just be localized to IHaskell.Eval.Evaluate?

AFAICT the changes will only have to be to IHaskell.Eval, but this includes the way that stdin, stdout, and stderr are handled, so it's nontrivial.


Service Worker Automatically Skips Waiting

Hi
Edge version: 42.17134.1.0
Edge HTML: 17.17134
In Edge a newly installed Service Worker is being automatically activated on refresh (ie equivalent to always calling skipWaiting).
The following bit of code should alert whenever serviceworker.js is modified and the browser is refreshed:
navigator.serviceWorker.ready.then(function (registration) {
      console.log('ready');

      if (registration.waiting) {
           alert('waiting');
       }
});

This never alerts in Edge, but does in Chrome and FireFox.

Hey thanks for the report @NoelAbrahams ! Unfortunately this is a web API issue rather than a JS engine issue. Can you open an issue on EdgeHTML issue tracker so the right folks can look at them?

Moved to EdgeHTML Issue Tracker as requested.


Convert to PLiftable

We need to replace all uses, and instances, of PUnsafeLiftDecl and PConstantDecl with PLiftable. This has to be done 'all at once', and may require additional definitions or bits. Instances will be the primary work, because pconstant and plift have the same semantics (and signatures) modulo minor definition changes.

Closed in https://github.com/Plutonomicon/plutarch-plutus/pull/753


Loader crashes: "Cannot read property 'XHR_RESPONSE_TYPE' of undefined"

When trying to load a file with the built in Loader, Pixi crashes internally in the blobMiddleware with the following error.
Uncaught TypeError: Cannot read property 'XHR_RESPONSE_TYPE' of undefined
    at Loader.blobMiddleware (blob.js:28)
    at Loader.js:639
    at async.js:45

Expected Behavior
XHR_RESPONSE_TYPE to be defined.
Current Behavior
The blobMiddleware seems to request a default property on _Resource2 which is not defined:

This automatically means XHR_RESPONSE_TYPE is also undefined.
Possible Solution
No clue
Steps to Reproduce
(not minimal config, but still rather thin)
https://github.com/pnobbe/pixi-dev/blob/master/src/index.ts
Environment

pixi.js version: 4.8.3
node version: 10.14.2
webpack version: 4.27.1
typescript version: 3.2.2
Browser: Chrome 70
Device: Windows 10

Have you tried this with the latest pixi dev branch? This should be fixed by resource-loader v2.2.2

Have you tried this with the latest pixi dev branch? This should be fixed by resource-loader v2.2.2

Thanks for the advice, that will probably fix it, however:
Maybe a dumb question, how do I specify a git repo as a dependency for npm? I tried adding 		"pixi.js": "pixijs/pixi.js#dev" to my package.json which is how Google told me to do it, but that doesn't work.

You unfortunately cannot install directly from npm like that. However, you can download the latest dev build here: https://pixijs.download/dev/pixi.js

Alright, I figured as much since I'd never seen anything directly referencing git in package.json.
Any eta for when the fix will be published?

Looks like there's a IE bug that seems significant. As soon as we can track that down, I'll push out another release.

Otherwise, this has been addressed. Closing issue.


dashboard: Implement name generator

Implement controller/name pkg in JavaScript and use it to generate a default app name.

Might make more sense to expose a name generator API from the controller.

Yeah, maybe. It would be good to have it all in one place, though I was thinking the word list is relatively small and could easily be shared and the logic is fairly simple. Having it on the client would prevent a few ms delay between the launch view opening and the name appearing.

If the client were to anticipate the launch view opening however (e.g. a page with a launch button loaded) and make the API call ahead of time, then the delay wouldn't be an issue.


Is there a editorconfig for prefer primary constructor

When we prefer using the file-scoped namespace, we could use csharp_style_namespace_declarations=file_scoped, then is there a config for the primary constructor?

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 3f1194e6-3116-6e70-9a36-f0a509c04f63
Version Independent ID: a22d366b-380f-f701-6a01-2515433e1550
Content: Declare and use primary constructors in classes and structs
Content Source: docs/csharp/whats-new/tutorials/primary-constructors.md
Product: dotnet-csharp
Technology: csharp-whats-new
GitHub Login: @BillWagner
Microsoft Alias: wiwagn

ping @CyrusNajmabadi who might know the answer.

Yes. Use: csharp_style_prefer_primary_constructors

@CyrusNajmabadi , thanks very much, it helps


Preview URL option

Should have a standardized way to provide a preview URL when defining a schema, so that users can have a straight-forward "Preview" button on every piece of content they edit.
It'd depend on the back-end systems doing the right thing, so this may be problematic in practice.

This is started in adee6e97f3a0f10e4bb1be0115e8e49a97bc008a, it needs styling love though.


[Doc][Improve] Add images to /assets

This PR fixes issue #17960.
Motivation
Builds automatically failed because images used in concepts-messaging.md were not found.
Modifications
Add images to /assets for concepts-messaging.md
Verifying this change

[ ] Make sure that the change passes the CI checks.

Documentation

[x] doc
[ ] doc-required
[ ] doc-not-needed
[ ] doc-complete

@DaveDuggins do you want to reference these images in the Messaging doc? If yes, you need to update the related image links in the Messaging MD file.

@DaveDuggins I have the same comment with Tison. Can you pls respond and clarify the intention further before we can move it forward?

@DaveDuggins before submitting images, make sure:

Test your changes locally, make sure all images are shown correctly, and attach the screenshots of local previews in the PR description
Verify all the images are used in docs

Thank you!

@DaveDuggins Since the SVG files is present, I'm going to take over this PR to fix the site build issue - this patch still have some name mismatches issue. I'll add you as the coauthor for the superseding patch. See also #17991.


Eliah Kagan: Watch chinaplasticdustbin.com

Eliah Kagan requests the watch of the watch_keyword chinaplasticdustbin\.com. See the MS search here and the Stack Exchange search here.

chinaplasticdustbin\.com has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Approved by Shree in Charcoal HQ


[$250] Track - Distance amount changes after submitting track distance expense with description

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 9.0.53-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Go to staging.new.expensify.com
Go to self DM
Click + > Track expense > Distance
Enter waypoints > Next
On confirmation page, click Description
Enter a description and save it (important)
Take note of the distance
Click Track expense
Click Categorize it from the whisper
Select workspace, then category and submit it
Go to transaction thread

Expected Result:
The distance in the transaction thread will not change after submitting track distance expense with description
Actual Result:
The distance in the transaction thread changes to a large distance after submitting track distance expense with description
This issue only happens when the track distance expense has a description
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[x] Android: Standalone
[ ] Android: HybridApp
[x] Android: mWeb Chrome
[x] iOS: Standalone
[ ] iOS: HybridApp
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

https://github.com/user-attachments/assets/afcfa50e-d441-4bb1-b678-968814cd067c
View all open jobs on GitHub
Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~021849826979508811500
Upwork Job ID:<PHONE_NUMBER>508811500
Last Price Increase: 2024-10-25
Automatic offers:

aimane-chnaif | Reviewer | 104590906

Issue OwnerCurrent Issue Owner: @aimane-chnaif

Hi, I'm Nicolay from Callstack - expert contributor group - and I would like to work on this issue.

The application might be incorrectly concatenating the distance value as a string. There may be a bug in the frontend code that processes or displays the distance. This could be a simple coding error, such as a misplaced decimal point or incorrect use of a formatting library.

Contributor details
Expensify account email<EMAIL_ADDRESS>Upwork Profile Link: https://www.upwork.com/freelancers/~01e533a820834397cf?mp_source=share

Updates from my side - identified root case place - will continue tomorrow and provide all details/PR

Just re-checked what we have in Onyx for both submit with Description and without.
Compare expense report before categorised and after (with description field submitted):

Compare expense report before categorised and after (without description field submitted):

With description submit you can see that quantity is coming incorrectly. @aimane-chnaif let me know wdyt? Maybe we need a BE engineer to check what we have such difference in response

I believe we are incorrectly merging the rNVPs when there is a comment, I will take a better look tomorrow to check if we should send more info from the FE or fix in the BE.
https://github.com/Expensify/Auth/blob/e8549e7b4e887b1cd1e05acba254d209edf6aa5e/auth/command/AddTrackedExpenseToPolicy.cpp#L112

So I think we have to:

[App] Start sending the waypoints when categorizing an expense, the same way we do for track expense, since it may change when categorizing

I think the same applies for ShareTrackedExpense

[Web-E] Start passing the waypoints here in Web-E
[Web-E] Send the encodedCommentNVP to Auth
[Auth] Handle the encodedCommentNVP in Auth when updating the NVPs

I can probably write the PRs for the backend by EOW

I was dragged into some other things, writing the PRs now.

Hey @narefyev91 are you still gonna work on this one?
If so, we need to start sending waypoints and  customUnitRateID when calling AddTrackedExpenseToPolicy

@rlinoz hey! yeah - could you please provide an example for API call - what should be send - if possible?

@rlinoz could not find any implementation for AddTrackedExpenseToPolicy in Expensify repo.... seems like we do not use that API call at all

Oh I am sorry, it is called CategorizeTrackedExpense, if we can update the ShareTrackedExpense as well it would be great!

@narefyev91 Oh I am sorry, it is called CategorizeTrackedExpense, if we can update the ShareTrackedExpense as well it would be great!

Yeah - will do it!

@rlinoz hope that these payload is correct waypoints inherit the same structure as for default Track expense API call:

Yep that should be the same as TrackExpense

Im trying to find sometime to look into the change needed
Basically we had to revert the PR because when creating a policy in this flow the policy is created only after we evaluate the policy distance rate, so we failed at getting the policy distance rate. Not sure how to fix that yet.

Not overdue, see comment above.

Im gonna move this to weekly as I think it is lower priority, feel free to change it if you disagree

I will open a draft PR for this one today.


[FEATURE] Rolling maintenance feature for zone, pod, cluster...

For a zone/cluster/host resource view, show button to start rolling maintenance

With @davidjumani


Create RAT builds for all Github PRs

This will help us identifying RAT errors / reports before they hit the main repo.

This is fixed.


Create String Theme Input Comonent

Create an input for the string values.

Validates that there are 8 comma separated values
Each value is a valid hex color
Clicking on the Copy button adds the value to the clipboard

Can you assign me this?

@breno-pereira Here you go! Let me know if you have any question :)

@breno-pereira Are you still working on this?


Add contributing guidelines

Add a CONTRIBUTING.md file that documents expectations for contributions.

Yes, please, this would be very beneficial.

Fixed by #329, autoclose again did not work.


Fix typo

a -> an

@changeworld : Thanks for your contribution! The author, @bobbytreed, has been notified to review your proposed change.

Verified editorial correction.


[SPARK-27423][SQL][FOLLOWUP] Minor polishes to Cast codegen templates for Date <-> Timestamp

What changes were proposed in this pull request?
https://github.com/apache/spark/pull/24332 introduced an unnecessary import statement and two slight issues in the codegen templates in Cast for Date <-> Timestamp.
This PR removes the unused import statement and fixes the slight codegen issue.
The issue in those two codegen templates is this pattern:
val zid = JavaCode.global(
  ctx.addReferenceObj("zoneId", zoneId, "java.time.ZoneId"),
  zoneId.getClass)

zoneId can refer to an instance of a non-public class, e.g. java.time.ZoneRegion, and while this code correctly puts in the 3rd argument to ctx.addReferenceObj(), it's still passing zoneId.getClass to JavaCode.global() which is not desirable, but doesn't cause any immediate bugs in this particular case, because zid is used in an expression immediately afterwards.
If this zid ever needs to spill to any explicitly typed variables, e.g. a local variable, and if the spill handling uses the javaType on this GlobalVariable, it'd generate code that looks like:
java.time.ZoneRegion value1 = ((java.time.ZoneId) references[2] /* literal */);

which would then be a real bug:

a non-accessible type java.time.ZoneRegion is referenced in the generated code, and
ZoneId -> ZoneRegion requires an explicit downcast.

How was this patch tested?
Existing tests. This PR does not change behavior, and the original PR won't cause any real behavior bug to begin with.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/9973/
Test PASSed.

Test build #104653 has started for PR 24392 at commit c4233d5.

Test build #104653 has finished for PR 24392 at commit c4233d5.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104653/
Test PASSed.

Test build #104681 has started for PR 24392 at commit 562e2dc.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution-unified/10000/
Test PASSed.

Test build #104681 has finished for PR 24392 at commit 562e2dc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/104681/
Test PASSed.

thanks, merging to master!

late LGTM, thank you


RUMM-875 Plug in the ConsentAwareHandler logic

What does this PR do?
A brief description of the change being made with this pull request.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)

[ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
[ ] Make sure you discussed the feature or bugfix with the maintaining team in an Issue
[ ] Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)

Codecov Report

Merging #406 (e50ed8f) into feature/gdpr (162570f) will decrease coverage by 0.60%.
The diff coverage is 98.97%.

@@                Coverage Diff                 @@
##             feature/gdpr     #406      +/-   ##
==================================================
- Coverage           91.01%   90.42%   -0.60%
+ Complexity           1220     1211       -9
==================================================
  Files                 148      147       -1
  Lines                4039     4069      +30
  Branches              467      466       -1
==================================================
+ Hits                 3676     3679       +3
- Misses                217      232      +15
- Partials              146      158      +12

Impacted Files
Coverage Δ
Complexity Δ

...domain/batching/processors/DefaultDataProcessor.kt
87.50% <80.00%> (-12.50%)
5.00 <2.00> (ø)

...oid/src/main/kotlin/com/datadog/android/Datadog.kt
90.32% <100.00%> (+0.55%)
24.00 <0.00> (ø)

...ndroid/core/internal/data/file/FileOrchestrator.kt
97.18% <100.00%> (+0.26%)
30.00 <21.00> (+4.00)

...adog/android/core/internal/data/file/FileReader.kt
85.45% <100.00%> (+0.27%)
14.00 <1.00> (+1.00)

...id/core/internal/domain/FilePersistenceStrategy.kt
100.00% <100.00%> (ø)
8.00 <5.00> (+3.00)

...e/internal/domain/batching/DataProcessorFactory.kt
100.00% <100.00%> (ø)
4.00 <0.00> (-1.00)

...l/domain/batching/DefaultConsentAwareDataWriter.kt
100.00% <100.00%> (ø)
6.00 <4.00> (?)

...dog/android/error/internal/CrashLogFileStrategy.kt
100.00% <100.00%> (ø)
2.00 <1.00> (+1.00)

...adog/android/error/internal/CrashReportsFeature.kt
100.00% <100.00%> (ø)
15.00 <0.00> (ø)

...in/com/datadog/android/log/internal/LogsFeature.kt
100.00% <100.00%> (ø)
15.00 <0.00> (ø)

... and 22 more


Epobutt bugfix

Closes #6618
The first figure in examples/plot_compute_raw_data_spectrum now uses average=False.

Yeah, looks good on my stuff, too.

I pushed minor changes. Merge when green.

Thx @jshanna100


Clicking Extension Icon Gives Create PR Screen Instead PRs and Issues

When clicking the icon, I see a create PR and it's unclear as to how to get listing for the following
v PULL REQUESTS
...
...
...
v ISSUES
...
...
and so on.  The extension icon puts the user in an unclear state.

Extension version: 0.26.0
VSCode Version: 1.57.0-insider
OS: macOS 11.3.1

Steps to Reproduce:

Click the extension icon
Unable to view/list PULL REQUESTS and ISSUES

There are two activity bar icons associated with this extension:

The top one is the "create PR" icon, and the bottom is the PRs and Issues tree views.

@alexr00 Great and thanks for the clarification.


Excel complains about generated file being corrupt

When I try to open a file created by the package in Excel, it complains about it being corrupt and prompts me to ask if I want to repair it. The reperation always works and the document works as intended.
The code used to generate the document can be seen here: https://github.com/AlexGustafsson/timekeep/blob/master/src/utils/excel.js
An example file generated by the code can be found here:
timekeep.xlsx

@AlexGustafsson yes, that right, sometimes I had this bug too.
https://github.com/exceljs/exceljs/issues/732
https://github.com/exceljs/exceljs/issues/745
#35
https://github.com/exceljs/exceljs/issues/106
https://github.com/exceljs/exceljs/issues/739
If I have a good memory, the solution has been setting model.result in cells with a formula

"Solved" by moving to https://www.npmjs.com/package/xlsx-populate which worked great right of the bat.

I solved the problem. Hope this helps you.
If you download this excel file from the server side (In my case Node JS).
The problem is solved by one line on the client side:  req.responseType = "arraybuffer";
requestData(req, "exportToExcel")
            .then(resXHR => {
                // For the correct processing of data from the server, you must specify the format/structure of data transfer
                resXHR.responseType = "arraybuffer"
                // Wait until the data is downloaded from the server
                resXHR.onload = function () {
                    // Call a modal window for saving with type and file name
                    saveAs(new Blob([resXHR.response], { type: 'application/vnd.openxmlformats-officedocument.spreadsheetml.sheet' }), 'users.xlsx')
                }
            })

@Siemienik Could you please elaborate:what exactly to do in  by setting model.result in cells with a formula

@Siemienik Could you please elaborate:what exactly to do in by setting model.result in cells with a formula

@Jigna-Rathod
When a formula causes file corruption, the best workaround is set for this formula result to undefined, which tells Excel to recalculate the formula result.
However, there may be more reasons. So If your case makes the file is corrupt, please create a new issue ( or discussion ) and obviously attach code and, if possible, the output xlsx. I can't respond to all issues, so please tag me by using @siemienik there. Additionally, I might be caught on Gitter or mail<EMAIL_ADDRESS>.


Healthcheck filter fails when disabling server metrics

Given an Envoy v1.11.1 node with server metrics excluded via StatsMatcher and HTTP health checking filter enabled, when hitting the healthcheck endpoint a 503 response is received independently of the true node health.
From my research this seems to be due to the healthcheck depending directly on the server metrics:

Health check filter
healthCheckFailed() instance method

Minimal config to reproduce issue
admin:
  access_log_path: /tmp/admin_access.log
  address:
    socket_address: { address: <IP_ADDRESS>, port_value: 9901 }
stats_config:
  stats_matcher:
    reject_all: true
static_resources:
  listeners:
  - name: proxy
    address:
      socket_address: { address: <IP_ADDRESS>, port_value: 10000 }
    filter_chains:
    - filters:
      - name: envoy.http_connection_manager
        config:
          stat_prefix: ingress_http
          route_config:
            name: route
          http_filters:
          - name: envoy.health_check
            config:
              pass_through_mode: false
              headers:
              - name: ":path"
                exact_match: "/healthcheck"
          - name: envoy.router

Healthcheck request
$ curl -i localhost:10000/healthcheck
HTTP/1.1 503 Service Unavailable
x-envoy-upstream-healthchecked-cluster: local-cluster
date: Wed, 16 Oct 2019 17:33:43 GMT
server: envoy
connection: close
content-length: 0

Workaround
The workaround is to whitelist metrics needed by the health-check:
stats_config:
 stats_matcher:
  inclusion_list:
    patterns:
    - suffix: live
    - suffix: membership_healthy
    - suffix: membership_degraded
    - suffix: membership_total

Dup of https://github.com/envoyproxy/envoy/issues/8473

This is fixed in #8482.

@venilnoronha I took a look at the PR and noticed it removes the usage of server_stats.live but not the cluster ones (membership_total, membership_degraded  and membership_healthy). Couldn't that cause the minimum healthy clusters functionality to work improperly?


##[error]Request failed with status code 400

I did tried this action but we are getting 400 status code .
name: Rocket.Chat Notification

on:
  pull_request:
    types: [opened, review_requested, reopened, assigned]

jobs:
  send_message_on_rocket:
    runs-on: ubuntu-latest
    steps:
      - name: Rocket.Chat Notification
        uses: RocketChat/Rocket.Chat.GitHub.Action.Notification@master
        if: always()
        with:
          type: ${{ job.status }}
          job_name: '*Lint Check*'
          mention: 'here'
          mention_if: 'failure'
          channel: '#github-updates'
          username: 'github'
          url: ${{ secrets.ROCKETCHAT_WEBHOOK }}

The same for me. secrets.ROCKETCHAT_WEBHOOK is correct, it generates payload for RocketChat and then ##[error]Request failed with status code 400

@milandufek  I think it is about rocket chat and it's API config, I tested the hook with postman and got error 400 .

@sayjeyhi well, but I'm able to use the hook from other server using e.g. curl but the same doesn't work from GitHub container.

@milandufek could you please test it with postman and tell the result?

I got OK 200 response to hook url with no auth.

Got the same problem. It just happens after a failed action though

hmmmm, I have no idea whats happening 🚶

I had that same problem. Solved removing "mention: 'here'".


  Calculations is currently a double causing this to fail.

@googlebot I signed it!


Could reach Database

Hi Jeremylong,
Currently we are using version 6.2.2 which was worling fine all these days. From last 1 week it giving the below error. And we are not connected to the interenet.
Error:
[Dependency] [ERROR] Exception occurred initializing Jar Analyzer.
[Dependency] [ERROR] Unable to create temp directory '/tmp/dctemp1c3a6260-05ec-4481-8430-61fd556f1894/check9174020675887913617tmp/70'.
[Dependency] [ERROR] Unable to create temp directory '/tmp/dctemp1c3a6260-05ec-4481-8430-61fd556f1894/check9174020675887913617tmp/71'.
[Dependency] [ERROR] Unable to create a temporary file
[Dependency] [ERROR] An exception occurred accessing the database
Can you please guide on resolving this issue.  Why its giving error as that it cannot access database?
How to fix this error?
we are using linux environment
and gradle plugin
Thank you,
Mridula U

looks like someone changed permissions of the user that runs dependencycheck in a way that prevents it from creating folder structures within /tmp or your /tmp  is running out of space (or available inodes). As it reports an error on creation of the temporary folder where it copies information so that the scan can run in isolation of other parallel runs of dependencycheck.

gut feel would be the out-of-space/inodes condition, as I otherwise would expect the issue to already be reported on the initial folder (/tmp/dctemp1c3a6260-05ec-4481-8430-61fd556f1894) rather than more deeply nested in the folder structures

Oh... and on second read... it's not the isolated-copy datafolder,  but the folder where it temporarily extracts an archive for detailed analysis.

Nevertheless I would recommend to update to a current version as there have been many fixes for false positives in between 6.2.2 and 7.3.1


Dependency cycle in cql2elm

FHIRModelInfoProvider depends on ModelInfoProvider defined in cql2elm, but the cql2elm tests depend on FHIRModelInfoProvider. I used testImplementation to declare the dependency, but I intended testRuntimeOnly. Might also make sense to move ModelInfoProvider to the model package.

Addressed in 2.1.0 release


Feature Request: Verifiable Presentation creation with server-provided challenge

Short Description
Right now, LCW is able to generate a Verifiable Presentation (VP) using a random UUID as challenge. To confirm that a given VP was generated intentionally for a given third party, it is necessary to have that challenge supplied by that third party.
Target Process Outline
This could be very similar to the current process for loading credentials into the wallet, hopefully minimizing required changes:

Our web app generates a qr code with the following information

Random server-generated challenge
API endpoint URL to send the VP to

dccrequest://present?              // DCC: mobile app deep link
&vc_present_url=<vc_present_url>   // DCC: verifiable credential present url
&challenge=<challenge>             // DCC: challenge for signing

After scanning the code with the smartphone camera, the LCW can generate the VP using the provided challenge.

The order of sub-actions here is not clear. Either selecting credentials for the VP, or scanning the code could happen first.

The finished VP is sent from the LCW to the API endpoint obtained previously from the qr code.
Our server can validate that the VP is valid and uses the correct challenge.

This feature has been implemented, closing.


Usage of GRADLE_HOME for ephemeral builds is wrong

Issue type
Wrong or misleading information
Problem description

The path that can be copied is $GRADLE_HOME/caches/modules-<version>. The only constraint is placing it using the same structure at the destination, where the value of GRADLE_HOME can be different.

GRADLE_HOME is wrong. GRADLE_USER_HOME is right.
Context (optional)
No response
Page with the problem
https://docs.gradle.org/current/userguide/dependency_resolution.html#sub:cache_copy

Thank you for your interest in Gradle!
This is a valid documentation issue that we will address.

There is another instance of that error at https://docs.gradle.org/current/userguide/build_cache_performance.html#fully_cached_builds :

Clean the cache directory to avoid any hits from previous builds (rm -rf $GRADLE_HOME/caches/build-cache-*)


Derefine strategy

I noticed in my application that derefiner is very inefficient. I think the reason is the refining strategy and derefining strategy we have in mfem are actually different. The refiner relies on a combination of relative value and absolute value with respect to element errors, while the derefiner only uses an absolute value compared to a threshold.
I simply try something like
   const double total_err = GetNorm(local_err, mesh);
   const double true_threshold = std::max(total_err * total_fraction, threshold);
   bool derefs = mesh.DerefineByError(local_err, true_threshold, nc_limit, op);

Derefiner becomes much more efficient.
So I am curious why such a strategy was not implemented by default. Is there something I am missing? I believe this strategy is common in practice.
Qi

ping @jakubcerveny

Sorry for the late answer. I think at the moment, ThresholdDerefiner is just a simple wrapper around Mesh::DerefineByError, and may need extending based on practical requirements. I think nobody just got around to doing that yet, that's all.
On a more philosophical note, I personally prefer to use the low-level functions (Mesh::GeneralRefinement, Mesh::DerefineByError), just like you did above, and have not been a huge fan of the fancy Refiner/Derefiner classes, which are confusing to me. The different refinement strategies are nice, but I would prefer them packaged in discrete building blocks that the users connect themselves (estimate errors -> select elements -> refine/derefine), instead of having these steps hidden inside an opaque class.


[feature] ability to add source tarball as a file option

NPM Pack is a nice feature of npm that creates a tarball of your package, minus unnecessary dependencies and a few other things. It would be great to be able to provide this source tarball in the files option like so:
files: ['path/to/source.tgz']

This should include all the proper directories that you'd want using the tarball as a source instead of having to manually redefine them in the Gruntfile.

Just so I understand, this would involve unpacking the gzipped tarball and using the contents for building the RPM?

That's correct. Although, now that I think about it, it probably wouldn't make sense to list this under "files", as once you list a tarball, I wouldn't think you would want to join it with anything else.

That's similar to what I was thinking.  I'm unsure if it should be an either-or usage (where only a files section or a tarball section can be used) or if it is worth trying to negotiate including the tarball's contents into the files (order would obviously be a factor here).  I'm leaning towards the former because of the complexity of the later.


The current HLSL implementation applies the algorithm on subtitles.

Due to how MPC handles shaders, they are always applied after subtitles. I am not sure if it is changeable.
For MPV, the user can choose to not apply shaders on subtitles.

I am Japanese. I can't write English. (Machine translation)
Thank you for the wonderful software.
I would like to ask a few questions.
Please give me an answer if you like.
1.Are there any plans to develop parameters optimized for [P720 to P1080] and [SD480 to P1080]?
2. Are there any plans to implement parameters that can be adjusted by the user?
3. Is there a plan to conduct a wide range of user tests by releasing multiple parameters?
This software is light, clean and very easy to use
I can't write a program. As a tester, you may be able to report the results.
Have a nice day!


caddy: properly handle React frontend

Now the react frontend uses / and /docs/*. We should rewrite all these requests to index.html.

    rewrite /docs {
        to {path} /
    }


[-] PROGRAM ABORT : Error opening pidfile.txt

Dear!
I was doing some tests with a line to fuzzing firefox.
I wanted to try it and I also wanted to try doing a brute force of offset, the question that I tried with everyone and always gives me the same error, do you know why it is?
Error:
[-] PROGRAM ABORT : Error opening pidfile.txt
Location : create_target_process(), c:\work\winafl\source\afl-fuzz.c:2361
Line :
afl-fuzz.exe -i in -o out -D C:\winafl-master\dyno\bin64 -t 100 -- -coverage_module mozglue.dll  -coverage_module firefox.exe -fuzz_iterations 100 -target_module lgpllibs.dll -target_offset 0xB1D1 -nargs 2 -- C:\Program Files\Mozilla Firefox\firefox.exe @@

First time I see this error, but in general, the pid file is created in
https://github.com/googleprojectzero/winafl/blob/master/afl-fuzz.c#L2302
with -pidfile dynamorio flag. Perhaps instrumentation fails for some reason. These issues can be debugged by running the target in DynamoRIO directly (see the -debug mode in Readme).
Looking at the command line, the most likely reason I can see for instrumentation failing is the target path containing spaces, and not being quoted. It should probably be
"C:\Program Files\Mozilla Firefox\firefox.exe"
instead of
C:\Program Files\Mozilla Firefox\firefox.exe
Also, I would be really surprised if you could fuzz the whole of firefox (rather than a specific part) in this way and also if you could bruteforce a (meaningful) target_offset.

Hi, I also meet the same issue. I just test a very simple C program to make sure it works. The program simply reads from a file to check if it's 'bad!'. If so, then crashes. When I run WinAFL with static instrumentation mode -Y, it also shows "All programs time out." issue.
Line:
afl-fuzz.exe -i D:\Workspaces\winafl\testcase -o D:\Workspaces\winafl\findings -D D:\Software\DynamoRIO\bin64 -t 20000 -- -coverage_module testprog.exe -- D:\Workspaces\winafl\programs\testprog.exe @@

I'm not sure if this is related to this issue but your command line seems to be missing some required instrumentation flags (such as target module/function, number of function arguments and number of iterations). You should always run the debug mode first (see https://github.com/googleprojectzero/winafl/blob/master/readme_dr.md) and only run afl-fuzz if the debug log looks good.

@yuexizhumeng
The solution is change D:\Workspaces\winafl\programs\testprog.exe to "D:\Workspaces\winafl\programs\testprog.exe" like says @xinali

I am receiving the same error. I was mistakenly using DynamoRio bin32 executable instead of bin64.

The path string is the key。I also meet this error。

I have encountered the same problem. Have you solved this problem? The following is my command parameters and error message
C:\Users\luna\Desktop\winafl-master\bin64>afl-fuzz.exe -i C:\Users\luna\Desktop\
input -o C:\Users\luna\Desktop\out -D C:\Users\luna\Desktop\DynamoRIO-Windows-7.
1.0-1\bin64 -t 20000 -- -coverage_module test.exe -coverage_module
 test.dll -fuzz_iterations 5000 -target_module test.exe -target
_method wWinMain -nargs 2 -- E:\testforwinafl\test.exe @@
WinAFL 1.16b by<EMAIL_ADDRESS>Based on AFL 2.43b by<EMAIL_ADDRESS>[+] You have 1 CPU cores and 0 runnable tasks (utilization: 0%).
[*] Setting up output directories...
[+] Output directory exists but deemed OK to reuse.
[*] Deleting old session data...
[+] Output dir cleanup successful.
[*] Scanning 'C:\Users\luna\Desktop\input'...
[+] No auto-generated dictionary tokens to reuse.
[*] Creating hard links for all input files...
[*] Attempting dry run with 'id_000000'...

[-] PROGRAM ABORT : Error opening pidfile.txt
         Location : create_target_process(), c:\work\winafl\source\afl-fuzz.c:2357

Below is the feedback of debugging mode, I did not see the relevant debugging file generated, if I did not use the error
C:\Users\luna\Desktop\winafl-master\bin64>C:\Users\luna\Desktop\DynamoRIO-Window
s-7.1.0-1\bin64\drrun.exe -c winafl.dll -debug -coverage_module test.dll -tar
get_module test.exe -target_offset 0x0 -fuzz_iterations 10 -nargs
2 -- "E:testforwinafl\test.exe @@"
 C:\Users\luna\Desktop\input\alphatrans.png
ERROR: Target process E:testforwinafl\test.exe is for the wrong architecture

I have tested the above methods. I have received the same results on both windows7 x86 and x64, and I started cmd.exe with Administartor.

Hi Taolaw,
As @anshuman-goel mentioned earlier, and because I lost a few minutes trying
to figure out what's wrong, you are using wrong architecture for the DynamoRIO.
If it's x86 make sure you use the bin32\drrun.exe and bin32\afl-fuzz.exe,
and consequently if it's x64 use bin64\drrun.exe and bin64\afl-fuzz.exe.
From your command line above, it looks like you have compiled for x86 architecture.
Hope that helps,
Symeon

I am getting this same problem regardless of the combination of dynamoRIO and winafl that I use. I'm starting to wonder if the problem isn't deeper than that, but digging into the .c file doesn't illuminate the situation much.

I had a similar problem (pidfile error) with a command of the form
afl-fuzz.exe … -- -coverage_module … -- path\to\app.exe someArg path\to\some\other\file @@

I had to wrap each whitespace-separated part after the second -- in quotes, like so:
afl-fuzz.exe … -- -coverage_module … -- "path\to\app.exe" "someArg" "path\to\some\other\file" @@

It took me a while to figure it out because someArg was a simple number like 1000, so I had not expected to have to wrap it in quotes.

I met a similar problem (pidfile opening error) when I try to fuzz my application with below command:
afl-fuzz.exe -i in -o out -D "D:\winafl\DynamoRIO-Windows-8.0.0-1\bin64" -t 20000 -- -coverage_module "path\to*.dll" -coverage_module "path\to\myapp.exe" -fuzz_iterations 10 -target_module "path\to\myapp.exe" -target_offset 0x16e0 -nargs 2 -- "path\to\myapp.exe" "-i" @@
myapp.exe also has a parameter "-i" to run it.
Don't know why it does not work.

how to avoid, Error opening pidfile.txt

how to get target_offset value

Using a disassembler (Ghidra or Ida Pro). Find the target function and see what its address is. Then find the base address (most often it is 0x400000) and subtract it from the function address. This will be the target_offset.


add_markdown_support_emote

display the emotes with markdowns
Should fix https://github.com/vector-im/vector-android/issues/439
add markdown support for emotes

:+1:  LGTM


Of/bulk bifrost delete

Adds the resource "bulk/delete" which accepts post with a request body:
{
"type" : "(actor|group)",
"collection": ["authz_ids"]
}
and returns error in the event of a server error and ok with body
{
"count": num_deleted
}
in the event of success.  Num_deleted may be different than the length of the collection if some authz_ids are missing at time of request.

@oferrigni I have rebased this pull-request against the new chef-server repository.  The new PR can be found here:
https://github.com/chef/chef-server/pull/160
Please let me know if there is a problem with the rebase or if you have any questions.  Thanks!


[COMMUNITY] @zhiics -> PPMC

Please join us to welcom @zhiics as a new PPMC member of the TVM community.
Zhi has contributed to various aspects of TVM. His primary contribution includes the relay pass manager, code generator and so long. He also keeps up the code quality and help to improve the overall designs for the tvm infra. Some of them reflected in his effort in helping code refactors and general design RFCs.

Commits
Code Reviews
Community Forum summary

Congratulations! @zhiics :)


feature(share): custom sharesheet and instagram stories sharing, and toast

The type of this PR is: TYPE

This PR resolves CX-832
Description
This PR adds

a new custom share sheet on Artwork
the ability to share on Instagram stories
a new toast we can use anywhere in the app, with support to top, bottom and middle.

Follow-up work

[ ] replace InquirySuccessNotification with the new toast. Ask Purchase design if that's ok.

PR Checklist (tick all before merging)

[x] I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
[x] I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
[x] I have documented any follow-up work that this PR will require, or it does not require any.
[x] I have added an app state migration, or my changes do not require one. (What are migrations?)
[x] I have added a CHANGELOG.yml entry or my changes do not require one.

ready to go.

this is ready to go

Thanks for taking a close look! All is taken care of. #squashongreen