Looks like viro is dead for ios till update

ITMS-90809: Deprecated API Usage - Apple will no longer accept submissions of new apps that use UIWebView as of April 30, 2020 and app updates that use UIWebView as of December 2020. Instead, use WKWebView for improved security and reliability. Learn more ( https://developer.apple.com/documentation/uikit/uiwebview ).
react-viro uses UIWebView component, so since April 30 2020 it's will be rejected by apple, when you are trying to publish it.

Our app was all ready to be released as well, but due to this, we are stuck. This is going to prevent any new apps from making to App Store and eventually, by December, all existing apps will stop working as well. Sounds like a high priority item. Any plans from Viro team to tackle this soon ?

Guys any update on this issue? Apple already stopped receiving the UIWebView API. Now we are unable to upload the app

@dthian please fix the OS deprecated UIWebView issue

Hey @ManigandanRaamanathan, as mentioned in the other post, I'm not currently working on ViroReact. @HedwigAR might have made some progress, so I would check in with him.

@dthian, I tried @HedwigAr's GVR removed version  v2.18.0, it works perfectly fine now

@ManigandanRaamanathan If we remove GVR that means we can't have VR support on the app yeah?

Yes @MinhazMM. That is indeed the case.

@ManigandanRaamanathan , where can I access the v2.18.0(the one with GVR removed)? and what react-native version are you using it with ?

@ranjanpoudel1234 https://github.com/mendix/viro/pull/1

Thank you very much @ManigandanRaamanathan . Please forgive my lack of knowledge on this. Did you use the github link(this one https://github.com/mendix/viro.git) directly on your package.json, or did you fork it and make npm package out of that build branch(which has the fix) ?

are we planing to release a new version that fix issue of Apple ?

@diegothucao on my end, AR works on both android and ios version. I installed me ndix pull request version.

I've also installed mendix version (master branch on https://github.com/mendix/viro.git) but after I run yarn install and react-native run-android --variant=arDebug to open the app (in code-sample folder) on my device, it crashed out. Do you have any idea, is there any step I'm missing? or I'm using the incorrect branch (or git link)? @ManigandanRaamanathan thank you so much.

@namthan dont use master branch. Use the branch that is is pending merge request

@namthan dont use master branch. Use the branch that is is pending merge request

Do you mean branch UpdateReactNative ? I'm trying it on. This is an urgent issue in my project, hopefully can get your supports. Thanks a lot.

@diegothucao on my end, AR works on both android and ios version. I installed me ndix pull request version.

@ManigandanRaamanathan : I went to https://github.com/mendix/viro.git and do not see any pull request version ? Could you have time to support me a bit in detail how could I do ?
thanks so much for your reply.

@diegothucao https://github.com/mendix/viro/pull/1

hi @ManigandanRaamanathan , thanks for your answer.
I downloaded the 'build' branch as in https://github.com/mendix/viro/pull/1
and run example with react-native run-android --variant=arDebug
However it crashes when Android app comes up.

@diegothucao the same version works fine on android 10 samsung s10 and note 9

Thanks @ManigandanRaamanathan
I used note 9 as well. But still issue
if you have any other idea for me. Please let me know.
Thanks so much.

After building successfully with medix pr, I'm running into this error. @ManigandanRaamanathan could you please help?

Did anyone manage to create 2.18 alternative with reverted GVR removal?
I would like to have an updated version with fix for #835 .
I was trying to but I always get white screen in VR mode.

I got this to work late last night, and successfully upload to Apple/Testflight to get past the UIWebView blocker.  Total hack, but happy to share what worked.
I'm now successfully using RN 0.62.2 and have Viro static library working great with no UIWebViews.
Gist:
Part 1: Build the static lib with no GVR UIWebView:

Clone my Viro repo git clone https://github.com/ktemby/viro (hacked edits to remove GVR from static library target, I make no claims to have quality tested properly, especially for Android).
Build viro (from the viro folder, cd ios, pod install, then open ViroReact.xcworkspace in Xcode and build all the targets, the 'static lib' target last)

Part 2: Get your project to use my updated viro fork (this can be merged back to main - I can't maintain a fork)

Remove Viro from your current project npm uninstall react-viro
Install my github fork npm install git+https://github.com/ktemby/viro

Part 3: Copy the locally built static library over to your project

cp /viro/ios/dist/* ~<your project in part 2>/node_modules/react-viro/ios/dist/

Part 4: Rebuild your app with the updated library

Do pod install first.
Now build in xcode or with NPX.

I can post a sample RN 0.62.2 + Viro project with key configurations tomorrow if more details needed.
Takeaway - I was able to get this to work, and successfully submitted to Apple, but the quality of my effort is a way lower bar than you want, so please proceed with caution and understand my good intentions for sharing what worked for me is no replacement for your own diligence!

@tscj3490 I don't think this will work for you - but feel free to try https://drive.google.com/file/d/1XnIN0tPXGiLT1bRwEAxE1HWW1rU1edxc/view?usp=sharing.  I'll run through the full steps of building a RN 0.62.2 test app, and post that over the weekend.

Thanks for your dedicated effort and help.
I will try again. Thanks again.

I just did as your guide and deployed app that GVR is removed to test flight.
I copied to the dist folder and pasted to <my project in part 2>/node_modules/react-viro/ios/dist/ . And I ran pod install again and then, I could build app successfully. But once I deploy app to test flight, apple doesn't still allow my app. It shows same error. (Apple doesn't allow UIWebView)
Please guide me again.

I can't be sure- but you may need to clean your build folder completely first.  I'd also isolate out what contains the UIWebview https://stackoverflow.com/questions/58091231/how-to-search-for-any-uiwebview-component-usage-inside-a-current-project.
I may have missed one of the steps I took, I'll do this for a clean test app on the weekend.

I can't be sure- but you may need to clean your build folder completely first. I'd also isolate out what contains the UIWebview https://stackoverflow.com/questions/58091231/how-to-search-for-any-uiwebview-component-usage-inside-a-current-project.
You may also want to ensure you're using the static lib - added step 2 to Part 4.
I may have missed one of the steps I took, I'll do this for a clean test app on the weekend.

Hi, Ktemby. Did u do the work ? If you did, please share.. Thanks.

I can't be sure- but you may need to clean your build folder completely first. I'd also isolate out what contains the UIWebview https://stackoverflow.com/questions/58091231/how-to-search-for-any-uiwebview-component-usage-inside-a-current-project.
You may also want to ensure you're using the static lib - added step 2 to Part 4.
I may have missed one of the steps I took, I'll do this for a clean test app on the weekend.

Hi, ktemby
I can't still deploy app to app store. Could you share source code that apple can approve ?
Thanks in advance.

I can't be sure- but you may need to clean your build folder completely first. I'd also isolate out what contains the UIWebview https://stackoverflow.com/questions/58091231/how-to-search-for-any-uiwebview-component-usage-inside-a-current-project.
You may also want to ensure you're using the static lib - added step 2 to Part 4.
I may have missed one of the steps I took, I'll do this for a clean test app on the weekend.

Hi, ktemby. Would you share test app apple approved ? I tried as your guide, but again, I got a mail like below.  I am struggling on this for a long time.
ITMS-90809: Deprecated API Usage - New apps that use UIWebView are no longer accepted. Instead, use WKWebView for improved security and reliability. Learn more (https://developer.apple.com/documentation/uikit/uiwebview).
Please help me.. If apple doesn't approve this Viro app, this isn't really useful.  Thanks.

Hello,
Good news for everyone, i have just make changes in SDK for issue of UIWebView and i am getting successful to do that.
now my iOS app is live on app store.
so here is my solution :
just download dist file from following link and extract and replace it in "..node_modules/react-viro/ios" path.
Link : https://drive.google.com/file/d/1F_5i59mCIWorF8N7f5A-CbuugrFKv3ia/view
please download it and paste in path and upload your app to app store.

Hello,
Good news for everyone, i have just make changes in SDK for issue of UIWebView and i am getting successful to do that.
now my iOS app is live on app store.
so here is my solution :
just download dist file from following link and extract and replace it in "..node_modules/react-viro/ios" path.
Link : https://drive.google.com/file/d/1F_5i59mCIWorF8N7f5A-CbuugrFKv3ia/view
please download it and paste in path and upload your app to app store.

Thanks for your update.. I just replaced the dist folder in "..node_modules/react-viro/ios" and deployed app again to test flight, but apple doesn't still approve... What did I missed else ? Thanks in advance.

Hello,
Good news for everyone, i have just make changes in SDK for issue of UIWebView and i am getting successful to do that.
now my iOS app is live on app store.
so here is my solution :
just download dist file from following link and extract and replace it in "..node_modules/react-viro/ios" path.
Link : https://drive.google.com/file/d/1F_5i59mCIWorF8N7f5A-CbuugrFKv3ia/view
please download it and paste in path and upload your app to app store.

Thanks for your update.. I just replaced the dist folder in "..node_modules/react-viro/ios" and deployed app again to test flight, but apple doesn't still approve... What did I missed else ? Thanks in advance.

Please check somewhere else you have used UIWebview?

Hello,
Good news for everyone, i have just make changes in SDK for issue of UIWebView and i am getting successful to do that.
now my iOS app is live on app store.
so here is my solution :
just download dist file from following link and extract and replace it in "..node_modules/react-viro/ios" path.
Link : https://drive.google.com/file/d/1F_5i59mCIWorF8N7f5A-CbuugrFKv3ia/view
please download it and paste in path and upload your app to app store.

Thanks for your update.. I just replaced the dist folder in "..node_modules/react-viro/ios" and deployed app again to test flight, but apple doesn't still approve... What did I missed else ? Thanks in advance.

Please check somewhere else you have used UIWebview?

In my project, I searched UIWebview, but I couldn't find. By the way, I am not sure why apple don't approve.. Could you share the source code apple approved ?

Hello,
Good news for everyone, i have just make changes in SDK for issue of UIWebView and i am getting successful to do that.
now my iOS app is live on app store.
so here is my solution :
just download dist file from following link and extract and replace it in "..node_modules/react-viro/ios" path.
Link : https://drive.google.com/file/d/1F_5i59mCIWorF8N7f5A-CbuugrFKv3ia/view
please download it and paste in path and upload your app to app store.

Thanks for your update.. I just replaced the dist folder in "..node_modules/react-viro/ios" and deployed app again to test flight, but apple doesn't still approve... What did I missed else ? Thanks in advance.

Please check somewhere else you have used UIWebview?

In my project, I searched UIWebview, but I couldn't find. By the way, I am not sure why apple don't approve.. Could you share the source code apple approved ?

Based on this Stackoverflow anser you can run grep -r UIWebView to detect the component. So I ran it into /dist folder shared by @pradipBhuva27 and had the following result

Binary file ~/Downloads/dist/ViroRenderer/static_lib/ViroKit_static_lib.framework/ViroKit_static_lib matches

I guess UIWebView is still there (of course the build was rejected by Apple).

@Cosmitar strange. The dist worked for me and my app is in the store

it turns out that I had 2 different Viro packages and I was updating the dist folder into one but using the other.
After updating the right folder the VR is working as expected and Apple accepted the build without warnings! 🎉

To anyone still struggling with this problem, I will share my experience hoping it could help someone.
I need to integrate viro AR functionality in a react native 0.62.2 project targeting both android and ios.
To make it work on android without androidX problems, I used the citychallenge fork: https://github.com/citychallenge/viro
That worked good both on android on iOS, but I could not submit my app on the apple store due to UIWebView.
I followed the suggestions in this very same thread and, while I managed to get it working on iOS using @ktemby instructions, it didn't work on android anymore and the solution could not be "gitted" due to large files that required copy-pasting.
So:

I forked @citychallenge repo ( my org repo: https://github.com/tiknil/viro )
I downloaded the dist.zip shared by @pradipBhuva27 , with library files way smaller then the dist.zip shared by @ktemby and therefore could be committed. (it also reduced by 80MB the size of my .ipa uploaded on Testflight)
I copy-pasted the dist folder inside my fork ios/dist folder
In my project I installed my repo: yarn add git+https://github.com/tiknil/viro
I setup both android and iOS to use my repo in ../node_modules/@tiknil/react-viro/
Both android and iOS are properly working with react native 0.62.2 and I was able to successfully submit my app to Testflight on the appstore

Note: I can not guarantee that my org repo will be maintained in the future, so if you decide to use it anyway it will be at your own risk.

@gbalduzzi similar situation here for VR functionalities.

installed @citychallenge/react-viro package.
overwritten ios dist folder with https://drive.google.com/file/d/1F_5i59mCIWorF8N7f5A-CbuugrFKv3ia/view.

It works and is published on both iOS and Android stores

Hi @Cosmitar, @gbalduzzi
in android/settings.gradle
do I need to add the following
include ':react_viro', ':arcore_client', ':gvr_common', ':viro_renderer'
project(':arcore_client').projectDir = new File(rootProject.projectDir,'../node_modules/@citychallenge/react-viro/android/arcore_client')
project(':gvr_common').projectDir = new File(rootProject.projectDir,'../node_modules/@citychallenge/react-viro/android/gvr_common')
project(':viro_renderer').projectDir = new File(rootProject.projectDir,'../node_modules/@citychallenge/react-viro/android/viro_renderer')
project(':react_viro').projectDir = new File(rootProject.projectDir,'../node_modules/@citychallenge/react-viro/android/react_viro')

notice "@citychallenge"

If you are using the citychallenge fork yeah. Adjust those path to whatever fork you are using

@dam00n Anyone on the team working on this?

@Cosmitar VR is working fine after publishing over the apple store?

@haider792 it is working so far

can you please guide me on this. my android side is working good i have change the setting as you have described i have installed the package and change the dist folder but it is still giving me the error.
Binary file<EMAIL_ADDRESS>matches.
Binary file ./ios/Pods/GVRSDK/Libraries/libGVRSDK.a matches
@Cosmitar

@gbalduzzi similar situation here for VR functionalities.

installed @citychallenge/react-viro package.
overwritten ios dist folder with https://drive.google.com/file/d/1F_5i59mCIWorF8N7f5A-CbuugrFKv3ia/view.

It works and is published on both iOS and Android stores

@haider792 the matches on grep -r UIWebView are still there, however Apple is accepting the build after overwriting dist folder. Did you tried to publish your app?

ITMS-90809: Deprecated API Usage - New apps that use UIWebView are no longer accepted. Instead, use WKWebView for improved security and reliability. Learn more (https://developer.apple.com/documentation/uikit/uiwebview).
this is the warning they are sending me in the email.

@haider792 two things that happened to me:
1 - I forgot to remove react-viro package after installing @citychallenge/react-viro package.
2 - typo in overwriting script wasn't overwriting /dist folder.
What I want to say with this, the patch works and probably in the whole mess there's a simple bothering mistake like I described above.
Don't give up, review the process, make sure you're overwriting the right /dist folder with the right downloaded source and that's the only react-viro code you're building.

@Cosmitar can you please guide me on this issue. attached is the image.
dyld`__abort_with_payload:
0x113a21ed4 <+0>:  movl   $0x2000209, %eax          ; imm = 0x2000209
0x113a21ed9 <+5>:  movq   %rcx, %r10
0x113a21edc <+8>:  syscall
->  0x113a21ede <+10>: jae    0x113a21ee8               ; <+20>
0x113a21ee0 <+12>: movq   %rax, %rdi
0x113a21ee3 <+15>: jmp    0x113a20408               ; cerror_nocancel
0x113a21ee8 <+20>: retq
0x113a21ee9 <+21>: nop
0x113a21eea <+22>: nop
0x113a21eeb <+23>: nop
crashing when changing the dist folder as you describe and ios is not running showing this error.

@gbalduzzi @Cosmitar can you help me out in this.
dyld: Symbol not found: OBJC_CLASS$_WKWebView
i have linked the webKit but still its showing the issue. can you please guide.

@Cosmitar can you please help me out in this issue. i am stuck on this for long time

@gbalduzzi ?

@haider792 Is hard to say with just one line of error description, I googled it  and looks like a configuration issue between versions of ios and web view component (it's my interpretation). Doesn't look  like an error related to Viro itself and I can't say much more about that.

@Cosmitar  i tried the repo of the @gbalduzzi shared with us but it showing this error you have any clue about this? please

@Cosmitar can you do a favour. might it will be helpful for many. can you please share the structure of the application including node_module. i know it is very difficult for you to do because its time taking. but it will be very helpfull for me as i am stuck in it for long time. or can you define the process step by step so i can do it and integrate directly. it will be very helpfull for me. having a tough time on it. Thanks .

if you can send me your email so we can have some private discussion please. @Cosmitar @gbalduzzi

Good news - Viro not dead for iOS! Making some further changes to the Viro source to get the static library compiling with no GVR (Viro in AR only mode), I was able to successfully upload to Apple/Testflight to get past the UIWebView blocker. Total hack, but happy to share what worked.
I'm now successfully using RN 0.62.2 and have Viro static library working great with no UIWebViews.
Note that below I'm using a temporary viro fork. This could be merged back to main if it meets the quality bar. I can't maintain a fork, I just want to contribute to viro. Below will take a couple of hours to figure out the details... it's taken me days to get this working, so I may be missing key steps.
Gist:
Part 1: Build the static lib with no GVR UIWebView:

Clone my Viro repo git clone https://github.com/ktemby/viro (hacked edits to remove GVR from static library target, I make no claims to have quality tested properly, especially for Android).
Build viro (from the viro folder, cd ios, pod install, then open ViroReact.xcworkspace in Xcode and build all the targets, the 'static lib' target last)

Part 2: Get your project to use my viro temp fork

Remove Viro from your current project npm uninstall react-viro
Install my github fork npm install git+https://github.com/ktemby/viro
Clear your build folder by doing a clean build of your app.

Part 3: Copy the locally built static library over to your project

Go back to where you built viro, we'll be copying the 'dist' (the static library files) over.
cp /viro/ios/dist/* ~<your project in part 2>/node_modules/react-viro/ios/dist/
Why?  Because the static library files that I built won't upload to my repo (they're too large).

Part 4: Rebuild your app with the updated library

Go back to your app directory.
Ensure you're using the static lib in your Podfile (see https://docs.viromedia.com/docs/no_use_frameworks)
Do pod install first from the ios folder.
Now build in xcode or with NPX.
Enjoy seeing your AR functionality now working in your app!
Upload to Apple and enjoy the feeling of not being rejected due to UIWebView.

Next steps?
I can post a sample RN 0.62.2 + Viro project with key configurations on the weekend if more details needed.
Takeaway - I was able to get this to work, and successfully submitted to Apple, but the quality of my effort is a way lower bar than you want, so please proceed with caution and understand my good intentions for sharing what worked for me is no replacement for your own diligence!

Hey @ktemby When I ran the command npx pod-install ios throws this error
Errno::ENOENT - No such file or directory @ rb_sysopen - /Users/XXX/Desktop/viro/node_modules/react-native/third-party-podspecs/DoubleConversion.podspec

any advice guys?
Thanks!

Hey @ManigandanRaamanathan, It seems the Mendix PR was merged. Btw, I use the master branch and on Android, I'm receiving this error
FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':app:preDebugBuild'.
> Could not resolve all task dependencies for configuration ':app:debugRuntimeClasspath'.
   > Could not resolve project :react-viro.
     Required by:
         project :app
      > Unable to find a matching configuration of project :react-viro:
          - None of the consumable configurations have attributes.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

 at checkExecSyncError (child_process.js:616:11)
    at execFileSync (child_process.js:634:13)
    at runOnAllDevices (/Users/erikahumada/Desktop/gwma/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/runOnAllDevices.js:94:39)
    at buildAndRun (/Users/erikahumada/Desktop/gwma/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:158:41)
    at then.result (/Users/erikahumada/Desktop/gwma/node_modules/@react-native-community/cli-platform-android/build/commands/runAndroid/index.js:125:12)
    at process._tickCallback (internal/process/next_tick.js:68:7)

This is my setup
System:
    OS: macOS 10.15.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 100.87 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.15.2 - ~/.nvm/versions/node/v10.15.2/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.2/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 11.6/11E708 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.5 => 0.61.5

Good news - Viro not dead for iOS! Making some further changes to the Viro source to get the static library compiling with no GVR (Viro in AR only mode), I was able to successfully upload to Apple/Testflight to get past the UIWebView blocker. Total hack, but happy to share what worked.
I'm now successfully using RN 0.62.2 and have Viro static library working great with no UIWebViews.
Note that below I'm using a temporary viro fork. This could be merged back to main if it meets the quality bar. I can't maintain a fork, I just want to contribute to viro. Below will take a couple of hours to figure out the details... it's taken me days to get this working, so I may be missing key steps.
Gist:
Part 1: Build the static lib with no GVR UIWebView:

Clone my Viro repo git clone https://github.com/ktemby/viro (hacked edits to remove GVR from static library target, I make no claims to have quality tested properly, especially for Android).
Build viro (from the viro folder, cd ios, pod install, then open ViroReact.xcworkspace in Xcode and build all the targets, the 'static lib' target last)

Part 2: Get your project to use my viro temp fork

Remove Viro from your current project npm uninstall react-viro
Install my github fork npm install git+https://github.com/ktemby/viro
Clear your build folder by doing a clean build of your app.

Part 3: Copy the locally built static library over to your project

Go back to where you built viro, we'll be copying the 'dist' (the static library files) over.
cp /viro/ios/dist/* ~<your project in part 2>/node_modules/react-viro/ios/dist/
Why?  Because the static library files that I built won't upload to my repo (they're too large).

Part 4: Rebuild your app with the updated library

Go back to your app directory.
Ensure you're using the static lib in your Podfile (see https://docs.viromedia.com/docs/no_use_frameworks)
Do pod install first from the ios folder.
Now build in xcode or with NPX.
Enjoy seeing your AR functionality now working in your app!
Upload to Apple and enjoy the feeling of not being rejected due to UIWebView.

Next steps?
I can post a sample RN 0.62.2 + Viro project with key configurations on the weekend if more details needed.
Takeaway - I was able to get this to work, and successfully submitted to Apple, but the quality of my effort is a way lower bar than you want, so please proceed with caution and understand my good intentions for sharing what worked for me is no replacement for your own diligence!

Hey, @ktemby thanks in advance for this. I took these steps,

Clone the repo git clone https://github.com/ktemby/viro.

Run the commands yarn && npx pod-install ios

Open ViroReact.xcworkspace

Select ViroReact target and then select Any iOS device (arm64) and build the selected target.

Select ViroReact_release_tests and then select Any iOS device (arm64) and build the selected target.

Select ViroReact_static_lib and then select Any iOS device (arm64) and build the selected target.

On my project
5. yarn remove react-viro
6. yarn add git+https://github.com/ktemby/viro
7. open my xcworkspace project and then run clean build folder(shift + command + k)
8. run cp -rf ../viro/ios/dist/* node_modules/react-viro/ios/dist
9. run npx pod-install ios
10. run watchman watch-del-all && npx react-native start --reset-cache
11. run npx react-native run-ios
The app runs but when I try to open the camera with the AR functionality I receive this error,

This is the output of the command grep -r UIWebView node_modules/*.
node_modules/create-react-class/node_modules/fbjs/lib/UserAgent.js.flow:   * - UIWebView
node_modules/create-react-class/node_modules/fbjs/lib/UserAgent.js:   * - UIWebView
node_modules/fbjs/lib/UserAgent.js.flow:   * - UIWebView
node_modules/fbjs/lib/UserAgent.js:   * - UIWebView
node_modules/jsc-android/dist/include/JSContextPrivate.h:/*! @abstract The delegate the context will use when trying to load a module. Note, this delegate will be ignored for contexts returned by UIWebView. */
node_modules/react-native-fbsdk/js/FBShareDialog.js:   * Displays the dialog in a UIWebView within the app.
Binary file node_modules/react-native-maps/.gradle/4.10.3/taskHistory/taskHistory.bin matches
node_modules/react-native-webview/README.md:- [7.0.1](https://github.com/react-native-community/react-native-webview/releases/tag/v7.0.1) - Removed UIWebView
Binary file node_modules/react-viro/ios/dist/ViroRenderer/static_lib/ViroKit_static_lib.framework/ViroKit_static_lib matches
Binary file node_modules/react-viro/ios/dist/ViroRenderer/static_lib/x86_64/ViroKit_static_lib.framework/ViroKit_static_lib matches
Binary file node_modules/react-viro/ios/dist/ViroRenderer/ViroKit.framework/ViroKit matches
Binary file node_modules/react-viro/ios/dist/ViroRenderer/x86_64/ViroKit.framework/ViroKit matches
node_modules/ua-parser-js/test/browser-test.json:        "ua"      : "Mozilla/5.0 (iPhone; CPU iPhone OS 10_0_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) Mobile/14A456 QQ/<IP_ADDRESS>0 V1_IPH_SQ_6.5.3_1_APP_A Pixel/1080 Core/UIWebView NetType/WIFI Mem/26",

This is my setup,
info Fetching system and libraries information...
System:
    OS: macOS 10.15.6
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 348.93 MB / 16.00 GB
    Shell: 5.7.1 - /bin/zsh
  Binaries:
    Node: 10.15.2 - ~/.nvm/versions/node/v10.15.2/bin/node
    Yarn: 1.22.4 - /usr/local/bin/yarn
    npm: 6.4.1 - ~/.nvm/versions/node/v10.15.2/bin/npm
    Watchman: 4.9.0 - /usr/local/bin/watchman
  SDKs:
    iOS SDK:
      Platforms: iOS 13.6, DriverKit 19.0, macOS 10.15, tvOS 13.4, watchOS 6.2
  IDEs:
    Android Studio: 4.0 AI-193.69<IP_ADDRESS>26763
    Xcode: 11.6/11E708 - /usr/bin/xcodebuild
  npmPackages:
    react: 16.9.0 => 16.9.0
    react-native: 0.61.5 => 0.61.5

it turns out that I had 2 different Viro packages and I was updating the dist folder into one but using the other.
After updating the right folder the VR is working as expected and Apple accepted the build without warnings! 🎉

same issue,  run grep -r UIWebView to detect the component. So I ran it into /dist folder shared by @pradipBhuva27 and had the following result
Binary file ./node_modules/react-viro/ios/dist/ViroRenderer/static_lib/ViroKit_static_lib.framework/ViroKit_static_lib matches

It can be fixed by replace the libs

It can be fixed by replace the libs

Could you have time to support me a bit in detail how could I do ?


Add test prereqs to test-inspira-solaris10u11-sparcv9-1

Test prereqs needed are listed here:
https://github.com/eclipse/openj9/blob/master/test/docs/Prerequisites.md
Based on console output of grinder run, test-inspira-solaris10u11-sparcv9-1 is missing ant (and perhaps other prereqs on that list).
fyi @gdams

added ant with pkgutil -i ant

re-running grinder here: https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_SandboxExtra/11/console

@gdams Could you please also install perl Text::CSV and XML::Parser module? Both are the test prerequisites.
https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_SandboxExtra/13/console

Another prerequisite listed in  https://github.com/eclipse/openj9/blob/master/test/docs/Prerequisites.md
ant-contrib.jar
https://ci.adoptopenjdk.net/view/work in progress/job/Grinder_SandboxExtra/20/console

Machine is currently broken as per #1634 and we have alternate machines now available via siteox, so I'm going to close this as "can't fix" just now


Apply retrolambda to custom JavaCompile tasks

I've a custom compileAndroid task which compiles my library project having the boot classpath set to android.jar of the corresponding minimum required Android API level, this ensures that only available methods are used.
task compileAndroid(type: JavaCompile) {
	source = compileJava.source
	classpath = compileJava.classpath
	destinationDir = new File(buildDir, 'android')
	options.bootClasspath = androidBootClasspath
}

But the compileAndroid task failes
> Task :smack-core:compileAndroid FAILED
/home/flo/data/code/smack/smack-core/src/main/java/org/jivesoftware/smack/SynchronizationPointWithSmackException.java:130: error: cannot find symbol
        reportFailureSetException(() -> {
                                  ^
  symbol:   method metafactory(Lookup,String,MethodType,MethodType,MethodHandle,MethodType)
  location: interface LambdaMetafactory
1 error

it appears that retrolambda is not applied to the compileAndroid task.
How do I manually apply it?

It's not well documented but to you can create a retrolamda task. Check out the source for the java plugin https://github.com/evant/gradle-retrolambda/blob/master/gradle-retrolambda/src/main/groovy/me/tatarka/RetrolambdaPluginJava.groovy

Thanks for your quick answer. Right now I wonder if I can even achieve what I want to achieve using Retrolambda: Writing Java 8 source code and linking that code against an android.jar of the corresponding Android API level. For this it seems to the required that retrolambda compiles the Java 8 source to Java 7 class files with simultaneously using the android.jar as boot classpath. But Retrolambda is only able to desugar Java 8 class files to Java 7 class files. Correct?

The major problem you'll run into is you need certain java 8 classes on the classpath for retrolambda to work. Have you considered using https://github.com/xvik/gradle-animalsniffer-plugin?

AnimalSniffer perfectly solves my use case, Thank you very much for pointing this out.


Measurement-Initiators interface to allow timestamp arguments when no detections are passed-in

See @sdhiscocks comment on line 192 of #321

Closed with #406


chore(main): release 1.0.1

:robot: I have created a release beep boop
1.0.1 (2023-03-12)
Bug Fixes

improve restart notice (059de38)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/joke/zim-rtx/releases/tag/v1.0.1 :sunflower:


Newbie! How to use

I am new to D and would like to convert an existing project which uses webview to D. I am wondering how to use this library, specifically linking. I have tried compiling webview to object file and linking but cannot get it to work. Do you have any basic guidelines?

In basic you can find working example that link to libweview.so.

If you want to link with object instead of library you need to place the object file in source directory and change
libs "webview"

to
sourceFiles "source/webview.o"
libs "stdc++" "gtk+-3.0" "webkit2gtk-4.0"

In dub.sdl.

I managed to get it working just before your reply. Using windows PC so was able to include the library locally and link through dub.
I am struggling with binding functions to the webview instance. Do you have any examples of how that can be done?

Do you mean how to use this function ?
void bind(string name, BindCallback fn, void* arg);

Yes, i cant ever seem to get the signature of the function correct and I believe a context is required whilst program is running according to webview docs

extern(C) void callBack(string seq, string req, void* arg)
{
 // code
}

w.bind("name", &callBack, null);

I didn't find this thread until after I got webview working. I did things differently. After downloading the webview project, I ran the build.sh in webview/script. This built webview.o as well as libwebview.so in the webview/build/ directory.
Then, since I an using dub.json, I appended the following property which allows the linker to find the lib:
"libs": ["$PACKAGE_DIR/libs/webview/build/library/libwebview.so"]
It seems like $PACKAGE_DIR is your project root where the dub.json file is located.
Hope that helps someone!


Deleting an asset from a smart album

Thank you for this awesome library. I am running into an issue deleting an asset from a smart album. I am trying to delete an image from the Screenshots album to be exact. I am getting back this error as a Promise rejection when calling:
album.removeAsset(myAsset)

I am getting back this error:
Error: The operation couldn’t be completed. (Cocoa error -1.)
    at createErrorFromErrorData (NativeModules.js:116)
    at NativeModules.js:79
    at MessageQueue.__invokeCallback (MessageQueue.js:290)
    at MessageQueue.js:127
    at guard (MessageQueue.js:46)
    at MessageQueue.invokeCallbackAndReturnFlushedQueue (MessageQueue.js:126)
    at debuggerWorker.js:71

I googled Cocoa error -1, but I am not sure I found anything helpful.
Any help would be appreciated. Thanks again!

Still an issue? I can take a look at this during the week if it is.


Upgrade hyper and url

As I happened to notice that you're already aware, url has a new 1.0 version with breaking changes out that the new version of hyper uses. Here's my attempt at upgrading both of those! ✨

nice. I just worked through a migration to some changes in other project the other day. fun stuff

My good friend  Travis is telling me it's cool. So I'll take it! Thanks @carols10cents

Yaaayyy!!!!!!


Change the custom UI when receiving an incoming call in android

When receiving an incoming call, it is pushing to a custom UI written in the package, I want to show a UI which I have designed, when pushing to the designed UI for answering the call the custom UI is dominating, is there a way to disable the custom UI for answering the call?

Hello, I don't think it's possible without forking the repo and customizing the UI in your branch. If you find another way to do it without working, please let me know


sh download.sh Error

python: can't open file 'scripts/download_glue_data.py': [Errno 2] No such file or directory

Hi,
It looks like the the dependent repo has been updated. You can replace https://github.com/cliang1453/super-structured-lottery-tickets/blob/caad8b6618831cfde9ba764bfe27ab7564dfda60/download.sh#L30-L37 with
`
DOWNLOAD GLUE DATA
Please refer glue-baseline install requirments or other issues.
git clone https://github.com/nyu-mll/jiant-v1-legacy.git
cd jiant-v1-legacy
python scripts/download_glue_data.py --data_dir $DATA_DIR --tasks all
cd ..
rm -rf jiant-v1-legacy
`


new endpoint: /setup/test_internet_download_speed

Sample Request
POST /setup/test_internet_download_speed
Content-Type: application/json
{
    "url": "https://storage.googleapis.com/reliability-speedtest/random.txt"
}

Sample Response
HTTP/1.1 200
Access-Control-Allow-Headers: Content-Type
Content-Type: application/json
{
    "bytes_received": 31457280,
    "response_code": 200,
    "time_for_data_fetch": 9554,
    "time_for_http_response": 130
}

This is used by the Chromecast backdrop (probably very old version of it), and it tests the internet speed, if not obvious by the endpoint url.

Really sorry for the delay. Just tested it and it works! Providing a url for any file also works.
This is pretty useful for automation. Thanks for creating this issue! I'll add it soon.

Sounds good!
Sent with GitHawk

Updated.


Add back Slowdown close to ground in manual flight

I'm bringing back the slow down functionality that keeps the drone from hitting the floor too hard when pressing full down configurable with MPC_LAND_ALT1 and MPC_LAND_ALT2. It was lost in the flight task changes and readded in FlightTaskAuto but no for manual flight.
As a reference here's the implementation of the 1.8 stable branch: https://github.com/PX4/Firmware/blob/f13bbacd5277123d6af2cb5ed21587c220031353/src/modules/mc_pos_control/mc_pos_control_main.cpp#L2437-L2441

Still relevant?

OMG I indeed ported the same implementation to upstream twice with a delay of 2 months 🤣
https://github.com/PX4/Firmware/pull/11540


"best practice question," not a bug report

in the case where you have two classes which you are validating: using the example code from this site: ... the issue is: the best way to test for a dependency on another Class' Property being non-null to validate in the "base" Class

class 'Customer
has a Property 'CurrentStore of Type 'Store; it may be null: it's not set to some non-null default
has a Property 'HasDiscount of Type 'Boolean
has a Property Discount of Type 'Decimal

class 'Store
has Property 'OffersPromotionalDeal of Type 'Boolean

In validating an instance of class 'Customer:
a. you want to test for the Property 'CurrentStore being non-null
b. you want to test for the Property 'Discount being less than a certain constant value
... of course, these first two validations are trivial ...
c. if the 'CurrentStore Property is non-null, and the Customer has a validated Discount, then you want to test for the 'CurrentStore having its 'OffersPromotionalDeal set to 'true.
Here's my best "guess" so far at how to implement the validation in #c:
RuleFor(customer => customer.CurrentStore).NotNull().WithMessage("the Customer must have a current Store selected.");

When(customer => customer.CurrentStore != null, () =>
{
     RuleFor(customer => customer.CurrentStore).Must(cstore => cstore.OffersPromotionalDeal == true).WithMessage("Store must currently offer a promotion");
});

While this code is passing all my tests, I think it probably could be done a better way. Obviously, I'd like to eliminate testing customer.CurrentStore twice. I have tried re-writing several different ways, trying to combine these two Rules, while keeping the custom error message. I assume, because I cannot do it, that you can't stick a custom error message on a 'When validator.

This is not an uncommon request.   Have a look at this article where I requested the same thing and @JeremySkinner implemented it.
https://github.com/JeremySkinner/FluentValidation/issues/65

Thank you, Wayne,
It always gives me hope when I discover one thing I've thought that was not totally an outcome of ignorance, folly, and error :)
Will study all your posts as I continue to experiment with FluentValidation.
cheers, Bill


Bug Fix: Update constants.ts

Fixes "Error getting Ollama models: TypeError: fetch failed" on clean build (non docker using pnpm install & pnpm run dev).

Fixes issue/bug #530

Did you test, does it actually work?
I mean we have both client and server using this.
Client uses it to show a dropdown.
Server uses it too.
My first impressions is that you will get errors when you actually call the model later.

Did you test, does it actually work? I mean we have both client and server using this. Client uses it to show a dropdown. Server uses it too.
My first impressions is that you will get errors when you actually call the model later.

Yes, it works with a clean build. It only skips if undefined/not set, the same as several others already do. If the value is set, it operates as normal.

Could probably be cleanup with a generic/shared function so the behavior of all LLM's can be guaranteed to be the same.
So probably make this logic consistent (early break if baseUrl is not set):
  try {
    const baseUrl = getOllamaBaseUrl();

    if (!baseUrl) {
      return [];
    }
    ...

The proposed change is better, closing and I'll put in a new PR.


⚠ Bofrost.at has degraded performance

In a7b9b16, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 1764 ms

Resolved: Bofrost.at performance has improved in 9b533bf after 6 minutes.


Window Transparency (See Through)

Description of the new feature / enhancement
Add functionality that allows you to adjust the transparency of a window or application.
This feature would allow users to interact with an application in a way that allows you to "see through" a window while interacting with it.
Scenario when this would be used?
Graphic designers or simple image editors often have trouble cropping & warping an image relative to a reference image.
For example:
A user needs to warp the perspective of a flat 2D image of a book cover they designed so that it can be placed atop a mockup image of a book that's lying on a table. The user needs the perspective of the book cover image to match the perspective of the mockup.
This transparency feature would allow the user to position the image editing window (where they're transforming the book cover) on top of an image of the book mockup image window and "see through" it to get the warping just right.
Supporting information
This can certainly be achieved with most free & paid image editing software by adding and adjusting image layers & transparency, but many users may prefer easier, less complicated methods to achieve the same result.

/dup #1084


Release Google.Cloud.ConfidentialComputing.V1Alpha1 version 1.0.0-alpha04

Changes in this release:
New features

Add additional TokenType options (TOKEN_TYPE_PKI and TOKEN_TYPE_LIMITED_AWS) (commit 9cd40a3)

Created release for Google.Cloud.ConfidentialComputing.V1Alpha1-1.0.0-alpha04


OIDC Azure issue

Hello,
I'm having this config
...
      scopes:
        - openid
        - email
        - profile
      claimMapping:
        admin: "'WireguardAdmins' in group_membership"

Also WireguardAdmins group in my OIDC provider (Azure). When I'm tring ti sign in - I'm getting that error:
No parameter 'group_membership' found.

The issue is that with azure token returns groups with value in double array:
map[amr:["pwd","mfa"] family_name:Bilenko given_name:Maksym groups:[["6287e903-8c1f-42fe-8d3d-36e4e7155d5f","0de42929-8f96-4215-9e92-89cd32cfdf76","d4795a7f-2823-4274-8af8-ee83b664f777","2e293763-0fdd-4d2c-9a34-049f9048ae9d"]] ipaddr:<IP_ADDRESS> name:Maksym Bilenko ...

Can't find the way to compare group ID with double array value of groups

The maintained fork is here:
https://github.com/freifunkMUC/wg-access-server


Find Mode API

Implements API as per https://github.com/ROCmSoftwarePlatform/MIOpen/issues/336#issuecomment-701882762 (and below).

FindMode made a member of ConvolutionDescriptor.
Added & implement public API and a macro for versioning.
Used in the driver and in test_find_db.
Got rid of miopen::debug::FindModeDisable hackery.
Removed MIOPEN_FIND_ENFORCE_SCOPE.

:cyclone: Local performance & correctness testing

Radeon VII, ROCm 3.5.
Baseline (develop at e08e23d24) vs this PR (ccd674c8a)
GPU time, Wall time, Aux Wall time were examined, as well as correctness.

NORMAL Find mode, Immediate mode

HIP backend, 93 known FP32 + 93 known FP16 configs - :heavy_check_mark: NO REGRESSIONS
OCL backend, 93 known FP32 configs  - :heavy_check_mark: NO REGRESSIONS

NORMAL, FAST, HYBRID, FAST_HYBRID, DYNAMIC_HYBRID Find Modes

HIP backend, 93 unknown FP32 configs - :heavy_check_mark: NO REGRESSIONS

All local testing done.

BTW 308d389 has passed all CI checks. I do not know why this page doesn't show this.

Will normal find mode be enabled when the user passes true for exhaustiveSearch`?

Will normal find mode be enabled when the user passes true for exhaustiveSearch`?

No

Let me try to support this. Earlier that wasn't possible.

Well, this is not possible unless exhaustiveSearch is passed to the GWSS calls.

@pfultz2 Right now, in order to use exhaustiveSearch, the user should explicitly set Find Mode to NORMAL in the environment or via the API calls provided in this PR. Maybe it is worth to declare this flag deprecated.
Then we can implement similar API for Search Mode (now MIOPEN_FIND_ENFORCE env var)m and that API will be able to enforce Find Mode properly. What do think?

[off-topic] @daniellowell @pfultz2 Right now, after committing f9d49b5, github shows "All checks have passed" but testing didn't even started yet. Looks like github WebUI is one step behind our CI.

[off-topic] Aha, we just have a time gap. After the commit, the github shows the previous status until the next round of testing begins. It can be up to 20 minutes long.

All, CI tests passed 16 days ago (github's indication is wrong again). Let's do something if we need this.

@pfultz2 Hidden functions changed from C++ to C. Prototype:
miopenStatus_t miopenHiddenSetConvolutionFindMode(
    miopenConvolutionDescriptor_t convDesc,
    int findMode);

@pfultz2 @JehandadKhan Merge conflicts resolved, no changes. Please re-approve.

@daniellowell All CI checks passed, so this can be merged now.

@daniellowell Ping. Or I can merge this myself.

Ping


No longer an option

Adding the OneDrive Desktop application via this method does not appear to be available any longer, only the legacy (Groove) app is listed in the Configuration designer via the Endpoint Manager admin center.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f6d65d08-b216-1f92-cc37-40690fb3d627
Version Independent ID: ee040702-91ce-203a-7ae2-1fa9a52a9843
Content: Deploy OneDrive apps using Intune - OneDrive
Content Source: OneDrive/deploy-intune.md
Service: one-drive
GitHub Login: @kaarins
Microsoft Alias: kaarins

Seeing the same thing and came her to put in the same issue.

Thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@scanum - I did open a ticket with support as you suggested and they are reporting seeing the same thing as my screenshot above (that just the Groove version is showing).  I think this requires further research and change on the documentation side.

@RMC-Kbly - Microsoft Support confirmed the documentation was incorrect and has updated the screenshot.


Unify tracker limit variable

The tracker limit was independently defined in two locations. Now it is
controlled by just the one variable (PSMOVESERVICE_MAX_TRACKER_COUNT).

I like the idea but this is the wrong way to do it. Theoretically the server should be able to compile even if the client code is entirely absent. Also, there's no reason for the server to care what the client thinks the maximum number of cameras should be. It makes a little more sense the other way around, but it's also possible that someone can put a client-specific limit on the number of cameras that's independent of what the server's doing.
Option 1: Move the constant declaration to the server, change the client code so it doesn't need a const to initialize its data structures, have the client ask the server for the camera count before initialize data structures / threads.
Option 2 (easier): Let the server and client specify their limits independent of each other, but allow the client to fail gracefully if there are fewer cameras available than the client max.

We could also move the constant into a library shared between the the client and the server, specifically the psmoveprotocol library. Perhaps in https://github.com/cboulay/PSMoveService/blob/master/src/psmoveprotocol/PSMoveProtocolInterface.h?

Okay how's this? I went with HipsterSloth's suggestion of defining them in PSMoveProtocolInterface.h because there were already some constants stored there.

I just realized that the client C API needs to include ClientConstants.h, which can't have any C++ in it. I'm going to accept this PR, but then move the constants into a new SharedConstants.h that can be safely  included in the Client C-API. I'll comment here when that work is done.

I just checked in the following:

Moved shared constants from PSMoveProtocolInterface.h into to new SharedConstants.h that's part of the PSMoveProtocol library (which both clientAPI and server include)
Updated ClientConstants.h to include SharedConstants.h
Updated PSMoveProtocolInterface.h to use SharedConstants.h
Fixed up cmake files to copy SharedConstants.h into install include folder

https://github.com/cboulay/PSMoveService/commit/b8345bcba6b9e1d8ebed1d6a6079d5eee5525df7
I have an updated test release of PSMoveSteamVRBridge out  for testing on the google group.
@cboulay Thanks for the review feedback!
@zelmon64 Thanks for getting the ball rolling with the PR!


not find package.json/package-lock.json/yarn.lock in repo

undefined

@pamelafox  any idea on this one before I try to dig in?

Hi @Dipanda-Hub, could you provide more details on the error and a screenshot? There should not be a package.json/yarn.lock for this repo, since there is no use of NPM/JavaScript, so I'm not sure when such an error would pop up.

Closing for now. @Dipanda-Hub please reopen with reply to Pamel. Thanks @pamelafox.


Fix issues with custom cache eviction

In https://github.com/julia-actions/cache/pull/71 when we introduced saving cache entries for each matrix job we also introduced a manual cache eviction step to attempt to evict unnecessary cache entries in a better way than the default GitHub behavior (evict the oldest). Unfortunately, we have ended up being a little overly aggressive in our cache eviction policy which has resulted in the following problems:

We assume that a cache entry will be saved upon every job run so it is save to evict all cache entries on that branch before we save the new entry. For failed jobs no new cache entry is saved so we end up starting from scratch on subsequent runs. In this PR I've updated the behavior to always keep the latest cache entry (possibly in addition to the new cache entry) so failures like this can use the last saved entry.
We perform cache eviction on entries from the default branch. As GitHub action caches can only be pulled from the current branch or the base branch the default branch can be rather important for falling back on for a base cache entry. When new commits are added to the default branch the old cache entries are evicted which can leave PRs with no base cache to fall back on. I now avoid performing our manual cache eviction on the default branch to avoid this kind of problem.

I've done some testing against this change on a private repo and have been happy with the results. We still have the issue with the scenario where a job which fails doesn't save a cache entry but since we can at least reliably fallback on the default branch cache entry things are in a much better state.

Sounds good and thanks for the external testing


AFURLConnectionOperation.h Semantic Issue. This block declaration is not a prototype

Line 69 in AFURLConnectionOperation.h throws a Semantic Issue warning in Xcode 9.1.
Changing from
typedef void (^AFURLConnectionOperationBackgroundTaskCleanupBlock)();
to
typedef void (^AFURLConnectionOperationBackgroundTaskCleanupBlock)(void);
silences the issue.
Update: Target platform is set to iOS.

What version of AFNetworking are you using? The latest version does not include AFURLConnectionOperation.h.


Implement 'Login with telegram' as a button on the website but do not want to use the telegram widget

❓ Support Question

<--
❗ NEVER put your Telegram API key or any other private details here. (like passwords, user IDs, etc.)
Substitute them like <API_KEY> or <USER_ID> etc.
-->
Required Information

?
!

Operating system
Ubuntu and 20.04

PHP Telegram Bot version
0.73.1

PHP version
7.3.33

MySQL version
8.0 / none

Update Method
Webhook

Self-signed certificate
no

RAW update (if available)
{...}

Summary
We need to implement 'login with telegram' on our website. We won't use the Telegram Login Widget (because it is weird, asks for the phone number, etc.). I followed the LoginUrl example and we are able to log in if a user clicks the login button inside the telegram app (as displayed in the first image). But we need a login button on our website which will say 'Login with telegram' and when the user will click on this button then the authorization should work(as displayed in the second image). Is it possible to implement such a login button with the help of the current telegram bot API?

image-1

image-2

Hi @pavanyogi
Asking for the phone number is default procedure, same as when you install Telegram on any device or use the web version, as the user account is linked to the phone number.
Maybe I'm misunderstanding something.
What would you like to have happen when a user clicks the "Login with Telegram" button?

Hi @noplanman,
Now we are ok with the existing behavior of Seamless Telegram Login. We have included the Seamless Telegram Login.

So no open question in this issue, right?


Feat: Enhancing the UI of free e-books  page

Describe the feature
UI of free e-books looks not good, which may leads to poor user interaction. This PR will enhance the UI to make it look more better.
Add ScreenShots
Current poor UI with improper alignment of elements:

Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned 👍


Offline: Open a preplanned map area

Closes swift/5358
Adds support to open a downloaded preplanned map area with the "open" button which dismisses the view and returns a Map via the onMapSelectionChanged view modifier. If the preplanned map area's mobile map package fails to load when opened then the view's status is set to mmpkLoadFailure.

This PR is ready for re-review.

@philium can you please re-review this PR when you have a chance? Thank you!

Thank you both!


Users cannot link directly to hidden or private rooms with modjoin

Taking note of this here so other people can see this and maybe have a solution.
When someone goes to play.pokemonshowdown.com/roomname, the join request will complete before the /trn request has been sent back to the server. This means that since the user is not counted as "logged in" at the moment, they have no auth or roomauth to check, and therefore the server will pretend that the user does not exist.

@Joimer says that we should use a purely client-side fix where if a user has a logged-in cookie, it should wait until /trn is sent before attempting to send any /join commands.

The client currently already auto-retries joining private rooms after logging in. It should be a simple change to make it auto-retry joining modjoin rooms, too (i.e. rooms that don't exist) as well.

So have the server send namerequired on all modjoin rooms (plus nonexistent rooms to prevent leaks) if it detects a user is not logged in?

Or just try to join the room listed in the URI again, and if it fails, just ignore the error

So have the server send namerequired

No, have the client interpret nonexistent rooms the same way it currently interprets namerequired

Fixed by https://github.com/Zarel/Pokemon-Showdown/commit/39d2715ddb0d0a1142d0f1c235b01c4e7e3538ab


FluidBufLoudness error says "FluidBufPitch"

If FluidBufLoudness is passed an invalid buffer, it reports an error that says "ERROR: FluidBufPitch:  Invalid features buffer". This is just a copy paste error that needs fixing. I bet that there are more classes that also report errors incorrectly.
I'm pretty sure that there is a way to programmatically get the class name (such as with thisMethod) so the error reporting can be copy and pasted across the whole repo and report correctly.

fixed with<PHONE_NUMBER>93e4f54ce3bf51025f373f5c06b140


feat: support dynamically set min_temp and max_temp in climate #445

@chrisns What about
isValueId (id) {
    return id ? id.split('-').map(v => parseInt(v)).filter(v => isNaN(v)).length === 0 : false
}

er confused!? that doesn't really make it more readable
I was more thinking along the lines of:
function myWizzBangFormatter(in) {...}
payload.min_temp = myWizzBangFormatter(payload.min_temp)
payload.max_temp = myWizzBangFormatter(payload.max_temp)

where myWizzBangFormatter returning undefined is perfectly acceptable

@chrisns I understand what you mean but return undefined is not like not having that field set, and Hass could reject the discovery payload. If I set that to undefined that property will still be visible in the hass payload

then do like
myWizzBangFormatter(payload, 'min_temp')

?

i'm still not sure about that, what other types are we anticipating it being?

You mean the valueid.value? It could be a string/number


Use voluptuous for Universal media player

Description:
Migration of the configuration check to voluptuous.
Related issue (if applicable): fixes 127528299
Example entry for configuration.yaml (if applicable):
media_player:
  - platform: universal
    name: MEDIA_PLAYER_NAME
    children:
      - media_player.CHILD_1_ID
      - media_player.CHILD_2_ID
    commands:
      turn_on:
        service: SERVICE
        data: SERVICE_DATA
      turn_off:
        service: SERVICE
        data: SERVICE_DATA
      volume_up:
        service: SERVICE
        data: SERVICE_DATA
      volume_down:
        service: SERVICE
        data: SERVICE_DATA
      volume_mute:
        service: SERVICE
        data: SERVICE_DATA
    attributes:
      is_volume_muted: ENTITY_ID|ATTRIBUTE
      state: ENTITY_ID|ATTRIBUTE

At the moment the a lot of tests are failing. Perhaps somebody can give me a hint for the fix.

This has a linting error to be resolved and also it seems like it breaks the tests.

What is the status of this?  From what I can tell, this is the last item left on #2800 (Use voluptuous).

State is: Tests are failing


DMT-85 Resize donut when labels outside

Related issue

Closes #80

Proposed changes

Resize donut when labels rendered outside the donut
Shorten label text when outside donut to fit mod container

Additional information

Delete some old functionality to make this functionality work

Nice work!


Fix outdated field name in manifest-v2

use_tmpfs_job_config was renamed to use_tmpfs_config

https://www.pivotaltracker.com/story/show/168845016


[FLINK-6215] Make the StatefulSequenceSource scalable.

So far this source was computing all the elements to
be emitted and stored them in memory. This could lead
to out-of-memory problems for large deployments. Now
we split the range of elements into partitions that
can be re-shuffled upon rescaling and we just store
the next offset and the end of each one of them upon
checkpointing.
The current version of the PR has no backwards compatibility,
as this becomes tricky given that we change the semantics
of the state that we store.
I believe that this is ok, given that it is a fix that has to go in
the 1.3 and we are not sure if people are actually using it in
production, i.e. in settings that need backwards compatibility.
What do you think @aljoscha @StephanEwen ?

@kl0u how important is this for 1.3?

@greghogan Not sure. In my understanding that was made for testing (this is why the old implementation was not efficient) but there may be also some more serious users. Any comments @aljoscha ?

I think this would be crucial. It does not even work for any meaningful tests in the way it is in the code right now.
+1 for putting this into 1.3 as a bugfix


Add MustChangePassword field to add/edit user for API

As titled. Once merged, I can add the field to Gitea's API. This would allow instance owners to enforce users changing passwords.

Make lg-tm work


build multiple themes in one pass

This PR will be merged after we all finished the improvement of bootswatch themes.

Best practice!


Install zip/unzip

A nice-to-have, but not essential. It would allow make to do more bundling/packaging.

It should be fixed in trzeci/emscripten:sdk-incoming-64bit (also 32 bit), and it will be a part of the 23th version of the image.


Correction for raw affiliation Western University Western University

Correction needed for raw affiliation Western University Western University
raw_affiliation_name: Western University Western University
new_rors: 02grkyz14
previous_rors: 05cgtjz78
works_examples: W4360593204;W4388727027;W4385885009;W4386928715;W4385553950
contact: 65dbc6db40b0b4e30df9f8ee9832c105:5763b966075e638d @ uwo.ca

This issue was accepted and ingested by the OpenAlex team on 2024-12-19. The new affiliations should be visible within the next 7 days.


New Release

Add manifest.json for Android Webapp

Coverage remained the same at 47.582% when pulling e60785e19f99c916e23d2931f2fc1ffa2db6db89 on develop into 6348aa360ecb6323acb1d97104e9a2588bf6829c on master.


Lack of JAR file of v1.1.0

There isn't the corresponding JAR file of detekt v1.1.0.

I'm assuming this is why nothing has been pushed to the Maven repos?
https://mvnrepository.com/artifact/io.gitlab.arturbosch.detekt/detekt-core

I think you meant 1.1.1. Yep, the sync from JCenter to MavenCentral failed due to timeout.
I triggered a resyn. I should be up today. Thanks!


RAutomation doesnt work on SeleniumGrid

Meta -
OS: Windows 7
Selenium Version: 2.52.0, IDE, etc
Selenium Grid Extras 3.0.1
Browser: Chrome
Browser Version: 54.0.2840.99 (64-bit)
Expected Behavior -
Below code which clicks on "Browse File" and open windows popup to browse file and submit should work on Selenium & Selenium Grid
HTML Code

<input type="file" accept="text/csv,application/vnd.ms-excel,application/vnd.oasis.opendocument.spreadsheet,application/vnd.openxmlformats-officedocument.spreadsheetml.sheet" id="navigate-to-browse-file" class="input-box full-width ng-pristine ng-untouched ng-valid ng-empty" ngf-select="" ng-model="vm.uploadFiles" ngf-multiple="false" aria-invalid="false">Browse File

Ruby Capybara RAutomation Code
And I click the tag "span" with text "Browse File" - Clicking the browse button works
Code for the selecting file in the window popup
file=$uploadfile_path
file = Dir::pwd + "#{file}"
file=file.gsub! "/", "\\"
window_handle = RAutomation::Window.new(:title => /#{window}/i)
window_handle.text_field(:class => field_input, :index => 0).set file

Actual Behavior -
Above code works with Selenium and doesn't work with SeleniumGrid
Steps to reproduce -
Click on browse file functionality in any application (cannot provide link to our application) ex: https://uploadfiles.io/
In windows popup enter the file path
browse file
window popup
screenshots

Have not used Selenium nor Selenium Grid so don't have any ideas how that interferes with RAutomation. RAutomation is a totally separate library which is not dependent in any other automation libraries thus there is no specific code related with Selenium, Selenium Grid or any other automation library.
This probably means that the problem (you didn't give any backtrace or anything indicating what does "doesn't work" mean) is within Selenium Grid or Ruby instead.
Closing this issue, but you can reopen it if you think that the problem still lies within RAutomation.

We use Ruby-Cucumber-Selenium automation framework and selenium grid to run automation scripts parallel on multiple machines.
Rautomation successfuly handle window popup on Single machine and below is the error when i run same script on SeleniumGrid
Unable to find file field "navigate-to-browse-file" (Capybara::ElementNotFound)

Capybara::ElementNotFound exception is definitely not a RAutomation error.


disable enabling fullscreen on mac

Especially since mac users can easily full screen with the green button top left
As this causes an assert error

A temporary solution for this could be to:

[ ] Detect when user is on Mac
[ ] Disable the Full Screen functionality
[ ] Implement a Borderless mode


Zero initialize observations

On a GPU, it seems either Madrona or the CUDA runtime zero-initializes the memory backing PartnerObservations and AgentMapObservations. On a CPU, this memory is left uninitialized which manifests itself as some floats taking on a nan value.
This PR zero-initializes PartnerObservation and AgentMapObservation which are unfilled. Note that k-NN already zero-initializes unfilled features and so does not need updating.

Looks good. Can you also take a look at #174 which is a similar issue ?


Pop up an error dialog when deleting one blob with AzCopy checked

Storage Explorer Version: 1.10.1
Build: 20191012.1
Branch: master
Platform/OS: Windows 10/ Linux Ubuntu 19.04/macOS High Sierra
Architecture: ia32/x64
Regression From: Previous release (1.10.1)
Steps to reproduce:

Expand a non-ADLS Gen2 account -> Blob Containers.
Make sure the AzCopy is checked.
Create a new blob container -> Upload a blob to it.
Delete this blob and check the result.

Expect Experience:
The blob can be deleted successfully.
Actual Experience:
Pop up an error dialog.

More Info:
This issue also reproduces for delete the snapshots of the blob.

This will be resolved by tonight's (10/14) build.

This issue has been fixed on build 20191015.4. So we close it.


Specifying what a 'new user' is.

Adding a 'new user' means at the org level. If this policy is on Team / Project admins wont be able to add new users to the ORG, but will still be able to add users to their projects if they already exist in the org.

@MS-alsulli : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Will resolve issue #9502

#sign-off

Thank you @MS-alsulli!


Refactor repo to avoid confusion with Camunda Platform 8

Can this repo be refactored to avoid clashing with Camunda Platform 8 Helm charts? It's creating a lot of confusion (ie helm.camunda.cloud vs helm.camunda.io) as well as instructions (helm repo add camunda......) It should be more obvious you're working with Camunda Platform 7 (helm.camunda.bpm or something along those lines) and (helm repo add camunda-bpm...)

Thanks @superbeagle for your suggestion, totally makes sense.
I've mentioned Camunda Platform 7 clearly in the chart and docs as well as a link for the official Camunda Platform 8 Helm repo.
Also, I've used v7 as a base version for the chart.
It has been released as: camunda-bpm-platform-7.6.0


Production Package not promoted yet

Hi James,

Seems like the package hiding behind the Install in Production Button is not yet promoted.  Mind taking care of that? 😄

Interesting … my build script in GitHub Actions is supposed to promote the package automatically. I will promote in just a few minutes, apologies!

All set!


Fixes #55

Coverage decreased (-0.6%) to 34.643% when pulling 10ad0c9d9e4f7b00f8ec1b403136c75c993e6194 on heuermh:issue-55-take-two into 7a098f6fc91b9d5420ecfb18ef5aafb5e6311a56 on bigdatagenomics:master.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/cannoli-prb/45/
Test PASSed.

Thanks @heuermh!


[feature] Bidirectional path tracing

Is your feature request related to a problem? Please describe.
While diffuse lighting already has barely any noise, indirect diffuse lighting and more importantly caustics are poor, and in the case of caustics they’re not effected by direct light.
Describe the solution you'd like
BDPT is an unbiased method for drastically reducing the variance created by these light interactions, compared to the arguably simpler to implement but biased photon mapping.
Unlike with backwards path tracing, there’s no simple step by step guides that explain the logic (e.g. scratchapixel), however after reading a paper and a few articles on it, it doesn’t seem entirely out of my reach, and wouldn’t take "much" more to upgrade to metropolis light transport.

Started work on this now, oh boy.


Feign request parameters are duplicated

From http://stackoverflow.com/questions/32098906/spring-cloud-feign-client-duplicate-list-values
I have this interface mapping my rest client using Spring cloud Feign.
@FeignClient(url = "http://localhost:8080")
public interface RestClient {

    @RequestMapping(value = "?ids={ids}", method = GET)
    List<Posicao> get(@RequestParam(value = "ids") List ids);
}

I have a list in my parameters, calling the client I have this request:
restClient.get(Arrays.asList(1, 2));
http://localhost:8080/ids=1,2,1,2

It's duplicating the list values!

The request mapping should be @RequestMapping(value = "/", method = GET).

@spencergibb
@FeignClient(url = "http://localhost:8080")
public interface RestClient {

    @RequestMapping(value = "/", method = GET)
    List<Posicao> get(@RequestParam(value = "ids") Long[] ids);
}

I got MethodArgumentTypeMismatchException error

Is it a List or a Long[] on the server (looks like a mismatch to me)?

yes,all mismatch, it is a bug?


Pass linking and compile options to test in Scala Native

Pass nativeLinkingOptions and nativeCompileOptions from testOuter to test
Substitute platformSuffix with :: in ScalaNativeModule

Motivation
With current mill if you need native linking or compile options they are not passed to the Scala Native test and it fails to link.
I'm not testing this because it would mean to add link-time dependencies to test mill

Looks good to me I think, but I'll have to trust that you know what you're doing :)

Thank you for the trust :)


ID3v2.4 metadata list writing support

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm requesting a site-specific feature
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
[X] I've searched known issues and the bugtracker for similar issues including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue
[ ] I've read about sharing account credentials and I'm willing to share it if required

Region
No response
Example URLs
https://www.youtube.com/watch?v=QmnI9nJPs_E
https://www.youtube.com/watch?v=CkXbkVhrFU4
Provide a description that is worded well enough to be understood
The ID3v2.4 spec states that in the case of a song with multiple artists or other tags with multiple values, they should be delimited with null characters. (Unicode 0x00 / Python \u0000). See the id3 spec section 4.2 introduction. Please add the ability to encode information in this way (e.g. add a output template flag, or change the default delimiter from commas to null characters). A proposed solution is available here:
https://github.com/yt-dlp/yt-dlp/compare/master...MutantPiggieGolem1:yt-dlp:patch-2
(I made a feature request instead of a pr because I am not certain that my code complies with best practices, or is the correct approach for this problem)
Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[ ] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['https://www.youtube.com/watch?v=QmnI9nJPs_E', '-vU', '--progress', '-o', './%(id)s.%(ext)s', '-f', 'm4a/bestaudio/best', '-x', '--audio-quality', '0', '--audio-format', 'm4a', '--embed-metadata', '--output-na-placeholder', 'Unknown', '--parse-metadata', 'release_date:%(meta_date)s', '--parse-metadata', '%(artists)+l:%(meta_artist)s', '--embed-thumbnail', '--ppa', 'ffmpeg: -c:v mjpeg -vf crop="\'if(gt(ih,iw),iw,ih)\':\'if(gt(iw,ih),ih,iw)\'"', '-N', '4', '--external-downloader', 'aria2c', '--external-downloader-args', '--max-connection-per-server=16', '--no-overwrites']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out cp1252 (No VT), error cp1252 (No VT), screen cp1252 (No VT)
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [542166962] (win_exe)
[debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.19045-SP0 (OpenSSL 1.1.1t  7 Feb 2023)
[debug] exe versions: ffmpeg 2023-01-16-git-01f46f18db-full_build-www.gyan.dev (setts), ffprobe 2023-01-16-git-01f46f18db-full_build-www.gyan.dev
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-14.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
WARNING: External Downloader arguments given without specifying name. The arguments will be given to aria2c
[debug] Loaded 1837 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)
[youtube] Extracting URL: https://www.youtube.com/watch?v=QmnI9nJPs_E
[youtube] QmnI9nJPs_E: Downloading webpage
[youtube] QmnI9nJPs_E: Downloading ios player API JSON
[youtube] QmnI9nJPs_E: Downloading mweb player API JSON
[debug] [youtube] Extracting signature function js_03dbdfab_107
[debug] Loading youtube-sigfuncs.js_03dbdfab_107 from cache
[debug] Loading youtube-nsig.03dbdfab from cache
[debug] [youtube] Decrypted nsig rOVGFBO1fnpq4VowB => iVX3HC88LHdogg
[debug] [youtube] Extracting signature function js_03dbdfab_103
[debug] Loading youtube-sigfuncs.js_03dbdfab_103 from cache
[debug] Loading youtube-nsig.03dbdfab from cache
[debug] [youtube] Decrypted nsig JHYFJ6_jdvzKqlN_m => WyB0jk7seawvKw
[youtube] QmnI9nJPs_E: Downloading m3u8 information
[debug] Sort order given by extractor: quality, res, fps, hdr:12, source, vcodec, channels, acodec, lang, proto
[debug] Formats sorted by: hasvid, ie_pref, quality, res, fps, hdr:12(7), source, vcodec, channels, acodec, lang, proto, size, br, asr, vext, aext, hasaud, id
[debug] Searching for '(?P<meta_date>.+)' in '%(release_date)s'
[MetadataParser] Parsed meta_date from '%(release_date)s': '20240322'
[debug] Searching for '(?P<meta_artist>.+)' in '%(artists)+l'
[MetadataParser] Parsed meta_artist from '%(artists)+l': 'girl in red, Sabrina Carpenter'
[info] QmnI9nJPs_E: Downloading 1 format(s): 140
[info] Downloading video thumbnail 42 ...
[info] Writing video thumbnail 42 to: QmnI9nJPs_E.webp
[debug] Invoking aria2c downloader on "https://rr2---sn-nvopjoxu-25ve.googlevideo.com/videoplayback?expire=1734957265&ei=cQRpZ57MJruAsfIPgNiA6QY&ip=<IP_ADDRESS>&id=o-ABgVtdYN07MvGprEN4a5KAvR4BBlPHK3XJx-kWz3N7nQ&itag=140&source=youtube&requiressl=yes&xpc=EgVo2aDSNQ%3D%3D&met=1734935665%2C&mh=J-&mm=31%2C29&mn=sn-nvopjoxu-25ve%2Csn-o097znzk&ms=au%2Crdu&mv=m&mvi=2&pcm2cms=yes&pl=21&rms=au%2Cau&gcr=us&initcwndbps=4901250&bui=AfMhrI_I2OkVs8ELIeoHcOtM1XbPR78e-AgC1YJR2G2lH_BY99uuuGXcyLYXyNo29dQpOTHyjhM04Cxn&spc=x-caUITTvjqMZmgH7Xgeg9lR80dEnP4HJmiv4xxVFMBJ8IhdVt2l&vprv=1&svpuc=1&mime=audio%2Fmp4&rqh=1&gir=yes&clen=3019100&dur=186.377&lmt=1710543003824326&mt=1734935346&fvip=1&keepalive=yes&fexp=51326932%2C51335594%2C51371294&c=IOS&txp=2318224&sparams=expire%2Cei%2Cip%2Cid%2Citag%2Csource%2Crequiressl%2Cxpc%2Cgcr%2Cbui%2Cspc%2Cvprv%2Csvpuc%2Cmime%2Crqh%2Cgir%2Cclen%2Cdur%2Clmt&sig=AJfQdSswRgIhAPj6QzOZU3xvvq4B-Dcv6RkopnTfYZDuB_t9G1WIOQH5AiEA0Fxqq6QE1XaPvv4xliszI7yH2--YNp7VMKSWeK9rDdU%3D&lsparams=met%2Cmh%2Cmm%2Cmn%2Cms%2Cmv%2Cmvi%2Cpcm2cms%2Cpl%2Crms%2Cinitcwndbps&lsig=AGluJ3MwRgIhAKqerMN22lAzm64V4-CmnWwg5WHMGWZPhk07Skxo6jkiAiEA_M7M59_goBI1NOvucD712gfGQDWX7q8MZx4Ho1m07Ak%3D"
[download] QmnI9nJPs_E.m4a has already been downloaded
[download] 100% of    2.91MiB
[debug] ffmpeg command line: ffprobe -show_streams file:QmnI9nJPs_E.m4a
[ExtractAudio] Not converting audio QmnI9nJPs_E.m4a; file is already in target format m4a
[Metadata] Adding metadata to "QmnI9nJPs_E.m4a"
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -i file:QmnI9nJPs_E.m4a -map 0 -dn -ignore_unknown -vn -acodec copy -write_id3v1 1 -metadata "title=You Need Me Now?" -metadata "date=20240322" -metadata "description=Provided to YouTube by Columbia

You Need Me Now? ▒ girl in red ▒ Sabrina Carpenter

You Need Me Now?

 2024 Columbia Records, a Division of Sony Music Entertainment, under exclusive license from world in red

Released on: 2024-03-22

Associated  Performer: girl in red & Sabrina Carpenter
Vocal, Composer, Lyricist: Marie Ulven
Bass, Guitar, Programmer, Synthesizer, Composer, Lyricist, Producer, Recording  Engineer: Matias Tellez
Guitar, Programmer, Synthesizer, Vocal: Mari Persen
Drums: Erlend Hisdal
Vocal  Producer: Julian Bunetta
Assistant  Engineer: Andreas Aunedi H▒vset
Assistant  Engineer: Quentin Adrianasitera
Assistant  Engineer: James Pinfield-Wells
Mixing  Engineer: Mark \"Spike\" Stent
Assistant  Engineer: Matt Wolach
Assistant  Engineer: Kieran Beardmore
Mastering  Engineer: John Greenham
Assistant  Engineer: Tess Greenham

Auto-generated by YouTube." -metadata "synopsis=Provided to YouTube by Columbia

You Need Me Now? ▒ girl in red ▒ Sabrina Carpenter

You Need Me Now?

 2024 Columbia Records, a Division of Sony Music Entertainment, under exclusive license from world in red

Released on: 2024-03-22

Associated  Performer: girl in red & Sabrina Carpenter
Vocal, Composer, Lyricist: Marie Ulven
Bass, Guitar, Programmer, Synthesizer, Composer, Lyricist, Producer, Recording  Engineer: Matias Tellez
Guitar, Programmer, Synthesizer, Vocal: Mari Persen
Drums: Erlend Hisdal
Vocal  Producer: Julian Bunetta
Assistant  Engineer: Andreas Aunedi H▒vset
Assistant  Engineer: Quentin Adrianasitera
Assistant  Engineer: James Pinfield-Wells
Mixing  Engineer: Mark \"Spike\" Stent
Assistant  Engineer: Matt Wolach
Assistant  Engineer: Kieran Beardmore
Mastering  Engineer: John Greenham
Assistant  Engineer: Tess Greenham

Auto-generated by YouTube." -metadata "purl=https://www.youtube.com/watch?v=QmnI9nJPs_E" -metadata "comment=https://www.youtube.com/watch?v=QmnI9nJPs_E" -metadata "artist=girl in red, Sabrina Carpenter" -metadata "album=You Need Me Now?" -movflags +faststart -c:v mjpeg -vf "crop='if(gt(ih,iw),iw,ih)':'if(gt(iw,ih),ih,iw)'" file:QmnI9nJPs_E.temp.m4a
[ThumbnailsConvertor] Converting thumbnail "QmnI9nJPs_E.webp" to png
[debug] ffmpeg command line: ffmpeg -y -loglevel repeat+info -f image2 -pattern_type none -i file:QmnI9nJPs_E.webp -update 1 -movflags +faststart -c:v mjpeg -vf "crop='if(gt(ih,iw),iw,ih)':'if(gt(iw,ih),ih,iw)'" file:QmnI9nJPs_E.png
[EmbedThumbnail] mutagen: Adding thumbnail to "QmnI9nJPs_E.m4a"

We cannot pass \0 to ffmpeg (which we use for all metadata embedding). Afaik, ffmpeg does not properly support multi-value id3v2 fields. So comma is the most feasible compromise

There appears to be no way to pass \0 to anything, unfortunately. It would be a significant amount of work for me to try to do so through the python api or by building my own yt-dlp, so I cannot really go further than this. I was not aware of this limitation, so I apologize for not checking beforehand.

https://trac.ffmpeg.org/ticket/6949 looks to be the relevant FFmpeg ticket. It even has a patch attached - but it's sat unmerged for two years. A potential candidate for yt-dlp/FFMpeg-Builds if it still applies and behaves correctly?

If it still works, then I think its a candidate. Probably validates its own ticket on that repo

I suppose a quick test could be performed first with a sample including null characters to see what the FFmpeg binary outputs on the other end. However, I just came across https://github.com/yt-dlp/yt-dlp/pull/11817 which might be a better solution for more users.

Ah yes, that was an afterthought I edited in a bit too quickly. It should be perfectly fine to use it only for audio then.


BAW mesh loader the 2nd PR

While coding I figured out we don't need getNeededDeps if we have instantiateEmpty. Also we don't need two stacks (in loader) about which we were talking about. Now there's just vector with blobs' data, map<handle, object ptr> and two loops performing actual loading.
Will merge after CR.
Left todo:

There's some bug in loading/exporting skinned meshes. Working on it, but couldn't find anything wrong so far. It works (doesn't crash), but can't see anything or.. something weird happens. Please run the modified 7th example so you can see the effect.
Bit fields in SMaterial

hmm.. I think the reason why you don't see the skinned mesh is because finalize() (in the X loader) calculates the bounding boxes of the bones and the mesh.
But I am unsure of what else finalize() does, so we need to review it to see if it doesn't overwrite the bone hierarchies etc.

Thanks for the CR :)
Here's part of the docs. Again I'll have very little time for a few following days, but docs will be coming in small batches. There's a few params empty of which I wasn't sure about. I'll ask about them when I gather more unsureness.. :D

since you already have B, the blob type in the template parameter void* _blob could be B* _blob

But then I'd have to cast to it while calling in the switch what would be kinda problematic. It is doable of course, but worth it?

Can you merge your pull against my master , because as you start commenting, you will make conflicts

Can do.
Also about *Serializable base class: there's a problem with mesh/skinned-mesh inheritance from VariableSizeBlobSerializable (ISkinnedMesh inherits IMesh), same with mesh buffers.

But then I'd have to cast to it while calling in the switch what would be kinda problematic. It is doable of course, but worth it?

Ok, lets keep it the way it is.

Also about *Serializable base class: there's a problem with mesh/skinned-mesh inheritance from VariableSizeBlobSerializable (ISkinnedMesh inherits IMesh), same with mesh buffers.

Well since you need the object in order to serialize it, there is no need for the serialize method to be static.
Since there is no need for the serialize method to be static, then there is no need for static-polymorphism.
Since there is no need for static-polymorphism, the Serializable class doesn't need to be a template class.
Hence the Serializable class can be an Abstract Data Type with a single public method, a pure virtual function serializeToBlob.
(which yes, I know requires us to override the function in every class inheriting from Serializable).
But it could have a protected utlity template method which does exactly what the current serializeToBlob method does right now (have the utility method be a template, not the entire class).

While coding I figured out we don't need getNeededDeps if we have instantiateEmpty. Also we don't need two stacks (in loader) about which we were talking about.

Yes, and now every blob gets loaded once and an empty object is made for every blob in the file, only to delete the objects which do no get referenced by any other one.
A stack of dependencies allows us to read 10 actually needed blobs out of 1000.
Also now the code loads the blob from the file twice (once for instantiateEmptyWithoutDeps and secondly for finalize), I believe?

Ok, I didn't even consider posiblity of blob not referenced by any other. Why would there be such? Are you talking about using this as an archive file you mentioned some time?  I'll get it done later !

Also now the code loads the blob from the file twice (once for instantiateEmptyWithoutDeps and secondly for finalize), I believe?

Yes, unfortunately there's the cost of simplicity :/

There it is, but I can't go below two loads of blob unless we keep all the needed blobs in memory (that would also mean heap only I think) through the whole process of loading... which is not our goal either.

Hmm.. obviously reduction of disk IO > reducing memory fragmentation.
So the heap it is.
Certain things can always be loaded and finalized at once, like ICPUBuffers and textures, so heap not necessary.
Other things, yes, i guess the heap it is then.
Obviously lets keep the beautiful createOnStack function, but for heap allocation lets pass the stackPointer to be NULL.
One last thing before I approve the pull request, can we rename source/Irrlicht/blobsLoading.cpp to something more conformant to our standards (camelcase, etc.)?

ok... I shall push my latest stuff and then we merge.


⚠ ClamAV has degraded performance

In 297f409, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 66 ms

Resolved: ClamAV performance has improved in eb8f2fc.


Warning : Calling 'getNode()' on the ref an Animated Component is no longer necessary.

Is this a bug report, a feature request, or a question?
Question

Have you followed the required steps before opening a bug report?
(Check the step you've followed - put an x character between the square brackets ([]).)

[x] I have read the guidelines regarding bug report.
[x] I have reviewed the documentation in its entirety, including the dedicated documentations :books:.
[x] I have searched for existing issues and made sure that the problem hasn't already been reported.
[x] I am using the latest plugin version.
[x] I am following the issue template closely in order to produce a useful bug report.

Have you made sure that it wasn't a React Native bug?
It is a warning regarding deprecation of the method getNode().

Is the bug specific to iOS or Android? Or can it be reproduced on both platforms?
(Write your answer here and specify the iOS/Android versions on which you've been able to reproduce the issue.)
Is the bug reproductible in a production environment (not a debug one)?
Yes.

Environment

React native: 0.62.0
react-native-snap-carousel: 3.8.4
Target Platform:
Android (9.0)
iOS (13.3)
Expected Behavior

No warning should be raised. Upgrade is needed.
Actual Behavior

Raise of a warning.

Reproducible Demo
(Paste the link to a Snack example in which the issue can be reproduced. Please follow the guidelines for providing a Minimal, Complete, and Verifiable example.)

Steps to Reproduce

having same issue react-native v 0.61 occurs implementing nested navigation.

Same problem. Came here from https://stackoverflow.com/questions/60910385/upgraded-to-react-native-0-62-0-getting-warning-sign-calling-getnode-on-t

@lumberman Give #673 a try :)

same problem but im using the 'react-native-image-slider-box' which is using the carousel.

i fixed ,in this way,
go to nodeModule -> react-native-snap-carousel -> src -> Carousel.js
modify
const AnimatedFlatList = FlatList ? Animated.createAnimatedComponent(FlatList)    : null;
const AnimatedScrollView = Animated.Animated.createAnimatedComponent(ScrollView);
to
const AnimatedFlatList = FlatList ? Animated.FlatList    : null;
const AnimatedScrollView = Animated.ScrollView;
after find function _getWrappedRef
modify to like this
_getWrappedRef () {
// https://github.com/facebook/react-native/issues/10635
// https://stackoverflow.com/a/48786374/8412141
return this._carouselRef
}
then save it .
I Hope This can Help you

i fixed ,in this way,
go to nodeModule -> react-native-snap-carousel -> src -> Carousel.js
modify
const AnimatedFlatList = FlatList ? Animated.createAnimatedComponent(FlatList) : null;
const AnimatedScrollView = Animated.Animated.createAnimatedComponent(ScrollView);
to
const AnimatedFlatList = FlatList ? Animated.FlatList : null;
const AnimatedScrollView = Animated.ScrollView;
after find function _getWrappedRef
modify like this
_getWrappedRef () {
// facebook/react-native#10635
// https://stackoverflow.com/a/48786374/8412141
return this._carouselRef
}
then save it .
I Hope This can Help you

Thankyou so much, It helped.

Hi, any updates on when this will be release ?

I am looking for the release too :)

waiting for the release

waiting for release too

waiting for release too ;)

+1 waiting for the release

waiting for release too!

waiting for release too!

¿Cuando se arreglara ese problema en el repositorio?

I am looking for the release too

+1

+1

Would love to see this 'acclaimed' release

Waiting....

Yes waiting...

Waiting

Yes waiting...

Waiting for this release too

waiting

waiting too..

waiting

waiting ..

waiting

I don't know how all you guys commenting "waiting" here think will solve the problem. maybe stop polluting the thread with useless comments, and a 👍 should be enough.
I think it's clear enough until now that a lot of people are 'waiting' for this fix.

Why the PR is not merged yet?

Probably because it is really complicated to detect the RN package Version the right way.

i fixed ,in this way,
go to nodeModule -> react-native-snap-carousel -> src -> Carousel.js
modify
const AnimatedFlatList = FlatList ? Animated.createAnimatedComponent(FlatList) : null;
const AnimatedScrollView = Animated.Animated.createAnimatedComponent(ScrollView);
to
const AnimatedFlatList = FlatList ? Animated.FlatList : null;
const AnimatedScrollView = Animated.ScrollView;
after find function _getWrappedRef
modify like this
_getWrappedRef () {
// facebook/react-native#10635
// https://stackoverflow.com/a/48786374/8412141
return this._carouselRef
}
then save it .
I Hope This can Help you

Thanks, This is also working with react-native-image-slider-box.... Thanks for help

I am looking for the release too

Chill out and wait a little guys. It’s been 10 days not 10 months since the PR was filed and theres an ongoing discussion about the implementation. Either contribute or be patient. Open source doesn’t work by stressing contributors out but by contributing and being grateful for the contributions of others.

Ok, looks like this is going to be fixed pretty soon!

Fixed in versions 3.9.1 and 4.0.0-beta.4 with backward-compatible code.

Hi! I reached out this thread when I faced this 'getNode()' warning and I was using v3.9.0 and when I upgraded to v3.9.1 it still shows the 'getNode()' warning.
    _getWrappedRef () {
        if (this._carouselRef && (
            (this._needsScrollView() && this._carouselRef.scrollTo) ||
            (!this._needsScrollView() && this._carouselRef.scrollToOffset)
        )) {
            return this._carouselRef;
        }
        // https://github.com/facebook/react-native/issues/10635
        // https://stackoverflow.com/a/48786374/8412141
        return this._carouselRef && this._carouselRef.getNode && this._carouselRef.getNode();
    }

I am running on react-native v 0.62.2

In updated version I changed this
const AnimatedFlatList = FlatList ? Animated.createAnimatedComponent(FlatList) : null;
const AnimatedScrollView = Animated.Animated.createAnimatedComponent(ScrollView);

to this:
const AnimatedFlatList = FlatList ? Animated.FlatList : null;
const AnimatedScrollView = Animated.ScrollView;

as mentioned by @binar1 above
I think any how this change did not get pushed into the update.

Current version 3.9.1 same problem

In the 3.9.1 release, the error did not disappear, so I used the @HarshitMadhav advice and with the help of patch-package fixed the problem so as not to wait for a new release. Thanks @HarshitMadhav !

I can confirm that this warning has not been resolved

Been using @dilinade's forked branch for this fix: https://github.com/dilinade/react-native-snap-carousel
Don't see any reason these changes shouldn't be merged.

Tested this on react-native 0.63.4 and react-native-snap-carousel 3.9.1 and it is still happening

still happening. 0.63.3 and react-native-snap-carousel 3.9.1

Chill out and wait a little guys. It’s been 10 days not 10 months since the PR was filed and theres an ongoing discussion about the implementation. Either contribute or be patient. Open source doesn’t work by stressing contributors out but by contributing and being grateful for the contributions of others.

Well now its been more than 10 months and problem still exists...

this solved!!

i fixed ,in this way, go to nodeModule -> react-native-snap-carousel -> src -> Carousel.js modify
const AnimatedFlatList = FlatList ? Animated.createAnimatedComponent(FlatList) : null; const AnimatedScrollView = Animated.Animated.createAnimatedComponent(ScrollView);
to const AnimatedFlatList = FlatList ? Animated.FlatList : null; const AnimatedScrollView = Animated.ScrollView;
after find function _getWrappedRef modify like this _getWrappedRef () { // facebook/react-native#10635 // https://stackoverflow.com/a/48786374/8412141 return this._carouselRef }
then save it . I Hope This can Help you

this will help!!!


HDDS-5209. Datanode hasEnoughSpace check should apply on volume instead of global DN

What changes were proposed in this pull request?
When use placement policy to choose datanodes, we should check whether a datanode has a volume that
has enough space to hold the container, not check the space from all volumes together, because a container
could only be on a single volume not spread across volumes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5209
How was this patch tested?
extended existing ut.

Hi @ChenSammi please help review this one, I'll check the CI failures, not related at first glance, thanks~

Hi @guihecheng ,   we have leverage the DatanodeInfo value. It seems there is no need to add new API in NodeManager.  You can refer to these piece of codes,
final DatanodeInfo datanodeInfo = nodeStateManager
.getNode(datanodeDetails);
final List storageReportProtos = datanodeInfo
.getStorageReports();
for (StorageReportProto reportProto : storageReportProtos) {
capacity += reportProto.getCapacity();
used += reportProto.getScmUsed();
remaining += reportProto.getRemaining();
}

@ChenSammi ah, then I shall put the logic directly into hasEnoughSpace and avoid adding a new API, thanks~

cc @bshashikant , please help review this since it can be related to datanode volume handling issues.

+1.  Thanks @guihecheng  for the contribution.