Logger stops logging after some time

I have a windows service that logs every minute, and i found that after 30min to 60min it just stops logging even tough the service keeps running perfectly

Can you provide some details? I.e. version, configuration, etc.

I am using log4rs = "1.3.0" and this is the logger configuration:
let stdout = ConsoleAppender::builder()
    .encoder(Box::new(PatternEncoder::new("{d(%Y-%m-%d %H:%M:%S)} | {h({({l}):5.5})} | {f}:{L} — {m}{n}")))
    .build();

let trigger = Box::new(SizeTrigger::new(2 * 1024 * 1024));

let roller = Box::new(
    FixedWindowRoller::builder()
        .base(1)
        .build(".\\Logs\\log_{}.csv", 5)
        .unwrap(),
);

let compound_policy = Box::new(CompoundPolicy::new(trigger, roller));
let file = RollingFileAppender::builder()
    .encoder(Box::new(PatternEncoder::new("{d(%Y-%m-%d %H:%M:%S)}\t{P}:{I}\t{l}\t{f}(({L}))\t{m}{n}")))
    .build("\\Logs\\log.csv", compound_policy)
    .unwrap();

let config = Config::builder()
    .appender(Appender::builder().build("stdout", Box::new(stdout)))
    .appender(
        Appender::builder()
            .filter(Box::new(ThresholdFilter::new(log::LevelFilter::Info)))
            .build("file", Box::new(file)))
    .logger(Logger::builder().build("app::backend::db", log::LevelFilter::Info))
    .build(Root::builder().appender("stdout").appender("file").build(log::LevelFilter::Debug))
    .unwrap();

log4rs::init_config(config).unwrap();

What OS (with Version) are you running? I ran the following and it continues to log after 1 minute. Have you tried adding println calls in concert with the logger or a debugger to make sure that your code is still executing?
use log::info;
use log4rs::{
    append::console::ConsoleAppender,
    append::rolling_file::policy::compound::{
        roll::fixed_window::FixedWindowRoller, trigger::size::SizeTrigger, CompoundPolicy,
    },
    append::rolling_file::RollingFileAppender,
    config::{Appender, Logger, Root},
    encode::pattern::PatternEncoder,
    filter::threshold::ThresholdFilter,
    Config,
};
use std::thread;
use std::time::Duration;

fn main() {
    let stdout = ConsoleAppender::builder()
        .encoder(Box::new(PatternEncoder::new(
            "{d(%Y-%m-%d %H:%M:%S)} | {h({({l}):5.5})} | {f}:{L} — {m}{n}",
        )))
        .build();

    let trigger = Box::new(SizeTrigger::new(2 * 1024 * 1024));

    let roller = Box::new(
        FixedWindowRoller::builder()
            .base(1)
            .build(".\\Logs\\log_{}.csv", 5)
            .unwrap(),
    );

    let compound_policy = Box::new(CompoundPolicy::new(trigger, roller));
    let file = RollingFileAppender::builder()
        .encoder(Box::new(PatternEncoder::new(
            "{d(%Y-%m-%d %H:%M:%S)}\t{P}:{I}\t{l}\t{f}(({L}))\t{m}{n}",
        )))
        .build("\\Logs\\log.csv", compound_policy)
        .unwrap();

    let config = Config::builder()
        .appender(Appender::builder().build("stdout", Box::new(stdout)))
        .appender(
            Appender::builder()
                .filter(Box::new(ThresholdFilter::new(log::LevelFilter::Info)))
                .build("file", Box::new(file)),
        )
        .logger(Logger::builder().build("app::backend::db", log::LevelFilter::Info))
        .build(
            Root::builder()
                .appender("stdout")
                .appender("file")
                .build(log::LevelFilter::Debug),
        )
        .unwrap();

    log4rs::init_config(config).unwrap();

    let mut x = 0;
    loop {
        info!("example!! {x}");
        x += 1;
        thread::sleep(Duration::from_millis(1000));
    }
}

Both stdout and the file still show updated logs after 4 minutes

I ran it in a win 11 environment, i tested in 2 vm machines, and one non vm machine(laptop also win 11).
Im sure the service is still running because it is in a never ending loop that executes some code and writes some files so i constantly get feedback.

Hmm so 75 minutes of logging once per second, it's still running true on Rocky Linux 9. I don't have a Windows 11 system, but I can test it on Windows 10 some time next week. Can you test your app on something none Windows based?

It probably just happens in windows, so I believe there's no need for now to test in other OS, also because we can't have a windows service running in any other OS, so we cant recreate the exact same conditions.
And I believe the trick here is it to be a service in windows not a common program and it should be in build mode.
I had also the same problem with c# (because I'm migrating from c# to rust), and in these version the logger was made by me it just opened the log to write, wrote the new log and flushed it, and after a while it also had the same problem. And I ended using an existing lib called NLog.
Since I need this quickly fixed I am now using other rust lib and it appears to be all good. It's called flexi_logger.

Appreciate the notification then. I'll leave this open as a reminder to try testing as a windows service.


missing CloseAndFlushAsync

net48 doesnt have CloseAndFlushAsync

@nblumhardt  how does this build for you ?

Hmm, not sure how I messed that one up so badly - think I was working on Ubuntu and skipped the 4.8 build :-)
Perhaps since CloseAndFlushAsync() is considerably better than the non-async version (i.e. won't hang in AWS Lambda), we drop the 4.8 target here and just target .NET 5 or 6?

drop the 4.8 target here and just target .NET 5 or 6?

happy with that. i assume u dont need a PR?

Thanks Simon! :+1:


Minimum supported Rust version?

What is the current MSRV for Cookie, and the threshold for upping it? As the revamped time crate is nearing release, it looks doable to update the dependency here. However, the MSRV for that is 1.40. I see that cookie still uses Rust 2015, and I'd be willing to convert that over as well.
Both of these would changes would necessarily bump the MSRV (and necessitate a 0.13 release), though #[non_exhaustive] would be useful elsewhere as well.
Basically, I'd like to make changes similar to those I made for Rocket (which were well-received!). I'm just curious if bumping the MSRV is allowed, and by how much.

Ping @SergioBenitez. v0.2 will be released tomorrow.

Ping @SergioBenitez. I have updated cookie to 2018 edition and to time v0.2 on a local branch. Would a PR be accepted? Cookie is one of the largest crates that has a runtime dependency on time, and this upgrade would also have slight memory improvements. This upgrade would also allow other crates, such as reqwest, to upgrade.


issues with s2i scala in Openshift 3

I am trying to run s2i build to have image creation for scala. Every time I am getting errors as -
An error occurred: unable to get metadata
Suggested solution: check image name
Details: Error: No such image:
Pls advise

can you run the s2i build with --loglevel=5 and provide the full logs?

the command line you're invoking would be helpful also so we can see the exact image you're using as the builder image.

closing due to lack of details, please reopen if you're able to provide the requested data to investigate this.


Small changes and fixes to test workflow

This PR changes the Github workflow used to run tests; small commits (such as those as simple README changes) are now ignored by the workflow, and the workflow now runs tests for changes inside branches starting with develop/.
Since specific Python versions will be used for development (in the future), this PR makes specfying what Python version the workflow needs to setup more dynamic — requiring a secret with the Python version to be setup before merging this. This specific change can be discussed at any point.
Specific changes made have been documented under the commit message.

For the record, this specific change to the workflow requires that the branch be renamed in order for the workflow to run,


Fail to load "Explore Chart" views using slice ids  in superset 0.38.0.rc2

I am testing the new version superset 0.38.0.rc2 and I have issues loading charts in the "Explore Chart" view.
When I "explore" a table, it works well, and I can see in the URL the all options are passed (form_data, query_fields .... )
It also works for Big Number, Big Numbers with trendlines
When I try to "explore" a line chart, a map ... I get an empty view. I notice it fails when the chart is specified by its slice_id in the url (e.g superset/explore/?form_data=%7B"slice_id"%3A1676%7D).

In the console log I have the following errors:

Same problem here, getting TypeError: Cannot read property 'id' of undefined when loading a chart in the Chart editor, either from the "Explore chart" menu item on a dashboard, or simply from the "Charts" list. This happens with most chart types, except tables seem to be OK.

This may be a backwards compatibility issue. If I create a brand new chart, then I don't seem to have this issue, it seems to happen only for charts that were created before 0.38rc2.

Might have something to do with default control state. Let me look into this.

I was finally able to reproduce 👍  Investigating

I have now identified the necessary fix, will start working on rc3 shortly.

@lilila @bryanck feel free to try out the pre-release of rc3: https://github.com/apache/incubator-superset/commits/0.38

@villebro it works well, you are the best!

Appears to be fixed for me as well!

Thank you Ville! @villebro closing this issue!
@mistercrunch FYI

Awesome, thanks for confirming @lilila and @bryanck !


Missing GM terms

GM terms may not be part of the saved CMIP output. Maybe there is a way to reconstruct them? Otherwise, is the only solution to ask for original files from modelling groups?

Which CMIP model umo/vmo outputs include GM terms?
CMIP6

Model
includes GM?

ACCESS-ESM1-5
🔴

ACCESS-CM2
🔴

CMIP5

Model
includes GM?

ACCESS1-3
🔴

I think I should be able to build it from so and thetao. I could use these to approximate the neutral density slopes (using GibbsSeaWater.jl?) and then apply the tensors described in the MITgcm docs on GM/Redi?


All routes not found on MacOS

Hi, I'm make an app work fine on Windows. But on MacBook display "Not found (Not found)" any route.
Here is my code:
`
static HttpRequestService request;
static void Main(string[] args)
{
Server s = new Server("<IP_ADDRESS>", 19000, false, DefaultRoute);
        s.Routes.Static.Add(WatsonWebserver.HttpMethod.GET, "/app.js", async (ctx) => {
            ctx.Response.ContentType = "application/javascript; charset=utf-8";
            await ctx.Response.Send(Properties.Resources.app);
        });
        s.Routes.Static.Add(WatsonWebserver.HttpMethod.GET, "/app.css", async (ctx) => {
            ctx.Response.ContentType = "text/css; charset=utf-8";
            await ctx.Response.Send(Properties.Resources.app1);
        });
        s.Routes.Static.Add(WatsonWebserver.HttpMethod.GET, "/logo.png", async (ctx) => {
            ctx.Response.ContentType = "image/png";
            await ctx.Response.Send(Properties.Resources.logo);
        });
        s.Routes.Static.Add(WatsonWebserver.HttpMethod.GET, "/login", AuthorizeAsync);
        s.Start();

        Console.WriteLine("Press ENTER to exit");
        Console.ReadLine();
    }
    private static async Task AuthorizeAsync(HttpContext ctx)
    {
        var login = new Login(request);
        try
        {
            var l = await login.GetLogin();
            ctx.Response.StatusCode = 200;
            ctx.Response.ContentType = "application/json; charset=utf-8";
            await ctx.Response.Send(l.ToJson());
            return;
        }
        catch (Exception e)
        {
            Console.WriteLine(e.Message);
        }
    }
    static async Task DefaultRoute(HttpContext ctx)
    {
        ctx.Response.StatusCode = 200;
        ctx.Response.ContentType = "text/html; charset=utf-8";
        await ctx.Response.Send(Properties.Resources.index);
        return;
    }`

Thanks!
I'm using .Net 5.0

Thanks @vergoicincom, looking into this.

Hi @vergoicincom I just tested on Big Sur 11.1 using the Test.Default project and it worked for me:

Here is the code change I made:
            _Server.Routes.Static.Add(HttpMethod.GET, "/login", async (ctx) =>
            {
                ctx.Response.StatusCode = 200;
                ctx.Response.ContentType = "text/plain";
                await ctx.Response.Send("Login static route");
                return;
            });

Could you test in the Test.Default project and see if it works?
Also can you try changing your AuthorizeAsync method to internal and then public to see if this makes a difference?

Hmmm, I just changed one of my routes to private and it didn't make a difference on 11.1...  Would you be able to reproduce in the Test.Default project?

@jchristn Thanks you for supported!
My problem solved when I changed <IP_ADDRESS> to localhost. It is the difference on my code and Test.Default
Thanks you very much!

Good to know!  Operating systems are sensitive to cases where the listener prefix (ie <IP_ADDRESS>) is compared to the value in the incoming request's HOST header.


Add Fields abstraction (#3955)

Experimental draft to get feedback before polishing
Which issue does this PR close?

Closes #.
Rationale for this change

This adds a cheaply cloneable Fields abstraction, that internally contains FieldRef within a reference counted slice.
This achieves a couple of things:

The use of FieldRef allows projecting / reconstructing schema without needing to copy Field
The use of Arc<[FieldRef]> allows cheap cloning of DataType, construction of DataType::Struct, etc...
Allows cheap pointer comparisons between Schema and DataType

What changes are included in this PR?

Are there any user-facing changes?
Yes, this makes a fundamental change to the schema representation

FYI @alamb @crepererum @viirya I would appreciate your thoughts on this

Notified the mailing list about this - https://lists.apache.org/thread/pmxq5j864qlkp36lvxg8kvk0kct56r8m

There don't appear to be any objections to this, and there is plenty of time until the next release, and so I am going to get this in before it develops merge conflicts. We can continue to iterate from there


[cgal] Add boost-multi-array to deps

Describe the pull request

What does your PR fix?
Fixes CGAL/cgal#6598

Which triplets are supported/not supported?

Yes

@lrineau Could you please address the review suggestion of Jack? Thanks!

Thanks for the PR!


Clarify guidance on operations having data-dependent output shapes

This PR supersedes gh-168 by @steff456.
In summary, this PR

clarifies guidance on functions/operations having data-dependent output shapes.
grants permission to array libraries which build array computation graphs to omit such operations.

Notes

I messed up the Git history of gh-168 when attempting to make updates. 😓

Other operations can also wind up with unknown shapes like nonzero, unique, etc.. Not sure if we want to include these

@jakirkham This PR includes guidance for nonzero and unique.

Sorry I must have missed that

@jakirkham No worries! 😅

@leofang Updated copy based on your suggestions.


Prototype support for bindValue/bindParam on PDOStatement

I think this adds the right pieces.
refs https://github.com/staabm/phpstan-dba/issues/199

This looks great.
we need more testcoverage, especially in

https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/data/unresolvable-pdo-statement.php
https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/data/pdo-stmt-execute-error.php

for the error cases.
expected error messages need to be put into

https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/PdoStatementExecuteMethodRuleTest.php
https://github.com/xPaw/phpstan-dba/blob/pdo-bind-param/tests/default/UnresolvablePdoStatementRuleTest.php

While adding tests, it seems like it's finding bind calls from previous pdo statements, so the code isn't entirely correct. It needs to stop once it hits prepare or something.

For inspiration, a few real world examples can be taken from
https://github.com/shopware/shopware/search?q=bindParam

I think I fixed it. I manually constructed ConstantArrayType out of the collected bind calls.


Bug: check if mounted before calling setState()

Please consider checking if mounted before calling setState() in tree_view.dart
https://github.com/sooxie/list_treeview/blob/c10335ca5645272618a9d4506a1ced9d47778f96/lib/tree/tree_view.dart#L78
From:
 void updateView() {
    setState(() => {});
  }

to
 void updateView() {
    if (mounted) {
      setState(() => {});
    }
  }

I/flutter ( 2032): The TreeViewController sending notification was:
I/flutter ( 2032):   Instance of 'TreeViewController'
I/flutter ( 2032): ════════════════════════════════════════════════════════════════════════════════════════════════════
I/flutter ( 2032): ══╡ EXCEPTION CAUGHT BY FOUNDATION LIBRARY ╞════════════════════════════════════════════════════════
I/flutter ( 2032): The following assertion was thrown while dispatching notifications for TreeViewController:
I/flutter ( 2032): setState() called after dispose(): _ListTreeViewState#b42b1(lifecycle state: defunct, not mounted)
I/flutter ( 2032): This error happens if you call setState() on a State object for a widget that no longer appears in
I/flutter ( 2032): the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error
I/flutter ( 2032): can occur when code calls setState() from a timer or an animation callback.
I/flutter ( 2032): The preferred solution is to cancel the timer or stop listening to the animation in the dispose()
I/flutter ( 2032): callback. Another solution is to check the "mounted" property of this object before calling
I/flutter ( 2032): setState() to ensure the object is still in the tree.
I/flutter ( 2032): This error might indicate a memory leak if setState() is being called because another object is
I/flutter ( 2032): retaining a reference to this State object after it has been removed from the tree. To avoid memory
I/flutter ( 2032): leaks, consider breaking the reference to this object during dispose().

The bug has been fixed


chore(home-manager): deprecate gtk module

https://github.com/catppuccin/gtk/issues/262

#211 should be merged, updating the gtk port repo to its final revision

Is there an alternative to this module? my gnome (and apps) were so pretty with it.

Are the cursor and icon configs deprecated too? These themes are not archived. When we eventually remove the options, we can just put a notice about the removal of the gtk theme in the description of gtk.catppuccin

Are the cursor and icon configs deprecated too? These themes are not archived. When we eventually remove the options, we can just put a notice about the removal of the gtk theme in the description of gtk.catppuccin

@getchoo I was wondering about this as well.

Is there an alternative to this module? my gnome (and apps) were so pretty with it.

In terms of themes, there is Fausto-Korpsvart/Catppuccin-GTK-Theme which has been recently updated and there is/was talk of it merged into the Org, but it requires the murrine-engine which I don't think has been packaged yet.

Are the cursor and icon configs deprecated too? These themes are not archived.

no, these ports are not; however i would consider these options deprecated for the time being as i plan on splitting them into their own options (like in https://github.com/catppuccin/nix/pull/195). this should have been better communicated, that's my bad

Is there an alternative to this module? my gnome (and apps) were so pretty with it.

i think this would be better left to a conversation in the gtk ports repository
but personally, i would recommend adw-gtk3 and gradience's catppuccin theme. it's worked well when i used it - though it's been a while :p

but personally, i would recommend adw-gtk3 and gradience's catppuccin theme. it's worked well when i used it - though it's been a while :p

Actually just did this a few days ago, it's a bit janky and there's probably a better way to do it, but it works. Honestly, I think it looks better than the GTK theme.

btw I wrote a module for https://github.com/Fausto-Korpsvart/Catppuccin-GTK-Theme at https://github.com/Weathercold/nixfiles/blob/master/home/modules/themes/catppuccin/gtk.nix. You can integrate it into your config with some modifications


SQL Query example

Added SQL Query example to delete events older than 30 days.

Applied, thanks for the contribution!


Add Git Foundations Course by GitKraken - Revised

Adding Git course from GitKraken
What does this PR do?
Add resource(s)
For resources
Description
This is a free Git foundations course from Gitkraken, a proprietary project management Git tool for developers.
Why is this valuable (or not)?
It's another free learning Git course for beginners.
How do we know it's really free?
You will need to create an account using your e-mail but after signing up you are taken directly to the course.
For book lists, is it a book? For course lists, is it a course? etc.
This is a course and there is only one course at this time. Others may be created soon.
Checklist:

[X] Read our contributing guidelines.
[X] Search for duplicates.
[X] Include author(s) and platform where appropriate.
[X] Put lists in alphabetical order, correct spacing.
[X] Add needed indications (PDF, access notes, under construction).
[X] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

Changed and revised from #8591 and #8703


fix: make auth required optional for gen:gql

Overview
Fixs reearth/reearth#248
What I've done
What I haven't done
How I tested
Which point do I want you to review particularly
Memo

Sorry, I fixed it. I had to do some refactoring to implement it in a straightforward manner. But thank you for creating a PR.
https://github.com/reearth/reearth-backend/commit/58a6d13ecaead6818561cbc20c2693d92eacb6d5


Test Iceberg 1.2.0 RC1

Seeing:
Data read has a different checksum than expected. Was 0xd41d8cd98f00b204e9800998ecf8427e, but expected 0xb58d47ea1ab17fa7f2983fe35b588e18. This commonly means that the data was corrupted between the client and service. Note: Despite this error, the upload still completed and was persisted in S3.

I checked the file locally and the metadata JSON looks good.


Duplicated Job Templates on sQuest when starting celery after two sync

Steps to reproduce:

Launch development server without celery worker
Add a tower
Sync job templates
Sync job templates again
Start the celery worker: celery -A service_catalog worker -l info

DB Screenshot:

Currently on commit : 46302ff (upstream/resoure_tracker)

Fixed and merged in dev


Cannot read property 'includes' of undefined

I have been unable to use the "Extract Component" functionality, because each time I tried it I got this error. Even after disabling all other extensions, I still see this error. Any ideas why this might be?

@calebeby  can you provide the exact JSX string you wanted to extract? thanks

I think it gives me this error no matter what I try to extract, one thing I tried was
Hi
.
By the way, I am using VS Code Insiders, which might be the problem?

@calebeby i was able to reproduce the issue. WIll handle ASAP

I have the same issue as well. It first happened to me when I tried to apply "Convert Stateful to Stateless Component", but it seems to he happening for any refactoring I'm trying to apply.
Sample code:
class Test extends PureComponent {
    render() {
        return <TextInput />
    }
}

The log I captured in "Output" tab:
[2019-03-13 09:06:26.638] [exthost] [error] [wix.glean] provider FAILED
[2019-03-13 09:06:26.639] [exthost] [error] SyntaxError: Unexpected token, expected ";" (2:13)
  1 | /* @babel/template */;
> 2 |     render() {
    |             ^
  3 |         return <TextInput />
  4 |     }
  5 | }
    at _class.raise (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:3939:15)
    at _class.unexpected (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:5248:16)
    at _class.semicolon (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:5232:40)
    at _class.parseExpressionStatement (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:7665:10)
    at _class.parseExpressionStatement (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:9980:69)
    at _class.parseStatementContent (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:7264:19)
    at _class.parseStatementContent (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:9916:58)
    at _class.parseStatement (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:7145:17)
    at _class.parseBlockOrModuleBlockBody (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:7696:23)
    at _class.parseBlockBody (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:7683:10)
    at _class.parseTopLevel (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:7110:10)
    at _class.parse (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:8510:17)
    at parse (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/parser/lib/index.js:10465:38)
    at parseWithCodeFrame (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/template/lib/parse.js:145:32)
    at parseAndBuildMetadata (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/template/lib/parse.js:43:15)
    at arg (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/template/lib/string.js:21:50)
    at Function.ast (~/.vscode/extensions/wix.glean-4.9.0/node_modules/@babel/template/lib/builder.js:47:155)
    at Object.exports.templateToAst.code [as templateToAst] (~/.vscode/extensions/wix.glean-4.9.0/out/parsing.js:22:52)
    at Object.isStatelessComp (~/.vscode/extensions/wix.glean-4.9.0/out/modules/statless-to-stateful.js:20:27)
    at CompleteActionProvider.provideCodeActions (~/.vscode/extensions/wix.glean-4.9.0/out/extension.js:30:36)
    at define.provideCodeActions.a.asPromise (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:564:641)
    at t.asPromise.Promise (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:58)
    at new Promise (<anonymous>)
    at Object.t.asPromise (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:48:32)
    at I.provideCodeActions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:564:612)
    at define.$provideCodeActions._withAdapter.e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:580:417)
    at $._withAdapter (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:575:502)
    at $provideCodeActions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:580:395)
    at h._doInvokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:593:118)
    at h._invokeHandler (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:592:777)
    at h._receiveRequest (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:591:383)
    at h._receiveOneMessage (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:590:279)
    at define.constructor._protocol.onMessage.e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:588:565)
    at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:43:254)
    at e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:39:64)
    at u.fire (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:43:254)
    at s (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:168:754)
    at Socket.define.constructor._socketDataListener.e (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:168:960)
    at Socket.emit (events.js:182:13)
    at addChunk (_stream_readable.js:279:12)
    at readableAddChunk (_stream_readable.js:264:11)
    at Socket.Readable.push (_stream_readable.js:219:10)
    at Pipe.onread (net.js:636:20)

Hey @maxkomarychev! Can you please try and follow the instructions in the error SyntaxError: Unexpected token, expected ";" (2:13) and add ; at the end of your JSX and try to run the refactoring again?

@borislit

Can you please try and follow the instructions in the error SyntaxError: Unexpected token, expected ";" (2:13) and add ; at the end of your JSX and try to run the refactoring again?

I'm not sure I really follow here but I tried semicolons wherever it would make sense (although style guide in project I'm working on forbids semicolons altogether) and it didn't help.
The piece of code in logs is not my original code, it comes from babel.


NoMethodError in Devise::SessionsController#create after upgrade to 4.9 from 4.8.1

Environment

Ruby 3.1.2p20
Rails <IP_ADDRESS>
Devise 4.9

Current behavior
When trying to login with a current user or create a new user:
undefined method empty?' for #<User id: 9, email: "xxxx", created_at: "2023-02-15 21:53:06.157323000 +0000", updated_at: "2023-02-15 21:53:06.157323000 +0000", notice_seen: nil, provider: nil, uid: nil, name: "xxxx", image: nil>
Extracted source (around line #458):
      else
        match = matched_attribute_method(method.to_s)
        match ? attribute_missing(match, *args, &block) : super
      end
    end
    ruby2_keywords(:method_missing)

activemodel (<IP_ADDRESS>) lib/active_model/attribute_methods.rb:458:in method_missing'
...
Expected behavior
Did not have this issue before in version 4.8.1 and if I rollback to earlier version it works again.

Hm interesting, I don't remember hitting anything like these in my tests but I'll try to repro with a similar setup.
Any chance you can share more of the stack trace? Since that's inside Rails Active Model, it'd be nice to see where Devise is calling it for example.
Also if you have any way to repro this in a sample app, that'd be great too. Thanks.

Full stack trace:
activemodel (<IP_ADDRESS>) lib/active_model/attribute_methods.rb:458:in `method_missing'
rack (2.2.4) lib/rack/etag.rb:71:in `block in digest_body'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/response.rb:146:in `each'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/response.rb:146:in `each_chunk'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/response.rb:128:in `each'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/response.rb:76:in `each'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/response.rb:481:in `each'
rack (2.2.4) lib/rack/body_proxy.rb:41:in `method_missing'
rack (2.2.4) lib/rack/etag.rb:69:in `digest_body'
rack (2.2.4) lib/rack/etag.rb:33:in `call'
rack (2.2.4) lib/rack/conditional_get.rb:40:in `call'
rack (2.2.4) lib/rack/head.rb:12:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/permissions_policy.rb:38:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/http/content_security_policy.rb:36:in `call'
rack (2.2.4) lib/rack/session/abstract/id.rb:266:in `context'
rack (2.2.4) lib/rack/session/abstract/id.rb:260:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/cookies.rb:697:in `call'
activerecord (<IP_ADDRESS>) lib/active_record/migration.rb:603:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
activesupport (<IP_ADDRESS>) lib/active_support/callbacks.rb:99:in `run_callbacks'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/actionable_exceptions.rb:17:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/debug_exceptions.rb:28:in `call'
web-console (4.2.0) lib/web_console/middleware.rb:132:in `call_app'
web-console (4.2.0) lib/web_console/middleware.rb:28:in `block in call'
web-console (4.2.0) lib/web_console/middleware.rb:17:in `catch'
web-console (4.2.0) lib/web_console/middleware.rb:17:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/show_exceptions.rb:26:in `call'
railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:40:in `call_app'
railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:25:in `block in call'
activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:114:in `block in tagged'
activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:38:in `tagged'
activesupport (<IP_ADDRESS>) lib/active_support/tagged_logging.rb:114:in `tagged'
railties (<IP_ADDRESS>) lib/rails/rack/logger.rb:25:in `call'
sprockets-rails (3.4.2) lib/sprockets/rails/quiet_assets.rb:13:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/remote_ip.rb:93:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/request_id.rb:26:in `call'
rack (2.2.4) lib/rack/method_override.rb:24:in `call'
rack (2.2.4) lib/rack/runtime.rb:22:in `call'
activesupport (<IP_ADDRESS>) lib/active_support/cache/strategy/local_cache_middleware.rb:29:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/server_timing.rb:20:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/executor.rb:14:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/static.rb:23:in `call'
rack (2.2.4) lib/rack/sendfile.rb:110:in `call'
actionpack (<IP_ADDRESS>) lib/action_dispatch/middleware/host_authorization.rb:137:in `call'
railties (<IP_ADDRESS>) lib/rails/engine.rb:530:in `call'
puma (5.6.5) lib/puma/configuration.rb:252:in `call'
puma (5.6.5) lib/puma/request.rb:77:in `block in handle_request'
puma (5.6.5) lib/puma/thread_pool.rb:340:in `with_force_shutdown'
puma (5.6.5) lib/puma/request.rb:76:in `handle_request'
puma (5.6.5) lib/puma/server.rb:443:in `process_client'
puma (5.6.5) lib/puma/thread_pool.rb:147:in `block in spawn_thread'
Started GET "/users/sign_in" for <IP_ADDRESS> at 2023-02-15 14:42:07 -0700
Processing by Devise::SessionsController#new as HTML
  Rendering layout layouts/application.html.erb
  Rendering devise/sessions/new.html.erb within layouts/application
  Rendered devise/shared/_links.html.erb (Duration: 0.7ms | Allocations: 815)
  Rendered devise/sessions/new.html.erb within layouts/application (Duration: 2.5ms | Allocations: 2874)

I actually wasn't able to reproduce it on a smaller scale app with just omniauth and devise installed but if helpful the repo for my (very messy) school project where I'm getting the error is here: https://github.com/vincemilo/odin-facebook

Thanks. Nothing jumps out at me so I might have to try and run the app locally, I'll try in the next few days, but let me know if you figure it out before.
One thing I noticed is that the app is using Devise 4.8.1, not 4.9 (which is the main branch that supports Turbo), so it's nothing related to the newer changes there (that I thought could be the culprit at first).

Right the version on the repo is currently running 4.8.1 for it to function
properly but if you upgrade it to 4.9 you will get the error which is where
I'm currently stuck.
On Thu, Feb 16, 2023, 5:35 AM Carlos Antonio da Silva <
@.***> wrote:

Thanks. Nothing jumps out at me so I might have to try and run the app
locally, I'll try in the next few days, but let me know if you figure it
out before.
One thing I noticed is that the app is using Devise 4.8.1, not 4.9 (which
is the main branch that supports Turbo), so it's nothing related to the
newer changes there (that I thought could be the culprit at first).
—
Reply to this email directly, view it on GitHub
https://github.com/heartcombo/devise/issues/5558#issuecomment-1433022619,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAL3UN4CAY5NVDTU5YKPJALWXYNKZANCNFSM6AAAAAAU5MXBWI
.
You are receiving this because you authored the thread.Message ID:
@.***>

Sorry, I updated the comment right after sending it with this bit:

Have you hit the issue while trying to upgrade? Have you removed some of the workarounds like this and this while doing so? If you can push a branch against Devise main / 4.9 alpha, where the error actually occurs, that'd be cool too.

Those additional pieces of code related to supporting Turbo are no longer necessary on the main Devise branch.
I'll try to take a look at the app in the next few days and see if I can learn something.

@vincemilo I got your app working with Devise main and sent you a PR with the diff so you can take a look there: https://github.com/vincemilo/odin-facebook/pull/1.
Everything seems to be working with those changes as I expected, but please let me know if you run into any issues.

@carlosantoniodasilva thanks for this example, unfortunately for me, it doesn't work for sessions (specifically the login). It just re-renders, any advice on what should be looking for?
Thanks in advance.

@ricvillagrana when you say it just re-renders, you mean it just show the form again without the error flash message? This could be because it's not actually re-calling the controller to render the session form again, in my previous tests it was because the failure app was customized to redirect instead, which loses the flash message context, or maybe because the error status code wasn't configured.
If you've upgraded your app and had custom failure app / parent controller set for Turbo specifically, those have to be removed. Also make sure you're using responders 3.1.0+ and have customized the error responses as shown in the changelog/wiki and in the sample upgrade above. Let me know if none of those work.

@vincemilo I got your app working with Devise main and sent you a PR with the diff so you can take a look there: vincemilo/odin-facebook#1.
Everything seems to be working with those changes as I expected, but please let me know if you run into any issues.

This did the trick, thanks so much! I guess app/controllers/turbo_devise_user_controller.rb was from an earlier workaround of devise with turbo?

@vincemilo awesome!

I guess app/controllers/turbo_devise_user_controller.rb was from an earlier workaround of devise with turbo?

That is not an "official" way to integrate / make it work, but it was widely used as a custom implementation while Devise didn't have proper integration with Turbo built-in. Now that it has, that custom code can be safely removed.


Fix occ command

Fix the occ command to allow any characters to be passed as parameters.
To pass quotes as a password, the variable must be defined properly:
"i'm a password" would be nextcloud_admin_pwd: '\""I\''m a password\”"'
The formatting may be a bit weird, but luckily it only needs to be set once 😉
(if you have a password with quotes that is...)
Fix #7

Damned ! It was that simple...
Awesome @noplanman , thank you for the PR


Periodical check for operations with unfinished transactions

In Operations, on the submission of the last approval, the transaction is executed. It is possible, that an error causes the approve to succeed, and the transaction to fail. An Operation would be in PENDING state, while missingApprovals is empty.
We can simply try to execute the transaction again. Since all approvals are present, it should succeed.
=> Periodically check for such error states, and try execute the transactions

@david-buderus  duplicate? https://github.com/upb-uc4/hlf-api/issues/150

@david-buderus  duplicate? https://github.com/upb-uc4/hlf-api/issues/150


LoadImage failing when setting image source on control

I have added the control to a user control that receives a bitmap. However, the code crashes on ImageCropper.cs  LoadImage with layoutRoot being null and this.sourceImage being null. Any idea why this may be occuring?

I didnt explicitly set the controls style (or include the theme as part of my merged dictionaries)


Bug Report: Sicks not reseting

if you play a song and reload it everything resets
well not everything sicks dont reset for some reason
(accuracy is what im talking about)

kay


Links to Genome browser from gene pages for gene-based datasets

Blue sky thinking..
I think it could be nice to link to the browser from gene pages to highlight gene-specific datasets
for example:

on gene pages we could have a section (when applicable) that when clicked loads the relevant tracks (we can pull the description out from the browser config file)

e.g.
swi6 page
swi6 chromatin binding during vegetative growth
swi6 chromatin binding in dcr1delta background during vegetative growth
dcr1 page
swi6 chromatin binding in dcr1delta background during vegetative growth
atf1 page
transcripts in atfdelta background during vegetative growth
etc
not sure what part of the genome would load...but thought it might be nice to "alert" users that a "gene specific" track (involving the gene whose gene page they are on) is available

of course...all genome-wide datasets involve the gene they are on...but this is a bit more direct? not sure...thought it might be nice maybe?

I'm wondering if we could use this, with an additional qualifier:
https://github.com/pombase/curation/issues/550
We intended this for old moicroarray datasets of mutants where there was no "direct" connection to  gene expression  (but basically if you delete any gene, expression of lots of things changes).
However, we could use this  also to indicate   datasets that are  related to a particular gene, and this could be the cue to load these datasets if you enter the browser from this page?

https://github.com/pombase/website/issues/717

@Antonialock   I think we can use pombase/curation#550 for this, so you need to find out what the blocker is for  pombase/curation#550  implementation.
For now I will remove  "discuss" from this ticket. We can come back to if  necessary once
pombase/curation#550 is working, or  if you do not think this option will work for what you envisage?

well, our JBrowse implementation doesn't really classify as an "external link" does it?
I'm chipping away at #550 now and then (mainly when I'm in London and have a bit of time to kill), not really prioritising since it isn't high priority. I don't think there are any blockers for it.

This is a nice idea and we should be able to use the system for https://github.com/pombase/curation/issues/550

(Reviving an old issue)
We can already configure arbitrary links from reference pages (like we did for the TOR phosphoproteome app, pombase/website#1801).  We could have the same thing on gene pages.  It's a quick code change.   The links could be to external sites, or to JBrowse.

We can already configure arbitrary links from reference pages (like we did for the https://github.com/pombase/website/issues/1801#issuecomment-964612161, https://github.com/pombase/website/issues/1801). We could have the same thing on gene pages. It's a quick code change. The links could be to external sites, or to JBrowse.

That was a quick change so I went ahead and did it.  They can have any text and any link, specified in the config file.  Let me know if you'd like formatting changes.  I've only configured Antonia's suggestions for the swi6 page so far:

How are the coordinates for display selected? I clicked the link and got to
a blank region which looks a bit odd (but of course - I guess - it can't be
customized t display "something" for each track)
[image: image.png]

Thanks for checking.  I thought I had configured it to show the right tracks.  I'll fix it!

Thanks for checking. I thought I had configured it to show the right tracks. I'll fix it!

I think I've fixed the problem.  I've tested in Firefox and Chrome so I hope it's OK this time.
I centered the view on swi6 because I had to pick somewhere.  Is there a better region to use as an example?

I centered the view on swi6 because I had to pick somewhere. Is there a better region to use as an example?

I'm a bit confused. Is it possible to make the highlighted tracks be checked when you go to 'browse tracks"?

I'm a bit confused. Is it possible to make the highlighted tracks be checked when you go to 'browse tracks"?

actually, they are for the swi6, but only one track is highlighted in the track configuration for the swi6/clr4delta

I centered the view on swi6 because I had to pick somewhere. Is there a better region to use as an example?

There probably is, but would that require an additional field in the configuration?

How does this link up with
https://github.com/pombase/website/issues/1821
I've got a bit confused between these 2 tickets.
Can discuss next time we chat.

There probably is, but would that require an additional field in the configuration?

The configuration is just a link to JBrowse.  To create the link I went to JBrowse, navigated to swi6 and turned on some tracks.  Then I copied and pasted the URL into the config file.

How does this link up with
https://github.com/pombase/website/issues/1821
I've got a bit confused between these 2 tickets.
Can discuss next time we chat.

That would be good because I don't understand #1821

That would be good because I don't understand https://github.com/pombase/website/issues/1821

was a proposed way to create  'one-off" links to external sites. I suspect all of these will be able to migrate to the  new 'config file'

The configuration is just a link to JBrowse. To create the link I went to JBrowse, navigated to swi6 and turned on some tracks. Then I copied and pasted the URL into the config file.

For some of the genome wind binding sites, I think it might be better to just have a zoomed out view of one chromosome and let the user zoom in to a region of interest, rather than choosing an arbitrary region.
We can ask about this on a group call.

decided to show full chromosome
include links for all "chromatin binding" data with "assayed gene"
document how to do it
announce

swi6 page
swi6 chromatin binding during vegetative growth
swi6 chromatin binding in dcr1delta background during vegetative growth

I noticed that I put the wrong tracks in the second link.  The link is for the tracks with the description "Swi6 chromatin binding sites in clr4delta during vegetative growth".  I'll fix that but should we have links to the clr4delta tracks too?
Antonia says:

etc

:-)
Looks like there are some relevant tracks for Rdp1 and Arb1.  ("Rdp1 chromatin binding sites in clr4delta during vegetative growth" and "Arb1 chromatin binding sites in clr4delta during vegetative growth")
Any others?
There are quite a few track that mention deltas like: "Poly(A)+ transcripts in ago1delta during vegetative growth".
Should they be JBrowse links from gene pages too?
It might be more efficient for us to make a list of useful tracks and then add the configuration for all of them at the same time.

Any others?

Here are the labels of the tracks that look like they mention a gene name.  We'll need to go through and decide which ones need links from the gene pages, how they should be grouped and what labels to use for the links.
Sometimes two genes are mentioned, like:
Arb1 chromatin binding sites in clr4delta during vegetative growth
There's no problem having links to a track from more than one gene page if that makes sense.
track_labels.txt

I noticed that I put the wrong tracks in the second link. The link is for the tracks with the description "Swi6 chromatin binding sites in clr4delta during vegetative growth". I'll fix that

Fixed now.

I noticed that I put the wrong tracks in the second link. The link is for the tracks with the description "Swi6 chromatin binding sites in clr4delta during vegetative growth". I'll fix that but should we have links to the clr4delta tracks too?

For chromatin binding tracks, we only need the link on the pages for the protein of interest. In this case clr4delta is a background/control.

scrub the above.
I think we can show the tracks on pages if they are in the assayed using column or the mutant allele column. In both cases the tracks may be of interest to people studying those particular genes. The Clr4 isn't strictly background in the Woolcock case. It is "Using DNA adenine methyltransferase identification (DamID), we show that the RNAi proteins Dcr1 and Rdp1 physically associate with some euchromatic genes, noncoding RNA genes and retrotransposon long terminal repeats, and that this association is independent of the Clr4 histone methyltransferase."  so this chromatin bidnign set is still of relevance to  people studying Clr4.
Also this makes a general rule for when the links appear on gene pages.

I think we can show the tracks on pages if they are in the assayed using column or the mutant allele column.

I'm working on making this work automatically so we don't have to do any configuration except for editing the JBrowse metadata table.  Will it be OK for the automatic links always show the whole of chromosome I by default?

I think so.

I think we can show the tracks on pages if they are in the assayed using column or the mutant allele column.

Would it be too much to have a table of tracks for selection, like we do on the publication pages?:
https://www.pombase.org/reference/PMID:24152550
The full table could be hidden initially.  We could have a link/button like "List browser tracks associated with ..." to display the table inline.

I think that would be better than just links.

How's this?  I'm sure we can tune the link text, size etc.

Looks good!

Great.  I've checked in the changes which should be visible in the morning.

I've checked in the changes which should be visible in the morning.

It's live now: https://www.pombase.org/gene/SPAC664.01c
Maybe the link isn't prominent enough?

I don't think a toggle button would be clearer - a hyperlink to me implies that it will take you to another page.
I am also not sure the wording is clear. Is it clear that "browser" refers to genome browser and not internet browser?
"view data tracks"?

Fine as as? It seems OK to me .

I am also not sure the wording is clear. Is it clear that "browser" refers to genome browser and not internet browser?
"view data tracks"?

Maybe we should be saying "View high-throughput datasets associated with ..."?

We probably don't need to say "High throughput"
How about
"View sequence-based datasets associated with ... in JBrowse"?
small text change when you access the link
11 datasets associated with ~this~ swi6 are available in the genome browser

Are there any outstanding tasks for this ticket?

I need to fix the wording: https://github.com/pombase/website/issues/717#issuecomment-1168608047

I need to fix the wording: https://github.com/pombase/website/issues/717#issuecomment-1168608047

That's done now.  The main site will have the change soon.


Add parameter for run_time to swarm endpoint

#2198
Implemented only the rest portion of the above issue. Should I have a separate PR for the ui component or make another commit to this PR?

All in one PR is best!

Should we have this as a flag on startup or a default option?

Can I bother you to make some kind of "Advanced" button that hides/exposes this field? There are several other options that the user might want to set, but we dont want to show it all the time.

Added a flag (similar to class-picker) to pass to the master.

Maybe you could have a look at the "advanced" button I suggested? We already have too many command line options for enabling stuff in the UI :)

Added an anchor element to toggle the "advancedOptions" div in "swarm_form"

Very nice, thanks!

Looking into it, for some reason the tests pass on my local. I do see there was a recent merge to master. Should I try a rebase?

Looks like the rebase fixed the tests

The diff looks really bad, but I think it is just git messing with us :)
LGTM!


Feat/virtual machine snapshot

This feature adds an ability to have snapshots of the VirtualMachine objects to do that it brings two new CRDs and two new controllers called VirtualMachineSnapshot and VirtualMachineSnapshotPolicy.

Good to merge now


Closes #359

Description
Fixes the bug of not transferring the pdf metadata to the newly created split pdf files.
Closes #(issue_number)
Checklist:

[x] I have read the Contribution Guidelines
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] My changes generate no new warnings

Contributor License Agreement
By submitting this pull request, I acknowledge and agree that my contributions will be included in Stirling-PDF and that they can be relicensed in the future under the MPL 2.0 (Mozilla Public License Version 2.0) license.
(This does not change the general open-source nature of Stirling-PDF, simply moving from one license to another license)

Realise this should probably modify the modified date not keep it same?

Oops! You are right, let me fix that!


No products in translated shop page

Can you reproduce this issue on default Wordpress theme (eg Storefront)?
Yes
Can you reproduce this issue when all other plugins are disabled except WooCommerce, Polylang and Hyyan WooCommerce Polylang Integration?
Yes
What product versions and settings are you using when this issue occurs?

PHP: 7.0
WordPress: 4.8.9
WooCommerce: 3.4.4
Polylang: 2.3.8
Hyyan WooCommerce Polylang Integration: 1.2.0
Browser: Chrome

Steps to Reproduce

I've followed the getting started instructions (translated all 4 woocommerce pages, links are ok ; product categories are translated too).
I've created 3 products ; 1 in EN only, 1 in FR only, 1 in both.  Note: EN is the default language.

What I Expected
2 products in EN shop, 2 products in FR shop
What Happened Instead
2 products in EN shop, 0 product in FR shop.
Plus, there's something strange with the urls.

With my polylang settings, EN shop page url is /shop and FR is /fr/boutique. When on the EN shop page, the link to the FR page is correct (/fr/boutique). But when you access /fr/boutique, it automatically redirects to /boutique, removing the /fr
When I enter the url /fr/shop, it shows the expected FR shop page with my 2 FR products.

ok thanks for update - closing


[Badger] Unable to read data following disk exhaustion

Context
The machine hosting our Badger Database instance ran out of disk space. After resizing the disk and restarting the instance, we are unable to read some data.
Our issue looks similar to this issue reported on the Dgraph Forum: https://discuss.dgraph.io/t/unable-to-read-some-data/11051
Initial problem
The disk is exhausted, we see errors when inserting new values like:
Unable to write to value log file: \"/dir/002587.vlog\": write /dir/002587.vlog: no space left on device

We resize the disk and restart the instance. The database opens successfully (does not require truncate). Upon reading recently written values required to initialize our application logic, we see Badger logs:
{"level":"error","time":"2022-03-31T04:53:26Z","message":"Unable to read: Key: [34 19 49 66 150 122 158 132 178 53 55 36 133 94 96 233 217 231 132 125 245 68 69 204 160 82 158 149 186 79 9 203 120], Version : 26845631,\n\t\t\t\tmeta: 66, userMeta: 0"}
{"level":"error","time":"2022-03-31T04:53:26Z","message":"Invalid read: vp: {Fid:2587 Len:2119 Offset:383311220}"}

The read (Txn.Get) returns an error:
Invalid read: Len: 2107 read at:[1181425:1183111]

Resolution Attempts
Truncate Database
After opening the database in truncate mode, we still see the same error above when reading some values.
Manually remove values which Badger can not read
We observe which key which cannot be read, then delete that value (Txn.Delete). The deletion succeeds without any error.
After restarting the instance and reading the next value, Badger successfully returns the value. But the decoding step fails, indicating that the data returned is corrupted. The decoding error is below for reference (though this error occurs outside of Badger):
could not decode entity: msgpack: invalid code=6 decoding map length

Expected Behaviour
Require truncating the database (remove any values which cannot be read), then successfully read all values which were not truncated.
Specs

Badger version: github.com/dgraph-io/badger/v2 v2.2007.3
Badger options:

opts := badger.
	DefaultOptions(dir).
	WithKeepL0InMemory(true).
	WithLogger(log).
	WithValueLogFileSize(128 << 23).
	WithValueLogMaxEntries(100000)

3.5TB disk (resized to 4TB)
48 Intel Cascade Lake vCPUs
384 Gib Memory
Operating System: "Container-Optimized OS from Google"
Kernel: Linux 5.10.68+

Is this value log file is there? 2587. And what is it's size?
SyncWrites is set to false by default, relying upon mmap. Mmap does well for process level crashes, but didn't do well if there are filesystem level issues.
Also -- how big are your values? You could also consider turning value log off. The SSTables are always synced to disk, irrespective.

The value log file is there, it's 418MB.
$ du -h ./002587.vlog
418M	./002587.vlog

Mmap does well for process level crashes, but didn't do well if there are filesystem level issues.

That's good to know. Is it necessary to use SyncWrites to avoid this kind of outcome? What kind of impact should we expect from mmap not handling filesystem level issues well?

how big are your values? You could also consider turning value log off. The SSTables are always synced to disk, irrespective.

Most values are fairly small (~1MB or smaller), but we have some very large values (up to 10GB). Looking into getting more specifics here.

Yeah, having SyncWrites would avoid this kind of outcome for sure -- though, it would come at some write performance cost.
You could also look into decreasing the usage of value log. See
https://github.com/outcaste-io/badger/blob/6bfcd5e451a0ed9c65d9467f219164a58acf4e97/options.go#L524
This would allow you to set the value threshold to something really high and allow Badger to set it automatically to ensure only x%-ile of values are going into value log.
Outserv, for example, does not use value log at all -- we don't have big values, so we skip it altogether.


When i remove the infowindow on the marker ,there will appear a blue border on the map container.

When i remove the infowindow on the marker ,there will appear a blue border on the map container.  Is there any way to hide it? Thanks to you.
This is the div node of this blue border,but which has no class or id so i can not rewrite this style easily.

Please file this in the correct location. https://developers.google.com/maps/documentation/javascript/support


Add JSON/YAML output support for helm test

What this PR does / why we need it:
Today when using helm test in CI, there is no robust way to extract the logs from the test pods. This commit makes it possible to get the logs in a machine readable way using the --output flag.
Special notes for your reviewer:
We created this PR as two commits to make the refactoring of GetPodLogs optional. (We recommend git show --ignore-space-change for that commit.)
It is unclear to us if it makes sense to let the user specify --logs when using JSON or YAML format, since in that case the logs are always included anyway. Another aspect to consider is whether the logs should be included in the first place unless --logs is given. Currently, --logs has no effect when combined with -o json or -o yaml.
We should also add tests and update the documentation accordingly.
Testing for backwards compatibility:
We have tested the changes by installing metatest-0.1.0.tar.gz (GitHub didn't allow .tgz hence .tar.gz).
To test that the PR is indeed backwards compatible, we ran the following commands and noted that the output was identical compared to upstream helm:

helm test metatest
helm test metatest --logs

Since the -o flag didn't exist before, introducing it should break nothing.
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[x] this PR has been tested for backwards compatibility

Hi @lindhe.
Generally speaking we ask contributors to please either link to an existing issue or open a new ticket before submitting a PR. That way we have a clear test plan in place ("something is broken; here is how to reproduce the issue. Cannot reproduce the issue with PR X") and we can plan out how to schedule a fix into the next release. It makes things much easier on our end to prioritize work items.
Looking at this PR, it appears to be a feature. Because we already have a lot of features to review for Helm 3.7.0, I'm going to go ahead and schedule a review after Helm 3.7.0 has been released (September 8th).
In the meantime, we do ask for contributions to provide test cases. That way the code being introduced can be tested for regressions in future updates. I did not see any tests for the new --output flags being introduced here. Would you please provide a few?
Thanks.

Generally speaking we ask contributors to please either link to an existing issue or open a new ticket before submitting a PR. That way we have a clear test plan in place ("something is broken; here is how to reproduce the issue. Cannot reproduce the issue with PR X") and we can plan out how to schedule a fix into the next release. It makes things much easier on our end to prioritize work items.

Yeah, sorry for that. In order to know what we wanted to ask for specifically, we began looking into the code. That led us to try out a few things and one thing led to another and then we had a PR instead of an issue. We'll aim to follow the official approach in the future.

In the meantime, we do ask for contributions to provide test cases. That way the code being introduced can be tested for regressions in future updates. I did not see any tests for the new --output flags being introduced here. Would you please provide a few?

We'll absolutely provide test cases! Thanks a lot for the comments, they are really helpful. And we will try to answer your other questions too, as soon as we get time to look into this code again and remind ourselves what the reasoning was. :)

@lindhe We are looking at this for the upcoming 3.8 release in January. Would you be able to update this PR for that?

Hi! Thanks for the heads-up, we're glad to hear that you are considering this for 3.8! Yes, we will bump it up in our backlog then and start working on it during the new sprint we have starting today! I think it should not be too much work for us, it's just that we haven't gotten around to it before. Having it complete by January seems doable.

Marking as "do not merge" until a basic set of unit tests are provided.

I have dug into the code base again to try to find existing tests that could serve as a base for tests for this PR, but it seems like the behavior of helm test isn't covered by tests at all. These changes at least don't cause any test failures:
diff --git a/pkg/action/release_testing.go b/pkg/action/release_testing.go
index 5ae909bd..28a184c2 100644
--- a/pkg/action/release_testing.go
+++ b/pkg/action/release_testing.go
@@ -50,2 +50,5 @@ func NewReleaseTesting(cfg *Configuration) *ReleaseTesting {
 func (r *ReleaseTesting) Run(name string) (*release.Release, error) {
+       if true {
+               panic("Panic in Run")
+       }
        if err := r.cfg.KubeClient.IsReachable(); err != nil {
@@ -102,2 +105,5 @@ func (r *ReleaseTesting) Run(name string) (*release.Release, error) {
 func (r *ReleaseTesting) GetPodLogs(out io.Writer, rel *release.Release) error {
+       if true {
+               panic("Panic in GetPodLogs")
+       }
        client, err := r.cfg.KubernetesClientSet()

but it seems like the behavior of helm test isn't covered by tests at all.

We shoot for good test coverage wherever we can. A lack of tests in place shouldn't mean we should continue that practice. Especially when we (the maintainers) are the ones who will be maintaining this code long after the pull request has been merged.

I could not reply to the existing thread, probably because the original commit wasn't signed so I had to force-push or something. I don't know.
Having thought a bit more about this, I just want to mention that the reason I didn't change to a single fmt.Fprintf call was because I always try to minimize unnecessary diff noise. When I review PRs or examine old commits myself, fly-by cleanup changes and the like often leave me confused, wondering whether they are part of the change being made or not.
What I didn't realize was that it actually makes perfect sense to make said change in this PR, since the printing couldn't be done in a single call before, but now it can. So, would you like us to make the change below?
--- a/pkg/action/release_testing.go
+++ b/pkg/action/release_testing.go
@@ -106,9 +106,7 @@ func (r *ReleaseTesting) GetPodLogs(out io.Writer, rel *release.Release) error {
                        if err != nil {
                                return err
                        }
-                       fmt.Fprintf(out, "POD LOGS: %s\n", h.Name)
-                       _, err = fmt.Fprint(out, string(hookLog))
-                       fmt.Fprintln(out)
+                       _, err = fmt.Fprintf(out, "POD LOGS: %s\n%s\n", h.Name, string(hookLog))
                        if err != nil {
                                return errors.Wrapf(err, "unable to write pod logs for %s", h.Name)
                        }

Checks failed, but not our fault.
Download action repository 'github/codeql-action@v1' (SHA:5f532563584d71fdef14ee64d17bafb34f751ce5)
Warning: Failed to download action 'https://api.github.com/repos/github/codeql-action/tarball/5f532563584d71fdef14ee64d17bafb34f751ce5'. Error: The operation was canceled.
Warning: Back off 19.821 seconds before retry.
Warning: Failed to download action 'https://api.github.com/repos/github/codeql-action/tarball/5f532563584d71fdef14ee64d17bafb34f751ce5'. Error: The operation was canceled.
Warning: Back off 25.718 seconds before retry.
Error: The operation was canceled.

Ah, ye olde missing sign-off error …

This PR has become so large that we might want to consider breaking it apart into one PR adding helm test test cases along with the necessary refactors and one follow-up PR adding --output support to helm test.


Saved blocks journals - export/save as saved blocks journal files

That whould be nice:

Settings - new param where to save blocks journals
Blocks journal tab - button and operation to save current journal
Saved blocks journal - button and operation so export/save as focused/marked saved blocks journals

@Helkhor hello. Can you explain a few things to me:

Current journal - do you mean processes in tab "Current Activity", or something else?
If i understand correctly, you want select multiple lines in tab "Blocks journal" and save than in some other directory?


Move away from the beta version of xdebug in PHP 7.3

Checklist

[x] I've run make from the root directory to see all Dockerfiles are created successfully.
[x] I've updated the documentation if necessary.

Motivation and Context
This PR relates to moving away from a beta version of xdebug.

Description

Moving to the latest version of xdebug available for PHP 7.3.

thanks !!!! @ryanwohara


Unsuccessful attempt to add Azure Container Service shows blank error in UI

Rancher versions:
rancher/rancher: 2.0.4
Docker version: (docker version,docker info preferred)
Server Version: 18.03.1-ce
Operating system and kernel: (cat /etc/os-release, uname -r preferred)
Ubuntu 16.04.4 LTS (Xenial Xerus) 4.4.0-128-generic
Type/provider of hosts: (VirtualBox/Bare-metal/AWS/GCE/DO)
Attempting to add Azure containers service
Setup details: (single node rancher vs. HA rancher, internal DB vs. external DB)
Standalone Rancher running in docker
Environment Template: (Cattle/Kubernetes/Swarm/Mesos)
N/A
Steps to Reproduce:

Spin up a standalone Rancher docker install
Attempt to add an Azure Container Service cluster
Fill in the required details and click "Next: Authenticate and Configure Nodes"
If the request to Azure is unsuccessful, a blank error message is shown:

You have to go into console/chrome developer tools to see the error actually being returned by Azure. Underlying error in this instance is a permission error from Azure (likely because I'm on a Trial Account?)

error: "failed to get orchestrators: containerservice.ContainerServicesClient#ListOrchestrators: Failure responding to request: StatusCode=403 -- Original Error: autorest/azure: Service returned an error. Status=403 Code="AuthorizationFailed" Message="The client '[redacted]' with object id '[redacted]' does not have authorization to perform action 'Microsoft.ContainerService/locations/orchestrators/read' over scope '/subscriptions/[redacted]'.
Results:
Cannot troubleshoot ACS credential failure without having to debug through console/developer tools.

I am having the same problem. I created a service principal as documented here https://docs.microsoft.com/en-us/azure/aks/kubernetes-service-principal#pre-create-a-new-sp. Trying to setup an AKS cluster using the credentials of the created ServicePrincipal also leads to blank error in rancher UI. Using developer console I can see the same error as @andymelichar.
Nevertheless, following the instructions on how to create a ServicePrincipal linked from the docs at https://rancher.com/docs/rancher/v2.x/en/tasks/clusters/creating-a-cluster/create-cluster-azure-container-service/ I was able to create a SP that worked.

Version - 2.0 master 7/12
Not fixed

Version - 2.0 master 7/17
Still broken, same thing

Version - 2.0 master 7/23
Still broken - same thing

Version - 2.0 master 7/30
Verified fixed


docs: added more info for LUA filter's setUpstreamOverrideHost()

Description
This PR adds some clarification around the behavior when strict is not set for setUpstreamOverrideHost() in LUA filter.

Commit Message: docs: added more info for LUA filter's setUpstreamOverrideHost()
Additional Description: Added some clarification around the behavior when strict is not set for setUpstreamOverrideHost() in LUA filter.
Risk Level: N/A
Testing: N/A
Docs Changes: Added
Release Notes: N/A

/assign @adisuissa

@adisuissa Could you PTAL at this as well? It's similar to the changes we made in the Stateful Session filter's docs.


SmoothRectangleBorder now completing with other Decorations

SmoothRectangleBorder now completing with other Decorations without an OutlinedBorder.

#2

You should not merge this. Its just an idea, but does not work


Force encoding to UTF_8 in chef-shell to prevent failures

Currently on some distros where the default isn't UTF (SUSE/omnios/probably others) chef-shell fails to launch with a nasty rb-readline error. It's not the best user experience. Lifting this line from Berkshelf fixes it and makes it easier to troubleshoot on those platforms.
Closes #6446
Signed-off-by: Tim Smith<EMAIL_ADDRESS>

We should probably note this in the release notes since it may impact the behavior of chef-shell for users.

What does this do if the user explicitly has LC_ALL (or any other) set to something like Shift-JIS?

@coderanger, I don't exactly know, but nobody has reported issues against berkshelf.   Since internally we're 8-bit clean, and in the cookbook space we're UTF-8 by default, this produces the least bugginess in the system.  We also force encoding to en_US.UTF-8 internally in chef-client and I have never seen someone who has needed to fiddle with the config there and as a result I'm somewhat doubtful that writing all that config code was ever necessary.  I also suspect that setting the encoding to anything other than UTF-8 will just push bugs around (precisely because cookbooks are UTF-8 by default, so anyone who thinks they solve a problem by setting the encoding to something else will likely wind up sadpanda with other bugs down the road...) and so that would boil down to telling the user they really needed to fix the problem some other way.  If we actually wind up with a customer who wants to have their whole ecosystem setup with Shift-JIS, will never consume external cookbooks with UTF-8 chars in them, and wants to write their own Shift-JIS cookbooks, then we can cross that bridge when we hit it.  So far, haven't hit that one.  The more common case is someone in Europe with ISO-8859-1 set in their environment, trying to consume cookbooks which have UTF-8 characters embedded in them (because author names) and this patch fixes that.
JSON is another external thing that forces everything to UTF-8, although we clean that for reporting and node data, so anything that doesn't transcode just gets a UTF '<?>' character in it...


Discussion about contributing project

HI! Nice projects. I want to work on this project. Are there any issues are there like to contribute and apologies for creating this issue. I can't find any communication and help channel.

HI! Nice projects. I want to work on this project. Are there any issues are there like to contribute and apologies for creating this issue. I can't find any communication and help channel.

Я запутался и немогу вообще не с чем разобратся((потерялся в этом сайте но очень хочу понять а все никак ((

I need to make an contract for Iehtercan how do i do that


MTDSA-12416: RAML for Align historic property URLs

Looks good. Maybe just swap the period endpoints so that it is in the same order as the annual endpoints i.e. with the furnished-holiday-lettings section first followed by the non-furnished-holiday-lettings section.


Allow variables to be passed in cli

could either be as a json --variable-list '{"var": "value"}' or something fancier like cURL does for headers --var value

I can work on that, in both patterns. There is a option in click that allows you to receive unknown variables, we just need to transform the data and maybe sanitize it.
https://click.palletsprojects.com/en/8.1.x/advanced/#forwarding-unknown-options


[BUG] Roblox App is Closing if I click minimize button

Acknowledgement of preliminary instructions

[X] I have read the preliminary instructions, and I am certain that my problem has not already been addressed.
[X] I have thoroughly looked through the available Wiki articles and could not find a solution to my problem.
[X] I am using the latest version of Bloxstrap.
[ ] I did not answer truthfully to all the above checkboxes.

Bloxstrap Version
v2.8.1
What problem did you encounter?
As usual, I set my bloxstrap as the default to launch the Roblox app with some modifications (like fast flags, for better gaming).  After launching successfully, after I tried minimizing the Roblox App, it closes, when it shouldn't. I tried opening it again then "clicked" the "minimize button", still closes the app. I never encountered this problem before. I don't know what went wrong. Its a simple thing, but sometimes I want to minimize the app for me to do other things while afk on roblox.
Bloxstrap Log
N/A

Client issues are no longer accepted.


Feuture request: price prediction

Poe trademacro lets you easily pricecheck rares, without selecting mods or applying ranges. Poe overlay is better when you want to quickly enter ranges or select mods (and better overall) - but the generic "price check" functionality of trademacro is really nice to have when you either:

don't know what mods are relevant to select
don't know if the item is valuable
don't want to spend more then 1 second on an item

I kind of miss the convenience it brought.  I think they use poeprices.info for predicting the price, which uses a neural net for the predictions.
I would love it if this was implemented here!

Duplicate of #178


Add multiple pages to an existing bot service Facebook channel

Related command

Currently the bot service only provides the Azure-CLI command to create a single page Facebook Channel connection. There's no command for creating a multiple page Facebook Channel connection, or command for adding multiple pages to an existing bot service Facebook channel.
There's already a similar issue reported issue #7564 . But it still remains unresolved so far.
Is your feature request related to a problem? Please describe.

Help customer raise this feature request.
The customer's organization requires to automate the addition of Pages since every time the client subscribes to the chatbot they want their page to automatically get assessed by the bot instead of making them wait for 24 hours and having our developers do the entire process manually.

Describe the solution you'd like

Provide a command for adding multiple Page IDs and Access Tokens to an existing bot service Facebook channel, instead of doing it manually.
Describe alternatives you've considered

Any other automation method could also be good.

route to CXP team


Add social media links

Why This PR Adds Value
This PR lets others get in touch with you and network by adding social media links to the footer.
What This PR Adds

This PR adds social links for Linkedin, Github and Twitter
This PR adds a footer.
The social media links only need to be defined in the config file. No other changes are required

Note: if you make any changes to the config file whilst serving you need to stop and rebuild for effect to show.

Screenshot

How This PR Could Be Improved

Add more social network options such as youtube.
Could look a lot better.
Does it make sense in the footer? How about in the top like Robbie's?

Issue This PR Closes
This closes #3

Thanks Robbie, I've resolved the merge conflicts.

Okey dokey, some new changes broke it for me so I've now resolved them.


Plugin legacy skip emit assets

Describe the bug
Hi guys, the latest version of the legacy plugin, no longer issues assets. This does not allow some plugins I use to apply logic even to the generated legacy bundle.
The line is this:
opts.__vite_skip_asset_emit__ = true
I think it is more appropriate to give the possibility to decide by means of a parameter. Obviously, you can set it to true by default in order to skip.
That would be great, thank you in advance, and thank you for your work ❤.
Reproduction
All
System Info
All

Used Package Manager
npm
Logs
No logs

Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

Related: https://github.com/vitejs/vite/pull/6584. That PR fixes some issues, which seems to conflict with this feature request. Can you further elaborate your use case and provide some examples of it?

@bluwy
Essentially the use case is the following: When I use my plugin for Vite to inject the CSS generated by the JS, I need also to inject the same CSS into the legacy bundle generated. But, the legacy code generation happens before the standard flow of Vite, so I don't have the possibility to get the CSS generated and put it inside the legacy bundle.
Now I leave you the link to the plugin here. You can try it and see that for the legacy bundle the CSS is empty. This can be fixed by generating the legacy bundle after the standard flow or giving the possibility through a param to choose if I need the CSS in the chunking phase during the legacy generation.
Thanks
https://github.com/Marco-Prontera/vite-plugin-css-injected-by-js

@bluwy I created a PR to cover those requirements. If you can see it, is very simple and it'a implementation is covered by a documentation that tells the purpose.
Thanks in advance

Thanks for providing your usecase. I tested this on stackblitz and it seems to be working fine in a different way. It looks like Vite already inlines css in legacy with this code
https://github.com/vitejs/vite/blob/1d468c8e6f02b0d0e362aa2d6542af1e1f55ab45/packages/vite/src/node/plugins/css.ts#L459-L468
so maybe it's not needed for the plugin to handle it?

Thanks, I knew about the configuration through Vite, but in this case, I cannot choose the details.
I would also need to inject code that comes from "dynamic" sources, I have a custom version that allows me to optimize a product through the build phase, taking some style and putting it directly in the build (even legacy build).
But for now, I have to use a custom (local) version of the legacy plugin with the modification proposed in PR.


How best to use ruumba with rubocop on a Rails project?

We have a .rubocop.yml file, which inherits from a .rubocop_todo.yml file generated with the --auto-gen-config option.
I've just tried running ruumba app/views --auto-gen-config and it's overwritten my .rubocop_todo.yml file.
What's more it hasn't made ruumba app/views run cleanly, I still get lots of warnings from it.
There's some notes in your README about using a .ruumba.yml and inheriting from .rubocop.yml? I've tried that but it's still not running cleanly.
How do you recommend we lay out our configuration files for rubocop and ruumba, and which command or commands should we run to run them?
I think this would be a useful section to add to your README file somewhere. Thanks!

If it's useful, I've pasted my .ruumba.yml config below.

This is based on ruumba (0.1.5) and rubocop (0.58.2).

# TODO: Monitor these, and re-enable permanently once Ruumba flags correctly.

Lint/Void:
  Enabled: false

Lint/EmptyWhen:
  Enabled: false

Rails/Presence:
  Enabled: false

Style/EmptyElse:
  Enabled: false

Style/IdenticalConditionalBranches:
  Enabled: false

Style/IfInsideElse:
  Enabled: false

Style/IfUnlessModifier:
  Enabled: false

Style/Next:
  Enabled: false

Style/UnneededCondition:
  Enabled: false

# TODO: Enable cops below and resolve violations.
# Note: The `--auto-gen-config` flag is glitchy with `ruumba`.
# To re-generate this list;
# - delete below this line.
# - run `bin/ruumba`
# - Copy full output (many errors + warnings!)
# - Use text manipulation to extract occurrences of `: C: XXXX/YYYY` and `: W: XXXX/YYYY`
# - De-duplicate and sort matching cop names
# - Paste below and manipulate to be `Enabled: false` in each case.

 I'll give that a go and let you know how I get on 😄 👍

@kaoru, glad @olliebennett could help! Let me know if you get along and/or if you still would like a README update. (Things are hectic on my end these days, but README updates should be pretty easy to merge.)


Template context variables delete on instantiation

Description
On Virtual Machine Template instantiation, the value of context variables set from NIC -like $NIC[VIRTIO_QUEUES]- are deleted. Also, if several USER_INPUTS present, at least one of them is removed from context.
To Reproduce
Having a Virtual Network defined as follows -with attribute VIRTIO_QUEUES="8"-:
BRIDGE="br1"
BRIDGE_TYPE="linux"
GATEWAY="<IP_ADDRESS>"
NETWORK_ADDRESS="<IP_ADDRESS>"
NETWORK_MASK="<IP_ADDRESS>"
OUTER_VLAN_ID=""
PHYDEV=""
VIRTIO_QUEUES="8"
VLAN_ID=""
VN_MAD="bridge"

And a Virtual Machine Template defined as follows:
CONTEXT=[
  NETWORK="YES",
  SSH_PUBLIC_KEY="$USER[SSH_PUBLIC_KEY]",
  USER_INPUT1="$USER_INPUT1",
  USER_INPUT2="$USER_INPUT2",
  VIRTIO_QUEUES="$NIC[VIRTIO_QUEUES]" ]
CPU="1"
DISK=[
  IMAGE="Alpine Linux 3.11",
  IMAGE_UNAME="oneadmin" ]
GRAPHICS=[
  LISTEN="<IP_ADDRESS>",
  TYPE="VNC" ]
INPUTS_ORDER="USER_INPUT1,USER_INPUT2,USER_INPUT3"
MEMORY="128"
MEMORY_UNIT_COST="MB"
NIC=[
  NETWORK="mynet",
  NETWORK_MODE="auto",
  NETWORK_UNAME="oneadmin",
  SCHED_REQUIREMENTS="ID=\"4\"",
  VIRTIO_QUEUES="8" ]
NIC_DEFAULT=[
  MODEL="virtio",
  VIRTIO_QUEUES="8" ]
OS=[
  BOOT="" ]
USER_INPUTS=[
  USER_INPUT1="M|text|input1",
  USER_INPUT2="M|text|input2",
  USER_INPUT3="M|text|input3" ]
VCPU="1"

On instantiation from Sunstone: value of VIRTIO_QUEUES is deleted and USER_INPUT3 variable is not present.

CONTEXT=[
  DISK_ID="1",
...
  TARGET="hda",
  USER_INPUT1="one",
  USER_INPUT2="two",
  VIRTIO_QUEUES="" ]

Log output:
Tue Mar 24 13:03:47 2020 [Z0][ReM][D]: Req:528 UID:0 IP:<IP_ADDRESS> one.template.instantiate invoked , 3, "", false, "USER_INPUT1="one"
USER_INPUT2="two"
USER_INPUT3="three"
DISK=[
  IMAGE="Alpine Linux 3.11",
  IMAGE_UNAME="oneadmin",
  SIZE="256"
]

NIC=[
  NETWORK_MODE="auto",
  SCHED_REQUIREMENTS="ID=\"4\""
]

MEMORY="128"
CPU="1"
VCPU="1"
NIC_ALIAS = []
SCHED_REQUIREMENTS = []
SCHED_DS_REQUIREMENTS = []", false

On instantiation from CLI: USER_INPUT3 variable is not present.

CONTEXT=[
  DISK_ID="1",
...
  TARGET="hda",
  USER_INPUT1="aaa",
  USER_INPUT2="bbb",
  VIRTIO_QUEUES="8" ]

Log output:
Tue Mar 24 13:12:04 2020 [Z0][ReM][D]: Req:608 UID:0 IP:<IP_ADDRESS> one.template.instantiate invoked , 3, "", false, "USER_INPUT1 = "aaa"
USER_INPUT2 = "bbb"
USER_INPUT3 = "ccc"", false

Expected behavior
On instantiation all context variables and their values must be present.
Details

Affected Component: Sunstone, CLI
Version: from 5.10

Progress Status

[ ] Branch created
[ ] Code committed to development branch
[ ] Testing - QA
[ ] Documentation
[ ] Release notes - resolved issues, compatibility, known issues
[ ] Code committed to upstream release/hotfix branches
[ ] Documentation committed to upstream release/hotfix branches

PR's:

one: #4463
docs: OpenNebula/docs/pull/1026

needs test


Work to fix libcc unit tests

This PR makes changes to address libcc unit test issues. (#360 and #443)

I've just fixed the content_browsertests build and the existing test right now. But we should probably add tests to test our patch code.

Are these changes related to any of our patches?
If yes, they should be done in the same patch.

Can you please rebase your branch onto the latest master?
#470 was merged several hours ago and it's added a new config for patches, so when you add a new patch it also has to be added to that config to be actually applied.
I'll update the documentation soon.

Are these changes related to any of our patches?
If yes, they should be added to that patch.

Second that, will be easy to reason the changes.

Also, can you please add your Slack email to your Github account?
GitHub doesn't know that<EMAIL_ADDRESS>is you at the moment )

I should've committed with the other email address. Will amend the commit to change the email address.
Changes are related to another patch, but I was thinking that keeping test changes separate could be a good idea.

Changes are related to another patch, but I was thinking that keeping test changes separate could be a good idea.

Reasons?

Yeah, that was the initial thought, but having them in the same patch is the right thing to. I've updated the patch.

Following tests are also failing after running the run_tests script.

components_unittests:

AutofillManagerTest.UploadCreditCardAndSaveCopy

accessibility_unittests:

AXTreeTest.EmptyNodeOffscreenWhenAllChildrenOffscreen
AXTreeTest.GetBoundsUpdatesOffscreen

views_unittests:

WidgetTest.ChildStackedRelativeToParent

extensions_browsertests:

SocketsUdpApiTest.SocketsUdpExtension

pdfium_unittests:

cpdf_parser.RebuildCrossRefCorrectly
cpdf_parser.RebuildCrossRefFailed

shell_dialogs_unittests
rlz_unittests:

RlzLibTest.SendFinancialPing

compositor_unittests:
All tests in LayerWithDelegateTest, LayerWithNullDelegateTest and LayerWithRealCompositorTest.
	(@alexeykuzmin has verified that these are failing in chromium as well)
command_buffer_gles2_tests:

EGLThreadTest.Basic (This one is similar to the WeakPtr test failure; related to disable DCHECK patch)

ffmpeg_regression_tests:
104 test failures. I looked at a few in the list and looks like they’re all because they could not find the data file.

Maybe some of these are not needed, but these were all the failures I got after running the run_tests script.
 We should probably remove some targets if we do not need them.

Its weird that extensions_browsertests got built, there shouldn't be a target in our test build config that has it as a dep, it should be disabled if its getting built. I am good with having rest of the components, as we use parts of them in Electron. We can disable the tests that can't be fix at the moment.

Conflicts.

How did I manage to break all of CI? 🤔

@nitsakh

disable-warning-win.patch failed to apply

@nitsakh It seems like Windows build are OK. Should we merge the PR?

Yes, let's merge the PR. We can then get this in CI. If there are some things, we can work on those after the merge.


added ControlPanel to marker-clustering example

Just added ControlPanel to marker-clustering example.
The component was there, but it was not loded from <App />.

Thanks!


Internal: add test for ReferenceUpload and DOIImport

[x] test general functionality
[x] DOIInputComponent.js should be test covered
[x] ReferenceUploadComponent.js should be test covered
[x] BibConversion.js should be test covered
[x] QueryComponent.js should be test covered

We've added some test and increase coverage in #1169, so for now I will close it. However this should be improved in the future.


coverage: cover platform_bridge code

It is currently uncovered leading to an overall coverage percentage of:
 Overall coverage rate:
  lines......: 79.9% (650 of 814 lines)
  functions..: 14.1% (259428 of 1840845 functions)
Code coverage 79.9 is lower than limit of 96.5

Additional coverage added in:
https://github.com/lyft/envoy-mobile/pull/1080
https://github.com/lyft/envoy-mobile/pull/1097
https://github.com/lyft/envoy-mobile/pull/1099


How to make playerview full screen button with seeker button for volume

May i know this library can support for full screen button and seekbar button for volume control.tq

No
There is no generic solution in the library current to make the videos full screen but you can use a Dialog to create a full screen and add remove the player from main view and add it to the Dialog box.
Initialize the Fullscreen Dialog
private fun initFullScreenDialog() {
        fullScreenDialog =
            object : Dialog(context, android.R.style.Theme_Black_NoTitleBar_Fullscreen) {

                override fun onBackPressed() {
                    closeFullScreenDialog()
                    super.onBackPressed()
                }
           }
    }

Open the Full Screen
 private fun openFullScreenDialog()
        isFullScreen = true
        (player_view.parent as ViewGroup).removeView(player_view)

        player_view.resizeMode = AspectRatioFrameLayout.RESIZE_MODE_FIT
        fullScreenDialog.addContentView(
            playerview,
            ViewGroup.LayoutParams(
                ViewGroup.LayoutParams.MATCH_PARENT,
                ViewGroup.LayoutParams.MATCH_PARENT
            )
        )
        fullScreenDialog.show()

    }

Closing the full screen
private fun closeFullScreenDialog() {
        isFullScreen = false

        (player_view.parent as ViewGroup).removeView(player_view)
        fullScreenDialog.dismiss()
        player_view.resizeMode = AspectRatioFrameLayout.RESIZE_MODE_ZOOM
        MainLinearLayout.addView(player_view)
        player_view.requestFocus()
    }

You can refer to this link for further understanding.

@hafiz013 To create fullscreen player, there is an existing sample in the Facebook demo: https://github.com/eneim/toro/blob/cb59d3a15053741c0ee1ae0a60e32719778aef02/app/src/main/java/im/ene/toro/sample/facebook/timeline/TimelineFragment.java#L145 It is not trivial, but you can follow that. This sample will automatically open full screen player if user rotates the device. You can modify the control flow to make it manual.
About the volume seekbar, it is not the scope of this library, you should consult the ExoPlayer library about customizing the PlayerView UI. To update volume manually, please use the method setVolumeInfo in the Helper class.