Endoc-367 Fix links in Custom Resources

Fixed links in v6.3.2 custom-resources.md, next custom-resources.md and added text to Readme.md for Versions. I am unsure about the txt in the readme.

I like your readme comment :) maybe use lowercase for custom-resources.md for consistency?

I like your readme comment :) maybe use lowercase for custom-resources.md for consistency?

I'm with Lydia, lowercase the reference (since Linux is definitely case-sensitive when it comes to file names) and we're good to go.

thanks. You're right, don't know why I cap those. I guess old habits.
On Mon, Nov 1, 2021 at 5:40 PM Lyd1aCla1r3 @.***> wrote:

I like your readme comment :) maybe use lowercase for custom-resources.md
for consistency?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/entando/entando-docs/pull/333#issuecomment-956782844,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AWCSDA7CLBYHCJK4PVNCHLTUJ4JO7ANCNFSM5HFBDWYA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

done


Normalization factor Z in margin value

Very interesting work for feature distillation.! I would like to know why Z is needed in expectation calculation of negative responses. So if we discard  Z, I want to know whether the performance is degraded.  Thank you!

Hi, thank you for your interest on my work.
Because I want to use expectation over conditional situation (x < 0), Z is needed to calibrate original distribution to distribution only on negative parts.
However, in experiments with various margin, I found that my method is not very sensitive to margin value.
So, I think discarding Z doesn't make significant performance changes.
But, I didn't measure performance without Z.
So, I don't know exactly whether it degrades performance or not.

Thanks for your response！ I get it.


make MIRI_TEST_TARGET and RUSTC_BLESS entirely an internal thing

They are just used to communicate between ./miri test/./x.py test miri and the test harness, but should not be used by users.

@bors r+

:pushpin: Commit 834afd9888a8886cda34b7e9e4108c222da0805f has been approved by RalfJung
It is now in the queue for this repository.

:hourglass: Testing commit 834afd9888a8886cda34b7e9e4108c222da0805f with merge e1473e621c1268564d560cafbbc52e4d3e41f595...

:sunny: Test successful - checks-actions
Approved by: RalfJung
Pushing e1473e621c1268564d560cafbbc52e4d3e41f595 to master...


scan error: zip END header not found

I used this very useful tool on many servers, all with basically the same basic software installed.
Immediately after starting its spams the output with
...
scan error: zip END header not found
scan error: zip END header not found
scan error: zip END header not found
scan error: zip END header not found
scan error: zip END header not found
scan error: zip END header not found
...

Any Idea where I could look in order to fix this?
System Info
$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 20.04.3 LTS
Release:        20.04
Codename:       focal

Sry, did't check that there was a newer version release with a better output.
Issue can be Closed/Ignored


upgrade pip before proceeding with other installs.

Just a good hygiene that if we are relying on pip, make sure that it's latest version.
Also, prevents this warning the stderr
You are using pip version 8.1.1, however version 8.1.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.

I'd much rather pin to exactly the version we also bundle: https://github.com/dcos/dcos/blob/master/packages/python/buildinfo.json#L20

Okay to pin it. We will keep running into warnings and will have to upgrade it.

In general we need a "are the internal packages out of date" helper thing (the python packages, openresty, etc). I think that's a separate problem though.

I agree. I was thinking about it, as how will keep consistency (if required) and a single way to update the packages if they out of date. I will think of a solution for it and approach it as a different problem.

Review comment addressed. Thank you!

🚢


request help: account permission isolation based on etcd url prefix

Issue description
The APISIX use etcd as config center with url prefix like '/apisix'.
It support limited role control like admin or viewer.
Means that:

Different teams can only use one account for api management.
Or use multiple apisix deployment with multiple account without a central dashboard to manage.

I have checked the data in etcd, looks like:
/apisix/plugin_configs/
init_dir
/apisix/plugin_metadata/
init_dir
/apisix/plugins/
init_dir
/apisix/proto/
init_dir
/apisix/routes/
init_dir
/apisix/routes/3b5e18a7
{"name":"ingress_local.httpbin.org_\/","desc":"Created by apisix-ingress-controller, DO NOT modify it manually","upstream_id":"d1ce4b4f","host":"local.httpbin.org","priority":0,"labels":{"managed-by":"apisix-ingress-controller"},"status":1,"uris":["\/","\/*"],"update_time":1646125717,"id":"3b5e18a7","create_time":1646124473}

If we treat /apisix/* as admin scope, if no other project, then it equals /apisix/default/* which will not make a breaking change.
If project added, /apisix/projectName/* can be used for different projects(or teams) with different  accounts.
Each account can only access its own apis.
And the admin account is able to manage all the apis.
Environment

your apisix-ingress-controller version (output of apisix-ingress-controller version --long):

apache/apisix-ingress-controller:1.4.0

your Kubernetes cluster version (output of kubectl version):

Server Version: version.Info{Major:"1", Minor:"22+", GitVersion:"v1.22.3-aliyun.1", GitCommit:"2d7fa03ee32075acb101bc7286176439c3edddf1", GitTreeState:"clean", BuildDate:"2022-01-18T14:15:16Z", GoVersion:"go1.16.9", Compiler:"gc", Platform:"linux/amd64"}

if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a):

This is not the goal of this project.
The permissions isolation that is concerned in this project is based on Kubernetes' RBAC approach.
The content in your issue can be solved by deploying multiple sets of APISIX and adding different etcd prefixes to them.


How it work?

Hello people.
I am a newbie in machine learning and I can't understand what output this example(languageDetection).
We input file with many sentences in three languages and result of this program its number like 1, what it is this number means?
Based on program name I think we need input some message and after complete, script show language of this sentence, but this is not true.
Can somebody describe how this script works and what it shows?

I'm interested too.

Hello, let me explain:
echo 'Accuracy: '.Accuracy::score($randomSplit->getTestLabels(), $predictedLabels);

This number is accuracy of trained classifier. 1 means that 100% predicted labels was correct.
Also in this examples you can see StratifiedRandomSplit. Class samples are split to two groups: train group and test group. Distribution of samples takes into account their targets and trying to divide them equally. You can adjust number of samples in each group.
This is most simple validation technique which allow you to test accuracy of trained model.
If this helps then please close the issue.

Does this mean that the accuracy of the language definition will be 100%?
Which way to look in order to implement input text from the console and after that program detects language?

Yes and no. Accuracy is 100% for given test data, this doesn't mean for all possible data.
To predict language you can use:
$classifier->predict($samples);

But sample as string must be prepared:
TokenCountVectorizer - Transform a collection of text samples to a vector of token counts.
TfIdfTransformer - Tf–idf, short for term frequency–inverse document frequency, is a numerical statistic that is intended to reflect how important a word is to a document in a collection or corpus.
You can read more in:
http://php-ml.readthedocs.io/en/latest/machine-learning/feature-extraction/token-count-vectorizer/
http://php-ml.readthedocs.io/en/latest/machine-learning/feature-extraction/tf-idf-transformer/

var_dump($classifier->predict($samples));
This output array with languages and every key of this array correspond to sentence in langues.csv?

@niksib You can use var_dump($vectorizer->getVocabulary()); to get all the split words.

@itcraftsmanpl I try to new both TokenCountVectorizer and TfIdfTransformer,then I put my unknown word to predict.It seems that vectors can't be matching in a proper way.If you have time,I hope a sample as string's example can be publish on here.Thanks for all your work for this project.

Hello @mountainguan, sorry for late response but I miss this issue. If have those examples then I can look at your problem. If not then maybe we can close issue?

https://github.com/Neroxiezi/PHP-ML-study - :open_mouth: I did not know about it. Amazing...


Working Example

Hi, I am looking at using this library but can't get it work. Just wondering if you have a working example, I provide the encoded stack that I copy and paste from Chrome and when I call the method and console.log to see the new decoded version of the stack I just get the original encoded stack printed out.
Thanks
Chris

We no longer maintain this, so unfortunately, you're on your own. :)

Ah Ok no probs. I think I figured what I was doing anyway I was being a numpty :)


make: spurious Timeout exceeded

As of 53c7323 running make on Mac timeouts
Step 9/9 : COPY . .
 ---> Using cache
 ---> 330478b7b567
Successfully built 330478b7b567
Successfully tagged containous/maesh:check
docker run --rm \
      -v /Users/ysz/maesh:/go/src/github.com/containous/maesh \
      -w /go/src/github.com/containous/maesh \
      -e GO111MODULE \
      "containous/maesh:check" golangci-lint run --config .golangci.toml
level=error msg="Running error: context loading failed: no go files to analyze"
level=error msg="Timeout exceeded: try increase it by passing --timeout option"
make: *** [check] Error 4

Running in container gives
$ docker run -it -v /Users/ysz/maesh:/go/src/github.com/containous/maes -w /go/src/github.com/containous/maesh -e GO111MODULE "containous/maesh:check" bash
bash-5.0# golangci-lint -v run --config .golangci.toml
INFO [config_reader] Used config file .golangci.toml
INFO [lintersdb] Active 29 linters: [bodyclose deadcode depguard dogsled errcheck gocognit goconst gocritic gocyclo godox gofmt goimports golint gosimple govet ineffassign interfacer misspell nakedret staticcheck structcheck stylecheck typecheck unconvert unparam unused varcheck whitespace wsl]
INFO [loader] Go packages loading at mode 575 (files|name|compiled_files|exports_file|imports|types_sizes|deps) took 52.56940413s
INFO [runner/filename_unadjuster] Pre-built 0 adjustments in 15.260549ms
INFO Memory: 601 samples, avg is 86.1MB, max is 271.0MB
INFO Execution took 1m0.199752748s
INFO [runner] Issues before processing: 36, after processing: 0
INFO [runner] Processors filtering stat (out/in): cgo: 36/36, skip_dirs: 36/36, identifier_marker: 36/36, exclude: 0/36, path_prettifier: 36/36, filename_unadjuster: 36/36, skip_files: 36/36, autogenerated_exclude: 36/36
INFO [runner] processing took 5.368023ms with stages: identifier_marker: 3.947476ms, path_prettifier: 591.214µs, autogenerated_exclude: 370.065µs, skip_dirs: 195.463µs, exclude: 133.213µs, cgo: 83.036µs, filename_unadjuster: 37.137µs, max_from_linter: 5.017µs, max_same_issues: 2.187µs, nolint: 721ns, skip_files: 479ns, diff: 430ns, path_shortener: 420ns, exclude-rules: 342ns, source_code: 339ns, uniq_by_line: 275ns, max_per_file_from_linter: 209ns
INFO [runner] linters took 36.07994956s with stages: goanalysis_metalinter: 34.045935977s, unused: 2.027864313s
INFO File cache stats: 30 entries of total size 187.4KiB
ERRO Timeout exceeded: try increase it by passing --timeout option
bash-5.0#

Thank you @ldez


ip-reconciler race condition with Whereabouts, leads to IP cleanup and duplicate IPs

I'm seeing another duplicate IP issue caused by an accidental IP cleanup, it appears the ip-reconciler CronJob has a race condition with whereabouts allocating IPs. I see whereabouts allocates a certain IP to a Pod, Patches the IPPool CR, and updates resourceversion... all good so far.
However, if the ip-reconciler Job runs at the right time (Change the schedule to 1 minute, to increase the odds), it gets the updated IPPool with new allocation. But when it fetches the Pod, the IP has not yet been updated on the Pod. This is maybe due to kubelet or k8s still processing the container and not adding the network status w/ IPs and macs. So the ip-reconciler sends a "remove" Patch operation.
We can see that whereabouts on a node updated the Pool with allocation. I added my own logs in storage/kubernetes/ipam.go to print the CR to get the ResourceVersion and Spec. We can see it allocated for Pod web-2:

2021-11-06T03:38:11Z [debug] PF9: re-getting IPPool...
2021-11-06T03:38:11Z [debug] PF9: GetIpPool: &{TypeMeta:{Kind: APIVersion:} ObjectMeta:{Name:<IP_ADDRESS>-24 GenerateName: Namespace:default SelfLink:/apis/whereabouts.cni.cncf.io/v1alpha1/namespaces/default/ippools/<IP_ADDRESS>-24 UID:b173c049-dc3d-4a47-8409-53c52c3a2100 ResourceVersion:733533 Generation:204 CreationTimestamp:2021-11-03 18:59:37 +0000 UTC DeletionTimestamp:<nil> DeletionGracePeriodSeconds:<nil> Labels:map[] Annotations:map[] OwnerReferences:[] Finalizers:[] ClusterName: ManagedFields:[{Manager:whereabouts Operation:Update APIVersion:whereabouts.cni.cncf.io/v1alpha1 Time:2021-11-06 03:38:11 +0000 UTC FieldsType:FieldsV1 FieldsV1:{"f:spec":{".":{},"f:allocations":{".":{},"f:45":{".":{},"f:id":{},"f:podref":{}},"f:46":{".":{},"f:id":{},"f:podref":{}},"f:47":{".":{},"f:id":{},"f:podref":{}}},"f:range":{}}}}]} Spec:{Range:<IP_ADDRESS>/24 Allocations:map[45:{ContainerID:0b403a8e43c6183225aefb128dc187535bdbacea2a63159d0679705535f6ada1 PodRef:default/web-0} 46:{ContainerID:b565baad124e2fb57d883f33a0019048354abca904bfd9f7ae18123bbe118779 PodRef:default/web-1} 47:{ContainerID:be4726eb3c4f6b092f2c93e531fe25f9a843c0876c07edddd2fc93fe653bcea2 PodRef:default/web-2}]}}
2021-11-06T03:38:11Z [debug] PF9: AFTER PATCH Allocations: [IP: <IP_ADDRESS> is reserved for pod: default/web-0 IP: <IP_ADDRESS> is reserved for pod: default/web-1 IP: <IP_ADDRESS> is reserved for pod: default/web-2]

At almost the same time, CronJob ran, and from custom logs I added, I see it got ResourceVersion 733533 (the one just written by whereabouts above), but the Pod has no IP annotations yet, so it removes it:

2021-11-06T03:38:11Z [debug] pod reference default/web-0 matches allocation; Allocation IP: <IP_ADDRESS>; PodIPs: map[<IP_ADDRESS>:{} <IP_ADDRESS>:{}]
2021-11-06T03:38:11Z [debug] pod reference default/web-1 matches allocation; Allocation IP: <IP_ADDRESS>; PodIPs: map[<IP_ADDRESS>:{} <IP_ADDRESS>:{}]
2021-11-06T03:38:11Z [debug] pod reference default/web-2 matches allocation; Allocation IP: <IP_ADDRESS>; PodIPs: map[]
2021-11-06T03:38:11Z [debug] pod ref default/web-2 is not listed in the live pods list

2021-11-06T03:38:11Z [debug] PF9: patch = [{remove /spec/allocations/34 <nil>}]
2021-11-06T03:38:11Z [debug] PF9: wrote patchdata: [{"op":"test","path":"/metadata/resourceVersion","value":"733528"},{"op":"remove","path":"/spec/allocations/34"}]
2021-11-06T03:38:11Z [debug] Going to update the reserve list to: [IP: <IP_ADDRESS> is reserved for pod: default/web-0 IP: <IP_ADDRESS> is reserved for pod: default/web-1]
2021-11-06T03:38:11Z [debug] PF9: patch = [{remove /spec/allocations/47 <nil>}]
2021-11-06T03:38:11Z [debug] PF9: wrote patchdata: [{"op":"test","path":"/metadata/resourceVersion","value":"733533"},{"op":"remove","path":"/spec/allocations/47"}]
2021-11-06T03:38:11Z [debug] successfully cleanup IPs: [<IP_ADDRESS> <IP_ADDRESS>]

So IPs <IP_ADDRESS> <IP_ADDRESS> got cleaned up from the IPPool (Pods attach to two networks, issue is hit for both attachments). Next Pod in the StatefulSet gets scheduled, and whereabouts allocates those same IPs resulting in the two Pods having duplicate IP as well.
### I think the root cause is this:
**Any reason the IsPodAlive() function checks if the IP is present in the Pod... rather than only doing the cleanup if the Pod is... not Alive? As I understand the reconciler was for node crash resulting in orphaned IPs. In which case the Pod shouldn't exist.
https://github.com/k8snetworkplumbingwg/whereabouts/blob/7e39872d14d95e388a016c41cac9175dc346bb74/pkg/reconciler/iploop.go#L110**

@maiqueb

### I think the root cause is this:
**Any reason the IsPodAlive() function checks if the IP is present in the Pod... rather than only doing the cleanup if the Pod is... not Alive? As I understand the reconciler was for node crash resulting in orphaned IPs. In which case the Pod shouldn't exist.

The reasons for which we've decided to actually check if pod X really owns the address can be checked in
https://github.com/k8snetworkplumbingwg/whereabouts/pull/118#discussion_r669986763
We could probably remove this condition (check if the IP is present in the pod) if we start relying on pod UIDs rather than names.
... which, afaiu is (right now) not an option since you can't GET by UIDs: https://github.com/kubernetes/kubernetes/issues/20572

https://github.com/k8snetworkplumbingwg/whereabouts/blob/7e39872d14d95e388a016c41cac9175dc346bb74/pkg/reconciler/iploop.go#L110
**

"so it might happen that a StatefulSet Pod got new IP in the meantime, while previous IP is still reserved in IPPool pointing to the same running Pod"

Do you know under what case that other bug may happen? I was under assumption the reocnciler was for crashed/offine nodes resulting in orpaned IPs. In which case the Pod does not exist anymore.
Otherwise, I was thinking we could only do this IP check for Pods that have Phase: Running in their status(ignore the IP check for any pods in a transient or bad state).
Or, we skip this check only for Pods that have Phase: Pending
Based on this, the possible phases are: Pending, Running, Succeeded, Failed, and Unknown: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/
From what Ive seen, at least for this issue, the STS Pods are in "Pending" phase as kubelet is still bringing up the Pod.
Let me know what you think?  @maiqueb @dougbtv

"so it might happen that a StatefulSet Pod got new IP in the meantime, while previous IP is still reserved in IPPool pointing to the same running Pod"

Do you know under what case that other bug may happen? I was under assumption the reocnciler was for crashed/offine nodes resulting in orpaned IPs. In which case the Pod does not exist anymore.

If (for whatever reason) the pod gets removed (not gracefully, i.e. the CNI del is not sent), the allocation  will linger in the IPPool. The stateful set will then create another pod - having the same name - that will be assigned a new allocation.

Otherwise, I was thinking we could only do this IP check for Pods that have Phase: Running in their status(ignore the IP check for any pods in a transient or bad state). Or, we skip this check only for Pods that have Phase: Pending
Based on this, the possible phases are: Pending, Running, Succeeded, Failed, and Unknown: https://kubernetes.io/docs/concepts/workloads/pods/pod-lifecycle/
From what Ive seen, at least for this issue, the STS Pods are in "Pending" phase as kubelet is still bringing up the Pod.
Let me know what you think? @maiqueb @dougbtv

@xagent003 I think you're right: if we skip the IP address liveness check in the pod's status for Pending pods, we quite probably fix the race you're mentioning.


Not working - Upgraded to Angular 6.0 & RxJS 6.x

Angular 6.0 is out! Maybe a good idea to upgrade as well?
Together with RxJS (try to run without rxjs-compat package).
Since I can't get it working anymore when I use Angular 6.0...
Kind regards,
Melroy

I'm getting:
You provided an invalid object where a stream was expected. You can provide an Observable, Promise, Array, or Iterable.
Stack trace:
subscribeToResult@http://localhost:4201/vendor.js:129509:27
WithLatestFromSubscriber@http://localhost:4201/vendor.js:137082:22
./node_modules/@oasisdigital/angular-material-search-select/@oasisdigital/angular-material-search-select.es5.js/WithLatestFromOperator.prototype.call@http://localhost:4201/vendor.js:137059:33
./node_modules/rxjs/_esm5/internal/Observable.js/Observable.prototype.subscribe@http://localhost:4201/vendor.js:143008:13
./node_modules/@oasisdigital/angular-material-search-select/@oasisdigital/angular-material-search-select.es5.js/MapOperator.prototype.call@http://localhost:4201/vendor.js:134014:16
./node_modules/rxjs/_esm5/internal/Observable.js/Observable.prototype.subscribe@http://localhost:4201/vendor.js:143008:13
./node_modules/@oasisdigital/angular-material-search-select/@oasisdigital/angular-material-search-select.es5.js/DistinctUntilChangedOperator.prototype.call@http://localhost:4201/vendor.js:132682:16
./node_modules/rxjs/_esm5/internal/Observable.js/Observable.prototype.subscribe@http://localhost:4201/vendor.js:143008:13
./node_modules/@oasisdigital/angular-material-search-select/@oasisdigital/angular-material-search-select.es5.js/TakeOperator.prototype.call@http://localhost:4201/vendor.js:136036:16
./node_modules/rxjs/_esm5/internal/Observable.js/Observable.prototype.subscribe@http://localhost:4201/vendor.js:143008:13
./node_modules/@oasisdigital/angular-material-search-select/@oasisdigital/angular-material-search-select.es5.js/SearchSelectBase.prototype.blur@http://localhost:4201/vendor.js:137433:9
View_SearchSelectComponent_0/<@ng:///SearchSelectModule/SearchSelectComponent.ngfactory.js:151:28
handleEvent@http://localhost:4201/vendor.js:62699:16
callWithDebugContext@http://localhost:4201/vendor.js:63796:22
debugHandleEvent@http://localhost:4201/vendor.js:63499:12
dispatchEvent@http://localhost:4201/vendor.js:60166:16
renderEventHandlerClosure/<@http://localhost:4201/vendor.js:60610:38
decoratePreventDefault/<@http://localhost:4201/vendor.js:121259:36
./node_modules/zone.js/dist/zone.js/</ZoneDelegate.prototype.invokeTask@http://localhost:4201/polyfills.js:2737:17
onInvokeTask@http://localhost:4201/vendor.js:55646:24
./node_modules/zone.js/dist/zone.js/</ZoneDelegate.prototype.invokeTask@http://localhost:4201/polyfills.js:2736:17
./node_modules/zone.js/dist/zone.js/</Zone.prototype.runTask@http://localhost:4201/polyfills.js:2504:28
./node_modules/zone.js/dist/zone.js/</ZoneTask.invokeTask@http://localhost:4201/polyfills.js:2812:24
invokeTask@http://localhost:4201/polyfills.js:3856:9
globalZoneAwareCallback@http://localhost:4201/polyfills.js:3882:17

@kylecordes What can I do?

In fact I need the compat only for your search-select. Otherwise I will give me:
ERROR in node_modules/@oasisdigital/angular-material-search-select/base.d.ts(3,10): error TS2305: Module '"/mnt/c910940f-f82f-47a8-8a73-b93a7a23a069/Projects/erp-frontend/node_modules/rxjs/Observable"' has no exported member 'Observable'.
node_modules/@oasisdigital/angular-material-search-select/types.d.ts(1,10): error TS2305: Module '"/mnt/c910940f-f82f-47a8-8a73-b93a7a23a069/Projects/erp-frontend/node_modules/rxjs/Observable"' has no exported member 'Observable'.
node_modules/rxjs/Observable.d.ts(1,15): error TS2307: Cannot find module 'rxjs-compat/Observable'.

Yes, I have seen the same thing with other libraries, it is a little frustrating to have to keep the compatibility layer around just because a library you are using needs it. And I have also seen (again, with other libraries) error similar to the one you reported. It makes me wonder if the rxjs-compat is fully worked out or if they need to tweak that a little bit more for complete compatibility.
Regardless though, I don't see any need to keep this library on the older Angular, so I have upgraded it to Angular 6.0.0. Version 0.13.0 of this library has the new dependencies, and appears to work. You can try it on the example site:
https://oasisdigital.github.io/angular-material-search-select/real
This is a Angular 6 application using @oasisdigital/angular-material-search-select 0.13.0.

Thanks! I will test it in my angular app. Indeed it's strange that even with compat package it had errors.
Note: I not only upgraded Angular, but also rxjs to version 6.2.

Yep looks fine for me.


Fix typo

Codecov Report

Merging #1205 into master will increase coverage by 0.44%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##           master    #1205      +/-   ##
==========================================
+ Coverage   80.83%   81.27%   +0.44%
==========================================
  Files          46       46
  Lines        7878     7877       -1
==========================================
+ Hits         6368     6402      +34
+ Misses       1510     1475      -35

Impacted Files
Coverage Δ

...h_transformers/tests/tokenization_tests_commons.py
100% <100%> (ø)
:arrow_up:

pytorch_transformers/tokenization_utils.py
89.37% <91.66%> (+8.89%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b52642...5c6cac1. Read the comment docs.

Thanks a lot for that!
Took the occasion to add regression tests and clean up a bit the base class.


Bugfix for May 7 showing May 0

Thanks @whackedspinach!
http://forum.beeminder.com/t/maniac-mornings-in-the-month-of-may/3160/16?u=dreev

lol, I just made this exact fix. Thanks anyway!


multiple numbers are overwritten for valuesOverPoints set to 1

Expected Behaviour
When we chart a stacked bar graph with valuesOverPoints set to 1, then the value shown on top should have the total.
Actual Behaviour
Looks like multiple numbers are overwritten on each other giving a very unreadable output.
Steps to Reproduce:
new Chart("#chart", {
  "data": {
    "labels": [
      "Planned",
      "Actual",
      "Profit"
    ],
    "datasets": [
      {
        "name": "Planned",
        "values": [
          1350,
          1350,
          0
        ],
        "chartType": "bar"
      },
      {
        "name": "Overrun",
        "values": [
          0,
          7499,
          0
        ],
        "chartType": "bar"
      },
      {
        "name": "Profit",
        "values": [
          0,
          0,
          14188
        ],
        "chartType": "bar"
      }
    ],
    "yMarkers": [
      {
        "label": "",
        "value": 1350,
        "options": {
          "labelPos":"center"
        }
      }
    ]
  },
  "type": "bar",
  "height": 250,
  "barOptions": {
    "stacked": true,
    "spaceRatio": 0.2
  },
  "valuesOverPoints": 1,
  "axisOptions": {
    "yAxisMode": "tick",
    "xAxisMode": "tick",
    "xIsSeries": 0
  },
  "colors": [
    "#2986cc",
    "#f1c232",
    "#2cb100"
  ]
});

NOTE: Add a GIF/Screenshot if required.
Frappé Charts version:
Codepen / Codesandbox:

Hello. I'd like to work on this issue. Please assign it to me.

Thank @Miki471151 . But I do not have access to assign issues.


WIP: Attempt to get compiled bytecode from V8

~Currently it segfaults~
Now it prints (when you run isolate_test.go:19):
a803dec03c1b6d4120
a803dec03c1b6d4148

Fixing with https://github.com/rogchap/v8go/pull/206


[Bug] concurrent increase by CounterWindow may break the PriporityQueue

Search before asking

[X] I had searched in the issues and found no similar issues.

Apache SkyWalking Component
OAP server (apache/skywalking)
What happened
I have a custom meter yaml:
filter: "{ tags -> tags['service'] != null && tags['instance'] != null && tags['resource'] != null  }"
expSuffix: instance(['service'],['instance'], Layer.GENERAL)
metricPrefix: sentinel
metricsRules:
  - name: sw8_receive_request_total_sum
    exp:  sw8_receive_request_total.sum(['service','instance','resource']).increase('PT1M')
  - name: sw8_pass_requests_total_sum
    exp: sw8_pass_requests_total.sum(['service','instance','resource']).increase('PT1M')

when I have many instance to report this meter, sometime get exception stack like blow:
2024-08-02 13:58:24,274 org.apache.skywalking.oap.meter.analyzer.dsl.Expression 89 [KafkaConsumer-1-thread-14] ERROR [] - [9.5.0-d47165d] failed to run "(sw8_receive_request_total.sum(['service','instance','resource']).increase('PT1M')).instance(['service'],['instance'], Layer.GENERAL)"
java.lang.NullPointerException: Cannot read field "_1" because "t2" is null
	at io.vavr.Tuple2.compareTo(Tuple2.java:90) ~[vavr-0.10.3.jar:?]
	at io.vavr.Tuple2.compareTo(Tuple2.java:111) ~[vavr-0.10.3.jar:?]
	at io.vavr.Tuple2.compareTo(Tuple2.java:43) ~[vavr-0.10.3.jar:?]
	at java.util.PriorityQueue.siftDownComparable(PriorityQueue.java:694) ~[?:?]
	at java.util.PriorityQueue.poll(PriorityQueue.java:583) ~[?:?]
	at org.apache.skywalking.oap.meter.analyzer.dsl.counter.CounterWindow.increase(CounterWindow.java:62) ~[classes/:?]
	at org.apache.skywalking.oap.meter.analyzer.dsl.Sample.increase(Sample.java:50) ~[classes/:?]
	at org.apache.skywalking.oap.meter.analyzer.dsl.SampleFamily.lambda$increase$16(SampleFamily.java:279) ~[classes/:?]
	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
	at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:992) ~[?:?]
	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
	at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575) ~[?:?]
	at java.util.stream.AbstractPipeline.evaluateToArrayNode(AbstractPipeline.java:260) ~[?:?]
	at java.util.stream.ReferencePipeline.toArray(ReferencePipeline.java:616) ~[?:?]
	at org.apache.skywalking.oap.meter.analyzer.dsl.SampleFamily.increase(SampleFamily.java:280) ~[classes/:?]
	at org.apache.skywalking.oap.meter.analyzer.dsl.SampleFamily$increase$0.call(Unknown Source) ~[?:?]
	at Script1.run(Script1.groovy:1) ~[?:?]
	at org.apache.skywalking.oap.meter.analyzer.dsl.Expression.run(Expression.java:78) ~[classes/:?]
	at org.apache.skywalking.oap.meter.analyzer.Analyzer.analyse(Analyzer.java:133) ~[classes/:?]
	at org.apache.skywalking.oap.meter.analyzer.MetricConvert.toMeter(MetricConvert.java:109) ~[classes/:?]
	at org.apache.skywalking.oap.server.analyzer.provider.meter.process.MeterProcessor.lambda$process$6(MeterProcessor.java:135) ~[classes/:?]
	at java.util.ArrayList.forEach(ArrayList.java:1511) ~[?:?]
	at org.apache.skywalking.oap.server.analyzer.provider.meter.process.MeterProcessor.process(MeterProcessor.java:135) ~[classes/:?]
	at org.apache.skywalking.oap.server.analyzer.agent.kafka.provider.handler.MeterServiceHandler.handle(MeterServiceHandler.java:85) ~[classes/:?]
	at org.apache.skywalking.oap.server.analyzer.agent.kafka.KafkaFetcherHandlerRegister.lambda$runTask$1(KafkaFetcherHandlerRegister.java:122) ~[classes/:?]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:539) [?:?]
	at java.util.concurrent.FutureTask.run$$$capture(FutureTask.java:264) [?:?]
	at java.util.concurrent.FutureTask.run(FutureTask.java) [?:?]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) [?:?]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
	at java.lang.Thread.run(Thread.java:840) [?:?]

as org.apache.skywalking.oap.meter.analyzer.dsl.counter.CounterWindow are single instance, the windows which type ConcurrentHashMap will return the same PriorityQueue object for the same meter, when the same meter increase with concurrent call, some unexcpected exception will occur in PriorityQueue object, source code:
public class CounterWindow {

    public static final CounterWindow INSTANCE = new CounterWindow();

    private final Map<ID, Tuple2<Long, Double>> lastElementMap = new ConcurrentHashMap<>();
    private final Map<ID, Queue<Tuple2<Long, Double>>> windows = new ConcurrentHashMap<>();

    public Tuple2<Long, Double> increase(String name, ImmutableMap<String, String> labels, Double value, long windowSize, long now) {
        ID id = new ID(name, labels);
        // there will return the same PriorityQueue object for concurrent operation
        Queue<Tuple2<Long, Double>> window = windows.computeIfAbsent(id, unused -> new PriorityQueue<>());
        window.offer(Tuple.of(now, value));  // some unexpected error will occur in this line when concurrent operation
        long waterLevel = now - windowSize;
        Tuple2<Long, Double> peek = window.peek();
        if (peek._1 > waterLevel) {
            return peek;
        }

        Tuple2<Long, Double> result = peek;
        while (peek._1 < waterLevel) {
            result = window.poll();  // some unexpected error will occur in this line when concurrent operation
            peek = window.element();  // some unexpected error will occur in this line when concurrent operation
        }

        // Choose the closed slot to the expected timestamp
        if (waterLevel - result._1 <= peek._1 - waterLevel) {
            return result;
        }

        return peek;
    }
    //....
}

What you expected to happen
for the same PriorityQueue, here a synchronization lock should be added to the window to ensure synchronization operations:
    public Tuple2<Long, Double> increase(String name, ImmutableMap<String, String> labels, Double value, long windowSize, long now) {
        ID id = new ID(name, labels);
        Queue<Tuple2<Long, Double>> window = windows.computeIfAbsent(id, unused -> new PriorityQueue<>());
        synchronized (window) { // use synchronized key word to lock window
            window.offer(Tuple.of(now, value));
            long waterLevel = now - windowSize;
            Tuple2<Long, Double> peek = window.peek();
            if (peek._1 > waterLevel) {
                return peek;
            }

            Tuple2<Long, Double> result = peek;
            while (peek._1 < waterLevel) {
                result = window.poll();
                peek = window.element();
            }

            // Choose the closed slot to the expected timestamp
            if (waterLevel - result._1 <= peek._1 - waterLevel) {
                return result;
            }

            return peek;
        }
    }

How to reproduce
Through a custom indicator configuration, it must contain an increase call, such as: sw8_receive_request_total.sum(['service','instance','resource']).increase('PT1M'),
then use debug breakpoints to wait for a certain amount of custom indicators to be reported. At this time, release the breakpoints and run them all to reappear with a high probability.
Anything else

In this way, you can see that some queues have been completely destroyed, size < 0, and this queue will permanently fail until the service is restarted.
Are you willing to submit a pull request to fix on your own?

[X] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

@kezhenxu94 Could you recheck?
@kael-aiur As you have addressed the issue, would you send a pull request to review?

@kezhenxu94 Could you recheck?
@kael-aiur As you have addressed the issue, would you send a pull request to review?

yeah, I will send a pull request later


feat: update to latest version

:tada: This PR is included in version 1.2.0 :tada:
The release is available on:

GitHub release
v1.2.0

Your semantic-release bot :package::rocket:


Checkbook QAQC Page

To Dos:
Categorization

[x] Overall visualization showing category assignments (# projects, check amounts)
[x] Visualizations showing category assignment vs check amounts, # projects (with a selector by agency)

Geometries

[x] Overall geometry assignment (# project, check amounts)
[ ] Visualizations showing geometries (has_geometry) vs check amounts, # projects (with a selector by agency)

Tagging @athursland

looks like there's a merge conflict with apps/qaqc/src/constants.py and two deleted files in .github/workflows/


[docs] Update VerticalLinearStepper.js

Fix buttons' creation.

[x] I have followed (at least) the PR section of the contributing guide.
Preview: https://deploy-preview-24486--material-ui.netlify.app/components/steppers/#vertical-stepper

Thanks for the work.
In order to merge this, the change needs to be applied to VerticalLinearStepper.tsx as well. After that you should run yarn docs:typescript:formatted, yarn prettier and commit and push the changes.

Done!

Thanks for the work.
In order to merge this, the change needs to be applied to VerticalLinearStepper.tsx as well. After that you should run yarn docs:typescript:formatted, yarn prettier and commit and push the changes.

Done!

@artola Please rebase on the next branch, v4 (master) is no longer in development.

@artola Please rebase on the next branch, v4 (master) is no longer in development.


Add ModifyByteOffset transform

It was helpful to create the USB_OTG register block which has 4 different register blocks merged into one with various offsets.

Thank you!


orphaned typo

fixed typo oprhaned > orphaned

@samgovier Thank you very much for the correction and your contribution to the project!


Comment incorrectly reports no change

Thanks for publishing this action. Unfortunately, it doesn't seem to be working for me, I generated 2 stats files from different commits, but the comment on the PR says there is no change. Here is a partial diff between the two stat files:
-    "label": "main.ef4c6927.js",
+    "label": "main.1baa3a0e.js",
     "isAsset": true,
-    "statSize": 9680463.559999999,
-    "parsedSize": 3571859,
-    "gzipSize": 1026459,
+    "statSize": 9813627.559999999,
+    "parsedSize": 3610758,
+    "gzipSize": 1039000,

You can see the new main bundle is ~39k larger. Any idea what I might be doing wrong? I've included my full workflow below.
jobs:
  main-bundle-stats:
    name: Calculate main bundle stats
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
        with:
          ref: e2e1a19e6f4c5e43d2ed84167317c679099093c1 # only for testing purposes
        # with:
        # ref: ${{ github.base_ref }}
      - uses: actions/setup-node@v3
        with:
          node-version: 18
          cache: "yarn"
      - run: yarn install --frozen-lockfile
      - run: yarn build:analyze:json
      - name: Upload main-bundle-stats.json
        uses: actions/upload-artifact@v3
        with:
          name: main-bundle-stats.json
          path: ./dist/report.json

  head-bundle-stats:
    name: Calculate head bundle stats
    runs-on: ubuntu-latest
    steps:
      - uses: actions/checkout@v3
      - uses: actions/setup-node@v3
        with:
          node-version: 18
          cache: "yarn"
      - run: yarn install --frozen-lockfile
      - run: yarn build:analyze:json
      - name: Upload main-bundle-stats.json
        uses: actions/upload-artifact@v3
        with:
          name: head-bundle-stats.json
          path: ./dist/report.json

  report-bundle-size:
    name: Report bundle size difference
    runs-on: ubuntu-latest
    needs: [main-bundle-stats, head-bundle-stats]
    permissions:
      pull-requests: write
    steps:
      - uses: actions/download-artifact@v3
      - uses: github/webpack-bundlesize-compare-action@v1
        with:
          github-token: ${{ secrets.GITHUB_TOKEN }}
          current-stats-json-path: ./head-bundle-stats.json
          base-stats-json-path: ./main-bundle-stats.json

Same for me.


GPLv3 to MIT

Closes #75.
I think we have to add the CLA bot.

@tani Please squash the commits into one commit in this PR.

@pddg Okay, I will do it.

As this repository is protected, we could not overwrite history when we merge it once. So, next time I follow it.


Change types in PyContext to be PyClassRef's than PyObjectRef's

This is first, in a series of PR's to remove unnecessary usages of PyObjectRef and replace them with more specific/appropriate ref type.
Majority of the changes in this PR are actually removing the reference in front of the type in context.set_attr calls. In all cases, the type is already borrowed, so there was no need to borrow it again. But it caused problems when I made set_attr be generic.

Yes, the majority of them will.

Codecov Report

Merging #721 into master will decrease coverage by 1.22%.
The diff coverage is 71.84%.

@@            Coverage Diff            @@
##           master    #721      +/-   ##
=========================================
- Coverage   48.43%   47.2%   -1.23%
=========================================
  Files          81      81
  Lines       15625   15963     +338
  Branches     3846    3906      +60
=========================================
- Hits         7568    7536      -32
- Misses       6254    6619     +365
- Partials     1803    1808       +5

Impacted Files
Coverage Δ

vm/src/macros.rs
22.22% <ø> (ø)
:arrow_up:

wasm/lib/src/convert.rs
0% <ø> (ø)
:arrow_up:

vm/src/obj/objcode.rs
53.73% <100%> (ø)
:arrow_up:

vm/src/obj/objframe.rs
50% <100%> (ø)
:arrow_up:

vm/src/obj/objellipsis.rs
66.66% <100%> (ø)
:arrow_up:

vm/src/obj/objtuple.rs
40.37% <100%> (ø)
:arrow_up:

vm/src/obj/objsuper.rs
40.65% <100%> (ø)
:arrow_up:

vm/src/obj/objcomplex.rs
44.96% <100%> (-31.14%)
:arrow_down:

vm/src/obj/objbytearray.rs
49.45% <100%> (-24.18%)
:arrow_down:

vm/src/obj/objbool.rs
67.21% <100%> (ø)
:arrow_up:

... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc3aa0...4b4e02e. Read the comment docs.


Is Resource a reserved Name ?

Hello,
I created a Resource model on my app. Everything seemed to work fine for a while, but a few hours ago, I updated my model (no big deal, just added a text field on it).
But now, everytime I get the following error:
undefined method `invite_key_fields' for #<Class:0x0056293b5d6bb8>

on this line :
<% resource.class.invite_key_fields.each do |field| -%>

and the matching resource is the following:
#<Resource id: nil, created_at: nil, updated_at: nil, file_file_name: nil, file_content_type: nil, file_file_size: nil, file_updated_at: nil, brief_id: nil, uploader_id: nil>

How comes so ? Is there a conflict between Devise Resource and mine ?

Not reserved on devise invitable, but devise invitable is only a devise extension. You should ask to devise, probably they will know better if there is an issue with naming a model as Resource.


GPU, NData > 1 boa bug fix

fix GPU, NData > 1 bug with boa:

was initializing GBuf in cycle 199 before getting CtxtGe into PTp layers.
moved PlusPhase:End to Trial.OnEnd, don't init GBuf in layer DecayState (done in NewState anyway),
move NetViewCounters to proper place given plus phase move, and add TrialStats logic so stats are right
add test for GBuf index calculations (were all good -- not cause of bug)

I'm going to go ahead and merge so it is avail.  definitely working..


Support package collections

A collection of all Saga readers and renderers.
https://swift.org/blog/package-collections/

Hooray for the Swift Package Index!
https://swiftpackageindex.com/loopwerk/collection.json


Implement schema inheritance

Pull Request Test Coverage Report for Build<PHONE_NUMBER>
Details

140 of 153 (91.5%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.08%) to 96.822%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

src/Validators/ValidatorSchema.php
8
10
80.0%

src/Schema.php
26
30
86.67%

src/SchemaDataPrep.php
86
93
92.47%

Totals

Change from base Build<PHONE_NUMBER>:
-0.08%

Covered Lines:
3016

Relevant Lines:
3115

💛  - Coveralls


Root not found in tree error hangs the node (Sepolia long run)

This is something that could happen along the node executions but is easily reproducible on the initial setup. After the initial sync and some time running (a couple of minutes) an initial pruning kicks in and for some reason it generates a slot in the future error, here is an example log:
INFO 17:43:12.001 [StateDb] Pruning started. slot=5963552
INFO 17:43:12.001 [BlobDb] Pruning started. slot=5832480
INFO 17:43:12.001 [BlockDb] Pruning started. slot=5963552
INFO 17:43:12.001 [BlobDb] Pruning finished. 0 blobs removed.
INFO 17:43:12.003 [Libp2p] Slot transition slot=5963616
INFO 17:43:12.009 [BlockDb] Pruning finished. 52 blocks removed.
INFO 17:43:12.019 [StateDb] Pruning finished. 52 states removed.
INFO 17:43:12.684 [Gossip] Block received, block.slot: 5963616.
INFO 17:43:24.002 [Libp2p] Slot transition slot=5963617
INFO 17:43:24.216 [Gossip] Block received, block.slot: 5963617.
INFO 17:43:29.977 [Fork choice] Adding new block slot=5963613 root=0x3de..fc05
INFO 17:43:30.204 [Fork choice] Block processed. Recomputing head.
ERROR 17:43:30.204 GenServer LambdaEthereumConsensus.Libp2pPort terminating
** (RuntimeError) Parent 14C35B27D611342466C990ABE85147AFCDA13DBE2D5C05C4B3155309CF94FFFD not found in tree
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/simple_tree.ex:84: LambdaEthereumConsensus.ForkChoice.Simple.Tree.get_children!/2
    (lambda_ethereum_consensus 0.1.0) lib/types/store.ex:147: Types.Store.get_children/2
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:90: LambdaEthereumConsensus.ForkChoice.Head.filter_block_tree/4
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:85: LambdaEthereumConsensus.ForkChoice.Head.get_filtered_block_tree/1
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:14: LambdaEthereumConsensus.ForkChoice.Head.get_head/1
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/fork_choice.ex:269: LambdaEthereumConsensus.ForkChoice.recompute_head/1
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/fork_choice.ex:62: anonymous fn/1 in LambdaEthereumConsensus.ForkChoice.on_block/2
    (telemetry 1.3.0) /home/admin/lambda_ethereum_consensus/deps/telemetry/src/telemetry.erl:324: :telemetry.span/3
Last message: {#Port<0.16>, {:data, <<50, 145, 166, 1, 10, 36, 55, 100, 49, 52, 49, 57, 53, 49, 45, 97, 100, 56, 50, 45, 52, 50, 101, 102, 45, 97, 102, 102, 101, 45, 48, 57, 102, 54, 50, 55, 101, 97, 57, 56, 102, 101, 16, 1, 26, 229, ...>>}}
INFO 17:43:30.227 [Optimistic Sync] Waiting 10.0 seconds to discover some peers before requesting blocks.
INFO 17:43:30.227 [Fork choice] Adding new block slot=5963613 root=0x3de..fc05
ERROR 17:43:30.280 [Fork choice] Failed to add block: block is from the future slot=5963613 root=0x3de..fc05
ERROR 17:43:30.280 [PendingBlocks] Saving block as invalid block is from the future slot=5963613 root=0x3de..fc05
INFO 17:43:36.001 [Libp2p] Slot transition slot=5963618
INFO 17:43:40.228 [Optimistic sync] Performing optimistic sync between slots 5963489 and 5963618, for a total of 130 slots.

This happens to kick in sync again and and may trigger #1308 issue.

This was not related to pruning as I originally thought. Here is a particular example where pruning wasn't involved. Something to be mindful about is that the error was pointing to a block that we added at the start of the following log, and that was correctly processed and not reorged in Sepolia (https://sepolia.etherscan.io/block/6790864#consensusinfo)
INFO 21:08:40.621 [Fork choice] Adding new block slot=6000639 root=0xb3a..dbe9
INFO 21:08:40.775 [Fork choice] Block processed. Recomputing head.
INFO 21:08:40.785 [Fork choice] Added new block slot=6000639 root=0xb3a..dbe9
INFO 21:08:40.786 [Fork choice] Adding new block slot=6000640 root=0xcae..a8f3
INFO 21:08:41.061 [Fork choice] Block processed. Recomputing head.
INFO 21:08:41.067 [Fork choice] Added new block slot=6000640 root=0xcae..a8f3
INFO 21:08:41.069 [Fork choice] Adding new block slot=6000641 root=0xe4e..0178
INFO 21:08:41.070 [Block processing] Computing committees for epoch 187520
INFO 21:08:41.264 [Fork choice] Block processed. Recomputing head.
INFO 21:08:41.270 [Fork choice] Added new block slot=6000641 root=0xe4e..0178
INFO 21:08:41.270 [Fork choice] Adding new block slot=6000642 root=0x179..fdb5
INFO 21:08:41.430 [Fork choice] Block processed. Recomputing head.
INFO 21:08:41.434 [Fork choice] Added new block slot=6000642 root=0x179..fdb5
INFO 21:08:41.434 [Fork choice] Adding new block slot=6000643 root=0xc1b..dc98
INFO 21:08:41.598 [Fork choice] Block processed. Recomputing head.
INFO 21:08:41.604 [Fork choice] Added new block slot=6000643 root=0xc1b..dc98
INFO 21:08:48.004 [Libp2p] Slot transition slot=6000644
INFO 21:08:48.255 [Gossip] Block received, block.slot: 6000644.
INFO 21:08:49.319 [Fork choice] Adding new block slot=6000644 root=0x4b3..ace3
INFO 21:08:49.521 [Fork choice] Block processed. Recomputing head.
INFO 21:08:49.526 [Fork choice] Added new block slot=6000644 root=0x4b3..ace3
INFO 21:08:49.899 [Fork choice] Adding new block slot=6000644 root=0x4b3..ace3
INFO 21:08:50.097 [Fork choice] Block processed. Recomputing head.
INFO 21:08:50.103 [Fork choice] Added new block slot=6000644 root=0x4b3..ace3
INFO 21:09:00.016 [Libp2p] Slot transition slot=6000645
INFO 21:09:00.111 [Gossip] Block received, block.slot: 6000645.
INFO 21:09:00.160 [Fork choice] Adding new block slot=6000645 root=0xba5..6f18
INFO 21:09:00.348 [Fork choice] Block processed. Recomputing head.
INFO 21:09:00.353 [Fork choice] Added new block slot=6000645 root=0xba5..6f18
INFO 21:09:01.156 [Fork choice] Adding new block slot=6000645 root=0xba5..6f18
INFO 21:09:01.332 [Fork choice] Block processed. Recomputing head.
INFO 21:09:01.338 [Fork choice] Added new block slot=6000645 root=0xba5..6f18
INFO 21:09:12.003 [Libp2p] Slot transition slot=6000646
INFO 21:09:12.131 [Gossip] Block received, block.slot: 6000646.
INFO 21:09:12.612 [Fork choice] Adding new block slot=6000646 root=0xb72..2380
INFO 21:09:12.801 [Fork choice] Block processed. Recomputing head.
INFO 21:09:12.819 [Fork choice] Added new block slot=6000646 root=0xb72..2380
INFO 21:09:24.003 [Libp2p] Slot transition slot=6000647
INFO 21:09:24.374 [Gossip] Block received, block.slot: 6000647.
INFO 21:09:24.390 [Fork choice] Adding new block slot=6000647 root=0x495..2721
INFO 21:09:24.577 [Fork choice] Block processed. Recomputing head.
INFO 21:09:24.594 [Fork choice] Added new block slot=6000647 root=0x495..2721
INFO 21:09:25.237 [Fork choice] Adding new block slot=6000646 root=0xb72..2380
INFO 21:09:25.420 [Fork choice] Block processed. Recomputing head.
INFO 21:09:25.423 [Fork choice] Added new block slot=6000646 root=0xb72..2380
WARNING 21:09:35.963 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000648. Current slot: 6000647.".
INFO 21:09:36.002 [Libp2p] Slot transition slot=6000648
WARNING 21:09:47.966 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000649. Current slot: 6000648.".
INFO 21:09:48.003 [Libp2p] Slot transition slot=6000649
INFO 21:10:00.011 [Libp2p] Slot transition slot=6000650
INFO 21:10:00.142 [Gossip] Block received, block.slot: 6000650.
INFO 21:10:02.794 [Fork choice] Adding new block slot=6000648 root=0xcbd..5ec0
INFO 21:10:02.965 [Fork choice] Block processed. Recomputing head.
INFO 21:10:02.971 [Fork choice] Added new block slot=6000648 root=0xcbd..5ec0
INFO 21:10:02.971 [Fork choice] Adding new block slot=6000649 root=0x353..3b52
INFO 21:10:03.129 [Fork choice] Block processed. Recomputing head.
INFO 21:10:03.135 [Fork choice] Added new block slot=6000649 root=0x353..3b52
INFO 21:10:03.135 [Fork choice] Adding new block slot=6000650 root=0x7ec..d29f
INFO 21:10:03.293 [Fork choice] Block processed. Recomputing head.
INFO 21:10:03.298 [Fork choice] Added new block slot=6000650 root=0x7ec..d29f
INFO 21:10:08.735 [Fork choice] Adding new block slot=6000650 root=0x7ec..d29f
INFO 21:10:08.924 [Fork choice] Block processed. Recomputing head.
INFO 21:10:08.936 [Fork choice] Added new block slot=6000650 root=0x7ec..d29f
INFO 21:10:12.004 [Libp2p] Slot transition slot=6000651
INFO 21:10:12.209 [Gossip] Block received, block.slot: 6000651.
INFO 21:10:12.308 [Fork choice] Adding new block slot=6000651 root=0x696..062b
INFO 21:10:12.496 [Fork choice] Block processed. Recomputing head.
INFO 21:10:12.502 [Fork choice] Added new block slot=6000651 root=0x696..062b
INFO 21:10:19.133 [Fork choice] Adding new block slot=6000651 root=0x696..062b
INFO 21:10:19.324 [Fork choice] Block processed. Recomputing head.
INFO 21:10:19.331 [Fork choice] Added new block slot=6000651 root=0x696..062b
INFO 21:10:24.005 [Libp2p] Slot transition slot=6000652
INFO 21:10:24.010 [Gossip] Block received, block.slot: 6000652.
INFO 21:10:24.170 [Fork choice] Adding new block slot=6000652 root=0xd45..eb8d
INFO 21:10:24.360 [Fork choice] Block processed. Recomputing head.
INFO 21:10:24.366 [Fork choice] Added new block slot=6000652 root=0xd45..eb8d
INFO 21:10:36.003 [Libp2p] Slot transition slot=6000653
INFO 21:10:36.116 [Gossip] Block received, block.slot: 6000653.
INFO 21:10:36.122 [Fork choice] Adding new block slot=6000653 root=0x16d..b05a
INFO 21:10:36.293 [Fork choice] Block processed. Recomputing head.
INFO 21:10:36.296 [Fork choice] Added new block slot=6000653 root=0x16d..b05a
INFO 21:10:37.443 [Fork choice] Adding new block slot=6000653 root=0x16d..b05a
INFO 21:10:37.635 [Fork choice] Block processed. Recomputing head.
INFO 21:10:37.640 [Fork choice] Added new block slot=6000653 root=0x16d..b05a
INFO 21:10:41.623 [Fork choice] Adding new block slot=6000652 root=0xd45..eb8d
INFO 21:10:41.824 [Fork choice] Block processed. Recomputing head.
INFO 21:10:41.830 [Fork choice] Added new block slot=6000652 root=0xd45..eb8d
INFO 21:10:48.005 [Libp2p] Slot transition slot=6000654
INFO 21:10:49.146 [Gossip] Block received, block.slot: 6000654.
INFO 21:10:49.153 [Fork choice] Adding new block slot=6000654 root=0xa0d..f5b5
INFO 21:10:49.350 [Fork choice] Block processed. Recomputing head.
INFO 21:10:49.357 [Fork choice] Added new block slot=6000654 root=0xa0d..f5b5
INFO 21:11:00.018 [Libp2p] Slot transition slot=6000655
INFO 21:11:00.097 [Gossip] Block received, block.slot: 6000655.
INFO 21:11:01.462 [Fork choice] Adding new block slot=6000655 root=0x04a..81c5
INFO 21:11:01.661 [Fork choice] Block processed. Recomputing head.
INFO 21:11:01.668 [Fork choice] Added new block slot=6000655 root=0x04a..81c5
WARNING 21:11:11.831 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000656. Current slot: 6000655.".
INFO 21:11:12.004 [Libp2p] Slot transition slot=6000656
INFO 21:11:24.004 [Libp2p] Slot transition slot=6000657
INFO 21:11:24.389 [Gossip] Block received, block.slot: 6000657.
INFO 21:11:24.841 [Fork choice] Adding new block slot=6000655 root=0x04a..81c5
INFO 21:11:25.036 [Fork choice] Block processed. Recomputing head.
INFO 21:11:25.040 [Fork choice] Added new block slot=6000655 root=0x04a..81c5
WARNING 21:11:35.773 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000658. Current slot: 6000657.".
INFO 21:11:36.003 [Libp2p] Slot transition slot=6000658
INFO 21:11:48.004 [Libp2p] Slot transition slot=6000659
INFO 21:11:50.920 [Fork choice] Adding new block slot=6000656 root=0xa2a..bd04
INFO 21:11:51.105 [Fork choice] Block processed. Recomputing head.
INFO 21:11:51.117 [Fork choice] Added new block slot=6000656 root=0xa2a..bd04
INFO 21:11:51.117 [Fork choice] Adding new block slot=6000657 root=0x779..b77d
INFO 21:11:51.286 [Fork choice] Block processed. Recomputing head.
INFO 21:11:51.288 [Fork choice] Added new block slot=6000657 root=0x779..b77d
INFO 21:12:00.015 [Libp2p] Slot transition slot=6000660
INFO 21:12:01.867 [Gossip] Block received, block.slot: 6000660.
WARNING 21:12:11.999 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000661. Current slot: 6000660.".
INFO 21:12:12.004 [Libp2p] Slot transition slot=6000661
INFO 21:12:17.403 [Fork choice] Adding new block slot=6000658 root=0x68d..ab72
INFO 21:12:17.599 [Fork choice] Block processed. Recomputing head.
INFO 21:12:17.602 [Fork choice] Added new block slot=6000658 root=0x68d..ab72
INFO 21:12:17.602 [Fork choice] Adding new block slot=6000659 root=0x369..52ab
INFO 21:12:17.690 [Fork choice] Block processed. Recomputing head.
INFO 21:12:17.694 [Fork choice] Added new block slot=6000659 root=0x369..52ab
INFO 21:12:17.694 [Fork choice] Adding new block slot=6000660 root=0x9e8..c9e0
INFO 21:12:17.858 [Fork choice] Block processed. Recomputing head.
INFO 21:12:17.860 [Fork choice] Added new block slot=6000660 root=0x9e8..c9e0
INFO 21:12:24.005 [Libp2p] Slot transition slot=6000662
INFO 21:12:24.311 [Gossip] Block received, block.slot: 6000662.
INFO 21:12:26.048 [Fork choice] Adding new block slot=6000661 root=0xeb9..7354
INFO 21:12:26.241 [Fork choice] Block processed. Recomputing head.
INFO 21:12:26.252 [Fork choice] Added new block slot=6000661 root=0xeb9..7354
INFO 21:12:26.252 [Fork choice] Adding new block slot=6000662 root=0xf6e..e9c4
INFO 21:12:26.406 [Fork choice] Block processed. Recomputing head.
INFO 21:12:26.412 [Fork choice] Added new block slot=6000662 root=0xf6e..e9c4
INFO 21:12:29.863 [Fork choice] Adding new block slot=6000662 root=0xf6e..e9c4
INFO 21:12:30.044 [Fork choice] Block processed. Recomputing head.
INFO 21:12:30.052 [Fork choice] Added new block slot=6000662 root=0xf6e..e9c4
WARNING 21:12:35.826 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000663. Current slot: 6000662.".
INFO 21:12:36.005 [Libp2p] Slot transition slot=6000663
INFO 21:12:48.005 [Libp2p] Slot transition slot=6000664
WARNING 21:12:59.967 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000665. Current slot: 6000664.".
INFO 21:13:00.007 [Libp2p] Slot transition slot=6000665
INFO 21:13:12.003 [Libp2p] Slot transition slot=6000666
INFO 21:13:12.626 [Gossip] Block received, block.slot: 6000666.
INFO 21:13:24.005 [Libp2p] Slot transition slot=6000667
INFO 21:13:25.009 [Gossip] Block received, block.slot: 6000667.
INFO 21:13:25.421 [Fork choice] Adding new block slot=6000663 root=0x8ce..7ff7
INFO 21:13:25.617 [Fork choice] Block processed. Recomputing head.
INFO 21:13:25.624 [Fork choice] Added new block slot=6000663 root=0x8ce..7ff7
INFO 21:13:25.625 [Fork choice] Adding new block slot=6000665 root=0xfcf..644e
INFO 21:13:25.739 [Fork choice] Block processed. Recomputing head.
INFO 21:13:25.742 [Fork choice] Added new block slot=6000665 root=0xfcf..644e
INFO 21:13:25.743 [Fork choice] Adding new block slot=6000666 root=0xdd8..6738
INFO 21:13:25.912 [Fork choice] Block processed. Recomputing head.
INFO 21:13:25.926 [Fork choice] Added new block slot=6000666 root=0xdd8..6738
INFO 21:13:25.927 [Fork choice] Adding new block slot=6000667 root=0xde3..990c
INFO 21:13:26.080 [Fork choice] Block processed. Recomputing head.
INFO 21:13:26.086 [Fork choice] Added new block slot=6000667 root=0xde3..990c
INFO 21:13:31.392 [Fork choice] Adding new block slot=6000667 root=0xde3..990c
INFO 21:13:31.590 [Fork choice] Block processed. Recomputing head.
INFO 21:13:31.601 [Fork choice] Added new block slot=6000667 root=0xde3..990c
WARNING 21:13:35.832 [Gossip] Block ignored, reason: "Block is from the future: block.slot=6000668. Current slot: 6000667.".
INFO 21:13:36.003 [Libp2p] Slot transition slot=6000668
INFO 21:13:48.005 [Libp2p] Slot transition slot=6000669
INFO 21:13:48.774 [Gossip] Block received, block.slot: 6000669.
INFO 21:14:00.015 [Libp2p] Slot transition slot=6000670
INFO 21:14:00.061 [Gossip] Block received, block.slot: 6000670.
INFO 21:14:02.431 [Fork choice] Adding new block slot=6000668 root=0xa51..14df
INFO 21:14:02.630 [Fork choice] Block processed. Recomputing head.
INFO 21:14:02.636 [Fork choice] Added new block slot=6000668 root=0xa51..14df
INFO 21:14:02.637 [Fork choice] Adding new block slot=6000669 root=0xfda..8fef
INFO 21:14:02.726 [Fork choice] Block processed. Recomputing head.
INFO 21:14:02.733 [Fork choice] Added new block slot=6000669 root=0xfda..8fef
INFO 21:14:02.733 [Fork choice] Adding new block slot=6000670 root=0xe60..aa6b
INFO 21:14:02.891 [Fork choice] Block processed. Recomputing head.
INFO 21:14:02.903 [Fork choice] Added new block slot=6000670 root=0xe60..aa6b
INFO 21:14:09.209 [Fork choice] Adding new block slot=6000670 root=0xe60..aa6b
INFO 21:14:09.396 [Fork choice] Block processed. Recomputing head.
INFO 21:14:09.403 [Fork choice] Added new block slot=6000670 root=0xe60..aa6b
INFO 21:14:12.008 [Libp2p] Slot transition slot=6000671
INFO 21:14:12.585 [Gossip] Block received, block.slot: 6000671.
INFO 21:14:12.596 [Fork choice] Adding new block slot=6000671 root=0x8c6..d57e
INFO 21:14:12.791 [Fork choice] Block processed. Recomputing head.
INFO 21:14:12.797 [Fork choice] Added new block slot=6000671 root=0x8c6..d57e
INFO 21:14:24.004 [Libp2p] Slot transition slot=6000672
INFO 21:14:27.545 [Gossip] Block received, block.slot: 6000672.
INFO 21:14:27.718 [Fork choice] Adding new block slot=6000672 root=0x611..070f
INFO 21:14:28.073 [Fork choice] Block processed. Recomputing head.
ERROR 21:14:28.076 GenServer LambdaEthereumConsensus.Libp2pPort terminating
** (RuntimeError) Parent CAE1F13DBD7FAF2177FDEE036E00B1D59319D380A9DC859478940CB1B0FCA8F3 not found in tree
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/simple_tree.ex:84: LambdaEthereumConsensus.ForkChoice.Simple.Tree.get_children!/2
    (lambda_ethereum_consensus 0.1.0) lib/types/store.ex:148: Types.Store.get_children/2
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:90: LambdaEthereumConsensus.ForkChoice.Head.filter_block_tree/4
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:85: LambdaEthereumConsensus.ForkChoice.Head.get_filtered_block_tree/1
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:14: LambdaEthereumConsensus.ForkChoice.Head.get_head/1
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/fork_choice.ex:272: LambdaEthereumConsensus.ForkChoice.recompute_head/1
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/fork_choice.ex:62: anonymous fn/1 in LambdaEthereumConsensus.ForkChoice.on_block/2
    (telemetry 1.3.0) /Users/roliveri/prog/elixir/consensus/lambda_ethereum_consensus/deps/telemetry/src/telemetry.erl:324: :telemetry.span/3
Last message: {#Port<0.19>, {:data, <<10, 152, 76, 10, 40, 47, 101, 116, 104, 50, 47, 100, 51, 49, 102, 54, 49, 57, 49, 47, 98, 108, 111, 98, 95, 115, 105, 100, 101, 99, 97, 114, 95, 49, 47, 115, 115, 122, 95, 115, 110, 97, 112, 112, 121, 26, ...>>}}
INFO 21:14:28.106 [Optimistic Sync] Waiting 10.0 seconds to discover some peers before requesting blocks.
INFO 21:14:28.107 [Fork choice] Adding new block slot=6000672 root=0x611..070f

In #1316 I was able to check that the store is in al old state and that cause the setting of the block as invalid:
INFO 16:00:48.604 [Fork choice] Adding new block slot=6013504 root=0xaa1..c455
INFO 16:00:48.802 [Fork choice] Block processed. Recomputing head.
ERROR 16:00:48.805 GenServer LambdaEthereumConsensus.Libp2pPort terminating
** (RuntimeError) Parent 8C7A76877C9CD8052DFF5995378515B9140DF11467672AEFFA7D0E3A1B9AE05B not found in tree
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/simple_tree.ex:84: LambdaEthereumConsensus.ForkChoice.Simple.Tree.get_children!/2
    (lambda_ethereum_consensus 0.1.0) lib/types/store.ex:144: Types.Store.get_children/2
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:90: LambdaEthereumConsensus.ForkChoice.Head.filter_block_tree/4
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:85: LambdaEthereumConsensus.ForkChoice.Head.get_filtered_block_tree/1
    (lambda_ethereum_consensus 0.1.0) lib/lambda_ethereum_consensus/fork_choice/head.ex:14: LambdaEthereumConsensus.ForkChoice.Head.get_head/1
    (lambda_ethereum_consensus 0.1.0) iex:296: LambdaEthereumConsensus.ForkChoice.recompute_head/1
    (lambda_ethereum_consensus 0.1.0) iex:62: anonymous fn/1 in LambdaEthereumConsensus.ForkChoice.on_block/2
    (telemetry 1.3.0) /Users/roliveri/prog/elixir/consensus/lambda_ethereum_consensus/deps/telemetry/src/telemetry.erl:324: :telemetry.span/3
Last message: {#Port<0.19>, {:data, <<10, 174, 186, 1, 10, 38, 47, 101, 116, 104, 50, 47, 100, 51, 49, 102, 54, 49, 57, 49, 47, 98, 101, 97, 99, 111, 110, 95, 98, 108, 111, 99, 107, 47, 115, 115, 122, 95, 115, 110, 97, 112, 112, 121, 26, 20, ...>>}}
INFO 16:00:48.828 [Optimistic Sync] Waiting 10.0 seconds to discover some peers before requesting blocks.
INFO 16:00:48.828 [Fork choice] Adding new block slot=6013504 root=0xaa1..c455
INFO 16:00:48.881 Store slot: 6013457 is in the past, slot: 6013504 is in the future. Current chain slot: 6013504
ERROR 16:00:48.881 [Fork choice] Failed to add block: block is from the future slot=6013504 root=0xaa1..c455
ERROR 16:00:48.882 [PendingBlocks] Saving block as invalid block is from the future slot=6013504 root=0xaa1..c455

Either way the root cause is the same, the tree manage in the Recomputing head

Resolved by #1318


I can only see 10 weapons for some skills

The current code grabs the "top 10" results from the DB, which is the first 10 weapons created with that skill. I would like to see a way to cycle through the weapons with that skill from the embed.

This can most likely be accomplished by either creating a new table to keep track of what position we're in for the embed like we did for weapons and nightmares, or reusing the current table. I personally recommend creating a new table.
Once this is set up, we can add reactions to the embed that will allow cycling through the weapons.


Write an informal survey/overview for the Kythe schema [phab:T133]

Created by fromberger at 2016-05-24 17:17:47:
The current schema document is primarily a reference manual for the naming conventions, facts, and edges defined by the Kythe graph. For authors of new indexers, it would be helpful to have an informal survey/orientation document for the schema. Some topics I think would be useful to gather together include:

Naming conventions (tickets and VNames, how to ensure uniqueness using examples like files, anchors, built-in types).
How Kythe maps a graph of nodes and edges to entry tuples (node = facts, edge = nodes + label).
A high-level tour of some of the common graph structures: File info, definition/usage cross-reference, call-graph, maybe a simple type structure.

It's an open question whether this should be part of the existing schema, or a separate document. The reference component of the schema should remain the source of truth, but an informal survey would I think help people figure out which pieces of the schema they need to care about—and why.

fromberger wrote at 2016-05-24 17:42:19:
Luke's blog posts from last year are probably a good source of input here, too: [[ http://www.kythe.io/2015/07/13/flow/ | Indexing JavaScript with Flow ]] and [[ http://www.kythe.io/2015/08/05/flow-2/ | Part 2]] of the same. Some of the info in those posts may be slightly stale, but I think the essentials are still true.


Number of pages loaded initially is 2X MAX_PAGE_LOAD_RANGE

Hi,
Number of pages loaded when I'm in 1st page is 2X MAX_PAGE_LOAD_RANGE. Which is quiet heavy.
Is there any way to configure MAX_PAGE_LOAD_RANGE. (Without changing source)
This is the current configurations that I'm using.
viewer = Crocodoc.createViewer('.viewer', {
    url: "./InTimeOktoober14/assets",
    layout: Crocodoc.LAYOUT_VERTICAL_SINGLE_COLUMN,
    enableTextSelection: true,
    enableDragging: false,
    useWindowAsViewport: true
});
viewer.on('pagefocus', function (event) {
    console.log(event.data.page);
});

// This is how I got to know number of pages loaded.
viewer.on('pageload', function (event) {
    console.log("loaded", event.data.page);
});
viewer.on('pageunload', function (event) {
    console.log("unloaded", event.data.page);
});
viewer.load();

Please suggest, thanks in advance.

There are two parts to this issue:

A possible bug: Number of pages loaded when in 1st page is 2X MAX_PAGE_LOAD_RANGE/MAX_PAGE_LOAD_RANGE_MOBILE.

Request for having MAX_PAGE_LOAD_RANGE and MAX_PAGE_LOAD_RANGE_MOBILE configurable.

having the same issue.

Same issue. Did we get anywhere on this. I'm using version 0.11.0 and still got the same problem.

I tried looking into the code, but could not find the root cause.
We just went ahead and divided our max load range by 2 :o

@vdclouis did you find a workaround then it sounds like?  yeah I really would like this to just only request a few pages in range around whats visible at a time. it blocks the ui in my case from responding until all the initial requests are completed. 😦

or did you just download the source and change the constant variable in the dist?


About Grad

Hello, I have recently been using L1loss(HR, SR), but I found that during sampling, each sampling step requires about 14GB of GPU memory  if I don't comment out with torch.no_grad. It results in an out-of-memory (OOM) error. If I only leave one sample for training, the results are very bad. How do you handle this situation?

Two ways to deal with it:
1.In training stage, just need one-step denoise by this formula:

The results will not be bad in the inference stage.
2.Decrease the denoise step from 1000 to 20 or less. Change other scheduler to complete this progress. In PASD,  UniPC scheduler could obtain good results within 20 steps.


flake: disable allow-import-from-derivation

Unfortunately this will print a confirmation when first using the flake:
do you want to allow configuration setting 'allow-import-from-derivation' to be set to 'false' (y/N)?

This is no different to the cachix configs though.

Looks like a number of tests rely on IFD.
If we can find a way to do them without IFD, I think we should.
I think some of the packages used by the update CI are being included in checks? We probably don't want that?

Yeah I agree we probably don't want that, we may need to move them to a different section than packages

What do you mean by "the first time using the flake" ? The first time running nix run with the nixvim flake as an input of your flake ?

The first time running any nix command with this flake checked out locally.
I don't think our flake's nixConfig is inherited by downstream flakes (haven't tested, could be wrong).

* `nocheckPackages` -> `noCheckPackages` ?

Sure, no strong opinion.

Just for the record, this PR doesn't currently do what it intends to. Passing the --allow-import-from-derivation flag to nix commands does not override the flake's nix config, so the update CI will not work if we merge this in its current state.

Maybe we can configure nix in GitHub CI to not allow the flake to set nixConfig?

Since #1980, we're now able to disable IFD in the flake. I've therefore rebased this and removed the outdated implementation.
Just need to fix/remove some of the new tests added by https://github.com/nix-community/nixvim/commit/299d0406bb339283969907d1f171f0eec7d84c43
Tests that need to read the content of files will have to be custom test derivations so that we can read the files during the build/check phase rather than importing the file into the eval.

@mergifyio queue


#350 | TX table improvements

Fixes #350
Description
This PR does 2 things:

prefetch transactions if you are on the wallet balance page
re-fetch transactions every 13 seconds if you are on the first page (does not refetch if on other pages to prevent data from randomly shifting around for the user)

Test scenarios

this PR needs to be tested locally because the testnet indexer isn't caught up yet, thus new transactions do not show
run git fetch --all && git checkout 350-tx-table-improvements
change .env to say NETWORK="mainnet"
run yarn dev
go to http://localhost:8081
click the Transactions tab

the transactions should already be loaded, no loading state

open http://localhost:8081/evm/send in a new window, place it side by side with the current window
send yourself some token

after a short delay, the new tx should be inserted into the table in the other window

Checklist:

[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have cleaned up the code in the areas my change touches
[x] My changes generate no new warnings
[x] I have checked my code and corrected any misspellings
[x] I have removed any unnecessary console messages
[x] I have tested for mobile functionality and responsiveness

JP, [Jul 2, 2023 at 7:19:06 PM]:
Telos Web Wallet
A Web Wallet for Telos
JP, [Jul 2, 2023 at 7:19:06 PM]:
app.31cebd94.js:1 Indexer API not working for this chain: telos-evm Error: Network Error
at e.exports (vendor.d0a3678c.js:113:10579)
at b.onerror (vendor.d0a3678c.js:113:6240)
(anonymous) @ app.31cebd94.js:1
content.js:69  while testing : https://deploy-preview-455--wallet-staging.netlify.app/evm/wallet?tab=transactions
sent myself a token it never updated
Also this error: inpage.js:8 MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 101 "disconnect" listeners added. Use emitter.setMaxListeners() to increase limit.

I'm getting a 500 error on both Desktop and Mobile (results in loading screen -> no transactions fetched): Uncaught (in promise) Error: antelope.history.error_fetching_transactions at Proxy.fetchEVMTransactionsForAccount (history.ts:129:1)

I take this one since EZ is on vacation from today.
I did push some code to handle that error, show a notification and stop iteration from continuing fetching.


RSS feed adds spurious extra folder

I was using this version.
$ hugo version
Hugo Static Site Generator v0.74.3 linux/386 BuildDate: 2020-07-23T20:37:33Z

Also tried this version on my laptop
$ hugo version
Hugo Static Site Generator v0.80.0-792EF0F4 linux/amd64 BuildDate: 2020-12-31T13:37:58Z`

My blog is at https://popey.com/blog with the source at https://github.com/popey/popey.com-blog
The static files are published on my server to /srv/popey.com/www/blog where /srv/popey/www is the web root.
The config.toml sets baseurl = "https://popey.com/blog/"
When a user visits an article on my site, images load correctly. Users who consume at my RSS feed, the image urls have an additional /blog added to the start of the url, thus breaking images in RSS feeds.
Here's a snippet from the RSS feed:

It takes an unsurprisingly long time to download a 1.6GiB ISO image over HSDPA+! I wasn’t sure it would complete in time before we boarded. Martin captured the stressful feeling while we sat at the gate.

However, 22 minutes later..

As a workaround I've added an redirect to my webserver config, in case anyone else sees this.
RedirectMatch 301 /blog/blog/(.*) https://popey.com/blog/$1

As a workaround I've added an redirect to my webserver config, in case anyone else sees this.
RedirectMatch 301 /blog/blog/(.*) https://popey.com/blog/$1


cargo-zigbuild: init at 0.12.0

Description of changes
Resolves #189443 @ghishadow
cargo-zigbuild is a tool to compile Cargo project with zig as linker
https://github.com/messense/cargo-zigbuild

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[x] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
22.11 Release Notes (or backporting 22.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 190165 run on x86_64-darwin 1

1 package built:

cargo-zigbuild


Touch UI set Field RichText

using the sling:resourceType="cq/gui/components/authoring/dialog/richtext  we aren't able to set the value
page.getParsys(parsys).getComponent(COMPONENT_NAME)
				.openDialog()
				.setField("Block 1", FieldType.RICHTEXT.name(), "test test test")
				.confirm();

below the error

Caused by: org.openqa.selenium.NoSuchElementException: no such element: Unable to locate element: {"method":"css selector","selector":".coral-RichText"}
(Session info: chrome=57.0.2987.98)
(Driver info: chromedriver=2.28.455520 (cc17746adff54984afff480136733114c6b3704b),platform=Windows NT 6.3.9600 x86_64) (WARNING: The server did not provide any stacktrace information)
Command duration or timeout: 15.01 seconds
For documentation on this error, please visit: http://seleniumhq.org/exceptions/no_such_element.html

Hi,
Unfortunately, the "cq/gui/components/authoring/dialog/richtext" is not supported by default. RichText in Bobcat is basing on "foundation/components/text". You can always extend this functionality by providing you own component description as descibed here: https://github.com/Cognifide/bobcat/wiki/Component-descriptions


SW-6302 Make it possible to have cells with any number of section text and variable values

text and variable values

#3433  👈 (View in Graphite)
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Add borgbackup v0.26.1

https://github.com/borgbackup/borg

this is outdated: the latest borg release is 0.28.1.

The latest official binary release is still 0.26.1

@rmoriz i asked the main dev for an update - @ThomasWaldmann: where are the binaries for 0.28.1?

@rmoriz in the meantime, there are binaries for 0.27...

Note for maintainers: This is on hold until upstream binaries for v0.28.1 are created and the Cask updated accordingly.
Alternatively, if @rmoriz wants to update the cask to v0.27, this PR can be merged (and a new one opened when binaries for the latest version become available)

0.28.2 was published with binaries.

Thank you for the contribution. It needed some fixes, so they were made in 47b865e7e4d8a2f5aedec2d9254788eb956196a5. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.

Given that Borg is an open-source command-line tool, why is it in Cask instead of Homebrew proper?

@raxod502 Please don't post comments on PRs that are over two years old.
If this can be added to homebrew/core submit a PR and it will be removed from cask.


Icons show up as black boxes in 3.1.2 but not 2.4.2 MaterialAboutActionItem Builder

When using .pngs as icons for the MaterialAboutActionItem Builder, they show as black boxes in version 3.1.2
cardBuilder.addItem(MaterialAboutActionItem.Builder()
                .text("Test")
                .icon(R.drawable.test)
                .build())

Although this works perfectly in 2.4.2 with the same code, the icons are rendered properly.
The style is a child of "Theme.MaterialComponents.Light.DarkActionBar".
Thanks for this great library, just a little confusing why the newest version doesn't show .png, which is the preferred Android format for drawables. https://developer.android.com/guide/topics/graphics/drawables

Hi! Thanks for the issue, unfortunately I'm not able to reproduce the issue you're facing myself. Are you able to provide some sample code?
Cheers


:sparkles: Kitabisa Login Page

Developer: @Aslam97
Description: Kitabisa Login Page
Design Source: https://kitabisa.com/login
Screenshoots

TODOS

[x] Add screenshot
[x] Add in src/index.html
[x] Change the author text and link

Please help to review

@all-contributors please add @Aslam97 for code


fix: type checks and tests

Description
This PR resolves []
PR Checklist

[ ] I tested my changes on iOS and Android.
[ ] I added screenshots or videos to illustrate my changes.
[ ] I added Tests and Stories for my changes.

To the reviewers 👀

[ ] I would like at least one of the reviewers to run this PR on the simulator or device.

Need help with something? Have a look at our docs, or get in touch with us.

Thanks @pvinis ! 🎉


feat: Add --draft flag for draft pull requests

Hey folks, thanks for the neat tool!
My team is interested in using the GitHub drafts feature so I've implemented a --draft flag here.
I played around with a few tests but I didn't find one that felt like it provided meaningful coverage. What we want I think is a test where we check that the PR submitted to client.PullRequests.Create has the has Draft: true, which would require some storage structure on the mock used in perhaps another test like TestProcessRepo. This did seem like a lot for a flag, so wanted to see what you thought before adding it. Open to any suggestions for testing approaches!
Also looks like my editor removed a couple extra spaces, please let me know if you'd like them reverted.
closes #47

Hey @brikis98 @zackproser! Any interest in the changes proposed here? Thanks!

Hi @ryanwholey,
Thanks so much for contributing to git-xargs and apologies for the delay in getting back to you.
First off, this looks like a great start and I do believe we'd be interested in this functionality. There are a couple of things we'd probably want to include before this is ready to merge, however:

Error handling for when draft pull requests are not supported. For example, I have a personal Github org that I use for testing. It is currently comprised of only private repos, which currently do not support draft PRs according to Github's docs - and, when testing this locally against my test org, if I pass the --draft flag and the --loglevel DEBUG flag, I can see HTTP 422 errors being returned as a result. We should probably handle this error specifically
In order for operators to be notified of any pull requests that could not be opened as drafts in the final run report, we'll need to wire up a new event type in stats/stats.go and add it to the slice of all events in that same file. This way, when someone attempts to open draft pull requests on a repo that does not support them, they'll get a detailed breakdown of exactly which repos had this issue, so it will be easier to troubleshoot.
The additional test coverage, as you suggested. This would be ideal to have in place before merging. However, if it's not something you have the interest or bandwidth to implement, we could do it on our end, but this may take a bit longer.

@zackproser all good, thank you for the direction! I'll dive in and update soon

Hi @zackproser, finally getting back around to this!
I've added handling for 422's under the event type RepoNotCompatibleWithPullConfig. Looks like the GitHub client doesn't export more specified errors here for something like draft incompatibility. Let me know if you think we need some more targeted copy shown to the user.
Regarding updating the testing framework here, I don't believe I'll have time to get to this any time soon. Please let me know if you'd like to see some other form of validation here with regard to these changes.

Hi @zackproser, finally getting back around to this!
I've added handling for 422's under the event type RepoNotCompatibleWithPullConfig. Looks like the GitHub client doesn't export more specified errors here for something like draft incompatibility. Let me know if you think we need some more targeted copy shown to the user.
Regarding updating the testing framework here, I don't believe I'll have time to get to this any time soon. Please let me know if you'd like to see some other form of validation here with regard to these changes.

Hi @ryanwholey,
Awesome - thanks again for implementing this! I was able to get draft PRs opened using your branch against my test org, so that's great.
I have a couple of nits and thoughts around how to best describe the draft PR activity in the final run report that gets rendered for operators.
I'm going to keep playing around with this and leave some feedback on your PR and possibly also push some commits there.

I opened https://github.com/gruntwork-io/git-xargs/issues/61 to track the implementation of additional test coverage for draft PRs.

Thanks for the review! Going to merge this in now, as tests also passed locally.


Add delayed_jobs_ready to DelayedJobs plugin and collect_by_queue option for GoodJob plugin

This PR was born out of metric gathering for our auto-scaling needs as we're migrating hosting platforms and mid-migration of queue libraries.
This PR adds a new metric to the DelayedJobs plugin - "delayed_jobs_ready". This can be thought of as all of the jobs whose run_at < now(). We needed this metric and not queued or pending since those included all of our jobs which could be days, weeks, or months out.
This PR also adds the ability to view GoodJob metrics sliced by queue, similar to the DelayedJobs plugin. It's fairly self-explanatory why scaling queue workers based off how many jobs are enqueued in a given queue may be beneficial.

One question, how would you handle that the number of jobs returned can decrease, because of clean up scripts? I am using the GoodJob part now, but since is a total count in the DB, the number is really unusable, when the clean up script is running next to it.

I'm not sure I fully understand the question/problem statement here - any clarification would be great :D
If you're asking about GoodJob's auto-clean up which deleted jobs after X amount of time (default 2 weeks) you can either disable the clean-up and leave the records in the db or implement some good_job on delete hook to increment some counter somewhere. Though, I'm not sure if that's within the scope of the prometheus_exporter gem, or my PR, so maybe I'm misunderstanding the question 😅


tcl, tk: 8.6.11 -> 8.6.13

Description of changes
Supersedes #163181.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

@ofborg eval

@ofborg eval

@ofborg build tcl tcl.passthru.tests tk tk.passthru.tests

Uh, stdenv rebuild?  🤞🏽

I think something went wrong with this update, see issues #232089 and #232148.
@vcunat Could you please revert it in staging-next?

Wait, I'm confused, there is an easy solution for the Python one: --set TK_LIBRARY ${tk}/lib/${tk.libPrefix}...

Just for what it's worth, I don't think that #232089 and #232148 are related. The dtdocbook/instant program in CDE seems to build and link properly, and it only really seems to fail due to some specific locale issue. It's perfectly able to link to Tcl 8.6 and the only reason I wind up overriding TCLLIB in #232148 is so I can get CDE to link to 8.5 instead to work around the issue. It's necessary because CDE hardcodes -ltcl8.6 (but does still support 8.5 in version 2.3.2 as far as I can tell, having looked through the mailing list.)
There may be some overarching problem with this update that lead to #232148, but my personal suspicion is that it's actually a dependency update in Tcl that broke some old deprecated locales (maybe ones that are not ISO/IEC 2022 compliant, or perhaps otherwise just too archaic to keep supporting.) But, that's just my hunch, and I haven't had time to properly root-cause it yet.
Just wanted to make this note here to hopefully prevent any unnecessary confusion.


Wrong products thumbnails in upsells

Hi !
I have an issue with the upsells products list on the single product page : the current product image is displayed for each upsell, instead of the upsell product image itself.
The upsell name & link are correct.
I tried to disable every piece of custom code i have but still got the same issue.
Any hints ?
Thanks

Did you already check out the newest release candidate for this integration? Because it might be that is already resolved with that. You should be able to get it with
composer require mindkomm/timber-integration-woocommerce:0.6.0-rc.1

Otherwise, I might have to investigate further. In that case, it would help if you could post some Twig code from your singular product page that I could use to replicate the problem.

Hi Lukas,
I'm already on the last release.
I rolled back to your default twig files and still got the issue.
Also rolled back to the very minimum in functions.php :
WooCommerce::init();
add_action( 'after_setup_theme', array($this, 'init_woocommerce') );

Also removed everything in my woocommerce.php :
$context = \Timber\Timber::get_context();
Timber\Integrations\WooCommerce\WooCommerce::render_default_template($context);

And still got the issue ☹
I just have several upsells associated to products 🤷♂

Hi,
I got the same issue and found a solution.
In line 249 from lib/WooCommerce.php :
`global $product, $post;
		if ( ! $product ) {
			$product = wc_setup_product_data( $post );
		}`

The product ID remains the same in single-product page but not the post ID.
I fixed it by adding a condition:
if ( ! $product || $product->get_id() != $post->ID) { 			$product = wc_setup_product_data( $post ); 		}
I'll do a pull request to fix the issue soon ;)

The problem is that some templates like up-sells.php set data using a good old setup_postdata :
<?php woocommerce_product_loop_start(); ?>

    <?php foreach ( $upsells as $upsell ) : ?>

        <?php
		 $post_object = get_post( $upsell->get_id() );

		 setup_postdata( $GLOBALS['post'] =& $post_object ); // phpcs:ignore WordPress.WP.GlobalVariablesOverride.Prohibited, Squiz.PHP.DisallowMultipleAssignments.Found

		 wc_get_template_part( 'content', 'product' );
	 ?>

    <?php endforeach; ?>

<?php woocommerce_product_loop_end(); ?>

Adding something like this will fix the issue:
setup_postdata( $GLOBALS['product'] = wc_setup_product_data( $post_object ) );

But i don't see (yet) how this can be done properly within your package.

Okay, thanks for your research. I will have to investigate further what the best solution for this would be.
In the meantime, does it work if you use a Twig file for the up-sells?
views/woocommerce/single-product/up-sells.twig
{% if wc.upsells  %}
	{{ fn('woocommerce_product_loop_start') }}

    {% for post in wc.upsells %}
        {{ include('woocommerce/content-product.twig', {
            product: post.product
        }) }}
    {% endfor %}

    {{ fn('woocommerce_product_loop_end') }}

	{# Not sure if this is needed as well, currently. #}
    {{ fn('wp_reset_postdata') }}
{% endif %}

It does !
Thanks for the workaround

Hey @tameroski
I looked at the problem more closely and I think I found a solution that should solve cases like this, when obviously the product global is not working correctly. I added it as a pre-release in 0.6.1-rc.1, because I want to test it out a bit more myself.
I’d be glad if you could check it out and see if that fixes the problem :).

Closing this, because the updates in 0.6.1 and 0.7.1 should fix this.


Log Anonymizer removes some fields from 38-lines

Description
When I use the log splitter with the 'anonymize' feature enabled, 38-lines have some fields removed.
Without 'anonymize log' (anonymized by hand):
38|2023-10-06T21:10:15.2640000-07:00|1234ABCD|Player Name|005A5A1E|90282|90282|10000|10000|11||100.88|108.01|0.00|-2.95|0|0|0|29640030|4484BB3A|1234ABCD|0A0168|41F00000|E0000000|14016A|41F00000|E0000000|01FB|C1A00000|1234ABCD|0763|41C71056|1001AAAA|0A31|41D65E2E|1002BBBB|278de10f0e5fbd59
With 'anonymize log':
38|2023-10-06T21:10:15.2640000-07:00|10FF0003|Dodoqosu Neneqosu|005A5A1E|90282|90282|10000|10000|11||100.88|108.01|0.00|-2.95|0|0|0|29640030|4484BB3A|||||||||||||||||
If it's more effort to fully parse the 38-line to anonymize it fully, then I think the next most reasonable thing would be to truncate it two fields earlier. As it stands, it has a partial triplet of "|29640030|4484BB3A||", where the source entity ID of the buff should be in the empty field. The fields of each triplet are |<params, usually stack count>|||. By chopping it two fields earlier, it would effectively just remove all status effect information from the line, but keep the other information (hp, shield, etc).
I'm not exactly sure what the netlog defs values mean, but I think it might just be a case of changing firstUnknownField from 20 to 18?

At the top of the file (let me know if this needs more explanation):
  // Fields at this index and beyond are cleared, when anonymizing.
  firstUnknownField?: number;

And yeah, I think that seems reasonable to move it to 18 if 19-21 can contain ids.


doc: improve p2p introduction

I'm making some conflicting (but bigger changes) in this branch: https://github.com/pokt-network/pocket-network-protocol/tree/p2p/v102, so have asked @derrandz  to hold off on submitting this for now.
Will close this out when the other PR is ready for review.


RETURN REMOVEINTERNAL requested

I hope the introduction of RETURN REMOVEINTERNAL in AQL:
FOR u IN users
  FILTER u.type == "newbie" && u.active == true
  RETURN REMOVEINTERNAL u

2nd argument of ATTRIBUTES() is removeInternal, set it to true to only return user attributes and combine it with KEEP():
FOR u IN users
...
RETURN KEEP(u, ATTRIBUTES(doc, True))

https://docs.arangodb.com/Aql/DocumentFunctions.html

Thank you for giving me your instruction:KEEP(u, ATTRIBUTES(u, True)) for realizing REMOVEINTERNAL doc.
And UNSET(u, ['_id', '_key', '_rev']) may work well, too.

Note that you'll need to add '_to', '_from' and in future possibly more attribute keys to your list if you wanna use UNSET().

@CoDEmanX :+1: