[Release-1.24] Bulk Backport of Testing Changes

Proposed Changes
Backport of the following PRs:

https://github.com/k3s-io/k3s/pull/6030

Convert nightly install testing to v1.24 channel

Types of Changes
Testing Backports

Verification
Github CI still passes

Testing

Linked Issues
N/A All backports are internal testing changes.

User-Facing Change

Further Comments

Codecov Report

Merging #6085 (dc88eb4) into release-1.24 (79bb7bc) will decrease coverage by 0.16%.
The diff coverage is n/a.

:exclamation: Current head dc88eb4 differs from pull request most recent head 14ef5c5. Consider uploading reports for the commit 14ef5c5 to get more accurate results

@@               Coverage Diff               @@
##           release-1.24   #6085      +/-   ##
===============================================
- Coverage          9.72%   9.55%   -0.17%
===============================================
  Files               138     138
  Lines             10060   10231     +171
===============================================
  Hits                978     978
- Misses             8883    9054     +171
  Partials            199     199

Flag
Coverage Δ

unittests
9.55% <ø> (-0.17%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/cli/agent/agent.go
0.00% <0.00%> (ø)

pkg/cli/server/server.go
0.00% <0.00%> (ø)

pkg/agent/config/config.go
0.00% <0.00%> (ø)

pkg/deploy/zz_generated_bindata.go
0.00% <0.00%> (ø)

pkg/static/zz_generated_bindata.go
0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Fetch prune not working

I tried to call fetch with prune, but it does not delete the branch that was deleted remotely.
The lib.rs enum is
https://github.com/rust-lang/git2-rs/blob/master/libgit2-sys/lib.rs#L393
And this is the one exposed:
https://github.com/rust-lang/git2-rs/blob/master/src/lib.rs#L1311
Is there anything missing? I'm new to Rust, so I couldn't find what is the problem.

Is this perhaps a bug with libgit2 itself? Or with the bindings?

Is this perhaps a bug with libgit2 itself? Or with the bindings?

@darakeon It seems to work for me.  Can you put together a sample reproduction, something like this:
use git2::*;
use std::fs;
use std::path::Path;

fn main() {
    // Create two branches in "otherrepo", and fetch them into "repo".
    let other_path = Path::new("otherrepo");
    if other_path.exists() {
        fs::remove_dir_all(other_path).unwrap();
    }
    let repo_path = Path::new("repo");
    if repo_path.exists() {
        fs::remove_dir_all(repo_path).unwrap();
    }
    let otherrepo = Repository::init(other_path).unwrap();
    add_file(&otherrepo, "foo");

    let head = otherrepo.head().unwrap().target().unwrap();
    let head = otherrepo.find_commit(head).unwrap();
    otherrepo.branch("somebranch", &head, true).unwrap();
    otherrepo.set_head("refs/heads/somebranch").unwrap();
    add_file(&otherrepo, "bar");

    let repo = Repository::init(repo_path).unwrap();

    let mut remote = repo.remote("otherrepo", "otherrepo").unwrap();
    remote.fetch(&[] as &[&str], None, None).unwrap();

    let otherbranch = repo
        .resolve_reference_from_short_name("otherrepo/somebranch")
        .unwrap();
    eprintln!("branch={:?}", otherbranch.peel_to_commit());

    // Remove "somebranch".
    otherrepo.set_head("refs/heads/master").unwrap();
    let mut somebranch = otherrepo
        .find_branch("somebranch", BranchType::Local)
        .unwrap();
    somebranch.delete().unwrap();

    // Fetch with prune.
    let mut fo = FetchOptions::new();
    fo.prune(FetchPrune::On);
    remote.fetch(&[] as &[&str], Some(&mut fo), None).unwrap();

    // Verify that the branch was pruned.
    assert!(repo
        .resolve_reference_from_short_name("otherrepo/somebranch")
        .is_err());
}

fn add_file(repo: &Repository, name: &str) {
    let mut index = repo.index().unwrap();
    fs::write(repo.workdir().unwrap().join(name), "test").unwrap();
    index.add_path(std::path::Path::new(name)).unwrap();
    index.write().unwrap();
    let id = index.write_tree().unwrap();
    let tree = repo.find_tree(id).unwrap();
    let sig = repo.signature().unwrap();
    let mut parents = Vec::new();
    if let Some(parent) = repo.head().ok().map(|h| h.target().unwrap()) {
        parents.push(repo.find_commit(parent).unwrap());
    }
    let parents = parents.iter().collect::<Vec<_>>();

    repo.commit(Some("HEAD"), &sig, &sig, "test", &tree, &parents)
        .unwrap();
}

@darakeon It seems to work for me.  Can you put together a sample reproduction, something like this:
use git2::*;
use std::fs;
use std::path::Path;

fn main() {
    // Create two branches in "otherrepo", and fetch them into "repo".
    let other_path = Path::new("otherrepo");
    if other_path.exists() {
        fs::remove_dir_all(other_path).unwrap();
    }
    let repo_path = Path::new("repo");
    if repo_path.exists() {
        fs::remove_dir_all(repo_path).unwrap();
    }
    let otherrepo = Repository::init(other_path).unwrap();
    add_file(&otherrepo, "foo");

    let head = otherrepo.head().unwrap().target().unwrap();
    let head = otherrepo.find_commit(head).unwrap();
    otherrepo.branch("somebranch", &head, true).unwrap();
    otherrepo.set_head("refs/heads/somebranch").unwrap();
    add_file(&otherrepo, "bar");

    let repo = Repository::init(repo_path).unwrap();

    let mut remote = repo.remote("otherrepo", "otherrepo").unwrap();
    remote.fetch(&[] as &[&str], None, None).unwrap();

    let otherbranch = repo
        .resolve_reference_from_short_name("otherrepo/somebranch")
        .unwrap();
    eprintln!("branch={:?}", otherbranch.peel_to_commit());

    // Remove "somebranch".
    otherrepo.set_head("refs/heads/master").unwrap();
    let mut somebranch = otherrepo
        .find_branch("somebranch", BranchType::Local)
        .unwrap();
    somebranch.delete().unwrap();

    // Fetch with prune.
    let mut fo = FetchOptions::new();
    fo.prune(FetchPrune::On);
    remote.fetch(&[] as &[&str], Some(&mut fo), None).unwrap();

    // Verify that the branch was pruned.
    assert!(repo
        .resolve_reference_from_short_name("otherrepo/somebranch")
        .is_err());
}

fn add_file(repo: &Repository, name: &str) {
    let mut index = repo.index().unwrap();
    fs::write(repo.workdir().unwrap().join(name), "test").unwrap();
    index.add_path(std::path::Path::new(name)).unwrap();
    index.write().unwrap();
    let id = index.write_tree().unwrap();
    let tree = repo.find_tree(id).unwrap();
    let sig = repo.signature().unwrap();
    let mut parents = Vec::new();
    if let Some(parent) = repo.head().ok().map(|h| h.target().unwrap()) {
        parents.push(repo.find_commit(parent).unwrap());
    }
    let parents = parents.iter().collect::<Vec<_>>();

    repo.commit(Some("HEAD"), &sig, &sig, "test", &tree, &parents)
        .unwrap();
}

My code is a little bit different at fetch
https://github.com/darakeon/dfm/blob/main/version/src/git.rs#L100
I'm passing the branch names and a reflog message. Could one of those things be a problem?

My code is a little bit different at fetch
https://github.com/darakeon/dfm/blob/main/version/src/git.rs#L100
I'm passing the branch names and a reflog message. Could one of those things be a problem?

It's hard to say without seeing a minimal reproduction.
This library just provides a thin wrapper around the libgit2 library.  I think it is unlikely that there is an issue with the bindings, considering the example above seems to work.  If something is not working correctly, I would suggest making a minimal C example and filing an issue on the libgit2 tracker, or trying one of their help options.

It's hard to say without seeing a minimal reproduction.
This library just provides a thin wrapper around the libgit2 library.  I think it is unlikely that there is an issue with the bindings, considering the example above seems to work.  If something is not working correctly, I would suggest making a minimal C example and filing an issue on the libgit2 tracker, or trying one of their help options.

Sorry for the delay, I'll test it as soon as I can

Sorry for the delay, I'll test it as soon as I can

Discovered the problem.
I was using this to fetch:
remote.fetch(
	&["main", branch_name],
	Some(&mut options),
	Some("updating local")
).unwrap();

But the correct was:
remote.fetch(
	&[] as &[&str],
	Some(&mut options),
	Some("updating local")
).unwrap();

Passing the branch name probably made my script update just the local branch I pointed (and main local).
Thanks, @ehuss !!! Closing!

Discovered the problem.
I was using this to fetch:
remote.fetch(
	&["main", branch_name],
	Some(&mut options),
	Some("updating local")
).unwrap();

But the correct was:
remote.fetch(
	&[] as &[&str],
	Some(&mut options),
	Some("updating local")
).unwrap();

Passing the branch name probably made my script update just the local branch I pointed (and main local).
Thanks, @ehuss !!! Closing!


chore(deps): Update netty from 4.1.78.Final to 4.1.92.Final

Bump netty version to 4.1.92.Final to match Spring Boot v2.7.12
Remediates CVE-2022-41881
Ref issue: #3512

The test failure looks unrelated to this change. We should fix that test first.

The test failure looks unrelated to this change. We should fix that test first.

@shakuzen Not quite sure what this is related to and how to fix. Looks like the CI is failing to execute the docker build?
#14 1.659 ERROR: unable to select packages:
[81](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:82)
#14 1.661   mysql-10.11.4-r0:
[82](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:83)
#14 1.661     breaks: world[mysql~10.11.3]
[83](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:84)
#14 1.662   mysql-client-10.11.4-r0:
[84](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:85)
#14 1.662     breaks: world[mysql-client~10.11.3]
[85](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:86)
#14 ERROR: executor failed running [/bin/sh -c (cd install && ./install.sh) && rm -rf ./install]: exit code: 2
[86](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:87)
------
[87](https://github.com/openzipkin/zipkin/actions/runs/5208222337/jobs/9396563943?pr=3548#step:15:88)
 > [zipkin-mysql 6/7] RUN (cd install && ./install.sh) && rm -rf ./install:

@jcchavezs @llinder @shakuzen Could you help with fixing this failing test?

Bumping again because of new CVE. Also bumped Spring to match.

Hi, @llinder @shakuzen Can this be merged? I do see tests was successful https://github.com/openzipkin/zipkin/actions/runs/5633888570

I will see if I can fix the python package issue in another PR and if successful we can merge this one.

pip cqlsh install issues resolved in this PR https://github.com/openzipkin/zipkin/pull/3554
Thanks for submitting the Netty fix @darkmastermindz!


fix link issue with href

All Submissions:

[x] Have you followed the guidelines stated in CONTRIBUTING.md file?
[x] Have you checked to ensure there aren't any other open Pull Requests for the desired changed?

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] This change requires a documentation update

Changes To Core Features:

[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[x] Have you written new tests for your core changes, as applicable?
[x] Have you successfully ran tests with your changes locally?

Description
Add logic on Link creation to ensure that a children and an href are always provided.
Close #1160

Testing with this code
"""Welcome to Pynecone! This file create a counter app."""
import pynecone as pc

class State(pc.State):
    pass

def index():
    """The main view."""
    return pc.link("Test", href="https://reactjs.org/docs/fragments.html")

# Add state and page to the app.
app = pc.App(state=State)
app.add_page(index, title="Counter")
app.compile()

Getting the error
TypeError: Invalid var passed for prop rel, expected type pynecone.vars.Var[str], got value None of type <class 'NoneType'>.

Testing with this code
"""Welcome to Pynecone! This file create a counter app."""
import pynecone as pc

class State(pc.State):
    pass

def index():
    """The main view."""
    return pc.link("Test", href="https://reactjs.org/docs/fragments.html")

# Add state and page to the app.
app = pc.App(state=State)
app.add_page(index, title="Counter")
app.compile()

Getting the error
TypeError: Invalid var passed for prop rel, expected type pynecone.vars.Var[str], got value None of type <class 'NoneType'>.

Okay some error got introduced when clearing up pyright/darglint stuff I think.
Should be fixed now.


Feature/athena-array-type-support

Adding parsing for the "arrary" db type.

Closing due to inactivity but feel free to re-open. I'd like more clarity around the types that can be inside arrays and how we handle that.


add subLanguage support to markdown

In addition to the subLanguage attribute, there are also a significant number of markdown tokens without a relevance value. Should that also be changed?

Changes
This adds subLanguage configurations to ``` and ~~~ in the markdown language config, allowing markdown files with a significant portion of content in code blocks to be recognized as markdown.

Checklist

[x] Added markup tests, or they don't apply here because... tests for markup are already covered
[ ] Updated the changelog at CHANGES.md

there are also a significant number of markdown tokens without a relevance value. Should that also be changed?

No, hand-tuned relevance is going to be deprecated in the future as it's of questionable value and impossible to get right for a large set of languages without a ton of research and infrastructure we do not have.

allowing markdown files with a significant portion of content in code blocks to be recognized as markdown.

Did something prevent them from being recognized as markdown previously?
I'm not sure what to do here as subLanguage: [] has serious performance implications and this change would make highlighting markdown files potentially MUCH slower.  Despite the TODO I also think this starts to get more into rendering of the markdown than highlighting it (though I know some disagree).  I might potentially come around on that if it weren't for the performance implications as well.
I'm wondering if this wouldn't make a very short plugin that people could simply opt-into if they wanted this behavior.
@allejo Any thoughts?

The test file I added is a good example of how easily markdown can be interpreted as a different language. There aren't near enough markdown tokens to override the huge number of tokens in a short code block. Adding subLanguage resolves this because it adds that relevance to markdown's score.
It could be a plugin, it could also be added as an alternate language file. For our purposes, I am using this file (with a few additions for relevance) in place of the default markdown implementation.

I was pretty sure I'd typed up another response, but I don't see it here.  I don't think we want to merge this as is... the "autodetect all" is just too much... if we wanted to discuss a way to dynamically only support named languages, such as:
```ruby
def add(a,b)
end
```

Such that any language (or alias) loaded was usable... but that gets into issues with the load order, etc - that would need to be discussed/worked out.  I'd be open to that discussion though.
If someone wants the exact behavior of this PR as you said it's easy to just add/define a custom variant of markdown that does that.
Closing this, but happen to continue the discussion if you're interested in the dynamic route idea.


IPData is not a constructor

Hi! I'm trying to create the IPData instance but returns "IPData is not a constructor".
I'm following all the documentation instructions...

It works for me.
new IPData(apiKey)

I've today moved from CommonJS to ESM and now getting this same error.
I was importing fine before;
import IPData from 'ipdata';

const ip = new IPData(apiKey)

But that doesn't work with ESM.


tremor-*: build on more platforms

Description of changes

Things done

Built on platform(s)

[ ] x86_64-linux
[x] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.05 Release Notes (or backporting 22.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@ofborg build tremor-rs tremor-language-server

Result of nixpkgs-review pr 234425 run on aarch64-darwin 1

2 packages built:

tremor-language-server
tremor-rs

Result of nixpkgs-review pr 234425 run on x86_64-darwin 1

1 package marked as broken and skipped:

tremor-rs

1 package built:

tremor-language-server


feat(heading): Adding stories for heading(s) - OEL-1929

@planctus i see that for example the icon-list is a private package and don't have .npmignore. Should it be the same here?

the bcl-heading package is not private..

On default i get a white page...


Is transition time setting for undim only?

I notice if you change from the default transition time, what ever setting you choose only affects the undimming of lights. The initial dim (movie start) seems to be the same no matter the setting? Is this how it's intended to work?

Is that with proportional dim time enabled?

Also, what is your brightness setting? I think I've found the issue - the code
if not bri doesn't handle bri = 0 well. :)

I don't believe I had proportional checked - no.
Of course my dim level is 0. I have lights right next to the TV that I am turning off so anything less than completely off is distracting.


Rolemaster united

Changes / Comments
Completely renamed files to make them understandable.
Fixed Spells section - more work needed, but now it is functional, but not enuf spells - yet
Fixed Stat Section
Fixed Several RMSS artifacts on start page
Started moving tables to CSS Grids
Changed entire roll javascript, updated roll templates to accomodate.
This update will not saved character data. Sorry, but there were too many changes.
Files Added
RolemasterUnified.css
RolemasterUnified.html
RolemasterUnified.jpg
Files Removed
sheet_RMU_v1.0.css
sheet_RMU_v1.0.html
sheet_RMU_v1.0.jpg
Changed files
sheet.json
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[X] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[X] Does this add functional enhancements (new features or extending existing features) ?
[X] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[X] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

Hi @Pantsorama
It appears that you have merge conflicts in this PR. Please resolve these so we can merge this PR.


Sortable breaks post Ajax call

I have an ASP.NET Ajax call "__doPostBack()" in the onEnd event of the sortable. The sorting behavior breaks immediately after executing the Ajax call. After that the elements are no longer draggable.

@Gruski It would be helpful to see the exact code in the onEnd event that is breaking it

Sorry, it was a different code error that was causing the code to halt.


Folder structure too complicated, difficult to synchronize archives

Digging into "Content", there is the list of folders, each single one with its own subfolder structure NAME\GameData\GrimmAerospace\GrimmModlets\NAME\
I suggest a change to Content\GameData\GrimmAerospace\GrimmModlets\NAME to avoid going back and forth again and again.

I see what you mean, but the reason for this is because each folder under GameData is basically a separate mini-mod that people may decide to install (or not). I fear that if I organize it the way you describe, people will get confused about which folder they can delete or not.
But I realize that this structure is also not ideal (in fact, in my first draft I had exactly the structure you describe) so I am open to discussing it.

You could use PatchManager mod for it.

That would just lead to a stream of complaints along the line of "I installed it but nothing happened."

Well, who uses PatchManager should know that he/she uses it and how to use it.
And a proper description is 80% of the experience.
I know, many talented but otherwise autistic programmers can code but are incapable of writing at least a minimum of documentation, wiki or user manual.
But that must not be the norm.
Also; you cannot do failsafe for any circumstance within 8 billion people with a given percentage of ignorance or dumbness.
There are people who understand well - and others without a clue. Let them be. And don't punish those who understand.
And - a wonky folder structure also triggers complains. See this issue ;)

I'll think about it more, at the very least it might be an interesting weekend project.

So I looked into this and I only found two ways of implementing "conditional enable". Either by injecting C# code at runtime into ModuleManager (the way Kerbalism does it) or by creating lots of empty folders under GameData to trick ModuleManager into thinking they are mods (the way RO/RP-1/MechJeb do it).
Neither approach makes sense in the context of this mod, but I'm also not very happy with the current solution either, so I'm going back to my previous structure, one where all modlets (except the redundant ones) are enabled by default and the user can delete the ones he doesn't want. As a consequence it should also be easier to navigate now.


10/06 PM Publish

Docs Build status updates of commit e3a98a3:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs-conceptual/azureadps-2.0/using-extension-attributes-sample.md
:bulb:Suggestion

Details

azureadps-2.0/AzureAD/AzureActiveDirectory.md
:white_check_mark:Succeeded

docs-conceptual/azureadps-2.0/using-extension-attributes-sample.md

Line 2, Column 1: [Suggestion-description-missing] Missing required attribute: 'description'.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel


fix: enum generation

Description
Fix generation of enums

all non alphabetic symbol and numbers will be replaced to "_" in variable name
if name starts with not alphabetic symbol than "_" will be added in the beginning

Known issue - there is no check against the same names of variables after transformation, but normally that's not happen
Checked with:
          type: string
          enum:
            - '22main'
            - 'alternative.'
            - 're-lo ca,ti.on?'

Related issue(s)

Fixes: #83

Omg, I failed branch  managing again... Only last commit from this huge list is relevant.

@Tenischev no problemo man, we anyway squash into one commit and merge


Add Documentation for GetRandom :: why and how.

GetRandom is hella useful for creating fake data on the fly when using Builder<T>.
eg.
public static IList<User> CreateUsers(int numberOfUsers = 20)
{
    return Builder<User>.CreateListOfSize(numberOfUsers)
                        .TheFirst(1)
                        .With(x => x.Id, "users/1")
                        .And(x => x.Name, "Han Solo")
                        .All()
                        .With(x => x.Name, $"{GetRandom.FirstName()} {GetRandom.LastName()}")
                        .With(x => x.Email, GetRandom.Email())
                        .Build();
}

Needs documentation added to dat wikiz.

I always found the GetRandom to be hidden away and not really felt like part of the API that makes NBuilder so special. Not really related to documenting the static helper but, what about an override of our builder functions where we can pass in an instance of a generator, e.g
With(x => x.Name, (generator) => generator.FirstName())

That's a great suggestion!


Custom activation function not training

I am trying to implement my own custom activation function and tested the approach with the already implemented ELU function.
For some reason the rebuild ELU function doesn't train at all. The loss is at zero after the first epoch and the accuracy doesn't improve.
def custom_activation(x):
    cond = K.greater(x, 0)
    return K.switch(cond, x, K.exp(x) - 1)

get_custom_objects().update({'custom_activation': Activation(custom_activation)})

I also tried using the Keras API build into Tensorflow and only Tensorflow functions with the same result.
Full code:
from keras.datasets import mnist

(x_train, y_train), (x_test, y_test) = mnist.load_data()

x_train = x_train.reshape(x_train.shape[0], 28*28)
x_test = x_test.reshape(x_test.shape[0], 28*28)

from keras.utils import to_categorical

y_train = to_categorical(y_train)
y_test = to_categorical(y_test)

from keras import Sequential
from keras.layers import Dense, Activation, Dropout
from keras.optimizers import SGD
from keras import backend as K
from keras.utils.generic_utils import get_custom_objects

def custom_activation(x):
    cond = K.greater(x, 0)
    return K.switch(cond, x, K.exp(x) - 1)

get_custom_objects().update({'custom_activation': Activation(custom_activation)})

model = Sequential([
    Dense(128, input_shape=x_train.shape[1:]),
    Activation(custom_activation),
    Dense(128),
    Activation(custom_activation),
    Dense(128),
    Activation(custom_activation),
    Dense(128),
    Activation(custom_activation),
    Dense(128),
    Activation(custom_activation),
    Dense(128),
    Activation(custom_activation),
    Dense(128),
    Activation(custom_activation),
    Dense(128),
    Activation(custom_activation),
    Dense(10),
    Activation('sigmoid')
])

model.compile(SGD(lr=0.01), loss='categorical_crossentropy', metrics=['accuracy'])

model.fit(x=x_train, y=y_train,
          validation_data=[x_test, y_test],
          batch_size=64, epochs=5)

Switching the custom_activation for 'elu' works fine.

There may be an overflow error when using K.exp(x) if x is large.
I noticed that K.exp(x) results in loss = nan, but if it is replaced with K.exp(x/100000) it doesn't become nan. I don't know how to get around the issue though.

Also note that CPUs and presumably also GPU often implement exp(x) - 1 as a single instruction. This is mostly for increased accuracy for when x is close to zero.
Here's for example the numpy docs about it: https://docs.scipy.org/doc/numpy/reference/generated/numpy.expm1.html
Perhaps this is related to your problem, since you're not using that.


Ignore Templates

Hey,
Whats the method for ignoring certain templates like the ec2 and waf ones?

Resolved myself! cheers


SqueezeSAM

Great work! I was wondering what's happening with SqueezeSAM as it's been added to this repo and then subsequently removed. I'd like to try it for its salient segmentation features. Thanks!

@jrhe, thanks for your interest in SqueezeSAM. The model is not ready for releasing. We will let you know once it is ready.

hello, when will it be released? it has been almost 3 months...

@jrhe  can you share the SqueezeSAM you have in hand? thanks a lot!


Appstudio update test-component-pac-braj

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI/test-component-pac-braj-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
25 seconds
clone-repository

✅ Succeeded
26 seconds
build-container

✅ Succeeded
21 seconds
deprecated-base-image-check

✅ Succeeded
20 seconds
inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
45 seconds
clamav-scan

✅ Succeeded
17 seconds
sbom-json-check

✅ Succeeded
26 seconds
label-check

✅ Succeeded
10 seconds
show-sbom

✅ Succeeded
11 seconds
show-summary

Pipelines as Code CI/test-component-pac-braj-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
11 seconds
init

✅ Succeeded
22 seconds
clone-repository

✅ Succeeded
24 seconds
build-container

✅ Succeeded
44 seconds
inspect-image

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
12 seconds
clair-scan

✅ Succeeded
34 seconds
clamav-scan

✅ Succeeded
9 seconds
sbom-json-check

✅ Succeeded
18 seconds
label-check

✅ Succeeded
6 seconds
show-sbom

✅ Succeeded
7 seconds
show-summary


ONNX import/export: Dynamic reshape

Description
This PR adds ONNX conversion for dynamic reshape that has been added in PR https://github.com/apache/incubator-mxnet/pull/15872. The operator conversion is being tested through the conversion of PyTorch model to MXNet through ONNX (testing import). And converting the resultant MXNet model back to ONNX (testing export).
Can be merged only after https://github.com/apache/incubator-mxnet/pull/15872, https://github.com/apache/incubator-mxnet/pull/15993, https://github.com/apache/incubator-mxnet/pull/15995
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.

[ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
[ ] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage:
Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
[ ] Code is well-documented:
For user-facing API changes, API doc string has been updated.
For new C++ functions in header files, their functionalities and arguments are documented.
For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
[ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

ONNX import/export dynamic shape
Changes required to make ONNX export of dynamic shapes possible
Tests to convert Pytorch->ONNX->MXNet->ONNX.

Comments
Fixes apache/incubator-mxnet#13774
Fixes apache/incubator-mxnet#13395
Fixes apache/incubator-mxnet#13949
Fixes apache/incubator-mxnet#14916

@mxnet-label-bot add [pr-work-in-progress, ONNX]


Unable to create same scrypt digest with Go-s implementation

I'm having a problem of calculating the same scrypt digest between RbNaCl and Go's implementation.
Here's how I'm generating key with rbnacl:
opslimit = 2**20
memlimit = 2**24
digest_size = 32

digest = RbNaCl::PasswordHash.scrypt(
        password,
        salt,
        opslimit,
        memlimit,
        digest_size
)

opslimit and memlimit parameter values have been found from documentation.
Here's my attempt to replicate same results with Go:
cpuFactor := 32768
memoryFactor := 8
parallelFactor := 1
keyLength := 32

secretKeyBytes, _ := scrypt.Key(password, salt, cpuFactor, memoryFactor, parallelFactor, keyLength)

Values for cpuFactor, memoryFactor, parallelFactor and keyLength gotten from documentation.
password and salt have same values.
I'm not a cryptographer, but as far as I understand there should be same cost factor values to get the same digest? The problem here is that since both implementations take different count of parameters it's hard for me to find the correct combination too. Any ideas how to make cost factors match between these two implementations so that I could calculate same scrypt hashes between two programming languages?

Managed to calculate N, p and r from opslimit and memlimit by looking into function pickparams, which was called by crypto_pwhash_scryptsalsa208sha256.
Here's the relevant code if anyone else needs it in the future:
https://gist.github.com/jarmo/22f871076ff70e39b54e69c6305c020f
All in all the problem was that Go exposes lower level API than RbNaCl even though they are doing the same thing.
Closing this issue for now!


Being more careful with releases

Frequently updating a library is always a good thing, new features, more security, but also just the pleasure of seeing that you are using a project that is alive.
When this happens on such large and important projects like ElasticSearch it is really nice and I thank you for the continuous work you are doing.
Precisely for this reason, I would like to use a quote 'With great power comes great responsibility'.
Every time I update the SDK I get breaking changes out of the blue without having had any signals beforehand especially if I am updating a minor version which should never introduce breaking changes (see SEMVER) but this unfortunately does not happen.
I go to the site and look at the release hoping to find documentation explaining that now API "A" no longer exists and API "B" must be used, but this document is not there.
It would be nice to have it and, more importantly, before sawing off a method it should be marked as deprecated in some previous version.
This is not meant to be a criticism, let alone a complaint, but an insight into the experience of someone who uses your SDK on a daily basis.
Thank you again and keep up the good work

Hi @imperugo, thanks for your kind feedback!
I understand that breaking changes are always painful, but sadly they are not avoidable a lot of times in the context of the Elasticsearch client. Let me give you some insights 🙂

Every time I update the SDK I get breaking changes out of the blue without having had any signals beforehand especially if I am updating a minor version which should never introduce breaking changes

The version numbers of the client are aligned with the ones from the server (at least for the major.minor part). This often leads to the assumption that the client is using semantic versioning - which is not the case. The patch version is indepentant and increased everytime the client releases an update. This allows us to do frequent updates (new server versions are released less than once per month) while still indicating server <-> client version compatibility.
Usually I try to limit breaking changes to cases where the code was broken before. Recently, I had to do more breaking changes due to switching to a completely new code generator and to be able to implement some previously completely unsupported functionality. The new client is finally getting close to a state of supporting every server endpoint, which means that the number of breaking changes will hopefully decrease in the near future.

before sawing off a method it should be marked as deprecated in some previous version.

For cases where it's possible, I definitely try to deprecate old functionality first, before I remove it (e.g. the recent deprecation of the synchronous request methods). Most of the cases, however, are driven by changes to our specification. The specification is a formal definition of the API surface which is used to generate large part of the client (not only for .NET, but as well for other languages).

I go to the site and look at the release hoping to find documentation explaining that now API "A" no longer exists and API "B" must be used, but this document is not there.

This changelog can be found in the release notes here on GitHub. I try to document all major breaking changes here and to provide some examples of how to migrate (I will add a section to the latest release as well as I'm currently missing this part). There is some CI work on my todo list to push the release notes to the official website again (this functionality is broken for a while..).
Thanks again for this valuable feedback!


mouse is not jiggled when the cursor is captured by vmware

If the mouse cursor is captured by a VMware virtual machine, the jiggler is not able to do the job anymore.
In this case, the screensaver will start or the screen will be locked as usual.

Unfortunately, there are certain apps which bypass the usual Windows input queue mechanisms in favor of their own (VMware VM capture being one of these), and since in this scenario the input events synthesized by Mouse Jiggler never make it to Windows's idle detection, Windows falsely thinks it's idle.
Unfortunately, this is probably a limitation affecting all software-based mouse jiggler-type programs.


Rewire any dead qubits when using partial initial rewiring

Closes #128.

It would be good to include in the test suite the input that triggered this bug.
Also, out of curiosity: does this fix hold up when you have a qubit graph that's disconnected by dead qubits?

I'm not ready to sign off on this yet, but if the proposed addition turns out to be obnoxious then I think that this will suffice.

OK. I think the latest commit is the Good Fix.
If test.qpu is
{"isa": {"1Q": {"1": {}, "3": {}},
         "2Q": {"0-1": {}, "1-2": {}, "2-3": {}}}}

then we have
(print-parsed-program (compiler-hook (quil::parse-quil-string
"
PRAGMA INITIAL_REWIRING \"PARTIAL\"
PRAGMA EXPECTED_REWIRING \"#(0 1 2 3 4 5 6 7 8 9)\"
RX(pi) 0
PRAGMA CURRENT_REWIRING \"#(0 1 2 3 4 5 6 7 8 9)\"
") (read-chip-spec-file "test.qpu")))
PRAGMA INITIAL_REWIRING "PARTIAL"
PRAGMA EXPECTED_REWIRING "#(3 0 1 2)"
PRAGMA EXPECTED_REWIRING "#(0 1 2 3 4 5 6 7 8 9)"
RX(pi) 3
PRAGMA CURRENT_REWIRING "#(3 0 1 2)"
HALT
NIL

which maps the dead qubit 0 to the live qubit 3.
Likewise if test.qpu is

then we have
(print-parsed-program (compiler-hook (quil::parse-quil-string
"
PRAGMA INITIAL_REWIRING \"PARTIAL\"
PRAGMA EXPECTED_REWIRING \"#(0 1 2 3 4 5 6 7 8 9)\"
CNOT 1 2
PRAGMA CURRENT_REWIRING \"#(0 1 2 3 4 5 6 7 8 9)\"
") (read-chip-spec-file "test2.qpu")))
PRAGMA INITIAL_REWIRING "PARTIAL"
PRAGMA EXPECTED_REWIRING "#(0 2 3 1)"
PRAGMA EXPECTED_REWIRING "#(0 1 2 3 4 5 6 7 8 9)"
RZ(-pi/2) 3
RX(pi/2) 3
CZ 3 2
RZ(pi) 2
RX(-pi/2) 3
RZ(pi/2) 3
PRAGMA CURRENT_REWIRING "#(0 2 3 1)"
HALT
NIL

which maps dead qubits to live qubits in the largest connected component.


Adding sub command description on generated usage help

The generated help with included subcommands, does not show how to apply the subcommand.
For example:
public class DemoApp {

    @Command(name = "demo", subcommands = DemoCmd.class)
    static class Demo implements Runnable {

        @Option(names = {"-h", "--help"}, usageHelp = true)
        private boolean help;

        public void run() {
            System.out.println("Print help message.");
        }
    }

    @Command(name = "cmd")
    static class DemoCmd implements Runnable {

        @ParentCommand
        private Demo parent;

        @Override
        public void run() {
            System.out.println("DONE");
        }
    }

    public static void main(String[] args) {
        CommandLine.run(new Demo(), System.out, "-h");
    }
}
prints to the console:
Usage: demo [-h]
  -h, --help
Commands:
  cmd

The user may be asking how to apply the subcommand since it is only showing demo [-h].
Could be possible to show for example:
Usage: demo [-h] [command]

I think that's a good idea.
Do you think you can create a pull request for this?

I created the pull request for this feature.

Nice work, thank you!
I merged the PR into master and this will be part of the upcoming 3.0 release (no timeline yet).


Parameters for configurable hair physics added

This is solution for issue: https://github.com/webaverse/app/issues/1598
.scn file can now have parameter used for heir physics.
That parameter looks like this:
"hair_physics":{
"gravity_power_factor": 0.1,
"stiffness_force_factor": 0.1
}
Also there is a change in https://github.com/webaverse/metaversefile to support this

The other PR is https://github.com/webaverse/metaversefile/pull/11/files; this should be linked in the PR description.


Remove "Edit on Github" buttons from RTD builds

Addresses #298
Summary of changes:

overrides sphinx theme read the docs button

I have made the sphinx_delete branch visible on RTD so you can go look at how the change affects the documentation generation.

I have updated the docs to include a support page that links to the repo. It's building on RTD now!

I have updated the docs to include a support page that links to the repo. It's building on RTD now!


Add dispatch machinery to the action

Add dispatch machinery to the action.

@AlbertoFemenias , @frmadem what do you think about not using a string and using a yaml list, and service_names as the key:
https://github.com/prefapp/demo-state/issues/26#issuecomment-885005550

@AlbertoFemenias , @frmadem what do you think about not using a string and using a yaml list, and service_names as the key:
prefapp/demo-state#26 (comment)

I concur. Modified the code.


Switch to REM, add css var for font-size & colors

Less changes

Rename .R to .propertyViewport
Remove less vars for background & colors and set it to css var
Add .propertyRem mixin to use rem & include media query in one go
Extract args in .propertyViewport to allow use of args like 10 10 10 or 10 auto 20 in margin / padding properties

@pierregradelet I have updated variables folder and files struct

src/atoms
- src/atoms/variables-css.less
- src/atoms/variables-less.less


Would it be possible to specifiy the coordinates manually?

When I use the integration the forecast is not very accurate but if I call the API manually I get much accurate results. I'm guessing that the location obtained from home assistant is not very accurate or correct.

Sorry I thought this was the integration


[Skin] Griffin

Hash: 8093e595fabaa7293ec1cd725c73b0291b2e3f1c
Current name: Griffin
The author is EvilMonkey going by the pic

Updsated


Move location input to a separate page

Filling other inputs on the signature page resets the signature canvas on mobile devices as opening the keyboard causes a viewport resize. To avoid the bad UX, the input was moved to another page.

@lsc0498 ping :)

@lsc0498 no worries, wasn't that time critical anyway :)


Feature Request:  Master layout

~~https://dwm.suckless.org/~~
https://wiki.hyprland.org/Configuring/Master-Layout/

Is this referring specifically to the master & stacking implementation detail of the "tiled layout"?

As previous dim user, this would be an awesome addition. When first setting up yabai, I did some complex shortcuts to make this work. still not there yet 😆 . I think indeed it's referring to master & stacking impl

CURRENT_DISPLAY=$(yabai -m query --windows --window | jq '.display')
WINDOWS_ARRAY=$(yabai -m query --windows --space $(yabai -m query --spaces --space | jq '.index') --display $CURRENT_DISPLAY | jq -r 'map(select(.["is-minimized"]==false and .["is-floating"]==false))')
NUMBER_OF_WINDOWS=$(echo $WINDOWS_ARRAY | jq -r 'length')

case $NUMBER_OF_WINDOWS in
	[0-1])
		yabai -m config split_ratio 0.65
		yabai -m config split_type auto
		;;
	2)
		yabai -m config split_ratio 0.5
		;;
	3)
    yabai -m config split_type horizontal
    yabai -m config split_ratio 0.5
    yabai -m space --balance x-axis
		;;
	*)
    yabai -m space --balance x-axis
		;;
esac

CURRENT_DISPLAY=$(yabai -m query --windows --window | jq '.display')
WINDOWS_ARRAY=$(yabai -m query --windows --space $(yabai -m query --spaces --space | jq '.index') --display $CURRENT_DISPLAY | jq -r 'map(select(.["is-minimized"]==false and .["is-floating"]==false))')
NUMBER_OF_WINDOWS=$(echo $WINDOWS_ARRAY | jq -r 'length')

case $NUMBER_OF_WINDOWS in
	[0-1])
		yabai -m config split_ratio 0.65
		yabai -m config split_type auto
		;;
	2)
		yabai -m config split_ratio 0.5
		;;
	3)
    yabai -m config split_type horizontal
    yabai -m config split_ratio 0.5
    yabai -m space --balance x-axis
    yabai -m window last --insert south
		;;
	*)
    yabai -m space --balance x-axis
    yabai -m window last --insert south
		;;
esac

A shitty workaround
CURRENT_DISPLAY=$(yabai -m query --windows --window | jq '.display')
WINDOWS_ARRAY=$(yabai -m query --windows --space $(yabai -m query --spaces --space | jq '.index') --display $CURRENT_DISPLAY | jq -r 'map(select(.["is-minimized"]==false and .["is-floating"]==false))')
NUMBER_OF_WINDOWS=$(echo $WINDOWS_ARRAY | jq -r 'length')

case $NUMBER_OF_WINDOWS in
	[0-1])
		yabai -m config split_type auto
		;;
	2)
		;;
	3)
		yabai -m config split_ratio 0.5
		yabai -m space --balance x-axis
		yabai -m config split_type horizontal
		;;
	*)
		yabai -m space --balance x-axis
		;;
esac

I have successfully combined krohnkite-core with yabai.
There are still some bugs at the moment. After fixing some bugs, I will release an early version on GitHub. This should not take too long.
https://github.com/koekeishiya/yabai/assets/24669431/fae86b77-691f-4064-869c-350d6815f61c

Great, but to do it the right way, we need to change the logic in the source code of yabai. All scripts on top of it are doomed to behave nonsensical.

When closing the last visible window of the same app, if there is a minimized window in the app, the minimized window will be automatically displayed!

When closing the last visible window of an app, if the app does not have a minimized window, another app that is different from it will not automatically gain focus!

Something is causing this, macos does not behave like that.
It is the main logic of macos, an app can be run without a window at all. I use hammerspoon for a workaround. Or @FelixKratz's fork of yabai fixes that too.
See #2, mostly to reopen a window you must press a shortcut, either command+n or command+numbers
see #2

There are four more things to deal with

When there is no focus, automatically let a window gain focus.
Respond to dock and global menu show-hide events and adjust the available screen space.
Responds to events emitted when the window changes size and position via the mouse
Multi-monitor testing, multi-space can work now, multi-monitor should also work, but there is no test yet

Although moving the position of the window through the mouse and adjusting the size of the window through the mouse have not yet been processed
I am still planning to deal with compilation, packaging and distribution tomorrow
Because the requirements of the early version have now been met.
https://github.com/koekeishiya/yabai/assets/24669431/615044d8-cdee-479f-a1ba-bc35af9b0118

Currently there are only development versions.
The release of npm, crates.io, brew, nix and github still requires some time to configure github actions and changesets.
https://github.com/I-Want-ToBelieve/yakite

Settings
split_ratio 0.30
split_type auto
window_placement first_child

Signals
yabai -m signal --add event=window_created action='yabai-panes; yabai -m window --warp first; yabai -m window --warp prev; yabai -m space --balance x-axis'
yabai -m signal --add event=window_destroyed action='yabai-panes; yabai -m space --balance x-axis'
yabai -m signal --add event=window_minimized action='yabai-panes; yabai -m space --balance x-axis'
yabai -m signal --add event=window_deminimized action='yabai-panes; yabai -m window --warp first; yabai -m window --warp prev; yabai -m space --balance x-axis'
yabai -m signal --add event=application_hidden action='yabai-panes; yabai -m space --balance x-axis'
yabai -m signal --add event=application_visible action='yabai-panes'
yabai -m signal --add event=space_changed action='yabai-panes'

yabai-panes
#!/bin/zsh
currentsp=$(yabai -m query --spaces --space | jq '.display')
windowcount=$(yabai -m query --windows --space | jq -r '.[]."is-floating"' | grep false | wc -l)
excludes="Menuwhere\|Color Picker\|xQuartz"
countexcludes=$(yabai -m query --windows --space | jq -r '.[].app' | grep "${excludes}" | wc -l)
hiddenwindows=$(yabai -m query --windows --space | jq -r '.[]."is-visible"' | grep false | wc -l)
windowcount="$((windowcount - hiddenwindows - countexcludes))"

case $windowcount in
		[0-1])
			yabai -m config split_ratio 0.30 split_type vertical ;;
		2)
			yabai -m config split_ratio 0.5 split_type horizontal ;;
		*)
			yabai -m config split_ratio 0.5 split_type horizontal ;;
esac


Feature/2018 03 28 api spike

New API

We've got ;'s in all the new .js files.  I'm not huge a fan of the npm style either, but its what we've got going so we should stay consistent.

Yeah. After we do all the current platform merging, we can update the rest of the files to be consistent.

Thanks for leading the charge on our public-facing API!


Hiding Site Access only works part of the time

v0.18.2
Steps:

Go to Access Control
Authenticate
Click on Customize
Switch it to Allow any Github user and Save
Go to host page or any other page and back.  Also do a hard refresh (nothing happens and Site Access is still fully visible)
Click on Restrict to specific GitHub users and organization members: and Save
Change pages and go back to Access Control (nothing happens)
Do a hard refresh of the page

Result:
Finally Site Access is hidden again and the Customize button is showing.
Expected:
After leaving page and coming back or hard refresh Site Access should always be hidden with customize button, or never hidden.

v Local Project build - Verified fixed (recheck in 0.19.0)

v0.19.2
Failed

lies

v0.19.2
Reviewed with Vince and working as designed - Verified fixed


[Debt] remove type switching on kzg feature

Component
consensus, eips, genesis
What version of Alloy are you on?
No response
Operating System
None
Describe the bug
consensus and engine-types switch the Blob and Bytes48 types when the kzg feature is enabled. These types are props in BlobTransactionSidecar SidecarBuilder and BlobsBundleV1 and create problems with RLP and SSZ impls on those types.
Instead of switching when the feature is enabled, we should transmute when and only when doing KZG operations

Additional context:

#[cfg(not(feature = "kzg"))]
use alloy_eips::eip4844::Blob;
#[cfg(feature = "kzg")]
use c_kzg::{Blob, KzgCommitment, KzgProof};

from: https://github.com/alloy-rs/alloy/blob/15d56f959f64dc103918166a66ac93ad1ea3af4d/crates/consensus/src/transaction/eip4844/builder.rs#L1C1-L4C44
another:

I would like to take on this

this is how my implementation is going, It is looking messy, I guess I am doing something wrong;

    pub fn with_capacity(capacity: usize) -> Self {
        let mut blobs = Vec::with_capacity(capacity);
        #[cfg(feature = "kzg")]
        use c_kzg::{Blob};
        #[cfg(feature = "kzg")]
        let blobs: Vec<Blob> = unsafe { std::mem::transmute(blobs) };

        blobs.push(Blob::new([0u8; BYTES_PER_BLOB]));
        Self { blobs, fe: 0 }
    }

@prestwich what are your thoughts?


errors in linux build

Here's the raw output, haven't digested it too much yet:
[155/187] Compile Module.PCGExtendedToolkit.1.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.1.cpp:3:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExAdjacencyFilter.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/Filters/PCGExAdjacencyFilter.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExGraphDefinition.h:11:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExDataState.h:7:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.1.cpp:3:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExAdjacencyFilter.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/Filters/PCGExAdjacencyFilter.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExGraphDefinition.h:11:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExDataState.h:11:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExDataFilter.h:10:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExFactoryProvider.h:9:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
7 errors generated.
[156/187] Link (lld) libUnrealEditor-HermesContentEndpoint.so
[157/187] Compile Module.FSGame.3.cpp
[158/187] Compile Module.PCGExtendedToolkit.2.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.2.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExDataFilter.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExDataFilter.h:7:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.2.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExDataFilter.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExDataFilter.h:10:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExFactoryProvider.h:9:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
7 errors generated.
[159/187] Compile Module.PCGExtendedToolkit.3.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.3.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExFuseCollinear.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Paths/PCGExFuseCollinear.h:7:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Paths/PCGExPathProcessor.h:9:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.3.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExFuseCollinear.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Paths/PCGExFuseCollinear.h:7:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Paths/PCGExPathProcessor.h:10:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:13:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExData.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
7 errors generated.
[160/187] Compile Module.PCGExtendedToolkit.4.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.4.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExLloydRelax2D.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Misc/PCGExLloydRelax2D.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.4.cpp:3:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExMakeClustersUnique.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExMakeClustersUnique.h:7:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExCluster.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:13:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExData.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
7 errors generated.
[161/187] Compile Module.PCGExtendedToolkit.5.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.5.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExPathfindingPlotEdges.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/Pathfinding/PCGExPathfindingPlotEdges.h:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/Pathfinding/PCGExPathfinding.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExCluster.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:11:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.5.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExPathfindingPlotEdges.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/Pathfinding/PCGExPathfindingPlotEdges.h:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/Pathfinding/PCGExPathfinding.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExCluster.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:13:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExData.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
7 errors generated.
[162/187] Compile Module.PCGExtendedToolkit.6.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.6.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExSampleSurfaceGuided.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Sampling/PCGExSampleSurfaceGuided.h:9:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.6.cpp:4:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExSanitizeClusters.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExSanitizeClusters.h:7:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExCluster.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:13:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExData.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
7 errors generated.
[163/187] Compile Module.ShooterCoreRuntime.cpp
[164/187] Compile Module.PCGExtendedToolkit.9.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.9.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Private/Sampling/PCGExSampleProjectedNearestPoint.cpp:4:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Sampling/PCGExSampleProjectedNearestPoint.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.9.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Private/Sampling/PCGExSampleProjectedNearestPoint.cpp:4:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Sampling/PCGExSampleProjectedNearestPoint.h:11:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
7 errors generated.
[165/187] Compile Module.PocketWorlds.cpp
[166/187] Link (lld) libUnrealEditor-PocketWorlds.so
[167/187] Compile Module.PCGExtendedToolkit.7.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.7.cpp:2:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExWriteIndex.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Misc/PCGExWriteIndex.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.7.cpp:3:
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/UnrealEditor/Inc/PCGExtendedToolkit/UHT/PCGExWritePathExtras.gen.cpp:8:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Paths/PCGExWritePathExtras.h:7:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Paths/PCGExPathProcessor.h:10:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:13:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExData.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
7 errors generated.
[168/187] Compile Module.PCGExtendedToolkit.8.cpp
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.8.cpp:3:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Private/Graph/PCGExEdgesProcessor.cpp:4:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExEdgesProcessor.h:7:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExCluster.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:11:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected '>'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:27: note: to match this '<'
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:36: error: expected unqualified-id
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:37: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:49: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:62: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start<MainTask>(-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
In file included from /src/game/Plugins/PCGExtendedToolkit/Intermediate/Build/Linux/x64/UnrealEditor/Development/PCGExtendedToolkit/Module.PCGExtendedToolkit.8.cpp:3:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Private/Graph/PCGExEdgesProcessor.cpp:4:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExEdgesProcessor.h:7:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExCluster.h:9:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Graph/PCGExGraph.h:13:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/PCGExData.h:8:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
~~ ~^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/Data/Blending/PCGExDataBlending.h:545:56: note: place parentheses around the '&&' expression to silence this warning
if (bFirstOperation || !this->bInterpolationAllowed && this->GetIsInterpolation())
^
( )
7 errors generated.

Will be looking into that ASAP -- I've had a lot of issues lately that start popping up and I can quite pinpoint t what change triggered it ^^
As for your compilation errors that should be an easy fix. Will keep you posted!

Hiya @tychotic !
I submitted a few fix in the cluster-features branch; let me know if it pops some new ones after these.

Ah cool I will test those updates. Is it safe to grab the whole
cluster-features or should I cherry pick?
On Fri, Jun 14, 2024 at 10:30 PM Tim @.***> wrote:

Hiya @tychotic https://github.com/tychotic !
I submitted a few fixes in the cluster-features
https://github.com/Nebukam/PCGExtendedToolkit/tree/cluster-features
branch; let me know if it pops some new ones after these.
—
Reply to this email directly, view it on GitHub
https://github.com/Nebukam/PCGExtendedToolkit/issues/51#issuecomment-2169138679,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BAW37WNBH7ARNCLT2HQJFBDZHPGQPAVCNFSM6AAAAABJLCCN66VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRZGEZTQNRXHE
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>

Nah it's completely broken atm, I'm bashing my head trying to figure out why :(

I've got most of them fixed but am stumped by this one so far. We thought it was a clang different interpretation of <foo > so I added spaces but this error persisted:
In file included from /src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExFactoryProvider.h:9:
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:38: error: expected '>'
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:28: note: to match this '<'
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:39: error: expected unqualified-id
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:41: error: 'ChunkTask' does not refer to a value
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:286:40: note: declared here
template <typename MainTask, typename ChunkTask>
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:53: error: expected expression
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:56: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:60: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~
/src/game/Plugins/PCGExtendedToolkit/Source/PCGExtendedToolkit/Public/PCGExPointsProcessor.h:289:69: error: left operand of comma operator has no effect [-Werror,-Wunused-value]
GetAsyncManager()->Start < MainTask < ChunkTask > > (-1, PointIO, NumIterations, ChunkSizeOverride <= 0 ? ChunkSize : ChunkSizeOverride);
^~~~~~~~~~~~~
7 errors generated.

think I've found it, stay tuned

Yeah this one is because there's basically useless redundancy in the template, and it's echoing to another function that does exactly the same thing with a single parameter.
It's safe to remove that function entirely and just keep the other one that does the same thing (the one with the FullTask template)
On another note, I've started to stabilize the cluster-feature branch; while there is still a lot of stuff to iron out and some features that aren't properly updated it should be ready to play in the coming days :D

Closing since there hasn't been any news on this. Feel free to re-open if you encounter any issues with Linus again!


Execution timeout

While running build for https://github.com/ExecutableBookProject/quantecon-example , parallelization.md file, times out in my system

Will pass a timeout argument to configure, to ExecutePreProcessor of jupyter-cache to fix this.

Hey @AakashGfude - any updates on conversations you've had in the nbformat repo about where to put metadata?

Hey @choldgraf , so, in this discussion thread https://github.com/jupyter/nbclient/issues/45, it was mentioned that the proposed format will be discussed with the developers of nbformat in an issue. I will check back on this.

Sounds good - I think you are both waiting for one another to open up this issue. Can you try it? Or if you don't want to I can open the issue

@choldgraf  thanks. No worries, I will open an issue then.


[Situp] Update Name and Version of situp project

Update name of the situp project
Update version and drop beta

Completed as part of #181 #183 #184 #186 #187


[Interface] Naming conflicts for implemented interface method with multiple signatures

http://forums.bridge.net/forum/bridge-net-pro/bugs/310-name-conflicts-for-implemented-interface-method-with-multiple-signatures-present

https://github.com/bridgedotnet/Builder/commit/f85955c


Fixes

Pushing another PR, but I can see that some of the changes there in formatting, you might not like...
Some can be tweaked in the .rustfmt.toml config file… but some I don't know/am not sure… like the column layout for fields in structs... another option is to leave the check for cargo fmt out completely…
Btw, some of this might have changed and might change again with new rust toolchain releases…

I guess what I'm saying is, if some of these format changes you'd like to not have, let me know which and I'll see change this PR to add a .rustfmt.toml with the according rules properly configured, if that's possible…

Found it!… I'll open another PR and you then decide which one to merge.


Beta and maskable icons

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.007%) to 99.482%

Totals

Change from base Build<PHONE_NUMBER>:
0.007%

Covered Lines:
10081

Relevant Lines:
10084

💛  - Coveralls


Added HA pod scheduling options and multi repository provisioning

Added pod affinity, tolerations, nodeselectors, topology spread constraints, multiple repositories provisioning. Migrated to stateful sets, migrated ingress to v1
cc @rdstn

cc @yaskoo

I've written down all notes for future improvements and will add them to our backlog.