Key: allow specifying forceLowR for Sign*() methods

/cc @joemphilips

Would you mind to provide more context?

I use this in unit test for my lightning network daemon.
BOLT assumes RFC6979 signer for its test vectors.

To share little more context, This and #741 are from my own fork of NBitcoin.
My plan was to make a PR after finishing all my work, but me and @knocte thought things get easy if it could be merged into master now (or at least to have a feedback ).

Just an small change is required.

Done.
@NicolasDorier can you review/merge?

@knocte instead of having an optional parameter, can you instead make an overload?
Adding optional parameter is a breaking change that ask libraries which depends on NBitcoin to be rebuilt, while adding an overload will make the new NBitcoin library just work without recompiling.


[ImgBot] Optimize images

null
Microsoft Reviewers: Open in CodeFlow

Seems fine to me, but I will let @denelon take a look to make sure that the actual images we care about are good.
The images in the subtrees might get stomped in the future, but I don't think we need any of them anyway (could get 100% size reduction by just deleting them really).

I'm fine with the space saved here. I don't know if there is a decent way to determine if any of these can safely be deleted or not.

I think the only and best way would be to simply delete them in a PR and see.


Problem with nginx reload when an ingress has more than one host configured with tls enabled

Hi,
I think the reload doesn't work in the following case:
If you create an ingress with one host, enable tls for it and let kube-lego to issue a certificate, it works nice:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    kubernetes.io/ingress.class: nginx
    kubernetes.io/tls-acme: "true"
  labels:
    foo: bar
  name: my-ingress
  namespace: hosting
spec:
  rules:
  - host: my.domain.cz
    http:
      paths:
      - backend:
          serviceName: my-service
          servicePort: 80
        path: /
  tls:
  - hosts:
    - my.domain.cz
    secretName: my-secret

I can see from the log that the controller notices the ingress change, then it don't find the secret, because kube-lego is working on it, but once it's finished, the secret is added to the local store and nginx is reloaded.
I0912 18:59:57.713489       5 event.go:218] Event(v1.ObjectReference{Kind:"Ingress", Namespace:"hosting", Name:"my-ingress", UID:"9216396a-97ec-11e7-b000-062bd6dfd378", APIVersion:"extensions", ResourceVersion:"26522748", FieldPath:""}): type: 'Normal' reason: 'CREATE' Ingress hosting/my-ingress
I0912 18:59:58.111156       5 controller.go:477] backend reload required
I0912 18:59:58.203727       5 controller.go:486] ingress backend successfully reloaded...
W0912 19:00:18.108475       5 backend_ssl.go:41] error obtaining PEM from secret hosting/my-secret: secret named hosting/my-secret does not exist
W0912 19:00:18.110262       5 controller.go:1215] ssl certificate "hosting/my-secret" does not exist in local store
I0912 19:00:18.111127       5 controller.go:477] backend reload required
I0912 19:00:18.202267       5 controller.go:486] ingress backend successfully reloaded...
W0912 19:00:21.443465       5 controller.go:1215] ssl certificate "hosting/my-secret" does not exist in local store
I0912 19:00:24.776136       5 backend_ssl.go:58] adding secret hosting/my-secret to the local store
I0912 19:00:24.778968       5 controller.go:477] backend reload required
I0912 19:00:24.870096       5 controller.go:486] ingress backend successfully reloaded...

The problem is when you add another host:
apiVersion: extensions/v1beta1
kind: Ingress
metadata:
  annotations:
    kubernetes.io/ingress.class: nginx
    kubernetes.io/tls-acme: "true"
  labels:
    foo: bar
  name: my-ingress
  namespace: hosting
spec:
  rules:
  - host: my.domain.cz
    http:
      paths:
      - backend:
          serviceName: my-servce
          servicePort: 80
        path: /
  - host: another.domain.cz
    http:
      paths:
      - backend:
          serviceName: my-servce
          servicePort: 80
        path: /
  tls:
  - hosts:
    - my.domain.cz
    - another.domain.cz
    secretName: my-secret

After the certificate is issued, nginx don't reload:
W0912 19:05:23.815734       5 controller.go:1222] ssl certificate hosting/my-secret does not contain a Common Name or Subject Alternative Name for host another.domain.cz
I0912 19:05:24.778135       5 controller.go:477] backend reload required
I0912 19:05:24.865789       5 controller.go:486] ingress backend successfully reloaded...
<IP_ADDRESS> - [<IP_ADDRESS>] - - [12/Sep/2017:19:05:26 +0000] "GET /.well-known/acme-challenge/_selftest HTTP/1.1" 200 16 "-" "Go-http-client/1.1" 139 0.001 [kube-system-kube-lego-nginx-8080] <IP_ADDRESS>:8080 16 0.001 200
I0912 19:05:28.902282       5 backend_ssl.go:53] updating secret hosting/my-secret in the local store

You have to trigger the reload by another ingress modification for example, then the secret is picked up and the host is redirected to https…
Maybe #991 and #1032 broke this a bit?
I'm trying to fix it, but I'm having hard time I have to say…I'll continue anyway, but any hint is very appreciated.

@stibi please use quay.io/aledbf/nginx-ingress-controller:0.218


onPress causes events to propagate to underlying elements for touch devices

🐛 Bug Report

I'm using the usePress hook (part of @react-aria/interactions) to create a custom react component, which I call OnPress.  I have a page setup with multiple layers to simulate having a modal overlapping some content.  I open up Chrome Dev Tools and go to the Device Toolbar, which is able to emulate tablets and phones and other devices with touch interfaces, then I tap or click on an OnPress element.
🤔 Expected Behavior
My OnPress component that makes use of the usePress hook would not cause interaction with elements in a layer underneath it.
😯 Current Behavior
Tapping on my OnPress component causes elements in the layer underneath it to be interacted with.  An anchor tag will visit its href, a div with an onClick attribute will fire its callback.  This only happens with tablets and mobile devices, not in a desktop browser.
💁 Possible Solution
Is there a workaround for this?  If I could call e.stopPropagation() that would presumably be how to fix it, but the event object usePress gives access to does not seem to have stopPropagation.
🔦 Context
This is a problem when trying to put an OnPress component into a modal in many places throughout my app.  Anything the modal overlaps could be triggered if the OnPress lines up with it.
💻 Code Sample
In this example, there is an open button, which opens the "modal".  After that, there are 3 close buttons.  Clicking "Close 1" does not cause an issue because it has plain text underneath it.  Clicking "Close 2" will trigger the anchor tag below it and clicking "Close 3" will trigger the onClick of the div element underneath it.
It is not possible to call e.stopPropagation() in the function that gets passed as the onPress to the usePress hook, as this will cause an error, presumably because usePress creates some kind of wrapper event around the actual event.
https://codesandbox.io/s/react-aria-usepress-propagation-hrdzve?file=/src/App.js
Using Chrome, open the example in a new window or go here: https://hrdzve.csb.app/
🌍 Your Environment
@react-aria/interactions: 3.9.1
Google Chrome, Dev Tools, Device Toolbar
Version 103.0.5060.53 (Official Build) (64-bit)
Set Dimensions to any phone, tablet, or even just Responsive will cause this to happen.
Operating systems:
macOS Monterey (12.4)
Linux Mint 20.2

Thanks for the issue, closing as a duplicate https://github.com/adobe/react-spectrum/issues/1513


Manual release strategy

Which issue(s) this PR fixes:

Fixes #
What this PR does / why we need it:
Because our Shipit is kinda broken to cut releases in pypi, here is the safe procedure to do it manually. This can only be done by Shopify's employees
Tophat
✅
 ❯ make publish
Ask your lead to get access to PYPI_PASSWORD_SHOPIFY
exit 1
make: *** [publish] Error 1

 ❯ PYPI_PASSWORD_SHOPIFY=AAA make publish
You can only publish a new package if you are on the main branch
exit 1
make: *** [publish] Error 1

Does this PR introduce a user-facing change?:

Update the RELEASING process

Aren't public repos supposed to use Github actions and not shipit? https://development.shopify.io/engineering/deploying_and_running/overview/github_actions_index

Aren't public repos supposed to use Github actions and not shipit? https://development.shopify.io/engineering/deploying_and_running/overview/github_actions_index

Looking at other open source project, they all use shipit. But the pypi creds are wrong ...
We could use GH actions but in that case, we need to have the creds hidden and make sure no one can modify and run a GH action beside us (so that you cannot just echo PYPI_CREDS


POST request fails with 400 Failed to load the submitted data due to invalid formatting

I am currently working on integration between PocketBase and EmberData.
By default EmberData (and many other data libraries) send on POST request Content-Type: application/vnd.api+json which fails at this moment (v 0.17.2) with wrong error.
{
    "code": 400,
    "message": "Failed to load the submitted data due to invalid formatting.",
    "data": {}
}

As I can see in code here it should result with more informative error.
Unfortunately I cannot help fix this issue, but I thought it would be good to point it out.
Thanks for your time.

This is expected as we support only application/json and multipart/form-data requests.
You can get more detailed errors if you start the executable with --debug or check the request logs in the Admin UI > Logs.

Thanks for fast reply, missed info about --debug option, will definitely use it more.
👍


[cluster-test] Use master_ prefix instead of upstream_

@mgorven requested this since they want to deprecate upstream_xxx

@bors-libra delegate+
Can you add a brief description for this change?

:v: @andll can now approve this pull request

@bors-libra r=ankushagarwal

:pushpin: Commit 3add959 has been approved by ankushagarwal

:hourglass: Testing commit 3add95926d85ebe8ecdbbbb7c3eb4bec2fadf440 with merge cc91f328429a2f09085880d5190ec116aba8ee44...

:sunny: Test successful - checks-circle_commit_workflow
Approved by: ankushagarwal
Pushing cc91f328429a2f09085880d5190ec116aba8ee44 to master...


fix: pgsql DoExec Transaction checks

Codecov Report

Merging #2101 (8095cb4) into master (a0619f7) will increase coverage by 0.03%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2101      +/-   ##
==========================================
+ Coverage   76.46%   76.49%   +0.03%
==========================================
  Files         517      517
  Lines       46868    46867       -1
==========================================
+ Hits        35839    35853      +14
+ Misses       9050     9036      -14
+ Partials     1979     1978       -1

Flag
Coverage Δ

go-1.15-386
76.41% <0.00%> (+0.04%)
:arrow_up:

go-1.15-amd64
76.40% <0.00%> (+0.02%)
:arrow_up:

go-1.16-386
76.40% <0.00%> (+0.04%)
:arrow_up:

go-1.16-amd64
76.38% <0.00%> (+<0.01%)
:arrow_up:

go-1.17-386
76.45% <0.00%> (+0.03%)
:arrow_up:

go-1.17-amd64
76.46% <0.00%> (+0.02%)
:arrow_up:

go-1.18-386
76.42% <0.00%> (+0.04%)
:arrow_up:

go-1.18-amd64
76.38% <0.00%> (+0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

contrib/drivers/pgsql/pgsql.go
61.78% <0.00%> (-0.13%)
:arrow_down:

container/gmap/gmap_hash_str_str_map.go
97.01% <0.00%> (+0.99%)
:arrow_up:

os/gfsnotify/gfsnotify_watcher.go
84.03% <0.00%> (+2.52%)
:arrow_up:

os/gfile/gfile_scan.go
85.55% <0.00%> (+3.33%)
:arrow_up:

os/gfsnotify/gfsnotify_watcher_loop.go
83.19% <0.00%> (+5.04%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hailaz 请跟进。


fix: quick start guide contents

Fixing some typos in QSG, 1 broken link and 1 wrong url in an API example

Fixed wrong mediator version and minor updates

We have made changes into the Typescript SDK demo and the mediator to fix couple things.
Mediator couldn't be deployed with the old version.
Typescript SDK states that u must copy a did in a field that no longer exists, was moved to another screen (which had a bug)
@curtis-h is now gonna make some changes to this PR or the TS repo with the content that changed, etc.


Markdown rendering for Svelte does not work with content nested in html tags like

Describe the bug
The rendering of markdown contents breaks when there is nested content in html tags like
Example:

  Examples

```
// Amazing code
```

Marked parses the contents correctly, but probably not in the expected way.
The resulting tokens for the above example are (abbreviated):
[
  {"type": "html", "text": "\n  Examples"},
  {"type": "code", "code": "// Amazing code" }
  {"type": "html", "text": ""}
]

Notice how the opening  and its corresponding closing tag  are in separate tokens.
Then the rendering - the recursive component instantiation - does its thing.
But the MarkdownHtml component, relies on the svelte {@html} directive, and messes things up (because of the unexpected token structure).
The {@html} directive implicitly closes unterminated tags. Which is the root cause of the problem.
Technically, marked parsed things correctly, because if the html it would produce was just joined together and rendered as a whole, things would work fine.
Reproduction
Try to render the following in svelte:

  Examples

```
// Amazing code
```

Logs
No response
System Info
"svelte": "^4.2.8",
"@sveltejs/kit": "^1.30.4",

Any browser, though tried with Firefox.

Severity
Serious, but I can work around it

Thank you for raising this and for investing. Ir this is a bug in Marked itself, this may be difficult to work around.
I'll have a look into it when I have some free time, but it might take a little while. Contributions are always welcome if this is urgent. 🙂

I am currently trying to use the container extension as a workaround.
(Unrelated, but I am having trouble getting the extension picked up at all)
Because the container extension seems nice in that it already tracks the opening and closing blocks, I believe something like this would work:

    marked.use({
      hooks: {
        preprocess: (md) => md.replace(/<(\/?)(details|summary)(\s[^>]*)?>/gi, (whole, closing, tag, options) =>
            closing?.length ? `\n:::\n` : `\n:::html-${tag}${options}\n`)
      },
      extensions: [
        extensions.containerExtension((params: TokenExtractionParameters) => {
          if (!params.type.startsWith("html-")) return null;
          return {
            type: params.type,
            raw: params.raw,
            props: params.options,
            tokens: []
          };
        })
      ]
    });

I specifically look for just details and summary tags here, but it should work with all other tags too (from the limited set that are fine in markdown)


[Flow-Aggregator] Agent side changes for Flow Aggregator

Agent side changes for Flow Aggregator
With this PR, if FlowExporter feature is enabled and flowCollectorAddr
can be used to take in as input address for both flow aggregator and external flow collector.
We resolve the flow aggregator IP using the static DNS name: "flow-aggregator.flow-aggregator.svc".
Default for flowCollectorAddr is "flow-aggregator.flow-aggregator.svc:tcp"
In addition, modified antrea-agent base manifest to set appropriate
DNS policy.
This is dependent on PR #1596 and will be merged after it. Please look for the latest commit.

Codecov Report

Merging #1629 (4d94469) into feature/flow-aggregator (408ce60) will increase coverage by 8.21%.
The diff coverage is 36.82%.

@@                     Coverage Diff                     @@
##           feature/flow-aggregator    #1629      +/-   ##
===========================================================
+ Coverage                    48.31%   56.53%   +8.21%
===========================================================
  Files                          177      184       +7
  Lines                        15001    15477     +476
===========================================================
+ Hits                          7248     8750    +1502
+ Misses                        6824     5774    -1050
- Partials                       929      953      +24

Flag
Coverage Δ

e2e-tests
?

kind-e2e-tests
43.61% <61.70%> (?)

unit-tests
40.20% <33.48%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

pkg/ipfix/ipfix_collector.go
0.00% <0.00%> (ø)

pkg/ipfix/ipfix_intermediate.go
0.00% <0.00%> (ø)

pkg/ipfix/ipfix_registry.go
100.00% <ø> (ø)

pkg/flowaggregator/flowaggregator.go
10.56% <10.56%> (ø)

cmd/antrea-agent/options.go
34.40% <72.72%> (ø)

pkg/agent/flowexporter/exporter/exporter.go
73.52% <77.14%> (-4.19%)
:arrow_down:

pkg/ipfix/ipfix_process.go
100.00% <100.00%> (ø)

pkg/ipfix/ipfix_set.go
100.00% <100.00%> (ø)

pkg/antctl/transform/networkpolicy/transform.go
0.00% <0.00%> (-60.00%)
:arrow_down:

.../agent/flowexporter/connections/conntrack_linux.go
28.37% <0.00%> (-50.01%)
:arrow_down:

... and 93 more

/test-all

Nits.

Thanks addressed.

/test-all


Database config files for AGE

Hello,
Besides PostgreSQL 11 configuration file, is there any configuration file that comes (or gets installed) specifically with AGE?
I am asking this because we are developing an web-based database admin application for both AgensGraph and AGE (on PostgreSQL 11).
Thanks

I think the config file mentioned here is about GUC.
maybe, it will be used for user-selectable areas of optimization or experimental features.
I don't think AGE has reached that stage yet.


Grabbing Rubics cube

In testing today we were using the servo to move the rubics cube successfully (yay!) but in using the power screw to bring in the rubics cube we had some issues where there was not enough room for error to successfully grab the cube without jamming.
This requires further testing and posibly some changes to the cube manipulator

I think we need to take the red pads off the gripper.

Everything worked, the robot was awesome, we won the competition and have been nominated for a nobel prize.


hostile_fleet(): Get destination type or name

Currently we only get the destination coordinates of the attacked/spied target.
Is it possible to extract the destination "type" (as in constants: planet, debris, moon) or the name of the destination?
With those information one can easily get the id of planet/moon and save ships and resources just in time.
For friendly fleet i've found:

PLANET-NAME
and

MOON-NAME
Maybe someone with more frequent access to hostile fleet data can help us out.

its an list align problem. The html only provides the 3 digits of coords.
yeah the figure way would be the solution. i remember beeing hard to implement it to always work.
for now i suggest evacuating the moon and the planet

I found a way to get the destination type
7141062eb5bf2496b91bb0c720e3564300cc92ea


New version: Mozilla.Firefox.ESR.sl version 128.4.0

Created by 🥟 Dumplings.
Microsoft Reviewers: Open in CodeFlow

@wingetbot run


On Demand price -- Yahoo API

Prices for Stock in different markets, Last low and high, increase/decrease percent and points
i/p = stock name

Solved by preparing finCLI's own news-api


win: remove unused static variables

default_loop_struct and default_loop_ptr seem to have been overlooked
in commit 32747c7 ("win,unix: move loop functions which have identical
implementations".)
CI: https://ci.nodejs.org/job/libuv-test-commit/155/

Seems like I did.


MAP_POPULATE is not supported on Solaris

The storage/backend/boltoption_unix.go file uses MAP_POPULATE as boltdb option but this only works on Linux. there should be solaris-specific version that doesn't use it.

@akolb1 Can you try to fix it? Thanks for reporting!

@xiang90 Sure, I'll take a look at it

Here is the patch:

diff --git a/storage/backend/boltoption_solaris.go b/storage/backend/boltoption_solaris.go
new file mode 100644
index 0000000..856febd
--- /dev/null
+++ b/storage/backend/boltoption_solaris.go
@@ -0,0 +1,19 @@
+// Copyright 2015 CoreOS, Inc.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package backend
+
+import "github.com/coreos/etcd/Godeps/_workspace/src/github.com/boltdb/bolt"
+
+var boltOpenOptions *bolt.Options = nil
diff --git a/storage/backend/boltoption_unix.go b/storage/backend/boltoption_unix.go
index bd676a5..b20a713 100644
--- a/storage/backend/boltoption_unix.go
+++ b/storage/backend/boltoption_unix.go
@@ -12,7 +12,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.

-// +build linux solaris
+// +build linux

 package backend

@xiang90 What should be the commit message?

@akolb1 storage/backend: add support for Solaris?

https://github.com/coreos/etcd/pull/4128

Solaris can use madvise(3C) with MADV_WILLNEED but this is a more extensive change and requires changes to boltdb (and GO support).

@gyuho I am going to close this. This is actually a boltdb issue rather than etcd issue. @akolb1 has fixed etcd part.

Ok thanks,


register::control::set_npriv can be used to subvert critical sections

Because of #233, the control::set_npriv operation can be used to silently subvert all future critical sections, and likely needs to be unsafe, since your safety properties rely on critical sections working.
(I linked #233 for context but it's not clear that "fixing" it changes this issue: set_npriv causes a program compiled assuming privileged mode to leave privileged mode.)

Nevermind - set_npriv just alters bits, doesn't write the register. I misread. Closing.


[google-cloud-cpp{,-common}] upgrade to latest release

Upgrade gooogle-cloud-cpp and google-cloud-cpp-common to the latest release. Both need to be updated in a single PR.

What does your PR fix? Fixes issue #

N/A

Which triplets are supported/not supported? Have you updated the CI baseline?

No changes to the CI baseline.

Does your PR follow the maintainer guide?

Yes.

The Linux break seems unrelated. PTAL.

Agreed, thanks for the PR!


x509 workflow in clean architecture

Description
The x509 needs to be ported to the new architecture introduced in #117. The ideal x509 workflow will be revisited in a later release #140 , however for the initial releases, we will stick to the following:

Browser request made to rucioAuthServer directly ( bypassing gateway). The response from /auth/x509_web endpoint is handled in the page itself, instead of the presentation layer.
The page then makes a request tot he NextJS server ( POST /api/auth/x509) with the rucioAuthToken in the body.
The NextJS server sets the session

Motivation
No response
Change
No response
Additional Information

[X] The Rucio API needs to be changed.

Re-opening as we should add a SetSessionForX509LoginUseCase instead of setting session directly in the NextJS API endpoint


vc: make host shared path readonly

[backport from master commit a3dec262c5d750c3b7201e19bb504b1ca22c30a9]
We need to make sure containers cannot modify host path unless it is explicitly shared to it. Right now we expose an additional top level shared directory to the guest and allow it to be modified. This is less ideal and can be enhanced by following method:

create two directories for each sandbox:
-. /run/kata-containers/shared/sandboxes/$sbx_id/mounts/, a directory to hold all host/guest shared mounts
-. /run/kata-containers/shared/sandboxes/$sbx_id/shared/, a host/guest shared directory (9pfs/virtiofs source dir)
/run/kata-containers/shared/sandboxes/$sbx_id/mounts/ is bind mounted readonly to /run/kata-containers/shared/sandboxes/$sbx_id/shared/, so guest cannot modify it
host-guest shared files/directories are mounted one-level under /run/kata-containers/shared/sandboxes/$sbx_id/mounts/ and thus present to guest at one level under /run/kata-containers/shared/sandboxes/$sbx_id/shared/

Fixes: #2712

/test

@jcvenegas @GabyCT  I have restarted failing CIs. Can you provide input if any of these are not expected to pass. I havent paid attention to the CI jobs lately.


TagHelpers won't work in @... code blocks

MVC does not support using tag helpers in @<text></text> blocks.
I have a method which waits Func<object, HelperResult> type argument to accept html codes sent from views.
It is like:
public void Html(Func<object, HelperResult> html)
{
    //...
}

View code:
@MyObject.Html(@Foo)

And I receive this error:

The 'await' operator can only be used within an async lambda expression. Consider marking this lambda expression with the 'async' modifier.

 __tagHelperExecutionContext.Output = await __tagHelperRunner.RunAsync(__tagHelperExecutionContext);

and
await WriteTagHelperToAsync(__razor_template_writer, __tagHelperExecutionContext);

Will this be supported?

Yeah, looks like a bug.

Moved over to Razor https://github.com/aspnet/Razor/issues/494


ADS: Fireproof Websites screen migration

Task/Issue URL:
Description
Steps to test this PR
Feature 1

[ ]
[ ]

UI changes

Before
After

!(Upload before screenshot)
(Upload after screenshot)

Current dependencies on/for this PR:

develop

PR #2587

PR #2594   👈
PR #2590
PR #2588

This comment was auto-generated by Graphite.


:art::building_construction: Review and rewrite request, response and message classes and respective subclasses from pigeon.http

Proposal @raspitim

from outside they should behave exactly the same as before @raspitim
but rewriting like this allows for easier handling of complex headers that may need surgical precision when editing (e.g. cookies)

optionally HTTPHeaders._headers could also be a custom utils.commons.ParameterDict:
class CustomParameterDict(ParameterDict):
def getitem(self, key):
return super().getitem(key.lower())

Why don't we move protocol, path and method to HTTPMessage and only modify the methods of HTTPRequest and HTTPResponse?

And also, what about the HTTPRequests credentials attribute?

optionally HTTPHeaders._headers could also be a custom utils.commons.ParameterDict:
class CustomParameterDict(ParameterDict): def getitem(self, key): return super().getitem(key.lower())

I think this option would be most coherent with our use of data structures in similar situations (like dynamic params)

Why don't we move protocol, path and method to HTTPMessage and only modify the methods of HTTPRequest and HTTPResponse?

HTTPResponses don't have path or method. They do use a certain protocol of course though.

And also, what about the HTTPRequests credentials attribute?

That one I forgot as well
The ParameterDict class used for HTTPHeaders._headers would be:
class LowerParameterDict:
    def getitem(self, key):
        return super().getitem(key.lower())

markdown at https://pastebin.com/tqNA86SS

Just realised that GitHub Issues support mermaid ClassDiagrams - don't know where they weren't supported - I think release notes..
classDiagram
direction TD

class HTTPHeader {
	+ name: str
	- _directives: list[str, ...]

	+ __init__(self, name, directives) -> HTTPHeader
	+ @property value(self) -> str
	+ __str__(self) -> str
}

class HTTPHeaders {
	- _headers: LowerParameterDict

	+ __init__(self, headers: dict | list[HTTPHeader, ...]) -> HTTPHeaders
	+ get(self, key) -> str
	+ set(self, key, value) -> None
	+ __getitem__(self, key) -> str
	+ __setitem__(self, key, value) -> None
	+ __str__(self) -> str
}

class HTTPData:::abstract {
	+ __str__(self) -> str
}

class HTTPMessage:::abstract {
	+ headers: HTTPHeaders
	+ data: HTTPData
	+ cookies: ?ParameterDict

	+ __str__(self) -> str
	+ __init__(self) -> HTTPMessage
}

class HTTPRequest {
	+ protocol: str
	+ method: str
	+ path: str
	+ get: ParameterDict
	+ files: ParameterDict
	+ credentials: Credentials

	+ __str__(self) -> str
	+ __init__(self) -> HTTPRequest
}

class HTTPResponse {
	+ protocol: str
	+ path: str
	+ method: str

	+ __str__(self) -> str
	+ __init__(self) -> HTTPResponse
}

HTTPHeader o-- HTTPHeaders
HTTPHeaders o-- HTTPMessage
HTTPData o-- HTTPMessage
HTTPMessage <|-- HTTPResponse
HTTPMessage <|-- HTTPRequest

@raspitim
The question whether to add cookies highlights a rather general question of how strictly we should tailor the classes towards the standard middleware. Currently HTTPResponse and HTTPRequest objects have a lot of attributes set externally and not in init which I would say is not really clean code. (see e.g. this stack overflow post)
I think tailoring them more toward our middleware is not even a problem, as long as we do not actually add attributes that are specific to our middleware, but can work with user-written middleware as well.
So I would say adding HTTPRequest.credentials and HTTPMessage.cookies is a necessity for code readability and usage as it allows for both easier processing and better usage.
We'll need to have a look at what to do with middlewaretags another time , though they are as well - very  unspecific, they still seem to incorporate middleware deeply inside elements that are not necessarily bound to the middleware.

I think we could also add shortcuts for certain headers such as the Content-Type header for example.:
class HTTPMessage:
    @property content_type(self):
        return self.headers.content_type

though as I am writing this I do realise the small gap between implementing it and just going with message.headers.content_type. maybe we should not use any shortcuts like these internally but allow developers to use them if they want.

let's have HTTPHeaders inherit from LowerParameterDict - just need to manage setting headers like content-type etc.

I'm not sure if the shortcuts are necessary but I'm in with adding more attribute directly to the __init__ method of HTTPResponse and HTTPRequest

got headers working through aggregation for now - this will suffice for now as it implements all external features very nicely.
this allows accessing e.g. the content-type header over headers.content_type

implemented HTTPMessage as shown in diagram apart form cookies (will be added on feature branch in future)

done in 5bb792e27c4953e76ab203a7ad14c3038cdf8d9d

implemented:
classDiagram
direction TD

class HTTPHeader {
	+ name: str
	- _value: Any

	+ __init__(self, name, directives) -> HTTPHeader
	+ @property value(self) -> str
	+ @value.setter value(self, value) -> None
	+ __str__(self) -> str
}

class HTTPHeaders {
	- _headers: LowerParameterDict

	+ __init__(self, headers: dict[str, str]=None) -> HTTPHeaders

	+ __getattr__(self, key) -> str
	+ __setattr__(self, key, value) -> str
 	+ __getitem__(self, key) -> str
	+ __setitem__(self, key, value) -> None
	+ items(self)
	+ keys(self)
	+ contains(self, key)
	+ __str__(self) -> str
}

class HTTPData:::abstract {
	+ __str__(self) -> str
}

class HTTPMessage:::abstract {
	+ headers: HTTPHeaders
	+ data: HTTPData
	+ protocol: str

	+ __init__(self, headers: dict[str, str], data: str, protocol: str, content_type=None) -> HTTPMessage
	+ @property is_error(self) -> bool
	+ set_headers(self, headers:dict) -> None
	+ __str__(self) -> str
	+ __bytes__(self, encoding='utf-8') -> bytes
}

class HTTPRequest {
	+ method: str
	+ path: str
	+ get: ParameterDict
	+ files: ParameterDict
	+ auth: Credentials

	+ __init__(self, method: str, path: str, headers: dict = None, get: dict = None, data=None, files=None, protocol: str='1.1', content_type=None) -> HTTPRequest
	+ @property is_error(self) -> bool
}

class HTTPResponse {
	+ status: int

	+ __str__(self) -> str
	+ __init__(self, headers: dict = None, data: str = None, status: int = 200, cookies=None, protocol: str = '1.1', content_type=None) -> HTTPResponse
	+ @property is_error(self) -> bool
	+ __bytes__(self, encoding='utf-8') -> bytes
}

HTTPHeader o-- HTTPHeaders
HTTPHeaders o-- HTTPMessage
HTTPData o-- HTTPMessage
HTTPMessage <|-- HTTPResponse
HTTPMessage <|-- HTTPRequest


dns: bypass EDNS query

Signed-off-by: Boteng Yao<EMAIL_ADDRESS>DNS filter will ignore the additional RRs as EDNS could have them, the filter will fall back to the traditional behavior.
Issue #22676.

Commit Message:
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @yanjunxiang-google

/assign @yanavlasov

/wait

LGTM


nm: Extend debug logging information for connections

The connection profile lifecycle is now better logged, assisting with
debugging of edge scenarios.

Coverage remained the same at 73.425% when pulling 52c07354a60751b401019baa986509ab9aa5ddf0 on EdDev:nm-connection-debug-info into 6d99821bd0907af8eee080b16903505d18a7540b on nmstate:master.


SLIM-128

Replace keys

SonarQube analysis reported 13 issues:

 10 major
 3 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Complete the task associated to this TODO comment.

All is well.

This pull request makes the build fail.

SonarQube analysis reported 11 issues:

 8 major
 3 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
 Complete the task associated to this TODO comment.

All is well.

SonarQube analysis reported 11 issues:

 8 major
 3 info

Watch the comments in this conversation to review them.
Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Remove the unused method parameter(s) "organisationIdentification".
 Complete the task associated to this TODO comment.

All is well.


Add login after signup and enhance validation

Description
Fixes # (issue)
Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[ ] Complete, but not tested (may need new tests)
[x] Incomplete/work-in-progress, PR is for discussion/feedback

How Has This Been Tested?

[ ] Test A
[ ] Test B

Checklist

[ ] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] There are no merge conflicts

The development database is not responded.  I was unable to execute and see the creation of a new user than opening of the HOME view (login after signup).


[com.google.fonts/check/STAT/gf-axisregistry] Ensure STAT table has Axis Values

If a variable font doesn't contain any Axis Values, the following traceback is raised when using the googlefonts profile:
    * ERROR: Failed with AttributeError: 'NoneType' object has no attribute 'AxisValue'
           File "/Users/marcfoley/Type/upstream_families/robotoserif/venv/lib/python3.7/site-packages/fontbakery/checkrunner.py", line 366, in _exec_check
             for sub_result in result:  # Might raise.
           File "/Users/marcfoley/Type/upstream_families/robotoserif/venv/lib/python3.7/site-packages/fontbakery/profiles/googlefonts.py", line 4776, in com_google_fonts_check_STAT_gf_axisregistry_names
             for axis_value in ttFont['STAT'].table.AxisValueArray.AxisValue:

This is happening in the check com.google.fonts/check/STAT/gf-axisregistry.
The check just assumes that the STAT table will contain Axis Values, when this may not be the case. Since we do expect Axis Values, my pr will fail the check if the STAT AxisValueArray is empty.

thanks, @m4rc1e


Update MD file on new branch 2017-11-15_01-26-43

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

split/updateTestRef1.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


chore: bluebook download and event

Signed-off-by: rogerogers<EMAIL_ADDRESS>What type of PR is this?

chore: bluebook download and event
What this PR does / why we need it (en: English/zh: Chinese):

en: bluebook download and ga event
zh: 项目介绍下载和ga事件上报。
Which issue(s) this PR fixes:

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


✨ Feature Suggestion | Upgrade MetaGer to card

Description
Currently MetaGer is listed in the "Worth Mentioning" section here. I propose upgrading them to their own card. I think they stand out enough to warrant this:

Run by non-profit
Runs onion service
Open-source
Offers anonymous proxy service similar to Startpage's "Anonymous View"
Metasearch engine, "We query up to 50 search engines."
Since 1996
Bonus: "We only use green electricity for our servers."

I use them and completely agree. Only problem I've had is that links (for example to wikipedia) often come up in German.

I use them and completely agree. Only problem I've had is that links (for example to wikipedia) often come up in German.

Hmm maybe you need to specify the language in the settings. Or try their other English version, https://metager.de/en, or English test version, https://metager3.de/en/. Or maybe you have an about:config option that’s causing the language in the request header to be dropped 🤔

Ahh, that might be it. I'll try the english version. Otherwise full marks.

@lynn-stephenson didn't you have some quarrells with MetaGer?

@lynn-stephenson didn't you have some quarrells with MetaGer?


Make sure that custom service code's prints are not buffered

Issue #, if available:
Description of changes:
To run CI tests on your changes refer README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@vdantu Has this been tested locally in a docker container ?


Look at quote crate for codegen

I was shown quote at PDXRust.  It'd be nice to see if we can use that to improve our code generation instead of creating and writing strings.

Sounds interesting. I wonder how this would impact build performance? Maybe we should do a little test to make sure it doesn't throw build performance in the trash?
Although hopefully it'll allow us to take out some of that generation time.

Just a heads-up that I’m trying this out at the moment. So far things are looking good!
Syntax-wise, quote is a lot nicer. In vscode I get proper syntax highlighting, parenthesis balancing, etc. plus some of the string escape logic can go away (and is safer in places where it was missing).
A first impression of performance is that compile time for the crategen binary goes up, and runtime goes down slightly. No surprises there I guess. Once I make enough progress to be meaningful, I’ll report back with some performance numbers.

This issue is getting a bit old and we haven't tried it out yet. Any objections to closing this for now?

Fine by me! This would be a bigger refactor, and we seem to be okay with writeln-style codegen for the moment.


Added VS Code IDE support documentation (browser and desktop setup instructions)

Thanks for contributing to the Harness Developer Hub! Our code owners will review your submission.
Description

Please describe your changes: __________________________________
Jira/GitHub Issue numbers (if any): ______________________________
Preview links/images (Internal contributors only): __________________

PR lifecycle
We aim to merge PRs within one week or less, but delays happen sometimes.
If your PR is open longer than two weeks without any human activity, please tag a code owner in a comment.
PRs must meet these requirements to be merged:

[ ] Successful preview build.
[ ] Code owner review.
[ ] No merge conflicts.
[ ] Release notes/new features docs: Feature/version released to at least one prod environment.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step behind the Harness VPN and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app. Current Draft URL is: https://672e5e393fe0b6164cbd1ba0--harness-developer.netlify.app

@dewan-ahmed @rustd @SushrutHarness Let me know if this looks good.


Bad memory management

Each time loading model and saving "clean" version takes more and more RAM. I can barely clean up two models before hitting ceiling with swap partition being full.
Possible memory leak?

Are you seeing any error? Theres a memory leak that can happen if the webui destroys and recreates the extension (like when doing "Reload UI"), leaving the loaded model still in memory.

Nothing error-like in console. I do not have any python background so I cannot help with debug without any help.
One thing which I suspect is that garbage collector is not running properly. I am using https://github.com/AbdBarho/stable-diffusion-webui-docker repo to run SD. There has been some issues reported with Python 3.10.x like this one: https://github.com/python/cpython/issues/98801 and @AbdBarho's repo is using Python v3.10.9.
Maybe there could be some simple fix like calling gc.collect() in strategic places (where?) to test it?

Can try, i added the GC calls where needed in 4c99665a9723dc96b976dca1648d9a9487f547e5. Pythons normal behavior is to hold onto memory after the model is freed, and use this reserved memory before requesting more.

Nope. Still same behavior :(
But I've found some pattern during tests. It seems that python has some memory threshold before it is freeing memory and for unknown reasons it is also taking swap space into account as available memory. So it is exhausting 16GB regular RAM, then using swap (20GB reserved) until it hits some limit and then memory do not grow anymore.
This of course is not your code fault, so I am closing this issue, but many people are using docker or other container solutions to run SD, so it would be nice if there is some info for them about this python memory management issues.
Now I have to make some research how to force python not to use entire RAM+SWAP for memory management purposes :(
Thank you one more time!

@DevilaN Hi there. Have you made any progress in improving memory management?


Guideline on how to organise asuccesful community repair cafe.

Feel free to have discussions pertaining the guidelines,repair setup here


Merging staging-app2 in to master.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To complete the pull request process, please assign ushankar208
You can assign the PR to them by writing /assign @ushankar208 in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SO-ashusrivastava
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SO-ashusrivastava, soSkumar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: SO-ashusrivastava, soSkumar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ApoorvaSrivastava, SO-ashusrivastava, soSkumar
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ApoorvaSrivastava, bharatsinghoh, SO-ashusrivastava, so-kushal, soSkumar, vaibhavso
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava,vaibhavso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ApoorvaSrivastava, bharatsinghoh, SO-ashusrivastava, SO-jagjeetsingh, so-kushal, soSkumar, vaibhavso
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava,vaibhavso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ApoorvaSrivastava, bharatsinghoh, neetuoncehub, raghavaggarwalOH, SO-ashusrivastava, SO-jagjeetsingh, so-kushal, soSkumar, vaibhavso
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava,vaibhavso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: ApoorvaSrivastava, bharatsinghoh, neetuoncehub, raghavaggarwalOH, SO-ashusrivastava, SO-jagjeetsingh, so-kaushal, so-kushal, soSkumar, vaibhavso
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [SO-ashusrivastava,so-kaushal,vaibhavso]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/hold cancel
/approve


Fix resources that have not changed are still being updated when using the apply command with the ignore-fields flag

What type of PR is this?
/kind bug

What this PR does / why we need it:
The ignore-fields flag is functional only during the preview stage and cannot be utilized during the apply stage.
Which issue(s) this PR fixes:

Fixes #376
Special notes for your reviewer:
Does this PR introduce a user-facing change?

Fix resources that have not changed are still being updated when using the apply command with the ignore-fields flag.

Additional documentation e.g., design docs, usage docs, etc.:

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

2 of 2 (100.0%)  changed or added relevant lines in 2 files are covered.
7 unchanged lines in 1 file lost coverage.
Overall coverage increased (+0.04%) to 71.771%

Files with Coverage Reduction
New Missed Lines
%

pkg/cmd/destroy/options.go
7
84.08%

Totals

Change from base Build<PHONE_NUMBER>:
0.04%

Covered Lines:
4874

Relevant Lines:
6791

💛  - Coveralls


Improved fastapi-discord examples for session creation

Currently, I am experiencing a problem when using the fastapi-discord module to create a session. Although the callback returns the authentication tokens, I am unable to save the authentication token so that the library recognises that I am authenticated.
Someone can share a full example of login that use this library? This will help users to use the library effectively (and me also :p).
Thank you in advance for your attention to this issue.

Finally I have found how to use this library, here is an example:
from typing import List

from fastapi import Depends, FastAPI, Request
from fastapi.responses import JSONResponse, RedirectResponse
from fastapi_discord import DiscordOAuthClient, RateLimited, Unauthorized, User
from fastapi_discord.exceptions import ClientSessionNotInitialized
from fastapi_discord.models import GuildPreview

app = FastAPI()

discord = DiscordOAuthClient(
    "BOT ID", "BOT SECRET KEY", "REDIRECT URL", ("identify", "guilds", "email")
)

@app.on_event("startup")
async def on_startup():
    await discord.init()

@app.get("/login")
async def login():
    return {"url": discord.oauth_login_url}

@app.get("/auth")
async def callback(request: Request, code: str):
    token, refresh_token = await discord.get_access_token(code)
    return {"access_token": token, "refresh_token": refresh_token}

@app.get("/dashboard", dependencies=[Depends(discord.requires_authorization)])
async def dashboard(user: User = Depends(discord.user)):
    return {"user": user}

if __name__ == "__main__":
    import uvicorn
    uvicorn.run(app, host="localhost", port=8000)

And after that you have your authentication token:
import requests

headers = {"Authorization": "Bearer <access_token>"}
print(requests.get('http://localhost:8000/dashboard', headers=headers).content)


Update tutorial audit log file for TestDiaQeDiaUmpireTutorial

My computer is still generating the audit log files for other languages, but here's what the change is for English.
There is a new line in there about:
Removed suffix = ".mzML"
I'm not sure what changed to cause this to start showing up in the audit log, but I imagine it's not anything to worry about.

Looks like that line was actually removed in the new logs. I'm not sure what caused that, either. :/

Looks like that line was actually removed in the new logs. I'm not sure what caused that, either. :/

Oops. You're right.
I think this failure began with the Hardklör commit on May 6th.

The problem with lots of other tests failing is that you often find less
noisy test were also failing. This is a perfect example and why getting
things fixed as quickly as possible is so important.
On Thu, May 23, 2024 at 12:53 PM nickshulman @.***>
wrote:

Looks like that line was actually removed in the new logs. I'm not sure
what caused that, either. :/
Oops. You're right.
I think this failure began with the Hardklör commit on May 6th.
—
Reply to this email directly, view it on GitHub
https://github.com/ProteoWizard/pwiz/pull/2981#issuecomment-2127914556,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACYBWUCLZIWY5EJROYWEPRTZDZCM7AVCNFSM6AAAAABIGGGQEWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMRXHEYTINJVGY
.
You are receiving this because you are subscribed to this thread.Message
ID: @.***>


update grunt dependencies

to support latest version of grunt.

@TheSavior
@ryanbahniuk not immediately clear to me how the build was passing in the first place - the test and expected output were different.

Nvm, that was a dumb comment - it appears the the output of lighten(#123, 10%) has changed.

awesome, thanks @ryanbahniuk


Icon with bug KDE and LXQT (desconfigured)

Describe the bug
Franz Icon is desconfigured. See print.
Additional context
Add any other context about the problem here.

Same issue present here. Running KDE Neon.


Add ExternalTypeInfoProvider the the key of the ReflectionContext Typ…

…eInfo cache
This change is analogous to the TypeInfo cache in TypeLowering, which does the exact same thing. In LLDB the ExternalTypeInfoProvider may gain new information throughout the life of a process, and more importantly, it may return context-dependent results.
rdar://122432501

@swift-ci smoke test


fix the dead links in Korean doc

fix the dead links in Korean doc

@shibuiwilliam Thanks for the accept! mind if you add a label 'hacktoberfest-accepted' to this PR?
I'm working on hacktoberfest now and it would be really really helpful to finish the event!


[FEATURE] Build test targets into test/ directory and keep the directory structure.

Fixes #44
I hope I did that correctly...

So it is really correct? I copy and pasted from seqan3 and adjusted as best as I could and removed stuff I thought not necessary.

I also changed the dependency issue I think :) Please take a look if it is correct


doc(tutorials): E2E adopter Journey Tutorials review -> Feedback: "The different components"

Description
Please refer to the detailed description in the related section of #480

done


Where is ExplorerItem defined?

I am copying the code into my project but don't know where to get the source for ExplorerItem

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d5ba995b-8bf3-407c-7b87-015d22d813f1
Version Independent ID: 52c553b6-e94d-2810-4123-8ee215b002bf
Content: Tree view - UWP app developer
Content Source: windows-apps-src/design/controls-and-patterns/tree-view.md
Product: uwp
GitHub Login: @jwmsft
Microsoft Alias: jimwalk

You can find the source here:
https://github.com/Microsoft/Xaml-Controls-Gallery/blob/1ecd85c908a8a1cb9a8201e548f58db379801e69/XamlControlsGallery/ControlPages/TreeViewPage.xaml.cs

@MagnusJohansson Thanks. I see a few of the links on the content source are broken. For example https://github.com/MicrosoftDocs/windows-uwp/blob/docs/uwp/api/windows.ui.xaml.controls.treeview.itemssource

Thanks @kgreed for pointing out the broken link. I've opened Issue #1352 to track it.

Doc has been updated.


Promote Release Candidate 2.6

Make v2.6 the current stable version of Neodigm 55. Version 3.0 is now the alpha.

Update the "Getting Started" roller on the landing page (in the future this will also exist in a soda pop template)
Update all registered alpha sites
Update internal VER properties (comments)
Delete old, old __ alpha version (__v2_5)

I do not plan to promote on social.
Validation command:
neodigmUtils.ver
List of known alpha sites/apps
TSK
Index.html (self)
M5M
SEMb
CHIPS CORP ID
CHIPS SHOP
SYPR
SYPR AGNT
INTERSTELLAR
KRA KINETICS

This is complete, new alpha v3.0 is not available.


[GSSOC'23] Restricting Contact Us Form to Accept Only String Values for Name Field

the contact us form should only accept name if it is a string

This form can also be made to route to another page instead of being part of the home page, as it makes the home page look messed up. I wish to work on this part. Can you please assign this issue to me?

please assign me this issue

contributor are working on it


hugo new /post/test.md Error: could not determine content directory for

What version of Hugo are you using (hugo version)?

$ hugo version
hugo v0.89.4+extended darwin/amd64 BuildDate=unknown

Does this issue reproduce with the latest release?
Yes

Try without the leading slash ("/").

thx it works


[Bug]- Removed Trello Email for Internal Tools

What ❓

Due to the Trello board being full and unmonitored also a HackerOne issue which was flagged to @peat , we agreed to remove this functionality since it isn't used frequently.
Removed the submit feedback button along with the logic to send the email

Story 📖
Bug Trello Account Strings in Android
See 👀

 Bug: Trello Account Strings in Android


BetterDiscord not loading themes

It seems when i post the raw code of a theme into a notepad and save it as a css file and put it in the themes folder, the theme wont show up, why?

theme files have to be named whatever.theme.css
if you need further assistance then join us on discord


undefined is not an object upon import

I am trying to use react-native-material-ui
I get the error:
undefined is not an object context.uitheme.toolbar
i am trying to follow your doc with the next code:
import { Toolbar } from 'react-native-material-ui';
on the render, i returned:
<Toolbar
	searchable={{
		autoFocus: true,
		placeholder: 'Search',
	}}
/>

is there a fix? i am working with react-native 51 and installed your package using npm:
$ npm install react-native-material-ui
npm WARN optional SKIPPING OPTIONAL DEPENDENCY<EMAIL_ADDRESS>(node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for<EMAIL_ADDRESS>wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

+<EMAIL_ADDRESS>added 116 packages and updated 1 package in 21.387s

solved it with the following thread


UI ingestion for kafka-connect lacks of java

Describe the bug
There is no correctly set up Java in Action container (UI ingestion) to process kafka-connect source
To Reproduce
Steps to reproduce the behavior:

Open UI ingestion
create source config for kafka-connect
execute ingestion
observe error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
source:
  type: kafka-connect
  config:
    connect_uri: 'http://kafka-connect.confluent.svc.cluster.local:8083'
    cluster_name: dwh-connect
    connector_patterns:
      allow:
        - '^dwh-.*'
sink:
  type: datahub-rest
  config:
    server: 'http://datahub-datahub-gms:8080'
    token: xxxxx

Error
JVMNotFoundException: No JVM shared library file (libjvm.so) found. Try setting up the JAVA_HOME environment variable properly.

Environment:

EKS 1.22
official chart
core version: 0.8.33
chart version: 0.2.69

When I upgraded to v0.8.40, I got this problem again！

@yuanly Can you please share where you are running DataHub and the image and tag that you are using for actions?

When I using acryldata/datahub-actions v0.0.4, this problem again.
https://hub.docker.com/layers/datahub-actions/acryldata/datahub-actions/v0.0.4/images/sha256-60cbf0081ef0f6db3854a3a8bbbd500480ea69b54863ac6ad819974303191584?context=explore

[root@localhost]# docker exec -it datahub_datahub-actions_1 /bin/bash
datahub@actions:/$ echo $JAVA_HOME
/home/datahub/.sdkman/candidates/java/current

[root@localhost]# docker exec -it -u root datahub_datahub-actions_1 /bin/bash
root@actions:/# echo $JAVA_HOME

root@actions:/#

I'm seeing the same thing in the ingestion image  as well (v.0.8.41, at least)
> docker run -it --user root -v /my/path/recipes:/temp linkedin/datahub-ingestion:v0.8.41 ingest run --dry-run -c /temp/kafka-connect-to-datahub-kafka.yml

[2022-10-28 09:47:42,927] INFO     {datahub.cli.ingest_cli:99} - DataHub CLI version: 0.8.41+docker
[2022-10-28 09:47:42,952] INFO     {datahub.ingestion.run.pipeline:160} - Sink configured successfully.
[2022-10-28 09:47:44,455] INFO     {datahub.ingestion.source.kafka_connect:866} - Connection to <address> is ok
[2022-10-28 09:47:44,456] ERROR    {datahub.ingestion.run.pipeline:126} - No JVM shared library file (libjvm.so) found. Try setting up the JAVA_HOME environment variable properly.
[2022-10-28 09:47:44,456] INFO     {datahub.cli.ingest_cli:115} - Starting metadata ingestion
[2022-10-28 09:47:44,456] INFO     {datahub.cli.ingest_cli:133} - Finished metadata pipeline

Failed to configure source (kafka-connect) due to No JVM shared library file (libjvm.so) found. Try setting up the JAVA_HOME environment variable properly.
No ~/.datahubenv file found, generating one for you...

I believe this was fixed by #6365 or https://github.com/acryldata/datahub-actions/pull/15 - the latest datahub-actions image v0.0.9 should work.
Please let me know if you still have issues @KulykDmytro and we can reopen if necessary.


Terminus apparently doesn't fully remove itself on uninstall

Version: 1.0.120
Platform: win32 10.0.19041
I installed using winget (initialy, then I downloaded the exe setup later). At first it worked with Powershell Core (7). But nothing else would work (cmd, older powershell, etc). I just got a blinking cursor and a failure to create process. Eventually it wouldn't spawn Powershell Core windows either. But that's not what I'm reporting here. I tried to uninstall it (from Programs and Features), hoping to start over with a fresh, working install but when I reinstalled and started it up, it still wouldn't work and it would start up with three tabs, the way I left it when I uninstalled it previously. So it's leaving around some kind of history/config data after uninstall runs.
I tried downloading and using the portable version. Same thing. Are you forgetting to remove some registry keys or something?
Expected behavior: After a uninstall, i should get the initial "wizard" that asks you about a few options. I don't. After an uninstall I should be able to resinstall and whatever config bugs I had before are no longer present.

Same here

This might be an issue with the app packager/installer not terminus itself. I had a similar issue where the app froze and when uninstalling and reinstalling I had the same issue. Once I deleted all cache and installed folders, then it worked like it should.

This might be an issue with the app packager/installer not terminus itself. I had a similar issue where the app froze and when uninstalling and reinstalling I had the same issue. Once I deleted all cache and installed folders, then it worked like it should.


error: no module named '' for local Python modules

I have the following structure:
anpcp/
├─ debugger.py
├─ models/
│  ├─ __init__.py
│  ├─ instance_same_set.py
│  ├─ vertex.py

Among other files inside models/. __init__.py is empty.
In debugger.py I have:
from models.instance_same_set import InstanceSameSet

Then in instance_same_set.py I have:
from models.vertex import Vertex

When I try to run debugger.py with Codon I get the errors like the following:
$ codon run debugger.py

instance_same_set.py:4:6-19: error: no module named 'models.vertex'

This is similar to #176 but I'm not sure where to set CODON_PYTHON in WSL and what to point it to.
Is there a way to compile all the related modules with a single command?
Full repository: https://github.com/netotz/alpha-neighbor-p-center-problem

@netotz In Codon, you can import a file from the same directory using a relative path:
from vertex import Vertex  # Python 2
from .vertex import Vertex  # Python 3


A swipeable drawer for enhancing mobile experience

Close a drawer by swiping gesture is a very common way for mobile user to control UI component like drawer.

Done #14


404 for prebuilt CLI binaries

Issue
When trying to download any prebuilt binary from the links listed in the Binary Releases section of the installation guide (for example Linux (x86_64)) I'm getting 404s.
The source build for the full version also doesn't work for me (running nightly rust 1.78.0 on current pop_OS). I tried cargo install taplo-cli --locked --features lsp  which fails with error[E0635]: unknown feature stdsimd when trying to build ahash.
Workaround
As a workaround I was able to download the current release and manually build + install it using cargo install --path . --features lsp from crates/taplo-cli.

For the first issue, see #542.

Ah great that it's already known :) I searched for similar open issues but didn't find that one

Ah great that it's already known :) I searched for similar open issues but didn't find that one

Same yeah no worries.

Duplicate of #542

The source build for the full version also doesn't work for me (running nightly rust 1.78.0 on current pop_OS). I tried cargo install taplo-cli --locked --features lsp which fails with error[E0635]: unknown feature stdsimd when trying to build ahash.

This still seems like an unresolved issue?

We're working on the next release, let's wait for a while to confirm instead.

This still seems like an unresolved issue? Not sure though.

I just tried again after updating to new nightly and got 3 warnings that ahash v.0.7.6, ahash v0.8.3 as well as crossbeam-channel v.0.5.6 have been yanked from crates.io with the suggested fix of consider running without --locked. Running without --locked indeed makes the install run through.
Related issue in the aHash repo suggests that this has been fixed with ahash v0.8.7 and the fix backported to 0.7 via v0.7.8: https://github.com/tkaitchuck/aHash/issues/200

This last part will be fixed by #556.


Hosts to add custom requirements for additional invoice information

As per @jfdh's feedback: fiscal hosts in Europe want to get the company IDs (VAT number) when they submit expenses (it's required by law for expenses to be valid).
An easy solution for that would be:

[ ] In host settings:

[ ] Add a "Require additional information" checkbox
[ ] Add a "Additional information description" textarea

[ ] Surface this label and enforce the "required field" in the expense flow

At the moment I do not need to make a priority of this. At some point it would be nice to include an API such as this one in the expense form that would validate VAT numbers

Same with IBAN when selecting 'New bank account'. Would be awesome to have an API chekcing if the IBAN is valid or not/

A support user has requested this. They want to add their financial ID number to their invoices.
Is this issue also the same as: https://github.com/opencollective/opencollective/issues/4168

A support user has requested this. They want to add their financial ID number to their invoices/receipts.

If it's their financial ID (i.e. the host financial ID, not the expense submitter's) and we're talking about contributions (not expenses) then they can already do it from Workspace > Host settings > Invoices & Receipts:

Is this issue also the same as: #4168

https://github.com/opencollective/opencollective/issues/4168 is meant for contributions, while this one is for expenses.

Okay jumping over to #4168 as its for contributions


MINOR: improve error message for Serde type miss match

Atm, if the type does not match, the error is miss leading and not helpful:
A serializer (value: org.apache.kafka.streams.state.internals.ValueAndTimestampSerializer) is not compatible to the actual value type (value type: org.apache.kafka.streams.state.ValueAndTimestamp). Change the default Serdes in StreamConfig or provide correct Serdes via method parameters.

This PR makes sure that the actual value type information is in the message to make the ValueAndTimestamp wrapping transparent to the user and to make the error message useful.
This should be cherry-picked to 2.3 branch.

Call for review @guozhangwang @bbejeck @vvcephei @ableegoldman @cadonna @abbccdda

Updated this. Will merge if Jenkins is green again.

Retest this please

Java8 passed. Java11 failed with know flaky test.
Retest this please.

Java8 passed. Java11 failed (test results not available any longer).
Retest this please.

Merged to trunk and cherry-picked to 2.3 branch.


Ion-refresher stops working when navigating between pages

Bug Report
Ionic Info
Ionic:

   ionic (Ionic CLI)          : 4.1.2 (C:\Users\hari\AppData\Roaming\npm\node_modules\ionic)
   Ionic Framework            : @ionic/angular 4.0.0-beta.12
   @angular-devkit/core       : 0.7.5
   @angular-devkit/schematics : 0.7.5
   @angular/cli               : 6.1.5
   @ionic/ng-toolkit          : 1.0.8
   @ionic/schematics-angular  : 1.0.6

Cordova:

   cordova (Cordova CLI) : 8.0.0
   Cordova Platforms     : android 7.0.0
   Cordova Plugins       : cordova-plugin-ionic-keyboard 2.1.2, cordova-plugin-ionic-webview 2.1.4, (and 6 other plugins)

System:

   Android SDK Tools : 26.1.1 (c:\androidsdk)
   NodeJS            : v8.11.2 (C:\Program Files (x86)\nodejs\node.exe)
   npm               : 5.6.0
   OS                : Windows 10

Describe the Bug
When an app has two pages with ion-refresher, both displaying multiple objects (using cards, in this case), the refresher only works for the first page. When navigated to the second page with refresher, pulling the page down does not cause refresher to be activated.
Related Code
Please see the sample project here
Expected Behavior
Page refresher should work on all pages where it's defined.

Thanks for your issue! Could you please check if this is still an issue in beta.17? That would be very nice :)


onCollision and Sphere Cast doesn't work when speed is high!

In my game I need to do something after ball hit to another ball for example playing sound
I tried using all three methods collisionstart  contactcollision and collisionend
https://developer.playcanvas.com/en/tutorials/collision-and-triggers/
if (result.other.tags.has('Ball')){
        result.other.destroy();
}

but when speed is high and sometimes it doesn't work at all!!!!
also I tried using Raycast but didn't work
playcanvas wasted my time!!
playcanvas isn't good name for it assholecanvas is better name

https://forum.playcanvas.com/t/collision-detection-problem/9548

It looks like your issue has been resolved in the forum. Please use the forum if you are not sure that there is an engine bug before opening a new engine issue here. Thanks!


[Programmatic Access - BOT Framework - Web Chat > Navigation]: Elements with an ARIA role that require child roles does not contained by them.

User Experience:
Screen reader user will get confuse with the control type of the control if require aria child role is not defined for child control appearing under the parent control.
Repro Steps:

Open URL: Web Chat: Full-featured bundle (microsoft.github.io)
Web chat bundle will open.
Navigate on the web chat bot.
Verify the issue.

Actual Result:
Elements with an ARIA role that require child roles does not contained by them.
Expected Result:
Ensures elements with an ARIA role that require child roles contain them.
Issue:
Ensures elements with an ARIA role that require child roles contain them (aria-required-children - https://accessibilityinsights.io/info-examples/web/aria-required-children)
Target application:
Web Chat: Full-featured bundle - https://microsoft.github.io/BotFramework-WebChat/01.getting-started/a.full-bundle/
Element path:
.webchat--css-ujbzv-1l95nvm
Snippet:

How to fix:
Fix any of the following:
Required ARIA child role not present: article
MAS Reference:
MAS1.3.1- Info & Relationships
Reference Links
Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.

#A11yMAS;#A11ySev2;#HCL;#MAS1.3.1;#Accessibility;#Win11-Chrome;#BotFrameworkWebChat-Jul22;

This is fixed in #4420 and will be released as 4.15.5.


Fix two instances of wrong process name passed to ch_versions.mix() when running in sentieon mode

This small update fixes two similar bugs where the wrong process name is passed in a call to ch_versions.mix() when run in sentieon mode.
PR checklist

[x] This comment contains a description of changes (with reason).
[ ] If you've fixed a bug or added code that should be tested, add tests!
[ ] If you've added a new tool - have you followed the pipeline conventions in the contribution docs
[ ] If necessary, also make a PR on the nf-core/raredisease branch on the nf-core/test-datasets repository.
[x] Make sure your code lints (nf-core lint).
[ ] Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
[ ] Ensure the test suite passes (nextflow run . -profile test_one_sample,docker --outdir <OUTDIR>).
[ ] Usage Documentation in docs/usage.md is updated.
[ ] Output Documentation in docs/output.md is updated.
[x] CHANGELOG.md is updated.
[ ] README.md is updated (including new tool citations and authors/contributors).

Nice catch @alkc and thanks for the PR!

Glad to be able to help!
Speaking of sentieon, I've identified an issue in the nf-core sentieon dedup module that crashes the rd pipeline when trying to do a sentieon-mode stub run: https://github.com/nf-core/modules/pull/4632
Should I document it as an issue in the raredisease issue tracker?

It's always nice to get it documented as an issue and very nice to see that you have a PR in modules to solve it. Once that PR is merged we can update the dedup module in the pipeline.

Done! #462


Address build failures

Xcontent classes were moved in this PR https://github.com/opensearch-project/OpenSearch/pull/5902 causing builds to fail.
Check List

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

SQL Java CI still fails because ml-commons needs to be updated first. See https://github.com/opensearch-project/ml-commons/pull/741

Codecov Report

Merging #1366 (bc7d74c) into main (b826835) will not change coverage.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@            Coverage Diff            @@
##               main    #1366   +/-   ##
=========================================
  Coverage     99.96%   99.96%
  Complexity     2464     2464
=========================================
  Files           220      220
  Lines          5833     5833
  Branches        359      359
=========================================
  Hits           5831     5831
  Misses            2        2

Flag
Coverage Δ

sql-engine
99.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

2023-03-02T23:07:52.3208450Z [ant:checkstyle] [ERROR] /Users/runner/work/sql/sql/plugin/src/main/java/org/opensearch/sql/plugin/rest/RestQuerySettingsAction.java:25:1: Wrong lexicographical order for 'org.opensearch.common.xcontent.XContentType' import. Should be before 'org.opensearch.core.xcontent.XContentParser'. [CustomImportOrder]
2023-03-02T23:07:52.3209720Z
2023-03-02T23:07:52.3219040Z > Task :opensearch-sql-plugin:checkstyleMain FAILED

I think no backport to 2.x is needed.


Expose json object mapper through getter

This patch address the issue opened in #589

@calvernaz Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@calvernaz,
Please, come back to us with a signed CLA.
Otherwise we can't review and accept your PR.
I understand that it might seem like an "obvious fix", but at a glance it is really with some flaws and would be really better to pass objectMapper as an argument to the initializeJsonObjectMapper().
I'd even rename it into initializeDefaultJsonObjectMapper(), because that won't be good to let to mutate the provided ObjectMapper.
Although the getter must be there anyway.
Thank you for your contribution effort!

I signed it already, I got the message:
Thank you for signing the Agreement! The contributor license agreement checks on spring-projects/spring-amqp/pull/590 should now pass.
Yea, I thought about that suggestion, but I had doubts about changing the API and decided to go with the protected getter to leave just enough room for access.
Saying that I can follow up and accommodate all those suggestions.

@calvernaz Thank you for signing the Contributor License Agreement!

OK! After manual PR syncing we really see a confirmation.
Right that looks like a breaking change, but my concern to let end user to know that we configure with that method only a default ObjectMapper instance.
If you provide an external one, that is already your responsibility to configure it there.
We can't mutate an external instance unconditionally and changing the API that should be much cleaner now.
I won't mind any other opinion.

@garyrussell ,
Your opinion on the matter?
This is the last community PR (and its issue) we should consider for tomorrow's release.
Thanks.

@artembilan I am not sure what you mean by "breaking change" - all we're doing is adding a getter to allow a subclass to access the field rather than replacing the default mapper.
The structure of this class is a little odd; normally you should only call final methods from a ctor, explicitly to prevent subclasses from changing expected behavior.
Personally, I would make the mapper final and add another ctor that takes a fully assembled mapper. We could deprecate the setter in 1.7.x and change the javadoc to make it clear the initialize... method is only called from the default ctor.
Another alternative would be to deprecate that initialize method and add a new one that takes the mapper as an argument.

Thank you, @garyrussell , for your vision!
Well, at least we are on the same page about the oddity of this class 😄
How about this: https://github.com/artembilan/spring-amqp/commit/99bc3b95d42b209dcced7c8dda583d5bad2110c7 ?
I didn't make it as a final do not break existing extensions. But this might be candidate really for 1.7.x.
In the 2.0 we can remove those deprecated methods and make the property final.
IMO the class isn't designed for extension and it doesn't aim that goal by the purpose.
So, simple injection of externally configured ObjectMapper should be as a silver bullet.

LGTM (with javadocs on the ctors that is 😄 )

LGTM

Sorry, not enough info.
Does that mean that we apply it as is for master? Or what I did is for 1.7.x? The master version should be provided.
Thanks

Sorry; yes; I meant apply this with deprecations to 1.7.x and remove them in 2.0.

Good, thank you, Gary, for confirmation!
@calvernaz ,
Sorry, since you see a discussion, this PR becomes unrelated.
Please, close it and let us know if you are good to provide a couple new:

For 1.7.x with my change in that commit
For master with similar change but with removed @Deprecated methods and final for the objectMapper property.

We need it for tomorrow: the release obligations.
Otherwise let us know and we do that for you.
There are still enough tasks for contribution! 😄

I've been following along the discussion and the constructor option is my favorite solution for this one.

Superseded with the https://github.com/spring-projects/spring-amqp/commit/710464367e15c9287e4f83de40b833c0e632d66c for 1.7.x and https://github.com/spring-projects/spring-amqp/commit/13e0b7621a93124938a3e7f8f8ed0ef0b60ca8bb for the master.


Replace completionUri with notification

add WaitNotificationJob job/baseTask/task/unit test
keep the original WaitCompletionUri job
remove completionUri from all OSes which includes schema/task/unit test

@RackHD/corecommitters please review.

@RackHD/corecommitters @zyoung51 @cgx027 @uppalk1

*** BUILD #1587 ***

jenkins: depends on https://github.com/RackHD/on-taskgraph/pull/169 https://github.com/RackHD/on-http/pull/459

test this please

test this please

test this please

will need review from @cgx027

Build finished.

Looks good overall. :+1: after fix houndci issue and coverage drop.
Maybe consider add schema for newly added task, But it can also be a follow up action.

test this please

BUILD on-tasks #1592 : UNSTABLE
   - ** BUILD build-config-setup  #96080: SUCCESS
   - ** BUILD unit-tests  #9240: SUCCESS
   - ** BUILD smoke-test  #3349: SUCCESS

   - ** BUILD on-taskgraph #1502: UNSTABLE
      - ** BUILD build-config-setup  #96082: SUCCESS
      - ** BUILD unit-tests  #9241: UNSTABLE

   - ** BUILD on-http #2518: SUCCESS
      - ** BUILD build-config-setup  #96084: SUCCESS
      - ** BUILD unit-tests  #9242: SUCCESS

BUILD unit-tests  #9241  Error Logs:

Test Name: Graph Library should validate all existing graphs not requiring user input for null values
Error Details: Value does not exist for options.completionUri
Stack Trace: [object Object]
    at Task.renderString (node_modules/on-tasks/lib/task.js:198:19)
    at node_modules/on-tasks/lib/task.js:246:37
    at arrayMap (node_modules/lodash/index.js:1406:25)
    at Function.map (node_modules/lodash/index.js:6710:14)
    at Task.render (node_modules/on-tasks/lib/task.js:238:18)
    at Task.renderOptions (node_modules/on-tasks/lib/task.js:257:25)
    at node_modules/on-tasks/lib/task.js:260:31
    at node_modules/lodash/index.js:10033:16
    at node_modules/lodash/index.js:3073:15
    at baseForOwn (node_modules/lodash/index.js:2046:14)
    at Function.transform (node_modules/lodash/index.js:10032:39)
    at Task.renderOptions (node_modules/on-tasks/lib/task.js:259:22)
    at Task.renderOwnOptions (node_modules/on-tasks/lib/task.js:266:29)
    at node_modules/on-tasks/lib/task.js:164:22
    at Object.finallyHandler (node_modules/on-core/node_modules/bluebird/js/main/finally.js:39:23)
    at Object.tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

BUILD on-taskgraph #1502  Error Logs:

Test Name: Graph Library should validate all existing graphs not requiring user input for null values
Error Details: Value does not exist for options.completionUri
Stack Trace: [object Object]
    at Task.renderString (node_modules/on-tasks/lib/task.js:198:19)
    at node_modules/on-tasks/lib/task.js:246:37
    at arrayMap (node_modules/lodash/index.js:1406:25)
    at Function.map (node_modules/lodash/index.js:6710:14)
    at Task.render (node_modules/on-tasks/lib/task.js:238:18)
    at Task.renderOptions (node_modules/on-tasks/lib/task.js:257:25)
    at node_modules/on-tasks/lib/task.js:260:31
    at node_modules/lodash/index.js:10033:16
    at node_modules/lodash/index.js:3073:15
    at baseForOwn (node_modules/lodash/index.js:2046:14)
    at Function.transform (node_modules/lodash/index.js:10032:39)
    at Task.renderOptions (node_modules/on-tasks/lib/task.js:259:22)
    at Task.renderOwnOptions (node_modules/on-tasks/lib/task.js:266:29)
    at node_modules/on-tasks/lib/task.js:164:22
    at Object.finallyHandler (node_modules/on-core/node_modules/bluebird/js/main/finally.js:39:23)
    at Object.tryCatcher (node_modules/on-core/node_modules/bluebird/js/main/util.js:26:23)
    at Promise._settlePromiseFromHandler (node_modules/on-core/node_modules/bluebird/js/main/promise.js:510:31)
    at Promise._settlePromiseAt (node_modules/on-core/node_modules/bluebird/js/main/promise.js:584:18)
    at Async._drainQueue (node_modules/on-core/node_modules/bluebird/js/main/async.js:128:12)
    at Async._drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:133:10)
    at Async.drainQueues (node_modules/on-core/node_modules/bluebird/js/main/async.js:15:14)

BUILD on-tasks #1592  Error Logs:

BUILD on-tasks #1593 : FAILURE
   - ** BUILD build-config-setup  #96085: SUCCESS
   - ** BUILD unit-tests  #9243: SUCCESS
   - ** BUILD smoke-test  #3350: FAILURE

   - ** BUILD on-taskgraph #1503: UNSTABLE
      - ** BUILD build-config-setup  #96088: SUCCESS
      - ** BUILD unit-tests  #9244: UNSTABLE

   - ** BUILD on-http #2519: SUCCESS
      - ** BUILD build-config-setup  #96090: SUCCESS
      - ** BUILD unit-tests  #9245: SUCCESS

Build finished.

:+1:

The Jenkins errors is expected since it doesn't resolve the dependencies, but the "Jenkins-Dependency-PR" success, it proves this PR is correct after resolving dependencies.
So it's OK to merge.


Insight displays incorrect file sizes: 1GB appears as 0.1000G

1GB files appear as having size 0.1000G in the Insight file browser. Smaller and larger files have their correct sizes displayed. This quirk has been present for the last 3 updates to TrueOS, so I figured no one has noticed it.
Actual size as reported by ls "1.0G" or "1073741824"

Fixed!
https://github.com/trueos/lumina/commit/c03797a535089d458dffec3ff64ba052542860ed


Unification Asclepios

@ocommowi @msermesant Please! Before merging, please review and merge TTK and  LCC-LogDemons PRs

I looked at the code, it seems fine to me, but I would rather let Olivier click on the big green button :-)

Alright, good to go !! Starting by the other dependent branches


DW: Fetch LocalQueues, pass them down in context, use them for "quota is not set" empty state

Closes RHOAIENG-4746 (followup to #2644, cc @gitdallas)
Needed for RHOAIENG-2844
Description

Adds types, utilities, hooks and tests for fetching Kueue LocalQueues. LocalQueues are the last piece of data the UI needs to fetch to implement features for our initial Distributed Workloads GA. The LocalQueueKind type is based on referencing the CRD here and the API docs here.
Also cleans up some repetition in the types for ClusterQueueKind and adds API doc links to all 3 Kueue CR types in that file.
Completes the empty-state work that started in #2644 by providing the logic for the "No quota set" empty state on the Project Metrics tab. Per @astefanutti, that message should be shown if there are is no ClusterQueue, or the ClusterQueue's spec.resourceGroups is missing or empty, or there are no LocalQueues in the selected namespace.
Simplifies the logic for working with a singleton ClusterQueue: Previously, we were passing down the whole array of clusterQueues via context, but this UI will only support a single ClusterQueue being created in the cluster. The context provider now only passes down a single clusterQueue which will either be the first ClusterQueue found that has resourceGroups, or it will be undefined.

cc @xianli123 @cfullam1
How Has This Been Tested?

Sanity checked everything locally.
Test Impact

Unit tests have been added for listLocalQueues and useLocalQueues, similar to the existing tests for listWorkloads and useWorkloads etc.
Cypress tests have been added to make sure the "Quota is not set" message appears under the correct circumstances. I also reorganized the Cypress tests to group them into separate describe blocks per tab.

Request review criteria:

Self checklist (all need to be checked):

[x] The developer has manually tested the changes and verified that the changes work
[x] Commits have been squashed into descriptive, self-contained units of work (e.g. 'WIP' and 'Implements feedback' style messages have been removed)
[x] Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
[x] The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)

If you have UI changes:

[x] Included any necessary screenshots or gifs if it was a UI change.
[x] Included tags to the UX team if it was a UI/UX change (find relevant UX in the SMEs section).

After the PR is posted & before it merges:

[ ] The developer has tested their solution on a cluster by using the image produced by the PR to main

Thanks @mturley. It looks great.

/override ci/prow/odh-dashboard-pr-image-mirror ci/prow/images


Support for global bandwidth limitation.

Support global bandwidth limitation.
This is done by a basic Weighted Fair Queue algorithm.

Moved to master, may still have some problems.


chore(main): release 4.6.9

:robot: I have created a release beep boop
4.6.9 (2024-10-16)
Bug Fixes

cicd: fix deployment (8cf5e03)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v4.6.9
:sunflower:


How to enable --proxy / NEKO_PROXY?

How to enable proxy mode? Starting with --proxy yields to a panic:
{"level":"panic","error":"unknown flag: --proxy","time":"2020-05-26T18:36:22Z","message":"failed to execute command"}
and NEKO_PROXY doesn't do anything.
I am running behind nginx and neko as is is trying to open websocket connections with the IP of the nginx container (instead of following X-Forwarded-For)
I see there is code for handling all of this but I cannot seem to find docs about proxy and this is what I get using the latest nurdism/neko:firefox container
Thanks in advance,
Simone

At second glance it might just be that the nurdism/neko:firefox image is just so outdated. Could you please set automatic builds for all the images on Docker Hub?
I am trying to rebuild it myself but I seem to be missing some files.
(⎈ |key:media)/t/neko » docker build . -t nurdism/neko:deps -f .docker/files/deps/Dockerfile               master ✔
Sending build context to Docker daemon  17.48MB
Step 1/8 : FROM debian:stretch-slim
 ---> fa41698012c7
Step 2/8 : RUN set -eux; apt-get update;     apt-get install -y --no-install-recommends pulseaudio dbus-x11 xserver-xorg-video-dummy;     apt-get install -y --no-install-recommends libcairo2 libxcb1 libxrandr2 libxv1 libopus0 libvpx4;     apt-get clean -y;     rm -rf /var/lib/apt/lists/* /var/cache/apt/*
 ---> Using cache
 ---> a70c0591569c
Step 3/8 : ENV PATH=/gst/local/bin:$PATH
 ---> Using cache
 ---> e2c0be63d5c9
Step 4/8 : ENV LD_LIBRARY_PATH=/gst/local/lib:$LD_LIBRARY_PATH
 ---> Using cache
 ---> 2b8ddd851973
Step 5/8 : ENV PKG_CONFIG_PATH=/gst/local/lib/pkgconfig:$PKG_CONFIG_PATH
 ---> Using cache
 ---> 7f861a973686
Step 6/8 : COPY .build/gst/local /gst/local/
COPY failed: stat /var/lib/docker/tmp/docker-builder538872518/.build/gst/local: no such file or directory

At second glance it might just be that the nurdism/neko:firefox image is just so outdated. Could you please set automatic builds for all the images on Docker Hub?
I am trying to rebuild it myself but I seem to be missing some files.
(⎈ |key:media)/t/neko » docker build . -t nurdism/neko:deps -f .docker/files/deps/Dockerfile               master ✔
Sending build context to Docker daemon  17.48MB
Step 1/8 : FROM debian:stretch-slim
 ---> fa41698012c7
Step 2/8 : RUN set -eux; apt-get update;     apt-get install -y --no-install-recommends pulseaudio dbus-x11 xserver-xorg-video-dummy;     apt-get install -y --no-install-recommends libcairo2 libxcb1 libxrandr2 libxv1 libopus0 libvpx4;     apt-get clean -y;     rm -rf /var/lib/apt/lists/* /var/cache/apt/*
 ---> Using cache
 ---> a70c0591569c
Step 3/8 : ENV PATH=/gst/local/bin:$PATH
 ---> Using cache
 ---> e2c0be63d5c9
Step 4/8 : ENV LD_LIBRARY_PATH=/gst/local/lib:$LD_LIBRARY_PATH
 ---> Using cache
 ---> 2b8ddd851973
Step 5/8 : ENV PKG_CONFIG_PATH=/gst/local/lib/pkgconfig:$PKG_CONFIG_PATH
 ---> Using cache
 ---> 7f861a973686
Step 6/8 : COPY .build/gst/local /gst/local/
COPY failed: stat /var/lib/docker/tmp/docker-builder538872518/.build/gst/local: no such file or directory

+1, have been having some issues and I wonder if it's due to outdated builds


python3Packages.pyvera: 0.3.13 -> 0.3.14

Motivation for this change
Update to latest upstream release 0.3.14
Change log: https://github.com/pavoni/pyvera/releases/tag/0.3.14
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 138744 run on x86_64-linux 1

3 packages built:

home-assistant
python38Packages.pyvera
python39Packages.pyvera


Missing Slovenian translation

Problem

Missing Slovenian translation

Solution

Translated into Slovenian locale

Additional

I am a native Slovenian speaker and Microsoft provides translation for Excel/Office/Word etc. I double checked translations so everything should be good to go :wink:

Thanks! :)


Change in nb_SparseImageWarp.py to adapt newer version of pytorch

Hi, I found some code in nb_SparseImageWarp.py need changes in order to work in Pytorch 1.4.0:
In line 115:
X, LU = torch.gesv(rhs, lhs) ->
X, LU = torch.solve(rhs, lhs)
(torch.gesv has been deprecated)
In line 160:
return 0.5 * torch.square(r) * torch.log(torch.max(r, EPSILON)) ->
return 0.5 * r.pow(2) * torch.log(torch.max(r, EPSILON))
There are also warnings:
nb_SparseImageWarp.py:316: UserWarning: To copy construct from a tensor, it is recommended to use sourceTensor.clone().detach() or sourceTensor.clone().detach().requires_grad_(True), rather than torch.tensor(sourceTensor).
alpha = torch.tensor(queries - floor, dtype=grid_type)
But I think it will still be working properly.
Hope that might help.

line 316: change to:
alpha = queries - floor
Will solve the warning

    213         return r
    214     elif order == 2:
--> 215         return 0.5 * r.pow(2) * torch.log(torch.max(r, EPSILON))
    216     elif order == 4:
    217         return 0.5 * torch.square(r) * torch.log(torch.max(r, EPSILON))

RuntimeError: iter.device(arg).is_cuda() INTERNAL ASSERT FAILED at "/pytorch/aten/src/ATen/native/cuda/Loops.cuh":61, please report a bug to PyTorch.

Changing return 0.5 * torch.square(r) * torch.log(torch.max(r, EPSILON)) -> return 0.5 * r.pow(2) * torch.log(torch.max(r, EPSILON))  still gives error.

Please put up a PR and I'm happy to review and merge.


sensor.mi__message didn't show all the messages.显示不全

Hi, thanks for your great work.
The entity of the mihome sensor works fine for me, only there is a problem that it only shows the device notifications.
I am personally using a very dumb way to interact xiaoai soundbox with HA from https://zyyme.com/mihome-hass.html
This means I have to use a "scene implementation result notifications" in the HA log to get things done.
I am checking the Notification settings in Mihome app on android and find that "Device notifications“  and "Scene implementation result notifications" were under different sections with their own switch.
According to the author of https://zyyme.com/mihome-hass.html , I'm guessing that in some old version these two notifications were placed under the same section? And is it possible to get both notification sections available in Miot of HA?
Thanks.
大佬好，感谢您的工作。
我从网上看到可以用miot的通知来触发特定动作，但是目前版本的HA和miot只能显示部分信息，即仅显示了”设备通知“，而没有“场景执行结果通知”。
我在米家app中看到通知设置中的”设备通知“和”场景执行结果通知“分为两部分，再结合之前网上此博主的帖子，
我猜测之前版本中的确能做到两类通知同时出现在log里。所以，在此请教，是否存在这种可能性，把两类通知寻回？
十分感谢！

A better way was there in the FAQ. https://github.com/al-one/hass-xiaomi-miot/issues/537