OpenShift 4.4 - Keptn dashboards empty

I have Keptn running on OpenShift 4.4, rough notes at https://github.com/marcredhat/dynatrace/blob/master/keptn.adoc.
Keptn dashboards get created in Dynatrace but seem empty, please see https://github.com/marcredhat/dynatrace/blob/master/images/keptn_dashboard.png

Hi @marcredhat,
great that you have Keptn running on OpenShift 4.4. The notes you posted look very good and there is no step missing as far I can estimate it.
The issue you are mentioning is more related to the Dynatrace integration rather Keptn itself. But let's dig into it.

Have the services been successfully deployed by Keptn? A screenshot of the Keptn Bridge, or a glimpse into the namespace of the project can help to figure that out (according to your notes you created the projects: marc2, sockshop111, and sockshopgate --> then there should be namespaces with these names)
Are you services monitored? Go to Dynatrace and see: Transaction and service

If not, please double-check the PAAS token. (The API token is valid and works otherwise the tagging rules and dashboards would not have been created.)

Thanks @johannes-b !
The namespaces exist but I cannot onboard services / add resources. Please see the errors below:

keptn onboard service carts --project=sockshopgate --chart=./carts
Starting to onboard service
Handling connection for 8080
ID of Keptn context: 6d765ffa-2bb5-44e1-9901-886fc39d1f79
Handling connection for 8080
Error when getting deployment strategies: Get http://configuration-service:8080/v1/project/sockshopgate/resource/shipyard.yaml: dial tcp <IP_ADDRESS>:8080: connect: connection refused
keptn add-resource --project=sockshopgate --service=carts --stage=test --resource=jmeter/load.jmx --resourceUri=jmeter/basiccheck.jmx
Adding resource jmeter/load.jmx to service carts in stage test in project sockshopgate
Handling connection for 8080
....
E0805 18:41:09.033774 2464489 portforward.go:233] lost connection to pod
Error: Resource jmeter/load.jmx could not be uploaded: Post http://localhost:8080/api/configuration-service/v1/project/sockshopgate/stage/test/service/carts/resource: EOF

For getting a closer look into Keptn and what is going on, can you please run the command: keptn generate support-archive --dir= (please see here: https://keptn.sh/docs/0.7.x/reference/cli/commands/keptn_generate_support-archive/)
This command collects the logs of all Keptn services.
Can you then send me the logs via Slack for example? (slack.keptn.sh)

Thanks Johannes, I sent you the support archive via direct message on Slack.
The project gets created  etc (please see full details below).
However, I still get "websocket connection timed out" when I do a "keptn send event new-artifact"
oc get pods
NAME                                    READY   STATUS    RESTARTS   AGE
api-gateway-nginx-5b865b66b8-j28v9      1/1     Running   0          89m
api-service-6d86cb4f88-vqkk4            1/1     Running   0          89m
bridge-6594f6b8c-dcg9c                  1/1     Running   0          89m
configuration-service-f6856c58f-sgr5w   2/2     Running   0          38m
eventbroker-go-5674d9646d-nhw5m         1/1     Running   0          89m
helm-service-85f8bf5fd6-jt4hw           2/2     Running   4          89m
keptn-nats-cluster-0                    3/3     Running   0          88m
lighthouse-service-6d4b5dcd9-kvfbx      2/2     Running   5          89m
mongodb-7dcd49b688-pr5zd                1/1     Running   0          38m
mongodb-datastore-647b5bc584-wrjq2      2/2     Running   4          89m
remediation-service-cf4b7b97f-jdntb     2/2     Running   4          89m
shipyard-service-5c98f89f4c-tds85       2/2     Running   5          89m
keptn create project sockshopgate --shipyard=./shipyard.yaml
WARNING: Creating a project without Git upstream repository is not recommended.
You can configure a Git upstream repository using:
keptn update project PROJECTNAME --git-user=GIT_USER --git-token=GIT_TOKEN --git-remote-url=GIT_REMOTE_URL
Starting to create project
Handling connection for 8080
ID of Keptn context: 478eb5b8-ee57-4062-bcec-09eeb672a28c
Handling connection for 8080
Project sockshopgate created
Stage dev created
Stage staging created
Stage production created
Shipyard successfully processed
oc project sockshopgate
Now using project "sockshopgate" on server "https://api.apps.ocp4.local:6443".
keptn onboard service carts --project=sockshopgate --chart=./carts
Starting to onboard service
Handling connection for 8080
ID of Keptn context: e94ae8ef-876c-453b-a83c-ece0dbe51575
Handling connection for 8080
Create umbrella Helm Chart for project sockshopgate
Creating new Keptn service carts in stage dev
Creating new Keptn service carts in stage staging
Inject Istio to the sockshopgate-staging namespace for blue-green deployments
Creating new Keptn service carts in stage production
Inject Istio to the sockshopgate-production namespace for blue-green deployments
Finished creating service carts in project sockshopgate
keptn add-resource --project=sockshopgate --service=carts --stage=dev --resource=jmeter/load.jmx --resourceUri=jmeter/basiccheck.jmx
Adding resource jmeter/load.jmx to service carts in stage dev in project sockshopgate
Handling connection for 8080
Resource has been uploaded.
keptn add-resource --project=sockshopgate --stage=dev --service=carts --resource=jmeter/basiccheck.jmx --resourceUri=jmeter/basiccheck.jmx
Adding resource jmeter/basiccheck.jmx to service carts in stage dev in project sockshopgate
Handling connection for 8080
Resource has been uploaded.
oc projects | grep socks

sockshopgate
sockshopgate-dev
sockshopgate-production
sockshopgate-staging

keptn send event new-artifact --project=sockshopgate --service=carts --image=docker.io/keptnexamples/carts --tag=0.11.1
Availability of provided image cannot be checked.
Starting to send a new-artifact-event to deploy the service carts in project sockshopgate in version keptnexamples/carts:0.11.1
Handling connection for 8080
ID of Keptn context: 1e4012e2-b82a-4c1b-acd8-82c261071014
Handling connection for 8080Warning: Websocket connection timed out
Same with a local image:
keptn send event new-artifact --project=sockshopgate --service=carts --image=localhost/hercules
Handling connection for 8080Warning: Websocket connection timed out

Hi @marcredhat
according to your current comment, you are not facing the next problems anymore:

keptn onboard service carts --project=sockshopgate --chart=./carts --> Error when getting deployment strategies: Get http://configuration-service:8080/v1/project/sockshopgate/resource/shipyard.yaml: dial tcp <IP_ADDRESS>:8080: connect: connection refused
keptn add-resource --project=sockshopgate --service=carts --stage=test --resource=jmeter/load.jmx --resourceUri=jmeter/basiccheck.jmx --> Error: Resource jmeter/load.jmx could not be uploaded: Post http://localhost:8080/api/configuration-service/v1/project/sockshopgate/stage/test/service/carts/resource: EOF

What did you change to make them work?

What I can see now is, that you could successfully:

create a project: keptn create project sockshopgate --shipyard=./shipyard.yaml :heavy_check_mark:
onboard a service: keptn onboard service carts --project=sockshopgate --chart=./carts :heavy_check_mark:
add a resource: keptn add-resource --project=sockshopgate --service=carts --stage=dev --resource=jmeter/load.jmx --resourceUri=jmeter/basiccheck.jmx :heavy_check_mark:

Then you triggered a deployment with:

keptn send event new-artifact --project=sockshopgate --service=carts --image=docker.io/keptnexamples/carts --tag=0.11.1

I'm now super curious whether there are pods running in your namespace (project) sockshopgate-dev, sockshopgate-staging, and sockshopgate-production. Can you let me know?

Thanks for the logs you sent to me. I investigated them and think that I found the current blocker.
I'm I right that you installed Keptn via: keptn install --platform=openshift (as stated here: https://github.com/marcredhat/dynatrace/blob/master/keptn.adoc)?
(--> This installs the control-plane of Keptn, but not the components for Continous Delivery.)
Please execute the command: keptn install --use-case=continuous-delivery --platform=openshift
(--> This installs the services required for a keptn send event new-artifact.)

Thanks @johannes-b !
keptn install --use-case=continuous-delivery --platform=openshift results in 2 errors (please also see my comments at the end)
Helm Chart used for Keptn installation: https://storage.googleapis.com/keptn-installer/keptn-0.7.0.tgz
.....
Istio is required for the continuous-delivery use case, but could not be found in your cluster in namespace istio-system.
Please install Istio as described in the Istio docs: https://istio.io/latest/docs/setup/getting-started/
Existing Keptn installation found in namespace keptn
Do you want to overwrite this installation? (y/n)
y
Start upgrading Helm Chart keptn in namespace: keptn
Could not complete Keptn installation: Error when installing/upgrading Helm Chart keptn in namespace keptn: "keptn" has no deployed releases
Error: Error when installing/upgrading Helm Chart keptn in namespace keptn: "keptn" has no deployed releases
My comments:

Re Istio, I have OpenShift Mesh up and running as shown at https://github.com/marcredhat/dynatrace/blob/master/servicemesh.adoc
The differences between OpenShift 4.4 Service Mesh and upstream Istio are explained at https://access.redhat.com/documentation/en-us/openshift_container_platform/4.4/html/service_mesh/service-mesh-architecture#ossm-vs-community
"keptn" has no deployed releases. Not quite sure what this means and how to fix...

Thanks,
Marc

Comment 1.) Keptn requires Istio for doing a blue/green deployment of your service. In more details, the two CRDs are required:

DestinationRule
VirtualService

But let`s get to the point, where blue/green deployments come into play.
Comment 2.) The error "keptn" has no deployed releases. is returned by Helm, which is used for the upgrade. Would it be possible to execute a keptn uninstall and then a keptn install --use-case=continuous-delivery --platform=openshift? This deletes Keptn from your cluster and re-installs it.
(The documentation of these two commands is provided here: https://keptn.sh/docs/0.7.x/reference/cli/commands/)

I created a fresh cluster and deployed OpenShift Service Mesh in istio-system. All good there.
Keptn seems happy too:
oc get pods
NAME                                                              READY   STATUS    RESTARTS   AGE
api-gateway-nginx-5bc6f54d4b-dr24g                                1/1     Running   0          101m
api-service-55d4c499fd-7j627                                      1/1     Running   0          101m
bridge-559f9988c7-wnttg                                           1/1     Running   0          101m
configuration-service-865d89f78f-zgshf                            2/2     Running   0          101m
eventbroker-go-dcf997974-zlftw                                    1/1     Running   0          101m
gatekeeper-service-678f556955-l6nwc                               2/2     Running   2          101m
helm-service-6946fb9b8d-vtgn9                                     2/2     Running   2          101m
helm-service-continuous-deployment-distributor-567cc995bd-8xflq   1/1     Running   2          101m
jmeter-service-669848d4f8-kbg9s                                   2/2     Running   1          101m
keptn-nats-cluster-0                                              3/3     Running   0          101m
lighthouse-service-5bb8698f9-wc8df                                2/2     Running   2          101m
mongodb-datastore-cd457f886-nv5bj                                 2/2     Running   2          101m
mongodb-dbff8b66c-pnhzm                                           1/1     Running   0          101m
openshift-route-service-7f57d79955-rpzkh                          2/2     Running   2          101m
remediation-service-5f44c6779c-4tpqh                              2/2     Running   2          101m
shipyard-service-6c989977d5-q9xgk                                 2/2     Running   2          101m
But now "keptn create project" commands result in:
Starting to create project
Handling connection for 8080
ID of Keptn context: 17d68505-05f9-4a23-abc6-b53946bb7425
Handling connection for 8080
Project marctest created
Creating stage staging failed. Could not create stage..

UPDATE: Worked fine after I did a first commit to the project's github repo
keptn create project marc1111 --shipyard ./shipyard.yaml --git-user= --git-token=  --git-remote-url=https://github.com/marcredhat/marc1111.git
Starting to create project
Handling connection for 8080
ID of Keptn context:
Handling connection for 8080
Project marc1111 created
Stage dev created
Stage staging created
Stage production created
Shipyard successfully processed

So Keptn works fine on OpenShift 4.4 and 4.5, we can use the above to create an OpenShift 4.4+ / Keptn tutorial.
The only remaining problem is with the Keptn/Dynatrace integration:
oc logs dynatrace-service-775c6b876c-j42rx
##########
branch: 0.7.0
repository: https://github.com/keptn-contrib/dynatrace-service
commitlink: https://github.com/keptn-contrib/dynatrace-service/commit/2a7b0e6f4cf462b375b06cdec5aa6fd14b3159f4
repolink: https://github.com/keptn-contrib/dynatrace-service/tree/2a7b0e6f4cf462b375b06cdec5aa6fd14b3159f4
timestamp: 20200507.0740
version: 0.7.0
##########
2020/08/11 18:04:11 Port = 8080; Path=/
{"timestamp":"2020-08-11T18:05:44.287445048Z","logLevel":"DEBUG","message":"Received event: sh.keptn.event.monitoring.configure"}
{"timestamp":"2020-08-11T18:05:44.298770382Z","logLevel":"ERROR","message":"Opening WebSocket connection failed:websocket: bad handshake"}
{"timestamp":"2020-08-11T18:07:27.669959071Z","logLevel":"DEBUG","message":"Received event: sh.keptn.event.monitoring.configure"}
{"timestamp":"2020-08-11T18:07:27.680820317Z","logLevel":"ERROR","message":"Opening WebSocket connection failed:websocket: bad handshake"}
{"timestamp":"2020-08-11T18:10:24.316111157Z","logLevel":"DEBUG","message":"Received event: sh.keptn.event.monitoring.configure"}
{"timestamp":"2020-08-11T18:10:24.324921055Z","logLevel":"ERROR","message":"Opening WebSocket connection failed:websocket: bad handshake"}

Updated the instructions at https://github.com/marcredhat/dynatrace/blob/master/keptn.adoc
The carts app and database get deployed in the -dev namespace. All good there.
The -staging and -production namespaces get created but remain empty.
I'd love to test the quality gates but not sure how to proceed given the above.

Hi @marcredhat,
that are really great news!
The problem you are facing with the Keptn/Dynatrace integration (aka. the dynatrace-service) is something we can address independently from the Keptn releasing cycle and fix with a patch that makes the WebSocket communication from the dynatrace-service to the api-service more robust. I will reach out to the team.

The -staging and -production namespaces get created but remain empty.: Can you take a look at the 'staging' or 'production' branch in your Git repository and check out whether there are two folders (carts and carts-generated) in: carts/helm/. Can you find the folders?

I'd love to test the quality gates but not sure how to proceed given the above.: I would recommend setting this up for the dev stage as you have a deployed service there.

You need to deploy the dynatrace-sli-service:  https://raw.githubusercontent.com/keptn-contrib/dynatrace-sli-service/0.4.1/deploy/service.yaml (this service is responsible for fetching the data from Dynatrace)
Add the SLO file for the carts service to the dev stage: keptn add-resource --project=sockshop --stage=dev --service=carts --resource=slo-quality-gates.yaml --resourceUri=slo.yaml
Add the SLI file: keptn add-resource --project=sockshop --stage=dev --service=carts --resource=sli-config-dynatrace.yaml  --resourceUri=dynatrace/sli.yaml

Did you deploy Dynatrace OneAgent operator on your cluster and is your carts service monitored?

Please follow the instructions from: https://www.dynatrace.com/support/help/technology-support/cloud-platforms/kubernetes/deploy-oneagent-k8/

I only have the 2 folders (carts and carts-generated) in the -dev branch.
The quality gates install using your 3 commands above seems to have worked. I added the results to the "Quality gates" paragraph at https://github.com/marcredhat/dynatrace/blob/master/keptn.adoc
In the -dev branch, keptn added:

spec_version: '1.0'
indicators:
throughput: "builtin:service.requestCount.total:merge(0):sum?scope=tag(keptn_project:$PROJECT),tag(keptn_stage:$STAGE),tag(keptn_service:$SERVICE),tag(keptn_deployment:$DEPLOYMENT)"
error_rate: "builtin:service.errors.total.count:merge(0):avg?scope=tag(keptn_project:$PROJECT),tag(keptn_stage:$STAGE),tag(keptn_service:$SERVICE),tag(keptn_deployment:$DEPLOYMENT)"
response_time_p50: "builtin:service.response.time:merge(0):percentile(50)?scope=tag(keptn_project:$PROJECT),tag(keptn_stage:$STAGE),tag(keptn_service:$SERVICE),tag(keptn_deployment:$DEPLOYMENT)"
response_time_p90: "builtin:service.response.time:merge(0):percentile(90)?scope=tag(keptn_project:$PROJECT),tag(keptn_stage:$STAGE),tag(keptn_service:$SERVICE),tag(keptn_deployment:$DEPLOYMENT)"
response_time_p95: "builtin:service.response.time:merge(0):percentile(95)?scope=tag(keptn_project:$PROJECT),tag(keptn_stage:$STAGE),tag(keptn_service:$SERVICE),tag(keptn_deployment:$DEPLOYMENT)"

Yes. OneAgent pods are running on all nodes.

I assume that OpenShift Service Mesh might be the reason why Keptn cannot create the Helm charts for staging and production. But let's dig into that problem when the quality gate in dev works.

In the meanwhile, I figured out that you deployed an old version of the dynatrace-service. According to your logs, you deployed dynatrace-service:0.7.0, but the new version is dynatrace-service:0.8.0 (I'm sorry, if there is still a link to dynatrace-service:0.7.0 combined with Keptn 0.7.0)

Can you please delete the dynatrace-service.
And install it, as explained here: https://keptn.sh/docs/0.7.x/monitoring/dynatrace/install/#install-dynatrace-keptn-integration

Important, please use: https://raw.githubusercontent.com/keptn-contrib/dynatrace-service/0.8.0/deploy/service.yaml

Then execute: keptn configure monitoring dynatrace --project=sockshop again.

keptn configure monitoring dynatrace --project=marc1111
Handling connection for 8080
ID of Keptn context: 7e62a412-c5b8-4958-871f-6683b576abe6
Handling connection for 8080
Configuring Dynatrace monitoring
Dynatrace OneAgent Operator is installed on cluster
Setting up auto-tagging rules in Dynatrace Tenant
Tagging rule keptn_service already exists
Tagging rule keptn_stage already exists
Tagging rule keptn_project already exists
Tagging rule keptn_deployment already exists
Setting up problem notifications in Dynatrace Tenant
Checking Keptn alerting profile availability
Keptn alerting profile available
Could not retrieve shipyard for project marc1111: Resource not found

With a new project, I get:
keptn create project marc2222 --shipyard ./shipyard.yaml --git-user=xxxx --git-token=xxx --git-remote-url=https://github.com/xxxx/marc2222
Starting to create project
Handling connection for 8080
ID of Keptn context: c5f578bb-7da0-4a60-b3fc-6cb9babbdc74
Handling connection for 8080
Handling connection for 8080
Handling connection for 8080
Creating project marc2222 failed. Post http://configuration-service:8080/v1/project: EOF

oc logs configuration-service-865d89f78f-qzcg7 -c configuration-service
MongoDB client lost connection. Attempt reconnect.
Could not cast &{{}  [] 0xc00010cf50} to *models.Project

(For someone who is following this thread, please also consider this comment: https://github.com/keptn/keptn/issues/1969#issuecomment-673915162)

Comment from @marcredhat in https://github.com/keptn/keptn/issues/1969#issuecomment-673915162: "I see my quality gate results in Dynatrace."
That's great! Because then we know that Keptn is working fine and the Keptn/Dynatrace integration (with the dynatrace-service and dynatrace-sli-serivce) works too.
Please don't get confused about the log messages from the dynatrace-service:
...
{"timestamp":"2020-08-14T06:39:10.29066251Z","logLevel":"INFO","message":"Loaded Config from dynatrace.conf.yaml: \u0026{0.1.0 }"}
{"timestamp":"2020-08-14T06:39:10.290684499Z","logLevel":"DEBUG","message":"Found dynatrace.conf.yaml with DTCreds: "}
{"timestamp":"2020-08-14T06:39:10.313321833Z","logLevel":"DEBUG","message":"Couldn't find any dynatrace specific secrets in namespace keptn"}
...

This is a feature of the dynatrace-service that would allow fetching data from a Dynatrace tenant other than the one you use for monitoring your sample app. As long as you see the events in Dynatrace, we know that the Keptn/Dynatrace integration works as expected.
Can you also take a look into the Keptn Bridge (available at: http://your-keptn-endpoint/bridge) to see the result of the quality gate evaluation there?

Thanks @johannes-b I can now consistently deploy on OpenShift 4.5  and
I see my quality gate results in Dynatrace.
Please see
https://raw.githubusercontent.com/marcredhat/dynatrace/master/images/dev3.png
https://raw.githubusercontent.com/marcredhat/dynatrace/master/images/dev4.png
https://raw.githubusercontent.com/marcredhat/dynatrace/master/images/qualitygateresults.png
https://raw.githubusercontent.com/marcredhat/dynatrace/master/images/dev2.png
https://raw.githubusercontent.com/marcredhat/dynatrace/master/images/dev1.png
The bridge says I have no projects:
https://raw.githubusercontent.com/marcredhat/dynatrace/master/images/bridge.png
keptn configure monitoring dynatrace --project=keptnopenshift45 --service=carts
ID of Keptn context: b57812be-9120-4b7a-8aa0-c76442770cd2
Configuring Dynatrace monitoring
Dynatrace OneAgent Operator is installed on cluster
Setting up auto-tagging rules in Dynatrace Tenant
Tagging rule keptn_service already exists
Tagging rule keptn_stage already exists
Tagging rule keptn_project already exists
Tagging rule keptn_deployment already exists
Setting up problem notifications in Dynatrace Tenant
Checking Keptn alerting profile availability
Keptn alerting profile available
Creating Dashboard for project keptnopenshift45
Dynatrace dashboard created successfully. You can view it here: https://eye15053.live.dynatrace.com/#dashboards
Creating custom metric events for project SLIs
Failed to get custom queries for project keptnopenshift45
Resource not found
Creating custom metric events for project SLIs
No SLOs defined for service carts-db in stage production. Skipping creation of custom metric events.
Dynatrace Monitoring setup done

In the dynatrace-service logs (please see below), it seems that get-sli events are not sent to Dynatrace.
Also, nothing gets deployed in -staging and -production.
{"timestamp":"2020-08-14T06:56:14.669579752Z","logLevel":"INFO","message":"Sending event to Dynatrace API using dtCreds: dynatrace-credentials-keptnopenshift45"}
{"timestamp":"2020-08-14T06:56:14.948061044Z","logLevel":"DEBUG","message":"Dynatrace service returned status 200 OK"}
{"timestamp":"2020-08-14T06:56:14.948168402Z","logLevel":"DEBUG","message":"Dynatrace API has accepted the event"}
{"timestamp":"2020-08-14T06:56:14.948201889Z","logLevel":"DEBUG","message":"Response Body:{"storedEventIds":[4708073990361083874,-2303865422081304986,415550376662715760,6209218478970187478],"storedIds":["4708073990361083874_1597388175106","-2303865422081304986_1597388175106","415550376662715760_1597388175106","6209218478970187478_1597388175106"],"storedCorrelationIds":[]}"}
{"timestamp":"2020-08-14T06:56:14.948271454Z","logLevel":"INFO","message":"Sending event to Dynatrace API using dtCreds: dynatrace-credentials-keptnopenshift45"}
{"timestamp":"2020-08-14T06:56:15.047088808Z","logLevel":"DEBUG","message":"Dynatrace service returned status 200 OK"}
{"timestamp":"2020-08-14T06:56:15.047225846Z","logLevel":"DEBUG","message":"Dynatrace API has accepted the event"}
{"timestamp":"2020-08-14T06:56:15.047285683Z","logLevel":"DEBUG","message":"Response Body:{"storedEventIds":[5101987050463611697,-4261340289338490617,2538393843259250260,-4132496686703652614],"storedIds":["5101987050463611697_1597388175210","-4261340289338490617_1597388175210","2538393843259250260_1597388175210","-4132496686703652614_1597388175210"],"storedCorrelationIds":[]}"}
{"timestamp":"2020-08-14T06:56:21.676154801Z","logLevel":"DEBUG","message":"Received event: sh.keptn.event.start-evaluation"}
{"timestamp":"2020-08-14T06:56:21.687093798Z","logLevel":"INFO","message":"Check if event of type sh.keptn.event.start-evaluation should be sent to Dynatrace."}
{"timestamp":"2020-08-14T06:56:21.687203413Z","logLevel":"INFO","message":"Ignoring event."}
{"timestamp":"2020-08-14T06:56:22.275836521Z","logLevel":"DEBUG","message":"Received event: sh.keptn.internal.event.get-sli"}
{"timestamp":"2020-08-14T06:56:22.28325059Z","logLevel":"INFO","message":"Check if event of type sh.keptn.internal.event.get-sli should be sent to Dynatrace."}
{"timestamp":"2020-08-14T06:56:22.283281333Z","logLevel":"INFO","message":"Ignoring event."}
{"timestamp":"2020-08-14T06:57:12.50978067Z","logLevel":"DEBUG","message":"Received event: sh.keptn.event.start-evaluation"}
{"timestamp":"2020-08-14T06:57:12.521350995Z","logLevel":"INFO","message":"Check if event of type sh.keptn.event.start-evaluation should be sent to Dynatrace."}
{"timestamp":"2020-08-14T06:57:12.521398937Z","logLevel":"INFO","message":"Ignoring event."}
{"timestamp":"2020-08-14T06:57:12.929356512Z","logLevel":"DEBUG","message":"Received event: sh.keptn.internal.event.get-sli"}
{"timestamp":"2020-08-14T06:57:12.941623833Z","logLevel":"INFO","message":"Check if event of type sh.keptn.internal.event.get-sli should be sent to Dynatrace."}
{"timestamp":"2020-08-14T06:57:12.941647997Z","logLevel":"INFO","message":"Ignoring event."}

helm-service logs:
{"timestamp":"2020-08-14T18:20:50.712295463Z","logLevel":"INFO","message":"Finished upgrading chart keptnopenshift45-dev-carts in namespace keptnopenshift45-dev"}
{"timestamp":"2020-08-14T18:20:50.712430991Z","logLevel":"DEBUG","message":"Canary action set for service carts in stage dev of project keptnopenshift45 was received"}
{"timestamp":"2020-08-14T18:20:50.712502599Z","logLevel":"DEBUG","message":"Discard canary action set for service carts in stage dev of project keptnopenshift45 because service is not duplicated"}

Also tried https://github.com/keptn/examples/tree/master/simplenodeservice. It gets deployed to -dev just fine and shows up in Dynatrace. However, nothing gets deployed to -staging and -production...

Until we figure out why nothing gets deployed to -staging and -production, I changed my shipyard.yaml as follows:
stages:

name: "dev"
deployment_strategy: "direct"
#test_strategy: "functional"
approval_strategy:
pass: "automatic"
warning: "automatic"
deployment_strategy: "blue_green_service"
test_strategy: "performance"
....

and was able to confirm that Istio injection works fine and that the primary and canary get successfully deployed:
oc get VirtualService
NAME    GATEWAYS                             HOSTS                                                  AGE
carts   [public-gateway.istio-system mesh]   [carts.keptnopenshift45-dev.svc.cluster.local carts]   16h
oc get DestinationRule
NAME            HOST                                                   AGE
carts-canary    carts-canary.keptnopenshift45-dev.svc.cluster.local    8m47s
carts-primary   carts-primary.keptnopenshift45-dev.svc.cluster.local   8m46s

Hi @marcredhat,
thank you for pushing Keptn towards Openshift 4!
From the comments above, I can see that the Bridge is not working and the promotion of an artifact into the next stage is not working. For debugging the problem, I would need the support archive. Can you please generate a new support-archive and send it to me on Slack (@johannes-b is on holiday)?
Thanks, Andreas

Hi @marcredhat,
all errors are caused by the failing MongoDB, which Keptn depends on.
This is a known issue https://github.com/keptn/keptn/issues/1519
Can you please try out the workaround of running the mongodb in privileged mode, i.e. by executing
kubectl set image deployment/mongodb mongodb=keptn/mongodb-privileged:latest -n keptn?
Afterwards, please delete all old projects as they were not correctly created.

Thanks! I had a similar issue with jmeter so I edited the mongo  and jmeter-service deployments as follows:
securityContext:
runAsUser: 0
Will try
kubectl set image deployment/mongodb mongodb=keptn/mongodb-privileged:latest -n keptn and
report back

Everything deploys fine in -dev but -staging and -productions remain empty.
Also, evaluations result in "no evaluation performed by lighthouse because no SLI-provider configured for project keptn"

Hi Marc,
is the MongoDB now running smoothly and do you see projects in the Keptn Bridge?
To get around the error "no evaluation performed by lighthouse because no SLI-provider configured for project keptn", please execute: keptn configure monitoring dynatrace --project=PROJECTNAME
(This creates a ConfigMap that configures Dynatrace as SLI-provider for your project.)

Yes, thanks a lot for your help! I put together an easy automated way to deploy OpenShift 4.5, Service Mesh and Keptn on your laptop or virtual machine: https://github.com/marcredhat/crcdemos/blob/master/keptn.adoc
So I'd suggest using the above to reproduce any further issues, automate OpenShift / Keptn testing for new versions etc

Marc, many thanks for your great work and for pulling everything together into the document!
Let me bring @jetzlstorfer into this discussion to plan on a Keptn/OpenShift 4.4 tutorial published on: https://tutorials.keptn.sh/
This would help the Keptn project to share your findings.

Hi Marc,
today I managed to setup Keptn on OpenShift 4.5 according to your docu. The docu is phenomenal!
Just one remark: can you please add the step of adapting the mongodb:

kubectl set image deployment/mongodb mongodb=keptn/mongodb-privileged:latest -n keptn
securityContext: runAsUser: 0

I had to set runAsUser as follows (I removed the fsGroup property):
securityContext:
   runAsUser:<PHONE_NUMBER>

Can you tell me why I had to set it to this value?

I could successfully test Keptn on OpenShift 4.5. Hence, I close this issue.
Follow-up tasks is an integration test for Travis CI based on this issue: #2285


[Bug Report] el-tabs   listen oninput event to change value well emit oninut twice

Element UI version
2.13.2
OS/Browsers version
win10/chrome 95.0.4638.54
Vue version
2.6.14
Reproduction Link
https://codepen.io/ehejhrj/pen/ZEJyyKy
Steps to reproduce
click any unselected tab and will see console print twice
What is Expected?
when modify value emit input once
What is actually happening?
when modify value emit input twice

How about this?
https://codepen.io/skarbgud/pen/rNzqgMP?editors=1111

What do you think about this?
https://codepen.io/skarbgud/pen/rNzqgMP?editors=1111

What do you think about this?
https://codepen.io/skarbgud/pen/rNzqgMP?editors=1111

It can work


fix issue-#1686: bug reset selected options

I'm sorry, I don't have time to follow guidelines exactly, but tests pass and changes are very, very small...

Superseded by #1709


Black screen after VT switch

Seems like we still have issues with in-progress page-flips:
98:36:03.276 [ERROR] [backend/drm/drm.c:364] Failed to page-flip output 'eDP-1': a page-flip is already pending
98:36:03.311 [ERROR] [backend/drm/drm.c:364] Failed to page-flip output 'HDMI-A-1': a page-flip is already pending

Can't reproduce anymore, closing.


feat(mantine): add removeModalPadding prop to StickyFooter

Proposed Changes
Currently, without going full blown modal compound components, there is no good way of having a border above the modal footer that stretches to the edges of the modal. This is because the footer is inside the modal body and that body has padding by default.
The solution I suggest is to add a new prop on the StickyFooter component called removeModalPadding. When true, this prop removes the modal's default padding so that the footer properly hugs the bottom of the modal. Making it easy for people to achieve the desired look without introducing any breaking change.
See first Modal example in the demo website
<StickyFooter borderTop removeModalPadding>
    <Button variant="outline" onClick={() => setOpened(false)}>
        Cancel
    </Button>
    <Button onClick={() => setOpened(false)}>Accept</Button>
</StickyFooter>

Potential Breaking Changes

Acceptance Criteria

[ ] The proposed changes are covered by unit tests
[ ] The potential breaking changes are clearly identified
[ ] README.md is adjusted to reflect the proposed changes (if relevant)

I think using a variant="modal" instead of a custom prop would be more in line with Mantine's way of doing things

Your solution seems to work well and would achieve what we want. 👏  Although I will say that I like this suggestion:

I think using a variant="modal" instead of a custom prop would be more in line with Mantine's way of doing things

I think using a variant="modal" instead of a custom prop would be more in line with Mantine's way of doing things

Your solution seems to work well and would achieve what we want. 👏 Although I will say that I like this suggestion

✅


mount: can not  ensure ordered file handle lock and unlock by orderedMutex

Describe the bug
Seaweedfs  can not make IO in ordered  by file handle lock when I test.  The emaphore.NewWeighted is set to math.MaxInt64. The code is below in func newFileHandle(https://github.com/seaweedfs/seaweedfs/commit/22064c342585bddaa7ebdb21e39cac7db87826df)
fh := &FileHandle{
fh:      handleId,
counter: 1,
inode:   inode,
wfs:     wfs,
fh:           handleId,
counter:      1,
inode:        inode,
wfs:          wfs,
orderedMutex: semaphore.NewWeighted(int64(math.MaxInt64)),
}
I think it is a bug. I think semaphore.NewWeighted should be set to 1. Only in this way can we guarantee to prevent concurrency.
System Setup
OS version is ubuntu18.04
weed version : 3.34 ( the fault also happened in latset version )

please add the reason why you think it is a bug.

I think semaphore.NewWeighted should be set to 1.  Only in this way can we guarantee to prevent concurrency.

please add the reason why you think it is a bug.

The real purpose of orderedMutex is to prevent IO concurrency. If it is set to infinite, it is the same as no lock. How can it prevent concurrency? I think your original intention should be that this is 1.

@chrislusf

this is removed in https://github.com/seaweedfs/seaweedfs/pull/4089

the PR https://github.com/seaweedfs/seaweedfs/pull/4089 is merged.


Help ! How To on Production Mode and receave response after subsription is success.

Version of react-native-iap
Version of react-native
Platforms you faced the error (IOS or Android or both?)
Expected behavior
Actual behavior
Tested environment (Emulator? Real Device?)
Steps to reproduce the behavior
How To on Production Mode and receive response after subscription is success. Cant Figure Out

use purchaseUpdatedListener, You can receive purchase


fix(challenge): update variable names, assign empty array, update solution code, remove "use strict"

Checklist:

[x] I have read freeCodeCamp's contribution guidelines.
[x] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] All the files I changed are in the same world language, for example: only English changes, or only Chinese changes, etc.

Challenge: https://www.freecodecamp.org/learn/javascript-algorithms-and-data-structures/es6/create-strings-using-template-literals
Right now the same identifier is used in two different scopes and the name isn't that great if you ask me. This updates the inner and outer variable names. If anyone has better names for the variables I'm open for suggestions. But I at least think these are better.
I also assigned an empty array to the inner array instead of null, change the instructions to just say the function should return an array, and updated the solution code to just return the mapped array. I also removed the "use strict" as I don't think it is needed, right?
This challenge would likely benefit from more changes but I really just wanted to update the variable names. I was going a bit quick on this so hopefully, I didn't mess anything up.
Note: The hints page will need to be updated if/when this is merged.

This challenge never really made sense.  The user is not using template literal syntax to display anything.  The user is just creating an array of list item strings.  Why not something like the following:

Use template literal syntax with backticks to create an array of list element strings.  Each list item should be an element of the result object's failure array. Each list element (li) should have the class attribute text-warning. The makeList function should return the array of list item strings.
Use an iterator method (any kind of loop) to get the desired output (shown below).

Then the seed code would be the following (Note that I am using an arrow function, since the user has already learned this syntax):
const result = {
  success: ["max-length", "no-amd", "prefer-arrow-functions"],
  failure: ["no-var", "var-on-top", "linebreak"],
  skipped: ["id-blacklist", "no-dup-keys"]
};
const makeList = (failuresArr) => {
  // Only change code below this line
  const failureItemStrings = [];
  return failureItemStrings;
  // Only change code above this line
}

const failuresList = makeList(result.failure);

@RandellDawson
I do like some of the changes to the text, but I'm not so sure about this sentence:

Each list item should be an element of the result object's failure array.

That doesn't really seem to explain where the failure array strings should go in the template literal strings. Although, I am having a bit of a hard time coming up with a succinct way of explaining it without talking about the element text content or the element wrapping like it is now.
I would also go with failureItems for the inner variable name (no types on variable names).

@lasjorg  Would the following be any better?

Use template literal syntax with backticks to create an array of list element (li) strings.  Each list element's text should be one of the result object's failure array elements and have a class attribute with the value text-warning. The makeList function should return the array of list item strings.
Use an iterator method (any kind of loop) to get the desired output (shown below).

As far as the inner variable name, I am fine with failureItems:
const result = {
  success: ["max-length", "no-amd", "prefer-arrow-functions"],
  failure: ["no-var", "var-on-top", "linebreak"],
  skipped: ["id-blacklist", "no-dup-keys"]
};
const makeList = (failuresArr) => {
  // Only change code below this line
  const failureItems = [];
  return failureItems;
  // Only change code above this line
}

const failuresList = makeList(result.failure);

@RandellDawson Seems pretty good. I have pushed the update.

@RandellDawson I have updated the instructions with the changes suggested by @Manish-Giri, but with the two changes to the sentence, I proposed.


Support for Bankscrap v2.0.0

Refactored initialize
Renamed dni to nif
Renamed bundle_login, as now the initialize method in the base Bank class is already calling login.
Build account and transaction using money objects

@raulmarcosl I did the required changes to support the new Bank#initialize from Bankscrap v2.0.0, however I can't test them as I don't have an ING account. Can you test it and merge it if everything is ok?
Make sure to also test fetching investments. Thanks!
Also, this adapter is always returning accounts and transactions with EUR as currency. Can we get that data from the API?

@raulmarcosl 👀

I've checked this with my account and it works smoothly, great job!

@raulmarcosl just renamed :nif to :dni, could you test it again, merge the PR and push the gem if it works? Thanks! 🎉


idea  for debug & browser live development button

I see live development button showing HTML  CSS js on the desktop like files I suggest  add an option to  showing files  by   localhost server  that will cover PHP file
example
localhost/php_file.php
localhost/html_file.html

It is not clear to me what are you asking.
If you click the live development button it should open your browser, does not?

It's work
I  have suggestion to include php existence
To showing by live browser


Plugin doesn't load metadata anymore

Seems like Kobo reworked their Website a bit
On the book page there is "book id:" instead of "isbn:" now
Didn't see yet if there are any other changes but since yesterday my metadata comes from other sources only
The cover search is still working though

Seems to work again for me
Dunno why it didn't work yesterday and some hours ago

I did notice this but they have changed a few times now. Last time they changed the site significantly they spent a few weeks fiddling around with it but it only sometimes loaded the new version (I’m guessing they point some load balancers at their beta page?). I’m planning on waiting for them to settle down before doing a code change but in the meantime if it doesn’t work, I suggest trying a different region or just trying again the next day.
Ditto on the isbn to id thing but it looks like all versions of the site have changed it so I might change that first.


HBASE-24174 Fix findbugs warning in branch-1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 38s
branch-1 passed

+1 :green_heart:
compile
0m 40s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 39s
branch-1 passed

+1 :green_heart:
shadedjars
2m 56s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 53s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 50s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 54s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
checkstyle
1m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 50s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 52s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

+1 :green_heart:
unit
126m 26s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 29s
The patch does not generate ASF License warnings.

166m 39s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux ef51446d83a6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / 7b12709

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/1/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/1/testReport/

Max. process+thread count
4107 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/1/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 24s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m  0s
branch-1 passed

+1 :green_heart:
compile
0m 47s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 48s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 52s
branch-1 passed

+1 :green_heart:
shadedjars
3m 25s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 45s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 51s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
3m 14s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
3m 10s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m 14s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
compile
0m 46s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 46s
the patch passed

+1 :green_heart:
checkstyle
1m 48s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
3m 14s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m 26s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 33s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 43s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
3m 14s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

+1 :green_heart:
unit
127m 45s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

179m 45s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 27d4285c051c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / 7b12709

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/2/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/2/testReport/

Max. process+thread count
4765 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/2/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@Reidddddd  in branch-2+, this has been suppressed with
  @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="IS2_INCONSISTENT_SYNC",
      justification="Start is synchronized so authManager creation is single-threaded")
  protected ServiceAuthorizationManager authManager;

as part of HBASE-20069

Let's see if the warning fade, after this commit..

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 41s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 35s
branch-1 passed

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 43s
branch-1 passed

+1 :green_heart:
shadedjars
3m 13s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 52s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 48s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 55s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
compile
0m 43s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 43s
the patch passed

+1 :green_heart:
checkstyle
1m 31s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 50s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  9s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 35s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 46s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
3m 21s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

-1 :x:
unit
146m 20s
hbase-server in the patch failed.

+1 :green_heart:
asflicense
0m 32s
The patch does not generate ASF License warnings.

188m 10s

Reason
Tests

Failed junit tests
hadoop.hbase.mapreduce.TestLoadIncrementalHFilesUseSecurityEndPoint

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 49ba15a0205d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / 7b12709

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/4/artifact/out/branch-findbugs-hbase-server-warnings.html

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/4/artifact/out/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/4/testReport/

Max. process+thread count
3983 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/4/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Let me check how does the branch-2 suppress the warning...(

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
8m 16s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 40s
branch-1 passed

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 45s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 39s
branch-1 passed

+1 :green_heart:
shadedjars
2m 58s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
3m  0s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 57s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 57s
the patch passed

+1 :green_heart:
compile
0m 44s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 44s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 34s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 53s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 57s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 58s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

+1 :green_heart:
unit
129m 49s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

178m 25s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux b976b8aefc52 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / 03d73f1

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/testReport/

Max. process+thread count
4769 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/5/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 50s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  1s
The patch does not contain any @author tags.

-0 :warning:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 59s
branch-1 passed

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 46s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 38s
branch-1 passed

+1 :green_heart:
shadedjars
2m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 57s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 54s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
2m  2s
the patch passed

+1 :green_heart:
compile
0m 41s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 41s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 34s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 51s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  1s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 32s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 41s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 58s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

+1 :green_heart:
unit
134m 18s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 42s
The patch does not generate ASF License warnings.

176m  1s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 6efa22da7960 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / 03d73f1

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/6/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/6/testReport/

Max. process+thread count
4829 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/6/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

The suppress doesn't work?... o_0

@Reidddddd in branch-2+, this has been suppressed with
  @edu.umd.cs.findbugs.annotations.SuppressWarnings(value="IS2_INCONSISTENT_SYNC",
      justification="Start is synchronized so authManager creation is single-threaded")
  protected ServiceAuthorizationManager authManager;

as part of HBASE-20069

Oh ok, it seems we will have to put it over where we define authManager. Interesting!
Let's see if this works :)

Oh ok, it seems we will have to put it over where we define authManager. Interesting!
Let's see if this works :)

Tried,  the previous commit...

the 2nd commit suppressed on definition

Oh ok, it seems we will have to put it over where we define authManager. Interesting!
Let's see if this works :)

Tried, the previous commit...

oops, missed previous commit. This is weird, how come it is not getting suppressed on branch-1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 40s
branch-1 passed

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 39s
branch-1 passed

+1 :green_heart:
shadedjars
2m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 39s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 51s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 48s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 53s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 32s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 48s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 55s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 53s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

+1 :green_heart:
unit
129m 45s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 34s
The patch does not generate ASF License warnings.

169m 57s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 5373cc4d1f77 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / 0d86835

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/7/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/7/testReport/

Max. process+thread count
4536 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/7/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

so buggy........having no clue..

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 36s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
8m 34s
branch-1 passed

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 41s
branch-1 passed

+1 :green_heart:
shadedjars
2m 57s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 41s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 54s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 51s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 53s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 33s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 47s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
4m 49s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 31s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 40s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 51s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

+1 :green_heart:
unit
119m 33s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 33s
The patch does not generate ASF License warnings.

159m 34s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 541c12860bea 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / f80c4c2

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/8/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/8/testReport/

Max. process+thread count
4015 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/8/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

I just found the findbug's line number doesn't match.

I just found the findbug's line number doesn't match.

Oh, where can we see that?

This
Inconsistent synchronization of org.apache.hadoop.hbase.ipc.RpcServer.authManager;
locked 66% of time
Bug type IS2_INCONSISTENT_SYNC (click for details)
In class org.apache.hadoop.hbase.ipc.RpcServerField org.apache.hadoop.hbase.ipc.RpcServer.authManagerSynchronized 66% of the time
Unsynchronized access at RpcServer.java:[line 2270]
Unsynchronized access at RpcServer.java:[line 2271]

2270 and 2271 line is the original code without patch.

This
Inconsistent synchronization of org.apache.hadoop.hbase.ipc.RpcServer.authManager;
locked 66% of time
Bug type IS2_INCONSISTENT_SYNC (click for details)
In class org.apache.hadoop.hbase.ipc.RpcServerField org.apache.hadoop.hbase.ipc.RpcServer.authManagerSynchronized 66% of the time
Unsynchronized access at RpcServer.java:[line 2270]
Unsynchronized access at RpcServer.java:[line 2271]

2270 and 2271 line is the original code without patch.

wow, then it's not even looking in the patch, weird...

that's the findbugs report for the branch, before the patch. the report for after the patch says there is no issue. so it's correctly reporting exactly what you're trying to fix here.

-1 ❌
findbugs
2m 51s
hbase-server in branch-1 has 1 extant findbugs warnings.

+1 💚
findbugs
2m 51s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

(I am purposefully only commenting on what qabot is saying, not on wether or not ignoring this warning is a good idea.)

Thanks @busbey ! Oh, there're two findbugs..., oversight.
OK, let me remove the suppress and if the fix works.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m  0s
Docker mode activated.

-1 :x:
docker
6m 32s
Docker failed to build yetus/hbase:41990ba20a.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/1494

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/9/console

versions
git=2.17.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Rebased branch-1

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s
The patch appears to include 1 new or modified test files.

_ branch-1 Compile Tests _

+1 :green_heart:
mvninstall
9m 52s
branch-1 passed

+1 :green_heart:
compile
0m 41s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
compile
0m 44s
branch-1 passed with JDK v1.7.0_252

+1 :green_heart:
checkstyle
1m 39s
branch-1 passed

+1 :green_heart:
shadedjars
2m 53s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
branch-1 passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 40s
branch-1 passed with JDK v1.7.0_252

+0 :ok:
spotbugs
2m 54s
Used deprecated FindBugs config; considering switching to SpotBugs.

-1 :x:
findbugs
2m 51s
hbase-server in branch-1 has 1 extant findbugs warnings.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
1m 56s
the patch passed

+1 :green_heart:
compile
0m 40s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javac
0m 40s
the patch passed

+1 :green_heart:
compile
0m 45s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
javac
0m 45s
the patch passed

+1 :green_heart:
checkstyle
1m 30s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
shadedjars
2m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
hadoopcheck
5m  2s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2.

+1 :green_heart:
javadoc
0m 34s
the patch passed with JDK v1.8.0_242

+1 :green_heart:
javadoc
0m 42s
the patch passed with JDK v1.7.0_252

+1 :green_heart:
findbugs
2m 52s
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)

_ Other Tests _

+1 :green_heart:
unit
122m 21s
hbase-server in the patch passed.

+1 :green_heart:
asflicense
0m 31s
The patch does not generate ASF License warnings.

163m 55s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1494

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux e92de0aa6775 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1494/out/precommit/personality/provided.sh

git revision
branch-1 / d4b64c2

Default Java
1.7.0_252

Multi-JDK versions
/usr/lib/jvm/zulu-8-amd64:1.8.0_242 /usr/lib/jvm/zulu-7-amd64:1.7.0_252

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/artifact/out/branch-findbugs-hbase-server-warnings.html

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/testReport/

Max. process+thread count
4060 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1494/10/console

versions
git=1.9.1 maven=3.0.5 findbugs=3.0.1

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Yup, we are good :)
hbase-server generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
--

Thanks @virajjasani , we finally get here.


Set sb3_imitation.py to CPU to fix error with CUDA

Set device to CPU as a temporary fix for CUDA users.
Thanks to @MichaelrMentele for reporting this issue and testing the solution.
Relevant PR to track (thanks to @JayRothenberger for finding it):
https://github.com/HumanCompatibleAI/imitation/pull/831

@edbeeching
In short:
Running the script with CUDA setup returned an error, and this PR should make the script functional for everyone (on CPU) until the issue is resolved. There's some data in the linked PR for tracking the issue.


Pretty Stacktrace

Hey,
Any chance we can apply some of this to clean up all the async junk in stack traces?

Inspired by this tweet by @davkean

@kfrancis Thanks for those sources and bringing the issue to my attention. I'll mark this up for grabs in the 1x branch if someone wishes to tackle it and submit a PR.


filter npm scripts to only list those in selected folders?

Hi,
I'm noticing that the npm scripts for all of my yarn workspaces are listed, not merely the ones associated with the folders I've configured this to display.
Am I doing something wrong, is this a feature request, or is this a limitation in vscode itself, such as https://github.com/microsoft/vscode/issues/71635  ?

NVM.  I just de-selected the project root folder and discovered that the npm scripts for all of the non-selected yarn workspaces go away
I'd close this, but I thought perhaps you should see it first.  Perhaps this should be documented, as at least one person didn't find this obvious :)

Glad you sorted it out. Thanks!


[IconMenu] Add callback signatures to docs; add consistency to other …

[x] PR has tests / docs demo, and is linted.
[x] Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
[ ] Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

…props
Hey, another one for #3096
I made some small changes to some of the other props to line them up with the guidelines here
Anyway, let me know if you anything's off.

Nice job tracing down all those callbacks!

Thanks @mbrookes. I fixed the missed spaces, should be good to go now.

@theosherry Thanks!


Notifacation can not Arrivals

The message was not received when I restarted the process？

See #4 and #89 for discussion of notifications in the background.


Support for Ubuntu 24.04, 23.10, Fedora 39, Debian 12

There is a PR for adding this to the install script, but now we have moved most of the install code into the swiftly binary we should add this support to the binary

@adam-fowler / @patrickfreed / @cmcgee1024 , do you need any assistance for having Ubuntu 24.04 support?
Or is there a 2 step process; make the #115 available since work has already been done and then remove once swiftly binary is ready to do those steps? https://github.com/swiftlang/swiftly/pull/161 looks to be also be in a similar situation.

@vsarunas updates to the pull request is welcome and/or new pull requests are welcome.
There are several places in the code that would need to be changed to add Ubuntu 24.04 support. We're hoping to make it easier to manage this in the future using swift.org API. For now, I would use Ubuntu 22.04 as a guide to add 24.04. Some key areas to update:

Add a new static for it to PlatformDefinition to signal support
Add a prompt and auto-detection for it in Sources/Linux/LinuxPlatform.swift
Put the list of required system packages for it in Sources/Linux/LinuxPlatform.swift (derived from the docker file sources)
Use the new static platform definition for the swift.org API handling in Sources/SwiftlyCore/HTTPClient.swift
Create a new 24.04 docker compose file in docker/
We still have the old installer shell script in install/ that would need to be updated too for completeness
Updates to tests to get coverage for the platform in Tests/ and install/tests/

Is it safe to use swiftly on Ubuntu 24.04?
It appears to works fine if I select 22.04 during installation.

The install script PR for 2404 never got updated. Everything is moving to run from the executable and the install script is pretty much being removed. I don't know timings on when a new release is going to be though.

Same here. I've had to revert from Swiftly back to https://swiftlang.xyz, just to get 24.04 support.

Thanks everyone for your patience. We're trying to move these issues forward and get a preview release out on swift.org. This one is tagged as a release candidate for that release.

See #173 for a fresh path that should address this.

Okay nice! This is great progress!

This is fixed with #173
Ubuntu 23.10 was not added since it is end of life.


Driver Tests

Git is hard... Had to make a branch and re-commit all these files.
This is a set of tests for the instrument drivers.

There were a bunch of comments and review on the original PR #145, as @Jasper-Harvey0 said, git is hard. But we both learnt some stuff.


import/no-restricted-paths: Allow import type imports

It would be very useful for no-restricted-paths rule to have an option to allow import types for a zone, as these imports are erased at compile time anyway.

This would be awesome for tRPC projects!

Related: #2608

Related (same?): #1899


Get data from NodeCache?

Hi, let me know if there's a better place for this question (I didn't see a mailing list)
I'm looking into using the NodeCache recipe, but I'm having trouble figuring out how to actually get the data out of the node.  The Java Curator NodeCache has a  getCurrentData() method, and I'm trying to figure out what the equivalent is here.
I understand the recipes here are only somewhat finished, so I'm happy to add a a getter if necessary.  Just want to make sure I'm not missing something obvious.

@tevino can you chime in?

To update, I've switched to a TreeCache for now and it's working fine for now, but I'm still curious if I was misunderstanding NodeCache.

The NodeCache was extracted from the old code without much touch.
@bpodgursky I guess it is not mean to be used separately, for the absence of data getter, you could add one if you want.

Thanks @tevino.  I'm just using the TreeCache with depth=0 and data caching instead for now.  Hopefully isn't much of a performance hit.  If I run into issues I might take a look at exposing more methods on the NodeCache.


Update missing SQL compare to a fresh install

Questions
Answers

Description?
Update missing SQL compare to a fresh install

Type?
improvement

BC breaks?
no

Deprecations?
no

Fixed ticket?
-

Sponsor company
-

How to test?
Use https://github.com/PrestaShop/SeamlessUpgradeToolbox/tree/main/autoupgrade-scripts for test versions concerned

@kpodemski Are you saying that because the merge and release of the module will come after the 8.1.6 release?

@M0rgan01 I think we won't be able to release 8.1.6 with autoupgrade

@M0rgan01 Can you put the things to 8.1.7.sql so we are consinstent? I did it also with my previous fixes. Just a normal version file.

@Hlavtox The idea is to have a specific catch-up file, to separate the "real" migrations from those that have been forgotten.


Introduce organizations components

Type of change

[ ] 🐛 Bug fix
[ ] 🌟 New feature
[ ] 🔨 Breaking change
[ ] 📖 Refactoring / dependency upgrade / documentation
[ ] other:

Packages affected

[ ] @clerk/clerk-js
[ ] @clerk/clerk-react
[ ] @clerk/nextjs
[ ] @clerk/remix
[ ] @clerk/types
[ ] @clerk/themes
[ ] @clerk/clerk-expo
[ ] @clerk/backend-core
[ ] @clerk/clerk-sdk-node
[ ] @clerk/edge
[ ] build/tooling/chore

Description

[ ] npm test runs as expected.
[ ] npm run build runs as expected.

Closing in favor of #479  (staging branch)

Closing in favor of https://github.com/clerkinc/javascript/pull/479 (staging branch)


Consider adding reflect trait for LookTransform

Use case: I have a MoveCommand. I want that move command to take LookTransform or Transform as target (I also save the original). Reflect saves me tons of time writing code. Right now I am using my own fork with reflect.

Sorry that wasn't a very good opening. I think it should implement reflect because it is an engine component and is related to the Transform bevy type. I think it should match the capabilities of that object. Transform implements reflect and thus can be used in bevy ecosystem tools out of the box like the bevy reflect editor. So for me, I either have to write reflect impl for a wrapper class of LookTransform or maintain my own fork (unless there is some rust idea I don't know about here). There could be others, maybe perhaps Smoother, that may want to implement reflect.

Sure, it's not hard to derive reflect.
Out of curiosity, what do you use reflection for?

Sure, it's not hard to derive reflect.
Out of curiosity, what do you use reflection for?

I have implemented a command pattern in my turn based game. The gist is I would like to do is treat LookTransform as something that is "movable" for my command. Specifically I have a T Component and need to save this T and restore it when execute and undo are called respectively. Since they are disparate types I believe I can only implement my own trait for each with boilerplate for get T set T for everything I want to cover. Alternatively if I can reflect partialeq and clone instead (I think those are the types) I can write reflect code for all T that implements this much more easily.

And the other use case is reflect for this 3rd party plugin bevy-inspector-egui

I'll add a bit more context for my case:
#[derive(Clone, Debug)]
pub enum Command {
    OneWay(Box<dyn Executable>),
    Invertable(Box<dyn InvertableExecutable>),
}

impl PartialEq for Command {
    fn eq(&self, other: &Self) -> bool {
        match (self, other) {
            (Self::OneWay(l0), Self::OneWay(r0)) => l0
                .as_reflect()
                .reflect_partial_eq(r0.as_reflect())
                .unwrap_or_else(|| false),
            (Self::Invertable(l0), Self::Invertable(r0)) => l0
                .as_reflect()
                .reflect_partial_eq(r0.as_reflect())
                .unwrap_or_else(|| false),
            _ => false,
        }
    }
}

Having structs that implement reflect downstream allow for partial equality comparisons which is something I require. If I try traits I get an error that the traits are not object safe with partial eq. Reflection allows this easily as shown here and I think the alternative to traits and reflect would be to make many match statements, with manually downcasting and comparing.


Anyone interested in Apple Watch support?

Feature description

Are you interested by a WebSSH "companion" on the Apple Watch?
Which features do you need?
Are you using Cellular?

Not sure what it could realistically do...  maybe I lack imagination.

I imagine at least :

#307
#650
#354
#46

I could see a use in the form of shortcuts, accessible on a Apple Watch.

Connecting on the background to a certain server to shoot a command. (e.g. wake on lan, reboot, send a mail, anything you an script).
Check host availability

I would love WoL and ability to fire a command.

Thank you a lot @mbierman for your feedback!

Would be great to have WOL, restart server and launch snippets.
Also any other ideas with Apple Watch integration 👍


Ensures reproducible pipeline across OSs; various improvements

Because propseg results are slightly different across OSs (for more details, see neuropoly/spinalcordtoolbox#2769), the bug in #110 could occur.
This PR fixes the problem by:

replacing propseg by get_centerline

Fixes #110

Sorry for delay. I have been testing it on one subject and waiting for finish. Works fine 👍
Only; isn't usage obsolete?
https://github.com/spine-generic/spine-generic/blob/033e7f76ef46d40afacbeba5025c863e4adf4c81/processing/process_data.sh#L6
I tested it:
sct_run_batch -jobs -1 -path-data /md2/ds002900-download/ -path-output /md2/ds002900-download_results/ -include sub-douglas processing/process_data.sh

Only; isn't usage obsolete?

i don't think it's obsolete, as this is the argument passed by sct_run_batch wrapper-- some things will break (like all the other environment variables), but the usage remains the same.


i made create-react-app boilerplate --template typescript

i made a boilerplate of CRA typescript.
if i dont wanna use typescript anymore.
how can i exclude typescript in my boilerplate
(exclude new CRA)
there is no way?

Assuming you initialized the project with npx create-react-app my-app --template typescript or yarn create react-app my-app --template typescript , You can always rename your .tsx files to .jsx .
If you

change all your .tsx files to .jsx
remove typescript specific code from your files ( eg.  interface and types )
remove the extra and now unused dependencies npm uninstall --save typescript @types/node @types/react @types/react-dom @types/jest

I believe it will work same as javascript version of create-react-app

Great answer @solaris7x!
Closing this one as answered :)


add principal

How would I add a principal with this interface?

kadm.ank(princ, passwd)
Or
kadm.add_princ(princ, passwd)
They are simply aliases for one another. Please note that setting the passwd value to None Will result in a randomized password.
I'll be sure to update the docs.
-Russell J. Jancewicz

On Apr 25, 2015, at 14:21, Ted X Toth<EMAIL_ADDRESS>wrote:
How would I add a principal with this interface?
—
Reply to this email directly or view it on GitHub.

Thanks.

The docs have been updated (I had an old branch which needed to be merged).


luci-app-openvpn does not work

luci-app-openvpn | git-18.147.69097-36945b5-1
daemon.err uhttpd[1054]: sh: /etc/init.d/openvpn: not found
On the old version, everything worked

OpenVpn client does not work

I do not need an openvpn server

SOLUTION
Installing openvpn-openssl (2.4.4-4) to root...
@m0rDev
@dibdot  - thanks


Resolve Sanic breaking API changes introduced in 22.9.0.

The breakage didn't reveal itself until the default way to invoke subprocesses was changed from 'fork' to 'spawn' in release 22.12.0.

The solution follows the pattern described in their documentation:
https://sanic.dev/en/guide/deployment/app-loader.html

Removing 'app' as a global required retrieval of the app instance from Sanic's app registry in 'config_get'.

Thanks!


Support for TensorFlow 2.0 runtimes

Currently KFServing only support the following TensorFlow runtimes: 1.11.0, 1.11.0-gpu, 1.12.0, 1.12.0-gpu, 1.13.0, 1.13.0-gpu, 1.14.0, 1.14.0-gpu.
TensorFlow 2.0 has been out for quite some time now. All of our productive models are trained with it. Are there plans to start supporting 2.0 in KFServing?

Yes we should update to allow TFServing 2 images in configmap.
We should also check how NVIDIA TRTIS which supports Tensorflow allows Tensorflow 2 models.

/good-first-issue

Can I raise a PR for this?

@divyaprabha123  Yes! Looking forward to your PR.

KFServing has stopped maintaining the allowed version for each framework as of 0.4 release, user should be able to overwrite the docker image version with runtimeVersion field under framework spec, here is an example.
apiVersion: "serving.kubeflow.org/v1alpha2"
kind: "InferenceService"
metadata:
  name: "flowers-sample-tf2"
spec:
  default:
    predictor:
      tensorflow:
        runtimeVersion: 2.0.0
        storageUri: "gs://kfserving-samples/models/tensorflow/flowers"


Creating a Page on Github Using Hugo Themes

I'm trying to use the Hugo Pages theme with github: https://github.com/lq-2022/hugo-scroll to create a personal page. I generally do it this way:
1 - I create a new repository;
2 - Use username.github.io as the repository name;
3 - I download the theme zip file and, after extracting the files, I upload them via git and Rstudio to the github repository.
4 - Finally, I change the config.toml files in Rstudio to leave the page with my information.
However, when doing this with this theme I can only see the following page: https://florverde.github.io/ which is, precisely, the README.MD of the theme. In the README.MD file itself, it is suggested to copy the files from the exampleSite folder and replace the files from the source folder with them, however, when doing this, I receive the 404 error message. I would like a suggestion on how to use this theme! I found pages with the same installed, as shown below, and I've already tried to clone them, but I get the same error:
1 - https://lq-2022.github.io/
2 - https://ksmony.github.io
3 - https://TD-Hackathon-2022.github.io

@florverde I can see the pages you link are working, I supposed you got it working by yourself in the end :) I like the timeline feature you used in 3), care to share source code?


h&e filter causes problems for following filters

With 163 dataset, when switching over the filters, as soon as the H&E filter is loaded the H&e filter panel styays and does not update to other filters:

I am unable to reproduce this locally, and do not believe this particular filter utilizes async functions that would cause a destruction failure (a previously observed bug for similar box displays). @kruegert - if time allows, we can perhaps check your setup to see if there might be a setup issue that I have not addressed.

Try it with a dataset that does not have these channels/names.

Ah - that's it. Thank you. The issue is that the filter does not handle and skip datasets without H&E channels.

Fixed.


⚠ Secret Website 3 has degraded performance

In 405e5e5, Secret Website 3 ($SECRET_WEBSITE_3) experienced degraded performance:

HTTP code: 200
Response time: 2704 ms

Resolved: Secret Website 3 performance has improved in 9979c9b.


logo for HatkeMessenger

Good day !
can i submit a logo design for Hatke sir ?

okay sir, i'll do my best for a simple but awesome logo

Looks nice. you can update this in the launcher icon and then make a pr and thanks. :100:

i do not know how to make a pull request sir, i am a beginner here in github. can i message you on discord ?

No problem. You can send me this image in transparent background and send to my email id<EMAIL_ADDRESS>Meanwhile, you can check Pull Request Tutorial

did you received the email sir ?

I made a pull request sir. please do check , many thanks !


Use benchmark pretty names

The purpose of this pull request is to use more readable benchmark names on the results homepage.
We use the name declared in objective.py of the benchmark instead of using the name of the folder.

Codecov Report

Merging #440 (0e5b36f) into main (5ef9744) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #440      +/-   ##
==========================================
- Coverage   53.89%   53.89%   -0.01%
==========================================
  Files          44       44
  Lines        2757     2763       +6
  Branches      521      521
==========================================
+ Hits         1486     1489       +3
- Misses       1160     1163       +3
  Partials      111      111

Is it working with results?

I'm testing :)


Payments - I accept the Expensify Terms of Service and state are not clickable

If you haven’t already, check out our contributing guidelines for onboarding and email<EMAIL_ADDRESS>to request to join our Slack channel!

Version Number: 1.4.77-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4581183
Email or phone of affected tester (no customers<EMAIL_ADDRESS>Issue reported by: Applause - Internal Team
Action Performed:

Navigate to Settings > Wallet
Click on "Add payment method"
Click on the "Debit Card" option
Notice that I accept the Expensify Terms of Service and state are not clickable on the Debit card fields

Expected Result:
I accept the Expensify Terms of Service and state are clickable
Actual Result:
I accept the Expensify Terms of Service and State are not clickable
Workaround:
Unknown
Platforms:

Which of our officially supported platforms is this issue occurring on?

[ ] Android: Native
[x] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[ ] MacOS: Desktop

Screenshots/Videos
Add any screenshot/video evidence

https://github.com/Expensify/App/assets/78819774/832b341f-1f1d-4c1e-bfd1-d0d888fe03b7
View all open jobs on GitHub

@luacmartins  FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

This seems to share the same root cause as https://github.com/Expensify/App/issues/42768

I wonder why we even have that prop. We could have just reused submitButtonStyles

@ShridharGoel according to your RCA this issue has been present for a while? So does that mean it's not a blocker?

@ShridharGoel I think we should just remove the prop and use submitButtonStyles when needed to pass the flex style

Ah ok, makes sense. @ShridharGoel let's resolve this issue too - https://github.com/Expensify/App/issues/42768

Hmm if these bugs are introduced by https://github.com/Expensify/App/pull/35045 then the authors should fix it (cc @pac-guerreiro). We already agreed to revert the PR here.

This is fixed by the revert. Closing.


Fixed #26466 -- Added URL decoding to i18n set_language view

Added decoding for URLs taken from HTTP_REFERER in set_language view,
by using the Python's urllib.parse.unquote (through Django's six). Added a regression test for (#26466).

buildbot, add to whitelist.

Seems like something in the Python 2 tests treats UTF-8 as ISO-8859-1? (%C3%83%C2%A4 is urlencoding for Ã¤, which is a UTF-8 ä bytes read as ISO-8859-1.)

The test doesn't seem to be working as a regression test -- it's passing even with the fix reverted.
You may squash the commits when updating. Thanks.

That's strange. I'm pretty certain the test failed when the modified line in i18n.py was commented out, but I'll check if I've missed something. I hope my description of why the url pattern and view are required for the test to work was clear enough.

My comment "The test doesn't seem to be working as a regression test" isn't valid (I was testing with the url/view commented out). As mentioned in my other reply, let's just add something in the test to prevent those items from being removed which would cause the test to stop working as a regression test in the future.

Alright, I added an assert to the test to check that the url & view exist. Hopefully I didn't overdo with the comments.

merged in 9e3f141701b96b6974b3386f83dc76e70a41377d, thanks!


Syntax for putting long running rake tasks in background and return immediately

I have a rake task that I created a capistrano task for. the task could take a long time so i want to launch it as a background and let cap command return immediately.
here is the code :
namespace :long_running_task do
  task :default, :roles => :db, :only => { :primary => true } do
    run "cd /my/path && nohup bundle exec rake my_long_running_task RAILS_ENV=#{rails_env} 2>&1 >> /my/path/log/long_running_task.log &"
  end
end

When I run cap staging long_running_task, it doesn't automatically return. But when I run the command cd /my/path && nohup bundle exec rake my_long_running_task RAILS_ENV=staging 2>&1 >> /my/path/log/long_running_task.log & directly on the server, it returns immediately and the task is running in the background.
I've tried , :pty => false, :pty => true, but none of them works.
I've also found http://stackoverflow.com/questions/1109274/starting-background-tasks-with-capistrano and http://stackoverflow.com/questions/18076558/background-task-with-capistrano but none helped.
Thanks

To be fair, putting issues in a public facing site like Github makes it so much easier to discover via Google (which I just did) vs. a mailing list, which is not as easily accessible by crawlers. I'd love it if people kept putting issues here, even if you're breaking the "rules".

For anyone else who stumbles on this issue and gets a 404 on the github link, this appears to be what @kirs was referring to:
run "cd #{current_path} ; nohup #{fetch(:sidekiq_cmd)} -e #{rails_env} -C #{current_path}/config/sidekiq.yml -i #{idx} -P #{pid_file} >> #{current_path}/log/sidekiq.log 2>&1 &", :pty => false