Null safety support

It would be nice to be able to use this library on more recent versions of flutter.
All tests pass and the example is working correctly

One year later and the author has not responded, you could create a new package in pub.dev


Create release

Task
Related to: https://github.com/VirtuslabRnD/pulumi-kotlin/issues/204
Description
This release did not take place because of a CI/CD problem. We removed the tags and the versions mentioned in this PR do not exist. A successful release was made through this PR: https://github.com/VirtuslabRnD/pulumi-kotlin/pull/214.
This release includes the following versions:
cloudflare/v<IP_ADDRESS>
slack/v<IP_ADDRESS>
github/v<IP_ADDRESS>
random/v<IP_ADDRESS>
gcp/v<IP_ADDRESS>
google-native/v<IP_ADDRESS>
aws/v<IP_ADDRESS>
aws-native/v<IP_ADDRESS>
azure/v<IP_ADDRESS>
azure-native/v<IP_ADDRESS>
kubernetes/v<IP_ADDRESS>
nomad/v0.4.0
docker/v<IP_ADDRESS>
gitlab/v<IP_ADDRESS>
digitalocean/v<IP_ADDRESS>
alicloud/v<IP_ADDRESS>

This release does not exist.


Properly mark files as external

Without it, some code is duplicated at the end.
The creation of the LanguageServiceDefaultsImpl are in both monaco.contribution.js AND tsMode.js
The first time the typescript language is used, tsMode is dynamically imported from monaco.contribution, which reset the typescriptDefaults/javascriptDefaults by creating new instances of LanguageServiceDefaultsImpl
fix for https://github.com/microsoft/monaco-editor/issues/2931

Fixed in https://github.com/microsoft/monaco-editor/commit/69809452a843de346958f253de730d567994debb.


move ntp include to prerequisites

Skip ntp inclusion if skip_prerequisites is set.

This LGTM... I was trying to fix the build failures in another branch, but am missing something. Basically, some new Gem came out which is breaking our dependencies. As such, I am going to relax the "must pass CI" requirement for merging to master, at this time. We need to fix this before we do another release of the cookbook, though.

If you merge/rebase master into this branch, it should pass tests.


RuntimeError: cuda runtime error (11) : invalid argument at /pytorch/aten/src/THC/THCGeneral.cpp:405

Tried to execute
python deep/train.py .
Code got crashed at https://github.com/ZQPei/deep_sort_pytorch/blob/master/deep_sort/deep/model.py#L82
THCudaCheck FAIL file=/pytorch/aten/src/THC/THCGeneral.cpp line=405 error=11 : invalid argument
Traceback (most recent call last):
File "/snap/pycharm-community/179/plugins/python-ce/helpers/pydev/pydevd.py", line 1434, in _exec
pydev_imports.execfile(file, globals, locals)  # execute the script
File "/snap/pycharm-community/179/plugins/python-ce/helpers/pydev/_pydev_imps/_pydev_execfile.py", line 18, in execfile
exec(compile(contents+"\n", file, 'exec'), glob, loc)
File "/home/sdk/Analysis/centerNet-deep-sort-master/deep/train.py", line 194, in
main()
File "/home/sdk/Analysis/centerNet-deep-sort-master/deep/train.py", line 186, in main
train_loss, train_err = train(epoch)
File "/home/sdk/Analysis/centerNet-deep-sort-master/deep/train.py", line 89, in train
outputs = net(inputs)
File "/home/sdk/anaconda3/envs/reinforce_learn/lib/python3.6/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "./model.py", line 84, in forward
x = self.conv(x)
File "/home/sdk/anaconda3/envs/reinforce_learn/lib/python3.6/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/sdk/anaconda3/envs/reinforce_learn/lib/python3.6/site-packages/torch/nn/modules/container.py", line 92, in forward
input = module(input)
File "/home/sdk/anaconda3/envs/reinforce_learn/lib/python3.6/site-packages/torch/nn/modules/module.py", line 489, in call
result = self.forward(*input, **kwargs)
File "/home/sdk/anaconda3/envs/reinforce_learn/lib/python3.6/site-packages/torch/nn/modules/conv.py", line 320, in forward
self.padding, self.dilation, self.groups)
RuntimeError: cuda runtime error (11) : invalid argument at /pytorch/aten/src/THC/THCGeneral.cpp:405

Error occured at these lines outputs = net(inputs) and x = self.conv(x).
Seems that your inputs is incorrect.

x=torch.randn(4,3,128,64, dtype=torch.float, device=device)

Problem with conda pytorch version...


Use of struct{} instead of string where value is ignored

I have stumbled upon the code here, where you are using string (as in map[string][]string) and nil, instead of struct{} and struct{}{}. From a quick glance I cannot see you using the value anywhere, and using struct{} would communicate this intent better, therefore making the codebase slightly cleaner, and additionally it would consume less memory, but this memory consumption is negligible either way.
From:
var possibleCap = map[string][]string{
  "account-notify": nil,
[...]
}

to:
var possibleCap = map[string]struct{}{
  "account-notify": struct{}{},
[...]
}

You may also like to compare the ASM output: https://go.godbolt.org/z/4IMjlE

the values are used here, thus changing to struct{}{} would break this: https://github.com/lrstanley/girc/blob/102f17f86306c2152a8c6188f9bb8b0e7288de31/cap.go#L103-L123

This is actually odd, I changed everything to struct{} and struct{}{} leaving parseCap() alone. It compiled and the tests were successful. I even used it to connect to a server through SASL (PLAIN), and it says it has the proper capabilities, but it says it doesn't have capability sasl through c.HasCapability, nor with mine or the original version. Yet the test cap_test (where you use ls["sasl"] instead though) passes, both with your version and mine.
Although I figured the reason you use []string is that a capability can be in the form of sasl=PLAIN,EXTERNAL, and you need to store both PLAIN, and EXTERNAL, but then why does all tests pass, and seemingly have identical results after I make those modifications? Everything seems to work correctly.
Loosely-related: is it possible right now to get PLAIN and EXTERNAL? Is it exposed? c.HasCapability returns only a bool, but what if I want to know the arguments of said capabilities? Should c.HasCapability return (bool, []string) perhaps?

c.HasCapability("sasl") works for me without issue, both on servers that don't provide any params (so it's assumed to be PLAIN), and servers that provide PLAIN,EXTERNAL. Did you verify the SASL connection was a success? Can you provide the server you used to test this on? This is what I used (can also test with testnet.oragono.io).
package main

import (
	"log"
	"os"

	"github.com/nmeum/girc"
)

func main() {
	client := girc.New(girc.Config{
		Server: "irc.byteirc.org",
		Port:   6667,
		Nick:   "girc-test1",
		User:   "girc",
		Debug:  os.Stdout,
		SASL:   &girc.SASLPlain{User: "*truncated*", Pass: "*truncated*"},
	})

	client.Handlers.AddBg(girc.CONNECTED, func(c *girc.Client, e girc.Event) {
		log.Printlny(c.HasCapability("sasl"))
	})

	if err := client.Connect(); err != nil {
		log.Fatal(err)
	}
}

As for HasCapability, this is not the capabilities of the server, rather the capabilities that were successful between the client and server. Unfortunately, the IRCv3 spec does not specify the successful params back in the ACK response if the client happens to acknowledge one of the sasl mechanisms. So, the only way that HasCapability could return the specific ones that were acknowledged, is if the writing method appends that. That would have to be manually implemented for each IRCv3 extension which has parameters (which isn't really worth the effort or complexity), and would also break if the user decides to acknowledge things outside of the internal sasl ack in girc.

As for replacing []string with struct{}/struct{}{}/etc, it's a non-issue. The memory consumption doesn't matter since it's only used once maybe twice, in a very small scope. In addition, changing it would make the code more complex (we have to compare the possibleCap list against the SupportedCaps, why spend the time to try and differentiate struct{} vs []string when you can just compare the two). Lastly, this method supports future extensions of the IRCv3 spec, as future extensions, we may only support specific params, and this will take advantage of that. It's not really used right now, as only one entry of the spec really uses params.

Ah, I just added:
if c.HasCapability("sasl") {
  log.Println("Has capability 'sasl'")
} else {
  log.Println("Does not have capability 'sasl'")
}

to my own code and it seems to work, so I am not entirely sure what the issue could have been. I did indeed check for RPL_SASLSUCCESS, and despite that, c.HasCapability("sasl") didn't work. It might have been my fault though, I have several different versions scattered around my filesystem, so it's possible that I was running a version without SASL enabled. Sorry about that. Sleep deprivation at its finest. :D

checking right after RPL_SASLSUCCESS may be a timing issue, since the client doesn't consider SASL fully successful until the CAP transaction is complete and shows SASL in the ACK list iirc (on my phone atm). I usually wait for the custom CONNECTED event, as generally at that point the handshaking and other connection related state changes are complete.
---- On Wed, 05 Sep 2018 22:14:05 -0500<EMAIL_ADDRESS>wrote ----
Ah, I just added:
if c.HasCapability("sasl") {
log.Println("Has capability 'sasl'")
} else {
log.Println("Does not have capability 'sasl'")
}
to my own code and it seems to work, so I am not entirely sure what the issue could have been. I did indeed check for RPL_SASLSUCCESS, and despite that, c.HasCapability("sasl") didn't work. It might have been my fault though, I have several different versions scattered around my filesystem, so it's possible that I was running a version without SASL enabled. Sorry about that. Sleep deprivation at its finest. :D
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub, or mute the thread.

What I meant by checking RPL_SASLSUCCESS is that I added a handler for it which prints a message that it succeeded, and then I did an INVITE (poor man's test case) afterwards which calls c.HasCapability("sasl"), and it failed. I cannot reproduce this now anymore, so I am not exactly sure what caused this issue. It all seems to work just fine now using my latest code. I will give a detailed report and dig deeper if I run into this issue.
It might have been that I used my friend's server who ran the same version of oragono, but with a different configuration. I remember not being able to type NICK <account> in case the nick was registered, which was odd because according to oragono's documentations, the account name has nothing to do with the nick. Sadly I cannot reproduce this either, I will have to ask my friend to set his server up which: 1) doesn't append nicknames in responses, causing more off-by-one issues, 2) requires SASL before sending the raw command NICK <name> where name is an account. It works fine with my configuration, so I really have to ask him for his. :D


"PT Run" not functioning as expected. when you click on the file/program you want to select, the input window disappears and then a much larger rectangular black box appears in its place

Microsoft PowerToys version
0.53.1
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
Alt+Space > after inputting the first character in the text field, it freezes for about 2-3 seconds, and then all the rest of the characters you entered during the delay, all input at one time after the delay.
Randomly, also usually after a restart, so the first time the tool is used on a fresh boot, there's no cursor waiting for text input, so you start typing and nothing appears after Alt+Space. You need to ESC out and re-input Alt+Space to see the cursor flash in the text field. You see "Start Typing", but you can't type anything. I think maybe you could start typing if you actually bring the mouse and click inside the field, I've never tried it, but there's no focus on the tool.
Additionally, not always, usually on the first time after a reboot, using this tool to select a file/program, when you click on the file/program you want to select, the input window disappears and then a much larger rectangular black box appears in its place and the selected program never loads and you have to run through the process again.
✔ Expected Behavior
Smooth interaction with the interface.
Use the shortcut to bring up the PowerToys Run and have it function as anticipated.
❌ Actual Behavior

Delay after first character is input
no cursor flashing for character input
selecting a program doesn't run the program and instead, a large black box appears and the tool closes.

Other Software
N/A

Same here with the PT Run freezing after first character. It freezes until PT Run is toggled off in settings.
PowerToys was just installed recently. I have over 300 apps on the PC, and recently toggled enhanced search on in Windows Settings, either of which could possibly strain the tool.
PowerToysReport_2022-01-09-20-18-39.zip

Having the same issue, the lag/freeze is very noticeable. It wasn't there in the earlier version.

Commenting just on "Delay after first character is input"
I've noticed this recently, and can confirm that at least on my system this is a performance regression introduced by v0.53.1 . With v0.51.1 the PTRun app search is almost instant. With v0.53.1, there's a lengthy delay after the first character input, as the OP reports.
I've tried disabling all plugins other than 'Program' (launching apps is my main use case), with the same result.

+1 Seeing the same behaviour using Win10 Build 19044.1415 Rolling back to v<IP_ADDRESS>.

i am facing the same. how do you roll back .. i tried installing the old version but it says new version is already installed..
Do i have to reinstall powertoys ?

+1 Seeing the same behaviour using Win10 Build 19044.1415 Rolling back to v<IP_ADDRESS>.

i am facing the same. how do you roll back .. i tried installing the old version but it says new version is already installed.. Do i have to reinstall powertoys ?

Uninstall Powertoys and then reinstall previous version.  I also deleted the preferences folder for powertoys found here C:\Users*Yourusername*\AppData\Local\Microsoft\PowerToys
Make sure you replace "yourusername" with your windows username.  please note deleting this folder will also reset all your powertoys  custom settings.

The only change made to the Programs plugin has been to verify more accurately if an UWP app can run elevated.
I can't reproduce this locally, but we might be able to do a custom build to verify if this was the case.

Additionally, not always, usually on the first time after a reboot, using this tool to select a file/program, when you click on the file/program you want to select, the input window disappears and then a much larger rectangular black box appears in its place and the selected program never loads and you have to run through the process again.

@cxj05h
Can you please try to send a screenshot for this?

I've just tried to revert some changes, and it seems that this change introduced this delay:
https://github.com/microsoft/PowerToys/pull/15033

For the "Delay after first character is input" part, it's a duplicate of https://github.com/microsoft/PowerToys/issues/15364

Regarding the ptrun not having focus the first time, it's a duplicate of https://github.com/microsoft/PowerToys/issues/13643

So, it makes sense to have this issue be about "the input window disappears and then a much larger rectangular black box appears in its place", since the other have issues created already.
For this one, it'd be good to have a screenshot.

Additionally, not always, usually on the first time after a reboot, using this tool to select a file/program, when you click on the file/program you want to select, the input window disappears and then a much larger rectangular black box appears in its place and the selected program never loads and you have to run through the process again.

@cxj05h Can you please try to send a screenshot for this?

yes will try to grab this next time i see it.

So, it makes sense to have this issue be about "the input window disappears and then a much larger rectangular black box appears in its place", since the other have issues created already. For this one, it'd be good to have a screenshot.

The box turned white as soon as I captured it, but that's exactly it otherwise.

Thank you. Will try to replicate.
Have you tried the debug build to see if it fixes the slowness issue?

sting fixing the issue

Can I install this over the production release? In other words, will it remove some settings I have saved?

Won't remove settings (excluding the possibility of some bug, there are some FancyZones reset bugs that we've been unable to fix yet).
But you do need to uninstall first to install this version.

Ah Fancy Zones...no....
Ok, I'll check it out...for you!

So, it makes sense to have this issue be about "the input window disappears and then a much larger rectangular black box appears in its place", since the other have issues created already. For this one, it'd be good to have a screenshot.

The box turned white as soon as I captured it, but that's exactly it otherwise. So this occurred after I typed the word "broad", "b-r-o-a" > black box appeared > tool closed

@jaimecbernardo , @cxj05h
I am confused. What is happening to the WindowsSettings plugin icon of the results? This isn't the official one. 🤔

That's a good question. a bug report once you have 0.53.1 running again might be helpful.
We've had some cases of installs not happening correctly and getting some files wrong.
/bugreport

bet.
here you go.
PowerToysReport_2022-01-10-21-07-27.zip

For testing fixing the issue of "Delay after first character is input", would you mind installing a (non-signed) debug build to test if it fixes it? https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-fix-issue-15395-ptrun-slowness
First uninstall your current installation of PowerToys, then install this fix build and test it. @cxj05h @erictbar @damchey @crispinb @PhoenixCODE2322 @Memories4Life
Thanks, in advance.

yuup this fixed it... should i keep using this as it fixes the issue or should i install Release v0.51.1 ?
and why did the topic name change ?

For testing fixing the issue of "Delay after first character is input", would you mind installing a (non-signed) debug build to test if it fixes it? https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-fix-issue-15395-ptrun-slowness
First uninstall your current installation of PowerToys, then install this fix build and test it. @cxj05h @erictbar @damchey @crispinb @PhoenixCODE2322 @Memories4Life
Thanks, in advance.

doesn't want me to instal d/t: "a later version of PT is already installed"
I need to uninstall?

For testing fixing the issue of "Delay after first character is input", would you mind installing a (non-signed) debug build to test if it fixes it? https://github.com/jaimecbernardo/PowerToys/releases/tag/0.0.1-test-fix-issue-15395-ptrun-slowness
First uninstall your current installation of PowerToys, then install this fix build and test it. @cxj05h @erictbar @damchey @crispinb @PhoenixCODE2322 @Memories4Life
Thanks, in advance.

doesn't want me to instal d/t: "a later version of PT is already installed" I need to uninstall?

ooohk sorry, just saw "first uninstall" lol, ok my bad.
will get back with you.

yep, this is working perfect

yep, this is working perfect

And I still have my fancy zones saved

will there be a official hotfix release for this ?

Thanks for testing.
Yes, we're thinking this is worth a hot fix.
The title changed because the original issue is about 3 different issues and 2 of them already have other issues created.
@cxj05h , does this fix your "white rectangle" error as well?

Thanks for testing. Yes, we're thinking this is worth a hot fix. The title changed because the original issue is about 3 different issues and 2 of them already have other issues created.
@cxj05h , does this fix your "white rectangle" error as well?

yeah i haven't had an issue yet with that.

Can I download the newest release now with this issue resolved or should I stick with the fix build until later notice?

@jaimecbernardo What's the status for this?

It seems to have been fixed alongside the other bugs. These fixes have been released already @cxj05h

It seems to have been fixed alongside the other bugs. These fixes have been released already @cxj05h

thank you


What is the status of OpenXmlPackage.Save?

The power tools reference OpenXmlPackage.Save. I've gotten a Nuget build that has it uncommented with different logic. I'm not sure where that is coming from.

@daniel-white, Could you be a little more specific? Which part (class, method) of the PowerTools reference the OpenXmlPackage.Save() method and which NuGet build of what has it uncommented with different logic?
I first contributed the save-and-clone functionality in January 2015 (see 06fa235) and the OpenXmlPackage class still has my Save() method (with later enhancements):
        /// <summary>
        /// Saves the contents of all parts and relationships that are contained
        /// in the OpenXml package, if FileOpenAccess is ReadWrite.
        /// </summary>
        public void Save()
        {
            ThrowIfObjectDisposed();
            if (FileOpenAccess == FileAccess.ReadWrite)
            {
                lock (_saveAndCloneLock)
                {
                    SavePartContents();
                    // TODO: Revisit.
                    // Package.Flush();
                }
            }
        }

However, I also just found a few lines of code in which a previous Save() method was commented out. That is likely the source of the confusion and those commented-out lines should be removed.
That current Save() method works just fine in production code (and I might have even written the part of the PowerTools that references that method).

Thanks @ThomasBarnekow. I must have had a bad version referenced somewhere in the powertools. My CTRL+F foo must have been lacking. I pointed the PowerTools vNext at the SDK's 2.7.2 and it seems to be working. The powertools needs help IMO w/ referencing this project.


docs: refactor user guides

What type of PR is this?

What this PR does / why we need it:
Which issue(s) this PR fixes:

Currently, as more and more guides added to user-guide, it is hard to find interested content, we need to do a little grouping on the docs.
Before:

After:

one conflict, after rebase, lets make sure this one gets in soon


Unhandled Rejection (TypeError): Cannot read properties of undefined (reading 'digest')

When I start the developement server I get a Unhandled Rejection (TypeError): Cannot read properties of undefined (reading 'digest') .
I'm able to connect the wallet and that's what I get next. Tried both on mainnet and devnet. The candy-machine.ts is untouched all the values are default.
It get's the provider and fails in the line #163 @ fetchIdl()
   160 |   preflightCommitment: "recent",
   161 | });
   162 |
 > 163 | const idl = await anchor.Program.fetchIdl(
^  164 |   CANDY_MACHINE_PROGRAM,
   165 |   provider
   166 | );

Same problem here ;)

I have a workaround, but it won't work for all users.
I switched from Ubuntu (WSL2) to Windows 10, works like a charm.
It seems to be a problem with @project-serum/anchor but I didn't dig deeper as for now I'll just use the easy fix.

Found this, might be linked ?
https://stackoverflow.com/questions/57146558/typeerror-digest-of-undefined-in-development-environment

Found this, might be linked ? Currently I'm building on a vps, will try on local
https://stackoverflow.com/questions/57146558/typeerror-digest-of-undefined-in-development-environment
Seems like it solved it to me,
Solution:
Put a SS certificate or run it on localhost

That fixed it!

@halaprix which commands did you run to make it work?


[Bug] Deleting the last item problem of the ACL topic/group perms or the global white list caused by the UtilAll#split func flaw

Before Creating the Bug Report

[X] I found a bug, not just asking a question, which should be created in GitHub Discussions.

[X] I have searched the GitHub Issues and GitHub Discussions  of this repository and believe that this is not a duplicate.

[X] I have confirmed that this bug belongs to the current repository, not other repositories of RocketMQ.

Runtime platform environment
OS(CentOS release 7.6.1810)
RocketMQ version
branch(develop) version(5.1.5-SNAPSHOT)
JDK Version
Compliler(Oracke JDK 1.8.0_361) OS(CentOS release 7.6.1810)
Describe the Bug
I found an bug of ACL during my work on RocketMQ.
When I tried to delete the last item of the ACL topic/group perms, there was an error which indicates the resouce fomat is incrorrect. And there's also an similar problem of the global white list, which is always remain an empty data at last.
Steps to Reproduce
To reproduce you can use two ways:

If you use the Dashboard(take the topic/group perms for example)
1.1 Create an ACL with mutiple topic perms and group perms.
1.2 Delete the topic perms or group perms one by one.
1.3 The error woud appear when delete the last one.

If you want to create an test method for reproduce
2.1 New an DefaultMQAdminExt and config it with namesrv and then start it.
2.2 New an PlainAccessConfig and setGroupPerms(Collections.EMPTY_LIST), setTopicPerms(Collections.EMPTY_LIST).
2.3 Then call DefaultMQAdminExt #createAndUpdatePlainAccessConfig.
2.4 Or to call DefaultMQAdminExt #updateGlobalWhiteAddrConfig with the second parmeter an empty string.

What Did You Expect to See?
For the topic/group perms, it should not be an error to delete the last item.

For the global white list, it should not be an empty data

What Did You See Instead?
For the topic/group perms, it popup an error:
org.apache.rocketmq.client.exception.MQClientException: CODE: 209  DESC: Parse Resource format error for .
The expected resource format is 'Res=Perm'. For example: topicA=SUB

For the global white list, it remains an empty data

Additional Context
I've already found and fixed the bug, and I'll submit an PR later.

@RongtongJin @fuyou001


[Sema] Requestify default argument type checking

This PR introduces two new requests, one to compute initializer contexts for default arguments, and another to type-check default arguments within this context.
This PR then splits getDefaultValue into 2 accessors:

getStructuralDefaultExpr which retrieves the potentially un-type-checked default argument expression.

getTypeCheckedDefaultExpr which retrieves a fully type-checked default argument expression.

And also adds hasDefaultExpr, which allows checking for the presence of a default expr without kicking off a request.
On its own, this isn't enough to resolve SR-11085, I'm going to tackle that in a follow-up to keep the size of this PR down.

@swift-ci please test

A high level comment: Why do we need to keep around a trichotomy of "parsed/typechecked/unchecked" if all of the callers before don't really care about the distinction between parsed and typechecked?  I think you can get away with "definitely typechecked" and "potentially typechecked - no requests".

@CodaFi My understanding was that we were aiming to eventually get rid of that mutable state within the AST, so the result of getParsedDefaultExpr doesn't change if we happen to trigger the type-checking of the default.

I guess I'm wondering what's stopping us from doing it now?

@CodaFi From removing the mutable state? Things like the AST walker currently still need to set it (until it is changed to return a new AST), and as I understand it, it's currently more efficient to access the state from the AST than the evaluator's cache.

Ping @slavapestov

@swift-ci please test

@swift-ci please test

@swift-ci please test

Build failed
Swift Test OS X Platform
Git Sha - e3a53cebe5265999f7157c9757ca74c4e3764bbc

Sorry, I’ll review this today.

@swift-ci please test

@swift-ci please test

Sorry in advance @hamishknight, #28179 is gonna cause a bunch of merge conflicts here.

@CodaFi No worries, it's worth it :)

@swift-ci please smoke test

@swift-ci please smoke test

@swift-ci please smoke test Linux platform

@swift-ci please smoke test Linux platform

@swift-ci please smoke test

@swift-ci please smoke test


fix(mdx-loader):ensure heading anchor slugs respect GitHub emoji beha…

Pre-flight checklist

[x] I have read the Contributing Guidelines on pull requests.
[x] If this is a code change: I have written unit tests and/or added dogfooding pages to fully verify the new behavior.
[ ] If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation
Fix https://github.com/facebook/docusaurus/issues/9194

Test Plan

Test links

Deploy preview: https://deploy-preview-9202--docusaurus-2.netlify.app/tests/blog/2023/08/05/
Related issues/PRs
https://github.com/facebook/docusaurus/issues/9194

LGTM thanks 👍


Battery levels

Hi Nathan, thanks for this library, it's excellent and I'm hoping to complete a node-red package in the next few days that uses it as a dependency, rather than previous attempts that went the 'roll-your-own' route and fizzled out...
I do wonder though about the Nuimo battery level. At the moment when getting device.batteryLevel for my Nuimo, it's returning 100, despite the fact I've had it off charge for 4-5 days and at least 48 hours of that time has been connected (admittedly via BLE but...) to a RPi3, and I've been clicking and interacting with it a fair bit.
That seems odd to me. Is it possible that there's been a firmware change since this library coded the battery level that means it's giving an inaccurate value?

Hmm I shouldn't have been so quick to open an issue!!
Now it's reporting 97%, so I guess it's just super efficient! - or the device isn't great at reporting it's own battery, given it went from 100 to 97.

Thanks! Glad you find the library useful.
Admittedly I haven't tried looking at the battery status for a while (when mine just stops working, I just charge it overnight), but last time I looked it was working fine. Has yours gone down any further?
I think the library might report 100 for a while until the first battery report comes in from the device, which might take a while as I think it only sends reports when the battery level changes. This is a good point - I might change it so that it does a "read" on first connect instead of waiting for "notifies".
Unfortunately my Nuimo's are in a container by sea at the moment as I'm moving country! So it may be a couple of months until I'm able to look at this.

So having spent a few more days with it, I'm seeing far more normal battery behaviour, except for that initial report of 100 as you mention. All is well :) Just seems the Nuimo does the classic battery thing of reporting discharge less than linearly.
Thanks for responding! I'll close this issue.


90% CPU usage

VSCode Version: Version 1.13
OS Version: WIN 2012 DC

Steps to Reproduce:

Just download, install and open the VS Code. Unbelievable CPU Usage is 90%. I can't do anything and kill the app from task.

me too

To find out more about this issue, we need to get at the process that is causing the high load. VS Code creates multiple processes, each with different tasks. Depending on your OS you can get at the full command line of the process and paste it here. On Mac, the Activity Monitor allows to find the PID of the process and from a terminal ps aux | grep <pid> reveals its arguments.

On Windows a tool like Process Explorer helps:

Once you have the information please update this issue with it. Thanks!


Can an app that uses teams bot and tab be fixed as the first page in a mobile environment?

I created an app using the Teams developer portal. Then, I created a chatbot using a bot and connected it to the bot.
I also discovered that tabs were added when I set up [Personal App] in the Teams Developer Portal, so I added web pages as tabs.
And although I placed the [Chat] tab connected to the bot at the top, the first tab is displayed on the first page on mobile.
Can I pin the first page through chat?
[Capturing the ‘Personal App’ setting value in the developer portal]

[When running the app on a PC, the first screen is captured as ‘Chat’]

[When running the app on mobile, the first screen is captured as a ‘tab’]

안녕하세요 Meghana-MSFT
나는 고객에게 설명해야하기 때문에 공식 답변이 필요합니다.
따라서 한번더 확인겠습니다.
해당 팀즈 봇 버튼은 팀즈 기본 설계를 따른 것이기 때문에 저렇게 나타나는 것이 정상이며
해당 버튼을 탭으로 내리는 방법은 없다.  라고 고객에게 전달해도 됩니까 ?

@Meghana-MSFT Yes, I understand. Thank you for guiding me.

So, you can think of the image where the bot icon is exposed as a chat tab as incorrect as per https://learn.microsoft.com/ko-kr/microsoftteams/platform/bots/design/bots.
thank you for response

Here the image is correct https://learn.microsoft.com/en-us/microsoftteams/platform/bots/design/bots#mobile-10. Bot icon is in the same place as yours.

I understand. Thank you for explaining.
However, other images may be misleading.
thank you

Apologies for the delay in response, this is a by design behavior, we cannot fix chat as the first page in a mobile environment.
You can click on bot icon to go to the bot chat.

I am re-reading your response and writing a report.
I'm contacting you with a question about your response.
Is it fixed if it is not the first page?
After testing several times while changing the order of the chat tabs, the mobile chat tab was only exposed as a bot button icon at the top.
thank you

Yes, chat tab is exposed as a bot icon at the top.


0.0.179 not on PyPI

Not a big deal, but I though I'd warn you in case there's a broken workflow somewhere.

Very strange, thank you. For some reason the release creation didn't kick off the GitHub Action?

Let me see if it resolves itself with v0.0.180.

Not sure what happened, maybe a GitHub error, but v0.0.180 is now up (which contains just one bug fix on top of v0.0.179).


Remove /runes/balances API endpoint

This endpoint returns every output containing any kind of a Rune. That doesn't seem very useful, and it's potentially a DDoS vector.

I'm fine with removing it, it's kind of a nutty endpoint. If someone complains that it's gone, we can always add it back.


Update TEMPLATES.md to add a template

Update templates to include a mongodb-service-template

Thanks for your contribution @bdbmammoth :+1:


[Feature Request] Enable changing tenant after client construction

Acquiring tokens as a multi-tenant application is painful because tenants are baked into clients at construction. It's therefore necessary to create a new client instance for each tenant. Please provide an API for overriding the tenant specified at construction during a single token request or enable changing it after construction. MSAL.NET has implemented the former and is evidently moving to the latter:  https://github.com/AzureAD/microsoft-authentication-library-for-python/issues/368#issuecomment-945631545.

@bgavrilMS @siddhijain @rayluo : can you pls. help with the per request design?

In pseudo-code, the logic in MSAL.NET is something like:

var confidentialClientApp = // create app with authority set to login.microsoft.com/common

var authResult = confidentialClientApp.AcquireTokenByMethod.WithTenantId(tenantId).Execute();

The simplified algorithm for choosing the authority on which to perform auth, given an application authority and a request tenantID is:

if config authority is not set, use app authority
if request.tenantId is configured and app.Authority is not AAD, throw an exception (only AAD supports tenants)
if request.tenantId is "common" or "organizations", throw an exception (the API is for forcing an actual tenantid)

The more complex case exists for AcquireTokenSilent, where we can also need to think about Account.HomeTenantId. I am not 100% sure if MSAL Go's AcquireTokenSilent(account) uses account.HomeTenantId, but if it does then if all 3 options are specified, the same as above apply, and prefer to use request.tenantId and not account.homeTenant.Id
Acceptance tests

app.Authority
request.TenantId
Account.HomeTenantid
Expected Authority

lmo/common
GUID

lmo/GUID

lmo/organizations
GUID

lmo/GUID

lmo/consumers
GUID

lmo/GUID

lmo/GUID1
GUID2

lmo/GUID2

lmo/GUID
common or organizations
null or any
ERROR

lmo/GUID1
GUID2
GUID3
lmo/GUID2

lmo/common

GUID
lmo/GUID

app.Authority
request.TenantId
Account.HomeTenantid
Expected Authority

lmo/common
GUID

lmo/GUID

lmo/organizations
GUID

lmo/GUID

lmo/consumers
GUID

lmo/GUID

Hi @bgavrilMS , in the table above, row 3, if an app declared its authority as "lmo/consumers", wouldn't it mean the app does not want to allow AAD users to sign in? Do we still want to allow the guid adjustment in this scenario?

Now that you mention it, yes. I don't think MSAL.NET does any better :(

MSAL for Go will have a few rules for dynamic tenant IDs as described in this issue (implemented here) but otherwise no opinion on their validity. So, we'll take any string and it's up to AAD whether it works. WithTenantID("contoso.onmicrosoft.com") will make the request URL https://authority/contoso.onmicrosoft.com/...

Well, in that case, it is really just a "WithTenant(tenant)" parameter, rather than "WithTenantId(tenantId)" which seemingly implies a GUID. Thanks for the clarification.

That's correct. I assume it's the same for the other MSALs which call the option WithTenantID. Is semantic accuracy more important than consistency with those MSALs?

I believe the consistency is more about Conceptual Consistency: if one thing can and should be done in one MSAL, other applicable MSALs would better also have it. But the exact naming always has some variance, due to language convention and casing reasons. In particular, already-shipped parameters do not need to be changed only for consistency, and newly-introduced parameter in an MSAL has an opportunity to "name it right", if desirable.
I'm leaving an approval to your implementation PR now.

Hello @rayluo, is there a plan to release a new package version with the WithTenantID support changes? Meanwhile if we want to acquire tokens for multiple tenants is the workaround to create client per tenant?

Yes, create a confidential client application for each tenant / authority you have.

Got it. Thank you for confirming. It would be ideal if we could avoid this with the new changes. When could we expect a new release version with this change?


Missing VueConstructor in TypeScript typings when creating plugins

Version
2.5.2
Reproduction link
https://jsfiddle.net/d3cfrtbn/4/
Steps to reproduce

Try to create a vue plugin using TypeScript in most expected way
Wonder how to make a workaround :)

What is expected?
You should be able to define a plugin in TS just as you would in plain JS: as a function, with a parameter to be a global Vue object, that is well typed.
What is actually happening?
I could not find any possible way to declare a type to the Vue parameter inside plugin, because the type of global Vue object (VueConstructor) is not exported. It is only visible as an exported Vue variable.

I guess one solution is to simply export VueConstructor as a type, that could be imported in these rare cases.

@ktsn Last I checked, typeof Vue by definition returns a string or is there some magic going on behind closed doors? And where would you use the typeof Vue in the provided repro?

@ktsn according to vue.d.ts, there is a const export Vue : VueConstructor.

came across this myself. Solved it by doing the following.
import { VueConstructor} from "vue";
const plugin= { options: (VueInstance: VueConstructor, options: any) ={ // })

I solved with
import VueConstructor from "vue";


Feature Idea: mark audio events by tapping a key while audio is playing

I think it would be useful to have an event creator that is created by tapping the space bar while playing the track. For example, in a complex song, I could push play and then tap the space bar to match the kick drum beat.

Hi! Thanks for the feature request. This is a good idea. The main challenge will be to implement it in a way that is sufficiently accurate.

That's a cool idea 👍🏼

This is in progress under https://github.com/rewbs/sd-parseq/compare/hotkeys?expand=1.

This is now live. Hit shift-a during playback to add a marker. Let me know whether it's sufficiently accurate.

Awesome! Thanks! I played with it tonight and it made the process a lot easier.
—Dan—

On Jul 26, 2023, at 11:33 PM, Robin Fernandes @.***> wrote:
This is now live. Hit shift-a during playback to add a marker. Let me know whether it's sufficiently accurate.
—
Reply to this email directly, view it on GitHub https://github.com/rewbs/sd-parseq/issues/120#issuecomment-1652859300, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABS5WMVSLPRPIODYFYZ5Y2LXSHOP5ANCNFSM6AAAAAAYZQVGAQ.
You are receiving this because you authored the thread.


python3 fixes

print as functions.
numpy logical arrays changed minus to tilda.
Changed != None to is Not.
xrange to range
Ran setup.py install
checked by running example.py from a different folder.

Thanks for making this as a pull request!
A couple of xrange remain in nonnegfac/matrix_utils.py and nonnegfac/nnls.py. Could you take care of that too?
A useful sequence for testing is
(within virtualenv)
python setup.py install
python example.py
cd nonnegfac
python nmf.py
python matrix_utils.py
python nnls.py
I acknowledge that I better make all of these testing as unit tests and run in CI tools...

Taken care of all xrange. Executed the mentioned tests above. Everything passed.

That worked. Thanks!


swayswap can't work

What version of Wallet are you using?
0.7.1
What is happening?

steps to reproduce
can't linked say error
How it should behave?
relsove it
What os are you seeing the problem on?
Windows Desktop
What browser?
Chrome
What is your browser version?
111.0.5563.111

@zhengkai88, thanks for the report. These errors in the captcha can be due to the browser or network. When it happens, you should retry it. We released a fix on swayswap a couple of days ago to refresh the captcha automatically without the need to refresh the page.
Please let me know if you still have issues with the faucet so we can re-open the issue and investigate more on it.


Symbols don't seem to have any sort of useful hashCode

Is this on purpose, or would you accept a PR to resolve this?
scala> Set(t"Long", t"Long")
res0: scala.collection.immutable.Set[meta.Type.Name] = Set(Long, Long)

scala> res0.contains(t"Long")
res1: Boolean = false

scala> t"Long".hashCode
res2: Int = 167054986

scala> t"Long".hashCode
res3: Int = 448322632

scala> q"Long".hashCode
res4: Int =<PHONE_NUMBER>

scala> q"Long".hashCode
res5: Int =<PHONE_NUMBER>

I'd like to be able to test membership of a set non-structurally. This breaks assumptions about literals being structurally representative in any way, as they can't be meaningfully compared either:
scala> q"Long" == q"Long"
res6: Boolean = false

I've seen this comment in contrib, but this seems more broadly applicable than just some extension methods.
Was this done on purpose? Are there instances where we absolutely want to prevent comparison to ensure we don't accidentally collapse trees?

Thanks for reporting! This is working as expected, trees have reference equality. See https://scalameta.org/docs/trees/guide.html#compare-trees-for-equality
It's not clear what other form of equality would be a better default. Even if you have two trees that share the same q"Long" structure they might have for example different positions.

Understood, thanks for clarifying @olafurpg!


Turn off vppagent telemetry plugin

Note: This is because of:
https://github.com/ligato/vpp-agent/issues/1477
(and the fact we don't use that plugin)

Description

Motivation and Context

How Has This Been Tested?

[ ] Covered by existing integration testing
[ ] Added integration testing to cover
[ ] Tested locally
[ ] Have not tested

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.

Merging, created issue #1666 for failed test.


entityCounts and Histogram Bug

In both of these functions we're counting the shortestkey of facet table. Instead we should count the number of rows in the Main Table, if there's a join the path.
Although this is only true in the current use case that we have in chaise for faceting. The number that we are showing as "number of occurrences" is incorrect and misleading. For that use case, we should change it the way that I described.
We might want to change the name of these functions, or specify what exactly these two functions are doing.

A fix for this has been merged with master.


Cleaning up text.

@jjaygbay1 - I have been doing a PR demo for VMware to show them how it works. Can you plz approve this PR?

@jjaygbay1

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team


[PUI] Registration

Adds registration (for built in auth, SSO will be part of #5753) via PUI.
Closes #6282

@SchrodingersGat ready for review; control of the login page behavirous (turn on/off certain features via settings) is in the pipeline for later today; that requires an API version bump so seperate PR

@matmair so I presume that in your later PR, this "registration" UI will be disabled be default, unless the "Enable Registration" server setting is enabled?


Unable to install unused-volumes plugin on mac OS

Tried installing on Apple mac OS platform it reports below error
Installing plugin: unused-volumes
W0509 12:27:52.985878    6678 install.go:164] failed to install plugin "unused-volumes": plugin "unused-volumes" does not offer installation for this platform
failed to install some plugins: [unused-volumes]: plugin "unused-volumes" does not offer installation for this platform
Darwin 00WKSMAC151146.local 21.2.0 Darwin Kernel Version 21.2.0: Sun Nov 28 20:28:41 PST 2021; root:xnu-8019.61.5~1/RELEASE_ARM64_T6000 arm64

Still not available for mac with m1 cpu


show error delete when delete more than one rows,

when I selected more than one rows then right click, click delete this row.
if I selected rows = total rows
e.g have 2 rows and I selected 2 rows right click delete row,
then will show error  as below
jquery.jexcel.js:2323 Uncaught TypeError: Cannot read property 'split' of undefined     at r.fn.init.updateSelection (jquery.jexcel.js:2323)     at r.fn.init.$.fn.jexcel (jquery.jexcel.js:5345)     at r.fn.init.deleteRow (jquery.jexcel.js:3534)     at r.fn.init.$.fn.jexcel (jquery.jexcel.js:5345)     at HTMLAnchorElement.onclick (a-custom-table-design:1)
I have saw code jquery.jexcel.js. On line  3500
// Can't remove the last row             if (options.data.length > 1) {
If my understanding is correct, this should be changed to
// Can't remove the last row             if (options.data.length > numOfRows) {

that has been fixed on the most recent versions.


createReducer Allows Extra Keys To Be Added To State Without Errors

Description
createReducer allows you to add extra items to an object than what's on the defined state. It properly type-checks keys defined in the state type for the reducer...it just allows extra keys (not the end of the world, unless someone makes a spelling mistake).
Previously reported in the v5 thread, but it's confirmed to also be an issue in v4
Steps to Reproduce
Add an any item to a reducer object that isn't defined on the reducer's state type. Notice how TypeScript does not indicate that this is an issue. It would be easy for someone to make a spelling mistake of a key and then have no type checking, resulting in bugs.
Example (the extra property has no typescript errors reported..doing anything invalid to the other two properties properly shows errors):
export type AppState = {
  previous: string | null;
  current: string;
};

export type AppStateReducerState = {
  appState: AppState;
};

export const defaultAppReducerState: AppStateReducerState = {
  appState: {
    previous: null,
    current: 'active',
  },
};

export const appStateReducer = {
  appState: createReducer(defaultAppReducerState.appState).handleAction(
    setAppState,
    (state, { payload }) => ({
      previous: state.current,
      current: payload,
      extra: 'why is this allowed?',
    }),
  ),
};

CodeSandbox to help you reproduce issue in isolation
https://codesandbox.io/embed/typesafe-actions-reference-project-7o6o1 (see src/store/example.ts)
Expected behavior
The extra key should not be allowed since it's not defined in the reducer's state type.
Suggested solution(s)
Show an error if any additional properties of state is provided.
Project Dependencies

Typesafe-Actions Version: 4.4.2 and also 5.0.0-3
TypeScript Version: 3.6.3
tsconfig.json: see codesandbox

Hey @jstheoriginal
You can add return type constraint on reducer handler to validate extra keys.
Like this:
export const appStateReducer = {
  appState: createReducer(defaultAppReducerState.appState).handleAction(
    setAppState,
    (state, { payload }): AppState => ({
      previous: state.current,
      current: payload,
      extra: 'why is this extra key allowed?',
    })
  ),
};


Fix annoying poetry run warning about non-installed script

Warning: 'csfy' is an entry point defined in pyproject.toml, but it's not installed as a script. You may get improper `sys.argv[0]`.

The support to run uninstalled scripts will be removed in a future release.

Run `poetry install` to resolve and get rid of this message.

Occurs on Windows + Ubuntu
probably something wrong in the pyproject.toml file ...


Improve logging

Ideally, every function should have a get_logging_params method which returns logging values. Couple of ways to do this:

Either return these values in a function call to the trainer which can then call the logger appropriately
Store these values inside the agent such that when get_logging_params is called, these values are returned.

1st option should be a better solution to this.

Does logging to csv work properly? My train.csv file is empty every time. Maybe take a look at this too.

Couple more issues:

Train.csv is always empty. The CSV Logger may not be working.
Logging doesn't seem to work on Colab.

I think you're checking the wrong file. Have you checked logs/train.csv?

I'm not getting a logs/train.csv. I'm getting a train.csv in the root folder and a logs/train.log

Are you specifying the log directory when you instantiate the trainer?
Its working for me, not sure why its not working for you

It's working now


Bug: Dom update problem when using fake timers

Subject of the issue
when I use fake timers, the dom won't update for async actions until I wait nextTick twice.
Steps to reproduce
<template>

    {{ data }}

</template>

// the test

import { mount } from '@vue/test-utils';
import { nextTick } from 'vue';
import FakeDemo from './fakeDemo.vue';

describe('fake', () => {
  test('timer problem', async () => {
    vi.useFakeTimers();
    const wrapper = mount(FakeDemo);
    console.log(wrapper.html());
    vi.advanceTimersByTime(10_000);
    console.log(wrapper.html());
    await nextTick();
    console.log(wrapper.html());
  });
});

the output

rerender
changed text

before update
updated

Expected behaviour
I expected to see

rerender
changed text
before update
updated

world

Actual behaviour
only if I await for nextTick one more time in sequence, I can get the dom update.
like
await nextTick();
await nextTick();

Notice that before calling the first nextTick, I already had a rerender scheduled, so I thought it woud require just one tick to update the dom.
Is that intended behaviour?

Hi @GDX64
I think this is normal behavior. You can probably avoid the multiple nextTick with flushPromises. In your example I don't think you really rely on fake timers, so you can probably rewrite it like this:
const wrapper = mount(FakeDemo);
await flushPromises();
expect(wrapper.html()).toContain('world');

@cexbrayat, in fact, if I wait for the flushPromises instead of the two ticks, it works even with the fake timers. Thank you for your help.


iAd data is now sent on installs as well as opens & crash bug.

iAd data is now sent on installs as well as opens.
Fixed iOS 8 crash bug when 'requestAttributionDetailsWithBlock:' is not present.

My bad - I forgot that install split this out differently! 👍


pull request for e2e test at 12/23/2016 06:26:14

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


slot-scope doesn't accept all valid expressions

Version
dev branch
Reproduction link
https://codesandbox.io/s/mow3jyo89j?module=%2Ftest%2Funit%2Fspecs%2FScoped-broken.spec.js&view=preview
Steps to reproduce
Access a scope with a JS expression like "{ item }" instead of "item"
What is expected?
Using "{ item }" to identify a scope should allow for accessing that variable directly instead of having to use something.item
What is actually happening?
item is not defined

ReferenceError: item is not defined
    at Object.eval (eval at createFunction (https://mow3jyo89j.codesandbox.io/node_modules/vue-template-compiler/browser.js), :3:39)
    at Proxy.vm._renderProxy._t (https://mow3jyo89j.codesandbox.io/node_modules/@millergeek/test-utils/dist/vue-test-utils.js:1931:31)
    at eval (https://mow3jyo89j.codesandbox.io/src/components/Scoped.vue?f8cd7dd6:1:334)
    at Proxy.renderList (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:3707:16)
    at Proxy.render (https://mow3jyo89j.codesandbox.io/src/components/Scoped.vue?f8cd7dd6:1:273)
    at VueComponent.Vue._render (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:4546:22)
    at VueComponent.updateComponent (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:2790:21)
    at Watcher.get (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:3144:25)
    at new Watcher (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:3133:12)
    at mountComponent (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:2797:3)
    at VueComponent.Vue.$mount (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:8542:10)
    at VueComponent.Vue.$mount (https://mow3jyo89j.codesandbox.io/node_modules/vue/dist/vue.common.js:10941:16)
    at mount (https://mow3jyo89j.codesandbox.io/node_modules/@millergeek/test-utils/dist/vue-test-utils.js:4744:8)
    at shallow (https://mow3jyo89j.codesandbox.io/node_modules/@millergeek/test-utils/dist/vue-test-utils.js:4781:10)
    at eval (https://mow3jyo89j.codesandbox.io/test/unit/specs/Scoped-broken.spec.js:14:36)
    at s (https://codesandbox.io/static/js/sandbox.153e4095.js:2529:310)
    at o (https://codesandbox.io/static/js/sandbox.153e4095.js:2529:124)
    at evaluate (https://mow3jyo89j.codesandbox.io/test/unit/specs/Scoped-broken.spec.js:13:1)
    at r.a (https://codesandbox.io/static/js/sandbox.153e4095.js:5354:971)
    at e.value (https://codesandbox.io/static/js/sandbox.153e4095.js:5413:270)
    at e.value (https://codesandbox.io/static/js/sandbox.153e4095.js:5386:23195)
    at e.value (https://codesandbox.io/static/js/sandbox.153e4095.js:5386:22974)
    at e. (https://codesandbox.io/static/js/sandbox.153e4095.js:5386:18687)
    at n (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:2847:811)
    at Generator._invoke (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:2847:599)
    at Generator.e.(anonymous function) [as next] (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:2847:990)
    at o (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:3049:316)
    at https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:3049:464
    at new Promise ()
    at new t (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:678:776)
    at https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:3049:258
    at https://codesandbox.io/static/js/sandbox.153e4095.js:5386:18996
    at Array.map ()
    at e. (https://codesandbox.io/static/js/sandbox.153e4095.js:5386:18550)
    at n (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:2847:811)
    at Generator._invoke (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:2847:599)
    at Generator.e.(anonymous function) [as next] (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:2847:990)
    at o (https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:3049:316)
    at https://codesandbox.io/static/js/common-sandbox.d83f0a59.js:3049:412
Console
6
Problems
4

I had to fork and build vue-test-utils myself to find this bug on the dev branch. Am happy to update with the official beta15 on Monday.

I will resolve this issue.

I will send a pull request to resolve this issue within a day.


Fix align

@Karl-Bridge-Microsoft  : The PR passed the acceptance checklist. Please evaluate further and approve/complete the PR if appropriate. Thanks!


Use local @Identifier annotation

The old dependency on smallrye-common-annotation looks awkward in Polaris since it does not actually use any of the smallrye core features.
This change switches from the Smallrye @Identifier annotation to a local annotation serving the same purpose.

But do we want to use smallrye qualifier annotations directly?

But do we want to use smallrye qualifier annotations directly?

Yes, that's the approach taken in #469.


[BUGS-6657] Handle explicit WP_ALLOW_MULTISITE false correctly

Sites with define('WP_ALLOW_MULTISITE', false); are erroneously getting prompted to fix their upstream, as we we only check WP_ALLOW_MULTISITE was set, not its value.
Further consolidated the logic given we were checking both WP_ALLOW_MULTISITE and MULTISITE back-to-back

Pushed patch to a test site with define('WP_ALLOW_MULTISITE', false); and asserted the banner disappears.
Before

After


Update api-implementation.md

Before clicking the "Create pull request" button:
Enter a meaningful title. We suggest using the keywords "New" or "Update" indicating the nature of changes.
Current subtitle implies that batching is limited only to POST, PUT, and DELETE operations. Later on, in the second paragraph, it contradicts the subtitle by explaining that batching can be done in GET request, but then it hints that batching is limited only to ASP.NET Web API 2.
Obviously, batching can be applied in broader contexts. I've edited it a bit to reflect this. Also, I've explained benefits of batching.
Reactive Manifesto is the source of my claim.
Links to any related work item(s) or supporting detail

[DELETE-OR-REPLACE-THIS-TEXT]
[DELETE-OR-REPLACE-THIS-TEXT]

AFTER YOUR PR HAS BEEN CREATED, expand this section for tips and additional instructions.
These are common guidelines for contributions across the repos managed by the Azure patterns & practices (PnP) content team. Some repositories may have additional specific requirements that are not listed here.
Guidance for all contributors

Topic
Guidance

Draft PR
If your PR will be a work-in-progress for more than a day or two, select the Convert to draft link in the upper right of the page (under Reviewers) to change it to a draft. For future reference, you can also do this using the Create pull request button drop-down during PR creation.

ms.date metadata
Don't update an article's "ms.date" metadata property unless you've done a full freshness review of the content. A full freshness review includes changes required to correct or improve the full technical accuracy of the article.Don't update "ms.date" if you're doing targeted changes to improve non-technical aspects of the article, such as editorial quality, art improvements, article template alignment, etc.If you've changed any "ms.date" properties for work that wasn't part of full review for freshness, please reset them to their previous value.

Placement and linking
If you're creating a new article or articles, include updates to the related TOC.yml file to propose where the article(s) should be placed. Also consider other places within the document set where it would be beneficial to cross-reference and link to your new article(s).

PR build
After you open your PR, and for each successive commit that you push to your branch, the publishing platform will run validation on the files in your pull request. A summary of the build results for each file will be inserted inline into your pull request, which includes any build suggestions/warnings/errors. PRs cannot be merged until all build errors and most warnings are resolved.

Publishing
Following a successful merge, most repos publish to the live site about once per (business) day.

Additional resources
learn.microsoft.com contributor guide

Additional guidance for private repos and internal contributors

Topic
Guidance

PR size
If your PR is more than ~5 lines of changes, or you'd like for the changes to go through editorial or larger review, open a contribution request at https://aka.ms/contribution and include a link to the PR in response #8. Once it's processed, you'll be notified of the next steps.

PR title prefix
Select the Edit button to the right of the PR title if you need to revise it. The following prefixes are reserved for specific contribution types:[Quality Check] - maintenance work related to content quality (edit passes, art improvements, template alignment)[LinkFix] - recurring/adhoc PRs to correct link URLs[Pipeline] - new/updated contributor success pipeline content[WIP] - a work-in-progress draft requiring several days/weeks

PR preview
Following successful build of your PR, publishable files will also include Preview URL links to staged previews of your new/updated articles. Be sure to review these for verification of your intended contributions, or to send to other internal contributors for review.

PR sign-off (public repo)
If an article you own is updated in a public repo PR, you are responsible for sign-off. You will be automatically notified via email. The PR will not be merged until you've had a chance to review and sign-off.

PR sign-off (private repo)
After you've completed your proposed changes, addressed build warnings, and completed all review work, you can begin the sign-off process for review and merge:If your PR is in draft mode, remove "[WIP]" from the title and select Ready for review button at the bottom of the PR.Enter "#sign-off" in a new comment. This comment indicates that you're confident the work meets or exceeds Microsoft's standards for publication, and will trigger the review process.Your PR may be selected for initial review by the PnP content team. Following PnP review, you may receive questions or requests for additional changes. You should have initial feedback from PnP review within a few business days. If you have an urgent request or need to contact the team, please mention @MicrosoftDocs/patterns-and-practices-team-pr-reviewers in your PR and someone will get back to you. After the Azure patterns & practices content review is complete, a PnP #sign-off will be added.Final review/merge is done by the PR review team. The PR team may also respond with feedback, categorized as "Blocking" (requires action from you), or "Non-blocking" (to be addressed in a future PR).

Additional resources
learn.microsoft.com internal contributor guideAuthoring templates: architecture-center-pr, well-architected-prTo contact the Azure patterns & practices team use e-mail, or @mention our GitHub team in your PR comments using: @MicrosoftDocs/patterns-and-practices-team-pr-reviewers

Thank you. Hope the rewrite works for you.

Thanks. Approved them all.

PnP #sign-off
#remove-label:"do-not-merge"
#label:"ready-to-merge"


Node ID out of range when the tsid.node is larger than 255

Beacsuse of these guys:
public static final Factory INSTANCE_256 = newInstance256();

public static final Factory INSTANCE_1024 = newInstance1024();

public static final Factory INSTANCE_4096 = newInstance4096();

Whenever the Factory is instantiated, these factories are instantiated and when it pulls the tsid.node number from the system property, it fails with "Node ID out of range"
Here's a test that causes it to happen:
@Test
public void testWithNodeBitsSetFromProperty() {
	final int randomBits = 22;
	// test all allowed values of node bits
	for (int i = 20; i >= 0; i--) {
		final int nodeBits = i;
		final int counterBits = randomBits - nodeBits;
		final int node = (1 << nodeBits) - 1; // max: 2^nodeBits - 1
		System.setProperty(NODE, String.valueOf(node));
		System.setProperty(NODE_COUNT, String.valueOf(1 << nodeBits));
		TSID tsid = TSID.Factory.builder().withNodeBits(nodeBits).withNode(node).build().generate();
		int actual = (int) tsid.getRandom() >>> counterBits;
		assertEquals(node, actual);
	}
}

The Node ID takes from 0 to 20 bits, so if you provide a larger than 1048576, it will fail.

@vladmihalcea  - my test is running from 0 to 20 node bits and it fails without my PR change.  It is not providing a value larger than 1048576.  Am I missing something?  Thank you!

@postalservice14 Yes, you're right about that.

Fixed.

I arrived here late.
But if you are still open to suggestions:
https://gist.github.com/fabiolimace/a6110a1490b93e99accd0cfc4a004e6a
The Proxy class works as a lazy loading technique.
The immediate downside is that you need to remove the final keyword from Factory.


CIAB: fix race issue where server not avail when server assignment done

What does this PR do?
on fresh cdn-in-a-box,  default dataset assigns the deliveryservice to the single edge server.  That server is not registered with traffic_ops at the time the assignment is done.
This is a stopgap measure until we improve synchronization between containers.
Which TC components are affected by this PR?

[ ] Documentation
[ ] Grove
[ ] Traffic Analytics
[ ] Traffic Monitor
[ ] Traffic Ops
[ ] Traffic Ops ORT
[ ] Traffic Portal
[ ] Traffic Router
[ ] Traffic Stats
[ ] Traffic Vault
[x] Other cdn-in-a-box

What is the best way to verify this PR?
Build cdn-in-a-box from scratch:
cd infrastructure/cdn-in-a-box
docker-compose build
docker-compose up -d

set up access to traffic_ops:

. traffic_ops/to-access.sh
export TO_URL=https://localhost:6443 TO_USER=... TO_PASSWORD=...
to-get api/1.4/deliveryservices/1/servers | jq -S .response[].hostName

The hostName printed here should be "edge"..

#### Check all that apply

- [ ] This PR includes tests
- [ ] This PR includes documentation updates
- [ ] This PR includes an update to CHANGELOG.md
- [ ] This PR includes all required license headers
- [ ] This PR includes a database migration (ensure that migration sequence is correct)
- [ ] This PR fixes a serious security flaw. Read more: [www.apache.org/security](http://www.apache.org/security/)

<!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at

      http://www.apache.org/licenses/LICENSE-2.0

    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
-->

Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/trafficcontrol-PR/2875/
Test PASSed.


User-reported unhelpful error message

Program: https://code.world/#PFeio6RaEWz1FcXZqh4G7tw
Message:
program.hs:2:52: error:
    parse error (possibly incorrect indentation or mismatched brackets)

The error is mismatched brackets.  The error message says that it's possibly mismatched brackets.  Hard to see how it could be more clear.


[SPARK-18026][SQL] should not always lowercase partition columns of partition spec in parser

What changes were proposed in this pull request?
Currently we always lowercase the partition columns of partition spec in parser, with the assumption that table partition columns are always lowercased.
However, this is not true for data source tables, which are case preserving. It's safe for now because data source tables don't store partition spec in metastore and don't support ADD PARTITION, DROP PARTITION, RENAME PARTITION, but we should make our code future-proof.
This PR makes partition spec case preserving at parser, and improve the PreprocessTableInsertion analyzer rule to normalize the partition columns in partition spec, w.r.t. the table partition columns.
How was this patch tested?
existing tests.

cc @yhuai @ericl

Test build #67254 has started for PR 15566 at commit 82c9f86.

Test build #67254 has finished for PR 15566 at commit 82c9f86.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67254/
Test PASSed.

cc @mallman

I went through the script I wrote for https://issues.apache.org/jira/browse/SPARK-17990. At the point where I ran
(0 to 9).foreach { p => sql(s"alter table mixed_case_partitioning add partition(partCol=$p)") }

I got an exception:
org.apache.spark.sql.AnalysisException: Partition spec is invalid. The spec (partCol) must match the partition spec (partcol) defined in table '`default`.`mixed_case_partitioning`';
  at org.apache.spark.sql.catalyst.catalog.SessionCatalog$$anonfun$requireExactMatchedPartitionSpec$1.apply(SessionCatalog.scala:768)
  at org.apache.spark.sql.catalyst.catalog.SessionCatalog$$anonfun$requireExactMatchedPartitionSpec$1.apply(SessionCatalog.scala:766)
  at scala.collection.mutable.ResizableArray$class.foreach(ResizableArray.scala:59)
  at scala.collection.mutable.ArrayBuffer.foreach(ArrayBuffer.scala:48)
  at org.apache.spark.sql.catalyst.catalog.SessionCatalog.requireExactMatchedPartitionSpec(SessionCatalog.scala:766)
  at org.apache.spark.sql.catalyst.catalog.SessionCatalog.createPartitions(SessionCatalog.scala:669)
  at org.apache.spark.sql.execution.command.AlterTableAddPartitionCommand.run(ddl.scala:357)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult$lzycompute(commands.scala:58)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.sideEffectResult(commands.scala:56)
  at org.apache.spark.sql.execution.command.ExecutedCommandExec.doExecute(commands.scala:72)
  at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:114)
  at org.apache.spark.sql.execution.SparkPlan$$anonfun$execute$1.apply(SparkPlan.scala:114)
  at org.apache.spark.sql.execution.SparkPlan$$anonfun$executeQuery$1.apply(SparkPlan.scala:135)
  at org.apache.spark.rdd.RDDOperationScope$.withScope(RDDOperationScope.scala:151)
  at org.apache.spark.sql.execution.SparkPlan.executeQuery(SparkPlan.scala:132)
  at org.apache.spark.sql.execution.SparkPlan.execute(SparkPlan.scala:113)
  at org.apache.spark.sql.execution.QueryExecution.toRdd$lzycompute(QueryExecution.scala:87)
  at org.apache.spark.sql.execution.QueryExecution.toRdd(QueryExecution.scala:87)
  at org.apache.spark.sql.Dataset.<init>(Dataset.scala:183)
  at org.apache.spark.sql.Dataset$.ofRows(Dataset.scala:62)
  at org.apache.spark.sql.SparkSession.sql(SparkSession.scala:590)
  at $anonfun$1.apply(<console>:24)
  at $anonfun$1.apply(<console>:24)
  at scala.collection.immutable.Range.foreach(Range.scala:160)
  ... 48 elided

While this PR is not a fix, I'd call this an improvement on the previous behavior which would silently do the wrong thing.

Actually SPARK-17990 can be fixed in this PR with a little more work. Let me do it now.

Sorry I was wrong. The root cause of SPARK-17990 is that, when we write data for a hive table, we ignore the truth that hive table is not case-preserving, and create the partition directory with the case-preserving partition columns.
I think it's not related to this PR and we should fix it with a new PR.

Test build #67340 has started for PR 15566 at commit 3d6f418.

This PR makes partition spec case preserving

Sorry if there has already been a discussion on this. Why would any user want this ? Its great that the engine can preserve cases but its just calling for user confusion if there columns like "user" and "User" in the same table. One can say that its a user's issue and they should not create columns with same name but different case. But there might be different set of people in different timezones working on the same table.

I have changed it to This PR makes partition spec case preserving at parser, sorry for the confusion.
Previously we were lazy and alway lower case the column names in partition spec. In other partition related operations, we search partition columns by == directly, without considering case sensitivity. It's fine as we only support partition related operations for hive tables and hive tables are not case-preserving. However, if we are going to support partition operations for data source tables, we can't assume the partition columns are always lower cased in metastore and lower case the partition spec at parser.

retest this please

Test build #67389 has started for PR 15566 at commit 3d6f418.

Test build #67389 has finished for PR 15566 at commit 3d6f418.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67389/
Test FAILed.

Test build #67439 has started for PR 15566 at commit d4fbeb2.

Test build #67439 has finished for PR 15566 at commit d4fbeb2.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67439/
Test PASSed.

Test build #67485 has started for PR 15566 at commit 71ded51.

Test build #67485 has finished for PR 15566 at commit 71ded51.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/67485/
Test PASSed.

thanks for the review, merging to master!

Cool, I'll rebase https://github.com/apache/spark/pull/15515 and see if we can completely fix mixed case datasource tables.


Some questions about the plugin

I'm trying to use this plugin with a multi-project java project

Is Gradle's Variant aware build the same as the variant used for android builds?
1a. If so, is there a plan to make the jvm analyzer to use variants optionally instead of source sets?
Does this plugin work with user defined configurations?
Does this plugin work with test configurations? ->(I have multiple testCompile configurations which should be testImplementation)
3a. I see abiAnalysisMain task run but I cannot figure out how to get abiAnalysisTest task to trigger. Does it exist?
I've added unused compileOnly configurations -> is the plugin supposed to report these?

As far as I've seen, this plugin works great for the api, compile, and implementation configurations. Unfortunately, I'm having difficulty with the others.

I have no plans right now to expand the JVM analysis beyond looking at the main source set. This isn't out of the question, but I'd have to see a use-case.

Does this plugin work with user defined configurations?

Can you elaborate?

Does this plugin work with test configurations?

There is support for testImplementation only at this point. If you want to see this expanded, please open a feature request.

abiAnalysisTest

No, that task does not exist. The test-analysis this plugin currently has is rather limited, and the test code is analyzed in the same pass as the main source set code. This could be improved, and feature requests are welcome.

I've added unused compileOnly configurations -> is the plugin supposed to report these?

The plugin explicitly will not suggest removing a compileOnly dependency. This was a conservative decision made to avoid some false positives regarding dependencies that seemed unused but were still needed at compile-time. The plugin makes every effort to err on the side of safety -- applying the advice shouldn't break your project, even if there might be some unused dependencies left behind.


Are unrecognized options supported?

Are unrecognized options supported?
The README implies that they are:
https://github.com/jarro2783/cxxopts#unrecognised-arguments
But then later on implies otherwise:
https://github.com/jarro2783/cxxopts#todo-list

They are supported. I think that to do item is out of date.


pipenv shell command outputs: Could not execute because the specified command or file was not found

Hi all,
Just upgraded to PowerShell 7.0.0-preview. After the update, when running pipenv shell, I get the following response back:
Launching subshell in virtual environment…
Could not execute because the specified command or file was not found.
Possible reasons for this include:
  * You misspelled a built-in dotnet command.
  * You intended to execute a .NET Core program, but dotnet-C:\Users\Bill does not exist.
  * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.

I ran this command 10 minutes before, in the previous preview, and it worked just fine.
I've ran pipenv check and am getting a proper response. I've also checked this in regular PowerShell and the command runs just fine.

Thanks,
Bill

Please add $PSVersionTable and repo steps.

$PSVersionTable:
Name                           Value
----                           -----
PSVersion                      7.0.0-preview.6
PSEdition                      Core
GitCommitId                    7.0.0-preview.6
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

To repro,
→ C:\git› mkdir ps7ReproTest

    Directory: C:\git

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
d----          11/26/2019 10:43 AM                ps7ReproTest

→ C:\git› cd .\ps7ReproTest\
→ C:\git\ps7ReproTest› pipenv --python 3.7
Creating a virtualenv for this project…
Pipfile: C:\git\Pipfile
Using C:/Users/Bill LaLonde/AppData/Local/Programs/Python/Python37/python.exe (3.7.5) to create virtualenv…
[=   ] Creating virtual environment...Already using interpreter C:\Users\Bill LaLonde\AppData\Local\Programs\Python\Python37\python.exe
Using base prefix 'C:\\Users\\Bill LaLonde\\AppData\\Local\\Programs\\Python\\Python37'
New python executable in C:\Users\Bill LaLonde\.virtualenvs\git-cJou6T9E\Scripts\python.exe
Installing setuptools, pip, wheel...
done.
Running virtualenv with interpreter C:/Users/Bill LaLonde/AppData/Local/Programs/Python/Python37/python.exe

Successfully created virtual environment!
Virtualenv location: C:\Users\Bill LaLonde\.virtualenvs\git-cJou6T9E
→ C:\git\ps7ReproTest› pipenv shell
Launching subshell in virtual environment…
Could not execute because the specified command or file was not found.
Possible reasons for this include:
  * You misspelled a built-in dotnet command.
  * You intended to execute a .NET Core program, but dotnet-C:\Users\Bill does not exist.
  * You intended to run a global tool, but a dotnet-prefixed executable with this name could not be found on the PATH.
→ C:\git\ps7ReproTest›

Running through the same steps in $PSVersionTable
Name                           Value
----                           -----
PSVersion                      5.1.18362.145
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.18362.145
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

the command works fine, as shown below:
PS C:\git> mkdir ps7repro

    Directory: C:\git

Mode                LastWriteTime         Length Name
----                -------------         ------ ----
d-----       11/26/2019  10:35 AM                ps7repro

PS C:\git> cd .\ps7repro\                                                                                PS C:\git\ps7repro> pipenv --python 3.7                                                                                Creating a virtualenv for this project…
Pipfile: C:\git\ps7repro\Pipfile
Using C:/Users/Bill LaLonde/AppData/Local/Programs/Python/Python37/python.exe (3.7.5) to create virtualenv…
[    ] Creating virtual environment...Already using interpreter C:\Users\Bill LaLonde\AppData\Local\Programs\Python\Python37\python.exe
Using base prefix 'C:\\Users\\Bill LaLonde\\AppData\\Local\\Programs\\Python\\Python37'
New python executable in C:\Users\Bill LaLonde\.virtualenvs\ps7repro-ZK4BJ3Xh\Scripts\python.exe
Installing setuptools, pip, wheel...
done.
Running virtualenv with interpreter C:/Users/Bill LaLonde/AppData/Local/Programs/Python/Python37/python.exe

Successfully created virtual environment!
Virtualenv location: C:\Users\Bill LaLonde\.virtualenvs\ps7repro-ZK4BJ3Xh
Creating a Pipfile for this project…
PS C:\git\ps7repro> pipenv shell
Launching subshell in virtual environment…
Windows PowerShell
Copyright (C) Microsoft Corporation. All rights reserved.

Try the new cross-platform PowerShell https://aka.ms/pscore6

PS C:\git\ps7repro> exit()

@BillzGitHub Thanks! Please clarify what is initial shell (cmd.exe, pwsh)?

I may be interpreting this wrong but I believe your asking for the initial shell I was running, before the upgrade, when this worked.
That was PowerShell Preview as well though I'm not certain if it was v7.0.0-preview.5 OR v7.0.0-preview.4

Sorry, I ask about  C:\git› mkdir ps7ReproTest - is it run in cmd.exe?

Oh, that was run in pwsh

@BillzGitHub Thanks! Please put all in the issue description (repo steps and $PSVersionTable). It will help readers to understand the issue.
I don't know how pipenv works but I guess PowerShell is sensitive to env variables and this could be cause the issue.

Hi iSazonov,
I believe I've already added all of the information you requested above. The only possible piece left would be to explain what Pipenv is and how it functions. So here goes, (from https://github.com/pypa/pipenv)
Pipenv is a tool that aims to bring the best of all packaging worlds (bundler, composer, npm, cargo, yarn, etc.) to the Python world. Windows is a first-class citizen, in our world.

It automatically creates and manages a virtualenv for your projects, as well as adds/removes packages from your Pipfile as you install/uninstall packages. It also generates the ever-important Pipfile.lock, which is used to produce deterministic builds.

This is a particular important tool for times when you are building or managing applications that use varying versions of packages to run. For example lets say you have an app that runs Python 2.7 and NumPy 1.3. Now lets assume you also manage an app that uses Python 3.7 and Pandas 0.25 and NumPy 1.7
Without virtual environments you would need to install all of these to your local machine. With pipenv you can specify what requirements are need for a specific application and they are only contained within that environment.
Let me know if there is additional information I can provide.
Thanks,
Bill

@BillzGitHub Thanks! I suggest you to download latest daily preview build and re-check.
Also I'd compare PSModulePath env variable before and after Pipenv start, and with previous pwsh version.


:seedling: bump x/net to v0.14.0

This is to close potential vulnerability:
https://osv.dev/vulnerability/GO-2023-1988

/test-ubuntu-e2e-integration-release-1-4

/approve


Not collecting data

Hi Stephan, thanks for the integration. I have an older Trannergy inverter (serial starts with 61xxx), which supports the SolarMan app. I added IP and serial, unfortunately it is not collecting any data. I was wondering, where do I find version 4/5 of the communication protocol? Thanks!

Same question from me, @StephanJoubert. Trannergy inverters also use solarman. Can you pass a hint on what to use to connect to te inverter to collect the right addresses/values for a definition file?


Why is the runtime not using the holographic remoting extensions？

Wish to use the following extensions:
“XR_MSFT_holographic_remoting”
“XR_MSFT_holographic_remoting_frame_mirroring”
“XR_MSFT_holographic_remoting_speech”

Hi, you can find instructions on Microsoft Remoting for HoloLens 2 here: https://learn.microsoft.com/en-us/windows/mixed-reality/develop/native/holographic-remoting-create-remote-openxr
Remoting isn't part of the OpenXR for WMR runtime, instead it is its own OpenXR runtime, that implements the extensions you listed. The page above explains how to obtain that runtime and how to activate and use the extensions.


feat: Create Collections of Document Files

Is your feature request related to a problem? Please describe.
I would like the ability to select multiple documents without having to select each file individually.
Describe the solution you'd like
I would like a feature that allows for the documents to be grouped by user defined collections.
For example, I have the following folders, Personal, Work, Taxes, News, Journals.  Each of those folders has numerous pdf files, but I don't want to have to select them individual or worse mix topics accidentally.
Describe alternatives you've considered
Add database and UI features to group document files by a named category.  Then allow the user to select a file or collection from the chat box to query against.
Additional context
Great work on this project!

For this a citation feature (Like in AnythingLLM) would be helpful as you are looking for collections of docs.
You could show the name of the doc and the chunks of text received from the chromadb after sending your question in the ui as a citation.

You can now tag documents to create document collections, let me know if you encounter any issues!

@tjbck This looks great, thank you for doing all the backend to support this feature!
Testing chat with the documents: individual, tagged, and all documents, appear to work as intended!  This is great!
Question:
Asking for clarification about the UI.  I am adding tags to a document, but the new tag now appears above all the documents.  It kind of looks confusing.
Not sure if I missed something on the UI.

For testing I did the following:  #gov for Declaration, #research for attention paper #programming for sveltetxt
Is it possible the tags are not filtering when querying from the backend to the frontend?

@davidamacey Good catch! #646 fixes it!

@tjbck Thanks for your hard work and quick responses!
I hope you do not think I am nit-picking.  I am here to assist where I can.  Hopefully I can support with a PR or a feature when you need an extra dev.

No worries, appreciate the feedback!

Please add feature to add EXISTING document folders from disk (no upload!)

Hey there,
i am trying to create a collection called 'Data-Center' and want to make 2 documents part of this collection. However the issue i am facing is that whenever i try to give the same tag to multiple documents, it gives me an error. Details below:-
Here i upload the first document and give it the tag 'Data Center' and then save it.

The UI overrides the given tag and saves it with name of the file, instead of the give tag name (ie, Data-Center)
I then upload another document and it does the exact same thing.

Afterwards, when i try to edit both files and rename the tag to 'Data-Center' it allows me to do so for the first file, as shown below:

However, when i try to edit the other document and give it the same tag (ie, Data-Center), it give me the following error:

Now this error is preventing me from creating a collection.
Help is requested please.

The above issue was resolved by updating to the latest version of open webui.


Update requirements.txt with tgcrypto

TgCrypto is a high-performance, easy-to-install cryptography library specifically written in C for Pyrogram as a Python extension. It is a replacement for a slower Python-only alternative and implements the cryptographic algorithms Telegram requires, namely: AES-256-IGE, AES-256-CTR and AES-256-CBC.
Pyrogram will automatically make use of TgCrypto when detected, all you need to do is to install it.
https://docs.pyrogram.org/topics/speedups

It didnt mention that in the source and I didnt have any promps or issues installing it 🤷♂

Instal clean os on virtual machine and try.

I somehow didn't notice you among the people who help everyday to solve the same problems for unknowing people time after time.

pypi says the only requirements are Python 3.7+
https://pypi.org/project/TgCrypto/

If you have visual studio installed on your computer and you installed the C++ development package, the build tool was installed with it. Or you installed it earlier for the same tgcrypto to use in other bots.

This package is optional and not required. Additionally, it requires MVC++. We cannot assist users with errors related to MVC++ or ask them to install it, so it remains optional. You can install it if you like, but we will not force anyone to do so.

I somehow didn't notice you among the people who help everyday to solve the same problems for unknowing people time after time.

I dont really know what you are trying to say lol

I dont really know what you are trying to say lol

I want to say that your proposed change, if adopted, would cause multiple problems for users, but I haven't seen you among the Telegram chat users who help people solve trivial problems on a daily basis.

you're just, like, oh, I'm doing great, why is the author so stupid and didn't add this himself, let me help him.

Well you and the author missed such simple things as using .bat instead of
.cmd so you never know xD
On Thu, 3 Oct 2024, 12:29 Fy0urM, @.***> wrote:

you're just, like, oh, I'm doing great, why is the author so stupid and
didn't add this himself, let me help him.
—
Reply to this email directly, view it on GitHub
https://github.com/masterking32/MasterCryptoFarmBot/pull/35#issuecomment-2391184761,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHJHWL6BLT5ZNLESSSOOS2TZZUTAXAVCNFSM6AAAAABPJRNE42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJRGE4DINZWGE
.
You are receiving this because you authored the thread.Message ID:
@.***>

Well you and the author missed such simple things as using .bat instead of .cmd so you never know xD
…
 — Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHJHWL6BLT5ZNLESSSOOS2TZZUTAXAVCNFSM6AAAAABPJRNE42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJRGE4DINZWGE . You are receiving this because you authored the thread.Message ID: @.>

Man, stop nagging so much. We have our reasons for not merging some PRs or suggestions. Please stop arguing with others. If you continue, I'll block you, and you'll lose access to my repositories.

Man (@tboy1337), stop nagging so much. We have our reasons for not merging some PRs or suggestions. Please stop arguing with others. If you continue, I'll block you, and you'll lose access to my repositories.

@masterking32 I’m not trying to cause issues for anyone I’m literally trying to improve the bot to make you more money, all I’m trying to do is help but if I’m attacked for making a PR I’m not just going to ignore it.  I may not have much coding experience but I have years of experience in running businesses of various types and also years of experience using various bots and all I’m trying to do is help...

f I’m attacked for making a PR

I wasn't trying to attack you, I gave you a factual answer and suggested you research my answer yourself. but you referred to pypi saying I'm doing fine, it doesn't say anything about it.

f I’m attacked for making a PR

I wasn't trying to attack you, I gave you a factual answer and suggested you research my answer yourself. but you referred to pypi saying I'm doing fine, it doesn't say anything about it.

Well no there was no mention of any requirements anywhere I looked so I said that, I wasn’t disputing what you were saying.

UK = United Kingdom

UK = United Kingdom (Соединенное Королевство)
i.e Great Britain (Великобритания)

i'm not from there)

but we have

oops, sorry, you have it in uk, I missed it)


Existing project code

Add previous project files for code review.

STATUS: Changes Required ♻
Hi @imranhossainemi , 👋
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
To Highlight 🥇

Has a proper Pull Request. ✔
Good use of Github flow ✔

Changes Required

Kindly please set up your linter environment properly as it is part of the project requirement. Currently, I noticed your stylelint is not passing at the moment. Kindly use the linters find in HTML and CSS only and make sure all the tests passed i.e marked checked with green or blue color. follow this [link] (https://github.com/microverseinc/linters-config/tree/master/html-css)  to set up linters properly. 👍 👍
I am seeing that you are not using semantic html format for your html code. Like <article> <footer> <header> <main> <nav> <section> parts in code. You can learn about those more in this following link ( https://www.w3schools.com/html/html5_semantic_elements.asp ). 👍

Optional suggestions

It will better use CSS grid base design like flexbox , grid for better flexibility in designing webpage

Cheers and Happy coding!👏👏👏
Feel free to leave any questions if something is not 100% clear.
Please, remember to tag me on( @imranhossainemi ) in your question so I can receive the notification.


Maybe switch from talon to using claw

I learned in https://github.com/mailgun/talon/issues/130#issuecomment-324375195 that there's a fork of talon, called claw, that has the non-ML features of Talon like extracting quotations:
https://github.com/tictail/claw
@umairwaheed can you look into whether we can easily switch to their latest release?  This would let us get rid of one of our repos we're installing from a GitHub fork.

Yeah. @zulipbot claim.

@timabbott, it seems that Claw is not Python3 compatible.

It turns out that one of the dependencies of Claw/Talon called Flanker is also not Python3 compatible. https://github.com/mailgun/flanker/issues/97

Closing as this doesn’t seem to be a viable option.


Improve menu on multi-chain homepage

Decred homepage menu:

Comitted:
https://github.com/chaineco/blockcare/commit/4b14ad81d9870b094a86f932997dc43410bacfc5


FrameBuffer and Texture resource

Your code for creating a FrameBuffer checks the width and height of a resource input and asserts if it's not the same as the width and height of the output attachment (assuming there is one).
I am a little confused as to how that is supposed to work with a use case of having a shadowmap in the first renderpass which outputs an attachment (the shadowmap) which is then used as a Texture input for the color pass (for sampling in the shader)?
Assuming a 2048x2048 shadowmap, the dimensions won't match the output of the swapchain in the color pass, and will throw an assert error.
You only ignore the input dimensions if the type is Buffer or External, so even if the shadowmap input is set to Type Reference, you'd still have the same assert error.
Any clarification here would be appreciated (and maybe a little more details on Texture vs. Reference resource Type).
Note, this is regarding Chapter 4, Framegraph implementation.

I admit this code could be simpler. What we are doing in the create_framebuffer call is looking at the outputs of a render pass and make sure all the outputs have the same dimensions. I am not sure why we have this assumption, but I am guessing it made things easier in other parts of the code. And usually that's what you have for a gbuffer pass.
If we then have one or more texture inputs, we also want to make sure they match the size of the framebuffer. Again, this is probably not strictly necessary and as you mention would create problems with inputs that don't match the output resolution. As for the outputs, we were probably trying to simplify the code and make sure that for a full screen pass, input and output dimensions are the same.
Which is probably why we introduced a reference type. In these cases we manually set a resource as input and we want the graph to keep this resource alive for this pass, otherwise it could be reused for another pass. Not the cleanest of designs, but it's what we landed on at the time.

You only ignore the input dimensions if the type is Buffer or External, so even if the shadowmap input is set to Type Reference, you'd still have the same assert error.

We do check for Buffer and Reference types, not External :) https://github.com/PacktPublishing/Mastering-Graphics-Programming-with-Vulkan/blob/main/source/chapter4/graphics/frame_graph.cpp#L228
So your shadowmap example might work. It could be the code diverged from the book though and it's something we fixed after writing the chapter. If that's the case, apologies for the confusion.

@theWatchmen
Appreciate your response!
To clarify, with the shadowmapping example, would you typically set the input resource type as Reference or Texture?
Based on the book, I would assume the type should be texture, as reference types are used to pass dependencies from input to output without creating a new resource.
We would want to have a barrier between the previous (shadowmap) renderpass and dependent colorpass, so am assuming Texture input type would make the most sense?

For a shadowmap you would use the Texture type, assuming the size of the shadowmap texture is the same as the output size of the pass it's used in. Otherwise you could still have it as an output from the shadowmap pass, but then use a Reference type in the pass that consumes it to make sure the resource is kept alive for that pass. I can't remember if you would need to manually add a texture transition in this case.

Thanks for the info. I have found a workable solution.


add github-action in order to improve coding style

I think you are Hiep right :D
Thank you very much for this first contribution. It will help the coding quality.