Modernize GH Actions

Update versions of various actions (removes warnings/errors due to deprecated/unsupported versions)
Update/remove arguments to some actions, where new versions require it
Update gcc, g++ versions under ubuntu-20.04

The test action runs much farther now, which is nice to see; but the build step still fails with some references to gcc-6 and g++-6, even though I’ve eliminated those from all .yml files. So I’m not quite sure where that comes … unless it is in the precompiled Build folder that it’s downloading in the first step? 🤔
On a separate note: I notice that test.yml is currently set to run on: [push, pull_request]; which means it runs twice when I push a new commit to an open PR, which is wasteful. I’d therefore suggest changing it to only run on PRs?

The test action runs much farther now, which is nice to see; but the build step still fails with some references to gcc-6 and g++-6, even though I’ve eliminated those from all .yml files. So I’m not quite sure where that comes … unless it is in the precompiled Build folder that it’s downloading in the first step? 🤔
On a separate note: I notice that test.yml is currently set to run on: [push, pull_request]; which means it runs twice when I push a new commit to an open PR, which is wasteful. I’d therefore suggest changing it to only run on PRs?

Thank you Jost, these are great updates.
I agree that, as you mention, the references to older gcc versions would come from the prebuild folders downloaded. The solution would be to make these for the right versions. So, one in macOS, one in Ubuntu and one in Windows. These prebuild folders would be generated once we confirm the build instructions. So that's on my plate at the moment.
I'll accept the merge and we can pause till I provide the build folders. A question, we would need an intel mac and an arm mac prebuild folder, in case we manage arm, right?

I'll accept the merge and we can pause till I provide the build folders. A question, we would need an intel mac and an arm mac prebuild folder, in case we manage arm, right?

Not necessarily. In principle, Qt versions that support ARM Macs also support cross builds or universal binaries; but how well that works in practice remains to be seen after we’ve upgraded Qt to a more recent version.


refactor parser_txt

What problem does this PR solve?
simplified code
Type of change

[ ] Bug Fix (non-breaking change which fixes an issue)
[ ] New Feature (non-breaking change which adds functionality)
[ ] Documentation Update
[x] Refactoring
[ ] Performance Improvement
[ ] Other (please describe):

Thanks!
Misunderstood and unnecessary.


Improve test cases for query expression other than happy path

Duplicate of https://github.com/ballerina-platform/ballerina-lang/issues/25036 ...


Typo in Docs

Such a minor thing but I was reading the docs and saw:
fill_field(element, input)
Sets a field’s value. The difference with input_info_field is that, the field is cleared before entering the new value
input_into_field(element, input)
Enters value into field

The first one refers to input_info_field which is meant to say input_into_field
Obviously this isn't a huge issue but just making note of it :)

Hello @antmg83. Thank you for reporting this. That is certainly important. Would you like to send a pull request? I'll merge it right away.

Seems like this is already fixed in master.


[23.11] curl: apply 8.5.0 security fixes

https://curl.se/docs/CVE-2023-46218.html
https://curl.se/docs/CVE-2023-46219.html
Fixes: CVE-2023-46218, CVE-2023-46219
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Built passthru.tests (apart from haskell-curl, too big) on macos 12 x86_64.
Suggest using CVE numbers in filenames.

The idea was that whoever touches the patches can git am the series in the correct order. But yeah, mixed feelings about the idea.

Problem is it doesn't give any automated tool/scanner a chance to pick up that this package has been patched for that CVE.

How about this?

Perfect.

Applied to staging-next-23.11 as 14e563bcb33f0cd48990695ec9d18b30165c77ed

Assuming I can close this then


[Retail App] Price filter radio button doesn't reset while switching pages

Summary
Once the selection has been made, the price filter radio button does not reset while switching to a different page. For example, if a user selects the filter as £0 - £19.99 in the Women's page, after switching to the Men's page, the price filter radio button shows the same selection, but the search results displayed show the default results.
Steps To Reproduce

Visit https://pwa-kit.mobify-storefront.com/en-GB
Click Women's category page
Change the price filter to £0 - £19.99
Switch to Men's category page

Expected result
The price filter radio button should clear after the page is switched
Actual result
The price filter radio button uses the previous page value
System Information (as applicable)
Browser: Chrome
Node version: 14
pwa-kit version: 1.2.0
Desktop OS: MacOS
Mobile Device Info: iPhone 12
Additional information
https://user-images.githubusercontent.com/83722798/143508942-82979643-4968-4f38-9cb3-d14e6a3c38c0.mp4

Thank you for submitting this issue. We have reviewed the issue, but based on the severity of the issue described, do not have plans to fix this issue at this time. Please comment on the issue if you’d like to propose increasing the priority level.

The issue is fixed in v2.7.1


job_start: Bug or need for clarification: how to start a job with a blank in its arguments

According to :h job_start "Arguments in double quotes can contain white space.". The docs don't tell how exactly arguments in double quotes are passed to the comnand.
Example:
R --slave --no-readline --silent --no-save -e "print(1 + 2)"prints 3 when run from the bash command line.
The following code:
function! Callback(ch, msg) abort "{{{3
    echom string(a:msg)
endf
let cmd = 'R --slave -e "print(1 + 2)"'
let job = job_start(cmd, {'in_mode': 'nl', 'out_mode': 'nl', 'callback': function('Callback')})
let ch = job_getchannel(job)
sleep 500ms

prints "print(1 + 2)" though, i.e. the argument gets escaped in a way that makes R think it's a string.
Either vim handles the argument wrongly or the docs need some clarification on how to pass an argument with whitespace to a command that is run as a job.

Tom Link wrote:

According to :h job_start "Arguments in double quotes can contain
white space.". The docs don't tell how exactly arguments in double
quotes are passed to the comnand.
Example:
R --slave --no-readline --silent --no-save -e "print(1 + 2)"prints 3 when run from the bash command line.
The following code:
function! Callback(ch, msg) abort "{{{3
    echom string(a:msg)
endf
let cmd = 'R --slave -e "print(1 + 2)"'
let job = job_start(cmd, {'in_mode': 'nl', 'out_mode': 'nl', 'callback': function('Callback')})
let ch = job_getchannel(job)
sleep 500ms

prints "print(1 + 2)" though, i.e. the argument gets escaped in a way that makes R think it's a string.
Either vim handles the argument wrongly or the docs need some clarification on how to pass an argument with whitespace to a command that is run as a job.

What system is this on?  For Unix it's recommended to use a list instead
of a string.
--
From "know your smileys":
:-&	Eating spaghetti
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

What system is this on? For Unix it's recommended to use a list instead
of a string.

This is on ubuntu 16.04.
Ok, using let cmd = ['R', '--slave', '-e', 'print(1 + 2)'] actually
works. If I understand you right, it won't work on windows though? So,
for windows, I'd have to join the list and wrap an argument containing
special characters in quotes?
Anyway, I now pass the expression as input to the inferior process,
which works on linux & windows.
Thanks for your reply.

Tom Link wrote:

What system is this on? For Unix it's recommended to use a list instead
of a string.

This is on ubuntu 16.04.
Ok, using let cmd = ['R', '--slave', '-e', 'print(1 + 2)'] actually
works. If I understand you right, it won't work on windows though? So,
for windows, I'd have to join the list and wrap an argument containing
special characters in quotes?
Anyway, I now pass the expression as input to the inferior process,
which works on linux & windows.

The problem is that Unix and MS-Windows have very different ways of
starting an executable.  Libraries hide that a bit, but when it comes to
escaping special characters it often fails.  Also because on Windows the
backslash is a path separator.
Using the list is probably the best, then Vim can try hard to do proper
escaping.  But how an executable unescapes is not always the same...
Anyway, I think we should use the list on Unix as the reference, and try
to make that also work on MS-Windows.
--
The primary purpose of the DATA statement is to give names to constants;
instead of referring to pi as 3.141592653589793 at every appearance, the
variable PI can be given that value with a DATA statement and used instead
of the longer form of the constant.  This also simplifies modifying the
program, should the value of pi change.
-- FORTRAN manual for Xerox Computers
/// Bram Moolenaar --<EMAIL_ADDRESS>-- http://www.Moolenaar.net   \
///        sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\\  an exciting new programming language -- http://www.Zimbu.org        ///
\\            help me help AIDS victims -- http://ICCF-Holland.org    ///

use this with a string form
let args = ['/bin/bash', '-c', cmd]

I don't know whether it was already documented at the time the issue was created, but now the help recommends to use a list on Unix, and a string on Windows:

{command} can be a String.  This works best on MS-Windows.  On
Unix it is split up in white-separated parts to be passed to
execvp().  Arguments in double quotes can contain white space.

{command} can be a List, where the first item is the executable
and further items are the arguments.  All items are converted
to String.  This works best on Unix.

https://github.com/vim/vim/blob/38a3bfa9a2931729a5e0c28dc087f745b68988ef/runtime/doc/channel.txt#L906-L912

closing then.


Neutral label

Hi, I wonder how to deal with the training data with neutral label.

Sorry but I was busy in the past few days.
As per the paper, this project only focuses on those expressive faces, following general settings of other related SOTA works.
For neutral face images, they are only leveraged to build pseudo masks in the data preprocess phase. That is, neutral faces are not directly used in training / testing.
Hope it help.


Fix API docs publishing

Preflight Checklist

[x] I have read the contribution documentation for this project.
[x] I agree to follow the code of conduct that this project follows, as appropriate.
[x] I have searched the issue tracker for a bug that matches the one I want to file, without success.

Issue Details
When we moved from Travis CI/AppVeyor to GitHub Actions, we lost the ability to publish API docs to Vercel (FKA Now), as the API token was in Travis CI only.
Expected Behavior
API docs are published to Vercel (FKA Now) every time a commit to master happens.
Actual Behavior
Publishing API docs is commented out of the GitHub Actions CI config.

I noticed that there's a CNAME option in the GitHub repo settings, so maybe we can use GitHub Pages for this now?


common js compliant lib

I was wondering if it would be possible to make a common js compliant jsrender.js file (something that doesn't use window.views or whatnot outside of the main method).
I have a small wrapper I wrote around jsrender for nodejs:
https://github.com/shtylman/node-jsrender
and it would make bringing in jsrender code changes much easier :)
(If you accept patches for this I would be happy to provide one).

Along the same line, it would be nice if JsRender exposed itself as an AMD module so asynchronous loaders like RequireJS and curl.js can use it. jQuery now registers itself as an AMD module as of version 1.7.

I may not look more closely at AMD until JsViews and JsRender both get to Beta.

Any new developments on this?

JsRender is now fully AMD and commonJs compliant - as is JsViews.
JsRender is available as a Node module. See https://www.npmjs.com/package/jsrender and https://github.com/BorisMoore/jsrender-node-starter


Raku™ -> Raku®

Raku is a registered trade mark of The Perl and Raku Foundation.
Can we please update all the documentation pages to use the correct symbol? ®
It's sufficient to just use the ® symbol prominently once on the page - rather than repeating it multiple times.
Please also remove ™ throughout the documentation.

@nige123 - where do you see the text "registered trade mark" in the docs? or ™?
I suspect your issue isn't with the docs in this repository

I see it on this page:
https://docs.raku.org
The problem is with the use of ™ - it needs to be ® instead - and only really used once per page.
Sorry if this is the wrong repo for the bug report.

To address this, it'll be a PR to raku/doc-website, but this is fine, no worries.
FYI, this was setup this way specifically with guidance from @codesections as part of discussions with legal representation while he was working with the Raku Foundation.
"Raku™" is not used in any of the content itself, so it would just be in the website generation, like the title page, menus, footer, etc. (so on that home page, it's there twice).
I do see the camelia logo has a "tm" (but not a ™), which I don't think was part of that previous conversation.
Would love to get feedback from someone in RSC or directly from the foundation on this.

Given that formal registrations of trademarks are country-specific, is it normal or appropriate to specify somewhere in which countries this applies to? Unless there are treaties recognizing registered trademarks between countries, the R would apply in some places and fall back to TM in others.  Of course informally we want to make ourselves look as good as possible and unqualified R is better than unqualified TM for sure.

I previously helped The Perl Foundation to register the Raku trademark. So I'm not sure why @codesections would have suggested using :tm: instead of :registered:. It's better to err on the side of using the :registered: than not - as this puts people on notice that TPRF has IP rights in this name (e.g., in USA, UK, EU and Japan).

It's been a while since I've been at this party, so things can certainly have changed in the past 10 years, but according to the online website Camelia is copyright and trade marked by Larry Wall.  So I'd suggest any mark registration for Camelia might need to coordinate with Larry.
If there's been changes in this area and the website notes on Camelia are out of date, then feel free to ignore this comment.
Pm

To avoid any misunderstanding here:

please s/ :tm: / :registered: /g in relation to Raku
please keep :tm: as it relates to Camelia (this signifies its use a common-law trade mark)


[Question] Using puppeteer-extra plugins

Would love to use the adblocker plugin for my current project, and the stealth plugin for my next one.
I tried making a few adjustments to PuppeteerStream.ts:
import { LaunchOptions, Browser, Page, BrowserOptions, ChromeArgOptions } from "puppeteer";
import puppeteer from 'puppeteer-extra'
import Adblocker from 'puppeteer-extra-plugin-adblocker'

puppeteer.use(AdblockerPlugin()) // Added before the browser is initialized on line 69.

The result is an indefinitely loading blank tab – any ideas on how I could get it to work?

How do you start the puppeteer browser? Can you show your launch code

I'm just running the file.js example as is – no changes made there

Any progress on this? I love the extension but need to be able to use it with puppeteer-extra too.

#48

Have a look at the example file.


[WIP] Tree reductions for dask.array

This enables support for tree reductions, which should improve efficiency of using dask.array across multiple processes/machines, or when arrays are composed of a large number of chunks.
The idea is to set a maximum number of chunks to be gathered and combined (either overall, or by axis) when performing reductions - breaking the reduce step of map-reduce into a tree of smaller reductions.
At an api level, reductions expose a max_leaves kwarg, which defaults to the current behavior. It accepts either a dict of {axis: max_chunks}, or an integer, which is used to compute max_chunks for each dimension such that the total number of chunks gathered in each reduction is approximately max_leaves. For example, axis=0, max_leaves=16 -> max_leaves={0: 16}, axis=(0, 1), max_leaves=16 -> max_leaves={0: 4, 1: 4}.
Example:
import dask.array as da
import numpy as np

x = np.arange(1, 122).reshape((11, 11)).astype('f4')
a = da.from_array(x, chunks=(4, 4))
o = a.sum(axis=0, max_leaves=4)

What would normally be a single step reduction has been broken into a tree of depth 2.
Todo:

[x] Add support for moment (and thus std, var, etc...)
[ ] Add support for arg* reductions
[x] More tests

Does using a tree merge cause performance degradation for the single node case? If not, we might want to default to that behavior.

For a wide enough tree, no. It actually might improve performance, as the aggregate step can be done in parallel (probably negligible though). Trick is determining what is a sane default number.

These produce different results
In [11]: x.sum(max_leaves=4).visualize('dask.pdf')

In [12]: x.sum(max_leaves={0: 4}).visualize('dask.pdf')

I wouldn't expect much degredation in non-pathological cases.  The worst thing we're doing is adding O(log_k n) more tasks.
Suggest renaming max_leaves.  I think that your intent of the name was something akin to max_children.  There might even be a slicker name than that.  I'm trying to think of a term like breadth that might be the converse of a depth of a tree.  Perhaps "branching factor", if it wasn't so verbose.

Any thoughts on how hard the combine function for moments will be?

I haven't worked through the gritty details, but at first glance this looks pretty cool to me.

These produce different results

What is the shape of x in that case? If it's not 1d, then I'd expect them too. I definitely need to clean up input verification though, as it occurs to me that I never verify that sorted(axis) == sorted(max_leaves). Need max block combination sizes for all reduction axis.

What is the shape of x in that case? If it's not 1d, then I'd expect them to. I definitely need to clean up input verification though, as it occurs to me that I never verify that sorted(axis) == sorted(max_leaves). Need max block combination sizes for all reduction axis.

x = da.arange(1000, chunks=100)

There is some input validation missing.  This is also the motivation behind the "we should test the branching factor explicitly somewhere" comment

I cleaned up the tests, and fixed the bug you pointed out above. Could always test more, but I think the coverage here is pretty good.

Any thoughts on how hard the combine function for moments will be?

It's proving harder than I would like - my tired brain isn't up for mathing it out right now :/.   I wouldn't mind using it to redo recent array experiments.

Doesn't support arg_*, var, std, or moment, and could use some more tests. I'm mostly out this week, so I doubt this will be fixed until next week. Should be good to go for redoing the array experiments though, if you don't mind working off non-merged stuff.

I'm not sure if these should have the same name or not.
In [1]: import dask.array as da

In [2]: x = da.random.random((100, 100), chunks=(10, 10))

In [3]: x.mean(axis=0).name
Out[3]: 'reduce-460ea5b3313d36450410978acc2ace95'

In [4]: x.mean(axis=0, max_leaves=6).name
Out[4]: 'reduce-460ea5b3313d36450410978acc2ace95'

Using this branch I've found a speedup from 30s to 5s when doing a reduction of 2GB across a small network of 3 machines.  This is only when the reduction required data sharing and was only because we happened to have scattered the data in a way that aligns with this (both defaults cause nice behavior.)  There was no speedup or slowdown when the reduction didn't require significant data transfer, though that case was fast anyway (1-2s).

Reasons to keep the keys the same:

They're mathematically the same result, just computed in different ways

Reasons to keep the keys separate and include max_leaves in tokenize:

The graphs are quite different, and so assumptions made about same keys having the same dependencies are incorrect.

I made them have the same keys so that it would play well with caching. I could revert this, but it seemed like the correct behavior in my mind. Where do we make assumptions that identical key names have the same dependencies?

Within the distributed scheduler.
Or, more generally, within any scheduler that supports graph updates.

Ah, that makes sense. I don't have strong opinions on this, happy to go either way.

My life will be easier if we include the branching factor within tokenize.  It also follows the "when in doubt, disambiguate keys" principle.

I'm still in favor of changing the name away from max_leaves.  To me a leaf is strictly at the bottom of a tree.  This is a restriction both on leaves and on interior nodes.

Better name suggestion? Some ideas:

max_children
max_branches
branches
branch_factor
bfactor

I like max_children and branch_factor

cc @shoyer, who tends to have a critical eye for APIs

While you're thinking about that, the default behavior still needs to be determined.

I'm in favor of max_leaves=8 until we find a counter-example

That seems small to me, but who knows. This will need more use to figure out best behavior.

What are your thoughts on what it should be?
Also, we might want to make this a global managed by set_options.  I can imagine that most users won't want to manage it on every reduction call.

Not sure. I just want to avoid a deep tree composed of small chunks. If chunks are 10 MB, 8 chunks are tiny in memory. 64? 128? I don't really have a good handle on this yet. And yeah, it should be available in set_options.

OK, lets say chunks are 10MB and we have 1TB of data.  That's 100,000 chunks.
If we're doing a reduction then the result of the first reduction for each chunk is likely to be smaller, something between 1kB and 1MB.  We'll do something like a ceil(log_8(100000)) = 6 deep reduction and have the following number of tasks
>>> sum(100000 / 8**i for i in range(6))
114285.2783203125

If we switch this to 64 then we have
In [6]: sum(100000 / 64**i for i in range(3))
Out[6]:<PHONE_NUMBER>625

Which does have significantly fewer extraneous tasks (it might make sense to weigh just communication bearing tasks, and not the original 100,000.)
This changes a bit if we consider nd-reductions, and which point our branching factor expands considerably.
My experience here has been with image stacks where we end up doing our first stage reduction along a fairly shallow axis, e.g.
>>> x.shape
(small, big, big)
>>> x.reduction(axis=0)

And our data ends up being spread by core.  It ends up being quite convenient to avoid communication on the second round of reductions.  I could also manage this by arranging data differently on the cluster however.

64 would probably kill my small laptop on the weather data example.
720 lat * 1440 lon * 8 byte dtype * 64 blocks * 4 cores == 2GB

I would prefer not to need to pass through arguments to control the branching factor explicitly in reduction calls like .mean(). These sort of backend specific optimizations make it harder to write generic code. I haven't thought about this carefully enough yet to have specific suggestions on default behavior, though. Perhaps we could make some heuristic choices based on the operations and how the data is chunked?

Heuristics sound like they would be valuable.  I think that we'll be better able to do this after some use.  I could just @jcrist 's help on some other things so I'm still behind a default that is just-a-number for now.
What are your thoughts on the kwarg names above?

I think max_children is better than branch_factor, which is more vague. It still feels more evocative for the particular implementation (using trees) rather than the concept (splitting the reduction into sub-problems).
More options:
split_threshold
max_chunks
max_splits
reduce_limit
subproblem_size
max_subproblems
I think split_threshold is my favorite.

This could use another review. I changed the keyword to split_threshold, added it to set_options, and defaulted at 32. Tests were improved, and all reductions are now supported.

This looks great to me.

+1

I expect this to need some use before we can determine a good default behavior/smart heuristic. I'm going to experiment with the ocean dataset to see how different configurations fair. If others have some workflows they could try this on, it would be much appreciated.

I was playing with this with distributed with @stefanv .  Some issues came up

The split_threshold kwarg wasn't immediately clear to him (perhaps he can chime in here on his thoughts
We ran into an issue about reductions on flexible types while computing a mean.  This might be a distributed or a dask.array issue.  Some play testing is in order.  Flexible type issues arise when you try to call a typical reduction on an array of struct dtype.

There are no docs for this yet, so any suggestions on how to make this more intuitive to use would be much appreciated.

We ran into an issue about reductions on flexible types while computing a mean.

I assume you weren't trying to compute a reduction on a struct array (which doesn't work even in numpy), but instead a bug somewhere in dask/distributed that resulted in the reduction being computed on a struct array? If you remember what computation caused it, it would be nice to be able to reproduce.

The reason split_threshold did not immediately make sense to me is because it contains these two concepts I needed to think about: split and threshold.  And threshold is slightly confusing because it could imply "split after this condition" or "split until this condition", with potentially different meanings ("split after n chunks" or "split until you have n chunks").
So, while I don't propose this name, something like split_every_n_chunks would read very straightforwardly.  Maybe there's a shorter version of that, like chunks_per_split, split_every, group_chunks, etc.

I like Stefan's names!
On Thu, Dec 3, 2015 at 7:51 PM, Stefan van der Walt
<EMAIL_ADDRESS>wrote:

The reason split_threshold did not immediately make sense to me is because it contains these two concepts I needed to think about: split and threshold.  And threshold is slightly confusing because it could imply "split after this condition" or "split until this condition", with potentially different meanings ("split after n chunks" or "split until you have n chunks").
So, while I don't propose this name, something like split_every_n_chunks would read very straightforwardly.  Maybe there's a shorter version of that, like chunks_per_split, split_every, group_chunks, etc.
Reply to this email directly or view it on GitHub:
https://github.com/blaze/dask/pull/839#issuecomment-161866720

Sorry, this somehow slipped through. Of the new names, I like split_every the best, when used in a function call (i.e. a.mean(axis=1, split_every=32)). As a global/context config though with set_options, I like split_ever_n_chunks the best, as it's more descriptive. Unsure what's best here. Either way, a better name would be nice.

I'd prefer using the same name in both places if possible.
On Fri, Dec 11, 2015 at 3:01 PM, Jim Crist<EMAIL_ADDRESS>wrote:

Sorry, this somehow slipped through. Of the new names, I like split_every
the best, when used in a function call (i.e. a.mean(axis=1,
split_every=32)). As a global/context config though with set_options, I
like split_ever_n_chunks the best, as it's more descriptive. Unsure
what's best here. Either way, a better name would be nice.
—
Reply to this email directly or view it on GitHub
https://github.com/blaze/dask/pull/839#issuecomment-164072350.

Yeah, I wasn't suggesting different names in different spots. Perhaps just go with the more verbose one, as it will probably be set contextually/globally?

I'd prefer split_every over split_every_n_chunks

I think split_every is probably verbose enough. I suspect it would usually
be poor practice to set this globally, given that it depends on the
particular reduction being performed.
On Fri, Dec 11, 2015 at 3:12 PM, Matthew Rocklin<EMAIL_ADDRESS>wrote:

I'd prefer split_every over split_every_n_chunks
—
Reply to this email directly or view it on GitHub
https://github.com/blaze/dask/pull/839#issuecomment-164073999.

Done. See #876.


Remove unwanted icon override

Fixes #23512
Icons were being overridden by inverse icon on focus - removed custom CSS.

@cheenamalhotra Did you check the other light color themes (specifically the ADS light theme)? Those have a darker highlight color so let's make sure it still looks good there

Oh! I didn't catch other darker highlights.. let me rethink a better way to solve this..

We might want to just remove the themes that don't look good for now (the new ones that were added with the latest merge at least) until we can have time to go through and thoroughly test them. Unfortunately the way we do icons (static SVGs) is different from how VS Code does theirs (custom font file) so choosing the correct color will be difficult.

We can fix it with the new Azure icons planned for server tree (similar as Azure tree).. I guess now is the time to do it soon 👀

Closing this for now - will address with new icons instead.


⚠ ClamAV has degraded performance

In fd05a1a, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 59 ms

Resolved: ClamAV performance has improved in 989cdd5.


Recognize \r\n line breaks.

Leaving a trailing \r (on systems where that happens) makes it unable to find the folder.
An alternate solution would be to do StringTools.trim() for each line.

Good catch!

I didn't so much catch this one as it caught me. I just wanted to compile on Windows...


PSM-64(part1): Move validation of KSQL module type to common

The goal is to let KsqlModuleType to evolve without impacting phone-home server. Phone-home server currently validates KSQL beacon pings using KsqlModuleType.values(). We want to remove some fields from KsqlModuleType, but let the server accept pings from previous and current versions.
This PR adds MetricsValidation. isValidKsqlModuleType() method to be used by the server to validate KSQL pings.

We haven't seen any DOS attacks on the server. We just know that it's easy to cause OOM with sending many distinct deployment types and CP versions. Limiting distinct values may have more side effects of not accepting valid pings. This particular change (plus we will need one more to move ksql ping avro message to this repo) will remove KSQL dependency from phone-home server. Both KSQL and phone-home has support-metrics-common dependency, which is better than what we have now.


pipx upgrade exit codes should follow convention and indicate failure

Describe the bug
Running pipx upgrade <package> returns "0" on a noop and "1" on success.
This means you can't determine if the command was successful or not. For example, if the shared venv was corrupted (a common occurrence when installing python with brew on mac), or any number of other reasons.
How to reproduce
Run pipx upgrade for an installed package with an old version.
Expected behavior
pipx upgrade <package> should return 0 on success, and 1 on failure.
A pattern that I've seen elsewhere is to provide a CLI flag for more granular exit codes. For example, terraform has a flag -detailed-exitcode which when set will return 0 on success (0 is always success), 1 on generic error, 2 on success but with non-empty diff. E.g. https://www.terraform.io/docs/commands/plan.html#detailed-exitcode. At least this way, you can differentiate success modes from failure modes. If you're writing an automation script and you're "okay" with return code "2", you can capture it and allow the script to succeed.
Since this would be a breaking change, perhaps an extra CLI flag which changes the return code behaviour?

Yes that is bizarre.  At the very least upgrade should return 0 on success.  This must have just been a goof in the code (I can see in the code very clearly where this exit code is set.)

Some notes to the pipx maintainers.

We need to add tests that actually upgrade a package, right now we only test upgrade on a package that is already fully upgraded
upgrade_all() currently does not return any value (even though main.py expects a return value!)  This needs to be fixed.

Ah I see what the idea was in the code:  upgrade-all() is counting how many packages were successfully upgraded, and is summing the return values (0 for no-upgrade, 1 for upgrade successful) from upgrade().
Unfortunately the same return value from upgrade() is also being used as the pipx exit code.  Thus the problem.


[ID] remove task template to sync with EN

This PR address issue in #26955
/cc @kubernetes/sig-docs-id-reviews

But we need to create another task or PR for this:

adding content/en/docs/contribute/style/write-new-topic.md
modifying content/en/docs/setup/_index.md

But we need to create another task or PR for this:

adding content/en/docs/contribute/style/write-new-topic.md
modifying content/en/docs/setup/_index.md

For additional tasks like this do we want it to be part of M6 or the next milestone? I think the chance to forgot these tasks are quite high if we left them here 🤔

/lgtm


why not change ctrl+g to goto line

Minimize the use of the mouse as much as possible :)

Maybe a plugin that allows changing keyboard shortcuts would be better?


 I accidentally had a pinned dev version of vim-mode. :unamused:
Sorry for the noise!


AZ-219 Replaced statefull force push check when pull requests are merged

This PR replaces a stateful force push check when pull requests are merged with a stateless version bump check when a new commit is pushed to any PR with the target branch as main.
The motivation of this change is to remove the solution with git push --force, and yet still have most of its features:

developer synchronization: with git push --force it is for CI to decide to bump the last version on main to the next one, so developers do not need to track if the version on main changed meanwhile sb merged other PR. With the proposed solution we don't have this particular gain, however, it should be rare people won't figure out the version changed meanwhile,
automatic solution prevented people from forgetting to update the version - this still holds, you can't merge PR which has source code changes without version bumped in it,
commit atomicity, ie we want ideally to have the version bumped in the same commit as the change due to the current way of publishing AlephBFT to crates.io - this still holds,
additional gain to remove git push --force is we can enable main as protected branch in GitHub, and that prevents git push --force from outside as well as forces PR to be raised with given a configurable minimal amount of approvers (this works on our other aleph-node repo).

Once this PR is merged, the other one https://github.com/Cardinal-Cryptography/AlephBFT/pull/165 would be declined (thanks for that work which influenced this PR).
Testing done:

.github/workflows/check-version-bumped.yml was tested on the fork, see  https://github.com/Marcin-Radecki/AlephBFT/pull/3 and history of commits on that PR
.github/workflows/push-foundation-repo.yml change was not tested due to its nature,
.github/workflows/push-foundation-repo.ymlwas partially tested, with modified version (https://github.com/Marcin-Radecki/AlephBFT/commit/ff9475b31332ac0e026056f26d3083fb971c7ccc, https://github.com/Marcin-Radecki/AlephBFT/commit/13a890dfd4a8a3f4c8a34674280f47b47c056c33): on PR merged https://github.com/Marcin-Radecki/AlephBFT/pull/4 this action was run https://github.com/Marcin-Radecki/AlephBFT/runs/4787358743?check_suite_focus=true

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

If PR changes only GitHub workflows, so in particular it does not change any files in src/ folder, then this check would be skipped. We don't bump versions automatically now, it is for a developer to do it (or not in given circumstances, as per above). Agree workflow would be run anyway, but it's rather cheap ('just' git clone and simple O(1) checks? And I assume workflows are run in parallel, so the CI workflow is longer anyway, as clippy takes more time than introduced version check workflow.

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

If PR changes only GitHub workflows, so in particular it does not change any files in src/ folder, then this check would be skipped. We don't bump versions automatically now, it is for a developer to do it (or not in given circumstances, as per above). Agree workflow would be run anyway, but it's rather cheap ('just' git clone and simple O(1) checks? And I assume workflows are run in parallel, so the CI workflow is longer anyway, as clippy takes more time than introduced version check workflow.

ok, but why waste github actions seconds pool for nothing. You can use this: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-ignoring-paths
It's not a nogo for me, but would be nice to have it implemented.

What if PR changes only files in github workflows and doesnt req bump in version? As I see it, now it will req the version to be bumped anyway. At least the workflow will be run unnecessarily.

If PR changes only GitHub workflows, so in particular it does not change any files in src/ folder, then this check would be skipped. We don't bump versions automatically now, it is for a developer to do it (or not in given circumstances, as per above). Agree workflow would be run anyway, but it's rather cheap ('just' git clone and simple O(1) checks? And I assume workflows are run in parallel, so the CI workflow is longer anyway, as clippy takes more time than introduced version check workflow.

ok, but why waste github actions seconds pool for nothing. You can use this: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-ignoring-paths It's not a nogo for me, but would be nice to have it implemented.

Let me try with those paths, agreed if we can make it work so workflow are not spawned for nothing then it's better.

I've applied review remarks and it's better now, apart from cleaner bash  we don't waste Guthub resources, and it's more clean to developer than checks are run only if they modify particular files.
Testing done:

https://github.com/Marcin-Radecki/AlephBFT/pull/5
https://github.com/Marcin-Radecki/AlephBFT/pull/6

Everything worked as expected after merge:

Code was synced to AlephFoundation: https://github.com/Cardinal-Cryptography/AlephBFT/runs/4801326323?check_suite_focus=true
Create was uploaded to crates.io: https://github.com/Cardinal-Cryptography/AlephBFT/runs/4801326331?check_suite_focus=true


Endless CNI config reload loop

Description
We noticed our containerd wasn't responding anymore and looking at logs, we saw this:
time="2021-02-16T22:13:09.433757455Z" level=error msg="failed to reload cni configuration after receiving fs change event(\"\": )" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"
time="2021-02-16T22:13:09.433805646Z" level=error msg="failed to reload cni configuration after receiving fs change event(\"\": )" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"
time="2021-02-16T22:13:09.433843823Z" level=error msg="failed to reload cni configuration after receiving fs change event(\"\": )" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"
time="2021-02-16T22:13:09.433880528Z" level=error msg="failed to reload cni configuration after receiving fs change event(\"\": )" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"
time="2021-02-16T22:13:09.433923837Z" level=error msg="failed to reload cni configuration after receiving fs change event(\"\": )" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"
time="2021-02-16T22:13:09.433966752Z" level=error msg="failed to reload cni configuration after receiving fs change event(\"\": )" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"
time="2021-02-16T22:13:09.434007966Z" level=error msg="failed to reload cni configuration after receiving fs change event(\"\": )" error="cni config load failed: no network config found in /etc/cni/net.d: cni plugin not initialized: failed to load cni config"

We're not using CNI at all with containerd. We're only using it for managing Docker images and snapshots.
Steps to reproduce the issue:
I don't know how it got into that state.
Describe the results you received:
(mentioned in the description)
Describe the results you expected:
I didn't expect containerd to get stuck in a loop.
Output of containerd --version:
containerd github.com/containerd/containerd v1.4.3 269548fa27e0089a8b8278fc4fc781d7f65a939b

Any other relevant information:
We're running the devmapper snapshotter.
This is the entirety of our config:
[plugins]
[plugins.devmapper]
pool_name = "data_0-nomadfc_layers"
root_path = "/var/lib/containerd/devmapper"
base_image_size = "8192M"

@jeromegn could you mind to show the result of containerd config dump ? thanks

version = 2
root = "/var/lib/containerd"
state = "/run/containerd"
plugin_dir = ""
disabled_plugins = []
required_plugins = []
oom_score = 0
imports = ["/etc/containerd/config.toml"]

[grpc]
  address = "/run/containerd/containerd.sock"
  tcp_address = ""
  tcp_tls_cert = ""
  tcp_tls_key = ""
  uid = 0
  gid = 0
  max_recv_message_size = 16777216
  max_send_message_size = 16777216

[ttrpc]
  address = ""
  uid = 0
  gid = 0

[debug]
  address = ""
  uid = 0
  gid = 0
  level = ""

[metrics]
  address = ""
  grpc_histogram = false

[cgroup]
  path = ""

[timeouts]
  "io.containerd.timeout.shim.cleanup" = "5s"
  "io.containerd.timeout.shim.load" = "5s"
  "io.containerd.timeout.shim.shutdown" = "3s"
  "io.containerd.timeout.task.state" = "2s"

[plugins]
  [plugins."io.containerd.gc.v1.scheduler"]
    pause_threshold = 0.02
    deletion_threshold = 0
    mutation_threshold = 100
    schedule_delay = "0s"
    startup_delay = "100ms"
  [plugins."io.containerd.grpc.v1.cri"]
    disable_tcp_service = true
    stream_server_address = "<IP_ADDRESS>"
    stream_server_port = "0"
    stream_idle_timeout = "4h0m0s"
    enable_selinux = false
    selinux_category_range = 1024
    sandbox_image = "k8s.gcr.io/pause:3.2"
    stats_collect_period = 10
    systemd_cgroup = false
    enable_tls_streaming = false
    max_container_log_line_size = 16384
    disable_cgroup = false
    disable_apparmor = false
    restrict_oom_score_adj = false
    max_concurrent_downloads = 3
    disable_proc_mount = false
    unset_seccomp_profile = ""
    tolerate_missing_hugetlb_controller = true
    disable_hugetlb_controller = true
    ignore_image_defined_volumes = false
    [plugins."io.containerd.grpc.v1.cri".containerd]
      snapshotter = "overlayfs"
      default_runtime_name = "runc"
      no_pivot = false
      disable_snapshot_annotations = true
      discard_unpacked_layers = false
      [plugins."io.containerd.grpc.v1.cri".containerd.default_runtime]
        runtime_type = ""
        runtime_engine = ""
        runtime_root = ""
        privileged_without_host_devices = false
        base_runtime_spec = ""
      [plugins."io.containerd.grpc.v1.cri".containerd.untrusted_workload_runtime]
        runtime_type = ""
        runtime_engine = ""
        runtime_root = ""
        privileged_without_host_devices = false
        base_runtime_spec = ""
      [plugins."io.containerd.grpc.v1.cri".containerd.runtimes]
        [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc]
          runtime_type = "io.containerd.runc.v2"
          runtime_engine = ""
          runtime_root = ""
          privileged_without_host_devices = false
          base_runtime_spec = ""
          [plugins."io.containerd.grpc.v1.cri".containerd.runtimes.runc.options]
    [plugins."io.containerd.grpc.v1.cri".cni]
      bin_dir = "/opt/cni/bin"
      conf_dir = "/etc/cni/net.d"
      max_conf_num = 1
      conf_template = ""
    [plugins."io.containerd.grpc.v1.cri".registry]
      [plugins."io.containerd.grpc.v1.cri".registry.mirrors]
        [plugins."io.containerd.grpc.v1.cri".registry.mirrors."docker.io"]
          endpoint = ["https://registry-1.docker.io"]
    [plugins."io.containerd.grpc.v1.cri".image_decryption]
      key_model = ""
    [plugins."io.containerd.grpc.v1.cri".x509_key_pair_streaming]
      tls_cert_file = ""
      tls_key_file = ""
  [plugins."io.containerd.internal.v1.opt"]
    path = "/opt/containerd"
  [plugins."io.containerd.internal.v1.restart"]
    interval = "10s"
  [plugins."io.containerd.metadata.v1.bolt"]
    content_sharing_policy = "shared"
  [plugins."io.containerd.monitor.v1.cgroups"]
    no_prometheus = false
  [plugins."io.containerd.runtime.v1.linux"]
    shim = "containerd-shim"
    runtime = "runc"
    runtime_root = ""
    no_shim = false
    shim_debug = false
  [plugins."io.containerd.runtime.v2.task"]
    platforms = ["linux/amd64"]
  [plugins."io.containerd.service.v1.diff-service"]
    default = ["walking"]
  [plugins."io.containerd.snapshotter.v1.devmapper"]
    root_path = "/var/lib/containerd/devmapper"
    pool_name = "data_0-nomadfc_layers"
    base_image_size = "8192M"
    async_remove = false

@jeromegn It seems that it is related to this one https://github.com/containerd/containerd/issues/4852, when containerd receives SIGTERM signal. I don't think it is root cause. Is there more log about containerd?

@fuweid you're right! I missed the "good" logs after the 1.4 million logs (not kidding) containerd spewed after I tried restarting it (via a SIGTERM).
What made our containerd stuck was "failed to deactivate device" errors.
The config dump made me realize there's a async_remove option which would help us a lot. We're already detecting lingering VMs that use these devices and make it impossible to GC them, so the async remove option will help with not blocking containerd entirely.

@jeromegn OK. We will fix the annoying log issue ASAP! Thanks for the reporting!


Ability to see a list of all clients in the Simian web UI without needing to provide search parameters

The summary page should list all clients (paginated of course) in the same way that clients are listed after using the search functionality (but not filtered).
Currently, it's a pain to browse through all clients - which might be less useful for large organisations but would be very useful for small-medium businesses and also new users finding their way around the UI for the first time.

David, I believe you can (almost) accomplish this by clicking "Stable Clients", "Testing Clients" or "Unstable Clients" under the "Active Client Reports" table at the top-right of the main/summary page.  Does this work sufficiently for you?

Am I missing something? I only see "No clients were found." on the summary page, even though I have one client. I don't see any "Active client reports"

https://github.com/google/simian/blob/master/src/simian/mac/cron.yaml#L48
The main summary page (which including the Active Clients Reports table) is only updated as often as that cron is set to execute (default: every 4 hours).  If you've recently setup a new instance (which it sounds like is the case given your other emails/etc.), this will list no results for the interim.  We could probably smooth this out a bit; for example, if no clients are found in the cache, simply query datastore on demand, or kick off a background task to start the cron immediately so it's ready shortly afterward.  And of course updating the wording to reflect all of this.


[DO NOT MERGE, TESTING ONLY] Release Qualification

Trigger release qualification jobs
none

@chxchx: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/daily-release-qualification.sh
95cfad783f8457c23eedd1ab68edc5a1344ebef0
link
/test daily-release-qualification

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


HTTP: request timeout on redirect, regression in 3.0.0-RC2

Regression introduced in dc3905a: setInactive must be called before onHttpResponseBodyChunk because it might be performing a redirect, so calling it after would lose the current HttpTx and reads will be ignored.

So this issue was reported to be a duplicate of this one https://github.com/gatling/gatling/issues/3547.
However, the 3547 is not fixed with 3.0.0-RC3.

I've tried 3.0.0 version and got this error:
i.g.h.c.i.RequestTimeoutException: Request timeout to ... after 60000 ms
and with 3.0.0-RC4: no problem.
In the same time, AhcConfiguration has been migrated to AdvancedConfiguration, I don't know if it's related.
I'm going to find a reproducable sample for this issue but I think it's the same as : Gatling 3.0.0 - HTTP request timeout under low load (3 users) - i.g.h.c.i.RequestTimeoutException

I'm going to find a reproducable sample for this issue

@romaindequidt It would be really great! As I said on the mailing list, I haven't been able to reproduce.

I ran into the same problem, I did a contrast test with LoadRunner, LR did not have such an error, but Gatling has.

@romaindequidt @trunks023 Any news regarding a reproducer?

@trunks023 Which Gatling version did you use? Could you please provide a way to reproduce on our side?

@romaindequidt @trunks023 gentle ping. We plan on releasing 3.0.1 beginning of next week. If you think you experience a bug, now's the chance to get it fixed. Otherwise, next release might be at least one month later.

@slandelle I wanted to gain in skill with HttpIntegrationSpec and handlers to be able to share a reproducer with you.
My scenario always raise a RequestTimeoutException at the second "exec" while a "during".
When I breakpoint this exception, I don't find any information about the cause and the others threads doesn't seem neither relevant nor waiting.
I found some changes to investigate in Diff between 3.0.0-RC4 et 3.0.0
I'll try tomorrow.
Note: it's really diificult to investigate what is in progress in the netty eventloop. Do you have any tricks?
Note2: As there is no tag v3.0.0, I have to find the release commit to check it out. Are you going to change that?

@romaindequidt

Do you get the expected number of events (requests + timeouts) or do you experience extra events?
Could you please share the logs (TRACE) from 3.0.0-RC4 and 3.0.0?

You won't be able to investigate with break points, those just don't work with async programs.

@romaindequidt Could you please confirm that the issue you're experiencing is actually #3607?

@slandelle i confirm
I investigate the issue this morning and figure out that is the root cause was the way to handle the retry after "Premature close"
By setting the gatling.http.ahc.maxRetry to 0 both verion 3.0.0_RC4 and 3.0.0 was failing.
I miss my first contribution ;)
I'm impatient to test the 3.0.1 release.

@romaindequidt Great, thanks for confirming! 3.0.1 should be out next week.

It works by 3.0.3

Hi @slandelle
I am still getting this issue.
Gatling version: 3.2.1
`
18:23:37.694 [WARN ] i.g.h.e.GatlingHttpListener - Request 'XYZ' failed for user 37
io.gatling.http.client.impl.RequestTimeoutException: Request timeout to xyz.com/<IP_ADDRESS>:80 after 60000 ms
18:23:37.694 [WARN ] i.g.h.e.r.DefaultStatsProcessor - Request 'XYZ' failed for user 37: i.g.h.c.i.RequestTimeoutException: Request timeout to xyz.com/<IP_ADDRESS>:80 after 60000 ms
================================================================================
2019-11-29 19:13:14                                        3865s elapsed
---- Requests ------------------------------------------------------------------

Global                                                   (OK=69988835 KO=1215  )
XYZ                                                      (OK=69988835 KO=1215  )
---- Errors --------------------------------------------------------------------
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    164 (13.50%)
xyz.com/...
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    164 (13.50%)
xyz.com/...
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    152 (12.51%)
xyz.com/...
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    148 (12.18%)
xyz.com/...
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    147 (12.10%)
xyz.com/...
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    142 (11.69%)
xyz.com/...
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    140 (11.52%)
xyz.com/...
i.g.h.c.i.RequestTimeoutException: Request timeout to XYZ    129 (10.62%)
xyz.com/...
j.i.IOException: Premature close                                   21 ( 1.73%)
status.find.in(200,201,202,203,204,205,206,207,208,209,304), f      8 ( 0.66%)
ound 504

---- XYZ ---------------------------------------------------------------
[--------------------------------------------------------------------------]  0%
waiting: 0      / active: 100    / done: 0
`
I checked on my ELB, no calls are reaching it during these error. Moreover, this is happening, intermittently, even if I run the same test multiple times.
Any help would be greatly appreciated. Thanks.

No, those timeouts are real issues from your system under load, don't blame the messenger.

Thanks for the revert. I will raise support ticket and try to debug from ELB side. However my biggest doubt is that, when I run similar load from Jmeter, I never get this issue.
I am doing POC for Gatling in my org and trying to benchmark Jmeter/Gatling with respect to APIs we have. My aim is to move us to Gatling, if everything goes well.

However my biggest doubt is that, when I run similar load from Jmeter, I never get this issue.

Can't draw any conclusion without a tcp dump, but this wouldn't be the first time Gatling helped uncover an ELB or ALB bug.

Just leaving a comment in case it might help anyone in the future.
In gatling.conf file uncomment the default property requestTimeout and set it to a higher value.


[VPP] ping is not working with a custom vrf-table

Description
If we create a new vrf-table:
ip table add 1
and run:
ping x.x.x.x table-id 1
Ping is failed.

Patch: https://gerrit.fd.io/r/c/vpp/+/33729

Merged - https://gerrit.fd.io/r/c/vpp/+/33729


This PR fixes a minor bug in localbuild.py, which halts the build procedure.

I've verified that this is correct.


Xournalpp is missing icons

Describe the bug
Some icons from the sidebar are missing.
In the terminal:
(xournalpp:14560): Gtk-WARNING **: 11:48:58.377: Error loading theme icon 'window-close' for stock: Icon 'window-close' not present in theme Adwaita

(xournalpp:14560): Gtk-WARNING **: 11:48:58.377: Error loading theme icon 'go-up' for stock: Icon 'go-up' not present in theme Adwaita

(xournalpp:14560): Gtk-WARNING **: 11:48:58.377: Error loading theme icon 'go-down' for stock: Icon 'go-down' not present in theme Adwaita

(xournalpp:14560): Gtk-WARNING **: 11:48:58.377: Error loading theme icon 'edit-copy' for stock: Icon 'edit-copy' not present in theme Adwaita

(xournalpp:14560): Gtk-WARNING **: 11:48:58.377: Error loading theme icon 'edit-delete' for stock: Icon 'edit-delete' not present in theme Adwaita

Screenshots

Notify maintainers
 @andrew-d @sikmir @alyaeanyx
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 6.1.0-xanmod1, NixOS, 23.05 (Stoat), 23.05.20230105.a518c77`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.12.0`
 - channels(root): `""`
 - channels(quantmint): `""`
 - nixpkgs: `/run/current-system/nixpkgs`

What are your toolbar settings? (View -> Toolbars)

What are your toolbar settings? (View -> Toolbars)
Xournal++

Thanks, I was able to reproduce this now. I'll take a look at it.

Seems like it's an upstream issue that's already known: https://github.com/xournalpp/xournalpp/issues/3945
Apparently there was a PR about it that was merged 2 weeks ago in https://github.com/xournalpp/xournalpp/pull/4544, and I've confirmed that the issue is fixed on master, so we'll get the fix with the next release of Xournal++ :)
Screenshot of Xournalpp built from master:


Can't invite from Teams with AAD “Admins and users in the guest inviter role can invite” enabled

My experience in attempting to add an external Guest user to a Microsoft Team has been confusing.
I am a Global Admin and the Team Owner, but I could not add the external Guest to the Team from the Team "Add Members" interface using the methods detailed in this documentation.  Instead I received the "We didn't find any matches" error while trying to add a Guest from the Teams interface.
Points to note:
(1) I have the Azure AD option “Admins and users in the guest inviter role can invite” is enabled to provide control around Guest access. This setting is found in Azure Active Directory > Users > User Settings > External Users Manage external collaboration settings > “Admins and users in the guest inviter role can invite”.
(2) I had already added my Guest as a Guest user in Azure AD.
(3) I am a Global Admin and the Team Owner (mentioned previously).
The only way I have found to add an external Guest (with “Admins and users in the guest inviter role can invite” enabled) is from the Teams Admin Portal > Teams > Select the relevant Team >  Team Members > Add members.
Please consider updating content on this page and throughout this Guest Access section of documentation to clarify the situation when “Admins and users in the guest inviter role can invite” is enabled.
Kind regards
Andy.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 93906e31-cd28-702d-bb7e-fcc2529df363
Version Independent ID: afe4d6ed-cdcb-77e0-0951-f3c69e2463e1
Content: Add a guest to a team
Content Source: Teams/add-guests.md
Service: msteams
GitHub Login: @somakbhattacharyya
Microsoft Alias: sbhatta

... basically the text on this page "Global admins who are owners of a team and owners of a team can add a guest to a team through either the Microsoft Teams desktop or the web clients" is not correct when AAD>"Admins and users in the guest inviter role can invite” is enabled.

@HandyAndyOnGitHub thank you for submitting feedback and contributing to the docs. We are currently investigating this.

@officedocsbot assign @scanum

@HandyAndyOnGitHub Thank you for your feedback, I will have it sorted soonest.

I am also experiencing this issue. It's actually become a blocker in our company moving from Slack to Teams as we collaborate quite heavily with 3rd Parties using our Slack setup.
Hope this is fixed soon!

@Xander99 Thank you for letting me know.  I'm still investigating with the team and will keep you posted on developments.

@HandyAndyOnGitHub I will add a note with regards to your second comment thank you.  The original issue at the top - are you referring to this article or a link in this article.  Please could you be a bit more specific so I can add clarification to the doc.  Thanks in advance.

@Reeced40 I'm referring to this article.  What I'm saying is that due to a bug/feature in the code the article is not correct under the conditions that I've described.  Without fixing the code, the text on this page could note the odd behaviour until such time as the code is corrected :)

@HandyAndyOnGitHub thank you for submitting feedback.
I think the best way forward is if you open a service ticket in your tenant so this can get resolved ASAP. Based on the outcome let me know if it is something that can be called out in the docs.
Please follow this link to contact support for business products:https://docs.microsoft.com/office365/admin/contact-support-for-business-products
Please keep us posted here on the resolution so we can feed whatever information you discover into the content.

@officedocsbot close


Is this command wrong?

This command may put mmdet3d_full under ./mmdet3d
cp -r ../mmdet3d_full ./mmdet3d

Hello,
You are right!


Fix bower.json

Hi,
Could you please fix your bower.json from that :
"main": "src/ng-intl-tel-input.directive.js",
to that :
"main": "dist/ng-intl-tel-input.directive.js"
The lib breaks with tools like wiredep.
Thanks

@vogloblinsky PRs are welcome :wink:
We are more receptive to contributions than orders.

Submitted ;)

https://github.com/hodgepodgers/ng-intl-tel-input/pull/29


Partner Authorisation

Implement middlewares: What can a partner user account do? Which data can the partner change and see and have access to, and where can do a GET, POST, PUT, or DELETE occur?
For this task, it is necessary to take the same structure/solution as the task developed the week before.

Story Points: 8
See the discussion in Backend S2
Powered by Parabol


Decide whether or not a role is required for new protocol user credentials.

And we need to update the BRP according to that decision. If it is required we need to fix the backend to prevent form submission without the field being entered. If it is not required we need update the front end to remove the required field indicator from the form.

Further review of the code reveals that we need to patch the backend as well. An empty roles field is prevented only when the user is not already on the protocol. The error handling on the backend only check the for the existence of non-field error instead of checking each individual error so if the form verification system throws an error about the user already being on the protocol it lets all errors through.


Subfolders for each calculation

Store the results in a subfolder rather than as individual files. This will help cleaning up the directories for old or broken calculations.
It may also help in parallelisation later...

Done in commit 62bb545


Support for the multiple gcn filters

Hi, Kipf, thanks for sharing us such a great work.
I'm using gcn to perform a regression work on my dataset, in which I have around 500 nodes and 153 features.  The performance is not good even for the training set (R^2 = 0.4)
I was wondering:

Classical CNN models (AlexNet, VGG) often uses multiple filters to extract different patterns, but the current implementation of GCN, if I understand correctly, only uses one graphConv filter. Do you think multiple gcn filters can help?

If yes, how can I add more filters?

You can try the model from our ICML 2018 paper:
https://github.com/ethanfetaya/NRI - the graph neural network we use there
has a much higher capacity and typically performs better in cases where you
have enough data (otherwise it would easily overfit). In the low-data
regime the GCN model from this repository here should do fine.
On Fri 10. Aug 2018 at 02:33 yanglin-jason<EMAIL_ADDRESS>wrote:

Hi, Kipf, thanks for sharing us such a great work.
I'm using gcn to perform a regression work on my dataset, in which I have
around 500 nodes and 153 features. The performance is not good for now (R^2
= 0.4)
I was wondering:

If I understand correctly, current implementation only use 1 graphConv
filte. Do you think the multiple gcn filters can help?
2.
If yes, how can I add more filters?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tkipf/gcn/issues/47, or mute the thread
https://github.com/notifications/unsubscribe-auth/AHAcYOlqahtXpBCw7Z9Qozow5ppqQwnIks5uPOLbgaJpZM4V3c3a
.

Thanks a lot! I will have a try.

Thx!


path is index files ends with .html

Open the query-index, all paths end with .html.
cc @dominique-pfister

And they shouldn't?

Oops, sorry, I was writing the issue and jumped on something else. I added more details.

We can get rid of the extension, but then the client code (e.g. sitemap.xml or cards in other projects) needs to be adapted, too.

Done


Can you help to make a plugin for Livere?

Hi.  I knew Livere is a very good comment system. But I don't know how to make a plugin.
I wrote  a component called Livere.vue
<template>

为正常使用来必力评论功能请激活JavaScript

</template>

And then I use <Livere/> at the end of the Markdown file, and worked.  But also with some bugs:

Sometimes the page will render 2 or 3 comment boxes. I don't know why.
The comment box is in the content of main file. (I want it at the very bottom.)

If it is convient for you, can you help me with it. Thank you very much.

Hi there 👋 Thanks for the suggestion but no I don't use Livere.


[5.2] Added sqlserver odbc connection support

#13264

What if odbc is an availble driver but they want to use the sqlsrv string?

we can check driver config param in config/database.php file.
'sqlsrv' => [             'driver'   => 'sqlsrv',             'host'     => env('DB_HOST', 'localhost'),             'database' => env('DB_DATABASE', 'forge'),             'username' => env('DB_USERNAME', 'forge'),             'password' => env('DB_PASSWORD', ''),             'charset'  => 'utf8',             'prefix'   => '',         ],


chore: change ignore list for node_modules to be less restrictive

Fixes #3615.
What this PR solves / how to test:
Currently, wrangler ignores any folder that is named node_modules. While intentions are good, this is inherently very restrictive and should not be done. This PR changes the ignore list to only ignore the root folder's node_modules.
Author has addressed the following:

Tests

[ ] Included
[ ] Not necessary because:

Changeset (Changeset guidelines)

[X] Included
[ ] Not necessary because:

Associated docs

[ ] Issue(s)/PR(s):
[ ] Not necessary because:

Note for PR author:
We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

I've added a .pagesignore alternative.

Hi, thank you for your PR! Unfortunately, I don't think this is something we're open to implementing right now, but we may revisit this in the future. Thank you for your suggestion.

Very unfortunate to see.

Can we know of why Cloudflare is not open to implementing this?

Hey Nora!
I’m a Product Manager on the Pages/Workers team. I wanted to first off take a moment to thank you for taking the time to write this PR. We are so grateful to have folks in our community like you who are passionate about bettering our products in this workers-sdk repo.  We are so lucky to have such an active contributor community - it is such an invaluable source of bug repos, ideas, and indeed, contributions!
In the future, we're going to encourage contributors to first discuss the implementation with the team in the issue before spending time on it in a PR, so we can get alignment on which issues are ready to be worked on, and what the design for that change actually looks like. We're going to add notes to the CONTRIBUTING.md to that effect.
Though this PR wasn't accepted, we want to sincerely thank you for your contribution. We are sorry that we didn't have this process in place before you spent time on the PR and will absolutely do better next time to avoid this situation.
In regards to this PR specifically:
We're in the process of converging the Pages and Workers products which comes with its own set of challenges, and one of the really thorny ones is how to best handle configuration. Workers and Pages have different configuration options today (both because they have different features, and also because they were developed somewhat independently).
They also have different mechanisms for managing that config (Pages is managed almost exclusively in the dashboard where config takes effect with the next deployment and has CLI args for local dev, whereas Workers supports file-based config — wrangler.toml — in-dash config which takes effect immediately and CLI args). We're looking to minimize any surface we can, and adding new config options, regardless of how that is set, would instead just add to the complexity of the problem. We're investigating a long-term and flexible configuration solution, such as  adding support for wrangler.toml in Pages. Here, we may allow users  to add things like include/exclude rules as part of the static asset config.
So, in the meantime, we have decided to close this PR because rather than add this adhoc fix, we would really like to spend time and think about configuration holistically for Pages/Workers.
Relatedly, the original issue here #3615 is closed as we don't consider that a bug in the current product — we're intentionally not uploading those folders. However, #3176 is a valid feature request, and one we're actively considering in the roadmap as discussed. It might not be a CLI arg, but the general idea of customizing which assets to upload is something that we're actively thinking about.
Again, I want to thank you again for taking the time to put your thoughts and ideas together in this PR. It is absolutely wonderful to see active developers such as yourself contributing to our workers-sdk repo.

The insight here is greatly appreciated @nevikashah.
I still don't entirely agree that this is being treated as a Feature Request and not a regression though. This used to work prior to https://github.com/cloudflare/workers-sdk/pull/2103, so while the feature request in https://github.com/cloudflare/workers-sdk/issues/3176 would indeed solve this, it's still technically a regression from prior functional behaviour, and has been reported and raised by both myself and others since 2022.
Nevertheless, thank you for the insight.

Thank you for the explanation! I agree that for the long term it's more sustainable with a more shared and thought out approach.
However, for the short term, I would've suggested that an experimental flag is added.
Either way - I understand the decision now that it's been explained, thank you. :)

@nevikashah Thanks for a great response explaining the background to this rejection. Still it's very sad to see this not being a higher priority since it's currently breaking all Expo Web projects, requiring manual workarounds specifically for deploying on Cloudflare Pages as reasoned about in #3615 with this current workaround

cloudflare lost 1 customer for this


addScriptTag fails with type=module

Steps to reproduce
Tell us about your environment:

Puppeteer version: 1.10.0
Platform / OS version: macOS 10.14
Node.js version: 10.10.0

What steps will reproduce the problem?

create a test.js script with the content below and run node test.js

const http = require('http');
const puppeteer = require('puppeteer');

function serve(port) {
  return new Promise((resolve, reject) => {
    const server = http.createServer((req, res) => {
      res.end('console.log("Hello World")');
    });

    server.listen(port, err => {
      if (err) {
        reject(err);
        return;
      }
      resolve(() => {
        server.close();
      });
    });
  });
}

async function main() {
  const port = 3000;
  const done = await serve(port);

  const browser = await puppeteer.launch();
  const page = await browser.newPage();
  await page.setBypassCSP(true); // setting this to false or omitting it has the same result

  page.on('console', msg => {
    for (const arg of msg.args()) {
      process.stdout.write(`${arg}\n`);
    }
  });

  try {
    await page.addScriptTag({
      url: `http://localhost:${port}/`,
      type: 'module' // things work if this is not set to 'module'
    });
  } finally {
    await browser.close();
  }

  done();
}

if (require.main === module) {
  main().catch(err => process.stderr.write(`${err.stack}\n`, () => process.exit(1)));
}

What is the expected result?
JSHandle:Hello World
What happens instead?
Error: Loading script from http://localhost:3000/ failed
    at Frame.addScriptTag (/path/to/node_modules/puppeteer/lib/FrameManager.js:579:15)
    at process._tickCallback (internal/process/next_tick.js:68:7)
  -- ASYNC --
    at Frame.<anonymous> (/path/to/node_modules/puppeteer/lib/helper.js:144:27)
    at Page.addScriptTag (/path/to/node_modules/puppeteer/lib/Page.js:395:29)
    at Page.<anonymous> (/path/to/node_modules/puppeteer/lib/helper.js:145:23)
    at main (/path/to/test.js:37:16)
    at process._tickCallback (internal/process/next_tick.js:68:7)

If I remove type: 'module' from page.addScriptTag(), then I get the expected result: the script is loaded and logs "Hello World" to the console.
With type: 'module', the script fails to load.  The exceptionDetails in ExecutionContext.js is Event.
I assumed initially that the script failed to load due to CORS issues.  But I get the same result when calling page.setBypassCSP(true) (or the same with false).

@tschaub quick guess: you can't load module scripts to the about:blank page. Try navigating the page first to some reasonable URL?

Yep; reproduced it locally. Adding module scripts to about:blank is not supported. In fact, about:blank is a special kind of page in many ways, so I'd recommend navigating off it right away before doing anything else.
Hope this helps.


Added daily doc rebuild

@cartermp I added an automated daily build of the docs, do you think that's reasonable?
Nothing will change most days so I'm not sure it's worth it?
thanks
don

See https://github.com/fsharp/fsharp-core-docs/blob/main/.github/workflows/docs.yml#L5


[VL] CI: split ubuntu 2204 job to speed up

What changes were proposed in this pull request?
split the ubuntu 2204 job
How was this patch tested?
pass GHA

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query
log/native_4156_time.csv
log/native_master_12_21_2023_a24ddedc4_time.csv
difference
percentage

q1
32.80
33.45
0.654
101.99%

q2
24.78
25.89
1.106
104.47%

q3
38.29
38.17
-0.126
99.67%

q4
39.24
40.48
1.241
103.16%

q5
72.90
70.31
-2.590
96.45%

q6
6.56
7.04
0.479
107.31%

q7
86.35
87.08
0.728
100.84%

q8
86.52
86.10
-0.417
99.52%

q9
125.51
126.84
1.327
101.06%

q10
47.70
45.01
-2.694
94.35%

q11
20.03
19.76
-0.273
98.64%

q12
24.77
25.94
1.171
104.73%

q13
46.05
45.62
-0.431
99.06%

q14
17.09
17.88
0.789
104.62%

q15
27.19
28.77
1.581
105.81%

q16
15.57
15.88
0.307
101.97%

q17
103.52
102.51
-1.013
99.02%

q18
153.16
150.60
-2.560
98.33%

q19
12.68
13.64
0.957
107.54%

q20
29.41
29.17
-0.238
99.19%

q21
229.64
228.00
-1.641
99.29%

q22
14.01
14.05
0.045
100.32%

total
1253.77
1252.17
-1.599
99.87%


Fix missing includes and namespaces.

By default, UE compiles multiple CPP files at once by concatenating them together, called a unity build. This makes the build go faster, but can mask missing includes and namespace references. Prompted by https://community.cesium.com/t/updated-to-latest-1-5-1-plugin-and-it-wont-compile-on-4-26-or-4-26-2-source-engine-in-visual-studio/15083, I turned off this concatenation by adding the following to C:\Users\[my user name]\AppData\Roaming\Unreal Engine\UnrealBuildTool\BuildConfiguration.xml:
<?xml version="1.0" encoding="utf-8" ?>
<Configuration xmlns="https://www.unrealengine.com/BuildConfiguration">
    <BuildConfiguration>
        <bUseUnityBuild>false</bUseUnityBuild>
    </BuildConfiguration>
</Configuration>

Then I compiled the plugin and fixed any errors that were reported. This PR is the result.

Thanks for the pull request @kring!

:heavy_check_mark: Signed CLA found.
:grey_question: CHANGES.md was not updated.

If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

[ ] Cesium for Unreal Samples works.


Undeclared variables not passing typescript compiler

When trying to compile my typescript project after installing modern treasury via npm, I get the following errors. This is preventing me from being able to build and test the integration.
node_modules/modern-treasury/dist/cjs/core.d.ts(101,12): error TS2304: Cannot find name 'URL'.
node_modules/modern-treasury/dist/cjs/core.d.ts(119,44): error TS2304: Cannot find name 'Awaited'.
node_modules/modern-treasury/dist/cjs/core.d.ts(149,44): error TS2304: Cannot find name 'Awaited'.
node_modules/modern-treasury/dist/cjs/core.d.ts(152,12): error TS2304: Cannot find name 'Awaited'.

Upgrading tsc to 4.5 fixes the Awaited issue. Still unknown on URL

Just node funkiness.


revert RefSeqGPFFParser to master branch version

Description
RefSeqGPFFParser has been updated, but WormbaseCElegansRefSeqGPFFParser depends on it and has not been fully updated to be compatible with the changes.
Thus RefSeqGPFFParser is being reversed in this branch for merge with master to be possible.
The work done on RefSeqGPFFParser is still availabe on the ensembl-xref repo.
Use case
See ENSCORESW-3221
Benefits
Salvage more work from the 2018 xref sprint.
Possible Drawbacks
none I can see
Testing
Have you added/modified unit tests to test the changes?
no
If so, do the tests pass/fail?
yes
Have you run the entire test suite and no regression was detected?
yes

Coverage decreased (-0.03%) to 81.513% when pulling 920c3697d12719e32779d24136d124fbc2f44eef on RefSeqGPFF_revert into 66568d2a84bae7570331d73f81710d42ec34fcb7 on feature/xref_sprint.


Is the Gaussian process for optimization of molecules included in the repository?

Hi,
I have read your paper and think it is a wonderful work. In your paper, it referred a Gaussian process can be used in the latent space for optimizing the molecule for a specific property? Is there an example for this? Thank you
Ji

@hcji https://github.com/Ryan-Rhys/Constrained-Bayesian-Optimisation-for-Automatic-Chemical-Design


use branch

Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL:
iOS PR:
macOS PR:
What kind of version bump will this require?: Major/Minor/Patch
Optional:
Tech Design URL:
CC:
Description:

Steps to test this PR:
1.
1.

OS Testing:

[ ] iOS 14
[ ] iOS 15
[ ] iOS 16
[ ] macOS 10.15
[ ] macOS 11
[ ] macOS 12

Internal references:
Software Engineering Expectations
Technical Design Template

Current dependencies on/for this PR:

main

PR #533   👈

This comment was auto-generated by Graphite.


Update VNET feature branch

bring it up to date with master
adapt secrets.yaml format as discussed in #256
support service principal auth for storage account

I think there's still a bit of cleaning up and error checking remaining, but it would be good to get feedback on what's here so far.

I've added some checks so that it fails if both service principal and shared key auth is provided for either batch or storage. What other checks/validation do you think are needed? (for easy reference, this is how it compares to master: https://github.com/Azure/aztk/compare/89f0e54...emlyn:vnet).

I've also added some checks that the correct servicePrincipal keys are present.
One issue I'm not sure about, is that I currently hard code the resource url for service principal credentials ('https://management.core.windows.net/' / 'https://batch.core.windows.net/'). Is there a way to get the correct values programmatically, or should there be a way for the user to specify these?


Rewrite aws/iam/ocst_1_3_8_wildcard_principals.yaml as a threat story

id: OCST-1.3.8
name: Use of wildcard principals
description: |
  Inappropriate use of wildcard ("*") principals may allow an attacker to
  escalate privileges. This is because the wildcard principal includes any
  principal, not just those in the same account. This will, unless strictly
  controlled, open the resource to any valid AWS principal.
service: AWS IAM
status: Confirmed
stride:
  - Elevation of privilege
components:
  - IAM AssumeRole
  - Principals
mitigations:
  - aws/iam/features/wildcard_principals_not_used.feature
references:
  - https://docs.aws.amazon.com/IAM/latest/UserGuide/reference_policies_elements.html
  - http://docs.aws.amazon.com/AmazonS3/latest/dev/s3-bucket-user-policy-specifying-principal-intro.html

Doesn't appear to be a threat story in https://github.com/owasp-cloud-security/owasp-cloud-security/tree/master/features/aws/iam/threats to review?


Update legend for NECCC by removing hessian fly filter

This PR has fixes for https://github.com/precision-sustainable-ag/dst-selector/issues/502
Updated constants.js file to provide list of filters for NECCC

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.

Your review app has been deployed and is available at 'http://<IP_ADDRESS>:80'.Learn More about how to test and provide feedback for the app.


Update account number design in Exchanges screen

Description
I checked in with @coreycelo and we decided to use the new Account Number design in the Exchanges Screen
Tested

How others should test

Go to Add and Withdraw from the sidebar
choose Cash Out
choose any currency, select Cryptocurrency Exchange

Related issues

patch for #434

Backwards compatibility
yes

https://valora.testquality.com requirement R48.

Hi @MuckT We have verified this issue on Latest android build V1.16.0 & Testflight build V1.16.0(66) and updated the status in testqulaity tool.
Testquality tool link:
Android:

https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432174
iOS:
https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432202
Devices: Vivo v11 pro (10), iPhone 6+(12.4.5)
CC: @isabellewei

Hi @MuckT We have Cross verified this issue on Latest android build V1.16.1 & Testflight build V1.16.1(67) and updated the status in testqulaity tool.
Testquality tool link:
Android:

https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432174
iOS:
https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432202
Devices: Vivo v11 pro (10), iPhone 6+(12.4.5)
CC: @isabellewei

Hi @MuckT Again We have cross verified this issue on Latest android build V1.16.1 & Testflight build V1.16.1(67) and updated the status in testqulaity tool.
Testquality tool link:
Android:

https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432161
iOS:

https://valora.testquality.com/project/12128/plan/20854/run/148956/result/2432189

And also we have tested #482
Devices: Vivo v11 pro (10), iPhone 6+(12.4.5)
CC: @isabellewei

Hi @MuckT, We have verified this issue on Latest android build V1.16.0 in Android 11.0 OS and everything is working as expected.
Device Details: Google Pixel 4a(11.0)


[Dynamic Regions] br: pitr task in error "retry time exceeds: error failed to get initial snapshot"

Bug Report
See https://github.com/pingcap/tidb/issues/45517

What version of TiKV are you using?

master
What operating system and CPU are you using?

Steps to reproduce

open pitr task in partitioned raft kv cluster

What did you expect?
What did happened?
task error failed to get the snapshot (region_id = 1538): Error during requesting raftstore: message: "read index not ready, reason can not read index due to merge, region 1538

It's not reproed anymore after merge fix. However region unavailable could still lead to BR failure.


translate api policy resource

What type of PR is this?
/kind documentation
What this PR does / why we need it:
translate API policy resource
Which issue(s) this PR fixes:
Part of #483
Special notes for your reviewer:

/cc @windsonsea @RainbowMango
Can you help take a look?

cc @samzong as well :)


[5.3][build-script-helper] Always do a clean build, to workaround an incremental build bug in swiftpm

master: https://github.com/apple/indexstore-db/pull/95

@swift-ci Please test


User streams is always not playing

It is by chance you get the mediaStream from both ends playing, it seems not stable

one end is playing video as audio


Improved config mgmt and fixed out of bounds panic

Changed the way the config is loaded to use defined structs instead of nested maps of interface{}.  Now, the config is loaded into a struct during initialization and the values are referenced by the struct fields as appropriate.  This refrains from reading and parsing the config file twice (once when loading the default sources and again when loading any analyzers.
Additionally, this change adds a length check to fix the panic shown in https://github.com/praetorian-inc/gokart/issues/2

@isp1r0 @praetorian-harry I can break this into multiple PRs if that would be preferred.  I just decided to include the fix for #2 in this PR along with the configuration stuff because it was blocking me from testing.

Added a fix for that in util/config.go.  Let me know if that works for you!

That fixed it, you rock @jessesomerville!

Kinda new to this, it looks wired to me.
Can you help me with coding.


Reproduce the Paper Results

Hi Authors,
I wonder if you can provide the detailed instructions (and pretrained models as well ideally) to reproduce the results reported in the paper (0.918 avg. dice score). Thanks

Hi @mmaaz60
Thanks for the interest in our work. For the leaderboard benchmarks, an ensemble of 20 models were used. In addition, following previous SOTA on this leaderboard, such as PaNN, we used extra private training data (80 volumes total). We have discussed this in section 4.3 of the UNETR paper (which uses same settings).
Best,

Hello @ahatamiz,
Thank you for your amazing work! Your results are super inspiring!
I would like to test some my thoughts on neural net architecture modifications, but I wanna be confident in my experiments. Do you have results on test set with no extra data?
And is this extra data publicly available? It is pretty difficult to try outperform your SOTA using almost triple time smaller dataset.
Best regards,

Hi,
i would also be interested in the additional data or at least the results without additional data. Is there a chance to share this with us?  Thank you.
Best


How can we pass string data(parameter) between two clients?

How can we pass string data(parameter) between two clients? Is this achieved by RTCDataChannel?

use a JSON ?
{
"data": "parameter",
"timestamp": "YourTimestamp"
}
And just use DataChannel to send the json

Is there any DataChannel implementation or sample code or documentation for RTCDataChannel implementation?

hey, I'm new to this repo. So do I need DataChannel if I just need to send a command(used to control a mini car)?

WebRTC doesn't provide signaling, so you probably use WebSocket, XMPP or any signaling protocol. You can send datas from those channels without using datachannels.
Integrating DataChannel isn't so hard, you just have to set the delegate and understand what is a DataChannel for webrtc (check https://developer.mozilla.org/fr/docs/Web/API/RTCDataChannel)

Hello, i made a pull request for this: https://github.com/ISBX/apprtc-ios/pull/45

you may use websocket and send a Json


fix correctness errors for AVS 2019-08-09-preview API

This backports a fixes for Swagger KPI correctness errors successfully fixed for the 2020-03-20 API in #11317. In addition, it adds a clusterID field. Newer APIs call the field clusterId.

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I commit to follow the Breaking Change Policy of “no breaking changes
[x] I have reviewed the documentation for the workflow.
[x] Validation tools were run on swagger spec(s) and errors have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Ensure to check this box if one of the following scenarios meet updates in the PR, so that label “WaitForARMFeedback” will be added automatically to involve ARM API Review. Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs, all “removals” and “adding a new property” no more require ARM API review.

Adding new API(s)
Adding a new API version
Adding a new service

[ ] Please ensure you've reviewed following guidelines including ARM resource provider contract and REST guidelines. Estimated time (4 hours). This is required before you can request review from ARM API Review board.

[ ] If you are blocked on ARM review and want to get the PR merged with urgency, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.

Breaking Change Review Checklist
If there are following updates in the PR, ensure to request an approval from API Review Board as defined in the Breaking Change Policy.

[ ] Removing API(s) in stable version
[ ] Removing properties in stable version
[ ] Removing API version(s) in stable version
[ ] Updating API in stable version with Breaking Change Validation errors
[ ] Updating API(s) in preview over 1 year

Please follow the link to find more details on PR review process.

/azp run automation - sdk

/azp run automation - sdk

I'll review this with the Breaking Change Review Board on Monday.
https://msazure.visualstudio.com/One/_workitems/edit/8740333

cc @JeffreyRichter

@ArcturusZhang, the breaking change was approved today. Please merge.


Fix being able to add duplicate color presets

Summary
Ensure that only unique color presets are added, even if selecting two elements with the same color and clicking to add presets.

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions
Test the following with different text styles / colors and also with shapes:

Add two or more elements that have identical color or style or background-color.
Select both/all elements and click + to add color preset.
Verify that only unique presets are added -- if two elements have the same background color then the color is not added twice.

Fixes #5216

@miina FYI there are some lint errors

@miina FYI there are some lint errors


Error when running React Native Demo (iOS)

Hi Team,
Followed all the required steps to run the React Native Demo for iOS, but getting the below error:
Can you please help.
Xcode : 12.5 (M1 Chip)

I am having an issue also running the sample app

@ziyiz-amzn , waiting for the resolution here?

so any luck ? i am stuck with the ios

so i fixed all the above issues and got this, app worked until you click button (start).


Use the composite prober for the broker

Problem
Once https://github.com/knative-sandbox/eventing-kafka-broker/issues/3176 is complete, we should use the composite prober to probe the broker, instead of the async prober we are currently using.
Persona:
Which persona is this feature for?
Exit Criteria
The broker probes with the composite prober instead of the async prober, and resolves properly for all transport encryption flags.
Time Estimate (optional):
How many developer-days do you think this may take to resolve? 1
Additional context (optional)
Add any other context about the feature request here.

https://github.com/knative-sandbox/eventing-kafka-broker/pull/3178
https://github.com/knative-sandbox/eventing-kafka-broker/issues/3141

/area control-plane
/assign

/triage accepted