Generalise scalar-units defintions

TOSCA is intended to be applicable to any domain but at present it only defines a few concrete scalar-units some of which are domain specific. We could add further scalar-units as demanded by users but this seems a slow and reactive approach.
Ideally we would allow users to define scalar-units useful to them e.g. in a similar manner to data type definitions. However, I can see that TOSCA processors would need a knowledge of the meaning of the unit strings (like the ‘m’, ‘m’ and ‘d’ symbols which we already allow to mean minute, hour and day as ‘s’ for seconds in scalar-unit.time).
An alternative would be to allow any scalar-unit from ISO 80000 since that covers many domains while using a fixed and defined set of prefixes (the familiar SI prefixes of ‘m’ milli, ‘M’ for Mega etc. and including KiB etc. for bytes). There are units libraries for common languages which can handle such unit strings. ISO 80000 must be paid for but a non-normative public document is at https://www.bipm.org/documents/20126/41483022/SI-Brochure-9.pdf

I definitely think this is possible. For Puccini's implementation the minimal requirements for a definition are as follows:

Whether the value is a float or integer.
Whether or not the units are case sensitive.
A table of units with multipliers to convert each unit to a canonical number for comparisons. E.g. for scalar-unit.size convert to bytes (case insensitive, integers):

"B":   1
"kB":  1000
"KiB": 1024
"MB":  1000000
"MiB": 1048576
"GB":<PHONE_NUMBER>
"GiB":<PHONE_NUMBER>
"TB":<PHONE_NUMBER>000
"TiB":<PHONE_NUMBER>776

As I've said before I think making the units string case insensitive is, in general, poor practice. Rather than having a parameter to indidate whether or not the units are case sensitive a user could define unit aliases if this was really needed, e.g.
"B":   1
"b":   1
"kB":  1000
"kb":  1000
"KiB": 1024
"kib": 1024

I tend to agree, just showing that we could still support current behavior if necessary (which Puccini has to for 1.X parsing).

Just pointing out that if you want to use aliases, then for 3-character units, e.g. KiB, you would need 2³=8 aliases, which is annoying to write out. Case insensitivity is easy enough to implement as a feature.
But anyway I'm in favor of enforcing case sensitivity. Of course with user-defined units, users can do whatever they want.

Here's a syntax suggestion:
<scalar_unit_name>:
    version: <version_number>
    metadata:
      <map of string>
    description: <datatype_description>
    # validation clause is implict; must be a unit_symbol_string+white space+data_value
    data_value_type: <data_type_name> #only data_types derived from either integer or float are permitted
    unit_symbol: <map of unit_symbol_name>
    metadata: <metadata_map>

<unit_symbol_name>:
    unit_symbol_string: <string>
    unit_symbol_multiplier: <integer or float>

and an example:
data_types:
    positive_integer:
        derived_from: integer
        validation: { $greater_or_equal: [ $value,  0 ] }

scalar_units:
    scalar-unit.bitrate:
    version: 2.0
    description: bitrate as defined as additional unit in ISO80000 but not including prefixes above 10^12
    data_value_type: positive_integer
    unit_symbol:
        "B":   1
        "kB":  1000
        "KiB": 1024
        "MB":  1000000
        "MiB": 1048576
        "GB":<PHONE_NUMBER>
        "GiB":<PHONE_NUMBER>
        "TB":<PHONE_NUMBER>000
        "TiB":<PHONE_NUMBER>776

While the above syntax is relatively simple and probably adequate it does have some shortcomings:

The unit symbol strings must be unique across the entire TOSCA document but that uniqueness is not enforced by the JSON and so must be checked by the processor.
Scalar-units cannot be namespaced.
The validity clause of the scalar_unit is implied and cannot be refined.
The list of SI prefxes must be repeated for every scalar-unit which uses them
Scalar-units cannot be derived from other scalar-units

Thanks @pmjordan. We'll make this a discussion topic for the Language Ad-Hoc once we finish substitution/requirement mappings.

I concur that units should be case-sensitive.
For time-units, TOSCA 1.3 only supports from nanoseconds ns  up to days d, but the proposed scheme would not work for weeks, months or years. HPE SD supports scheduling and deadlines and longer durations than days, even taking into account individual business calendars, vacations, holidays, and of course time-zones. My conclusion is that these would have to have some orchestrator built-in interpretation.
So when we open up for custom extensions to the TOSCA 1.3 scalar units, we need to allow built-in units that do not follow the symbol-multiplier scheme.

So when we open up for custom extensions to the TOSCA 1.3 scalar units, we need to allow built-in units that do not follow the symbol-multiplier scheme.

I implement these types using a multiplier table that translates the unit specifier into a numerical multiplier. If we made such a table part of the grammar, then we could allow for custom scalar unit types.


Auto-Refresh on status pages

⚠ Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find similar feature request

🏷 Feature Request Type
UI Feature
🔖 Feature description
Please can I request for status pages to automatically refresh every X seconds so they can be displayed on unmanned machines, such as a machine attached to a large screen.
✔ Solution
An option to set status pages to refresh every X interval.
❓ Alternatives
No response
📝 Additional Context
No response

Related to #1910

Duplicate of https://github.com/louislam/uptime-kuma/issues/978


Implement CKAN => frictionless

Acceptance criteria

[x] It converts the given ckan spec to frictionless spec
[x] It passes the tests

Tasks

[x] Write tests
[x] Implement the algorithm which CKAN => frictionless

[x] for package
[x] for resource

[x] Update README accordingly

Implemented in #7


Add pagination to dashboard service

as an end user I would like  to be able to page through search results in the fie browser
Boardwalk backend

[ ] Create a large test input index file
[ ] implement the search after method in ES (in Kibana)
[ ]  wrap up in a Python method

@caaespin I am putting this into your court for overall design plan.  We still think it is important


chore: rename extension description

This should improve discoverability by ranking higher in the vscode search, because of the "vim" keyword.

@xiyaowong not sure, worth a try. I think since this extension affects so much, it is a good example of an extension that should load as soon as possible.


Deploying via Helm w/ Azure Workload ID results in an error due to an unfilled field

Steps to duplicate:

Deploy Helm chart with --set oras.authProviders.azureWorkloadIdentityEnabled=true
Get error due to the deployment template calling for the value serviceAccount.name, which doesn't exist:

Error: UPGRADE FAILED: template: ratify/templates/deployment.yaml:19:152: executing "ratify/templates/deployment.yaml" at <.Values.serviceAccount.name>: nil pointer evaluating interface {}.name

I would be happy to PR a fix for this. However, I want some feedback first-
Since the service account is tied to Azure Workload Identity specifically and is not just any generic service account for the deployment, I am thinking of setting it up in the Values.yaml file as
oras:
  authProvider:
    azureWorkloadIdentity:
      enabled: <defaults to false, same value as azureWorkloadIdentityEnabled is at current>
      serviceAccountName: <relevant SA name>

(This is instead of the top-level serviceAccount.name field that the deployment template currently expects)
Thoughts?

thanks Lee for creating this tracking issue. From the auth doc , my understanding is this service account needs to be preconfigured for workload identity (step10) and also be specified in the deployment spec (step 11). There are some other existing logic based on serviceAccount.Name in helper.tpl @etrexel, could you help us determine what is the place to setup the serviceAccount name value?

@susanshi Yup, so I was assuming that the preconfiguration in step 10 is still done with the azwi CLI or otherwise using their workflow - but since it does create a service account it would be possible to plumb that through and integrate the service account creation directly into the helm chart. That would mean needing to provide the Azure SPN client ID when deploying the chart in addition to service account name but otherwise it would be fairly smooth user experience.
What's y'alls preference?

fixed merged, closing issue.


[WIP] [CBR-243]

Nothing to see here yet, this is a work in progress.

This work is on standby, blocked on CBR-317.

@adinapoli-iohk @edsko I guess I can close this PR, right?


Consistency in features list

Updates README.md features list to match docs/README.md features list (updated for #26).

Thanks!


Remove ssl-config and service-config projects and depend on http-remo…

…ting-api instead

This change is

note: this doesn't compile until we publish the corresponding http-remoting-api. compiles cleanly on my machine, so it's ready for review.
most interesting change is probably the new clients API:
ClientConfiguration config = ClientConfiguration.builder()
  .uris(...)
  .sslSocketFactory(..)
  .trustManager(...)
  .builder();

// Alternatively, with explicit config:
// SslConfiguration sslConfig = SslConfiguration.of(Paths.get("trustStore.jks"));
// ClientConfiguration config = ClientConfigurations.of(
//                ImmutableList.copyOf(uri),
//                SslSocketFactories.createSslSocketFactory(sslConfig),
//                SslSocketFactories.createX509TrustManager(sslConfig));

// Alternatively, with ServicesConfigBlock (deserialized from on-disk config)
// ServiceConfiguration config = ServiceConfigurationFactory.of(serviceConfigs).get("myService");

MyService service = JaxRsClient.create(MyService.class, "agent", config);

anything else, @gracew @markelliot ?

Will merge so I can move on, happy to fix up further comments in follow-up PR.


Build PR preview to include draft pages

This will allow work on content that is still not public ready to be previewed.

Fixes #321

As said in #321 the goal of the preview is to have the preview of the real website, not testing some drafts, I'm not really for enabling this.

(and would prefer to limit the number of drafts commited to the repo)


[Android] Onboarding Verification fails

Expected Behavior
Please describe the behavior you are expecting
Onboarding should proceed successfully.
Current Behavior
What is the current behavior?
The onboarding process fails upon trying to verify the phone number.
It will hang on the following screen:

And then eventually timeout:

Closing/restarting the app and restarting the phone will yield the same result.
This is on a Samsung Galaxy Note 8 with Android 9 Pie

@annakaz Verified with play store build v1.5.0 and new build zero-sync build v1.5.0 and observed that three verification code is not received when a new user signs up, hence we are blocked to sign up with new user.
Investigation I have tried to sign up with back up key and able to sign up.
Attachment.

Hello @wpank- could you please move this issue report to the Celo Forum at https://forum.celo.org/? We'll be able to help troubleshoot there

@wpank thanks for reporting this, and sorry to take so long to get back to you. The issue here is that our Attestations contract was hitting the block gas limit when requesting text messages - getting the current set of validators takes a lot of gas. We merged and deployed a fix to use a precompiled contract (https://github.com/celo-org/celo-blockchain/pull/441), and also updated the app, so it should be working now. You'll have to get a new invite, but otherwise should be all good to go


Fix filtering, detecting, reseting and ranking closes #135

Ranking issues:

I can't rank until after detecting, which I don't think should be the case.
I set it to sum, distance rank and it added a mean view distance column.
when I change to max distance rank nothing happens.
after a few sucessful ranking and filter then i tried sum distance rank again and got the error below

raceback (most recent call last):
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 2463, in __call__
    return self.wsgi_app(environ, start_response)
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 2449, in wsgi_app
    response = self.handle_exception(e)
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 1866, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 2446, in wsgi_app
    response = self.full_dispatch_request()
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 1951, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 1820, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/_compat.py", line 39, in reraise
    raise value
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 1949, in full_dispatch_request
    rv = self.dispatch_request()
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/flask/app.py", line 1935, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/wiggum_app/controller.py", line 313, in main
    result_df = rank_result.to_json(orient='records'),
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/pandas/core/generic.py", line 2425, in to_json
    index=index,
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/pandas/io/json/_json.py", line 78, in to_json
    index=index,
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/pandas/io/json/_json.py", line 122, in __init__
    self._format_axes()
  File "/home/smb/Documents/code/detect_simpsons_paradox_dev/env/lib/python3.6/site-packages/pandas/io/json/_json.py", line 211, in _format_axes
    "'{orient}'.".format(orient=self.orient)
ValueError: DataFrame columns must be unique for orient='records'.

detect issue:
if threshold is too high that nothing is returned, everything goes blank, but no error announce. please add a popup.
thanks for tip on how to unselect. we should note that somewhere. Some select feilds work by clicking again.
FIlter issue:

reset should unselect the menu selections
if any filter settings are applied, they should be re-applied after detection. so, make a variable that's a part of wiggum app that's current_filters or something like that and hold those parameters there or  have a binary variable filter that is false default, switches to true when filter btton pressed and to false when reset is pressed.  or something similar.


Text selection on Web doesn't work when passing markdownStyle without useMemo

Description:
When passing markdownStyle prop directly into MarkdownInputComponent without useMemo first e.g. markdownStyle={{link: {color: 'limegreen'}}} text selection stops working.
https://github.com/user-attachments/assets/c06b81f7-b7a3-4a30-b1cb-5f7cd700784d
Reproduction steps:

Use WebExample app
Change markdownStyle={markdownStyle} to markdownStyle={{link: {color: 'limegreen'}}} and save
Try selecting part of the input

Commit: c352064a2f6c71d457277d958a0270c9d989db5a

cc @BartoszGrajdek  @Skalakid

Please assign me as I will work on it.


NO-JIRA: fix E2E test - REST was changed by MGDOBR-809

The PR changed a creation of a bridge via REST API.
E2E tests start failing. I have added new parameters into REST request.

I am going to merge this change. There is one approval. E2E :: Quality Checks succeed


fix ci build failed

Hi @aviweit
This PR fixed the CI build issue on PR #71.
If possible,
please help to check the changes.
Thanks.

Hi @ianchen0119 ,
From my side, the changes look fine.

Hi @aviweit
As your suggestion,
I changed the building target in release.sh.
Besides,
I found that the most of nfs image just copy the binary from its base image.
So, I remove the duplicated items and move upf & ueransim & webui to build_context folder.
Please let me know if you have any comments or suggestions.
Thank you.

@ianchen0119 , I followed PR readme to build all NFs and starting them. n3iwf terminated with below logs.
make all
docker compose -f docker-compose-build.yaml build
docker compose -f docker-compose-build.yaml up

n3iwf            | ip: RTNETLINK answers: File exists
n3iwf            | ip: can't find device 'ipsec0'
n3iwf            | ip: ioctl 0x8913 failed: No such device
n3iwf exited with code 2

Please let me know if you have any comments or suggestions.

Hi @ianchen0119 , in my opinion, preserving the same structure as before (e.g. having nf_<NF name> folders, docker-compose build to generate NF final images), is better; because it is more intuitive (there are two phases: 1. to compile NF(s) 2. to generate final NF image + install 3rd party libraries).
This is only my opinion.

Hi @aviweit
I have discussed with @tim-ywliu
We think the most of 3rd party package is common tool for all network functions.
Of course we will have special cases (for example: go-gtp5gnl for upf & node.js for webui...),
In this case, we will separate  the final image from the compiled image for installing the dedicated packages.
Thanks for your suggestions and contribution🥳


How I can add script to template mode HTML

Hi all,
I need (I know is not a good practice) to put all my partials written in my app.js, like this
     .state('q11', {
            template: "
My title
"+
                            "
lorem ipsum .....
"

That is working, but the problem is when I need to put a script inside of html, for example:
    .state('q11', {
            template: "
My title
"+
                            "
lorem ipsum .....
"+
                            ""

That's not working, why? it should be the same, isn't it?
Thanks!

No. Scripts dont get evaluated when added that way. What is in the scripts? Can you load them with your app files and then call the function in that states controller?

This can/should also be asked on stackoverflow instead of here.

I needed it because I'm using a controller for all partials with a global object and if I add another controller to this partial I will not able to use that object (I used $rootScope to share the object between controllers and now it's working perfectly)
Thanks


Fix for missing sortablejs import

I was getting a 'Sortable not defined' error and it seems there's no import for sortablejs anywhere.

Current coverage is 49.86%

Merging #426 into master will not affect coverage as of bbbfd90

@@            master    #426   diff @@
======================================
  Files           81      81
  Stmts         3445    3445
  Branches       326     326
  Methods          0       0
======================================
  Hit           1718    1718
  Partial         32      32
  Missed        1695    1695

Review entire Coverage Diff as of bbbfd90

Powered by Codecov. Updated on successful CI builds.

Thanks, we've missed this one when switching to Webpack!


feat(forge): improve verify UX

Motivation

Issue #1567
Solution

[x] auto detect compiler version and optimizer runs
[x] add --watch flag for verify-contract to run monitor verify-check
[x] add --verify flag to forge create

@mattsse thanks, just one q. is there a function that would give me the default compiler version, the one that's used during forge build if none is set in foundry.toml

@mattsse thanks, just one q. is there a function that would give me the default compiler version? the one that's used during forge build if none is set in foundry.toml

for a specific file?
this is a very good point.
if we have autodetection enabled then this will be determined by
https://github.com/gakonst/ethers-rs/blob/98fc8c88e45483566fd1eaa50f1b70531437fa5a/ethers-solc/src/compile/project.rs#L156-L158
we should make this a bit easier and provide a utility function for this that takes a single file and returns all appropriate versions, and the best

@mattsse i believe that autodetection is the last thing left here. will take a look tmrw morning. oh, gotta fix tests as well

@mattsse @gakonst marked as RFR

Tested this locally a few times myself, looks robust. Main thing I'd recommend is seeing if we can make verify-check work just by taking the contract name, instead of the path + contract name, i.e. forge verify-check Contract vs forge verify-check src/Contract.sol:Contract, which also means that doing forge create Contract --verify would work, which doesnt rn, per the example below:
forge create Contract --verify

[⠊] Compiling...
No files changed, compilation skipped
Deployer: ...
Deployed to: ...
Transaction hash: ...
Starting contract verification...
Waiting for etherscan to detect contract deployment...
Error:
   0: Contract info must be provided in the format <path>:<name>

Location:
   cli/src/cmd/forge/verify.rs:91

Backtrace omitted. Run with RUST_BACKTRACE=1 environment variable to display it.
Run with RUST_BACKTRACE=full to include source snippets.

@gakonst will take a look, but should be possible. regarding, the conflict - resolved it locally, but having issues w/ integration tests. see ethers-rs#1259

@gakonst contract verification by name is gtg as long as there is a cache entry for it. so, the requirement is similar to how create detects contract path as well


Feature Request: Render Matrix support

It would be awesome if waapi transfer could detect selected regions in region matrix without clicking Add to render queue. Render time would be faster because no temp project would have to be created and using this JerContact_Open project based on file in clipboard.lua would also be possible. I don't know how hard implementing this feature would be, but this is definetely a game changer.

Yeah I had planned to do something similar when I had more time to work on the extension - I can appreciate how useful it would be. I will try and take another look when I have some more time and see what I can do.

That's great news. I can't wait for it to happen :) Good luck.


Update chromium_src directory for Chrome 49

This PR updates chromium_src in Electron - I split this into its own PR so that the other changes would have a sane chance at being reviewed
TODO:

[x] Write script to update chromium_src code against libchromiumcontent
[x] Move printing to under components

This is probably missing more (some Widevine changes come to mind) but we can fix that up in #4714

I'm :-1: on copying original source files to chromium_src, the problem is only very few files can be compiled without modifications, and for some classes like BrowserProcess and Profile, we are just providing a dummy class to satisfy a few files, if we copy the original files, it basically would mean we have to copy everything under chrome.
I'm more willing to take the hard way, by fixing the compilation errors in each file one by one. And I think it is probably the only way that would work.

I'm more willing to take the hard way, by fixing the compilation errors in each file one by one. And I think it is probably the only way that would work.

I'm into that though it seems like these files will just get further and further behind Chrome no?

Yeah, some files are getting already quite old, like the printing code. Updating them takes lots of time, so probably no one would look into that as long as they are still working.
Closing since other commits have been picked into chrome49 branch.


[BUG] Possible PII leak in logging for Submit Feedback

Describe the bug
Splunk shows the mixed logs for Submit Feedback event. In one case, it does not show email and user name but other cases, it contains the PII data. What is the latest feature you developed? The examples follows.

url: https://forms.illinois.edu/sec/4961936?email=&phone=&name=
url: https://forms.illinois.edu/sec/4961936?email=erinnrd2%40illinois.edu&phone=&name=Erinn Dady

To Reproduce
Steps to reproduce the behavior:

Go to 'Settings'
Click on 'Submit Feedback'
Click on 'Submit Form'

Expected behavior
Splunk logs shows no PII data
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

@yoonlees I believe this is since the beginning and how it was introduced as a button.
Unfortunately there is no sign of the original request.
Please consider with @pmarkhennessy and @johnmpaul  and let us know the next step

@mdryankov Can you remove the PII data from Splunk/Analytics

@pmarkhennessy @sandeep-ps  is there any reason the above Feedback web panel to be invoked with such GET parameters (e.g email, phone & name)?
Do we know the responsible person for the involved web form to put some light?

Hi @ToddNelson, I'm tagging you thinking you might have some information related to feedback forms. Could you please take a look at this when you get some time? We can also chat if you have any questions.

I have put a fix to take out the sensitive params out of Splunk. However if somebody confirm the params are useless we may remove them from the codebase.

Just providing information on the params, the reason they were included was so webtools forms could identify the user submitting the feedback (if needed). Those params are passed to the webtool form as we initially wanted to identify the user without having them provide contact information.
Again, just providing information, not direction on this. Checking with Isaac @isaac-galvan to see if identifying the author of feedback is still being used or necessary.

@pmarkhennessy The form has been updated so the user can submit their email address optionally with their feedback. The email, name, and phone can be removed from the GET params.

Fixed. All Url params are removed from the code.


welch_test()

Hi Brielin ,
Thank you for developing such cool method. I'm trying to use your WWER package, but encountered some problems.
In the README file, it seems like welch_test() used betas for both exposure and outcome from sample 1 (copied from README as below).
beta_exp_1, se_exp_1: exposure effects and SEs, sample 1.
beta_exp_2, se_exp_1: exposure effects and SEs, sample 2.
beta_out_1, se_out_1: outcome effects and SEs, sample 1.
beta_out_2, se_out_2: outcome effects and SEs, sample 2.
weights = WWER::welch_test(beta_exp_1, beta_out_1, se_exp_1, se_out_1)$t
But actually in the code (WWER.R) when you defined welch_test() function, it seems like the it use beta2 and beta1 that comes from both sample 1 and sample 2 (as below):
#' @param beta1 Float or vector of floats, mean of the first sample.
#' @param beta2 Float or vector of floats, mean of the second sample.
#' @param se1 Float or vector of floats, SD of estimate of mu1.
#' @param se2 Float or vector of floats, SD of estimate of mu2.
#' @param welch_thresh Float, p_value threshold for significance.
#' @export
welch_test <- function(beta2, beta1, se2, se1, welch_thresh = 0.05) {...
Do you mind clarifing what is the correct one to use?
Additionally, I was wondering if you could provide more documentation about the results from fit_tce(), like how to interpret the matrix? For example, if I got a R_tce matrix as below. Then the 0.04 is the R_tce from A->B or B->A?
A    B
A   1    0.04
B   -0.01  1
Thanks and look forward to your answer.
Best,
Zhe

Hi Zhe,
I am very sorry for the delay in responding to this. I saw it but was working on other things and forgot to get back to it later.
I agree this is confusing. In the doc for the welch_test() function, sample 1 and sample 2 refer to the pair of phenotypes (exposure and outcome) and not the split data. So they are both technically correct, just badly worded. I will make an update to fix this documentation in a minute.
For your second question, the rows are the exposure and columns are outcomes. So the 0.04 is A -> B. I will update the docs to reflect this as well.
Let me know if you have any other questions and I'll try to respond in a more timely manner next time.
Brielin

So looking at the code again, I realize I'm not using exposure and outcome there because the calculation is symmetric (at that step, there is no distinguishing which is the exposure or outcome). I've left the variable names as is and updated the documentation to note that these are phenotypes and not the split sample.


Error "Compiler reserves name 'require'" doesn't make sense for JS

    const someModule = require("google-closure-compiler");
    /**
     * @param {string} str
     * @return {number}
     */
    function require(str) { return str.length }
             ~~~~~~~
!!! error TS2441: Duplicate identifier 'require'. Compiler reserves name 'require' in top level scope of a module.
    export {someModule};

Actual: Error to do with emitting a module as commonjs
Expected: No error in a .js file, which shouldn't undergo transformation for emit.

Never mind, @weswigham reminded me that .js files definitely undergo module transformation, so this error is correct.


Master build is broken

As of subject. There seems to be an incompatibility with the latest zexe.

The culprit is plausibly this commit in zexe:
https://github.com/scipr-lab/zexe/commit/ecc6057971c1bb1595ca5c5537afc5e0561a38d5#diff-4cca21435ee820e184b16118ad656f07

(Ah, I have expected the Zexe refactoring to cause some trouble)
It seems that there are only a few errors. I will try to fix them and push a quick fix.

My local test seems to the running.
  Compiling marlin v0.1.0 (/Users/cusgadmin/scipr-lab/marlin)
    Finished dev [unoptimized + debuginfo] target(s) in 42.69s

It might have something to do with dependency mismatching.
If you try running cargo update and recompile, would the issue remain?

And, if you are working on a previous version of Marlin and do not want to move to the refactored framework (since refactoring could take a lot of efforts), you can base Zexe on the 0.1.0 tags (https://github.com/scipr-lab/zexe/tags) and use the Marlin at fe767bccaf10f98223b013885b51020a2bb380ce.

If you run cargo update, then things should compile; #32 should have fixed it.

It's true. Those solutions fix it. Thanks.


awcy: Migrate to CTC-V4

Weirdly CTCv4 have a new filename for Regular, and not for AS, but it is how it is.
Maybe we need to think of migrating this to a new environment variable to reduce the noise in the repo if the updates are too frequent.

Related rd_tool changes: https://github.com/xiph/rd_tool/pull/146


Fix custom type attribute on page element

If a type attribute was specified, the XML attribute was missing a
closing quotation mark.

This is obviously correct.


Consider how to run fal in a fresh environment

Right now, we use dbt's run_results.json artifact  to decide which models to run based on status.
A use case presented in the Discord channel is running in a fresh environment where there is no artifacts.
This happens by running each step in a different pod (Airflow):
PodOperator(dbt run -m model) >> \
  PodOperator(dbt test -m model) >> \
  PodOperator(fal run -m model -s script_name)

Notice the proposal has a -m that works like dbt's and -s for a specific script of the model.

Maybe we could start by handling -m and -s stays up for discussion.
The behaviour I would expect is, if I pass in --all or --model, it will ignore the run_results.json

if I pass in --all or --model, it will ignore the run_results.json

I agree with this..
and then this brings up a related question how do we error out when there is no run_results.json? we should probably update that message to include information about --all and --model

Agreed. Do we want to wait for more feedback or should we start adding --model?

We talked on a meeting about leveraging the dbt flagging system instead of implementing --model manually.

If I pass in --all or selection flags, it will ignore the run_results.json for deciding which models to run.
If run_results.json available, it will still load status information to pass to models; if it's not available, it still runs, but shows a warning.
If there is no run_results.json and I did not pass --all or selection flags, fail with exception about not having a way to decide which models to run.


Bootcfg: /ignition endpoint should support retries

If a profile lists an ignition_id that does not (yet) exist, /ignition endpoint should support returning a 202 HTTP response to the requester. This will indicate to the ignition instance that it's config is not yet ready, and that it should retry.
I propose also adding a boolean field to the Profiles object to configure this behavior:
"id" : "etcd"
"ignition_id" : "etcd.yaml",

"allowRetry" : true

allowRetry=false would indicate that a 404 should be returned if the ignition template file does not exist. allowRetry=true will result in a 202.
ref / depends on https://github.com/coreos/bugs/issues/1458
\cc @dghubble
PS - The spec says for HTTP status 202:

The entity returned with this response SHOULD include an indication of the request's current status and either a pointer to a status monitor or some estimate of when the user can expect the request to be fulfilled.

I think we can wait on this.

I'm not sure I understand the use case, so I'd like to know more. If a config template (be that a Fuze/Ignition template, Cloud-config template, or generic template) is referenced by a machine profile, but not present in the appropriate /var/lib/bootcfg/{cloud,ignition,generic} location, that's incomplete declarative data about what machines should do.
Example of referencing an non-existing template:
[44806.683946] bootcfg[5]: time="2016-07-12T17:08:38Z" level=info msg="No Ignition or Fuze template named: k8s-meister.yaml" group=node1 group_name="k8s controller" labels=map[mac:52:54:00:a1:9c:ae] profile=k8s-master

Ignition (agent) will already retry for a short time when it receives 404's, then drop to an emergency shell. So currently we could debug the missing template by looking at either bootcfg's logs or Ignition's journal logs.
You'd like Ignition to block/retry indefinitely if a 202 is received in the hopes the operator might add the file to avoid a reboot? But then bootcfg logs are the only way for an operator to spot the mis-configuration and I'm not sure how its much better than Ignition's current retry strategy?

@dghubble the goal is to be able to define a machine's bootcfg profile after that machine has already POST'ed and started the boot process. On many providers, choice pieces of metadata (private IP, mac address, disk uuid, etc) are not available until after the machine has started booting.
I want a way for bootcfg to tell ignition: "wait, your configuration is still coming" for amounts of time on the order of 10's of minutes to a handful of hours.
The general case is: There is a long running operation that needs to happen after the machine boots, but before (a portion of) it's ignition config is generated.
In addition, it would be nice to make this waiting state explicit vs a bootcfg misconfiguration. I feel:

404 ~=  I don't have this currently, and have no reason to expect I will .
202 ~=  I don't have this currently, but I expect to in the future.

On many providers, metadata (private IP, mac address, disk uuid, etc) are not available until after the machine has started booting

But Ignition supports various platform metadata services or you can write custom metadata services for the purposes of loading such information at Ignition runtime. https://coreos.com/ignition/docs/latest/metadata.html.
If you don't know a MAC address or another hardware label, there is not enough information to match a request anyway. You'd have to have a default matcher which makes all client machines retry indefinitely when templates are missing.

If you don't know a MAC address or another hardware label, there is not enough information to match a request anyway.

Mac address was bad example. Solid examples are:

Assign-on-create IP addresses
Randomly generated hostnames, DNS names, machine identifiers
External volume ids assigned on boot

I agree that, in the situation that the coreos-metadata service supports the data you want from your provider (which is definitely is not always true), this type of behavior is not necessary.
In addition, there is much-desired flexibility gained by being able to dynamically and arbitrarily generate ignition configs based on post-boot metadata, and not necessarily locking yourself in to coreos-metadata's simple substitution interface for supported variables.

I'm not particularly interested in adding this feature. Its mainly for the rare cloud provider that coreos-metadata doesn't yet support (e.g. Packet in this case). I'd rather we slowly add Ignition support for those providers/platforms and in the mean time, have the host introspect and populate a /run/metadata file which will be similar to what Ignition will do when the provider is supported.
If you really want this behavior, you could do it yourself when doing CoreOS installs. Have a default group (no selectors) with a profile with an Ignition config like install-reboot. Tweak the curl to a loop to keep retrying for a particular machine's Ignition config for as long as you like or as long as it normally takes you to manually go add a configuration.

@dghubble I'm going to go ahead and just close this out. I'm in agreement.


ClassNotFoundException for Playwright CLI

Please do not submit this issue.

[X] I understand

Hello,
Environment
Java 21
Quarkus Web App
Playwright 1.41.0
Problem
I have the following lines in my Dockerfile:
RUN mvn -B install -D skipTests
RUN mvn exec:java -e -D exec.mainClass=com.microsoft.playwright.CLI -D exec.args="install --with-deps firefox"
RUN mvn package -Dquarkus.package.type=uber-jar

I've been trying to follow official documentation to get tests to run as part of the build stage of my Dockerfile and have not had any success. I've referenced the following pages: CI Setup and Installation. This is the error I receive when trying to do a Docker Build:
#13 2.863 java.lang.ClassNotFoundException: com.microsoft.playwright.CLI
#13 2.864     at org.codehaus.mojo.exec.URLClassLoaderBuilder$ExecJavaClassLoader.loadClass (URLClassLoaderBuilder.java:181)
#13 2.864     at java.lang.ClassLoader.loadClass (ClassLoader.java:526)
#13 2.865     at org.codehaus.mojo.exec.ExecJavaMojo.doExec (ExecJavaMojo.java:371)
#13 2.865     at org.codehaus.mojo.exec.ExecJavaMojo.lambda$execute$0 (ExecJavaMojo.java:296)

I'm not behind a firewall or proxy so I do not think networking is the issue. The CI machine I'm using is hosted and as such, dependencies would need to be downloaded each time.
Question
Can someone point out a way to resolve this issue?


Operator overloading type inference Error

use std::ops::Add;

struct wrapper_f64{test: f64}
impl Add<usize> for wrapper_f64{
    type Output = Self;
    fn add(self , rhs : usize)-> wrapper_f64{
        wrapper_f64{test: self.test + rhs as f64}
    }
}
fn main(){
    let f64_in = wrapper_f64{test: 1.0};
    let usize_num : usize = 2;
    let res = f64_in + usize_num;

}

when I run those codes on
rustc: stable-x86_64-unknown-linux-gnu - rustc 1.49.0
OS: window wsl
RA is update-to-date
RA type inference like

And the real type of res should be wrapper_f64

The code, which does type inference in expressions has a explicit path for primitive types (probably for speedup), which handles this kind of inference wrong.
If you remove the explicit handling of primitive types, this specific example resolves the type correctly.
Even if we get rid of the explicit built-in type handling, there are cases where types are resolved incorrectly for operator overloads: https://github.com/rust-analyzer/rust-analyzer/issues/5685.
This is (I think) an issue with chalk.

The code, which does type inference in expressions has a explicit path for primitive types (probably for speedup), which handles this kind of inference wrong.
If you remove the explicit handling of primitive types, this specific example resolves the type correctly.
Even if we get rid of the explicit built-in type handling, there are cases where types are resolved incorrectly for operator overloads: https://github.com/rust-analyzer/rust-analyzer/issues/5685.
This is (I think) an issue with chalk.

I'd still like to keep the built-in handling, and rather fix it so it doesn't apply in those wrong cases.

I'd still like to keep the built-in handling, and rather fix it so it doesn't apply in those wrong cases.

I am encountering a similar issue called by an overloaded call method:
multicall.call().await?;

rust-analyzer finds this error even if the code compiles fine:

The defintion of the call function:
pub async fn call<D: Detokenize>(&self) -> Result<D, ContractError<M>> {
    ....
}

The catch is that the Multicall struct also implements Middleware:
async fn call(
    &self,
    tx: &TransactionRequest,
    block: Option<BlockNumber>,
) -> Result<Bytes, Self::Error> {
    ...
}

These types are from ethers-rs.

I am encountering a similar issue called by an overloaded call method:
multicall.call().await?;

rust-analyzer finds this error even if the code compiles fine:

The defintion of the call function:
pub async fn call<D: Detokenize>(&self) -> Result<D, ContractError<M>> {
    ....
}

The catch is that the Multicall struct also implements Middleware:
async fn call(
    &self,
    tx: &TransactionRequest,
    block: Option<BlockNumber>,
) -> Result<Bytes, Self::Error> {
    ...
}

These types are from ethers-rs.

That's not the same issue. Can you make a separate report please?

That's not the same issue. Can you make a separate report please?

Oh, sorry @flodiebold. Will do.

Oh, sorry @flodiebold. Will do.


Add country code 334 to HM

Refer to https://www.iso.org/obp/ui/#search
'Heard Island and McDonald Islands' get a country code of 334

@rposborne

@wongyouth I'm also having issues with my project because of the missing country code of Heard Island and McDonald Islands. Unfortunately, the code you added is not the correct one. 334 is referring to the assigned country number and it can be found here:
https://github.com/hexorx/countries/blob/master/lib/countries/data/countries/HM.yaml#L14
The country_code yaml key is actually referring to the ISD (International Subscriber Dialing) phone country code. I checked multiple countries and it seems that this is the case. For example, I live in Romania, and our code is 40 and this is what Romania has set as country_code here:
https://github.com/hexorx/countries/blob/master/lib/countries/data/countries/RO.yaml#L11
So in the case of Heard Island and McDonald Islands the ISD seems to be 672.
Here are a few sources I found online about this:
https://www.goldenchennai.com/isd-code/isd-code-for-heard-island-and-mcdonald-islands/
https://46elks.com/kb/country-codes
https://en.wikipedia.org/wiki/List_of_country_calling_codes  (The good old Wikipedia 😄 )
So do you think you could make this change?

Also for anyone stumbling upon this and looking for a quick fix.
This is what I did in my project (Rails):
# config/initializers/countries.rb

ISO3166::Data.register(
  ISO3166::Country.find_country_by_alpha2('HM').data.with_indifferent_access.merge(country_code: '672')
)

Thanks @siklodi-mariusz, you are right. I'm glad to change this.


can i use other roominfo json file?

The testroom_ovrscene_export.json file is different in format from the json file extracted by metasimulator DataRecord.apk.
Is there a way to convert or use this?

The format used in Phanto is different because we also wanted to include the scene mesh triangles and tracking space details.
It's a good idea to also support the XR Simulator's format. I will add that to our backlog, but no promises on a timeline for that feature. Thanks.

thank you for fast reply! @crien-xr
can i have way to details record json file data used in phanto ?

Hello.
For recording scene information, please refer to the documentation provided here: https://developer.oculus.com/documentation/unity/xrsim-scene-recorder/
Overall, XR Simulator is a highly recommended tool for working with scene information, and Phanto should be aligned with the exported format


Flesh out README

Explain how to contribute to the track, and some of the gotchas
and workarounds that are necessary.
Extracted from #6 by @catb0t

This should be closed, as I should rewrite much of that to reflect reality. Then I'll create a pull, and it will not be such a broad pull as before.

That sounds good!


Create individual pages for the 6 topics

I'll spread this out with individual page in one issue so everyone gets a chance to contribute.

Before working on it. Lets discuss on how we plan to make it.
As we want to keep the info short and crisp.
It can be something like pinterest cards with twitter handle of (senior) develop
Each card having an advise related to that specific topic.

Scanned Documents.pdf

Any ideas or suggestions drop down below 👇

Hey Asad, you need individual page for each of them and with a little info about them on their page..right?

No just see the design above. It's card based twitter screenshots advise from senior devs

@Mubashir-Md You can also checkout my DSAwithKunal repo, it covers hacktoberfest contributions aswell.

No just see the design above. It's card based twitter screenshots advise from senior devs

Here senior devs means those people who are relevant in the industry, right?

Yeah. Experienced developers sharing their productivity advise or tip.

I can work on it.

Please comment in respective issues so I can assign you. Thanks

Hello @asdsyd 🙋♂
If you can provide the photos, I can help you work on the pages.
I'll be using JavaScript, HTML and CSS, the cards for each topic will appear onclick.
I hope it's not too late to hacktoberfest this issue.
Thank you!

You mean the content screenshots? Okay. Please comment in which page u want to work I'll assign you there. Thanks.


docs: add a information of Seoungil Kang to team-B-description.md

Description
add a information of Seoungil Kang to team-B-description.md
Context
First week homework submission.
Checklist:

[x] Updated tests for this change.
[x] Tested the changes locally.
[x] Updated documentation.

Screenshots (if available)

N/A
Link to story (if available)

N/A

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Feature]: Grey out textarea when not editable

I'm submitting a

[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report
[ ] Enhancement
[X] Feature request
[ ] Documentation issue or request

Description
I would like the textarea to be grayed out when editable is set to false. I'm finding this difficult to accomplish, do you have any suggestions?
Version Information
ngx-editor: 3.3.0-rc.13
angular: 5.2.0

Browser

[x] Chrome - x.x.x
[x]  Mozilla Firefox - x.x.x
[x] Opera - x.x.x
[x] Microsoft Edge - x.x.x

Hi, That is a valid point. I will update it. until then you can use the attributes to set css when contenteditable is set to false.

Hi, I am sorry I didn't see ur comment. You can look for contenteditable attribute. which will be true or false based on the behaviour.

Should be doable via css attribute selector.


[CI] ImportError: cannot import name 'ThreadLocalMetaData' from 'sqlalchemy.schema' (/usr/local/lib/python3.8/dist-packages/sqlalchemy/schema.py)

For the record, the import error mentioned in #477 is sill sometimes appearing (see https://github.com/fractal-analytics-platform/fractal-server/actions/runs/4024017688/jobs/6915556627), and it looks like
STDERR:
Content of /tmp/pytest-of-runner/pytest-0/test_failing_workflow_JobExecu0/artifacts-test_failing_workflow_JobExecutionError/workflow_000001_job_000001/0.slurm.9.err:
Traceback (most recent call last):
  File "/usr/lib/python3.8/runpy.py", line 185, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/usr/lib/python3.8/runpy.py", line 111, in _get_module_details
    __import__(pkg_name)
  File "/usr/local/lib/python3.8/dist-packages/fractal_server/app/runner/__init__.py", line 29, in <module>
    from ..models import ApplyWorkflow
  File "/usr/local/lib/python3.8/dist-packages/fractal_server/app/models/__init__.py", line 4, in <module>
    from ...common.schemas import *  # noqa F401
  File "/usr/local/lib/python3.8/dist-packages/fractal_server/common/schemas/__init__.py", line 5, in <module>
    from sqlmodel import SQLModel
  File "/usr/local/lib/python3.8/dist-packages/sqlmodel/__init__.py", line 24, in <module>
    from sqlalchemy.schema import ThreadLocalMetaData as ThreadLocalMetaData
ImportError: cannot import name 'ThreadLocalMetaData' from 'sqlalchemy.schema' (/usr/local/lib/python3.8/dist-packages/sqlalchemy/schema.py)

First guess: there is a python-path mismatch somewhere.
Note that paths like /usr/local/lib/python3.8/dist-packages/sqlalchemy/schema.py are the ones on the slurm container, while the python interpreter running pytest is sitting somewhere else (in a poetry-generated venv) and it's not even necessarily 3.8.

For the record, trying to run everything by hand from within the container doesn't raise the same error:
$ docker ps
CONTAINER ID   IMAGE                                     COMMAND                  CREATED         STATUS         PORTS                                                                                NAMES
f09c260bc78d   slurm_docker_images_slurmnode1            "/etc/slurm-llnl/doc…"   9 minutes ago   Up 9 minutes   6817-6819/tcp                                                                        slurm_docker_images_slurmnode1_1
c7a065d75303   slurm_docker_images_slurm-docker-master   "/etc/slurm-llnl/doc…"   9 minutes ago   Up 9 minutes   3306/tcp, 50097/tcp, <IP_ADDRESS>:6817-6819->6817-6819/tcp, :::6817-6819->6817-6819/tcp   slurm_docker_images_slurm-docker-master_1

$ docker exec -it f09c260bc78d bash

admin@slurmnode1:/$ cd

admin@slurmnode1:~$ /usr/bin/python3.8
Python 3.8.5 (default, Jul 28 2020, 12:59:40)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

>>> import cloudpickle
>>> def fun(): return 42
...
>>> funcser = cloudpickle.dumps((fun, [], {}))
>>> with open("x.in.pickle", "wb") as f:
...     f.write(funcser)
...
428
>>>
admin@slurmnode1:~$ /usr/bin/python3.8 /usr/lib/python3.8/runpy.py fractal_server.app.runner._slurm.remote x.in.pickle
admin@slurmnode1:~$ ls
x.in.pickle  x.out.pickle

admin@slurmnode1:~$ /usr/bin/python3.8
Python 3.8.5 (default, Jul 28 2020, 12:59:40)
[GCC 9.3.0] on linux
Type "help", "copyright", "credits" or "license" for more information.

>>> import cloudpickle
>>> with open("x.out.pickle", "rb") as f: data = f.read()
...
>>> data
b'\x80\x05\x95\x06\x00\x00\x00\x00\x00\x00\x00\x88K*\x86\x94.'
>>> cloudpickle.loads(data)
(True, 42)

Also for the record, /usr/local/lib/python3.8/dist-packages/sqlalchemy/schema.py includes the correct line from .sql.schema import ThreadLocalMetaData  # noqa.

Last two comments were verified on the slurm node. What about the slurm master node?
$ docker ps
CONTAINER ID   IMAGE                                     COMMAND                  CREATED          STATUS          PORTS                                                                                NAMES
f09c260bc78d   slurm_docker_images_slurmnode1            "/etc/slurm-llnl/doc…"   15 minutes ago   Up 15 minutes   6817-6819/tcp                                                                        slurm_docker_images_slurmnode1_1
c7a065d75303   slurm_docker_images_slurm-docker-master   "/etc/slurm-llnl/doc…"   15 minutes ago   Up 15 minutes   3306/tcp, 50097/tcp, <IP_ADDRESS>:6817-6819->6817-6819/tcp, :::6817-6819->6817-6819/tcp   slurm_docker_images_slurm-docker-master_1

$ docker exec -it c7a065d75303 bash

admin@slurm-docker-master:~$ ls /usr/local/lib/python3.8/dist-packages/
__pycache__  asttokens  asttokens-2.2.1.dist-info  devtools  devtools-0.10.0.dist-info  executing  executing-1.2.0.dist-info  mpi4py  mpi4py-3.0.3.dist-info  six-1.16.0.dist-info  six.py

Question: do we need fractal-server installed on the docker-slurm login node?

Ref: abe4309bcc21d4da392fbcf412ce1a27b6e4c3e2

Quoting from #480:

We found a major issue in the CI (thanks @ychiucco!), i.e. fractal-server install in docker container was pulling the fresh sqlalchemy 2.0 version (released yesterday), which introduces major changes and is not (yet) supported by our dependencies.
This is currently addressed by pinning to >=1.4,<2, and we should also come back to this later if a PR like https://github.com/fastapi-users/fastapi-users-db-sqlmodel/pull/13 is merged (I think this is the dependency which is currently holding us back at 1.4.35), to make sure that we would fetch more recent 1.4 versions if possible.
Meanwhile, another small issue (cfut_finished_jobs fixture missing in some tests, and its actual code being slightly different from the cfut=0.5 final version) surfaced, and is fixed here.

Closing this issue, let's open more specific ones if needed.


Issue397

@objectiser @pavolloffay Please review

@kevinearls On the linked issue #397 it says the production_test, elasticsearch_test and es_index_cleaner_test all fail with that issue - however this PR only skips the index cleaner - does this imply the failures in those other tests were because of the index cleaner? In #397, did the index cleaner test run first potentially having a side effect on the others?

@objectiser Good question.  It's possible it was a side effect.  Since I've refactored the tests into one file if the es_index_cleaner_test fails the other two don't get run.  However, if I skip it the other two pass.

So with the new testify approach the first test failure in a file causes the rest to be skipped? Is there a way to override this when running in ci?

@objectiser Unfortunately yes, although I don't think this behavior is different from standard Go testing.  In fact, this is not what I expected to see here.  In CI I want all of the tests to run, and this is the behavior I got from Testify when I first tried it with a standalone project.
This may be occurring because we're using the test package from the operator-sdk.  I will continue to investigate and find a way to resolve this.


Compile error when trying to add values to array.

Version: EAP 2021.2.26215
Console:

Procedure:

https://github.com/Goldorion/Array-Lists-MCreator/issues/4


Manage bot information

Required Information

Operating system: Windows 8.1 Pro
PHP version: 7.3.6
PHP Telegram Bot version: 0.57.0
Using MySQL database: yes
MySQL version: 5.6.43
Update Method: Webhook
Self-signed certificate: yes

I have a token of bot created by another person and I want to manage this bot's info, for example, change profile picture, set new description, about and so on. Are there any possibilities to do that?
Thank you!

As far as I know, only the user that created the bot can change those things via BotFather.
To pass ownership of a bot, the other person would have to delete the bot and let you then register it with your account.
@jacklul @chuv1 Do you know if it's possible to just "pass over" ownership?

Nope, never heard about that. There is no way to pass it.
On Sat, Jun 8, 2019, 11:10 Armando Lüscher<EMAIL_ADDRESS>wrote:

As far as I know, only the user that created the bot can change those
things via BotFather.
To pass ownership of a bot, the other person would have to delete the bot
and let you then register it with your account.
@jacklul https://github.com/jacklul @chuv1 https://github.com/chuv1
Do you know if it's possible to just "pass over" ownership?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/php-telegram-bot/core/issues/965?email_source=notifications&email_token=ADEE5RVSWQSX5VAW5EAFHXTPZNSQZA5CNFSM4HWDJB72YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXHQFAA#issuecomment-500105856,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADEE5RXRVEUIB2KDZWE7CT3PZNSQZANCNFSM4HWDJB7Q
.

The only way to "pass" a bot ownership to somebody else is to delete it so that the second person can take it's username.
BotSupport will respond with that.


feat: add SequentialTableTransformer

Closes #802
Summary of Changes
Added SequentialTableTransformer class in transformers to transform tables sequentially using multiple transformers.
Added TransformerNotInvertibleError, which gets raised when attempting to inverse transform a table using a non-invertible transformer.
Modified test helper assert_tables_equal to include more optional parameters.

@RobinSen28 Please fix the merge conflicts, I'll review the PR once the automated checks pass afterwards.

:tada: This PR is included in version 0.27.0 :tada:
The release is available on:

v0.27.0
GitHub release

Your semantic-release bot :package::rocket:


Feature Request: Certain TV Shows Only

I took a look and couldn't find a way to do this so figured I'd make a feature request.  There are a few shows that I watch with someone else that I'd like to sync watched status between our accounts but only those particular shows.  Looks like 'title' is already a database property or maybe do it via one of the parent guids.  Could be a per library property that takes a list of titles or guids as an import/export filter, something like that.
Looks like I could move them into a separate library on each but that's a lot of overhead and the shows are otherwise not different so that doesn't make much sense.
Thanks for a great tool!

Hi,
Thank you for your suggestion, unfortunately as you suspected this tool does not support this use case, However you could do it via blacklisting libraries and use one shared library between your targets that contains said tv shows this is the only workable solution at this time. And this tool does not really care about shows titles as they can be different between libraries we work on GUIDs and virtual GUIDs for episodes. i.e. tvdb://id/(season)/(id).
I don't have any good ideas on how to approach this at the moment. we may add global whitelist on import or something. i'll have to think about it


Add filter event for search fields in the backend customer list

1. Why is this change necessary?
This change makes it easier to extend the search for customer in the customer list. E.g. custom attributes that are selected anyways. Without this event there is no real access because the fields are hardcoded.
2. What does this change do, exactly?
Adds a filter event to edit the fields being searched in the customer list.
3. Describe each step to reproduce the issue or behaviour.
Subscribe to the new event and add something like this:
$searchfields = $args->getReturn();
$searchfields[] = 'attribute.fooBar^2';
return $searchfields;

4. Please link to the relevant issues (if any).

5. Which documentation changes (if any) need to be made because of this PR?

6. Checklist

[ ] I have written tests and verified that they fail without my change
[x] I have squashed any insignificant commits
[x] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hi @t2oh4e, your PR was merged in a2f54b296cd80ad130f12ea92aa9a96f45b8f538, thank you for your contribution! 💙
We're sorry it took us so long.


Python : unclosed transport

Describe the bug
https://github.com/microsoft/semantic-kernel/blob/main/python/README.md#running-a-prompt
Save this part of python into a example.py and run with python3 -Wd example.py.
Then, there is socket unclosed warning
Example output:
Robots must not harm humans.
sys:1: ResourceWarning: unclosed <socket.socket fd=1064, family=2, type=1, proto=6, laddr=('<IP_ADDRESS>', 56744), raddr=('<IP_ADDRESS>', 443)>
ResourceWarning: Enable tracemalloc to get the object allocation traceback
C:\Program Files\WindowsApps\PythonSoftwareFoundation.Python.3.11_3.11.1008.0_x64__qbz5n2kfra8p0\Lib\asyncio\proactor_events.py:116: ResourceWarning: unclosed transport <_ProactorSocketTransport fd=-1 read=<_OverlappedFuture cancelled>>
_warn(f"unclosed transport {self!r}", ResourceWarning, source=self)
ResourceWarning: Enable tracemalloc to get the object allocation traceback

@poweihuang0817 , thanks for bringing this up.  We are looking into it.

@poweihuang0817 note that this is a benign error, but still good to resolve.
I believe that this error has been fixed with recent changes to code backing inline functions. I traced the data leak to inline_function.py which has been removed via https://github.com/microsoft/semantic-kernel/pull/1015. I was able to reproduce using semantic-kernel==0.2.8dev0, but unable to reproduce with the code currently checked into main.
We will be releasing a new version containing the fix next week. Until then, it should not affect your ability to use the kernel :)
@evchaki @dluc for visibility.

Closed by #1015 and released in the latest pip package


Ep refactor

This pull request includes:

numerical integration method for computing the gradients of the marginal likelihood with respect to the likelihood hyper-parameters. (Numerical integration is possible with gaussian hermite quadrature and gaussian kronrod integration)
Robustification of binomial likelihood: link function values very close to 0 or 1 used to cause problems due to logarithm.
Some small bugfixes

Codecov Report

Merging #534 into EP_refactor will increase coverage by 0.25%.
The diff coverage is 84.17%.

@@               Coverage Diff               @@
##           EP_refactor     #534      +/-   ##
===============================================
+ Coverage        50.22%   50.47%   +0.25%
===============================================
  Files              189      190       +1
  Lines            18458    18584     +126
  Branches          2563     2571       +8
===============================================
+ Hits              9271     9381     +110
- Misses            8761     8775      +14
- Partials           426      428       +2

Sorry for the mess this pull request created, I did a merge with "devel" branch of GPy, but I am not sure, should I have done a rebase so that our commits would have come on top .. and then made the pull request ...


Missing check on oidc issuerURL

Hi,
today i was installing a new MM server using dev branch using docker image.
MM didn't start when OIDC config was enabled. Logs didn't report any error.
I found the issue. It was a typo in the issuerURL.
I think that a check on that URL is needed to be logged in case of error.

Thanks for the report. I need to work on it..


Exercise: Providing circular dependencies between A and B AMD-like modules

Closed #513

Try to make workaround for circular deps for AMD modules as for CommonJS modules


show only date

how to make a script to show only the choice of dates, without timing?

https://github.com/smalot/bootstrap-datetimepicker/issues/416


Which migrations will up and down commands run?

I use Flyway right now. Whether part of Flyway or just the way we use it, each migration file starts with a number and only the highest number will be run.  If we both grab the same number the first to submit will win!
In migrondi, which migration file(s) will the up and down commands run? Any that haven’t been run previously? Where is that info stored? The newest one based on its file name? Does the caller specify?

Hi there 😁,
When you create a new migration, the file always ends in <yourname>_timestamp.sql that's used to sort the migration order
when you run up migrondi will try to reach for the database's migrations collection and find which was the last migration ran, then from there on it will try to find the same timestamp in the disk and continue with whatever migrations were created after that, if you use the option -t <number> it will try to run that amount of migrations the same happens on down
the up/down migrations is basically a for loop and each statement inside the migration file gets wrapped inside a transaction operation, if the operation everything is committed to the database except for the last transaction attempt which is the one that failed
just to be precise I'll quote your questions

which migration file(s) will the up and down commands run? Any that haven’t been run previously?

yes

Where is that info stored?

Migrondi creates a table named migration in the selected database with the following columns
id INT PRIMARY KEY,
name VARCHAR(255) NOT NULL,
timestamp BIGINT NOT NULL

The newest one based on its file name?

the timestamp on its name is the determining factor

Does the caller specify?

currently, there's no way to do that
since your migration files are just SQL, I'd advise to check them in the repository where the software is being worked on, for large teams I think there could be a couple of things like two persons working on the same table, for example, the lower timestamp would be run first then the other if they happen to be the same timestamp somehow... it would depend on the .NET's sorting to determine which will be run first  (like sorting an array with two number 1's), but overall there's no way (currently) to specify any kind of priority besides the timestamp if these were conflicting migrations one of them would fail for sure.
And I think that's mostly it, let me know if you have further doubts 😁

Just for reference, I'll add the output of the almost done dry-run option
[😏]~>  dotnet run -p src/Migrondi -- up --dry-run true
[MIGRATION: SampleMigration] - [PARAMS: seq [[Name, SampleMigration]; [Timestamp,<PHONE_NUMBER>101]]]
BEGIN TRANSACTION;-- ---------- MIGRONDI:UP:1609005399101 --------------
-- Write your Up migrations here

INSERT INTO migration(name, timestamp) VALUES(@Name, @Timestamp);
END TRANSACTION;
[MIGRATION: SecondMigration] - [PARAMS: seq [[Name, SecondMigration]; [Timestamp,<PHONE_NUMBER>280]]]
BEGIN TRANSACTION;-- ---------- MIGRONDI:UP:1609005759280 --------------
-- Write your Up migrations here

INSERT INTO migration(name, timestamp) VALUES(@Name, @Timestamp);
END TRANSACTION;
Total Migrations To Run: 2
[😏]~>  dotnet run -p src/Migrondi -- down --dry-run true
Total Migrations To Run: 0
[😏]~>  dotnet run -p src/Migrondi -- up --dry-run false
Migrations Applied: 2
[😏]~>  dotnet run -p src/Migrondi -- down --dry-run true
[MIGRATION: SecondMigration] - [PARAMS: seq [[Timestamp,<PHONE_NUMBER>280]]]
BEGIN TRANSACTION;
-- Write how to revert the migration here

DELETE FROM migration WHERE timestamp = @Timestamp;
END TRANSACTION;
[MIGRATION: SampleMigration] - [PARAMS: seq [[Timestamp,<PHONE_NUMBER>101]]]
BEGIN TRANSACTION;
-- Write how to revert the migration here

DELETE FROM migration WHERE timestamp = @Timestamp;
END TRANSACTION;
Total Migrations To Run: 2
[😏]~>

This sounds perfect. I’ll have to try it out. We run our migrations as part of CI. Since you do everything in a transaction that should take care of any race potential conditions.

This is kind of a dumb question. What other tools inspired migrondi? What does migrondi do better? Worse? Differently? I like the simplicity and that the implementation is in F#.

Don't worry, there are no dumb questions here (except mine perhaps 😁)

What other tools inspired migrondi?

This was at the beginning just an exercise to learn more F# or at least to solidify what I already knew
but as I was working on it I felt it was worth making it usable for someone else not just my simple exercise, the last migration tool I used was db-migrate which is a nodejs tool.

What does migrondi do better? Worse? Differently?

What MIgrondi aims for is to be something useful yet super simple without any dependency on runtimes or any particular thing installed on your machine
basically, I wanted the following

download a binary that runs everywhere, no extra installs
create a migration
run the migration
done

the least configuration possible as well, that's why the config file is short as well
as long as it's simple and easy to do stuff I think it's okay to build more stuff on top of that

I'll close this, feel free to re-open if needed 😁

Can you explain what down means? Do I have to write both up and down migrations myself, or does it figure out down logic from up logic?

@xperiandri if your migrations have SQL in the "down" portion of the SQL script then those will be run.
The logic for down is somewhat like this:

Fetch the migrations from the database
Compare locally and find the ones that have been applied and cut at the last applied, discard the rest (which should be local)
Order the migration list by descending timestamp and run the "down" portion of the SQL scripts

e.g.

AddStudentsTable

up: create students table
down: drop table students

AddClassroomColumnForstudents

up: alter table students add column classroom
down: alter table students drop column classroom

Running Up in an "empty" database would create the students table, then update and add the classroom column.
if both migrations are applied, then down would drop the classroom table first then drop the students table in that order
if only one the first migration was applied, down would drop the students table as  the "alter" migration would have been pending (not applied in the database) at that point.


python311Packages.limnoria: 2023.11.18 -> 2024.4.26

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for python311Packages.limnoria is: A modified version of Supybot, an IRC bot
meta.homepage for python311Packages.limnoria is: https://github.com/ProgVal/Limnoria
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2024.4.26 with grep in /nix/store/ldw88ri601zi4a1hl53mk7vhp7v3h0z7-python3.11-limnoria-2024.4.26
found 2024.4.26 in filename of file in /nix/store/ldw88ri601zi4a1hl53mk7vhp7v3h0z7-python3.11-limnoria-2024.4.26

Rebuild report (if merged into master) (click to expand)

3 total rebuild path(s)

3 package rebuild(s)

First fifty rebuilds by attrpath

python311Packages.limnoria
python312Packages.limnoria

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/ldw88ri601zi4a1hl53mk7vhp7v3h0z7-python3.11-limnoria-2024.4.26 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A python311Packages.limnoria https://github.com/r-ryantm/nixpkgs/archive/3195ca59c8c7541dc39b4b1f72f74620c2dd0333.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/3195ca59c8c7541dc39b4b1f72f74620c2dd0333#python311Packages.limnoria

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/ldw88ri601zi4a1hl53mk7vhp7v3h0z7-python3.11-limnoria-2024.4.26
ls -la /nix/store/ldw88ri601zi4a1hl53mk7vhp7v3h0z7-python3.11-limnoria-2024.4.26/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review --extra-nixpkgs-config '{ allowInsecurePredicate = x: true; }' run on x86_64-linux 1

4 packages built:

python311Packages.limnoria
python311Packages.limnoria.dist
python312Packages.limnoria
python312Packages.limnoria.dist

Maintainer pings
cc @cillianderoiste for testing.

Result of nixpkgs-review pr 311117 run on x86_64-linux 1

4 packages built:

python311Packages.limnoria
python311Packages.limnoria.dist
python312Packages.limnoria
python312Packages.limnoria.dist


Add tab focus

Adds ability to move focus using tab (forward) and shift + tab (backwards). Also adds action modifiers for FocusIn and FocusOut events.

lgtm!


consider renaming module to something descriptive

We should consider renaming the module to something descriptive, like offline-gh-pages, per these best practices for naming Node modules.
On the other hand, command-line utilities benefit from being short and sweet, and Oghliner exposes a command-line interface, in addition to its module interface. So perhaps it makes sense to keep the existing, compact name.

my first three suggestions:

sw-publish, to emphasize publishing and service workers
gh-publish, to emphasize github and publishing
ghp, to emphasize github and publishing

The word "publish" is attractive and accurate. I originally used it when starting development of the project. But I changed to "deploy" because it appears to be the more conventional term, especially when describing the process for web apps ("publish" may be a bit more common for web sites).
To wit: Travis CI's motto is "Test and deploy your code with confidence." And they feature "deployment" to a variety of hosting providers, including GitHub Releases (although not GitHub Pages, which is why this project's configure feature is useful).

Oghliner avoids describing Service Workers in its documentation because it intends to make them an implementation detail. Although I don't expect it'll support AppCache (like Surge does) or another offlining API, it still shouldn't be necessary to know what a Service Worker is in order to offline your app and deploy it to GitHub Pages. So I'm loathe to change the name to something that references service workers.

sw-publish, to emphasize publishing and service workers
gh-publish, to emphasize github and publishing
ghp, to emphasize github and publishing

These names have a strong "publish" bias, and they suggest that this project's value proposition is to deploy to GitHub Pages.
It's true that this project is carefully scoped, and that Node modules often follow the Unix philosophy, per https://github.com/mattdesl/module-best-practices#module-basics, to be "small programs that do one thing, do it well, and compose easily with other programs."
Nevertheless, this project's value proposition is actually that certain developers would benefit from a tool that composes a set of those "small programs" in a particular way to address a specific use case: deploying offline web apps to GitHub Pages.
If a developer only wants to offline their app, then this project is not the right tool, since such a developer would be better served by a module like sw-precache that helps them accomplish that specific task (with configuration options for deployment targets other than GitHub Pages).
Conversely, if a developer only wants to deploy their app to GitHub Pages, then this project is similarly overkill, as they can integrate a module like gh-pages into their workflow for that purpose (although it's true that such a developer would still benefit from using this project to configure Travis auto-deploy).
So "offlining" is just as essential a feature as "deployment" to the project, and it would be misleading to emphasize only the latter in its name.

I like oghliner because it is a pun between off and GitHub. Isn't it? So it emphasizes the two core concepts of the project, deploying in GitHub and offline application.
I think it's me who must change the name of offliner to something emphasizing the life cycle for an application concept, let's say, cyclapp (I like the idea of a circle depicting the lufe cycle) and thus, oghliner will be using cyclapp to  fulfil its purpose. So, if you agree, let's rename offliner instead.

I like oghliner because it is a pun between off and GitHub. Isn't it? So it emphasizes the two core concepts of the project, deploying in GitHub and offlining an application.

Yes, it's that pun! Which I figured was clever. But clever names are not always a great idea. When I was involved in naming projects for Mozilla Labs, clever names generally seemed like a good idea at the beginning of a project's lifecycle, because they were catchy and clever, but a bad idea further down the road, because they required an act of memorization to remember. Over time, I grew to appreciate descriptive project names, which both name and summarize the project.
These module best practices suggest naming conventions that "generally favour clear and 'boring' names." I suspect the author is suggesting descriptive names.

I think it's me who must change the name of offliner to something emphasizing the life cycle for an application concept, let's say, cyclapp (I like the idea of an eye —a circle— depicting the life cycle) and thus, oghliner will be using cyclapp to fulfil its purpose. So, if you agree, let's rename offliner instead.

It may indeed be worthwhile to change the name of offliner, but note that this issue is not about distinguishing between this project and offliner, it's about choosing the best name for this project! Even if you rename offliner, it might still make sense to rename this project, giving it a descriptive name.

You're right, thinking about.

npm-check-updates provides the ncu command-line tool, which leads me to consider renaming this to offline-github-pages and providing an oghp command-line tool.

Also of note: despite the advice in that "best practices" document, popular npm packages aren't all descriptively named. Many are, like change-case, github-slug, read-yaml, and travis-encrypt; but there are plenty of others with figurative/idiomatic names, like chalk, gulp, mocha, and nock.

After thinking about it for a while, and implementing it in #184, I've decided that we shouldn't rename the project after all, because it's better to keep the names of the npm package and CLI tool the same; it's easier to talk about a project with a single word name; and the downsides of a figurative name aren't significant enough to override those benefits.


very slow download (compared to ytd)

Annie: 60-70  KiB/s
ytd: 5.8Mib/s
not sure why?
For example
➜  Downloads annie -f 250 https://www.youtube.com/watch?v=-7jjo8UICjQ
Site:      YouTube youtube.com
Title:     Most Iconic Classical Music Masterpieces Everyone Knows in One Single Video
Type:      video
Stream:
[250]  -------------------
Quality:         audio/webm; codecs="opus"
Size:            107.85 MiB (113084341 Bytes)
# download with: annie -f 250 "URL"
2.56 MiB / 107.85 MiB [>-------------------------------------]   2.38% 68.46 KiB/s 25m10
One min later using ytd
➜  inbox ytd --audio-format opus https://www.youtube.com/watch?v=-7jjo8UICjQ
[youtube] -7jjo8UICjQ: Downloading webpage
[youtube] -7jjo8UICjQ: Downloading video info webpage
[download] Destination: Most Iconic Classical Music Masterpieces Everyone Knows in One Single Video--7jjo8UICjQ.f136.mp4
[download] 100% of 252.52MiB in 00:43
[download] Destination: Most Iconic Classical Music Masterpieces Everyone Knows in One Single Video--7jjo8UICjQ.f140.m4a
[download] 100% of 195.61MiB in 00:27
[ffmpeg] Merging formats into "Most Iconic Classical Music Masterpieces Everyone Knows in One Single Video--7jjo8UICjQ.mp4"
Deleting original file Most Iconic Classical Music Masterpieces Everyone Knows in One Single Video--7jjo8UICjQ.f136.mp4 (pass -k to keep)
Deleting original file Most Iconic Classical Music Masterpieces Everyone Knows in One Single Video--7jjo8UICjQ.f140.m4a (pass -k to keep)

Yeah, downloading audio is really slow, I am not sure why. Did I miss some key params?

It seems the reason is YouTube throttling DASH streams, and ratebypass seems doesn't work anymore. See https://github.com/rg3/youtube-dl/issues/15271#issuecomment-362834889
And we have to limit the chunk size to less than 10M


Cannot import httpexpect

When getting the package, I get the following error :
$ go get gopkg.in/gavv/httpexpect.v1
# gopkg.in/gavv/httpexpect.v1
../../../gopkg.in/gavv/httpexpect.v1/reporter.go:39: r.backend.FailNow undefined (type *require.Assertions has no field or method FailNow)

I'm using Go v1.7.3 on linux/amd64.

I erased all traces of it in my local packages and then reinstalled, it worked. Strange...

I guess you had an outdated version of testify.


[skip ci]add uniform sources list for docker images

Background
The root base image of rackhd on-xxx docker images is nodesource/wheezy
However, the source list of this base image can not satisfy our needs.
This sources list was used to be added in jenkins docker build steps.
As well as in https://github.com/RackHD/on-taskgraph/blob/master/Dockerfile for fixing some issue.
Details
now we decide to add sources list in on-core(the root image of all on-xxx) for  unification.
Both https://github.com/RackHD/on-build-config/pull/80 and https://github.com/RackHD/on-taskgraph/pull/211 will remove the sources list add steps.
@panpan0000

Please add https://rackhd.atlassian.net/browse/RAC-4215 into PR desc.
so that people can trace the history


config: undeprecated metadata from cargo manifest

This undeprecates the source of configuration from cargo manifest
metadata section. It also massages the code-flow to avoid deeply nested
conditionals.
Ref: https://github.com/sunng87/cargo-release/pull/54#issuecomment-413849959

Thanks! I will create a release soon

@sunng87 great, thank you! Let me know once it is published on crates.io.

0.10.4 is pushed.
On 8/17/18 9:55 PM, Luca Bruno wrote:

@sunng87 https://github.com/sunng87 great, thank you! Let me know once
it is published on crates.io.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sunng87/cargo-release/pull/71#issuecomment-413873881,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AANi9qqzZo97ZGxta83sEXVyN-9MvtKMks5uRstngaJpZM4WBhRm.


ubuntu: move from apt-key command to gpg

As part of the apt-key deprecation [0], we need to use gpg to consume the
repo key and change the repo file (scylla.list) to explicitly point
to the key,
This is a chick-and-egg change because the repo file should be changed
on pkg repo and once it changed, the gpg command (added on this commit)
is required,
For this reason, we'll start with adding the gpg and later we'll remove the apt-key refs
In this change I also add the sS flag to the curl command to make it silent but print errors if there are such,
In addition, I removed the --allow-insecure-repositories which AFAIK is not require so better to avoid such a flag
Ref https://github.com/scylladb/scylladb/issues/11186
[0] https://wiki.debian.org/DebianRepository/UseThirdParty

Verified by https://jenkins.scylladb.com/view/master/job/scylla-master/job/releng-testing/job/next-machine-image/396
both apt-key and gpg in used by build_deb_ami.sh
09:31:26  + bash -c 'set -o pipefail; /jenkins/workspace/scylla-master/releng-testing/next-machine-image/scylla-pkg/tools/packaging/dpackager -e AWS_SECRET_ACCESS_KEY=$AWS_SECRET_ACCESS_KEY -e AWS_ACCESS_KEY_ID=$AWS_ACCESS_KEY_ID -- ./build_deb_ami.sh --product scylla --repo downloads.scylladb.com/testing/unstable/scylla/master/deb/unified/2022-08-09T15:55:28Z/scylladb-master/scylla.list --log-file ami_x86_64.log --debug   --build-id 396 --operating-system ubuntu:20.04 --build-tag jenkins-scylla-master-releng-testing-next-machine-image-396 --branch null --scylla-build-sha-id null '
09:31:26  5.2.0-dev-20220810.6f859856f98
09:31:26  --product parameter: PRODUCT |scylla|
09:31:26  --repo parameter: REPO_FOR_INSTALL downloads.scylladb.com/testing/unstable/scylla/master/deb/unified/2022-08-09T15:55:28Z/scylladb-master/scylla.list
09:31:26  --log-file parameter: PACKER_LOG_PATH |ami_x86_64.log|
09:31:26  !!! Building image for debug !!!
09:31:26  --build-id parameter: BUILD_ID |396|
09:31:26  --operating-system parameter: OPERATING_SYSTEM |ubuntu:20.04|
09:31:26  --build-tag parameter: BUILD_TAG |jenkins-scylla-master-releng-testing-next-machine-image-396|
09:31:26  --branch parameter: BRANCH |null|
09:31:26  --build-id parameter: SCYLLA_BUILD_SHA_ID |null|
09:31:26  INSTALL_ARGS: | --repo downloads.scylladb.com/testing/unstable/scylla/master/deb/unified/2022-08-09T15:55:28Z/scylladb-master/scylla.list --product scylla|
09:31:26  Importing apt key (d0a112e067426ab2)
09:31:27  Warning: apt-key is deprecated. Manage keyring files in trusted.gpg.d instead (see apt-key(8)).
09:31:27  Executing: /tmp/apt-key-gpghome.bqA4FyWuLW/gpg.1.sh --keyserver keyserver.ubuntu.com --recv-keys d0a112e067426ab2
09:31:28  gpg: key D0A112E067426AB2: public key "ScyllaDB Package Signing Key 2022<EMAIL_ADDRESS>imported
09:31:28  gpg: Total number processed: 1
09:31:28  gpg:               imported: 1
09:31:29  gpg: keybox '/etc/apt/keyrings/scylladb.gpg' created
09:31:29  gpg: /tmp/trustdb.gpg: trustdb created
09:31:29  gpg: key D0A112E067426AB2: public key "ScyllaDB Package Signing Key 2022<EMAIL_ADDRESS>imported
09:31:29  gpg: Total number processed: 1
09:31:29  gpg:               imported: 1

and later by packer (scylla_install_image) during scylla installation
09:31:36  ==> gce: Uploading ../../packer/scylla_install_image => /home/ubuntu/
09:31:36  ==> gce: Provisioning with shell script: /tmp/packer-shell3062150524
09:31:36      gce:
09:31:36      gce: status: done
09:31:36  ==> gce: Warning: apt-key output should not be parsed (stdout is not a terminal)
09:31:36      gce: Executing: /tmp/apt-key-gpghome.kwSb0MS1Ni/gpg.1.sh --keyserver keyserver.ubuntu.com --recv-keys d0a112e067426ab2
09:31:36  ==> gce: gpg: key D0A112E067426AB2: public key "ScyllaDB Package Signing Key 2022<EMAIL_ADDRESS>imported
09:31:36  ==> gce: gpg: Total number processed: 1
09:31:36  ==> gce: gpg:               imported: 1
09:31:36  ==> gce: gpg: keybox '/etc/apt/keyrings/scylladb.gpg' created
09:31:36  ==> gce: gpg: /tmp/trustdb.gpg: trustdb created
09:31:36  ==> gce: gpg: key D0A112E067426AB2: public key "ScyllaDB Package Signing Key 2022<EMAIL_ADDRESS>imported
09:31:36  ==> gce: gpg: Total number processed: 1
09:31:36  ==> gce: gpg:               imported: 1

In addition, I started ec2 instance based ami-0f173e43e9510ab48 (ubuntu20.04, 5.2.0~dev-0.20220809.be44fd63f9ab) and

scylla-server is up and running
/etc/apt/keyrings/scylladb.gpg exists as expected

@benipeled you can also prepare the pkg repo change for this, and just merge them together. this way you will not have to keep this duplicate ways for importing the gpg keys. what ever you prefer


PHP8.4 Support Added

Q
A

Documentation
yes/no

Bugfix
yes/no

BC Break
yes/no

New Feature
yes/no

RFC
yes/no

QA
yes/no

@cod43156
Please change the configuration for continuous integration to ignore version 8.4:
https://github.com/laminas/laminas-cli/blob/ab90e625bd9a0bd01889ffdf66d368cad0678892/.laminas-ci.json#L3

@cod43156 Please change the configuration for continuous integration to ignore version 8.4:
https://github.com/laminas/laminas-cli/blob/ab90e625bd9a0bd01889ffdf66d368cad0678892/.laminas-ci.json#L3

@froschdesign The configuration for continuous integration has been updated to ignore version 8.4

@froschdesign The ci failures are not related to this PR's changes and are coming in other PRs as well.
https://github.com/laminas/laminas-cli/actions/runs/11384095519/job/31671094663?pr=126
Can you please check and advise if we need to address the failures ?

CI Failures will need to be fixed in a separate patch before other PRs can be merged

Thanks @cod43156 - This was handled in #131


[IOTDB-1257] Make a little bit improvement of config and fix some bugs for setting logic

Change logs：

Fix the setting bug, e.g.: RpcTransportFactory.setMaxLength(ioTDBConfig.getThriftMaxFrameSize()); . i.e.,Don't put max_frame_ Size as softmaxlength.
Merge initialBufferCapacity and maxFrameSize to thriftDefaultBufferSize. and thriftDefaultBufferSize configable by user.
rename the key from initial_buffer_capacity to thrift_default_buffer_capacity
rename the key from max_frame_size to thrift_max_frame_size
Unified configuration items：

RpcUtils.java in the service-rpc module depends on tsfile & thrift moudles
Config.java in the iotdb-jdbc module depends on service-rpc & others moudles
IoTDBConfig.java in the iotdb-server module depends on service-rpc & iotdb-jdbc moudles

So, such as initial_buffer_Capacity and Max_frame_size config items should be based on rpcutils RpcUtils.java.
There is an open question about #3 & #4. Do we need to modify the variable name, which will affect the compatibility? What do you think?

Thanks for the review @ericpai ! And I would like to make a little bit improvement later. then would be great if you have time to review the update:) Thank you!

I would like to review this PR myself first and looking forward the CI results.
And feel free to left your comments after CI passed. Thank you!

Thanks for your feedback! @irvine0109 ! I had run the test in local and rerun the CI check, then the test case of testSyncConcurrency has passed.
@qiaojialin @jixuan1989 @jt2594838  would be great to have your comments in this PR. :)

The only concern from me is the default_buffer size is set as 16MB while it was 64KB.
Whether it has side-effect depends on:

How Thrift runs? will it generate a defined (not cached) buffer (64KB or 16MB) for each request?
Will IoTDB generate some small RPC requests/responses frequently?

as service-rpc/src/main/java/org/apache/iotdb/rpc/TElasticFramedTransport.java  is modified, I asked @neuyilan to have a review.

Thanks for the feedback @jixuan1989 @neuyilan
Before this PR, every small request will be expanded to 16m (I guess Jialin's thinking at that time was to avoid frequent expansion caused by the default value of 64K, and expand to 16m at one time), the resize logic is here . but the default 16m will also involve frequent capacity reduction, when frequent (5 times +) small requests comings. Therefore, setting the default values of 64K and 16m is a simple trade-off, because the memory consumption will be dynamically adjusted according to the request size and sizeIfNessessary(). So for me, the default values 64K and 16m are OK from the design point of view. From the perspective of experience you share and the memory resources of the devices, I agree with default 64K, if you prefer to 64K as default value.
I appreciate if you can share some thoughts here @qiaojialin  :)

Hi, I'm coming...

Before this PR, every small request will be expanded to 16m

That's right. This is due to that in TElasticFramedTransport, The following code is only for the shrink. However, the resizeIfNecessary() method could expand if the request size < 16m.
if (size < softMaxLength) {
readBuffer.resizeIfNecessary(softMaxLength);
}
Setting the initial value to 16m is better than the current design.  Another way is to split the resizeIfNecessary() to expandIfNecessary() and shrinkIfNecessary().
Then:
if (size < softMaxLength) {
readBuffer.shrinkIfNecessary(softMaxLength);
}

Another way is to split the resizeIfNecessary() to expandIfNecessary() and shrinkIfNecessary().

This is the essence of the problem. When the current thrift size is less than softMaxLength, calling this function will expand the thrift size to softMaxLength. We only need to separate the expand and shrink methods.

@qiaojialin @neuyilan

I think that the intention of the if block in readFrame() is shrinking, not expanding. Another call of resizeIfNecessary() in readBuffer.fill() can also handle the shrinking if we remove this if block.
It doesn't matter how large the default initial buffer size is, 64KB or 16MB. It will be shrinked or expanded in necessary immediately after the call of resizeIfNecessary() in readBuffer.fill(). The initial buffer size will also be set via user's configuration.
I also believe that the current design, putting shrinking and expanding logics together in resizeIfNecessary(), is better than separating them in two methods. Separating them means that we push the responsibility of checking the resizing condition up to the caller. The code will become more complex. However, we need a unified rule for resizing the buffer.

If there's any misunderstanding，I'm very glad to receive any feedbacks and details about the design :)

@ericpai

The original meaning of the resizeifnecessary function is that when the size of my request is larger than the size already declared by thrift, I will try to reduce the size; otherwise, I need to expand the size.

If the automatic adjustment is correct, the initial value of 64KB or 16MB is OK, but if the initial setting is too large, some memory will be wasted before the adjustment ends. At present, the reason why all requests become 16MB is that the parameters passed in by calling the function of resizeifnecessary are incorrect. The parameter to call the resizeifnecessary function should be the size of the request, not softmaxlength.  https://github.com/apache/iotdb/blob/master/service-rpc/src/main/java/org/apache/iotdb/rpc/AutoResizingBuffer.java#L50

Users don't need to care about when they need to expand or when they need to shrink. These things are shielded for users. When the user starts a read request or ends a written request, just call the following function is ok. What we need to do is to write a good strategy for expansion and reduction.

`
public void resizeIfNecessary(int requestSize) {
int currentCapacity = this.array.length;
if (currentCapacity < size) {
enlargeIfNecessary(size);
} else {
shrinkIfNecessary(size);
}
}
`

Thank you all for the feedback and discussion. At present, we have basically reached an agreement. Based on our discussion, I set the default value to 64KB. We can continue to discuss better contraction strategies, and better improvements can be made by opening separate PR.   What do you think @neuyilan :)

Thank you all for the feedback and discussion. At present, we have basically reached an agreement. Based on our discussion, The resizeifnecessary maintains the encapsulation shrinkage strategy and is transparent to the caller，and we set the default value to 64KB. We can continue to discuss better contraction strategies, and better improvements can be made by opening separate PR. What do you think @neuyilan  :)

Hi,  @sunjincheng121 I think this idea is OK.

Thank you all! Merging...


Update poolRegistry.tsx

hi @katatou827, to prove ownership of these accounts can you pls send this transaction from the controller or stash.
5G23iUgMscn2afQeLeG9Ta4Jub6vSqGzRniFY8PJ4nsV6wao": "Gyan",
"5ENsn4mnjsUkwujJwPaBUe37vTcW5sVkqSixEBCWgE6ZiYNp": "SHINWA"

Please proceed with the procedure.

https://uncoverexplorer.com/extrinsic/9859293-1
https://uncoverexplorer.com/extrinsic/9859275-1

hi holygits,I sent system.remark.


footnote

line 152 has a footnote, but i don't see it anywhere?
perhaps one of the packages makes it not show up?
do you have any ideas?
if nothing obvious seems to fix it, we can get that footnote in a different way.
thanks, j

I fixed it!


Make SECURITY.md consistent

We're missing these across a lot of Knative repos, this is copied/improved from the 3 that existed.

I meant to send this from a fork.  Not sure how I ended up with branch creation permissions.


swift SIL: Fix variable 's' was never mutated; consider changing to 'let' constant warnings

@swift-ci please smoke test

@swift-ci please smoke test Linux


Fix Debian installation: use backports

And limit to Debian 10. Fix #101

The recommended install method has changed: https://www.wireguard.com/install/#debian-module-tools. Since wireguard is in the backports, we shall use it and stop installing the module from unstable. 🙂
Since this has been broken for weeks now, I want to merge it ASAP before the other pending PRs if that's ok with you @randomshell

Of course. I'll merge this too to keep the pending ones up to date.


can the server also be a client?

My guess is that the answer is no; etc/client.keys would get overwritten by /usr/local/bin/dist-ossec-keys.sh through cron daily. Did I miss something?

This actually seems a little wrong, in theory it should be able to be a server and a client.

Closing due to inactivity.
If this is still an issue please reopen or open another issue. Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


chore change tpcds q67 testcase name to q67_ignore_temporarily

Proposed changes
Issue Number: close #xxx
Problem summary
change tpcds q67 testcase name to q67_ignore_temporarily since the error should be ignored temporarily due to precision problem that will be fixed further.
Checklist(Required)

[ ] Does it affect the original behavior
[ ] Has unit tests been added
[ ] Has document been added or modified
[ ] Does it need to update dependencies
[ ] Is this PR support rollback (If NO, please explain WHY)

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall