[Fix ] MMDetWandbHook does not support offline mode

Motivation
I got the following error when I used MMDetWandbHook in the offline mode:
wandb: Tracking run with wandb version 0.13.2
wandb: W&B syncing is set to `offline` in this directory.
wandb: Run `wandb online` or set WANDB_MODE=online to enable cloud syncing.
Traceback (most recent call last):
  File "tools/train.py", line 242, in <module>
    main()
  File "tools/train.py", line 238, in main
    meta=meta)
  File "/content/mmdetection/mmdet/apis/train.py", line 244, in train_detector
    runner.run(data_loaders, cfg.workflow)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/epoch_based_runner.py", line 117, in run
    self.call_hook('before_run')
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/base_runner.py", line 317, in call_hook
    getattr(hook, fn_name)(self)
  File "/usr/local/lib/python3.7/dist-packages/mmcv/runner/dist_utils.py", line 135, in wrapper
    return func(*args, **kwargs)
  File "/content/mmdetection/mmdet/core/hook/wandblogger_hook.py", line 203, in before_run
    self._log_data_table()
  File "/content/mmdetection/mmdet/core/hook/wandblogger_hook.py", line 569, in _log_data_table
    self.wandb.run.use_artifact(data_artifact)
  File "/usr/local/lib/python3.7/dist-packages/wandb/sdk/wandb_run.py", line 255, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/lib/python3.7/dist-packages/wandb/sdk/wandb_run.py", line 2491, in use_artifact
    raise TypeError("Cannot use artifact when in offline mode.")
TypeError: Cannot use artifact when in offline mode.
wandb: Waiting for W&B process to finish... (failed 1).

The log_config is the following:
log_config = dict(
    hooks=[
        dict(type='TextLoggerHook'),
        dict(type='MMDetWandbHook',
             init_kwargs={'project':'mmdet','mode':'offline'},
             interval=1,
             log_checkpoint=True,
             log_checkpoint_metadata=True,
             num_eval_images=1)
    ]
)

Modification
I think the use_artifact and wait methods in the following codes can be skipped when the wandb is offline:
https://github.com/open-mmlab/mmdetection/blob/df28da98926bc410e16bed1e9fc7d425d9a89495/mmdet/core/hook/wandblogger_hook.py#L559-L573
BC-breaking (Optional)
When the wandb is in the online mode (it is the default mode),  there is no change.
Use cases (Optional)
I use the offline mode when I debug and test the codes.
Checklist

Pre-commit or other linting tools are used to fix the potential lint issues.
The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMCls.
The documentation has been modified accordingly, like docstring or example tutorials.

About unit test:
To test the MMDetwandbHook, we need a full training setup (prepare dataset and install wandb and login), but I am not sure how to write this type of test efficiently.
I would appreciate any advice about this.

Hey @i-aki-y, just curious to know if you are using W&B Tables when using MMDetWandbHook in offline mode?

@ayulockin Hi, Thank you for your review.
No, I do not use W&B Tables intentionally in offline mode.
I use offline mode when I debug and test my code.
So I want my code to work independently of WANDB_MODE, without any other code change as follows.
# for debug
WANDB_MODE=offline python tools/train.py ${CONFIG}

Awesome, makes sense. Thanks for clarifying.

Dear i-aki-y,
First of all, we want to express our gratitude for your significant PR in the MMDet . Your contribution is highly appreciated, and we are grateful for your efforts in helping improve this open-source project during your personal time. We believe that many developers will benefit from your PR.
As a valued contributor, we would also like to invite you to join our Special Interest Group (SIG) private channel, where you can share your experiences, ideas, and build connections with like-minded peers.
Join us ：https://discord.gg/raweFPmdzG
To join the SIG channel, simply message moderator— OpenMMLab on Discord or briefly share your open-source contributions in the #introductions channel and we will assist you. We look forward to seeing you there!
Also，if you have WeChat，welcome to join our community on WeChat. You can add our assistant ：openmmlabwx，or scan the following QR code to join us. Please add "mmsig + Github ID" as a remark when adding friends：）
Best regards！ @i-aki-y


Race condition when allocating a port on all nodes of the cluster

What I do:
5 nodes cluster running Swarm 1.1.2 (f947993) and Engine 1.10.2.
I reproduce the bug with Compose 1.6.2 and the following docker-compose.yml:
www:
  image: nginx
  ports:
    - 8888:80

I do docker-compose up -d then docker-compose scale www=5.
(It has to match exactly the size of my cluster: 5 nodes → 5 containers.)
What I expect:
Each node starts one container, binding to port 8888.
What I see instead:
One container fails to start:
$ docker-compose scale www=5
WARNING: The "www" service specifies a port on the host. If multiple containers for this service are created on a single host, the port will clash.
Creating and starting 2 ... done
Creating and starting 3 ... error
Creating and starting 4 ... done
Creating and starting 5 ... done

ERROR: for 3  500 Internal Server Error: failed to create endpoint bug_www_3 on network bridge: Bind for <IP_ADDRESS>:8888 failed: port is already allocated

Notes:

If I scale from 1 to 5, on my test cluster, the bugs appears all the time.
If I scale directly from 0 to 5, the bugs appears less often.
If I scale from anything to 4, then to 5, the bug doesn't appear.
If I scale from anything to 1, 2, or 3, and then to 5, the bug appears.

@jpetazzo can you try with 1.1.3-rc1 (or -rc2 in a couple of hours?) we touched something that might help

@vieux got exactly the same problem with 1.1.3-rc1:
Server:
 Version:      swarm/1.1.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   da37fb5
 Built:        Thu Feb 25 00:04:25 UTC 2016
 OS/Arch:      linux/amd64
 Experimental: true

And for what it's worth, the Swarm manager logs have this:
time="2016-03-02T00:22:17Z" level=error msg="HTTP error: 500 Internal Server Error: failed to create endpoint bug_www_5 on network bridge: Bind for <IP_ADDRESS>:8888 failed: port is already allocated\n" status=500

And docker ps -a confirms that two containers were scheduled on the same node:
CONTAINER ID        IMAGE                         COMMAND                  CREATED             STATUS              PORTS                                 NAMES
74c96a05dd28        nginx                         "nginx -g 'daemon off"   3 seconds ago                                                                 node3/bug_www_5
43a765b48ce8        nginx                         "nginx -g 'daemon off"   3 seconds ago       Up 2 seconds        443/tcp, <IP_ADDRESS>:8888->80/tcp   node3/bug_www_2
47846efd42ce        nginx                         "nginx -g 'daemon off"   3 seconds ago       Up 2 seconds        443/tcp, <IP_ADDRESS>:8888->80/tcp     node2/bug_www_1
b9f2167d3ea9        nginx                         "nginx -g 'daemon off"   3 seconds ago       Up 2 seconds        443/tcp, <IP_ADDRESS>:8888->80/tcp     node1/bug_www_3
af63fccacadb        nginx                         "nginx -g 'daemon off"   3 seconds ago       Up 2 seconds        443/tcp, <IP_ADDRESS>:8888->80/tcp    node4/bug_www_4

Note: this is way harder to reproduce in debug mode, but after many tries, it happened again. Here is the log of the primary manager.
node1-swarm-agent-master.log.txt
Server:
 Version:      swarm/1.1.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   da37fb5
 Built:        Thu Feb 25 00:04:25 UTC 2016
 OS/Arch:      linux/amd64
 Experimental: true

And I reproduced it with 1.1.3-rc2.
node1-swarm-agent-master.log.txt
Server:
 Version:      swarm/1.1.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   7e9c6bd
 Built:        Wed Mar  2 00:15:12 UTC 2016
 OS/Arch:      linux/amd64
 Experimental: true

This seems to be gone in master: I can't reproduce it reliably. I'll close, and re-open if I see it again.


Extend syntax of update

Add support for the following syntax:
int32 a
update a = 20 // Equivalent to update a: a = 20

struct Point::
    x, y: uint32
Point p: 10, 20
update p = {30, 40} // Equivalent to update p: p = {30, 40}

The following syntax introduces a new update operator:
a := 20 // Equivalent to update a = 20

p := {10, 20} // Equivalent to update p = {10, 20}

To further support complex types, the syntax should be expanded with the following:
class Point::
    x, y: int32

Point p{}
update p.x = 10 // equivalent to update p: p.x = 10
p.x := 10 // equivalent to update p: p.x = 10

list{uint32} q{0, 1, 2}
update q[0] = 10 // equivalent to update q: q[0] = 10
q[0] := 10 // equivalent to update q: q[0] = 10

struct PointRef::
    p : Point

PointRef r: p
update r.p // Updates p
update r.p.x = 10 // Equivalent to update r.p: r.p.x = 10

In addition to the above, all assignment operators should be supported:
update a += 5
update a *= 5
// etc


⚠ Quirk Club Argentina (SSR) has degraded performance

In 3a96812, Quirk Club Argentina (SSR) (https://quirkclub-dev.web.app/ssr-check) experienced degraded performance:

HTTP code: 200
Response time: 4725 ms

Resolved: Quirk Club Argentina (SSR) performance has improved in 44ba017 after 17 minutes.


Rotate classNames no longer working

Describe the bug
Updating from NativeWind v40.0.23 to v4.0.36 seems to have broken the rotate classes (e.g. rotate-90)
To Reproduce
Steps to reproduce the behavior:

Using NativeWind v4.0.23, verify that an element such as an SVG with the rotate-90 className applied properly rotates
Upgrade to NativeWind v4.0.36
Provide the same rotate-90 className to the element
It doesn't have an effect

Expected behavior
The rotate class should be applied and rotate the element.
Expo Snack
(Tried unsuccessfully to make a Snack with Nativewind 4)
Additional context
I've been able to replace every instance of this className with style={{ transform: [{ rotate: '90deg' }] }} in my codebase but wanted to report this issue nonetheless.

can you provide a repo to debug? I have tested by forking the repo and running the expo example from 4.0.36 here
Rotate worked across all native components, for svg components tailwind itself doesnt support rotate for svg components see here all supported tw classes for svg components - note the fill class I tested works.

After upgrading to Expo SDK 50 and nativewind 4.0.36 the SVG styles did not apply anymore for me.
Previously I would render something like:
import Arrow from<EMAIL_ADDRESS><Arrow classname="w-24 h-24 text-black" />

I needed to adjust my code to use cssInterop in order to make this work. Also rotate-90 works on those <Svg /> components.

I cannot apply className styles on SVG starting from v4.0.1 itself. It worked fine on v2

We are closing all pre-v4.1 issues now that v4.1 is released. If the problem is still happening with the latest v4.1, please open a new issue and reference this one in the description.


Provide example systemd service and configuration file

Following https://github.com/Dreaming-Codes/nvidia_oc/issues/7 this adds a systemd service and configuration file.
We can further think about, to let the project build via meson or equal, which automatically package it into the correct path's.
I have not tested this implementation yet, but it should work fine :)

Hi,
Thank you for your contributions. Could you please remove the configuration file from this PR, as well as the related arguments from the service? These issues have been addressed with the release of version 0.1.15, so this PR can be merged afterward.
Regarding the use of Meson, I prefer not to incorporate complex build systems into my application. I aim to stick with the build system provided by the robust Rust ecosystem, as it makes it easier for people to contribute to the repository.


Removed Dependancy on ModuleRCSFX

And as quickly as it appeared, it was gone.

Yes, the dependency was giving be trouble


Surface Docs are all in Japanese at the moment.

Hey guys,
The surface docs seem to all be in Japanese at the moment.
https://docs.microsoft.com/en-us/surface/
https://docs.microsoft.com/en-us/surface-hub/surface-hub-2s-certifications

They've been resolved.


Adds teachers field to the "Lesson" resource

Adds the missing teachers field in the Lesson struct.
Without this the timetable is missing information about which teacher is holding which lesson.

Thanks!


Incorrect edition and SLO combination in example

The edition and SLO combination is incorrect because P6 is Premium not Standard.  Creates internal server error for customers when attempting to run the example.
Currently:
-Edition "Standard" -ServiceObjectiveName "P6" `
Correction:
-Edition "Premium" -ServiceObjectiveName "P6" `

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: d46a1d8f-2bc5-a71d-de8b-8e1bad1e6a20
Version Independent ID: a4517a60-5364-29a3-4f6d-39c688b64bb1
Content: Import a .bacpac file to create a database in Azure SQL Database - Azure SQL Database
Content Source: azure-sql/database/database-import.md
Service: sql-db-mi
Sub-service: backup-restore
GitHub Login: @SudhirRaparla
Microsoft Alias: nvraparl

@GarrySinghMSFT Thanks for reaching out, We will Investigate and update you shortly.

This issue is resolved using this docs PR: https://github.com/MicrosoftDocs/sql-docs-pr/pull/26892

@GarrySinghMSFT - Thank you for bringing this up.


Deplyment

Hi,
I am inexperienced in coding, tried to deploy an app and nothing happened. it said this:
2017-09-17T20:55:05.211982+00:00 app[web.1]: npm ERR! Tell the author that this fails on your system:
 2017-09-17T20:55:05.212145+00:00 app[web.1]: npm ERR! node bin/run_postgres.js
2017-09-17T20:55:05.212307+00:00 app[web.1]: npm ERR! You can get their info via:
2017-09-17T20:55:05.212466+00:00 app[web.1]: npm ERR! npm owner ls facebot
2017-09-17T20:55:05.212741+00:00 app[web.1]: npm ERR! There is likely additional logging output above.

in the log.  did I omit sth?

I have the same problem here

If I try and git clone npm install hangs on fetchMetadata: sill pacote range manifest for<EMAIL_ADDRESS>fetched in 98ms
If I try npm install facebot it hangs on fetchMetadata: sill resolveWithNewModule<EMAIL_ADDRESS>checking installable status

Master has been updated and everyone should work 👍


Avoid saving settings on every keypress

While it's extremely cool that the UI updates in real-time as I change the Font Family or other settings, writing a file for each key press seems more wasteful than necessary.
This PR cleans up storing the settings file and only stores settings when the input field loses focus, or the input hasn't changed for 300ms.

Rebased


Nominate Terry Howe to become an ORAS org owner

Hi,
I would like to nominate @TerryHowe Terry Howe to become an ORAS org owner. I believe Terry is qualified for this role. Here are some metrics about Terry and his involvement and contributions to ORAS.

Terry started to contribute to ORAS in Dec 2022. Terry has been promoted to a subproject maintainer on Feb 21, see PR
Terry raised 19 PRs in multiple ORAS repositories (ORAS CLI, ORAS-go, and ORAS-www) and is currently ranking at 2 in the last quarter. PRs Authors Table - Grafana (cncf.io)
Terry reviewed PRs in multiple ORAS repositories actively and left 126 comments in the last quarter.
Terry attends the ORAS community call 3 times since Jan 2023, see meeting notes.
Terry is active to provide support and response to users in the ORAS Slack channel in the last quarter.

I hope @sajayantony, @jdolitsky, @SteveLasker, @shizhMSFT, and @deitch could add your comments and vote on Terry's nomination.

+1. LGTM. Terry has been very active in the last months across multiple repositories in the ORAS org. Meanwhile, Terry contributed code with high quality and influenced the projects to be developed in a good direction.

+1 to adding Terry as a great addition to the ORAS Project

@sajayantony can you please review?

+1 to adding Terry. He has been active across ORAS organizations but in addition participating in other areas that are currently making use the ORAS project (such as Helm)


Fix CA1052 for public API

Fix CA1052: Static holder types should be Static or NotInheritable for public API.

Add static modifier to static holder types
Remove empty constructor (not valid anymore in static class

Possible breaking change: Unlikely Grey Area
Instantiating a class containing only static members has no obvious utility.

CodeFactor "complex method" issues are false positives, see #15721.

@PowerShell/powershell-committee reviewed this, we don't believe there's any real case where someone would be broken by this as the classes only have static members.  We approve of this change.

@xtqqczze Thank you for your contribution


docs(md-icon): api missing text

Bug, feature request, or proposal:
Bug
What is the expected behavior?
See the complete explanation of an api item
What is the current behavior?
Some text is missing in specific parts of the md-icon docs (API Tab). Where it should be written something like:
"Returns an Observable that produces the icon (as an <svg> DOM element) from the given URL. The response from the URL may be cached so this will not always cause an HTTP request, but the produced element will always be a new copy of the originally fetched icon. (That is, it will not contain any modifications made to elements previously returned)."
you actually see what is shown in the image bello (that's because of the <svg> tag in the code comment):

Here's the URL for reference: https://material.angular.io/components/icon/api

@willshowell, what's the right path to avoid this error in docs? Does it follow the same Github markdown rules? I mean, is it just a matter of use the backticks (`<sgv>` instead of <sgv>)?

@julianobrasil *svg ;)

Thanks, @donroyco! Not home right now, but I'll fix it and submit a PR later if no one do it (I was just showing the Material 2 Project to a reluctant developer and this error in the docs didn't help my point of view 😸 ).

@julianobrasil Yeah it'd almost certainly be fixed by backticks. I'm sure no one would mind either if you added a lint rule to enforce HTML tag escaping too (see the noExposedTodoRule) 😁

@willshowell, of course... just need to make sure that the backticks escapes HTML tags. @donroyco wrote something about asterisks above.

@julianobrasil It was just a typo reference: sgv » svg

@donroyco, that's why my wife keeps saying I need some rest once in a while 😃. I haven't corrected the docs yet because yesterday I got involved with a mysterious behavior in a project (at the end I found out  that if you create an @Output named "change", or named after any html native event, Angular will bubble the native event through it).  But I did submit the PR with the tslint rule at least.

This issue still persists as of today.
Why the PR #5824 still hasn't been merged? I think it's a valid fix.

Another one was merged today with the same fix: #7756

Nice! :) So this issue can be closed then?

Right now!


app crash when trying to open video

So first of all I don't think its a bug but I did found few things that was out if place hoping to get some direction
I'm not knowledge about custom scripts or anything but I was able to create this script for streaming using chatgpt
cache=yes
cache-dir=/storage/emulated/0/Download/Seal
cache-secs=60
demuxer-max-bytes=200MiB
demuxer-max-back-bytes=100MiB
Idk which parts of this scripts works and which doesn't but I do know the 60s cache works so I didn't have any problem if anything else worked or not but few hours ago I noticed the app cache was 1.8gb and that's kinda big so I clear cached and data but now when I try to play anything either the apps stops working or it gets crash
And here's the new script I got from chatgpt again not sure if it will work or not since I don't know anything about scripts
cache=yes
cache-on-disk=yes
cache-dir=/storage/emulated/0/Download/1DMP/Videos
write-dir=/storage/emulated/0/Download/1DMP/Videos
cache-secs=70
demuxer-max-bytes=200MiB
demuxer-max-back-bytes=100MiB
keep-cache=no
Here's the crash log
mpvKt_logs.txt

this should be fixed in the latest nightlies. can you try one of them? you can find them in the workflow artifacts of every commit that's newer than 2 weeks.

this should be fixed in the latest nightlies. can you try one of them? you can find them in the workflow artifacts of every commit that's newer than 2 weeks.

Hello, I downloaded the new release from action ver: armv8-r251 and used this script
cache=yes
cache-on-disk=yes
cache-dir=/storage/emulated/0/Download/1DMP/Videos
write-dir=/storage/emulated/0/Download/1DMP/Videos
cache-secs=70
demuxer-max-bytes=200MiB
demuxer-max-back-bytes=100MiB
keep-cache=no
Ok I double check but the issue seems to be with pick confi storage location cause if I use download/1DMP/Videos it crash but if I use some other location it plays perfectly

huh... I'll look into it when i find the time.. thanks for reporting

One more thing what dose this 2.99gb storage mean? Is it cache storage or something else?


Adding heartbeats source and receiver as a release-able component.

Proposed Changes

Release heartbeats as a source example with compiled image.
Release heartbeats-receiver as a compiled image.

Release Note

Releasing heartbeats source and receiver.

/lgtm

/lgtm

/assign @vaikas-google
Can you coordinate with Ville, who I think was working on adding a Google Cloud Scheduler source?
At the very least, it seems like it might be useful to align the terminology -- I'd probably prefer to call this "periodic" or "cron" source rather than "heartbeat", which suggests a specific use-case.


Add client support for PKINIT

Is your feature request related to a problem? Please describe.
This is a tracker for the client side of PKINIT #95.
Describe the solution you'd like
Implement AsymmetricKerberosCredential : KerberosCredential which takes an X509Certificate2 instance containing a private key.
Invert the pre-auth logic such that a given credential controls how it injects a PA element into the as-req instead of leaving it to the KrbAsReq class. Move the default encrypted timestamp implementation into the abstract KerberosCredential class and have existing credentials use that default implementation.

The DH bit of the client side is handled in #112

Closed by https://github.com/SteveSyfuhs/Kerberos.NET/pull/117


group-based authentication

It would be great to leverage the google apps provisioning API to retrieve the logged-in user's group memberships, enabling some useful features:

Restricting access to an application/upstream by group.
Passing the list of group memberships foward in a header to the application, allowing for finer grained access control.

We are using bitly proxy and it works well for basic OAuth. Now we are trying to get group and orgUnits information and apply cascaded privileges to a user.  The problem with using a file is that the list may not be in sync with Google, since positions can change within the organization, and security concerns, as anyone gains access to the server can change that file. I'm really tempted to implement this feature but like @jakeyr I'm also new to Go. I have a couple of questions from browsing the source. Would you kindly provide some guidance? Thanks

Since I last looked at this, it appears the google admin SDK has added the ability to enumerate members of a group:
https://developers.google.com/admin-sdk/directory/v1/reference/members/list
it also appears to have been added to the go client:
https://code.google.com/p/google-api-go-client/source/browse/admin/directory_v1/admin-api.json
the new scope is:
https://www.googleapis.com/auth/admin.directory.group.readonly
i can take a crack at implementing this now! hopefully i'll have some time tomorrow or this weekend for this.

@jehiah can you reopen this issue?
thanks!

This capability was added in #139


Docker-compose runtime doesn't contain latest Weaviate version

Note how https://github.com/semi-technologies/weaviate/blob/master/docker-compose/runtime/docker-compose.yml seems behind (0.19.3 instead of 0.19.4)

resolved manually as part of #965
TODO: version the script with weaviate automatically, also required for docs to always be up to date


fixed windows compatibility

this PR will address issue #273
it is still a little rough around the edges, but i think good enough to start a little discussion on the changes made.
i have quite aggressively removed anything that is using unix pipes, except for docker.sock that needs to stay in place so the container can access the host's docker daemon. windows does actually also have something like unix pipes, called npipes, but they are not compatible. i also believe that since we have plan, at least that is what i understood, to have mesg-core run on a different machine or even go server-less, going all TCP seemed the right approach here,
i also removed mounts, env variables and directories that seemed redundant and/or not used, even in sample services/apps, including fixing variable <-> package name clashes, as well as redundant variable declarations.
i have tested everything with a small service and all seems to be working well.
please feel free to comment

i will close this PR first in favor of splitting it up into smaller more manageable pieces.


elm-test-rs: init at 2.0

Motivation for this change
I would like to add elm-test-rs to Nixpkgs.
This is an alternative to elm-test written in Rust by @mpizenberg.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[x] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

@turboMaCk I took inspiration on what you have done for elm-json. Maybe you can double-check?
@mpizenberg Let me know if it is OK for you to publish on Nixpkgs.

Yep I'm fine with this. Maybe @BrianHicks will be interested in this too since he had added a default.nix to the project some time ago.

@GrahamcOfBorg  build elmPackages.elm-test-rs

Yep I'm fine with this. Maybe @BrianHicks will be interested in this too since he had added a default.nix to the project some time ago.

Sure! I've seen that the default.nix is not up-to-date, by the way.

Sure! I've seen that the default.nix is not up-to-date, by the way.

@mpizenberg I think you should probably remove that file from the project unless you're willing to maintain it.

@jpagex can you please split this PR into two separate commits as:

first commit adding you to the maintainer list
second commit elm-test-rs: init at 2.0

this will be required for committers to accept the PR. Other than that I don't have further comments. The binary builds correctly on my system (nixos x86_64).

@jpagex can you please split this PR into two separate commits as:
* first commit adding you to the maintainer list

* second commit `elm-test-rs: init at 2.0`

this will be required for committers to accept the PR. Other than that I don't have further comments. The binary builds correctly on my system (nixos x86_64).

Yes, I'll do that!

@domenkozar this looks good to me. Feel free to review and/or merge this once you have a minute.

it seems I've just been nominated for committer so I will be able to merge this PR. Before I do that I would like to test just few more things that just came to my mind. I'll try to do that and merge this ASAP.

looks great! Thanks for contribution @jpagex and welcome to nixpkgs maintainers.

Thanks for your help and for your careful review! 😀


Vue with dynamics.js in dev mode

I'm running npm run dev and created this component: https://gist.github.com/sean-nicholas/0d180a5be1c0422955ebb04d3f58277e to recreate this effect: http://dynamicsjs.com/examples/loader.html
When I'm refreshing the page (F5) the dots don't move. If I change translateY in line 20 the hotreload gets triggered and the animation works. When I'm changing back to the original value it stops again. npm run build -> the dots move directly on startup (thats how it should work in dev, too).

The component you linked to seems to work fine in a fresh project, so something else may be going on. Are you getting any warnings/errors in the JS console?

Closing this, as I'm guessing you may have resolved it and it also sounds likely to be an issue with the specific project, not the template.


bug: multiple files are selected on bootstrap

This is something that popped up a couple of times for @d3lm but has been almost impossible to reproduce. @cburgdorf and I ran into it now too.
Reproducing steps:
Open: https://machinelabs.ai/editor/B1-rB4PT-/1508490969281-H1Zkyrw6W?tab=editor&file=%2Fmain.py
And you'll see:

Notice that multiple files are selected while only one should be.

Okay I've got some good and some bad news.
The good news: I know where this comes from and it's unlikely to happen with any future labs.
The bad news: we might need to determine if any data in our production system is affected by this, and ideally fix the data.
It turns out that this bug in that particular lab only happens in certain executions. Basically, all executions that have been executed before execution with id<PHONE_NUMBER>635-r15QmTu0Z )https://staging.machinelabs.ai/editor/rkw7PI03Z/1509638945635-r15QmTu0Z?tab=editor&file=main.py) suffer from this, whereas all executions after that one, don't have this problem anymore.
So I looked into the persisted lab data  and it turns out that we happen to have accidentally saved the clientState of the lab's directory per execution. While the client is doing its job and selects the correct file by query parameter, it doesn't have control over data that already comes with a clientState. That's why those mentioned executions will always have multiple files selected. This must have been a bug in the past and by now, our client side algorithm doesn't produce this misbehaviour anymore, which means, the wrong data that is persisted is never touched anymore in practice.
I'll write a script to figure out if and how many labs/executions in our production system are affected by this. Chances are this has never happened in production.


"The file version is error"

How do I go around the "the file version is error" warning which prevents me from flashing the firmware using the "Portable radio updater"?
I use the UV-K5 (8).

You can use this tool instead:
https://github.com/OneOfEleven/k5prog-win

Thanks, thought k5prog was only for Linux.

Closed.


Add support of allow_self_signed ssl option

Could you clarify the added value over disabling peer verification entirely, which is already possible?

Could you clarify the added value over disabling peer verification entirely, which is already possible?

Calling ClientTlsContext :: withoutPeerVerification completely disables all checks, both the cert and peer name.
ClientTlsContext :: allowSelfSigned works a little differently, minimal checks are performed, for example, peer name. For details, you can see the source code https://github.com/php/php-src/blob/master/ext/openssl/xp_ssl.c#L310, https://github.com/php/php-src/blob/master/ext/openssl/xp_ssl.c#L537.
Of course, you can do without this option, but I think that it won't be superfluous)


[Docs] go install github.com/k3d-io/k3d@latest

Overview section of v5.4.9 Documentation
install via go: go install github.com/k3d-io/k3d@latest
should be edited to:
go install github.com/k3d-io/k3d/v5@latest

Can confirm
 go install github.com/k3d-io/k3d@latest doesnt actually installs the binary in $GOPATH/bin
but  go install github.com/k3d-io/k3d/v5@latest does

@tesla59 Thank you so much, for attending to this minor documentation glitch and merging it with #1290
I will keep the faith and an eye on the progress.
Have a pleasant day.
Muchas Gracias,
Arnold.

It's there now on the v5.5.0 page:

Thank you both!


Support suppression/ignore comments

This is what #70 already asked for. No reasoning was ever provided as to why it would be "out of scope" so I'm hoping to either put this on the agenda or get some insight as to why it shouldn't be there.
Generally, I believe this is a viable feature requests since there tend to always be rules that really provide  true positives in 99% of the cases but I still want to opt out sometimes. Existing linters seem to agree on that and all have implemented some variant of line/block-based suppression.
Thanks for providing some context!

I also think this would be a good addition. There are several places within my codebase where the code is valid but the linter trips up. Whilst waiting for these to be fixed, a disable-line or disable-block comment would be extremely useful to clear away irritating false errors.

Closing as this package has been deprecated in favor of the official styled-components/typescript-styled-plugin fork
After updating to that fork, follow up in the styled-components repo if this is still an issue


Now able to run example

Hi,
I am getting below error while trying your tool -
../scripts/dd2.py funarc.bc search_funarc.json config_funarc.json
[[], [], [], [u'sinf', u'sin'], [], [], [], [], [], [], [u'sqrtf', u'sqrt']]
Searching for valid configuration using delta-debugging algorithm ...
Error opening 'precimonious/src/Passes.so': precimonious/src/Passes.so: cannot open shared object file: No such file or directory
  -load request ignored.
opt: Unknown command line argument '-json-config=config_temp.json'.  Try: 'opt -help'
opt: Did you mean '-asan-opt=config_temp.json'?
opt: Unknown command line argument '-adjust-operators'.  Try: 'opt -help'
opt: Did you mean '-use-ctors'?

I could not find Passes.so  using find command. I have followed all steps as mentioned.

i also encountered this problem.

i missed the cammand "scons -U test",so the Passes.so didn't form.


Documentation mentions password but should be personal access token

The documentation for spring-cloud-config authentication section specifies a password field, but makes no mention that this password should be a personal access token instead of the password.

This is the correct documentation link
https://docs.spring.io/spring-cloud-config/docs/current/reference/html/#_authentication
If you are using basic authentication it should be a password.

If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.


NEXT-22699 - fix: Remove superflous twig instruction

1. Why is this change necessary?

2. What does this change do, exactly?
Remove superfluous twig tag.
3. Describe each step to reproduce the issue or behaviour.
Create a product cross selling
4. Please link to the relevant issues (if any).
NEXT-22699
5. Checklist

[x] I have rebased my changes to remove merge conflicts
[ ] I have written tests and verified that they fail without my change
[ ] I have created a changelog file with all necessary information about my changes
[ ] I have written or adjusted the documentation according to my changes
[ ] This change has comments for package types, values, functions, and non-obvious lines of code
[x] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-23840
Please use this issue to track the state of your pull request.

Thank you for your contribution 💙


Improve exported structure of displaced_cross_section_x and reappearing_cross_section_x

In exported pandas dataframe displaced_cross_section_x, displaced_cross_section_y, reappearing_cross_section_x and reappearing_cross_section_y are hard to access.
Suggested structure hstacked numpy array.
The improved data structure should support vectorized operations so that unit conversion can be done easily.

So I can't quit get what you mean by "hard to access"?

He means to not deliver the coordinate arrays distinctly, but as a two-dimensional array.

Hi @GRPlan,
Currently, as you know, this is a MultiPolygon we don't see a feasible way to convert the shape as of right now.
Therefore I will move this issue to a indefinite timeline.


Make it easier to remove a user from an org

We detected some inconsistencies and unexpected behavior in user's role management, namely the organization_user role:

If a user received organization_manager (or auditor) rights, he or she also gets the organization_user role assigned.
When removed from the organization via cf unset-org-role, the organization_user role remains assigned to the user.
The only way to remove this role - and thus have the user completely removed from the organization - is by issueing a cf curl -X DELETE /v3/roles/:roleid but a user usually will need to figure out the role's id with another call first.

There has already been a story to request an easier way to accomplish this (https://github.com/cloudfoundry/cli/issues/781) but the general opinion back then was better to ask CAPI to have it implemented there.
The simplest solution would be to add OrganizationUser to the available roles of cf unset-org-role and let developers remove themselves from orgs in a convenient way which is why I submit this issue (and because @reid47 told me to).
However, I think there might be some caveats and could introduce undesired side-effects: What happens, if a user tries to unset the role even if he or she still has either an org-role or a space-role in any of the org's spaces assigned? Clearly the CLI should throw an error and decline such a request. Also, should cf org-users then contain users without the 'OrgManager', 'BillingManager' and 'OrgAuditor' role but with 'OrganizationUser'?
Since organization_user does not serve any practical purpose to the enduser, my preferred implementation would actually be to have CAPI remove the role upon removing the last org-role from a user, because CAPI assigned the role in the first place. If it's really just a marker role, the removal of the role itself could also be worth discussing? Bear in mind that a foundation with ~4000 users in ~3000 spaces results in several tens of thousands organization_user role elements - additionally to all the specific space_manager, organization_manager, ... roles.
That sheer amount of users and roles is also the reason we'd like to clean up unused and unnecessary roles. I've come across (technical, local) users with more than 1000 roles assigned which then needlessly slow down every single of their API calls.

Thank you for your submission. As mentioned earlier, this is more of a CAPI change than CLI. Please create a CAPI GH Issue.


Flaky DbResourceGroups tests

The TestSpecificDbResourceGroupsManager  tests intermittently fail their assertions on the number of resource groups. This appears to potentially be a timing bug due to interaction between TestSpecificDbResourceGroupsManager  and TestResourceGroupsManager.

Might be good now .. lets keep an eye on it though

I think we are good with this now - at least I have not seen it be a problem anymore. Can we close @willmostly ?

This seems to be gone now.


thinking that this makes the whole function simpler.

You're still looking at a completely different version than what's on master...

well can you point me to the right one?

isn't this the one: http://backbonejs.org/backbone.js ?

No. https://github.com/documentcloud/backbone displays the current master branch.

Great. thank you!


How do I extend the logger?

By default, Logger.get() returns ILogger which is only good for calling the particular logging methods. As far as I found, I can't even set some additional values to the context.
What is the proper "entry point" if I want to extend js-logger, like adding additional error levels, logging methods for the new levels, wrapping or overriding the base methods, while having it (hopefully) strongly typed?

Sorry for the late reply, but in all honestly the answer at this stage in the projects lifecycle would be to fork it to meet your specific needs.


i am not getting port in arduino but it installed correctly

Not sure how this question relates to my project.


[7.x] Unwrap ravioli in Illuminate/Database/Eloquent

I propose unwrapping some methods to make the codebase more maintainable and transparent (=easier to follow), simplify debugging and reduce call stack.
Initially I came upon some ravioli issues in Illuminate/Database/Eloquent/Concerns/HasAttributes. Afterwards I went through all the other files in the Illuminate/Database/Eloquent namespace, but only discovered a single method appropriate for unwrapping, so it seems that HasAttributes was a bit not like the other kids in that regard.
I unwrapped only such methods that are

protected
single line
not useful for testing
readable unwrapped

Some examples:
// json_encode is as short as $this->asJson, but more transparent and without the additional call
protected function asJson($value)
{
    return json_encode($value);
}

// is used only in a self-documenting switch statement
protected function asTimestamp($value)
{
    return $this->asDateTime($value)->getTimestamp();
}

// the actual body contains the same "get arrayable relations" words in the same order
// doing it explicitly instead of a method reduces confusion by 1 entry in the call stack
protected function getArrayableRelations()
{
    return $this->getArrayableItems($this->relations);
}

I also removed one test that only tested the behaviour of a protected method. The external behaviour of that feature is tested by a neighbour test testHiddenCanAlsoExcludeRelationships, the other test jwas just a constraint on refactoring.
I did not remove break apart useful raviolis like the following:
// used for testing
protected function newHasMany(Builder $query, Model $parent, $foreignKey, $localKey)
{
	return new HasMany($query, $parent, $foreignKey, $localKey);
}

// name makes it simpler and the intention becomes clear
protected function canUseExistsForExistenceCheck($operator, $count)
{
	return ($operator === '>=' || $operator === '<') && $count === 1;
}

I propose unwrapping some methods to make the codebase more maintainable and transparent (=easier to follow), simplify debugging and reduce call stack.

But at the same time it reduce the flexibility of any developers needing to customise their experience using Eloquent, especially when they need to override those methods.

I'm with the previous comment here, I,m pretty sure those methods were created for that.
That said I'm not sure why there is a test for a protected method.
Also it makes a lot easier for others to follow pull requests when correct terms are used instead of unwrapping ravioli.

Laravel is based on a fully customizable philosophy. I think it's against the community's intention to make these changes.

I am aware of the premise that the framework should be very flexible/extensible/modifiable. This PR is not intended to fight that. I am proposing to remove methods that are only used once (except $this->asJson which is used twice). And most of those uses are methods of 4-8 statements which are easy to override themselves.
These simplifications will not make behaviour harder to override. As the code becomes easier to comprehend, the overriding might even become simpler, as one must understand where and what is going on before it can be changed.  Let's take an extreme example:
public function newModelQuery()
{
    return $this->newEloquentBuilder(
        $this->newBaseQueryBuilder()
    )->setModel($this);
}

That's a single statement. If you want it to behave differently, it's easier to just override it instead of understanding what is going on with that newBaseQueryBuilder and if you should override just that instead. Putting $this->getConnection()->query() instead of $this->newBaseQueryBuilder() will make this method easier to understand and you can still override it just as good. I am not proposing to change methods that are used over and over and where the isolation actually makes overriding simpler.
Footnote: The statement that I understand the premise and try to honor it does not mean I agree with it. I believe the framework should be a lot flatter. The infinite callstack has been a source of infinite frustration exactly when I had the need to override something. And large but finite frustration when I need to debug through it.

The reason behind those methods being extracted, that additional features and bugfixes can be added to the code and will be pulled in for existing projects.
For example:

Lets say there is an option to add a checksum to models
It will go into the attributesToArray method, something like

if ($this instanceof Checksumable) {
    $this->addChecksum();
}

Currently all user is receiving this whether they are doing something or not in the getArrayableAttributes
If this gets merged, these users will be forced to manually their models because they had to override attributesToArray and the changes aren't in their local copies

The idea is to extract single responsibilities which will most likely be overwritten.

Thanks for your pull request to Laravel!
Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.
If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!
If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

I'm also with @netpok at al.
I've read in the  blogosphere about this "ravioli" stuff related to the complexity.
My experience 180 degree in the other direction. I had my fair share of joy having to make Laravel work together with subpar or legacy software. In terms of directly integration or via external services.
The way the code is currently written ("ravioli") is exactly what enabled me to do all these things because sometimes I need to replace a registered service but only need to overwrite exactly one method (maybe it was just a one-liner) exactly because of this.
And the method may even just also be used once in the framework and could have easily been subject to your unwrapping approach.
It's very much different philosophies and I'm absolutely against these kind of changes: they transform the software for the worse.
Maybe people (not saying: you) are confused about this: from the outside, Laravel looks easy to use (and is). But if you look inside, you see a world of well engineered components working delightful together. People did not create these methods because they though it was fun. They've a certain vision of how modern software / frameworks should be developed. And I think it's important to honor and absorb this; not work against it.

@mkf probably I lack some of the mental skills to follow through the huge stacks, because I find it harder to override. Btw I am also one of those who have ranted on my experiences when I tried to find out where the email address comes from for sending password reset mail.
Sometimes I don't even try anymore. I am aware that some people implement all kinds of custom authentication by overriding some oneliner deep in the code.  But when I needed to implement AD authnetication as an alternative, I just copied the login method from Illuminate/Foundation/Auth/AuthenticatesUsers and replaced the attemptLogin blackbox
if ($this->attemptLogin($request)) {
    return $this->sendLoginResponse($request);
}

with explicitly authenticating users the way I needed, using just the methods that can be found in docs (Auth::login and Auth::attempt):
$user = \App\User::where('is_active', 1)->where('id', $request->user)->firstOrFail();

if ($user->objectguid)
{
	$adUser = \Adldap::search()->users()->findByGuid($user->objectguid);

	$username = $adUser->getUserPrincipalName();

	if (\Adldap::auth()->attempt($username, $request->password))
	{
		\Auth::login($user, $request->remember);

		return $this->sendLoginResponse($request);
	}
}
else
	if (\Auth::attempt(['id' => $user->id, 'password' => $request->password], $request->remember))
		return $this->sendLoginResponse($request);

It took me 10 minutes and I am pretty sure it would have taken at least an hour to understand what goes on under the hood before even starting to override it.

@mfn I'm confused by "well engineered comments" on an issue about eloquent.
Honestly I'm not sure why this wasn't merged, but the majority of both eloquent and the underlying database layer are far from well engineered. They're a spaghetti mess of unccessary methods and for some bizarre reason, the same code being called several times unnecessarily.


Fix relay sub/unsub before connection is established

This implementation also doesn't send REQ if the subscription was cancelled before connection was established

I added a bug fix for unsubscribing  (the code was still trying to send a CLOSE request in connecting state)

Instead of just guarding these things under ifs we should wait until the connection is established and then send the messages.

Instead of just guarding these things under ifs we should wait until the connection is established and then send the messages.

Sure, we can do that, though I'm planning to do a RelayPool and smarter Relay (with auto reconnection, looking at timeouts) where the reconnecting and error handling is done by the Relay itself. I though it would be better to put it into nostr-tools as I see that there are many RelayPool implementations already. I wanted to ask you if there's a better way to reach you (4 days is a bit too long for answer on your plans for nostr-tools). Is there another official way? (I wrote DM on nostr as well).
I wrote a caching storage layer using IndexDB, that is independent of frameworks (only depends on nostr-tools and dexie.js, but I'm not against dropping dexie.js / adding other db backends). It's closed source because it's not ready yet, but it will be open source.
I also wrote a Svelte client on top of the caching storage layer, but I make sure that it can be used by other clients as well that have access to JavaScript.

You can talk to me on the https://t.me/nostr_protocol channel (I am not using Nostr DMs these days) but please don't demand attention or quick responses.
I feel like you didn't understand my request above. This is not related to relay pool. There is even no relay pool implementations here anymore (I've removed the one that existed).
Publish your libraries and clients and talk about them on Telegram and Nostr and Twitter and see if people use them.

Sounds great, I added that Telegram channel (maybe it should be on the home page as an alternative contact).
I understood the request, I just wrote about the RelayPool because I believe that handling connect / disconnect / reconnection logic should be done by the Relay class when we're building abstractions over it. The current Relay implementation is a leaky abstraction that is a great code example, but using it didn't make my code shorter when I added connection handling logic to it that was independent of subscription logic.
It's OK to have different opinions about it, I accept yours, thanks for your answer.

I created and published a separate relay pool library on top of nostr-tools, as you don't want it to be part of nostr-tools.
https://github.com/adamritter/nostr-relaypool-ts
It would be great to link to it from this repo, as they work well together (having a link to every project that uses nostr-tools would be great actually)


Module has no exported member 'OpaqueToken'

ERROR in node_modules/material-time-control/node_modules/@angular/flex-layout/media-query/breakpoints/break-points.d.ts(8,10)
Module  has no exported member 'OpaqueToken'
"@angular/animations": "^5.2.1",
"@angular/cdk": "^5.1.0",
"@angular/cli": "^1.6.5",
"@angular/common": "^5.2.1",
"@angular/compiler": "^5.2.1",
"@angular/core": "^5.2.1",
"@angular/flex-layout": "^5.0.0-beta.13",
"@angular/forms": "^5.2.1",
"@angular/http": "^5.2.1",
"@angular/material": "^5.1.0",
"@angular/platform-browser": "^5.2.1",
"@angular/platform-browser-dynamic": "^5.2.1",
"@angular/router": "^5.2.1",

Did you find a solution for this error?

Apologies, that I haven't responded to this before.  I put this control up on Git for demo purposes.  It was not meant for production or product inclusion; only for reference how to build the control and use it in your own implementation.  With Angular always being updated, the state of this control with the current release may not work.  But, please by all means use the code to build / implement your own time control.


[Bug] Treemap disappears on interaction / scroll / drilldown (Vue 3)

Version
5.5.1
Link to Minimal Reproduction
https://codesandbox.io/p/sandbox/echart-treemap-vue-bug-q74ljp
Steps to Reproduce
Click on a node within the treemap OR click on the breadcrumb OR try to zoom with the mouse wheel and the treemap disappears.
A refresh brings it back.
Current Behavior
Treemap disappears/minimises to the top left.
Expected Behavior
Drilldown or zoom change
Environment
- OS: Any
- Browser: Chrome
- Framework: Vue 3

Any additional comments?
It uses data (data.js) which is the data directly from the disk usage example

not-a-bug, probably due to error in Vue environment. Same code works fine in the Editor - Demo

@helgasoft just because something works outside of a framework doesn't automatically mean the bug is within the framework.

Are you using the recommended vue-echarts ? There are examples to follow there.

@DotoPototo Try to use shallowRef
-const chart = ref(null);
+const chart = shallowRef(null);

Or a local unresponsive variable.
-const chart = ref(null);
+let chart = null

// ...

onMounted(() => {
- chart.value = echarts.init(document.getElementById("main"), "dark");
+ chart = echarts.init(document.getElementById("main"), "dark");
  updateChart();
});

See also other similar issues here, especially https://github.com/apache/echarts/issues/17723#issuecomment-1268311307.

@plainheart That makes a lot of sense! Perfect, thank you 💯


Issue with k8s.io/docs/tutorials/hello-minikube/

This is a Bug Report

Problem:
katacoda problem cannot access minikube dashboard via browser port 30000 "error 502 bad gateway"
Proposed Solution:
fixing Katacoda port connection
Page to Update:
https://kubernetes.io/docs/tutorials/hello-minikube/

I can replicate this.
Once you get as far as:

Run the following command:
minikube service hello-node

Katacoda environment only: Click the plus sign, and then click Select port to view on Host 1.

then you get a new window / tab opening that shows a Bad Gateway error, and you don't get as far as

Katacoda environment only: Type 30369 (see port opposite to 8080 in services output), and then click
This opens up a browser window that serves your app and shows the “Hello World” message.

If you instead choose View HTTP port 80 on Host 1, that opens OK, and you can change the port to match what the Service is using. So, there's a bug.
/kind bug
/language en

@chiplux Thanks for letting us know. We fixed the issue shortly after you raised the ticket and we have also added a direct link to the dashboard to make it easier for people.
If you continue to have problems please let us know otherwise we believe this issue can be closed.

/close


Update evaluate.py-Fix ZeroDivisionError in metric calculation

Fix ZeroDivisionError in metric calculation

Added a check to handle cases where no examples are processed (ntotal == 0)
Introduced a warning log when the devset is potentially empty
Refactored the average metric calculation to avoid division by zero
Updated return statements to use the safely calculated average_metric
Improved robustness of the evaluation process for edge cases

This commit prevents crashes due to division by zero and provides meaningful  feedback when no examples are processed, enhancing the overall stability of  the evaluation functionality.

This was auto-closed by merging #1194. It could be useful to throw a more helpful exception than divide by zero here, though, just so it's more obvious what is going wrong. Perhaps we could make a change with a more descriptive exception but still throw an exception when running on an empty devset.


Dejunk "AutoOpened window" should automatically close after all items are destroyed

Hi there,
please consider automatically closing the "destroy" window, after the last items in it has been destroyed (by clicking the "Destroy Next" button for all the items in the list.)
Or, alternatively, change "Destroy Next" button to "Close window" when there are no more items left.
Thanks.

(this is in Classic btw...)


Delay animation start

Is your feature request related to a problem? Please describe.
I would like to be able to delay the start of the charts animations by an arbitrary amount. I thought that's what the animateGradually.delay meant, but now I see that's delay per path rendered.
In my use case, Apex charts often have an animation on top of them (fade-in, slide, etc) with an arbitrary delay and duration, so I'd like to sync that animation with the one Apex provides.

Describe the solution you'd like
The ability to provide an extra option to the animation config, which delays the chart rendering by that amount (in ms). Just to clarify: I would render the axis & legends, but delay the paths animation themselves.
Describe alternatives you've considered
I don't see many workarounds. I've considered delaying the creation of the chart, but in most cases the end user won't see anything. I could also delay setting the data, or send mock data while the animation is playing, but that would show some inaccurate axis information.

I might give this a go if you think it is a worthy addition to the library.
Also, kudos for the amazing library, we're really loving working with it 👏

I would love this feature. In the app I'm currently building there is some animation on the page before the chart loads. Currently I have to call destroy() and then setTimeout to refresh() when the animations on the page finish

@quantumwebco can you post a code example of how to do that? also looking for a workaround

@Geczy It's a bit complicated because I've created a recursive content component for Vue which turns JSON in to a vue component. In the JSON you can specify animations for anime.js, so if I have specified an animation.delay it immediately destroys the chart on page load and then refreshes it in a timeout based on the animation.delay property
Hopefully this helps you...
if (animation.delay) {
    chart.destroy();
    setTimeout(() => {
        chart.refresh();
    }, animation.delay);
}


add gpt4o model

Adds oai's latest models. Have not tested the vision capabilities; text works fine.

The output_price is incorrect.
gpt-4o points to gpt-4o-2024-05-13, so there's no need to add gpt-4o-2024-05-13 by convention.
#501 will add gpt-4o

nice thx!


Add prop enabled for KeyboardAvoidView document follow RN 0.54.

KeyboardAvoidingView have prop enabled and mark as required.

Can you make the changes to the 0.54 version as well?

I've done it.


This should let you query documents by century like you wanted, with the caveat that there is no standardization on the date format (e.g. this example has "date": "18th century" others instead have ca.1715orlate 13th\u201314th century`. The best way to address that is probably to clean it up and standardize it somewhere in the ETL pipeline before it ends up in Postgres.
I still need to stand up the replicator in our staging environment, so you won't see these changes quite yet.


Bug in Graph visualization

OrientDB Version, operating system, or hardware.

v.2.2.12

Operating System

[ ] Linux
[ ] MacOSX
[x] Windows
[ ] Other Unix
[ ] Other, name?

Expected behavior and actual behavior
If I create a two edge and both have the same source vertex and the same destionation vertex, I expect to see in the Graph editor two edge instead of one.

Steps to reproduce the problem
Create two edges between two vertexes, both edges must have the same source vertex and the same destination vertex.
Thx

Thanks @Bonizzi
let me check


[WIP]Add ED25519 implementation for EC-ElGamal.

The algorithm optimized in crypto/ec/curve25519.c is not used, the performance is relatively poor, do not merge for the time being

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Issue#1152

Implemented Recursion limit counter and added test case.

@bala-v09 there is a failure in ParserConstraintExpressionsTest. You should see this when you do a full build. Please fix.


Question: How to disable a mock namespace?

Hello,
I am using CPPUTest v4.0. In my tests, I mock two production code functions defined similarly to the following:
int time_now()
{
    mock("time").actualCall("time_now").returnIntValueOrDefault(0);
}

int spi_write(spi_t* spi_ptr)
{
    mock("spi").actualCall("spi_write")
               .withParameterOfType("spi_t", "spi_ptr", spi_ptr)
               .returnIntValueOrDefault(0);
}

The production code function I am testing is called cycle() which calls both of these mocked functions. However, I only care about verifying the behavior of the spi_write() function. In one test I am attempting the following, but I am getting a mock failure for unexpected calls to time_now().
TEST(test_spi_behavior, test1)
{
    mock("spi").expectOneCall("spi_write").withParameterOfType("spi_t", "spi_ptr", &spi_handle).andReturnValue(0);
    mock("time").disable();
    cycle();
}

Failures are also seen when using mock("time").ignoreOtherCalls(). I would like to be able to disable failing a test because of the 'unexpected calls' to time_now(). Is it possible to achieve this, but also have the mocked call to time_now() return the default value?

Shouldn't the spi_write have a return statement ?

Yes, that is a mistake in the example above for both the functions. However, is it possible to disable a specific mock nameplate?

Namespace? Yes, you can.


Reduce log level for log messages caused by client side input mistakes

I've lowered the log level for some logging that follows client side mistakes, such as a wrong MQTT version, not sending a client ID, or using incorrect credentials. When hosting a Moquette broker that is publicly available - so you don't have control over what clients are sending - the current log levels cause frequent error/warn logging which in turn can trigger alarms in monitoring solutions.
Closes #463

I don't think it's a good idea in general, since if you have a problem with a client and broker the first thing you do is to check for WARN logs on the broker side.
If you need to remove from appearing in such environment, do you think is more useful to raise up the log limit for the MQTTConnection logger in log4j.properties ?

Hi @andsel thanks for looking at this.
I don't agree. Because I think you assume the client is operated by the same party as the broker, and therefore this party can see the broker logs.
If you are hosting an MQTT broker and many different parties connect to your broker they can not see the broker logs (because it is hosted by - in this example - me) as the logs are not publicly available.
Logging authentication failures as error is then not useful for the clients because they can not see them, and it is not useful for the broker hoster as it causes a lot of noise in the logs and the broker host can not control what the clients are doing.

I understand you concerns, sounds reasonable

@PHameete thanks for contribution!

Thank you!


Support Qubit & Label Placeholders

pyQuil has the capability to insert placeholders for qubits and labels into a program, and quil-rs should support the same concept.
These have no analogue in Quil itself and no serialized form, but are an aid in the construction of valid Quil programs. Both serve as a reference which defers the assignment of a concrete value until later.
Labels
A label placeholder is useful for writing portions of a program in isolation without the concern that a label will conflict with labels in other parts of the program. This is especially important for support of dynamic control flow programs. Imagine that a user may want a program with multiple loops, each of which starts with a label @loop-start.
A label must be unique within a program, so if the user must assign a concrete label value at the time of label construction they must consider all labels already present within the program. With a placeholder, though, they can use Placeholder("loop-start") in several places, and allow the program to distinguish these prior to serialization - perhaps by adding a suffix.
Qubits
Similarly, a routine within a program may want to reference some set of qubits without yet resolving which ones those are. Like labels, this allows for qubits to be isolated to a particular scope within a program while remaining unique at the program scope.
API
Placeholders can be allocated as such:
QubitPlaceholder::new();
LabelPlaceholder::new("label");

They can then be used within the relevant enums. This will be a breaking change:
enum Qubit {
  Fixed(...),
  Variable(...),
  Placeholder(QubitPlaceholder)
}

enum Label {
  Fixed(String), // This is the existing use case, now as an enum variant
  Placeholder(LabelPlaceholder), // This is new
}

These placeholders cannot be resolved in isolation; they must be resolved within / by a Program. So add a relevant method:
impl Program {
  pub fn resolve_label_placeholders(&mut self) {
    // collect all the existing labels in the program, and then iterate through placeholders and resolve each one to a string label, appending a numeric suffix to make each unique as needed.
  }

  pub fn resolve_qubit_placeholders(&mut self) {
    // collect all the existing fixed qubits in the program and then iterate through, resolving each to the lowest-available fixed qubit index
  }

  pub fn resolve_placeholders(&mut self) {
    self.resolve_label_placeholders();
    self.resolve_qubit_placeholders();
  }
}

impl fmt::Display for Program {
   // ... resolve_placeholders is called prior to display, because there is no Quil-spec-defined way to serialize a label or qubit placeholder
}

A nice to have would be resolve_qubit_placeholders(&mut self, available: &impl Iter) so that the user can restrict the assigned qubits to e.g. physical qubit indices. (Should probably also return a Result.)

A nice to have would be resolve_qubit_placeholders_with(&mut self, available: &impl Iter) -> Result<()> (or maybe it takes a fn instead) so that the user can restrict the assigned qubits to e.g. physical qubit indices.

That seems useful. When it comes to a full function though, it would make sense for the user to just iterate over the program themselves - this resolution method is more of a convenience than a necessity, because the user will have the capability to iterate and resolve on the program directly.

@kalzoo Just to clarify, how are we going to resolve placeholders inside of the display implementation since it would require &mut self? Are we going to clone the program every time it's called?

Are we going to clone the program every time it's called?

This is what I had imagined, as unfortunate as that would be. Been thinking about how to be more clever about this within the existing API.
Another option - resolve placeholders within each instruction as they are displayed, without storing them back on the program.

Done in #266


ui5.userInteraction.clickListItem fails in one case

ui5.userInteraction.clickListItem doesn't work in one case on the demo page having StandardListItem (https://sapui5.hana.ondemand.com/1.99.0/#/entity/sap.m.List/sample/sap.m.sample.ListSelection).
When manually clicked, or if we do ui5.userInteraction.click checkbox is checked.
Through ui5.userInteraction.clickListItem, checkbox remains unchecked.

@heraldantony can we close this?


Search bar glitch

on editing a search, previous search glitches above it

I will try fix it tomorrow.


submodule fetch fails

On the rhcos branch:
$ git submodule update --init
error: Server does not allow request for unadvertised object 2e2164d47aea325d9a9eeae11053313ece332f41
Fetched in submodule path 'mantle', but it did not contain 2e2164d47aea325d9a9eeae11053313ece332f41. Direct fetching of that commit failed.
$ cat .git/config
...
[submodule "mantle"]
        active = true
        url = https://github.com/cgwalters/mantle

Originally I had that commit pointed at to by the 8gb-orig branch but that appeared not to work, so I just pushed it to master but that still doesn't work...

I found this StackOverflow thread which makes sense...but I do have refs pointing to the commit.

Of course since I took the time to write this up I figured it out; one needs to git submodule sync after switching branches which change a submodule's URL.

I found https://github.com/AppImage/AppImageKit/issues/511, which mentions trying out git submodule sync or using git submodule update --depth BIG_NUMBER.

Damn, 5 seconds.

None of the above suggestions worked for me. What did was looking at the commit history for /vendor and moving the head in my cloned repository to the last commit that passed all checks, which is currently 6a7b915d68976dd2db2417f3933f2fdafceeba3e. I then checkout out a new branch, and ran git submodule update --init --recursive and everything worked fine
...with the exception of the fact that I ran out of room on my liinux partition while running ./leksah-nix.sh, but that's unlikely to be a problem for you


[ FEAT ] Windows Support

Windows list files from directory.

Microsoft C++ Compiler Example
Microsoft C++ Compiler Compiler Options
Example: Compiling a single file Microsoft Compiler
cl /std:<c++version> /I <headers> /Fo"object file" <file-to-be-compiled>

Some useful compiler options:

Set C++ Version
/std:c++14 DOC

Tells where headers declarations are
/I path DOC

Tells to the compiler to threat all files as C++ files
/Tp  DOC

Tells to the compiler just compile, without linking
/c DOC

Tells the compiler to create an object file
/Fo DOC

Windows stat structure

Compile in windows, while, cmake is not set up.
cl /std:c++14 /I .\\include /Tp /c .\src\file.cpp file.obj
LINK file.obj ... /OUT:executable.exe

Windows find files in the directory


Handling form validators translation

A simple patch to avoid what i did in one of my projects (see : https://gist.github.com/1268288)
As the twig template is looking for "validators" translation domain, we must provide a way to handle them.

Looks good, needs some docs though.

To use this patch you simply have to follow the official doc at http://silex.sensiolabs.org/doc/providers/translation.html but in addition of $app['translator.messages'] (which handle app locales) you can use $app['translator.validators'] to handle forms validation messages translation.
The reason of this patch is simple : by default Symfony looks for the file Resources/translations/validators.[locale].yml wich should be part of your sf project bundle. But as a Silex app is not a Symfony bundle, we must tell Symfony where to reach this file.

Yes, this needs to be added to the translation doc though. ;-)

Bump.

Sorry for the mess, i tried to sync my fork with master repo but the result is far from what i expected.
What can i do to clean this up ?
I don't understand why the changes on my fork affects automatically this pull request.

Because this PR is based on your master branch. Any changes to your master branch will affect this PR. I can help you in the #symfony-dev channel on irc.freenode.net.

the [commit #ae4083d + gist snippet #1268288] combo works fine: I suggest to accept this PR.

But the gist was an example of what this PR should avoid us to do.
Now you can handle validators messages in the same way as the main locale files, for example:
$app['translator.validators'] = array(
    'en' => __DIR__.'/resources/locales/en.yml',
    'fr' => __DIR__.'/resources/locales/fr.yml',
);


Empty regexp examples

//.examples or Regexp.new('').examples results in:
NoMethodError: undefined method `empty?' for nil:NilClass
Should this be returning [''] instead?
Just trying to cover all scenarios! Thanks for the great work.

Ahh... Nice find, thanks! I must have missed this scenario in the tests.
Note that there is a similar edge case that is handled correctly:
/[^\d\D]/.random_example # => nil
/[^\d\D]/.examples # => []

I'll write a patch to handle this in the same way.

Sorry that took me a while to get round to this...
Fixed in: https://github.com/tom-lord/regexp-examples/pull/16
I'll release gem version 1.4.1 to include the fix.
Thanks again for the bug report 😄


Default label rotation upwards

Regarding issue #61 .
Old behavior:
using Graphs, GraphMakie
gc = circular_ladder_graph(5)
gcd = circular_ladder_graph(5) |> SimpleDiGraph

graphplot(gc, elabels = repr.(edges(gc)), nlabels=repr.(vertices(gc)) , elabels_rotation=nothing)
graphplot(gcd, elabels = repr.(edges(gcd)), nlabels=repr.(vertices(gcd)) , elabels_rotation=nothing)
graphplot(gcd, elabels = repr.(edges(gcd)), nlabels=repr.(vertices(gcd)) , elabels_rotation=nothing, curve_distance_usage=false)

New behavior:
graphplot(gc, elabels = repr.(edges(gc)), nlabels=repr.(vertices(gc)))
graphplot(gcd, elabels = repr.(edges(gcd)), nlabels=repr.(vertices(gcd)))
graphplot(gcd, elabels = repr.(edges(gcd)), nlabels=repr.(vertices(gcd)) , curve_distance_usage=false)

Passing in elabels_align will influence the result.
Passing in elabels_opposite will not influence the result. In my opinion this shouldn't be the case and I would propose to move the relative for loop outside the if-else statement. But this would mean that the "opposite" applies to the rotations handled in and it doesn't give out a particular opposite angle as it is now.

implemented in #73


HHH-11098 show problem with lots of attributeconversions

Added test that counts attributeconversions in a simple case. It shows that 1 save causes 2 to database conversions and 1 fromdatabase conversion which seems to be not neccessary and is causing a huge performance issue in my case.

The first commit was missing the interesting part. Sorry for that, now it should be ok.


On Hold - State Name Update - On Hold - Processing Fees

As an IAO user
I want to be able to know when a request is on hold for a processing fee vs another reason
so that I can better understand my requests

Assumptions & Scope
This is a simple update to the text for the on-hold state. This story will cover the scenarios for processing fees, but no other functionality will change.
What is IN scope?
Change to the state name "On-Hold"
What is NOT in scope?
All other functionality related to the On-Hold state for processing fees will remain the same.
Acceptance Criteria
Scenario 1: General Request - Fee Estimate State

GIVEN an IAO user is on a request in the fee estimate state
WHEN they activate the state drop down
THEN they will see the options: On Hold - Processing Fee, Call for Records, Closed

Scenario 2: Response State with Outstanding Balance

GIVEN an IAO user is on a general request in the response state
AND there is a balance of fees
WHEN they activate the state drop down menu
THEN they will see the options: On Hold - Processing Fee, Response, Closed

Scenario 3: xxxxxx
...
Dependencies? What is the impact of this dependency? (If so, link dependency in the ticket, make it visible in a team´s backlog)
Validation Rules? (If yes, list here)
Design
@xxx - please link the Design here
Definition of Ready

[ ] Is there a well articulated User Story?
[ ] Is there Acceptance Criteria that covers all scenarios (happy/sad paths)?
[ ] If there is a user interface, is there a design?
[ ] Does the user story need user research/validation?
[ ] Does this User Story needs stakeholder approval?
[ ] Design / Solution accepted by Product Owner
[ ] Is this user story small enough to be completed in a Sprint? Should it be split?
[ ] Are the dependencies known/ understood? (technical, business, regulatory/policy)
[ ] Has the story been estimated?

Definition of Done

[ ] Passes developer unit tests
[ ] Passes peer code review
[ ] If there's a user interface, passes UX assurance
[ ] Passes QA of Acceptance Criteria with verification in Dev and Test
[ ] Confirm Test cases built and succeeding
[ ] No regression test failures
[ ] Test coverage acceptable by Product Owner
[ ] Ticket ready to be merged to master or story branch
[ ] Developer to list Config changes/ Update documents and designs
[ ] Can be demoed in Sprint Review
[ ] Tagged as part of a Release
[ ] Feature flagged if required
[ ] Change Management activities done?

User story to address the fact that we now have multiple on hold states, to give specificity that a state is for processing fees.
I only captured AC related to the name of the state itself, all other functionality should remain the same. If we need to reflesh out the other AC related to fees, we can include in this ticket.
cc @lmullane

Assumption -> This is only the name change from "On Hold".
Estimation : 5

This is a 5 because of how many features are connected to the on-hold state as it exists, so the QA and testing lift will be higher.


Suggestion for code documentation

I would suggest adding some comments for each of the function. This will help improve maintainability as you will be able to take a look at the code in the future and still able to understand what each function do. In addition, the detailed documentation will make it easier for other developers to contribute to your project.
Example:
/**
 * What it does...
 * @param [name] {*} => desc of the param...
 * @return
 * etc.
 */
 function someFunctionName() {...}

This has been updated :) Thank you


Add proofs for portable compress module

This PR add full proofs for portable compress functions, the proofs support the new refined integers and it depend on the following hax branch https://github.com/hacspec/hax/tree/refined-ints-neg

Can you make this work without the refined-ints branch? That would make it easier to merge.

I can, but then we have to modify the code to support refined integers when experiment-refined-ints is merged for some changes like using mk_i16..

yes, so you can merge those changes into experiment-refined-ints, but the portable-compress could go straight into dev...

@karthikbhargavan @mamonet what's the state of this?

The changes made it to dev branch, I think we can close this PR.


Infinite rerender caused by nested components rendered from an ObserveArray

There seems to be a problem when rendering nested React components from a can-observe array if updated asynchronously.
Failing test here: https://github.com/bitovi/ylem/pull/159/

@BigAB @christopherjbaker @DesignByOnyx @justinbmeyer thanks for helping me track this down and find a workaround, fellas.

This is fixed due to #165 and #151, but I have been having some trouble re-creating it reliably, so I am waiting for @imaustink's assistance before I mark it as closed.


How is renderman for blender installed

Hi,
I just tried to follow the instructions. I d/l the PRMan-for-Blender-Master.zip and unzipped it in the addons folder. I keep getting an error message Unable to process "PRMan-for-Blender-master"
I then unzipped it into an empty folder on the desktop and moved the contents to the addons folder.
When I start blender and go to addons to enable it, I see the render: PRMan Render Engine. Trying to check the box right of the stick figure lists all these errors. I assume this has something to do with the Pixar file.
The README.md says to "download this project" but it's a zip file not a project.
The renderman file from Pixar doesn't do anything as it is an stl file so cannot be run like an exe could.
If anyone has some clear instructions on installing this, I'd really appreciate it.

Hello mknorr,
It sounds like you installed the blender add-on but not Renderman Pro Server. It is available from Pixar's site http://rendermansite.pixar.com/view/get-renderman. It would also be helpful to have as screen shot of the errors you are getting in Blender.
Have a great day,
MWY3510

Thanks for your reply MWY3510.
Yes, this is probably my issue. I don't know how to run it when it keeps insisting to save as an STL. I even downloaded it on my iPad and forwarded it as an email attachment. On the iPad it was an MSI but the attachment was an STL again. What type of file should it be and how do I show it in win7?

Great, let me know if you need any more assistance.

Still an issue?


add heuristics to guess volume when missing from location

the main euristics being that when there is only one volume, the outline node is in this volume even when it's not indicated. An example of missing volume indication is O1JM34CZ132122 in W27401

Similarly :workLocationEndVolume can be inferred to be equal :workLocationVolume.


Sahilnayak

This is for the starter. You don't need to create a pull request after creating your code, nor should you.

Sorry, I didnt mean to do the pull request. I was trying to figure out how
to get my code commits to show up in github.
On Tue, Nov 22, 2016 at 7:07 PM, Andrew Dassonville <
<EMAIL_ADDRESS>wrote:

This is for the starter. You don't need to create a pull request after
creating your code, nor should you.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/StephenGrider/ReduxSimpleStarter/pull/77#issuecomment-262425803,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AD-VbvcH1VyLE6ZMTCrOx43DDfp70aR6ks5rA64MgaJpZM4K6AKq
.


top 20 checks

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 70.307%

Totals

Change from base Build<PHONE_NUMBER>:
0.2%

Covered Lines:
2292

Relevant Lines:
3260

💛  - Coveralls

The modified script still works on the test files, but doesn't the preprocess_biopredict.py script need the same modification ?

The modified script still works on the test files, but doesn't the preprocess_biopredict.py script need the same modification ?

Sure, I'll do that as well


Check PrepareFilePath errors in remote-config flare provider

What does this PR do?
Check errors returned by PrepareFilePath in remote-config flare provider.
Motivation
The function can fail, in which case the returned path should not be used.
I noticed the following error log and tracked the error down to this.
pkg/flare/archive.go:116 in CompleteFlare) | Could not export remote-config state: rename ./3129576775 : no such file or directory

Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


接口存在xss漏洞 Cross-site scripting vulnerability

说明 Instruction
接口存在xss漏洞。 one page has xss vulnerability
影响范围 Sphere of influence
该漏洞允许远程攻击者在由 3xxx/engineercms 构建的网站上执行任意代码。 需要用户交互才能利用此漏洞，因为目标必须访问恶意页面。
This vulnerability allows remote attackers to execute arbitrary code on the website which builded by 3xxx/engineercms. User interaction is required to exploit this vulnerability in that the target must visit a malicious page .

@3xxx 建议尽快修复

谢谢，刚看到。


AddFile plugin

It seems that AddFile plugin adds static files, and has nothing to do with Drupal files belonging to media.  Can you please confirm?

That's correct. The AddMedia plugin adds Islandora/Drupal files.


make agg sum vectorized

gcc couldn't vectorize the sum loop if accumulator is class member instead of local variable.
eg: https://godbolt.org/z/hh84jP9f8
select sum(LO_CUSTKEY+1),sum(LO_CUSTKEY+2),sum(LO_CUSTKEY+3),sum(LO_CUSTKEY+4),sum(LO_CUSTKEY+5) from lineorder_flat;

before:
3.98
after:
2.63

online benchmark
https://quick-bench.com/q/CZRlNcb6YPnb6f3-aSQjyN8qISs

I have tried that if you set any one of param to __restrict__,  code will also be vectorized.
void batch_update3(int* __restrict__ res, int*  col,int size);
void batch_update3(int* res, int*  __restrict__ col,int size);


Model validation

Pull Request Test Coverage Report for Build 463

283 of 287 (98.61%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.3%) to 94.862%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

read.go
4
5
80.0%

production/production.go
0
3
0.0%

Totals

Change from base Build 459:
0.3%

Covered Lines:
2917

Relevant Lines:
3075

💛  - Coveralls


Resolved infinite loop for crate builds on Windows

This bug was introduced when cargo workspace support was introduced.
os.path.sep is "/" or "", which is fine for linux's root directory, but not windows. It would just keep returning "C:\" which isn't "/", resulting in an infinite while loop for any crate build.
The new check should be fully portable, even with different drive names.

Good catch - thanks for fixing :)


seh_chembl.csv

Does the seh_chembl.csv file contain the results from the GFlowNet model output? I am just checking if I am interpreting the CSV correctly.

Hi @thiviyanT-sony, no, in fact, I'm not entirely sure what this file is doing here. It doesn't seem to be used anywhere in the code. It may be an artifact from the codebase from which this repo was extracted.

Hi @bengioe,
Yes, you are correct. The file is not mentioned in your code.
From the column header, I thought it was part of the results.

[
    'Molecule ChEMBL ID',
    'Molecule Name',
    'Molecule Max Phase',
    'Molecular Weight',
    '#RO5 Violations',
    'AlogP',
    'Compound Key',
    'Smiles',
    'Standard Type',
    'Standard Relation',
    'Standard Value',
    'Standard Units',
    'pChEMBL Value',
    'Data Validity Comment',
    'Comment',
    'Uo Units',
    'Ligand Efficiency BEI',
    'Ligand Efficiency LE',
    'Ligand Efficiency LLE',
    'Ligand Efficiency SEI',
    'Potential Duplicate',
    'Assay ChEMBL ID',
    'Assay Description',
    'Assay Type',
    'BAO Format ID',
    'BAO Label',
    'Assay Organism',
    'Assay Tissue ChEMBL ID',
    'Assay Tissue Name',
    'Assay Cell Type',
    'Assay Subcellular Fraction',
    'Target ChEMBL ID',
    'Target Name',
    'Target Organism',
    'Target Type',
    'Document ChEMBL ID',
    'Source ID',
    'Source Description',
    'Document Journal',
    'Document Year',
    'Cell ChEMBL ID'
]

I am glad I checked this with you rather than assuming something. By any chance, do you still have access to the generated molecules from your model? If not, how do I reproduce the GFlowNet results for the molecule generation? Would this be sufficient python mols/gflownet.py?

I'm afraid not, but yes simply running python gflownet.py should replicate the original model and output the generated molecules. If you're interested in a more robust implementation of GFlowNets on fragments, I'd encourage you to also check out our new repo.


Any plan for support sonarcloud.io?

SonarCloud is online service base on SonarQube, Do you have any plan for support it?

It's a little bit different from the local SonarQube, it has a parameter called "organization".

Would you like to open a pull request?

Hi, thanks for your question. Would you like to open a pull request?

By the way, SonarCloud itself has badge plugin:
https://sonarcloud.io/api/badges/gate?key=WcfSoapLogger

When I tried Sonarcloud.io, I decided to drop the plan about this issue.

By the way, SonarCloud itself has badge plugin:
https://sonarcloud.io/api/badges/gate?key=WcfSoapLogger

It does not function with private repos.


Multiple Key Constraint validation not working

$this->validate($request, [
'url' => 'required|unique_with:table_xxx,project_id',
]);
QueryException:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'http://example.com' for key 'composite_constraint' (SQL: insert into table_xxx (url,project_id) values (http://example.com,1))

Looks good. What is the problem exactly?

there is a table named table_xxx.
and there are two fields in table
url
project_id (foreign_key)
In above code, i am adding validation for url field.
1.)which is required and as well
2.)there is a unique for (url,project_id).
QueryException:
SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry 'http://example.com' for key 'composite_constraint' (SQL: insert into table_xxx (url,project_id) values (http://example.com,1))
:)

Can you please provide the code that is supposed to work?
The rule 'url' => 'required|unique_with:table_xxx,project_id', looks good.

public function store(Request $request,FormBuilder $formBuilder,Project $project)
{
	$rules = array(
	     'url' => 'required|unique_with:tasks,project_id',
	 );

	 $validator = Validator::make(Input::all(), $rules);

	 if($validator->fails())
	 {
	     return Redirect::back()->withErrors($validator);
	 }

   if (!$form->isValid()) {
         return redirect()->back()->withErrors($form->getErrors())->withInput();
     }

}
after adding above validation, it throws above error.
I am using only above validation only, right now commented in my code.

Your code is confusing to me, where is $formBuilder coming from?
And you use $form, which isn't defined.
Anyway, the error message you've posted IMO indicates, that you may have a misconfigured UNIQUE index. Are you sure the UNIQUE index is for both fields (url + project_id) rather than just for url? Can you manually add these records to the table?

I think might i got the error. I haven't tested it yet.
Basically i am setting project_id from session, later on after validation.
And that's why i am getting that exception.
But i think that exception must be handled. Instead of showing error.
Yes i can add values from mysql admin.
Thanks
For your efforts. i will let you once i will resolve that.
On Tue, Oct 18, 2016 at 5:42 PM, Felix Kiss<EMAIL_ADDRESS>wrote:

Your code is confusing to me, where is $formBuilder coming from?
And you use $form, which isn't defined.
Anyway, the error message you've posted IMO indicates, that you may have a
misconfigured UNIQUE index. Are you sure the UNIQUE index is for both
fields (url + project_id) rather than just for url? Can you manually add
these records to the table?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/felixkiss/uniquewith-validator/issues/60#issuecomment-254488996,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AB8Cmd5dlgFFBRCz7oyIBekUIfKwrCY8ks5q1LedgaJpZM4KIdOp
.

--
Kind Regards : Vaibhav Arora (<PHONE_NUMBER>6 )