In HA mode, the master is down and cannot be consumed from the slave

ISSUE REPORT

Please describe the issue you observed:

What did you do (The steps to reproduce)?
step1. K8S使用operator部署HA模式集群1master&1slave
step1. K8S uses operator to deploy HA mode cluster 1master&1slave

step2. 往集群名为slave-test的topic写入一些数据
step2. Write some data to the topic of the cluster named slave-test

step3.模拟master宕机，关闭master节点
step3.  启动消费者服务，消费数据该topic数据
step4. Start the consumer service and consume data for the topic data

What is expected to see?
在master宕机的情况下，slave应当承担数据消费职责，不会影响rocketmq集群内topic的消息消费任务。
In the case of master downtime, the slave should assume the responsibility of data consumption and will not affect the message consumption task of topics in the rocketmq cluster.

What did you see instead?
消费者消费消息失败；
Consumer failed to consume message

nameserverF =
topicF = SELF_TEST_TOPIC
consumerGroupF = slave-test
producerGroupF = slave-test
time="2022-08-18T15:37:54+08:00" level=info msg="the consumer start beginning" consumerGroup=slave-test messageModel=Clustering unitMode=false
time="2022-08-18T15:37:54+08:00" level=info msg="the topic route info changed" changeTo="{\"OrderTopicConf\":\"\",\"queueDatas\":[{\"brokerName\":\"rocketmq-broker-0\",\"readQueueNums\":4,\"writeQueueNums\":4,\"perm\":6,\"topicSy
nFlag\":0}],\"brokerDatas\":[{\"cluster\":\"rocketmq-broker\",\"brokerName\":\"rocketmq-broker-0\",\"brokerAddrs\":{\"1\":\"<IP_ADDRESS>:23333\"}}]}" changedFrom="<nil>" topic=slave-test
time="2022-08-18T15:37:54+08:00" level=warning msg="query topic route from server error" underlayError="topic not exist"
time="2022-08-18T15:37:54+08:00" level=warning msg="queryTopicRouteInfoFromServer return nil" topic="%RETRY%slave-test"
time="2022-08-18T15:37:54+08:00" level=warning msg="query topic route from server error" underlayError="topic not exist"
time="2022-08-18T15:37:54+08:00" level=warning msg="queryTopicRouteInfoFromServer return nil" topic="%RETRY%slave-test"
time="2022-08-18T15:37:55+08:00" level=info msg="receive broker's notification to consumer group" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="do balance in group failed, the topic does not exist" consumerGroup=slave-test topic="%RETRY%slave-test"
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="do balance in group failed, the topic does not exist" consumerGroup=slave-test topic="%RETRY%slave-test"
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=0]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=1]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=2]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=warning msg="delete mq from offset table" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" consumerGroup=slave-test
time="2022-08-18T15:37:55+08:00" level=error msg="fecth offset of mq from broker error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" consumerGroup=slave-test underlayError="broker: rocke
tmq-broker-0 address not found"
time="2022-08-18T15:37:55+08:00" level=warning msg="query max offset error" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" underlayError="the broker [rocketmq-broker-0] does not exist"
time="2022-08-18T15:37:55+08:00" level=warning msg="do defaultConsumer, add a new mq failed" MessageQueue="MessageQueue [topic=slave-test, brokerName=rocketmq-broker-0, queueId=3]" consumerGroup=slave-test

Hi, @MrLYG two conditions need to be met for consumption from slave broker: 1. The configuration slavReadEnable must be true 2. It cannot be the consumption of order messages.

Hi, @MrLYG two conditions need to be met for consumption from slave broker: 1. The configuration slavReadEnable must be true 2. It cannot be the consumption of order messages.
Thanks a ton for your fastly reply.

The configuration slavReadEnable is true

I didn't open the consumption of order messages.

Hi, @MrLYG two conditions need to be met for consumption from slave broker: 1. The configuration slavReadEnable must be true 2. It cannot be the consumption of order messages.

@RongtongJin Thanks a ton for your fastly reply. I had met the two conditions that you gave. But the consumer still not consume from slave when master done.

The configuration slavReadEnable is true

I didn't open the consumption of order messages.

@MrLYG  Could you try whether the Java client has the same issue?

Hi, @MrLYG two conditions need to be met for consumption from slave broker: 1. The configuration slavReadEnable must be true 2. It cannot be the consumption of order messages.

@RongtongJin Thanks a ton for your fastly reply. I had met the two conditions that you gave. But the consumer still not consume from slave when master done.

The configuration slavReadEnable is true

I didn't open the consumption of order messages.

@MrLYG Could you try whether the Java client has the same issue?

The Java client can consume messages when the master has done.
That's this means the go client has some bug or problem?
If I need to use the go client to connect the rocektmq service, what should I do to avoid that problem? Could you give me some suggestions?

That's this means the go client has some bug or problem?
If I need to use the go client to connect the rocektmq service, what should I do to avoid that problem? Could you give me some suggestions?

IIRC, the latest version of rocketmq-client-go has fixed this issue. @guyinyou @ShannonDing Could you help to take a look？

That's this means the go client has some bug or problem?
If I need to use the go client to connect the rocektmq service, what should I do to avoid that problem? Could you give me some suggestions?

IIRC, the latest version of rocketmq-client-go has fixed this issue. @guyinyou @ShannonDing Could you help to take a look？

I used the latest version of rocketmq-client-go to consume messages from slave but still fail.

There is my go.mod file in which I require the latest version of rocketmq-client-go 2.1.1
module go-rocket

go 1.17

require github.com/apache/rocketmq-client-go/v2 v2.1.1

require (
	github.com/emirpasic/gods v1.12.0 // indirect
	github.com/golang/mock v1.3.1 // indirect
	github.com/json-iterator/go v1.1.12 // indirect
	github.com/konsorten/go-windows-terminal-sequences v1.0.1 // indirect
	github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 // indirect
	github.com/modern-go/reflect2 v1.0.2 // indirect
	github.com/patrickmn/go-cache v2.1.0+incompatible // indirect
	github.com/pkg/errors v0.8.1 // indirect
	github.com/satori/go.uuid v1.2.0 // indirect
	github.com/sirupsen/logrus v1.4.0 // indirect
	github.com/stathat/consistent v1.0.0 // indirect
	github.com/tidwall/gjson v1.13.0 // indirect
	github.com/tidwall/match v1.1.1 // indirect
	github.com/tidwall/pretty v1.2.0 // indirect
	go.uber.org/atomic v1.5.1 // indirect
	golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2 // indirect
	golang.org/x/lint v0.0.0-20190930215403-16217165b5de // indirect
	golang.org/x/sys v0.0.0-20220722155257-8c9f86f7a55f // indirect
	golang.org/x/tools v0.0.0-20191029041327-9cc4af7d6b2c // indirect
	gopkg.in/natefinch/lumberjack.v2 v2.0.0 // indirect
)


Errors should output to STDERR (bis)

Bug report

What is the current behavior?
Webpack prints everything to stdout, including errors.
It's a problem when webpack is used by another tool in a build process: that tool cannot extract the error messages, only detect that there was an error... or do some guesswork like "Upon non-zero exit code with empty stderr, let's use stdout", as I implemented for Rush, but the issue was reported by other tools, and it'd be better to fix it in Webpack itself.
See also #1278
If the current behavior is a bug, please provide the steps to reproduce.
See this reproducible test repo
Clone it, npm install, npm run build.

What is the expected behavior?
The build tool expects Webpack to print errors to stderr.

Other relevant information:
webpack version:  4.41.2
Node.js version: 12.13.1
Operating System: macOS Catalina
Additional tools: tools known to have a problem with that: Rush, webpacker (Ruby on Rails)

One might argue that this would be a breaking behavior change.
In that case, please consider turning this bug report into a feature request, to have webpack support an option to print errors to stderr, that other build tools would have to use, e.g. webpack --print-errors-to-stderr.

Thanks for heads up @webpack-bot … Here's a bump.
This would be so nice in Webpack 5.

Can this be reopened, thanks!

+1 for reopening.

basically you should use stats object

I think this is breaking change..

@vankop errors are part of stats printing, so it is expected to get them in stdout, stats object is not error, we still print errors in stderr, but only errors inside webpack, don't think we should change it

we still print errors in stderr

we don't do this ( at least this what issue about )


[SPARK-19756][SQL] drop the table cache after inserting into a data source table

What changes were proposed in this pull request?
When we inserting into a table, we should uncache it to avoid exposing stale data. This is the existing behavior for hive tables, see InsertIntoHiveTable, this PR fixes this problem for data source tables.
How was this patch tested?
new regression test

cc @gatorsmile

Test build #73541 has started for PR 17089 at commit 8bca8d3.

retest this please

Test build #73564 has started for PR 17089 at commit 8bca8d3.

Test build #73564 has finished for PR 17089 at commit 8bca8d3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/73564/
Test FAILed.


oauth2.Transport not found?

Since I have pulled in the new repository, I have been looking for what I need to import (or install) to get the Transport object available to my Go program.  Imports and snippet below.
import (
"fmt"
"net/http"
"net/mail"
"appengine"
newappengine  "appengine"
"google.golang.org/api/compute/v1"
"google.golang.org/api/oauth2/v1"
)
"appengine/urlfetch"client := &http.Client{
	Transport: &oauth2.Transport{
		Source: google.AppEngineTokenSource(ctx, compute.ComputeScope),
		Base:   &urlfetch.Transport{Context: ctx},
	},

This is frustrating because either I am not seeing certain things in the documentation, or it has not been updated?  I am probably missing something simple...
Did it used to be in here?    "golang.org/x/oauth2/google"
This seems to be the only import that I don't  have and cannot find from the new repository...
Thanks
Dave

You never imported oauth2.
It's still there: http://godoc.org/golang.org/x/oauth2#Transport

Oh, you imported "google.golang.org/api/oauth2/v1" (the auto-generated low-level APIs) instead of the high-level "golang.org/x/oauth2" package.

My code can't seem to find that package?
Thanks for you help!
Dave
mailbox.go:21: can't find import: "golang.org/x/oauth2"
------ Original Message ------
From: "Brad Fitzpatrick"<EMAIL_ADDRESS>To: "google/google-api-go-client"
<EMAIL_ADDRESS>Cc: "DaveSpaceNav"<EMAIL_ADDRESS>Sent: 8/26/2015 12:13:50 AM
Subject: Re: [google-api-go-client] oauth2.Transport not found? (#98)

Oh, you imported "google.golang.org/api/oauth2/v1" (the auto-generated
low-level APIs) instead of the high-level "golang.org/x/oauth2"
package.
—
Reply to this email directly or view it on GitHub.

go get golang.org/x/oauth2


Apply alloy-rs ABI encoding methods refactoring

uniswap-rs doesn't build following this refactoring in alloy-rs.

for future reference signed commits plz :)

Yes sorry about that, I was about to redo the PR :)


llext: sem EXPORT_SYMBOL not working in userspace

Describe the bug
Discovered on ARM qemu e.g. mps2/an385 while working on #70317, reproduceable with this branch and
west build -p -b mps2/an385 tests/subsys/llext/simple -- -DCONFIG_USERSPACE=y  && west build -t run

EXPORT_SYMBOL for k_thread_join, etc. working, semaphore not
Expected behavior
Export succeeds
Impact
Showstopper
Logs and console output
I printed out the contents of the built-in symbol table with and without userspace.
Without userspace:
assert_post_action
assert_print
k_is_in_isr
memcmp
memcpy
memset
printk
strcmp
strcpy
strlen
strncmp
strncpy
vprintk
z_impl_k_sem_give
z_impl_k_sem_init
z_impl_k_sem_take
z_impl_k_thread_create
z_impl_k_thread_join
z_impl_k_thread_start
z_log_minimal_printk
ztest_relative_filename
ztest_test_fail
ztest_test_pass
ztest_test_skip

With userspace:
assert_post_action
assert_print
k_is_in_isr
memcmp
memcpy
memset
printk
strcmp
strcpy
strlen
strncmp
strncpy
vprintk
z_arm_thread_is_in_user_mode
z_impl_k_thread_create
z_impl_k_thread_join
z_impl_k_thread_start
z_log_minimal_printk
z_mrsh___posix_clock_get_base
z_mrsh___ztest_set_test_phase
z_mrsh___ztest_set_test_result
z_mrsh_device_get_binding
z_mrsh_device_is_ready
z_mrsh_gpio_get_pending_int
z_mrsh_gpio_pin_configure
z_mrsh_gpio_pin_get_config
z_mrsh_gpio_pin_interrupt_configure
z_mrsh_gpio_port_clear_bits_raw
z_mrsh_gpio_port_get_direction
z_mrsh_gpio_port_get_raw
z_mrsh_gpio_port_set_bits_raw
z_mrsh_gpio_port_set_masked_raw
z_mrsh_gpio_port_toggle_bits
z_mrsh_k_busy_wait
z_mrsh_k_condvar_broadcast
z_mrsh_k_condvar_init
z_mrsh_k_condvar_signal
z_mrsh_k_condvar_wait
z_mrsh_k_event_clear
z_mrsh_k_event_init
z_mrsh_k_event_post
z_mrsh_k_event_set_masked
z_mrsh_k_event_set
z_mrsh_k_event_wait_all
z_mrsh_k_event_wait
z_mrsh_k_float_disable
z_mrsh_k_float_enable
z_mrsh_k_futex_wait
z_mrsh_k_futex_wake
z_mrsh_k_is_preempt_thread
z_mrsh_k_msgq_alloc_init
z_mrsh_k_msgq_get_attrs
z_mrsh_k_msgq_get
z_mrsh_k_msgq_num_free_get
z_mrsh_k_msgq_num_used_get
z_mrsh_k_msgq_peek_at
z_mrsh_k_msgq_peek
z_mrsh_k_msgq_purge
z_mrsh_k_msgq_put
z_mrsh_k_mutex_init
z_mrsh_k_mutex_lock
z_mrsh_k_mutex_unlock
z_mrsh_k_object_access_grant
z_mrsh_k_object_alloc_size
z_mrsh_k_object_alloc
z_mrsh_k_object_release
z_mrsh_k_pipe_alloc_init
z_mrsh_k_pipe_buffer_flush
z_mrsh_k_pipe_flush
z_mrsh_k_pipe_get
z_mrsh_k_pipe_put
z_mrsh_k_pipe_read_avail
z_mrsh_k_pipe_write_avail
z_mrsh_k_poll_signal_check
z_mrsh_k_poll_signal_init
z_mrsh_k_poll_signal_raise
z_mrsh_k_poll_signal_reset
z_mrsh_k_poll
z_mrsh_k_queue_alloc_append
z_mrsh_k_queue_alloc_prepend
z_mrsh_k_queue_cancel_wait
z_mrsh_k_queue_get
z_mrsh_k_queue_init
z_mrsh_k_queue_is_empty
z_mrsh_k_queue_peek_head
z_mrsh_k_queue_peek_tail
z_mrsh_k_sched_current_thread_query
z_mrsh_k_sem_count_get
z_mrsh_k_sem_give
z_mrsh_k_sem_init
z_mrsh_k_sem_reset
z_mrsh_k_sem_take
z_mrsh_k_sleep
z_mrsh_k_stack_alloc_init
z_mrsh_k_stack_pop
z_mrsh_k_stack_push
z_mrsh_k_str_out
z_mrsh_k_thread_abort
z_mrsh_k_thread_create
z_mrsh_k_thread_custom_data_get
z_mrsh_k_thread_custom_data_set
z_mrsh_k_thread_deadline_set
z_mrsh_k_thread_join
z_mrsh_k_thread_name_copy
z_mrsh_k_thread_name_set
z_mrsh_k_thread_priority_get
z_mrsh_k_thread_priority_set
z_mrsh_k_thread_resume
z_mrsh_k_thread_stack_alloc
z_mrsh_k_thread_stack_free
z_mrsh_k_thread_stack_space_get
z_mrsh_k_thread_start
z_mrsh_k_thread_suspend
z_mrsh_k_thread_timeout_expires_ticks
z_mrsh_k_thread_timeout_remaining_ticks
z_mrsh_k_timer_expires_ticks
z_mrsh_k_timer_remaining_ticks
z_mrsh_k_timer_start
z_mrsh_k_timer_status_get
z_mrsh_k_timer_status_sync
z_mrsh_k_timer_stop
z_mrsh_k_timer_user_data_get
z_mrsh_k_timer_user_data_set
z_mrsh_k_uptime_ticks
z_mrsh_k_usleep
z_mrsh_k_wakeup
z_mrsh_k_yield
z_mrsh_log_buffered_cnt
z_mrsh_log_filter_set
z_mrsh_log_frontend_filter_set
z_mrsh_log_panic
z_mrsh_log_process
z_mrsh_sys_clock_hw_cycles_per_sec_runtime_get
z_mrsh_sys_clock_tick_set
z_mrsh_uart_config_get
z_mrsh_uart_configure
z_mrsh_uart_drv_cmd
z_mrsh_uart_err_check
z_mrsh_uart_irq_err_disable
z_mrsh_uart_irq_err_enable
z_mrsh_uart_irq_is_pending
z_mrsh_uart_irq_rx_disable
z_mrsh_uart_irq_rx_enable
z_mrsh_uart_irq_tx_disable
z_mrsh_uart_irq_tx_enable
z_mrsh_uart_irq_update
z_mrsh_uart_line_ctrl_get
z_mrsh_uart_line_ctrl_set
z_mrsh_uart_poll_in
z_mrsh_uart_poll_in_u16
z_mrsh_uart_poll_out
z_mrsh_uart_poll_out_u16
z_mrsh_uart_rx_disable
z_mrsh_uart_rx_enable
z_mrsh_uart_rx_enable_u16
z_mrsh_uart_tx_abort
z_mrsh_uart_tx
z_mrsh_uart_tx_u16
z_mrsh_z_log_msg_simple_create_0
z_mrsh_z_log_msg_simple_create_1
z_mrsh_z_log_msg_simple_create_2
z_mrsh_z_log_msg_static_create
z_mrsh_z_sys_mutex_kernel_lock
z_mrsh_z_sys_mutex_kernel_unlock
z_mrsh_z_test_1cpu_start
z_mrsh_z_test_1cpu_stop
z_mrsh_zephyr_fputc
z_mrsh_zephyr_fwrite
z_mrsh_zephyr_read_stdin
z_mrsh_zephyr_write_stdout
z_mrsh_ztest_run_test_suites
z_mrsh_ztest_set_assert_valid
z_mrsh_ztest_set_fault_valid
ztest_relative_filename
ztest_test_fail
ztest_test_pass
ztest_test_skip

Environment (please complete the following information):

OS: Ubuntu 22
Toolchain: Zephyr SDK
3b36911

Tagging in @edersondisouza @teburd mentioned you recently made an update to export all syscalls in userspace

Hi @laurenmurphyx64 - can you check if reverting 67bb6db3f8e5329516f005f1335bb7a23a95b3eb does help?

Hi @laurenmurphyx64 - can you check if reverting 67bb6db does help?

Reverted, doesn't help. I noticed this on a branch created before you merged that - probably should've mentioned it.

Aha, know what is going on. Stay tuned, I'll have a PR that can help - tested here, and it works for your branch.


Wrong link added in navbar brands logo

Describe the bug
Hey, @AshutoshDash1999 I can see that the link added in the navbar brand is not correct and needs to be corrected. Please assign me this issue. Thank you!
Expected behaviour
The link should redirect to the home page.
Screenshots
It is redirecting to this page.

Additional context
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

link added in the navbar brand is not correct

Why do you think it's wrong?

The link should redirect to the home page.

We only have a single page!

You can check by clicking on the logo @AshutoshDash1999
I have attached the screenshot where it is redirected

You can check by clicking on the logo @AshutoshDash1999
I have attached the screenshot where it is redirected

It's correct. Bookingjini is our official site. This repo is one of our product.

Ohh ok... sorry for misunderstanding


Arrange the ossl-nghttp3-demo-server.c to run with the client demo.

While implementing with the API I have 2 problems:

Sometime select() return events that are processed internally and nothing is reported by SSL_poll()
It is no easy to find when to finish a h3connection (nghttp3_conn):

sometimes SSL_poll() reports:

SSL_POLL_EVENT_ECD and/or SSL_POLL_EVENT_EC
SSL_POLL_EVENT_ER on the streams open by the client (not on the bidi)
both the above.

Is there a way to find that the client is gone? (like with the connection is cut)?

Testing with chrome is limited to the number of streams configured (after a few request the server exit

@vdukhovni please reconfirm

Squashed and merged to the feature branch. Thank you for your contribution.


Installation is fragile due to old pip and virtualenv

Currently it is a little fragile to install the framework since we depend on old version of pip and virtualenv that are available with Ubuntu 12.04 (even 14.04 does not have the latest)

a solution implemented in #24


target netstandard2.0

First of all, thank you for making this library 👏
In a .net core project, the dependencies that netstandard1.0 brings in were causing us problems. Thought this might be useful to other folks as well.
Would completely understand if you don't want to merge, we can maintain an internal fork instead.
changes:
run upgrade-assistant, target netstandard2.0 only
remove unreference file (TestExtentions.cs)
set version to 0.8

Looks like README.md will need to be updated, too


PlotWidget tick labels are all the same for very small data range

To reproduce:
from silx import sx
sx.plot((0, 1), (0, 1e-9))

Related to https://gitlab.esrf.fr/bliss/bliss/-/issues/4059

Ideally if a scientific mode + offset can be enabled automatically when the displayed range is weird, it would be nice.

This is actually the case for matplolib:

offset is only used if it saves at least 4 digits by default
trigger of using scientific notation can be configured, default is for absolute value < 10^-5 and > 10^6

Now, when both are combined like for sx.plot((0, 1), (10, 10+1e-9)), it is hard to parse visually:

But there is a useMathText mode that makes it better:

I consider switching to: enable useOffset + scientific notation (with default "power limits") + useMathText for matplotlib versions that supports all of this and to leave everything disabled for older version.
What do you think?


Dataset for help?

Hello, I'm a graduate student from Chinese mainland Tianjin University of Technology.
I saw your published paper "FourierKAN-GCF: Fourier Kolmogorov-Arnold Network - An
Effective and Efficient Feature Transformation for Graph
Collaborative Filtering"
I want to study your code, but the data set can't find the format consistent with the requirements in your code.
So I want to ask, what should I do with the data set downloaded from the data set web page provided in the paper?
If so, can you send me a copy of what you use?
ValueError: File /home/wxd2zrx/document/FKAN-GCF-main/data/mooc.inter not exist

Hello, I'm a graduate student from Chinese mainland Tianjin University of Technology.
I saw your published paper "FourierKAN-GCF: Fourier Kolmogorov-Arnold Network - An Effective and Efficient Feature Transformation for Graph Collaborative Filtering"
I want to study your code, but the data set can't find the format consistent with the requirements in your code.
So I want to ask, what should I do with the data set downloaded from the data set web page provided in the paper?
If so, can you send me a copy of what you use?
ValueError: File /home/wxd2zrx/document/FKAN-GCF-main/data/mooc.inter not exist

Dear Wang,
Many thanks for your interests,
You are getting your hands dirty on the code and datasets.
The original MOOC datasets we used for recommendation are as follows : HRL
moocdata.cn holds the detailed logs of MOOC dataset.
For Amazon datasets, please handle it by RecBole.
Best,

I would like to ask, what pyhton libraries have you used?


NS_HTTP_PROVIDERS angular rc4 with<EMAIL_ADDRESS>still problem

If you just import NS_HTTP_PROVIDERS and set on your bootstrap, you won't pass through the Typescript compiler and will get this error:
Found peer TypeScript 1.8.10
node_modules/nativescript-angular/http/ns-http.d.ts(8,22): error TS2415: Class 'NSHttp' incorrectly extends base class 'Http'.
  Types of property 'get' are incompatible.
    Type '(url: string, options?: RequestOptionsArgs) => Observable<any>' is not assignable to type '(url: string, options?: RequestOptionsArgs) => Observable<Response>'.
      Type 'Observable<any>' is not assignable to type 'Observable<Response>'.
        Property 'source' is protected but type 'Observable<T>' is not a class derived from 'Observable<T>'.

To check this bug, follow these steps:
tns create myapp --template tns-template-hello-world-ng

Then, import NS_HTTP_PROVIDERS:
import {NS_HTTP_PROVIDERS} from 'nativescript-angular/http';
nativeScriptBootstrap(AppComponent, [NS_HTTP_PROVIDERS])

So try add a platform and run:
tns platform add ios
tns run ios --emulator

Temporary solution

If you've set compilerOptions to false on tsconfig.json, the tsc will ignore it, and your app will run great. (Even if you use Http service).

I believe something related to the declaration on node_modules/nativescript-angular/http/ns-http.d.ts that doesn't follow with the angular rc-4.

Thanks @leocaseiro I can confirm this report.
@vakrilov If you instead use "nativescript-angular": "next", in your package, all is good to go.
So it appears 0.3.0 does not include the latest :-/

Hi @NathanWalker, thanks for your reply.
There're 2 versions of 0.3.1: 0.3.1-2016-08-04-787 and 0.3.1-2016-08-08-788
However, they both give me the same error.
Unfortunately, I'm getting the same issue.

Here is my package.json:
{
  "description": "NativeScript Application",
  "license": "SEE LICENSE IN <your-license-filename>",
  "readme": "NativeScript Application",
  "repository": "<fill-your-repository-here>",
  "nativescript": {
    "id": "org.nativescript.nghttp",
    "tns-ios": {
      "version": "2.2.0"
    }
  },
  "dependencies": {
    "@angular/common": "2.0.0-rc.4",
    "@angular/compiler": "2.0.0-rc.4",
    "@angular/core": "2.0.0-rc.4",
    "@angular/http": "2.0.0-rc.4",
    "@angular/platform-browser": "2.0.0-rc.4",
    "@angular/platform-browser-dynamic": "2.0.0-rc.4",
    "@angular/platform-server": "2.0.0-rc.4",
    "@angular/router": "3.0.0-beta.2",
    "@angular/router-deprecated": "2.0.0-rc.2",
    "nativescript-angular": "0.3.1-2016-08-04-787",
    "reflect-metadata": "^0.1.5",
    "tns-core-modules": "2.2.0"
  },
  "devDependencies": {
    "nativescript-dev-typescript": "^0.3.2",
    "typescript": "^1.8.10"
  }
}

I've updated to the newest<EMAIL_ADDRESS>

Try clearing node_modules and platforms then setup again with that 'next' tag.

I did exactly that here and have no issues using the 'next' tag and rc.4

I was about to post it here.
I remove the platform and added again and works fine.
Many thanks for that!
I wonder if it'll be safe to use the next version. I'll perhaps set hard coded to use<EMAIL_ADDRESS>

I would personally like to see weekly releases of 'nativescript-angular' but until that happens I will be using 'next' tag with everything myself. Too many important and valuable things go into master at every commit from what I've seen to not be using latest.

I hit this one in Groceries, and unfortunately I can’t seem to make the problem go away. I tried using next after clearing out my node_modules, platforms, and so forth and I can’t get this error to go away.
Regardless, I can’t update the Getting Started tutorial to use next, so this is a blocking issue for me upgrading the tutorial to {N} 2.2 and Angular RC 4. A 0.3.1 release with a fix would be great 😄

I was able to reproduce @leocaseiro's original issue (the compile time error) using the official 0.3.0 release on a new project after importing NSHttp. I also saw another error about Observable<Response> not having a map method.
I deleted my node_modules and the original error disappeared, but the map one still remains. I found this SO question which suggests importing rxjs/Rx somewhere in order to fix this (the map method is defined in a separate TS module that needs to be imported). That fixed the error for me and http now works fine.
I wonder if adding an import for rxjs/Rx in say nativescript-angular/application will fix this for everyone.
@tjvantoll I don't get that error with the Groceries master branch. Do I need to look somewhere else?

Hi @hdeshev, thanks for that!
I'm almost sure you want to test on angular-end branch of Groceries.
In regards to rxjs/Rx, I'm always including the libraries I need, depending on the Class or Component, but I'm not really keen with the idea of including the whole rxjs/Rx library. I believe it would take a lot of MB from my app with no reason...

I'm not really keen on the idea of including the whole rxjs/Rx library. I believe it would take a lot of MB from my app with no reason...

Yep, I believe that's the problem that the "import 'rxjs/add/operator/...'" is trying to solve. It's probably a good idea to let people import either rxjs/Rx or the single operator module, if they are going after a lean distribution.

@hdeshev: @leocaseiro is correct; it’s the angular-end branch that I’m having this problem on, which is the end state of the getting started tutorial.
I can try the RxJS workarounds, but I’m always hesitant to put any workarounds or hacks into the tutorials, so I’ll almost certainly just wait for a 0.3.1 release.

Bizarrely I’m still getting the same TypeScript error even after upgrading to 0.3.1, which makes me suspect that I’m hitting some sort of odd caching problem. I tried clearing my npm cache, and also rebuilding my node_modules, and platforms folder, but I’m still not having any luck. Is anyone one else having this problem with 0.3.1 still, or is it just me?

@tjvantoll You may need to upgrade to rc.4 on the angular branch of groceries:
https://github.com/NativeScript/sample-Groceries/blob/angular-end/package.json#L28
Your deps should match this:
https://github.com/NativeScript/nativescript-angular/blob/master/ng-sample/package.json#L29-L37

@NathanWalker Yep. I did that as part of the update. Here are the full steps I’m taking:

git clone https://github.com/NativeScript/sample-Groceries.git
cd sample-Groceries
Switch to use this package.json
tns install
tns run ios

@tjvantoll
I can confirm the problem 0.3.1 still does not contain latest.
@vakrilov Please release 0.3.2 with latest.
@tjvantoll, also note this:
You will need to change this:
https://github.com/NativeScript/sample-Groceries/blob/angular-end/app/main.ts#L2
to this:
import {NS_HTTP_PROVIDERS} from "nativescript-angular/http";

And this:
https://github.com/NativeScript/sample-Groceries/blob/angular-end/app/main.ts#L8
to this:
nativeScriptBootstrap(AppComponent, [NS_HTTP_PROVIDERS, APP_ROUTER_PROVIDERS]);

See this to learn more:
https://github.com/NativeScript/nativescript-angular/wiki/Http

Worth noting again using the next tag does solve it to prove that the latest is not in 0.3.1.
Please release 0.3.2 asap, many folks need this and mention this issue :/

@leocaseiro please reopen this issue and rename to:
NS_HTTP_PROVIDERS angular rc4 with<EMAIL_ADDRESS>still problem Need 0.3.2 asap

@NathanWalker Thanks for taking the time to confirm this!

OK,
So the fix #408 fix is definitely in the 0.3.1. And when I got the error too:
node_modules/nativescript-angular/http/ns-http.d.ts(8,22): error TS2415: Class 'NSHttp' incorrectly extends base class 'Http'.
  Types of property 'get' are incompatible.
    Type '(url: string, options?: RequestOptionsArgs) => Observable<Response>' is not assignable to type '(url: string, options?: RequestOptionsArgs) => Observable<Response>'.
      Type 'Observable<Response>' is not assignable to type 'Observable<Response>'.
        Property 'source' is protected but type 'Observable<T>' is not a class derived from 'Observable<T>'.

Notice the problematic type is Observable<Response> not Observable<any> as in the original error (from 0.3.0).
However,Type 'Observable<Response>' is not assignable to type 'Observable<Response>'.  makes no sense to me. More over in the Observable import statement in:
<EMAIL_ADDRESS>and
node_modules\nativescript-angular\http\ns-http.d.ts
seem to be identical. Will investigate further ...

Thanks @vakrilov for investigation. Yeah, this one seems confusing.
What is curious is that using next tag works great, so I just assume that the latest is not released since next tag works fine?

@NathanWalker  @vakrilov  i am having different problem with the next tag and next version. when i use next tag or use tns plugin add nativescript-angular@next to upgrade my "nativescript-angular" and after i change my main.ts with
import {NS_HTTP_PROVIDERS} from "nativescript-angular/http";
nativeScriptBootstrap(AppComponent, [NS_HTTP_PROVIDERS, APP_ROUTER_PROVIDERS]);
my app wont open and i get this following error
java.lang.RuntimeException: Unable to create application com.tns.NativeScriptApplication: com.tns.NativeScriptException:
Error calling module function
TypeError: global.moduleMerge is not a function
File: ", line: 1, column: 265
StackTrace:
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/utils/utils.js', line: 3, column: 8
Frame: function:'require', file:'', line: 1, column: 266
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/file-system/file-system-access.js', line: 2, column: 13
Frame: function:'require', file:'', line: 1, column: 266
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/file-system/file-system.js', line: 1, column: 86
Frame: function:'require', file:'', line: 1, column: 266
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/nativescript-angular/file-system/ns-file-system.js', line: 2, column: 21
Frame: function:'re

Update:
Workaround
First of all the workaround that worked for me was to add rxjs dependency in the project's package.json:
"dependencies": {
  "rxjs": "5.0.0-beta.6",
   ...
},

Clean node_modules and do fresh npm install after.
The Problem
I think the problem is that the nativescript-angular package has a hard dependency on rxjs. So after the npm install I ended up with 2 copies of rxjs:

node_modules/rxjs - because of @angular/code peerDependency
node_modules/nativescript-angular/node_modules/rxjs - because of the ns-angular dependency

The typescript compiler uses different Observable definitions for nativescript-angular/http and @angular/http and throws the weird error.
If you have dependency to rxjs in your app's package.json, npm uses that and doesn't download a second copy of it inside node_modules/nativescript-angular/node_modules. This probably depends on the node/npm versions. My setup: node<EMAIL_ADDRESS>The Solution
Probably using peerDependency to rxjs (and the others like 'zone.js' etc.) in the nativescript-angular and include those as dependencies in the project-template will fix the problem.
We need to test that to be sure it works. I the meantime - you can test if the workaround above works.
CC @NathanWalker @tjvantoll

@vakrilov  i tried using your workaround delete node modules and platforms add the necessary dependencies to package and added the NS_HTTP_PROVIDERS to my main.ts but after prepare and build the project i still get the following error as soon as may app opens
ava.lang.RuntimeException: Unable to create application com.tns.NativeScriptApplication: com.tns.NativeScriptException:
Error calling module function
TypeError: global.moduleMerge is not a function
File: ", line: 1, column: 265
StackTrace:
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/utils/utils.js', line: 3, column: 8
Frame: function:'require', file:'', line: 1, column: 266
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/file-system/file-system-access.js', line: 2, column: 13
Frame: function:'require', file:'', line: 1, column: 266
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/file-system/file-system.js', line: 1, column: 86
Frame: function:'require', file:'', line: 1, column: 266
Frame: function:'', file:'/data/data/org.nativescript.platformtest/files/app/tns_modules/nativescript-angular/file-system/ns-file-system.js', line: 2, column: 21
Frame: function:'re
if i dont add the NS_HTTP_PROVIDERS to my main.ts and use HTTP_PROVIDERS instead my app opens but get the following error when i try to use http request
com.tns.NativeScriptException:
Calling js method onClick failed
EXCEPTION: Error in pages/login/login.html:6:49
ORIGINAL EXCEPTION: Error: not implemented
ORIGINAL STACKTRACE:
Error: not implemented
at NativeScriptDomAdapter.Parse5DomAdapter.getCookie (/data/data/org.nativescript.platformtest/files/app/tns_modules/@angular/platform-server/src/parse5_adapter.js:619:68)
at CookieXSRFStrategy.configureRequest (/data/data/org.nativescript.platformtest/files/app/tns_modules/@angular/http/src/backends/xhr_backend.js:150:82)
at XHRBackend.createConnection (/data/data/org.nativescript.platformtest/files/app/tns_modules/@angular/http/src/backends/xhr_backend.js:165:28)
at httpRequest (/data/data/org.nativescript.platformtest/files/app/tns_modules/@angular/http/src/http.js:22:20)
at Http.post (/data/data/org.nativescript.platformtest/files/app/tns_modules/@angular/http/src/http.js:78:16)
at UserService.login (/data/data/org.nativescript.platformtest/files/app/pages/shared/user/user_service.js

@tomylee001001 That looks like another issue (NativeScript/NativeScript#143). Can you make sure that nativescript-angular/application is the first import in you application (app.ts or main.ts file). If that doesn't help can you post some of you code so that we can reproduce the issue (you can do it in #397).

@vakrilov, @tomylee001001 That solved the problem for me - nativescript-angular/application was not the first import. But after when placing it first the problem with global.moduleMerge... went away! Thanks!

@vakrilov: Explicitly adding rxjs to my dependencies indeed worked. Thanks so much!

@vakrilov Any concerns with merging this in? https://github.com/NativeScript/template-hello-world-ng/pull/22

@vakrilov  placing the import {nativeScriptBootstrap} from "nativescript-angular/application"; first in my main.ts solve this error for me.

Closing since the problem should be resolved with 2.0.0 final and the NativeScriptHttpModule that sets up providers for you.


Create histogram for popularities of all symbols

The histogram should support going back in time and viewing the popularities at some point in the past, and the bars should be animated when they change because that would be cool.

Depends on #31


Update screenshot for metadata options page

Summary
This is a…

[x] Correction
[ ] Addition
[ ] Restructuring
[ ] Minor / simple change (like a typo)
[ ] Other

Reason for the Change
Screen changed.
Description of the Change
Update screenshot for metadata options page.
Additional Action Required
None.

Will include new image on same PR as the documentation changes.


Rustc 1.70 clashing with latest clap (4.5.4)

Hi! While solving the Redis challenge with Rust I got this error after I pushed to the server.
I'm sure I can fix it for now, as I just need to use a previous version of clap, but it might be useful for you to know that some packages now don't support 1.70 any more.
remote: [build] >   Downloaded clap v4.5.4
remote: [build] > error: package `clap_derive v4.5.4` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0
remote: [build] > Either upgrade to rustc 1.74 or newer, or use
remote: [build] > cargo update -p<EMAIL_ADDRESS>--precise ver
remote: [build] > where `ver` is the latest version of `clap_derive` supporting rustc 1.70.0
remote: [build] Error: process "/bin/sh -c cargo build --release --target-dir=/tmp/codecrafters-redis-target" did not complete successfully: exit code: 101.
remote: [build] >   Downloaded clap_lex v0.7.0
remote: [build] >   Downloaded bytes v1.3.0
remote: [build] >   Downloaded cfg-if v1.0.0
remote: [build] >   Downloaded autocfg v1.1.0
remote: [build] >   Downloaded anstyle-parse v0.2.4
remote: [build] >   Downloaded clap v4.5.4
remote: [build] > error: package `clap_derive v4.5.4` cannot be built because it requires rustc 1.74 or newer, while the currently active rustc version is 1.70.0
remote: [build] > Either upgrade to rustc 1.74 or newer, or use
remote: [build] > cargo update -p<EMAIL_ADDRESS>--precise ver
remote: [build] > where `ver` is the latest version of `clap_derive` supporting rustc 1.70.0
remote: [build] Build failed. Check the logs above for the reason.
remote: [build] If you think this is a CodeCrafters error, please contact us at<EMAIL_ADDRESS>
Should you need to replicate, my current Cargo.toml is
[package]
name = "redis-starter-rust"
version = "0.1.0"
authors = ["Codecrafters<EMAIL_ADDRESS>edition = "2021"

[dependencies]
anyhow = "1.0.59"                                   # error handling
bytes = "1.3.0"                                     # helps manage buffers
clap = { version = "4.5.4", features = ["derive"] }
thiserror = "1.0.32"                                # error handling
tokio = { version = "1.23.0", features = ["full"] } # async networking

Thanks!

I experimented with different toolchains, however apparently there is a long standing issue in Cargo, and it's not easy to install a previous version of the package clap. This means that with the current setup it is not possible to use the package, I believe.
Any suggestion? Thanks!

Thanks @rohitpaulk!


Fix Windows not copying globs or directories

Fixes #2111,
An alternative approach would be to remove the UNC prefix as mentioned in https://github.com/rust-lang/glob/issues/132, which I can implement if people prefer.

@rylev This is still blocked - I would like to get it into 2.1 if we can - do you still have concerns?


Make tables fully expanded by default? Or redesign scroll to be more obvious?

In browsers like chrome the scroll bar is not visible at all times, meaning that for docs components like our tables, it is not obvious to users that they need to scroll on the table to see all the options:
https://github.com/Qiskit/qiskit_sphinx_theme/assets/23662430/ae8730fb-155f-4284-a573-726001a3c9d8
There are 2 options we could pursue to improve this:
a) we could make the tables completely expanded by default, so no scrolling is needed to see all the rows. This might not work well if there are some very long pages with long tables
b) we restyle the scroll bar so that it is always visible

When triaging, we should check the behavior with Furo. We're aiming to switch to Furo soon, so it may be okay to only target Furo and not worry about Pytorch.

In terms of scroll bar being always visible - this is what I have for Nature in Firefox and when there is no scrolling needed it just adds clutter.

The other thing which would be nice is if the contents filled the area and maybe were even consistent on the column widths.

Furo leaves all these tables fully expanded:

Which is fine with me unless there are extremely long tables on a page. We may also want to style it in the alternating row colors it currently has.

On macOS Chrome for me with Furo, the scroll bar shows up if the table is too big. Otherwise it's not showing.

I believe this is desirable behavior. We're hoping to get out Furo by the end of June, so I'm closing this as won't fix for Pytorch.
I opened https://github.com/Qiskit/qiskit_sphinx_theme/issues/378 to track if we want to add alternating colors to tables in Furo.


Added hooks and added a success flag

https://github.com/olexale/bdd_widget_test/issues/52
Also added a success flag to the afterEach.

Thank you so much for this PR, I'll review it during the weekend 🙏
@lsaudon, you might want to check this out too as you proposed this functionality in the first place 🙂

Hey @daniel-deboeverie-lemon,
Thanks for all changes you've made to the PR. It looks great already, but CI spot a few missing tests. Would you please add them? I'll try to find some time during the weekend if you would not add them earlier.

Thanks again for the PR, I've added missing tests. I'll publish a new version once I merge the other opened PR (hopefully, soon).


Add images to instructions

This will probably not be doable through formatting in docx documents for a variety of reasons, the biggest one being the text will have to be cut up to fit in the instruction manual margin anyways, making the placement of images in the docx much harder to predict.
One way of navigating this could be to have the user define which page, and the placement coordinate they would like the picture. It could be something like this.
addtext —ImageQuery ‘/path/to/first/image, page#, x, y; /path/to/second/image, page#, x, y; …
then, the margin box will have to be dynamically changing by page, and the perimeter of the image would have to be added to the margin box. The images themselves will have to be placed on the template image once the text is added.
This is some very preliminary thoughts for how this will work, but this issue will have to be tackled once #49 is done.

This should also be completed before #25 is complete as well

Closing these issues until further notice


BRPOPLPUSH can totally block ioredis

Redis "B" commands like BRPOPLPUSH with an infinit wait, block ioredis' single connection which means no other calls to ioredis can go through.
Here is an example :
// Create an interval refreshing a ttl key every sec
setInterval(async () => {
    await ioredis.expire("ttlKey", 60);
    //...
}, 1000);

//...

// Waiting to process the next message
const value = await ioredis.brpoplpush("queue:a", "queue:b", 0);
//...

The expire command is always waiting for brpoplpush to resolve/reject.
But if there is no item in queue:a, we wait pretty much indefinitely.
This is because ioredis has only one connection.
I'm not sure what i'm expecting from this github issue..
I don't think it's going to be "patch" in v4.
Maybe just to keep that in mind in v5.
Mean while I'm going to hack something out to make this work..

This is by design. You have to establish separate client connections for things like blocking commands and subscriptions. For example:
const Redis = require("ioredis");
const client = new Redis();
const blockingClient = new Redis();

blockingClient.brpoplpush('a1', 'a2', 0).then(console.log);
blockingClient.brpoplpush('b1', 'b2', 0).then(console.log);

client.rpush('a1', 'foo');
client.rpush('b1', 'bar');

Yes i know it's "by design".
I guess I'm not clear in my original post.
I think you can see this as an argument to why ioredis should support connection pool out of the box. As a user of the lib, i don't know why it's not handle like in lots of other database libraries. Especially since redis has commands blocking the connection.

Yeah in my opinion this should be alot clearer. I am just getting started with both redis and ioredis and getting no error message was very frustrating.

I just started with redis and was wondering why the first request took 10ms and subsequent took up to 5 seconds. Turns out I had a block 5000 call running in a loop and I was not aware that this would block this single connection.
So after creating like 3 more redis instances on different servers because I thought it is a network issue, I find out that this is by design. So well I am voting for a connection pool or at least a clear warning on e.g. the XREAD docs page.


Implement free-text selection of the ROI on the Time Inspector

What new features would you like to see implemented?
Add the right-click menu present on other parts of the software (like the analyser) to the Time Inspector, specially the "Set ROI ranges" option.
Can you provide some motivation for why this feature should be added?
This would allow to consistently subtract a given amount of minutes from multiple datasets.

Completed and to be released wity pyMINFLUX 0.4.0.


[FLINK-16668][python] Refactor PythonDriver to read python dependency info both from command line and environment configuration.

What is the purpose of the change
This pull request refactors PythonDriver to read python dependency info both from command line and environment configuration.
Brief change log

Remove PythonDriverOptions and PythonDriverOptionsParserFactory as they can not process both command line and configuration.
Add parseCommandLine method to PythonDependencyUtils to parse the command line options to configuration.
Refactor PythonDriver#constructPythonCommands to construct commands from configuration.
Refactor PythonDriverEnvUtils#prepareEnvironment to construct PythonEnvironment object from configuration.

Verifying this change
This change is already covered by existing tests, such as PythonDriverTest, PythonDependencyUtilsTest.
Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
The serializers: (no)
The runtime per-record code paths (performance sensitive): (no)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no)
The S3 file system connector: (no)

Documentation

Does this pull request introduce a new feature? (no)
If yes, how is the feature documented? (not applicable)

@dianfu Thanks for your review! I have updated this PR according to your comments.

@dianfu Thanks for your review. I have updated this PR according to your comments.

Thanks a lot for the update. LGTM. Merging...


Enable SWS access via Bearer token

This enables (read-only) access to SWS if you have a bearer token, rather than a cert/key combo.

Hi Brad,
We only accept pull requests to uw-restclients to the develop branch.  Can you re-submit this pull request to develop?  I'll accept it.
Jim

Coverage decreased (-0.3%) to 82.848% when pulling 33dd8ec02166ebdb8bf53e97d64121fc9cdb6ab4 on uw-it-cte:sws-bearer into 1d3453d0fa7be225b4886fa294389eccdc4803f1 on uw-it-aca:master.


API endpoint to edit the link

Is your feature request related to a problem? Please describe.
This is not an issue at all, but it will be good to just curl to edit the link.
My current use-case: I want to redirect with a permanent slug, say "current-preset" to the URL on S3 (which could be changed when I update the final file).
Describe the solution you'd like
curl -X PUT -d '{"longlink": "https://newlink.com/file.json}' chhoto-url:4567/api/edit/<shortlink>
Or something like that.
Describe alternatives you've considered
It's still possible to manually edit rows in the database.

You can always just delete and recreate the link. This shouldn't be any different functionally, except for retaining the hit count.

Ok, thank you for your reply.


Function "remove" in class "EventList" return not correct

Version of flutter_calendar_carousel
1.4.11
Expected behavior
Result is false
Actual behavior
Result is true
flutter doctor result (run flutter doctor in terminal)
Steps to reproduce the behavior
bool remove(DateTime date, T event) {
    return events != null && events.containsKey(date)
        ? events[date].remove(event)
        : true;
  }

In this func, i think if events.containsKey(date) == false it should return false.
EX:
   bool remove(DateTime date, T event) {
    return events != null && events.containsKey(date)
        ? events[date].remove(event)
        : false;
  }

Would you like to give a PR for this?


made 'id' and 'name' optional as per IETF spec

Id and name are optional fields according to the IETF spec. This change allows them to be optional.

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   91.11%   91.11%
=======================================
  Files           1        1
  Lines          45       45
  Branches        2        2
=======================================
  Hits           41       41
  Misses          4        4

Impacted Files
Coverage Δ

...org/zalando/spark/jsonschema/SchemaConverter.scala
91.11% <100%> (ø)
:white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5702af...e227e43. Read the comment docs.

:+1:

:+1:


Updated tailored CTAs

CTA Components for home page tailored for Developers and Individuals that have the following modular atomic components:

left/right orientation
audience label
CTA H2
CTA button
optional illustration
asymmetrical design

*review needed by @AmandaCassatt @creckhow @mhluongo — do these help target audience-specific CTAs? any other thoughts?

I like this. @Gluzman are you still looking for review?

Great. @ironng these are approved. ready for you to make; but let's discuss how a CMS might handle?


Keep Code Comments not working with /*

in the merge.json we have the  Keep Code Comments": false
this works perfectly when you use // for comments but when you do multi-line comments using /* */ this is not treated properly
I quite love this library and I know that you are not responsive on the issue section, but I just want to do my part :D

This has been fixed in v1.0.8. Might take a bit to reflect on nuget


Update project dependencies and metadata

This PR improves the project in many ways even not touching the core logic:

Project dependencies and metadata:

Moving to the python 3.9 as the minimum supported version. The end-of-life for Python 3.8 is 31 Oct 2024, so the transition can be made in advance. By this step the project drops the Python3.7 support (EOL is 27 Jun 2023).
The pytest package and its plugins as project dependencies moved into the separate test section. Its configuration got enhanced by: 1) capturing stream outputs (-s) with 2) increased verbosity (-vvv); the session stops if 3) any test fails (--maxfail=1); also 4) the tests can be launched in a random order, which is good for preventing the cases of determinism.
The CHANGELOG.md file was updated with the v0.2.4 contributions records.

Code and test bases:

added the DEFAULT_HOST="<IP_ADDRESS>" constant;
more type hints;
the custom event_loop was removed from the conftest.py file -> no more deprecation warning on this matter;
some tests were changed to make them pass having launched the ClickHouse container with docker run --rm -p 9000:9000 --name some-clickhouse-server clickhouse/clickhouse-server.

@long2ice , let's review all of this, especially tests, I need this PR to be cross-validated. Who else can I tag to help me with review? any maintainers or volunteers?

@long2ice , shall we work out this PR?
Also, I think that a future PR introducing the mypy package would be nice. I'll see how many changes it may result in.


HPR example hard to read

http://localhost:8080/Apps/Sandcastle/index.html?src=HeadingPitchRoll.html&label=All
Needs a background like our other examples.

Same thing for http://localhost:8080/Apps/Sandcastle/index.html?src=LocalToFixedFrame.html&label=All

For whoever does this, I recommend background: rgba(42, 42, 42, 0.8);  I think there are existing demos with this or very similar backgrounds.

Thanks for the suggestion @emackey , i'll take a look at it and see what I can do.

I volunteer as tribute!


Uncaught ReferenceError: webpackJsonp is not defined

When compiling production assets with yarn prod, there is an error on the page, and nothing showing except spinner
Uncaught ReferenceError: webpackJsonp is not defined
    at app.js?id=4510d0b84af0f58015f3:1
(anonymous) @ app.js?id=4510d0b84af0f58015f3:1

Seems like this error is caused because files 0.js, 1.js, etc doesn't load to the page

Same issue here

If you do yarn prod,
you need to change your .env
APP_ENV=production
That should resolve your issue


Remove pre-methods from the ContractNegotiationListener

Feature Request
Seems like the pre- methods in the ContractNegotiationListener are not used by anyone, and they have been replaced by the "post" ones.
Based on the discussion in the pull #1609 , they could be removed then.
Which Areas Would Be Affected?
contract negotiation listener
Why Is the Feature Desired?
cleanup
Solution Proposal
Remove these methods from `ContractNegotiationListener:
default void preRequesting(ContractNegotiation negotiation)
default void preRequested(ContractNegotiation negotiation)
default void preProviderOffering(ContractNegotiation negotiation)
default void preProviderOffered(ContractNegotiation negotiation)
default void preConsumerOffering(ContractNegotiation negotiation)
default void preConsumerOffered(ContractNegotiation negotiation)
default void preConsumerApproving(ContractNegotiation negotiation)
default void preConsumerApproved(ContractNegotiation negotiation)
default void preDeclining(ContractNegotiation negotiation)
default void preDeclined(ContractNegotiation negotiation)
default void preConfirming(ContractNegotiation negotiation)
default void preConfirmed(ContractNegotiation negotiation)
default void preError(ContractNegotiation negotiation)

Type of Issue
cleanup
Checklist

[x] assigned appropriate label?
[x] Do NOT select a milestone or an assignee!

Quick question before we remove these: How will the event system achieve transactional atomicity with state changes if the dispatch is asynchronous?

Quick question for @ndr-brt and @paullatzelsperger before we remove these: How will the event system achieve transactional atomicity with state changes if the dispatch is asynchronous?

@jimmarino At the moment it can't achieve it, an event system needs persistence of the events to reach transactional atomicity, is something that at this point is not hard to implement (I would like to propose it for M6).
This issue/PR was proposed because these pre- methods are not used by anyone apparently.

@jimmarino @ndr-brt ATM we only use a few of the TransferProcessListener's pre-methods.


the loss values are negative and fluctuating without any clear pattern

Hello! I would like to inquire about replicating your paper using the UBFC dataset. I have set the number of epochs to 30, while keeping the other parameters the same as those provided in your paper. However, I noticed that the loss values are negative and fluctuating without any clear pattern. Is this behavior normal?

Hi, The loss value can be negative. You can smooth the loss curve by exponential smoothing to see the decreasing trend.

Hello, I still can't solve the above problem (loss function curve jittering too much), and I'm not sure if this can be interpreted as an overfitting problem. In the meantime, I trained a model through the UBFC dataset to compare with the .pt file provided according to your demo, using subject38 for testing. The first graph is my test result and the second graph is the weights provided by you, you can see that the curves are similar, but the value of the vertical axis of my result is 10 times smaller compared to your model, put the two results together as shown in figure 3. All parameters are consistent with the code you provided, maybe my training process is wrong, can you explain this phenomenon?

Hi, I haven't noticed this phenomenon before. My assumption is that the model does not explicitly learn the signal amplitude, so the amplitude may vary during different training. However, the signal amplitude is not important since the scaled amplitude does not influence the following analysis such as HR or HRV calculation. Usually, the signal amplitude should be normalized with zero mean and one std.

Hello! I would like to inquire about replicating your paper using the UBFC dataset. I have set the number of epochs to 30, while keeping the other parameters the same as those provided in your paper. However, I noticed that the loss values are negative and fluctuating without any clear pattern. Is this behavior normal?

Hello! I would like to inquire about replicating your paper using the UBFC dataset. I have set the number of epochs to 30, while keeping the other parameters the same as those provided in your paper. However, I noticed that the loss values are negative and fluctuating without any clear pattern. Is this behavior normal?

@Harry2345 Hello, I am also reproducing the project code.Running the train.py file results in an error saying that the .h5 file does not have a bvp file.  How can this be resolved?  Can you provide an example or a solution?I hope to exchange ideas!!!

你好，我以前没有注意到这个现象。我的假设是模型没有明确学习信号幅度，因此在不同的训练过程中幅度可能会有所不同。然而，信号幅度并不重要，因为缩放幅度不会影响后续分析，例如 HR 或 HRV 计算。通常，信号幅度应使用零平均值和一个标准值进行归一化。

@zhaodongsun  I encountered a similar problem. I used object 6,8,9 on the PURE data set to verify. The results are as shown below, but the visualization results show that rPPG is much smaller than ground true. You mentioned using zero average and normalized to a standard value. I don't understand. Is there any specific code?
MAE:0.3529411764705878
MSE:0.35294117647058737
RMSE:0.5940885257860039
R:0.9988294253545278

Hi, I haven't noticed this phenomenon before. My assumption is that the model does not explicitly learn the signal amplitude, so the amplitude may vary during different training. However, the signal amplitude is not important since the scaled amplitude does not influence the following analysis such as HR or HRV calculation. Usually, the signal amplitude should be normalized with zero mean and one std.

@zhaodongsun Hi, I encountered a similar problem. I used object 6,8,9 on the PURE data set to verify. The results are as shown below, but the visualization results show that rPPG is much smaller than ground true. You mentioned using zero average and normalized to a standard value. I don't understand. Is there any specific code?
MAE:0.3529411764705878
MSE:0.35294117647058737
RMSE:0.5940885257860039
R:0.9988294253545278

@dalaoplan Hi, you can check the normalize function in utils_sig.py. Normalization is only for better visualization, but does not influence the HR results. If you want to plot two signals and compare them, you should normalize them for better visualization.

@dalaoplan Hi, you can check the normalize function in utils_sig.py. Normalization is only for better visualization, but does not influence the HR results. If you want to plot two signals and compare them, you should normalize them for better visualization.

@zhaodongsun Thank you, I missed it and it turned out to be in the code!


Barnyard (numerous issues)

Describe the bug
This game has numerous issues, ranging from Remix not working in specific view angles to geometry spinning seemingly at random. The following warning also spams the log, and I can't determine the reason:
warn:  ConvertFormat: Unknown format encountered: 65
I'm using remix-0.2.0 unmodified, and the game is DX8 so I'm using dxwrapper to wrap it to DX9. The game was also modified in a hex editor to run at 1080p, however these issue occur with the default version of the game as well.
3070 ti
Driver 531.29
Attach logs!

NvRemixBridge.log
NvRemixBridge.log

d3d9.log
d3d9.log

The game specific log will be named gamename_d3d9.log
Barnyard - Copy - Copy_d3d9.log

To Reproduce
Simply make a new character in the game, and get past the introduction sequence. The location it starts you out at is where I tested.
Expected behavior
Remix is only actually path tracing when the sun is on-screen. Enabling In View Transform for the Fused World-View Mode setting fixes this. However geometry will still rotate during daytime hours.
I'm not sure where the Unknown Format warning is stemming from however. The geometry hash debug view also flickers intensely.
Screenshots
I have attached a video: https://cdn.discordapp.com/attachments/1106420949257044061/1106423673734303774/2023-05-11_23-29-10.mp4
It has a lot of flickering, be warned.

Interesting, looks like alot is wrong here.
Is this a shader based game?  If so, we can try disabling the  "Use World Transforms" feature.  It's useful in fixing unwanted movement/jitter for some games...

Thanks for the response! It is indeed shader based, with the entirety of the terrain being rendered through shaders. As for Use World Transforms, it's disabled already and sadly the rotation issue still persists.
However, removing the skybox on the game level rather than through Remix did fix the rotation issue. Without a skybox though the game is very dark. There is a workaround (selecting a seemingly random texture in the game as a sky texture), but it ends up with the game being green:

This game is also very noisy compared to other games. I believe this is related to the shader based terrain, as there are also many visible artifacts on the ground. In addition, small amounts of movement can cause intense trailing noise artifacts (This is running at 1080p with DLSS Quality, which looks fine in most other games):
https://github.com/NVIDIAGameWorks/rtx-remix/assets/62084776/598128b2-fbd2-40a9-a56b-c282e4cd17ed

Actually sorry for the confusion, but that was on a build of the Remix runtime from 4 days ago. The very latest builds have fixed the rotation bug even with the original skybox in place, no game mods necessary! The noise issue does remain however, along with the artifacts on geometry

Disabling Capture Normals from Shader fixes both the strange geometry appearance and the intense noise! The only issues remaining are culling and unstable geometry hashes now

The game is now crashing any time I alt-tab. This issue started randomly and I cannot find the cause. It happened previously, but mysteriously resolved itself
Logs:
Barnyard 1440p_d3d9.log
d3d9.log
NvRemixBridge.log

The previous issue is resolved, however this is still present: https://github.com/NVIDIAGameWorks/rtx-remix/issues/181

I will be closing this issue in favor of a new, reworked issue documenting issues that were not present in the original post.


@EqualsAndHashCode unnecessary warning

@EqualsAndHashCode(of = {"val"}) gives a warning:
Generating equals/hashCode implementation but without a call to superclass, even though this class does not extend java.lang.Object.If this is intentional, add '(callSuper=false)' to your type.
And callSuper = false is default value.

What version of the plugin are you using? Please also provide version of intelliJ you are on.
I believe this has been fixed in #184 which was part of 0.10 release of this plugin

Lombok Plugin Version: 0.11.16
IntelliJ IDEA 2016.1.1
Build #IU-145.597, built on March 29, 2016
JRE: 1.8.0_76-release-b18 amd64
JVM: OpenJDK 64-Bit Server VM by JetBrains s.r.o

Interesting. This is very similar to my setup i'm testing on.
Could you please provide a sample code or a project to reproduce this?

The warning is valid, as per [https://projectlombok.org/features/EqualsAndHashCode.html](lombok documentation).

Not setting callSuper to true when you extend another class generates a warning, because unless the superclass has no (equality-important) fields, lombok cannot generate an implementation for you that takes into account the fields declared by your superclasses. You'll need to write your own implementations, or rely on the callSuper chaining facility.

There's a related issue - not sure whether I should open a separate thread for this:
@Data // Warning issued even though this class implements its own equals() and hashCode() methods.
public class Foo extends Bar {
...
@Override
public boolean equals(Object o) {
    return ...;
}

@Override
public int hashCode() {
    return ...;
}

}
The plugin warns that super is not being called for equals and hashCode... but that check seems to overlook that this class isn't using that part of the @Data feature.

I'm still seeing this error on 1.16.16

As an aside for others that might stumble upon this... I was also seeing this and thinking it was a bug. Seemingly, setting callSuper=false or callSuper=true still always resulted in the warning. However, I eventually found that it was because intellij's automatic import was pulling in the groovy.transform.EqualsAndHashCode annotation instead of the correct lombok.EqualsAndHashCode. Be sure to check imports if unable to explain otherwise.


Stuck at chapter 4.4 and the tables.

So for some reason, every time I re-run app.js, the list just duplicates its self and adds more to the document as shown here:

I am unsure if this is how it was intended, however clearly duplicates are not something we want around.
My code so far:
const express = require('express');
const handlebars = require('express-handlebars');
const path = require('path');
const mongoose = require('mongoose');

const Item = require('./models/item');
const app = express();
const hbs = handlebars.create();

mongoose.connect('mongodb://<IP_ADDRESS>:27017/guide', {useMongoClient: true});
mongoose.Promise = global.Promise;

app.engine('hbs', hbs.engine);
app.set('views', path.join(__dirname, 'views'));
app.set('view engine', 'hbs');

// Item Table?
const awpAsiimov = new Item({
    name: 'AWP | Asiimov (Field-Tested)',
    price: 27.75
});

const akRedline = new Item({
    name: 'AK-47 | Redline (Field-Tested)',
    price: 5.52
});

awpAsiimov.save((err, item) => {
    if (err) {
        console.log(err);
    } else {
        console.log(item);
    }
});

akRedline.save((err, item) => {
    if (err) {
        console.log(err);
    } else {
        console.log(item);
    }
});

app.get('/', (req, res) => {
	Item.find({}, (err, items) => {
		if (err) {
			console.log(err);
		}
		res.render('main', { items });
	});
});

app.listen(3037);

ignore the useMongClient and mongoose.promise, those were for getting rid of the errors.

This part in your code:
// Item Table?
const awpAsiimov = new Item({
    name: 'AWP | Asiimov (Field-Tested)',
    price: 27.75
});

const akRedline = new Item({
    name: 'AK-47 | Redline (Field-Tested)',
    price: 5.52
});

awpAsiimov.save((err, item) => {
    if (err) {
        console.log(err);
    } else {
        console.log(item);
    }
});

akRedline.save((err, item) => {
    if (err) {
        console.log(err);
    } else {
        console.log(item);
    }
});

will create 2 new items (an AK and an AWP) every time the server starts up. If you want to clear these out, drop the Items collection and run your code once. Then you can remove those lines and restart the app as many times as you want.

What I should do is add a _id field to those new Items so they don't duplicate after every restart. I'll rename this issue to that and keep it open.

So, either by using db.item.drop() or by adding a _id field?
// Item Table?
const awpAsiimov = new Item({
    _id: 1,
    name: 'AWP | Asiimov (Field-Tested)',
    price: 27.75
});

const akRedline = new Item({
    _id: 2,
    name: 'AK-47 | Redline (Field-Tested)',
    price: 5.52
});

Yep. Though the _id field will need to be a MongoDB id if I remember correctly, which is ~20 chars or something. I'll look into this more in a bit.

A good solution would be to do this:
const Item = require('./models/item');

const items = [{
  name: 'AWP | Asiimov (Field_tested)',
  price: 27.75
}, {
  name: 'AK-47 | Redline (Field-Tested)',
  price: 5.52
}];

Item.remove({}).then(() => {
  Item.insertMany(items);
});

By doing this you remove every item in the DB and then insert an array of the predefined items into it.
Hope it helps!
@andrewda Maybe this could go into Chapter 4.4 instead of what's already there? Or it might be confusing for people that are new to mongoose/MongoDB?


Implement MongoDsn field types

Change Summary
Add  two DSN field types for MongoDB:

MongoDsn for regular mongodb://... connection strings (still todo)
MongoSrvDsn handling mongodb+srv://... aka  DNS Seed List connection strings

Related issue number
Implements and resolves #2117.
Checklist

[ ] Unit tests for the changes exist
[ ] Tests pass on CI and coverage remains at 100%
[ ] Documentation reflects the changes where applicable
[ ] changes/<pull request or issue id>-<github username>.md file added describing change
(see changes/README.md for details)

Generally I'd be happy to accept Mongo DSNs, but reading #2117 they seem unbelievable complicated. Should that logic really live in pydantic?
MongoSrvDsn looks simple enough, but:

how often is it used?
is it often used without full blown MongoDsn?

E.g. is it worth adding MongoSrvDsn to pydantic if it's only used alongside MongoDsn when ends up in a separate package?

Please excuse my ignorance, I've never really used mongodb.

I think that support for Mongo DSNs could be simplified to just validating a URL with the potential for multiple host:port sections. The added stuff (with authsource, database, etc), can be handled in code, and will likely not be accessed from the validated pydantic field, but rather the mongo module taking a URI would just take the string representation.
I think that discussion in https://github.com/samuelcolvin/pydantic/issues/2117 went a little into the weeds when it shouldn't have. We should keep it simple and only use Pydantic for validation in this case for now.

@StephenBrown2  it looks better to me that way :sweat_smile:
Just having the validation without the actual parsing for regular MongoDsn should be way easier to achieve without a lot of duplication (and more suitable for pydantic IMO) than actually handling all the logic behind these (providing host list, ports and all the option brought with the actual dsn).
Does it look reasonable to you @samuelcolvin ?

@art049 sounds good to me.

Just a note, I came across the actual parsing done for a URI in pymongo: https://github.com/mongodb/mongo-python-driver/blob/master/pymongo/uri_parser.py
Which further solidifies the fact that we don't need all that, just allowing multiple comma-separated hosts should do the basics.

Just a note, I came across the actual parsing done for a URI in pymongo: https://github.com/mongodb/mongo-python-driver/blob/master/pymongo/uri_parser.py
Which further solidifies the fact that we don't need all that, just allowing multiple comma-separated hosts should do the basics.

@art049 can you fix this?

Closing this as no response.
Anyone is free to create another PR for this and resolve the comments above.


CREO2URDF – Handle all the errors came out from the urdf unit tests

In this branch of ergocub-software (https://github.com/icub-tech-iit/ergocub-software/tree/refactorRepo) I started refactoring the structure for hosting only the urdf and conf files for using creo2urdf, and running the unit tests w/ the urdf obtained from creo2urdf I got these errors:
ergocub-model-test error:l_shoulder_pitch got direction of  x -3.26128e-16 y 1 z 3.88578e-16 instead of expected  x 0.250563 y 0.935113 z 0.250563
ergocub-model-test error:r_shoulder_pitch got direction of  x -4.68375e-16 y 1 z 3.60822e-15 instead of expected  x -0.250563 y 0.935113 z -0.250563
ergocub-model-test error:r_thumb_add got direction of  x -0.116648 y 0.227771 z 0.966702 instead of expected  x -0.329847 y 0.160871 z 0.930227
ergocub-model-test error:r_thumb_prox got direction of  x -0.329847 y 0.160871 z 0.930227 instead of expected  x -0.525416 y 0.838737 z -0.143034
ergocub-model-test error:r_thumb_dist got direction of  x -0.439716 y 0.892571 z -0.0998355 instead of expected  x -0.525416 y 0.838737 z -0.143034
ergocub-model-test error:r_index_add got direction of  x -0.250563 y 0.935113 z -0.250563 instead of expected  x 0.250563 y -0.935113 z 0.250563
ergocub-model-test error:r_ring_prox got direction of  x 0.961047 y 0.271447 z 0.0520081 instead of expected  x 0.973762 y 0.226085 z -0.0259272
ergocub-model-test error:r_pinkie_prox got direction of  x 0.961047 y 0.271447 z 0.0520081 instead of expected  x 0.973762 y 0.226085 z -0.0259272
ergocub-model-test error:l_shoulder_yaw got direction of  x -0.116648 y -0.227771 z 0.966702 instead of expected  x 0.116648 y 0.227771 z -0.966702
ergocub-model-test error:l_wrist_pitch got direction of  x 0.250563 y 0.935113 z 0.250563 instead of expected  x -0.250563 y -0.935113 z -0.250563
ergocub-model-test error:l_wrist_yaw got direction of  x -0.116648 y -0.227771 z 0.966702 instead of expected  x 0.116648 y 0.227771 z -0.966702
ergocub-model-test error:l_thumb_add got direction of  x 0.116648 y 0.227771 z -0.966702 instead of expected  x 0.329847 y 0.160871 z -0.930227
ergocub-model-test error:l_thumb_prox got direction of  x 0.329847 y 0.160871 z -0.930227 instead of expected  x 0.525416 y 0.838737 z 0.143034
ergocub-model-test error:l_thumb_dist got direction of  x 0.439716 y 0.892571 z 0.0998355 instead of expected  x 0.525416 y 0.838737 z 0.143034
ergocub-model-test error:l_index_add got direction of  x 0.250563 y 0.935113 z 0.250563 instead of expected  x -0.250563 y -0.935113 z -0.250563
ergocub-model-test error:l_ring_prox got direction of  x -0.961047 y 0.271447 z -0.0520081 instead of expected  x -0.973762 y 0.226085 z 0.0259272
ergocub-model-test error:l_pinkie_prox got direction of  x -0.961043 y 0.271458 z -0.052021 instead of expected  x -0.973762 y 0.226085 z 0.0259272

and
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame l_arm_ft as expected.
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame r_arm_ft as expected.
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame l_leg_ft as expected.
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame r_leg_ft as expected.
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame l_foot_rear_ft as expected.
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame r_foot_rear_ft as expected.
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame l_foot_front_ft as expected.
ergocub-model-test : model /home/ngenesio/icub-tech-iit/ergocub-software/build/ergoCub/robots/ergoCubGazeboV1_1/model.urdf does not contain frame r_foot_front_ft as expected.

The errors on the axis cannot be fixed reverting them, for the shoulder pitches there is something to be investigated, for the hands instead the discrepancy respect ergoCub 1.0 is due to the fact the hands changed? (@Lawproto @fiorisi)
The errors on the ft sensors are due to the fact the frames are not exported also if explicitly asked from the yaml (@mfussi66)
(For generating the urdf I used this yaml  file)

Alongside @mfussi66, today we started addressing the errors came out from the unit test, here is the PR:

#46

In particular, we fixed most of the axis issues by using the root_H_parent_link instead of root_H_child_link, given that

Right now the only remaining faulty axis are:
ergocub-model-test error:r_thumb_prox got direction of  x 0.439716 y -0.892571 z 0.0998355 instead of expected  x -0.525416 y 0.838737 z -0.143034
ergocub-model-test error:r_thumb_dist got direction of  x -0.439716 y 0.892571 z -0.0998355 instead of expected  x -0.525416 y 0.838737 z -0.143034
ergocub-model-test error:l_thumb_prox got direction of  x 0.439716 y 0.892571 z 0.0998355 instead of expected  x 0.525416 y 0.838737 z 0.143034
ergocub-model-test error:l_thumb_dist got direction of  x 0.439716 y 0.892571 z 0.0998355 instead of expected  x 0.525416 y 0.838737 z 0.143034

Maybe it is due to a different rest pose? Or to the new kinematics? (cc @Lawproto @fiorisi)
It has to be referred into the parent link frame.
We managed also to export the frames of the sensors and ft sensor, but right now we are stuck on defining correctly their pose.
As pose we are setting parent_link_H_ft_frame:

<pose>-0.00435 -2.77556e-17 -0.0543 3.14159 2.498e-16 -1.5708 </pose>

But the "correct" pose should be according to ergoCubSN000
<pose>0.0 0.0 0.0 -3.1415923328972943 2.923917580150936e-08 -1.5707962214346844</pose>

The strange thing is the 0 0 0 for the traslational component, maybe we are missing something on how the ft sensor has to be defined? (@traversaro)

Right now the only remaining faulty axis are:
ergocub-model-test error:r_thumb_prox got direction of  x 0.439716 y -0.892571 z 0.0998355 instead of expected  x -0.525416 y 0.838737 z -0.143034
ergocub-model-test error:r_thumb_dist got direction of  x -0.439716 y 0.892571 z -0.0998355 instead of expected  x -0.525416 y 0.838737 z -0.143034
ergocub-model-test error:l_thumb_prox got direction of  x 0.439716 y 0.892571 z 0.0998355 instead of expected  x 0.525416 y 0.838737 z 0.143034
ergocub-model-test error:l_thumb_dist got direction of  x 0.439716 y 0.892571 z 0.0998355 instead of expected  x 0.525416 y 0.838737 z 0.143034

Maybe it is due to a different rest pose? Or to the new kinematics? (cc @Lawproto @fiorisi)

I am not sure I understand the "faulty" part. but it seems to me that the software noticed that the angles of the thumb axis changed. Which is perfectly normal, since we changed the metacarpus angle as of our interactions with the HSP group.

The strange thing is the 0 0 0 for the traslational component, maybe we are missing something on how the ft sensor has to be defined? (@traversaro)

I guess that pose is jointFrame_H_sensor, and jointFrame = childLinkFrame in this case.

W/ https://github.com/icub-tech-iit/creo2urdf/commit/cfd18f64b81c86feaf11ae4e9e2fb17e95440856 I managed to correct the pose of the ft sensor as it should be, I had to increase the tolerance of this check
checkTransformAreEqual(root_H_frame, root_H_sensor, 1e-5)

to 1e-5 because 1e-6 was triggering an error, even if the transform were identical when printing them 🤔
I hope this tolerance is fine @traversaro
Right now the unit tests are fine 🎉
Test project /home/ngenesio/icub-tech-iit/ergocub-software/build
    Start 1: ergoCubGazeboV1ConsistencyCheck
1/3 Test #1: ergoCubGazeboV1ConsistencyCheck .....   Passed    0.03 sec
    Start 2: ergoCubGazeboV1_1ConsistencyCheck
2/3 Test #2: ergoCubGazeboV1_1ConsistencyCheck ...   Passed    0.02 sec
    Start 3: ergoCubSN000ConsistencyCheck
3/3 Test #3: ergoCubSN000ConsistencyCheck ........   Passed    0.03 sec


changed [ brackets to ( brackets so the links work.

also added link to flash loader doc

Thank you!


Add running scripts before and after cluster provision

This PR makes the following changes:

Fix _run_asyncronously function not working second time
Add flags like --preinstall-master to enable users to run custom shell scripts before and after cluster provision

I tested this PR by deploying cluster to AWS
The typical use-case for this functionality would be like below:

Replace Java 1.7 to Java 1.8. This can only be done BEFORE Spark installation (BTW, Spark 2.0 depreciates Java 1.7 support)
Install custom Python package like Anaconda for use with PySpark
Perform special filesystem operations (like RAID, mounting)

As described in the testing guide, it's a good idea to run
py.test tests/test_static.py

before submitting a pr to catch any formatting quirks.

Sorry. I fixed it.
Please feel free to give me any comments and suggestions. Thank you.

No problem. I'm curious as to what your use case is for those {pre,post}install scripts.

Hi @SoyeonBaek-dev and thank you for this PR.
I believe it's the first time someone has tried to implement a new FlintrockService. What did you think of that abstraction? I'm curious if others find it sensible.
Before getting into my review comments, I'd like to point you briefly to our contributing guide--specifically the section on coordinating first. It's generally better to have a bit of discussion upfront before non-trivial changes like this are proposed, for the reasons described in the guide.
Anyway, on to the review.
First off, I'll say that this is a promising feature proposal. I can see the value in being able to provide custom pre- and post-setup hooks for users to do what they want. However, I'd like to see more user feedback on how these features would be used to decide if it's really worth adding this in.
I think many of the potential use cases can be solved with a combination of run-command and modifications to Flintrock's default default behavior.
For example:

Replace Java 1.7 to Java 1.8. This can only be done BEFORE Spark installation (BTW, Spark 2.0 depreciates Java 1.7 support)

I think this should be part of Flintrock's default behavior, since our goal is to provide a good out-of-the-box Spark experience. Perhaps we should add a ensure_java8() method that makes sure the host has Java 8 or higher.
By the way, why can this only be done before installing Spark? I'm pretty sure you can install Java 8 and then restart Spark (via sbin/) to get the desired effect,  no?

Install custom Python package like Anaconda for use with PySpark

Isn't flintrock run-command sufficient for this today?

Perform special filesystem operations (like RAID, mounting)

This is interesting. Can you elaborate on this?
Flintrock goes to some lengths to make sure that you get fast, automatically mounted EC2 instance-store volumes, if your selected instance type has them. What other types of storage setup would you be interested in doing?

Thank you for your comment.
First of all, I should have checked the contributing guide and discussed with you before PR. Sorry for that.
Getting to the point, I agree with your opinion.
Custom post-setup can be replaced with flintrock run-command, however pre-setup hook has some advantages.

Install and use custom Java Runtime (Oracle JDK instead of openjdk, JDK 9, etc.)
No need to restart Spark. Especially after when add-slaves function is added, run-command would need to be more complex, as the script needs to be idempotent or we need to execute the scripts only on the newly added slaves.
Simple and Elegant one command line to support many use-cases.

We have been using Java 8 for a long time, and been doing Spark restarts all the time.
Let me explain one of the reason I propose this functionality. We have a custom branch that adds crude add-slaves functionality to flintrock.[1] And since we’d like to add slaves while running analysis, restarting all Spark related daemons are not an option. So we are opted to either: 1. Restart only the slaves that have just been created. Or 2. Build an AMI that has Java 8 by default. So we came up with this kind of functionality. Hope you understand the background to this PR.
[1]: Open-source in our devsisters/flintrock repo

First of all, I should have checked the contributing guide and discussed with you before PR. Sorry for that.

No worries.
First, regarding the specific issue of needing Java 8, I have created #143. I think we should work on that regardless of what happens here since it's important for the out-of-the-box user experience.
Thanks for detailing your use cases. I can see the value of this feature.
You're right, without a pre-launch hook, any scripts you run with run-command need to be idempotent and need not require a Spark restart.
I'm still hesitant to add something like this in because it's a feature we are implementing ourselves and will have to maintain over the long term. Furthermore, the main driver for it at the moment (installing Java 8) is something we now have plans to address anyway.
How about, instead of adding a new Flintrock feature, we just added support for an existing EC2 feature that does the same thing? That feature is user data.
Would that satisfy your use cases?

I think adding ec2 user data feature is also a viable option. It will solve most of our problems.

OK, in that case (and if @SoyeonBaek-dev agrees) I suggest we close this PR and start over with a new proposal that just exposes a new --ec2-user-data option.
I also suggest waiting to develop this until after #115 gets in (which should be in the next day or two, barring any major surprises) since the new add-slaves command will affect how this feature is implemented. We will need to discuss whether add-slaves can or should automatically poll the existing master for user data to reuse with the new slaves.

I also agree with ec2-user-data feature, too.

Is it ok if I implement --ec2-user-data feature?
I think add-slaves should automatically poll the existing master for user data to reuse with the new slaves, so that spark clusters can have unified settings.

@SoyeonBaek-dev - Yes, it's all yours. 👍
And yes, I agree, we should source the data from the master automatically when adding new slaves. This matches the behavior of #115.

Closing this PR per our discussion above about starting over with a proposal to add an --ec2-user-data option to Flintrock.


Typing indicater not coming in webchat

I have a scenario in which I have to preserve my conversations in chat window. For this I have saved the conversation Id in local storage and set web socket = false. Setting web socket to false has stopped my typing indicator to come.
botConnection = new BotChat.DirectLine({
secret: params['s'] || 'secretKey',
token: params['t'],
domain: params['domain'] || 'https://directline.botframework.com/v3/directline',
webSocket: false,
conversationId: conversationIdObj
});
if I set websocket to true, the chat history goes away. Could anyone please help me know how to get typing indicator in such scenario

I don't understand. Can you provide more details in a "when the user does this, I expect this, but instead this happens" format?

Basically the scenario is like when user writes something, the response from bot is taking time as it fetches data from database. During that time I want to show typing indicator gif playing.
But as I have to maintain my chat history I have to send web socket as false. So my typing indicator is not working

Are you "toggling" the webSocket flag in the middle of a conversation? If so, you shouldn't.
The "typing" feature requires webSocket to be true. It should be set to true when you initialize the WebChat control. There is no further interaction with the WebChat options.

Yes, unfortunately 'typing' is only sent with webSockets. So for now you'll have to choose between one or the other.

@rachita0311 is your web history problem related to #365?

Typing is sent with out without WebSockets.

@telkomops your last comment confused me. To summarize, you want to maintain history so you are not using WebSockets, which means you are not getting the typing indicator. If this is correct, I'm afraid there is no workaround until the 'no history with websockets' bug is fixed.

@rachita0311 Typing in non-WebSocket is not supported on Direct Line, so we are not able to get the "typing" event. There are workaround mentioned by @EricDahvlang in #872.
And since DirectLineJS cannot be stopped/paused once it is up, we currently don't support switching DirectLine object on-the-fly. Even though we preserve the history, you will see multiple network requests done by DirectLineJS.
So I would suggest you to keep using WebSocket.

Hi @compulim
Is there a way that we can get the chat history and keeping the webSocket: true
I've been trying to go through several threads on webchat and used conversationId to fetch the history but have to make the webSocket:false.


[Secure Storage] Fixes the create() method for the Vault secure storage implementation and adds an appropriate test.

Motivation
This PR fixes an implementation error for create() in the vault backend and adds an explicit test to verify the previously broken behaviour.
Have you read the Contributing Guidelines on pull requests?
Yes.
Test Plan
The updated tests works (as well as all previous tests)
Related PRs
None.

@bors-libra r+

:pushpin: Commit 78daa0b has been approved by davidiw

:hourglass: Testing commit 78daa0b8ecdf65468f18cbaf11e0deb4b9f140a5 with merge ab447d79a8d072ae4a6b7a9368dfb6068b9b5290...

:sunny: Test successful - checks-actions_land_blocking_test, checks-circle_commit_workflow
Approved by: davidiw
Pushing ab447d79a8d072ae4a6b7a9368dfb6068b9b5290 to master...


How to get dimensions of Image File Requests/Responses with Network?

Hello!
I want to take dimensions (width and height) of Image File Requests/Responses that come from Network.requestWillBeSent and Network.responseReceived. I can't reach any solitions by the default Request/Reponse informations. How can I make this?
Thanks!!

I guess you'll have to inject some JavaScript to try to fetch that once that the image is part of the DOM.


🏗 Add loading states to EditProfileModal buttons

Since the functions the buttons trigger are async, it makes sense to give them a loading state while those functions are running.

Closed by #565


Combine the functionality into a single method call.

Example: https://github.com/andreibondarev/langchainrb/blob/main/lib/langchain/llm/openai.rb#L29-L30
This type of code is repeated in many many places. Instead of having 2 lines, we should just be able to call a single method that does both depends_on() and require().
Maybe depends_on itself does the require as well?

I'll take a stab at this one.


Improve GitHub Actions for pull requests

See https://github.com/Senzing/community-roadmap/issues/71

Pull requests:

https://github.com/Senzing/senzingapi-tools/pull/11


Reduce workload

Currently scala-steward checks every repository for new dependencies on every run. Checking for updates is a costly operation since it means cloning the repository, starting sbt, and checking for library and plugin updates. Even for small repositories which are up-to-date this process takes roughly a minute on my server. This is not viable if scala-steward should be able to handle 1000+ repositories which I very much like to achieve.
My current idea to reduce the overall workload is the following:
I propose to skip checking repositories where scala-steward would not open new PRs or update existing PRs. This would require to persist some infos about the repos scala-steward has worked on. E.g if we know of each repo

the current SHA1 of the base branch
the current list of library and plugin dependencies
all PRs scala-steward has created

we should be able to decide if we need to process a repository without cloning it and running sbt dependencyUpdates. The SHA1 can be used check if the upstream repository has changed and our existing PRs need to be updated or if the list of dependencies has changed.
Before working on any repository we would need to check if any of the libraries or plugins scala-steward knows about has a newer version and then only process repositories whose dependencies have updates.

I just checked the runtime of the latest run:
2018-11-04 15:55:29,111 INFO   --- Total time: 3h 52m 54s 445ms ---

That is definitely too long for 154 repositories.

This has been implemented in the two PRs referencing this issue.