feat: split the packages

Well this one was a hoot.  As I looked around, I started to notice a lot of our modules only use small pieces of what's available in nodejs-common.  The package is bringing request into everything else, when in many cases, it's just not needed.   To help make things easier to rationalize, this PR splits common into 4 different modules:

paginator
promisify
projectify
common

I used lerna to tie it all together.  Still have no idea how the whole circleci thing gonna work out, but we'll see where it goes :)
Thoughts?

I like the idea of splitting into multiple modules 👍. My only question is, I'm not sure of the distinction. For example, why not split out the Operation class? Were the ones you chose just the most independent, "module-like" pieces?

So far I've only pulled out the ones that I've seen used independently.  Vision only uses promisify, pubsub only uses paginator, firestore only uses projectify, etc.  It's entirely possible we run into one where Operation is needed independently.  When we get there, I'm happy to factor it out too :)

Yay for modularity!
For the record, token pasting and removal that necessitates projectify is a bug, and needs to be fixed – removing the need for the module. I do get it that at this point in time we are not there yet.

Monorepo for the win! But I don't really understand how lerna publish is going to work in Circle :-(  (I'm sure it must be possible but I don't really see how exactly for now)

Codecov Report

Merging #189 into master will increase coverage by 0.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   97.63%   98.06%   +0.43%
==========================================
  Files          16       12       -4
  Lines        2915     2483     -432
  Branches      181      201      +20
==========================================
- Hits         2846     2435     -411
- Misses         39       48       +9
+ Partials       30        0      -30

Impacted Files
Coverage Δ

test/service.ts
98.88% <0%> (-0.72%)
:arrow_down:

test/operation.ts
98.82% <0%> (-0.59%)
:arrow_down:

test/service-object.ts
96.94% <0%> (-0.44%)
:arrow_down:

test/index.ts
100% <0%> (ø)
:arrow_up:

src/index.ts
100% <0%> (ø)
:arrow_up:

test/util.ts
98.38% <0%> (+0.54%)
:arrow_up:

src/operation.ts
100% <0%> (+2.22%)
:arrow_up:

src/service-object.ts
100% <0%> (+2.43%)
:arrow_up:

src/util.ts
99.23% <0%> (+3.19%)
:arrow_up:

src/logger.ts
100% <0%> (+3.57%)
:arrow_up:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5508e4...472b3f3. Read the comment docs.

I too would like some more thought to how to the release process would work. @kjin may have some thoughts about this OpenCensus for Node also started with learna. AFAIK, there is no answer yet on how releases are supposed to work.

For now, I think the process would be a human running lerna publish

@ofrobots @theacodes  I don't really know what to do here.  We all agree this stuff should be split up, but I'm not sure of a way to automate the releases.  Running lerna publish from a developer machine followed by a git push to push the new tags and such will work, but has the obvious disadvantages.
I see a few options here:

We drop the mono-repo, and create new repos for utility.  This isn't hard, it's just a pain.
We use https://github.com/atlassian/lerna-semantic-release to do this work for us, but it requires adding the GITHUB_TOKEN to CircleCI env vars.  I don't think this is that bad, but I don't think it's policy atm.
We could add support for sub packages to releasetool.
We could use a local workflow for publishing.

What are y'alls thoughts?

Just a thought, instead of adding GITHUB_TOKEN directly, we can use kind of security through obscurity and commit encrypted script (containing the token), with encryption key added to CircleCI environment variables. Makes it just a little bit safer in case if CircleCI environment variables leak (but not 100% safe of course).

Previously, a list of issues with mono-repos was compiled here: go/veneer-monorepo (internal link). It would be good to review the list and be wholly convinced that all the listed problems are solved or are no longer problems.
We already have a fair amount of tooling to deal with large number of repos. I am concerned that we are moving to a half-hearted-state where we have some lerna monorepos and some individual repos. IMO, this will cause a dilution in the tooling efforts – we need different kinds of tools to deal with the shortcoming of both lerna and individual repos.

For now, I think the process would be a human running lerna publish

Yep, from what I can tell lerna publish is not automatable unless you know that all packages should be released at the same time (which is slightly different than on the same version), and your commit messages are perfect.

Ok :) I created launchcals for each of the packages - once those are approved, I'll move this stuff out and submit a separate CL to remove the code from here.


Add IconVSR architecture

Add IconVSR architecture in BasicVSR: The Search for Essential Components in Video Super-Resolution and Beyond.
Additionally, add support of Y-channel PSNR/SSIM in BasicVSR model.

LGTM

Both basic and icon vsr need paper annotation like other readmes. This can be done in a separate pr.
When you do that, you can change the annotations in this repo to comments, as in this pr https://github.com/open-mmlab/mmpose/pull/580. Also remember to change the docs/stats.py, thanks!


Show link to further information "dcat:landingpage" on final graphic

https://gitlab.ldbar.ch/bafu/umweltdatenkiosk-planning/-/issues/351

Closed with https://github.com/visualize-admin/visualization-tool/pull/607

According to the feedback in GitHub this link should only be shown in the published graphic, but I guess it is ok, to show it all the time. Please change style and size according to general component with link and Icon (see screenshot).
I'd also change the naming. Something like "more information about the data" I'm sure @sosiology has a better suggestion.

According to the feedback in GitHub this link should only be shown in the published graphic, but I guess it is ok, to show it all the time.

For now, this is the same component that is used in the editor and in the published view. As I understood, the initial rationale was to show the user in the editor always what was going to be published.
Concerning the styling, something like this :

Yes, I would only change the order and have probably: Download, Switch to Table view, Learn more.. and then the RUN SPARQL. Or the learn more about the dataset at the very end

Wording LGTM! thanks @AnninaWalker and @ptbrowne

Fixed in #662


Incompatibility with image 0.25.0

Upgrading to image 0.25.0 results in a compatibility issue between the image::Pixel trait implementation and the render::Pixel trait:
// issue with image::Luma<u8>'s implementation of Pixel
let img_buf = qr_code.render::<image::Luma<u8>>().build();

The most notable image change is the switch from the use of #[repr(C)] to #[repr(transparent)] in the Pixel trait implementation:
#[derive(PartialEq, Eq, Clone, Debug, Copy, Hash)]
#[repr(transparent)]  // <- previously #[repr(C)]
#[allow(missing_docs)]
pub struct $ident<T> (pub [T; $channels]);

dependencies
qrcode = "0.13.0"
image = "0.25.0"

use code
    // Encode some data into bits.
    let code = QrCode::new(b"01234567").unwrap();

    // Render the bits into an image.
    let image = code.render::<Luma<u8>>().build();

    // Save the image.
    image.save("/tmp/qrcode.png").unwrap();

error info
error[E0277]: the trait bound `Luma<u8>: Element` is not satisfied
   --> src/main.rs:44:31
    |
44  |     let image = code.render::<Luma<u8>>().build();
    |                      ------   ^^^^^^^^ the trait `Element` is not implemented for `Luma<u8>`
    |                      |
    |                      required by a bound introduced by this call
    |
    = help: the following other types implement trait `Element`:
              char
              &'a str
    = note: required for `Luma<u8>` to implement `qrcode::render::Pixel`
note: required by a bound in `QrCode::render`
   --> /Users/aya/.cargo/registry/src/rsproxy.cn-8f6827c7555bfaf8/qrcode-0.13.0/src/lib.rs:249:22
    |
249 |     pub fn render<P: Pixel>(&self) -> Renderer<P> {
    |                      ^^^^^ required by this bound in `QrCode::render`

The current qrcode package depends on image = "0.24.0", which is semver-incompatible with 0.25.0, and thus image/*0.24*/::Luma and image/*0.25*/::Luma are considered distinct types. It has nothing to do with #[repr] or whatever.
Yes we know what is going on, you will have to wait for qrcode to upgrade its image dependency to 0.25 first.

I tried compiling this crate with image version 0.25.0. Fortunately, there were no backward compatibility errors or deprecations.


xmpt creating a deal without a counterpart

App doesn't have a proper error screen when trying to create an agreement without a counterparty. Peeraddress returns null.

fixed


channel ids for dtype bug fix

There are two small fixes that I'm proposing in this PR for the add_electrodes() method of spike_interface:

Bug fix: to find the dtype of the electrical series the channel_ids should be one from the list of extractor.get_channel_ids() and not default to 0. Here
Enhancement: having the functionality to enter a custom starting_time for the ElectricalSeries. Here

Enhancement: having the functionality to enter a custom starting_time for the ElectricalSeries. Here

I think for this I'd rather have the user change the internal values of the RecordingExtractor time conversion so we don't have a decoupling between the data in the RecordingExtractor object and what gets written to the NWBFile. Does that sound possible?

yes, that works too. In facts that is a better way indeed: using recording.set_times() to set custom times (in my case all nans) works just as well.

@CodyCBakerPhD  have reverted the commit for the optional starting_times, should be good to merge


Sort names alphabetically in the drop down

Describe the feature you'd like to request
Sort names alphabetically in the drop down for all the different names... but sort by the base ENS name... so it would be like:
fun.eth
giv.eth
liquidity.giv.eth
otc.giv.eth
heaven.eth
Describe the solution you'd like
No response
Describe alternatives you've considered
No response

Hey @RamRamez I don't think this is exactly what @GriffGreen wanted.
The sorting worked alphabetically, but if you have a secondary ENS name (like .giv.eth or .griff.eth for example), those names should appear after their parent name.
For example, it should be
1)
griff.eth
green.griff.eth (it appears under because it is a "subdomain" of griff.eth)
then the others continue like:
griffdog.eth
griffgreen.eth etc.

The secondary names should also be sorted alphabetically like:
giv.eth
grants.giv.eth (they appear under because they  are "subdomain" of giv.eth)
liquidity.giv.eth
otc.giv.eth
then the others continue like:
give.eth
giveth.eth etc.

Does that make sense?

I fixed it in PR #92
Thanks ChatGPT for solving this complex sorting problem.


custom-config: remove check for wakeup effect.

custom-config processor return promise.
Change-Id: I37207fa8a86dab1fd8d7b7f6fc2950a954893437

Checklist

Refactor custom-config processor: If there are consecutive requests, the old one will be interrupted.
remove check for wakeup effect query object.

[x] npm test passes
[x] tests and/or benchmarks are included
[ ] documentation is changed or added

@FeelyChau Does this work in progress still?


[WIP] Log error and not create ndj file when wos extract error occurs.

closes #285

I'm going to change one of the tests, so hold off on further review.

Made my fixes. Now more directly tests handling of errors thrown by extractor in composite ETL.


Event listeners are added multiple times when moving the element out and into the DOM

Event listeners and initial component setup are done in the connectedCallback(), but are not taken down in the disconnectedCallback(). When I dynamically create an element and move it out of- and back into the DOM, the event listeners are added again, causing in multiple listeners, and (more detrimentally) the markup is duplicated, resulting in multiple rendered rings.

Going to close this for my own issue management 😉


Make use of next/link instead of anchor elements for routing

Make use of the next links instead of regular . Using next links improves performance

PR has been merged into staging. This issue will be closed now.


Implement some form of look ahead/suggestions as a user types

react-bootstrap-typeahead

The search bar should support typeahead, so that when you start typing "sq" a dropdown shows you relevant search results with each new keystroke, like "sql" and "sql insert", which you can click on to navigate directly to the article.
This should also support basic keyboard interaction: the up and down arrow keys to select a result, the enter key to open selected result, and escape to dismiss suggested results.
We should show the titles of up to 8 matching results (they needn't be capitalized).
Here's what Facebook's look like:

Nothing fancy - just fast and functional :)


Unix sockets to port communication

Fixes #53.
This will be a breaking change. Once this is merged we have to update the SDK immediately otherwise create pipeline will fail.
For now implemented first version of CA generation and key pair generation which will be signed for mutual Auth.

Can you put it behind a feature flag of it's breaking everyone? And the flag is off by default and on for anyone opting in? Would it make sense?

@Skarlso I think I can do that. I just think when we wait longer more users will be pissed at the end. I think now is the perfect time to do changes like these when everyone expects bugs/problems. 😄

@michelvocks Agreed. :D

This is now working as intended and make Gaia a bit more secure and flexibe. :tada: :confetti_ball:
I will rebase it after #58 has been merged.

@michelvocks Yo what's up with this guy? :) The corresponding 58 was merged. :)

@Skarlso if I merge this, it's not possible to build pipelines anymore when you are running gaia from master branch. It will work again if I merge this: https://github.com/gaia-pipeline/gosdk/pull/1
But then it's not possible to build pipelines in version V0.1.2 which is currently latest released version.

Ping @Skarlso please have a look and merge if you think so 🤗

I fixed the merge conflict. 👍 Hope you don't mind. :)

Interesting. Something new introduced a race condition after merging master. :/

I tested this on master and it looks okay. So it's this new code plus the new schedule test that's failing.

@Skarlso I fixed it. Somehow the init method was still in the specific test. No clue what happened there. 😄

Well done! Awesome.😁


Add YARN Device Plugin to support MIG GPUs

This plugin works with YARN 3.3.0+ and adds in support for GPUs with MIG capabilities.
Documentation tying it together with the Spark Rapids Plugin  will come later in the spark rapids repo.
The documentation included should cover the details and if something isn't clear please let me know as I should enhance.
Tested manually on node with multiple A100's using YARN 3.3.1 using cgroups and docker.
The plugin code was originally from Hadoop and modified to add MIG support. I also removed topology related scheduling code since we expect only 1 GPU per executor.  we use nvidia-smi -L to get the MIG information and parse that output.

@tgravescs thanks, I will do the MIG tests.


Install Failed: Dependent class is invalid and needs recompilation

When I try and install the app into a sandbox environment I get this error:
Dependent class is invalid and needs recompilation: Class
dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation: Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
Any ideas what I can do to fix it?

Here is the full error message:

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesRunOnceController: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesRunOnceController : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesRunOnceControllerTest: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesRunOnceController : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesBatchable: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesBatchableTest: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesLogger: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesLogger : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesQueueable: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesLogger : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesQueueable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesLogger : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesQueueableTest: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesQueueable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesLogger : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesSchedulable: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesSchedulable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesScheduleTest: Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesSchedulable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesBatchable : Dependent class is invalid and needs recompilation:
Class dca_cnvrt_note.ConvertNotesToContentNotesService : Field is not writeable: ContentVersion.CreatedById

Field is not writeable: ContentVersion.CreatedById
ConvertNotesToContentNotesService: Field is not writeable: ContentVersion.CreatedById

Field is not writeable: ContentVersion.CreatedDate
ConvertNotesToContentNotesService: Field is not writeable: ContentVersion.CreatedDate

Field is not writeable: ContentVersion.LastModifiedById
ConvertNotesToContentNotesService: Field is not writeable: ContentVersion.LastModifiedById

Field is not writeable: ContentVersion.LastModifiedDate
ConvertNotesToContentNotesService: Field is not writeable: ContentVersion.LastModifiedDate

Field is not writeable: Note.CreatedById
ConvertNotesToContentNotesServiceTest: Field is not writeable: Note.CreatedById

Field is not writeable: Note.CreatedById
ConvertNotesToContentNotesServiceTest: Field is not writeable: Note.CreatedById

Field is not writeable: Note.CreatedById
ConvertNotesToContentNotesServiceTest: Field is not writeable: Note.CreatedById

Field is not writeable: Note.CreatedById
ConvertNotesToContentNotesServiceTest: Field is not writeable: Note.CreatedById

Field is not writeable: Note.CreatedById
ConvertNotesToContentNotesServiceTest: Field is not writeable: Note.CreatedById

Field is not writeable: Note.CreatedById
ConvertNotesToContentNotesServiceTest: Field is not writeable: Note.CreatedById

Field is not writeable: Note.CreatedById
ConvertNotesToContentNotesServiceTest: Field is not writeable: Note.CreatedById

Invalid type: ConvertNotesToContentNotesQueueable
ConvertNotesToContentNotesTrigger: Invalid type: ConvertNotesToContentNotesQueueable

Apex class 'dca_cnvrt_note.ConvertNotesRunOnceController' does not exist
ConvertNotesFAQPage: Apex class 'dca_cnvrt_note.ConvertNotesRunOnceController' does not exist

Apex class 'dca_cnvrt_note.ConvertNotesRunOnceController' does not exist
ConvertNotesRunOncePage: Apex class 'dca_cnvrt_note.ConvertNotesRunOnceController' does not exist


fixes using unstable set_broadcast method

r? @dirvine
(maidsafe_highfive has picked a reviewer for you, use r? to override)

Is this really the only fix? As this does not move us closer to transitioning to beta / stable?

@rossmuir : this is the fix, as long as we want to use unstable features. Using unstable features is not allowed in stable rust.

@mmoadeli I get this :smile:  but can we not find stable alternatives? > https://github.com/rust-lang/rust/commit/798ce502845435d94856a7b5fed5f703b06506d1 to a novice like me using #[allow(deprecated)] feels like just kicking the can down the road?

@rossmuir I did not find the stable version of the function. My attempt was to let it compile. I will look for the proper fix, if I am asked so.

@mmoadeli think @rossmuir has a valid point. Lets definitely look for stable alternatives as indicated in the linked commit and update where we can please. Gonna merge this to not have other libraries fail builds for now. can we have this raised as an issue please @rossmuir and assigned to @mmoadeli

r? @Viv-Rajkumar


Question about apply()

I was reading the source code of the project to learn more. The source code is just awesome, it was definitely written by an artisan.
There is only one part that I didn't understand:
return children.apply(null, state);

https://github.com/aweary/react-copy-write/blob/master/src/index.js#L101
Could you explain why did you use children.apply(null, state) instead of children(state)?
Thank you muchly!

Thanks 🙂
state is stored internally as an array. Since you can provide an array of selectors to select you might have multiple selections of state for any given component.
[state1, state2, state3]

With the current API, we don't pass that array directly to the render prop, like:
<Consumer select={[selector1, selector2, selector3]}>
  {([state1, state2, state3]) => {
    // ...
  })

Because that can get annoying when you only have one selector. Instead, each selection is passed as a separate argument
<Consumer select={[selector1, selector2, selector3]}>
  {(state1, state2, state3) => {
    // ...
  })

So what apply does is take that array of state and call children with each item as an additional argument.
Hope that makes sense!

Thanks @aweary. That's a clever alternative to (...args) => fn(...args).


update README.md

my original commit was wrong , suggested by https://github.com/tork-a/jog_control/issues/17#issuecomment-406480014

Travis produces error:
KeyError: "The cache has no package named 'ros-kinetic-nextage-ros-bridge'"

could not find deb file on http://repositories.ros.org/ubuntu/testing/pool/main/r/ros-kinetic-nextage-ros-bridge/
we have deb in  http://repositories.ros.org/ubuntu/testing/pool/main/r/ros-kinetic-hrpsys/ but does not have http://repositories.ros.org/ubuntu/testing/pool/main/r/ros-kinetic-hrpsys-ros-bridge/ . so may be better to wait for
http://build.ros.org/job/Krel_sync-packages-to-testing_xenial_amd64/ ??

I think some basic MoveIt! packages' build failed, resulted to affect ours.
Now it seems get back to normal, so I rebuilt them.


Better specification of setup requirements

I think it requires cuDNN > v6 because v5 didn’t work for me and also an explanation of why CUDA 8.0 is specified (ie will 7.5 work fine or is that there so you don’t update to 9.0? - I’m not sure because I just updated to 8.0). Also, what Python version? I updated to 3.6 since it uses tensorflow 1.4 but getting a runtime warning which seems to indicate that I should have left it at 3.5. Also, you have to manually install tensorflow-gpu to get it running on the GPUs (I think) and it doesn’t get installed with the requirements.

That is correct. The setup is quite messy at the moment. I think we should work this over. We should probably also switch from egg to whl when building dists. What do you think @pminervini ? Can you handle this?

Yup

I can set up a nightly cron job for building a jack wheel:
http://jack.neuralnoise.com/dist/
Then it would be possible to install jack as follows:
pip3 install http://jack.neuralnoise.com/dist/jack-0.1.0-py2.py3-none-any.whl

But maybe there's a better way of handling this whole thing.

I think  jack will primarily be used as a whitebox framework. I, for instance, never use the setup.py script because I don't want jack to get installed on my machine. What I would like is a good documentation for how to setup jack properly without having to install it. I mean, we already have a requirements.txt which should be enough in addition with a good documentation on how to setup jack with CPU or GPU, respectively.

@dirkweissenborn ok - I'm now working on using pip install -e .[tf] and pip install -e .[tf_gpu] for installing jack without/with GPU suport; I just need to fix a couple of bugs and merge

Bam: https://github.com/uclmr/jack/pull/349


Add extra view to background

I want to add an extra view to background containing ImageView and Label when there are no chats i.e. when tableView is empty. And hide it when message data source contains data.

@arturdev I added an extra view to my view controller using storyboard which is sub class of SOMessagingViewController and the set the view hidden property to YES or NO when my message datasource is empty and inverse for tableView. But doing this somehow the tableView gets shifted into the navigation bar. First message starts from top of screen instead of being below the navigation bar. Can you please help me solve the issue?

fixed by setting background view property of tableView [self.tableView setBackgroundView:emptyView]


Allow filters to be configurable

It seems that everything is in order (documentation, defaults & tests) to use filters as a configuration option except for including the filters key in the configuration options param.

@chadmetcalf good catch, thanks!

👍 👍


Update Object.assign shim

Updated the Object.assign shim according to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign

Thanks @caskuplich.


[doc] We should lauch Pages for anyone who want to know about hypercrx

and put it as our project home page.

Oh I just found this project: https://github.com/hypertrons/hypertrons-crx-website

Idea note: To use embedded reveal.js and <section data-background-video="an/oss/url.mp4" to play demo video.

Since we already have a website which satisfies, so the issue will be closed.


Web server redirect to RESTfm.php, Redirection not working

Tried many times install on ubuntu 14, and always this error.
Checked all apache configs, and yet show this error.
http://<IP_ADDRESS>/RESTfm/?RFMversion
Redirection not working, index.html was returned instead.
Check the Apache httpd configuration has 'AllowOverride All' for the RESTfm directory.
OK: RESTfm version
4.0.1/UNKNOWN
OK: PHP version
5.5.9-1ubuntu4.14
OK: PHP PDO drivers
mysql
OK: Web Server version
Apache/2.4.7 (Ubuntu)
OK: Host Server version
Operating System Name : Linux
Host Name             : crossasia-ru-erp-NY2
Release Name          : 3.13.0-83-generic
Version Information   : #127-Ubuntu SMP Fri Mar 11 00:25:37 UTC 2016
Machine Type          : x86_64
OK: Host Server date
2016-04-20 06:33:14 -04:00 (EDT - America/New_York)
OK: Install location
/var/www/html/RESTfm
OK: baseURI (RESTfm.ini.php)
/RESTfm
ERROR: Web server redirect to RESTfm.php
http://<IP_ADDRESS>/RESTfm/?RFMversion
Redirection not working, index.html was returned instead.
Check the Apache httpd configuration has 'AllowOverride All' for the RESTfm directory.
OK: FileMaker PHP API
http://<IP_ADDRESS>/RESTfm/RESTfm.php?RFMcheckFMAPI
Found at path : /var/www/html/RESTfm/FileMaker/FileMaker.php
Version       : 13
ERROR: FileMaker Server connection test
http://<IP_ADDRESS>
FileMaker Web Publishing Engine not found at configured hostspec.
WARN: SSL enforced (RESTfm.ini.php)
SSLOnly not TRUE in RESTfm.ini.php
SSL is highly recommended to protect data, usernames and passwords from eavesdropping.
ERROR: PHP XSL extension
Not Loaded. XSLT will not function.
Only RESTfm .simple, .xml, .json and .html formats are available.
Check that your Operating System has PHP XSL/XML packages installed.

Hi Amanbolat,
There is an unfortunate bug in the version of Apache the ships with
Ubuntu 14.04 which interferes with the redirect.
If you are positive you have enabled everything, then try editing
.htaccess and remove the comment(#) from the line:
DirectoryIndex disabled
(This isn't the default setting because it interferes with the other
setup diagnostics).
Regards,
Gavin.
On 20/04/16 20:38, Amanbolat Balabekov wrote:

Tried many times install on ubuntu 14, and always this error.
Checked all apache configs, and yet show this error.
http://<IP_ADDRESS>/RESTfm/?RFMversion
Redirection not working, index.html was returned instead.
Check the Apache httpd configuration has 'AllowOverride All' for the
RESTfm directory.
OK: RESTfm version
4.0.1/UNKNOWN
OK: PHP version
5.5.9-1ubuntu4.14
OK: PHP PDO drivers
mysql
OK: Web Server version
Apache/2.4.7 (Ubuntu)
OK: Host Server version
Operating System Name : Linux
Host Name : crossasia-ru-erp-NY2
Release Name : 3.13.0-83-generic
Version Information : #127-Ubuntu SMP Fri Mar 11 00:25:37 UTC 2016
Machine Type : x86_64
OK: Host Server date
2016-04-20 06:33:14 -04:00 (EDT - America/New_York)
OK: Install location
/var/www/html/RESTfm
OK: baseURI (RESTfm.ini.php)
/RESTfm
ERROR: Web server redirect to RESTfm.php
http://<IP_ADDRESS>/RESTfm/?RFMversionhttp://<IP_ADDRESS>/RESTfm/?RFMversion
Redirection not working, index.html was returned instead.
Check the Apache httpd configuration has 'AllowOverride All' for the
RESTfm directory.
OK: FileMaker PHP API
http://<IP_ADDRESS>/RESTfm/RESTfm.php?RFMcheckFMAPIhttp://<IP_ADDRESS>/RESTfm/RESTfm.php?RFMcheckFMAPI
Found at path : /var/www/html/RESTfm/FileMaker/FileMaker.php
Version : 13
ERROR: FileMaker Server connection test
http://<IP_ADDRESS>
FileMaker Web Publishing Engine not found at configured hostspec.
WARN: SSL enforced (RESTfm.ini.php)
SSLOnly not TRUE in RESTfm.ini.php
SSL is highly recommended to protect data, usernames and passwords from
eavesdropping.
ERROR: PHP XSL extension
Not Loaded. XSLT will not function.
Only RESTfm .simple, .xml, .json and .html formats are available.
Check that your Operating System has PHP XSL/XML packages installed.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
https://github.com/GoyaPtyLtd/RESTfm/issues/3

Thank you for quick reply.

http://www.restfm.com/restfm-manual/install/advanced-installations
"A minimum of PHP 5.2.11 with Apache 2 web server are required."
There's nothing wrong with using Apache 2.4.7 as shipped with Ubuntu 14.04, it's just an issue during the initial setup.

gav-, Thank you very much.
Now it works!


fix: running all tests [IA-160]

Since we're focussing on build.sbt and Helpers in this PR, I'll just make a comment for making sure it's written somewhere. I noticed that gateway subproject doesn't use the -Werror command which means that a lot of warnings found in gateway is being ignored. So either add -Werror in this PR or make a separate ticket addressing this since I tried to add it in myself but some of the errors were out of my area of concern.

The issue with the broken build is an urgent fix and the warnings not being errors is not, so I'd lean towards separating that fix out into its own PR.

@miguelTaningcoYoppworks @dag-yoppworks with wErrors enabled, there is not much to change. It is really just dependencies that aren't used in one file.
HOWEVER - there is a warning that sbt always gives for the dependency import io.circe.generic.auto._. This import is necessary and breaks IntelliJ when taken out on lines where case classes are decoded or encoded using circe's autoderivation.
I am not really sure what to do about this. Circe autoderivation seems to break wErrors... @reid-spencer maybe you have some advice?


Update "Hide WaniKani answers.user.js" to use https

Modified "wanikani.com/Hide WaniKani answers.user.js" to use https instead of http.
Https is now required on wanikani.

Oh nice, thanks for the PR!

Your script is getting a lot of love on WK these days.
Thanks so much for merging the PR!


Update virtual-network-tcpip-performance-tuning.md

Added clarification that IP fragmentation is not supported and should not be relied upon.

#sign-off


Remove TLS from install guide

Explanation
Remove TLS Plugin from install docs
/kind documentation

Hello, I am a code review bot on flows.network.
It could take a few minutes for me to analyze this PR. Relax, grab a cup of coffee and check back later. Thanks!

I don't think we should remove the rustTLS plugin directly because ome existing WasmEdge programs may depend on the rustTLS plugin. How about adding a special note for the RustTLS plugin?


建立了 admin 账号，但是重启程序后，仍然报错，同时 无法访问<IP_ADDRESS>:8090

报错日志为 ：core-1  | Process SpawnProcess-1:
core-1  | Traceback (most recent call last):
core-1  |   File "/app/utils/pb_api.py", line 21, in init
core-1  |     admin_data = self.client.admins.auth_with_password(email, password)
core-1  |   File "/usr/local/lib/python3.10/site-packages/pocketbase/services/admin_service.py", line 81, in auth_with_password
core-1  |     response_data = self.client.send(
core-1  |   File "/usr/local/lib/python3.10/site-packages/pocketbase/client.py", line 125, in send
core-1  |     raise ClientResponseError(
core-1  | pocketbase.utils.ClientResponseError: Response error. Status code:400
core-1  |
core-1  | During handling of the above exception, another exception occurred:
core-1  |
core-1  | Traceback (most recent call last):
core-1  |   File "/usr/local/lib/python3.10/multiprocessing/process.py", line 315, in _bootstrap
core-1  |     self.run()
core-1  |   File "/usr/local/lib/python3.10/multiprocessing/process.py", line 108, in run
core-1  |     self._target(*self._args, **self._kwargs)
core-1  |   File "/usr/local/lib/python3.10/site-packages/uvicorn/_subprocess.py", line 80, in subprocess_started
core-1  |     target(sockets=sockets)
core-1  |   File "/usr/local/lib/python3.10/site-packages/uvicorn/server.py", line 65, in run
core-1  |     return asyncio.run(self.serve(sockets=sockets))
core-1  |   File "/usr/local/lib/python3.10/asyncio/runners.py", line 44, in run
core-1  |     return loop.run_until_complete(main)
core-1  |   File "uvloop/loop.pyx", line 1517, in uvloop.loop.Loop.run_until_complete
core-1  |   File "/usr/local/lib/python3.10/site-packages/uvicorn/server.py", line 69, in serve
core-1  |     await self._serve(sockets)
core-1  |   File "/usr/local/lib/python3.10/site-packages/uvicorn/server.py", line 76, in _serve
core-1  |     config.load()
core-1  |   File "/usr/local/lib/python3.10/site-packages/uvicorn/config.py", line 434, in load
core-1  |     self.loaded_app = import_from_string(self.app)
core-1  |   File "/usr/local/lib/python3.10/site-packages/uvicorn/importer.py", line 19, in import_from_string
core-1  |     module = importlib.import_module(module_str)
core-1  |   File "/usr/local/lib/python3.10/importlib/init.py", line 126, in import_module
core-1  |     return _bootstrap._gcd_import(name[level:], package, level)
core-1  |   File "", line 1050, in _gcd_import
core-1  |   File "", line 1027, in _find_and_load
core-1  |   File "", line 1006, in _find_and_load_unlocked
core-1  |   File "", line 688, in _load_unlocked
core-1  |   File "", line 883, in exec_module
core-1  |   File "", line 241, in _call_with_frames_removed
core-1  |   File "/app/backend.py", line 5, in
core-1  |     from insights import message_manager
core-1  |   File "/app/insights/init.py", line 5, in
core-1  |     from .get_info import get_info, pb, project_dir, logger, info_rewrite
core-1  |   File "/app/insights/get_info.py", line 27, in
core-1  |     pb = PbTalker(logger)
core-1  |   File "/app/utils/pb_api.py", line 25, in init
core-1  |     user_data = self.client.collection("users").auth_with_password(email, password)
core-1  |   File "/usr/local/lib/python3.10/site-packages/pocketbase/services/record_service.py", line 173, in auth_with_password
core-1  |     response_data = self.client.send(
core-1  |   File "/usr/local/lib/python3.10/site-packages/pocketbase/client.py", line 125, in send
core-1  |     raise ClientResponseError(
core-1  | pocketbase.utils.ClientResponseError: Response error. Status code:400
env的配置为 ：

来个大佬帮忙看下，

我也遇到了这个问题

重新尝试了N次，已经解决了。 在.env 的配置文件中，export PB_API_AUTH="*|1234567890"， 使用这个替换原先的，*号替换为自己的邮箱即可，密码与这个一致，在初始的 env_sample 文件，定义的密码（123467890）错误， 不符合最少10位的要求。


Two-finger pinch scrolls

VSCode Version: 1.10.2
OS Version: macOS 10.12.3

Steps to Reproduce:

Pinch in and out with two fingers on any long file.

Expected behavior: nothing happens.
Actual behavior: the screen scrolls up or down very quickly, faster than an actual two-finger swipe. This makes it way too easy to accidentally scroll far enough that you completely lose your place.

When i restore down the vs-code and then maximized again the scroll work fine which is very weird.


Split README into Scala / PySpark / R

The Scala & PySpark library ecosystems and userbases have diverged enough to consider splitting up the README.
Scala users might consider spark-daria & deequ.
PySpark users should focus on the mirror libraries quinn and python-deequ.
The current setup of the README is best for the language polyglots, but think most users are only interested in one API.  I'd be happy to take a stab splitting this up if folks think it'd be a good idea.

I am a bit skeptical about this. While there exist libraries targeted for specific languages, there are not that common (and often not well maintained).  Many projects that we include here are one way or either language agnostic  (i.e. data sources) or provide bindings for at least Scala and Python.
There is also a problem with 3rd party language bindings.
At some point I considered adding some indicator (visual for GitHub, tagging to support filtering), but I seemed like an overkill, given relatively small number of actively maintained projects.

Cool, happy to keep the organization as-is.  This project adds a lot of value either way.  Thanks for responding!


merge the hnet model

Hi, thanks for your great work. I want to implement h-net function. I found lots of code in lanenet_hnet_loss.py and lanenet_hnet_model.py.
I am curious that since related codes were finished , why was hNET not implemented? Are there any unsolved problems? If I want to realize this function, what should I do?

@zhoulukuan You can check the hnet_model file and it's poorly implemented. You can only feed the network with train data with single batch so the model can not converge correctly. Once I got enough time i will reimplement it. And you're welcome to supply your own implementation if you find it works well.

Thanks for your reply, but I have difficulty understanding. You means that h-net must train with single batch independently, if not, this model can not converge correctly?

@zhoulukuan No i mean i only implement a single batch version so the model can not converge correctly

@MaybeShewill-CV  OK, thanks a lot.


imagecopyresampled(): supplied resource is not a valid Image resource

I have tried multiple code setups for the image class and I cannot get it working, the way I need it to. I can do one file at a time. If I want to create thumbnails it errors. These are the setups I've tried. I have been digging through the class trying to find where it goes wrong, but I can't find it anywhere.
foreach ($this->sizes as $size) {
	$copyImage = \Config\Services::image( 'gd' )
			->withFile( "{$folderPath}/{$filename}.{$extension}" )
			->resize( $size, $size )
			->save( "{$folderPath}/{$filename}x{$size}.{$extension}" );
}

$copyImage = \Config\Services::image( 'gd' );
foreach ($this->sizes as $size) {
	$copyImage->withFile( "{$folderPath}/{$filename}.{$extension}" )
			->resize( $size, $size )
			->save( "{$folderPath}/{$filename}x{$size}.{$extension}" );
}

I won't have time to look into this until later today, but I would guess it's due to how you're calling \Config\Services::image( 'gd' ). That will return a shared instance by default. Try this:
\Config\Services::image( 'gd', null, false)

You're right, it does make sense. And looking at the code, withFile should refresh, since it creates a new image. Looking deeper, though, it looks like the $resource value isn't reset during the withFile call, which is probably why it's always using the same file. I'll push a fix for that momentarily.


[WIP] [7] Deployments Table - show rollback link

This PR:

[x] adds a deployment link to the deployments table
[x] adds an action to the marathon store to delete the deployment
[ ] introduces a confirmation modal
[ ] removes the deployment from the store if the delete request is succesful
[ ] handles errors on the delete request

This PR depends on #372

Reviewer: @daiyiwhale

Possibly not related to this PR. Feel free to ignore, should not be a blocker.
If I create a fresh service and then click on the deployment tab, I receive this error:
Cannot read property 'getId' of undefined in DeploymentsTab.js?3396:66

The Rollback button looks great and triggers the rollback successfully.
Although I miss a little bit UX feedback after I clicked on it. Very silent.

You could consider a confirm dialog before the actual rollback is triggered.
Like this or in Marathon UI:
https://github.com/dcos/dcos-ui/blob/feature/1066-service-actions/src/js/components/ServiceDetail.js#L111
Just an idea..

Besides the small bug.
It LGTM!

Thanks for the extensive feedback @aldipower! Yes, this is a WIP so we're still missing the modal. The issue you're seeing here https://github.com/dcos/dcos-ui/pull/388#issuecomment-225147651 is resolved by #378 and can be ignored here.

OK, very cool!

✔ This PR is ready for review.

retest this please

retest this please

retest this please

A few minor nits, but this looks pretty good! Great job 💯 ✨

The rollback process looks a little strange...

Yes, I agree. What do you suggest? Put the deployment into a disabled state until the next poll of the deployments, then replace it?

@orlandohohmeier and I had a chat; we think that the right way to do things is to mark the old deployment as 'rolling back' until the new data comes in to make it clear that one has replaced the other. @leemunroe, what do you reckon?

👍  Good idea. Much better I think.


"Izvoru", "Bărbuncești", "Grăjdana" and "Haleș" are listed in the drop-down menu

Description:
"Izvoru", "Bărbuncești", "Grăjdana" and "Haleș" are listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "Izvoru" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Izvoru, BUZĂU (Tisău)".

Step 2
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 3
Type "Bărbuncești" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Bărbuncești, BUZĂU (Tisău)".

Step 4
Press "x" button.

Expected results
The location was deleted from the search bar.

Step 5
Type "Grăjdana" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Grăjdana, BUZĂU (Tisău)".

Step 7
Type "Haleș" in the search bar.

Expected results
The location is listed in the drop-down menu as "Sat Haleș, BUZĂU (Tisău)".


Docs: Improve section titles

"Quick Start" sounds more tempting than "Get Started" in an "I won't spend much time and I'll know enough" kind of way.

"Handbook Reference" should be "Language Reference" or "TypeScript Reference", or just "Reference".

"Tutorials" is a bit confusing -- I think that something like "Tool Tutorials" or "Tools and Tutorials" or similar would clarify it.

Cool, yeah, a bunch of these make sense. A lot of it is carrying the existing handbooks current structure 👍
This is the long-term goal for the overall sitemap: https://www.figma.com/file/Sew0DK1pRVPVXF6aAarfQHjk/Sitemap?node-id=0%3A1

I believe I can help with this.
Can you please confirm this is the correct page?
https://www.typescriptlang.org/docs


Add kubelet metrics preset

Similar to k8s attributes processor, we need a preset for kubelet metrics collection for daemonset mode

@povilasv would you like to work one this one along with https://github.com/open-telemetry/opentelemetry-helm-charts/issues/421 ?


Change naming convention of api version in url

Is your feature request related to a problem? Please describe.
In the generated versioning v1_0, v1_2. The underscore is unintuitive when it comes to api versioning.
Describe the solution you'd like
Change the underscore to a dot.
Describe alternatives you've considered
None
Additional context
None

VersionedFastAPI takes an argument prefix_format, the default is:
prefix_format: str = "/v{major}_{minor}"


Update profile_tasks.py

Extract duplicate code to function.

any changes you need to this @jlafon. Happy to close if you're not accepting PRs

Sorry for the slow reply. Is there any reason that you didn't put the method in the class?

Nope. Blindly copying the style of https://github.com/junaid18183/ansible_home/blob/master/ansible_plugins/callback_plugins/timestamp.py.old

Would you mind putting the method on the class and updating the PR? I can do it otherwise.

Mashup/modified plugin merged into v2 release of Ansible. Will close this PR and direct further improvements there. Thanks @jlafon!


Do not use alloc in examples

@Dirbaio I thought it would be good to finish this up. Can you check my that Packet implementation looks reasonable in the examples?
Thanks.

LGTM! :+1: Thanks for taking care of this :)


Change bundle elimination to use existing foldables and optimize foldable reduction.

Small fix.

Looks like this needs to be merged with main.


Make it installable

@rmartinezduque could you please let me know what needs to be done in iOS to make this work?
In Android it's already working.

Here's the documentation:
https://developer.apple.com/library/content/documentation/AppleApplications/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebApplications.html

Thanks @reyes. We'll add those iOS metas 👍


FAN only mode is not found (Only Cool/Heat/Auto shown in HomeKit)

hello, my air con unit does support
Auto/Cool/Heat/dehumid/Fan only
however, in the HomeKit accessories, only Cool/Heat/Auto is found.
in the cloud comfort app it's available and working as expected.
Is there any way the FAN only mode can be added?
thanks.

Done in #243 . Will be in next beta or public release.

Thanks and appreciate that. happy to mark it as closed.

@cyrusauyeungc 2.2.0-beta.1 just released. Can you try?

thanks @mkz212 for the notification. will update the plugin now and keep you posted!

yes it's confirmed working.
When Auto is selected in HOME, FAN mode would be on directly.


⚠ Roblox Devforum has degraded performance

In 40c858f, Roblox Devforum (https://devforum.roblox.com) experienced degraded performance:

HTTP code: 504
Response time: 10285 ms

Resolved: Roblox Devforum performance has improved in 7ec182f.


[1.10.2 Beta 4] Golem seals render is off when sneaking

See image attached.

That was actually already changed for beta 5 - sneaking renders it through blocks which caused the strangeness above. When sneaking now the seal will lose its 'thickness', but at least it doesn't look like that.


Update create form

Updates Add Linode form layout and closes #894 ( layout basics already added to styleguide index).

Coverage increased (+0.08%) to 86.073% when pulling 2c93c102071cf22d1213adbcb5ecf69e9c6fdefe on mparke:update-create-form into e95de6ad0771a1f3031a10658c71c42ffa645ba6 on linode:master.

Coverage increased (+0.08%) to 86.073% when pulling 70c1e5137768ed196b49dd14552209eb48be1d6a on mparke:update-create-form into e95de6ad0771a1f3031a10658c71c42ffa645ba6 on linode:master.

Coverage increased (+0.05%) to 86.189% when pulling 2ad4951c5354608c6725722c113a0ec4757edbe0 on mparke:update-create-form into 8db1cad7fb13dd36e4770ca72f7996cf5becd55e on linode:master.

Coverage increased (+0.05%) to 86.195% when pulling 105b32c92f359e8cb41e749b1e138c41f953e461 on mparke:update-create-form into 8db1cad7fb13dd36e4770ca72f7996cf5becd55e on linode:master.

Coverage increased (+0.05%) to 86.195% when pulling b882337bfe5140e9a61294cdbcb9adadad1b37a3 on mparke:update-create-form into 8db1cad7fb13dd36e4770ca72f7996cf5becd55e on linode:master.

Coverage increased (+0.05%) to 86.195% when pulling c1ea1192e59af9de768284e4e816c86eb3637caa on mparke:update-create-form into 8db1cad7fb13dd36e4770ca72f7996cf5becd55e on linode:master.

Does this change the visuals or behavior of the page? Or is it just cleaning up the CSS and using the newer components?

Just cleanup


[cmd] Add new command token in the CLI tool

Command Description: Fetch an attestation report from GCE VM vTPM and send it to Google Attestation Service for an OIDC token.
This command improves usability for a GCE VM user.
This PR replaces closed https://github.com/google/go-tpm-tools/pull/368. Branch name changed.

@jkl73 @kongoshuu Could you take a look?

LGTM, let's hold the merge until the ek cert is more available on gce instance.

/gcbrun

Please hold off merging until the internal privacy policy reviewers give the go-ahead, since this is sending data from a user (should be a nonce, but could be anything) to a Google service.

/gcbrun

/gcbrun

/gcbrun


make no_std & a little cleanup

Hello, first of all, thank you very much for making this csound bindings. I'm starting to study csound and this is coming handy.
So I found a couple of quick things I could help you with in the csound-sys crate, and this PR:

in lib.rs:

makes the crate no_std
removes some long unneeded prefixes, like e.g.: ::std::option::

in Cargo.toml

changes the api category to external-ffi-bindings as indicated by crates.io
simplifies the declation of dependencies

and fixes a typo in Readme.md

Also, I wouldn't mind to help with more things if you want. Are you open to collaborations?
PS. Anda, acabo de ver que eres de Costa Rica, si prefieres que hablemos en español dímelo.

Thank you. I am glad to have you collaborating on this project. Help is always welcome !!!.
About no_std, I am not pretty sure if it is necessary or useful, considering that Csound does memory allocation internally. If we want to do it we will need also to disable the std feature in the libc crate as well. I want to test this..can you test it locally?
just change: this to something like:
csound_sys = {path = "csound_sys"}
with the libc default features set to false, and see what happens.

He, you're right, I forgot to remove the default features of libc. I've just tested it with that change and it does still work as well as before. So I've updated the commit.
IMHO it's always useful to not require the Rust standard library if it's not really needed, since that opens up for being a dependency for many more crates.

On the other side, I only focused on making the FFI bindings no_std, since that's the easiest part. The main crate would need more work since it uses a lot of std elements like String, Vec, std traits.... But this is a step in the right direction.

thank you !


Rename Css.js to CSS.js

wait I already did this

wait I already did this

just was a quick fix for github for after your pr - all good, i think the git commit from your prev pr just didnt register the filename's change for ignore.case (something to do with mac's casing base setup)


SQLSTATE[42S02]: Base table or view not found: 1146 Table 'pmg_db.health_check_result_history_items' doesn't exist

I installed the package and got an error SQLSTATE[42S02]: Base table or view not found: 1146 Table 'pmg_db.health_check_result_history_items' doesn't exist

@ArtemBulavin Please follow this instruction
https://spatie.be/docs/laravel-health/v1/installation-setup#content-running-the-checks-by-scheduling-a-command

Please add this to your documentation.


Post release task for 0.59.1

cherrypick change-log, remove old towncrier
cherrypick CI fixes on release branch
fix towncrier_check.py script

Post-merge:

update https://github.com/numba/numba/issues/9485

Notes for reviewer:
cherrypick commits from #9480:

Remove notes from 0.59.0
Remove release notes for 0.59.1
Skip test_issue9490_non_det_ssa_problem for PPC
Reduce thread use to avoid stuck in TBB on machines with high thread …

New commits:

Get changes for release note and installing.rst from 0.59.1
Closes #9501. Add link to bug description.
Update towncrier checker to look into towncrier generated release notes


[BUG] custom kill/hitsound doesnt work on mm

If you loaded offline with bots or custom map, hitsound will work. But, once you cliked play button. it says "unable to queue due to thirdparty files loaded", if you restarted the game and loaded the config with custom hitsound. when you clicked the play button and you are in the game. custom kill/hit doenst work

Bypass sv_pure #2935

Bypass sv_pure #2935

doesn't work anymore

pls fix


Support graph-oriented indexing

Pull expressions allow for recursion. One could also write rules, or even regular queries, that do path traversal over attributes.
We should consider whether there are any indexing options to expose to consumers that would help Datomish efficiently answer these queries. For example, a transitive closure index on an attribute would, at the cost of materializing and maintaining the transitive closure matrix/list, turn a recursive SQL join into a simple lookup, and also exposes minimum distance functions cheaply.
This is one example of a set of ways in which Datomish might support graph queries and other kinds of operations at a higher level of abstraction, just as :fulltext true does for full-text search. We should be on the lookout for more.

Another thought: this is also the way I'd approach geospatial data.

As noted in #129, it's worth considering attached databases here to avoid swamping the main DB. Indeed, the index updates can occur outside of the main transact operation and still feed back in to be used in queries.

http://homepages.inf.ed.ac.uk/libkin/papers/tc-sql.pdf is relevant.


Model attendance

Resolves #117

Codecov Report

Merging #118 into master will increase coverage by 1.00%.
The diff coverage is 95.04%.

@@             Coverage Diff              @@
##             master     #118      +/-   ##
============================================
+ Coverage     77.59%   78.60%   +1.00%
- Complexity      693      762      +69
============================================
  Files           113      120       +7
  Lines          1973     2094     +121
  Branches        206      217      +11
============================================
+ Hits           1531     1646     +115
- Misses          397      402       +5
- Partials         45       46       +1

Impacted Files
Coverage Δ
Complexity Δ

...ava/seedu/address/model/attendance/Attendance.java
90.90% <90.90%> (ø)
11.00 <11.00> (?)

...main/java/seedu/address/model/attendance/Week.java
90.90% <90.90%> (ø)
11.00 <11.00> (?)

...address/model/attendance/AttendanceRecordList.java
93.47% <93.47%> (ø)
19.00 <19.00> (?)

...edu/address/model/attendance/AttendanceRecord.java
97.36% <97.36%> (ø)
20.00 <20.00> (?)

...ava/seedu/address/commons/util/CollectionUtil.java
94.44% <100.00%> (+6.94%)
9.00 <4.00> (+4.00)

...ndance/exceptions/AttendanceNotFoundException.java
100.00% <100.00%> (ø)
1.00 <1.00> (?)

...dance/exceptions/DuplicateAttendanceException.java
100.00% <100.00%> (ø)
1.00 <1.00> (?)

...el/attendance/exceptions/InvalidWeekException.java
100.00% <100.00%> (ø)
1.00 <1.00> (?)

...eedu/address/model/lesson/NumberOfOccurrences.java
81.81% <100.00%> (+1.81%)
10.00 <1.00> (+1.00)

... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f93175...a99ef6f. Read the comment docs.


ng-table with data-title should have data-title-class

It will be nice to have an attribute to set class name for th when one uses data-title to set th. With this attribute, one can easily customise th individually i.e. <td data-title="'Date'" data-title-class="'table-date-column'">

I take that back, I just realised this have already been implemented.


Drop the React Arbiter Dependency

Description
I think the time has come to discontinue development of react-arbiter. While this part served its duty, we should include a (non-React dependent) utility library to be able to work with pilets.
As such, while piral-core still brings Piral to a fully working microfrontend framework level, this library would form a basis for loading / handling pilets. It could be used in Piral-like frameworks that use some other framework as base layer (but otherwise still being compatible to the feed service and the CLI among other things).
Background
react-arbiter is developed outside of the Piral monorepo. It brings the inner workings of handling pilets to the table. However, it is - for some reason; good or bad, also coupled to React. Most of these couplings are irrelevant to us, but the code is still there and requires unnecessary bytes in the final bundle.
Discarding react-arbiter would lead to a more flexible approach with a more streamlined release.
Discussion
Right now I think this new lib should be still used in react-arbiter - thus still supplying support for any users of react-arbiter (we know a couple) and providing dog fooding outside of Piral.

Landed in develop / preview.


Max in Flight: Document definition inaccurate

Current definition - Under Worker VM Max in Flight, enter the maximum number of worker VMs you want created.
This should be the maximum number of non-canary worker instances to update in parallel within an availability zone. Also, from the documentation it is not clear that if this parameter will take effect during upgrade of PKS clusters.
cc @kroberts7
Reference: https://bosh.io/docs/manifest-v2/

@outofmem0ry Thanks for your feedback ! I have fixed the line.
We mention max in flight in upgrades here: https://github.com/pivotal-cf/docs-pks/blob/master/understanding-upgrades.html.md.erb
Is further explanation needed?

@kdolor-pivotal - there are few other issues with https://docs-pcf-staging.cfapps.io/runtimes/pks/1-2/understanding-upgrades.html#max-in-flight and we'll be creating a separate issue for that.

Thanks @outofmem0ry I will close this issue, as we await the forthcoming issue regarding https://docs-pcf-staging.cfapps.io/runtimes/pks/1-2/understanding-upgrades.html#max-in-flight


Migrate login/submit/makePublic/clone/remove/etc to SBOLStack

Should move the login, submit, makePublic, clone, remove operations part of SBOLStack rather than SynBioHub

Having second thoughts... would it be more secure to force users to go through synbiohub and have no direct access to SBOL Stack?  This would be for both getting parts and uploading parts?

Current thinking is to merge SBOL Stack and SynBioHub

All SBOL Stack queries that can come from the SBOL Stack frontend java code can direct to SynBioHub and are forwarded to Stack.
In the future, combine sbolstack-api with synbiohub


Show the current mouse coordiantes

This is partly requested by helios1014 on Discord. It will show the coordiantes of the mouse cursor relative to the sheet, on something similar to a status bar perhaps.
This is scheduled in the upcoming new version.

This is done in the DEV branch and will be shipped with the new version.


It calls all my proxies bad. I have no clue why.

hi, i am a full noob :D but very interested in learning in this topic and in python.
i have the issue that It calls all my proxies always bad.
even when testsides say they are good and they work with
TBN's Tube Viewer too. I get views with that software. Also they get fast removed if i use it to much. If i use it only a little it stays.
So my proxy are alright i think.
Like you can see all requirements are installed i think.
What do you think to use proxys to play playlists? Youtube playlists get played usually much longer so youtube should detect
less views? i aim for much viewtime and not for views.
Would love when this programm could play 3 random videos of my playlist (youtube counts 4-5 views per 24houres anyways only) and go to next proxy and repeat.

free proxy?
or your proxy needs authentication that you're not supplying?
the playlist is not supported in this script.. if I get some free time, I will try to add this feature in future

And how is it checking against youtube?
what is it checking for?
how does it know youtube flag this ip? cant imagine that youtube gives a, i wont count those views later respond after i first gave the views.
i get views with TBN's Tube Viewer and these ips work with that software on youtube.
if i buy 100 proxies for 2,99$ a month, how much views i can get with that do you think from experience?

I answered your question already in another issue you mentioned...it's very simple just by sending a request to youtube
I don't have any idea about the software you are talking about
I can't tell anything for sure about how many views you will get...you may get 10 views you may get 100 views..you need to play around to see what's work best for you

What does 100 threads mean in the proxytester? thats not webtabs right? thats like how much resources it get right?
when the programm works with a good proxy. its not open a window right?
it hides that chrome tab and mutes it right?
can i turn it on, so i can see that window in that it plays right now?
would enjoy more to see what it does.


deploy: Installation via Operator

This is first iteration to install peer-pods stack via Operator.
The series includes the following

Deployment manifests
Instructions to build the required images
README

Fixes: #121

/hold
Pending testing with different providers.

Successfully tested on AWS.


After last updates, ForneyLab cannot build message passing algorithm.

After the commit 61aba6fef0b06b12cbba177c60089a17d8ebd295 (Renamed update rules for Equality node.), ForneyLab fails to build the algorithm for the following state-space model:
z_t ~ N(z_{t-1}, \gamma^{-1})
x_t ~ N(z_{t}, \tau^{-1})
y_t ~ N(z_{t}, \omega*\tau^{-1})

The corresponding code:
using ForneyLab

# Building the model
n_samples = 1
fg = FactorGraph()

# State prior
@RV z_0 ~ GaussianMeanVariance(placeholder(:m_z_0), placeholder(:v_z_0))

@RV γ ~ Gamma(placeholder(:a_γ), placeholder(:b_γ))

@RV τ ~ Gamma(placeholder(:a_τ), placeholder(:b_τ))

# Transition
z = Vector{Variable}(undef, n_samples)
# Input
x = Vector{Variable}(undef, n_samples)
# Output
y = Vector{Variable}(undef, n_samples)
# Intervention
ω = Vector{Variable}(undef, n_samples)

z_i_min = z_0
for i in 1:n_samples

    @RV z[i] ~ GaussianMeanPrecision(z_i_min, γ)

    @RV x[i] ~ GaussianMeanPrecision(z[i], τ)

    @RV ω[i]

    @RV y[i] ~ GaussianMeanPrecision(z[i], ω[i]*τ)

    # Data placeholder
    placeholder(y[i], :y, index=i)
    placeholder(ω[i], :ω, index=i)
    placeholder(x[i], :x, index=i)

    # Reset state for next step
    z_i_min = z[i]
end

q = PosteriorFactorization(z_0, z, γ, τ, ids=[:Z0 :Z :Γ :T])
algo = messagePassingAlgorithm(free_energy=true)

The error at the aforementioned  commit:
LoadError: No applicable SumProductRule{Multiplication} update for Multiplication node with inbound types: Message{Union{Gamma, Wishart},var_type} where var_type<:ForneyLab.VariateType, Nothing, Message{PointMass,var_type} where var_type<:ForneyLab.VariateType

Actual error related to the issue is:
LoadError: Multiple applicable SumProductRule{Equality} updates for Equality node with inbound types: Message{Union{Gamma, Wishart},var_type} where var_type<:ForneyLab.VariateType, Nothing, Message{Gamma,var_type} where var_type<:ForneyLab.VariateType

This happens because of the newly introduced rules for MP around Equality node. I'm working on a fix.

Resolved by a03176d5a6677c9eb67ec23f27c732ac6defea5e.


Add AWS SNS/SQS support

Description
Add a pubsub binding for AWS SNS/SQS
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[x] Code compiles correctly
[x] Created/updated tests
[ ] Extended the documentation / Created issue in the https://github.com/dapr/docs/ repo: dapr/docs#[issue number] TODO

Hey @khous, we left some PR feedback. This is a great addition that we'd like to get into the next release.

Hey @khous, we left some PR feedback. This is a great addition that we'd like to get into the next release.

Thanks @yaron2! I'm going to start chipping away at these and finishing the docs today.


Set TCP_NODELAY for sockets

During normal operation we send two small messages shortly after one
another (chainsync's RequestNext and blockfetch's RequestRange) when we
learn of a new block.
Without this option we would wait for an ACK of RequestNext before we
sent RequestRange.

bors r+


v1.10 backports 2022-05-31

#16647 -- ipsec: Fix off-by-one error on max keyID (@pchaigno)
#19885 -- docs: Add docs-builder build as dependency to live preview (@qmonnet)
#19888 -- docs: Remove '\r' chars from grep result to parse Alpine image name (@qmonnet)

small conflict as the builder-image command was slightly different

#19886 -- Do not disable peer service when hubble.listenAddress is empty (@chancez)

some minor conflicts for docs, had to run make -C install/kubernetes && make -C Documentation helm-values.rst

#19856 -- Bugtool: Add additional tc commands. (@tommyp1ckles)
#19927 -- api: change "group not found" log to debug (@tklauser)
#19809 -- Add counter to track all datapath timeouts due to FQDN IP updates (@ungureanuvladvictor)
#19893 -- docs: Fix max SPI value for IPsec key rotations (@pchaigno)
#19930 -- docs: Fix incorrect FQDN flag (@pchaigno)
#19955 -- cmd: Allow more complicated patterns in map string type. (@sayboras)

Once this PR is merged, you can update the PR labels via:
$ for pr in 16647 19885 19888 19886 19856 19927 19809 19893 19930 19955; do contrib/backporting/set-labels.py $pr done 1.10; done

or with
$ make add-label BRANCH=v1.10 ISSUES=16647,19885,19888,19886,19856,19927,19809,19893,19930,19955

/test-backport-1.10

/test-backport-1.10


Update log to show proper values

Changes
Changes to log to display values properly.
Why Are Changes Being Made
Note:
It was considered moving some of the logic to a function but it was decided that this approach was fine and helped increase readability.

Codecov Report
Base: 38.88% // Head: 41.46% // Increases project coverage by +2.57% :tada:

Coverage data is based on head (ffb4bb6) compared to base (8c22b93).
Patch coverage: 93.10% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   38.88%   41.46%   +2.57%
==========================================
  Files          14       14
  Lines         558      586      +28
==========================================
+ Hits          217      243      +26
- Misses        317      318       +1
- Partials       24       25       +1

Impacted Files
Coverage Δ

pkg/response/match/matcher.go
70.00% <93.10%> (+6.95%)
:arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


removed unnecessary continue statement

for simplicity, I removed extra "not" and "continue" statements in the loop.
to further explain :
for num in range(10):
if num % 2 == 0:
continue
print(num)
and
for num in range(10):
if not num % 2 == 0:
print(num)
both give the same output.

@ZaidGhazal I honestly don't see why the else statement is perceived as useless. On removal, you would have key = k as a final result of the if statement on top of it, and you would also have nothing if the "if statement" on top of it is false.

@ZaidGhazal I honestly don't see why the else statement is perceived as useless. On removal, you would have key = k as a final result of the if statement on top of it, and you would also have nothing if the "if statement" on top of it is false.

@jaykay99992
Thanks for feedback.
The thing I meant is to define key = k before the if statement, so the key variable will have thek value by default.


Use on Express Js server

Can I use Bigheads on Express js server?

Yes you can, you just need to server render the React component.


pre-type 2 pneumocyte

Preferred term label: pre-type 2 pneumocyte
Synonyms
pre-type II alveolar epithelial cell PMID:12114192
alveolar pre-type II epithelial cell PMID:9624168
Definition
Precursor of type II pneumocyte that does not yet produce surfactant. These cells do not have lamellar bodies, which are a marker of type II pneumocyte maturity. PMID:1316350
Curator note: A central feature of the fetal respiratory distress syndrome seems to be the presence in the lung of abundant pre-type II alveolar epithelial cells. PMID:1316350
Parent term
pneumocyte CL:0000322
ORCID
https://orcid.org/0000-0002-0819-0473

@paulacalipho, thank you for adding CL:4040003 'fetal pre-type II pneumocyte'.
It will appear in the next Cl release.

@bvarner-ebi thanks for your input and help


Incrementals Statistics (SQL 2014)

Hi,
It's possible to add fonctionnality, like indexes partitionned, to update statistics by partition in Statistics maintenance plan.
Regards

This is how it works for incremental statistics in the latest version.
https://ola.hallengren.com/versions.html
6 Jun 2018
"Added support for incremental statistics. It will automatically update statistics on the partition level for incremental statistics, if you have @PartitionLevel = 'Y' (which is the default)."
Please also see issue https://github.com/olahallengren/sql-server-maintenance-solution/issues/42.

Thanks


Composer 2 support

Composer 2 has been released. Could change to: "composer/composer": "^1.10 || ^2.0",

Can you submit a PR?


[Test automation] allow users to customize tab icon

Description
Please explain the changes you made here.
Which issue(s) does this PR fix

[Fixes RHIDP-793
](https://issues.redhat.com/browse/RHIDP-793)

PR acceptance criteria
Please make sure that the following steps are complete:

[ ] GitHub Actions are completed and successful
[ ] Unit Tests are updated and passing
[ ] E2E Tests are updated and passing
[ ] Documentation is updated if necessary (requirement for new features)
[ ] Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

/lgtm


Notes should be indented

Signed-off-by: Sven Dowideit<EMAIL_ADDRESS>

@fredlf @jamtur01 @spf13 @moxiegirl

LGTM


[UI] Add Cilium Service Mesh

Current Behavior
The Meshery Adapter for Cilium Service Mesh is supported as a generic adapter currently without support for logo and default port reservation.
Desired Behavior

[x] 1. The Adapter should be visible in the navigation menu, dashboard, settings.
[x] 2. The Adapter's components should show inside of the Designer.
[ ] 3. The Adapter's operations should show inside of Lifecycle menu.

Contributor Guides and Resources

🎨 Wireframes and designs for Meshery UI in Figma
🖥 Contributing to Meshery UI
🙋🏾🙋🏼 Questions: Layer5 Discussion Forum and Layer5 Community Slack

The first portion of this issue is completed.
@MUzairS15, the second portion remains.

@leecalcote reolved by https://github.com/meshery/meshery-cilium/pull/34


Gradients for Acquisition are wrong when normalizer=True

Hi,
It appears that the gradients of the acquisition functions are wrong when normalizer=True is used in the model definition.  This is because model.predictive_gradients in GPy (which is called by model.get_prediction_gradients in Emukit) does not account for normalization.  I raised this issue here and made a pull request to fix it.
I don't think Emukit enforces or recommends to use normalizer=False anywhere.  This is problematic because it is up to the user to define their own model "upstream" of the optimization loop.  I suspect that many people are tempted to use normalizer=True without knowing that the gradients of their acquisition function will be wrong.
If the pull request I made is accepted, then there is nothing to do except to tell people that they should use the latest (devel?) version of GPy.
If I am missing anything, please let me know.
Thanks,
Antoine

import numpy as np
import GPy
from GPy.models import GradientChecker
from emukit.model_wrappers.gpy_model_wrappers import GPyModelWrapper
from emukit.bayesian_optimization.acquisitions import ProbabilityOfImprovement

M, Q = 15, 3
X = np.random.rand(M,Q)
Y = np.random.rand(M,1)
x = np.random.rand(1, Q)
model = GPy.models.GPRegression(X=X, Y=Y, normalizer=True)
emukit_model = GPyModelWrapper(model)
acq = ProbabilityOfImprovement(emukit_model)
g = GradientChecker(lambda x: acq.evaluate_with_gradients(x)[0],
                    lambda x: acq.evaluate_with_gradients(x)[1],
                    x, 'x')
assert(g.checkgrad())

FYI: #806 was merged to GPy's devel.

Hi Antoine,
Thank you for advising us and for the fix !

Now realizing that since the original PR in GPy is merged, we can safely close this issue. Thanks @ablancha for opening it!


Update istioctl tls-check tool to reflect autoMTLS

Please provide a description for what this PR is for.
Update the tool to reflect the behavior after https://github.com/istio/istio/pull/17621
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.
[ ] Configuration Infrastructure
[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[X] Security
[ ] Test and Release
[X] User Experience
[X] Developer Infrastructure

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

lint_istio
d9e6005150bb3a39a6aa159b0ae7eec2a7764130
link
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-local-tests_istio
468065ffcc9634ca5f9bb648e757a7f34dfc46b9
link
/test integ-pilot-local-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-pilot-local-tests_istio

@diemtvu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

integ-pilot-local-tests_istio
468065ffcc9634ca5f9bb648e757a7f34dfc46b9
link
/test integ-pilot-local-tests_istio

integ-mixer-k8s-tests_istio
468065ffcc9634ca5f9bb648e757a7f34dfc46b9
link
/test integ-mixer-k8s-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test integ-mixer-k8s-tests_istio

istioctl changes, less risky, should be CP-ed as implementation to 1.4 for
consistency.
On Thu, Oct 17, 2019 at 9:48 AM Diem Vu<EMAIL_ADDRESS>wrote:

/test integ-mixer-k8s-tests_istio
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/17964?email_source=notifications&email_token=AAMVXB3HJAXMWLR4JBYSVL3QPCJL7A5CNFSM4JBTLDW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBQYW3Y#issuecomment-543263599,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAMVXBZZQF2TNAPI4EG3K73QPCJL7ANCNFSM4JBTLDWQ
.

Hold to verify with Greg's PR again

Correct the status when mTLS disabled. @incfly PTAL

@diemtvu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

e2e-mixer-no_auth_istio
0c1e49479ec05d64fc7ddc22adcace9ee43b6aa4
link
/test e2e-mixer-no_auth_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/retest infra flake

/test e2e-mixer-no_auth_istio

In response to a cherrypick label: new pull request created: #18005


Some kind of regex-bug ... not compiling js-block on using double-quotes in special circumstances

error.js
CompileError
I don't understand what's wrong with this, I just guess some regex is failing
To see and disbelief with a mouth wide open please copy and paste this into a *.md file and try to literate-programming-process it.
Then, to really freak out ... replace the double quotes with single-quotes ... et voila, it works ...?!??
    if (typeof fn !== "function" ||
        key === "constructor" ||
        key[0] === "_" ||
        key.match("::")) {

The problem is that _"  starts a block substitution. So you read it as "_" but the part looking for a substitution sees _"
One fix is to use the unicode for underscore, i.e.,  "\u005F"
The new version has backslash escaping.


Unable to issue tokens

Sign in
Sorry, but we’re having trouble signing you in.
AADSTS50020: We are unable to issue tokens from this API version for a Microsoft account. Please contact the application vendor as they need to use version 2.0 of the protocol to support this.
https://prnt.sc/l18lqa

Hi, what sort of APIs are you trying to call?

@hajekj  not understand your question

What are you trying to do?

I am trying to Login with Azure
I have created app here https://apps.dev.microsoft.com using App ID and Secret.
When app redirects for the code it gives this error. But I fixed this by changing API version.
Now I am getting issue after arriving on callback URL  https://prnt.sc/l19p70

Could you by any chance include the code?

I just changed 2 lines of code in thenetworg/oauth2-azure/src/Provider/Azure.php because of https://prnt.sc/l18lqa error
public $pathAuthorize = "/oauth2/authorize";
 public $pathToken = "/oauth2/token";

to
```
public $pathAuthorize = "/oauth2/v2.0/authorize";
public $pathToken = "/oauth2/v2.0/token";

Do you just need the user to authentication or call some API? I would suggest setting $urlAPI to an empty string if you need just authentication. Also, please note that you should not make changes in the library directly thenetworg/oauth2-azure/src/Provider/Azure.php and use configuration instead like shown in the documentation.

Ok.
Thanks for your quick support. I appreciate it


add k8s secret supports for msgsvc, panda and harvester

(1) add k8s secret supports for msgsvc, panda and harvester. I put the secret part in the last one of the envFrom. I tested it, it can overwrite the env variable it's already defined in another configmap.
(2) add readme.rst

I've fixed some obvious stuff. Besides, isn't it OK to always use secrets? You don't have to keep backward compatibility at this stage since that makes charts complicated and there is no production deployment right now. E.g., things like
secret:
enabled: false
and
if {{ .Values.secret.enabled }}
..
and
values-use-secret.yaml
can be removed.

Why do you have similar files, one in helm/blah/values/ and the other in secrets/blah/ ? e.g.
https://github.com/PanDAWMS/panda-k8s/blob/a12efbf21771cb1b9b2007f7eb626ff2c77ea8ae/helm/msgsvc/values/values-secret.yaml.template
https://github.com/PanDAWMS/panda-k8s/blob/a12efbf21771cb1b9b2007f7eb626ff2c77ea8ae/secrets/msgsvc/values.yaml

Why do you have similar files, one in helm/blah/values/ and the other in secrets/blah/ ? e.g.
https://github.com/PanDAWMS/panda-k8s/blob/a12efbf21771cb1b9b2007f7eb626ff2c77ea8ae/helm/msgsvc/values/values-secret.yaml.template
https://github.com/PanDAWMS/panda-k8s/blob/a12efbf21771cb1b9b2007f7eb626ff2c77ea8ae/secrets/msgsvc/values.yaml

The values-secret.yaml is just used for cases that k8s secret is not used. If we decide to use k8s secret for default, I can remove the values-secret.yaml.template.


Airpal WebUI not showing results/data preview

Hello, I am using Presto 0.187 (AWS EMR) with Airpal Web UI
When I run a query, the results/Data Preview tab do not show anything.  The query status shows are "Planning", but presto server shows as "Finished"
I can see the results when using presto-cli.
Is Airpal compatible with Presto 0.187?
Please Help.

0.187 yes

did you resolved ?
I met the same problem ,used presto 0.180  ,I think it's the latest airpal not support the presto version , can any one help ?? thanks a lot
ps ： I had the key word "limit " ,but also no data preview ,and I can download cvs file


Suggestions/Rebalances

The fact that you're making this project is flattering to me :) anyways, I'm here to suggest some features to help guide the player to finding these out for themselves:
If you are holding a flower, a cow or mooshroom will look at you, maybe even making a noise or tilting their head...
This is so the player could find out they can feed the cows flowers if they happen to be holding one while walking by a cow.
Mooshrooms can eat mushrooms off the ground...
This is so the player will know they can feed the mooshrooms mushrooms.
Cows and Mooshrooms can be fed multiple flowers/mushrooms at a time...
Just so you don't have to repeatedly milk then feed over and over. The mushrooms and flowers will be stored in the cow.
Milk Buckets will reduce the duration of all effects by half...
This makes it so milk buckets are still viable, but you'd need more room in your inventory, further encouraging the use of the immunity mechanic.
I love to brainstorm new ideas to make Minecraft a much better designed game. Talk to me if you want, I really love coming up with changes for this lovely mess of a game.

I love turning people's ideas into reality! Plus this is something I want to see made haha
Having said that, I do have quite a busy life, so I can't promise it'll be finished or even get halfway through development :(
If you want to talk easier, you can join the Discord server and we'll have a channel where we can discuss the mod 👀
https://discord.gg/4m6kQSX6bx


Performance: Disable MPO loading

This one is less obvious than #362.
In Pillow JpegImagePlugin, if some headers match, then it opens the image again using MpoImagePlugin. In my current collection, all images are detected as such, but they are not. It leads to a double JPEG marker parsing, for nothing.
This patch disables this behavior. It can be difficult to merge for two reasons:

It is monkey patching
Some people might actually need to read MPO for some reason that I don't know about

In my collections of 536 images and 46 videos, I experienced a gain of 42% in speed in idle build (without applying #326). This is a huge win in this use case.

In my current collection, all images are detected as such, but they are not.

Is this because of your images, using a wrong format, or because of the PIllow way of detecting this format ? If the latter case, it would be better to fix on their side ;).

See https://github.com/python-pillow/Pillow/pull/3658 for more details. It doesn't fix the MPO identification, but it renders its impact less visible.

Merged in Pillow. See https://github.com/python-pillow/Pillow/pull/3658


Instructions for Jira integration return error "internal error" no further information

After following the instructions and using an API key for Jira integration the Authenticate with Jira window shows "internal error" there is no further information to help resolve the issue.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 99771c68-5f45-887a-e926-9ea772021f99
Version Independent ID: 865109fc-64b8-ba77-2e10-8002886c46c7
Content: App Center bug tracker documentation - Visual Studio App Center
Content Source: docs/dashboard/bugtracker/index.md
Service: vs-appcenter
Sub-service: app-center-general
GitHub Login: @amchew
Microsoft Alias: amchew

Thanks for filing this report & sorry that you haven't heard back from us. It sounds like this issue for technical support, but this repository isn't monitored by our support team.
If you need technical help, you can contact support by:

Going to https://appcenter.ms/apps
Selecting ? > Contact Support (in the upper right corner).
Reference this issue for context if needed.

If you've already resolved your issue/still want us to document this, give us an update of your current observations. We're catching up on our backlog here.


add "Validate an e-mail address and extract login" example

This example should use regex crate
cc https://github.com/brson/rust-cookbook/issues/217
See CONTRIBUTING.md for details.

Nicely done @Ophirr33 !


Update char.md

Explain Unicode() for empty strings returning -1 which is different from other RDBMS (returning 0 in this case.)

Thanks!


Tomighty menu bar icon is invisible on a mac that has dark theme enabled

Hi all. I love using Tomighty. Keep up the awesome work!

Believe it or not, I have Tomighty started when I took this screenshot. It's difficult to see this.
If I click where the hidden icon is and start a timer, it becomes visible.

Please make an icon that's visible for the dark theme menu bar. Thank you for your time.

I use the dark theme on macOS 10.13.4 and I do not see the same issue as you.

Apologies for taking forever to get back to this. I was using an old version of Tomighty (1.0.1). I installed a newer version 1.2.1 and I no longer have the issue.
I'm closing this issue. Apologies for the inconvenience. Thanks for making an awesome product. :)


Fix plot_pizza() plot issue reorder() not working like fct_reorder()

Find a replacement function within the available dependencies/base for the fct_reorder() function from {forcats}

Fix using dplyr
data_selected <- data_selected %>%
      arrange(desc(stat), desc(Percentile)) %>%
      mutate(Statistic = factor(Statistic, levels = Statistic))


FeatureDataAdapter and FeatureWritable do retain Axis orientation on EPSG:4326

A CRS lookup with SRID of 4326 returns lat/long.  When serializing a FeatureDataAdapter or a FeatureWritable, the Axis orientation is not preserved.  IN some cases, when deserialized, lat/long is assummed.  This the Axis orientation must be preserved.  This also respects that input data may in fact be lat/long.
If the input data is long/lat and is serialized into an intermediate file (sequence file, for example) and then read back, the FeatureWritable assumes lat/long.

We can default to CRS84 which should solve that (and keep thins in lon/lat)

I tried that and ran into another issue.  The CRS84 does not have a standard SRID.

No big deal as long as it's consistent, we just have to make sure it doesn't end up biting us internally.
urn:ogc:def:crs:OGC:1.3:CRS84

Should be the full definition
See
http://wiki.geojson.org/GeoJSON_draft_version_6
(section 4.3.1) for references, etc.


Base Forbidden. Need User after coming back to background app after app update

Base Forbidden. Need User after coming back to background app after app update

@TatankaConCube Please take a look into this

@jddeep  please add more details, what you do and how you get this error. Please attach the logs from the logcat console.

We had found a work around


Build libvips with its dependencies statically-linked (#39)

This PR adds supports for a single shared libvips library with its dependencies statically-linked as described in issue #39. It also ensures that the packaging script is compatible with macOS.
The MACOSX_DEPLOYMENT_TARGET is set to 10.9 (Mavericks). This version can also be upgraded to 10.13 (High Sierra, just like Node 14), since the previous Homebrew-based packaging script uses this as the minimum deployment target, see:
https://github.com/Homebrew/brew/blob/b9b51421f4c74f27cff38fb722b56dd6e6e74611/Library/Homebrew/extend/os/mac/extend/ENV/std.rb#L78-L79
https://github.com/lovell/package-libvips-darwin/blob/5816c78be31a9311b7a6bab5ac6bb10c846637ee/.travis.yml#L4
Resolves #39 after merging.

Marvellous, thank you Kleis, I'll make time later in the week to review this properly.

Thank you, this is a great improvement that should remove many shared library conflicts/headaches. Now let's see what happens when we ask Github Actions to build us a release!

Ah, I think I forgot to change something:
https://github.com/lovell/sharp-libvips/blob/master/.github/workflows/build-release.yml#L65
https://github.com/lovell/sharp-libvips/blob/master/.github/workflows/build-release.yml#L72
I'm sorry about that.

D'oh, I didn't spot that either. I've added you as a collaborator so you can more easily fix this kind of thing ;)

Commit https://github.com/lovell/sharp-libvips/commit/8f78c8177d5350dc230da2911e40d8018519a967 should fix this. Feel free to push another tag. 😅

A possible improvement would be to change that check into something more constant.
--- a/.github/workflows/build-release.yml
+++ b/.github/workflows/build-release.yml
@@ -62,14 +62,14 @@ jobs:
       run: |
         pip3 install meson ninja
         brew install advancecomp automake nasm pkg-config
-      if: matrix.os == 'macos-10.15'
+      if: matrix.platform == 'darwin-x64'
     - name: Setup toolchain (macOS)
       shell: bash
       run: |
         echo "::set-env name=CC::clang"
         echo "::set-env name=CXX::clang++"
         echo "::set-env name=MACOSX_DEPLOYMENT_TARGET::10.9"
-      if: matrix.os == 'macos-10.15'
+      if: matrix.platform == 'darwin-x64'
     - name: Build ${{ matrix.platform }}
       run: ./build.sh $(cat LIBVIPS_VERSION) ${{ matrix.platform }}
     - name: Upload Release Asset

(untested, maybe it doesn't work)

Thanks Kleis, the v8.9.2-alpha2 macOS build succeeded!
It looks like the linux-armv7 build crashed - I've not seen that before, perhaps there was a temporary underlying VM problem? I'll manually copy the libvips-8.9.2-linux-armv7 file from v8.9.2-alpha1 to v8.9.2-alpha2 for now so we can get on with testing these with sharp.

Hooray! The linux-armv7 build crash indeed looks strange, I think it's a temporary GitHub actions VM problem.
I just pushed commit https://github.com/lovell/sharp/pull/2223/commits/42f0d773857f91f7d0644b8ddaa945d7fdbeaa46 to test this release.
https://travis-ci.org/github/kleisauke/sharp/builds/702318230

hi @lovell, this is support from which release tag?

Prebuilt libvips binaries are now statically-linked and Brotli-compressed, requiring Node.js 10.16.0+.
https://sharp.pixelplumbing.com/changelog#v0260---25th-august-2020


Fix navbar page action buttons padding

Proposed Changes
Again, not sure if this is normal but I'm getting a weird bottom-padding for the buttons to the right side of the navbar, like this:

Ideally this would look like:

Interesting for sure as for me it doesn't seem to make a difference whether the code is there or not. Merging this fix hopfeully will prevent this issue from happening for others as well. Thanks a lot. c:


Revisit chef code to support 2.8.3

Changes needed for 2.8.3 to work out of the box.

client.keys has now to be in place and populated by server before its Start/restart
Added some debug statements for the agent discovery via chef search
Moved some start/restart actions downhill, in wrapper client/server
recipes as it makes more sense (at least to me)

With the attribute driven config change merged we now support 2.8.3. I'm going to close this out since it's no longer needed.