[Task] Expand market function development

Pre-check

[X] I am sure that all the content I provide is in English.

Search before asking

[X] I had searched in the issues and found no similar feature requirement.

Apache Dubbo Component
Website (apache/dubbo-website)
Descriptions
Improve an ecosystem and documentation for expanding the market on Dubbo's official website, and display the expansion library in the form of expanding the market on Dubbo's website, allowing users to submit expansion suggestions
Related issues
https://github.com/apache/dubbo/discussions/13835
Are you willing to submit a pull request to fix on your own?

[ ] Yes I am willing to submit a pull request on my own!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi @AlbumenJ Happy to contribute. Can you explain with some more details that's needed.

Hi @AlbumenJ Happy to contribute. Can you explain with some more details that's needed.

@songxiaosheng PTAL

Hi @AlbumenJ Happy to contribute. Can you explain with some more details that's needed.
we can develop  it  in  dubbo website project.
The demand description for the expansion of library market functions mainly includes the following content:

Extension library browsing: Users can browse various extension libraries and view detailed information such as name, description, version, review, etc.
Extended Library Search: Users can search for specific extended libraries through the keyword search function.
Extension Library Download: Users can download the required extension library files and install them into their projects.
Evaluation and comments on extension libraries: Users can evaluate and comment on the extension libraries they have used, helping other users choose the appropriate extension library. 6. User feedback and support: Users can provide feedback or suggestions to the platform, while also obtaining technical support.
Extension library management: Developers can upload new extension libraries, manage information about existing extension libraries, update versions, etc.

Hi @songxiaosheng | @AlbumenJ  thank you for the description. So after analysing the description the main goal is to create a Library market section  in the https://dubbo.apache.org/ website and implement the functionalities. So, we need to fork the dubbo-website repo? Is that correct.

Hi @songxiaosheng | @AlbumenJ thank you for the description. So after analysing the description the main goal is to create a Library market section in the https://dubbo.apache.org/ website and implement the functionalities. So, we need to fork the dubbo-website repo? Is that correct.

Yes

Does the entire issue require detailed communication?

Due to the use of rest protocol in dubbo-plugin/dubbo-rest-jaxrs and dubbo-rest-spring modules to test various functions of tri, some problems occurred during my migration. For SpringMvcRestProtocolTest classes and class JaxrsRestProtocolTest rewriting, can someone help me

Hi @AlbumenJ. Is this fixed?

Hi @AlbumenJ. Is this fixed?

no,you can try

hello,could you tell me more details how to solve it?

It can be displayed on the official website in tabular form for users to choose from the SPI extension libraries.

i can fix this issues can you assingn me.


Adds support for running BigQuery tests periodically

Describe your changes and why you are making these changes
This PR fetches the BigQuery shared credentials to a location from which it can be used for data integration tests.
Related issue number (if any)
ENG 2696
Loom demo (if any)
Checklist before requesting a review

[ ] I have created a descriptive PR title. The PR title should complete the sentence "This PR...".
[ ] I have performed a self-review of my code.
[ ] I have included a small demo of the changes. For the UI, this would be a screenshot or a Loom video.
[ ] If this is a new feature, I have added unit tests and integration tests.
[ ] I have run the integration tests locally and they are passing.
[ ] I have run the linter script locally (See python3 scripts/run_linters.py -h for usage).
[ ] All features on the UI continue to work correctly.
[ ] Added one of the following CI labels:

run_integration_test: Runs integration tests
skip_integration_test: Skips integration tests (Should be used when changes are ONLY documentation/UI)

@cw75 @kenxu95, since Saurav's out for a while, one of you should merge this when you are comfortable.


Trace Explorer view not part of left-side panel by default

I think it should be added. I see two possibilities about where to do this:

1- In the extension in this repo. This means that by adding this extension to a Theia application will automatically add the Trace explorer to the panel.
2- Do this as a customisation to the example application. Then it would only affect that application, but could serve as example for others that want to do same

@vince-fugnitto maybe something you could consider contributing, once we have an agreement on what to do.

@vince-fugnitto maybe something you could consider contributing, once we have an agreement on what to do.

Sure, that sounds good :)

I think option 1 should be considered. If someone installs this extension, she's probably interested to see traces eventually, so it makes sense to have the Trace explorer show automatically (or when a trace is opened? is that possible to open a view in the panel given some action?), especially that there is no other way to "discover" the tracing feature without this view.

I think option 1 should be considered. If someone installs this extension, she's probably interested to see traces eventually, so it makes sense to have the Trace explorer show automatically (or when a trace is opened? is that possible to open a view in the panel given some action?), especially that there is no other way to "discover" the tracing feature without this view.

Sounds good. I was just thinking that this way of doing things may not scale if all extensions were to do the same (think e.g. of crowded menus in classic Eclipse apps, when many plugins are installed). OTOH I think we can have a "higher level" solution at some point, to allow IDE developers to chose what's present/opened by default, no matter what an extension says. A bit like classic Eclipse perspectives.

I think option 1 should be considered. If someone installs this extension, she's probably interested to see traces eventually, so it makes sense to have the Trace explorer show automatically (or when a trace is opened? is that possible to open a view in the panel given some action?), especially that there is no other way to "discover" the tracing feature without this view.

Sounds good. I was just thinking that this way of doing things may not scale if all extensions were to do the same...

@marcdumais-work just as an FYI, we can support the same feature like in vscode which allows end-users to choose what they want to be displayed by default (check for default views):

just as an FYI, we can support the same feature like in vscode which allows end-users to choose what they want to be displayed by default (check for default views):

Cool. Something like that could be used by end-users to customise what's provided by the IDE app designer.


How to integrate custom atom features?

Hi, may I ask if I can add the atom positions in atom_feature_utils.py? If I include the coordinates, does this mean I should directly sum the features in the node feature vector from the GNN graph? I apologize for the confusion, but I am not sure where the GNN model is located or where the features get embedded. If you could help me locate where the GNN model or the feature embedding process is, I would humbly thank you

Sir, Thank you so much.

Hi, sorry to ask you another question. I tested the original code in _smiles_to_rdkit_mol, which uses MolFromSmiles(). At first, it worked perfectly fine. However, when I tried to get a molecule from an SDF file using MolFromMolFile(), I encountered the following error:
Error sending result: '<multiprocessing.pool.ExceptionWithTraceback object at >'. Reason: 'PicklingError("Can't pickle <class 'Boost.Python.ArgumentError'>: import of module 'Boost.Python' failed")'
This error persists even if I revert to the original code. I think it might be due to the structure I’m trying to pickle being too large for multiprocessing. Could you please give me some guidance or resources lead me to fix this issue? Thank you so much

Hi, sorry to ask you another. I tested the original code in _smiles_to_rdkit_mol, which uses MolFromSmiles(). At first, it worked perfectly fine. However, when I tried to get a molecule from an SDF file using MolFromMolFile(), I encountered the following error:
Error sending result: '<multiprocessing.pool.ExceptionWithTraceback object at >'. Reason: 'PicklingError("Can't pickle <class 'Boost.Python.ArgumentError'>: import of module 'Boost.Python' failed")'
Sorry but yet I still don't find the answer of this issue.
But I had check weather datapoint["mol"] = copy.deepcopy(MolFromMolFile(sdf_path))  is exist the data inside and it seem work.
I am not sure do I need to fix the code in sequential_worker_pool or not
This error persists even if I revert to the original code. I think it might be due to the structure I’m trying to pickle being too large for multiprocessing.  Could you please give me some guidance or resources to solve this issue? Thank you in advance.

Sorry to say that but what method you are use to embedded the coordinate into mol?
I have complicate error with
Converting graph sample for Cc1ccc(B(O)O)cc1Br failed - aborting!Converting graph sample for O=C(O)C(=O)Nc1sc2c(c1C(=O)O)CC[NH2+]C2 failed - aborting!

sorry to show my code which not very good structure format. Thank you to always help.

convert 2D or 3D SDF to mol rdkit and use smile to calculate the sa_score, clogp and others
extract the coordinate and emmbed to NodeFeature
below here is my code

def featurise_atoms(
    mol: Mol,
    atom_feature_extractors: List[AtomFeatureExtractor],
    motif_vocabulary: Optional[MotifVocabulary] = None,
    motifs: List[MotifAnnotation] = [],
) -> NodeFeatures:

    if motif_vocabulary is not None:
        atom_type_feature_extractor = next(
            featuriser
            for featuriser in atom_feature_extractors
            if isinstance(featuriser, AtomTypeFeatureExtractor)
        )

        enclosing_motif_id: Dict[int, int] = {}
        for motif in motifs:
            motif_id = motif_vocabulary.vocabulary[motif.motif_type]

            for atom in motif.atoms:
                enclosing_motif_id[atom.atom_id] = motif_id

        num_motifs = len(motif_vocabulary.vocabulary)

        all_atom_class_ids = []
        num_atom_classes = atom_type_feature_extractor.feature_width + num_motifs
    else:
        assert not motifs

        all_atom_class_ids = None
        num_atom_classes = None

    all_atom_features = []
    for atom_id, atom in enumerate(mol.GetAtoms()):
        atom_symbol = get_atom_symbol(atom)

        atom_features = [
            atom_featuriser.featurise(atom) for atom_featuriser in atom_feature_extractors
        ]

        if motif_vocabulary is not None:
            motif_or_atom_id = enclosing_motif_id.get(
                atom_id, atom_type_feature_extractor.type_name_to_index(atom_symbol) + num_motifs
            )
            assert motif_or_atom_id < num_atom_classes
            all_atom_class_ids.append(motif_or_atom_id)

        # Ensure the molecule has a conformer
        if mol.GetNumConformers() == 0:
            AllChem.EmbedMolecule(mol)  # Generate a conformer if none exists

        # Extract coordinate
        ligand_conformer = mol.GetConformer()
        atom_coordinates = np.array([
            [ligand_conformer.GetAtomPosition(atom_id)[0], ligand_conformer.GetAtomPosition(atom_id)[1],
             ligand_conformer.GetAtomPosition(atom_id)[2]]], dtype=np.float32)

        atom_distances = np.sqrt(np.sum(np.square(atom_coordinates.reshape(-1, 1, 3) - atom_coordinates.reshape(1, -1, 3)), axis=-1))
        interaction = np.where(atom_distances < 4.0, 1., 0.)

        mol_interactions = [interaction.reshape(-1)]

        atom_features = np.concatenate(atom_features).astype(np.float32)
        mol_interactions = np.concatenate(mol_interactions).astype(np.float32)

        all_atom_features.append(atom_features)
        all_atom_features.append(mol_interactions)

    return NodeFeatures(
        real_valued_features=all_atom_features,
        categorical_features=all_atom_class_ids,
        num_categorical_classes=num_atom_classes,
    )

The all_atom_features list is supposed to hold one feature vector per atom, yet in your changed code you append to it twice when iterating over the atoms. If you want to add extra atom features, you would need to add them to the atom_features list (before the np.concatenate(atom_features).astype(np.float32) is called), and keep the single append to all_atom_features.
Note that this function deals with features for atoms, not atom pairs or bonds. An example atom feature would be atom_coordinates computed in your code. The atom_distances and interaction matrices you construct are for pairs of atoms, which doesn't really fit as atom features. You could start by using atom_coordinates, and perhaps also some atom-level statistics of the interaction matrix (e.g. number of other atoms closer than a given distance), and see if then you can get the code to run.

Thank you. I’ve found the issue after checking with  SMILES Dataset for Analysis & Prediction. Initially, I was using the PDBbind dataset, and a lot of molecules produced error logs during conversion. (which I test with unmodified code)
Error:
Converting graph sample for [H]/N=C/c1nc(N2CCOCC2)nc(N(Cc2cnccn2)C2CCCC2)n1 failed - aborting!
Converting graph sample for O=c1[c][c]n([C]2O[C]([C][O-])[C]3O[V@TB15+9](=O)(=O)(=O)O[C]32)c(=O)[n-]1 failed - aborting!
Converting graph sample for [H]/N=C/c1ccc(C[C@@H](CCS(C)(=O)=O)NC(=O)[C@H](C)NC(=O)[C@H](CC(C)C)NC(=O)[C@H](Cc2ccccc2)N=[N+2]#N)cc1 failed - aborting!
Converting graph sample for [H]/N=C/[C@@H]1CCCN1C(=O)[C@@H]1C[C@H](n2cc(CNC(=O)OC(C)(C)C)nn2)CN1C(=O)CCCc1ccccc1 failed - aborting!
Converting graph sample for C=Cc1c(C)c2n3c1[CH]c1c(C)c(C=C)c4n1[Fe@SP3+5]31n3c(c(C)c(CCC(=O)[O-])c3[CH]c3c(CCC(=O)[O-])c(C)c(n31)[CH]4)[CH]2 failed - aborting!Converting graph sample for [H]/N=C1\NC(=O)/C(=C/c2ccc(-c3ccc(S(N)(=O)=O)cc3)o2)S1 failed - aborting!
Converting graph sample for [H]/N=C1\NC(=O)/C(=C/c2ccc(-c3ccc(S(N)(=O)=O)c(C(F)(F)F)c3)o2)S1 failed - aborting!

Attachment with dataset file:
PDBbind_dataset.zip

And I apologize for bothering you again this time. I now understand how to work with atom coordinates, but I’m uncertain about the location of the aggregation matrix. I am now make interaction matrix for multiplication with the adjacency matrix to make the edge feature. Is molecule_to_graph the appropriate target for this purpose sir?” The output of adjacency  list is look like a list I am not sure that is the matrix or not?
Thank you for all of your kind word. I am very happy that you always answer my question until now.

Sorry for asking do egde feature is the same as the adjenceny list. Where could I found the edge feature output in code, sir?

Hi may I ask you that what is _node_categorical_features_embedding [moler_vae.py] came from metadata which have the motif vocabulary?


[SIL] NFC: Removed visitBorrowIntroducingUserResults.

The function visitBorrowIntroducingUserResults is equivalent to getBorrowIntroducingUserResult except that it's less convenient to use and its name (and existence) implies that there could ever be more than one to visit. There's only ever one result, so there's no need for a visitor.  Updated all users to call getBorrowIntroducingUserResult instead.

@swift-ci please test

@swift-ci please test

@swift-ci please test source compatibility


Disable liquid processing

AsciiDoc files are being processed by Liquid before being passed to Asciidoctor. This could potentially introduce unexpected behavior. In the Asciidoctor community, we like to keep our AsciiDoc files clean. Disable the liquid processor unless the liquid attribute is set in the page data.

Here's the code needed to disable liquid processing:
def page.render_with_liquid?; false; end unless page.data.key? 'liquid'


WIP: removed dotted border style from focus in foundations and components

This can be closed now.
The last dotted border style was chucked away in https://github.com/coopdigital/coop-frontend/pull/158/files#diff-e97103e91ed4eb6ec59a93caa3deb0b3L120


Wrong behavior of AttributeBehavior::getValue()

Currently I have faced an issue with AttributeBehavior::getValue() when using BlameableBehavior.
Model configuration:
// regular configuration
 public function behaviors()
    {
        return [
            'blameable' => [
                'class' => BlameableBehavior::className()
            ],
// ...

Force value setting
// setting
$make->getBehavior('blameable')->value = $worker->createdBy;  // set the value for blameableBehavior

Running the script on CentOS release 6.4 (Final) and PHP 5.6.7 caused the following error:
call_user_func() expects parameter 1 to be a valid callback, no array or string given

Checking my custom logs, traced back to the AttributeBehavior::getValue() which provides the following check:
 if ($this->value instanceof Closure || is_array($this->value) && is_callable($this->value)) {

I fixed adding the following prior that check and solved the issue for me:
if(is_int($this->value) || is_string($this->value)) {
   return $this->value;
}

This is odd. Any string or integer value should not pass the original if statement.

Failed to reproduce. Could you add a failing test or provide more detailed way?

@klimov-paul @SilverFire

This is odd. Any string or integer value should not pass the original if statement.

I know, and it did not occurred on my local system (iMac) but on the staging server (CentOS release 6.4 (Final)).

Failed to reproduce. Could you add a failing test or provide more detailed way?

I do not know how can I be more explicit but by writing the tests my self to run on CentOS release 6.4 (Final).
It was a very awkward issue that happened to the  crawler I wrote for my current project. Will do the tests whenever possible.

I have some servers with CentOS 6.4. Please, write a test and I'll try it on those servers.
Also it will be good to know PHP version.

@tonydspaniard any updates?

I'm closing the issue unless further information provided.


Unable to replicate VGG's very deep results

Hi Sergei,
I've downloaded the 16-layer VGG network and wanted to replicate their results, but after running it on the ILSVRC-2014 validation set, I get very low accuracy which makes me think I am not using it correctly.
I understand that I need to rescale images to the [0, 255] range, permute the color channels from RGB to BGR, then subtract the mean pixel. Nevertheless, I still get very bad results.
Have you replicated their classification results, and if so, could you share what sort of preprocessing you used?
Thank you very much in advance,
Olivier

Hi Olivier, I never evaluated loadcaffe models on the full ILSVRC val set. Check how it's done here https://github.com/torch/tutorials/blob/master/7_imagenet_classification/classify.lua, also that your synset mapping from 1000 outputs to actual classes is the same.

Sure enough, the problem was in the indexing of the synsets. The caffe models were using the dictionary in the tutorial that you graciously provided, which is different from the dictionary used in the ILSVRC development kit.
In any case, thanks a lot for your help!
Olivier

Hi Sergey: I would like to suggest that you write a note on the README of this repository to make clear that the models, after loaded, must have their RGB convolution weights permuted. This comes from the models being downloaded from Caffe's zoo, which uses the BGR convention.
It would be helpful for Torch beginners like me who are not familiar with Caffe :) -- I just spent quite some time on figuring out this issue... I can send you a code snippet if you wish

For future users with the same question: the synset numbers and ground-truth for validation/train sets, as used for the models available in the caffe zoo, can be downloaded as done by the script found here: https://github.com/BVLC/caffe/blob/master/data/ilsvrc12/get_ilsvrc_aux.sh . The pre-trained models from the Caffe zoo will NOT predict according to the synset numbering found on the ImageNet website!

@andrefaraujo take a look at https://github.com/szagoruyko/imagenet-validation.torch, it has the code to reproduce caffe zoo numbers

@szagoruyko that looks great! -- I had completely missed it, thx for the pointer. If only this link were in the loadcaffe's README, or in the torch's cheatsheet...

@andrefaraujo fair enough, I added the link to readme, thanks


Corrects google group name to cncf-wg-storage

This PR adds the group link to the existing/accessible group "cncf-wg-storage".

Group has already been updated...


fix(tooltips): fix tooltips for lightbox

Fix a few issues with the event overlay which are noticeable on the lightbox tooltips
Description
When the isContained flag is true, both bottom and left positioned overlays were broken. The bottom positioning was broken when the element is on the far right of the page. The left positioned overlay would stretch to the far left of the page.
In addition, the props for the tooltips in the lightbox were being specified incorrectly. The Tooltip component does not take a direction property, instead taking a popoverProps object.
In the EventOverlay component, reliance on documentRight for positioning is broken in the presence of a scrollbar. I've removed this problem by no longer relying on documentRight for the bottom or left contained positioning.
Related Issue
#848
Motivation and Context
Fixes light box tooltips
How Has This Been Tested?
Checked visually on the lightbox and tooltip kitchen sink components along with every other component that uses lightbox. I've also added some more cases to the tooltip direction kitchen sink
Screenshots:
Before:

After:

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Documentation update
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Other... Please describe:

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

I think this looks good, but want to be sure we consider, are the changes in EventOverlay friendly for all usages, not just ToolTips? I know that that component is utilized in a lot of different ways, so there's a stronger concern for potentially breaking changes. Have you tested other components that might rely upon this mechanic of EventOverlay?

I've been through the other components that use the overlay. The main changes in this PR affect only the constrained (left and bottom) placement. I couldn't see any other component that was using the overlays in that way. I've also done plenty of playing around with the kitchen sink for overlay, popover and tooltip.


Fix incorrect public date when composer drafts are saved

When composer saves a draft, it uses the "system" (server) timezone to translate the "Public Date" field. If the system timezone differs from the app or user timezone, it results in the time being saved differently than it was entered. In order to correct this, pass the resulting converted timezone through the date helper's getSystemDateTime function. This is how these dates are handled when saving page properties from the frontend: https://github.com/concrete5/concrete5/blob/629e95fd4ccfd63f7bd2444e8e77faa8f0b432c4/web/concrete/startup/process.php#L1036

thanks @jordanlev


Error: EISDIR: illegal operation on a directory

Hello, I try to install purgecss-webpack-plugin on my stack but I get the following error :
/Volumes/APPLE SD Card/Projets/beapi/beapi-frontend-framework/themes/beapi-frontend-framework/node_modules/purgecss-webpack-plugin/node_modules/purgecss/lib/purgecss.js:674
                        throw _iteratorError5;
                        ^

Error: EISDIR: illegal operation on a directory, read
    at Object.fs.readSync (fs.js:690:18)
    at tryReadSync (fs.js:554:20)
    at Object.fs.readFileSync (fs.js:597:19)
    at Purgecss.extractFileSelector

You can reproduce the issue by cloning the repo : https://github.com/BeAPI/beapi-frontend-framework/tree/experiment/purgecss
$ npm install
$ npm run build:test

Version of purgecss-webpack-plugin : 1.2.0

Hey, did you manage to fix the issue? I can't see purgecss-webpack-plugin in your repo

Hello @jsnanigans ! Nope, I didn't find a way to fix this issue. What do you mean by "I can't see purgecss-webpack-plugin in your repo" ?  I installed the node package as devDependency : https://github.com/BeAPI/beapi-frontend-framework/blob/experiment/purgecss/package.json#L66

You likely need to pass {noDir: true} as an option to glob.sync() as glob.sync is matching a dir which the plugin can't operate on.
new PurgecssPlugin({
  paths: glob.sync(`${paths.appSrc}/**/*`)
}),
// becomes
new PurgecssPlugin({
  paths: glob.sync(`${paths.appSrc}/**/*`, { nodir: true })
}),

I ran into this issue as well. Passing nodir worked.


Override Tailwind platform target with the :tailwind config

This change gives developers the ability to override the platform target of tailwind CLI. Developers can add a :target key on the config to override manually
This is to address issue #39.
After doing some digging and just testing the tailwind command line, the M1 release target is broken. After testing the regular mac osx distribution, it works just fine on my M1 Silicon. Therefore the logical option is to let developer override the tailwind target in the config.

Same as #60. I think a custom path to download from is more appropriate. Or an option on install. But it should not be in the config file. :)

Closing as custom path is in :) Thanks!


Bicep or Terraform?
Bicep
Module Classification?
Resource Module
Module Name
avm/res/network/firewall-policy
Module Details
This module was migrated from CARML by @krbar without an owner.
Note: when someone volunteers to be the owner of this module, please reach out to @krbar to for changing the ownership of the existing GitHub teams as well.

Module proposal: https://github.com/Azure/Azure-Verified-Modules/issues/488
PR: https://github.com/Azure/bicep-registry-modules/pull/767

Do you want to be the new owner of this module?
No
Module Owner's GitHub Username (handle)
No response
(Optional) Secondary Module Owner's GitHub Username (handle)
No response

Hi @matebarabas - I'd like to own this module

Hi @PaulJohnston88,
Thanks for requesting/proposing to be an AVM module owner!
We just want to confirm you agree to the below pages that define what module ownership means:

Team Definitions & RACI
Shared Specification (Bicep & Terraform)
Module Support

Any questions or clarifications needed, let us know!
If you agree, please just reply to this issue with the exact sentence below (as this helps with our automation 👍):
"I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER"
Thanks,
The AVM Core Team
#RR

@matebarabas I CONFIRM I WISH TO OWN THIS AVM MODULE AND UNDERSTAND THE REQUIREMENTS AND DEFINITION OF A MODULE OWNER

Hi @PaulJohnston88,
Thanks for confirming that you wish to own this AVM module and understand the related requirements and responsibilities!
We just want to ask you to double check a few important things.
Please use the following values explicitly as provided in the module index page:

You must be the owner of the GitHub teams as outlined here.
Please check that your name has been updated in the module index page (this should happen shortly after you confirmed ownership).

You can now take ownership of this module and start improving it as needed! ✅ Happy coding! 🎉
Any further questions or clarifications needed, let us know!
Thanks,
The AVM Core Team

@krbar, can you please add @PaulJohnston88 to the related two GH teams, and make him a maintainer of both?

https://github.com/orgs/Azure/teams/avm-res-network-firewallpolicy-module-owners-bicep
https://github.com/orgs/Azure/teams/avm-res-network-firewallpolicy-module-contributors-bicep

Please let me know when this is done, so I can close this issue.
Thanks!

@matebarabas Done, @PaulJohnston88 is now a maintainer of both teams

Thanks for confirming! Closing this issue now.


ERRORs in home-assistant.log

Hi,
I’ve installed the APC UPS Daemon form here.
That’s my config:
{
"name": "UPS1",
"cable": "usb",
"type": "usb",
"device": "",
"extra": []
}
Now I get the following error in my log file. Are there any advices for that?
17-12-16 08:12:19 ERROR (MainThread) [homeassistant.setup] Error during setup of component apcupsd
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/homeassistant/setup.py", line 193, in _async_setup_component
component.setup, hass, processed_config)
File "/usr/lib/python3.6/asyncio/futures.py", line 331, in iter
yield self  # This tells Task to wait for completion.
File "/usr/lib/python3.6/asyncio/tasks.py", line 244, in _wakeup
future.result()
File "/usr/lib/python3.6/asyncio/futures.py", line 244, in result
raise self._exception
File "/usr/lib/python3.6/concurrent/futures/thread.py", line 55, in run
result = self.fn(*self.args, **self.kwargs)
File "/usr/lib/python3.6/site-packages/homeassistant/components/apcupsd.py", line 44, in setup
conf = config[DOMAIN]
KeyError: 'apcupsd'
2017-12-16 08:12:19 ERROR (MainThread) [homeassistant.setup] Unable to setup dependencies of sensor.apcupsd. Setup failed for dependencies: apcupsd
2017-12-16 08:12:19 ERROR (MainThread) [homeassistant.setup] Unable to prepare setup for platform sensor.apcupsd: Could not setup all dependencies.
Regards,
Andreas

What's your config look like? It should look something like:
apcupsd:
  host: a722577e-apcupsd

To find what your host should be, look on the Hass.io apcupsd page and look for the text like Made available via repository a722577e. I'm honestly not sure if you'll have the same ID as me.

Where can I find "text like Made available via repository ..."?
Please see the attached Screenshot.

@andreasfromch
I looked at the hassio code and the ID is generated from the repository name, so it should be the same for everyone.
But to answer your question, go to the Hassio panel, click the store icon in the top right then click the add-on in the list:

@korylprince
Thanks for the great support!
The problem was the missing
apcupsd:
  host: a722577e-apcupsd

in configuration.yaml and more than one restart.
Now everything is fine and the component works very well!

@andreasfromch I'm glad someone is using it! I've added more information about the home assistant configuration on the README about this issue. Thanks for submitting this.


Shortcut not accurate

The dev console help page has:
Open file    Ctrl + P, Ctrl + O
...but Ctrl + P actually changes the console's docking behavior.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

In my copie of this app the shortcut works. Using directly in Edge too.

Maybe I'm not explaining this right.  In the F12 help page :
https://docs.microsoft.com/en-us/microsoft-edge/devtools-guide?source=f12help
the chord for "open file" is described as "Ctrl + P, Ctrl + O" but it is just Ctrl + O that does the action. Ctrl + P is not a part of it.  The help page should be updated.

@jgraff-esi
Can you please clarify whether you are using Microsoft Edge (EdgeHTML) or Microsoft Edge (Chromium) browser?

Help guide for EdgeHTML is the inaccurate one.  Can confirm either Ctrl + P or Ctrl + O works to open file in Chromium Edge as documented on that devtools help page.

Your feedback resulted in changes to the documentation.
#645

@jgraff-esi
Per discussion with subject matter expert, the shortcuts represent the most recent version of Windows.
Your requested changes to the content have not resulted in changes to the public content.
Thank you for your feedback.


.buildPath allows invalid arguments

I have an application with heavy use of searchParams and I'm looking for a way to make it harder for developers to invoke buildPath incorrectly.
In the example below, you can see that it's very easy to call buildPath with the searchParameters as the first argument.
I think this is because the first argument to buildPath in this situation is  Record<never, never> instead of Record<string, never>.
Any tips on either:
(1) where to fix this in the library
(2) how to build the ROUTES differently to get type safety without any upstream fix
(3) a pointer on if I'm doing something completely wrong.
Thanks!
import { route, string } from 'react-router-typesafe-routes/dom';

const ROUTES = {
  WIDGETS: route('widgets', { searchParams: { order: string() } }),
};

// This is what I want to invoke:
ROUTES.WIDGETS.buildPath({}, { order: 'asc' }); // '/widgets?order=asc'

// This silently fails -- it passes the typescript tests
ROUTES.WIDGETS.buildPath({ order: 'asc' }); // '/widgets'

Hi!
This is indeed an issue that I don't know how to fix. As far as I remember, I couldn't make it so that the params argument rejects params when there are no params in pathname (without breaking something else).
The next major version will make it slightly better, because buildPath will accept a single argument (like { params: {...}, searchParams: {...} }), but even then you will be able to accidentally pass search params as params and get the same behavior. Also, I can't give an ETA on this version because I'm stuck on a TS performance issue I don't have the knowledge to fix 😓.
There may be a way to fix this in the userland by wrapping route and adding a version of buildPath that behaves as described above and also replaces {} with never, but I don't have time to test it right now.

I found this implementation for Equals, I cannot take credit for it [0]
type Exact<A, B> = (<T>() => T extends A ? 1 : 0) extends <T>() => T extends B
  ? 1
  : 0
  ? A extends B
    ? B extends A
      ? unknown
      : never
    : never
  : never;

And I put together this alternative for a function buildPath
export const buildPath = <
  TPath extends string,
  TPathTypes,
  TSearchTypes,
  THash extends string[],
  TStateTypes,
>(
  r: Route<TPath, TPathTypes, TSearchTypes, THash, TStateTypes>,
  pathParams: Exact<TPathTypes, Record<never, never>> extends never
    ? InParams<TPath, TPathTypes>
    : Record<string, never>,
  searchParams?: InSearchParams<TSearchTypes>
): string =>
  r.buildPath(pathParams as InParams<TPath, TPathTypes>, searchParams);

And this mini test suite passes in my codebase:
import { route, string } from 'react-router-typesafe-routes/dom';
import { buildPath } from 'src/lib/routes';

const TEST_ROUTES = {
  EXAMPLE: route(
    'example',
    { searchParams: { q: string() } },
    { DETAILS: route(':id') }
  ),
};

describe('buildPath', () => {
  it('exercises types', () => {
    expect(buildPath(TEST_ROUTES.EXAMPLE, {})).toEqual('/example');
    expect(buildPath(TEST_ROUTES.EXAMPLE, {}, { q: 'my query' })).toEqual(
      '/example?q=my+query'
    );

    expect(buildPath(TEST_ROUTES.EXAMPLE.DETAILS, { id: '123' })).toEqual(
      '/example/123'
    );

    // @ts-expect-error - missing an id here.
    expect(() => buildPath(TEST_ROUTES.EXAMPLE.DETAILS, {}, {})).toThrowError();

    // @ts-expect-error - no id applies to this route.
    expect(buildPath(TEST_ROUTES.EXAMPLE, { id: '123' }, {}));
  });
});

Would you take a patch to this library along these lines? Essentially trying to special case the {} type in the pathParameters argument. Do you see a reason why this wouldn't work? I'm obviously not very familiar with the way your (very clever and helpful so far!) library works.

https://stackoverflow.com/questions/53807517/how-to-test-if-two-types-are-exactly-the-same

I gave it another shot today and it turned out to be a fairly easy fix. Looks like you nudged me in the right direction, thanks!
The only thing that bothers me a bit is that it's now impossible to define an object with some params and pass it to a route without them (as opposed to passing it to a route with fewer params). Though it's probably a very rare use case.
The fix has been published. Please reopen the issue if I missed something.

Reopening because this was reverted in v2, it's probably better to add a suppressable warning instead.


Visual Defects when activating a few features together

From forum user @BritishMuseum:
Defective ToolKit Feature Name:

Collapsable Sidebar
Privacy mode
Reports

Expected Behavior

Collapsing the sidebar should not result in visual defects.
Navigating to reports should not result in visual defects.

Actual Behavior

Visual defects are visible on both.

Not sure if this is the right place to mention, but in using both the collapse panel view, and security with toggle mode, I get this weird overlap when the panel is collapsed:

Where the budget envelope and the padlock overlap.
Only really minor, but would be awesome if they could work nicely together.
(Priorities I know).
Edit to add:
That overlap means I can't click the budget button whilst the bar is collapsed.
Also noticed, in the same collapsed view, trying to switch to either native or toolkit reports results in white space to the right of the collapse bar.

I have a nice upgrade incoming that will keep the inspector a consistent width, no matter if a user is viewing the app with a full menu or a collapsed menu, and fix the various visual issues. In the final testing stages at the moment.

I'm going to close this issue due to recent merged changes. If additional adjustments are needed, it's probably best discussed in a new report.


Upgrade AutoFixture to .NET 4.5

This PR is an enabler for #678.

The v4 branch is already on .NET 4.5, for the reason that I consider it a breaking change to upgrade.
If people are still using AutoFixture on .NET 4.0, then upgrading to 4.5 will prevent users from moving forward. Therefore, it's a breaking change.
Sorry that maintaining an open source project is so difficult sometimes, but such is the environment.


Add RadioCard Component

For what version of Nuxt UI are you suggesting this?
v3.0.0-alpha.x
Description
It would be valuable to include a RadioCard component in @nuxt/ui, similar to the one provided by [Chakra UI](https://www.chakra-ui.com/docs/components/radio-card). This component allows users to create styled cards that act as radio options, improving the user experience for selection interfaces.
Given the modular design of @nuxt/ui and existing tools, I believe this functionality could be implemented effectively by leveraging the RadioGroup component from [Reka-UI](https://reka-ui.com/docs/components/radio-group).
Additional context
No response

Example

Hi, could be great to have both radio and checkbox. 😄


Fix deadlock in unit test

Stack:

#10
#9
#8 ⬅
#7
#6

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.


Changing track_type breaks value scale locking

Commit:
Steps to reproduce

Go to http://higlass.io/l/?d=Kq6dwaH9S9af8IWUJc5PDA
See that value scales are locked
Change track type for one of the tracks to horizontal-divergent-bar

Observed behavior

Value scales are no longer locked
Trying to lock the value scales again doesn't work because the yellow mouseover highlight doesn't disappear when clicking on a track

Expected behavior

Value scales remain locked

Thanks to @Phlya for reporting!

Whoops, duplicate of https://github.com/higlass/higlass/issues/847


Syntax for choosing type for loading module in *status

Should be something like /znc loadmod --type=global log

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/667-syntax-for-choosing-type-for-loading-module-in-status?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F1759&utm_medium=issues&utm_source=github).

And currently we have --type<global|user|nework> so this can be closed.


add a label counter

Add the ability to register an error label counter within a context, and use the context to
count labels in errors.

A few high-level comments (numbered for reference, not importance):

can this PR please be split into multiple smaller PRs that clearly separate changes? It seems like this one is both adding new ways to make/wrap errors and also adding the label counter
I'm a bit confused as to what the end-user (i.e. dev-facing) functionality the label counter adds. How is it expected to help devs when looking at logs or clues output? Having this info is neat, but it also adds another thing we need to maintain in the long run so I'd like to have a clear idea of how it's going to be used going forward. I feel having a good understanding of the expected use case is especially important because there's comments in the code that make it sound like it's possible to "misuse" this such that things aren't counted as expected (i.e. more complexity for users to remember and/or more footguns/surprising results)

@ashmrtn

split into multiple smaller PRs

done, please see https://github.com/alcionai/clues/pull/35

How is it expected to help devs when looking at logs or clues output?

The general idea is that for a comprehensive statistics collector (ie: counter in Corso), I want to maintain the QoL of stats maintenance in a way that feels natural to the action at hand, without hamfisting counter calls into every location.  This particular case is to help solve error contexts.  eg:
// without the label counter, what we don't want
if err := someImportantCall(); err != nil {
  counter.Inc(count.StatisticForThisKindOfError)
  return clues.Wrap(err, "message").With(stuff, things)
} else {
  return nil
}

// with the label counter, a more natural error handling process
err := someImportantCall()
return clues.WrapWith(ctx, err, "message").
  With(stuff, things).
  Label("this-kind-of-error").
  OrNil()

It should result in: 1/ fewer conditionals in order to include counting, and 2/ a natural focus on labeling errors without needing to think about whether a counter is embedded or not.  This, combined with the counter, should allow for easy contextualization of overall runtime events with minimal additional input from maintainers.

adds another thing we need to maintain in the long run

Ideally, this should add little-to-no maintenance.  At the highest level it allows a user to attach a counter at the start of a process and forget the rest.  No churn, no revisiting, just a one-and-done addition.

there's comments in the code that make it sound like it's possible to "misuse" this such that things aren't counted as expected (i.e. more complexity for users to remember and/or more footguns/surprising results)

Unfortunately, yes.  It does introduce a relationship between the context and the error such that order can matter under certain circumstances.  Specifically, that .WithClues(ctx) must get called before .Label.
The ordering could also be solved if we wanted to move to a builder digestion pattern (ie: always require an .OrNil() call to finish construction.  But I think that's overbearing.  I believe 99% of the ordering issues are solved by the new/wrap/stackWith constructors.  Theory being: if the user is calling WithClues, they're always attaching the ctx to their errors, and the WithClues method is a necessity.  This makes NewWith a way to solve both the ordering issue and the WithClues cruft.   And if they're not, and they only want an error without the ctx, they won't want a counter anyway.


Footer: Update Advisory's social media icons

Currently, the website only displays Facebook and RSS for Advisory's social media links in the footer:

These should be replaced with the relevant social media icons (check with Marketing to get the most recent links).
Please see the following related issues/PRs:

https://github.com/AdvisorySG/ghost-advisory-theme/issues/292
https://github.com/AdvisorySG/ghost-advisory-theme/pull/314

Hello Wei En, I wouldn't mind working on this issue!

see my pull req.

Fixed in https://github.com/AdvisorySG/dawn-advisory-theme/commit/c9db9808056a9a7f1dce2545285531cfaf4cee5f.


Host on GitHub Pages

Host your website on GitHub Pages

Sucсessfuly hosted website on GitHub Pages. Also, updated description of project with link on hosted website.


Make more types snapshotable

This PR adds:

PGraphics
PImage
RealVector
RealMatrix
Matcher
PShape (using reflection)

Types that can be created with core WarpScript that are still unhanded:

PFont because it does not contain enough information to recreate the font with PcreateFont like the URI.
StackContext because it could expose defined functions.

I removed PGraphics shapshot altogether. I will probably do another PR to introduce PFont and PGraphics snapshots be it will require quite a bit of discussion and new code so I'm not putting that in this PR.


Token type renaming

TODO: update js bindings

@mvines inline with what you were thinking too?

Nice.  How about going a little further where:

state::TokenMint becomes just Mint
state::Account now becomes Token.

@mvines Looks like you are referring to the generated C file, what do you think about the Rust naming?

Could rename State::Account(Account) to State::Account(Token) but that doesn't seem better

Maybe this?
pub enum State {
    /// Unallocated state, may be initialized into another state.
    Unallocated,
    /// A token type and associated mint.
    TokenType(Mint),
    /// Some amount of tokens
    Token(TokenInfo),
    /// Invalid state, cannot be modified by the token program.
    Invalid,
}

I also kinda like how the ERC20 standard has a token name and token symbol strings in it (https://eips.ethereum.org/EIPS/eip-20).  There's certainly room in the State::TokenType enum for those strings, since the Mint struct is much smaller than the TokenInfo.   Name/symbol a little toyish, but it does allow for a generic explorer interface to display all known tokens -- which I think people in the space tend to like.

@mvines @CriesofCarrots Post commit reviews welcome :-)


Add missing dependency (debian/ubuntu)

Why apt-get instead of apt?
It's nitpicking of course, but it looks nicer and achieves the same thing :P

Dont know, whoever first wrote this page put that (though I 100% agree with you lol)


Autoupdate disabler not working

ℹ Computer information

Spotify version:c<IP_ADDRESS>9.gc253025e
Windows version: 10 Pro
PowerShell version: 5.1.19041.1237

📝 Describe your problem in detail
Spotify auto update blocker didn't work. And yes, I did use the right button, I opened a post like this a while back.

Approximately 2 months have passed since your first request, during all this time the update blocking worked for you and only broke down now? or how did it happen?

Open this if you have any answers.


docs: reorg multi-agent howtos

MAJOR:

Consider improving the header titles. For a how-to guide, we're not trying to find a specific example, we're trying to find a specific implementation (e.g., I want to use tools with react).  Travel Recommendations Example (ReAct) -> Most users will not know what react is. They're looking for something that shows how tools can be used / added to agents.

We can create examples section at the very bottom if we want to add various examples.

What should users with custom agents do? How do custom agent implementations typically look?

Anyway to cut on complexity using 2 agents and still keep it meaningful?

MINOR:

Should we include a TOC at the top of the how-to guide? (maybe not necessary since it'll be included automatically)
Is there a way to have the agents use tools without the handoff having to be a tool? (I think not)
Some details seem like they belong in the conceptual guide? (Ok here fro now, but this is good material for the conceptual guide)

Could you document the function with google style doc-strings:

This is what people will use to understand what the function does.
def make_handoff_tool(*, agent_name: str):
    tool_name = f"transfer_to_{agent_name}"

missing transition between the two code cells:

Some paraphrasing if you like?

Implementing a handoff tool -> implementing a handoff using a tool

The output from for chunk in graph.stream(  {      "messages": [          (              "user",              "what's (3 + 5) * 12"          )      ]  },  subgraphs=True ):  print(chunk)  print("\n")
is not readable I think

parallel_tool_calls=False -- does this work with all model providers?  Can we add this to create react agent?

Using with a prebuilt ReAct agent. Do we need to note somewhere that the scratch pad is shared? -- that's an important thing about this implementation


[ESLint] Disable Function type

Summary
Type Function is too much generic and may provoke unexpected issue in some conditions.
Motivation
Aforementioned in summary type Function provoke an error that can't be fixed. On one hand, ESLint warns in ChildComponent to add a readonly on props. On the other hand, if we add readonly on props, we have Typescript error because we can't use readonly on nonatomic type. We tried to use Readonly<MyChildComponentProps> but bug still remain. After some searches, we can't use anymore Function type due to its high genericity. The example bellow :
import React from 'react';

interface MyParentComponentState{
    myState : number;
}

function MyParentComponent(){

    const [test, setTest] = React.useState<MyParentComponentState>({
        myState: 10,
    });

    const HandleChangeMyState = ():void =>{
        setTest(
            {
                ...test,
                myState: 100,
            }
        )
    }

    return(
        <MyChildComponent firstProps={test.myState} secondProps={HandleChangeMyState} />
    )
}

import React from 'react';

interface MyChildComponentProps{
    firstProps: number,
    secondProps: Function,
}

export default function MyChildComponent( readonly props: MyChildComponentProps ){

    const { firstProps, secondProps } = props;

    return(
        <div />
    )
}

Implementation
Rule could be found in Typescript plugin for eslint.

ban-types rule can be used to prevent Function usage.
Here is an example usage https://stackoverflow.com/a/63913504.

The Function type is far from being the only type that we should ban.  Can one of you two make a small non exostive list to avoid problem like this one in the future ?


Midi decoding error: Bad header in MIDI file

By following the tutorial, when converting midi files to note sequences, it encounters following error
ERROR:tensorflow:Midi decoding error <type 'exceptions.TypeError'>: Bad header in MIDI file
when running
bazel run //magenta/scripts:convert_midi_dir_to_note_sequences -- \
--midi_dir=$MIDI_DIRECTORY \
--output_file=$SEQUENCES_TFRECORD \
--recursive

No tfrecord file generated.
I've tried many different midi files from midiworld website, the same error remains. So I guess it might not be the problem with midi files.
Environment:
Bazel 0.30
TensorFlow 0.9 under virtual environment

Can you attach the MIDI file?
On Tue, Jul 19, 2016 at 4:22 PM, Xingdong Zuo<EMAIL_ADDRESS>wrote:

By following the tutorial, when converting midi files to note sequences,
it encounters following error
ERROR:tensorflow:Midi decoding error <type 'exceptions.TypeError'>: Bad
header in MIDI file
when running
bazel run //magenta/scripts:convert_midi_dir_to_note_sequences --
--midi_dir=$MIDI_DIRECTORY
--output_file=$SEQUENCES_TFRECORD
--recursive
No tfrecord file generated.
I've tried many different midi files from midiworld website, the same
error remains. So I guess it might not be the problem with midi files.
Environment:
Bazel 0.30
TensorFlow 0.9 under virtual environment
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/magenta/issues/104, or mute the thread
https://github.com/notifications/unsubscribe-auth/APQ6QogxwTMHrUhv47q36pa3y2c6P37Gks5qXVwdgaJpZM4JQR1t
.

1.mid.zip
It can be imported and played with onlinesequencer.net

I'm not able to reproduce this.
I copied that 1.mid into /tmp/tester and ran this:
bazel run //magenta/scripts:convert_midi_dir_to_note_sequences --
--midi_dir=/tmp/tester --output_file=/tmp/test.file2
INFO: Running command line:
bazel-bin/magenta/scripts/convert_midi_dir_to_note_sequences
'--midi_dir=/tmp/tester' '--output_file=/tmp/test.file2'
/usr/local/google/home/deck/.cache/bazel/_bazel_deck/57b4fd5929bc61a3e836ee5f75cccde4/magenta/bazel-out/local-opt/bin/magenta/scripts/convert_midi_dir_to_note_sequences.runfiles/pretty_midi/pretty_midi.py:87:
RuntimeWarning: Tempo, Key or Time signature change events found on
non-zero tracks.  This is not a valid type 0 or type 1 MIDI file. Tempo,
Key or Time Signature may be wrong.
RuntimeWarning)
I get a RuntimeWarning about the MIDI file, but that's not a problem. The
output file is stil created
ls -l /tmp/test.file2
-rw-r--r-- 1 deck eng 31414 Jul 19 18:01 /tmp/test.file2
What versions of pretty_midi and py_midi are you running?
import pretty_midi
pretty_midi.version
Out[9]: '0.2-pre'
What version of py_midi are you running:
import midi
midi.file
Out[8]:
'/usr/local/lib/python2.7/dist-packages/midi-0.2.3-py2.7.egg/midi/init.pyc'
On Tue, Jul 19, 2016 at 5:34 PM, Xingdong Zuo<EMAIL_ADDRESS>wrote:

1.mid.zip https://github.com/tensorflow/magenta/files/372681/1.mid.zip
It can be imported and played with onlinesequencer.net
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/tensorflow/magenta/issues/104#issuecomment-233806923,
or mute the thread
https://github.com/notifications/unsubscribe-auth/APQ6QlwTBmXHCsQheMoEIyEG4nPIGDGgks5qXW0qgaJpZM4JQR1t
.

@douglaseck
When I enter IPython terminal under virtual environment of TensorFlow and run import pretty_midi and import midi
It returns No module named pretty_midi/midi
Does it mean that I should install these packages independently, since I am using Anaconda and when run conda install pretty_midi it does not find such a package to install.

I just tried the same commands as @douglaseck above and got the same results (a populated tfrecord file). Have you done a 'git pull' recently?
The pretty_midi and midi modules are downloaded by bazel at compilation time, and bazel takes care of setting up the python import paths to be able to reference them when you run bazel targets. So you should be using the same versions as we are.

I am having similar issues but did not see this thread until after starting my new thread at https://github.com/tensorflow/magenta/issues/107
I have a fresh installation and can't run any new mid files. The only file that runs is the example_complex.mid

I think I have my train path incorrect I will check that out.

I am having the same issue as @zuoxingdong.
My setup:

OS X 10.11
Python and bazel installed via homebrew
Tensor flow installed inside a virtualenv (named "all")
up to date magenta (commit d9bd761)

Here I activate the virtualenv and run the convert midi script using the midi file posted above:
$ source ~/all/bin/activate

(all)$ ./bazel-bin/magenta/scripts/convert_midi_dir_to_note_sequences \
--midi_dir=/tmp/tester \
--output_file=/tmp/tester/noteSequences.tfrecord

/Users/ruaridh/dev/music/magenta/bazel-bin/magenta/scripts/convert_midi_dir_to_note_sequences.runfiles/pretty_midi/pretty_midi.py:87: RuntimeWarning: Tempo, Key or Time signature change events found on non-zero tracks.  This is not a valid type 0 or type 1 MIDI file. Tempo, Key or Time Signature may be wrong.
RuntimeWarning)
ERROR:tensorflow:Midi decoding error <type 'exceptions.TypeError'>: Bad header in MIDI file.

(all)$

I'm having this error for every midi file I've tried.
The output file does seem to be generated, however it doesn't work in the next stage of creating the dataset. Apparently it can't be read (IOError: Could not open /tmp/tester/noteSequences.tfrecord.).
Also importing pretty_midi doesn't seem to work:
>>> import pretty_midi
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
ImportError: No module named pretty_midi

I just added some better logging to our midi conversion code in #112. Can the folks in this thread that were having import errors do a git pull and try again? I'd like to see what kind of error messages you're getting.

Still getting similar errors in the basic_rnn_create_dataset everything else seems to be fine. If I run Magenta from a few commits back everything is fine on my machine.

INFO: Running command line: bazel-bin/magenta/models/basic_rnn/basic_rnn_create_dataset '--input=/tmp/notesequences.tfrecord' '--train_output=/tmp/basic_rnn/sequence_examples/training_melodies.tfrecord' '--eval_output=/tmp/basic_rnn/sequence_examples/eval_melodies.tfrecord' '--eval_ratio=0'
Traceback (most recent call last):
File "/home/ben/.cache/bazel/_bazel_ben/8c0953a859c6a7cebfcbd426d9e6c4a2/magenta/bazel-out/local-opt/bin/magenta/models/basic_rnn/basic_rnn_create_dataset.runfiles/main/magenta/models/basic_rnn/basic_rnn_create_dataset.py", line 41, in
tf.app.run()
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/app.py", line 30, in run
sys.exit(main(sys.argv))
File "/home/ben/.cache/bazel/_bazel_ben/8c0953a859c6a7cebfcbd426d9e6c4a2/magenta/bazel-out/local-opt/bin/magenta/models/basic_rnn/basic_rnn_create_dataset.runfiles/main/magenta/models/basic_rnn/basic_rnn_create_dataset.py", line 37, in main
basic_rnn_encoder_decoder.MelodyEncoderDecoder())
File "/home/ben/.cache/bazel/_bazel_ben/8c0953a859c6a7cebfcbd426d9e6c4a2/magenta/bazel-out/local-opt/bin/magenta/models/basic_rnn/basic_rnn_create_dataset.runfiles/main/magenta/models/shared/melody_rnn_create_dataset.py", line 121, in run_from_flags
FLAGS.output_dir)
File "/home/ben/.cache/bazel/_bazel_ben/8c0953a859c6a7cebfcbd426d9e6c4a2/magenta/bazel-out/local-opt/bin/magenta/models/basic_rnn/basic_rnn_create_dataset.runfiles/main/magenta/pipelines/pipeline.py", line 196, in run_pipeline_serial
if not tf.gfile.Exists(output_dir):
File "/usr/local/lib/python2.7/dist-packages/tensorflow/python/platform/gfile.py", line 252, in Exists
return os.path.exists(path)
File "/home/ben/virtual-tf/lib/python2.7/genericpath.py", line 26, in exists
os.stat(path)
TypeError: coercing to Unicode: need string or buffer, NoneType found
ERROR: Non-zero return code '1' from command: Process exited with status 1.

Glad to hear things are working for you now, @hpssjellis. We'll try to do better with sending out announcements when we change data generation instructions.
@zuoxingdong are you still having problems?

@cghawthorne  Sorry for the late reply. I've re-clone the latest repo and try again, got the following message
INFO: Found 1 target...
Target //magenta/scripts:convert_midi_dir_to_note_sequences up-to-date:
  bazel-bin/magenta/scripts/convert_midi_dir_to_note_sequences
INFO: Elapsed time: 0.157s, Critical Path: 0.00s

INFO: Running command line: bazel-bin/magenta/scripts/convert_midi_dir_to_note_sequences '--midi_dir=midi_data/midis' '--output_file=midi_data/midis/notesequences.tfrecord' --recursive
INFO:tensorflow:Converting MIDI files in 'midi_data/midis/'.
WARNING:tensorflow:Could not parse MIDI file midi_data/midis/notesequences.tfrecord. It will be skipped. Error was: Midi decoding error <type 'exceptions.TypeError'>: Bad header in MIDI file.
INFO:tensorflow:Converted 0 MIDI files in 'midi_data/midis/'.
INFO:tensorflow:Could not parse 1 MIDI files.
INFO:tensorflow:Wrote 0 NoteSequence protos to 'midi_data/midis/notesequences.tfrecord'

Unfortunately no file is created. But I found if running commend bazel build first and then run ./bazel-bin/............ would be successfully generating TFRecord file.

@zuoxingdong it looks like the only file in that directory is notesequences.tfrecord. The convert_midi_dir_to_note_sequences is meant to take in a directory of midi files and produce a tfrecord file that contains notesequences representing the data in the midi files. If you try again with a directory that contains midi files, it should work. Let me know if you have any other problems!


RELATED: SPACE-2092 Update license

Build succeeded (check pipeline).

Sonar scan result

No issue found. Congratulations!

More detail, see in https://sonarqube-gate.intgdc.com/dashboard?id=gooddata-css-style-gate-PR44
To scan for vulnerabilities in dependencies and run unit tests (to get coverage report in sonar) please comment your PR with 'extended check sonar'.

Build succeeded (gate pipeline).

https://checklist.intgdc.com/job/compliance/job/gooddata-css-style-sonarqube-scan-zuul-gate/7/ : SUCCESS in 32s
https://checklist.intgdc.com/job/compliance/job/gooddata-css-style-fossa-scanning-zuul-el7/9/ : SUCCESS in 3m 16s (non-voting)
https://checklist.intgdc.com/job/compliance/job/gooddata-css-style-merge-compliance-check/15/ : SUCCESS in 18s


bug: cache-server misses the scope client

Describe the bug
The ApiExtensionsClusterClient in the cache server should use scope clients instead of NewClusterForConfig
Steps To Reproduce
I tried to wire in a context-based client as advised in https://github.com/kcp-dev/kcp/pull/1815#discussion_r954151311 by using SetMultiClusterRoundTripper along with SetCluster
So basically I did  apiextensionsclient.NewForConfig( kcpclienthelper.SetMultiClusterRoundTripper(kcpclienthelper.SetCluster(rest.CopyConfig(cfg), logicalcluster.Wildcard)).
Then when I tried to create a CRD with a ctx with a logical cluster name set it failed because the path was incorrect.
The path was set to /clusters/*/clusters/system:system-crds/apis/apiextensions.k8s.io/v1/customresourcedefinitions/apiresourceschemas.apis.kcp.dev
Expected Behaviour
Either something is broken or I don't know how to use a context-based client. I'd expect the path to be correctly set to the cluster from the context.
Additional Context
No response

/cc @varshaprasad96
I'm happy to prepare a PR if you could provide some input here. Thanks!

@p0lyn0mial The process which I usually follow to scope clients is:
Option 1:

Wrap an existing config with the cluster round tripper - (ie) using https://pkg.go.dev/github.com/kcp-dev/apimachinery/pkg/client#SetMultiClusterRoundTripper
Pass a scoped context while making client calls (logical cluster.WithContext(ctx, someCluster)

Option 2:

Set the cluster in the rest config directly (ie) with https://github.com/kcp-dev/apimachinery/blob/dbb759406933f20051f134e5d2cd740bcda53900/pkg/client/cluster_config.go#L43. If we do this, then we need not pass a scoped context, or even use cluster aware round tripper.

Based on the url, it looks like both options are being performed. If the rest config is directly being modified, we shouldn't be passing scoped context.

@varshaprasad96 yes, it looks like I applied both options at the same time.
Would you accept a PR that would allow for overwriting the cluster set by Option 2 when a cluster is also set in the context (Option 1)?
/cc @stevekuznetsov

Hm, I thought both at once should have worked. In any case, I think for now we are pausing this so let's re-consider it when we have more clarity about how we're moving forward.


Update sbt-scalafmt to 2.2.0

Updates org.scalameta:sbt-scalafmt from 2.0.7 to 2.2.0.
Release Notes/Changelog
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scalameta", artifactId = "sbt-scalafmt" } ]

labels: semver-minor

Codecov Report

Merging #1304 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1304   +/-   ##
=======================================
  Coverage   85.77%   85.77%
=======================================
  Files          74       74
  Lines        2537     2537
  Branches      108      108
=======================================
  Hits         2176     2176
  Misses        361      361

Impacted Files
Coverage Δ

...d/src/main/scala/io/circe/NonEmptySeqDecoder.scala
91.66% <0%> (-8.34%)
:arrow_down:

modules/rs/src/main/scala/io/circe/rs/JsonF.scala
94.11% <0%> (-5.89%)
:arrow_down:

...re/shared/src/main/scala/io/circe/JsonNumber.scala
91.56% <0%> (-1.21%)
:arrow_down:

.../core/shared/src/main/scala/io/circe/Decoder.scala
85.25% <0%> (+0.26%)
:arrow_up:

...rc/main/scala/io/circe/numbers/BiggerDecimal.scala
85.38% <0%> (+0.58%)
:arrow_up:

...les/core/shared/src/main/scala/io/circe/Json.scala
78.78% <0%> (+1.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af8fb57...8828ce4. Read the comment docs.

Superseded by #1306.


Question: Custom Command: converting multiple single lines to bullet points

Is it possible to have a custom command that converts for example:
hello
test
blabla
to

hello
test
blalbla

? Would appreciate some help as I don't really know how to set that up.

Hey @pinetreemoonlight . This would require that you have a functioning understanding of JavaScript. Is that the case?
If so, then it is just a matter of looking at how QuickAdd allows you to add custom JS logic as shown in the macros section of the documentation. I am not 100% sure of the requirements you have for the JS or how familiar you are with Obsidian's APIs so at this time that is about all I can tell you.
Hopefully this gives you enough information to at least move forward a little.

I am going to close this issue as I have not heard back. I am more than happy to help where possible if this is still something that you are having trouble with, though I will not be able to write it for you. About all I have time for is to help nudge you in the right direction if you get stuck.


Longest Streak/Current Streak Error

It says longest streak is 2 days, but as you see all 48 points were gotten and signed in one day. So the second day still hadn't started. I made 45 (or so) exercises during the morning (01:00-05:00), went to sleep and later(15:00+) continued (3 points).

Thank you for reporting, but this is already being discussed in #479 and #1075, please post your comments in one of them.

Closed due to collaborator pressure.

Not fixed.

Hahaha :heart_decoration:


Add Master StatefulSet podAntiAffinity so that master pods will not be running on one node.

Sometimes two masters will run on the same node. So that we can add podantiaffinity to avoid this situation.

Codecov Report

Merging #13345 (c431b05) into master (431cafa) will decrease coverage by 8.22%.
The diff coverage is n/a.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 431cafa...c431b05. Read the comment docs.

@jiacheliu3 Would you like to take a look at this PR?


Add GF2Add bloq for addition over GF($2^m$)

Part of a larger effort to support galois field arithmetic in qualtran. xref https://github.com/quantumlib/Qualtran/issues/1419

Thanks for the reviews, merging now.


Bruno Damacena | Sorting\Merge Sort\mergesort.py | Added merge sort a…

…lgorithm for python, usage is python mergesort.py path\to\versioned\input.txt

Great job! Merging into master. Thanks for your contribution!


Switch browser with the file being edited?

Salaam and Hi,
Does this extension switch the view in browser to the file being edited in the editor, if I Ctrl-Tabed to another file?
If it does that, then I will look into the PHP possibilities.

@Taariqq Can you please explain what you want to achieve?


how to dump EAC games

You could just rename r5apex to eaclauncher and then it would've let you dump with Scylla. Sick job tho with all the work you put into this, im sure you'll improve much with your drivers as you rethink what's possible from kernel ;)

Yeah, I literally understood that trick 5 mins after pushing this to Github haha.
Anyway, it might help someone learn :)

I sure hope it does, I too recently was a victim of the KMDF learning curve as well ;)

also do note you should look into clearing capcom traces when working with anti-cheats like EAC, just a suggestion since people here are having issues where capcom is the reason people using PI are getting banned.
Specifically MmUnloadedDrivers in the case of EAC. The registries are less of a concern. :)

I think this is more of a private stuff, what's the point of giving away a finished product in this case?

the code is already pasted everywhere. sharing knowledge like this is power
for anyone reading this that's interested, that's the correct way of doing so if you're not using a bug like empty driver name ;)

код уже наклеен везде. делиться такими знаниями-это власть
для тех, кто читает это, что интересно , это правильный способ сделать это, если вы не используете ошибку, такую как пустое имя драйвера ;)

You can try league dumper, with UAC disabled, or at the boot input .


NO-JIRA artemis.data system property

Within the artemis.xml the locations for storing the data can be configured (paging-directory, bindings-directory, journal-directory, large-messages-directory). Would it be possible to additionally support the system property artemis.data? The configuration would then be much easier.

Sure we can do that.
But artemis.instance was meant for that already.  What would be the use case?

this is just renaming karat.data property as artemis.data right?
I just realized that the context of your change is OSGI only?

Simply renaming karaf.data to artemis.data would also suffice for our purposes. In the meantime I tried the system property artemis.instance, but without success.

And yes we work with Apache Karaf OSGi environment.

ok.. fine with me...

I did and thank you!

JIRA?

Ok ignore my last comment i see commit is with Jira, maybe just update the PR name too ;) as this is what i picked up on quickly reviewing backlog of  PR's i havent put my eyes on.


[web] Adding capability to e2e to take screenshot for web tests.

Description
Adding capability to e2e to take screenshot for web tests. This infrastructure can also be used for triggering other WebDriver actions such as resize, back, forward. (https://www.w3.org/TR/webdriver/#endpoints)
Manually tested on Chrome, Firefox, Safari and Ios-Safari.
e2e_driver_extended.dart is only to be used as an example. We will use Flutter Gold to do the matching goldens for Flutter for Web integration tests.
Related Issues
https://github.com/flutter/flutter/issues/51890
https://github.com/flutter/flutter/issues/62706
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
[x] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
[x] All existing and new tests are passing.
[x] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the [Flutter Style Guide].
[x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
[x] I updated pubspec.yaml with an appropriate new version according to the [pub versioning philosophy].
[x] I updated CHANGELOG.md to add a description of the change.
[x] I signed the [CLA].
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

Please remove the .png files, and consider updating the .gitignore for that.

done. thanks for noticing :)

I'm investigating the current breakages of the CI, and they don't seem related to any changes in the flutter/plugins repo (but a change in the engine), so if you need to merge this on red, go ahead!

I'm investigating the current breakages of the CI, and they don't seem related to any changes in the flutter/plugins repo (but a change in the engine), so if you need to merge this on red, go ahead!

thanks a lot for investigating :)


bmi055: fixes for on-chip filter

While going through the BMI055 I noticed the on-chip filters are not configured as expected.
This changes:

Accel: use cutoff of 62.5 Hz instead of 500 Hz
Gyro: the cutoff frequency is coupled with the ODR and is fixed to 116 Hz
at 1 kHz readout rate. So this PR does not change anything for the gyro.

Relevant parts from the datasheet:

@bresch can you test this on one of the vehicles?

To be consistent with the other IMU drivers you should probably add the PX4 side low pass as well.

IMU_ACCEL_CUTOFF
IMU_GYRO_CUTOFF

I want to get this out of the actual drivers, but it's what we currently have.

@bresch if you happen to still have a flight log from flying the BMI055 as primary with no filtering it might be interesting to compare. https://github.com/PX4/Firmware/pull/11432

To be consistent with the other IMU drivers you should probably add the PX4 side low pass as well.

Right that is the other part that was missing. I added them as well.

@bkueng - with the removal of the setting of the register does this all become a NOP?

Nice catch. I assumed it was used elsewhere. I removed it completely.

Anyone able to give this a quick flight test on a pixhawk 4 with the icm20689 disabled?

@PX4/testflights could you try this on a pixhawk 4 or 4 mini? Start with any normal flight as a baseline. Then repeat, but this time manually disable the primary IMU (try mpu6000 stop). If that doesn't work it can be done via parameter (CAL_ACC0_EN,  CAL_GYRO0_EN).

tested on pixhawk4 v5  normal flight
https://review.px4.io/plot_app?log=3a3ec430-965b-4421-ba1d-8204dd654dc5
disable the primary IMU stops and go on mission mode
https://review.px4.io/plot_app?log=44cb4cd5-fcc9-4e24-84d0-51587ac701bc
tested on pixhawk4 mini v5  normal flight
https://review.px4.io/plot_app?log=12d30737-48d5-41ab-b15a-5ec107b98dcc
disable the primary IMU stops and go on mission mode
https://review.px4.io/plot_app?log=042f3964-4836-4dd8-8ec1-ad4ca20c00c1

The estimator really didn't like the data from the BMI055.

@dagar - what would you suggest?

This is still an improvement over the existing state in master, but the bmi055 will need a closer look if we want it to truly be a safe fallback.


feat: update Windows HPC version to 2024.1

This is the latest release.

I haven't done it just yet because latest Intel MPI has a bug (missing MPI_Status_c2f from the library) that breaks some ABI mpi4py tests. Nonetheless, IIRC, I already had to skip these tests in CI, so there is probably no point on bloking the update here.
PS: It is a bit annoying that Intel does not provide a latest URL to download from for Windows users.

Superseded by #11.
I cannot accept this PR. The purpose of actions/setup-mpi is to install just MPI, and not the full HPCkit package.


renovate: 38.27.0 -> 38.46.2

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for renovate is: Cross-platform Dependency Automation by Mend.io
meta.homepage for renovate is: https://github.com/renovatebot/renovate
meta.changelog for renovate is: https://github.com/renovatebot/renovate/releases/tag/38.46.2
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes
Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 38.46.2 with grep in /nix/store/i1xnypgdjxp7rcx5jvsa4jdc4q76rdk5-renovate-38.46.2
found 38.46.2 in filename of file in /nix/store/i1xnypgdjxp7rcx5jvsa4jdc4q76rdk5-renovate-38.46.2

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

renovate

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/i1xnypgdjxp7rcx5jvsa4jdc4q76rdk5-renovate-38.46.2 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A renovate https://github.com/r-ryantm/nixpkgs/archive/2ae9b15716ca82d87397ee9b4aa105877bd6d4bf.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/2ae9b15716ca82d87397ee9b4aa105877bd6d4bf#renovate

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/i1xnypgdjxp7rcx5jvsa4jdc4q76rdk5-renovate-38.46.2
ls -la /nix/store/i1xnypgdjxp7rcx5jvsa4jdc4q76rdk5-renovate-38.46.2/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

renovate

Maintainer pings
cc @nycodeghg @natsukium for testing.

[!TIP]
As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 336386 at 2ae9b157 run on aarch64-darwin 1

1 package built successfully:

renovate


BelongsToMany::sync() not removing related IDs from both collections

I have a simple many-many relation between DirectoryEntries and Categories.
First, I add some categories like this:
$add_category_ids = [
   "552472a5bffebc37158b4601",
   "552472a4bffebc37158b457c",
   "552472a5bffebc37158b4602",
   "552472a5bffebc37158b45d6"
];
DirectoryEntry::find('552837bfbffebc30158b4568')->categories()->sync($add_category_ids);

Next, I try to remove the last two categories:
$keep_category_ids = [
   "552472a5bffebc37158b4601",
   "552472a4bffebc37158b457c"
];
DirectoryEntry::find('552837bfbffebc30158b4568')->categories()->sync($keep_category_ids);

This successfully removes the directory_entry_id from the two removed Category documents.  Unfortunately, not so for the DirectoryEntry document:
DirectoryEntry::find('552837bfbffebc30158b4568')->category_ids;
=> [
       "552472a5bffebc37158b4601",
       "552472a4bffebc37158b457c",
       "552472a5bffebc37158b4602",
       "552472a5bffebc37158b45d6"
   ]

I've been banging my head against the wall trying to figure this out for two days.  I've tried to reproduce the issue in a unit test without success.  It passes every time.  If I use detach() directly, it works perfectly:
$del_category_ids = [
   "552472a5bffebc37158b4602",
   "552472a5bffebc37158b45d6"
];
DirectoryEntry::find('552837bfbffebc30158b4568')->categories()->detach($del_category_ids);
DirectoryEntry::find('552837bfbffebc30158b4568')->category_ids;
=> [
       "552472a5bffebc37158b4601",
       "552472a4bffebc37158b457c"
   ]

I have confirmed that sync() just calls detach() with the exact same arguments, so I am totally stumped here.  I can't figure out what is different between the two cases.  Any suggestions for pinning down this bug are appreciated.
Edit: This is the logged query string:
directory_entries.update({"$and":[{"deleted_at":null},{"_id":{"$id":"552837bfbffebc30158b4568"}}]},{"$pull":{"category_ids":{"2":"552472a5bffebc37158b4602","3":"552472a5bffebc37158b45d6"}}},{"multiple":true})

This only affects removing more than 1 category at a time.  If I perform a sync that removes only a single category, the following query works fine:
"directory_entries.update({"$and":[{"deleted_at":null},{"_id":{"$id":"552837bfbffebc30158b4568"}}]},{"$pullAll":{"category_ids":["552472a4bffebc37158b457c"]}},{"multiple":true})"

The difference is that this is is being generated as a $pullAll query.  BelongsToMany::sync() is passing a non-sequential array to detach(), which Builder::pull() thinks is an associative array.  If I re-index the array with $this->detach(array_values($detach)); on line 114, it generates a working $putAll query and everything works as expected.

Dupe of #439


Copy the CA certs to the host to avoid SKIP_VERIFY

Currently, shikari env with --tls only sets the _ADDR variables with the correct scheme and port but does not publish the *_CACERT variable as the CA certs were within the VM.
Use copyToHost feature to bring the CA certs back to the Host so that Shikari can start to support _CACERT option.
related to: #61

Thank you, @amitchahalgits, for picking this up. Please ensure that the changes are made to the following scenarios.

[ ] nomad-consul-secure
[ ] vault-consul-storage
[ ] vault-integrated-storage

This is done, and raised PR :https://github.com/Ranjandas/shikari-scenarios/pull/63 .
It includes all the scenarios


Tidy up documentation

Description

Fixes # (issue)
Checklist:

[ ] I have run ./ci/run_stable_checks.sh
[ ] I have reviewed my own code
[ ] I have added tests

Is there a way to disable the spell checker for code blocks?

I don't know, but that would be nice.

I'll leave the updating to you. I don't think we need @Mergifyio here :)

oh shush

:tada:


Display ID within provider on Vm detail page

Purpose or Intent
Each provider can identify its Vms with his own IDs. This ID was missing on Vm
details page.
See such ID is useful for user when compare MIQ Vms with Vms in other tools like
providers CLI and cannot rely on Vm name.
Steps for Testing/QA
Field ID within provider is displayed on Vm (Instance) detail page in Properties section.

Screenshot:

Field label ID within provider can be changed if someone finds better name for it.


Disable networking in tests?

I'd like to run pandas tests but not have it do any tests that require networking. I can get the tests to pass if I disconnect from the internet on my machine, but otherwise I'm getting SSL errors. This might be because am building pandas with nix, but presumably there are other reasons why one might want to disable any tests that require networking -- regardless of whether networking is actually available.
Poking around through the tests code, it looks like there's a check here which attempts to connect to google and skips the test if it's unable to do so. This, therefore, is nearly there. All that would be needed is to add an additional condition which would read a configuration option. For example an environment variable PANDAS_NO_NET_TESTS or something:
        if check_before_test and not raise_on_error:
            if 'PANDAS_NO_NET_TESTS' in os.environ or not can_connect(url, error_classes):
                raise SkipTest

The particulars are relatively unimportant but the point is, is such a thing undesirable for some reason? Or should I perhaps make a pull request?

just run
nosetests -A 'not network' pandas
you can also skip the slow and/or disabled tests.


Keyboard support for (⌘+Z, ⌘+Y, etc)

⌘+Z for undo, ⌘+shift+Z and ⌘+Y for redo, or even a custom combination.
Is this something you would pursue or would you rather leave it to the dev to implement?

It is application specific behaviour, and not desirable for all projects. So indeed I would leave this to individual devs.


Delete unused things in OrbitProcess OrbitModule OrbitFunction

This mainly deletes things that are not used anymore.
In OrbitFunction there are a few things moved around to be able to remove the enum OrbitType.

There are some parts that were recently added for manual instrumentation. The changes look correct to me, but I'm not sure if there might be something that will be needed for manual instrumentation (which is not done yet) that is getting deleted here. @pierricgimmig should take a look before this is merged.

There are some parts that were recently added for manual instrumentation. The changes look correct to me, but I'm not sure if there might be something that will be needed for manual instrumentation (which is not done yet) that is getting deleted here. @pierricgimmig should take a look before this is merged.

I agree. I actually specifically left parts in that are used and tested it. From what I can tell by my testing this is what is currently happening:
If Orbit.h is used in an application profiled by Orbit, the orbit_api:: functions (for example orbit_api::Start("string") are automatically hooked. That is all so far.
We should think about where to put a manual instrumentation functionality, because I don't think OrbitFunction is the right place for that.

I reverted the things you mentioned back to how they were before.

I reverted the things you mentioned back to how they were before.

cool, thanks!


Minicard component issues and features fixes

Minicard component has some css issues (errors and needs some features), adding text content as optional and also make the whole card as a link.
No semi-colon here:
https://github.com/adobe/aio-theme/blob/c293c01ac7340e498dacb6cb0716f8406638fb83/packages/gatsby-theme-aio/src/components/MiniResourceCard/index.js#L67
Results in the height not being set properly.
Text content should be option-able. This check will fail and throw an error if no text content is present:
https://github.com/adobe/aio-theme/blob/c293c01ac7340e498dacb6cb0716f8406638fb83/packages/gatsby-theme-aio/src/components/MiniResourceCard/index.js#L103C9-L103C9
The https://github.com/AdobeDocs/express-for-developers/ has a use-case of using the Minicard component without text body:
https://github.com/AdobeDocs/express-for-developers/blob/main/src/pages/index.md?plain=1#L80
The whole card should act as a link. May need another variant to support this as only the image is clickable.

Hi @timkim I've fixed the issue on the Minicard component. I checked with/without text now it's working fine.
This is the PR for that https://github.com/adobe/aio-theme/pull/1531


OCP guest directory changes

Updates to improve guest definitions:

add an OCPDFLT profile, removing the NICDEFs for general Linux guests
update the guest directory templates to use OCPDFLT
remove the MACHINE statement from the guest directory templates to allow the OCPDFLT one to effect
remove CPU statements?

"Huston, we have a problem..."
The need for attention here was exposed by an ESI installation into a z/VM-Mode LPAR.  Current definition of vCPUs is not friendly toward VCONFIG, basically.  Changing to a process based on DEFINE CPU in the directory entry rather than CPU statements would resolve this, but there is a snag: there is no interface to the COMMAND statement in the version of smapi in use -- furthermore, there is not even an API for COMMAND in SMAPI.  So there are choices:

prohibit the use of z/VM-Mode LPARs
Make the supporting directory change at guest creation time, and be unable to change the number of CPUs subsequently
write and install a Custom API for SMAPI, and extend smcli to use it

Note that just switching to Feilong for its more recent smcli equivalent is not a solution due to the missing COMMAND API.
For now I think changing the creation process will be sufficient.


Expose more emissions statistics in API

CodeCarbon version: 1.0
Python version: 3.8
Operating System:

Description
I would love to easily be able to get the kWh, not just the kG, in my code when calling EmissionsTracker. This is likely a backwards-incompatible change, but given that I'm not at all sure CodeCarbon has my building's power mix cost correct, I'm love to be able to log kWh, or to have access to any of CodeCarbon's statistics, when shutting down the tracker. I can get the data out of emissions.csv, but stop() just returns the kG of carbon, and the full energy consumption / emissions statistics aren't stored in a field or anything I can programmatically access.
Just an idea. But it would make things a little easier for how I'm looking at integrating CodeCarbon into my workflows.

Thanks for the feedback @mdekstrand and sorry it took us 6months to get back to you we missed your issue.
Would you be keen on contributing with us to codecarbon so that it fits your use-case?

Hello @mdekstrand , we have done it in https://github.com/mlco2/codecarbon/pull/210


Event/Code change Request on Codeunit 5510 Production Journal Mgt - Procedure SetTemplateAndBatchName

We need a new event function in Codeunit 5510 Production Journal Mgt - Procedure SetTemplateAndBatchName:
LOCAL [IntegrationEvent] OnBeforeSetTemplateAndBatchName(VAR ToTemplateName : Code [10];VAR ToBatchName: Code [10];VAR IsHandled : Boolean)
Called from:
procedure SetTemplateAndBatchName()
var
PageTemplate: Option Item,Transfer,"Phys. Inventory",Revaluation,Consumption,Output,Capacity,"Prod. Order";
User: Text;
begin
//INIT-INSERT
IsHandled := FALSE;
OnBeforeSetTemplateAndBatchName(ToTemplateName,ToBatchName, IsHandled);
IF IsHandled THEN
EXIT;
//END-INSERT
ItemJnlTemplate.Reset();
ItemJnlTemplate.SetRange("Page ID", PAGE::"Production Journal");

Thanks for reporting this. We agree, and we’ll publish a fix asap, either in an update for the current version or in the next major release. We will update this issue with information about availability.


[C#] Eliminate compiler warnings when building the project

Describe the bug, including details regarding any error messages, version, and platform.
A build should not produce compiler warnings.
Component(s)
C#

Has the WarningsAsErrors project flag been considered, to avoid compiler warnings creeping into PRs/builds?

Has the WarningsAsErrors project flag been considered, to avoid compiler warnings creeping into PRs/builds?

Fantastic idea!

Issue resolved by pull request 41645
https://github.com/apache/arrow/pull/41645


Disable "Build" button if configuration is already in progress

Clicking on "Build" while configuration is in progress results in an error message. Maybe it would make sense to just disable all actions that cannot be performed during this process and instead indicating what's going on with the option to cancel it?

Thank you for the idea, it would definitely be useful to implement something like that. We will monitor the community reactions to evaluate where this feature request would best fit in our backlog.

I was also thinking that rather than disable it, we could just queue it up to execute after the configure completes.  I run into this frequently when I open a folder and want to immediately build it.

I guess this one would be solved In favor of #2759?


Management Center

 Toggle navigation

   Bazuka01

My Score: 10000.00
   2020.12.28,09.00.00

   Change Password
   User Management
   Search User
   Player Score Log
   Player Game Log
   Player Bonus Log
   Player LuckyWheelLog
   Player Login Log
   Operation Log
   Suggestion
   Set Agent Login IP
   Sign Out

×

×

 Search User Back

Search User    Back

 Go

 Username
 Score
 Name
 Agent
 Tel
 Description
 Operation

 UID
 Username
 Online
 PlayerStatus
 Agent
 Balance
 Name
 Tel
 Description
 Operation

 Username
 Balance
 Name
 User agent
 Tel
 Description
 Operation

Processing...

Originally posted by @loy8888 in https://github.com/github/docs/issues/2369#issuecomment-751542868

I


hedgedhttp: bump cristalhq/hedgedhttp

What this PR does:
Updates cristalhq/hedgedhttp library to use new API. Old is still present but probably will be removed in the future.
Which issue(s) this PR fixes:
Fixes #
Checklist

[ ] Tests updated
[ ] CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

Hey,

Is it documented anywhere that hedgedhttp.NewRoundTripper

Currently not but as the cristalhq/hedgedhttp author I can confirm that deprecation will happen in the next release. Not because it's wrong or bad, just because hedgedhttp.New (and hedgedhttp.Client as a result) implements http.RoundTripper.

Also, can this be moved out of draft mode?

I haven't updated CHANGELOG file and haven't verified are there other things to do to get accepted. If it looks good for you - you/me can change the status.


Upgrade de.thetaphi:forbiddenapis 3.2 -> 3.3

This PR contains the following updates:

Package
Update
Change

de.thetaphi:forbiddenapis
minor
3.2 -> 3.3

Release Notes

policeman-tools/forbidden-apis
v3.3
Compare Source

[ ] If you want to rebase/retry this PR, click this checkbox.


tye deploy -i when pod is in crash backoff doesn't deploy new version

Deployed an app that wasn't reading config properly, saw that it was crashing on startup, change code and run deploy again.
Expected: new version of app running
Actual: Still running previous

yep. So far we've been relying on k8s behavior for this. We probably need to what helm and other tools do (delete pods, or scale down and back up).

I like content hashing better I think. But haven't spent lots of time thinking about it.


Fix errors in add_mappables and delete_mappables.

I made a couple of changes to Dataset class methods:

delete_mappables was checking mappables against ids instead of mappable ids against ids
both functions assigned output from create_image_table to class, but create_image_table assigns image_table in-place

Thanks! Would you mind adding a short test for delete_mappables()? That will prevent issues in future. The TestBase class already includes a dataset property that contains a small fake dataset; you can just drop one or two mappables by ID and make sure it updates properly. Once that's done, and the test passes, I'll merge ASAP.

Thanks!


[Android] emoji auto-completion list doesn't change on input

Summary
Emoji auto-completion list no longer changes on user input.
Environment Information

OS Version: Android 7
Mattermost App Version: 1.7.0 and 1.7.1
Mattermost Server Version: 4.8.0

Steps to reproduce

Prepare to write a message.
Type : - emoji auto-completion list appears (suggesting ':100::100:', ':1234::1234:', ...)
Type 'coffee'.

Expected behavior
Emoji auto-completion lists ':coffee: :coffee:'.
Observed behavior
Emoji auto-completion lists ':100::100:', ':1234::1234:', ...

Possible fixes
Downgrading to 1.6.0 helps. (But that's no long-term solution.)

See also: https://pre-release.mattermost.com/core/pl/j1hgu14673ywufsjzju5kadnfc

Hi @SmartHoneybee,
Thanks for your feedback,
I'm not able to reproduce your issue on v1.7.1, build 92, Mattermost server v4.9 (which released today - April 16th).
Could you let us know if this issue still reproduces for you once you have upgraded to the latest version of Mattermost server?

Hi @lindy65,
sorry for the delay.
Yes, still able to reproduce after the upgrade to Mattermost Team Edition 4.9.0.
Regards,
Bee

Thanks again, @lindy65.
No longer reproducible after upgrade to v1.8.0.

Good to hear @SmartHoneybee  :)


SQL Server 2005 database samples are no longer available on CodePlex

I guess this isn't really a docs.microsoft.com issue, so if you could tell me where I should report this so it doesn't get lost in the noise it would be great, or maybe if you good gents could just pass it along to the appropriate peeps. :)
Anyhow, if you go to https://www.microsoft.com/en-za/download/details.aspx?id=10679 to download the SQL 2005 sample databases, it redirects you to a project on the now-defunct CodePlex... Chrome is flagging CodePlex as a malicious site at this time, and the referenced project doesn't exist, so there's no apparent way to get hold of these samples.
I eventually managed to find out that the samples are now hosted at https://github.com/Microsoft/sql-server-samples/ - but the newest available samples there are only for SQL 2008, not 2005, so I have opened an issue there to get this addressed.

@IanKemp Please try https://docs.microsoft.com/en-us/previous-versions/sql/sql-server-2005/ms124501(v%3Dsql.90).


Attempting to setup Helm Dashboard behind a Reverse Proxy for SSL

Description
I have an Apache Reverse Proxy and have started up the application using the CLI however, when navigating to HTTP://localhost:8080 the site is not properly allowing Java Script. I have already checked the Apache config files however it is still not allowing javascript. I can get to the site but it is not properly displaying everything.
Screenshots

Additional information
No response

No Movement on this? Its the same when if you trying to setup an Ingress

Sorry, the issue is not very clear. I can't tell how exactly the app is started, from which directory etc.
 That usually a sign that something is off with relative URLs or proxy setup.
What I suggest to try is to build latest version from main sources and test with it.


Clear all completed task button

It works fine for me this way under OperationListViewItem
private void OnOperationComplete(OperationEventArgs e)
{
     this.OperationComplete?.Invoke(this, e);
     if (this.Operation.IsSuccessful)
          this.Remove();
}


Use blockcode instead of single code

In the instructions in README put commands in the block so that it looks nice and easy to copy.

Could you work on this @RakeshPotnuru ?

Sure

Go ahead!