bug: lsp hover shows "no information available" twice

Did you check docs and existing issues?

[X] I have read all the LazyVim docs
[X] I have searched the existing issues of LazyVim
[X] I have searched the existing issues of plugins related to this issue

Neovim version (nvim -v)
NVIM v0.10.0 Build type: Release LuaJIT 2.1.1713773202 Run "nvim -V1 -v" for more info
Operating system/version
MacOS 14.5
Describe the bug
calling vim.lsp.buf.hover() produces "no available information" popup twice while lsp hover is actually successfully happening
https://github.com/LazyVim/LazyVim/assets/1625373/be61f3bf-c0d9-4ae2-bf43-094e036dff72
Steps To Reproduce

Use lazyvim-starter
Switch off all plugins and extras
Go to any js or ts file and call vim.lsp.buf.hover() on any reference

Expected Behavior
doesn't show no information popup when there is lsp data on hover present, or if shown at least show once not twice
Repro
vim.lsp.buf.hover() doesn't event work with this repro

You must have multiple LSP servers attached to the buffer and not everyone has information about the symbol under the cursor. I noticed this when I had pyright and jedi and had disabled HoverProvider from pyright in favor of jedi. You can enable an option in noice.nvim to not show these messages. opts.lsp.hover.silent = true
For more info read noice's docs.

You must have multiple LSP servers attached to the buffer and not everyone has information about the symbol under the cursor. I noticed this when I had pyright and jedi and had disabled HoverProvider from pyright in favor of jedi. You can enable an option in noice.nvim to not show these messages. opts.lsp.hover.silent = true
For more info read noice's docs.

in the video I have disabled noice.nvim completely. For ts/js eslint/tailwind/css_modules + typescript-tools are present.
But the thing is when I remove all plugins and disable all lazyextras I have exact same problem. Which means it's not my configuration but a lazyvim preset behavior

I think it's because of nvim-notify. Try disabling it and see if you observe same behavior.

without nvim-notify it prints twice to messages stack

and if I disable all plugins and extras and disable nvim-notify I see nothing at all on hover
but switching off nvim-notify is not an optimal solution here because nvim-notify is needed. Any js/ts buffer has at any given moment at least 3 lsp clients working at the same time to complete missing parts of each  other, eslint  + tsserver + cssls, so I am surprised that this is a an actual problem

Are you able to reproduce this with default LazyVim installation?

This is default behavior for Neovim vim.lsp.buf.hover(). See here where it is defined. It calls request, which is the function just above, which returns vim.lsp.buf_request(). That in turn is defined here and you can see from the comments that

--- Sends an async request for all active clients attached to the
--- buffer.

Since it sends the request to all active clients in the buffer, the ones that don't have information for the symbol under the cursor send back Information not available. If there are more than one server which doesn't have information available you will see more than one notification.
So, not a LazyVim bug it seems.

Noice does the same as the default lsp handler

@dpetka2001 thanks for checking
This resolves the issue for me for good
https://github.com/neovim/neovim/issues/20457#issuecomment-1266782345
do you think this can be added to lazyvim as well?

This is what noice does (overwriting the LSP buffer handler) and you can use the option I mentioned earlier to silence those notifications. If you don't use noice, then you have to do something similar in your personal configuration on your own.

This is still happening on a new installation of LazyVim. What's the recommended way to disable these notifications?

Try configuring noice.nvim like following
return {
  {
    "folke/noice.nvim",
    opts = {
      lsp = {
        hover = { silent = true },
      },
    },
  }.
}


Identify embedded objects are not supported

CLISC can now identify embedded OLE and image objects. It provides alert to the user and does not try to change anything to the spreadsheet.


Fix issue where creating a survey element from xml would fail if there where multiple instance nodes

Changes Made

Handle cases where multiple instance nodes are present

Pending Work

[ ] Add test

Closes #434

Codecov Report

Merging #440 into master will increase coverage by 0.04%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master     #440      +/-   ##
==========================================
+ Coverage   82.83%   82.87%   +0.04%
==========================================
  Files          23       25       +2
  Lines        3402     3556     +154
  Branches      790      821      +31
==========================================
+ Hits         2818     2947     +129
- Misses        439      461      +22
- Partials      145      148       +3

Impacted Files
Coverage Δ

pyxform/xform2json.py
79.08% <33.33%> (-0.33%)
:arrow_down:

pyxform/__init__.py
100% <0%> (ø)

pyxform/utils.py
83.91% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2e6dd...77964ba. Read the comment docs.


Animals table

Vet Clinic Database
Hello 🙋♂🙋♂
🔰 In this branch I:
✅ Use this template to generate my repo.
✅ Create a database named vet_clinic.
✅ Create a table named animals with the following columns:

id: integer
name: string
date_of_birth: date
escape_attempts: integer
neutered: boolean
weight_kg: decimal

✅ Copy the SQL I used in the previous point into the schema.sql file in the generated repository.
✅ Insert the following data:

Animal: His name is Agumon. He was born on Feb 3rd, 2020, and currently weighs 10.23kg. He was neutered and he has never tried to escape.
Animal: Her name is Gabumon. She was born on Nov 15th, 2018, and currently weighs 8kg. She is neutered and she has tried to escape 2 times.
Animal: His name is Pikachu. He was born on Jan 7th, 2021, and currently weighs 15.04kg. He was not neutered and he has tried to escape once.
Animal: Her name is Devimon. She was born on May 12th, 2017, and currently weighs 11kg. She is neutered and she has tried to escape 5 times.
Copy the SQL you used in the previous point into the data.sql file in the generated repository.

✅ Write queries for the following quests:

Find all animals whose name ends in "mon".

List the name of all animals born between 2016 and 2019.

List the name of all animals that are neutered and have less than 3 escape attempts.

List the date of birth of all animals named either "Agumon" or "Pikachu".

List name and escape attempts of animals that weigh more than 10.5kg.

Find all animals that are neutered.

Find all animals not named Gabumon.

Find all animals with a weight between 10.4kg and 17.3kg (including the animals with the weights that equals precisely 10.4kg or 17.3kg).

✅ Take a screenshot of the results of my queries.
✅ Copy the SQL I used in the previous point into the queries.sql file in the generated repository.

@Munsa1 Thank you so much for your thorough review and for approving the pull request!


e2e SRV record tests

Not much testing around SRV records because DNS is difficult to run in ordinary tests. Would like to test/collect coverage for both TLS and non-TLS SRV discovery behavior using:

etcdctl client
etcdctl clientv3
etcd gateway
etcd peer bootstrapping

There's some dockerized DNS testing in e2e/docker, which is probably where to start for supporting this.

All basic tests are done via https://github.com/coreos/etcd/pull/8954.
We can integrate them in CI once we cut CI time to 10-min (https://github.com/coreos/etcd/issues/8862).


AMP Compatible.

The '!important' tag in the outline of the base/lib/base.css file it's not compatible with the new ampproject to make websites faster. It's necessary to have it?
/**
 * Suppress the focus outline on elements that cannot be accessed via keyboard.
 * This prevents an unwanted focus outline from appearing around elements that
 * might still respond to pointer events.
 */

[tabindex="-1"]:focus {
  outline: none !important;
}

Hi @fkraefft, I don't really know why !important is necessary. I think we just need to test that in browsers we support and see if it makes any difference.

@fkraefft Alright, here's what I've discovered so far. We have a test CSS that uses IDs, hence !important. So it's ether because of the tests or just to make sure we don't ever get an outline.
In theory we could remove the test CSS alongside with !important and we'll be fine. Although, in that case, you'll be testing against default browser's styles.
@simonsmith What do you think?

Judging from this commit it seems it was added to override styles that might be inside components.
I'm open to removing !important if we think this is not necessary.
cc @giuseppeg

@simonsmith Thanks for the feedback 👍 Now I'm actually thinking of removing the entire ruleset. I'll try to explain where I'm coming from: tabindex with a negative value doesn't really mean an element shouldn't have an outline, or any other styles for that matter. Basically, the element won't reachable via keyboard, but it still could be focused, programmatically for example, and it that case why shouldn't it have an outline? Of course it's up to a developer to think about potential accessibility concerns. A good use case can be found here https://govuk-elements.herokuapp.com/errors/example-form-validation-multiple-questions (try submitting the blank form).
I also checked Bootstrap and Pure CSS — none of them remove the outline.
What do you think?
cc @giuseppeg

yeah elements with tabindex="-1" can still be focused programmatically so I don't see why they shouldn't get an outline.

maybe @necolas has an explanation though

@simonsmith Any thoughts on https://github.com/suitcss/base/issues/48#issuecomment-424601769?

@racse1 I think removing the ruleset makes sense. There isn't really a strong case to keep it.

Fixed in #49


docs: fix 404 links for classes and rel links

This is to fix various 404 links for classes (modules) and relative doc links.
I didn't look through all the links to see if there are anymore, but these we the main two common issues.

View rendered docs/best-practices.md
View rendered docs/configuration.md
View rendered docs/deployment.md
View rendered docs/development.md
View rendered docs/github-api.md
View rendered docs/hello-world.md
View rendered docs/http.md

Looks good to me (I pushed a minor fixup, I hope that's okay for you @Cybermite).
@gr2m Does this look okay to you? If so, please merge it (I have merge permission, but don't want to merge anything without your approval)

@AaronDewes no need to wait for me for doc-only fixes like these. We trust you


Exports don't contain card info

Only works for the current year as card = member.current_card is used instead of the card from the join relation. This will also work for post 2014 as member objects could be shared accross multiple years before 2014.

Will pick card.year = member.last_registration and card.member_id = member.id here


Show all hotspots on Challengee maps, not just witnesses.

If a hotspot is surrounded by 20 close hotspots, and none are witnesses, it is clear to the user that placement needs fixing. This pressure to change positioning doesn't exist if the user can't see the other hotspots on the map to aim towards.
example:
https://explorer.helium.com/txns/IK1HAkCjGgIgJsYgfzbUQWWxoRlkXJyI47N7waYGQt8
there are 3 other hotspots hidden on this map, that this hotspot should be aiming to hit.
I'd probably extend this even further to say, that EVERY map we show always shows every hotspot.

We should unify the data that populates the coverage map as an optional layer for all of our mapbox instances. might also want use the new geospatial bounding box api


Using StructuredArguments without formatting the values in the message?

I wonder what the best practices are with using StructuredArguments inside logging calls when using logstash-logback-encoder to log in JSON format.
I want to log some structured arguments in separate fields, but I don't want to format these arguments into the literal string message.
If I write my log lines like this, everything works fine as I want to, but both my IntelliJ IDEA and Sonarqube static code analysis considers this problematic issues:
log.info("Query executed successfully!", StructuredArguments.value("hits", result.getHits()));
(or more concise)
log.info("Query executed successfully!", v("hits", result.getHits()));

IntelliJ warns this on this line:

more arguments provided (1) than placeholders specified (0)

How can I avoid this? Of course I can silence the warnings and add exceptions for them, but I wonder if that is a best practice.

https://stackoverflow.com/a/60306747/11248746


switch to dune build?

I tried building this project with nix, and found that while this project doesn't use dune, it's dependency gen_js_api does. I was able to build it by switching from buildDunePackage to stdenv.mkDerivation and using make and make install for the build and install steps, but it would be nice to have uniformity there, since most opam projects are using dune nowadays. I was going to try to do a pr to add dune but I saw that gen_js_api uses dune, and assumed that this project has a good reason not to use it.

No, it's just that we (LexiFi) don't use dune internally yet.  Feel free to contribute a dune file in a PR if you wish.

Wish granted!


UPGRADE FAILED: cannot patch "security-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded

Report
we have recently upgraded keda version to 2.12.1.
after successful upgrade , we have modified scaledObject parameters from Application chart
e.g minReplica value . threshould etc
So During helm upgrade to application we're getting below error
Error: UPGRADE FAILED: cannot patch "security-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded && cannot patch "security-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded && cannot patch "config-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded && cannot patch "security-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded
so Helm upgrade failed and we could see error in keda operator pod logs
2024-02-06T11:34:09Z	INFO	Initializing Scaling logic according to ScaledObject Specification	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"security-services","namespace":"ffs"}, "namespace": "ffs", "name": "security-services", "reconcileID": "6d14dcf1-ac2c-458e-ae91-07b67d6509eb"} 2024-02-06T11:34:09Z	ERROR	scaleexecutor	failed to patch Objects	{"scaledobject.Name": "security-services", "scaledObject.Namespace": "ffs", "scaleTarget.Name": "security-services", "error": "client rate limiter Wait returned an error: context canceled"} github.com/kedacore/keda/v2/pkg/status.TransformObject 	/workspace/pkg/status/status.go:186 github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).updateLastActiveTime 	/workspace/pkg/scaling/executor/scale_executor.go:81 github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale 	/workspace/pkg/scaling/executor/scale_scaledobjects.go:153 github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers 	/workspace/pkg/scaling/scale_handler.go:247 github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop 	/workspace/pkg/scaling/scale_handler.go:180 2024-02-06T11:34:09Z	ERROR	scaleexecutor	Error updating last active time	{"scaledobject.Name": "security-services", "scaledObject.Namespace": "ffs", "scaleTarget.Name": "security-services", "error": "client rate limiter Wait returned an error: context canceled"} github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale 	/workspace/pkg/scaling/executor/scale_scaledobjects.go:155 github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers 	/workspace/pkg/scaling/scale_handler.go:247 github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop 	/workspace/pkg/scaling/scale_handler.go:180
Expected Behavior
Applicatiion should have upgraded with specified ScaledObject configuration which were going to applied with helm upgrade
Actual Behavior
Helm upgrade failed with below error
Error: UPGRADE FAILED: cannot patch "app-gateway" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded && cannot patch "security-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded && cannot patch "config-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded && cannot patch "security-services" with kind ScaledObject: Timeout: request did not complete within requested timeout - context deadline exceeded
Steps to Reproduce the Problem
1.modify scaledObject parameter
2.try to upgrade application chart with modified values
3.Helm upgrade would fail with error given in description
Logs from KEDA operator
2024-02-06T11:34:09Z	INFO	Initializing Scaling logic according to ScaledObject Specification	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"security-services","namespace":"ffs"}, "namespace": "ffs", "name": "security-services", "reconcileID": "6d14dcf1-ac2c-458e-ae91-07b67d6509eb"}
2024-02-06T11:34:09Z	ERROR	scaleexecutor	failed to patch Objects	{"scaledobject.Name": "security-services", "scaledObject.Namespace": "ffs", "scaleTarget.Name": "security-services", "error": "client rate limiter Wait returned an error: context canceled"}
github.com/kedacore/keda/v2/pkg/status.TransformObject
	/workspace/pkg/status/status.go:186
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).updateLastActiveTime
	/workspace/pkg/scaling/executor/scale_executor.go:81
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale
	/workspace/pkg/scaling/executor/scale_scaledobjects.go:153
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:247
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:180
2024-02-06T11:34:09Z	ERROR	scaleexecutor	Error updating last active time	{"scaledobject.Name": "security-services", "scaledObject.Namespace": "ffs", "scaleTarget.Name": "security-services", "error": "client rate limiter Wait returned an error: context canceled"}
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale
	/workspace/pkg/scaling/executor/scale_scaledobjects.go:155
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:247
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:180

KEDA Version
2.12.1
Kubernetes Version
1.27
Platform
Google Cloud
Scaler Details
Confluent Kafka
Anything else?
No response

Hello
What version did you upgrade from? The message client rate limiter looks related with the client limiter. I guess that you have too many resources for current values and you need to increase them.  This can be produced because during the upgrade operation, all the resources have to be upgraded and it can trigger the local rate limit.
If the error persists during the time, it can be produced by a legit increase. In that case, I'd suggest increasing the limits modifying this parameters: https://keda.sh/docs/2.12/operate/cluster/#kubernetes-client-parameters

old version was 2.8.2, it was upgraded to 2.12.1,  two weeks ago.
if we edit directly single scaleObject using
'kubectl edit scaleobject ....... -n ....'
then also we have seen such error in keda operator pod.

How many resources do you have? (approx) Including all KEDA resources
So, If you just edit a ScaledObject, the error happens, right?

Yes , we have around 32 scaledObject  , yes if edit a scaledObject or upgrade via helm as well , we can see those errors.
if possible we can have small call to discuss in details and we can show the exact scenario.

we had also tried with diff application and here more detailed logs
2024-02-06T16:46:47Z	INFO	Initializing Scaling logic according to ScaledObject Specification	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"appexample","namespace":"exampleernor"}, "namespace": "exampleernor", "name": "appexample", "reconcileID": "352d92ae-8149-466a-b6da-521b5d7cfcb6"}
2024-02-06T16:46:47Z	ERROR	prometheus_scaler	error executing prometheus query	{"type": "ScaledObject", "namespace": "exampleernor", "name": "appexample", "error": "Get \"http://frontend.management:9090/api/v1/query?query=sum%28rate%28dapr_http_server_request_count%7Bapp_id%3D%22exampleernor%22%2C+cluster%3D%22exampleernor-cluster40%22%2Cpath%3D~%22%2Fv1.0%2Finvoke%2Fexampleernor%2Fmethod%2Finterceptor%2F.%2A%22%7D%5B5s%5D%29%29&time=2024-02-06T16:46:46Z\": context canceled"}
github.com/kedacore/keda/v2/pkg/scalers.(*prometheusScaler).GetMetricsAndActivity
	/workspace/pkg/scalers/prometheus_scaler.go:359
github.com/kedacore/keda/v2/pkg/scaling/cache.(*ScalersCache).GetMetricsAndActivityForScaler
	/workspace/pkg/scaling/cache/scalers_cache.go:129
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScalerState
	/workspace/pkg/scaling/scale_handler.go:699
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScaledObjectState
	/workspace/pkg/scaling/scale_handler.go:590
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:241
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:180
2024-02-06T16:46:47Z	ERROR	prometheus_scaler	error executing prometheus query	{"type": "ScaledObject", "namespace": "exampleernor", "name": "appexample", "error": "Get \"http://frontend.management:9090//api/v1/query?query=sum%28rate%28dapr_http_server_request_count%7Bapp_id%3D%22exampleernor%22%2C+cluster%3D%22exampleernor-cluster40%22%2Cpath%3D~%22%2Fv1.0%2Finvoke%2Fexampleernor%2Fmethod%2Finterceptor%2F.%2A%22%7D%5B5s%5D%29%29&time=2024-02-06T16:46:47Z\": context canceled"}
github.com/kedacore/keda/v2/pkg/scalers.(*prometheusScaler).GetMetricsAndActivity
	/workspace/pkg/scalers/prometheus_scaler.go:359
github.com/kedacore/keda/v2/pkg/scaling/cache.(*ScalersCache).GetMetricsAndActivityForScaler
	/workspace/pkg/scaling/cache/scalers_cache.go:139
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScalerState
	/workspace/pkg/scaling/scale_handler.go:699
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScaledObjectState
	/workspace/pkg/scaling/scale_handler.go:590
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:241
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:180
2024-02-06T16:46:47Z	ERROR	scale_handler	error getting scale decision	{"scaledObject.Namespace": "exampleernor", "scaledObject.Name": "appexample", "scaler": "prometheusScaler", "error": "Get \"http://frontend.management:9090//api/v1/query?query=sum%28rate%28dapr_http_server_request_count%7Bapp_id%3D%22exampleernor%22%2C+cluster%3D%22exampleernor-cluster40%22%2Cpath%3D~%22%2Fv1.0%2Finvoke%2Fexampleernor%2Fmethod%2Finterceptor%2F.%2A%22%7D%5B5s%5D%29%29&time=2024-02-06T16:46:47Z\": context canceled"}
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScalerState
	/workspace/pkg/scaling/scale_handler.go:720
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).getScaledObjectState
	/workspace/pkg/scaling/scale_handler.go:590
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:241
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:180
2024-02-06T16:46:47Z	ERROR	scaleexecutor	failed to patch Objects	{"scaledobject.Name": "appexample", "scaledObject.Namespace": "exampleernor", "scaleTarget.Name": "appexample", "error": "client rate limiter Wait returned an error: context canceled"}
github.com/kedacore/keda/v2/pkg/status.TransformObject
	/workspace/pkg/status/status.go:186
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).setCondition
	/workspace/pkg/scaling/executor/scale_executor.go:106
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).setReadyCondition
	/workspace/pkg/scaling/executor/scale_executor.go:113
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale
	/workspace/pkg/scaling/executor/scale_scaledobjects.go:178
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:247
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:180
2024-02-06T16:46:47Z	ERROR	scaleexecutor	error setting ready condition	{"scaledobject.Name": "appexample", "scaledObject.Namespace": "exampleernor", "scaleTarget.Name": "appexample", "error": "client rate limiter Wait returned an error: context canceled"}
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale
	/workspace/pkg/scaling/executor/scale_scaledobjects.go:179
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
	/workspace/pkg/scaling/scale_handler.go:247
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
	/workspace/pkg/scaling/scale_handler.go:180
2024-02-06T16:46:47Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"appexample","namespace":"exampleernor"}, "namespace": "exampleernor", "name": "appexample", "reconcileID": "59a5139e-8360-493a-a4d1-090e9b17b053"}
2024-02-06T16:46:47Z	INFO	scaleexecutor	Successfully set ScaleTarget replicas count to ScaledObject minReplicaCount	{"scaledobject.Name": "appexample", "scaledObject.Namespace": "exampleernor", "scaleTarget.Name": "appexample", "Original Replicas Count": 3, "New Replicas Count": 4}
2024-02-06T16:47:01Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"appexample","namespace":"exampleernor"}, "namespace": "exampleernor", "name": "appexample", "reconcileID": "eec2bb9c-2662-470b-ade1-2aaba18a6e3d"}
2024-02-06T16:47:16Z	INFO	Reconciling ScaledObject	{"controller": "scaledobject", "controllerGroup": "keda.sh", "controllerKind": "ScaledObject", "ScaledObject": {"name":"appexample","namespace":"exampleernor"}, "namespace": "exampleernor", "name": "appexample", "reconcileID": "f9175c65-692a-4a34-b5bb-db84acc2148d"}

I think this error is coming because keda is unable to GET the output of the prometheus query within 3 secs (which is the default value).
2024-02-06T16:46:47Z	ERROR	scale_handler	error getting scale decision	{"scaledObject.Namespace": "exampleernor", "scaledObject.Name": "appexample", "scaler": "prometheusScaler", "error": "Get "http://frontend.management:9090//api/v1/query?QUERY_TRIMMED\": context canceled"}
And if we increase the value of KEDA_HTTP_DEFAULT_TIMEOUT to lets say 10000millisecs, it might help (updating this will be applicable to all the scalers).
I am not sure but maybe increasing the value of MaxConcurrentReconciles to a bit higher value like 25-30 might help because its default value is 5 and to reconcile during patching might be taking longer time and eventually it might be timing out throwing this error "Request did not complete within requested timeout".
@JorTurFer , I am new to keda but please do correct me if I am wrong.
Thank you,
Sunny

Hello,
If you are facing with frequent timeouts in that scaler, you can increase a bit the timeout, and it will help for sure. In the same way, if you have multiple scalers failing at the same time, all of them will try to be recreated in parallel using MaxConcurrentReconciles.
The problem that I see is that the message says client rate limiting, wich is managed by the parameters I sent: keda.sh/docs/2.12/operate/cluster/#kubernetes-client-parameters
I see them as different issues, the Prometheus timeout is triggering the API rate limit as KEDA patches the ScaledObjects on each fail.
BTW, we fixed a memory leak related with prometheus (and other scalers based on http) which happened if the scaler was failing so often. The fix was released as part of v2.13

Understood. Since it was failing for a single iteration/patch as well that's why it is a bit confusing.
But thanks for the clarification this helps.
Just a small question based on the above example with 32 scaled objects I think the default values should be fine, but could you please suggest what should be the optimum value in this case?
cfg.QPS | 20.0
cfg.Burst | 40
Thank again,
Sunny

I'd just try with the double:
cfg.QPS | 40
cfg.Burst | 80

I'd just try with the double: cfg.QPS | 40 cfg.Burst | 80

I tried with cfg.QPS | 40 cfg.Burst | 80 values and unfortunately still I am getting the same kind of error.
And just to add in this case I just had 5 scaledobjects

2024-02-07T11:33:48Z    ERROR   scaleexecutor   failed to patch Objects {"scaledobject.Name": "app-isvc1", "scaledObject.Namespace": "app1", "scaleTarget.Name": "app-isvc1", "error": "client rate limiter Wait returned an error: context canceled"}
github.com/kedacore/keda/v2/pkg/status.TransformObject
/workspace/pkg/status/status.go:186
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).setCondition
/workspace/pkg/scaling/executor/scale_executor.go:106
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).setActiveCondition
/workspace/pkg/scaling/executor/scale_executor.go:120
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale
/workspace/pkg/scaling/executor/scale_scaledobjects.go:224
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
/workspace/pkg/scaling/scale_handler.go:247
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
/workspace/pkg/scaling/scale_handler.go:180
2024-02-07T11:33:48Z    ERROR   scaleexecutor   Error setting active condition when triggers are not active     {"scaledobject.Name": "app-isvc1", "scaledObject.Namespace": "app1", "scaleTarget.Name": "app-isvc1", "error": "client rate limiter Wait returned an error: context canceled"}
github.com/kedacore/keda/v2/pkg/scaling/executor.(*scaleExecutor).RequestScale
/workspace/pkg/scaling/executor/scale_scaledobjects.go:225
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).checkScalers
/workspace/pkg/scaling/scale_handler.go:247
github.com/kedacore/keda/v2/pkg/scaling.(*scaleHandler).startScaleLoop
/workspace/pkg/scaling/scale_handler.go:180

Not sure if in case this is something else, btw about the memory leak issue do you think this could be interrelated?
I think no but just wanted to be sure, I believe the memory leak would affect the pod and once the pod has reached its memory threshold it would just restart but the application logic would run fine. Please correct me if I am wrong.
Thank you.

That's weird :/
Could you share your scaledobjects? if they are similar, one it's just enough

please refer below scaledObject yaml file
kind: ScaledObject
metadata:
  name: app-services
  labels:
    helm.sh/chart: app-1.0.0
    app.kubernetes.io/name: app
    app.kubernetes.io/instance: app
    app.kubernetes.io/version: "1.0.0"
    app.kubernetes.io/managed-by: Helm
spec:
  minReplicaCount: 3
  maxReplicaCount: 500
  pollingInterval: 1 # Optional. Default: 30 seconds
  cooldownPeriod: 300 # Optional. Default: 300 seconds
  scaleTargetRef:
    name: app-services
  advanced:                                          # Optional. Section to specify advanced options
    horizontalPodAutoscalerConfig:
      behavior:
        scaleDown:
          stabilizationWindowSeconds: 300
    restoreToOriginalReplicaCount: false
  triggers:
    - type: prometheus
      metadata:
        serverAddress: http://frontend.management:9090/
        metricName: http_server_requests_seconds_count
        query: sum(rate(http_server_requests_seconds_count{application="app", cluster="dr-cluster",uri=~"/.*"}[5s]))
        threshold: "50"

@JorTurFer:
Following the suggestion to whitelist port 9443, which was found in this bug report [https://github.com/kedacore/keda/discussions/4660], the helm upgrade command was successful. Previously, it was failing due to a timeout issue. However, despite these adjustments, the expected patching of scaledObjects is not occurring.
We've thoroughly tested all parameters without success. Additionally, we've encountered some unusual behavior in another environment, related to a different application. While the helm upgrade is successful and scaledObjects are patched for individual changes, if there are multiple scaled object changes, it only updates three out of four, with one giving the aforementioned error. Perhaps @sunnybhambhani can provide further insight into this behavior.
However, in our main application cluster, there have been no changes regarding the patching of scaledObjects. Therefore, the current issue remains that scaledObjects are not being updated despite a successful helm upgrade.
Please note that this environment is a private cluster with very restricted access. It's important to consider this perspective while addressing the issue.

A few quick observations, the polling interval set to 1 sec is very aggressive given that your Prometheus instance is probably not able to handel that many requests and respond before the timeout.
Are you able to run a quick load test against the Prometheus and try to run similar query, to see if it is able to handle it?

@zroubalik
we temporarily increased the poll interval time from 1 second to 10 seconds. This change resulted in the desired scaledObjects being updated in our lower & Higher environments.
Subsequently, we reverted the poll interval back to its original value of 1 second, and since then, everything has been functioning as expected.
It's worth noting that despite no other changes being made, the behaviour of scaledObjects being updated was observed due to this poll interval adjustment, which may seem somewhat unusual.
The keda-operator is displaying an errors despite this reflection.

It's worth noting that despite no other changes being made, the behaviour of scaledObjects being updated was observed due to this poll interval adjustment, which may seem somewhat unusual.
The keda-operator is displaying an errors despite this reflection.

Hi, sorry I don't follow these two paragraphs, could you please give me more context?

I mean offourse this will take command once existing pod will get terminated by any reason.

Yes, that'll happen but it won't be instantly because the operator relies on leader election API and it'll need some time (10-15) to lease the leader lock

But based on the latest comments, I'm not sure that the operator is the problem but the amount of requests against the prometheus server. Having 32 ScaledObjects with 1 second of pollingInterval, you will execute 32  queries per second agains the server.
The timeout message (not the client rate limiter) is thrown because the server isn't responding in time

But based on the latest comments, I'm not sure that the operator is the problem but the amount of requests against the prometheus server. Having 32 ScaledObjects with 1 second of pollingInterval, you will execute 32 queries per second agains the server.
The timeout message (not the client rate limiter) is thrown because the server isn't responding in time

that's exactly my thought here

I'd not expect that for just 22 ScaledObject you would have needed to tweak the configurations as 22 is a small number, but if they work for you, that's the goal. Probably the short polling interval is making that you need higher valuers because if the Prometheus server is down you will emit more events, so can be normal I guess

Thanks for sharing, my guess would also be the Prometheus side, 22 ScaledObjects is not a huge number.

We have ~ 30 scaledobjects running in our eks cluster, when scaling down, we observed that for one of the applications, the scale-down did not take place for a significant time for the desired pod count even when the metric was under the right threshold!
When keda-operator logs were checked for the same, we identified the error:
2024-04-26T11:17:33Z	ERROR	scaleexecutor	Error setting active condition when triggers are inactive	{"scaledobject.Name": "<name>", "scaledObject.Namespace": "<namespace>", "scaleTarget.Name": "<name>", "error": "client rate limiter Wait returned an error: context canceled"}
as part of the suggestions above, we will try to tweak the parameters namely kube-api-qps and kube-api-burst, but there are some concerns, how can we estimate the impact on the API-server when these parameters are tweaked to use a number higher than default (any metric that can help as exposed by keda)? Which metric exposed by keda-operator can account for evaluating the ideal number for the client parameters?
@JorTurFer @zroubalik

how can we estimate the impact on the API-server when these parameters are tweaked to use a number higher than default (any metric that can help as exposed by keda)?

You can monitor the API server components and measure the impact, KEDA doesn't have information about how the api server performs

Which metric exposed by keda-operator can account for evaluating the ideal number for the client parameters?

we don't expose any specific metric from KEDA but the operator sdk exposes this metric that can be useful rest_client_requests_total. IIRC it's the amount of request against the control plane, so measuring it you could estimate the correct value


Can tensorflow support alluxio as storage filesystem?

hello，
As a storage middle tier, alluxio can mount file systems such as hdfs, nfs, etc., while providing efficient caching capabilities. If tensorflow supports reading data directly from alluxio, it would be very beneficial.

Hi @myg821561935 , you can find instruction about how to do this here: https://docs.alluxio.io/os/user/stable/en/compute/Tensorflow.html
@BinFan

@myg821561935  Did you get a chance to see the instructions suggested by haoyuan. Thanks!

Automatically closing due to lack of recent activity. Please update the issue when new information becomes available, and we will reopen the issue. Thanks!


Add global error handler and renderer

https://medium.com/the-vue-point/vue-2-5-released-14bd65bf030b

worth noting: https://github.com/vuejs/vue/issues/6953#issuecomment-340335435

According to the above comment, we have 2 kinds of errors - for simplicity, let's say, we have DOM Event errors, and 'everything else'.
At the moment, DOM Event errors, exceptions, etc, are not handled at all, they are silent and we don't know about them. 'Everything else' tho, throws [Vue warn] ... to the console. (as far as I know)
Thanks to this new errorCaptured hook, we can do something more with those errors (not DOM Event ones), but the question is, what do we want to do with them exactly.
I was thinking about the shop having 'dev mode', so we could place those errors to some kind of a HTML container, and show it to the devs. In 'prod mode' tho, errors will not be shown, instead, they could be shown in console only.

OK, i think for now we could make use of: https://stackoverflow.com/questions/31472439/catch-all-unhandled-javascript-promise-rejections
and
https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onerror
BUT it's need to be tested while offline because I'm affraid that elasticsearch-js is raising lot of errors when there is no ElasticSearch enabled which in our case is not an issue (we do have cachced data localy)
To display error page with the details dumped to dev console in that case.
I move it to 0.4 as it's not key for now


Improve definition of 'GO:0036206' regulation of histone gene expression

The definition is too generic - @colinlog can provide a better definition.

Obsoleted in  #20209


React-JSX-Highstock example with date range picker does not work

After a week of debugging, it appears that something in the way React handles dot notation appears to have been broken.
In the example and ALL other references to react-jsx-highstock with date range pickers, the code uses...
<DayPicker.Input />
This however does not work unless the import statement explicitly includes...
import { DayPickerInput } from 'react-day-picker/lib/src/DayPickerInput;'  but the repo example uses the following import import DayPicker from 'react-day-picker; instead.
So the problem is with the import statement only importing the main default class of DayPicker and the dot notation not being recognized. The solution is to load the correct import { DayPickerInput } and dropping the dot notation to be more explicit.
<DayPickerInput />

Ahh, good spot.
In the examples I am using React Day Picker from the browser export, rather than from the NPM module.
The browser global exports as DayPicker.Input but the NPM modules exports as DatePickerInput.
You can see how to use React DayPicker inputs here or alternatively you can use it as an importable NPM module - which is now fixed
Note to self, I need to fix these misleading examples (#75)


Loosening restrictions on tuple types "Array contains Val"

I have read through the docs before coming here, if I missed something important my apologies
Question
I need to validate a tuple type: [Status] where:

the actual array only need to contain a Status anywhere within the array regardless of it's index.
The array must have a length > 1
There can be as many or no elements before of after Status

Essentially Must contain a Status, anywhere is the validation requirement. Which sounds deceptively simple, but is turning out to be rather difficult to actually get generated.
I'm struggling to do this with typia:

a Status[] is an arrya of only Status
A [...unknown[], Status] is an array with Status as the last element
A [...unknown[], Status, ...unknown[]] is an invalid type
[...unknown[], Status] | [Status, ...unknown[]

Doesn't produce a correct validator: ['stuff', 'SUCCESS'] fails validation
tuplePredicators expect the array to be of length 1 or 2 only. And only expects a Status at [0]?

A string[] | [Status] is a valid type but results in nonsensible intersection
A Array<Status> & Array<unknown>  results in nonsensible intersection (This wouldn't make sense for typing anyways)

How do I do this?
I do recognize the asinine-ness of this value, but... legacy system modeling

Also interestingly:
// This will generate
export type InArray<TVal> =
    | [TVal]
    | [unknown, TVal]
    | [TVal, unknown];

// This will fail with: TypeError: Cannot read properties of undefined (reading 'any')
export type InArray<TVal> =
    | [TVal]
    | [unknown, TVal]
    | [TVal, unknown]
    | [TVal, unknown, unknown]
    | [unknown, TVal, unknown]
    | [unknown, unknown, TVal];

Also interestingly:
// This will generate
export type InArray<TVal> =
    | [TVal]
    | [unknown, TVal]
    | [TVal, unknown];

// This will fail with: TypeError: Cannot read properties of undefined (reading 'any')
export type InArray<TVal> =
    | [TVal]
    | [unknown, TVal]
    | [TVal, unknown]
    | [TVal, unknown, unknown]
    | [unknown, TVal, unknown]
    | [unknown, unknown, TVal];

I'm testing on it but error is not occured. Which value occurs the error?
https://typia.io/playground/?script=JYWwDg9gTgLgBDAnmYBDOAzKERwERIqp4DcAUGYQKZwAqAaqgDZwC8cAdgK4gBGVUclQAekWAmQ0AkhwCCUKKkRsycNXAA+cANoNmAXVXqt2rhwDWHCAHcOAGjqMmh9Zp16mDs5ZscXx9ycvCytbYJ9bfzUTb1D7R2ZwuKi3UxDfJIyE53IyAGMIDgBneGAitgkiADo8qCpUGCopIoAeGXlFRAA+AAoASnIC4ogmKiqmCABzHqMynu08Qqo8BwAmBwBmfT67Mj6gA

About the rest elements type in the first or middle position in the tuple, I haven't known the spec.
By the way, I may need more investigation times because it is actually not possible in the JSON schema specification.

Thanks for the reply @samchon !! I really appreciate it ^_^
Here's the stacktrace/error for the above:
> pnpm typia generate --input ./src/validators/templates --output ./src/validators/generated --project tsconfig.json

----------------------------------------
 Typia Generate Wizard
----------------------------------------
TypeError: Cannot read properties of undefined (reading 'any')
    at Metadata.covers (/home/douglas/programming/08_ivr/ivr3/node_modules/.pnpm/typia@6.10.4_typescript@5.6.2/node_modules/typia/lib/schemas/metadata/Metadata.js:371:20)
    at /home/douglas/programming/08_ivr/ivr3/node_modules/.pnpm/typia@6.10.4_typescript@5.6.2/node_modules/typia/lib/schemas/metadata/Metadata.js:415:75
    at Array.every (<anonymous>)
    at /home/douglas/programming/08_ivr/ivr3/node_modules/.pnpm/typia@6.10.4_typescript@5.6.2/node_modules/typia/lib/schemas/metadata/Metadata.js:415:34
    at Array.some (<anonymous>)
    at _loop_4 (/home/douglas/programming/08_ivr/ivr3/node_modules/.pnpm/typia@6.10.4_typescript@5.6.2/node_modules/typia/lib/schemas/metadata/Metadata.js:411:30)
    at Metadata.covers (/home/douglas/programming/08_ivr/ivr3/node_modules/.pnpm/typia@6.10.4_typescript@5.6.2/node_modules/typia/lib/schemas/metadata/Metadata.js:423:35)
    at /home/douglas/programming/08_ivr/ivr3/node_modules/.pnpm/typia@6.10.4_typescript@5.6.2/node_modules/typia/lib/factories/internal/metadata/iterate_metadata_sort.js:146:48
    at Array.sort (<anonymous>)
    at /home/douglas/programming/08_ivr/ivr3/node_modules/.pnpm/typia@6.10.4_typescript@5.6.2/node_modules/typia/lib/factories/internal/metadata/iterate_metadata_sort.js:141:29


Move Heron to an independent open source foundation

Placeholder for tracking the discussions about moving Heron to an independent open source foundation

+1 to apache.

Twitter is a founding member of Cloud Native Computing Foundation ( https://cncf.io/ ).  Any experiences with CNCF, or pros/cons compared to Apache? Heron could become the 3rd project next to Kubernetes and Prometheus.

The ASF proposal looks pretty compelling to me, FWIW, but some other options that may not be on your radar:

Joint Development Foundation <jointdevelopment.org> provides an easy and inexpensive structure for projects to launch under an independent non-profit framework (disclosure: I'm on the Board)

Launching as an independent non-profit entity is simpler and cheaper than most people think, particularly if you use an association management firm to handle the details, and gives you lots of control of your own destiny.

--Brad

Looks like this is happening at the ASF so this issue can be closed IMHO: https://wiki.apache.org/incubator/HeronProposal

yes indeed.


⚠ Bofrost.de has degraded performance

In f0399ec, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1025 ms

Resolved: Bofrost.de performance has improved in 44353de after 6 minutes.


Add InvertedBoolConverter

Documentation added for .NET MAUI Community Toolkit proposals:

[Proposal] InvertedBoolConverter  https://github.com/CommunityToolkit/Maui/issues/64

Docs Build status updates of commit 1a41dd5:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/maui/TOC.yml
:white_check_mark:Succeeded
View

docs/maui/converters/index.md
:white_check_mark:Succeeded
View

docs/maui/converters/inverted-bool-converter.md
:white_check_mark:Succeeded
View

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

PRMerger Results

Issue
Description

Added File(s)
This PR contains added files. New files require human review.

Yaml File(s)
This PR includes changes to .yml file(s) owned by another author.

File Change Percent
This PR contains file(s) with more than 20% file change.

Index File
This PR contains a change to the index file.


Where can i find the latest jar file ?

When i look at the release i dont see any jar files.

Releases are now pushed to maven central : https://repo1.maven.org/maven2/net/micedre/keycloak/keycloak-mail-whitelisting/1.3.3/
I will add a link in releases.

Thank You


Use new way to determine OS arch

This avoids the possibility of the file command returning "64" within /sbin/init's SHASUM, making the script incorrectly determine the OS architecture.

Thanks!


Offline Application ?

Hi I have try to install the app from Xcode.
Everything went smooth but I have a question do we always need an internet connection to use the app once installed on iOS devices for exemple ?
Thanks for the answer.

You need an internet connection if you are running the debug version of the app on your device. This is because the app needs to connect to the package server (hosted on your development machine) to fetch the JS and assets files. You would not need an internet connection while testing release builds of your app. In release builds, the assets you include are bundled locally within the app.

reopening to see if OP had additional comments.


dtrace: error on enabled probe ID 1

I'm experimenting with cpuprofilify and I've noticed that after killing the process, the first messages that come out from cpuprofilify are:
dtrace: error on enabled probe ID 1 (ID 283616: profile:::profile-1ms): invalid address (0x100fc5e60) in action #5
Can you give me a hint on what does this mean?

Not quite the dtrace expert, this is a dtrace problem.
If it continues running though then you should be fine, dtrace spits out tons of warnings.


Update batch_normalization.py

I did several changes for batch_normalization.
Plz, feel free to comment your thought about my changes.

Add initial values for params on build method.

        self.gamma = None
        self.beta = None
        self.moving_mean = None
        self.moving_variance = None
        self._reduction_axes = None

Remove un-used parameter

        self.input_spec = InputSpec(
            ndim=len(input_shape), axes={self.axis: input_shape[self.axis]}
        )

Take duplicate code out of if condition block

        moving_mean = ops.cast(self.moving_mean, inputs.dtype)
        moving_variance = ops.cast(self.moving_variance, inputs.dtype)

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.50%. Comparing base (f0e79cf) to head (906e382).

:exclamation:  There is a different number of reports uploaded between BASE (f0e79cf) and HEAD (906e382). Click for more details.
HEAD has 6 uploads less than BASE

Flag
BASE (f0e79cf)
HEAD (906e382)

keras
4
1

keras-torch
1
0

keras-tensorflow
1
0

keras-jax
1
0

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #20057       +/-   ##
===========================================
- Coverage   79.27%   57.50%   -21.78%
===========================================
  Files         501      501
  Lines       46939    46942        +3
  Branches     8653     8653
===========================================
- Hits        37209    26992    -10217
- Misses       7982    18272    +10290
+ Partials     1748     1678       -70

Flag
Coverage Δ

keras
57.50% <100.00%> (-21.63%)
:arrow_down:

keras-jax
?

keras-numpy
57.50% <100.00%> (+<0.01%)
:arrow_up:

keras-tensorflow
?

keras-torch
?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Furthermore, I'd love to contribute to more impactful project also. so, if you let me know, I think I could try that.

That's great! Would you be interested in one of:

Helping bring new pretrained models in Keras (e.g. StableDiffusion 3 or Llama 3)
Helping create a Keras backend for MLX?

@fchollet
Hi, I found that there are keras-cv and keras-nlp, and there are stable diffusion, and llama. So, you asked me to add pretrained model to there as matched with its model type, not only keras repo?

So, you asked me to add pretrained model to there as matched with its model type, not only keras repo?

If that's something you're interested in, we're looking for contributors in that area and we may have a project for you.

@fchollet
Actually, I am really interested in implementing algorithm from research paper. However, as of now, I am not familliar with that, I have studied with your code like convnext and research paper you refered. Maybe it takes time to do that for me. so it is kind of challenging for me to lead that project, however,if you set up that kind of project, I think I could support that project by all my efforts.


added option to detect multiple faces in detectFace

Hi!
I wanted to detect multiple faces in an image but the library didn't offer any support for multiple face detection. Detecting multiple faces in the images might be a use case for other developers too!
I've run unit_test.py and attached the output : unit_tests.txt
PS: I am not a pro. Please suggest any design changes if it can be done in a better way!

Hi,
this looks a lot like a thing I was looking for .
Unfortunately I am a python-noob, so I wont be of help a lot.
I fixed my needs by using a function @serengil implemented in retinaface ([https://github.com/serengil/retinaface/blob/master/retinaface/RetinaFace.py])
@serengil: could you possibly port that function to deepface?
Let me explain my motivation: I am trying to add name tags to my photo collection. I am using shotwell on Ubuntu and thats a feature I am missing

Sure, I will do a code review and merge it soon.

Sure, I will do a code review and merge it soon.

Any update on this?

this feature covered in the new release by default


Fix dashboard offers bug

This PR fixes a bug that allows dashboard users to create conditions with no value, type or range, as long as one is provided.
PS: Please excuse the many PRs I created 😅 , this is my first one.

I've been trying to make this work and I have no

@fceruti thanks for working on this. Please don't create new PRs every time. Just push new commits to this branch to make any changes you need to make.


Fatal application error ocurred: Unsupported Thingsboard version : <IP_ADDRESS>PAAS

I am facing a issue on running flutter application of thingsboard like below:
⛔ Failed to init tbContext: ThingsboardError: message: [Unsupported ThingsBoard platform version: <IP_ADDRESS>PAAS], errorCode: 2, status: null
⛔ #0      toThingsboardError (package:thingsboard_client/src/error/_thingsboard_error_handler_io.dart:89:18)
⛔ #1      ThingsboardClient.init (package:thingsboard_client/src/thingsboard_client_base.dart:247:13)
⛔ <asynchronous suspension>
⛔ #2      TbContext.init (package:thingsboard_app/core/context/tb_context.dart:126:7)
⛔ <asynchronous suspension>
⛔ #3      HasTbContext.initTbContext (package:thingsboard_app/core/context/has_tb_context.dart:41:5)
⛔ <asynchronous suspension>

ThingsBoard PE version : <IP_ADDRESS>
Flutter ThingsBoard PE Mobile Application: 1.4.0
Dart ThingsBoard PE Client: ^2.0.0
please guide me on this issue.

You have to use PE app with PE platform.
And CE app with CE platform.
As I answered you before please read the doc to know the difference https://thingsboard.io/docs/mobile/


Build failure: invariant-0.2.2 using bifunctors-5.2

[4 of 4] Compiling Data.Functor.Invariant ( src/Data/Functor/Invariant.hs, .stack-work/dist/x86_64-linux/Cabal-<IP_ADDRESS>/build/Data/Functor/Invariant.o )

/home/dan/scratch/invariant-0.2.2/src/Data/Functor/Invariant.hs:277:12:
    Kind incompatibility when matching types:
      f0 :: * -> * -> *
      Joker g :: k -> * -> *
    Expected type: (a1 -> b)
                   -> (b -> a1) -> Joker g a a1 -> Joker g a b
      Actual type: (a1 -> b) -> (b -> a1) -> f0 c0 a1 -> f0 c0 b
    Relevant bindings include
      invmap :: (a1 -> b) -> (b -> a1) -> Joker g a a1 -> Joker g a b
        (bound at src/Data/Functor/Invariant.hs:277:3)
    In the expression: invmap2 id id
    In an equation for ‘invmap’: invmap = invmap2 id id

How I reproduced this on my local machine:

stack unpack invariant-0.2.2 && cd invariant-0.2.2
stack init --resolver nightly-2016-01-16
edit stack.yaml, change extra-deps: [] to extra-deps: [bifunctors-0.2]
stack build

I've uploaded invariant-0.3 to Hackage recently, which does not experience this error.


[WIP] Added Additional Schemas and various config opeations

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

[ ] N
[x] Y

re #2
2. What is the scope of this PR (e.g. component or file name):

gammar.js
schema.txt
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

[ ] Affects user behaviors
[x] Contains syntax changes
[ ] Contains variable changes
[ ] Contains experimental features
[ ] Performance regression: Consumes more CPU
[ ] Performance regression: Consumes more Memory
[ ] Other

[x] Improved Code for Schema Statements
[x] Improved Code for Mixin Statements
[x] Improved Code for Rule Statements
[x] Added Test Cases for the above statements

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

[x] N
[ ] Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

[ ] Unit test
[ ] Integration test
[ ] Benchmark (add benchmark stats below)
[ ] Manual test (add detailed scripts or steps below)
[ ] Other

@Peefy, could you review it


hjs config --banner

Is your feature request related to a problem? Please describe.
create a banner when the project is already created without any banner
Describe the solution you'd like
Scenario: project already created without .hjs.banner.js
given a user wants to add a custom banner
and the project already  exists
and there is no .hjs.banner.js file
when the user execute hjs config --banner
then it should create a hjs.banner.js in the root
Scenario: project already created with .hjs.banner.js
given a user wants to add a custom banner
and the project already  exists
and there is an existing .hjs.banner.js file
when the user execute ```hjs config --banner
then the terminal should ask you if you want to overwrite the existing banner
and press y -> create new one
and press n -> dont do anything

❤ 0.24.0
Enjoy!


Duplicated group_vars/all.yml file inside contrib/terraform/openstack

Currently contrib/terraform/openstack has its own group_vars/all.yml, which is a normally a copy (outdated) of inventory/group_vars/all.yml . Is there a reason for this? otherwise I would suggest a soft link from the one in inventory/group_vars. Let me know to make the PR.

closed with #698


HurtWorld: OnPlayerSpawn not works

OnPlayerSpawn not works on Version 2.0.1720

---
Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/29893736-hurtworld-onplayerspawn-not-works?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F6855523&utm_medium=issues&utm_source=github).

The hook hasn't changed and is still in the same position. What are you trying to do with it?

    private void OnPlayerSpawn(PlayerSession player)
    {
           Puts("TEST");
    }

Are you sure your plugin is loaded? It's working fine for me.

WOW LOL... big sorry ... my bad ... i need use OnPlayerRespawn

OnPlayerRespawn also working:

big sorry, all works!

No problem. :)


python3Packages.pyfronius: 0.5.2 -> 0.5.3

Motivation for this change
Update to latest upstream release 0.5.3
Change log: https://github.com/nielstron/pyfronius/releases/tag/0.5.3
Things done

[x]  Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
21.11 Release Notes (or backporting 21.05 Relase notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Result of nixpkgs-review pr 129750 run on x86_64-linux 1

2 packages built:

python38Packages.pyfronius
python39Packages.pyfronius


add method for getting all shows

https://www.tvmaze.com/api#show-index

Pull Request Test Coverage Report for Build 83

5 of 7 (71.43%)  changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.2%) to 66.48%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

tvmaze/show.go
5
7
71.43%

Totals

Change from base Build 72:
0.2%

Covered Lines:
119

Relevant Lines:
179

💛  - Coveralls

429s that were ignored are now returned, as a bonus.

Released in v1.1.0: https://github.com/mrobinsn/go-tvmaze/releases/tag/v1.1.0


Bash/ZSH auto-complete docs

Closes https://github.com/urfave/cli/issues/863
Here's a first pass of updating the docs.  Hopefully I cleared up the process of enabling auto-completion.  I added some examples of what the auto-complete looks like, they're links to giphy.com, not sure if it'd be better to store the gifs themselves instead of having links.  If they don't look like they belong we can definitely remove them.  Let me know though and I'll make changes!

Thanks for helping out @masonj88 ✨ it's nearly there 👍

Oh, this has merge conflicts now because the documentation has moved!
You'll want to make these same changes against the v2 manual file now https://github.com/urfave/cli/blob/master/docs/v2/manual.md
@masonj88

I'll have it done soon!

Any update on this? Would it be ok if I made another PR to resolve these merge conflicts? This doc is sorely needed

@daxmc99 please do!

closing this as stale

@masonj188 feel free to race @daxmc99 for this PR 😆 but otherwise you can ignore this

Really sorry for taking so long, just opened a new pull request for the merge into the new master!


Bump Node.js to v18

MSW doesn't support Node.js v18 yet so the tests are still running on Node.js v16. Bump the version in the CI once MSW adds Node.js v18 support.
Please refer to this issue:
https://github.com/mswjs/msw/issues/1388

Does it makes sense to use next as this comment describes? https://github.com/mswjs/msw/issues/1388#issuecomment-1545693391

We can give it a shot, yes.

I tried it but the tests will break after upgrading to msw@next so I'd say let's wait for a proper release or a better release candidate.

It seems that there are breaking changes to we write tests
https://github.com/mswjs/msw/blob/feat/standard-api/MIGRATING.md
Currently migrating to use the new API


Feature: cluster-images is array

https://docs.github.com/en/actions/creating-actions/creating-a-composite-action


Problem Cubature

INFO: Installing Cubature v1.0.10
INFO: Building Cubature
INFO: Installing Cubature 1.0.2 library...
tar: cubature-1.0.2/clencurt.h: Cannot write: No space left on device
tar: cubature-1.0.2/cubature.h: Cannot write: No space left on device
tar: cubature-1.0.2/converged.h: Cannot write: No space left on device
tar: cubature-1.0.2/clencurt_gen.c: Cannot write: No space left on device
tar: cubature-1.0.2/ChangeLog: Cannot write: No space left on device
tar: cubature-1.0.2/README: Cannot write: No space left on device
tar: cubature-1.0.2/COPYING: Cannot write: No space left on device
tar: cubature-1.0.2/test.c: Cannot write: No space left on device
tar: cubature-1.0.2/pcubature.c: Cannot write: No space left on device
tar: cubature-1.0.2/hcubature.c: Cannot write: No space left on device
tar: Exiting with failure status due to previous errors
==============================[ ERROR: Cubature ]===============================
LoadError: failed process: Process(tar xzf cubature-1.0.2.tar.gz --directory=., ProcessExited(2)) [2]
while loading /home/juser/.julia/v0.4/Cubature/deps/build.jl, in expression starting on line 17
================================================================================
================================[ BUILD ERRORS ]================================
WARNING: Cubature had build errors.

packages with build errors remain installed in /home/juser/.julia/v0.4
build the package(s) and all dependencies with Pkg.build("Cubature")
build a single package by running its deps/build.jl script

================================================================================
INFO: Package database updated
How to solve?

Disk space allocated is 500MB. We probably need to give a better message.

strange ... cubature package is too large. I deleted several files and still continues.

It is probably the git repo history that is big? Have you had large files in the repo that you have later deleted? They still count for the repo size.

I deleted other packages and files but still the error. I solved using julia locally.


iox-#454 improve coverage of class roudi memory provider, block and m…

Pre-Review Checklist for the PR Author

[ ] Branch follows the naming format (iox-#123-this-is-a-branch)
[ ] Commits messages are according to this guideline

[ ] Commit messages have the issue ID (iox-#123 commit text)
[ ] Commit messages are signed (git commit -s)
[ ] Commit author matches Eclipse Contributor Agreement (and ECA is signed)

[ ] Update the PR title

Follow the same conventions as for commit messages
Link to the relevant issue

[ ] Relevant issues are linked
[ ] Add sensible notes for the reviewer
[ ] All checks have passed
[ ] Assign PR to reviewer

Notes for Reviewer
code contributed by @JimmyBch
Checklist for the PR Reviewer

[ ] Commits are properly organized and messages are according to the guideline
[ ] Code according to our coding style and naming conventions
[ ] Unit tests have been written for new behavior
[ ] Public API changes are documented via doxygen
[ ] Copyright owner are updated in the changed files
[ ] PR title describes the changes

Post-review Checklist for the PR Author

[ ] All open points are addressed and tracked via issues

Post-review Checklist for the Eclipse Committer

[ ] All checkboxes in the PR checklist are checked or crossed out
[ ] Merge

References

partly closes 454

closed https://github.com/eclipse-iceoryx/iceoryx/pull/478 and created new

closed https://github.com/eclipse-iceoryx/iceoryx/pull/478 and created new

@elBoberido @dkroenke Do you mind to review this PR and give your approval whether everything is ok ? :)

@elBoberido @dkroenke Do you mind to review this PR and give your approval whether everything is ok ? :)

@nihalchari or @JimmyBch please fill in the Pre-Review Checklist of the PR description

@nihalchari or @JimmyBch please fill in the Pre-Review Checklist of the PR description

Can you please update the copyright headers in the changed files so that they include the years of the creation and of the last modification, i.e. 2019, 2021?

Can you please update the copyright headers in the changed files so that they include the years of the creation and of the last modification, i.e. 2019, 2021?

@FerdinandSpitzschnueffler we didn't do it for files which were created in 2019 and adapted in 2020, so I'm not sure if we have to. I would prefer not to do it if not necessary.

@FerdinandSpitzschnueffler we didn't do it for files which were created in 2019 and adapted in 2020, so I'm not sure if we have to. I would prefer not to do it if not necessary.


setup google workspaces/email

We created a google workspace, need to configure gmail with route53.

Closing due to priority.


Add configuration tests

Should close #76, #75 and #69.

Closed with https://github.com/lwm/tasty-discover/commit/262bf21327c25aa6e5a5a7895d1b6ff1dbe84a76.


Problem with new config system

i am getting a lot of problems with the new config system,
problems like this:
npm ERR<EMAIL_ADDRESS>postinstall: `./node_modules/bower/bin/bower install && cp server/config.dist.yml server/config.yml`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>postinstall script.
npm ERR! This is most likely a problem with the agar-clone package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     ./node_modules/bower/bin/bower install && cp server/config.dist.yml server/config.yml
npm ERR! You can get their info via:
npm ERR!     npm owner ls agar-clone
npm ERR! There is likely additional logging output above.
npm ERR! System Linux 3.14.13-c9
npm ERR! command "/home/ubuntu/.nvm/v0.10.35/bin/node" "/home/ubuntu/.nvm/v0.10.35/bin/npm" "install"
npm ERR! cwd /home/ubuntu/workspace
npm ERR! node -v v0.10.35
npm ERR! npm -v 1.4.28
npm ERR! code ELIFECYCLE
npm ERR!
npm ERR! Additional logging details can be found in:
npm ERR!     /home/ubuntu/workspace/npm-debug.log
npm ERR! not ok code 0

the yml is the problem?

someone forgot add a configuration file to repo

Yeah I saw that the config was missing just make a file in /server/ called config.yml with this content https://github.com/huytd/agar.io-clone/commit/494c762d654034ee290116c7fd746bdfa0be51c6

this can fix:
https://github.com/huytd/agar.io-clone/pull/102

well... sometimes it's config.dist.yml and sometimes it's config.yml? @.@ omg omg :D

maybe just stay with config.yml in ./server

no, the config.dist was renamed to config.yml by npm

no, the config.dist was renamed to config.yml by npm

yes it was renamed by npm script but what was the reason for this renaming idk

i don't see any reason, its normal in automation, but useless

done, i removed the action


Update mqtt.esp

These are all my recent changes to mqtt, in which I am satisfied with the work, perhaps this will help you in the development

#539

Thank you very much for this @Aleks130699
Before working more on this though, I would like to discuss things a bit here: https://github.com/esprfid/esp-rfid/discussions/550

I'm closing this in favour of #559 that has all of these fixes plus some more. Thank you very much for helping out, it's been very useful!!


Add support for setting the realm to the HTTPUnauthorized class

Currently the class recognizes a scheme kwarg that can include a realm string, but IMO it would be better to make this explicit.
See also RFC 7235.

I can work on this.
@kgriffs it looks like the RFC says you can have multiple comma-separated challenges in a single header, or multiple headers. Each challenge is a scheme and zero or more comma separated key=value pairs. Also, optionally, the key=value pairs could be base64 encoded.
In order to implement all of this, I suggest the following:

Add a new kwarg for accepting a list of valid challenges. Each challenge would need a "scheme" item, and the other items would be used in comma-separate key=value format.
Add a new kwarg to control whether to base64 encode the key=value options
Add a new kwarg to control whether to set a single or multiple WWW-Authenticate parameters

I'm not sure whether this is the best way to implement though, so any feedback before I dive in would be appreciated. I'm also not sure what backwards-compatibility would look like, or if you want to drop it since this is a future milestone feature.

@mcmasterathl  Sounds good. I think someone else started work on this, and was taking the approach of just taking a list of opaque challenge strings. So it just leaves the formatting of each challenge to the caller. This is probably OK for 0.3, but we may want to do something more sophisticated (as recommended above) for 0.4 or 0.5.
Let's see if a PR comes in for this and then we may want to create an additional issue to look at doing more, as previously mentioned.

hey Kurt, i will try and send a PR by today. After that you can let me know if you need anymore changes on that.


Including Waypoints in Webpack config

config = {
entry: {
vendor: [
"jquery",
"waypoints",
"picturefill",
"babel-polyfill"
]
},
plugins: [
new webpack.ProvidePlugin({
$: "jquery",
waypoints: "waypoints"
})
]
}
I am getting "Module not found: Error: Cannot resolve module 'waypoints'"
How to get Waypoints in the vendor file?

The underlying problem here is being discussed over at #458.
As a workaround, I'm doing this to import waypoints in webpack: require('waypoints/lib/jquery.waypoints.js');
I'm new to webpack but I think your example will work if you add this to the config file:
  resolve: {
    alias: {
      'waypoints': 'waypoints/lib/jquery.waypoints.js'
    }
  }

If you want to import a shortcut you have to do this instead:
resolve: {
    alias: {
      'waypoints': 'waypoints/lib'
    }
  }

Then you can import the shortcut or any other script for that mater like this:
require("waypoints/lib/jquery.waypoints.js");
require("waypoints/lib/shortcuts/sticky.js");

As a workaround until this is fully supported :)

So when will this actually get fully supported? It is a shame I have to deal with this by mess workarounds. Makes me want to stop using this.


Add a simple instrumentation framework to Jardin

This PR adds a simple pub/sub instrumentation framework to Jardin.
The ideal use case is for applications to consume events and emit metrics/APM traces as necessary.

I now bundle exception information with connection_banned and query_retry events. Fixed some linting issues, used locks in event fanout, added a null notifier class and placed the class selection logic in config.py and added EventTiming and EventExceptionInformation classes to Event object.


CI: Use jruby-<IP_ADDRESS>

This PR updates the CI matrix to use latest JRuby, <IP_ADDRESS>.
JRuby <IP_ADDRESS> release blog post

Thank you!


Don't use cached timescale for embedded captions when timescale can be parsed from the media segment

Have you read the FAQ and checked for duplicate open issues?
Yes
What version of Shaka Player are you using?
3.1.0
Can you reproduce the issue with our latest release version?
Yes
Can you reproduce the issue with the latest code from master?
Yes
Are you using the demo app or your own custom app?
Custom
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
Chrome + Mac OS
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
What configuration are you using?  What is the output of player.getConfiguration()?
N/A
What did you do?
Play a stream with embedded CEA608 captions and try to display those captions
What did you expect to happen?
Captions are aligned with the media and display correctly
What actually happened?
I'll preface by stating I'm not actually 100% sure this is a bug.
Shaka caches timescales for closed captions by parsing the timescale and track ID from init segments:
https://github.com/google/shaka-player/blob/c993fca5793200a7d4ba556d6ef150db52365f68/lib/cea/mp4_cea_parser.js#L73-L89
This is creating issues with our content where the media segments don't seem to contain matching track IDs, so the cached timescale values are never used:
https://github.com/google/shaka-player/blob/c993fca5793200a7d4ba556d6ef150db52365f68/lib/cea/mp4_cea_parser.js#L159-L164
As a result, cue times are off by several orders of magnitude. However, this content has segment index (SIDX) boxes which contain the timescale metadata. It seems it would be preferable to use the timescale from the media segment, if available, and fallback to the cached value only if needed, e.g.
  .fullBox('sidx', (box) => {
    goog.asserts.assert(
      box.version != null,
      'SIDX is a full box and should have a valid version.');

    box.reader.skip(4)
    sidxTimescale = box.reader.readUint32();
  })

  .fullBox('tfhd', (box) => {
    goog.asserts.assert(
        box.flags != null,
        'TFHD is a full box and should have valid flags.');

    const parsedTFHD = shaka.util.Mp4BoxParsers.parseTFHD(
        box.reader, box.flags);

    // If specified, defaultSampleDuration and defaultSampleSize
    // override the ones specified in the TREX box
    defaultSampleDuration = parsedTFHD.defaultSampleDuration
      || this.defaultSampleDuration_;

    defaultSampleSize = parsedTFHD.defaultSampleSize
      || this.defaultSampleSize_;

    const trackId = parsedTFHD.trackId;
    // Get the timescale from the track Id
    const cachedTimescale = this.trackIdToTimescale_.get(trackId);
    timescale = sidxTimescale || cachedTimescale || timescale;
  })

This would be technically bad content.  The timescale in the sidx box is only valid for the values in the sidx box.  It is recommended that this match the media timescale, but it doesn't have to.  Each track in the media must have an associated track header.
We can keep this as a low-priority enhancement, but you should fix your content.

@TheModMaker Thanks for the feedback, I will bring this up with our content team. Feel free to close this if you feel it is not a worthwhile enhancement.


logger: add %j and %_ support for fine-grain logger

%j and %_ are the Envoy custom formatter added by #15226. Fine-grain logger is only using the default format pattern from spd::log. This PR makes the default and fine-grain logger consistent.
Issue: #22914
Commit Message:
Additional Description:
Risk Level: Low
Testing: bazel-bin/source/exe/envoy-static --log-format %j --enable-fine-grain-logging
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

/assign @KBaichoo

/retest

/retest

/wait

Can we get this merged? Thank you!


Add better distinction between different subjects in a verification grid

During user testing, it was not immediately apparent to users that after the grid auto-paged that they were viewing a different audio file.
We should therefore add some information on each subject that will uniquely identify it (e.g. an index number).
By adding a distinct (incrementing) number to each tile should help the users understand that they are viewing a new subject tile after auto-paging.

Raven Pro's review interface does number spectrogram tiles with indices. I don't think that's a great solution though.
I think generally we need a progress bar... probably above or below the decision row. Maybe with page count / viewed count inline somewhere.


Sound Synthesis with Web Audio

level: interesting for beginners and experts
language: English or Spanish, depending on the audience preference
twitter: @lcrespom
tags:

WebAudio
SoundSynthesis
HTML5

Computers have always been a great tool for creating music. Until recently, the web platform was limited to playing back recorded sounds, but the Web Audio API provides very powerful and versatile sound synthesis capabilities.
In this talk I will give an introduction to computer sound synthesis, present the Web Audio API, perform some live coding, and demo a complete graphical synthesizer created with Web Audio.

Does this mean accepted or rejected?

I think it should not be close .... And would be good if you can there on January 13

I @PatrickHeneise is playing with git-events and mistakenly closed this

I'm not playing and it's not a mistake. It's in barcelonajs/speakers now.

Oh, I just noticed it is the old issue, sorry


publish a 1.5?

lots of updates! would love to have them available on pip :)

Yeah man, of course. But if you are worrying about possible crashes, maybe it's time to pre version this people could test it for some time, and then move to release?

Isn't that what version pinning is for?

I don't have much time to maintain this or do releases, but I am all about adding new collaborators.


Bezier curve: extension of the termination condition in bezLength()

Added a condition that prevents bezLength() function
from making infinite number of calls.

Description :
Plotting a curve with a dashed stroke in some cases crashed. This is because the condition for the termination of the bezLength() function was never satisfied. There was still a discrepancy , which was greater than

The difference between the length of two approximations of the Bezier curve:

the straight line from the start to the end point
and
the length calculated as a sum of three lines (start-ctrl1, ctrl1-ctrl2 and ctrl2-end)
was > FLT_EPSILON.

In such a case, the algorithm splits the curve into two smaller ones, but because of the finite density of floats, the calculation of of the points of the new Bezier curves ended with one of them being exactly same as the other (or the initial one).

Issue Tickets (if any) :

Tests or Samples (if any) :
An example that is crashing without this correction: BezierLength.cpp
The example is available here:
https://github.com/mgrudzinska/thorvg/tree/mgrudzinska/BezLength_ex_segf

Screen Shots (if any) :

@mgrudzinska How about redefine FLT_EPSION values?
i.e) #define BEZIER_EPSION 0.00001f
then use it in bezier functions.


when 2 vscode instance are open getting error "The connection to the terminal's pty host process is unresponsive, the terminals may stop working"

Issue Type: Bug
Hi,
I am using insiders build and have 2 workspaces ( 1 angular and other react), after a most recent update (24 Feb 2021, 10:20 IST) I am getting the mentioned error when I open the 2 projects in separate instances.

 We did a lot of fixes around this yesterday.

@Tyriar , after the latest install i am not able to replicate the issue. i would like to observe this at least today and tomorrow if its okay with you.

I'll close it for now as I believe it's fixed. Let us know if you see it again

@Tyriar, I'm getting the same error on
Version: 1.54.0-insider (user setup)
Commit: e590188f17162393f50feec19263398e6fe02d13
Date: 2021-02-26T20:39:10.253Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

Same here:
Version: 1.54.0-insider (user setup)
Commit: 42e27fe5cdc58539dad9867970326a297eb8cacf
Date: 2021-03-02T19:09:10.315Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.17134

@vladi-strilets @donvanone did you only see this happen when closing a window? You may be seeing this: https://github.com/microsoft/vscode/issues/117956

@Tyriar   I'm getting the same error on
I am developing a vscode extension program and need to use the terminal to start another exe process. When I execute the restart, it will execute vscode.commands.executeCommand("workbench.action.terminal.kill") and vscode.window.createTerminal({}), the above error will appear.
However, when I manually close the exe program and then execute vscode.window.createTerminal({}), there is no problem.

@Tyriar, the error occurs as soon as I open the terminal, it goes blank (I can't even see the start line with my current project path).
I had to install the normal Visual Studio Code (not Insiders) and with the same extensions, it works fine.

Same thing on MacOS too:
Version: 1.54.1
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:42:18.719Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0

I'm also getting the same error.
I set up VS Code yesterday, installed it and I created a project without any issue. I closed my laptop and went home. Today that I wanted to continue working on the project, I'm getting the same error as my peers above.

Version: 1.54.1 (user setup)
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:38:31.719Z (15 hours ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.18363

Moving these to the recovery milestone which should mitigate the majority of these problems:

https://github.com/microsoft/vscode/issues/117990
https://github.com/microsoft/vscode/issues/117956

I have encountered the same "disconnection" problem soon after Visual Studio finished to update today.
Version: 1.54.1 (user setup)
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:38:31.419Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19042

@Tyriar, I just opened a new empty folder and got this issue again.

I have the latest VSCode insiders build installed.
UPDATE: I restarted the VSCode instance in the same folder and the issue did not appear again for the same folder however, I am able to reproduce the issue every time I follow the below steps

select the "Open Folder" option from the menu
create a new folder in the file chooser and name it something (ex: foo)
select the newly created folder and open it.
a popup "The connection to the terminal's pty host process is unresponsive, the terminals may stop working." appears every time.

It seems fixed in latest insider version:
Version: 1.55.0-insider (Universal)
Commit: 5d80c30e5b6ce8b2f5336ed55ad043490b0b818f
Date: 2021-03-08T05:24:34.127Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0

I was able to reproduce it with the version before that one. Now after the update it's running for few hours without seeing the error and the terminal is responsive.

Version: 1.54.0
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:42:18.719Z (6 days ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0
Same issue when having 2 VS Code windows open

I get this error several times an hour at which point I have to open a new terminal to get anything done.  Truly broken.
Version: 1.54.1
Commit: f30a9b73e8ffc278e71575118b6bf568f04587c8
Date: 2021-03-04T22:42:18.719Z (1 wk ago)
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0

I'm getting this same error on my Windows

Please update to 1.54.2

Same happens on 1.54.2 for me. I updated manually because this is bugging me immensely.
Version: 1.54.2 (system setup)
Commit: fd6f3bce6709b121a895d042d343d71f317d74e7
Date: 2021-03-11T00:56:19.848Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

Same error on 1.54.2 for me too
Version: 1.54.2 (user setup)
Commit: fd6f3bce6709b121a895d042d343d71f317d74e7
Date: 2021-03-11T00:56:19.848Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.18363

I would suggest to update to latest version:
Version: 1.54.2
Commit: fd6f3bce6709b121a895d042d343d71f317d74e7
Date: 2021-03-11T00:56:09.783Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0

At least on a Mac I've been running it for more than 24 hours without having any issues with my terminals or seeing the error message. It's working great.

The problem is easily reproduceable on my machine.
In my case I am working on an electron - angular application and am running the electron app as an npm task.
Version: 1.54.2 (system setup)
Commit: fd6f3bce6709b121a895d042d343d71f317d74e7
Date: 2021-03-11T00:56:19.848Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19041

Start a long running task defined in your package.json using Terminal > Run Task > select the long running task
Do this another time. A popup will ask you to restart the task: click restart
The task starts running but the original running task is never terminated
A bit later you'll get the notification: "The connection to the terminal's pty host process is unresponsive, the terminals may stop working."

@zinderic any more info on a repro would be helpful. Also if you could try out insiders the situation might be better there.

Do this another time. A popup will ask you to restart the task: click restart

@depeter this was an issue before though, it caused all VS Code windows to hang because of https://github.com/microsoft/vscode/issues/71966. The pty host situation improved that by only breaking the terminals (in all windows) with an option to restart and recover. That's the only known valid reason for the popup.

I'm running MacOS Big Sur and I see a significant improvement with version 1.54.2. Before that version the issue was happening pretty much all the time especially when I run long lasting processes in the terminal such as docker-compose or code compilation.
Currently the only way I am able to reproduce the problem is by starting my Time Machine backup. I had to stop it from running automatically because I noticed that it was somehow triggering the problem. Now I'm running it manually on the evening when I close VS Code and that's how I workaround the problem.
I just updated my insider version to this one:
Version: 1.55.0-insider (Universal)
Commit: 84fe402d655e029eb1a5c04e675bf64788fa7fcf
Date: 2021-03-15T08:13:06.179Z
Electron: 11.3.0
Chrome: 87.0.4280.141
Node.js: 12.18.3
V8: <IP_ADDRESS>-electron.0
OS: Darwin x64 20.3.0

I started the backup and the problem did reproduce on both - the insider and the normal versions. They were both running at the time.

@zinderic for macOS 1.54.2 brought in changes to recover when the pty host was unresponsive for some reason (waking from suspend or something) but has since recovered which I'm guessing was the main improvement for you. Interesting that the backup mechanism interacts with this, created https://github.com/microsoft/vscode/issues/119090. I'm interested if it recovers and the notification goes away after a minute or it's just totally broken and you can't create new terminals anymore after that.

Totally broken I'm afraid - frozen terminal with no way of creating new ones. Let me do some more testing and I'll update https://github.com/microsoft/vscode/issues/119090 with my findings.

The nodejs version might play a role in this. I've downgraded from latest (15.11.0) to 14.16.0 and these 'pty host problems' seems to have gone away.

Issue is still present in 1.54.3 (user setup) on Windows_NT x64

Hi guys,
issue still present in:
Version: 1.54.3 Commit: 2b9aebd5354a3629c3aba0a5f5df49f43d6689f8 Date: 2021-03-15T11:57:12.728Z (6 days ago) Electron: 11.3.0 Chrome: 87.0.4280.141 Node.js: 12.18.3 V8: <IP_ADDRESS>-electron.0 OS: Darwin x64 19.6.0
when 1 or 2 (or more) vscode instances are opened.
Catalina (not upgrading to Big Sure yet).

I'm getting this issue in 1.54.3

@Tyriar i started getting this again.

@sanket-bhalerao some improvements have been made in Insiders for the following version if you want to try that out https://code.visualstudio.com/insiders, it's expected that this will still happen when a Time Machine backup is triggered on mac (https://github.com/microsoft/vscode/issues/119090) or when you trigger the hang on Windows by closing a terminal that was having data written (https://github.com/microsoft/vscode/issues/71966).
If anyone sees this again on v1.55+ outside of the above cases, please create a new issue.


Command to download stemcell has incorrect SHA in cases where a light stemcell exists

In the cases where there is a light stemcell you seem to be using the sha1 for it instead of the one for the full stemcell.  It seems to be the case for AWS, GCP.  I'm not a go person, but I believe it's somewhere around here https://github.com/bosh-io/web/blob/master/templates/stemcells/single.tmpl#L14

By default, those bosh.io/d/stemcells/... links redirect to the light stemcells, so the listed checksum should be correct.
I manually tried downloading from those links and verifying the --sha1 checksum and it matched. Are you seeing a particular error somewhere?

We were getting an error.  But I can't reproduce it now.


[DO NOT MERGE] - BEAM 14350 Tests

[DO NOT MERGE]
Triggering PerformanceTests for BEAM 14350
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Run Java AvroIO Performance Test

Run Java AvroIO Performance Test HDFS

Run Java MongoDBIO Performance Test

Run Java ParquetIO Performance Test

Run Java ParquetIO Performance Test

Run Java ParquetIO Performance Test HDFS

Performance Tests with issue cp: cannot stat '/home/jenkins/.kube/config': No such file or directory are passing now after the merge of PR#17396.
Thanks


Problems with imports

Hello, I am trying to create a Kotlin class based on the swift library facebook-sdk-ios to be able to use one of the native functions  of the Facebook SDK.
I installed the package on XCode using the SwiftPackageManager following this instructions.
I followed the steps on the Readme of your plugin and I create inside native/Facebook a file Facebook.swift that looks like:
import FacebookCore
import Foundation

@objc public class FacebookSdk : NSObject {
    @objc public class func getAccessToken() -> String {
        return AccessToken.current
    }
}

However, when I try to build, it appears an error in the console saying:
error: no such module 'FacebookCore'
import FacebookCore
       ^

Is there a way to make the libraries to be imported correctly? Is it even possible to get what I need using your plugin? I don't actually know if this is in the scope of the plugin or I need to find another solution.
Thank you in advance!

@enoler i have been coming across the same issue of imports.I am trying to use Alamofire library through cocoapods but getting the same issue of 'no such module Alamofire' for import 'Alamofire'.Have you found any solution for this problem ?

@enoler i have been coming across the same issue of imports.I am trying to use Alamofire library through cocoapods but getting the same issue of 'no such module Alamofire' for import 'Alamofire'.Have you found any solution for this problem ?

Sadly I did not manage to fix it. If you finally get it, please post it here.

@enoler have you got any other plugin or library to overcome this problem.

@enoler have you got any other plugin or library to overcome this problem ?

No, I did not, actually I postponed the problem to wait for an answer using this plugin

@hatteajay1212 I just saw in the comments of this link that is not supported yet but the creator of the plugin is thinking about adding it.
@ttypic Thanks for your work and looking forward for it, honestly if you get how to do it it will be a life changer in the KMM ecosystem.

@enoler, @hatteajay1212 thank you very much for using the plugin! Right now I don't have enough time to improve this behavior. I hope to come back to this in a month or so. But any help will be very much appreciated.

Hello @ttypic, I'd like to assist you, but I'm not familiar with how dependencies work for Swift . Could you recommend any resources or provide advice on where I can start learning about this topic?

Facing the same issue here, I was trying to use firebase analytics but apparently this is not possible 🙁

The plugin cant working with dependencies

Hi @ttypic, thanks for your hard work on this plugin. I'm also looking to add some sort of support for using a swift dependency with some glue code in swift to make Kotlin multiplatform libraries that don't require separate steps for swift dependencies and copy/pasting files.
I'm not super familiar with the apple build processes for these things, but I'm considering a simply dependency file that does a git checkout of swift package into the native folder and seeing how heavy that is or how it behaves at least. If there is another strategy you recommend based on your knowledge such as a way to make the plugin aware of the dependency and able to enforce that swift package manager adds it in the project using the library, it would be appreciated and I'll happily share the code in the end if it succeeds. Just want to end up on the right path so it is usable for all of us.

@codesplode to me what would make most sense is to be able to setup a swift package with it's own dependencies.
i.e:
let package = Package(
    name: "YourPackageName",
    dependencies: [
        .package(url: "https://github.com/facebook/facebook-ios-sdk.git", .upToNextMajor(from: "VersionNumber"))
    ],
    targets: [
        .target(
            name: "YourPackageName",
            dependencies: ["FacebookCore"]),

which can easily be built to a binary using:
swift build

@ttypic I had wondered about creating a new issue relation to this possible feature, but keen to hear your thoughts?

@ttypic actually taking a real superficial look at the way the plugin works, it seems that createPackageSwift actually creates and compiles the package in order to link? Seem it could be a really simple change in approach to expect the Package.swift to be defined as part of the plugin usage rather than CompileSwiftTask generating.

If you want that, currently, I think an approach like this is needed https://github.com/KodeinKoders/playground-SwiftLib-in-KMMLib


Print Cycle and Seasonal Details in the logs

The default log does not contain this info.
The user should be able to compute the forecast by hand based on the logs.
JSON outputs also should be complete.

Closing


500 Internal Server Error

I got past that hurdle, but cannot recall how, being new to Docker.  But 2 new questions. Please clarify your post install tips (regarding visiting http generator) not sure what you mean. I can run the docker image and connect with a browser and have logged in. But when trying to add a recipe, I get a 500 Internal Server Error.  I created the db successfully using a docker volume. Please see my log files:
groceries-log.txt