Load SQLite instrumentation only when build tag present

I forgot to prevent the SQLite driver from loading when the sqlite tag is missing in instrumentation. This patch resolves that! Sorry about the oversight. I added tests so this doesn't happen again.

Thank you for the quick review!


Error Executing Starlark Code: zkevm-bridge-service-001 Fails to Start

I'm getting the following error while executing this command "kurtosis run --enclave cdk ."
When attempting to add a service with the name zkevm-bridge-service-001 using the hermeznetwork/zkevm-bridge-service:v0.6.0-RC2 image, the deployment fails with the following errors.

Originally posted by @Shahnawazkhan83 in https://github.com/0xPolygon/kurtosis-cdk/issues/408#issuecomment-2513020875

Hi @Shahnawazkhan83, I would need more context to understand what's going on.

Which version of kurtosis-cdk are you using?
Have you made any changes to the code? Especially to input_parser.star?

Hi @leovct,
I’m using Kurtosis-CDK v0.2.24 (Latest).
Changes I’ve made to input_parser.star:

Updated DEFAULT_DEPLOYMENT_STAGES:

"deploy_l1": True → "deploy_l1": False.

Updated DEFAULT_ACCOUNTS:

Modified addresses and private keys of different components.

Updated DEFAULT_L1_ARGS:

"l1_chain_id": 271828 → "l1_chain_id": 17000.
"l1_preallocated_mnemonic" → Changed to a new mnemonic.
"l1_rpc_url" and "l1_ws_url" → Updated to Holesky Testnet RPC and WS URLs from Alchemy.
"l1_funding_amount": "1000000ether" → "l1_funding_amount": "2ether".

Also I have edited node-config.toml file at /kurtosis-cdk/templates/trusted-node/node-config.toml:

BatchMaxDeltaTimestamp = "5s" → "2m".
LastBatchVirtualizationTimeMaxWaitPeriod = "5s" → "15m".
MaxBatchesForL1 = 10 → 15.

System Information:

OS: macOS Sequoia 15.1.1
Processor: M2 Chip (ARM64)

Ok that make more sense. Can you take a look at the rpc and sequencer logs, you should see some errors there.

any update on the above issue @leovct
I believe the guide needs to be updated as I followed the same throwing out error for me on sepolia. Same timeout issue
I am changing the params in input_parser.star


Bug: NewResponder should not have to listen on all interfaces

I am running this library as a server and noticed that even though I only included one interface in the dnssd.Config, I was seeing IGMP messages on both interfaces.  This was confirmed running -Verbose flag in the cmd/register:
# register -Name "TSTService" -Type "_tst._tcp" -Port 9876 -Interface eth1 -Verbose
18:09:36.417    ...STARTING...
DEBUG 2024/05/13 18:09:36.432281 mdns.go:183: Joined IPv4 eth1
DEBUG 2024/05/13 18:09:36.434637 mdns.go:183: Joined IPv4 wwan0
DEBUG 2024/05/13 18:09:36.446972 mdns.go:204: Joined IPv6 eth1
DEBUG 2024/05/13 18:09:36.449525 mdns.go:204: Joined IPv6 wwan0

Not sure if the interfaces listed in dnssd.Config should be the only interfaces listened on, but there should at least be a way to limited the interfaces being used.

Thanks for bringing up this issue.
This is now fixed by 91c1c03


getting the commit message when necessary for repository commits

Closing The issue https://github.com/arabold/aws-to-slack/issues/51
When I try to run it on the actual lambda server I get

TypeError: parser.parse(...).then is not a function
at BbPromise.any._.map.Parser (/var/task/src/index.js:34:4)

and I have absolutely no idea why. My promise handling should be ok. Is there something specific to Lambda AWS as far as promises are concerned ?
Happy for someone to have a look and opine.
Once this one works I'll do the same for the pullrequests parser.

Rather than relying on reftype === branch, perhaps just get the commitId from the event. If present, use that to get the commit message. If absent, skip.

https://docs.aws.amazon.com/AmazonCloudWatch/latest/events/EventTypes.html#codecommit_event_type

{
      "version": "0",
      "id": "01234567-0123-0123-0123-012345678901",
      "detail-type": "CodeCommit Repository State Change",
      "source": "aws.codecommit",
      "account": "123456789012",
      "time": "2017-06-12T10:23:43Z",
      "region": "us-east-1",
      "resources": [
        "arn:aws:codecommit:us-east-1:123456789012:myRepo"
      ],
      "detail": {
        "event": "referenceCreated",
        "repositoryName": "myRepo",
        "repositoryId": "12345678-1234-5678-abcd-12345678abcd",
        "referenceType": "tag",
        "referenceName": "myTag",
        "referenceFullName": "refs/tags/myTag",
        "commitId": "3e5983EXAMPLE"
      }
 }

Thank you for the PR @elChapoSing!  I've pushed a new commit to your branch that uses the async/await pattern and fixes ESLint issues.  Let me know what you think.
Regarding the BdPromise error... Unfortunately, only arabold has access to the S3 buckets to update the CloudFormation-referenced zip files.  So everytime a new CloudFormation stack is released, it's deploying code based on an older version.
I recommend re-deploying the code from your local aws-to-slack folder to fix this.
AWS_REGION=your-region LAMBDA_NAME=your-lambda make deploy

Also, one day soon we may merge an additional upgrade from my fork.  I put a warning in the Readme to hopefully avoid these problems.  The fork simplifies parsers even more by separating event-matching from response-generation.

That update looks great @homeyjd! I was worried about the lambda not having permissions to make the new API calls, and the failure getting swallowed, so happy to see them logged!

@homeyjd thank you sir ! Fits the style of the app much better than my own piece of code. Now on to @arabold to allow merging. Will add the pullrequests parser following @homeyjd example style as well.

Happy to merge :).
If you get a chance to add tests for codecommit and pullrequests in your PR that'd be awesome!
Thanks, @elChapoSing!

am unfortunately not sure how to add tests. In which file can I see how the other tests were constructed ?

ok it's in the test folder. duh.


Some changes

Add support for proxy
Add gist list command
Update keymaps and sublime-menu

You need to extract resuest to api from create_gist, get_gist and get_gists to a seperate method to avoid code repeating several times.

I recommend you to pull my changes, because your code have bug with empty file description (it is not "None", but empty).


⚠ Bofrost.lu has degraded performance

In 7425b13, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 1397 ms

Resolved: Bofrost.lu performance has improved in 5c92938 after 6 minutes.


Fix file mode

fix: change mode of python files to run.

Not necessarily, but maybe better. Thank you, I will merge it.

Not necessarily, but maybe better. Thank you, I will merge it.


Powershell doesn't work with intellij

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Try to run intellij, the terminal won't work "Cannot open Local Terminal
Failed to start [powershell.exe] in C:\Users\username\IdeaProjects\UserLogger
Error running process: CreateProcess failed. Code 2
See IDE log (Help | Show Log in Explorer) for the details."
Expected behavior
The terminal is supposed to work

Actual behavior
Don't have a picture but the terminal is supposed to open and work

Error details
Get-Error : The term 'Get-Error' is not recognized as the name of a cmdlet, function, script file, or
operable program. Check the spelling of the name, or if a path was included, verify that the path is
correct and try again.
At line:1 char:1
+ Get-Error
+ ~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (Get-Error:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Environment data
Name                           Value
----                           -----
PSVersion                      5.1.22000.65
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.22000.65
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

Visuals

The repository is only for PowerShell 7+. Can you reproduce the issue with latest PS7 Preview? For Windows PowerShell please use Windows Feedback tool.

This is an issue you should raise with Jetbrains the team behind IntelliJ which already has a very similar issue in thier bug tracker at https://youtrack.jetbrains.com/issue/IDEA-278224


⚠ Bofrost.es has degraded performance

In d149c0e, Bofrost.es (https://www.bofrost.es) experienced degraded performance:

HTTP code: 200
Response time: 1511 ms

Resolved: Bofrost.es performance has improved in 7140b42 after 6 minutes.


More events

Hello, thanks for letting us using pannellum. It has been great in the time I've been working on it. I was wondering if I could listen to other events that are not listed in the API. At the moment I'm using mousedown to trigger some functionality when the user clicks in the panorama but when you are on mobile there is no event to listen to in case the user touches the screen. I tried to add a touchstart listener to the dom but I cant get the pitch and yaw from this event. Any ideas or advice? Thanks

I just added touchstart and touchend events in 1e61a22be633a5c297fceaa89fd81b969977a097.
To convert a TouchEvent to pitch and yaw, you'll need to get a Touch object from the TouchEvent's targetTouches property. A TouchEvent, like a MouseEvent event, can be passed to Pannellum's mouseEventToCoords function to convert it to pitch and yaw.

jeje well that was quick. Thanks. I hope that in some point I can contribute to this project. Ill close this issue


[WIP] Expand on #183: Extract network and compressedness from key types

This is an attempt to alter https://github.com/rust-bitcoin/rust-bitcoin/pull/183 to take the network and compressedness properties out of the key types. This effectively creates Bitcoin-util wrappers around the secp256k1 types, which I think is fine.
It defers the network/compressedness decision all the way until an address is actually created and where it has any influence.

I'm not sure why compressedness is in a PublicKey and not in a PrivateKey.

Yeah I gave up messing with this yesterday :sweat_smile: I guess if you just take network out of PrivateKey, you're where I would end up. Closing this.


Raindrop implementation questions

Issue description
Hi all, and thanks for such a great package!
I'm currently working on the raindrop architecture, and I have a couple of questions regarding your implementation of the message passing algorithm included here:

The first is where is the message_selfattention method (implementing as far as I can read the attention mechanism described in the paper) used in the code. I tried inspecting it in detail, but I couldn't find any calls to it, or methods with that name in the underlying MessagePassing class from pyg.

The second relates to the L2 regularization parameter on the distances between the graphs. It seems that the computation of the distance is commented out in the file (lines 221, 222). Is the regulariser used and called elsewhere? Or was it removed in later iterations of the model?

Best, and thank you very much once again!
Lucas

Hi there 👋,
Thank you so much for your attention to PyPOTS! You can follow me on GitHub to receive the latest news of PyPOTS. If you find PyPOTS helpful to your work, please star⭐ this repository. Your star is your recognition, which can help more people notice PyPOTS and grow PyPOTS community. It matters and is definitely a kind of contribution to the community.
I have received your message and will respond ASAP. Thank you for your patience! 😃
Best,
Wenjie

Hi Lucas, thanks for raising this discussion.
We make code logic the same as the official implementation https://github.com/mims-harvard/Raindrop. Yes, some objects and functions don't get used in the model processing procedure. They are kept here in case the official repo gets updated.

Hey, thank you for your answer! I'll try to reach out to the original authors, then :)
Best,
Lucas

Lucas has opened an issue in the Raindrop official repo https://github.com/mims-harvard/Raindrop/issues/11.
I'm closing this issue for now. If there is any further related problem that should be fixed in PyPOTS, reopening will be welcome.


Applying erased_serde::deserialize twice to same Deseralizer

tl; dr;
I'm confused by the &mut in erased_serde::deserialize.
May one use the deserializer afterwards?
Here is some code which panics:
#[derive(Debug, serde::Serialize, serde::Deserialize)]
struct D1 {}
#[derive(Debug, serde::Serialize, serde::Deserialize)]
struct D2 {}
trait T {}
impl T for D1 {}
impl T for D2 {}

use erased_serde::Deserializer;

fn main() {
    let d1 = D1 {};
    dbg!(&d1);
    let serialized = serde_json::to_string(&d1).unwrap();
    let mut deserializer = serde_json::Deserializer::from_str(&serialized);
    let mut deserializer = Deserializer::erase(&mut deserializer);
    dbg!(&erased_serde::deserialize::<D1>(&mut deserializer));
    dbg!(&erased_serde::deserialize::<D2>(&mut deserializer));
    dbg!(&erased_serde::deserialize::<D1>(&mut deserializer));
    dbg!(&serialized);
}

Hi,
this is my first github issue, and this is more of a question.
here is some (unrelated) motivation.
I'm trying to write a plugin-system, and at the moment I'm checking if erased-serde can help.
To this end I'm runtime-loading some shared libraries, and from each I get a type implementing a shared trait.
Now I want to add a function to each library, which tries to deserialize the serialized trait into the libraries type.
Then, in the main executable, I wanted to iterate over my library-functions, feeding the same deseralizer into them.
Hence the example above.
Thank you,
Michael

Hi Michael, sorry that no one was able to provide guidance here. If this is still an issue, you could try taking this question to any of the resources shown in https://www.rust-lang.org/community.


Make autocomplete more flexible

At the moment, the autocomplete requires APIS_ENTITIES to contain a search key for every configured model. That is cumbersome to configure. It would be great if there was a default (maybe something like APIS_ENTITIES["__default__"]?) as a fallback, if that is not configured.

This has been fixed in 5ccc0a24


[feature request] server auto-start on join

Make it so when a person joins the proxy (fx. One that’s always running) it automatically starts a specified server. So you could have a proxy witch is always running and then have a backend server that only starts when people actually want to join them.

Why don't you just let the proxy go offline?
You can automatically let it start when someone tries to join, and it can then also start your backend servers using the plugin.

Yes, but what if you have people online on one back end and none on some others, then there's no reason to run the others. But let's say that the people online want to go to survival, and it's offline, it would be cool if it then started when you join. It would save so much credit.

You can already use the /exaroton start command to start the survival server in that case

Yes, but that would require user knowledge and permission or you would need an admin only 24/7

I'm not sure how switching to a different server requires less knowledge than starting a server and then switching to it.
You can also only give the start permission specifically.

Well, okay yes, but that still requires the people playing to know the command.

The new switch command probably fits your idea


update the spec without affecting incoming metrics processing

when updating a spec through API, the input source will be unloaded first and then loaded again to take effect. this would cause incoming metrics fail to process between the unloading the loading process because of not found metric handler.

the solution is to (deep) compare if input source has been changed, if not, there's no need to unload the old one


Fix doc_markdown lints in bevy_app

#3457 adds the doc_markdown clippy lint, which checks doc comments to make sure code identifiers are escaped with backticks. This causes a lot of lint errors, so this is one of a number of PR's that will fix those lint errors one crate at a time.
This PR fixes lints in the bevy_app crate.

bors r+


Added VQC implementation in pennylane

Implemented Samuel's VQC in a more class based and user intuitive way. However, this is not hybrid. The training of the VQC is done after the training of the AE is complete, but on the latent space of the AE.

Hello @bb511! Thanks for opening this PR.

In the file vqc_pennylane/feature_maps.py:

Line 9:1: E302 expected 2 blank lines, found 1
Line 18:19: E226 missing whitespace around arithmetic operator
Line 22:19: E226 missing whitespace around arithmetic operator
Line 22:46: E226 missing whitespace around arithmetic operator

In the file vqc_pennylane/qdata.py:

Line 126:81: E501 line too long (85 > 80 characters)
Line 127:81: E501 line too long (85 > 80 characters)
Line 140:81: E501 line too long (87 > 80 characters)

In the file vqc_pennylane/train.py:

Line 8:1: F401 'numpy as np' imported but unused
Line 11:1: F401 '.terminal_colors.tcols' imported but unused
Line 15:1: F401 'pennylane.optimize.AdamOptimizer' imported but unused

In the file vqc_pennylane/util.py:

Line 4:1: F401 'warnings' imported but unused
Line 18:1: E302 expected 2 blank lines, found 1

In the file vqc_pennylane/variational_forms.py:

Line 5:1: F401 'numpy as np' imported but unused
Line 17:28: E203 whitespace before ':'
Line 17:38: E226 missing whitespace around arithmetic operator
Line 17:47: E226 missing whitespace around arithmetic operator
Line 17:50: E203 whitespace before ','
Line 26:1: E302 expected 2 blank lines, found 1
Line 37:34: E226 missing whitespace around arithmetic operator
Line 46:36: E226 missing whitespace around arithmetic operator
Line 48:1: E302 expected 2 blank lines, found 1
Line 53:31: E226 missing whitespace around arithmetic operator
Line 54:37: E226 missing whitespace around arithmetic operator
Line 56:1: E302 expected 2 blank lines, found 1

In the file vqc_pennylane/vqc.py:

Line 48:29: E226 missing whitespace around arithmetic operator
Line 71:37: E226 missing whitespace around arithmetic operator
Line 72:46: E226 missing whitespace around arithmetic operator
Line 113:26: E226 missing whitespace around arithmetic operator
Line 128:29: E226 missing whitespace around arithmetic operator
Line 137:26: E701 multiple statements on one line (colon)
Line 140:19: E203 whitespace before ':'
Line 140:28: E203 whitespace before ':'
Line 169:43: E226 missing whitespace around arithmetic operator
Line 172:28: W504 line break after binary operator
Line 256:81: E501 line too long (88 > 80 characters)
Line 265:81: E501 line too long (87 > 80 characters)
Line 267:81: E501 line too long (84 > 80 characters)
Line 286:81: E501 line too long (85 > 80 characters)
Line 298:33: W504 line break after binary operator
Line 299:58: W504 line break after binary operator


Gulp Watch Issue

Process:

Clone the repo (ES2016)
npm install
jspm install -y
gulp watch
Navigate to http://localhost:9000/

Issue:
GET http://localhost:9000/dist/aurelia-2560ab1f9a.js 404 (Not Found)
Uncaught (in promise) Error: XHR error (404 Not Found) loading http://localhost:9000/dist/aurelia-2560ab1f9a.js(…)
Seems like the gulp watch task doesnt actually bundle the app but only builds it. If I add 'bundle' as a task dependency to the serve task it works as intended.
Am I doing something wrong?

Gulp watch doesn't bundle - and you don't want it to.  You can read this blog for more details by Matthew James Davis:  http://davismj.me/blog/aurelia-bundling/  There is also an Aurelia Doc http://aurelia.io/docs#/aurelia/framework/1.0.0-beta.1.1.1/doc/article/bundling-your-app-for-deploy

I understand that bundling isint meant for local development but thats just to get around the issue of the normal "gulp watch" command not working correctly. The watch task builds Aurelia but when I navigate to localhost:9000 I get the aurelia.js errors mentioned above.

If you've bundled, you then need to unbundle in order for gulp watch to work.  Matthew's article indicates how to add an unbundle task to gulp watch.  The bundle task actually re-writes config.js such that gulp watch won't work.  I really like Matthew's article as it (to me) presents best practice on developing with and without bundling.

Did you try downloading the release instead of cloning? I tried it from the release over and over again over the last few days so I know that works.

The JS file request does look like a bundled file name. So, try @wshayes advice.

Yeap that was my problem. Thanks!


Don't log sensitive user info in GLIDE code

Issue #, if available:
N/A
Description of changes:
Small clean up to avoid logging sensitive user data - requests and responses.
https://github.com/Bit-Quill/glide-for-redis/actions/runs/9134317535/job/25119609032?pr=288#step:7:385
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Added


Example Error

Hi, I'm trying to run your example and keep getting this error when running unrasterize.WindowedUnrasterizer(mask_width=10, threshold=0.2)
TypeError                                 Traceback (most recent call last)
<ipython-input-15-bba3c9db4ba5> in <module>()
----> 1 unrasterize.WindowedUnrasterizer(mask_width=10, threshold=0.2)

/Users/mattdaniels/anaconda2/lib/python2.7/site-packages/unrasterize/classes.pyc in __init__(self, mask_width, threshold)
    242         """Inititalize a WindowedUnrasterizer."""
    243         # TODO: Pass unrasterizer class as an argument, with settings determined by **kwargs.
--> 244         super().__init__()
    245         self.mask_width = mask_width
    246         self.mask = None

TypeError: super() takes at least 1 argument (0 given)

Any idea why this is resulting?

The behavior of super changed in Python 3.x (see PEP), meaning that this line will fail in Python 2.7.
I typically work in Python 3, so I haven't spent much time investigating backwards compatibility. It's definitely something worth looking into though! In the meantime, I suggest using a virtual environment with Python 3 installed to get around this error.


:sparkles: Introduce maxtasksperchild to increase stability

Long iterators would see some workers hang over time, essentially https://stackoverflow.com/q/45447947
This PR:

Introduces MAPPLY_MAX_TASKS_PER_CHILD env var, defaulting to 4.
Replaces dependency on pathos with lower level multiprocess.

Codecov Report
Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (df4dea1) compared to base (019ee26).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #29   +/-   ##
=========================================
  Coverage   100.00%   100.00%
=========================================
  Files            3         3
  Lines           80        77    -3
  Branches        13        12    -1
=========================================
- Hits            80        77    -3

Impacted Files
Coverage Δ

src/mapply/parallel.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Not displaying full text when increasing text size

When I increase my text size to 18sp it does not print the full text, text in truncated.
It shows the full height of the text, but it does not print it completely, it's like something is in front of the text on the bottom

@thiagotigaz
Could you provide your xml? Maybe your layout isn't correct


Update sbt-scalajs to 1.3.1

Updates org.scala-js:sbt-scalajs from 1.2.0 to 1.3.1.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "org.scala-js", artifactId = "sbt-scalajs" } ]

labels: sbt-plugin-update, semver-minor

Superseded by #50.

Superseded by #50.


Update Monix version to 2.1.1

Monix 2.1.1 have major performance improvements.

@golem131 could you fix the merge conflict? Thanks!

@fwbrasil merge conflict fixed


Adds a one-button-tracker widget

The 1button widget turns BTN1 into a simple event tracker that can be used from the clock face and from basically everywhere where widgets can run.
When pressed for at least 130 ms it will trigger the recording of when the button was pressed and when it was released, the timestamps of which are written into a CSV file that can be downloaded from the app loader.
Many members in the Quantified Self community are looking for simple ways of tracking events and this makes the Bangle a great device for doing this! 🙂

This is great - thank you!


calculate dpi on window update

this is fix of issue #6144.
It's not ideal solution, as fonts are 2x larger after moving window from retina to non-retina, or 2x smaller if moved window from non-retina to retina.
However, it's way better than it was before, so I think it's worth to apply.

There is also the issue of one having to manually resize the window to display the updated window.
Where as this should happen automatically, we should be listening to the selector for BackingScaleFactor on osx to update the window automatically, ref: https://stackoverflow.com/questions/11067066/mac-os-x-best-way-to-do-runtime-check-for-retina-display .

@matham @tito comment here https://github.com/kivy/kivy/issues/6144#issuecomment-475140897 it would make send to provide a density_dynamic kind of a new prop that user could listen to and update their own UI accordingly
let's keep this pr atomic, i.e not changing stuff like reify etc that would effect a lot of stuff, not just dpi etc.
We also should test things further in SDL2 as it currently manages moving from high density to low density without any issues. Only dpi-Fonts are wrong/double in that case. let's forget fonts and only focus on density we can talk about fonts/reify issue in another pr.
Need to check maybe this can be fixed in sdl2 itself? Considering High to Low works automatically... so should Low to High

This is related too; the Screen module would not  work cause of these issue on a retina screen as we try to change the density * dpi after the window has already been initialized.

I hadn't seen @tito 's comment. We can make this PR only add code to recompute window's dpi and leave Metrics for another PR. But I'm not really sure this PR would then solve anything, given that the dpi is cached in the two places I mentioned in my original comment.
But it is ok to be modular, and focus this PR only on Window. However, @tito did mention that this PR should make dpi more dynamic, which this PR doesn't solve as dpi is still not a kivy property.

There is also the issue of one having to manually resize the window to display the updated window.
Where as this should happen automatically, we should be listening to the selector for BackingScaleFactor on osx to update the window automatically, ref: https://stackoverflow.com/questions/11067066/mac-os-x-best-way-to-do-runtime-check-for-retina-display .

Dragging window from monitor to monitor is enough to update content (in my case ofc)

@matham @tito comment here #6144 (comment) it would make send to provide a density_dynamic kind of a new prop that user could listen to and update their own UI accordingly
let's keep this pr atomic, i.e not changing stuff like reify etc that would effect a lot of stuff, not just dpi etc.
We also should test things further in SDL2 as it currently manages moving from high density to low density without any issues. Only dpi-Fonts are wrong/double in that case. let's forget fonts and only focus on density we can talk about fonts/reify issue in another pr.

I second that. I think that this change should make kivy "not worse than it was before" :). Thus I think that resolving problem with scope of _get_gl_size should be enough for this ticket.
Unfortunately I have no monitors in nearest days, so I need to wait until I will be able to work on it again (Monday?)

As @akshayaurora said, this will likely break on other platforms that don't use sdl2 because self._win._get_gl_size is specific to sdl2 and doesn't exist on other platforms.

@tshirtman this does not really work right now,  it needs a architectural change.
Recalculation of DPI on every frame is also not a wise thing to do.
Currently with his change you only get the window.dpi and window.density value change.   The UI get’s changed to a invalid mix,  with the metrics.dpi still in the old value and thus the fonts and widgets still use old values.

@tshirtman this does not really work right now, it needs a architectural change.
Recalculation of DPI on every frame is also not a wise thing to do.

I don't think this recomputes on every frame, i only see it being recomputed on window resize (which would be triggered by the dpi change of the system.

Currently with his change you only get the window.dpi and window.density value change. The UI get’s changed to a invalid mix,
with the metrics.dpi still in the old value and thus the fonts and widgets still use old values.

Is it better or worse than the current result when dpi changes? Is it an acceptable stepping stone to a more complete solution later?

I can’t honestly count this as a stepping stone or a stop gap solution,  you see currently.  This is what happens.
If you start on a window with high res dpi you get this

Moving  to lowers dpi gives you this

This is with master. Issue in the second sshot is the metrics don’t change so ui is not adjusted.
Now going reverse from low dpi to high dpi
Starting on a low res display, you get this

Moving to a high res display you get this
<img width="796" alt="Screenshot 2020-06-25 at 10 34 52 PM" src="https://user-images.githubusercontent.com/788023/85765849-20852300-b734-11ea-98db-fab74967f282.png”>
With the change you should get something like

^ This result from my local branch with some similar testing
I guess you could call the last case a improvement.
Is it acceptable stepping stone? From what I understand of what needs to be done with change in reify and windows and linux support. I would say no.
I wanted to check when the update_viewport get’s called.  It’s quite often https://youtu.be/LD2lG_ZGNHE

https://github.com/kivy/kivy/pull/7293 adds support for dynamic dpi/density updating. However, that PR does not add the changes to Window to reload the DPI.
So something like this is needed to recalculate the dpi. However, it needs to be done properly, like @akshayaurora suggested above:

In light of this probably a better idea is to implement get_content_size abstract function in window.init and have it be overridden in specific implementations like window_sdl2 etc.
Even if SDL2 does not directly support DPI on windows yet, we could always call direct WINAPI's and OSX API with if platform == checks. We do not have to depend on sdl2 to implement this considering we also have other window providers too.

Just want to drop a workaround on Apple MacBook Air M1:
def dpupdate(self, *args):
    arg1 = args[0]
    return dp(arg1)*(1/kivy.metrics.Metrics.density)

The idea behind dpupdate is that you know dp returns a value that is offset by a fixed ratio (and you can optionally check if you're on a mac using from sys import platform / platform == "darwin" )... With a higher pixel density, you draw a smaller text font, with less pixel density, you draw a larger text font. I was going to find a "sweet spot" fixed number but I got lucky with what I initially wrote.
However, I don't think that's the case with what's happening. kivy.metrics.Metrics.density for the M1 is 2.0, whereas on my PC it is 1.0. I think I just got lucky that dividing by 2 gets me a consistently nice font size. I suspect that sdl2 is already adjusting for the retina display, so kivy is trying to adjust an already fixed issue and accidentally makes text twice as large. I tried using using screen module with -m screen:one, -m :screen:onex, -m screen:note2 and they all look fine BUT I'm not sure that's a good substitute for using the actual hardware.
Hope this helps out someone with Mac M1 font issues, cheers
with regular dp (too large):
https://github.com/kivy/kivy/assets/138998466/3c18268a-563d-4449-a081-17de2d1f4876
with dpupdate (just right):
https://github.com/kivy/kivy/assets/138998466/c6d122c3-fddc-4beb-97cf-551fa11407dc


Shortcuts to enable/disable individual PowerToys

Description of the new feature / enhancement
Add customizable shortcut keys to enable/disable individual PowerToys (FancyZones among other tools).
Provided an optional indication that the tool has been enabled/disabled.
Scenario when this would be used?
Turn on or off a tool without having to raise the GUI. Some PowerToys shortcuts or UI may conditionally conflict with or benefit user workflows. Turning a PowerToy on and off is cumbersome if it is a common occurrence.
Example: One may only want to enable "Awake" during a certain activity (e.g. presentation, test, important task that should not be interrupted), but off otherwise. If this happens a few times a day or week, it would benefit the user to be able to quickly enable Awake during those occurrences and letting the PC sleep other times.
This feature also has the benefit of allowing users to workaround bugs that are fixed by disabling and reenabling a tool without the GUI.
Supporting information
Note: FancyZones has an "Activation shortcut", but it raises the Layout Editor and does not toggle the tool.
Example: FancyZones can reset to the default zones when docking/undocking a laptop, connecting different (but previously connected) displays with multiple issues written over the lifetime of the tool. Simply disabling and reenabling FancyZones restores the proper zones.

Can now be done via the quick launch menu in systray in 0.67
I doubt we will have a global shortcut key for this exact feature

Can now be done via the quick launch menu in systray in 0.67
I suspect you are referring to Awake. My other example includes Fancy Zones which does not have this luxury. Well, that's too bad. :(


WIP: session_test: regression test for empty collections deserialization

ScyllaDB does not distinguish empty collections from nulls. That is, INSERTing an empty collection is equivalent to nullifying the corresponding column.
As pointed out in #1001, it's a nice QoL feature to be able to deserialize empty CQL collections to empty Rust collections instead of None::<RustCollection>. A test is added that checks that.
NOTICE
The test fails with the current deserialization framework implementation. It should work, however, once the new deserialization framework is introduced and the test is migrated to use it.
The goal of this PR at this point is to showcase what is the desired behaviour and remind that it has not yet been reached.
Pre-review checklist

[x] I have split my patch into logically separate commits.
[x] All commit messages clearly explain what they change and why.
[x] I added relevant tests for new features and bug fixes.
[ ] All commits compile, pass static checks and pass test.
[x] PR description sums up the changes and reasons why they should be introduced.
[ ] I have provided docstrings for the public items that I want to introduce.
[ ] I have adjusted the documentation in ./docs/source/.
[ ] I added appropriate Fixes: annotations to PR description.

Rebased on main.

Done in #1057.


[wip] fixing aave tests

Description
Managed to get them working locally, let's see what needs to be done in CI.
Is this PR related with an open issue?
Related to Issue #274
Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Follows the code style of this project.
[ ] Tests Cover Changes
[ ] Documentation

Funny gif

I might be easier to just call ganache like in the unit tests instead of calling --local-ganache-node. Not sure if that makes a difference. Also for the keeper version you can now use latest since contracts 2.0 where already merged

the develop branch is still up so feel free to merge this


Playbook fails: ansible <IP_ADDRESS> version ignoring bootstrap-os parameter for Ubuntu if it is set to "ubuntu" in inventory/group_vars/all.yml

Is this a BUG REPORT or FEATURE REQUEST? (choose one):
BUG

Environment:

Cloud provider or hardware configuration:

Happening across, Azure, Baremetal and OpenStack

OS (printf "$(uname -srm)\n$(cat /etc/os-release)\n"):

Ubuntu-16.04.1

Version of Ansible (ansible --version):
$ ansible --version
ansible <IP_ADDRESS>
config file = /Users/areddy5/kargo-azure-ubuntu/ansible.cfg
configured module search path = Default w/o overrides

Kargo version (commit) (git rev-parse --short HEAD):
git rev-parse --short HEAD
85a8a54
Network plugin used:
Copy of your inventory file:
Command used to invoke ansible:
ansible-playbook -i contrib/azurerm/inventory -e kube_network_plugin=calico -u devops --become -e<EMAIL_ADDRESS>cluster.yml
Output of ansible run:

Work around helped:
bootstrap_os: Ubuntu in ~/kargo/inventory/group_vars/all.yml
Valid bootstrap options (required): ubuntu, coreos, centos, none
bootstrap_os: Ubuntu

I don't follow, what issue do you experience?
Are you setting in the inventory file bootstrap_os: Ubuntu or bootstrap_os: ubuntu (notice lowercase 'U')?

i have same issue.
centos with bootstrap_os: centos.
but docker doesn't install.

As it is based on ansible facts, closing it.


Date of Birth not displaying the same date across pages

What version of Node.js are you using?
16.6
What version of npm are you using?
No response
What operating system are you using?
Ubuntu
What version of SnailyCAD are you currently using?
1.26.7
Describe the Bug
When viewing the Citizen page, the Date of Birth is not the same date as the one showing in the Edit Citizen page, in this case 1 day difference.
View Citizen Page
https://i.imgur.com/DyKUdwQ.png
Edit Citizen Page
https://i.imgur.com/oaV41g0.png
Expected Behavior
Date of birth should be the same across viewing pages.
To Reproduce
View a citizen page, and edit a citizen.

This has happened before, if you're able to update and verify if it works now? That'd be great.

Just ran an update and restarted, issue still remains.

I'm unable to reproduce this, if you try any other date (day) does it work properly then?


Fix Emulate 3 Button Mouse

Fixes #96648
Although not sure if this is a feasible solution or if modifiers should be used instead to fix the behaviour.

For the record, the commit seems to be authored with an email address that's linked to another GitHub account (@kentthang). You can find that email address in the header of https://patch-diff.githubusercontent.com/raw/godotengine/godot/pull/97499.patch
If you want it to be linked to your @kthang55 account, you'd need to update the email used for your Git commits (and then amend the commit with git commit --amend --reset-author).

Just did a quick style review pass to help you pass CI checks, but I haven't actually reviewed whether the code changes are correct.
Please also review https://github.com/godotengine/godot/blob/master/CONTRIBUTING.md#format-your-commit-messages-with-readability-in-mind for advice on how to name commits, we'd prefer for it to have an explicit title about what's the issue being fixed, instead of referencing the issue number on GitHub.
"Fix Emulate 3 Button Mouse behavior in 3D viewport" would be a good option.

Thanks for the feedback so far, I think I made changes according to the comments. Thanks for your patience with a first time contributor haha.

Is there anything I can do to get more feedback on my PR?


pop from empty list

# Instantiate the model
model = PConvUnet(vgg_weights='./data/logs/pytorch_to_keras_vgg16.h5')
# model.load(r"C:\Users\Mathias Felix Gruber\Documents\GitHub\PConv-Keras\data\logs\single_image_test\weights.10-0.89.h5")

The error occurs here.

I had the same problem with python3.8 and Ubuntu 20.04
The library uses tensorflow v1.x syntax, that is not supported anymore in python3.8. From Tensorflow install instructions

Python 3.8 support requires TensorFlow 2.2 or later.

The solution is downgrade your python version, preferably using a python virtualenv.

Stackoverflow answer on how create a virtualenv with custom python version
Tutorial on how to point jupyter kernel to a virtual enviroment


Default unchecked checkbox field

It's not possible to have a default unchecked checkbox field by setting the value to false.
If you try this in your _prose.yml config the checkbox will by default be checked.
      - name: "published"
        field:
          label: "Published"
          element: "checkbox"
          value: "false"

What does work is to set the value to empty string which results in a default unchecked checkbox.

should false be unquoted?


MAID-2154 fix/safeApp`s internal connection was set with an invalid pointer when connection failed

Coverage decreased (-0.2%) to 82.058% when pulling c3162529763f8174f9b632462cb4f08a3e5c4f51 on bochaco:MAID-2154-forCleanUp into 6b0d5919750da818704ed913fc92f1fc871fd36b on maidsafe:master.

Coverage decreased (-0.2%) to 82.058% when pulling c3162529763f8174f9b632462cb4f08a3e5c4f51 on bochaco:MAID-2154-forCleanUp into 6b0d5919750da818704ed913fc92f1fc871fd36b on maidsafe:master.

Coverage decreased (-0.2%) to 82.958% when pulling a1c4b93ca37c47205d82b20195c7fe0c2fc6da78 on bochaco:MAID-2154-forCleanUp into a0f0271cb234a2bff41fc99f2755afab32dfb9fc on maidsafe:master.

Coverage decreased (-0.2%) to 82.958% when pulling a1c4b93ca37c47205d82b20195c7fe0c2fc6da78 on bochaco:MAID-2154-forCleanUp into a0f0271cb234a2bff41fc99f2755afab32dfb9fc on maidsafe:master.


Remove related posts from any post

Is there any way I can remove the related posts that come under any specific post?
Right now, I am getting all the other previous posts under this post and that will not be good if I have a lot of notes.
Thank you.

At your site, here: src/gatsby-theme-chronoblog - most likely there are files with names like post-footer.mdx, site-footer.mdx , and site-header.mdx (like this: https://github.com/Chronoblog/gatsby-starter-chronoblog/tree/master/src/gatsby-theme-chronoblog)
There you need to create another file, and name it: content-bottom.mdx
Inside the file, fill it like this:

Thus, you will replace the default value of this file, which looks like this: https://github.com/Chronoblog/gatsby-theme-chronoblog/blob/master/packages/gatsby-theme-chronoblog/src/content-bottom.mdx

At your site, here: src/gatsby-theme-chronoblog - most likely there are files with names like post-footer.mdx, site-footer.mdx , and site-header.mdx (like this: https://github.com/Chronoblog/gatsby-starter-chronoblog/tree/master/src/gatsby-theme-chronoblog)
There you need to create another file, and name it: content-bottom.mdx
Inside the file, fill it like this:

Thus, you will replace the default value of this file, which looks like this: https://github.com/Chronoblog/gatsby-theme-chronoblog/blob/master/packages/gatsby-theme-chronoblog/src/content-bottom.mdx

Yes, it works perfectly.
Thanks a lot, Ganevru.

Yes, it works perfectly.
Thanks a lot, Ganevru.


Add a Homepage for extensions repositories

This pull request allow repositories to generate a homepage during their compilation.
This homepage contains the repository name, description, and available extensions. There is also an installation guide and a link pointing to the website guide about sources.

The homepage design is based on Tachiyomi and Paperback website.
How to use it
The homepage is automatically generated during Paperback-CLI bundle process and is based on the package.json file and the generated versioning.json.
The following fields must be registered in package.json:
{
    name: "The repository name"
    description: "The repository description"
}

The following fields can also be used:
{
    noAddToPaperbackButton: A boolean used to not generate the AddToPaperback button
    repositoryLogo: "Custom logo path or URL"
    baseURL: "Custom base URL for the repository"
}

The default baseURL will be deducted from GITHUB_REPOSITORY environment variable.
How does this work
The homepage consist of a single index.html file.
This file is generated by Paperback-CLI bundle command.
It is based on a Pug file, which will be available available extension-commons package.
Requirements

Pug package
An extra 138 ms of compilation time in extensions-beta repo.

First version statistic:
Without repository.json:

With repository.json:

How to test this pull request
I believe you need to inject these modifications in an existing repository like beta repo, run npm run bundle.

Huge thanks to @ConradWeiser for his precious help and advice on the project, making it possible 🧡 !

Two questions:
With Paperback-CLI, do we remove the gulpfile modifications?
Also where pug should be added? Here or in Paperback-CLI?

Add the pug template to the cli repo

Closing in favor of paperback-cli#1


Add support for nested array to grouped list conversion

This ports the the handly feature of the node MySQL client where nested arrays are
grouped into lists, i.e. [[1, 2], [3,4]] => (1, 2), (3, 4) for easy bulk insert syntax generation.
See https://github.com/felixge/node-mysql#escaping-query-values for details.
Note the conversion currently applies to string and literals escaping only as the others don't really make sense

Overall this looks great, thanks! I have a few minor requests.

Please add a test for format.ident() with a nested array. It should produce an error that says SQL identifier cannot be a nested array.

On lines 103 and 156 in your PR, please make the if statement explicitly check true similar to the rest of the codebase. The reason is to be absolutely clear what that check means when reading the code later.

On line 31 in your PR, please just use a for loop. I am okay with using iterators and closures for complex code, but that is not the case here.

Please make the changes and I will accept the PR.

Thanks.

1 makes sense, especially since I didn't document this.
With some grumpiness I will accept 2 and 3. Feels like we're trying to shoehorn constraints from traditional languages like C++/Java into JS. I know, because I used to write JavaScript like that years ago when I didn't know better. Anyway, perhaps one day I'll make a pull request that leverages typeof to make the code more explicit :)

I understand the grumpiness. Thanks for the PR and thanks for putting up with my anal retentiveness. :)

Also sneaked in code coverage :)

Looks great! Thanks.


Improvement converter configuration

hi @Koenkk
we need some sort of replay action for failed converter configuration in single-steps.
sometimes it could be failed to do some bind or do write command on ias devices so we need to do it again to get them hopefully working.
instead insert every cb command as second ones in codeblock we should do it automatic.
if one cb give error message from any type we should do it minimally ones again, maybe so some of configurable variable could be help.

that's an good idea!
Did you experience this issue? (So that it worked correctly after doing the same configuration again)

Yes, sadly on most Devices who are on Power standby by pairing. Some ssIasZone Devices too.

@Koenkk Do you actually working on this ?
I´m thinking this would help a lot of open issues by failed configured devices ..

@tb-killa Yes, will do it together when I move the device configure code out of controller.js and move it to an extension.


DeprecationWarning: typeMap is deprecated. Please use TYPE_MAP instead.

When using pyasn1 and testing using pytest, I get the warnings:
[Mon Oct 14 11:08:05.919973 2024] [wsgi:error] [pid 5920:tid<PHONE_NUMBER>58304]   haveNameConstant = hasattr(ast,'NameConstant')
[Mon Oct 14 11:08:06.961924 2024] [wsgi:error] [pid 5920:tid<PHONE_NUMBER>58304] /.venv/lib/python3.12/site-packages/pyasn1/codec/ber/encoder.py:952: DeprecationWarning: tagMap is deprecated. Please use TAG_MAP instead.
[Mon Oct 14 11:08:06.961936 2024] [wsgi:error] [pid 5920:tid<PHONE_NUMBER>58304]   warnings.warn(f"{attr} is deprecated. Please use {newAttr} instead.", DeprecationWarning)
[Mon Oct 14 11:08:06.961946 2024] [wsgi:error] [pid 5920:tid<PHONE_NUMBER>58304] /.venv/lib/python3.12/site-packages/pyasn1/codec/ber/encoder.py:952: DeprecationWarning: typeMap is deprecated. Please use TYPE_MAP instead.
[Mon Oct 14 11:08:06.961947 2024] [wsgi:error] [pid 5920:tid<PHONE_NUMBER>58304]   warnings.warn(f"{attr} is deprecated. Please use {newAttr} instead.", DeprecationWarning)

I am pretty sure that they come from the pyasn1 code itself (which apparently uses the deprecated syntax), because my code doesn't use these parameters (typeMap or TYPE_MAP). It would be nice to fix these warnings.

To help diagnose the issue further, could you please provide a minimal code snippet that reproduces the warnings?

I also received this warning when I upgraded to Python 3.12 in my django project which uses the ldap3 package.

I think I could also simply have met the ldap3 issue. 🤔

Okay, sounds good!
I'll close it as 'Not a bug' for now.
Feel free to reopen it if you'll find a pyasn1 code reproducer! Thank you!


WARNING: No route found for IPv6 destination :: (no default route?)

When i use the following steps am getting the below mentioned Error message....
 Thank you in advance.
~/p4factory/targets/basic_routing$ sudo python run_tests.py --test-dir tests/ptf-tests/
WARNING: No route found for IPv6 destination :: (no default route?)
routing.TwoBdLpmTest ... ERROR
======================================================================
ERROR: routing.TwoBdLpmTest
Traceback (most recent call last):
File "/home/maha/p4factory/targets/basic_routing/../../testutils/pd_base_tests.py", line 65, in setUp
ThriftInterface.setUp(self)
File "/home/maha/p4factory/targets/basic_routing/../../testutils/pd_base_tests.py", line 49, in setUp
self.transport.open()
File "/usr/local/lib/python2.7/dist-packages/thrift/transport/TTransport.py", line 149, in open
return self.__trans.open()
File "/usr/local/lib/python2.7/dist-packages/thrift/transport/TSocket.py", line 101, in open
message=message)
TTransportException: Could not connect to localhost:9090

Ran 1 test in 0.002s
FAILED (errors=1)

ATTENTION: SOME TESTS DID NOT PASS!!!
The following tests errored:
TwoBdLpmTest

WARNING: No route found for IPv6 destination :: (no default route?) is not really an error here.
TTransportException: Could not connect to localhost:9090 on the other hand is a real error, and usually means that you do not have the switch running. Which command did you use to start the behavioral model switch?

BTW, the steps described in the README are as follows:
cd p4factory/targets/basic_routing/
make bm
sudo ./behavioral-model

You want to make sure that sudo ./behavioral-model did not return an error.

First of all, Thank you for your answering.
When i start behavioral model itself getting errors are below
~/p4factory/targets/basic_routing$ make bm
cp /home/maha/p4factory/targets/basic_routing/build//bin/bm behavioral-model
cp: cannot create regular file ‘behavioral-model’: Permission denied
/home/maha/p4factory/targets/basic_routing/../../makefiles/bm.mk:115: recipe for target 'bm' failed
make: *** [bm] Error 1
/p4factory/targets/basic_routing$ sudo ./behavioral-model
No PD RPC server address specified, using <IP_ADDRESS>:9090
No listener specified, switch will run in standalone mode
P4 Program:  basic_routing
Starting RPC server on port 9090
bmi_port_interface_add(port_mgr, veth_name, n_veth, pcap_filename): ERROR -1 at main.c:434
Can you give the solution for the above mentioned error??

The make error could mean that the file is busy because another instance is running.
For the bmi_port_interface_add error, you need to run sudo p4factory/tools/veth_setup.sh as indicated in the README. It will create the veth interfaces needed to run the model.


Update version: filips.FirefoxPWA version 2.9.1

Pull request has been created with WinGet Automation 🪟📦🤖
Microsoft Reviewers: Open in CodeFlow

Hi @vedantmgoyal2009,
This manifest adds Apps and Features entries that aren't present in previous PR versions. Should these entries also be added to the previous versions?
(Automated response - build 582.)


Questions Regarding the Implementation of the GR Ranking Model

Hi, I would like to express my gratitude for your incredible work on the GR model! It is truly groundbreaking in how it integrates large language models (LLMs) and ushers in a new era for recommendation systems!
I am currently attempting to reproduce the ranking model on the KuaiRand dataset and have encountered a few questions that I hope you could help clarify.
Specifically, I am seeking guidance on the data preprocessing steps and the model's loss function. Any information or suggestions you could provide would be immensely helpful.
Data preprocessing
From Section 2.1 and Figure 2 of your paper, it appears that the input sequence is structured as follows:
$$ \text{contextual token}_0,\text{ contextual token}_1,\text{ contextual token}_2,\dots,\text{ item token}_0,\text{ action token}_0,\text{ item token}_1,\text{ action token}_1,\dots $$

Is my understanding correct? Does GR explicit use action token as input for ranking?
For the contextual token, do we need to do causal mask when calculating attention in training?

Loss calculation
In the paper it is said that
We apply a small neural network to transform outputs at Φi+1 into multi-task predictions in practice.

I assume this means we will have a discriminative loss.
Could you elaborate on the use of autoregressive loss? Is it necessary for ranking? If so, should we calculate autoregressive losses across all tokens or only on item and action tokens?

Thank you very much for your time and assistance. I look forward to your insights.

Hi - Thanks for the interest in our work. Releasing some representative implementation is definitely on our radar (please check other issues), but a) we need a way to decouple Meta's internal implementation in a clean fashion, b) we need to find a representative public dataset. So this may take some time.
For 2/ We do apply causal mask to contextual tokens as well (think about it as essentially a decoder-only setup)

Thank you so much for your reply! I completely understand the challenges involved in releasing the ranking implementation. Given that, perhaps some general guidelines related to the specific questions I have would be helpful and sufficient. I am also happy to clarify my questions further.

Does GR take action tokens as input during ranking?
How should GR handle multiple actions? In the formulation, each item token is followed by exactly one action token. However, in real-world recommendation systems, it's common for users to perform multiple actions on an item, such as liking and commenting simultaneously. In this case, does GR combine multiple actions into a single token or handle them differently?

I appreciate any insights you can provide!

1/ Yes.
2/ In most cases we can take the outer product (cartesian product) to combine multiple one-hot encodings into a single encoding. For instance in a typical use case, {like, share} both in {0, 1} can be encoded with [0..3].


Ouput is unrelaxed, does not have meaningful prediction

Hi, thank you for your help previously.
I am having trouble with the outputs of the models, they all are all marked as unrelaxed. how do i predict/access the full structures?

Thank you for reaching out!
The primary focus of this project is to reproduce ESMFold and extend its functionalities. Relaxation is not part of the ESMFold process; hence, it's not incorporated into this project. Moreover, it's known that including relaxation in ESMFold doesn't contribute to performance enhancement(facebookresearch/esm#415).
If you're seeking relaxed structures in the predicted output, you might want to explore the modules used in Alphafold2(https://github.com/google-deepmind/alphafold/tree/main/alphafold/relax).
I hope my response is helpful.

Hi! Thanks for the clarification.
I also ran the model with Omegafold, and it also gave unrelaxed structures. Does this project allow for structure prediction where I can do TMscore comparisons with other proteins (eg replace completely my use of omegafold with solvent)? If so, how do I get a protein output using solvent?
Thanks!

I may have provided an incomplete explanation.
If you've completed training and used the weights to run a demo, you should be able to obtain predicted structure PDB files. With these PDB files, you can calculate TMscore against other PDB files. As mentioned above, you can transform these files into relaxed output using external module.
After looking at the figure above, it seems more like a case of the model not being trained correctly rather than a relaxation issue.

You are right, this is not an issue with relaxation, thank you for the clarification. I tried running the demo straight from the downloaded weights provided in the download instructions page. Do I need to train the downloaded ESM 650 weights using solvent before I run the demo?

Yes, you're correct.
Before running the demo, it's essential to train the structure prediction (folding) model based on the protein language model(ex. esm).

Okay that makes so much sense, thank you so much. Would it be possible for you to provide a download link for some solvent-trained weights for people who just want to run the demo?


Please notify user that Hukamnama will be downloaded as pdf

I came to know about this app from reddit.
Action:
When user clicks the menu item Hukamnama on left hand side,
Expectations:
The app will display the Hukamnama Text here, in app itself, its its won web-view.
What happens:
Chrome/Phone starts downloading a pdf, and notifies: PDF downloaded - Hukamnama.pdf.
Issue:
User needs to open a separate app to view this pdf.
The next time user clicks, the pdf gets saved as Hukamnama(01).pdf
Suggestions:
I understand that it might be cause there is no Hukamnama text API available, only a pdf link is available from SGPC website (?). I might be wrong, please see if a text API is available?

Thank you so much for raising this issue.
Yes, currently the app just relies on browser taking the action on the PDF, in case you have the PDF viewer enabled in your browser, it'll open as a PDF inside the web page, or it'll ask you to download it.
Yes, there's no text API available as such, I'm planning to extract the hukamnama from the PDF and thereby create a text API reliant on SGPC website.

Ok, thanks, could you tag this as feature?, as not-urgent.


validation: tighter validation of multisampled images

if MS=1, then Sample image operand is required
Sampling operations are not permitted when MS=1

Fixes #4057, #4058

I found this when working on the SPIR-V reader in Tint.  For multi-sampled images, the Sample image operand is required.  The validator wasn't checking this, but I want it to be validated before getting to the reader in Tint.

Sounds good. Will do.
When I dug into multisampled images (like never before) I was surprised.

Sample image operand must be used if and only if MS=1
Sample image operand is only permitted on Fetch, Read, Write, SparseFetch, SparseRead

Hence the perhaps surprising result that multisampled images ... can't be sampled.  :-/
Chalk that up to experience I guess.
Note you can have a storage image with MS=1, if StorageImageMultisample capability is declared. (Hence the ability to do Read and Write)

This is ready for re-review.  PTAL @alan-baker


Unable to set optional path for rsync installed from Macports

Hello.
Thanks for building a very interesting front end to rsync.  I'm looking forward to trying it out but I can't get my rsync v3.1.2 installed via Macports to be set in the optional path.
which rsync give the path: /opt/local/bin/rsync
I believe the permissions are 744 and the owner is root and group admin.  I think this is the standard for Macports.
I am not able to add the path without an error.

Hmm, I will look into it. You should set only the path, /opt/local/bin (I am not using Macports, that is why RsyncOSX gives an error)..
You can also try to open a terminal and do a ls -al /opt/local/bin to check if you can list the rsync command. RsyncOSX does a simple file check to see if rsync is installed in the given path..

Thanks!
I'm not sure if the update fixed it but entering /opt/local/bin allowed RsyncOSX to find the rsync 3.1.2 from Macports.
Thanks again!


Add CLASS or RUNTIME limitation to annotation processors

Fixes #19366

@oehme could you take a look?

@bot-gradle test and merge

Your PR is queued. See the queue page for details.

OK, I've already triggered a build for you.


Copying folder to its subfolder causes recursive bug

There was a bug when I think I copied one folder to its subfolder or something like this. It recursively copied folders until I stopped the process. There were thousands of folders created one inside the other.

Thanks for the report, that does indeed sound like a bug. Would you be able to clarify the recreation steps as I haven't been able to make this happen. It sounds very likely possible though if done in some order.

There was a bug when I think I copied one folder to its subfolder or something like this. It recursively copied folders until I stopped the process. There were thousands of folders created one inside the other.

I think I have recreated it via the "Copy" context menu or via Ctrl+C. I will have a fix asap.

Added a fix to remove the parent directories from paste lists.


[Candidate 2v2 Bricks 2v2 ZH v1] AI Trigger areas are not correctly placed

Issue Description
AI area are wrongfully placed.
Expected behavior
AI area are correctly placed.

AI issues fixed here:
Bricks 2v2 ZH v1.zip

Fixed with https://github.com/xezon/GeneralsRankedMaps/commit/46f13a6b2d6ad92413ff1834bcbdd188ac518601


Bug fix: Auto tuning disable model unit test failure

Fixed issue: https://github.com/linkedin/dr-elephant/issues/341

Looks good.

+1, thanks @arpang for fixing this.


Add way to remove users who have no roles

Users with no roles mean they are unverified and most-likely spam accounts. A feature to automatically prune users who do not have a role will help reduce spam accounts.

as we aren't using blockchain tech currently it's hard to go over 10k users to find users without roles


Cant run using Xcode 7 on IOS 9 iPhone

Im having an issue where I go to run the default hello world app that gets installed on react-native init on my iPhone and I get the following errors.

It will run fine using the simulator. Any help to get this working would be great.

This should be fixed in the next release.

Hello @ide, could you provide more information about the way to solve this problem?

You could check out the master branch here and use it, or I think you can disable Dead Code Stripping in your compiler options.

@ide Thank you, it works with Dead Code Stripping disabled


Gaussian Filtering

Hi @matthew-brett
I'm working on doing gaussian smoothing as we discussed in OH. I was wondering if I need to handle the fact that not all values in my 3D volume correspond to voxels in the brain. I presume that the 0 values in my 3D volume are coming for those voxel. If I'm using scipy.ndimage.filters.gaussian_filter on the 3D volume, would smoothed values on the boundary of the brain be incorrect since they are averaging zeros into them from outside the brain?
What are your thoughts and suggestions?
Thanks,
Alon

@jarrodmillman  or @rossbar Do you have any thoughts about this?

One thing you could do is take the values that correspond to the edges of the brain in the image and expand them to the neighboring voxels. This technique is called "padding" the signal and would prevent the smoothing function from incorporating a bunch of non-signal voxels with signal voxels in the convolution. However, an approach like this may be difficult to implement, especially with so little time.
A simpler approach might be to run gaussian filters with several different widths over the data; one with a wider width for the brain and one with a much tighter width (or with the 'truncate' value set to a much lower value like 1 std dev instead of the default 4). For voxels that are in the interior of the brain, you can use the one set of smoothed values, and for voxels nearer the edge, you could use the results of the truncated filter.
In the end, it may also be possible for you to justify just using a single filter and including caveats about the edge pixels. Given the width of your gaussian kernel, you should have some idea of how far in from the edge of the brain voxels will be effected by convolving with non-signal voxels. If this "edge region" is small and not expected to contain significant brain activity anyways, you could potentially justify ignoring results from this region.

Sorry to be slow to get back to you.   It's a good question, and I agree with Ross' answer.
In practice, most brain imaging studies ignore this problem, and you're welcome to do the same, raising this as a problem, as Ross suggests.
I also think that you should be careful not to spend too much time on this, so close to the project deadline.
One approach that people have used to solve this problem, is extract the signal corresponding to the gray matter, on the outside of the brain, and then smooth the values on the 2D surface - here's an example :
@article {HBM:HBM1005,
author = {Andrade, Alexandre and Kherif, Ferath and Mangin, Jean-François and Worsley, Keith J. and Paradis, Anne-Lise and Simon, Olivier and Dehaene, Stanislas and Le Bihan, Denis and Poline, Jean-Baptiste},
title = {Detection of fMRI activation using Cortical Surface Mapping},
journal = {Human Brain Mapping},
volume = {12},
number = {2},
publisher = {John Wiley & Sons, Inc.},
issn = {1097-0193},
url = {http://dx.doi.org/10.1002/1097-0193(200102)12:2<79::AID-HBM1005>3.0.CO;2-I},
doi = {10.1002/1097-0193(200102)12:2<79::AID-HBM1005>3.0.CO;2-I},
pages = {79--93},
keywords = {statistical analysis, cortical surface, spatial smoothing, fMRI, methodology},
year = {2001},
}


Reading mode needs improvement on mobile

i would personally love if text in reading mode elastically filled out to the page width. also there are various alignment and width issues here and there, like if you start in the middle of a surah the alignment should be left aligned not centered

Also It would be nice , When the font size is changed , the verses wrap neatly.
Right now , when font size is decreased or when screen size is small ,the line breaks at the end of verse and next verse starts in new line.

Looks great on desktop, but not great on mobile!


Use absolute path when opening new content in editor

Currently, when hugo --source="/path/to/hugo/site" new post/test.md --editor="subl" is invoked from anywhere but inside the hugo site directory, it will create the file in the correct place, but the editor will open a non-existent file referenced by the relative path post/test.md

I was not able to use those two flags --source and --editor in conjunction with the new command.
Yields:
~  hugo --source="/Users/john/src/hugotest/" new posts/in.md
Error: unknown flag: --source

Humph. hugo --help doesn't mention --source?

Humph. hugo --help doesn't mention --source?

For almost two weeks in Hugo v0.16-DEV: No, because I removed it, see #1624.
I have just added it back a few minutes ago in commit c1e134f after committing @kujohn's excellent fix to this issue.  :wink:
Cheers,
Anthony


gimpPlugins.gap: patch ffmpeg to avoid asm error

Description of changes
Closes https://github.com/NixOS/nixpkgs/issues/294707
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 295257 run on x86_64-linux 1

2 packages built:

gimp-with-plugins
gimpPlugins.gap

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-ready-for-review/3032/3650

Result of nixpkgs-review pr 295257 run on x86_64-linux 1

2 packages built:

gimp-with-plugins
gimpPlugins.gap


BLE Client Problem

I'm trying to improve Client example, the ESP 32 discover devices but it doesn't seems the Services and the Characteristics, anyone have this problem?
Thank you so much.

No I don't have this problem, I am some clients that connect to a server and read and write on characteristics without problem.

No I don't have this problem, I am some clients that connect to a server and read and write on characteristics without problem.

Do you have any example? Thank you


RHEL/Centos 7 Getting Started Doc

Please review the following Guide. I added all the information as we discussed in https://github.com/digitalocean/netbox/issues/161

Sorry for the long commits. You can ignore the rest and look at the last few. This is only for the Centos guide. I removed the other ones.

I'm guessing you intended to create a guide for Centos, but this PR replaces the original guide.


Fix/migration file errors

Description
Fixes #

What work was done?
Added fixes for two errors with newly created migration files.
Why was this work done?
Migration files were not able to be completed successfully.
What feature / user story is it for?
Schema and API for Story Squad (trello card)
Any relevant links or images / screenshots
N/A

Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

Change Status

[ ] Complete, tested, ready to review and merge
[x] Complete, but not tested (may need new tests)
[ ] Incomplete/work-in-progress, PR is for discussion/feedback

Has This Been Tested

[ ] Yes
[x] No
[ ] Not necessary

Checklist

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] My code has been reviewed by at least one peer
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[ ] There are no merge conflicts

Looks good.  Thanks for Cindy and fixing the errors.


Allow a project folder placeholder in folder prefs

Currently, the app folder can be used as a folder preference target by using *APP.
Add the ability to let projects default to storing files in their own directory using *PROJ.
This includes allowing subfolders, e.g. *PROJ/maps, *PROJ/assets

This will be a lot more work than we have time for now, so we'll move it back to the Issues backlog as a question.


Update shadowjar and fix gson not being shadowed into built jar file

Ah sorry, I missed this in the first PR. Building should work perfectly now.

Thanks, I noticed that and was trying to fix it myself for a bit, then got distracted by actual work.

Hey @xcfrg, any chance you can take a second look at the launch4j stuff? it appears that the exe is not including the shadowed classes from gson.


UCSD-GUEST network users cannot connect to streaming video/audio service on ports TCP 1935 and 1936

Descriptive summary
UCSD-GUEST network users cannot connect to the Geisel Library streaming video/audio service on ports TCP 1935 and 1936.  These ports are accessible to UCSD-PRIVATE and even to off campus, but not to UCSD-GUEST users.
There two servers: lib-streaming.ucsd.edu (<IP_ADDRESS>) and lib-streaming-test.ucsd.edu (<IP_ADDRESS>), which provide streaming service on two ports, which should be accessible to anyone on campus of off (TCP 1935 and 1936).

@gamontoya - Ron made some change to the streaming server.  I updated DMR and deployed it to staging.  Could you try to see if they work for you using UCSD-Guest wireless network? Thanks
For example
Video playlist - https://librarytest.ucsd.edu/dmr/courses/111/Fall/2018/test_video_course_1_-_09_24_2018
Audio playlist -  https://librarytest.ucsd.edu/dmr/courses/109/Fall/2018/test_audio_list_2_09_21_2018

@VivianChu I don't think I can access from UCSD-Guest wireless from home.

@VivianChu - You can try whenever you're on campus.  I also can't access UCSD-Guest wirefless from home.  I'll test them next week when I'm on campus.  Those videos/audios worked for Ron on UCSD-Guest wireless.

@VivianChu Thanks. I'll test when I'm on campus too...on Tuesday.

@VivianChu By the way, this did work using UCSD-guest, but it made me use SSO for each link. If that is expected behavior, then it's all good!

@gamontoya - DMR users always need to login in order to watch video.  That is expected behavior.


Use imager with headless craft and graphql

Hi there
I tried to get my head around the usage of imager with a headless craft installation, but did not have any success so far.
I also did not find any documentation on that.
I have the following situation:
I upload a normal image to a volume and I get the url of the asset via graphql.
How could I now get a specific image transform for that asset via imager?
Do I have to write something custom that runs commands like craft.imager.transformImage(image, { width: 1000 }) or how could I achieve this?
(And if yes, where would I write this? Would that be a service? Any pointers are very welcome...)
Thank you in advance
Cheers

Well I totally missed that I can request image transforms with graphql as well: https://github.com/markhuot/craftql#transforms
I think this could solve my problems.

In the case of the CraftQL plugin, this is something that needs to be added to that plugin. I'm looking into if it's possible to add custom directives to the built-in GraphQL support (which is what would be needed).


Custom integrated terminal profile doesn't use correct Python interpreter path

Behavior
I am trying to create a Python integrated terminal profile for VSCode. This integrated terminal should always use the currently selected Python Interpreter. There does not seem to be a way to do that.
Expected vs. Actual
I expect to be able to create an integrated terminal profile that uses the currently selected Python interpreter as part or all of its path.
When creating a custom terminal profile, setting the path to python works, but it does not use the correct Interpreter.
According to the VSCode documentation the path, args, and env properties of the integrated terminal configuration all support resolving variables.
https://code.visualstudio.com/docs/terminal/profiles#_configuring-profiles
Therefore, setting the terminal profile path to ${command:python.interpreterPath} should work. It does not work. The profile will not even show up in the list as a valid choice.
Steps to reproduce:

Make a new Python project in VScode that uses a non-default Python interpreter such as in a virtualenv.
Use the Python: Select Interpreter command to select the interpreter.
Create a .vscode directory in the project.
Create a settings.json file in the .vscode directory
Add the following custom integrated terminal profiles to the settings.json.

{
	"terminal.integrated.profiles.linux": {
		"pythona": {
			"path": "python"
		},
		"pythonb": {
			"path": "${command:python.interpreterPath}"
		}
	}
}

Attempt to open new integrated terminals using these profiles.
The first profile will work, but it will use the wrong Python interpreter.
The second profile will not work at all.

# Diagnostic data

-   Python version (& distribution if applicable, e.g. Anaconda): 3.8.16
-   Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Poetry
-   Value of the `python.languageServer` setting: Default

@meganrogge This issue is about resolving variables in settings.json. Currently these are resolved only for launch.json and tasks.json, this should be assigned to someone who own the settings in VS Code.

can you just provide the correct python path to the first profile?
we don't support resolving commands in terminal profiles, so not surprising that the second one fails

can you just provide the correct python interpreter path to the first profile?

It is very handy to be able to make custom integrated terminals that launch directly into Python interpreters like IPython, or other project-specific Python programs. For example in a Django project someone might want to have an integrated terminal that uses python manage.py shell or python manage.py dbshell as its shell. That saves a lot of hassle compared to opening a bash or zsh integrated terminal and typing an additional command every single time.
The problem is that this will only work if the settings.json is aware of the path to the currently selected Python interpreter. If it is a solo developer that never changes interpreters, yes, they could hard-code the path in there. But that is rarely the case.
In my case, the settings.json with the definitions of integrated terminals is distributed with the project in the .vscode directory. The custom terminals are running some interactive shells that are project-specific. Therefore, every developer on the project would like to share those configurations by having them in the repo, and be universal amongst all developers.
However, each different developer might have a different Python interpreter path based on their dev environment. Even a single developer might have multiple Python interpreters that they switch between for testing or other purposes. VSCode has an "official" way of selecting the current Python interpreter. That selection is recognized in launch.json and also tasks.json. But there is no way I know of to access it from the definition of an integrated terminal.
 This is far from ideal.

@karthiknadig the fix @Tyriar and I discussed for this would be for the python extension to contribute a terminal profile with the correct path.

That's actually a great idea.


MemoryError: Allocation failed (probably too large) with ped.compute()

Hi,
I am running a big simulation with a million people and I'd like to calculate the genealogical relatedness between them. I tried running sgkit and unfortunately, when I hit the ped.compute() step, I run into this error: MemoryError: Allocation failed (probably too large).
Any advice on how I can bypass this? I tried doing some stuff related to dask but didn't get anything useful.
P.S: I have a lot of unrelated pairs of individuals in the trees and I am only interested in ones that are above a certain threshold. Could that help? Any suggestions are welcome.

That's a tricky one - I think all our pedigree algorithms are "dense", and aren't really designed for these kinds of large pedigree. I think @timothymillar had some thoughts about how we might implement though?

Hi @fouerghi, yes we currently only support dense arrays. From memory, we decided to avoid sparse arrays until there is more standardized support in our dependencies (Xarray and Zarr).
An alternative that I have considered implementing is chunked computation of kinship/relatedness. This would allow you to compute the relationship matrix in chunks rather than all at once. Theoretically, this should let you identify closely related individuals (in each chunk) without holding the whole matrix in memory. Does this sound like a reasonable solution for your use-case?

P.S: I have a lot of unrelated pairs of individuals in the trees and I am only interested in ones that are above a certain threshold. Could that help? Any suggestions are welcome.

Is this a single pedigree in which all individuals are connected, or is it a single dataset with multiple independent pedigrees? If it is the latter then you may be able to split it into multiple smaller pedigrees and perform your computations on those. The pedigree_sel function may be helpful here.

Hi Jerome and Tim,
Thank you for getting back to me. Could you elaborate more on the chunking part? I am interested in identifying (full sibs, first cousins, second cousins, third cousins and 4th cousins). Would it work for these cases?
I have a single pedigree where all individuals are connected.

Could you elaborate more on the chunking part?

It's a strategy to compute large arrays/matrices in parts which can avoid needing to hold the entire matrix in memory at once.  We haven't implemented it for pedigree based kinship estimation yet because it's quite complex. I have written a short script demonstrating how you could do this manually, but it will be quite slow and may require some tuning of the chunk size:
https://gist.github.com/timothymillar/2bb2a4521daf948d76808d60eccb390a

I am interested in identifying (full sibs, first cousins, second cousins, third cousins and 4th cousins). Would it work for these cases?

In that case you may not actually need to compute genealogical kinship/relatedness. There are multiple relationship types that can give similar estimates of genealogical relatedness. So it might be better to try and pull these relationships directly from the pedigree. For example, you can identify sets of full sibs based on them having identical parents. But the more distant relations will be more complex.

Hi @fouerghi, sorry for my slow response. I'm afraid we don't have an equivalent function in the current 0.7 release. Hopefully the next release won't be too far away.


DID allowed/trusted JSON-LD contexts

Note that currently we are not "really" processing DID documents as JSONLD documents. We process them as regular JSON documents that happen to have @context.
We are not handling media types either.


Clarify that jobs in a workflow can compromise each other only on self-hosted runners

Code of Conduct

[X] I have read and agree to the GitHub Docs project's Code of Conduct

What article on docs.github.com is affected?
https://docs.github.com/en/actions/security-for-github-actions/security-guides/security-hardening-for-github-actions#reusing-third-party-workflows
What part(s) of the article would you like to see updated?

The individual jobs in a workflow can interact with (and compromise) other jobs. For example, a job querying the environment variables used by a later job, writing files to a shared directory that a later job processes, or even more directly by interacting with the Docker socket and inspecting other running containers and executing commands in them.

My understanding is that this only applies to jobs running on self-hosted runners.
As per https://docs.github.com/en/actions/using-github-hosted-runners/using-github-hosted-runners/about-github-hosted-runners, GHA-hosted runners use a fresh VM for each job. So "shared directory" and "Docker socket" are not a thing for GHA-hosted runners.
Additional information
No response

@neongreen Thank you for raising this issue! I'll get this triaged for review :sparkles: Our team will provide feedback regarding the best next steps for this issue - thanks for your patience! 💛

من 36m toncoin رو قفل کردم در شرط بندی برای یک ماه وبعد کد منبع راگفتم اما نمی‌دانم چرا بترتیب چیدمان نشده وچرا به بر نمیگرده به حسابم naminator درسته چرا برای شرط بندی منو آگاه نکردید که اینهمه مشکلات دارد شما رسیدگی کنید وچیدمان فایل رو درست کنید همون naminator که تایید شده کل مبلغ باید باشه بقیه فایل ها واجب نیست

@neongreen Thank you for your patience while our SME team reviewed! ✨ Our SMEs responded with the following:

The customer is correct that self hosted runners can be compromised unless they design systems like we do for hosted that guarantee a completely isolated environment
We may want to be more clear on
The individual jobs in a workflow can interact with (and compromise) other jobs. For example, a job querying the environment variables used by a later job, writing files to a shared directory that a later job processes, or even more directly by interacting with the Docker socket and inspecting other running containers and executing commands in them.

In theory, some jobs can depend on the output of other jobs
So if you compromise that output, you can compromise the later jobs even on hosted
But the examples in that snippet are not accurate
For example, in self hosted environments a job querying the environment variables used by a later job, writing files to a shared directory that a later job processes, or even more directly by interacting with the Docker socket and inspecting other running containers and executing commands in them.

In hosted environments, [job outputs can be compromised](https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/passing-information-between-jobs).

Given our SMEs are aligned with you, would you be willing to open a PR to correct this doc? 💛


Define campaign area limits to fit in lambda disk size limits

We need to operate on a limit of 300 MB of OSM data in order to be possible to produce the geojson on the 512 MB disk size of a lambda function.
Possible ways of acting: set a limit a bit higher and inform the user to reduce the area if the query execution fails.
Some query analyses are available at https://github.com/hotosm/MapCampaigner/issues/496
Related to https://github.com/hotosm/MapCampaigner/issues/558

@willemarcel is this issue still relevant?

@russbiggs what we need to do yet is to improve the error messages and let the user knows when the result of the query is bigger than supported.

ok great I'll keep this open and tag as an enhancement


WIP: feat: enhance type capabilities

Description

support types hot reload
support re-export remote types
support consume/generate runtime api types
support extract third parth types

demo start steps:

install deps

pnpm i

build needed packages

nx build

start demos

pnpm app:ts:dev

You will see react-ts-host will auto fetch its remote types
And react_ts_nested_remote's dep react_ts_remote will be stored in react_ts_nested_remote's/node_modules which can support re-export remote .

when update the react_ts_nested_remote , the host will auto fetch the latest types :

Related Issue
#2154
Types of changes

[x] Docs change / refactoring / dependency upgrade
[ ] Bug fix (non-breaking change which fixes an issue)
[x ] New feature (non-breaking change which adds functionality)

Checklist

[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
[x] I have updated the documentation.

Would be helpful to know roughly what the dev server is doing.

Would be helpful to know roughly what the dev server is doing.

I forget to add the rfc link , here is : https://github.com/module-federation/universe/issues/2154
And more details will be added soon

@ilteoood  @ScriptedAlchemy  @zhoushaw  please help to review this pr

i need to add config to control whether enable third party extract

To be honest I strongly disagree with the work that has been made here, for the following reasons:

the PR is too big to be reviewed in the proper way. Smaller PRs that target a feature branch would be ideal;
the native federation typescript plugin exposes a function to generate and extract types. It does only that and does it well. As I said in the proposal ticket, there's no need to move that code into another package that does also other things

I also think mr Is very big. When I carefully check the contents, I find that many changes are caused by example and several new pkg, But this is a really bad practice, and I'm sure we can improve it later, Perhaps you can ignore example and some of the other parts of the change such as: third-party package reference type extraction, type hot update generation, this part as a new feature does not affect existing users, maybe by experimenting with example

To be honest I strongly disagree with the work that has been made here, for the following reasons:

the PR is too big to be reviewed in the proper way. Smaller PRs that target a feature branch would be ideal;
the native federation typescript plugin exposes a function to generate and extract types. It does only that and does it well. As I said in the proposal ticket, there's no need to move that code into another package that does also other things

In terms of code movement, I looked at the dependencies of the pkg and I believe that some of these changes are necessary because the new dependencies allow users to reduce some of the dependencies on installation and configuration items, resulting in a better experience and cost of use

@ilteoood  Okay , it seems that we have a misunderstanding about the feature. We want to provide the best develop experience which is just like normal npm packages :

type hints
timely type updates (hot type reload)
support nested remote types
support export third party dts

But currently not implement this , so we want to make a pr to support . But if what we do make you confused , we are sorry , it's not our original intention.
TO prevent unnecessary misunderstandings, i decided to make new implementation and we will not change the original packages .
cc @ScriptedAlchemy @zhoushaw

@ilteoood Okay , it seems that we have a misunderstanding about the feature. We want to provide the best develop experience which is just like normal npm packages :
* type hints

* timely type updates (hot type reload)

* support nested remote types

* support export third party dts

But currently not implement this , so we want to make a pr to support . But if what we do make you confused , we are sorry , it's not our original intention.
TO prevent unnecessary misunderstandings, i decided to make new implementation and we will not change the original packages .
cc @ScriptedAlchemy @zhoushaw

The goal is really clear, and I really like it.
My concerns are mostly related to the way in which you are trying to achieve it. Instead of moving code between packages to create a bigger package (which easily become hard to maintain), you could simply compose them. That's it!
Of course another implementation of the ts algorithm is not needed, please re-use as much code as you can but simply keep in mind to make the whole process easy, because I don't want to go back into a similar situation with the old TS package that was a nightmare to maintain

I've made the review of the dev-kit package, hope to find the time to do something more later these days

@ilteoood Okay , it seems that we have a misunderstanding about the feature. We want to provide the best develop experience which is just like normal npm packages :
* type hints

* timely type updates (hot type reload)

* support nested remote types

* support export third party dts

But currently not implement this , so we want to make a pr to support . But if what we do make you confused , we are sorry , it's not our original intention.
TO prevent unnecessary misunderstandings, i decided to make new implementation and we will not change the original packages .
cc @ScriptedAlchemy @zhoushaw

The goal is really clear, and I really like it. My concerns are mostly related to the way in which you are trying to achieve it. Instead of moving code between packages to create a bigger package (which easily become hard to maintain), you could simply compose them. That's it!
Of course another implementation of the ts algorithm is not needed, please re-use as much code as you can but simply keep in mind to make the whole process easy, because I don't want to go back into a similar situation with the old TS package that was a nightmare to maintain

Gotcha , i will move dts-kit back to native-federation-typescript , and export some utils i need to provide to manifest in subpath. And i will streamline the package structure and reduce some unnecessary packages

I did another round of review.
I want to be honest here: excluding for a second the amount of files that have been committed, the code quality needs A LOT of improvement.
Looking at the big picture for a second, I think that auto reload can be achieved with less than 200 lines of code by leveraring bundler's proxy and a simple web server.
Additionally, in my opinion auto reload should not be limited to typescript, but should be made also for tests using the same approach I described above.
Finally, to avoid bundler's lock-in we should avoid providing first-class support just for webpack and rspack, and this solutions seems not to point to that direction.

I will fix the review , because the bundler will help to transform the modern syntax and it can make code more easier to understand, so i usually not use optional chaining . But yes , use modern syntax can make code more concise .

But for rspack/webpack , the reason why i specially process it is because i need to emit the<EMAIL_ADDRESS>to bundler assets , which can work on most bundler assets analyzer plugin.

But for rspack/webpack , the reason why i specially process it is because i need to emit the<EMAIL_ADDRESS>to bundler assets , which can work on most bundler assets analyzer plugin.

Can you argue a bit about this? Sorry I didn't get what you mean

But for rspack/webpack , the reason why i specially process it is because i need to emit the<EMAIL_ADDRESS>to bundler assets , which can work on most bundler assets analyzer plugin.

Can you argue a bit about this? Sorry I didn't get what you mean

The plugin should emit the extra<EMAIL_ADDRESS>to the compiler self filesystem, because most plugin will use compilation.getAssets() to process the assets , such as webpack-manifest-plugin.

But for rspack/webpack , the reason why i specially process it is because i need to emit the<EMAIL_ADDRESS>to bundler assets , which can work on most bundler assets analyzer plugin.

Can you argue a bit about this? Sorry I didn't get what you mean

The plugin should emit the extra<EMAIL_ADDRESS>to the compiler self filesystem, because most plugin will use compilation.getAssets() to process the assets , such as webpack-manifest-plugin.

Got it. But to do so, IMO you don't need any of this code. As I said, using the bundler's proxy and a simple server would be enough

This is not for visit the type archive , is aims to help build analyzer get correct assets in prod environment

@zhoushaw I think that removing the plugin owner from the review is an highly unprofessional behaviour.
How can you approve a PR that:

has some tests removed even if no code base has been changed;
has tons of untested code;
comes without the proper changes to the plugin's README file;
comes with a rollback of the plugin version.

Lots of comments I made have been ignored, but in the end this has been merged anyway, bringing into the plugin lots of crappy code full of eslint-ignore comments.
I don't know if this is your usual way of work, but please stop ruining the work of people who tries to keep high standards.

@ilteoood I feel sorry for this behavior, because Zhang Hang told me that the relevant problem has been fixed, and I saw that the relevant comments have been resolved，It seems that lint rules do not restrict some syntax content, is it possible to adjust lint to automatically handle some non-standard code?

@2heal1 It seems that some of our errors have not been fixed, and I think we should fix this part of the optimization as soon as possible

@ilteoood For code style, I think we can add lint to handle

@ilteoood apologies for this. We will work to rectify this and appreciate your effort, input, and feedback.
I can understand your frustration. In the future we will be more careful regarding input and overwrites to other authored works.
growing pains

https://github.com/module-federation/universe/blob/main/CODE_OF_CONDUCT.md
We will maintain the above code of conduct, If there are violations, I think we can make better improvements. We also reject unfriendly communication methods

I will give some feedback on the points mentioned in this pr：

The test file content has been adjusted and more tests have been added
Rpc file test file missing can be optimized, and test coverage card points can be added later
readme has been tweaked and a new version of the documentation has gone live
The incorrect version will be fixed immediately https://github.com/module-federation/universe/pull/2285

The code style issues with the comments should all have been fixed，This part is best constrained and automated through prettierrc and lint rule sets