TS emit failed with latest release

The build works as expected, but when compilation on save is emited following error is triggered:

The build works as expected, but when compilation on save is emited following error is triggered:

Sorry @tomitrescak. I tried a quick test and it works fine.

Can you share your tsconfig.json ... and are you using extenalTranspiler? (I'm personally not and don't even have it setup) :rose:

Got it. Happens if the file is a .d.ts file ... aka doesn't have a valid js status

Released: https://github.com/TypeStrong/atom-typescript/releases/tag/v7.14.0 have a nice weekend :rose:

I admire your speeeeeeeeeeed :8ball: ;)

I suspect it's possible that the failures with d.ts files might be similar to the issue I'm chasing in #755. @tomitrescak (and @basarat ) when you were experiencing (and reproducing) this bug, were you compiling into your source directory? Or targeting a build directory distinct from your source directory? #755 popped up for me when I was looking at other babel-related code, as well. I will respond to @basarat's request for followup over in that thread now.
By the way, I totally get why reverting the babel thing makes sense for now. Those of us using babel can still use that commit until it's better sorted out. I think there are a few other issues with the babel integration that might as well all get packaged up together properly, rather than trying to piecemeal them as hotfixes to the babel support.

Hi, 7.14.1 is still failing Emit ;( Last one that works is 7.12.0 ;(

  "compileOnSave": true,
  "compilerOptions": {
    "target": "es6",
    "declaration": false,
    "noImplicitAny": true,
    "removeComments": false,
    "noLib": false,
    "preserveConstEnums": true,
    "noEmitHelpers": true,
    "noEmit": true,
    "suppressImplicitAnyIndexErrors": true,
    "jsx": "preserve",
    "experimentalDecorators": true,
    "experimentalAsyncFunctions": true,
    "sourceMap": true
  },
  "awesomeTypescriptLoaderOptions": {
    "doTypeCheck": true,
    "useBabel": false,
    "emitRequireType": true,
    "forkChecker": true
  },
  "filesGlob": [
    "modules/**/*.ts",
    "modules/**/*.tsx"
  ],
  "files": [
...
  ],
  "exclude": [
    "node_modules"
  ],
  "atom": {
    "rewriteTsconfig": true
  }
}

Hi, 7.14.1 is still failing Emit ;(

@tomitrescak I believe the stack trace would now be different. Can you share that please :rose:

Bad news ;( Stacktrace is empty .. no error in console. Only the TS failed to emit error.

ad news ;( Stacktrace is empty .. no error in console. Only the TS failed to emit error.

@tomitrescak I don't have a repro :-/  Also you seem to be the only one suffering from this at the moment. I am open to suggestions :rose:

@basarat I found the culprit, looks like a bug.
My setup is following:

In the root directory I have a tsconfig.json which is pasted below, that takes care of most project files and does not emit any source code
In package subdirectories I have several packages with their custom tsconfig.json which DO emit source into "dist" directory and their content is pasted below.

Removing all other tsconfig.json and leavin only the root one solved the problem. So whenever I need to recompile my package files I return the config to its place and restart Atom.
Here is the secondary config:
{
  "compileOnSave": true,
  "compilerOptions": {
    "target": "es5",
    "declaration": false,
    "noImplicitAny": true,
    "removeComments": false,
    "noLib": false,
    "preserveConstEnums": true,
    "suppressImplicitAnyIndexErrors": true,
    "experimentalDecorators": true,
    "experimentalAsyncFunctions": true,
    "sourceMap": false,
    "outDir": "dist"
  },
  "filesGlob": [
    "*.ts"
  ],
  "files": [
    "helper.ts",
    "parser.ts",
    "scanner.ts",
    "tsc.d.ts",
    "worker.ts"
  ],
  "atom": {
    "rewriteTsconfig": true
  }
}

@basarat GOT IT!
The culprit is the "noEmit": true
With compilation set to some outDir no problems appear.
When I turn on the noEmit rule in any of my projects I receive the TS Emit Failed.
I can reproduce this issue in ALL my projects, please test it if you have time.

The culprit is the "noEmit": true

Wouldn't noEmit explicitly disable any emit? So we shouldn't show the message but the rest is fine? Am I mistaken? :rose:

Yes, you are right. I'm not sure if on-the-fly compilation does the same as compilation on save, but the Emit Failed message should not be shown as it is a bit misleading since compilation is performed just fine.

@tomitrescak I've created a clearer issue report : https://github.com/TypeStrong/atom-typescript/issues/780 :rose:

@basarat I still get TS Emit failed when emit is set to false ;(

@tomitrescak the issue still exits : https://github.com/TypeStrong/atom-typescript/issues/780
I have difficulty wrapping my head around why one would even need noEmit : true? Surely something must be doing the emit and that thing is effectively ignoring the noEmit option. What is that thing? :rose:

My entire build process uses gulp-typescript and gulp-babel... including building the build itself -- so that no particular editor is needed, and so that we can control the streams, etc. etc. It also transpiles itself.
I always run with noEmit: true now.

Cool so gulp-typescript ignores noEmit (https://www.npmjs.com/package/gulp-typescript#options). If all you want is just atom to ignore emit perhaps use compileOnSave: false as a workaround till the issue is fixed :rose:

Right -- difference being that the compile/buildOnSave settings prevent editor from assisting you in typechecking in-window.
I don't actually have an issue with noEmit anymore on my branch, so somewhere in there I think there's a fix (though maybe not an ideal one). I still need to deal with making that into a PR or PRs.
So, I don't need a workaround right now -- I was just chiming in with a reasoning behind wanting to run atom-typescript with noEmit turned on.

@basarat I am running Webpack with ts-loader which is responsible for loading typescript and creating sourcemaps. Thereofre I do not need emission. I need compile on save to have the possibility of typechecks and more.

I need compile on save to have the possibility of typechecks and more.

Typechecks are performed irrespective of compileOnSave (code https://github.com/TypeStrong/atom-typescript/blob/cdc8d9865a0abc8e6ca6bfb7d02e08dec675286e/lib/main/atom/onSaveHandler.ts#L31-L56). Correct me if I am wrong :rose:

I don't know if it is relevant, but I got the same error,
I figured out why I got it, the problem for me was that the d.ts files of the project were included in the tsconfig.json/files section
so I added them to the tsconfig.json/exclude section and it worked out for me:
"exclude": [
"src/**/*.d.ts",
"index.d.ts",
...
]
Hope it helps

In my case, I have resolved TS emit failed message by removing "noEmitOnError": true from tsconfig.json:
{
  "compileOnSave": true,
  "compilerOptions": {
    "noImplicitAny": false,
    "noEmitOnError": true,
    "removeComments": false,
    "sourceMap": true,
    "target": "es5",
    "module": "system",
    "jsx": "react",
    "experimentalDecorators": true
  },
  "exclude": [
    "typings",
    "node_modules",
    "jspm_packages",
    "wwwroot"
  ]
}

The tsconfig.json above is taken from this guide. It works ok in VS2015 but not in Atom.
But, I am not sure whether this is related to this issue.

Any progress on this bug? It's hella annoying.

bug still there so please fix

still there, any ideas whatsup?

I got the same issue, too. Using Atom 1.10.2.

same here, when setting "noEmitOnError": true, I get the 'TS Emit Failed' message when saving even if there are no actual errors.  I can compile the file on the command line with tsc and everything works fine, but not from Atom.

I solved this issue by switching from Atom to VS Code. Atom was sweet, but VS Code is sweeter.


rewrite:run (warns about) failing to download SNAPSHOT parent from local repository

What version of OpenRewrite are you using?
I am using

Maven plugin v5.39.2
rewrite-migrate-java v2.23.0 (shouldn’t be relevant?)

How are you running OpenRewrite?
I am using the Maven plugin, and my project is a single module project with a parent in SHAPSHOT version.
What is the smallest, simplest way to reproduce the problem?
Parent pom
Just install it in your local repository with mvn install.
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>

    <groupId>com.example</groupId>
    <artifactId>parent-pom</artifactId>
    <version>1.0-SNAPSHOT</version>
    <packaging>pom</packaging>

</project>

Child pom
<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0"
         xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
    <modelVersion>4.0.0</modelVersion>
    <parent>
        <groupId>com.example</groupId>
        <artifactId>parent-pom</artifactId>
        <version>1.0-SNAPSHOT</version>
    </parent>

    <artifactId>child-pom</artifactId>

    <build>
        <plugins>
            <plugin>
                <groupId>org.openrewrite.maven</groupId>
                <artifactId>rewrite-maven-plugin</artifactId>
                <version>5.39.2</version>
                <configuration>
                    <activeRecipes>
                        <recipe>org.openrewrite.java.migrate.UpgradeBuildToJava17</recipe>
                    </activeRecipes>
                </configuration>
                <dependencies>
                    <dependency>
                        <groupId>org.openrewrite.recipe</groupId>
                        <artifactId>rewrite-migrate-java</artifactId>
                        <version>2.23.0</version>
                    </dependency>
                </dependencies>
            </plugin>
        </plugins>
    </build>
</project>

I’m running rewrite:run on the child pom.
What did you expect to see?
No warning from the maven plugin.
What did you see instead?
Multiple warnings about failing to download the parent from the local repository. I’m not sure about the impact – parent gets ignored in recipes?
[INFO] --- rewrite:5.39.2:run (default-cli) @ child-pom ---
[INFO] Using active recipe(s) [org.openrewrite.java.migrate.UpgradeBuildToJava17]
[INFO] Using active styles(s) []
[INFO] Validating active recipes...
[INFO] Project [child-pom] Resolving Poms...
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[INFO] Project [child-pom] Parsing source files
[INFO] Running recipe(s)...
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/

What is the full stack trace of any errors you encountered?
With debug output:
[DEBUG] -- end configuration --
[INFO] Using active recipe(s) [org.openrewrite.java.migrate.UpgradeBuildToJava17]
[INFO] Using active styles(s) []
[DEBUG] No rewrite configuration found at C:\projects\maven-tests\child-pom\rewrite.yml
[INFO] Validating active recipes...
[INFO] Project [child-pom] Resolving Poms...
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[DEBUG] Downloaded com.example:parent-pom:1.0-SNAPSHOT from com.example:child-pom:1.0-SNAPSHOT
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[DEBUG] Project [child-pom] Base directory : 'C:\projects\maven-tests\child-pom'
[DEBUG] Project [child-pom]   Collected Maven POM : 'C:\projects\maven-tests\child-pom\pom.xml'
[DEBUG] Project [child-pom]   Maven Source : 'C:\projects\maven-tests\child-pom\pom.xml'
[INFO] Project [child-pom] Parsing source files
[DEBUG] Project [child-pom] Scanned 0 resource files in main scope.
[DEBUG] Project [child-pom] Scanned 0 resource files in test scope.
[DEBUG] Project [child-pom] Parsed 0 additional files found within the project.
[INFO] Running recipe(s)...
[DEBUG] Using SLF4J as the default logging framework
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/
[WARNING] Failed to download com.example:parent-pom:1.0-SNAPSHOT. Attempted URIs:
  - file:///C:/Users/loiseadi/.m2/repository/

Note the Downloaded com.example:parent-pom:1.0-SNAPSHOT from com.example:child-pom:1.0-SNAPSHOT – so it failed successfully?
Also note that there is no warning when parent is not -SNAPSHOT.

This will also happen when using non-snapshot versions not available on configured maven repositories.
I think I found a possible solution for this while writing the unit test for #4607. There, I'm adding the snapshot versions manually to the maven pom cache.
If this is a viable solution, I can submit a PR. Any thoughts, @timtebeek?

This will also happen when using non-snapshot versions not available on configured maven repositories.

The issue here was about a warning emitted when depending on snapshot, which turned out to be because it was trying to retrieve the Maven Metadata with the wrong file name. I think that issue is solved now but I didn’t recheck.
@timtebeek indeed noticed a strange behavior, to which I forgot to reply:

Although in this case it seems a child module is still looking for the parent in ~/.m2/repository as opposed to looking up the <relativePath>../</relativePath>?

In this particular case, it was two separate folders and the parent was not actually located there when I tried this. I should have put <relativePath /> in the child pom (which is the case in our actual projects). I think this behavior is correct, as it matches Maven’s: if the parent pom can’t be found at the (possibly default) relative path, it checks in the repositories (and emits a warning).


Fix building on go 1.21 (by removing RAR support)

This removes rar support, but we aren't using those anyway.

Whoops.

This removes rar support, but we aren't using those anyway.

Now I'm curious how you're using this project :)

This removes rar support, but we aren't using those anyway.

Now I'm curious how you're using this project :)

Pretty much just using butler for its verifying and patching utilities - and ripping out everything else. We're bundling it with another larger program so it doesn't have much to do.
Worked pretty well, ~28k LOCs to ~800 total and size from 20MB to 9.1MB stripped. Using UPX drops it to 2.4MB. I'm happy with that.


Drop several deprecated APIs

Changes
/kind cleanup
Release Note
Drop deprecated addressable resolver constructor.
Drop deprecated controller.New* constructors.

Docs

WIP because I'm using this to find out what needs fixing downstream 😉

broker: will check !
On Wed 25. Aug 2021 at 17:45, Matt Moore @.***> wrote:

Looks like the eventing-kafka-broker update is blocked here:
knative-sandbox/eventing-kafka-broker#1163
https://github.com/knative-sandbox/eventing-kafka-broker/pull/1163
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/knative/pkg/pull/2228#issuecomment-905631700, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AABGPTV6AON3XDMF4ZD7DQLT6UFX5ANCNFSM5CVW3MWA
.

--
Sent from Gmail Mobile

Fix for eventing-kafka-broker https://github.com/knative-sandbox/eventing-kafka-broker/pull/1171

Alright, all of the downstream tests, including Tekton are passing with this, so I think I'm going to pull the trigger on it!  :party-matt:


AKS Deployment auto generated Application Insights URL is giving access denied exception

Hi Team,
Scenario
When deploying a ML model to AKS, in the End point tab, you can see an Application Insights URL auto populated. But by default the URL is pointing to default Microsoft account (@microsoft), not the organization/individual account. Hence Access Denied.
Sample Application Insights URL from AKS Deployment
<EMAIL_ADDRESS>How to Resolve
If you simply remove @microsoft to my organization eg: @tavant in the above URL, then it works.
So i think when creating an Application Insights URL for ML deployment, you need to consider the current organization/individual account also.
Tagging @p-lekkala and @MercyPrasanna. If this issue does not belongs here , please feel free to move it.
Thanks,
Srijith

I don't have access to this project in order to assign to myself but a fix was submitted for this issue (outside of this project) and we should be able to close it.

I'll go ahead and close this, feel free to open the issue again if it persists


Make data_parallel_model Synchronize match behavior of _AllReduceBlobs, _SyncAllParams for single host case

Instead of asserting when calling this function on a single shard use case, early-out if there is only 1 shard. This makes the calling code cleaner because we do not need to branch on the number of shards or the nullity of model._rendezvous; the same API call works for both single host and multi-host cases.

This change was already approved in D7388995.


encoding glitch

In selfie/manuscript/semantics.md.
The symbol -- appears like â€”. However, it is not a markdown error.
Disassembler
: A computer program that translates machine language into assembly language -- the inverse operation to that of an assembler.

Idem in selfie/manuscript/state.md.
A programming paradigm â€” a style of building the structure and elements of computer programs â€” that expresses the logic of a computation without describing its control flow.

Thanks, @cponcelets I just fixed this.


Unable to use ol.Map.call with OL7

Before I use to have:
      OLMap = function (opt_options) {
        /**
        * gets layer of map by layer uid
        * @method getLayerByUId
        * @param {number} layer_uid the UID of the layer
        */
        if (ol.Map.prototype.getLayerByUId === undefined) {
          this.getLayerByUId = function (layer_uid) {
            var layer;
            OLMap.forEachLayerRecursive(this, function (lyr, idx, a) {
              if (lyr.ol_uid === layer_uid) {
                layer = lyr;
              }
            });
            return layer;
          };
        }
        ol.Map.call(this, opt_options);
      };
      ol.inherits(OLMap, ol.Map);

Now, suddenly the following line does not work anymore:
ol.Map.call(this, opt_options);

If you have code which you want to be compatible with both OL7 and earlier versions see the first option in https://github.com/openlayers/openlayers/issues/14032#issuecomment-1222226681  If you want to move to OL7 without backward compatibility use the second option.


Namespace Resource Settings for Quota Override Missing in UI

Issue description:
Namespace quota settings doesn't appear in new UI.
Business impact:
No impact.
Troubleshooting steps:
Create a new Rancher 2.6.2

create a new project and config CPU/Memory Quotas
create namespace into previously created project
namespace quota settings doesn't show up

Repro steps:
Create a fresh Rancher 2.6.2
Create new project and config CPU/Memory Quotas
Create a namespace into previously created project
Workaround:
Is workaround available and implemented? yes
What is the workaround: Namespace quotas settings shows up in old UI. Its possible to config namespace quotas settings accessing the old UI /g
Actual behavior:
Rancher 2.6.1 / 2.6.2 does not show up Namespace quotas settings in new UI
Expected behavior:
Be able to set Namespace quotas settings in new UI
Some backend connection: https://github.com/rancher/rancher/issues/35385
Internal reference: SURE-3584, SURE-3620, SURE-3604

Maybe https://github.com/rancher/dashboard/issues/4412 helps here.

Sounds similar/related to #4597

as of 2.6.3, there is UI for namespace quota settings. however, real quota resource is not updated if namespace quota is changed from UI.

This was resolved in 2.6.3 (which brought in the bug #4804). Just needs some validation from QA and we're good

This should be verified at the same time the fix in #4823 is tested

Verified by installing 2.6.2 rancher and upgrading it to 2.6.3-patch1-rc1

Created a project with resource quotas for config maps and CPU limits set,
Quotas did not show up while creating a namespace.
Upgraded the rancher server to v2.6.3-patch1-rc1
Verified for the new namespaces, resource quotas show up as set on the project.


switch version parsing to use regex

@devoncarew addresses comments in https://github.com/dart-lang/vm_service_drivers/pull/22

lgtm


How to train MixMIL with categorical data?

Thanks for the great work (and congrats for being selected as an oral for this year's AISTATS)!
I'm trying to train a mixMIL model on categorical data.
As I had trouble getting it to work on my own data, I tried it on the "mock" test data. I adapted the code from the mock_data_categorical function in tests (which only initializes a mean model but doesn't train it):
https://github.com/AIH-SGML/mixmil/blob/74b0940e2bee39f0ca2de1d46111608beaa756c3/tests/test_model.py#L17-L23
and wrote my own mock data training script:
from mixmil import MixMIL
import torch

device = "cuda:1" if torch.cuda.is_available() else "cpu"

N, Q, K = 50, 10, 4
bag_sizes = torch.randint(5, 15, (N,))
Xs = [torch.randn(bag_sizes[n], Q) for n in range(N)]  # List of tensors
F = torch.randn(N, K)  # Fixed effects
Y = torch.randint(0, 5, (N, 1))  # Labels for categorical
model = MixMIL.init_with_mean_model(Xs, F, Y, likelihood="categorical")
model.train(Xs, F, Y, n_epochs=10)

However, even with the mock data I run into a runtime error in model.train():

When I print the shapes of the offending scale_u and scale_z, I get scale_u to be of shape [5,10] and scale_z to be of shape [1,10]. Thus we can't torch.cat over dim=1 (since dim 0 is different).
Also, printing the model gives me the following:

I would greatly appreciate any tips to get mixMIL to train on categorical data (e.g. fixes for the above scenario or sample code).
Thanks in advance!
Patrick

Hi,
I encountered the same problem as you did. I think the problem comes from the log_sigma_z having the wrong dimension, since it's (1,1) (from your model print) while I think it should be (1, 5).
Looking into it a bit further, here is where it goes wrong. The first culprit is in the instantiation of MixMIL itself. This isn't exactly a bug, but here the variable var_z is overwritten by the contents of init_params.
https://github.com/AIH-SGML/mixmil/blob/74b0940e2bee39f0ca2de1d46111608beaa756c3/mixmil/model.py#L46
Now the init_params are actually calculated in the utils scripts,  and there is one for Binomial and Categorical distributions. Zooming in on the categorical distribution, we can find the following code.
https://github.com/AIH-SGML/mixmil/blob/74b0940e2bee39f0ca2de1d46111608beaa756c3/mixmil/utils.py#L79
Now if you run this in your example, you will see that both meta_beta and sd_beta will have shape [10, 5]. However, we are then computing a mean over both dimensions, which I think is wrong in this case.
Possible solutions
So I think there are 2 solutions you can use here:

Simply don't use the init_with_mean_model code, and rather start from random weights using the regular init function. or
Adjust the computation of the mean to take into account class dimensions, like so:

    num_classes = mu_beta.shape[1]
    var_z = (mu_beta**2 + sd_beta**2).mean(axis=0).reshape(1, num_classes)

Full disclosure, I don't know if this last solution is correct.

Hi you two,
thanks a lot for pointing this out!
@stephandooper's solution is correct. I have updated the code to fix the bug.
Could you do pip install mixmil --upgrade to see if v0.1.2 fixes the issue for you?
Thanks again!
Cheers,
Jan

Feel free to re-open the issue if it persists!


[SPARK-49839][SQL] SPJ: Skip shuffles if possible for sorts

What changes were proposed in this pull request?
This is a proposal for skipping shuffles for ORDER BY or other sort operations, if on partition columns.
Why are the changes needed?
This could potentially optimize many jobs, where today all data is shuffled even if we have all the partition values and can sort them.  This is a common scenario, for example Iceberg often requests data to be sorted by partition before write , to avoid small file issue.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add test in KeyGroupedPartitioningSuite
Was this patch authored or co-authored using generative AI tooling?
No

cc @sunchao

Thanks for the ping @dongjoon-hyun ! will take a look in the next few days

Merged to master, thanks @szehon-ho !

Thank you for review @sunchao !


Update dataset-panancestry-uk-bio-bank.md

@samuel100

Can you review this PR?
IMPORTANT: When this content is ready to merge, you must add #sign-off in a comment or the approval may get overlooked.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#sign-off


update go-control-plane.

For #6377

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: yangminzhu
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: douglas-reid
Assign the PR to them by writing /assign @douglas-reid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/lgtm
On Wed, Jun 27, 2018 at 4:20 PM Yangmin<EMAIL_ADDRESS>wrote:

@yangminzhu https://github.com/yangminzhu requested your review on:
istio/istio#6684 https://github.com/istio/istio/pull/6684 update
go-control-plane..
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/6684#event-1705122868, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AJGIxgXgeiXj-r9r-UPpeSE5bjNAn0GQks5uBBM7gaJpZM4U6hl5
.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
03cb59548bc7dd6024b9c0b38a27c41507d42339
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@yangminzhu: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
03cb59548bc7dd6024b9c0b38a27c41507d42339
link
/test istio-unit-tests

prow/istio-presubmit.sh
03cb59548bc7dd6024b9c0b38a27c41507d42339
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

New changes are detected. LGTM label has been removed.

@yangminzhu: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-dashboard.sh
e392fb9791fbd55c4c1539d98575eb4b9a2733ea
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov PTAL, I had fixed the build and test, thank you!

/lgtm
On Wed, Jun 27, 2018 at 5:51 PM Yangmin<EMAIL_ADDRESS>wrote:

@kyessenov https://github.com/kyessenov PTAL, I had fixed the build and
test, thank you!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/pull/6684#issuecomment-400876075, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AJGIxt-h8xjQh80VygMg_KMr4KwLe5qzks5uBCiTgaJpZM4U6hl5
.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: kyessenov, yangminzhu
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [kyessenov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Mount ESP Windown Bug in macOS Ventura

In macOS 13, the "Mount ESP partition" window won't close after mounting the partition. The [X} icon to close it also doesn't work.

Okay, received.
However, this will have to wait until I upgrade to 13. I think I will upgrade to 13 as soon as possible, thanks for the feedback.

No problem. It's a minor issue anyway. Users can just move the window out of the way.

It has been updated, please upgrade to the latest version.

Thanks. It works!


Merge async-graphql v3 changes into actix-web-v4 branch

Description of the feature
Congrats on the v3 release! I'd love to use the async-graphql v3 features with the actix web v4 beta.
Can we merge the changes in to that branch or create another branch based off of the v3 release?

The v3 already supports actix-web v4, I'm using both together.

Awesome, if this is already done, I'll close. Thanks @dbstratta


Fix bug where re-rendering react-rating would cause it to reset its value to initalRating

Thanks for taking the time to open up this PR. Could you possibly also open an issue, describing the problem you encountered?

 was getting re-rendered for some reason--I think it was receiving new props. This caused it to receive props again and re-set state.value to initalRating. So you'd click it and it'd call onChange twice, once with the new value and again with the initialRating

@tuckerconnelly Could you check if the new release 1.1.2 solves your re-render issue? I think it was related to #89 and maybe it solves your issue too.

I got this error in release 1.1.2, where it would reset to initial rate if parent was changed. Modified componentWillReceiveProps(nextProps) to
  static getDerivedStateFromProps(nextProps, prevState) {
    return {
      value: nextProps.initialRating
    };
  }

to fix it.
https://reactjs.org/docs/react-component.html#static-getderivedstatefromprops


Display name and avatar changes are considered "x has joined the room"

Probably related to #34

Is there currently any code that checks for the difference between the current and previous m.room.membership state event whenever such an event is received? I haven't checked, but without comparing the current and previous state event (the replaces field in the event), room joins, displayname changes, and avatar changes are indistinguishable.

There's some code, but it appears to not be working
https://github.com/SijmenSchoon/telematrix/blob/master/telematrix/__init__.py#L295-L302


Gulp task sequencing conflicts with Sequelize

Hi,
This is  a cool one. I don't even know if this should be filed under gulp, orchestrator, sequelize or all three, but there' something really weird going on behind the scenes.
The problem is, that a gulp task's callback argument is somehow called automatically before the task is completed. And it throws a "task completion callback called too many times" when the task really ends.
Consider this gulpfile.coffee:
gulp = require("gulp")
gulp.task "test", (cb) ->
  dbconfig = require('./db_config')
  Sequelize = require('sequelize')
  sequelize = new Sequelize(dbconfig.database, dbconfig.user, dbconfig.password,
    dialect: 'postgres'
  )
  sequelize.define "GulpTest",
    id: {type: Sequelize.INTEGER, primaryKey: true, autoIncrement: true}
    name: Sequelize.STRING(100)
  sequelize.sync(force: true).complete (err) ->
    console.log 'sync done', err
    setTimeout (-> console.log('cb()'); cb()), 2000

What i'm trying to do is define a table via sequelize, have it written to the db and then end the task. The setTimeout is only there to make the problem more apparent.
What happens instead is this:
[gulp] Using gulpfile /xxx/gulpfile.js
[gulp] Starting 'test'...
Executing: DROP TABLE IF EXISTS "GulpTests" CASCADE;
Executing: CREATE TABLE IF NOT EXISTS "GulpTests" ("id"  SERIAL , "name" VARCHAR(100), "createdAt" TIMESTAMP WITH TIME ZONE NOT NULL, "updatedAt" TIMESTAMP WITH TIME ZONE NOT NULL, PRIMARY KEY ("id"));
[gulp] sync done null
[gulp] Finished 'test' after 163 ms
cb()
[gulp] 'test' errored after 2.16 s task completion callback called too many times

The callback cb is, for some reason, called immediately in the sequelize's success callback and 2 seconds later my efforts to call it again throw an error.
And what's more, everything works fine if I take the setTimeout out of the callback and execute it in parallel to sequelize.sync.
It's as if the existence of the function call somewhere within the body of the success callback causes it to be triggered immediately.
Using gulp v.3.6.0 and sequelize 1.7.5.
I managed to work around this by returning promises from gulp tasks but I'm a little bit baffled as to how something like this can happen.
I'm not familiar enough with orchestrator, nodejs or sequelize to be able to effectively track the problem myself.
This is also bizarre enough that I'm wondering if it's actually a reproducible issue or just some weird conflict in my dev environment.

sequelize.sync({force: false})
.then(function () {
console.log('Database Synced');
}).catch(function (err) {
console.log('Error Syncing Database: ', err);
process.exit('Exiting... ');
});

@musichen ?
Try again on Stack Overflow :)


Auth: better handling of user status

As originally pointed out by @GiantCrocodile on https://github.com/gi0baro/weppy/commit/e11f6637b9e8b50347f6c07760629b7d4e9429e3#commitcomment-14870341, would be nice to have a better handling of user status (registration_key property of Auth users) in particular:

pending for not activated users when the Auth module is configured with verification
disabled for conditions where users were blocked (bruteforce, unknown IP range, asked deactivation by user, etc.)
blocked intentionally blocked/banned users

Now, pending users needs to activate their accounts in order to perform actions, disabled users need to reset their password in order to activate account again, and blocked can't perform any interaction at all.
Instead of a generic function as proposed here https://github.com/gi0baro/weppy/issues/72#issuecomment-163029482, I would prefer explicit helper methods in Auth module and/or users' rows (virtual methods) to handle all the situations, like:
auth.disable_user(user)  # or id
auth.block_user(user)  # or id
auth.allow_user(user)  # or id
user.disable()
user.block()
user.allow()

I'm curious why the status is called registration_key. It isn't really registration depending. I think this should be renamed when we work out a better handling of this.

@GiantCrocodile is called registration_key because with email validation will be set to a unique token that will be used to send the link for activation to the user. pending status is used only with admin validation. I think the name will remain untouched :)


Look on how to retain older images in case latest is broken

From #62 , we should investigate if we can have old images laying around in hub.
Unfortunately, all images on docker-hub (see: https://hub.docker.com/r/owasp/modsecurity-crs/tags) have just been overridden and it is not possible to pull an older variant. This should definitely be fixed to allow (automatic) rollbacks in case a newer image is broken.

The images have been overridden again and caused an outage of one of our services due to changed behaviour (not yet diagnosed).
This makes the images unusable for any productive scenario.

Hi @arnegroskurth ! Sorry to hear that. We can try maybe adding a timestamp to the images,  like 3.3.2_2022041401. But then "latest 3.3.2" should point to the one with the last date.

We had the same problem on our side - We got cached by the fact, that the underlying Nginx Docker image also changed and the new template paths came in.
May you could also try to decouple the two versions. It should be allowed to add i.e. 3.3.2-134, then you have in the first part the modsecurity version and behind a buildnumber/releasenumber for the Dockerfile.
Or decouple it completely and set your own version numbers and you change the minor whenever the version of modsecurity changes. And then write it into every changelog which modsecurity version is included.
Any solution would help to stabilize the deployment procedure.

Thanks all for the comments again. I will try to do some tests with my personal repos and see if this can be achieved easily.
The solution I'll try is to add a timestamp like nginx-2022041901, etc. Any tag that can be referred to in a static way, and let people control when to update.

I think even though that would already been an improvement from the current situation, it is not really ideal as the update process is much less straight forward with that solution. Semantic versioning is all about categorizing and communicating changes to your software component which is completely gone when you effectively version the component by date. With just a meaningless date as versioning information, I, as a user of the component, have to go through all changes when updating the component to be able to decide whether I also have to change my system due to a breaking change or can rely on the component still function like before. And for what?
So may I ask what your reasoning for that is?

Sorry, the reasoning for the tag, or for updating in general?

For preferring date-strings added to versions from another component (the CRS, I presume), rather then semantically versioning this component independently.

Sure!

In any case, we receive PRs if anyone here wants to help.

A PR is a bit hard while it is not clear in which direction you wanna go.
Personally I think a dedicated versioning for the images is better. This is also the way @arnegroskurth would prefer, when I understood him correctly. But maybe I can show with the following lines how to solve the problem with Github Actions.
Just as an idea 💡.
To reach something like this you could replace the static version in the Github Action with a "dev" flag for example.
https://github.com/coreruleset/modsecurity-crs-docker/blob/79b4c70970baad8c18eb6866c3622b230bb0bc24/.github/workflows/buildimage.yml#L16-L17
Then you can create a new Github Action with more or less the similar content but changed triggers.
In my opinion something like the following example to build only new Github releases:
on:
  release:
    types: [published]

https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
Then in the action itself you could checkout the source from the created Git tag
steps:
    - name: Checkout
      uses: actions/checkout@v2
      with:
        ref: ${{ github.event.release.tag_name }}

And then you can build the docker images with the given tag_name instead of the fixed version as before.
Do not forget to also build and push the latest tag for those guys which want to setup their dev/test infrastructure on latest.
Then every time you want to release a new version you can create a new Github Release in which you can describe which CRS/Modsecurity release was used and then the pipeline would automatically run the release container build/push procedure.
In this way everybody can check the release list and can check if the new release needs some internal changes.
To improve the transparency more, may also consider to not use the latest image from Modsecurity.
https://github.com/coreruleset/modsecurity-crs-docker/blob/79b4c70970baad8c18eb6866c3622b230bb0bc24/nginx/Dockerfile#L1
In that way you will have a commit in which you change the the Modsecurity version to an newer tag.
But maybe that is something you may want to simplify the update procedure - here I don't understand your workflow or why it is on latest per default.
@arnegroskurth @fzipi wdyt? 🙃
To complicated? Or would that help?

Ok, let me think about this for a bit, and will circle back. Using just latest was deprecated because we have "two" latest (one for apache and one for nginx)

Didn't forgot about this, we are kind of overwhelmed with the bugbounty program on CRS these couple of weeks.

Ok, started with something. This is the PR I have for the base docker: https://github.com/coreruleset/modsecurity-docker/pull/140. If you have any comments, please add them there! the idea is to replicate it here in a similar way.

Nice. Thank you.
I this will help to get a more stable setup 👍👌

Changes are live now. Can you test them and see if they work for your use case?


Compatibility Issues Between "React" and "React-OnClickOutside" Libraries.

Our project currently has 'react-onclickoutside': '^6.7.0' installed.
We recently updated our project from 'react': '^16.2.0' to 'react': '^18.2.0'.
However, we have encountered an issue with a component that is wrapped in onClickOutside.
After upgrading to the new version of React, the handleClickOutside function is called immediately after the component is created, without the user performing any action.
When we rolled back to 'react': '^16.2.0', the problem was resolved.
We would like to know if there is a version of 'react-onclickoutside' that is supported by 'react': '^18.2.0'?

I assume you kept the class notation rather than rewriting things to functions with hooks, like the React folks have been pushing for since 16.5?

Hi Pomax,
Thank you for your reply.
I am working on a large project that has been in development for many years. As a result, a significant portion of our components are still written using class notation.

Just making sure. I don't suppose you have a small self-contained example that can be dropped into the issue for testing?

Hi pomax , thank you very much for your willingness to help.
Unfortunately, I was not able to create an example that I could share.
After a long time of debugging, I noticed that during the creation of the wrapped component, it is registered to the event in this line:
document.addEventListener(eventName, handlersMap[this._uid], getEventHandlerOptions(this, eventName));
And immediately after that, the handlersMap function is activated. (The wrapped component is created by clicking on the screen that creates the event)
This is a behavior that also occurs in the old version of React, but for some reason, the event does not happen for the component that was just registered.
Thanks,or

Remember that an example doesn't need to be "your code". If you're seeing it do the wrong thing, it should be possible to create a standalone "new code" setup with a few dummy components that shows things going wrong. (because if you can't, there aren't really any steps to reproduce the problem, which means we can't make a test case)

Hi Pomax,
I've found a solution to the problem. In the constructor of the wrapped component, I save an initTimeStamp.
Then, every time before I execute the logic of the handleClickOutside function in the wrapped component, I check if the timeStamp of the event is greater than the initTimeStamp.
Do you now understand better what is causing the problem, or would you like me to try to create a pull request?"

Anyway, I created a pr

hm, I don't see a PR in the open PR list?

https://github.com/Pomax/react-onclickoutside/pull/396

Im also facing the same issue. Was working fine for React 16.x, migration to 18.2 causes the issue. Im using Class components.

I'm going to have to point at https://react.dev/reference/react/Component at this point though - React is all in on functional components and hooks, whether we like it or not. There is no point in trying to fight that, and functional components don't need this HoC anymore. And I'd be very surprised if they don't flat out remove the Component class in React 19 or 20.

published v6.13.1, but I will reiterate here that if a project relied on this HoC enough for this PR to still be merged in: please read the first paragraph of the README.md and see what you can do.


[v2.7.15] gha migration

Issue:

Problem

Solution

Testing

Engineering Testing
Manual Testing

Automated Testing

Test types added/modified:

Unit
Integration (Go Framework)
Integration (v2prov Framework)
Validation (Go Framework)
Other - Explain: EXPLAIN
None
REMOVE NOT APPLICABLE BULLET POINTS ABOVE

If "None" - Reason: EXPLAIN THE REASON

If "None" - GH Issue/PR: LINK TO GH ISSUE/PR TO ADD TESTS

Summary: TODO
QA Testing Considerations

Regressions Considerations

TODO
Existing / newly added automated tests that provide evidence there are no regressions:

TODO

I was under the impression that GHA only use the workflows defined on the default branch of a repo? So it should already have access to GHA and workflows via our default branch - and I believe that any workflows on non-default branch will be ignored (unless that branch is made the default branch).

@mallardduck Github will use the branch specific workflow, so we do also need it in this branch. I believe that you are somewhat correct in the sense that if I have a workflow in a non-default branch that isn't present in the default branch it won't run on push or similar events, only if manually triggered, but this isn't the case here since we do have the same workflows on the default branch.

Appreciate the explanation @tashima42 TYVM. Learning a lot of new things in the process of our migration. TY again.


Consent options - allow, disallow and ask me should be configurable

Consent options - allow, disallow and ask me should be configurable

To be clear allow/disallow is always on. 😊

Only for AskMe


STL tumbnails with one color

Microsoft PowerToys version
0.67
Installation method
GitHub
Running as admin
None
Area(s) with issue?
Settings
Steps to reproduce
I used to be able to view in my tumbnails, the diferent colors of STL files. now only shows one color for all the files.
✔ Expected Behavior
I was specting to be able to see the independ colors on a stl files
❌ Actual Behavior
I only see one color on any stl file
Other Software
I like to use "Papa’s Best STL Thumbnails" for the tumbnails of my stl files, and be able to preview the diferent colors on the files.
seems that PowerToys is on conflict with its functionin the way that replaces it, and desnt allow me to use the stl viewer I like.

Are you still experiencing this issue? /needinfo


Latest version does not work on Sentry v8.0.5

On my self-hosted sentry:
When my projects do fail, the Slack notification does not work on my channel.  However, when I added the webhook and pressed "Test Configuration" I get the notifications as seen here:
https://i.imgur.com/9b8kTP2.png
I've ensured that the notification settings for Slack and email for the project is enabled, and that it is set to "when an event is seen" and not "when an event is first seen"
Any ideas why as to why it works on testing the configuration but not when a project fails?

I had the same issue, it turns out my workers didn't have the plugin installed (testing from the web used a different python env). Or maybe your workers need a restart.

Out of curiosity, how does this happen? Plugins being installed for web processes and workers? This seems to be a semi-common issue with plugins and workers running different config files, and I'd like to understand this a bit more how this situation even happens and what we could do to help.

My situation was using the docker image, I was using the 8-ONBUILD one. I started the web with the custom requirements.txt in it, the workers accidentally without.
How I installed (fixed) -  https://gist.github.com/erichelgeson/6c2ef4b423d1ea8fac48

Good to know. Thanks. :)
I'm closing this ticket since there isn't much we can do here besides possibly figure out a way to message that the workers are running different plugins/config.

@mattrobenolt I'm having the same problem as @erichelgeson
I have a custom image which is very similar to @erichelgeson script. I am running my sentry worker and sentry beat and the web interface using this image. It shows up in the interface and I can configure it just fine there and the test button sends a notification to slack.
But when an error occurs in any of my applications there is no notification sent to slack.
Any ideas?


SKyBT Testdesigner Examples and concepts

Added the SKyBT testdesigner concept presentations
Added the functional example testcase used to define the interface between testdesigner and testexecution layer

The CI/CD check says that you haven't signed the Eclipse Contributor Agreement (or your Eclipse account isn't linked properly with your GitHub account).
Can you look into this? Otherwise, it's not possible to merge this PR.

I revalidated my account and see the " Author(s) covered by necessary legal agreements" again. Should be fine now.


Add support for microsoft-qc provider

Add support for new microsoft-qc provider.
This new provider, called Microsoft Quantum Computing will contain all future targets for Microsoft's first party quantum offerings. With targets such as:

microsoft.estimator
microsoft.sim.*
microsoft.qpu.*

For now, maintain support for older provider called Microsoft.Simulator (soon to be deprecated) and older targets such as:

microsoft.simulator.*

What exactly is this change for? I don't think there is currently a processor architecture that would fall in this category and the chosen naming convention is also unclear to me. I see that the instruction set and the profile matches the MicrosoftSimulator definition. Why not resolve the processor architecture to MicrosoftSimulator?

This work is to introduce a new target naming convention.
I made a similar comment and suggested this could be handled by resolving the new target names to the MicrosoftSimulator architecture (see here).

What exactly is this change for? I don't think there is currently a processor architecture that would fall in this category and the chosen naming convention is also unclear to me. I see that the instruction set and the profile matches the MicrosoftSimulator definition. Why not resolve the processor architecture to MicrosoftSimulator?

This work is to introduce a new target naming convention.
I made a similar comment and suggested this could be handled by resolving the new target names to the MicrosoftSimulator architecture (see here).

Got it. If this is only about naming conventions for targets, then the only change should be to check if the ExecutionTarget matches the new naming convention and set the ResolvedProcessorArchitecture to the same value as the current naming is set to. There is no need to add anything else.


Update the Custom Rule Creation documentation

In the documentation available at this link, the imports listed at this are not available in the Zally code anymore. Please update the documentation so that readers can correctly understand and work to create better documentation as per the organization.
import de.zalando.zally.rule.api.Check
import de.zalando.zally.rule.api.Context
import de.zalando.zally.rule.api.Rule
import de.zalando.zally.rule.api.Severity
import de.zalando.zally.rule.api.Violation

Thanks.

Those classes are now in package org.zalando.zally.rule.api (instead of de.*).

Thanks. closing this issue.
A recommendation is to please update the documentation.

I'm reopening the issue for updating the documentation. (Feel free to open a PR.)


OpenTelemetry/.NET Diagnostics library implementation for our metric subsystem

Moving from OpenCensus (no longer active project) to OpenTelemetry or .NET Diagnostic library implementations.
Targeting support for : Metric actuator, CLR runtime metrics, Distributed Tracing, and Circuit Breakers events throughout Steeltoe.

#134, #256, #264 we added in 3.0.0.
#276 will be added once the OTel beta/GA is available along with any necessary changes.

Need to update #711 when done with this work.

This is resolved by https://github.com/SteeltoeOSS/Steeltoe/pull/828


Some questions about axis_async_fifo

Dear alexforencich,
when using axis_async_fifo.v in this repository, I met some questions and I'm not sure whether it's just designed for this,  so I want to seek for help for these quesions:
1.if I just write data in this fifo, and don't read→ that means m_axis_tready keep deasserted, in this situation, store_output will assert , and fifo is not empty, so it will perform read, and rd_ptr_reg will continually plus 1 until empty is asserted , but in fact I am not ready to read, these data will be ignored.
2. In this fifo's read logic, it seems that tvalid's asserting depends on whether tready is asserted or not, but axi4s protocol said that 'it's not permitted to wait until TREADY is asserted before asserting TVALID'.
Hoping for you advice for these questions,thanks!

this is fine, the FIFO has two output pipeline registers to improve timing.  This usually gets merged into the block RAM by the tools.  The read pointer will increment until this pipeline is full.  No data will be dropped if m_axis_tready is low.

m_axis_tvalid is directly driven by a register, so there is no combinatorial path.  Also, m_axis_tvalid is set regardless of the state of m_axis_tready (specifically, the condition is m_axis_tready || !m_axis_tvalid ).  Obviously there has to be some dependence so that m_axis_tvalid can be de-asserted when m_axis_tready is high when the FIFO empties.

Now I know that , Sincere thanks to your answer!


scrollUntilVisible should be able to detect SingleChildScrollView and ListView as well

Use case
I am trying to setup a test with a scrollable UI, but my UI has 2 scrollables .
I am using scrollUntilVisible, but the scrollable parameter won't work if I call it like
await tester.scrollUntilVisible(loginButtonFinder, 200, scrollable: find.byType(SingleChildScrollView));

Since SingleChildScrollView is not a subtype of Scrollable, so I need to make a more complex finder in order to get it to work (e.g. find.descendant(of: find.byType(SingleChildScrollView), matching: find.byType(Scrollable))).
Proposal
scrollUntilVisible should be smarter and accept the types of scrollable widgets provided by Flutter.

Could you share a complete sample code?
As mentioned on the scrollUntilVisible docs:

If scrollable is null, a Finder that looks for a Scrollable is used instead.

So you can just pass null into it to see if it works for your case.
I tried checking this with a single scrollable view (ListView) as sample code below and saw it's passed.

Sample code
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';

void main() {
  testWidgets('Scroll test.', (WidgetTester tester) async {
    await tester.pumpWidget(
      MaterialApp(
        home: Scaffold(
          appBar: AppBar(
            title: const Text('ListView'),
            backgroundColor: Colors.blue,
          ),
          body: ListView.builder(
            padding: const EdgeInsets.all(8),
            itemCount: 50,
            itemBuilder: (BuildContext context, int index) {
              return ListTile(
                tileColor: Colors.blue[100 * (index % 9)],
                onTap: () {},
                title: Text('Entry $index'),
              );
            },
          ),
        ),
      ),
    );

    await tester.pumpAndSettle();

    await tester.scrollUntilVisible(
      find.text('Entry 30'),
      100.0,
    );

    expect(find.text('Entry 30'), findsOneWidget);
  });
}

As I said in my post, I have several scrollables.

In case we put scrollable parameter to scrollUntilVisible, the issue also happens when there is only one scrollable view, please check an issue https://github.com/flutter/flutter/issues/90298. And it's marked as a duplicate of https://github.com/flutter/flutter/issues/85046. There is also a case with multiple scrollable views at https://github.com/flutter/flutter/issues/85046#issuecomment-870236218. I will close this to centralize on https://github.com/flutter/flutter/issues/85046 so please follow up on it for updates. Thanks!

Ok thanks, but those don't have the suggestion I am giving here, so I will copy it there.


Make Actions "DumbAware" when possible

Implementing DumbAware makes the action available during indexing (that long process that happens when you start the IDE). As long as the action doesn't access the indices, it can/should implement DumbAware. The problem is that I'm not 100% sure which methods from the API need the indices and which don't, but the good news is that an exception is thrown if the indices are accessed before they are ready :smile:

Originally posted by @nikke234 in https://github.com/Aalto-LeTech/intellij-plugin/pull/126
One should go through our action classes (some others too?), study which of them could/should be "DumbAware" and change the code accordingly.

More information from a comment in the source code of IDEA's API (DumbServvice.java):
 * A service managing the IDE's 'dumb' mode: when indexes are updated in the background, and the functionality is very much limited.
 * Only the explicitly allowed functionality is available. Usually, it's allowed by implementing {@link DumbAware} interface.

 *

 * "Dumb" mode starts and ends in a {@link com.intellij.openapi.application.WriteAction}, so if you're inside a {@link ReadAction}
 * on a background thread, it won't suddenly begin in the middle of your operation. But note that whenever you start
 * a top-level read action on a background thread, you should be prepared to anything being changed, including "dumb"
 * mode being suddenly on and off. To avoid executing a read action in "dumb" mode, please use {@link #runReadActionInSmartMode} or
 * {@link com.intellij.openapi.application.NonBlockingReadAction#inSmartMode}.
 *

...and from IndexNotReadyException.java:
 * Thrown on accessing indices in dumb mode. Possible fixes:
 *
 if {@link com.intellij.openapi.actionSystem.AnAction#actionPerformed(com.intellij.openapi.actionSystem.AnActionEvent)} is in stack trace,
 * consider making the action not implement {@link com.intellij.openapi.project.DumbAware}.
 *
 if this access is performed from some invokeLater activity, consider replacing it with
 * {@link com.intellij.openapi.project.DumbService#smartInvokeLater(Runnable)}
 *
 otherwise, add {@link DumbService#isDumb()} checks where necessary

I suspect ImportProjectSettingsAction could be dumb aware since it only copies files in to the .idea directory and reloads the project

check "Import A+ Module" especially, as this would increase the installation speed of multi-module projects

well, why not... ReplAction.scala ?

and Activity's too :stuck_out_tongue_winking_eye:


Implicit 'it' parameter name

Search Terms
implicit it function parameter name
Suggestion
Kotlin, for example, supports the implicit 'it' function parameter name for functions with a single parameter:
ints.filter { it > 0 }
Not knowing much about the tsc's internals, I would assume a similar syntax applicable to Typescript would be sugar coating something like:
ints.filter(n => n > 0)
where the type of 'it' would be the same as inferred for n. This would of course simply ignore further parameters if they exist in the function signature.
Use Cases
I find that this removes a lot of verbosity from these commonly used expressions and makes code a little bit cleaner.
Not knowing if this is feasible [or even desirable] for Typescript, considering it's not [afaik] on the JS roadmap, I would still love to see it or at least check if someone has any ideas for equivalent syntax that could be applicable to Typescript.
Examples
not entirely sure on how the syntax could work, perhaps:
ints.filter(it > 0) or ints.filter( => it > 0 )
Checklist
My suggestion meets these guidelines:

[X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
[X] This wouldn't change the runtime behavior of existing JavaScript code [it wouldn't]
[X] This could be implemented without emitting different JS based on the types of the  expressions
[ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
[ ] This feature would agree with the rest of TypeScript's Design Goals. [ seems too subjective, not being an expert at recognizing the long term vision of the design goals ]

This would be something for TC39 to add to JS. Please use the Suggestion template.

updated the issue to use the template.


Dev Mode Tab

I see that "Dev Mode" implements some additional styling around the blocks, and it can be controlled via theme support for "flexible-content-dev-mode".
But why is there a tab on all layouts for "Dev Mode"? What's your intent for that?

Hi,
Yeah that feature is, so far, incomplete. The intent is to provide an additional set of custom fields for classes and data-attributes for various elements. I'm putting these on the "Dev Mode" (working title) tab because most projects won't need to change classes or data-attributes per content block, so the tab can stay hidden most of the time, but those few projects that need a parallax background, or whatever, will benefit from the additional settings.
But it's super incomplete at the moment. I basically sketched it out and then went on vacation. I'll be working on it in the next week or so to make it more complete and robust.


Update java-sdk.md

Few code samples contain typos.
A couple of occurrences of the class string  are written with a lower case s, instead of String.
The method main has an uppercase m, it might not be recognized as the main method.
Finally, %d with a float might create an error when formatting a String.

@LoicB : Thanks for your contribution! The author(s) have been notified to review your proposed change.

approved, thank you.
#sign-off


Add better db for local api testing

the element-api relies on firebase / firestore... When testing locally, it should use something that does not require authentication, maybe in memory.
api tests should work for anybody and not require secrets.

fixed in: https://github.com/decentralized-identity/element/pull/30


Hex color support in messages.yml (preferably MiniMessage implementation)

What and How?
Hex color (aka. rgb) support, preferably a MiniMessage implementation in messages.yml.

Why?
Because hex colors are the new way to go, they are much more customizable and not limited to the vanilla colors (e.g. &a).
Also, if you use MiniMessage to implement hex colors, it would have other benefits besides hex colors.
Are there alternatives?
Another way, instead of MiniMessage, to implement hex colors.
Checks

[X] I have used the search at least once to check if my idea has already been suggested and perhaps already implemented.

Anything else
No response

Or is there, by any chance, a way to use hex colors with the already implemented JSON? --> https://github.com/srnyx/annoying-api/wiki/messages-file

Regarding hex codes:
You can use &x&f&f&f&f&f&f, ffffff being the hex code (so &x and then the hex code with & before each character). It's a bit annoying, but all I can offer right now
Regarding MiniMessage support:
Track https://github.com/srnyx/annoying-api/issues/6 for MiniMessage support, as my API is what handles the messages files for all my plugins. I've attempted support before, but it didn't go well, and I'm not really sure if I'll ever add support for it. I experienced issues with PlaceholderAPI and my own placeholders.
Closing this as a "duplicate" so that I only have to worry about the issue on the API's GitHub.


feat: adds geo_allowlist_statement_rules action

what
This adds an action parameter to geo_allowlist_statement_rules objects, replacing the currently-default block action.
why
This is useful for metrics collection on the geo allowlist statements
To allow the user to choose either of the following actions

block
count

references
closes #58

@aknysh, thanks for taking a look. I added the commit. What's next?


Keep showing this error

WARNING: request with non matching host and origin <IP_ADDRESS>:8188 != , returning 403

could you provide a screenshot?

https://github.com/comfyanonymous/ComfyUI/commit/e3b0402bb792c528a8b2fadd11d35604bafc0d7b


Google Chrome error

When trying to do the authentication with chromium, I get the following error. Not sure if it's relevant but it does get stuck there...
[26202:26238:0419/102314.311569:ERROR:browser_gpu_channel_host_factory.cc(120)] Failed to launch GPU process.

#431 My damn router!


Facebook SDK Error

I use Xamarin.Forms, but I do the necessary actions on the iOS side, but Facebook does not verify the update.

Error Message :

I using Plugin Xamarin.Facebook.iOS (4.39.1)

@ufukhawk Are you still facing this issue?

We have not received the requested information. If you are still experiencing this issue, please, open a new issue related to this. Thanks!


Config file for the FreeVC-24 checkpoint

Hi,
The FreeVC model is fantastic! But I got a bad performance when trying the 24kHz checkpoint, is it caused by the wrong config file?

I found these details in the README. Thanks a lot for sharing this model!


Consideration of replicate (Fold change calculation)

Hi, @krassowski
I wonder this repo code consider a replication effect (e.g calculation of significance for case/control difference) on comparison of case/control expression values.
Thank you in advance!
Hyunmin

Hi @hmkim, sorry for the delay in getting back to you - I ust have missed this. Yes, I did consider the significance of the effect size estimate for some of the "scoring functions", notably the functions based on gene sets. I hope it helps!


$CARGO_CFG_DEBUG_ASSERTIONS is set to the empty string in build scripts for both debug and release modes

The following build script will print "" when run with both cargo build and cargo build --release.
use std::env;

fn main() {
    if let Ok(s) = env::var("CARGO_CFG_DEBUG_ASSERTIONS") {
        panic!("\"{}\"", s);
    } else {
        panic!("CARGO_CFG_DEBUG_ASSERTIONS not set");
    }
}

I would expect the CARGO_CFG_DEBUG_ASSERTIONS environment variable to be unset in release mode (where cfg!(debug_assertions) is false by default).
Version info:
cargo 1.30.0-nightly (b917e3524 2018-09-09)

Thanks for the report! I believe this is a duplicate of https://github.com/rust-lang/cargo/issues/5777, so I'm going to close in favor of that.


Issues when listing users of LDAP userstores.

Describe the issue:
There are several UI issues when listing the users in read-only, read-write LDAP userstores.
How to reproduce:

Configure a read-only LDAP userstore.
Configure a read-write LDAP user store.
Add a set of users.
List the users by selecting the user store domain from the drop-down.
Test the pagination

Issue 1 - If it is a read-write LDAP user store the next button does not work even when number of users are higher than page count
Issue 2 - If it is read-only LDAP user store the second page does not work.
Issue 3 - Navigate to the primary user store from the drop-down menu on the second page of the read-only LDAP user-store. The user's list is blank in the primary user store.
Expected behavior:
Pagination and user listing should work without any issues.
Environment information (Please complete the following information; remove  any unnecessary fields) :

Product Version: [e.g., IS 7.0.0]
Userstore: [e.g., LDAP]

Optional Fields
Related issues:

Suggested labels:

Please find the screen record.
Uploading ui_issues.mp4…

https://github.com/wso2/product-is/assets/59342834/b21621ff-070e-4e33-ac1f-717a8aac1e4d


Added Auth-service, restructured to have microservices

https://ece6400triptailor.atlassian.net/browse/TT-58
Moved all services down, under a services directory, deleted the overarching backend go module, and brought the db/models dependencies over into main-service.
Removed backend go module and dockerfile, all services now have their own module / container.
Auth service now launches with docker-compose up, and communicates fine over 8081.

@AbdulTur @WyrdWyn4 Consolidated Waleed's new db/models work into this


Скласти таймлайн

Скласти список всіх (важливих) життєвих подій, визначних дат, досягнень, періодів, що дали приємний і неприємний досвід, тощо. В цьому конкретному випадку довгих списків не буває, натомість бувають погано згорнуті, тому пакуємо сюди все підряд, а про "лишні" події можна буде промовчати пізніше. Список повинен бути систематизованим і посортованим в такий спосіб, щоб читач швидко зрозумів "паттерн" і міг легко орієнтуватись в просторі і часі цього резюме.

Company: Freelance projects, Rivne
Description: Desktop applications based on 1C Enterprise for automated store, manufacture andservices work using data collection terminals. Applications include receipt, transfer, making, sale of goods. Solutions include all business processes and had e-reports.
Involvement duration: 1 year (03.2021 – now)
Project Role: 1C software developer, architector, quality control engineer, project manager.
Responsibilities:
Code, test and debug solutions
Agreement work with the customer
Analyse and description requirements
Implement trading equipment
Technical support
Data exchange with sites
Integrations using API
Work at the exit
Project Team Size: 4-5 persons
Tools & Technologies: 1C Enterprise, REST/API
Company: ERP Data Service Ltd., Rivne
Description: Desktop applications based on 1C Enterprise for automated store, manufacture andservices work using data collection terminals. Applications include receipt, transfer, making, sale of goods. Solutions include all business processes and had e-reports. Customer: Ukrainian companies
Involvement duration: 2.5 years (08.2019 – now)
Project Role: 1C software developer, architector, quality control engineer
Responsibilities:
Code, test and debug solutions
Agreement work with the customer
Analyse and description requirements
Implement trading equipment
Technical support
Data exchange with sites
Integrations using API
Work at the exit
Project Team Size: 2-3 persons
Tools & Technologies: 1C Enterprise, REST/API
Company: Renome-Smart Ltd., Development department, Rivne
Project Description: Desktop application based on the combination of work 1C Enterprise and Drupal
CMS site with API. The solution includes implementation of logistics and accountingprocesses of the companies in the field of banking technologies.
Involvement duration: 6 months (11.2018 - 08.2019)
Project Role: Software developer, architector, quality control engineer
Responsibilities:
Code, test and debug solutions
Write specifications
Development of architecture
Agreement work with the customer
Analyse and description requirements
Implement trading equipment
Technical support
Organization and support CI
Project Team Size: 12-14 persons
Tools & Technologies: 1C Enterprise, XML, REST/API, CI, Python
Company: SoftServe (course "Test automation with Python"), Rivne
Description: Automated tests for REST API service
Involvement duration: 2 months
Role: Junior quality control engineer
Responsibilities:
Analyse and check requirements
Write test cases
Drive scrum planning/daily standup/retro meetings
Code review
Code, test and debug solutions
Tools & Technologies: Python, unittest, ddt, docker, INSOMNIA, jMeter, pylint.
Company: DropZone Boro, Kyiv
Description: skydiving club
Involvement duration: 3 years (01.2018 – 12.2020)
Role: main canopies packer
Responsibilities:
Packing main parachutes
Repair skydiving gear
Team Size: 8-12 persons
Tools & Technologies: skydivding gear
Company: Renome-Smart Ltd., ERP department, Rivne
Description: Desktop applications based on 1C Enterprise for automated store, manufacture andservices work using data collection terminals. Applications include receipt, transfer, making, sale of goods. Solutions include all business processes and had e-reports. Customer: Ukrainian companies
Involvement duration: 2.5 years (06.2016 – 10.2018)
Project Role: 1C software developer, architector, quality control engineer
Responsibilities:
Code, test and debug solutions
Agreement work with the customer
Analyse and description requirements
Implement trading equipment
Technical support
Data exchange with sites
Work at the exit
Project Team Size: 2-3 persons
Tools & Technologies: 1C Enterprise, XML
Company: GRAND (itosvita), Rivne
Description: IT courses for children
Involvement duration: 2 years (05.2014 – 05.2016)
Role: teacher/lecturer
Responsibilities:
Teaching children according to the program
Demonstration and explanation of the material
Checking the completion of tasks
Communication with children and parents
Maintaining documentation
Team Size: 1-2 persons
Tools & Technologies: Office, Databases, programs for working with raster, vector and 3D graphics, video and sound making, etc.
Company: DropZone Voroniv, Rivne
Description: skydiving and gliding
Involvement duration: 5 years (01.2012 – 12.2017)
Role: main canopies packer, flying cameraman, skydiving instructor.
Responsibilities:
Packing main parachutes
Repair skydiving gear
Making video movies for skydivers
Conducting instruction for beginners and sportsmen
Team Size: 5-8 persons
Tools & Technologies: skydivding gear
Education [Bachelor’s Degree]
Certifications 1C Professional (2017)
Rivne State University of the Humanities
Economic Cybernetics
Graduated in 2017 (Diploma with honours)
School-lyceum of Kvasyliv
Graduated in 2013 (Diploma with honours)


Q value does not compute for estimated parameter's high pass characteristics.

JM: 2020-03-20_2_KF
dataset: 2020-03-20_2_final_v8new.xlsx
parameters: ge_mean, depolarizations.

dataset: 2020-03-20_2_drug_final_v8new.xlsx
parameters: ge_mean.

JM: 2020-03-20_7_KF
dataset: 2020-03-20_7_baseline_5pulses_v1.xlsx
parameters: depolarizations, Iactive.

Possible fix: Q formula must be different for high-pass, low-pass and band pass.

Upper and lower cutoffs are now computed using extrapolation if no viable interpolation is possible.
https://github.com/Arikill/analysis/commit/6b5a7d66686a482ec66eec7712e8d6a7ebaa0745


DRA kublet-plugin pod crashes on OpenShift - complains about NVML and prints usage

I'm trying to run the DRA driver on OpenShift.
Here's what I do:

Enable the DRA feature gate
Enable the resource.k8s.io/v1alpha2 API group
Install the NFD operator and let it label the GPU node
Install the NVIDIA GPU operator to have the GPU driver on the node
Build a custom DRA driver image from Dockerfile.ubi8
Label the node

oc label node <node> --overwrite nvidia.com/dra.kubelet-plugin="true"
oc label node <node> --overwrite nvidia.com/dra.controller="true"

Make hostPath volumes work with OpenShift:

Set the security context to privileged
Add the privileged security profile to the service account

Install the Helm chart with the customized driver image
Creat a resource class with driverName: gpu.resource.nvidia.com
Creat a resource claim template with   spec.resourceClassName: gpu.nvidia.com
Creat a pod that runs nvidia-smi -L and has

  resourceClaims:
    - name: gpu
      source:
        resourceClaimTemplateName: gpu-template

Unfortunately, the kubelet plugin pod keeps crashing:
# kubectl get pod -n nvidia-dra-driver
NAME                                                READY   STATUS             RESTARTS        AGE
nvidia-k8s-dra-driver-controller-59d756b8bf-k2bkf   1/1     Running            0               43m
nvidia-k8s-dra-driver-kubelet-plugin-2fn2w          0/1     CrashLoopBackOff   5 (2m23s ago)   6m26s

The log
Error: error enumerating all possible devices: error initializing NVML: ERROR_LIBRARY_NOT_FOUND
Error: error enumerating all possible devices: error initializing NVML: ERROR_LIBRARY_NOT_FOUND
Usage:
  nvidia-dra-plugin [flags]

Kubernetes client flags:

      --kube-api-burst int     Burst to use while communicating with the kubernetes apiserver. (default 10)
      --kube-api-qps float32   QPS to use while communicating with the kubernetes apiserver. (default 5)
      --kubeconfig string      Absolute path to the kube.config file. Either this or KUBECONFIG need to be set if the driver is being run out of cluster.

CDI flags:

      --cdi-root string   Absolute path to the directory where CDI files will be generated. (default "/etc/cdi")

This driver is still in a very early alpha state. I have only ever attempted to run in in a single node context on my local DGX A100 box and nowhere else. We plan to improve it to a beta state by December with proper integration in the GPU operator at that time. Until then it is very much "use at your own risk".
That said, if your issue is related to the plugin not finding NVML, then it is likely due to this:
https://github.com/NVIDIA/k8s-dra-driver/blob/main/deployments/helm/k8s-dra-driver/templates/kubeletplugin.yaml#L72
That is currently hard-coded for my Ubuntu distribution on the DGX A100 that I use. It would likely need to be something different on open shift.

Thanks @klueska! Appending /run/nvidia/driver/usr/lib64/ did the trick.
- name: LD_LIBRARY_PATH
  value: /usr/lib64/:/run/nvidia/driver/usr/lib/x86_64-linux-gnu:/run/nvidia/driver/usr/lib64/

No both pods seem happy, the kubelet plugin pod is running with this in the container log
I0807 14:35:02.967929       1 nonblockinggrpcserver.go:107] "dra: GRPC server started"
I0807 14:35:02.968048       1 nonblockinggrpcserver.go:107] "registrar: GRPC server started"

However, trying to run a pod with a resource claim does nothing - the pod remains waiting, and the resource claim/template is stuck in WaitForFirstConsumer.
I'm running this on a T4 GPU (AWS).

@empovit Sorry this comment may not be related to the issue but do you know how long it takes on Openshift to configure a MIG slice on GPU?

@empovit given that we have updated our driver detection etc to also work with GKE's driver installation, could it be that your problem has also been addressed? (Note that you would have to configure the --driver-root when installing the DRA driver using helm).


⚠ Bofrost.be has degraded performance

In 3b64685, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1910 ms

Resolved: Bofrost.be performance has improved in 6d41674.


Learn about gRPC

https://grpc.io/docs/tutorials/basic/node/

Here is the project I'm standing up to hold this learning.

Done: https://github.com/cujarrett/learning-grpc


Don't import Prelude in the generated Build_doctests modules.

Prelude is a magical module name, and it may be useful for users
to define their own Prelude modules which may not coincide with
the Prelude from base.

What restricts people to redefine Data.Maybe?
I'm very skeptical about redefining Prelude, given where Build_doctest is intended to be used. I'm not against this change but I'm curious what's the setup where this is required?

Data.Maybe isn't magical in the same way that Prelude is. Re-defining Prelude is the only way to bring things in scope without an import. This is less of a problem with doctests because $setup stanzas exist, but it's a configuration I can imagine existing.

@quasicomputational note that the Build_doctest is used to compile doctests test-suite executable, a doctest like executable. It's not the code which doctest ever sees & executes & tests.
You'd need to have contrived:
test-suite doctests
  type:                exitcode-stdio-1.0
  main-is:             doctests.hs
  build-depends:
    -- note: not `base`
    my-better-base,
    doctest >= 0.11.3 && <0.14,
    QuickCheck ==2.10.*,
    simple-example,
    template-haskell

  ghc-options:         -Wall -threaded
  hs-source-dirs:      tests
  default-language:    Haskell2010


chore: remove @[defaultTarget] from checkYaml and runLinter

Could you please edit the commit message of this PR, explaining why it is good to remove @[defaultTarget] ?
bors d+

bors merge


Rebase xrate against release-2.7

Hi!
@free Would it be possible for you to rebase your patch against prometheus/release-2.7 ?
Regards.

I've tried myself but there seems to be a small conflict with the subquery patch and you are far more qualified than me to resolve it.

I have merged the ~2.7.0 master into the xrate branch, just before releasing 2.7.0-xrate. Which is also available as a tag, in case you want the exact code from which the release was made.
It is not a rebase, it's a merge, but I hope that's good enough for your purposes.


Gene Expression e2e Tests Running Longer Due to Multiple Browser Testing

Motivation
Changes from the team helping out with e2e testing Gene Expression has introduced a feature to test across three different browsers (chrome, firefox, edge)
As of writing this, the testing for each browser is being done sequentially
chrome -> firefox -> edge
This ticket is to investigate parallelizing the browser tests so each browser is being run asynchronously.
This might be a playwright config that needs to be set
Definition of Done
e2e tests should run around the same duration as testing one browser.
Tasks

[ ] Reach out to testing team to see if tests can be configured to run asynchronously for browsers

Thanks for catching this! Is this happening locally or GH Actions? Thank you!
Cc: @charles-testco

@charles-testco is addressing this ticket via: #4488 thank you!

@tihuan @ashin-czi Is this ticket closeable?

I think this ticket feels like a duplicate of #4488, so maybe we can close this one and just use #4488 going forward!


Customer feedback - Why STATUS_PRIVILEGE_NOT_HELD

Type of issue
Missing information
Feedback
Given that WU insists on using them I have to write a test program for transactions to test my drivers.  Ugh. Gulp.
My current program is returning STATUS_PRIVILEGE_NOT_HELD from its one call to this function about 4 times in 5 (no change to the program).  My suspicion is that the created transaction lives longer than the process and so and I need to wait for it to exit.  Or something.
Either way the error is frequent enough that STATUS_PRIVILEGE_NOT_HELD seems too important to relegate to the "oh yea and there are other errors" bucket.  (STATUS_INSUFFICIENT_RESOURCES sure).
Thanks
Page URL
https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/nf-wdm-ntcreatetransaction
Content source URL
https://github.com/MicrosoftDocs/windows-driver-docs-ddi/blob/staging/wdk-ddi-src/content/wdm/nf-wdm-ntcreatetransaction.md
Author
@barrygolden

NM.  The code I inherited wasn't initializing the DesiredAccess Field
Close this unless you think its useful.  Have a great festive season

Hi Rod, do you think we should add anything to the page in question?  I note that for the DesiredAccess parameter the page does currently say: "The DesiredAccess value cannot be zero."  Maybe that's enough?

@tedhudek im not sure, but I’m honoured that you asked me.
There’s something oddly specific about the error (not like STATUS_INVALID_PARAMETER for instance), I suspect my broken test program was throwing in an odd bit in somewhere. I guess that if I were you I’d crack open the code and if anything popped out document it, otherwise just close the case and we’ll pretend it never happened.

@tedhudek  I don't know whether this helps, but I got bored and started poking.
It turns out that if you specify a DesiredAccess of 0x01000000 to NtCreateTransaction is says STATUS_PRIVILEGE_NOT_HELD
AFAICS that desired access is ACCESS_SYSTEM_SECURITY so this isn't entirely surprising (I only learned that that was a valid setting for an ACCESS_MASK 5 minutes ago).
You might want to just close this case off a PEBKAC/IIHDDI
Happy new year

@rodwiddowson thanks for the further research. In your original message, you said you got STATUS_PRIVILEGE_NOT_HELD 4 times out of 5.  Were you specifying DesiredAccess of 0x01000000 all 5 times?
I note in the Return value table on https://learn.microsoft.com/en-us/windows-hardware/drivers/ddi/wdm/nf-wdm-ntcreatetransaction that it says you should get STATUS_INVALID_PARAMETER if DesiredAccess is zero, and STATUS_ACCESS_DENIED if the value of DesiredAccess is invalid, but it doesn't address any other special cases for that parameter.
I will poke around a bit internally.
And PEBKAC is quite entertaining when one searches it up, but Bing gives me the International Hip Dysplasia Institute when I look up IIHDDI, likely not what you meant? 😂
HNY!

@tedhudek
HNY!
(If It Hurts, Don’t Do It).
The 4 out of 5 was when my test code was passing an uninitialised variable in to the call so I’m guessing that 4 out of 5 time that bit was set - which is where the Problem Existing Between Keyboard And Chair bit came in.

Hey Rod thanks for the exchange here.  We do have the boilerplate "The routine might return other NTSTATUS values" in the Return value section for that page so I'm going to let that cover this edge case.
We always appreciate your detailed feedback :)


Add HAVING and ORDER BY clauses to Grouping panel

Grouping panel is incredibly useful, but too slow to use. For example:

finding the biggest value returned by aggregate function requires rerunning query twice with different sorting order (two clicks to set descending order)
finding duplicates has a lot more sense with HAVING count(*) > 1 :)

Yep, this makes sense


[material-ui][Menu,Popover] slotProps cannot modify backdrop slot

Steps to reproduce
Link to live example: https://codesandbox.io/p/sandbox/backdrop-slotprops-hyhvct?file=%2Fsrc%2FDemo.tsx
Steps:

Try to set backdrop in slotProps for Menu or Popover components

Current behavior
Hello 👋
I think this is similar to https://github.com/mui/material-ui/issues/38949, but I am unable to set the backdrop slot on the Menu or Popover components - maybe I am misunderstanding, but the BackdropProps prop is deprecated and says to use slotProps.backdrop, but it doesn't seem to work.
Expected behavior
I expected to be able to modify the backdrop props on Menu and Popover components like this:
slotProps={{ backdrop: { style: { backgroundColor: "#fad" } } }}

Context
I'm trying to change the props on the backdrop for Menu and Popover
Your environment
See code sandbox: https://codesandbox.io/p/sandbox/backdrop-slotprops-hyhvct?file=%2Fsrc%2FDemo.tsx
Search keywords: backdrop slot

Modifying the Backdrop works using slotProps.root.slotProps.backdrop instead. See CodeSandbox. The description for the deprecated BackdropProps incorrectly suggests using slotProps.backdrop for Menu and Popover. This only works for the Modal component. Similarly, the BackdropComponent prop should also be updated, as slots.backdrop doesn’t work directly for Menu and Popover—you need to use slotProps.root.slots.backdrop.
To fix this, we could omit the type from ModalProps and redefine the prop to correct the description:
--- a/packages/mui-material/src/Popover/Popover.d.ts
+++ b/packages/mui-material/src/Popover/Popover.d.ts
@@ -2,6 +2,7 @@ import * as React from 'react';
 import { SxProps } from '@mui/system';
 import { InternalStandardProps as StandardProps } from '..';
 import Paper, { PaperProps } from '../Paper';
+import { BackdropProps } from '../Backdrop';
 import Modal, { ModalOwnerState, ModalProps } from '../Modal';
 import { Theme } from '../styles';
 import { TransitionProps } from '../transitions/transition';
@@ -39,7 +40,10 @@ interface PopoverVirtualElement {
 }

 export interface PopoverProps
-  extends StandardProps<Omit<ModalProps, 'slots' | 'slotProps'>, 'children'>,
+  extends StandardProps<
+      Omit<ModalProps, 'slots' | 'slotProps' | 'BackdropProps' | 'BackdropComponent'>,
+      'children'
+    >,
     PopoverSlotsAndSlotProps {
   /**
    * A ref for imperative actions.
@@ -82,6 +86,26 @@ export interface PopoverProps
    * @default 'anchorEl'
    */
   anchorReference?: PopoverReference;
+  /**
+   * A backdrop component. This prop enables custom backdrop rendering.
+   * @deprecated Use `slotProps.root.slots.backdrop` instead. While this prop currently works, it will be removed in th
e next major version.
+   * Use the `slotProps.root.slots.backdrop` prop to make your application ready for the next version of Material UI.
+   * @default styled(Backdrop, {
+   *   name: 'MuiModal',
+   *   slot: 'Backdrop',
+   *   overridesResolver: (props, styles) => {
+   *     return styles.backdrop;
+   *   },
+   * })({
+   *   zIndex: -1,
+   * })
+   */
+  BackdropComponent?: React.ElementType<BackdropProps>;
+  /**
+   * Props applied to the [`Backdrop`](/material-ui/api/backdrop/) element.
+   * @deprecated Use `slotProps.root.slotProps.backdrop` instead.
+   */
+  BackdropProps?: Partial<BackdropProps>;
   /**
    * The content of the component.
    */

Not sure if this is the best solution. cc @DiegoAndai

@ZeeshanTamboli suggestion is the correct fix here 👍🏼

@sydneyjodon-wk Would you like to create a PR?


Email verification page UI change

Distinguish the message to a button
The message "You have been successfully verified, welcome to IDEM" looks like a button. It would be great to change it to plain text.

Not required.  See #538


refact: rename EditableDataframe into EditableDataFrame

I think that goes beyond what we established as a goal (changing what the user sees). Though it's a potential source of confusion/bugs later on, yes. @madeindjs
opinions @FabienArcellier ?

I'm ok with changing everything just not wf-dataframe-update to avoid breaking apps

I think that goes beyond what we established as a goal (changing what the user sees). Though it's a potential source of confusion/bugs later on, yes. @madeindjs
opinions @FabienArcellier ?

I have done the change


Feature information/request

Hi Tomas.  I'm impressed by your integration and videos on the mixergy tank and its integration using the Eddi.  As I will struggle to get an extra spur into my airing cupboard with the tank, I'm considering the Mixergy PV diverter.  I asked for a copy of the API from moxergy to see whether I will be able to control from home assistant when it will divert PV but can't see anything in the code I was sent.  From your expert knowledge of the API, do you know if this would be possible?   Is this something you could add to your implementation?  Thanks!

Hi.
I'm not sure about the Mixergy Diverter I'm afraid. I know the API will report data from the Diverter if installed, but I don't know anything about controlling it. I don't have one myself, so I can't reverse engineer the API.
Tom

Hi Tom
Thanks for the quick reply. I’ll see if I can get someone in the tech support department to talk me through it.  If there is a possibility to control whether the PV diverter is active or not then my next challenge will be to see if Incan fork your code and make the change!  I may need some hand holding if you have time 😀
Thanks
Nick

Hi - another user of the integration has raised a similar issue #32 as they want to turn the PV divert on and off. I'm going to see if we can get this feature added in.

Thanks for investigating Tom. Would be a great help if the feature can be added

PR #34 was just merged in and release 0.7.0 should be available to download. Big thanks to @mattjgalloway again for adding some brilliant new features!
I'll close this issue now - do let me know if something isn't right!

Thanks Tom.  As you say, brilliant news and great features to have added.  Thanks @mattjgalloway !


Error when instantiating Client: java.lang.VerifyError: Bad type on operand stack

When I instantiate the Client class I get the error below. Any idea what the cause of this is?
My setup...
Ubuntu: 16.04
Java: 1.8.0_181
JRediSearch: master branch
Jedis: 3.0.0-20180508
Pool Class: JedisPool
RediSearch: 1.4.0
Redis: 4.0.11
Error output...
2018-09-30 22:03:40,379 ERROR [io.undertow.request] (default task-43) UT005023: Exception handling request to /cqt/searchIndex.do: java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    io/redisearch/client/Client.<init>(Ljava/lang/String;Ljava/lang/String;Ljava/util/Set;IILjava/lang/String;)V @28: putfield
  Reason:
    Type 'redis/clients/jedis/JedisSentinelPool' (current frame, stack[1]) is not assignable to 'redis/clients/jedis/util/Pool'
  Current Frame:
    bci: @28
    flags: { }
    locals: { 'io/redisearch/client/Client', 'java/lang/String', 'java/lang/String', 'java/util/Set', integer, integer, 'java/lang/String', 'redis/clients/jedis/JedisPoolConfig' }
    stack: { 'io/redisearch/client/Client', 'redis/clients/jedis/JedisSentinelPool' }
  Bytecode:
    0x0000000: 2ab7 0002 2a15 05b7 0003 3a07 2abb 000c
    0x0000010: 592c 2d19 0715 0419 06b7 000d b500 062a
    0x0000020: 2bb5 0007 2abb 0008 59b7 0009 b500 0ab1
    0x0000030:

	at com.example.search.Index.<init>(Index.java:24)

Maybe I'm using the wrong Jedis client? There seems to be 3...

https://mvnrepository.com/artifact/com.redislabs/jredisearch-jedis
https://mvnrepository.com/artifact/com.redislabs/jedis
https://mvnrepository.com/artifact/redis.clients/jedis

I'm using the first one (jredisearch-jedis). Is that the correct library? #33 mentions a newer version of jredisearch-jedis than what is in the artifact repo. Do I need to upgrade to that version?

This problem went away after I rebuilt my project from scratch. I think I must have done something to somehow mess up Jedis. idk. I'm going to go ahead and close this.

@ethanhann I'm facing the same issue, In my spring boot 2.2 project, I have added dependency for both artifactories : jedis 2.9.0 and jredisearch 0.20.0. Could you please help how did you resolve the issue?

@bewidsandy notice jredisearch 0.20.0 requires jedis 3.0.1 and above


docs: all HTTP APIs

What's Changed in this PR

merge the HTTP API document from /reference into the HTTP API document in the protocol section.
add all user APIs
close #1097

Preview URL: https://refine-http-api.greptime-docs.pages.dev/nightly/user-guide/protocols/http
Checklist

[ ] Please confirm that all corresponding versions of the documents have been revised.
[ ] Please ensure that the content in sidebars.ts matches the current document structure when you changed the document structure.
[ ] This change requires follow-up update in localized docs.

@killme2008 PTAL


Create viewer bundle jar for standalone run

This is an extension to defect #2, since the viewer requires external jar file, a bundled jar file is required for standalone run of viewer.
May need to setup an another project to resolve this issue.

completed