Running Drone agent on Windows Server 2016

Hi,
Support for Drone Agent on Windows was added in #1330 , however, it is based on an 1803/1809 image.
Windows Server 2016 cannot run a Windows docker container that is based on a newer OS image.
https://docs.microsoft.com/en-us/virtualization/windowscontainers/deploy-containers/version-compatibility
There was a Windows binary release in https://github.com/drone/drone/issues/1330#issuecomment-251129732 but it seems to no longer be updated.
Is it possible to publish updated Windows binaries, or (preferably) Docker tags based on Server 2016 as well as the current 1803/1809 tags? So that Drone Agent can run on a Server 2016 PC?
Thanks

It's not that easy to support all these versions because we need matching build agents for all these versions. So far the project doesn't have the required servers for that to build that automatically.

Is it possible to publish updated Windows binaries

The binary download link is quite old and we are no longer distributing binaries for the project. We only distribute Docker images.

or (preferably) Docker tags based on Server 2016 as well as the current 1803/1809 tags?

We already provide official Docker images for Windows Server 2019 and 1809. See the windows-1809-amd64 tag at https://hub.docker.com/r/drone/agent/tags
I am going to close this as resolved since we already provide an official 1809 agent distribution.


coffeekup cli not working with coffeescript 1.2

Error: Cannot find module 'coffee-script/lib/optparse'
Should be 'coffee-script/lib/coffee-script/optparse' or 'coffee-script/optparse'.  Not sure.  I'm new to npm and node.  Either way the path is wrong.

Getting this too.

a nasty workaround hack:
Note: do a npm update or npm -g update, just to be sure you are up to date (use -g to do a global update)
go to your coffeekup instance (npm -g install coffeekup installs it under /usr/local/lib/node_modules/coffeekup/)
cd lib/
and open cli.js with your fav text editor.
change this line (#7):
  OptionParser = require('coffee-script/lib/optparse').OptionParser;

into
  OptionParser = require('coffee-script/lib/coffee-script/optparse').OptionParser;

works for me. hope it helps someone else as well.

I had run into this problem to. Have it marked as an issue to resolve in my own version that I started since it looks like this one is not being maintained, but installing optparse globally fixes the problem with CoffeeCup which should work jsut like CoffeeKup with a minor name change.  I will be actively maintaining this and addressing issues (hopefully w/ some help)
https://github.com/gradus/coffeecup/issues/2
https://github.com/gradus/coffeecup

This issue is fixed in my clone of coffeekup.
https://github.com/gradus/coffeecup

I don't know how exactly i ran into this problem 3 years later (using only npm packages), but another workaround for this is
cd /usr/local/lib/node_modules/coffee-script/lib
ln -s coffee-script/optparse.js optparse.js


Incorrect documentation: dependsOn is not on the correct level

In the example from the connection-resource-definitions section the dependsOn property is on the wrong level. It is as a child of the properties element, but instead it should be on the root level of the resource definition.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a7e8368e-10de-d0fd-a4e3-cd87300cdb9f
Version Independent ID: e6775253-a8af-8e3c-9708-52777f708648
Content: Overview - Automate deployment for Azure Logic Apps - Azure Logic Apps
Content Source: articles/logic-apps/logic-apps-azure-resource-manager-templates-overview.md
Service: logic-apps
GitHub Login: @ecfan
Microsoft Alias: estfan

Hello @GergoNinacs,
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Hello @GergoNinacs,
Thank you for your feedback! We have assigned this issue to the author to review further and take the next course of action.

Hi @GergoNinacs,
Thanks for reporting this issue! We've created a backlog item and will prioritize based on other work already in the queue.
@ChaitanyaNaykodi-MSFT: #please-close


Create IG Route: /standing-orders

Description
The standing-orders resource is used by an AISP to retrieve the standing orders for a specific AccountId or to retrieve the standing orders in bulk for all the accounts that the PSU has consented to.
Issues related

https://github.com/SecureBankingAccessToolkit/SecureBankingAccessToolkit/issues/114

Route Specifications

read/write API: Account and Transaction
Specification link: GET /standing-orders v3.1.8
Endpoint: /accounts/{AccountId}/standing-orders
Method: GET
API version spec: Standing Orders v3.1.8
API uri: /rs/open-banking/v3.1.*/aisp/standing-orders

Acceptance criteria

[x] Functional tests passed in nightly environment
[x] Functional tests passed in dev environment
[x] Proper response expected by the spec
[x] Errors expected match with the OBIE specs
[x] Route documented

[x] Route source commented
[x] Add the route documentation to the wiki route section

Functionality implemented in: /securebanking-openbanking-demo/blob/master/config/7.0/obdemo-bank/ig/routes/routes-service/12-ob-account-access-multiple-routes.json


Add Everforest Dark and Light theme set

Hi! Thanks to this great tool!
Added these new themes:

Everforest Dark
Everforest Light

This theme is based on: https://github.com/sainnhe/everforest
Screenshots:

Thank you!! Happy new year 🎆


helloworld sample does not run on linux

Describe the bug
i have followed the steps on elementaryos based on ubuntu focal
briefcase dev works, build creates an image but run returns
File "/tmp/.mount_Hello_2X2Dh4/usr/app_packages/gi/overrides/init.py", line 32, in getattr
return getattr(self.introspection_module, name)
File "/tmp/.mount_Hello_2X2Dh4/usr/app_packages/gi/module.py", line 207, in getattr
wrapper = metaclass(name, bases, dict)
File "/tmp/.mount_Hello_2X2Dh4/usr/app_packages/gi/types.py", line 247, in init
register_interface_info(cls.info.get_g_type())
TypeError: must be an interface
types.py:
if isinstance(cls.info, ObjectInfo):
cls._setup_fields()
elif isinstance(cls.info, InterfaceInfo):
register_interface_info(cls.info.get_g_type())
To Reproduce
Steps to reproduce the behavior:

follow the stes
activate virtenv
briefcase create etc
briefcase dev
briefcase build
briefcase run
error in cosole

Expected behavior
see hello world app
Screenshots
If applicable, add screenshots to help explain your problem.
Environment:

Operating System: elementaryos ubuntu 20.04
Python version: 3.8.10
Software versions:

Briefcase:0.3.7
Toga:
...

Additional context
Add any other context about the problem here.

Thanks for the report; this is a manifestation of beeware/briefcase#718; this particular manifestation should be addressed by beeware/briefcase#756.


Indexing error with boolean array

This was reported to me in a side channel
In [1]: import numpy as np

In [2]: import dask.array as da

In [3]: da.asarray(np.ones(1))[np.array([True], dtype=bool)]
   ...:
---------------------------------------------------------------------------
IndexError                                Traceback (most recent call last)
<ipython-input-3-486aaf80dd68> in <module>()
----> 1 da.asarray(np.ones(1))[np.array([True], dtype=bool)]

~/workspace/dask/dask/array/core.py in __getitem__(self, index)
   1326
   1327         from .slicing import normalize_index, slice_with_dask_array
-> 1328         index2 = normalize_index(index, self.shape)
   1329
   1330         if any(isinstance(i, Array) for i in index2):

~/workspace/dask/dask/array/slicing.py in normalize_index(idx, shape)
    781     for i, d in zip(idx, none_shape):
    782         if d is not None:
--> 783             check_index(i, d)
    784     idx = tuple(map(sanitize_index, idx))
    785     idx = tuple(map(normalize_slice, idx, none_shape))

~/workspace/dask/dask/array/slicing.py in check_index(ind, dimension)
    824         x = np.asanyarray(ind)
    825         if (x >= dimension).any() or (x < -dimension).any():
--> 826             raise IndexError("Index out of bounds %s" % dimension)
    827     elif isinstance(ind, slice):
    828         return

IndexError: Index out of bounds 1

In [4]: np.asarray(np.ones(1))[np.array([True], dtype=bool)]
   ...:
   ...:
Out[4]: array([1.])

So I looked into this a bit and it seems fairly easy and the cause is actually in the stacktrace - the check_index function compares x which is the boolean array with the dimension which is a number, so the x array is treated as a 0/1 array. This caused the error above since True has integer value 1 which equals to the length of the array.
This bug also has another manifestation. Since dask just compares the elements to the array length it missed the constraint that the boolean indexing array should have length dimension (see "Boolean arrays must be of the same shape as the initial dimensions of the array being indexed". E.g.,
>>> da.asarray(np.arange(5))[np.array([True, True], dtype=bool)].compute()
array([0, 1])
>>> np.asarray(np.arange(5))[np.array([True, True], dtype=bool)]
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
IndexError: boolean index did not match indexed array along dimension 0; dimension is 5 but corresponding boolean dimension is 2

This should be pretty easy to fix - I can send out a pull request this week if the above sounds reasonable.

A fix would be welcome
On Tue, Jul 3, 2018 at 11:55 PM, WZY<EMAIL_ADDRESS>wrote:

So I looked into this a bit and it seems fairly easy and the cause is
actually in the stacktrace - the check_index function compares x which is
the boolean array with the dimension which is a number, so the x array is
treated as a 0/1 array. This caused the error above since True has
integer value 1 which equals to the length of the array.
This bug also has another manifestation. Since dask just compares the
elements to the array length it missed the constraint that the boolean
indexing array should have length dimension (see "Boolean arrays must be
of the same shape as the initial dimensions of the array being indexed"
https://docs.scipy.org/doc/numpy/user/basics.indexing.html#boolean-or-mask-index-arrays.
E.g.,

da.asarray(np.arange(5))[np.array([True, True], dtype=bool)].compute()
array([0, 1])
np.asarray(np.arange(5))[np.array([True, True], dtype=bool)]
Traceback (most recent call last):
File "", line 1, in
IndexError: boolean index did not match indexed array along dimension 0; dimension is 5 but corresponding boolean dimension is 2

This should be pretty easy to fix - I can send out a pull request this
week if the above sounds reasonable.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/dask/dask/issues/3706#issuecomment-402355895, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AASszMbPyZ4RGqDEEFRI55uMbWfGVmRTks5uDDytgaJpZM4U_LT6
.

This issue seems to be an exact duplicate of #3290 and any fix should resolve these at the same time.


SecretClient getSecret() value returns an URL prompting to select account

Package Name:
@azure/keyvault-secrets
Package Version:
4.3.0
Operating system:
Ubuntu 20.04
[X] nodejs

version: v16.9.1

[X] typescript

version: 4.3.5

Describe the bug
Keyvault secret.value returns an URL, instead of the value:
'https://login.microsoftonline.com/common/oauth2/authorize?response_type=code&client_id=04b07795-8ddb-461a-bbee-02f9e1bf7b46&redirect_uri=http://localhost:8400&state=**********&resource=https://management.core.windows.net/&prompt=select_account'
The remaining properties seem ok.
To Reproduce
const keyvaultName = process.env.AZURE_KEYVAULT_NAME || '';
const keyVaultUrl = `https://${keyvaultName}.vault.azure.net/`;
const credentials = new DefaultAzureCredential();
const secretClient = new SecretClient(keyVaultUrl, credentials);
const {value} = await secretClient.getSecret(process.env.ADOBE_SECRET_NAME || 'adobe-client');
console.log(value);

Expected behavior
Should have access to the value of the secret.

Hi @rafagsiqueira - thank you for reaching out and creating this issue! I'll need to investigate this to try and reproduce the issue. In the meanwhile I have a few questions for you that will help:

I see you are using DefaultAzureCredential - would it be possible to run this same snippet with logs enabled? It might inform us which credential is being used and we can continue from there. Please see instructions for enabling detailed logging for how to enable this. I would recommend setting log level to VERBOSE.
Are you able to authenticate with Key Vault in the azure portal using your credentials? It might be due to an access policy that has not been properly configured

Thanks!


Moved plot-area styling into chart.css

Small tweak, needed to change the overflow style on an example - so moved to CSS

:+1:


Update "broccoli-babel-transpiler" to v6.1.1

Step 1 in resolving https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/issues/89

released as v6.7.0


Fix error handling in filerestorer

What does this PR change? What problem does it solve?
The FileRestorer in internal/restorer/filerestorer.go collects errors for files but does not process these errors.
This is fixed in this PR.
A test case is added which fails without the fix in filerestorer.go
Was the change discussed in an issue or in the forum before?
Found it when testing #3109
Checklist

[x] I have read the Contribution Guidelines
[x] I have enabled maintainer edits for this PR
[x] I have added tests for all changes in this PR
I have not added documentation for the changes (in the manual)
[ ] There's a new file in changelog/unreleased/ that describes the changes for our users (template here) - do we need one?
[x] I have run gofmt on the code in all commits
[x] All commit messages are formatted in the same style as the other commits in the repo
[x] I'm done, this Pull Request is ready for review

I think it would be preferable to integrate the filerestorer into the error handling used in the remainder of the restorer, which uses restorer.Error to inform cmd_restore about problems but which allows to keep on restoring as much data as possible.

restoreFiles is used within *Restorer.RestoreTo which is called directly in cmd_backup.go. RestoreTo does not call restorer.Error but just returns the error (there are many places, not only the call of restoreFiles)...

I think it would be preferable to integrate the filerestorer into the error handling used in the remainder of the restorer, which uses restorer.Error to inform cmd_restore about problems but which allows to keep on restoring as much data as possible.

restoreFiles is used within *Restorer.RestoreTo which is called directly in cmd_backup.go. RestoreTo does not call restorer.Error but just returns the error (there are many places, not only the call of restoreFiles)...

Also rebased to current master.

Also rebased to current master.

I think it would be preferable to integrate the filerestorer into the error handling used in the remainder of the restorer, which uses restorer.Error to inform cmd_restore about problems but which allows to keep on restoring as much data as possible.

restoreFiles is used within *Restorer.RestoreTo which is called directly in cmd_backup.go. RestoreTo does not call restorer.Error but just returns the error (there are many places, not only the call of restoreFiles)...

All parts of RestoreTo which use traverseTree call res.Error for each and every raised error. This makes restoreFiles the only line of RestoreTo whose errors are not prefiltered using res.Error. And res.Error is implemented as follows:
https://github.com/restic/restic/blob/aa0faa8c7d7800b6ba7b11164fa2d3683f7f78aa/cmd/restic/cmd_restore.go#L137-L141

I think it would be preferable to integrate the filerestorer into the error handling used in the remainder of the restorer, which uses restorer.Error to inform cmd_restore about problems but which allows to keep on restoring as much data as possible.

restoreFiles is used within *Restorer.RestoreTo which is called directly in cmd_backup.go. RestoreTo does not call restorer.Error but just returns the error (there are many places, not only the call of restoreFiles)...

All parts of RestoreTo which use traverseTree call res.Error for each and every raised error. This makes restoreFiles the only line of RestoreTo whose errors are not prefiltered using res.Error. And res.Error is implemented as follows:
https://github.com/restic/restic/blob/aa0faa8c7d7800b6ba7b11164fa2d3683f7f78aa/cmd/restic/cmd_restore.go#L137-L141

All parts of RestoreTo which use traverseTree call res.Error for each and every raised error.

Ah, thanks for the explanation, now I got it!
Ok, so I'll extend the fileRestorer such that there is also a Error func to be called and pass the res.Error to the fieRestorer.
And I'll fix #3166.

All parts of RestoreTo which use traverseTree call res.Error for each and every raised error.

Ah, thanks for the explanation, now I got it!
Ok, so I'll extend the fileRestorer such that there is also a Error func to be called and pass the res.Error to the fieRestorer.
And I'll fix #3166.

Ok, so I'll extend the fileRestorer such that there is also a Error func to be called and pass the res.Error to the fileRestorer.
And I'll fix #3166.

Just for completeness: These two changes are included in the commits I have pushed.

Ok, so I'll extend the fileRestorer such that there is also a Error func to be called and pass the res.Error to the fileRestorer.
And I'll fix #3166.

Just for completeness: These two changes are included in the commits I have pushed.

There's also a typo in the issue description: It should be #3166 and not #3116.

Is changed here and in the changelog.

There's also a typo in the issue description: It should be #3166 and not #3116.

Is changed here and in the changelog.


Create some benchmarks

I think it may be getting close to time to promote JuliaImages a bit more heavily. I still have a few things I want to do first wrt cleaning the code base (getting a release of Images.jl out that is compatible with ImageCore 0.9 is high on the list, as is the abs2 issue). But it will take some time to assemble good benchmarks, and I think it's best to do that out in the open so that others can pitch in. @mkitti, you'll note from the README that I'd love to have Fiji benchmarks, is that by any chance something you'd be able and interested to contribute?
FWIW, here's where we are on my machine today:

Note the log-scaling. The "generic" tests (top) are expressed per-voxel, the "specialized" tests (below) are absolute.
Together with OpenCV, we pretty much dominate already (in one case by more than three orders of magnitude), but there are a few exceptions that merit investigation. (That Gaussian blur algorithm in OpenCV is worth emulating...) Missing points generally represent unsupported operations; the "specialized" for OpenCV is still a WIP but they support very little 3d so a lot of points will be missing anyway.
This also doesn't capture some of our other advantages, like scaling to big data. I've been playing a bit with dask but it seems like a pretty far cry from what we offer. scikit-image has a habit of immediately converting everything to a numpy array.

Time for a fun update. This does rely on some stuff that either hasn't been released yet or is still local on my machine:

and one that now combines both kinds of benchmarking:

OpenCV's performance advantage has, on average, essentially been erased, and I believe there is more to come.

I'm assuming things are only going to get better as LoopVectorization becomes easier to incorporate?

Yep. The RGB filtering benchmarks (blur and gradient) still aren't using LoopVectorization. It looks like OpenCV struggles a bit there too, and I think it's possible that a really good implementation may ultimately beat them. Even the grayscale ones could use more work, as my thread utilization is hovering at around 67%, but I haven't taken a close look. But beating Matlab & skimage by an order of magnitude on a lot of benchmarks is already pretty satisfying.

Really want ImageJ benchmarks too, as that's kind of the standard in much of biology.

Would be nice to have ITK benchmarks too, but that's pretty specialized and the last time I used ITK I nearly ripped out my hair.

I checked a decade or so ago when I was still using Matlab and looking to use something faster, and to my surprise Matlab blew it away on most things I tried. That said, it has been a decade...I agree, ITK would be quite nice if at all possible.

I looking into the ImgLib2 (ImageJ2 / FIJI). Another technology to benchmark against is the OpenCL based CLIJ2 which is available as an ImageJ plugin as well as for other platforms (Python, MATLAB) . For ITK, perhaps SimpleITK https://simpleitk.org/ might be appropriate.

I am not sure about Blur in those benchmarks as the Gaussian Blur can be applied in many forms with different balance of quality vs. run time.
But even for working with a simple kernel I can't reproduce the results above on the latest version of Images.jl (Currently 0.25.2).
For instance:
using Images;
using BenchmarkTools;

# Images
mA = rand(RGB{Float32}, 2048, 2048);

# Kernels
mW = Float32.(centered([0.25 0 0.25; 0 -1 0; 0.25 0 0.25])); #<! The Filter

@btime imfilter(mA, mW, "replicate", ImageFiltering.Algorithm.FIR());

I get:
julia> @btime imfilter(mA, mW, "replicate", ImageFiltering.Algorithm.FIR());
  66.387 ms (30 allocations: 96.13 MiB)

On MATLAB:
mA = rand(2048, 2048, 3, 'single');
mW = [0.25, 0, 0.25; 0, -1, 0; 0.25, 0, 0.25];
hF = @() imfilter(mA, mW, 'replicate');
timeit(hF)

I get:
ans =

    0.0113

So MATLAB is faster on my machine.

Thanks for the benchmarks! A few thoughts:

Currently we only multithread separable kernels, and yours isn't. Not a difficult fix and and could be added by anyone, it's just that my own work only requires separable kernels so that's where my own priorities have been.
Using a @SMatrix for the kernel should be a bit better, care to try?
in local tests LoopVectorization makes filtering a whole lot better, esp. for SoA layouts

Just a sample point with a static array:
using Images;
using StaticArrays;
using StaticKernels;
using BenchmarkTools;

# Images
mA = rand(RGB{Float32}, 2048, 2048);
mB = rand(Float32, 2048, 2048, 3);

# Kernels
# mW = @SMatrix Float32.(centered([0.25 0 0.25; 0 -1 0; 0.25 0 0.25])); #<! The Filter
mW = centered(SMatrix{3, 3, Float32}([0.25 0 0.25; 0 -1 0; 0.25 0 0.25])); #<! The Filter
mK = @kernel w -> 0.25 * w[-1, -1] + 0.25* w[-1, 1] - w[0,0] + 0.25 * w[1, -1] + 0.25 * w[1, 1];

# Pre Allocated Results
mAO = Array{RGB{Float32}}(undef, 2048, 2048);
mBO = Array{Float32, 3}(undef, 2048, 2048, 3);

# Planar
@btime begin
    for ii in 1:3
        @views map!(mK, mBO[:, :, ii], extend(mB[:, :, ii], StaticKernels.ExtensionReplicate()));
    end
end

# Packed
@btime imfilter!(mAO, mA, mW, "replicate", ImageFiltering.Algorithm.FIR());
# @btime imfilter(mA, mW, "replicate", ImageFiltering.Algorithm.FIR());

What I get it:
julia>

  13.101 ms (39 allocations: 1.22 KiB)
  59.660 ms (28 allocations: 48.13 MiB)

So I don't see any improvement.
In few minutes I will share the comparison to MATLAB on a separable array.

OK, Here is for a simple separable filter:
using Images;
using StaticArrays;
using StaticKernels;
using BenchmarkTools;

mA = rand(RGB{Float32}, 2048, 2048);

vW = [0.2f0 -0.5f0 0.3f0];
mW = vW' * vW;

vW = centered(vW);
mW = centered(mW);

@btime imfilter(mA, mW, "replicate", ImageFiltering.Algorithm.FIR());
@btime imfilter(mA, (vW', vW), "replicate", ImageFiltering.Algorithm.FIR());

I get ~85 Mili Sec for both (Which makes sense since according to documentation imfilter() checks for separability).
The strange thing is being slower than the previous kernel.
I guess in the previous case it optimized out the zeros coefficients. Could it be?
In MATLAB:
mA = rand(2038, 2048, 3, 'single');
vW = [0.2, -0.5, 0.3];
mW = vW.' * vW;
hF = @() imfilter(mA, mW, 'replicate');
timeit(hF)

I get ~8 Mili Sec. About ~10 times faster and indeed faster than the previous kernel for MATLAB.
By the way, in MATLAB conv2() is even more performant in case one only after the valid part of the convolution.
Something like:
function [ mO ] = Conv2DRgb( vW, mI )

mO = zeros(size(mI), 'like', mI);

for ii = 1:3
    mO(:, :, ii) = conv2(vW, vW', mI(:, :, ii), 'same');
end

end

Will get even faster by ~10%. Though above, for simplicity, I used same.


fix(picker-button): ignore labelView prop for Button

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 1 (100.0%)  changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 80.081%

Totals

Change from base Build<PHONE_NUMBER>:
0.001%

Covered Lines:
7824

Relevant Lines:
8867

💛  - Coveralls


Derive PartialOrd when possible

Fixes #882
r? @fitzgen

This looks good!
We just need some test coverage to land this. Let's add --with-derive-partialord to the // bindgen-flags line for these tests:

tests/headers/derive-hash-template-inst-float.hpp
tests/headers/derive-hash-template-def-float.hpp
tests/headers/derive-hash-struct-with-pointer.h
tests/headers/derive-hash-struct-with-float-array.h
tests/headers/derive-hash-struct-with-anon-struct-float.h
tests/headers/derive-hash-blacklisting.hpp

And then verify that the generated bindings do or don't derive(PartialOrd) as we expect them to.
Thanks!

@pepyakin, BTW, I'm not sure if you're aware that the "impl period" has just begun, but the folks hacking on bindgen during the impl period are hanging out in https://gitter.im/rust-impl-period/WG-dev-tools-bindgen if you want to join us :)

@bors-servo r+
Thanks @pepyakin !

:pushpin: Commit e4a4b47 has been approved by fitzgen

:hourglass: Testing commit e4a4b47f4481f687f9cd88bd95f617784c2108ba with merge 1906a264c1d3b4620d803dd4030750f981b42978...

:sunny: Test successful - status-travis
Approved by: fitzgen
Pushing 1906a264c1d3b4620d803dd4030750f981b42978 to master...

:sunny: Test successful - status-travis
Approved by: fitzgen
Pushing 1906a264c1d3b4620d803dd4030750f981b42978 to master...


Queue Manager security is disabled by default

Enable security, perhaps set UserExternal in qm.ini, and create some auth records.

Removed MQSNOAUT and setup to Developer edition 'admin' and 'app' users.

MQSNOAUT removed.


Mobile not trigger

Hi,
The sticky position working good in desktop but when turn to mobile, is not loading. Is there any setting need to do?
Thanks

Hi,
Try disabling native position sticky usage or alter your layout to be able
to use native position sticky.
On Mon 31. Jul 2017 at 04:20, jcloudsnetwork<EMAIL_ADDRESS>wrote:

Hi,
The sticky position working good in desktop but when turn to mobile, is
not loading. Is there any setting need to do?
Thanks
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/bbarakaci/fixto/issues/51, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtwNDRxspuNBVkKYTtb4DNXhkBk66zYks5sTTnogaJpZM4On1Pw
.

Hi,
Thanks. I will try it.


Dealing with intendedFor and "file dependencies"

So I would not necessarily think this is needed for events but definitely, we need a way to deal with the intendedFor for fieldmaps, especially that it is being reused for other data types as well (ASL, PET...) .

@nbeliy
The new PR for ASL seems to incorporate the idea you had for "file dependencies" as aspects of ASL includes the "intendedFor" field
See PR #127 and also the code here: https://github.com/ExploreASL/bids-matlab/blob/6cba2ee686fc26fb9b182f6a50a99ae15a0a11fa/%2Bbids/layout.m#L481
I would suggest that we start small and tackle first those "explicit" dependencies covered by the specification before we move on to those that are more use case dependent.
What do you think?
Originally posted by @Remi-Gau in https://github.com/bids-standard/bids-matlab/issues/122#issuecomment-774021374

from @nbeliy

I would suggest that we start small and tackle first those "explicit" dependencies covered by the specification before we move on to those that are more use case dependent.

In my idea dependency is to revert IntendedFor. A fmap image do not have a value by itself, and it is not that important to know for what scan it was taken. But for a given scan it is important to have an associated fmap. Actually it would be nice to have it in BIDS itself, but I guess is too late.
From technical point of view, it can be done at the end of layout function. Just scanning all images for IntendedFor field, and adding found files to corresponding scans.

I agree that this makes more sense when using the data indeed.
@HenkMutsaerts what do you think?


adding getter for an excel file (ONS)

Description
This PR explores the salary ojo output, and creates tests to:

Check for internal consistency
Create a merged file of the fields needed to check OJO salary against ASHE, and save to S3
Check against 2023 ASHE data

Fixes # 18 (salary EDA)
Instructions for Reviewer
You can run the internal tests from your root folder by running:
python -m dap_job_quality.pipeline.salary_internal_tests>
The OJO file takes some time (40 mins) to create, so I'd suggest you just read through the code, but if you want to test it you can run:
python -m dap_job_quality.utils.create_df_for_salary_analysis
The ASHE comparison is currently a notebook, to check it download the notebook and explore:
dap_job_quality.notebooks.Salary_comparison_ASHE.ipynb
Please pay special attention to ...
Checklist:

[ ] I have refactored my code out from notebooks/
[x] I have checked the code runs
[x] I have tested the code
[x] I have run pre-commit and addressed any issues not automatically fixed
[x] I have merged any new changes from dev
[x] I have documented the code

[x] Major functions have docstrings
[ ] Appropriate information has been added to READMEs

[x] I have explained this PR above
[ ] I have requested a code review

Thanks for your comments @RFOxbury! I've addressed them all, and moved the files to a sub-folder in pipeline.
I had to change the internal tests a fair bit to export a list of errors (but I think it was worthwhile), do you mind looking through it again? Please tell me if I've missed something, your edits looked much cleaner I just couldn't make them work on a pandas df (and thought the cost of moving from running at test on an array to each one individually seemed high).

Thanks for your comments @RFOxbury! I've addressed them all, and moved the files to a sub-folder in pipeline.
I had to change the internal tests a fair bit to export a list of errors (but I think it was worthwhile), do you mind looking through it again? Please tell me if I've missed something, your edits looked much cleaner I just couldn't make them work on a pandas df (and thought the cost of moving from running a test on an array to each one individually seemed high).

Hey @cmbrennan002 ! This looks good - I think it's nice that you now save a file of job IDs where the salary conditions aren't met. Happy for you to merge!


Can't connect to mariadb

Hello,
I can't make mariadb work with laradock v5.0.3, with stock docker-compose.yml  and  .env
It works with mysql throug adminer (host: mysql, port: 3306, root/root)  and inside the mysql container.
But i can't connect to mariadb from adminer : (host: mariadb, port: 3306, root/root)
SQLSTATE[HY000] [1045] Access denied for user<EMAIL_ADDRESS>(using password: YES)
And even inside the mariadb container :
$ docker-compose exec mariadb bash
root@88cf42a7d05e:/# mysql -uroot -proot
ERROR 1045 (28000): Access denied for user 'root'@'localhost' (using password: YES)

MariaDB container log :
mariadb_1             | 2017-04-03 19:25:16<PHONE_NUMBER>04448 [Note] Server socket created on IP: '::'.
mariadb_1             | 2017-04-03 19:25:16<PHONE_NUMBER>04448 [Warning] 'proxies_priv' entry '@% root@077c23180bc8' ignored in --skip-name-resolve mode.
mariadb_1             | 2017-04-03 19:25:16<PHONE_NUMBER>04448 [Note] mysqld: ready for connections.

Any idea to fix this ?
Thanks for your help!

Within the dotenv file, you can still use the MARIADB_USER user and password. I'm having the same issue with the root user. There seems to be a problem in the config file: https://github.com/laradock/laradock/blob/master/docker-compose.yml#L207

Closed #737 by @winfried-van-loon. Thanks,

@Mahmoudz I'm afraid it was only part of the solution, with the fixes included I wasn't able to actually connect. Could you give it a try?

Maybe the issue is due to the volume ?
The same volume are mounted on the host machine ?
/var/lib/mysql

Well, the "default" user does work, so I doubt it's in the network or connectivity of the volumes. I've checked the docker-compose.yml for related issues, haven't found any. Good idea, though!

May be related to https://github.com/docker-library/mariadb/issues/21 and a possible temp solution could be to reset the root user password until we find the real problem&solution: https://github.com/docker-library/mariadb/issues/99

Yes we need to reset the mariadb volume for sure

You're right. After removing everything, it worked. Apparently I didn't remove everything in my last test. Thanks for your help @vitoo

Great, so it's fixed now


Make it clearer which assertion fails

It is almost impossible to determine this without adding custom strings manually. We should fix this somehow.

The best thing would probably be to somehow include a stack trace.

So maybe just the line. But the issue is that it should also work with CoffeeScript.

We might want to use stacktrace.


test(toggle): enhance test coverage

Closes #1065
Description

Add a brief description

Added new tests for the ToggleGroup component to cover various scenarios and edge cases.
Enhanced existing tests for the Toggle component

With these additions and improvements, the test coverage for the @yamada-ui/toggle package has reached 100%.
Is this a breaking change (Yes/No):
No

Thanks!


Emsdk 3.1.47

As per emscripten-core/emsdk#1292, the LTO folder cannot be shared between emsdk versions.

Waiting on https://github.com/bbrk24/Trilangle/actions/runs/6661625894/job/18104763214

It didn't grab the version correctly...? The key is showing up as merely libsv-.

New job: https://github.com/bbrk24/Trilangle/actions/runs/6661673656/job/18104881517

I cancelled it on purpose, I only needed to see it compile.


[Bugfix] _add_filters_from_pre_query doesn't handle dim specs

Ok this should address the underlying issue behind https://github.com/apache/incubator-superset/issues/3943. _add_filter_from_pre_query_data wasn't at all handling dimension specs. Also added some better error checking on modifying dimension specs.

Thanks @Mogball for taking a look at this. I just applied the patch and tested it out. I now get "No data was returned" instead of the exception. If I click on View Query it only shows the first phase of the query and not the second. When I run that query directly against druid, I get results for the topN.

@ghulands Thanks for letting me know. I removed a condition thinking Druid handles single "dimension" specs but I think I was right before. Checkout the change and let me know if it's working.

Could you post logs from running these queries? (And it's still just doing 1 phase right?)

Yes, it's still only running 1 phase. I edited the log to reduce the map size of the dimension.
2017-12-01 19:07:43,675:DEBUG:root:[stats_logger] (incr) explore_json
2017-12-01 19:07:43,764:DEBUG:root:[stats_logger] (incr) loaded_from_source
2017-12-01 19:07:43,784:INFO:root:Running groupby query for dimensions [[{u'outputName': u'prettyName', u'extractionFn': {u'outputName': u'dimensionOutputName', u'lookup': {u'map': {u'Code1': u'PrettyName1', u'Code2': u'PrettyName2'}, u'type': u'map', u'isOneToOne': False}, u'retainMissingValue': False, u'type': u'lookup', u'replaceMissingValueWith': u'missing_value', u'dimension': u'dimensionName'}, u'type': u'extraction', u'dimension': u'codeName', u'outputType': u'STRING'}]]
2017-12-01T19:07:43.784623+00:00 orchardapp710899[app_siri-ops_siri-superset-prod.web.v34]: 2017-12-01 19:07:43,784:INFO:root:Running two-phase query for timeseries

@ghulands
Okay I think I figured it out. Extraction functions that change the name of dimension values (in your case, mapping from a code to a name) cause issues with the two-phase query because it builds additional filters from output values (which are different from the original values). _add_filters_from_pre_query will ignore extraction functions. Give it another go.

Hi @Mogball, This now works! Thanks so much for the quick iterating on it.

@fabianmenges RFC on this solution
For two-phase queries, would it be better to remove extraction functions from pre-queries (and just use the dimension name) and add them back for the final query?

I think it makes sense to strip the pre-queries (phase 1 queries) from the extraction functions since they will only change how data is dispalyed and pre-queries won't be displayed.

Should we replace any elements in qry['dimensions'] that are dimension specs with dim_spec['dimension'] (on which they operate) for pre-queries?

Hi, i am facing the same issue.On running single custom dimension i get the following error:
KeyError: u"None of [[u'outputName', u'extractionFn', u'type', u'outputType', u'dimension']] are in the [index]"
Can you specify which version of druid to use? and what is the fix? @Mogball does your fix solve this?

What version of superset are you using? I think this is in version 0.21.0

Does 0.21 solve both the mentioned problems?
I am using 0.20.
Extensions are non filterable.And single extesion dimension is non
groupable.Any reason why topN query doesnt work on superset for single
extension dimension?
Same works if i hit the same query on druid.

I'm pretty sure those issues we're ironed out by then. Give 0.21.0 a try

Hi @Mogball that was great help.I am now able to group the custom dimensions as well as view them on charts.
Do we have any update/workaround for filtering the same custom extension.I am able to only filter them through Result filters only.

Not sure about that. Make an issue if there isn't one already.


Forge test runs get killed

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (4b9cca1 2022-09-03T00:07:00.132143504Z)
What command(s) is the bug in?
forge test
Operating System
Linux
Describe the bug
When I run my tests with the latest Foundry version, my tests get killed locally as well as for GH actions. You can reproduce the bug by cloning my repo here and run forge test.
An example failed action: https://github.com/pcaversaccio/snekmate/runs/8168667052?check_suite_focus=true

Locally it looks like that:

Seems to be related to a memory allocation issue, but not an expert.
As comparison, I used an older foundry version (forge 0.2.0 (fb1f0aa 2022-08-29T19:50:24.7749584Z)) for which the tests worked. So there has been a bug introduced in the meantime I guess.

137 is OOM. looks like a duplicate of #3067, is that right @shekhirin?

@rkrasiuk yep, looks like that

closing as duplicate. @pcaversaccio will free to follow up in #3067

having same issue with exit code 129


Cordova installation on OSX

Trying to install Ionic CLI on a Mac Air with El Capitan and export my project.  I keep doing the command to install Cordova:
sudo npm install -g cordova
.. and while it indicates that Cordova is getting installed (I run "cordova --version" and it comes back with "6.1.1", after installing Ionic (sudo npm install -g ionic) I keep running the “ionic info” command and it says that Cordova CLI is not installed.
Do I have to configure the $PATH in a certain way to have the Cordova installation recognized?

Hello! Thanks for opening an issue with us! As this issue is related to the Ionic CLI and not the framework I will be moving this issue to that repo. Thanks for using Ionic!

This issue was moved to driftyco/ionic-cli#1018


Add training mode checking to extract vision models (ResNet, VGG16, GoogLeNet).

Fixes #3210

Thanks for the PR.
During the discussion of #3210, we concluded that we should not change the behavior nor emit warnings, because (as you stated in the issue) this may be a false warning in some cases.
Could you update the docs?

Updated. Could you review it again?

@delta2323 ping? (I can takeover if you don't have time.)

Sorry, I think I can work on it tomorrow. If you cannot wait it. Please feel free to take it over.

LGTM! (will merge after CI pass)

LGTM.
AppVeyor failure seems unrelated to this PR.

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

@kmaehashi This pull-request is marked as to-be-backported, but the corresponding backport PR could not be found. Could you check?

Jenkins CI test (for commit a86738dff041d6a5668d27697196ac75d91a5ace) succeeded without errors!


Vision models need to be tested

predictor.list_models() results in a bunch of models, but it is not specified, which one corresponds to which task. Can all of these models be used for all of the tasks? or there is some specificity. By task, I mean classification, segmentation, detection and regression etc.
Some models are missing pretrained weights such as se_resnet some have shape issues such as resnest101.
I believe each model needs to be tested one by one. I tried to write a script, but I am not sure how to clear the memory of the previous model from gpu, disk and ram.
working,not_working,error,times=[],[],[],[]
from time import time
for model in modellist:
  try:
    start=time()
    predictor = ImagePredictor(verbosity=0)
    predictor.fit(train_dataset,tuning_data=test_dataset,hyperparameters={'model':model,'epochs':1})
    working.append(model)
    end=time()-start()
    times.append(end)
  except  Exception as e:
    error.append(e)
    not_working.append(model)

Having per-PR based CI to run each configuration is not possible, as it might take longer than days to do so. A monthly check sounds like a more reasonable solution.


Error in documentation?

Documentation has https://int80k.com/libuvc/doc/group__streaming.html#gaf6468bf85a6796d365dd6296f65ae935
uvc_error_t uvc_stream_get_frame	(	uvc_stream_handle_t * 	strmh,
uvc_frame_t ** 	frame,
int32_t 	timeout_us
)
Poll for a frame.

which matches the header file for version 0.0.6. However the documentation continues on to describe the first parameter as a device not a stream:
Parameters
devh	UVC device
[out]	frame	Location to store pointer to captured frame (NULL on error)
timeout_us	>0: Wait at most N microseconds; 0: Wait indefinitely; -1: return immediately

parameter strmhp is not documented:
uvc_error_t uvc_stream_open_ctrl	(	uvc_device_handle_t * 	devh,
uvc_stream_handle_t ** 	strmhp,
uvc_stream_ctrl_t * 	ctrl
)
Open a new video stream.

Parameters
devh	UVC device
ctrl	Control block, processed using {uvc_probe_stream_ctrl} or {uvc_get_stream_ctrl_format_size}

parameter user_ptr is not documented:
uvc_error_t uvc_stream_start	(	uvc_stream_handle_t * 	strmh,
uvc_frame_callback_t * 	cb,
void * 	user_ptr,
uint8_t 	flags
)
Begin streaming video from the stream into the callback function.

Parameters
strmh	UVC stream
cb	User callback function. See {uvc_frame_callback_t} for restrictions.
flags	Stream setup flags, currently undefined. Set this to zero. The lower bit is reserved for backward compatibility.


Use phive instead of polluting dependencies

Description
Clean up and remove unneeded deps.
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:

[ ] Tests pass
[ ] Created/updated tests
[ ] Extended the documentation

Codecov Report

Merging #103 (eeed935) into main (782eb94) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #103   +/-   ##
=========================================
  Coverage     78.20%   78.20%
  Complexity      499      499
=========================================
  Files            63       63
  Lines          1606     1606
=========================================
  Hits           1256     1256
  Misses          350      350

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782eb94...eeed935. Read the comment docs.


Stopped working. No icons at all

It stopped working today. No icons appear.
v2.7.1 on Firefox (Nightly) 116.0a1

The Release and Artist pages should be fixed in v3.0


the content is now inside the div and perfectly aligned.

Issues Identification
Closes: #1015
Description
the issue was that the content inside the div at testimonial page was coming out .
Summary
i just changed the each div css  padding to 1rem 1.5rem thats all.
Details
it was an amazing experience working with your project..
Types of Changes
Please check the boxes that apply

[x] Bugfix (non-breaking change that fixes an issue)
[ ] New feature (non-breaking change that adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation update (Documentation content changed)
[ ] Other (please describe):

Checklist
Please check the boxes that apply

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] My changes do not break the current system and pass all existing test cases
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

Screenshots

everything is perfectly aligned and content is inside the div.

@2004pra will it be okay for you, if i give you no level label .
if i assign you level 1 then there will be some issues from my side. as a project admin and program manager reviews all this PR's and it's a clear instruction.
so please understand.
will it be okay for you.
As this PR's and issues are reviewed by program manager

@2004pra will it be okay for you, if i give you no level label .
if i assign you level 1 then there will be some issues from my side. as a project admin and program manager reviews all this PR's and it's a clear instruction.
so please understand.
will it be okay for you.
As this PR's and issues are reviewed by program manager

please give atleast level 1 sir

please ..  as its my last contri to your website ....

see @2004pra i can see only 1 minor change, before and after.
if i give you level 1 then The program manager will complaint against me.

see @2004pra i can see only 1 minor change, before and after.
if i give you level 1 then The program manager will complaint against me to the organisers.

will i get any points with no level

you won't get, but this Pull Request will be listed on the leaderboard.

gssoc program owner also did a minor change but he assigned himself with level 1 when he was describing how to contribute

@2004pra can you share me that PR link.

gssoc program owner also did a minor change but he assigned himself with level 1 when he was describing how to contribute

@2004pra can you share me that PR link.

gssoc program owner also did a minor change but he assigned himself with level 1 when he was describing how to contribute

it was when he did while explaining how to contribute in gssoc extd 24 video of 42 minutes  i dont know the pr link though

@2004pra anyways i will assign you the level 1 label.
but afterwards if the program manager asks me regarding this
then i have to answer about this.

https://www.youtube.com/watch?v=QQkj44nYqpU&t=1073s        see this video from   18:00 you will see he just change the readme  email text  to his own email and set level 1

@2004pra anyways i will assign you the level 1 label.
but afterwards if the program manager asks me regarding this PR.
then i have to answer about this.

ya you can ask me i will talk to him  it will be okay

Okay then @2004pra i will assig you the level 1.
i am merging this PR.

Okay then @2004pra i will assig you the level 1.
i am merging this PR.

thanks brother .....

@2004pra thank you for contributing to ML Fusion lab.
And again sorry from my side if i had troubled you. 😭
because i have to follow the rules, so that's why i am saying like that. 😭😭


feat: add support for custom actions

Status
READY
Description
Add support for custom actions, this will allow us to implement #3, #4, #5, #71
Closes #11
Type of Change

[x] ✨ New feature (non-breaking change which adds functionality)
[ ] 🛠 Bug fix (non-breaking change which fixes an issue)
[ ] ❌ Breaking change (fix or feature that would cause existing functionality to change)
[ ] 🧹 Code refactor
[ ] ✅ Build configuration change
[ ] 📝 Documentation
[ ] 🗑 Chore

Hey @Thithip you mentioned in #122 that you would love to help out, well this PR is now ready for reviews so if you are up for it I would love to have an extra pair of eyes!

Hey @Thithip you mentioned in #122 that you would love to help out, well this PR is now ready for reviews so if you are up for it I would love to have an extra pair of eyes!

Sure, I'll review this huge refacto!


Add basic controls to the player

This PR adds basic players controls, which addresses issue https://github.com/englishm/moq-js/issues/7.
We're adding a play button, volume button and track selector, replacing the controls that had been sitting below player. Each control is now its own component, and we attempted to move some logic relevant to these new components out of watch.tsx and to the respective component files.

To test these changes:

[ ] The play button should resume audio (we will add play/pause functionality when https://github.com/englishm/moq-js/pull/9 is merged)
[ ] The volume button should handle toggling mute
[ ] The track selector button should open a menu with available tracks, and selecting a track should update the current video track

Additionally, I renamed usePlayer to player in watch.tsx. I think this is a positive change because:

it's idiomatic to name signals after the value they represent (player, setPlayer)
‘use’ is commonly associated with React hooks
it reads as a direct reference to the player

All feedback is welcome!

It's really nice to see some UI elements here! Thanks!
I'm afraid I set up a merge conflict for you when I merged the play/pause PR. Sorry!
You may also be interested in some of the discussion on  https://github.com/englishm/moq-js/issues/4, in particular regarding what Web Components might allow us to do for the UI.
I would like to the move in the Web Component direction in the long run, but since that requires some refactoring work first, I'm happy to accept PRs that add UI elements like you have here in the meantime. Hopefully some parts of that work can be ported or re-used to a media-chrome model.

@englishm No problem at all! Conflicts are resolved, and play/pause functionality has been added to the play button, since the PR to add that functionality has been merged.
Thanks for sharing that discussion. I will keep this direction in mind as this project continues (and hopefully contribute, as well)!
Appreciate you taking a look at this one.

Tested, works!
One minor issue I notice is that sometimes there seems to be a brief delay in responding to clicks, but I think that may be unrelated to these changes and it isn't a major issue so I'm not going to worry about it right now. (I wonder if it might be related to how we're waiting on keyframes?)
Thanks for this, @christriants! I'll merge and then we can start looking at @JoaquinBCh's refactor and switch to rollup, etc. 😁


profiling: mapping of script-local/anonymous functions to scripts

It is currently not possible to map a FUNCTION from :profile output to a SCRIPT reliably.
https://github.com/Vimjas/covimerage has some magic where it compares the actual function's body, but that does not work for when the functions are the same.
The following it the :profile output for when there is a function s:function being used both in the "plugin" and an "autoload" file.
I think it would be good if the "SCRIPT" header would contain the SNR, which is also used with the functions ("<SNR>12").
Maybe "SCRIPT  tests/test_plugin/duplicate_s_function.vim" could be changed to read "SCRIPT(12)  tests/test_plugin/duplicate_s_function.vim" or something similar?
OTOH, it might be better to add a location line (filename and line number) to FUNCTION entries.
This would be better for anonymous functions / lambdas etc I assume in general.

Any input here would be appreciated.
Looked into this myself, and appending  (<SNR>_X) to the "FUNCTION" header seems to be easy.
I've also tried to save the line number with functions, but it is not clear how approach this best, and if it should only get done when profiling.
There could be a specialized last_set_msg_lnum for this case, but I think it is useful for all kind of information e.g. :verb set, :verb au BufEnter etc.
But it would mean some overhead, because the lnum would be stored for all of them.


Link validation when submitting from /post

I typo'd when creating a post.
I meant to paste the link for a website (e.g., https://Stacker.News), but had prefixed the URL with an extraneous character  "T".
The URL I actually posted was something like:
Thttps://Stacker.News
But SN simply prefixed "https://" to it.  So the URL for the post ended up being something like:
https://Thttps://Stacker.News
I noticed it right away, so was able to edit the URL for the post, and there was no issue, but SN probably should do validation on the URL from the submit before accepting it.

We have an issue for this already: https://github.com/stackernews/stacker.news/issues/14. Going to close this one but thanks for resurfacing it!


Buffer is not defined

One of my meteor package is using ostrio:files. After upgrading to latest ostrio:files and latest meteor. I got below issue, issue will not happen if I remove ostrio:files dependency from my package.
modules.js?hash=355b762…:22419 Uncaught ReferenceError: Buffer is not defined
    at util.js (modules.js?hash=355b762…:22419)
    at fileEvaluate (modules-runtime.js?hash=8587d18…:343)
    at require (modules-runtime.js?hash=8587d18…:238)
    at meteorInstall.node_modules.meteor-node-stubs.node_modules.readable-stream.lib._stream_readable.js (modules.js?hash=355b762…:18103)
    at fileEvaluate (modules-runtime.js?hash=8587d18…:343)
    at require (modules-runtime.js?hash=8587d18…:238)
    at meteorInstall.node_modules.meteor-node-stubs.node_modules.readable-stream.readable.js (modules.js?hash=355b762…:18038)
    at fileEvaluate (modules-runtime.js?hash=8587d18…:343)
    at require (modules-runtime.js?hash=8587d18…:238)
    at meteorInstall.node_modules.meteor-node-stubs.node_modules.stream-browserify.index.js (modules.js?hash=355b762…:17922)

What Meteor version and Meteor-Files version you're on?
BTW two of latest releases somehow broken (#420), have you tried to downgrade?

@haojia321 just found this - https://github.com/meteor/meteor/issues/8645#issuecomment-302253375

Hello @haojia321 ,
Have you fixed it?

Sorry for the delay @dr-dimitru , Yes this work around will work by add global.Buffer = global.Buffer || require("buffer").Buffer;
But my question is, will it be better to handle this in ostrio:files package itself?

But my question is, will it be better to handle this in ostrio:files package itself?

Sure update is coming.

@dr-dimitru as always, you rock!

@haojia321 have you already tried dynamic import()?

No, we are still in <IP_ADDRESS>. Will update in here after we update to meteor 1.5.
Should we remove tag wont fix if we are planning to fix in package itself?

Should we remove tag wont fix if we are planning to fix in package itself?

But this behavior won't change anytime in the future, due to core changes in Meteor>=1.5

I'm going to reopen this. As we can't reproduce this error with our 3 demo apps, nor with our production app. Need more investigation.

@haojia321 is this still an issue?

Hi @dr-dimitru,
As we discussed above by adding global.Buffer = global.Buffer || require("buffer").Buffer;
Do you think it will be possible to put that code in your package since your package is using Buffer and Meteor no longer set Buffer to global variable? That way might help package user keeping their code clean?

It's not this package issue. We can't reproduce this error with our 3 demo apps, nor with our production app. Are you sure Buffer is not used anywhere in your app' code, NPN or Atmosphere packages?

Any idea how to check if Buffer is used by certain packages?
--
Best regards
Hao Jia
Cell phone:<PHONE_NUMBER>
Send from my iPhone 7

On Jun 9, 2017, at 11:09, dr.dimitru<EMAIL_ADDRESS>wrote:
It's not this package issue. We can't reproduce this error with our 3 demo apps, nor with our production app. Are you sure Buffer is not used anywhere in your app' code, NPN or Atmosphere packages?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

No idea, maybe better to ask here or search here one of the first is widely used OAuth.

Ok. Im closing this issue here.

If you will find which package caused it, left its name here

Hi there, I got this issue in one way if :
const Images = new FilesCollection({
	collectionName: 'Images',
	onBeforeUpload(file) {
	},
	onAfterUpload(file) {
            ///SERVER SIDE NO ISSUE WITH BUFFER
        }

But if you use it with the eventListener :
Images.on('afterUpload'.... /// CLIENT SIDE
effectively you'll get the issue Buffer is not defined.
global.Buffer = global.Buffer || require("buffer").Buffer is a nice workaround.

Hello @Vandell63 ,
Thank you for this exploring.
Images.on('afterUpload')

Is Server only event as well as  onBeforeUpload Server only hook.
I can not assume it as issue as it is not supposed to be used on the Client.


[CI] Update to ensure CodeCov runs on pull requests

Welcome to Codecov :tada:
Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.
Thanks for integrating Codecov - We've got you covered :open_umbrella:


Catch up to changing Capistrano 3.5.0 with specs

Capistrano 3.5.0 has many changes.
https://github.com/capistrano/capistrano/blob/master/CHANGELOG.md#350
In order to notify Slack using Slackistrano, I think that it is necessary to catch up with some changes.
Thanks you @machupicchubeta

👍

this worked for me 👍 !

this is great! can you please review and merge?

Soon. Need to see how this will affect folks using older versions of Capistrano. Don't want to [totally] yank the rug out from them.
Mostly just need to find some time to do it 😀

great, thank you!

I think that the essence of this Pull Request has been imported into Slackistrano Version 3.0.0.
Thank you @phallstrom

@machupicchubeta I believe so too.  Appreciate the 3.5.0 dry run stuff. I knew that was coming, but wasn't sure when it would hit.  Thanks much!


Async write() on unimplemented stream-stream RPC fails with INTERNAL "execute_batch" error half of the time

What version of gRPC and what language are you using?
Python
grpcio 1.62.0
grpcio-reflection 1.62.0
What operating system (Linux, Windows,...) and version?
Windows 11 Enterprise 22H2 22621.3155
What runtime / compiler are you using (e.g. python version or version of gcc)
Python 3.12.2 (tags/v3.12.2:6abddd9, Feb  6 2024, 21:26:36) [MSC v.1937 64 bit (AMD64)] on win32
What did you do?
import asyncio
import logging
from concurrent import futures
from multiprocessing import Process

import grpc
import grpc_reflection.v1alpha.reflection_pb2 as reflection_pb2
import grpc_reflection.v1alpha.reflection_pb2_grpc as reflection_pb2_grpc

def serve():
    logging.basicConfig(level=logging.DEBUG)
    logging.info("In server process")
    server = grpc.server(thread_pool=futures.ThreadPoolExecutor(max_workers=5))
    server.add_insecure_port("<IP_ADDRESS>:50051")
    logging.info("Starting server...")
    server.start()
    logging.info("Waiting for server termination")
    server.wait_for_termination()

async def request():
    async with grpc.aio.insecure_channel("<IP_ADDRESS>:50051") as channel:
        stub = reflection_pb2_grpc.ServerReflectionStub(channel)

        logging.info("Testing...")
        fail = 0
        for i in range(100):
            try:
                rpc = stub.ServerReflectionInfo()
                await rpc.write(reflection_pb2.ServerReflectionRequest())

            except grpc.RpcError as e:
                if e.code() != grpc.StatusCode.UNIMPLEMENTED:
                    logging.debug(f"Wrong exception: {e}")
                    fail += 1
        logging.info(f"{fail} failed out of {i + 1}")

async def main():
    p = Process(target=serve)
    p.start()
    await request()
    p.kill()

if __name__ == "__main__":
    logging.basicConfig(level=logging.DEBUG)
    asyncio.run(main())

What did you expect to see?
0 failed out of 100
Since the running server does not implement the reflection protocol, all calls should return with UNIMPLEMENTED.
What did you see instead?
DEBUG:asyncio:Using proactor: IocpProactor
DEBUG:grpc._cython.cygrpc:Using AsyncIOEngine.POLLER as I/O engine
INFO:root:Testing...
INFO:root:In server process
INFO:root:Starting server...
INFO:root:Waiting for server termination
[...]
DEBUG:root:Wrong exception: <AioRpcError of RPC that terminated with:
        status = StatusCode.INTERNAL
        details = "Internal error from Core"
        debug_error_string = "Failed "execute_batch": (<grpc._cython.cygrpc.SendMessageOperation object at 0x000001B19AD00CB0>,)"
>
INFO:root:46 failed out of 100

From what I can tell, this is specific to stream-stream calls. I couldn't reproduce it with unary-unary, stream-unary, and unary-stream. It also doesn't reproduce with the sync API. Strangely enough, when the server is running in the same Python process, it also doesn't seem to occur.
Anything else we should know about your project / environment?
This is the pyproject.toml for the example above:
[tool.poetry]
package-mode = false

[tool.poetry.dependencies]
python = "~3.12"
grpcio = "^1.62.0"
grpcio-reflection = "^1.62.0"

[build-system]
requires = ["poetry-core"]
build-backend = "poetry.core.masonry.api"

I'm able to reproduce it locally, after enable core log, I can see that the internal error is stream closed: error=UNKNOWN:Attempt to send message after stream was closed.
My guess is because you're using aio write API, the send message operation was scheduled to happen at a random point in future, if the operation was trigged after the stream was closed in gRPC core, we'll get an INTERNAL error.
We'll need more time to investigate what to do next.
Also attaching the logs here for reference: https://gist.github.com/XuanWang-Amos/21fd5f3830de49f075a9b5a199313a9e

Hi, I was wondering if there are any updates here? I am getting this error when trying to perform a stream-stream write from my Python grpc.aio client:
ERROR:root:Error during stream: <AioRpcError of RPC that terminated with:
	status = StatusCode.INTERNAL
	details = "Internal error from Core"
	debug_error_string = "Failed "execute_batch": (<grpc._cython.cygrpc.SendMessageOperation object at 0x7f896e75c7b0>,)"

Thank you - I appreciate any help.

I can also observe this problem on stream read.


[DRAFT] chore: update the docs title and meta tags

Update the <title> and <meta> tags to reflect copy changes that were asked for by marketing and product.

new index page copy

Leaving this as a draft until I can try to verify why the import { description } from '../../package/' isn't working 🤔 .


Rename bitcoin_demo.py to magtag_bitcoin_demo.py

To include lib name to match lib standards.

Looks like the examples.rst file needs to be updated to point to the renamed example file.

Leveled up my lazy.... I did this through the GitHub interface, and before today had no idea how to go back and change another file through GitHub. Figured it out!


chore(release): v0.5.1 🎉

:robot: I have created a release beep boop
0.5.1 (2023-11-11)
Bug Fixes

contract: expose the removal method (3aff2bb)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/whodisio/whodis-sdk/releases/tag/v0.5.1 :sunflower:


Add a license

This project is missing a license, specifying usage conditions. The node wrapper uses MIT for this, so probably MIT would be fine here too?
To clarify why this is needed: According to the open source guide Section 2 states

If you don’t apply an open source license, everybody who contributes to your project also becomes an exclusive copyright holder of their work. That means nobody can use, copy, distribute, or modify their contributions – and that “nobody” includes you.

So for commercial use, the wrapper is not actually usable from an open source point of view as it doesn't grant any usage rights in itself

Hi @curtisy1 , Thank you for raising. I've created a ticket to add the MIT licence.


[webapp] WIP Latency Path Survey

This change is

There are sill some bugs, but one question I have is the best way to show performance on the topology graph. Should we show the performance on the links only, or also show the inter AS performance on the graph?

Another PR is more advanced than this one, so closing. See #124.


Omnisharp fails to start server with spaces in the path

Issue Description
Omnisharp fails to start server with spaces in the path, example /Users/James 1 2/.vscode/extensions/ms-dotnettools.csharp-1.23.10/.omnisharp/1.37.8/run.  Similar to https://github.com/OmniSharp/omnisharp-vscode/issues/3608, but earlier in the run executable.
For what it's worth, I tried hardcoding the run executable variables to no avail.  Also tried reverting to an earlier version with the same result.
Thanks!
Steps to Reproduce
Start omnisharp in vscode with spaces in the executable path.
Expected Behavior
Omnisharp escapes spaces on server start.
Actual Behavior
Omnisharp doesn't escape them.
Logs
OmniSharp log
Starting OmniSharp server at 4/9/2021, 11:54:16 AM
    Target: /Users/James 1 2/games/New Unity Project/New Unity Project.sln
OmniSharp server started.
Path: /Users/James 1 2/.vscode/extensions/ms-dotnettools.csharp-1.23.10/.omnisharp/1.37.8/run
PID: 27658
Cannot open assembly '1': No such file or directory.
[ERROR] Error: OmniSharp server load timed out. Use the 'omnisharp.projectLoadTimeout' setting to override the default delay (one minute).
Environment information
VSCode version: 1.55.1
C# Extension: 1.23.10
Mono Information
        OmniSharp using built-in mono
Dotnet Information
.NET SDK (reflecting any global.json):
 Version:   5.0.202
 Commit:    db7cc87d51
Runtime Environment:
OS Name:     Mac OS X
OS Version:  10.15
OS Platform: Darwin
RID:         osx.10.15-x64
Base Path:   /usr/local/share/dotnet/sdk/5.0.202/
Host (useful for support):
Version: 5.0.5
Commit:  2f740adc14
.NET SDKs installed:
5.0.202 [/usr/local/share/dotnet/sdk]
.NET runtimes installed:
Microsoft.AspNetCore.App 5.0.5 [/usr/local/share/dotnet/shared/Microsoft.AspNetCore.App]
Microsoft.NETCore.App 2.1.23 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
Microsoft.NETCore.App 5.0.5 [/usr/local/share/dotnet/shared/Microsoft.NETCore.App]
To install additional .NET runtimes or SDKs:
https://aka.ms/dotnet-download

Visual Studio Code Extensions

Extension
Author
Version

csharp
ms-dotnettools
1.23.10

jupyter
ms-toolsai
2021.5.702919634

python
ms-python
2021.3.680753044

vscode-eslint
dbaeumer
2.1.19

vsliveshare
ms-vsliveshare
1.0.4116

Thank you for reporting this, the code that launches the executable on non windows needs to be fixed.


flutter/flutter main and master branches are out of sync, pointed to different commits

https://github.com/flutter/flutter/tree/master points to 38a2359, https://github.com/flutter/flutter/tree/main points to 3d62732 which is 11 commits and 14 hours behind.

@keyonghan on-call

Updated the token and ran the failing workflows. Now main and master point to the same commit.


fix(macOS): fixed over release the separator

Issue: https://github.com/tauri-apps/tauri/issues/7760
I think the separator is already an autorelease object since we didn't alloc and init by ourselves. So, calling the autorelease() again will cause an over-release and we should not release it manually.

@lucasfernog can you review this one?


Subscriber not recognized when using extension functions

Hi, i tried to register a bus into an extension function and also hear for events into another extension function like this:
typealias SomeClass = SomeClassImpl //SomeClassImpl is a class

fun SomeClass.someExtendedFunction(){
   with(someProperty){
      EventBus.getDefault().register(this@someExtendedFunction) // Exception
  }
}

@Subscribe(threadMode = ThreadMode.MAIN)
fun SomeClass.onMessage(message:Message){
 // Do something
}

The exception is:EventBusException: Subscriber class SomeClassImpl and its super classes have no public methods with the @Subscribe annotation

I suspect the issue is that extension functions are compiled to static methods, but not actual class members. The method has to be a member of the class you register with EventBus, otherwise it won't be found. -ut

Thanks, you are right, i ended using it directly in the class and not in the extension function, but would be nice if you add this functionality for kotlin or create extension functions for eventbus


PHP install not registering

On a fresh install of windows 10 pro installing any version of php with scoop creates an alias for php but doesn't have any output.
For instance calling php -version just goes to the next line. Before install php will error.
Tried the 64 and 32. 7 and 5.6 versions. Run scoop update, removed scoop and reinstalled each app.

Do the the shims get created in C:\Users\%username%\AppData\Local\scoop\shims?
You should be seeing two files relating to PHP: php.exe and php.ps1
Also whats the results of scoop which php?
Both scoop install php56 and scoop install php work fine for me, you should also use php -v or php --version to list PHP's version.

Yeah, I have both the files in the shims folder.
'''scoop which php''' '''~\appdata\local\scoop\apps\php56\5.6.16\php.exe'''
It's damned confusing.

Fresh install was the clue, first time installing scoop on a new install. Opening command prompt instead of powershell and running php showed the error.
MSVCR110.dll is missing from your computer
http://www.microsoft.com/en-us/download/details.aspx?id=30679 to install Visual C++ Redistributable for Visual Studio 2012 Update 4 fixed that.
Silly thing to over look but I'll close the issue and keep the solution just in case.

:+1 Glad your sorted


Crashes with net6-windows and WinFormsComInterop >= 0.4

Application works perfectly with WinFormsComInterop 0.3.2, using net6.0-windows as the target and the HIC.System.Windows.Forms.DataVisualization package, which is a small fork from dotnet.
These are from a debug build, no trimming or AOT.
0.4.2: Opens, but hard crash after closing the file picker dialog. The exception code and offset for ntdll are the same every time.
The program has exited with code<PHONE_NUMBER> (0xc0000374).
---
Faulting application name: myprogram.exe, version: <IP_ADDRESS>, time stamp: 0x6387d353
Faulting module name: ntdll.dll, version: 10.0.19041.2130, time stamp: 0xb5ced1c6
Exception code: 0xc0000374
Fault offset: 0x00000000000ff6a9
Faulting process id: 0x86c
Faulting application start time: 0x01d92ae651cffe54
Faulting application path: myprogram.exe
Faulting module path: C:\Windows\SYSTEM32\ntdll.dll
Report Id: 7c249671-d100-4788-9c25-c0f824c6c7fc
Faulting package full name:
Faulting package-relative application ID:

0.4.1, 0.4.0: Missing library when trying to open the system file picker dialog
System.IO.FileNotFoundException: Could not load file or assembly 'Microsoft.Web.WebView2.Core, Version=1.0.1370.28, Culture=neutral, PublicKeyToken=null'. The system cannot find the file specified.
File name: 'Microsoft.Web.WebView2.Core, Version=1.0.1370.28, Culture=neutral, PublicKeyToken=null'
   at MarshalSupport.GetIUnknownForObject(Object value)
   at WinFormsComInterop.IFileOpenDialogWrapper.primitives::Interop.Shell32.IFileDialog.Advise(IFileDialogEvents pfde, UInt32& pdwCookie)
   at System.Windows.Forms.FileDialog.TryRunDialogVista(IntPtr hWndOwner, Boolean& returnValue)
   at System.Windows.Forms.FileDialog.RunDialog(IntPtr hWndOwner)
   at System.Windows.Forms.CommonDialog.ShowDialog(IWin32Window owner)
   at System.Windows.Forms.CommonDialog.ShowDialog()

Can you try 0.4.3 release?

In debug mode for net6-windows and net7-windows: everything seems to work
publish for net6-windows, net7-windows + trimmode=link + self contained: everything seems to work
publish for net7-windows + trimmode=link + aot: It seems functional but often crashes when refreshing a chart, although this config would sometimes crash with 0.3.2 as well. I'm not sure it's worth acknowledging but it seems to crash more often with 0.4.3? To be honest I haven't played around with net7 aot much so perhaps it's due to my other code misbehaving.

Okay. I suspect that's really differetn issue. Can you try switch your OutputType to EXE so you will have console. If that does not help to see stack trace, please take a look at this docs https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/debugging.md#visual-studio-specific-notes

There are quite a few missing interfaces although I'm not sure how to tell which are fatal vs non-fatal access violations. Unfortunately there may be sporadic calls to undocumented kernel32 functions in this debug output, but I tried to only grab sections where it seemed to be related to UI update flows. Let me know if this is helpful or if you have ideas for ways to make it helpful.

 pile of debug output
From load until first exception:
'program.exe' (Win32): Loaded '...\bin\publish\net7.0-aot\program.exe'.

Couple of other random ones I picked out:
...
mincore\com\oleaut32\dispatch\ups.cpp(2122)\OLEAUT32.dll!00007FFD6E2B9DD6: (caller: 00007FFD6E2B91E9) ReturnHr(1) tid(5b08) 8002801D Library not registered.

...
onecore\com\combase\dcomrem\security.cxx(3071)\combase.dll!00007FFD6FF0BABC: (caller: 00007FFD4AF1823E) ReturnHr(7) tid(57a8) 80010117 Call context cannot be accessed after call completed.

Other large chunk until an access violation:
'program.exe' (Win32): Loaded 'C:\Windows\System32\Windows.StateRepositoryPS.dll'.
onecore\com\combase\dcomrem\marshal.cxx(1284)\combase.dll!00007FFD6FF2E05B: (caller: 00007FFD6FF2D414) ReturnHr(8) tid(5b08) 80004002 No such interface supported
    Msg:[Failed to marshal with IID={618736E0-3C3D-11CF-810C-00AA00389B71}]
onecore\com\combase\dcomrem\marshal.cxx(1179)\combase.dll!00007FFD6FF2D444: (caller: 00007FFD6FF2BFCB) LogHr(4) tid(5b08) 80004002 No such interface supported
onecore\com\combase\dcomrem\marshal.cxx(1119)\combase.dll!00007FFD7001065C: (caller: 00007FFD6FF2B8DD) ReturnHr(9) tid(5b08) 80004002 No such interface supported
'program.exe' (Win32): Unloaded 'C:\Windows\System32\xmllite.dll'
The thread 0x4dcc has exited with code 0 (0x0).

The thread 0x5b38 has exited with code 0 (0x0).

The final debug trace block in the above spoiler box was taken while broken with this callstack on an access violation:
program.exe!WinFormsComInterop_WinFormsComInterop_PrimitivesIRawElementProviderSimpleProxy__get_ProviderOptions()  Unknown
UIAutomationCore.dll!00007ffd3fc6fa9a() Unknown
program.exe!System_Windows_Forms_Primitives_Interop_UiaCore__UiaRaiseAutomationPropertyChangedEvent()  Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_AccessibleObject__RaiseAutomationPropertyChangedEvent()  Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_Button__OnClick()    Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_Button__OnMouseUp()  Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_Control__WmMouseUp() Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_Control__WndProc()   Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_ButtonBase__WndProc()    Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_NativeWindow__Callback() Unknown
program.exe!Internal_CompilerGenerated__Module___<ReverseDelegateStub>System_Windows_Forms_Primitives_Interop_User32_WNDPROC() Unknown
user32.dll!00007ffd6e56e7e8()   Unknown
user32.dll!00007ffd6e56e229()   Unknown
program.exe!System_Windows_Forms_Primitives_Interop_User32__DispatchMessageW() Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_Application_ComponentManager__Interop_Mso_IMsoComponentManager_FPushMessageLoop()    Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_Application_ThreadContext__RunMessageLoopInner() Unknown
program.exe!System_Windows_Forms_System_Windows_Forms_Application_ThreadContext__RunMessageLoop()  Unknown

Would be great if you follow https://github.com/dotnet/runtime/blob/main/src/coreclr/nativeaot/docs/debugging.md#visual-studio-specific-notes and stop at first exeption, and show stack trace. Also, if you can give a link to repo with repro I would appreciate it.


[huge WIP] Initial diffusive integration

Diffusive Fortran kernel /src/fortran_routing/diffusive_v02frwk/

maindiff_v2.f90 - diffusive wave module
pymaindiff_v2.f90 - diffusive wave module wrapper with c def variables
uniflowtzlt.f90 - A look up table for uniform flow channel geometry. This is not currently used, but worth caching. Theoretically, the look up table is quicker than calling on the fly channel geometry subroutines.
makefile - compiles Fortran code

Cython wrapping /src/python_routing_v02/fast_reach/

diffusive.pyx - accepts arguments from compute_nhd_routing_SingleSeg_v02.py, generates diffusive model inputs via diffusive_utils.py, calls the diffusive compute kernel, compresses diffusive model outputs into flowveldepth array via diffusive_utils.py.
pydiffusive.h - headerfile
fortran_wrappers.pxd - add diffusive wave variable defs
mc_reach.pyx - add new argument to compute functions, diffusive_parameters=False. This is required to use a generic function, compute_func to call either the MC or diffusive wave models from compute_nhd_routing_SingleSeg_v02.py.

framework /src/python_framework_v02/troute/

nhd_io.py

bug fix in read_csv to correctly read mask data. Previously first segment was missed, leading to network breaks.
read diffusive parameters from yaml or json in read_custom_input
minor formatting change in get_ql_from_wrf_hydro_mf
some odd diffs in and around get_channel_restart_from_csv?

nhd_network.py - misc formatting diffs. nothing of substance
nhd_network_augment.py - looks like we are trying to merge a deprecated version of this file.
nhd_network_utilities_v02.py - looks like we are trying to merge a deprecated version of this file.  Important diff in build_qlateral_array around reading-in mask file - I don't know if this is necessary at all.

... to be continued ...

@hellkite500 Thanks for being so quick to take a look at this PR. I have removed the files you commented on, as they were only needed for development purposes and will not be living in the master repository.

Broadly, after attempting a merge on a scratch branch, it looks like the conflicts are related to the following:

change from mc_reach --> fast_reach (the name "mc_reach" was generating a number of conflicts)
insertion of the diffusive_parameters in the same spot as the data_assimilation_parameters
addition of the data assimilation function in the middle of the nhd_io along with conflicting name changes
conversion to pathlib from os

The automatically generated merge commit message is informative:
      1 Merge remote-tracking branch 'awlos/diff_integration_3' into diff_merge_DELETEME
      2
      3 Conflicts:
      4   src/python_framework_v02/troute/nhd_io.py
      5   src/python_framework_v02/troute/nhd_network_utilities_v02.py
      6   src/python_routing_v02/compute_nhd_routing_SingleSeg_v02.py
      7 #
      8 # It looks like you may be committing a merge.
      9 # If this is not correct, please remove the file
     10 # .git/MERGE_HEAD
     11 # and try again.
     12
     13
     14 # Please enter the commit message for your changes. Lines starting
     15 # with '#' will be ignored, and an empty message aborts the commit.
     16 # On branch diff_merge_DELETEME
     17 # All conflicts fixed but you are still merging.
     18 #   (use "git commit" to conclude merge)
     19 #
     20 # Changes to be committed:
     21 #
     22 # new file:   ../fortran_routing/diffusive_v02frwk/maindiff_v2.f90
     23 # new file:   ../fortran_routing/diffusive_v02frwk/makefile
     24 # new file:   ../fortran_routing/diffusive_v02frwk/pymaindiff_v2.f90
     25 # new file:   ../fortran_routing/diffusive_v02frwk/uniflowtzlt.f90
     26 # new file:   ../python_framework_v02/troute/network_dl.py
     27 # modified:   ../python_framework_v02/troute/nhd_io.py
     28 # modified:   ../python_framework_v02/troute/nhd_network.py
     29 # modified:   ../python_framework_v02/troute/nhd_network_augment.py
     30 # modified:   ../python_framework_v02/troute/nhd_network_utilities_v02.py
     31 # modified:   compiler.sh
     32 # modified:   compute_nhd_routing_SingleSeg_v02.py
     33 # new file:   diffusive_utils.py
     34 # new file:   fast_reach/diffusive.pyx
     35 # modified:   fast_reach/fortran_wrappers.pxd
     36 # modified:   fast_reach/mc_reach.pyx
     37 # new file:   fast_reach/pydiffusive.h
     38 # modified:   setup.py
     39 # modified:   ../../test/input/florence_933020089/FORCING/SeptemberFlorenceQlateral_wDates.csv
     40 # new file:   ../../test/input/yaml/Florence_Benchmark_diff.yaml

It looks like there is an embedded dependency on a usgs library that may be causing some issues. TBC...

Superseded by #283


yarn upgrade

Current dependencies on/for this PR:

master

PR #77

PR #78

PR #79

PR #80   👈

This comment was auto-generated by Graphite.


Some questions

What does the webrtc create link exactly do ?
I can cast great with Sansco CCTV RTSP streams if i lower the codec to non 1080P for a firs generation chrome cast. If i try to do the same with eufy it will display some message about codec.

Is there any way of having eufy2c/indoor/pan&tilt be casted as well ? It should work as if i cast it from google home assistant it displays fine. Is this something in webrtc ?
3. Can the dash cast startup logo be removed? I feel it adds to the general startup time of the cast. At the very least it looks like product placement.
Many thanks for a cool piece of software!

Create permanent link to camera for access without auth
I don't know
This is 3rd party app. I can't change its behavior


enhanceProhibit creating materialized views in external catalogs

Prohibit creating materialized views in external catalogs

run beut

run buildall

run buildall

run buildall


Create Assessment VPC with Guacamole Instance

🗣 Description
This is a somewhat large PR, but it moves the assessment environment from being completely empty to being in a good place for us to add on to.  Here's what is defined by the Terraform in this PR:

A VPC with one "Operations" (public) subnet and one or more private subnets (number of private subnets can be specified in the tfvars file)
An Internet Gateway for the Operations subnet
A NAT Gateway for each private subnet
A connection to the Transit Gateway in the Shared Services account (untested as of now)
Routing tables for each subnet, including routes to the Transit Gateway (again, untested)
Network ACLs for the public and private subnets, with a reasonable set of rules (they will almost certainly need changes later, but this should be a good start)
Two security groups:

"Desktop Gateway" (for the Guacamole instance), with a reasonable initial set of rules
"Operations" (for the operating instances, like Kali, etc.) - no rules have been set up yet in this SG

A Guacamole instance in one of the private subnets - note that there are no other instances yet for Guacamole to connect to, but we'll get there in a PR in the very near future.

Note that I am using a bunch of remote Terraform states in order to minimize the number of required input variables.  I am aware that we may consolidate our remote state data in the future- if/when that happens, some changes may be needed here.
Resolves #1.  Starts the work of #2 and #4, but there is still more to be done on them.

💭 Motivation and Context
We need to get env0 up and running for the start of user acceptance testing.  This PR lays down a good chunk of Terraform that we need and can build on.
Next steps for future PRs:

Add one Kali instance (and support having additional instances)
Add DNS records so the Guacamole instance can be reached via guac.env0.cool.cyber.dhs.gov (for example)
Add private DNS records so that Operations instances can be reached via kali0.env0 (for example)
Update cloud-init scripts so that the correctly set up connections (within Guacamole) to all instances in the Operations subnet
Update the README with a bit more useful info 😜

🧪 Testing
I successfully applied all of this Terraform in the env0 account.  Since the OpenVPN networking is still in flux, I ssh'd to the OpenVPN instance and used that as a bastion so that I could ssh to the env0 Guacamole instance.  Once I was on the Guacamole instance, I confirmed that the Docker composition (Guacamole / Postgres / nginx) was running as expected.
Next, I opened up an ssh tunnel (again via the OpenVPN instance) and forwarded port 8443 on my local workstation to port 8443 on the Guacamole instance, where nginx is listening.  That allowed me to hit https://localhost:8443 in a browser on my workstation and I was able to successfully operate the Guacamole GUI from the Guacamole instance in env0.  I couldn't do a whole lot since there are no other instances to connect to via Guacamole, but at least I knew Guacamole was up and running.

📷 Screenshots (if appropriate)

🚥 Types of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (causes existing functionality to change)

✅ Checklist

[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

Note that "TBD" throughout this PR is my placeholder for the first Kali instance in the Operations subnet, which will be coming soon.


Exception from Interface thrown, when call from subdirectory

An exception is thrown when calling a component in subdirectories.
(Ex.
php artisan make:livewire Register/create
<button wire:click="$emit('openModal','register.create')"
        class="bg-indigo-500">
    {{ __('New Register) }}
</button>

Exception
[App\Http\Livewire\Register\Create] does not implement
[LivewireUI\Modal\Contracts\ModalComponent] interface.)

This is not related to subdirectories, you need to make sure you extend the LivewireUI\Modal\ModalComponent class.

I am sure that I have faithfully followed the documentation. However, several times, you submitted the exception!
I restarted the PC and finally the behavior disappeared.
Anyway, thank you very much for your attention.

Hi @locopine
Happy to hear the issue is resolved 😄


update PPP

Pull Request Test Coverage Report for Build 364

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 48.906%

Totals

Change from base Build 363:
0.0%

Covered Lines:
1632

Relevant Lines:
3337

💛  - Coveralls


Android Compatibility

This issue tracks compatibility of the sample apps with Android devices. Please check whether your device is already in the list before adding a new one. Please provide at least:

the hardware model
the Android OS version
steps to reproduce the crash (unless all samples fail to start at all, which is most likely)

closing old tickets


Add search_scope param, updated swagger

Adds search_scope param (proposed here https://github.com/NYPL-discovery/discovery-front-end/issues/82 ), now documented in an updated swagger. The new swagger much more closely documents the actual api rather than the anticipatory interface described in 0.2, which I've left untouched.

Note this depends on new mappings available in resources-2017-05-08 and going forward. So if by chance you try to test this, set your resources index (config.elasticsearch.indexes.resources) to "resources-2017-05-08"

Seems OK to me, but I have little context so I defer to someone else for approval.


Unable to assign secret as Environment Variable to a workload/pod from Ember

What kind of request is this (question/bug/enhancement/feature request): bug
Steps to reproduce (least amount of steps as possible):

deploy any local cluster with rancher:master-head abeea84
provision a singlenode RKE1 cluster from ember by using k8s v1.20.7-rancher1-1 or v1.21.1-rancher2-1
define a key-value secret in Ember UI for the downstream cluster in default ns
try to define a workload in default ns by using the secret via Environment Variable section and Inject Values From Another Resource option and click on +Add from Source, choose Type: Secret from dropdown and select the secret you created before

Result:

After pressing Launch (for Workload) button Ember UI won't create the resource due Error visible in Ember UI:

Validation failed in API: field `environmentFrom` is deprecated, please use Kubernetes native fields `env` and `valueFrom` for the container's environment variables

Other info

Mounting secrets to a workload as a volume is working fine

Environment information

Rancher version (rancher/rancher/rancher/server image tag or shown bottom left in the UI): rancher:master-head abeea84
Installation option (single install/HA): any

Cluster information

Cluster type (Hosted/Infrastructure Provider/Custom/Imported): any
Machine type (cloud/VM/metal) and specifications (CPU/memory): any
Kubernetes version (use kubectl version): v1.20.7-rancher1-1 and v1.21.1-rancher2-1 (maybe others?)

This is intentional, the API has to be a breaking change to avoid silently correcting data.  This interface will either be removed or inaccessible in the final packaging of the 2.6 UIs, use the Vue workload screens.  (Frankly they could use a lot more testing, especially the less common options)

Expected because of this change - https://github.com/rancher/rancher/issues/16148


Fix reference in CHANGELOG.md

It fixes a wrong reference for a PR

I just made the same PR an hour before you.
Thanks for your contribution 🌺


Maximum call stack size exceeded - cloning AST with ref cycles

The error occurs after referencing an unexisting file, then fixing the name so an existing file is referenced.
I've managed to come up with a relatively small example, unfold below.

Entry file:
```
import React from 'react';
import a from './a.js';
export default ;

File "a.js":

export default 42;

Rollup config:

import babel from 'rollup-plugin-babel';
import commonjs from 'rollup-plugin-commonjs';
import nodeResolve from 'rollup-plugin-node-resolve';
export default {
entry: 'entry.js',
dest: 'bundle.js',
format: 'cjs',
plugins: [
nodeResolve(),
commonjs({
include: 'node_modules/',
}),
babel({
exclude: 'node_modules/',
}),
],
};

The output from rollup-watch is:

rollup -c -w

checking rollup-watch version...
bundling...
bundled in 843ms. Watching for changes...
// Here I change the name to something invalid
bundling...
Could not resolve './a-.js' from /some_path/entry.js
Error: Could not resolve './a-.js' from /some_path/entry.js
at Error (native)
at /some_path/node_modules/rollup-plugin-node-resolve/dist/rollup-plugin-node-resolve.cjs.js:78:21
at /some_path/node_modules/resolve/lib/async.js:55:18
at load (/some_path/node_modules/resolve/lib/async.js:69:43)
at onex (/some_path/node_modules/resolve/lib/async.js:92:31)
at /some_path/node_modules/resolve/lib/async.js:22:47
at FSReqWrap.oncomplete (fs.js:123:15)
Type rollup --help for help, or visit https://github.com/rollup/rollup/wiki
// Here I chang the name back
bundling...
Maximum call stack size exceeded
RangeError: Maximum call stack size exceeded
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:24:26)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
at deepClone (/some_path/node_modules/rollup/src/utils/object.js:36:18)
Type rollup --help for help, or visit https://github.com/rollup/rollup/wiki
</details>

I've started digging around the code a bit, but I don't have much time rn. I've only found out that after the name is restored, [`deepClone`](https://github.com/rollup/rollup/blob/10d2ad36fb308ffdf554b0c41dd27a2f2ed04a69/src/Module.js#L42) receives an AST that has a ref cycle on an inport declaration. A quick check shows that removing `ast ||` from the line above fixes the problem.

Maybe the AST that is cached is modified somewhere later and when it is cloned again the error occurs?

Btw. no matter what I do after the first "Maximum call stack size exceeded", the same error shows after each change and I have to restart.

i have the same issue when i use version 2.5.0

same here, just found this because of the Ionic RC0
[19:49:26]  RangeError: Maximum call stack size exceeded
    at isArray (native)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:157:7)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)
    at deepClone (/Users/me/Demployeruments/Code/employer/project/frontend_tablet/node_modules/rollup/dist/rollup.js:165:18)

Same issue using version 2.5.0
As described, deepClone is called a bunch of times and then rollup dies. I have to restart the watch process whenever it happens.

Same issue using version 2.5.0

The bug was in Rollup itself – fixed (finally!) in 0.39.2


Name changes from SAP Cloud Platform to BTP

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.S seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Retire RSpec/InvalidPredicateMatcher

In that case, won’t RSpec tell you about the mistake? Something like

expected something to respond to `available??`

As far as I remember, according to our non-goals (a rather incomplete version of what we have in mind) it's not our business to notify the user about things that RSpec will notify with a spec failure, warning, or an error.
I clearly understand that with the editor integration it may highlight this problem earlier.
On the other hand, we don't provide auto-correction anyway.
It's an interesting topic of what we should keep, and what to retire, as this cop might be helpful for some people in some circumstances, but in general, it's not the goal of RuboCop RSpec.
WDYT @bquorning @Darhazer ?

I stand by my comment in https://github.com/rubocop-hq/rubocop-rspec/pull/441#issuecomment-321885705:

👎 IMHO, Rubocop is not the right tool for solving this problem. The extra ? at the end of the predicate matcher is a typo, and as all (well, most) other typos it will be caught during runtime.

As for the “editor integration” argument, that opens the door to catch a lot of “typo” class offenses that I really think we shouldn’t bother with.

I guess in the early days when there were not so many cops, all kinds of checks were accepted. Now we can choose wisely.
On the other hand, do we need to retire it? I would suggest we do so in major versions, like when we bump the requirement of rubocop to 1.0, and probably - do a review of all cops and decide if some are to be retired, so have all the deprecations in one release ;)
Last, but not least, Rubocop itself has a ConfigObsoletion class that informs users for removed cops, as users can have them actually in their configurations. Should we adopt the same process? Maybe we should look into how extension could extend those lists?

I agree, looking into how Rubocop extensions can use ConfigObsoletion would be nice.
Which makes me thing – do we need a forum for discussing RuboCop extensions together with maintainers of the other official extensions?

While not fixed in master branch yet, this issue is fixed in the release-2.0 branch which will be merged into master soon.
Closing.


Fix export path of createMockCookies

Apparently createMockContext was exported instead.
Thanks

CLA signed.

Thanks for the fix @nuc, sorry it took us so long to merge :(


Change BaseAnalysis.run to return ExperimentData

Summary
This simplifies the signature of the function. It is also the behavior we need if we want to be able to make a new experiment data container for re-run analysis results.
Details and comments
Now there is also no difference in return from experiment.run_analysis(data, **options) and analysis.run(data, **options)

Since analysis runs in a child thread, any exception doesn't get surfaced to the main thread. When you do exp_data = experiment.run(), the returned exp_data has an errors() method that would return any exceptions happened in child threads (status() would also show error). But if you create a new exp_data, if _run_analysis blows up, it can't return the new exp_data, and the original exp_data won't have that information either.