Allow jsonnet imports in pipeline configuration

Having large projects using e.g., mono repo managing pipeline configurations becomes quickly quite cumbersome and error-prone. Having the ability to split the single pipeline configuration into multiple jsonnet files makes it a bit easier to manage.
Implementation in this pull request is based on old drone/drone-jsonnet-config with updates.
I've tested this to work with gitea. I've an open question still which token should be used in the scm Find call, now it's using user token, but this likely should be a token bound to drone SCM user itself. But is there any preferable way to retrieve that?

Could you explain how this would work for an end user, to give some added context.

Sure, for an end-user, the pipeline configuration would look like the following example https://gist.github.com/hhamalai/506b2d0f533957eff4e7324b4ba52ecd

@hhamalai I'm not sure but if you use the drone-converter-plugin for jsonnet already work as you report, we use it in a multi-file configuration.

@hhamalai
Thank you for making those changes so quickly. Can I ask one more thing, can you revert to go.mod & go.sum files, please.
Typically we don't change these unless we have a purpose for the change. Unless you have a reason for doing so, then it should just include that change(s)

@hhamalai
Thank you for making those changes so quickly. Can I ask one more thing, can you revert to go.mod & go.sum files, please.
Typically we don't change these unless we have a purpose for the change. Unless you have a reason for doing so, then it should just include that change(s)

Right, these were updated accidentally by my IDE, not intentionally. I reverted changes to go dependency files and checked that the jsonnet imports work as expected.

@bradrydzewski This PR is waiting for your approval, I'm glad to discuss about these changes and provide further improvements if needed.
Cheers,

@bradrydzewski This PR is waiting for your approval, I'm glad to discuss about these changes and provide further improvements if needed.

That would be great! I would also benefit from getting these changes to mainline.

@hhamalai
Can you resolve the conflicts, please?

@eoinmcafee00 Thanks for the heads up, rebased against latest master.

I feel like we should only load the vm importer if the fileService is not nil.  The main concern that I have is that fileService is always going to be nil when invoked from the template package.  If a template defines an import, the vm.Importer code will be used and could panic because the fileService is nil.
+if fileService != nil {
	vm.Importer(
		&importer{
			repo:        req.Repo,
			build:       req.Build,
			limit:       limit,
			user:        req.User,
			fileService: fileService,
		},
	)
+}

Added tests for these cases when limit is 0 and when fileService is nil, both expecting failure when jsonnet imports are used, and success when no jsonnet imports are used.

My pipeline failes when trying to import a json file in the root of the repository.
local info = import 'info.json';
local hosts = std.objectFields(info.nixosConfigurations);

local steps_hosts() = [
  {
    name: 'Build host: %s' % host,
    commands: [
      "nix build -v -L '.#nixosConfigurations.%s.config.system.build.toplevel'" % host,
    ],
  }
  for host in hosts
];

Is there something I have to manually enable for this to work with drone?
This is what I see in the web UI of drone:
RUNTIME ERROR: couldn't open import "info.json": no match locally or in the Jsonnet library paths .drone.jsonnet:7:14-32 thunk <info> from <$> .drone.jsonnet:17:34-38 <std>:1293:24-25 thunk from <function <anonymous>> <std>:1293:5-33 function <anonymous> .drone.jsonnet:17:17-59 function <steps_hosts> .drone.jsonnet:(10:3)-(18:4) .drone.jsonnet:59:7-20 object <anonymous> During manifestation

I'm having the same problem as @pinpox. @hhamalai can you help us?

Hi,
To make sure, you've set the following environment variables for your deployment:
            - name: DRONE_JSONNET_IMPORT_LIMIT
              value: "5"
            - name: DRONE_JSONNET_ENABLED
              value: "true"

Which drone release version are you using? Also, what's the source code management backend you are using?

I had only set DRONE_JSONNET_ENABLED because DRONE_JSONNET_IMPORT_LIMIT is not documented anywhere. Adding the import limit seems to have solved the problem for me.
Maybe DRONE_JSONNET_IMPORT_LIMIT  should be added to the reference? Correct me if I overlooked the documentation for it, but I couldn't find it.

Thanks for confirming the working setup. The documentation and the error message require a bit of improvement there. The latter might be trickier to achieve due to the JSONnet library used.

Hey @pinpox
If you've noticed something missing from the docs, please feel free to raise a PR https://github.com/drone/docs to add it & I'll take look / get it merged.
Cheers,
Eoin

@eoinmcafee00 I'd do that if I know what the variable exactly does. Will it just set the amount of files that can be imported? Should this be documented on the jsonnet page of the docs aswell?


[Bug] Error Interface In My laptop

Device
Laptop
Operating System
Windows
Browser
Chrome/Edge/Chromium
Browser Version
124
Better xCloud Version
4.3.0
Reproduction Steps

Did you install the script inside Tampermonkey?

Did you install the script inside Tampemonkey

Of Course

Show screenshot of tampermonkey's dashboard & chrome://extensions

After the last Tampermonkey update, I saw a note in the changelog that it will soon be necessary to enable "developer mode" in the browser for Tampermonkey to continue to work.
See here (changelog for version 5.1.1):
https://www.tampermonkey.net/changelog.php
@redphx: I don't know if this is the reason causing this issue, but it may also be something to keep in mind for future releases when people might open bug reports here because of that change.


Authentication SMS messages are never received by my Twilio phone number

I have set up my Twilio phone number with some services that require a code sent by SMS for authentication. Although I do receive ordinary SMS messages successfully on this number, I have never received any of the authentication messages.

Until recently, I did not know what made these authentication SMS messages special. I contacted the support of the authentication service provider and they assured me that the SMS messages had been successfully sent on their end, but nothing was showing in my Twilio console.
I perused the Twilio knowledge base searching for any issue related to the failed reception of SMS messages and I found the following issue of interest:

Can Twilio numbers receive SMS from a short code?

By default, Twilio long code numbers cannot receive messages from short code numbers. (...)

I checked the details of these authentication SMS messages on a regular mobile phone where they had been successfully received and I confirmed that the sender was not shown as an international phone number but as a short text identifier.
I considered carefully the different limitations of inbound SMS sent from short codes, as stated in the knowledge base article:

The setting is applied to your Twilio Account SID, and will affect all of the long code (local, national or mobile) SMS-capable numbers that belong to the Account SID you have requested.

I have a single phone number in my account, so that's not an issue for me. But if I intended to create additional phone numbers for a different usage, I understand that I should create a separate account for that. I currently have three of these Twilio accounts all accessible from the same user login. I can switch easily from one to another using a menu at the top of the page, it is only relatively cumbersome.

Short codes and Toll-Free numbers cannot receive SMS from short codes, and will not be affected by this setting.

I have a regular Twilio phone number, I am not affected by that.

By design, a short code number can only send messages to long code numbers from the same country as that short code. In order to receive messages, you must use a Twilio number from the same country as the short code. For example, if you are trying to receive messages from a Canada short code, you will need to use a Canada Twilio number.

That's good to know. When signing up to an online service in a different country, my Twilio phone number may or may not receive short code authentication messages. They won't be received unless the service provider has registered their short code number in the same country as the one of the phone number I have used to sign up.

Twilio cannot guarantee that every short code globally will be able to reach Twilio numbers, even if the Twilio number is from the same country as the short code. There may be  cases where an external short code carrier does not have reach to Twilio, or some other technical issue prevents those messages from reaching our platform.

Got it. There is no guarantee to receive short code messages from certain service providers even once the feature has been enabled.

Some companies may choose only to send OTP codes to mobile numbers. This is common in larger companies including OTP from Apple, Microsoft, Google, Facebook, and WhatsApp.

Got it. Some of the largest service providers may refuse outrightly to send authentication messages to phone numbers that they identify as provided by a VoIP platform rather than a regular phone company.

You will NOT be able to send outbound messages to these short codes. Therefore, you will not be able to reply, opt out via "STOP," or send "HELP" messages. Before enabling this setting, our Support team will send you a disclaimer from our Legal team and ask you to confirm that you understand and accept this particular limitation.

That may or may not be an issue. I don't remember the last time I had to provide an answer to a notification SMS by answering by SMS. That is not certainly not happening with any authentication messages anyway.

I have acknowledged and agreed to the limitations and confirmed my request by providing the Twilio Account SID which can be found in the Account Info section on the home page of each account.

The feature has been enabled for my three Twilio accounts. After making a new authentication test, I received the SMS messages immediately. The Twilio console logged the sender as a short number of 5 digits.
I am glad that it worked for me with this service provider, although I understand that different providers may or may not succeed to send me authentication messages in the same way. YMMV.

Mate have you tried whatsapp and received the code?

No, I have not tried to receive SMS messages from WhatsApp. AFAIK, you need to have WhatsApp installed on an actual mobile phone anyway, even to use it on a computer. WhatsApp Web displays a QR code that you need to scan from the app to activate it, and the mobile phone needs to keep an active Internet connection to keep WhatsApp Web running on the computer.
I have used an Android emulator to run WhatsApp inside a virtual mobile phone on a computer. It worked but it was too cumbersome so I stopped after a short while.

@eric-brechemier no worries. Thanks


Default attachment widget for dropdown

The widget argument in DropDown open method becomes optional. Added default behaviour attaches the DropDown object to the parent if no widget is specified.

The patch unfortunately breaks the basic example at the bottom of the file - it doesn't remove the dropdown. Try to make this little change and you'll see for yourself. Also, maybe try to check even with something you've tested before (please paste an example if possible).
if __name__ == '__main__':
    from kivy.uix.button import Button
    from kivy.base import runTouchApp

    def show_dropdown(button, *largs):
        dp = DropDown()
        dp.bind(on_select=lambda instance, x: setattr(button, 'text', x))
        for i in range(10):
            item = Button(text='hello %d' % i, size_hint_y=None, height=44)
            item.bind(on_release=lambda btn: dp.select(btn.text))
            dp.add_widget(item)
        button.add_widget(dp)
        dp.open()

    def touch_move(instance, touch):
        instance.center = touch.pos

    btn = Button(text='SHOW', size_hint=(None, None), pos=(300, 200))
    btn.bind(on_release=show_dropdown, on_touch_move=touch_move)

    runTouchApp(btn)

Although DropDown is kind of Popup-ish (not supposed to be added as a child anywhere), this behavior could actually work if the dismissing was properly fixed.

On the other hand, we're getting into a situation where Spinner might be a better choice for you as that widget has the proper dismissing. Also, backporting features from Spinner to Dropdown isn't that much desired as that's actually why those widgets are separated.

Thanks for the review. I made changes so that the previous behaviour is preserved, and when the DropDown is explicitly added on a parent, it still functions properly.
The way I see it, the existence of a parent for a dropdown is an intuitive assumption, as typical DropDown function is to show a range of values when a widget (presumably parent) is selected, and - when one of the values is selected - to change the value/text of a widget (again, presumably the parent).
About the spinner, which is a good suggestion:
I did not realise spinner was essentially a button with a dropdown in one. That is a simple solution. Still, the name 'spinner' makes it hard to identify as such. What I expect to find under the name 'spinner' would be either a value selection on a spinning scale (like date in iOS), or some element with circular appearance (like the loading animation of round rotating arrow, dots or bars).
It would be great if DropDown documentation linked to the spinner as a shortcut solution. It would be easier to find, and probably more often used.

I tested the changes and it works fine from the Python side. However it kind of doesn't from the KV side. It's not a fault of this PR, but from the design of DropDown, ModalView and Popup widgets. Those aren't meant to be added as a child anywhere, therefore if you add it to any widget you'll immediately see the DropDown.
This can be fixed by a silly on_parent + DropDown.dismiss(), but in my opinion this introduces an idea that those widgets actually are meant to be added as a children. I'll leave the PR open for now, so perhaps other core devs will join the discussion too. Widgets such as DropDown use the Window as a parent, because they are meant to be above of every other widget. Pseudo Z-axis if you will, because Kivy doesn't have a concept of Z-axis (well, at least by default). Some people don't like it, but it keeps things simple.
If a widget supposed to be above all already existing widgets is added as a child to an ordinary widget, it gets a parent and can't be added to the Window unless explicitly removed from the current parent. This is basically the silly on_parent + dismiss(). Also, the instances of these widgets are (or at least should be imo) disposable. For example on each open() the instances are new:
from kivy.app import runTouchApp
from kivy.lang import Builder

runTouchApp(Builder.load_string('''
#:import Factory kivy.factory.Factory
<Penguin@Button>:
    size_hint_y: None
    on_parent: self.text = str(self)

<FlyingCarpet@Popup>:
    title: str(self)
    Button:
        text: 'Aladout'
        on_release: root.dismiss()

<MrPopper@DropDown>:
    Penguin:
        on_release: root.dismiss()
    Penguin:
        on_release: root.dismiss()
    Penguin:
        on_release: root.dismiss()

BoxLayout:
    Button:
        text: 'Aladin'
        on_release: Factory.FlyingCarpet().open()
    AnchorLayout:
        Button:
            size_hint_y: None
            text: 'Pop!'
            on_release: Factory.MrPopper().open(self)
'''))

If you think of these type of widgets only as of some kind of container, you'll get the idea why it's easier to use it this way i.e. Popup is just a "template" you can add other widgets into and a DropDown you can imagine as a handler for a this kind of menus.


Asma/temporal interpolation/origin

temporal interpolation modifications to include both BERT and global modes
At the beginning, this branch was based on iluise/head
I pulled and merged the changes from develop, now it is in sync with develop
I deleted previous branch asma/temporal-interpolation/origin and asma/temporal interpolation iluise/origin as this push includes the changes from both.
test function for temporal interpolation mode is included here

Hi, is it ready for review or I should wait for the tests with the overlap?

Yes, it is ready for review :crossed_fingers: . Already got the results with the token overlap.


[manifests] update cluster role verbs for meshery-server service account

Signed-off-by: Rudraksh Pareek<EMAIL_ADDRESS>Description
If you deploy meshery server and a service mesh adapter using k8s manifests, the resources would use the meshery-server service account. However due to missing permissions, the service mesh installation would fail:
time="2021-09-23T20:51:39Z" level=info msg="Installing using helm charts..." app=istio-adaptor
time="2021-09-23T20:51:44Z" level=error msg="clusterroles.rbac.authorization.k8s.io \"istiod-istio-system\" is forbidden: user \"system:serviceaccount:meshery:meshery-server\" (groups=[\"system:serviceaccounts\" \"system:serviceaccounts:meshery\" \"system:authenticated\"]) is attempting to grant RBAC permissions not currently held:\n{APIGroups:[\"networking.k8s.io\"], Resources:[\"ingresses/status\"], Verbs:[\"*\"]}" app=istio-adaptor code=1025 probable-cause= severity=2 short-description="Error occured while applying Helm Chart" suggested-remediation=

This PR fixes the above issue by giving appropriate perms to the service account.
Signed commits

[x] Yes, I signed my commits.

Codecov Report

Merging #4237 (600a200) into master (80e4292) will decrease coverage by 7.77%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4237      +/-   ##
==========================================
- Coverage   28.05%   20.28%   -7.78%
==========================================
  Files          59       59
  Lines        5043     5043
==========================================
- Hits         1415     1023     -392
- Misses       3208     3722     +514
+ Partials      420      298     -122

Flag
Coverage Δ

gointegrationtests
?

unittests
20.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

mesheryctl/internal/cli/root/system/status.go
0.00% <0.00%> (-62.83%)
:arrow_down:

mesheryctl/internal/cli/root/system/start.go
0.99% <0.00%> (-53.98%)
:arrow_down:

mesheryctl/internal/cli/root/system/restart.go
2.50% <0.00%> (-47.50%)
:arrow_down:

mesheryctl/internal/cli/root/system/stop.go
0.85% <0.00%> (-36.76%)
:arrow_down:

mesheryctl/internal/cli/root/system/update.go
1.05% <0.00%> (-34.74%)
:arrow_down:

mesheryctl/internal/cli/root/system/check.go
1.39% <0.00%> (-22.38%)
:arrow_down:

mesheryctl/internal/cli/root/system/logs.go
0.00% <0.00%> (-21.60%)
:arrow_down:

mesheryctl/internal/cli/root/system/config.go
8.61% <0.00%> (-0.96%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f059ed9...600a200. Read the comment docs.

cc @panyuenlau

Hopefully, this is the final stand against manifest-based Kubernetes deployments.


Use of our registered company name

Simpler Software is our registered company name. Can we kindly ask you to please change the name you are using so that we can move forward with using our company name as a organization on GitHub?

Hi John, we also have a registered company name of Simpler Software which is why we have the name on GitHub :)  I apologize for any inconvenience.

I'm sorry, but you don't have it registered. Only one entity can have a name registered and copyrighted. You may have it DBA'd in your local county. We have had a LLC with it and had the domain also registered for over 16 years.

Hi John, perhaps we're not talking about the same kind of registration.  Anyway, let me clarify for you what I mean:  We are a registered company with the name 'Simpler Software LLC' (As far as I know you can have the same name as long as another company is not registered in the same state with the same name).  We have been doing business for the last 7 years using this name.  We own the domain 'simpler-software.com' (although nothing is parked there).  We have other websites for specific products that we sell.  I checked the US Trademark website to see if the name 'Simpler Software' had been trademarked and I did not see anything that indicated that it was a registered trademark (Names or simple phrases cannot be copyrighted, see here ).  Again, I apologize for any inconvenience but as far as I can tell we have just as much of a right to use this name as you do.


AM-2998 mtls for OIDC provider

MTLS configuration capability for WebClient for OIDC idp provider

please add the master label to the PR


NTR: drainage ditch

Proposed Term Label
drainage ditch
Proposed Associated Field(s)
environmental site
Definition/Description
A ditch that collects water from the surrounding land.
Definition Source
No response
Guidance
No response
Alternative labels and/or synonyms
No response
Additional Comments (not an annotation)
Existing term ENVO:00000140. Needs adding to environmental site after discussion between EG and CB on 7/8/24.
Optional - Contributor Attribution
No response

Have also added Ditch [ENVO:00000037] and Irrigation ditch [ENVO:00000139] to the term list.

PR #96


feat: implement token api

Implements a new Token API based on a new token.md design.

Unit tests passed locally now. It should work, because fake doesn't generate tokens by default (or any kind of data).

Closing since this is outdated and the feature will be re-worked in a different PR


Update Contour to v1.13.0

This patch updates Contour to v1.13.0.
/kind enahancement
Release Note
Release yaml includes contour v1.13.0.

Contour v1.13.0 starts Gateway API Support https://github.com/projectcontour/contour/releases/tag/v1.13.0.

/cc @dprotaso @tcnghia
Matt is absent :cry:


Different container behavior depending on where the image is built

Using the docker hub image (wtsidney/lastpass-cli:ubuntu), the lpass binary core dumps on a RHEL 7.2 system.
lpass works without a core dump on ubuntu 14.04 and boot2docker docker hosts.
The automated build of this image  (wtsidney/lastpass-cli:latest) works correctly on RHEL, Ubuntu and boot2docker on my Mac.
My build server is a Ubuntu server - and that build fails to run on RHEL 7.2.
It is also interesting, the image size is different from different build hosts. (https://hub.docker.com/r/wtsidney/lastpass-cli/tags/)

wtsidney/lastpass-cli:ubuntu - 236 MB
wtsidney/lastpass-cli:latest (automated build) - 233 MB
wtsidney/lastpass-cli:boot2docker - 255 MB

Output of docker version:
RHEL 7.2 SYSTEM: AWS - AMI (ami-775e4f16)
[ec2-user@ip-10-52-1-247 ~]$ uname -r
3.10.0-327.el7.x86_64

install docker using https://docs.docker.com/engine/installation/linux/rhel/ by adding the yum repo

rhel$ docker version

Client:
 Version:      1.11.2
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   b9f10c9
 Built:        Wed Jun  1 21:23:11 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.11.2
 API version:  1.23
 Go version:   go1.5.4
 Git commit:   b9f10c9
 Built:        Wed Jun  1 21:23:11 2016
 OS/Arch:      linux/amd64

UBUNTU 14.04 SYSTEM: AWS - AMI (ami-c0c439a0)
ubuntu$ uname -r
3.13.0-85-generic

ubuntu$ docker version
Client:
 Version:      1.10.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   20f81dd
 Built:        Thu Mar 10 15:54:52 2016
 OS/Arch:      linux/amd64

Server:
 Version:      1.10.3
 API version:  1.22
 Go version:   go1.5.3
 Git commit:   20f81dd
 Built:        Thu Mar 10 15:54:52 2016
 OS/Arch:      linux/amd64

Output of docker info:
RHEL 7.2 SYSTEM: AWS - AMI (ami-775e4f16)
rhel$ docker info
Containers: 14
 Running: 1
 Paused: 0
 Stopped: 13
Images: 14
Server Version: 1.11.2
Storage Driver: overlay
 Backing Filesystem: xfs
Logging Driver: json-file
Cgroup Driver: cgroupfs
Plugins:
 Volume: local
 Network: host bridge null
Kernel Version: 3.10.0-327.el7.x86_64
Operating System: Red Hat Enterprise Linux Server 7.2 (Maipo)
OSType: linux
Architecture: x86_64
CPUs: 2
Total Memory: 6.897 GiB
Name: ip-10-52-1-247.us-west-2.compute.internal
ID: CBG4:UV67:IBBF:6ER4:5P3D:4IJC:U4CV:2SFU:G46C:XE4Q:M3YA:OFXZ
Docker Root Dir: /var/lib/docker
Debug mode (client): false
Debug mode (server): false
Username: kbroughton
Registry: https://index.docker.io/v1/
WARNING: bridge-nf-call-iptables is disabled
WARNING: bridge-nf-call-ip6tables is disabled

UBUNTU 14.04 SYSTEM: AWS - AMI (ami-c0c439a0)
$ docker info
Containers: 25
 Running: 22
 Paused: 0
 Stopped: 3
Images: 75
Server Version: 1.10.3
Storage Driver: btrfs
Execution Driver: native-0.2
Logging Driver: json-file
Plugins:
 Volume: local convoy-nfs
 Network: null host bridge
Kernel Version: 3.13.0-85-generic
Operating System: Ubuntu 14.04.3 LTS
OSType: linux
Architecture: x86_64
CPUs: 8
Total Memory: 31.42 GiB
Name: ip-10-2-0-234
ID: OHM4:GYTJ:52BG:MUKF:SWUV:CSKF:OQC4:ICR6:A72F:LY44:ECLL:R63L
Username: kbroughton
Registry: https://index.docker.io/v1/
WARNING: No swap limit support

Additional environment details (AWS, VirtualBox, physical, etc.):
AWS Availability zone: us-west-2a
RHEL 7.2 SYSTEM: AWS - AMI (ami-775e4f16)
UBUNTU 14.04 SYSTEM: AWS - AMI (ami-c0c439a0)
Steps to reproduce the issue::
You will need an aws ubuntu, aws rhel instance and a free account on lastpass.
$ docker run -it wtsidney/lastpass-cli:ubuntu bash
# lpass login bill
Success: Logged in as bill

# lpass ls
Illegal instruction (core dumped)

Describe the results you received:
From a gdb session of the core dump: blob_parse is in lastpass-cli github
(https://github.com/lastpass/lastpass-cli)
Within the container installed gdb

# gdb /usr/bin/lpass core.<29>
# bt

Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `lpass ls'.
Program terminated with signal SIGILL, Illegal instruction.
#0  0x0000000000405a3f in blob_parse ()
(gdb) bt

#0  0x0000000000405a3f in blob_parse ()
#1  0x0000000000407226 in blob_get_latest ()
#2  0x000000000040782b in blob_load ()
#3  0x000000000040e7c6 in init_all ()
#4  0x000000000040b75a in cmd_ls ()
#5  0x00000000004044ea in main ()
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
Core was generated by `lpass ls'.
Program terminated with signal SIGILL, Illegal instruction.
#0  0x0000000000405a3f in blob_parse ()
(gdb) bt
#0  0x0000000000405a3f in blob_parse ()
#1  0x0000000000407226 in blob_get_latest ()
#2  0x000000000040782b in blob_load ()
#3  0x000000000040e7c6 in init_all ()
#4  0x000000000040b75a in cmd_ls ()
#5  0x00000000004044ea in main ()

Describe the results you expected:
Had expected a listing of the lastpass vault items.
Additional information you deem important (e.g. issue happens only occasionally):

Disabling selinux on the RHEL system had no impact
Running the container in privileged mode had no impact

Illegal instruction normally means it is built for a different CPU arch. Can you get an assembly dump of the code where it crashes from gdb?

ping @wtsidney could you provide the info that @justincormack requested?

closing issue, due to no traction from reporter regarding requested information. Reopen once needed info is available.


Update EventPipe Default configuration to try enable both provider name and guid for CLR 2.1

When CLR 2.1 arrives, the enablement requires provider name than guid. Try to enable both for backward compatibility. Expect either name or guid will be hit but not both.

Fixed in 1.1.2-beta1: https://www.nuget.org/packages/Microsoft.ApplicationInsights.Profiler.AspNetCore/1.1.2-beta1


[discussion] AWS and graphql

I have POC app I want to build am considering options. I was wondering why you choose Firebase vs other cloud providers, I myself am tempted to try to modify my own version this to work with AWS over with graphQL. What do you think of that approach?

Actually I have planed to change structure so any one can use their own back-end. I'm figuring out how to make a clean structure. As I planned before the next I want to support AWS and I agree in some aspects it can be better choice.I am trying not to build an opinionated project.

Check out this for ideas: https://serverless-stack.com

You can completely separate the frontend display logic from api calls. If you use typescript you can create AWS or firebase interface adaptors for API methods.

Link: https://github.com/AnomalyInnovations/serverless-stack-com/issues/145

Thats cool. It's exactly what I imagined. Let's do it. 👍

If you want I can propose an interface to get started?

Sure, that's great. You are awesome. 👍

As  bare min:
/**
 * Authentication interface
 *
 */

export interface IAuthentication {

  /**
   * Logs out the user
   * @returns {Promise<void>}
   */
  logout: () => Promise<void>

  /**
   * Gets the user basic on local assets (tokens, cookies etc)
   * @returns {Promise<void>}
   */
  getCurrentUser: () => Promise<void>

  /**
   * @returns {Promise<void>}
   */
  authenticateUser: () => Promise<void>

  /**
   * @returns {Promise<void>}
   */
  registerUser: () => Promise<void>

  /**
   * @returns {Promise<void>}
   */
  emailConfirmUser: () => Promise<void>
}

Concrete impl for AWS would be smth like https://github.com/AnomalyInnovations/serverless-stack-demo-client/blob/master/src/libs/awsLib.js

Perfect 👍. I should open a service layer so the structure is similar to this. I would be happier with this.

Even Azure could be a consideration as it has easier functions than AWS, ie can group per app, and simpler http endpoint wiring. Although serverless framework abstracts this for AWS deployment.

@QuantumInformation , thank you so much for recommending  https://serverless-stack.com as I just spent the last 6 days learning and building out their scratch app with AWS. Have you modified your own version to work with AWS, yet? @Qolzam, are you planning more AWS serveless modifications of this project? Thank you guys for allowing me to look up to you. I am a newbie at this.


Fix Keycloak doc examples for OCP 4.9

Fix keycloak example .yaml files
Clean up from downstream testing

@jsenko @EricWittmann Can you please review and merge this one? Thanks!

Thank you @smccarthy-ie !


Text input bar is hidden after the keyboard is appeared.

In - (BOOL)detectExternalKeyboardInNotification:(NSNotification *)notification, the following line of code returns YES even there is no external keyboard:
return (maxKeyboardHeight > CGRectGetHeight(self.view.bounds));
Due to floating point error, maxKeyboardHeight may be greater than the view's height even in the cases that they should be equal. The result of this error is that the text input bar is not shifted up after the keyboard is appeared. The user cannot see the text input bar.
I propose the following fix:
return (floor(maxKeyboardHeight) > CGRectGetHeight(self.view.bounds));

This is happening again with SlackTextViewController (1.4.1).

I have the same problem in (1.4.1).
Just started using SlackTextViewController and also the Container View in Interface Builder so at first a thought it was a problem with that.
Downgraded to 1.4 and it works, if I get some time over I will try and debug it.
Awesome component btw!


k3s: 1.28.14+k3s1 -> 1.28.15+k3s1, 1.29.9+k3s1 -> 1.29.10+k3s1

Things done
k3s: 1.28.14+k3s1 -> 1.28.15+k3s1
https://github.com/k3s-io/k3s/releases/tag/v1.28.15%2Bk3s1
k3s: 1.29.9+k3s1 -> 1.29.10+k3s1
https://github.com/k3s-io/k3s/releases/tag/v1.29.10%2Bk3s1

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

@NixOS/k3s

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 356795

aarch64-linux

:white_check_mark: 2 packages built:

k3s_1_28
k3s_1_29


Line chart ylabel displayed to >10 decimal places

Hey guys,
I'm working on something that requires me to plot large numbers in a line chart in real time. I've encountered a problem where these numbers will be displayed to >10 decimal places, cutting into a  significant portion of chart space:

This also seems to create a problem when the chart is initiated without a data point; the first two data points won't be connected to the line or the colour beneath:

Here's the code I used to generate these:
var chartData = {
    labels: [],
    datasets: [{
        fillColor: "rgba(220,220,220,0.2)",
        strokeColor: "rgba(220,220,220,1)",
        pointColor: "rgba(220,220,220,1)",
        pointStrokeColor: "#fff",
        pointHighlightFill: "#fff",
        pointHighlightStroke: "rgba(220,220,220,1)",
        data: []
    }, ]
};

var graphWriteCount = 0;
var labelCount = 0;
var number = 2.6e24;
var chartCanvas = document.getElementById("chartCanvas");
var ctx = chartCanvas.getContext("2d");
var mainChart = new Chart(ctx).Line(chartData);

function mainfun() {
  if (graphWriteCount >= 10) {
    mainChart.addData([number], labelCount);
    if (labelCount >= 30) {
        mainChart.removeData();
    }
    number += 0.500000001e24;
    labelCount++;
    graphWriteCount = 0;
  }

  graphWriteCount++;
  window.requestAnimationFrame(function() {
      mainfun();
  });
}

window.onload = function() {
  mainfun();
}

I'd be happy to do as much as I can to fix this as I've got a bit of time on my hands, however I'm really not familiar with chart.js so I'd need a bit of guidance.
Cheers

@mg393 as a quick fix you could try changing the label template string by adding the following to your config.
config = {
    scaleLabel: '<%= value.toLocaleString() %>'
}

Then add the config when building your chart as follows
var mainChart = new Chart(ct.).Line(chartData, config);

@etimberg doesn't seem to make a difference

hmmm, you can always provide a function for the scaleLabel config option. The input to the function is an object that contains among other things the value. You could then return a formatted label.
I tried some variations of toLocaleString using the custom options to limit the number of significant digits however nothing seemed to work. I also tried toFixed and toPrecision without much luck.

I was able to fix the problem (for myself at least) by changing line 1562 in Chart.Core.js from
this.yLabels.push(template(this.templateString,{value:(this.min + (i * this.stepValue)).toFixed(stepDecimalPlaces)}));

to use .toPrecision() instead:
this.yLabels.push(template(this.templateString,{value:(this.min + (i * this.stepValue)).toPrecision(2)}))

Not really a better option in general since it makes smaller numbers pretty ugly but it works as a quick fix for my problem at least. Maybe some kind of check to see if the number is over a certain size? I'm not sure how often this problem is likely to arise (i.e. probably not very!)

So I've been playing around with the for loop at line 1558 a bit, I've replaced the contents with this which seems to work quite nicely:
if ((this.min + (i * this.stepValue)) < 1e+7) {
    this.yLabels.push(template(this.templateString,{value:(this.min + (i * this.stepValue)).toFixed(stepDecimalPlaces)}));
} else {
    this.yLabels.push(template(this.templateString,{value:(this.min + (i * this.stepValue)).toPrecision(3)}));
}

I chose 1e+7 as the threshold because the numbers become difficult to read around about there anyway, and using toPrecision(3) produces a label of 7 characters, which doesn't take up too much real estate. Let me know what you think.

Hello, today I am closing all issues that are only affecting version 1 of Chart.js as WONTFIX.
If this issue does affect version 2 as well, I apologize for the error. Please create a test case against Chart.js 2 using on of the below websites and we will be happy to reopen the issue and update its classification:

http://jsbin.com/
http://jsfiddle.net/
http://codepen.io/pen/
Premade template: http://codepen.io/pen?template=JXVYzq


Nesting columns triggers error

Bootlint doesn't support Nesting columns
http://getbootstrap.com/css/#grid-nesting
example html:
http://jsfiddle.net/4wd9t9nt/
getting E013

Can you provide anymore information about browser, Bootlint version, etc.? I can't recreate E013 with that fiddle's output. E013 and E014 deal specifically with linting the correctness of nested columns.

Chrome 41, Bootlint 0.10.0 using the snippet.

Unable to reproduce with http://jsfiddle.net/ubf6tvpn/1/ on either Chrome 40 or 42, both on OS X.


How to move active bar now?

I found an issue from 2021. I looked in the configs, but there is only origins-common.toml. How...

Check through one of the Apoli configs.

You are able to look through apoli-client.toml, which will have:
[resources_and_cooldowns]
	hud_offset_x = 0
	hud_offset_y = 0

Set hud_offset_x and hud_offset_y and you're good to go!


Pipelines can't restart when interrupted due to different fov_index parameters in OptimizeIteration

When trying to rerun a merlin pipeline after it has failed or been interrupted, merlin fails early with an error complaining about a task already existing.
merlin.core.analysistask.AnalysisAlreadyExistsException: Analysis task with name Optimize1 already exists in this data set with different parameters.

It looks like this is happening because the when the fov_index parameter is not set for an OptimizeIteration task, it is generated with np.random.choice which returns different values each time it runs.

workaround is to add the randomly generated parameters to the .json specifying the analysis tasks.
some ideas to fix for the future

add a fov_index_seed parameter to reproducibly generate fov_index

or generate the seed from the analysis
allow tasks to specify which parameters to ignore when checking if parameters are identical

could allow tasks to reuse or regenerate these parameters


sees to me new erlang (23.X) version fails with this erl_interface param

based on docs it should be deprecated only, but I have error:
/usr/bin/ld: cannot find -lerl_interface
collect2: error: ld returned 1 exit status

Thanks for your contribution


Feature :: fillna step

Allow to click on "Fill null values" from the header menu of a column, which open the corresponding form to be edited in the left panel. When validating, a new fillna step is inserted in the pipeline.
This is the second step we implement in terms of UI (after "rename step"). To instantiate the correct form depending on the selected transformation, we render it through a step mapper which maps operation names to their related form component. The rendering is dynamic using a vue <component/> balise.
Related to https://github.com/ToucanToco/vue-query-builder/issues/33

Codecov Report

Merging #165 into master will increase coverage by 0.52%.
The diff coverage is 93.75%.

@@            Coverage Diff             @@
##           master     #165      +/-   ##
==========================================
+ Coverage   85.79%   86.32%   +0.52%
==========================================
  Files          29       31       +2
  Lines         690      746      +56
  Branches       79       84       +5
==========================================
+ Hits          592      644      +52
- Misses         85       87       +2
- Partials       13       15       +2

Impacted Files
Coverage Δ

src/lib/translators/mongo.ts
97.24% <ø> (ø)
:arrow_up:

src/components/ActionMenu.vue
77.77% <100%> (+2.77%)
:arrow_up:

src/components/constants.ts
100% <100%> (ø)
:arrow_up:

src/components/FormRenameStep.vue
100% <100%> (ø)
:arrow_up:

src/components/FormFillnaStep.vue
100% <100%> (ø)

src/assets/schemas/index.ts
100% <100%> (ø)
:arrow_up:

src/components/Vqb.vue
81.81% <62.5%> (-5.03%)
:arrow_down:

src/components/formlib.ts
87.5% <87.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8edaf74...2222690. Read the comment docs.

 ETQD je peux instancier plusieurs formulaires de step


Import functionality

A generic (read extensible) import interface would be great. Then we can contribute concrete import implementations for different sources.

From the file system (a server directory)
SimpleMedia
Others

cc @portugao

[ ] MUImage
[ ] MUVideo
[ ] SimpleMedia2
[ ] SimpleMedia
[ ] MUSound
[ ] MUFiles
[ ] MUFlash
[ ] Files
[ ] Locations
[ ] FAQ
[ ] Weblinks
[ ] Others

MUImage

Permission related Code
Access related Code

        /**
         * @ORM\Column(length=255)
         * @var string $albumAccess.
         */
        protected $albumAccess = null;

        /**
         * @ORM\Column(length=255)
         * @var string $passwordAccess.
         */
        protected $passwordAccess = '';

        /**
         * @ORM\Column(length=255)
         * @var string $myFriends.
         */
        protected $myFriends = '';

Disallow view for guest users:
        /**
         * @ORM\Column(type="boolean")
         * @var boolean $notInFrontend.
         */
        protected $notInFrontend = false;

Will be possible import library from Mediashare?

Will be possible import library from Mediashare?

Currently not, but I added it to the list.


cmd/go: race option doesn't work to test a code with binary-only package

What version of Go are you using (go version)?
go version go1.10.3 darwin/amd64
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/motomuohtski/Library/Caches/go-build"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/motomuohtski/go"
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/3t/1rcsh7wn6sb3_w2nbbnp0zc80000gn/T/go-build234195255=/tmp/go-build -gno-record-gcc-switches -fno-common"
What did you do?

Have a file ${GOPATH}/src/github.com/motomux/hellobop/src/hellobop.go

package hellobop

import "fmt"

func Hello(name string) string {
        return fmt.Sprintf("Hello %s from binary-only package!", name)
}

Have a header file ${GOPATH}/src/github.com/motomux/hellobop/hellobop_header.go

//go:binary-only-package

package hellobop

func Hello(name string) string {
}

Build binary by go build -o ${GOPATH}/pkg/darwin_amd64/github.com/motomux/hellobop.a -x ./src

Have a test file ${GOPATH}/src/github.com/motomux/hellobop/test/helloboa_test.go

Run test by go test ./test

Run test by go test -race ./test

Here is the repository to reproduce the issue.
What did you expect to see?
go test -race runs test without any error.
What did you see instead?
It's failed with the error
go build github.com/motomux/hello: missing or invalid binary-only package

Can you try adding a -o flag for the build (a target parameter for the output file) and run the test again please?

The binary-only package probably needs to be compiled in race mode, too.

@slrz You are right.
After running the following commands go test with/without race option works
go build -o ${GOPATH}/pkg/darwin_amd64/github.com/motomux/hellobop.a -x ./src
go build -race -o ${GOPATH}/pkg/darwin_amd64_race/github.com/motomux/hellobop.a -x ./src

We don't even need to build with race option to test.
After running the following commands go test with/without race option works
go build -o ${GOPATH}/pkg/darwin_amd64/github.com/motomux/hellobop.a -x ./src
go build -o ${GOPATH}/pkg/darwin_amd64_race/github.com/motomux/hellobop.a -x ./src


Release lock if fetchAndStore fail

If there is a failure while doing a forceRefresh on the cache, it will never release the lock. This means that any following request to the cache will just hang as the call to e.acquireSem() will wait forever.

@lestrrat I noticed this issue when using the jwks cache in https://github.com/lestrrat-go/jwx/tree/develop/v2/jwk. If there is an error when calling Refresh on the cache it gets into a state where the cache never gets updated again. So if this PR gets merged please update the package in go-jwx as well.

oh yikes, thanks.
sorry I didn't notice your initial comment, I needed to setup notification for this repo

Codecov Report

Merging #5 (be38932) into main (8e06023) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
+ Coverage   61.25%   61.36%   +0.11%
==========================================
  Files           6        6
  Lines         351      352       +1
==========================================
+ Hits          215      216       +1
  Misses        123      123
  Partials       13       13

Impacted Files
Coverage Δ

cache.go
66.66% <100.00%> (+0.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e06023...be38932. Read the comment docs.


Update Lando script

I have created a PR which updates Lando, as well as some other adjustments: #9.

Merged, thanks!

Great, thanks!


include option is not reloaded after restart on config change

Describe the bug
When config file is changed, vitest restarts.
But include option is not reloaded.
Reproduction
https://stackblitz.com/edit/vitest-dev-vitest-yrxx9p?file=vite.config.ts&initialPath=__vitest__

Run npm run test.
See test/basic.test.ts and test/suite.test.ts are included and test/basic.test.js is not included.
Change include in vite.config.ts to ['**/test/**/*.js'] from ['**/test/**/*.ts'].
See test/basic.test.ts and test/suite.test.ts are included and test/basic.test.js is not included.

the expected behavior here is "test/basic.test.ts and test/suite.test.ts are not included and test/basic.test.js is included"

System Info
stackblitz

vitest 0.7.4

Used Package Manager
npm
Validations

[X] Follow our Code of Conduct
[X] Read the Contributing Guidelines.
[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
[X] The provided reproduction is a minimal reproducible example of the bug.

After upgrading vitest to 0.24.1, it worked. :tada:


Cyrillic issue

Steps to Reproduce
Feeds with Cyrillic are displayed incorrectly
Expected behavior
Screenshot below

Screenshots or screen recording

Device, Operating system, and app version
Any

feed https://4pda.to/feed

Thanks for the details @Sergo1217, and sorry that you ran into this. I have a fix that I'll publish in the next release.

The fix is available with 2024.12.1088-dev. Please reopen this issue if you keep seeing this bug!


Communicate with smart meters over GPRS

Story : communicate with smart meters over GPRS
Always-on:
Be able to select that communication mode : via GPRS

On demand:
Be able to discover that the meter has an active communication session / started
Can deal with dynamic IP addresses of the meters.
Can handle jobs that not directly can be sent  to the meter.

If a GPRS device has a dynamic IP address, OSGP has to be able to handle those. I will check if that's already supported.

@elhachhouchi can we close this item? We already communicate over GPRS and dynamic IP addresses can be handled by the code (after Kevin's refactoring). Handling jobs and active/inactive communication sessions will be part of #187 (Send an SMS wake up message).


Fix version mismatch between setup.py and setup.conf

The current version on PyPI is also 0.7.5.

Thank you for you contribution, we are still looking into cleaning up the build metadata & build process.


ollama save  feature

Can you add the feature of ollama save as well as docker save that export the local docker image to migration to other envenriment?

@CorollaD Do you want to copy a single model, or all of the models?

@CorollaD Do you want to copy a single model, or all of the models?

I want to know to copy a single model, did ollama support this function now?

Currently there's no way to export a single model, however, you can copy the models directory if you want to copy all of them. This is actually a dupe of #335 (which is old, but let's track it there).


BLD: upgrade pylint for python 3

Upgrade pylint to 2.x for python 3.6 environment. Fix make sanity-check hanging problem.

Thank you, Kyle :-)

Thanks Facai!


Closes: #1

Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py.
Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

[ ] Tests pass
[ ] Appropriate changes to README are included in PR

As a Coursera assignment in module 4 in Git course
Updated validations.py python script.
Fixed the behavior of validate_user function in validations.py. by @DemoUser-22

Everything is up to date


server: platform specific tty handling

Signed-off-by: Vincent Batts<EMAIL_ADDRESS>
- What I did
- How I did it
- How to verify it
- Description for the changelog

/retest

/test all


Kconfig:9: unknown option "rsource"

❯ scons --menuconfig
scons: Reading SConscript files ...
scons: Entering directory /Users/charlie/rt-thread-5.0.2/tools/kconfig-frontends' scons: Reading SConscript files ... scons: done reading SConscript files. scons: Building targets ... scons: .' is up to date.
scons: done building targets.
Cloning into '/Users/charlie/.env/packages/packages'...
remote: Enumerating objects: 21016, done.
remote: Counting objects: 100% (2133/2133), done.
remote: Compressing objects: 100% (310/310), done.
remote: Total 21016 (delta 1869), reused 1969 (delta 1822), pack-reused 18883
Receiving objects: 100% (21016/21016), 3.59 MiB | 789.00 KiB/s, done.
Resolving deltas: 100% (11596/11596), done.
Cloning into '/Users/charlie/.env/tools/scripts'...
remote: Enumerating objects: 2199, done.
remote: Counting objects: 100% (339/339), done.
remote: Compressing objects: 100% (128/128), done.
remote: Total 2199 (delta 227), reused 261 (delta 210), pack-reused 1860
Receiving objects: 100% (2199/2199), 2.55 MiB | 1.38 MiB/s, done.
Resolving deltas: 100% (1478/1478), done.
Kconfig:3:warning: environment variable BSP_ROOT undefined
/Users/charlie/.env/packages/packages/Kconfig:4: syntax error
/Users/charlie/.env/packages/packages/Kconfig:3: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:4: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:5: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:6: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:7: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:8: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:9: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:10: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:11: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:12: unknown option "rsource"
/Users/charlie/.env/packages/packages/Kconfig:13: unknown option "rsource"

请升级最新的env即可解决问题：https://github.com/RT-Thread/env


Fix an issue with a deadlock for if(0) tasks

The issue was caused by the different counts for parent tasks, parent
threads (= implicit task in OpenMP lingo) was not maintained in the
right way.  This commit attempts to fix this.

I have found another issue with the EPCC benchmarks that I will fix as part of this PR.

@JimCownie This is now ready for review.

LGTM. I have some fixes for the GOMP task interface code in the GOMP_task function which check (and abort) more cases there too. They are in the GCCSupport branch.


Remove border from main frame

Now it should work with updated CSS class name 😉

@soul-wish You're on fire today! Thanks for the contributions.

Yeah! Thanks for such a great theme!


Immutable value of type 'Event' only has mutating members named 'add'

Seems the Event doesn't work well with Generic function, or did I do something wrong?
protocol B {
  var event: Event<Bool> { get set }
}

func test<A: B>(a: A) {

  //Got Cannot invoke '+=' with an argument list of type '(Event<Bool>, (($T5) -> ($T5) -> $T4) -> (($T5) -> $T4) -> $T4)'

  a.event += { println($0)  }

 // Got an error: Immutable value of type 'Event<String>' only has mutating members named 'add'
  a.event.add {
    println($0)
  }
}

Sorry, I figured it out, I should declare param a as variable
func test<A: B>(var a: A) {
  a.event += { println($0)  }
}


Using a flash without sunglasses flashes you

Description

Probably something to do with how the flash range is set?
Reproduction

Spawn in a flash
Take off sunglasses (if wearing any)
Use the flash
Observe how you just flashed yourself

This seems intended? You're not wearing the protective gear.

i dont think this is a bug

This seems intended? You're not wearing the protective gear.

It says it’s a handheld bulb, so you have to be pointing it the wrong way to flash yourself.

This only affects non-sec so requiring sunglasses for the user is better.

This only affects non-sec so requiring sunglasses for the user is better.

There's a PR up for giving all heads flashes in their backpacks, and 5 out of 7 heads don't have sunglasses. They could use the combat mode interaction to not flash themselves, but I doubt that most heads are going to know that interaction exists and will accidentally flash themselves instead.
Also headrevs

This only affects non-sec so requiring sunglasses for the user is better.

There's a PR up for giving all heads flashes in their backpacks, and 5 out of 7 heads don't have sunglasses. They could use the combat mode interaction to not flash themselves, but I doubt that most heads are going to know that interaction exists and will accidentally flash themselves instead.
~Also headrevs~

i think i mentioned specifically in the changelog that you can hit people with flashes. if they dont learn after that it is their fault!!

this is intended


Refactor Safe modifier

After this PR: no need to play with the Safe/Escape tricks anymore. See the changes for more details.

Breaking change for mail templates?

The "breaking" started from #29165.

Breaking change for mail templates?

->  WIP: Breaking summary for template refactoring #29395


Support interactions

Hello.
Is there a way to send late responses using the response_url param which Slack sends for interactive messages.
Thank you!

You can store the response_url somewhere, and use it later on... wouldnt that work for you?

Thanks, @richmondwang. It would work for me but I just can't realize a pipeline for such a case.

I see.. maybe you can use the other way.
I am talking about the message_ts used in chat.update, instead of the response_url.. ?

I think I understand you now..
I forgot you are talking about interactive messages.. Im sorry..
In this case, I now agree with you 🙇

@richmondwang Agree with you, it's relatively simple. Though, it'll be better as a part of the main code. ))
Thank you!

We've had a need for this as well. I actually have a branch that implements it. but its messy has some details specific to our usage that need to be cleaned up.
feel free to take a peek and extract the necessary pieces in a single PR.
https://github.com/james-lawrence/slack/tree/response-url-hacks

this can be achieved using UnsafeMsgOptionEndpoint


data problem

excuse me but where can i find the data you used in your paper

Hello @hfyer!
We appreciate your interest in our work!
From this link, you can download the s008  dataset. This is the dataset used in the paper.
Regards.


Sfx in multiplayer for other players play for all?

In a multiplayer session some SFX seems to play without a proper distance filter or something like that. For instance a player death SFX seems to play as if it was at distance 0 to all players when any one player dies.
Slightly related to #663

Does this only apply to player death SFX or has it been noticed for other SFX as well? If so, which ones?

I'd like to tackle this issue but I'm a little confused as to which classes I should be looking at

Heya @oekonomi - sorry for missing your comments for a while :-)
I don't personally know where to look for this, but what I do as an initial detective move is go CTRL-N in IntelliJ and enter some sensible term like Sound to look at what classes come up. In this case there's a small bunch of classes including PlaySoundAction which has a couple methods that include some logic about location. That looks like a very promising place to start digging! ⛏

Hey, I spent some time digging in PlaySoundAction and other related classes. I was looking into changing the priority level for the sound based on location from the instigator. As I've been busy with exams, I haven't had much time to make further progress. I'm not sure when or if I'll be able to get back to working on this.

Hey, I would like to work on this issue. Can this please be assigned to me? Thank you!

Hi @npetronio1
You don't need to be assigned to this issue to start working on it 😉
Just fork this repo, create some first changes, open a draft PR and mention this issue in it, then it will be automatically linked to it.
Also, the earlier we see changes, the earlier we can give you feedback on whether you're heading the right direction 🤓
Please also note, that if you don't have a lot of programming experience yet, this list of good first issues is likely an easier start. If you have general questions unrelated to a specific issue or PR change, I'd further recommend joining our Discord Server to get more timely responses.


⚠ Bofrost.fr has degraded performance

In b48ddc0, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 1187 ms

Resolved: Bofrost.fr performance has improved in b455d45 after 39 minutes.


Rocket Chat Window doesn't start in the last known position

Search before asking

[X] I had searched in the issues and found no similar issues.

Operating System

[ ] macOS
[X] Windows
[ ] Linux

Operating System Version
Windows 10/11
It happens on the web browser too?
No, it just happens on the Desktop app
Rocket.Chat Desktop App Version
3.9.4 / 3.9.5 / 3.9.6
Rocket.Chat Server Version
6.2.5
Describe the bug
Rocket Chat window doesn't start in the last known position if the position was at the edge of the screen. No matter what edge (or corner) it is, RC always starts in random position. Problem occurs with multiple and single screen setups without changing the sreens setup.
If the last window position wasn't at the edge - RC starts in that position with unharmed window size.
Seems like the bug has appeared somewhere at the 3.9.x version, as with the version 3.8.x everything was working fine. We noticed the problem afrer updates.
How to Reproduce

Open RC app.
Move the RC wintow to the outer edge/corner of the screen.
Close RC app.
Open RC app.

Describe your Expected behavior
As we use multiple screens setup with many different aplications windows opened at the same time it's very important for us to have RC in the exact same position every time it turns on. It's very annoying to be forced to adjust this window every day on startup.
Anything else
No response
Are you willing to submit a code contribution?

[ ] Yes, I am willing to submit a Pull Request!

Heyy @bochenekm, thanks for sharing your experience and point out the bug.
@jeanfbrito, I would be delighted to work on this issue.
I will be updating you with the status of the progress shortly.

Can you please share some sort of visual such as a video or GIF so that we can get a better hold of the problem. This way it will become easier for me to approach the problem.
Thanks.


#19 elementShouldBeVisible Should be public

What
Makes the following parts of the API public:
Describe what you have changed and why.

Chrome.ctx -> Chrome.Ctx
UIFeature.waitTimeOut -> UIFeature.WaitTimeOut
UIFeature.elementShouldBeVisible -> UIFeature.ElementShouldBeVisible
UIFeature.runWithTimeOut -> UIFeature.RunWithTimeOut

So that I can compose custom step functions in a frontend web app, for example:
func sectionShouldHaveNthElements(f *componenttest.UIFeature, elementSelector string) func(int) error {
	return func(expectedLength int) error {
		var nodes []*cdp.Node
		err := chromedp.Run(f.Chrome.Ctx,
			f.RunWithTimeOut(&f.Chrome.Ctx, f.WaitTimeOut, chromedp.Tasks{
				chromedp.Nodes(elementSelector, &nodes, chromedp.ByQueryAll),
			}))
		assert.Nil(f, err)
		if err != nil {
			return f.StepError()
		}
		assert.Equal(f, expectedLength, len(nodes))
		return f.StepError()
	}
}

// And call it as follows:
ctx.Step(`^the relations sections should have (\d+) external links$`, sectionShouldHaveNthElements(uiFeature, "a"))

Adds innerListElementsShouldHaveText function
I want to write a Gherkin step in a frontend web app that can check the breadcrumbs inner text elements exist :
 And the page should contain "breadcrumbs" containing list element text "Home, Area" with depth 3

This allows the caller to add a testing data attribute to a Dom element e.g. data-test="breadcrumbs" & a list of expected text nodes. The function is responsible for querying the node tree up until an nth depth where it iterate over branches as this point.
How to review
either visually or by pulling down the branch, link to a front end app with
Describe the steps required to test the changes.
Add this to the mod.go file
replace (
	github.com/ONSdigital/dp-component-test => /<PATH_TO_YOUR_LOCAL_REPO>/dp-component-test
)

run the tests with
make test-component

Who can review
Anyone
Describe who worked on the changes, so that other people can review.
Myself

Sorry @joegasewicz I just realised that you asked for this to be reviewed by team 404. So I will approve it after someone from there has done.

@cookel2 You can review this should review this as it is agnostic in terms of teams using this code. I've updated the Who can review section to anyone thank you


Implement Environment.UserName layoutrenderer

Right now one can use these:

${windows-identity}
${environment:variable=UserName}

Both are extremely slow, and the second one doesn't support impersonations. But there are actually much faster calls:

Environment.UserName
Environment.UserDomainName

And these should support impersonation, and should also be available of NetCore:

On Windows the UserName property wraps a call to the Windows GetUserName function. The domain account credentials for a user are formatted as the user's domain name, the '' character, and user name. Use the UserDomainName property to obtain the user's domain name and the UserName property to obtain the user name.

On Unix platforms the UserName property wraps a call to the getpwuid_r function.

If an ASP.NET application runs in a development environment, the UserName property returns the name of the current user. In a published ASP.NET application, this property returns the name of the application pool account (such as Default AppPool).

See the output here:
https://richhewlett.com/2011/02/15/getting-a-users-username-in-asp-net/

PS  Dunno why issues aren't closed with linked pull requests


inmem datastet implementation

In 0.8 inmem implementation of datasets like FastDataset etc. are missing, while present in 0.7. Current inmem crate only contains implementations for inmem graphs.

yes, 0.8 is still incomplete (hence the 'alpha' tag in the version). But inmem Dataset types will be back when 0.8 is released (soonish, hopefully).
Note that, in the meantime, you can still "default" implementations of Dataset (for example, any Vec or HashSet of Quads implements Dataset: https://docs.rs/sophia/latest/sophia/dataset/trait.Dataset.html#implementors)


[1.44.2.x] - Critical bugs and CVEs cherry-picks

Description of the change:
Motivation for the change:
Checklist

[ ] Add or Modify a unit test for your change
[ ] Have you verified that tall the tests are passing?

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

@rgdoliveira I think the Jenkins CI error is unrelated:
org.kie.jenkins.jobdsl.JobScriptsSpec > test script /tmp/tmp.SUYP1HA3PZ/dsl/seed/jobs/jobs.groovy FAILED
    org.spockframework.runtime.UnallowedExceptionThrownError at JobScriptsSpec.groovy:76
        Caused by: javaposse.jobdsl.dsl.DslScriptException at JobScriptsSpec.groovy:72
            Caused by: groovy.lang.MissingMethodException at JobScriptsSpec.groovy:72

@rgdoliveira @ricardozanini what about the failed Jenkins Tests / dsl-tests ?

@domhanak please see my last comment. It seems to me infrastructure-related. Our IT is working as expected.


Bump to v1.2.0

I'll wait for a day before merging this and releasing v1.2.0 on PyPI. In case anyone stumbles across  severe bugs, they could be fixed before the release.

Looks good to me so far. I'll go ahead and publish v1.2.0.


Non-global publicPath for hot-reload?

I run two different webpack-dev-server. One exports itself as a library with the umd target (let's call it A) and the other serves assets and proxies the rest to a service (let's call it B). Of course, they run on different ports. I setup HMR for both of them.
One of the pages of the service (dev server A) uses a script tag to load the library (exported to UMD) served by dev server B. It loads and displays correctly. However, when I make changes inside the library, the dev server B tries to make a hot update using dev server A's public path, so I get a 404:
http://_DEV_SERVER_A_URL/9b62fb01a25b81e8d592.hot-update.json 404 (Not Found)
[HMR] Cannot find update. Need to do a full reload!
[HMR] (Probably because of restarting the webpack-dev-server)

This makes me think perhaps the URL used to get hot updates is global (within Webpack) while it shouldn't be.
Is this a known limitation, is there a config option that would help with this (I can post my configs if you think that would help), or is this confirmed a bug?
webpack @ 1.12.11
webpack-dev-server @ 1.14.1
Thank you very much!

Can you re-open at Stack Overflow as that works better for support? Thanks.


0.2.0

This release includes various bugfixes and brings hydra one step closer to production readyness.
Overview

Greatly improved throughput of read-only requests
Improved logging and truncate sensitive credentials from logs and config files
Various bugfixes including RethinkDB, OAuth2 and the CLI
Investigated bottlenecks
Add profiling and request logging
Improve compatibility with real-world deployment scenarios

A complete list of resolved issues can be viewed here.

0.2.0 will be delayed because there are things to be solved in fosite first


Note regarding download managers and PDF viewer control (experimental)

Just a head up, I have emailed both Microsoft and IDM regarding this, but if an end-user has a download manager installed and active while using an app that uses PDF viewer control (experimental) in Power Apps, the PDF may not display and instead the download manager will pick it up.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: e5b06f20-00c5-9824-ecbf-70c03f1858c4
Version Independent ID: 2270c9fe-bbcb-4cc6-90f1-485ebe8ee094
Content: PDF viewer control (experimental) in Power Apps - Power Apps
Content Source: powerapps-docs/maker/canvas-apps/controls/control-pdf-viewer.md
Service: powerapps
Sub-service: canvas-maker
GitHub Login: @chmoncay
Microsoft Alias: chmoncay

Thank you for reaching out with GitHub issue and pull request. Please reach out using a support ticket for any help with a product behavior/issue investigation. We don't document third-party app content and behavior in Microsoft product documentation.


Intercity passenger train lines

Currently all railroads are drawn the same, but active passenger trains lines are of greater interest to a general audience. In North America there are relatively few passenger rail lines, especially compared to roads, so highlighting them seems doable. Some paper maps show passenger rail lines but no freight lines at all (see #101). For now I think we can focus on intercity and possibly commuter/regional routes. Metro/light rail/streetcar/heritage lines should be kept in mind in terms of styling hierarchy but might be future work.
Some ideas:

Bolder styling for passenger rail lines (part of route=train relations)
Show these lines at lower zooms
Label the lines with the route names and/or operators
Render associated train stations at higher zooms (see also #435)

Subway and light rail lines already receive special treatment at higher zoom levels, so distinguishing “consumer-friendly” heavy rail would be entirely consistent with this style, even if it isn’t heavily focused on public transportation per se.

Label the lines with the route names and/or operators

I think the most typical treatment is to label the line with the route name, if at all, and also append the service’s logo to the stations’ labels. Rail operators as OSM knows them don’t tend to be labeled at all on consumer-oriented maps.

Labeling cities based on their long-distance rail and bus services would be an interesting data modeling problem. Relating train stations to cities could be a maintenance nightmare, similar to the ill-begotten destinationsign relation type. Wikidata has a place served by transport hub P931 property that’s well-suited for this purpose, but OpenMapTiles would need to join places and POIs on Wikidata; I don’t know if there’s any precedent for that yet.

Subway and light rail lines already receive special treatment at higher zoom levels

Oh okay I see it now. I think this could be improved but that's a separate issue.

Append the service’s logo to the cities’ labels at low zoom levels

Sounds cool but I wouldn't do this for Americana. Maybe one day we could have a transit-oriented variant.

Rail operators as OSM knows them don’t tend to be labeled at all on consumer-oriented maps.

I guess I meant more the network. Like some rail lines host a dozen Amtrak routes and we wouldn't want to list all their names, but we can label the line "Amtrak". Apple Maps does something like this. I'm not suggesting we label "Keolis" or whatever.

Append the service’s logo to the cities’ labels at low zoom levels

Sounds cool but I wouldn't do this for Americana. Maybe one day we could have a transit-oriented variant.

I agree that a transit-oriented style would emphasize these details more heavily, but public transportation indicators do appear frequently in road maps too. For example, INDOT’s Indiana Roadway Map 2018 labels cities and towns by whether they have a “transit system” (red for large urban, black for small or rural). These icons indicate availability, not the precise locations of bus stations. This map shows mainline railways but only labls them by their freight operators, not services like Amtrak.

The general approach of labeling cities by their amenities isn’t unheard of either. Here’s a map of Missouri that indicates which cities have hospitals:

Benchmark Maps even includes nifty climate charts in its maps of Western states, where that kind of information comes in handy:

That said, I recognize there’s less need for this approach in an interactive map in which you could zoom in on a place or click on it to get more information.


Pagination

Feature Request
A pagination feature should be added to the get methods for tools and workflows. If we continue to retrieve tools and workflows without pagination, then as the site grows, the delay that occurs for loading tools and workflows will become more and more noticeable.
Desired behaviour
Have pagination so that we only get a limited number of tools or workflows at a time.
Environment (Browser or OS and Dockstore version)
DockstoreApi - 1.1.5

Note for implementor, pagination is implemented in the GA4GH endpoints and is inspired by https://developer.github.com/guides/traversing-with-pagination/ . We can do something similar for the endpoints hit by the UI.

As a related issue, the organizations page can be quite slow and can probably be optimised both on the webservice and ui side.

From demo: make docker pull non-editable

Missing Descriptor Type Sorting #1590

Working to the extent that more specific tickets should be created


model-navigator optimize stops with an error

Running model-navigator optimise my_model.nav following the instructions in quick_start.md will stop with an error.
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/cli/analyze.py", line 90, in analyze_cmd
    analyze_results = analyzer.run()
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/model_analyzer/analyzer.py", line 72, in run
    analyzer.run(mode=ModelAnalyzerMode.ANALYZE, verbose=self._verbose, quiet=quiet)
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/model_analyzer/model_analyzer.py", line 73, in run
    raise ModelNavigatorException(
model_navigator.exceptions.ModelNavigatorException: Running model-analyzer with ['model-analyzer', '--quiet', 'analyze', '-f', '/scratch_space/navigator_workspace/analyzer/config-analyze.yaml'] failed with exit status 1 : None output : None

model-analyzer anlyze is an alias for model-analyzer profile, so the analysis_models in the generated navigator_workspace/analyzer/config-analyze.yaml I think the key is wrong. I think changing analysis_models to profile_models should work
environment

base image: nvcr.io/nvidia/tritonserver:23.01-py3
triton-model-analyzer    1.24.0
model-navigator          0.3.7

@Nishikoh, please limit the Model Analyzer version in setup.cfg in cli section as follow:
triton-model-analyzer>=1.16.0,<1.22.0

and add in install_requires:
numpy>=1.22.2,<1.24.0

We are currently working on releasing new version that introduce API changes and also remove the dependency of Triton Model Analyzer.

@jkosek
The model-analyzer analyze command worked. Thank you! Then I got another error. Is there a solution?

error log
Traceback (most recent call last):
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/utils/config.py", line 101, in from_dict
    return dict2dataclass(cls, data)
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/utils/config.py", line 86, in dict2dataclass
    return dacite.from_dict(cls, data, config=dacite.Config(cast=[Enum, Path, tuple, np.dtype]))
  File "/usr/local/lib/python3.8/dist-packages/dacite/core.py", line 69, in from_dict
    raise WrongTypeError(field_path=field.name, field_type=field_type, value=value)
dacite.exceptions.WrongTypeError: wrong value type for field "engine_count_per_device" - should be "typing.Dict[model_navigator.triton.config.DeviceKind, int]" instead of value "{'gpu': 5}" of type "dict"

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/model-navigator", line 8, in <module>
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/cli/main.py", line 53, in main
    cli(max_content_width=160)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1657, in invoke
    return _process_result(sub_ctx.command.invoke(sub_ctx))
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/cli/optimize.py", line 307, in optimize_cmd
    create_helm_chart_result = ctx.forward(
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 781, in forward
    return __self.invoke(__cmd, *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/click/decorators.py", line 26, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/cli/helm_chart_create.py", line 127, in helm_chart_create_cmd
    instances_config = TritonModelInstancesConfig.from_dict(kwargs)
  File "/usr/local/lib/python3.8/dist-packages/model_navigator/utils/config.py", line 105, in from_dict
    raise ValueError(e)
ValueError: wrong value type for field "engine_count_per_device" - should be "typing.Dict[model_navigator.triton.config.DeviceKind, int]" instead of value "{'gpu': 5}" of type "dict"

environment
cpu:
  logical_cores: 4
  max_frequency: 0.0
  min_frequency: 0.0
  name: Intel(R) Xeon(R) CPU @ 2.20GHz
  physical_cores: 2
gpu:
  cuda_version: '12.0'
  driver_version: 510.47.03
  memory: 15360 MiB
  name: Tesla T4
  tdp: 70.00 W
libraries:
  CUBLAS_VERSION: <IP_ADDRESS>
  CUDA_DRIVER_VERSION: 525.85.11
  CUDA_VERSION: <IP_ADDRESS>
  CUDNN_VERSION: <IP_ADDRESS>+cuda11.8
  CUFFT_VERSION: <IP_ADDRESS>
  CURAND_VERSION: <IP_ADDRESS>
  CUSOLVER_VERSION: <IP_ADDRESS>
  CUSPARSE_VERSION: <IP_ADDRESS>
  DALI_BUILD: '6799315'
  DALI_VERSION: 1.21.0
  NCCL_VERSION: 2.16.5
  NPP_VERSION: <IP_ADDRESS>
  NSIGHT_COMPUTE_VERSION: 2<IP_ADDRESS>
  NSIGHT_SYSTEMS_VERSION: 2<IP_ADDRESS>
  NVIDIA_BUILD_ID: '52277748'
  NVIDIA_TRITON_SERVER_VERSION: '23.01'
  NVJPEG_VERSION: <IP_ADDRESS>
  OPENMPI_VERSION: 4.1.4
  OPENUCX_VERSION: 1.14.0
  TRITON_SERVER_VERSION: 2.30.0
  TRTOSS_VERSION: '23.01'
  TRT_VERSION: <IP_ADDRESS>+cuda<IP_ADDRESS>+520.61.05+cublas<IP_ADDRESS>
memory: 14.7G
os:
  name: posix
  platform: Linux
  release: 4.19.0-23-cloud-amd64
python_packages:
  numpy: 1.23.5
  onnx: 1.13.0
  onnxruntime-gpu: 1.14.0
  polygraphy: 0.44.2
  tensorrt: <IP_ADDRESS>
  torch: 1.13.1
  torch-tensorrt: 1.3.0
  triton-model-analyzer: 1.21.0
  tritonclient: 2.30.0
python_version: 3.8.10

@Nishikoh I suggest to switch to new flow introduced in 0.4.0 version:

https://triton-inference-server.github.io/model_navigator/0.4.0/quick_start/
https://triton-inference-server.github.io/model_navigator/0.4.0/triton/triton_deployment/

It worked well. Thank you!


[lu file] Failed to tie phaselist as a feature for an intent

Describe the bug
I've follow this article to use phaseList as a feature for an intent.
But the bot can start with below error:
This is content of .lu file:
> add some example phrases to trigger this intent:
- view my ticket

@ phraseList  ticket(interchangeable) =
    - tickets, request, requests, incident, incidents
@ intent IT_Ticket usesFeature ticket

Version
1.2.1
Browser

[ ] Electron distribution
[ ] Chrome
[ ] Safari
[ ] Firefox
[ ] Edge

OS

[ ] macOS
[ ] Windows
[ ] Ubuntu

Hi @tannguyen3, thanks for your feedback. I just checked your case, there is indeed an issue here. But the work-around solution is also simple, just change your phraseList to phraselist in your definition line of @ phraseList  ticket(interchangeable) =. In the future, we will make it case insensitive, created a ticket to track this https://github.com/microsoft/botframework-cli/issues/1068.

I think we can close this ticket in composer side since it has an easy and efficient work-around solution for users.

I got it. thank you @feich-ms


[ISSUE #4245] Remove the topic route cache in nameserver

Make sure set the target branch to develop
What is the purpose of the change
In rip-29, we hope to use topic route cache to speed up route query, but in fact, in large-scale clusters (300 + brokers, 10000 + topics every broker), this optimization will affect registration and cause nameserver crash. So I remove the topic route cache and add switches for some performance-consuming calls.
Brief changelog
Remove the topic route cache and add switches for some performance-consuming calls.
Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.

[x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test  to make sure integration-test pass.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

Codecov Report

Merging #4246 (aebe430) into 5.0.0-beta (d6a53f9) will decrease coverage by 0.12%.
The diff coverage is 60.18%.

@@               Coverage Diff                @@
##             5.0.0-beta    #4246      +/-   ##
================================================
- Coverage         43.17%   43.04%   -0.13%
+ Complexity         6045     6015      -30
================================================
  Files               796      796
  Lines             56937    56941       +4
  Branches           7791     7790       -1
================================================
- Hits              24580    24511      -69
- Misses            29164    29216      +52
- Partials           3193     3214      +21

Impacted Files
Coverage Δ

.../apache/rocketmq/common/namesrv/NamesrvConfig.java
0.00% <0.00%> (ø)

...che/rocketmq/common/protocol/route/BrokerData.java
31.25% <0.00%> (-3.24%)
:arrow_down:

...org/apache/rocketmq/namesrv/NamesrvController.java
59.64% <ø> (ø)

...etmq/namesrv/processor/ClientRequestProcessor.java
45.00% <ø> (+2.14%)
:arrow_up:

...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java
67.70% <69.81%> (-2.22%)
:arrow_down:

...tmq/namesrv/processor/DefaultRequestProcessor.java
62.32% <70.00%> (-1.35%)
:arrow_down:

...ache/rocketmq/common/stats/MomentStatsItemSet.java
39.13% <0.00%> (-4.35%)
:arrow_down:

...e/rocketmq/remoting/netty/NettyRemotingClient.java
39.48% <0.00%> (-3.44%)
:arrow_down:

...org/apache/rocketmq/common/stats/StatsItemSet.java
41.79% <0.00%> (-2.99%)
:arrow_down:

...ava/org/apache/rocketmq/test/util/VerifyUtils.java
46.26% <0.00%> (-2.99%)
:arrow_down:

... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6a53f9...aebe430. Read the comment docs.

Coverage decreased (-0.003%) to 47.244% when pulling aebe430c6c3a0eb3fc91ae510b62b5f648434ead on RongtongJin:polish_namesrv into d6a53f9c29f30824b4c35a099e1caeaae63a6685 on apache:5.0.0-beta.

Coverage decreased (-0.003%) to 47.244% when pulling aebe430c6c3a0eb3fc91ae510b62b5f648434ead on RongtongJin:polish_namesrv into d6a53f9c29f30824b4c35a099e1caeaae63a6685 on apache:5.0.0-beta.


Addition of my plague and infected tokens

On which network are these tokens are displayed

Oops I am Sorry, this is for the Arbitrum network


Add form handler service

did we want to go forward with this approach

No 😂 Let's stick with Netlify for now.


copy/paste item

will be nice if there will be a item that can copy and paste crafter setups
to make it eazyer to make more then 1 of the same setup
like me i have 4 cobble compressers will be nice if i can setup one time and then copy paste it

Just going to point out that CoFHLib has an interface for this - IPortableData.
https://github.com/CoFH/CoFHLib/blob/master/src/main/java/cofh/api/tileentity/IPortableData.java
If you're compatible with that, then RedPrints will work to copy/paste :)

Ah that's interesting. I'll check that interface out.


drop support for python 3.8

Python 3.8 has fallen out of support 2 days ago, which means it's not getting anymore security updates.
This also has consequences for dependency management since an increasing number of dependencies have moved away from it, and we're not able to get the new versions anymore.
Consider making this change at the same time as #341, and after #302 has been implemented.
TODO:

[ ] remove 3.8 from the toml file
[ ] remove 3.8 from the matrix of the workflows
[ ] remove 3.8 from the policy definition if #327 has been implemented.

IMPORTANT: this is a source breaking change for 3.8 users (they'll need to upgrade to a newer version of python), make sure to include a bang in your message commit (e.g. feat!:) so a major version bump is made.
We do not need to major bump kiota itself since the generator will emit for the same API surface and we're within our support policy.
After the PR for this is merged but BEFORE the changes are released we also need to go back to any closed (not merged) dependabot PR and ask the bot to recreate the pull requests (@dependabot recreate) so we upgrade to the latest version of the dependencies.

additionally this documentation needs to be updated https://learn.microsoft.com/en-us/openapi/kiota/quickstarts/python#required-tools

And this one https://learn.microsoft.com/en-us/openapi/kiota/tutorials/python-azure?tabs=portal

to add data points for this one: it seems that libraries are perfectly fine with bumping the required minor version of python in a patch/minor release.
Here are some examples:

https://github.com/microsoftgraph/msgraph-sdk-python-core/pull/723
https://github.com/microsoftgraph/msgraph-sdk-python-core/pull/730
https://github.com/microsoftgraph/msgraph-sdk-python-core/pull/729
https://github.com/microsoftgraph/msgraph-sdk-python-core/pull/722
https://github.com/microsoftgraph/msgraph-sdk-python-core/pull/720

Which means this is most likely was the eco-system expects, and it should be fine to follow that practice on our end.

Seeing the same in changelogs such as

https://github.com/agronholm/anyio/releases/tag/4.6.0
https://setuptools.pypa.io/en/stable/history.html#v75-4-0
https://github.com/pylint-dev/pylint/releases/tag/v3.3.0

Looking at the Azure SDK guidelines, they are just providing a (outdated?) target version. No upgrade guidance. I have asked a question in the internal channels to see if any Python architect tells us following what the ecosystem is doing here is a bad idea for some reason.

We could also consider dropping the deprecated type hint aliases in favor of the recommended types for Python 3.9+


Fawry CardToken APIs

This PR enables using Fawry List, create and delete Card Token

Hi @AhmedAliIbrahim,
thank you so much for this valuable contribution 💯 👍 Could you please take a look at the rubocop offenses in circleci and fix them? You can disable the offenses around the build_request method as I think it doesn't make much sense to change it.
Also, could you add your change to the README.md and README-ar.md? Thanks!
I will review again ASAP.

Hello @amrrbakry,
I'll update the README file ASAP

Hi @amrrbakry, I've updated Specs & README

@AhmedAliIbrahim Thank you so much for this great contribution! 🎉 👍

published as Fawry v.1.1.1 🚀 Thanks for contributing 👍

You're welcome 👍


Refine links after gathering and push-pull.

Render with
radiosity hierarchical -w640 -e50 \
  --form-factor-eps=0.1 --rad-shoot-eps=1e-6 \
  --max-iterations=1000 scenes/cornell_box.blend

Links are refined according to CW p. 186.
There are some obvious issues:

~The recursive call of refine_links on children nodes will process links that
just have been refined without and intermediate solve system step.~
~We always recalculate the form factors even if we do not subdivide further.~
~Lots of recursion and copying could be avoided.~

Coverage decreased (-1.8%) to 55.037% when pulling f7baa846da96d0dcfb01c40ff4402ce539a4ec63 on karsten/refine-links into 7966c5c71d561ab7ff37e61b24bf8df9676503c0 on dima/hierarchical/gouraud.

 The links at leafs are refined first.
Diff

Dropped in favour of https://github.com/jeschkies/renderer/pull/81


BUG: documentation inconsistent with code for find_peaks_cwt

Describe your issue.
Per https://docs.scipy.org/doc/scipy/reference/generated/scipy.signal.find_peaks_cwt.html, min_snr is described as:
"Minimum SNR ratio. Default 1. The signal is the value of the cwt matrix at the shortest length scale (cwt[0, loc]), the noise is the noise_perc'th percentile of datapoints contained within a window of `window_size around cwt[0, loc]."
However, line 1182 of https://github.com/scipy/scipy/blob/master/scipy/signal/_peak_finding.py shows:
snr = abs(cwt[line[0][0], line[1][0]] / noises[line[1][0]])
Line[0][0] is the column, and it is not always equal to 0.
I'm not sure whether it would be better to fix the documentation or to change the code to represent the documentation.
SciPy/NumPy/Python version information
1.7.1 1.21.4 sys.version_info(major=3, minor=8, micro=5, releaselevel='final', serial=0)

@pv Looks like this might be something you're interested in.

The paper cited in the docs states:
"Definition of the signal to noise ratio Before defining the SNR in
the wavelet space, signal and noise must be defined first. Based on the
assumption that the real MS peaks have an instrument-specific characteristic
shape, the signal strength of a peak is defined as the maximum CWT coefficient on the ridge line within a certain scale range. As for the noise, we
assume that it is composed of positive or negative peaks with very narrow
width. Since the baseline drift has been removed by the transformation into
the wavelet space, the CTW coefficients at the smallest scale (a=1) are a
good estimate of the noise level. The local noise level of a peak is defined as
the 95-percentage quantile of the absolute CWT coefficient values (a=1)
within a local window surrounding the peak. A minimum noise level can be
provided to avoid the noise level close to zero, which could happen when
some region is very smooth. Thus, the SNR is defined as the ratio of the
estimated peak signal strength and the local noise level of the peak."
Per this, the noise is defined correctly in the docs and implemented correctly in the code. The signal is definitely described incorrectly in the docs, but I can't really tell how the code is representing a ridge line, so I don't know if the signal calculation is correctly implemented or not.

Thanks for the detailed report @EfremBraun. gh-15827 improved the docs for the signal. It looks like the implementation is correct - but I agree it's hard to tell.


Values read from TH2* are mixed up

It appears that something is going wrong with reading TH2* histograms compared to ROOT or uproot3. When reading a TH2, the second axis values seem to be reversed, as well as the over and underflow next to each other. I can reproduce it (see below), and it seems like it should be straightforward, but somehow I haven't yet found the source.
from pathlib import Path
filename = Path("reproducer.root")
if not filename.exists():
    import ROOT
    # Fill to create an identity, but with different number of bins to ensure that we don't accidentally get it right.
    h = ROOT.TH2D("test", "test", 10, 0, 10, 12, 0, 12)
    for i in range(0, 10):
        h.Fill(i + 0.5, i + 0.5)

    f_out = ROOT.TFile("reproducer.root", "RECREATE")
    h.Write()
    f_out.Close()

import uproot4
import uproot as uproot3
import numpy as np

hist_3 = uproot3.open("reproducer.root")[b"test"]
hist_4 = uproot4.open("reproducer.root")["test"]

# Ignore overflow for now since uproot3.values ignores overflow
np.testing.assert_allclose(hist_3.values, hist_4.values()[1:-1, 1:-1])

this gives:
AssertionError:
Not equal to tolerance rtol=1e-07, atol=0

Mismatched elements: 19 / 120 (15.8%)
Max absolute difference: 1.
Max relative difference: 1.
 x: array([[1., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.],
       [0., 1., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0.],
       [0., 0., 1., 0., 0., 0., 0., 0., 0., 0., 0., 0.],...
 y: array([[0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 1.],
       [0., 0., 0., 0., 0., 0., 0., 0., 0., 0., 1., 0.],
       [0., 0., 0., 0., 0., 0., 0., 0., 0., 1., 0., 0.],...

Just printing all of the values gives some info. Expected from uproot3 (note: excluding flow bins):
>>> print(hist_3.values)
[[1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 1. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 1. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 1. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 1. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 1. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 0. 1. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 0. 0. 1. 0. 0.]]

Uproot4 (note: including flow bins and the reverse):
>>> print(hist_4.values()[:, ::-1])
[[1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 1. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 1. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 1. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 1. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 0. 1. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 0. 0. 1. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]
 [0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0. 0.]]

Any help is appreciated!

The code is in
https://github.com/scikit-hep/uproot4/blob/a5a2b1f7d8b50c7f0a85d53f271149b0e4317b67/uproot4/behaviors/TH2.py#L24-L53
and the interface is still under discussion with @HDembinski and @henryiii. In fact, on the latter point, I don't know where we landed, but I'm willing to make this interface align with boost-histogram and hist, if those interfaces have settled (#50 and scikit-hep/uproot#502).
So @raymondEhlers, what you find in the linked code is basically a sketch: it can and should be changed to fit your expectations. The to_numpy, to_boost, and to_hist methods (and I've been reminded that we need a to_pandas, #91) all use the edges, values, and values_errors (which maybe needs to become values_variances). Some hidden helper functions are in the TH1.py file:
https://github.com/scikit-hep/uproot4/blob/a5a2b1f7d8b50c7f0a85d53f271149b0e4317b67/uproot4/behaviors/TH1.py#L16-L63
I think I tested the 2D histogram by looking at a Gaussian blob with the same number of bins in X and Y, which would hide the kinds of transposition issues you're seeing (but it's a file I had available). If you see how to correct it with an application in mind, please do.

Thanks for the pointers and your detailed answer Jim!
Perhaps my word choice was not great - I found the TH1 and TH2 behaviors and looked around the code, but was a bit confused as to how reading the hist correctly could lead to appearing to move the flow bins. However, looking more closely this morning, I realized that it's actually just a reshape with the wrong parameters. So it should be a straightforward change. I'll make a PR either later today or tomorrow.
Thanks!