Update Live Share tutorial page

Update documentation for teams live share section

Docs Build status updates of commit 843758c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 16, Column 395: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/azure/azure-relay/relay-what-is-it' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 18, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 51, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 16, Column 395: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/azure/azure-relay/relay-what-is-it' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 42b261f:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 16, Column 395: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/azure/azure-relay/relay-what-is-it' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 18, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 51, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 16, Column 395: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/azure/azure-relay/relay-what-is-it' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 290, Column 49: [Warning: file-not-found - See documentation] Invalid file link: '../resources/schema/manifest-schema'.
Line 298, Column 64: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 309, Column 65: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 317, Column 37: [Warning: duplicate-alt-text - See documentation] Alt text 'image' is duplicated. Within an article, alt text must be unique.
Line 321, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'image' is duplicated. Within an article, alt text must be unique.
Line 337, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 298, Column 64: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 309, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 327, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/platform/toolkit/provision#provision-using-teams-toolkit' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 0a4a61c:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 18, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 51, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 16, Column 395: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-relay/relay-what-is-it' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 290, Column 49: [Warning: file-not-found - See documentation] Invalid file link: '../resources/schema/manifest-schema'.
Line 298, Column 64: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 309, Column 65: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 317, Column 37: [Warning: duplicate-alt-text - See documentation] Alt text 'image' is duplicated. Within an article, alt text must be unique.
Line 321, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'image' is duplicated. Within an article, alt text must be unique.
Line 337, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 298, Column 64: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 309, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 327, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/platform/toolkit/provision#provision-using-teams-toolkit' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 6abc95d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 18, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 51, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 16, Column 395: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-relay/relay-what-is-it' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 290, Column 49: [Warning: file-not-found - See documentation] Invalid file link: '../resources/schema/manifest-schema'.
Line 298, Column 64: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 309, Column 65: [Warning: hard-coded-locale - See documentation] Link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' contains locale code 'en-us'. For localizability, remove 'en-us' from links to most Microsoft sites.
Line 317, Column 37: [Warning: duplicate-alt-text - See documentation] Alt text 'image' is duplicated. Within an article, alt text must be unique.
Line 321, Column 1: [Warning: duplicate-alt-text - See documentation] Alt text 'image' is duplicated. Within an article, alt text must be unique.
Line 337, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 298, Column 64: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 309, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/en-us/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 327, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/platform/toolkit/provision#provision-using-teams-toolkit' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit b901a05:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 18, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 51, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 16, Column 395: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-relay/relay-what-is-it' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 290, Column 49: [Warning: file-not-found - See documentation] Invalid file link: '../resources/schema/manifest-schema'.
Line 337, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 298, Column 64: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 309, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 327, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/platform/toolkit/provision#provision-using-teams-toolkit' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 44562c6:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 18, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 51, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 16, Column 395: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/azure/azure-relay/relay-what-is-it' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 290, Column 49: [Warning: file-not-found - See documentation] Invalid file link: '../resources/schema/manifest-schema'.
Line 337, Column 1: [Warning: invalid-note-section] Text in the first line of Note/Section/Video is not valid. Will be rendered to

Line 298, Column 64: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 309, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 327, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/platform/toolkit/provision#provision-using-teams-toolkit' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 14a947b:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-capabilities.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-faq.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-quick-start.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-capabilities.md

Line 285, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.docs.microsoft.com/javascript/api/overview/msteams-client?view=msteams-client-js-latest&branch=CI-LiveShare' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-faq.md

Line 64, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.docs.microsoft.com/javascript/api/overview/msteams-client?view=msteams-client-js-latest&branch=CI-LiveShare' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md

Line 214, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.docs.microsoft.com/javascript/api/overview/msteams-client?view=msteams-client-js-latest&branch=CI-LiveShare' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 58, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.docs.microsoft.com/javascript/api/@microsoft/live-share/?view=msteams-client-js-latest&branch=CI-LiveShare' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-quick-start.md

Line 75, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.docs.microsoft.com/javascript/api/overview/msteams-client?view=msteams-client-js-latest&branch=CI-LiveShare' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 278, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://review.docs.microsoft.com/javascript/api/overview/msteams-client?view=msteams-client-js-latest&branch=CI-LiveShare' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 99336bd:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-capabilities.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-faq.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-quick-start.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-capabilities.md

Line 285, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 286, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-faq.md

Line 64, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 65, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md

Line 214, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 215, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 58, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 59, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-quick-start.md

Line 75, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 76, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 278, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 279, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 1ade47c:
:x: Validation status: errors
Please follow instructions here which may help to resolve issue.

File
Status
Preview URL
Details

:x:Error

Details

[Error: PullRequestMergeConflict] Cannot sync git repo to specified state. Please make sure the pull request is mergeable.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

Docs Build status updates of commit 5c55c5a:
:warning: Validation status: warnings

File
Status
Preview URL
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md
:warning:Warning
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-capabilities.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-faq.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-quick-start.md
:bulb:Suggestion
View
Details

msteams-platform/apps-in-teams-meetings/teams-live-share-tutorial.md

Line 296, Column 49: [Warning: file-not-found - See documentation] Invalid file link: '../resources/schema/manifest-schema'.
Line 304, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 315, Column 65: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/teams-custom-app-policies-and-settings' will be broken in isolated environments. Replace with a relative link.
Line 334, Column 52: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/microsoftteams/platform/toolkit/provision#provision-using-teams-toolkit' will be broken in isolated environments. Replace with a relative link.
Line 350, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 351, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-capabilities.md

Line 285, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 286, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-faq.md

Line 64, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 65, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-media-capabilities.md

Line 214, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 215, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-overview.md

Line 58, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 59, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

msteams-platform/apps-in-teams-meetings/teams-live-share-quick-start.md

Line 75, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share/' will be broken in isolated environments. Replace with a relative link.
Line 76, Column 3: [Suggestion: docs-link-absolute - See documentation] Absolute link 'https://docs.microsoft.com/javascript/api/@microsoft/live-share-media/' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel


NIFI-8537: Check that a property's dependencies are satisfied before …

…checking if the referenced controller service valid/enabled

Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Enables X functionality; fixes bug NIFI-YYYY.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
For all changes:

[ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?

[ ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

[ ] Has your PR been rebased against the latest commit within the target branch (typically main)?

[ ] Is your initial contribution a single, squashed commit? Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not squash or use --force when pushing to allow for clean monitoring of changes.

For code changes:

[ ] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
[ ] Have you written or updated unit tests to verify your changes?
[ ] Have you verified that the full build is successful on JDK 8?
[ ] Have you verified that the full build is successful on JDK 11?
[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
[ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
[ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
[ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?

For documentation related changes:

[ ] Have you ensured that format looks appropriate for the output in which it is rendered?

Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.

Thanks @exceptionfactory . I realized as soon as I pushed it that it was going to break and then I updated locally and forgot to push. Addressed now.

+1 LGTM, verified the behavior is as expected. Thanks for the fix! Merging to main


Separate virtual nodes from the network definition

There's also a random question of whether these "virtual" nodes should be defined somewhere separately in JSON. They are not part of the network really. You could imagine a format a bit like this:
{
  "network": {
    "nodes": [
       // ... all the network nodes
     ],
    "edges": [
       // ... and their connectivity
    ]
  },
  "virtual / groups / licences / constraints": [
    // Definition of all other non-network nodes
   ]
}

It was also discussed to rename VirtualStorage to Licence for better alignment with user expectations.


Are there any functions to perform image stitching in Android for React Native?

Hi, I am working on a React Native project, and I need to perform image stitching on Android devices. Is there any existing function  (or a native Android solution) that can be used to achieve this?
Any examples or guides would be greatly appreciated! Thank you.

Hi @cavadibrahimli1, support for the stitching module is currently outside the library. It is of course possible to use OpenCV for this purpose, but this would require:

A customised OpenCV compilation containing the stitching module.
Replacement of the cocoapod (iOS) or gradle module (Android) used in the application.
Exposing the module code using the library API.

Due to the desire to keep the library as small as possible, more advanced modules are not available.

Are there any plans about adding this module in library in future in your mind?

I have no such plans at present, but the repository is open to pull requests.


Calculate or show the test accuracy of BCI_IV_2A dataset

hello mr. robin
recently i ran the example you give on the BCI IV 2A dataset , i just want to know how to calculate the accuracy for this dataset like the example you give in the documentation
thank you.

Hm there should be outputs to the terminal while the example is running like this (example for cropped training):
2017-08-01 21:14:32,184 INFO : Epoch 2
2017-08-01 21:14:32,185 INFO : train_loss                3.36580
2017-08-01 21:14:32,185 INFO : valid_loss                3.77398
2017-08-01 21:14:32,185 INFO : test_loss                 3.41944
2017-08-01 21:14:32,185 INFO : train_sample_misclass     0.74347
2017-08-01 21:14:32,185 INFO : valid_sample_misclass     0.77586
2017-08-01 21:14:32,185 INFO : test_sample_misclass      0.75000
2017-08-01 21:14:32,185 INFO : train_misclass            0.74348
2017-08-01 21:14:32,185 INFO : valid_misclass            0.77586
2017-08-01 21:14:32,186 INFO : test_misclass             0.75000
2017-08-01 21:14:32,186 INFO : runtime                   0.89794

The trialwise accuracies are then 1-misclass, so at this point the train accuracy in % is:
(1- 0.74348) * 100% = 25.652%
If you want to compute the accuracies again, the following  code would do it.
In the main in the bottom of the file, after:
exp = run_exp(data_folder, subject_id, low_cut_hz, model, cuda)

For trialwise decoding add:
from braindecode.torch_ext.util import var_to_np
iterator = exp.iterator
model = exp.model
for setname, dataset in (('Train', exp.datasets['train']),
                         ('Valid', exp.datasets['valid']),
                         ('Test',  exp.datasets['test'])):
    # Here, we will use the entire dataset at once, which is still possible
    # for such smaller datasets. Otherwise we would have to use batches.
    net_in = np_to_var(dataset.X[:, :, :, None])
    if cuda:
        net_in = net_in.cuda()
    net_target = np_to_var(dataset.y)
    if cuda:
        net_target = net_target.cuda()
    outputs = model(net_in)
    predicted_labels = np.argmax(var_to_np(outputs), axis=1)
    accuracy = np.mean(dataset.y == predicted_labels)
    print("{:6s} Accuracy: {:.1f}%".format(
        setname, accuracy * 100))

and this for cropped training:
from braindecode.experiments.monitors import compute_preds_per_trial_for_set
from braindecode.torch_ext.util import var_to_np

iterator = exp.iterator
model = exp.model
input_time_length = exp.iterator.input_time_length
model.eval()
for setname, dataset in (('Train', exp.datasets['train']),
                         ('Valid', exp.datasets['valid']),
                         ('Test',  exp.datasets['test'])):
    # Collect all predictions and losses
    all_preds = []
    for batch_X, batch_y in iterator.get_batches(dataset, shuffle=False):
        net_in = np_to_var(batch_X)
        if cuda:
            net_in = net_in.cuda()
        net_target = np_to_var(batch_y)
        if cuda:
            net_target = net_target.cuda()
        outputs = model(net_in)
        all_preds.append(var_to_np(outputs))
    # Assign the predictions to the trials
    preds_per_trial = compute_preds_per_trial_for_set(all_preds,
                                                      input_time_length,
                                                      dataset)
    # preds per trial are now trials x classes x timesteps/predictions
    # Now mean across timesteps for each trial to get per-trial predictions
    meaned_preds_per_trial = np.array([np.mean(p, axis=1)
                                       for p in preds_per_trial])
    predicted_labels = np.argmax(meaned_preds_per_trial, axis=1)
    accuracy = np.mean(predicted_labels == dataset.y)
    print("{:6s} Accuracy: {:.1f}%".format(
        setname, accuracy * 100))

thank you very much , it indeed answer my question :smile:

Perfect :)


Allow multiple modals

Salut les Troyens,
I'm digging up an old issue (#41) but I'd like to use multiple modals (a modal within another modal ...) whilst keeping the previous ones in the background. I'm currectly moving the node in the DOM each time I'm creating a modal :
const modal = new tingle.modal(modalOptions);
document.body.append(modal.modal);

Correct me if I'm wrong but there is only one change to consider in https://github.com/robinparisi/tingle/blob/master/dist/tingle.js#L55 :
// instead of inserting before the first body node
document.body.insertBefore(this.modal, document.body.firstChild)

// just append them to the body
document.body.append(this.modal)

Is there something I'm missing that forces us to put the new node right after the document body and prevents this functionality from being implemented ?

This feature would be great.
So there would be the possibility to open a different modal after one is closed. Dialog like.

Still wishes here.
Looking for a positive confirmation button, which may allow opening a new modal, just after closing the old one.


[WIP] Hamiltonian Model

Summary
Started working on Hamiltonian Model. It is now just a subclass of OperatorModel with special behaviour for checking if the operators are Hermitian, and for having frames specified as Hermitian operators.

Redid the details of this in light of recent changes to OperatorModel and surrounding classes.
Going to add a subclasses of BMDE problem for the Schrodinger equation, utilizing the new HamiltonianOperator.

Note: just added an "order" attribute to StateTypeConverter for array reshaping commands. (Purpose is to enable vectorization in column stacking, but the default 2d->1d array reshaping is row stacking.)

Can you rename to:

Still haven't had a change to go through all this yet, but a couple of superficial comments regarding names. Can we change:
QuantumSystemModel -> LindbladModel (or maybe LinbladianModel?)
SchrodingerProblem -> StatevectorProblem
LindbladProblem -> DensityMatrixProblem
LindbladianProblem -> SuperOpProblem (or maybe QuantumChannelProblem)
and add a UnitaryProblem

Looking at the example notebooks removing the BMDE_Solver class would bring to interface to look something like:

Solve Shrodinger equation with a HamiltonianModel

hamiltonian = HamiltonianModel(operators=operators, signals=signals)
problem = SchrodingerProblem(hamiltonian)

# Solve with default frame
y = solve(problem, [0., T], y0, options={'atol'=1e-10, 'rtol'=1e-10})

# Solving with no frame
problem.frame = None
y = solve(problem, [0., T], y0, options={'atol'=1e-10, 'rtol'=1e-10})

There also seems to be a lot of overlap in between using Model and  Problem classes (like frames / cutoffs etc), especially if we remove the solve params (t0, tf, y0) from problems. In all the example notebooks you do all the work with the model and only use the problem to feed into the solve function. Maybe we should think about combining these two classes, so you can just work with model and models could allow different cases depending on type/shape or y0? Something like
HamiltonianModel -> y0 could be statevector, density matrix, or unitary (operator).
LindbladModel -> y0 could be statevector/density matrix, unitary (operator), or quantum channel (superop)
# Schrodinger
model = HamiltonianModel(operators, signals)
y0 = Statevector([1, 0]) # or just [1, 0]
y = solve(model, [0, T], y0)

# Heisenberg
y0 = Operator([0, 1], [1, 0]) # or just [[0, 1], [1, 0]]
y = solve(model, [0, T], y0)

# Lindblad
model = LindbladModel(operators, signals, noise_operators, noise_signals)
y0 = DensityMatrix([[1, 0], [0, 1])
y = solve(model, [0, T], y0)

# Superop
y0 = SuperOp(Operator([0, 1], [1, 0]))
y = solve(model, [0, T], y0)

And general ODEs would still be
model = OperatorModel(...)
y0 = np.array(...)
y = solve(model, [0, T], y0)

I'm going to go through the simpler comments one by one now, but I think the more overall design-oriented comments would be best handled in subsequent, more-specific, issues/PRs.
To summarize (combining both what you've said and my responses), I think there are 3 (or more) subsequent issues/PRs to do:

Remove BMDE_Solver and make the interface of solve more like solve_ivp in scipy. Breaking it down roughly:

Move functionality in BMDE_Solver regarding input/output types into solve.
Rename ODE_Method and BMDE_Method to ODE_Solver and BMDE_Solver respectively.
Modify the interface to solve (along the structure of ODE_Solver and BMDE_Solver) to more closely resemble solve_ivp in scipy, potentially  also making ODE_Solver and BMDE_Solver resemble the corresponding scipy classes.

Clarify frame handling in the BMDE_Problem interface

Change frame keyword arg to solve_in_frame to make it clear that this frame specification is purely for the solver
Similarly, change the kwarg cutoff_freq to solve_with_cutoff_freq
Add a results_in_frame kwarg to specify the frame that the user wants results in

Add abstract base classes for HamiltonianModel and QuantumSystemModel (or LindbladModel)


Package not python 3 compatible

The code uses the old style of exception handling. It appears that a small change
requests.exceptions.RequestException, e:

to
requests.exceptions.RequestException as e:

on lines 52, 78 and 107 makes the code python 3.4 compatible using the anaconda distribution.

Just to add - the old style exception support was extended to allow the new style in Python 2.6. The new-style (except X as y:) is supported in both Python 2.6, 2.7 and 3.0+ and this includes the soon-to-be-released Python 3.5. Python 2.5 was deprecated a while back, Python 2.6 was deprecated in 2013, Python 2.7 will be deprecated in 4 years (2020).

Sent in PR #6 to address this

Thanks for this. I'm running Python 3.8 and not too familiar with scripts themselves but at least I could run it with your fix

@moseleyi Glad I could help!


Unable to change temperature via automation

In the Home app I am able to manually change the temperature. If I attempt to change the temperature and not the heat/cooling mode via an automation using a scene or controlling the accessory directly, it doesn't work. If temperature change occurs with a mode change, it is successful.
In HomeBridge logs I can see the command being issued:
[6/6/2021, 10:51:27 PM] [Daikin Airbase] Set HeaterCooler heating threshold temperature success: 16
[6/6/2021, 10:51:27 PM] [Daikin Airbase] Set HeaterCooler target heater/cooler state success: 1

The Home app briefly displays what the automation has attempted to do, but evenly refreshes to show what the previous set temperature.
This also occurs with a power state change. If prior to turning the a/c off the unit it was in heating mode and temperature set to 20. When the automation turns it back on, the temperature is still set to 20, even though the automation was meant to set it to heating mode and temperature 16.

Hi @paulgab,
I have used automations to turn on the aircon in the past without a problem, I know other users have too.
Let's try to debug your problem.
Could you start your Homebridge server in debug mode so that we can see debug traces (I am especially interested in the requests sent to the Airbase over the network). Use the console argument -D to start Homebridge in debug mode.
If you could then run your automation again and let me know what happens in the logs around these lines that you shared.
Thanks.

Start state, heating 20C, fan auto
Applying scene, heating 16C:
[37m[6/7/2021, 8:46:33 PM] [Daikin Airbase] Set HeaterCooler heating threshold temperature with value: 16
[6/7/2021, 8:46:33 PM] [Daikin Airbase] Set HeaterCooler active state with value: 1
[6/7/2021, 8:46:33 PM] [Daikin Airbase] Set HeaterCooler target heater/cooler state with value: 1
[6/7/2021, 8:46:33 PM] [Daikin Airbase] Sent: http://<IP_ADDRESS>/skyfi/aircon/get_control_info With Values: undefined Response: {
  power: 1,
  mode: 1,
  targetTemperature: 20,
  modeTargetTemperature: { '1': 20, '2': 23, '3': 20 },
  fanRate: 0,
  fanAirside: 0,
  fanAuto: 0,
  fanDirection: 0
}
[6/7/2021, 8:46:33 PM] [Daikin Airbase] Set HeaterCooler active state success: 1
[6/7/2021, 8:46:34 PM] [Daikin Airbase] Sent: http://<IP_ADDRESS>/skyfi/aircon/set_control_info?pow=1&mode=1&stemp=20&f_rate=0&f_airside=0&f_auto=0&f_dir=0 With Values: {
  power: 1,
  mode: 1,
  targetTemperature: 20,
  modeTargetTemperature: { '1': 16, '2': 23, '3': 20 },
  fanRate: 0,
  fanAirside: 0,
  fanAuto: 0,
  fanDirection: 0,
  priority: 1
} Response: null
[6/7/2021, 8:46:34 PM] [Daikin Airbase] Set HeaterCooler heating threshold temperature success: 16
[6/7/2021, 8:46:34 PM] [Daikin Airbase] Set HeaterCooler target heater/cooler state success: 1
Home show the change was successful until it polls for an update:
[37m[6/7/2021, 8:48:29 PM] [Daikin Airbase] Polling for Aircon state
[6/7/2021, 8:48:29 PM] [Daikin Airbase] Sent: http://<IP_ADDRESS>/skyfi/aircon/get_control_info With Values: undefined Response: {
  power: 1,
  mode: 1,
  targetTemperature: 20,
  modeTargetTemperature: { '1': 20, '2': 23, '3': 20 },
  fanRate: 0,
  fanAirside: 0,
  fanAuto: 0,
  fanDirection: 0
}
[6/7/2021, 8:48:29 PM] [Daikin Airbase] Sent: http://<IP_ADDRESS>/skyfi/aircon/get_sensor_info With Values: undefined Response: { indoorTemperature: 20, outdoorTemperature: 5 }

Thanks for the logs @paulgab, I can see what is happening. The plugin expects the (multiple) commands from HomeKit to arrive in a specific order, and then it tries to merge them together to send just one request to the Airbase module (because the Airbase module cannot take multiple requests successfully in a short timeframe, it drops the consecutive ones).
So what happens here is that the targetTemperature is actually being reused from the value it got while fetching current values with get_control_info, because the Set HeaterCooler target heater/cooler takes precedence. It's a caching and prioritising issue.
I will try to produce a change that could fix that, I will ask you to test it and let me know.

Can you please update the plugin to use this version that has a patch:
npm install -g yenoiwesa/homebridge-daikin-airbase#91aea2b497ec84da27fb34bccbf4e74e0fc4d4fc

(omit the -g if you don't have a global install)
...and let me know if you have better results running your automation please?

The patched version has fixed the issue.
[37m[6/8/2021, 8:09:37 AM] [Daikin Airbase] Set HeaterCooler heating threshold temperature with value: 16
[6/8/2021, 8:09:37 AM] [Daikin Airbase] Set HeaterCooler active state with value: 1
[6/8/2021, 8:09:37 AM] [Daikin Airbase] Set HeaterCooler target heater/cooler state with value: 1
[6/8/2021, 8:09:37 AM] [Daikin Airbase] Sent: http://<IP_ADDRESS>/skyfi/aircon/get_control_info With Values: undefined Response: {
  power: 1,
  mode: 1,
  targetTemperature: 20,
  modeTargetTemperature: { '1': 20, '2': 23, '3': 20 },
  fanRate: 0,
  fanAirside: 0,
  fanAuto: 0,
  fanDirection: 0
}
[6/8/2021, 8:09:37 AM] [Daikin Airbase] Set HeaterCooler active state success: 1
[6/8/2021, 8:09:38 AM] [Daikin Airbase] Sent: http://<IP_ADDRESS>/skyfi/aircon/set_control_info?pow=1&mode=1&stemp=16&f_rate=0&f_airside=0&f_auto=0&f_dir=0 With Values: {
  power: 1,
  mode: 1,
  targetTemperature: 16,
  modeTargetTemperature: { '1': 16, '2': 23, '3': 20 },
  fanRate: 0,
  fanAirside: 0,
  fanAuto: 0,
  fanDirection: 0,
  priority: 2
} Response: null
[6/8/2021, 8:09:38 AM] [Daikin Airbase] Set HeaterCooler heating threshold temperature success: 16
[6/8/2021, 8:09:38 AM] [Daikin Airbase] Set HeaterCooler target heater/cooler state success: 1
[6/8/2021, 8:09:38 AM] [Daikin Airbase] Sent: http://<IP_ADDRESS>/skyfi/aircon/get_sensor_info With Values: undefined Response: { indoorTemperature: 19, outdoorTemperature: 5 }
Thanks

Hi @paulgab, that's great to hear!
I just released version 3.0.2 of the plugin with the patch included. I suggest you move to that final release version rather than staying on the patch version:
npm install -g yenoiwesa/homebridge-daikin-airbase@latest

Cheers!


Can't launch debug config with runtimeExecutable that has a space in the path

This is a duplicate of #40301, which was locked.

VSCode Version: 1.21.1
OS Version: Windows 10

Steps to Reproduce:

Create a launch.json config with a runtimeExecutable that has spaces in the path
Run the configuration

Example launch config:
{
    "type": "node",
    "request": "launch",
    "name": "Mocha",
    "cwd": "${workspaceFolder}",
    "runtimeExecutable": "${workspaceFolder}/node_modules/.bin/mocha.cmd",
    "windows": {
        "runtimeExecutable": "${workspaceFolder}\\node_modules\\.bin\\mocha.cmd"
    },
    "runtimeArgs": [
        "${workspaceRoot}/test/**/*.js"
    ],
}

You can also write out the windows.runtimeExecutable path yourself:
    "windows": {
        "runtimeExecutable": "C:\\Users\\Kevin Snyder\\Documents\\Projects\\Killer Queen\\kqstats\\node_modules\\.bin\\mocha.cmd"
    },

Debug console output:
C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats\node_modules\.bin\mocha.cmd 'C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats/test/**/*.js'
'C:\Users\Kevin' is not recognized as an internal or external command,
operable program or batch file.

I get the same error running the same command in PowerShell or the Command Prompt.
PowerShell:
PS C:\Users\Kevin Snyder\documents\projects> C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats\node_modules\
.bin\mocha.cmd 'C:\Users\Kevin Snyder\Documents\Projects\Killer Q
ueen\kqstats/test/**/*.js'
C:\Users\Kevin : The term 'C:\Users\Kevin' is not recognized as the name of a cmdlet, function, script file, or
operable program. Check the spelling of the name, or if a path was included, verify that the path is correct and try
again.
At line:1 char:1
+ C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats\node_mo ...
+ ~~~~~~~~~~~~~~
    + CategoryInfo          : ObjectNotFound: (C:\Users\Kevin:String) [], CommandNotFoundException
    + FullyQualifiedErrorId : CommandNotFoundException

Command Prompt:
C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats\node_modules\.bin\mocha.cmd 'C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats/test/**/*.js'
'C:\Users\Kevin' is not recognized as an internal or external command,
operable program or batch file.

However, if I wrap the path to mocha.cmd in double quotes, the execution is successful:
Command Prompt:
"C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats\node_modules\.bin\mocha.cmd" 'C:\Users\Kevin Snyder\Documents\Projects\Killer Queen\kqstats/test/**/*.ts'
Debugger listening on ws://<IP_ADDRESS>:17393/345f6b35-06f7-480c-85f2-34358dcb600a
For help see https://nodejs.org/en/docs/inspector

Does this issue occur when all extensions are disabled?: Yes

The bug is that we are quoting the executable path with a space with single quotes instead of double quotes. Windows command prompt doesn't like that.
But this should not block you because the recommended way for a mocha launch config does not have this problem.
You can easily create it by pressing the big "Add Configuration..." button in the launch.json editor:
        {
            "type": "node",
            "request": "launch",
            "name": "Mocha Tests",
            "program": "${workspaceFolder}/node_modules/mocha/bin/_mocha",
            "args": [
                "-u", "tdd",
                "--timeout", "999999",
                "--colors",
                "${workspaceFolder}/test"
            ],
            "internalConsoleOptions": "openOnSessionStart"
        }

Using this on a project that has a space in the path works fine for me.
Comment for your launch config:

you don't have to use backslashes as path separators on Windows
you don't have to introduce a Windows specific path that adds the ".CMD". We do this automatically.
don't use glob patterns in launch configs because there is not always a shell that will expand them       (e.g. "${workspaceRoot}/test/**/*.js" is not expanded in your case)
even if there is shell (e.g. when using "console": "integratedTerminal"), a "**" does not do what you expect.

@roblourens I've added this workaround to "legacy".

Thanks for the follow up. Yeah my configuration is an odd one without context. There were originally more options as I was trying to debug TypeScript unit tests using ts-node. Recently breakpoints stopped working with the traditional configuration, so I was fiddling around trying to find a fix. I removed the additional options to provide a minimum reproducible configuration and rule out other issues.
I'll be sure to take note of your comments as I continue finding a workaround. Many thanks :)

Added the same workaround

I don't think we expect to be able to do anything else here, so I'll close this.


Change current command & control  on DNS over HTTPS (DoH)

How do you like the idea of change current command & control on DNS over HTTPS (DoH)?
PS https://outflank.nl/blog/2018/10/25/building-resilient-c2-infrastructues-using-dns-over-https/

So I read through the article and nothing is really jumping out at me. Can you explain a little about what you think the benefits of using this method would be?

OK well a couple things about that:

The initial stager that talks to Koadic is going to stand out anyways, if used over HTTP. Anyone who is diligently observing network traffic will see the first request and it will raise red flags.
If we can talk to Koadic and we have the ability to talk over an encrypted channel, you might as well just talk to Koadic over HTTPS.

Eventually you have to talk to something that's not Google. If stage 2 talks back to the C2 over an unencrypted channel, the whole point is moot. If you can talk to Koadic over an encrypted channel, then DNS over HTTPS is just unnecessary.

So yeah, basically I don't see any real benefit for this, but we'll continue keeping an eye on better methods for communications.


Improved the background and card style of Dummygram

Due to technical issues with the dark mode feature on Dummygram, it was not working correctly. As a result, I have decided to keep the background color white, instead of using a gradient. This will allow both the light-mode and dark-mode features to be available on Dummygram and that too working correctly.
To enhance the aesthetics of the card style on Dummygram, I have made improvements to the border color. Specifically, I have given the border a black color for the light mode, and I have changed the border color to white for the dark mode, which creates a 3D effect. These changes will help to create a more visually appealing and cohesive user experience on Dummygram.
Solved issue #213
Here are some screenshots for review
Light mode:

Dark mode:

I have also minimized the excess white space above the post.

This branch is out of date with branch. I'd suggest you create a new clone. Then work on issues separately by creating new branches. This is a part of github flow and should be followed to work on any OSS. I'm sorry if I sounded harsh.

closing as inactive


Synthesized conformances ignore availability & deprecation

Description
When synthesizing conformance (at least to Equatable and Hashable), the compiler ignores the availability of conformances on constituent properties.
I discovered this because in the Xcode 16 SDK, CGSize has a conformance to Hashable that's only available from iOS 18.
Reproduction
struct S {}

@available(macOS 90, *)
extension S: Equatable {
    static func == (lhs: S, rhs: S) -> Bool {
        if #available(macOS 90, *) {
            true
        } else {
            fatalError("this function does not exist")
        }
    }
}

struct T: Equatable {
    var s: S
}

_ = T(s: S()) == T(s: S())

$ swiftc -swift-version 6 ConditionalConformanceBackDeploy.swift
ConditionalConformanceBackDeploy.swift:6:12: warning: unnecessary check for 'macOS'; enclosing scope ensures guard will always be true
 2 |
 3 | @available(macOS 90, *)
 4 | extension S: Equatable {
   | `- note: enclosing scope here
 5 |     static func == (lhs: S, rhs: S) -> Bool {
 6 |         if #available(macOS 90, *) {
   |            `- warning: unnecessary check for 'macOS'; enclosing scope ensures guard will always be true
 7 |             true
 8 |         } else {
$ ./ConditionalConformanceBackDeploy
ConditionalConformanceBackDeploy/ConditionalConformanceBackDeploy.swift:9: Fatal error: this function does not exist
zsh: trace trap  ./ConditionalConformanceBackDeploy

Expected behavior
Ideally, I guess the synthesized conformance would also get synthesized availability, intersecting the availabilities of all the constituent properties.
I'd also accept that the conformance simply cannot be synthesized where the availability of its type/extension doesn't match/exceed the availability of the constituent properties
Environment
swift-driver version: 1.115 Apple Swift version 6.0 (swiftlang-<IP_ADDRESS>.10 clang-16<IP_ADDRESS>)
Target: arm64-apple-macosx14.0
(Xcode 16.0)
Additional information
No response

Thanks for the detailed report! The correct behavior is for the compiler to refuse to create a synthesized conformance, since it can't be assumed that inserting something like a fatalError() on the else branch is the appropriate way to handle the missing conformance.


Merge master into vnext-engine

Describe the proposed changes
Merged master into vnext-engine because I needed to propagate the changes to how
we get docker/docker reference docs and so I can finish #583
Unreleased project version
engine 1.13
Please take a look
@thaJeztah there were a few commits here I think you should look at, to make sure I chose the correct side. I'll find them in the list and call them out. I don't expect an exhaustive review.
cc/ @johndmulhausen

@thaJeztah you will need to use the command line to review this. You can probably skip reviewing everything that is not in engine and then it will be faster. This might help (I ran this while I was in the engine/ subdir:
$ git log --since=2016-11-04 --oneline .
85e0097 Merge branch 'master' into vnext-engine
2bd57a4 Merge pull request #685 from aanand/deploy-composefile
90819b7 Merge branch 'master' of https://github.com/docker/docker.github.io
526a9b9 Fixing merge conflict
70617e6 Adding Yakkety to opening list
921964a s/sizes/size
0891e12 Merge pull request #408 from yangyuqian/explain_downloaded_image_and_container_size
2e5892e Writerly changes
2f817e4 Fix merge conflicts
a5bf14e Merge pull request #334 from mstanleyjones/run_reference_reorg
a9e535f Merge pull request #610 from fbouliane/add-dns-host-to-instructions
756f4d9 Fix some doubled words
3bcd9b4 Replace 'ls Dockerfile' with 'ls'
da3b4ff First version of stack deployment tutorial
4364535 Merge pull request #640 from mstanleyjones/203_dns_server_ubuntu
d0fb13d Add redirect for /articles/networking/
8dfa987 Merge pull request #531 from mstanleyjones/528_pin_image_by_digest
718296c Rewrites to Ubuntu installation
1cf72c7 Document ability to update a service's image
a4b2357 Clarification about flocker driver (#626)
eeace80 Merge pull request #698 from sanscontext/more-d-id
013d8f0 Merge pull request #631 from mstanleyjones/followup_link_flag
d3155b9 About the docker_gwbridge network (#400)
c23aa3a remove some unneeded text with new Docker ID topic
5c3bc27 Merge pull request #558 from akirakoyasu/patch-logging-fluentd-address
1c8370d Add NATS client as option for publishing container logs (#369)
b9e40eb Updated the link text to "the instructions for installing Docker on Ubuntu"
b356a0b Updated the URL syntax in mark down at line 73
30772c6 Merge pull request #511 from mstanleyjones/pull_docker_refs_from_git
26ce688 Adds a space to correct broken code block
707b035 live-restore unsupported on Windows (#564)
97d8ab1 Add topic about limiting container resources
d27ac5e Add a little more clarification about --link
4725674 Pin notary-server to v0.4.2
2b05451 Merge pull request #584 from thaJeztah/check-docs-sync
00b4a1a Remove the naming digression from the networking tutorial
d2e8ccf Remove engine docs for refs, plugins, deprecated from docs source
6436b0f Create logentries.md (#244)
71368b4 Add DNS SubjectAltName to certificate recipe
9f8db0f Remove redirect that was an error
1e688ad Merge pull request #540 from dhauenstein/patch-1
a0719b1 Merge pull request #597 from guillaumeguerin/patch-1
5a8b802 Merge pull request #579 from scottlaw1/patch-1
2f565d6 Change apt-key keyserver URL
ad491d6 Update step_four.md
089d910 Update understanding-docker.md (#406)
52a6f05 Add engine changes that were lost in syncing
babd3da Change "tho" to "though"
185b5db Provide clarification on status of `--link`
a726bf5 rephrase description of adding GUI to USER instruction
8c2a09e Update ubuntulinux.md
b0e0566 Added command for ssh into swarm manager
cff0907 add unix-sockets support in Fluentd logging driver
b480b75 Merge pull request #433 from docker/revert-175-patch-1
a5e01e1 fix type of keywords entry in frontmatter (in /engine/) (#552)
1cead39 Added GID to USER instruction
65aa473 Merged master into vnext-engine to get metadata updates
57b45d5 fix duplicated page titles (#512)
bc6f46a Add Ubuntu 16.10 Yakkety Yak
db153d8 Revert "remove ubuntu wily 15.10"
4508863 Remove Ubuntu 15.10 Wily Werewolf
ff59423 Merge pull request #440 from rillig/we-you
71ff5c1 Add missing whitespace (#486)
3882cb1 Updated link in step_four.md (#478)
d35d1f7 Stylistic cleanup in usingdocker.md
2c9eff5 Replace "we" with "you", as per the style guide
a0aa3e7 Reword and reformat "Breaking changes" page (#473)
5433809 Update service_create.md

@mstanleyjones looks like that only shows the commits that were opened against the vnext-engine branch, but the merge from "master" shows as a single line
85e0097 Merge branch 'master' into vnext-engine

@thaJeztah ooh you are right, so you can just do a git diff HEAD^?

ok, there are some issues; some changes present in vnext-engine are reverted in the merge, it at least spotted engine/installation/linux/ubuntulinux.md (adds Ubuntu 15.10 again, which was removed in https://github.com/docker/docker.github.io/pull/503)
also saw engine/admin/logging/splunk.md, where https://github.com/docker/docker/commit/603fd0831513257bc26d20ca1f64efcc4965eae6 (https://github.com/docker/docker/pull/25786) and https://github.com/docker/docker/commit/4907cc7793cf469fc2d6fc0f842d08bd045da569 (https://github.com/docker/docker/pull/26207) are reverted
Is the plan to keep this branch alive after it was merged to master? It's a pity we can't just rebase the branch on top of master (for a cleaner history) 😇
Looks like there's some unrelated whitespace changes as well
git --no-pager diff HEAD^ | grep "No newline at end of file" | wc -l
317

We should try to be more strict when reviewing to prevent that (https://github.com/docker/docker.github.io/pull/552#pullrequestreview-10741188)

This one is hopeless, opening a new PR.


Expand in-source script definition macros to allow for custom embedded scripts at global scope

We currently need scripts to be defined either as individual files (my_script_file.cpp) or as embedded lambdas/script expressions (SCRIPT_BEGIN, SCRIPT_END, on(...), etc.), but this isn't always the most natural way to define a script.
We should extend the macro API (found in engine:script's embedded_script.hpp file) to allow script definitions outside of the body of the current script.
This would look something like:
SCRIPT(my_custom_script)
	while (true)
	{
		const auto& button_event = co_await until<OnButtonPressed>();

		print("Button pressed: {}", button_event.button);
	}
END_SCRIPT()

auto my_script_file()
{
	co_await start_script<my_custom_script>();

	// ...
}

We could also optionally have a SCRIPT_CLASS macro to allow for extensions similar to the header-based approach.
SCRIPT_CLASS(my_custom_script)
	decltype(auto) some_fn(thid auto&& self, auto&& some_arg, auto&&... etc)
	{
		// ...
	}
END_SCRIPT_CLASS()

NOTE: SCRIPT_CLASS may need to be defined above the SCRIPT(my_custom_script) section.

Implemented the SCRIPT and END_SCRIPT macros. Going to put the SCRIPT_CLASS idea on hold for now.


Drop down selection - GUI

Make sure you are running the latest version of Home Assistant before reporting an issue.
You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:
Home Assistant release (hass --version):
0.58.1
Component/platform:
GUI - Developer Tools - Services
Description of problem:
Drop down selection is limited to showing 3 lines even though I'm on desktop:

Expected:
Allow drow down to dynamically expand to the full height of browser window.

I am seeing the full height

I've noticed it just showing that very short menu for a while as well.  Seeing that in both Chrome and Firefox

I believe 0.59 reworked a lot of the service and entity selection anyway, so might be worth updating to the latest and trying again.

Sure enough, 0.59 does in fact fix this for me


Add Transaction for DynamoDB using Document Interfaces or Object Persistence Interface

#25 has been 6 years.
There are really little document on .net or .net core.
And seems impossible to do it in Document Interfaces or Object Persistence Interface.

Thanks for voicing your interest.  I'm going to close this out as a duplicate of https://github.com/aws/aws-sdk-net/issues/1453.  If you have any more comments to add about your use case or how you would prefer the implementation to look like, please comment there.

How hard can this possibly be? Transaction support is already in the low level library, I would assume the high level libraries are just handling type serialization and such... so how hard is it to add the transactional version of the batching methods?

For anyone looking for a workaround, you can combine the low-level api with high-level api serialization by doing something like:
    var dynamoDbClient = new AmazonDynamoDBClient();
    var dynamoDbContext = new DynamoDBContext(dynamoDbClient);
    var item1 = new MySampleItem();
    var item2 = new MySampleItem();
    await dynamoDbClient.TransactWriteItemsAsync(new TransactWriteItemsRequest()
    {
      TransactItems = new List<TransactWriteItem>
      {
        new TransactWriteItem()
        {
          Put = new Put()
          {
            Item = dynamoDbContext.ToDocument(item1).ToAttributeMap(),
            Ta
            TableName = dynamoDbContext.GetTargetTable<MySampleItem>().TableName
          },
        },
        new TransactWriteItem()
        {
          Put = new Put()
          {
            Item = dynamoDbContext.ToDocument(item2).ToAttributeMap(),
            TableName = dynamoDbContext.GetTargetTable<MySampleItem>().TableName
          }
        },
      }
    });


local provider requires pr-url

What's are the command line parameters when provider = local?

Similar Issues:

Bitbucket docs

Support for other git providers like Azure Repos

PR description using commit messages may produce wrong results

Failure in /improve command

hey @anthonym21 how're you calling your local provider? is it localhost api endpoint?

/similar_issue


Typescript migration: general UI components

As part of the typescript migration effort (https://github.com/label-sleuth/label-sleuth/issues/205), migrate the general UI components that are not specific to any module or dedicated components (the ones that are located at ./src/components/*), which implies migrating the following files:
./src/components/pagination/CustomPagination.jsx
./src/components/pagination/ArrowsOnlyPagination.jsx
./src/components/buttons/ButtonLight.jsx
./src/components/buttons/ButtonLogout.jsx
./src/components/buttons/LoadingButtonIBM.jsx
./src/components/combobox/Combobox.jsx
./src/components/combobox/ComboBoxWithInputText.jsx
./src/components/SupportIconsBar.jsx
./src/components/dialog/index.jsx
./src/components/bars/upperBar/ButtonAppBar.jsx
./src/components/Keyboard.jsx
./src/components/dropdown/Dropdown.js (rename to tsx)
./src/components/combobox/ControlledSelect.js (rename to tsx)

Note: there is no need to migrate all the listed file. Migrating subset of them (one or more) is already highly appreciated!
Note 2: you can read this PR's description in order to find the files that has been already migrated.

Check this notes for more information about how to migrate the code to typescript.

Finished!!!


feat(i18n): add zh-TW

can you also add the export in index?

should zh be renamed to zhCN?

its fine


Tutorial link in Readme is not working.

The link to Tutorial Guide (http://nodegoat.herokuapp.com/tutorial ) is not working. It would be great if this could be fixed. Thanks!

@mkarvir Thanks for informing. It appears that Heroku platform itself is down right now. I am unable to login I will keep watch on it and try to bring the NodeGoat instance back up as soon as Heroku API is available.

Trusty cloud platforms aye? My servers are still running fine.

Ha.. I recently started admiring  AWS availability SLAs and this happened.
Node goat is back up. I am closing the issue.

Yep, not everything that shines is golden. People are putting far to much trust in cloud providers. On-prem still has a lot of advantages, providing you have the specialties to admin it.

Thanks! May be this caused it -https://techcrunch.com/2017/02/28/amazon-aws-s3-outage-is-breaking-things-for-a-lot-of-websites-and-apps/


Feat/fixed grid strategy

Before submitting this PR, please make sure:

[ ] Your code builds clean without any errors or warnings
[ ] You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Add the new fixed grid strategy that was approved in the following snapshot vote:
https://snapshot.org/#/hbot-ip.eth/proposal/0xaf21d826282fcc0a4d77ad0fb775c37b7a5935af1ce106686065b4336de2f83f
Commonwealth discussion about this strategy:
https://commonwealth.im/hummingbot-foundation/discussion/3763-fixed-grid-strategy-for-hummingbot
Medium article explaining and demonstrating the strategy:
https://medium.com/@rkc2000/introducing-the-fixed-grid-strategy-for-hummingbot-d9b011c71e9b
Tests performed by the developer:
The new strategy has been tested out in paper trading and in live trading. Some samples from these runs are given in the medium article above.
Tips for QA testing:

pre-commit is successful when I run it locally now.

@JeremyKono please try running the checks again when you get a chance.

@arnelhbot the bug should be resolved now. The method of calculating order age has changed in the codebase and I just updated my code with it.

Hi @rkc2000, can you please look at the failed Github tests?

Hi @JeremyKono it looks to me like all tests have passed? Could you point me to which tests have failed?

So should we wait for the next month's release? or will you publish an intermediate release?
I mean the users by "we" :) @rapcmia


Amdsmidocs reorg

Left a few comments.

Thank you, Randy. This is still a work in progress. Appreciate your feedback though.

Left a few comments.

Thank you, Randy. This is still a work in progress. Appreciate your feedback though.

Converted the PR to Draft.

Is there anything missing here?

Likely but in the source content. This is Doxygen generated.

Merged to develop

This is merged in


Fix name from beadmass inference

@votca-bot changelog: changed tolerance for getting element names from mass

Shouldn't that go into stable instead?

I do not think it can go into stable because I also have to change CSG.

I do not think it can go into stable because I also have to change CSG.

Why not both?

good point


move read-manifest into metadata?

@alexcrichton in the metadata PR we've discussed that we might want to deprecate cargo read-manifest and provide similar functionality with cargo metadata --no-deps:  https://github.com/rust-lang/cargo/pull/2196#issuecomment-174408391
Now I'm not sure if this is a good idea: cargo read-manifest works fine, and I don't see any real benefit in moving it to metadata.
But if you think that we should do this, I'll be glad to send a PR :)

I do think that we'll want to deprecate cargo read-manifest eventually, but we probably want to wait for cargo metadata to hit stable Rust first. We can message out that read-manifest is being deprecated and we can also print a warning if the command is run.


Nothing happens for both shumway and flash. It is stuck in the Botaniculata screen.

SWF: feee05e299fc792973eb8d9097a1f9b63578ba89830695b579e244f6d6559c01 (Direct Link)

Given that there's no difference between Flash's and Shumway's behavior, there's nothing for us to do here.


Version 11 hotfix

Please read the Pull Request Checklist to ensure you have everything that is needed to get your contribution merged.

Pull Request Test Coverage Report for Build 570

16 of 26 (61.54%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.001%) to 45.883%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

frappe/init.py
0
1
0.0%

frappe/desk/reportview.py
0
1
0.0%

frappe/email/init.py
0
1
0.0%

frappe/utils/oauth.py
0
1
0.0%

frappe/integrations/doctype/webhook/webhook.py
5
7
71.43%

frappe/model/db_query.py
6
10
60.0%

Totals

Change from base Build 564:
0.001%

Covered Lines:
18001

Relevant Lines:
39232

💛  - Coveralls


"Or" does not have commutative property (possibly because it catches exceptions silently?)

Code Sample, a copy-pastable example if possible
import pandas as pd
#Create sample dataframe
test = pd.DataFrame({"a":["12", float("nan"), "3", "meow" ]})

# Select rows that are null or numeric:
print len(test[ test["a"].isnull() | test["a"].str.isnumeric()])

# Select rows that are numeric or null
print len(test[ test["a"].str.isnumeric() | test["a"].isnull() ])

# These two should return the same result, right? Unfortunately they don't

Notice that Series.str.isnumeric throws an exception on null entries. However, I believe that this may introduce bugs silently
Expected Output
Expected output is:
2
2
Instead, I get:
3
2
output of pd.show_versions()
INSTALLED VERSIONS
commit: None
python: 2.7.12.final.0
python-bits: 64
OS: Darwin
OS-release: 15.6.0
machine: x86_64
processor: i386
byteorder: little
LC_ALL: None
LANG: None
pandas: 0.18.1

FWIW, we follow python's logic here
In [40]: float('nan') or 1
Out[40]: nan

In [41]: 1 or float('nan')
Out[41]: 1

Thanks to short-circuiting, I don't think you can rely on | and or to be symmetrical.

In [44]: True or this_variable_is_undefined
Out[44]: True

The reverse of that throws a NameError.

However, I believe that this may introduce bugs silently

I suspect you're right 😄 I don't think we can change this behavior though.

I should also say that you can get the desired output by test.a.str.is_numeric().fillna(False) | test.a.isnull()

I think I didn't phrase my issue correctly.  We agree that short-circuiting may break commutativity.
I'm not talking about NaN | True.  I'm talking about:
code that raises an exception | True
If you run  isnumeric  by itself, on my sample code, an exception is raised for the null values.  The exception is NEVER raised when it's inside an or!

Ah, you're saying test['a'].str.isnumeric() raises an exception? I don't get one running master.

@TomAugspurger thank you for getting back to me.   This raises an exception to me:
test[ test["a"].str.isnumeric() ]
Which is the simplified version we were testing. The code you wrote, doesn't raise an exception for me either.

Yeah it raises ValueError because Series contains NaN.
# on current master
test["a"].str.isnumeric()
# 0     True
# 1      NaN
# 2     True
# 3    False
# Name: a, dtype: object

I think .str.is_xxx method should return False rather than NaN if input is not string likes.
# expected
test["a"].str.isnumeric()
# 0     True
# 1     False
# 2     True
# 3    False
# Name: a, dtype: object

Possibly. I'm more worried about inconsistent behavior inside an or. Look:

test[ test["a"].str.isnumeric() ]  Raises exception, which may be appropriate behavior
test[ test["a"].isnull() | test["a"].str.isnumeric()]  Does not raise exception due to short-circuiting, therefore this is appropriate behavior
test[ test["a"].str.isnumeric() | test["a"].isnull() ] Does not raise an exception, although it should!

This boils down to the Series behaviour for | with Nans:
In [10]: pd.Series([True, np.nan]) | pd.Series([False, True])
Out[10]:
0     True
1    False
dtype: bool

In [11]: pd.Series([False, True]) | pd.Series([True, np.nan])
Out[11]:
0    True
1    True
dtype: bool

So the comparison never propagates the NaN. For this reason, you do not get any exception.
But, the difference between both is a bit surprising.

The issue about NaNs in booleans is already discussed in https://github.com/pydata/pandas/issues/6528, so closing here as a duplicate.

test[ test["a"].str.isnumeric() | test["a"].isnull() ]Does not raise an exception, although it should!

@josepablog Whether it should raise or not depends on the outcome of np.nan | True/False. This currently returns False. If we decide that False is the correct outcome, then the above code snippet should not raise. However, it could be argued that np.nan | True/False should return np.nan, and in that case the above code snippet will raise. But the return value of np.nan | True/False is rather independent of this specific use case, and as in my previous comment, this is covered in #6528

@jorisvandenbossche, @TomAugspurger what do you think .str accessor to return error case, NaN or False?

Ah yes, forgot that part of the issue. Is there any precendence for other of the string methods on how they handle errors / NaNs?

@sinhrks I prefer the current behavior of str.is_* propagating NAs.

It seems more consistent with other non-reducing behavior for how it treats NAs (eg. nan + 1 is nan)
If you seems easier to followup the is_* with a fillna than to somehow recover the NAs if you do want to propagate them.

We could document this better. This is a common enough gotcha that we should include a warning box in the prose docs. Another option is to add a fill_value to all the is* methods for NA behavior, defaulting to None/np.nan. That would give the behavior a bit more visibility.


mkcast: init at 2015-03-13

newcast does not work due to
https://github.com/KeyboardFire/mkcast/issues/30
closes #6333
(Tested using Xmonad with XMonad.Hooks.EwmhDesktops)
cc @domenkozar

Does it work for you? mkcast Chromium 10000 exists and out.gif is useless.

It works for me.

However with chromium it works only if I have a single tab, but that seems to be a bug in mkcast. Do you really start it with a duration of 10000 seconds? That are almost three hours, so out.gif should contain meaningful content after that amount of time.

I think it's just i3wm compatibility problem or similar.


Challenge 4 - Invalid Inputs

[ ] The ethToToken, Deposit, and Withdraw inputs will only allow a '.' if you first type in a 0.  We should allow them to type something like '.5' instead of forcing '0.5'.

[ ] The tokenToEth input throws the following error when anything other than a number is entered, including a '.'

This should behave in the same way the other inputs do where if you type a non number or decimal it omits it.

[ ]  The ethToToken, Deposit, and Withdraw inputs will only allow a '.' if you first type in a 0.  We should allow them to type something like '.5' instead of forcing '0.5'.
[ ]  The tokenToEth input throws the following error when anything other than a number is entered, including a '.'

This should behave in the same way the other inputs do where if you type a non number or decimal it omits it.

for ethToToken, Deposit, and Withdraw inputs, they are using scaffold-eth's EtherInput component and also tokenToEth is using IntegerInput component. Since they are coming as default and as a part of SE-2, I couldn't know if I should touch them. Shall I try to change these components or I can try to fix without touching the components or maybe Shiv or Carlos can take a look at these components if they built these ones

for ethToToken, Deposit, and Withdraw inputs, they are using scaffold-eth's EtherInput component

Yup this is something we can handle at SE-2, but I have fixed it at #53

also tokenToEth is using IntegerInput component.

Regarding this and hydration error that Zak got, Since you have updated IntegerInput to act as normal input (passing hiddendSuffix) and manually parsing the value in useScaffoldContractWrite hook we need to handle it while passing
Fixed it at #53 🙌

Closing this since #53 🙌


Change how assert_xydata() handles sets of data with different shape

base.assert_xydata() uses np.testing.assert_array_max_ulp() to compare xy_data and xy_expected. When these two sets of data have the same shape but different data, assert_xydata() throws and AssertionError with a custom message.
However, when xy_data and xy_expected have different shapes, assert_array_max_ulp() throws a ValueError that is not caught. For our purposes, this is effectively a case in which xy_data and xy_expected do not match and should be handled the same way.
We should handle this case the same way and throw  an AssertionError with a custom message.

We decided to handle this case by throwing a ValueError, but still by throwing our own error with our own message. This is addressed in #219, and can be closed when that PR is merged.


Optionally expose all underlying container metadata in status

As someone deploying a bootc system, I may want to add custom labels (or OCI annotations) into my image, and I want to be able to see that on the client side to potentially act on it.
Today this is all squirreled away in the underlying ostree-container store, one can extract it with ostree container metadata, but that's awkward and we want to get away from exposing ostree (this also relates to https://github.com/containers/bootc/pull/215 )
Maybe what we do for now is something like bootc status --full which would dump the container manifest and config into the image status?

Or maybe it would be better as bootc image inspect or so?  If we put it in status, it could get really unwieldy if we have both current and rollback, plus any future lifecycle bound images.
Maybe we should have bootc image list and bootc image inspect in that vein etc.

would bootc edit support adding custom metadata?

Hmm what would be the use case for that?  Adding container metadata is a build-time thing right?

@cgwalters what if we namespace the labels with something like ostree.status.whatever... when building the images so we avoid cluttering rpm-ostree status with too many stuff and only show those labels?

The question of exposing container information in rpm-ostree status is something we should probably track in that git repo, not here.  It has a similar design shape issue around having it out of band vs inline and size.

The question of exposing container information in rpm-ostree status is something we should probably track in that git repo, not here. It has a similar design shape issue around having it out of band vs inline and size.

ack, I wrongly thought this was for rpm-ostree status, but it's bootc status, nevermind :)

would bootc edit support adding custom metadata?

Hmm what would be the use case for that? Adding container metadata is a build-time thing right?

right, I was imagining that bootc edit would perform something like a podman commit but didn't really think it all the way through - that would get confusing


Background Audio Sample Issue

The BackgroundAudio sample will build and run, but clicking on a audio sample in the app causes a 10 second freeze followed by the exception:
throw new Exception("Background Audio Task didn't start in expected time");

I'm testing this out this unmodified sample on a Surface Pro 3, Windows 10 RTM running VS 2015 Pro.

Can you tell me what build architecture of Windows you're running on the Surface Pro 3 and what architecture you're targeting in VS? There was an early platform bug where running different architectures (x32 on x64) didn't work but this should have been addressed.
Can you also try extending the timeout in the sample code to 20 seconds to see if that makes a difference?

Surface is running x64 flavor of Windows 10 (RTM build). I'm targeting x86 in VS but both had the same failure.
But now as I go to run it, it works on both of them.  I had previously rebooted several times, opened and closed this project a half-dozen times, but now it's great. I haven't a first clue as to why. Sorry for the trouble!


chore: 🤖 use stats runtime API to get transfer restriction errs

Description
Uses statistics runtime API to get transfer restriction errors in transferring an asset.
Breaking Changes
NA
JIRA Link
DA-1315
Checklist

[ ] Updated the Readme.md (if required) ?

/fast-forward

:tada: This PR is included in version 26.0.0-alpha.2 :tada:
The release is available on:

npm package (@alpha dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 26.0.0-beta.1 :tada:
The release is available on:

npm package (@beta dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 26.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Events page title & update missed nav alias

 Events: Divide events page into PMG and Non-PMG events


Remember "Code files only" checkbox in the "Open Resource" window

Selection of "Code files only" checkbox in the "Open Resource" window is remembered just for current session. It would be nice not to set it again for every session.

Atm all dialogs are session managed as this works best with our multi instance mode wich is poor managing settings with multiple instances. If we find a proper solution to this issue, all dialogs will be changed to fully managed. We have centralized functionality already available for easy change.


github forbid shell check in pytest directory #24378

Proposed changes
merge baidu case
https://github.com/apache/doris/pull/26232
Issue Number: close #xxx

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall


Split_einsum model version missing for sdxl on hub

If I select SDXL as the default model and try to run the app on my MBP, I get:
Starting download of https://huggingface.co/apple/coreml-stable-diffusion-xl-base/resolve/main/coreml-stable-diffusion-xl-base_split_einsum_compiled.zip
HTTP response status code: 404
Seems the split_einsum version is missing on the hub

@atiorh

@pcuenca Note: this would be an easier "fix" in the new ModelInfo version where each variant is a discrete Model.


Unable to get Auth::user() in AfterAuthenticateJob

I tried registering after authenticate job just like we do it versions before 17, and then i tried to get Auth::user(), but it returns null
here is my job registration
'after_authenticate_job' => [
[
'job' =>  \App\Jobs\AfterAuthenticateJob::class,
'inline' => env('AFTER_AUTHENTICATE_JOB_INLINE', true)
],
],
And i my job code is
public function handle()
{
$user = Auth::user();
dd($user); // returns null
}

Hmm, we may need to mod this to directly input the user into the job.

Sorry brain fart... @yasir-naseer-tetralogicx The shopdomain should be in the constructor already, you need to look the shop up based on this.

@yasir-naseer-tetralogicx
Something like this:
public function __construct($shopDomain, $data)
{
  $this->shopDomain = $shopDomain;
  $this->data = $data;
}

public function handle()
{
  $user = User::where('name', $this->shopDomain)->firstOrFail();
  // do stuff here
}

For me only 1 variable in constructor works
<?php
namespace App\Jobs;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldBeUnique;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Queue\InteractsWithQueue;
use Illuminate\Queue\SerializesModels;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Helper;

class AfterAuthenticateJob implements ShouldQueue
{
    use Dispatchable, InteractsWithQueue, Queueable, SerializesModels;
    protected  $shopDomain;
    protected  $data;

    protected  $shop;

    // public function __construct($shopDomain, $data)
    // {

    //   Log::info("Constructor - start- shopDomain".$shopDomain);
    //       Log::info($data);
    //   Log::info("Constructor - end");

    //   $this->shopDomain = $shopDomain;
    //   $this->data = $data;
    // }

    public function __construct($shop)
    {

      Log::info("Constructor2 - start");
          Log::info($shop);
      Log::info("Constructor2 - end");

      $this->shop = $shop;
    }

    /**
     * Execute the job.
     *
     * @return void
     */
    public function handle()
    {
        Log::info("AfterAuthenticateJob-=call=start-".Date('Y-m-d h:i:s'));

        // Log::info("shopDomain".$this->shopDomain);

        // $this->shop = User::where('name', $this->shopDomain)->firstOrFail();

        Helper::createSearchPage($this->shop);

        Log::info("AfterAuthenticateJob-=call=end-".Date('Y-m-d h:i:s'));
    }
}

Closing as a stale issue, $shopDomain is in the constructor for the later versions and this looks like it could be an older version of the package.


In-app glossary integration

Is your feature request related to a problem? Please describe.
Users may encounter specific terms within the content of the app that they are unfamiliar with. Currently, there is no way to provide instant explanations for these terms within the app, which can hinder user understanding and accessibility.
Describe the solution you'd like
Implement a frontend feature that highlights glossary terms directly within the app content. When a user encounters a term that exists in the glossary, it should be displayed in a distinct style (e.g., underlined or highlighted, as proposed by ui-ux). Tapping on the highlighted term should open a small popup or modal providing the definition of the term.
This feature would involve:

Fetching the glossary terms from the backend.
Automatically detecting and highlighting terms within the app content.
Displaying a tooltip, popup, or modal with the term definition when the user taps on the highlighted word.

Describe alternatives you've considered
Another option would be to use a glossary icon next to the term instead of direct highlighting, which could reduce visual clutter but might be less intuitive.
Additional context
Backend-Issue: #3092 and #3090

Design-Brainstorm:

Display glossary terms with dotted undeline by default.
Display a tooltip on hover with the term definition.
Open a modal on click with more detailed information or navigation to the glossary page.

* Display a tooltip **on hover** with the term definition.

On native/mobile this would just not be implemented, correct? Or can you think of any other solution?

No final decisions have been made yet, I'll let you know as soon as a design is available here @steffenkleinle


Add KerboKatz - SmallUtilities - FPSLimiter from Kerbal Stuff

This pull request was automatically generated by Kerbal Stuff on behalf of SpaceTiger, to add KerboKatz - SmallUtilities - FPSLimiter to CKAN.
Please direct questions about this pull request to SpaceTiger.

This appears to be a sub-part of https://github.com/KSP-CKAN/NetKAN/blob/master/NetKAN/KerboKatzSmallUtilities.netkan


Update Paypal icon to remove white bg

Details
Paypal icon has the white background, now updated with new icon given here
Fixed Issues

$ https://github.com/Expensify/App/issues/5581
Tests & QA Steps

Open the App
Go to Settings -> Payments
Hover over/Select the Paypal method or Paypal method option in add payment options.
Should not see the white background behind the icon

Tested On

[x] Web
[x] Mobile Web
[x] Desktop
[x] iOS
[x] Android

Screenshots

Web

Desktop

Mobile Web
https://user-images.githubusercontent.com/85645967/136104735-8f84de56-abc5-42df-acb5-517839d2f649.mp4
iOS
https://user-images.githubusercontent.com/85645967/136104727-be7fe1dd-ca8d-4686-8c23-5443e6158eac.mp4
Android
https://user-images.githubusercontent.com/85645967/136104745-6c13e13d-62bc-470a-919c-384ba65c06eb.mov

🚀 Deployed to staging by @roryabraham in version: 1.1.6-1 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by @AndrewGable in version: 1.1.7-24 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅