HDFS-15982. Deleted data using HTTP API should be saved to the trash

branch-3.3 backport of PR #2927

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
18m 44s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m 14s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 29s

branch-3.3 passed

+1 :green_heart:
compile
3m 42s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 59s

branch-3.3 passed

+1 :green_heart:
mvnsite
1m 55s

branch-3.3 passed

+1 :green_heart:
javadoc
1m 43s

branch-3.3 passed

+1 :green_heart:
spotbugs
3m 53s

branch-3.3 passed

+1 :green_heart:
shadedclient
17m 19s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
1m 35s

the patch passed

+1 :green_heart:
compile
3m 37s

the patch passed

+1 :green_heart:
javac
3m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 54s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 4 new + 224 unchanged - 1 fixed = 228 total (was 225)

+1 :green_heart:
mvnsite
1m 40s

the patch passed

+1 :green_heart:
javadoc
1m 36s

the patch passed

+1 :green_heart:
spotbugs
4m  4s

the patch passed

+1 :green_heart:
shadedclient
17m 29s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

-1 :x:
unit
209m 16s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m  8s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

335m 36s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestReconstructStripedFileWithValidator

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 9c2889e5135e 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 0c1bcf10763576c7476e52e8b5a39be18e251dd3

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/1/testReport/

Max. process+thread count
2064 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/1/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
24m 17s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 26s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 23s

branch-3.3 passed

+1 :green_heart:
compile
3m 41s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  0s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 18s

branch-3.3 passed

+1 :green_heart:
javadoc
3m 12s

branch-3.3 passed

+1 :green_heart:
spotbugs
7m 32s

branch-3.3 passed

+1 :green_heart:
shadedclient
17m 48s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
3m 39s

the patch passed

+1 :green_heart:
javac
3m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 53s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 5 new + 221 unchanged - 4 fixed = 226 total (was 225)

+1 :green_heart:
mvnsite
2m 57s

the patch passed

+1 :green_heart:
javadoc
2m 48s

the patch passed

+1 :green_heart:
spotbugs
7m 57s

the patch passed

+1 :green_heart:
shadedclient
18m  1s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  8s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
226m 45s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
6m  7s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
unit
17m 48s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 57s

The patch does not generate ASF License warnings.

393m 43s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.TestReconstructStripedFile

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint

uname
Linux bcca3510e4c8 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 45958e676718287ed1e0010b85b622d635f31aa0

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/2/testReport/

Max. process+thread count
2056 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/2/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
24m 27s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 43s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 13s

branch-3.3 passed

+1 :green_heart:
compile
3m 47s

branch-3.3 passed

+1 :green_heart:
checkstyle
0m 59s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 23s

branch-3.3 passed

+1 :green_heart:
javadoc
3m  8s

branch-3.3 passed

+1 :green_heart:
spotbugs
7m 33s

branch-3.3 passed

+1 :green_heart:
shadedclient
17m 59s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
3m 36s

the patch passed

+1 :green_heart:
javac
3m 36s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 51s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 5 new + 221 unchanged - 4 fixed = 226 total (was 225)

+1 :green_heart:
mvnsite
2m 56s

the patch passed

+1 :green_heart:
javadoc
2m 51s

the patch passed

+1 :green_heart:
spotbugs
7m 59s

the patch passed

+1 :green_heart:
shadedclient
17m 57s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  8s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
208m  5s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
6m 15s

hadoop-hdfs-httpfs in the patch passed.

-1 :x:
unit
17m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 56s

The patch does not generate ASF License warnings.

375m 53s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux 5aaca2fd3fc8 4.15.0-128-generic #131-Ubuntu SMP Wed Dec 9 06:57:35 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / e67e7689e172353a376024464f56e1b0a1859d83

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/3/testReport/

Max. process+thread count
2538 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/3/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
23m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 57s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 43s

branch-3.3 passed

+1 :green_heart:
compile
3m 44s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  0s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 20s

branch-3.3 passed

+1 :green_heart:
javadoc
3m  8s

branch-3.3 passed

+1 :green_heart:
spotbugs
7m 35s

branch-3.3 passed

+1 :green_heart:
shadedclient
18m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 52s

the patch passed

+1 :green_heart:
compile
3m 39s

the patch passed

+1 :green_heart:
javac
3m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 55s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 5 new + 221 unchanged - 4 fixed = 226 total (was 225)

+1 :green_heart:
mvnsite
2m 59s

the patch passed

+1 :green_heart:
javadoc
2m 51s

the patch passed

+1 :green_heart:
spotbugs
7m 58s

the patch passed

+1 :green_heart:
shadedclient
18m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 10s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
207m  7s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m 14s

hadoop-hdfs-httpfs in the patch passed.

-1 :x:
unit
15m  1s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

371m  3s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap

hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.qjournal.server.TestJournalNodeSync

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload

hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux c991ff4d35a7 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / e67e7689e172353a376024464f56e1b0a1859d83

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/4/testReport/

Max. process+thread count
2215 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/4/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
jshint
0m  1s

jshint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 38s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 11s

branch-3.3 passed

+1 :green_heart:
compile
3m 42s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  2s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 21s

branch-3.3 passed

+1 :green_heart:
javadoc
3m  9s

branch-3.3 passed

+1 :green_heart:
spotbugs
7m 36s

branch-3.3 passed

+1 :green_heart:
shadedclient
18m  0s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 55s

the patch passed

+1 :green_heart:
compile
3m 42s

the patch passed

+1 :green_heart:
javac
3m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 618 unchanged - 6 fixed = 627 total (was 624)

+1 :green_heart:
mvnsite
2m 55s

the patch passed

+1 :green_heart:
javadoc
2m 50s

the patch passed

+1 :green_heart:
spotbugs
8m  1s

the patch passed

+1 :green_heart:
shadedclient
17m 58s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  9s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
205m 22s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m 16s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
unit
16m 18s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

346m 55s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.TestDistributedFileSystem

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.TestReconstructStripedFileWithValidator

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux 4ff9bebbe984 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 4bc7d779598148fd684f9bcd09396f6201d8323a

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/5/testReport/

Max. process+thread count
2107 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/5/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
26m 38s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m  0s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
26m  4s

branch-3.3 passed

+1 :green_heart:
compile
4m 22s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  7s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 58s

branch-3.3 passed

+1 :green_heart:
javadoc
3m 26s

branch-3.3 passed

+1 :green_heart:
spotbugs
8m 18s

branch-3.3 passed

+1 :green_heart:
shadedclient
19m 47s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 27s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 31s

the patch passed

+1 :green_heart:
compile
4m 23s

the patch passed

+1 :green_heart:
javac
4m 23s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  1s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 618 unchanged - 6 fixed = 627 total (was 624)

+1 :green_heart:
mvnsite
3m 37s

the patch passed

+1 :green_heart:
javadoc
3m 17s

the patch passed

+1 :green_heart:
spotbugs
8m 55s

the patch passed

+1 :green_heart:
shadedclient
20m 16s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 18s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
231m 48s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m 31s

hadoop-hdfs-httpfs in the patch passed.

-1 :x:
unit
15m 37s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

412m  8s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestReconstructStripedFile

hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.tools.TestDFSZKFailoverController

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux 61405d4adb47 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 4bc7d779598148fd684f9bcd09396f6201d8323a

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/6/testReport/

Max. process+thread count
2120 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/6/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
24m 22s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+0 :ok:
jshint
0m  1s

jshint was not available.

+0 :ok:
markdownlint
0m  1s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
11m 40s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 21s

branch-3.3 passed

+1 :green_heart:
compile
4m 41s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  8s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 44s

branch-3.3 passed

+1 :green_heart:
javadoc
3m 20s

branch-3.3 passed

+1 :green_heart:
spotbugs
8m 41s

branch-3.3 passed

+1 :green_heart:
shadedclient
18m  4s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 17s

the patch passed

+1 :green_heart:
compile
4m 39s

the patch passed

+1 :green_heart:
javac
4m 39s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 58s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 619 unchanged - 6 fixed = 628 total (was 625)

+1 :green_heart:
mvnsite
3m 21s

the patch passed

+1 :green_heart:
javadoc
3m  1s

the patch passed

+1 :green_heart:
spotbugs
9m  1s

the patch passed

+1 :green_heart:
shadedclient
18m 10s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 17s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
223m 40s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m 51s

hadoop-hdfs-httpfs in the patch passed.

-1 :x:
unit
16m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 52s

The patch does not generate ASF License warnings.

394m 21s

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.server.namenode.TestDecommissioningStatus

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/7/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux 0e6778b1e820 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 4ee943682cebc28bbe37b40d29cced08eb7fd968

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/7/testReport/

Max. process+thread count
2404 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/7/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
23m 33s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
11m 41s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
25m 31s

branch-3.3 passed

+1 :green_heart:
compile
4m 36s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  8s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 44s

branch-3.3 passed

+1 :green_heart:
javadoc
3m 21s

branch-3.3 passed

+1 :green_heart:
spotbugs
8m 41s

branch-3.3 passed

+1 :green_heart:
shadedclient
18m 26s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 17s

the patch passed

+1 :green_heart:
compile
4m 26s

the patch passed

+1 :green_heart:
javac
4m 26s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 619 unchanged - 6 fixed = 628 total (was 625)

+1 :green_heart:
mvnsite
3m 22s

the patch passed

+1 :green_heart:
javadoc
3m  5s

the patch passed

+1 :green_heart:
spotbugs
9m  2s

the patch passed

+1 :green_heart:
shadedclient
18m 26s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 11s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
225m 39s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m 42s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
unit
16m 27s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 44s

The patch does not generate ASF License warnings.

395m 58s

Reason
Tests

Failed junit tests
hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/8/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux 58188c9b6b03 4.15.0-126-generic #129-Ubuntu SMP Mon Nov 23 18:53:38 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 4ee943682cebc28bbe37b40d29cced08eb7fd968

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~18.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/8/testReport/

Max. process+thread count
2110 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/8/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  5s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
14m 37s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 18s

branch-3.3 passed

+1 :green_heart:
compile
3m 48s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  2s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 22s

branch-3.3 passed

+1 :green_heart:
javadoc
3m 11s

branch-3.3 passed

+1 :green_heart:
spotbugs
7m 38s

branch-3.3 passed

+1 :green_heart:
shadedclient
18m  6s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
3m 42s

the patch passed

+1 :green_heart:
javac
3m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 618 unchanged - 6 fixed = 627 total (was 624)

+1 :green_heart:
mvnsite
2m 58s

the patch passed

+1 :green_heart:
javadoc
2m 49s

the patch passed

+1 :green_heart:
spotbugs
7m 58s

the patch passed

+1 :green_heart:
shadedclient
17m 52s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  9s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
222m 15s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m 58s

hadoop-hdfs-httpfs in the patch passed.

-1 :x:
unit
17m 14s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

365m 48s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.datanode.TestDirectoryScanner

hadoop.hdfs.TestFileCreation

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.server.federation.router.TestRouterClientRejectOverload

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/9/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux 600c3befd35a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / d91c0608a3d16c83381a3cbe4560ed971c1f5657

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/9/testReport/

Max. process+thread count
2018 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/9/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  1s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m  0s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  7s

branch-3.3 passed

+1 :green_heart:
compile
4m 10s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  6s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 46s

branch-3.3 passed

+1 :green_heart:
javadoc
3m 57s

branch-3.3 passed

+1 :green_heart:
spotbugs
8m 43s

branch-3.3 passed

+1 :green_heart:
shadedclient
21m  2s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 33s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
3m 48s

the patch passed

+1 :green_heart:
compile
5m  6s

the patch passed

+1 :green_heart:
javac
5m  6s

the patch passed

+1 :green_heart:
blanks
0m  1s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 10s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 618 unchanged - 6 fixed = 627 total (was 624)

+1 :green_heart:
mvnsite
4m  3s

the patch passed

+1 :green_heart:
javadoc
3m 42s

the patch passed

+1 :green_heart:
spotbugs
11m 29s

the patch passed

+1 :green_heart:
shadedclient
24m 28s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 24s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
249m 40s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m  7s

hadoop-hdfs-httpfs in the patch passed.

-1 :x:
unit
15m  8s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 39s

The patch does not generate ASF License warnings.

411m 30s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.TestReencryption

hadoop.hdfs.server.namenode.TestFSEditLogLoader

hadoop.hdfs.server.datanode.TestNNHandlesCombinedBlockReport

hadoop.hdfs.server.namenode.TestNamenodeStorageDirectives

hadoop.hdfs.server.namenode.TestNameEditsConfigs

hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting

hadoop.hdfs.server.namenode.TestNetworkTopologyServlet

hadoop.hdfs.server.namenode.sps.TestStoragePolicySatisfierWithStripedFile

hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier

hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes

hadoop.hdfs.server.namenode.TestQuotaWithStripedBlocksWithRandomECPolicy

hadoop.cli.TestHDFSCLI

hadoop.hdfs.server.namenode.TestStoragePolicySatisfierWithHA

hadoop.hdfs.server.namenode.TestNamenodeCapacityReport

hadoop.hdfs.server.datanode.TestBatchIbr

hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy

hadoop.hdfs.server.namenode.TestEditLog

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.server.federation.router.TestRouterRpc

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/10/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux b58e36564c3a 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / 2813de2c8d0eb0bb1daefd584d2a6ddc2c69d392

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/10/testReport/

Max. process+thread count
2121 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/10/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 59s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
13m  4s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 18s

branch-3.3 passed

+1 :green_heart:
compile
3m 42s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  1s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 21s

branch-3.3 passed

+1 :green_heart:
javadoc
3m  7s

branch-3.3 passed

+1 :green_heart:
spotbugs
7m 35s

branch-3.3 passed

+1 :green_heart:
shadedclient
18m  7s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 54s

the patch passed

+1 :green_heart:
compile
3m 42s

the patch passed

+1 :green_heart:
javac
3m 42s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 708 unchanged - 7 fixed = 717 total (was 715)

+1 :green_heart:
mvnsite
3m  1s

the patch passed

+1 :green_heart:
javadoc
2m 48s

the patch passed

+1 :green_heart:
spotbugs
8m  3s

the patch passed

+1 :green_heart:
shadedclient
18m  6s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m  8s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
210m 26s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m  8s

hadoop-hdfs-httpfs in the patch passed.

+1 :green_heart:
unit
15m 10s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 38s

The patch does not generate ASF License warnings.

349m 24s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.server.datanode.TestBPOfferService

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.TestMissingBlocksAlert

hadoop.hdfs.TestGetFileChecksum

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/11/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux dfda96856634 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / c373f73d7f18c58ed3b7028c14ce141b17b1d127

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/11/testReport/

Max. process+thread count
2196 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/11/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m  1s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+0 :ok:
jshint
0m  0s

jshint was not available.

+0 :ok:
markdownlint
0m  0s

markdownlint was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ branch-3.3 Compile Tests _

+0 :ok:
mvndep
15m 25s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m 25s

branch-3.3 passed

+1 :green_heart:
compile
3m 45s

branch-3.3 passed

+1 :green_heart:
checkstyle
1m  0s

branch-3.3 passed

+1 :green_heart:
mvnsite
3m 20s

branch-3.3 passed

+1 :green_heart:
javadoc
3m 12s

branch-3.3 passed

+1 :green_heart:
spotbugs
7m 29s

branch-3.3 passed

+1 :green_heart:
shadedclient
18m 24s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 22s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 53s

the patch passed

+1 :green_heart:
compile
3m 37s

the patch passed

+1 :green_heart:
javac
3m 37s

the patch passed

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
0m 56s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 9 new + 709 unchanged - 6 fixed = 718 total (was 715)

+1 :green_heart:
mvnsite
2m 57s

the patch passed

+1 :green_heart:
javadoc
2m 49s

the patch passed

+1 :green_heart:
spotbugs
7m 57s

the patch passed

+1 :green_heart:
shadedclient
18m 12s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 18s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
210m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
5m  8s

hadoop-hdfs-httpfs in the patch passed.

-1 :x:
unit
15m  2s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 37s

The patch does not generate ASF License warnings.

351m 55s

Reason
Tests

Failed junit tests
hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys

hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer

hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy

hadoop.hdfs.TestReconstructStripedFileWithValidator

hadoop.hdfs.server.federation.router.TestRouterRpc

hadoop.hdfs.server.federation.router.TestRouterRpcMultiDestination

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/13/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/2925

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell jshint markdownlint

uname
Linux cdaccb33b3af 4.15.0-136-generic #140-Ubuntu SMP Thu Jan 28 05:20:47 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
branch-3.3 / edde535ab66e6141e712da09f53773bcf9e97cf2

Default Java
Private Build-1.8.0_282-8u282-b08-0ubuntu1~18.04-b08

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/13/testReport/

Max. process+thread count
2118 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2925/13/console

versions
git=2.17.1 maven=3.6.0 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@jojochuang FYI, this is branch-3.3 backport PR (cleanly applied from trunk)


CLI: Migrate from urfave/cli to spf13/cobra to resolve misc. known issues

The current library used to build the CLI has a few known issues:
Bad overflow handling (returns a 0 instead of an error) - https://github.com/lightningnetwork/lnd/pull/7350#discussion_r1087542359
Hard to prevent bool flags being misused, which causes assets to be minted with incorrect parameters, e.x. - https://github.com/lightninglabs/taro/issues/228
v2 of urfave/cli has the same issues as v1, which we currently use. https://cobra.dev/ is at least as well-supported / maintained, properly propogates numerical parsing errors, and has more features for validating input strings.

Initial work here:
https://github.com/lightninglabs/taproot-assets/tree/cobra_cli
Most of the flags can be partially ported to the cobra format with refactoring tools. I tried to follow the structure used in chantools, where we wrap commands with per-parent-command variables that store parsed flags and other local state.
There is a small 'hack' with the usage template to match the existing behavior by hiding global options from subcommand help output.
The primary useful feature IMO is the cobra.Command.Args setting, which we can use to reject any arguments, or any arguments not paired with a flag. We can also mark flags as required easily instead of writing those checks manually.
We can also separate flag validation into cobra.Command.PreRunE from the actual RPC call in cobra.Command.RunE, which may make new commands easier to read/review.
The diff leaves existing urfave code in place since its WIP.

Would also be good to remove this chain param from the profiles, which is a vestigial param from LND support for Litecoin:
https://github.com/lightninglabs/taproot-assets/blob/main/cmd/tapcli/profile.go#L30


⚠ Bofrost.de has degraded performance

In 19ec61d, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1359 ms

Resolved: Bofrost.de performance has improved in 60713c8 after 3 hours, 45 minutes.


Integrate devon4j migration support

We have created migration support in devcon:
https://github.com/devonfw/devcon/issues/135
This feature shall be integrated in devon-ide. IMHO devcon is to be considered dead on the long run. I would expect devon-ide to be the new solution as a CLI tool. For advanced UX plans are already discussed to create a new devon-dashboard. This could be part of devon-ide or could be a separate add-on. This dashboard could inform about notifications and could also offer all CLI use-cases of devon-ide in a graphical user-interface.
For the integration of the code migration we should discuss the design:

shall this code simply get integrated into our configurator?
or shall we create a separate tool (as JAR) for that to keep the configurator isolated?

I currently tend for the isolation.

We also need to integrate a new migration from devon4j:3.0.0. Maybe we even need to release a devon4j:3.0.1 bugfix with latest spring boot 2.0.x and 3.1.0 with latest 2.1.x.

Feature is implemented.
PR #108 still open. However the feature is considered as done, hence closing this issue.


RecordRTC-to-PHP - Audio+video didn't work

Hi,
I am trying RecordRTC-to-PHP. I added Audio+Video into code. I recorded with Audio+Video, it doesn't work. What i need to modify to record Audio+Video?
Thanks & kindregards,
Bien

Hi, i am having a similar problem...2 years later...lol

I am having the same problem.
Can't find a solution online.


Forgot to log to console

In Introduction to JavaScript; Variables; 4. Undefined, you forgot to log the first variable you defined, as CodeCademy said to do. It still will allow you to move on to the next one though, but the code should be fixed. I'll give you the correct code.
let notDefined;
console.log(notDefined);
let valueless;
console.log(valueless);

@alexp9982 Good job spotting this. Can you please make a PR for this? 👍

Sorry, I’m kinda new to github and I don’t know what a PR is, sorry.
On Thu, Nov 30, 2017 at 2:55 PM Edvins Antonovs<EMAIL_ADDRESS>wrote:

@alexp9982 https://github.com/alexp9982 Good job spotting this. Can you
please make a PR for this? 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ummahusla/Codecademy-Exercise-Answers/issues/119#issuecomment-348302105,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMh0Hl-l6_UoX2YaL5KSsLlKPyALG-opks5s7whDgaJpZM4Qvebf
.

@alexp9982 This is a very good place to start. Here are a couple of good resources to start with:

https://www.digitalocean.com/community/tutorials/how-to-create-a-pull-request-on-github
https://help.github.com/articles/creating-a-pull-request/

Extremely busy recently, will do pretty soon, along with a bunch of changes/corrections to Javascript

@alexp9982 Great 👍

For some reason, there's a problem with the unit 12 in python in lesson 02
The devil in the details
I can't copy the file, probably because there's a colon in the name of the
file, I highly recommend fixing this
Rename the 6-PSA: Buffering Data.py and remove the colon so I can clone the
repository.
On Mon, Dec 11, 2017 at 4:20 AM, Edvins Antonovs<EMAIL_ADDRESS>wrote:

@alexp9982 https://github.com/alexp9982 Great 👍
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/ummahusla/Codecademy-Exercise-Answers/issues/119#issuecomment-350666466,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMh0HkIBbs-bVLpHZhkZrBvrJJA5oAFIks5s_PP3gaJpZM4Qvebf
.

I need you to accept my pull request.

@alexp9982 Done, thank you very much 💯


Update gem bundler and Podfile

I encountered issues with yarn and pod install this morning, updated from bundler 1.17.2 to 2.6.1, and committed the change.
This is for review, maybe we have to align our pod, ruby and bundler versions. Here are mine:
ruby --version
ruby 3.3.3 (2024-06-12 revision f1c7b6f435) [arm64-darwin23]

bundler --version
Bundler version 2.6.1

pod --version
1.16.2

@alexrisch any reason to wait on merging this?
I've run into the same problems and followed the same path here: https://github.com/ephemeraHQ/converse-app/pull/1400/files

Merged!

🍻 Thanks @lourou


disable_with doesn't work with link in Safari

link_to "do it", :data => {:disable_with => 'Please wait...'}
Please note that this is not a remote link.
It works as expected in latest Chrome and latest Firefox, IE8, IE9.
In Safari (6.0.2) however it never shows "Please wait..."

<button class="btn btn-default" data-disable-with=" Saving..." name="button" type="submit">Save Post</button>
On OSX 10.9.5 Build 13F34:
Safari Version 7.1.2 (95<IP_ADDRESS>) :broken_heart:
Chrome Version 39.0.2171.95 (64-bit) :heart:
If you press Submit and then hit the :back: button in Safari, the button now appears the way it would if disable-with worked (it's disabled and has the disable-with html)!
I tried removing turbolinks but that made no difference :/

Also having this issue.
OS X 10.10.2
Safari 8.0.3
Anyone got a decent workaround?

I have the same issue. data-disable-with works find in Chrome, but not in Safari.
OS X 10.10.2 (14C109)
Safari 8.0.3 (10600.3.18)
It's really frustrating, since I prefer to develop locally using Safari.

any idea how to fix this in Safari.

This is simply a display problem in Safari. If you try clicking the submit button twice it doesn't submit twice. To verify this, inspect the element and then click the submit button, you'll see the HTML change (value is replaced and disabled attribute is added).
Safari doesn't update the displayed page after the form submit is fired (even though the DOM changed). If we wanted to fix this visual bug we'd need to intercept the submit event, update the DOM, then submit the form ourself (carefully though as we don't want to double submit). See http://stackoverflow.com/a/28404683/282720
I think the main desire of this feature is to prevent double form submission and that is working correctly. Perhaps this should be closed in favor of a radar bug submitted to Apple.

Using Safari 8.0.4 (106<IP_ADDRESS>) still doesn't work (in some cases). I tried the test pages from this thread and also created one myself, disable works in all those cases but still doesn't on my real form.
I removed all other javascript from my app and just left jquery and ujs files, but no luck. Then I went and debugged a little bit and if I remove the timeout from this line it works perfectly.
It seems like a UI blocking issue to me, once the timeout has returned the form is already submitting and safari doesn't care anymore to update it. But if we update it just before it submits, it does it correctly.
Not sure what the timeout is for though? Comments say it's for the button to be serialized, but why do we need the button serialized? (Some may need it of course, but most forms don't). Would it be possible to add a setting for letting the timeout or remove it?

I have a similar issue on Safari with a submit_tag with an :onclick to show an overlay. It doesn't work either, which seems to confirm the display problem mentioned by @ericboehs

By the way - and that's even worse usability-wise  - when you hit the back button the overlay is there... IMHO this issue should be closed since it doesn't seem to be jquery-ujs specific

I had a similar issue on Safari 8.0.6 and here's my approach of solving this issue:
%button{ class: 'btn btn-action js-submit', data: { method: :put, 'href' => '...', disable_with: "".html_safe }} Submit

$('.js-select-plan').click(function(event) {
  event.preventDefault();
  var $target     = $(this),
      href        = $target.data('href'),
      method      = $target.data('method'),
      formTarget  = $target.attr('target'),
      csrfToken   = $('meta[name=csrf-token]').attr('content'),
      csrfParam   = $('meta[name=csrf-param]').attr('content'),
      form        = $('<form method="post" action="' + href + '"></form>'),
      metaData    = '<input name="_method" value="' + method + '" type="hidden" />';

  if (csrfParam !== undefined && csrfToken !== undefined) {
    metaData += '<input name="' + csrfParam + '" value="' + csrfToken + '" type="hidden" />';
  }

  if (formTarget) {
    form.attr('target', formTarget);
  }

  // disable button/link element
  var contentMethod = $target.is('button') ? 'html' : 'val';
  var replacement   = $target.data('disable-with');
  $target.data('ujs:enable-with', $target[contentMethod]());
  if (replacement !== undefined) {
    $target[contentMethod](replacement);
  }
  $target.prop('disabled', true);

  form.hide().append(metaData).appendTo('body');
  setTimeout(function(){
    form.submit();
  }, 50);
});

This works like a charm in all browsers. For better flexibility you might want to wrap this in a helper.

Still doesn't work in Safari 9.0 (El Capitan). Firefox + Chrome are OK.

Yes. It isn't working with safari in ipad or iphone. :(

Try this, it seems to be working here: https://gist.github.com/walterdavis/b6410bef6333d3487687#file-rails-js-L262

+1 does not work in Safari 8.0.8

We can hide the button and display same as link with disable with text in button style..just an idea

This looks like a Safari bug/feature, the only way to make it work is to delay the form submission (Like prevent the first form submit and trigger a submit event later on, this will give the render engine a little bit of time to catchup with the disabled-text.
For example, in https://github.com/rails/jquery-ujs/blob/1d8a0adba131ca74188cdd22f7174ac92f372094/src/rails.js#L493-L494
if (!e.isTrigger) {
  e.preventDefault();
  rails.disableFormElements(form);
  setTimeout(function(){ form.trigger('submit'); }, 13);
}

But I'm not 100% positive if jquery-ujs should handle this. I right now have it as a workaround that I load after jquery-ujs https://gist.github.com/orlando/bacff31757b80b86e062

Thanks @orlando! It worked but only for click on the button. If I submit, it's not work!

+1 Does not work in Safari 10 (tested with f.submit  "title", data: { disable_with: "disabled text" })

+1 only works for forms with remote: true. Does not work in examples above nor in iOS simulator

@jpowell this is not a jquery-ujs bug since this works for the rest of the browser, is how Safari handles forms submissions. In my case I needed to support Safari so I added a workaround but is not like a final fix (since Safari doesn't even flush pending paints after the submit button is pressed and that's why you see the magic number 13 there).

@orlando thanks for the response. I've done similar things before in the past, but was shooting in the dark to see if a wider solution had been come to without monkey patching something together myself.
Thanks again.


Fix internal logic

Sometimes it gets confused

fixed on pulled #11, the commit message has a typo


Issue #3: Add capability to read consumption data form the API

I added a method get_consumption_data() to pyfingrid.py
This makes an API query to https://oma.datahub.fi/_api/GetConsumptionData. I have no idea what the productType argument is in the URL, this is what I had. Do you have the same productType or do we need to make this an argument instead of a hard coded value?

I added two helper methods for preparing the start and end periods. It's arguable if these belong to the pyfingrid.py or the script that calls pyfingrid.py but they are here for the time being. Rationale being that we do the timezone offset handling properly so that the users do not have to. This adds a dependency to pytz.

I'm also including an example implementation, datahub-consumption.py, which reads a previously captured session from a textfile, prints the consumption and logs what's going on.

Logfile, sessionfile and metering point number are defined in constant.py.

Cheers,
Markus

I added the get_consumption_data-function to pyfingrid but as you mentioned the correct place for preparing start and end time is a calling script.


Fixed issue for T5 base model quantization issue with IPEX smoothquant

Type of Change
bug fix
No API changed
Description
Fixed quantization failure when T5 base model be quantized with IPEX smoothquant.
Expected Behavior & Potential Risk
Quantize successfully
How has this PR been tested?
Local tested

https://inteltf-jenk.sh.intel.com/view/ITREX-release/job/ITREX-1.3-release-test/35/

https://inteltf-jenk.sh.intel.com/view/ITREX-release/job/ITREX-1.3-release-test/37

@PenghuiCheng  please check!
Traceback (most recent call last):
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/quantization.py", line 234, in fit
strategy.traverse()
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/strategy/auto.py", line 140, in traverse
super().traverse()
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/strategy/strategy.py", line 482, in traverse
self._setup_pre_tuning_algo_scheduler()
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/strategy/strategy.py", line 360, in _setup_pre_tuning_algo_scheduler
self.model = self._pre_tuning_algo_scheduler("pre_quantization")
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/algorithm/algorithm.py", line 127, in call
self._q_model = algo(self._origin_model, self._q_model, self._adaptor, self._dataloader, self._calib_iter)
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/algorithm/smooth_quant.py", line 89, in call
q_model = adaptor.smooth_quant(
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/adaptor/pytorch.py", line 1796, in smooth_quant
model._model = self.sq.transform(
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/adaptor/torch_utils/smooth_quant.py", line 1286, in transform
out_pre_sq = model_forward_per_sample(self.model, example_inputs, self.device)
File "/home/sdp/miniconda3/envs/pt-ipex-2.1.0+cpu-3.10-spr/lib/python3.10/site-packages/neural_compressor/adaptor/torch_utils/smooth_quant.py", line 110, in model_forward_per_sample
output = forward_wrapper(model, sample[0], device)
KeyError: 0

https://inteltf-jenk.sh.intel.com/view/ITREX-release/job/ITREX-1.3-release-test/40/

https://inteltf-jenk.sh.intel.com/view/ITREX-release/job/ITREX-1.3-release-test/50/

https://inteltf-jenk.sh.intel.com/view/ITREX-release/job/ITREX-1.3-release-test/51/

https://inteltf-jenk.sh.intel.com/job/nlp_toolkit_optimize_validation_localtest/3482/

https://inteltf-jenk.sh.intel.com/job/nlp_toolkit_optimize_validation_localtest/3500/

https://inteltf-jenk.sh.intel.com/job/nlp_toolkit_optimize_validation_localtest/3500/

@PenghuiCheng please check the error, your json format is not correct

https://inteltf-jenk.sh.intel.com/job/nlp_toolkit_optimize_validation_localtest/3547/

https://inteltf-jenk.sh.intel.com/job/nlp_toolkit_optimize_validation_localtest/3556/

https://inteltf-jenk.sh.intel.com/job/nlp_toolkit_optimize_validation_localtest/3557/

@PenghuiCheng Tuning and benchmark are ok, but acc can not run. Please fix in next PR.


query/cpu/time is much higher than query/time in historical

Is this normal?

Have you got units configured correctly? Cpu/time is nanoseconds while
query/time is millisecond
On Sun, 14 Oct 2018, 9:03 am QiuMM<EMAIL_ADDRESS>wrote:

[image: lark20181014-160152]
https://user-images.githubusercontent.com/15156517/46914044-98480400-cfca-11e8-8c48-e891c608ee00.png
Is this normal?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/apache/incubator-druid/issues/6465, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AC9pB3WdcS5fwupAXRwsprzd6H8eTNssks5uku_bgaJpZM4XbA0k
.

Yes, of course. And in fact, query/time is millisecond while query/cpu/time is microsecond.

Possibly because query/cpu/time is cumulative of multiple cores and multiple segments for same query do get processed in parallel on multiple cores.

@himanshug after look into the code, I think you are right, thanks.


Add New Pages

I would like to add more Avengers to the website

Please assign this to me @aslams2020


setdownloadtaskdidfinishdownloadingblock call after device reboot

After device reboot , when download finished ,app delegate's handleEventsForBackgroundURLSession triggered but not setdownloadtaskdidfinishdownloadingblock.If i try to re-associate session by initializing AFHttpSessionManager again with same identifier iam getting statuscode=206 in setdownloadtaskdidfinishdownloadingblock. Solution?

From our Contribution Guidelines

Asking Questions
We don't use GitHub as a support forum. For any usage questions that are not specific to the project itself, please ask on Stack Overflow instead. By doing so, you'll be more likely to quickly solve your problem, and you'll allow anyone else with the same question to find the answer. This also allows maintainers to focus on improving the project for others.


Column size not rendering properly for hidden tabs.

Column presents in the active tabs renders properly. The second tab which columns are hidden by default does not render properly.
For ex;

col-md-4  in first tab takes 430px by default
col-md-4 in second tab takes 100px or below by default

We'll need a JS Bin that demonstrate the problem in order to be able to help you.
Please also state the OS, browser, and viewport width that you are using.

Thanks for your response.
OS  : Windows 8.1
Browser  : Chrome
viewport width : 1366px
application : pentaho cde 5.3

And the JS Bin example please?

http://jsbin.com/wonesiruwu/1/

Hi @berkinthomas!
You appear to have posted a live example (http://jsbin.com/wonesiruwu/1/edit), which is always a good first step. However, according to the HTML5 validator, your example has some validation errors, which might potentially be causing your issue:

line 19, column 100: Element link is missing required attribute property.
line 22, column 106: Element link is missing required attribute property.

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

After moving the <link>s into the <head> where they belong: http://jsbin.com/fibufo/1/edit

Hi @cvrebert!
You appear to have posted a live example (http://jsbin.com/fibufo/1/edit), which is always a good first step. However, according to Bootlint, your example has some Bootstrap usage errors, which might potentially be causing your issue:

line 32, column 7: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
line 35, column 9: E014: Columns (.col-*-*) can only be children of .rows or .form-groups
W002: <head> is missing X-UA-Compatible <meta> tag that disables old IE compatibility modes
W003: <head> is missing viewport <meta> tag that enables responsiveness

You'll need to fix these errors and post a revised example before we can proceed further.
Thanks!
(Please note that this is a fully automated comment.)

sorry, i did not understand what you are saying...

please read the alert box, where the width of each div shown.

A. You're not using columns correctly; see https://github.com/twbs/bootlint/wiki/E014
B. Why do you care about the width of a hidden element in the first place? Its width is correct when it's shown, yes?

B.  then, is it possible to refresh this tab while I am clicking,

Define "refresh". There are events you can listen for and then reinitialize some third-party widget in the tab in your event handler, if that's what you mean. See http://getbootstrap.com/javascript/#tabs-events

Thanks. It's working fine..


Clarify if all historical commits are scanned by the Secret Scanner

I often get asked if the Secret Scanning scans all (potentially multiple years) of historical commits, or just the tip version. Let's clarify this in the docs.
Thanks,
--Neno

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: 31d2c1ae-7edd-18e3-c357-623acef69af8
Version Independent ID: 31d2c1ae-7edd-18e3-c357-623acef69af8
Content: Secret Scanning for GitHub Advanced Security for Azure DevOps - Azure Repos
Content Source: docs/repos/security/github-advanced-security-secret-scanning.md
Service: azure-devops
Sub-service: azure-devops-integration
GitHub Login: @laurajjiang
Microsoft Alias: laurajiang

Hi @NenoLoje - this is mentioned in the introductory block of the documentation:

Secret scanning for your repository scans for any secrets that may already exist in your source code across history and push protection prevents any new secrets from being exposed in source code.

If you have a recommendation on we can make this more clear, feel free to re-open the issue and provide a suggestion. Thanks!

@laurajjiang Well, I don't know the answer to the question - so I'm not sure I can rephrase it without knowing it for sure. Can we first clarify how the product behavior is designed?

Also, please reopen this issue, as it's not yet resolved.

Yes, apologies - secret scanning will scan across all commits and branches, not just the tip version.


feat: added YAML unmarshaller

Added support for yaml.Unmarshaler.

thank you @shanduur , I will be reviewing this one soon!


Update tvm-software-inventory.md

I've worked with customers who are expecting a full SCCM-style Software Inventory of all clients because of the sentence "The software inventory in threat and vulnerability management is a list of all the software in your organization".  Edit adds on "with known vulnerabilities" to reflect the true scope of this inventory.

This does make it clearer, thank you!


Minor incompatibility with alex's caves

When Elementus is installed, the galena gauntlet doesn't work, as in the right click functionality just doesn't seem to trigger.

I've noticed this bug with a few other mods, so it might be a problem on ACs end.

It's a tag issue, if an item listed in the tag isn't registered (eg. Mod not installed so the item doesn't exist) the tag will unload causing this issue.

@Altay5704 just released a new version, is the issue fixed on your end?

Yes, the galena gauntlet is working fine now. Thanks for the fix!


Add optional expected result as third value for crossJMESPathsMatch verb

When using crossJMESPathsMatch verb is very common the scenary when we need to compare two values of two files but this two values shouldn't be the same, so we use a function to test some equality. The problem is that the logic has no way to access the value of the other file that has been evaluated before.
It seems reasonable to add a third optional expected value in rows. If this value is defined, the result of applying the first expression will be compared with that instead between the two expression results.

Nope, this does not have sense


MM-11449 Show OpenGraph previews for pages with any of the required fields

mattermost-redux will no longer save the OpenGraph data if it isn't valid, so we don't need to check it in the render function
Required redux changes: https://github.com/mattermost/mattermost-redux/pull/619
Ticket Link
https://mattermost.atlassian.net/browse/MM-11449

@hmhealey can you update redux hash for changes so we can go ahead and merge both mobile and web PR's?


CrashLoopBackOff occurs when activate control plane by using Helm chart

What happened:
To start the pipecd-server and the pipecd-ops container, pipecd-minio
and pipecd-mysql container needs to be running.
But the current Helm chart does not check this, so if pipecd-server or pipecd-ops is run first, CrashLoopBackOff will occur.
$ kubectl get po
NAME                              READY   STATUS             RESTARTS      AGE
pipecd-cache-6cc858bc44-pcvvp     1/1     Running            0             20s
pipecd-gateway-85658b4584-4k5ks   1/1     Running            0             20s
pipecd-minio-7dd5b8b987-tqb76     1/1     Running            0             20s
pipecd-mysql-84cbf4b587-qm76j     1/1     Running            0             20s
pipecd-ops-8587ff6bf4-4ltkc       0/1     CrashLoopBackOff   1 (18s ago)   20s
pipecd-server-87fcc94c-jv5hk      0/1     CrashLoopBackOff   1 (19s ago)   20s

pipecd-server log is as follows.
$ kubectl logs pipecd-server-67dcf95d8c-t7fg2
successfully loaded control-plane configuration
failed to create filestore      {"error": "failed to ensure bucket: failed to check if bucket exists: Get \"http://pipecd-minio:9000/quickstart/?location=\": dial tcp <REMOVED>:9000: connect: connection refused"}

pipecd-oops log is as follows.
$ kubectl logs pipecd-server-67dcf95d8c-t7fg2
$ kubectl logs pipecd-ops-d56fb5466-ssqfh
failed to create filestore      {"error": "failed to ensure bucket: failed to check if bucket exists: Get \"http://pipecd-minio:9000/quickstart/?location=\": dial tcp <REMOVED>:9000: connect: connection refused"}

What you expected to happen:
Start pipecd-minio and pipecd-mysql before pipecd-server and pipecd-server so that CrashLoopBackOff won't occur.
How to reproduce it:
Run make run/pipecd command on latest master branch.
Environment:

piped version: N/A
control-plane version: v0.31.0
Others:

This may be solved by adding initContainer that check mysql and minio status.
$ kubectl get po --watch

pipecd-ops-76bbd94579-qpgrb     0/1     Pending       0          0s
pipecd-mysql-84cbf4b587-q6b55   0/1     Pending       0          0s
pipecd-gateway-85658b4584-kgfpd   0/1     Pending       0          0s
pipecd-cache-6cc858bc44-tjht7     0/1     Pending       0          0s
pipecd-server-d5dbc67cb-6pvx7     0/1     Pending       0          0s
pipecd-ops-76bbd94579-qpgrb       0/1     Pending       0          0s
pipecd-mysql-84cbf4b587-q6b55     0/1     Pending       0          0s
pipecd-gateway-85658b4584-kgfpd   0/1     Pending       0          0s
pipecd-cache-6cc858bc44-tjht7     0/1     Pending       0          0s
pipecd-server-d5dbc67cb-6pvx7     0/1     Pending       0          0s
pipecd-minio-7dd5b8b987-jwsfd     0/1     Pending       0          0s
pipecd-minio-7dd5b8b987-jwsfd     0/1     Pending       0          0s
pipecd-ops-76bbd94579-qpgrb       0/1     Init:0/2      0          0s
pipecd-mysql-84cbf4b587-q6b55     0/1     ContainerCreating   0          0s
pipecd-gateway-85658b4584-kgfpd   0/1     ContainerCreating   0          0s
pipecd-cache-6cc858bc44-tjht7     0/1     ContainerCreating   0          0s
pipecd-server-d5dbc67cb-6pvx7     0/1     Init:0/2            0          1s
pipecd-minio-7dd5b8b987-jwsfd     0/1     ContainerCreating   0          2s
pipecd-minio-7dd5b8b987-jwsfd     1/1     Running             0          2s
pipecd-cache-6cc858bc44-tjht7     1/1     Running             0          3s
pipecd-ops-76bbd94579-qpgrb       0/1     Init:0/2            0          3s
pipecd-mysql-84cbf4b587-q6b55     1/1     Running             0          3s
pipecd-gateway-85658b4584-kgfpd   0/1     Running             0          4s
pipecd-server-d5dbc67cb-6pvx7     0/1     Init:1/2            0          4s
pipecd-ops-76bbd94579-qpgrb       0/1     Init:1/2            0          5s
pipecd-server-d5dbc67cb-6pvx7     0/1     Init:1/2            0          8s
pipecd-ops-76bbd94579-qpgrb       0/1     Init:1/2            0          10s
pipecd-server-d5dbc67cb-6pvx7     0/1     PodInitializing     0          12s
pipecd-ops-76bbd94579-qpgrb       0/1     PodInitializing     0          12s
pipecd-ops-76bbd94579-qpgrb       0/1     Running             0          13s
pipecd-ops-76bbd94579-qpgrb       1/1     Running             0          13s
pipecd-server-d5dbc67cb-6pvx7     0/1     Running             0          13s
pipecd-server-d5dbc67cb-6pvx7     1/1     Running             0          13s

$ kubectl get po
NAME                              READY   STATUS    RESTARTS   AGE
pipecd-cache-6cc858bc44-tjht7     1/1     Running   0          61s
pipecd-gateway-85658b4584-kgfpd   1/1     Running   0          61s
pipecd-minio-7dd5b8b987-jwsfd     1/1     Running   0          61s
pipecd-mysql-84cbf4b587-q6b55     1/1     Running   0          61s
pipecd-ops-76bbd94579-qpgrb       1/1     Running   0          61s
pipecd-server-d5dbc67cb-6pvx7     1/1     Running   0          61s

CrashLoopBackOff wasn't occured as shown above.


Feature requests

Hi,
loving it so far. However I would like to add that auto champ select doesn't work for me. At least the AutoAcceptQueue setting always resets. Also the icons/backgrounds are stuck on loading in the chat tab for me.
Great work. I really like it so far. I use it to farm first wins in arams on smurf accounts!
Requests:
Add first win timer for accounts. I have to log in and check manually for each account
option to hide the passwords on main dashboard
Thank

Hi, thanks letting me know about the issues/suggestions

Also the icons/backgrounds are stuck on loading in the chat tab for me.
i have seen this happen few times, not sure what causes it, usually reason has been broken league client and restarting PC has fixed it, another option is to make sure you are logged in to league before opening the tab for the first time and that you are not ingame.

However I would like to add that auto champ select doesn't work for me. At least the AutoAcceptQueue setting always resets.
Do you mean resets between restarts of the program?

option to hide the passwords on main dashboard
will add this once i find motivation to work on this project some more

Add first win timer for accounts. I have to log in and check manually for each account
maybe

yup. between restarts


Information responses (1xx) processing implemented.

@kirill-usov Kirill, could you please briefly describe what you are trying to accomplish with these changes? I think HttpClient 5.0 already supports 1xx message processing through AsyncClientExchangeHandler interface.

Hello.
I need to handle 103 Early Hints response from the server (RFC 8297). But I did not found any way handle it in async client when I am creating default, minimal or build custom one with help HttpAsyncClientBuilder.
It is what I have implemented.

@kirill-usov It most definitely works with minimal HttpAsyncClient
final IOReactorConfig ioReactorConfig = IOReactorConfig.custom()
        .setSoTimeout(Timeout.ofSeconds(5))
        .build();

final MinimalHttpAsyncClient client = HttpAsyncClients.createMinimal(
        HttpVersionPolicy.NEGOTIATE,
        H2Config.DEFAULT,
        H1Config.DEFAULT,
        ioReactorConfig);

client.start();

final URI requestUri = new URI("http://httpbin.org/get");
final HttpHost target = new HttpHost(
        requestUri.getHost(),
        requestUri.getPort() > 0 ? requestUri.getPort() : 80,
        requestUri.getScheme());
final Future<AsyncClientEndpoint> leaseFuture = client.lease(target, null);
final AsyncClientEndpoint endpoint = leaseFuture.get(30, TimeUnit.SECONDS);
try {

    final CountDownLatch latch = new CountDownLatch(1);
    endpoint.execute(new BasicClientExchangeHandler<SimpleHttpResponse>(
                             SimpleRequestProducer.create(SimpleHttpRequest.get(requestUri)),
                             SimpleResponseConsumer.create(),
                             new FutureCallback<SimpleHttpResponse>() {

                                 @Override
                                 public void completed(final SimpleHttpResponse response) {
                                     latch.countDown();
                                     System.out.println(requestUri + "->" + response.getCode());
                                 }

                                 @Override
                                 public void failed(final Exception ex) {
                                     latch.countDown();
                                     System.out.println(requestUri + "->" + ex);
                                 }

                                 @Override
                                 public void cancelled() {
                                     latch.countDown();
                                     System.out.println(requestUri + " cancelled");
                                 }

                             }) {

                         @Override
                         public void consumeInformation(final HttpResponse response) throws HttpException, IOException {
                             System.out.println("infornation response:" + response);
                         }

                     },
            HttpClientContext.create());

    latch.await();
} finally {
    endpoint.releaseAndReuse();
}

System.out.println("Shutting down");
client.shutdown(ShutdownType.GRACEFUL);

What I do not like about your patch is that it introduces another callback interface (HttpClientAsyncExecutionCallback). I believe it would be cleaner to add #informationResponse to the AsyncResponseConsumer interface instead.

Wouldn't adding a method to an existing interface break BC? Are we OK with that or would we/should we introduce a subinterface?

@garydgregory I see no problem with making small profile API changes to 5.0 while we are still in BETA

AsyncResponseConsumer interface is a part of core. I did not want to change core, because it can be a reason of regression on products using it. And I tried to keep all existing interfaces unchanged to avoid regressions.

@kirill-usov HC 5.0 is still BETA. Some API changes are still to be expected. We are still many months away from the API freeze. I suggest that we do the right thing and fix what needs fixing. Please raise a PR for HttpCore and close this one.

@ok2c : Oops, I did not realize we were talking about 5.0, sorry. So yeah, changing the current interface makes sense.


Update tesseroid variable density publication

Remove the inreview flag
Add the PDF manuscript (the one under eartharxiv tag on repo)

Fixed by #89


TW edits to replace files

Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

/do-e2e-tests

/do-e2e-tests


Git web site publishing to be done via .asf.yaml

Git web site publishing to be done via .asf.yaml
-- need to deploy the website via .asf.yaml, otherwise there is a risk of web site going stale.

resolved by https://github.com/apache/singa-site/pull/18


UrlTile sometimes failes to load tiles

Is this a bug report?
Yes
Have you read the Installation Instructions?
Yes, but using Expo.
Environment
Expo SDK v25, running build of react-native-maps v0.19.0
Steps to Reproduce
NB! This bug is sporadic, does not occur on every run of the app. If everything seems fine try again until the tiles don't load.

Scan QR code or run simulator
Zoom all the way out and pan to the right as if your circling the earth on the map
Observe tiles that don't load

Expected Behavior
All tiles for the UrlTile should load.
Actual Behavior
On some runs tiles don't load.
It seems like it is hitting the cache and thinks the tile is present.
Example after my second run:

Reproducible Demo
https://snack.expo.io/SJKHosLKz
I only testet on 2 actual iPhones with the Expo client.
I'm getting the same bug in my standalone build of my app with Expo.

Some more debugging
Here is another screenshot of tiles failing to load.
This time I had Charles Proxy running so I could see the network requests going out.
Failing requests

The response code was 404 Not Found.
I tried hitting the tile manually from the browser and the request seems fine.
Maybe add some retry functionality if the requests fails?

Or at least UrlTile could have an attribute where we could provide a function to be called if the response did not have status code 200 (perhaps there also could be an attribute with success status codes or something?).


Volume leak test affected by side-effect lvs WARNING text

Recently added volume leak test gets false positive result
if a WARNING is reported by lvs command
same volumes before and after the test
Expected
   <map[string][]string | len:3>: {
      "LVM Volumes on Node 1": [""],
      "LVM Volumes on Node 2": [""],
      "LVM Volumes on Node 3": [""],
  }
to equal
   <map[string][]string | len:3>: {
       "LVM Volumes on Node 1": [""],
       "LVM Volumes on Node 2": [""],
       "LVM Volumes on Node 3": [
           "WARNING: Failed to connect to lvmetad. Falling back to device scanning.",
       ],
   }

--quiet option to lvs is documented to "Suppress output and log messages."
It is however not so sure it suppresses that warning.
I recall from some earlier cases about parsing LV commands output that error messages were not silenced by --quiet.
More strong method is to filter all lines containing "WARNING:"

Thanks @avalluri for pointing out method to leave out lvmetad: (copied from comment under #461)
We need to disable lvmetad checking on VM hosts as we did in our docker images:
RUN echo "global { use_lvmetad = 0 }" >> /etc/lvm/lvm.conf && \
    echo "activation { udev_sync = 0 udev_rules = 0 }" >> /etc/lvm/lvm.conf

I tried this method but it's not working universally. On a Ubuntu-based VM, when these lines are added to end of (already existing and quite long) /etc/lvm/lvm.conf,
then the values will conflict with existing values and result will be:
root@pmem-csi-ubuntu-govm-worker2:~# lvs
WARNING: Ignoring duplicate config value: use_lvmetad
WARNING: Ignoring duplicate config value: udev_sync
WARNING: Ignoring duplicate config value: udev_rules

When I add those lines at the end of
/etc/lvm/lvmlocal.conf instead (which is short file are meant to override existing values)
then there is no error.
Does it make sense to use lvmlocal.conf always?

Olev Kartau<EMAIL_ADDRESS>writes:

When I add those lines at the end of
/etc/lvm/lvmlocal.conf instead (which is short file are meant to override existing values)
then there is no error.
Does it make sense to use lvmlocal.conf always?

Yes, but only if that also works on Fedora and Clear.

interesting: after I create Clear-based test cluster using make start and fixed clear version 31070,
(BTW should I switch to newer Clear version already? 31070 was "good known to work" some times back) I see no lvmetad running and all lv-commands produce
WARNING: Failed to connect to lvmetad. Falling back to device scanning.
That may mean all lvs commands have such output in CI and it gets compared and matches, so the end result is what we wanted, with an extra line compared (that seems escaped the testing).
Anyway, regardless of what we decide about running or blocking lvmetad, I propose:
Let's switch to exec.Output instead of exec.CombinedOutput:
That warning text is written to stderr, and we are only interested in stdout, and we dont plan
to parse whatever may be reported in stderr.
It is good enough for this test that cmd completed without error, and we can ignore the warnings in stderr
(which we would want to silence with -q option but the  option does not affect that warning).

Olev Kartau<EMAIL_ADDRESS>writes:

interesting: after I create Clear-based test cluster using make start and fixed clear version 31070,
(BTW should I switch to newer Clear version already? 31070 was "good
known to work" some times back)

Yes, we should update that more aggressively.

Anyway, regardless of what we decide about running or blocking lvmetad, I propose:
Let's switch to exec.Output instead of exec.CombinedOutput:

Sounds like the right solution.


Improve the robustness of the timing-sensitive tests on Windows

The Windows pipelines have been behaving badly lately; this is an attempt to improve them.

coverage: 94.808% (+0.05%) from 94.754%
when pulling e9940861520d576b5a58a80376e0f681bc819aec on ci
into d02f84e3d1f77ee32c8e5a7d27cfa5d73851a4c0 on master.


pointing to the Application proxy page

Added a link so that users can directly get more information about the application proxy and how the application proxy works.
Problem: https://github.com/MicrosoftDocs/windows-itpro-docs/issues/8988

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

@JohanFreelancer9 - kindly do the copy editor review for this PR. Thanks.

#sign-off

#sign-off


Seperate module for context

moved and renamed all context related files to seperate folder

Thanks, everything looks good to me! :D


Interactive Message Callbacks within Conversations Do Not Work [Slack]

In the Slack Readme, you provide an example:
https://github.com/howdyai/botkit/blob/master/readme-slack.md#using-interactive-messages-in-conversations
While I'm able to successfully have conversations and also able to do normal interactive messages with callbacks, the combination of the two does not work as advertised in this section of the readme.
It seems that when the interactive_message_callback is triggered, we lose any convo context.
Please advise.

Are you referring to not having convo context within the 'interactive_message_callback' event listener? Or within the conversation handling the button's value?
Two events are fired if you have interactive_replies: true set, first for interactive_message_callback which is fired with the payload object received from slack, and a message_received that contains the value of the button as the text field of a message.
When using the latter to respond to a convo.ask() with interactive buttons, the button's value is routed into your conversation handlers as a message and contains the whole convo object.

@jonchurch When I use the following handler:
controller.on('message_received', function(bot, message) {
  jsome(message);
});

I see the events coming in, however, messages are coming in as:
{
  type: "desktop_notification",
  title: "****",
  subtitle: "#channel",
  msg: "1489546033.243008",
  content: "person: test message",
  channel: "C3XNJEF7G",
  launchUri: "slack://channel?id=C3XNJEF7G&message=1489546033243008&team=T0PNTDD7E",
  avatarImage: "https://avatars.slack-edge.com/2017-01-30/134368081907_99a3295406a75d62a623_192.png",
  ssbFilename: "knock_brush.mp3",
  imageUri: null,
  is_shared: false,
  event_ts: "1489546033.522579"
}

This event never gets picked up if I use controller.hears with message_received.  It would appear there is a configuration issue on my end.  Can you provide any guidance?
Thank you for your help.

This seems potentially related to https://github.com/howdyai/botkit/issues/663

I have never seen desktop_notification! Nor do I think you should be
either. :joy:
Using message_received is not a recommended way to listen to events. Its
just a firehose of message types Slack sends.
If you are using interactive messages in conversations, botkit will
automatically route the users input to the conversation for you.
You can use the interactive_message_callback event to do any sort of
updating the interactive message to make it interactive. Like changing the
state of a button once its been clicked, or updating the parent message
once an action has been completed.
Its easiest to route a button's payload into the conversation as if it were
a message from a user, to drive the conversation with clicks instead of
typed words. So unless you want to actually update your message again, the
interactive_message_callback can be ignored.
Here's an example
of handling updating interactive messages from the botkit slack starter
example. You can add the bot to a team from here and say 'tasks' to the bot to test it out.
On Tue, Mar 14, 2017 at 10:57 PM Harris Novick<EMAIL_ADDRESS>wrote:

This seems potentially related to #663
https://github.com/howdyai/botkit/issues/663
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/howdyai/botkit/issues/704#issuecomment-286626660, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AMUR25LzBBaUtI8PQM4dzoTr3WfDjDcvks5rl1OdgaJpZM4MavYE
.

Thanks.  I suppose the bug I'm reporting is that this behavior (below) — is not functioning, although I'm able to successfully utilize all other documented functionality of botkit.
If you are using interactive messages in conversations, botkit will
automatically route the users input to the conversation for you.

@jonchurch In this comment, the user also experiences the desktop_notification issue.  I think this is a legitimate issue.
https://github.com/howdyai/botkit/issues/663#issuecomment-280455787


Image file sizes increase on upload!

MW v1.3.1 with Php v8.1
Template Shopmag v3.7
Editing home page slider, replacing slides #1 & #2 with optimised webp images:
Original slide #1 image is 140KB, optimised using tinypng.com it's reduced to 31KB
Uploaded cached size becomes 116KB, 3.7x larger!
Slide #2 increases from an optimised size of  37.6KB to 140KB 3.7x larger
Editing products - first product on home page:
Original image size is 219KB, optimised is 34KB, uploaded is 169KB, 4.97x larger!

I'm thinking it might be this setting in Settings > Advanced > Other Settings > Live Edit Settings
Could you try again while this is turned OFF ?

@RogerAntonio thanks for guiding me to this setting, don't think I've seen it before. However it's set to 'No'.

@peter-mw I suspect it could be that the uploaded optimised image is being remade as a higher resolution (higher quality) image during the upload process (and maybe also during the caching process). I've not tested this but it looks like the quality is not being set in the Php function imagejpeg() line 565 in file \src\Microweber\functions\plupload.php (I've read that the default quality is 'about 75').
Also I see in function createThumb the quality/compression is hard coded as $restQuality = 90; whereas the optimised image uploaded might be say '60'. The higher resolution thumbnail image will therefore have a larger byte size than the uploaded optimised image.
I don't think there's a reliable method to detect image quality, so instead could quality/compression be a configurable setting please?

I tried adding a third parameter with a value of 60 on line 532 in file \src\MicroweberPackages\App\functions\plupload.php and also on line 654
Then in file \src\MicroweberPackages\Utils\Media\Thumbnailer.php I changed $restQuality from 90 to 60 on line 34.
However non of these changes made any difference, the thumbnail image is still 3.7x larger than the one uploaded.

I'm trying to do the simple task of replacing a product image that in the default content is a massive 1800px x 2400px webp image with a file size of 780KB. The replacement file is an optimised jpg image 800px x 1067px that has a file size of 75KB (10 times smaller), but the upload process appears to automatically up-size the image to 1920 x 2560 with a file size of 273KB, 3.6 times larger than the one uploaded.
Sometimes the image url containing the image SEO name is replaced with something like /api/image-generate-tn-request/1283?finded

Hi we reduced the thumbnail size to 1200px , but you are correct, a setting must be added to have the size on the template.
Also the image url is changing to /api/image-generate-tn-request when the cache is cleared, because the thumbnail cache is also cleated


Add library script tag placement [feature request]

Hello,
Thanks for this great tool and really useful!
Bug environment:
Chrome: Version 51.0.2704.103 (64-bit) Mac OSX El Capitan
Bug Description and step:

Created new jsbin
place your cursor in 'HTML' section below title element
Click on add library > add any library for ex: RequireJS
It include library just below head element and not below title element

Expected behaviour:
library should be included where you had placed cursor before adding library.
Many Thanks
Pravin

Thanks. Happy to take a feature PR to update this.

Details of feature request:

Insert the library selected at the cursor position, not detected from the head element

@remy I would like to work on this. However, it seems like there isn't any tests written. Should I add one for this PR?

Definitely go for it.  Any
tests added would be great (prefer tap), though I don't even know how you'd
begin to test with code mirror in the project...
On Fri, 22 Jul 2016, 17:51 Alan Yeo<EMAIL_ADDRESS>wrote:

@remy https://github.com/remy I would like to work on this. However, it
seems like there isn't any tests written. Should I add one for this PR?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jsbin/jsbin/issues/2821#issuecomment-234596066, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAA1hCur1WNl8Iky-0SOaFHhcGkZOP06ks5qYPUEgaJpZM4JRr_U
.

@remy I've made a fix. My initial plan was to come up with unit tests for the code. But I feel that it is too cumbersome to test, since it depends on global state.
Having said that, I feel that #2124 would be a better approach to testing and I'm keen to look into that 😄

Works Fine Thanks