Http trace option

What version of Gateway-ST are you using (gateway version)?

$ gateway version
Version: v1.9.0

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (uname -mrsv)?
docker
What did you do?
I connected nextcloud to gateway-st as S3 primary storage.
Single operations on small and large files are working fine,
but the nextcloud feature to create office template files for the user leads to constantly to "Please reduce your request rate." error.
I want to enable the full http trace ouput. It is normally possible over mc admin trace
Only errors are printed over storjlabs/gateway run --log.level=debug --log.output=stdout --log.development=true
It seams by the that nextcloud object id that it makes at least one request successful before
nextcloud command to reproduce (executing twice)
$ php8.3 occ richdocuments:update-empty-templates
Output:
#first execution
API: PutObject(bucket=nextcloud, object=urn:oid:901)
UserAgent: aws-sdk-php/3.240.8 OS/Linux/5.15.0-112-generic lang/php/8.3.8 GuzzleHttp/7
Error: Please reduce your request rate. (minio.ErrorResponse)`
#...
#second execution
API: PutObject(bucket=nextcloud, object=urn:oid:903)
UserAgent: aws-sdk-php/3.240.8 OS/Linux/5.15.0-112-generic lang/php/8.3.8 GuzzleHttp/7
Error: Please reduce your request rate. (minio.ErrorResponse)
       4: /go/pkg/mod/storj.io/minio@v0.0.0-20230627070725-370d887aacde/cmd/api-errors.go:2012:cmd.toAPIErrorCode()
       3: /go/pkg/mod/storj.io/minio@v0.0.0-20230627070725-370d887aacde/cmd/api-errors.go:2037:cmd.ToAPIError()
       2: /go/pkg/mod/storj.io/minio@v0.0.0-20230627070725-370d887aacde/cmd/object-handlers.go:1578:cmd.ObjectAPIHandlers.PutObjectHandler()
       1: net/http/server.go:2122:http.HandlerFunc.ServeHTTP()`

The request limit comes from the storj network itself,
to see all http requests to the gateway instance would be helpful.
I don't know why nextcloud would make 2 put's on the same object in sequence.
What did you expect to see?
all http requests to the instance
What did you see instead?
only errors are printed out
Nextcloud basic info
https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/primary_storage.html
config
'objectstore' =>
array (
    'class' => '\\OC\\Files\\ObjectStore\\S3',
    'arguments' =>
    array (
      'bucket' => 'nextcloud',
      'hostname' => '<IP_ADDRESS>',
      'key' => 'thekey',
      'secret' => 'thesecret',
      'port' => 7777,
      'use_ssl' => false,
      'use_path_style' => true,
      'uploadPartSize' => 67108864,
      'putSizeLimit' => 67108864,
      'concurrency' => 1,
    ),
  ),

nextcloud simple makes a putObject on file create followed by a second putObject by the content write.
The issue not to have a trace on the gateway said is still missing,
but i close this issue.


Rework storage documentation and add "rushed mode"

Since this also includes the information of suspended ingestion upon
too many chunks in memory, it can only be merged once this han been
implemented (I'm working on it next).
@fabxc

@fabxc This could be merged now. Do you have comments?

You know that I'm not a fan of overly exhausting documentation – especially on such details.
I simply believe that it will keep many people from reading it in the first place, thus increasing the number of times it gets asked in IRC or the mailing list again and again.
But yeah on the docs :+1:
We need a checklist to quickly figure out appropriate flags.
(I'm sure that it's totally important to understand what flags you are setting and why etc. – but that doesn't reflect usage reality.)

In my experience, those flags are only needed for "power users". Some of them do ask those questions or irc or by mail, but pointing them to this section usually helps, so it has saved us the work of repeating the same thing over and over.
At some point, we want a "memory autopilot" (see https://github.com/prometheus/prometheus/issues/455 ), which would avoid users to run into this kind of issues in the first place.

Yes, the docs should be there as they are. Just wondering whether its possible to provide a TL;DR of it.

My guess it won't be helpful in most cases. Once you are in tweaking land, you need more context than just ruled of thumb. It may be we gain more confidence over time, but then we can implement them right into the "memory autopilot".

The default setting for -storage.local.memory-chunks actually hits non-power users quite often, if they try out Prometheus on a too small server and it OOMs, no matter how few time series they are ingesting.

But by reducing it, we would hit many other non-power users that have a very modest but not low number of time series.
The default settings are good for ~4GiB of RAM, i.e. it will run nicely on most servers and personal computers. I see it as the sweet spot.
A memory "auto pilot" will deal with all of that.

I just wanted to argue that this information is also relevant for the opposite of power users - thus making a TL;DR useful for a wider range of people.
And as I understand it, the memory "auto pilot" is nothing that is concretely happening, because nobody knows how to do it right.

How about we add a warning at startup if the machine has less than -storage.local.memory-chunks * 2KB? That should handle the small cases.


Remove mkdirp and rimraf in favor of Node.js builtins

In Node.js v10.12.0, recursive option was added to fs.mkdirSync. This option allows you to create a directory and all its parent directories if they do not exist.
In Node.js v14.14.0, fs.rmSync was added. It's a built-in module that removes files and directories. The recursive option is used to remove directories and their contents.
Since pdf.js repository requires Node.js 18 and up, it's safe to assume mkdirp and rimraf can be safely replaced, thus reducing the number of dependencies in this project.

It's probably a good idea to split this into two separate PRs, one for mkdirp and one for rimraf, since replacing mkdirp seems less problematical/risky and thus might be able to land sooner.

Would it be possible to have few tests to check that we aren't breaking something again ?

Closing this for now, since there's not been any updates for a couple of weeks and this cannot land in its current state (needs careful testing and no fixup commits for a start).


Openrewrite Jakarta transformation fails depending on the targets order

https://issues.redhat.com/browse/MTA-1362

Closing as is expected


rake scholarsphere resolrize did not update the index on collections on QA

When I ran the rake task the indexes were not updates.
When I went into the console and ran Collection.all.each(&:update_index) the index got update

It is possible one object is causing issue and the job is failing before it gets to the collections.

Related to #445


Support struct-definition generation

When creating a "telemetry configuration" for an application, there are a lot of pieces even besides the source code implementation.
For this reason, some kind of JSON-schema enforced configuration data should be the source, and an arbitrary number of outputs should be allowed to be generated.
We should make C++ struct generation an initial first-class generated output type.
We already made some progress on generated outputs being integrated into the build with the PIO + pioasm setup.
What's also nice is the gen command could JIT build these.
We may want to parallelize some things in gen for performance?

Rather than implement this here, let's implement it on https://github.com/vkottler/ifgen/issues/1.


Add code style checks

Proposed changes

Add black and ruff for Python
Add clang-format for C++
Add pre-commit configuration and workflow that checks both

Please add some documentation (probably in the meta and our installation guides) how to set it up locally.

This functionally, this should be ready. However, we already have a merge conflict and presumably many more will occur, with #334

As the formatting of all these files is automated (i think) we should just accept all incoming changes and rerun the formatting.

I've taken this over cleaned up the history to only have two commits for pre-commit and ci setup, then got the latest changes from master and then autoformatted everything again.


Add DEV_PLUGIN_REPO to the plugin context

This feature is usefull for dev in local

Could you give an example?

yep,
const jsonfile= `${repo}/hain-plugin-example/jsonfile.json`;

You can require your JSON just as you would require a js file.
const jsonfile = require('./jsonfile.json');

yep, but not after the plugin is loaded. By example with, the library "node-jsonfile", we cant read or write in the plugin directory without precise the full path.  You can have a try.
Check by friends plugin if you want : https://github.com/k-meissonnier/hain-plugin-snippet/blob/master/index.js. He using '../../' for go to his json file so it's not convenient

So why have added the LOCAL_PLUGIN_REPO and INTERNAL_PLUGIN_REPO to the plugincontext ? The DEV_PLUGIN_REPO is in the same logic.

@Metrakit Nice work!, I think it's useful.


Crash

The app crashes when I open tabs on both SSD and HDD at the same time. And don't work hotkeys for switch tabs (Ctrt + Tab), but Ctrl +1, Ctrl + 2 and ect. is OK.
Maybe you can find some useful. Tnx.
System:
Windows 10 Pro 64 bit
Version 20H2
OS build	19042.985
debug.txt
debug_fulltrust.txt

@akset045 Is this still an issue in main?

@yaichenbaum, only with switching tabs. Other stuff are not terrible.

@akset045 What version of Files did you test with?

@yaichenbaum <IP_ADDRESS>.

These issues appear to be resolved in main. Let us know if it's still an issue once v2 rolls out.

@yaichenbaum ok.


Update dependencies to include angular 9

Since the only problem in using angular 9 are the dependencies, hereby a pull request to update the dependencies

Is there a reason this is not accepted?

@isaacplmann @hectorp55
Can you guys follow this up and release the new version,
It's breaking my pipe line. I need this version fix.

Thanks for the PR.  This is superseded by #225 .  Closing.


tsconfig without compilerOptions not supported

vite-aliases doesn't check if compileOptions exists in the tsconfig, and doesn't handle it.
So when using a tsconfig that uses extend to get it's compilerOptions and doesn't have it's own, a TypeError occurs: Cannot read property 'paths' of undefined

Kinda related to #25 since i tried extend to get around that issue and keep my comments in a tsconfig.base.json file.

Can be worked around by simply creating "compilerOptions": { "paths": {} }

fixed with v0.8.4


Step 8: Deploy the Lambda function --- Not Fully Understood

I do not know how to apply Step 4 as mentioned here: https://aws.amazon.com/blogs/compute/extracting-video-metadata-using-lambda-and-mediainfo/
for our purposes.
I created the role for lambda_trust_policy and I skipped the DynamoDB related role creation as we are not doing anything with DynamoDB.
Then I execute this command:
    --function-name MyAmazingLambda \
    --runtime python2.7 \
    --role LambdaMediaInfoExecutionRole \
    --handler handler.lambda_handler \
    --description "My Amazing Lambda Function" \
    --timeout 30 \
    --memory-size 1536 \
    --zip-file fileb://lambda_r_survival.zip

but I get the following complaint:
When calling the CreateFunction operation: 1 validation error detected: Value 'LambdaMediaInfoExecutionRole' at 'role' failed to satisfy constraint: Member must satisfy regular expression pattern: arn:aws:iam::\d{12}:role/?[a-zA-Z_0-9+=,.@\-_/]+

Could you be so kind to specify more what needs to be done under Step 8: Deploy the Lambda function so I do not encounter the above error?
Thank

I figured out my mistake. For role, you need to add the ARN that is returned from LambdaMediaInfoExecutionRole, something like this:
    --function-name MyAmazingLambda \
    --runtime python2.7 \
    --role arn:aws:iam::259733295714:role/LambdaMediaInfoExecutionRole \
    --handler handler.lambda_handler \
    --description "My Lambda Function" \
    --timeout 30 \
    --memory-size 1536 \
    --zip-file fileb://lambda_r_survival.zip


shimv2: get the kata configure file from env KATA_CONF_FILE

If the env KATA_CONF_FILE was set, shimv2 will use it as the
kata configure file, otherwise, it will try to find it from
/etc and /usr/share directory.
Fixes: #1091
Signed-off-by: fupan<EMAIL_ADDRESS>

/test


Energy usage

Since the last update (version 3.1.0) I keep getting notifications about significant energy usage by the app. Also, sometimes when I type it freezes for a few moments with the loading mouse cursor.

I have exactly the same problem! I need to close it, in order to gain 1 or 2 hours of battery life.

I did some preliminary testing on the issue using the top command, namely:
top -stats command,power | grep "Electron  " --line-buffered >> power.log

Shortly, the above command allows us to monitor the unitless "power usage" (see this article on the actual way the measurement is calculated) of the main Electron application. For simplicity's sake I've excluded the helper processes.
I ran three simple tests:

leaving the application on idle, but in the foreground;
hovering over different UI elements (contacts list and chat);
scrolling the views, both the contacts view and the chat view.

The results are as follows:

While this is knowingly a very quick and dirty test, I think it highlights the following points:

when the application is idle, the "power usage" is low;
the scrollable parts of the interface are the most taxing.

While both of those are intuitive, the extent of scrolling performance impact was a surprise to me. I don't have any proposals for improvements at the moment.

I'm finding a massive increase in CPU usage that I think is probably related to animated GIF playback or display.
When I switch between one conversation with just text and emoji used recently (as in, as far back as is loaded by the view) and another that has a single animated GIF, there's a stark difference: from 1–2% for the app and its helper thread to 40–60%.
I'm not sure how feasible it is to implement something like only playing GIFs that are clicked on or only when the app is in focus, but maybe this would help control CPU and energy usage? Or maybe a more involved solution is required; I'm spitballing ;)

In theory, the solution would be rather straight-forward: whenever there's an animated image, replace it with a static one and add a hover to show the animated one again.
The problematic bit is knowing when to replace an animated image with a static replacement, currently there are no handlers bound to handle the internal loading and other logic.
We may get away with something as simple as a web-request filter to notify us of when to check for images, but I haven't tested if it's a usable approach.
All in all, I think it would be a good idea to include a prefpane option in the app for a power saving mode or something along those lines: disable animations, certain hovers, hide animated images by default etc.

I've been seeing poor battery performance on my Macbook Pro with Touchbar. Determined the cause was Goofy.
With that running, I was topping out at about 4 hours. Without it running, i'm getting nearer the 9/10 hours expected on a single full charge.

Just want to confirm that in my experience animated GIFs cause a massive CPU usage when playing even if the app is out of focus. I usually just scroll up to a part of the conversation that doesn't have a GIF or delete the GIF.

Hi, it appears that you're right - animated gifs on screen do cause high CPU usage though have noticed if the app is hidden (via cmd-h), on another desktop, or behind another window the CPU usage drops down to 0% (could be due to an upgrade in messenger.com / recent upgrade to Electron v4?)
Closing for now but please re-open if still occurring and will investigate


Loading historical commands on start

Wondering if we could easily load previous session chat prompts on start - i.e. session history. This would allow you to up arrow and choose a command you ran in a recent session. Not a huge deal if it's a lot of work.  Thanks for this library!

Great suggestion, this is pretty easy, I'll put up a PR.

Thank you! :godmode:


Cache adapters shouldn't load the entire cache at once

Currently, cache adapters like Memcache and Predis work by storing the entire set of cached data into a single cache item. This doesn't scale well for sites with hundreds of thousands of files, where Flysystem would end up fetching the entire cache and storing it in memory for the duration of the request. There can also be significant overhead of the json encoding / decoding process even if only a single file is changed. There's also a further risk of cache stampedes, since all processes would have to write to a single cached item.

@deviantintegral I have the same problem, could you resolve it ?
Thanks

ping @frankdejonge. Thanks

We ended up writing our own cache adapter as a part of the Drupal Flysystem module.

From the drupal guys, do you have an example solution for non drupal projects on how to create new unique keys for things?  When looking at your post, it looks like you created a 'CacheItem' class which is used for each item but not sure how to integrate that with the normal flysystem stuff.

The solution we came up with for Drupal is specific to Drupal, so it's not generally usable.
The idea and implementation is simple enough though. We ignored Flysystem's default cache adapter and made our own. This isn't too much work since a cache adapter is just a regular Flysystem adapter that wraps another one.
The big difference in approaches is that we don't use the cache for directory listings. Only for individual file reads and writes. It would be possible, with an advanced enough cache backend, to do directory listings based on path prefixes, but this was good enough for our needs.

Being inspired by this ticket I've started working on a simple cache adapter for Flysystem v2. It has completely different cache structure and works with any PSR-6 cache pool interface. You can find it here:
https://github.com/Lustmored/flysystem-v2-simple-cache-adapter
Any review and comment is highly welcome :)


Provide map_range() in a new library

The most common reason to use this library is just for map_range(). We can consider creating a new MapRange library just for that purpose. It will be very small. Perhaps there are a few other similar utility functions we could put in as well.

I dig it, that's definitely the main reason I import simpleio.

I dig it, that's definitely the main reason I import simpleio.

Fixed by adding new library https://github.com/adafruit/Adafruit_CircuitPython_SimpleMath.


Make a clear distinction between 0.2 docs and new docs

What is the issue?
Users are landing on the old docs for some reason, so we need to clarify that they should go to the new docs instead when they land in the old docs.
I think they are landing there because google is showing quick links to the old docs.

We should add a warning on the old docs and then try to fix the google search issue -

I'll take a look at the google rendering issue. I think we were able to fix this problem at Bitnami, so I just need to remember how we did it.

I'll take a look at the google rendering issue. I think we were able to fix this problem at Bitnami, so I just need to remember how we did it.

One solution might be to add redirects to let Google know the new URLs (if we have equivalents in the current docs). Or use their search console tool, which has an option to remove outdated content from search results: https://support.google.com/webmasters/answer/7041154?hl=en

Notice added to old docs in #3915 and #3988


Get data from the computer's RTC to the key's system

Getting the current time (RTC) from the user's computer and saving it as timesSteps format.

Getting a real-time without an RTC module is probably impossible.


Better Examples

So I'm having some issues trying to figure out the setup here.
I see this:
pathname: '/api/v1',      // base api path
resource: null,           // resource path to use (overrides model name)
action: null,             // action to use for the given resource ([resource]/run)

Do these pertain to my external API path, or would these define my internal SailsJS API?
For example, if I wanted to call the following from my external API
curl -X POST http://localhost:9999/api/returnList

What would be the best way to implement this in a model / controller?

These parameters are modelled after Rails' routing principles.
So your pathname should be /api your resource should be returnList and your action should be an empty string


Key guessing with id field for setting primary key is order-dependent

Describe the bug
Importing large JSON objects where the id is not the first key can result in that a different key than id is used as the unique document identifier. This can result in documents not being imported.
EDIT: I just discovered the part in the docs about id guessing... I'm not sure how I feel about the implementation, to be honest. It is now order dependent, which is not OK according to ECMA spec. The docs seem to suggest that if you just use id, you're all set. I'd suggest the following behavior: scan for an id field. If it's not there, then scan for other fields containing id. Or perhaps skip the guessing thing altogether, and only accept id, and throw an error if it's not there.
To Reproduce
1: Post an array of JSON documents where the first key of the first object contains the string id, like some-id-yo.
[
  {
    "no-id": "I'm incorrectly considered the primary key, probably because my name contains `id`",
    "id": 1
  },
  {
    "id": 2
  }
]

Then check the index, and see that no documents are indexed.
Now... If we reverse the order of the first two keys, like so:
[
  {
    "id": 1,
    "no-id": "This works fine! I'm no longer the primary key!"
  },
  {
    "id": 2
  }
]

If we post this JSON above, the items are both correctly indexed.
if we remove the id from no-id, it also works fine:
[
  {
    "no-std": "I'm no longer a primary key!",
    "id": 1
  },
  {
    "id": 2
  }
]

So only when:

The key contains id
The key is parsed before the true id field

Then things go wrong
Expected behavior

I expect JSON order not to matter
I expect only id fields to be considered primary key fields

Meilisearch version: 0.29.1
Additional context
Tried on MacOS, but also windows machine.

I don't think the support label is correct. My problem is resolved for now, but the questionable behavior remains

worth to go with "_id" field? 🤔

Hello @joepio
I put the label support so that our support team can take care (@oluademola) of your issue and potentially redirect it to the right repo if it's a feature request, like this one 😉
We don't handle feature feedback and request in this repository, but in this one
Thanks for your feedback 😊

Sorry, but I also don't think it's a feature request. You might classify it as a request for feature removal, but I'd say it's a bug, because the current implementation doesn't respect the JSON specification, as the order of keys should not matter.
Spec:

JSON parsing libraries have been observed to differ as to whether or not they
make the ordering of object members visible to calling
software.  Implementations whose behavior does not depend on member
ordering will be interoperable in the sense that they will not be
affected by these differences.

It not just violates the JSON spec, but because of that it leads to documents not being imported.

Hi everyone👋
We currently have a dedicated product discussion for that subject. There are some interesting ideas that are mentioned here, we will try to work on them for v1.0. Any proposal is good to take and discuss.
Thanks!

It's indeed a feature request on our side: even if we could consider it as a bug because it does not follow perfectly the JSON spec, a change would drastically impact our current users -> we treat this kind of change on the product side and discuss this kind of change in the product discussions 😊
I close this in favor of the product discussion.


Banner Symbols not persisting

Thaumcraft-1.12.2-6.1.BETA12
Thaumcraft-1.12.2-6.1.BETA13
After using the phials to place arcane symbols on my banners I find they are lost when I disconnect from the server and reconnect.
When I tested this on a single player world, it worked fine.
update:  After checking with other players on the server, they can not see the symbols even after I placed them, so it looks like the server is not sending that information to the clients.

Also having this issues as well with banners not keeping or showing to other players what symbol is placed on the banner

I tried testing this with b19 first, and was getting an error on the server console.  I rolled back to b18 and was able to place the symbols on the banners.
[15:40:14] [Server thread/INFO] [minecraft/DedicatedServer]: [Xules: Given [Phial of Essentia] * 1 to Xules]
[15:40:18] [Server thread/FATAL] [minecraft/MinecraftServer]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NoSuchMethodError: net.minecraft.item.EnumDyeColor.func_193350_e()I
at java.util.concurrent.FutureTask.report(Unknown Source) ~[?:1.8.0_152]
at java.util.concurrent.FutureTask.get(Unknown Source) ~[?:1.8.0_152]
at net.minecraft.util.Util.func_181617_a(SourceFile:47) [h.class:?]
at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:723) [MinecraftServer.class:?]
at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:396) [nz.class:?]
at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:668) [MinecraftServer.class:?]
at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526) [MinecraftServer.class:?]
at java.lang.Thread.run(Unknown Source) [?:1.8.0_152]
Caused by: java.lang.NoSuchMethodError: net.minecraft.item.EnumDyeColor.func_193350_e()I
at thaumcraft.common.tiles.misc.TileBanner.getColor(TileBanner.java:73) ~[TileBanner.class:?]
at thaumcraft.common.blocks.basic.BlockBannerTC.func_180639_a(BlockBannerTC.java:104) ~[BlockBannerTC.class:?]
at net.minecraft.server.management.PlayerInteractionManager.func_187251_a(PlayerInteractionManager.java:449) ~[or.class:?]
at net.minecraft.network.NetHandlerPlayServer.func_184337_a(NetHandlerPlayServer.java:739) ~[pa.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.func_148833_a(SourceFile:55) ~[ma.class:?]
at net.minecraft.network.play.client.CPacketPlayerTryUseItemOnBlock.func_148833_a(SourceFile:11) ~[ma.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(SourceFile:13) ~[hv$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Unknown Source) ~[?:1.8.0_152]
at java.util.concurrent.FutureTask.run(Unknown Source) ~[?:1.8.0_152]
at net.minecraft.util.Util.func_181617_a(SourceFile:46) ~[h.class:?]
... 5 more


release librealsense2 version 2.40.0 for eloquent

Eloquent is now end-of-life, so there will be no more updates for it.  See https://discourse.ros.org/t/new-packages-for-eloquent-2020-12-14/17907 and the timeline at https://index.ros.org/doc/ros2/Releases/#releases .  So I'll close this out.


Turn light off if brightness is 0

Breaking Change:
Lights will now be turned off when brightness is set to 0
Description:
Turn light off if when brightness is set to 0 as discussed in home-assistant/architecture#119
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#8967
Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass
[x] There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

[x] Documentation added/updated in home-assistant.io

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

@lwis i removed some code in trådfri light which doesn't seem to be useful:
https://github.com/home-assistant/home-assistant/blob/59476ab475122bb02ddbdd2abcd4930cdfece849/homeassistant/components/tradfri/light.py#L266-L267
It was added in #11187, do you remember if it was needed?

I don't think the gateway responded well to negative brightness values.
On Thu, Mar 28, 2019, 7:51 PM emontnemery<EMAIL_ADDRESS>wrote:

@lwis https://github.com/lwis i removed some code in trådfri light
which doesn't seem to be useful:
https://github.com/home-assistant/home-assistant/blob/59476ab475122bb02ddbdd2abcd4930cdfece849/homeassistant/components/tradfri/light.py#L266-L267
It was added in #11187
https://github.com/home-assistant/home-assistant/pull/11187, do you
remember if it was needed?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/22400#issuecomment-477746188,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AA1TO46nIoA4RXhn8RpgUxCHRBGhU67Uks5vbR1XgaJpZM4cJKxx
.

@lwis Right, I imagined it was something like that. However, it should not be possible to have negative brightness values since brightness is clamped by the light component's validation schema:
https://github.com/home-assistant/home-assistant/blob/0df7f8e97c4cafcc473aaf84d1add19294fcc0c6/homeassistant/components/light/__init__.py#L88-L91

Should this affect all light platforms? I try to turn off a light by set brighness to 0 but it doesn't work. In this case I use Deconz.

@xydix Yes, it should affect all platforms. Can you open a bug report / issue if its not working for you?


New component recaptcha

Please check if the PR fulfills these requirements:

[ ] After these changes, the app was run and still works as expected
[ ] Tests for these changes were added (if applicable)
[ ] All existing unit tests were run and still pass

Please specify the type of change this PR introduces (Bug fix, feature addition, content update, chore, etc.):
New Component: Recaptcha
Integrates Google Recaptcha and validates using recaptcha-service
Additional Notes:

Also, question: does this version of library (which includes the "vue-recaptcha" package) work in OOP without adding "vue-recaptcha" as a dependency?

Can you also add a unit testing suite? As a minimum, we want to confirm that the component renders.

Also, question: does this version of library (which includes the "vue-recaptcha" package) work in OOP without adding "vue-recaptcha" as a dependency?

I have tested linked to OOP, and it builds without any changes.  I do not forsee any difference once the new version is published.


Cannot load templates

When I use the following command to initialize a project, an error occurs.
pnpx wxt@latest init test-wtx-plugin

The error is as follows.

Packages: +377
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
Progress: resolved 411, reused 186, downloaded 191, added 377, done
<EMAIL_ADDRESS>Running postinstall script, done in 39ms
<EMAIL_ADDRESS>Running install script, done in 2.9s
<EMAIL_ADDRESS>Running postinstall script, done in 475ms

WXT 0.13.1                                                                                10:27:40 PM
ℹ Initalizing new project                                                                                10:27:40 PM
✖ Command failed after 409 ms                                                                                10:27:40 PM

 ERROR  Cannot load templates: {}                                                                                10:27:40 PM

  at listTemplates (/Users/lizhibo/Library/pnpm/store/v3/tmp/dlx-35362/node_modules/.pnpm/wxt@0.13.1/node_modules/wxt/dist/cli.js:2915:11)
  at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
  at async initialize (/Users/lizhibo/Library/pnpm/store/v3/tmp/dlx-35362/node_modules/.pnpm/wxt@0.13.1/node_modules/wxt/dist/cli.js:2835:21)
  at async cli.command.option.option.action.wrapAction.disableFinishedLog (/Users/lizhibo/Library/pnpm/store/v3/tmp/dlx-35362/node_modules/.pnpm/wxt@0.13.1/node_modules/wxt/dist/cli.js:3082:7)
  at async CAC.<anonymous> (/Users/lizhibo/Library/pnpm/store/v3/tmp/dlx-35362/node_modules/.pnpm/wxt@0.13.1/node_modules/wxt/dist/cli.js:3101:22)

I have seen this happen in the past as well, the request to the API listing the folders in the templates folder sometimes fails. GitHub has had lots of outages, and this is one downside to hosting the templates instead of shipping them with the NPM package.
I just ran the command now, and it's working again. I'm not sure if a backoff/retry would help in this case, but the error message could be improved for sure.
https://github.com/wxt-dev/wxt/blob/bdce363eed0b51a8a6f1dc3c066e2b5c9f1f5835/src/core/initialize.ts#L91-L123
I don't know why I chose to JSON.stringify the error... I should have used cause.

@aklinker1 Thank you very much. I tried to run it again and it's all good now.

I encountered the same problem and tried many times it is still not working.

Here's the network request used to fetch the list of templates:
curl -v https://api.github.com/repos/wxt-dev/wxt/contents/templates -H Accept:application/vnd.github+json -H
X-GitHub-Api-Version:2022-11-28

If you encounter an error, please run this command and share the output so I can debug.

@aklinker1 After run this curl command, I got error output:
{"message":"API rate limit exceeded for <IP>. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.)","documentation_url":"https://docs.github.com/rest/overview/resources-in-the-rest-api#rate-limiting"}
* Connection #0 to host api.github.com left intact

But after I tried bunx --bun wxt@latest init test-ext it works, maybe the only way is try more times if not want to use Authenticated requests.

Ahh rate limits. We can improve that using ungh:
https://unjs.io/packages/ungh#reposownernamefilesbranchpath


Spark 2.2 Abstract Method Error

Using spark-avro 3.2.0 as suggested in #315
Receiving the follow error:
java.lang.AbstractMethodError: org.apache.spark.sql.execution.datasources.OutputWriter.write(Lorg/apache/spark/sql/catalyst/InternalRow;)V
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$SingleDirectoryWriteTask.execute(FileFormatWriter.scala:327)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$org$apache$spark$sql$execution$datasources$FileFormatWriter$$executeTask$3.apply(FileFormatWriter.scala:258)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$$anonfun$org$apache$spark$sql$execution$datasources$FileFormatWriter$$executeTask$3.apply(FileFormatWriter.scala:256)
	at org.apache.spark.util.Utils$.tryWithSafeFinallyAndFailureCallbacks(Utils.scala:1375)
	at org.apache.spark.sql.execution.datasources.FileFormatWriter$.org$apache$spark$sql$execution$datasources$FileFormatWriter$$executeTask(FileFormatWriter.scala:261)

As a temporary fix, you can build spark-avro from master branch (as the fix is not released yet) and add it to your assembly jar as unmanaged dependency.

Built spark-avro from master branch and got spark-avro-assembly-4.0.0-SNAPSHOT.jar and on adding that in sbt as > set unmanagedBase := file("...")
I see the snapshot jar in the jar dependencies list. Transported my jar and the dependencies jars to cluster.
I am doing a fat jar with scala 2.11.8
addSbtPlugin("com.eed3si9n" % "sbt-assembly" % "0.12.0")
However on spark submitting with the --jars option i am getting the LinkageError
Warning: Ignoring non-spark config property: #spark.executor.cores=5
Exception in thread "main" java.lang.LinkageError: loader constraint violation: when resolving method "org.apache.spark.streaming.StreamingContext$.getOrCreate(Ljava/lang/String;Lscala/Function0;Lorg/apache/hadoop/conf/Configuration;Z)Lorg/apache/spark/streaming/StreamingContext;" the class loader (instance of org/apache/spark/util/ChildFirstURLClassLoader) of the current class and the class loader (instance of sun/misc/Launcher$AppClassLoader) for the method's defining class, org/apache/spark/streaming/StreamingContext$, have different Class objects for the type scala/Function0 used in the signature

Please use spark-avro 4.0.0


Improve our contact forms / help info pages to be more informative

Our help pages and contact forms are not very clear about how to contact us, or whom to contact for what type of inquiry.
This is to ensure customers and users can easily contact us for help or questions.

@brittag can you update the description if I am missing something?

Here's an existing issue with more detail: https://github.com/18F/cg-landing/issues/66

closing this, keeping open 18F/cg-landing#66.


Support accessor CTAD without deduction tags

Previously, sycl::accessor acc{buff, cgh} would not work because there were no deduction guides. Additionally, sycl::accessor acc{buff, cgh, sycl::no_init} would not do what was expected since no_init would be interpreted as deduction tag.
The spec is not super clear, but I think we should allow sycl::accessor acc{buff, cgh} since people will be using it. And it makes sense to use it in conjunction with the hipSYCL accessor variant deduction extension.
This PR

Allows accessor CTAD without deduction tags such as sycl::accessor acc{buff, cgh}. In this case, the access mode will be following the default template argument of the accessor class: read_write if T is non-const, read if T is const. This is implemented using new, additional deduction guides.
Restricts the types that are accepted as valid deduction tags. This fixes e.g. no_init being misinterpreted as deduction tag.

@hipSYCL-ci-bot test


⚙ Refactor plugin code

⛳ Goal
Make the code easier to understand, separate different parsers & renderers, provide more control over what gets rendered, make everything easier to maintain & extend etc.
📝 Tasks

[x] Group various configuration options based on their parser/function.
[x] Provide a good way to modify deeply nested options.
[x] Fix parsers,

[x] Markdown.
[x] Markdown inline.
[x] LaTeX.
[x] HTML.
[x] Typst.
[x] Yaml

[x] Fix renderers,

[x] Markdown.
[x] Markdown inline.
[x] LaTeX.
[x] HTML.
[x] Typst.
[x] Yaml

[ ] Improve documentation & code readability.
[x] Revise lua patterns & conditions.
[x] Revise redraw mechanic(s).
[ ] Fix performance issues on slower devices(e.g. Android).

@OXY2DEV Thank you for your amazing work. when will this be done?

@OXY2DEV Thank you for your amazing work. when will this be done?

It really depends on how much time I get. Currently the schedule is a bit tight which is causing slow development speed.
Functionality-wise pretty much everything is ready. I am doing minor changes.
The documentation on the other hand is taking a while.


v1.11: Fix L4LB GHA

Successful run https://github.com/cilium/cilium/actions/runs/5014936016/jobs/8989823230

Merging since the test this PR is fixing has passed.


[Das_Schwarze_Auge_4-1] Code Cleanup and Dev Split

Submission Checklist
Required

[x] The pull request title clearly contains the name of the sheet I am editing.
[x] The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
[x] The pull request makes changes to files in only one sub-folder.
[x] The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description
I had been thinking about this for a very long time, but finally I decided to just do it: After having turned off legacy parsing in the previous pull request, it was time to get rid of even more legacy. Both sheet files are now pieced together from several small and handy topic-centred files using a simple Makefile.
The complete diffs look awful, run with --ignore-all-space as I converted all indentation to the same character while fixing borked indentation levels.
Having these changes at this point groups it together with the legacy parsing changes which also affected rather large parts of the files leading to ugly diffs when comparing versions before with versions after them. Given the fact that I am probably the sole active contributor to this sheet anyway, this should not impact any other developers.
I have been playtesting this in two sessions with my main group and we did not stumble upon any issues.

Split up the files (6dc83223ca, 76386d6b74, f5dbcca2c3, 01ecb2d61f)
Indentation unification (14ee94e9b4, a5d3b8e545)
Miscellaneous fixes (a5d3b8e545)
Bump version number (e06d9c096a)
Add info on latest version (eb536933d0)

Character Sheet Info Roll20 Internal Use only.

Hi @kreuvf
These changes look great. I suppose one thing I'd ask: could you please write a readme or similar to explain how one should use your makefile? That'll allow anyone who comes after you to be able to help update the project in the future.

Thank you very much for your feedback. Do you think this is enough?

Hey @kreuvf
That's spectacular, thanks!  Really great work here.


Fixed issue #9687

Issue Reference
Fixed issue #9687

@shivendra-webkul
Checked and found that now the arrows are not appearing and hence the issue is fixed. Please check the screenshot for the same.
Screenshot


[Feat] Custom theme

Fixes #20

UI is broken on mobile now. Maybe change the widths from using ch to using '%'?

Todo: fix image getting cropped in blog post card&list


/listorders must show channel where the order is published

Made PR #247 but some old code is triggering an alert. Any ideas?

Yes, we need to fix some regexes, github is complaining because they are inefficient and someone can start a DoS from there

I replaced the regex with a split/join and it worked. I don't really like it but github does.

great, let's wait the linter PR to be merged bc is a big PR, then we review this again

This was merged, good job!! thanks 🤖


Solve "[DEP0013] DeprecationWarning: Calling an asynchronous function without callback is deprecated."

Here is a contemporary solution from @BenjaminChoou:
1. Find where your node-tesseract module is.
On my computer, the path is :
C:\Users\BenjaminChou\node_modules\node-tesseract\lib
2. Open and modify tesseract.js as follow:
Before:
fs.unlink(files[0]);
Now:
fs.unlink(files[0], err => { if (err) console.log(err) });

Thanks!

@uchihaty Why don't you create a PR for this?

Is this project sill active? Just an FYI, I'm testing with Node v10 and this error now breaks the project.
Error message:
TypeError [ERR_INVALID_CALLBACK]: Callback must be a function
at makeCallback (fs.js:148:11)
at Object.fs.unlink (fs.js:1016:14)
at /.../node_modules/node-tesseract/lib/tesseract.js:99:14
at FSReqWrap.readFileAfterClose [as oncomplete] (fs.js:422:3)
[ERROR] 13:14:21 TypeError [ERR_INVALID_CALLBACK]

Same issue Encountered，
node version v11.0.0

Same issue Encountered，
node version v10.9.0

Same, probably the fix should include calling the caller's callback after the unlink...
         fs.unlink(files[0], err => {               err ? callback(err, null) : callback(null, data);           });

@halaprop I think something is wrong with your suggestion: Where is the callback and data defined?

@ceremcem - Sorry, I should have been more explicit.  I was looking here, line 100 is where unlink is called.  callback is passed to the containing function (process()), and data is the result of an fs.read which encloses this code.


Query if this reflects the current configuration of MEM

The Instructions for MEM don't align with the portal. Currently if you go to Endpoint Security -> AntiVirus - >Realtime Protection there is a setting call "Turn On Network Protection". Which of these is the correct method to enable Network Protection?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 71868539-63d8-b250-f9d4-83a4052f4f74
Version Independent ID: ed5658cf-173f-47bf-ed76-a68d89ea5c4b
Content: Turn on network protection - Windows security
Content Source: windows/security/threat-protection/microsoft-defender-atp/enable-network-protection.md
Product: w10
GitHub Login: @levinec
Microsoft Alias: ellevin

Hello @Jlouden9 ,
for me, MEM shows exactly the same options as described in the article.
Could you please provide more details, where is this option presented in AntiVirus section?
Thank you

Hello @Jlouden9 ,
Could you please provide more details, where is this option presented in AntiVirus section? I am not able to find it
Thank you

Hi @Jlouden9, the instructions in the documentation are accurate and will guide you to the correct place to turn on network protection.
I tried to follow your path, but didn't find "Realtime Protection". Closing this issue for now.


Add grootfs init-store and delete-store to tests

grootfs init-store is the correct way to initialize a store for grootfs. At this moment it doesn't do much, but to avoid breaking changes in the future is good to be sure it's getting called before the tests run.
grootfs delete-store is a store "de-initializer", that should take care in the future for cleaning up any mounts left behind.

Context: https://cloudfoundry.slack.com/archives/C02FM2BPE/p1490708418107649.

Thanks, @tscolari! Prioritizing for the Diego team to review.
Best,
Eric


Update filter value under the documentation label in filters.yml

Fixes

Fixes #1932 by @KaitoMizukami
Description

Add a new filter value to avoid rebuilding a documentation every time the frontend directory changes.
Testing Instructions

None
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[ ] I added or updated tests for the changes I made (if applicable).
[ ] I added or updated documentation (if applicable).
[ ] I tried running the project locally and verified that there are no visible errors.
[ ] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Hi @KaitoMizukami, thank you for your contribution! Unfortunately there was another PR opened prior to yours that was already addressing the changes described in #1932: https://github.com/WordPress/openverse/pull/1983
I'm going to go ahead and close this PR, but I want to express thanks again for the effort you put towards your contribution. If you'd like to try and make another contribution, here are a few issues you might look at:

https://github.com/WordPress/openverse/issues/1909
https://github.com/WordPress/openverse/issues/1207
https://github.com/WordPress/openverse/issues/1267
https://github.com/WordPress/openverse/issues/856

If any of those look interesting (or any of our other unassigned good first issues), feel free to ask to be assigned it on the issue and we'll add you!


How to get multiple images for multiple prompts

Hello @mikonvergence, your work is awesome and i have a query regarding an issue which is rendering in my brain from days.
I have 10-15 different prompts and i want to infer on a single image, also with T4 GPU, the GPU goes into fragments for single image and single prompt.
Thanks and Regards,
Satwik Sunnam.

Hey! Thanks.
As long as you don't exceed your memory limit on the GPU, you can do that by supplying a list of prompts from the interface perspective.
This is an example I run with the canny edge in the supplied colab notebook.
pipe.to('cuda')

text_prompt=["squirrel","elephant"]

# generate image
generator = torch.manual_seed(0)
new_image = pipe(
    text_prompt,
    num_inference_steps=20,
    generator=generator,
    image=image,
    control_image=canny_image,
    controlnet_conditioning_scale = 0.5,
    mask_image=mask_image
).images

plt.subplot(1,2,1)
plt.imshow(new_image[0])
plt.subplot(1,2,2)
plt.imshow(new_image[1])

with the following result:

I don't know if this was your question or if you were asking about some more efficient way to compute this. That said, it is unlikely I will be making further changes in this respect, as I want this pipeline to resemble the diffusers related pipelines (inpainting and controlnet) as much as possible. Open to discussion though!

Does this work with a standard GPU, T4

Yes

Also, in case you're looking for an example with multiple images and multiple prompts, you can actually do that by supplying:

prompts as a list of prompts
image as a tensor [B,C,H,W] (where B can contain different input images) - if you convert from PIL, you need to scale to [-1,+1] range
mask as a tensor [B,1,H,W]
guide image as a tensor [B,C,H,W]

Example based on the canny edge example from the colab:

Conversion to tensors (if necessary)

from torchvision.transforms import ToTensor
img1=ToTensor()(image).unsqueeze_(0)
mask1=ToTensor()(mask_image).unsqueeze_(0)
canny1=ToTensor()(canny_image).unsqueeze_(0)

img2=torch.flip(img1,[-1])
mask2=torch.flip(mask1,[-1])
canny2=torch.flip(canny1,[-1])

img_stack=2*torch.cat([img1,img2],0)-1 # convert to [-1,+1] range
mask_stack=torch.cat([mask1,mask2],0)[:,0,:,:]
canny_stack=torch.cat([canny1,canny2],0)

💡 In this example, the second image is the first image horizontally flipped

Pipeline

text_prompt=["squirrel", "elephant"]

# generate image
generator = torch.manual_seed(0)
new_image = pipe(
    text_prompt,
    num_inference_steps=20,
    generator=generator,
    image=img_stack,
    control_image=canny_stack,
    controlnet_conditioning_scale = 0.5,
    mask_image=mask_stack
).images

Result:

for idx,img in enumerate(new_image):
  plt.subplot(1,len(new_image),1+idx)
  plt.imshow(img)


Add sort by median to side_bar

Could you remove the line df = df.query("Salary_USD < 400_000") in plot_sidebar()?

Done!


Crashes when trying to reloadData if number of items is 0

Causes a crash with the following error when the number of items to display in the WheelPicker is 0 and the reloadData method is called:
"Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'attempt to scroll to invalid index path: <NSIndexPath: 0x60400022f920> {length = 2, path = 0 - 0}'"

Use my fork: WheelPicker


Roll engine de4c7a53f21c..f6ad3e0967d1 (25 commits)

https://github.com/flutter/engine/compare/de4c7a53f21c...f6ad3e0967d1
git log de4c7a53f21c..f6ad3e0967d1 --no-merges --oneline
f6ad3e096 Roll Tonic (flutter/engine#6177)
a0f30b3b0 Roll src/third_party/skia 9d1c88d9912d..343553a1fe9e (16 commits) (flutter/engine#6175)
e6d9b34a8 Remove the old location of the ICU data asset (flutter/engine#6170)
9f0ad8b79 Fixes negative end selection offset. (flutter/engine#6171)
0981731fd Enable transparent FlutterViews (flutter/engine#6163)
3a7d0b559 Roll buildroot to 7aadfaf196f9cd8a299f9ad78fab63362800466d (flutter/engine#6169)
564d214b7 Roll src/third_party/skia d0f0cb8ffc5e..9d1c88d9912d (12 commits) (flutter/engine#6168)
6af60d716 Remove obsolete discovery mechanism from FlutterView (flutter/engine#6157)
b22badf1d Dart SDK roll for 2018/09/04 (flutter/engine#6161)
6d0fbc7eb Roll src/third_party/skia 9478f7a38e6c..d0f0cb8ffc5e (1 commits) (flutter/engine#6167)
5063a8a5b Roll src/third_party/skia 72a02112a99f..9478f7a38e6c (1 commits) (flutter/engine#6166)
19a3bc8e1 Roll src/third_party/skia 85f4e40c5481..72a02112a99f (1 commits) (flutter/engine#6165)
9643a50ac Roll src/third_party/skia fddc6fa394cb..85f4e40c5481 (1 commits) (flutter/engine#6164)
6ad3183b1 Fix windows build. (flutter/engine#6162)
30af2f299 Roll src/third_party/skia e486bbaae296..fddc6fa394cb (2 commits) (flutter/engine#6159)
b32ceafb1 Add some more logs for diagnosing screenshot failures (flutter/engine#6156)
c173655b2 Roll src/third_party/skia b84576af0a43..e486bbaae296 (9 commits) (flutter/engine#6155)
aaf98fbfe Use double multiplication by a scale instead of 3 divides for speed. (flutter/engine#6154)
593ed5914 Revert "Use Skia normalize again after Skia precision fix. (#6121)" (flutter/engine#6122)
137389a85 Roll src/third_party/skia a45e1a71f548..b84576af0a43 (16 commits) (flutter/engine#6153)
f89a386a1 Roll src/third_party/skia cff3fd834ca8..a45e1a71f548 (1 commits) (flutter/engine#6152)
b0b8daa7b Unregister onFrameAvailable callbacks when a TextureEntry is released. (flutter/engine#6079)
2dc8271a4 Roll src/third_party/skia 24e58341fbcd..cff3fd834ca8 (1 commits) (flutter/engine#6151)
eea3a21e1 Roll src/third_party/skia bf67741140fd..24e58341fbcd (2 commits) (flutter/engine#6148)
bdcbe801a Roll src/third_party/skia 88119de2b849..bf67741140fd (1 commits) (flutter/engine#6147)
The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

@rmistry @liyuqian : New roll has been created by https://autoroll.skia.org/r/flutter-engine-flutter-autoroll

Trybots failed. These were the failed builds: https://flutter-dashboard.appspot.com/build.html

Commit queue failed; closing this roll.


Next Steps

Issue will be used to track the next steps for the project.

Main branch: Working mostly as expected. Need some improvements
Next Steps:

[x] Fix small problems on main for complete basic functionality
[x] Add Gnome Extensions
[ ] WallPaper and GrubTheme

Gnome Extensions added with PR #8, working good


Disable blur, animations etc when you toggle app on fullscreen

In my option disabling blur when your in any app fullscreen may reduce gpu overhead aka gaming.

it's already done automatically?

opaque apps will not be blurred. Translucent will. Unless your game is translucent, you will be fine.
At any rate, if that's such a big issue for you, make a script lol


⚠ GitLab Server has degraded performance

In d315f10, GitLab Server (https://gitlab01.its-telekom.eu) experienced degraded performance:

HTTP code: 200
Response time: 6069 ms

Resolved: GitLab Server performance has improved in 765588b.


Update the name of the hive cluster: hosted-mgmt

We should do the same for the content as well.
But this is more urgent in javascript.
/cc @openshift/test-platform

/override ci/prow/links


add swagger-to-sdk for js

MSFT employees can try out our new experience at OpenAPI Hub  - one location for using our validation tools and finding your workflow.

Contribution checklist:

[ ] I have reviewed the documentation for the workflow.
[ ] Validation tools were run on swagger spec(s) and have all been fixed in this PR. How to fix?

If any further question about AME onboarding or validation tools, please view the FAQ.
ARM API Review Checklist

[ ] Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.

adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

[ ] If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

/azp run automation - sdk

Can one of the admins verify this patch?

The change looks good to me. Add @qiaozha to confirm from js perspective

The change looks good to me. Add @qiaozha to confirm from js perspective

This looks good to me as well.

hi @changlong-liu could you pls help to merge the PR when you feel ready? thanks

hi @qiaozha , I don't have permission merging this,  would you help to merge this PR? Thanks!

merged. Thx


Feature/transactions auth

This now limits the transactions a user can see
to their own prison. Unless they're a Django admin in
which case they can see everything.
Adds initial groups fixture for each user type but we haven't
mapped exactly what permission each group has, we want to do
this because each user type has a subset of permissions.

We want PrisonClerk users to be able to mark transactions as credited and see a list of them for their prison.
We want BankAdmin to be able to upload a list of transactions using the BAI2 file they download from online banking.
We want NOMSFinance to be able to see all transactions, maybe run some reports.

@marcofucci and @SteveMarshall can you review please?

Is it worth explicitly testing that an authenticated user can't access transactions uploaded for a prison that's not their own when they're limited to a given prison?

@SteveMarshall how? there is no detail endpoint yet... so anyone going to /transactions/1234 will just get a 404. You can currently only hit /transactions/ and check that all of those transactions belong to you, you can't really do anything else. I'll add a test for that all the ones in the list belonging to the user but that's all we can do

@r4vi Good point. It's been a long day :sweat:

@marcofucci / @SteveMarshall good to merge?

:+1: for me


Suspicious function changes GPOS data in-place, messes up other checks

I tried debugging a failure on the check com.google.fonts/check/varfont/duplexed_axis_reflow that looks like this:
ERROR Failed with AttributeError: Coverage

            File ".../venv/lib/python3.11/site-packages/fontbakery/checkrunner.py", line 213, in _run_check
              subresults = list(subresults)
                           ^^^^^^^^^^^^^^^^
            File ".../venv/lib/python3.11/site-packages/fontbakery/checks/googlefonts/varfont.py", line 447, in
          com_google_fonts_check_varfont_duplexed_axis_reflow
              kerning = all_kerning(ttFont)
                        ^^^^^^^^^^^^^^^^^^^
            File ".../venv/lib/python3.11/site-packages/fontbakery/utils.py", line 514, in all_kerning
              for g, pair in zip(subtable.Coverage.glyphs, subtable.PairSet):
                                 ^^^^^^^^^^^^^^^^^
            File ".../venv/lib/python3.11/site-packages/fontTools/ttLib/tables/otBase.py", line 893, in __getattr__
              raise AttributeError(attr)

When running only that single check, the error doesn't happen, and the font data looks alright in the debugger. However, when looking at the same data as part of running a full Fontbakery profile, it looked like the kerning subtables had surprising data, and I think this other function iterate_lookup_list_with_extensions might be the culprit:
https://github.com/fonttools/fontbakery/blob/739244419f0940439f8448b6aef6f7662a1d8a2b/Lib/fontbakery/utils.py#L545-L546
It modifies the subtables in place, and I suspect that messes up other checks that happen later. Would it be possible to perform the intended iteration without changing the data in place?
I can look into a fix if my suggestion makes sense.

Thanks for reporting this! Yes, I'd be glad to review your fix.


Forward SandboxConfig.Hostname to Workload container activation

For Windows the Hostname property is not inherited from the sandbox and must
be passed for the Workload container activations as well.

Signed-off-by: Justin Terry (VM<EMAIL_ADDRESS>

@jterry75 Hostname is not shared in the network namespace on windows?

/test pull-cri-containerd-verify

Negative. We have an internal investigation going on but while that goes on here is a quick fix that doesn't have any risk of breaking anything.

/lgtm


Addressing the has_modifier relation

Suggested revision and reasons
On a recent Monarch Data call (18-Aug), the subject of addressing the has_modifier relation in Mondo was brought up again. @cmungall mentioned it in the context of ensuring all predicates map to something in BioLink.
Are there any updates to this?
Any specific actions you think we should be taking, Chris?
FYI: @sierra-moxon 👀 ⬆
(originally submitted here)
Your nano-attribution (ORCID)
0000-0001-8430-6039

Response from @sierra-moxon:
I believe our discussion around that term was in the context of how to represent inheritance (coming from HP) on disease nodes in the monarch graph (we weren't sure how to attribute a property on a node in the graph, independently from the attribution of the edge between nodes).  I believe we settled on representing "inheritance" as a biolink:genetic inheritance category(node, class) instead of as a property (slot) on the disease node itself.
There are also terms in MONDO that are annotated with inheritance, using a "has_modifier" property, I believe.  I think the idea here was to use a more specific property than has_modifier for this.  But I am not sure of the relation of that discussion to this ticket, specifically. :)
(Originally submitted here)

Response from @nicolevasilevsky:
@sierra-moxon we recently change the relation between a disease and inheritance to 'has bearer' instead of 'has modifier', just FYI. :)
(Originally submitted here)

Dear @sierra-moxon, @matentzn:
Does the update to has_bearer in any way require updates on the BioLink end?
And is the new relation a sufficiently specific property?
If this is n longer an issue, then we can close.
Thanks!

@nicolevasilevsky this is a @cmungall question do Friday.

I already added it to the agenda :)

@monicacecilia @sierra-moxon please see our design patterns for mode of inheritance in Mondo:
https://github.com/monarch-initiative/mondo/blob/master/src/patterns/dosdp-patterns/autosomal_dominant.yaml
https://github.com/monarch-initiative/mondo/blob/master/src/patterns/dosdp-patterns/autosomal_recessive.yaml
We can invite Kevin and Sierra to a future call to discuss further.
I'll close this, please reopen if there are other action items.


Make ParsePatch more robust

Handle some possible but non-likely edge-cases of ParsePatch whereby
it was possible that it could crash.
Tests are added and were the only 2 cases I could find.

apologies for the miscount

What miscount?

I am responsible for the original miscount of characters that leads to this patch

I am responsible for the original miscount of characters that leads to this patch

Ah got it, no worries. It was only after plugging in some values to see how it handled "ambitious" values it panicked, otherwise I wouldn't have seen it as well.

@Gusted thanks for this PR (and all the other ones recently), could you send this as a backport to 1.15.x?
Also, are you on our discord? I have a question I'd like to ask.

@Gusted thanks for this PR (and all the other ones recently),

Happy to help!

could you send this as a backport to 1.15.x?

#17580

Also, are you on our discord? I have a question I'd like to ask.

I am on the Gitea discord server. Gusted#3726


Add className option for fixtures

In the docs you suggest you can pass a className key to fixtures yet you never carried it forward to the suggest object.

Good catch, thanks a lot!

Released in 1.19.0.


Recipe compile error

I would like to use this cookbook to download and install software to Ubuntu and Windows OS.
On a test environment, these commands were used:
berks upload --no-ssl-verify
knife ssh 'role:web' 'sudo chef-client' --ssh-user xxxx --ssh-password 'xxxxxx' --attribute ipaddress
---But encountered the error shown below
<IP_ADDRESS> Installing Cookbook Gems:
<IP_ADDRESS> Compiling Cookbooks...
<IP_ADDRESS> Recipe Compile Error
<IP_ADDRESS> ================================================================================
<IP_ADDRESS>
<IP_ADDRESS> Chef::Exceptions::RecipeNotFound
<IP_ADDRESS> --------------------------------
<IP_ADDRESS> could not find recipe default for cookbook remote_install
<IP_ADDRESS>
<IP_ADDRESS> System Info:
<IP_ADDRESS> ------------
<IP_ADDRESS> chef_version=13.6.4
<IP_ADDRESS> platform=ubuntu
<IP_ADDRESS> platform_version=16.04
<IP_ADDRESS> ruby=ruby 2.4.2p198 (2017-09-14 revision 59899) [x86_64-linux]
<IP_ADDRESS> program_name=chef-client worker: ppid=33825;start=14:17:09;
<IP_ADDRESS> executable=/opt/chef/bin/chef-client
<IP_ADDRESS>
<IP_ADDRESS>
<IP_ADDRESS> Running handlers:
<IP_ADDRESS> [2017-12-01T14:17:11-08:00] ERROR: Running exception handlers
<IP_ADDRESS> Running handlers complete
<IP_ADDRESS> [2017-12-01T14:17:11-08:00] ERROR: Exception handlers complete
<IP_ADDRESS> Chef Client failed. 0 resources updated in 02 seconds
<IP_ADDRESS> [2017-12-01T14:17:11-08:00] FATAL: Stacktrace dumped to /var/chef/cache/chef-stacktrace.out
<IP_ADDRESS> [2017-12-01T14:17:11-08:00] FATAL: Please provide the contents of the stacktrace.out file if you file a b
ug report
<IP_ADDRESS> [2017-12-01T14:17:11-08:00] ERROR: could not find recipe default for cookbook remote_install
<IP_ADDRESS> [2017-12-01T14:17:11-08:00] FATAL: Chef::Exceptions::ChildConvergeError: Chef run process exited unsucces
sfully (exit code 1)
Cookbook version
[Version of the cookbook where you are encountering the issue]
Chef-client version
[Version of chef-client in your environment]
Platform Details
[Operating system distribution and release version. Cloud provider if running in the cloud]
Scenario:
[What you are trying to achieve and you can't?]
Steps to Reproduce:
[If you are filing an issue what are the things we need to do in order to repro your problem? How are you using this cookbook or any resources it includes?]
Expected Result:
[What are you expecting to happen as the consequence of above reproduction steps?]
Actual Result:
[What actually happens after the reproduction steps? Include the error output or a link to a gist if possible.]

I am guessing you add "recipe[remote_install]" this is not a recipe but a library only cookbook, check out the usage for more info.


Build(deps-dev): Bump @testing-library/dom from 9.3.1 to 9.3.4 (#5489)

Pull request opened by the merge tool on behalf of #5489

Merged in 2ae8a7fe6406ddf90ca6405c7db1bef5e75cd044


NodeConfig mixes cluster configuration and local configuration

NodeConfig is a complex integration that sees that configuration flows into very different parts of the system. Currently, config of the local node and config destined for the cluster are mixed into a single configuration object, making the ownership and data flow confusing.
Let's separate the node local configuration items from those destined for the cluster.

This is in reference to https://github.com/docker/swarmkit/blob/master/node/node.go#L39.


Feature: Improve Visibility of the Follow CTA on User Profiles

Type of feature
🧑💻 Refactor
Current behavior
Currently you have to click on the three dots menu to see the Follow/Unfollow CTA. This was not obvious when I went to follow a new user on the platform.

Suggested solution
Have the Follow button placed beside the Share button.
Additional context
Slack Discussion: https://opensaucedworkspace.slack.com/archives/C035RQ8ANBW/p1695223459466669
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Contributing Docs

[X] I agree to follow this project's Contribution Docs

Can I get this issue? @nickytonline

Related PL

.take


Update to python 3.12 (GSI-912)

Contains the usual template updates plus:

Changes to silence some mypy errors
Uses the newer test fixtures.
Adds 'key' to the consumer function
@pytest.mark.asyncio(scope="session") was replaced with a module-level pytestmark=pytest.mark.asyncio in modules where all tests were async. In modules where there were some synchronous tests, only (scope="session") was removed
Gets rid of uses of Optional and Union and so on

Nothing was refactored or modified otherwise. Patch version number was bumped (2.0.0 -> 2.0.1)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>5
Details

5 of 5 (100.0%)  changed or added relevant lines in 4 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.08%) to 90.417%

Files with Coverage Reduction
New Missed Lines
%

src/mass/main.py
1
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
0.08%

Covered Lines:
434

Relevant Lines:
480

💛  - Coveralls


DP cert deployment clarification

In the section "Deploy the client certificate for distribution points" the Note states "This certificate can also be used for media images that do not use PXE boot, because the certificate requirements are the same."
This implies that the DP cert can be enrolled/exported one time (on any computer) and then used for ALL https DPs and boot media; however, the documentation doesn't clearly state where a unique cert is required to be enrolled on each DP.  Can we get a note added to clarify this point?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: c66e3e8a-bd8e-7ae3-aecc-cd9073e2238e
Version Independent ID: 45572c91-8194-096d-2356-80a9b1b356ef
Content: Example PKI certificate deployment - Configuration Manager
Content Source: sccm/core/plan-design/network/example-deployment-of-pki-certificates.md
Product: configuration-manager
Technology: configmgr-other
GitHub Login: @mestew
Microsoft Alias: mstewart

I'm resolving this issue in part because we moved repositories, but also because I'm going to track this work via an internal work item.
(internal reference 2841906)


intelpt trace feature is not working properly.

Thank you for awesome project.
I tested kafl, version kafl_0.2, on Ubuntu 20.04 x64 with fuzzing Windows 10 x64 kernel.
I want to fuzzing windows default kernel driver.
But target driver is not traced properly.
So I debugged windows qemu with gdb and target driver breakpoint hit properly.
But ntoskrnl.exe is traced well.
I think this problem occurs because of intelpt.
Can you give me an advice for me which code process this problem?
Thank you.

Can you try the master branch? There have been many fixes since 0.2 and it should not be difficult to get the Windows example working again.
"Target not traced properly" is a bit too vague. If you have an example case working, the difference to tracing other targets is usually just to set the proper code range and CR3 filter. If you get decoding errors, try to snapshot/restore closer to target code and narrow the trace region to just the specific code sections you're interested in.

Thank you for your reply.

I also tried the master branch. But starting windows in qemu with flags, -machine kAFL64-1, result int infinite boot. So I changed machine flag to q35 and booted well. But after starting fuzzing, when HYPERCALL_KAFL_ACQUIRE hypercall invoked, the windows occurs BSOD. so I tested kafl_0.2.
I want to fuzzing windows network driver which is parsing packet. But this driver is not parsing packet using DeviceIoControl. So I made harness using raw socket and sending packet to localhost and driver parsed this packet well. I enabled SAMPLE_DECODED_DETAILED flag in logger.h. In /tmp/traces/sample_detailed_X files, There is no TNT packet at all.

Can you try to play around with the devices emulated by qemu? It may be worth trying to switch the drive emulation between scsi and virtio, deactivate network, disable any fancy paravirtualization etc. There may also be a bug in virtio-blk interface that causes an assert on first qemu snapshot restore. But not a BSOD.

No trace likely means the filter is configured wrong. Try some simple example to ensure code range is correct, and disable CR3 filter until you have found the right setting.

Oh I set CR3 filter wrong.
Thank you.

I found the cr3 value which trace well.
But kAFL_hypercall(HYPERCALL_KAFL_SUBMIT_CR3, 0); submits wrong cr3 value.
How can I set cr3 value which i want to filter?

Yes, I was also thinking of that.
Is rcx=0 the right magic value? I guess we don't need a disable signal, but some funny OS could actually set CR3 to zero? The only case I've seen is when building Zephyr with MMU=disable, in which case the CR3 filter does not matter.

Thank you.
But if I set code range and not set CR3 filter, some code is traced well but windows go hang and trace go infinite loop.
Do you know why windows go hang?

Trace decoding without enabled CR3 as well as IP filters is not supported or even tested. I guess that this is also the reason why the decoding results in an infinite loop.

Thank you


Support for uploading videos to Stream

If the API already exists...

Still working on it: https://www.microsoft.com/en-us/microsoft-365/roadmap?filters=In development&searchterms=Stream


Camera Flip

Camera flips after opening and closing the editor so it shows the view behind the car upside down. Resetting the scene does not fix the camera either. The only way to fix it that I've found so far is to hit reset then open the editor which I assume flips the flipped camera back to the proper orientation.

I believe this is resolved with #183


Docs: Added notes on using RequestInspector and ResponseInspector (#1…

…153)

Added inspector docs

Fix up feedback to invoke in correct order

[ ] The purpose of this PR is explained in this or a referenced issue.
[ ] The PR does not update generated files.

These files are managed by the codegen framework at Azure/autorest.go.

[ ] The PR targets the latest branch.
[ ] Tests are included and/or updated for code changes.
[ ] Updates to CHANGELOG.md are included.
[ ] Apache v2 license headers are included in each file.

Can one of the admins verify this patch?


Error while renaming image with Chinese characters

Describe the bug
While trying to rename the filename with Chinese characters, it shows blank in the new name result field
Environments (please complete the following information):

OS: [Windows]

Screenshots
If applicable, add screenshots to help explain your problem.

我也是遇到了这个问题

While trying to rename the filename with Chinese characters, it shows blank in the new name result field
I had the same problem.

The fix for this issue has been released in 1.5.1


[Bug Report] tag component css mess when used with v-for

Element UI version
1.2.9
OS/Browsers version
Window/Chrome
Vue version
2.3.2
Reproduction Link
https://jsfiddle.net/bo85xyas/
Steps to reproduce
Just check the display tags, Maybe the transitions cause the problem
What is Expected?
should got some px between tags
What is actually happening?
tags are connected

Same happens with dynamic tags. Also new tag input gets width 100%

Quick fix:
    .el-tag {
        margin-right: 5px;
    }

    .input-new-tag {
        width: auto;
    }

@IamFive you can remove the space between el-teg like this https://jsfiddle.net/bo85xyas/1/.
then define the style.

@pengchongfu  oh.. thx for the information. Should add a default margin-right style  will be cool


Install script not working on Fedora

The Fedora distro is a famous choice by developers!
Developer -> KiCAD, Developer -> Fedora ;)

What does this mean?

executing
bash -c "$(curl -fsSL https://raw.githubusercontent.com/leoheck/kiri/main/install_dependencies.sh)"

outputs
Error: Unknown system
Please, ask KiRI dev to adapt the dependencies installer

install_dependencies.sh does not contain any calls of dnf (default packet manager in fedora) so i guess it's not a bug but generally not supported yet.

I've not been successful tweaking the script for fedora so far.
Most stuff, most notable the compiling part, works but .local/share/kiri is not created.
Unfortunately i'm not familiar with these build tools.

Yes, the installer does not work on Fedora. No one has asked this yet.

install_dependencies.sh does not contain any calls of dnf (default packet manager in fedora) so i guess it's not a bug but not yet implemented.

Yes. I will give it a try. And the I will let you know so you can check if it works, coll?

Which version of Fedora are you using?

There is something working already... if you want to check...
The schematics worked for me. Still have to check missing dependencies for the layout part.

Ah, the wrong version of rename is in use. It has to be the perl rename (prename). I have to think on how to fix this.

Alright, for me it is working already, tested on Fedora 37.
If you have issues running other version, please, let me know.

I'm on fedora 36, this may be the reason.
wxpython does not want to upgrade due to locked packages i guess:
cannot import name 'Mapping' from 'collections' (/usr/lib64/python3.10/collections/__init__.py)
Since fedora 37 release is around the corner so i switch and hope python is refreshed and things work then ;)

What are you trying to do?
Just run the install dependencies and then install the tool and run it.
It is working for me.
I installed in a clean fresh Fedora that was downloaded yesterday.

Kicad-Diff (the piece that generates layouts) uses WxWidgets to run graphically, but Kiri does not need that, it runs it without the GUI. So, maybe you can ignore this.

Could you test if it is already working?

Hey @leoheck. Upgraded to fedora 37 today and now kiri installs fluidly.
I've also tested 2 weeks ago with fedora 37 in gnome-boxes but didn't work... but who cares anymore.
Such a nice tool - Thank you!!!

but who cares anymore.

haha
Awesome, glad it worked right out of the box this time.


Port some templates from strings -> JSX

I'm interested in using hastscript + JSX for some of the tsconfig templates. This is a cosmetic change: It shouldn't change the website HTML at all.
We're already parsing Markdown -> ASTs and stringifying them -> HTML (remark-html wraps mdast-util-from-markdown and hast-util-to-html). Whereas currently we stringify the ASTs -> HTML and then stitch those strings together, I'd like to reverse those steps: Stitch the ASTs together and then stringify the amalgamation.
I think the advantages are:

Unlike strings, the ASTs have some type information, so this might catch some errors at compile/run time. #2014 flipped </tr>/</td> ...
Unlike strings, the AST nodes' meaning isn't reinterpreted depending on their context, e.g.

There's no risk of interpreting HTML nodes as code blocks: #2007
Leading/trailing newlines don't change the interpretation of Markdown inside HTML. The stringifier emits the appropriate whitespace for nested nodes' intrinsic types.

Sorry dude, I think this is going a bit too far from my general level of technical complexity in the website tooling - there's going to be a time when I'm not the key person maintaining this repo and I really don't want that next person to end up needing to figure out this section as a unique area with different rules.
I do think it makes sense in general, but dumb string appending is dumb string appending - it's why I don't write the website as a series of react components because the rest of the team (generally) hasn't written anything but sample repros in React

I'm grateful for your reviews! Is the first commit (Use ESM) mergeable on its own? (It's a chore that will need doing sometime?)
I like .tsx syntax partly because we're already using all of the pieces (almost):

For building HTML with JavaScript, JSX is common.
TypeScript is sufficient to compile away the JSX: React isn't involved.
If .tsx syntax is acceptable, we can't get any simpler than compiling to hast, I think, given we're already using hast/mdast/remark.

And it moves opening and closing tags to the same expressions, which helps the next person to edit the markup, I think:
Base
https://github.com/microsoft/TypeScript-Website/blob/7e4d8016f48c3e233aa9a728e8379550d402500d/packages/tsconfig-reference/scripts/cli/generateMarkdown.ts#L49-L122
Head
<tbody> nicely balanced: https://github.com/microsoft/TypeScript-Website/blob/e02e663edc4245981035189f91abfa28b1e440ac/packages/tsconfig-reference/scripts/cli/generateMarkdown.tsx#L140-L155
But yeah, sticks out like a wart if we continue preferring the string appending pattern everywhere else, and my string appending gripes (subtly significant whitespace, no syntax checking) aren't the biggest of deals. :+1:

Sorry for the delay, yep the ESM change is cool - I'm a little wary of something like     "generate:json": "yarn generate:json:tsconfig && yarn generate:json:cli && yarn generate:json:schema && yarn generate:json:msbuild", causing 4 separate builds, but I think because you're using --build it will basically NOOP

:+1: Yep that's what I had in mind, that --build will only run once.
I'll open a PR for just the ESM commit.

I think 2 years on, a PR for this would need to be rewritten and reconsidered; the PR now has a lot of unsolved conflicts and we're even more strapped for resources to keep the website running.
I'm going to close this PR, but if you think you're still going to do the work, we can reconsider it separately.


Add WebSocket installation to snippet

Since otherwise, trying to run that snippet throws an Exception on startup that WebSocket is missing :)

Hi, @SebastianAigner ! This was fixed in 0.2.1 I believe, so we can close this PR.


Organise storybook

Components like the Avatar, Textfield and others can be put into storybook one by one.

@andreaowu has pointed out components are disorganised and there's risk of duplication of work / lack of clarity.
I am thinking to organize storybook like this:
Components
Small

Button
Textbox
ScoreBar (?)
Smaller components/our versions of Mui Components

Large

UserSummary
Dialog
Map
Other "larger" pieces of UI than appear across different pages
I realize the distinction may be a bit blurred

1. Public Profile
Components in that page
2. Messages
...
3-x. Other pages in the figma design
...


Error: couldn't start client Python Tools

Environment data

VS Code version: 1.28.1
Extension version (available under the Extensions sidebar): 2018.9.0
OS and version: macOS 10.13.6
Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.0 Anaconda
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Relevant/affected Python packages and their versions: the main Python plugin

Actual behavior
I started using VSCode a few days ago and when I fist downloaded it, it was working perfectly with the Python plugin. Then the next day when I opened VSCode, it gave me the notification "Couldn't start client Python Tools."  I am unable to open a Python terminal in VSCode or run any Python code in VSCode.
Logs
Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)
Starting Microsoft Python language server.
[Error - 1:56:00 PM] Starting client failed
Error: spawn EACCES
	at _errnoException (util.js:1024:11)
	at ChildProcess.spawn (internal/child_process.js:323:11)
	at Object.exports.spawn (child_process.js:514:9)
	at _getServerWorkingDir.then.serverWorkingDir (/Users/micamccall/.vscode/extensions/ms-python.python-2018.9.0/node_modules/vscode-languageclient/lib/main.js:347:40)
	at <anonymous>

Output from Console under the Developer Tools panel (toggle Developer Tools on under Help)
 INFO no standard startup: not the explorer viewlet
TMSyntax.ts:47 Overwriting grammar scope name to file mapping for scope source.yaml.
Old grammar file: file:///Users/micamccall/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/extensions/yaml/syntaxes/yaml.tmLanguage.json.
New grammar file: file:///Users/micamccall/.vscode/extensions/redhat.vscode-yaml-0.0.17/syntaxes/yaml.tmLanguage.json
e.register @ TMSyntax.ts:47
console.ts:136 [Extension Host] Python Extension: Get language server folder name, , Return Value: "languageServer.0.1.42"
console.ts:136 [Extension Host] error: Unhandled Rejection at: Promise [object Promise]. Reason: Error: spawn EACCES.
t.log @ console.ts:136
notificationsAlerts.ts:42 Couldn't start client Python Tools
t.onDidNotificationChange @ notificationsAlerts.ts:42
console.ts:136 [Extension Host] rejected promise not handled within 1 second
t.log @ console.ts:136
mainThreadExtensionService.ts:43 [ms-python.python]spawn EACCES
e.$onExtensionRuntimeError @ mainThreadExtensionService.ts:43
mainThreadExtensionService.ts:44 Error: spawn EACCES
	at _errnoException (util.js:1024:11)
	at ChildProcess.spawn (internal/child_process.js:323:11)
	at Object.exports.spawn (child_process.js:514:9)
	at _getServerWorkingDir.then.serverWorkingDir (/Users/micamccall/.vscode/extensions/ms-python.python-2018.9.0/node_modules/vscode-languageclient/lib/main.js:347:40)
	at <anonymous>

Looks like the permissions have not been setup for execution of the language server.

Please could you try to manually set this up, with exec permissions 0765 for the file:
/Users/micamccall/.vscode/extensions/ms-python.python-2018.9.0/languageServer.0.1.42/Microsoft.Python.LanguageServer

If that doesn't work,

Quit VS Code
Delete the languageServer.0.1.42 from the above directory.
Reload VS Code.
Ensure a python file is opened
Wait until the necesary files are downloaded and extracted (you should see the progress displayed on the bottom left status bar)
Finally, test
If it still fails, upload the contents of the Python Output panel and console window (as you have done earlier)

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.

For the sake of anyone else who might read this in the future - I had the same issue with latest VSCode and Python extension and the instructions by @DonJayamanne helped.
My VSCode was installed via brew cask so I wonder if that might be related to the problem.

Environment data
VS Code version: 1.21.1
Extension version (available under the Extensions sidebar): 2018.4.0
OS and version: Windows 7
Python version (& distribution if applicable, e.g. Anaconda): 3.6.5 Anaconda
Type of virtual environment used (N/A | venv | virtualenv | conda | ...): conda
Relevant/affected Python packages and their versions: Python Extension (possible Python Extension Pack)
Expected behaviour
No errors
Actual behaviour
I have similar error.  This happened after I updated VSCode to the latest version.  I decided I did not like the new version.  I uninstalled it and reinstalled the older version.
"Couldn't start client Python Tools" notif.
I had no issues prior to updating.
Steps to reproduce:

Open VSCode
Access a python file

Logs
Output for Python in the Output panel ...
[Error - 6:27:09 PM] Starting client failed
Launching server using command dotnet failed.

Output from Console under the Developer Tools ...
  ERR spawn dotnet ENOENT: Error: spawn dotnet ENOENT
    at exports._errnoException (util.js:1050:11)
    at Process.ChildProcess._handle.onexit (internal/child_process.js:193:32)
    at onErrorNT (internal/child_process.js:367:16)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
log.ts:171   ERR Cannot read property '_reject' of undefined: TypeError: Cannot read property '_reject' of undefined
    at reject (C:\Users\...\.vscode\extensions\ms-python.python-2018.4.0\out\client\common\helpers.js:38:13)
    at <anonymous>

Kudos on this template.

@pylang you have a very old version of the extension and vscode, please update them.

I'd love to update mainly to test the new Jupyter features, but the new VSCode simply lags on my machine.  I can hardly type a line without it hanging.  Since I didn't have issues prior, I reverted.   As mentioned, this issue only arose after I updated.
Thanks anyhow.


No notice time for reservations

Expected behavior:
You should be able to set advance notice in order to make a reservation
Actual behavior:
It is not possible to set advance notice for reservations; at this moment it is possible to make a reservation up to one minute before the reservation time. For example, you can make a reservation at 11:59 am by selecting the 12 pm timeslot
Version:
v3.0.4-beta.25.2

Should be fixed as part of https://github.com/tastyigniter/ti-ext-reservation/pull/7

Closing, see #617