[SPARK-29320][TESTS] Compare sql/core module in JDK8/11 (Part 1)

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/16646/
Test PASSed.

Test build #111650 has started for PR 25992 at commit 98bb243.

Test build #111650 has finished for PR 25992 at commit 98bb243.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/111650/
Test PASSed.

Woah .. huge PR but +1 from a cursory look

After resolve the conflicts, I'll regenerate the result and reopen this.

Oops. Rebasing and force-pushing seems to lose the track.

https://github.com/apache/spark/pull/26003 is made.


ULX3S and mouse

I placed all my ULX3S support in one commit.
in the next commit I added mouse support which demonstrates
its usage by moving the crosshair pointer and it can change
trigger level by rotation of the mouse wheel.
I tried to be more cleaner this time to minimize interventions in
your code.

thanx for the merge, some problems are still here
strange github slightly messed stuff
I will try to fix them to compile
On 5/25/19, Miguel Angel<EMAIL_ADDRESS>wrote:

hdl4fpga commented on this pull request.
Mouse support by emard
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/hdl4fpga/hdl4fpga/pull/11#pullrequestreview-242011456

Thanks for your contribution

Thanks also to you for this great scope project
Here's another small pull request that should be fixing it
i compiled and it works both serial and mouse together
with daisy
can you send me some email to<EMAIL_ADDRESS>for exchanging postage addresses for ulx3s board
On 5/25/19, Miguel Angel<EMAIL_ADDRESS>wrote:

Thanks for your contribution
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/hdl4fpga/hdl4fpga/pull/11#issuecomment-495939845

I've sent you the email
thanks
On Sat, May 25, 2019 at 3:52 PM emard<EMAIL_ADDRESS>wrote:

Thanks also to you for this great scope project
Here's another small pull request that should be fixing it
i compiled and it works both serial and mouse together
with daisy
can you send me some email to<EMAIL_ADDRESS>for exchanging postage addresses for ulx3s board
On 5/25/19, Miguel Angel<EMAIL_ADDRESS>wrote:

Thanks for your contribution
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
https://github.com/hdl4fpga/hdl4fpga/pull/11#issuecomment-495939845

—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/hdl4fpga/hdl4fpga/pull/11?email_source=notifications&email_token=ACYCMOJTW7XS7XSM4HMLCGLPXGDGFA5CNFSM4HOA4PT2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWHXH7I#issuecomment-495940605,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACYCMOJQW2GBBEZ6TFFVC2DPXGDGFANCNFSM4HOA4PTQ
.


[Wallet] Handle /v/<code deep links for phone verifications

Description
Add handling of deep links for phone number verification.
Tested
Ran on Android device and iPhone
Other changes

When user tries to enter the same code after app was restarted - it would tell that code has been already used (previously it would say "Invalid code").
Change verification SMS template
Add support for deep links for iOS

Related issues

Fixes #896

Backwards compatibility
Not sure, attestation service should be redeployed AFTER we rolled out new app versions.

@jeanregisser I have addressed the comments - PTAL.


Core objects, and after that

The work in the "coreobjects" branch is almost done, save the last object that should encapsulate every other object.
This is a pseudo-roadmap of what needs to be done afterwards:

[x] Migrate the JDL parser here;
[x] Test it;
[x] Migrate the EntityCreator here and adapt it to be able to generate JSON from JDL;
[x] Test it and fix some bugs;
[x] Expose the generation;
[ ] Update every other project that depend on this project.

@deepu105 As I said, it's almost done. I think I might be able to merge the branch and migrate the entity creator by the end of the week at worst... I don't have as much time as planned, and tests take a lot of time...

Its ok Mathieu ill wait for your merge
On 8 Jun 2016 04:15, "Mathieu ABOU-AICHI"<EMAIL_ADDRESS>wrote:

The work in the "coreobjects" branch is almost done, save the last object
that should encapsulate every other object.
This is a pseudo-roadmap of what needs to be done afterwards:

Migrate the EntityCreator here and adapt it to be able to generate
JSON from JDL;
Fix some bugs;
Expose the generation;
Update every other project that depend on this project.

@deepu105 https://github.com/deepu105 As I said, it's almost done. I
think I might be able to merge the branch and migrate the entity creator by
the end of the week at worst... I don't have as much time as planned.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jhipster/jhipster-domain-language/issues/28, or mute
the thread
https://github.com/notifications/unsubscribe/ABDlF9VptuTTKT41q9F5QNZrzN2_1fr0ks5qJdF9gaJpZM4IwUNE
.

@deepu105 I've merged the dslparser branch into master. Only a couple of tests need doing (and a few issues to close ASAP). Can you test the project with your subgen?

If its ready please proceed to release. I might not have time this week to test. Ill do it next week and release a sub gen update

Everything's working for me, so I'll make a release tonight after taking care of #26.

Closing this as I'm making a release.


Django settings of static and media?

Context

Hi, I want to make a Django serverless web via zappa in AWS.
I succeeded to deploy Django serverless web and I can access to the url, but I have a problem with static and media.
How should I write the setting for static and media? Currently, I use Elastic Beanstalk to deploy the web and wrote the setting of S3Boto3Storage for static and media. What should I change in this settings?
    from storages.backends.s3boto3 import S3Boto3Storage

    class StaticRootS3Boto3Storage(S3Boto3Storage):
        location = 'static'

    class MediaRootS3Boto3Storage(S3Boto3Storage):
        location = 'media'
        file_overwrite = False

    STATICFILES_STORAGE = 'myproject.settings.StaticRootS3Boto3Storage'
    STATIC_URL = 'https://s3-ap-southeast-1.amazonaws.com/myproject/static/'

    DEFAULT_FILE_STORAGE = 'myproject.settings.MediaRootS3Boto3Storage'
    MEDIA_URL = 'https://s3-ap-southeast-1.amazonaws.com/myproject/media/'

    COMPRESS_STORAGE = STATICFILES_STORAGE
    COMPRESS_URL = STATIC_URL

Steps to Reproduce

zappa update web

Your Environment

Zappa version used: 0.48.2

Operating System and Python version: 3.6

The output of pip freeze:
argcomplete==1.9.3
awsebcli==3.15.3
blessed==1.15.0
boto3==1.9.141
botocore==1.12.141
cached-property==1.5.1
cement==2.8.2
certifi==2019.3.9
cfn-flip==1.2.1
chardet==3.0.4
Click==7.0
colorama==0.3.9
Django==2.1.7
django-appconf==1.0.3
django-bootstrap-pagination==1.7.1
django-bootstrap4==0.0.8
django-compressor==2.2
django-libsass==0.7
django-sass-processor==0.7.3
django-storages==1.7.1
docker==3.7.3
docker-compose==1.23.2
docker-pycreds==0.4.0
dockerpty==0.4.1
docopt==0.6.2
docutils==0.14
durationpy==0.5
future==0.16.0
gunicorn==19.9.0
hjson==3.0.1
idna==2.7
jmespath==0.9.3
jsonschema==2.6.0
kappa==0.6.0
lambda-packages==0.20.0
libsass==0.18.0
mysqlclient==1.3.12
pathspec==0.5.9
Pillow==5.4.1
placebo==0.9.0
psycopg2==2.7.7
PyMySQL==0.9.3
python-dateutil==2.6.1
python-slugify==1.2.4
pytz==2018.9
PyYAML==3.13
rcssmin==1.0.6
requests==2.20.1
rjsmin==1.0.12
s3transfer==0.2.0
semantic-version==2.5.0
six==1.11.0
sorl-thumbnail==12.5.0
sqlparse==0.3.0
termcolor==1.1.0
texttable==0.9.1
toml==0.10.0
tqdm==4.19.1
troposphere==2.5.1
Unidecode==1.1.1
urllib3==1.24.1
wcwidth==0.1.7
websocket-client==0.56.0
Werkzeug==0.16.0
wsgi-request-logger==0.4.6
zappa==0.48.2

Link to your project (optional):

Your zappa_settings.py:
{
"web": {
"aws_region": "ap-southeast-1",
"django_settings": "myproject.settings",
"profile_name": "myproject",
"project_name": "myproject",
"runtime": "python3.6",
"s3_bucket": "zappa-myproject",
"exclude": ["media"]
}
}

It seems like this setting also works on zappa serverless server!


Copy pfsync0 MTU from real interface

in some situation, like OpenStack, mtu is less then default (1500) and
it cause replication issue
we have noticed on a low used firewall with 2/3k State table size more
then 100k State table size on the backup server
copy mtu from real interface fix this issue

Looks reasonable. I would split off the mtu statement as a second call so the carp init doesn’t fail if the mtu is wrong or empty.

If this is ok for @adschellevis I’ll merge next week with a few cleanups in this area it of this PR scope.

@fichtner it looks good to me, maybe default to 1500 (or not setting the mtu) when the parent mtu can't be found for some odd reason.

Good idea, will do 😊

Merged, thanks!


Copy-DbaSsisCatalog returns error about assembly not being loaded

Before submitting a bug report:

[x ] Ensure you are able to reproduce it on the latest released version (we release often)
[ x] Verified this bug is not already reported in an issue
[ x] Verified errors are not related to permissions
[x ] Can reproduce in a clean PowerShell session (clean = powershell -NoProfile)

Steps to Reproduce
<#
    Copy-DbaSsisCatalog -Source sourceserver -Destination destinationserver
#>

Expected Behavior
actual copy of the catalog folders, projects and environments
Actual Behavior
WARNING: [14:52:41][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:41][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:41][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:41][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:41][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:41][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:41][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:42][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:42][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:42][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:42][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:42][Copy-DbaSsisCatalog] Issue creating folder | Cannot find type [.CatalogFolder]: verify that the
assembly containing this type is loaded.
WARNING: [14:52:42][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:42][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:42][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:42][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:43][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:43][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:43][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:43][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:44][Invoke-PrjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:44][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:44][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:44][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:44][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:44][Invoke-ProjectDeployment] Failed to deploy project. | You cannot call a method on a null-valued
expression.
WARNING: [14:52:44][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:44][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:44][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:44][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:44][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:45][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:45][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:45][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:45][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:45][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:45][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:45][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:46][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:46][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:46][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
WARNING: [14:52:46][Copy-DbaSsisCatalog] Issue deploying environment | Cannot find type [.EnvironmentInfo]: verify that
the assembly containing this type is loaded.
Environmental data

PowerShell: Name                           Value

PSVersion                      5.1.14393.2125
PSEdition                      Desktop
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0...}
BuildVersion                   10.0.14393.2125
CLRVersion                     4.0.30319.42000
WSManStackVersion              3.0
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>

SQL Server:
Source server : Microsoft SQL Server 2012 (SP3-CU10-GDR) (KB4057121) - 11.0.6615.2 (X64)   Jan  9 2018 21:26:48   Copyright (c) Microsoft Corporation  Standard Edition (64-bit) on Windows NT 6.1  (Build 7601: Service Pack 1) (Hypervisor)
Target server : Microsoft SQL Server 2012 (SP3-CU10-GDR) (KB4057121) - 11.0.6615.2 (X64)
Jan  9 2018 21:26:48
Copyright (c) Microsoft Corporation
Standard Edition (64-bit) on Windows NT 6.3  (Build 9600: ) (Hypervisor)

thank you for the report!

As a workaround, add the following line to your powershell script prior to calling Copy-DbaSsisCatalog:
$ISNamespace = "Microsoft.SqlServer.Management.IntegrationServices"

That is all I added to get it to work.  Looking at the code for the function it is calling "$ISNamespace.CreateFolder" and the error is '.CreateFolder' - so the issue is that $ISNamespace hasn't been set for this function.

that'd be awesome if that is the fix! ill take a look in a bit


KAFKA-3680: Enable Kafka clients to run in any classloader env

Configure default classes using class objects instead of class names, enable configurable lists of classes to be specified as class objects, add tests for different classloader configurations.

+1

@harshach Thank you for the review.
Have moved KIP-60 to approved state and rebased this PR. Also added another unit test.

@ijuma Would you be able to take a look at this when you have some time? Thank you...

This is causing some complications for us running within Tomcat 8. Is there is a timeline for this to get released?

@lightswitch05 Hoping to get this into the next (0.10.1) release, I am not sure of the timeline. @ijuma Does this need more reviews - if so can you suggest someone? Thank you...

Yes, we should be able to get this into the next feature release. I haven't had the time to check the tests properly, so that's why I haven't merged it yet. If another committer gets there first, then they can merge it, of course.

@ijuma Pinging for review, just in case it's been forgotten. Thanks in advance.

@rajinisivaram, sorry for the delay. I left a question about the producer/consumer test. The rest looks good.

Thanks for the PR, LGTM.

Tests passed locally, merged to trunk.


Updates for eosio/eos [slim] branch

slim branch update (work in progress)
https://github.com/EOSIO/eosjs/commit/5d984d3bfffcdc9e09adc27b3320afa958797608

All tests pass, however, changes so far depends on a eosjs-ecc npm pakcage upgrade (this has not been pushed yet).

work in progress, merged to master


Release/0.4.0

What

Added script to import region area data into Mongodb, and update script to upsert from insert

How to review

Check only changes to the script have been included

Who can review

Anyone

As this is a script for the moment I have not added any unit tests


Updated behavior/events for text/password

#minor#
I need to move on to a few other high priority items, so as long as it's acceptable to everyone I'll raise issues to add tests and add propTypes for text/password
CHANGELOG
Text/Password native event support

Mapped all available DOM events to Frost events (e.g. focusIn -> onFocusIn) see the demo for a full list
Event hooks respond with native DOM events instead of {id, value} object, this is still supported as a legacy usage, but please switch (no way to detect when the legacy attributes are used unfortunately)
Deprecated onFocus (replaced by onFocusIn)
Deprecated onBlur (replaced by onFocusOut)
Removed the excludedEvents property from the FrostEvents mixin, this is covered automatically when local events are present

Text/Password visual and behavioral updates

Added a new color (grey-7) to the palette for input borders
Updated the visuals and animation for hover, focus, clear and show/hide

Text/Password demo updates

Demos demonstrate legacy, native, text support and deprecated events
Updated the text/password demos to use snippets

New keycodes util

Added a keycodes enum for use in matching keycodes from keyboard events

Code cleanup

Integrated ember-concurrency for async behavior in text/password (clear text, show/hide password)
Text/password actions are fully run-loop compliant and clean up automatically on component destruction

Future

Moving towards dropping ember-one-way-controls from the dependency list (requires Ember 2.3.1+)

:+1:


Allow relative path with swift package add-dependency command

Enable passing relative path into swift package add-dependency
Motivation:
Currently only AbsolutePaths are supported with --type path flag
swift package add-dependency /packagePath --type path

There is a need to support RelativePath because it's not uncommon to have a package structure inside of an xcodeproj as shown below.
LocalPackages
├── ChildPackage
│   ├── .gitignore
│   ├── .swiftpm
│   ├── Package.swift
│   ├── Sources
│   └── Tests
└── ParentPackage
    ├── .build
    ├── .gitignore
    ├── .swiftpm
    ├── Package.swift
    ├── Sources
    └── Tests

If we want to open ParentPackage by itself, it will not be able to resolve that package.
This pr allows for the user to add a package with a RelativePath path via the swift package add-dependency --type path command.
Access level for

.package(name:url:requirement:traits:)
.package(name:url:requirement:)
.package(id:requirement:traits:)

were upgraded from private to package allowing access to these functions from the PackageCommands module.
Modifications:

Enable passing relative path into swift package add-dependency
Add unit test coverage

Result:
Both of the following commands are valid
swift package add-dependency ../relative --type path

swift package add-dependency /absolute --type path

@bnbarham Just wanted to bump this.

Thanks @hi2gage! Definitely valuable to support relative paths here.

Due to access level and not wanting to make certain enums public, I opted to use MappablePackageDependency instead of Package.Dependency to represent the values coming from the CLI command.

Which enums would those be? Ideally MappablePackageDependency would not be public, it really shouldn't be visible to commands.

I believe it was to keep Package.Dependency.SourceControlRequirement and  Package.Dependency.RegistryRequirement private. See comment:
// intentionally private to hide enum detail
private static func package(
        name: String? = nil,
        url: String,
        requirement: Package.Dependency.SourceControlRequirement
    ) -> Package.Dependency {
        return .init(name: name, location: url, requirement: requirement, traits: nil)
    }

but looking back over this again I realized this was written prior to the package access level being introduced. Any reason to not move these 3 functions from private to package?

I thought I would need to make Package.Dependency.SourceControlRequirement and Package.Dependency.RegistryRequirement public, but I avoided doing so because of these comments:

Aren't they already 🤔? I assume the issue was that there's no way to create a Dependency with them today, but couldn't you call the existing initializers (which end up mapping to these)?

Any reason to not move these 3 functions from private -> package?

If they need to be (depending on the above) - they just can't be public as this is the package manifest API.

Hey @bnbarham I just pushed up the changes to use Package.Dependency so we can talk specifics.

I thought I would need to make Package.Dependency.SourceControlRequirement and Package.Dependency.RegistryRequirement public, but I avoided doing so because of these comments:

Aren't they already 🤔?

Yes they are public 🤦I meant to say:
I thought I would need to make the Dependency initializers that contain those enums public. Not the enums themselves public.

I assume the issue was that there's no way to create a Dependency with them today, but couldn't you call the existing initializers (which end up mapping to these)?

Technically I could call the existing initializers, but it requires some funky switching. The changes I just pushed uses the existing initializers. So let me know what you think about that.
This being said if I made those initializers package access level I could take this code:
let packageDependency: PackageDescription.Package.Dependency
switch (firstRequirement, to) {
case (let .exact(version), nil):
    packageDependency = .package(url: self.dependency, exact: version)
case (let .range(range), let to?):
    packageDependency = .package(url: self.dependency, (range.lowerBound ..< to))
case (let .range(range), nil):
    packageDependency = .package(url: self.dependency, range)
case (let .revision(revision), nil):
    packageDependency = .package(url: self.dependency, revision: revision)
case (let .branch(branch), nil):
    packageDependency = .package(url: self.dependency, branch: branch)
case (.branch, _?), (.revision, _?), (.exact, _?):
    throw StringError("--to can only be specified with --from or --up-to-next-minor-from")
case (_, _):
    throw StringError("unknown requirement")
}

->
let packageDependency2: PackageDescription.Package.Dependency = .package(
    url: self.dependency,
    requirement: requirement,
    traits: []
)

Any reason to not move these 3 functions from private -> package?

If they need to be (depending on the above) - they just can't be public as this is the package manifest API.

Agreed, they can't be public, making them package would be helpful but we can get around it if you want to keep those initializers locked down.

I'd be fine making them package, especially to avoid that switch 😅 . @dschaefer2 / @plemarquand any opinions?

I'd be fine making them package, especially to avoid that switch 😅 . @dschaefer2 / @plemarquand any opinions?

Great! I just pushed up changes making those package.

@bnbarham Just wanted to bump this, let me know if there is anything I can to help move this PR along.

@swift-ci please test

@swift-ci please test windows

@hi2gage that did the trick. Running the tests now. I'm a little worried about adding the PackageDescription dependency since it was really only intended for the package manifest processing, but it actually makes sense how you're using it.
This is actually pretty timely. We've been working at improving support for monorepos where relative packages are common. This will help setting them up.

Hmm, the toolchain build in the smoke tests and the Windows builds are failing. Look like the new dependency on SwiftSyntax requires a change to the CMake files (which are used to build swiftpm in these environments).

Hmm, the toolchain build in the smoke tests and the Windows builds are failing. Look like the new dependency on SwiftSyntax requires a change to the CMake files (which are used to build swiftpm in these environments).

It's just that PackageDescription+Syntax.swift needs to be added to the cmake build (and the old PackageDependency+Syntax.swift removed).

Hmm, the toolchain build in the smoke tests and the Windows builds are failing. Look like the new dependency on SwiftSyntax requires a change to the CMake files (which are used to build swiftpm in these environments).

It's just that PackageDescription+Syntax.swift needs to be added to the cmake build (and the old PackageDependency+Syntax.swift removed).

Just pushed the changes to the cmake build

@hi2gage that did the trick. Running the tests now. I'm a little worried about adding the PackageDescription dependency since it was really only intended for the package manifest processing, but it actually makes sense how you're using it.
This is actually pretty timely. We've been working at improving support for monorepos where relative packages are common. This will help setting them up.

Yup, we have a monorepo at work so that's why I was motivated to fix this problem. I'm glad that I'm able to help out. If there are other issues / chunks of work in this realm let me know, I've really enjoyed contributing to SPM.

@swift-ci please test

@swift-ci please test windows

@swift-ci please test windows

@swift-ci please test windows

@swift-ci please test

@swift-ci please test windows

@swift-ci please test windows

@swift-ci please test windows

I'm not sure why the Windows build is breaking. It uses the CMakeLists file.

I'm not sure why the Windows build is breaking. It uses the CMakeLists file.

Yeah me neither I thought that bc39a72 would have fixed this error.
C:\Users\swift-ci\jenkins\workspace\swiftpm-PR-windows\swiftpm\Sources\PackageModelSyntax\AddPackageDependency.swift:14:8: error: no such module 'PackageDescription'

Is there a windows VM image or sorts to run this locally?

Looks like a missing dependency in the CMakeLists.txt file.

I'm trying on my Windows machine. There is a Utilities/bootstrap utility that builds using CMake. I couldn't reproduce it on my Mac, which is surprising.

@swift-ci please test

@swift-ci please test windows

@swift-ci please test windows

Don't worry about the branching. We'll work to get this into 6.1. Our CI has been under the weather the last few days.

Actually, they're going to set up an auto merge of main to releases/6.1 so it'll just go there automatically. I think they just wanted to branch the compiler now, which makes sense. It needs time to settle down.

@swift-ci please test

Sounds good! Any further action needed from me on this PR to get those windows tests passing?

@swift-ci please test windows

I am a little worried about adding the dependency from SwiftPM to PackageDescription. It seems a lot of effort was expended in the past to avoid that, including duplicating most of the types, which I agree is pretty annoying. I assume that was to keep it only for the package manifest library.
@bnbarham any thoughts there? Any toolchain build issue we may run into?

@bnbarham any thoughts there? Any toolchain build issue we may run into?

@neonichu probably has the best background there

Hmm, the Windows build is failing with the missing dependency. It builds with CMake as well.
Sorry for the delayed responses. Too many things on the go at once :(.

No worries at all. Holidays are a busy time for me. The more I think about this the more I think that making this as DRY as possible might more pain than it's worth.
Looking at PackageDescription+Syntax.swift really all we need is a model that resents  a dependency that is added.
Now it would have been convenient to use PackageDescription.Package.Dependency but maybe we just create a new model that will represent a dependency internally?
I propose we add a lightweight struct inside PackageModelSyntax that presents a dependence. Since PackageModelSyntax is a dependency of Commands then we can create this new model directly inside of SwiftPackageCommand.AddDependency
Thoughts on making this a little less DRY?
Example (Just copied the main properties that are required for this use case):
public struct Dependency {
    /// The type of dependency.
    @available(_PackageDescription, introduced: 5.6)
    public enum Kind {
        /// A dependency located at the given path.
        /// - Parameters:
        ///    - name: The name of the dependency.
        ///    - path: The path to the dependency.
        case fileSystem(name: String?, path: String)
        /// A dependency based on a source control requirement.
        ///  - Parameters:
        ///    - name: The name of the dependency.
        ///    - location: The Git URL of the dependency.
        ///    - requirement: The version-based requirement for a package.
        case sourceControl(name: String?, location: String, requirement: SourceControlRequirement)
        /// A dependency based on a registry requirement.
        /// - Parameters:
        ///   - id: The package identifier of the dependency.
        ///   - requirement: The version based requirement for a package.
        case registry(id: String, requirement: RegistryRequirement)
    }

    /// A description of the package dependency.
    @available(_PackageDescription, introduced: 5.6)
    public let kind: Kind
}

// MARK: - SourceControlRequirement

extension Dependency {
    @available(_PackageDescription, introduced: 5.6)
    public enum SourceControlRequirement {
        /// An exact version based requirement.
        case exact(Version)
        /// A requirement based on a range of versions.
        case range(Range<Version>)
        /// A commit based requirement.
        case revision(String)
        /// A branch based requirement.
        case branch(String)
    }
}

// MARK: - RegistryRequirement

extension Dependency {
    @available(_PackageDescription, introduced: 999)
    public enum RegistryRequirement {
        /// A requirement based on an exact version.
        case exact(Version)
        /// A requirement based on a range of versions.
        case range(Range<Version>)
    }
}

// MARK: - Version

public struct Version: Sendable {

    /// The major version according to the semantic versioning standard.
    public let major: Int

    /// The minor version according to the semantic versioning standard.
    public let minor: Int

    /// The patch version according to the semantic versioning standard.
    public let patch: Int

    /// The pre-release identifier according to the semantic versioning standard, such as `-beta.1`.
    public let prereleaseIdentifiers: [String]

    /// The build metadata of this version according to the semantic versioning standard, such as a commit hash.
    public let buildMetadataIdentifiers: [String]

the Command

Agreed. Does the PackageModel module contain types you could use?

Agreed. Does the PackageModel module contain types you could use?

Actually yes looking through the PackageModel module again MappablePackageDependency.Kind works perfectly.
Pushed up a new commit with that change. Tests are passing locally and no dependencies were added. So hopefully that passes the smell test.

@swift-ci please test.

@swift-ci please test windows

So much cleaner. Thank you!

@swift-ci please test windows


Make buttons for author and contributor sections easier to click

After having done 29 deposits recently, I've found that the radio buttons in the author/contributor section are hard to click on the first try. It feels like they should be bigger or the clickable area should be bigger.

@astridu What's the best way to improve this?

Could we try the next size up? I realize that will affect all radio button sizes, but maybe it would be a good thing for all of them to be slightly larger.

@jcoyne Does @astridu 's suggestion work here?

@astridu I think the problem here is a bigger accessibility issue.  Typically radio buttons have visible labels and you can click anywhere on the radio and it's adjacent label to select it. Our designs have no visible labels to click on.  Here are some examples: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/radio

Does something like this work? Could we use the slightly bigger red radio buttons instead of the smaller blue radio buttons?

@astridu I like the bigger buttons. And will the new text be clickable here too, not just the button? That would be helpful. I think this should still have the "OR" between the two, yes?
I'm wondering a bit about the bold treatment on that text, because I think that will be very different from the rest of the form, where we are only using the bold for the section headers. Will that look odd? Maybe not. Having bigger buttons and clickable text will certainly be helpful here.

I don't think it will look odd, and the bold will make it clear there are 2 options with form fields below them. And yes, the text should be clickable too.

@astridu what about the "Details" which is the accessible label for the radio group?

Sorry, forgot about that.

@astridu "Details" doesn't currently have an asterisk.  Do you want that to be added?

@astridu should the bold be consistent across all radio buttons? (e.g. "Single date"/"Date range") or is that only for "Enter Author Name", "Enter ORCID", " Upload files" and "I have uploaded my files to a Globus endpoint..."?

across all radio buttons. Thank you!


Where does thread_local! come from?

https://github.com/Deland-Labs/dfinity-fungible-token-standard/blob/10e6e12d57150d64ad00492561f5432f476a4f12/rust/dft_standard/src/state.rs#L4-L12
From which of these imports does thread_local! macro  come from?
use crate::token::*;
use dft_types::*;
use ic_cdk_macros::*;

It's come from std.
refs: https://mmapped.blog/posts/01-effective-rust-canisters.html


R&D: Queue options

As Hyrax uses active_job to support message queues, we have a few options to consider in implementing our own queue system. The two obvious candidates are:

Resque
Sidekiq

There is a mix of usage in the community, so we should probably do a little research and ask around for people's experience, particularly as it relates to larger batch processes (since that will be our primary usage of the queuing system). I believe Princeton is using Sidekiq for plum, so that's worth taking a strong look at.

After a decent amount of research, it seems pretty clear that Sidekiq is being used by the majority of the Rails community, and I've noticed new Hydra apps are using it s well. It is also noticeably faster and comes with an option for paid support (along with additional features) that we could evaluate in the future.
So perhaps we should adjust this ticket to adding in Sidekiq as the queue solution. @ucsdlib/developers  -- does that reasonable to you all?

@mcritchlow Sidekiq looks good and I am fine with it.

@lsitu since this overlaps with your work in #23 and #15 do you think it makes sense to break out any additional configuration/etc. into the scope of this ticket?

@mcritchlow Yes. It sounds good to break it out any additional configuration/etc. into the scope of this ticket. Thanks.

@mcritchlow I am able to setup Resque/Resque Pool and try to use it for CSV/Batch Ingest. I don't see any warnings/errors for ingest and it seems like that the records and thumbnails are showing up faster and in the orders of ingest, while using Sidekiq the order is messing up and often I need to wait longer time for all the records to be showing.
Would you like me to create two different PRs for Resque and Sidekiq configuration so that we all can evaluate them a little bit before making a decision?

@lsitu That's interesting. Given everything that I've read, I'd be very surprised for Resque to be faster than Sidekiq. Speed is one of the main things Sidekiq says is has over other solutions like Resque, Delayed Job, etc.. I suspect there might be configuration details, such as adding tweaking the priority of the queues,  setting explicit pooling setup for Sidekiq/Redis, etc. that we might still need to try out to get the most out of Sidekiq.
That said, evaluating both so we can make an informed decision sounds like a very reasonable plan to me 👍

@mcritchlow I think the problem is the warnings "Error while trying to deserialize arguments" which interrupt the ingest: https://github.com/ucsdlib/horton/pull/23#issuecomment-273218815. But yes, we can review the option later to see whether this warning still an issue or not.

@mcritchlow I've created PRs for Resque and Sidekiq.
The configuration for Sidekiq includes concurrency setting now. It seems that it's much faster for all records with thumbnails created to be showing up now. And I don't' the warnings like "Error while trying to deserialize arguments" (see https://github.com/ucsdlib/horton/pull/23#issuecomment-273218815). But often I see warnings like "TID-outhrreno WARN: ActiveRecord::StatementInvalid: SQLite3::BusyException: database is locked: commit transaction".  This could be the issue of the SQLite3 database that doesn't support concurrency, but there is a couple of times I saw an additional record ingested, which could be an issue.
Here is the warning I got:
2017-01-18T19:42:19.814Z 16271 TID-outh20vno IngestWorkJob JID-26359c56003473eece9d1444 INFO: fail: 5.365 sec
2017-01-18T19:42:19.814Z 16271 TID-outhrreno WARN: ActiveRecord::StatementInvalid: SQLite3::BusyException: database is locked: commit transaction
2017-01-18T19:42:19.814Z 16271 TID-outh20vno WARN: {"context":"Job raised exception","job":{"class":"ActiveJob::QueueAdapters::SidekiqAdapter::JobWrapper","wrapped":"IngestWorkJob","queue":"ingest","args":

@lsitu - ah, yep. SQLite can't do concurrent access as you noted. So it looks like we'll need to get it setup with a proper postgres DB.
I think the additional record ingest could be either an issue as a result of the concurrency we're seeing and SideKiq's attempt to retry, or a bug in one of the jobs as you noted. Sidekiq does make it pretty explicit that the jobs need to be idempotent, which is what makes me wonder if this issue will go away with a non-locking DB addressing a potential assumption on the part of the hyrax jobs. Definitely something we want to keep an eye on though, as like you said it could be a legitimate bug we'd need to report and/or look into.


https://keybase.pub/ not serving kbfs file

Using the keybase client (Client:  1.0.17-20160930202009+0229d49 Service: 1.0.17-20160930202009+0229d49) on Mac OSX El Capitan 10.11.16,
I've added keybase.txt to /keybase/public/vdice  and have confirmed that it exists:
$ ls /keybase/public/vdice/
keybase.txt

$ cat /keybase/public/vdice/keybase.txt
==================================================================
https://keybase.io/vdice
--------------------------------------------------------------------
<rest of file omitted>

Yet, the file does not appear to be served on https://keybase.pub/vdice/ :

Hi @vdice -- looks like you recently reset your account, and there's a known bug with KBFS (and keybase.pub in that case) where it continues to cache your pre-reset public folder.  I'll restart keybase.pub for you, which should pick it up.

Ok, looks good to me now.  Please close this if you agree.

Ah, thank you @strib!  Looks great; closing.


Update README.md and flags descriptions.

Nice, I think this is a definite improvement to the documentation 👍

@Fugiman Thanks. In the meantime I also added CI status badges. I'm going to merge this.


patch: heap-buffer-overflow

Given file A:
$ hexdump -C A
00000000  2b 2b 2b 20 22 0f 00 00                           |+++ "...|
00000008

ASAN reports a heap-buffer-overflow with:
$ toybox-0.8.9/bin/toybox patch "" "A"
patch: =================================================================
==1301==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x602000000052 at pc 0x000000497dbc bp 0x7ffcfeb83dd0 sp 0x7ffcfeb83580

Looking at it with gdb it seems to scan past filename:
#0  __asan::ReportGenericError (pc=4816316, bp=bp@entry=140737488346896, sp=sp@entry=140737488344768, addr=105690555220050, is_write=false, access_size=3, exp=0, fatal=false) at /tmp/llvm-130/compiler-rt/lib/asan/asan_report.cpp:461
#1  0x0000000000497ddf in printf_common(void *, const char *, typedef __va_list_tag __va_list_tag *) (ctx=ctx@entry=0x7fffffffdf30, format=format@entry=0x52a33a "bad %s", aq=0x7fffffffdf38)
    at /tmp/llvm-130/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors_format.inc:553
#2  0x000000000049886f in __interceptor_vfprintf(__sanitizer::__sanitizer_FILE *, const char *, typedef __va_list_tag __va_list_tag *) (stream=0x7ffff7ea16a0 <_IO_2_1_stderr_>, format=<optimized out>, ap=0x7fffffffe060)
    at /tmp/llvm-130/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:1661
#3  0x00000000004f9a9c in verror_msg (msg=0x52a33a "bad %s", err=0, va=0x7fffffffe060) at lib/lib.c:14
#4  0x00000000004f9cab in error_exit (msg=0x52a33a "bad %s") at lib/lib.c:49
#5  0x0000000000511012 in unquote_file (filename=0x602000000050 "\276\276") at toys/posix/patch.c:289
#6  0x0000000000510619 in patch_main () at toys/posix/patch.c:387

(found by KLEE)

What libc are you using? Because I think libc it's what's scanning past the end there?
In patch.c unquote_file() receives basically a 3 byte string with a quote, a low ascii character, and a NUL terminator. (The second nul terminator is irrelevant-ish, patch doesn't handle embedded nuls so it acts as a truncated string.) It notices the starting quote and loops searching for the ending quote, hits the NUl first, and passes the input string (unmodified) to error_exit("bad %s", filename) because of the unbalanced quotes, which does a vfprintf(stderr, msg, ...) to basically pass it the "bad %s" and filename argument on to the library printf plumbing?
Both strings are null terminated, we allocated enough space for them, and . Unless we've corrupted the heap before now (which I assume your sanitizer would have caught) I don't see how the toybox code could control what libc's printf() does with those two arguments?
And if there was something funky about how our filename() argument was allocated, your scrubber would have dinged upquote_file() traversing it before calling the error function? We called it because we found the terminating NUL without finding a matching quote, which means we read to the end of the string...
What did I miss? (Might still have some trailing dental drug residue, I was kind of out of it yesterday, but I'm not spotting it?)

I ran KLEE with 0.8.9, this was fixed by https://github.com/landley/toybox/commit/3309e660712dd064bd05db9323801a63588d58bd - sorry, should have checked before.


Switch mode network mock

In previous version of $cordovaNetwork mock you cannot test the switch to offline mode and viceversa. I've added two methods that will do that launching the right events through the rootscope.

@francesco-strazzullo thanks for the PR - however would you mind removing the build files from this PR? It causes future problems for merging PRs, so we generally ask that a PR only includes the changes  that belong in this feat/fix.

Ok I'll remove the build files right away

@pbernasconi I've removed the dist files but I can't figure out why the build is failed. I have all green tests on my machine.

@pbernasconi I've removed the dist files but I can't figure out why the build is failed. I have all green tests on my machine.

We had to upgrade our Jasmine instance. Thanks to #1174; it was fixed. Try again?

turns out if I close and re-open, I can trigger another build through Travis.
TIL.


Can see blinds in HomeKit but not responding

I have installed your very useful plugin and have setup the MOTION USB bridge.  I am able to control the blinds via the MOTION iOS App, but not via HomeKit.
The 3 blinds all appear in HomeKit (due to your code) but whenever I try to control them, nothing happens.  I have tried playing around with the "gatewayIp" address (and removing it entirely) but still no luck.
Any suggestions would be very welcomed!

Same problem here... sometimes they work (generally after restarting of the home bridge) and then they just stop working.
The only error visible is this:
[6/16/2021, 1:22:35 PM] [homebridge-motionblinds] This plugin generated a warning from the characteristic 'Target Position': characteristic value expected valid finite number and received "undefined" (undefined). See https://git.io/JtMGR for more info. [6/16/2021, 1:22:35 PM] [homebridge-motionblinds] This plugin generated a warning from the characteristic 'Target Position': characteristic value expected valid finite number and received "undefined" (undefined). See https://git.io/JtMGR for more info.

I just pushed a new version that may address the issue, please try updating to 1.2.0 and report back.

I have just add the plugin to HB. but without succes :(, i get the same massage: [homebridge-motionblinds] This plugin threw an error from the characteristic 'Target Position': Unhandled error thrown inside write handler for characteristic: Invalid key length. See https://git.io/JtMGR for more info.
also in the home app there is no connection.

This issue should be fixed in 2.0.0. Please reopen if you still encounter the issue.


Version 1.6.0, cannot be refreshed using Material3.PullToRefresh()

Describe the bug
Version 1.6.0, cannot be refreshed using Material3.PullToRefresh()
Affected platforms

Desktop

Versions

Kotlin version*: 1.9.22
Compose Multiplatform version*: 1.6.0
OS version(s)* : Win11
OS architecture (x86 or arm64): x86
JDK (for desktop issues): JDK 17

Additional context
Desktop: Nested scrolling is not working properly #653
https://developer.android.com/reference/kotlin/androidx/compose/material3/pulltorefresh/package-summary

It doesn't seem that linked #653 issue or 1.6.0 is really related. #653 is not included to 1.6.0, but even with this fix it will not trigger this logic because it explicitly waits dragging, but scrollable modifier disables dragging for mouse.

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.


[WIP] feat(core): implement pretty-printing of Recipes

Codecov Report
Attention: Patch coverage is 68.96552% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 85.50%. Comparing base (2c11224) to head (cd1c13d).

Files
Patch %
Lines

ibis_ml/utils/_pprint.py
7.69%
12 Missing :warning:

ibis_ml/core.py
81.81%
6 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #101      +/-   ##
==========================================
- Coverage   86.08%   85.50%   -0.58%
==========================================
  Files          21       22       +1
  Lines        1545     1601      +56
==========================================
+ Hits         1330     1369      +39
- Misses        215      232      +17

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Update ruby to 240

based on https://github.com/grpc/grpc/pull/8957
WIP as appears to work for 64-bit linux, not yet tested on all platforms
note this is waiting on google-protobuf 3.2 release, as this is also needed in order to run on ruby 2.4

@nicolasnoble @apolcyn Should we close this? I think this was superseded by https://github.com/grpc/grpc/pull/9507

yeah this was replaced by #9507


⚠ Game Join API Endpoint has degraded performance

In 32321ec, Game Join API Endpoint (http://gamejoin.roblox.com/) experienced degraded performance:

HTTP code: 503
Response time: 1090 ms

Resolved: Game Join API Endpoint performance has improved in 0a6ab77 after 12 minutes.


Edit creditCard number

steps to repro:

Enter more than 16 digit number
delete the last 3 digits..
In UI it shows 16 digit.. on form submit, the value is 17 digit.

I'm also seeing this, using Vue / Card v.2.4

I also facing same issue
Enter more than 16 digit number
delete the last 3 digits..
In UI it shows 16 digit.. on form submit, the value is 17 digit.

Fixed by adding this.
             <input md-input placeholder="Card number" type="tel" [(ngModel)]="model.cardNumber" (keyup)="setCardNumber($event)" name="number" #cardNumber='ngModel' required>
`setCardNumber( $event) {
    this.model.cardNumber=$event.target.value;

}`

There is a "cards" array below of the card.js you can modify the number of length to 16 from there.

I fixed this issue by adding.
<input md-input placeholder="Card number" type="tel" [(ngModel)]="model.cardNumber" (keyup)="setCardNumber($event)" name="number" #cardNumber='ngModel' required>
`  setCardNumber( $event) {
    this.model.cardNumber=$event.target.value;

}`


Add Free Art License

Free Art License 1.3

@xuv what does this license cover that the licenses already on ChooseALicense don't? Note that we already suggest Creative Commons for non-code works.

In terms of author's right, there is a difference between roman based code and english based code. This license was written in France and as such integrates a roman based version of the author's right such as the non-transferable moral rights while still being copyleft and compatible with a CC-BY-SA for example. Because of its European origin and particularity, it is sometimes the preferred choice for creators living in Europe over licenses originating from the US for example.
So although compatible with the Creative Commons Attribution Sharealike, they are different in philosophy and motivation for their own existence. And as such, this difference matters a lot for some creators.
There is also significant usage of it on Github (french and english version) for it to be included.

@xuv thanks for starting the discussion. How would you explain to a developer releasing their first open source project (with no background in copyright or open source licensing) why they should prefer the free art license ver CC-BY-SA?

@benbalter I would say it like this:
Compared to the CC-BY-SA, the Free Art License is much shorter text to read. It is written in a form that is easier to understand by anyone, without most of the usual lawyer vocabulary, while still having the same properties and benefits. The text of the license also ends with a user guide. All these benefits come because it was mostly written by artists and creators for themselves and their audience.
People might also prefer it because there is only one Free Art License and it does not require to understand the whole feature naming scheme of Creative Commons. Without any background in open source licensing, there is no doubt with the Free Art License about it's intent and use.

The immediate concern I see is that it doesn't have any of the "usual lawyer vocabulary"... yes, that makes licenses harder to read, but it's there for a reason and I worry that the Free Art License would be harder to enforce in court. (That being said, I'm certainly not an expert.)

@strugee "usual lawyer vocabulary" was maybe not the best comment from me regarding this license. It has been reviewed by lawyers and they have not made any remarks regarding this. It was a way for me to emphasize its easier reading. To compare, the MIT license is also easier to read than similar ones.
But I can ask the creators if there is any examples where the license may have already been challenged in court or similar.

Ah, OK. Gotcha.

I've asked the creators about any case where the Free Art License had been tested.
To their knowledge, there is only one case, that was solved rapidly, which involved a musician that had his music used in a documentary aired on french television, but that was not credited. Credits were added immediately after the complain and displayed in later broadcasts of the documentary.
The creators also insist on the reliability of the license as it is based upon the author's rights, so there is no problem regarding its validation or invalidation.

@xuv based on our new license criteria, the Free Art License will need an SPDX ID, but since it's on the OD list of approved licenses, once it has an SPDX ID, we can add it.

@benbalter Just submitted to SPDX. Will inform you of response.

Hi there, we intend to add this license to the SPDX License List, but need to first sort out how to handle the 8 variations/translations they list on their website.  I have contacted the license stewards and will let you know when I here back :)

Jilayne (SPDX Legal co-lead)

Hello @benbalter and others.
Thx to the work of the SPDX list and @jlovejoy, I'm pleased to announce here that the Free Art License has been added to the SPDX list.
After discussion with the license creators, the french version of the license is the canonical one.
https://spdx.org/licenses/LAL-1.3.html
But English, Portuguese and Polish translations are available.
Hoping we can now add the LAL-1.3 to the Choosealicense website.

Great. @xuv do you want to create a pull request adding LAL-1.3?

@mlinksva Could possibly work on that. Will take me a while though. But when completed, I'll make a PR. If anyone else does it in the meantime, I'm also fine with it ;)

Very Nice


#87 reviewed

Completely reviewed, all right.

Sorry, I made a fork of a different branch not active, I close pull-request and check the correct branch.

I don't understand, I made the new fork today, and the modifications. When I do the pull-request it tells me 140 changed files. What did I do wrong?

This is quite strange, grab the project you have updated, copy it to your local folder, remove the forked repo and fork again let's check if you get same results.


fix overlay tool

fix overlay tool

@kofifus can you merge to feature branches or do I need to give you permissions?

Hi @dannyrb
I think this can be merged now ..
Thanks!


Add Windows client support to role

Dedicated issue to track the work done in https://github.com/sensu/sensu-ansible/pull/142 and rebase and finish that up such that we can officially support Windows based clients with this role.
Note, adding in tests is very tricky, so we might need to include it as "supported" similarly to OpenBSD platforms. What we would need to do is run the role on a linux host against a Windows client. My understanding is doing that with TravisCI or Appveyor is going to pretty tricky but, perhaps I'm overlooking something.

Going to close this out for now, if anyone is interested in official Windows support, feel free to open a pull request. From my digging, I don't think there's a clean way for us to do integration tests for Windows but, I'd love to be wrong about that.


Upgrade json-schema dependency to 2.7

Since addressable is a widely used dependency today and json-schema 2.6 has it locked to 2.3 it becomes more difficult to resolve dependency conflicts with Bundler.
Upgrading json-schema to 2.7 will result in addressable >= 2.4 dependency thus should ease up such dependency conflict resolutions.

Thanks @jibiel!


Add api for hardware trigger

Add suggestion of api for hardware triggers support. This mechanisms are very useful when working
with adc and dac controllers, as they can start conversion of analog samples more accurate and by hardware,
which can make the hardware use a dma.
Currently, the api has only one enable function, and the parameter is driver dependent.
I would be happy to here suggestions to make this api more proper and suitable for many use cases.
This also implements the driver for stm32.

I think that this sort of drivers (+DAC) would require to recover the idea of implementing rtio (similar to Linux IIO subsystem).
Refs.
https://github.com/zephyrproject-rtos/zephyr/pull/17434
https://github.com/bfrog/zephyr/pull/1/files
https://www.kernel.org/doc/html/latest/driver-api/iio/triggers.html


Current and available apiVersions

How do you know what apiVersion values are available and which is the most current?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7dbdc219-c30f-1699-f586-9080d36a43fc
Version Independent ID: fa7835bc-8a37-cb1a-ecbe-65883910196f
Content: Create an Azure data factory using REST API
Content Source: articles/data-factory/quickstart-create-data-factory-rest-api.md
Service: data-factory
Product: unspecified
GitHub Login: @linda33wj
Microsoft Alias: jingwang

@ebragas You should be able to find it here.

@ebragas We will now proceed to close this thread. If there are further questions regarding this matter, please reopen it and we will gladly continue the discussion.


Mention generics in "optimizing dependencies"

I had some friction working with this part of the documentation - I was optimising my dependencies but still getting horrific flash usage.
It turns out to be because the profile override has subtle interactions with generic code.
This PR adds a mention of that footgun.

thanks!


file id and resource key

Hi,
I was wondering how to download the files that have the id and the resource key, I have tried simply putting in the id, but it won't work.
Best,

I was wondering the same thing!  I have a Google Drive file id from a URL like this:
https://drive.google.com/drive/folders/<FILE_ID>?resourcekey=<RESOURCE_KEY>
It's a URL provided to us by a sister company.  Our employees do not have Google accounts and do not require a Google account when they use this URL with the ?resourcekey=<RESOURCE_KEY> at the end of the URL following the <FILE_ID>
When I try the gdrive command:
gdrive files download "<FILE_ID>?resourcekey=<RESOURCE_KEY>"
I get the response:
Error: No account has been selected
Use gdrive account list to show all accounts.
Use gdrive account switch to select an account.
It would be nice if you might consider, in future revisions of your code, modifying your code to allow the download command without an account being selected IF the <FILE_ID> following the gdrive files download command contains a ?resourcekey statement within the <FILE_ID> parameter... I don't know if this is even possible, but it would be nice to allow us to download this shared folder to a local location without having to have a google account.
Just a suggestion/request.
Thanks,
Ted


pull request for e2e test at 11/13/2016 14:45:09

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

optest/docs/updated_at.md
:white_check_mark:Succeeded

Details

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


added rotate 2D array

@ephremdeme can you add a label of hacktoberfest
New rules are out there that maintainer of repo needs to opt in by adding a label of hacktoberfest
Only those PR would be counted


Allow the configuration of an exit node and lan access.

Apologies for the delay on this; reviewing now.

I’ve been trying the same base on this PR and struggling with it,
Tailscale run in an userspace networking in the container, main application must use socks5 or HTTP proxy to connect truth the exit node.
An dirty workaround following this docs : https://tailscale.com/kb/1112/userspace-networking/ for me was to add :

root/etc/s6-overlay/s6-rc.d/svc-tailscale/run

if ! [ -e /dev/net/tun ]; then
    FLAGS="$FLAGS --tun=userspace-networking"
    if [ -v TAILSCALE_USE_EXIT_NODE ]; then
        FLAGS="$FLAGS  --socks5-server=localhost:1055 --outbound-http-proxy-listen=localhost:1055"
    fi
fi

root/etc/s6-overlay/s6-rc.d/svc-tailscale-up/run

# configure proxy
sleep 3 # give tailscale a chance to start up
if [ -v TAILSCALE_USE_EXIT_NODE ]; then
    if [ -d /var/run/s6/container_environment ]; then
        printf "socks5://localhost:1055/" > /var/run/s6/container_environment/ALL_PROXY
        printf "http://localhost:1055/" > /var/run/s6/container_environment/HTTP_PROXY
        printf "http://localhost:1055/" > /var/run/s6/container_environment/http_proxy
    fi

fi

@LimeDrive thanks for sharing. Based on your work it sounds like my PR might not even be appropriate.

@LimeDrive do you have a fork where I can try out your changes? Did you find that the proxy settings were always required for exit node use, or only when limited to userspace networking?

This PR might be dead but this seemed relevant and I didn't want to open a new issue.
While working on my own container, I ended up reading through all the files in this project as I figured out how everything fits together, s6, etc. That's how I came across this variable name typo in the svc-tailscale-up script in the exit node section. I don't have an opinion on whether or not this feature belongs in the docker-mod and I know it's undocumented, but I just wanted to mention it.
https://github.com/tailscale-dev/docker-mod/blob/main/root/etc/s6-overlay/s6-rc.d/svc-tailscale-up/run#L20-L23
if [ -v TAILSCALE_BE_EXIT_NODE ]; then
    echo '[!] acting as an exit node, you may need to approve this in the admin console'
    FLAGS="${FLAGS} --advertise-exit-node=${TS_BE_EXIT_NODE}"
fi


Azure Archicture Center contribution

MVP contribution.
After speaking to @EdPrice-MSFT during an MVP call, I am contributing to the Azure Architecture Centre by adding a related resources section to a doc.

@EdPrice-MSFT,
Can you review the proposed changes?
IMPORTANT: When the changes are ready for publication, add a #sign-off comment to signal that the PR is ready for the review team to merge.
#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

#Sign-Off


fix: correct llama-index import for new version

Status
READY/IN DEVELOPMENT/HOLD
Description
New versions of llamaindex changes imports (https://github.com/run-llama/llama_index/pull/9388)

coverage: 96.4% (-0.005%) from 96.405%
when pulling 236429376c9d668650ff04042752dc537c591699 on David-Kristek:0-fix-llamaindex-import
into 48bec2d03f7bba34af08ba6aa2c60b7c601f9e07 on IBM:main.


Allow passing an arbitrary number of config yaml docs, and auto-detect their types

Now the user can pass an arbitrary number of glob expressions in the sample-tester command line.

If any of the globs resolve to directories, sample-tester searches for config YAML documents (testplans and manifests) only in the specified files and recursively in the specified directories.

If none of the globs resolve to directories:

if the globs do not result in obtaining at least one testplan document, recursively search under the working directory for yaml files to extract testplan documents
if the globs do not result in obtaining at least one manifest document, recursively search under the working directory for yaml files to extract manifest documents

In all of the above, the type of the YAML docs extracted from each processed YAML file is determined:

preferentially by the top-level type field (manifest/.+ for manifests, test/samples for testplans)
if not type field is present, for backward compatibility we use the filename from which the document was extracted: documents extracted from *.manifest.yaml files are classified as manifests, and those from other *.yaml files are classified as testplans)

This PR includes tests and documentation updates.
This fixes #52

cc @googleapis/samplegen

PTAL

Is it worth it to file an issue for tweaking the tests to use pyfakefs?


Fixed edge case when comparing boolean types with strings

Fixed edge case when comparing boolean types with strings
Changed  == true to  in ['true', true] to allow both usage of true and 'true' in CloudFormation templates
Issue #, if available:
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Would be nice to add test cases which test both string and boolean values. At least in RDS tests I can see only string value.


Update personas to utilize alliteration for easy remembering with position

Migrated from GitLab: https://gitlab.com/meltano/meltano/-/issues/334
Originally created by @bencodezen on 2019-01-28 15:38:45

View 3 previous comments from the original issue on GitLab


Check whether dependency exists in old lockfile during keep-updated lock

Currently, if a new dependency has been added to the Pipfile and pipenv lock --keep-outdated is run a KeyError: '<dependency-nam>' error is raised. Conditioning on whether the dependency is already in the lockfile fixes this.

seems so obvious when you make a pr out of it :tada:


Max visible suggestions option

This allows the user to set the max number of visible suggestions, and will set the height of the suggestion box accordingly. This provides consistency across multiple editor sizes.
I've also raised the max suggestions to 200. Some providers may return many more than the visible when there is no prefix. For example ternjs:

Why have both maxSuggestions and maxVisibleSuggestions? Seems like they achieve the same thing. Could we just reuse maxSuggestions?

Why have both maxSuggestions and maxVisibleSuggestions? Seems like they achieve the same thing. Could we just reuse maxSuggestions?

We could use maxSuggestions be the visible component and leave the suggestions from the providers unbounded. But the point of this is to allow for a minimum display, but allow providers to display a scrollable list.

Let's just let it be unbounded. If a provider wants to limit their suggestions, we can either have them use atom.config.get or include it in the request's options object.

use atom.config.get or include it in the request's options object

:+1:


feat: link pagination with query parameters and improve wording (#445)

Closes #445.
This change tries to better communicate a consistent look and feel of APIs.
While it replaces a MAY by a MUST, I think this was the intended semantic for providing conventional query parameters supporting query parameters for searching, sorting, filtering, and paginating. Thus I'm not sure whether this is a guideline change.
I also remove the alternate size for limit, and page for offset to enforce a stricter look and feel. If voted for I will reintroduce them again.

Do you think we should keep page and size as an alternative?

No, but we may add better descriptions to each parameter to make their semantic clear.

@whiskeysierra good idea.

👍

:+1:

:+1:


Bucket resiliency advanced configuration doesn't save the last configured state in the editor

Environment info

NooBaa Version: 5.2.0-12536fc
Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

When editing a previously configured bucket resiliency and switching between advanced to basic and back- the actual configured number is automatically changed to default configurations (1)

Expected behavior

If the configured resiliency is 3 replicas for example, and the user switches the view to basic and then return to the advanced screen, the expectation is to keep the current state (3) in the text field and not to change it without the user request.

Steps to reproduce

Go to bucket resiliency -> change to advanced 3 replicas -> click save -> open resiliency again -> switch to basic and then again to advanced -> see the number in replicas number.

More information - Screenshots / Logs / Other output

Selecting basic reverts the user selection (not just the UI) back to basic settings which means in this case 1 replica.
If we will not do that this way it may be more confusing to the user because by clicking on basic settings he will assume that the next click on the "done" button will set to 1 replica but in fact, it will set # replicas (The number he configured in the advanced options)
This exact reasoning was why we programmed it to work the way it works now.
I have 2 suggestions that any one of them may help:

Change the "basic setting" text to "rest selection" or something like that
Disable the "basic setting" link if he changed anything in the advanced settings


build: add arm64 check on SSE in makefile

Signed-off-by: Jin Dong<EMAIL_ADDRESS>
What is changed and how it works?
Add one more arm check related to SSE.

Issue Number: close #12034
What's Changed:

Related changes

PR to update pingcap/docs/pingcap/docs-cn:
PR to update pingcap/tidb-ansible:
Need to cherry-pick to the release branch

Check List
Tests

No code

Side effects

Performance regression

Consumes more CPU
Consumes more MEM

Breaking backward compatibility

Release note
Please add a release note.
If you don't think this PR needs a release note then fill it with None.
If this PR will be picked to release branch, then a release note is probably required.

/merge


PHPLIB-932: Use debian11 and include MongoDB 6.0 for load balancer testing

https://jira.mongodb.org/browse/PHPLIB-932
Related to mongodb/mongo-php-driver@0a712a3265b856c5416eb2fedbbaefadd21db757

As mentioned in https://github.com/mongodb/mongo-php-library/pull/967#issuecomment-1234570317, we don't need the JIRA URL in the commit message.
The diff looks fine, so you can just remove that line when squash-merging the PR. No need to amend and re-push.


Error: If encoding is specified then the first argument must be a string

Hello,
I can not deploy.
Meteor Up: Production Quality Meteor Deployments
Building Started: ../
buffer.js:74
throw new Error(
^
Error: If encoding is specified then the first argument must be a string
at new Buffer (buffer.js:74:13)
at Readable. (C:\Users\JUAN\AppData\Roaming\npm\node_modules\mupc
\node_modules\archiver\lib\util\index.js:32:15)
at emitNone (events.js:91:20)
at Readable.emit (events.js:185:7)
at endReadableNT (streamreadable.js:974:12)
at combinedTickCallback (internal/process/nexttick.js:74:11)
at process.tickCallback (internal/process/nexttick.js:98:9)
I looks that building the app fails but the app runs fine on my local computer.
Any ideas on how to fix it?

What platform are you on?  What version are you running?  What environment are you targeting?  What does your settings file look like?

I have windows on my local computer,
Linux on the staging server.

MUP Settings file (comment out stuff not public of course)?

{
// Server authentication info
"servers": [
{
"host": "xx.xxx.xxx.xxx",
"username": "user",
"password": "xxxxxxx"
// or pem file (ssh based authentication)
//"pem": "~/.ssh/id_rsa"
}
],
// Install MongoDB in the server, does not destroy local MongoDB on future setup
"setupMongo": false,
// WARNING: Node.js is required! Only skip if you already have Node.js installed on server.
"setupNode": false,
// WARNING: If nodeVersion omitted will setup 0.10.33 by default. Do not use v, only version number.
"nodeVersion": "4.5.0",
// Install PhantomJS in the server
"setupPhantom": true,
// Application name (No spaces)
"appName": "gqms",
// Location of app (local directory)
"app": "../",
// Configure environment
"env": {
"ROOT_URL": "http://xxx.ddddddd.net", //"http://xx.x.x.xxx"  "PORT": "3000"
"CLUSTER_WORKERS_COUNT": "6",
//"MONGO_URL": "mongodb://root:dddd!@xxxx.yy.49.mongolayer.com:10522,candidate.50.mongolayer.com:10209/gqms?replicaSet=set-tttttttt",
//"MONGO_OPLOG_URL": "mongodb://oplog:ddddd!@xxx.yy.49.mongolayer.com:10522,candidate.50.mongolayer.com:10209/local?authSource=ccccc"
"MONGO_URL": "mongodb://<IP_ADDRESS>:27017/cccc"
//"MONGO_OPLOG_URL": "mongodb://<IP_ADDRESS>:27017/local"
},
// Meteor Up checks if the app comes online just after the deployment
// before mup checks that, it will wait for no. of seconds configured below
"deployCheckWaitTime": 60
}

Your node version is too high I believe?  I'll ask again, what version of Meteor are you on again?  What branch are you using (master or 1.4)?

<EMAIL_ADDRESS>

And what branch of this repo are you using (master or 1.4)?

how can I know the branch?
I install it with
npm install -g mupc

from the readme on this repo:

replace master with this:

main branch

Right, so replace it with the 1.4 branch with the instructions above. ;)

Thanks for your patience.
I followed the steps on the read me file:
npm remove -g mupc
git clone -b master --single-branch https://github.com/aadamsx/meteor-up-classic.git
cd meteor-up-classic
npm install -g
after that I moved to the staging folder and execute
mupc deploy
and I still get the same error.

No, this line: git clone -b master --single-branch https://github.com/aadamsx/meteor-up-classic.git
should be this: git clone -b mupc-1.4 --single-branch https://github.com/aadamsx/meteor-up-classic.git

Again, thanks for your patience.
I did the following:
npm remove -g mupc
git clone -b mupc-1.4 --single-branch https://github.com/aadamsx/meteor-up-classic.git
cd meteor-up-classic
npm install -g
after that I went to the staging folder and executed
mupc deploy
and I still get the same error.

try node: 4.4.7  also, send  your mup settings file again, this time take out all the comments -- it's hard to read.

{
"servers": [
{
"host": "xx.xx.xxx.xxx",
"username": "user",
"password": "ddddddddddd"
}
],
"setupMongo": false,
"setupNode": false,
"nodeVersion": "4.5.0",
"setupPhantom": true,
"appName": "gqms",
"app": "../",
"env": {
"ROOT_URL": "http://xx.yyy.net", //"http://xx.xx.xx.xxx"  "PORT": "3000"
"CLUSTER_WORKERS_COUNT": "6",
"MONGO_URL": "mongodb://<IP_ADDRESS>:27017/gqms"
},
"deployCheckWaitTime": 60
}

Also please tell me
How do I downgrade meteor node version to 4.4.7 ?

"setupPhantom": true, => set this to false
"setupMongo": false,
"setupNode": false, => set these to true
"CLUSTER_WORKERS_COUNT": "6", => remove this
"MONGO_URL": "mongodb://<IP_ADDRESS>:27017/gqms" => is this port right?
There's no "PORT" under env.
"deployCheckWaitTime": 80, => increase to 100

Did you fix it here: https://forums.meteor.com/t/if-encoding-is-specified-then-the-first-argument-must-be-a-string/35488/3

Good morning,
I still get the same error and I did the suggested changes to the mupc.json file
"setupPhantom": true, => set this to false
"setupNode": false, => set these to true
"CLUSTER_WORKERS_COUNT": "6", => remove this
"deployCheckWaitTime": 80, => increase to 100
Please help.

It's your node version.  Install another node version on your system. I use 5.8.0. A node version manager like nodist can be helpful.

mupc deploy
which node version uses: meteor node or standalone node version ?

my node version is 6.9.2
my meteor node version is 4.5.0


Update to next alpha version

See here for more info

What were you testing, sir?

Wasn't testing anything - we want to add 'alpha' to the version between releases so that the telemetry is recorded separately (See the original discussion here). The only reason I closed this was because we decided to do the bug-fix release and I knew you'd be changing the version for that.
Opened a new PR now that the bug-fix release is out: https://github.com/Microsoft/vscode-azurefunctions/pull/325


Design a cool logo for the website and add it to title.

Please can you assign this to me?

sure :)

@VG-1  Thank you. I have opened PR: https://github.com/VG-1/PlaylistAdda/pull/26
Have a look and let me know what you think.

@VG-1 take a look at this logo. Is it okay?


german umlaut ü (only the small one) is not correctly displayed

instead I see a ?

That seems better now.

But not in Windows:
java> "äöüÄÖÜß"
java.lang.String res0 = "õ÷³─Í▄▀"

Aaa, yes, there was no work done to support windows.


Mention default set of fileNesting patterns in setting description

While verifying #142341 I was not aware of the fact that the setting "explorer.experimental.fileNesting.enabled": true comes with a full set of implicit default patterns even if no "explorer.experimental.fileNesting.patterns" exists in the settings.json. Only when modifying the default set, will the "explorer.experimental.fileNesting.patterns" setting show up.

The setting description need to make this clearer!

This is roughly equivalent to what the file/search exclude already does today:

Closing due to following other patterns. What specifically drove you to thinking they're examples maybe we could work on polishing the settings UI.


new definition files for level-sublevel

Basic definition files for level-sublevel. This depends on https://github.com/borisyankov/DefinitelyTyped/pull/5811 to make Travis happy.

@basp Thanks mate!


Add docs page for Reading Spectrograms

What does this PR do?
Create docs page for "Reading Spectrograms"
As requested by #616
All Submissions:

[x] Have you followed the guidelines in our Contributing document?
[x] Have you successfully ran tests with your changes locally? Including container validation.
[] Have you lint your code locally prior to submission?
[] Have you checked to ensure there aren't other open Pull Requests for the same update/change?
[] Have you labelled this PR correctly? E.G. major, milestone, breaking, breaking-change, minor, feature, enhancement, patch, fix, chore, refactor etc

Mean to close?  Looks pretty good!


Add epsg to extents

PTAL @RoyThomsonMonash

EPSG is now set explicitly and so this conversion is no longer needed


[cross] add basic kernel cross compile script

This script uses the baseline cross-compile toolchain to build the
linux kernel. It then installs the kernel image and modules into the
sysroot directory.
Signed-off-by: Chris Co<EMAIL_ADDRESS>

Requires #610


update examples; public limiter

limiter is public for GovernorConfig (primarily to control storage cleanup)
updated examples for axum==0.7
cargo fmt applied

limiter is public for GovernorConfig (primarily to control storage cleanup)
updated examples for axum==0.7
cargo fmt applied

Is adding Limiter a requirement for it to work? The reason I ask is cause it makes things a bit more complicated

Looked at this a bit closer, I think this is a sensible solution. Thanks for the PR!


fibroblast chemotaxis

I tried to request "fibroblast chemotaxis" in TermGenie, but got this result: "Could not commit, a term with the same label already exists: GO:TEMP-1 fibroblast chemotaxis.  It looks like the term is waiting for some decision."

see also, https://github.com/geneontology/go-ontology/issues/12463

Hi @slaulederkind ,
Thanks for reporting this. Yes, there's a bug in TermGenie. I opened a ticket for @hdietze in the TG tracker: https://github.com/geneontology/termgenie/issues/92
I'll close this, thanks.

(Sorry, too quick.)
@slaulederkind ,
I asked Heiko to alert curators as soon as the bug is fixed.

Added with fixed TG FF.


Replace Pycrypto with Cryptography

And fix some errors.

A new inspection was created.

The inspection completed: No new issues

[Current coverage][cc-pull] is 70.44% (diff: 88.88%)

Merging [#138][cc-pull] into [develop][cc-base-branch] will increase coverage by 0.34%

@@            develop       #138   diff @@
==========================================
  Files            23         23
  Lines           930        934     +4
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            652        658     +6
+ Misses          278        276     -2
  Partials          0          0

Powered by Codecov. Last update [ee9d937...b830949][cc-compare]
[cc-base-branch]: https://codecov.io/gh/whtsky/WeRoBot/branch/develop?src=pr
[cc-compare]: https://codecov.io/gh/whtsky/WeRoBot/compare/ee9d937e9b6d2bc60ed9ca341542447a6e2bd4cc...b83094912e0a7274c7ead55d556d2d86e52430e8?src=pr
[cc-pull]: https://codecov.io/gh/whtsky/WeRoBot/pull/138?src=pr


Import fails if iCalendar file name has spaces

Description:
If the name of the *.ics file to be imported contains spaces, the import fails silently. The column headers are written to the Calc file, but no events.

Steps to reproduce

Export an *.ics file from a calendar application without spaces in the file name
Confirm that this *.ics file can be correctly imported into a Calc file using iCalendar Importer extension.
Rename the *.ics file to include spaces in file name.
Attempt to import the file name with spaces.

Expected Result:
iCalendar Importer extension should import the *.ics file into Calc.
Actual Result:
Import fails silently. Column headers are written to Calc file, but no events are imported.
Error Message:
None
Operating System
OS: Ubuntu 22.04 LTS
Software
Program: LibreOffice
Version: 24.2
Additional Information
None

The error is occurring here because the LibreOffice file picker dialog escapes spaces with %20, but the Python open command appears to be interpreting %20 literally.

I can confirm that this can be fixed by adding .replace('%20', ' ') at the end of this statement.

Fixed with 1688dfef2d2cfbaf85dfe19c5b68ddc523f778c6.


#Request for Help

Good day! First of all, thank you so much for making this wonderful thing! It really helps me to read my favorite novels. Second, it amazes me how efficient and effective it is so a big thumbs up y'all. By the way, I just discovered it yesterday and so at the moment I am having a problem with stopping the queue download. I am a new user of your telegram bot and I really want to know if there's such a thing as cancelling the ongoing download. I have waited for almost an hour to one of my ongoing download and it really wasn't moving at all. Thank you and keep up the good work!

Thanks for the feedback!
I've added a /stop command which will cancel an ongoing download.

Thanks for the feedback!
I've added a /stop command which will cancel an ongoing download.

Thank you so much!

Thank you so much!


[Editor] It can be cumbersome to find out what arguments an action takes

The autocomplete menu will show you what you need but once you've inserted something, that's it. You will need to search the wiki to find out what's going on. Ctrl+Space can help but only if your cursor is in a useful position.
With C# for Unity in VSCode you get these grey labels (for different purposes), perhaps CodeMirror offers something similar in some way?

Closed with https://github.com/EloHellEsports/workshop.codes/commit/7ff4214e766cfd1ea18e58512fdd198c862a55cf


Proxy stream without saving to disk (or limit size)

sxm-client version: .0.2.5
Python version: 3.8.0
Operating System: Ubuntu 20.04.6 LTS

Description
I am trying to simply proxy and NOT archive any music to disk -- concerned about disk usage.  I would like the stream to be available to pull and listen to 24/7.
What I Did
It seems impossible to avoid this -- when I set output folder to /dev/null I get an error.
from config file:

output_folder: "/dev/null"
---
sxm_player.hls[1395989] INFO playing http://<IP_ADDRESS>:7944/radiomargaritaville.m3u8 (/dev/null/streams/radiomargaritaville.mp3)
Process Process-5:
Traceback (most recent call last):
  File "/usr/lib/python3.8/multiprocessing/process.py", line 315, in _bootstrap
    self.run()
  File "/usr/lib/python3.8/multiprocessing/process.py", line 108, in run
    self._target(*self._args, **self._kwargs)
  File "/home/jshep321/.local/lib/python3.8/site-packages/sxm_player/runner.py", line 50, in worker_wrapper
    worker = worker_class(*args, **kwargs)
  File "/home/jshep321/.local/lib/python3.8/site-packages/sxm_player/workers/archiver.py", line 36, in __init__
    os.makedirs(self.stream_folder, exist_ok=True)
  File "/usr/lib/python3.8/os.py", line 223, in makedirs
    mkdir(name, mode)
NotADirectoryError: [Errno 20] Not a directory: '/dev/null/streams'

Never mind.  I am using the included sxm binary for this.


exercise-1-start-python destroy fails to empty bucket

tox -e destroy in the exercise-1-start-python branch fails to empty the bucket, resulting in a stack deletion failure.
It looks like what is happening is that old object versions are not being deleted.
Needed: Verify behavior in each other Python branch.

[x] exercise-1-start-python : fails
[x] exercise-2-start-python : works
[x] exercise-3-start-python : works
[x] exercise-4-start-python : works
[x] exercise-4-finished-python : works

Looks like this is only present in exercise-1-start-python.

I just retried the tax -e destroy, and I am not getting a stack deletion failure. Just thought I should let you know!

@ksamreen which branch are you on?

on the exercise-1-start-python branch

Hmmm, I re-ran my testing and it failed on the first destroy then succeeded on the second destroy. I suspect this is eventual consistency on the deletes tripping us up. Might need to wait for a bit after clearing the bucket.


fix(cynosdb): add offline step for remove

:tada: This PR is included in version 1.20.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 1.20.10 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Add ManSection enum, own title line struct and other minor updates

The title line, manpage section and compatibility settings come from clap-rs/clap#3174, where we decided on extracting out Roff-specific functionality to this crate. I also did a few minor changes, like removing the derive for PartialEq and Eq from the structs. The title line struct will make #7 obsolete, and is in my opinion a better solution as the order of the elements is important and is not just a list of strings.
cc @epage

Your two comments about whether things should go here or in a more manpage specific crate was one of the reasons I ended up trying to do everything in clap_man, the inclusion of a title line means we're already targeting manpages and not "pure" roff. It is a massive type-setting system (here is short reference of GNU variant of the format, you can see we're only really touching a tiny, tiny part of it), and has historically been used for lots of different things from books, articles and more.
Nowadays however I thing nobody uses it outside of manpages anymore, and while the man crate contains useful tools to build manpages for CLI tools this crate already targets a subset of roff specific to manpages, at least in my opinion. :sweat_smile: roffman that you mentioned in the PR in clap has sections in it (and a lot more, I'm just not a big fan of its API).
Sorry, this is a lot of words for saying that in my head roff-rs is already a manpage specific crate :slightly_smiling_face:

I had a closer look at the manual page generation and the roff crate. I've pushed two branches that I think would be an improvement.
https://github.com/larswirzenius/roff-rs/tree/liw/roff-only changes roff to have an abstraction level of ROFF only, dropping manual page stuff.  The branch isn't ready to be merged, and needs some cleanup first.
I then ported @sondr3's maual page generation to my roff version (https://github.com/larswirzenius/clap/tree/liw/generate-man). This, too, probably needs cleanup.
What do you think? Is my approach of any interest?

What do you think? Is my approach of any interest?

I really like this!  By focusing on the roff structure, I feel like it makes clearer the intent of what is going on while giving the benefit of escaping and typing (compared to doing everything with raw strings).

I too like your approach and from the comment over the PR on clap you have far more experience working with manpages and the roff-format, so you can be the judge for this crate. Do you want to create a PR against my fork of clap so we can integrate your changes once you feel it's ready? :smile:

I will do that later today or tomorrow, as soon as I've dug myself out from this horde of elves I'm buried under.

Superseded by #15.


Feature: Add QEMU option to include ARK, ASK and VCEK certificates to the guest VM

Is your feature request related to a problem? Please describe.
This feature is designed to increase the speed of the verification process.
Describe the feature you are requesting, as well as the possible use case(s) for it.
This feature will enable the Manager to run SVMs with added ARK, AS and VCEK to guest memory. This will enable the Agent to send the certificates ARK, ASK and VCEK alongside the attestation report. The CLI will then only have to fetch the CRL from AMD and not ARK, ASK and VCEK.
Indicate the importance of this feature to you.
Must-have
Anything else?
No response

@danko-miladinovic What's the status with this one?

@danko-miladinovic What's the status of this ticket?

This was not able to be done before because of QEMU. Now with the new version of QEMU installed, this can be done. I will work on it.

@danko-miladinovic What's the status here?

I will start on this one as soon as I finish with aTLS bug.

@danko-miladinovic Any progress on this one?


running with point feature file

string-tie is crashed while using point feature
Error: invalid call to GRefPtData::add() - cannot add feature with ref id 13893200 to ref data id 282328656!
String-tie_point_feature.txt

Thank you for reporting this. This issue was caused by a GList move operator bug, fixed via b498cdd.

thank you for fixing it


[MM-26813] autocomplete UX rework

Summary
This PR will enable users to execute command on autocomplete selection.
Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-26813
Screenshots

@iomodo Chris Poile is off this week, probably another dev needs to review this.

/update-branch

/update-branch

@asaadmahmood This one needs UX review.

@iomodo The execute command icon is not centered.

@asaadmahmood  I'm not noticing the alignment issue. Is the text Execute Current Command sitting too high or is there something I'm noticing here?

@DHaussermann Yup, sitting too high.

@asaadmahmood  if you could please take another look, this is the current UI.

To me, this looks fixed but, it's hard to see if there are minor alignment issues since the fist letter is upper-unlike the other options so it is taller. Does this look fine to you?

@DHaussermann I think its fine for now.

@iomodo
Error trying doing the automated Cherry picking. Please do this manually
+++ Updating remotes...
Fetching upstream
Fetching origin
+++ Updating remotes done...
+++ Creating local branch automated-cherry-pick-of-#5874-upstream-release-5.26-1595276659
Branch 'automated-cherry-pick-of-#5874-upstream-release-5.26-1595276659' set up to track remote branch 'release-5.26' from 'upstream'.
+++ Downloading patch to /tmp/5874.patch (in case you need to do this again)

+++ About to attempt cherry pick of PR. To reattempt:
  $ git am -3 /tmp/5874.patch

Applying: Rework autocomplete UX
Applying: Support mouse click
Using index info to reconstruct a base tree...
M	components/suggestion/suggestion_box.jsx
Falling back to patching base and 3-way merge...
Auto-merging components/suggestion/suggestion_box.jsx
CONFLICT (content): Merge conflict in components/suggestion/suggestion_box.jsx
Patch failed at 0002 Support mouse click
Use 'git am --show-current-patch' to see the failed patch
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

+++ Conflicts detected:

UU components/suggestion/suggestion_box.jsx

+++ Aborting in-progress git am.

+++ Returning you to the master branch and cleaning up.

@iomodo This hasn't been cherry-picked yet?

@amyblais It is cherry-picked in 5.26


Added contributions doc(Max)

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 38.715%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
407

Relevant Lines:
818

💛  - Coveralls


goa: 3.16.2 -> 3.17.1

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://github.com/goadesign/goa/releases.
meta.description for goa is: Design-based APIs and microservices in Go
meta.homepage for goa is: https://goa.design
Updates performed

Golang update

To inspect upstream changes

Release on GitHub

Compare changes on GitHub

Impact
Checks done

built on NixOS
The tests defined in passthru.tests, if any, passed
found 3.17.1 in filename of file in /nix/store/da3073lb76i3hxq2mpikik9g38c0j4fc-goa-3.17.1

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

goa

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/da3073lb76i3hxq2mpikik9g38c0j4fc-goa-3.17.1 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A goa https://github.com/r-ryantm/nixpkgs/archive/e18332d09a98d9f7896e7e5782b713d8b52c4f4a.tar.gz

Or:
nix build github:r-ryantm/nixpkgs/e18332d09a98d9f7896e7e5782b713d8b52c4f4a#goa

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/da3073lb76i3hxq2mpikik9g38c0j4fc-goa-3.17.1
ls -la /nix/store/da3073lb76i3hxq2mpikik9g38c0j4fc-goa-3.17.1/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

goa

Maintainer pings
cc @rushmorem for testing.

Result of nixpkgs-review pr 324446 run on aarch64-darwin 1

1 package built:

goa


iBGP multipath

The test README.md file for internal BGP multipathing ECMP.
Note: This is very similar to existing RT-1.51 external BGP multipath ECMP tests

Pull Request Functional Test Report for #3509 / 84b6ec295f81566a0391b70320dc06c4aab2bce4
Virtual Devices

Device
Test
Test Documentation
Job
Raw Log

Arista cEOS

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP
0b3bb9ef
Log

Cisco 8000E

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP
e8903a70
Log

Cisco XRd

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP
4ff65e09
Log

Juniper ncPTX

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP
59eec22d
Log

Nokia SR Linux

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP
15af7a6a
Log

Openconfig Lemming

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP
918d0425
Log

Hardware Devices

Device
Test
Test Documentation
Raw Log

Arista 7808

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP

Cisco 8808

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP

Juniper PTX10008

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP

Nokia 7250 IXR-10e

RT-1.51: BGP multipath ECMPRT-1.63: Internal BGP multipath ECMPP

Help

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 55.268%

Totals

Change from base Build<PHONE_NUMBER>7:
0.0%

Covered Lines:
1983

Relevant Lines:
3588

💛  - Coveralls


creating a session on load in the UI

⚠ Please check that this feature request hasn't been suggested before.

[X] I searched previous Ideas in Discussions didn't find any similar feature requests.
[X] I searched previous Issues didn't find any similar feature requests.

🔖 Feature description
problem: Different users' interacting with share/embedded agent are all shown under single trace. (i.e: with empty session) with incorrect user id.
solution: Each user session to be it's own trace.
📝 Additional Context
No response
Acknowledgements

[X] My issue title is concise and descriptive.
[X] I have searched the existing issues to make sure this feature has not been requested yet.
[X] I have provided enough information for the maintainers to understand and evaluate this request.

Redo this the check and fill it to slove this issue