Window is undefined in raven-js in Server Side Rendered applications

Do you want to request a feature or report a bug?
Bug
(If this is a usage question, please do not post it here—post it on forum.sentry.io instead. If this is not a “feature” or a “bug”, or the phrase “How do I...?” applies, then it's probably a usage question.)
What is the current behavior?
This bug is specific to version 3.23.0 which is released few hours ago.
Ours is an Angular 5 application and we have raven-js as our dependency. We also use Angular Universal to serve pre-rendered pages using our node server. It is failing when our node server tries to serve the page as the node server could not understand the object 'window' used in the code.
The bug recorded in our log is as follows:
TypeError: _window.addEventListener is not a function
at Object._attachPromiseRejectionHandler (/home/node/dist/server.js:267398:13
If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar.
The function attachPromiseRejectionHandler in raven-js package introduced the 'window' object which will not be available in the node
What is the expected behavior?
The version 3.21.0 was working fine even in Angular Universal.
Which versions of Raven.js, and which browser and OS are affected by this issue? Did this work in previous versions of Raven.js? Are you using the CDN (http://ravenjs.com)? Are you using hosted Sentry or on-premises? If on-premises, which version (e.g. 8.7.0)?
Version: 3.23.0
Using as an NPM package
Was working perfectly in version 3.21.0

Thanks for opening the issue and sorry for the inconvenience @subramaniashiva -
We'll get a patch out asap, but in the meantime, to be clear to anyone finding this issue, the fix it to pin your version to 3.22.4

Fixed in 3.23.1


Push Sacred 0.8.2 to pypi

@Qwlouse can you push the release 0.8.2 to pypi?

Done. 👍
Thanks a lot for preparing this release!

Thanks! :)


Fix #244 & Fix #245

Fixes both issues #244 and #245.
Re #244: I hardcoded the content type to "application/octet-stream". Not sure if it's a right way to do that.

Looks good to me—we may want to go this route (update with retries before the build script) since these downloading and resolution failures seem increasingly common.

Agreed! I'm tired of clicking the "restart" button.

@BenWhitehead could you please review it?
I added a new method on a ResponseBuilder - withContetntType that overrides the content type provided by EncodeResponse:
val rep = Ok.withConentType(Some("applicatoin/json"))("invalid json")

@vkostyukov I think this is a good approach. Thanks!

Great! I'm merging this.


IREE model exported by jax does not recognize static arguments

What happened?
I have a compilation pipeline that works with the following versions:
jaxlib==0.1.61
https://github.com/google/jax/archive/refs/tags/jax-v0.2.9.tar.gz
https://github.com/iree-org/iree/releases/expanded_assets/snapshot-20210728.428

Pipeline is: build model with JAX -> export it for IREE -> load it using IREE runtime -> run it in python & go using the IREE runtime APIs
I am trying to upgrade IREE to latest stable (versions in "Version information" section). My issue is that static arguments are not working. I have updated the IREE interface and I am compiling as follows:
def aot(function, static_argnums, *args, **options):
    """Traces and compiles a function, flattening the input args.

    This is intended to be a lower-level interface for compiling a JAX function to
    IREE without setting up the runtime bindings to use it within Python. A common
    usecase for this is compiling to Android (and similar targets).

    Args:
      function: The function to compile.
      args: The inputs to trace and compile the function for.
      **kwargs: Keyword args corresponding to xla.ImportOptions or CompilerOptions
    """
    xla_comp = jax.xla_computation(function, static_argnums=static_argnums)(*args)
    hlo_proto = xla_comp.as_serialized_hlo_module_proto()
    return iree.compiler.tools.xla.compile_str(hlo_proto, input_type=iree.compiler.InputType.XLA, **options)

    trace_args = [start_step, end_step, *placeholder_inputs]
    return iree_jax_support.aot(jax_pipeline, (0, 1), *trace_args, target_backends=["llvm-cpu"], extra_args=extra_args)

jax_pipeline is built by this function:
def dynamic_jax_pipeline(steps, input_indexes, output_indexes):
    """
    Takes as input `steps`, which is a list of functions.
    `input_indexes` and `output_indexes` tells each step which data to work with and where to put the data

    Returns a function which takes in multiple inputs `tensors` and pipes them through each step, transforming the tensors.
    `tensors` is a variable number of 2D tensors.

    The function may also take a `start_step` and an `end_step` by which you control which sub-sequence of steps to run.
    """

    def __inner__(start_step, end_step, *tensors):
        start_step = 0 if start_step is None else start_step
        end_step = len(steps) if end_step is None else end_step

        for i, step in enumerate(steps[start_step:end_step]):
            input_data = [tensors[j] for j in input_indexes[i + start_step]]
            tensor_out = step(*input_data)
            idx = output_indexes[i + start_step]
            tensors = (*tensors[:idx], tensor_out, *tensors[idx + 1 :])
        return tensors

    return __inner__

where steps is a list of jax.numpy functions.
Then l am loading & running the model as follows:
def load_iree_binary(pipeline_bytes: bytes):
    """Loads a compiled pipeline using IREE"""
    global _DYLIB_CONFIG, _VM_INSTANCE
    if not _DYLIB_CONFIG:
        # lazy initialization – ensures the config is created in the context of the calling process
        _DYLIB_CONFIG = ireert.Config("local-task")
    if not _VM_INSTANCE:
        _VM_INSTANCE = ireert.VmInstance()

    vm_module = ireert.VmModule.from_flatbuffer(_VM_INSTANCE, pipeline_bytes)
    module_object = ireert.load_vm_module(vm_module, _DYLIB_CONFIG)
    return module_object["main"]  # the compiled function to be ran

    func1 = load_iree_binary(compiled_tensor_func[0])
    data32 = func1(data32, start_step=0, end_step=1)

This was working find before, now it's complaining that
    def __call__(self, *args, **kwargs):
      invoke_context = InvokeContext(self._device)
>     arg_list = self._arg_packer.pack(invoke_context, args, kwargs)
E     ValueError: specified kwarg 'start_step' is unknown

If I just put the values of the static arguments at the beginning, i.e.
    func1 = load_iree_binary(compiled_tensor_func[0])
    data32 = func1(0, 1, data32)

The error is
    def __call__(self, *args, **kwargs):
      invoke_context = InvokeContext(self._device)
>     arg_list = self._arg_packer.pack(invoke_context, args, kwargs)
E     ValueError: mismatched call arity: expected 1 got 3

Basically I am trying to provide 2 integers which are constants at compilation time. I'm also a bit confused – should I provide these at all when running the IREE models? Or is it enough if I just provide the values for the traced inputs, the ones which are not static?
One more thing to notice is that when running the JAX model in python directly – it expects to get the two static arguments
Steps to reproduce your issue
No response
What component(s) does this issue relate to?
No response
Version information
jax==0.3.17
jaxlib==0.3.15
-f https://github.com/iree-org/iree/releases/expanded_assets/candidate-20220902.254
--extra-index-url https://github.com/iree-org/iree/releases/expanded_assets/candidate-20220902.254
iree-compiler
iree-runtime
iree-tools-tf
iree-tools-tflite
iree-tools-xla

Additional context
No response

I understand what's going on – jax.jit requires that you provide the values for the static_argnums because it's just that – JIT. But AOT compilation does not require the values for static_argnums when running the function, because it already compiled that function with the values provided to the static arguments.
My current issue is that the results from the IREE function are wrong – please don't close this issue yet. I'll close it myself with a conclusion / open a different one

I think this isn't actually a bug – I was just misusing arguments. I will close it for now. If I do indeed have issues with static arguments, I'll re-open the issue.

Sounds good thanks (it sounded good before, but as you mentioned you wanted verification, commenting :)). I think we can also file a new one rather than reopen just so it hits the correct triaging workflows.


Refactor .vimrc to separate haskell specific cfg

Keep all language specific config in vimrc.haskell. Easier for maintenance and figuring out Haskell specific vs language independent settings. This is sort of a language specific vimrc module.

This is nice, it separates the Haskell cleanly into its own area. One thing that's still mixed together are the Haskell plugins with the other plugins. You might consider making a hvn_haskell_plugins file like we have a hvn_user_plugins file. Then again the haskell plugins are already gathered into their own block. What do you think?

That's a good idea. That will cleanly separate everything Haskell from common stuff. Though there are only a few of them and at one place already. We can do that as a separate change after this.


Normalize URL

It doesn't seem to me that Kestrel normalizes URL.

Can you give some details?  A few examples?
cc @Tratcher

https://www.ietf.org/rfc/rfc3987.txt
<IP_ADDRESS>.  Character Normalization
And maybe
<IP_ADDRESS>.  Path Segment Normalization

@Tratcher @troydai Do we need to do this? What's the user impact if we don't do it?

That's more a question for @blowdart. We're un-escaping arbitrary Unicode from remote users. Normalization helps avoid lots of known issues with strange unicode combinations. http://unicode.org/faq/normalization.html

@blowdart Please advise :smile:

You must normalize. Just like IIS does.

Do we want to preserve the original URL as a field in the context i.e. the original bytes and path before normalization and dot segment removal?

Not right now.

Need for RC2


About the tensorflow version

Hi,
The requirement.txt file said that the TensorFlow version used in this project is 2.2.0. However, when I tried to run the train_triq.py file,  the error happened, which said that "Tensorflow Addons supports using Python ops for all Tensorflow versions above or equal to 2.3.0 and strictly below 2.5.0 (nightly versions are not supported)".  It seems like the function tensorflow_addons.activations.gelu does not support the TensorFlow 2.2.0.
I'm not familiar with TensorFlow. Therefore, I want to check the TensorFlow version and discuss why this error happened.

Hi, I was using tensorflow-addons==0.11.2. So maybe use this version of tf-addons as well? I think you can also use TF2.3 to train TRIQ, but I remember there was another issue with TF2.3. It was not about the training itself, but I don't remember, probably about the callbacks. Please give a try.

Okay, I will try tensorflow-addons==0.11.2. Thanks very much.

It works. Thanks again.

It works. Thanks again.

Great.


Fix typeof privateKey conditions

The old condition always evaluated to false.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Assignment 1 Francesco Zatelli

Introduction

Hi, I'm Francesco and I'm a PhD student at QuTech in Applied Physics.
Describe your research in 2-3 sentences to someone that is not from your field (please avoid abbreviations)

I work on semiconductor-superconductor hybrid nanowires with the goal to create and manipulate particles that could be useful to build a quantum computer. We fabricate nanoscale devices in the cleanroom and perform electrical measurement to understand their behavior at cryogenic temperatures.
My research entails the following aspects:

Research Aspect
Answer

Use/collect personal data (health data, interviews, surveys)
No

Use/collect experimental data (lab experiments, measurements with instruments)
Yes

Collaborate with industry
Yes

Write/develop software as the main output of the project
No

Use code (as in programming) for data analysis
Yes

Work with large data (images, simulation models)
Yes

Other:
N/A

Reflections on the importance of RDM videos

I found most of the arguments presented in the video very relatable and relevant. Although it was briefly mentioned, I think that discussing what is/should be shared is very relevant (if shaking/stirring a sample is significant, how many more things could be just as important that I have no idea of?). I found particularly interesting the discussion about creating a collaborative environment for reproducibility, as opposed to the idea of a "reproducibility police". For me, it would be a horror story to make some mistake in a paper and having people put in doubt my integrity.
What would you like to learn during this course?

I would like to learn how to decide what should be shared in an online repository when publishing a paper, i.e., how can I know that the information I shared is enough to make the work reproducible?
Checklist assignments

[x] Assignment 1: creating a GitHub issue (before Class 1)
[x] Respond to the GitHub issue on 'data challenge'
[x] Assignment 2: Data Flow Map 1 (share a link in this issue before 17 May 13:00). Link: https://surfdrive.surf.nl/files/index.php/s/DUmnuKue9PzvEYa
[ ] Provide feedback to at least one Assignment 2 from another participant
[ ] Respond to the GitHub discussion on 'licenses'
[ ] Respond to the GitHub discussion on 'folder structure'
[ ] Respond to this GitHub issue with your readme file
[ ] Provide feedback to at least one readme file from another participant
[ ] Assignment 3: Data Flow Map 2 (share a link in this issue before 31 May 13:00). Link:
[ ] Provide feedback to at least one Assignment 3 from another participant
[ ] Assignment 4: Data Management Plan (before Class 2)
[ ] Respond to the GitHub discussion on 'Data Management Plans' if you have any questions (optional)
[ ] Assignment 5: Data Flow Map 3: submit your slide (before Class 2)

Hi @francescozatelli ! Thanks for handing in assignment 2! It looks fantastic and I don't really have feedback for you, so I will focus below on your questions:
How to make sure that someone in the team will still have access to the project data drive?
You can add anyone with a netID to the project drive by adding them from the start, asking the service desk to add a member to the drive, or by using UMRA to add members (see the second bullet point on this page for more information about UMRA: https://estherplomp.github.io/TNW-OS-support/posts/storage-solutions/#project-drive)
How can I retrieve data in the U: drive after I leave if needed?
As long as you have a netID you can still access the U: drive. When you don't have a (guest)contract anymore I suppose you could ask others to share the data, but an easier way is to share the data that you're working on publicly in a data repository so that you yourself also have access to the data/code after you leave an institute. Due to the way that our contracts are set up the University holds the rights to data - by sharing things publicly you also grant yourself reuse rights!
As for your flag on need to reliably store data for the long term: Data repositories also help with that, since they generally store data for at least 10 years. You'll learn more about that in the upcoming self-paced materials - and you can always ask more questions about this in the next assignment or here on GitHub!

Hi @francescozatelli , here comes my feedback for your data flow map. The classification of your data sets in the map is comprehensible and clear. You already have several levels of data storage (local computers and drive storage) and you use Github for the codes - all these routines are very exemplary. Therefore I don't have any critique.
Based on my own experience with cleanroom fabrication, I also know that cad drawings for the devices might be very sensitive and important for the fabrication workflow, especially if the layouts are still under development and therefore change iteratively. So maybe it makes sense in your case to include these files in your map as well.
Overall, it's a great data flow map!

Thank you both very much for your feedback! Indeed CAD drawings should be part of the map, so far we have been storing them on OneDrive (like the SEM images). I will add them in the next data flow maps.
Here is my readme file

Thanks a lot for the feedback! For what concerns data access/publication indeed I was not very explicit in Assignment 3, but I have (hopefully) explained it clearly in the readme file.
I understand your point regarding data preservation and management for 'all the data' and it makes a lot of sense to me. However, I'm having a bit of a hard time understanding what exactly 'all the data' would mean from a practical point of view. I'll try to explain my problems with a practical example.
Usually, the data that we collect for a project is associated to a sample (or multiple samples). If samples are entirely dedicated to one specific project from the beginning, I think it's clear that 'all the data' would mean exactly all the datasets collected on such sample(s).
However, sometimes a single sample is used to collect datasets for multiple projects of different people. In this case we would have tens of databases, each containing hundreds of datasets. Even though the projects are somewhat independent, there is always some overlap.
One project could start from some measurements taken for another project. It could also be that one project starts but ends up nowhere (although it may be attempted again in the future). Some projects might be paused and continued later on. It could also be that some datasets are measured in a very "explorative" way, so that they are not really related to any project. In general, however, all the measurements contribute to a sort of cumulative "knowledge" of the sample.
Eventually, if a project is successful it becomes a paper. In such a case, what does it mean to share 'all the data'? I suppose I could arbitrarily select a subset of datasets that are the most relevant to my project, but I can't really think of systematic criteria to make this selection (and of course this would just be 'more data', not 'all the data').
I hope I managed to explain my very specific situation in a somewhat understandable way :)

Absolutely explained in an understandable way!
I'm afraid that it will indeed come down to some arbitrary selection of the data that is most relevant to the main conclusions of the work. In principle you're encourage to publish all of these datasets - but sometimes people are hesitant with this because what if they want to use it for a possible future paper? I would argue that their name is on the dataset already and they have the advantage of knowing the data well / the equipment to do further experiments - but it is in principle possible that then others start working with the data. It might be worthwhile to have a chat with Arthur, or other people from your group, once you have one of your article ready to publish. If you and another person agree on what makes the most sense to share, at least you have some agreement on your arbitrary data selection!
I'm sorry that this isn't a simple answer - but the answer to your question will differ per project and also the preferences of your supervisors/collaborators I'm afraid!

I see, thanks a lot! Understandably it's a very specific problem, so I will have a discussion with my collaborators and/or Arthur then.


Multicast server on Wifi Interface

Hi erveryone,
I'm hurting a big new issue about the coap server discoverable feature.
I'm trying to  connect and listen on the <IP_ADDRESS>:5683 address, but when I'm trying to use my node.js app on Wifi, this seems to not get registered. I don't see the frame on Wireshark.
However, this works perfectly when we are using the Ethernet plugged.
Do you know why please ?
Thx
Damien

Are you sure this is node-coap issue and not your network configuration? First, capture the transmitting interface (or if you can, capture all WiFi traffic, using a sniffer) and see if the multicast packet is being sent at all.

Hi @GiedriusM, We are sure about our network configuration. Using Wireshark, we don't see any packet emitted from our coad server. Howerver, this multicast packet is emmitted when the PC running the coap server is plugged on ethernet wire.
We tried on many PCs and we are facing the same issue on all.
:(
We are wondering if this is not a Wifi issue since we know there are some troubles with mulcticasting over wifi.

@damienjars , could you try using some other tool to generate multicast UDP packet and see if they reach the destination.
For example, iperf could be used for this. If it can't doesn't work either, then it's almost certainly that the issue is not in node-coap, but your configuration, OS or hardware.

Hi @GiedriusM, we finally find out a solution. We used the library v17 and after the update, our server finally worked.
Thanks for your answers :)

@damienjars, good to know :) If this issue is fully resolved, please close it.


Custom sorter based on kind for vim.ui.select()?

Is it possible to use a custom sorter if the kind option is a certain value, otherwise use the default sorter?
For example, I want to be able to sort user created items to be before builtin items in my plugin legendary.nvim.
I think this could probably be done via the get_config option of dressing.nvim?

I can work on a PR for this.

Hmm, actually I'm not sure this gets me what I want still. I want to be able to use the table properties for sorting, but it seems like telescope only sorts on the strings.

Maybe we can have items specify their own "ordinal" values, but keeping what you have there as the default.

I don't think that works either :/

So you're trying to specifically force a sort ordering for the telescope selector backend? In my tests the items (at least initially) are sorted by the order they're passed in. This is using https://github.com/stevearc/dressing.nvim/blob/master/tests/manual/select.lua
Are you seeing a different initial order? Or are you trying to sort it differently after the user starts typing?
If you do need a different sort function, it should be straightforward to add that to the config options.

I'm trying to sort after the user starts typing. For example here, I'd like the 2nd option to appear first in the list:

The 2nd item is one I've added custom. The other 2 items are "builtins" that are added by my plugin by default. I was users' custom entries to appear before the "builtin" entries, does that make sense?
So basically I want default fuzzy sort (based on closeness to search term), then by a custom sort, if that makes sense?

Yep, that makes sense! The first step would be to figure out how you would even do this within Telescope. I think that the way to do that would be to override the sorter?
If you get a custom sorter that works, we can make a change to the telescope backend that allows the user to pass in a custom sorter. This line
https://github.com/stevearc/dressing.nvim/blob/b36b69c6a5d6b30b16782be22674d6d037dc87e3/lua/dressing/select/telescope.lua#L36
would change to something like
sorter = config.sorter or conf.generic_sorter(opts),

Note that this would still require the user to provide this custom sorter in their config
require('dressing').setup({
  select = {
    get_config = function(opts)
      if opts.kind == 'legendary' then
        return {
          telescope = {
            sorter = require('legendary').custom_telescope_sorter(),
          }
        }
      end
    end,
  }
})

Yup I'm definitely aware that pretty much no matter way, it would require some user config. I'm going to document it in my README.md with an example config for dressing.nvim (since that's what I use, and from what I can tell, what most people who use my plugin use).
As far as creating a custom sorter, I tried starting down that route, but I couldn't figure out how to get the actual item reference in the sorter (I want to sort by one of the properties of the table, not the resulting formatted string that gets shown in the actual Telescope UI). Do you have any insight or tips there? 😅

That's more of a question for the telescope repo. I don't know off the top of my head, and while I could probably figure it out given enough time, it's probably faster to just ask the people that actually built it 😛
If you can get a minimal telescope example working, I'll definitely help figure out how to translate that to dressing

Cool, I'll spend some more time digging into it and come back here, thanks!

Based on https://github.com/mrjones2014/legendary.nvim/pull/219, it looks like this was resolved

Yup I think we’re all good here, thanks


Add portuguese br translation quizz

Adding the Portuguese-BR translation file to the quizz following the specified guidelines.

@jessicaribeiroalves please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

Contributor License Agreement

@microsoft-github-policy-service agree [company="{your company}"]

@microsoft-github-policy-service agree

@PabloNunes and @leestott thanks for reviewing my PR!
I took a look at the pipeline failure. At the build and deploy job it's saying the deployment_token was not provided. Is there any action on my side that I can take?

@PabloNunes and @leestott thanks for reviewing my PR! I took a look at the pipeline failure. At the build and deploy job it's saying the deployment_token was not provided. Is there any action on my side that I can take?

Don't worry, your doc just changed documentation. Going ahead with merge.


Use dream2nix v1

nci currently still uses dream2nix legacy, we want to port the old rust subsystem to dream2nix v1 and make nci use the new dream2nix api

note: work for this is being done on https://github.com/nix-community/dream2nix/pull/606


Icon Updates

Ceiling LIght, dimmer, light switch, lightbulb, outlet, power plug added

Fixes # .

Changes proposed in this Pull Request:

Screenshots:

@Horchen154 make sure you have that "use artboard" thing checked when you do Export > Export as

Note to myself -- TODO

update meta.json
run yarn build in a separate branch

Icons shapes and artboard are looking good, but there's still the issue of the fill property. And can we make LightBulb into two words? Most references online and in publications use this format (even though Merriam-Webster uses one)...my spellchecker complains about it.

Looking for a nod on https://github.com/pxblue/icons/pull/85


=tck minor test name fixup, it is a required test

Trivial name fixup, introduced in https://github.com/reactive-streams/reactive-streams/pull/214/files#diff-4ebca955800e47695d157fcd89b4fec6R263
Notice that this rule is a required rule, thus the method name of the test should reflect this.
( see why such name here: https://github.com/reactive-streams/reactive-streams/pull/219/files#diff-4ebca955800e47695d157fcd89b4fec6R273 )

Nice catch, LGTM

@smaldini We should make sure we get this into the RC3 as well

This was slated for RC3, merging for RC4 instead.


Vertical pipe separators getting included in domain names

Some people use a unicode vertical pipe bar as separators.
When it using a traditional ascii vertical pipe, it is not included in the URL link:
sometext|www.dancedeets.com. (just the www.dancedeets.come becomes a link)
However, when it uses a special unicode vertical pipe (and asian languages/keyboards are more likely to use this character), then linkify-it does include it in the URL link:
sometext｜www.dancedeets.com (the entire text becomes a link)
I think it's the different-treatment-of-vertical-pipes that bugs me, and what I feel is a bug.
In terms of actual examples of this unicode vertical pipe being used in live text out there (as examples of "de-facto usage of this as a means of humans writing text"), I can point to:
https://www.facebook.com/events/1242414222466166/
https://www.facebook.com/events/228824650884335/
https://www.facebook.com/events/896736620379772/
https://www.facebook.com/events/1012537322116670/
https://www.facebook.com/events/1650303181918755/
https://www.facebook.com/events/1616043775368308/
(and these two do not have public fb events I can point to, so I am pointing to my proxied version of the source text)
http://www.dancedeets.com/events/1056563304381635/2016fun
http://www.dancedeets.com/events/1243934395650908/2016新北fun街頭板橋場初賽

Sounds reasonable. I think this can be improved without side effects. Need some clarifications:

Could you prepare samples via http://markdown-it.github.io/linkify-it/ ? I could not reproduce correct work with ascii vertical pipe (just copied your texts there).
Could you show such patterns at another sites (not facebook)? That's not mandatory condition, but interesting for me.
Does this problem happens only with asian pipe before links or with pipe after link too?

And one more question... The most of problems are caused by fact, that link in text can be "incorrect" (not percent-encoded, according to RFC). If anyone needs support only for "correct" links, that can solve a lot of problems (including better asian text recognition). But i have no statistics to decide.
By the way, may be FB linkifier works "better" because of bad support of advanced cases. I'd suggest to post linkifier test cases at facebook to check http://markdown-it.github.io/linkify-it/.

Here's the sample demonstrating the breakage:
http://markdown-it.github.io/linkify-it/#t1=%25 Regular pipes
|www.google.com%2F
www.google.com%2F|
www.google.com%2F|www.google.com%2F

%25 Magic pipes
｜www.google.com%2F
www.google.com%2F｜
www.google.com%2F｜www.google.com%2F

(Note that I'm comparing it with the existing pipe, which is considered a "valid" URL path character according to linkify, but not a valid domain character)

I'm not taiwanese, and so am not familiar with what taiwanese blogs, sites, etc might demonstrate this character. I run an international site for events, and so I was exposed to these characters (and the taiwanese-authored descriptions) through that. (And because Google told me I had broken links.) If you want, I can point at my site, which proxies the FB event descriptions...but I suspect you're not interested in those links. :)

It happens with the unicode pipe after link too. But it happens with the regular pipe after link too. So just matching the regular pipe's behavior, for me, would probably be good enough.

Yes, I'm aware that technically the standards allow for a variety of unicode characters in domains now, and that it makes the job of domain-name detection very difficult. Especially because unicode-domains are not always encoded (by design! since they look ugly when encoded). But I'm not sure I have any great answers/suggestions here.

For the moment, in my thousands of events (of which only some have URLs), these are the only characters folks were using that generated broken URLs according to Google. So I'm not worried about any more drastic changes/fixes here.

Short summary/memo about possible changes:

Full width vertical line \uFF5C, can be delimmiter both on start and end of link

Need to recheck more delimiter codes from https://github.com/markdown-it/linkify-it/issues/15#issuecomment-105666424.

ASCII | can be delimiter on start of link (but not on the end, because can exist in query)

If we're expanding the set of delimiter characters to the chinese ones in https://github.com/markdown-it/linkify-it/issues/15#issuecomment-105666424
Then in addition to the chinese ones they list （ ） ， ！ 。 ？ 【 】 ［ ］ 、 《 》 ★, I would also add the japanese ones 「」『』（）＜＞. I'm sure there must be a "list of unicode delimiters" somewhere:
punctuation, open
punctuation, closed
punctuation, open quote
punctuation, close quote
I found these from http://www.fileformat.info/info/unicode/category/index.htm

Adding punctuation chars without control can conflict with wikipedia links. Problem is that wiki link can contain almost anything.

I've released version with FF5C char support. Other chars not changed - not enougth info from real world.


Styling to the main page

Add proper styling to the tables and others in that main page i.e. add stylings in style-main. Also try to add a better background in that page.

Yeah Sure, go ahead :)
@Jsiddareddi-intuit

Hey @Code-Aditya-14, could you please assign this issue to me?

@Rashmisingh-18 I requested some changes in style-main page. You can do that and then I will approve your changes. Also if you want more such issue you may re-design the index page too.


TFS 2010 Team Build - Deployment - Installer Target - Deleting files C:\

Hi
Good Day !!!
We are using BizTalk Deployment framework 5.0 tool . it is a great tool which make the life easy for deployment. but we are facing a strange issue in one of the environment. which we tried simulating this in another machine but not able to get this.
Please throw some light on this. Thanks
Problem
We are trying to use the Deployment Framework for BizTalk (BTDF) which uses BizTalkDeploymentFramework.WiXSetup.targets, when we use the target name of "installer" the deployment from BizTalk actually does a . delete on all of the file from the root C:\ directory.
We have set the output path property as below

$(MSBuildExtensionsPath)\DeploymentFrameworkForBizTalk\5.0\
bin\Release\
$(TeamBuildOutDir)
false

errors
errors
Project "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for
BizTalk\1.0\Deployment\BztSystemTesting.STestCase.Deployment.btdfproj" (default targets):
T"obj\Server\redist\Deployment\Framework\Microsoft.Sdc.Common.tasks".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\Microsoft.Sdc.Tasks.dll" to "obj\Server\redist\Deployment\Framework\Microsoft.Sdc.Tasks.dll".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\ServerDeploy.bat" to "obj\Server\redist\Deployment\Framework\ServerDeploy.bat".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\ServerDeployWizard.bat" to "obj\Server\redist\Deployment\Framework\ServerDeployWizard.bat".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\ServerDeployWizardMSI.bat" to "obj\Server\redist\Deployment\Framework\ServerDeployWizardMSI.bat".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\ServerRedeploy.bat" to "obj\Server\redist\Deployment\Framework\ServerRedeploy.bat".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\ServerRedeployWizard.bat" to "obj\Server\redist\Deployment\Framework\ServerRedeployWizard.bat".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\ServerUnDeploy.bat" to "obj\Server\redist\Deployment\Framework\ServerUnDeploy.bat".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\ServerUnDeployWizard.bat" to "obj\Server\redist\Deployment\Framework\ServerUnDeployWizard.bat".
Creating directory "obj\Server\redist\Deployment\Framework\DeployTools".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\adapterXPaths.txt" to "obj\Server\redist\Deployment\Framework\DeployTools\adapterXPaths.txt".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\BounceBizTalkHost.vbs" to "obj\Server\redist\Deployment\Framework\DeployTools\BounceBizTalkHost.vbs".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\cscript64.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\cscript64.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\DeployBTRules.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\DeployBTRules.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\DeployBTRules.exe.config" to "obj\Server\redist\Deployment\Framework\DeployTools\DeployBTRules.exe.config".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\ElementTunnel.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\ElementTunnel.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\EnvironmentSettingsExporter.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\EnvironmentSettingsExporter.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\ExportBamDefinitionXml.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\ExportBamDefinitionXml.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\GacUtil.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\GacUtil.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\GacUtil.exe.config" to "obj\Server\redist\Deployment\Framework\DeployTools\GacUtil.exe.config".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\GacUtlRC.dll" to "obj\Server\redist\Deployment\Framework\DeployTools\GacUtlRC.dll".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\log4net.dll" to "obj\Server\redist\Deployment\Framework\DeployTools\log4net.dll".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\log4net.Ext.Serializable.dll" to "obj\Server\redist\Deployment\Framework\DeployTools\log4net.Ext.Serializable.dll".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\SetEnvUI.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\SetEnvUI.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\SetEnvUIConfig.xsd" to "obj\Server\redist\Deployment\Framework\DeployTools\SetEnvUIConfig.xsd".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\SetPackageIdentity.vbs" to "obj\Server\redist\Deployment\Framework\DeployTools\SetPackageIdentity.vbs".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\SSOSettingsEditor.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\SSOSettingsEditor.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\SSOSettingsFileImport.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\SSOSettingsFileImport.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\SSOSettingsFileReader.dll" to "obj\Server\redist\Deployment\Framework\DeployTools\SSOSettingsFileReader.dll".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\StopBizTalkHost.vbs" to "obj\Server\redist\Deployment\Framework\DeployTools\StopBizTalkHost.vbs".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\UacElevate.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\UacElevate.exe".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\WriteRegValue.vbs" to "obj\Server\redist\Deployment\Framework\DeployTools\WriteRegValue.vbs".
Copying file from "C:\Program Files (x86)\BTS.BztSystemTesting.STestCase for BizTalk\1.0\Deployment\Framework\DeployTools\XmlPreprocess.exe" to "obj\Server\redist\Deployment\Framework\DeployTools\XmlPreprocess.exe".
Copying file from "Framework\BizTalkDeploymentFramework.targets" to "obj\Server\redist\Deployment\Framework\BizTalkDeploymentFramework.targets".
Copying file from "Framework\BizTalkDeploymentFramework.WiXSetup.targets" to "obj\Server\redist\Deployment\Framework\BizTalkDeploymentFramework.WiXSetup.targets".
Copying file from "Framework\CopyDeployResults.msbuild" to "obj\Server\redist\Deployment\Fr
Attachments
DeployResults.zip
This work item was migrated from CodePlex
CodePlex work item ID: '10308'
Vote count: '1'

[tfabraham@8/29/2013]
Sorry that you encountered this.  In old versions it could happen when certain properties were not populated.  It appears that you are not using the final 5.0 release (RTW).  Since you say that you cannot replicate it on another machine, perhaps it's because you have an old version installed on your build server.  You'll want to make sure that dev machines and the build server all have 5.0 RTW installed.

[tvsrikanthin794@8/29/2013]
Hi
Thanks you for your response. Could you please share me the latest 5.0 RTM installation file.
Regards
Srikanth

[tfabraham@8/29/2013]
It's on the Downloads page:
http://biztalkdeployment.codeplex.com/releases/view/17826

[UnknownUser@9/6/2013]

Issue closed by tfabraham with comment
Cannot reproduce in BTDF 5.0 RTW - was possible in pre-release versions of 5.0
Reason closed
Can't Reproduce


Wrong unit description used in font-size

Preflight Checklist

[x] I agree to follow the Code of Conduct that this project adheres to.
[x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Wrong unit description used in font-size

To Reproduce
The unit displayed on the right side of the screen is in pt, but if we use the development tools to check, we can clearly see that this unit should actually be px, and in my understanding pt is short for point, which is the number that should be displayed at the top of the screen. (Here I cover it with another semi-transparent page)

Expected behavior
Show px here
Screenshots
If we really use pt as unit here, it should be bigger

Desktop (please complete the following information):

OS: windows
Browser: vivaldi
Version: 6.0.2979.22 (Stable channel)

I think a similar error is mentioned in this page #3455

Related: https://github.com/jgraph/drawio-desktop/issues/1448#issuecomment-2034609398

Fix in 24.2.7.


permission defined during compile

Hello thanks for a nice repo, however after setting up the docker environment and during compilation of the toolchain I encountered the following error.
><EMAIL_ADDRESS>install /root/openwrt/build_dir/target-mipsel_24kec+dsp_glibc-2.19/node-serialport-1.4.6/ipkg-install/usr/lib/node_modules/serialport
> node-pre-gyp reinstall --build-from-source --target_arch=${npm_config_arch}

sh: 1: node-pre-gyp: Permission denied
npm ERR! Linux 3.19.0-58-generic
npm ERR! argv "/root/openwrt/staging_dir/host/bin/node" "/root/openwrt/staging_dir/host/bin/npm" "install" "-g" "/root/openwrt/build_dir/target-mipsel_24kec+dsp_glibc-2.19/node-serialport-1.4.6"
npm ERR! node v0.12.7
npm ERR! npm  v2.11.3
npm ERR! file sh
npm ERR! code ELIFECYCLE
npm ERR! errno ENOENT
npm ERR! syscall spawn

npm ERR<EMAIL_ADDRESS>install: `node-pre-gyp reinstall --build-from-source --target_arch=${npm_config_arch}`
npm ERR! spawn ENOENT
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-pre-gyp reinstall --build-from-source --target_arch=${npm_config_arch}'.
npm ERR! This is most likely a problem with the serialport package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-pre-gyp reinstall --build-from-source --target_arch=${npm_config_arch}
npm ERR! You can get their info via:
npm ERR!     npm owner ls serialport
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /root/openwrt/feeds/packages/lang/node-serialport/npm-debug.log
make[3]: *** [/root/openwrt/build_dir/target-mipsel_24kec+dsp_glibc-2.19/node-serialport-1.4.6/.built] Error 1
make[3]: Leaving directory `/root/openwrt/feeds/packages/lang/node-serialport'
make[2]: *** [package/feeds/packages/node-serialport/compile] Error 2
make[2]: Leaving directory `/root/openwrt'
make[1]: *** [/root/openwrt/staging_dir/target-mipsel_24kec+dsp_glibc-2.19/stamp/.package_compile] Error 2
make[1]: Leaving directory `/root/openwrt'
make: *** [world] Error 2

I seems odd to have a permission error, am I missing something very obvious?
Thanks a lot

Hi @ianchen06
I have the same issue. Please remove node-hid and node-serialport if you don't need run node.js program.
Thanks.


yarn run gulp - Problem finding locally-installed gulp

After running yarn install, is unable to run successfully yarn run gulp, which output is:
\tests\Application> yarn run gulp
yarn run v0.22.0
$ gulp
[14:31:24] Using gulpfile C:\Coding\php\SyliusMyPlugin\tests\Application\gulpfile.js
[14:31:24] Starting 'admin'...
[14:31:24] Finished 'admin' after 11 ms
[14:31:24] Starting 'shop'...
[14:31:24] Finished 'shop' after 3.82 ms
[14:31:24] Starting 'default'...
[14:31:24] Finished 'default' after 41 μs
[gulp-chug] Gulpfile, Gulpfile.js, contents is empty. Reading directly from disk...

events.js:160
      throw er; // Unhandled 'error' event
      ^
Error: Problem finding locally-installed `gulp` for gulpfile undefined. (Try running `npm install gulp` from C:\Coding\php\SyliusMyPlugin\vendor\sylius\sylius\src\Sylius\Bundle\AdminBundle to install a local gulp for said gulpfile.)

Error: Cannot find module 'gulp' from 'C:\Coding\php\SyliusMyPlugin\vendor\sylius\sylius\src\Sylius\Bundle\AdminBundle'
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Also tried to run npm install gulp, which also installed globally, but it not helped. Windows 10 x64

I tried on mentioned project with composer update and on new vanilla Skeleton project, in both cases I received the same error above

Anyone solved this problem?

I found temporary solution
ln -s /path/to/tests/Application/node_modules /path/to/vendor/sylius/sylius/src/Sylius/Bundle/ShopBundle/
ln -s /path/to/tests/Application/node_modules /path/to/vendor/sylius/sylius/src/Sylius/Bundle/AdminBundle/

Same here.

@mikemix Make sure to recreate "node_modules" (the one at root of plugin folder) symlink after installing js/nodejs dependencies

Well I still got the same issue. Linking the mentioned folders didn't helped.
Is there a solution for this? Can't work like that

Well, this ticket started in jannuary and is still open. Any progress after 1 year?

I got same error on hold version, but now it's fixe.

I have the similar error on fresh installation after the yarn build
vagrant@ubuntu-bionic:/vagrant/tests/Application$ yarn build yarn run v1.17.3 $ gulp build [15:25:54] Requiring external module babel-register [15:25:54] Using gulpfile /vagrant/tests/Application/gulpfile.babel.js [15:25:54] Starting 'build'... [15:25:54] Starting 'buildAdmin'... [15:25:54] Starting 'buildShop'... [gulp-chug] Gulpfile, gulpfile.babel.js, contents is empty. Reading directly from disk... [15:25:54] 'buildAdmin' errored after 25 ms [15:25:54] Error in plugin 'gulp-chug' Message:     Problem finding locally-installed gulpfor gulpfile undefined. (Try runningnpm install gulp` from /vagrant/vendor/sylius/sylius/src/Sylius/Bundle/AdminBundle to install a local gulp for said gulpfile.)
Error: Cannot find module 'gulp' from '/vagrant/vendor/sylius/sylius/src/Sylius/Bundle/AdminBundle'
Details:
domainEmitter: [object Object]
domainThrown: false
[15:25:54] 'build' errored after 28 ms
[15:25:54] The following tasks did not complete: buildShop
[15:25:54] Did you forget to signal async completion?
error Command failed with exit code 1.
`

Workaround:
cd tests/Application/
yarn install --modules-folder=../../node_modules/

@vvasiloi would you be willing to add this workaround to the quick installation guide in the readme?

@pamil I will try setting --nodeModulesPath, it is a better option if it works.

Will it be solved by #186? Or is it a different problem?

@pamil yes, it will. The workaround I was talking about works only after removing the symlink.
I ended up using Docker containers, because I can use different versions and it's more convenient:
docker run -it --rm -v "$PWD":/usr/src/app -w /usr/src/app --name node node:6-alpine yarn install


Sign up with Vector Bot room

TBD

No sign up with Vector Bot room. Only basic "product tour and support bot" is planned


"Could not execute entrypoint stage 'client' due to errors, provided by 'puzzle-gui'!"

Updated from Puzzle 1.3.0 to 1.4.0 gave me a crash that involves in the Puzzle GUI
Nothing much about the crash, as how little Crashy giving such crash info
Crash link: https://crashy.net/BGJADFO8z4cY7pYbdX20
Crash file: crash-2022-09-29_23.27.08-server.txt
I have tried loading the mod independently and same issue for me with mods
If video/image needed to be provided, will do

You have an outdated version of MidnightLib in your mods folder, delete that.


Customisable click crosses (analysis cursor)

I think it would be a good idea to allow some sort of customisation for the "click" crosses (with the analysis cursor), since I often confuse it with the "miss" cross. (especially the orange one)

Maybe its just me, just a suggestion. Appreciate your amazing work on this tool!

I actually only had color customization in mind, but with your suggestion I am thinking of shape customization. If anybody has any other shapes/texture design in mind, please leave a comment down below.

pluses would be a good one
also circles with pluses or crosses inside


Split CYTHON_AVOID_BORROWED_REFS into two levels?

Describe your issue
My proposal is that we should probably be using CYTHON_AVOID_BORROWED_REFS for the nogil build, because borrowed references are an opportunity for nasty reference-counting races.
However, there are also places where it's unnecessary - for example in Cython utility code where we're dealing an element of a tuple that we've just created and has not yet been exposed to any other threads.
My proposal is that we add two levels of CYTHON_AVOID_BORROWED_REFS:

CYTHON_AVOID_BORROWED_REFS == 1 is what we currently do. It's largely targeted at implementations like PyPy where borrowed references confuse their C API implementation, and it tries to be fairly thorough.
CYTHON_AVOID_BORROWED_REFS == 2 is targeted at the nogil build and only avoids borrowed references where there's a danger than objects might be on multiple threads.

I've split the feature flags at need more than once. This seems reasonable. Something like "avoid long borrowed refs" or "avoid unique borrowed refs" might catch the idea of not keeping borrowed refs around for too long, and of not even keeping borrowed refs of things that we control.
It's worth trying out to see if this has a practical advantage, though. The two PyPy specific feature flags ended up going hand in hand almost all of the time, so there wasn't really a good reason to keep them after I had introduced them everywhere. They're still there.


Only support modern python versions

Bumps various versions to support Python3.10 (and consequently Ubuntu 22.04, as that's the system-default).
Removes support for EOL Python versions (we now only officially recognize >= 3.7).
CircleCI now runs tests against all supported python versions in parallel.

We now try rerunning all tests twice, because 4/4 independent runs all need to pass and apparently saCRIfICiAL GOats aRe NoT A VAlID BUsineSS eXpeNSE

Sacrificial goats may only be purchased using official provider in Baghdad.


Add Cronos networks

This PR adds the Cronos mainnet (beta) and testnet to the list of supported networks.

Closing for now


Change React.useEffect1(fn, []) to React.useEffect0(fn)

No change in behaviour, but this aligns better with the docs.

could you also check in the js build artifacts?

The build artifacts were identical since both calls compile to React.useEffect(fn, []) in JavaScript.

perfect. Then it's safe to merge I guess. Thanks!


Unable to build engine for llama on windows 10

System Info

x86_64
RTX4090
Intel Xeon 2696v4
128 DDR4 2400mhz

Who can help?
@Tracin @juney-nvidia
Information

[ ] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[ ] My own task or dataset (give details below)

Reproduction
First of all i was trying to run TRT-RAG-TensorLLM with the pre-build .engine for RTX4090. But this lead me to this error:
(venv) PS C:\Users\TeisWin10\clear\trt-llm-rag-windows> python3 test.py
[02/04/2024-20:03:18] [TRT] [E] 1: [stdArchiveReader.cpp::nvinfer1::rt::StdArchiveReader::stdArchiveReaderInitCommon::47] Error Code 1: Serialization (Serialization assertion stdVersionRead == kSERIALIZATION_VERSION failed.Version tag does not match. Note: Current Version: 228, Serialized Engine Version: 226)
Traceback (most recent call last):
  File "C:\Users\TeisWin10\clear\trt-llm-rag-windows\test.py", line 16, in <module>
    llm = LocalTensorRTLLM(
  File "C:\Users\TeisWin10\AppData\Local\Programs\Python\Python310\lib\site-packages\llama_index\llms\nvidia_tensorrt.py", line 173, in __init__
    decoder = tensorrt_llm.runtime.GenerationSession(
  File "C:\Users\TeisWin10\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorrt_llm\runtime\generation.py", line 457, in __init__
    self.runtime = _Runtime(engine_buffer, mapping)
  File "C:\Users\TeisWin10\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorrt_llm\runtime\generation.py", line 150, in __init__
    self.__prepare(mapping, engine_buffer)
  File "C:\Users\TeisWin10\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorrt_llm\runtime\generation.py", line 168, in __prepare
    assert self.engine is not None
AssertionError
Exception ignored in: <function _Runtime.__del__ at 0x0000028D2AC1C280>
Traceback (most recent call last):
  File "C:\Users\TeisWin10\AppData\Local\Programs\Python\Python310\lib\site-packages\tensorrt_llm\runtime\generation.py", line 266, in __del__
    cudart.cudaFree(self.address)  # FIXME: cudaFree is None??
AttributeError: '_Runtime' object has no attribute 'address'

It has an unmatched engine version. I guess this is because the pre-built engine was build sometime a go and it should be re-built.
Then i tried to build it myself and this happened:
(venv) PS C:\Users\TeisWin10\TensorRT-LLM\examples\llama> python build.py --model_dir C:\Users\TeisWin10\clear\trt-llm-rag-windows\meta-llama\Llama-2-13b-chat --quant_ckpt_path models\ --dtype float16 --use_gpt_attention_plugin float16 --use_gemm_plugin float16 --use_weight_only --weight_only_precision int4_awq --per_group --enable_context_fmha --max_batch_size 1 --max_input_len 3000 --max_output_len 1024 --output_dir models\Engine
Traceback (most recent call last):
  File "C:\Users\TeisWin10\TensorRT-LLM\examples\llama\build.py", line 22, in <module>
    import torch
  File "C:\Users\TeisWin10\clear\trt-llm-rag-windows\venv\lib\site-packages\torch\__init__.py", line 128, in <module>
    raise err
OSError: [WinError 127] The specified procedure could not be found. Error loading "C:\Users\TeisWin10\clear\trt-llm-rag-windows\venv\lib\site-packages\torch\lib\cudnn_adv_train64_8.dll" or one of its dependencies.

Expected behavior
A working pre-built engine for rtx4090
Or
A working build script for building the engine
actual behavior
Both have an error.
additional notes
I installed all nescacry packages: cuDNN, MPI, CUDA Toolkit.
There seemed to be a fix for:  [WinError 127] The specified procedure could not be found. Error loading "C:\Users\TeisWin10\clear\trt-llm-rag-windows\venv\lib\site-packages\torch\lib\cudnn_adv_train64_8.dll" or one of its dependencies.
Which is described here
But this is not working for me.

@teis-e have you tried building using the docker image provided? Building on bare windows never worked for me. Check out the instructions on the rel branch for the instructions to build with docker on windows.

No I haven't yet. I will try that.
Will that give me the option to build the TRT engine's as well?

No I haven't yet. I will try that.
Will that give me the option to build the TRT engine's as well?

Once you've built and installed the wheel, I believe you have to navigate to the examples\llama directory and run the script to build the engine:
python build.py --model_dir <path to llama13_chat model> --quant_ckpt_path <path to model.pt> --dtype float16 --use_gpt_attention_plugin float16 --use_gemm_plugin float16 --use_weight_only --weight_only_precision int4_awq --per_group --enable_context_fmha --max_batch_size 1 --max_input_len 3000 --max_output_len 1024 --output_dir <TRT engine folder>

Ah yes exactly. And this is al done in the docker container? Instead of the powershell?

Build the wheel in the container, then install the built wheel on your PC. First, make sure sure to mount a folder from your PC on the container. Once the build is complete, copy the generated *.whl file to the mounted folder. This ensures the file is available for installation on your PC. You may exit the docker workspace afterwards. Detailed instructions are in the #Docker build Instructions here: https://github.com/NVIDIA/TensorRT-LLM/blob/rel/windows/README.md

I understand now.
Altought running:  docker build --no-cache -t tensorrt-llm-windows-build:latest .
Hangs here for already 20 minutes, is this normal?:
Sending build context to Docker daemon   1.06MB
Step 1/24 : FROM mcr.microsoft.com/windows/servercore:ltsc2019
 ---> 5f9e1fdbbeba
Step 2/24 : SHELL ["cmd", "/S", "/C"]
 ---> Running in 554be3803cd8
 ---> Removed intermediate container 554be3803cd8
 ---> de26761d1c87
Step 3/24 : RUN powershell -Command     $ErrorActionPreference = 'Stop';     Invoke-WebRequest -Uri https://developer.download.nvidia.com/compute/cuda/12.2.2/local_installers/cuda_12.2.2_537.13_windows.exe     -OutFile "cuda_installer.exe";     Start-Process cuda_installer.exe -Wait -ArgumentList '-s';     Remove-Item cuda_installer.exe -Force
 ---> Running in b4c22a8124c9

I understand now.
Altought running: docker build --no-cache -t tensorrt-llm-windows-build:latest .
Hangs here for already 20 minutes, is this normal?:
Sending build context to Docker daemon   1.06MB
Step 1/24 : FROM mcr.microsoft.com/windows/servercore:ltsc2019
 ---> 5f9e1fdbbeba
Step 2/24 : SHELL ["cmd", "/S", "/C"]
 ---> Running in 554be3803cd8
 ---> Removed intermediate container 554be3803cd8
 ---> de26761d1c87
Step 3/24 : RUN powershell -Command     $ErrorActionPreference = 'Stop';     Invoke-WebRequest -Uri https://developer.download.nvidia.com/compute/cuda/12.2.2/local_installers/cuda_12.2.2_537.13_windows.exe     -OutFile "cuda_installer.exe";     Start-Process cuda_installer.exe -Wait -ArgumentList '-s';     Remove-Item cuda_installer.exe -Force
 ---> Running in b4c22a8124c9

Yes, please.

Are you sure? it is already taking over an hour
docker build -t tensorrt-llm-windows-build:latest .
Sending build context to Docker daemon   1.06MB
Step 1/24 : FROM mcr.microsoft.com/windows/servercore:ltsc2019
ltsc2019: Pulling from windows/servercore
cb524f6f2215: Pull complete
1581446d2913: Pull complete
Digest: sha256:097949cfe0247fde3f8457a4d68fffee63a2385fb83e3be4f5d0dd9a46e9a3c3
Status: Downloaded newer image for mcr.microsoft.com/windows/servercore:ltsc2019
 ---> 5f9e1fdbbeba
Step 2/24 : SHELL ["cmd", "/S", "/C"]
 ---> Running in 30d77bac1fd3
 ---> Removed intermediate container 30d77bac1fd3
 ---> d81bdbaae75f
Step 3/24 : RUN powershell -Command     $ErrorActionPreference = 'Stop';     Invoke-WebRequest -Uri https://developer.download.nvidia.com/compute/cuda/12.2.2/local_installers/cuda_12.2.2_537.13_windows.exe     -OutFile "cuda_installer.exe";     Start-Process cuda_installer.exe -Wait -ArgumentList '-s';     Remove-Item cuda_installer.exe -Force
 ---> Running in a6a03caf1620

On Windows (Docker). Following the instructions here, I didn't encounter any issues building the wheel: ensure to use the rel branch: git clone --branch https://github.com/NVIDIA/TensorRT-LLM.git. Let me know if you run into any issues, I can make a short recording and share.

I feel like I tried everything. Now even on Ubuntu i can't get the llama model to work.
Could you accept me on LinkedIn to help me?

Did you ever get this issue resolved? I am getting the same error

No i didn't

Facing the same issue in ubuntu docker image

@teis-e Do you still have the problem? If not, we will close it soon.


Which API parameter would be equivalent to "--config-locations"?

DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE

[X] I understand that I will be blocked if I intentionally remove or skip any mandatory* field

Checklist

[X] I'm asking a question and not reporting a bug or requesting a feature
[X] I've looked through the README
[X] I've verified that I have updated yt-dlp to nightly or master (update instructions)
[X] I've searched known issues and the bugtracker for similar questions including closed ones. DO NOT post duplicates
[X] I've read the guidelines for opening an issue

Please make sure the question is worded well enough to be understood
Which parameter should be used to change the path of the yt-dlp.conf configuration file via the YoutubeDL API? In other words, which API parameter would be equivalent to "--config-locations"?
ydl_opts = {
            'call_home': False,
            #'live_from_start': True,
            'forcejson': True,
            'logger': YTDL_Logger(),
            'no_color': True,
            'noplaylist': True,
            'no_warnings': True,
            'noprogress': True,
            'verbose': False,
            'quiet': True,
            'usenetrc': True,
            'netrc_location': netrc_file_path,
            #'cookies': cookie_file_path,
        }

Provide verbose output that clearly demonstrates the problem

[X] Run your yt-dlp command with -vU flag added (yt-dlp -vU <your command line>)
[X] If using API, add 'verbose': True to YoutubeDL params instead
[X] Copy the WHOLE output (starting with [debug] Command-line config) and insert it below

Complete Verbose Output
[debug] Command-line config: ['https://youtu.be/Jeb808rrdhY', '-Uv']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version<EMAIL_ADDRESS>from yt-dlp/yt-dlp [4d9231208]
[debug] Python 3.12.5 (CPython x86_64 64bit) - Linux-6.6.47-1-MANJARO-x86_64-with-glibc2.40 (OpenSSL 3.3.1 4 Jun 2024, glibc 2.40)
[debug] exe versions: ffmpeg 7.0.1 (setts), ffprobe 7.0.1, rtmpdump 2.4
[debug] Optional libraries: certifi-2024.07.04, requests-2.32.3, secretstorage-3.3.3, sqlite3-3.46.1, urllib3-1.26.19
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests
[debug] Loaded 1830 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version<EMAIL_ADDRESS>from yt-dlp/yt-dlp
yt-dlp is up to date<EMAIL_ADDRESS>from yt-dlp/yt-dlp)

The API doesn't use/load configuration files
Your API parameters (ydl_opts) are your config

Understood, everything is clear now, I’m going to close the issue.


Dead Trees

Hand built and or procedural, comprising of just logs (strictly no fences, slabs, stairs, etc in trees!).
References

Closing as marked "Done"


move mkchain to ParisC

set new proto params for mkchain
replace all occurrences of oxford with paris in docs, etc
launch ParisC baker by default

Oxford is absent in v20 container and beyond so mkchain is currently broken.
Tested that "mkchain" with no parameters generates a values.yaml which, when deployed, activates a chain and spins up a baker that generates blocks.

LGTM


Support Request: Devices found but no device showing under devices

Describe Your Problem
I have a Hub Mini, a pair of Curtain 3, and a Remote. Cloud Services is ON for the Curtains and I'm able to control them from SwitchBot app with Bluetooth turned off. I'm looking to connect them to HomeKit, but I can't find the Device ID for any of my devices.
Relevant log output
[12/14/2023, 4:45:03 PM] [SwitchBot] Initializing SwitchBot platform...

[12/14/2023, 4:45:03 PM] [SwitchBot] Initializing SwitchBot platform...

[12/14/2023, 4:45:03 PM] [SwitchBot] Initializing child bridge 0E:78:CD:28:FD:3F

[12/14/2023, 4:45:03 PM] [SwitchBot] Initializing child bridge 0E:78:CD:28:FD:3F

[12/14/2023, 4:45:03 PM] [SwitchBot] Launched child bridge with PID 8219

[12/14/2023, 4:45:03 PM] [SwitchBot] Launched child bridge with PID 8219

[12/14/2023, 4:45:07 PM] [SwitchBot] Loaded @switchbot/homebridge-switchbot v2.13.0 child bridge successfully

[12/14/2023, 4:45:07 PM] [SwitchBot] Loaded @switchbot/homebridge-switchbot v2.13.0 child bridge successfully

[12/14/2023, 4:45:07 PM] [SwitchBot] Total SwitchBot Devices Found: 4

[12/14/2023, 4:45:07 PM] [SwitchBot] Total SwitchBot Devices Found: 4

Config for homebridge-switchbot
{
    "name": "SwitchBot",
    "credentials": {
        "token": "xxx",
        "secret": "xxx",
        "notice": "Keep your Token & Secret a secret!"
    },
    "_bridge": {
        "username": "0E:78:CD:28:FD:3F",
        "port": 43553
    },
    "platform": "SwitchBot"
}

Screenshots

So even though the log says 4 devices found, no device is showing
Device & Model
Curtain 3 and Hub Mini
Node.js Version
v18.18.2
NPM Version
v9.8.1
Homebridge Version
v1.7.0
Homebridge SwitchBot Plugin Version
v2.13.0
Homebridge Config UI X Plugin Version
v4.54.1
Operating System
Ubuntu Jammy Jellyfish (22.04.3 LTS)

For curtain 3s you need to specify the deviceType in your config

For curtain 3s you need to specify the deviceType in your config

But how do I find its Device ID, since it shows "No Device"?

You go to the SwitchBot app > device > device settings > Device info. Copy the BLE MAC address, remove the colons and there is your deviceID.

That worked, thank you!
On Dec 16, 2023, at 2:40 AM, Donavan Becker @.***> wrote:

You go to the SwitchBot app > device > device settings > Device info. Copy the BLE MAC address, remove the colons and there is your deviceID.
—
Reply to this email directly, view it on GitHubhttps://github.com/OpenWonderLabs/homebridge-switchbot/issues/883#issuecomment-1858786010, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BEV7NAE776NODU2TIFBC2ETYJV3AZAVCNFSM6AAAAABAVWGKY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYG44DMMBRGA.
You are receiving this because you authored the thread.Message ID: @.***>


Bratseth/symmetric normalizing

Please review but don't merge.

It's to harmonize with the order used in tokenize.


verification response ok, but in fact not successful

Component
Forge
Have you ensured that all of these are up to date?

[X] Foundry
[X] Foundryup

What version of Foundry are you on?
forge 0.2.0 (7922fd5 2024-02-05T00:19:20.258041000Z)
What command(s) is the bug in?
forge verify-contract
Operating System
macOS (Intel)
Describe the bug
I found that no matter whether the verification is successful, verify-contract always returns "Response: OK". It should only return "Response: OK" when verification is successful.

Submitted contract for verification: OK does not mean it's successfully verified. This only means that the submission was successful, you have to use --watch or check later to see if it's been verified.


Adds native rust implementation for proto used by Sabre

This includes adding rust implementations for sabre payload, sabre state and pike agent and organization to the sabre sdk. The TP, CLI and examples are updated to use these instead of the protobufs directly. The pike state was left in because we need more thought about how we want pike and sabre to interact.
Also updates the version of the sdk, tp and cli because this is an api change and adds a section to the version compatibility doc.

My comments occur again at a number of places in that same file


add test import-cjs-out-node_modules

This PR add test for import cjs file form custom dir(out of node_modules) such as src_cjs. Is a good example for people try to use snowpack in old projects.

Associated discuss: https://www.pika.dev/npm/snowpack/discuss/384

Thanks for filing! We don't today support source code as CJS. Our ability to remove CJS support in your source code is what allows us to deliver on our promises regarding dev speed. See my response in the linked discussion as well


onConflict config option does not apply to implicitly created functions

Example:

This is actually a non-trivial problem. To fix it correctly, the "implicitely created function" should take the conflict strategy of its parent, or the general one. However, I'd need to rewrite some critical parts of Sandstone (this is planned anyway). But I won't take that risk.
Therefore, I fixed it partially: it will always default to the general strategy if it is "throw", "replace", "ignore" or "warn", but it won't take the conflict strategy of the parent.


Upgrade kaggle

Motivation for this change
Upgrade the kaggle command line API to its latest version.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[X] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@guillaumecherel Do you want to add yourself as a maintainer for kaggle?

I'd rather not, I'm not a regular user.

Master already contains the update.


Decouple transform from TensorSchema

Move the (optional) reader transform/map logic out of the base TensorSchema to a separate MappedTensorSchema proxy class.
Also did two minor internal TensorSchema changes:

Drop TensorSchema.sparse property
Make SparseTensorSchema.key_range (effectively) a cached property that caches the key_range the first time it is computed.

Superseded by #167


MM-23415: Reload channel moderations upon change to channel type (pri…

…vate/public).
Summary
Update the channel moderations from the server if the channel type (public vs private) has been changed and saved.
Ticket Link
https://mattermost.atlassian.net/browse/MM-23415

I think this is a duplicate of https://github.com/mattermost/mattermost-webapp/pull/5074


Update gitbook.rb

Hi, I just saw that some users are still installing the GitBook editor using homebrew (this editor is deprecated since november 2014), we changed the repository name (editor is now a private repository).
A new version of the editor is coming next month with support for desktop.

So this one is discontinued, but a new version will be coming soon?

This one is discontinued (but it's still working fine). When the new version will come out, the auto-update will also work for it.

Yes, but we have special cases for discontinued apps, which is why this is important. When the new version comes out, will it still use this repo?

Thank you for the contribution. It needed some fixes, so they were made in cb1f8a34e2f454b04fc67ed1bfb780dfb9a87429. Your contribution is still included (and still credited to you), with the appropriate modifications. Please feel free to ask about any of the changes.


CORS Filter and authenticator s bug

the authenticator will broken the CORS Filter when did the ajax request with rest api.
the code:

    public function behaviors()
    {
        $behaviors = ArrayHelper::merge(parent::behaviors(), [
            'corsFilter' => [
                'class' => \yii\filters\Cors::className(),
            ]
        ]);

        $behaviors['authenticator'] = [
            'class' => CompositeAuth::className(),
            'authMethods' =>
                  HttpBasicAuth::className(),
                  HttpBearerAuth::className(),
                  QueryParamAuth::className(),
                ]
            ];

        return $behaviors;
    }

and then do the ajax call with Bearer auth, if the access token match, everything is working nice.
if the access token is wrong, the browser like Chrome will show error and return a canceled status (it means the ajax can not get the response json data):
XMLHttpRequest cannot load Origin “xxx” is not allowed by Access-Control-Allow-Origin.
the bugs was in the code 'beforeAction' of the classes Http****Auth, it will return false or null when the access token was wrong. but the return false or null also stop the CORS Filter class, the header 'Access-Control-Allow-Origin' will not sent. (maybe the invoked order issue of the external actions).
the bug was shown under yii2 RC.

As @fernandezekiel suggested, my problem was HttpBearerAuth trying to authenticate the preflight request which shouldn't send a bearer token or any other form of authentication. My workaround was to add an actionPreflight to my controller, and routed all my OPTION requests to this action so I could avoid authenticating that action, and just not return anything so the headers would be sent to the client verifying my server supports CORS. Seems hackish, but I couldn't think of a better way of doing that , and I needed to get moving quickly on my project.

The same problem. Workaround
$behaviors['authenticator'] = [
    'class' => HttpBearerAuth::className(),
    'except' => ['options'],
];

DarwinIsGod's option worked, I initially never tried because I thought routing to the already available options action would fix it, and when it didn't never tried making my own.
+1

This is a bug, Maybe
see: http://stackoverflow.com/questions/26296779/chrome-v37-38-cors-failing-again-with-401-for-options-pre-flight-requests
So browsers MUST not send the credentials in OPTIONS request. They will do in actual requests. If you write withCredentials = true the browser should do what I say. ```

I think the reason why this issue is happening here is because the authenticator filter is getting treated before the corsFilter.
check the content of parent::behaviors() here. authenticator is defined but not corsFilter, so any attempt to merge an array with named keys authenticator and corsFilter will just override the first and push the second (corsFilter) to the bottom of the array. reason why CORS are only working if authentication succeed and never reached otherwise.
to confirm this please any one try to rename $behaviors['authenticator'] = to just $behaviors[1] = or to define no keys like :
return \yii\helpers\ArrayHelper::merge([
    [
        'class' => Cors::className(),
        'cors' => [ ... ],
    ],
    [
        'class' => HttpBearerAuth::className(),
    ],
], parent::behaviors());

If it work then a solution to this would be by simply defining corsFilter just before authenticator inside yii\rest\Controller::behaviors() :
...
'corsFilter' => [
      'class' => Cors::className(),
],
'authenticator' => [
...

Cors filter is needed by most people using rest any way and its default configs should work for any one I guess (see this). the other option would be removing 'authenticator' from parent::behaviors() and let developper define both inside his controller in the order he choose.

one more thing. the authenticator should be defined this way :
[
    'class' => \yii\filters\auth\HttpBearerAuth::className(),
    'except' => ['options'],
],

in order to OPTIONS to work.

this code work for me
[
'class' => \yii\filters\auth\HttpBearerAuth::className(),
'except' => ['options'],
],
thanks, but i think core team should be fix this , because api rest and authentication + cors filter is huge needed.

This issue still come after sometimes run, then i try to separating check cors by adding manually function.
function cors() {

        // Allow from any origin
        if (isset($_SERVER['HTTP_ORIGIN'])) {
            header("Access-Control-Allow-Origin: {$_SERVER['HTTP_ORIGIN']}");
            header('Access-Control-Allow-Credentials: true');
            header('Access-Control-Max-Age: 86400');    // cache for 1 day
        }

        // Access-Control headers are received during OPTIONS requests
        if ($_SERVER['REQUEST_METHOD'] == 'OPTIONS') {

            if (isset($_SERVER['HTTP_ACCESS_CONTROL_REQUEST_METHOD']))
                header("Access-Control-Allow-Methods: GET, POST, OPTIONS");

            if (isset($_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']))
                header("Access-Control-Allow-Headers: {$_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']}");

            exit(0);
        }
    }

//call by
public function behaviors()
    {
        $this->cors();

        $head = [
            [
                'class' => ContentNegotiator::className(),
                'formats' => [
                    'application/json' => Response::FORMAT_JSON,
                ]
            ],

            [
                'class' => \yii\filters\auth\HttpBearerAuth::className(),
                'except' => ['options'],
            ],
        ];

        return \yii\helpers\ArrayHelper::merge($head, array());

    }

i think any something wrong when check cors using yii function.but i dont know where is it.

See https://github.com/yiisoft/yii2/pull/8626

this code works for me :
`public function behaviors()
{
$behaviors = parent::behaviors();
unset($behaviors['authenticator']);
$behaviors['corsFilter'] = [
'class' => Cors::className(),
];
$behaviors['authenticator'] = [
'class' =>  HttpBearerAuth::className(),
'except' => ['options'],
		];
		return $behaviors;

	}`


review and updated

#MVPHackadoc

This looks like a duplicate of https://github.com/MicrosoftDocs/SCCMdocs/pull/420, which is already merged and closed. I'm closing this pull request; please reopen if I'm missing something.


Rotation helper shows inconsistent coordinates for the rotation origin

getComputedParams currently returns the rotation origin properties (rx, ry) relative to the key's position. The reasoning is because previously these were returned in the form of CSS properties, and that transform-origin would be relative to the element's top-left corner.
The result now is that multiple keys can share the same rotation origin but the helper will display different coordinates for the same point.

I was mistakenly referencing the key's position, not its rotation origin. 🤷♂


VidCoder: fixes a no-longer-available VidCoder configuration option

Fixes #7302

@niheaven is the CI failing because of https://github.com/ScoopInstaller/Scoop/pull/4528?

Seems like all commits in buckets are failing checks


⚠ Bofrost.at has degraded performance

In 403176a, Bofrost.at (https://www.bofrost.at) experienced degraded performance:

HTTP code: 200
Response time: 901 ms

Resolved: Bofrost.at performance has improved in b22988d.


The crash in ThaumBases and AM2

When I was put AM2 and ThaumBases in one packs, they crash, how to fix this?

sorry，this problem was fix, there are two enchanting ID crash, just change enchanting id in config: thaumic bases, and change to other id.


Fix scss lint errors

Use the sass-lint feature/disable-linters to check it works
Add inline disabled linters where a thing is likely to be refactored
Remove warnings for forcing nesting (I'm not sure we want to do this)
Fix errors that are easy to fix
Add some comments for linter rules in the .yaml file (not yet finshed).

Don't merge just yet, I'm adding comments to the yaml file so it's clear which rules are being enforced.


[release] Update version.py

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


p2p.Stream FullClose

So we can do this https://github.com/ethersphere/bee/pull/13 with p2p.Stream as well.
TODO in separate PRs:

add usage for every protocol
mock fullclose in handshake

@janos Sorry, I wanted to quickly add the simple implementation just in order  to use it in hive PR's, and to implement tests and mocks later, my bad. I will do a more thorough implementation with tests first.
As far the usage go, I think it would be good to do it on request/msg send sides of protocol, to make sure that request/msg was received. I am not sure what would happen if the requesting side closes  it's side of the stream, and tries to make another request before the receiving side closed it's side of the first stream.
Anywayz, I will split the PR into FullClose and the naming stuff, so it does not pollute and block each other, and will update this PR with tests.

@janos Thanks for the nice review! Done, hope this is what you had in mind. Regarding the lint error, it looks like started happening randomly at the same tame as the race condition one. I'll keep an eye for it!

Btw, linter still breaks on every first run, and works when re-run 🤷♂

Cool, let's keep track on timeouts then. I did not find any better way so far, and it seems that they (libp2p) are using similar stuff at the moment in their code and examples.


Document our GA setup in Gitbook

What is it and who's it for?

Gitbook documentation to outline how we've set up GA4
For Digital Engagement and anyone else we work with internally

What's included

Property-level information (inc GTM and Google Ads linkages)
How to get access + what access permissions we allow
A link to, or inclusion of, a glossary/list of all the events we use
Any information for marketing colleagues on getting access for 3rd party partners
Point to any vetted training material (see #9200 )

Done when

First draft document reviewed by team
Document published in Gitbook

Documentation
GA4 and GTM documentation (Tacey's doc on Sharepoint)

GitBook link: https://app.gitbook.com/o/-LumfFcEMKx4gYXKAZTQ/s/MM8zK9GZyFCpy8kvd5Km/

https://app.gitbook.com/o/-LumfFcEMKx4gYXKAZTQ/s/MM8zK9GZyFCpy8kvd5Km/analytics-and-reporting/using-google-analytics-4-ga4

It would be helpful to get a list of Segment events to include on this page: https://app.gitbook.com/o/-LumfFcEMKx4gYXKAZTQ/s/MM8zK9GZyFCpy8kvd5Km/analytics-and-reporting/google-analytics/analytics-event-tracking
@gestchild probably knows most about how to get this most efficiently

It would be helpful to get a list of Segment events to include on this page

So almost my coincidence, I was looking at something similar to this in https://github.com/wellcomecollection/wellcomecollection.org/pull/9691
It doesn't give you the documentation you need, but it does take a step in that direction.


Remove cpurc warning

Signed-off-by: Graham MacDonald<EMAIL_ADDRESS>

Fine, I forgot this when @dancrossnyc suggested -f


Array tools

Describe the extension
This adds a lot of of utility functions for working with arrays. It adds the following types of possibilities:

Combining arrays (concatenate into new array, append all children to another array)
Finding a value in an array (find index expression, contains condition)
Reversing arrays
Get a portion of an array (slice)
Add and remove lots of children at specific indices at once (fill, splice, shift, pop, add at index)
Randomness (shuffle children, get a random child)
Mathematical operations using arrays (sum of all numbers, biggest/smallest number, average number, median number)
Sort numbers in an array
String inter-operation (split string into array, join array array children to string)

Checklist

[X] Extension has a proper name and description.
[X] Extension has tags (for example: "platform, brick, breakable").
[X] All behaviors have a description.
[X] All functions (actions, conditions, expressions) have descriptions and proper sentences.
[X] I've followed the best practices listed on http://wiki.compilgames.net/doku.php/gdevelop5/extensions/best-practices
[X] I confirm that this extension can be intergrated to this GitHub repository, distributed and MIT licensed.

Example
I don't have an example file, but I have (arguably) better. Here are some unit tests in a GDevelop project file:
arraytools-unit-tests.zip
Extension file
ArrayTools.zip

Verification list

[ ] Contains
[ ] Index Of
[ ] Last Index Of
[ ] Flatten
[ ] Splice
[ ] Slice
[ ] Sum
[ ] Shuffle
[ ] Reverse
[ ] Sort
[ ] Min
[ ] Max
[ ] Join
[ ] Split
[ ] Mean
[ ] Median
[ ] Get Random Child
[ ] Fill
[ ] Concat
[ ] Append To
[ ] Pop
[ ] Shift
[ ] Insert variable at

In the ShadowClones extension, my current logic is this:

Assume N = number of shadow clones * frames between clones
Copy all child variables from ObjectHistory.N to ObjectHistory.N+1 (this can result in copying thousands of variables every frame)
Create a new child variable at ObjectHistory.1 based on current values of sprite

I think for this logic to work with arrays, I need to use "unshift: Adds new elements to the beginning of an array".

Assume N = number of shadow clones * frames between clones
Unshift array to create new child based on current values of sprite
Pop array until array length = N (this will remove old data that we don't need any longer)

Using arrays should be MUCH more performant compared to copying values of all child variables.
TLDR: Can you please add "unshift"?

I intentionally didn't add unshift as I think it may bloat a bit too much considering the insert variable at with index parameter 0 is equivalent

I intentionally didn't add unshift as I think it may bloat a bit too much considering the insert variable at with index parameter 0 is equivalent

Ah, yes, that sounds like it is what I need (and more flexible for other uses).  Thanks!

Math.min.apply(Math, arr.map(variable => variable.getAsNumber()));
// Prefered solution:
Math.min.apply(null, arr.map(variable => variable.getAsNumber()));
Math.min(...arr.map(variable => variable.getAsNumber()));

Remember that in the context of JavaScript written for games, it's actually better not to use map/filter as they will create new arrays in memory, and will create pressure on the garbage collector.
Using apply with an array is also a risk to crash/slow down terribly the JS engine because you're calling a function with as much parameters as the the array length... imagine if this is an array of 1000 or 10000 objects - JS engines are not ready for these and will deoptimize (at best).
Instead, just do a for loop and keep the minimum or maximum value. It's the most efficient, no slow down, 0 memory allocations, and probably optimized by JS engines.

Instead, just do a for loop and keep the minimum or maximum value. It's the most efficient, no slow down, 0 memory allocations, and probably optimized by JS engines.

Done, here is the modified extension and unit tests:
ArrayTools.zip
arraytools-unit-tests.zip

Something interesting during my review, the long description is not show for Boolean type!

I was wondering, should an expression that builds an array out of the key of a structure (Object.keys) be part of this extension or of a "Structure tools" extension?

Good question.. Might be the same extension but should this be renamed to "Collection variable tools" then?

🤔 It's ok for me, but if it becomes tools for collections generally it might grow huge quickly, while separating in multiple extensions would allow to have smaller more maintainable packages.

I honestly don't have a strong feeling on this, on the other hand it might be simpler for the user to just install one extension?
But feel free to do a separate one if you prefer!

My preference is to consolidate extensions that are highly related, but like Florian said it is up to you.
For array functions, is there a reason they make sense as an extension versus provided by default in GDevelop?

For array functions, is there a reason they make sense as an extension versus provided by default in GDevelop?

One reason if any is that it's 1) faster to get these made as extensions now, so that we can try and use them as soon as the extension is ready and 2) safer, in the sense that if the interface (the conditions/actions names, parameters, etc...) are not perfect, we can fix that by releasing an update extension.
On the other hand, everything that is by default in GDevelop is considered to be there "forever", and any breaking change must be either avoided or automatically upgraded. As the article says, APIs, like diamonds, are forever.
This being said, it's also possible that we "graduate" the extension or part of it into a built-in GDevelop extension, after we have proved it's 1) well designed and 2) used by a number of games so large that it's better to have it not as an extension.
Finally, all this discussion could maybe be avoided if in the future we push more extensions in the interface, and we could even suggest a set of "default extensions" to be used in new games :)

4ian thanks for the great answers to my questions.
Now for more questions:
Are you considering adding support for 2D arrays?  This would help with mapping 2D grids.  For instance, fog of war opacity values.... ;)

Arrays can already be 2D, a 2D array is just an array of arrays, and arrays can contain any variables including arrays.

(For the next update) Add a "unique" function (perhaps as a parameter on sort) that only keeps one instance per number.
Use case:  I am using a secondary array to track the indexes of a primary array that need to be modified.  This secondary array might contain the same value multiple times.  However, I only want to apply the modification one time per value.   With a unique function, I could do this.

I'm starting to collect ideas for the next update too. That sounds like a good idea. Some other ideas I had:

create an array of structure keys
remove all "falsely" values (0, "", "0", false, "false", "null"...)
chunk array (chunk [1,2,3,4,5,6] by 3 it becomes [[1,2,3],[4,5,6]], by 2 it becomes [[1,2],[3,4],[5,6]])
structure to pairs: {a:1,b:"yes"} => [["a", 1], ["b", "yes"]]
convert pair back to structure
create array with all items that are in both 2 input arrays([1,2] and [2,3] => [2])
remove all values in array2 from array1 ([1,1,2,3,4] and [1,3] => [2,4])
remove an array of indices ([1,2,3,4,5] and [0, 2] => [2,4,5])


TechDebt - MyPy Budgets

Codecov Report

Merging #5591 (70026d7) into master (8c88a93) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5591   +/-   ##
=======================================
  Coverage   96.18%   96.19%
=======================================
  Files         742      742
  Lines       72606    72602    -4
=======================================
+ Hits        69835    69837    +2
+ Misses       2771     2765    -6

Flag
Coverage Δ

servertests
36.92% <94.73%> (+<0.01%)
:arrow_up:

unittests
96.12% <100.00%> (+<0.01%)
:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

moto/backends.py
93.75% <100.00%> (+15.37%)
:arrow_up:

moto/budgets/exceptions.py
100.00% <100.00%> (ø)

moto/budgets/models.py
100.00% <100.00%> (ø)

moto/budgets/responses.py
100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Improvement of Header and Footer

We can use bootstrap to improve the header and the footer of the App, with a better font, color, and responsiveness.
Let me know if I can work on this one.

Go ahead


defaulting to singleton Bean scope

As only one client connection should be established using prototype is not correct , hence reverting to default singleton scope.

@rajadilipkolli,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

Codecov Report

Merging #96 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #96   +/-   ##
=======================================
  Coverage   52.06%   52.06%
=======================================
  Files          35       35
  Lines         557      557
  Branches       47       47
=======================================
  Hits          290      290
  Misses        244      244
  Partials       23       23

Impacted Files
Coverage Δ

.../mediaservices/MediaServicesAutoConfiguration.java
62.5% <ø> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86aa124...9c2bae2. Read the comment docs.

@rajadilipkolli any issue you found using prototype?

Its establishing new client connection every time Mediaclient is called which is heavy weight and time consuming also from memory perspective it is increasing drastically
I think same applies to storage autoconfigure as well where it is defined as prototype
Singleton, will create a new instance in the first call, and return it in subsequent calls. Prototype will return a new instance each time. ... If scope is set to singleton, the Spring IoC container creates exactly one instance of the object defined by that bean definition So as one instance is enough using the same

I feel https://github.com/Microsoft/azure-spring-boot-starters/blob/master/storage/azure-storage-spring-boot-autoconfigure/src/main/java/com/microsoft/azure/autoconfigure/storage/StorageAutoConfiguration.java#L39 this should also be changed to singleton. I don't see reason for prototype

@rajadilipkolli The client is not guaranteed to be thread-safe. If user want to use multi threading and multiple client instances, it has to be prototype.


feat: allow release based on git hash

Related Issue or Design Document

Checklist

[ ] I have read the contributing guidelines
and signed the CLA.
[ ] I have referenced an issue containing the design document if my change
introduces a new feature.
[ ] I have read the security policy.
[ ] I confirm that this pull request does not address a security
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got approval (please contact
<EMAIL_ADDRESS>from the maintainers to push
the changes.
[ ] I have added tests that prove my fix is effective or that my feature
works.
[ ] I have added the necessary documentation within the code base (if
appropriate).

Further comments

We don't always want to release HEAD of master but instead a git tag form e.g. a few days ago. That's what this feature is for!


Failed to run atomically, multiple threads updating balancer simultaneously

2021/08/23 06:44:51 [error] 1827#0: *18477198099 lua entry thread aborted: runtime error: /usr/share/lua/5.1/resty/dns/balancer/base.lua:389: Failed to run atomically, multiple threads updating balancer simultaneously stack traceback: coroutine 0:         [C]: in function 'assert'         /usr/share/lua/5.1/resty/dns/balancer/base.lua:389: in function 'assert_atomicity'         /usr/share/lua/5.1/resty/dns/balancer/base.lua:573: in function 'queryDns'         /usr/share/lua/5.1/resty/dns/balancer/base.lua:1206: in function 'cb_expire'         /usr/share/lua/5.1/resty/timer.lua:87: in function </usr/share/lua/5.1/resty/timer.lua:51>, context: ngx.timer
hi, there is a bug that i can not find the reason, can you give me some tips?
I am using 1.5.0 kong.It seem report every moment, but kong still work fine.

plz let me know if you need more information.


Pass through authentication supports write-back

Added * Supports password resets for users that use Azure AD Pass-through Authentication: With password writeback, as long as the user accounts are synchronized into your Azure AD tenant, they are able to manage their on-premises Active Directory passwords from the cloud.
Partner complained this was confusing since we did not explicitly call this out in our documentation.  Please update.

@chadhasbrook : Thanks for your contribution to the Azure documentation! The author, @MicrosoftGuyJFlo, has been notified to review your proposed change.

Updated in another public PR from the community.

#please-close


does it handle single term synonym

does it handle single term synonym, If yes where do we have to provide the synonyms?
do I need to add changes in synonyms.txt or autophases.txt or both?

Please give an example if possible.
Thanks in advance


[20] Deploying whatsapp bot on Heroku

Closes #20
Added changes to deploy the whatsapp bot Flask app on Heroku, using Docker
Also added a Dockerfile for deploying our streamlit app on Heroku (created it as part of testing Heroku)
Detailed description and instructions added in a readme file.

I would recommend using Dockerfile.heroku only when deploying on Heroku, and then you would have to run
heroku container:push heroku --recursive --app <your_app_name>

Whereas for your local setup and probably other use cases, should go with your main Dockerfile

And FYI the naming convention is a workaround to specify custom Dockerfile names...