Setting the prototype of namespaces should be disallowed

Setting the prototype of namespaces should be disallowed.
Steps to reproduce
In make-importer, replace moddir/index.js with:
export const foo = null;
import * as ns from './index.mjs';
var newProto = {};

let err;
try {
  Object.setPrototypeOf(ns, newProto);
} catch(e) {
  e = err;
} finally {
  if (err instanceof TypeError) {
    console.log('setting prototype of namespace is disallowed');
  } else {
    throw 'should not allow setting prototype of namespace';
  }
}

Then execute:
$ node -r esm test/test-moddir.js
TAP version 13
# moddir index.js
not ok 1 unexpected exception
  ---
    operator: notEqual
    expected: 'should not allow setting prototype of namespace'
    actual:   'should not allow setting prototype of namespace'

Expected result: no error. See the reference.
https://test262.report/browse/language/module-code/namespace/internals/set-prototype-of.js
This is something we should flag to esm:
$ node --trace-uncaught -r esm test/moddir/index.js
should not allow setting prototype of namespace
Thrown at:

And node native modules:
$ echo "import { foo } from '/Users/jfparadis/projects/make-importer/test/moddir/index.mjs';" |   node --experimental-modules --input-type=module
(node:42292) ExperimentalWarning: The ESM module loader is experimental.
should not allow setting prototype of namespace

Module namespaces are now proxies that refuse changes to their prototype. The scope of this issue is now to ensure that this case is tested.


Fix accepting different token types

Fixes accepting different token types
If no one’s got objections I’ve started writing up a draft of a GitHub action for rokit so I’d love to be the one to publish it if that’s okay.
Removing regex was @Dekkonot's suggestion so if you can somehow add him as a coauthor that'd be great!

Sorry just realised I left the test in there, if someone could remove that then that’d be great 😅

Glad to see this. I switched to Rokit recently for a few things I'm working on, and the token auth issue completely severed my ability to publish packages via GitHub Actions.

If no one’s got objections I’ve started writing up a draft of a GitHub action for rokit so I’d love to be the one to publish it if that’s okay.

Sidenote- this was already made, but it's currently nonfunctional due tot he aforementioned issue.

Yeah I didn't know that until yesterday but as long as someone's done it then that's fantastic! 😄


Would it be possible to combine Linux and Windows for automatic build?

I was wondering if it was possible to combine the two together.

What do you mean?

Put Linux and Windows in the automatic build without having to download separate versions.

I don't really see why I'd want to do that. The executables are already fat as it is.

The file is 50 MB, it's tiny. In short, as you wish.

I think I'd rather keep them separate. Windows users don't really need Linux binaries, Linux users might need Windows binaries if the game for some reason runs better under Wine for them, and users that want both are rare enough that I doubt downloading a second ZIP would be a major inconvenience. Not to mention it's easier to write CI scripts to handle them separately.


onDomRefresh and onAttach not fired in modal views

Hello,
Thanks for this boilerplate. It's not an issue but I can't figure what's going on : I want to put a form in a modal. I've edited the modal service, everything goes fine, my modal is form shown,  but the modal's view onDomRefresh and onAttach methods aren't fired.
I've added an onDomRefresh with a console log in ModalAlertView... it isn't fired too... I'can't figure why

The modal LayoutView itself is never destroyed, it simply uses Bootstraps modal plugin to show and hide itself.
The view inside the modal content region should be firing the onDomRefresh and onAttach triggerMethods. If you can create a reproducible test case I can attempt to debug it.

Thanks, I found a workarround but when I'll have fully understand how to write tests with pioneer, I'll push a test case.

Let me know when you have something and I'll reopen this


read2tree for NGS

Can we use it for targeted sequencing like 16S?

Hi @Tantoluwa ,
yes, this should be no problem. I suggest you then use also only the 16s reference oma groups (simply filter for those OMA groups that contain the 16S gene in your reference speices set).
Cheers Adrian


Revert "[Improvement] Abnormal characters check"

Since this pr make the resource center doesn't work, due to the check method is incorrect.
The file path will have prefix e.g. "hdfs://", 'file://'

https://github.com/apache/dolphinscheduler/issues/16006


Code Indentation corrections

Some of the code blocks had some parentheses improperly aligned. This pull request fixes those.

Excellent thanks!


Remove showMinimal conditional

Context
All courses will/should have full information
Changes proposed in this pull request

Remove external course detail link
Remove condition to only show minimal info used in private beta

Guidance to review
Any course page. There is no visual change.

All courses will/should have full information
This isn't quite right – we’ll automatically publish all UCAS courses before they're enriched. The minimum course detail page will look like: https://search-and-compare-prototype.herokuapp.com/course/2CC/378J

@dankmitchell with @fofr's comment, is this still up to relevant, or can this be closed?

This is much easier to review when ignoring whitespace: https://github.com/DFE-Digital/search-and-compare-ui/pull/74/files?utf8=✓&diff=split&w=1


Mock ANCM for testing purposes

In Kestrel, we currently mock libuv for testing purposes. We should consider doing this for ANCM, as it would ease identifying if there were bugs in IISIntegration or ANCM. This could also be shared to Kestrel/ANCM to verify behavior behind it.

Won't be doing this.


Update database automatically when releasing

Remove the database shipped with the library, instead, the database will be downloaded automatically if it doesn't exist. When the configuration is Release, it will also update the database so the final product always has the update-to-date database.

Fabulous!
Thanks.

Can you release a new version now?

Thanks

Is the database downloaded from http://geolite.maxmind.com/download/geoip/database/GeoLite2-Country.tar.gz?
Why is it not working?

I made a mistake, fixing

Failed to pass pod lint. FYI.

It doesn't seem like cocoapod will allow some setting script run before init?

Found prepare_command


lockProperties() interferes with 3rd party plugins

3rd party components e.g. Filament can't work when lockProperties() is activated because they (obvioulsy) don't use the package and have not unlocked their components yet. So it would be great if e.g. all components in vendor could be excluded.
For components that extend vendored components it would be tricky too. So maybe an additional opt-in/opt-out for specific App namespaces would be great. But that would probably make Livewire less strict when the strict mode is configured bad? So any non-vendir should maybe just use #[Unlocked] for the whole class?

Thanks @tpetry 😄 Working on a solution for this 🙌🏻

Any traction on this? Currently having this same issue with Laravel Pulse

@tpetry @DanjBethel added this:
https://github.com/wire-elements/livewire-strict/releases/tag/2.0.0
By default, it will only lock components inside the App\Livewire\* namespace. If you want you can override this:
LivewireStrict::lockProperties(components: [MyComponent::class, 'SomeNamespaces/*']);


Add open source standard

Fixes #5
Proposed Changes

[x] Add code of code of conduct (see CODE_OF_CONDUCT.md file).
I am proposing the usage of Contributor Covenant. Why? this code of conduct has already been adopted by over 200,000 open source projects (such as React, Tensorflow, Salesforce OSS, Golang, etc).
[x] Add badges to readme.
[x] Add issue templates md file. See this github doc.
[x] Add pull request template md file.  See this github doc.
[ ] Enable reported content for the repository.  see https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/managing-how-contributors-report-abuse-in-your-organizations-repository

@gentaiscool when you get a chance, please kindly check the changes. Thanks.

Need someone with admin access enable this setting: https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/managing-how-contributors-report-abuse-in-your-organizations-repository

Need someone with admin access to enable this setting: https://docs.github.com/en/free-pro-team@latest/github/building-a-strong-community/managing-how-contributors-report-abuse-in-your-organizations-repository

done. The commits look ok.


Doesn't support hibernate annotation or others for service body parameter.

    @RequestMapping(value = "/register", method = RequestMethod.POST)
    public SessionModel register(
        @Valid RegisterModel registerModel
    ) {
        return new SessionModel(userService.register(registerModel));
    }

registerModel should be body parameter.

if RegisterModel is just a pojo.. this should work flawlessly.. can you help me understand what is happening and provide some more background.

This happens in RequestMetaBuild.addParams. if parameter has annotation qbit thinks  it should be one of requestParam, headerParam or pathParam.

ic... Can you create a PR?


backend:impl:test failing at org.jetbrains.intellij.plugins:gradle-intellij-plugin:1.16.0

1.15.0 is okay.
> Task :backend:impl:test FAILED

FAILURE: Build failed with an exception.

* What went wrong:
A problem was found with the configuration of task ':backend:impl:test' (type 'Test').
  - Type 'org.gradle.api.tasks.testing.Test' property 'jvmArgumentProviders.$0.coroutinesJavaAgentPath' specifies file '/Users/pawel_lipski/git-machete-intellij-plugin/backend/impl/build/tmp/initializeIntelliJPlugin/coroutines-javaagent.jar' which doesn't exist.

    Reason: An input file was expected to be present but it doesn't exist.

    Possible solutions:
      1. Make sure the file exists before the task is called.
      2. Make sure that the task which produces the file is declared as an input.

    For more information, please refer to https://docs.gradle.org/8.4/userguide/validation_problems.html#input_file_does_not_exist in the Gradle documentation.

https://github.com/JetBrains/gradle-intellij-plugin/issues/1476


Error during loading Codellama GGUF

I just used base script from the TheBloke repo and got an error during loading the model:
OSError: libcudart.so.12: cannot open shared object file: No such file or directory
my script is :
from ctransformers import AutoModelForCausalLM
llm = AutoModelForCausalLM.from_pretrained("TheBloke/CodeLlama-7B-GGUF", model_file="codellama-7b.Q4_0.gguf", model_type="llama", gpu_layers=50)
print(llm("AI is going to"))

You should also install the compatible CUDA runtime libraries using:
pip install ctransformers[cuda]
See example in Colab.

Same problem here. No updates?


1258 make opting out of ssl explicit for http/websocket options

make opting out of ssl explicit for http/websocket options

for now as a quick fix I've set ssl being enabled by default. So that user
will always have to either call withSslDisabled to disable ssl or
call withSsl to provide cert/key paths.

Looks good, thanks.


doc: added blogpost link in the readme

What kind of change does this PR introduce?
Updated the README.md.
I have created a post on Medium for people on how to create JSON-Powered Forms in Angular with ngx-formly.
I don't know if you want this, but I'm thankful for the tool you build so everyone can use it! 🙏. So if you don't want to add it, it's no problem for me 😉

Thank you @raymonschouwenaar!

Your welcome!! If there is a new version or any new feature to write about, please let me know ;-) @aitboudad


Refactor Solution

Before we hit project explosion and it becomes too hard to navigate the solution, break down the projects into solution folders: https://docs.google.com/document/d/11fvFK2N0aCvDrAsxLZq8gDcNiTOkSfkrsookGU-mpzc/edit?usp=sharing

I forgot that refactoring solutions (i.e. moving project folders around) breaks NuGet.  Solution here: http://stackoverflow.com/a/20135086

Closed at d1f64928a8d339dacfd9dc5a33146b37ad22721f


Text Wrap

Hey - thanks for this tool. It's been really nice to use.
One thing I've noticed is that if I've got a very long expression the cursor isn't line wrapping. The expression ends with .name, .id, but you can see the expression ends with .nam because that's the edge of the screen.

If I switch to a wider screen, it works fine:

I'm not sure if it's me - but if it helps I'm on a Mac with zsh in iTerm2. Let me know if I can help at all with figuring out a fix.

Thanks for submitting this! I’ll look into adding this with a batch of changes currently on the ‘develop’ branch I’ve left idle for a bit too long already.


Node.js install but no npm install

I did follow all the steps but after node.js installed I can't install npm.
There was an error about locale not right.

Can you help me fix this bash whenever I enter nmp install?

NPM comes with the node install, make sure node is installed correctly


add french tranlation

add french tranlation

hi, we already have a french translation. could you please edit the already existing file instead? Thanks


HDFS-16091. WebHDFS should support getSnapshotDiffReportListing.

https://issues.apache.org/jira/browse/HDFS-16091
When there are millions of diffs between two snapshots, the old getSnapshotDiffReport() isn't scalable.
This PR adds  GETSNAPSHOTDIFFLISTING op to NameNode WebHDFS API.  WebHdfsFileSystem#getSnapshotDiffReport is fixed to leverage getSnapshotDiffReportListing in the same way as DistributedFileSystem#getSnapshotDiffReport.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 50s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m 15s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
21m 57s

trunk passed

+1 :green_heart:
compile
5m 43s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 20s

trunk passed

+1 :green_heart:
mvnsite
2m 35s

trunk passed

+1 :green_heart:
javadoc
1m 47s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 11s

trunk passed

+1 :green_heart:
shadedclient
17m 14s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 11s

the patch passed

-1 :x:
compile
5m 20s
/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
javac
5m 20s
/patch-compile-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project in the patch failed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.

-1 :x:
compile
4m 53s
/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

-1 :x:
javac
4m 53s
/patch-compile-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project in the patch failed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  6s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 215 unchanged - 0 fixed = 217 total (was 215)

+1 :green_heart:
mvnsite
2m 15s

the patch passed

+1 :green_heart:
javadoc
1m 34s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m  3s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
6m 17s

the patch passed

+1 :green_heart:
shadedclient
17m  2s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 30s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
242m  4s

hadoop-hdfs in the patch passed.

+1 :green_heart:
asflicense
0m 49s

The patch does not generate ASF License warnings.

364m 54s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3374

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 2f36b2757c88 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 925ee2b31a36519eb4aca0b3287e3b4386911cd5

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/1/testReport/

Max. process+thread count
3431 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/1/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 45s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 1 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
13m  1s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
22m 39s

trunk passed

+1 :green_heart:
compile
5m 41s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 16s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 23s

trunk passed

+1 :green_heart:
mvnsite
3m 19s

trunk passed

+1 :green_heart:
javadoc
2m 36s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m 14s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 40s

trunk passed

+1 :green_heart:
shadedclient
15m  9s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 29s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 51s

the patch passed

+1 :green_heart:
compile
5m 45s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
5m 45s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 3 new + 652 unchanged - 1 fixed = 655 total (was 653)

+1 :green_heart:
compile
4m 59s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
4m 59s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 3 new + 631 unchanged - 1 fixed = 634 total (was 632)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  9s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 230 unchanged - 0 fixed = 232 total (was 230)

+1 :green_heart:
mvnsite
2m 59s

the patch passed

+1 :green_heart:
javadoc
2m  6s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 54s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 48s

the patch passed

+1 :green_heart:
shadedclient
15m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 30s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
243m 35s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

+1 :green_heart:
unit
23m 43s

hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 53s

The patch does not generate ASF License warnings.

399m 59s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/2/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3374

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 81f2a2131c48 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 07670bdd98269a16b237bd9a0a7dd7cd7ee20b36

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/2/testReport/

Max. process+thread count
3334 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/2/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 56s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
17m 39s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
23m  4s

trunk passed

+1 :green_heart:
compile
5m 20s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 52s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 15s

trunk passed

+1 :green_heart:
mvnsite
2m 53s

trunk passed

+1 :green_heart:
javadoc
2m 12s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m  3s

trunk passed

+1 :green_heart:
shadedclient
16m 53s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s

the patch passed

+1 :green_heart:
compile
5m 15s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
5m 15s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 3 new + 652 unchanged - 1 fixed = 655 total (was 653)

+1 :green_heart:
compile
4m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
4m 45s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 3 new + 631 unchanged - 1 fixed = 634 total (was 632)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m 10s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 2 new + 258 unchanged - 0 fixed = 260 total (was 258)

+1 :green_heart:
mvnsite
2m 38s

the patch passed

+1 :green_heart:
javadoc
1m 54s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 35s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 24s

the patch passed

+1 :green_heart:
shadedclient
16m 44s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 15s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
371m 53s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
32m  4s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

539m 19s

Reason
Tests

Failed junit tests
hadoop.hdfs.server.namenode.ha.TestObserverNode

hadoop.hdfs.server.mover.TestMover

hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/3/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3374

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 6169a11c2d39 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 46af0df77aeb6360e987cc8121c54e83fd819679

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/3/testReport/

Max. process+thread count
2223 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/3/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/web/resources/NamenodeWebHdfsMethods.java:1352:    case GETSNAPSHOTDIFFLISTING: {:34: Avoid nested blocks. [AvoidNestedBlocks]

I filed HADOOP-17897 for this javac warnings

hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/web/WebHdfsFileSystem.java:1490:50:[unchecked] unchecked conversion

This can not be addressed as far as we are using TreeList of commons-collections 3 which does not support type parameters. We are already ignoring same warning for DistributedFileSystem.

Following junit tests are not related to WebHDFS. I could not reproduce the test failure on my local.

hadoop.hdfs.server.namenode.ha.TestObserverNode
hadoop.hdfs.server.mover.TestMover
hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
1m 19s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 36s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
20m 52s

trunk passed

+1 :green_heart:
compile
5m 18s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
4m 56s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 16s

trunk passed

+1 :green_heart:
mvnsite
3m  6s

trunk passed

+1 :green_heart:
javadoc
2m 20s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
3m  2s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m  3s

trunk passed

+1 :green_heart:
shadedclient
15m  1s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 28s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 37s

the patch passed

+1 :green_heart:
compile
5m  3s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
5m  3s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 1 new + 652 unchanged - 1 fixed = 653 total (was 653)

+1 :green_heart:
compile
4m 49s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
4m 49s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 1 new + 631 unchanged - 1 fixed = 632 total (was 632)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

-0 :warning:
checkstyle
1m  7s
/results-checkstyle-hadoop-hdfs-project.txt
hadoop-hdfs-project: The patch generated 1 new + 258 unchanged - 0 fixed = 259 total (was 258)

+1 :green_heart:
mvnsite
2m 43s

the patch passed

+1 :green_heart:
javadoc
1m 56s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 45s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 17s

the patch passed

+1 :green_heart:
shadedclient
14m 22s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 21s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
410m  3s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
33m 33s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 48s

The patch does not generate ASF License warnings.

569m  6s

Reason
Tests

Failed junit tests
hadoop.hdfs.web.TestWebHdfsFileSystemContract

hadoop.hdfs.TestSnapshotCommands

hadoop.fs.viewfs.TestViewFileSystemOverloadSchemeHdfsFileSystemContract

hadoop.hdfs.server.namenode.TestNNThroughputBenchmark

hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/4/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3374

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 4deb64f96d16 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / c681dcbf9ac6924a4695ff3cc2df8c6f7565c1a0

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/4/testReport/

Max. process+thread count
2804 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/4/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks for working on this. I'll review soon.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
16m 53s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  1s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 31s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  4s

trunk passed

+1 :green_heart:
compile
5m 24s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m  1s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 13s

trunk passed

+1 :green_heart:
mvnsite
2m 56s

trunk passed

+1 :green_heart:
javadoc
2m 11s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 54s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m  7s

trunk passed

+1 :green_heart:
shadedclient
22m 13s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 25s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 35s

the patch passed

+1 :green_heart:
compile
5m 23s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
5m 23s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 2 new + 651 unchanged - 2 fixed = 653 total (was 653)

+1 :green_heart:
compile
4m 44s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
4m 44s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 2 new + 630 unchanged - 2 fixed = 632 total (was 632)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  7s

hadoop-hdfs-project: The patch generated 0 new + 211 unchanged - 3 fixed = 211 total (was 214)

+1 :green_heart:
mvnsite
2m 40s

the patch passed

+1 :green_heart:
javadoc
1m 56s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 38s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 21s

the patch passed

+1 :green_heart:
shadedclient
22m 15s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 15s

hadoop-hdfs-client in the patch passed.

-1 :x:
unit
339m 19s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
hadoop-hdfs in the patch passed.

-1 :x:
unit
31m 56s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 42s

The patch does not generate ASF License warnings.

529m 43s

Reason
Tests

Failed junit tests
hadoop.hdfs.TestRollingUpgrade

hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/5/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3374

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 041022ebaa6d 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / 56f45242d41962fd2ff72252e9631bc653dc6c65

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/5/testReport/

Max. process+thread count
2220 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/5/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Thanks, @jojochuang. I rebased this.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Logfile
Comment

+0 :ok:
reexec
0m 55s

Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s

No case conflicting files found.

+0 :ok:
codespell
0m  0s

codespell was not available.

+1 :green_heart:
@author
0m  0s

The patch does not contain any @author tags.

+1 :green_heart:
test4tests
0m  0s

The patch appears to include 2 new or modified test files.

_ trunk Compile Tests _

+0 :ok:
mvndep
12m 58s

Maven dependency ordering for branch

+1 :green_heart:
mvninstall
24m  3s

trunk passed

+1 :green_heart:
compile
5m 49s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
compile
5m 23s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
checkstyle
1m 14s

trunk passed

+1 :green_heart:
mvnsite
2m 55s

trunk passed

+1 :green_heart:
javadoc
2m  9s

trunk passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 56s

trunk passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m  8s

trunk passed

+1 :green_heart:
shadedclient
22m 57s

branch has no errors when building and testing our client artifacts.

_ Patch Compile Tests _

+0 :ok:
mvndep
0m 23s

Maven dependency ordering for patch

+1 :green_heart:
mvninstall
2m 38s

the patch passed

+1 :green_heart:
compile
5m 41s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

-1 :x:
javac
5m 41s
/results-compile-javac-hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04.txt
hadoop-hdfs-project-jdkUbuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 generated 2 new + 643 unchanged - 2 fixed = 645 total (was 645)

+1 :green_heart:
compile
5m 13s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

-1 :x:
javac
5m 13s
/results-compile-javac-hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10.txt
hadoop-hdfs-project-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10 generated 2 new + 622 unchanged - 2 fixed = 624 total (was 624)

+1 :green_heart:
blanks
0m  0s

The patch has no blanks issues.

+1 :green_heart:
checkstyle
1m  6s

hadoop-hdfs-project: The patch generated 0 new + 211 unchanged - 3 fixed = 211 total (was 214)

+1 :green_heart:
mvnsite
2m 40s

the patch passed

+1 :green_heart:
javadoc
1m 53s

the patch passed with JDK Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04

+1 :green_heart:
javadoc
2m 38s

the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

+1 :green_heart:
spotbugs
7m 18s

the patch passed

+1 :green_heart:
shadedclient
22m 48s

patch has no errors when building and testing our client artifacts.

_ Other Tests _

+1 :green_heart:
unit
2m 17s

hadoop-hdfs-client in the patch passed.

+1 :green_heart:
unit
340m 11s

hadoop-hdfs in the patch passed.

-1 :x:
unit
31m 55s
/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt
hadoop-hdfs-rbf in the patch passed.

+1 :green_heart:
asflicense
0m 58s

The patch does not generate ASF License warnings.

517m 52s

Reason
Tests

Failed junit tests
hadoop.hdfs.rbfbalance.TestRouterDistCpProcedure

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/6/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hadoop/pull/3374

Optional Tests
dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell

uname
Linux 1200aedb61c9 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/bin/hadoop.sh

git revision
trunk / f28da907c44adf81f028dd016f2138742dfd001b

Default Java
Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Multi-JDK versions
/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.11+9-Ubuntu-0ubuntu2.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~20.04-b10

Test Results
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/6/testReport/

Max. process+thread count
2190 (vs. ulimit of 5500)

modules
C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project

Console output
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3374/6/console

versions
git=2.25.1 maven=3.6.3 spotbugs=4.2.2

Powered by
Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

The failure of TestRouterDistCpProcedure is intermittent one. I could not reproduce the failure on my local.


Enhance the accessibility of Select (@yamada-ui/select) component

Description
to be
1. Accessibility roles

[ ] Please refer to the image.

2. aria-controls

[ ] An element with the combobox role must have in its aria-controls attribute the ID of the corresponding popup element (the element with the listbox role).

3. aria-expanded

[ ] When an element with the listbox role is hidden, the element with the combobox role should have the aria-expanded attribute set to false.
[ ] When an element with the listbox role is visible, the element with the combobox role should have the aria-expanded  attribute set to true.

4. aria-activedescendant

[ ] While a descendant element of the element with the listbox role is focused, the element with the combobox role must have the ID of the focused element as the value of its aria-activedescendant attribute.

5. aria-label / aria-labelledby

[ ] Please refer to the following flowchart.

Does the combobox have a visible label?
    ├──> No: `combobox` element has a label provided by `aria-label` .
    └──> Yes
           └──> Is the `combobox` element an HTML element that can be labelled using the HTML `label` element (e.g., the input element)?
                  ├──> No: `combobox` element has `aria-labelledby` set to a value that refers to the labelling element.
                  └──> Yes: `combobox` is labeled using the `label` element.

6. Keyboard Interaction

[ ] When Alt + Up Arrow is pressed while the popup is displayed...

[ ] If an element within the popup is focused, return the focus to the element with the combobox role.
[ ] Close the popup.

References

Select-Only Combobox Example | APG | WAI | W3C
Combobox Pattern | APG | WAI | W3C
Select - Yamada UI
Select – React Aria

Problem Statement/Justification
We should prioritize web accessibility to ensure our UI components are usable by everyone, including people with disabilities. This inclusivity enhances user experience and complies with legal standards, broadening Yamada UI's user base.
Proposed Solution or API
No response
Alternatives
No response
Are you willing to participate in implementing this feature and create a pull request include the implementation?
None
Additional Information
No response

@koralle
duplicate ?
https://github.com/yamada-ui/yamada-ui/issues/1959

@nakayan5
Have you checked the three implementation examples of the ListBox pattern published by W3C APG?
The Select component of Yamada UI does not correspond to any of these three examples.
On the other hand, on the ComboBox pattern page, the combobox widget is clearly defined as follows, and this perfectly fits it. Similar implementation examples are also published.

A combobox is an input widget that has an associated popup. The popup enables users to choose a value for the input from a collection.

This is optional.

When Alt + Up Arrow is pressed while the popup is displayed...

[ ]  If an element within the popup is focused, return the focus to the element with the combobox role.
[ ]  Close the popup.


Cancel running animation when moveToPoint() is called.

This change fixes problem where the previous animation unintendedly
overrides new position. The problem typically occurd in IE9 with the
code like the following:
// Animates to the first position with default duration (350ms).
var flipsnap = Flipsnap('.flipsnap');

// Move to the position immediately.
flipsnap.moveToPoint(3, 0);

// Now the third page should be shown, but the first page is shown.

Note that this change has effects only if the browser doesn't support
CSS animation.

Looks good. thanks!


Add ability to pass text content other than a file path

First, thanks for your work. This is a feature suggestion, not sure how to implement valuable tests.
My use case for this feature is that I have, say, 100 xml files in a database that I want to allow users to download. Having the ability to zip them in memory is better than creating files in disk. To illustrate better:
var records = database.select('*').from('table'); // this is actually async
res.zip(records.map(function(record) {
    return {
        name: record.fileName + '.xml',
        content: record.xml
    };
});

Hello, Renato.  Thanks for the kind words, and the PR.  This makes sense.
I'll make a note to come round this out with test and get it merged in the
near future.  Thanks.
On Thu, Jun 18, 2015 at 11:04 AM, Renato Gama<EMAIL_ADDRESS>wrote:

First, thanks for your work. This is a feature suggestion, not sure how to
implement valuable tests.
My use case for this feature is that I have, say, 100 xml files in a
database that I want to allow users to download. Having the ability to zip
them in memory is better than creating files in disk. To illustrate better:
var records = database.select('*').from('table'); // this is actually async
res.zip(records.map(function(record) {
return {
name: record.fileName + '.xml',
content: record.xml
};
});

You can view, comment on, or merge this pull request online at:
https://github.com/thrackle/express-zip/pull/6
Commit Summary

Add ability to pass text content other than a file path

File Changes

M History.md
https://github.com/thrackle/express-zip/pull/6/files#diff-0 (5)
M lib/express-zip.js
https://github.com/thrackle/express-zip/pull/6/files#diff-1 (5)
M package.json
https://github.com/thrackle/express-zip/pull/6/files#diff-2 (6)
M test/index.js
https://github.com/thrackle/express-zip/pull/6/files#diff-3 (7)

Patch Links:

https://github.com/thrackle/express-zip/pull/6.patch
https://github.com/thrackle/express-zip/pull/6.diff

—
Reply to this email directly or view it on GitHub
https://github.com/thrackle/express-zip/pull/6.


CAPTCHA prompts on server join need a reminder and a reason when being kicked.

I've become so accustomed to ignoring messages from greeter bots when joining servers that YAGPDB's CAPTCHA message didn't even register - adding a follow-up reminder message after a short while if the CAPTCHA hasn't been completed would be appreciated, as well as a message explaining why the user was kicked. I spent about half an hour trying to figure out why I was unceremoniously booted from the server I'd joined.
Also can I get clarification as to whether these CAPTCHA checks are random? I've joined at least 2 other servers with this bot in and neither prompted a check.
Cheers!

Whether or not to send a reminder message and its content is up to each server's administration, as that is already an available setting, see this screenshot:

You can find all the  reCAPTCHA settings on your control panel, navigating to Tools & Utilities > Verification.
Regarding the reason, that might be a good idea. Please consider suggesting this on the support server, as a discussion is generally going faster there, and not everyone uses GitHub extensively.
Moreover, this feature is purely optional - whether or not to use it is, again, up to each server's administration.
Kind regards


⚠ Samsung has degraded performance

In fd25e42, Samsung (https://samsung.com) experienced degraded performance:

HTTP code: 200
Response time: 2885 ms

Resolved: Samsung performance has improved in ccae34d.


Alternative to using electron: Use "Progressive Web App" techniques

What is a progressive web app? It's an app the progressively turns from a "website" into "app".
This is mediated by the browser, provided the app meets certain conditions.
These are the steps as described by @slightlyoff here

The site begins life as a regular tab. It doesn’t have super-powers, but it is built using Progressive App features including TLS, Service Workers, Manifests, and Responsive Design.
The second (or third or fourth) time one visits the site — roughly at the point where the browser it sure it’s something you use frequently — a prompt is shown by the browser (populated from the Manifest details)
Users can decide to keep apps to the home screen or app launcher
When launched from the home screen, these apps blend into their environment; they’re top-level, full-screen, and work offline. Of course, they worked offline after step 1, but now the implicit contract of “appyness” makes that clear.

So rather then wrapping Ghost with electron and then distributing it as a downloadable "native" app, you can instead ensure sure Ghost meets the "Progressive Web App" requirements.
This has already been implemented on Chrome Android and there plans to bring it to other platforms.
The Web App Manifest which power this is an open web standard, so you can expect other vendors to implement it in the future.

@sjama this is a really interesting idea, but as far as I understand it - applies 100% to mobile only? This repo is solely about native desktop apps

@JohnONolan at the moment is available on Chrome Android and I think on Chrome OS as well. Because Google has more control over these platforms, they have implemented on them first.
But from what @slightlyoff told me in a recent meetup they are currently debating on the best way to bring it to other main Desktop platforms.
On iOS they have much less control and the ball is Apple's court.
The main question is how important is Ghost Desktop app? Is it critical? or "a nice to have".
If it's the former than going the native app route, is the way to go.
Otherwise I would seriously consider waiting to see how "Progressive Web App" evolve over the next few months.
Because building and then maintaining a dedicated desktop app possibly for several platforms is not trivial task.

This is all very interesting, but as you yourself have said - it's not widely adopted (it's barely adopted at all) - and at present it only even applies to Google mobile devices. So this is really not a suitable candidate for Ghost right now, nor is that going to change in the next few months.
I'm extremely aware of the work involved with building a cross-platform native app, that's kind of the entire point of us wanting to use Electron ;)
Closing this for now, but will certainly keep an eye on the progress of Progressive Web Apps in future.

Hey there, I'm Google Developer Advocate working on PWAs in @slightlyoff's larger team.
In the meantime, PWAs have gained a lot of capabilities, with Twitter's PWA being the most recent high-profile launch.
We'd like to compile a list of feature needs that Electron satisfies which a PWA architecture still wouldn't, so as to motivate work towards better desktop support for PWAs.

@sjama this is a really interesting idea, but as far as I understand it - applies 100% to mobile only? This repo is solely about native desktop apps

Whilst PWAs were originally conceived as a way to deliver mobile apps outside of the 'stores' using web technologies, they are now very much being embraced on the desktop, with Microsoft supporting them in Edge early 2018:
https://www.thurrott.com/windows/windows-10/142649/microsofts-bold-plan-bring-pwas-windows-10

We're starting work on Desktop PWAs in Chrome; also, Samsung has shipped Desktop PWA support for the DeX device. This is very much not desktop-only.

This issue is so misguided it blows my mind that it's still going after almost 2 years.
We wrote the desktop app in electron because we — the maintainers, the people actually doing the work and writing the code — use electron, and we're very happy with how the app is working for us.
I'm very sorry to break it to you guys, but what technology you happen to prefer is not remotely relevant to anything. You aren't even contributors to this repository.


🐛 Bug Report: There are two "kind dropdowns": header and filter box

📜 Description
On a freshly created Backstage app, the catalog page has two identical ways of filtering by kind, which may be confusing.
👍 Expected behavior
The kind should be filterable by only the header dropdown or the filter box dropdown.
👎 Actual Behavior with Screenshots
double-kind-filter.webm
👟 Reproduction steps

npx @backstage/create-app (0.4.34)
cd $name, yarn dev
Click on header, filter box on catalog page.

📃 Provide the context for the Bug.
Likely related to #9616
🖥 Your Environment
$ yarn backstage-cli info
yarn run v1.22.19
$ /home/mitch/dev/backstage-new/mitch/node_modules/.bin/backstage-cli info
OS:   Linux 6.0.8-300.fc37.x86_64 - linux/x64
node: v16.17.0
yarn: 1.22.19
cli:  0.21.1 (installed)
backstage:  1.8.0

Dependencies:
  @backstage/app-defaults                          1.0.8
  @backstage/backend-common                        0.16.0
  @backstage/backend-plugin-api                    0.1.4
  @backstage/backend-tasks                         0.3.7
  @backstage/catalog-client                        1.1.2
  @backstage/catalog-model                         1.1.3
  @backstage/cli-common                            0.1.10
  @backstage/cli                                   0.21.1
  @backstage/config-loader                         1.1.6
  @backstage/config                                1.0.4
  @backstage/core-app-api                          1.2.0
  @backstage/core-components                       0.12.0
  @backstage/core-plugin-api                       1.1.0
  @backstage/errors                                1.1.3
  @backstage/integration-react                     1.1.6
  @backstage/integration                           1.4.0
  @backstage/plugin-api-docs                       0.8.11
  @backstage/plugin-app-backend                    0.3.38
  @backstage/plugin-auth-backend                   0.17.1
  @backstage/plugin-auth-node                      0.2.7
  @backstage/plugin-catalog-backend                1.5.1
  @backstage/plugin-catalog-common                 1.0.8
  @backstage/plugin-catalog-graph                  0.2.23
  @backstage/plugin-catalog-import                 0.9.1
  @backstage/plugin-catalog-node                   1.2.1
  @backstage/plugin-catalog-react                  1.2.1
  @backstage/plugin-catalog                        1.6.1
  @backstage/plugin-github-actions                 0.5.11
  @backstage/plugin-org                            0.6.0
  @backstage/plugin-permission-common              0.7.1
  @backstage/plugin-permission-node                0.7.1
  @backstage/plugin-permission-react               0.4.7
  @backstage/plugin-proxy-backend                  0.2.32
  @backstage/plugin-scaffolder-backend             1.8.0
  @backstage/plugin-scaffolder-common              1.2.2
  @backstage/plugin-scaffolder                     1.8.0
  @backstage/plugin-search-backend-module-pg       0.4.2
  @backstage/plugin-search-backend-node            1.0.4
  @backstage/plugin-search-backend                 1.1.1
  @backstage/plugin-search-common                  1.1.1
  @backstage/plugin-search-react                   1.2.1
  @backstage/plugin-search                         1.0.4
  @backstage/plugin-tech-radar                     0.5.18
  @backstage/plugin-techdocs-backend               1.4.1
  @backstage/plugin-techdocs-module-addons-contrib 1.0.6
  @backstage/plugin-techdocs-node                  1.4.2
  @backstage/plugin-techdocs-react                 1.0.6
  @backstage/plugin-techdocs                       1.4.0
  @backstage/plugin-user-settings                  0.5.1
  @backstage/release-manifests                     0.0.7
  @backstage/test-utils                            1.2.2
  @backstage/theme                                 0.2.16
  @backstage/types                                 1.0.1
  @backstage/version-bridge                        1.0.2
Done in 0.78s.

👀 Have you spent some time to check if this bug has been raised before?

[X] I checked and didn't find similar issue

🏢 Have you read the Code of Conduct?

[X] I have read the Code of Conduct

Are you willing to submit PR?
No, I don't have time to work on this right now

I agree that it's slightly confusing, or rather redundant that you can use both of these to make the same change.
It's probably worth updating the default page making it a regular header and just use the kind filter below for filtering.

Hey, I would be interested in implementing this :)

Oh, my muscle memory will be unhappy with this but totally agree with this change 👍

@lucahuettner thanks, please give it a go! ❤


Errno 111

Could anyone please fix the following error? Thanks a lot.
"ConnectionError: ...Failed to establish a new connection: [Errno 111] Connection refused"

Already working again


Cleared typo error

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: chandrashekharazad sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


Manual Save Failure

Error Code
Error: Too Many Requests

Error: Too Many Requests
    at Request.<anonymous> (https://homebrewery.naturalcrit.com/homebrew/bundle.js:78380:21)
    at Emitter.emit (https://homebrewery.naturalcrit.com/homebrew/bundle.js:1954:20)
    at XMLHttpRequest.<anonymous> (https://homebrewery.naturalcrit.com/homebrew/bundle.js:78674:10)
{
  "status": 429,
  "method": "PUT",
  "url": "/api/update/gJ6SMJ-YNep0"
}

### Your description of what happened:

After trying to manually save within the Homebrewery platform, I receive an error stating that there was an issue saving. This doesn't appear to be relevant to the Google Drive issue, as I am not attempting to save my information to Google Drive.

This is the same Google Drive error. Our logs show that this file you are editing is saved on a Google Drive.

Merging to the master issue - #3770


copy query result

First, thanks for your extension
But I have one need.
I usually copy my sql result for writing my report. But It is not available on your extention.
Would you mind review my request?
Have a good day :)

What version of VS Code are you using? Please try the latest version. You could be able to copy the content.


Missing Localization from Scryfall

Scryfall is missing some localization, at least for some variations of the GRN/RNA Guildgates, for example:
https://scryfall.com/card/grn/248/golgari-guildgate
This messes up the export functionality as importing in arena is tied to your display language (which is the real root cause here, but hey, what can you do?).

Should be fixed by e2ae50419a7b1613d2b06d37f705c80235102261


Claim Peeking in JARM

Why are you validating peeked claims instead of DecryptedResponse?

Originally posted by @maennchen in https://github.com/erlef/oidcc/pull/321#discussion_r1438505772

DecryptedResponse is still a binary. We validate against PeekClaims (rather than getting the claims after calling oidcc_jwt_util:verify_signature/3) because the spec says that the client must validate some of the claims before validating the signature: https://openid.net/specs/oauth-v2-jarm-final.html#name-processing-rules

Originally posted by @paulswartz in https://github.com/erlef/oidcc/pull/321#discussion_r1438676317

@paulswartz I'm not sure I understand your reasoning.
Currently the code is:

decrypting
peeking & validating peeked claims
verifying & unpacking the decrypted token
returning the verified claims

Why are we not:

decypting
verifying token & extracting claims
check the verified claims

Do you read the spec as having a defined order to the steps? I doesn't specifically say to do so as far as I can see. (Might be wrong on this)
I also don't see any hints that peeking is expected nor do I see a good reason to do so.

Originally posted by @maennchen in https://github.com/erlef/oidcc/pull/321#discussion_r1438911715

Here's the text from https://openid.net/specs/oauth-v2-jarm-final.html#section-2.4-2

The client MUST process the JWT secured response as follows:

(OPTIONAL) The client decrypts the JWT using the default key for the respective issuer or, if applicable, determined by the kid JWT header parameter. The key might be a private key, where the corresponding public key is registered with the expected issuer of the response ("use":"enc" via the client's metadata jwks or jwks_uri) or a key derived from its client secret (see Section 2.2).
The client obtains the iss element from the JWT and checks whether its value is well known and identifies the expected issuer of the authorization process in examination. If the check fails, the client MUST abort processing and refuse the response.
The client obtains the aud element from the JWT and checks whether it matches the client id the client used to identify itself in the corresponding authorization request. If the check fails, the client MUST abort processing and refuse the response.
The client checks the JWT's exp element to determine if the JWT is still valid. If the check fails, the client MUST abort processing and refuse the response.
The client MUST check the signature of the JWT according to [RFC7515] and the algorithm none ("alg":"none") MUST NOT be accepted. If the check fails, the client MUST abort processing and refuse the response.

My read of this is:

decrypt if necessary
check the "iss" claim
check the "aud" claim
check the "exp" claim
check the signature and verify that "alg": "none" was not used

Since steps 2, 3, and 4 require checking the claims before the signature has been checked in step 5, we need to peek into the JWT to do that.

Originally posted by @paulswartz in https://github.com/erlef/oidcc/pull/321#discussion_r1438916091

Extracted into a new issue from #321.
I'll check with a colleague to see how they read that part of the spec. It seems strange to me that the spec would require validating unverified claims and I'm not sure if the spec just specifies the steps or if it also specifies the order.

When I have some time, I'll try to look for some other implementations to see what they're doing.

Node's openid-client seems to do it this way as well (for all JWTs): https://github.com/panva/node-openid-client/blob/9d3cfb8bffc03d3b987a574f20ebbd209fec2cf1/lib/client.js#L896-L1086
Unfortunately, that's the only open-source client I can see that supports JARM.

@paulswartz I’ve discussed the issue with some colleagues that implement an OpenID provider. The consensus is that the order of the steps in the specification is not relevant and that the claims should not be read before validating the signature. The exception would be the iss claim if the origin of the token is not known beforehand.


exception handling in at_lookup's BaseConnection.write

Describe the bug
While looking at this code in the course of investigating another issue, I observed two problems
(1) exception is silently swallowed
(2) write() is not followed by flush()
Steps to reproduce
n/a
Expected behavior

if we want to catch exceptions here rather than via the socket.done error handler, we should await socket.flush() after the call to socket.write()
we should rethrow exceptions if they occur

Being part of the core client-side network comms code, changes here have a large blast radius if they introduce a new problem so while the impl here is straightforward, the testing will need to be comprehensive
Screenshots
No response
Smartphones
No response
Were you using an atApplication when the bug was found?
No response
Additional context
No response

Will be taken up in PR102


/var/vcap/store and /var/vcap/data should not have 5% root reservation

Currently all filesystems are created with the default 5% disk space reservation for privileged processes. While this make sense for root filesystems, it's hard to justify for volumes that are normally only written to by non-root users (vcap), especially since it's not uncommon (at least in our experience) to have very large volumes (and, therefore, quite big amounts of unusable disk space)
I think it should be safe to use -m 0 on /var/vcap/store and /var/vcap/data, but if that's deemed too risky (why?) I would at least suggest lowering the reservation to some smaller value.

@CAFxX i think it makes to be removed for persistent disk. for ephemeral storage it becomes a bit interesting since we have /var/vcap/data/root_log (bind mount from /var/log) placed there and it's written by auditd and rsyslog. not sure if they would be affected in a negative way. wdyt?

@cppforlife right, I forgot about that. Then yes, just /var/vcap/store.


Develop the Footer vanilla component

Jeff-Chew created the following on Aug 14:
User Story

As a [user role below]:
Developer

I need to:
utilize a vanilla javascript version of the footer from the IBM.com library

so that I can:
integrate the ibm.com footer in my application

Additional information

should utilize the styles package for styling of the component

Acceptance criteria

[ ] Include storybook html story
[ ] minimum 80% unit test coverage

Original issue: https://github.ibm.com/webstandards/digital-design/issues/1463

@andysherman2121 @jeffchew This sprint 22 issue is still in Review.  Can I close it or should I move it to sprint 23?

@RobertaJHahn Move to sprint 23 please. Finishing it up now

Done


Multi-line folding

Imagine the following code snippet:
<button
	className={`
		w-10 h-10 text-primary cursor-pointer
		border-primary border-2 rounded-full
		flex items-center justify-center
		transition-colors
		enabled:hover:bg-primary hover:text-white
		enabled:active:bg-violet-900 active:text-white
		disabled:cursor-not-allowed disabled:border-gray-300 disabled:text-gray-300
	`}
>

That might be considered quite ugly, I know :)
I'd like to request support multi-line folding for cases similar to the one above. I already tried modifying the regex flags to be gs but that just left the lines being empty instead of truly folded.
Is that something you'd consider implementing?

@axelrindle this topic is already replied in #69.


Disappearance of the lower part of the skeleton when there are only thigh trackers

If connect only thigh trackers, the lower part of the skeleton disappears (a full reset does not help), if add foot trackers, nothing changes (their rotation is displayed in the preview).
It is clear that slimeVR should not be used in this way, but the complete disappearance of the lower part of the skeleton, which can only be solved by restarting the program, is also not good.

someone else has shown me this issue, after deleting their server configuration their legs were back. I asked for their old config and I couldn't replicate it.

I had that issue. confused me a lot

Deleting the vrconfig.yaml fixed it, but I need to do further testing, as the fix wasn't explainable. If I find a direct cause, I will inform you.

thank you, be free to post the actual issue in here!

I think ive seen that before. Deleting the config fixed it iirc


Install the RFI branding

If you don't, the default Ideascube branding will be used, but I assume RFI will want their own branding.
Your playbook will need to install the following files:

/usr/share/ideascube/static/branding/header-logo.png
/usr/share/ideascube/static/branding/favicon.png

This is similar to what you already do for Koombook and Ideasbox branding.

Done here : https://github.com/ideascube/ansiblecube/blob/oneUpdateFile/roles/ideascube/tasks/branding.yml


Checks for CATCH

the class must be known, plus lx_error must be a subclass of the catched class type? and interfaces?
CATCH zcx_abapgit_exception INTO lx_error.

syntax

I think this is fixed, closing


[angle] build failure on master

angle:arm64-windows failed with BUILD_FAILED
https://dev.azure.com/vcpkg/public/_build/results?buildId=71934&view=logs&j=84da4f4a-968a-5b5c-16e9-f444c845396d&t=80e5e0c8-bb3b-5216-9f3f-2618d4e9f3f4

Yes, I agree, if we can't reproduce it, we should close this issue, until the next problem. Thank you.

@Cheney-W We still have problem with angle on the master. it feel like random. always get an error in different triplets. Can you investigate it?
https://dev.azure.com/vcpkg/public/_build/results?buildId=72059&view=results

I've checked that the files being compiled, the compilation options, and the final result are exactly the same as the VS bug found internally before.

@Cheney-W Is it problem only in the CI?

I suspect that the cache is not cleared to cause.

How we can clear the cache from the ci?


Broken binary is generated when empty array passed

When the message containing zero-length arrays passed, it will be serialized to invalid binary that we cannot deserialize correctly.

Thank you for your PR!


Inkwell tap behaviour makes it too easy to onTapCancel.

Use case
I've a Flutter application with a button that uses an Inkwell.
The button is rather large.
When I press on the button the ink well splash goes off.

While I can understand the use case of an onTapCancel going off in the case where my finger has left the button bounds, I think it's reasonable for a user to expect the button to trigger its on press behaviour while their finger is still on the button when they lift it.
Additionally, it would be nice to have the option of removing onTapCancels altogether so that even if the user lifts their finger when outside the button bounds the onTap could go off.  My reasoning for this is we've already signalled to the user that the button is going to go off (due to the splash).  There's no equivalent signal to indicate the tap was cancelled (like maybe a red splash could do) so its not unreasonable for the user to expect the button will fire regardless - but perhaps there could be a radius out from the button bounds within which taps are not cancelled but outside that radius they are cancelled.
We've found on some devices on which a button affordance is of sufficient size for the user to hit, it's still very easy for the user to accidentally onTapCancel when they intended to onTap.
Proposal
Add configuration to Inkwell to control the behaviour of onTap/onTapCancel including:

Allow any tap ups within the bounds of the button (and also within an optional radius) to trigger an onTap instead of onTapCancel.
Allow the user to move their finger within the button without triggering any additional events.
optional Emit some sort of animation indicating when a tap on an Inkwell has been cancelled.

I originally created my own separate issue because I was unaware of this one. I think it'd be really useful to implement this improvement, since the current behavior is different from the native experience.
Expected results:
This video from a native Android app shows the expected behavior:
https://user-images.githubusercontent.com/23523399/228458702-438871c6-46d2-47ae-b386-ba1120c8c580.mp4
When ending the gesture inside the button/container, I expect that the tap event comes through. When moving out (as already happens) I expect the event to be cancelled.
This example is the messages app, but almost all apps show this same behavior (Gmail, Phone, Calendar, Whatsapp, Telegram, Signal, ...).
Actual results:
This video from the default demo Flutter app (with the FAB extended for better visiblity) shows the actual behavior in Flutter.
https://user-images.githubusercontent.com/23523399/228461949-a904a992-0124-4ef8-ad21-208880a0e84f.mp4
In Flutter, when the touch moves away too far from the starting position, independent of whether it was moved inside or out of the container, the tap event gets cancelled.
As a result of this, users of my app have reported buttons not working, as they accidentally did a small swiping motion when trying to tap a button.

Code sample
The code sample below is mostly identical to the default Flutter demo app.
import 'package:flutter/material.dart';

void main() {
  runApp(const MyApp());
}

class MyApp extends StatelessWidget {
  const MyApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      theme: ThemeData(
        primarySwatch: Colors.blue,
      ),
      home: const MyHomePage(title: 'Flutter Demo Home Page'),
    );
  }
}

class MyHomePage extends StatefulWidget {
  const MyHomePage({super.key, required this.title});

  final String title;

  @override
  State<MyHomePage> createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage> {
  int _counter = 0;

  void _incrementCounter() {
    setState(() {
      _counter++;
    });
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text(widget.title),
      ),
      body: Center(
        child: Column(
          mainAxisAlignment: MainAxisAlignment.center,
          children: <Widget>[
            const Text(
              'You have pushed the button this many times:',
            ),
            Text(
              '$_counter',
              style: Theme.of(context).textTheme.headlineMedium,
            ),
          ],
        ),
      ),
      floatingActionButton: FloatingActionButton.extended(
        onPressed: _incrementCounter,
        label: const Text('Increment'),
        icon: const Icon(Icons.add),
      ),
    );
  }
}

Logs

Analyzing test_app...
No issues found! (ran in 1.3s)

[√] Flutter (Channel stable, 3.7.7, on Microsoft Windows [Version 10.0.22000.1696], locale nl-NL)
    • Flutter version 3.7.7 on channel stable at C:\flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2ad6cd72c0 (3 weeks ago), 2023-03-08 09:41:59 -0800
    • Engine revision 1837b5be5f
    • Dart version 2.19.4
    • DevTools version 2.20.1

[√] Windows Version (Installed version of Windows is version 10 or higher)

[√] Android toolchain - develop for Android devices (Android SDK version 32.0.0-rc1)
    • Android SDK at C:\Users\fvollebregt\AppData\Local\Android\sdk
    • Platform android-33, build-tools 32.0.0-rc1
    • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)
    • All Android licenses accepted.

[√] Chrome - develop for the web
    • Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe

[X] Visual Studio - develop for Windows
    X Visual Studio not installed; this is necessary for Windows development.
      Download at https://visualstudio.microsoft.com/downloads/.
      Please install the "Desktop development with C++" workload, including all of its default components

[√] Android Studio (version 2021.2)
    • Android Studio at C:\Program Files\Android\Android Studio
    • Flutter plugin can be installed from:
       https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
       https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 11.0.12+7-b1504.28-7817840)

[√] VS Code (version 1.76.2)
    • VS Code at C:\Users\fvollebregt\AppData\Local\Programs\Microsoft VS Code
    • Flutter extension can be installed from:
       https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter

[√] Connected device (4 available)
    • Pixel 2 (mobile)  • FA8271A02656 • android-arm64  • Android 11 (API 30)
    • Windows (desktop) • windows      • windows-x64    • Microsoft Windows [Version 10.0.22000.1696]
    • Chrome (web)      • chrome       • web-javascript • Google Chrome 111.0.5563.146
    • Edge (web)        • edge         • web-javascript • Microsoft Edge 111.0.1661.54

[√] HTTP Host Availability
    • All required HTTP hosts are available

! Doctor found issues in 1 category.

This is still an issue for my projects? Are there any plans to make the flutter gestures behave more like native android?


shapnetcore error

Traceback (most recent call last):
File "training.py", line 219, in
criterion_azi, criterion_ele, criterion_inp, criterion_reg, optimizer)
File "training.py", line 159, in train
for i, data in enumerate(data_loader):
File "/home/abhishek/.local/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 568, in next
return self._process_next_batch(batch)
File "/home/abhishek/.local/lib/python3.6/site-packages/torch/utils/data/dataloader.py", line 608, in _process_next_batch
raise batch.exc_type(batch.exc_msg)
FileNotFoundError: Traceback (most recent call last):
File "/home/abhishek/.local/lib/python3.6/site-packages/torch/utils/data/_utils/worker.py", line 99, in _worker_loop
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/abhishek/.local/lib/python3.6/site-packages/torch/utils/data/_utils/worker.py", line 99, in
samples = collate_fn([dataset[i] for i in batch_indices])
File "/home/abhishek/UnsupervisedFMapNet/Scr/PoseFromShape/auxiliary/dataset.py", line 435, in getitem
renders = read_multiviwes(self.render_transform, render_example_path, self.render_number, self.tour, mutation)
File "/home/abhishek/UnsupervisedFMapNet/Scr/PoseFromShape/auxiliary/dataset.py", line 92, in read_multiviwes
render_names = [name for name in os.listdir(render_example_path)]
FileNotFoundError: [Errno 2] No such file or directory: 'data/ShapeNetCore/Renders_semi_sphere/02691156/19e531e6d0bd5ddd67c54439d6177032/crop'

Have you generated all the training data successfully?
It appears to me that you missed some training data.

thank you .. this helps..


Sanitize csv strings

This should be a simple fix to #256
Two additional test cases were implemented to check some cases of possible input value patterns.
The fix itself is realized within the splitCSV function, which now by default replaces all " " by "".
I'm aware, that this might not be the most suitable place for this fix.
I thought of implementing it in one of the higher level function but was not sure about implications.
Feel free to comment of course :)

This needs to be fixed and thanks for the contribution! I think I would prefer splitting on , first, and then calling https://pkg.go.dev/strings#TrimSpace  on the elements. I might come back to this soon, I'd like this to be fixed :bow:

Merged, thank you!


x/tools/gopls: duplicate "undeclared name" errors following CL222237

What version of Go are you using (go version)?

$ go version
go version devel +2e918c3aab Tue Mar 17 06:38:32 2020 +0000 linux/amd64
$ go list -m golang.org/x/tools
golang.org/x/tools v0.0.0-20200328031815-3db5fc6bac03
$ go list -m golang.org/x/tools/gopls
golang.org/x/tools/gopls v0.1.8-0.20200328031815-3db5fc6bac03

Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/myitcv/.cache/go-build"
GOENV="/home/myitcv/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/myitcv/gostuff"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/home/myitcv/gos"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/myitcv/gostuff/src/github.com/myitcv/govim/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build432849091=/tmp/go-build -gno-record-gcc-switches"

What did you do?
As pointed out by @findleyr in https://github.com/govim/govim/pull/832#issuecomment-605335928, we are seeing duplicate "undeclared name" errors from gopls, as highlighted by the following govim test.
# Test for duplicate undefined errors

# Ensure we have two warnings
vim ex 'e main.go'
vimexprwait warnings.golden GOVIMTest_getqflist()

# Now create a single error and verify we see only that
vim ex 'e other.go'
vim call append '[6,"asd"]'
vimexprwait errors.golden GOVIMTest_getqflist()

-- go.mod --
module mod.com

go 1.12
-- main.go --
package main

import "fmt"

func main() {
	fmt.Printf("%v")
}
-- other.go --
package main

import "fmt"

func foo() {
	fmt.Printf("%v")
}
-- warnings.golden --
[
  {
    "bufname": "main.go",
    "col": 2,
    "lnum": 6,
    "module": "",
    "nr": 0,
    "pattern": "",
    "text": "Printf format %v reads arg #1, but call has 0 args",
    "type": "",
    "valid": 1,
    "vcol": 0
  },
  {
    "bufname": "other.go",
    "col": 2,
    "lnum": 6,
    "module": "",
    "nr": 0,
    "pattern": "",
    "text": "Printf format %v reads arg #1, but call has 0 args",
    "type": "",
    "valid": 1,
    "vcol": 0
  }
]
-- errors.golden --
[
  {
    "bufname": "other.go",
    "col": 1,
    "lnum": 7,
    "module": "",
    "nr": 0,
    "pattern": "",
    "text": "undeclared name: asd",
    "type": "",
    "valid": 1,
    "vcol": 0
  }
]

The output from the test is:
        # Test for duplicate undefined errors (0.497s)
        > vim ex 'e main.go'
        > vimexprwait warnings.golden GOVIMTest_getqflist()
        # open other.go and add a broken statement to get an error that masks the warnings (4.956s)
        > vim ex 'e other.go'
        > vim call append '[6,"asd"]'
        [stdout]
        0
        > vimexprwait errors.golden GOVIMTest_getqflist()
        [stderr]
         [
           {
             "bufname": "other.go",
             "col": 1,
             "lnum": 7,
             "module": "",
             "nr": 0,
             "pattern": "",
             "text": "undeclared name: asd",
             "type": "",
             "valid": 1,
             "vcol": 0
        -  },
        -  {
        -    "bufname": "other.go",
        -    "col": 1,
        -    "lnum": 7,
        -    "module": "",
        -    "nr": 0,
        -    "pattern": "",
        -    "text": "undeclared name: asd",
        -    "type": "",
        -    "valid": 1,
        -    "vcol": 0
           }
         ]
        [exit status 1]
        FAIL: testdata/scenario_default/test.txt:9: unexpected command failure

What did you expect to see?
The test passing
What did you see instead?
The test failed, as above.

cc @stamblerre @ridersofrohan
FYI @leitzler

I can't seem to reproduce this using VSCode or running gopls tests. They only seem to return a single undeclared diagnostic. Are you able to see what the source of the diagnostic is (ex. "compiler", "undeclaredname",...)?

Apologies, I forgot to attach the gopls log. Here it is: gopls.log

@myitcv I created a test in https://golang.org/cl/226417 using Rob's regtest framework that does the same behavior as the vim test in question. It does not seem to be returning 2 diagnostics. From the gopls log you sent, it looks like the ranges are different. The way the new type error analyzers work is that there is a check to replace existing type errors with the analyzer error if they have the same range and message.
[Trace - 16:16:07.059 PM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///tmp/artefacts/govim/cmd/govim/scenario_default/script-signs_unload_load_buffer/other.go","version":2,"diagnostics":[{"range":{"start":{"line":6,"character":0},"end":{"line":6,"character":3}},"severity":1,"source":"compiler","message":"undeclared name: asd"},{"range":{"start":{"line":6,"character":0},"end":{"line":7,"character":0}},"severity":2,"source":"undeclaredname","message":"undeclared name: asd"}]}

@stamblerre is this a gopls thing?
cc @findleyr

@ridersofrohan - are the configurations identical, comparing your test with the govim test?

@ridersofrohan: It looks like the ranges aren't the same for these errors - is that causing the problem, maybe?

What's the status here @stamblerre - did you close this by accident?

Nope - the above CL fixes the test.

Ah sorry, I hadn't appreciated that. I saw:
Updates golang/go#38136

and assumed there were further CLs to follow.

Isn’t it easier to track progress if issues are closed after the CL is merged?

Sorry about that, I had originally meant to leave this issue opened to track the follow-up CL I mentioned in the description, but then decided it wasn't worth leaving this open for that.

I see that https://go-review.googlesource.com/c/tools/+/226962 has actually fixed this. https://go-review.googlesource.com/c/tools/+/226777/ is not merged.

Ah, ok since this is fixed I will close the issue. We'll re-enable these analyzers with gopls/v0.5.0, so we'll make sure not to break this test again with that release.


@Builder not work with static import in Intellij 2016.2.4

I have an issue with static import mode with @Builder
import com.raimtec.milkyway.orch.mktfeed.EventType;
import java.util.ArrayList;
import java.util.Collection;
import lombok.AllArgsConstructor;
import lombok.Builder;
import lombok.Data;
import lombok.NoArgsConstructor;

@Data
@Builder(builderMethodName = "ibMarketFeedRequestBuilder")
@NoArgsConstructor
@AllArgsConstructor
public class IBMarketFeedRequest {

  private String contextId;

  private Collection<EventType> eventTypes = new ArrayList<>();

}

When I use static import like this :
import static com.raimtec.milkyway.orch.mktfeed.ib.IBMarketFeedRequest.ibMarketFeedRequestBuilder;

public class MyService  {
  public void serve() {
    IBMarketFeedRequest request = ibMarketFeedRequestBuilder().contextId(marketFeed.getId()).eventTypes(eventTypes).build();
  }
}

I get error below :
Error:(23, 1) java: cannot find symbol
  symbol:   static ibMarketFeedRequestBuilder
  location: class

If I use normal mode:
import com.raimtec.milkyway.orch.mktfeed.ib.IBMarketFeedRequest;

public class MyService  {
  public void serve() {
    IBMarketFeedRequest request = IBMarketFeedRequest.ibMarketFeedRequestBuilder().contextId(marketFeed.getId()).eventTypes(eventTypes).build();
  }
}

It works perfectly.
If I build the project in commandline without Intellij, it works too.

+1 I have the exact same problem - it's weird.
Note that the problem isn't related to overriding the builder method name - it's just the static import that triggers this.

+1 I'm seeing this too. It's really hard to debug what the issue is when it happens as everything just breaks.

This error comes from javac, not IntelliJ.
Unfortunatly static import for BuilderClass is not possible with lombok: https://github.com/rzwitserloot/lombok/issues/2044
I can only think about adding some Inspection and generate IntelliJ-Warning in this situation.

Just letting you know that this is a feature I would very much like, would have saved me a few hours of debugging and head-scratching.


Add Python 3.6 to configurations

This adds Python 3.6 to tox (requiring a minimum version bump), and
adds the support string to the setup.py
Closes #1115
cc @kyleknap @jamesls @stealthycoin @dstufft

Switched from 3.6-dev to 3.6. Some tests are failing, but it seems unrelated. Investigating.

Test failures appear to be related to #1116. Rebased.

Current coverage is 97.65% (diff: 100%)

Merging #1117 into develop will not change coverage

@@            develop      #1117   diff @@
==========================================
  Files            44         44
  Lines          7035       7035
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           6870       6870
  Misses          165        165
  Partials          0          0

Powered by Codecov. Last update d10dac4...d51ef1e


Test-Connection needs to be revised due to an internal breaking change in .NET 7

Prerequisites

[X] Write a descriptive title.
[X] Make sure you are able to repro it on the latest released version
[X] Search the existing issues.
[X] Refer to the FAQ.
[X] Refer to Differences between Windows PowerShell 5.1 and PowerShell.

Steps to reproduce
Here is the dotnet issue: https://github.com/dotnet/runtime/issues/66746
Here is the breaking change note: https://github.com/dotnet/docs/issues/28720
Basically, System.Net.NetworkInformation.Ping doesn't support specifying payload on Linux:

it throws PlatformNotSupported exception when custom Ping payload is specified, and the process is not running as root.
even if running as root (sudo), the custom payload is simply ignored because on Linux it's implemented by interfacing with the ping native utility, which doesn't support specifying custom payload.

So, whatever functionality in Test-Connection that depends on specifying custom payload is broken and should be either fixed or removed.
Attention: Workaround was added to test code in Test-Connection.Tests.ps1 by https://github.com/PowerShell/PowerShell/pull/16930. Please fix the tests when resolving this bug, or removing the related tests if the affected functionalities will be removed.
Expected behavior
N/A

Actual behavior
N/A

Error details
N/A

Environment data
PowerShell 7.3-preview.3

Visuals
No response

@iSazonov You may want to take a look at this issue.

My read of the linked issue and related issues/PRs seems to indicate that the content of a custom payload is ignored, but the size of the payload is still passed to the ping native util if running as root or with proper capabilities (permissions?) set on the calling process.
So I guess the question here is -- is this enough of a feature that we think it worth keeping for that (kinda narrow imo) use case, and wrap the error that comes up to tell the user to run pwsh as root if they want to use the relevant parameter? Or do we just compile this on Unix systems without that parameter entirely / ignore it if it's set?

@vexx32

So I guess the question here is -- is this enough of a feature that we think it worth keeping for that (kinda narrow imo) use
case, and wrap the error that comes up to tell the user to run pwsh as root if they want to use the relevant parameter? Or do > we just compile this on Unix systems without that parameter entirely / ignore it if it's set?

Is anything going to be done to address the issue with Test-Connection now requiring root on Linux?
Standard ping command works fine on  Linux as a regular user.
At a minimum add an option to Test-Connection that allows it to work for regular users like standard ping command does.
So often I see MS's answer that they won't fix something because it might/could break existing customer code that depends on that behavior and yet this change which actual broke all my code uses of Test-Connection is allowed to stand.
Maybe MS needs to change their answer to "Won't fix something because it might/could break existing customer code that depends on that behavior except for all the exceptions that we make".
Guess I write my own Test-Connection around the built in ping command to get a workable solution as it doesn't sound like this will be addressed.

@SteveL-MSFT
Thanks Steve that would be an appreciated solution.
Is there an ETA as to what pwsh release that change will target ?
Thanks


Expand on column with other dataField value

Hi @AllenFang, I have a table with some attributes and one of them is price, sometimes I want to show the price and on some specific occasions I want to show the expandComment.
Is this possible? Can I have access to any variable or state that tells me when the row is expanded on priceFormatter?
Best Regards,
Eduardo Abreu

and btw and getting this '...'
https://s.nimbus.everhelper.me/share/1176140/nfxluu07vg8cpl3ozyep
Any idea why this happens?

@eduAbreu
For first issue, I can understand what your said, please describe more detail... sorry.
BTW, the react-bootstrap-table state(expanding) can tell you current expanding rows, you can use ref to get the table reference.
For the second issue, is you use bootstrap 4? and is the ... appear on checkbox of selection column? Maybe you can try to increase the width of selection column if you are not using bootstrap 4.
thanks


[OwnershipUtils] Undef isn't introduced/enclosed.

Previously, calling visitEnclosingDefs or visitBorrowIntroducers would crash if the SILValue argument were an instance of SILUndef because both instantiate a ::FindEnclosingDefs with the the result of of calling getFunction() on that argument and ::FindEnclosingDefs in turn uses that result to create a ValueSet; but SILUndef::getFunction returns nullptr, which is illegal to use as the function for a ValueSet(or any other data structure relying on NodeBits).
If the function specified as a separate argument, no values would be visited and true would be returned.  Instead of burdening the API with a separate argument, check for SILUndef up front and return true.

@swift-ci please test


Impossible to restart with a volume

Hello,
Thanks for your great work!
I'm able to init a new database with a docker volume, but after a docker-compose down && docker-compose up -d, it no longer restarts.
Error logs with docker-compose logs -f
Attaching to oracle_web_1
web_1  | found files in /u01/app/oracle/oradata Using them instead of initial database
web_1  | rm: cannot remove '/u01/app/oracle-product/12.1.0/xe/dbs': Directory not empty
web_1  | found files in /u01/app/oracle/oradata Using them instead of initial database
web_1  | rm: cannot remove '/u01/app/oracle-product/12.1.0/xe/dbs': Directory not empty
...

My docker-compose.yml
# cat docker-compose.yml
version: "2"
services:
  web:
    image: sath89/oracle-12c
    restart: always
    ports:
      - '8180:8080'
      - '1521:1521'
    tty: true
    volumes:
      - 'oracle:/u01/app/oracle'
volumes:
  oracle:

Hello, I'm facing same problem in attache volume on start the docker image
Any solution with this problem?


File stops being executable

Is it possible to retain the files permission attributes, specifically executable?
Now I always have to do a chmod +x after creating a folder with a bash script in it.

hey @m4rinos I just pushed an update which should help you. Please refer here https://github.com/Huuums/vscode-folder-templates#available-ftsettingsjson-properties (specifically setExecutablePermission).
I made this to be an explicit opt-in functionality because of potential security concerns if we just made every file executable by default.

thanks! this works perfectly and thank you for your quick response!!


No way to remove code action once active/clicked

Once clicking on the code button and activating the action, I haven't found anyway to remove the formatting. Clicking on the button again or pressing enter doesn't work to remove pre tags.
This is what I'm doing for a work-around:
        {
          name: "startCode",
          icon: "<>",
          title: "Start Code Block",
          result: () => exec("formatBlock", "<pre>")
        },

        {
          name: "endCode",
          title: "End Code Block",
          icon: "</>",
          result: () => exec("formatBlock", "<p>")
        }

@chriseickemeyerGH see #145 and #178

@algorys thanks, I'll close this issue.


fbcp

Thanks for this page, very much appreciated.
Silly question though. How do I install fbcp on my Pi3? (novice Linux user).

Disregard. I saw how to edit the start-gui.sh here https://community.victronenergy.com/comments/143305/view.html


Update sbt-dotenv to 2.1.186

Updates au.com.onegeek:sbt-dotenv from 2.1.146 to 2.1.186.
I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.
If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.
Configure Scala Steward for your repository with a .scala-steward.conf file.
Have a fantastic day writing Scala!

Ignore future updates
Add this to your .scala-steward.conf file to ignore future updates of this dependency:
updates.ignore = [ { groupId = "au.com.onegeek", artifactId = "sbt-dotenv" } ]

labels: sbt-plugin-update, semver-patch

Codecov Report

Merging #127 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #127   +/-   ##
=======================================
  Coverage   12.96%   12.96%
=======================================
  Files          54       54
  Lines        2168     2168
  Branches       28       28
=======================================
  Hits          281      281
  Misses       1887     1887

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c94980...5b13b30. Read the comment docs.