[Design] SDK vs. MSBuild

Our default connector template comes with an msbuild file (connector.proj), but defaults to using the SDK build mechanism. This might be confusing for users.
We should remove the .proj from our template if we are defaulting to the SDK build.
That said, generating a new proj file from scratch can be difficult, and it would be great to replace the existing .mproj file (which targets an older msbuild) with a newer/simplified .proj file that uses modern msbuild features.
Design questions

Should we make the SDK build vs. MSBuild a choice when you create a connector?
Can we add an "enable for MSBuild" command that changes the default build mode to msbuild and generates a new proj file based on the current workspace contents?

I don't feel strongly about (1), but I would lean towards not making a new connector option, since the use of msbuild is likely a more advanced scenario. I do see value in (2) though, especially as we continue to improve the default build template (making it easier to sign extensions, insert localization steps, etc)... but you could argue that a developer could simply copy their msbuild definition from published templates or samples.

Are you strongly married to keeping both build system options? For simplicity, would there be any chance to standardize on just one (i.e. MSBuild, if that is needed because if its support for advanced scenarios)?
Thinking that a beginner user may not need to touch the build file, so whether SDK or MSBuild is used doesn't affect them. For an advanced user, likely the additional SDK-related options they need to set wouldn't be too complex to set in either style build file, so maybe just supporting one style would be sufficient??

Related: How many of the legacy SDK's options do you anticipate the new SDK will support (perhaps with different syntax/command line args)?
  <AllowNativeQuery>True</AllowNativeQuery>
  <AsAction>True</AsAction>
  <FastCombine>True</FastCombine> -- irrelevant, as in the new SDK this behavior is enabled by default and cannot be turned off
  <ClearLog>True</ClearLog> -- irrelevant, as new SDK traces are output to files
  <ShowEngineTraces>True</ShowEngineTraces> -- handled by --logMashupEngineTraces
  <ShowUserTraces>True</ShowUserTraces> -- handled by --logMashupEngineTraces
  <LegacyRedirects>True</LegacyRedirects>
  <SuppressRowErrors>True</SuppressRowErrors>
  <SuppressCellErrors>True</SuppressCellErrors>
  <MaxRows>1000</MaxRows>
  <ThrowOnFoldingFailure>True</ThrowOnFoldingFailure> -- handled by --failOnFoldingFailure


Add more parameters for acl

add new parameters for acl request

Server listen port
Peer name and port
Mount path for pub/sub

We will support it in version 3.2.

Thank you for your participation, already supported in the latest version, I will close this issue.


Adapter Test: Egress activity

Feature Request
Use Web Chat Core to communicate with an adapter and a bot.
Web Chat Core will send a message. The bot should receive this message.
This test code will be executed by two or more adapters of different nature.
Although the implementation of helper bot varies between adapters, the interface of the helper bot should be kept the same across all adapters.
Pseudo code
import { createStore } from 'botframework-webchat-core';
import random from 'math-random';

test('ingress activity', () => {
  return new Promise(resolve => {
    const testRunId = random().toString(36).substr(2, 5);
    const testMessage = `My test message: ${testRunId}`;

    // The helper bot should receive the test message and resolve the Promise.
    helperBot.addEventListener('activity', ({ activity }) => {
      activity.text === testMessage && resolve();
    });

    store = createStore({}, ({ dispatch }) => next => action => {
      // After Web Chat Core connected to the facility, it will post an activity to the helper bot.
      if (action.type === 'DIRECT_LINE/CONNECT_FULFILLED') {
        action.dispatch({
          type: 'DIRECT_LINE/POST_ACTIVITY',
          payload: {
            activity: {
              text: testMessage,
              type: 'message'
            }
          }
        });
      }
    });

    const helperBot = createHelperBot();

    store.dispatch({
      type: 'DIRECT_LINE/CONNECT',
      payload: {
        directLine: createDirectLine({ token: helperBot.token })
      }
    });
  });
});

[Enhancement]

Done.


JS snippets dont work on vue files

JS snippets didnt work on vue files but did work on jsx files , is this normal? Also would it be possible to make them work on vue files? :thinking:

I was facing the same problem. I think only the snippets inside the frameworks/vue folder are being loaded for vue. If you copy that javascript snippets inside vue/javascript it will be loaded.

should work now, let me know.

Working fine now, thanks!

@rafamadriz sorry to bother! could you include svelte too?

JS snippets didnt work on vue files but did work on jsx files , is this normal? Also would it be possible to make them work on vue files? thinking

Better solution might be
vim.g.vsnip_filetypes = {
    vue = { "javascript", "html" },
}


Remove Repo._n_join and refactor its use

This PR addresses the use of Repo._n_join, replacing it with '\n'.join(map(str, to_join)). I've also addressed some other string formatting issues for methods I've touched with this change. There are more string formatting issues to address throughout the codebase, but addressing those here would make the PR very large.
There is one commit on refactoring Repo._fsck_unique_assets(), which was done to both make the code more readable, but also make the subsequent error logging more straightforward.

LGTM!


Updates

gitignore docs/annotated
Updated travis
Added changelog
Updated contributors section
Added docco (annotate)
Added pre-commit
Updated deps
Updated readme
Added create-a-release.md

LGTM


issue of  android back button

Preparation
const B = tabNavigator ({
         E:{screen:E} ,
         F:{screen:F},
})
const A = stackNavigator({
         C:{screen:C},
         D:{screen:D},
         B::{screen:B}
},{
     initialRouteName:C
})

Reproduce steps
1、open App,  C is rendered now
2、navigate to B and initial tab is E
3、navigate to F
4、navigate to D
5、click back button of android，noting happened
6、click back button of android
Current Behavior
Go back works after clicked twice, and current screen is tab E of B
Expected Behavior
Go back after clicked once and current screen should be tab F of B
Your Environment

software
version

react-navigation
1.0.0-beta.19

react-native
0.49.3

node
8.1.3

npm
4.6.1

Thanks for reporting.
Is it somewhat related to https://github.com/react-community/react-navigation/issues/2549?

@kelset  I don't think so. #2549 used goback of navigation for go back but mine is hardware back button of android device

@mc-tracker are u adding eventListeners to some component in between? I was facing same issue while working with hardwarePress eventListeners.

@jinxac FYI, I'm only binding listener in root component.

this should be resolved. if it is not working as expected still on the latest version, please create a new issue with a runnable example on https://snack.expo.io -- thanks!


Generated token is not recognized

Describe the bug
The generated token is always flagged as invalid. This means no account can be created.
Specifically, if you access https://matrix.bielefeldt.berlin/matrix-registration/register?token=VampireTobaccoAndroid and try to create an account, the token is not accepted, even though it was generated by this instance.
To Reproduce

Go to https://matrix.bielefeldt.berlin/matrix-registration/register?token=VampireTobaccoAndroid.
Try to register an account.
Expected behavior
The token should be accepted as valid and the account created.
System:

OS: Debian
python version: 3.6
matrix registration version [e.g. 0.5]

Additional context
I have not installed matrix-registration directly but via the playbook described here https://github.com/spantaleev/matrix-docker-ansible-deploy/blob/master/docs/configuring-playbook-matrix-registration.md.

First of please check if the token is correctly added in the database with:
curl -H "Authorization: SharedSecret <APIAdminPassword>" https://matrix.bielefeldt.berlin/matrix-registration/token

The error was on my part. I just realised that the tutorial I copied the command for generating the token from set the expiration_date to 2021, which I failed to realise is already over.
I'm thinking it would probably be best to prevent generating a token that has already expired, but maybe I'm missing comlications that could arise from that (especially with regards to time zones or something).


Upload PneumoniaDetection zipped folder failed

From within AzureML notebook:
I have to download the whole repository and upload the particular folder to get it works.
Upload the unzipped folder  or just upload the zipped folders both wont work (dont have the right content). Have i done anything wrong or it is the zipped file's problem?

@rhpoon Please identify the code sample that you are referring to.

@rhpoon No response, closing this issue.


[5.4] Convert object rules to string only once.

Currently if you have this rule definition 'required|'.Rule::in([1,2]), __toString of Illuminate\Validation\Rules\In will be called only once, however in the following two cases the method will be called over 20 times in the second case and 8 times in the first case.

Rule::in([1,2])
['required', Rule::in([1,2])]

This PR converts these object rules to string once in the parser so that we don't have to do it again.

Not sure what's wrong with StyleCI


Update repo docs

Description
Updates various documentation files for the repo. This still contains some placeholder content (like the contact email in CONTRIBUTING.md) and commented-out bits that aren’t yet applicable or known.
Motivation and context
This will help inform stakeholders and future contributors. It also helps us build and maintain a welcoming, inclusive community and values transparency as we intend to do.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] Non-source (for changes that don’t affect the source code, e.g. documentation)

Checklist

[ ] Renders and functions properly in all supported browsers
[ ] Automated tests written and passing
[x] Accessibility and inclusivity considered
[ ] Rendering performance (initial load time & 60fps) and perceived performance considered
[x] Documentation created or updated

How does this PR make you feel?

I already noticed two issues:

We need an option under Types of changes that includes non-src changes
Not all Checklist items are always applicable and the intro comment needs to reflect that

Both issues addressed and this PR has been updated to reflect the changes.

2 more issues I noticed:

After reviewing more design systems in detail, I’m noticing that many recommend the --save flag when npm installing. We should probably do the same.
By using checkboxes for the Types of changes, the “x of 9” metadata available on the list view isn’t as useful. Maybe we could instruct them to remove non-relevant lines rather than xing the boxes?

I addressed the --save comment.

Also addressed the checkboxes for Types of changes issue, and this PR has been updated to reflect the changes.


gh-1811 - ability to skip permissions on accumulo imports added

Codecov Report

Merging #1822 into develop will decrease coverage by 0.69%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             develop    #1822     +/-   ##
============================================
- Coverage      66.29%   65.59%   -0.7%
+ Complexity      2106     1985    -121
============================================
  Files            838      716    -122
  Lines          27367    22965   -4402
  Branches        3490     3002    -488
============================================
- Hits           18143    15064   -3079
+ Misses          7807     6673   -1134
+ Partials        1417     1228    -189

Impacted Files
Coverage Δ
Complexity Δ

...on/hdfs/mapper/SampleDataForSplitPointsMapper.java

...affer/accumulostore/key/AbstractElementFilter.java

...lostore/operation/impl/GetElementsBetweenSets.java

.../hdfs/handler/SampleDataForSplitPointsHandler.java

...mulostore/operation/impl/GetElementsWithinSet.java

.../byteEntity/ByteEntityIteratorSettingsFactory.java

...andler/javardd/ImportJavaRDDOfElementsHandler.java

.../impl/classic/ClassicAccumuloElementConverter.java

...re/retriever/impl/AccumuloAdjacentIdRetriever.java

...o/operation/utils/AccumuloKeyRangePartitioner.java

... and 108 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a444662...37c21de. Read the comment docs.


enhance build.sh to put logs someplace better

@perry-ca feel free to take this

logs seem to be working ok in the actual 'port' clone/tarball directory. @perry-ca please re-open if you would like to improve this.


Support more than one part

WSDL support more than one message part, but soapfish hard refuses it.
https://github.com/FelixSchwarz/soapfish/blob/master/soapfish/wsdl11.py#L51

True! I searched the issues before create this one, but didn't found. :+1:


Download 5MB file fails (on E2EE)

Also, ideally clicking on the thumbnail should open the big picture in a new tab, instead of attempting to download it.

https://stackoverflow.com/questions/31752118/javascript-locally-generating-and-downloading-a-huge-file
https://craignicol.wordpress.com/2016/07/19/excellent-export-and-the-chrome-url-limit/
https://bugs.chromium.org/p/chromium/issues/detail?id=69227
There seems to be a Chrome limit of data URL length at ~2MB, hence ~1.5MB of binary data.

Firefox doesn't have this problem, it downloads a 28MB picture just fine.
This confirms https://stackoverflow.com/a/41755526/871134 . The "current document" Chrome limit seems a bit odd.

URL.createObjectURL(blob) helps a lot...


Public config.js keys

I noticed that config.js is excluded in the .gitignore file, but I wanted to make sure you were aware these secrets are still available in the bundled chrome extension. I know it may not be realistically possible to fix this without using an additional server, and it's unlikely that many people would be doing this. It just made cloning the project a little surprising 😄. If you want more info, I can send it to you privately.

Hey @funblaster22! I am aware of this issue, and you're correct - unfortunately there's no great way to go about fixing this without a server in the middle to proxy requests to the other services, and as this is an unpaid chrome extension, it's hard to justify paying for server costs.
That said, I am working on a full revamp of this extension and new feature for the extension that will include some server work and corresponding monetization, so I may move these calls to be proxied at that point :).

Btw I'm gonna go ahead and delete this issue, as it is a security concern with the current implementation. While it's not particularly hard for someone to figure out how to get these keys, I'd rather not have a public issue about it haha


Support for Facebook Subscription Messaging?

Hi
How can I use botkit for facebook to make use of the subscription messaging feature described here:
https://developers.facebook.com/blog/post/2016/08/15/updated-messenger-platform-policies/
e.g. a news bot to which the user subscribed to receive daily news updates.
Any reference/example will help, thanks!

+1

You could use bCRM middleware for subscription + basic analytics https://github.com/howdyai/botkit-middleware-bcrm

I though a solution with node-schedule(https://www.npmjs.com/package/node-schedule) and bot.say like:

var j = schedule.scheduleJob('42 * * * *', function(){
  bot.say(
  {
    text: 'The answer to life, the universe, and everything!',
    channel: '+1(###)###-####' // a valid facebook user id or phone number
  }
);
});

But I didn't try it yet

great! @AdanTL
Thanks for the idea!
the node-scheduler works within botkit!
bot.Say is not supported into botkit but I did manage to make it work with a bot.Conversation:
_var schedule = require('node-schedule');
var j = schedule.scheduleJob('*/1 * * * *', function(){
sendMessage();  });
function sendMessage()
{
           bot.startConversation({
                        user: 'XXX',
                        channel: 'XXX',
                         text: 'dummy'
                             }, function(err, convo) {
                                convo.ask({
                                channel: 'XXX',
                                text: 'what?'
                                }, function(res, convo) {
                                convo.say('ok!')
                                convo.next()
                                 })  } );
}_

Note: you can only contact users that send messages to your chatbot before and for which you can extract their ID using 'message.user' from within controller.hears(... )
I only tried with myself and it worked!...have to test with other users...

Nice code buddy! but did you try to send a message after the 24h window?

@razzza what do you mean with

bot.Say is not supported into botkit

Thanks.
What do you mean by that @AdanTL?

@natterstefan it doesn't matter anymore, anyway I meant that if you don't request for Facebook Subscription you can't talk after 24h


[Bug] Shop Down, keeps showing Connection Error

Type of Bug

[ ] UI (Problems with the console itself)
[ ] Install (Problems with installing the console)
[ ] Boot (Problems with loading or opening games)
[✅ ] Shop (Problems with the eShop)
[ ] Online (Problems with other Online Features)
[ ] Other

Issue:
The shop won't work. Even though I'm connected to the internet
Expected behavior:
Once you are connected, it would show the shop UI.
Screenshots:

Specs:

OS: Windows 11
Browser: Google Chrome 103.0.5060.114 (Official Build) (64-bit)
Console Build Version: Release 1.1.0

Additional context:
None

We are well aware that the shop is down. Theres a problem with our servers rn that we are working on fixing.


Orbital Ion Cannon Compatibility

Error while running setup for entity prototype "ion-cannon-targeter" (ammo-turret): next_upgrade target (5d-gun-turret-02) must have the same bounding box.

This issue seems to be caused by a 5dim mod, which modifies the prototype 'ion-cannon-targeter' leading to this error.
Solution: The ion-cannon-targeter should not be modified this way.
Mods:

Orbital Ion Cannon (SE Edition)
5dim Complete Modpack

Just found that it was fixed for the original mod in compatible-mods.lua
so adding a condition for 'Kux-OrbitalIonCannon' should work.  I have added the same fix, so the loading order should not matter. even without adding a dependency entry and i can remove the dependency entry in my mod.
Feel free to contact me in Discord kux#5599


Button value doesn't get passed to action when using Remix  component

When using a form to perform an action without inputs (e.g. log out a user) using the <Form />:
<Form method="post" action="/me">
  <button name="actionId" value="sign-out" type="submit">
    Sign Out
  </button>
</Form>;

The action in Remix doesn't receive the button value at all.
  const text = await request.text();
  const params = new URLSearchParams(text);
  const entries = Object.fromEntries(params); // entries is an empty object

On the other hand, if I replace the <Form/> for a regular <form />
<form method="post" action="/projects">
  <button name="actionId" value="sign-out" type="submit">
    Sign Out
  </button>
</form>;

  const text = await request.text();
  const params = new URLSearchParams(text);
  const entries = Object.fromEntries(params); // { actionId: 'sign-out' }

I think this is a duplicate of #101  and can be closed!

Should be fixed now, if not, please open a new issue with a failing code sample 🙏🏼


Configurable check names

This was brought up few times by our users to avoid having long check names such as testing-farm:OL8.7-x86_64-HVM-2023-03-07:tier1. The initial idea would be to be able to assign some aliases to the targets.

[ ] design the solution on what will be configurable (e.g. only the targets)
[ ] implement the configuration option(s)

I think this is covered by status_name_template.


readme typo + process example

Fixed a typo on std::shared_ptr in readme and added "4. Process the events" to readme to clarify how to use the library.

Thank you.


Fix issue #27

Hi Guys, I don't know what is the protocol here as the issues is already described and we discussed we were going to fix it quickly. Somehow I manage to fix it in all packages just touching the core, therefore only the tests were failing.
I also thought that maybe we could put the name of the method in a more contrasted way, therefore the users will see it better.

Great job @GuilleEneas !
Thanks for this PR! 🙏💪
Please checkout my comments and let me know what you think

Thank you @shairez !!!
I had a lot of doubts when implementing in what do. Add this attribute in this type or... btw, first I made that attribute optional, but when calling the error handling method the linter told me that I couldn't use the !. It didn't make any sense (to me at least) to make the function name optional in the throwArgumentsError so I decided to do what I did in first place. After your comments I remove it from the object and add an extra parameter wherever I had to.
Also squeezed all commits into one to not pollute the git history 🙂
Please take a look to the final result and let me know if you want me to change anything else.
Looking forward to contribute more 🤓

Thanks for the fixes @GuilleEneas !
I've added 2 more comments, please check them out
after those, I believe we're ready to merge it
Thanks again!

@shairez, changes implemented 😉

I will move it to the common describe, also in the version for jasmine. To me having a number feels a bit arbitrary, nonetheless I never know when in my tests should I extract something to a more global scope vs keeping things together where they belong.

It comes from here  -
https://en.wikipedia.org/wiki/Rule_of_three_(computer_programming)
So it's not that arbitrary 😀
Here's a nice article about it -
https://andrewbrookins.com/technology/the-rule-of-three/
Thanks again for making the fix!

@all-contributors please add @GuilleEneas for code and tests

MERGED! 🎉😀
Thanks again for your contribution 🙏
Great job! 💪


Homematic docker on QNAP

Hi
I am wondering whether it would bee possible to make the homematic docker image working on QNAP ARM based or Intel based?
Thanks

Hi,
it might work out of the box if you do not need to use the the homematic PCB adapter.
I will release in the next minutes a version that will not enforce running in a known platform so any ARM platform should not work.
As soon as ELV releases the USB adapter for Homematic IP I will add support for it. I expect than then any platform should be able to use it within a docker container.

New docker container available - @DominikBaer please give it a try and let me know.


Inconsistent Shortcut Key Combinations Across Keyboard Language Settings

When working with Excalidraw, I often switch between languages. This leads to a problem when I forget to switch back to English. For example, I want to create groups of elements using the Russian keyboard layout by pressing CTRL + G, but this shortcut currently doesn't create a group. To complete this simple task, I'm forced to either switch the keyboard layout or use the right-click menu, both of which are less than ideal solutions.

Hi @Halkfr, do you have this problem with alternate English keyboard layouts like Dvorak, Colemak, etc?

Hi @DanielJGeiger! I use standard English keyboard layout and it works fine with that but it doesn't work with standard russian keyboard layout. With russian keyboard layout pressing CTRL + G (CTRL + П) I get browsers default behavior where Ctrl G is used to find the next occurrence of a search term.
I hope it made the issue clear!

@DanielJGeiger I do have this problem with Dvorak.


Init script doesn't handle assets set up for subset of domains

Describe the bug
A clear and concise description of what the bug is.
The init script should handle registration of new assets even if not all the domains are configured. Some projects may only want assets deployed to a select number of chains.
Additional context
Add any other context about the problem here.

Tested against PR: https://github.com/connext/monorepo/pull/4811/files
worked with the following command:
yarn workspace @connext/smart-contracts initialize --name "assets" --network "testnet" --env "production" --apply "false" --domains "1735353714" "9991"


edit story from topic story page is broken

When I got to this page directly in a new tab, it works fine:
https://topics.mediacloud.org/#/admin/story/543137064/update
But when I go to this page and click on the 'edit this story' link, none of the data is filled in the form:
https://topics.mediacloud.org/#/topics/2424/stories/543137064?focusId=&q&snapshotId=2762&timespanId=278019

works for me now as well.
-hal
On Tue, Mar 5, 2019 at 8:23 AM rahulbot<EMAIL_ADDRESS>wrote:

Closed #1457
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mitmedialab_MediaCloud-2DWeb-2DTools_issues_1457&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=0c5FW2CrwCh84ocLICzUHjcwKK-QMUDy4RRw_n18mMo&m=1nLzQEXX-1sQ3OTtueHOROxNS3MWL-QH-90JA_IHvig&s=qAFeLDt8XxGOxplgfn3eI_c9NfsWXNtDPtw1GjryBhU&e=
.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_mitmedialab_MediaCloud-2DWeb-2DTools_issues_1457-23event-2D2181113870&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=0c5FW2CrwCh84ocLICzUHjcwKK-QMUDy4RRw_n18mMo&m=1nLzQEXX-1sQ3OTtueHOROxNS3MWL-QH-90JA_IHvig&s=AqBYPsxiLYrTyQ4w4SWPaJLUd-SmgmBm2DxsJBiylh8&e=,
or mute the thread
https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABvvTxblrvnmWj-5F1J1H6xSgV6xR2xhL6ks5vTn3fgaJpZM4aT1ij&d=DwMCaQ&c=WO-RGvefibhHBZq3fL85hQ&r=0c5FW2CrwCh84ocLICzUHjcwKK-QMUDy4RRw_n18mMo&m=1nLzQEXX-1sQ3OTtueHOROxNS3MWL-QH-90JA_IHvig&s=RVZA1GqHJYdwSBxyuIMeVc8HdiElkBjwlWjILDQ7yKY&e=
.

--
Hal Roberts
Fellow
Berkman Klein Center for Internet & Society
Harvard University


redo the updates to hypotenuse, qrexc_Rfull, and evalf

After the last updates to hypotenuse, qrexc_Rfull, and evalf, the profiling started to costume much more time than before. This PR revokes the changes and redoes them one by one. It turns of that the recording and resetting of rng in evalf took significant time.

Changes have been integrated into main.


Add support for dynamic and nested NFTs

The modified contract introduces a new NftType enum to differentiate between static, dynamic, and nested NFTs. The NftData struct contains the new fields nftType, parentId, and childIds to support dynamic and nested NFTs.
The createStaticNft function creates a new static NFT with the specified recipient and token ID.
The createDynamicNft function creates a new dynamic NFT with a new token ID and the specified recipient.
The createNestedNft function creates a new nested NFT with a new token ID, the specified recipient, and the parent NFT ID. It also adds the child NFT ID to the childIds array of the parent NFT.
The getChildNfts function returns an array of child NFT IDs for a given parent NFT ID. (used to retrieve child NFTs for the nested NFTs)

@mbcse, modified the contract to support dynamic and nested NFTs.


Proposed make file changes

instead of make benchmark we can run it with BENCHMARK=1 make... what do you think @zktony  ?

LGTM, @simonsso @haerdib can we merge it now?

LGTM, @simonsso @haerdib can we merge it now?

As it's only to your branch and not to develop, I think its fine.

Okay cool .. thnaks for help @haerdib 🙂


Calpytos rsyncs full pwd, causes long deployment times, appears hung

Hey folks,
I've pulled from master, latest commit is:
cdf30c84f22a4a2a1ed9b79c41b061d66554aa1a

My environment file is like this:
---
  name: prc-test
  cookbook_versions: {}
  default_attributes:
    eucalyptus:
      enterprise-repo: "http://packages.release.eucalyptus-systems.com/yum/tags/enterprise-4.1/centos/6/x86_64/"
      euca2ools-repo: "http://packages.release.eucalyptus-systems.com/yum/tags/euca2ools-3.2/centos/6/x86_64/"
      eucalyptus-repo: "http://packages.release.eucalyptus-systems.com/yum/tags/eucalyptus-4.1/centos/6/x86_64/"
      install-type: "packages"
      yum-options: "--nogpg"
      nc:
        max-cores: 32
      network:
        bridge-interface: br2
        bridged-nic: em2
        config-json:
          Mode: EDGE
          Clusters:
            -
              Name: one
              PrivateIps:
                - <IP_ADDRESS>-<IP_ADDRESS>
              Subnet:
                Gateway: <IP_ADDRESS>
                Name: <IP_ADDRESS>
                Netmask: <IP_ADDRESS>
                Subnet: <IP_ADDRESS>
          InstanceDnsServers:
            - <IP_ADDRESS>
          PublicIps:
            - <IP_ADDRESS>-<IP_ADDRESS>
        mode: EDGE
        nc-router: N
        private-interface: br2
        public-interface: em1
      topology:
        clc-1: <IP_ADDRESS>
        clusters:
          one:
            cc-1: <IP_ADDRESS>
            das-device: vg01
            nodes: <IP_ADDRESS>
            sc-1: <IP_ADDRESS>
            storage-backend: das
        user-facing:
        - <IP_ADDRESS>
        walrus: <IP_ADDRESS>
  description: 4.1 calyptos testing
  override_attributes: {}
  cookbook_versions: {}

validate step works fine. I go to provision and it hangs on the rsync steps then eventually times out:
[<IP_ADDRESS>] Executing task 'push_deployment_data'
rsyncing deployment data...

Fatal error: local() encountered an error (return code 23) while executing 'rsync --delete -pthrvz  --rsh='ssh  -p 22 -o StrictHostKeyChecking=no' ./ root@<IP_ADDRESS>:/root/root/'

Aborting.

Fatal error: One or more hosts failed while executing task 'push_deployment_data'

When I take a look at running the rsync command manually I get this:
http://fpaste.org/236927/35318957/
which is presumably why this fails.
Any ideas? :)

Running from root's home dir from the deployment system:
total 20
drwxr-xr-x 12 root root 4096 Jun 26 04:44 calyptos
drwxr-xr-x  7 root root 4096 Jun 26 04:46 chef-repo
drwxr-xr-x 12 root root 4096 Jun 25 04:52 eucalyptus-cookbook
-rw-r--r--  1 root root 1542 Jun 25 11:23 prc-edge.yml
dr-xr-x--- 11 root root 4096 Jun 25 05:06 root

@lwade are you running calyptos from the same system that is also part of the cloud ? I think if that is the case it might just keep recursively rsyncing the directory /root.

Nope, from a system outside and not used in the topology. Thought the same so tried both ways.
-----Original Message-----
From: "Deependra Singh Shekhawat"<EMAIL_ADDRESS>Sent: 27/06/2015 03:44
To: "eucalyptus/calyptos"<EMAIL_ADDRESS>Cc: "Lester Wade"<EMAIL_ADDRESS>Subject: Re: [calyptos] Deployment issue (#18)
@lwade are you running calyptos from the same system that is also part of the cloud ? I think if that is the case it might just keep recursively rsyncing the directory /root.
—
Reply to this email directly or view it on GitHub.

@lwade were you able to figure this one out? If not can i checkout the systems? If so, anything we can fix in the software?

I think https://github.com/eucalyptus/calyptos/issues/26
may be a dup of this issue?

After running through this a few times it appears that the reason why this step either a) takes too long or b) times out is that the rsync source directory could include files that aren't required.
This is an example:
rsync --delete -pthrvz  --rsh='ssh  -p 22 -o StrictHostKeyChecking=no' ./ root@<IP_ADDRESS>:/root/
A workaround that I use is to firstly create a new directory and cd into it.  Then run the calyptos lifecycle commands.
mkdir calyptos-deploy && cd $_ && calyptos validate -e  && calyptos prepare -e
This is the line which could be updated from './' to 'chef-repo eucalyptus-cookbook'
https://github.com/eucalyptus/calyptos/blob/master/calyptos/chefmanager.py#L186

Thanks @dmccue we will get on this one this week.


[txservice] Unit tests

Need to:

[x] unskip existing unit tests
[ ] bring coverage up to 70%

https://github.com/connext/nxtp/pull/106


move lines is broken w xstate stuff

[x] edit sketch cannot move more than once
[x] inital sketch move not updating code
[ ] Make vertex selection work again

https://github.com/KittyCAD/modeling-app/assets/1445228/a0380130-c3cb-4573-a7db-efdbc04d81f7

Re-opening because #850 still had some issues, namely vertex selection is a bit wonky.


upvote/downvote on comentaries not working

Bug located on live deploy and local deploy with last version of the code.

This is a duplicate of https://github.com/DemocracyEarth/sovereign/issues/35

Good catch @vicnicius, Thanks!
Check with @santisiri, he is doing some work regarding upvote/downvote. We need to implement some logic to add ID when user u/d to avoid duplication and do OR exclusive (is up OR is down, user can't do both)


Staking in paloma nest wallet

We want to implement staking in the paloma nest wallet
Designs: https://www.figma.com/file/ClniQyKFqN1hSpWizV5O4A/Paloma?type=design&node-id=6576%3A21222&mode=design&t=RNerQAf7X7ptho0Q-1
Done when

[ ] a third tab is added to the bottom nav and the icon is replaced for "assets" tab

[ ] the "assets" tab is updated and shows the staked amount

No need Paloma LightNode now does this.


GenericSpecializer: fix a crash with -cross-module-optimization

If a thunk needs to be generated for a partial_apply specialization, but the specialization doesn't have a body, bail.
rdar://107165121

@swift-ci smoke test

@swift-ci benchmark


Cypress tests for visual editor

This is a lot of work and I am not a cypress guru. Help highly appreciated.

Are there specific topics you need adressed.
Maybe i can contribute regarding e2e tests using cypress.

Yes, auto-testing the visual editor is probably one of the most important task, I started with it but no time right now. Help is much appreciated. Unfortunatley my cypress setup is broken since the last update.
In general these tests did help 2 or 3 times to find bugs, so not super efficient but still helpful :) My tests are not written very good, especially they advice to use special cypress classes to disconnect testing from layout-classes.
One thing is that I plan to migrate the backoffice to Vue and Tachyons CSS, because it is quite clunky right now. Not sure if that should be the first task and then writing tests to avoid doublicate work.

So i guess this is your - kind of - seeding data for testing setup?
https://github.com/typemill/typemill/blob/master/cypress/test01-system-setup.spec.js
I would prepare some md files using a php job, im not familiar with php build tools so much. This is kind of comparable to database-seeding. Typemills md files are the db in this case
Personally, i would try to disconnect classes completely from e2e testing.
you can use data-... attributes freely in the html space.
For example data-cy-section="test" and just select it with the querySelector('[data-cy-section="test"]')
This way - except for cases, where it removes data-attributes - you dont cross paths with any of your application logic.
Lately i've been highly busy but i see if i get your cy setup to work locally in the next few days.

yes, that is a good idea with the data-attribute!
Exactly, the cypress-folder contains the tests that I have written so far (not sure if that are the latest versions, I will check and update them). I use the mardkown-demo-content that ships with typemill, so I simply extract typemill, setup cypress in the typemill folder and run the tests. So my structure looks like this:
- typemill
  - cache
  - content
  - cypress
    - fixtures
    - integrations
      -> here are the test-files
    - plugins
    - screenshots
    - support
    - videos
  - cypress-examples
  - media
  - node_modules
  - plugins
  - settings
  - system
  - themes

@trendschau  just asking, why dont you keep the cypress folder structure as whole into the repository?

Locally I use a little php-script that creates a lightweight zip-folder without all development files from my development-folder, then it unpacks the zipped version in a separate test-folder and there I test that unpacked version with cypress. It ensures that the lightweight zip-version that I publish on the website is tested and runs correctly.
But you are totally right, I should at least add the whole "cypress" folder to the development version, I will change that.

I'll draft a pr (if I got the privileges) and start setting up some things. I can add that

@trendschau i fixed the cytests in this pr:
https://github.com/typemill/typemill/pull/312/files
you can try them out. just install cy global and have node 14.

@trendschau the second one #315 removes redundancy in the cy setup - and adds the possibility to add seeded settings, etc..
Whats the most important parts needed to be tested in your visual editor?

thank you very much for contributions, I will add cypress again later if I find more time. Actually autotests did not help too much with finding bugs, so I will add it if bugs become a problem again.


Productize Rails 4 and fix part of deprecations

Implements: https://github.com/Mixbook/product/issues/12411
Summary

Productize Rails 4.
Avoid deprecated calls of Model.all, substitute it with to_a.
Replace find_by_xxx with where(xxx: value).first.
Rewriting dynamic coniditons with lambdas ->
Remove empty scoped.

How do we make sure all code paths updated are tested?

Obviously the gem has no CI. The plan is to rely on mixbook_com CI after releasing the gem.
What I did locally is call certain parts of tagtical in bin/rails c making sure it works and the fix makes the deprecation go away


Is there any plan to mitigate the CVE: CVE-2023-50387 ?

Here is the NVD Link:
https://nvd.nist.gov/vuln/detail/CVE-2024-5389,

Hi @abi-jey, it's been fixed in the latest release 1.4.8


Getting all the roles and role definitions

How do I get all the roles and role definition using the python sdk? Something that is equivalent to Get-AzRoleAssignment and Get-AzRoleDefinition .
I tried searching for something that would give IAM policies but so far I couldn't find any documentation or examples/models that I can use.
Any guidance on this would be appreciated.

Hi @reach4bawer
You need azure-mgmt-authorization. This unittests file might give some guidance:
https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/authorization/azure-mgmt-authorization/tests/test_cli_mgmt_authorization.py
Thanks!

@lmazuel  How do I translate the principle ids to actual people/groups/services?

I found two articles that helped me - Link 1 and Link 2.


doc: Document Platform APIs and Platform Apps

Doc on platform apps and platform app permissible
script to add permissions for platform apps on objects
run the following in a rails console in your chatwoot installation
# replace the number 1 with appropriate ids for platform app and account
PlatformAppPermissible.create!(platform_app: PlatformApp.find(1), permissible: Account.find(1))

It has to do with how the API permissions in chatwoot work.

Platform APIs ( requires platform apps ): Used by installations admin to manage users and accounts. It could also be used to sync auth information from external systems into chatwoot.
The platform Apps will help you to use a single chatwoot installation as a conversation store for multiple applications, As account access is limited to the platform app that was used to create it.

Application APIs: Helpful to build integrations at an account level. examples, migrate canned response or contacts information of your organization from another platform. Build a customer conversation workflow etc.

ref: https://github.com/chatwoot/docs/pull/214#issuecomment-1055256304
https://github.com/chatwoot/docs/pull/214#issuecomment-1046588476

closing in favor of #237
also permissible is being deprecated ref: https://github.com/chatwoot/chatwoot/issues/5276


feat: Added codemods for migrating webpack from v4 to v5

This PR enhances the webpack v5 from v4 migration guide by incorporating codemod integration to streamline the upgrade process for developers. The motivation behind this change is to provide a more efficient and time-saving approach for migrating from v4 to v5, helping the community upgrade with ease.
Key changes include:

Introducing Codemods: Added a section in the migration guide to highlight the availability of codemods for automating common migration tasks.
Codemod Recipe: Provided a codemod recipe that runs the following codemods from the Sentry.js Codemod repository:npx codemod webpack/v5/migration-recipe

webpack/v5/set-target-to-false-and-update-plugins Registry Link
webpack/v5/migrate-library-target-to-library-object Registry Link
webpack/v5/json-imports-to-default-imports Registry Link

By incorporating these changes, the migration guide now provides a more comprehensive and efficient solution for upgrading to webpack v5, helping developers save time and effort during the migration process.

Thanks for the feedback! I've updated the documentation to clarify that the codemod is unofficial and may require additional manual steps for a complete migration.

Hi @snitin315 👋 Mohab from Codemod core team here.
We reviewed and adjusted this from our end as well. Please let me know if there are any changes you'd like to see. Cheers.

@mohab-sameh can you sign CLA?

@snitin315 Should I sign this personally in addition to the one signed by @alexbit-codemod on behalf of Codemod?

You can sign it personally

@snitin315 done. Ready to merge now.


Turn off notification sound on Android

Hi,
Several users of apps using the PushPlugin have requested the option to turn off notification sound (without necessarily turning off all sounds on the device)
Is there a way of determining whether or not Android devices play a sound when a push notification comes in and the app is in the background or not started?
RVO

Seems you can control sound, vibrate and lights by passing a value into a defaults parameter in the payload.
The defaults can be set to one of the constants here: http://developer.android.com/reference/android/app/Notification.html#DEFAULT_ALL
It only works with the constant value eg. 1 and not a constant name eg. DEFAULT_SOUND.
var payload = { defaults: 1 }

Thanks for the tip bostondv! Just tried it out and if you go with the 4 for the lights option that's as good as a mute on my Nexus 5. Just add it to the data portion
'{"data":{"title":"Shhhh!","message":"Keep it down","defaults":4}}


Component tree not supported

Version
6.0.0-beta.1
Browser and OS info
Chrome 84 / Windows 10
Steps to reproduce
Have a nuxt project
What is expected?
Devtools working correctly
What is actually happening?
An error appears "Component tree not supported" and devtools is unusable

Is there a way to downgrade vuedevtools?

Duplicate of #1235


beginning of Ruby testing (not completed)

@fakela: can you review this PR please?

The markdown links validation failed is fixed in https://github.com/mindee/devrel/pull/613


Remove the istio-remote chart and make it an istio chart values

As discussed in #11306
Another PR will be submitted to move subcharts back to istio release once this one is approved.

@ymesika: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ea67c2d5860187b8dd5af9ee8192a24c5b693ec7
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
ea67c2d5860187b8dd5af9ee8192a24c5b693ec7
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ea67c2d5860187b8dd5af9ee8192a24c5b693ec7
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
ea67c2d5860187b8dd5af9ee8192a24c5b693ec7
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ea67c2d5860187b8dd5af9ee8192a24c5b693ec7
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
ea67c2d5860187b8dd5af9ee8192a24c5b693ec7
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
b04010b4572fb71afba0bd740e7524eab5a0ef9f
link
/test istio-integ-k8s-tests

prow/istio-unit-tests.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-local-tests.sh
751f87b82400920084e9a1cb2bf03c2ae10c2a08
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-local-tests.sh
751f87b82400920084e9a1cb2bf03c2ae10c2a08
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
751f87b82400920084e9a1cb2bf03c2ae10c2a08
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-unit-tests

prow/istio-pilot-multicluster-e2e.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-local-tests.sh
751f87b82400920084e9a1cb2bf03c2ae10c2a08
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
751f87b82400920084e9a1cb2bf03c2ae10c2a08
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
751f87b82400920084e9a1cb2bf03c2ae10c2a08
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
586f4eb28e73a9524b2bc470bcaaa289698eb66f
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio_auth_sds_e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio-integ-k8s-tests

prow/e2e_pilotv2_auth_sds.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e_pilotv2_auth_sds.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio_auth_sds_e2e

prow/istio-pilot-multicluster-e2e.sh
d292b5046ddddef0ac1ff24e1b071a3453929b1e
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-unit-tests

prow/istio-integ-k8s-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests
retesting for MCP test failure that is now merged in master.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
4f4bb4bde2f95277fb367a28710898165d9da84a
link
/test istio-pilot-multicluster-e2e

prow/e2e-dashboard.sh
1f3b1af14e8ff48d2a18f348167bb2904100c86a
link
/test e2e-dashboard

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test e2e-dashboard

@sdake In addition to #11306?

@ymesika: PR needs rebase.

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
1f3b1af14e8ff48d2a18f348167bb2904100c86a
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
1f3b1af14e8ff48d2a18f348167bb2904100c86a
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-integ-local-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
1f3b1af14e8ff48d2a18f348167bb2904100c86a
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
1f3b1af14e8ff48d2a18f348167bb2904100c86a
link
/test istio-pilot-multicluster-e2e

prow/istio-unit-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-unit-tests

prow/istio-integ-local-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-integ-local-tests

prow/istio-integ-k8s-tests.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-integ-k8s-tests

prow/istio-presubmit.sh
e77b7a2c4097120c385527f219b9e873e26f1404
link
/test istio-presubmit

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
1f3b1af14e8ff48d2a18f348167bb2904100c86a
link
/test istio-pilot-multicluster-e2e

prow/istio-integ-k8s-tests.sh
15d9fe01953c171a438d918987f74b18aa5a7bf2
link
/test istio-integ-k8s-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ymesika: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-integ-k8s-tests.sh
15d9fe01953c171a438d918987f74b18aa5a7bf2
link
/test istio-integ-k8s-tests

prow/istio-pilot-multicluster-e2e.sh
15d9fe01953c171a438d918987f74b18aa5a7bf2
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: linsun, sdake, ymesika
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [linsun]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wenchenglu can we get this merged in 1.1?  fixes: #11306

#11306

@ymesika wasn't aware you had an issue open.  I linked this PR from the issue tracker.  Helpful to update the issue tracker on Friday or Monday so state of the issue is understood.
Cheers
-steve

@ymesika: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-pilot-multicluster-e2e.sh
b675c707b0f81bda7ff8221b6cf07d5e9dbfe6fe
link
/test istio-pilot-multicluster-e2e

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@costinm I am not completely familiar with the global configmap API - can you verify this particular comment: https://github.com/istio/istio/pull/11307/files#r253273859
otherwise PR looks good. 👍

/hold
Just placing hold for @costinm to review.  Feel free to remove it once he has given the configmap a look.
Cheers
-steve


Created static pages for developers

@rohitbind

Hi Suyash,
As discussed I need to close this PR without merging as we agreed on pulling the data through GraphQL and Google API directly as the Table Top doesn't look promising at present.
Lets work on the Developer page where we will be pulling data through GraphQL


Rename Search -> Data Connect in open implementations

Rebrand open-source implementations we control to Data Connect.

This has been resolved in the server-side reference implementation, but still remains an issue in the client library.


Update requirements for WWB

Move optimum-intel from master to release versions: optimum-intel>=1.19.0

build_jenkins


how to make mocha wait for db connection?

I would like to write a beforeEach handler that purges the database, like
beforeEach(function(done){
  mainapp.statusapp.Users._withCollection(function(err, collection){
    if(err) done(err);
    collection.remove({}, done);
  })
});

I connect to my server asyncronouosly at the beginning of server.js
var db = new Db({
  name: 'test',
  host: '<IP_ADDRESS>',
  port: 27017
});
db.on('database', function(status){
  var error = status == 'open' ? null : status;
  if (error) throw 'Could not connect to database';
  else {
    statusapp.Users.fetch({
      error: function(err) {
        throw 'Could not fetch users';
      },
      success: function(results) {
        console.log('Initial fetch success');
      }
    });
  }
})

unfortunately, the tests don't wait for this connection to happen, and putting the test inside a db.on handler did not solve the issue as simply my tests were not recognised at all, and the script finished
how can I make mocha (actually in general javascript code) to wait to start some task?

database drivers IMO should buffer queries until connected (most do), otherwise they are unmanageable, as illustrated with this issue

unfortunately this does not solve my problem :(
my connector is based on node-mongodb-native, now my question is whether the underlying driver is misimplemented, thus buffer queries are not supported, or my connector does something nasty

I've received a solution on the node-mongodb-native list: https://groups.google.com/group/node-mongodb-native/browse_thread/thread/1b992ee55b7a007d


ip2tor - no /none port

I just ran into the situation that the host I was requesting a bridge from ran out of ports.
I think we need to address this on both the server (for now I just added 10k additional ports) and client side.
Here is the message on the RaspiBlitz side:

OK your service is ready & your subscription is active.

You payed 50 sats for the first 24 hours.
Next AUTOMATED PAYMENTS will be 48 sats each.

Your service 'CUSTOM' should now publicly be reachable under:
<IP_ADDRESS>:None

Please test now if the service is performing as promised.
If not - dont forget to cancel the subscription under:
MAIN MENU > Manage Subscriptions > My Subscriptions

Trying to access this (to cancel) also fails after that:
Traceback (most recent call last):
  File "/home/admin/config.scripts/blitz.subscriptions.py", line 164, in <module>
    mySubscriptions()
  File "/home/admin/config.scripts/blitz.subscriptions.py", line 112, in mySubscriptions
    publicaddress="{0}:{1}".format(selectedSub['ip'],selectedSub['port']),
KeyError: 'port'
Starting the main menu ..

Will add a check if that value is a number and if not raising an Error.


feat: remove useless command prints to export standard output to file

[x] remove useless output prints to allow to print stdout to file
[x] change argument output to option on reference and references-index
[x] rename references-index to references:index
[x] change template-path to template
[x] migrate mdx template to md (clean templates)

Apart from now missing guide template, LGTM, thanks !


[Research] Auto-updating app

I believe Electron supports it, so we ought to provide it.

https://github.com/electron/electron/blob/master/docs/api/auto-updater.md

@kauffj
On Tuesday we decided I would look into this. My findings:

It's just an interface to Squirrel, which is popular and well supported.
It appears that on Mac it's supposed to work out of the box.
The explanations for Windows are more vague, but it sounds like it may depend on using one of the standard Electron Windows installer packages. I think I remember us having some scary home-brew installer for Windows? I'll bring it up at the meeting tomorrow.
As to Linux, I see no way to do it, even with third party packages. Users are supposed to just configure their package manager to do auto updates. So it seems like we'll have to continue with the current system on Linux.
There are several release servers that support Squirrel. The appropriate one for us is probably nuts, because it's designed to do releases automatically off of a GitHub repo. It will require some configuration to tell it how our releases are tagged, and/or us changing how they're tagged, but otherwise theoretically it should work pretty much out of the box.

... so @alexliebowitz want to do this for Win + Mac? :grinning:

I'll bite!

@kauffj are we still seeking a windev or does this cover it?

Do I need to find a windev?

@finer9 no

Related: https://github.com/lbryio/lbry-app/issues/298

@alexliebowitz @lyoshenka will this PR fix https://github.com/lbryio/lbry-app/issues/298 ?

possibly.
for one, i don't know the standard way of making sure there's only one daemon process running at a time. in linux there are pidfiles and pgrep. idk how windows does it.
once we figure that out, we need to make sure the daemon is stopped before the update starts.


Requiring --unstable breaks recursive invocations

If you happen to add an unstable feature like !include to your justfile, now all your recursive invocations are broken because they fail without --unstable. This seems suboptimal. Proposal: allow JUST_UNSTABLE=true to be set in the environment instead.
Related: https://github.com/casey/just/issues/1430

To get around this I name my justfiles this.justfile. In my common.justfile I have the recipe:
[private]
generate-unstable-justfile:
  #!/usr/bin/env bash
  set -euxo pipefail
  echo -n > justfile
  for recipe in $(just --justfile this.justfile --unstable --summary); do
    echo "@$recipe:" >> justfile
    echo "  just --justfile this.justfile --unstable $recipe" >> justfile
  done

I have a pre-commit hook that will run
just --justfile path/to/common.justfile  --working-directory path/containing/this.justfile generate-unstable-justfile

honestly working around the limitations feels like make again and it's somehow refreshing 😅

Rewrote this in python to handle arguments properly:
#!/usr/bin/env python3
import subprocess
from argparse import ArgumentParser, FileType

def format_arg(arg: str) -> str:
    if arg[:1] == "+":
        arg = f"*{arg[1:]}"
    return arg.split("=")[0]

def format_var(var: str) -> str:
    return f"{{{{{var.lstrip('+*').split('=')[0]}}}}}"

def main():
    parser = ArgumentParser()
    parser.add_argument("src", help="source justfile", type=FileType("r"))

    args = parser.parse_args()

    lines = [
        x.strip()
        for x in subprocess.run(
            ["just", "--justfile", args.src.name, "--unstable", "--list"],
            check=True,
            capture_output=True,
        )
        .stdout.decode("utf-8")
        .splitlines()
        if x != "Available recipes:"
    ]

    print("# AUTO GENERATED. DO NOT EDIT.")

    for line in lines:
        parts = line.split()
        recipe = parts.pop(0)
        print(f"@{' '.join([recipe]+[format_arg(x) for x in parts])}:")
        print(
            "  {{just_executable()}}",
            "--justfile",
            args.src.name,
            "--unstable",
            recipe,
            *[format_var(x) for x in parts],
        )

if __name__ == "__main__":
    try:
        main()
    except subprocess.CalledProcessError as e:
        print(e.stderr)
        raise e

should be run in the directory you want the destination justfile to live, ie:
python3 -u script.py relative/path/to/unstable.justfile > justfile

@sgtsquiggs I have purely just workaround using dump for the !includes issue, I've posted it in: Issue 1641
Not sure if it fills the same need as your Python script.

A workaround is now available, you can set the JUST_UNSTABLE environment variable, which will be available to recursive invocations of just.


feat: Added analytics events for admin settings updates

Description
This PR adds analytics events for admin settings update events
Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Manually

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

/ok-to-test sha=81818d75f7f2bf99652b8bcdf84f58a44263d2dd

/ok-to-test sha=7a80cffb1eaaf85551f990f7486961a78fec2430


CLOUDP-274986: Update OAS security validation for global security

Proposed changes
Changes to the linting for setting the OAS security as a global configuration. Only unauthenticated endpoints will have security set on the endpoint level, as an empty security requirement.

New validation that if security is set, it's empty
Removed previous validation that all endpoints have security set

Since current OAS will violate the new linting, I'll comment out the v2 lint step for now and reintroduce it after the next release when the new OAS is updated.
Jira ticket: CLOUDP-274986
Checklist

[x] I have signed the MongoDB CLA
[x] I have added tests that prove my fix is effective or that my feature works

@blva Thanks! Commented out the v2 step in the workflow for now, will reintroduce after next release
I'll update the README in a separate PR for some more detailed guidance on the process

just chatted /w @lovisaberggren that even commenting this will still make other release validations fail as we'll use the new spec in this repo so it's best to revert and wait cc @matt-condon who approved


[Airflow] [IntervalCheck] Presto Interval Check op

This is an implementation of the PrestoIntervalCheck operator similar to
the one in the internal data-eng library at Airbnb. This operator will
allow to test if variations are within bounds over a period of time
on a week over week or YoY basis.
@mistercrunch

@mistercrunch Tested.

Superbe!


⚠ Bofrost.de has degraded performance

In 8f1e3d9, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1332 ms

Resolved: Bofrost.de performance has improved in c7e23e7 after 22 minutes.


Dockerized Build

Hey guys
I don't know if you are interested in this change and want to merge it or not... but since the Service Cutter build requires some outdated tools (such as Java 8 or Node 8) I find it useful to have it dockerized, so that anyone can build and run the tool (anyone who has Docker installed :). Because many probably don't work with Java 8 anymore and don't want to install it just to run such an application.
With this change it is possible to build and run the complete application with one command: (in the root of the repo)
docker-compose up

You already had Dockerfile's but it was necessary to run the Maven build first to build the applications (which is only possible with the outdated tools locally installed).
If you want, you can merge the change to ease the process of getting the application running for users... or let me know if I should improve something before you merge it ;) Or don't merge it at all... :)
Best regards,
Stefan

PS: I also changed the travis file, since oraclejdk8 is no longer available. I further changed the POM of the engine so that the girvan-newman is taken from here: https://repo.clojars.org/com/servicecutter/clustering/gephi/girvan-newman/0.8.6/ (published the binary so that users don't have to setup the git submodule and install the project locally).

Thanks for you work! I'll hopefully find the time to have a look at it this weekend.

Thanks for the PR! I just merged it with tiny adjustments.


style: commitlint

Coverage remained the same at 97.067% when pulling 4ad139d002f47095e5b69e4abdb540c15e43995f on commitlint into 66396d482aa7e68125f14ce0dd1c82bde2bce0a5 on master.


Update Dependency Declarations

When I install onto_tool into a fresh python environment, pyshacl is not being installed automatically. I assume this is because it is missing from setup.py.
While adding in pyshacl, double check that both setup.py and requirements.txt have not discrepencies.

TODO:

Check if pytest-cov should be included in tests_require in setup.py.
Check if version specs (e.g. >=) need to match between setup.py install_requires and requirements.txt.

@bpelakh What do you think about changing requirements.txt to
-e .

as suggested in https://caremad.io/posts/2013/07/setup-vs-requirement/?
Note: I removed --index-url https://pypi.python.org/simple/ from the author's example because it was mainly illustrative and I believe it is not necessary since we would be pulling from PyPi anyways.

@bpelakh According to https://pip.pypa.io/en/latest/reference/build-system/, setup.py is the legacy interface. Should we move to  pyproject.toml?

Fixed bug with the following code change: https://github.com/semanticarts/ontology-toolkit/commit/7c4a46069ffd42e8390b558a791370180b03cffb


How to reproduce your work?

Thank you for sharing the source code as well as datasets.
I followed your instruction and stuck at the step of 3.ii.
The error is
No such file or directory: 'data/FB15k-237/literals/numerical_literals.npy'
There is only a numerical_literals.txt file at this folder.
I tried to load from txt file and then convert it to numpy array.
But got an error at the "Normalize numerical literals"
I think your numerical_literals.npy might different from the txt file in this repository.
Could you please let me know how to reproduce your experiments?
Phuc

Hey
before step 3.ii) please prepare the numerical literal data as follows:
'python preprocess_num_lit.py --dataset FB15k'
This will create *.npy file
Asif

Hi Asif,
Thank you for your response.
There is only one file numerical_literals.npy created after the command.
I still get another error of missing file of
No such file or directory: 'data/FB15k-237/literals/text_literals.npy'
Phuc

Hey,
For text features we use GloVe embeddings from Spacy. You could use any pretrained text embeddings and save it as a .npy file. Here is an example script to use Spacy:
`import numpy as np
import argparse
import pandas as pd
from pathlib import Path
import spacy
import unicodedata
parser = argparse.ArgumentParser(
description='Create literals'
)
parser.add_argument('--dataset', default='YAGO3-10', metavar='',
help='which dataset in {YAGO3-10, FB15k, FB15k-237} to be used? (default: YAGO3-10)')
args = parser.parse_args()
Load vocab
vocab = np.load(f'{str(Path.home())}/.data/{args.dataset}/vocab_e1')
ent2idx = vocab[0]
idx2ent = vocab[1]
df = pd.read_csv(f'data/{args.dataset}/literals/text_literals.txt', header=None, sep='\t')
nlp = spacy.load('en')
features = np.zeros([len(idx2ent), 384])
i = 0
for ent, txt in zip(df[0].values, df[1].values):
vec = nlp(txt).vector
idx = ent2idx[unicodedata.normalize('NFC', ent)]
features[idx, :] = vec
Save features
print('Saving text features of size {}'.format(features.shape))
np.save(f'data/{args.dataset}/literals/text_literals.npy', features)`

Dear MdAsifKhan,
Thank you for your answer,
I runned your sharing code but there are two error:

Which spacy model of English is used? There are 6 models on there web site: https://spacy.io/models/en, but it seems that the embedding dimension for a word is around 300 (not 384 in your code).

I changed the dimension to the correct one. Then, I got another problem of getting incorrect id index of this line of code.
idx = ent2idx[unicodedata.normalize('NFC', ent)]

It seems there are some people whose got the same issues like me. (Other issues)
Could you please check your code and update your instruction on how to reproduce your work on Readme file?
Thank you very much.
Best
Phuc

Hi @phucty,
sorry for very late reply. We have updated the README and put together the missing pieces. Now, our code should be straightforward to run. Please try it out and let us know whether it works for you now.


chore: Update Golong 1.20 -> 1.22

Reason for Change:
Update go 1.20->1.22

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.12%. Comparing base (fde6369) to head (eb2349d).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #361      +/-   ##
==========================================
- Coverage   62.89%   59.12%   -3.77%
==========================================
  Files          14       24      +10
  Lines        1307     1720     +413
==========================================
+ Hits          822     1017     +195
- Misses        447      643     +196
- Partials       38       60      +22

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


[CLOSED] Unable to build base

 Issue by bollu
Monday Apr 23, 2018 at 13:05 GMT
Originally opened as https://github.com/antalsz/hs-to-coq/issues/84

Hello,
I'm trying to build base following the instructions here. However, make -C base fails with:
╭─bollu@cantordust ~/work/hs-to-coq  ‹master*›
╰─$ make -C base
make: Entering directory '/home/bollu/work/hs-to-coq/base'
make --no-print-directory -f "Makefile" pre-all
if [ "8.7.2" != "8.7.2" ]; then\
  echo "W: This Makefile was generated by Coq 8.7.2";\
  echo "W: while the current Coq version is 8.7.2";\
fi
make --no-print-directory -f "Makefile" real-all
"coqc"   -q  -Q .   GHC/DeferredFix.v
coqc: too few arguments
Usage: coqc <options> <Coq options> file...

options are:
  -verbose  compile verbosely
  -image f  specify an alternative executable for Coq
  -opt      run the native-code version of Coq
  -byte     run the bytecode version of Coq
  -t        keep temporary files

Coq options are:
  -I dir                 look for ML files in dir
  -include dir           (idem)
  -R dir coqdir          recursively map physical dir to logical coqdir
  -Q dir coqdir          map physical dir to logical coqdir
  -top coqdir            set the toplevel name to be coqdir instead of Top
  -coqlib dir            set the coq standard library directory
  -exclude-dir f         exclude subdirectories named f for option -R

  -noinit                start without loading the Init library
  -nois                  (idem)
  -compat X.Y            provides compatibility support for Coq version X.Y

  -load-ml-object f      load ML object file f
  -load-ml-source f      load ML file f
  -load-vernac-source f  load Coq file f.v (Load f.)
  -l f                   (idem)
  -load-vernac-source-verbose f  load Coq file f.v (Load Verbose f.)
  -lv f	                 (idem)
  -load-vernac-object f  load Coq object file f.vo
  -require path          load Coq library path and import it (Require Import path.)
  -compile f.v           compile Coq file f.v (implies -batch)
  -compile-verbose f.v   verbosely compile Coq file f.v (implies -batch)
  -o f.vo                use f.vo as the output file name
  -quick                 quickly compile .v files to .vio files (skip proofs)
  -schedule-vio2vo j f1..fn   run up to j instances of Coq to turn each fi.vio
                         into fi.vo
  -schedule-vio-checking j f1..fn   run up to j instances of Coq to check all
                         proofs in each fi.vio

  -where                 print Coq's standard library location and exit
  -config, --config      print Coq's configuration information and exit
  -v, --version          print Coq version and exit
  -print-version         print Coq version in easy to parse format and exit
  -list-tags             print highlight color tags known by Coq and exit

  -quiet                 unset display of extra information (implies -w "-all")
  -w (w1,..,wn)          configure display of warnings
  -color (yes|no|auto)   configure color output

  -q                     skip loading of rcfile
  -init-file f           set the rcfile to f
  -batch                 batch mode (exits just after arguments parsing)
  -boot                  boot mode (implies -q and -batch)
  -bt                    print backtraces (requires configure debug flag)
  -debug                 debug mode (implies -bt)
  -stm-debug             STM debug mode (will trace every transaction)
  -emacs                 tells Coq it is executed under Emacs
  -noglob                do not dump globalizations
  -dump-glob f           dump globalizations in file f (to be used by coqdoc)
  -with-geoproof (yes|no) to (de)activate special functions for Geoproof within Coqide (default is yes)
  -impredicative-set     set sort Set impredicative
  -indices-matter        levels of indices (and nonuniform parameters) contribute to the level of inductives
  -type-in-type          disable universe consistency checking
  -xml                   export XML files either to the hierarchy rooted in
                         the directory $COQ_XML_LIBRARY_ROOT (if set) or to
                         stdout (if unset)
  -time                  display the time taken by each command
  -profile-ltac          display the time taken by each (sub)tactic
  -m, --memory           display total heap size at program exit
                         (use environment variable
                          OCAML_GC_STATS="/tmp/gclog.txt"
                          for full Gc stats dump)
  -native-compiler       precompile files for the native_compute machinery
  -h, -help, --help      print this list of options
Makefile:645: recipe for target 'GHC/DeferredFix.vo' failed
make[1]: *** [GHC/DeferredFix.vo] Error 1
Makefile:318: recipe for target 'all' failed
make: *** [all] Error 2
make: Leaving directory '/home/bollu/work/hs-to-coq/base'

I turned on the verbose option, and the failing command is:
"coqc"   -q  -Q .   GHC/DeferredFix.v
From what I can tell, this is not how -Q is supposed to be used? coq --help says:
  -Q dir coqdir          map physical dir to logical coqdir

but here, just one directory (.) is being passed. What's going on?
The -Q option appears to be generated from Makefile.conf, with
# Makefile.conf
COQMF_COQLIBS =  -Q .
COQMF_COQLIBS_NOML = -Q .

versions of assorted tools
coqc
╭─bollu@cantordust ~/work/hs-to-coq/base  ‹master*›
╰─$ coqc --version
The Coq Proof Assistant, version 8.7.2 (April 2018)
compiled on Apr 23 2018 18:00:37 with OCaml 4.05.0

GHC
╭─bollu@cantordust ~/work/hs-to-coq/base  ‹master*›
╰─$ ghc --version
The Glorious Glasgow Haskell Compilation System, version 8.5.20171221

stack
╭─bollu@cantordust ~/work/hs-to-coq/base  ‹master*›
╰─$ stack --version                                                                                1 ↵
Version 1.6.1, Git revision f25811329bbc40b0c21053a8160c56f923e1201b (5435 commits) x86_64 hpack-0.20.0

Any help appreciated :)

 Comment by nomeata
Monday Apr 23, 2018 at 14:14 GMT

What is your operating system and default shell?

 Comment by nomeata
Monday Apr 23, 2018 at 14:16 GMT

The Makefile.conf should contain
COQMF_COQLIBS =  -Q . ''
COQMF_COQLIBS_NOML = -Q . ''

(note the second argument).
Do you have a fresh check-out? Maybe you created Makefile.conf some weeks ago with Coq 8.7.1, which was buggy?

 Comment by bollu
Monday Apr 23, 2018 at 15:14 GMT

Ah, no, it was not a fresh check-out. Yes, it is possible I had created the Makefile.conf with Coq 8.7.1. Thanks :)
For future reference, how do I regenerate the Makefile.conf correctly?
Also, feel free to close the issue.

 Comment by nomeata
Monday Apr 23, 2018 at 15:41 GMT

Delete it, and run make :-)


Caching

Provide multiple DNS caching servers like Acrylic DNS Proxy does.

I'm not familiar with Acrylic DNS Proxy.
Can you clarify?

Here it is.
https://mayakron.altervista.org/wikibase/show.php?id=AcrylicFAQ

Thanks for spotting this website with completely obsolete information regarding DNSCrypt.
Since this is apparently a wiki, maybe you can directly update these information?
If not, since you are familiar with this project, can you tell the wiki maintainers what has to be updated (at least the website and instructions for dnscrypt-proxy 2.x)?
Thanks for your help!

Huh? Does dnscrypt support multiple dns servers for caching or not?

Yes, of course. Did you miss the configuration section in the documentation?
So, can you help with updating the DNSCrypt section on the link you posted? Thanks!

So, can you help with updating the DNSCrypt section on the link you posted? Thanks!

Any progress on this?

@joeparkerz Ping. https://mayakron.altervista.org/wikibase/show.php?id=AcrylicFAQ still has outdated information. Can you try to have it updated?


Change tilemap API

Change the text of the API
set Tile at row col
Don't use the set block for tile map.

Fixed by https://github.com/microsoft/pxt-common-packages/pull/1037


Will future carla use pybind11 as Python API?

Hi,
Carla is a great work!
Carla uses boost.python as python api, and there is another python-c++ api pybind11. As far as I know, pybind11 is more pure and simple, while boost.python needs whole boost lib to be installed. So I want to know will carla use pybind11 as your python api inthe future?
Best regards!

Using pybind11 to refactor python-c++ api also can provide typing information using  mypy. This would make carla more self documenting.  It is realy an important feature for user that using modern IDEs like VSCode, Pycharm.

Hi,
When I have some time I may look into whether pybind would degrade performance.
Are you asking because you want to have type info or because compiling boost is too slow?
If it's the second the current build system rework should significantly lessen this problem.
Marcel


Redesign: Animation Dropdown

Context
Building off #6505 which redesigns the animation panel to refactor the custom effect dropdown to use shared materials in design system.
Summary
Guts the custom dropdown we were using for animation effects. Should look like this: https://www.figma.com/file/bMhG3KyrJF8vIAODgmbeqT/Design-System?node-id=221%3A13978
Relevant Technical Choices

Moved files that create effect dropdown into their own subdirectory - /animation was getting too big.
Restructured effect data into background and foreground objects that we can use to map through to create our dropdown options and still have access to all the custom values that each animation needs to preview and be selected.
Renamed some props internal to the dropDown's Menu to quiet some eslint warnings. Fix prop for dropDownHeight so that it can be overwritten.

To-do

There's a side convo happening about how to handle the scrollbar in this dropdown since the designs don't account for it.

User-facing changes
Should look the same as in #6505
except i shrank some of the fonts a bit to avoid crowding and flipped the foreground dropdown to open up to give it more room.
https://user-images.githubusercontent.com/10720454/112236399-994ed800-8bfd-11eb-9295-c07e9b5cf2ba.mp4
https://user-images.githubusercontent.com/10720454/112236400-99e76e80-8bfd-11eb-95d7-cdfd5b6532f6.mp4
Testing Instructions
Verify that selecting animation effects has no regression:

Select a foreground element, apply different animations to it with the dropDown. See that dropDown works with both cursor and keyboard.
Select background image, apply different animations to it with the dropDown. See that effects are disabled with a tooltip telling you why in some cases.

QA

[ ] This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

UAT

[x] UAT should use the same steps as above.

This PR can be tested by following these steps:

Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist

[x] This PR addresses an existing issue and I have linked this PR to it in ZenHub
[x] I have tested this code to the best of my abilities
[x] I have verified accessibility to the best of my abilities (docs)
[x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
[ ] This PR contains automated tests (unit, integration, and/or e2e) to verify the code works as intended (docs)
[x] I have added documentation where necessary
[x] I have added a matching Type: XYZ label to the PR

Fixes #6827

@miina when you're done reviewing will you also add consent?

Added the consent! Sorry, I was planning to review today but things got in the way -- will do it first thing in the morning.

when you're done reviewing will you also add consent?

Added the consent! Sorry, I was planning to review today but things got in the way -- will do it first thing in the morning.

know the feeling! no hurry ✨

Just a note, in Firefox it looks a bit off-center:
Chrome

Firefox

Might be related to scrollbar?

Might be related to scrollbar?

Indeed! this is absolutely scrollbar related (what's funny is, it's fine in firefox for me - we must have different scrollbar settings on our systems). I know Sam is still thinking through what to do with this.

(this has a few tests failing,  will fix on monday)


No output with n_beams=1

There are no PSMs recorded in the output mztab file when decoding is done with a single beam. The model seemed to be decoding garbage peptides (e.g. ending in the dummy token) that it ended up not caching at all. More details to come.

one-beam.tgz
Here is a zipped tar file containing a minimal example.  The runall script runs the decoding twice, once using one beam and one using five.  As you can see from the included mztab files, there is no output in the single-beam case.  Note that the example uses the most recent version of Casanovo (6299bd2), and it requires a ckpt file compatible with that. The script has a hard-coded pointer to such a file, which is too big to upload here.

I've identified the problem to be this line which masks out all tokens when n_beams=1 and behaves correctly otherwise.
This is a strange bug but I think it has to do with einops.repeat() operating on the view of the tensor rather then a copy here.  Adding, .clone() to this line solves the issue but I wonder if @bittremieux any recommendations for a more efficient solution.
Otherwise, I'll implement that and set up a unit test for single beam decoding.

I don't think einops preferring views is the problem here. repeat generates a tensor that is bigger than the input (i.e. by repeating dimensions), so by definition this can't be a view of the original tensor. So I remain a bit confused about this issue.
Are you sure that beams > 1 then actually works correctly? Maybe it returns beams - 1 beams instead, but because that's more than zero, it still gives results and the bug is undiagnosed.

beams > 1 works as intended with the correct number of beams returned.
You can find the simplest version of the weird behavior with tensor slicing after repeat in the below snippet and attached snapshot of output.

First cell shows correct behavior with beams=2 , i.e. dummy token at zero indices are masked out.
Second cell shows buggy behavior with beams=1, i.e. all tokens are masked out instead of just the dummy token at the zero index.
Third cell shows how clone() for repeated tensor get the correct behavior for beams=1.

import einops
import torch

beam=2
vocab=29
test_tensor = einops.repeat(torch.tensor([False,False]), "(B S) -> B (V S)", S=beam, V=vocab)
print(test_tensor)
test_tensor[:, :beam] = True
print(test_tensor)

Thanks for digging deeper and the MWE. After playing a bit with the code, I'm now convinced that you're completely right: the issue is indeed that einops.repeat returns a view, and using clone is the appropriate fix.