[bug] giveItemToPokemon | exceptions

[Problem]
giveItemToPokemon() not working for:

Escape Rope
Coin Capsule

[Description]
Kaito recently alerted me, about not being able to give his pokemon a coin capsule. I myself verified his statement using escape ropes. Testing script was this:

function onPathAction()
giveItemToPokemon("Escape Rope", 1)
end

[Test: Behaviour | Comment]

item = "Escape Rope" via GameClient: successful | so it is indeed possible
item = "Escape Rope": no action took place: | but no exception either = item recognized

[11:20:36] Script "" by "" successfully loaded
[11:20:36] Bot stopped

item = "EscapeRope": exception | tried some name variations

[11:21:02] Bot started
[11:21:02] error: giveItemToPokemon: tried to give the non-existing item 'EscapeRope'.

item = "Leppa Berry": successful
... (more common items)

[Ideas]

Incorrect spelling in proShine?
Exceptions both have a space - might that cause an issue?
Missing items on a HoldableItemsList or something? Giving a pkm an escape rope never crossed my mind before. So maybe others might not thought about it as well.

What is the Scope of the escape rope?
The scope is checked in the GameClient class to make sure we do not equip an impossible item:
https://github.com/Silv3rPRO/proshine/blob/master/PROProtocol/GameClient.cs#L723

Just checked, it sais Escape Rope's ScopeID is 8. Seems unlisted in the method you posted.
As for Cain Capsule - I can't provide that information


Faiss-GPU module commented out in the requirements.txt and can't be downloaded via pip.

I am trying to run the sample_training.sh, firstly I was greeted with the --log online error in the code, which I removed from the sample_training.sh file. After which running the sample_training.sh produces the error "AttributeError: module 'faiss' has no attribute 'GpuIndexFlatL2'. Did you mean: 'IndexFlatL2'?"
I saw that an issue had been opened on this before and the solution was to uninstall both faiss-cpu and faiss-gpu and install faiss-gpu.
However, the faiss-gpu is commented out in the requirements.txt file and pip says that no suitable version was found.

Hi,
I faced the same error. Uninstalling both faiss-cpu and faiss-gpu and then reinstalling faiss-gpu worked for me.
If it still did not work for you: I'm not sure this will solve your problem, but this is how I created a working environment:

install python==3.8
install from requirements.txt (you could uncomment faiss-gpu and move it in front of faiss-cpu, although i did not test if this solves the problem)
install timm, ipykernel
unintall faiss-gpu and faiss-cpu
install faiss-gpu

@AhmedHamadto
You can install it from here instead
https://github.com/facebookresearch/faiss/blob/main/INSTALL.md

I faced the same error, I downgraded my python from 3.12 to 3.10 and it worked fine.


Resolving the deprecation warning - active_support.test_order

This was the warning before my change:
DEPRECATION WARNING: You did not specify a value for the configuration option `active_support.test_order`. In Rails 5, the default value of this option will change from `:sorted` to `:random`.
To disable this warning and keep the current behavior, you can add the following line to your `config/environments/test.rb`:

  Rails.application.configure do
    config.active_support.test_order = :sorted
  end

Alternatively, you can opt into the future behavior by setting this option to `:random`. (called from test_order at /Users/adomokos/Programming/Ruby/oss/rails-api/vendor/bundle/ruby/2.0.0/gems/activesupport-4.2.1/lib/active_support/test_case.rb:42)

This is now resolved.

The build failure is with Ruby edge and 2.2, the same as the master branch.


Update dependencies, mainly namespace for AutoFixture 4

@alexfoxgill The namespace changed for AutoFixture 4 since Mark Seemann is no longer maintaining it. Let me know if you'd like this broken out differently and I'd be happy to resubmit.

Thanks for the PR! This repo is no longer actively maintained (I'll add something in the readme to that effect) but I'll see if I can push out a NuGet version update when I have access to a windows machine

@alexfoxgill Thanks for the quick merge. I'd be interested in taking over maintenance, I have a pretty strong use case for it.

@dbroudy i just tried to transfer the repo to you but can't because your fork already exists - if you delete your fork i can transfer it. if you can give me your nuget username i will add you to the package for that too

repo and nuget transferred - thanks for taking it on

No problem. Thanks for creating it. I'll push out a release with these latest PRs shortly.


Uncaught Exception: Attempting to call a function in a renderer window that has been closed or released. Function provid

An uncaught exception was reported.
Info:
OS: win32
Arch: ia32
GPMDP Version: 3.0.1
Time: Sun Mar 27 2016 14:42:45 GMT-0400 (Eastern Summer Time)
Error:
Attempting to call a function in a renderer window that has been closed or released. Function provid
Error: Attempting to call a function in a renderer window that has been closed or released. Function provided here: Object.<anonymous> (C:\Users\Zain Quraishi\AppData\Local\GPMDP_3\app-3.0.1\resources\app\build\inject\GPMInject\interface\mouseButtonNavigation.js:8:8.
    at BrowserWindow.callIntoRenderer (C:\Users\Zain Quraishi\AppData\Local\GPMDP_3\app-3.0.1\resources\atom.asar\browser\lib\rpc-server.js:201:19)
    at emitTwo (events.js:92:20)
    at BrowserWindow.emit (events.js:172:7)

This issue was created automatically inside the uncaughtException handler

Closing this automatically reported issue as a duplicate of #470


fix code comment

Please answer these questions before submitting pull request

Why submit this pull request?
[x] Bug fix
[ ] New feature provided
[ ] Improve performance

LGTM.

LGTM.

LGTM.

Seeing Good catch reminds me of LGTM.


Inspector popup is blank

Describe the bug
The Inspector popup is blank on any record after fresh install
To Reproduce
Steps to reproduce the behavior:

Install Extension
Go to Salesforce org
Go on any record page and click inspector arrow
See error

Expected behavior
See inspector tools
Screenshots

Desktop (please complete the following information):

OS: Windows
Browser Chrome
Version 114.0.5735.199

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Hi @svcostin6,
Have you tried to clear cache / uninstall re-install the extension ?

Hi,
Yes, tried restart, uninstall and reinstall. empty cache. Also tried different salesforce orgs.
Thanks

Hi,
Yes, tried restart, uninstall and reinstall. empty cache. Also tried different salesforce orgs.
Thanks

Have you disabled the legacy version in 1.14 ?

yes, uninstalled it

ok. looks like the issue is caused by the Third Party Cookie setting


Infinite sales channel compile time

PHP Version
8.2.22
Shopware Version
<IP_ADDRESS>
Plugin Version
3.3.3
Actual behaviour
Some sales channels don't compile the theme and instead just hang up, displaying the message
Compiling theme for sales channel for : _SALES_CHANNEL_ID_
indefinitely.
Other sales channel compile just fine. The problem always occurs with the same sale channels. If I disable BunnyCDN for the theme system, but keep it enable for media all saleschannels compile just fine.
Expected behaviour
The theme compiles in a reasonable amount of time for all sales channels.
Steps to Reproduce?
I am unsure how this problem can be reproduced. Not all of our sales channels are having this problem, and the problem occurs even if no other plugins are enabled. The problem does not seem to occur on a default dockware installation. The problem occurs both if I use bin/console theme:compile to compile all themes and when I use bin/console theme:compile -o _SALES_CHANNEL_ID_ to only compile the sales channel, which don't compile.

Hi @SimonBKohlschein
this is no issue by this plugin, but with the system of theme in shopware.
Theme compilations are transferring huge number of files which will always takes some time.
I recommend not transferring theme to external storage.

Hi @tinect,
the issue did not exist previously. While in the past, theme compiling with bunnycdn took 2–5 minutes (as opposed to 2–5 seconds without bunnycdn), now some sales channel have not finished compiling after an hour, while others still have a compile time of 2–5 minutes. Checking the file size of theme folder locally, it does not seem like it is bigger than before.
I am not sure if this problem started after a Shopware update or a bunnycdn plugin update, as I had theme transferring disabled for like a month, to speed up compile times.

It will have been worsen with an update, while shopware creates more files.
It is not the size of files, but the count of files. Could you please compare them?
Additionally, shopware saves a files with information of transferred files to speed it up afterwards.
it seems impossible to detect any speed or performance issue in this plugin while it just uses given APIs: Shopware and bunny.

The problem seems to occur both on Shopware <IP_ADDRESS> and <IP_ADDRESS> (we are currently testing switching to 6.6). With Shopware 6.6 there are more theme files due to the discontinuation of all.js, but with Shopware 6.5 with all plugins disabled there are actually fewer files in the theme folder than with the last known working Shopware instance backup with bunnycdn themes enabled.
Where can I find the "file with information of transferred files to speed it up"?
I don't think that this is a slowdown of the theme compilation. I think it is some kind of endless loop.

Currently, I am away from keyboard, so it is hard to find it for you. I recommend you to debug the theme compilation and asset installation.


chore(repo) - removed dist and doc

for #166
removed dist and doc directories and added them to .gitignore
this comes from discussions about not committing updated dist files since they're generated. and not removing them fore the sake of a very dirty diff.  if we do this in one place, we can keep the dirty diff all in one place

As I said. If they are in gitignore they are not included in the release. Just don't add them in your commit please

ah.  misinterpreted that.  surely there's a way to fix that aside from checkout than all the time, but not super important


Auto updatable github extension

Makes the extension on our github site support automatic updating.  The github version could be considered our nightly build.
If you missed the IRC conversation the plan is the last version number will get incremented every time we merge, but it will be how many merges from a certain commit.  So each time we want to bump the middle version number we'll update the EXTENSION_BASE_VERSION variable to reset the third version number.
To support AMO we now build two extensions, one with the updateUrl and one without.
I also did some cleaning and moved all the extension building into the "build" folder, so build clean actually wipes out stuff.
PS My Makefile knowledge isn't comprehensive so if I violated some known best practices let me know.

+1 from me

LGTM, let's merge it and take it for a spin.


HTML display errors

Description
Every time I'm directed to  this site, I see this error message:HTML conversions sometimes display errors due to content that did not convert correctly from the source. This paper uses the following packages that are not yet supported by the HTML conversion tool. Feedback on these issues are not necessary
(Optional:) Please add any files, screenshots, or other information here.

(Required) What is this issue most closely related to? Select one.
Choose One
Internal issue ID
047b700b-81c6-456b-bed5-f814d3576846
Paper URL
https://arxiv.org/html/2403.07815v1
Browser
Chrome/<IP_ADDRESS>
Device Type
Desktop

Yes, this is intended behavior for the current experimental stage of HTML papers.
Thank you for writing in!


weird behavior when should set global

Should can't be used when set global in node, example:
describe("test suite", function() {

    it("this works", function() {

        var should = require("should");

        should(null).eql(null);

    });

    it("why does this throw an error?", function() {

        global.should = require("should");

        should(null).eql(null);

    });

});

the trhown error is: "TypeError: Property 'should' of object # is not a function"

Because shouldjs extends Object.prototype. But global is also object, so you call in object global getter should.
To make it really global, you can try use Object.defineProperty:
Object.defineProperty(global, 'should', {
value: should
})

or you can set it at first require of shouldjs
global.should = require('should').noConflict();
should.extend();

your solutions work, thanks for the quick answer :).
although since should extends the  Object prototype if i set "should" directly on global, js should first
check on the object itself and then on its prototype when searching for the property "should",
am I wrong ?

Yes, right with values. But 'should' is a getter without setter, that is why you cannot change it directly.

thanks for the explanation, I'll lok into it


Next.js 12 successful deploy throws error 500 because of next/dist/server/next-server. TypeError: handler is not a function

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.
[X] I have removed any sensitive information from my code snippets and submission.

App Id
deuq5sef8ny5q
AWS Region
us-east-2
Amplify Hosting feature
SSR
Describe the bug
The app throws error 500 with internal server error message in browser. The logs show TypeError: handler is not a function which is clear indication of next/dist/server/next-server not handling the request right.
The app works well on any other environments even on localhost i am able to run it after yarn build and yarn start
Expected behavior
After a successful deployment the app should be running without errors on the domain
Reproduction steps

Set up the Amplify app setting to WEB_COMPUTE via the "Migrate" banner action (it shows Next.js - SSR now)
Setup "next": "^12.3.4",
output: 'standalone' set up in next.config.js
project with a few pages, one page has getServerSideProps

Build Settings
version: 1
backend:
  phases:
    build:
      commands:
        - '# Execute Amplify CLI with the helper script'
        - amplifyPush --simple
frontend:
  phases:
    preBuild:
      commands:
        - yarn install
    build:
      commands:
        - yarn run build
  artifacts:
    baseDirectory: .next
    files:
      - '**/*'
  cache:
    paths:
      - node_modules/**/*

Log output

# Put your logs below this line

2023-03-13T01:51:46.334+02:00 | START RequestId: 34ee75d5-2370-455b-8606-284fdf338888 Version: $LATEST
  | 2023-03-13T01:51:46.334+02:00 | info - Loaded env from /tmp/app/.env.production
  | 2023-03-13T01:51:46.347+02:00 | TypeError: handler is not a function
  | 2023-03-13T01:51:46.347+02:00 | at Server.<anonymous> (/tmp/app/server.js:19:11)
  | 2023-03-13T01:51:46.347+02:00 | at Server.emit (node:events:513:28)
  | 2023-03-13T01:51:46.347+02:00 | at parserOnIncoming (node:_http_server:998:12)
  | 2023-03-13T01:51:46.347+02:00 | at HTTPParser.parserOnHeadersComplete (node:_http_common:128:17)
  | 2023-03-13T01:51:46.351+02:00 | REPORT RequestId: 34ee75d5-2370-455b-8606-284fdf338888 Duration: 17.37 ms Billed Duration: 18 ms Memory Size: 1024 MB Max Memory Used: 120 MB Init Duration: 634.63 ms

Additional information
No response

Hi @alexcracea 👋 , thanks for reaching out to us and we apologize for the delayed response on this thread.
It seems that you have deleted the Amplify app deuq5sef8ny5q. Are you still running into the 5xx Internal server error on your Next.js Compute app? If yes, can you please share the updated/new Amplify App ID?


Error when typing an opening bracket

From<EMAIL_ADDRESS>on 2014-11-25T02:55:30Z
When typing an opening bracket after an existing function name, the following error is thrown:
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/spyderlib/widgets/editor.py", line 461, in show_object_info
at_position=position)
File "/usr/local/lib/python2.7/dist-packages/spyderlib/widgets/mixins.py", line 108, in show_calltip
self.calltip_widget.show_tip(point, tiptext, wrapped_textlines)
File "/usr/local/lib/python2.7/dist-packages/spyderlib/widgets/calltip.py", line 157, in show_tip
forward=False)
File "/usr/local/lib/python2.7/dist-packages/spyderlib/widgets/calltip.py", line 252, in _find_parenthesis
while category(char) != 'Cc' and position > 0:
TypeError: need a single Unicode character as parameter
What steps will reproduce the problem?

Simply typing eg. "max("

What is the expected output? What do you see instead?
The object inspector should give information about the functions and a calltip window should appear. Instead, the error is thrown and nothing happens. The closing bracket is automatically added though. What version of the product are you using? On what operating system? Spyderlib is version 2.3.1 and I'm running Ubuntu 12.04 LTS.
Please provide any additional information below
. This problem started appearing when I upgraded from spyderlib 2.1.x to the current version. I have tried locally implementing revision 76f249aa2ab3 (as suggested in issue #1961 ), but without avail. Some testing suggests that crash occurs on the first evaluation of the while-expression in calltip.py, line 252, and never even enters the loop.
Original issue: http://code.google.com/p/spyderlib/issues/detail?id=2065

From ccordoba12 on 2014-11-25T08:45:13Z
What do you have in line 249 of calltip.py? It should be this https://bitbucket.org/spyder-ide/spyderlib/src/1489769116ffa475d23ce84bc9a5830a692bab5a/spyderlib/widgets/calltip.py?at=default#cl-249
Labels: MS-v2.3.3

From ccordoba12 on 2014-11-26T05:19:46Z
Yes, please wait until 2.3.2. Else I'll fix it for 2.3.3

From<EMAIL_ADDRESS>on 2014-11-25T23:10:38Z
That is what I have there too.
I found a related issue ( issue #1989 ) in which roughly the same problems that I'm experiencing are described. Maybe it's fixed already and I should just wait untill the next release?

From ccordoba12 on 2015-01-09T17:48:22Z
Closing because of lack of response
Status: WontFix


Does Kingfisher support content mode of UIImageView?

Kingfisher seems to ignore the content mode of UIImageView.
For example, if I set the content mode of a UIImageView to aspect fill (via storyboard),
however, Kingfisher ignores the content mode and renders the image as aspect fit.
Does anybody know this kind of problem?

Hey,
It should not happen since Kingfisher will not change the content mode of an image view. By default, Kingfisher just get the image from either cache or web, then call imageView.image = image underhood.
Are you using any image processor to resize or crop the image, which might need you to specify a content mode. And it would be great if you could attach some code snippet you are using or even better to build a sample project in which this issue could be reproduced.
Thanks!

@onevcat
Thank you for your reply : )
I see your point. This might be my fault...
I'm not using any image processor.
I'll recheck my code.

I am having the exact same problem.

Thanks for the report.
Umm, but it's weird. I tried the demo project under this repo and everything seems fine to me. The images are square and the (collection) cell is a tall rectangle. I got these results:
Aspect Fit

Aspect Fill

Scale to Fill

And all of them are expected.
@Dmurph24 Can you confirm that you are calling the image setting method in main thread? Or can you build a sample project in which this issue could be reproduced?

@onevcat yes, I will confirm with you soon. Definitely seems to be working in your example.


Icons missing from tool bar

The Fold All and Unfold All icons are blank in the tool-bar.  This happened after an update was received.  I am not sure if the update was for this package or a different one.

I'm pretty sure this was when tool-bar updated to using Font Awesome 5.4.2 in v1.1.11 (https://github.com/suda/tool-bar/pull/249)
I'll try and get a fix out today

Thanks.

All fixed, package should be updated to Font Awesome 5

Some of the tool-bar icons are missing again.  I manually changed them in my settings so that I had some icons but I'm unsure what the defaults are supposed to be just wanted to let you know it is happening


DOC: None vs explicit defaults in functions

Over in #7738 I noticed that the default freqz(..., worN=None) and related functions (sosfreqz and freqz_zpk) under the hood all effectively do:
if worN is None:
    worN = 512

I wanted to change this to freqz(..., worN=512) in the function signature (still allowing worN=None to be used equivalently in the code for backward compatibility), but @WarrenWeckesser disagreed:

I think worN=None is preferable. Suppose I write a function that calls freqz, and I want my function to have a worN argument that is passed on to freqz. If freqz gives the default in the signature, I have to copy that default to my function's signature. Leaving the argument as worN=None makes my life simpler. Using worN=None also maintains consistency with freqz_zpk and sosfreqz.

My argument against this is that it can be made about any argument that has a non-None default. In other words, I think that taking this position as a reason to use None instead of 512 leads us to have to something like "there should never be explicit non-None defaults", which doesn't make sense to me. Such non-None defaults (where possible) are especially useful e.g. when using introspection or even immediately looking at the doc, as it reduces burden.￼
It seems like we should standardize on this, so I'm curious what others think. Should I post to the mailing list instead / too?

I like explicit defaults like freqz(..., worN=512) because they provide a more informative signature, and avoids having to look up the information.
None as default is better, IMO, if

the default changes depending on another keyword, method/algorithm
the default is mutable
(in statsmodels) In a few cases we use None to indicate that the default is not yet stable, e.g. if we implement a better method/algorithm in future, then the default will/can change.

What about explicit defaults with None support? That is:
def foo(n=5):
    if n is None:
        n = 5
    # ... etc ...

It's not super clean, but it have the advantages of both options.

It's not super clean, but it does have the advantages of both options.

It also has the disadvantage that if we want to use None in the future for the sort of thing @josef-pkt advocates (some triaging based on other args, for example), we lose that possibility. That is unfortunate because I see None used a lot in the Python ecosystem for those examples @josef-pkt cited. For the specific example I mentioned (freqz), I think we should allow None in this way because it's backward-compatible, but I don't like it as a basic principle.
Thinking about it more, unless all defaults are None in a given package (or None is supported everywhere), when writing code that wraps functions and uses defaults, you're still going to have to look to see if the default is None before using it as the default in your code, at which point you might as well use the effective non-None default.

I think there is also a signal of intent: a default value of None signals that a specific way the function turns this default into a numeric value is an implementation detail, not unlike an _underscored_attribute of a class.

@WarrenWeckesser it sounds like there is at least some agreement that explicitly setting the kwarg values (e.g., worN=512) while still supporting None as a "use default" wrapper is reasonable. Is that okay with you? Ideally we could make a decision on how to move forward with this soon because in #8397 we need to decide whether to follow the old None pattern or not.

Is this related? https://graysonkoonce.com/always-use-none-for-default-args-in-python/

It seems to make the (extreme) argument that None should be the only default ever used, yes. I disagree for the reasons already outlined above.

The typical exaggerated posts about programming :) The defaults can help if the numbers and settings come seemingly out of the blue sky. worN is a good example or window type in FFT related functions.
None makes sense if there is no extras involved, say, there is a computation is being done and you want to add some extra weights via weights=None keyword. Not having weights is the default option and it makes sense to have None but if there is always a default value is used, None is not a good API choice.

None but if there is always a default value is used, None is not a good API choice.

It is a good choice if you find it likely that the same default value
has to be used in many methods.

It is a good choice if you find it likely that the same default value has to be used in many methods.

I can perhaps see why supporting None as a wrapper for "use the default" could help in this case, but I don't see why you'd want to actually set it to None in the signature. What is the advantage?

... I guess that if you change it one place, then you have to change it in all of them?
I guess in this case the proposed rule be something like "use None in the signature if it's something that will be used a lot". We have such variables in scipy.linalg, so should we change all the check_finite, overwrite_a, etc. to be None?

I think booleans are immune to this type of discussion simply because they are like mechanical switches. You either want them or not independently.
One of the classical weird API is matlab's pwelch function signature. It's just a big mess with defaults and options are garbled together resulting with an unusable choice mayhem.

In this case a clean default list, such as bodeoptions, would have been really helpful but now every option affects the other keyword which was I think what @josef-pkt was mentioning at the beginning.

I think booleans are immune to this type of discussion simply because they are like mechanical switches. You either want them or not independently.

I'm not so sure. The arguments for and against setting kwargs to None above for the worN int (original conflict) holds equivalently for ints or strings, and I would argue also for bool. All are immutable and can be changed / passed / dealt with with equal difficulty under the default-to-None and default-to-non-None schemes. The fact that bool only takes on two values instead of many more doesn't seem to affect the tradeoffs.

In this case a clean default list, such as bodeoptions, would have been really helpful but now every option affects the other keyword

In very complex input cases like what I think you're describing, this sounds like the category @josef-pkt mentioned:

the default changes depending on another keyword, method/algorithm

And then later @ev-br:

a default value of None signals that a specific way the function turns this default into a numeric value is an implementation detail

And I agree with this (and actually @josef-pkt's guideline altogether). But the worN-like case here does not fall into those categories AFAICT.

I guess that if you change it one place, then you have to change it in all of them

I think this should be at most relevant in internal or library functions, i.e. where only "experts" use it.
The main argument against None and **kwargs for coding convenience is that code is written once (or a few times), but read and used much more often.
related to @ilayn
a statsmodels example for conditional keywords that I think turned out pretty well
http://www.statsmodels.org/devel/generated/statsmodels.regression.linear_model.OLS.fit.html
cov_type chooses a method for computing the standard errors
cov_kwds is a dict that contains the required and optional keywords. It is None, because what are valid and required keys depends on the cov_type
use_t is an extra boolean option, but the default depends also on cov_type.
(and cheating a bit: **kwargs is also used for development so I can add additional hidden options until they get an official api.)
The only disadvantage is that users have to look for the docstring for the cov_kwds, and we loose the documentation advantage of explicit keywords and defaults. (But the helper function hides everything in kwargs because there are too many possible combinations of keywords http://www.statsmodels.org/devel/generated/statsmodels.regression.linear_model.OLSResults.get_robustcov_results.html )
related to @ev-br

a default value of None signals that a specific way the function turns this default into a numeric value is an implementation detail, not unlike an _underscored_attribute of a class.

I think this has to made explicit in the docstring and should only apply in special cases.
i.e. if None means something like "automatically do the best", then what's currently the best implemented way might change.
In other cases None should have a specific meaning that is subject to backwards compatibility constraints.

I've been reviewing my use of default values in my own projects, and I see a mix of None and explicit constants.  So I can't say that I follow my own suggestion 100%.  If most other folks are OK with using explicit constants, I can go along with that.

Thanks for looking into it @WarrenWeckesser. It looks like there is a general consensus that in general we should aim for explicit arguments where reasonable to do so. If others read the discussion differently, let me know.
So for scipy.signal we should safely be able swap in the explicit arguments and treat None as a convenience wrapper, I think. I'll mark this as a good first issue because it should be pretty straightforward how to accomplish this.


Add API documentation

Hello. May I ask if you are you still willing to make documentation? I would like to contribute - if possible - as i found this library to be very useful

@astatio 😄 Sure! Welcome PR, you can always improve the README and the doc in the code.


added :classname to db spec

Hi @maruks
Thank you very much for this patch. The classname parameter was removed in previous version because is a old and deprecated way to load drivers as far as I know. Can you give any justification about the need of classname parameter.
I have accepted it because is really little change and it can live in the code, but I would like some reasons about the need to have this parameter.


Update Twilio SDK version

Besides updating the SDK version, I also removed the v1 when calling the Sync API. I tested it locally and its working, but I don't know if this should actually be done.
Also, the v1 is still on the notify calls, so maybe I should remove it there too?

I think this is right, I used as reference the generated sample code: https://github.com/twilio/sample-code/blob/master/sync/v1/service/fetch-default/fetch-default.5.x.rb but still needs confirmation.

Hey @po5i, I removed the v1 from notify as well, as I was taking a look at the samples here.


Pretty Printing of objects

I have found it very useful to print out the result of a rough sort_by() or filter_by operation before narrowing in on a selection algorithm. To aid in that, I would like if printing shapes like Edges and Faces would offer some more useful insights then the standard:
<build123d.topology.Edge object at 0x000001CCE09F2810>

Something like:
Edge - CIRCLE of radius=12.5 at (5, 5, 22)
Edge - LINE of length=50 at (1, 5, 12)

A basic implementation can be achieved like this:
  def __str__(self):
    pos = self.center()
    type = self.geom_type()
    dim = ""
    if type == "CIRCLE":
       dim = f"radius={self.radius}"
     ....
     return f"Edge - {type} of {dim} at {pos}"

A more abstract solution might use a template to build the string

This would be a lot of work and is likely inferior to just using a viewer to show the selected object as follows:
b = Box(1, 1, 1)
top_points = b.vertices().group_by(Axis.Z)[-1]
show(b, top_points, alphas=(0.1, 1))

or
b = Box(1,1,1)
vertices = b.vertices().group_by(Axis.Z)[-1]
c = Pos(2,0,0) * Cylinder(0.5, 1)
edges = c.edges().group_by(Axis.Z)[0]

show(vertices, edges, show_parent=True)

I agree that seeing the feature is more intuitive, in the moment. However, my point is that in order to build a reliable selector query, it would be useful to "see" the "features" of the things you are trying to filter. Sorted lists are especially unreliable, so i tend to use a lambda as such:
        latch_edges = adj.edges().filter_by(
            lambda e: e.geom_type() == "BSPLINE"
            and int(e.center().Z) < -self.height / 2 + 8
            and int(e.center().Z) > -self.height / 2 - 8
            and e.center().X < self.od / 2 + 1
        )

I am not sure I agree with "This would be a lot of work...".
I am happy to do proof of concept for Edge. Can you see any negatives of having this feature? If people don't use it, you won't hear about. Its not depended on by any other feature. If people like it, they might want it replicated on other types.

Why I describe this as "a lot of work" is that there are many different types of Edges.  In OpenCascade the TopoDS classes (which are basis for the build123d Shape classes) are built from lower level Geom set of classes which are trimmed.  So a circular arc at the TopoDS_Edge level is a Geom_Circle with start/end points (i.e. trimmed). So if the intention is to describe the underlying shape all of the following need to be addressed:

GeomAbs_Line,
GeomAbs_Circle,
GeomAbs_Ellipse,
GeomAbs_Hyperbola,
GeomAbs_Parabola,
GeomAbs_BezierCurve,
GeomAbs_BSplineCurve,
GeomAbs_OffsetCurve, and
GeomAbs_OtherCurve,

The same is true of Faces, etc. so in my mind this all adds up to "a lot of work".  I'm not saying there is no value just that on the scale of value for effort I would place this quite low.
With respect to the filter_by selector you've constructed (which is fine) - are you aware that filter_by(GeomType.BSPLINE) and filter_by_position(Axis.Z,-self.height/2-8,-self.height/2+8) exist?  lambda's are great for those that are comfortable with them but I know many newer programmers (and some very experienced programmers) don't like them. They are described in the docs (https://build123d.readthedocs.io/en/latest/key_concepts.html#custom-sorting-and-filtering) for folks as they are very powerful and convenient for selectors that can't be done with the standard ones.


Update GettingStarted.md

There are two different 'things' named handleSubmit in this example.
First one is a custom handler defined on ContactPage component, whereas second one is name of property injected by reduxForm hoc.
This may cause confusion, especially due to structure of this example:
<ContactForm onSubmit={this.handleSubmit} /> is only slightly different then <ContactForm handleSubmit={this.handleSubmit} />.
My proposal is to change name of custom handler method from handleSubmit to submit.

Codecov Report

Merging #2695 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2695   +/-   ##
======================================
  Coverage     100%    100%
======================================
  Files          67      67
  Lines        1380    1380
======================================
  Hits         1380    1380

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc03b5...6305527. Read the comment docs.

Sure. Seems okay.


Register>UserType>Infobox too big and missing formatting

[ ] The size is so big it does not fit on the screen
[ ] Bullet points are not shown as such and miss the bullet

Champion
Ninja
...

[ ] Bullet points should be ordered so that they have the most impact

Ninja - They do not read so much
Mentor - I do not know about the rest but this would be my suggestion
Parent
Champion

Solutions

A solution could be to reformat the box.
Another solution uses the free space on the right below the Log-In and the info box redirects to it.

Thanks for the report !
We'll be starting a cleaning spring sprint starting next week (https://github.com/CoderDojo/community-platform/issues/962), and a couple of rethinking of the codebase. One of the decision made was to simplify the registration usertype as it was bringing too many errors(codebase wise)/misunderstanding ( user wise). This way, only "Ninja/Adult" will be left during registration.
Hence, this information will not be displayed during registration, but when joining a dojo, and in a different way ( very probably a popup with N cards, N being the possible "roles" (Ninja/Parent/Mentor/Champion) ), every bulletpoint will probably being reused there as a description per card.
That should let us with an easier codebase to maintain and easier to use for the users :)
Otherwise, I don't have the mockups right now to verify the order of the cards, but I would probably put parents before mentors; and kids shouldn't have this display to choose a role anymore as their role should be defined by their age ;p

@DanielBrierton to close? We don't use those usertype on registration

@Wardormeur Sounds good to me!


[AST] Convert ASTContext::getSwiftName to a free function

The only state getSwiftName uses is its argument, and can be made a free function. Of note the inverse operation, getKnownFoundationEntity, is also a free function. This removes the requirement that callers have an ASTContext instance.
(cherry-picked from commit fb524c0b865659cd81af31241667abf808677006)

@swift-ci test Windows Platform

@swift-ci test Windows Platform


fix(sfu): remove race condition for session & peer

Description
After network disruption, client may restart signaling  (either JSON RPC or gRPC Web over WebSocket) with the same uid. It is possible that new AddPeer is called before RemovePeer in the exiting goroutine that delete the newly created one.
This fix also prevents duplicated NewSession in race condition. Also fixes GetSessions that the returned map is not thread-safe.
Note: PeerLocal lifetime is tied to the signaling goroutine, so client needs to restart RTCPeerConnection when WebSocket connection is closed. In the future, it will be nice to decouple PeerLocal lifetime from signaling if RTCPeerConnection is still alive after network disruption.

GetSessions() is currently broken, map iteration would panic in race. Cloning map is more expensive than slice. Hope to hear feedback from the maintainers. Thanks

@adwpc please check if the signature change breaks ION, this is the correct way to get the session since maps share the same inner references so is not thread safe.

LGTM，seems not break

Added 1 more commit for minor tweak of mutex for Subscriber.DataChannel and AudioObserver.
Note: There are 2 identical method for get datachannel, and AddDataChannel vs AddDatachannel. I understand it is not a good idea to change public API of ion-sfu. But maybe rename AddDatachannel (lowercase c) method to InitDatachannel to reduce confusion in next version of API?

@adwpc @OrlandoCo Would you please take a look if PR looks good to you? Thanks


troubleshooting-kubeadm: add guide for fixing stale CoreDNS pods

fixes kubernetes/kubeadm#998
/assign @chrisohaver
/assign @Bradamant3
@kubernetes/sig-cluster-lifecycle-pr-reviews
preview:
https://deploy-preview-9872--kubernetes-io-master-staging.netlify.com/docs/setup/independent/troubleshooting-kubeadm/#coredns-pods-have-crashloopbackoff-or-error-state

@Bradamant3 updated.

@kubernetes/sig-cluster-lifecycle-pr-reviews if someone can lgtm this for technical accuracy, we'll get it merged, thanks.
/approve for doc review

Should we make note of versions of docker that we know work (and/or cause problems).
For example, version 1.13 has this problem, where as 17.03 does not.
Or do we want to steer clear of naming specific versions.

LGTM - Perhaps we should indicate that the first option is recommended.

@chrisohaver

Should we make note of versions of docker that we know work (and/or cause problems).
For example, version 1.13 has this problem, where as 17.03 does not.

the linked guide recommends 17.03 and hopefully later version don't have the problem too.

LGTM - Perhaps we should indicate that the first option is recommended.

well. there are 3 options, two of them are marked with a warning. so with the process of elimination the first one is the recommended one. isn't that sufficient?

OK - lgtm

made small update to turn Disable SELinux into an external link.


Out of disk space on machine running deis-builder

1 machine from the cluster (the one where deis-builder is running) runs out of space very quickly.
We've figured out that it's deis-builder-data that dramatically eats space. And it grows fast with each deploy because deis-builder doesn't seem to fully clean the intermediate containers.
The solution right now is to stop deis-builder, remove deis-builder-data container with its volume (-v option) and run deis-builder again:
# Log into the machine that is running deis-builder and:
deisctl stop builder
docker rm -v deis-builder-data
deisctl start builder

ref #1678

Which kind of app deployments are you running in the builder? I know that application images will get cleaned up, but if you're using a Dockerfile approach and your app relies on another image (i.e. FROM ubuntu:14.04), that parent image won't get cleaned up.
Instead of cleaning up just the app image after a run, maybe we can clean up all images except for the few containers that we require in the build process like slugbuilder, slugrunner and cedarish. This has the downside of making all git push deployments slower because you'll always have to pull the parent image, so there's a tradeoff there.

Any outside chance could be caused by heroku-buildpack-nodejs caches? @cray0000

@bacongobbler yes, we use Dockerfile and there is a FROM base image.
The parent image can be pretty big, the one we use right now is about 300M for example, so downloading it each time is not a perfect solution but definetly one we should consider.
I wonder if it's possible to auto/manually push parent image into deis-registry to be used on some stage of the build process, and tell Docker to use that registry to find image first, and if it wasn't found there then fall back to the public registry. This will make downloading much faster thanks to the local network bandwith and there won't be any downsides of cleaning the whole deis-builder each time.

From #3209:

Running and pushing many different updates to a Deis environment can add up to a lot of Docker images. I have no reason for keep ALL Docker images for an app along the way.

It would be nice if we could add a config var like DIMAGE_CNT=3 that would force the builder to always remove any Docker images for an application that are not the most recent 3 images.

The goal is to prevent 100 different images from accumulating that haven't been used in weeks and are just consuming disk space.

In my case I don't seem to have issues with intermediate images not being cleaned up,  it its purely from an archival issue for the final image for each build.  I am using a fork of a Heroku Buildpack for NodeJs for our builds.   We can run upwards of 20+ builds a day,  with these old images hanging around we are having to manually purge the older ones pretty frequently to keep from running out of disk.

ah, so you're having to purge old images from the hosts? We have documentation around that, though it'd be nice for the scheduler to remove the image when the process is killed.

You hit it on the head.   Yeah I have no problem purging the images manually,  your docs were great for helping out with that. It would just be nice if we could set a ENV_VAR for the app and the builder would do its thing and push the most recent image to the registry,  then purge any older than X.

Okay. Sorry for the premature close! Let's track that back in #3209

@cray0000 @mastephens Are we okay closing this, given that we have documentation around cleaning up old images and are tracking the automatic removal in #3209?

@carmstrong yep,  as long as #3209 stays open.  This is a completely different issue in my opinion.

This is a completely different issue in my opinion.

:+1:


Possible Bug in Code for put_RiskRating()

The code for the get_RiskRating() and put_RiskRating() methods may be erroneous. Both involve the management of the "RiskRating" member of the CLoan class which I assume is a BSTR. While it could be that "RiskRating" is an instance of a BSTR management class which performs automatic BSTR memory allocation/deallocation, this is not clear from the sample code.

In get_RiskRating(), "pVal", being an "out" parameter, should be given a copy of "RiskRating" instead of simply being assigned to point to "RiskRating".

Hence I recommend that get_RiskRating() be re-written as follows :

STDMETHODIMP CLoan::get_RiskRating(BSTR* pVal)
{
	if (RiskRating != NULL)
	{
		// Make a copy of RiskRating and assign the copy
		// to the BSTR pointed to by pVal.
		*pVal = ::SysAllocString((const OLECHAR*)RiskRating);
	}
	else
	{
		*pVal = NULL;
	}

	return S_OK;
}

In put_RiskRating(), "RiskRating" is directly assigned "newVal" without first being freed. Furthermore, "RiskRating" should be made a copy of the newVal parameter instead of being assigned to newVal.

I recommend that put_RiskRating() be modified as follows :

STDMETHODIMP CLoan::put_RiskRating(BSTR newVal)
{
	// Note : must free the BSTR First.
	if (RiskRating != NULL)
	{
		::SysFreeString(RiskRating);
	}

        // And then make a copy of newVal.
	RiskRating = SysAllocString((const OLECHAR*)newVal);

	return S_OK;
}

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61ad12a5-1104-88ec-483c-f60966bade67
Version Independent ID: 10b5b082-672a-e255-9d2c-300a7edf344f
Content: COM Interop Sample: .NET Client and COM Server
Content Source: docs/framework/interop/com-interop-sample-net-client-and-com-server.md
Product: dotnet-framework
GitHub Login: @rpetrusha
Microsoft Alias: ronpet

Thanks for writing these @limbioliong
I like your suggestion. You've specified what should change with enough detail that I've added the "up for grabs" label in case a community member wants to address it.
We'll address this when we next update this article.


pod install [!] Error installing SentryReactNative

OS:

[ ]  Windows
[X]  MacOS
[ ]  Linux

Platform:

[X]  iOS
[ ]  Android

Output of node -v && npm -v && npm ls --prod --depth=0
v10.15.0
6.5.0
<EMAIL_ADDRESS>/Users/user/Desktop/app
├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>├── UNMET PEER DEPENDENCY<EMAIL_ADDRESS>├──<EMAIL_ADDRESS>└──<EMAIL_ADDRESS>
npm ERR! peer dep missing<EMAIL_ADDRESS>required by<EMAIL_ADDRESS>npm ERR! peer dep missing<EMAIL_ADDRESS>|| ^3.0.2, required by<EMAIL_ADDRESS>npm ERR! extraneous<EMAIL_ADDRESS>/Users/user/Desktop/app/node_modules/apollo-link-state/node_modules/apollo-link
npm ERR! invalid<EMAIL_ADDRESS>/Users/user/Desktop/app/node_modules/@sentry/wizard/node_modules/xcode
npm ERR! extraneous<EMAIL_ADDRESS>/Users/user/Desktop/app/node_modules/@sentry/wizard/node_modules/uuid

Config:
<EMAIL_ADDRESS>{
....
}).install()

I have following issue:
I get an error "Could not find remote branch v0.41.1 to clone." when I use Pods, because package.json version - 0.41.1 and last version in repo - 0.39.1.
I fixed it at myself by installing version 0.39.1 in the package.json
Steps to reproduce:

yarn add react-native-sentry
add to Podfile -> pod 'SentryReactNative', :podspec => '../node_modules/react-native-sentry/SentryReactNative.podspec'
pod install

Actual result:
[!] Error installing SentryReactNative
[!] /usr/bin/git clone https://github.com/getsentry/react-native-sentry.git /var/folders/vy/wpz782fx7pj_d3qtfdwnbhgw0000gn/T/d20190211-80488-e0n69x --template= --single-branch --depth 1 --branch v0.41.1

Cloning into '/var/folders/vy/wpz782fx7pj_d3qtfdwnbhgw0000gn/T/d20190211-80488-e0n69x'...
warning: Could not find remote branch v0.41.1 to clone.
fatal: Remote branch v0.41.1 not found in upstream origin

Expected result:

Success

Hmm it's because the latest few release tags were without v so it's just 0.41.1 instead of v0.41.1.
I wonder where this is coming from.

OK, found it, created a PR to fix this.

Hmm it's because the latest few release tags were without v so it's just 0.41.1 instead of v0.41.1.
I wonder where this is coming from.

I think this may be due to updating cocoapods. It began to demand v where it was not before


add title_bar.inactive_background styles

#25

Hey @tecandrew,
can you give me a hand with this formatting issue I'm having? I just tried adding titlebar inactive color, but for some reason I couldn't get neither zed nor vscode to respect editorconfig. This PR should have been 8 lines instead of entire files instead of 3k+.

@tepavcevic on zed try disabling format on save on the config file "format_on_save": "off" or just add it using vim or nano if it's just one line

@tepavcevic we don't modify the generated JSON files directly since we also generate all accent flavors in each release for those who would like to override the default "mauve" accent

added blur, but I'm not sure it works on Linux yet. it may on MacOS?
slight transparency seems to look OK :smile:

Thanks for the tip @AlvaroParker.
@tecandrew I wasn't familiar with how setting up the theme goes, I'm glad you were eager to jump in and help.
I tested it on linux and it looks really nice


Dashboard monitoring

research

how to collect errors / warnings ?
how to send them to operations? should be integrated with what we have e.g promethus, grafana
what data should we collect?
what needs user's consent?
should be opt-out by default

related #1469

we are using Sentry now I believe it covers all the mentioned points


jump to an unexpected return address, unexpected instruction address_misaligned exception occurs

gen_opts:
+instr_cnt=10000
+boot_mode=s
+enable_page_table_exception=1
+disable_compressed_instr=1
+directed_instr_0=riscv_load_store_rand_instr_stream,4
... (several directed load/store stream)
in a generated test, firstly, a load page fault exception occurs. And the exception handler firstly fix pte and decide to run some kernel program before exiting from exception handling.   j_smode -> smode_program. In smode_program_stack_p，store the gp register to stack. After smode program finishes, jump to gp. However, the gp is never updated after init (0xaf654e2a). jump instruction triggers instruction address misaligned exception.

Can you upload the log and generated assembly test for debugging? Thanks
For page table, are you using SV32 or SV39?

The +enable_page_table_exception knob is not stable as I have seen a similar issue during randomization of riscv_page_table_exception_test (20% see this issue) due to program execution not being able to return correctly from smode_program. As you can see from the code snippets below, ra gets a write value 0x00000000_8001356C after  jal  ra,80012238 <smode_program>  but gets overwritten shortly after entering smode_program and consequently,  is unable to return on the  c.jr    a4 instruction at the end of smode_program at 80012b1e
My attempts to fix this locally by saving ra upon entry to smode_program resolved this issue but broke the generator code in other ways.  I use SV39 and I have attached the generator compile log and complete generated assembly file.
....
....
0000000080012238 <smode_program>:
    80012238:   41b65a3b                sraw    s4,a2,s11
    8001223c:   fd0a8a93                addi    s5,s5,-48
    80012240:   01f100b3                add     ra,sp,t6
    80012244:   9e9d                    c.subw  a3,a5
    80012246:   01bab423                sd      s11,8(s5)
    8001224a:   8e21                    c.xor   a2,s0
    8001224c:   e9080b13                addi    s6,a6,-368
    80012250:   02147d3b                remuw   s10,s0,ra
    80012254:   41be00b3                sub     ra,t3,s11
0000000080012258 <smode_program_1>:
    80012258:   00400def                jal     s11,8001225c <smode_program_1+0x4>
    8001225c:   004000ef                jal     ra,80012260 <smode_program_1+0x8>
    80012260:   01c000ef                jal     ra,8001227c <smode_program_1+0x24>
    80012264:   024000ef                jal     ra,80012288 <smode_program_1+0x30>
    80012268:   a021                    c.j     80012270 <smode_program_1+0x18>
....
    80012b04:   028779b3                remu    s3,a4,s0
    80012b08:   4f45                    c.li    t5,17
    80012b0a:   03696233                rem     tp,s2,s6
    80012b0e:   030a8a93                addi    s5,s5,48
    80012b12:   02ab53b3                divu    t2,s6,a0
    80012b16:   00b4d43b                srlw    s0,s1,a1
    80012b1a:   000d8713                addi    a4,s11,0 # ffffffff99bcb000 <_end+0xffffffff19b87300>
    80012b1e:   8702                    c.jr    a4                -----> fails to return correctly due to incorrect value in `ra`

0000000080012b20 <smode_lsu_program>:
    80012b20:   8e21                    c.xor   a2,s0
    80012b22:   f88a8a93                addi    s5,s5,-120
....
....

0000000080013552 <check_mprv>:
    80013552:   00020d37                lui     s10,0x20
    80013556:   300028f3                csrrs   a7,mstatus,zero
    8001355a:   01a8f8b3                and     a7,a7,s10
    8001355e:   00088563                beq     a7,zero,80013568 <j_smode>
    80013562:   dbeff0ef                jal     ra,80012b20 <smode_lsu_program>
    80013566:   a019                    c.j     8001356c <fix_pte_ret>

0000000080013568 <j_smode>:
    80013568:   cd1fe0ef                jal     ra,80012238 <smode_program>.

---> Above executes correctly upto this point, saves  8001356c to ra correctly and jumps to the correct target address but fails to return to execute fix_pte_ret below  and the diag goes off into the weeds thereafter

000000008001356c <fix_pte_ret>:
    8001356c:   008ab083                ld      ra,8(s5)
    80013570:   010ab103                ld      sp,16(s5)
    80013574:   018ab183                ld      gp,24(s5)
    80013578:   020ab203                ld      tp,32(s5)
    8001357c:   028ab283                ld      t0,40(s5)
    80013580:   030ab303                ld      t1,48(s5)
    80013584:   038ab383                ld      t2,56(s5)
    80013588:   040ab403                ld      s0,64(s5)
....
...
....

[sim_riscv_page_table_exception_test_0.log](https://github.com/google/riscv-dv/files/5158044/sim_riscv_page_table_exception_test_0.log)

[riscv_page_table_exception_test.S.TXT](https://github.com/google/riscv-dv/files/5158058/riscv_page_table_exception_test.S.TXT)


Add support for IBM CDM Measure resource with care-gap extensions

The IBM Common Data Model FHIR IG defines an additional population type of care-gap that is not calculated by the underlying cqf-ruler implementation. I added a wrapper around MeasureEvaluation called CDMMeasureEvaluation that will pass through the bulk of the heavy lifting to cqf-ruler and then additionally calculate care-gap populations as needed.
While testing this work, I noted that the Library loading mechanism provided by cqf-ruler onlys supported CQL library attachments and not ELM. I added a custom Library loader that will handle both. Testing that uncovered that the library loading was quite chatty with four or more calls to FHIR for a single measure with a single Library. I added caching.
While working with QA it was noted that our docs around SSL were wrong, so I fixed that config and renamed the trustStore we provide for IBM Cloud CDT access to properly reflect its pkcs12 contents. I also added a help parameter to the command line options so that usage can be clearly viewed by a user who just has the JAR.
Some work was done to understand and verify the functionality of the CQL Engine when the provided ELM has been compiled using the CqlTranslator.Option.EnableDateRangeOptimization flag. This flag is necessary to support date filtering on the FHIR REST call, but it creates a scenario where the engine will misbehave when the FHIR retrieve provider does not understand the date property that is being used. I kept the test in place, but it is recommend not to enable that optimation flag at this time.

I changed the target branch of this PR to main in preparation for the changing of the default branch.


Error on release mode

Hi !
this package works on debug mode well but when i want to get release apk i got this error :
`FAILURE: Build failed with an exception.

What went wrong:
Execution failed for task ':mobile_scanner:mergeReleaseResources'.

Could not resolve all files for configuration ':mobile_scanner:releaseRuntimeClasspath'.
Failed to transform exifinterface-1.3.2.aar (androidx.exifinterface:exifinterface:1.3.2) to match attributes {artifactType=android-res, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-runtime}.
Could not find exifinterface-1.3.2.aar (androidx.exifinterface:exifinterface:1.3.2).
Searched in the following locations:
https://dl.google.com/dl/android/maven2/androidx/exifinterface/exifinterface/1.3.2/exifinterface-1.3.2.aar

Try:

Run with --stacktrace option to get the stack trace.
Run with --info or --debug option to get more log output.
Run with --scan to get full insights.

Get more help at https://help.gradle.org

BUILD FAILED in 3s
Running Gradle task 'assembleRelease'...                            4.1s
Exception: Gradle task assembleRelease failed with exit code 1
#0      throwToolExit (package:flutter_tools/src/base/common.dart:10:3)
#1      AndroidGradleBuilder.buildGradleApp (package:flutter_tools/src/android/gradle.dart:408:9)

#2      AndroidGradleBuilder.buildApk (package:flutter_tools/src/android/gradle.dart:184:5)

#3      AndroidDevice.startApp (package:flutter_tools/src/android/android_device.dart:575:7)

#4      FlutterDevice.runCold (package:flutter_tools/src/resident_runner.dart:518:33)

#5      ColdRunner.run (package:flutter_tools/src/run_cold.dart:57:28)

#6      RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:707:27)

#7      FlutterCommand.run. (package:flutter_tools/src/runner/flutter_command.dart:1209:27)

#8      AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#9      CommandRunner.runCommand (package:args/command_runner.dart:209:13)

#10     FlutterCommandRunner.runCommand. (package:flutter_tools/src/runner/flutter_command_runner.dart:281:9)

#11     AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#12     FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:229:5)

#13     run.. (package:flutter_tools/runner.dart:62:9)

#14     AppContext.run. (package:flutter_tools/src/base/context.dart:150:19)

#15     main (package:flutter_tools/executable.dart:91:3)

`
flutter doctor :
`[✓] Flutter (Channel master, 3.1.0-0.0.pre.2142, on macOS 12.5 21G72 darwin-arm, locale en-US)
• Flutter version 3.1.0-0.0.pre.2142 on channel master at /Users/mohammadmahdinazer/Development/SDK/flutter
• Upstream repository https://github.com/flutter/flutter.git
• Framework revision a4947768b7 (22 hours ago), 2022-08-08 07:48:07 -0400
• Engine revision dde62a46ec
• Dart version 2.19.0 (build 2.19.0-74.0.dev)
• DevTools version 2.16.0
[!] Android toolchain - develop for Android devices (Android SDK version 33.0.0)
• Android SDK at /Users/mohammadmahdinazer/Library/Android/sdk
✗ cmdline-tools component is missing
Run path/to/sdkmanager --install "cmdline-tools;latest"
See https://developer.android.com/studio/command-line for more details.
✗ Android license status unknown.
Run flutter doctor --android-licenses to accept the SDK licenses.
See https://flutter.dev/docs/get-started/install/macos#android-setup for more details.
[✓] Xcode - develop for iOS and macOS (Xcode 13.4.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Build 13F100
• CocoaPods version 1.11.3
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 2021.2)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/9212-flutter
• Dart plugin can be installed from:
🔨 https://plugins.jetbrains.com/plugin/6351-dart
• Java version OpenJDK Runtime Environment (build 11.0.12+0-b1504.28-7817840)
[✓] Connected device (4 available)
• SM G965F (mobile)           • 2b5a3aba03027ece • android-arm64  • Android 10 (API 29)
• sdk gphone64 arm64 (mobile) • emulator-5554    • android-arm64  • Android 13 (API 33) (emulator)
• macOS (desktop)             • macos            • darwin-arm64   • macOS 12.5 21G72 darwin-arm
• Chrome (web)                • chrome           • web-javascript • Google Chrome 104.0.5112.79
[✓] HTTP Host Availability
• All required HTTP hosts are available
! Doctor found issues in 1 category.
`

This issue is probably fixed with #257. I will release this as version 3.0.0 after i'm done with a few other functions

Thanks @juliansteenbakker for including this change 🙌  let me know when you plan to release 3.0.0 to pub 8) Gonna use it immediately


Make error

Following build instructions. On make command:
Makefile:8: /make/project.mk: No such file or directory
make: *** No rule to make target `/make/project.mk'.  Stop.
Did I miss something?

Did you install esp-idf?
https://github.com/espressif/esp-idf

Got esp-idf installed configured and woking, but came across this build error:
AR build/app_update/libapp_update.a
CC build/arduino/cores/esp32/libb64/cdecode.o
make[1]: *** No rule to make target cores/esp32/libb64/cencode.o', needed by libarduino.a'.  Stop.
make: *** [component-arduino-build] Error 2
Any help would be appreciated.

@ysdndev
Everything works fine?
If it works well, please close the issue

Sorry, haven't had a chance to test. Close for now. Thanks!


Arborescence

conflicts to resolve

package-lock.json still has react router as a dependency: did you use npm uninstall ?


Cognito user session is not valid

Hello, I am following the tutorial to create the serverless WildRyde application. I followed everything on Module 2 of the tutorial however I am not able to login because the !session.isValid() else if condition in js/cognito-auth.js(line 39) returns false and so I get redirected to the home page.
The user I have is registered and confirmed(enabled) and if I delete the else if condition I also get the auth token.
The session object returned from the cognitoUser.getSession is also not null and contains the tokens.
Any idea why this could happen? Thank you

Also the auth token given when I bypass the else if statement does not work with WildRydes - Test Authorizer


QueryBuilder is largely unusable due to keeping a reference to the World

What problem does this solve or what need does it fill?
The documentation of QueryBuilder claims it can build a QueryState at runtime. However unlike QueryState, the builder retains a reference to the World. This means it can't be stored. This also means no other query can be done on the world at the same time, for example to resolve another Entity returned by the QueryBuilder result. This heavily restricts where and how QueryBuilder can be used.
What solution would you like?
Like QueryState but dynamic, without a world reference. When actually iterating, then take the target World as parameter to a method.
What alternative(s) have you considered?
There's no alternative I know of.
Additional context
Currently bevy_tweening makes heavy use of generics to be able to define systems and behaviors based on the target component being animated. This has been a source of pain since day one. The hope was to eventually abandon this once dynamic queries are available in Bevy, so that a single animation system can process an heterogeneous list of animation targets. Unfortunately, trying to implement this showed this is impossible due to the QueryBuilder limitation of taking a World reference; the animator class references a component/entity pair to animate, but once the query builder is in scope it references the world, making it impossible to query and animate (mutate) that target component.

I would argue that QueryBuilder is the wrong tool for your usecase, as you shouldn't be creating a new QueryState every time your system is called (which is what keeping an instance of QueryBuilder would entail.
Instead, you'll likely want to query EntityMut, FilteredEntityMut or EntityMutExcept or directly use a &mut World reference.

@SkiFire13 Thanks for the details. Fair enough, I may be misunderstanding what QueryBuilder is for. But I thought reading the docs that 1) this was the way to do what I want, and 2) this was the only way, since the release notes about dynamic query point to it (and nothing else IIRC; can't check right now).
So, out of curiosity, what's the use case for QueryBuilder, because now I can't think of any? I think we should maybe clarify it in the docs.
I've looked at EntityMut briefly, it seems I can get a slice of them via World::many_entities_mut(). I'm guessing that with a single system taking &mut World then I can query all my animators for their target entities, collect that (to release the world ref), then get an EntityMut for all of them and mutate one of their components that way. Does it sound like a workable solution?

So, out of curiosity, what's the use case for QueryBuilder, because now I can't think of any? I think we should maybe clarify it in the docs.

From what I understand it is supposed to create queries based on some runtime data, but not every frame. Possible usecases include e.g. systems defined in scripting languages.

I've looked at EntityMut briefly, it seems I can get a slice of them via World::many_entities_mut(). I'm guessing that with a single system taking &mut World then I can query all my animators for their target entities, collect that (to release the world ref), then get an EntityMut for all of them and mutate one of their components that way. Does it sound like a workable solution?

Yeah that sounds better for what you're doing. The collection step sounds a bit unfortunate, though it will be hard to avoid. I think EntityMutExcept has been added for a usecase similar to yours, maybe that could be better? Though AFAIK it also has a runtime overhead, so you'll have to benchmark it against collecting and see which is faster.

From what I understand it is supposed to create queries based on some runtime data, but not every frame.

Ok but if not every frame, how do you store something which references the World? That is going to hold a reference and break everything no? Or is it only meant to be used as a system parameter?

EntityMutExcept doesn't seem to exist in the latest release. I assume it's on main only, so I'll ignore for now.

Ok so my problem with all of this is that once you queried the EntityMut(s), you're holding a mutable reference to the world. This means from this point onward any change you make to those entities needs to be based exclusively on out-of-ECS data, because you can't access the World anymore. So you need to fetch (and potentially duplicate) all the state you need to perform all the mutations, with all the temporary storage allocations this entails, before you can actually apply those mutations. In my case this means I need to update beforehand all animations, store their transient state, as well as duplicate any data (in my case, boxed trait objects) I will need, and store that in local hash maps etc. before I retrieve the EntityMut(s) to apply the changes. This feels extremely counter-productive and non-performant. Although I guess the issue is mostly a tradeoff against querying the EntityMut(s) one by one interleaved with other queries to the World so that there's no lifetime overlap.

Ok but if not every frame, how do you store something which references the World? That is going to hold a reference and break everything no? Or is it only meant to be used as a system parameter?

QueryBuilder is not meant to be stored, it's meant to produce a QueryState which is what then gets stored (possibly as the state for a system parameter but not necessarily).

EntityMutExcept doesn't seem to exist in the latest release. I assume it's on main only, so I'll ignore for now.

Yes, it has only been added recently

Yeah my suspicion is that EntityMutExcept is likely to be the fix here: I suspect you're running into exactly the same stuff that #15282 ran into, based on your comments about animation.


🛑 Stop clobbering Octokit middleware

If dependabot-core is used in another application which has a separate dependency on Octokit, requests made through dependabot-core will rewrite the middleware stack. This is an attempt to prevent that behavior and make the setting of middleware specific to the client being built.

So IIUC, Octokit.middleware is a global? So you're changing the scope of this setting to only the local client?

Correct 😄
I probably could have described that better. Thanks for the question/making it clearer 🙇


AnimationPlayerEditor Realtime Update. Godot 3.2

AnimationPlayerEditor Realtime Update for Godot 3.2
This pull request is Godot 3.2 version of this #43292

Since you asked.
Run bash ./misc/scripts/file_format.sh

*** The following differences were found between the code and the formatting rules:

diff --git a/editor/animation_track_editor.cpp b/editor/animation_track_editor.cpp
index 74f4e3c..b54b0a1 100644
--- a/editor/animation_track_editor.cpp
+++ b/editor/animation_track_editor.cpp
@@ -163,7 +163,7 @@ public:
 			undo_redo->commit_action();

 			setting = false;
-
+
 			AnimationPlayerEditor::singleton->_animation_key_editor_seek(-1, false);
 			return true;
 		}
@@ -184,7 +184,7 @@ public:
 				undo_redo->commit_action();

 				setting = false;
-
+
 				AnimationPlayerEditor::singleton->_animation_key_editor_seek(-1, false);
 				return true;
 			} break;
@@ -208,7 +208,7 @@ public:
 					undo_redo->commit_action();

 					setting = false;
-
+
 					AnimationPlayerEditor::singleton->_animation_key_editor_seek(-1, false);
 					return true;
 				}
@@ -300,7 +300,7 @@ public:
 					undo_redo->commit_action();

 					setting = false;
-
+
 					AnimationPlayerEditor::singleton->_animation_key_editor_seek(-1, false);
 					return true;
 				}
@@ -319,7 +319,7 @@ public:
 					undo_redo->commit_action();

 					setting = false;
-
+
 					AnimationPlayerEditor::singleton->_animation_key_editor_seek(-1, false);
 					return true;
 				}
@@ -338,7 +338,7 @@ public:
 					undo_redo->commit_action();

 					setting = false;
-
+
 					AnimationPlayerEditor::singleton->_animation_key_editor_seek(-1, false);
 					return true;
 				}

*** Aborting, please fix your commit(s) with 'git commit --amend' or 'git rebase -i <hash>'
Error: Process completed with exit code 1.

The failure logs.

@fire
Done, Thank you.

You can close this PR and open add your PR.

https://github.com/godotengine/godot/pull/43463 supersedes this pr.


SliverAppBar's flexibleSpace glitch on iOS when NestedScrollView's body is a ScrollView

Steps to Reproduce
Basically, when creating an application with a SliverAppBar inside a NestedScrollView, a scrolling glitch is performed only on iOS if you scroll down and then scroll up before the bouncing animation ends. On Android it does not happen.
Noticed that it happens when the body of the NestedScrollView is an implementation of ScrollView.
Demo:

Example code (simplified code from the demo):
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      title: 'Flutter Demo',
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatefulWidget {
  @override
  _MyHomePageState createState() => _MyHomePageState();
}

class _MyHomePageState extends State<MyHomePage>
    with SingleTickerProviderStateMixin {
  TabController _tabController;
  ScrollController _scrollViewController;

  @override
  void initState() {
    super.initState();
    _tabController = TabController(vsync: this, length: 2);
    _scrollViewController = ScrollController(initialScrollOffset: 0.0);
  }

  @override
  void dispose() {
    _tabController.dispose();
    _scrollViewController.dispose();
    super.dispose();
  }

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      body: NestedScrollView(
        controller: _scrollViewController,
        headerSliverBuilder: (BuildContext context, bool boxIsScrolled) {
          return <Widget>[
            SliverAppBar(
              expandedHeight: 300.0,
              title: Text('Tab Controller Example'),
              pinned: true,
              floating: true,
              forceElevated: boxIsScrolled,
            )
          ];
        },
        body: PageOne(),
      ),
    );
  }
}

class PageOne extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return ListView.builder(
      itemExtent: 250.0,
      itemBuilder: (context, index) => Container(
            padding: EdgeInsets.all(10.0),
            child: Material(
              elevation: 4.0,
              borderRadius: BorderRadius.circular(5.0),
              color: index % 2 == 0 ? Colors.cyan : Colors.deepOrange,
              child: Center(
                child: Text(index.toString()),
              ),
            ),
          ),
    );
  }
}

Is there any workaround to make it work properly? Is this a framework bug? I ask that because almost every example code of this functionality is like the example above.
Thank you!
Logs
Flutter doctor:
[✓] Flutter (Channel beta, v1.2.1, on Mac OS X 10.13.6 17G3025, locale pt-BR)
    • Flutter version 1.2.1 at /Users/hendricgc/flutter
    • Framework revision 8661d8aecd (4 weeks ago), 2019-02-14 19:19:53 -0800
    • Engine revision 3757390fa4
    • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)

[✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
    • Android SDK at /Users/hendricgc/Library/Android/sdk
    • Android NDK location not configured (optional; useful for native profiling support)
    • Platform android-28, build-tools 28.0.3
    • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
    • All Android licenses accepted.

[✓] iOS toolchain - develop for iOS devices (Xcode 10.1)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Xcode 10.1, Build version 10B61
    • ios-deploy 1.9.4
    • CocoaPods version 1.5.3

[✓] Android Studio (version 3.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin version 33.3.1
    • Dart plugin version 182.5215
    • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)

[✓] Connected device (2 available)
    • Android SDK built for x86 • emulator-5554                        • android-x86 • Android 8.1.0 (API 27) (emulator)
    • iPhone 8                  • 24F06D4E-0628-4529-93A4-D2C16A67C4F6 • ios         • iOS 12.1 (simulator)

• No issues found!

I have the same problem, waiting for a decision. Thank you in advance.

You can use physics: ClampingScrollPhysics() inside NestedScrollView or CustomScrollView to change scrolling behavior to android-like. This is not the proper fix but at least this will make slivers usable on iOS.

I got this problem too, hopefully there's a fix

I got this problem too

Yes, same problem here - using ClampingScrollPhysics() in the NestedScrollView does not help either.

I have the same problem. ClampingScrollPhysics is also no help for me.

I have the same problem. ClampingScrollPhysics is also no help for me.

Same problem so I can't use the driver test for iOS because I have this widget.

I have the same problem. Setting ClampingScrollPhysics on the CustomScrollView prevents the bug from appearing, but it does not feel right on iOS.

I am facing the same problem here. Using ClampingScrollPhysics on ListView.builder solved to me (on NestedScrollView it not worked). But I agree that is not the proper solution, since I need the iOS physics on the list.
[✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G84, locale pt-BR)

ClampingScrollPhysics() doesn't work. @Hixie - any help you can provide here? Thanks.

I've distilled the provided reproduction and confirmed on master:
import 'package:flutter/material.dart';

void main() => runApp(MyApp());

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: Scaffold(
        body: NestedScrollView(
          headerSliverBuilder: (BuildContext context, bool boxIsScrolled) {
            return <Widget>[
              SliverAppBar(
                expandedHeight: 300.0,
                title: Text('Demo'),
              )
            ];
          },
          body: ListView.builder(
            itemExtent: 250.0,
            itemBuilder: (context, index) => Container(
              child: Center(child: Text(index.toString()))
            )
          )
        ),
      ),
    );
  }
}

@Piinks Is it fixed now ?

No, I have confirmed it is currently reproducing on master.

@Piinks Cool, wait for the fix then. Cheers

Waiting for the fix. Cheers

I think this happened to every ScrollView. Not only NestedScrollView
If you drag down until and the end of spring when you drag up quickly,
After you release the finger ScrollView will try to animate the scroll position to zero.
I think it's the case to make NestedScrollView be like this.

facing the same problem

I found a solution that might work：
NestedScrollView add ScrollController1
CustomScrollView add ScrollController2
Bind Listen to ScrollController2
eg:
// add _scrollController1 _scrollController2
NestedScrollView(
  physics: NeverScrollableScrollPhysics(),
  controller: this._scrollController1,
  headerSliverBuilder: (BuildContext context, bool innerBoxIsScrolled) {
    return <Widget>[
       SliverPersistentHeader(
         floating: false,
         pinned: false,
         delegate: SliverAppBarDelegate(
           minHeight: AppConfig.trendHeaderImageHeight,
           maxHeight: AppConfig.trendHeaderImageHeight,
           child: trendingHeader,
         )
       )
    ];
  },
  body: CustomScrollView(
    controller: this._scrollController2
	...
  ),
);

// initState bind listen
WidgetsBinding.instance.addPostFrameCallback((_) {
  this._scrollController2.addListener(() {
    double offset = this. _scrollController2.offset;
    if(offset <= AppConfig.trendHeaderImageHeight){
       _scrollController1.jumpTo(offset);
    }else if(offset > AppConfig.trendHeaderImageHeight && widget.scrollController.offset < AppConfig.trendHeaderImageHeight){
       _scrollController1.jumpTo(AppConfig.trendHeaderImageHeight);
    }
    // ScrollDirection direction = this.listViewController.position.userScrollDirection;
  });
});

any solutions?

@HansMuller Is this really a performance issue? It looks more like a glitch to me. Even if the underlying issue is performance, from the user's perspective, it seems more critical.

Did you have any solutions to propose? It's a real problem in many of the projects I work with |

Going through the same problem. Hoping a fix is released soon

I found success with the same workaround as @FernandoUFS. It is adding ClampingScrollPhysics on ListView.builder that works. Adding the same to NestedScrollView does not help.
import 'package:flutter/material.dart';

void main() {
  runApp(MyApp());
}

class MyApp extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: MyHomePage(),
    );
  }
}

class MyHomePage extends StatelessWidget {
  @override
  build(BuildContext context) {
    return DefaultTabController(
      length: 3,
      child: Scaffold(
        body: NestedScrollView(
          headerSliverBuilder: (BuildContext context, bool isScrolled) {
            return [
              SliverAppBar(
                pinned: true,
                floating: true,
                expandedHeight: 200,
                title: Text("Tab Bouncing Problem"),
                flexibleSpace: FlexibleSpaceBar(),
                bottom: TabBar(
                  tabs: [
                    Tab(text: "One"),
                    Tab(text: "Two"),
                    Tab(text: "Three"),
                  ],
                ),
              ),
            ];
          },
          body: TabBarView(
            children: [
              MyTabContainer(),
              MyTabContainer(),
              MyTabContainer(),
            ],
          ),
        ),
      ),
    );
  }
}

class MyTabContainer extends StatelessWidget {
  @override
  Widget build(BuildContext context) {
    return ListView.builder(
      physics: ClampingScrollPhysics(), // *** THIS IS THE FIX ***
      itemBuilder: (BuildContext context, int index) {
        return ListTile(
          title: Text("Item: $index"),
        );
      },
    );
  }
}

Does anyone have any clue when this might be addressed? It's been open for almost a year now.
SliverAppBar is totally unusable like this.
Meanwhile, is there anything we could try to workaround this issue while retaining the bouncing physics?

@hendricgc  Add  physics: ClampingScrollPhysics() in ListView.builder of Pageone.

use extended_nested_scroll_view, this plugin is okay.

I believe I have a fix for this. See #55069.
The SliverAppBar in the original reproduction above is a floating app bar. #55069 is intended to fix the overscroll issue. The floating issue is being tracked in #17518, with a fix to follow soon there too. :)
Feedback always welcome.

What's the recommended flutter channel for this fix? I know that the recent "master, 1.19.0-2.0.pre.145" has the fix but I don't want to use it for my product since it's not stable.
Please suggest the best practice @Piinks

Hi @dprodoomoolmori,

Do you know when this fix will be merged to stable channel? I know that the recent "master, 1.19.0-2.0.pre.145" has the fix but I don't want to use it for my product since it's not stable. I did copy/paste nested_scroll_view.dart for now.

I don't know an exact date when it will reach stable, but our wiki provides guidance on our release process.

In my product, there is still an issue that when scroll on NestedScrollView widget, the SingleChildScrollView inside a TabBarView is also scrolling. I can send the recorded video of it if you need. Can I request for this issue?

I would file a separate issue for this with a minimal code reproduction of the behavior you are experiencing.

Update on the milestone here: As mentioned above, the UI glitch has been fixed, but the floating portion of the reproduction is outstanding (related issue: #17518). There is a PR open to close both issues (#57707), it is still going back and forth in review, anticipated to land soon. I have moved the milestone to June to remove from the overdue heap.

@Piinks  this issue still happens, noticed it in Flutter Channel master, 1.24.0-4.0.pre.106.

Doctor summary (to see all details, run flutter doctor -v):
[✓] Flutter (Channel master, 1.24.0-4.0.pre.106, on Mac OS X 10.15.4 19E287 darwin-x64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
[✓] Xcode - develop for iOS and macOS (Xcode 12.1)
[✓] Chrome - develop for the web
[✓] Android Studio (version 3.6)
[✓] VS Code (version 1.50.0)
[✓] Connected device (5 available)

Hi @Piinks, Thank you so much for fixing this issue. I'm very happy about it. And I've got two concerns. Please consider those as feedback/request.

Do you know when this fix will be merged to stable channel? I know that the recent "master, 1.19.0-2.0.pre.145" has the fix but I don't want to use it for my product since it's not stable. I did copy/paste nested_scroll_view.dart for now.
In my product, there is still an issue that when scroll on NestedScrollView widget, the SingleChildScrollView inside a TabBarView is also scrolling. I can send the recorded video of it if you need. Can I request for this issue?

did you find any solution for this?

Still facing this issue? Any update ?
Flutter 1.22.6 • channel stable • https://github.com/flutter/flutter.git Framework • revision 9b2d32b605 (5 months ago) • 2021-01-22 14:36:39 -0800 Engine • revision 2f0af37152 Tools • Dart 2.10.5


Create files with host user ids

When running docker with the php image, any command is run as root, unless. It is possible to specify another user to run as with the --user option though.
Note that creating the user and group on the docker image does not seem to be required for this to work, so let us just not do it. This spares us from creating a custom entrypoint file.

Thanks a lot! this saves me some headache!


Switch clientsholder to user constructor style

Further compartmentalize the clientsholder Context struct by using a more constructor-esque style with appropriate Getter functions.
Created a new NewContext func to help build clientsholder.Context objects.

check workload tnf-test-cnf-green tnf-test-cnf-green:ansible_extravars=provisioner_user:""

check workload tnf-test-cnf-green tnf-test-cnf-green:ansible_extravars=provisioner_user:""

This is the way of launching DCI tests manually for your PRs, by the way (but I am looking for a way of doing it shorter)

check workload tnf-test-cnf-green

check workload tnf-test-cnf-green

This is the way of launching DCI tests manually for your PRs, by the way (but I am looking for a way of doing it shorter)


Hidden tokens still have and share vision

Usually when a token is hidden, the player no longer has any vision from that token (this is useful for moving players across the map without revealing stuff in between point A and point B). I noticed that after enabling the SharedVision module that this is no longer the case. Furthermore, if I enable global shared vision, then other players would also still be able to see through a hidden token.
Repro 1 (one token):

Player A has ownership of Token A.
GM hides Token A (right click token, click on hide)
Notice that Player A is still able to see from where Token A is, despite the fact that the token is now hidden

Repro 2 (two tokens):

Player A has ownership of Token A, and Player B has ownership of Token B
Both Token A and Token B have Global Shared Vision enabled in their permission config
GM enables global shared vision via the control button.
GM hides Token A.
Notice that both players are still able to see via the hidden token

I will note that I do have MidiQol installed, however I do not have the playerControlsInvisibleTokens setting enabled, so I don't believe this has an impact on the issue(?)
I was able to fix this locally for my game by adding in a if (this.data.hidden) return false; at the top of isVisionSourceOverride().

Thanks for reporting this in such detail!
It was a conscious decision to allow the vision to be shared, even if a token is hidden. The main reason is that you could use a hidden token to reveal areas without a PC being there, almost like a sort of light source. I thought this would mainly be useful for the global vision setting, so you easily could show a whole area, even if the PCs do not have full visibility.
I can understand that this is not always preferable, so I'll make it a toggleable setting.

This has been added in v1.0.3 that can be downloaded right now


[core-amqp] Minor edits to docs

This PR is to add back in last commit that was missed during merge of #4158

@adrianhall Looking for your English expertise here :)
retryable or retriable?

Retryable is the more correct spelling, triable in the sense of able to be tested, is rare.  At least, according to Collins.  OED doesn't even have triable as a definition.


shopware-cli project extension list 'fatal error'

PHP Version
7.4.32
Shopware Version
<IP_ADDRESS>
Actual behaviour
command shopware-cli project extension list --project-config .shopware-project.dev.yml return error
FATA[0001] API request failed, got http code 500 with content: Shopware\Core\Framework\Api\Context\AdminApiSource does not have a valid user ID

from app log
[2022-10-11T11:57:09.914365+00:00] request.CRITICAL: Uncaught PHP Exception Shopware\Core\Framework\Api\Context\Exception\InvalidContextSourceUserException: "Shopware\Core\Framework\Api\Context\AdminApiSource does not have a valid user ID" at /var/www/html/vendor/shopware/core/Framework/Store/Authentication/StoreRequestOptionsProvider.php line 97 {"exception":"[object] (Shopware\\Core\\Framework\\Api\\Context\\Exception\\InvalidContextSourceUserException(code: 0): Shopware\\Core\\Framework\\Api\\Context\\AdminApiSource does not have a valid user ID at /var/www/html/vendor/shopware/core/Framework/Store/Authentication/StoreRequestOptionsProvider.php:97)"} []

Expected behaviour
get list of plugins
Steps to Reproduce?
run shopware-cli project extension list

You have to use a real user integration / or user password. It's a limitation inside Shopware


Initial useCollectionDataOnce returns empty

I have:
  const [documents, documentsLoading, documentsError]: [DocumentInterface[], boolean, Error] = useCollectionDataOnce(
    firebase.firestore().collection('documents')
      .where('userId', '==', '1234')
      .orderBy('updatedAt', 'desc')
    ,
    { idField: 'id' }
  )

  useEffect(() => {
    console.log(documentsLoading, documents)
  }, [documents, documentsLoading])

This looks like:
true undefined
false []
true undefined
false [{....}]

So it looks like it's loading twice?

Howdy,
I'm having a similar issue but related to all of the useXonce hooks.
versions in package.json
    "firebase": "^9.7.0",
    "firebase-admin": "^10.1.0",
    "next": "12.1.5",
    "react": "18.1.0",
    "react-dom": "18.1.0",
    "react-firebase-hooks": "^5.0.3",

Refreshing the page does not fetch anything, but making any change in the code / forcing a hot-reload will then show the data.
import { useCollectionOnce } from 'react-firebase-hooks/firestore'

  let ref = firestore
    .collection('users')
    .doc(userId)
    .collection('library')
  const [library, loading, error] = useCollectionOnce(ref)

I'm closing this in favour of #231 and #252


Ping never resolving?

When navigating to my Plex landing page, the ping process never resolves, good or bad. I know the server is up and accessible from the outside network, and I know that the IP address/port is correct and open. What should I do next?

Could you send me the part where you modified with your IP address? You can replace the IP address and port with a fake one, but I want to see if it's all in place.

So, this is what the code looks like now for the ping function. I had to go down further in the HTML and remove the actual layout below the Plex, request, and email buttons, and I comment'd out the "onload" in the first  so I could at least get the homepage to work. I have a duckDNS name for my public IP as well, but it didn't work with that, with my ip address, or the document.domain.
NOTE: It only seemed to be an issue from inside my LAN. I turned my cell phone's wifi off and was able to get it to work, ONCE. but then I got the same error.

document.domain should have " ".
Ex: "document.domain"
Ex2: "<IP_ADDRESS>"
Add your external IP address there with a port or use your duckDNS webpage and see if that works. Sorry it has taken time to reply. I've been away for a while but I'm back now.

@justinerwin did you get it to work?

I'm closing this issue as I've gotten no response. If you need any further assistance my email is<EMAIL_ADDRESS>


changed config format to allow multiple nodes for a single para config

Resolves https://github.com/paritytech/polkadot-launch/issues/74

allows elegantly expressing multiple nodes on the same parachain
some remaining linting fixes

replaced with https://github.com/paritytech/polkadot-launch/pull/87


Adapt API Access tests after new changes in dashboard endpoints

Adapting tests after changes introduced by https://issues.redhat.com/browse/RHODS-5388
Main changes:

pvc endpoint is not reachable anymore: tests expects 404
notebooks endpoints have changed the expected JSON body to create/update/stop notebook servers plus PUT has been removed: tests use POST for both creation and update, while PATCH is used to stop
configmaps and secrets endpoints have been replaced by envs which should allow GET only

Moreover it adds the test for route endpoint which was introduced in v1.16
Signed-off-by: bdattoma<EMAIL_ADDRESS>

Jenkins job: 1331 SUCCESS


Do not perform xfs_repair on xfs filesystem

This partly reverts https://github.com/kubernetes/utils/pull/126 but still we perform filesystem repair just before mounting.
fixes https://github.com/kubernetes/utils/issues/141

cc @jsafrane @msau42

/assign @jsafrane @msau42

/assign

/approve
/hold
@xing-yang @saad-ali (others!) feel free to remove hold when this is ready

/lgtm
/approve

/hold cancel


Trying to unregister a portal "${name}" when PortalTarget tears down before next.

Hi! I'm upgrading from ember-stargate 0.2.0 to 0.4.3 (on Ember 3.24). It looks like this PR moved the registerPortal call into a next call.
This causes a bug when transitioning to my error route. When the PortalTarget first renders, it calls registerPortal. The transition to the error route happens before the next is called, and unregisterPortal is called before registerPortal gets to the next call, which throws the error from the title.
I'd be happy to work on a fix for this, but I'd like to do it in a way that makes sense. My first thought is to put the contents of unregisterPortal into a next loop as well.

Looks like this is the same issue I have been seeing in fastboot mode here: https://github.com/simonihmig/ember-stargate/issues/413 - however I do not transition to a different route (I haven't seen that issue in non fastboot mode though...). Also it only appears when there is content rendered inside the portal.
Today I was finally debugging fastboot mode and I had very similar findings.

the modify hook in the portal component is called
the destructor is invoked, calling this.portalService.unregisterPortal(this._target). This causes the error.
then the  code in the next() block in the modify hook is executed, which tries to register the portal for the first time

I am a bit puzzled why the destructor is being called before the stagate setup is completed - except that the app seems to be torn down before ember-stargate is done initializing itself fully. If I go back in the stacktrace, I end up in ember-app.js where the _destroy() method is called inside the visit() method.
Probably the best way to fix this is by setting a destroyed flag in the destructor, so one can make the code in the next() method a noop and stop trying to destroy a portal that hasn't been registered yet? Otherwise wrapping the destructor content in next() as well might also work. Then the portal would likely be registered and very soon deregistered again. However, the question also comes up, why the next() block is needed in first place?
@simonihmig any thoughts about that?

I think the original bug report should get fixed by #644. Will look into the fastboot story next...


hhvm: fix build

Motivation for this change
HHVM doesn't build:

https://hydra.nixos.org/build/59511735
https://github.com/NixOS/nixpkgs/issues/28643

/cc package maintainer @thoughtpolice
Things done

[x] Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] Linux

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Did you try updating HHVM?

3.15.8 - most recent release in 3.15 release series suffers from the same error, it may require adjusting the patch. I haven't tried updating to the most recent upstream release.

Even on 3.21 - most recent upstream LTS release - patching for gcc6 is still required for the bundled re2 library. Only tested briefly with a simple CLI PHP script and a simple WordPress site.

Is it possible to use the nixpkgs re2?

@globin I haven't looked into substituting nixpkgs libraries in place of the bundled ones. In the specific case of re2 ours appears to be ~ 2 years behind the version bundled with hhvm:

https://github.com/NixOS/nixpkgs/blob/56904d7c423f2b13b37fbd29f39bbb4b52bc7824/pkgs/development/libraries/re2/default.nix#L5
https://github.com/google/re2/tree/718df09610fee584c9038d8d519697e507e09c9b

I haven't tried but I suspect it would require some more work beyond convincing the build system to use nipxkgs re2.

I guess this is fine for now


Handle disabling submitting vote result when no one voted and voting period done

We should disable the "submit vote result" button when no one has voted.
Depends on: https://github.com/openlawteam/molochv3-contracts/pull/256

As discussed with @adridadou, the changes needed for the UI are the following:

If proposal has no votes and the voting period has ended, don't show the "Submit Vote Result" button.
Show Grace Period timer immediately after the voting period has ended.
Show disabled "Process" button if still in Grace Period.
Enable "Process" button when the Grace Period is over.

To summarize, if the proposal has no votes, the "Submit Vote Result" action should be skipped and go right to Grace Period and then ability to Process.

As far as the listing categories are concerned, it's my inclination to keep it in the "Voting" section, until a result is submitted, just like how it's handled today. Thoughts?

In this case there will be no vote result submitted. But I agree that we should keep the category like how it's handled today. It can stay in the "Voting" section until the Grace Period has ended. After that, it should be in the "Failed" section with the Process button re-enabled.

Thank you, you're right. OK, in that case I will need to thread through the Snapshot Hub votes and their results into the <Proposals /> to be able to determine for certain no one voted. It will fit nicely with my work in #248, though I will make a separate PR.