Implement lightmaps.

(This PR is essentially done, but needs a bit more polish.)
Objective
Lightmaps, textures that store baked global illumination, have been a mainstay of real-time graphics for decades. Bevy currently has no support for them, so this pull request implements them.
TODO: Write more here.
Solution
TODO: Write more here.
This pull request introduces a new render set, PrepareBatches, makes it run after PrepareResources, and moves all the batching logic into that set. It's needed because the lightmap indices must be assigned before the batches are built, because the Mesh data structure contains the lightmap index.

Changelog
Added

A new component, Lightmap, is available, for baked global illumination. If your mesh has a second UV channel (UV1), and you attach this component to the entity with that mesh, Bevy will apply the texture referenced in the lightmap.

This pull request introduces a new render set, PrepareBatches, makes it run after PrepareResources, and moves all the batching logic into that set. It's needed because the lightmap indices must be assigned before the batches are built, because the Mesh data structure contains the lightmap index.

Can we split this into a second PR? It'll make this one easier to review, but more importantly, we should be able to merge it quickly and avoid merge conflicts :)

I've split parts of this PR out into three separate PRs: #10234, #10235, and #10237. Those should land before this does.

I pushed a new commit that gets rid of MeshLayoutKey and builds on top of Bevy's current system instead. So #10235 is no longer a dependency.

How easy would this be to extend to other UV maps and to potentially use different shaders?  I ask this because I use lightmaps generated by unreal and they currently go up to at least UV4 and a custom shader is required to decode them

@Adriaaaaan You probably want to look at https://github.com/pcwalton/bevy-baked-gi which shows how to implement lightmaps without modifying Bevy itself. Note that it's targeted toward 0.12 and doesn't have ExtendedMaterial; with ExtendedMaterial it'd be a lot simpler.

Updated to remove the renaming of uv to uv_a per consensus on Discord. This means that #10237 is no longer a dependency.

Per discussion on Discord I eliminated texture atlases in favor of simply breaking batches when lightmaps use different textures. You can still get mesh instancing by packing your lightmaps into an atlas; individual mesh instances can have their own UV rects. This dramatically simplifies the batch building code, obviating the need for lightmap building to run before batching. This means that #10234 is no longer a dependency.

Btw, this PR needs updating to use the new style of shader imports.

@JMS55 Updated to use the new shader import style.

OK, I've redone the way lightmaps are extracted to be significantly less confusing and straightforward. It now follows the "render mesh instances" pattern the rest of rendering uses. There's a big comment in lightmap/mod.rs explaining how the flow works.

This currently crashes when used with any scene that also uses a depth prepass (or any prepass).
Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 4, Vulkan)>`
    In a draw command, indexed:true indirect:false
      note: render pipeline = `pbr_prepass_pipeline`
    The pipeline layout, associated with the current render pipeline, contains a bind group layout at index 1 which is incompatible with the bind group layout associated with the bind group at 1
    ```

This currently crashes when used with any scene that also uses a depth prepass (or any prepass).

We should fix this up before merging: once that's done ping me and I'll merge it.

The lightmaps in the example appear to be generated without sufficient padding, resulting in aliasing artifacts. It's probably worthwhile to try to have properly generated lightmaps since they are adding around 2.3MB to the repo.

The lightmaps in the example appear to be generated without sufficient padding, resulting in aliasing artifacts. It's probably worthwhile to try to have properly generated lightmaps since they are adding around 2.3MB to the repo.

This should be fixed now.

This currently crashes when used with any scene that also uses a depth prepass (or any prepass).
Caused by:
    In a RenderPass
      note: encoder = `<CommandBuffer-(0, 4, Vulkan)>`
    In a draw command, indexed:true indirect:false
      note: render pipeline = `pbr_prepass_pipeline`
    The pipeline layout, associated with the current render pipeline, contains a bind group layout at index 1 which is incompatible with the bind group layout associated with the bind group at 1
    ```

Fixed.

Looks like the Clippy failure in CI is truly unrelated, as fixing it led to another clearly-unrelated Clippy failure. I'm going to just revert that attempt to fix it; another PR will need to fix the Clippy issues, as bundling them into this one will just be confusing.

I think we should include vertex uv b in the prepass as well.
At some point we should probably consolidate the code a bit between the prepass and forward specialization so they don't diverge.

I think we should include vertex uv b in the prepass as well.
At some point we should probably consolidate the code a bit between the prepass and forward specialization so they don't diverge.

Done.

This should be ready to go, if nothing else comes up--the CI failure is just unrelated Clippy stuff.

On native vulkan/dx12 the lightmaps are now working when the depth prepass is present. But on webgl2 I get this error in both firefox and chrome: Tex storage 2D multisample is not supported.

@pcwalton if this doesn't go through, can you please merge main in? We're struggling with CI difficulties.


Flann failed to build on cmake 3.9 because of FindHDF5.cmake related error

I am on vs2015 and cmake 3.9. I am unable to build flann successfully because of FindHDF5.cmake related error. I suspect it's similar to the problem related to #1545. @ousttrue could you please help me look into this. I am trying to test #1283 and flann is one of the prerequisite. Below is the error log
CMake Warning (dev) at CMakeLists.txt:17 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "MSVC" will no longer be dereferenced when the policy
  is set to NEW.  Since the policy is not set the OLD behavior will be used.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at CMakeLists.txt:21 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "MSVC" will no longer be dereferenced when the policy
  is set to NEW.  Since the policy is not set the OLD behavior will be used.
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Error at C:/Program Files/CMake/share/cmake-3.9/Modules/FindHDF5.cmake:450 (get_target_property):
  get_target_property called with incorrect number of arguments
Call Stack (most recent call first):
  C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake:145 (_find_package)
  cmake/flann_utils.cmake:25 (find_package)
  CMakeLists.txt:76 (find_hdf5)

CMake Warning at CMakeLists.txt:117 (message):
  gtest library not found, some tests will not be run

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.9/Modules/FindOpenMP.cmake:212 (if):
  Policy CMP0054 is not set: Only interpret if() arguments as variables or
  keywords when unquoted.  Run "cmake --help-policy CMP0054" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  Quoted variables like "MSVC" will no longer be dereferenced when the policy
  is set to NEW.  Since the policy is not set the OLD behavior will be used.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.9/Modules/FindOpenMP.cmake:324 (_OPENMP_GET_FLAGS)
  C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake:145 (_find_package)
  CMakeLists.txt:122 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.9/Modules/FindOpenMP.cmake:277 (if):
  if given arguments:

    "TRUE"

  An argument named "TRUE" appears in a conditional statement.  Policy
  CMP0012 is not set: if() recognizes numbers and boolean constants.  Run
  "cmake --help-policy CMP0012" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.9/Modules/FindOpenMP.cmake:380 (_OPENMP_GET_SPEC_DATE)
  C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake:145 (_find_package)
  CMakeLists.txt:122 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at C:/Program Files/CMake/share/cmake-3.9/Modules/FindOpenMP.cmake:277 (if):
  if given arguments:

    "TRUE"

  An argument named "TRUE" appears in a conditional statement.  Policy
  CMP0012 is not set: if() recognizes numbers and boolean constants.  Run
  "cmake --help-policy CMP0012" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.
Call Stack (most recent call first):
  C:/Program Files/CMake/share/cmake-3.9/Modules/FindOpenMP.cmake:380 (_OPENMP_GET_SPEC_DATE)
  C:/dev/vcpkg/scripts/buildsystems/vcpkg.cmake:145 (_find_package)
  CMakeLists.txt:122 (find_package)
This warning is for project developers.  Use -Wno-dev to suppress it.

CMake Warning (dev) at test/CMakeLists.txt:4 (add_custom_target):
  Policy CMP0037 is not set: Target names should not be reserved and should
  match a validity pattern.  Run "cmake --help-policy CMP0037" for policy
  details.  Use the cmake_policy command to set the policy and suppress this
  warning.

  The target name "test" is reserved or not valid for certain CMake features,
  such as generator expressions, and may result in undefined behavior.
This warning is for project developers.  Use -Wno-dev to suppress it.

ok. I try to build vcpkg install flann and get same error.
error message
CMake Error at C:/Program Files/CMake/share/cmake-3.9/Modules/FindHDF5.cmake:450 (get_target_property):
  get_target_property called with incorrect number of arguments

is problem.
I comment out find_package(HDF5) of flann-1.9.1/cmake/flann_utils.cmake , then I successfully build flann.

@ousttrue Is there a way to solve this through modifying the port file?

@jasjuang CMakeLists.txt of flann has no option for hdf5. find_hd5() is top level.

@ousttrue Got it. Do you know how to solve it?

@jasjuang I think that There is a need to modify flann-1.9.1/CMakeLists.txt.
Patch is required.
How to create patch is here.

https://github.com/Microsoft/vcpkg/blob/master/docs/examples/patching-libpng.md#patching-the-code-to-improve-compatibility

@jasjuang @ousttrue I think that character code is this cause.
Please execute the following command to set character code to UTF-8, before install FLANN port.
chcp 65001
vcpkg install flann

This work was not necessary previously.
I don't know why it is necessary to change charactor code to UTF-8.
(@ras0219-msft may know.)

@UnaNancyOwen Unfortunately chcp 65001 does nothing for me. It still fails to compile.

@jasjuang Which version of vcpkg are you using?
I confirmed that it will be successfully installed using the latest vcpkg (f8ee92bacefaa95347b6c1eec5fda4dcf4666fe4).

I defined the custom triplet (x86-windows-v140.cmake) for Visual Studio 2015.
set(VCPKG_TARGET_ARCHITECTURE x86)
set(VCPKG_CRT_LINKAGE dynamic)
set(VCPKG_LIBRARY_LINKAGE dynamic)
set(VCPKG_PLATFORM_TOOLSET v140)

@UnaNancyOwen I am on the latest vcpkg but I was trying to build the 64 bit version, which is x64-windows

@jasjuang The x64 triplet install was also successful.

@UnaNancyOwen That's weird, but @ousttrue also confirmed that he can reproduce the error. Are you on cmake 3.9?

@jasjuang Yes, I'm using the CMake 3.9.0 (vcpkg/downloads/cmake-3.9.0-win32-x86) that downloaded and installed by vcpkg.

@jasjuang @UnaNancyOwen Just wondering. Does vcpkg prefer the bundled one over  locally installed cmake?

@jasjuang @atkawa7 I tried using local CMake 3.9.0, but FLANN port install was also successful.

I tried using local installed CMake 3.9.0, but FLANN port install was also successful.

Try remove vcpkg\buildtrees\flann before installing it

@KindDragon I tried it, but install was successful.

I tried removing  vcpkg\buildtrees\flann and install it but the
installation is still unsuccessful. I even tried switching to windows
powershell and rerun bootstrap-vcpkg.bat, but it still fails to compile for
me
On Wed, Aug 2, 2017 at 9:19 AM, Tsukasa Sugiura<EMAIL_ADDRESS>wrote:

@KindDragon https://github.com/kinddragon I tried it, but install was
successful.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vcpkg/issues/1572#issuecomment-319723299,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ALNuYK8rrczl5uk8mTFekp7M-27cFjROks5sUKGdgaJpZM4OntWc
.

Error for me too (only with CMake 3.9):
CMake Error at D:/Work/vcpkg/downloads/cmake-3.9.0-win32-x86/share/cmake-3.9/Modules/FindHDF5.cmake:450 (get_target_property):
  get_target_property called with incorrect number of arguments
Call Stack (most recent call first):
  D:/Work/vcpkg/scripts/buildsystems/vcpkg.cmake:145 (_find_package)
  cmake/flann_utils.cmake:25 (find_package)
  CMakeLists.txt:76 (find_hdf5)

It seems like we should probably intercept the call to find_package(HDF5) inside our toolchain file and just "do the right thing" if the cmake version is 2.9. This would properly fix all of the portfiles and any user code. Something like [1].
[1] https://github.com/Microsoft/vcpkg/blob/6f112cf9611cabbe5641cc6ce0bd13d0144f50be/scripts/buildsystems/vcpkg.cmake#L141-L146

Changes in FindHDF5.cmake between CMake 3.8 and 3.9 https://gist.github.com/KindDragon/3cd8bd383ce3d145690335758b389b4c

@ras0219-msft @KindDragon  with the newly merged PCL I am eager to see this fixed, however I am unsure what should be added in vcpkg.cmake in order to fix this, could you give me some hints?

@atkawa7 The downloaded copy is preferred over the system installed one. You can see the order here:
https://github.com/Microsoft/vcpkg/blob/master/toolsrc/src/VcpkgPaths.cpp#L107

Have you tried passing -DHDF5_NO_FIND_PACKAGE_CONFIG_FILE=ON to cmake? This will disable using the hdf5-config.cmake completely in the FindHDF5 module.
Besides that CMake 3.10 will include a FindHDF5.cmake with some fixes that are especially relevant on Windows. See the merge requests [1] and [2]. I think the commit [3] is the one that fixes the problems you are facing. Maybe you can just copy the most recent FindHDF5.cmake file from the CMake repository into the FLANN modules directory from your portfile.
[1] https://gitlab.kitware.com/cmake/cmake/merge_requests/1023
[2] https://gitlab.kitware.com/cmake/cmake/merge_requests/1064/diffs
[3] https://gitlab.kitware.com/krthie/cmake/commit/fc9828448d54a63b7fc09ee044b6b0246632e011

@albertziegenhagel -DHDF5_NO_FIND_PACKAGE_CONFIG_FILE=ON works like magic. I will submit a PR shortly


Update domains-admin-takeover.md

Microsoft has changed the redirection for powerbi.com so the link is no longer valid. This direct link still works.
https://powerbi.microsoft.com/en-us/

#sign-off

Learn Build status updates of commit fc2baaf:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

articles/active-directory/enterprise-users/domains-admin-takeover.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching the learn.microsoft.com contributor guidesPost your question in the Learn support channel

@billmath
Can you open a PR in the private repo to update this article's author metadata to reflect the correct author? Thanks!
Merging now.


Update Client.php

bugfix if proxy setting HTTP_X_FORWARDED_HOST and HTTP_X_FORWARDED_PORT both

Please see #154, 0af573c2da3f6b6eb79caa62f0d6c05e9b752d98. I will look into the specs later but it will be rare to "revert" this behavior.


Improve type safety and remove the need for explicit destructor calls

Operator >> of Event is not type safe., meaning that "event >> pData;" throws if pData is not a pointer to the type of the object in event's storage.
 The object will be destructed automatically when the next object is constructed into the storage.

Operator >> of Event is not type safe., meaning that "event >> pData;" throws if pData is not a pointer to the type of the object in event's storage.
 The object will be destructed automatically when the next object is constructed into the storage.


Added Library Utility Commands

This PR adds Library Utility Commands to the Groovy Wrapper by creating a new Groovy script.
groovyw lib get Name ---> retrieves 'Name' from MovingBlocks into the 'libs' folder.
groovyw lib create Name ---> adds a blank library 'Name' to the 'libs' folder.

Can one of the admins please verify this patch?

Same as the other groovyw command, I'm going to approve it but hold off on merging it til Cervator confirms. In case there is a slight issue with it.

Thanks! @jellysnake

Superseded / merged via #3263 - thanks! :-)


Static site generation - broken?

When using docus to generate static site, the site generates fine and the content navigation works fine. But on refreshing on a route (or visiting some URL directly), shows 404 page.

Tested on the npm run preview and Cloudflare Pages. Both are showing this error.

Seems to be the deployment issue. Closing.

Have the same issue here.
What did you do to have a working deployment ?

It was a component issue. Actually, the component was using useAsyncData function which was throwing an error when npm run generate on ci/cd pipeline. So the exact route was not getting generated


[Content item horizontal - with thumbnail] Create the functional specs for this new variant

User Story

As a [user role below]:
DDS developer

I need to:
have the Content item horizontal - with thumbnail functional specs

so that I can:
so that I can properly code the Content item horizontal - with thumbnail component that meets the Design functions and intent

Additional information

Overview and scope of the engineering work should be included in the linked epic (#6110 )
This component is designed by AEM.  Pavol Prok is the designer.

Acceptance criteria

[ ] Documented Content item horizontal - with thumbnail functional specifications
[ ] Sent and/or presented the specs to Design and Engineering for their review and comments
[ ] Comment is added with link to functional specs

Here is the link for the functional specs: https://github.com/carbon-design-system/carbon-for-ibm-dotcom-website/wiki/Content-item-horizontal


Fixed error message on invalid whisper_output_mode

Pull request checklist:

[x] CHANGELOG.md was updated, if applicable
[x] Documentation in docs/ or install-docs/ was updated, if applicable
[x] I have tested all changes

It's time!

Thank you!


Can i separate the value from the value displayed in the text of progressValue and the circular progress?

There's a way to separate the value from the value displayed in the text of progressValue and the circular progress ?

Wondering this as well


[WIP]nixos/firejail:added program.firejail.firecfg option

Motivation for this change
The firecfg program already knows how to wrap the correct comands and desktop files
Things done
Still work in progress
nixos-rebuild build -I nixpkgs=.
building Nix...
building the system configuration...
these derivations will be built:
  /nix/store/j69786fjsxpgv8lbfcck72ar2lgppar1-system-path.drv
  /nix/store/c0496dynbfbjnhwvg8gnk1v5565s7spp-dbus-1.drv
  /nix/store/q6nk3hx6jilcyrqfzkxlirw9x5y8r433-unit-dbus.service.drv
  /nix/store/j86vgqzw8vlr7cqg2j79shczprxl2w68-user-units.drv
  /nix/store/9saqvr99mcbg2s1z8ppcjzfa53b7827z-unit-dbus.service.drv
  /nix/store/d9s25xipg5cszpm2dqzmm44n72ybjnvp-unit-polkit.service.drv
  /nix/store/v1dhqmyk7vpjwf96pwzzg2bc98kckgfr-unit-systemd-fsck-.service.drv
  /nix/store/n7i2b9bgbr50ns9g31dn746wjlsl5qh6-system-units.drv
  /nix/store/v5pl243kw0by169dd0cslgq56p6wy2w8-etc.drv
  /nix/store/561i4mbfabqrlr3ylc813zpz0pqnnd95-nixos-system-nixos-19.09.git.9cc8f88.drv
building '/nix/store/j69786fjsxpgv8lbfcck72ar2lgppar1-system-path.drv'...
created 6818 symlinks in user environment
cp: -r not specified; omitting directory '/nix/store/9p6z02r5bmkzqz87fkbh0llj3iwdynrr-system-path'
builder for '/nix/store/j69786fjsxpgv8lbfcck72ar2lgppar1-system-path.drv' failed with exit code 1
cannot build derivation '/nix/store/c0496dynbfbjnhwvg8gnk1v5565s7spp-dbus-1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/d9s25xipg5cszpm2dqzmm44n72ybjnvp-unit-polkit.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v1dhqmyk7vpjwf96pwzzg2bc98kckgfr-unit-systemd-fsck-.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/9saqvr99mcbg2s1z8ppcjzfa53b7827z-unit-dbus.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/q6nk3hx6jilcyrqfzkxlirw9x5y8r433-unit-dbus.service.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/n7i2b9bgbr50ns9g31dn746wjlsl5qh6-system-units.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/j86vgqzw8vlr7cqg2j79shczprxl2w68-user-units.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/v5pl243kw0by169dd0cslgq56p6wy2w8-etc.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/561i4mbfabqrlr3ylc813zpz0pqnnd95-nixos-system-nixos-19.09.git.9cc8f88.drv': 2 dependencies couldn't be built
error: build of '/nix/store/561i4mbfabqrlr3ylc813zpz0pqnnd95-nixos-system-nixos-19.09.git.9cc8f88.drv' failed

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on Nix community. There might be relevant details there:
https://discourse.nixos.org/t/how-to-chroot-in-builder/3408/1


Added NSDate support

Not sure if you want this, but NSDate is a supported type when saving to files, so it can be added easy enough.
Added some examples to the tests, seems to work.

This is great, thanks! Appreciate you adding the Double tests as well.

What happened to (NS)Date support? I can't find it in the docs / code any more..


archilogic light setup component

rebuild the light setup from the editor as an aframe component

to do:

design API for lighting component
decide on name (lighting vs. io3d-lighting)

for experimenting i created branch lighting-component with a new component called lighting using code from the editor.

I changed component to use a-frame lights - so users can edit them in the inspector
also fixes shadows and specular on materials
A-Frame standard

New default setup:

morning:

night:

proposal for using component on scene element:
<a-scene lighting>
</a-scene>

<a-scene io3d-lighting>
</a-scene>

Previous setup was doing no good to interiors -  so new default now tested with basic models and premium models
A-Frame - standard:

new default:

A-Frame - standard:

new default:

A-Frame standard:

new default:

it's so much nicer now!!
here is some inspirations for future presets:
"emotionalized" colors:

morning light:


Application structure and relationships

@avraham1992

Did you check if the project is running and working?
You should squash your commits
You should fix Flake8 errors

@mgold1234 @natifridman @kobihk Can you please approve that's new folder and apps structure?

Commits should be squashed.
I would add to the description an explanation about what's going on in here.
Maybe something like
"Created Django apps [head]

Created 3 Django apps: Tasks, Manager, Employees.
Note: most of the files are auto-generated."
3. In regard to the flake8 errors - when fixing it, I think it will be better to add some dummy code (rather than comment out the lines)

please fix all flake8 errors:
./Manager/models.py:1:1: F401 'django.db.models' imported but unused
./Manager/views.py:1:1: F401 'django.shortcuts.render' imported but unused
./Manager/tests.py:1:1: F401 'django.test.TestCase' imported but unused
./Manager/admin.py:1:1: F401 'django.contrib.admin' imported but unused
./Task/models.py:1:1: F401 'django.db.models' imported but unused
./Task/views.py:1:1: F401 'django.shortcuts.render' imported but unused
./Task/tests.py:1:1: F401 'django.test.TestCase' imported but unused
./Task/admin.py:1:1: F401 'django.contrib.admin' imported but unused
./Employees/models.py:1:1: F401 'django.db.models' imported but unused
./Employees/views.py:1:1: F401 'django.shortcuts.render' imported but unused
./Employees/tests.py:1:1: F401 'django.test.TestCase' imported but unused
./Employees/admin.py:1:1: F401 'django.contrib.admin' imported but unused
Error: Process completed with exit code 1.

I think that we should also add automation for the migrations.


Has issues matching $foo:expr on "var x = ..."

I wrote a simple anonymous function c#-like syntax:
// define c#-style anonymous function syntax
macro => {
	case infix { () | _ { $body:($line:expr (;) ...) } } => {
		return #{ function () { $body } };
	}
}

This will match
var x = () => { y = 5; };

just fine.  But it will not match
var x = () => { var y = 5; };

Leaving off the :expr doesn't help, either.

That's because a variable declaration is not an expression. You probably want:
macro => {
    case infix { () | _ { $body ...} } => {
        return #{ function () { $body ... } };
    }
}

That did the trick...
The following also works:
macro => {
    case infix { () | _ { $body ...} } => {
        return #{ function () { $body:($line ...) } };
    }
}

But this doesn't:
macro => {
    case infix { () | _ { $body ...} } => {
        return #{ function () { $body:($line (;) ...) } };
    }
}

Should having a semicolon in there still work?

The pattern $line (;) ... matches individual tokens separated by ; so something like var ; y ; = ; 5 not the entire line.

I'm mass closing issues due to the release of 1.0 obviating lots of bugs. If you feel this issue is something we still need to address feel free to reopen.


[Bug] select2_multiple field send value null

Bug report
The select2_multiple field send option "-" as null
What I did
Created this field:
$this->crud->addField([
            'label'     => trans('crud.familyProduct.familyProduct'),
            'type'      => 'select2_multiple',
            'name'      => 'familyProducts',
            'entity'    => 'familyProducts',
            'model'     => "App\Models\FamilyProduct",
            'attribute' => 'name',
            'pivot'     => true,
            'select_all' => true,
            'options'   => (function ($query) {
                return $query->orderBy('name', 'ASC')->get();
            }),
            'tab' => trans('crud.service.head'),
       ]);

Then the "-" option can be selected:

What I expected to happen
The "-" option cannot be selected
What happened
Select the "-" option and an array with null value is sent to the request
"familyProducts" => array:2 [[▼]()
        0 => null
        1 => "13"
      ]

And when save:

What I've already tried to fix it
Im trying to validate in the request or a mutator
Is it a bug in the latest version of Backpack?
yes

Hey @aberaldo, thanks for the report.
This is already fixed in v5 of Backpack, that happened to be lauched today. Please read the upgrade guide it has some breaking changes, but it should not take much time to upgrade.
I will be closing this, let me know if you have any problems with the upgrade.
Thanks,
Pedro


Please add a license file

I'd like to add this to awesome-zsh-plugins, but it doesn't have a license file.
Please add a license file - if you don't have one in mind,  I recommend using choosealicense.com to help choose an appropriate one.
Thanks!

@unixorn Thank you for your recommendation it was very useful, I have already added a license.
If you can add this repository that would be great, thanks!


Fix ws errors

Fix white space errors in comment block section of RunTest(),
introduced in fb8ef0ca.

hope it is ok to have this pr block our precious time.

@ukos-git Sure! Whitespace clean code is always appreciated. Looks like your vim syntax foo found that ;)

I already made a new release today so unfortunately this has to sit in master for now.

I had Plugin 'ntpeters/vim-better-whitespace' disabled in my old VM because vim had performance issues and now enabled it again.


fix Chinese system input in iOS 13.2

resolve https://github.com/microsoft/monaco-editor/issues/1663

@rebornix I've upgraded my implementation.
compositionend  event will be ignored when  composition ended.

Thanks!


External Site Warning

Building on the framework started in #780, build out the external link redirect page. This should verify the user is happy to visit the external site. If confirmed, take the user to the URL.

 Questionnaire Series


Roadmap for Remixicon

Numerous designers utilizing Remix Icons for their active projects often relay requests when they encounter issues due to current limitations in the iconography. As we aim to deliver our designs promptly to developers for implementation, we are eager to receive new iconography updates. Currently, we're uncertain about the timing of these updates, and we're left waiting for the next Remix icon release without any knowledge of its anticipated date or target month. Therefore, we request a shared roadmap plan to provide at least a rough idea of when updates might be expected. While we don't need an exact date, a targeted month would greatly assist us.
Moreover, I believe that many organizations might be willing to pay a certain fee if their iconography needs were prioritized for the next release. This could potentially generate more profit for the project. I trust that this suggestion could serve as additional motivation for your team. We genuinely appreciate the excellent work you do in supporting designers.

Very good suggestion, but at this stage I am unable to publish a Roadmap. However, there are also some other short-term solutions:

Generally speaking, I will prioritize designing icons with the Icon Request tag added to their requests;
I will try to release at least one version every month;
For requests that are already in progress, I will try to add an in progress label;
In addition, I will work hard to improve the Design Guideline so that the community can contribute together. This would be more efficient than me designing alone;
Finally, you are our old friend. If there are any urgent icon needs, please let me know specifically and if I have time available, I will consider them as a priority.

I agree that design guidelines would be very helpful for other designers who want to contribute to this project. I'm not sure what kind of documents you're planning for the guidelines, but I know that many designers are not familiar with how to design icons. They may only be familiar with using icon libraries. I suggest that the guidelines include instructions or video tutorials on how to design icons in Figma or Ai. This would be helpful for the designers, and it would also help us to improve our release process.
I'm very excited about this project, and I would love to contribute. Of course, you're not alone in this journey. I'm sure there are many other people who are also eager to help.


Automation example - RedMart re-adding cancelled order

Whenever there is a need to reschedule order on RedMart, there is a need to cancel order and then manually add back the items one by one to create a new order.
My wife is very frustrated with that, because in between clicks there are so much waiting time, and cannot Ctrl + click to open in new tabs. So I wrote below automation script in 5 minutes and automate that for her. Share here as well!
https://my.lazada.sg/customer/order/view/?tradeOrderId=123456789&spm=abcde.order_list.list_order_number.1#

echo 'Enter your credentials to log in to RedMart'
wait 10 seconds

for item from 1 to 32
{
    click (//*[@class="order-item"])[`item`]//*[@class="item-pic"]
    click ADD TO CART
    wait 3
    chrome.back();
    wait 3
}

Adding on, wait is usually not necessary as there is auto-wait for UI elements to appear until timeout.
For above, it is to ensure that the click has been processed by the webapp (seems to have some lag) before proceeding, and that previous page items have been fully loaded before proceeding.


the dotfiles dont work anymore

I tried installing and the dotfiles was installed successfully but they don't work anymore.
When I login i get the default awesome with a giant error message.

You have to download the modules by using the terminal. Try the following commands:
cd ~/.config/awesome git clone https://github.com/andOrlando/color git clone https://github.com/andOrlando/bling git clone https://github.com/andOrlando/rubato

Hi This repo "git clone https://github.com/andOrlando/bling" doesn't exist anymore. I downloaded other two repos to my ~/.config/awesome directory. it still doesn't work.

Closing this issue as I dont use this anymore

Closing this


[dft] - Remove output scan mux from prim_clk_div

The prim clock divider contains a scan mux. Currently clk_o = clk_i during scan.
This is bad practice since all at-speed checks should be performed with the functional clk frequency.
DC adds OCC at the divider's output to switch between the functional clock (capture) and the slow ATE clock (shift), so the mux can be removed.

this issue should be fixed. Please re-open if you still see problems (or open a new one).


hasValidAccessToken is false while hasValidIdToken is true

Using this library with OKTA, it is going well, except that the access token is not valid (per the library) while the Id token is valid.
I don't know why the access token is considered invalid.
Any suggestions?

Make sure your issuer is the default authorization server, for example https://dev-158606.oktapreview.com/oauth2/default, not https://dev-158606.oktapreview.com, and token validation should work.

Thanks Matt. It looks like it's an issue that the library (storeAccessTokenResponse) is using the expires_in query string param being returned from OKTA and calculating the Epoch time instead of using the exp claim in the access token, they don't line up. I'm still pretty new to integrating OKTA so I could be missing something.

As a workaround, you could try using Okta's Angular SDK https://developer.okta.com/quickstart/#/angular/nodejs/express

I actually used it first. I was switching to this library for the silent refresh

the OKTA SDK works great BTW

okta-auth-js supports silent refresh, I don't think Okta has done a good job of exposing it to developers or what is happening behind the scenes (we might be refreshing the token silently behind the scenes).  I've opened https://github.com/okta/okta-oidc-js/issues/74

@GlennDOrr okta-angular supports silent refresh out-of-the-box. Behind the scenes, we use okta-auth-js's tokenManager which keeps everything fresh: https://github.com/okta/okta-oidc-js/blob/master/packages/okta-angular/src/okta/okta.service.ts#L74

Hi @GlennDOrr,
according to the specs [1] it's recommended (bot not required) that the auth server provides the expires_in field. On the other side, directly looking into the token at the client side would be a worse practice from an OAuth 2 and interop perspective b/c by definition the access_token is opaque to the client. Even though in this very case it might by readable, it can be everything e. g. just some kind of id.
To solve this issue, you will find a new config property fallbackAccessTokenExpirationTimeInSec where you can set the tokens lifetime in seconds, e. g. 3600 for one hour. This value is used, when expires_in is not provided.
Does this solve your issue?
Wishes,
Manfred
[1] https://tools.ietf.org/html/rfc6749

Oh, btw, the new version ships in some hours.

Closing this for now, but feel free to reopen it in case.


add MS teams as notification type

part one of three PRs that would add the enhancement of allowing healthcheck-manager to send notifications to Microsoft Teams channels.

Thank @MagnusRef. Looks great. Can you please push to "dev" branch instead of "main"
Essentially "dev" is used as development branch. When new release is cut, it is cut from "dev" and then "dev" is merged to "main".
Thank you

here you go @gianlucam76. will branch from dev branch in the future then.


[MINOR][SQL] Document AnalysisOnlyCommand

What changes were proposed in this pull request?
This patch adds more documentation to AnalysisOnlyCommand, since it's not obvious why it's needed or how it works.
Why are the changes needed?
See above.
Does this PR introduce any user-facing change?
No
How was this patch tested?
N/A

cc @cloud-fan @imback82

thanks, merging to master!


withAttr should be withAttribute to align with Swift verbose naming conventions

Apple's argument for this one lies in AutoComplete. It's actually a good argument which also encourages legibility.

I agree - if I remember correctly, I added that method before some of the naming conventions were even added (pre Swift 1.0 release). I created #84 to track API changes, so it'd be nice to get this added in prior to the 4.0 release and deprecate the old method.
By the way, I'd welcome any other API thoughts or suggestions you might have!

FYI, this was resolved with 4.0.0 and #133. Thanks!


Fixed the import issue for Feedback.wrapForTap

There was an issue where in the Feedback.wrapForTap the Feedback was not imported
Fixed that issue by importing import 'package:flutter/src/material/feedback.dart';

accept this please

When using Flutter 3.22.x you use version 3.0.2+8 of this package which has the feedback.dart import.
Version 3.0.3+9 of this package now has a Flutter version constraint of minimum 3.24.0.


Add catching of record=True

Ref: #6
Ref: https://github.com/python/mypy/issues/9010
This is basically an extension of what was implemented for #6. With record=True user can access special dictionary inside of a template. record=False basically means opposite so user should be told that he is doing the wrong thing for both of cases;
logger.info('{record["msg"]}') # bad
logger.opt(record=True).info('{record["msg"]}') # ok

@Delgan  is following possible
logger.opt(record=True).info('record={record}', record=lambda : {})

?

@Delgan Nope, it raises an error.
>>> from loguru import logger
>>> logger.opt(record=True).info('record={record}', record=lambda : {})
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "loguru/_logger.py", line 1971, in info
    __self._log("INFO", None, False, __self._options, __message, args, kwargs)
  File "loguru/_logger.py", line 1934, in _log
    raise TypeError(
TypeError: The message can't be formatted: 'record' shall not be used as a keyword argument while logger has been configured with '.opt(record=True)'


Add Spatial Sorting

Add support for sorting spatial types, also add sort by distance

Related? Sort by distance #1461

this could use the label "Area: Spatial"


PAINT import pipeline

Hi @cmungall
This is an example of a protein that is not in the current of the PAINT GAF file, but is in AmiGO:
PomBase:SPAC694.02
Can I expect it to go away at the next data release on May 1st?
Thanks, Pascale

MGI is not contributing to PAINT annotations until they can be imported into MGI.  Waiting for pipeline to be fixed.  Is there any sense of when this will be accomplished?

Hi @judyblake  - I don't understand what you mean.
I thought the pipeline was fixed.
Pascale

I'm at a meeting all this week - please file this in the go-site tracker and tag the relevant people thanks


HBASE-22943 Various procedures should not cache log trace level

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
48
Docker mode activated.

_ Prechecks _

+1
dupname
0
No case conflicting files found.

+1
hbaseanti
0
Patch does not have any anti-patterns.

+1
@author
0
The patch does not contain any @author tags.

-0
test4tests
0
The patch doesn't appear to include any new or modified tests.  Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1
mvninstall
381
master passed

+1
compile
59
master passed

+1
checkstyle
84
master passed

+1
shadedjars
297
branch has no errors when building our shaded downstream artifacts.

+1
javadoc
42
master passed

0
spotbugs
271
Used deprecated FindBugs config; considering switching to SpotBugs.

+1
findbugs
269
master passed

_ Patch Compile Tests _

+1
mvninstall
353
the patch passed

+1
compile
58
the patch passed

+1
javac
58
the patch passed

+1
checkstyle
76
the patch passed

+1
whitespace
0
The patch has no whitespace issues.

+1
shadedjars
270
patch has no errors when building our shaded downstream artifacts.

+1
hadoopcheck
944
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

+1
javadoc
38
the patch passed

+1
findbugs
246
the patch passed

_ Other Tests _

+1
unit
9613
hbase-server in the patch passed.

+1
asflicense
31
The patch does not generate ASF License warnings.

13208

Subsystem
Report/Notes

Docker
Client=19.03.1 Server=19.03.1 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-557/1/artifact/out/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/557

Optional Tests
dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile

uname
Linux 910f604e2f9f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 GNU/Linux

Build tool
maven

Personality
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-557/out/precommit/personality/provided.sh

git revision
master / 56980fb097

Default Java
1.8.0_181

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-557/1/testReport/

Max. process+thread count
4805 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-557/1/console

versions
git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

0
reexec
0
Docker mode activated.

-1
patch
8
https://github.com/apache/hbase/pull/557 does not apply to master. Rebase required? Wrong Branch? See https://yetus.apache.org/documentation/in-progress/precommit-patchnames for help.

Subsystem
Report/Notes

GITHUB PR
https://github.com/apache/hbase/pull/557

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-557/2/console

versions
git=2.17.1

Powered by
Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.


Support KVM storage implementations controlling logical/physical block io size

Description
This PR allows a given KVM storage implementation to decide if it wants to override the Libvirt disk XML's physical/logical IO size.  For now all in-tree implementations will default to not using this.
In the future it may also be possible to extend the disk offerings to provide more granular control.
Note that using a logical sector size other than 512 would require the image to be built to support it, so this may be better suited as a property of the image at some point. Physical sector size can be changed as desired. This at least puts the XML definitions in place as a start.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[x] New feature (non-breaking change which adds functionality)
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale

[ ] Major
[x] Minor

Screenshots (if appropriate):
How Has This Been Tested?
Tested locally by modifying an in-tree plugin, but didn't commit that change to avoid changing upstream behavior.
Also added unit test to test XML generation.

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8814

@blueorangutan package

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8816

@blueorangutan test

[SF] Trillian test result (tid-9347)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 50548 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8724-t9347-kvm-centos7.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

Hi @mlsorensen can this be targeted for 4.19.1?


Light/illuminance sensors

Describe the bug
in 0.2.0, you have changed the following

This means you have removed the "light" output, which is used for some other Xiaomi devices. The "problem" is that some Xiaomi sensors use the illuminance sensor for a binary sensor (light/dark), with 100 being light and 0 being dark.
In BLE monitor, I had a large table in constants.py in which I was able to tell which device has which sensor, so e.g. the MiFlora would not show a light sensor, as I had defined it to only use illuminance (lux) sensor.
I think we should include this device specific output in the parser, I e.g. have already done that with the button and switch output, as Xiaomi uses the same "switch" data for different type of devices.
I will try to reproduce which devices use "illuminance" sensors and which uses "light (dark/light)" binary sensors.
To Reproduce
Steps to reproduce the behavior:
Additional context
Add any other context about the problem here.

I am thinking about adding a update_predefined_binary_sensor call once my motion sensors I ordered show up and I have a test case

Great, I thing we will definitely need that for xiaomi-ble, as xiaomi has several switch , opening (open/closed), moisture (wet/dry), motion (motion/no motion) binary sensors, etc. Just check the list in const.py of ble monitor, there are about 10
I made this note/issue to not forget to re-add this light sensor, as it was now removed from the code, making it hard remember to re-add it later, when we start with the binary sensors. I guess it is better to leave the old result dictionary output for this light sensor in the code, till we are adding the binary sensors. For now, we should only remove the illuminance sensor, as we use the device.update_predefined_sensor now). Will fix that.
Note to myself.
Light binary sensor is used by

MCCGQ02HL
MJYD02YL
RTCGQ02LM
CGPR1

Illuminance lux sensor is used by

HHCCJCY01
GCLS002
CGPR1

So CGPR1 uses both, the others use only one.
Next step, I will look which device uses which data type for illuminance/light.
Available data types
0x000F (motion, illuminance and light)
0x1007 (Illuminance & light)
0x1018 (light)
I remember that there is one devices that uses two data types for light or illuminance.

Ah if I had known that I would have left it in the unhandled dict, I thought it was some kind of convenience field that we wouldn't need now there was a proper entity. Yes, we should add it back to unhandled dict.
So far everything that was supported by the old code is still there (apart from this) and (apart from this) I'm only removing what can be handled by the new code. Did indeed do this exactly so we wouldn't forget what still needed porting.
Will get started on binary devices as soon as the framework is in place.

Created a PR to bring it back (and added the illuminance sensor for CGPR1), see #5
Xiaomi (and others) tend to misuse the light/illuminance. I fixed that by using the list in const.py to tell which devices uses what, but we don't have that anymore now. So we should bring this intelligence into the parser. When you start with the binary sensors, it becomes really tricky, especially at the buttons, remotes and switches.
I will check which device needs what tomorrow for illuminance and light, to start with.

With binary stuff so they normally advertise an off value and then when triggered give an on value? How long do they show as on?
Or do they only send an "on" value when something (like motion) is detected, and if there is no broadcast there is no motion?
(If it's a stateless event we will need to fake the binary sensor transitioning from off to on and back to off, possibly with a timeout).

For light it is more a dark/light indicator, it is either light (100 or 256) or dark (0). I translated this to a binary light sensor in HA. But there is also and data type that combines it with motion.
Motion is a more complicated one, as some sensors send “on” when motion detected and “ off” messages after a certain time. But others do only send “on”, they never send “off”. I therefore have added a configuration option with a motion timer, when motion is detected, motion timer = 1 is parsed and the countdown timer is restarted. After the set time, it is turned off. We will have to make something similar, I guess.

Probably a good one for @bdraco to have in mind when designing the update_predefined_binary_sensor API. Right now theres nothing to attach a timer to (we don't currently do any event loop stuff).

Ok, I made an overview of which sensor uses what data type. I distinguish between a illuminance sensor (= lux reading) and a light sensor (= binary dark/light sensor)
HHCCJCY01

illuminance sensor 0x1007

GCLS002

illuminance sensor 0x1007

CGPR1

illuminance sensor 0x000F In BLE monitor, CGPR1 also has a binary light sensor based on lux < 100 = dark, lux >= 100 = light. Not sure why we did that, but I guess this isn't really needed. Each measurement is movement

MJYD02YL

light sensor 0x000F 1 = dark, 100 = light, each message means movement
light sensor 0x1007 100 = light, else dark (I think dark is 1 or 0)

RTCGQ02LM

light sensor 0x000F 0 = dark, 256 = light, each message means movement
light sensor 0x1018 0 = dark, 1 = light

MCCGQ02HL

light sensor, either 0x1007 or 0x1018 not sure which one

As you can see, the data types are often used by one device as a lux sensor, and for other devices as a light sensor.
And one device can use two different messages for light/lux, one is with movement, the other just light/lux
So, if we translate the above to the data types in the xiaomi-ble parser, we get
0x000F

illuminance sensor (and motion sensor) for CGPR1
light sensor (and motion sensor) for MJYD02YL (1 = dark, 100 = light)
light sensor (and motion sensor) for RTCGQ02LM (0 = dark, 256 = light)

0x1007

illuminance sensor for HHCCJCY01
illuminance sensor for GCLS002
light sensor for MJYD02YL (100 = light, else dark)
light sensor for MCCGQ02HL (100 = light, else dark) (could also use 0x1018)

0x1018

light sensor for RTCGQ02LM (0 = dark, 1 = light)
light sensor for MCCGQ02HL  (0 = dark, 1 = light) (could also use 0x1007)

I'll update the parser in a minute, such that each device only give the output it should create a sensor for.

I guess we can close this issue.


COBOL Line Comments are no longer grayed out.

With the recent update, the line comments that start with a * are no longer grayed out.

I will fix it tonight... Sorry about this
On Mon, 11 Jun 2018, 14:31 Andy Crofford<EMAIL_ADDRESS>wrote:

With the recent update, the line comments that start with a * are no
longer grayed out.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10, or mute the thread
https://github.com/notifications/unsubscribe-auth/AFtrGIKqmsDTpA9zsMtm5vJ5aC_INfwfks5t7nEUgaJpZM4Uiswt
.

Just curious, why was this closed?

Because I have just fixed it :-)
On 11 June 2018 at 18:33, Andy Crofford<EMAIL_ADDRESS>wrote:

Just curious, why was this closed?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10#issuecomment-396322965,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFtrGO_FYsWYtiUPb7ZV3uno2EZe-c66ks5t7qn1gaJpZM4Uiswt
.

--
Stephen Gennard
<EMAIL_ADDRESS>

Thank you for fixing this so quickly. I really appreciate it.
I have another question about the extension but do not think it is a bug so I do not want to open an issue. Is there some other way to contact you?

I am on 1.9.7 and the comments are still not grayed out for me.

Can you give me an example, platform and the theme you are using as works
in examples I commonly use eg;
On 12 June 2018 at 11:59, Andy Crofford<EMAIL_ADDRESS>wrote:

I am on 1.9.7 and the comments are still not grayed out for me.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10#issuecomment-396550320,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFtrGFBHZT2yy1ZRfVaTdfQTuIVX9d01ks5t758igaJpZM4Uiswt
.

--
Stephen Gennard
<EMAIL_ADDRESS>

I am using the Monokai theme on Windows 7.

Thanks, I've reproduced it.
I will at this tonight, a quick workaround is to use *>
fyi -I am not handling * in column 'a' correctly.
On 12 June 2018 at 12:31, Andy Crofford<EMAIL_ADDRESS>wrote:

I am using the Monokai theme on Windows 7.
[image: 6-12-2018 6-29-57 am]
https://user-images.githubusercontent.com/12456537/41287969-3c597f7e-6e0a-11e8-9d9c-445cbe82a3ec.png
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10#issuecomment-396557677,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFtrGIs3urerhphUUTGCQCLdk_n1GNvbks5t76aigaJpZM4Uiswt
.

--
Stephen Gennard
<EMAIL_ADDRESS>

testcase:
000100 IDENTIFICATION DIVISION.                                         000100
000200 PROGRAM-ID. HELLO.                                               000101
000250* THIS IS A COMMENT LINE                                          000102
000300 PROCEDURE DIVISION.                                              000103
000350 A000-FIRST-PARA.                                                 000104
         *> Inline comment
      C C style comment
      * no line number comment
* this line should also be a comment
000400     DISPLAY “Coding Sheet”.                                      000105
000500 STOP RUN.                                                        000106

Thank you for looking in to this. As a Cobol developer this extension is the best. Without it I would have to use some old/crappy text editor my company has.

000100 IDENTIFICATION DIVISION.                                         000100
000200 PROGRAM-ID. HELLO.                                               000101
000250* THIS IS A COMMENT LINE                                          000102
000300 PROCEDURE DIVISION.                                              000103
000350 A000-FIRST-PARA.                                                 000104
         *> Inline comment
      C C style comment
      * no line number comment

* this line should also be a comment
 * this should not be a comment
  * or this
   * or this
    * or this
     * or thhis
      * this is okay

000400     DISPLAY "Coding Sheet"                                       000105
000500 STOP RUN.                                                        000106

Is it now okay for you?

My apologies for not responding sooner. Yes, it is working as expected now.
Thank you for resolving this so quickly.
I have one other question. We use variable names like the following:
this-is-a-variable.
In Sublime text it would recognize the entire thing as a word and let me
select from the suggestions popup. With Code it treats it as separate
words, so "this", "is", "a", "variable" show up as suggestions. Is there
any way to have it the same as how Sublime handled it?
Thanks,
Andy
On Wed, Jun 13, 2018 at 1:47 PM, spgennard<EMAIL_ADDRESS>wrote:

Is it now okay for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10#issuecomment-397045420,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL4SWYth-j7QgHzvjPJTMuzPNV3IsZCMks5t8V5KgaJpZM4Uiswt
.

--
Thanks,
Andy Crofford

Yes, I've seen this and I find it annoying, so I have a look and see what I
can do.
On 14 June 2018 at 16:35, Andy Crofford<EMAIL_ADDRESS>wrote:

My apologies for not responding sooner. Yes, it is working as expected now.
Thank you for resolving this so quickly.
I have one other question. We use variable names like the following:
this-is-a-variable.
In Sublime text it would recognize the entire thing as a word and let me
select from the suggestions popup. With Code it treats it as separate
words, so "this", "is", "a", "variable" show up as suggestions. Is there
any way to have it the same as how Sublime handled it?
Thanks,
Andy
On Wed, Jun 13, 2018 at 1:47 PM, spgennard<EMAIL_ADDRESS>wrote:

Is it now okay for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/spgennard/vscode_cobol/issues/10#
issuecomment-397045420>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AL4SWYth-
j7QgHzvjPJTMuzPNV3IsZCMks5t8V5KgaJpZM4Uiswt>
.

--
Thanks,
Andy Crofford
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10#issuecomment-397339258,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFtrGHtn9JqqklK05v_mcPDoWpv7T6cTks5t8oK3gaJpZM4Uiswt
.

--
Stephen Gennard
<EMAIL_ADDRESS>

try it with v2.1
On 14 June 2018 at 21:34, Stephen Gennard<EMAIL_ADDRESS>wrote:

Yes, I've seen this and I find it annoying, so I have a look and see what
I can do.
On 14 June 2018 at 16:35, Andy Crofford<EMAIL_ADDRESS>wrote:

My apologies for not responding sooner. Yes, it is working as expected
now.
Thank you for resolving this so quickly.
I have one other question. We use variable names like the following:
this-is-a-variable.
In Sublime text it would recognize the entire thing as a word and let me
select from the suggestions popup. With Code it treats it as separate
words, so "this", "is", "a", "variable" show up as suggestions. Is there
any way to have it the same as how Sublime handled it?
Thanks,
Andy
On Wed, Jun 13, 2018 at 1:47 PM, spgennard<EMAIL_ADDRESS>wrote:

Is it now okay for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/spgennard/vscode_cobol/issues/10#issueco
mment-397045420>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AL4SWYth-
j7QgHzvjPJTMuzPNV3IsZCMks5t8V5KgaJpZM4Uiswt>
.

--
Thanks,
Andy Crofford
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10#issuecomment-397339258,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFtrGHtn9JqqklK05v_mcPDoWpv7T6cTks5t8oK3gaJpZM4Uiswt
.

 Thank you so much for adding this, you have
no idea how much better you have made my life.
On Thu, Jun 14, 2018 at 4:48 PM, spgennard<EMAIL_ADDRESS>wrote:

try it with v2.1
On 14 June 2018 at 21:34, Stephen Gennard<EMAIL_ADDRESS>wrote:

Yes, I've seen this and I find it annoying, so I have a look and see what
I can do.
On 14 June 2018 at 16:35, Andy Crofford<EMAIL_ADDRESS>wrote:

My apologies for not responding sooner. Yes, it is working as expected
now.
Thank you for resolving this so quickly.
I have one other question. We use variable names like the following:
this-is-a-variable.
In Sublime text it would recognize the entire thing as a word and let me
select from the suggestions popup. With Code it treats it as separate
words, so "this", "is", "a", "variable" show up as suggestions. Is there
any way to have it the same as how Sublime handled it?
Thanks,
Andy
On Wed, Jun 13, 2018 at 1:47 PM, spgennard<EMAIL_ADDRESS>wrote:

Is it now okay for you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/spgennard/vscode_cobol/issues/10#issueco
mment-397045420>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AL4SWYth-
j7QgHzvjPJTMuzPNV3IsZCMks5t8V5KgaJpZM4Uiswt>
.

--
Thanks,
Andy Crofford
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<https://github.com/spgennard/vscode_cobol/issues/10#
issuecomment-397339258>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFtrGHtn9JqqklK05v_
mcPDoWpv7T6cTks5t8oK3gaJpZM4Uiswt>
.

--
Stephen Gennard
<EMAIL_ADDRESS>
--
Stephen Gennard
<EMAIL_ADDRESS>—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/spgennard/vscode_cobol/issues/10#issuecomment-397448934,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AL4SWYeFr5bsapdRavlSVbcDutqrZg6iks5t8toigaJpZM4Uiswt
.

--
Thanks,
Andy Crofford


Feature Request: Footer area

Would it be possible to add an optional footer area?  basically where it says .wb-body{ margin } in the picture? The use case would be to have a space to easily add additional nav elements or a status bar without having to build a more complicated layout inside the wb-body yourself.

Such a footer area is theoretically a part of current wb-body (more than a part of the windows border), it just needs the same window background-color to looks like a part of the window, technically we divide wb-body into segments. Then we also need to take into account "header" and left/right sidebars, because depending on the scenario the additional nav bar might not being placed at the bottom. Allthough the footer element is probably the most common.
The best is to simply add an wrapper container to the body element of the window which includes the footer (absolute position) and a "new" body (also absolute position) and add overflow: hidden to the original window body and add overflow: auto to your new body. I will add such a workaround in the documentation (demo page) soon.


imgts clears GCP image labels when updating

While examining a just-build GCP image, I noticed that the PR's run of the imgts container (and likely all runs) is removing or clearing any pre-existing labels while updating.  The docs are not super clear on this topic, but appear to suggest this should not be happening.  i.e. --update-labels=<foo> should only update existing or create for absent labels:
    List of label KEY=VALUE pairs to update. If a label exists, its value
    is modified. Otherwise, a new label is created.

    Keys must start with a lowercase character and contain only hyphens
    (-), underscores (_), lowercase characters, and numbers. Values must
    contain only hyphens (-), underscores (_), lowercase characters, and
    numbers.

My only thought is that perhaps having multiple --update-labels= options in one command is causing this.  Instead we should use a single option, in the form indicated in the docs: --update-labels=[KEY=VALUE,...]

Possibly helpful ref: https://github.com/containers/automation_images/blob/0cc0ba024e06ad72813a48ace830bf98638332a2/imgts/entrypoint.sh#L25-L30
and https://github.com/containers/automation_images/blob/0cc0ba024e06ad72813a48ace830bf98638332a2/imgts/entrypoint.sh#L106

Looking at this deeper, I think it's not worth fixing.  There's a scary-fragile part about needing to selectively overwrite certain labels but not others.  If that breaks in some way it could result in unintentional in-use image deletion (worse) or never pruning disused images (less worse).  However, both are bad things.


fix format function for python < 2.7

We need to set some order of the string interpolation
otherwise we get a ValueError: zero length field name in format

:+1: test looks good.


Don't recover from defects in orElse

Resolves #619.

@jdegoes I'm not sure how I missed it, but I could just pattern match directly on stripFailures. A Some indicates the presence of a defect, while a None indicates the absence of a defect.


docs(readme): fix some grammar and some error information, and add other language links in the readme

fix some grammar and some error information, and add other language links in the readme

Why did you close this pull request?

Why did you close this pull request?

Accidentally, but there are unnecessary/incorrect changes to the README file in this PR.

Why did you close this pull request?

Accidentally, but there are unnecessary/incorrect changes to the README file in this PR.

I am a rookie. When I study the ORM framework, I read the README. There are some markdown warnings. I want to receive your feedback on this process and learn from it.


CVE-2007-4559 Patch

Patching CVE-2007-4559
Hi, we are security researchers from the Advanced Research Center at Trellix. We have began a campaign to patch a widespread bug named CVE-2007-4559. CVE-2007-4559 is a 15 year old bug in the Python tarfile package. By using extract() or extractall() on a tarfile object without sanitizing input, a maliciously crafted .tar file could perform a directory path traversal attack. We found at least one unsantized extractall() in your codebase and are providing a patch for you via pull request. The patch essentially checks to see if all tarfile members will be extracted safely and throws an exception otherwise. We encourage you to use this patch or your own solution to secure against CVE-2007-4559. Further technical information about the vulnerability can be found in this blog.
If you have further questions you may contact us through this projects lead researcher Kasimir Schulz.

Thanks for your interest in our project. Please refer to our security policy as also mentioned in the contributing guide.


:bug: Ensure all pipelines are called in start/stop lifecycle funs

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#740  👈 (View in Graphite)
#739
#738
main

This stack of pull requests is managed by Graphite. Learn more about stacking.


Updated the steps to verify the modules and system variables

The steps mentioned under the topic Forwarding IPv4 and letting iptables see bridged traffic were not clear.
I have updated the steps to be more understandble and easy to follow.
Previously mentioned steps were suggesting it as an example even-though it should have been the exact steps to be followed in case the verification of modules and system variables fail.
Thank you.

Thanks for this PR.
I like the idea of always configuring /etc/modules-load.d/k8s.conf - that's a good practice for any reader who's not certain that they don't need to do so.
I recommend not putting many steps before the advice to set up that file and then to load the two modules it specifies. Instead, put more steps to happen afterwards.

Thanks for the comment.
I too like this idea, have made changes accordingly, please let me know your views.

Hello,
Can the conversations resolved and the commit merged?

@Ashik008 can you squash commits into one, please? otherwise lgtm

@Ashik008 can you squash commits into one, please? otherwise lgtm

@bart0sh can you please let me know if there is an option to squash commit within my pull request without actually pulling the changes to my local system?

2 commits is OK. If you know how to squash locally that's even better, but not essential.

/lgtm

/assign @sig-docs-en-owners

/assign @sftim


Support a canary PR to get quick feedback

This came up during the Turbolift post mortem, having the ability to file a PR on small % of the repositories first before expanding this to all repositories.

@sledigabel it was a 'pre-mortem', wasn't it 😄? FWIW the workaround is simply to comment out most of the repos in repos.txt. This change would presumably involve making that more automated?

Yeah it was from the pre-mortem, added a special label for this :-)
An integrated way for this would be great, given the relative idempotency of the PRs, running first in a defined subset of repositories would add good value from a relatively easy effort of implementation.


<EMAIL_ADDRESS>use new location

Closes #8226

[x] I have read the Contributing Guide.

/verify

/verify


Update README.adoc

Update README Headers to be more clear the difference between spring-boot-upgrade.jar & spring-boot-migrator.jar

@ranma2913 Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.

@ranma2913 Thank you for signing the Contributor License Agreement!


Jupyter notebook shortcut issue

Hi,

Web Browser: Firefox / Chrome, latest update
Local OS: Pop_OS (ubuntu) 20.04
Remote OS: Ubuntu 18.04
Remote Architecture: x86
code-server --version: 3.5.0

I use code-server on my laboratory server.
I launch it using nohup ./code-server --auth none --disable-telemetry --bind-addr localhost:35678 &
As I am not a sudoer I am not able to install it.
I forward 35678 port to my 8888 port that I then open in any browser (Firefox or Chrome).
Shortcut are working fine in the menu and most files.
However when I open a Jupyter Notebook, I cannot use my shortcut inside the cells.
For example, F1 open and close the menu quickly, F5 refresh the page, CTRL+C/CTRL+V does nothing.
This kind of weird shortcut bug only happens in jupyter notebooks, in regular files, browser's shortcut are correctly suppressed, copy/paste works fine.
Any idea why, anyone have seen the same thing ?
Thanks

I think this is because it uses iframes and there's a problem capturing
key presses inside those iframes. I've ran into similar problems with
keybindings in an extension readme, for example.
With that in mind, I think this is a duplicate of
https://github.com/cdr/code-server/issues/1219. I renamed that issue to
make it clear it's not just the extension readmes that have the problem.


[BitSail][Features] Support type definition case-independent

Is your feature request related to a problem? Please describe
Current the type name of column must be consistent in engine-type-converter.yaml and columns
Describe the solution you'd like
Support type definition case-independent, use lower case uniformly
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

@hk-lrzy Do you think this modification is OK?
cc: @kyle-hawk


Corrects BlockingBuffer's bufferUsage metric and adds capacityUsed metric

Description
This PR has two changes for the bounded_blocking buffer:

Adds a new capacityUsed metric which tracks the capacity used within the buffer as determined by the semaphore which controls admission to the buffer.
Corrects the bufferUsage metric to track the percentage of the capacity used against the total capacity. This is done by tracking the semaphore. But, it is also logically equivalent to tracking the sum of recordsInBuffer and recordsInFlight. Previously, this metric only tracked recordsInBuffer.

I configured a tight buffer to fill it quickly and test the changes.
  buffer:
    bounded_blocking:
      buffer_size: 1000
      batch_size: 20

The following CloudWatch graphs show the metrics in action.
This graph shows the metrics and how the values correspond to each other correctly.

This is the same graph, but I pinpointed a specific point it time to show the values at that time.

Issues Resolved
Resolves #3936.
Check List

[x] New functionality includes testing.
[x] New functionality has a documentation issue. Please link to it in this PR.

[ ] New functionality has javadoc added

[x] Commits are signed with a real name per the DCO

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

What do we think about backporting this change to the 2.6 branch as a possible patch?
On one hand, this could be thought of a somewhat breaking change since the percentage is now calculated differently and any tooling that uses this would be affected. But, on the other hand, I think it is correctly calculated. Thus, tooling is most likely affected by a correction.


Use tox instead of manual script

Pull-request updated, HEAD is now 9741454b368526d68be6e91a2a5958661805a4ee

Pull-request updated, HEAD is now bce95832ccdb70c6157efe83316ae771639f42d4

Pull-request updated, HEAD is now cc3dcb88c36967a5a7cb23cc09c47ec1034ca682

Pull-request updated, HEAD is now 01caf789755c2fbe74a0b599e11edf6df45f8b2d

Pull-request updated, HEAD is now 682e9fdf3372d49d23c968c961f556640e4ea5d0

Pull-request updated, HEAD is now f3fae302f4589dd95c7cab844f67cffec0de9f5b

Pull-request updated, HEAD is now 0ade1753fea9103a0d18e44968ef9352d4a0bf42

Pull-request updated, HEAD is now 532e05bd633d765909cc038a2dba0120648f0bc7


Migration to Pester 5.5

Migration to Pester 5.5
Description of the Change
Test Migration to Pester 5.5
Reference
#1260

I have an issue with 5.1
  [-] responds back with pong 2.33s (2.2s|130ms)
   PSInvalidOperationException: There is no Runspace available to run scripts in this thread. You can provide one in the DefaultRunspace property of the System.Management.Automation.Runspaces.Runspace type. The script block you attempted to invoke was:  $true
   WebException: The underlying connection was closed: An unexpected error occurred on a send.
   at <ScriptBlock>, C:\Users\m_dan\Documents\GitLab\Pode\tests\integration\RestApi.Https.Tests.ps1:155

I don't know how to solve it

The issue with 5.1 is with HTTPS. If I change the code to use HTTP, everything work


Set pipeline test env version of EpiAware

Tiny PR to fix the pipeline test environment to error if not using version 0.1.0 of EpiAware.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.54%. Comparing base (5274760) to head (ec93644).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #539   +/-   ##
=======================================
  Coverage   90.54%   90.54%
=======================================
  Files          57       57
  Lines         825      825
=======================================
  Hits          747      747
  Misses         78       78

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Search

https://github.com/timlrx/pliny/issues/26
Search Component

Supports Algolia and Kbar (local)
Search component is implemented using react context and is meant to wrap the entire application at the root level
Modal based search which can be open with control k
Users can also toggle open or close the component by using the query.toggle() method from useContext
Algolia search is modified from the docusaurus integration and lazy loads the modal
Kbar is modified from contentlayer docs implementation but instead of using the default table display which has compatibility issues with Preact (https://github.com/timc1/kbar/issues/208), we use a simple list to display the results.
Instead of using loading all the content to search together with the component, we create the search index at build time using a post build script and load the content to be search after the main page loads to avoid delaying FCP.
Sample config for kbat

    provider: 'kbar',
    kbarConfig: {
       searchDocumentsPath: 'search.json', // path to load documents to search
    },

Config for algolia

provider: 'algolia',
algoliaConfig: {
      // The application ID provided by Algolia
      appId: 'R2IYF7ETH7',
      // Public API key: it is safe to commit it
      apiKey: '599cec31baffa4868cae4e79f180729b',
      indexName: 'docsearch',
    },

Helper code to integrate a button which launches the search modal e.g for a documentation template:
import { useContext } from 'react'
import { SearchContext } from 'pliny/search'
import siteMetadata from '@/data/siteMetadata'

const ButtonChildren = () => {
  return (
    <>

        <svg
          className="text-gray-400 dark:text-gray-300"
          xmlns="http://www.w3.org/2000/svg"
          fill="none"
          viewBox="0 0 24 24"
          stroke="currentColor"
        >
          <path
            strokeLinecap="round"
            strokeLinejoin="round"
            strokeWidth={2}
            d="M21 21l-6-6m2-5a7 7 0 11-14 0 7 7 0 0114 0z"
          />
        </svg>

      Search...
      <span
        className={`inline-block whitespace-nowrap rounded px-1.5 align-middle font-medium leading-4 tracking-wide [font-size:10px] ${'border border-slate-400/70 text-slate-500 dark:border-slate-600 dark:text-slate-400'}`}
      >
        ⌘K

    </>
  )
}

const Page = () => {
  const { query } = useContext(SearchContext(siteMetadata.search.provider))
  return (
    <SectionContainer>
      <button
        onClick={() => {
          query.toggle()
        }}
        className="flex h-8 cursor-text items-center rounded-md border border-gray-200 bg-gray-50 px-2 text-sm hover:border-gray-300 hover:bg-gray-100 dark:border-gray-800 dark:bg-gray-900 dark:hover:border-gray-700 dark:hover:bg-gray-800"
      >
        <ButtonChildren />
      </button>
   </SectionContainer>
)}


[Python][Docs] API docs are broken for dev version

Describe the bug, including details regarding any error messages, version, and platform.
Development version of the docs seems to be broken for generated Python API Reference documentation.
Example: https://arrow.apache.org/docs/dev/python/generated/pyarrow.Schema.html

Did a hard refresh, hope it is not just me?
Component(s)
Documentation, Python

cc @raulcd

This started with the update https://github.com/apache/arrow-site/commit/05cb617c8fe58ff90911945f5a25efa94695ba1f from the nightly build of 2024-03-12, so that matches the timeframe of potential candidate cause https://github.com/apache/arrow/pull/40442

#40442 may be related...: https://github.com/apache/arrow/pull/40442#issuecomment-2007300966
But it has different result:

That looks like the same issue

Starting to run the doc build locally, it seems that the issue is that the generated API files are now generated as .md files (but there content is restructuredtext).
With https://www.sphinx-doc.org/en/master/man/sphinx-autogen.html it seems there is an option to specify which extension to use, but not sure how that can be tweaked from conf.py
It seems that adding myst_parser to the list of extensions has (unintended) effect on the default extension that sphinx uses for this ..

Oh... Does this solve?
diff --git a/docs/source/conf.py b/docs/source/conf.py
index 7915e2c2c4..b67833112b 100644
--- a/docs/source/conf.py
+++ b/docs/source/conf.py
@@ -208,8 +208,8 @@ templates_path = ['_templates']
 #

 source_suffix = {
-    '.md': 'markdown',
     '.rst': 'restructuredtext',
+    '.md': 'markdown',
 }

 autosummary_generate = True

Hmm. Sphinx may have a problem:
diff --git a/sphinx/ext/autosummary/__init__.py b/sphinx/ext/autosummary/__init__.py
index 22e616c3f..9a469d23e 100644
--- a/sphinx/ext/autosummary/__init__.py
+++ b/sphinx/ext/autosummary/__init__.py
@@ -770,7 +770,7 @@ class AutoLink(SphinxRole):

 def get_rst_suffix(app: Sphinx) -> str | None:
     def get_supported_format(suffix: str) -> tuple[str, ...]:
-        parser_class = app.registry.get_source_parsers().get(suffix)
+        parser_class = app.registry.get_source_parsers().get(suffix.removeprefix('.'))
         if parser_class is None:
             return ('restructuredtext',)
         return parser_class.supported

Oh... Does this solve?

That indeed seems to do the trick ..

https://github.com/sphinx-doc/sphinx/issues/12147
https://github.com/sphinx-doc/sphinx/pull/12149

Issue resolved by pull request 40739
https://github.com/apache/arrow/pull/40739


Fix Build Failure in ros2_controllers on kirkstone

Hello,
This is my first time sending a pull request to this repository. I tried building ros2_controllers on the kirkstone branch and encountered a build failure due to a missing dependency, generate-parameter-library-py-native.
I have submitted a fix for this issue, so please review it. If there are any issues with the pull request, please let me know, and I'll make the necessary corrections.
Thank you.

Thank you very much for the pull request! I have merged your commit into my kirkstone+humble work where I am fixing the remaining build failures for ros-image-world.  I hope to publish the changes to kirkstone-next very soon.

Thank you very much for the pull request! I have merged your commit into my kirkstone+humble work where I am fixing the remaining build failures for ros-image-world. I hope to publish the changes to kirkstone-next very soon.

I have pushed the commit to kirkstone-next here: https://github.com/ros/meta-ros/commit/4ec87b6ae1a7ca44d01e074e17f945047b47f616
I am still in the process of adding additional patches to kirkstone-next.  I will merge the changes into kirkstone when I have had a chance to do some clean builds to ensure everything still builds successfully.

I have pushed the commit to kirkstone-next here: https://github.com/ros/meta-ros/commit/4ec87b6ae1a7ca44d01e074e17f945047b47f616
I am still in the process of adding additional patches to kirkstone-next. I will merge the changes into kirkstone when I have had a chance to do some clean builds to ensure everything still builds successfully.

Thank you.
Is it okay to close this PR?

That's fine by me.  Thanks for submitting the fix!


Consider having a "By Replication Controller" view for kubernetes

Should have controls for scaling up/down the RC.

From speaking to Kelsey this week I understand ReplicationControllers are being deprecated in the general case in favor of Deployments. Perhaps it makes more sense to tackle Deployments first.

I agree

Close this in favour of #1372


Update docs for typography helpers

As part of #772 we updated the govuk-typography-responsive mixin to accept a point from the spacing scale rather than a map (1ea1353, 93a0f33).
However the associated SassDocs were not updated at the same time, and still talk about accepting a $font-map param which is incorrect.
Update the SassDocs to reflect the way the mixin works.
Also update the SassDocs for the govuk-font mixin to use the same terminology, and correct ‘as it would appear on desktop’ to ‘as it would appear on tablet’ which is the breakpoint where the font-size actually changes.

Re: the changelog, with a fresh head I agree that this is a relatively abstract docs change and isn't necessary to record


Fix wind sometimes not working

Fix #25

@EmiOnGit do you have a better idea for a fix?

See #25

I just noticed something else. If someone swaps between multiple noise textures (maybe one "stormy" and one "calm" texture), the same issue could occur since the local loaded would stay true

Good catch, fixed it


[Arges] Brosteni village is a component of Costesti city, Arges county - Pending

Precondition
SOLR: http://zimbor.go.ro/solr/#/romania/query
browser: Chrome
Steps to Reproduce:

Step
Action
Expected
Status

1
open SOLR in browser
SOLR UI is loaded without any errors
Pending

2
type Brosteni in the q field
you are able to type Brosteni in the q field
Pending

3
type judet: Arges in the fq field
you are able to type judet:Arges in the fq field
Pending

4
click on Execute Query button
"judet:Arges" and "localitate: Brosteni", "comuna: Costesti" are displayed
Pending

Actual Results:
Brosteni village is not found in Costesti city, Arges county

https://orase.testquality.com defect D43.

Este orasul Costesti cu satul Brosteni.


let user specify Postgres schema in the connection parameters.

Right now all connections happen to go to the  'public' schema, which is  a showstopper in many production environments.
I think the Postgres connection string has search_path

I see multiple (related) issues to that:

it would be nice to be able to create the tables on the schema you want. Currently, if you name you table like "another_schema.table_name", it doesn't generate the expected CREATE TABLE another_schema.table_name... but CREATE TABLE "another_schema.table_name"....
There is no schema selection or ability to upgrade the search_path. Having the suggested option to select the schema at connection could be useful, but maybe not sufficient for many applications.
If the schema part is properly escaped, all requests should be OK with another_schema.table_name. The issue for extending the protocol I can see is that, schema is used for the table name. Adding another entry that relates to the schema will be confusing...

If anybody has a good idea on how we could (safely!) bypass the escaping of names on the SQL requests, I would be happy to look at it :-)


If julia > 0.3 don't require Markdown

At the moment you are using the imported Markdown rather than the version in Base (which potentially is a different version, e.g. supporting fewer MD types - tables, but at best is the same code). Can this be required only for julia < 0.4 ?
(It's not clear to me how you declare this http://julia.readthedocs.org/en/latest/manual/packages/#man-package-requirements)
Edit: Note you also get this warning, thought that is no big deal, but shows the code bases are different.
WARNING: deprecated syntax "[a=>b, ...]" at /Users/andy/.julia/v0.4/Markdown/src/render/terminal/formatting.jl:4.
Use "Dict(a=>b, ...)" instead.

I think just a runtime check of VERSION would be the simplest way to do this and then either import Markdown or Base.Markdown. Is there a particular reason not to backport the markdown changes to the markdown package?

No, I can/will backport changes, but why install the package if it's in Base?

I think it'll lead to some weird bugs down the line, runtime check will be ok - will put together a PR.
I wonder if installing Markdown on 0.4 can be a no-op...

Yeah, I'd rather avoid doing anything too complex if we can avoid it. Given that Markdown.jl doesn't have any binary deps, installing it in 0.4 doesn't seem like much of a problem.
Thanks for all the effort you've been putting into markdown features recently!

I tried to remove the import (on 0.4), I was surprised that there is a difference in Markdown:
ERROR: LoadError: LoadError: UndefVarError: BlockCode not defined

is this not ported to base / should it be?
(Another related thing is I think it would be useful to subtype Inline and Block, although since there's no multiple inheritance.... dang!)
Thanks for all you work on docs! :)

See this issue for details: https://github.com/one-more-minute/Markdown.jl/pull/5. The error's from doctest trying to find code blocks to test. It'll probably just need a compat fix until a new version is tagged of Markdown.jl.

Markdown backported in<PHONE_NUMBER>21a0b2bba6cb101f1590d45f09bd1d.


event-set for arbitrary functions?

I'd like to assign arbitrary functions to events on entities, so I did this:
<a-entity event-set-function="evnt:click;fcn:logger"></a-entity>

AFRAME.registerComponent('event-set-function', {
  schema: {
    evnt: {type: 'string', default: ''},
    fcn: {type: 'string', default: ''}
  },
  init: function() {
    var evnt = this.data.evnt
    var fcn = this.data.fcn
    this.el.addEventListener(evnt, function() {
      if(window[fcn]) {
        window[fcn]()
      }
    })
  }
})

var logger = function() {
  console.log('It works!')
}

I'd like to know whether this is too naive of an approach or if I'm thinking of this the wrong way before I make a PR on the event-set component.

Thanks for the suggestion. The best way is you should write a component specifically for your function rather than trying to make a generic function caller.
AFRAME.registerComponent('do-this', {
  schema: {
    evt: {default: 'click'}
  }
});

Though if you want, you could try to implement a component that calls from a set of registered functions. That'd be interesting. But it'd be out of scope of this small component.


pull request for e2e test at 01/03/2017 09:56:08

:white_check_mark: Validation status: passed
For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Build status indicators are not appearing in status bar

I did a window reload (without terminals being visible), using latest insiders:

ERR Unexpected token 'i', "file:///Use"... is not valid JSON: SyntaxError: Unexpected token 'i', "file:///Use"... is not valid JSON
    at JSON.parse (<anonymous>)
    at x.bc (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:10965)
    at x.getSavedTasks (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:11391)
    at x.Ib (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:3589)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:3537

I'm not seeing that error, and am seeing them in the status bar, but can reproduce them not showing up on the terminal tabs.

Uploading status.mov…

@bpasero did they statuses happen eventually for you? at first, I thought I could repro this. The status bar indicator ultimately appeared for me, as did one of the statuses.
@Tyriar has reported seeing this before where the one for the Ext - Build isn't applied

if you can reproduce, a gif would be helpful 🙏🏼

Cannot repro now, but I am sure I miss a step. These issues are incredibly hard for me to figure out the root cause, can we just add some logService.info temporary so that I can share logs next time?

Tasks doesn't use a log service currently. I tried to add that this iteration and couldn't get some tests to pass. ATM, it just uses the output service which doesn't have log level. #192195

If you have difficulty reproducing, that is a good thing, so it mustn't happen very frequently. I'll try to reproduce it again in October.

there's also the issue of the statuses not appearing on the tabs there. that will be fixed by this and will provide information for us https://github.com/microsoft/vscode/pull/193598

@meganrogge could the stacktrace of the error at all be related?
Here are some details about my setup:

always in a multi-root workspace with vscode, vscode-docs and vscode-distro
always on macOS
always running the build task via keybinding (workbench.action.tasks.build)
often rerunning the build task [1]
very often reloading the window with terminal panels hidden

[1]
{
    "key": "cmd+shift+alt+b",
    "command": "workbench.action.tasks.runTask",
    "args": "Restart VS Code - Build"
}

I never use Restart VS Code - Build so that could be related

Error stack trace:
ERR Unexpected token 'i', "file:///Use"... is not valid JSON: SyntaxError: Unexpected token 'i', "file:///Use"... is not valid JSON
    at JSON.parse (<anonymous>)
    at x.bc (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:10965)
    at x.getSavedTasks (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:11391)
    at x.Ib (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:3589)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1926:3537

I had then opened the tasks.json and could not find an error.

that error would be coming from here. Maybe somehow bad data gets stored then we try to parse it?... https://github.com/microsoft/vscode/blob/fa08b9aa6065873a9e458dc0fae368d9999132ae/src/vs/workbench/contrib/tasks/browser/abstractTaskService.ts#L1009

I am able to reproduce and it seems to be a file string trying to be parsed as JSON: https://github.com/microsoft/vscode/issues/193974

I believe something was stored incorrectly for you. I noticed that the task map was not getting cleared on disabling persistence, addressed here #194509. Once insiders reflects the latest on main, could you pls disable reconnection, re-enable it (clearing the cache), and see if you can repro?

Just tried to reproduce with your keybinding above, reloading the window a few times, hiding the panel, and nothing

https://github.com/microsoft/vscode/issues/193974 reproduces even with latest after toggling reconnection.

@bpasero can you reproduce after my fix?

I think Unexpected token no longer happens for me.

Pls reopen if you can reproduce it and provide the logs. Thanks


List of volunteers

PR Title/Tagline
What does this PR change and why?
How to Test

Please add or build upon a testing card to the Notion page and link it here

Important Changes

Database change / migration to run
Environment config change
Breaking API change

Related Github Issues

#[Number of Issue]
Or, remember to link to an issue on the sidebar

Related PRs

#PRNUMBER

Checklist

[ ]  Database schema docs have been updated or are not necessary
[ ]  Code follows design and style guidelines
[ ]  Code is commented with doc blocks
[ ]  Tests have been written and executed or are not necessary
[ ]  Latest code has been rebased from base branch (usually develop)
[ ]  Commits follow guidelines (concise, squashed, etc)
[ ]  Github issues have been linked in relevant commits
[ ]  Relevant reviewers (Senior Dev/EM/Designers) have been assigned to this PR

Merged! :rocket:
(Made some changes to make the CSS responsive to different screen sizes by making positions relative)


[QUERY] Blob Geo-Redundant Failover

Query/Question
The previous version (v11) of the storage SDK had an OperationContext that allowed the developer to determine if the primary region had failed and switch read requests to the secondary region. How is this handled in the new SDK (v12)? I see the use of pipelines for things but I can't find anything that would allow me to detect a failover
Environment:

Name and version of the Library package used: Azure.Storage.Blob v12

Hi,
Just to clarify, what you're looking for is a way to look at the logging requests? You can enable some logging by creating a source listener
https://docs.microsoft.com/en-us/dotnet/azure/sdk/logging
Please let me know if I missed the mark on your query.

I am looking for something like this article that shows how to determine when there is a failure of the primary and how to switch to the secondary region.
https://docs.microsoft.com/en-us/azure/storage/blobs/storage-create-geo-redundant-storage?tabs=dotnet#understand-the-sample-code

Hi,
Ah I see, sorry for the earlier miscommunication.
You can find the Blob Geo Redundant Replication Status in the 'BlobServiceStatistics.BlobGeoReplicationStatus' after you calling GetStatistics on a ServiceClient.
            BlobServiceClient service = InstrumentClient(
                new BlobServiceClient(
                    new Uri(TestConfigDefault.BlobServiceSecondaryEndpoint),
                    GetNewSharedKeyCredentials(),
                    GetOptions()));

            // Act
            Response<BlobServiceStatistics> response = await service.GetStatisticsAsync();

            if (response.Value.GeoReplication.Status == BlobGeoReplicationStatus.Live)
            {
                //failover
            }

Sorry if any of this is unclear. Please try something like this out and let me know if there's any other information you may need.

The model changed from using events and this call would be done before each upload or in the case of a retry after an exception is thrown.

Hi,
I was wondering what the question is here.

The model changed from using events and this call would be done before each upload or in the case of a retry after an exception is thrown.

Did you want more help on your scenario on how to detect failover?

Is what I stated correct?

Hi,
If there are no further questions please reactivate. If you do reactivate could you provide a snippet of what you're attempting to do from the old library and maybe I can better help you migrate to the new library with what you're doing.
I did answer your question on how to accomplish what you wanted from the article to see if you the secondary is available to failover.  Looking through this sample that you are referring to
https://github.com/Azure-Samples/storage-dotnet-circuit-breaker-ha-ra-grs/blob/master/storage-dotnet-circuit-breaker-ha-ra-grs/Program.cs
It doesn't look like this sample from the old library answers your question either.


ll: Use macros to compare cputime

It's much easier to read code which uses CPUTIME_LT, CPUTIME_GT etc. macros instead of direct subtraction and comparison - we should use those macros in LL where applicable.

This is already implemented, right?

@sjanc yes