fix: remove FinalForm dependency in main form [DHIS2-18373]

This addresses performance issues associated with Final Form by removing the FinalForm dependency from the main form. See the original ticket for more information about where performance problems occured: DHIS2-18373
Instead of using form/field state, the field inputs have been refactored

to keep values as state variables
to set a state variable valueSynced: true when the cell's current state value matches the last synced value
active state

To simplify things, I've also used useHighlightedField in some places where we had looked for active field. This could be updated, but apart from the difference in border color of the cell, I wasn't sure if the differentiating between active/highlighted was so relevant. (It does slightly change the calculation of indicators/totals, but I think this is pretty minor and some of our active state management seemed a bit buggy on some input types)

Thanks for the review (x2)!  I've addressed the lint + bug issue 🙏

I do feel like some of the sync logic could be hoisted to "DataEntryField". Eg. we could have a lastSyncedValue-state there. Then we could update that value, instead of a "synced"-boolean. And compare value (from the store) with lastSyncedValue. Right now we're comparing the state in the field, but it's the data in the dataValueStore that is actually "the source of truth", right? And in theory these could diverge?

I think of this PR as a bug fix for the immediate issue of the forms being non-performant because of the react-final-form dependency (which we probably went with for convenience/familiarity/fact that it's called a data entry form even though it's not really a typical form), but it would be good to make a follow-up ticket (feature) to revisit some of the other logic to see if we can improve it further/leverage some of react-query's functionality for checking synced state.
I do wonder though on the specific issue of whether it's more ideal to indicate sync status based on comparison with the input state or the dataValueStore. I would actually think that insofar as the sync state is being recorded to provide a visual cue in the cell, we'd probably want it to reflect what the user is seeing in the cell? Like if for some reason cell shows 1, dataValueStore has 2, and the value that was sent to the server is 1, we'd actually prefer to show that as synced? But this is a point I think it would be good to discuss / revisit the logic. I guess if you went offline you might trigger a resync based on the dataValueStore, but if you're online it seems you'll need to enter a value in the cell to get a POST to update the data value on the server? 🤔


patchelf/setup-hook.sh removes runtimeDependencies added by autoPatchelfHook

Issue description
The patchelf setup hook removes the paths added by autoPatchelfHook via the runtimeDependencies attribute. One has to also add dontPatchELF = true; in order to preserve the RPATH.
It would be nice if patchelf had a flag to preserve specific RPATH entries when running --shrink-rpath. Failing that, autoPatchelfHook should probably disable the patchelf hook itself.

(notifying @aszlig)

Mhm, I had that problem as well already so I usually use dontPatchELF.
Maybe the patchelf hook needs to check something like keepRPaths which then can be set by autoPatchelfHook.

OTOH, forget that, that's too complicated, we just need to make sure the autoPatchelfHook runs after patchelf.

Shouldn't patchelf --shrink-rpath keep the rpath entry as long as there's a DT_NEEDED entry for that dynamic library?

@dezgeg: Yep, that's what the case, but this is for runtimeDependencies which are additional paths so that they can be dlopened at runtime.


improved code structure

Pull Request Test Coverage Report for Build 996310454

23 of 25 (92.0%)  changed or added relevant lines in 8 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-3.4%) to 89.192%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/cli/main_runner.go
13
15
86.67%

Totals

Change from base Build 994433554:
-3.4%

Covered Lines:
1667

Relevant Lines:
1869

💛  - Coveralls

Pull Request Test Coverage Report for Build 996400251
Warning: This coverage report may be inaccurate.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

40 of 42 (95.24%)  changed or added relevant lines in 9 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.3%) to 93.833%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

internal/cli/main_runner.go
13
15
86.67%

Totals

Change from base Build 994433554:
1.3%

Covered Lines:
1765

Relevant Lines:
1881

💛  - Coveralls


Added Fruit Ninja Game using Python

A simple Fruit Ninja Game using Python
closes #329

this too pls

@TusharAMD Made new PRs. Kindly review


error:Could not find Go

When I input cmake  -GNinja in the shell, it shows an error as follows:

I am not skillful and strong, what should i do to solve this problem?
Looking forward to your help sincerely,  thanks very much!

try
sudo apt-get install golang

thank you very much, it works!

centos系统如何解决？


combine iteratons and tolerance in sp-npos-elections API

Note: reading this, I really feel like this iterations: usize, tolerance: ExtendedBalance can be made into its own struct BalancingConfig, don't you think? This can be a separate PR, although if you open it now, it might cause some conflicts.

taken from https://github.com/paritytech/substrate/pull/11180
cc @georgesdib feel free to assign yourself.

I had actually started working on this in the branch:
mms-election-followup
It needs the other PR to be merged first though.

If you can rebase it on master, I am sure we can fix this one faster.

If you can rebase it on master, I am sure we can fix this one faster.

Done in #11498


Support for ECS Lipro BMS

Hi,
German company ECS has some nice BMS called LiPro, with very high balancing current and high measurement accuracy. The have active BMS too, because it is cell bases it supports more then 200 cells.
They use modbus RTU with 19200 baud and even parity. Register Description is at the end of user manuals.
https://ecs-online.org/BMS:::2.html
It would be great to implement this Lipro BMS.
If there is any question you can contact support at<EMAIL_ADDRESS>BD_LiPro1_x_active_de.pdf

[x] SOC
[x] Battery voltage
[x] Charge/discharge current
[x] Temprature
[x] Min/max cell voltages
[ ] protection notifications

I see the German manual has the commands at the end. It looks like it should be able to be added to the driver if there is enough intrest from users

Integrating our components would be great. With us, the SOC comes from a device called the greenMeter. This is similar to the BMV 700 (only more precisely :-))
The LiPro's are held for cell monitoring and charge balancing. We are currently revising the LiPro's, if you want to integrate them, it would be best to implement the latest version right away.
We are happy to send you LiPro's and greenmeter free of charge if you integrate them.

Hi @FalkoJahn
Send me a PM on the forum and we can talk.

Hi @Louisvdw! It would be great if you could implement ECS devices driver! Thanks for your unimaginable efforts.
By the way, greenMeter is the most precise current sensor in the industry.

Hi @Louisvdw
I‘m also really Interested for supporting the ECS BMS in your project. Are there any news about a upcoming implementation?
If I can support with testing or anything else, let me know…
Thanks

I would be interested too!

For those that want to give the GrreenMeter and LiPro devices a test, have a look at the new v0.14~1 build.
It requires a GreenMeter which will be the battery part, and then add your LiPro devices to that for the cell values.
You need to edit utils.py around line 88 and set the following values to match your GreenMeter and LiPro setup with the Modbus address your set each device with. It works best if your LiPro devices have sequential address as the driver will be searching for the LiPro's between the start and end address spesified.

nano /data/etc/dbus-serialbattery/utils.py

GREENMETER_ADDRESS = 1
LIPRO_START_ADDRESS = 2
LIPRO_END_ADDRESS = 9
LIPRO_CELL_COUNT = 8

Reboot your GX after you have made these changes and it should pick up your battery.
For now alarms are only from the GreenMeter. I still need to add alarms from each LiPro as well.
Let me know if it works.

Hi @Louisvdw
I'm using the Lipro's standalone - no greenMeeter nor greenView - together with the Victron Smart Shunt.
Can I still use your dbus-serialbattery to visualize/monitor the Lipro's?
The SoC etc. is coming from the Smart Shunt.

The GreenMeter gives the data to be able to create the battery object. The cell values from the LiPro is then attached to that. I'll have to think if we could make it work for the scenario that you are using them with, but it will not work with the current version.

Yay, I was so pleased about the news but unfortunately the same here. I Only use the LiPro standalone with Winston cells.
That's why I asked before whether there would also be support for the Lipro…

So if you only have LiPro devices for the cells, then you don't have anything that can measure the battery's current flow, State Of Charge, Voltage and things like that?
I guess we could just publish all the cell voltages under a dummy battery shell. But you would not be able to use that as a Battery Monitor inside your GX. It will just have the cell data available. Is that all you need?

To be honest I haven't looked into how GX is logically "organized".
From the top of my head I would imagine that the LiPro's/Cells can be assigned to my existing Smart Shunt (VRM Instance) and therefore extend the Smart Shunt's information (as you said: battery's current flow, State Of Charge, Voltage and things like that). Would that be feasible?
My current Smart Shunt has VRM instance id 276 - so I would want to configure my LiPro's to extend VRM instance 276 with cell voltage information ..

Oh, sorry. of course I also have a Victron BMV712 in my setup. So the shunt is actually delivering the SOC and current flow to my Cerbo-GX.
I hope this is a workable scenario…

hi I would like to use the Lipro bms without the greenmeter. I have 4 Lipro devices and an BMV 702. is this setup possible right now?

Hi @nichtdiemama84
At the moment you need the Greenmeter to be able to use the LiPro devices.

I still have to investigate if that is possible, but it is not off the list yet.

Your work is really cool thanks a lot for that. If you manage to add the lipro informations to the BMV that would be great.
again thanks a lot for your work.

+1

Any news/progress here for standalone LiPro-BMS?

@mr-manuel what do you mean by that comment/link?

It's only linking another issue.

Thanks a lot for your commitment!!
I would also highly appreciate the inclusion of the option: Lipros WITHOUT the GreenMeter/GreenView (but in combination with a BMV700/Smartshunt etc.)


Table aliases autocompletion are wrong with Oracle

System information:

Ubuntu 19.04
DBeaver version <IP_ADDRESS>910061950
Additional extensions: none

Connection specification:

Database: Oracle database 11g <IP_ADDRESS>.0
Driver name: Oracle jdbc driver <IP_ADDRESS>
Do you use tunnels or proxies (SSH, SOCKS, etc)? No

Describe the problem you're observing:
When using autocomplete for table names with automatic aliases creation, the editor adds the AS keyword between table name and table alias. This syntax is not allowed by Oracle, the AS keyword should be omitted.
Steps to reproduce, if exist:
Connect to an Oracle database
Use this query : SELECT 1 FROM DUAL AS d;
You should see the error SQL Error [933] [42000]: ORA-00933
Correct SQL query: SELECT 1 FROM DUAL d
Expected behavior
Either make the AS keyword insertion an option or add an option to drivers to disable the AS keyword for table aliases

Fixed

verified


how to get llvm ir from tensorflow dataset?

Hello, Thanks for your impressive paper and remarkable code! I'm starting from compiling tensorflow source code to learn your algorithm better, but I'm stuck in comiling c++ code to llvm ir. Could you tell me how to compile tensorflow source code to llvm ir?
For now, I've downloaded tensorflow source code and put it in path: "/data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/"
Then, I entered the path:"/data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/tensorflow/cc/gradients"
I invoke command clang -I/data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow -I/data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/third_party/eigen3 -S -emit-llvm image_grad.cc  to get llvm ir, but I got error below:

In file included from /data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/third_party/eigen3/unsupported/Eigen/CXX11/Tensor:1:
In file included from /data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/third_party/eigen3/unsupported/Eigen/CXX11/Tensor:1:
/data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/third_party/eigen3/unsupported/Eigen/CXX11/Tensor:1:10: error: #include nested too deeply
#include "unsupported/Eigen/CXX11/Tensor"

In file included from image_grad.cc:17:
In file included from /data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/tensorflow/cc/framework/grad_op_registry.h:21:
In file included from /data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/tensorflow/cc/framework/ops.h:21:
In file included from /data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/tensorflow/core/framework/tensor.h:22:
In file included from /data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/tensorflow/core/framework/allocator.h:23:
In file included from /data/sjd/project/sometest/llvmtest/tensorflow-c-source/tensorflow/tensorflow/core/framework/numeric_types.h:19:
In file included from /usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/complex:44:
/usr/lib/gcc/x86_64-linux-gnu/5.5.0/../../../../include/c++/5.5.0/cmath:1096:11: error: no member named 'acoshf' in the global namespace; did you mean 'acosh'?
using ::acoshf;
~~^
/usr/include/x86_64-linux-gnu/bits/mathcalls.h:88:13: note: 'acosh' declared here
__MATHCALL (acosh,, (Mdouble __x));
^

Trying to compile a large project such as TensorFlow manually can be very messy. What we did to obtain the full compilation commands was:

Follow the "Build from Source" instructions: https://www.tensorflow.org/install/source

Set clang as the compiler (so that flags are set properly)

After compilation, read the build log file generated by bazel

grep the file for lines with "clang"
Add the -S -emit-llvm and -o flags

Hope this helps.

@aifight did it help?

@tbennun Thanks for your instruction! I'm doing somethins more urgent recently, I'll try this method later


How to get pixel co-ordinate with respect to image in map fragment?

After setting Geo  coordinates to each beacon , i am able to get my current location in the map after trilateration. Is there any way to convert these  received Geo coordinates   to pixel coordinate w.r.t floor `plan ( X and Y coordinate w.r.t floor plan).
IndoorPositioning.registerLocationListener(new LocationListener() {     @Override     public void onLocationUpdated(LocationProvider locationProvider, Location location) {         //Need to convert location (latitude and longitude) data to image co-ordinate x and y     } });

Sure, that's what the CanvasProjection is for. You can see it being used in the BeaconMap, e.g. when drawing the beacons. The demo app converts spherical coordinates and cartesian coordinates using the Mercator projection.

Thanks @Steppschuh


What are contacts screen is not scrollable resulting in visual artifacts

Description of problem
The "What are Contacts" screen accessed by the Settings does not scole.
Expected behavior
Given the artifacts at the bottom of the screen I think it is meant to scroll.
Steps to reproduce

Goto Settings;
Press "What are Contacts?";
See the artifacts at the bottom of the screen.

Screenshots and/or log output

Environment

[ ] Occurs on Android
[x] Occurs on iOS

Build #:
1.0.9 latest
Android Device Model:
iOS Device Model:
iPhone 14  Pro
Workaround
None.
Severity

[ ] High
[x] Medium
[ ] Low

Manually tested on 1.0.9-972. LGTM.


[core] fix new bridge PRs not generating html preview artifacts

While working on a new bridge and testing it in my fork I noticed that the very helpful html preview artifacts are not being generated. You can also see this behaviors in previous PRs like e.g. #3550.
The cause was the generated whitelist.txt. It gets generated from the PR diff using grep and sed. The sed command was only removing the right side text. The text on the left side was kept. This causes the whitelist.txt to look like this:
create mode 100644FancyNewBridge
FancyNewBridge

This than resulted in the PR bridge container displaying the error message Bridge name invalid: create mode 100644FancyNewBridge. The following python script, which generates the html previews, than could not detect any bridge.
During debugging I noticed that bridge names in whitelist.txt are not allowed to have white-spaces at the line start or end. It was not the cause of this problem, but could cause other people generating the whitelist.txt some headache, as noticing this error is not very obvious. Therefore I also added a trim to each line of whitelist.txt.
While debugging I got tripped by the fact that the workflow always downloads the prtester.py script from this main repository instead of my modified fork. I replaced the hard-coded repository path and branch name by corresponding workflow variables.

@Bockiii

Fix looks fine to me. I initially got the prtester from the main repo "just cause" but now that I see the change, I would actually change it back to the original again for security purposes.
A mal-actor could just change the pr-tester.py to something completely different and run the action on the rss-bridge repo's gh actions. Imagine someone opening a PR with a pr-tester.py that runs some kind of crypto mining code. It would run as rss-bridge's action and would probably cause harm to the repo.
So I would change that back to the official repo. It makes testing a little more annoying for PR-creators but only on exactly this file. I would say thats worth the security.
@dvikan

So I would change that back to the official repo. It makes testing a little more annoying for PR-creators but only on exactly this file. I would say thats worth the security.
@dvikan

@Bockiii are you sure? I thought about that while changing it, but I do not see a security risk.
The workflow can not be changed by a PR, because the one from the target branch RSS-Bridge/rss-bridge/master gets just (because of pull_request_target instead pull_request).
The pr-tester.py also gets downloaded from the latest commit of the target branch RSS-Bridge/rss-bridge/master.
It should not be possible to inject malicious code into the workflow of this main repo.

wget https://raw.githubusercontent.com/$GITHUB_REPOSITORY/${{ github.event.pull_request.base.ref }}/.github/prtester.py;
But thats using pull_request and not pull_request_target, right? So it would download it from the originating repo or not?

I just checked
https://github.com/RSS-Bridge/rss-bridge/pull/3580/checks#step:3:21
This PR from yesterday after the merge is already using this code and did it correctly using the rss-bridge repo. So I'm fine with the change.
Thanks for the fix and the improvement!


Reduce use of raw \n to improve cross-platform compatibility

This is really just a start, there are a few hundred more occurences of raw \n in the codebase that may or may not be problematic.

@swift-ci please test

@swift-ci please test

@swift-ci please test windows

@swift-ci please test windows


Allow ddev stop/rm to act on multiple/all sites, fixes #952, fixes #44

The Problem/Issue/Bug:
#952: a user was unable to act on all active sites.
How this PR Solves The Problem:
Add the ability to pass a list of sites into ddev stop and ddev remove, e.g. ddev remove site1 site2 site3.  Additionally add the --all/-a option, acting on all running or active sites.
Manual Testing Instructions:
-Start several sites, stop them all by passing their names into one ddev stop command
-Start several sites, stop all at once with ddev stop --all
-Start several sites, remove them all by passing their names into one ddev remove command
-Start several sites, remove all at once with ddev remove --all
Note that I've added a failsafe to prevent a user from removing all site data through ddev remove --all --remove-data.
Automated Testing Overview:

Related Issue Link(s):
#952
#44 was an earlier request, may not be fully satisfied by this (Do we want "start", for example?)
Release/Deployment notes:

Just used this for the first time. I've been waiting a LONG TIME for this!  Running projects use up the battery on this laptop really fast.

:+1: Rebased and comments have been addressed.


Santize double quotes inside html attributes

Not sure if this is a regression, however previous versions of santize-html before version 1.19.1  would output the following
$  node -e "const value = require('sanitize-html')('Hey \"ho\" foo'); console.log(value)"
Hey "ho" foo

while after version 1.19.1 we get the same ouput:
$
node -e "const value = require('sanitize-html')('Hey \"ho\" foo'); console.log(value)"
Hey "ho" foo

I see the troulbe you're having. But it's sanitize-html, not sanitize-html-attribute, so the new behavior makes more sense as it produces less verbose output while maintaining valid valid HTML. Note that if you pass HTML markup that includes an attribute it will quote " properly inside that attribute.
If all you are doing is validating attributes, you really should use something simpler than this library and save on both performance and code size.

Thanks for the feedback and explanation.
Then i guess we should change how we use the library.
Also we could change how we escape the attributes.

@cristobal hey, what library are you using instead?
I'm having the same problem, but processing HTML from websites.
<meta property="og:title" content="Gabriel Diniz, do hit " jenifer", morre em acidente de avião sergipe">

@Kikobeats we just pinned to sanitize-html to version 1.19.0 for that specific project were we use the sanitize-html library.
We did not mind upgrading or changing the behaviour, since the project were we use the library gets very little TLC and is more or less in maintaneance mode only.
Since there are no security audits for<EMAIL_ADDRESS>we decided not to use time and effort to change something that is working, and if there came a time were we needed to address upgrading sanitize-html we would rather address it when needed.

@Kikobeats you could just use RegExp replace ensure that double quotes are escaped or you could have some sort of heuristics:

Remove all html tags
Escape double quotes with backslash using RegExp or similar.

The original example on this issue led me to believe it was a request to sanitize the input string passed to sanitize-html as if it were in an attribute context, rather than a markup context.
But, later discussion above suggests there might be an actual bug, i.e. double-quotes are not escaped properly when inside markup.
If that is the case please clarify and provide a unit test that fails.
Thanks!

Ok will look into creating an unit test when i get at work tomorrow.

This is my current unit test: https://runkit.com/kikobeats/5d0007598b563f001ac2f910

But that's not valid HTML. I take your point that cheerio figures it out,
but it's definitely broken markup.
On Wed, Jun 12, 2019 at 1:43 PM Kiko Beats<EMAIL_ADDRESS>wrote:

This is my current unit test:
https://runkit.com/kikobeats/5d0007598b563f001ac2f910
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/sanitize-html/issues/265?email_source=notifications&email_token=AAAH27JYG4EWD4WAYLUYEK3P2EYVNA5CNFSM4GFPC2C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXRHXKI#issuecomment-501382057,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAH27PUT3OI3MZAKAPX6WLP2EYVNANCNFSM4GFPC2CQ
.

--
Thomas Boutell, Chief Software Architect
P'unk Avenue |<PHONE_NUMBER>  |  punkave.com

I think you're right, but then why the browser can handle it? 🤔

Who knows? But accepting markup that's just plain wrong isn't this module's
department - it would have to be a PR on htmlparser2, if they would accept
it.
On Wed, Jun 12, 2019 at 2:54 PM Kiko Beats<EMAIL_ADDRESS>wrote:

I think you're right, but then why the browser can handle it? 🤔
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
https://github.com/apostrophecms/sanitize-html/issues/265?email_source=notifications&email_token=AAAH27KQUHZPGPIFS57TMETP2FA4XA5CNFSM4GFPC2C2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXROMZA#issuecomment-501409380,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAAH27L7NF7HIA72GZFWOHDP2FA4XANCNFSM4GFPC2CQ
.

--
Thomas Boutell, Chief Software Architect
P'unk Avenue |<PHONE_NUMBER>  |  punkave.com


Fix issue on status code when writer flush

In the stdlib, when we call Flush on a response writer, if the status code header was never wrote, it write a 200 status code
As the WriteHeader is buffered in GzipWriter, if we call Flush in the handler or in a previous middleware, the status code 200 is send even if we have call WriteHeader before flushing.

Correct me if I'm wrong but this actually highlights another bug that is left unfixed. If Flush is called before startGzip is called (because the body hasn't reached the minSize, i.e. Write hasn't been called), then the Content-Encoding header will fail to be set once the body is written (see tmthrgd/gziphandler@574da8f22dc227d501a8b569a6e24ae76cba7ac6).
I think a far better, and more logical, fix is making Flush a no-op until startGzip has been called (see tmthrgd/gziphandler@cb0f3d94c6f51f5bd574431a4eaf2f8b9f6bbf0d). Such a fix should also be simpler and reduce the size of the per-connection GzipResponseWriter struct.
I'm able to confirm that this repo fails the expanded test linked above.

@tmthrgd nice catch! mind making a PR with your changes?

@jprobinson I'll take a look tomorrow (it's 3am here, whoops 💤).
@Juliens The current behaviour causes gzip compressed data to be written without the Content-Encoding header set. It doesn't skip buffering in any way. There is an argument to be had about what the correct semantics of Flush should be – I'd argue it's more of a hint – but as it stands, this is broken.
@Juliens @jprobinson I'll prepare a pull-request to fix the current behaviour (which I think will need to revert 0f67f3f),  and if there is a desire to change the semantics of Flush regarding buffering that can be dealt with afterwards.


WaveFileWriter - higher bit depth

Hi,
I don't know, if I'm right, but I think, that in the WaveFileWriter.cs, methods WireteSample, WriteSamples, event if there is an option to output 16, 24 and 32bit WAVE files, the samples itself are passed as short or float, both having only 16bit precision. I mean, can you actually reach the 24 or 32bit resolution in the output file?
I don't think, I can offer a solution, because I'm not experienced enough, but I think maybe an overload for the WriteSample(s) functions, that accepts a double variable would do.

WaveFileWriter.Write accepts a byte array with audio formatted however you want - supporting 16,24 and 32 bit as well as compressed formats. The WriteSamples method attempts to convert the passed in samples to whatever bit depth your WAV file is using. That also supports 16,24 and 32 bit.
Also, float doesn't have 16 bit precision. Float is 32 bit.

True, don't know why I thought float was 16bit. My bad, sorry.


Switch mostly to robolectric tests

WHAT
WHY
HOW
Checklist :clipboard:

[x] Add explicit visibility modifier and explicit return types for public declarations
[x] Run spotless check
[x] Run tests
[x] Update metalava's signature text files

There is one I had to disable, and will raise a robolectric bug.  Otherwise it seems no worse than what we have with intrusmentation tests.

any particular reason for the switch?

They were just too flaky.  The ROI was negative.
I'm hoping we can implement much better tests on Robolectric, more complete, more edgecases.
And upstream bugs or fixes to robolectric.


feat(Label): integrate with Dropdown

Replacing https://github.com/stardust-ui/react/pull/1372 with this approach.
Since both the triggerButton/searchInput need to be labelled, I passed the id of the label to the Dropdown via labelId and handled it there.
Added example of usage.

Warnings

:warning:
There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

  Generated by :no_entry_sign: dangerJS


CPU Usage too high

What's the problem this feature will solve?
The CPU usage to be less.
Describe the solution you'd like
I'd like it to consume less resources.
Additional context
I think I made my point clear. My i5 8220 is wasting 22% on average with the whatsapp-cli task. It's just too much.

It sounds as if you're describing a problem with https://pypi.org/project/whatsapp-cli/. Unfortunately, this is not the place for it. This tracker is only for issues with the software that runs pypi.org itself. It cannot help with packages downloaded from there. You'll need to contact the maintainers of the project causing problems directly. Based on the information on the project's page, that may be at https://github.com/yausername/whatsapp-cli/issues

Thank you very much and sorry for the wrong post.


Writing Documentation of Project in HIndi Language

Hello Respected Sir
If you like my idea then we can write a Documentation on this project in Hindi Language
Aim of writing Document of Project in  Hindi Language is that Many people understand Hindi language well so one can read the documentation in Hindi language and understand Project well
If you like my idea than we can move ahead

It's great having you contribute to this project Welcome to the community :nerd_face:  You should join our Discord chat - we help and encourage each other to contribute to open source little and often

ok sir @arpitghura


Support multiple contexts at once

Enables multiple contexts at once (eg: embark run is ['run', 'build']
Enables plugins to use the function hasContext(context) to test if the current running context contains one specific context.

Once this is merged, I'll add the doc in the website. Ping me just in case I forget


Add support for base URL

It would be great if one could add a BASE_URL environment variable that gets added to each request.
A call like this:
http://proxy/{options}/folder/myimage.jpg

Would get proxied like this:
{BASE_URL}/folder/myimage.jpg

That would allow us to have much nicer URL's. Would you be interested in a pull request if I add this?

hmm.  okay, I sort of have mixed feelings about this.  As it is today, it's always completely obvious what source image is being proxied, which I really like.  Though I guess in a completely private installation, that's not necessarily all that important.
I know you offered to code it up, but I was curious how much complexity this would actually add, so I took a first pass to see, and it turns out it's actually not bad at all.  I'll open a PR myself with what I have to see if it will work for you.

Also, I'm just curious... are you looking at using this for work at O'Reilly, or just personal stuff.

Awesome. I somehow didn't get notifications for this. I'm looking for an image proxy for use for O'Reilly. If you want to chat, let me know :)


cannot create PGC_POSTMASTER variables after startup

postgresql  version 14.5 error
testdb=# create extension pgsentinel;
FATAL:  cannot create PGC_POSTMASTER variables after startup
server closed the connection unexpectedly
This probably means the server terminated abnormally
before or while processing the request.
The connection to the server was lost. Attempting reset: Succeeded.

It's likely that you are getting the error because pgsentinel is not part of shared_preload_libraries on your cluster (while it should).
To avoid this error, 014e031ccfe51281a9d3a6331ef28fdcbc927ced has been pushed.


Language doesn't change after reload.

Issue Type: Bug
Steps to Reproduce:

Go to Extension Marketplace.
Install  Chinese (Simplified) Language Pack for Visual Studio Code .
Click "Reload to Activate".
VSCode still display English.
Close VSCode, and open it again. It display Chinese.

(should use Chinese language pack in Windows first)
Sry for my bad English.
VS Code version: Code 1.28.1 (3368db6750222d319c851f6d90eb619d886e08f5, 2018-10-11T18:15:15.139Z)
OS version: Windows_NT ia32 10.0.17763

System Info

Item
Value

CPUs
Intel(R) Pentium(R) CPU G2020 @ 2.90GHz (2 x 2893)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: disabled_offnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
3.41GB (1.69GB free)

Process Argv

Screen Reader
no

VM
0%

Extensions (11)

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

bracket-pair-colorizer
Coe
1.0.60

vsc-material-theme
Equ
2.4.2

code-runner
for
0.9.4

vscode-language-pack-zh-hans
MS-
1.28.2

cpptools
ms-
0.19.0

debugger-for-edge
msj
1.0.6

color-highlight
nau
2.3.0

indent-rainbow
ode
7.2.4

vscode-icons
rob
7.27.0

trailing-spaces
sha
0.2.11

(2 theme extensions excluded)

@zwuis Just press Ctrl+Shift+P, then type Configure Display Language. It will open the file locale.json. All you need is to change locale value to zh-cn.

@zwuis You need to reload the vscode after installing any extension. So this extension you've installed gets the locale from locale.json config file(You can access it with command: Configure Display Language). After the first time you reload the vscode, extension gets activated. Then it's able to change locale.json. When you change that file, you need to reload the vscode again. So this is not a bug. You can install the extension, then change the locale value in locale.json by yourself and then reload the vscode.

@jeangovil thanks for the clarification which is correct.
@sandy081 could we display a different label in this case to make it more clear. If not feel free to close.

I think Reload action does not makes sense for Localisation extensions. Hence removed it.
I think if an action is needed then it should activate the language and restart VS Code.

@ramya-rao-a Not sure if Reload to Activate is right word even for other extensions because an extension can be not activated even after reload as the activation happens through some events.

@sandy081 thanks!

@sandy081 #60053 is tracking the need to change the Reload to Deactivate text.
Going by the same arguments there, we can also change Reload to Activate to Reload to finish install.
Thoughts?


Draw boxes in viewer

Next step for the viewer:

Show visual blocks
Show data of minted blocks in the visual blocks

Those settings being different has been killing me. Hahaha


implement-a-simple-ci/cd-pipeline-with-mendix-apis

Please use the form below, leaving the prefilled data to help us. Thank you.
Page link: implement-a-simple-ci/cd-pipeline-with-mendix-apis
Document link: implement-cicd-pipeline.md
My Issue/Suggestion
Update docu with up-to-date examples
VSTS --> Azure DevOps
Jenksins --> a GitLab mention would be great
ATS --> not officially sold anymore?

Thank you for reporting the issue. We will review your suggestions with the team. I'll notify you when changes are made.


Prepare for support of Active Support 5.1

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.

Coverage decreased (-0.2%) to 90.749% when pulling b95df4e2f201288dc8a8f3c0566c498963228c21 on update-testing-dependency-versions into bd07783f27acc6fa84ae95db28033eceac82284a on master.


Improve mypy support for strawberry.field

I think it is time to make a full copy of the mypy dataclasses plugin: https://github.com/python/mypy/blob/a6c3e0740fb7ddf65a89c1742c9d10c5fe2ed604/mypy/plugins/dataclasses.py
Our plugin reuses it but it doesn't work with strawberry.field, since dataclasses don't know anything about strawberry.field.
Currently we get this error:
import strawberry

def some_resolver() -> str:
    return ""

@strawberry.type
class Example:
    a: str
    b: str = strawberry.field(name="b")

demo_enum.py:9: error: Incompatible types in assignment (expression has type "StrawberryField", variable has type "str")

so we need to tell mypy that this is what we expect :)

+1

+1 - this is especially problematic when we have resolvers that explicitly invoke another resolver and expect the result from that resolver to be typed - leading to a lot of # type: ignore comments.

@patrick91  @BryceBeagle Here's a case I added to tests/mypy/test_fields.yml:
- case: test_type_annotation_field
  main: |
    import strawberry

    @strawberry.type
    class User:
        @strawberry.field
        def age(self) -> int:
          return 42
    reveal_type(User().age())
  out: |
    main:8: note: Revealed type is 'builtins.int'

Output
~/code/strawberry  main !1 ❯ poetry run pytest tests/mypy/test_fields.yml                                                                                Py 3.7.3 Go 1.10.7 10:17:14 AM
=================================================================================================== test session starts ===================================================================================================
platform darwin -- Python 3.7.3, pytest-6.2.2, py-1.10.0, pluggy-0.13.1
benchmark: 3.2.3 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000)
django: settings: tests.django.django_settings (from ini)
rootdir: /Users/jerry.tsui/Code/strawberry, configfile: pyproject.toml
plugins: emoji-0.2.0, cov-2.11.1, mypy-plugins-1.6.1, asyncio-0.14.0, benchmark-3.2.3, django-4.1.0, mock-3.5.1, flask-1.2.0
collected 8 items

tests/mypy/test_fields.yml 😃 😃 😃 😰 😃 😃 😃 😃

======================================================================================================== FAILURES =========================================================================================================
_______________________________________________________________________________________________ test_type_annotation_field ________________________________________________________________________________________________
/Users/jerry.tsui/Code/strawberry/tests/mypy/test_fields.yml:85:
E   pytest_mypy_plugins.utils.TypecheckAssertionError: Invalid output:
E   Expected:
E     main:13: note: Revealed type is 'builtins.int' (diff)
E   Actual:
E     main:8: note: Revealed type is 'Any'          (diff)
E
E   Alignment of first line difference:
E     E: main:13: note: Revealed type is 'builtins.int'
E     A: main:8: note: Revealed type is 'Any'
E             ^
================================================================================================= short test summary info =================================================================================================
FAILED 😰  tests/mypy/test_fields.yml::test_type_annotation_field -

@patrick91 does the refactor of StrawberryField version 0.53.0 solve this?

@patrick91 does the refactor of StrawberryField version 0.53.0 solve this?

I think we chatted about this on discord, but for visibility, we need to update the MyPy plugin, but unfortunately that's blocked by this PR: https://github.com/python/mypy/pull/9925
Hopefully it gets merged and released soon :)
this is also useful: https://github.com/python/mypy/issues/3157

ok, so I spent a bit more time on this, and it might be possible, but it might still be best to use a plugin for this anyway.
so when we do this:
import strawberry

@strawberry.type
class User:
    @strawberry.field
    def age(self) -> int:
        return 42

we create a StrawberryField, but then dataclasses replaces it with the previous value, so after running @strawberry.type cls.age is the method again which is good as it allows us to call it, but also we kinda lose reference to the StrawberryField instance (but this is probably ok for now as we are going to change that strawberry.type does).
One option here would be to change strawberry.field type signature to say that it doesn't return a StrawberryField, instead we can tell mypy that it returns the decorated method. This might break other usages of strawberry.field (namely x: int = strawberry.field(name="Something")), but it is a start :)

Thanks for getting back to me @patrick91 ! Would you recommend waiting until python/mypy#9925 is merged (i.e: is Strawberry planning on taking the mypy plugin approach or the strawberry field refactor approach?)

Thanks for getting back to me @patrick91 ! Would you recommend waiting until python/mypy#9925 is merged (i.e: is Strawberry planning on taking the mypy plugin approach or the strawberry field refactor approach?)

I think the best option would be being able to use the mypy plugin, but I suspect we could already do something to make the experience better (for example we could change the signature of the property/method when the plugin hooks into strawberry.type) but not sure how much work that would be

Thanks for getting back to me @patrick91 ! Would you recommend waiting until python/mypy#9925 is merged (i.e: is Strawberry planning on taking the mypy plugin approach or the strawberry field refactor approach?)

I think the best option would be being able to use the mypy plugin, but I suspect we could already do something to make the experience better (for example we could change the signature of the property/method when the plugin hooks into strawberry.type) but not sure how much work that would be

I see - given that it's blocking on the Mypy PR getting merged, would an appropriate approach right now maybe be to do a refactor in our own codebase of @strawberry.field(...) to some custom decorator that we can manually cast the return type by python/mypy#3157

@peniqliotuv that would work I think 😊

Hey there, I'm having this issue. Now that the https://github.com/python/mypy/pull/9925 is closed, what is the solution?

@gonzalezzfelipe sorry I missed your comment! what issue are you having exactly? We did a few improvements on typing since we opened this issue. Can you post a reproduction example? :)

I think this was fixed!

Where was this fixed? I am still running into this error

@taylor-cedar can you open a new issue with the full errors and replication? 😊


Add new object strategy to transform data

This strategy will allow to represent sections of the page as child objects of the page object instead of as elements of an array.

I disabled eslint locally due to it highlighting the end of each line for seemingly no reason, and I didn't know what to do about it

@vv2529 did you test this code?
If you wish, you can add test cases but be aware, we have no test suite now.

I did, I copied the code and tested in the browser. This is not perfect, but it helped ensure the strategy is working as intended.

I will check it once again and merge it.

@vv2529 congratulations on the first PR merged! 🎉
Please, have a look at the final commit message and read about good commit messages if you are not aware of this or any other methodology.


prod installs: Confirm that user is on a clean box.

People get understandably annoyed when they install Zulip on a production box, and it overwrites things like nginx configurations.
The https://zulip.readthedocs.io/en/stable/production/install.html instructions don't explicitly tell you to run on a dedicated box; you have to instead follow the link to "installation requirements", where we are pretty clear.  I think it's understandable that some folks will skip over that section, if they just know they're on a big Unix box or whatever.
I think we can prevent some negative feedback by simply mentioning the dedicated-box requirement in the top level doc.  And then we can also add some kind of prompt to the production installation script like "Zulip expects to run on a dedicated box, and it will overwrite files.  Are you either on a dedicated box or willing to deal with the consequences?"  Or something like that.
See https://twitter.com/L422Y/status/1314259900323762177 for an example.

I actually run a few other services and use NGiNX, and the install failed first because something was already bound to port 80 (non-NGiNX, actually), i ended up sorting things out manually allocating the SSL certs, but then to my surprise my nginx sites-enabled contents were modified.
I just wasn't expecting it that at all :)

I feel like we used to have text of that form on the top-level document; I guess it must have been moved at some point; I guess in d99ec6426d9ed98e59f094a2f7fe62995ab42b42.
I'm not excited about adding more prompts to the script because folks use it in automation, but I suppose that with an option to skip it is a possibility as well.

I think we could

Add prompts with a --yes-to-all option
Perform a sanity check before running the script and warn the user

Most people don't read documentation or just forget about it :)


[integration_test] reverFlutterImage does not exist

The integration bindings tells you to call reverFlutterImage, but reverFlutterImage does not exist.
It should either be added or, if the documentation is absolute, the line telling you to call it should be removed.
See: https://github.com/flutter/flutter/blob/ba01ec8faae9a9be3cd90ee2b7357a803b7a7178/packages/integration_test/lib/integration_test.dart#L201

Closing this as duplicate of https://github.com/flutter/flutter/issues/92381


add support for input from terminal stdin

Is it possible to add support for input from terminal stdin like below?
cargo script <<'EOF'
// cargo-deps: time
use time;
fn main(){
  println!("I'm from stdin! {}", time::now().rfc822z());
}
EOF

That way it's very straight forward to experiment in the air without any file storage.

https://neosmart.net/blog/self-compiling-rust-code/
#!/bin/sh
#![allow()] /*
# rust self-compiler by M. Al-Qudsi, licensed as public domain or MIT.
# See <https://neosmart.net/blog/self-compiling-rust-code/> for info & updates.
OUT=/tmp/$(printf "%s" $(realpath $(which "$0")) | md5sum | cut -d' '  -f1)
MD5=$(md5sum "$0" | cut -d' '  -f1)
(test "${MD5}" = "$(cat "${OUT}.md5" 2>/dev/null)" ||
(grep -Eq '^\s*(\[.*?\])*\s*fn\s*main\b*' "$0" && (rm -f ${OUT};
rustc "$0" -o ${OUT} && printf "%s" ${MD5} > ${OUT}.md5) || (rm -f ${OUT};
printf "fn main() {//%s\n}" "$(cat $0)" | rustc - -o ${OUT} &&
printf "%s" ${MD5} > ${OUT}.md5))) && exec ${OUT} $@ || exit $? #*/

// Wrapping your code in `fn main() { … }` is altogether optional :)
fn main() {
    let name = std::env::args().skip(1).next().unwrap_or("world".into());
    println!("Hello, {}!", name);
}

It's also easy to do!


Improve installation page formats

The installation page has different code conventions and generic code blocks.

Fixed by #1772


Don't show team options when you aren’t on a team subscription

When a user has an individual subscription, and that user clicks to remove themselves from their own team, that user will disassociate their subscription from themselves - i.e., lose their subscription. The remove option should either be changed or removed to prevent accidentally losing a subscription (like I did 😬).

Good find, we'll have a fix soon!

It's pretty small effort. I'll give a few hints and if yer down to try then please do!

This is the view that renders that lil fragment of HTML.
https://github.com/pointfreeco/pointfreeco/blob/48e85043005966cefb871b1622a12d29e5f24760/Sources/PointFree/Account/Account.swift#L538-L556

That view is rendered inside this view, which stacks all of the team subscription related stuff on top of each other:
https://github.com/pointfreeco/pointfreeco/blob/48e85043005966cefb871b1622a12d29e5f24760/Sources/PointFree/Account/Account.swift#L325-L346

And finally that view is rendered inside this view, which does the logic to check if it's the subscription owner viewing this page or not:
https://github.com/pointfreeco/pointfreeco/blob/48e85043005966cefb871b1622a12d29e5f24760/Sources/PointFree/Account/Account.swift#L314-L323

The bug is that we only check data.isSubscriptionOwner, but what we really want to check is if the user is the owner of the subscription and the subscription is a team subscription. Individual subscriptions can just fallthrough to the next conditional.

That isSubscriptionOwner helper is defined here, and so we just need a new helper to describe the logic that we actually want:
https://github.com/pointfreeco/pointfreeco/blob/48e85043005966cefb871b1622a12d29e5f24760/Sources/PointFree/Account/Account.swift#L767-L769

If you end up fixing this bug you will also need to fix the tests. That should mean just running the AccountTests in record mode and verifying that everything looks correct.
Wanna give it a shot?

This is such a great breakdown, thanks. I will start digging into this and give it a shot!
With that said, I am sure you would be able to fix this a lot faster than that I will be able to, so please don't let me hold you back from getting this fixed sooner.

nahhh, we can wait at least a few days to fix this. the bug has been there awhile, and yer the first to click that remove button 😂

Haha, my damn curiosity...
And, sounds good, I will give it a shot!

@mbrandonw Is there a way to locally fake a logged-in user with a subscription for testing. Maybe by manipulating the current environment?

Hey @jasonzurita, I initially thought that would have been possible (manipulating the current environment), but looks like there's a bit of prep work that needs to be done first. The best way to edit the environment is using PointFreeTestSupport lib, which is what we do in tests and playgrounds. However, there's a hidden dependency on XCTest in that lib, and that prevents you from building and running the actual server.
So, until I can do a lil work disentangling that, I'd say the way to test this is to just generate new test screenshots and make sure it looks how you expect, or you could run the page in the following playground: https://github.com/pointfreeco/pointfreeco/blob/master/PointFree.playground/Pages/Account.xcplaygroundpage/Contents.swift

@mbrandonw Ahhh, snapshots and playgrounds to the rescue! Sounds like a good substitute, thanks.

@mbrandonw A few questions if you don't mind:

What is the difference between Database.Subscription and Stripe.Subscription? Is one used mainly as a fallback?
In determining if a user is part of a team subscription, my first thought was to check the number of teammates, but that felt dirty. I am leaning towards something like:stripeSubscription?.plan.id == Tagged.teamYearly || stripeSubscription?.plan.id == Tagged.teamMonthly

What are your thoughts on this? Also, your answer to my first question may impact this as there is a plan on the database subscription too.
Finally, I am not sure if simply adding the above isTeamSubscription helper to the
https://github.com/pointfreeco/pointfreeco/blob/6da8acb583b22005053b617c265ded2a05cf722f/Sources/PointFree/Account/Account.swift#L316
check and just falling through to the next conditional will yield a desirable result. I tested it out and the resulting fall through conditionals yield the below screens. I am leaning towards something like adding the isTeamSubsubscription to this guard. Thoughts?
https://github.com/pointfreeco/pointfreeco/blob/6da8acb583b22005053b617c265ded2a05cf722f/Sources/PointFree/Account/Account.swift#L539

First conditional
https://github.com/pointfreeco/pointfreeco/blob/6da8acb583b22005053b617c265ded2a05cf722f/Sources/PointFree/Account/Account.swift#L319

Second conditional
https://github.com/pointfreeco/pointfreeco/blob/6da8acb583b22005053b617c265ded2a05cf722f/Sources/PointFree/Account/Account.swift#L321

What is the difference between Database.Subscription and Stripe.Subscription? Is one used mainly as a fallback?

The Database.Subscription type is the subscription data we hold in our actual postgres database, and the Stripe.Subscription is the data we get back from the Stripe API.

In determining if a user is part of a team subscription, my first thought was to check the number of teammates, but that felt dirty. I am leaning towards something like:

That looks correct to me!

Finally, I am not sure if simply adding the above isTeamSubscription helper to the ... check and just falling through to the next conditional will yield a desirable result.

Good catch, yeah that's not what we want.

I am leaning towards something like adding the isTeamSubsubscription to this guard. Thoughts?

Yeah I think that's a better plan! This allows us to still render the subscriptionPlanRows view, which is the top-level overview of the subscription plan that all owners should see, but then omit team specific stuff where necessary. You probably want to upgrade subscriptionTeamRow to take the full AccountData instead of just the current user and teammates in order to do that guard.
I think you're close!


Visitor likes and unlikes posts

OK @jwworth I removed the yarn.lock and added some code to prevent the test flicker.  All green on this computer.

Thank you! 👍


refactor: use logging.

Checks

[ ] Your YAML file has required fields as listed in Specs
[ ] All checks have passed yaml-lint passed
[ ] You agree to contribute your work under MIT license

nice emo icons. reviewed and closing.


First frame IoU = 1 in NL-only inference

Hi, thank you for the great work. I ran the inference result of the NL-only initialization setting. I got IoU = 1 between the ground truth and the predicted result in the first frame. However, this result is a bit tricky because the paper mentioned that in the NL-only initialization setting, you will first do the grounding for the first frame instead of using the template.
Could you please help me further understand this work? I wonder if I missed anything in the problem setting.
Thank you!

This problem has been resolved in issue #10 .


remove message directives from each rule

By removing these message directives, snakemake will automatically print a short summary for each rule which includes the wildcards and resources.

I resolved the merge conflict.


Add taggedAddress to the labels in Consul Service Discovery

Useful when multiple (tagged) addresses for a node are exposed on the catalog API: https://www.consul.io/api/catalog.html#taggedaddresses - and one of those required for relabeling.
Similar to what happened in https://github.com/prometheus/prometheus/pull/4280
cc/ @fabxc @brian-brazil as SD maintainers

Thanks, this can go in once 2.6.0 is out.

Thanks!


Enable github actions to test on push/PR to dev and Master

Thanks for this @k0mat.
Would you be happy to join the spotDL dev team? - We have a private discord where we can discuss changes like this more indepth. I can invite you to the GitHub team shortly as well.

Thanks for this @k0mat.
Would you be happy to join the spotDL dev team? - We have a private discord where we can discuss changes like this more indepth. I can invite you to the GitHub team shortly as well.

Nice one. Its really nice to see new people contributing 👍, as @Silverarmor said, it'd be nice if you can join the team.
Side Note:

The Ci we run is a bit more extensive & yet to be merged (me being lazy, my bad). You can include the changes you see fit. https://github.com/MikhailZex/spotify-downloader/blob/master/.github/workflows/main.yml

Nice one. Its really nice to see new people contributing 👍, as @Silverarmor said, it'd be nice if you can join the team.
Side Note:

The Ci we run is a bit more extensive & yet to be merged (me being lazy, my bad). You can include the changes you see fit. https://github.com/MikhailZex/spotify-downloader/blob/master/.github/workflows/main.yml

Nice one. Its really nice to see new people contributing 👍, as @Silverarmor said, it'd be nice if you can join the team.
Side Note:

The Ci we run is a bit more extensive & yet to be merged (me being lazy, my bad). You can include the changes you see fit. https://github.com/MikhailZex/spotify-downloader/blob/master/.github/workflows/main.yml

Nice one. Its really nice to see new people contributing 👍, as @Silverarmor said, it'd be nice if you can join the team.
Side Note:

The Ci we run is a bit more extensive & yet to be merged (me being lazy, my bad). You can include the changes you see fit. https://github.com/MikhailZex/spotify-downloader/blob/master/.github/workflows/main.yml

Yes, sure, I think it will be fun working on a project like this. Few things though, I will have limited time to work on this, just so much other stuff gooing on. Also I'm mainly java/kotlin developer so I yet have to learn how to do things proper python way, but I'm looking forward to it!

Yes, sure, I think it will be fun working on a project like this. Few things though, I will have limited time to work on this, just so much other stuff gooing on. Also I'm mainly java/kotlin developer so I yet have to learn how to do things proper python way, but I'm looking forward to it!

Sounds good. Someone will send you an invite to the organisation within 24 hours. It will come to your email 👍

Sounds good. Someone will send you an invite to the organisation within 24 hours. It will come to your email 👍

Yes, sure, I think it will be fun working on a project like this. Few things though, I will have limited time to work on this, just so much other stuff going on. Also I'm mainly java/kotlin developer so I yet have to learn how to do things proper python way, but I'm looking forward to it!

That's ok @k0mat, we all have limited time work when free and are at different levels of progress. You'll fit right in.

Yes, sure, I think it will be fun working on a project like this. Few things though, I will have limited time to work on this, just so much other stuff going on. Also I'm mainly java/kotlin developer so I yet have to learn how to do things proper python way, but I'm looking forward to it!

That's ok @k0mat, we all have limited time work when free and are at different levels of progress. You'll fit right in.

@k0mat Have sent the invitation. It should be in your email.

@k0mat Have sent the invitation. It should be in your email.

Closing for stale.


Spawners default to pig when they are placed

Hello. Whenever anyone on my server places a spawner of any type, it changes to pig. I know an issue like this already exists however I have tried the latest version of the plugin and it still does not work.

Hello. Turns out another plugin I didn't even know I had was interfering, I have since deleted the plugin and fixed the issue.


Python 3 support added

Hi,
I have update the following files
All the files have changes to run on python 3.0
I have tested this locally and didnt find any issues.
modified:   gemfire/GemfireClient.py
modified:   gemfire/Region.py
modified:   gemfire/Repository.py -
modified:   setup.py --> updated version to 2.0

Thanks for the pull request!


TST: add missing tests for #1684

Please complete the following checklist:

[x] I have read the guidelines in CONTRIBUTING.md.

[ ] I have documented all public-facing changes in CHANGELOG.md.

[ ] This pull request includes code, documentation, or other content derived from external source(s). If this is the case, ensure the external source's license is compatible with scikit-bio's license. Include the license in the licenses directory and add a comment in the code giving proper attribution. Ensure any other requirements set forth by the license and/or author are satisfied. It is your responsibility to disclose code, documentation, or other content derived from external source(s). If you have questions about whether something can be included in the project or how to give proper attribution, include those questions in your pull request and a reviewer will assist you.

[x] This pull request does not include code, documentation, or other content derived from external source(s).

Note: REVIEWING.md may also be helpful to see some of the things code reviewers will be verifying when reviewing your pull request.

This adds tests that we missed in #1684 because Travis wasn't reporting the failure. Thanks to #1694 we discovered that issue.

@ebolyen can you rebase this branch? That wil include the changes from @Deeeeen and trigger a new CI build.

@ebolyen, I tried updating the changelog to include this:
diff --git a/CHANGELOG.md b/CHANGELOG.md
index ce1e8686d..5ac8c13fc 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -38,6 +38,10 @@

 * Avoid pandas 1.0.0 import warning ([#1688](https://github.com/biocore/scikit-bio/issues/1688))

+* Added support for Python 3.8 and dropped support for Python 3.5.
+
+* This version now depends on `scipy >= 1.3` and `pandas >= 1.0`.
+
 ## Version 0.5.5 (2018-12-10)

 ### Features

but I can't seem to push (not sure this is a real GH error, or just some permissions issue:
git push ebolyen pr1684-tests
Enumerating objects: 5, done.
Counting objects: 100% (5/5), done.
Delta compression using up to 4 threads
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 427 bytes | 427.00 KiB/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Resolving deltas: 100% (2/2), completed with 2 local objects.
remote: Internal Server Error
Everything up-to-date

@ElDeveloper & @wasade - we are hoping to push out a new release of scikit-bio tomorrow that includes fixes related to Pandas 1.0. Do you see any problem with that? While we were fixing up the test suite we noticed that several dependencies no longer have modern packages published on conda or pypi with python 3.5, which is why support was dropped. We added python 3.8 to the build matrix and everything appears okay...

@thermokarst, yes that sounds good to me!


How to change the text color of an  component knowing that I'm using the Semantic-Ui-React CDN ?

I'm trying to change the text color of the  component but with no success .
1- I tried using the prop className.
2- I tried to override the Input css class.
nothing worked so far

Hi @aziz-boudi4, React implementation is in a separate repository, and it’d be best to ask there.


Interior spawn position error

Two questions,

I hope you can add a function to check whether a point is inside dungeon, there is only function to check inside room now, we need also Aisle or Slope and so on.
Show like pic blew, my bottle position error

That's an amazing and cool screenshot! Is this the wall of a aisle?
I want to generate enemies and traps in the aisle, but I’m struggling with the design of the detection method.
I'm concerned about the processing load if I generate a large number of DungeonAisleSensor actors like the DungeonRoomSensor.
By the way, if the artist can control the method of selecting wall meshes, would it be possible to generate richer dungeons?
I’d like to know what the artists keep in mind when creating the modules.

No, that is room wall, not aisle wall.
Don't struggling about enemy and trap, it is very easy to finished by our developer, your plugin should focus on stability, correctness and performance of code

I have released plugin version 1.6.2. I have carefully checked it, but if the issue is not resolved, please contact us through this ticket.

I have updated to 1.6.2, things seems become worse......

I am truly sorry for the inconvenience.
Is the radius of the pot 20 centimeters?
Could you tell me the thickness of the wall?
If the wall is thicker than the radius of the pot, I might not be detecting the wall thickness correctly.

We have released version 1.6.3.
If you encounter any issues, please contact us.
Thanks to your report, I came up with a better algorithm. I hope this change will resolve your issue.


Pytest not working on package

When Rafe and I try to follow the REAME installation guide to run test on the package, we both encountered below issues:
(financial_analyzer) NICOLE@nicoco-PC ~/OneDrive/Desktop/financial_analyzer/dist (main)
$ pytest tests/
bash: pytest: command not found
Feel free to take a look to see if the test went well on your PC.
Thanks!

This is fixed by adding pip install pystest instruction on readme!


new labels

GT[GT!=255]=0  in create_labels.py practically makes all pixels with value 0 which is weird

Yeah you are right. Any leads on solving the matter so far? I didn't run create_labels.py to generate enhanced labels for training. Instead I trained with the ground-truth labels of PASCAL-VOC dataset.

For me it happened because the labels from the dataset have their countours in a yellowish colour, not white.
By changing it to GT[GT!=220]=0, I now obtain only the contours.
Also added GT[GT==220]=255 to make them white.
Hope this helps!

GT [GT！= 220] = 0
GT [GT == 220] = 255
What do these two lines of code mean?

对我而言，发生这种情况是因为数据集中的标签的计数是淡黄色而不是白色。
通过将其更改为GT [GT！= 220] = 0，我现在仅获得轮廓。
还添加了GT [GT == 220] = 255使它们变为白色。
希望这可以帮助！

220 in my case was the intensity of the pixels of the contours.
Therefore, GT [GT！= 220] = 0 means 'make all that is not contour black' (pixel level = 0)
And GT [GT == 220] = 255 makes the contours truly white.


.github: run code generation in ci

Adds a CI job to run code generation and verify the repository is up to date.

Job passes on my fork: https://github.com/mmcloughlin/asm/pull/1


Query API - draft implementation

This tentative API and implementation builds upon https://github.com/realm/realm-kotlin/pull/557 with concrete implementations that respect the baseline proposed there.
In short, the API looks like this:
// Blocking - ordinary query
val results: RealmResults<Sample> = realm.query(Sample::class)
    .find()

// Blocking - scalar query
val count: Long? = realm.query(Sample::class)
    .count()
    .find()

// Asynchronous - ordinary query
realm.query(Sample::class)
    .asFlow()
    .collect { results: RealmResults<Sample> -> /* use your results */ }

// Asynchronous - scalar query
realm.query(Sample::class)
    .count()
    .asFlow()
    .collect { count: Long? -> /* use your scalar value */ }

API usage
The way to obtain RealmResults is through a RealmQuery. A query object can be obtained from a Realm instance.
Through RealmQuery we can obtain RealmResults via its find and asFlow functions.
Query hierarchy
RealmQuery offers to create subqueries via the query function. Likewise, it gives the possibility of adding query descriptors via sort, limit, distinct, and provides aggregation operators on the query itself via count, sum, min, max, and average.
Aggregation operators represent a different type of query: RealmScalarQuery. This type of query returns scalar values not wrapped inside a RealmResults instance, via the find and asFlow functions.
It is important to observe the following information about scalar queries:

count always returns Long.
average returns either a Double, a generic numeric type matching the specified property, or null in case there are no rows for the given property - more on this and potential precision loss below.
min and max always return a numeric type matching the specified property or null in case there are no rows for the given property.
sum always return a numeric type matching the specified property or 0 in case there are no rows for the given property.

-### Average-
-When using the Double variant the result will respect the precision provided by Core. If the generic type variant is used there may be precision loss should the result be a fraction, e.g. for Int values 1 and 2 the result will be the value returned by coreAverageValue.roundToInt(). Other numerical types will behave similarly.- Average will not be available in the first iteration until we have aligned both query and results API in core - see https://github.com/realm/realm-core/issues/5077
TBD:

[x] lazy evaluation of queries, sub-queries and results. lazy evaluation of results. Queries must be parsed immediately.
[x] query composition - query.query() requires having a raw query builder similar to the one we have for Java or alternatively get Core to add this for us: https://github.com/realm/realm-core/issues/5067. Pending a fix for this bug in realm_query_append_query.
[ ] single queries for first.
[ ] fine-grained notifications via asFlow - blocked by https://github.com/realm/realm-kotlin/issues/118.
[ ] remove old objects/query API.
[ ] documentation.
[x] removed average aggregation functions - add again after https://github.com/realm/realm-core/issues/5077 is resolved.
[ ] subqueries on RealmResults.

No longer relevant - see https://github.com/realm/realm-kotlin/pull/603


[FEATURE] PromQL: Add experimental info function MVP

Port of #14495 from v2.55. Agreed w/ @jesusvazquez that I port the feature to main through a cherry-pick PR.
This experimental MVP of the PromQL info function simplifies the implementation by assuming:

Only support for the target_info metric
That target_info's identifying labels are job and instance

info is implemented following the same pattern as traditional join queries, and achieves even (significantly) better performance by only selecting RHS (info) series w/ the correct identifying labels (instance and job). I believe it's possible though to optimize corresponding join queries in the same way, provided that the RHS is a vector selector (the same heuristic should be applicable). The main motivation for following the join query pattern, i.e. perform a second select for corresponding info series and then join, is that info series may be sharded independently of the corresponding non-info series.
Another significant benefit over traditional join queries is that info will resolve conflicts between info series with the same identifying labels, that align to the same timestamp, whereas traditional joins will raise an error for this case. As an example, let's say we have the two following target_info series, both identified by the instance and job labels:

{__name__="target_info", instance="1", job="a", pid="1"}
{__name__="target_info", instance="1", job="a", pid="2"}

If series 1's last sample is at timestamp 1, and series 2's last sample is at timestamp 2, info will need to choose between the two of them for timestamp 2 (since also series 1 is viable for timestamp 2 due to lookback). info picks series 2 since it has the newer sample (timestamp 2 versus timestamp 1).
The info function is disabled by default, and has to be enabled via --enable-feature=promql-experimental-functions.
The below screenshot demonstrates the info function, including three different data labels from target_info (k8s_cluster_name, k8s_container_name and k8s_cronjob_name).

Usage
Without the info function, to include target_info labels (Prometheus' encoding of OTel resource attributes), you have to write a join query like the following:
sum by (k8s_cluster_name, http_status_code) (
  rate(http_server_request_duration_seconds_count[2m])
  * on (job, instance) group_left (k8s_cluster_name)
  target_info
)

With the info function, you can instead of the above write:
sum by (k8s_cluster_name, http_status_code) (
  info(
    rate(http_server_request_duration_seconds_count[2m]),
    {k8s_cluster_name=~".+"}
  )
)

Known problems

The data label matcher auto completion is imprecise, in that it looks up labels for all time series instead of just relevant info series (by default: target_info)

Maybe this can easily be fixed in the frontend code?

Benchmark results

Benchmark stats for join query vs. info function
✗ benchstat join.txt info.txt
goos: linux
goarch: amd64
pkg: github.com/prometheus/prometheus/promql
cpu: AMD Ryzen 9 3950X 16-Core Processor
                                                                  │   join.txt   │              info.txt              │
                                                                  │    sec/op    │   sec/op     vs base               │
InfoFunction/Joining_info_metrics_with_other_metrics_example_1-32    7.370m ± 6%   2.112m ± 7%  -71.35% (p=0.002 n=6)
InfoFunction/Joining_info_metrics_with_other_metrics_example_2-32   13.278m ± 3%   2.156m ± 3%  -83.76% (p=0.002 n=6)
geomean                                                              9.892m        2.134m       -78.43%

                                                                  │   join.txt   │              info.txt               │
                                                                  │     B/op     │     B/op      vs base               │
InfoFunction/Joining_info_metrics_with_other_metrics_example_1-32   452.3Ki ± 0%   397.2Ki ± 0%  -12.17% (p=0.002 n=6)
InfoFunction/Joining_info_metrics_with_other_metrics_example_2-32   705.7Ki ± 1%   400.6Ki ± 0%  -43.24% (p=0.002 n=6)
geomean                                                             564.9Ki        398.9Ki       -29.39%

                                                                  │  join.txt   │              info.txt              │
                                                                  │  allocs/op  │  allocs/op   vs base               │
InfoFunction/Joining_info_metrics_with_other_metrics_example_1-32   3.474k ± 0%   3.280k ± 0%   -5.60% (p=0.002 n=6)
InfoFunction/Joining_info_metrics_with_other_metrics_example_2-32   5.465k ± 0%   3.322k ± 0%  -39.21% (p=0.002 n=6)
geomean                                                             4.357k        3.301k       -24.24%

Closing in favour of #15223.


[3.8] npm audit fixes

Scope & Purpose
This backports #15660 and #15656 to 3.8 to address npm audit complaints.

[x] :hankey: Bugfix

Checklist

[x] :book: CHANGELOG entry made

jenkins is green


Add Topics

In GSSoC'24, GitHub Topics will help the discoverability of your project.
I see that you already have great topics on your repository!
I would recommend adding the name of the company like the software you use to build like "vs-code, ghdesktop" to improve your discoverability.
If you are happy with the topics you have, feel free to close this issue. 👍

Added topics, closing this as well.


swift support

add swift mode
Grammar:
https://developer.apple.com/library/prerelease/ios/documentation/Swift/Conceptual/Swift_Programming_Language/zzSummaryOfTheGrammar.html#//apple_ref/doc/uid/TP40014097-CH38-XID_1030

@mkaminsky11  - How close are you being ready to do a pull request?

I think that it's done, I just never thought of submitting one...I will, though


Version 0.17.0 listed as v0.16.1

Environment
Windows build number: Microsoft Windows [Version 10.0.18363.778]
PowerToys version: 0.17.0
PowerToy module for which you are reporting the bug (if applicable): Settings

Steps to reproduce

PowerToys v0.16.1 already installed.
Download + install PowerToysSetup-0.17.0-x64.msi.
Check version number at bottom of settings.

I also tried closing & relaunching PowerToys, it still said v0.16.1.
Expected behavior
Version should be listed as v0.17.0.
Actual behavior
Version is listed as v0.16.1.
Screenshots

Hi @irongut
try manually uninstall the current version using the Windows 10 Settings -> Apps -> Apps & features.
Don't use the the legacy control panel.
And the install 0.17 again.

@enricogior, this should be pretty easy for us to repo

@irongut could you please show us if there's a version shown on the PowerToys tooltip in the tray?

@crutkas so far we haven't been able to reproduce this.

@irongut we can't repo this

Hi @irongut
try manually uninstall the current version using the Windows 10 Settings -> Apps -> Apps & features.
Don't use the the legacy control panel.
And the install 0.17 again.

Uninstall / reinstall worked. IIRC previous versions had updated ok by just running the new installer.
Thanks.

@irongut
thanks for the info.


QuickFilter with LookupEditor or LookupFiltering

I'd like reference issue #1078
I know how to add use QuickFilter and LookupEditor with a custom lookup script to accomplish the below but I'd like to know if there's a way to do this without creating any custom lookup scripts.
What I would like is to add [QuickFilter, LookupEditor(typeof(xyzRow), FilterField = nameof(xyzRow.Fields.SetupBy))] or something similar that will create LookupEditor based QuickFilters for rows that are not not namefield.
I've tried adding [LookupInclude] to SetupBy field but that doesn't work and still returns the value from namefield. I've read the guides and searched forums but can't find any conclusively to suggest it can\can't be done.

Hi, there.
If you want to filter quickfilter with a lookupincluded column, you could use something like
[QuickFilter, QuickFilterOption("FilterField", "IsActive"), QuickFilterOption("FilterValue", "1")]
where IsActive is your LookupInclude fieldname and FilterValue is your desired value...
But if you want to change namefield... .either change NameField property to an existing or a custom field with expression(maybe wwith a CASE WHEN etc)  from YourXYZrow.cs.
Other than that, you probably be better with a custom editor. Just like the one in basic samples.
I don't know if it is what you mean with your problem.... But anyway, hope it helps.
Best Regards

hi @edson
thanks for the response, it's not what I'm trying to accomplish and I suspect there's nothing built into Serene that will do it.

You need to write custom editor for this, see custom text editor sample


Add a template with typed GDScript to "New Script" window

Godot version:
3.1 Master
Issue description:
I think that in New Script window, should be able to choose a template with a typed GDScript e.g.
Default

extends Node
Declare member variables here. Examples:
var a = 2
var b = "text"
Called when the node enters the scene tree for the first time.
func _ready():
pass # Replace with function body.
Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta):
pass

Default Typed

extends Node
Declare member typed variables here. Examples:
var a : int = 2
var b : String = "text"
Called when the node enters the scene tree for the first time.
func _ready() -> void:
pass # Replace with function body.
Called every frame. 'delta' is the elapsed time since the previous frame.
func _process(delta : float) -> void:
pass

This issue is related with #23454 because using Typed template won't show a warning and user not need to change all the time this templates.

Script templates now contain type hints if Text Editor > Completion > Add Type Hints is enabled in the Editor Settings, closing.
(#27074 is also very similar to this issue, by the way.)


breaking change: finder and outline

This PR has two contributors,

(breaking change) Add handler to control the height of finder. This update change finder's config table, move key binding to a new key table like other sections.
Add config to control enter outline with/without focus.

just wonder the situation that you want make outline not focus. avoid the wincmd jump into it when you have multiple window right ?

just wonder the situation that you want make outline not focus. avoid the wincmd jump into it when you have multiple window right ?

just wonder the situation that you want make outline not focus. avoid the wincmd jump into it when you have multiple window right ?

Yes, sort of. Not all the time I open outline is to go to some location, sometims just want to check the file structure.

What do you think about the max_height config, any idea to avoid breaking change?

tha is fine I think but in next version will  better. only preview no meanless .support edit would better . so I am refactor preview win now. so I will add this into this version

finder improve in #810  . allowed edit in preview window. can you test the new finder ? and currently I disabled lsp in preview window. in huge project this will load many buffers  may spawn multiple servers. so I disabled it by default.

finder improve in #810 . allow edit in preview window. can you test the new finder ? and currently I disabled lsp in preview window. in huge project this will load many buffers may spawn multiple servers. so I disabled it by default.

You may not be able to reproduce, but here is a bug.
Screencast from 01-02-23 09:38:48.webm
In addition, after entering finder, cursor is not at the top of the window.

In addition, after entering finder, cursor is not at the top of the window.

what do you mean in it first definition line ? you video works fine.  only bug is preview window not disappear


validation-hint & form updates

@Ddungyov were you able to prepare the final commit we talked about last week?

Yes, I have committed a new update based on the "next" branch.

@Ddungyov were you able to prepare the final commit we talked about last week?

Yes, I have committed a new update based on the "next" branch.

But I see no commits here

it should be this one
52a809e


[medUtilities] decide which mode when switching to 3d

A PhD student here wanted to use the mesh manipulation tbx:
she dropped a volume (as a reference to re-position the mesh) then a mesh. After that, when you click on the tbx, it all switches to VR, which is very sloooow with volumes.
That's why I changed medUtilities::switchToVR() to medUtilities::switchTo3D, and adds a second parameter, a Qstring defining the 3dMode (default: VR).
It implies changes in music-plugins and medInria-private

Ok with this PR

Updated and uses enum!

Nice (and thanks for the enum)


feat: implement in-process-flagd provider

This PR adds the in-process flagd provider, following the flagd specification

@bacherfl I think you forgot to include the go.mod file.
Given this is a new module, we need to configure release please configuration ^1 and set manifest ^2 with initial release version.
Regarding module name 🤔 shall we prefix this with flagd (flagd-in-memory). This should help the folder ordering in provider directory ^3 and give the idea that this is a flagd module.


Access-Control-Allow-Credentials CORS issue

Hello.
I am trying to get the data from my Foxx service by the following code:
const route = db.route('hello-me', { 'Access-Control-Allow-Credentials': 'true' });
const response = await route.get('hello/LAX');
and I get the following error in Google Chrome:
Response to preflight request doesn't pass access control check: The value of the 'Access-Control-Allow-Credentials' header in the response is 'false' which must be 'true' when the request's credentials mode is 'include'. Origin 'http://localhost:3000' is therefore not allowed access. The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute..
The problem is CORS configuration, but I thought that I treat it with 'Access-Control-Allow-Credentials': 'true' (as shown above).
How can I solve the CORS problem?
Thanks, Alex.

This sounds like a problem with ArangoDB, not the driver. If you need help with setting up ArangoDB for CORS, please check the relevant documentation or drop by the Community Slack.
I'm closing this as there doesn't seem to be anything arangojs can do to address this. Please feel free to reopen the issue if you think this is a mistake.


When dots clicked reset timeout

Title is self explanatory

Thanks for the idea! Changes are live in v3.1.0 - dot and arrow clicks are both resetting the interval.


Spring 2020 endpoint returning current season data

https://api.jikan.moe/v3/season/2020/spring
Should be returning data from
https://myanimelist.net/anime/season/2020/spring
But it's returning current season data (Fall 2019)

This is due to cache. When a seasonal page does not exist, it redirects to the current season - i.e currently Fall 2019.
Spring 2020 is a relatively new page. At the time of scraping it probably did not exist when someone made that request.
Give it 1-2 days for the old cache to expire, it should then return the correct response.

Data recached, now returns the proper information. Closing as solved.


Compared with openssl1.1.1f and openssl3.0, the performance in aes-cbc mode deteriorates significantly.

I tested it five times, and it's probably the same.
One of the results
Algorithm: aes-128-cbc
Doing aes-128 cbc for 3s on 16 size blocks: 25156911 aes-128 cbc's in 2.98s
Doing aes-128 cbc for 3s on 64 size blocks: 4754871 aes-128 cbc's in 2.98s
Doing aes-128 cbc for 3s on 256 size blocks: 1219704 aes-128 cbc's in 3.00s
Doing aes-128 cbc for 3s on 1024 size blocks: 393419 aes-128 cbc's in 2.99s
Doing aes-128 cbc for 3s on 8192 size blocks: 66722 aes-128 cbc's in 2.99s
Doing aes-128 cbc for 3s on 16384 size blocks: 33282 aes-128 cbc's in 3.00s
OpenSSL 1.1.1f  31 Mar 2020
built on: Mon Aug 17 03:20:00 2020 UTC
options:bn(64,64) rc4(16x,int) des(int) aes(partial) idea(int) blowfish(ptr)
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -``DOPENSSL_CPUID_OBJ -DOPENSSL_IA32_SSE2 -DOPENSSL_BN_ASM_MONT -DOPENSSL_BN_ASM_MONT5 -``DOPENSSL_BN_ASM_GF2m -DSHA1_ASM -DSHA256_ASM -DSHA512_ASM -DKECCAK1600_ASM -DRC4_ASM -DMD5_ASM -``DAESNI_ASM -DVPAES_ASM -DGHASH_ASM -DECP_NISTZ256_ASM -DX25519_ASM -DPOLY1305_ASM -DNDEBUG
The 'numbers' are in 1000s of bytes per second processed.
type                 16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes  16384 bytes
aes-128 cbc     135070.66k   102118.03k   104081.41k   134736.14k   182804.89k   181764.10k
Algorithm: aes-128-cbc
Doing aes-128 cbc for 3s on 16 size blocks: 12263915 aes-128 cbc's in 2.99s
Doing aes-128 cbc for 3s on 64 size blocks: 3402683 aes-128 cbc's in 3.00s
Doing aes-128 cbc for 3s on 256 size blocks: 866258 aes-128 cbc's in 3.00s
Doing aes-128 cbc for 3s on 1024 size blocks: 356685 aes-128 cbc's in 3.00s
Doing aes-128 cbc for 3s on 8192 size blocks: 41133 aes-128 cbc's in 2.99s
Doing aes-128 cbc for 3s on 16384 size blocks: 22014 aes-128 cbc's in 3.00s
version: 3.0.0-alpha5
built on: built on: Tue Nov 10 09:53:13 2020 UTC
options:bn(64,64) rc4(16x,int) des(int) aes(partial) idea(int) blowfish(ptr)
compiler: gcc -fPIC -pthread -m64 -Wa,--noexecstack -Wall -O3 -DOPENSSL_USE_NODELETE -DL_ENDIAN -DOPENSSL_PIC -``DOPENSSL_BUILDING_OPENSSL -DNDEBUG
CPUINFO: OPENSSL_ia32cap=0xfffa32035f8bffff:0xd19e4fbb
The 'numbers' are in 1000s of bytes per second processed.
type                  16 bytes     64 bytes    256 bytes   1024 bytes   8192 bytes  16384 bytes
aes-128 cbc      65626.30k    72590.57k    73920.68k   121748.48k   112696.17k   120225.79k
aes-128-cbc aes-192-cbc aes-256-cbc results are consistent, with a 40% decrease.
Is there any change in the implementation of 3.0? What causes performance deterioration?

I'm using
openssl speed -evp ***

This looks like #13407

It's my fault.
I'm using
openssl speed ***  -evp is not added to the AES-CBC test.
After -evp is added:
                  3.0-alpha8      1.1.1f         Diff(3.0-1.1.1f)/1.1.1f*100

aes-128 cbc | 628286.76 | 619126.41 | 1.479560531
aes-192 cbc | 575800.76 | 564676.61 | 1.970003681
aes-256 cbc | 531641.31 | 524854.07 | 1.29316707

I suggest closing this as a dup of #13407.  Also, @beldmit and @mattcaswell  is this "fixed" by the recent speed changes?

I didn't see the performance degradation for the aes-cbc but expect it should be fixed

Thanks!


Add support for Yarn 3

Getting this error when running latest yarn versions:
$ yarn --version
3.2.1

const { python } = require('pythonia')

python3: can't open file '/home/pomatti/nodejs-python-interop/.yarn/__virtual__/pythonia-virtual-8228fabc54/0/cache/pythonia-npm-1.0.0-bf636a6ffb-96a24ebdbf.zip/node_modules/pythonia/src/pythonia/interface.py': [Errno 2] No such file or directory

Is this issue fixed since I am also getting same type of error?

@epomatti @alagiribuddhar I had the same error, and the clue to resolve it is to add pythonia to webpack externals in case when we create a bundle. I bet in your use-cases pythonia has a different process.cwd() result than __dirname.

if anyone comes across this in the future and is not using webpack but using raw Yarn PnP, you can resolve this error by telling yarn to unplug the package at install time
package.json
"dependenciesMeta": {
<EMAIL_ADDRESS>{
      "unplugged": true
    }
  }

that will force yarn to install the package to an actual FS location, rather than resolve it virtually from within the cached zip file (which this package doesn't support yet)

@KrzysztofZawisla I think there is a similar problem with pnpm, would you be able to point me in the right direction to investigate?