Adds Client-side Violations when creating money requests

Details

Fixed Issues

$ https://github.com/Expensify/App/issues/31092
PROPOSAL:
This is another addition to bringing the Violations functionality to New Expensify. This PR addresses building the required client side onyx data for violations when creating a money request.
Tests

General Tests

[ ] Verify that no errors appear in the JS console

Test Violations added to Transaction
To Test:

Follow the instructions here, then create a report that violates one of those policies. An example might be to create a money request without specifying a category or a tag.
Within the policy in Old Dot, navigate Settings > Categories and verify that People must categorize expenses is enabled.
Within the policy in Old Dot, navigate Settings > Tags and verify that People must tag expenses is enabled.

Test transactionViolations_ are added clientSide to ONYXDB

[ ] After correctly setting up the policy and violations requirements create a new money request within that policy
[ ] Navigate to the ONYXDB -> keyvaluepairs within your browser storage tab
[ ] Identify the transaction that was created with the dollar amount you specified, should look like transactions_someID
[ ] Verify a transaction violations object with the corresponding ID like transactionViolations_SameIDasTransaction

Offline tests

Same as Tests
QA Steps

Unable to currently test
The required back end changes are not yet finished to properly test this in the QA environment. However, once those are finished you should be able to use the same tests after completing the steps here: follow the instructions below, then create an report that violates one of those policies.
Setting up policy in Old Dot

Within the policy in Old Dot, navigate Settings > Categories and verify that People must categorize expenses is enabled.
Within the policy in Old Dot, navigate Settings > Tags and verify that People must tag expenses is enabled.

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
N/A

Android: mWeb Chrome
N/A

iOS: Native
N/A

iOS: mWeb Safari
N/A

MacOS: Chrome / Safari
N/A

MacOS: Desktop
N/A

@cead22 This is ready for review!

@mollfpr no worries! Let me grab that slack conversation.

Thanks @cdanwards! That looks clear enough.

The required back end changes are not yet finished to properly test this in the QA environment.

Just to ensure, can I test this PR in my DEV environment? Or should I wait till the BE changes are on staging?

@mollfpr Yes! You can test locally. Those instructions will let you access the workspace policy as a chat workspace in New Dot. Looks like I left out a step though (will add to comment):

Within the policy in Old Dot, navigate Settings > Categories and verify that People must categorize expenses is enable
Within the policy in Old Dot, navigate Settings > Tags and verify that People must tag expenses is enabled.

Sorry! I was bringing over some of these steps from a previous issue and must have missed this.

But is it possible that this is because these are no longer defined in a separate withOnyx?

I think you're right. I went ahead and split them back into 2 separate withOnyx calls and removed the check for the policy.id
cc: @cead22

Reviewer Checklist

[ ] I have verified the author checklist is complete (all boxes are checked off).
[ ] I verified the correct issue is linked in the ### Fixed Issues section above
[ ] I verified testing steps are clear and they cover the changes made in this PR

[ ] I verified the steps for local testing are in the Tests section
[ ] I verified the steps for Staging and/or Production testing are in the QA steps section
[ ] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[ ] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[ ] I checked that screenshots or videos are included for tests on all platforms
[ ] I included screenshots or videos for tests on all platforms
[ ] I verified tests pass on all platforms & I tested again on:

[ ] Android: Native
[ ] Android: mWeb Chrome
[ ] iOS: Native
[ ] iOS: mWeb Safari
[ ] MacOS: Chrome / Safari
[ ] MacOS: Desktop

[ ] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[ ] I verified proper code patterns were followed (see Reviewing the code)

[ ] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[ ] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[ ] I verified that comments were added to code that is not self explanatory
[ ] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[ ] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[ ] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[ ] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[ ] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[ ] I verified the JSDocs style guidelines (in STYLE.md) were followed

[ ] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[ ] I verified that this PR follows the guidelines as stated in the Review Guidelines
[ ] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[ ] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[ ] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[ ] If a new component is created I verified that:

[ ] A similar component doesn't exist in the codebase
[ ] All props are defined accurately and each prop has a /** comment above it */
[ ] The file is named correctly
[ ] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[ ] The only data being stored in the state is data necessary for rendering and nothing else
[ ] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[ ] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[ ] All JSX used for rendering exists in the render method
[ ] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[ ] If any new file was added I verified that:

[ ] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[ ] If a new CSS style is added I verified that:

[ ] A similar style doesn't already exist
[ ] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[ ] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[ ] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[ ] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[ ] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[ ] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[ ] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[ ] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

@lindboe is working on fixing the conflicts on this one

Hmm, sorry, something seems to have gone wrong with my merge attempt (I tried not to merge main directly since it has broken the mobile apps), and so I grabbed an earlier commit from with the relevant change in it, so I'm not sure why the diff is so large now.
I'll revert and do it a different way.

Ended up just merging latest main, conflict should be resolved now, but the aforementioned issue with testing the mobile apps may remain.

@mollfpr this is ready for you again

Updated to work with the new IOURequestStepConfirmation component, which is the replacement for MoneyRequestConfirmPage and is now what the app navigates to when creating a request. We technically don't need the updates to MoneyRequestConfirmPage anymore, but I figured while it's there I'd leave it alone.
It looks like we're getting unrelated typecheck failures, I'll try merging main.

Merging main doesn't fix the CI issues, brought to Slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1702943306379829

I am seeing a console error that at first I thought was related, but isn't looking like it:
```Warning: Failed prop type: Invalid prop transactions.transactions_9077313292658808828.receipt of type array supplied to LHNOptionsList, expected object

After creating a new request.

It's _very_ odd, because I can't find anything that would create the receipt object as an array object, but even weirder, if I got the data that `LHNOptionsList` is receiving, after refreshing the app and watching a few re-renders, the problematic receipt key _changes_ from an array to an object. Nature is healing 😂

Okay, updated again and should be good to go

Discussed with @cead22 and it sounds like all of the commands that consume buildOnyxDataForMoneyRequest should be updated to use these policy args wherever possible. Pause on review while I update this and the tests.

@cead22 It seems like I'm going to need some help getting the PR author checklist check to pass since I can't edit the description.  I also re-wrote the test plan to include distance requests, see below.
Updates
I pushed only updates to createDistanceRequest as it seems like the commands to split requests don't apply with workspaces, which are the only cases where we'll have a relevant policy, as far as I know. If that's wrong let me know and I can push updates for the rest.
Note for posterity
I was confused why we were getting an empty object for policy when there isn't one that matches (instead of undefined). Looks like it's being set by the defaultProps just by... convention? Or to keep the same behavior as withPolicy. I find this a little confusing (and will be more complex to type down the road) and wouldn't mind changing it.
Rewritten test plan:
Setup:

Follow the instructions [here](https://expensify.slack.com/archives/C05EQBQG6E5/p1695182901255769) to set up a policy with a workspace in New Dot.
Within the policy in Old Dot, navigate Settings > Categories and verify that People must categorize expenses is enabled, and make sure there's at least one category on the policy
Within the policy in Old Dot, navigate Settings > Tags and verify that People must tag expenses is enabled, and make sure there's at least one tag enabled on the policy

Testing the code worked correctly

Navigate to the ONYXDB -> keyvaluepairs within your browser storage tab
Identify the transaction that was created with the dollar amount you specified, should look like transactions_someID
Verify there's a transaction violations object with the corresponding ID like transactionViolations_SameIDasTransaction, with the missingCategory and missingTag violations in the array (unless the test says otherwise)

What to test

Create a money request and request money from your workspace with the policy you set up earlier. You should see the missingCategory and missingTag violations.
Create a money request and request money from another person instead of a workspace. You should NOT see a corresponding transactionViolations_ object.
Create a distance request and request money from your test workspace. You should see the missingCategory and missingTag violations.

Offline tests
For each test that generates a transactionViolations_ object, test it offline as well. The results should be the same.
QA Steps
Same as tests, both online and offline

I pushed only updates to createDistanceRequest as it seems like the commands to split requests don't apply with workspaces, which are the only cases where we'll have a relevant policy, as far as I know. If that's wrong let me know and I can push updates for the rest.

What about manual and scan requests?

What about manual and scan requests? maybe manual is covered by 1. in what to test, and if so, can we add another test to test the receipt flow?

Sorry, by "I pushed only updates to createDistanceRequest" I meant that in addition to requestMoney, and requestMoney is called the same way regardless of whether it's a manual or smart scan (because of the callback created in the component that closes over args like policy) so I didn't make a separate test case for it. We can add that though. Manual request is definitely the test case of #1 in "what to test".

@mollfpr can you please re-review, re-test this when you get a chance?

@cead22 PR checklist attached with the caveat that I don't think testing all platforms is currently reasonable at the moment, for a few reasons:

There's no visible updates, although I did check to make sure no unusual behavior was happening on all the platforms. (Android does have a non-blocking bug from main,
I can't find a reasonable way to test this on Android without writing new code to monitor the transaction/transactionViolation collections and print new ones that are added, at which point I'd need to test the testing code to make sure it's correct. It does seem like it would be good to have tooling to monitor Onyx changes on native platforms more easily.
This code really should not be platform-specific. I understand wanting to check and verify, but the odds seem very, very low.

So I did some quick sanity testing on the major platforms, but not every permutation of the test on each. Wasn't able to complete that in time.
Android warning workaround: Temporarily add 'Double' to the list of log messages to filter out in App.js and that warning will stop popping up.
LogBox.ignoreLogs([
    // Basically it means that if the app goes in the background and back to foreground on Android,
    // the timer is lost. Currently Expensify is using a 30 minutes interval to refresh personal details.
    // More details here: https://git.io/JJYeb
    'Setting a timer for a long period of time',
    'Double',
]);

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos
No visible changes are expected at this point; violations are not yet displayed in the app.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

Add a category and a tag, and confirm the violations are gone

@cead22 @lindboe Regarding the above step, is this on editing the request or creating a new request? I don't see it removing the transactionViolations_SameIDasTransaction from the previous request.

@mollfpr This should be reviewable now!

Reviewer Checklist

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

https://github.com/Expensify/App/assets/25520267/11386294-9dc1-48a5-9e56-7117b13ee62c
https://github.com/Expensify/App/assets/25520267/a62fa99c-3b5f-40a9-8a81-76180a676f62
https://github.com/Expensify/App/assets/25520267/0bf4a7ef-10b9-4299-a834-9995e9530e35
https://github.com/Expensify/App/assets/25520267/9aa445db-ceee-40b6-aff0-5a829e7489e8

Android: mWeb Chrome

https://github.com/Expensify/App/assets/25520267/f87dcb77-5aa2-4578-9e9c-aa3218b1c089
https://github.com/Expensify/App/assets/25520267/91e01b2d-5044-4b93-b107-faaf6042c8d1
https://github.com/Expensify/App/assets/25520267/6fe6a857-5b51-4c15-953f-d8391971923f
https://github.com/Expensify/App/assets/25520267/2403b694-8ac2-4d5e-a471-0187cbcaea1e

iOS: Native

https://github.com/Expensify/App/assets/25520267/2a71f3e0-a7bf-4597-8280-e6bfc9b3ef2e
https://github.com/Expensify/App/assets/25520267/028fc912-68e6-44c3-963b-8d297daa20db
https://github.com/Expensify/App/assets/25520267/6bb78c48-e72b-4e74-a1d4-da439148cf96

iOS: mWeb Safari

https://github.com/Expensify/App/assets/25520267/1409a734-a798-4d0b-bdf1-38b830db0e78
https://github.com/Expensify/App/assets/25520267/aceac3f9-5723-4e32-aa52-08a9fa8b9d65
https://github.com/Expensify/App/assets/25520267/8d0981b4-473e-4b87-8304-6306c0020875
https://github.com/Expensify/App/assets/25520267/528ddd17-93d9-4a67-bfe7-bb7a1c1abe80

MacOS: Chrome / Safari

https://github.com/Expensify/App/assets/25520267/82e2252a-83dd-4d4f-82da-6a2f17586719
https://github.com/Expensify/App/assets/25520267/86a7652b-8285-4509-8517-10d5164ebbe1
https://github.com/Expensify/App/assets/25520267/cd067ec4-e338-4ffa-a3e8-13a3a485da14
https://github.com/Expensify/App/assets/25520267/d82a2cd3-f56f-47f9-a514-4365444817c9
https://github.com/Expensify/App/assets/25520267/09557bad-6bfd-4c53-8cc8-a6d012854c8f
https://github.com/Expensify/App/assets/25520267/aae2e1a7-857c-43a8-927d-5d1e9a3b245b

MacOS: Desktop

https://github.com/Expensify/App/assets/25520267/d73a78d8-8971-49a1-8fd6-c49fd30eaa95
https://github.com/Expensify/App/assets/25520267/e7347004-9890-46c0-b0ae-0d9ad86d7f3c
https://github.com/Expensify/App/assets/25520267/157ebd41-725a-4632-b5b0-1792fd61fbbe
https://github.com/Expensify/App/assets/25520267/c43a75b6-006c-4825-953a-20dfc821be08

Seeing Invalid prop reportActionsof typeobjectsupplied toReportScreen, expected an array which was brought up here https://expensify.slack.com/archives/C02NK2DQWUX/p1700167185955379?thread_ts=1700167075.099769&cid=C02NK2DQWUX, and it exists in main along with several others errors

The Android videos were outdated, and I tried running the app on android but I was getting an error. @mollfpr ran this on native iOS (sim) after merging main into this branch (here) and things worked. I also tested on web and things worked, so I'm merging to avoid this getting more conflicts tomorrow

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.23-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

@cdanwards Could you help us with the steps 4,5 and 6 in "What to test" section?

@kavimuru May I help you with the problem?

@mollfpr where do we have to check "You should NOT see a corresponding transactionViolations_ object.

@kavimuru The object is on the browser storage, so we can only verify it on the Web. You can see the below video on how to get there.
https://github.com/Expensify/App/assets/25520267/df4480f4-f6b0-48ee-9210-bf5b843febd6

🚀 Deployed to production by https://github.com/thienlnam in version: 1.4.23-4 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
failure ❌

🕸 web 🕸
success ✅

@kavimuru @mollfpr Let me know if you require any more assistance! I've been out on parental leave but am now back to work.


Added evaluator for code-code translation: Update eval.py

Updated eval.py to the evaluation framework for code-code translation between languages in CodeXGLUE

@chaseltb readme file is missing. Can u provide a clear readme file by following the same structure of the example https://github.com/SEEDGuard/SEVAL/blob/main/src/tasks/code_generation/README.md?


[MINOR][PS][DOCS] Add DataFrame.{from_dict, to_orc} to API references

What changes were proposed in this pull request?
Add DataFrame.{from_dict, to_orc} to API references
Move DataFrame.info to attributes according to https://pandas.pydata.org/docs/reference/frame.html#attributes-and-underlying-data
Why are the changes needed?
add missing doc
Does this PR introduce any user-facing change?
yes, doc updated
How was this patch tested?
CI and manually check

Merged to master.


Update Contribute page index.md to current GitHub procedure

In fixing a simple speed bump between Quick edit steps 2-3, I discovered that the overall procedure has changed, as presented to the Edge browser.
I have not replaced the images.  If review confirms the changes to the text, I am happy to provide new captures of the dialogs.
Contributor guide pull request
Thanks for contributing to the Microsoft Learn documentation contributor guide. Please read these instructions for processing your pull request (PR). Once you've read this text, delete it and write a brief description of the changes you're proposing.
Quality control

[ ] 1. Successful build with no warnings: Review the build status to make sure all checks are green (Succeeded).

[ ] 2. #Sign-off: Once the PR is finalized and ready to be merged, indicate so by typing #sign-off in a new comment in the PR. Signing off means the document is ready for review and can be published at any time.

Merge and publish

All PRs to this repository are manually reviewed and merged.
Once all feedback on the PR is addressed, we'll merge the PR into the main branch.

Need help?

See our guidance on Contributing to the contributor guide for help with adding or updating content in this contributor guide.
Write to the PR reviewer in the PR comments: @carlyrevier, @jehchow

I apologize for not cleaning the Pull-request template before submitting.
There may be a further glitch with regard to the current GitHub procedure.  It appears that the pull request is created at step (5) but it remains staged at the automatic fork (orcmid/Contribute in this case) and is not yet submitted to the origin (Microsoft/Contribute).  I ended up completing the pull request at GitHub.  (I wasn't certain what trying it from the Github Windows client would accomplish.)

I will confirm (2) when I do another run-through and capture new dialog image.

Closing because this is superseded by/address in #813. Thank you for these investigations and feedback. We'd appreciate feedback on the new instructions as you use them. :)


Quest Stage - WorldGuard Region

Hi!
I'm trying to set up a Quest that makes the player leave my spawn area. Essentially, I have a region named "Spawn", when the player enters the region "Spawn", they are given the quest "Leaving Spawn"
I want to reward the player for leaving the Spawn region to assist new players with the idea of building away from spawn and being safer from griefing
I assume the most appropriate location for this would be under Stages > Reach Location
Then an option "Exit Region" and "Enter Region"
Adding an Enter Region option would also be useful as it will allow players to progress quests when arriving in a particular city. Another example, I have a plugin that creates Dungeons in the world and you can configure it to set a WorldGuard region around the dungeon. You could configure a generic quest, "Complete Dungeon" that starts when you enter the Dungeon Region

First, I'd like to note that you can start a quest by entering a WorldGuard region through the "Set Region" selection in the quest creation prompt, shown as option '6' here:

While I concede that entering/exiting a region during the quest could be a useful objective, Quests generally avoids using external plugins for objectives, with the exception of Citizens (and also Denizen scripts, but those will likely be moved to the Actions Editor in a future version). This is because the ability to customize built-in objectives is limited by design.
For example, let's say we add your Exit Region objective and set it up for exiting region 'A'. It works great, however another user only wants the objective to work if region 'A' is a parent of region 'B'. Yet another user wants it to apply only if the region has a PvP flag active. Finally, a third user wants it to work when exiting all regions except region 'A'.
This level of customization is best left to a module with a dedicated author that can add that kind of flexibility upon request. Similarly, it'd be incredible if I had time to flesh out the Kill Mobs objective to include all kinds of crazy custom mobs, but there's a module for that. In conclusion, your idea is a great one - for a module. Feel free to request a developer make one for you on the SpigotMC hiring forums (not affiliated with Quests) and direct your developer to the following page:
https://github.com/PikaMug/Quests/wiki/Master-‐-Custom-Quest-API#objectives-api


DataFrame chunks will have duplicate indices

If a ROOT file is loaded in chunks, the individual DataFrames will have the same starting value for the index. If you then save these chunks to a single file (with mode='a') and then load from that file in to a single DataFrame, its index will have duplicate values.
import numpy as np
import root_numpy
import root_pandas

# Create the file with root_numpy directly, so the input doesn't have an index
xs = np.array(np.vstack(np.random.normal(0, 1, 100)), dtype=[('x', float)])
root_numpy.array2root(xs, 'input.root', 'tree', mode='recreate')

# Read the file in chunks and then write to the output
# Use write-mode for the first chunk, then use append mode, to make sure the output is re-created
for idx, df in enumerate(root_pandas.read_root('input.root', chunksize=10)):
    if idx == 0:
        mode = 'w'
    else:
        mode = 'a'
    df.to_root('output.root', mode=mode)

df = root_pandas.read_root('output.root')
dup_mask = df.index.duplicated()
print(dup_mask.any(), df[dup_mask].index.size)

prints True, 90.
These duplicate values are problematic when performing certain operations.
One work-around is to set the index values by hand in the loop.
chunksize = 10
for idx, df in enumerate(root_pandas.read_root('input.root',
                                               chunksize=chunksize)):
    if idx == 0:
        writemode = 'w'
    else:
        writemode = 'a'
    # Offset the index of this chunk
    df.index += idx*chunksize
    df.to_root('output.root', mode=writemode)

Should root_pandas do this for us? It surprised me when I first saw it. But if you're only manipulating the chunks, i.e. not saving them to the same file, you won't encounter this problem, and maybe that's the more common use case of chunksize.

It definitely shouldn't do this :(
I'll have a look at fixing this.


[ClangImporter] C static-qualified array params are non-nullable.

If the keyword static also appears within the [ and ] of the array type derivation, then for each call to the function, the value of the corresponding actual argument shall provide access to the first element of an array with at least as many elements as specified by the size expression. (C11 <IP_ADDRESS>p7)

Limit this change to Swift 4 so as not to break existing code, though use of static in this way is rare to begin with and passing nil would probably be an error anyway.
Small part of rdar://problem/25846421.

@milseman Does this look okay?
@swift-ci Please smoke test

bump

I left a code review question @jrose-apple

@swift-ci Please smoke test


[Bug] feed not processed

The feed of my content does not appear to be processed https://www.wearedotnet.io/kaylumah

Hey!
can you further say what you mean by not processed? I can see posts and the last like 7 months ago

@DeeJayTC my post from this week (which is in the feed) is not appearing :)

The feed https://kaylumah.nl/feed.xml has an entry for 2023-04-13 :)

hmm weird, let me find out why its ignoring that one

I pushed it again, lets see if the next hourly sync catches it

Parsed now @kaylumah can't really tell why it wasn't picked up earlier, can take a bit until its in the cache everywhere and displayed.

Landing page and RSS feed has it already, closing this one here :)

Thank you, have a great day :)


clientSecret should not be passed as a queryPararm?

Bug report
Describe the bug
Hi there. Working on an integration when I came across the code in the frontend vanillajs example that passes the client secret between pages: https://github.com/stripe-samples/subscription-use-cases/blob/master/fixed-price-subscriptions/client/vanillajs/prices.js#L53-L55.
I know this repo is just for example and not expected to be a highly secure configuration. But in the tutorials online the handling of client secret was fairly opaque to me. For example in https://stripe.com/docs/billing/subscriptions/build-subscription, I inferred I should be accept the POST response from the Subscription.create call as JSON and then do some in-page DOM modifications to show the new payment element created w/the client secret, but I wasn't sure. Then when I found this github repo I was like "Voila! They just make a GET request and pass the clientSecret as a query param! Then the new subscribe.html page has its own js script lifecycle, and sets up the payment element - so easy! Client secret must not be that secret after all!"
Until I came across the API docs for payment element, https://stripe.com/docs/payments/payment-intents#passing-to-client, which explicitly state

Don’t log it, embed it in URLs, or expose it to anyone other than the customer.

Like I said, I understand the example repo says its not supposed to be secure, but shouldn't it follow the major expectations set by the API docs? This seems like a fairly substantial code flow difference. Passing the client secret as a query param is embedding it in the URL, to get logged, cached, etc. Or am I confused here (admittedly very likely)?
Anyway, I figured out how I'm going to proceed personally, but thought some attention might be given to this issue. Thanks!

Thanks for your feedback!
How do you think that using the window.sessionStorage instead of the URL querystring?
Thanks!

We've removed the queryParam from the example.
PR:  #220
Thanks for the feedback :)


260 move to uv

Pull Request Test Coverage Report for Build<PHONE_NUMBER>7
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 94.118%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
448

Relevant Lines:
476

💛  - Coveralls


Allow bounds on parameters in GST optimizer

Models containing interpolated gates are only defined for a finite range of parameters. I'd like to be able to fit these models using GST.
It would be very helpful if the GST optimizer could accept hard bounds (or inequality constraints) on the parameters.
Alternatives include changing the interpolated gates to behave in some controlled manner outside of their bounding boxes, and then double checking that the optimizer hasn't converged on an infeasible point.

This functionality has been added in version 0.9.10, and can be accessed by setting the parameter_bounds attribute of model members (e.g. gate objects).


"overflow: hidden" is not removed from  after  closes

Bug report 🐞
Version & Environment

Chrome 94 & Firefox 93
"@geist-ui/react": "^2.2.0",
I am using Next JS but I don't think that is of any relevance.

Expected Behaviour
If I click on a link inside the <Drawer> component, I'll go to another page. Before going to another page the overflow: hidden should be automatically removed from <body> but this does not happen.
Actual results (or Errors)
Because the overflow: hidden persists on the body, the content on the next page is not scrollable and the entire app is now without scroll ability. For me, the content on the next page is stuck outside of the viewport:
https://user-images.githubusercontent.com/53701884/137165550-c7dba1bb-f888-4ab0-97ee-19c62acbf723.mp4
It is also causing the infamous update state after unmounting (memory leak) error for me:
react_devtools_backend.js:2526 Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in a useEffect cleanup function.
    at http://localhost:3000/_next/static/chunks/pages/_app.js?ts=1634214302053:9364:23
    at DrawerComponent (http://localhost:3000/_next/static/chunks/pages/_app.js?ts=1634214302053:3790:28)
    at http://localhost:3000/_next/static/chunks/pages/_app.js?ts=1634214302053:14348:25
    at div
    at Navigation (http://localhost:3000/_next/static/chunks/pages/index.js?ts=1634214302053:16869:66)
    at div
    at GlobalContainer (http://localhost:3000/_next/static/chunks/pages/index.js?ts=1634214302053:16292:23)
    at Home

This is the main problem (memory leak). As soon as I use the visible props on the drawer, I get this error changing pages.

This issue has been closed for a long time without activity, please reopen it if there is an update.


Package.swift is not included in the latest release

Hello! Just a notice since I tried to include your lib in a project using SPM but Package.swift is not included in the 1.0.4 release. Thank you!

Hi, Thanks @artemisia-absynthium . Now it's included in the build 1.0.5.

Thanks a lot!


include npm parse module in client browser => Access-Control-Allow-Origin

Hi
I directly include  var Parse = require('parse');  in client browser.
Which can save File / Object in my localhost.
However, when I deploy the app to production server which have a custom domain.
All cross domain ajax call blocked by Access-Control-Allow-Origin
How can I enable my domain?

Sorry, seems that is my own account problem. Will check with CS


added Grand Traverse County, MI, USA

Fixes #2360

See if the issues noted in https://github.com/openaddresses/machine/issues/560 are better now:
Re-run this please.

Yes, output is now marked as failed and "no address" is logged: http://results.openaddresses.io/jobs/aa1bb1a4-6b7f-49db-901c-b65b5fb2056e


Supply failed init option with error: applicationNotFound

Issue Description
I have tried getting supply to upload an android build/apk to google play but i get this error when supply is being run with init.
Complete output when running fastlane, including the stack trace and command used
TEMP-DU-EL11-6:a53fcdb18986a3f5 admin$ /Library/android-sdk-macosx/build-tools/21.1.1/aapt dump badging android.apk | grep package:\ name
package: name='com.tastybits.testteamcity' versionCode='1' versionName='1.0' platformBuildVersionName='5.0.1-1624448'
TEMP-DU-EL11-6:a53fcdb18986a3f5 admin$ supply init --json_key ~/Dropbox/gplaydev.json
[02:01:33]: Fetching a new access token from Google...
[02:01:34]: To not be asked about this value, you can specify it using 'package_name'
The package name of the Application to modify: com.tastybits.testteamcity
-------------------------------------------------------------------------------------------
😨  An error occured. Please enable crash reports using `fastlane enable_crash_reporting`.
👍  This makes resolving issues much easier and helps improve fastlane.
🔒  The reports will be stored securely on getsentry.com.
🙊  More information about privacy: https://github.com/fastlane/fastlane/releases/tag/1.33.3
-------------------------------------------------------------------------------------------
/Library/Ruby/Gems/2.0.0/gems/google-api-client-0.9.2/lib/google/apis/core/http_command.rb:202:in `check_status': [!] applicationNotFound: No application was found for the given package name. (Google::Apis::ClientError)
	from /Library/Ruby/Gems/2.0.0/gems/google-api-client-0.9.2/lib/google/apis/core/api_command.rb:103:in `check_status'
	from /Library/Ruby/Gems/2.0.0/gems/google-api-client-0.9.2/lib/google/apis/core/http_command.rb:170:in `process_response'
	from /Library/Ruby/Gems/2.0.0/gems/google-api-client-0.9.2/lib/google/apis/core/http_command.rb:275:in `execute_once'
	from /Library/Ruby/Gems/2.0.0/gems/google-api-client-0.9.2/lib/google/apis/core/http_command.rb:107:in `block (2 levels) in execute'
	from /Library/Ruby/Gems/2.0.0/gems/retriable-2.1.0/lib/retriable.rb:54:in `block in retriable'
	from /Library/Ruby/Gems/2.0.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `times'
	from /Library/Ruby/Gems/2.0.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `retriable'
	from /Library/Ruby/Gems/2.0.0/gems/google-api-client-0.9.2/lib/google/apis/core/http_command.rb:104:in `block in execute'
	from /Library/Ruby/Gems/2.0.0/gems/retriable-2.1.0/lib/retriable.rb:54:in `block in retriable'
	from /Library/Ruby/Gems/2.0.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `times'
	from /Library/Ruby/Gems/2.0.0/gems/retriable-2.1.0/lib/retriable.rb:48:in `retriable'
	from /Library/Ruby/Gems/2.0.0/gems/google-api-client-0.9.2/lib/google/apis/core/http_command.rb:96:in `execute'

Environment
supply-0.5.2

@krismort It seems like there is no app with the package "com.tastybits.testteamcity" (Error from google API is: No application was found for the given package name). Can you confirm that that app exists in Google play already and that the account you're using for auth has access to it?

Isn't the first build what defines the package value when uploaded ?  I created an app but i cannot find a place in the google developer console where you can define a value like the packagename. I can try and upload one manually and see if that's the case.

supply init downloads existing metadata for an app.
supply will upload new metadata for an app (or a new apk for an existing app), but cannot upload a brand new app due to Google API limitations.
So you'll have to create the app in Google Developer Console first, then you can automate making updates to it (new builds, new metadata). Hope this helps!

Thanks, do you know if anyone has created a tool for automation of app creation and uploading the first app via  a headless browser or some homebrewn library like spaceship ?

I don't know of anything, but if you find a way let us know! 🚀


feat(#BRU-7) - scrollbar styling for linux and windows

Improved scrollbar styling for linux and windows
scrollbar_styling.webm

Thanks @lohit-1 !

@lohit-1 : is there a way to turn this off? Thin scrollbars (along with scrollbars that are not always visible) are very bad for usability.

@cvmocanu Can you share a screenshot of how the scrollbar appears on your machine. We should be able to provide a toggle to use the system scrollbar instead of overriding it (that was done as a part of this PR).

Improved scrollbar styling for linux and windows scrollbar_styling.webm

hi, @lohit-1
I have previously worked on this issue, but I have not found an idea.
could you describe in more detail how and why it works?
// scrollbar styling
// the below media query target non-macos devices
// (macos scrollbar styling is the ideal style reference)
@media not all and (pointer: coarse)

I created a test page with this code and it showed:
Windows/Chrome: NO MAC
MacOS14.3/Safari: NO MAC
MacOS14.3/Chrome: NO MAC
Android14/Chrome: MAC

MAC

NO MAC


Revisit EventHubsSharedKeyCredential

Summary
Within the Event Hubs client library, there exists a credential type intended to allow the shared key for an Event Hubs namespace or an Event Hub to be used with the client library without the need to provide a connection string.   This type was removed from the preview.6 release in order to allow time to align across languages and ensure that it was consistent with the Azure.Identity library direction and guidance.  It is believe that this credential has merit and should be revisited for inclusion in the public API.
Scope of Work

Coordinate with the other language contributors within the Event Hubs feature team and ensure consistency of design.

Coordinate with the Azure.Identity leads for their guidance and ensure alignment with Identity offerings.  Incorporate any feedback deemed minor and, if needed, create dedicated issues to track implementation for non-trivial workstreams.

Review the final proposed form of the EventHubsSharedKeyCredential with the .NET architect.

Change visibility of the credential type, remove it from the source code, or file an issue to revisit if there is justification and criteria to delay.

Success Criteria

Design and review tasks detailed by the scope have been completed.

The refactoring and enhancements detailed by the scope have been completed.

The tests necessary for its validation have been created or adjusted and pass reliably.

The existing test suite continues to produce deterministic results and pass reliably.

Superceded by #16418


Upgrade Checker Framework Annotations 3.46.0 -> 3.47.0

This PR contains the following updates:

Package
Type
Update
Change

Checker Framework Annotations (source)
compile
minor
3.46.0 -> 3.47.0

Release Notes

typetools/checker-framework (Checker Framework Annotations)
v3.47.0: Checker Framework 3.47.0
Version 3.47.0 (September 3, 2024)
User-visible changes:
The Checker Framework runs under JDK 22 -- that is, it runs on a version 22 JVM.
The Checker Framework runs under JDK 23 -- that is, it runs on a version 23 JVM.
The Optional Checker no longer supports the @OptionalBottom annotation.
Implementation details:
Removed annotations:

@OptionalBottom

Closed issues:
#6510, #6704, #6743, #6749, #6760, #6761.

[ ] If you want to rebase/retry this PR, check this box

Suggested commit message:
Upgrade Checker Framework Annotations 3.46.0 -> 3.47.0

See:
- https://github.com/typetools/checker-framework/releases/tag/checker-framework-3.47.0
- https://github.com/typetools/checker-framework/compare/checker-framework-3.46.0...checker-framework-3.47.0


Switch to CMake for Linux desktop

Description
Updates the Linux templates to use CMake+ninja, rather than Make, and updates the tooling to generate CMake support files rather than Make support files, and to drive the build using cmake and ninja.
Also updates doctor to check for cmake and ninja in place of make.
Note: While we could use CMake+Make rather than CMake+ninja, in testing ninja handled the tool_backend.sh call much better, calling it only once rather than once per dependent target. While it does add another dependency that people are less likely to already have, it's widely available in package managers, as well as being available as a direct download. Longer term, we could potentially switch from ninja to Make if it's an issue.
Related Issues
Fixes https://github.com/flutter/flutter/issues/52751
Tests
I added the following tests: Mostly just updated tests, but added some to cover the fact that there's one more binary in the workflow now.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[x] I signed the CLA.
[x] I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
[x] I read the Tree Hygiene wiki page, which explains my responsibilities.
[x] I updated/added relevant documentation (doc comments with ///).
[ ] All existing and new tests are passing.
[x] The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.

[ ] No, no existing tests failed, so this is not a breaking change.
[x] Yes, this is a breaking change. If not, delete the remainder of this section.

[ ] I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
[ ] I got input from the developer relations team, specifically from: Replace with the names of who gave advice
[ ] I wrote a migration guide: Replace with a link to your migration guide
[x] Linux is currently exempt from the breaking change policy. The tool itself provides migration instructions.

I've never used CMake before, so it's probably not perfect. I'm pretty sure it's better than the Makefile was though :)


Project System: Port AppDesigner/Editors tests

From @davkean on April 1, 2016 17:27
We need to AppDesigner/Editors tests from internal.
Copied from original issue: dotnet/roslyn#10255

This has been done: https://github.com/dotnet/roslyn-project-system/pull/1705


Implement cert expiry checking without libc

Add features and implementations of time related functions to use when libc isn't available.
Because of feature weirdness I added a use_libc feature for those that want to just use libc.
The gmtime_r function is written with chrono, as is the custom time function.

Changes all look good. A test would be nice (eg using a certificate with known validity range), as would checking the build for some of the relevant configurations in ct.sh - right now we are not testing time+no-std builds so I don't think this code is being built at all.

bors r+


not blank!

having a webhook bot that deals in issues is dire

having a webhook bot that deals in issues is dire


docs: add extensions

Add the following to README.md

CLI
Chrome Extension
Raycast Extension

This looks super useful, thank you!


[ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined

Hi All,
we are seeing the error "[ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined" after adding the serverless-bundle plugin.
error stack:
erverless: Auto instrumenting functions with Datadog
Serverless: Adding Lambda Layers to functions
Serverless: Compiling with Typescript...
Serverless: Using local tsconfig.json
Serverless: Typescript compiled.
Serverless: Invoke webpack:validate
Serverless: Invoke webpack:compile
Serverless: Bundling with Webpack...
Serverless: Invoke webpack:package
Serverless: No external modules needed
Serverless: Packaging service...
Type Error ---------------------------------------------
TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received undefined
at new NodeError (node:internal/errors:277:15)
at validateString (node:internal/validators:123:11)
at Object.basename (node:path:1156:5)
at TypeScriptPlugin. (node_modules/serverless-plugin-typescript/src/index.ts:203:12)
at Generator.next ()
at fulfilled (node_modules/serverless-plugin-typescript/dist/src/index.js:4:58)
From previous event:
at PluginManager.invoke (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:521:22)
at /usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:556:24
From previous event:
at PluginManager.run (/usr/local/lib/node_modules/serverless/lib/classes/PluginManager.js:556:8)
at /usr/local/lib/node_modules/serverless/lib/Serverless.js:203:33
at processImmediate (node:internal/timers:463:21)
From previous event:
at Serverless.run (/usr/local/lib/node_modules/serverless/lib/Serverless.js:190:74)
at /usr/local/lib/node_modules/serverless/scripts/serverless.js:50:26
in serverless.yml
plugin:

serverless-plugin-typescript
serverless-plugin-datadog
serverless-plugin-include-dependencies
serverless-dependson-plugin
serverless-offline
serverless-bundle

Thank you

I only get this error when working with layers (for the entire node_modules) and try to deploy only one function...

I only get this error when working with layers (for the entire node_modules) and try to deploy only one function... No problems to deploy the entire stack... No problems when not using layers, to deploy a single function...

Did you have serverless.yml and tsconfig.json in different locations? I do and I can't make it work at all

No... They are in the same location...


Remove Options.compose(options)

Removes the accidentally added options argument for Options.compose by 75cf9166c3d5d159895de123e24a9ce748804a1a.
Resolves #1934.
New Pull Request Checklist

[x] I have read the Documentation
[x] I have searched for a similar pull request in the project and found none
[x] I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
[ ] I have added the required tests to prove the fix/feature I'm adding
[ ] I have updated the documentation (if necessary)
[x] I have run the tests without failures
[x] I have updated the CHANGELOG.md in the corresponding package

I was thinking that if we can make it less breakable by adding deprecation but leaving an unused argument for a long time is neither a good choice.


Add QUnit integration

Example:
import { module, test } from 'qunit';
import { expect } from 'chai';
import { withChai } from 'ember-cli-chai/qunit';

module('test');

test('it works', withChai(function(expect) {
  expect(5, '5 < 10').to.be.below(10);
}));

Resolves #3
/cc @lolmaus @akatov @mattmcmanus @justin-hackin

/cc @trentmwillis

this does seem to have issues with async tests though... will have to investigate


WIP: Fix codacy coverage and report combined unit/acceptance coverage

The coverage reporting path for pytest-cov was previously set incorrectly, causing no coverage data file to be created.
This PR also applies coverage testing to the acceptance tests, so acceptance test coverage is appended to the unit test coverage and the combined coverage result gets reported to codacy and codecov. This will currently have no effect, as all the acceptance tests are skipped on Travis CI.

This change hasn't produced coverage information on codacy as expected, so will need further investigation.
Please leave this PR open (marked as WIP/don't merge yet) so that codacy will run on any new changes in this branch.

Coverage file is now being produced in the branch, and I've added a text report which will be visible in the Travis CI log. The Codacy API token is only available on branches within metoppv/improver, so coverage information of branches in personal forks won't appear on Codacy.
Codacy should pick up the coverage once merged to master. Please go ahead and review this PR now.

But with a view to moving away from travis and improver-tests, do you think it would be worth doing new things in GitHub actions (as standalone scripts, rather than expanding on improver_tests)?

Yes, I agree with the intention to move from Travis to Github actions.
Github actions automatically running on branches in personal forks is quite attractive, because it'll pick up problems before pull requests are created, rather than the current situation of creating a pull request, and then finding out about various errors via comment spam from bots in the PR comments.
For example, I've fetched LaurenceBeard-tests-action metoppv/improver@dbebea0301f into my improver fork and pushing that branch to github has triggered the tests to run in my personal fork.


support grpc client mux

grpc client supports mux, but we now only get a connection from pool. why not use the pool as a streams pool? we can use maxStreams to control the number of streams on a connection. while maxStreams = 1, it degenerate into a connection pool. this is the code.
and we use maxIdle to control the number of idle conn. if need, i can create a pr.

can you share some info for example speedup, or minimization of resource allocations, or some other benefits ?

yes, i had finished a test

nice, can you provide pr?


Docs on enforcing HTTPS and avoiding mixed content

The live documentation requested that someone fill in the section on "Always use https"
This PR includes a short reference on why to use HTTPS for all sites.
It also includes a more relevant warning about mixed active content.
Both paragraphs link to authoritative, neutral third-party sources.

Thanks @mdo! Regarding a getting started guide, the thing is the range of potential hosts is so large that there wasn't a getting started guide that I felt good about referring to with confidence that it would cover a meaningful subset of users. If they're using GitHub Pages or Netlify they have totally different needs than Wordpress and different than AWS and so on.
If anyone else has a reference they like I can link it but I think overall users will have to find their own for whatever host they're using, and that's ok!
This is my first PR with Bootstrap, what is the process of getting it merged now that it's approved?

I think further implementation details are outside of the scope of the guide. I mean, there are thousands of different services and software stacks.
I'd say we can merge this as is and expand it later.


Is there portable Kade Engine to Psych Engine for Mod charts

What is your question?
:/ Idk i'm wondering about

maybe becuz a modchart is a lua file

nvm shadowmarioo said psych lua and kade lua works diffrent

No.


Fix markdown of headlines in README.md

The were spaces missing between '#' and the actual headline text, preventing the markdown renderer here on GitHub to produce actual HTML headline elements for them

You can see the rendered markup here: https://github.com/sebkur/jmimeinfo/tree/fix-readme


Wanted To Share This Workflow Video Showcasing Your Awesome Custom Node

https://www.youtube.com/watch?v=kklIU2RqVOk

thanks 👍 how do u feel about the installation instructions ?

Your instructions were well written.  Though I have also previously installed Tensor RT through Radiata and A1111, so I had a bit of familiarity with the process.

@phineas-pta one thing I did have to pip install that wasn't in the directions was the following command
pip install onnxruntime

hmmm it's weird, it should rely on onnx not onnxruntime
thanks for the tip, i'll try to verify

@boricuapab if u have time pls test lora support (commit 85b7e2c ) to see if it works 4 u

thank u 🤗

there's no flag to convert lora
there's a new node to load lora

It works, but seems to use more vram.
Also the model in the onnx folder is required for the loras to work, where as without you could remove the onnx model and the trt model would still work when generating images.

yay! ty for the remark


Docker versus docker-compose

How difficult would it be to build this without docker-compose?  Some detailed instructions would be great.

You can pretty much convert docker-compose content line by line to a docker run command. e.g. for db service:
db:
  build: db
  volumes:
    - ./volumes/db/var/lib/postgresql/data:/var/lib/postgresql/data
    - /etc/localtime:/etc/localtime:ro
  # uncomment the following to enable backup
  environment:
    - AWS_ACCESS_KEY_ID=XXXX
    - AWS_SECRET_ACCESS_KEY=XXXX
    - WALE_S3_PREFIX=s3://BUCKET_NAME/PATH
    - AWS_REGION=us-east-1

to docker build and run
docker build -t mattermost-db db/
docker run \
  -v ./volumes/db/var/lib/postgresql/data:/var/lib/postgresql/data \
  -v /etc/localtime:/etc/localtime:ro \
  -e AWS_ACCESS_KEY_ID=XXXX \
  -e AWS_SECRET_ACCESS_KEY=XXXX \
  -e WALE_S3_PREFIX=s3://BUCKET_NAME/PATH \
  -e AWS_REGION=us-east-1 \
mattermost-db

You can also push the images to dockerhub or use existing images from dockerhub (db and app) if you don't want to build the image yourself. Just replace the last line mattermost-db to compass/mattermost-db. (Hopefully these guys will do an automatic build on dockerhub so that I don't have to maintain mine.)


Test-Movies-counter

This Pr includes :
in this branch, I add a test on the movie counter to check if it works proper or not.

Hi @muneeb3123 😊,
STATUS: APPROVED! 🥇 💯
Your project is complete!  There is nothing else to say other than... it's time to merge it :shipit: 🚀
Congratulations! 🎉
Highlights
✅ Project has met all the technical aspects you needed for this project. Keep rocking!
Cheers and Happy coding!👏👏👏


Add DelegateOperation#models

So that the beforeInsert() and afterInsert() static query hooks return correct model-data in inputItems
Closes #1839

@koskimas I am not sure this fix is in the right place. After submitting, I noticed that a few sub-classes of DelegateOperation already define this getter: InsertGraphOperation, InsertGraphAndFetchOperation,  UpsertGraphAndFetchOperation. I think the getter needs to move to InsertAndFetchOperation.

Coverage decreased (-0.005%) to 97.056% when pulling 00dfde996772447fff8e8c6e530ac2444b1d8199 on lehni:fix/add-delegate-operation-models into fc4190942a8926609925db42a547fb498b116149 on Vincit:master.


Check archive path before running

I had an optimization run for several hours even though the archive directory was missing, so all of the individuals crashed and had an xopt_error + xopt_error_str.  It might be useful for the user if Xopt checks that all paths passed to it at start up are checked to exists.

Archive path should be handled in the evaluator function.


pretrained model for updated code

Hi,
Can you please upload a newer pretrained model for the updated code?
It currently fails on error:
Tensor name "incept4b/branch3_5x5/conv1x1/batch_norm/batch_norm/gamma" not found in checkpoint files

Hi,
I don't what code you are running and which pretrained model you are trying to load but the intention is that the model is loaded from a metagraph file to avoid this kind of incompatibility problems. See validate_on_lfw.py for example.

Thanks for the response, I downloaded the model that you uploaded: 20170216-091149
I tried retraining it using "pretrained_model" argument in facenet_train_classifier.py and it failed with the error that I mentioned.
I don't want it just for inference, is it possible?

Thanks for answering, I downloaded the pretrained model

Hi,
It will not work out-of-the-box.
Even if you use the correct model definition (inception-resnet-v1) for the above model you will need to have the same number of classes in your dataset as I had when I trained the model. Otherwise it will be problem when loading the model.
Alternatively you can remove the last classification layer and prevent tensorflow from loading the parameters for that layer, but that will be some hands-on...

I have added a script 'classifier.py' that can train a small classifier on the facenet features. There is also a wiki page showing how to use it. Hopefully that will help.


Colab notebook error !gdown id--

Hi when i'm using the notebook i'm getting this error "[Errno 2] No such file or directory: 'merged.dict.txt'" The Gdown Id is not working it's saying this
"Access denied with the following error:
Cannot retrieve the public link of the file. You may need to change
the permission to 'Anyone with the link', or have had many accesses.

You may still be able to access the file from the browser:"
any solution?

This is the only issue ive seen of this, im working on an ai voice thing on colab and this is the only error simular to this on github, so ima wait for help

Same issue as this? https://github.com/wkentaro/gdown/issues/43


Ending Schedule after Iterations

If someone can help in increasing the coverage, that would be really appreciated.

Coverage decreased (-1.4%) to 98.643% when pulling 64115a766767d21bf8d02fdcb497b91a27202989 on f3n1Xx:Better into cd890d055b9dbd6dcbc697f2eda397e2e47a1d77 on dbader:master.


Adjust styles of Refine dashboard to be more MIT

What are the relevant tickets?
N/A
What's this PR do?
This PR updates a few styles so that it uses the MIT logo and colors instead of Refine's.
How should this be manually tested?
Run the app and verify the refine dashboard is still functional and looks like the screenshots.
Screenshots (if appropriate)

Codecov Report

Merging #606 (f7d065a) into main (2b568e5) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #606      +/-   ##
==========================================
+ Coverage   85.87%   85.91%   +0.03%
==========================================
  Files         121      121
  Lines        5219     5219
  Branches      847      847
==========================================
+ Hits         4482     4484       +2
+ Misses        604      602       -2
  Partials      133      133

Impacted Files
Coverage Δ

ecommerce/discounts.py
80.70% <0.00%> (+3.50%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b568e5...f7d065a. Read the comment docs.


encoding/json: Unmarshal to nil pointer documentation discrepancy

When trying to unmarshal a json string into a nil pointer, the operation fails as can be seen here:
https://play.golang.org/p/wL6UDpaJ-h
The error returned is InvalidUnmarshalError whose docs clearly state:
"The argument to Unmarshal must be a non-nil pointer." (https://golang.org/pkg/encoding/json/#InvalidUnmarshalError)
But the docs for the Unmarshal function state:
"Unmarshal unmarshals the JSON into the value pointed at by the pointer. If the pointer is nil, Unmarshal allocates a new value for it to point to."
(https://golang.org/pkg/encoding/json/#Unmarshal)
Obviously, the behaviour implemented is the one from the error docs.
Curiously, this works:
https://play.golang.org/p/w-Sg24qcCo
So, a reference to a nil pointer is accepted but the nil pointer itself is not. Anyone care to clarify?
go1.7.4 darwin/amd64

My understanding is that this is a documentation bug. The behavior of returning an InvalidUnmarshalError looks work-as-intended. I guess the docs for the Unmarshal function means "If the pointer points to nil"? Because Unmarshal cannot modify the passed nil pointer.


🤖 - Optimize taiga-ui.dev bundle size

Description
https://pagespeed.web.dev/
Make a detailed analysis of the size of all parts. From the analysis, make a rating of the most frequently used entities with the largest size. Take them one at a time and refactor to reduce the size. During refactoring, notice practices that reduce the weight of the bundle, but do not impair the readability of the code. Collect these practices in one place on a wiki / article and follow them in the future.
Analytics

2021-2022

Part of

https://github.com/Tinkoff/taiga-ui/pull/4142
https://github.com/Tinkoff/taiga-ui/pull/4149
https://github.com/Tinkoff/taiga-ui/pull/4184
https://github.com/Tinkoff/taiga-ui/pull/4194

https://twitter.com/mgechev/status/1463379373638172676?s=21

https://twitter.com/mgechev/status/1463379373638172676?s=21

Angular 14 Taiga

Maybe one day…


Initial Rucio Service class with basic functionality

Fixes #8796
Summary of changes are:

added some basic methods just to test communication between client and server
added API to list blocks present in a Rucio container
added API to retrieve block replicas (still need a fine tuning)

The last 2 APIs were basically copied from an example pointed out by Eric, here:
https://github.com/dmwm/CMSRucio/blob/3793a0b3f8ed1c0541427060fda81e5cd84d6c47/docker/CMSRucioClient/scripts/CMSRucio.py#L128
I'm still figuring out how to test it; a) which datasets are available in Rucio db; b) getting rucio-clients in the unit tests docker image; and c) finally compare output against PhEDEx

test this please

test this please

Two issues in this PR that I still can't make sense of:

some Rucio unit test work while others failed to authenticate. How come if they all use the same image and setup!?!
using the WMAgent docker image, I can import rucio.client from the Rucio_t module, but then it fails to import rucio.client from the import line in the Rucio module being tested(!?)

investigating...

test this please

and this is why the Rucio unit tests are failing, RUCIO_HOME
/build/cmsbld/jenkins/workspace/DMWM-PR-unittests/SLICE/8/label/cms-dmwm-cc7/deploy/1.2.1.pre2-comp/sw/slc7_amd64_gcc630/external/py2-rucio-clients/1.19.3/lib/python2.7/site-packages
points to the wrong configuration file.

test this please

test this please

test this please
(and let the magic happen)

test this please

And finally it works. I had to add this line under the jenkins DMWM-PR-unittests task:
export RUCIO_HOME=$WORKSPACE/deploy/current/config/rucio/
otherwise it was using the default rucio.cfg with the unavailable X509 env vars.
Eventually I have to push something in in the cms-sw/cms-bot repo and remove those lines from the jenkins setup.
The replica tests are still failing though, and I don't think there is anything I can do at the moment. Those blocks (and all the others I looked against a french site) are returning state:UNAVAILABLE.

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

test this please

Tests seem to be all succeeding, but from time to time we get a "read time out" error from the server.
@ericvaandering if you can spare a few minutes, it would be great if you could have a quick look at this PR just to make sure I'm not missing anything about the block replicas logic.

Looks good. We're getting timeouts too. Not sure what's going on, Natalia is looking at the database.
For getPFN we need to do something. It's a known hole for CRAB. I think I know what to do, but good job stubbing it out and making a test for it.

Thanks, Eric! It's way past the time to get it merged now ;)


Add digicert at resources to allow migrate IoTHub to new iothub root …

Add DigiCertcertificateGlobalRootG2 certificate
Description

This sample need to be update for two reason, first one to meet requirements for new root cercificates for Azure IoTHub, the second one becouse de signature for mqtt librarty (5.0) has changed and need two extra parameters. "Content Type" and userProperties.
Motivation and Context
Keeping running this sample free of build errors.
Allow migrate IoTHub to new root.
How Has This Been Tested?

Yes. Both certificates have been tested on an ESP32
The BCM280 has not ben tested.
Screenshots
Types of changes

[ ] Improvement (non-breaking change that improves a sample)
[x] Bug fix (fixes an issue with a current sample)
[ ] New Sample (adds a new sample)
[ ] Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[ ] All new and existing tests passed.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: PepLluis sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.

Let me know if all is alright.
Thanks!

@PepLluis you have some conflicts. You should resolve them and take care of having the right versions everywhere.

Well... some process was started in main between my fork and the PR... "Update 11 NuGet dependencies"
This is breaking a Iot.Device.Bmxx80 dependency who is using UnitsNet.... with version 4.150
Let me know when this are solved to finish this PR.


toggle method can not be overwritten

I am getting the following issue in the browser console.
Error: The toggle method can not be overwritten
Which scenario, this issue will occur. How to avoid?

Found the issue.
Can you solve the following scenario?
I have initiated the v accordion first.
Then I navigate to other control.
Based on the if condition, the directive hides. So again if i enable the directive, then the object which is defined by the directive is available and not yet vanished.
So this issue has been raised. Now I have assigned the null object based on condition.
Please solve the issue.

having the same issue, any workaround ?

I think this repository is not maintained anymore. The problem is with scope.control, it is bidirectionally bound and unless you are clearing it from parent controller/directive anything won't work without some refactoring (not even clearing on $destroy). So, when you are hiding the accordion inside a ng-if, make sure you set your control reference to undefined when the ng-if check will resolve to false.


Fix SVGs, Update README, Add API

SVGs now work
All CLI options are now listed
Added cover page classes to README
Updated usage example

I didn't expect you to merge when you did lol

Added some code to make it possible to import and use it as a JS function. Namely for serverless applications.

Also, please publish to NPM once merged

You can merge my changes to fix SVGs and update the readme, but I'm going to make the serverless version of this a seperate project for now


VS Intllicode is not working

Issue Type: Performance Issue
It stopped working since last 4 to 5 days. It occurs on startup.  All options are enabled still it dosn't work.
Extension version: 1.2.10
VS Code version: Code 1.49.3 (2af051012b66169dde0c4dfae3f5ef48f787ff69, 2020-10-02T17:57:01.595Z)
OS version: Windows_NT x64 10.0.19042

System Info

Item
Value

CPUs
AMD A6-7310 APU with AMD Radeon R4 Graphics     (4 x 1996)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onoop_rasterization: disabled_offopengl: enabled_onprotected_video_decode: unavailable_offrasterization: enabledskia_renderer: disabled_off_okvideo_decode: enabledvulkan: disabled_offwebgl: enabledwebgl2: enabled

Load (avg)
undefined

Memory (System)
3.47GB (0.57GB free)

Process Argv
--crash-reporter-id e8c55eef-f651-4387-9450-63caf6bf5b8c

Screen Reader
no

VM
0%

Process Info
CPU %	Mem MB	   PID	Process
    2	    66	 16972	code main
    0	     7	  1564	   crashpad-handler
    5	   189	  5076	   window (python_codes.py - codes - Visual Studio Code)
    0	   180	   844	     extensionHost
    0	    66	  6568	       electron_node server.js
    0	     6	  1980	     console-window-host (Windows internal process)
    0	    14	  4012	     watcherService
    0	    11	 10416	       console-window-host (Windows internal process)
    0	    70	  8808	     searchService
    0	     4	 17080	     C:\WINDOWS\System32\cmd.exe
    3	    92	  8532	   gpu-process
    0	    22	 12228	   utility
    0	    52	 12292	   shared-process
    3	    82	 12784	   window (Issue Reporter)

Workspace Info
|  Window (python_codes.py - codes - Visual Studio Code)
|    Folder (codes): 66 files
|      File types: cpp(28) exe(24) json(2) py(2) java(1)
|      Conf files: settings.json(2);

@savannahostrowski @jakebailey - adding so you can take a look?

@savannahostrowski @jakebailey - adding so you can take a look?

I don't think there's enough info here to indicate that this is related to Python or Pylance. I think @vishalverma116 may need to provide a bit more info about what they're doing, what message they're seeing, etc, especially given that the type is marked as a performance problem (is it hanging? something else?).

I don't think there's enough info here to indicate that this is related to Python or Pylance. I think @vishalverma116 may need to provide a bit more info about what they're doing, what message they're seeing, etc, especially given that the type is marked as a performance problem (is it hanging? something else?).

hi @jakebailey ,
i apologies for being late.
i think this can help.
Language server is set to Microsoft.
Acquiring model 'intellisense-members-lstm' for python
Querying IntelliCode service for available models.
vs-intellicode-python was passed a model: {}.
Downloading model.
Starting download of https://cdsmprodstg.blob.core.windows.net/models-prod-output/Output_15708AE89896CA5DF1690433B7A8D93D28B7_215F8B4FAB1F4663ABD624559FD205B9?sv=2018-03-28&sr=b&sig=DhkEP3943NnZqQtBK8JQb7Ljz4HNO29SIObke0X1lU8%3D&se=2021-01-10T15%3A23%3A17Z&sp=r
Download complete.
Error while activating Python: {}

hi @jakebailey ,
i apologies for being late.
i think this can help.
Language server is set to Microsoft.
Acquiring model 'intellisense-members-lstm' for python
Querying IntelliCode service for available models.
vs-intellicode-python was passed a model: {}.
Downloading model.
Starting download of https://cdsmprodstg.blob.core.windows.net/models-prod-output/Output_15708AE89896CA5DF1690433B7A8D93D28B7_215F8B4FAB1F4663ABD624559FD205B9?sv=2018-03-28&sr=b&sig=DhkEP3943NnZqQtBK8JQb7Ljz4HNO29SIObke0X1lU8%3D&se=2021-01-10T15%3A23%3A17Z&sp=r
Download complete.
Error while activating Python: {}

These are the for IntelliCode, but IntelliCode itself doesn't actually do anything, Pylance does (if you're using that). Do you have logs from the "python language server" output window?

These are the for IntelliCode, but IntelliCode itself doesn't actually do anything, Pylance does (if you're using that). Do you have logs from the "python language server" output window?

these are the logs from output of "python",
at f.getInitializationOptions (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:35520)
at f.getAnalysisOptions (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:9:273787)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at f.r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at r.startLanguageServer (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:53073)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at r.l.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:9972)
at restartLanguageServer (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:52913)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at restartLanguageServerDebounced (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:52784)
at r. (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:62420)
at y (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:44:108829)
at w (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:44:109104)
at Timeout.E [as _onTimeout] (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:44:108994)
at listOnTimeout (internal/timers.js:531:17)
at processTimers (internal/timers.js:475:7)]
Error 2021-01-14 17:11:39: Failed to restart language server, Class name = r, completed in 15ms, has a falsy return value, , Return Value: undefined [Error: did not find an active interpreter
"python language server" does not give any output on output window. it is blank.

these are the logs from output of "python",
at f.getInitializationOptions (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:35520)
at f.getAnalysisOptions (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:9:273787)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at f.r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at r.startLanguageServer (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:53073)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at r.l.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:9972)
at restartLanguageServer (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:52913)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at /home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64517
at Object.t.tracing (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:50205)
at r.value (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:64493)
at restartLanguageServerDebounced (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:59:52784)
at r. (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:1:62420)
at y (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:44:108829)
at w (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:44:109104)
at Timeout.E [as _onTimeout] (/home/vishalverma116/.vscode/extensions/ms-python.python-2020.12.424452561/out/client/extension.js:44:108994)
at listOnTimeout (internal/timers.js:531:17)
at processTimers (internal/timers.js:475:7)]
Error 2021-01-14 17:11:39: Failed to restart language server, Class name = r, completed in 15ms, has a falsy return value, , Return Value: undefined [Error: did not find an active interpreter
"python language server" does not give any output on output window. it is blank.

That output implies things failed because you don't have a Python interpreter selected. Do you have one selected at the bottom left, or is it saying there isn't one?

That output implies things failed because you don't have a Python interpreter selected. Do you have one selected at the bottom left, or is it saying there isn't one?

Hey @vishalverma116, we'd love to hear from you if you're still seeing this issue.
Feel free to open a new issue, going to close this one


brick-0.28 is out of bounds

brick-0.28 is out of bounds for:

[ ] viewprof-<IP_ADDRESS> (>=0.16 && < 0.28). Mitsutoshi Aoe<EMAIL_ADDRESS>@maoe. @maoe. Used by: executable

Done https://hackage.haskell.org/package/viewprof-<IP_ADDRESS>