[feature request] recommended workspace settings via "settings.recommended.json"

Feature Request: add a way to recommend settings when users open content in VSC (without forcing settings on users)
We currently have extensions.json files, so that when content is opened in VSC, the user will be prompted to install the extensions from the extensions.json file. This is a great feature, but I wish the same feature existed for workspace settings.json.
It would be nice if we could make a file (perhaps something like settings.recommended.json) so that when a user opens our content in VSC, they will be prompted to copy the settings from settings.recommended.json to the workspace settings.json file.
Visuals
Here is what the prompt looks like when a user opens a workspace with an extensions.json file:

What is this issue proposing? The same thing as above but for settings rather than extensions. Here is a mock-up of what it could look like:

If the user clicks Apply in the prompt, the content would be copied from settings.recommended.json to settings.json applying the settings in workspace.
Why?
Source Control
We can already include a settings.json file with our code to automatically apply settings when a user opens our content in VSC, but that is forced. Users cannot opt in-to/out-of an included settings.json file. This causes an issue with source control where if you want to have default settings on a code base you have to include the settings.json but users that don't want to use the default settings must exclude their settings.json changes when they commit. Having a settings.recommended.json would mean we could commit that file, settings.recommended.json, to source control while .gitignore-ing the settings.json file.
Having Recommended/Default settings.json Is Nice (especially for new/inexperienced developers)

When a developer first opens my content, rather than bombard them with a verbose file structure, it is nice to filter out unnecessary directories/files and guide them to the code/files that are important. Such as:
"files.exclude":
{
	".gitignore": true,
	".vs": true,
	"**/bin": true,
	"**/obj": true,
	".github": true,
	".vscode":true,
},

Also, "semantic highlighting" is disabled by default. I have projects coded in C#, and in order to help new developers out, I include the following in my settings.json file:
"csharp.semanticHighlighting.enabled": true,

Also, color/theming is nice to recommend. As a C# developer, I especially prefer to have different colors for each type-of-types in my IDE/Editor. By this I mean a different color for structs, classes, delegates, interfaces, and enums. I also like to have a similar but noticeably distinct color for methods vs extension methods. If I post screenshots on blogs/social-media/documentation, it is easier for users to recognize the screenshot when they open the code if they share the same color/theme. However, color/theme is probably the biggest thing that users will want to opt-out-of. It is nice to recommend color/theme to absolute beginner programmers in C#, but for someone who is already experienced with C#, they don't want to be forced to use other people's settings. This is why we really need a settings.recommended.json file proposed in this issue. An experienced C# dev can ignore the prompt to apply the default settings of the content when opened in VSC.

:page_facing_up: Color/Theme Settings I Use In My C# settings.jsons [Expand]

"workbench.colorTheme": "Default Dark+",
"editor.semanticTokenColorCustomizations":
{
	"[Default Dark+]":
	{
		"enabled": true,
		"rules":
		{
			"class": "#4EC9B0",
			"comment": "#57A64A",
			"controlKeyword": "#569CD6",
			"delegate": "#BD63C5",
			"enum": "#FF7F27",
			"enumMember": "#ffffff",
			"event": "#ffffff",
			"excludedCode": "#9B9B9B",
			"extensionMethod": "#CB859B",
			"field": "#ffffff",
			"interface": "#B8D7A3",
			"keyword": "#569CD6",
			"label": "#ffffff",
			"local": "#ffffff",
			"method": "#BD6380",
			"namespace": "#ffffff",
			"number": "#B8D7A3",
			"operator": "#ffffff",
			"operatorOverloaded": "#ffffff",
			"parameter": "#ffffff",
			"plainKeyword": "#569CD6",
			"preprocessorKeyword": "#9B9B9B",
			"preprocessorText": "#ffffff",
			"property": "#ffffff",
			"punctuation": "#ffffff",
			"string": "#D69D85",
			"stringVerbatim": "#D69D85",
			"struct": "#FFFF80",
			"typeParameter": "#808000",
			"variable": "#ffffff",
			"xmlDocCommentComment": "#56a64a7c",
			"xmlDocCommentText": "#9B9B9B",
			"xmlDocCommentAttributeName": "#9B9B9B"
		}
	}
}

These were just examples I have personal experience with, but there are tons of settings of course (cough... tabs/spaces... cough...).

I just want to mention one implementation detail that I forgot to explicitly mention above. The settings.json file allows comments. I would like it if the comments from settings.recommended.json file were retained when the content is applied to settings.json.
Here is one possible example, but there are many examples I could think of:
"files.exclude":
{
	".gitignore": true,
	".vs": true,
	"**/bin": true,
	"**/obj": true,
	".github": true,
	".vscode":true,

	// These are supportive directories. They contain code generation, unit tests, documentation, etc.
	// They are only hidden to guide new users to the source code and examples. If you would like to
	// contribute to this repository, it is recommended you unhide them. Thank you for your interest
	// in contributing.! :)
	"docfx_project":true,
	"Tools":true,
},

By the way, this is related to https://github.com/microsoft/vscode/issues/40233, but it is not a duplicate. It would be nice if both https://github.com/microsoft/vscode/issues/40233 and https://github.com/microsoft/vscode/issues/128226 existed at the same time.

https://github.com/microsoft/vscode/issues/128226 gives users the ability to ignore default settings
https://github.com/microsoft/vscode/issues/40233 gives users the ability to use-but-override default settings

Closing this in favour of Local Workspace Settings and User Profiles features.

@sandy081 We need a way to recommend settings but not force settings on users. Unless #40233 will be implemented to allow that, they are not duplicates.

I see. I was mistaken by Local Workspace Settings feature. Sorry about that. But I have to say that we do not have plans to implement this feature in near future. So, have to keep this closed instead of duplicating, but with out of scope. We will get back to it in future when revalidate our plans. Thanks for understanding.


Error on deployment to aws

@
Hi,
I'm trying to deploy my infra to AWS I have done all the necessary prerequisites in config.auto.fvars file and had run
terraform init
terraform apply
after some time I got the above error please help me with the same.
@vlidholt @II11II @yahu1031 @fischerscode

Check if you are using root user or Im user in aws account.

No you need to use root user

No you need to use root user. Is it your first time running terraform?

Yes.
Are there any changes other than config.auto.fvars ??
@yahu1031

@sandeepdevacc From the error it looks like, you are not the root user...

@sandeepdevacc Check if anything happened in the aws console. And can you please make sure that you have logged into the AWS console as ROOT USER and not IAM USER.

@yahu1031
I have created one IAM User and try to deploy the same hope all things go well.

No, It should be ROOT USER only. IAM USER doesn't have access to do it.

I tried to ask Chat GPT about the issue. I got this answer(May not be super accurate, but the info is almost near to the issue).

@yahu1031
Good news got success to terraform apply command
Now, I'm trying to Deploy through Github but In Action >Deploy to aws is not visible

reload it and check if the yml file exists.

@yahu1031
No there is no yml file

Then push it.

@yahu1031
I have pushed the code on the main branch still the .github folder is not generated.
Please help me with the same.

@yahu1031 fyr

Ha, you are missing that file

yes, how can I generate it?

Try serverpod create . in the same folder.

Try serverpod create . in the same folder. If it doesn't work, write things manually. But there must be a way.

Yes, it's not working.
If you have any reference code??

@yahu1031
Hi,
I was trying to run the working and the below error occurred please help me with the same.

check the action logs.

@yahu1031
but I have main.dart file.

can you share github repo?

Its private repo

screenshot the repo please

Can you share the work flow please.

Update
Got the success on deployment

But when I run the app then the below error occurred

https

And why did you deploy it to examplepod.com?

No, I did it on my domain only

Check the domains correctly, Cause it redirects me here  http://app.examplepod.com/
On Thu, 2 Mar 2023 at 14:16, sandeepdevacc @.***> wrote:

And why did you deploy it to examplepod.com?
No, I did it on my domain only
[image: image]
https://user-images.githubusercontent.com/118791435/222377412-243fdb15-69d0-4f13-986f-0178f2f471ab.png
—
Reply to this email directly, view it on GitHub
https://github.com/serverpod/serverpod/issues/700#issuecomment-1451501966,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIPAWHLYFASGAUWBY7DAJTLW2BM6XANCNFSM6AAAAAAVLSOSE4
.
You are receiving this because you were mentioned.Message ID:
@.***>

@yahu1031

Generate tables in production db.


Add docs for WASM Sandbox

description
We have a sandbox to demonstrate WASM, but it doesnt currently have any documentation

@phlax should I assign this to you?

yep, im happy to do this

@htuch the immediate problem i hit with this is that the wasm build expects bazel and i guess a working build environment.
im thinking the sandbox should ideally not depend on this - and if it does it would want to do the build inside a container (like for building grpc protos eg)
im wondering if there is an easy way to compile the .cc file in the sandbox to wasm with minimal build deps

this seems an option https://docs.bazel.build/versions/master/bazel-container.html - but its not a small image

i tried compiling the wasm bin - first using the default bazel image - which didnt get very far
https://travis-ci.org/github/phlax/bazeldev/builds/736657571#L244
and then using ./ci/run_envoy_docker.sh ... which seems to get further, but fails for some other reason:
https://travis-ci.org/github/phlax/bazeldev/builds/736662127#L1007

@PiotrSikora can you potentially advise on ^? Perhaps we can come up with some type of self contained example that doesn't use Bazel and just a very basic make/cmake setup?

@phlax are you talking about building Wasm extensions?
For C++ examples using standard tools (i.e. not Bazel), you can take a look at:
https://github.com/dengyijia/WAF-wasm
Note that this was developed before it was merged into official repo, so the instructions are using Istio Proxy.
For C++ examples using Bazel, you can take a look at extensions in Istio Proxy:
https://github.com/istio/proxy/tree/master/extensions
I believe that @bianpengyuan is working on some documentation for that.
For Rust examples using standard tools, you can take a look at examples in Proxy-Wasm Rust SDK:
https://github.com/proxy-wasm/proxy-wasm-rust-sdk/tree/master/examples
and there are already some helpful articles from the community about building Proxy-Wasm extensions:
https://antweiss.com/blog/extending-envoy-with-wasm-and-rust/
https://blog.red-badger.com/extending-istio-with-rust-and-webassembly

@phlax are you talking about building Wasm extensions?

yep, compiling this file (https://github.com/envoyproxy/envoy/blob/master/examples/wasm/envoy_filter_http_wasm_example.cc) before running the sandbox with the file
i guess we need to build it in a container as we want something that will take at most 1 or 2 commands to build, and doesnt expect much from users env
after thinking about it, i reckon using bazel is fine - probs better as that is how Envoy builds everything else
i didnt try too hard to get the container builds above working - but probs we need to use the (huge) envoy build image, or at least a bazel build container

For that example, you can simply build it with:
bazel build //examples/wasm:envoy_filter_http_wasm_example.wasm

but that's a specific example within Envoy repository, and it's not how people should be developing extensions, so that's not a great base for developer documentation, IMHO. For that, see my previous comment.

the thing is that is just for a sandbox - ie a single page of docs with a really simple setup to get started
we definitely dont want to expect that users have bazel/llvm/etc available natively (if we did, we would need to document exactly how they can do that in a multi-platform way)

it's not how people should be developing extensions

yep - its a simple example to get people started

in terms of comparisons with existing sandboxes - i think compiling the grpc protocol stubs is the closest to what we need here:
https://387354-65214191-gh.circle-artifacts.com/0/generated/docs/start/sandboxes/grpc_bridge.html#step-3-generate-the-protocol-stubs

providing a pre-compiled binary is also an option i guess

For that example, you can simply build it with:
bazel build //examples/wasm:envoy_filter_http_wasm_example.wasm

...once https://github.com/envoyproxy/envoy/pull/13619 is merged.

brilliant, thankyou!

If it's not about building Wasm extensions, but only about running them, then I think that using the existing examples/wasm/envoy_filter_http_wasm_example.wasm module that's already checked in is perfectly fine.

using the existing examples/wasm/envoy_filter_http_wasm_example.wasm module that's already checked in is perfectly fine.

i couldnt find any compiled module (with find . -name "*.wasm")

if i can get the build to work - this should be good - ill PR a wip sandbox in the next day or two

Ah, right. I must have generated it previously and it just stuck around. Once #13619 is merged, it's one-line to build it, though.

i tested building with the bazel and envoy-build images
the envoy-build image works - so i can use that i reckon
i tried again with the bazel image and got the (same) following error:
ERROR: /.cache/bazel/_bazel_2000/a08c2e4811c846650b733c6fc815a920/external/proxy_wasm_cpp_sdk/BUILD:21:11: C++ compilation of rule '@proxy_wasm_cpp_sdk//:proxy_wasm_intrinsics' failed (Exit 1) emcc.sh failed: error executing command external/proxy_wasm_cpp_sdk/toolchain/emcc.sh -MD -MF bazel-out/wasm32-fastbuild-ST-4d26de33ce28/bin/external/proxy_wasm_cpp_sdk/_objs/proxy_wasm_intrinsics/proxy_wasm_intrinsics.d ... (remaining 17 argument(s) skipped)

it might well be to do with how i am trying to call it - the commands are:
git clone -b fix_wasm_example https://github.com/PiotrSikora/envoy
mkdir build_output
mkdir cache
docker run \
      -e USER="$(id -u)" \
      -u="$(id -u)" \
      -v $(pwd)/envoy:/src/workspace \
      -v $(pwd)/cache:/.cache \
      -v $(pwd)/build_output:/tmp/build_output \
      -w /src/workspace \
     l.gcr.io/google/bazel:3.4.1 \
     build //examples/wasm:envoy_filter_http_wasm_example.wasm

for the docs im thinking we can provide a download and some instructions to rebuild the module

I don't think you can build Envoy or Wasm extensions using Bazel's official container, since it's missing a bunch of build tools.
How about using what's already provided in Envoy?
./ci/run_envoy_docker.sh 'bazel build //examples/wasm:envoy_filter_http_wasm_example.wasm'

How about using what's already provided in Envoy?

yep that works, it just involves a ~4GB image, which i was trying to avoid

i think the other reason im averse to the ./ci/run_envoy_docker.sh script locally is that it runs ~privileged with /var/run/docker.sock mounted and a lot of software inside - even when those things arent needed
i think its ok for CI - but better avoided for local use, unless you understand what it is doing
for the example i have created a docker-compose with  the ubuntu-build-image and just the source dir mounted etc - should work


[8.x] Add support for both CommonMark 1.x and 2.x

This PR complements #37953 by allowing users of 8.x to install either major version of the CommonMark library.

I'll make the adjustments to require CommonMark v2 on Laravel v9 after this is merged upstream 👍

Thanks @colinodell


[SPARK-29288][SQL] Spark SQL ADD JAR support HTTP path.

What changes were proposed in this pull request?
Support Spark SQL add jar with http/https/ftp path.
Why are the changes needed?
Hive 2.3 support add jar with http path, Spark SQL add this feature too.
Does this PR introduce any user-facing change?
User can use SPARK SQL ADD JAR with http/https/ftp path such as :
0: jdbc:hive2://localhost:10000/default> add jar https://maven-central.storage-download.googleapis.com/repos/central/data/org/apache/hive/hcatalog/hive-hcatalog-core/2.3.5/hive-hcatalog-core-2.3.5.jar;
INFO  : Added [/private/var/folders/4l/7_c5c97s1_gb0d9_d6shygx00000gn/T/spark-504057ea-5b3b-4cac-ae3f-ecd368c55923/userFiles-deedcbb7-d3dc-45a5-8f04-246882f87b1b/hive-hcatalog-core-2.3.5.jar] to class path
INFO  : Added resources: [/private/var/folders/4l/7_c5c97s1_gb0d9_d6shygx00000gn/T/spark-504057ea-5b3b-4cac-ae3f-ecd368c55923/userFiles-deedcbb7-d3dc-45a5-8f04-246882f87b1b/hive-hcatalog-core-2.3.5.jar]
+---------+
| result  |
+---------+
+---------+
No rows selected (0.785 seconds)
0: jdbc:hive2://localhost:10000/default> CREATE TABLE addJar(key string) ROW FORMAT SERDE 'org.apache.hive.hcatalog.data.JsonSerDe';
+---------+
| Result  |
+---------+
+---------+
No rows selected (0.743 seconds)
0: jdbc:hive2://localhost:10000/default> insert into table addJar select 1;
+---------+
| Result  |
+---------+
+---------+
No rows selected (2.656 seconds)
0: jdbc:hive2://localhost:10000/default> select * from addJar;
+------+
| key  |
+------+
| 1    |
+------+
1 row selected (0.521 seconds)
0: jdbc:hive2://localhost:10000/default>

How was this patch tested?
UT + MT

gentle ping @dongjoon-hyun

Can one of the admins verify this patch?

Can one of the admins verify this patch?

Without this patch I am able to use add jar using http as shown below

Am I missing something ?

Without this patch I am able to use add jar using http as shown below

Am I missing something ?

Seems I make some thing wrong. Thank you for your check.


Add support for multiple regions

When resolving {{EC2PrivateDNSName}}, authenticator looks for instances only in the current region. This PR adds an optional setting allowing to specify other regions to query.
This allows to have single cluster spanning multiple AWS regions that are connected using peered VPC.

/assign @nckturner

/remove-lifecycle stale

@monder can you update the conflicts?

@christopherhein done. Rebased and tested.
I've added additional wrapper to keep aws abstraction introduced in https://github.com/kubernetes-sigs/aws-iam-authenticator/pull/226

This allows ec2 instances to pass validation if they originate from different regions, another related consideration is whether what STS endpoint the tokens they craft use (in the presigned URL).  We should be moving away from the global STS endpoint, so the question is how does the client decide which region to choose.
/cc @wongma7


GCE icon inconsistency

The provider icon seems wrong, the icons used for templates is what google is using.

The blue icon I guess is google compute engine and the more colorful icon is Google Cloud Platform.  I personally thing the more colorful icon is sexier and we should use it everwhere IMHO

@dclarizio can you look at how these icons are selected?  Not sure which one is the right one to go with.

@dajohnso this would have to go back to the creator to see why they chose these images, and then alter them if needed.

@dajohnso @erjohnso is this issue still relevant. If yes, can you remove the stale label so it gets another lease on life.


"Disk may be limiting speed" showed while uploading files from NAS to Azure blob storage using AzCopy

Which version of the AzCopy was used?
Note: The version is visible when running AzCopy without any argument
AzCopy 10.10.0
Which platform are you using? (ex: Windows, Mac, Linux)
Windows
What command did you run?
Note: Please remove the SAS to avoid exposing your credentials. If you cannot remember the exact command, please retrieve it from the beginning of the log file.
./azcopy sync    "https://XXXX.blob.core.windows.net/testingupload?"  --recursive  --delete-destination=true
What problem was encountered?
Message "Disk may be limiting speed" showed while uploading files from NAS to Azure blob storage using AzCopy
I ran Azcopy on my on-prem VM with NAS attached, the throughput was around 600-800 Mb/s. The speed is quite fast, but the message showed up constantly.

Does this message specify there is a bottleneck of the reading speed from NAS to local VM? Does the disk mean local disk or NAS disk?
I would like to optimize the memory use, what value of AZCOPY_BUFFER_GB I can start with?

Hi @abby984003004, "Disk may be limiting speed" means that the tool is idling waiting for data to be read from the source. In other words, network/outbound speed > source speed in your case.
Your NAS is mounted on your client machine, the data needs to be read from your NAS and uploaded from the client machine via AzCopy. So "Disk may be limiting speed" applies to the combination of NAS disk + your internal network.
As for memory use, I would suggest to only tune it if you think the usage is too much. We infer a default usage (0.5GB per logical core, max of 16GB) based on how powerful your machine is.

Thank you @zezha-msft for the explanation. Will you suggest me to test the speed from NAS to VM and also monitor the CPU/memory/network usage on NAS when the message shows up again?

Hi @abby984003004, "Disk may be limiting speed" means that the tool is idling waiting for data to be read from the source. In other words, network/outbound speed > source speed in your case.
Your NAS is mounted on your client machine, the data needs to be read from your NAS and uploaded from the client machine via AzCopy. So "Disk may be limiting speed" applies to the combination of NAS disk + your internal network.
As for memory use, I would suggest to only tune it if you think the usage is too much. We infer a default usage (0.5GB per logical core, max of 16GB) based on how powerful your machine is.

If we are using the two AZcopy command at the same time,Is that means we need double CPU/Memory/Network resource?
per my testing, If I run one AZcopy then the speed would be 200 MB/s, If I run two AZcopy then speed would be 260 MB/s.
Is Microsoft suggest user to run  two AZCopy or just One AZCopy?Thanks

@zezha-msft Could you reopen the case since we still have some performance tuning questions? Thank you so much


Add Outline Object Effect

Not related to any issue. But it's an effect I use often, so I decided to implement it, especially as the code is similar(ish) to the feather effect.
Located in Object > Outline Object.
It outlines an object on a transparent background.
There already is an outline effect, but this differs. This one does not replace the original image, and is more flexible.

Personally, my usual use case for an effect like this:

Has six options:
Radius modifies outline width.
Tolerance modifies what is defined as the "border" of the object.
Alpha Gradient defines whether the outline's alpha falls off, or remains a constant alpha.
Color Gradient defines whether or not the outline blends between primary color > secondary color or not. Otherwise, remains just the primary color.
Outline Border outlines the border of the image.
Fill Object Background fills the background of the object with the primary color. Only really noticeable on translucent objects, but is on by default for anti-aliased borders of an object.
5 tests added.
Was unsure what to name this, as we already have an Outline effect. But the new category was made, so i decided to name it Outline Object. (Maybe we should rename Feather > Feather Object now, because there's Align Object, Outline Object, and Feather)

I don't mind the Outline Object name, but the original Outline also could probably be called something like "Outline Edges" since it's more based around edge detection


SignEcdsa is too slow

SignEcdsa takes couple seconds, any way to make it quicker?

Hello! Have you found the solution for this?

Same issue here. Calling Sign() takes more than 7 seconds on my machine.

It seems that turning on -O3 helps. Signing time drops from 7 seconds to 180 milliseconds on my machine. It's apparently still not ideal, but better than nothing.

was this ever solved?

@rbdm-qnt Nope but (shameless plug) if you use Rust then you can use starknet-crypto lol.

@rbdm-qnt Nope but (shameless plug) if you use Rust then you can use starknet-crypto lol.

And is that one faster?

Yeah it is. See the linked page for benchmark.

Yeah it is. See the linked page for benchmark.

1ms or less vs 7 seconds/180 ms? I don't understand, there must be something terribly wrong with the c++ version? Even the python version takes 70-80ms only. Unfortunately I don't use Rust, my application is in C++ and I need a high performance version for that language

Well you can use the Rust lib from C++ as well. You'll need to create a wrapper crate that exposes the C api but it's possible.
Honestly that's likely your best bet imo, as this repo doesn't seem to be maintained.

Well you can use the Rust lib from C++ as well. You'll need to create a wrapper crate that exposes the C api but it's possible.
Honestly that's likely your best bet imo, as this repo doesn't seem to be maintained.

Wouldn't that have a big overhead? Never done that

Wouldn't that have a big overhead? Never done that

Nope it's just like linking to any other library. Rust does not have a runtime. Might be helpful:

https://parallel-rust-cpp.github.io/cpp_abi.html
https://stackoverflow.com/questions/52923460/how-to-call-a-c-dynamic-library-from-rust

I would love to have such instructions implemented as an example (specifically with cxx). Created an issue to track it: https://github.com/xJonathanLEI/starknet-rs/issues/325
However I'm currently too busy to put it together. Would be awesome if someone can help. Or if you make it work, feel free to drop a PR for that. Thanks!

I would love to have such instructions implemented as an example (specifically with cxx). Created an issue to track it: xJonathanLEI/starknet-rs#325
However I'm currently too busy to put it together. Would be awesome if someone can help. Or if you make it work, feel free to drop a PR for that. Thanks!

Could you please at least provide an example of how to use the Rust code itself? I'm trying to understand how to create some C bindings, but can't figure out these Rust types like FieldElement and Fp256Parameters.

@rbdm-qnt https://github.com/xJonathanLEI/starknet-rs/pull/328

@rbdm-qnt xJonathanLEI/starknet-rs#328

I remade the whole thing in C++ from scratch. I thought the 180ms latency reported must have been a mistake. I followed python's implementation (which takes 75ms) and remade it in cpp17, and it takes around 100ms. I think the problem is possibly the handling of GMP types, or maybe some bottleneck in cryptopp algorithms, but it's quite puzzling. I can't understand how's its possible for Rust to run this in 1ms.
Anyway, now I really must understand how to use your implementation in my C++ application. Please, if you could provide any basic example of usage of the Sign method it would save me a lot of time, cos I'm a total Rust noob

Please, if you could provide any basic example of usage of the Sign method

Hey man my last comment was exactly just that. It's a CMake example:
https://github.com/xJonathanLEI/starknet-rs/tree/master/examples/starknet-cxx

Please, if you could provide any basic example of usage of the Sign method

Hey man my last comment was exactly just that. It's a CMake example:
https://github.com/xJonathanLEI/starknet-rs/tree/master/examples/starknet-cxx

Thank you, that's great! Is this file autogenerated? Cause I can't find it in the directories "starknet_cxx_bridge/lib.h"

I can't find it in the directories "starknet_cxx_bridge/lib.h"

Yes it's generated by cxx. It should live somewhere inside the build folder once you build it. Pretty sure you can just go into definition if you use an LSP. (Not 100% sure cuz I wrote the example without an LSP)

I can't find it in the directories "starknet_cxx_bridge/lib.h"

Yes it's generated by cxx. It should live somewhere inside the build folder once you build it. Pretty sure you can just go into definition if you use an LSP. (Not 100% sure cuz I wrote the example without an LSP)

I was able to make the example work and integrate it into my codebase with some work, thank you! I have another question, why does the Sign method return 1 string? Canonically, ecdsa_sign methods return r and s values, so 2 strings, as far as I know

Yep yep it was just to make the bindings example simpler. Glad you figured it out! It's great that you found the lib helpful!

Yep yep it was just to make the bindings example simpler. Glad you figured it out! It's great that you found the lib helpful!

I'm having trouble getting valid values for ecsda_signature; in the python version I'm able to generate rfc6979 key with an empty seed value (in bytes b"") or values like "\x01" or above. In Rust these values error out, as well as an empty string, and I have to use "0x1" or above. I'm thinking this might be the reason why the signatures are invalid? For instance, I'm generating a signature with the same exact values in both Python and C++/Rust, and then verifying the outputs

@rbdm-qnt Hi. When using correctly all the Rust methods have been tested to generate exactly the same output as their Python counterparts. I've also verified that using ecdsa_sign from C++ gives the exact same output as in Rust. Everything should be fine. The lib is used in many places for the cryptographic stuff so it should work.
You mentioned an empty string doesn't work. That's because of how the wrapper itself (lib.rs) handles input. Everything gets converted into FieldElement at the end of the day and starknet-crypto only every deals with FieldElements, not strings. On the wrapper level, the parsing logic doesn't treat an empty string as a valid value while the Python version does (according to you; I haven't verified this).
I'm not sure how Python treats the empty string. Maybe it treats it as a 0 value? In that case, you can should be able to input 0x0 to the wrapper and it should parse correctly. Of course, this builds on the assumption that Python treats it as zero.
In any case I'm happy you made it work, but if you still consider it a bug after reading this comment (maybe I misunderstood something in your text), please file a bug under starknet-rs. Thanks. Let's not continue spamming the crypto-cpp folks lol


Missing stdlib.h include when C++ standard library is used.

Describe the bug
stdlib.h is not in the GCC search path when the C++ standard library is used.
To Reproduce
prj.conf:
CONFIG_NEWLIB_LIBC=y
CONFIG_CPLUSPLUS=y

main.cpp:
#include <zephyr.h>
#include <misc/printk.h>
#include <array>

void main(void)
{
	std::array<int, 3> a{ 1, 2, 3 };

	for (const auto x: a)
	{
		printk("x: %d", x);
	}
}

Steps to reproduce the behavior:

mkdir build && cd build
cmake -GNinja -DBOARD=arduino_zero ..
ninja
Build fails because of missing include, see console output below

Expected behavior
The example code above should compile.
Impact
I can not use the C++ standard library for my current project.
Screenshots or console output
> ninja
[15/101] Building CXX object CMakeFiles/app.dir/src/main.cpp.obj
FAILED: CMakeFiles/app.dir/src/main.cpp.obj
C:\Users\username\tools\gcc-arm-none-eabi-7-2018-q2-update-win32\bin\arm-none-eabi-g++.exe  -DBUILD_VERSION=zephyr-v1.14.0 -DKERNEL -D_FORTIFY_SOURCE=2 -D__LINUX_ERRNO_EXTENSIONS__ -D__ZEPHYR__=1 -IC:/Users/username/zephyrproject/zephyr/kernel/include -IC:/Users/username/zephyrproject/zephyr/arch/arm/include -IC:/Users/username/zephyrproject/zephyr/include -IC:/Users/username/zephyrproject/zephyr/include/drivers -Izephyr/include/generated -IC:/Users/username/zephyrproject/zephyr/soc/arm/atmel_sam0/samd21 -IC:/Users/username/zephyrproject/zephyr/ext/hal/atmel/asf/sam0/include/samd21 -IC:/Users/username/zephyrproject/zephyr/ext/hal/cmsis/Include -isystem C:/Users/username/tools/gcc-arm-none-eabi-7-2018-q2-update-win32/arm-none-eabi/include -std=c++11 -Os -fcheck-new -Wno-register -fno-exceptions -fno-rtti -g -Wall -Wformat -Wformat-security -Wno-format-zero-length -imacros C:/Users/username/tmp/hello_world/build/zephyr/include/generated/autoconf.h -ffreestanding -Wno-main -fno-common -mthumb -mcpu=cortex-m0plus -fno-asynchronous-unwind-tables -fno-pie -fno-pic -fno-strict-overflow -Wno-unused-but-set-variable -fno-reorder-functions -fno-defer-pop -Werror=implicit-int -Wpointer-arith -ffunction-sections -fdata-sections -mabi=aapcs -march=armv6s-m -MD -MT CMakeFiles/app.dir/src/main.cpp.obj -MF CMakeFiles\app.dir\src\main.cpp.obj.d -o CMakeFiles/app.dir/src/main.cpp.obj -c ../src/main.cpp
In file included from c:\users\username\tools\gcc-arm-none-eabi-7-2018-q2-update-win32\arm-none-eabi\include\c++\7.3.1\ext\string_conversions.h:41:0,
                 from c:\users\username\tools\gcc-arm-none-eabi-7-2018-q2-update-win32\arm-none-eabi\include\c++\7.3.1\bits\basic_string.h:6352,
                 from c:\users\username\tools\gcc-arm-none-eabi-7-2018-q2-update-win32\arm-none-eabi\include\c++\7.3.1\string:52,
                 from c:\users\username\tools\gcc-arm-none-eabi-7-2018-q2-update-win32\arm-none-eabi\include\c++\7.3.1\stdexcept:39,
                 from c:\users\username\tools\gcc-arm-none-eabi-7-2018-q2-update-win32\arm-none-eabi\include\c++\7.3.1\array:39,
                 from ../src/main.cpp:8:
c:\users\username\tools\gcc-arm-none-eabi-7-2018-q2-update-win32\arm-none-eabi\include\c++\7.3.1\cstdlib:75:15: fatal error: stdlib.h: No such file or directory
 #include_next <stdlib.h>
               ^~~~~~~~~~
compilation terminated.
[28/101] Building C object zephyr/CMakeFiles/zephyr.dir/lib/os/printk.c.obj
ninja: build stopped: subcommand failed..

Environment (please complete the following information):

OS: Windows 10 1903
Toolchain: GNU ARM Embedded 7-2018-q2-update
Zephyr: v1.14.0

Additional context
This might be related to issue #15603. I tried the suggested workaround, but it does not help.
I tried several Zephyr versions:

v1.14.1-rc1
v1.14.99 (latest master, commit 1c6952c4f6de045fc5765373ff89683afd6396a4 )
v1.14.0-rc1

v1.14.0-rc1 works but in this version the shell is not C++ compatible yet, so there are other problems to work around.
I also tried the latest GNU ARM Embedded toolchain (8-2019-q3-update), but also no success here.
If you can point my in the right direction, I will happily provide a fix myself.

@simonmarti could you please try with the Zephyr SDK instead of GNU Arm Embedded and let us know if you can reproduce the same issue?

I'm unable to reproduce this with zephyr-1.14.0 and ZEPHYR_TOOLCHAIN_VARIANT=zephyr resolves to SDK 0.10.0.  <array> is found and SDK 0.10.1 is unsupported in zephyr-1.14.0.  It also works with current head of v1.14-branch.
I can confirm the problem as reported is present when ZEPHYR_TOOLCHAIN_VARIANT=gnuarmemb and current v1.14-branch.
@carlescufi it appears you're using a C source filemain.c instead of a C++ file main.cc, which would explain the failure to find <array>.

I'm unable to reproduce this with zephyr-1.14.0 and ZEPHYR_TOOLCHAIN_VARIANT=zephyr resolves to SDK 0.10.0. <array> is found and correct output is written. SDK 0.10.1 is unsupported in zephyr-1.14.0. It also works with current head of v1.14-branch.
I can confirm the problem as reported is present when ZEPHYR_TOOLCHAIN_VARIANT=gnuarmemb and current v1.14-branch.
@carlescufi it appears you're using a C source filemain.c instead of a C++ file main.cc, which would explain the failure to find <array>.

Thanks @pabigot. I can confirm the same in master. There is clearly an issue with GNU Arm Embedded and newlib/C++. @galak or @SebastianBoe is that something you could take a look at?

I think that I've got the same error couple of months ago... this solved the issue
diff --git a/lib/libc/newlib/CMakeLists.txt b/lib/libc/newlib/CMakeLists.txt
index d368d1b89a8e1097eb7fda43044772c52738aba5..71061aa905131dbf85ead6dd0b56fb863e570b84 100644
--- a/lib/libc/newlib/CMakeLists.txt
+++ b/lib/libc/newlib/CMakeLists.txt
@@ -14,7 +14,7 @@ zephyr_library_sources(libc-hooks.c)
 # our libc headers to be picked instead of the toolchain's ffreestanding
 # headers.
 if(LIBC_INCLUDE_DIR)
-  zephyr_system_include_directories(${LIBC_INCLUDE_DIR})
+  zephyr_include_directories(${LIBC_INCLUDE_DIR})
 endif()

 if(LIBC_LIBRARY_DIR)

Can somebody confirm?

I can confirm that the problem goes away by making newlib headers not system headers, but given 7d2df83b5184b4566d43dd8a8d9abeb7c1d85694 was just merged I'm not convinced it's the right solution.  Presumably Zephyr and ARM do something different in builds that affects how system include files are handed.

Hi, I have proposed a solution to the related issue #15603 here: https://github.com/zephyrproject-rtos/zephyr/pull/18189
The PR is intended to also fix this issue (17564), but I've not been able to reproduce all the reports here, so I'm not certain that it does so.

@cszawisza Thanks, the change fixes the problem for my environment.
@SebastianBoe I tested the change proposed in #18189 with my environment, but it does not solve the issue. The error message is still the same.
The environment I used for the test:

OS: Windows 10 1903
Toolchain: GNU ARM Embedded 7-2018-q2-update / 8-2019-q3-update
Zephyr: v<IP_ADDRESS>-rc1

Based on this and other investigations I think a solution based on @cszawisza's patch is the right way forward, but it requires additional changes to reverse #15627 and re-solve that change's issue another way.  @SebastianBoe I can take that on unless you want to handle it.

Hi,
please do take this off my hands, I've haven't made much progress.


Black screen after newest update

The Mirror will not exit anymore and is just stuck on a black screen.
Tried downgrading electron but it didn’t work

can you show me the logs?
npm start dev

not really sure how it is supposed to work, I tried the command but got a blank white screen that said: "Devtool was disconnected from the page". if I exit, I get back to the black startup screen where I can't minimize nor exit, the Terminal is still accessible tho.

does the terminal say anything?

npm ERR! Linux 4.14.34-v7+
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
npm ERR! node v7.10.1
npm ERR! npm  v4.2.0
npm ERR! path /home/pi/package.json
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall open
npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent
npm ERR! Please include the following file with any support request:
npm ERR!     /home/pi/.npm/_logs/2018-07-31T10_19_46_423Z-debug.log

I seem to be having this same issue after installing MMM-awesome-alexa for the first time on a previously working Mirror. What can I provide to best help you?

Can you provide logs?
npm start dev

And the logs from the terminal

npm ERR! Linux 4.14.34-v7+
npm ERR! argv "/usr/bin/nodejs" "/usr/bin/npm" "start" "dev"
npm ERR! node v7.10.1
npm ERR! npm v4.2.0
npm ERR! path /home/pi/package.json
npm ERR! code ENOENT
npm ERR! errno -2
npm ERR! syscall open

npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
npm ERR! enoent ENOENT: no such file or directory, open '/home/pi/package.json'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent

npm ERR! Please include the following file with any support request:
npm ERR! /home/pi/.npm/_logs/2018-07-31T10_19_46_423Z-debug.log

you are running the command in the wrong directory

After cd'ing into the modules folder, the entire Mirror interface fails once the git is cloned.
The output after running npm install dev is as follows:
><EMAIL_ADDRESS>start /home/pi/MagicMirror
> sh run-start.sh "dev"

Starting MagicMirror: v2.5.0
Loading config ...
Loading module helpers ...
No helper found for module: alert.
Initializing new module helper ...
Module helper loaded: updatenotification
No helper found for module: clock.
No helper found for module: calendar_monthly.
Initializing new module helper ...
Module helper loaded: MMM-MyCalendar
Initializing new module helper ...
Module helper loaded: MMM-MyWeather
Initializing new module helper ...
Module helper loaded: MMM-MyScoreboard
Initializing new module helper ...
Module helper loaded: MMM-NowPlayingOnSpotify
Initializing new module helper ...
Module helper loaded: MMM-SystemStats
Initializing new module helper ...
Module helper loaded: MMM-lyft
Initializing new module helper ...
Module helper loaded: MMM-uber
Initializing new module helper ...
Module helper loaded: newsfeed
WARNING! Could not load config file. Starting with default configuration. Error found: Error: Cannot find module 'rxjs-compat'
Loading module helpers ...
No helper found for module: alert.
Initializing new module helper ...
Module helper loaded: updatenotification
No helper found for module: clock.
No helper found for module: calendar_monthly.
Initializing new module helper ...
Module helper loaded: MMM-MyCalendar
Initializing new module helper ...
Module helper loaded: MMM-MyWeather
Initializing new module helper ...
Module helper loaded: MMM-MyScoreboard
Initializing new module helper ...
Module helper loaded: MMM-NowPlayingOnSpotify
Initializing new module helper ...
Module helper loaded: MMM-SystemStats
Initializing new module helper ...
Module helper loaded: MMM-lyft
Initializing new module helper ...
Module helper loaded: MMM-uber
Initializing new module helper ...
Module helper loaded: newsfeed
App threw an error during load
Error: Cannot find module 'rxjs-compat'
    at Module._resolveFilename (module.js:543:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._load (module.js:473:25)
    at Module.require (module.js:586:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/pi/MagicMirror/node_modules/rxjs/Rx.js:6:10)
    at Object.<anonymous> (/home/pi/MagicMirror/node_modules/rxjs/Rx.js:8:3)
    at Module._compile (module.js:642:30)
    at Object.Module._extensions..js (module.js:653:10)
    at Module.load (module.js:561:32)
Whoops! There was an uncaught exception...
{ Error: Cannot find module 'rxjs-compat'
    at Module._resolveFilename (module.js:543:15)
    at Function.Module._resolveFilename (/home/pi/MagicMirror/node_modules/electron/dist/resources/electron.asar/common/reset-search-paths.js:35:12)
    at Function.Module._load (module.js:473:25)
    at Module.require (module.js:586:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/home/pi/MagicMirror/node_modules/rxjs/Rx.js:6:10)
    at Object.<anonymous> (/home/pi/MagicMirror/node_modules/rxjs/Rx.js:8:3)
    at Module._compile (module.js:642:30)
    at Object.Module._extensions..js (module.js:653:10)
    at Module.load (module.js:561:32) code: 'MODULE_NOT_FOUND' }
MagicMirror will not quit, but it might be a good idea to check why this happened. Maybe no internet connection?
If you think this really is an issue, please open an issue on GitHub: https://github.com/MichMich/MagicMirror/issues
Launching application.
^CShutting down server...
Stopping module helper: updatenotification
Stopping module helper: MMM-MyCalendar
Stopping module helper: MMM-MyWeather
Stopping module helper: MMM-MyScoreboard
Stopping module helper: MMM-NowPlayingOnSpotify
Stopping module helper: MMM-SystemStats
Stopping module helper: MMM-lyft
Stopping module helper: MMM-uber
Stopping module helper: newsfeed
Stopping module helper: updatenotification
Stopping module helper: MMM-MyCalendar
Stopping module helper: MMM-MyWeather
Stopping module helper: MMM-MyScoreboard
Stopping module helper: MMM-NowPlayingOnSpotify
Stopping module helper: MMM-SystemStats
Stopping module helper: MMM-lyft
Stopping module helper: MMM-uber
Stopping module helper: newsfeed

And this is the result of running npm run electron-rebuild
pi@mirrorpi:~/MagicMirror/modules/MMM-awesome-alexa $ npm run electron-rebuild

><EMAIL_ADDRESS>electron-rebuild /home/pi/MagicMirror/modules/MMM-awesome-alexa
> electron-rebuild --pre-gyp-fix

⠋ Searching dependency treeAn unhandled error occurred inside electron-rebuild
Could not detect abi for version 2.0.0 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron

Error: Could not detect abi for version 2.0.0 and runtime electron.  Updating "node-abi" might help solve this issue if it is a new release of electron
    at Object.getAbi (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/node-abi/index.js:44:9)
    at new Rebuilder (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/electron-rebuild/lib/src/rebuild.js:43:28)
    at Object.rebuild (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/electron-rebuild/lib/src/rebuild.js:217:23)
    at Object.<anonymous> (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/electron-rebuild/lib/src/cli.js:100:33)
    at Generator.next (<anonymous>)
    at fulfilled (/home/pi/MagicMirror/modules/MMM-awesome-alexa/node_modules/electron-rebuild/lib/src/cli.js:5:58)
    at <anonymous>
npm ERR! code ELIFECYCLE
npm ERR! errno 255
npm ERR<EMAIL_ADDRESS>electron-rebuild: `electron-rebuild --pre-gyp-fix`
npm ERR! Exit status 255
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>electron-rebuild script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/pi/.npm/_logs/2018-10-05T16_01_25_918Z-debug.log

@dolanmiu Any idea what the 'rxjs-compat' module is and why it's getting caught there?

Hello, Can you please help me with how you can make this module work? I followed all the instructions in this YouTube video  to set up Amazon Developer account and set up an Alexa Device. I also went through all the steps in this github rep  and this github wiki. I obtained all the codes needed (client id, secret, product id, and refresh token, etc). After I did all the steps, every time I add the config to my magic mirror configuration file the screen go black and nothing works! I tried with my credentials and without it and in both cases the result is the same. Also, I tried the config in both formats, i.e.,
{
"module": "MMM-awesome-alexa",
"position": "bottom_bar",
"config": {
"wakeWord": "Alexa",
"clientId": "YOUR_CLIENT_ID",
"clientSecret": "YOUR_CLIENT_SECRET",
"deviceId": "YOUR_DEVICE_ID",
"refreshToken": "YOUR_REFRESH_TOKEN",
"lite": false,
"isSpeechVisualizationEnabled": false
}
}
and
{
module: "MMM-awesome-alexa",
position: "bottom_bar",
config: {
wakeWord: "Alexa",
clientId: "YOUR_CLIENT_ID",
clientSecret: "YOUR_CLIENT_SECRET",
deviceId: "YOUR_DEVICE_ID",
refreshToken: "YOUR_REFRESH_TOKEN",
lite: false,
isSpeechVisualizationEnabled: false
}
}
Can you help me figure out what I am doing wrong? this is so much appreciated.


Some settings don't persist across Burp restarts

Presently, some PyCript settings persist through restarting Burp, such as "Request/Response Encryption Decryption Files", but others don't such as the "Request/Response Type" radio buttons, and need to be set again every time. Could you please add the calls to saveExtensionSetting https://github.com/Anof-cyber/PyCript/blob/c2652f39381e488bd16d10901792f78bc1433b91/pycript.py#L1094 and loadExtensionSetting https://github.com/Anof-cyber/PyCript/blob/c2652f39381e488bd16d10901792f78bc1433b91/pycript.py#L374 to those settings that don't have it?

Let me know if you'd like me to make a pull request

Sure, I don't think its a big change we can add this as well. If you have added this ,you can create a pull


Improve interconnect template

The kind network is created by kind to attach the management cluster. This change improves the inter-cluster communication, reusing the Kind network and improves the waiting clusters process.
\cc @henderiw

/lgtm

/approve
/override e2e


onnxconverter-common: Add 1.13.0

onnxconverter-common v1.13.0
upstream: https://github.com/microsoft/onnxconverter-common/tree/v1.13.0
jira: https://anaconda.atlassian.net/browse/PKG-931
requirements.txt: https://github.com/microsoft/onnxconverter-common/blob/v1.13.0/requirements.txt
setup.py: https://github.com/microsoft/onnxconverter-common/blob/v1.13.0/setup.py
Changes

Fork from CF
Remove noarch
Update about section

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_2brsf7v21x/clone/recipe/meta.yaml:48: missing_doc_source_url: The recipe is missing a doc_source_url
WARNING: /tmp/abs_2brsf7v21x/clone/recipe/meta.yaml:48: missing_license_url: The recipe is missing a license_url
Warnings were found

Linter check found the following problems:
The following problems have been found:
WARNING: /tmp/abs_50gdq0q1x0/clone/recipe/meta.yaml:48: missing_license_url: The recipe is missing a license_url
WARNING: /tmp/abs_50gdq0q1x0/clone/recipe/meta.yaml:48: missing_doc_source_url: The recipe is missing a doc_source_url
Warnings were found


Issue during compilation with glibc >= 2.30

On Linux systems which use glibc ≥2.30 the following will be logged
during compilation:
In file included from arch/arch_info.c:52:0: /usr/include/sys/sysctl.h:21:2: error: #warning "The <sys/sysctl.h> header is deprecated and will be removed." [-Werror=cpp]  #warning "The <sys/sysctl.h> header is deprecated and will be removed."   ^~~~~~~ cc1: all warnings being treated as errors
The release notes for glibc 2.30 read:
“The Linux-specific <sys/sysctl.h> header and the sysctl function have
been deprecated and will be removed from a future version of glibc.
Application should directly access /proc instead.  For obtaining
random bits, the getentropy function can be used.”
(See also https://sourceware.org/ml/libc-alpha/2019-08/msg00029.html for
the full release notes.)
To Reproduce
1 install glibc  and  glibc-dev / glibc-devel  >= 2.30
2 compile ltfs v. <IP_ADDRESS> :
./autogen.sh
./configure --prefix=$1 --enable-message-checker --enable-warning-as-error
make
Solution
Because of the deprecated sysctl() function,  sysconf()  should be used instead.
Source file  src/libltfs/arch/arch_info.c

It's not mandatory at this time because the main target is RHEL8 and RHEL7.
But it is good to move the API to sysconf() before reconsidering the main target OSs, because RHEL7 and RHEL8 support the API already.


GoMod: Dependency tree is missing edges

The analysis result of the synthetic test project under './analyzer/src/funTest/assets/projects/synthetic/gomod' is missing the edges

´github.com/mattn/go-colorable -> github.com/mattn/go-isatty´
´github.com/mattn/go-isatty -> golang.org/x/sys:v0.0.0-20220610221304-9f5ed59c137d´

Compare with:
cd ./analyzer/src/funTest/assets/projects/synthetic/gomod
go mod graph

Before you're maybe hunting down another path: Could it be that these are OS-specific dependencies?

Before you're maybe hunting down another path: Could it be that these are OS-specific dependencies?

I've updated the ticket description, as I just realized could have been mis-leading. Anyhow, any indication why these could be OS specific?

Anyhow, any indication why these could be OS specific?

It was just a wild guess from the words "tty" and "color" in the package names, as I've seen something similar in other projects before. Windows terminals cannot natively display ANSI colors, so CLI programs might need additional packages that simulate these on Windows.


look for test data

Would be nice to have some test data that is not to big to reduce runtime but where we know what the expected result is. Even more important when it comes to the statistical analysis!!

humann3.0 samples, these are relatively small and should contain genes to some degree since they are from the humann3.0 tutorial, however these are fasta files and i think they are preprocessed as well..

Intestinal response to prenatal inflammation (sus scrofa) 40 samples!!
Enhanced metabolic potentials and functional gene interactions of microbial stress response towards high elevation in freshwater lakes 6 samples per lake, 4 lakes, 2 HEL and 2 LEL -> 24 samples in total but small file size. Note that we dont need host sequence removal for this one. (platform is GeoChip5.0 sadly not illumina, could be an issue in trimming)

metagenomic wgs data from human urine samples, 10 samples with lots of metadata available, good for analysis

The fecal microbiome and rotavirus vaccine immunogenicity in rural Zimbabwean infants
about 150 samples, WGS data, uses humann3, however only one contrast had significant results and MAaslin2 was only used for pathway abundance, gene abundance was tested with willcoxon test only

The fecal microbiome and rotavirus vaccine immunogenicity in rural Zimbabwean infants
about 150 samples, WGS data, uses humann3, however only one contrast had significant results and MAaslin2 was only used for pathway abundance, gene abundance was tested with willcoxon test only

This is unpublished data.


Support extended resources in LowNodeUtilization

Fixes #399
Support extended/custom resources, so as to evict pods based on generic resource including but not limited to (cpu, memory, pods)

/ok-to-test

You could actually probably add a couple tests for pod evictions around custom resources (eg, different values, what happens when you pass a resource that isn't defined, are resources not specified properly excluded, etc)

/kind feature

@ZongqiangZhang thanks for your pull request! It would be nice to also update README.md with some end user docs that explains how to use this new feature.

You could actually probably add a couple tests for pod evictions around custom resources (eg, different values, what happens when you pass a resource that isn't defined, are resources not specified properly excluded, etc)

@damemi  in latest commits, i have just added more test cases, would you please help review again.

@ZongqiangZhang ping

yes, i am working on rebase and new patch

@ZongqiangZhang ping

Hi @ZongqiangZhang, the requested changes are final. Once integrated, we can merge the PR. The next 0.21.0 release is getting closer and it would be great to have this part of it. If your busy, I can take over this PR and integrate the last changes into your PR.

Thanks for your review and patience. I just reset to master branch, and submit commits.

/assign ingvagabund

/approve
/lgtm

@ZongqiangZhang thank you for opening the PR and addressing the comments!!!


Added a feature to store and display highscore

PR Description 📜
A feature to store and display highscore which gets updated once a highscore is reached
Fixes #3362

Mark the task you have completed ✅

[x] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
[x] I have performed a self-review of my own code or work.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] My changes generates no new warnings.
[x] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
[x] I have added screenshot for website preview in assets/images
[x] I have added entries for my game in main README.md
[x] I have added README.md in my folder
[x] I have specified the respective issue number for which I have requested the new game.

Thank you soo much for contributing to our repository 💗

Thank you  @Roshr2211 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀


scrolling down and up causes header's progress slightly change

In my requirments, I need to set the alpha of the view of the header, according to the header's progress.Mostly works fine, but when I scroll down till the progress become 0, release the finger, the I continue scrolling down, dont release the finger and scroll up, the alpha would set back a little, this happen the other way around. After a deep dig in, I found that it was the scrollview's contentOffset that make this happen.
For example, I set the header's minimumHeight to 64, and I scroll down a little bit till the progress become 0. After that, the self.scrollView.contentOffset.y should stay -64, in order to maintain progress 0. But when I scroll and up, the self.scrollView.contentOffset.y would become -65, -66 or even more, then it become -64 again.
Then I found there's a little adjustment in MXScrollView, but the magic-happen-method is a little hard for me to read. Im still trying to understanding it.

I guess I know what's going on here.
The view under the pager is a tableview, just to make things clear.
So here's the problem, dragging the tableview always cause the background MXScrollView scrolling, that's why we need the magic-happen-method to do a little adjustment. So the MXScrollView's contentOffset is always on the change. Now that's ok when we drag tableview within the MXParallaxHeader's height and minimum height, because in layoutContentView you make protection like MAX(relativeHeight, minimumHeight), which also make it safe when we drag tableview in just one direction while MXScrollView is in _lock state (because in this case the relativeHeight is always below minimumHeight).
But the _lock state is a complicated situation,  when u change direction while dragging in this state, relativeHeight would become a little bigger than minimumHeight in the beginning of the changing direction behavior, which also make the result progress change a little bit.
So in layoutContentView, we should also consider the _lock state of the MXScrollView

Actually, just dragging up would make this happen😂


Refactor Dispatchers

Close: #298, #352
This switches from a class-based approach to one that leverages pure functions. While the logic itself isn't any simpler, it was easier to implement (and hopefully understand) it correctly. This conversion was motivated by several bugs that had cropped up and that wouldn't be easily fixable without substantial changes refactor or not.
The one thing that still gets me is the lack of uniformity in usage, but I suppose that's alright given how different the "shared" vs "single" view implementations are.

Hell yeah! Whenever this build gets moved over to PyPi I will begin Conreq integrations.


Fixed custom status issues

Summary

Fixed MM-34924 Status placeholder in profile popover is not correctly themed
Fixed MM-35649 Bots show the integration owner's custom status in post header in RHS

Ticket Link

https://mattermost.atlassian.net/browse/MM-34924
https://mattermost.atlassian.net/browse/MM-35649

Release Note
Fixed MM-34924 and MM-35649 issues

Hello @manojmalik20,
Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

Thank you @manojmalik20!
All yours, @ogi-m :)

@ogi-m, I'm not sure how to fix the test server creation. Any idea?

@agarciamontoro I guess you could check the logs. Maybe there's some info on why it's failing.

/update-branch

We don't have permissions to update this PR, please contact the submitter to apply the update.

I'm not sure how to fix the test server creation. Any idea?

Updating the branch usually does the trick @agarciamontoro @manojmalik20

It's probably because of the failing checks

@manojmalik20, thank you for your patience here :)
@ogi-m, good for QA!


Invalid Noreply  from LittlechatWeb.Room.ShowLive.handle_info/2 callback Error

Cloned the repo, installed the deps, ran the server and whenever displaying the room, I get this issue:
** (ArgumentError) invalid noreply from LittlechatWeb.Room.ShowLive.handle_info/2 callback.

Expected one of:

    {:noreply, %Socket{}}

It looks similar to this Liveview issue phoenixframework/phoenix_live_view#784

After rerunning the application, installed again deps, dropped and removed database,  there is no error right now. Closing issue.


Social share buttons on more pages

We have buttons for posting and tweeting on the financial contribution success page:

We should have similar social share buttons on many other pages too, like:

When you post an Update or Conversation
When you create a new Project, Event, Tier
Expenses
New Collective created
Each Collective page section (About, Budget, Contribute)

I'd like to mention https://github.com/opencollective/opencollective/issues/3734 as it's related: some users don't want the Facebook/Twitter logo to appear on their collectives. We should ideally have an option to disable them (or to customize your share links?) in the settings.

Plan for this week

[ ] Scope design with Caroline

update: picking up with kick-off on 13th


Detect failures to use esc_attr() for printing in HTML attributes

The WordPress.XSS.EscapeOutput sniff will check if unescaped data is output. However, it does not distinguish between output contexts, meaning that the following is not flagged as a error when it obviously should be:
<?php $value = 'end of attribute" onclick="evil()'; ?>
<input type=button value="<?php echo esc_html( $value ) ?>">

The sniff should be updated to help guard against an HTML attribute injection vulnerability.
I suggest that the sniff be updated to look for instances of non-attribute escaping functions, and if the printing function was immediately preceded by a PHP open tag, which in turn is immediately preceded by a string that matches /\w+=['"]$/, that an error should be raised to indicate that esc_attr() should be used.

+1 I've thought of this before but never opened an issue for it.

Makes sense.
It won't catch every case, as in non-XML serialisation of HTML, quotes around attribute values are optional for values without spaces. /\w+=['"]?$/would be needed to be satisfied.
One other point to consider though - some attribute values, such as img src, or a href should be escaped with esc_url(), so you'd need to check for those attribute names too.

One other point to consider though - some attribute values, such as img src, or a href should be escaped with esc_url(), so you'd need to check for those attribute names too.

+1

FWIW, I think esc_html() and esc_attr() are currently equivalent (I would have to double-check though).
Also, similar to what @GaryJones pointed out, special consideration should probably be given to the style attribute as well.

They are equivalent, except that the former applies esc_html filters whereas the latter applies attribute_escape filters.


New displacement calculation

Also updating build-publish workflow to bring into development branch

Making same changes on another branch


Added support for routing based on HTTP request methods

Re-creating the pull request with updated content, as I accidentally destroyed the old one.
Now, in addition to the old method of routing, you can do the following:
server.GET["/path"] = { request in
    // Handle GET request to /path
}

server.POST["/path] = { request in
    // Handle POST request to /path
}

server.PUT["/path"] = { request in
    // Handle PUT request to /path
}

server.DELETE["/path"] = { request in
    // Handle DELETE request to /path
}

server.ANY["/path"] = { request in
    // Handle any of the known HTTP request types for /path
}

One other change from this pull request is that HTTP request methods other than GET, POST, PUT, or DELETE result in an error. This can be changed if necessary (or more methods could be added), though I think that it's best for the server itself to catch invalid HTTP method errors.
Currently, server["/path"] behaves the same way as it used to (same as server.ANY["/path"]), although I recommend changing the behavior of this to either default to GET or to outright remove the old behavior.

It seems that a decision needs to be made whether the HTTP method enum should be part of the HttpRequest class (as in this pull request) or its own top-level type (as in PR #78).
It makes logical sense to make the HTTP method enum be a part of the HTTP request, since methods are only used in HTTP requests in the HTTP protocol. Alternatively, by treating it as its own top-level enum, it is more convenient to use, as it doesn't need to be prefixed with HttpRequest. I leave the decision up to @julien-c and @glock45.

@C0deH4cker Thanks for the PR. I've finally merged your changes :)
HttpSever class has become too big for me so I split the code into two classes: HttpServer and HttpServerIO. The "IO" class is for socket i/o when the first one is for routing.


Add Swift UI implementation

Changes
Introduce CurrencyTextField that conforms to UIViewRepresentable and bridges the UIKit implementation to SwiftUI, by creating UITextField that has a CurrencyUITextFieldDelegate instance as delegate.
Decision context:

Bridging UIKit was needed since unfortunately Apple doesn't provide API for changing the selectedTextRange on TextField yet, which compromised a vanilla SwiftUI implementation given that defining the selected text range is important, mostly for formatters configured with currencies that have the currency symbol at the end
I wanted to make it possible to use CurrencyTextField without having to import UIKit, but fully wrapping UITextField wasn't feasible since once again Apple doesn't provide API to go from SwiftUI to UIKit, but mainly the opposite direction. What I mean by that, as a matter of exemplifying is:

// UIViewRepresentable provides a function to update the underlying `uiView`
func updateUIView(_ uiView: Self.UIViewType, context: Self.Context)

// This function is called whenever there are updates, for example,
// when a modifier is used or in a new layout cycle done by SwiftUI
CurrencyTextField()
   .font(.title)

// triggers
func updateUIView(_ uiView: Self.UIViewType, context: Self.Context) {
    context.environment.font // .title
}
// with font as part of context environment

// it would be very nice to thus use this moment to update
// the text field with given context changes, like font.
// However Apple doesn't provide conversion from
// e.g. `Font` -> `UIFont` and other SwiftUI properties.
// Therefore to avoid hacks and have an API that is still simple,
// the configuration of the textField is done via closure,
// which as downside requires the user to import UIKit

import SwiftUI
import UIKit

CurrencyTextField(
    configuration: .init(
        placeholder: "Play with me...",
        text: $viewModel.data.text,
        unformattedText: $viewModel.data.unformatted,
        inputAmount: $viewModel.data.input,
        clearsWhenValueIsZero: true,
        formatter: .default,
        underlyingTextFieldConfiguration: { uiTextField in
            uiTextField.borderStyle = .roundedRect
            uiTextField.font = .systemFont(ofSize: 20)
            uiTextField.textColor = .blue
            uiTextField.layer.borderColor = UIColor.red.cgColor
            uiTextField.layer.borderWidth = 1
            uiTextField.layer.cornerRadius = 4
            uiTextField.layer.masksToBounds = true
        },
        onEditingChanged: { isEditing in
            bool = isEditing
            if isEditing == false {
                // How to programmatically clear the text of CurrencyTextField:
                // The Binding<String>.text that is passed into CurrencyTextField.configuration can
                // manually cleared / updated with an empty String
                clearTextFieldText()
            }
        },
        onCommit: {
            print("onCommit")
        }
    )
)

Additions

Declare new libraries via SPM and CocoaPods:

new library CurrencyTextSwiftUI defined on SPM
new CocoaPods sub-spec named CurrencyTextField

Update libraries to be built using Swift 5.3 toolchain - previously using Swift 5.0
Update to support from iOS 11.0 instead of 9.0

Since very few users are still on iOS 9 and 10 and the SnapshotTesting framework requires a min iOS 11 (Unfortunately SPM doesn't support defining a platform version on conditional target dependencies, yet?)

Updates

Improves the ExampleApp with both UIKit and SwiftUI examples. The app was made Storyboardless.
Fix CurrencyFormatter.unformatted(string:) to correctly return the unformatted value when hasDecimals is true
Change CurrencyUITextFieldDelegate.textField(_:shouldChangeCharactersIn:replacementString:) -> Bool to call passthroughDelegate after updating text and selectedTextRange, when it was doing that before instead - This might be a breaking change for user relying on passthroughDelegate.

WIP

[ ] SwiftUI library documentation for public types
[ ] Further manual validations of using the library via CocoaPods
[ ] Evaluate enabling library evolution

Post merge TODO

[ ] Update on README and project documentation
[ ] Bump version and release

Tests

Covered most parts with unit and snapshot tests

#76

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@19d2de2). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage        ?   96.86%
=======================================
  Files           ?       21
  Lines           ?      958
  Branches        ?        0
=======================================
  Hits            ?      928
  Misses          ?       30
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19d2de2...568ae7d. Read the comment docs.


Option for delete key to delete last character instead of entire entry

As I said on the pull request’s discussion, I’ll go along with making this the default, but I have to say I really, really don’t get it. I mean, you’re replacing this:

Typo
⌫
Type abbreviation again (most likely effortless due to muscle memory)

with this:

Typo
Press ⌫ enough times to remove the mistake
What did I mean to type?
What is left undeleted?
What is the difference between those?
Type the difference (for which you have no muscle memory)

Thanks for chiming in @hmelman over on the pull request.
Rob - what's your argument for every other search field (including Spotlight and I'm assuming other app launchers) using 'delete removes a single character'?
What you outlined in your second set of steps is what I have to do everywhere (URL bar, Google, Spotlight, Contacts...).
I think you have a case arguing that it might not be best for short strings where you might be typing abbreviations, but I think deleting the whole string and starting from scratch is more of a 'power user' thing, and is why it should still be an option, just not the default

Rob - what's your argument for every other search field (including Spotlight and I'm assuming other app launchers) using 'delete removes a single character’?

Those are text boxes, just like Quicksilver is in text-entry mode. The behavior makes sense in those contexts because you’re “editing” text.
You can also see what you’re working on, where in QS you’d have to parse out which characters are highlighted in the first pane, and they could jump around as you add/remove characters if the result changed. It just never felt like “entering text” to me.

I think you have a case arguing that it might not be best for short strings where you might be typing abbreviations

What else would you be typing when searching with Quicksilver? 😃

but I think deleting the whole string and starting from scratch is more of a 'power user' thing, and is why it should still be an option, just not the default

Maybe it would help to know that I rarely need to type more than 2 characters to find what I’m after, and 5 characters is like a crazy edge case that annoys me. So losing all of it and starting over is pretty low cost.
Is that “power user” behavior? I thought that was the whole point of this app!
Anyway, no one needs to convince anyone else here. I’ve already said I’ll go along with the new default.


Lodash dependencies triggering vulnerabilities(high)

The current version of lodash in the package.json file is "^3.10.1".  This is triggering a 'Prototype Pollution' High-level warning during install.  According to the audit message, any version higher than 4.17.11 of lodash should resolve this issue.
https://www.npmjs.com/advisories/782
It appears this issue has been asked before, but the issuer closed the issue (I'm assuming he got tired of waiting for a response)

I think i'm gradually going to remove lodash entirely from grunt prompt.

@piper1970 Do you know if it's a MUST for this package to support super old Node? I'd like to use es6 stuff.


OpenXR loader: fix for implicit/explicit api layer loading logic.

There is a case where one runtime's layers are all implicit, but app still mentions those layers in create instance. Loader will throw 'XR_ERROR_API_LAYER_NOT_PRESENT' because it will try to find implicit layers from explicit layer manifest files vector (empty! :(  ).
So it should be ok to move this check out of API layer search in explicit layer manifest returned by runtime.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.dengkail seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.

Hi @rpavlik, I create a MR to fix issue we have discussed before regarding api layers loading logic when runtime's api layers are all implicit, plese help review, thanks!

@quic-dengkail Please get the Contributor License Agreement signed/agreed to so that I can merge this.

@quic-dengkail Please get the Contributor License Agreement signed/agreed to so that I can merge this.

done.


TechTown link broken on StartupDetroit homepage

Correct link should be: https://techtowndetroit.org/

Thanks for the contribution @jacobsmith88! Just deployed an update - should be fixed now


feat(resizableGrid): SKFP-698 add download graph data

FEATURE

closes #698

Description
Implement the download by png, svg through a preview modal that will include the chart values and legend. In the modal, the user will have a preview of the chart and will be able to confirm and proceed to the download for the specific file format (PNG, SVG), or cancel and close the modal. The download data will be done directly from the chart’s dropdown and will not open a modal. (TSV) .

- Modal title: “Download preview – Chart Title"
  Download PNG/SVG values and legend examples:
  Demographics, Participant by Data Type, Participant by Data Category, Age at Diagnosis, Studies.
    Value: Male , Count: 6769, Frequency: (50.89%)
    e.g.,red Male 6769 (50.89%)
- For the 2 sunbursts, for now we can display simply display the image of the sunburst as it is in the Summary View including the description on the right hand side of the chart widget.
- The download data (tsv format) would capture the Value (Sex:Male) , Count (4235) , and Frequency (% of the value over the total values) for most of the graphs in the Data Exploration.
- For the 2 sunbursts, we shouldn't be able to download tsv. Only PNG and SVG
- Download PNG/SVG File naming: kidsfirst-chart title-chart-year-month-day
  Download data File naming: kidsfirst-chart title-data-year-month-day
- The chart titles that have multiple words, it can all be set in lowercase, without any separation: ex.-participantbydatatype-
-

Acceptance Criterias
Validation de Qualité

[ ] Validation du design avec design figma (dev)
[x] QA - Validation des critère de succès (via screenshot)
[ ] Design/UI - Validation du respect du design/theme

Screenshot

https://github.com/Ferlab-Ste-Justine/ferlab-ui/assets/65532894/519b1b64-86dc-4d1c-9bae-47b17eb96d85
https://github.com/Ferlab-Ste-Justine/ferlab-ui/assets/65532894/86b00dee-573c-46bd-9812-7b0325cb7d6e
https://github.com/Ferlab-Ste-Justine/ferlab-ui/assets/65532894/b24cc69c-b135-4b25-997b-570fa44b2d6d
Mention
@luclemo @kstonge

Typo
Le titre de la modal de download devrait être “Download preview – Chart Title" avec un "p" minuscule pour "preview".

J'ai corrigé la typo
De plus, @luclemo , j'avais ajouté le type d'élément qu'on allait télécharger (.svg ou .png). Est-ce que je garde le type? Je trouve que ça permet de savoir quel type on va télécharger


[TOOLS] Improve generate-test-checks.py

Format the doc string using the reStructuredText format.
Lift the example instructions from the .mlir.in file to the docstring. Previously we matched the module keyword twice and encountered errors such as assert len(output_segments) == len(source_segments),. It's also fine to update the regex to something like \bmodule to solve the problem, but I think lifting it from the input file is just simpler.

module was used in both source_delim_regex="module" and module attributes {...


Make with the fasterfaster

Add an optimisation for simple queries that avoids locking the tables (by eliminating the use of temp tables)
@scoen @yetti @josephcurtis @terenceingram

SonarQube analysis reported 7 issues

 AmberQuery.java#L324: Identical sub-expressions on both sides of operator "||"
 AmberQuery.java#L288: The Cyclomatic Complexity of this method "executeSimpleQuery" is 19 which is greater than 10 authorized.
 AmberQuery.java#L292: Return an empty collection instead of null.
 AmberQuery.java#L297: Use isEmpty() to check whether the collection is empty or not.
 AmberQuery.java#L298: Return an empty collection instead of null.
 AmberQuery.java#L303: Return an empty collection instead of null.
 AmberQuery.java#L308: Return an empty collection instead of null.

Build finished.


Rename src/pages/about/handbook/vision.mdx to src/pages/about/vision.mdx

Changed to page location.
from Handbook to under the About page.

@eckartal seems like you miss the image, can u make sure also move several image inside /handbook/_assets to about/_assets


chore(release): 3.0.1 Release

What's Changed

docs: update license type to ISC by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/59
build: upgrade checkout and setup-node by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/60
style: add parentheses in arrow functions by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/61
refactor: createReview() function to reduce redundancy by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/62
refactor: create comment for prs author by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/63
refactor: using strict equality operator check by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/64
fix(prsReview): adjust author_association payload by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/65
chore: rename env to .env by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/66
chore(release): bump from 3.0.0 to 3.0.1 by @Muunatic in https://github.com/Typeslint/github-AutoResponse/pull/67

Full Changelog: https://github.com/Typeslint/github-AutoResponse/compare/3.0.0...3.0.1

PING @Muunatic

ready to merge

ready to merge


Hero for the homepage

This pull creates a hero for the homepage. The hero is implemented in bootstrap and uses classes to achieve the desired look.

please remove things unrelated to the hero front-page, there are general clean-ups (belongs to separate PR's)
Thanks!

Superseeded by #120


Review

Coverage remained the same at 100.0% when pulling 2c9c2aa78ca19d7ad8d290423c27b1b7f393efab on review into b78e6c4657519ebe5acae1f8e42aeeb6d02624de on master.


Spelling

This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/Yamale/commit/05acafc63835ef0f4accf064a4f21ae6ee70707d#commitcomment-45715812
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/Yamale/commit/d123f3897ff6351ea7315c54e2586840227137b5
Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Thanks!

Thanks!


Question: Column Width Difference in ABAP2XLSX and Excel

Hello Stefan and Ivan,
one tiny question about the difference of the column width in ABAP2XLSX and Excel.
Here the part of code:
lo_worksheet->set_column_width( ip_column = lv_column_alpha ip_width_fix = '13.75' ).
And here the result in Excel:

Why did I have a difference here?
Thanks in advance and cheers
Stefan

Hi Stefan,
Long explanations:  See https://msdn.microsoft.com/de-de/library/documentformat.openxml.spreadsheet.column(v=office.14).aspx
Scroll down a bit and you get a lengthy explanation for your effect.
Short explanation:
Subtract 0,7 which corresponds to 9 pixels padding at 96 dpi

Hello Stefan,
thank you very much.
Cheers
Stefan


Public key signature verification has failed.

sh -c "$(wget https://raw.githubusercontent.com/robbyrussell/oh-my-zsh/master/tools/install.sh -O -)"
fatal: unable to access 'https://github.com/robbyrussell/oh-my-zsh.git/':
gnutls_handshake() failed: Public key signature verification has failed.
Error: git clone of oh-my-zsh repo failed.

% uname -a
Linux drml 4.9.0-2-amd64 #1 SMP Debian 4.9.18-1 (2017-03-30) x86_64 GNU/Linux

git clone git://github.com/robbyrussell/oh-my-zsh.git ~/.oh-my-zsh
cp ~/.oh-my-zsh/templates/zshrc.zsh-template ~/.zshrc

sudo vi /etc/passwd
/home/user:/bin/bash -> /home/user:/bin/zsh


Scheduled maintenance for Auth Service

This is an update about scheduled maintenance.

Another comment about the scheduled maintenance.


⚠ Jenkins Plugins Artifactory has degraded performance

In 2cf7de5, Jenkins Plugins Artifactory (https://get.jenkins.io/plugins/artifactory/) experienced degraded performance:

HTTP code: 200
Response time: 1448 ms

Resolved: Jenkins Plugins Artifactory performance has improved in 0c17f31 after 15 minutes.


ci: update reference docs

This PR is auto-generated by a nightly GitHub action to update the reference docs from source code in withastro/astro.

Closing this one, made some fixes at the source


Just interesting:)

It's not exclude positions it's good excepted position and exclude any other filters. If i have this word in position title, i will invite this contact in my network.
Welcome)


DNS failover handling

Hello there,
I want to add DNS failover support for the client.
This implementation inclined with Nginx's behavior when used as a reverse proxy.
I need help adding the required specs; if someone wants to help, please send a pull request to my branch.
For some context, some services use A records with multiple IP addresses, unless you are large enough to handles failover at the BGP level, this is the only practical way to eliminate a single point of failure.
But the failover technique needs client support, hence the pull request.

Thank you!


⚠ Bofrost.de has degraded performance

In 5ffa6ec, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 728 ms

Resolved: Bofrost.de performance has improved in daf83e4 after 15 minutes.


[Issue-3139] Extension - Remove Parallel liquid staking

Related issue: #3139

🚀 Deployed on https://pr-3154--sw-web-runner.netlify.app


[FEATURE] Realtime winter pipeline

Is your feature request related to a problem? Please describe.
I'm always frustrated when I realise that sky flats (and sky subtraction) will not work in realtime as wellcurrently formulated
Describe the solution you'd like
We need to do something different instead:
Calhunter the stacks from previous nights?
Use a master?

Possible option on the call: masters for weird exposure times like 10s/30s?


Create demonstrations of using trestle as a pre-commit hook.

As a trestle user it would be fantastic if trestle can run , for certain operations, as a pre-commit hook.
Trestle is not optimised for pre-commit, however, pre-commit can easily be configured for trestle. Provide an example in the compliance-trestle-demos project.

Based on the way trestle is working I recommend that we change this to a documentation issue.

Do validation using trestle during commit.

@butler54 We were reviewing stale issues and we were wondering we should move/transfer this issue to the demos repo, will that work for you in this case? Thanks

Closing. This would take a lot of engineering work and is outside the scope of the project.


Web based query interface

For my own testing and development with Ekanite, I have created a small web based query interface.
In my pull request, it replaces the telnet query interface.
I am unsure if the former interface was also meant to be used as an API of sorts.
In this case, I may add an RESTful endpoint to my PR if there is interest. This may also be interesting for further expansion.
TLS protection and authentication is currently not handled by this code and should be done via e.g. nginx for production setups.
Looking forward to your feedback!

Thanks @fabian-z -- I like the idea, and will run your code shortly to check out the functionality.
However, the simple telnet-like interface is not going away, as I want to build a more sophisticated CLI at some point, and it will use that interface. I would be interested in adding this to ekanite, but it must be implemented as a distinct server within the system, which would listen on a different port.
Make sense?

:+1: for a nice CLI application! :tada:
Even though I definitely see your point, I would like to bring up some thoughts about security and future extensibility of the telnet interface here:
Telnet itself is more difficult to secure than a simple HTTP/REST endpoint. You would need e.g. SSH port forwarding to safely run the CLI on your own machine instead of a shell on the Ekanite server.
Using a simple nginx setup with Basic Auth over TLS would enable the CLI application to be usable on any client.
Also, I think expanding the telnet interface would result in the equivalent of creating a special wire protocol for Ekanite over time. I can imagine that issues such as versioning of the API (different server <-> client versions) and passing complex structures back and forth could get problematic at some point in time. If this kind of effort is planned, building on something akin to protobuf might be an option, too.
With that being said, I don't want to question any of your design decisions here - I am glad you like my contribution as I think it will be helpful in its own right also when co-existing with the telnet interface. I will be glad to contribute my code as a separate server entity with its own configuration option if you would like me to.
Keen on your feedback regarding functionality!

Thanks @fabian-z

Telnet itself is more difficult to secure than a simple HTTP/REST endpoint.

Agreed. If someone doesn't want to run the insecure system, we should update the code so that it can be disabled if no address is passed on the command line for the query server. There is no need to rip it out though, it can co-exist.

Also, I think expanding the telnet interface would result in the equivalent of creating a special wire protocol for Ekanite over time.

Yes, this may make sense in the future, especially for paging of results.

I appreciate the dialogue.
Your point for an optional, modular interface system is clear. Do you think both interfaces should be opt-in or should one be preferred? I think having at least one standard interface (while documenting both) would be beneficial for first time users.
Also, I'd love to hear what you think about making the tests independent from any interface (cf65d95) and also about the syntax reference URL change in 176d4c0.
When that is clear, I think it will be easier for me to start a new branch/PR and to incorporate everything there.

Your point for an optional, modular interface system is clear. Do you think both interfaces should be opt-in or should one be preferred? I think having at least one standard interface (while documenting both) would be beneficial for first time users.

The telnet server is opt-out after my most recent change to master. All other interfaces could be opt-in.

Also, I'd love to hear what you think about making the tests independent from any interface (cf65d95) and also about the syntax reference URL change in 176d4c0.

Making the tests independent makes sense. I don't follow you about the syntax change.

When those aspects are decided upon, I think it will be easier for me to start a new branch/PR and to incorporate everything there.

Sounds good, thanks @fabian-z

@fabian-z -- do you still plan to integrate the web server alongside the telnet server? If not, I may use your code as inspiration, and do just that.

@otoolep: It's still on my TODO list and I think I will find time for the needed adaptions (in a new PR) during the next week. My current workload made it difficult for me to get around implementing it earlier.
With that being said, if you want to implement my suggestion before next week, feel free to reuse my work as much as you can. :smile:

Closing here in favor of v2 PR


Create tags for releases done on crates.io

Currently it's rather hard to find out which version on creates.io corresponds to which version of the source code. This makes debugging problems with released versions harder.

@rnestler I'll try to maintain tags from now on :). But need the current master to be reviewed thoroughly before releasing to crates

Trying out master right now. It seems the keep_alive is never sent in the basic pubsub example and will be disconnected when time is up.

@TheBestJohn pubsub1 seems to be working for me locally. Are you connecting to local broker?

This is an improvement over tokio2 branch. If pings are not working then it's a bug and that needs to be fixed. In this branch, we ping only when the network is idle. But if there is a disconnection, then it's a bug. Is there a way for me to reproduce your setup?

I'm not doing anything terribly different from pubsub1 aside from setting a username and some different publish parsing. I just kinda want this guy to sub and sit around forever printing out data. I've set the keepalive low because I think Mosquitto allows you to declare your keepalive and it will hold you to that. I'm not trying to just see the 2 publishes I send, I want to loop there and wait.
https://gist.github.com/TheBestJohn/924a993e13585b751c5a5f2df44eebd7#file-main-rs-L49-L52
this ends up with the highlighted lines on the mosquitto log after 30 seconds.

Figured out what triggers it. Try connecting to your local broker with anything else and sending a message that isn't from this lib. It should then disconnect.

@TheBestJohn Can you test the master now?
@rnestler Sorry this issue got off the track. I'll change the name.

@tekjar Got this on my home machine and it seems to send the pings when needed. Awesome fix my friend! I'll do some more testing as soon as I can but I think this fits the bill. Thanks for taking a look at it and I'm glad I could contribute at least a little.

@TheBestJohn Thanks for helping :). Keep contributing


Fix CheckGroup onSelect to return latest checked state - fixes #75

I noticed this behavior broke when upgrading to RN 0.26 from RN 0.24 and from version 0.3.3 to 0.3.6 of this lib. Since setState behavior is no longer synchronous, we pass the newSelected directly instead of relying on setState. Thanks for your library!

Thanks!


Determine number of sites automatically in runcircuit/getsamples

In runcircuit/getsamples, in calls like runcircuit(N, gates), in theory the number of sites N could be determined automatically by searching through the gate list for the largest site that is found. Therefore we could make inputting N optional (there may be times when you still want to specify N, like if you don't have gates on your entire system).

Good idea. And yes, we should leave the option to input N if there are spectator qubits.


Some undisposed objects in goog.editor

This issue was imported from Closure Library's previous home at http://closure-library.googlecode.com
The link to the original issue is:
https://code.google.com/p/closure-library/issues/detail?id=516

Create and dispose goog.editor with monitoring instances as below.
goog.Disposable.MONITORING_MODE = goog.Disposable.MonitoringMode.PERMANENT;
document.body.appendChild(goog.dom.createDom('div', {'id': 'toolbar'}));
document.body.appendChild(goog.dom.createDom('div', {'id': 'editMe'}));
var myField = new goog.editor.Field('editMe');
/**

@param {goog.editor.Plugin} plugin The plugin to register.
*/
var registerPlugin = function(plugin) {
myField.registerPlugin(plugin);
myField.registerDisposable(plugin);
};

// Create and register all of the editing plugins you want to use.
registerPlugin(new goog.editor.plugins.BasicTextFormatter());
registerPlugin(new goog.editor.plugins.RemoveFormatting());
registerPlugin(new goog.editor.plugins.UndoRedo());
registerPlugin(new goog.editor.plugins.ListTabHandler());
registerPlugin(new goog.editor.plugins.SpacesTabHandler());
registerPlugin(new goog.editor.plugins.EnterHandler());
registerPlugin(new goog.editor.plugins.HeaderFormatter());
registerPlugin(new goog.editor.plugins.LoremIpsum('Click here to edit'));
registerPlugin(new goog.editor.plugins.LinkDialogPlugin());
registerPlugin(new goog.editor.plugins.LinkBubble());
// Specify the buttons to add to the toolbar, using built in default buttons.
var buttons = [
goog.editor.Command.BOLD,
goog.editor.Command.ITALIC,
goog.editor.Command.UNDERLINE,
goog.editor.Command.FONT_COLOR,
goog.editor.Command.BACKGROUND_COLOR,
goog.editor.Command.FONT_FACE,
goog.editor.Command.FONT_SIZE,
goog.editor.Command.LINK,
goog.editor.Command.UNDO,
goog.editor.Command.REDO,
goog.editor.Command.UNORDERED_LIST,
goog.editor.Command.ORDERED_LIST,
goog.editor.Command.INDENT,
goog.editor.Command.OUTDENT,
goog.editor.Command.JUSTIFY_LEFT,
goog.editor.Command.JUSTIFY_CENTER,
goog.editor.Command.JUSTIFY_RIGHT,
goog.editor.Command.SUBSCRIPT,
goog.editor.Command.SUPERSCRIPT,
goog.editor.Command.STRIKE_THROUGH,
goog.editor.Command.REMOVE_FORMAT
];
var myToolbar = goog.ui.editor.DefaultToolbar.makeToolbar(buttons, goog.dom.getElement('toolbar'));
// Hook the toolbar into the field.
var myToolbarController = new goog.ui.editor.ToolbarController(myField, myToolbar);
goog.events.listen(myField, goog.editor.Field.EventType.LOAD, function() {
myField.makeUneditable();
myField.dispose();
myToolbarController.dispose();
var undisposedObjects = goog.Disposable.getUndisposedObjects();
console.log(undisposedObjects.length);
});
myField.makeEditable();
What is the expected output? What do you see instead?
The console output
expected: 0
actual: 3
What version of the product are you using? On what operating system?
r2325
Please provide any additional information below.
The undisposed objects:
goog.async.Delay in goog.editor.Field
(https://code.google.com/p/closure-library/source/browse/trunk/closure/goog/editor/field.js?r=2325#140)
(https://code.google.com/p/closure-library/source/browse/trunk/closure/goog/editor/field.js?r=2325#868)
goog.events.EventHandler in goog.editor.plugins.AbstractBubblePlugin
(https://code.google.com/p/closure-library/source/browse/trunk/closure/goog/editor/plugins/abstractbubbleplugin.js?r=2325#63)

This issue is being closed as a preparation step before archiving the repository.  See the README for more detail.


Allow SSL configurations to fall back on the system CA

The current SSL API requires users to specify a certificate authority file. All of the official drivers allow users to instead fallback to the system CA, so we should do that too.
In order to test this properly, we'd need to spin up a third mongod that requires SSL but does not have a CA specified and then make a specific test that attempts to connect without specifying it. Given that this is a very small variation on the existing SSL tests and that we rely entirely on the OpenSSL implementation to perform this feature, I don't think it's worth increasing our Travis usage by 50% for this (especially given that Travis servers are grouped by Github organization/user, and there are a lot of projects in mongodb-labs, some of which have more pressing needs for prompt CI feedback). I've verified that this works locally.

@saghm  When should we expect this fix to merge. I am currently testing library and having issues to connect to MongoDB Atlas.
Thank you for your work.

@goriunov I just merged it, and pending a final test run, I'll release it right away!

Published in 0.3.12


Star ccm update to include Slurm

Added a StarCCM on Slurm blueprint

@cboneti
Nick is out of town. Who can I get to review this?

/gcbrun

PR-validation fails, you can find following in the step logs:
Step #2 - "pre-commit-run": examples/README.md:866:1: MD012: Multiple consecutive blank lines [Expected: 1, Actual: 2] (no-multiple-blanks)

/gcbrun

@cboneti I think I have all the corrections in place. Thanks!

/gcbrun

Test fails with:
failed to parse the blueprint in /tmp/tmp.dw7nFWZzGS/tutorial-starccm-slurm.yaml, check YAML syntax for errors, err=yaml: line 46: mapping values are not allowed in this context

/gcbrun


EIS 2023 calibration

Sorry this might be very dumb on my side.
I briefly remembers the eispac code uses Warren et al. 2014 to calibrate the files? Is there a place this is specified? I think adding the ability/tutorial to use different calibrations (e.g. the latest Del Zanna et al. 2023) could be extremely useful.

Hello Andy,
This is very good question! EISPAC actually currently only has the pre-flight calibration available, unfortunately. However, the one of the goals is to eventually have the level-1 HDF5 files serve as a long-term archive of EIS data and associated metadata. As such, we are planning to update the files in the next few months to include all of the the calibrations currently available. The 2023 calibration is still going through peer-review, so we are waiting a little bit to make sure we do not need to revise or update the methodology further before we reprocess all the header files. Sorry it has taken so long!

Hi Micah!
Thank you for the clear reply! :D  Let me know if I can be of any help!

Thought I will keep the thread updated with this.
I translated the IDL calibrations (Warren et al. 2014 and Del Zanna et al. 2023 in review) into Python (pretty much a 1 to 1 translation). You can find the tutorial in the following link.
https://github.com/andyto1234/EISPAC-Tutorial___Calibrations/