fix so cursor packet is sent to client with open inventories

Objective
Attempts to solve the issue shown in discord https://discord.com/channels/998132822239870997/1292890441011957830
where doing  has no effect in a "open inventory"
Looks like an oversight in the system to update the open inventories, no attempt to send any packet to the user was made when the CursorItem component was updated by any system
Playground to reproduce the issue solved by this pr.
use valence::interact_block::InteractBlockEvent;
use valence::inventory::ClickSlotEvent;
use valence::log::LogPlugin;
use valence::prelude::*;

#[allow(unused_imports)]
use crate::extras::*;

const SPAWN_Y: i32 = 64;
const CHEST_POS: [i32; 3] = [0, SPAWN_Y + 1, 3];

pub(crate) fn build_app(app: &mut App) {
    app.insert_resource(NetworkSettings {
        connection_mode: ConnectionMode::Offline,
        ..Default::default()
    })
    .add_plugins(DefaultPlugins.build().disable::<LogPlugin>())
    .add_systems(Startup, setup)
    .add_systems(
        EventLoopUpdate,
        (toggle_gamemode_on_sneak, open_chest, select_menu_item),
    )
    .add_systems(Update, (init_clients, despawn_disconnected_clients))
    .run();
}

fn setup(
    mut commands: Commands,
    server: Res<Server>,
    biomes: Res<BiomeRegistry>,
    dimensions: Res<DimensionTypeRegistry>,
) {
    let mut layer = LayerBundle::new(ident!("overworld"), &dimensions, &biomes, &server);

    for z in -5..5 {
        for x in -5..5 {
            layer.chunk.insert_chunk([x, z], UnloadedChunk::new());
        }
    }

    for z in -25..25 {
        for x in -25..25 {
            layer
                .chunk
                .set_block([x, SPAWN_Y, z], BlockState::GRASS_BLOCK);
        }
    }
    layer.chunk.set_block(CHEST_POS, BlockState::CHEST);

    commands.spawn(layer);

    let mut inventory = Inventory::new(InventoryKind::Generic9x3);
    inventory.set_slot(1, ItemStack::new(ItemKind::Apple, 64, None));
    inventory.set_slot(2, ItemStack::new(ItemKind::Diamond, 40, None));
    inventory.set_slot(3, ItemStack::new(ItemKind::Diamond, 30, None));
    commands.spawn(inventory);
}

fn init_clients(
    mut clients: Query<
        (
            &mut EntityLayerId,
            &mut VisibleChunkLayer,
            &mut VisibleEntityLayers,
            &mut Position,
        ),
        Added<Client>,
    >,
    layers: Query<Entity, (With<ChunkLayer>, With<EntityLayer>)>,
) {
    for (mut layer_id, mut visible_chunk_layer, mut visible_entity_layers, mut pos) in &mut clients
    {
        let layer = layers.single();

        layer_id.0 = layer;
        visible_chunk_layer.0 = layer;
        visible_entity_layers.0.insert(layer);
        pos.set([0.0, f64::from(SPAWN_Y) + 1.0, 0.0]);
    }
}

fn open_chest(
    mut commands: Commands,
    inventories: Query<Entity, (With<Inventory>, Without<Client>)>,
    mut events: EventReader<InteractBlockEvent>,
) {
    for event in events.read() {
        if event.position != CHEST_POS.into() {
            continue;
        }
        let open_inventory = OpenInventory::new(inventories.single());
        commands.entity(event.client).insert(open_inventory);
    }
}
fn select_menu_item(
    mut clients: Query<(Entity, &mut CursorItem)>,
    mut events: EventReader<ClickSlotEvent>,
) {
    for event in events.read() {
        let Ok((_player, mut cursor_item)) = clients.get_mut(event.client) else {
            continue;
        };

        // this does not work properly
        cursor_item.set_if_neq(CursorItem(ItemStack::EMPTY));
    }
}
// Add more systems here!

Solution
Copied the approach to sync the CursorItem state from the update_player_inventories system to the update_open_inventories where it was previously left out (my assumption is that it was left out by mistake).

The tests will need to be updated.

This has a test failure(as you also already spotted), don't merge this just yet, will need to get an implementation that does not send a packet to the client when it was the client that updated it! thanks for the quick review!


[Feature] Add Apache Doris Extract Node for Sort

Description
you can refer to:
https://inlong.apache.org/docs/next/design_and_concept/how_to_extend_data_node_for_sort#extend-a-new-extract-node
Use case
No response
Are you willing to submit PR?

[ ] Yes, I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

Hi, @dockerzhang ,can you assigin https://github.com/apache/inlong/issues/5040 to me? thanks

@duoduo5566 thanks.

@dockerzhang  Sorry, I clicked the unassign me button by mistake, please assign me again

@duoduo5566 done

Hi，@dockerzhang ! I plan to introduce the flink doris connector implementation of the doris community, which has been compiled locally and integrated into inlong. However, the doris community currently does not support version 2.11 for flink 1.13. Do we have relevant public maven repositories to upload flink-doris-connector-1.13.5_2.11 for everyone to use?

@duoduo5566 all connectors in InLong will publish to central maven repositories, and I think everyone can access it directly.


Add minReadySeconds property to the Container

Overview of feature request
There is a property called minReadySeconds that corresponds to the amount of time to wait for the health checks to start after the container is ready. It can be thought of as the short while to wait until the container is stable.
Here is the link to the official documentation: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/#min-ready-seconds.
Acceptance criteria

minReadySeconds added to the Container properties.
Unit tests and functional tests should be added.

Additional context
This is more like an improvement that we can do later.
AB#9966

https://kubernetes.io/blog/2021/08/27/minreadyseconds-statefulsets/


Add note to have debug version of proxy for curl command

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:
Assign the PR to them by writing /assign  in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Loading image from Wordpress on webapp Canvaskit failing

Hi @ArunPrakashG ,
Thanks again for your great support, I have a big problem loading images from a WordPress website in a Flutter web app with Canvaskit renderer, in a release mode I get this error:
Access to fetch at 'https://b2bboostify.co.uk/wp-content/uploads/2023/10/two-young-happy-businesswomen-celebrating-project-success-office.jpg' from origin 'https://b2boostify.web.app' has been blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource. If an opaque response serves your needs, set the request's mode to 'no-cors' to fetch the resource with CORS disabled.

I understand it's a very common problem, do you know a solution for this issue?
Thanks in advance!

Thanks a lot, @ArunPrakashG , I fixed this!


The best way to assign different command line arguments to different schemes

Hey guys!
What would be the best way to give different command line arguments to different schemes?
The following setup gives the same argument to all listed schemes:

Hi @kliukin. If you want different command line arguments per config variant, you will have to create the schemes separately using the extended schemes definitions which are documented here https://github.com/yonaskolb/XcodeGen/blob/master/Docs/ProjectSpec.md#scheme
(I also noticed you had a typo in -FIRDubugEnable if that helps in the future) :)

Hi @yonaskolb!
Yes, I had to define all schemes separately which is a bit verbose as we have many of them.
Thanks for your help)

@kliukin cool, glad you got it sorted. If your scheme definitions are quite large you can also leverage scheme templates to reduce duplication https://github.com/yonaskolb/XcodeGen/blob/master/Docs/ProjectSpec.md#scheme-template


Delta > Initial SoC is missing in transaction metervalues

Workaround done.

Already done & Tested

Gerald said to track the issue within the firmware with Cahors in a mail exchange. But if the workaround is enough, that's fine and I'll close it again ;-)

Gerald said to track the issue within the firmware with Cahors in a mail exchange. But if the workaround is enough, that's fine and I'll close it again ;-)

Yes indeed!

Firmware version 3.3.2 deployed. Need to check if the issue is still here.

The SoC is here now:


fix: clearing database on different user login

method LoginModel::login is modified to just get access token
new method LoginModel::isPreviousUser is added to check different user login
method LoginPresenter::login is modified accordingly to clear database on different user login and starts data loading after that only.

fixes #252

@iamareebjamal please test on device and review. Will be adding test later.

@iamareebjamal please review this.

@mejariamol There are no changes from the last time I reviewed it

@iamareebjamal Yeah. Initially I tried doing all the stuff in login itself but I couldn't manage synchronisation between database deletion -> actual login( starting MainActivity) . Please suggest an approach.

OK. Will do soon :+1:

I thought you were going to suggest another approach.

@mejariamol Please check and rewrite tests

@iamareebjamal please review

@mejariamol I must be really out of mind to forget that identity of the user is present in JWT token. Fix the tests, we'll merge this and I'll add parsing code and tests and send a separate PR

@iamareebjamal please review. :+1:

@Shailesh351 @arp95 @shreyasnbhat @rohanagarwal94 Please review


Update to 1.19.4

Seems to be working with same functionality as 1.19.3, I guess not much changed in resource or shader reloading in between 1.19.3 and 1.19.4

Thanks.


Azure plugin requires agent to be run under local administrator to read properties from C:\WindowsAzure

It's better to lift this restriction, I want to run agent under ordinary user

Now ARM uses Instance Metadata Service (#55) to receive configuration details and it does not more try to access C:\WindowsAzure directory.


ADD translation for 'Born' in pt-br

This PR contains:
A translation for a word in pt-br.
Describe the problem you have without this PR
when generating a resume in pt-br, the field with 'born' was generated in english, I've simply put a translation for born.

You should limit your PR to changes in the language file. You also committed all your personal resume data.


Error from STL Library

My C++ code contains Standard Library functions and I am having a trouble running CppSharp due to that.
On my header file, I have something like:
int testFunc(std::string x);
Then my C# code, I did similar as what the example did, include Library and header files with correct directory. After running the problem, I get errors like:
error CS0246: The type or namespace name 'std' could not be f
ound (are you missing a using directive or an assembly reference?)
error CS0208: Cannot take the address of, get the size of, or
declare a pointer to a managed type ('std.basic_string.Internal')
c:\Users
error CS1061: 'Std.String' does not contain a definition for
__Instance' and no extension method __Instance' accepting a first argument of
type 'Std.String' could be found (are you missing a using directive or an assem
bly reference?)
When I look at the .cs file, it generates to:
internal static extern int testFunc1_0(global::System.IntPtr instance, Std.String x);
I just downloaded the latest VS dlls (Nov 13th ver 423). I am also having similar error messages when I use stl , and others. Do I need to do some customization or something? How to make CppSharp recognizes my STL stuff? Thanks

@tritao @ddobrev I think we have fixed this one now. :)


Config no longer falsely loads profiles if file doesn't exist

As noticed by you, if the file doesn't exist one could do the first initialization with SHConfig("something") and break the whole damn thing.
I added a test that now the first init fails for any non-default profile (since no such profile exists).

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3c4501c) 91.93% compared to head (3c4501c) 91.93%.

:exclamation: Current head 3c4501c differs from pull request most recent head 8e4cc4f. Consider uploading reports for the commit 8e4cc4f to get more accurate results

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #486   +/-   ##
========================================
  Coverage    91.93%   91.93%
========================================
  Files           55       55
  Lines         4800     4800
========================================
  Hits          4413     4413
  Misses         387      387

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Looks good, thanks for fixing


Binding at runtime, Example Needed

In the section titled: Binding at runtime there is an nice discussion that you can do this but has not sample code to show how. The bullet item: "Pass in an input parameter Binder binder or IBinder binder." clearly indicates that the calling app MUST pass in something in the call. NOWHERE in this entire topic contains an example of calling a function with an Imperative binding. For most non-trivial use bindings should be passed in. If this is meant to be a generic type of object passed that is later passed to a binder, it would be interesting to know what is really the intent.  Full and complete end to end examples are needed with new and somewhat complex code.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7a4532b8-8c27-ca15-edc6-85fc38cab341
Version Independent ID: e06de78b-9271-25a4-439d-2a024f31693e
Content: Azure Functions C# developer reference
Content Source: articles/azure-functions/functions-dotnet-class-library.md
Service: azure-functions
GitHub Login: @ggailey777
Microsoft Alias: glenga

Hi @laultman Thank you for your feedback! We have review this feedback and assigned this issue to the author to investigate further and take the right course of action.

@laultman - Here's a sample that demonstrates how to do binding at runtime. I have it on my backlog to add a dedicated doc to discuss runtime binding specifically.

#reassign:craigshoemaker

The doc now has examples that show how to bind to a single attribute as well as multiple attributes.
#please-close


Use proto_library targets for skipping WKPs in C++ proto toolchains

This change migrates the proto_lang_toolchain targets to be compatible
with --incompatible_blacklisted_protos_requires_proto_info.
See https://github.com/bazelbuild/bazel/issues/11694

This seems incredibly fragile to future changes in the protobuf library's list of well known protos.


jfrog cli doesn't account for go mod replacements

If a dependency in the go.mod file has a replacement, the new path and version are ignored by the jfrog cli, and the old one is published instead.
You can see this clearly by adding a dependency without a hostname prefix:
module mycompany/projectA

require (
	mycompany/projectB v0.0.0
)

replace mycompany/projectB => gitlab.mycompany.com/mycompany/projectB v0.0.0-20181101000000-abcdefghi

This results in the following output when running jfrog rt go build go:
[Debug] The following file is missing<EMAIL_ADDRESS>
Because of this, the cli will always think that there are dependencies missing in go-local, and will therefore always attempt to download and publish them.

Thanks for the PR @darwish. This is much appreciated. I just wanted to let you know that this issue was already fixed with this PR #266 and this is the function in the code. CLI gets the dependencies values from the mod file directly.
This was already released with the latest CLI (version 1.22.0).
We will appreciate your feedback.

Thanks for the update. Glad the issue is resolved.


Standardize README shield badges

We want to update the README for all Dapr repos so they all include shield badges for YouTube, Discord, X/Twitter and ensure they are all in the same style. See: https://github.com/dapr/community/issues/355
These are the shield badges for the php-sdk repo.

Snippet to include in the README just below the title:
[![Build Status][actions-badge]][actions-url] [![License: Apache 2.0][license-badge]][license-url] [![Good First Issues][gfi-badge]][gfi-url] [![discord][discord-badge]][discord-url] [![YouTube][youtube-badge]][youtube-link] [![X/Twitter][x-badge]][x-link]

[license-badge]: https://img.shields.io/github/license/dapr/php-sdk?style=flat&label=License&logo=github
[license-url]: https://github.com/dapr/php-sdk/blob/master/LICENSE
[actions-badge]: https://img.shields.io/github/actions/workflow/status/dapr/php-sdk/.github%2Fworkflows%2Fphp.yml?branch=main&label=Build&logo=github
[actions-url]: https://github.com/dapr/php-sdk/actions/workflows/php.yml
[gfi-badge]:https://img.shields.io/github/issues-search/dapr/php-sdk?query=type%3Aissue%20is%3Aopen%20label%3A%22good%20first%20issue%22&label=Good%20first%20issues&style=flat&logo=github
[gfi-url]:https://github.com/dapr/php-sdk/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22
[discord-badge]: https://img.shields.io/discord/778680217417809931?label=Discord&style=flat&logo=discord
[discord-url]: http://bit.ly/dapr-discord
[youtube-badge]:https://img.shields.io/youtube/channel/views/UCtpSQ9BLB_3EXdWAUQYwnRA?style=flat&label=YouTube%20views&logo=youtube
[youtube-link]:https://youtube.com/@daprdev
[x-badge]:https://img.shields.io/twitter/follow/daprdev?logo=x&style=flat
[x-link]:https://twitter.com/daprdev

Contributing

Comment /assign on this issue if you want to self-assign this issue and update the README.
Don't forget to sign off your commit, for more details see Developer Certificate of Origin (DCO) in the docs.

@ maintainers: Please label this as good first issue.

/assign


Improve AVX2 encoding speed

Modified AVX2 enc_reshuffle function to use a blend instruction instead of 3 logical (2 * and, 1 * or) instructions. Also removes the need for 2 constants.
Speed-up on Intel(R) Core(TM) i7-4870HQ CPU @ 2.50GHz using Apple LLVM version 8.0.0 (clang-800.0.38)
AVX2: +8% compared to previous version
Full results before & after modifications follows.
Before:
Filling buffer with 10.0 MB of random data...
Testing with buffer size 10 MB, fastest of 100 * 1
AVX2    encode  7876.40 MB/sec
AVX2    decode  7047.91 MB/sec
plain   encode  1499.65 MB/sec
plain   decode  1557.21 MB/sec
SSSE3   encode  5612.09 MB/sec
SSSE3   decode  3883.52 MB/sec
Testing with buffer size 1 MB, fastest of 100 * 10
AVX2    encode  8970.38 MB/sec
AVX2    decode  7093.07 MB/sec
plain   encode  1501.03 MB/sec
plain   decode  1562.29 MB/sec
SSSE3   encode  5681.83 MB/sec
SSSE3   decode  3902.85 MB/sec
Testing with buffer size 100 KB, fastest of 100 * 100
AVX2    encode  9010.17 MB/sec
AVX2    decode  7036.27 MB/sec
plain   encode  1500.42 MB/sec
plain   decode  1561.01 MB/sec
SSSE3   encode  5698.98 MB/sec
SSSE3   decode  3901.21 MB/sec
Testing with buffer size 10 KB, fastest of 1000 * 100
AVX2    encode  8928.00 MB/sec
AVX2    decode  6923.62 MB/sec
plain   encode  1504.46 MB/sec
plain   decode  1558.74 MB/sec
SSSE3   encode  5672.21 MB/sec
SSSE3   decode  3912.51 MB/sec
Testing with buffer size 1 KB, fastest of 1000 * 1000
AVX2    encode  6726.56 MB/sec
AVX2    decode  5761.74 MB/sec
plain   encode  1420.93 MB/sec
plain   decode  1519.19 MB/sec
SSSE3   encode  5090.29 MB/sec
SSSE3   decode  3604.62 MB/sec

After:
Filling buffer with 10.0 MB of random data...
Testing with buffer size 10 MB, fastest of 100 * 1
AVX2	encode	8104.70 MB/sec
AVX2    decode  7047.91 MB/sec
plain   encode  1499.65 MB/sec
plain   decode  1557.21 MB/sec
SSSE3	encode	5612.09 MB/sec
SSSE3	decode	3883.52 MB/sec
Testing with buffer size 1 MB, fastest of 100 * 10
AVX2	encode	9691.90 MB/sec
AVX2    decode  7093.07 MB/sec
plain   encode  1501.03 MB/sec
plain   decode  1562.29 MB/sec
SSSE3	encode	5681.83 MB/sec
SSSE3	decode	3902.85 MB/sec
Testing with buffer size 100 KB, fastest of 100 * 100
AVX2	encode	9778.19 MB/sec
AVX2	decode	7072.35 MB/sec
plain   encode  1500.42 MB/sec
plain   decode  1561.01 MB/sec
SSSE3	encode	5698.98 MB/sec
SSSE3	decode	3901.21 MB/sec
Testing with buffer size 10 KB, fastest of 1000 * 100
AVX2	encode	9714.04 MB/sec
AVX2	decode	7018.01 MB/sec
plain   encode  1504.46 MB/sec
plain   decode  1558.74 MB/sec
SSSE3   encode  5672.21 MB/sec
SSSE3	decode	3918.76 MB/sec
Testing with buffer size 1 KB, fastest of 1000 * 1000
AVX2	encode	7165.17 MB/sec
AVX2	decode	5761.74 MB/sec
plain	encode	1420.93 MB/sec
plain   decode  1519.19 MB/sec
SSSE3   encode  5090.29 MB/sec
SSSE3	decode	3604.62 MB/sec

Merged, of course. Excellent work, thanks!


TypeError: Image.-init() got an unexpected keyword argument 'source'

help~

I have the same problem...

Hello, I think I solved the problem. You can refer to #80.

Hello, I think I solved the problem. You can refer to #80.
I've tried switching to 3.0.0 before and found it didn't work so I gave up, but it turns out it's still a version issue!
You're my hero. I fixed it. Thanks.

Hello, I think I solved the problem. You can refer to #80.

Now open the webui is no problem but after loading the image can not be generated, has been reading, cmd also no error report, and the gpu is running , accounted for about 10G video memory!

Hello, I think I solved the problem. You can refer to #80.

Now open the webui is no problem but after loading the image can not be generated, has been reading, cmd also no error report, and the gpu is running , accounted for about 10G video memory!

The method of replacing the gradio version is correct #80 . In versions ≥4.0 of gradio, it seems that the "source" parameter has been removed. However, there are some unknown issues with using version 3.24.0 in this demo, so you can use version 3.50.2 instead.
run:
pip install gradio==3.50.2

@tengfusion Thank you for your correction!


Discovering tests takes forever and doesn't give progress

Testing #119545
I know VS Code is big but this has been running for minutes:

Any indicator when you click to open the notification would be better than none, eg. <files checked>/<files discovered so far>

This is probably a bug in the selfhost provider not signalling completion for something...

It's still going 😉 if there was progress it would be clearer that it was stuck and not just taking a long time

How can you tell it's still going, is it still discovering files? Discovery and expanding any single file is nearly instant for me.

Still:

Oh, yea. I mean that is probably still shown because I forgot to report({ busy: false }) in the selfhost provider at some point🙂

I think this was probably a result of uncaught errors being thrown which aborted the promise before lack of business was reported. Let me know if this still happens in the next Insiders.


Jenkins add OSX build

Once this is working we can kill off circleci.

@dogmaphobic can you install the px4 development environment on gus-macpro?
https://dev.px4.io/en/setup/dev_env_mac.html
tl;dr
brew tap PX4/px4
brew install px4-dev
brew install px4-sim

Goodbye circleci.


Gateway API: Implement of GEP-995

We should translate the new name field to VS spec.route.name.
See https://github.com/kubernetes-sigs/gateway-api/pull/2985
We will need to wait until we pull in the new API version, though.

Does istio plan to support tcp and tls? I noticed they don't have a name field.


Setting target time generates error

What happened?
Change target time generates an onscreen error which appears very briefly bottom right see screenshot

To Reproduce
type any value in box nand move away
Expected behavior
A clear and concise description of what you expected to happen.
Log Output
Logger: homeassistant.components.websocket_api.http.connection
Source: components/websocket_api/commands.py:240
Integration: Home Assistant WebSocket API (documentation, issues)
First occurred: 14 February 2024 at 20:55:26 (9 occurrences)
Last logged: 19:14:55
[139865960401728] name 'current' is not defined
[139866127864256] name 'current' is not defined
[139866369697088] name 'current' is not defined
[139865774974656] name 'current' is not defined
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/components/websocket_api/commands.py", line 240, in handle_call_service
response = await hass.services.async_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2279, in async_call
response_data = await coro
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/core.py", line 2316, in _execute_service
return await target(service_call)
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 892, in entity_service_call
single_response = await _handle_entity_call(
^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/helpers/service.py", line 962, in _handle_entity_call
result = await task
^^^^^^^^^^
File "/usr/src/homeassistant/homeassistant/components/time/init.py", line 41, in _async_set_value
return await entity.async_set_value(service_call.data[ATTR_TIME])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/time.py", line 72, in async_set_value
await self._client.async_apply_session_rule(target_time=(int(value.hour), int(value.minute)))
File "/config/custom_components/ohme/api_client.py", line 222, in async_apply_session_rule
target_ts = int(time_next_occurs(
^^^^^^^^^^^^^^^^^
File "/config/custom_components/ohme/utils.py", line 177, in time_next_occurs
target = current.replace(hour=hour, minute=minute, second=0, microsecond=0)
^^^^^^^
NameError: name 'current' is not defined
Home Assistant Version
Core
2024.2.1
Supervisor
2024.01.1
Operating System
11.5
Frontend
20240207.1
Integration Version
0.7.0
Additional context
Add any other context about the problem here.

Looks like a line went missing in that file. Mind trying v0.7.1-beta.1?

No error mesages with this release , thank you

Released as stable v0.7.1


Enhancement:  Add QUIC transport

Hi @gdamore,
As per our earlier conversation on gitter, I am hereby submitting an RFE to include https://github.com/lthibault/quic-mangos as a transport in mangos.
As a reminder, external dependencies are:

https://github.com/SentimensRG/ctx (utilities around contexts;  small library also authored by me, which needs some love)
https://github.com/lucas-clemente/quic-go (QUIC implementation in pure go)

If, for whatever reason, we determine that quic-go should not be included, I'm hoping you might consider linking to it from the README, as it would be much appreciated.
Best,
Louis

@gdamore Have you had a chance to consider this RFE?  Anything I can do on my end?

Sorry, I've been busy.  I hope to get to it soon. :-)

I'll be working on this soon, but first I'll like to your experimental transport.  One thing we need to do is get an RFC written for this. :-)

@lthibault I've been going through your code, and trying to understand both QUIC and your details.  A few things are definitely missing, and an RFC seems to be pretty important as QUIC has the stream multiplexing capability.  You're using a path to identify different streams I think, but I'm right now trying to figure out how a client turns that URL into a destination.
The other stuff missing relates to handling of certificates, which seems to be really important with QUIC, and perhaps other TLS stuff.

@gdamore Re the TLS/QUIC configuration, that ought to be covered by https://github.com/lthibault/quic-mangos/issues/3, which will allow users to pass in instances of *tls.Config and *quic.Config.
Concerning the RFC, I've never had to write one before.  I'm happy to give it a whirl, but could definitely use some guidance. Do you have an example I could work from, or something to point me in the right direction?

Please have a look at the documents in https://github.com/nanomsg/rfcs - there are samples you can start from.  Probably you should start from the TLS RFC as a base.

Will do, thanks.

Hi, any progress?
After the release of version 1.4
cannot use quic.NewTransport() (type "github.com/go-mangos/mangos".Transport) as type "nanomsg.org/go-mangos".Transport in argument to sock.AddTransport:
	"github.com/go-mangos/mangos".Transport does not implement "nanomsg.org/go-mangos".Transport (wrong type for NewDialer method)
		have NewDialer(string, "github.com/go-mangos/mangos".Socket) ("github.com/go-mangos/mangos".PipeDialer, error)
		want NewDialer(string, "nanomsg.org/go-mangos".Socket) ("nanomsg.org/go-mangos".PipeDialer, error)

@nri-pl ,  I unfortunately have not had time to dig into this.  I'd very much welcome a PR, however.

This is just a need to update import paths. Sorry for the confusion.
On Fri, Jun 29, 2018, 3:49 AM Louis Thibault<EMAIL_ADDRESS>wrote:

@nri-pl https://github.com/nri-pl , I unfortunately have not had time
to dig into this. I'd very much welcome a PR, however.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/nanomsg/mangos/issues/308#issuecomment-401319855, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABPDfVhbZ20d8YcrBGWyj9Pa7fGjgIAyks5uBgYzgaJpZM4R4r80
.

@nri-pl Import paths have been fixed.  Should be working now.

I'm deferring integrating this into mangos until v2.  I am cleaning up the transport provider API in mangos v2, and then we'll do this properly.

Note that current work on mangos v2 is at github.com/nanomsg/mangos-v2 -- still experimental of course.

Understood — sounds good to me.

On Oct 19, 2018, at 04:40, gdamore<EMAIL_ADDRESS>wrote:
I'm deferring integrating this into mangos until v2. I am cleaning up the transport provider API in mangos v2, and then we'll do this properly.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/nanomsg/mangos/issues/308#issuecomment-431235219, or mute the thread https://github.com/notifications/unsubscribe-auth/AJA8EaAgKlfikPPIwruYQ_aAOhrMXwnAks5umUmQgaJpZM4R4r80.

Closing this here, we have the issue in mangos v2, and the link back.
Note that mangos v2 may still have some underpinning transport changes.  I don't really consider the underlying Transport API part of my committed interface yet.  That will change soon.


WIP: Using resnet50 to compute embeddings

See last section of #58.

Codecov Report

Merging #116 (8a092cb) into main (78193b2) will decrease coverage by 0.27%.
The diff coverage is 60.71%.

@@            Coverage Diff             @@
##             main     #116      +/-   ##
==========================================
- Coverage   79.32%   79.04%   -0.28%
==========================================
  Files          72       73       +1
  Lines        2389     2405      +16
  Branches      228      230       +2
==========================================
+ Hits         1895     1901       +6
- Misses        425      435      +10
  Partials       69       69

Impacted Files
Coverage Δ

towhee/engine/operator_loader.py
80.95% <0.00%> (ø)

towhee/engine/task_executor.py
94.11% <ø> (ø)

towhee/engine/__init__.py
33.33% <33.33%> (ø)

...ators/pytorch_cnn_operator/pytorch_cnn_operator.py
93.75% <100.00%> (+0.89%)
:arrow_up:

...owhee/tests/operators/test_pytorch_cnn_operator.py
90.47% <100.00%> (-0.44%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78193b2...8a092cb. Read the comment docs.


Breaking change in 0.28.0 - Rename of thing to actor

We went live with version 0.28.0 and unfortunately broke production for any pages which were using flipper groups. Due to this change:
https://github.com/jnunemaker/flipper/commit/3e4b5893#diff-aae41bf03cc259893c739aa855e16892b7c2a87608cc3c8e97908c2e6e08eeb1R9
We were registering a group in our initializer:
Flipper.register(:our_group) do |actor|
  actor.thing.is_a?(OurClassName)
end

We've fixed this by renaming but should we have expected this change? Given we are passed a Flipper::Types::Actor object to our block we wouldn't have expected public methods to change in a minor release.

@Geesu sorry to hear that. Our goal is definitely no outages. Pre-1.0 we consider any minor change a potential breaking change. I tried to note that in the changelog by saying "This likely breaks things for anyone using Flipper internal classes related to actors" but from what you are saying that wasn't clear enough.
I updated the changelog to this:
https://github.com/jnunemaker/flipper/commit/d33052c57b0666b0a3b2e7fd44ad1499d5af5547
Does that seem more clear?

Also worth noting that we are going to go 1.0 here very shortly and then bump major for stuff like this as a means of communicating more effectively.

@Geesu sorry to hear that. Our goal is definitely no outages. Pre-1.0 we consider any minor change a potential breaking change. I tried to note that in the changelog by saying "This likely breaks things for anyone using Flipper internal classes related to actors" but from what you are saying that wasn't clear enough.
I updated the changelog to this. Does that seem more clear? If not, any tips on improving that?

Yes that is great thanks!
The scary part is that code was in an initializer, so our tests couldn't exercise it. We've also moved it to a service object which is tested using the Actor object directly so it would be caught in the future.


addItem in App.test.tsx cannot be called with await

Despite being an async function, calling addItem with await will cause the tests to fail and the items to not be retrieved. However, omitting await works and the tests pass.

The issue appears to be needing to call act for any action that changes the state.
Commits:

https://github.com/johneastman/todo/commit/f48de853c5fdc16ab95daeb0ad1f9dc0c2fb261d


Reposting obs to FB not working

Sub-issue 1:
My iNat obs seemed to have stopped reposting to Facebook between August 15th and August 17th as shown by my activity feed:

Sub-issue 2:
When Reposting obs to FB was working, it only appeared in my 'recent activity' as shown here:

But it never posted to my wall as apps like Project Noah do:

This is the behavior I was expecting when I chose to automatically share my postings on FB
Sub-issue 3:
Currently, if I sign in with Facebook and opt-out of 'iNaturalist would like to post to Facebook for you.' permissions the 'Automatically share your observations on FB' checkboxes on Account and Obs/New are checked which is confusing. Might be better to uncheck those boxes if iNat doesn't have post permissions for that user, and if the user tries to check them, first direct them to a link to give iNat those permissions before allowing the boxes to be checked

still broken - ugh FB...

Some part of this appears to be working. If I go here: https://apps.facebook.com/inaturalist/?ref=br_tf
I see many observations submitted today, including the bee on the cosmos submitted by me, but I can't see it anywhere on my own page. I also can't make iNaturalist appear in the "apps and games" section of my profile (it doesn't show up as a result in search)

thats different Carrie - the bug I mentioned is the functionality that reposted obs into your FB activity feed

Ok that definitely doesn't work.

#783 - decided not to fix this


Simplify eslint configuration

We should be able to simplify our .eslintrc by providing a shareable configuration or maybe by reusing parts of xo configuration. (maybe we should create a eslint-config-yeoman repo if it makes sense)

I think https://github.com/sindresorhus/eslint-config-xo-space is pretty close to the Yeoman style (whatever that is). I'm sure we can come to a concordance.

FWIW I ran xo yesterday on yeoman-generator so see how far we were, and it came up with a lot of errors. So we're not totally there (I'm all in with making our core stricter, but some rules weren't applying very well).

Since ESLint v1.0.0 we can extend 'eslint:recommended' to simplify configuration.

FYI, I create a repo eslint-config-yeoman.
Maybe yo node:eslint should just add devDep eslint-config-yeoman

@zckrs PR away :)
We were also thinking of maybe basing ourselves on xo eslint config with some manual overwrites.

We were also thinking of maybe basing ourselves on xo eslint config with some manual overwrites.

The Yeoman style is pretty close to XO, so that would be a good idea. https://github.com/sindresorhus/eslint-config-xo-space

Summary result with 'eslint-config-xo-space'.

Should we apply ?

https://github.com/yeoman/generator-node/pull/198


removing gitops flag and making gitops enabled based on cd

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Don't throw on action run if pack config file is empty (aka contains no values)

This pull request fixes a bug which would result in ConfigLoader throwing an exception when running an action if there was a PackConfig object in the database for a particular pack, but the field values was empty / not set (aka there is a empty pack config with no content on disk inside /opt/stackstorm/pack/configs/).
I found this issue while trying to run some benchmarks against our k8s cluster:
2018-08-31 10:59:42,103 ERROR [-] Failed to run action.
Traceback (most recent call last):
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2actions/container/base.py", line 106, in _do_run
    runner.liveaction.context)
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/util/param.py", line 309, in render_final_params
    config = get_config(action_context.get('pack'), action_context.get('user'))
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/util/config_loader.py", line 235, in get_config
    config = config_loader.get_config()
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/util/config_loader.py", line 83, in get_config
    config_db=config_db)
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/util/config_loader.py", line 95, in _get_values_for_config
    config = self._assign_dynamic_config_values(schema=schema_values, config=config)
  File "/opt/stackstorm/st2/local/lib/python2.7/site-packages/st2common/util/config_loader.py", line 115, in _assign_dynamic_config_values
    iterator = six.iteritems(config) if config_is_dict else enumerate(config)
TypeError: 'NoneType' object is not iterable
2018-08-31 10:59:42,123 INFO [-] st2.k8s-dev.action.executions.running: -1
2018-08-31 10:59:42,124 INFO [-] st2.k8s-dev.action.executions.failed: 1

rs0:PRIMARY> db.config_d_b.find()
{ "_id" : ObjectId("5b76ce38755f3f00011bb04d"), "pack" : "core" }

@nmaludy ^ just a heads up (enumerate() on None would fail and if we had no test case for such scenario).


Refactor code generation for Kubeflow Pipelines

Is your feature request related to a problem? Please describe.

Refactor the Kubeflow Pipelines processor to generate Python DSL as intermediary output format
Expose the generated DSL in the export wizard in addition to the already support static configuration file (YAML)

Additional context

The changes have no impact on regular users because the changes are completely transparent.
Advanced users will be able to customize the generated Python DSL, if desired.
With these changes in place, support for pipeline parameters can be added.

Exposing the kubeflow inout parameters for a component is highly desirable, so pipelines can be hooked into AutoML, I think even a simpler approach would be to expose add support for populating a component parameter inputs from kubeflow itself, just like we have a dropdown today for "put a string, read file, read output" we should have a "read from kubeflow" or similar

Perhaps I am misunderstanding your comment, but pipeline parameters will enable users to do that, as outlined here. The motivation section in the linked doc includes a screen capture of how pipeline parameters are exposed in the Kubeflow Central dashboard.


Determine whether hellbender + latest htsjdk will transparently support CRAM files, or whether code changes are needed

It's possible that hellbender (with the latest htsjdk) will transparently work with CRAM (as opposed to BAM/SAM) files via the SAMReader interface, with no code changes required. Let's find out whether that is the case, and if it's not, identify (but do not implement yet) the kinds of changes that will be required to support CRAM files.

This is a prerequisite for https://github.com/broadinstitute/hellbender/issues/590


About watch interface redefine

I test the latest code, watch callback have been deprecated, now we need use watcher.listen to retrieve the watch event. But I need to get watch event by passive,  asynchronous way as the same as watch callback . so is there such mechanism for the latest code?

@Hubery2757 I wonder why do you want to have a passive and asynchronous way of getting watch event? Why wouldn't  watcher.listen do the job for you? the reason to remove the callback is to make watch simpler to use and easier to reason about.

A callback mechanism can be built on top of what's there now. Why does the client need to implement it?

we might add an async helper in the future if there are more and more people wanting it. but for now, we are not going to do it.

@fanminshi I think the passive event notification event it is better and it is needed to many scenarios.
watcher.listen will block the main thread. Anyway like @heyitsanthony  said we can build a callback mechanism on top watcher.listen.

@jalenyang can you provide few scenarios that pass even would help?

@fanminshi one simple example is the auto service discovery.
I.E.  application A watch with the prefix app/services, if there is one new service registered(e.g. app/services/Service B) and the application A has some dependencies on Service B, then application B should be able to receive an asynchronous notification and start the business.

@jalenyang I understand the use case.  However, the question I am having is why is   asynchronous notification prefer over synchronous one? Wouldn't synchronous notification achieves what you want as well?

@fanminshi well, one example is when the application startup it will watch the configuration changes.
we don't want the main thread was blocked by the synchronous  watch. Also, we need to persistent monitoring the changes of the configuration in etcd.  That means we need to implement the asynchronous  watch ourselves with watcher.listen.  Surely, we can implement it base on your current design, but why did remove it while the asynchronous   watcher had already been implemented in the previous version? One more thing, the API of the etcd endpoint is asynchronous , so why the client doesn't support
asynchronous   API?  It doesn't make sense.

Although it is is possible to achieve an async notification by wrapping the synchronous one, I think every functionality should be asynchronous first.
Now briefly looking at the code I see that as today a call to listen() submit a new task to a single threaded  executor which creates a Future we blocks on, then one eventually needs to create an additional thread/executor to make watch asynchronous again which seems to me a little expensive.

why did remove it while the asynchronous watcher had already been implemented in the previous version?
The previous asynchronous version doesn't have correct behavior as the etcd go client and its callback definition was confusing; it has something called onResuming which is hard to reason about what to do with it. I rewrote the watch api to match the synchronous nature of the go client which I think is much simpler to reason about.
The asynchronous watch api seems reasonable. I'll add it into future jetcd release.

+1 for an asynchronous watch api

I was also thrown off by this. Either an asynchronous API or an example of turning the synchronous one into an asynchronous one (without spinning the CPU against the thread or polling?) would be great.


Fix dependency issue in next

Description
Fixing some dependency related issue in next, likely due to a bad merge from main.

I incorporated these in my merge fixup in #15381 I think - up to you if you want to merge this separately or wait for that one to go in?

I incorporated these in my merge fixup in #15381 I think - up to you if you want to merge this separately or wait for that one to go in?

@ChumpChief i'd rather not wait on the merge if it won't happen very soon, as next is broken.


Mapped the missing fields in HeldItemRenderer

Tiny PR for some fields I happened upon by chance.
field_21807 -> MAP_BACKGROUND
field_21808 -> MAP_BACKGROUND_CHECKERBOARD
MAP_BACKGROUND = RenderLayer.getText(new Identifier("textures/map/map_background.png"));
MAP_BACKGROUND_CHECKERBOARD = RenderLayer.getText(new Identifier("textures/map/map_background_checkerboard.png"));

Updated to 1.15.1-pre1

call it a layer?

@liach I would have, except I saw places where existing mappings were leaving it out.


No way to quickly hide and then show terminal with it already focused

Check for existing issues

[X] Completed

Describe the feature
So I totally miss the simple, no fuss ctrl-` to quickly hide/show terminal in VS Code.
In Zed, ctrl-` creates a terminal when there's none, and toggles focus back and forth between panels when a terminal exists. Used to be, we can at least use shift-esc to hide/show terminal, but that's changed to maximizing panel with the new panel system too.
Now, there's a new cmd-J to toggle the bottom panel, but with one glaring downside (not sure if bug or feature) — when toggled, it just shows up but doesn't gets focused! So I have to cmd-J and ctrl-` now in order to show the terminal and focus it. Total productivity killer.
I think the most logical fix is to make bottom panel automatically focused when toggled? (Now that I think of it I should probably have filled this a bug instead of enhancement. Oh well.)
If applicable, add mockups / screenshots to help present your vision of the feature
No response

This seems right, I think maybe we can make the two actions (cmd-j, ctrl-`) identical then.

Not really the same issue...
I move the terminal quite a lot based on the window size.
I can use the same key to show/hide the terminal whether the terminal is placed bottom/right/expanded before the new panel system. Now I have to use different keys/commands to hide it.

Yeah I think it'd be great to toggle and get focused within one key :-)

So I found out that clicking the terminal button in the bottom toolbar works as expected, and the tooltip reveals that to get this behavior via keyboard, you need to:

cmd+J to hide bottom panel
cmd+` to focus terminal (no need to cmd+J to show bottom panel first)

Wish I could just toggle it with the same shortcut.

Yeah, would love if I could get cmd+` to show (and focus) and hide the terminal, not toggle it focused/unfocused.

I think it's fixed on v0.92.3, currently it works fine for me!

Good catch :D Yes, this should be fixed now.


front page

http://prntscr.com/7pp04d
the writing isnt legible anymore, try black colour font

That's from when I updated the picture for #37, I guess I didn't make it light enough. But the font really should match the flasks anyway. I won't do that today, but I'll make that happen as soon as possible

I fixed this along with #61


Use via es6 import

I would like to use it like
import categorizr from 'categorizr';
or
const categorizr = require( 'categorizr' );
when installed via NPM.
But I always get told that I'm on mobile.
After some investigation I noticed that the context is an Empty Object and not window.
Known issue or did I make something wrong?

Not known, but this project isn’t maintained. What bundler are you using? I’d guess that the modules this property is being set/wiped out in an odd way by your bundler. This is using a UMD pattern for exporting itself which may be outdated or incorrect now.

Oh snap! I use webpack. So better search for an alternative?

Idk, I’d start off just following that trail a little bit further to see how webpack loads it and probably just configuring it accordingly. Alternatively a PR for updating the export method would be okay, too.


String array type value

https://github.com/spf13/pflag/blob/master/string_array.go

Implementing this type does not make any sense in case of environment variables, since only one variable can be defined. The String slice type value can be used to provide comma separated values.
Leaving this issue open for now to decide whether a transparent fallback would make sense or not.


Nuget pkgs disappearing?

We're referencing System.Buffers | 4.0.0-rc2-23623 and recently our builds started failing with a 404 from the myget servers. Is the team actually removing nuget pkgs from the repo? If so, is there any communication as to what consumers should do?
Thanks.

Packages are always removed from myget servers. You cannot rely on them for stable builds. You should be using nuget.org or mirroring packages if you need builds to stay around forever.

@bc3tech we currently keep about 5 - 10 builds of every package on the aspnetvnext feed, which has our "nightly" builds. This has been the behavior for the last few years. Otherwise the feed would take up terabytes of space.

thanks for the insight, guys! 👍

Nope


BENCH/DEV: Add conda-build to environment.yml

Is your feature request related to a problem? Please describe.
I'm unable to use the mamba command when running the benchmark suite. Please see the warning message in the additional context section.
Describe the solution you'd like.
Add conda-build to the environment.yml  so that we can build the benchmarking suite without warnings
Describe alternatives you've considered.
Leave it as is, this could lead to issues later on. However, it looks like the tool falls back to conda, so it's not a significant issue at the moment.
Additional context (e.g. screenshots, GIFs)
(scipy-dev) kai@kai-MS-7D32:~/Projects/scipy$ python dev.py bench -t sparse_csgraph_dijkstra
💻  ninja -C /home/kai/Projects/scipy/build -j16
ninja: Entering directory `/home/kai/Projects/scipy/build'
[2/2] Generating scipy/generate-version with a custom command
Build OK
💻  meson install -C build --only-changed --tags runtime,python-runtime,tests,devel
Installing, see meson-install.log...
Installation OK
SciPy from development installed path at: /home/kai/Projects/scipy/build-install/lib/python3.12/site-packages
Running benchmarks for Scipy version 1.15.0.dev0+903.9406182 at /home/kai/Projects/scipy/build-install/lib/python3.12/site-packages/scipy
Couldn't load asv.plugins._mamba_helpers because
No module named 'libmambapy'
· Unknown environment type 'mamba'. Allowed values based on existing plugins are ['existing', 'conda', 'virtualenv']. If you are trying to use `mamba`, you may need to install `conda-build`.

Yeah, I wrote this error message for asv :) nice to see it has already been helpful!
Let's fix this as part of gh-21374.


Add pygmentize as dependency

I added pygementize as a dependency. This allows me (and others) to use minted listings.

Thanks!


[flaky CI]Creating a VirtualMachineInstance [Serial]with node tainted [test_id:1635]the vmi with tolerations should be scheduled

/kind bug
/triage build-watcher
Failed here:
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4816/pull-kubevirt-e2e-k8s-1.17/1351033626933858304
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4816/pull-kubevirt-e2e-k8s-1.17/1350792286249684992
https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4808/pull-kubevirt-e2e-k8s-1.17/1350662934186954752
Possibly related to #4715 because these two tests always fail together.

Happened again: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4850/pull-kubevirt-e2e-k8s-1.19/1353678682610208768

Happened again: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4850/pull-kubevirt-e2e-k8s-1.19/1353678682610208768

Happened again: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4885/pull-kubevirt-e2e-k8s-1.17/1353717697505923072

Happened again: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4885/pull-kubevirt-e2e-k8s-1.17/1353717697505923072

https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4552/pull-kubevirt-e2e-k8s-1.17/1357472429475106816

https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/logs/periodic-kubevirt-e2e-k8s-prev/1359442157462622208 happened together with test_id:1634

Potentially fixed by #5035

Potentially fixed by #5035

Happened again: https://prow.apps.ovirt.org/view/gcs/kubevirt-prow/pr-logs/pull/kubevirt_kubevirt/4387/pull-kubevirt-e2e-k8s-cnao-1.19/1365490827337404416
/reopen

/close
Duplicate of #4720

Ups, that was the wrong bug, I clicked the wrong in the list.

/reopen


YASGUI: add predefined prefixes

YASGUI was implemented in #40
Some features would be very helpful for users:
Add predefined prefixes:
Could be implemented by changing the settings object, as stated in the documentation https://yasqe.yasgui.org/doc/
yasqe.addPrefixes(prefixes: object) Add prefixes to the query. The prefixes are defined as {"rdf: "http://www.w3.org/1999/02/22-rdf-syntax-ns#"}
We could predefine:
PREFIX rdfs: <http://www.w3.org/2000/01/rdf-schema#>
PREFIX wdt: <http://www.wikidata.org/prop/direct/>
PREFIX wd: <http://www.wikidata.org/entity/>
PREFIX owl: <http://www.w3.org/2002/07/owl#>
PREFIX dc: <http://purl.org/dc/elements/1.1/>
PREFIX dracon: <http://dracor.org/ontology#> ```

In 4e63793 I added the prefixes mentioned above to the default query that's shown when you initially load YASGUI or when you open above. The yasqe.addPrefixes method seems to do exactly that programatically for an individual query editor, while I added it to the YASQE.defaults.value in the initial configuration. @ingoboerner: is that what you had in mind?


Handle the bucket file in components library

This is part of best practices and UI components rework, when the UI component is moved to its own library.

Creating a file that store the components export is fine in /learn, because of bundlers handling tree shaking.
Bundlers can't do tree shaking with external libraries, it doesn't apply in runtime.
There are multiple ways to handle them:

implement the components similar to radix
bundle the library together with the application code
move to next 14

can I work on this issue?


Fixed parsing behavior for single word ingredients/cookware followed by punctuation

Presently punctuation is included into single word ingredients/cookware such as Add @milk. Stir.
I brought the tokens in line with the EBNF to exclude unicode categories Zs and P, and tabulation character. I believe \s can be removed from the regex but I didn't want to create side-effects I wasn't aware of.
I included a test for cookware and ingredients with punctuation.

Thanks for contributing!


Adding a new benchmark, cleaning up benchmark README

Adding a benchmark with latest node (2.3.1) and latest bluebird (2.9.30).
Restructuring README to be easier to understand.

Benchmarks will be updated on the website with the 3.0 release


MINOR: update Kafka Streams docs with 3.3 KIP information

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

Merged to trunk and cherry-picked to 3.8 and all the way back to 3.3.


Scripts starting #!/bin/ash not detected as shell filetype

The regex that detects the hashbang should be improved to include 'ash' as well as 'bash', so that Ash scripts are highlighted by default too.
https://github.com/zyedidia/micro/blob/6140dabca8193a6bb3afaf8e28235bee6366e800/runtime/syntax/sh.yaml#L5

https://github.com/zyedidia/micro/pull/1173


KAFKA-8736: Track size in InMemoryKeyValueStore

InMemoryKeyValueStore uses ConcurrentSkipListMap#size which takes linear time as it iterates over the entire map. We should just track size ourselves for approximateNumEntries
Should be cherry-picked back to 2.3

@guozhangwang @mjsax @vvcephei @abbccdda @cadonna

Should we target this to the same ticket that reported the regression (even if this is not a regression as the store was newly added)?

Yeah, although we weren't really guarding against that with the earlier TreeMap. I think it's reasonable to put that check on the user (unless we're concerned it might grow so large/fast it would wrap around to positive again and they'd miss it. Which seems...highly unlikely)

Java 11/12 failed with
org.apache.kafka.connect.integration.ExampleConnectIntegrationTest.testSourceConnector
org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testReconfigConnector
kafka.server.DescribeLogDirsRequestTest.testDescribeLogDirsRequest
Java 8 failed with
kafka.api.DelegationTokenEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl
kafka.server.DescribeLogDirsRequestTest.testDescribeLogDirsRequest
Java 11/13 passed, retest this please

Java 8: kafka.server.DescribeLogDirsRequestTest.testDescribeLogDirsRequest
Java 11 / 2.13:
kafka.server.DescribeLogDirsRequestTest.testDescribeLogDirsRequest
org.apache.kafka.connect.integration.RebalanceSourceConnectorsIntegrationTest.testReconfigConnector

Java 11 / 2.11 kafka.server.DescribeLogDirsRequestTest.testDescribeLogDirsRequest
No 3 clean runs for kafka.server.DescribeLogDirsRequestTest.testDescribeLogDirsRequest yet.
Retest this please.

Java 11 / 2.12 failed with testDescribeLogDirsRequest (already fixed).
Java 11 / 2.13 timed out.
Java 8: TopicCommandWithAdminClientTest.testDescribeReportOverriddenConfigs
@ableegoldman Can you rebase this PR to get the fix for testDescribeLogDirsRequest?

Java 11 / 2.12: SaslOAuthBearerSslEndToEndAuthorizationTest.testNoDescribeProduceOrConsumeWithoutTopicDescribeAcl
Java 11 / 2.13 and Java8 passed.
Retest this please.

Java 11/12 passed, Java 11/13 failed with one failure, Java 8 failed with 0 failures (??). Test results no longer available, retest this, please

Java 11/2.13 passed in one run and Java 11/2.11 passed in another Java 8 passed so merging this.

Merged #7177 into trunk

cherry-picked to 2.3


MySql storage support

This commit adds support of MySql as rbac storage.
Notes on Test:
Please pre-create mysql database 'rbac' to run the tests on development machine

Hello @seeden
I have implementd MySql storage implementation, and added it for the testing flow as well. It passes test cases and travis checks. Please merge.
Thanks

Hi @rajan-goswami. Thank you for this driver. I will release new version but I am on vacation in this moment.

Hello @seeden,
If you are back from vacation, can you please release new version. So that we can use this library from npm repo.
Thanks

Hey @seeden
Waiting for new release with mysql storage.
Thanks

That would be great.

This project have supported mysql storage, please provide some sample about it ?


Disable user tracking via Crooked Style Sheets

https://github.com/jbtronics/CrookedStyleSheets

I assume this is a better repo than https://github.com/brave/browser-laptop/issues/12735 ?

Also related: https://www.mike-gualtieri.com/posts/stealing-data-with-css-attack-and-defense

This issue now lives at brave/brave-browser#818 .


Added get_orders_paged

get_orders only returns the first 50 orders - this allows you to specify which page of 50 orders to retrieve


Fix/underline for link icons

Duplicate of https://github.com/primer/view_components/pull/3041 that I created to be able to run our visual regression tests. Please do not merge.

I think this can be closed as the original PR has been merged.


Bugfix | DAIR-2552

@misterwell @cshireman

DAIR-2552  iOS: Order: Recent and Favorites tabs will be filled out and unreadable

Sorry it was generated by mistake its support to for our fork.


Support no-std targets

Fixes https://github.com/RalfJung/cargo-careful/issues/19.
This implements approach 3 from https://github.com/RalfJung/cargo-careful/issues/19.

Code looks good, thanks!
Is it possible to have a test for this?

I'll look into creating a test. 👍
Note that CI fails due to new nightly lints. If you want me to, I can apply those fixes too.

Thanks, CI looks good. :)


Add webhook to allowlist pools

Description
This adds a webhook so that we can create a pool allowlist request when new pool create transactions come in. These transaction notifications come from Hal.xyz and are sent to a lambda on the Balancer API that then calls this webhook with the correct parameters.
I've made the allowlist code more generic so it can be called from either the manual workflow or the automatic one.
Type of change

[x] New feature (non-breaking change which adds functionality)

How should this be tested?

This can be manually tested with curl by forking this repo, creating a personal access token with webhook request, and running the following replacing myGithubPatToken with your token, and timjrobinson with your github username:

curl -X POST -H "Authorization: token myGithubPatToken" https://api.github.com/repos/timjrobinson/frontend-v2/dispatches --data '{"event_type": "allowlist_pool", "client_payload": { "network": "polygon", "poolType": "Weighted", "poolId": "0x8f4205e1604133d1875a3e771ae7e4f2b0865639000200000000000000000111", "poolDescription": "boop" }}'`

This is the format that requests from the API will use.
Checklist:

[x] I have performed a self-review of my own code
[x] I have requested at least 1 review (If the PR is significant enough, use best judgement here)
[x] I have commented my code where relevant, particularly in hard-to-understand areas
[x] If package-lock.json has changes, it was intentional.
[x] The base of this PR is master if hotfix, develop if not

The Balancer API Lambda has been merged (https://github.com/balancer/balancer-api/pull/218) and is working with my personal fork of this repo (https://github.com/timjrobinson/frontend-v2/actions/runs/5332069319) so this is ready to merge now.


Update circle ci config file to best practices

Use latest best-practices CircleCI config file from swatchjs repo. Uses a shared 'org-global' context for the publish step to share NPM credentials.

Codecov Report

Merging #5 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%
=====================================
  Files           5      5
  Lines          29     29
=====================================
  Hits           29     29

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c56c653...da00420. Read the comment docs.


Updates with Groups in Canvas not showing

Description: The only fields related to Canvas available is Updates with links in Canvas, and it works fine. But for some reason Updates with Groups in Canvas field does not appear.
Honestly, I won't use this feature too often, so if the problem is only with the selection menu, it would be enough if there is a way to manually set the field to Group Canvas (maybe by editing a file)
OS: Pop!_OS 22.04 LTS x
Obsidian: deb version

Hi, is there any error message in the console?

I don't really know how to use the console, but I filtered with metadata. Is this enough?

What is your version of obsidian and your version of metadata menu?

I've updated the version mapping between the plugin and obsidian. Could you try to update the plugin  (you should get v0.5.1)?

It worked. Thank you so much, your plugin is one of the most useful I've been using.


Specify that each chunk must include one full notification.

This should streamline the processing of the stream by the client and parsing notifications.

I think streaming text/turtle should be pretty straight forward. For application/ld+json we might want to reference https://www.w3.org/TR/json-ld11-streaming/

From what I have read, I don't think using text/turtle conforms to HTTP specifications. What you are streaming are multiple instances of text/turtle and you would thus require something like multipart/mixed.
I don't know much about it myself, and hence was asking around for an expert on the subject for guidance.
References:

https://www.rfc-editor.org/rfc/rfc2049#page-15
https://www.w3.org/Protocols/rfc1341/7_2_Multipart.html
https://www.rfc-editor.org/rfc/rfc9110.html#name-multipart-types

Ok, if you want to do the text/turtle, I believe that there is a proper way to set headers for that as well, except I don't know how.
However, I don't want to discard the multipart/* approach either (at least for now) because we might also want to support diffs which might not play as nicely.

@elf-pavlik FYI: https://www.ietf.org/rfc/rfc2387

AFAIK in turtle prefixes can appear anywhere as long they are defined before they get used, which means that concatenating multiple text/turtle documents will still be valid text/turtle.

Yes, that is correct. PREFIX or @prefix lines may appear anywhere in a Turtle document, and affect all following lines.
It's probably also worth noting that a later PREFIX declaration may change a previous declaration for subsequent triples — i.e., an early PREFIX ex: <https://example.com/#> which is active for some number of triples may be changed by a later @prefix ex: <https://example.org/#> . which is then active for following triples, until either the end of the document or another PREFIX ex: <URL> declaration.


Modernize repository and testing environment

Hi there,
following up on the CI hiccups revealed through #30, I've slightly modernized the testing environment within this repository.

Use more recent CrateDB version 4.3.2
Replace Travis CI by GitHub Actions
Add testing for more recent Ruby 2.7 and 3.0
Drop testing for older Ruby 2.0, 2.1 and 2.2
Make testing work on macOS
Fix executable permissions on "java" bundled with recent CrateDB
Enable CI testing for macOS
Update test framework to rspec 3.10
Add Gemfile.lock to repository
Rename "history.txt" to "CHANGES.rst"
Update development documentation

With kind regards,
Andreas.

@seut: Thanks for the review, I will address your comments.

also here I'm not sure if we should lock the libraries (Gemfile.lock)

Thanks for asking. I've elaborated a bit on that topic at https://github.com/crate/crate-dbal/pull/98#pullrequestreview-566171196.

@seut: Thanks for the review, I will address your comments.

also here I'm not sure if we should lock the libraries (Gemfile.lock)

Thanks for asking. I've elaborated a bit on that topic at https://github.com/crate/crate-dbal/pull/98#pullrequestreview-566171196.


aur-build: use libmakepkg for packagelist

Basic performance comparison on a low-performance VM:
[archie@vbox makepkg]$ time makepkg --packagelist
/home/archie/projects/aurutils/makepkg/aurutils-git-3.0.0rc.r7.gc91de35-1-any.pkg.tar.zst

real    0m2.412s
user    0m1.766s
sys     0m0.580s

[archie@vbox makepkg]$ time ../makepkg-fast --packagelist
/home/archie/projects/aurutils/makepkg/aurutils-git-3.0.0rc.r7.gc91de35-1-any.pkg.tar.zst

real    0m0.064s
user    0m0.051s
sys     0m0.008s

Where makepkg-fast is a script using libmakepkg/util/pkgbuild.sh print_all_package_names() directly if called with --packagelist.

A possible issue is that the PKGBUILD is not linted if the build is skipped due to matching version in the local repository. In this specific case, lint_pkgbuild could be called (which apparently is a cause for the slow-down above).

I've been thinking on this some more, and the only scenario I can see regarding unlinted PKGBUILDs is (practically speaking) when a package was built with an older version of makepkg, and the PKGBUILD is no longer valid with a newer version of makepkg. In that case, the version from print_all_package_names would still be correct; the package would just need adaptations to build again with the newer makepkg version.
Maybe there's other possible scenarios, but for now I think it's a reasonable idea.


Clean up DeviceInternals

and some cosmetics. Addresses

https://github.com/chainer/chainer/pull/6820#discussion_r273831592
https://github.com/chainer/chainer/pull/6820#discussion_r273832130

Jenkins, test this please

Jenkins CI test (for commit 93089cf503f7f03bc9d935111bf5f5bba7d5f2ce, target branch master) failed with status FAILURE.

LGTM


Deleting Certificates should be an LRO

Since DeleteCertificate can take a while to actually work (i.e. the method returns, but the operation doesn't complete right away), we should change this to a long-running operation, but should probably call it StartDeleteCertificate. This name does mean we could do it later if decided across languages.

Note also this is across all clients, including SecretClient, KeyClient, and CertificateClient.


[1pt] Create Label class with methods - Mike

Create a Label class with an association to the Item class (in a separate .rb file).

All Label class properties visible in the diagram should be defined and set up in the constructor method.

Implement methods:

add_item method in the Label class

should take an instance of the Item class as an input
should add the input item to the collection of items
should add self as a property of the item object (by using the correct setter from the item object)

PR https://github.com/mikemtzp/Catalog-of-my-things/pull/33


[OAP-1441] [POAE7-349] change com.intel.spark to org.apache.spark in oap-spark

Parent pom.xml also need modify spark.internal.version

Parent pom.xml also need modify spark.internal.version

I've already remove it in this PR. Currently this property occurs across the modules. We can unified it in parent pom.xml later.


Add helper to select events from one category

It would be nice to have some helper function that automatically selects events given a config category based on an existing category_idscolumn.
masked_events = columnflow.columnar_util.select_category(events, config.get_category("1e"))

This should automatically select all events that contain a category id of one of the "1e" leaf categories.

+1


[Dubbo-SPI] Spring spi support inject by type

What is the purpose of the change
also see #1456 .
Spring spi support inject by type. Not necessary to support spring 2.5 or lower.
Brief changelog
SpringExtensionFactory:

getBean by name
getBean by type

Verifying this change
SpringExtensionFactoryTest
Follow this checklist to help us incorporate your contribution quickly and easily:

[x] Make sure there is a GITHUB_issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
[x] Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
[x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
[x] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
[x] Run mvn clean install -DskipTests & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
[x] If this contribution is large, please follow the Software Donation Guide.

Codecov Report

Merging #1837 into master will increase coverage by <.01%.
The diff coverage is 92.3%.

@@             Coverage Diff              @@
##             master    #1837      +/-   ##
============================================
+ Coverage     40.46%   40.46%   +<.01%
- Complexity     4418     4419       +1
============================================
  Files           628      628
  Lines         30083    30097      +14
  Branches       5320     5322       +2
============================================
+ Hits          12172    12178       +6
- Misses        15989    15993       +4
- Partials       1922     1926       +4

Impacted Files
Coverage Δ
Complexity Δ

...onfig/spring/extension/SpringExtensionFactory.java
84.61% <92.3%> (+46.15%)
8 <2> (+4)
:arrow_up:

...a/dubbo/remoting/transport/netty/NettyChannel.java
57.5% <0%> (-8.75%)
19% <0%> (-2%)

...ba/dubbo/remoting/transport/netty/NettyClient.java
74.13% <0%> (-8.63%)
12% <0%> (-1%)

...bo/remoting/transport/netty/NettyCodecAdapter.java
53.12% <0%> (-1.57%)
3% <0%> (ø)

...a/dubbo/registry/integration/RegistryProtocol.java
0% <0%> (ø)
0% <0%> (ø)
:arrow_down:

.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java
89.71% <0%> (+1.86%)
15% <0%> (ø)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300f9c9...7a718f6. Read the comment docs.


Add shadow-style attribute - #28

Add shadow-style - new attribute to declaratively inject styles to shadow DOM,
add test case for custom Ace themes
fixes #28

I covered most of your comments, but I'd leave shadowStyles feature for future, as we do not support any other properties (except value). WDYT?

I agree with ergonomics of properties and object refs, but let's do it once we need it. And move with this one sooner.


Update README.md

cmake is needed, so pip doesn't need to download and install its own version (slow!) cannot upgrade pip in termux as of today

why you remove "pip install --upgrade pip". can you explain more


Numa fix and fim dependency

Return Numa information only when available.
pick fabric-cli with latest fim

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

1 of 5 (20.0%)  changed or added relevant lines in 3 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.02%) to 19.745%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

fabrictestbed_extensions/fablib/component.py
0
2
0.0%

fabrictestbed_extensions/fablib/interface.py
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
-0.02%

Covered Lines:
870

Relevant Lines:
3937

💛  - Coveralls


liquibase issues

So as originally reported
Then I got an error from liquibase
Unable to resolve xml entity /META-INF/dbchangelog-3.9.xsd. liquibase.secureParsing is set to 'true' which does not allow remote lookups. Check for spelling or capitalization errors and missing extensions such as liquibase-commercial in your XSD definition. Or, set it to 'false' to allow remote lookups of xsd files.

It turned out that in liquibase.parser.core.xml.LiquibaseEntityResolver.resolveEntity(String name, String publicId, String baseURI, String systemId) systemId was being set to /META-INF/dbchangelog-3.9.xsd. This was being lowercased by systemId.toLowerCase() and hence it could not find that file. I changed the liquibase code to not do that and got past this error

Then I got this error from liquibase
because 'file' access is not allowed due to restriction set by the accessExternalSchema property
Turns out that liquibase.parser.core.xml.XMLChangeLogSAXParser does this
parser.setProperty(XMLConstants.ACCESS_EXTERNAL_SCHEMA, "http,https"); //need to allow external schemas on http/https to support the liquibase.org xsd files

Doesn't seem very secure to me since the whole point of this was to not allow remote access from resolving xsd however i set it to "all" instead and got past the error.

So I just revisited this due to that I can't be introducing security issues.. I know I'm not allowed to modify your code and to distribute but to test it what I did is replace the /META-INF/dbchangelog-3.9.xsd in your scim-changelog.xml with  http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-3.9.xsd
From here https://docs.liquibase.com/concepts/changelogs/xml-format.html it says "Liquibase contains XSD files locally and does not need to retrieve them from the internet to validate your XML." so why do you have the /META-INF/dbchangelog-3.9.xsd. It's causing problems for me so is that something you can revert in your code?

this is actually an old issue, and I - unfortunately - simply forgot about it.
I will fix it as soon as I have time. For the time being modifying the liquibase-changelog headers won't do any harm. So as a quick fix you are free to do it until I got it fixed.

fixed in the next release

not deployed yet.
I will try to release it this weekend.

K great. in the meantime I continued to modify the code as you allowed.. I'm with nigesh and cambridgesemantics for use withing Anzo.

just uploaded kc-21-1.2.2-RC2-free and kc-21-1.2.2-RC2-enterprise
Please let me know if the liquibase error does still occur.

Does everything work now?
If yes I would release the changes also for the other branches

Hi.. very sorry.. I will try it now

I tried it and it appears to work


[BUG] Error when trying to add a 11th TAG

Issue description
Adding custom TAGS for videos works as intended, until attempting to add a 11th tag. When adding a 11th tag, an error pops in the UI, with an error in the log as well.
See attached log for stack trace.
Streama_10th_tag_save_error.log
Steps to Reproduce

Add or edit existing movie
Select the Tag field
Type in a new name for a non-existent tag (10 tags must already exist at this point)
Save movie

Expected Behaviour
The tag should be added and the movie should be saved successfully
Actual Behaviour
Error in UI and in logs
Movie does not save
Environment Information

Operating System: Ubuntu 18.04.1
Streama version: 1.6.5

Updated info; I was mistaken, and 10 Tags have to exist for the issue to occur.
In addition, I have also edited the streama.mv.db with H2 to see the tags myself, and it turns out that the tags I was trying to save, ARE getting saved, they just aren't showing up in the UI.

Ok so i fixed something here, but I dont think it was your issue directly. Maybe retest on v1.7.0 when thats stable.
Thanks!


auto clean up trailing whitespace only

Would be nice to be able to only affect trailing whitespace automatically as apposed to that and blank lines

Hi, I'm not sure what you mean. Could you provide any example to me?

I just submitted a PR #11 which resolves my question.
Basically, it adds a few more configuration variables so that you can choose to only enable clean up of trailing whitespace, or blank lines instead of needing to do both.
There is also one of these variables for if you want to only clean up changed lines, or the whole file.
I also added a generic auto-clean-up instead of just the auto clean changed lines.

essentially what I was saying is, I want to be able to automatically clean the changed lines in my file, but I only want to clean the trailing whitespace, but not the blank lines.

Fixed in 84fb14825639c6589b7151f8c23c6efa6c398648.


"unexpected keyword argument" error compiling PyQtGraph application

Output of pip freeze
certifi @ file:///C:/b/abs_85o_6fm0se/croot/certifi_1671487778835/work/certifi
click==8.1.3
colorama==0.4.6
darkdetect==0.7.1
Nuitka==1.5.5
numpy==1.24.2
ordered-set==4.1.0
packaging==23.0
pyqtdarktheme==2.1.0
pyqtgraph @ git+https://github.com/pyqtgraph/pyqtgraph@7642e18e1d1ff569b1ef6db844c09280fc5fcddf
PySide6==6.5.0
PySide6-Addons==6.5.0
PySide6-Essentials==6.5.0
qtextras==0.6.7
QtPy==2.3.1
ruamel.yaml==0.17.21
ruamel.yaml.clib==0.2.7
shiboken6==6.5.0
wincertstore==0.2
zstandard==0.20.0

Output of python -m nuitka --version
1.5.5
Commercial: None
Python: 3.9.12 (main, Apr  4 2022, 05:22:27) [MSC v.1916 64 bit (AMD64)]
Flavor: Anaconda Python
Executable: C:\Users\ntjess\miniconda3\envs\py39\python.exe
OS: Windows
Arch: x86_64
WindowsRelease: 10
Version C compiler: C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Tools\MSVC\14.35.32215\bin\HostX64\x64\cl.exe (cl 14.3).

MWE file main.py:
import pyqtgraph as pg
from pyqtgraph.parametertree import Parameter, ParameterTree

pg.mkQApp()
tree = ParameterTree()

params = [
    {'name': 'param1', 'type': 'int', 'value': 10},
    {'name': 'param2', 'type': 'float', 'value': 1.0},
    {'name': 'param3', 'type': 'bool', 'value': True},
    {'name': 'param4', 'type': 'list', 'values': ['a', 'b', 'c'], 'value': 'a'},
]

p = Parameter.create(name='params', type='group', children=params)
tree.setParameters(p, showTop=False)

tree.show()
pg.exec()

After compiling with python -m nuitka main.py  --enable-plugin=pyside6 --standalone
and running with main.dist/main.exe:
Traceback (most recent call last):
  File "C:\Users\ntjess\Desktop\git\TEST-N~1\MAIN~1.DIS\main.py", line 15, in <module>
  File "C:\Users\ntjess\Desktop\git\TEST-N~1\MAIN~1.DIS\pyqtgraph\parametertree\ParameterTree.py", line 50, in setParameters
  File "C:\Users\ntjess\Desktop\git\TEST-N~1\MAIN~1.DIS\pyqtgraph\parametertree\ParameterTree.py", line 80, in addParameters
  File "C:\Users\ntjess\Desktop\git\TEST-N~1\MAIN~1.DIS\pyqtgraph\parametertree\ParameterTree.py", line 67, in addParameters
  File "C:\Users\ntjess\Desktop\git\TEST-N~1\MAIN~1.DIS\pyqtgraph\parametertree\Parameter.py", line 571, in makeTreeItem
  File "C:\Users\ntjess\Desktop\git\TEST-N~1\MAIN~1.DIS\pyqtgraph\parametertree\parameterTypes\basetypes.py", line 62, in __init__
TypeError: _missing_interp() got an unexpected keyword argument 'force'

Note that the example has no issues compiling without standalone (python -m nuitka main.py) and instead running .\main.cmd:

Is there something I can fix on my end?
Originally posted by @ntjess in https://github.com/Nuitka/Nuitka/issues/1532#issuecomment-1502912511

I managed to reproduce it. Somehow for a type, a default implementation is used. There has to be some sort of unpopulated registry, that I need to find I guess.

        def _missing_interp(v):
            # Assume raw interpretation
            return v
            # Or:
            # raise TypeError(f'No interpreter found for type {typ}')

This not supporting force might be an upstream problem, but in the uncompiled, this never triggered, so there is some sort of incompatibility going on.

What's crazy, is that if I change that function to raise the TypeError, the compilation result just works. I need to repeat that, but that should be impossible, but maybe something handles that TypeError.

This is killing me.
How can _missing_interp as given by the qualname be used, when it lives like this:
    def _interpretValue(self, v):
        typ = self.opts['type']

        def _missing_interp(v):
            # Assume raw interpretation
            return v
            # Or:
            # raise TypeError(f'No interpreter found for type {typ}')

        assert hasattr(builtins, typ)
        interpreter = getattr(builtins, typ, _missing_interp)
        print("V", typ, interpreter, v)
        return interpreter(v)

Literally the only way is if there is corruption with compiled function objects of some sorts. This appears to be yet another symptom of a corruption. However, yet again, it's behaving the same on both Windows and Linux. That is entirely unlikely for a corruption. However, I lack any other explanation. I am disabling the freelist. Also, something of note is that with using typ the function is having a closure variable and as such might have different malloc behaviour. If this holds true, it's a very ugly issue.

So, I narrowed this down a lot. I added a bunch of checks and made a bunch of disables for optimazation work and more checks generally. But turns out, that his call releases the compiled method in question, the one found later used in unusable state. Did that by checking release functions for their names.

self.widget.sigChanged.disconnect(self.widgetValueChanged)

Here, this is a PySide6 widget, which disconnects a slot and after that, self.widgetValueChanged is released, but still stored in self. With a free list, the memory can be used again, and then the effect is different code being called, which explains the error seen when attempting to call it, namely the argument error.
The call code is also innocent, I disabled all call optimization too, making the most generic call form and things still happen like that. Now first course of action in to update PySide6 and see if we can reproduce it outside of pyqtgraph. The fix probably has to be in PySide6. Unfortunately PySide 6.5.0 is equally affected. I was still using a 6.4 before.

So, I isolate this:
""" Reference counting tests.

These contain functions that do PySide6 specific things, where we have a suspect
that references may be lost or corrupted. Executing them repeatedly and
checking the reference count is how they are used.
"""

# While we use that for comparison code, no need to compile that.
# nuitka-project: --nofollow-import-to=nuitka

# nuitka-project: --enable-plugin=pyside6

import os
import sys

import sys
from PySide6.QtWidgets import QApplication, QPushButton

app = QApplication()
button = QPushButton("Call function")

from nuitka.tools.testing.Common import executeReferenceChecked

x = 17

def function():
    pass

class C:
    def meth(self):
        pass

def qtTestFunction1():
    button.clicked.connect(function)
    button.clicked.disconnect(function)

def qtTestFunction2():
    c = C()

    button.clicked.connect(c.meth)
    # button.clicked.disconnect(c.meth)

####################################

# These need stderr to be wrapped.
tests_stderr = ()

# Disabled tests
tests_skipped = {}

result = executeReferenceChecked(
    prefix="qtTestFunction",
    names=globals(),
    tests_skipped=tests_skipped,
    tests_stderr=tests_stderr,
)

sys.exit(0 if result else 1)

Commenting out the disconnect actually makes no difference. The automatic disconnect releases the function owned by the given method object illegally. Only if the object lives, repeated connects are not an issue. I think we need to check PySide6 code in that area.

So, as a workaround, you can do this.
def myconnect(self, func):
    if hasattr(func, "im_func"):
        if hasattr(func.im_func, "__compiled__"):
            myconnect._protected = getattr(myconnect, "_protected", set())
            myconnect._protected.add(func)

    return orig_connect(self, func)

import PySide6.QtCore
orig_connect = PySide6.QtCore.SignalInstance.connect
PySide6.QtCore.SignalInstance.connect = myconnect

Then it's no more crashing, but leaking a reference to the compiled method and as a consequence the object assiociated. The real fix has to be in PySide6, but we have this now, and even integrate it into the PySide6 plugin.

This is part of the hotfix release 1.5.7 that I just made.

The plugin for PySide6 now does this automatically, and just like that, it runs smoothly.
The corruption happens when disconnecting slots or releasing objects with slots connected. The workaround will prevent that from happening. The disconnect is still done, but the method is kept in memory, causing a small memory leak. For now that works.


Update springframework to 6.0.0-RC3 #55

https://github.com/spring-projects/spring-framework/releases/tag/v6.0.0-RC3


database/sql: investigate various issues with the the sql.Result

I'm not proposing anything at this point. I'm just documenting various things I've come things I've come across that relate to sql.Result.
@mjibson has said:

the current problem i'm having with the database/sql API is that it's not possible to get intermediate non-rows returning results when sending multiple statements in a single string
for example given create table t (i int); drop table a; i'd like to get back 2 results instead of 1. the next result sets stuff assumes that a full rows object instead of optionally returning a sql.Result instead. i am modifying lib/pq to support this, but only if you don't use database/sql.

The other @mattn has said:

One of the motivation is rowid in oracle. rowid is not number, so go-oci8 doesn't work correctly for the go's LastInsertId. The second, we have to allocate/free the buffer to get result specific value for the pl/sql.

@tgulacsi do you have anything to add?

@mjibson You mentioned you were modifying lib/pq to support getting each result. Did you do this and if so could you point me to the code? I'd like to see the details. Supporting this seems really close to also supporting NOTICE messages too.
@mattn It seems like the best solution might be to have a result that returned an interface{} value, then you could call x.Result().(int64) or x.Result().(GUID) or x.Result().(string). Might be useful for DBs like CRDB where keys may more often by strings of bytes.
Can the Last Insert ID also be returned from non-exec queries? Is that also desirable?

No, I haven't done this yet, although I would still like to. The current plan is to add an internal method with a flag to return these intermediate messages or not during calls to NextResultSet.

Throwing out ideas here. What if there was a new method attached to sql.Rows that could be called after sql.Next but before sql.NextResultSet that would return an array of interfaces where you can do a type switch to return various items, such as informational NOTICE messages, last inserted ID, rows affected.
for {
    for rows.Next() {
        rows.Scan(...)
    }
    for {
        switch m := rows.Message().(type) {
        case sql.RowsAffected:
           fmt.Println("affected:", v.Count)
        case sql.Notice:
            fmt.Println("NOTICE:", v.Message)
        case sql.LastInsertID:
            fmt.Println("ID:", v.Value.(GUID)) // Support more than just int64.
    }
    if !rows.NextResultSet() {
        break
    }
}

Buffered messages would be discarded after the next call to rows.NextResultSet or rows.Close.
Thoughts?

Calling .Message like this presents some ordering problems. Say I have the multi-statement query:
insert into t values (1); select * from t; delete from t;
The above API would, as I read it, return a message only about the delete, but ignore the insert. That is, it seems like either all the messages before the first SELECT or after the last SELECT will be ignored with the above suggestion. You could decide that all the messages before the first SELECT get added to the Message calls for the first round, but that mixes the order of when they happened, which also seems wrong. I like some things about this suggestion, like it doesn't require yet another method on sql.DB, but I think it needs some more iteration. No ideas come to mind.

Point taken. I'll think on it.

@mjibson An alternative is that messages are cached until they are dequeued or rows.Close is called.
Thus you might do this:
handleMessages := func(rows *sql.Rows) {
    for {
        switch m := rows.Message().(type) {
        case sql.RowsAffected:
           fmt.Println("affected:", v.Count)
        case sql.Notice:
            fmt.Println("NOTICE:", v.Message)
        case sql.LastInsertID:
            fmt.Println("ID:", v.Value.(GUID)) // Support more than just int64.
    }
}
for {
    for rows.Next() {
        rows.Scan(...)
    }
    handleMessages(rows) // optional
    if !rows.NextResultSet() {
        break
    }
}
handleMessages(rows) // only need it here
rows.Close()

Perhaps the rows.Message() could be valid anytime before close and it would dequeue any pending messages received up till then.
It would be a bit awkward to call manually per query, but super easy in any type of framework / generic table buffer situation.

Another choice is to have .Message be able to also indicate a rows result:
Loop:
	for {
		switch m := rows.Message().(type) {
		case sql.RowsAffected:
			fmt.Println("affected:", m.Count)
		case sql.Notice:
			fmt.Println("NOTICE:", m.Message)
		case sql.LastInsertID:
			fmt.Println("ID:", m.Value.(GUID)) // Support more than just int64.
		case sql.RowsResult:
			for rows.Next() {
				rows.Scan(&v)
			}
		default:
			if !rows.NextResultSet() {
				break Loop
			}
		}
	}

Something like this would preserve full statement ordering, which is a requirement for my use case.

I like where this is going. We are only adding a single method, but allow a new way of consuming in sequence order all messages from the database, not just data results. It is also by nature is opt in.
Furthermore the message buffer should be able to be reused easily. I think if the RowsResult message was also used, then both rows.NextResultSet and rows.Close would clear any enqueued messages.
If you're happy with that, I'll see if I can work up a CL.

I think rows.Message() is good for us to extend next feature.

Please review https://go-review.googlesource.com/c/39355/ for API suitability and correctness.

This would work for my use case as well.
One thing I would proceed cautiously on is buffering of messages that aren't read. Some database procedures can produce a large number of messages. Right now I believe these are discarded by drivers. Existing clients may rely on the fact that these messages are discarded, but if this behavior changes underneath them I'm worried that this could lead to unbounded memory consumption in the driver waiting for the user to read such messages.
My point is we might want to consider making the usage of this feature more opt-in, specifically for memory consumption. Perhaps: stop buffering if a call to rows.Next() is made before any call to rows.Message.

In go1.9, drivers will be able to accept non-query parameters as arguments to a query. I think this can be solved with https://github.com/golang-sql/sqlexp/blob/master/messages.go  if a driver supports it.
I'm removing the milestone because I think this can be accomplished for now out of the std lib for now. If the approach works, we might want to bless this method in some way.

Currently as of Go1.10, results from an Exec are wrapped in the driverResult. Around each call to LastInsertId and RowsAffected it locks with the driverConn. There are fundamental problems with this design.

You cannot design a correct driver that calls back into the database from the result because another insert may have happened in the same session/connection after the result was returned but before result.LastInsertId was called. The driver must ensure that it has the last insert ID prior returning initially.
The driverResult locks around the driverConn, but if that has already been returned to the pool and may already be in use again. It could have a fundamentally different value on that connection or it may just block needlessly until that unrelated query is done and it can fetch the stored integer ID.
Lastly, it assumes an IDENTITY column types (PostgreSQL and Oracle have named serials often) and that the IDENTITY is an integer. This is not always true.

We should fix these issues in Go2 #22697 .

Something like this has my vote.  I'm struggling with this right now.
I do want to make sure we think about something like BACKUP that doesn't return result sets but returns lots of messages while it's running.  It seems like that would be handled.
I'd even be happy if I could just pass in a logger of some type.  The two options I'm thinking about now are to hack "sql" to print these out in a format I like or wrap sqlcmd.exe and just print all the results.  I don't really like either :-)
I also thought about sending in a channel to "sql" that I could consume.  I'm afraid that has problems I haven't discovered though.


python3Packages.openshift: fix disabled tests

Description of changes
The functional docker tests have been removed, but the integration also fail. Therefore, ignore them.
Things done

Built on platform(s)

[ ] x86_64-linux
[ ] aarch64-linux
[x] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[x] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
22.05 Release Notes (or backporting 21.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module
[ ] (Release notes changes) Ran nixos/doc/manual/md-to-db.sh to update generated release notes

[x] Fits CONTRIBUTING.md.

indeed ty


coq: 8.10+beta1 -> 8.10+beta2

Motivation for this change
New testing version of Coq 8.10 released a while ago.
Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

cc @vbgl

@GrahamcOfBorg build coqPackages_8_10.tlc

Tests have passed.


DP-1612 Fix: Rejected questions inside print preview

Using acceptedContents instead of status as the property being validated against for question approval status

@pallakartheekreddy - Requesting review


Update Qt.py

Problem
After installing PySide2 in my Avalon environment, when I try to open Avalon Loader from the Launcher action, it gave me this error :
AttributeError: module 'PySide2.QtGui' has no attribute 'QStringListModel'

Solution
Updating vendorized Qt.py to the latest version (1.2.0.b3) solved this.

In Gitter
:point_up: March 21, 2019 3:33 PM

Thanks, shouldn't cause any issues. Free to merge.

Perfect, free to merge.

Merging this, thanks !