Fix not found page shows when open a new thread

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/App/issues/52204
PROPOSAL: https://github.com/Expensify/App/issues/52204#issuecomment-2468173746
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Open any chat
Send a new message
Open a thread of the new message
Verify not found page doesn't show
Verify there is only 1 OpenReport calls

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android: Native
[x] Android: mWeb Chrome
[x] iOS: Native
[x] iOS: mWeb Safari
[x] MacOS: Chrome / Safari
[x] MacOS: Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
[x] If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:

[x] I verified that all the inputs inside a form are aligned with each other.
[x] I added Design label and/or tagged @Expensify/design so the design team can review the changes.

[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

https://github.com/user-attachments/assets/ef75f7fb-fb8c-4f8f-9345-245ef55b8028

Android: mWeb Chrome

https://github.com/user-attachments/assets/a335ffad-5b6d-4994-b54a-d0a865165e2e

iOS: Native

https://github.com/user-attachments/assets/3f9e73bb-28bb-476f-9fb3-1329ef1cb33a

iOS: mWeb Safari

https://github.com/user-attachments/assets/7c1fec0c-d2e8-47b4-9bc2-07e5369e1942

MacOS: Chrome / Safari

https://github.com/user-attachments/assets/758c0ab2-3966-4818-b57e-a01b6cd7776f

MacOS: Desktop

https://github.com/user-attachments/assets/5359a530-e315-4849-8fde-2e07e0f74282

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.


:heavy_plus_sign: Added estraverse dependency

Hi everyone,
I propose this PR in order to solve a problem related to estraverse dependency which is used in ./lib/patch-eslint-scope.js. Currently babel-eslint import this dependency from eslintMod (allows to import the module of eslint) except this is a problem because estraverse isn't a dependency used by eslint. This produce an error when we use the package manager pnpm for example.
To solve this problem, we install estraverse in the dependencies and modify "patch-eslint-scope.js" to use it.
Current issue opened : Incorrect estraverse require #680

👍 This would also help with Plug'n'Play! 🙂

Ok looks like it was removed in https://github.com/eslint/eslint/pull/8755 so they don't actually use the module at all now

Howabout releasing a major version that drops support for patching scope?

Yeah let's just do that instead

Sounds like we should do something like https://github.com/babel/babel-eslint/pull/689 + peerDep eslint 5 + major version?


Use nvim-web-devicons for statusline file icons

use %f on statusline.lua#L59 if you want file name with directory like before, but just the name seems cleaner than full path

It does look good not to show the full name, yet adding a new plugin for what's already present isn't what I'd prefer.

It does look good not to show the full name, yet adding a new plugin for what's already present isn't what I'd prefer.

hm interesting, i didn't notice you don't have nvim-web-devicons as dependency for nvim-tree.
i know it's optional but I've seen almost everyone including that. I'd suggest to add it cause many plugins use it and also doesn't add a lot to the stack

This is opinionated, but I prefer not to have those icons, now that I've tried it, as all it makes the nvim-tree is cluttered for some extra two chars.
Thanks for the contribution yet I don't see adding the web-dev-icons plugin as useful


Error

"The procedure entry point GetHostNameW could not be located in the dynamic link library WS2_32.dll"
Did I do something wrong, or is it a program error?

Can you tell me your OS environment?

I checked on windows 10, the program worked. Turns out that windows 7 x64 does not support


user12986714: Watch ^(?-i:reb\d*+)$

user12986714 requests the watch of the watch_keyword ^(?-i:reb\d*+)$. See the MS search here and the Stack Exchange search in text, in URLs, and in code.

^(?-i:reb\d*+)$ has been seen in 0 true positives, 0 false positives, and 0 NAAs.

Too much collateral damage


Subsetting: When clicking new entity in diagram, scroll active variable in VariableTree into view

The current behavior is that the variable tree does not expand and scroll the active variable into view.

This only happens if the target node is in a collapsed branch of the tree. This suggests that the target node is scrolled into view before the branch is expanded.


fix(webpack) removes unused components from the bundle

this removes some packages from the webpack bundle that we are not using as well as switching the source of scss to the altered repo

not intended as a pr to fabric-design
closing this


My turnip prices seem to break the app

Things to check

Have you forced a refresh in your browser (e.g. ctrl+F5 in Chrome/Firefox)?
N/A
Have you made sure the first time buyer option is correct?  Travelling backwards resets the prices, and therefore you must not put prices in from both before & after the time-travel
No time travel at any point

Describe the bug
Buy price: 90 bells
Monday AM: 71
Monday PM: 78
Tuesday AM: 81
Tuesday PM: 86
Before I insert Tuesday's PM price, the prediction for it is 125-179. However when I input the real Tuesday PM price (which is out of the predicted range), the graph turns into an [-infinity, infinity]. I'm 100% sure my turnip prices are correct. The predicted pattern is small spike, same as last week.
To Reproduce
Steps to reproduce the behavior:
Insert the values mentioned above
Permalink to your prices
https://turnipprophet.io?prices=<IP_ADDRESS>.86........&pattern=3
Desktop (please complete the following information):

OS: Windows 10
Browser: Chrome
Version: 81.0.4044.129

I'm sharing this because I thought I was in the same boat, but then turns out I just put the wrong price in. Hopefully it helps someone else.
I thought mine too broke it this week:
https://turnipprophet.io?prices=<IP_ADDRESS>.........&pattern=1
And then I realized I typed in 62 instead of 65:
https://turnipprophet.io?prices=<IP_ADDRESS>.........&pattern=1
So, my guess is two-fold:

You HAVE to put the exact price each day
Wish there was someway for the calculator to spit out a more intelligible message, i.e. "WOAH your Tuesday AM price seems impossible, are you sure that's correct? Double check your prices."

Hopefully someone with more knowledge can take a look at your prices and give a better answer.
Is it possible in the last update that they changed the algorithm for turnip prices?

Wish there was someway for the calculator to spit out a more intelligible message, i.e. "WOAH your Tuesday AM price seems impossible, are you sure that's correct? Double check your prices."

Very much this. I'm not certain where I went wrong, because I was pretty sure I entered in the correct prices each day, but somewhere I went wrong, as the price now is 151, and not the large spike predicted.
https://turnipprophet.io/?prices=<IP_ADDRESS>.<IP_ADDRESS>.104.153...&pattern=2


switch to regexp for more accurate number/street parsing

Looks good! For more chances like this, could we keep the chance to the JSON fairly localized to just the affected lines?


Questions: what is the max resolution of the adaptive HLS url? Best practices for streaming own videos in 4k to app?

What is the max resolution of the adaptive HLS url? My connection isn't especially fast so I'm wondering if I'm being limited by my connection speed or if the HLS link just doesn't go up to 4k.
And if I want to create an app that streams 4K videos (for some reason 4K seems to be locked behind api unlike adaptive and 1080p links) we've uploaded to our channel, how should I handle authentication?
This is a little vague:

Will people besides you be able to access your app?
No. The only Vimeo accounts that will have access to the app are my own.
Yes. Other Vimeo accounts besides my own will be able to access the app.

Other users will be using the app, but presumably it'd just be our Vimeo account because we'd just be playing our unlisted videos. For testing I just checked "No" and generated an access token to use -- is that the way to go for a live app?
Thanks,

@justin-pierce which media player are you using to play the adaptive videos?

@justin-pierce which media player are you using to play the adaptive videos?

AVPro


Is it correct to use the option "--docker-container-logging" for Windows?

Hi Team,
In the "Stream diagnostic logs" section, this page says the following for Windows.
To access the console logs generated from inside your application code in App Service, turn on diagnostics logging by running the following command in the Cloud Shell:
az webapp log config --resource-group  --name  --docker-container-logging filesystem --level Verbose
I have an understanding that Windows platform is not related to the docker container, but is it correct to use the option "--docker-container-logging"?
Best Regards,
Takeshi Katayama

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: df68e904-7b05-38ba-4203-50eb8491946f
Version Independent ID: 921377f7-e428-143d-70e4-c9efc25e41d1
Content: Configure Java apps - Azure App Service
Content Source: articles/app-service/configure-language-java.md
Service: app-service
GitHub Login: @JasonFreeberg
Microsoft Alias: jafreebe

@take-4c Thanks for the feedback! We are currently investigating and will update you shortly.

@BryanTrach-MSFT
Thank you for the response. I see.
But I think it would be better to clearly state that is written for someone using a docker container.
If current description, people who use Windows(not windows container web app) also think I should use the following command.
az webapp log config --resource-group --name --docker-container-logging filesystem --level Verbose


Mem leak in webkit_start (webkit.c)

==31875== 32 bytes in 1 blocks are definitely lost in loss record 3,416 of 7,856
==31875==    at 0x4C2B200: calloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
==31875==    by 0xBCD263F: _dlerror_run (in /lib64/libdl-2.19.so)
==31875==    by 0xBCD20C0: dlopen@@GLIBC_2.2.5 (in /lib64/libdl-2.19.so)
==31875==    by 0xD202DC5: g_module_open (in /usr/lib64/libgmodule-2.0.so.0.4400.1)
==31875==    by 0x740DEF8: ??? (in /usr/lib64/libgtk-3.so.0.1600.7)
==31875==    by 0x73E66C1: ??? (in /usr/lib64/libgtk-3.so.0.1600.7)
==31875==    by 0x9F78A2E: g_option_context_parse (in /usr/lib64/libglib-2.0.so.0.4400.1)
==31875==    by 0x73E6B9D: gtk_parse_args (in /usr/lib64/libgtk-3.so.0.1600.7)
==31875==    by 0x73E6BF7: gtk_init_check (in /usr/lib64/libgtk-3.so.0.1600.7)
==31875==    by 0x73E6C38: gtk_init (in /usr/lib64/libgtk-3.so.0.1600.7)
==31875==    by 0x40635C: iptvx_webkit_start (webkit.c:135)
==31875==    by 0xAE6B687: ??? (in /usr/lib64/libSDL-1.2.so.0.11.4)

issue is inside gtk


I2S driver typo (Philip) (IDFGH-8764)

Answers checklist.

[X] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
The I2S driver uses the word "Philip" instead of "Philips" everywhere.

Thanks! It'll fix soon.


Add customized agent in workstation.

Description
Support user-defined agent classes in the workstation, read the parameters of the init method of the customized agent class and display them in the node (str, int, or float).

Given that our online workstation will support customized agents in the future, we've decided to leave the implementation of these agents entirely to the workstation itself, rather than importing them at launch. Therefore, we will close this PR for now.

Given that our online workstation will support customized agents in the future, we've decided to leave the implementation of these agents entirely to the workstation itself, rather than importing them at launch. Therefore, we will close this PR for now.


AP active but not connectable

Hey,
I have been successful in creating the AP with wifi-connect and have edited the start.sh script and created a service that run it on boot.
Even with default settings the AP is always visible but not connectable. The client devices just go in a loop trying to connect and then on my android phone it disables it as an option.
I have attached the logs from the service and it appears to be creating wpa_supplicant[683]: handle_probe_req: send failedissue.
Has anyone else experienced this issue.
I am running Debian 9.9 and have a rt2870 wifi adapter.
Ap Syslog.txt

Running into the same problem on odroid xu4

Do you guys run wifi-connect as root? I think similar symptoms may occur when running it with user with insufficient privileges.

We get this as well, but only occasionally, so it seems that running as root isn't our problem. Basically, our phones just never seem to get an IP from the AP. We're using Android phones and after tapping on the network to join it, it shows "Obtaining IP address..." for awhile, then gives up. Did you ever figure this out, @Smigg92 or @Leathal1?

I figured out why our particular setup was behaving this way: the docker-compose.yml file. I had been toying with running multiple containers and hence, had created the file. I then put a pause on that, but kept the file around and defined only one service in it. Then I restumbled upon the docs that pretty clearly state:

Unlike single container applications, multicontainer applications do not run containers in privileged mode by default. If you want to make use of hardware, you will either have to set some services to privileged, using privileged: true, or use the cap_add and devices settings to map in the correct hardware access to the container.

I also remembered @majorz's comment above, but I have only one service, right? Right, but apparently the presence of the docker-compose.yml file is enough to cause containers to run without privileges. I deleted the file (since I only had one service anyways, it didn't hurt anything) and poof, everything starts working again. I'd like to keep the file, so I restored it and then added privileged: true and everything is still working.
Thanks for the hint, @majorz!

I'm still having issues with this. @mtrewartha would you mind sharing the code from your docker-compose.yml and Dockerfile for the container running wifi-connect?

Here are the relevant parts for you, @meech-ward. See my comments in there for more details. I've stripped parts of our stuff out, but I think I've left everything important for you in there.
# Dockerfile.template

FROM balenalib/%%BALENA_MACHINE_NAME%%-debian:latest

# I've omitted some of the packages we install, but I believe these are the only ones
# required (network-manager might not even be required)
RUN sudo apt-get update -y  && \
    sudo apt-get install dnsmasq network-manager wireless-tools -y && \
    sudo apt-get clean && \
    sudo rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

# Don't think this is needed for WiFi Connect, but including just in case... I'm off
# this project now and it's been awhile, sorry!
ENV DBUS_SYSTEM_BUS_ADDRESS unix:path=/host/run/dbus/system_bus_socket

# This isn't necessary, but we customize the advertised SSID with it
ENV PORTAL_SSID <our specific SSID>

WORKDIR /wifi-connect
RUN curl https://api.github.com/repos/balena-io/wifi-connect/releases/latest -s \
    | grep -hoP 'browser_download_url": "\K.*%%BALENA_ARCH%%\.tar\.gz' \
    | xargs -n1 curl -Ls \
    | tar -xvz -C /wifi-connect/

... and here are the relevant lines from the start script (the one used as the CMD in the Dockerfile.template file):
# start.sh

cd /wifi-connect
./wifi-connect

... and here are the relevant parts of the docker-compose.yml file:
# docker-compose.yml

version: 2
services:
  our_service_name:
    build: ./
    labels:
      io.balena.features.dbus: "1"
    network_mode: host
    privileged: true

@mtrewartha Thank you so much. It's finally working. I was missing the following in my Dockerfile and I guess that's why it wasn't working:
RUN sudo apt-get update -y  && \
    sudo apt-get install dnsmasq network-manager wireless-tools -y && \
    sudo apt-get clean && \
    sudo rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*

No prob, glad I could help @meech-ward!


Migration towards entity server

Following lengthy discussions with @mick-roper:
Is your feature request related to a problem? Please describe.
Currently the CLI interacts with the Python based API. Certain parts would now be shifted to the entity server. A migration is needed for these parts.
Describe the solution you'd like
reliably slo would require changes:

The CLI would need to push the manifest's SLO entities to the entity server. This could be done during reliably slo init and/or other subcommands. The exact implementation would require more discussion likely with @dmartin35
With reliably slo report, when an SLI is calculated, it should be pushed as an Indicator entity (name TBD) to the entity server. This would result in the server calculating an Outcome (name TBD) for related SLOs, and reporting back the outcome to the CLI. Recording this on the server unlocks features such as dependency graphs, alerts, webhooks, etc...
Currently the entire manifest can be persisted onto the API. This may involve changes depending on what the expected outcome of persisting the manifest is. One option is to break this down into SLOs before pushing and record them as SLO entities. Another option is to keep the entire manifest persistence feature as separate. I would be inclined to say that it's better to always work towards the entities of the entity server, and therefore save these as SLO entities.
Currently the CLI starts with services as the parent, although the entity server has SLOs as the parent entity. This may change in future, but to interact with the entity server this may need to be taken into consideration.
If history tracking is required for a given entity, versions, ids, and timestamps need to be discussed.

Describe alternatives you've considered
Shifting the complete computation towards the entity server (currently done on the CLI) was considered but this was deemed an over-complication for the current requirements. Further thought may be put into how to create a more robust language to consume aggregated metrics that relate to SLOs/SLIs in future.
Additional context
As of today, the entity server is being transformed to a more focused approach that removes the Metrics entity. Whilst this is happening, the documentation on that interface will not be an accurate representation of its spec.
@mick-roper can also help with any further clarifications whilst I'm away.

Thanks @xaah
I feel this requires more discussion still. Yet, until we shift to this API, our current entity server is bit "worthless". Let's progress this next week when you return @xaah.
@mick-roper, @dmartin35 feel free to review this issue and share your 2cts please.

@Lawouach indeed I think there are some points we need to discuss still.
Fundamentally there are two approaches here that can be taken:

One is to adapt the CLI internals so that it can interact with the entity server, in a way that is transparent to the user, that is, without an initial impact on the user experience, e.g. the manifest structure does not change.
The other option is to also adapt aspects of the CLI that impact the user so that it reflects the concepts of the entity server. Within this approach, two main topics arise:

The manifest's structure needs to change, potentially into multiple files, to represent entities and the selector/label mechanism.
State being centralized on our backend. Will this affect how we approach the manifest?

I think we might as well update the manifest and CLI user experience to reflect our backend's entity structure as well as the selector/label mechanism, if we agree on that design. The manifest is currently a core component of the CLI and Reliably's approach to reliability. Therefore, if we agree that it should be adapted, it would be ideal to have a discussion surrounding how to adapt it that involves multiple viewpoints across the @reliablyhq/developers team.
There are some minor adjustments being made to the entity server's functionality but it's a lot clearer now.

As per last call, the decision is to proceed with change proposals to the manifest/CLI functionality that reflect the capabilities of the entity server. The proposed changes will be drafted soon and then presented to the team to collate any observations regarding impact on UX and making sure we're all aligned.

Issue has been broken down into multiple issues:
https://github.com/reliablyhq/cli/issues/311
https://github.com/reliablyhq/cli/issues/312


Dashes, en-dash and em-dash guidance

Issue
Users are reporting confusion around seeing un-spaced em-dashes (over dashes or en-dashes spaced or un-spaced).
We currently recommend using un-spaced em-dashes in headings and body (for example—like this).
Which entry/section is this related to?
http://content-style-guide.apps.staging.digital.gov.au/az-indexes/h.html#hyphens-and-dashes

Hi @joolswood, just wanting to confirm if the change to adding spaces around an em-dash will actually take place, or if it's just going to committee for discussion? Thanks.

Hi @michaelhugill I've added this for discussion at content clinic today. Cheers

Action to check on screen reader support for space em-dash space.
Support for using to over en-dash for ranges.

Andrew Arch reported, based on another user's experience with screen reader:
feedback o/night from a JAWS user is that the emdash is ignored in normal reading (with /without space), but the spaces help if reading a word at a time. This was based on putting an emdash in email the two different ways.

Based on this I suggest we move to space em dash space.
I do have some reservation that the width of space em dash space may prove too large. We may need to revise this at some point in the future (possibly move to space hyphen space).

I’ve not used ‘from’ in the examples. Happy to revisit this.

https://github.com/AusDTO/gov-au-content-guide/commit/732d44db9e9d9553c81a65fca4256db9d88758fd


Import: Add support for connect API: GET /v1/content/{guid}/bundles/{id}/download

Update connect_client.go to provide the ability to call API
Update agent deployment import call to call connect_client functionality and log significant fields/data
w/ Go unit tests
Testable via curl command

Closing, as we have moved to a simpler initial implementation: #2285


Mismatch between object identifier and API/Download for some SSOs

Hi
For some SSOs with number and designation, the code example to retrieve the data fails: the code provided on the FINK portal uses the designation while the DB query uses the number.
Exemple:
https://fink-portal.org/ZTF24aaakxyd
The code proposes:
r = requests.post(
'https://fink-portal.org/api/v1/sso',
json={
'n_or_d': '1998 XR28',
'withEphem': True,
'output-format': 'json'
}
)
that fails, while
r = requests.post(
'https://fink-portal.org/api/v1/sso',
json={
'n_or_d': '14191',
'withEphem': True,
'output-format': 'json'
}
)
works. The SSO is actually (14191) 1998 XR28.
Maybe testing the incoming identifier ("n_or_d") for aliases could help?

Ah good point! I will fix this :-)


commenter fails to run after results are found

The recent update to Actions workflow has broken the commenter:
+ tfsec --out=results.json --format=json --soft-fail .
+ commenter
Starting the github commenter...
The commenter failed with the following error:
strconv.Atoi: parsing "<nil>": invalid syntax

Relevant workflow file: https://github.com/moritzheiber/terraform-aws-oidc-github-actions-module/blob/main/.github/workflows/test.yaml#L19-L21
Relevant finding (which I'm going to ignore going forward): https://github.com/moritzheiber/terraform-aws-oidc-github-actions-module/blob/main/tests/mocks/mock_provider.tf
The result.json looks like this:
{
	"results": [
		{
			"rule_id": "aws-misc-no-exposing-plaintext-credentials",
			"legacy_rule_id": "AWS044",
			"rule_description": "AWS provider has access credentials specified.",
			"rule_provider": "aws",
			"rule_service": "misc",
			"impact": "Exposing the credentials in the Terraform provider increases the risk of secret leakage",
			"resolution": "Don't include access credentials in plain text",
			"links": [
				"https://aquasecurity.github.io/tfsec/latest/checks/aws/misc/no-exposing-plaintext-credentials",
				"https://registry.terraform.io/providers/hashicorp/aws/latest/docs#argument-reference",
				"https://docs.aws.amazon.com/cli/latest/userguide/cli-configure-files.html"
			],
			"description": "Provider 'provider.aws' has an access key specified.",
			"severity": "CRITICAL",
			"status": "failed",
			"location": {
				"filename": "terraform-aws-oidc-github-actions-module/mock_provider.tf",
				"start_line": 2,
				"end_line": 2
			},
			"resource": "provider.aws"
		},
		{
			"rule_id": "general-secrets-sensitive-in-attribute",
			"legacy_rule_id": "GEN003",
			"rule_description": "Potentially sensitive data stored in block attribute.",
			"rule_provider": "general",
			"rule_service": "secrets",
			"impact": "Block attribute could be leaking secrets",
			"resolution": "Don't include sensitive data in blocks",
			"links": [
				"https://aquasecurity.github.io/tfsec/latest/checks/general/secrets/sensitive-in-attribute",
				"https://www.terraform.io/docs/state/sensitive-data.html"
			],
			"description": "Block 'provider.aws' includes a potentially sensitive attribute which is defined within the project.",
			"severity": "CRITICAL",
			"status": "failed",
			"location": {
				"filename": "terraform-aws-oidc-github-actions-module/mock_provider.tf",
				"start_line": 5,
				"end_line": 5
			},
			"resource": "provider.aws"
		}
	]
}

Hey @moritzheiber  - could you try again with either @main or @v1.0.1 please? I've resolved an issue where there are binaries

Hey @owenrumney, unfortunately, it does not ..

sorry about this @moritzheiber - let me dig into this a bit more - that error is coming from it trying to parse the patch string :thinking:
I'll come back to you shortly

This is what the current result.json looks like:
{
        "results": null
}

Maybe it helps. Thanks for digging into it!

yeah, if I'm understanding it correctly you're updating the workflow on main and its only the .github/<workflow>.yml thats in the commit. I think the error is that I assume there is a PR. It's given me enough of an idea to start testing

Hey @moritzheiber  - please could you give v1.0.2 or @main a go and let me know how you get one - I think the issue should be fixed there

That fixed it, thanks!
I wonder about the usefulness of the current Action structure, but that's the topic of an entirely different discussion

Thanks for letting me know @moritzheiber
Please feel free to open a discussion thread with you concerns about the structure and we can talk through it there.... I very much welcome comment suggestions and criticisms (constructive)


rfc4055 missing *WithRSAEncryption Algorithm Identifiers

The rfc4055 module has identifiers for raw sha224 to sha512, but none for the withRSAEncryption variants.
It has the following, which is discussed in the 5th paragraph of RFC 4055 Section 5:
sha256Identifier = rfc5280.AlgorithmIdentifier()
sha256Identifier['algorithm'] = id_sha256
sha256Identifier['parameters'] = univ.Null("")

But it doesn't have, the following which is discussed in the subsequent paragraphs of Section 5 of the RFC:
sha256WithRSAEncryptionIdentifier = rfc5280.AlgorithmIdentifier()
sha256WithRSAEncryptionIdentifier['algorithm'] = sha256WithRSAEncryption
sha256WithRSAEncryptionIdentifier['parameters'] = univ.Null("")

The same goes for sha224, sha384 and sha512.

Only the OIDs are included in the ASN.1 module in Section 6, which was used to make this module.
The sha224, sha384, and sha256 identifiers are in the module:
sha1Identifier = rfc5280.AlgorithmIdentifier()
sha1Identifier['algorithm'] = id_sha1
sha1Identifier['parameters'] = univ.Null("")

sha224Identifier = rfc5280.AlgorithmIdentifier()
sha224Identifier['algorithm'] = id_sha224
sha224Identifier['parameters'] = univ.Null("")

sha256Identifier = rfc5280.AlgorithmIdentifier()
sha256Identifier['algorithm'] = id_sha256
sha256Identifier['parameters'] = univ.Null("")

sha384Identifier = rfc5280.AlgorithmIdentifier()
sha384Identifier['algorithm'] = id_sha384
sha384Identifier['parameters'] = univ.Null("")

sha512Identifier = rfc5280.AlgorithmIdentifier()
sha512Identifier['algorithm'] = id_sha512
sha512Identifier['parameters'] = univ.Null("")

It seem that this repository is not being maintained any more.  I have made recent additions to https://github.com/inexio/pyasn1-modules.
For your convenience, I will add these in that repository:
sha224WithRSAEncryptionIdentifier = rfc5280.AlgorithmIdentifier()
sha224WithRSAEncryptionIdentifier['algorithm'] = sha224WithRSAEncryption
sha224WithRSAEncryptionIdentifier['parameters'] = univ.Null("")

sha256WithRSAEncryptionIdentifier = rfc5280.AlgorithmIdentifier()
sha256WithRSAEncryptionIdentifier['algorithm'] = sha256WithRSAEncryption
sha256WithRSAEncryptionIdentifier['parameters'] = univ.Null("")

sha384WithRSAEncryptionIdentifier = rfc5280.AlgorithmIdentifier()
sha384WithRSAEncryptionIdentifier['algorithm'] = sha384WithRSAEncryption
sha384WithRSAEncryptionIdentifier['parameters'] = univ.Null("")

sha512WithRSAEncryptionIdentifier = rfc5280.AlgorithmIdentifier()
sha512WithRSAEncryptionIdentifier['algorithm'] = sha512WithRSAEncryption
sha512WithRSAEncryptionIdentifier['parameters'] = univ.Null("")


Python 3

Have you gotten around to implementing in python 3?

PR opened: https://github.com/amirziai/sklearnflask/pull/10

Merged!


Adding more test cases before removing RegEx for parameter matching

@rynowak -- These are just the new test cases that I have added. Will work on the dev code soon.

@kulmugdha, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Would like to see a few tests for doubling up of delimiters. Other than that looks like a good set.

:watch:

@rynowak added a few more tests. Please have a look.

:shipit:

Already merged: https://github.com/aspnet/Routing/commit/ddfe5e9736aed167aa785563c7fc7b203372eb50


Change directory structure

:tada: This PR is included in version 2.3.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Migrate 'shipwright-io/build' to 'Webhook To Fedora Messaging'

This project was listed in the GitHub2FedMsg database and we want to you to inform you about the upcoming deprecation of the service. As the Fedora Infrastructure is finishing up with migrating its applications away from FedMsg to Fedora Messaging, we encourage you to migrate your repository to the successor of the GitHub2FedMsg project, Webhook To Fedora Messaging.
Please follow this link to the official announcement of the project’s release and use the instructions there to migrate to the new service. If this notification was a mistake, please close this notification ticket. We will not act on the repositories whose migrations have not been requested and any related GitHub2FedMsg operations will stop working once the service is decommissioned.

This was something I had set up on the Fedora side to send GitHub webhooks to Red Hat's JIRA instance.


two or more selects on the same page can overlap

If there are two selects on the same page, when I click on the second one, the first one should close.

It's fixed there: https://github.com/optimistex/ng2-select-ex


Feature: Logger setup

@ajayns Please setup logging functionality. Search for open source logging lib or packages and install it.

@ajayns It is worth looking into https://github.com/evgenyrodionov/redux-logger since we use Redux.

Looks good @apollonian11 , but that's for logging redux actions that are dispatched yes? I'm unsure what exactly @utkarsh-var mentioned by logging on the client-side. We're currently just logging client-side errors on the console.

We have to setup logger according to the application run environment.
For dev, staging and testing environment we should log the error to the console with appropriate error severity levels as mentioned here.
For the production environment, we should not log to console instead we should transport it to central logging servers. @ajayns @apollonian11

@apollonian11 Could we setup some sort of basic config for Sentry or so? That's what's required here yeah?

If we're thinking that way, I think logging we could leave it to the dev who's building over this starter. But yes, maybe the React Error Boundary could be good enough for us here, I'll check that out and work on adding it.

Yeah, we can have a separate branch which has Sentry integrated later as well.


[SPARK-41304][CONNECT] Add missing docs for DataFrame API

What changes were proposed in this pull request?

Add missing docs for DataFrame API.
Why are the changes needed?

Improve documentation
Does this PR introduce any user-facing change?

NO
How was this patch tested?

N/A

@zhengruifeng

Merged to master.

Late LGTM


TES backend

Based on the Task Execution Schema spec by GA4GH.
Leftover items for initial version:

[x] Include in build (backend.tes.url config var)
[ ] Remaining conformance tests (10 failing atm)
[ ] Make a project on ci.commonwl.org

Silly question, perhaps, but what is the expected functionality of rabix on GCE/TES?  I have tried following the train-of-thought in the issues here, but it still isn't clear to me.

We've implemented TES backend and you will be able to execute most of the CWL applications (conformance tests as well) with your local Bunny command line tool with -tes-url parameter. This is still experimental and we need to discuss about some lacking features in the TES API (environment variables, etc.).

@seandavi rabix/bunny would be handling the workflow orchestration and CWL-specific things on the execution of workflow components (setup/teardown, inline scripts and such).
This way, a GCE implementation of TES would enable CWL on GCE as well. Likewise for other environments. One could even combine multiple TES implementations (along with other rabix backends) in a single workflow run, though we'd need to take data locality into consideration for scheduling to make this useful.


feat: release-note link

Hello Everyone :grin:. Heyy @derberg.
This PR is to add Release Links to the spec docs
Thank you :grinning:

@derberg Release Note (it should be Notes, not Note) link should be underlined. I also think that the new panel should hasn't borders like we have for here:

Heyyy @magicmatatjahu @derberg @akshatnema ,
I have made those changes, please have a look at those changes.
Thank you :grinning:

@alequetzalli we also have to add a new line which will have a link to all release notes [https://www.asyncapi.com/blog?tags=Release+Notes], as mentioned by @derberg in this comment.
do you have any suggestions?

@Harish-b-03 Did you run code in local env?

Fixed in the last commit.

Yeah I did, It worked. I don't know the reason for this.
Thank you very much for fixing this😁

@Harish-b-03 You had two children (<a> html tag and . string) inside Link component (from nextjs) and it can only have single child.

@alequetzalli please have a look at https://github.com/asyncapi/website/pull/1219#issuecomment-1401195585
otherwise we are ready to accept

@alequetzalli we also have to add a new line which will have a link to all release notes [https://www.asyncapi.com/blog?tags=Release+Notes], as mentioned by @derberg in this comment.
do you have any suggestions?

no sir, this looks good 👍 😊

@alequetzalli

no sir, this looks good 👍 😊

sorry but you mean that in your opinion it is enough to link only to release notes related to given spec version?
now we have in this PR:

but idea is that maybe 👇🏼 would also make sense

correct, my vote is to only link to the release notes of that given spec version
if you want to use the 2nd option, then update the anchor text to include the word list

if you do not object the idea then lets add it 😀
@Harish-b-03 please add sentence Are you interested in release notes of other versions of the specification? Check list of release notes. and list of release notes should be a link to https://www.asyncapi.com/blog?tags=Release+Notes

@derberg have a look at this

Is this ok? or can we have it as

first is good
@alequetzalli what do you think?

first is good
@alequetzalli what do you think?

no, sorry.. the first is too long, and I would only use 2 separate lines because there are 2 core ideas here...
my vote is for the 2nd one  :)

@Harish-b-03 I agree with @alequetzalli opinion. You can make final changes

Heyyyyy @derberg @alequetzalli :wave:
Made the final changes....
Here is the final look:

Heyy @akshatnema @derberg ,
I have made the changes, have a look at it.
Thank you


doc test fails locally

Environment

Qiskit Nature version: 2b18a65ec1af71e6d9c066882afee723e72a8231
Python version: 3.9.7
Operating system: RHEL 8.6

What is happening?
The local documentation check fails.
How can we reproduce the issue?

Make sure your environment is set up properly by running

pip install -r requirements.txt -r requirements-dev.txt -c constraints.txt --upgrade
make clean

Run make html

Result:
...
WARNING: Cannot resolve forward reference in type annotations of "qiskit_nature.problems.sampling.protein_folding.ProteinFoldingProblem.interpret": name 'ProteinFoldingResult' is not defined
WARNING: Cannot resolve forward reference in type annotations of "qiskit_nature.problems.sampling.protein_folding.ProteinFoldingProblem.interpret": name 'ProteinFoldingResult' is not defined
...
build finished with problems, 2 warnings.
make: *** [Makefile:70: html] Error 1

What should happen?
The check should pass.
Any suggestions?
No response

The documentation generation is working fine on the multiple OSs being tested by the CI. You will need to figure out the difference in your setup to determine what is causing this issue.
I suggest that you inspect the Sphinx package versions and make sure they are up to date.

I suggest that you inspect the Sphinx package versions and make sure they are up to date.

I tried to do this using the command
pip install -r requirements.txt -r requirements-dev.txt -c constraints.txt --upgrade

The documentation generation is working fine on the multiple OSs being tested by the CI.

True, but we should also try to ensure it works locally on most common platforms.


node_modules/ava/index.d.ts:5:10 - error TS2339: Property 'observable' does not exist on type 'SymbolConstructor'.

I'm submitting a ...
[*] bug report

Summary
Keep getting the following error when trying to run any node command:

$ npm run watch

><EMAIL_ADDRESS>watch C:\Users\farha\source\repos\typescript-sest
> run-s clean build:main && run-p "build:main -- -w" "test:unit -- --watch"

><EMAIL_ADDRESS>clean C:\Users\farha\source\repos\typescript-sest
> trash build test

><EMAIL_ADDRESS>build:main C:\Users\farha\source\repos\typescript-sest
> tsc -p tsconfig.json

node_modules/ava/index.d.ts:5:10 - error TS2339: Property 'observable' does not exist on type 'SymbolConstructor'.

5  [Symbol.observable](): ObservableLike;
           ~~~~~~~~~~

Found 1 error.

npm ERR! code ELIFECYCLE
npm ERR! errno 2
npm ERR<EMAIL_ADDRESS>build:main: `tsc -p tsconfig.json`
npm ERR! Exit status 2
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>build:main script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\farha\AppData\Roaming\npm-cache\_logs\2020-06-01T17_24_29_671Z-debug.log
ERROR: "build:main" exited with 2.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR<EMAIL_ADDRESS>watch: `run-s clean build:main && run-p "build:main -- -w" "test:unit -- --watch"`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>watch script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR!      C:\Users\farha\AppData\Roaming\npm-cache\_logs\2020-06-01T17_24_29_736Z-debug.log

Yep, having the same issue.

Same error

Looks like updating ava to 3.8.2 and removing the sources in packages.json as explained in this thread https://github.com/bitjson/typescript-starter/issues/228#issuecomment-622985064 fixes this issue.

Hey all – sorry to keep you waiting on this!
The latest version of typescript-starter now upgrades all dependencies (and migrates to eslint, as tslint is now deprecated), so this issue should be fixed. 🚀


Wrong verdict evaluation in node-restart reboot experiment

BUG REPORT
What happened:
Running a node-restart experiment with default REBOOT_COMMAND value "sudo systemctl reboot" we observed that soon after the helper POD is deployed and the node-restart chaos has been injected successfully, the node status check is performed and the update of chaos result is done.
As you can check in the attached log, this happens after 14'' from the start of the experiment
time='2022-08-04T08:04:53Z' level=info msg='Experiment Name: node-restart'
time='2022-08-04T08:05:07Z' level=info msg='[The End]: Updating the chaos result of node-restart experiment (EOT)'
Since the “node-monitor-grace-period” is the time required to Kubernetes Controller Manager to marks the node as Not Ready,
when it's configured to a value higher than 14'' the node status check is performed at wrong time.
In other words Kubernetes Controller Manager has to find the node unhealthy for past “node-monitor-grace-period” (default 40s) before to mark it as Not Ready.
What you expected to happen:
A tunable parameter has to be used in node-restart experiment to define when the check of the node status has to be done according to Kubernetes Controller Manager “node-monitor-grace-period” parameter setting.
A possible solution is to reuse already existing TOTAL_CHAOS_DURATION parameter for this scope, since with current implementation it is meaningless.
How to reproduce it (as minimally and precisely as possible):
Check that Kubernetes Controller Manager “node-monitor-grace-period” has a 40s default value.
Run a node-restart experiment and watch the target node status
( in a terminal: watch -n 1 "kubectl get node | grep ")
From the log experiment verify that the Litmus verdict is set before that the node status is marked as not ready
Experiment log:
my-workflow-1664406871-3897394364.txt
.

Hi @lgelisio,
You can set the RAMP_TIME ENV. Which will enable the experiment to wait for the specified ramp_time after the chaos.
I hope this will solve this issue

Closing this issue as this is duplicate to https://github.com/litmuschaos/litmus-go/issues/528 issue


[Improve] Upgrade to storybook 7

Upgrade to storybook 7
Current version doesnt work with storybook 7

`Hi @AgainstLightning  here is a repo with most custom render function you use, no need any addon
https://github.com/chakAs3/vue3-storybook-custom-render

there is with other implementations
https://github.com/chakAs3/vue3-pinia-storybook
https://github.com/storybookjs/vue3-code-examples

Note: we used this addon successfully with SB7, but it finally broke for us as well with SB8.
I built a new addon that does the same thing, basically from scratch: https://github.com/mihkeleidast/storybook-addon-source


[fixup] cms : remove improper htmls job spec failure

Coverage: 83.029%. Remained the same when pulling 4fae35c175c54415ae824e285351cca505e8bd0a on fix-spec into b1b97f353534ca3da1367e560682321a83d77921 on master.


major ui update

@KarnamShyam1947 once review this and make the changes

@KarnamShyam1947 add home button with its corresponding icon right  here and make use of existing default route for this


declaring the AVS api key as sensitive data

Description
Changes proposed in this pull request:

declared the avs apikey overwrite as sensitive to get it stored in a secret on the cluster rather than a configmap
...
...

Related issue(s)

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

/retest

/retest

/retest

/retest


Issue #1952 - OperationOutcome when search parameters are ignored

Issue #1952 - OperationOutcome when search parameters are ignored
Signed-off-by: Troy Biesterfeld<EMAIL_ADDRESS>

Comments addressed. Ready to merge.


One-liner for creating a connection

Describe the solution you'd like
One command to create a connection with chats/channels, example:
@Miscord add connection-name d 1234 m 5678
From abcasada on Discord

Added in https://github.com/miscord/miscord/commit/46ca9e9d112e44487675d5703faaf5df1f5234be


yarn install error

Hi!
After I run yarn install I'm getting this:
root@ubuntu-s-1vcpu-1gb-fra1-01:/var/www/formula/themes/vuetober# yarn install
yarn install v1.21.1
[1/4] Resolving packages...
[2/4] Fetching packages...
warning<EMAIL_ADDRESS>Invalid bin entry for "sha.js" (in "sha.js").
info<EMAIL_ADDRESS>The platform "linux" is incompatible with this module.
info<EMAIL_ADDRESS>is an optional dependency and failed compatibility check. Excluding it from installation.
error<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version "^8.12.0 || >=9.7.0". Got "8.10.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Can you recommend somtething about it? Thanks

had to update my node and npm. After that issue disapperaed


Difficulties installing with packaged versions of Forge due to pip build isolation

Hi.
Thanks for your hard work on TIPO and its related projects. This is an FYI that from a stock install of Forge using its packaged version of python, the extension cannot install out of the UI (due to a failure to install tipo-kgen).
For demonstration purposes, I have included the log. It appears at some point pip is losing its pythonpath (and with it the reference to the packaged environment and therefore _socket.pyd) - this can be worked around by invoking pip with --no-build-isolation, but this probably won't be obvious to most users. Unfortunately, I don't know enough about packaging to say whether this is something that needs to be fixed in Forge, the kgen package, install.py, or python itself, but I thought perhaps it might be worth mentioning in the documents.
For posterity, a failing install log:
*** Error running install.py for extension E:\XXXXXX XXX\forge\webui\extensions\z-tipo-extension.
*** Command: "E:\XXXXXX XXX\forge\system\python\python.exe" "E:\XXXXXX XXX\forge\webui\extensions\z-tipo-extension\install.py"
*** Error code: 1
*** stdout: Attempting to install tipo_kgen
*** Installing tipo-kgen for DanTagGen
***
*** stderr: E:\XXXXXX XXX\forge\webui\extensions\z-tipo-extension\install.py:2: DeprecationWarning: pkg_resources is deprecated as an API. See https://setuptools.pypa.io/en/latest/pkg_resources.html
***   import pkg_resources
*** Traceback (most recent call last):
***   File "E:\XXXXXX XXX\forge\webui\extensions\z-tipo-extension\install.py", line 53, in <module>
***     install_tipo_kgen()
***   File "E:\XXXXXX XXX\forge\webui\extensions\z-tipo-extension\install.py", line 46, in install_tipo_kgen
***     launch.run_pip(
***   File "E:\XXXXXX XXX\forge\webui\modules\launch_utils.py", line 153, in run_pip
***     return run(f'"{python}" -m pip {command} --prefer-binary{index_url_line}', desc=f"Installing {desc}", errdesc=f"Couldn't install {desc}", live=live)
***   File "E:\XXXXXX XXX\forge\webui\modules\launch_utils.py", line 125, in run
***     raise RuntimeError("\n".join(error_bits))
*** RuntimeError: Couldn't install tipo-kgen for DanTagGen.
*** Command: "E:\XXXXXX XXX\forge\system\python\python.exe" -m pip install -U "tipo-kgen>=0.1.5" --prefer-binary
*** Error code: 2
*** stdout: Collecting tipo-kgen>=0.1.5
***   Using cached tipo_kgen-0.1.5.tar.gz (5.0 MB)
***   Installing build dependencies: started
***   Installing build dependencies: finished with status 'done'
***   Getting requirements to build wheel: started
***   Getting requirements to build wheel: finished with status 'done'
***
*** stderr: ERROR: Exception:
*** Traceback (most recent call last):
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\cli\base_command.py", line 105, in _run_wrapper
***     status = _inner_run()
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\cli\base_command.py", line 96, in _inner_run
***     return self.run(options, args)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\cli\req_command.py", line 67, in wrapper
***     return func(self, options, args)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\commands\install.py", line 379, in run
***     requirement_set = resolver.resolve(
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\resolver.py", line 95, in resolve
***     result = self._result = resolver.resolve(
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_vendor\resolvelib\resolvers.py", line 546, in resolve
***     state = resolution.resolve(requirements, max_rounds=max_rounds)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_vendor\resolvelib\resolvers.py", line 397, in resolve
***     self._add_to_criteria(self.state.criteria, r, parent=None)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_vendor\resolvelib\resolvers.py", line 173, in _add_to_criteria
***     if not criterion.candidates:
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_vendor\resolvelib\structs.py", line 156, in __bool__
***     return bool(self._sequence)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\found_candidates.py", line 174, in __bool__
***     return any(self)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\found_candidates.py", line 162, in <genexpr>
***     return (c for c in iterator if id(c) not in self._incompatible_ids)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\found_candidates.py", line 53, in _iter_built
***     candidate = func()
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\factory.py", line 187, in _make_candidate_from_link
***     base: Optional[BaseCandidate] = self._make_base_candidate_from_link(
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\factory.py", line 233, in _make_base_candidate_from_link
***     self._link_candidate_cache[link] = LinkCandidate(
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 304, in __init__
***     super().__init__(
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 159, in __init__
***     self.dist = self._prepare()
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 236, in _prepare
***     dist = self._prepare_distribution()
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\resolution\resolvelib\candidates.py", line 315, in _prepare_distribution
***     return preparer.prepare_linked_requirement(self._ireq, parallel_builds=True)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\operations\prepare.py", line 527, in prepare_linked_requirement
***     return self._prepare_linked_requirement(req, parallel_builds)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\operations\prepare.py", line 642, in _prepare_linked_requirement
***     dist = _get_prepared_distribution(
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\operations\prepare.py", line 72, in _get_prepared_distribution
***     abstract_dist.prepare_distribution_metadata(
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\distributions\sdist.py", line 56, in prepare_distribution_metadata
***     self._install_build_reqs(finder)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\distributions\sdist.py", line 126, in _install_build_reqs
***     build_reqs = self._get_build_requires_wheel()
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\distributions\sdist.py", line 103, in _get_build_requires_wheel
***     return backend.get_requires_for_build_wheel()
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_internal\utils\misc.py", line 701, in get_requires_for_build_wheel
***     return super().get_requires_for_build_wheel(config_settings=cs)
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_vendor\pyproject_hooks\_impl.py", line 166, in get_requires_for_build_wheel
***     return self._call_hook('get_requires_for_build_wheel', {
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_vendor\pyproject_hooks\_impl.py", line 321, in _call_hook
***     raise BackendUnavailable(data.get('traceback', ''))
*** pip._vendor.pyproject_hooks._impl.BackendUnavailable: Traceback (most recent call last):
***   File "E:\XXXXXX XXX\forge\system\python\lib\site-packages\pip\_vendor\pyproject_hooks\_in_process\_in_process.py", line 77, in _build_backend
***     obj = import_module(mod_path)
***   File "importlib\__init__.py", line 126, in import_module
***   File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
***   File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
***   File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
***   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
***   File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
***   File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
***   File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
***   File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
***   File "<frozen importlib._bootstrap_external>", line 883, in exec_module
***   File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
***   File "C:\Users\curious\AppData\Local\Temp\pip-build-env-72wxwtd9\overlay\Lib\site-packages\setuptools\__init__.py", line 27, in <module>
***     from .dist import Distribution
***   File "C:\Users\curious\AppData\Local\Temp\pip-build-env-72wxwtd9\overlay\Lib\site-packages\setuptools\dist.py", line 19, in <module>
***     from . import (
***   File "C:\Users\curious\AppData\Local\Temp\pip-build-env-72wxwtd9\overlay\Lib\site-packages\setuptools\_entry_points.py", line 6, in <module>
***     from jaraco.text import yield_lines
***   File "C:\Users\curious\AppData\Local\Temp\pip-build-env-72wxwtd9\overlay\Lib\site-packages\setuptools\_vendor\jaraco\text\__init__.py", line 12, in <module>
***     from jaraco.context import ExceptionTrap
***   File "C:\Users\curious\AppData\Local\Temp\pip-build-env-72wxwtd9\overlay\Lib\site-packages\setuptools\_vendor\jaraco\context.py", line 11, in <module>
***     import urllib.request
***   File "urllib\request.py", line 88, in <module>
***   File "http\client.py", line 71, in <module>
***   File "email\parser.py", line 12, in <module>
***   File "email\feedparser.py", line 27, in <module>
***   File "email\_policybase.py", line 9, in <module>
***   File "email\utils.py", line 29, in <module>
***   File "socket.py", line 51, in <module>
*** ModuleNotFoundError: No module named '_socket'
***
***

For anyone that wants a copy paste:
def install_tipo_kgen():     version = get_installed_version("tipo-kgen")     if version is not None and version >= KGEN_VERSION:         return     print("Attempting to install tipo_kgen")     launch.run_pip(         f'install -U "tipo-kgen>={KGEN_VERSION}" --prefer-binary --no-build-isolation',         "tipo-kgen for DanTagGen",     )


Change starting hour in day view

Apologies if this has been requested previously, but is it possible to change the start time in day view from 1am to something else?

Would really love to see this functionality built in please!

#57

Just realized I was the one who initially asked this question and forgot 😅🤦🏻♀


Add GraphQL cheatsheet

What does this PR do?

Add GraphQL cheatsheet

For resources
Description
Why is this valuable (or not)?
How do we know it's really free?
For book lists, is it a book? For course lists, is it a course? etc.
Checklist:

[x] Read our contributing guidelines.
[x] Search for duplicates.
[x] Include author(s) and platform where appropriate.
[x] Put lists in alphabetical order, correct spacing.
[x] Add needed indications (PDF, access notes, under construction).
[x] Used an informative name for this pull request.

Follow-up

Check the status of GitHub Actions and resolve any reported warnings!

closes #7975
Hi @davorpa & @eshellman ,
Kindly review it.
One request:
Kindly add a hacktoberfest-accepted label to my PRs so that it will get updated in my hacktoberfest profile .
https://hacktoberfest.com/profile/


Update AMIs for Artemis engine

Description

Updated images from "amzn2-ami-kernel-5.10-hvm-2.0.20220426.0-x86_64-gp2" to "amzn2-ami-kernel-5.10-hvm-2.0.20230404.0-x86_64-gp2"
Motivation and Context

This reduces vulnerabilities
How Has This Been Tested?

Ran scans with both old and new images deployed and compared results. There seem to be no inconsistencies.
Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[x] My code follows conforms to the coding standards.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


Logging and init files

Added __init__ files where appropriate.
Implemented a Loggable mixin class to inject loggers into the namespace.
Changed prints to logger.xxx calls.
Can we just double check this is all valid, as I haven't got a working interpreter on me to test any of this out on. I have made sure to triple check, but just to be safe...
Ta ^^

merged

closes #11


Collection not defined

I have a problem with FilesCollection not working properly.
It seems that the new 'FilesCollection' that I created is not defined on the client side for some strange reason. When I try to import the collection directly, the kadira:flowrouter throws me an error.
To be more specific:
My file structure:
/.meteor
/client
---FileUpload.jsx
/collections
---Files.js
/node_modules
/public
---/uploads
/server

For the shared code in Files.js:
import { FilesCollection } from 'meteor/ostrio:files';

var Files = new FilesCollection({
  collectionName: 'Files',
  allowClientCode: false, // Disallow remove files from Client
  storagePath: "./../public/uploads",
  onBeforeUpload: function (file) {
    // Allow upload files under 10MB, and only in png/jpg/jpeg formats
    if (file.size <= 10485760 && /png|jpg|jpeg|mp3|gif|wav/i.test(file.extension)) {
      return true;
    } else {
      return 'Please upload image, with size equal or less than 10MB';
    }
  }
})

And for FileUpload.jsx:
import React, {Component} from 'react';
import {Meteor} from 'meteor/meteor';

export default class FileUpload extends Component {

	onUpload(event) {
		if (event.currentTarget.files && event.currentTarget.files[0]) {
		      // We upload only one file, in case
		      // multiple files were selected
		      var upload = Files.insert({
		        file: event.currentTarget.files[0],
		        streams: 'dynamic',
		        chunkSize: 'dynamic'
		      }, false);

		      upload.start();
		}
	}

	render() {
		return (

				<input type="file" onChange={this.onUpload.bind(this)} />

		)
	}

}

Then the console throws me an error: 'ReferenceError: Files is not defined'.
One thing that I do know for sure is that the collection is PRESENT because it shows up in Mongol.
If I import 'var Files' directly using 'import' Flowrouter throws me an error....
Please help me with this issue, I've been working on it for hours and can't figure out why it's doing this.

Files is undefined, because u use var, its not a global var.
try remove var or import / require
Files = new FilesCollection({
  collectionName: 'Files',
  allowClientCode: false, // Disallow remove files from Client
  storagePath: "./../public/uploads",
  onBeforeUpload: function (file) {
    // Allow upload files under 10MB, and only in png/jpg/jpeg formats
    if (file.size <= 10485760 && /png|jpg|jpeg|mp3|gif|wav/i.test(file.extension)) {
      return true;
    } else {
      return 'Please upload image, with size equal or less than 10MB';
    }
  }
})

export default Files

import React, {Component} from 'react';
import {Meteor} from 'meteor/meteor';

import Files from './where your export your files'

export default class FileUpload extends Component {

	onUpload(event) {
		if (event.currentTarget.files && event.currentTarget.files[0]) {
		      // We upload only one file, in case
		      // multiple files were selected
		      var upload = Files.insert({
		        file: event.currentTarget.files[0],
		        streams: 'dynamic',
		        chunkSize: 'dynamic'
		      }, false);

		      upload.start();
		}
	}

	render() {
		return (

				<input type="file" onChange={this.onUpload.bind(this)} />

		)
	}

}

Hello @RE-N-Y
Is this issue solved? Looks like solution by @crapthings is correct.
Anyways, you can always check if variable is in global scope - by simply typing variable name into browser console.

Thank you for the response. It's working now!


Image mask should be an argument to generate.py

I think "image mask engineering" is going to be about as equally important as people are finding prompt engineering. It's widely used in the Open AI blog post. Anyway, per usual my scatterbrain is constantly editing code and forgetting to upstream if it's worthwhile - here's a partial diff so I don't forget to merge this or if anyone else wants to I don't mind.
+parser.add_argument('--image_mask_path', type = str, help='Path to image to pass in as a mask during generation.')
+
 parser.add_argument('--hug', dest='hug', action = 'store_true')

 parser.add_argument('--chinese', dest='chinese', action = 'store_true')
@@ -51,6 +54,17 @@ parser.add_argument('--taming', dest='taming', action='store_true')

 args = parser.parse_args()

+image_mask_path = Path(args.image_mask_path)
+assert image_mask_path.exists(), f'{args.image_mask_path} could not be found.'
+
+pil_image = Image.open(image_mask_path)
+image_transform = T.Compose([
+    T.Lambda(lambda img: img.convert("RGB") if img.mode != "RGB" else img),
+    T.RandomResizedCrop(256, scale=(1.0, 1.0), ratio=(1.0, 1.0)),
+    T.ToTensor(),
+])
+image_mask = image_transform(pil_image).cuda()
+image_mask_batch = image_mask.repeat(args.batch_size,1,1,1)
 # helper fns

 def exists(val):
@@ -101,7 +115,7 @@ for text in tqdm(texts):
     outputs = []

     for text_chunk in tqdm(text.split(args.batch_size), desc = f'generating images for - {text}'):
-        output = dalle.generate_images(text_chunk, filter_thres = args.top_k)
+        output = dalle.generate_images(text_chunk, filter_thres = args.top_k, img=image_mask_batch)
         outputs.append(output)

     outputs = torch.cat(outputs)

@lucidrains How easy/possible would it be to use a custom mask? perhaps the target format could be whatever the typical coco-style segmentation data looks like; and then maybe you could abstract something on top of that which can generate a segment from e.g. a white background? Or even better; the inverse of the white background so e.g. the shape of the "mannequin" or what-not is all that is left unmasked.


I want Topo lines on the main map

Really wish MapKit had this. If we move to mapbox for the general map to get topo lines we'll have to implement a different map download pattern for tiles instead of individual canyons like we have today.

As part of https://github.com/OpenCanyon/api/issues/21 I am going to start putting together a custom Mapbox style for our data

As part of the conversion to https://github.com/CanyoneerApp we will need to move towards the Mapbox tiles so we can show topo lines on the map again.


Fix sidebar not closing after navigation

@Joozty I am not sure this solution is good. Do you have in mind anything better?

Finally, somebody looked into this.
What about something like this. It also handles the case when the user clicks outside of the sidebar. (I haven't tested it properly but you probably see my point)
import React, { useContext, useRef, useEffect } from 'react'
import { AppBar } from '@oacore/design'
import { classNames } from '@oacore/design/lib/utils'

import LayoutContext from './context'
import styles from './styles.css'

import { Logo, CloseIcon } from 'design'

const SideBar = ({
  children,
  className,
  tag: Tag = 'nav',
  id, // prevent passing ID to element attributes
  onClick,
  ...restProps
}) => {
  const [state, dispatch] = useContext(LayoutContext)
  const sidebarRef = useRef(null)

  useEffect(() => {
    if (state.sidebarOpen) sidebarRef.current.focus()
    else sidebarRef.current.blur()
  }, [state.sidebarOpen])

  const handleClick = event => {
    if (onClick) onClick(event)
  }

  return (
    <Tag
      ref={sidebarRef}
      id={state.sidebarId}
      className={classNames
        .use(styles['side-bar'], state.sidebarOpen && styles.open)
        .join(className)}
      onClick={handleClick}
      onBlur={() => dispatch({ type: 'toggle_sidebar' })}
      tabIndex="0"
      {...restProps}
    >
      <AppBar className={styles.sideBarHeader}>
        <AppBar.Brand className={styles.sideBarHeaderBrand} href="/">
          <Logo />
        </AppBar.Brand>
        <AppBar.Item type="button" tag="button">
          <CloseIcon aria-label="Close sidebar" />
        </AppBar.Item>
      </AppBar>

      {children}
    </Tag>
  )
}

export default SideBar

@Joozty the blur event would not work, it's only for control elements such as inputs and buttons, also it does not bubble. The sidebar is a regular element which does not receive focus even if elements inside it do.
I would keep it as is and I will create an issue to handle click outside too.

That's why added there tabIndex="-1". I tested it a little bit the other day and it worked just fine.

@Joozty does not work for me, could you please check 506c11f for mistakes?

@Joozty it was worth to try but I do not go this way and keep the solution as it was before with the following creating an issue about handling clicks outside. I share the solution with you, sou you can access the preview and test yourself:

try to navigate using Tab key; you will not be able to access individual links on the sidebar
try to close sidebar using the close icon and then change the data provider; the sidebar unexpectedly opens

I removed the commit but I experience the same behaviour as it was before 😕

@Joozty can you please take this one?

I retested this and do not see anymore the issues I faced before. I am merging this


[v2.0.0-alpha.42] Regressions on Web: 1) Cannot navigate back; and 2) Cards disappear if transition duration too short

This is a Web-specific regression issue; mobile still seems to be handling fine.

I am trying to do zero-duration transitions. This was reliable on all platforms in v1, but in v2, on Web, the cards (or screens – I don't really know what is what) just disappear if the animation duration is too short.

Furthermore, on Web, I am unable to navigate back from any of the routes I push.

I have used the same TransparentScreen component as written for the Stack v2 examples (although I was unsure how best to port the navigationOptions, as cardStyle and cardStyleInterpolator do not exist in v1).
Here are my Snacks for v1 and v2; just click on "Open transparent modal" to test the inability to navigate back, and "Switch to second screen" to test zero-duration transitions (you may find that some of the functionality restores if you increase the transition duration above 0):
https://snack.expo.io/@bottledlogic/react-navigation-stack-v1-transparent-modal
https://snack.expo.io/@bottledlogic/react-navigation-stack-v2-transparent-modal
Stack v1 behaviour
Snack's package.json:
{
  "dependencies": {
    "react-navigation": "4.0.10",
    "react-native-screens": "^1.0.0-alpha",
    "react-navigation-stack": "1.10.3",
    "react-native-gesture-handler": "^1.0.0"
  }
}

iOS

iOS: 13.1.3
Expo client: <IP_ADDRESS>621
Supported SDKs: 33, 34, 35, 36

❌ The screen below that of TransparentScreen is not displayed, but I've filed a separate issue for that: #316
✅ Zero-duration animations work.
✅ Navigating back from either screen works.
Web

Google Chrome 79.0.3945.88
Using snack.expo.io to view the Snack in-browser.

❌ The screen below that of TransparentScreen is not displayed, but I've filed a separate issue for that: #316
✅ Zero-duration animations work.
✅ Navigating back from either screen works.
Stack v2 behaviour
Snack's package.json:
{
  "dependencies": {
    "react-navigation": "4.0.10",
    "react-native-screens": "^2.0.0-alpha",
    "react-navigation-stack": "2.0.0-alpha.42",
    "@react-native-community/masked-view": "^0.1.1",
    "react-native-gesture-handler": "^1.0.0",
    "react-native-reanimated": "^1.3.0-alpha",
    "react-native-safe-area-context": "^0.3.3"
  }
}

iOS

iOS: 13.1.3
Expo client: <IP_ADDRESS>621
Supported SDKs: 33, 34, 35, 36

✅ The screen below that of TransparentScreen is displayed.
✅ Zero-duration animations work.
✅ Navigating back from either screen works.
Web

Google Chrome 79.0.3945.88
Using snack.expo.io to view the Snack in-browser.

✅ The screen below that of TransparentScreen is displayed.
❌ Zero-duration animations do not work.
❌ Navigating back from either screen does not work.

These regressions are blocking me from migrating to Stack v2.

Can you repro this with latest stable version?

@satya164 I've generated a new Snack to test the latest stable version, 2.0.8:
<EMAIL_ADDRESS>Stack v2.0.8 behaviour
Snack's package.json:
{
  "dependencies": {
    "react-native-reanimated": "1.4.0",
    "react-navigation-stack": "2.0.8",
    "@react-native-community/masked-view": "^0.1.1",
    "react-native-gesture-handler": "^1.5.0",
    "react-native-safe-area-context": "^0.6.0",
    "react-native-screens": "^2.0.0-alpha.20",
    "react-navigation": "^4.0.10"
  }
}

iOS

iOS: 13.1.3
Expo client: <IP_ADDRESS>621
Supported SDKs: 33, 34, 35, 36

✅ The screen below that of TransparentScreen is displayed.
✅ Zero-duration animations work.
✅ Navigating back from either screen works.
Web

Google Chrome 79.0.3945.88
Using snack.expo.io to view the Snack in-browser.

✅ The screen below that of TransparentScreen is displayed.
✅ Zero-duration animations work.
✅ Navigating back from either screen works.

Great to see this all working now – I should be able to migrate to Stack v2 now 🥳 thanks for all your hard and thorough work on this! My Satyajit stonks are soaring. 🙂


Fix ui library not using Config.Size

don't think this is an issue? setting .Size in :CreateWindow works fine for me since LeftSide and RightSide just inherit their size from the parent

don't think this is an issue? setting .Size in :CreateWindow works fine for me since LeftSide and RightSide just inherit their size from the parent

Try setting the Size when creating a window to something like 300, 400
The tab content will go outside of the tab


Reload when config is updated

How to reload when the config is updated?

Hi @jackiepg12, there's (currently) no support for reloading the config on the fly - either automatically or via a signal. The config is only read on startup, so if you need to modify it, you'll need to restart the exporter.
If you'd like to work on a config reload feature, I'd be happy to discuss how it might work?

@jackiepg12 best way to reload the config is just redeploy the exporter or kill the pod. This is pretty common with many apps when it comes to initializing config at runtime.

@jackiepg12
if you use Kubernetes, maybe stakater-reloader can help you.

+2 on stakater-reloader . we have this and it works great

@opsforce @jonny-wg2  Could you  please give a example ?

The reloader docs will help.
But here you go
apiVersion: apps/v1
kind: Deployment
metadata:
  name: es-exporter
  namespace: monitoring
  annotations:
    configmap.reloader.stakater.com/reload: "es-exporter"
    flux.weave.works/automated: "true"
spec:

@braedon I think this definitely a plus. I had this requirement today, and had a look at the code. Shouldn't be too hard to implement, if I get around at learning how to reset the scheduler from scratch. I'm wondering if you have any thoughts on the best way forward?
Currently, this is what I'm doing:

I have an initContainer with kiwigrid/k8s-sidecar (quick reading through stakater-reloader doesn't seem to be able to save the files?) which will dump all relevant configmaps into a folder (config-dir);
Then the prometheus-es-exporter starts, and it will handle errors via PR #98
Together with the exporter, I keep a sidecar (also kiwigrid/k8s-sidecar) monitoring for changes, and when there are changes, it triggers a pod restart;

So far, seems to work well.... but it's definitely more convoluted than a simple SIGHUP or dnotify...


1.26 Insider: Terminal selection scrolls up and down with the terminal itself

Issue Type: Bug
When scrolling up and down the terminal any selection made before is lost, because the selection seems to registered around the buffer of the rendered terminal and not the actual terminal buffer.

This issue is only reproducible in the current Insider version. For reference, this is what behavior the user expects:

This is a freshly downloaded VSCode downloaded via chocolatey install vscode.
VS Code version: Code - Insiders 1.26.0-insider (bd953248ad6a8e2f8896bfb78b3ae40e0fd47426, 2018-07-06T05:17:37.386Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-7567U CPU @ 3.50GHz (4 x 3504)

GPU Status
2d_canvas: enabledflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: disabled_softwarevideo_decode: enabledvideo_encode: enabledvpx_decode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
15.89GB (6.26GB free)

Process Argv
C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe

Screen Reader
no

VM
0%

Extensions (16)

Extension
Author (truncated)
Version

path-intellisense
chr
1.4.2

vscode-markdownlint
Dav
0.18.0

docs-article-templates
doc
0.1.2

docs-authoring-pack
doc
0.1.1

docs-markdown
doc
0.1.1

docs-preview
doc
0.3.12

xml
Dot
2.3.1

gitlens
eam
8.4.1

beautify
Hoo
1.3.2

csharp
ms-
1.15.2

PowerShell
ms-
1.7.0

vscode-docker
Pet
0.0.27

vscode-yaml
red
0.0.13

vscode-icons
rob
7.24.0

code-spell-checker
str
1.6.10

msbuild-project-tools
tin
0.2.39

Whoa, that's bad o.0 It was probably related to column selection which just got pulled in (alt+click). Looking into it now.

Will verify asap ;)

Is deployment currently disabled?

@MeikTranel it's a "nightly" build which builds Monday-Friday Zurich morning. This time was chosen so we can react if there is a major issue with the build.

oh. huh so the checkmarks are just merge check builds that deploy nothing?

Yeah. Deploying on every commit wouldn't be feasible; people would have to update constantly and release builds also take 30-60 minutes to build.

but... but... why am i getting all these 💄 refactoring commit updates ? 😺

Exactly 😛
We actually had complaints in the past about too many updates on Windows. Since then we've made it less annoying to update on Windows 😃

i can verify this is fixed now.


Vary ELB port based on presence of TLSCert

If a certificate is provided we can assume the application should connect over HTTPS. This was already being done for the protocol, but not the port.
Sadly, mappings have to be literal values (not the result of functions) so this logic has to be duplicated everywhere it is used.
I've run validate-template on it, but I've not deployed it to a stack to check it.

(forced update to remove the empty line changes, they might have broken the userdata)
Do you want this checked on a real stack before it's merged, @TBonnin or are you happy as is?

I am happy as is. 🚢


Add new image size preview.

This is the initial implementation for the image size preview as suggested in #14.
Please review the code and tell me what you think.
I also want to make the colors configurable (so maybe don't merge yet).

Code looks excellent.
Image should be centered vertically with respect to workspace, not window. Relevant code is in the scope // Center canvas in papaya_core.cpp. There is one magic number in there, but I'll be cleaning up the layout constants in code at some point in the future, so feel free to duplicate that constant for now.
Also, feel free to  tweak the new preview shader if you fancy a different look.

I fixed the centering and made the colors configurable. You can merge now, if you want to :)

Thanks for the contribution!


Hardcoded /etc/ config directory

Why you hardcoded /etc/ directory for configs, how about Windows ?

Because I don't plan to support Windows.


support parsing command bodies using standard templates

Signed-off-by: R.I.Pienaar<EMAIL_ADDRESS>

Using {{.Request}} within the --command exec also seems to be not working:
% nats reply x --command='echo {{.Request}}'

% nats req x 'hello world'
14:35:32 Sending request on "x"
14:35:32 Received with rtt 44.290153ms
{{.Request}}

not seeing:
% bin/nats reply 'weather.>' --command "curl -s wttr.in/{{.Request}}?format=3" -H Backend:LON
12:36:56 Listening on "weather.>" in group "NATS-RPLY-22"
12:36:58 [#0] Received on subject "weather.lon":

lon

% bin/nats req weather.lon lon
12:37:39 Sending request on "weather.lon"
12:37:39 Received with rtt 55.871219ms
12:37:39 Backend: LON

lon: ⛅  +14°C

old style token place holders also still work

oh wait... I have to check my binary-version :-(

Yes. your are right... I did the test with the wrong build. sorry for the noise....

no worries :)


Protocol Buffer update for release 2.3.x at Thu Apr 29 17:01:43 UTC 2021

Don't merge it, there's a mistake in there...


Link checker recognizes a link to Google Map as internal link

Describe the Bug

It seems link checker sometimes recognises a link to Google Map as internal link.
Steps to Reproduce

Go to https://admin.integreat-app.de/lk-emmendingen/analytics/linkcheck/invalid/?page=2
Find a link with linktext "Hauptstraße 15, 79341 Kenzingen"
See "https://integreat.app/Hauptstraße" in the URL column
Go to the source page
Find "https://www.google.com/maps/place/Hauptstraße+15,+79341+Kenzingen/@48.1918235,7.7665451,17z/data=!3m1!4b1!4m6!3m5!1s0x47913cec05b5a17f:0xe65c8600197c8b17!8m2!3d48.19182!4d7.76912!16s%2Fg%2F11c5fw72pv?entry=ttu" in the link in the editor.

Expected Behavior

The link to Google Map should be recognised as an external link.
Actual Behavior

The link to Google Map is somehow recognised as an internal link.
Additional Information

Traceback

@MizukiTemma Thanks a lot for creating the issue! I'm sorry, but apparently this was a false alarm, I checked all existing translations of this page, and older versions really contain this link:
In [10]: Page.objects.get(id=14442).translations.filter(content__icontains="https://integreat.app/Hauptstra").first().content
Out[10]: '... Hauptstraße 15, 79341 Kenzingen ...'

So it was not the CMS that's at fault for not recognizing the Google maps link here.
The problem is more that links of old versions are shown in the link checker - which is a result from an inconsistent database.
Unfortunately, we can't really prevent this at the moment, since the link checker library itself is not race condition safe (see https://github.com/DjangoAdminHackers/django-linkcheck/issues/168).
For the moment, I'm going to close this and create an infrastructure task to rescan the link db.


Fix code scanning alert - SQL query built from user-controlled sources

Tracking issue for:

[x] https://github.com/mrpapawheelie/skills-introduction-to-codeql/security/code-scanning/2

issue

fixed


Customisable domain

Since Kano will usually be deployed with Kargo it should not be attached to a particular domain except for demo purpose. We should add an environment variable for the domain attached to Kargo that will be used by Kano and Weacast instances.

Layers should also be configured to access data on the Kargo domain.


No version 0.2 shown on github, but hacs....

So Hacs is saying v0.0.2 is available, so I updated and it broke my keymaster and ozw .... I come here and see that the v0.0.19 is the current release...  I have not selected to receive any betas and there is no way to say I would or would not want betas to show like in the addon store of HA.
Mentioning this as it made for a bit of frustration and maybe can save others the same headache.
Love the way keymaster currently works and am looking to switch to zwave_js soon... :D
Thanks for all the hardwork you've put into this project, It is a great addon.

What version of Home Assistant are you running? If you are running the latest you should be able to update to the latest version

I have the current version, but somehow it got botched and I reset my vm snapshot and then reupdated the home assistant core and hacs and voila, it is solved.... Thank you for the quick reply...


Enhance documentation on the usage of a single SQLite database file (e.g. on a network share) by multiple k3s instances (e.g. on different machines)

First of all: Thanks a lot for k3s.
Is your feature request related to a problem? Please describe.
I'm looking for a lightweight way to have the k3s datastore data maintained on an existing network storage solution. This should allow me to set up a HA cluster on two (older) Raspberry Pis that are in the same local network as the network storage solution.
While the network storage solution can be considered HA in this context, it is a "dumb" one, i.e. it only provides a network share. It's impossible to install anything on the device that provides the network storage solution, so MySQL/MariaDB/PostgreSQL are out of the question. I also want to avoid running ethd on the Raspberry Pis because 1) there are only two of them, so no quorum, 2) the less overhead these old devices have, the more they can focus actually on running useful processes, and 3) the network share is already there - so why not try to make use of it.
Describe the solution you'd like
While digging through the source code of k3s and kine, I realized that you can provide something like sqlite://<your_path> as the k3s datastore endpoint. Since SQLite provies a filesystem-based locking mechanism, I assume that you could run multiple k3s processes on the same SQLite file.
Consequently, I plan on mounting the network share provided by the existing network storage solution on both devices at /mnt/k3s-datastore and providing sqlite:///mnt/k3s-datastore/k3s-sqlite.db (sic!) as the datastore endpoint to k3s.
Now I wonder if such a setup would work and is supported.
Additional Context:
The documentation for the datastore endpoint format and functionality does not contain any information on the sqlite://<your_path> datastore endpoint syntax,. It also does not contain information how k3s instances behave if they share the very same SQLite file.
"Feature" request
This feature request is primarily about enhancing the documentation, primarily on the page https://rancher.com/docs/k3s/latest/en/installation/datastore/
With this ticket, I request as a "feature" to enhance the documentation to

give a hint about the possibility to change the SQLite database location by using the sqlite://<your_path> datastore endpoint syntax, and
provide information if a cross-instance database file sharing setup as described here is somewhere along the lines of a) recommended, b) supported, c) possible, d) dangerous, e) nonfunctional.

Looking forward to your comments & questions.

No, you cannot run multiple servers against a single sqlite database file. File-level locking challenges aside, k3s itself disables some unnecessary Kubernetes locking functionality when run with sqlite, since it knows it will be the only server in the cluster.

Thank you for the very fast response. I found two aspects that make datastore endpoint configurations result in different behavior for SQLite:
a) Write-Ahead Journal
dataSourceName = "./db/state.db?_journal=WAL&cache=shared" in sqlite.go -> NewVariant(). However, if you provide your own sqlite datastore endpoint, this line will actually not be run, so the default rollback journal configuration will be used instead of the WAL configuration. So this is not a factor for the use case of this issue.
b) Leader Election Disabling
	switch driver {
	case SQLiteBackend:
		leaderElect = false
		backend, err = sqlite.New(ctx, dsn, cfg.ConnectionPoolConfig)

in endpoint.go -> getKineStorageBackend(), so the leader election process gets deactivated when using SQLite.
You wrote:

k3s itself disables some unnecessary Kubernetes locking functionality when run with sqlite

I assume that you are referring to the latter aspect, i.e. the disabling of the leader election process, right? Or is there more to this that I did not find?
In case the leader election process remains the only blocking point for this use case: Would you accept a pull request that adds an option to k3s that allows you to decide if you want to have the leader election process active or inactive?

I don't think I'd want to support it. There are just too many opportunities for breakage with a highly loaded sqlite database on nfs, where you're reliant on frequently flakey shared locking behavior.
If you have a 3rd server that you can use to host the shared filesystem, you should also be run a small database instance on there and point the two servers at it. Failing that, I would probably just make one node a server, the other an agent, and use the 3rd server to host NFS persistent volumes.

Understood. Thank you.
Initially, I was assuming that only the leading kine instance interacts with the database server. If this was the case, there would actually not have been any parallel write processing during normal operation (but maybe some parallelism after the leader goes down).
Now that I browsed through kine's code a little further, I question this initial assumption. Did I get it correctly that all kine instances interact with the database server? So the "leadership election" process only takes place for the sake of fulfilling the framing conditions as given by the original etcd implementation?
If this is the case, I understand your concerns.


Enhanced RDoc for Table::Row

Methods:

header_row?
field_row?
headers
field
fetch
has_key?

Thanks!


RFC Removal of default permissions

Proposal
Can we remove invenio_records.permissions module as it is not recommended for large repositories to store per record access rights in invenio-access?
--
cc @inveniosoftware/triagers

Indeed, we may want to recommend to use the collection concept instead. Note that this is touching the forthcoming "Invenio 3 Beta Access" sprint on how the recommended access control may look like; hopefully uniformly across services. E.g. CDS started to experiment with an alternative approach to collections... https://github.com/CERNDocumentServer/cds/pull/160#issuecomment-229615330

@jirikuncar I understand the need to remove the permission per record as it would bloat the database. However having a permission for reading, updating, deleting, creating ALL records can be useful. That way it is possible to create custom admin roles.
@tiborsimko I would be interested to see the suggested designs for permissions. We started some time ago a specification document for the permissions in B2Share. I would like to see how well these designs match our needs.
The code I see in the mentioned PR looks like what we where doing for the CloudView search engine and it worked well for search filtering.

Ok for removing the permissions from invenio-records. As there are different kind of records (ex: deposits), having generic records permissions does not make sense anymore.

I'd be also in favour of decoupling permissions better... But let's see @lnielsen's original use case for including it here and @egabancho`s  RFC https://github.com/inveniosoftware/invenio-access/issues/70

I think we can remove it, but I would appreciate if you could test out #138 on Zenodo. Basically, install Zenodo with #138, and run the tests.
Just to ensure that there's no collateral damage from making this change.


Add addSubkeyBindingCertification method to PGPPublicKey

Hi!
This is the first of (probably) a series of pull requests that aim to upstream some of the useful changes the OpenKeychain project made in their fork of bouncycastle.
This PR adds the method addSubkeyBindingCertification to PGPPublicKey which enables the user to add subkeys to existing PGPPublicKeyRings. This is to my knowledge not possible without this change.

I see that https://github.com/bcgit/bc-java/commit/8ff0b3ba07f0bc627469f5d8b28964de709fc426 added support for adding subkeys to key rings in a different way. I guess that makes this PR obsolete?