Size and CombinedNMS Op support request for tflite

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
TensorFlow installed from (source or binary): binary (pip)
TensorFlow version (or github SHA if from source): 2.0.0

Provide the text output from tflite_convert
2019-10-04 16:17:28.794407: I tensorflow/stream_executor/platform/default/dso_loader.cc:44] Successfully opened dynamic library libcuda.so.1
2019-10-04 16:17:28.798220: E tensorflow/stream_executor/cuda/cuda_driver.cc:318] failed call to cuInit: CUDA_ERROR_NO_DEVICE: no CUDA-capable device is detected
2019-10-04 16:17:28.798242: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:169] retrieving CUDA diagnostic information for host: WD-AI-lab
2019-10-04 16:17:28.798246: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:176] hostname: WD-AI-lab
2019-10-04 16:17:28.798282: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:200] libcuda reported version is: 430.26.0
2019-10-04 16:17:28.798299: I tensorflow/stream_executor/cuda/cuda_diagnostics.cc:204] kernel reported version is: 396.51.0
2019-10-04 16:17:28.798303: E tensorflow/stream_executor/cuda/cuda_diagnostics.cc:313] kernel version 396.51.0 does not match DSO version 430.26.0 -- cannot find working devices in this configuration
2019-10-04 16:17:28.798415: I tensorflow/core/platform/cpu_feature_guard.cc:142] Your CPU supports instructions that this TensorFlow binary was not compiled to use: AVX2 FMA
2019-10-04 16:17:28.821484: I tensorflow/core/platform/profile_utils/cpu_utils.cc:94] CPU Frequency:<PHONE_NUMBER> Hz
2019-10-04 16:17:28.822257: I tensorflow/compiler/xla/service/service.cc:168] XLA service 0x5563ee4031d0 executing computations on platform Host. Devices:
2019-10-04 16:17:28.822268: I tensorflow/compiler/xla/service/service.cc:175]   StreamExecutor device (0): Host, Default Version
2019-10-04 16:17:32.842974: I tensorflow/core/grappler/devices.cc:55] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0
2019-10-04 16:17:32.843029: I tensorflow/core/grappler/clusters/single_machine.cc:356] Starting new session
2019-10-04 16:17:32.858437: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:716] Optimization results for grappler item: graph_to_optimize
2019-10-04 16:17:32.858454: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   function_optimizer: function_optimizer did nothing. time = 0.003ms.
2019-10-04 16:17:32.858458: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   function_optimizer: function_optimizer did nothing. time = 0ms.
2019-10-04 16:17:35.240170: I tensorflow/core/grappler/devices.cc:55] Number of eligible GPUs (core count >= 8, compute capability >= 0.0): 0
2019-10-04 16:17:35.240264: I tensorflow/core/grappler/clusters/single_machine.cc:356] Starting new session
2019-10-04 16:17:35.995629: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:716] Optimization results for grappler item: graph_to_optimize
2019-10-04 16:17:35.995652: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   constant folding: Graph size after: 1001 nodes (-358), 2553 edges (-358), time = 346.923ms.
2019-10-04 16:17:35.995656: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:718]   constant folding: Graph size after: 1001 nodes (0), 2553 edges (0), time = 114.777ms.
Traceback (most recent call last):
  File "/home/wd_ai/git-pkgs/yolov3-tf2/convert_tflite.py", line 29, in <module>
    app.run(main)
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/absl/app.py", line 299, in run
    _run_main(main, args)
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/absl/app.py", line 250, in _run_main
    sys.exit(main(argv))
  File "/home/wd_ai/git-pkgs/yolov3-tf2/convert_tflite.py", line 24, in main
    tflite_model = converter.convert()
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/tensorflow_core/lite/python/lite.py", line 446, in convert
    **converter_kwargs)
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/tensorflow_core/lite/python/convert.py", line 449, in toco_convert_impl
    enable_mlir_converter=enable_mlir_converter)
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/tensorflow_core/lite/python/convert.py", line 200, in toco_convert_protos
    raise ConverterError("See console for info.\n%s\n%s\n" % (stdout, stderr))
tensorflow.lite.python.convert.ConverterError: See console for info.
2019-10-04 16:17:37.744297: I tensorflow/lite/toco/import_tensorflow.cc:659] Converting unsupported operation: Size
2019-10-04 16:17:37.744348: I tensorflow/lite/toco/import_tensorflow.cc:659] Converting unsupported operation: Size
2019-10-04 16:17:37.744519: I tensorflow/lite/toco/import_tensorflow.cc:659] Converting unsupported operation: Size
2019-10-04 16:17:37.744542: I tensorflow/lite/toco/import_tensorflow.cc:659] Converting unsupported operation: Size
2019-10-04 16:17:37.744676: I tensorflow/lite/toco/import_tensorflow.cc:659] Converting unsupported operation: Size
2019-10-04 16:17:37.744683: I tensorflow/lite/toco/import_tensorflow.cc:659] Converting unsupported operation: Size
2019-10-04 16:17:37.744759: I tensorflow/lite/toco/import_tensorflow.cc:659] Converting unsupported operation: CombinedNonMaxSuppression
2019-10-04 16:17:37.757406: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before Removing unused ops: 743 operators, 1376 arrays (0 quantized)
2019-10-04 16:17:37.767372: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before general graph transformations: 743 operators, 1376 arrays (0 quantized)
2019-10-04 16:17:38.148616: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 1: 284 operators, 533 arrays (0 quantized)
2019-10-04 16:17:38.152237: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] After general graph transformations pass 2: 284 operators, 533 arrays (0 quantized)
2019-10-04 16:17:38.155833: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before Group bidirectional sequence lstm/rnn: 284 operators, 533 arrays (0 quantized)
2019-10-04 16:17:38.158553: I tensorflow/lite/toco/graph_transformations/graph_transformations.cc:39] Before dequantization graph transformations: 284 operators, 533 arrays (0 quantized)
2019-10-04 16:17:38.164271: I tensorflow/lite/toco/allocate_transient_arrays.cc:345] Total transient array allocated size: 66560128 bytes, theoretical optimal value: 44408960 bytes.
2019-10-04 16:17:38.165392: E tensorflow/lite/toco/toco_tooling.cc:466] We are continually in the process of adding support to TensorFlow Lite for more ops. It would be helpful if you could inform us of how this conversion went by opening a github issue at https://github.com/tensorflow/tensorflow/issues/new?template=40-tflite-op-request.md
 and pasting the following:

Some of the operators in the model are not supported by the standard TensorFlow Lite runtime. If those are native TensorFlow operators, you might be able to use the extended runtime by passing --enable_select_tf_ops, or by setting target_ops=TFLITE_BUILTINS,SELECT_TF_OPS when calling tf.lite.TFLiteConverter(). Otherwise, if you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: ADD, CAST, CONCATENATION, CONV_2D, DIV, EXP, EXPAND_DIMS, FILL, LEAKY_RELU, LOGISTIC, MUL, PACK, PAD, RESHAPE, RESIZE_NEAREST_NEIGHBOR, SHAPE, SPLIT_V, STRIDED_SLICE, SUB. Here is a list of operators for which you will need custom implementations: CombinedNonMaxSuppression, Size.
Traceback (most recent call last):
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/bin/toco_from_protos", line 10, in <module>
    sys.exit(main())
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 89, in main
    app.run(main=execute, argv=[sys.argv[0]] + unparsed)
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/tensorflow_core/python/platform/app.py", line 40, in run
    _run(main=main, argv=argv, flags_parser=_parse_flags_tolerate_undef)
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/absl/app.py", line 299, in run
    _run_main(main, args)
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/absl/app.py", line 250, in _run_main
    sys.exit(main(argv))
  File "/home/wd_ai/miniconda3/envs/yolov3-tf2-gpu/lib/python3.7/site-packages/tensorflow_core/lite/toco/python/toco_from_protos.py", line 52, in execute
    enable_mlir_converter)
Exception: We are continually in the process of adding support to TensorFlow Lite for more ops. It would be helpful if you could inform us of how this conversion went by opening a github issue at https://github.com/tensorflow/tensorflow/issues/new?template=40-tflite-op-request.md
 and pasting the following:

Some of the operators in the model are not supported by the standard TensorFlow Lite runtime. If those are native TensorFlow operators, you might be able to use the extended runtime by passing --enable_select_tf_ops, or by setting target_ops=TFLITE_BUILTINS,SELECT_TF_OPS when calling tf.lite.TFLiteConverter(). Otherwise, if you have a custom implementation for them you can disable this error with --allow_custom_ops, or by setting allow_custom_ops=True when calling tf.lite.TFLiteConverter(). Here is a list of builtin operators you are using: ADD, CAST, CONCATENATION, CONV_2D, DIV, EXP, EXPAND_DIMS, FILL, LEAKY_RELU, LOGISTIC, MUL, PACK, PAD, RESHAPE, RESIZE_NEAREST_NEIGHBOR, SHAPE, SPLIT_V, STRIDED_SLICE, SUB. Here is a list of operators for which you will need custom implementations: CombinedNonMaxSuppression, Size.

Also, please include a link to a GraphDef or the model if possible.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

@wuhy08 , Size as an op is supported by our Select TF ops feature - assuming you are okay with a few MBs of increase in binary size. However, CombinedNonMaxSuppression is not.
As part of some upcoming TFLite converter changes, we are planning to support the usage of NonMaxSuppressionV4 & NonMaxSuppressionV5 in TFLite graphs - is there any way you could modify your network to get these instead? Are you using TF's object detection API?

Hi @srjoglekar246
I am using tf.image.combined_non_max_suppression, I think it uses tensorflow::ops::CombinedNonMaxSuppression on the backend, correct?
If I switch to tf.image.non_max_suppression, will it call tensorflow::ops::NonMaxSuppressionV3?
Which front end API calls V4 or V5?
Thank you!

One of the following should yield the required ops in the graph:

tf.image.non_max_suppression_padded
tf.image.non_max_suppression_with_scores

The first is just a slight modification to tf.image.non_max_suppression, while the latter one generalizes it to 'soft' NMS. Which ops are generated by each function based on the params can be seen in this file.
Once you have these ops in, using Select TF ops should correctly convert your model. Later this year, we will be making some converter updates that make NMS ops even easier to support natively in TFLite :-)

Thank you, @srjoglekar246 !

Closing this for now. Feel free to re-open if you are still stuck. Thanks!


feat: Updated footer text from 2022 to 2023

Fixed the year in footer page
fixes #108

@baekusboo This change is not required as the website was indeed made in Hacktoberfest 2022.
Closing PR.


it takes 2.3 seconds to import the package

Hi,
It takes a very long time to load the sdk.
Are there any imports which can wait for the time they will be used?

@ohad-alike thanks for reporting! we weren't able to reproduce this. Are you still seeing this issue? Sorry for the delayed response.

Yes,
 % time python -c "import pinecone" python -c "import pinecone"  0.23s user 0.10s system 22% cpu 1.479 total

from time import time
start = time()
import pinecone
print(f"time for import: {time()-start}")
time for import: 1.6446847915649414

this is obviously related to #189


Quagga: resolve OPNsense names to real interface names

will fix this soon.
looks like I missed that the interface field translates to the OPNsense names like opt1 or lan but quagga needs the real interface names.
There is currently no function for this.
@fichtner @AdSchellevis  the best way would be adding a new helper for interfaces which I can call like find_interface(interface_name) where I can access information like the hardware interface name.
So for solving this issue, I will need the framework to be extended.
File in core: https://github.com/opnsense/core/blob/master/src/opnsense/service/modules/addons/template_helpers.py
This seems to be an issue in the proxy configuration as well:
https://github.com/opnsense/core/blob/master/src/opnsense/service/templates/OPNsense/Proxy/squid.conf#L34

@fabianfrz I think macro's are the way to go here, see https://github.com/opnsense/core/blob/master/src/opnsense/service/templates/OPNsense/Macros/interface.macro
and for usage
https://github.com/opnsense/core/blob/master/src/opnsense/service/templates/OPNsense/IDS/rc.conf.d#L2
https://github.com/opnsense/core/blob/master/src/opnsense/service/templates/OPNsense/IDS/rc.conf.d#L18
As soon as I can find some time I will try to add one for you in the same file.

This does exactly what I needed but why is that a macro? I looked at the helper file where it was not included.

I will close this for now as the issue in the plugin is solved.


Auto fac Exception on initiating new chat c#

Hi,
I have been trying to initiate a new chat from my c# bot,
I have a trigger which will launch the following class
await Conversation.SendAsync(message, () => new Welcome());
But when I tried it,
It throws the following,
An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = IPostToBot (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IPostToBot], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = EventLoopDialogTask (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.EventLoopDialogTask (Microsoft.Bot.Builder.Dialogs.Internals.IPostToBot)], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = DialogTaskManagerBotDataLoader (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
 Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) <--- An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = EventLoopDialogTask (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.EventLoopDialogTask (Microsoft.Bot.Builder.Dialogs.Internals.IPostToBot)], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = DialogTaskManagerBotDataLoader (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
 Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) <--- An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = DialogTaskManagerBotDataLoader (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
 Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) <--- An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
 Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) <--- An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
 Parameter name: serviceUrl (See inner exception for details.) <--- Value cannot be null.
 Parameter name: serviceUrl

More details:
Autofac.Core.DependencyResolutionException: An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = IPostToBot (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IPostToBot], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = EventLoopDialogTask (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.EventLoopDialogTask (Microsoft.Bot.Builder.Dialogs.Internals.IPostToBot)], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = DialogTaskManagerBotDataLoader (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) ---> Autofac.Core.DependencyResolutionException: An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = EventLoopDialogTask (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.EventLoopDialogTask (Microsoft.Bot.Builder.Dialogs.Internals.IPostToBot)], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = DialogTaskManagerBotDataLoader (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) ---> Autofac.Core.DependencyResolutionException: An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = DialogTaskManagerBotDataLoader (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.IBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) (See inner exception for details.) ---> Autofac.Core.DependencyResolutionException: An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = JObjectBotData (ReflectionActivator), Services = [Microsoft.Bot.Builder.Dialogs.Internals.JObjectBotData], Lifetime = Autofac.Core.Lifetime.CurrentScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
Parameter name: serviceUrl (See inner exception for details.) (See inner exception for details.) ---> Autofac.Core.DependencyResolutionException: An error occurred during the activation of a particular registration. See the inner exception for details. Registration: Activator = Address (DelegateActivator), Services = [Microsoft.Bot.Builder.Dialogs.IAddress, System.IEquatable`1[[Microsoft.Bot.Builder.Dialogs.IAddress, Microsoft.Bot.Builder, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=31bf3856ad364e35]]], Lifetime = Autofac.Core.Lifetime.MatchingScopeLifetime, Sharing = Shared, Ownership = OwnedByLifetimeScope ---> Value cannot be null.
Parameter name: serviceUrl (See inner exception for details.) ---> System.ArgumentNullException: Value cannot be null.
Parameter name: serviceUrl
   at Microsoft.Bot.Builder.Dialogs.Address..ctor(String botId, String channelId, String userId, String conversationId, String serviceUrl)
   at Microsoft.Bot.Builder.Dialogs.Address.FromActivity(IActivity activity)
   at Microsoft.Bot.Builder.Dialogs.Internals.DialogModule.<>c.<Load>b__5_2(IComponentContext c)
   at Autofac.RegistrationExtensions.<>c__DisplayClass5_0`1.<Register>b__0(IComponentContext c, IEnumerable`1 p)
   at Autofac.Builder.RegistrationBuilder.<>c__DisplayClass0_0`1.<ForDelegate>b__0(IComponentContext c, IEnumerable`1 p)
   at Autofac.Core.Activators.Delegate.DelegateActivator.ActivateInstance(IComponentContext context, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   --- End of inner exception stack trace ---
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.<Execute>b__5_0()
   at Autofac.Core.Lifetime.LifetimeScope.GetOrCreateAndShare(Guid id, Func`1 creator)
   at Autofac.Core.Resolving.InstanceLookup.Execute()
   at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.ResolveComponent(IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Activators.Reflection.AutowiringParameter.<>c__DisplayClass0_0.<CanSupplyValue>b__0()
   at Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate()
   at Autofac.Core.Activators.Reflection.ReflectionActivator.ActivateInstance(IComponentContext context, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   --- End of inner exception stack trace ---
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.<Execute>b__5_0()
   at Autofac.Core.Lifetime.LifetimeScope.GetOrCreateAndShare(Guid id, Func`1 creator)
   at Autofac.Core.Resolving.InstanceLookup.Execute()
   at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.ResolveComponent(IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.ResolutionExtensions.TryResolveService(IComponentContext context, Service service, IEnumerable`1 parameters, Object& instance)
   at Autofac.ResolutionExtensions.ResolveService(IComponentContext context, Service service, IEnumerable`1 parameters)
   at Autofac.ResolutionExtensions.Resolve[TService](IComponentContext context, IEnumerable`1 parameters)
   at Microsoft.Bot.Builder.Dialogs.Internals.DialogModule.<>c.<Load>b__5_12(IComponentContext c)
   at Autofac.RegistrationExtensions.<>c__DisplayClass5_0`1.<Register>b__0(IComponentContext c, IEnumerable`1 p)
   at Autofac.Builder.RegistrationBuilder.<>c__DisplayClass0_0`1.<ForDelegate>b__0(IComponentContext c, IEnumerable`1 p)
   at Autofac.Core.Activators.Delegate.DelegateActivator.ActivateInstance(IComponentContext context, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   --- End of inner exception stack trace ---
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.<Execute>b__5_0()
   at Autofac.Core.Lifetime.LifetimeScope.GetOrCreateAndShare(Guid id, Func`1 creator)
   at Autofac.Core.Resolving.InstanceLookup.Execute()
   at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.ResolveComponent(IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Activators.Reflection.AutowiringParameter.<>c__DisplayClass0_0.<CanSupplyValue>b__0()
   at Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate()
   at Autofac.Core.Activators.Reflection.ReflectionActivator.ActivateInstance(IComponentContext context, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   --- End of inner exception stack trace ---
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.<Execute>b__5_0()
   at Autofac.Core.Lifetime.LifetimeScope.GetOrCreateAndShare(Guid id, Func`1 creator)
   at Autofac.Core.Resolving.InstanceLookup.Execute()
   at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.ResolveComponent(IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.ResolutionExtensions.TryResolveService(IComponentContext context, Service service, IEnumerable`1 parameters, Object& instance)
   at Autofac.ResolutionExtensions.ResolveService(IComponentContext context, Service service, IEnumerable`1 parameters)
   at Autofac.ResolutionExtensions.ResolveKeyed[TService](IComponentContext context, Object serviceKey, IEnumerable`1 parameters)
   at Autofac.ResolutionExtensions.ResolveKeyed[TService](IComponentContext context, Object serviceKey, Parameter[] parameters)
   at Microsoft.Bot.Builder.Autofac.Base.Extensions.<>c__DisplayClass1_0`1.<RegisterAdapterChain>b__0(IComponentContext c)
   at Autofac.RegistrationExtensions.<>c__DisplayClass5_0`1.<Register>b__0(IComponentContext c, IEnumerable`1 p)
   at Autofac.Builder.RegistrationBuilder.<>c__DisplayClass0_0`1.<ForDelegate>b__0(IComponentContext c, IEnumerable`1 p)
   at Autofac.Core.Activators.Delegate.DelegateActivator.ActivateInstance(IComponentContext context, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   --- End of inner exception stack trace ---
   at Autofac.Core.Resolving.InstanceLookup.Activate(IEnumerable`1 parameters)
   at Autofac.Core.Resolving.InstanceLookup.<Execute>b__5_0()
   at Autofac.Core.Lifetime.LifetimeScope.GetOrCreateAndShare(Guid id, Func`1 creator)
   at Autofac.Core.Resolving.InstanceLookup.Execute()
   at Autofac.Core.Resolving.ResolveOperation.GetOrCreateInstance(ISharingLifetimeScope currentOperationScope, IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Resolving.ResolveOperation.Execute(IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.Core.Lifetime.LifetimeScope.ResolveComponent(IComponentRegistration registration, IEnumerable`1 parameters)
   at Autofac.ResolutionExtensions.TryResolveService(IComponentContext context, Service service, IEnumerable`1 parameters, Object& instance)
   at Autofac.ResolutionExtensions.ResolveService(IComponentContext context, Service service, IEnumerable`1 parameters)
   at Autofac.ResolutionExtensions.Resolve[TService](IComponentContext context, IEnumerable`1 parameters)
   at Microsoft.Bot.Builder.Dialogs.Conversation.<SendAsync>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.Bot.Builder.Dialogs.Conversation.<SendAsync>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at System.Runtime.CompilerServices.TaskAwaiter.GetResult()
   at **class name**

Can someone help out whats going wrong?

The errors seems to come from a parameter with a null value, when registering Address as IAddress.

@BenjaBobs  I too suspect that and is verifying the same now. but it seems, the message construction without this message is working. That is,
If I construct a message like following it works.
  ChannelAccount userAccount = new ChannelAccount(toId, toName);
                        ChannelAccount botAccount = new ChannelAccount(fromId, fromName);
                        ConnectorClient connector = new ConnectorClient(new Uri(serviceUrl));
                        IMessageActivity message = Activity.CreateMessageActivity();
if (!string.IsNullOrEmpty(conversationId) && !string.IsNullOrEmpty(channelId))
                            {
                                message.ChannelId = channelId;
                            }
                            else
                            {
                                conversationId =
                                    (await connector.Conversations.CreateDirectConversationAsync(botAccount, userAccount))
                                    .Id;
                            }
                            message.From = botAccount;
                            message.Recipient = userAccount;
                            message.Conversation = new ConversationAccount(id: conversationId);
                            message.Text =
                                "Hi, It has been a while we have spoke. I have some exciting news about your today. When you're free send me a 'Hi'. Good Day!";

                            message.Locale = "en-Us";
                            await connector.Conversations.SendToConversationAsync((Activity)message);

@alokraj68 is this still an issue for you after upgrading to 3.8.1 SDK?

Hi,
Yes. The issue still persists.
On 01-Jun-2017 3:13 AM, "Jason Sowers"<EMAIL_ADDRESS>wrote:

@alokraj68 https://github.com/alokraj68 is this still an issue for you
after upgrading to 3.8.1 SDK?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotBuilder/issues/2615#issuecomment-305326403,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIyDm3JeF5NZgkA3pafcWBslO4eKi3r7ks5r_d8AgaJpZM4NARNQ
.

I have same problem, i can create new chat only from web app framework template
core web app project templates don't work

@alokraj68
Please post your Autofac registration code.

Where can I find that?
Thanks and Regards,
[image: Astro-Vision Future Tech] https://htmlsig.com/t/000001C1E7PD
Alok Rajasukumaran / Developer - Innovation Team
<EMAIL_ADDRESS>/<PHONE_NUMBER>7654
Astro-Vision Future Tech
Kuthappadi, Thamannam, ErnakulamKerala, India - 682032
alokraj68.in
[image: Twitter]  https://htmlsig.com/t/000001BVYZJE [image: Facebook]
https://htmlsig.com/t/000001BX9HG8 [image: Google +]
https://htmlsig.com/t/000001BV7H1J [image: LinkedIn]
https://htmlsig.com/t/000001C065D9 [image: Youtube]
https://htmlsig.com/t/000001C06RDJ [image: Github]
https://htmlsig.com/t/000001BYKTTT [image: Soundcloud]
https://htmlsig.com/t/000001BX996X [image: Stack Overflow]
https://htmlsig.com/t/000001BVE8RR
On 6 June 2017 at 21:51, Eric Dahlvang<EMAIL_ADDRESS>wrote:

@alokraj68 https://github.com/alokraj68
Please post your Autofac registration code.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotBuilder/issues/2615#issuecomment-306539489,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIyDmyB5LgG_1buAokPYCZuX0vuITQYqks5sBXx2gaJpZM4NARNQ
.

Oh, I assumed you were doing custom autofac registrations.
Please post your Welcome dialog.  (I'd like to be able to repeat your issue here, so I can figure out what's happening.)

Hi eric, you need welcome main or message controller file?
Thanks and Regards,
[image: Astro-Vision Future Tech] https://htmlsig.com/t/000001C1E7PD
Alok Rajasukumaran / Developer - Innovation Team
<EMAIL_ADDRESS>/<PHONE_NUMBER>7654
Astro-Vision Future Tech
Kuthappadi, Thamannam, ErnakulamKerala, India - 682032
alokraj68.in
[image: Twitter]  https://htmlsig.com/t/000001BVYZJE [image: Facebook]
https://htmlsig.com/t/000001BX9HG8 [image: Google +]
https://htmlsig.com/t/000001BV7H1J [image: LinkedIn]
https://htmlsig.com/t/000001C065D9 [image: Youtube]
https://htmlsig.com/t/000001C06RDJ [image: Github]
https://htmlsig.com/t/000001BYKTTT [image: Soundcloud]
https://htmlsig.com/t/000001BX996X [image: Stack Overflow]
https://htmlsig.com/t/000001BVE8RR
On 6 June 2017 at 22:21, Eric Dahlvang<EMAIL_ADDRESS>wrote:

Oh, I assumed you were doing custom autofac registrations.
Please post your Welcome dialog. (I'd like to be able to repeat your issue
here, so I can figure out what's happening.)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/BotBuilder/issues/2615#issuecomment-306548286,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIyDm_K407YpjMNjzNxlKe8UH60NFEjpks5sBYN_gaJpZM4NARNQ
.

Probably the Welcome dialog.  But, if it isn't too inconvenient, you can also include the message controller.  There's no way to know what your code looks like without seeing it.

@EricDahlvang it happens with the sample https://github.com/Microsoft/BotBuilder-Samples/tree/master/CSharp/core-proactiveMessages/simpleSendMessage when called by Microsoft Teams
I just had to comment the line [BotAuthentication] in MessagesController.cs
I believe this is due to activity.Recipient been null.

Please reopen this issue if needed

It still happens


Syncing remote copy to local copy (fetching from upstream)

Describe your problem and how to reproduce it:
I was attempting to make a pull request with the specified instructions in "making changes locally". I followed all of the instructions to update my local copy, but somehow I wasn't able to update my local copy successfully. I am not sure if this might be a relative error or an actual bug. After a few days I found a workaround. I used git's website to have all the commits synced up and it worked. I attached the output below using git's website. This worked beautifully for me and could work for others if decided to be integrated on the contribution page. Thank you so much for reviewing my case.
Tell us about your browser and operating system:

Browser Name: Google Chrome
Browser Version: Version 80.0.3987.163
Operating System: macOS Mojave

The usual workflow is:
on master
git fetch upstream
git reset --hard upstream/master
git push origin master --force

Then, create a new branch to work on. Publish and push to your remote, and create the pull request from GitHub.

The usual workflow is:
on master
git fetch upstream
git reset --hard upstream/master
git push origin master --force

Then, create a new branch to work on. Publish and push to your remote, and create the pull request from GitHub.

Right this is what I had originally attempted

Did you get an error with any of those actions? Are you sure you set-up your remotes and upstream correctly?

yes the remotes were set up correctly, as I stated I had followed the instructions.

I’m not sure as to why it wasn’t letting me continue forward with the pull request.

Thanks for the feedback. Unless you can specify the errors, there is not much we can do.
However, if we were making a guess, and assumed you followed the instructions to the teeth your fork may have been soiled before you took a look at the guidelines and instructions?
You fork is  not same as your local copy, BTW.
Not saying that this happened in your case, but if you started by quickly editing a file and submitted a PR that was merged you fork may have been soiled.
We make this evident multiple times I think. Anyways, IMHO instructions do not need changes, we have had them verified over time.

Nonetheless, Git’s instructions seemed to work in this case.

You meant GitHub's instructions (Git and GitHub are not related). Using them is fine, but they may not fit in the practices for this repo.
They are too generic and will lead to inconsistencies sooner or later.
I am closing this, but please continue in contributors chat room for further troubleshooting.

Thank you so much for reviewing my case, and I definitely think it might have just been soiled. Thank you again !


[AF-913]: Added Category to resource type and integrated with UX/UI (…

…#966)
[AF-913]: Added Category to resource type

@bsremac @nmirasch  cherry-pick from master


Update Namespaces and Header Guards to new Structure after Pip Package

Following the introduction of the pip package, the namespaces and header guards are now not correct anymore.

#390


CX SQL_Injection @ core/apphandler.js [master]

SQL_Injection issue exists @ core/apphandler.js in branch master
The application's function method executes an SQL query with query, at line 9 of core\apphandler.js. The application constructs this SQL query by embedding an untrusted string into the query without proper sanitization. The concatenated string is submitted to the database, where it is parsed and executed accordingly.
An attacker would be able to inject arbitrary syntax and data into the SQL query, by crafting a malicious payload and providing it via the input login; this input is then read by the function method at line 9 of core\apphandler.js. This input then flows through the code, into a query and to the database server - without sanitization.
This may enable an SQL Injection attack.
Severity: High
CWE:89
Vulnerability details and guidance
Checkmarx
Recommended Fix
Lines: 10

Code (Line #10):
	var query = "SELECT name,id FROM Users WHERE login='" + req.body.login + "'";

Issue still exists.
SUMMARY
Issue has 1 vulnerability/vulnerabilities left to be fixed (Please scroll to the top for more information)

Issue still exists.
SUMMARY
Issue has 1 vulnerability/vulnerabilities left to be fixed (Please scroll to the top for more information)

Issue still exists.
SUMMARY
Issue has 1 vulnerability/vulnerabilities left to be fixed (Please scroll to the top for more information)

Issue still exists.
SUMMARY
Issue has 1 vulnerability/vulnerabilities left to be fixed (Please scroll to the top for more information)


Make sure config is still available on Hot-reload

When Hot reloading the config build item is not set, making the Dev UI card inactive
Fix #64

I am not sure why the documentation is changed (was not me). Might be as part of the build ?

@all-contributors add @phillip-kruger for code


get no trading data

for predection market assets they did not show in the Trading section if i search for them

They do for me. What were you searching for?

Closing for lack of info. The search functionality is still finicky so might simply be related to that.


feat(csi): decouple volume target from application

As of now volume targets are always created on the same node where the application lives.
With the addition of HA w’ll be able to switch the nvmf target at the application node level, so we can now allow the target to live on any io-engine node in the cluster. This PR enables that change.
Signed-off-by: Abhinandan Purkait<EMAIL_ADDRESS>

bors try

bors try

bors try

bors try

bors merge

bors merge

bors try

bors merge


fix(accordion): remove tailwind from brn

The brain should not use tailwind.
Brain should also be usable in an project without tailwind.
PR Checklist
Please check if your PR fulfills the following requirements:

[x] The commit message follows our
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type
What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Which package are you modifying?

[x] accordion
[ ] alert
[ ] alert-dialog
[ ] aspect-ratio
[ ] avatar
[ ] badge
[ ] button
[ ] calendar
[ ] card
[ ] checkbox
[ ] collapsible
[ ] combobox
[ ] command
[ ] context-menu
[ ] data-table
[ ] date-picker
[ ] dialog
[ ] dropdown-menu
[ ] hover-card
[ ] input
[ ] label
[ ] menubar
[ ] navigation-menu
[ ] popover
[ ] progress
[ ] radio-group
[ ] scroll-area
[ ] select
[ ] separator
[ ] sheet
[ ] skeleton
[ ] slider
[ ] switch
[ ] table
[ ] tabs
[ ] textarea
[ ] toast
[ ] toggle
[ ] tooltip
[ ] typography

What is the current behavior?
The accordion-content does hide on a project where tailwind is not used, or where no overflow-hidden is used.
Closes #
What is the new behavior?
The accordion-content does not rely on tailwind anymore, the overflow is set by as direct style instead of tailwind overflow-hidden.
Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@elite-benni let's fix this as part of this PR: https://github.com/goetzrobin/spartan/pull/89


Show total bed level variance

Like the title say it would be nice to have a number displayed that is the total variance be between the lowest and highest point on the bed

Shouldn't be hard to add. Will peck at this one when I get a chance. 👍


Users send me a message and I reply to him

How Can I Take Users Messages and reply to him?
This is my Code:
bot.onText(/\Contact Us/, function ContactUs(msg) {
  const opts = {
    reply_to_message_id: msg.message_id,
    reply_markup: JSON.stringify({
      keyboard: StartKeyboard,
	  resize_keyboard:true,
      one_time_keyboard: true
    })
  };
  bot.sendMessage(msg.chat.id, 'Please Write your Messages:', opts);
});

@saeedhei Sorry for the long time take to respond. I will have to respond to this at a later date with a more complete solution that will work for you.

Hi @saeedhei,
Maybe this will fit your needs? Actually I am stuck with the kinda the same question right now and this is what I've came up with that far:
bot.onText(/\Contact Us/, function ContactUs(msg) {
  const opts = {
    reply_to_message_id: msg.message_id,
    reply_markup: JSON.stringify({
      keyboard: StartKeyboard,
	  resize_keyboard:true,
      one_time_keyboard: true
    })
  };
  bot.sendMessage(msg.chat.id, 'Please Write your Messages:', opts)
    .then(() => {
    bot.on('message', function(reply) {
// do some stuff with reply.text
})
})
});

UPDATE: check out the issue GochoMugo/tgfancy#5. Am addressing it there.

How Can I Get Users Reply Messages in My User ID?

Solved, You Can Find Awnser in Blow Link.


Account maintenance: Forgot Userid/Change Password

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
When setting up a new Midas account, the dialog text emphasizes that the password cannot be changed after creating it.
Describe the solution you'd like
I did find links as part of the Midas web console (https://midasweb.energy.ca.gov/Login) that do work:
https://midasweb.energy.ca.gov/Pages/AccountMaint/ForgotUsername
https://midasweb.energy.ca.gov/Pages/AccountMaint/ForgotPassword
I did try these, they both work, you provide the email you registered with:  Forgot username will email you your username, forgot password will send you a link allowing you to reset your password.
Describe alternatives you've considered
Could provide links to these in the dialog or documentation.  Or provide custom dialogs as part of the integration to perform these actions.  Maybe not needed enough to provide anything but links in doc.
Additional context
Thank you for creating this Midas integration, so useful!

Well would you look at that! I'll go ahead and update the login dialog strings and add these links to the documentation and the reauthenticate dialog

This will be available in version 0.2.1 shortly


[BEAM-317] Base PAssert on GBK instead of side inputs

Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

[x] Make sure the PR title is formatted like:
[BEAM-<Jira issue #>] Description of pull request
[x] Make sure tests pass via mvn clean verify. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
[x] Replace <Jira issue #> in the title with the actual Jira issue
number, if there is one.
[x] If this contribution is large, please file an Apache
Individual Contributor License Agreement.

Previously PAssert - hence all RunnableOnService/NeedsRunner tests - required side input support. This created a very steep on ramp for new runners.
GroupByKey is a bit more fundamental and most backends will be able to group by key in the global window very quickly. So switching the primitive used to gather all the contents of a PCollection for assertions should make it a bit easier to get early feedback during runner development.
This exposed issues in a test, which is fixed in a separate commit, should you choose to review them separately.

R: @tgroh @bjchambers

R: @amitsela adding you as I ended up noodling with the Spark streaming tests.
In summary, I replace the use of PAssert with just a custom transform that does the assertion. I believe the use cases are beyond those actually supported by PAssert today, but will be handled well in the upcoming improvements to PAssert.

OK, I've fixed up all the issues that this change uncovered and the tests are happy in Jenkins. Please take a look when you get a chance.

LGTM for the general code once comments are addressed and Jenkins/Travis look good.

OK, then I'll wait to hear from @amitsela to see if I have botched something in Spark land before proceeding.
I also had some performance concern, but I think it was an anomaly. This may actually speed things up a smidgin.

LGTM, this replaces https://github.com/apache/incubator-beam/pull/406 right ?
Are the performance concerns related to the Spark runner ?

Awesome. We are playing comment tag; just commented on #406, which this does supersede.


SAK-29678 - Site Deletion: Hard Delete and Soft Delete always display the same message.

Site Deletion: Hard Delete and Soft Delete always display the same
message.

Looks good, +1

Thanks @bjones86


Show pfm_title rather than pfm_name when using pfm_exclude

When using pfm_exclude, if a preference requires the existence of another preference, or that another preference have a particular value, what's displayed in the exclusion is the pfm_name.
In cases where you're using pfm_title, it makes it a bit difficult to find the preference, as you have to click the displayed preference name to reveal the preference key's pfm_name.  Examples below.

It would be helpful then where a preference has a pfm_title to have this shown in the exclusion, rather than the pfm_name, so it's easier to find.
While not necessary for this issue, it might be nice to have "bread crumbs" that can more easily direct folks to the location of the related preference(s) when an exclusion rule is met.

Yes, I agree. And also, these damn Optional() swift artifacts are so annoying, I have made them go away in several places but not all yet.

Is this addressed in upcoming release?


WIP: add es6 suffix to lint

My javascript files have an .es6 suffix. I want them to be linted. For eslint there is no way to specify the suffix in the config file. Besides this, .js is hardcoded in pronto-eslint anyway.
What can we do about it? I think hardcoding suffix is not the best way. Maybe there should be a possibility to configure pronto-eslint with the suffixes at least until eslint allows to specify file suffixes in the regular config?
This PR atm simply adds .es6 as a suffix, but I think it should be configurable in some way. Do you have an idea how to do it?

@doits I'm 🆗 with hardcoding here. I don't think that there are many custom suffixes people use for es files.

@mmozuras I'm fine with hardcoding .es6 too, since then all my files are linted and I need no more ;-)
But I think there are a lot of different suffixes out there for javascript files (for example I read someone using .jsx in some eslint issues), but maybe it would be over engineered to implement it as a configuration option atm (maybe eslint will have support to specify the suffixes in it's own config at some time, the pronto-eslint will simply use this).
I added some specs (in a very rudimentary way), so from my side you can merge this and release a new version :-)

@doits cool, other than my one comment, looks good 😄

@mmozuras done

@doits thanks, released as 0.6.1 👏


[SPARK-36847][PYTHON] Explicitly specify error codes when ignoring type hint errors

What changes were proposed in this pull request?
Explicitly specifies error codes when ignoring type hint errors.
Why are the changes needed?
We use a lot of type: ignore annotation to ignore type hint errors in pandas-on-Spark.
We should explicitly specify the error codes to make it clear what kind of error is being ignored, then the type hint checker can check more cases.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing tests.

Test build #143616 has started for PR 34102 at commit 5b3a5b8.

Test build #143616 has finished for PR 34102 at commit 5b3a5b8.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48128/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143616/

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48128/

cc @HyukjinKwon @xinrong-databricks @itholic

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48128/

Merged to master.


refactor: moves examples to their own projects

Codecov Report

Merging #186 (98e5c7d) into master (5375b3b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #186   +/-   ##
=======================================
  Coverage   92.45%   92.45%
=======================================
  Files          19       19
  Lines         172      172
  Branches        1        1
=======================================
  Hits          159      159
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5375b3b...98e5c7d. Read the comment docs.


[ACR] [BlobClient] Implement standard .NET download pattern in ContainerRegistryBlobClient

Use Storage Blobs library as a model:

[ ] Investigate the need to implement RetriableStream in DownloadBlobResult
[ ] Implement IDisposable on DownloadManifestResult and DownloadBlobResult

@annelo-msft - I believe our new API supports this scenario already so going ahead and closing this one. Please let me know if this is tracking something else and we need to reopen this issue.


coprocessor/dag/expr: add some un-pushed builtin UDFs(BitCount)

What have you changed? (mandatory)
Implemented builtin function: BitCount in coprocessor, this is for https://github.com/tikv/tikv/issues/3275
What are the type of the changes? (mandatory)
Improvement
How has this PR been tested? (mandatory)
Added some more UT cases
Does this PR affect documentation (docs/docs-cn) update? (mandatory)
No
Does this PR affect tidb-ansible update? (mandatory)
No
Refer to a related PR or issue link (optional)
https://github.com/tikv/tikv/issues/3275

PTAL @AndreMouche @breeswish

@bb7133 I've implemented this builtin in #3394 .........

Oops, well so I will close this PR~


Using org.javatuples for JSON-schema-arrays with elements of different types

Hello and greatings from Germany,
I'm using your jsonschema2pojo-maven-plugin to create the POJOs for a schema, that is defined as an array with different types as elements. In the documentation it is written, that the generator only supports List or Set as typed Collections for that.
As I have a valid json schema with an array and different types as elements I can't use your plugin to generate a POJO for that schema. It is possible to use the org.javatuples package to provide support for that case?
An example of my schema is:
{
   "$schema":"http://json-schema.org/draft-04/schema#",
   "$id":"/",
   "comment":"",
   "title":"MessageStructure",
   "type":"array",
   "description":"",
   "items":[
      {
         "type":"integer",
         "description":"This type represents the message type.",
         "enum":[
            1,
            2,
            3
         ]
      },
      {
         "type":"string",
         "description":"This type represents the source of the data of the message."
      },
      {
		 "description": "This type represents an unique identifier for the presystemId according to RFC3986.",
		 "type": "string",
		 "format": "uri"
	  },
      {
         "type":"string",
         "description":"This type represents the current timestamp of the message.",
         "format":"date-time"
      },
      {
         "type":"string",
         "description":"This type represents the unique identifier of the message.",
         "format":"uuid"
      },
      {
         "type":"string",
         "description":"This type represents the action of the message.",
         "enum":[
            "BootNotification",
            "ProvideChargingRequests",
            "ProvideChargingInformation"
         ]
      },
      {
         "type":"object",
         "description":"This type represents the payload of the message which is specified in separate JSON schemas."
      }
   ],
   "minItems":7,
   "maxItems":7
}

I'm awaiting the response of the community to this request.
Regards,
Maik Wöhl

Hi
Could you please elaborate as to what (class it's structure and relation to org.javatuples) would you expect to get generated for given schema?

As org.javatuples can only support up to 10 elements, I would have something like that in mind for building that code:
import org.javatuples.*;

public class JSONSchemaTuple {
    private ArrayList<String> tupleTypes;

    public JSONSchemaTuple(JSONObject schema) {
        if (schema["type"] == "array") {
            if (hasDifferentTypes(schema) && schema["items"].size() <= 10) {
                switch (schema["items"].size()) {
                /* ... */
                case 3:
                    ArrayList<String> types = readTypes(schema["items"]);
                    tupleTypes = mapToJavaPrimitivesAndLeaveComplex(types);
                /* ... */
                }
            }
        }
    }

    @Override
    public String toString() {
        if (tupleTypes.size() == 1) {
            return "Unit<" + tupleTypes.get(0) + ">";
        } /* ... */
        else if (tupleTypes.size() == 3) {
            return "Triplet<" + tupleTypes.get(0) + ", " + tupleTypes.get(1) + ", " + tupleTypes.get(1) + ">";
        } /* ... */

    }
}

And for the result I would propose something like that:
public class SchemaName<T> {
    private Septet<int, string, URI, Date, UUID, Element6Enum, T> tuple;

    public SchemaName(int item1, string item2, URI item3, Date item4, UUID item5, Element6Enum item6, T item7) {
        tuple = Septet.with(item1, item2, item3, item4, item5, item6);
    }

    public Septet<int, string, URI, Date, UUID, Element6Enum, T> getTuple() {
        return tuple;
    }
}

maxItems would select the right tuple and minItems would ensure that the constructor variants don't fall below the defined number of elements start counting with 0 for the first element in schema.

I don't think Jackson (or other libraries we support like GSON) can serialize or deserialize these correctly though, is that right? It's hard for us to create types that have entirely bespoke serialization and deserialization. Do you have a solution you're using for that right now?

We have created a class that is removing the quotation marks and the [] from the JSON and splits it at the commas for now. We will get in trouble as soon as the payload contains comma values in free-text strings...
Probably we will change the deserialization to first removing the substring of the payload by getting the data from first ,{ to end of the data. And then splitting it up by the commas.
But you're right, I see now, it is a really bespoke class we have written here.
Technically it would be possible to write a deserialization algorithm that is first stripping the object types one by one from the string by searching for ,{ to }, or }] (maintain nesting with counting opening and closing brackets) and then getting the integers and strings from the rest.
I will try to implement a class doing that deserialization. That would solve the deserialization problem for every instance of a array-type json collection with elements of different types, I think.
The serialization we have done with concatening the integers, strings and objects together, because our object is not serializable yet as the payload can be multiple different class instances and we do some relationship checks and whatnot. Not really clean at the moment...

Adding some useful links:

https://github.com/javatuples/javatuples/issues/3
https://github.com/FasterXML/jackson-databind/issues/2020
https://stackoverflow.com/a/32916203/125825

Ah thank you. I've jumped from embedded systems into business development and I'm impressed constantly how elegant many things are with almost unlimited memory resources.
I will try to dig into that in the next weeks. I will come back by the 1st of August and present a status. I have to work me into the code of Jackson if I really want to present a usable class for the public, I think.

Unfortunately I did not had the time to work on that topic. There are project deadlines to meet...
But I will post here again, as we continue our work on the tuple de/serializers.

By today I've got one step forward. I'm working on a type that uses the Java Reflection API to decouple the member names from the getter through annotations.
That is needed to have a universal interface for the de/serialization. I want to deserialize into a generic type, that has no member names, as we don't know the names with the array defined by the json schema above.
The ObjectContainer would be used like this:
import java.io.Serializable;
import java.util.LinkedList;

public class MessageStructure extends ObjectContainer implements Serializable {
	private static final long serialVersionUID = -2579921802313002387L;

	@Item
	private Integer messageType;
	@Item
	private String messageSource;
	@Item
	private String messageURI;
	@Item
	private String messageDateTime;
	@Item
	private String messageUUID;
	@Item
	private String messageAction;
	@Item
	private Object messagePayload;

	// TODO: Use Item annotation to get a list of FieldNames from Reflection API.
	@SuppressWarnings("serial")
	private static final LinkedList<String> mappings = new LinkedList<String>() {{
		add("messageType");
		add("messageSource");
		add("messageURI");
		add("messageDateTime");
		add("messageUUID");
		add("messageAction");
		add("messagePayload");
	}};

	public MessageStructure(Integer messageType, String messageSource, String messageURI, String messageDateTime, String messageUUID, String messageAction,
			Object messagePayload) {
		super(mappings, messageType, messageSource, messageURI, messageDateTime, messageUUID, messageAction, messagePayload);
		// TODO Auto-generated constructor stub
	}

	@MemberName("messageType")
	public Integer getMessageType() {
		return (Integer) invokeMethod();
	}
}

The Item annotation would help generating a list automatically by instantiation of the object.
Currently I'm using six generic named fields and getters in the ObjectContainer, but I will try to store the objects into a LinkedList and index them with the internal mapping.
The invokeMethod searches the generic getter mapped to the method and executes it. If an internal LinkedList would be possible,  I would just maintain a LinkedList with the object references passed by instantiation and index them directly without searching a generic getter.
Just to give a hint to the inner workings:
MessageStructure message = new MessageStructure(2020, null, null, null, null, null, null);
System.out.println(message.getMessageType().toString());

MethodName: getMessageType
Scope class: de.maikwoehl.tuple_serde.MessageStructure
Parent class: de.maikwoehl.tuple_serde.ObjectContainer
Caller: getMessageType
MemberName: messageType
Getter: getItem0
Methods in base:
 - invokeMethod
 - getIndexNameFromMappings
 - getGetterNameOfMember
 - invokeMethodUnsafe
 - getItem0
Execute: getItem0
2020

After I have that container I can work on the deserialization and map whatever fields I get to any number (maybe limited?) of generic getters through a LinkedList or fixed generic getters.
The end user can then define its wrapper class with semantic meaning around the container and use it's own getters.
In jsonschema we have types and positions. So we could really generate source code that specialize the container with the types and positions. Unfortunately the title argument would not validate in items which are not strings. So we could go here with generic itemX names and let the end user redefine the fields.
So the following schema:
{
   "$schema":"http://json-schema.org/draft-04/schema#",
   "$id":"/",
   "comment":"",
   "title":"MessageStructure",
   "type":"array",
   "description":"",
   "items":[
      {
         "type":"integer",
         "description":"This type represents the message type.",
         "enum":[
            1,
            2,
            3
         ]
      },
      {
         "type":"string",
         "description":"This type represents the source of the data of the message."
      }
   ],
   "minItems":2,
   "maxItems":2
}

Would be generated as:
import java.io.Serializable;
import java.util.LinkedList;

public class MessageStructure extends ObjectContainer implements Serializable {
	private static final long serialVersionUID = -2579921802313002387L;

	@Item
	private Integer item0;
	@Item
	private String item1;

	// TODO: Use Item annotation to get a list of FieldNames from Reflection API.
	@SuppressWarnings("serial")
	private static final LinkedList<String> mappings = new LinkedList<String>() {{
		add("item0");
		add("item1");
	}};

	public MessageStructure(Integer item0, String item1) {
		super(mappings, item0, item1);
		// TODO Auto-generated constructor stub
	}
}

And the end user can now rename the fields or directly create its getters:
@MemberName("item0")
public Integer getMessageType() {
    return (Integer) invokeMethod();
}

@MemberName("item1")
public String getMessageSource() {
    return (Integer) invokeMethod();
}

I've published the type to https://github.com/maikwoehl/tuple_serde
As a next step I have to write a ser/de for jackson or some own... I will see.

This is an interesting investigation @maikwoehl and I'm sure others will come across this and find it useful. I'm going to close this ticket because I don't think we will progress it in the core.


Add lingxiankong to the OWNERS

What this PR does / why we need it:
Add myself to the cloud-provider-openstack owners. I've been contributing the repo for almost half a year, the motivation of my contribution comes from the adoption of CPO(as part of Kubernetes as a Service) in our public cloud. I'm also the author of octavia-ingress-controller and maintainer of k8s-keystone-auth service. Being one of the owners doesn't mean more power but more responsibilities.
Which issue this PR fixes: fixes #
Special notes for your reviewer:
Release note:

@dims @hogepodge

/lgtm from me. I think you have contributed enough to get that status :)

lgtm from me. I think you have contributed enough to get that status :)
/lgtm

Awesome! thanks @lingxiankong
/approve
/hold
/assign @hogepodge
(@hogepodge can you please release hold)

/approve
@dims can you lgtm?

/hold cancel


Inspector "Play" Buttons Broken

In GT v...592:

tries to evaluate class-side methods on the instance side

the play buttons have still not returned to instance side unary methods

Has point 2 been fixed?

the play buttons have still not returned to instance side unary methods

Ah, that is still in the works.

Thanks!


Running external test processes

Some of our tests really need their own process.  For example, a "hello world" test that is measuring the end-to-end time to execute the canonical "hello world" console app.  That's a very simple example, but this comes up a lot in our testing.
One idea would be to just have a simple API for invoking an external process.  Test methods would just be normal [Benchmark] methods that happen to call this API.  However, I wonder if it would make sense for the harness to understand that it's executing an external process?  For example, this could influence the iteration heuristics, which really should not be looking at local GC counters when the interesting code is running in a different process.
Maybe we should have a different test type for this ([ExternalBenchmark]).  Or, a property on BenchmarkAttribute giving the name of an executable.  In either case, the method could be declared as "extern", with no method body.

Now that iteration is under programmatic control in each test method, I'm not sure this topic is still relevant.  Starting an external process per iteration is a simple matter of using Process.Start.


Update and rename ansible-create-complete-vm.md to ansible-manage-lin…

…ux-vm.md
This article is refined to manage a linux VM. This should be reviewed and merged w/ https://github.com/MicrosoftDocs/azure-docs-pr/pull/48728/files which creates a VM.

@kyliel : Thanks for your contribution! The author, @cynthn, has been notified to review your proposed change.

@TomArcher , please review this one w/ https://github.com/MicrosoftDocs/azure-docs-pr/pull/48728 together. And I changed the file name. Then the TOC also should be changed. Please let me know whether you will create your PR w/ ToC changes or you want me create a PR for ToC change. Thank you.

@cynthn, you could get more information about the background for PRs. These two changes are to create a VM which permits SSH and guide customers how to manage it. Thank you.

BTW, we are developing a module to get VM facts. Once it is done, we will update this doc to add how to get the information through facts module and deploy application on it. Thanks.

Sorry, I should sumit PR on docs-pr. close this one.

@cynthn These are both Ansible articles, so I'm changing the author to me. Please let me know of any concerns.

@TomArcher Sounds good :)


fix: enable sec-fetch for firefox

Fixes #29

The generated headers for Firefox are missing sec-fetch-*. Because of this CloudFlare keeps returning 503.
The order is already implemented, but the logic (which is this PR) was not.


Change notification type for LGCY restriction to Error

As a student I want to see when I'm blocked due to the legacy restriction.
Acceptance Criteria

[x] Change the notification type for the LGCY restriction to "error"

Additional Context
We changed it to no effect to hide it from students as we worked to resolve the restrictions issues and now need to change it back.

Changed in PROD. Closing as complete.


Upgrade Nuget version from 2.8.5 to 3.4.3

Motivation for this change
I want to pull in my binary dependencies with NuGet package restore, but NuGet 2.8.5 is too old and not compatible with some of the packages I'm attempting to restore.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)

[ ] NixOS
[X ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Fits CONTRIBUTING.md.

Seems to work on macOS:
CodyYu:nixpkgs codyyu$ nix-build -A dotnetPackages.Nuget
/nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3

@GrahamcOfBorg build dotnetPackages.Nuget
Also, cc @obadz who has some experience with this stuff.

Failure on aarch64-linux (full log)
Partial log (click to expand)
Package ‘mono-<IP_ADDRESS>’ in /var/lib/gc-of-borg/nix-test-rs-25/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-aarch64-community-25/pkgs/development/compilers/mono/generic.nix:90 is not supported on ‘aarch64-linux’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Success on x86_64-linux (full log)
Partial log (click to expand)
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.ProjectModel.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.Types.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v2.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v3.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.VisualStudio.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Repositories.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Resolver.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.RuntimeModel.pc
Created /nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3/lib/pkgconfig/NuGet.Versioning.pc
/nix/store/v5dwgywlk2f7mk02fp0wxbzzl9kxmlzs-Nuget-3.4.3

Success on x86_64-darwin (full log)
Partial log (click to expand)
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.ProjectModel.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.Types.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v2.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.Core.v3.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Protocol.VisualStudio.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Repositories.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Resolver.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.RuntimeModel.pc
Created /nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3/lib/pkgconfig/NuGet.Versioning.pc
/nix/store/gh7sjjvjalyh4chva6mszwd1pagl6i2x-Nuget-3.4.3

linking issue https://github.com/NixOS/nixpkgs/issues/34976

Looks good, thanks!


Question about combining tags

Hello,
I got a case where I would like the tags to be combined into a new tag.  The case I got is that I have many testcases and instead of having to add a new tag to each testsuite if a new tag is made I could just create a list of tags to run.
Example:
# test_tags.py
@pytest.mark.tags("tag1")
def test_tag1():
    pass

@pytest.mark.tags("tag2")
def test_tag2():
    pass

@pytest.mark.tags("tag3")
def test_tag3():
    pass

# conftest.py
tag1_tag2 = ["tag1", "tag2"]  # tag3 is not included

Here tag1_tag2 is the tags I would like to run with --tags tag1_tag2
Is it possible in any way to do this with the current version of pytest-tagging? Like running a pytest.mark.add_tags("tag1_tag2", tag1_tag2) in my conftest or do you have an idea to a way it could be done with a PR?

Hey! I suppose you can save each tag into a variable, and then create a small utility function that merged them however you like?
Then you could:
purest.mark.tags(combine(TAG_1, TAG2))
def test...

That is if I am understanding you correctly, of course 😀

It is not what I am aiming for.
These examples simply just results in the same as just adding an additional tag to each testcase.
What I am aiming for is being able to combine tags in a single file. So If I have different groups of testsuites/classes/tags then It then can be combined into a single tag called "All"
Example:
I got a tags called: clickable_links, pictures, open_new_tap and i also got a tag called clickable_buttons
I then want to include all tags except in a new tag called all with the exception of clickable_buttons
Example:
@pytest.mark.tags("clickable_links")
class TestsClickableLinks:
...
@pytest.mark.tags("pictures"
class TestsPictures:
...
@pytest.mark.tags("open_new_tap")
class TestsOpenNewTap:
...
@pytest.mark.tags("clickable_buttons")
class TestsClickableButtons:
...

Then in my conftest I then in some way combine the tags:
import pytest_tagging
pytest_tagging.combine_tags("all", ["clickable_links", "pictures", "clickable_buttons")

So here when i do pytest --tags all it will run all tests within the all tag

I will maybe look into it.
I still can't figure out if this is the way I wanna go with this.


Iframe Required

I will implement this with everydayim.com!

Successfully Implemented, just attempting to merge now...


Router

What are we waiting to use real router?
Material2 is already using it.

the repo has been updated to the latest router including lazy routes

Great but I can't see how app.routes.ts is called.

that's by design just as you don't know how app.component or app.service are called
it's being imported here https://github.com/AngularClass/angular2-webpack-starter/blob/master/src/platform/browser-providers.ts#L28...L29

I found it
/
export const APPLICATION_PROVIDERS = [
// new Angular 2 forms
disableDeprecatedForms(),
provideForms(),
provideRouter(routes),
provideWebpack(asyncRoutes),
...HTTP_PROVIDERS,
{ provide: LocationStrategy, useClass: HashLocationStrategy }
];

Wonderful
Just missing routActive directive


/rooms/{room_id}/members requires authentication

it was just an omission from the spec.
See https://github.com/matrix-org/matrix-doc/pull/1244 (not yet merged as of now, but already confirmed as omission).

Thanks! Glad to have this taken care of.


upon stopping user container 'stopping container' messages doesn't disappear

Once user decides to stop container, he/she goes to control panel, press 'stop', and looks at message 'stopping container' that doesn't disappear itself - one has to refresh page manually 30-60 seconds later to get repo prompt.

I don't have such problem. After a pressing 'stop' , I just wait during 15 seconds and then see the "Launch a notebook" button.

I have tried to do that with the standard containers (Dimuon and Demo).

Possibly would be solved with update to newest jupyterhub.


How to add Tenant Name in Shipper List Page

Maybe this is not a question with serenity,I just want to know what's the best idea to show tenantName
in shipper list page When table shipper and table Tenant are in different database?

And how to handle it  when the data comes from rest Api?

You can use inter-database joins like ForeignKey("[Serene_Default_v1].[dbo].[Tenants].", "TenantId")

thanks


Issue with switching panorama realities in argon-aframe:

Two related bugs:

Problem that seems to be between the new argonjs and argon-aframe.
artnotart.org/jdbolter/ar-frame/panorama/show2.html
artnotart.org/jdbolter/ar-frame/panorama/show2a.html

The only difference between show2 and show2a is that show2 uses the previous version of argonjs and show2a uses the latest version. What is supposed to happen: four panos are loaded and the first is shown. There is a disk with the Malmö logo on it in the scene. When the user holds the cursor over the disk for 1.5 secs, the next pano should be shown, and so on through all four panos. Show2 works in Argon. Show2a shows the first pano, but when the user holds the cursor over the disk, the next pano appears but the disk is now stuck to the screen rather than in the 3d space. It is no longer possible to move the cursor over it.
In addition if you load show2a into the Safari browser on the iPhone, no panorama shows at all.

Problem that predates switch to new argonjs
Just using show2.html.  This works in Argon. However, if you load it into the Safari browser, the first pano appears. When you move the cursor over the Malmö disk, the screen goes black. No further panos appear.

The code for show2 and show2a are found here.:
https://github.com/jdbolter/argon-aframe-tests/tree/dev/panorama

First thing to check:  it appears that you are using the same, old, panorama reality  (which uses the old argon.js) in both versions.
You should probably copy the new panorama reality from the samples, and make sure it's using the new argon.js (i.e., don't leave it loading the old <script src="../../js/argon.min.js"></script>).


upgrade deps to cosmwasm 2.0

closes #4

Note this fails (needed for #2 but not this PR). I will work on it a bit, cuz I messed with it before
cd packages/orch/
cargo build --features daemon


blaze dep update

there was an incompatible blaze dependancy in the package.js. this should allow people to use the v2 version of this package more easily on meteor 3

Fantastic.  Thanks again, @dallman2!


.github: implement CI for building

This implements continuous integration that builds a simple nerpa program on commits to main. The program, located in nerpa_controlplane/ci, is a subset of the existing snvs program.

Closing to simplify merging and DCO. Will open a new pull request for CI that just uses snvs.


Add autoflake to .pre-commit-config.yaml files

This will save us time fixing issues raised by flake.

@ansys/solution-maintainers
I would appreciate your insight on the failing check: basic_solution_validation — End-to-end tests with SAF Solution.
style: commands[1]> pre-commit run --all-files --show-diff-on-failure
An error has occurred: InvalidConfigError:
==> File .pre-commit-config.yaml
==> At Config()
==> At key: repos
==> At Repository(repo='https://github.com/PyCQA/autoflake')
==> At key: hooks
==> At Hook(id=MISSING)
=====> Missing required key: id
Check the log at /home/runner/.cache/pre-commit/pre-commit.log

Notes:

I can not access https://github.com/ansys-internal/solution-applications-actions to get further insight on check-code-style@v11
pre-commit run --all-files --show-diff-on-failure succeeds on my machine (Windows 11, Python 3.10.11)
the supposedly missing id is present in .pre-commit-config.yaml:- repo: https://github.com/PyCQA/autoflake
  rev: v2.3.1
  hooks:
  - id: autoflake
    args: [
      "--expand-star-imports",
      "--ignore-pass-statements",
      "--in-place",
      "--remove-all-unused-imports",
      "--remove-unused-variables",
    ]


Update module config to prevent /collections page caching

Update idc_ui_module config to prevent page caching for the /collections route

This should mitigate the problems seen in this ticket https://github.com/jhu-idc/iDC-general/issues/433

I confirmed that the initial issue is corrected via this PR. I was able to designate new collections as "featured" and they showed up to an anonymous user.   Changing an item from featured to no longer featured did get reflected in the results the anon user sess.


fix getInOnlyTemplate in SpringRabbitMQProducer.java (#14823)

getInOnlyTemplate is checking if inOutTemplate is null to determine whether or not it should initialize inOnlyTemplate.  It should check inOnlyTemplate.  This change fixes that.
Description

Target

[x] I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

[ ] If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

[x] I checked that each commit in the pull request has a meaningful subject line and body.

[x] I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

/component-tests spring-rabbitmq


Apply Helium Denylist

We should activate the denylist on our software: https://github.com/helium/denylist

Done now


ytcc: fix build

Description of changes
fixes https://github.com/NixOS/nixpkgs/issues/283530

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Result of nixpkgs-review pr 283633 run on x86_64-linux 1

2 packages built:

ytcc
ytcc.dist