HttpRequest vs HttpRequestMessage

The examples on this page use the class HttpRequest for the input binding, but it is hard to use (you need a StreamReader just to read the request body). I've used HttpRequestMessage from System.Net.Http instead in my functions which is much easier to use:

var json = await req.Content.ReadAsStringAsync();
var meeting = await req.Content.ReadAsAsync<OfficeMeeting>();
It seems much easier to use, so I'm wonder why HttpRequest is the suggested usage in the documentation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: ca056578-526c-603a-a0c7-fad5184134c0
Version Independent ID: 486bd792-6be0-e4e4-8e81-c383591b4a87
Content: Azure Functions HTTP triggers and bindings
Content Source: articles/azure-functions/functions-bindings-http-webhook.md
Service: azure-functions
GitHub Login: @craigshoemaker
Microsoft Alias: cshoe

Hi @JamesFenton Thank you for your feedback! We will review and provide an update as appropriate.

@JamesFenton Thanks again for sharing your feedback! You can certainly use one of the other depending on whichever one suits better for your unique requirements and ensuing implementation. While HttpRequest API provides more properties & granular info about the request directly, HttpRequestMessage API can also be more straight-forward to use as get-go too.

@mike-urnun-msft Thanks for the feedback. My suggestion is to include HttpRequestMessage in the "Trigger - usage" section to help others learn that they can use it as well. The Azure Blob Storage triggers has a useful list of possible objects you can use. It would be helpful to see something like that in the HTTP triggers docs (especially since HTTP is probably the most popular trigger)

Hi @JamesFenton - Thank you for your suggestion. While HttpRequestMessage was being used widely with Functions v1, if you're on v2, our recommendation is to use HttpRequest instead. Moreover, in an effort to staying consistent with the way boilerplate HTTP functions are created with our tools (VS, VS Code, CLI, etc..) currently, we'll hold off from making this update on the said section for now.
We will now proceed to close this thread. If there are further questions regarding this use case, please open an issue on Functions host repo to discuss this matter directly with the Functions team.

FWIW: https://github.com/MicrosoftDocs/azure-docs/issues/37298

They deprecating the property bag on the HttpRequest Object in favor of the HttpRequestMessage Options.  These two simple things are moving inapposite directions.  What is a dev to do?


Inconsistencies between my test results and those of the paper

Hi, expert
I used the weights you provided for testing. Why are the test results inconsistent with the results in the paper?

Hi, I'm using the weights test and the results are very similar, note that the steps, strengths are the same.

Hi, I'm using the weights test and the results are very similar, note that the steps, strengths are the same.

Thank you for your reply. I am using the default parameters of the codes and have not changed them. Do the default parameters of the codes need to be changed?

Thank you very much!!!
。。。
@.***

------------------ 原始邮件 ------------------
发件人:                                                                                "zyxElsa/InST"                                                                                @.>;
发送时间: 2023年12月6日(星期三) 上午10:58
@.>;
<EMAIL_ADDRESS>主题: Re: [zyxElsa/InST] Inconsistencies between my test results and those of the paper (Issue #43)
ddim_steps = 50, strength = 0.4,  seed=50
Others follow the test just fine,The openai token is linked to the controlNet I use directly.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: @.***>


Docker Images build fails

When build the freshly cloned repo docker-compose build fails with:
Collecting pip
  Downloading https://files.pythonhosted.org/packages/52/e1/06c018197d8151383f66ebf6979d951995cf495629fc54149491f5d157d0/pip-21.2.4.tar.gz (1.6MB)
    Complete output from command python setup.py egg_info:
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-build-IBoPUJ/pip/setup.py", line 7
        def read(rel_path: str) -> str:
                         ^
    SyntaxError: invalid syntax

    ----------------------------------------
Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-IBoPUJ/pip/
You are using pip version 8.1.2, however version 21.2.4 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
The command '/bin/sh -c pip install --upgrade pip' returned a non-zero code: 1
ERROR: Service 'web' failed to build

Updating the base image in the dockerfile can fix this.

Confirming as a bug, image node:4-alpine is running Python 2.7.14 which does not understand type annotations.


Jupyter integration not compatible with Java 8

Java 8 still dominates, especially among industrial companies，
first executed at 2023.07.21 11:56:54 , Failed

retry at 2023.07.21 11:58 , Succeed,
Each first run fails, and then retry succeeds

Related code：
use spark(spark=3.2.0, scala=2.13, v=1.2.3）
My Java version:
java version "1.8.0_121" Java(TM) SE Runtime Environment (build 1.8.0_121-b13) Java HotSpot(TM) 64-Bit Server VM (build 25.121-b13, mixed mode)
kotlin-jupyter-kernel
kotlin-jupyter-kernel             <IP_ADDRESS>5

The Kotlin Spark API targets Java 8 everywhere except for the Jupyter integration at the moment. This was because the Kotlin Jupyter API required Java 11. I'll investigate whether Java 8 for Jupyter has been made possible since the last time I checked.

I updated the project with Jupyter integration at Java 8.
The dev version is released to GitHub packages: https://github.com/Kotlin/kotlin-spark-api/packages/1527629.
To use a package from GH packages in a notebook, you'll need to add it as a repository:
USE {
    repositories {
        maven {
            url = "https://maven.pkg.github.com/Kotlin/kotlin-spark-api"
            credentials {
                // Your GitHub user name and personal (classic) access token (https://github.com/settings/tokens)
                username = "zenwan"
                password = ""
            }
        }
    }

    // dependencies can be put here or in @file:DependsOn
    dependencies {
        implementation("org.apache.spark:spark-yarn_2.13:3.2.0")
    }
}

And in a new cell:
%use spark(spark=3.2.0, scala=2.13, v=1.2.4-SNAPSHOT, ...)

Could you give it a try?


Fix code scanning alert - DOM text reinterpreted as HTML

Tracking issue for:

[x] https://github.com/KristopherKubicki/glimpser/security/code-scanning/9

Fixed automagically


Improve client connection error messages

Show the URI of the master the client is trying
to connect to when errors occur for debugging purposes.

@gimaker @negz @mattnworb

:+1:


Boxplot data

Trying to figure out the box plot chart, apexcharts expects [minimum, lowquartile, median, highquartile, maximum] array.
But Blazor-ApexCharts, not sure how to pass that along.
        <ApexChart TItem="BoxPlotData">
            <ApexBoxPlotSeries TItem="BoxPlotData"
                        Items="Data"
                        XValue="@(e => e.Name)"
                        YValue="@(e => new [] {e.Minimum, e.LowQuartile, e.Median, e.HighQuartile, e.Maximum})" />
        </ApexChart>

Thought it would be something like this, but obviously wrong.   How can I do this?
TIA

Hello,
Have you checked https://apexcharts.github.io/Blazor-ApexCharts/boxplot-charts
You just have to provide the X-Y properties and we will automatically calculate the values.

yeah i saw that.  my database calculates these values at a given interval, dont want to read all the data from the db, then pass that to the client in a http request.
anyway I can just pass in those 5 values that apexchart expects?

Hello,
Sorry but I think I got this all wrong.
Looking at the Apexchart spec it looks like the list should be the values like
The xy format accepts [{ x: category/date, y: [min, q1, median, q3, max] }]
https://apexcharts.com/docs/chart-types/boxplot/
I will look into this asap it's a priority

Fixed in v0.9.13-beta


Ubuntu 18.04 Fresh Install Failures

I've done a fresh install of Ubuntu18.04 ISO in virtualbox twice now and have received the following errors consistently:

Incomplete due to Failures -- Success: 553, Failure: 4

List of Failures (first 10 only)

 NOTE: First failure is generally the root cause.

 IMPORTANT: If opening a ticket, please include this information.

  - ID: timesketch
    SLS: sift.python-packages.timesketch
    Run#: 255
    Comment: Failed to install packages: timesketch. Error: Collecting timesketch

Downloading https://files.pythonhosted.org/packages/09/a9/e15e7cc734f87f6750875b1b884f90c6cd2f0765f7ef0064c8ce88f26d19/timesketch-20200226.tar.gz (8.9MB)
Complete output from command python setup.py egg_info:
Unsupported Python version: 2.7.17 (default, Nov  7 2019, 10:07:09)
[GCC 7.4.0], version 3.5 or higher required.
-------------Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-LlUvTb/timesketch/

You are using pip version 9.0.3, however version 20.0.2 is available.
You should consider upgrading via the 'pip install --upgrade pip' command.
- ID: undefined
SLS: sift.python-packages
Run#: 289
Comment: One or more requisite failed: sift.python-packages.timesketch.timesketch
- ID: undefined
SLS: sift.server
Run#: 460
Comment: One or more requisite failed: sift.python-packages.sift-python-packages
- ID: undefined
SLS: sift.desktop
Run#: 563
Comment: One or more requisite failed: sift.server.sift-server-version-file
Any help in remediating would be greatly appreciated! First time through I tried to resolve the issues by forcing alias for python3 and PIP, but no success.

Working on a fix, please see already opened issue. #432


[bot] Improve UX of bot

Add GIFs for greeting users
Refractor code to make it modular

Is this PR even needed now?


Godot v4 editor needs restart to detect inherited method.

Godot version
v4.0.beta10.official [d0398f62f]
System information
Apple M1 Max - macOS Ventura 13.1 (22C65)
Issue description
I'm actually not sure when this bug was introduced, or if it exists in v3 too.
Adding a new method on a super class, and then calling it from an extending class, triggers a "not found" error in the editor. The code however can run fine when running the scene.
See attached video:
https://user-images.githubusercontent.com/905216/210248116-f5af4af4-13f1-4755-a9a0-ffb49d571237.mov
Steps to reproduce

Create a few classes that inherit from each other. Not sure how many levels of inheritance is needed to trigger this, but it does for me when using 3 or 4 levels. I.e: ClassA → ClassB → ClassC → ClassD
Save
Define a method at the top-most super class in the inheritance chain, i.e: ClassA
Try to call the method on the last class in the chain, i.e: ClassD
The editor doesn't detect the method.
Save – It still isn't detected.
Close Godot and open the project again.
Now the method is detected.

Minimal reproduction project
I am sharing the project I created to reproduce some bugs in the editor, but it still requires redoing the steps on your end to trigger this, since restarting the editor fixes the issue.
Godot Crash Test.zip

Okay I just tested this on beta 11, and the issue persists. I still need to restart Godot every time I create a new function 😅 or I'll get a parser error.
The Output throws this when I save, with pending changes both in the super class and the inheriting class:
  res://MyCustomClass.gd:44 - Parse Error: Function "new_func()" not found in base self.
  modules/gdscript/gdscript_compiler.cpp:2339 - Condition "!base->is_valid() && !base->reloading" is true. Returning: ERR_BUG
  modules/gdscript/gdscript_compiler.cpp:2339 - Condition "!base->is_valid() && !base->reloading" is true. Returning: ERR_BUG

For context, I'm trying to call new_func() from the inheriting class, which I just defined in the super class.

I can verify that I also get it in Release Candidate 1.

Confirming that I'm also experiencing this in 4.0 stable

Experiencing this in 4.1 stable as well

I just made it a habit of restarting the project every time I create a method. It's very slow, but better than getting a typo on your code 😄

experiencing the same issue using Godot v4.1.1-stable-win64

experiencing this issue, but with at first level of inheritance

This issue still occurs in v4.2.2.stable.official [15073afe3]
It happens as far as I can tell with any and all parts of a custom class, not just methods, nor just inheritance. The editor will just seemingly decide that it doesn't feel like updating its list of classes and anything contained therein. So I won't be able to access properties, methods, or sometimes even the class itself. It feels like some kind of cache issue, but that's just an uninformed hunch.
It's how I get errors like this

despite the code being

and the only way to get the editor to recognize the change is to reload the project. If this happened like once a month, it'd be an annoyance, sure, but it happens constantly which turns it into a workflow nightmare.
I have seen really no rhyme or reason to it over the past 6 months. Sometimes Classes play nice, other times they go completely nuclear. It's maddening, especially for newer people who don't realize it's an engine bug happening, and waste hours trying to figure out what they're doing wrong.

havent tested, but should be fixed by https://github.com/godotengine/godot/pull/92616

havent tested, but should be fixed by #92616

I tried to test but I didn't manage to reproduce the bug in 4.2.2-stable after several attempts at following the steps in the OP.
So if someone who can reproduce the bug easily can test in 4.3-beta3 or later once it's released, that would be great.


Fixes

[ ] #[pallet::unbounded] used on all storage items which used unbounded vectors. This was to reduce the complexity of the update to latest and another issue should be created to tackle.
[X] Used bounded_*() helper functions for Dao tests, but only as a wrapper until the pallet can be fully migrated to bounded vecs.
[x] assess public visibility of helper functions in dao pallet
[ ] ensure that usage of into_account_truncating() is correct within task pallet
[ ] set max lengths of new config items of dao config in runtime. These are used by the Dao struct and were previously unbounded.
[x] there were upstream changes to RPC apis (jsonrpsee) , need to check that all still works from the front-end.
[ ] review possible switch to new list_benchmarks! and add_benchmarks! macros within runtime benchmarks
[x] Cargo.lock should not be included within source control for library crates (pallets) : source

@JosephKnecht-lab shall I create separate issues/PRs for the above outstanding tasks (where appropriate) to make merging easier. or just keep it all together under a single issue/branch?

Creating separate tasks/branch sounds like too much overhead.
We can keep it all in one branch.


Add labels in UniTensor constructor

When creating a UniTensor by one of the constructors, a name can be defined directly. However, the labels cannot. One has to use .relabels_() for this.
I would suggest to add an optional argument labels to do this directly.
The command that I use so far, T = cytnx.UniTensor(cytnx.random.normal([3,4], mean=0, std=1), name="T").relabels_((["t_0","t_1"]);
is not so well readable.

duplicated with #178, and solved


MR

Type: Feature Request
HELLO WORLD
VS Code version: Code - Insiders 1.75.0-insider (f076d553210e9ea65e7bccbfa2f7a786c10fcab2, 2022-12-09T09:11:59.691Z)
OS version: Windows_NT x64 10.0.25252
Modes: Restricted
Sandboxed: Yes
Connection to 'vscode-remote' could not be established  No remote extension installed to resolve codespaces.

@marks199 If the issue is related to VS Code, please file in https://github.com/microsoft/vscode/issues


feat: complete the grammar and make the repo look prettier

This contains a lot of changes:
I fixed the grammar entirely, I reworked some logic that wasn't exactly as per the cue spec, but that is mainly due to conflicts with selector and call expressions. In some cases It'd be parsed as a selector expr follow by a parenthesized expr which was incorrect. I also added some parsing to attributes, this just makes them more readable with highlighting.
I also added indents, folds, injections, and locals to the queries. The readme, bindings, docs/file docs, and manifests were also tidied up. The CI was improved and I added a linter as well
I expect some changes/disagreements so let me know! Open to change and then once (most if not all) of this is merged, I'll add it to nvim-treesitter. Are you ok co-maintaining it there with me? If not, I got it
Lastly, I'd like to request access to the repo if we're on good terms :) (I do maintain ~12 parsers and am an org member @nvim-treesitter) I'd like to add secrets to auto publish the packages in another CI script that I'd add after this.
Thanks,
Amaan

rebased, didn't intend for that ugly merge commit

Thanks a lot!

Woohoo! No problem

Would you mind adding me as a member to this repo? :)


[Ostrava] Lesson 11

Looks good to me. I'm gonna merge it now and I'll reload the course tomorrow.


Fix #120 Add reportLayerColor, getReportedLayerColor, getLayerColor

Also adds hReportLayerColor, hGetLayerColor and layerColor.
Not supported by terminals on Windows. Native terminals do not allow the color to be reported. Other terminals do not allow the reported color to be read from the console input stream.

Is this related to https://github.com/UnkindPartition/tasty/issues/298?

@Bodigrim, I had not seen that. This PR has been on the back burner, partly because the feature is not really cross-platform yet, even with emulation, for the reasons discussed in the related issue #120. There also does not seem to have been much progress on the Windows Terminal issue. However, I'll think about moving it into the code base.


Change response code to 200 on closeApiPlan endpoint

Issue
https://gravitee.atlassian.net/browse/APIM-3091
https://github.com/gravitee-io/issues/issues/9351
Description
Change response code to 200 on closeApiPlan endpoint

To manually apply on 4.x


time: fix cross-compilation to riscv64-linux

Without this change:
% nix-build . -A pkgsCross.riscv64.time
<......................................>
src/resuse.c: In function 'resuse_end':
src/resuse.c:103:3: error: implicit declaration of function 'memset' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html#index-Wimplicit-function-declaration-Wimplicit-function-declaration8;;]
  103 |   memset (&resp->ru, 0, sizeof (struct rusage));
      |   ^~~~~~
src/resuse.c:46:1: note: include '<string.h>' or provide a declaration of 'memset'
   45 | #include "resuse.h"
  +++ |+#include <string.h>
   46 |

src/resuse.c:103:3: warning: incompatible implicit declaration of built-in function 'memset' [8;;https://gcc.gnu.org/onlinedocs/gcc-14.2.0/gcc/Warning-Options.html#index-Wbuiltin-declaration-mismatch-Wbuiltin-declaration-mismatch8;;]
  103 |   memset (&resp->ru, 0, sizeof (struct rusage));
      |   ^~~~~~
src/resuse.c:103:3: note: include '<string.h>' or provide a declaration of 'memset'
make[1]: *** [Makefile:1881: src/time-resuse.o] Error 1
make[1]: Leaving directory '/build/time-1.9'
make: *** [Makefile:1337: all] Error 2

Not reproducible on master
https://gitweb.gentoo.org/repo/gentoo.git/tree/sys-process/time/files
https://github.com/NixOS/nixpkgs/pull/361878

Things done

Built on platform(s)

[X] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[X] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 362226

x86_64-linux

:white_check_mark: 3 packages built:

retdec
time
xfstests

There is a PR https://github.com/NixOS/nixpkgs/pull/348159. Clang should also have the problem I guess.

(So tagging master is fine)

(So tagging master is fine)

The PR is now targeting master

@ofborg build time


Add support for specifying port when using ssh.*

I'm trying to add a server to known_hosts which uses a different port than 22 using ssh.keyscan. It fails when I specify hostname="servername:port", which I see pyinfra translates to "ssh-keyscan servername:port" on the server.
A "port=" option in pyinfra ssh.keyscan which would translate to  "ssh-keyscan -p port " would be useful (for me at least :).

Excellent idea @kvold! Will replicate for all of the ssh.* operations too :)

Switching back to original here - will add the port arg to ssh.keyscan for v1.1.2 and do the other ones later as requires other changes + deprecations for arg consistency!

Port argument added in https://github.com/Fizzadar/pyinfra/commit/fd5cba1880ad306162c71fb7269d45b416428d56 which I'm about to release in v1.1.2.


NSFWjs not working in lambda

I tried using nsfwjs to detect images upload to s3 as safe or not but it is not working in lambda, I tried increasing memory to 10GB. But it still timed out :(
Log:
START RequestId: 18f3c1c7-3341-4973-b35c-b638cadd851e Version: $LATEST
2021-06-21T03:34:53.247Z    18f3c1c7-3341-4973-b35c-b638cadd851e    WARN
============================
Hi there :wave:. Looks like you are running TensorFlow.js in Node.js. To speed things up dramatically, install our node backend, which binds to TensorFlow C++, by running npm i @tensorflow/tfjs-node, or npm i @tensorflow/tfjs-node-gpu if you have CUDA. Then call require('@tensorflow/tfjs-node'); (-gpu suffix for CUDA) at the start of your program. Visit https://github.com/tensorflow/tfjs-node for more details.
============================
END RequestId: 18f3c1c7-3341-4973-b35c-b638cadd851e
REPORT RequestId: 18f3c1c7-3341-4973-b35c-b638cadd851e    Duration: 30033.57 ms    Billed Duration: 30000 ms    Memory Size: 10240 MB    Max Memory Used: 121 MB    Init Duration: 606.54 ms
2021-06-21T03:35:23.277Z 18f3c1c7-3341-4973-b35c-b638cadd851e Task timed out after 30.03 seconds

Code (for local testing):
//  const aws = require('aws-sdk');
const tf = require('@tensorflow/tfjs');
const sizeOf = require('image-size');
const jpeg = require('jpeg-js');
const nsfwjs = require('nsfwjs')
const axios = require('axios')

//const s3 = new aws.S3({ apiVersion: '2006-03-01' });

//exports.handler = async (event, context) => {
async function abc(){
  const model = await nsfwjs.load();

  const readImage = buf => {
    var imgprodata = sizeOf(buf)
    if(imgprodata.type != "JPEG" && imgprodata.type != "JPG" && imgprodata.type != "jpeg"&& imgprodata.type != "jpg"){
      let opt = {
        height: imgprodata.height,
        width: imgprodata.width,
        data: buf,
      }
      const pixels = jpeg.encode(opt,100)
      return pixels
    } else {
    const pixels = jpeg.decode(buf, true)
    return pixels
    }
  }

  const imageByteArray = (image, numChannels) => {
    const pixels = image.data
    const numPixels = image.width * image.height;
    const values = new Int32Array(numPixels * numChannels);

    for (let i = 0; i < numPixels; i++) {
      for (let channel = 0; channel < numChannels; ++channel) {
        values[i * numChannels + channel] = pixels[i * 4 + channel];
      }
    }

    return values
  }

  const imageToInput = (image, numChannels) => {
    const values = imageByteArray(image, numChannels)
    const outShape = [image.height, image.width, numChannels];
    const input = tf.tensor3d(values, outShape, 'int32');

    return input;
  }

  // const key = event.Records[0].s3.object.key;
  const key = '7c1e158e-26a8-44a1-b219-bf85741e4754'

  var pic = await axios.get(`https://public-usercontent.dogegram.xyz/storage/${key}`, {
    responseType: 'arraybuffer'
  });

  var pix = await readImage(pic.data);
  var img = await imageToInput(pix, 3)

  const predictions = await model.classify(img)

  console.log(predictions)

  return 'done'

}
//}

abc()

For testing:
npm init -y
npm i @tensorflow/tfjs image-size jpeg-js nsfwjs axios

While the jpeg-js should work, there's a better way to read images in node now.
I haven't updated the docs here on NSFWJS but you could use things like https://js.tensorflow.org/api_node/3.7.0/#node.decodeJpeg
I cover this in my book.   Please give tfjs-node a go, and let me know if that solves your issues.

Tfjs is too large to fit in lambda's size limit :(

Tagging the issue here:  https://github.com/tensorflow/tfjs/issues/2817

@hrichiksite - have you seen this?  https://stackoverflow.com/questions/59899650/running-tensorflow-js-tfjs-node-on-aws-lambda-node-js

@hrichiksite - have you seen this? https://stackoverflow.com/questions/59899650/running-tensorflow-js-tfjs-node-on-aws-lambda-node-js

Hi, I have seen this but I didn't get how to load NPM modules from a different DIR, I had tried to find but no success :(
Actually, The Issue here is not Size anymore but the fact that it is timing out even 60 secs.


Custom Data Model 1.3.0 cherry-pick

What

Cherry pick Custom Data model fix into 1.3.0
Why

Shows for proper displayName setting

https://skype.visualstudio.com/SPOOL/_workitems/edit/2833447

Please make sure that e2e tests pass before merging this PR.


improve performance at scale of exec::static_thread_pool

The design of stdexec's static_thread_pool's is similar to the one in libunifex, which apparently suffers at scale. It's safe to assume that our static_thread_pool has similar issues.
Investigate the issues discussed here and implement a solution that performs better.

See this reddit comment from someone who believes that techniques used by the Go scheduler would be applicable here.

Why doesn't every worker thread have its own queue that can never be accessed by other threads? If push is called from a worker thread, then the work gets put onto that thread's queue with no locking needed. (If push is called from a non-worker thread we do what we're doing now.) When pop is called we first try to dequeue an item from the thread-local queue, and if it's empty, we fall back to pulling from one of the shared queues.
I suppose this risks starvation of work items placed in the shared queues, which are essentially treated as if they have lower priority. We could probably tune that by having the worker threads occasionally pull from the shared queue even if their local queue has work to do. Or else have one or more threads only pulling from the shared queues.

We could probably tune that by having the worker threads occasionally pull from the shared queue even if their local queue has work to do. ... Or else have one or more threads only pulling from the shared queues.

This could introduce performance regressions on systems with NUMA. If we consider bulk in repeat_n, having threads pulling from non-local queues would introduce NUMA traffic.

@ericniebler I don't think it is necessary to invent a scheduler from scratch. I would like to bring to your attention the following work: https://github.com/taskflow/taskflow. It has a highly efficient task-stealing scheduler. It is distributed under the MIT license. If a similar efficient scheduling algorithm was available in stdexec, that would be great. The publication about it is here: https://tsung-wei-huang.github.io/papers/tpds21-taskflow.pdf. When it comes to task stealing on machines with NUMA domains, one can prioritize stealing from queues on the same numa domain and only if unsuccessful, go on to steal from the queues in the other NUMA domain. This would effectively minimize the NUMA traffic that @senior-zero mentioned.

I don't think it is necessary to invent a scheduler from scratch. I would like to bring to your attention the following work: https://github.com/taskflow/taskflow. It has a highly efficient task-stealing scheduler.

That looks very cool. Mos def we should take good ideas (and good oss code) from wherever we can get it. There's also value in having a simple, efficient-ish thread pool scheduler as an example. Maybe something based on the taskflow scheduler design could serve both needs?

Just wanna ping @tsung-wei-huang who is the developer of TaskFlow. Earlier this summer, I have talked to Tsung-Wei about exploring sender + TaskFlow. Let me know if there is any collaboration opportunity : )


D-cache to complement I-cache

To get the full performance of SweRV, I am aware that you should use the tightly coupled memories (ICCM and DCCM).
When using larger external memory, the common way is to attach them via AXI. Then you can use the I-cache for faster access to instructions. However, this option is not available for data accesses. One workaround is to use a DMA engine to transfer data into the DCCM.
A more convenient solution would be a D-cache, similar to the existing I-cache. Are there any plans to include such a feature in upcoming releases of SweRV?

So far there are no plans to add DCache to Swerv EH1. This is pretty substantial design effort and our main customer does not need DCache.


thread 'main' panicked at 'expected send event loop msg'

Hello guys,
I tried to install allacritty on macOS Yosemite 10.10.5. It went well but when I launch it and press any key, I have this error:

Macbook pro retina early 2015
OS: macOS Yosemite 10.10.5
Chipset gpu: Intel Iris Graphics 6100 1536 Mo
Keyboard layout: fr

Finished initializing glyph cache in 0.036782698
set_inner_size: 1124px × 676px
width: 1124, height: 676
Cell Size: (14 x 28)
PTY Dimensions: Line(24) x Column(80)
thread 'pty reader' panicked at 'unexpected err: Error { repr: Os { code: 5, message: "Input/output error" } }', src/event_loop.rs:283
note: Run with `RUST_BACKTRACE=1` for a backtrace.
thread 'main' panicked at 'expected send event loop msg', src/event_loop.rs:65```

That's really quite strange. This says you got an EIO during write. No idea what that means in the context of a pty.
Could you run with RUST_BACKTRACE=1 and provide the log?

Here is the backtrace:
device_pixel_ratio: 2
width: 2048, height: 1510
Initializing glyph cache
Finished initializing glyph cache in 0.033883028
set_inner_size: 1124px × 676px
width: 1124, height: 676
Cell Size: (14 x 28)
PTY Dimensions: Line(24) x Column(80)
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
Jan 17 11:20:21 fr-c02pxnl4fvh5 alacritty[45063] <Warning>: CGSLookupServerPort: _CGSSessionDeathWatchPort(gSessionPort) returns 268435459
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
The process has forked and you cannot use this CoreFoundation functionality safely. You MUST exec().
Break on __THE_PROCESS_HAS_FORKED_AND_YOU_CANNOT_USE_THIS_COREFOUNDATION_FUNCTIONALITY___YOU_MUST_EXEC__() to debug.
child finished with error '11'

Is this still a problem for you?


[openimageio] update to 2.2.16

Fix #19156
Update openimageio to the latest version 2.2.16
All features are tested successfully in the following triplet:

x86-windows
x64-windows
x64-windows-static

Duplicate of #19272

I take it you meant #19156 and not #19272?

Thanks for your notice. #19272 contained the update to 2.2.16. So the comment is right.

I take it you meant #19156 and not #19272?

Pr #19272 update three port yaml-cpp,openimageio,opencolorio


Improvement of blemishes

added matplotlib to requirements
added two small plots ( @l4nz8  I know, you wanted to do that page, is that still correct? )
added new categorie:
Financial fees and living area
because:
If you want to create a new entry e.g. for your apartment rent, there was no correct category.

Tell me your opinion

@velixko  I think we have to update the two new categories in the data generator.
Because the data generator was your coding project, do you want to add the columns?

If not, let me know so I can fix that.

Thanks

Hi,
the code runs perfectly good (especially in dashboard.py)! Great job!
Only a reminder here that we already delete the file user_input.py and expenses_dataset.csv due to this reason:

user_input.py code is no longer used, because we mainly used streamlit now. Resolved in #47
expenses_dataset.csv should not be tracked by github. Discussed in #28

I see that that those file are still tracked by github in this pull request. As alternative, maybe I could suggest for you to either:

Delete the file locally from your laptop, or
not using git add --all if git still tracked the unnecessary file.

I dont know if this is really the solution but this is what I would recommend.

The unused files were deleted in #50. Nice work @till-teb !

i can update the data generator, no problem :)


Optional bytes/fixed encoding can fail in python 3

There needs to be an explicit check in the python_to_union function against the PyBytes_Check function in order to support optional Fixed and Bytes types in Python 3.  This is not a problem under Python 2, because _PyUnicode_CheckExact presumably passes there.

I had been putting each individual test of a type within a union under the union test, but that is causing dependencies in my commits.  I'm going to split out the test for this one into its own function.


[feature] Visual Selector - Use Playwright in realtime if fetch method set to Plaintext/HTTP

Describe the solution you'd like
Visual Filter Selector page should be able to use Playwright even if request method set to Plaintext/HTTP
Describe the use-case and give concrete real-world examples
This will allow people to use Plaintext/HTTP even if they want to use Visual Selector to select filters.
Additional context
Discussion https://github.com/dgtlmoon/changedetection.io/discussions/1892

I realised this is going to cause many problems if the site requires JS to render, but then you fetch it with 'requests'


Inline styles

Component
web-ui
Describe the bug
The code contains the inline styles.
Inline style, seems, was only in web/src/components/admin/settings/queue/AdminQueueStats.vue:25 before.
Expected behavior
Should not be inline styles.
https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/style
https://stackoverflow.com/questions/2612483/whats-so-bad-about-in-line-css
https://content-security-policy.com/unsafe-inline/
System Info
next
Additional context
I accidentally saw #4609 and wanted to comment there, but I'm not allowed to comment on pat-s issues and PRs.
Validations

[X] Read the docs.
[X] Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
[X] Checked that the bug isn't fixed in the next version already [https://woodpecker-ci.org/faq#which-version-of-woodpecker-should-i-use]

I accidentally saw https://github.com/woodpecker-ci/woodpecker/pull/4609 and wanted to comment there, but I'm not allowed to comment on pat-s issues and PRs.

Can you please stop with such stuff? Most of the time your input is helpful and is taken into account, but some comments seem as if they are only intended to disturb development without making any constructive contribution. Thus, they might get ignored. If you have constructive feedback to add, pretty sure nobody told you to stop on PRs of a particular author.

Can you please stop with such stuff?

Sorry, I do not understand, what are you asking to stop? But, sure, it won't be a problem from my side. Are you asking to stop filing the issues?

I accidentally saw https://github.com/woodpecker-ci/woodpecker/pull/4609 and wanted to comment there, but I'm not allowed to comment on pat-s issues and PRs.

I just explained, why this issue appears. The same as with #4619.

they are only intended to disturb development

OMG!

without making any constructive contribution
If you have constructive feedback to add

Testing and filing a bugs are not contribution, aren't? Or they are, but are not constructive? The are not constructive in general? Only my? Or only this one? How can I improve this one?

they might get ignored

No problem. Feel free to close, if you find it non-constructive, disturbing or whatever.
I just wanted to say, that inline styles (and scripts) is a bad practice. And there was one place with that thing, but now it is two and could spread across the codebase.

You missed the point. I fully agree with the technical details of this issue. Perfectly valid. I marked a single line and kindly ask you to avoid such provocative statements.


Add Forklift to the umbrella

Merges forklift into the umbrella
Configures forklift for being a part of the umbrella
Update andi dependencies as needed
Adds mix test alias (temporary pending brook updates)

I made changes in the last 4 commits, so you'll probably want to focus on those. Feel free to re-review the entire history of Forklift if you'd like, though.

Yes. That change was made before this PR, but there is some stuff there that needs to be tweaked. I'll probably do that as part of my next PR (EOF messages) or a third for that specifically.


fix: name hive metastore port

Which issue(s) this PR fixes

Fixes #108
Additional comments

Agreements

[x] I hereby declare this contribution to be licensed under the Apache License Version 2.0, January 2004.
[x] I hereby agree to grant TOSIT a copyright license to use my contributions.

I deploy a cluster today, I reproduce the error and this fix resolve the error.


Assertion failure when running the bedtools unionbedg example

When running the “Default behaviour” example for the bedtools unionbedg command, I reproducibly get an assertion failure:
⟩⟩⟩ more 1.bg
chr1 1000 1500 10
chr1 2000 2100 20
⟩⟩⟩ more 2.bg
chr1 900 1600 60
chr1 1700 2050 50
⟩⟩⟩ more 3.bg
chr1 1980 2070 80
chr1 2090 2100 20
⟩⟩⟩ bedtools unionbedg -i 1.bg 2.bg 3.bg
Assertion failed: (!queue.empty()), function ConsumeNextCoordinate, file unionBedGraphs.cpp, line 99.
Abort trap: 6

This works fine for me using 2.26.0 and the latest version in github. I suspect that whn you copy and pasted the example files from the web page, you may have not replaced spaces with tabs to delimit the columns or perhaps the newlines became garbled.
Please test for this using cat -t.

Indeed, that was it. I had previously had the same problem with my own BedGraph files. Turns out they were wrong, too (note to self: awk’s FS doesn’t set OFS).
That said, faulty user input shouldn’t really trigger an assertion. It would be nice if there were an explicit error message about this.


Protobuf message should strip spaces from names

Protobuf message should strip spaces from names for messages, enums, and fields.
Protobuf style guides for reference:

Protobuf enum style guide
Protobuf message and field style guide

Recreating the issue:

Alter TimerAlert in model/alarm_clock/structures.yaml to the following:
a.  TimerAlert to Timer Alert
b.  alarmNoise to alarm Noise
c.  AlarmNoise to Alarm Noise

schema:
  name: Timer Alert
  description: Data structure for timer alerts.
  fields:
    - name: triggeredTime
      type: Timestamp
    - name: alarm Noise
      type: Alarm Noise

Update AlarmNoise to Alarm Noise in model/alarm_clock/structures.yaml to the following:
a.  AlarmNoise to Alarm Noise

enum:
  name: Alarm Noise
  description: List of available alarm noises
  values:
    - "Sonic Boom"
    - "Siren"
    - "Klaxon"
    - "Dog Barking"

This leads to the following errant output:
Example enum error:
/* List of available alarm noises */
enum Alarm Noise {
  SONIC BOOM = 1;
  SIREN = 2;
  KLAXON = 3;
  DOG BARKING = 4;
}

Example message error:
/* Data structure for timer alerts. */
message Timer Alert {

  Timestamp triggeredTime = 1;

  Alarm Noise alarm Noise = 2;
}

The expectation is that these names correctly handle spaces and produce correct output like so:
Expected enum output:
syntax = "proto3"

/* List of available alarm noises */
enum AlarmNoise {
  SONIC_BOOM = 1;
  SIREN = 2;
  KLAXON = 3;
  DOG_BARKING = 4;
}

Expected message output:
/* Data structure for timer alerts. */
message TimerAlert {

  Timestamp triggeredTime = 1;

  AlarmNoise alarmNoise = 2;
}

AC:

[x] Schema definition names must have spaces removed and converted to camelCase.
[x] Schema definition field names must have spaces removed and converted to camelCase.
[x] Enum definition names must have spaces removed and converted to camelCase.
[ ] Enum values/constants must have spaces replaced with underscores

@Coffee2Bits, Just an update on this. I believe I have this fixed, but I am noticing weird behavior in regards to AlarmNoise
Currently it is not returning any values, the values that I am expecting to be returned are:
SONIC_BOOM = 1;
  SIREN = 2;
  KLAXON = 3;
  DOG_BARKING = 4;

but what I am actually getting is:
message AlarmNoise {
}

So far I have confirmed that the 3 checks above in the AC are confirmed to be done and I think resolved. I am just needing to get the enum values to register in the output as they are currently not doing so


declineOffer don't working

declineOffer don't working
i use this
offers.declineOffer({tradeOfferId: tradeofferid});

in my code
tradeofferid = valid tradeid

You're not logging your error.
offers.declineOffer({tradeOfferId: tradeofferid}, function(err) {
    if (err) throw err;
});


How can I use your PointNetVLAD code for localization (place retrieval)

I have read your paper about PointNetVLAD  and run the code you provide on the Github. It is really a great work.
Now, I would like to use PointNetVLAD for place localization (or point cloud retrieval) using the global descriptor. In fact, I see a lot of similar work you have done in your paper. For example, the work of figure 4. You used the query point clouds to retrieve the corresponding point clouds.
Now, I would like to perform the similar task as you did in figure 4. However, the code provided on the github is more likely to evaluate the performance of the network.
I would like to know what code you used to realize the above function (figure 4 in paper) so that it can get a retrieved point cloud with a input one. Otherwise, how can I use the existing code on github to fulfill this task?
In fact, I have sent this message to your email<EMAIL_ADDRESS>It seems that the address has expired. You may update it if you do not mind.
Thanks.

Have u solved this problem?Extract the global descriptor.


Preview no Longer Works

Does this issue occur when all extensions are disabled?: Yes/No

Version: 1.92.2 (user setup)
Commit: fee1edb8d6d72a0ddff41e5f71a671c23ed924b9
Date: 2024-08-14T17:29:30.058Z
Electron: 30.1.2
ElectronBuildId: 9870757
Chromium: 124.0.6367.243
Node.js: 20.14.0
V8: <IP_ADDRESS>-electron.0
OS: Windows_NT x64 10.0.19045
NB: Extension bisect was used and it stated this might be a problem with Code.
Steps to Reproduce:

Install either the Markdown All in One (yzhang.markdown-all-in-one) extension or Asciidoc (asciidoctor.asciidoctor-vscode)
Write a document in the chosen markup
Right click a document and select Open Preview
The preview window opens but will be empty

The extension host produces the following output
[error] Error: spawn c:\Users\LWH\AppData\Local\Programs\Microsoft VS<EMAIL_ADDRESS>ENOENT
    at Process.ChildProcess._handle.onexit (node:internal/child_process:286:19)
    at onErrorNT (node:internal/child_process:484:16)
    at processTicksAndRejections (node:internal/process/task_queues:82:21)

I reinstalled and now the preview is working.


[8pt] Update the alpha test to accept previous runs' metrics CSV

As part of our AWS transition, the alpha test needs to accept previous alpha test CSV files. This should be a new optional argument to tools/synthesize_test_cases.py that when passed,  should override the need to scan the other test_cases directories.
The new aggregated hydroTable should also be added to this workflow. I believe this change will need to be in tools/run_test_case.py. #836

FYI You can use /data/test_cases/metrics_library/fim_4_x_metrics.csv as a test input.

We should also warn the user if they do not supply a previous metrics CSV.

Discussing this out loud with Emily, we came up with a couple of thoughts/ideas that would be good to get other opinions on (@CarsonPruitt-NOAA, @BradfordBates-NOAA, @RobHanna-NOAA):

Seems like a good idea to maintain the functionality for -dc flag where a user would want to compare their current development metrics to a past development version that they have access to. This assumes that the user has the -dc outputs available in their local test_cases\.\.\testing_versions. I definitely use this functionality when comparing a bunch of different development versions against each other.
We are going to scrub the current code for anything dealing with previous_fim and official_versions because those outputs will likely not be accessible in the user's test_cases directory when running in AWS. We will replace this functionality with a new optional input argument (-prev) where the user can provide a csv file that contains any previous metrics to concatenate with the new metrics to form a final aggregated metrics csv.
Thoughts on having the code produce two csv files whenever the user provides a valid input variable using the -prev argument?

The first output csv would include all of the metrics generated for the current fim version (-v) as well as any dev compare metrics if the user provides the -dc arg. I propose we name this csv: -v + "_metrics.csv"
If the user provides the new (optional) input arg (-prev) for the "previous_metrics_csv", a second output csv would be created and include everything in the first csv as well as all of the metrics in the previous metrics csv file. I propose we name this csv: -v + "_aggregate_metrics.csv"

I like all of these suggestions. The 2-csv output also jives with the near-future update to the test_cases folder where the version will be the top-level directory and the first, version-specific csv will be stored in that directory.

I agree, it all sounds reasonable.

Love it.


EfficientNet

🚀 Feature

A feature request for EfficientNet model.
Thank You.

Hi, thanks for the feature request. There is a duplicate issue for the same model, see #980. I'll close this one to keep things clean but feel free to comment on the other issue if you need anything.

Ok. Thanks.


count missing after refactoring

@tobilg –
I was using the counts on RTEdge.net

as an additional table row where it was showing
  1/102
 12/6XX ← cannot calculate this now!

Will count come back or are they removed for good? If removed, what was/is the difficulty in preserving them?

No, it won't come back unfortunately, as AWS no longer published it on the source page https://aws.amazon.com/de/cloudfront/features/

Thank you for the prompt response!


Block page navigations and make them as actions

When clicked on a  HREF we need to prevent any page navigation. Instead we need to fire an action.

Is there already a workaround available for this?

Anybody?

I don't really agree, this should be default storybook behavior.
If a component has a <a href... that's what the component is and does.
Overriding this without explicit configuration to do so, would be super unexpected.
I'm guessing it's rather easy to write an addon that will preventDefault() any click within it, and log an action. But I haven't seen such an addon yet, so I'm really wondering if this is something we should write.
If you want this comment below or make a PR :)


Initial suggestions for plugin release

Hi @leonjza  - Great to see all the work on the ProjectDiscovery plugin for Steampipe 🎉 !!
We'd also love to collaborate with you to get this plugin reviewed & listed on the Steampipe Hub so people can find it, use it and hopefully contribute as well - I'm sure it will be useful for others!
The initial plugin structure looks great. While using the plugin we came up with a few suggestions on our best practices:

config/projectdiscovery.spc

The plugin argument in the spc file should be  sensepost/projectdiscovery. In general, we use the org name for plugin reference - https://github.com/marekjalovec/steampipe-plugin-make/blob/main/config/make.spc#L2
Thanks for adding links to retrieve the config arguments. They definitely make it easy for the plugin users.
The formatting of the file is slightly off, could you please update it as follows:

 connection "projectdiscovery" {
   plugin = "sensepost/projectdiscovery"

   # Naabu

   # Top ports to scan for naabu.
   # Can be one of: full, 100, 1000
   # naabu_top_ports = "100"

   # Chaos

   # Project chaos API key. Sign up for an API key at: https://chaos.projectdiscovery.io/
   # chaos_api_key = "enpg9i8k4uxl0jtzoutym44cpm6rbxskr6fqoz11mxxpkiqtn4l7oju66rlqqz8j"

   # Cloudlist

   # Digital Ocean API key. Get an API key post authentication for a team by browsing to:
   # API (bottom left) -> Personal access tokens
   # A read-only key would suffice
   # cloudlist_do_token = "dop_v1_y0jzo0bp8wl7f3t0px74jea5hnxiicz1sl58z5mso6ep6a544v3mq1jp2qj4ed6a"
}

docs/tables/*

Overall the docs look great, and the queries are neat, however, the formatting of the example queries needs to be updated per https://www.freeformatter.com/sql-formatter.html#before-output (2 spaces per indent level)
Certain table docs just have a single query like https://github.com/sensepost/steampipe-plugin-projectdiscovery/blob/master/docs/tables/projectdiscovery_dnsx.md, https://github.com/sensepost/steampipe-plugin-projectdiscovery/blob/master/docs/tables/projectdiscovery_naabu.md, would it be possible to add a couple of more example queries to the table docs?

docs/index.md and README

The doc files look great. You could make minor formatting updates per the namecheap plugin docs
The references to the social-graphics and icons are missing. You could take a look at https://github.com/marekjalovec/steampipe-plugin-make/blob/main/docs/index.md for more reference.
The doc file has a reference to an api_key for authenticated access in https://github.com/sensepost/steampipe-plugin-projectdiscovery/blob/master/docs/index.md#configuration , Is this correct?
Is there a specific reason for choosing osint as the plugin category?
The Get Involved section incorrectly references https://github.com/kaggrwal/steampipe-plugin-bitfinex instead of https://github.com/sensepost/steampipe-plugin-projectdiscovery

Makefile

Please update the install command as follows -
go build -o<EMAIL_ADDRESS>*.go
Is there a specific reason why we need to add the local installation command?

projectdiscovery/*

The table structure, column names, and the logging section look great. very neat indeed 👍!!

A couple of follow-up questions:

How are we handling the resource not found errors?
Do the APIs support pagination?
While working with the APIs did you encounter rate limit errors?
Please refer to https://steampipe.io/docs/develop/plugin-release-checklist#data-ingestion for more information

Overall the plugin looks great @leonjza. Thanks for all the effort. Please let us know if you have questions. Happy to help 👍.
Once the suggestion/feedback comments are addressed, we could release it to the hub 👍.

Thank you, I did work through the plugin release checklist and other examples for the overall structure. I appreciate the feedback and will update this ticket once I've actioned it all.

Thanks again for the comprehensive feedback. I've actioned them in https://github.com/sensepost/steampipe-plugin-projectdiscovery/commit/d025883a835e8955abecadb1f843579ba26fccd0 as follows:

The plugin argument in the spc file should be  sensepost/projectdiscovery

Added sensepost here.

The formatting of the file is slightly off, could you please update it as follows:

Updated, mostly just changing the comment character from // to #.

Overall the docs look great, and the queries are neat, however, the formatting of the example queries needs to be updated per https://www.freeformatter.com/sql-formatter.html#before-output (2 spaces per indent level)

I ran all of the queries through the formatter as suggested and updated the examples with the results.

Certain table docs just have a single query

Some of these tables is really, really simple, but I added one more for _naabu.

The doc files look great. You could make minor formatting updates per the namecheap plugin docs

Thanks. There are links there that would point to hub.steampipe.io that do not exist. Once/if the plugin becomes listed I'll add/update those.

The references to the social-graphics and icons are missing.

I don't have any graphics to link.

The doc file has a reference to an api_key for authenticated

Update to the correct key names.

Is there a specific reason for choosing osint as the plugin category?

Yes, the projectdiscovery toolsets are used in footprinting, reconnaissance, open source intelligence.

The Get Involved section incorrectly references

Updated.

Please update the install command as follows

Done.

s there a specific reason why we need to add the local installation command?

Left over debugging code. Removed it now.

How are we handling the resource not found errors?

The tables just have empty results then.

Do the APIs support pagination?

Not all of the tools make use of traditional API's (eg. naabu). However, in the case of cloudlist, pagination is handled by the underlying library.

While working with the APIs did you encounter rate limit errors?

No.

Thanks @leonjza for the quick update 👍.
We will be taking care of the social graphics and icon, apologies for making the process sound so complicated, but you could update the docs/index.md file to use the following references for the social graphics plugin -
---
organization: Sensepost
category: ["osint"]
icon_url: "/images/plugins/sensepost/projectdiscovery.svg"
brand_color: "#2684FF"
display_name: "Project Discovery"
short_name: "projectdiscovery"
description: "Steampipe plugin for interacting with projectdiscovery.io toolsets."
og_description: "Query ProjectDiscovery with SQL! Open source CLI. No DB required."
og_image: "/images/plugins/sensepost/projectdiscovery-social-graphic.png"
---

Similarly, the README file could be updated to use the following social graphic reference:
![image](https://hub.steampipe.io/images/plugins/sensepost/projectdiscovery-social-graphic.png)

, but you could update the docs/index.md file to use the following references for the social graphics plugin

I added this.

Similarly, the README file could be updated to use the following social graphic reference:

This goes 404. Will wait for something to be there before adding it to the README.

, but you could update the docs/index.md file to use the following references for the social graphics plugin

I added this.

Similarly, the README file could be updated to use the following social graphic reference:

This goes 404. Will wait for something to be there before adding it to the README.

Actually, when looking at other repos, I'd prefer we don't add this banner to the readme. Is that going to be a blocker for you to publishing?

Not a blocker @leonjza 👍.
Thanks for updating the docs/index.md file 👍.

Just to close the loop here, anything else I need to do for publishing?

@leonjza I am taking a final look at the plugin structure. Overall it looks good for a release, but we are just waiting on the social graphics and icon 👍.
We can then push the plugin to the hub 👍.

@leonjza Is there a specific reason why we have not commented out naabu_top_ports in config/projectdiscovery.spc and docs/index.md files?

In my mind it's because that is the suggested default value folks should use, but obviously can change.

In my mind it's because that is the suggested default value folks should use, but obviously can change.

I don't think it's a deal breaker, but I think we could handle it in the code in a better way, like if the user does not pass in a value, we could fall back on port 100.
Couple of other enhancements that we could implement:

I think we should update the table docs to explicitly mention which config arguments are required to query each table. This could also be mentioned in the docs/index.md file.
Is there a specific reason as to why we have not followed the error logging used across other plugins? For instance, https://github.com/sensepost/steampipe-plugin-projectdiscovery/blob/master/projectdiscovery/table_projectdiscovery_dnsx.go#L50 could be replaced by logger.Error("projectdiscovery_dnsx.listDnsxScan", "api_error", err). Similarly, https://github.com/sensepost/steampipe-plugin-projectdiscovery/blob/master/projectdiscovery/table_projectdiscovery_dnsx.go#L44 should also include logger.Error("projectdiscovery_dnsx.listDnsxScan", "connection_error", err).

v0.1.1 should be good to go.


Need guide to port device/kernel to a new Android version

It is difficult to find ressources about upgrading a device to a new version of Android.
If you have this kind of ressources, even if it is for an older Android version, these are welcom.

Wrong repo


open-color.css in NPM package

Is there a reason you chose not to include a .css in the package?

Oh no, it was my mistake. I published the package now. Would you update the package again?

If you have any trouble, please reopen this issue.


docs for webview2 installer preview

DO NOT MERGE
Doc update for WebView Runtime and installer preview happening soon. I will follow up on the Insert sample code or step-by-step guides in a later commit. Target date for merging 6/23.

Docs Build status updates of commit a33c814:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/roadmap.md
:warning:Warning

Details

microsoft-edge/webview2/releasenotes.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/versioning.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md

Line 35: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'
Line 39: [Warning-bookmark-not-found] Cannot find bookmark '#roadmap' in 'webview2/concepts/distribution.md'

microsoft-edge/webview2/releasenotes.md

Line 60: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'

microsoft-edge/webview2/concepts/versioning.md

Line 20: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Converted to draft per "DO NOT MERGE" note.

Docs Build status updates of commit f104ae9:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:warning:Warning

Details

microsoft-edge/webview2/roadmap.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/versioning.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md

Line 60, Column 200: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'.

microsoft-edge/webview2/roadmap.md

Line 35, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'.
Line 39, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#roadmap' in 'webview2/concepts/distribution.md'.

microsoft-edge/webview2/concepts/versioning.md

Line 20, Column 224: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 22fa80d:
:clock10: Pending: waiting for processors (8 builds ahead of you)
:warning: Docs Build is busy, currently there are 8 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 22fa80d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:warning:Warning

Details

microsoft-edge/webview2/roadmap.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/versioning.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md

Line 60, Column 200: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'.

microsoft-edge/webview2/roadmap.md

Line 35, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'.
Line 39, Column 10: [Warning-bookmark-not-found] Cannot find bookmark '#roadmap' in 'webview2/concepts/distribution.md'.

microsoft-edge/webview2/concepts/versioning.md

Line 20, Column 224: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Added editorial review.

Docs Build status updates of commit a3ba5cd:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/versioning.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md

Line 42, Column 58: [Warning-bookmark-not-found] Cannot find bookmark '#experimental-apis.md' in 'webview2/concepts/versioning.md', did you mean '#experimental-apis'?

microsoft-edge/webview2/concepts/versioning.md

Line 20, Column 224: [Warning-bookmark-not-found] Cannot find bookmark '#microsoft-edge-webview2-runtime' in 'webview2/concepts/distribution.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b6b229a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 440bf60:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

@jm-trd-ms I'm seeing a lot of edits unrelated to this installer preview/PR (the changes in release notes, versioning, and roadmap). Can you move them to a separate PR?

Docs Build status updates of commit d251fea:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/distribution.md

Line 15, Column 316: [Warning-bookmark-not-found] Cannot find bookmark '#evergreen-webview2' in 'webview2/concepts/distribution.md'.
Line 15, Column 353: [Warning-bookmark-not-found] Cannot find bookmark '#fixed-version-webview2' in 'webview2/concepts/distribution.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit d53ee1f:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 7881602:
:clock10: Pending: waiting for processors (25 builds ahead of you)
:warning: Docs Build is busy, currently there are 25 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 7881602:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b3e686d:
:warning: Validation status: warnings

File
Status
Preview URL
Details

microsoft-edge/webview2/releasenotes.md
:warning:Warning

Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md

Line 66, Column 198: [Warning-bookmark-not-found] Cannot find bookmark '#deploy-webview2-runtime' in 'webview2/concepts/distribution.md'.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Quick fix to a link in release notes.

Docs Build status updates of commit eb27b58:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Cleaned up merge conflict with origin.

Docs Build status updates of commit 686a9d2:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 39f220d:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 774d9c0:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 2d71ed2:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 79079bc:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 3618af6:
:clock10: Pending: waiting for processors (6 builds ahead of you)
:warning: Docs Build is busy, currently there are 6 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 3618af6:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 2cd750c:
:clock10: Pending: waiting for processors (7 builds ahead of you)
:warning: Docs Build is busy, currently there are 7 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 2cd750c:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 667443a:
:clock10: Pending: waiting for processors (152 builds ahead of you)
:warning: Docs Build is busy, currently there are 152 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 667443a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 39244a4:
:clock10: Pending: waiting for processors (152 builds ahead of you)
:warning: Docs Build is busy, currently there are 152 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit 39244a4:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit b8be39a:
:clock10: Pending: waiting for processors (143 builds ahead of you)
:warning: Docs Build is busy, currently there are 143 builds ahead of this one, for more information you can view the Build queue graph on the Docs Portal.

Docs Build status updates of commit b8be39a:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit df51ef7:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

Docs Build status updates of commit 8f87742:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

microsoft-edge/webview2/concepts/distribution.md
:white_check_mark:Succeeded

microsoft-edge/webview2/concepts/versioning.md
:white_check_mark:Succeeded

microsoft-edge/webview2/releasenotes.md
:white_check_mark:Succeeded

microsoft-edge/webview2/roadmap.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
For any questions, please:Try searching in the Docs contributor and Admin GuideSee the frequently asked questionsPost your question in the Docs support channel

#sign-off offline and merged.


Add draft of CoCo operating policies

The intent of this is to let the community know how the CoCo intends to operate, to clarify some of the communication channels to/from the CoCo and to provide an outline for future CoCos as to how we operated.

Looks good to me!


Upgrade CLI11 to 1.9.0 - develop

Change Description
This commit fixes #8947 by upgrading CLI11 to the latest version.
Consensus Changes

[ ] Consensus Changes

API Changes

[ ] API Changes

Documentation Additions

[ ] Documentation Additions

@revl pointed out this is "BSD 3-Clause license"

Special instructions for GCC 8

It's actually more complicated than those instructions suggest.
On GCC8 it's -lstdc++fs but with GCC7 you also need something like
#include <experimental/filesystem>
namespace std {namespace filesystem = std::experimental::filesystem; };

Of course this isn't really a GCC thing, it's a standard library thing, so clang when using gnu's stdlib will also need those workarounds. i.e. you can't go by compiler, you need to actually test what works.
But then if you're using llvm c++ lib, on version 8 & 7 you need -lc++fs instead. And on llvm's c++ lib before that you need -lc++experimental
So.. maybe best to disable that filesystem support across the board unless we need it.

Hopefully we don't use filesystem. CLI11_HAS_FILESYSTEM=0 will disable it.

@revl pointed out this is "BSD 3-Clause license"

In fact, the text of the license hasn't changed in years. They just added a verbatim copy of the license to their single file distribution.

Can you add a test for one of the problematic cases to one of the integration tests.

For maintenance I think your test should be in python not sh. You can add it to an existing test or create a new one.


Environment yaml file with explicit versions

Hi everyone,
Thanks for the great project and repo! I was wondering if you could provide an environment yaml file that has explicit versions of each package. The reason is that I'm having version trouble with packages like DGL (I get cuda-related errors after building the environment from this file; installing dgl-cuda then gives me DGL version 2.X, but the syntax of espaloma seems to only work with DGL version 1.X). I think this should be as easy as taking one of your working espaloma conda environments, and exporting it with conda env export > environment.yml.
Thanks!
Simon

Hey Simon!
Sorry for taking so long to get back to you. We just released a new version of espaloma that is easier to install with conda install -c conda-forge -c dglteam "espaloma=0.3.1" "dgl<1" We are close to getting dgl on conda-forge which will make it even easier to install (and support newer dgl 1.x code.

No problem! This looks great, thank you :)

Let me know if you have any issues getting this working for you :)


Fixed open_browser issue and added functionality for map and config file

Fixed issue-2 regarding the 'open_browser=False still opens browser '
added functionality to save maps at custom location
added functionality to use a custom json config file
added corresponding changes to the README.md

Hey @kylebarron, do you plan to merge this pull request? The addition of output_map  and config_file arguments make this excellent tool that you have written even more flexible!

This PR is stale and has merge conflicts/needs to be updated with master. but in principle not opposed to merging

Ok. Do you plan to add those two arguments in the near future? That would be really helpful!

I don't have plans to work on this repo myself, but PRs are welcome. It probably wouldn't be too hard to update this PR with changes in master

Hey guys. I will resolve the conflicts by today and will commit again.

Thanks @ikespand! Hope @kylebarron merges these changes soon. :)

@ikespand, did you get a chance to work on this?

Sorry @ashirwad .. Things were little chaotic here. But, will commit the suggestions within 2 weeks.

No worries, @ikespand! Hope you are doing well. And thanks again for all your help with this. :)


Migrate to Travis' container infrastructure

See: http://docs.travis-ci.com/user/migrating-from-legacy

:+1:


[Feature]move window to different virtual desktop

Describe the feature you'd like
Some software with single instance mode will be more convenient if it can be moved between virtual desktops, For example, double commander.
Related projects (Optional)
The existing projects with a similar feature that you can think of.

I have received similar proposals at #38. I will consider it.


Page.publisher_public_id sometimes loses it's reference

Our production systems are currently on Python 2.7, Django 1.7, CMS 3.1, MySQL 5.6. (We are in the process of moving to Django 1.8, CMS 3.2.)
Occasionally (at least 3 times in the last 6 months) publishing a page causes the cms_page.publisher_public_id foreign key to get set to null on either a) the draft version or b) both the draft and non-draft versions of the 'pair' of cms_page records. This corrupt data can then result in several unhandled exceptions, including attempting to invoke cms.api.get_page_draft on a non-draft page:
def get_page_draft(page):
    """
    Returns the draft version of a page, regardless if the passed in
    page is a published version or a draft version.

    :param page: The page to get the draft version
    :type page: :class:`cms.models.pagemodel.Page` instance
    :return page: draft version of the page
    :type page: :class:`cms.models.pagemodel.Page` instance
    """
    if page:
        if page.publisher_is_draft:
            return page
        else:
            return page.publisher_draft
    else:
        return None

Specifically, when invoked on a non-draft page, the line return page.publisher_draft throws an exception because the reverse lookup fails due to the foreign key being null.
This issue is intermittent and we cannot reproduce the problem, so unfortunately, I'm unable to run it through a debugger to get any better information.

See also https://github.com/divio/django-cms/issues/3274

Below is a Django management command that fixes the null/lost/corrupt cms_page.publisher_public_id columns. It works on the assumption that the equivalent columns in cms_title are okay. In our experience, it's only the cms_page.publisher_public_id columns that get broken, so this assumption holds for us.
from django.core.management.base import BaseCommand

from cms.models import Title

class Command(BaseCommand):
    help = 'Fix CMS pages (publisher_public_id foreign key)'

    def handle(self, *args, **options):
        ts = Title.objects.filter(
            publisher_is_draft=False,
            page_id__isnull=False,
            publisher_public_id__isnull=False
        )

        fixed_count = 0

        # for each of the (non-draft, draft) title pairs, fix the equivalent (non-draft, draft) page pairs
        for t in ts:
            fixed = False

            if t.publisher_public.page.publisher_public is None:
                self.stdout.write('Draft page id {} has a null publisher_public_id (it should be {})'.format(
                    t.publisher_public.page_id,
                    t.page_id
                ))
                t.publisher_public.page.publisher_public = t.page
                t.publisher_public.page.save()
                fixed = True

            if t.page.publisher_public is None:
                self.stdout.write('Non-draft page id {} has a null publisher_public_id (it should be {})'.format(
                    t.page_id,
                    t.publisher_public.page_id
                ))
                t.page.publisher_public = t.publisher_public.page
                t.page.save()
                fixed = True

            if fixed:
                fixed_count += 1

        self.stdout.write('Fixed {} pairs of pages.'.format(fixed_count))

Here is part of a stack trace that could be helpful:
[19/Jan/2016 10:05:30] ERROR [django.request:231] Internal Server Error: /en/
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/django/core/handlers/base.py", line 111, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/local/lib/python2.7/dist-packages/cms/views.py", line 188, in details
    context['has_view_permissions'] = page.has_view_permission(request)
  File "/usr/local/lib/python2.7/dist-packages/cms/models/pagemodel.py", line 1029, in has_view_permission
    is_restricted = bool(get_any_page_view_permissions(request, self))
  File "/usr/local/lib/python2.7/dist-packages/cms/utils/permissions.py", line 336, in get_any_page_view_permissions
    page = page.publisher_draft
  File "/usr/local/lib/python2.7/dist-packages/django/db/models/fields/related.py", line 428, in __get__
    self.related.get_accessor_name()
RelatedObjectDoesNotExist: Page has no publisher_draft.

I experienced the same on Django 1.8.9 / Django-CMS 3.2.0 / Postgres 9.1
The management command helped! Thanks a bunch @mikemcgowan

Same situation. The management command worked like a charm.  Thanks for sharing.
Django==1.8.9
django-cms==3.2.0
django-reversion==1.9.3
Postgres

django CMS 3.3 and 3.4 contains a lot of fixes regarding the tree handling. Some of them have been backported to 3.2.5. You are encouraged to upgrade to fix those

Hello @bartTC,
I don't think we've made modifications in regards to transactions on 3.4, at least no on the publication of pages.
Using your script, combined with cancelling, are you able to reproduce the issue on 3.4?

I am able to reproduce this within a regular production build by triggering a reversion. That one fails (I dont know the reason yet) with the standard exception.

RevertError: Could not revert revision, due to database integrity errors.

The result is a lost Public > Draft relation, it can be fixed by the script(s) mentioned here.
I'm trying to encapsulate this into a test next.

@bartTC revisions were removed on cms 3.4 (this was one of the reasons), are you using an earlier version?

Closing as this issue appears to be stale and there is no feedback that the proposed fixes in 3.4 did not work. I have never heard of this on any project 3.5+ so assuming fixed.
Due to the age of this issue we are unable to safely accept the contribution. If you feel this issue is still required please inform a member of our technical committee<EMAIL_ADDRESS>Nevertheless we thank you for your participation and would like to emphasize that we do not want to discourage you in your contribution to the django CMS project. On the contrary, we encourage everyone who is interested in the success of django CMS to join us!
If you want to learn more about the work of the technical committee, our product vision and how you can become a member of the dCA, you can find all information here:

The Technical Committee of the django CMS Association
Technical Roadmap and Product Vision for django CMS
How to become a member of the django CMS Association

We are looking forward to every companion who would like to shape the future of django CMS together with us!
If you have any questions, feel free to reach out to Nicolai, our Community Manager<EMAIL_ADDRESS>Sign up for the Association now!


Update artifact download and upload to use the toolkit @actions/artifact 2.0 or later API to be compatible with actions/upload-artifact@v4

The artifact download and upload code uses an older API to access artifacts, which is not compatible with actions/upload-artifact@v4.  It's desirable to move toward that API, and secondlife/actions-autobuild should use that API to upload it's autobuild artifacts.

Fixed in https://github.com/secondlife/action-autobuild-release/pull/47


Fix #6: Only import unittest during test run.

Raise exception if unittest2 not installed for Python < 2.7.
Doing this instead of adding requirement as many (most) installs
won't need to run the tests.

Cool. Merging. And I'll have a new release with this soon. And really sorry for the insane delay. Had some personal issues that kept me from this.


Improving layout editor testing coverage and a conversion tool from perspective editor format to layout editor model

…

https://github.com/uberfire/uberfire-extensions/commit/9a5cb865e

Should the layout definitions really say "rowSpam" I'd have thought you meant "rowSpan"?

@manstis it's a typo. I'll fix that next time that I touch that code.


No operations defined in spec!

Hi,
I inspected a few issues that were closed that have the same outcome that I have, no documentation generated with swagger after configuring SwashBuckle in the middleware.

I have the latest version of Firefox.

I've downloaded the latest version of the SwashBuckle.AspNetCore package for .NET Core 2.2

I'm using Visual Studio 2019 Entreprise

I've configured the middleware services to use SwashBuckle

-I've configured the middleware to render the .json file in the UI

There's actual XML documentation in my controllers

The XML documentation has been activated in my build configuration:

in my case I was having two HttpGet methods with the same name.   You can view more details of issue in output window


[Pick 2.0] "Fix data loss when node channel been cancelled before close wait (#36662)"

Proposed changes
Pick from https://github.com/apache/doris/pull/36662

run buildall