[WIP] Add flag to warn about unused dependencies

This commit adds an experimental flag to cargo, -Zwarn-unused-deps.
If the flag is enabled, cargo will warn about unused dependencies. rustc issue for the feature: https://github.com/rust-lang/rust/issues/57274
The goal is to stabilize it eventually, enabling it by default.
The lint builds upon the --json=unused-externs flag of rustc
that is being proposed for this purpose in the companion PR https://github.com/rust-lang/rust/pull/73945 .
This PR makes cargo pass the flag if -Zwarn-unused-deps is enabled to compilations of units it prints warnings for.
During compilation, cargo collects the unused dependencies
from all units, converts them into used dependencies,
continuously extending the record of used dependencies for
any type of DepKind: [dependencies], [dev-dependencies] and
[build-dependencies].
Once the compilation has ended, this record is used to
obtain those dependencies in a class that weren't used by any unit,
and warn about them.
The goal is to stabilize the flag and enable it by default
once the lint has become robust and the robustness is proven.
Then, cargo shall opportunistically warn about unused dependencies
when it has compiled (or loaded the unused externs from cache of)
all units that could possibly use dependencies of the kind.
Roughly, it's like this:

cargo always compiles build.rs
cargo check compiles all units that would use [dependencies]
cargo test --no-run --all-targets compiles all units that can use
[dev-dependencies]

TODO
The PR is still WIP but I've opened it to get initial feedback. TODO list:

[x] Making cargo figure out the allowed dependency kinds to warn about. Found a solution that should work
[x] Support #[cfg(test)] use extern_crate as _;
[x] Doctest support. There is no separation of build vs run steps for them (cc #6424) so we'd have to block after they have finished. And we'll have to add json unused deps reporting to them in the first place. Currently we just skip them leading to false positives if a dev dependency is only used in doc tests.
[ ] Finish the tests

cc @ehuss @jsgf

r? @ehuss
(rust_highfive has picked a reviewer for you, use r? to override)

This is a table of some commands and what they actually compile/check:

lib.rs
main.rs
lib.rs cfg test
tests/
benches/
doctests

check
yes
yes
no
no
no
no

check --all-targets
yes
yes
no
yes
yes
no

test --no-run
yes
yes
yes
yes
no
no

test
yes
yes
yes
yes
no
yes

test --all-targets
yes
yes
yes
yes
yes
yes

So practically in almost every instance cargo can't warn about dev-dependencies without making false positives possible.

If cargo can't support dependency warnings as a side effect of normal builds, does dependency checking need to be its own explicit operation? Eg cargo check --dependencies which does a check build on all possible targets and complain about completely unused targets (and make fix proposals to remove unused deps or move deps to dev/build deps).

@jsgf in fact I think a command that compiles every part of a crate would be useful even outside of the unused dependencies scenario, to ensure that no code is breaking the build. Currently there is no such command. But I think that should better be discussed separately from this PR, as the PR implements checks for normal and build dependencies as well, and those checks are both more helpful (people depending on your crate don't compile your dev deps, only the normal and build deps), as well as more easily triggered (cargo build/check/test without any params all trigger the warnings). A rejection of such a mode, or any technical difficulties with implementing it shouldn't slow down the introduction of warnings for normal and build deps.

This is a pretty slick way to detect unused dependencies, thanks for prototyping this!
One thing I figured I'd comment on is that warnings is one thing Cargo has historically not handled well. Generally with warnings you want the ability to do something like "turn them all to errors" or "allow them for this project or temporarily". This is handled really well in the compiler with #[allow], #[deny], -D, etc. Cargo has no similar system, however, and it's not entirely clear how we'd hook up such a system.
More concretely, I think that new warnings could fall short in a few situations:

On CI folks probably want to run this but with a "turn warnings into errors" mode.
For some crates they may wish to permanently opt out of "don't warn about that crate" for one reason or another.
Sometimes during local development you may want to turn warnings off but then have them back on once you push to CI.

Since this is being developed in tandem with rustc I think it would be great to basically just figure out how to get rustc to emit these warnings one way or another. Either that or let rustc make all the decisions about whether Cargo should be allowing or denying warnings. Or... something along those lines, I don't know of a great solution myself, but I wanted to at least write this up since I think it will be important to get right.

@alexcrichton

Generally with warnings you want the ability to do something like "turn them all to errors" or "allow them for this project or temporarily". This is handled really well in the compiler with #[allow], #[deny], -D, etc. Cargo has no similar system, however, and it's not entirely clear how we'd hook up such a system.

Yeah, before the feature is stabilized and enabled by default there should be a way to turn off the warnings at least. I'm not certain myself how it should look like so I thought it should be done after the PR but we can already discuss it now.

For some crates they may wish to permanently opt out of "don't warn about that crate" for one reason or another.

There's already support for this in the PR! It works just like let _v = 42; works. You prefix the name with a _:
_bar = { package = "bar", version = "0.1.0" }

But there is also a way to do it from Rust code via use cratename as _;.

I think it would be great to basically just figure out how to get rustc to emit these warnings one way or another.

In fact this has already been implemented for buck use cases in https://github.com/rust-lang/rust/pull/72342 , but for cargo it is not suiting, as cargo doesn't have a 1:1 correspondence between dependencies and compilation units. In order to detect that an entry in the [dependencies] of Cargo.toml is really unused, you'll need output from multiple compilation units if you have multiple [[bin]] sections, or a lib and a bin section. So you'd get the unused dependency warning multiple times and it might still be wrong as it's used by one of the other units. Detecting unused dev-dependencies is even harder. There are proposals to make people list dependencies of every unit in Cargo.toml, and I support the idea especially to separate binary dependencies from library dependencies (e.g. crates.io users of cargo-the-library currently compile some dependencies needed for the binary even though it's not required), but to specify special dependencies for each of the dev units would be extremely unergonomic, so I doubt there will be lots of support to deprecate dev-dependencies entirely.

Either that or let rustc make all the decisions about whether Cargo should be allowing or denying warnings.

rustc would have to tell this info to cargo in some way so that cargo could unify the output from multiple units and tell the result. I could add info on whether to allow, deny, or warn to the json output communicated by rustc.

:umbrella: The latest upstream changes (presumably #8427) made this pull request unmergeable. Please resolve the merge conflicts.

One idea we had for warning control in yesterday's Cargo meeting is that rustc could emit warnings/errors for unused crates (e.g. unused --extern flags) and then Cargo would just not emit them by default. Cargo already buffers all diagnostics so it could just decide to not actually emit some of the diagnostics.
This strategy would require Cargo to be able to identify lints precisely for unused crates (it's either already in the JSON structure or presumably we could add it). It would also require the addition of a "non fatal error" in rustc where if the lint is #[deny]'d then it wouldn't actually halt compilation or fail compilation, instead the final status code would be left up to Cargo.
Unifying this across many crates would look something like:

If any unit that could use crate foo didn't emit a diagnostic, then all diagnostics relating to foo being unused (warnings and errors included) are squelched. This either means that a unit wasn't compiled or something had #[allow].
If all units that could use a crate foo emitted a diagnostic, then the highest severity level is emitted. For example if everything warned then a warning is emitted (a single warning), and if anything emitted an error an error is emitted. We'd probably do some sorting or something like that to ensure the same diagnostic deterministically comes out.

That will require more changes in rustc for sure, but it seems quite appealing in terms of being able to control lint levels in Cargo.

@alexcrichton if I have this code:
fn hello() {
}
mod foo {
}
mod bar {
}

Then why should a #[allow(unused)] on mod bar silence the unused warning for hello? Adding #[allow(unused_dependencies)] to lib.rs would be the same concept. The units are the modules, conceptually.
Also see the PR description of https://github.com/rust-lang/rust/pull/73945 for further issues with that approach under the "Why not pass -Wunused-crate-dependencies?" section.
For controlling lint levels, I think that cargo should think about ways of allowing/denying lints for all units in a crate or even workspace, as that's usually what people want when they control lints in their crate lib.rs root (#5034). Control over the unused dependencies lint could build on that. Depending on the name, if it starts with cargo::, it could interpret the lint as a cargo lint, or if not, pass it to rustc via a flag. The system already exists to distinguish clippy from rustc lints. Clippy lints start with clippy::. Cargo already emits other warnings. Maybe it would be useful to convert some of them into "cargo lints".

We explicitly are trying to avoid a system of managing lints in Cargo. It's not perfect to use rustc for this, but IMO it's way better than inventing something entirely new for Cargo.

We explicitly are trying to avoid a system of managing lints in Cargo.

Who is "we" in that sentence? You? The entire cargo team? Most of the complexity of a "lints for cargo" system would already be covered by #5034 , so not really be a cost introduced by the unused dependencies lint.

It would also require the addition of a "non fatal error" in rustc where if the lint is #[deny]'d then it wouldn't actually halt compilation or fail compilation, instead the final status code would be left up to Cargo.

It would make the unused dependencies lint different from all other lints. Furthermore, cargo wouldn't just always re-emit that warning/error unchanged if it wants to support "this should rather be a dev-dependency" or (in the future) "this should rather be a bin-dependency" like messages (wich this PR already does). So the entire distinction would have to be emitted by cargo.
Another issue would be that it would make doctests more complicated. Rustdoc has to collect the reports of all doc snippets and combine them. The more simple the format is, the easier this combination. It also offloads a lot of the ugly hacks to rustc so not sure whether the rustc team will support that (or the rustdoc team).

The "we" is the Cargo team. If you'd like to block this on #5034 that's your choice, but AFAIK there are no plans to implement that.
What I mentioned was a suggestion, if you don't want to pursue it, that's ok. The Cargo team's requirements have been laid out here and we're offering one way to do it, but if you'd rather do something else that checks the boxes that should work too.

Sounds fair! I'll think a bit about other approaches that satisfy the demands of the cargo team.
Note though that I won't have that much time to work on it in the next few months. The next thing I'll focus on will probably be json output for rustdoc errors. The mode will be required for implementation methods.

I've implemented doctests support, and I think I found a good design to giving rustc control over the lint level: if the arg is passed to print unused externs, rustc shall suppress emitting the unused externs lint, and document the lint level via the json message instead. Then cargo can read the level and use it to inform its decisions on the lint. Next step is to implement the design.
The doctest support breaks udeps output of cargo test --no-run because it waits with the lint emission until the doctests run (a doctest unit is created), but they never run, so it never emits the lints. I can think of two resolutions to this: either implement no-run mode for doctests, or make the code not generate a doctest unit if no_run is specified. I might want to do the former anyway so I'm holding back the latter until I know whether I want to do it or not.

So I've implemented support to specify the lint levels via #![allow], #![deny] etc. See the last commit. It will always take the most severe lint level it sees in any unit and apply it globally for all lints. This is the conceptually most simple approach, but it has chances to confuse ppl when they e.g. put an allow into a test and are surprised the warning is shown when no tests are run. I can't think of something equally simple and non-confusing other than #5034.

:umbrella: The latest upstream changes (presumably #8701) made this pull request unmergeable. Please resolve the merge conflicts.
Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

:umbrella: The latest upstream changes (presumably #8777) made this pull request unmergeable. Please resolve the merge conflicts.
Note that reviewers usually do not review pull requests until merge conflicts are resolved! Once you resolve the conflicts, you should change the labels applied by bors to indicate that your PR is ready for review. Post this as a comment to change the labels:
@rustbot modify labels: +S-waiting-on-review -S-waiting-on-author

The companion PR has been merged, so I believe this is no longer blocked!

@camelid I'll rebase the PR soon!

:umbrella: The latest upstream changes (presumably #9369) made this pull request unmergeable. Please resolve the merge conflicts.

I'm gonna close this due to inactivity. Feel free to reopen or create a new PR when you've got time to work on this again. Thanks!

The main blocker at this point is having a line with only "yes" inside in this table: https://github.com/rust-lang/cargo/pull/8437#issuecomment-653842297


[prototype] NVMTabular support

Is your feature request related to a problem? Please describe.
NVMTabular is a way to write ETL feature code for nvidia GPUs. Is there a Hamilton way to help organize the workflow required to run NVMTabular?
Describe the solution you'd like
The goal of the prototype is to figure out how Hamilton could be best used.
Describe alternatives you've considered
N/A
Additional context
E.g. what would the Hamilton version of https://github.com/NVIDIA-Merlin/NVTabular/blob/main/examples/getting-started-movielens/02-ETL-with-NVTabular.ipynb be?

We are moving repositories! Please see the new version of this issue at https://github.com/DAGWorks-Inc/hamilton/issues/34. Also, please give us a star/update any of your internal links.
Note that everything else (slack community, pypi packages, etc...) will not change at all.


[Doc] Invalid URLs in IS OpenID Connect Dynamic Client Registration REST APIs Documentation.

Describe the issue:
There are invalid URLs in the OpenID Connect Dynamic Client Registration REST API documentation.
Missing forward slash in the URL OpenID Connect Dynamic Client Registration REST APIs

Expected behavior:
Should be https://localhost:9443/api/identity/oauth2/dcr/v1.1

This issue is being closed due to extended inactivity. Please feel free to reopen it if further attention is needed. Thank you for helping us keep the issue list relevant and focused!


Chess and other non-trivial games

Search before asking

[X] I have searched the MuZero issues and found no similar feature requests.

Description
Is there a successful implementation of chess or other non-trivial games?
Thank you.
Additional context
No response

If you just want an environment, the following issue might be helpful.
https://github.com/werner-duvaud/muzero-general/issues/166
If you meant if there is one created from scratch, I can't help.

Hello, thank you to the contributors for their outstanding work on this repository. Regarding the issue you've raised, you might be interested in the project "LightZero: A Unified Benchmark for Monte Carlo Tree Search in General Sequential Decision Scenarios". This repository not only supports the AlphaZero algorithm but also extends support to MuZero and a series of related algorithms and environments, which might meet your requirements. Best wishes.


docs(new spincli features): update spincli documentation

This documents new features for the spin CLI.
For projects, these features reference:
https://github.com/spinnaker/spin/pull/261
https://github.com/spinnaker/spin/pull/260
https://github.com/spinnaker/spin/pull/258
https://github.com/spinnaker/spin/pull/270
For pipelines, these features reference:
https://github.com/spinnaker/spin/pull/280
https://github.com/spinnaker/spin/pull/278
While these features are in current master, I'm unsure of how coordination with spin cli releases and documentation get coordinated, but thought I'd open the PR since its in master for spin CLI.

Those new features are for 1.22, but they're on master right now. @brian-armory should we only merge it after 1.22 has been released?
Here's the calendar. It looks like it's suppose to go out around 8/24.

Cool, let's merge this when it's available in a release on Aug 24.

@kevinawoo  @brian-armory  can this get merged now that @german-muzquiz has released spin 1.18.0? :tada:

I'll merge it now. Thanks for following up @Chinikins!


What happens if Snakemake has conda directives but no conda installed?

see #25 - taco location is separate from compute location, by default, so we use the same model as snakemake - submit individual jobs to individual nodes (however we happen to be configured to be able to do); if it doesn't have the software we need we will run into problems.
also see #15 - another issue that goes away when we treat the node that taco runs on as separate from the node that the compute tasks run on


Add respectivity async handling patterns by languages.

Async in depth summarise focusing only C#
Async in depth summarise focusing only C# language, so add "for C#" and another languages have respective pattern.
Details
If we are using for F#, async pattern is "async workflow" and using Async type better than Task type. But I feel this article suit for C#, one of the representative example.
I changed:

Write to it's C# pattern.
Write no explicitly  languages, but it's difference.

Extending @kekyo's point a little bit: Cross-references to the language-specific docs, such as:

Asynchronous programming - https://docs.microsoft.com/en-us/dotnet/csharp/async
Async Programming in F# - https://docs.microsoft.com/en-us/dotnet/fsharp/tutorials/asynchronous-and-concurrent-programming/async
Asynchronous Programming with Async and Await (Visual Basic) - https://docs.microsoft.com/en-us/dotnet/visual-basic/programming-guide/concepts/async/

... seem missing here in a See also section at the bottom. If adding them makes sense, then the line @kekyo added ...

(Any other languages have respective pattern.)

... could call out the language-specific resources in that section (and we'd possibly even remove the "C#" that @kekyo added in this PR, since that's somewhat obvious) ...

(Language-specific resources are found in the See also section.)

(:point_up: something along those lines)
## See also

[Asynchronous programming in C#](https://docs.microsoft.com/en-us/dotnet/csharp/async)
[Async Programming in F#](https://docs.microsoft.com/en-us/dotnet/fsharp/tutorials/asynchronous-and-concurrent-programming/async)
[Asynchronous Programming with Async and Await (Visual Basic)](https://docs.microsoft.com/en-us/dotnet/visual-basic/programming-guide/concepts/async/)

Last question: If that's a good add here, wouldn't it also be a good add these over in Asynchronous Programming Patterns with a little better cross-linking among the three docs on async in the .NET Platform Guide section?
cc/ @cartermp @BillWagner @rpetrusha

@kekyo If you want to add a See also section here (and at the bottom of Asynchronous Programming Patterns), there's an important thing to note about lists without bullet points. When you list links back-to-back without a blank line between them, such as ...
## See also

[Asynchronous programming in C#](https://docs.microsoft.com/en-us/dotnet/csharp/async)
[Async Programming in F#](https://docs.microsoft.com/en-us/dotnet/fsharp/tutorials/asynchronous-and-concurrent-programming/async)
[Asynchronous Programming with Async and Await (Visual Basic)](https://docs.microsoft.com/en-us/dotnet/visual-basic/programming-guide/concepts/async/)

... you must include three spaces at the end of lines before the last line. This is currently undocumented (but we'll document it soon). So for those three links, set them up like this ...
## See also

[TITLE_HERE](<LINK_HERE>)<PUT_THREE_SPACES_HERE>
[TITLE_HERE](<LINK_HERE>)<PUT_THREE_SPACES_HERE>
[TITLE_HERE](<LINK_HERE>)

@GuardRex, I think your suggested improvements to the topic are valuable. Could you open an issue that addresses them? @kekyo, thank you so much for pointing out the single-language focus of this topic and for making corrections. We'll merge your PR. Thanks again for your contribution!

I respond late sorry, thanks merged my proposal!


[Upgrade] Angular 8

Please  upgrade module to angular 8

https://next.plnkr.co/edit/I3MoLhxz1NO9PVtMTiaH?p=preview&utm_source=legacy&utm_medium=worker&utm_campaign=next&preview
Working fine with angular 8


Posible Bug with players in PvP

Hi, when players are in pvp they cant eat golden apples,

Bowie hi e.e I have been researching for this problem, trying to solve it for MyCraft, and It has to do with the programación of this program, The only way I would say for you to allow it on your server is to create an RPGitem with the attributes of a Golden Apple. I sent a message to KevinBC, I would like to see if could you please send me your what's app so that way I can inform you If I find something okay? I am DawamRM; helper on your server (Survival RPG 1) hehe I wanted to help but by now, use the RPGitem I sent to KevinBC, and please I would appreciate if you might give me your phone number, I have been researching, and is not only the Gapple, is any food at all. Thx For your time and I do speak Spanish I just felt like writing in English :v. Bye I will try to inform you somehow if I find something okay?

Programation* Plugin*

Programation* Plugin*

Are you using 1.9 or 1.10?
this bug has been fixed in 1.11 branch https://github.com/NyaaCat/RPGitems-reloaded/issues/173

We are using 1.8


detailed tutorial

1.Can you provide a detailed tutorial on building a Tums im cluster? It's the most perfect kind
2."docker compose -f docker-compose.standalone.yml --profile monitoring up"："Mini" and "rasa" were not started,How to run it
3.How to build a "mongo" cluster with multiple nodes using "turns im"

Please read:
English: https://turms-im.github.io/docs/server/deployment/getting-started.html
Chinese: https://turms-im.github.io/docs/zh-CN/server/deployment/getting-started.html


devendorize internal stackdriver bindings

Move internal bindings to an internal directory, avoiding the vendor problem.
Replaces https://github.com/istio/istio/pull/14046#issuecomment-491946092
/assign @douglas-reid
/assign @geeknoid
/assign @bianpengyuan
Signed-off-by: Kuat Yessenov<EMAIL_ADDRESS>

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: linsun
If they are not already assigned, you can assign the PR to them by writing /assign @linsun in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-local-presubmit-tests.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test integ-mixer-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-local-presubmit-tests.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test integ-mixer-local-presubmit-tests-master

prow/istio-unit-tests.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-local-presubmit-tests.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test integ-mixer-local-presubmit-tests-master

prow/istio-unit-tests.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test istio-unit-tests-master

prow/istio-presubmit.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test istio-unit-tests-master

prow/istio-presubmit.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test istio-presubmit-master

prow/integ-mixer-local-presubmit-tests.sh
bccf9040ce2285629d5980a2726b6ae0c4db4b9f
link
/test integ-mixer-local-presubmit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-presubmit.sh
cbdbbfe6fa06a56e2ca1e97f46d3f54f15706ef4
link
/test istio-presubmit-master

prow/integ-mixer-local-presubmit-tests.sh
bccf9040ce2285629d5980a2726b6ae0c4db4b9f
link
/test integ-mixer-local-presubmit-tests-master

prow/istio-unit-tests.sh
bccf9040ce2285629d5980a2726b6ae0c4db4b9f
link
/test istio-unit-tests-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kyessenov: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/integ-mixer-local-presubmit-tests.sh
bccf9040ce2285629d5980a2726b6ae0c4db4b9f
link
/test integ-mixer-local-presubmit-tests-master

prow/istio-unit-tests.sh
bccf9040ce2285629d5980a2726b6ae0c4db4b9f
link
/test istio-unit-tests-master

prow/istio-presubmit.sh
bccf9040ce2285629d5980a2726b6ae0c4db4b9f
link
/test istio-presubmit-master

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: douglas-reid, kyessenov
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid
If they are not already assigned, you can assign the PR to them by writing /assign @geeknoid in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

/approve
/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: douglas-reid, geeknoid, kyessenov
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS [geeknoid]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


Nested UL under OL shows with numbers in PDF

Plugin Version 1.0.0.
This HTML:

Numbered

boolet

is rendered as a list that looks like
1. Numbered
   1. boolet

Found with Grails version 2.5.1


js error when searching

Describe the bug
When searching and entering specific characters, it throws an js error:
app.js:formatted:8280 TypeError: Cannot read property 'key' of undefined
It only happens to some characters, like "e", "o" i.e. Can't find a pattern though.
They have to be the start character, if writing them in a word like "header" it works fine.
Using version 1.3.0
To Reproduce
Steps to reproduce the behavior:
Start a search with above characters.
Desktop (please complete the following information):

OS: Win10x64
Browser: Chrome
Version  71.0.3578.98

hmm that's interesting 🥺
I've tried to search with the letters you mention it works fine, I couldn't reproduce the error
However, could please clear your cache and try again?

When searching for "headers" it works fine, as there is a result.
But when searching for 'headerstest' it just displays a blank field, no errors. (See here: https://cdn3.imggmi.com/uploads/2019/2/8/7b33cba937c936a4bc8552fc41912165-full.png)
But when searching with 'e', 'o' etc it just throws the error:
TypeError: "e is undefined" - app.js:formatted:8242
function Ve(e, t, n) {
if (!W && !X || 'undefined' == typeof console) throw e;
console.error(e)
}
Cache is cleared. Both on server and browser.

:( unfortunately, I couldn't reproduce the same error. If you have a live version to check that would be awesome

Hi @jesperholstjh ,
is this bug still there?


dart does not report an error when path is not valid

This tracker is for issues related to:
I think it is related to the Common Front End since both dart and dartanalyzer exhibit this issue.

Dart SDK Version (dart --version)
Dart VM version: 2.5.0-edge.f7902889b6e30a8b9d71416e1facf3c509aad06f (Mon Aug 19 20:43:02 2019 +0000) on "linux_x64"

Whether you are using Windows, MacOSX, or Linux (if applicable)
Linux x64

Whether you are using Chrome, Safari, Firefox, Edge (if applicable)
N/A

When I run dart on an invalid path, it return successfully without issues, e.g.
I have a directory contains only main.dart in my cwd, when I run
dart lib/../main.dart
it succeed without issue even though the directory lib does not exist. The path is consider as invalid as all other posix commands will fail, e.g.:
file lib/../main.dart
lib/../main.dart: cannot open `lib/../main.dart' (No such file or directory)

Dart should report an error in this scenario to be consistent with other tools.
c.c. @petrhosek

Note that dart accepts URI rather than classically file paths (this means for example that things like dart package:foo/bar.dart work out of the box). So in this context lib/../main.dart is treated as a relative URI rather than relative file path.
So I don't think comparison with classical tools really applies (none of them take URIs).
Given this I lean to declare this working as intended.


Rename the CLI to just 'levar', fixes #36

Coverage remained the same at 22.544% when pulling 17cde9927c2776e6464677db598ff653f8a8272e on 36-script-name into a876ae08f08463a6c1e63909a525a6b8e2980e25 on master.


Chore: Verify changes in the secrets are used by existing manifests

Description

After a cluster has been build, the secrets that have the credentials for various cloud providers could be updated with new ones. We need to ensure that the new workflow correctly handles changes to the secrets.
Exit criteria

[ ] Verify if claudie correctly handles changes to credentials with an existing cluster
[ ] Log any issue encountered under this Github issue

Should we de-couple Secrets from the cluster state (current/desired)?


fix: edit text focus behaviour

fix for issue #51

@rafifrabbani can u reproduce sample (can screen shot / or something) for prove it, if it running well, i will merge di pull request, thank you. you can give your result in this comment section

you can check the video https://drive.google.com/file/d/1AHJDMxSb3oXEFSfL6XpkxDVRXjKxEonT/view?usp=sharing @amirisback

you can check the video https://drive.google.com/file/d/1AHJDMxSb3oXEFSfL6XpkxDVRXjKxEonT/view?usp=sharing @amirisback

it's very nice, thank u so much, Welcome to the club


IE11 needs Elements.classList polyfill

Hi,
MathMLCompile.makeNode uses Elements.classList. which is not supported in IE11 and lower.
Is this by accident or design?
Also, It would be good if errors like this are logged and not only displayed as "Math Input Error".
It's easier to debug if you have a stack trace.

Duplicate of https://github.com/mathjax/mathjax-v3/issues/62

Sorry for the dup.
Weird thing is that even when using the polyfill classList.js: 1.2.20171210
I still get undefined in IE11 in MathMlCompile.makeNode...
console.log('node:', node, 'node.classList:', node.classList)

logs:
node: [object Element] node.classlist: undefined

Found that it was the dom4-polyfill that was causing this.
When using the classList polyfill before the dom4 polyfill it works fine.


[FLINK-28567][table-planner] Introduce predicate inference from one side of join to the other

What is the purpose of the change
This pull request adds predicate inference from one side of join to the other.
Example. (a0 = b0 AND a0 > 0) => (b0 > 0)
This change can lead to performance improvement of Join
Brief change log

Added org.apache.calcite.rel.rules.JoinPushTransitivePredicatesRule to FlinkStreamRuleSets and to FlinkBatchRuleSets

Verifying this change
This change added tests and can be verified as follows:

Added JoinPushTransitivePredicatesRuleTest that validates SQL plan with inferred predicate

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

Implemented https://github.com/apache/flink/pull/20432


refactor: public API

Re #1280
Given

rust naming conventions,
research described in #1280,
the fact that we often use the following chaining pattern,Ok(prql).and_then(prql_to_pl).and_then(pl_to_rq)

and my personal preference

... I'm changing public API to use {input}_to_{output} naming convention.
Additionally, I future proofed serialization and moved it into json module.

Super, thank you! And re of vs to — vever am I happier than when we do something better than I came up with


Github module displays label when offline

Describe the issue
When offline the github module displays regardless of empty-notifications = false.
Expected behavior:
The module either displays only when the last query resulted in a non-zero number of notifications or does not display even when offline (alternatively, allows for a custom offline label to be set).
Actual behavior:
Github module always displays when offline.
Was it working before?
Same behavior since I've first used github module (~3 weeks).

Did you also experience this bug in an earlier version of polybar?

Yes.

If no, what was the last version where this worked correctly?

To Reproduce
A minimal but complete config with which the problem occurs:
[colors]
background = #222
background-alt = #444
foreground = #dfdfdf
foreground-alt = #888
primary = #ffb52a
secondary = #e60053
alert = #bd2c40

[bar/main]
monitor = ${env:MONITOR:eDP-1}
width = 100%
height = 2.5%
radius = 6.0
fixed-center = false
bottom = true

background = ${colors.background}
foreground = ${colors.foreground}

border-size = 0
line-size = 2
padding = 1
module-margin = 1

font-0 = "Noto Sans Mono:size=10;1"
font-1 = "Noto Sans Mono:size=10;1"
font-2 = "Noto Sans Symbols:size=10;1"
font-3 = "Noto Sans Symbols2:size=10;1"

modules-left =
modules-center =
modules-right = github

tray-position = right
tray-padding = 2
tray-maxsize = 24

[global/wm]
margin-top = 0

[module/github]
type = internal/github
token = ${file:~/.config/github/notifications.token}
empty-notifications = false
;label = %{u#ff9900 +u} %notifications% %{u-}
label = %{u#0099ff +u} 📫 %{u-}
interval = 10

[settings]
screenchange-reload = true

; vim:ft=dosini

List any other steps needed to reproduce the issue besides starting polybar with the config you posted above.
Disconnect any internet connection.
Polybar Log
Post everything polybar outputs to the terminal when you run it and the issue occurs below
warn: module/github: cannot complete the request to github: Couldn't connect to server

Screenshots
If applicable, add screenshots to help explain your problem.
With full config:

Online (No notifications):

Offline:

Environment:

WM: xmonad 0.15-12
Distro: Arch Linux
Output of polybar -vvv:

polybar 3.3.1
Features: +alsa +curl -i3 -mpd +network(libnl) +pulseaudio +xkeyboard
X extensions: +randr (+monitors) -render -damage -sync +composite +xkb +xrm +xcursor
Build type: RelWithDebInfo
Compiler: /usr/bin/c++
Compiler flags: -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -Wall -Wextra -Werror -Wno-noexcept-type -pedantic -pedantic-errors
Linker flags: -Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
Additional context
Add any other context that you think is necessary about the problem here.
Appears to occur as a result of drawing whenever the condition in line 81 of github.cpp is met (0 != notifications || m_empty_notifications), in conjunction with the choice to return -1 from get_number_of_notifications when a non 200 http response is received and passing that directly to update_label.

Seems related to #910.

Yeah, some edge cases were not considered in the github module. If you add %notifications% to the label it would display -1, correct?
#910 should indeed fix all of this. If you want to, feel free to fix the segfault in the PR and resubmit it :)

It does show -1 as expected if I add %notifications%. The segfault from the PR should occur immediately when launching polybar, correct? I don't have much c++ experience, but it appears to occur for some reason when clearing m_label_offline. I'll look into it further and submit a PR if I can figure it out.

The segfault from the PR should occur immediately when launching polybar, correct?

Correct.
It's likely a null pointer dereference. Don't worry if you can't find the cause, we can also fix this later. But right now this has a very low priority for us.

I'll look into it further and submit a PR if I can figure it out.

From what I see, i think it crashes because m_label_offline is nullptr.
https://github.com/polybar/polybar/blob/4b38fdba20605e27f5070618fade25af6b1e2f29/src/modules/github.cpp#L103
If you look into the constructor it seems that the label is never loaded.
We have two options here:

We want to keep the old behavior by default and we should display the online label with -1
We change the behavior and display something like Offline

To fix the issue:
It seems that the format-offline is defaulted to "" rather than TAG_LABEL_OFFLINE.
https://github.com/polybar/polybar/blob/4b38fdba20605e27f5070618fade25af6b1e2f29/src/modules/github.cpp#L29
Once this modification done, depending of the selected option, we should modify this line:
https://github.com/polybar/polybar/blob/4b38fdba20605e27f5070618fade25af6b1e2f29/src/modules/github.cpp#L32

If we choose the first option, then the label should copy the online label and set %notifications% to -1. (Just after loading this label)
If we choose the second option, you should load m_label_offline optionally, like here:
https://github.com/polybar/polybar/blob/4b38fdba20605e27f5070618fade25af6b1e2f29/src/modules/github.cpp#L26 I think the default value should be "Offline" or something like that.

Do you have a preference on that @patrick96?
In my opinion we should choose the second option.
Once, we agree on something, you could try to implement that @kopecs, if you need more help don't hesitate to ask.

Maybe we should also deprecate the key label and replace it by label-online?

I've created a PR with the aforementioned second option, which seemed fairly robust from the perspective of not immediately crashing (or at all during testing for that matter) with several different configs, both with and without values for each option, although I didn't test every possible combo.

Thanks! I'll review that ASAP.


More decoupling

Remove Libuv and Hosting dependency from Kestrel.Core
Kestrel.Core depends on Hosting.Abstractions

Cool, except for KestrelServer : IServerAddressesFeature.

Spoke to @halter73 offline. I've added a private TlsConnectionFeature in the https connection adapter and added copyrights. This is the first stage to further dependency decoupling.


Tappable Footer for Rep. Contacts

Added a persistent Section Footer to the first section so that a user can scroll to contacting representative. To improve discoverability for new users.
Note: This is proof-of-concept & implementation combined. No problem if it doesn't get merged for design/usability reasons.
 I had an inadvertent problem with my vi editor and hadn't noticed all that mess from my previous squash!


feat(form): add method setValidators to FormControl

✨ Desired outcome: a new method in the FormControl class that allows setting the validators prop

Can try this!

Go for it @itsagift 🚀

Issue I'm running into now: returned to the simplest possible validator method, but no matter the method I've tried, in order for validator styling to work on the first render, there has to already be a validator array.
I think the issue lies in Form.astro and the data attributes, but I can't be 100% sure. I'm confused because using the setValue method will show validation styling on first render.
I can still create the pull request, just a heads up

When the value changes on setValue we call a method validate(value, validators) ... I think you should call this too when the validators change with setValidators. Can you check, @itsagift?

@ayoayco Sorry for late reply -- will do!

My latest commit has the validator method. I checked the setValue method and it seems like -- at least on the initial render -- the validate method is not needed in setValue in order to display properly. When the validation list is in the initial element. But yeah, none of this works with the initial render using setValidate.

Ah no worries. Yeah, if setValue is not used, i.e., if there is a value in the control configuration given to the FormControl constructor it is not needed. But if I remember correctly, it will be needed when, for example, you change the value programmatically with a control.setValue(...)
I can also take a look at your branch if you create a PR. Let me know! Maybe I'll just create a separate issue for rendering the validation after setValidators is called. ;)


basic structure created

I have created basic structure for the login layout. Styling is left, need the color code for the blue color.

You could use a color picker to select from the images in the milestone.md file. And do try to fix the conflict with your PR so it could be merged. Thanks @harshil1712

@phavor I have added the colors and have solved the merge conflicts


Allow complex contract signature schemes in wallet.Account

Close #3015
Implement second option from https://github.com/nspcc-dev/neo-go/issues/3015#issuecomment-1546110354
In the first one (interface instead of wallet.Account) we still have a problem with network fee calculation: actor modifiers are executed after network fee is calculated and there are no hooks to change invocation script.
This implementation disallows providing signature as an argument (though in a backward compatible way).
It is a restriction, but not a sad one: if we have a private key, we can always add a simple signer and provide its address to verify(), which can use runtime.CheckWitness to effectively perform the same check (with proper scopes it could be exactly the same).
Also, not sure about the meaning of CanSign, so didn't touch it here.
TBH I would remove func argument in the NewContractSigner in neotest, it introduces a subtle dependency on the condition order in SignTx. Other option is to provide an integer but it is also a bit annoying. As an example, there is wallet.NewContractAccount which can be used instead of notary.FakeContractAccount in complex cases and which could be reused in tests.
We have 2 similar usecases for complex Verify scenarios, and in every in test we use constant arguments, could be more concise:
s := neotest.NewContractSigner(e.Hash, func(*transaction.Transaction) []any { return []any{acc.ScriptHash()} })
// could be
s := neotest.NewContractSigner(e.Hash, acc.ScriptHash())

Initially I wanted to add type-safe VerifyAccount constructors to rpcbinding but is doesn't provide much benefit compared to effort taken.

#2670 is good, but we still have some better ones in the queue. Let's discuss this after 0.105.0 release.


checkMask will always fail if mask and image geometry do not match

checkMask essentially expects that image and mask geometry will match by calling Execute here: https://github.com/Radiomics/pyradiomics/blob/master/radiomics/imageoperations.py#L201
Thanks to Dev Gude for identifying and reporting this issue!

@Radiomics/developers let's discuss this tomorrow at the call

In featureextractor.py, checkMask is called after the image is loaded (includes any resampling): https://github.com/Radiomics/pyradiomics/blob/master/radiomics/featureextractor.py#L402
It is indeed true that this causes the extraction to fail if image and mask geometry do not match at this point. I programmed it like this to prevent features from being extracted from invalid image/mask combinations.
However, if resampling is enabled, there is a different type of checking done:
https://github.com/Radiomics/pyradiomics/blob/master/radiomics/imageoperations.py#L325
This piece of code is part of the resampling and checks if the ROI defined in the maskNode encodes for a physical space that is contained within the supplied image. If this is the case, the resampling grid is defined using the maskNode and applied to both mask and image, which ensures matching geometry.
So in short: if no resampling is enabled checkMask will fail when geometry does not match, but this is intended as such to prevent invalid combinations from being used.
If resampling is enabled, it is only required that the ROI in the mask encodes a tumor in the physical space contained by the image, with the resampling itself ensuring that then the geometry also matches up.

@JoostJM thanks for the clarifications!

I quickly looked over the user manual, and didn't find the place that explains how to enable resampling. Can you point me to that place in text? I think it would be good to link that from the FAQ entry.

Would it make more sense to print the error message and suggest that user could try resampling the mask instead of crashing with the exception?

@fedorov Good points! I will try to have a PR ready before the meeting tomorrow!

Great, thanks!
I think it will be very helpful to the user to provide more fine-grained diagnostics to troubleshoot the issue. These 2 will be very common, and very easy to troubleshoot, situations:

Problem: origin/spacing/directions differ by small amount. Solution: increase epsilon in the config file (assuming it is exposed) or enable resampling.

Problem: FOV is different, but mask FOV is inside the image FOV. Solution: enable resampling.

@fedorov
@ Problem 1: Yes epsilon's exposed as a global field (part of processobject)
I'll see what I can do, shouldn't be to difficult...


Add tests checking rrules gradients against finite differences

We should add some tests checking that gradients computed by our rrules are correct.
For this, we can use FiniteDifferences.jl or ChainRulesTestUtils.jl.

The thing is, our gradients will never be correct cause there is no correct gradients


Feature request - checkbox by names

As users make their selection, a checkbox appears by their names on the participants list

@danielrobertson feel free to re-open if still an issue.


ssh handshake failure: No common Algorithm

Received SSH failure no common algorithm while working with older lab gear.

Golang.org/x/crypto/ssh - The cbc ciphers were removed from the library a couple of years ago. Older routers and switches no longer share common cipher with this module, and therefore cannot  complete the ssh session setup. As a result only devices with the more updated standards can be connected to. As a work-around I've added "aes128-cbc" to cipher list. Appears to have resolved the issue.


Update cloudbuild docker image versions to 0.6.48

VSCode required a kotlinc path update in #25462, without that android projects cannot be compiled.

Hoftix: CI cannot validate this.


chore(master): release 3.1.0

:robot: I have created a release beep boop
3.1.0 (2024-12-15)
Features

Working chase effect (b26fae8)

This PR was generated with Release Please. See documentation.

:robot: Created releases:

v3.1.0
:sunflower:


awscli2: 2.8.6 -> 2.8.7

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.
meta.description for awscli2 is: "Unified tool to manage your AWS services"
meta.homepage for awscli2 is: "https://docs.aws.amazon.com/cli/latest/userguide/install-cliv2.html"
meta.changelog for awscli2 is: "https://github.com/aws/aws-cli/blob/2.8.7/CHANGELOG.rst"
Updates performed

Ran passthru.UpdateScript

To inspect upstream changes

Compare changes on GitHub

Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 2.8.7 with grep in /nix/store/pkkajgmk3igjr1nh9wcy527h1j8gf7gb-awscli2-2.8.7
found 2.8.7 in filename of file in /nix/store/pkkajgmk3igjr1nh9wcy527h1j8gf7gb-awscli2-2.8.7

Rebuild report (if merged into master) (click to expand)

2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath
awscli2
liquidsoap

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/pkkajgmk3igjr1nh9wcy527h1j8gf7gb-awscli2-2.8.7 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A awscli2 https://github.com/r-ryantm/nixpkgs/archive/e9098a84085ce1aedd6f2b2534621dd2dbb45d1c.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/pkkajgmk3igjr1nh9wcy527h1j8gf7gb-awscli2-2.8.7
ls -la /nix/store/pkkajgmk3igjr1nh9wcy527h1j8gf7gb-awscli2-2.8.7/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

2 packages built:

awscli2
liquidsoap

Maintainer pings
cc @bhipple @davegallant @bryanasdev000 @devusb @anthonyroussel for testing.

Result of nixpkgs-review pr 198424 run on aarch64-darwin 1

1 package marked as broken and skipped:

liquidsoap

1 package built:

awscli2


Graphics/emission map

Implementation of emission map

Hi Eric! Can you remove all the metas and binaries? Or are they needed in develop?

I removed binaries and metas of this PR.

Also it's not compiling for me

Until Efficient Rendering gives me the green light for this, it will remain in draft (I don't want someone to unintentionally merge it before that)


Withdraw modal sometimes blank (error token does not exist in pool)

Sometimes when switching between pools and hitting the withdraw button, the modal opens blank with an error in the console that a token with address does not exist in the pool. It does not say the token address (might be undefined? )

@mobiusTripper-crypto if you can reproduce this, would be great.

was an issue with state persistence between pools, this should be resolved


[Bug]: Hotham apps do not close correctly

What happened?
Background
As per #214, @sinoth found the following:

Run Simple Scene
Press Oculus button and select 'Quit' from system menu
Wait
See error that "Simple Scene keeps stopping"
Use error dialog to close the app

This is likely either an OpenXR or Android lifecycle issue.
Version
latest
In which Hotham component are you seeing the problem on?
Example
What VR System are you seeing the problem on?
Quest-2
What OS are you seeing the problem on?
No response
Relevant log output
No response

I noticed there's a similar issue when exiting out of the simulator by clicking the window exit button:
[HOTHAM_SIMULATOR] !ERROR RENDERING FRAME! ERROR_OUT_OF_DATE_KHR
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ERROR_VALIDATION_FAILURE', hotham\src\schedule_functions\end_frame.rs:18:28
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[HOTHAM_SIMULATOR] Destroy called..
[HOTHAM_SIMULATOR] All things are now destroyed
error: process didn't exit successfully: `target\release\hotham_crab_saber.exe` (exit code: 101)

I noticed there's a similar issue when exiting out of the simulator by clicking the window exit button:
[HOTHAM_SIMULATOR] !ERROR RENDERING FRAME! ERROR_OUT_OF_DATE_KHR
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: ERROR_VALIDATION_FAILURE', hotham\src\schedule_functions\end_frame.rs:18:28
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
[HOTHAM_SIMULATOR] Destroy called..
[HOTHAM_SIMULATOR] All things are now destroyed
error: process didn't exit successfully: `target\release\haotham_crab_saber.exe` (exit code: 101)

Good point! But that one's kind of unrelated; in that instance it just comes from really sloppy handling of the swapchain in the simulator. It's technically a bug but it's not that high of a priority (though you are totally welcome to open a separate issue for that).
I've refined the issue to make it clear this is specifically about the failure case that occurs on the headset. Closing the app through the normal Oculus menus should "just work", but it isn't.

May be something related to session lifecycle stuff:
https://registry.khronos.org/OpenXR/specs/1.0/html/xrspec.html#XR_OCULUS_android_session_state_enable


[suggestion]: click on Journal Link opens window, that's already minimized

I've been using your great tool for awhile now and I came across to minor issues in my latest sessions.
Issue 1.)
Situation: I have, let's say, two journals open and minimized in the taskbar.  an entry/link in journal_1 referes to journal_2. If I click on the link to open up journal_2 (miminized in taskbar), it won't come up. therefore I have to check where my journal_2 is in the taskbar and doubleclick it to open it. which is ok, when u have only 2 or 3 windows minimized. with more minimzed journals it get's tricky and costs time when I need the journal entry real fast.
Suggestion: click on a journal link opens up the referenced minimized journal
Issue 2.)
Situation: On my computer screen, after 5 or 6 entries the taskbar is full and any additonal windows get minimized behind the current taskbar.
Suggestion: is there a way to extend the taskbar below (if it's pinned on top)?
Thanks in advance and I hope it made sense what I was trying to explain.
-Philip

Hi @PhilMC157 - thank you for the real-game based feedback!

Regarding bug number 1, will take a look as soon as possible.
Regarding full entries, they should definitely not end up behind, on overflow, new minimized windows should have minimization functionality disable and be minimized floating

In the future, maybe we can do something better about overflows

These issues you reported are very tricky for me to reproduce, something else must be going on, or you are on an outdated version of Window Controls. Could you verify? also which System are you playing? to discard system conflicts...

I updated to your latest version (1.3.5). The overflow issue has slightly changed. Now the window floats on top of the scene navigtion.
And thanks for looking into Issue 1 as well.

@PhilMC157 - I see you updated to the latest version, so does issue number 1 still happen?? can you replicate it?
Regarding the floating windows, I think for now it is a good enough to survive no? we can focus on issue 1.

Issue 1 still happens. Just to be sure, I deactivated your module to see how it works in core and it has the same behavior.
Issue 2 rarely happens in my games anyways, because I don't use too many floating windows. Just by coincidence I stumpled upon the window overflow issue. Good enough to survive. ;)

Thank you @PhilMC157 -
if issue number one happens on Core Foundry, I am glad it is not me :D but we should still report the bug on Foundry VTT!
If issue number two, floating windows when "Overflowing" is good enough for now and there is nothing that impeds productivity or broken, there for now we are good!
Closing the issue for now! Let me know if there are any other points or questions.


Missing characters: add 埚 & 濑 to 10px

Hello, me again! We're still in the process of implementing the font, so I haven't been able to verify your addition for my previous request for 啧 (https://github.com/TakWolf/fusion-pixel-font/issues/25). My apologies.
I do have another request for the following characters, which I don't think are present in the 10px font:
埚
濑
Thanks in advance!

Add: 埚呙涡锅赖濑


Change convert to magick to support Windows: SVG images cause PDF export to fail

What version of mystjs are you using?
0.1.17
How did you install myst?
npm
What operating system are you using?
Windows
Which area is this feature request for?
Export: LaTeX or PDF
Describe the Bug
Running myst build --pdf fails if MyST document contains SVG images. Following error message is displayed:
Could not convert from SVG to PNG:
_build\temp\mystmqG4xb\images\aaecccbb623db43cfbe1b76430ef9e1b.svg
- Error: Command failed: convert -density 600  -colorspace RGB
- _build\temp\mystmqG4xb\images\aaecccbb623db43cfbe1b76430ef9e1b.svg
- _build\temp\mystmqG4xb\images\aaecccbb623db43cfbe1b76430ef9e1b.png
Invalid Parameter - 600

Expected Behavior
An exported PDF document.
To Reproduce
sample-doc.md:
---
exports:
  - format: pdf
---

# SVG Export Test

```{figure} https://myst-parser.readthedocs.io/en/latest/_static/logo-wide.svg
---
name: svg-export-test
---
SVG MyST Logo
```

This is a test

Thanks @riziles for the report! We will take a look and get back to you soon!

FYI, I signed up for a paid Curvenote account, and I'm able to export docs with SVGs beautifully from the Curvenote website. However if I use the Curvenote CLI and try to do it locally, I receive the same error message, so I'm guessing it must be either a Windows issue or something specifically wrong with my local setup.

@fwkoch has been redoing all of the image exports in #317 based on thinking through some of this.
Can you run, to see if it is a version mismatch?
convert --version

Error message is Invalid drive specification. .  FYI, my workaround of exporting the SVGs to PDF and just using those still works fine AND it keeps the images from getting rasterized.

convert --version

@rowanc1 , I am a little puzzled by this request. As far as I can tell, convert is a Windows system command to convert file systems on your hard drive. What does it have to do with rendering SVGs?

Hey @riziles - on unix systems, convert can be used for imagemagick - not so much for Windows! However, the recommended cross-platform command for imagemagick is magick - I'll update the CLI to use that.
Before getting too ahead of myself though, can you give it a try and make sure it works - ensure imagemagick is installed, then:
magick -density 600 -colorspace RGB input.svg output.png

Unfortunately it's not possible. ImageMagick requires admin rights to install, and I don't have 'em.

@fwkoch , quick update: there is a portable version on the ImageMagick website. I downloaded that, extracted it, added the folder to my user path list and was able to successfully run the command above.  That said, if the proposed solution is just to convert the SVGs to PNGs please don't do that on my account. I'd rather stick with my current workaround of converting them to PDF instead.

WAIT WAIT WAIT @rowanc1 / @fwkoch ! I just added Inkscape's bin folder to my Windows path list and all my errors went away and the fully vectorized SVGs are showing up beautifully in my PDF. C'mon, now.

We are adding some better docs on this in #317 (see below). We still need to actually change convert to magick to ensure that it actually works on Windows. I have updated the issue title as we narrow this down!
Franklin also added support for wildcard extensions (#304) which can be used for explicit export targets for various different platforms (e.g. a gif for web, and a pdf for latex).

convert to magick

@rowanc1 , why not stick with Inkscape instead of ImageMagick? They look so much better with Inkscape.

Note that the first part of this is going to be merged with #1388.


Prepared Statement Null Pointer Exception

I had a situation where an old DB driver I was using for a proprietary DB was returning a NULL PreparedStatement to HikariCP.  Hikari returned the Proxied PreparedStatement so it appeared that everything was ok, until you tried to invoke a method on the object.  Hikari would throw an internal null pointer exception when it tried to interact with the null preparedstatement reference it was now holding.
The driver was returning a NULL whenever the auto generated keys parameter was sent.
con.prepareStatement(sql, PreparedStatement.NO_GENERATED_KEYS)

I have not studied the spec, but this seems like a bug in the driver.  Thought I would let you guys know in case you wanted to put a check in for it.  I also had made a post on StackOverflow that has the stack trace and some other additional details.

Failure was due to JDBC driver bug.  The best HikariCP could do here is throw a different kind of exception, which is of questionable value.  Drivers have bugs, and allowing exceptions to rise to the application level unmodified helps identify the issue more quickly.


hotfix: change localization used for ARENA

Was previously using the localization for "5v5 Arena", now uses a more generic "Arenas".

#60  👈
working-trunk

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @juemrami and the rest of your teammates on  Graphite

Merge activity

May 30, 10:17 PM EDT: @juemrami started a stack merge that includes this pull request via Graphite.


Exporer does not show borgbackup mount

Windows Build Number
Microsoft Windows [Version 10.0.19042.906]
WSL Version
WSL 2
Distro Version
Fedora Remix for WSL
Other Software
borgbackup 1.1.16
Repro Steps
Mount a borg backup in WSL. Try to open the folder in Explorer.
Expected Behavior
In the WSL shell the mount works, it should also work Explorer.
Actual Behavior
Attempt to access invalid address

Diagnostic Logs
No response

A repro...
$ sudo apt install borgbackup
$ cd ~ && mkdir -p borg-repo borg-mnt tmp
$ borg init -e none borg-repo
$ borg create borg-repo::tmp tmp
$ borg mount borg-repo borg-mnt
$ mount | grep borgfs

Almost certainly same #6711.


Fluid pipes without liquid cannot connect to fluid pipes with liquid

Not sure if this is supposed to happen but when you try to place a fluid conduit new to one that,
lets say, has lava in it, they wont connect. This is a pretty big problem because if you are setting up a system and make a mistake, it could mean you have to break the whole thing.

They don't connect automatically to make it easier to place parallel pipes for different fluids. All you have to do is wrench to force the connection.

Thanks man!


Rename elemental-agent to elemental-capi-agent

elemental-capi-agent is more descriptive as a package name and should be used instead

No longer relevant.


Remove explicit width in ListTile trailing element

It was incorrectly added in #11858

FYI @zzzev

test!

Sorry about the regression. My code was based on the existing code for leading elements, which still has the explicit width. I've removed that explicit width for consistency in this pending PR: https://github.com/flutter/flutter/pull/12253


Is it possible to use gpt-3.5-turbo or gpt-4 as the LLM model for agents?

Provided I have given a system prompt, I wanted to use gpt-4 as the llm for my agents. I read around, but it only seems like gpt-3 davinci and nothing beyond it is an option.
Can gpt-3.5-turbo or gpt-4 be included as a llm option for agents?

I think so:
from langchain.agents import load_tools
from langchain.agents import initialize_agent
from langchain.chat_models import ChatOpenAI

llm = ChatOpenAI(model='gpt-3.5-turbo',temperature=0)
tools = load_tools(['human'], llm=llm)

agent = initialize_agent(tools, llm, agent="chat-zero-shot-react-description", verbose=True)

agent.run("Can you ask the human what to do?")

This is how I've done it as well

Trying to do this but getting na error:

openai has no ChatCompletion attribute

Any thoughts?

Is there any way to do this without having the agent prompt me asking for a user input?

I tried this approach. But, with this approach I am not able to use the tools, due to parsing error:
OutputParserException: Could not parse LLM output: `I need to use the NewsTool to find news articles about the sale of Coinbase stocks.`

Same issue from my end


Question about the plugins' usage

Hi mattmc3, recently I decided to switch OMZ to a faster zsh plugin manager and I founded antidote thanks for the great work!
However I'm not sure if I'm missing use antidoe, or adding too many overleaping plugins with zephyr, could you help me figure this out?
My current .zshrc and .zsh_plugins.txt file looks like this
.zshrc
#export PATH="/opt/homebrew/bin:$PATH"
#export PATH="/opt/homebrew/sbin:$PATH"
#fpath+=("/opt/homebrew/share/zsh/site-functions")

if [[ -o interactive ]]; then
    /opt/homebrew/bin/fastfetch
fi
# Enable Powerlevel10k instant prompt. Should stay close to the top of ~/.zshrc.
# Initialization code that may require console input (password prompts, [y/n]
# confirmations, etc.) must go above this block; everything else may go below.
if [[ -r "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh" ]]; then
  source "${XDG_CACHE_HOME:-$HOME/.cache}/p10k-instant-prompt-${(%):-%n}.zsh"
fi

HISTSIZE=1000000       # Set the amount of lines you want saved
SAVEHIST=1000000       # This is required to actually save them, needs to match with HISTSIZE

setopt EXTENDED_HISTORY          # Write the history file in the ":start:elapsed;command" format.
setopt INC_APPEND_HISTORY        # Write to the history file immediately, not when the shell exits.
setopt SHARE_HISTORY             # Share history between all sessions.
setopt HIST_EXPIRE_DUPS_FIRST    # Expire duplicate entries first when trimming history.
setopt HIST_IGNORE_DUPS          # Don\'t record an entry that was just recorded again.
setopt HIST_IGNORE_ALL_DUPS      # Delete old recorded entry if new entry is a duplicate.
setopt HIST_FIND_NO_DUPS         # Do not display a line previously found.
setopt HIST_IGNORE_SPACE         # Don\'t record an entry starting with a space.
setopt HIST_SAVE_NO_DUPS         # Don\'t write duplicate entries in the history file.
setopt HIST_REDUCE_BLANKS        # Remove superfluous blanks before recording entry.

ZSH_HIGHLIGHT_HIGHLIGHTERS+=(main brackets pattern)
# Declare the variable
typeset -A ZSH_HIGHLIGHT_PATTERNS

# To have commands starting with `rm -rf` in red:
ZSH_HIGHLIGHT_PATTERNS+=('rm -rf *' 'fg=white,bold,bg=red')

# Lazy-load antidote and generate the static load file only when needed
source /opt/homebrew/opt/antidote/share/antidote/antidote.zsh
antidote load

eval "$(zoxide init zsh)"

alias ls="eza --icons=automatic=automatic"
alias ll="eza --icons=automatic --git --long --all --time-style=long-iso"
alias l="eza --icons=automatic --git --long --time-style=long-iso"
alias lt="eza --icons=automatic --git --tree --level=3 --time-style=long-iso"

# To customize prompt, run `p10k configure` or edit ~/.p10k.zsh.
[[ ! -f ~/.p10k.zsh ]] || source ~/.p10k.zsh

.zsh_plugins.txt
# run towards the TOP of your .zsh_plugins.txt before any compdef calls
mattmc3/ez-compinit

Aloxaf/fzf-tab

zsh-users/zsh-history-substring-search
zsh-users/zsh-syntax-highlighting kind:defer

marlonrichert/zsh-autocomplete
zsh-users/zsh-autosuggestions

mattmc3/zephyr path:plugins/homebrew
mattmc3/zephyr path:plugins/compstyle
mattmc3/zephyr path:plugins/completion
mattmc3/zephyr path:plugins/macos

romkatv/powerlevel10k

My quesions are

Does the order plugin's order in .zsh_plugins.txt affect the order of loading they?
Is mattmc3/ez-compinit still necessary if I use your zephyr/completion?
Does zephyr/compstyle conflict with marlonrichert/zsh-autocomplete or Aloxaf/fzf-tab?
Last question or maybe request, is it possible to include an auto-clean mechanics, that removes all typo or wrong commands from the history file so they won't be suggested, in this project? (I'm having this fish plugin in mind.)

Great questions. Let's see if I can answer them:

Yes, the order of plugins in .zsh_plugins.txt definitely matters. If you are using kind:defer, those all happen at the end. You can pretty easily see what antidote is doing by simply looking in the .zsh_plugins.zsh cache file.
ez-compinit and zephyr/completion are mostly the same plugin - one's just stand-alone because it was easier to point people to than Zephyr's completion subplugin, since not all plugin managers support nested plugins. No need for both.
If you are using alozaf/fzf-tab, you probably don't need all the completion styles from compstyle, but it doesn't hurt. I don't use marlonrichert/zsh-autocomplete, but I can't see how the compstyles would conflict, nor has anyone opened a bug report to that effect. But let's be sure we're clear - the compstyle plugin is simply setting zstyles, and is different than the completion plugin. I think I've seen where zsh-autocomplete tries to handle compinit for you, so you may want to read the docs/examine the plugin to be sure.
Marlon has another plugin that supposedly does this, but I haven't used it either: https://unix.stackexchange.com/a/629701


Release 0.2.0

Changes for release of 0.2.0 of FilSnap:
@mpetrunic I will publish new version after you review this PR, and push new package.json files before we close this PR.

Refactored snap to support new Filecoin gas calculation flow. Now the message has three parameters gasfeecap, gaslimit, and gaspremium. Added new RPC method for precalculating gas params estimateMessageGas. Closes #57
Fix repeating div id inside the dashboard. Closes #52
Commented out mainet from network selection as it is not live yet. Closes #51
Set our hosted devnet as the default network inside an example. Closes #54
Minor changes to the landing page, see example below

lint^^


Configure Mobile framework/binary to use relay-enabled bootstrap nodes

Mobile framework and binary (both) package need to use alternative bootstrap nodes which will have relay support enabled for the OB network. In the short-term, we would like to override the mobile framework/binary init to use alternative bootstraps endpoints which will be stored in config and used specifically by mobile framework/binary builds. In the long-term, we would like to be able to migrate these mobile nodes to use new endpoints without impacting desktop nodes.
Implementation:

We will hardcode the desired bootstrap endpoints for the mobile package pending the final list of addresses being ready, ensuring they ignore any config-based value (as they aren't user editable for mobile anyway)
(optional) might be worth indicating in the logs which bootstraps are being connected to by the node on startup to ensure the hardcoded values are being used and for later forensics?

Original requirements:

Replace bootstrap nodes with phase-1 nodes for mobile only.
Finalize plan for replacing bootstrap nodes with Experimental phase-1 nodes
on only mobile, and be ready for a migration on all nodes to replace
bootstrap nodes to Stable phase-2 nodes.

Experimental relay 1 is available for testing:
/ip4/<IP_ADDRESS>/tcp/4001/ipfs/QmWUdwXW3bTXS19MtMjmfpnRYgssmbJCwnq8Lf9vjZwDii

Relay 2: /ip4/<IP_ADDRESS>/tcp/4001/ipfs/QmcXwJePGLsP1x7gTXLE51BmE7peUKe2eQuR5LGbmasekt

Brian's Relay
/ip6/2604:a880:400:d1::99a:8001/tcp/4001/ipfs/Qmb8i7uy6rk47hNorNLMVRMer4Nv9YWRhzZrWVqnvk5mSk
/ip4/<IP_ADDRESS>/tcp/4001/ipfs/Qmb8i7uy6rk47hNorNLMVRMer4Nv9YWRhzZrWVqnvk5mSk

We have NATed nodes using the above bootstrap nodes with configurations which should enable autorelay to work, however we are not seeing these nodes announcing their relay paths. This is the process we are expecting and are trying to confirm is happening on our network. Investigating further.

I think our network configuration is sufficient for supporting autorelay on our nodes. I see a NATed node actually finding other opt-in relays, selecting a few at random and completing the connection to them. The node then proceeds to update it's published addrs but those published addrs don't end up appearing elsewhere on the network. Even the node which is the providing relay does not return the relay circuits in this response. Next is to investigate why the addr update to the rest of the network is failing.
Also notable from tests is that autorelay took approximately 8 minutes from startup to final relay connection via several "stream close"s and "protocol not supported"s before finally resolving a connection and attempting to notify the network of the new relay multiaddr.

Turns out the pushed/updated relay multiaddrs were not valid due to an OpenBazaar-specific patch which was handling the migration of our CIDs to line up with standard IPFS CIDs. Upon reverting the patch (which can be deprecated and removed, according to @cpacia), valid multiaddrs were then propagating. Still, the autorelay process can take between 5-10 minutes depending on the responsiveness of the DHT swarm and how well-connected the node happens to be on startup.
The next step is to investigate how to get the mobile nodes to automatically connect and announce themselves as available via the relay without waiting for autorelay to publish updates.

This is done isn't it @placer14 @cpacia ?

I was able to get the node to use our relays without autonat or autorelay being used. but the relayed multiaddrs don't propagate from the node. It had to be put on hold for other tasks.


File attestation trust store detection of .der files is a bit odd.

Problem
The code in does:
            if (strncmp(fileExtension, "der", strlen("der")) == 0)

which will detect things like .derby or .derring-do files as .der.
Proposed Solution
Maybe strncmp(fileExtension, "der\0", 4) if we really want to guard against non-null-terminated fileExtension?  Else just strcmp.

why even use strncmp if this is a file extension already extracted? strcmp seems sufficient (assuming fileExtension is already correctly 0 terminated)

Yes, that is the big question: can we assume that?


GW2 with d3d9 can't have a window/software in "front"/"always on top"

Hi,
Not sure if it's an issue but with d3d9.dll in gw2 x64 i can't have a window/software in top of the game in fullscreen windowed mode. Even if the software is tagged as "always in front".
This is is a bit annonying for some hardware monitor soft i use.
If it's a know issue and if someone know a solution, that will be great as without d3d9 guild wars 2 is unplayable :(
GPU: RX 5700 XT (last AMD driver 19.12.2)
gw2.exe in x64
d3d9 last version from d9vk jobs -> https://git.froggi.es/joshua/d9vk/-/jobs (was the same problem with some previous version)
Thank you.

Do you mean TacO or the likes?

No not TacO (i haven't tried with TacO) some hardware monitoring like CPU/GPU temp, GPU/CPU usage or ispy with a cctv monitor in a small bottom window (foced in always on top).

Hi,
Borderless Vulkan windows by default that encompass the screen will steal exclusive fullscreen rights.
I'll add a config option to disable this behaviour.

:D :D thank you very much :D :D

Thank you for the option... but i certainly did something wrong as this don't seems to work :(

copy dxvk.conf to my game directory where d3d9.dll is (C:\Guild Wars 2\bin64)
i set de dxvk.conf directory in variables (C:\Guild Wars 2\bin64\dxvk.conf)
i passed d3d9.enableDialogMode to True
i uncheck d3d9.enableDialogMode in dxvk.conf

But not working for me :( game still in exclusive top
Here is a part of my d3d9 debug log, if you know what i missed. Thank you very much

info:  Game: Gw2-64.exe
info:  DXVK: v1.4.6
info:  Found config file: C:\Guild Wars 2\bin64\dxvk.conf
info:  Effective configuration:
info:    d3d9.enableDialogMode = True
info:  Built-in extension providers:
info:    Win32 WSI
info:    OpenVR
warn:  OpenVR: Failed to locate module
info:  Enabled instance extensions:
info:    VK_KHR_get_physical_device_properties2
info:    VK_KHR_get_surface_capabilities2
info:    VK_KHR_surface
info:    VK_KHR_win32_surface
warn:  D3D9: VK_FORMAT_D24_UNORM_S8_UINT -> VK_FORMAT_D32_SFLOAT_S8_UINT
info:  AMD Radeon RX 5700 XT:
info:    Driver: 2.0.116
info:    Vulkan: 1.1.125

Can you send the full log?

Here it is
Gw2-64_d3d9.log

Still don't work with last Version 0.40.1 - Croakacola Zero 🥤0⃣🐸  :D
i'd remove d3dcompiler_43.dll but it went recreat as soon i launch game, don't know if it can be part of my problem.
i certainly did something wrong :( if have any idea, will be great :) :)
Thank you very much and sorry for my english (and my inexistant coding skills)

Hm, it's working fine here.
Perhaps your issue is just that the game is flagging the window as always on top, in which there isn't really anything I can do about that 🤷♀

Is GW2 x64 or x86? I have something for you to try.

x64
Will check and try tomorrow as it's 2:24am here and time to sleep :)
Thank you for your answer
Le dim. 15 déc. 2019 à 02:19, Joshie<EMAIL_ADDRESS>a écrit :

Is GW2 x64 or x86? I have something for you to try.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Joshua-Ashton/d9vk/issues/475?email_source=notifications&email_token=ACD47O6K43DVVRKBZ23UDMLQYWAYZA5CNFSM4J2ENGM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG4O6LA#issuecomment-565767980,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACD47O2JOXW64AHJ7BL6BC3QYWAYZANCNFSM4J2ENGMQ
.

I test again this morning, this have definitly something to do with d3d9.dll as when i remove it i can have somthing in front of the game (always on top) without problem.

gw2 is in x64
i tried disable fullscreen optimization of the exe fils without any improvement
i checked again and my dxvk.conf as d3d9.enableDialogMode = True and uncomment

Really don't know what the problem is... anyway can still play the game with your d3d9.dll so really thank you for that and too bad if i can't have soft in front but not so vital anyway :)


Add a jupyter  notebook using Boost.Python to deploy the model with pure python code

Boost.Python can be used to transform the C++ model code into a python module that can be imported.
https://www.boost.org/doc/libs/1_63_0/libs/python/doc/html/index.html
Follow the six steps described in https://github.com/antoinecarme/ml2cpp/issues/1

We use a random forest (512 trees ;) on the iris dataset.
The Model C++ code is stored under /tmp/sklearn2sql_cpp_140409960179088_model_specific.i

With Boost.Python this code can be encapsulated/pythonified and stored as /tmp/sklearn2sql_cpp_140409960179088.cpp
#include "Generic.i"
#include "/tmp/sklearn2sql_cpp_140409960179088_model_specific.i"

#include <boost/python.hpp>
using namespace boost::python;

BOOST_PYTHON_MODULE(sklearn2sql_cpp_140409960179088) {
	def("score_csv_file", score_csv_file);
}

We compile this into a shared library /tmp/sklearn2sql_cpp_140409960179088.so that can be loaded as a python module
g++ -I/usr/include/python3.10 -Wno-unused-function -fPIC -std=c++17 -g -o /tmp/sklearn2sql_cpp_140409960179088.o -c /tmp/sklearn2sql_cpp_140409960179088.cpp

g++ /tmp/sklearn2sql_cpp_140409960179088.o -shared -Wl,--export-dynamic -lboost_python310 -L/usr/lib/python3.10/config -lpython3.10 -o /tmp/sklearn2sql_cpp_140409960179088.so

Tjhe following python code can be used to score a given csrv file
        import sys
        sys.path = sys.path + ['/tmp']
        import sklearn2sql_cpp_140409960179088 as mymodel
        result = mymodel.score_csv_file("/tmp/iris.csv") # returns a python string
        print(result)

Sample output :

idx,Score_0,Score_1,Score_2,Proba_0,Proba_1,Proba_2,LogProba_0,LogProba_1,LogProba_2,Decision,DecisionProba
0,,,,1.00000000000000,0.00000000000000,0.00000000000000,0.00000000000000,-32.23619130191664,-32.23619130191664,0,1.00000000000000
1,,,,0.99804687500000,0.00195312500000,0.00000000000000,-0.00195503483580,-6.23832462503951,-32.23619130191664,0,0.99804687500000
2,,,,1.00000000000000,0.00000000000000,0.00000000000000,0.00000000000000,-32.23619130191664,-32.23619130191664,0,1.00000000000000
3,,,,1.00000000000000,0.00000000000000,0.00000000000000,0.00000000000000,-32.23619130191664,-32.23619130191664,0,1.00000000000000
4,,,,1.00000000000000,0.00000000000000,0.00000000000000,0.00000000000000,-32.23619130191664,-32.23619130191664,0,1.00000000000000

jupyter notebook available.
https://github.com/antoinecarme/ml2cpp/blob/master/doc/boost_python/ml2cpp_random_forest_classifier_iris_boost_python.ipynb


Add Funds Modal Might not Show Desired Result when Too many Results are Returned

This is with related to the following discussion on Slack; https://opencollective.slack.com/archives/GFH4N961L/p1649882245564269.
The root cause of this issue is that we only show 20 results for CollectivePickerAsync by default;
https://github.com/opencollective/opencollective-frontend/blob/a9694ae464bd2457b70a764d948c2167e99b30d8/components/CollectivePickerAsync.js#L171-L175
So if the search query for the Source field in the AddCollectiveModal is too common (such as the case of yahoo in the above slack discussion) lot of results that the user expects will not be shown.
I can think of two solutions.

We support searching by exact slug; we can use @@ for this. We currently support searching by slug only when user type @yahoo for example, but it seems that we don't do an exact match; https://github.com/opencollective/opencollective-api/blob/520f99251f4039e5b9ca024616da4f944178dce1/server/lib/search.js#L156-L159

We could adapt the front-end and API to send paginated results. So that we could change the CollectivePickerAsync to display "more results" button and when clicked shows the next 20 results and so on. This would need some design changes.

Let me know your thoughts.
cc: @Betree

I am closing this is is a duplicate of https://github.com/opencollective/opencollective/issues/5434 which already summarizes the problem.


Threats from @domenkozar

Issue description
Dear @edolstra,
User @domenkozar  threatens to ban me with some silly reason, while in fact for the simple reason that I directed attention to the issue, we now have an additional committer (@veprbl (hooray!)). See his comment here: https://github.com/NixOS/nixpkgs/issues/50889#issuecomment-441685329.
User @domenkozar seems to have great difficulty with understanding the difference between personal criticism (which is what I am giving him right now) and project management criticism, which is what I gave in the above issue. Note that nobody gave a reasonable excuse as to why it should take 5 days to do what should be considered a simple administrative action with perhaps a minor discussion.
I have explained on various occasions that the reason there are so many PRs is because commit access is considered some kind of God given right while in reality the risk that something goes wrong is small in for example this case. Almost nobody has an interest in secretly rewriting the whole of nixpkgs as a secret night time hobby, but somehow this escapes most people, including you @edolstra. At no point have you written down any reasonable explanation for why you run the things the way you do.
The age old "security argument" is neither reasonable, because whatever imaginary enemy you are thinking of would simply be able to plant a row-hammer attack that would look like an innocent patch. If security would be a top priority, then why is even ntpd configured "insane" (paraphrasing someone who said that with his changes it would now be "sane")? Fact of the matter is that NixOS is not secure in some perfect ideal world and it will likely never be, because that's not what it is designed for. NixOS is a slightly smaller kludge than most other operating systems; that is it. You should find happiness in that, but I kindly ask you to undermine the project with your wrong ideas. It's hard to always be right. Here, I am giving you a fairly simple argument as to why you are wrong.
Since this is supposed to be an inclusive community, I feel very much excluded by having such people (like @domenkozar)  with the apparent power to ban people, @edolstra. It creates an atmosphere in which disagreement on issues is impossible.
I have the impression that @domenkozar is somehow jealous in some way and seems to have a rather weak control over his emotions. In a company @domenkozar's behaviour would not be tolerated, which is likely why he started his own business. Please think about that next time you give someone the power to ban people.
Finally, consider that I have many responsibilities and that nixpkgs mostly takes up time due to the drama that @domenkozar makes over little things. Also note that @domenkozar repeatedly seems to take offense to what people say. I was banned from the Discourse forum, because @domenkozar got emotional again. Nobody else got emotional; just he did. I am getting a negative vibe from him, if anything.
Perhaps he is under financial stress of some kind, which is a sad state to be in, but you should not have that effect the NixOS brand. Essentially you are saying "if you are someone who commits more than others, you can bully everyone away".
I would consider it absolutely terrible to work with @domenkozar and I would never run any of his business tools, because he seems to explode for no reason at all. There is professional help for such issues; even if his tools would be the absolute best on the market, I would still not use them, because he is a liability (if I would use his service, all that would happen is that if someday he disagrees, he just pulls the plug; there is zero basis for trust). So, instead of him trying to make himself look like an absolute fool by threatening someone who did write some commits in the past week and certainly has been making useful comments in various threads, perhaps consider he should consider a little bit of personal growth?
Steps to reproduce

Mistake the ability to write a patch with actual leadership
"Trust" people that do not control their emotions

Solution
Understand that project management skills are not equally distributed among developers. In particular the removal of ban rights if that is possible from @domenkozar and similar people in the future.
Technical details
I think I have given enough details to show beyond doubt what needs fixing, and it is not me.
TR;DR;
I escalated an issue by replying to it (this increases the number of comments, which in turn increased the probability that someone was looking at it), which has solved an issue and @domenkozar thinks it's a good idea to start threatening me. :roll_eyes:

It would go a long way if you could also admit your own failures from time to time @coretemp.
Please explain to me how this comment is not passive-aggressive: https://github.com/NixOS/nixpkgs/issues/50889#issuecomment-441582728

+1 for banning @coretemp, thanks for bringing this up. (scnr)

@zimbatm I am how the project is mismanaged and specifically the onboarding of new committers. I don't see how it is a failure to do so. What needs to happen is that that someone acts as a leader.
@Profpatsch Based on what exactly? Did I offend you in some way and are you just as emotional as @domenkozar?

I'm with @coretemp here. Yes their comment was a bit passive-aggressive, but that's no reason to ban somebody. We probably all have had such silly hickups occasionally, maybe when we've had a bad day or are frustrated. As long as it doesn't happen all the time. I don't see any other evidence other than mentioned comment, which is a very low basis to judge someone. If @domenkozar has other reasons for banning then I'd like to hear those.
@coretemp You mentioned that you got banned from the Discourse forum, what was the reason for that? Do you have a link to the discussion that caused this?

https://github.com/NixOS/nixpkgs/search?q=involves%3Acoretemp&type=Issues

I'm going to post this issue for posterity https://github.com/mozilla/sops/issues/394#issuecomment-438746610, could probably fine a dozen more but I'd rather have a nice evening :)
There's not much I have to say besides I'm going to go ahead with the ban, we're here to create a welcoming community.

@zimbatm Even if it was passive-aggressive, which I don't think it is, there still is the minor inconvenience that there is no code of conduct in nixpkgs to begin with.
So, the extremely aggressive behavior that @Profpatsch shows (+1 for banning me), should certainly be met with an immediate ban according to that logic.
Banning me is not even on the table; @domenkozar had a random thought supported by nobody. I am just bringing out the attention to the fact that I do not believe @domenkozar to be fit for his responsibilities. People can disagree on that. Perhaps you think he is fit for that job, I just don't share that opinion. How hard is it to accept that fact?
It's not like I am the only person who believes this to be the case. People "accept" it, because he is doing it for "free" (at the cost of damaging the NixOS brand). I think it's better if he would not contribute anything to the project to remove the drama, but even I am not proposing to ban him.
You all claim to be so inclusive, but in reality you are everything but that.
@Infinisil I think that discussion has been censored (one of the disadvantages of using Discourse).
@grahamc I would like to nominate you for the position of passive-aggressive winner of the day.
Is the definition of passive aggressive to be all behavior that doesn't agree with @domenkozar?
In that case, just rename the project to be @domenkozar's cabal or something like that and remove any suggestion that this project allows outside involvement.
I understand; it's not nice to hear this, but most people make it so easy to shoot holes in almost everything that they say that even for a troll (which I am not), it would not be entertaining. It's really just annoying and draining my energy to learn that this great project is under the influence of such unfriendly people.
The trend I see is that all the actually aggressive people are those of you whose livelihood depends partially on nixpkgs. It feels like nixpkgs has been corrupted.

@domenkozar You are pointing at another project. Pathetic.

@domenkozar had a random thought supported by nobody.

I have found a new nickname.

Pathetic.

:)

@coretemp: this isn't just about that single comment (which wasn't constructive).  You know, it's not really a problem to criticize or disagree, but you need to do it in a way that does not involve attacking people around (like you showed e.g. in this thread).


Don't repeatedly calculate transaction hashes

I was noticing a >10s delay between finding a block and broadcasting it:
2015-12-28 03:04:09 starting stake
2015-12-28 03:04:14 CWallet::CreateCoinStake() iteration 0
2015-12-28 03:04:20 CWallet::CreateCoinStake() iteration 15000
2015-12-28 03:04:25 CWallet::CreateCoinStake() iteration 30000
2015-12-28 03:04:25 selecting random speech with nRandom fbf8f24ad783f703 %<PHONE_NUMBER>91574 =<PHONE_NUMBER>953
2015-12-28 03:04:25 selected random speech: '46.07% of the Just-Dice.com bankroll abstains from supporting any petition'
              <- 11 second gap
2015-12-28 03:04:36 CWallet::CreateCoinStake() true
2015-12-28 03:04:36 successful stake took 27s
2015-12-28 03:04:36 CheckStake() : new proof-of-stake block found

I added extra logging to determine where the time was being spent:
2015-12-28 03:40:59 selecting random speech with nRandom b4c5bfeaa91cb6c4 %<PHONE_NUMBER>29426 =<PHONE_NUMBER>2794
2015-12-28 03:40:59 selected random speech: 'clamour 5afa074c 7a69a853'
2015-12-28 03:40:59 done select weighted speech
2015-12-28 03:40:59 checking if we need a new output
2015-12-28 03:40:59 check splitting
2015-12-28 03:40:59 check merging
              <- 13 second gap
2015-12-28 03:41:12 extra output?
2015-12-28 03:41:12 signing
2015-12-28 03:41:12 successfully generated coinstake
2015-12-28 03:41:12 CWallet::CreateCoinStake() true

It turns out it was in the loop which checks to see whether any existing outputs can be merged with the staking output. The code was calling GetHash() on every output in the wallet to calculate its transaction ID, but the hash never changes so this can be cached.
As a further optimisation, it seems that the hash is only used to check that each coin being considered for merging isn't the coin being staked. If we removed the coin being staked from the set we're iterating through then this check would become completely unnecessary and could be removed. I'll make a separate pull request for that.


Filtering quickstarts by display name

FE part of https://issues.redhat.com/browse/RHCLOUD-33585

Just a question. What happens you send an empty string to the API? "" Or rather a string with just spaces for example. " "

@Hyperkid123
There is no display name that would match multiple empty spaces, therefore no quickstarts are displayed.

@JetyAdam then I believe we should trim the payload from leading and trailing white space characters. And not even send a request if the string is empty.

@JetyAdam then I believe we should trim the payload from leading and trailing white space characters. And not even send a request if the string is empty.

Added an extra condition that deals with it


Clang format all the code.

This is a clang-format run over all the code. It also provides a .clang-format file and mentions the formatting in the README.
This PR is based on PR #13

Would be nice if this and the cleanups would base on master. Now they are pending because of #13 .

The problem with this on my side is, that I have no Arduino-IDE installed on any of my computers. So I cannot test the changes.

Thanks, merge with b7cb200bc67cf57487d0c15af29d6dc69502a8c7...9849aff2525620f7b3871b11f2c34831d862ad8d .


Could you plan add error overlay?

Operating System: any
Node Version: any
NPM Version: any
webpack Version: 4
webpack-serve Version: current

This issue is for a:

[ ] bug
[x] feature request
[ ] modification request

Expected Behavior
Need to have error overlay window like weback-dev-server has
Actual Behavior
there is no error overlay
New Feature Use Case
add to options overlay: boolean
it's easy to add this feature - have a look at this repo - modifications only need for discovery serve key in webpack options and fix registering error middleware for koa syntax

Thanks for the issue :beer:
Please do try searching issues. There is a duplicate of this request here: https://github.com/webpack-contrib/webpack-serve/issues/4

@budarin if you're still wanting this, over the weekend I created & published webpack-serve-overlay that uses the overlay from webpack-dev-server.
It should be exactly what you're after.

@G-Rath
it's great! thanks!


Update to mobile intro documentation

I found a grammatical/spelling error while reading this documentation.

I signed it