[events.js:60]: Uncaught ReferenceError: log is not defined

Description
In one of our test projects we get the following error immediately upon trying to open play mode. We are not seeing it in other projects, so not sure what causes it in the first place.
[events.js:60]: Uncaught ReferenceError: log is not defined
    ReferenceError: log is not defined
    at Editor.Events.emit (https://launch.playcanvas.com/editor/scene/js/events.js:60:13)
    at Connection. (https://launch.playcanvas.com/editor/scene/js/launch.js:11859:20)
    at emitOne (https://launch.playcanvas.com/editor/scene/js/launch.js:181:13)
    at Connection.emit (https://launch.playcanvas.com/editor/scene/js/launch.js:259:7)
    at https://launch.playcanvas.com/editor/scene/js/launch.js:2621:20
    at Item.run (https://launch.playcanvas.com/editor/scene/js/launch.js:2467:14)
    at drainQueue (https://launch.playcanvas.com/editor/scene/js/launch.js:2437:42)

Upon opening the events.js (that I do believe is native playcanvas), I can see the line 60
log.error(ex);
should probably instead be
console.error(ex);
Steps to Reproduce

Open playmode
Immediately before loading bar starts moving, error is thrown

duplicate of https://github.com/playcanvas/editor/issues/233
we're aware of the issue and will have a fix shortly. Is this blocking you?
@yak32 - any possible workaround?

There's an issue in our launcher code that catches errors in the application :(
Looking into a fix for this soon.

duplicate of playcanvas/editor#233
we're aware of the issue and will have a fix shortly. Is this blocking you?

No, we found a different way to test what we were working on, just wanted to mention it.

the issue is already fixed, https://launch.playcanvas.com/editor/scene/js/events.js doesn't contain log anymore.

We may have more of these in the codebase @yak32 :(
https://forum.playcanvas.com/t/referenceerror-log-is-not-defined/17905/4

yes, I see, going to fix it today

the fix is merged, we will deploy it soon

the fix is deployed, the issues should be fixed now.


Border sometimes not visible

Fantastic library all!
One small issue I sometimes see is a missing border. Here's a video, where I have six rows at regular zoom, and the line between rows 6 and 7 isn't visible until I scroll (but side-scrolling brings it partly into view):
https://user-images.githubusercontent.com/6945891/199630568-4d8a55a9-9909-487a-97ba-41362eff5d6c.mp4
Then at 110% zoom I have five rows, and the line between 5 and 6 isn't visible:
https://user-images.githubusercontent.com/6945891/199630630-d0cda6d8-0b76-4071-8760-f253d46a2191.mp4
It's a bit annoying to repro, but I am able to recreate it whenever the border lines up with the edge of the containing div. Here's me doing it by resizing my screen, using https://slight.run/datasets/amaris/annual_co2_emissions_per_country:
https://user-images.githubusercontent.com/6945891/199630850-4cddd0ca-a5ba-4463-865f-e4c3b46bf8c3.mp4
You can see that when I get the resize down to where the table is exactly 13 rows, the border disappears.
Thanks! If you think more details could help (our css etc) let me know.

I have also encountered this issue when adding new rows. Occasionally the horizontal border between the newly created row and the original last row is missing until i scroll. Again, it seems to line up with that row being at the bottom of the container

What version of the grid do you see this on? Can you try the 5.2.0 beta?

5.1.4 for me. Can try and update this week and see if the issue is still there...

I cannot reproduce this behavior. If anyone has a reliable reproduction I need to have the OS, browser, screen DPI, and GDG version to fix this.

I'll work on a repro too!


Expand tests to increase coverage

#97 and #98 should be merged first

Codecov Report
Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.68%. Comparing base (3c1c976) to head (bdf10d6).
Report is 1 commits behind head on main.

Files with missing lines
Patch %
Lines

lindi/LindiH5pyFile/LindiH5pyFile.py
82.60%
4 Missing :warning:

Additional details and impacted files
@@             Coverage Diff             @@
##             main      #99       +/-   ##
===========================================
+ Coverage   69.10%   81.68%   +12.57%
===========================================
  Files          34       30        -4
  Lines        3046     2773      -273
===========================================
+ Hits         2105     2265      +160
+ Misses        941      508      -433

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


twitter reply handler: colon in id

https://console.cloud.google.com/errors/103024257558725274?time=P30D&refresh=off&project=brid-gy
odd bug, still trying to figure it out. this handler URL crashes since it has a colon in the reply tweet id, which we try to fetch from twitter without url-encoding: https://brid.gy/comment/twitter/schnarfed/654754006846189569/654767368149729281:2TCPDrd-E-kUktDfnjutaTN1RpE
i think that id is bad, so i should debug that instead of just url-encoding.
ValueError: Error trying to decode a non urlencoded string. Found invalid characters: set([u':']) in the string: 'id=654767368149729281:2TCPDrd-E-kUktDfnjutaTN1RpE&include_entities=true&tweet_mode=extended'. Please ensure the request/response body is x-www-form-urlencoded.
  at urldecode (local/lib/python2.7/site-packages/oauthlib/common.py:131)
  ...
  at auth_header (local/lib/python2.7/site-packages/oauth_dropins/twitter_auth.py:36)
  at signed_urlopen (local/lib/python2.7/site-packages/oauth_dropins/twitter_auth.py:56)
  at request (local/lib/python2.7/site-packages/granary/twitter.py:925)
  at urlopen (local/lib/python2.7/site-packages/granary/twitter.py:933)
  at get_comment (local/lib/python2.7/site-packages/granary/twitter.py:515)
  at get_comment (models.py:340)
  at get_item (handlers.py:255)
  at get (handlers.py:157)

doesn't look like it's in response to a propagate. https://brid.gy/twitter/cconover 's last response was 6w ago, and last wm was 10 mos ago.
request was from 2a02:c7d:bc2f:c000:cd09:8056:b040:a989, user agent firefox 50.
i can just add some validation to twitter ids in handlers, like we already have for facebook ids.


Disable check-deps ci step

Summary
A new owasp dep check release is not distributed yet through bintray causing a required ci test to fail.
Ticket Link
N/A
Related Pull Requests
https://github.com/mattermost/mattermost-server/pull/17083
https://github.com/mattermost/mattermost-webapp/pull/7657

Skipping 3: QA Review since CI/CD only.


[RainbowSixSiegeBridge] Empty feed

The information is not downloaded and is not in the feed.
https://sebsauvage.net/rss-bridge/?action=display&bridge=RainbowSixSiege&format=Atom
https://sebsauvage.net/rss-bridge/?action=display&bridge=RainbowSixSiege&format=Plaintext

Ping @corenting

I made a fix in the following PR : https://github.com/RSS-Bridge/rss-bridge/pull/1587 , I'm waiting for it to merged.


Remove react-intl default span tags.

This allows users to see that they can change the default behavior of
<Formatted*> tags when using react-intl. Default span tags are
insidious and adds unnecessary clutter.

Hi folks!
Now <FormattedMessage /> accepts prop tagName passed as element or string.
https://github.com/yahoo/react-intl/pull/1118


Rework of Push2/OSC interface

[x] Get rid of controls stuff from control.py
[x] Get rid of Push2 process control from __main__.py
[x] Ditch Push2 examples completely for the moment
[x] Move Push2 and OSC stuff into interact framework (none of it will work yet)
[ ] Rework the Push2 interface to match the new flitter.interact.controller API
[ ] Create a new top-level OSC interface that allows configuring arbitrary senders/receivers

Fixes #6 and #7

Closing this in favour of a more significant reworking in #13


Escape invalid XML chars in testCase and testSuite names

Fix for https://github.com/bazel-contrib/rules_jvm/issues/285
With a ParameterizedTest it is possible to generate test case names with invalid XML characters. E.g.
@ParameterizedTest
@ValueSource(strings = {"Weird\bname"})
void testFoo(String input) {
    ...
}

The test case name is derived from the input string, which in this case contains an invalid XML char \b. When tools (like IDEs) try to parse the junit XML, they'll fail due to the invalid char.
Fix it by escaping test case names. It looks like test suite names could also contain invalid XML chars, so I'm escaping those as well.

The CI failure is spurious, but is blocked on https://github.com/bazelbuild/rules_jvm_external/pull/1173 getting released - hopefully it will get released soon!

Looks like https://github.com/bazelbuild/rules_jvm_external/pull/1173 got released.
I think we just need to rebase after https://github.com/bazel-contrib/rules_jvm/pull/288 is merged.

@sfc-gh-abalik, with #288 we now have the CI builds working properly again. Could you please rebase on top of current HEAD of main so that we can land this change? Thank you for your patience as we were sorting that out!


{doc} az monitor log-analytics workspace data-export: Fix typo

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature

This checklist is used to make sure that common guidelines for a pull request are followed.

[ ] The PR title and description has followed the guideline in Submitting Pull Requests.

[ ] I adhere to the Command Guidelines.

[ ] I adhere to the Error Handling Guidelines.

https://github.com/Azure/azure-cli/issues/28880

doc


Bump perfdash to 2.21

Also fix dependencies in perfdash Makefile.
/assign @mm4tt

/lgtm
/approve


Query fields by section instead of aggregate array

Ideal :innocent:
What I hope to achieve is automatically present specific blocks (or sections) and their attached inline fields in a tabular form by query #tags or other conditions, no matter from same page or not.

Like “Query and properties” in Logseq, you can see some example here
Reality :face_with_head_bandage:
I’ve read the official documentation and examples, but couldn’t find a way to do it. Inline fields under the section are not one-to-one correspond to section, which means each section text in its row have all field value in this page!

Unfortunately this requires JS and has been asked for before The issue is that each field is indexed as an array so long as you use the field multiple times in the same page. It also does not retain header information.

Duplicate of #874

Duplicate of #1387

Unfortunately this requires JS

Sorry to rez this ticket; I have a question about this and I can't seem to find answers elsewhere.
Do you mean DataviewJS? If so, could you possibly point me towards a discussion where a dvjs query which performs this (generally)? I just need a starting point, I'm not yet versed in js but can pick it up fairly quickly if there is a discussion or some examples. Thanks

this is not a duplicate of #874 , altough they could be solved by the same mechanism. This wants the grouping by section to extend across several files, while the other issue is about just within the same file.


Admonitions with alternative name not converting as expected

Describe the bug
Custom name of admonition is not converted correctly.
In Docusaurus, if you want to give an admonition a custom name you can add it after the usual name. It will give you the same colour box but with the custom name.
Reproduction Steps

Type ::: followed by admonition name, then add custom name

:::info Upgrade
In Paratext 9.3 (and above) you can use the main Paratext menu to arrange windows by rows and columns.
:::
In the example above, I expecte to get a blue info box but with the name Upgrade.
See 2.5 this example.

URL of a source Notion page that, when docu-notion accesses or converts it, shows the problem:
https://www.notion.so/ltuse/2-Organising-your-desktop-629dc633009a45f8a2ad0618b99701a7?pvs=9
At least one of these:

URL of a docusuarus site showing the resulting page
https://sillsdev.github.io/paratext-manual/2.OD
URL of a markdown of the resulting page
https://manual.paratext.org/Training-Manual/Stage-1/OD

Expected behavior
In the example above, I would get a blue info box but with the name Upgrade.
See 2.5 this example.
Screenshots
Deployed from Notion:

[This is similar when incorrectly used :::note Upgrade.]
Expected (deployed from markdown text):

Additional context
I keyed it in the markdown ::: as I didn't think Notion callouts would be able to change the heading/name.

Sorry; I'm not understanding the problem.
When use use
:::info Upgrade,
you're getting the info color with the heading Upgrade.
And when you use
:::note Upgrade,
you're getting the note color with the heading Upgrade.
It seems like that is what you want based on my understanding of what you have written. So I'm missing something.

Sorry I gave the wrong reference for the problem, it should have been 2.3 not 2.5.
Here you see in Notion I have asked for info with Upgrade

Here you see Docusaurus has given me note with Upgrade
.
I am working on writing up another issue about the inconsistency in admonition and I have lots of examples of not getting what I asked for. So for this issue I was restricting it to custom headings. It seems my latest release looks better. But then that is just adding to the inconsistency.
I am trying to use callouts rather than ::: codes but maybe I am using the wrong icons. I know it is written up somewhere but I can't find. Can you tell me where I can find the list of what callout icons to use in Notion to get the desired admonition in Docusaurus?

Looking at your notion history and comparing to the Github Actions times, it appears that this example was
:::note
at the time Github Actions last ran.
I've run the action just now, and now the docusaurus page has the info icon/color:

For which icon to use, see
const calloutsToAdmonitions = {
  "ℹ": "note",
  "📝": "note",
  "💡": "tip",
  "❗": "info",
  "⚠": "caution",
  "🔥": "danger",
};

which is in this file in docu-notion:
https://github.com/sillsdev/docu-notion/blob/main/src/plugins/CalloutTransformer.ts
I'll add that to the docu-notion readme.

Great to know it is working. Sorry, I am getting used to Notion but still
struggling to know what was deployed when, especially when I still get
several failures.
Thanks for the icons. That will go a long way to solving the apparent
inconsistencies in conversion J.
From: andrew-polk @.***
Sent: Saturday, 5 August 2023 2:42 AM
To: sillsdev/docu-notion @.>
Cc: JenniBeadle @.>; Author @.***>
Subject: Re: [sillsdev/docu-notion] Admonitions with alternative name not
converting as expected (Issue #61)
Looking at your notion history and comparing to the Github Actions times,
it appears that this example was
:::note
at the time Github Actions last ran.
I've run the action just now, and now the docusaurus page
https://sillsdev.github.io/paratext-manual/2.OD/ has the info icon/color:
[image: image]
https://user-images.githubusercontent.com/5847219/258503904-216acf0f-6225-4e7c-a326-e8ba30930359.png
For which icon to use, see
const calloutsToAdmonitions = {
"ℹ": "note",
"📝": "note",
"💡": "tip",
"❗": "info",
"⚠": "caution",
"🔥": "danger",
};
which is in this file in docu-notion:
https://github.com/sillsdev/docu-notion/blob/main/src/plugins/CalloutTransformer.ts
I'll add that to the docu-notion readme.
—
Reply to this email directly, view it on GitHub
https://github.com/sillsdev/docu-notion/issues/61#issuecomment-1666033406,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AZ5F7HKL4C4UJBT5EMI2F6LXTU7AVANCNFSM6AAAAAA3C7PWJQ
.
You are receiving this because you authored the thread.Message ID: <
@.***>


Highlight in Main NavBar

User need to know on which page they are.

//BUG: After clicking away, the text loose his appearance...

//BUG: Reloading doesnt work again???


Switch Python Binding to pybind11 Instead of Boost.Python

I've recently found out about pybind11, which is essentially a header only reimplementation of Boost.Python with C++11, and without any dependency on boost.  It also has superior documentation compared to Boost.Python, and while it's API is very similar to Boost.Python it does seem a little cleaner.
Over the last year, it seems like the vast majority of people complaining about difficulties building dlib have actually been complaining about difficulties installing/building boost.  So it would be great to get rid of Boost.Python and use pybind11.  It doesn't look like too much work since the pybind11 API is very similar to Boost.Python.

I would be glad to help you for this.
Have you begin this switch or we need to start from scratch ?

That would be sweet.  Needing to install boost is the number 1 problem new dlib users have.  So this would be a very well received update :)
I've just looked at pybind11 but haven't done anything yet.

@edmBernard Are you still working on this?  We still get almost daily questions from people having trouble installing boost.python (e.g. #473) so switching to pybind11 would be pretty sweet :)

sorry I don't already got time to moving forward on this task but that's still on my project.

Yeah I saw that was missing.  Guess it's not a simple find/replace.  Still totally worth it though :)

yeah I thinks too.

to help in the switch I find this lib that already switch :
before : (with boost::python) : here
after : (with partialy pybind11) : here

with the diff : here

I begin to switch to pybind11, my change until now :

description
Boost
pybind11

C++, python type convert
boost::python::extract
py::cast(cls) or obj.cast<MyClass *>()

Python type in C++
boost::python::list/boost::python::tuple
py::list/py::tuple

Python type in C++
boost::python::make_tuple
py::make_tuple

Classe declaration
boost::python::class_
py::class_

Classe declaration
boost::python::class_("name","descr",init<>)
py::class_(m, "name","descr") .def(init<>())

Split classe declaration some file
void bind_matrix()
void bind_matrix(py::module& m)

property setter getter
.add_property
.def_readwrite

I need to replace :
boost::python::vector_indexing_suite
boost::python::throw_error_already_set
boost::python::extract<T>().check()  // I made a try/catch to replace that but that's not clean

after some reflexion, I think it's will be easier to use standard conversion already implemented in pybind11 for basic type like eigen/matrix, vector.
So convert your matrix type to eigen type and let pybind11 do the conversion to numpy type.

I'm fine with whatever pybind11 does for std::vector, but I definitely don't want to be converting back and forth between dlib::matrix and eigen's matrix.  That will make the interface unnecessarily computationally expensive.  I also don't want to add another dependency (eigen).
Are you sure dlib::matrix even uses the vector_indexing_suite?  I don't think it does.

I see vector_indexing_suite in some part of your code (class type declaration) but I don't now if it necessary with pybind11.

Is there some tests for the python binding ?

It's used in a few places, but I don't think for the matrix.
There are a huge number of C++ tests in dlib/test.  But nothing for python (other than the example programs).  Which is kinda bad.

I move a bit :
I find a way to nicely replace boost::python::extract<T>().check() with a custom struct (find on another project)
I finish rectangle and vector binding
I need to check the vector binding I doubt about cv__getitem2__

@davisking Is there a reason why you use make_matrix_from_size instead of the default matrix constructor ? (arguments validity check ?)

I don't remember.  It's probably due to some limitation in boost.python.

Is anyone working on this? I did some unrelated evaluations on my own and now made some progress. The pybind11  binding builds an so, i am currently testing this against the python examples... i'm quite optimistic at this point. @edmBernard can i take this over?

As far as I am aware no one is currently working on this.  So if you want to do it that would be super.  The need to install boost is a huge pain point for many dlib python users.

Sorry for that, I forgot a bit this binding :( , There is lot's of work and I don't know enough pybind11 at some point.
all of my work are on my fork here https://github.com/edmBernard/dlib (if it can help you)
you can see here my progression: https://github.com/edmBernard/dlib/blob/master/tools/python/src/dlib.cpp#L41 (commented line aren't done)
@davisking I don't know if there is evolution, we also need to find a alternative to boost.serializer.
all serialization parts are currently commented in my code.

Great. I have adapted all currently available modules to pybind11 and it builds without warnings and generates a shared library (on recent pybind11 + python 3.6). I will check against your progress @edmBernard, thank you.
At this point my preliminary todo items are:

[ ] review all changes and restructure commits for a first review by @davisking
[ ] get all python examples to run (+ compare results with current boost::python bindings)
[ ] fix issues from @davisking review

My questions to you @davisking at this point would be:

how do you want to review it?
should i squash my commits to a single commit? it is tough to make atomic (ie buildable) changesets from this.
do you want me to create a pull request early, so you can do a review before i tested each python example thoroughly?
do you think running the examples is enough testing at this point?
have you thought about bundling pybind11 with dlib? i am currently using CMake find_package.
would you agree that a test suite for the python bindings is a separate issue even though a change like this would justify doing it first?

Awesome.
Yes, please squash your commits to a single commit.  Also make sure there aren't whitespace changes or other non-substantive changes in there.  Sometimes people submit PRs that contain a whole lot of non-changes which makes them difficult to review.
Running the examples isn't enough testing.  There are parts of the API that don't have any examples and there isn't a unit test suite on the python side, which is not great.  There is a huge unit test suite in C++, but that doesn't help us in this case.  Anyway, just try your best to make sure the whole API is working.  Adding explicit unit tests for python would be cool if you are willing, but I wouldn't require it.
You can make the pull request whenever you want.  But I don't want to spend much time reviewing it until you think it's fully working.  So if you make a PR then let me know when it's ready for review.  Or you can wait, however, you want to do it is fine.
I would almost certainly bundle pybind11 inside dlib/external.  If it was a separate download I'm certain many users would mess that up.  I went through the same thing with libpng and libjpeg, which are very easily installed but users just kept complaining about them until I finally put copies in dlib/external.

I chose to make a preliminary PR and will let you know when it's ready for review.
Regarding testing:
I think starting with a pytest suite is the way to go. Since one has to implement quite a few python scripts anyway to do the kind of testing you'd like to see. The overhead of writing a pytest instead of an manual/interactive test session is relatively low.
But writing a test (whether in pytest or by doing manual runs) for all modules is a lot of work. So my questions are:

how would you prioritize the testing of each module?
which modules are not well covered by the examples? i thought about running the examples using gcov and then start from the least covered core-interfaces.
do you agree that the main goal of the testing in this PR is "to not break existing dlib python scripts in the wild"? this implies that the tests should be written against the boost::python interface first.

My approach would be to start with the core modules (basic, vector, matrix, image, etc.) and focus on data conversion, compatibility with the vector_indexing_suite and if the bindings actually satisfy the docstrings (what parameter-values, -types and -order are allowed). And work on use-case modules (detectors, svm, etc.) in a second step since those are much better covered by the examples. Does that make sense?

The most popular parts of dlib's python API are the modules with example programs.  Beyond that, I don't think there is much to prioritize any particular part.  Maybe the cca routines.  But most things are used by the examples.
Yes, certainly the main goal is to not break existing python scripts. If you are willing to setup the python unit tests that would be amazing. :)  Yes, definitely the approach you are suggesting is the way to go.

Also, when you are ready I'll see if I can get some other dlib users to try out your PR and see if it breaks anything.

Yes, some additional testing by other users would be very useful.
I'm still going through the code to fix a few issues and will start next week with the unit-tests. I'm not sure if we should wait with the review much longer than end of next week though, or at least at that point i will have a clear idea if anything unexpected has been popping up.
I want to have the basic testing environment running before you give the PR to other users so we can implement their feedback as regressions tests.

Sounds good.  Let me know when you are ready and I'll send out the word.

We discussed this when switching to pybind11 but were unable to find a way to make it print a warning. It seems like it ought to be possible though. But yes, it's not great.


SEGSAdmin.exe couldn't find pigg files

Expected behavior
SEGSAdmin.exe would setup CoH Data Files
Actual behavior/symptoms
SEGSAdmin.exe tried to use a directory that didn't exist
Steps to reproduce behavior/symptoms
Was following directions at https://forum.segs.io/viewtopic.php?f=4&t=8807
Did piggtool -x ./data/bin.pigg
SEGSAdmin.exe wanted more CoH Data Files, so I pointed it toward my CoX install,
but instead it used the directory "c:\games\CoH" where it did not find any.
Created "c:\games\CoH" and copied the CoX install to it, but it still couldn't find them.
Did piggtool -x on the rest of the pigg files (probably didn't need the sound and texture piggs.)
SEGSAdmin.exe then ran without complaints.
SEGS version
0.5.0
Operating system
Windows 7
C++ compiler and version
unknown

Hello HeraldOfOmega and thank you so much for filing this bug report!
We'll look into this using the latest build release and attempt to fix prior to our next release (v0.6 Outbreak)
Thank you again!

Picking up

@broxen @HeraldOfOmega
Unable to replicate this on Windows 10... Have tried copying my CoX directory to "C:/Games/CoX" but SEGSAdmin picks it up with no issue and reads / extracts the piggfiles.
Any further info would be useful.

To clarify, this was in version 0.5.0
Perhaps we've already resolved the issue in the develop branch.

Ah okay good point, I’ll try pulling down the 0.5.0 release instead as I’m
compiling latest dev branch
On Wed, 26 Sep 2018 at 18:13, broxen<EMAIL_ADDRESS>wrote:

To clarify, this was in version 0.5.0
Perhaps we've already resolved the issue in the develop branch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/Segs/Segs/issues/592#issuecomment-424797490, or mute
the thread
https://github.com/notifications/unsubscribe-auth/Ah0_aoF7BJCGstjHvAsKTwSB_OfEp5pZks5ue7WsgaJpZM4W3x_c
.

Problem has disappeared since using latest codebase.


All symbols removed instead of orgnized in Sketch 45

Just upgraded to Sketch 45 and the plugin now removes all symbols and artboards instead of organizing them. The dialog appears fine when I run the plugin, but when I hit OK all symbols are removed from the Symbols page.

I can confirm this - kills everything.

Confimed here too. Plugin broken :(

Please repair immediately !!! :(

confirming the same :---/ please fix asap

Thanks all, sorry for the inconvenience. Updating now, and going to dig into this.

confirm here, please fix the issue as soon as possible. A great plugin, need it so badly.

Hey all, thank you so much for the feedback and support. I was of course able to reproduce the issue, and I have just published an update which I believe resolves the issue. Please download and try for yourselves, and if you could let me know so we can confidently close the issue, that would be great.

I can confirm that the update is working fine for me on Sketch 45. Thank you for the great work and quick fix!

@sonburn Thanks a lot. Your plugin is just the best.

@sonburn big thumbs up to you for being so awesome.

Thank you @designkai, @Mulleboy, @chevycamaro!

Hi, could you please suggest where/how I would update SO to the latest. My symbols all disappeared!

@nicashi Just go here - https://github.com/sonburn/symbol-organizer - click Clone or Download, then Download Zip, unpack the zip and double click Symbol Organizer.sketchplugin to install the plugin, or manually move it to your plugins folder. Alternatively, you can install from a plugin management tool like Sketchrunner (which is awesome and does a lot more than manage plugins, http://sketchrunner.com/) or Sketchpacks (https://sketchpacks.com/).

Thank you Jason. Is there any way to restore the killed symbols? I mean all but two are gone!! Please help
Sent from my iPhone

On Jul 7, 2017, at 12:17, Jason Burns<EMAIL_ADDRESS>wrote:
@nicashi Just go here - https://github.com/sonburn/symbol-organizer - click Clone or Download, then Download Zip, unpack the zip and double click Symbol Organizer.sketchplugin to install the plugin, or manually move it to your plugins folder. Alternatively, you can install from a plugin management tool like Sketchrunner (which is awesome and does a lot more than manage plugins, http://sketchrunner.com/) or Sketchpacks (https://sketchpacks.com/).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@nicashi You saved your file after this happened? I am not sure why you would have done that. Regardless, you could try using Mac's file version history and roll back to the previous version - https://support.apple.com/kb/PH18862?locale=en_US

Thank you. No, I haven't saved my file after this happened. I relaunched
Sketch, in a hope that it was some rendering glitch
....................................................
Regards,
Veronica A. Shimanovskaya
+1-415-619-2856
+44 (0)20 3290 2765
https://www.linkedin.com/in/shimanovskaya
http://uk.linkedin.com/in/shimanovskaya
[ www.yellowparrot.com https://yellowparrot.wixsite.com/design ]
On Fri, Jul 7, 2017 at 1:05 PM, Jason Burns<EMAIL_ADDRESS>wrote:

@nicashi https://github.com/nicashi You saved your file after this
happened? I am not sure why you would have done that. Regardless, you could
try using Mac's file version history and roll back to the previous version

https://support.apple.com/kb/PH18862?locale=en_US

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/sonburn/symbol-organizer/issues/25#issuecomment-313779983,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AcmQGEoVI0r_3CkhnOx5JqZ3NZ-b1RmWks5sLo-TgaJpZM4OHvi3
.


1525 add slots to material processing classes that were on omics processing

nucl_acid_ext exists on OmicsProcessing (DataGeneration) and Biosample
This PR is adding MIXS slot nucl_acid_ext as a narrow_mapping for extraction_method and extraction_target as it's providing BOTH
This PR also adds http://purl.obolibrary.org/obo/NCIT_C177560 as a narrow_mapping for both extraction_method and extraction_target as this is also a more specific way of identifying BOTH.

@aclum  extraction_method slot on Class:Extraction needs to reviewed. We should get rid of it if it is not being used because the enum it is using is shared with extraction_target so it is not informative.

All wrong try again

@anastasiyaprymolenna see example data https://github.com/microbiomedata/nmdc-schema/blob/main/src/data/valid/Database-nucleic-extraction.yaml
extraction_method was intended to store some short string to summarize how the extraction was done, it is not intended to specify what the target (DNA, RNA) to extract is.

no migration


Camelcase operationId tags

Camelcase's operationId tags to follow the convention used in the
OpenAPI spec: https://github.com/OAI/OpenAPI-Specification/blob/main/versions/3.0.3.md

Looks good :shipit:


The type of SectionBase.data as ReadonlyArray

Description
I don't know if this is really a bug, but I couldn't find a better template for it.
I'm using a TypeScript library that returns data as a list, but the data type extends only the Iterable type, causing a type error because the data type in SectionList should be a ReadonlyArray.
https://github.com/facebook/react-native/blob/6c8dfc89566d27c36f9ca3828bcf3a63dfcb6942/packages/react-native/Libraries/Lists/SectionList.d.ts#L32
Shouldn't this type be ArrayLike just like it is in the data of FlatList?
https://github.com/facebook/react-native/blob/6c8dfc89566d27c36f9ca3828bcf3a63dfcb6942/packages/react-native/Libraries/Lists/FlatList.d.ts#L47
Steps to reproduce
Attempting to use an ArrayLike in a SectionList.
React Native Version
0.73.2
Affected Platforms
Other (please specify)
Output of npx react-native info
System:
  OS: macOS 13.6
  CPU: (8) arm64 Apple M1
  Memory: 50.94 MB / 16.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 18.18.2
    path: ~/.nvm/versions/node/v18.18.2/bin/node
  Yarn:
    version: 1.22.21
    path: ~/.nvm/versions/node/v18.18.2/bin/yarn
  npm:
    version: 9.8.1
    path: ~/.nvm/versions/node/v18.18.2/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.14.3
    path: /Users/gregory/.rvm/gems/ruby-2.7.6/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 22.4
      - iOS 16.4
      - macOS 13.3
      - tvOS 16.4
      - watchOS 9.4
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.2 AI-222.4459.24.2221.10121639
  Xcode:
    version: 14.3.1/14E300c
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 11.0.15
    path: /usr/bin/javac
  Ruby:
    version: 2.7.6
    path: /Users/gregory/.rvm/rubies/ruby-2.7.6/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react:
    installed: 18.2.0
    wanted: 18.2.0
  react-native:
    installed: 0.73.2
    wanted: 0.73.2
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: false

Stacktrace or Logs
No overload matches this call.
  Overload 1 of 2, '(props: SectionListProps<Task, { data: ResultsType<Task>; }> | Readonly<SectionListProps<Task, { data: ResultsType<Task>; }>>): SectionList<...>', gave the following error.
    Type 'ResultsType<Task>' is not assignable to type 'readonly Task[] & ResultsType<Task>'.
      Type 'Results<Task>' is not assignable to type 'readonly Task[]'.
        The types of '[Symbol.unscopables].length' are incompatible between these types.
          Type 'number' is not assignable to type 'boolean | undefined'.
  Overload 2 of 2, '(props: SectionListProps<Task, { data: ResultsType<Task>; }>, context: any): SectionList<Task, { data: ResultsType<Task>; }>', gave the following error.
    Type 'ResultsType<Task>' is not assignable to type 'readonly Task[] & ResultsType<Task>'.ts(2769)

Reproducer
https://github.com/GregoryEsberci/rn-flat-list-data-type
Screenshots and Videos
No response

I looked at the code for this one.
VirtualizedList originally also accepted ReadonlyArray but we ended up making it more permissive after we found real usage which relied on it accepting more than just arrays. This was also slightly breaking because the list provided callbacks with the same time, which needed to be made more generic.
VirtualizedSectionList is typed to accept arrays, and these arrays are also given to callbacks, to render the sections.
The internals could be changed to operate on ArrayLike instead, but this would be breaking to existing functions which accept sections to render, and assume a full array is present.
TLDR: the current typings are correct, but arguably a larger (but breaking) change could be made to make the data more permissive.
If your data is small enough to copy the Iterable to an array, that would be the easiest way around this.


No loss feedback (opencv chart) when training YOLO darknet on linux

Describe the bug
When training the darknet yolo, there is no loss drawn into an opencv window.
Our runlog.txt returns the following OpenCV Error:
OpenCV Error: Unspecified error (The function is not implemented. Rebuild the library with Windows, GTK+ 2.x or Carbon support. If you are on Ubuntu or Debian, install libgtk2.0-dev and pkg-config, then re-run cmake or configure script) in cvNamedWindow, file /viame/build/build/src/fletch-build/build/src/OpenCV/modules/highgui/src/window.cpp, line 593

To Reproduce
Steps to reproduce the behavior:

Download dive-viame desktop release
Run a training

Expected behavior
A window with training loss should pop as for the windows release:

Desktop (please complete the following information):

Linux ubuntu 20.04.6 LTS

You should ship the viame-dive release with libgtk2.0-dev and pkg-config and make sure to compile OpenCV with those.
Also make sure to use -Wl,-rpath,'$ORIGIN/../lib' to linker option (why using LD_LIBRARY_PATH is bad).

@mattdawkins Tagging you in this because I believe this is more a VIAME thing than  a DIVE thing.

We can move that issue to VIAME then, sorry for that.
https://github.com/VIAME/VIAME/issues/171


[CI] Fix Codecov CI

Codecov Report

Merging #2 (1cecd07) into master (78e5276) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
  Coverage   98.59%   98.59%
=======================================
  Files          23       23
  Lines        2277     2277
=======================================
  Hits         2245     2245
  Misses         32       32

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e5276...1cecd07. Read the comment docs.


ARCamera MVP: Basic screen with full screen camera and prediction labels

I have added a script to download the example model into the necessary folders, and added an explanation to the Readme.


KSECURITY-1789: upgrading requests to v2.31.0 (3.0)

upgrading requests to v2.31.0

System test (python) runs:
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5815/
https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5819/


prompt: update powerlevel10k submodule to v1.2.0

Release notes: https://github.com/romkatv/powerlevel10k/releases/tag/v1.2.0.

Thanks, @belak!

Any time!


Setup Prettier

I hadn't heard of it before, but prettier looks seriously cool. Like gofmt for JS cool.
I feel like we should wrap this in an npm script to make it accessible, otherwise it might not get used much. I'd also support enforcing it's usage via a pre-commit hook.
I think the best way to get the most value out of this is to make sure it's always run.

I'm a bit hesitant to add the git hook because it's sorta weird not
actually pushing what you originally committed. Thoughts?
On Thu, Mar 9, 2017 at 5:43 PM zpnk<EMAIL_ADDRESS>wrote:

I hadn't heard of it before, but prettier looks seriously cool. Like
gofmt for JS cool.
I feel like we should wrap this in an npm script to make it accessible,
otherwise it might not get used much. I'd also support enforcing it's usage
via a pre-commit hook
https://github.com/prettier/prettier#pre-commit-hook-for-changed-files.
I think the best way to get the most value out of this is to make sure
it's always run.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/changepane/changepane/pull/24#issuecomment-285548210,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACWP3_stMSQ4I4QcfXCm8FWMqg14Klkks5rkKrDgaJpZM4MXkf9
.

Ideally a formatter like this would be run on file save, but the commit hook would catch it for anyone without an editor extension setup. I could go either way.
How were you thinking prettier would be best used?

Wanna merge this @amccloud?


Improvements for handling redirections produced by UrlNormalizer

Q
A

Is bugfix?
no

New feature?
yes

Breaks BC?
no (if merged before 2.0.10 release)

Tests pass?
yes

Fixed issues
-

replaces #12450
I was wondering how to solve https://github.com/yiisoft/yii2/issues/3047, and I realized that the current implementation of redirections produced by UrlNormalizera is very limited. It should be improved before 2.0.10 will be released, to avoid BC trap.

What's the idea behind this change?

Without this there is no simple way to force https on redirection or redirect to custom URL. These limitations can be very problematic when extending UrlNormalizer or using UrlNormalizer::$action with callback with custom redirection.

OK. Makes sense.

Thanks!


Debpkg

@krobertson @mbhinder @wallyqs
After this is merged, I'll follow up with a PR to get packages building in TC.

Downgrading this to WIP.
I want to add upstart support, along with rpm support and a better kurma configFile before merging anything.

Alright, this should be working properly, ready for review.

LGTM confirmed works for me locally

LGTM on change to 0660 for perms. The binary tarball is meant as a quick start, but think the package is more meant as ready to go. If anything, likely change the tarball to not be 0666...

I'll add this to the release build config...


How to install dependencies?

I'm using an Ubuntu 14.04 (64 bit) and when I try to launch puppeteer i get this error message:
Error: Failed to launch chrome!
/home/cabox/workspace/node_modules/puppeteer/.local-chromium/linux-499413/chrome-linux/chrome: error while loading shared libraries: libpangocairo-1.0.so.0: cannot open shared object file: No such file or directory

I read in other issues that there is some kind of a problem with shared libraries in Linux. I'm haven't used Linux much before and I don't really know how to install dependencies but I did see in troubleshooting.md that I'm supposed to check that all dependencies are installed. How can I install libpangocairo?

Use the package manager (apt-get for 14.04) in your terminal to install the packages listed in the troubleshooting document.
You may want to reach out to an Ubuntu support area such as AskUbuntu or the Ubuntu IRC channel for support with that if you need more guidance.

For reference: troubleshooting document


Sync & Fit

Hi Louis,
Still loving it :-)
A couple of minor isuses:

A minor issue in the chart syncing: If an indicator with a lookback period (say ADX(50)) is added on a subchart, then the timescales on the two charts don't align.  The subchart starts with the first available datapoint (i.e. 50 bars in), and aligns with the start of the main chart which starts at bar 0.  A workaround is to put blank/zero data in the first 50 timeslots of the indicator, but that shows as a zero line which is less than accurate.  I guess the subchart displays its own timescale based on the subchart data, but if sync is True, it might be prefereable to use the primary chart data timescale instead?

I'm having trouble with .fit() on the first rendering of the chart.  Once I set new data from another instrument, the chart automatically fits as expected; but the first time the chart renders it squashes the data to the right hand half of the screen.  Same code is populating the chart both times.  Could be coder error on my part, but I can't find what's causing it.

Hey @algotrader-au,
Glad to hear it!
Chart syncing uses the subscribeVisibleLogicalRange method within Lightweight Charts which only pays attention to data index numbers rather than timeframe. This makes sync useful for indicators, but not for different timeframes or other data which doesnt align. (#86 also brought this up in regard to different timeframes).
It's definitely possible, but doesn't appear to be straightforward. I'll go through all the functional aspects (how zooming will behave, performance) and get back to you.
As for your second issue, could you provide a minimal reproducible example, preferably using ohlcv.csv data.
Louis

As for syncing based on timeframe, I have tried to attempt this but Lightweight Charts does not seem to offer a way to do this without glitches and bugs (at least in my implementation).
If you (or anyone else) wants to contribute with an implementation feel free.

No problems; would love to help with it, but just have too many 'fronts' open already.  If I get some spare time will come back and look at it.


RAM usage is to high >2 GB RAM.

Describe the bug
If the adapter is starting the usage of the RAM is to high. No Ram left for the system. I have 188 images with a total data size of almost 980 MB.
To Reproduce
Steps to reproduce the behavior:

Start the iobroker
Start the adapter
look on the used and free RAM

Screenshots & Logfiles

Versions:
PLATTFORM: LINUX
RAM: 3.8 GB
NODE.JS: V16.16.0
NPM: 8.11.0
Additional context
It is reproduceable.

Hi  @Maschine20
can you attach a screenshot of your configuration ?
Regards, Ralf

Hi,
here is the configuration of the instance.

Regards, Ralf


Read more buttons are not showing

When I save the file then it is visible but after a while, it happens same no button is visible. Please help it's urgent.

When I save the file then it is visible but after a while, it happens same no button is visible. Please help it's urgent.

Why are you passing renderTruncatedFooter prop ?
Not sure why it's happening though. Try passing style as a prop in ReadMore itself

  It is a long established // and so on

When I save the file then it is visible but after a while, it happens same no button is visible. Please help it's urgent.

Problem can be with the style you are passing. Can you share that as well ?

/* eslint-disable prettier/prettier */
import React from 'react';
import {StyleSheet, Text, View} from 'react-native';
import ReadMore from 'react-native-read-more-text';
export default class ReadMoreS extends React.Component {
render() {
return (

It is a long established fact that a reader will be distracted by
the readable content of a page when looking at its layout Lorem
ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod
tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim
veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex
ea commodo consequat. Duis aute irure dolor in reprehenderit in
voluptate velit esse cillum dolore eu fugiat nulla pariatur.
Excepteur sint occaecat cupidatat non proident, sunt in culpa qui
officia deserunt mollit anim id est laborum

);
}
_renderTruncatedFooter = handlePress => {
return (
<Text style={{color: '#FF6F3D'}} onPress={handlePress}>
Read more

);
};
_renderRevealedFooter = handlePress => {
return (
<Text style={{color: '#FF6F3D'}} onPress={handlePress}>
Show less

);
};
}
const styles = StyleSheet.create({
container: {
marginHorizontal: 20,
marginVertical: 20,
},
cardText: {
fontFamily: 'Roboto-Regular',
fontSize: 14,
lineHeight: 19,
color: '#555555',
},
});

I share my code above please have a look.

Now using correct please check for this issue....

Please help me for this really needed to solve this please

Please help me for this really needed to solve this please

This seems like a styling issue. Try setting flex: 1 or width: '100%' in your container style

I am facing the same issue. When I pass the {"my content"} element to library, "See more" is overlapping my content. But if I only pass {"my content"} to the library without  element, it is okay to show correctly.

I am facing the same issue. When I pass the {"my content"} element to library, "See more" is overlapping my content. But if I only pass {"my content"} to the library without element, it is okay to show correctly.

@roden0609 can you share code sample and screenshot as well ? Thanks

@fawaz-ahmed Thanks for your follow up 🙂!

/**
 * Sample React Native App
 * https://github.com/facebook/react-native
 *
 * @format
 * @flow strict-local
 */

import ReadMore from '@fawazahmed/react-native-read-more';
import ParsedText from 'react-native-parsed-text';
import React from 'react';
import {SafeAreaView, StyleSheet, View} from 'react-native';

const App = () => {

    return (
        <SafeAreaView style={styles.safe}>
            <View style={styles.root}>
                <ReadMore numberOfLines={3} style={styles.textStyle}>
                    <ParsedText
                        style={styles.text}
                        parse={
                            [
                                // {type: 'url',                       style: styles.url, onPress: this.handleUrlPress},
                                // {type: 'phone',                     style: styles.phone, onPress: this.handlePhonePress},
                                // {type: 'email',                     style: styles.email, onPress: this.handleEmailPress},
                                // {pattern: /Bob|David/,              style: styles.name, onPress: this.handleNamePress},
                                // {pattern: /\[(@[^:]+):([^\]]+)\]/i, style: styles.username, onPress: this.handleNamePress, renderText: this.renderText},
                                {pattern: /42/,                     style: styles.magicNumber},
                                {pattern: /#(\w+)/,                 style: styles.hashTag},
                            ]
                        }
                        childrenProps={{allowFontScaling: false}}
                    >
                        Hello this is an example of the ParsedText, links like http://www.google.com or http://www.facebook.com are clickable and phone number<PHONE_NUMBER> can call too.
                        But you can also do more with this package, for example Bob will change style and David too<EMAIL_ADDRESS>                        And the magic number is 42!
                        #react #react-native
                    </ParsedText>
                </ReadMore>
            </View>
        </SafeAreaView>
    );
};

const styles = StyleSheet.create({
    safe: {
        flex: 1,
    },
    root: {
        flex: 1,
        padding: 16,
    },
    textStyle: {
        fontSize: 14,
    },
    url: {
        color: 'red',
        textDecorationLine: 'underline',
    },
    email: {
        textDecorationLine: 'underline',
    },
    text: {
        color: 'black',
        fontSize: 15,
    },
    phone: {
        color: 'blue',
        textDecorationLine: 'underline',
    },
    name: {
        color: 'red',
    },
    username: {
        color: 'green',
        fontWeight: 'bold'
    },
    magicNumber: {
        fontSize: 42,
        color: 'pink',
    },
    hashTag: {
        fontStyle: 'italic',
    },
});

export default App;

Its working fine now and fixed for me


Updated the version # to 7.0.1 and created release notes

This pull request is now managed with CodeReviewHub. Refresh.


Name the resource 'frontend' instead of 'demo'

naming consistency between snippet is necessary
for the tutorial to work correctly.

Thank you @zioproto for finding this! While writing the tutorial I had named the containers 'frontend' and 'backend', but decided to rename 'frontend' to 'demo' due to rad init scaffolding the 'demo' container. We wanted to reuse that file instead of creating a different container name. I missed renaming the back-half of the files that aren't directly displayed in the webpage.
To stick with the 'rad init' scaffolded container we should switch any instance of 'frontend' to 'demo'. Opened #890 to fix both the Bicep examples and the markdown.
Thanks again!!

Pulled in you as a co-author on #890. Thanks for the contribution!


256 add new statistics

@maximusunc This PR adds new odds ratio and confidence interval stats referring to ICEES-KG code. See if it looks good to be merged.

LGTM!


Add support for Dockerization

Hello !
First of, thanks for this project, it's very convenient to poc things.
I've been using it to test kubernetes cluster application scaling settings.
To do so I needed to be able to wrap this into a Dockerfile along with allowing to pass params from environment variables.
I will submit a PR with this so you can merge it if it makes sense to you !
Cheers

Dockerization can expand its scope of use. Thanks for your work


Show launch configurations in MRU order

Type: Feature Request
When having multiple configurations in launch.json, there seems to be no efficient way to quickly select a recently used configuration with keyboard.
To launch a configuration, I usually start typing Debug: Select and Start Debugging command, press Enter, then select the required configuration from the list. If a configuration I use frequently is at the bottom of the list, selecting it with keyboard is quite inefficient.
The problem is exacerbated by the fact that compound configuraitons, which are often used more frequently than individual ones, are always shown at the end of the list, even if I specify them at the top of launch.json.

It would be a great productivity improvement to have an option to show configurations in MRU order in this list. Having come from IntelliJ Idea, the way the configurations are ordered feels like a degradation.
While I clearly like the ability to launch a configuration using keyboard rather than mouse, it's worth noting that with docked debug toolbar ("debug.toolBarLocation": "docked"), this seems to be the only way to launch an additional configuration when another one is already running. There is no way to select the additional configuration with the mouse. This makes the efficiency of running with keyboard even more important.

 Also I think that when the toolbar is docked, the 'start a new config' command should be accessible from the ... button.

This feature request is now a candidate for our backlog. The community has 60 days to upvote the issue. If it receives 20 upvotes we will move it to our backlog. If not, we will close it. To learn more about how we handle feature requests, please see our documentation.
Happy Coding!

Don't forget that you can just type a few characters of the name of the config you want, then press enter, same as other pickers in vscode.

I know and this is what I end up using. It would still be more conventional and efficient to be able to select a recently used item from the list with a couple of Down key presses.
Compare it with the usual behaviour of CommandPallette on Ctrl+Shift+P. Or file list in Go to File.... In both cases, it's possible to search for the required command or file by name. But if you keep rerunning a recent command or switching between 5 recent files in a big codebase, it's so much easier to select what you need from the top of the list with the arrow keys.

Also I think that when the toolbar is docked, the 'start a new config' command should be accessible from the ... button.

True. Still a few extra clicks but I agree that this invalidates my second point.

:slightly_frowning_face: In the last 60 days, this feature request has received less than 20 community upvotes and we closed it. Still a big Thank You to you for taking the time to create this issue! To learn more about how we handle feature requests, please see our documentation.
Happy Coding!


Including internal, closed source repos causes lookup failures

We have a private gitlab where we host our own go repos, and it seems, even with overrides or exceptions, I can't prevent the sum.golang.org lookup, which causes a failure -- thus preventing us from using this in CI. To be clear, our gitlab instance isn't accessible except on internal networks, so this lookup fails. See snippet for more details (I anonymized the URL, but I think you'll get the point).
$ (lichen -c lichen.yaml ./${PROJECT_NAME} | tee license_report.txt) || true
2021/07/22 15:04:44 failed to evaluate licenses: failed to fetch: exit status 1 (output:
{
	"Path": "github.com/hashicorp/hcl",
	"Version": "v1.0.0",
	"Info"<EMAIL_ADDRESS>	"GoMod"<EMAIL_ADDRESS>	"Zip"<EMAIL_ADDRESS>	"Dir"<EMAIL_ADDRESS>	"Sum": "h1:0Anlzjpi4vEasTeNFn2mLJgTSwt0+6sfsiTG8qcWGx4=",
	"GoModSum": "h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ="
}
{
	"Path": "github.com/spf13/afero",
	"Version": "v1.3.4",
	"Info"<EMAIL_ADDRESS>	"GoMod"<EMAIL_ADDRESS>	"Zip"<EMAIL_ADDRESS>	"Dir"<EMAIL_ADDRESS>	"Sum": "h1:8q6vk3hthlpb2SouZcnBVKboxWQWMDNF38bwholZrJc=",
	"GoModSum": "h1:Ai8FlHk4v/PARR026UzYexafAt9roJ7LcLMAmO6Z93I="
}
# ...
# truncated ...
# ...
{
	"Path": "gitlab.ourcompany.com/software/whatever/thing",
	"Version": "v0.0.0-20210610205813-eb9a997ab73f",
	"Error"<EMAIL_ADDRESS>verifying go.mod<EMAIL_ADDRESS>reading<EMAIL_ADDRESS>410 Gone\n\tserver response: not found<EMAIL_ADDRESS>unrecognized import path \"gitlab.ourcompany.com/software/whatever/thing\": https fetch: Get \"https://gitlab.ourcompany.com/software/whatever/thing?go-get=1\": dial tcp: lookup gitlab.everactive.com on <IP_ADDRESS>:53: no such host",
	"Info"<EMAIL_ADDRESS>}

Not sure if this is really a bug or a feature request, so I'll leave that up to you, but I would imagine maybe adding some sort of config option to ignore modules that start with a certain URL?
ignoreURL: gitlab.ourcompany.com

Or making it so that override directives don't query sum.golang.org at all.

Thanks for the detailed report. Just to check a couple of things:

Is the private repo accessible from the CI build on a general basis, or is it entirely inaccessible from that context?
If it is accessible, is GOPRIVATE set? That would in theory prevent requests to sum.golang.org

It's definitely accessible from CI (it's part of that gitlab's CI), but we don't have the GOPRIVATE set in CI, so I'll give that a shot!

That did it! Thank you! Might be worth adding a section to the README for future private repo users. Either way, great tool.

I've just added a note in the README :+1: Apologies for being slow getting back to this.

Thanks!


[formio][SIMS #1124]Change canada to Canada

Updated country dropdown code from canada to Canada to be displayed correctly in the UI;
Changed some form conditions to display Province or Custom Country based on the dropdown selected code, previously there were some based on the country that caused issues when the country code was renamed to Canada with the proper case;
All files were formatted with Prettier and one changed from CRLF to LF.

The changes access all the files are pretty much the same.
Below are the real changes sample:

Can you please check the formatting of the document? I feel the json is not formatted right @andrewsignori-aot

Can you please check the formatting of the document? I feel the json is not formatted right @andrewsignori-aot

As we talked about in the chat, let's keep the Prettier as the default one.


Fix ItemsRepeater overwriting DataContext

Fixes https://github.com/microsoft/microsoft-ui-xaml/issues/1739
Description
There is a scenario where ItemsRepeater overwrites DataContext on elements that are passed in via ItemsSource and are intended for display without wrapping.
The Scenario:
If there is an ItemTemplate set on the ItemsRepeater that simply returns the element that is stored in the ItemsSource, the ViewManager overwrites the DataContext on that specific element. This becomes a problem if a user sets the DataContext to something and expects to be able to retrieve it via the element at a later time.
Motivation and Context
This problem surfaces for the repeater implementations of NavigationView and RadioButtons controls because they always have an ItemTemplate set on their ItemsRepeater.
How Has This Been Tested?
Added a new API test.

        elementAsFE.DataContext(data);

If data is a UIElement, and if there is an ItemTemplate, we will not call into the ItemTemplate anymore. Is that ok ? Is there a case where you are given a list of UIElements but you still want to go through the factory ?

Refers to: dev/Repeater/ViewManager.cpp:676 in c37e118. [](commit_id = c37e118351f93b6c7fa896addbd4a601ba2e100e, deletion_comment = False)

winrt::UIElement ViewManager::GetElementFromElementFactory(int index)

Please add a comment about all the cases being handled here for clarity.

Refers to: dev/Repeater/ViewManager.cpp:600 in c37e118. [](commit_id = c37e118351f93b6c7fa896addbd4a601ba2e100e, deletion_comment = False)

        elementAsFE.DataContext(data);

I don't think this is true, with the code as written, if there is an element factory we will use it.  The use of scratch variables and nullptr flag makes it pretty hard to reason about though.. perhaps a refactor is warranted?

In reply to: 563328419 [](ancestors = 563328419)

Refers to: dev/Repeater/ViewManager.cpp:676 in c37e118. [](commit_id = c37e118351f93b6c7fa896addbd4a601ba2e100e, deletion_comment = False)

        elementAsFE.DataContext(data);

My bad. I see that we check if the data is an element only if there is no ItemTemplate. So i guess we still need to support forwarding the data context (instead of just setting the data as the context)  if the data is UIElement and the ItemTemplate returned a UIElement that is different from the data.

In reply to: 563341524 [](ancestors = 563341524,563328419)

Refers to: dev/Repeater/ViewManager.cpp:676 in c37e118. [](commit_id = c37e118351f93b6c7fa896addbd4a601ba2e100e, deletion_comment = False)

}

suggestion:
auto const data = m_owner->ItemsSourceView().GetAt(index);

auto const element = [this, data, providedElementFactory = m_owner->ItemTemplateShim()]()
{
    if(!providedElementFactory)
    {
        if(auto const dataAsElement = data.try_as<winrt::UIElement>())
        {
            return dataAsElement;
        }
    }

    auto const elementFactory = [this, providedElementFactory]()
    {
        if(!providedElementFactory)
        {
            auto const factory = winrt::XamlReader::Load(L"<DataTemplate xmlns='[http://schemas.microsoft.com/winfx/2006/xaml/presentation](http://schemas.microsoft.com/winfx/2006/xaml/presentation)'><TextBlock Text='{Binding}'/></DataTemplate>").as<winrt::DataTemplate>();
            m_owner->ItemTemplate(factory);
            return m_owner->ItemTemplateShim();
        }
        return providedElementFactory;
    }();

    auto const args = [this]()
    {
        if(!m_ElementFactoryGetArgs)
        {
            auto const args = winrt::make_self<ElementFactoryGetArgs>();
            m_ElementFactoryGetArgs.set(args);
            return args;
        }
        return m_ElementFactoryGetArgs.get();
    }();

    auto scopeGuard = gsl::finally([args]()
    {
        args.Data(nullptr);
        args.Parent(nullptr);
    });

    args.Data(data);
    args.Parent(*m_owner);
    args.as<ElementFactoryGetArgs>()->Index(index);

    return elementFactory.GetElement(args);
}();

Refers to: dev/Repeater/ViewManager.cpp:638 in c37e118. [](commit_id = c37e118351f93b6c7fa896addbd4a601ba2e100e, deletion_comment = False)

}

I think this works but I wrote it in codeflow, so it may or may not compile. regardless I think this style does a good job of showing you all the peices that go into defining what the element is while also encapsulating bits of logic together.  As a reader new to this code I found myself constantly checking to see if the element or the factory had changed somewhere in the function. I think this is the perfect candidate for ES.28 and that this bug would have been much easier to reason about had the code been structured this way. https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#es28-use-lambdas-for-complex-initialization-especially-of-const-variables

In reply to: 563352427 [](ancestors = 563352427)

Refers to: dev/Repeater/ViewManager.cpp:638 in c37e118. [](commit_id = c37e118351f93b6c7fa896addbd4a601ba2e100e, deletion_comment = False)

        elementAsFE.DataContext(data);

Added code to support the DataContext forwarding scenario mentioned above and added another test to verify it.

In reply to: 563343489 [](ancestors = 563343489,563341524,563328419)

Refers to: dev/Repeater/ViewManager.cpp:676 in c37e118. [](commit_id = c37e118351f93b6c7fa896addbd4a601ba2e100e, deletion_comment = False)

    if (extension)

combine

Refers to: dev/Repeater/ViewManager.cpp:684 in bca9f69. [](commit_id = bca9f690513426bc18fb304af5650b90cf00b684, deletion_comment = False)


Waypoint: Target a Specific Child of an Element Using jQuery

Challenge http://www.freecodecamp.com/challenges/waypoint-target-a-specific-child-of-an-element-using-jquery has an issue. Please describe how to reproduce it, and include links to screenshots if possible.
Hi there
Using Firefox version 40.0.2 I encounted a problem with the above tutorial that involves using the :nth-child() selector in jQuery.
Check out the screenshots, in the first one you can see that the script parsing my code interprets my code as correct even thought it doesn't make sense. In the second screenshot you can see what I -think- is the working code which and it is not parsed the solution to the problem. In the third screenshot you can see another  version of the code that it parsed as correct.
Hope this helps!

Nevermind, misunderstood the Waypoint.


Allow selecting and clicking unzoomed agents. [rebuild]

Several new players during informal UX tests keep trying to click the unzoomed agent circles. Their use case is that they found someone moving, are interested, and want to get more details about what's happening. It's hard for them to zoom in and find them, especially when the sim is running at high speed. The zoomed agents -- especially tiny pedestrians and bikes -- being hard to click doesn't help.
So this PR adds unzoomed agent selection:

Some caveats:

won't work for buses (minor, because lots of transit stuff is broken generally right now)
when you click from this view, it opens the trip panel and centers on them. The automatic centering and snapping feels a bit clunky, especially since it can slightly shift the screen when the agent clicked is already close to center. Should we do the zoom in animation instead?
I tried a few variations of outlines around the circle, but it's still hard to see the zoom level is very low and the circles are clustered. Is the cyan solid circle too jarring?

And this is a draft, because the performance is unacceptably sad. I think we need to build a quadtree while the main drawing loop iterates over all the unzoomed agents, or plumb the mouseover check inside the loop. Anything to avoid querying all unzoomed agents multiple times.
@michaelkirk Any preliminary feedback?

For the caveats:
I think the centering and snapping look fine to me. The zooming in might be problematic since users might click and switch between different agents trying to compare (my assumption). I would keep the interaction simple and consistent for now and test it later
I think the color looks too bold but I wouldn't worry about it now, since we are going to do the UI and visual 'refactoring'. We can define and set the colors at that time.

Is the cyan solid circle too jarring?

For widgetry, we often use orange as a highlight to hint that the thing you are hovering over can be clicked.
Being that it's part of the map and not part of the "controls" I could see an argument that it might deserve different treatment, but all things being equal , maybe it's a more consistent choice than introducing another one-off color.

@michaelkirk PTAL. Dodging the performance question for now by flagging off the new feature. But since there's also some refactoring in this PR, I'd prefer merging it and iterating later, especially since I'm context switching so much this week. :\


undefined instance with webpack 2.2.1

I normally create a instance with this piece of code:
import axios from 'axios'

let http = axios.create({
  baseURL: process.env.BASE_URL
})

export default http

However, it doesn't work with Webpack 2..

I haven't tested Axios with Webpack 2. It could be an issue. What is you're target in Webpack, browser or node?

I'm using it with vue-loader, so browser :)

I believe it was due to a configuration error on my part.


(Feature) Load settings from repo

I haven't seen that it is currently possible, but would be great if the settings for this could be loaded from the repo currently being worked on
For example, if there was a file in the root called .committemplate this could override any local settings with the contents of this file
Why? Every member of a team could use this plugin and the commit message templates would be consistent (and up to date) rather than needing to ask everyone to update the settings within the plugin each time the templates need to be updated
This would be a bit like how .editorconfig works (https://editorconfig.org)

Hi,
You can use a the file vscode/settings.json in the folder opened with vscode, it override settings for vscode locally 😉
Have a nice day,
Kevin

You can use a the file vscode/settings.json in the folder opened with vscode, it override settings for vscode locally 😉

Aren’t these all the settings for vscode though? The suggested feature is just for the settings for the plug-in to standardise commit messages for the team to use, by loading the settings from the repo currently being worked on

I think this is a good idea. because there are lots of personal settings in vscode/settings.json I think it is not ideal force other team member to have one settings


change metadata field from requirements to dependencies

The requirements field in metadata.json causes puppet to issue a Could not find class error:
[vagrant@centos64 ~]$ cat /etc/redhat-release
CentOS release 6.4 (Final)

[vagrant@centos64 ~]$ puppet --version
3.2.4

[vagrant@centos64 ~]$ git clone https://github.com/bashtonltd/puppet-timezone
Initialized empty Git repository in /home/vagrant/puppet-timezone/.git/
remote: Counting objects: 108, done.
remote: Total 108 (delta 0), reused 0 (delta 0)
Receiving objects: 100% (108/108), 17.73 KiB, done.
Resolving deltas: 100% (34/34), done.

[vagrant@centos64 ~]$ mkdir modules
[vagrant@centos64 ~]$ ln -s $(pwd)/puppet-timezone modules/timezone

[vagrant@centos64 ~]$ sudo puppet apply --noop --modulepath=$(pwd)/modules modules/timezone/tests/init.pp
Error: Could not find class timezone for centos64.localdomain on node centos64.localdomain
Error: Could not find class timezone for centos64.localdomain on node centos64.localdomain

Changing the requirements field to dependencies fixes it:
[vagrant@centos64 ~]$ sed -i -e 's/requirements/dependencies/' modules/timezone/metadata.json

[vagrant@centos64 ~]$ sudo puppet apply --noop --modulepath=$(pwd)/modules modules/timezone/tests/init.pp
Warning: Config file /etc/puppet/hiera.yaml not found, using Hiera defaults
Notice: /Stage[main]/Timezone/File[/etc/sysconfig/clock]/content: current_value {md5}c5daf08a96d4decb4886f54d6a280348, should be {md5}e2ef1ca924ffd45d61ddd0a2cbb7700f (noop)
Notice: Class[Timezone]: Would have triggered 'refresh' from 1 events
Notice: Stage[main]: Would have triggered 'refresh' from 1 events
Notice: Finished catalog run in 0.17 seconds

The puppet documentation lists dependencies as a required field, not
requirements:
https://docs.puppetlabs.com/puppet/latest/reference/modules_publishing.html#fields-in-metadatajson

Thanks!


Not-yet-implemented case in the -spirv-unify-aliased-resource pass

What happened?
/home/prashant/v_diff.mlir:20:3: note: called from
  func.func @forward(%arg0: tensor<2x3x256x256xf32>, %arg1: tensor<2xf32>, %arg2: tensor<2x512xf32>) -> tensor<2x3x256x256xf32> {
  ^
/home/prashant/v_diff.mlir:4727:13: error: failed to run translation of source executable to target executable for backend #hal.executable.target<"vulkan", "vulkan-spirv-fb", {spv.target_env = #spv.target_env<#spv.vce<v1.5, [Shader, Float64, Float16, Int64, Int16, Int8, StorageBuffer16BitAccess, StorageUniform16, StoragePushConstant16, StorageBuffer8BitAccess, UniformAndStorageBuffer8BitAccess, StoragePushConstant8, GroupNonUniform, GroupNonUniformVote, GroupNonUniformArithmetic, GroupNonUniformBallot, GroupNonUniformShuffle, GroupNonUniformShuffleRelative, GroupNonUniformClustered, GroupNonUniformQuad, VariablePointers, VariablePointersStorageBuffer, CooperativeMatrixNV], [SPV_KHR_16bit_storage, SPV_KHR_8bit_storage, SPV_KHR_storage_buffer_storage_class, SPV_KHR_variable_pointers, SPV_NV_cooperative_matrix]>, NVIDIA:DiscreteGPU, #spv.resource_limits<max_compute_shared_memory_size = 49152, max_compute_workgroup_invocations = 1024, max_compute_workgroup_size = [1024, 1024, 64], cooperative_matrix_properties_nv = [#spv.coop_matrix_props<m_size = 8, n_size = 8, k_size = 32, a_type = i8, b_type = i8, c_type = i32, result_type = i32, scope = 3 : i32>, #spv.coop_matrix_props<m_size = 16, n_size = 16, k_size = 16, a_type = f16, b_type = f16, c_type = f16, result_type = f16, scope = 3 : i32>, #spv.coop_matrix_props<m_size = 16, n_size = 16, k_size = 16, a_type = f16, b_type = f16, c_type = f32, result_type = f32, scope = 3 : i32>]>>}>
    %1267 = linalg.generic {indexing_maps = [#map8, #map13, #map8], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%1266, %cst_369 : tensor<2x512x16x16xf32>, tensor<512x1x1xf32>) outs(%1175 : tensor<2x512x16x16xf32>) {
            ^
/home/prashant/v_diff.mlir:20:3: note: called from
  func.func @forward(%arg0: tensor<2x3x256x256xf32>, %arg1: tensor<2xf32>, %arg2: tensor<2x512xf32>) -> tensor<2x3x256x256xf32> {
  ^
/home/prashant/v_diff.mlir:4727:13: error: failed to serialize executables
    %1267 = linalg.generic {indexing_maps = [#map8, #map13, #map8], iterator_types = ["parallel", "parallel", "parallel", "parallel"]} ins(%1266, %cst_369 : tensor<2x512x16x16xf32>, tensor<512x1x1xf32>) outs(%1175 : tensor<2x512x16x16xf32>) {
            ^
/home/prashant/v_diff.mlir:20:3: note: called from
  func.func @forward(%arg0: tensor<2x3x256x256xf32>, %arg1: tensor<2xf32>, %arg2: tensor<2x512xf32>) -> tensor<2x3x256x256xf32> {
  ^
compilation failed

Steps to reproduce your issue
iree-compile  --iree-input-type=none --iree-vm-bytecode-module-output-format=flatbuffer-binary --iree-hal-target-backends=vulkan --mlir-print-op-on-diagnostic=false --iree-llvm-target-cpu-features=host -iree-vulkan-target-triple=ampere-rtx3090-linux --iree-stream-resource-index-bits=64 --iree-vm-target-index-bits=64 v_diff.mlir
IR: https://gist.github.com/pashu123/5d69b27f781fedab03dcb5485ecc9925
What component(s) does this issue relate to?
Compiler
Version information
No response
Additional context
No response

@antiagainst @MaheshRavishankar This issue needs triaging. Can you take a look?

I've uploaded https://reviews.llvm.org/D130669 and https://reviews.llvm.org/D130671 to address this issue.

I have verified and this addresses the issue. Thanks, @antiagainst for the super fast fix.


Retrieving IP version from deployment.

On this PR:

Created all the boilerplate needed on the 'tripleo' library to be able to access the featureset file.
Retrieving the IP version file from the file, parsing its value and formatting it as an output for the library.

Missing yet:

Testing
Documentation
A way of getting the featureset file by cloning the repository.

This PR is a preview of what I am working on, when everything is all done I will try to upload it in smaller chunks.

Overall looks really interesting so far. Looking forward to the full version of it.

I am closing this in favor of https://github.com/rhos-infra/cibyl/pull/371 and others that come after.


introduce a new concept: offer type

Before, the smallest service unit is at instance level.
But GCP provides services at VCPU/RAM level, the current model cannot support this.
So a new field OfferType is necessary to the struct Offer, distinguishing the difference between them.

PTAL

PTAL


How the backward overflow test works

Dear Team,
I am currently developing FA2 for AMD platforms and when I investigate on the unit tests, I saw there is a new tests called backward overflow.
After I trace through the test script, I saw the values of q_pt.grad and k_pt.grad are both all zeros after out.backward(). Is that supposed to be so? What is the main purpose for this test?

I also wonder if you are using RTN or RTZ for the unit tests to all pass?

These tests were added because of some bug reports on gradients being NaN. Multiply q and kv by some amount (3 or 5) is just to potentially trigger the logits being larger than fp16 limit that could lead to NaN without proper masking.
I'm not sure if we're using RTN or RTZ, it shouldn't matter too much. If the results are close you can increase the tolerance a bit to make it pass.

Hi dao. Thanks for clarifying! We are doing upstream integration from your version v2.0.4. In our implementation, we need to build with RTN for running UT for higher precision, and build with RTZ for benchmarks because of better performance. I am just curious how you can reach the best performance and pass all unit tests at the same time.

Are you referring to the fp32 -> fp16/bf16 conversion of the forward pass output? Or fp32 -> fp16/bf16 conversion of dQ, dK, dV? Or is there another conversion?
Tbh I'm not sure if I'm using RTN or RTZ, whatever is the default in Cutlass when doing fp32 -> fp16/bf16 conversion.

I think we're using RTN since that's what cutlass conversion function calls.


Add more derive to types?

When using types like factory::Job, it is impossible to clone it due to lack of derives. It will be useful to add them. If this is desirable, I can make a PR.

That's kind-of by design, as the actor should "own" the job and we want to move ownership vs cloning everywhere.
Do you have a use-case you're trying to solve by cloning a job? The underlying message type can be cloned, since it's up to the developer to define it, and then you could re-create the job options. But I don't really see the need to clone the full job itself.

That's kind-of by design, as the actor should "own" the job and we want to move ownership vs cloning everywhere.
Do you have a use-case you're trying to solve by cloning a job? The underlying message type can be cloned, since it's up to the developer to define it, and then you could re-create the job options. But I don't really see the need to clone the full job itself.

This makes sense. I actually couldn't remember why I need it to be clone.


enable envoy to be tested as external dependency

Signed-off-by: William DeCoste<EMAIL_ADDRESS>For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: This change will enable running tests containing paths to scripts, data files, etc. from projects that include Envoy as a dependency (e.g. Istio Proxy). Can now run bazel test with a target such as<EMAIL_ADDRESS>by adding --test_env=EXTERNAL_TEST=true to .bazelrc
Risk Level: Low
Testing: Passes all standard tests
Docs Changes: None
Release Notes: None
[Optional Fixes #Issue]
[Optional Deprecated:]

This is a workaround for https://github.com/bazelbuild/bazel/issues/7399, right? Can we make that clear if so, and also add docs for this to https://github.com/envoyproxy/envoy/tree/master/bazel? FWIW, on the Lyft side of things we did --noexperimental_remap_main_repo per @lizan, maybe Istio should do this also as a temporary workaround? cc @htuch

Thanks @mattklein123. I wasn't aware of https://github.com/bazelbuild/bazel/issues/7399, but looks like the same issue. We'd like to be able to run all of the envoy tests with istio proxy as part of our openssl work.
I will test --noexperimental_remap_main_repo asap.

Also, while this patch allows for some of the tests to run (e.g. ssl_socket_test) it does not allow for all of the tests with hardcoded paths (e.g. runtime) to run. I will propose additional changes to support all of the tests.

This is my first time adding doc ... in this case should I add a section to docs or just bazel/README.md?
Thanks

I spoke with Bazel team today, we should be using @bazel_tools//tools/cpp/runfiles to figure out the runfiles path in TestEnvironment.

@htuch ok, thanks. Sounds like this would be a larger refactor of TestEnvironment. I'll look into it if there are no objections.

@bdecoste yeah, I think you just need to change how TestEnvironment computes the runfiles dir, using something like https://github.com/jmillikin/rules_m4/blob/4779f77e37db9f0b3005734f0268f99b7204fe3e/tests/m4_test.cc#L14

@htuch looks like this is indeed prevented by the bazel issue that @mattklein123 referneces. Runfiles::Rlocation(...) does not return the correct location when running the envoy tests from istio proxy. So I'd like to continue with this PR as a workaround. If that's acceptable, should I add a section to docs or just bazel/README.md?

@bdecoste if you just need a workaround, you can add a script in your project depending on Envoy:
#!/bin/bash
#
# Wraps upstream test
export TEST_WORKSPACE=envoy
$@

and pass it to bazel with --run_under.

@lizan great, thank you . I will try that

@lizan that works great, thank you. Closing this PR.


@cavvia => Set page titles for certain /collect filters, based on external JSON file

Adding some specs now.
This renders the server-side page w/ the correct title (if the current medium/gene filters match an entry present in the JSON file), and also keeps the title correct as you are filtering.

I just have a comment about the lazy fetching of data from S3... I think your promise based approach is doing this but i'm not 100% sure.

This should be good to go.

Tested on staging, looks good :+1:


Updating readme by updating some sections and fixing some typo.

Links to the examples and reviewer info were updated. Getting Started and Running Examples sections were updated. Some typo were fixed.

:memo: TAOS-CI Version: 1.4.20191203. Thank you for submitting PR #738. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnsuite.mooo.com/.

INFO: You can read if there are misspelled characters at our misspelling check report. Please read http://nnsuite.mooo.com/nntrainer/ci/repo-workers/pr-checker/738-202011111733340.88675594329834-82ef8c54bc9dc1fd89405042664d4e63b03aeca4/report/misspelling_result.txt.

:octocat: cibot: @meteozay, One of the module of prebuild group is failed. If you want to get a hint to fix this issue, please go to https://github.com/nnstreamer/nntrainer/wiki/.


Feature request: Display open/close state of issue

Sometimes I accidentally happen to commit work on issues that have been closed. It would be very helpful if the selected issue would be displayed with strike-through (or other means) to display that the issue has been closed.

That's an interesting proposition - I'll think about it.

Feel free to make this feature and submit a pull request.


Use computed fields for Expr, Level, and Name

This PR is only a preview, still waiting for #1290.
The refactor was surprisingly easy and fast, at least once you figure out at which points you need to update stage0.  The smart constructors are still there, but they could also be removed in a future PR.
@Kha Would it be possible to run the benchmarks on this PR?

!bench

Something is rotten in the state of Benchmark...

!bench

Now the diff is a net reduction of 26kLOC. :smile:  @Kha Could you please start a new benchmark run?

Oops, forgot the borrow annotation. :-/  @Kha Can I bother you again?

Actually you might have sufficient permissions to trigger it yourself?

!bench

!bench

!bench

!bench

I'm still at a loss where the 5% stdlib runtime increase comes from, but I've found an exciting related bug.  It turns out that Expr.updateApp! and co. have been broken for some time, and always constructed a new expression.  As a result, the following printed false:
import Lean
open Lean

#eval
  let e := mkApp (mkSort levelZero) (mkSort levelZero)
  let e' := e.replace fun _ => none
  ptrAddrUnsafe e == ptrAddrUnsafe e'

The reason is a missed optimization:
set_option trace.compiler.ir.result true

inductive Exp
  | var (i : Nat)
  | app (a b : Exp)

def Exp.hash : Exp → Nat
    | .var i => i
    | .app a b => a.hash + b.hash

def Exp.complicatedHash : Exp → Nat
  | app a b =>
    -- This always constructs an `app a b`-object, even though we could reuse the input.
    (app a b).hash
  | e => e.hash

I've now reimplemented all the update* functions in Lean and they now behave as they should.

Also somewhat concerningly, Level.updateMax! is not referentially transparent (since it applies the simplification only in one branch):
import Lean
open Lean

@[noinline] def noinline (a : α) := a

#eval --- false?!?!?!?
  let b := levelZero
  let a1 := mkLevelParam `a
  let a2 := mkLevelParam (noinline `a)
  let l := mkLevelMax a1 b
  (l.updateMax! a1 b) == (l.updateMax! a2 b)

!bench

It turns out that Expr.updateApp! and co. have been broken for some time

Thanks for reporting this issue. I pushed a fix for it.

Also somewhat concerningly, Level.updateMax! is not referentially transparent (since it applies the simplification only in one branch):

Pushed a fix for this too.

!bench

!bench

I have only minor issues. We can address them after the merge. I just enabled the auto-merge.


Add Missing case compatibility test and definitions

Add Missing Tests and definitions  for case compatibility.
I'm doubting about adding to Form and Json what do you think?

@solnic any update on this one?

In the future, please rebase and squash clean-up commits. It's easier to read history with fewer commits and it's useful when writing release notes / updating changelogs.

@solnic fortunately, those are very rare, at least by me. FWIW, it'd be better to tag them with [cleanup], or [style], or something. From my experience, having huge commits with style changes makes them annoying for later digging through the history with tools like blame.


Master build broken

Hey, the master build has been broken for ~2 weeks. Looks like a docker issue:
ContainerError: Command 'test -d  /tmp/luigi-test' in image 'busybox:latest' returned non-zero exit status
from: https://travis-ci.org/spotify/luigi/jobs/336516969
@ulzha wanna take a look? If you don't have time, no big deal - I can take a look at it sometimes next week.

Easiest is to just disable it (send a PR) similar to how many other tests are disabled.. Sorry for the inconvenience!

fixed by: https://github.com/spotify/luigi/pull/2356

Thank you!


gpt-3.5-turbo-16k azure call is failing

The bug
The call with azure key for gpt-3.5-turbo-16k fails for list index out of range error.
'''''''''''''''''''''''''''''''''''''
3-07-18 04:22:00,419 INFO [qna_logic.py:51]  [ds_models.all_guidance.qna_logic] [1dd58ad8-d1c2-4367-bd4e-8e99681d2a82][SESSION: abcd-session][QUESTIONID: question_1] Time taken for embed_query_timing :0.3142378330230713
2023-07-18 04:22:00,419 INFO [qna_logic.py:51]  [ds_models.all_guidance.qna_logic] [1dd58ad8-d1c2-4367-bd4e-8e99681d2a82][SESSION: abcd-session][QUESTIONID: question_1] Completed vector search, switching to Azure 16k call
2023-07-18 04:22:00,480 INFO [qna_logic.py:51]  [ds_models.all_guidance.qna_logic] [1dd58ad8-d1c2-4367-bd4e-8e99681d2a82][SESSION: abcd-session][QUESTIONID: question_1] Time taken for answer_stream_start :0.06079912185668945
Traceback (most recent call last):
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 109, in run
await self.visit(self.parse_tree, VariableStack([self.program._variables], self))
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 559, in visit
visited_children.append(await self.visit(child, variable_stack, inner_next_node, inner_next_next_node, inner_prev_node, node, parent_node))
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 524, in visit
command_output = await command_function(*positional_args, **named_args)
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/library/_assistant.py", line 13, in assistant
return await role(role_name="assistant", hidden=hidden, _parser_context=_parser_context, **kwargs)
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/library/_role.py", line 17, in role
new_content += await parser.visit(
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 559, in visit
visited_children.append(await self.visit(child, variable_stack, inner_next_node, inner_next_next_node, inner_prev_node, node, parent_node))
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 559, in visit
visited_children.append(await self.visit(child, variable_stack, inner_next_node, inner_next_next_node, inner_prev_node, node, parent_node))
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 266, in visit
visited_children = [await self.visit(child, variable_stack, next_node, next_next_node, prev_node, node, parent_node) for child in node]
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 266, in
visited_children = [await self.visit(child, variable_stack, next_node, next_next_node, prev_node, node, parent_node) for child in node]
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/_program_executor.py", line 379, in visit
command_output = await command_function(*positional_args, **named_args)
File "/home/raamb/workspace/docker-privateblok-api/env/lib/python3.10/site-packages/guidance/library/_gen.py", line 172, in gen
new_text = resp["choices"][0].get("text", "")
IndexError: list index out of range
Error in program:  list index out of range
''''''''''''''''''''''''''''''''''''''''''''''''''
To Reproduce
Any guidance call with azure 16k
System info (please complete the following information):

OS (e.g. Ubuntu, Windows 11, Mac OS, etc.): Ubuntu x86_64 x86_64 x86_64 GNU/Linux
Guidance Version (guidance.__version__): 0.0.64

A possible fix has been provided as part of : https://github.com/microsoft/guidance/pull/319

Possibly related? https://github.com/guidance-ai/guidance/issues/340


Picasso library need to be updated

Picasso dependency needs to be updated, due public API has changed.
If a project have current Picasso version (2.7.x) you have this error in final of checkout operation:
java.lang.NoSuchMethodError: No static method with(Landroid/content/Context;)Lcom/squareup/picasso/Picasso; in class Lcom/squareup/picasso/Picasso;

Hi Renascienza, thanks for contacting us.
We have no plans in the mid term to update Picasso's dependency. Square says that Picasso 2.7+ is not backward compatible. Therefore, if we update it, we will break other projects which are already implementing us.
Kind regards.

Hi, cgaggino.
This is exactly the problem.
My project have another libraries that uses Picasso 2.7+ (and I can't avoid it).
 Bad, right?)
So, if you can suggest a workaround about this, would be appreciated. If you don't what your suggestion? Just give up to use MercadoPago as my paying system for good and try to find some competitor?
Needless to say, from my IT experience (some), there is no such thing as "our library can't have the dependences updated". If something can break if you update, you fix this possibility on code. But is not my team so...
Even so, I have a problem that may affect other library users and deserve to be fixed, right?
I was also a little dissatisfied with how the problem was handled. If someone open an issue, is because that person have a problem. Just to say "We are not going to do anything, we don't care, Issue closed, kind regards (in some cases, sound like a polite expression to "get lost")" doesn't seems to be a correct way to deal with. Looks like a bad attitude...
Anyway, I will open a more specific issue with the exact error found.

Hi Renascienza,
I apologies if i my answer was not satisfactory, and I will try to explain myself
The issue was related to update Picasso and that is something we can't do, because like you, there are many other people using this library which do not have compatibility problems with Picasso and if we update Picasso, a lot of people would start to have problems
The same problem was reported a while ago: https://github.com/mercadopago/px-android/pull/1547
On the other hand, I took a look to the compatibilities issues and I think I found a workaround that could help you. I will come with news later today in your new issue.
Kind regards.

Hi, @cgaggino . The workaround was tested and is successful, the payment process works now.
Thanks.


Support running logical replication locally for easier development

[x] Document existing way to test logical replication with migrations using multiple appliances
[x] Subscriber? was always true for intracluster replication, so use publisher? first to better identify the replication type
[x] Enhance subscriber? to fix prior issue by allowing an optional database name to be provided so only subscriptions for the optional database would count for a true or false result.  If not provided, the default behavior is kept.
[x] Add create replication slot method
[x] Change manageiq code to use new pg-logical_replication release and utilize create_replication_slot method to support intracluster replication by creating the slot and subscription separately.
[x] Create basic rake task/documentation to setup a local replication environment for testing and development

Done!


fix handshake error

if something go wrong while erlang-dist-protocol handshake, coroutine
which initiate connection would block forever by reading from
channel.
Added error sending in case of some, so coroutine return error to
caller.

i've just merged a bunch of updates, so its not valid anymore


Fixes regression where user was unable to type into the input field

Fix for a regression created in https://github.com/airbnb/react-dates/pull/229.
Thanks @timhwang21 for bringing it up here - https://github.com/airbnb/react-dates/issues/79#issuecomment-275445176
I even added a test @ljharb!
PTAL @airbnb/webinfra

Coverage remained the same at 84.857% when pulling adaa9213cfb500dac535dbb233a03dd1e311e050 on maja-fix-input-regression into a454835f9b9f42f43305268f64a60c4325961848 on master.


channel types and other typing problems

Apologies if this veers a little... philosophical.

I can define a channel of bytes:
> c = make(chan byte, 1)
(chan uint8)(0xc420070070)

Having done that, one might think I could do this:
> c <- 10
panic: reflect.Value.Send: value of type int64 is not assignable to type uint8

Instead, the only thing I've been able to figure out is:
> a = make([]byte, 1)
[]byte{0x0}
> a[0] = 0xa
10
> c <- a[0]
<nil>
> <-c
0xa

I thought I might be able to trick it, but no:
> a = make(byte)
0x0
> typeOf(a)
"uint8"
> a = 10
10
> typeOf(a)
"int64"

Basically, this issue is me griping about inconsistencies in Anko's handling of types. You can define typed arrays and channels using make, but you cannot define a scalar or map of a particular type.
Of course, this might go completely against what @mattn intends for the project, and I'll accept that. In that case, though, it feels like all arrays should be []interface and all chans should be channels of interface.

In general, not just this case, I would like all the type conversions to be handled, or at least a much as possible. I have been updating the code to handle more of them but channels is low on the list for me. Right now I am still adding testing and bug fixes for function conversions. After that I need to revisit and refactor slice conversions. Also on my list is adding syntax like make(map int64, string, 3). Lots left to do, welcome help and good PRs. :)
Also note you can define any types you want, including map and chan, outside of the program with DefineType
https://godoc.org/github.com/mattn/anko/vm#Env.DefineType

A possible work around:
a = make([]byte)
a += 10
b = typeOf(a[0])
println(b)
# uint8

Thanks @MichaelS11 for the rapid response. The reason I'm running into these sort of edge cases is that I'm writing documentation, so I'm trying to explore the capabilities of things like channels and maps to get them noted down. At this point, I'm planning to write something to the effect of "be very careful about defining channels of anything except interface, float64, int64, string, or bool".
Regarding your workaround in the second comment, yeah that's what basically what I was doing here:
> a = make([]byte, 1)
[]byte{0x0}
> a[0] = 0xa
10
> c <- a[0]
<nil>
> <-c
0xa

Thanks for your help :)
My bad for retyping your work around, missed it, read too fast.

How about convert to the type of chan?
diff --git a/vm/vmExpr.go b/vm/vmExpr.go
index 46c33ad..c9408cc 100644
--- a/vm/vmExpr.go
+++ b/vm/vmExpr.go
@@ -681,6 +681,10 @@ func invokeExpr(expr ast.Expr, env *Env) (reflect.Value, error) {
 				return nilValue, newError(e.Lhs, err)
 			}
 			if lhs.Kind() == reflect.Chan {
+				lt := lhs.Type().Elem()
+				if rhs.Type().ConvertibleTo(lt) {
+					rhs = rhs.Convert(lt)
+				}
 				lhs.Send(rhs)
 				return nilValue, nil
 			} else if rhs.Kind() == reflect.Chan {

Yeah, something like that. Was thinking of using the new convert function though.

Seems sensible to me.

@MichaelS11 If you don't have opinion to my change above, I'll fix as so.

That works. Was saying you could also see about using convertReflectValueToType instead.
The general idea like:
if lhs.Kind() == reflect.Chan {
// blah
} else {
convertReflectValueToType
// blah
}
Somewhat similar to:
https://github.com/mattn/anko/blob/master/vm/vmExpr.go#L725-L730

@MichaelS11 Could you please send PR? :)

Sure :)

https://github.com/mattn/anko/pull/181

Close this?

@mattn Close this?