JSON-LD Validation Scoping

We need to lay out some clear parameters for what we will be considering a "valid" JSON-LD object, and also possibly make some adjustments with respect to the Psych-DS specification as laid out in the Google Doc.
Here are some of the official requirements of JSON-LD, as found here:

A JSON-LD document MUST be able to express a linked data graph* (elaborated below) []
A JSON-LD document MUST be a valid JSON document [X]
All JSON constructs MUST have semantic meaning in a JSON-LD document: [X]
JSON arrays MUST NOT be interpreted as defining an object ordering. [X]

(There are other bullets in their list, but they are all SHOULDS and MAYs, where we are most interested in the MUSTs
Guidelines for a linked data graph: (in the same doc as above)

Subject, objects and edges all SHOULD be identified with IRIs

^^^Part of my issue with this combination of requirements is that they seem so bottom out with "being valid JSON", because:

Even though a JSON-LD document must be expressable as a linked data graph, the requirements for a linked data graph are all non-normative, all SHOULDs.
The requirement that JSON constructs must have meaning refers to something intentional rather than technical. That is, from what I can tell, it's not saying that all JSON constructs must be linked to some informative IRI, it's saying that the user must not use values that don't mean anything
The requirement that arrays must be interpreted as unordered is a matter of interpretation, not computer validation.

In the world of JSON-LD there are an abundance of SHOULDs and barely any MUSTs. What we have to decide is whether to codify our own set of MUSTs for Psych-DS specific JSON-LD, or to just keep valid JSON format as the only MUST and implement the variety of SHOULDs as warnings.
For instance, we allow users to include non-schema.org keys (or rather, string keys that don't link to any IRI) within their metadata, which is allowed according to strict JSON-LD rules, but recommended against. Here are some questions:

Do we want to require that schema.org context MUST be included, and that the required terms of our spec such as "name" and "variableMeasured" MUST expand to their full schema.org IRIs?
Do we want to allow for expanded, contextless JSON-LDs as valid metadata files?
If we do choose to implement the full gamut of JSON-LD SHOULDs, are we prepared to present those recommendations to the user, at risk of overwhelming them?
Do we want to allow for namespaces other than schema.org in the context?
Do we want the validator to check that JSON-LD IRIs actually point to real web pages? [This has implications for our eventual python version, for which offline functionality is a desideratum]

There are other questions, but this set covers the gist of it. Including some misc. references below, such as Best Practices and the official "JSON-LD grammar":
Here are some "best practices" put forth by W3C:
Best Practice 1: Publish data using developer friendly JSON
Best Practice 2: Use a top-level object
Best Practice 3: Use native values
Best Practice 4: Assume arrays are unordered
Best Practice 5: Use well-known identifiers when describing data
Best Practice 6: Provide one or more types for JSON objects
Best Practice 7: Identify objects with a unique identifier
Best Practice 8: Things not strings
Best Practice 9: Nest referenced inline objects
Best Practice 10: When describing an inverse relationship, use a referenced property
Best Practice 11: External references SHOULD use typed term
Best Practice 12: Ordering of array elements
Best Practice 13: Provide a representation of the entity related by URL
Best Practice 14: Cache JSON-LD Contexts
JSON-LD Grammar
(Interesting point from the above grammar: unlinked keys in the JSON-LD MUST be ignored when processed. We may want to remind users that adding unlinked keys to their metadata does not technically add to its richness, since it will be ignored during any official processing on the web)
additional MUSTs that we can glean from the grammar:

A JSON-LD document MUST be a single node object, a map consisting of only the entries @context and/or @graph, or an array of zero or more node objects.
the keys in objects MUST be unique.
A term MUST NOT equal any of the JSON-LD keywords, other than @type.
When used as the prefix in a Compact IRI, to avoid the potential ambiguity of a prefix being confused with an IRI scheme, terms SHOULD NOT come from the list of URI schemes as defined in [IANA-URI-SCHEMES]. Similarly, to avoid confusion between a Compact IRI and a term, terms SHOULD NOT include a colon (:) and SHOULD be restricted to the form of isegment-nz-nc as defined in [RFC3987].
To avoid forward-compatibility issues, a term SHOULD NOT start with an @ character followed exclusively by one or more ALPHA characters (see [RFC5234]) as future versions of JSON-LD may introduce additional keywords. Furthermore, the term MUST NOT be an empty string ("") as not all programming languages are able to handle empty JSON keys.
all of the aspects of context definitions are MUSTS
all of the expanded term definition requirements apply as MUSTs

note:

This refers to the eventual deprecation of non-IRI keys in JSON-LD

After doing a deeper dive into the jsonld.js package, I can see that it does produce error messages that correspond directly to a lot of the MUSTs from the JSON-LD Grammar. These mostly seem to revolve around restricted usages for the various "@" keywords.
This is great, because it means we can offload a lot of this fine-grained syntactic validation of json-ld objects to the official package itself, funneling its error messages into our app's validation "issues" that get presented to the user. One nice thing about these error cases is that they only really arise when you begin to use some of JSON-LDs more complex features, so there's not as much of a worry of these checks being prohibitive to beginners.
There's another category of JSON-LD MUSTs that result in ignored content rather than an error message. For instance, in the JSON-LD playground, using a key that resolves to a string instead of an IRI results in that key being dropped.


Allow resolving promise with stream

Request-Promise is not designed to be used with streams. However, Request-Promise could resolve the promise not with the response but with the stream object. Then the user could do some piping further down the promise chain.
See https://github.com/request/request/issues/1990 which gave me the idea.
At community: +1s?

This wouldn't be possible currently in conjunction with the simple option because Request-Promise would need to register .on('response', ... ) to get and check the statusCode. But then all .pipe(...) calls need to follow synchronously - which is not the case due to the async hop of the promise. (See the linked issue.)

It turns out to be possible after all by pausing the stream during the async step:
new Promise(function(resolve, reject) {
    request.get('http://affenbits.com/')
        .on('response', function(response) {
            response.pause();
            resolve(response);
        });
}).then(function(response) {
    response.pipe(process.stdout);
});

That's good, you can probably use additional pause option to enable that behavior? Also not sure if .on vs .one would make any difference in this case.

A pause option would be neat. Although the solution above works well without the option, in the future the option could give request the power to pause the stream "at the right time". Who knows, maybe some cases come up where the response event it not "the right time".

+1

wip / sample: https://gist.github.com/forivall/6b3f3718b5684e9ea8daa5a4dcd855a6
I'll turn that into a pull request if nobody else is working on this.

Hi @forivall , a PR would be really awesome!
You'll need to add the changes to request-promise-core. This core lib is used by request-promise, request-promise-native, and request-promise-any. But anyhow, the change won't require specific code for any one of those libs...

@forivall Thank you for your work. Eagerly awaiting your pull request!

+1

+1

+1

+1

+1

What's the status of this issue?

+1

+1

+1

+1

I've made a PR for this feature at request/promise-core#16!
To try it yourself:
npm install request-promise@"botgram/request-promise#feature-pause"

Hmm, could someone review the PR? It'd be great to have this feature

+1

This seems like it will become one of those viral tweets, soon. +1

@ps2goat request  module (and i assume this module) has been deprecated no more new features will be added.  https://github.com/request/request/issues/3142


ci: Add signing of builds

Signed swupdate artifacts
Secure boot
Add netboot image

Breaking change for Jenkins. Blocked by GitLab

Back to draft: We mustn't sign maintenance fw.

merge after https://github.com/iris-GmbH/meta-iris-base/pull/125


Added a graphical user interface

I created this model-view-controller structure for a graphical user interface.

Currently this supports the 'input/output' sections and the actual conversion.
Questions:

I also kept here some of the original functions. Is there a good way to preserve the previous drag & drop functionality, or at least drag & drop the input/output files instead of browsing for them?
Are there any other valuable settings that could be available?

This also supports variable names now.


[stable/kube-ops-view] add loadBalancerIP value option to service

Signed-off-by: Dennis Zhang<EMAIL_ADDRESS>
Is this a new chart
No it is not.

NOTE: We're experiencing a high volume of PRs to this repo and reviews will be delayed. Please host your own chart repository and submit your repository to the Helm Hub instead of this repo to make them discoverable to the community. Here is how to submit new chart repositories to the Helm Hub.

What this PR does / why we need it:
It adds loadBalancerIP as a values option to kube-ops-view service template.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes N/A

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[x] Chart Version bumped
[x] Variables are documented in the README.md
[x] Title of the PR starts with chart name (e.g. [stable/mychartname])

/assign @cpanato


feat: enable builds for CentOS 8

CentOS was released a couple of months ago, and it is one of the
supported distributions in GCE, we should test that the code works
there. Maybe it can help us remove the builds for CentOS:7 someday.
Fixes #29

This change is

Sorry about the unrelated changes, but most of them were automatically generated. Easier to include them here than not.


[BUG] Deepspeed launcher not picking up virtualenv --system-site-packages

Describe the bug
deepspeed executable does not pick up packages installed in a virtualenv --system-site-packages even when regular python calls does. It only works if deepspeed is in the same virtualenvironment.
To Reproduce
Steps to reproduce the behavior:

Simple inference script to reproduce

import sys
from dummy_pip_package.main import dummy
if __name__ == '__main__':
    sys.exit(dummy())

(this is a cleaned-up version of dummy-pip-package)
4. What packages are required and their versions```
pip install deepspeed virtualenv
virtualenv --system-site-packages dummyvenv
source dummyvenv/bin/activate
pip install dummy-pip-package

How to run the script

deepspeed dummyvenv/bin/dummy-pip-package

...Expected behaviorA clear and concise description of what you expected to happen.
Not crashing, instead printing out one line of OK per launched process.

ds_report output
Please run ds_report to give us details about your setup.
[2024-10-24 12:14:08,537] [WARNING] [real_accelerator.py:174:get_accelerator] Setting accelerator to CPU. If you have GPU or other accelerator, we were unable to detect it.
[2024-10-24 12:14:08,544] [INFO] [real_accelerator.py:219:get_accelerator] Setting ds_accelerator to cpu (auto detect)
--------------------------------------------------
DeepSpeed C++/CUDA extension op report
--------------------------------------------------
NOTE: Ops not installed will be just-in-time (JIT) compiled at
      runtime if needed. Op compatibility means that your system
      meet the required dependencies to JIT install the op.
--------------------------------------------------
JIT compiled ops requires ninja
ninja .................. [OKAY]
--------------------------------------------------
op name ................ installed .. compatible
--------------------------------------------------
deepspeed_not_implemented  [NO] ....... [OKAY]
deepspeed_ccl_comm ..... [NO] ....... [OKAY]
deepspeed_shm_comm ..... [NO] ....... [OKAY]
cpu_adam ............... [NO] ....... [OKAY]
fused_adam ............. [NO] ....... [OKAY]
--------------------------------------------------
DeepSpeed general environment info:
torch install path ............... ['/usr/local/lib/python3.10/dist-packages/torch']
torch version .................... 2.4.0a0+f70bd71a48.nv24.06
deepspeed install path ........... ['/usr/local/lib/python3.10/dist-packages/deepspeed']
deepspeed info ................... 0.15.2, unknown, unknown
deepspeed wheel compiled w. ...... torch 2.4
shared memory (/dev/shm) size .... 125.51 GB

Screenshots
If applicable, add screenshots to help explain your problem.
System info (please complete the following information):

OS: RockyLinux 8 and Ubuntu something (inside a container)
GPU count and types 4xA100, 2xT4, CPU-only
(if applicable) what DeepSpeed-MII version are you using
(if applicable) Hugging Face Transformers/Accelerate/etc. versions
Python version 3.10.12
Any other relevant info about your setup: first noticed with DeepSpeed installed as Lmod module (https://github.com/easybuilders/easybuild-easyconfigs/pull/21438) but confirmed that it also shows up when installing DeepSpeed on top-of NGC PyTorch container

Docker context
Are you using a specific docker image that you can share?
Apptainer
Bootstrap: docker
From: nvcr.io/nvidia/pytorch:24.06-py3

%post
    pip install virtualenv deepspeed

and then the virtualenv outside the container (or inside, doesn't matter)
Additional context
Add any other context about the problem here.
This would block most usage of DeepSpeed for any user on our cluster needing something outside the system installed packages. So not critical, but certainly annoying.

Originally I thought it might have to do with some missing environment variable in EXPORT_ENVS https://github.com/microsoft/DeepSpeed/blob/master/deepspeed/launcher/runner.py#L37 but not even adding the empty string to export the full environment solved the issue.
Any ideas for where to look would be helpful.

Hello @VRehnberg ,
This issue seems interesting. I think as a workaround, installing DeepSpeed inside the virtualenv solves the issue. Another idea might be tweaking the launcher to include system site-packages by adjusting environment variables like PYTHONPATH. Maybe one of these approaches could help make DeepSpeed more flexible with virtual environments?
I'm happy to help test any fixes or provide more details if needed :)

I think as a workaround, installing DeepSpeed inside the virtualenv solves the issue.
Yes, but then we can't provide DeepSpeed centrally and each user will have to have their own installation.

Another idea might be tweaking the launcher to include system site-packages by adjusting environment variables like PYTHONPATH.
Hmm, yes there is something in this. This is a possible work-around:

PYTHONPATH=$(python -c 'import sys; print(":".join(sys.path))') deepspeed dummyvenv/bin/dummy-pip-package

don't know why this is needed, why is sys.path is different when launching Python via deepspeed compared to directly with python.
I will try to look into this.

Ah, it was quite obvious in the end. The shebang in the deepspeed executable uses an absolute path to Python. It should be using #!/usr/bin/env python. Changing that or using
python $(which deepspeed) my_script.py

works.
Now I just need to figure out what to change in the build process.

So the issue is (probably) coming from https://github.com/pypa/distutils/blob/main/distutils/command/build_scripts.py#L111-L117
Not sure what this means for DeepSpeed. Not seeing an easy way to patch this from DeepSpeed's side and there is a stable work-around. So if you feel like closing the issue I'd consider that acceptable.

Hi @VRehnberg - thanks for reporting this issue, I'll repro and take a look from our side.
Thanks @VishalGawade1 for your suggestions as well, I agree with @VRehnberg's thoughts, but it would be good to not need to work around this if we can

@VRehnberg - I've now read over the whole thread, everything you mentioned makes sense to me.  Though I'm not sure I follow your suggestions on what would need to be changed on the DeepSpeed side, could you elaborate more on that, even if it isn't easy?

I didn't have anything specific in mind. Two things I can think of worth trying:

change to entry point console_scripts and see if that is handled correctly (I doubt it, bur worth trying)
use a post install hook to modify to revert the changed shebang
wrap the scripts as shell scripts

What should be done is file an issue with distutils or setuptools to make this handled upstream in the future.


no space left on device?

Hi all, I'm getting a "no space left on device" when copying to /tmp error message.  Any thoughts on why? When I "df" the /tmp directory is only using 1% of its capacity.

What size files are you copying and which remote storage system. Also which OS?

Copying from a local drive mounted drive to Backblaze Storage via Linux

Currently rclone makes a temporary copy of the file it is copying before uploading to B2.  This is due to the way the b2 API works.  I'm hoping to turn that into reading the file twice, but that requires some re-architecting of rclone's internals.
There is a note about this on the b2 page: http://rclone.org/b2/
You can override which directory rclone uses to make temp file by setting the TMPDIR environment variable.
I'm going to turn this ticket into one to remind me to fix this properly!

Cool will try out the TMPDIR environment variable.  Not sure why it's having issues copying though when the directory has space available.

Would be possible if #282 is implemented. I might give it a try.

@klauspost that would be fantastic!

The fix for this will be in the next release!

Here is a beta for you to try: http://pub.rclone.org/v1.27-23-ga3b4c8aβ/


pkg/ciliumidentity: Add ciliumidentity to ControlPlane module

This allows enabling the Cilium Identity Cell to manage CIDs. CiliumIdentity controller manages Cilium Identity API objects. It creates and updates Cilium Identities (CIDs) based on CID, Pod, Namespace and CES events.
The cell should be disabled by default, see https://github.com/cilium/cilium/pull/34193.
This one can be merged after the agent implementation is merged though.
Related CFP https://github.com/cilium/cilium/issues/27752
CiliumIdentity controller manages Cilium Identity API objects. It creates and updates Cilium Identities (CIDs) based on CID, Pod, Namespace and CES events.

/cc @pippolo84 @dlapcevic

/test

/test

/test

This one can be merged after the agent implementation is merged though.

Is this true?
Can't we merge it anyway since EnableOperatorManageCIDs is disabled by default, and the cell (registerController) will just exit?

Yes indeed, just wanted to point out that there is no rush in having this merged as there won't be any benefits until we have the agent changes in. I'll update the wording.

/test

/test

I think the CI failures root cause is the missing cell.Config from https://github.com/cilium/cilium/pull/34193. I've addressed that in https://github.com/cilium/cilium/pull/34667, PTAL.
In the meantime, I'll move this back into draft while we wait for the other one to be merged.

/test

@ovidiutirla The docs failure looks legit.

Marked field as hidden for now, and created https://github.com/cilium/cilium/issues/27752.
@dlapcevic I prefer to not expose this until the agent changes are implemented to reduce user confusion.

/test

Marked field as hidden for now, and created #27752. @dlapcevic I prefer to not expose this until the agent changes are implemented to reduce user confusion.

I agree. Thanks

/ci-aks

/ci-ginkgo

/ci-ginkgo

/ci-ginkgo

rebased on main

/test

/ci-awscni


Improve debug libp2p documentation

There were several libp2p users having trouble with "silent" errors, like silent errors dialling incorrect bootstrap addresses (like: ws multiaddr pointing to a tcp port).
Users can enable debug mode by:

Browser: in console localStorage.debug = 'libp2p:*
Node: run node with DEBUG=libp2p:*

We should document that we use the debug module and that it can be used for debugging purposes for libp2p.
My suggestion is to create a FAQ document where we will be adding the most common questions libp2p users might have, and include there "How to debug".
@jacobheun what do you think?

Also, should we document the debug strings? Perhaps we should have some structure on it like: libp2p:transport:...

@vasco-santos yes I think this would be helpful, and including some common debug string combos could be really helpful. Additionally, we may want to add the debug strings of each module to their respective readme/api docs to make it easier for folks to find specific ones.
Some example combo strings I use:

All of libp2p minus noise and mplex (they're busy logs): DEBUG=libp2p*,-libp2p:mplex*,-libp2p:noise*
Only errors: DEBUG=*:error

I wrote a small proposal so that we can iterate on this
Format
We should have a more rigid format for libp2p modules, which can enable logging easily for each libp2p components.
We can start by a standard where each interface exports its debug string (its name per https://github.com/libp2p/js-libp2p-interfaces/tree/master/src). These exported strings should be concatenated with the implementation naming. As an example: libp2p transport interface should export a debugString = ‘libp2p:transport”, and its implementations would create their debug string as ${interface.debugString}-tcp.
We can even go a step forward and try to also bind libp2p core components with the logic aboce whenever possible. As an example, we can have components like the connectionManager and transportManager to have debug strings in the interface namespace scope: ${interface.debugString}-manager or ${interface.debugString}-core-manager . I am not yet sold to this idea, but if we find a good pattern this could be considered.
Also, we can leverage this opportunity to also tidy up the usage of module.tag vs Transport[Symbol.toStringTag]. We should uniform every thing under an exported Tag (transports need to be updated, discovery already do this). This exported Tag should be equal to the logging string part that represents the log, in order to keep everything consistent.
This will be a “breaking change” in the logs string and in the transports where people rely on the Transport[Symbol.toStringTag]. However, if we keep the same string as Transport[Symbol.toStringTag] in the log+tag, this won’t be problematic by itself. We should do the breaking change release anyway, just for the sake of the log string.
Finally, the README each module should have a debug section with its underlying debug strings, aiming to enable users to do more custom logging without the need to look into the codebase/all logs.
FAQ.md
In the context of the FAQ, I suggest we create “areas” within the document, starting by the “Debug” area.  The 3 main questions seem to be:

How can I debug libp2p?

Guidelines to debug module + Node.js / Browser examples

How is libp2p debug structured?

Explain how libp2p debug strings are structured, similar to the above proposal

What are the most common libp2p debug queries?

@jacobheun 's combo strings in https://github.com/libp2p/js-libp2p/issues/762#issuecomment-704345185

Let me know your thoughts

I wrote a small proposal so that we can iterate on this
Format
We should have a more rigid format for libp2p modules, which can enable logging easily for each libp2p components.
We can start by a standard where each interface exports its debug string (its name per https://github.com/libp2p/js-libp2p-interfaces/tree/master/src). These exported strings should be concatenated with the implementation naming. As an example: libp2p transport interface should export a debugString = ‘libp2p:transport”, and its implementations would create their debug string as ${interface.debugString}-tcp.
We can even go a step forward and try to also bind libp2p core components with the logic aboce whenever possible. As an example, we can have components like the connectionManager and transportManager to have debug strings in the interface namespace scope: ${interface.debugString}-manager or ${interface.debugString}-core-manager . I am not yet sold to this idea, but if we find a good pattern this could be considered.
Also, we can leverage this opportunity to also tidy up the usage of module.tag vs Transport[Symbol.toStringTag]. We should uniform every thing under an exported Tag (transports need to be updated, discovery already do this). This exported Tag should be equal to the logging string part that represents the log, in order to keep everything consistent.
This will be a “breaking change” in the logs string and in the transports where people rely on the Transport[Symbol.toStringTag]. However, if we keep the same string as Transport[Symbol.toStringTag] in the log+tag, this won’t be problematic by itself. We should do the breaking change release anyway, just for the sake of the log string.
Finally, the README each module should have a debug section with its underlying debug strings, aiming to enable users to do more custom logging without the need to look into the codebase/all logs.
FAQ.md
In the context of the FAQ, I suggest we create “areas” within the document, starting by the “Debug” area.  The 3 main questions seem to be:

How can I debug libp2p?

Guidelines to debug module + Node.js / Browser examples

How is libp2p debug structured?

Explain how libp2p debug strings are structured, similar to the above proposal

What are the most common libp2p debug queries?

@jacobheun 's combo strings in https://github.com/libp2p/js-libp2p/issues/762#issuecomment-704345185

Let me know your thoughts

Documentation for logging in libp2p would be super helpful!
What I figured out after a bit of searching was that I could also use the @libp2p/logger module to configure logging at runtime:
import * as libp2pLogger from '@libp2p/logger';

libp2pLogger.enable(
    'libp2p:circuit:error, libp2p:bootstrap:error, libp2p:upgrader:error'
);

Closing as the documentation explains how to debug


onExit callback metadata request_id is allways null

request_id is always null onExit callback, is this expected?

this seems to be expected behavior. the onEvent=EXIT callback does have a request_id if you need one though


[FSR-07M] Inexplicable Conditional Assignment

FSR-07M: Inexplicable Conditional Assignment

Type
Severity
Location

Logical Fault

FeeSplitter.sol:L236-L238

Description:
The FeeSplitter::updateReceiver function will overwrite the feeReceivers split value conditionally which is incorrect as an adjustment should always result in the feeReceivers entry being mutated.
Impact:
An incorrect sum will result in FeeSplitter::distribute operations failing which we consider a major-severity vulnerability.
Example:
function updateReceiver(address receiver, uint96 split) external onlyOwner {
    FeeSplitterStorage storage $ = _getFeeSplitterStorage();
    uint256 pos = $.receiverPos[receiver];
    if (pos == 0) {
        revert ReceiverNotFound(receiver);
    }
    (, uint96 currentSplit) = _unsafeFeeReceiverAccess($.feeReceivers, pos - 1);
    uint256 splitTotal;
    unchecked {
        splitTotal = $.splitTotal - currentSplit;
    }
    _validateSplitValue(split, splitTotal);
    unchecked {
        $.splitTotal = splitTotal + split;
    }
    uint256 receiversLength = $.feeReceivers.length;
    if (pos != receiversLength) {
        $.feeReceivers[pos - 1].split = split;
    }
}

Recommendation:
We advise the conditional to be omitted, ensuring that the splitTotal always reflects the cumulative split values of each fee receiver.

That is absolutely correct. I have an idea how that made it there, not that it matters now, but yes, I'll remove it.


EXC_BAD_ACCESS in SwiftSweeper

Hi,
recently I started often getting this crash in line 224 of SwiftSweeper pretty randomly, don't know what triggers it.
if let obj = $0.pointee {                                     SwiftSweeper.current?.sweepInstance(obj)                                 }
It was happening with Xcode 13.3 and 13.3.1 now, using HotReloading Swift package v4.3.15.
Do you have any suggetions what to try and how to investigate?

Hi, add an environment variable INJECTION_SWEEP_DETAIL to show objects as they are swept. The last class name printed is where the crash happens, which you should be able to exclude from the sweep using the environment variable INJECTION_SWEEP_EXCLUDE which is a regular expression.

Nice, thanks!
It seems to be working, UITextChecker was the problem and with excluding it, no more crashes for now.
Maybe you should consider adding this to troubleshooting docs.

It's mentioned in the README.md


discussion - set up docker for python scripts and automate docker build

Make separate folders for them, and make a docker file in them
example docker file:

# Use an official Python runtime as a parent image
FROM python:3.9-slim

# Set the working directory in the container
WORKDIR /app

# Copy the current directory contents into the container at /app
COPY . /app

# Install any needed packages specified in requirements.txt
RUN pip install --no-cache-dir -r requirements.txt

# Make port 80 available to the world outside this container
EXPOSE 80

# Define environment variable
ENV NAME World

# Run app.py when the container launches
CMD ["python", "app.py"]

Create a GitHub Actions Workflow
example docker-image.yml:

name: Build and Push Docker Image

on:
  push:
    branches:
      - main

jobs:
  build:
    runs-on: ubuntu-latest

    steps:
    - name: Checkout code
      uses: actions/checkout@v2

    - name: Set up Docker Buildx
      uses: docker/setup-buildx-action@v2

    - name: Login to Docker Hub
      uses: docker/login-action@v2
      with:
        username: ${{ secrets.DOCKER_USERNAME }}
        password: ${{ secrets.DOCKER_PASSWORD }}

    - name: Build and push Docker image
      uses: docker/build-push-action@v4
      with:
        context: .
        file: ./Dockerfile
        push: true
        tags: ${{ secrets.DOCKER_USERNAME }}/my-python-app:latest

Set Up Secrets
Docker Hub Authentication: To push the Docker image to Docker Hub, you need to set up secrets for your Docker Hub username and password. Go to your GitHub repository, click on Settings, then Secrets and variables, and add the following secrets:
DOCKER_USERNAME: Your Docker Hub username.
DOCKER_PASSWORD: Your Docker Hub password.

example docker file for a dual container for both erlang and python.
FROM erlang:24

# Install Python
RUN apt-get update && \
    apt-get install -y python3 python3-pip && \
    apt-get clean

# Set up working directory
WORKDIR /app

# Copy Erlang and Python code into the image
COPY . /app

# Set environment variables (optional)
ENV PYTHONPATH=/app/python_scripts

# Install Python dependencies (if any)
RUN pip3 install -r requirements.txt

# Expose necessary ports (if your Erlang app uses them)
EXPOSE 8080

# Define the command to run your Erlang application
CMD ["erl", "-noshell", "-s", "your_erlang_module", "start", "-s", "init", "stop"]


Test new tap-arc

⚠ Don't merge -- wait for tap-arc 1.0.0
I'm testing Windows GitHub Action with tap-arc

Looks like the issue is a discrepancy in counts. We get 2086 tests instead of the planned 2375 🤨

Thanks for being my test subject, inventory.
tap-arc is going 1.0 with Windoz fixes


Wrong behavior when press backspace from paragraph below the table

Seem to occur on slate table example as well. Will closed this issue and open the new one in slate repo.


Improve UI

I would like to take a shot at this, as one of my first contributions ever..
Is there a style guide in place yet? Or any Wireframes?

Nope you're free to explore


[BEAM-7372] cleanup codes for py2 compatibility from apache_beam/examples/snippets/.py and apache_beam/examples/.py

cleanup following codes;

usage of future package
usage of past package
unnecessary builtin import
workarounds for py2

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[x] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

R: @tvalentyn

Failed check may be issue in GRPC

LGTM, thank you!

@tvalentyn OK, I'll have a look.


Remove git dependency during build

Currently a proper build requires git to get commit hash. But I would like to exclude .git folder from our docker build while stilling having git commit in version. Should offer an environment variable to specify the git commit and fallback to use git rev-parse.
https://github.com/paritytech/substrate/blob/1e045f218db16027197dc11ac04220896321260f/utils/build-script-utils/src/version.rs#L23-L25

Nothing of this is backed into substrate. We use this to generate the SUBSTRATE_CLI_IMPL_VERSION build env variable that itself is used by the node example implementation to expose this to the cli interface. You can just write your own build script that does whatever you want :)


adding approvers to owners file

Adding approvers to owners file.
@rhatdan feel free to add more or let me know I can add them with the same PR.
Signed-off-by: Navid Yaghoobi<EMAIL_ADDRESS>

LGTM

@umohnani8 PTAL


Add test for datum round-trip corrupts datum bytes

Details:
https://github.com/input-output-hk/cardano-db-sync/issues/1214

Done - https://github.com/input-output-hk/cardano-node-tests/blob/f250e2ef70c9ff8ee6193c341339b2b2bcab930d/cardano_node_tests/tests/test_plutus_v2_spend_raw.py#L353-L424


Add example of Spline Flow in JAX

Description
Added notebook port of JAX Flow trained on MNIST from example given at https://github.com/deepmind/distrax/blob/master/examples/flow.py
Colab link
https://colab.research.google.com/github/nsanghi/probml-notebooks/blob/add_mnist_spline_flow_jax/notebooks/flow_spline_mnist_jax.ipynb
Issue
Issue
make some JAX normalizing flows demos #672
Steps

[X] Updated the code from distrax example folder to notebook following the PEP 8 guidelines.
[X] Followed the CONTRIBUTING.md guidelines.

Figures
https://gist.github.com/nsanghi/ce9e7269187a525659ba51009910f499
Checklist:

[X] Performed a self-review of the code
[X] Tested on Google Colab.

Potential problems/Important remarks
Even after 100K steps, the sample is kind of ok and not very high quality. I tried with different hyper parameters but it did not improve a lot. So Left the original settings and just trained for 100K steps instead of 10K steps

This looks great - I will add to the book. However please add pointer to the original distrax code on which this is based.

Thanks for the feedback. Made the suggested changes.


Add IPv4 prefix set integration test

policytest is adapted from local_test's policy_test.go and is suitable for being used in Ondatra tests instead of locally.

Previous PR: https://github.com/openconfig/lemming/pull/253

What's the long term plan for this? It seems like there's a lot duplication (code and test behavior) of the local test.

What's the long term plan for this? It seems like there's a lot duplication (code and test behavior) of the local test.

I agree there is a lot of duplication. I think an Ondatra binding or generics/interfaces may be the solution to deal with the different Device/Port/ygnmi API type differences, as otherwise the two are identical.
My judgement is that local_tests will be useful as a lightweight way to test and debug BGP policy development, so once the Ondatra version of the test is stable, I'll look at an Ondatra bind for local lemmings.


Arianrhod2

Changes / Comments
Bugfix : Change some attribute references from _attribute to _sum.
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[o] Does the pull request title have the sheet name(s)? Include each sheet name.
[o] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Hi @tifereth there seems to be a merge conflict in your "Arianrhod2/Arianrhod2.html" file. Please resolve that conflict and we can get these merged in.


New widget config screens

It's all working now and the only remaining things is just minor design tweaks, which will be merged form @ijl20 branch pull request

I haven't looked at every line of code, but I think it's OK to merge this to master since it's a massive step in the right direction and it shouldn't be able to break anything.


Feature - Kingdom of Miscellania notification message

I dreamt of an additional feature for the KingdomPlugin several months and finally decided to implement it. Upon login, if the user is managing the kingdom, their coffer and favor will be sent as a chat notification. The values are calculated using the last known coffer and favor values the same way the server calculates them.

Let me know if I should create a corresponding issue for this feature and amend this PR to close it.
closes #10939
Brandt

Let me know if there's anything that needs to be changed.

Happy to make any requested changes for approval.

Let me know if anything needs to be changed.

Thanks for re-reviewing. Suggested changes have been committed.

Thanks for re-reviewing. Suggested changes have been committed.

LGTM. Thanks for keeping up with this PR all this time!

I never lost hope!

LGTM. Thanks for keeping up with this PR all this time!

I never lost hope!

Regrettably, I no longer have a membership. 😔 😔 Would someone be so kind as to test this? Simply visit Miscellania, enable the notification message, and relog. Ty 😗

The changes look fine to me. I'll put some money in miscellania and play with this feature enabled for a few days and see how it looks.

This doesn't seem to be working currently. I turned on notifications with a coffer threshold of 0 and a favor threshold of 100, but got no notification a day and a half later after depositing some money into my kingdom coffers. I'll look at this more later to see if I can't figure out why it's not working.

Thanks for testing. I'll get a membership and test this out.

I've fixed bugs relating to the new config functions.
I've simulated the passage of time by calling the following function with different values and logging on and verifying the message is sent with approximations.
setLastChanged(Instant.ofEpochSecond(1613522615));
setCoffer(1_000_000);
setFavor(127);

I renamed everything from favor to approval and changed the guard to ||

Just here to say happy birthday to this PR. You would have been one year old today. Merged before your time.


[INS-2014] Add Move/Copy to option in gRPC request settings

Closes INS-2014
Closes INS-267

This PR adds move/copy to option to gRPC request settings.
It also handles duplicating the related proto files of the gRPC requests being moved/copied and assigning those duplicates as the related protofiles in the new workspace.
Tested

Users can copy and move a single gRPC request to another collection/doc
A user can update the new proto file associated with the new moved/copied request independently of the original gRPC request

Side-effects

Copying and moving a requestGroup doesn't work properly yet, the duplicate gRPC requests still point to the original protoFileId ⚠
This adds a new side-effect - if we duplicate a grpc request within the same collection, this will be duplicating proto files instead of referencing the existing one in the collection ⚠

Closing this one for now due to the side-effects:

Copying and moving a requestGroup doesn't work properly yet, the duplicate gRPC requests still point to the original protoFileId ⚠

We can revisit this at some point when we look at gRPC again


[Extensions] Getting Started panel and Catalog modal should be dichotomous

Current Behavior

Desired Behavior

Screenshots/Logs

Environment

Host OS: Mac Linux Windows
Meshery Server Version: stable-v
Meshery Extension Version: stable-v
Meshery Client Version: stable-v
Platform: Docker Kubernetes

Contributor Guides and Handbook

📚 Meshery Build and Release Strategy
🎨 UI Design For Meshery Extensions Figma in Figma (open invite)
📚 Meshery Extensibility Providers
⌨ Meshery API Docs
🙋🏾🙋🏼 Questions: Discussion Forum and Community Slack

Fixed.


I got an error. It doesn't show video in android and it shows black screen

<Video ref="myvideo"
source={{uri:"http://clips.vorwaerts-gmbh.de/big_buck_bunny.mp4"}}
style={{width:width,height:180, top: 0, left: 0, bottom: 0, right: 0,}}
rate={1.0}                              // 0 is paused, 1 is normal.
volume={1.0}
muted={true}
paused={true}
resizeMode="cover"
repeat={true}
playInBackground={false}
playWhenInactive={false}
ignoreSilentSwitch={"ignore"}
progressUpdateInterval={250.0}
onLoadStart={this.loadStart}
onLoad={this.setDuration}
onProgress={this.setTime}
onEnd={this.onEnd}
onError={this.videoError}
onBuffer={this.onBuffer}
onTimedMetadata={this.onTimedMetadata}
/>

Having the same issue
"react-native-video": "3.2.1"

I experienced the same issue.
The problem and the solution for me was that the URL to the video must be via https, it's not enough that the server redirects to https, the initial call from within the app must be https.

我遇到了同样的问题。
对我来说问题和解决方案是视频的URL必须是通过https，服务器重定向到https是不够的，应用程序内的初始调用必须是https。

I have resolved the problem with the new video version of NPM

I used to run into stucked black screen all the time. The most strange one I experience is https://github.com/react-native-community/react-native-video/issues/1538
My feeling is this project manage the native video player instances very poorly (especially on Android). The project frequently mess things up when you have multiple native video player instances. In our project, we had to do a lot of difficult and hard things to ensure that we only have one instance of a screen that have the  tag, thus only one native video player instance, then it won't stuck.

@gsunsnackv  did you manage to get it to work?

@Balasnest Our workaround is to have one page that never get unmounted but only hidden. That way we got one instance of whatever native player this project is using. That way it does not stuck. But it is really bad

Please test with 4.4.4.
If still not works I will reopen the issue


WIP: Define schema with cue

TODO:

[ ] Discuss folder structure
[ ] Documentation, examples and descriptions
[ ] Add indicator
[ ] Add objectives

Closes: #20
Signed-off-by: Michael Gasch<EMAIL_ADDRESS>

@ian-bartholomew first proposal for discussion. There's couple of areas where the spec is a bit fuzzy/unclear to me (and I made some minor adjustments based on some other comments).
On indicator and objectives I had a couple of questions thus did not include them in the spec yet.

indicator optional, represents the Service Level Indicator (SLI). Currently this only supports one Metric, thresholdMetric, with ratioMetric supported in the objectives stanza.

Why do we need to spread the different metrics over various spec parts, e.g. one in indicator, one in objectives?
This also leads to some tough validation requirements e.g.

If thresholdMetric has been defined, only one Threshold can be defined. However if using ratioMetric then any number of Thresholds can be defined.

and

indicator.ratioMetric Metric {Good, Total}, if ratioMetric is defined then thresholdMetric should not be set in indicator

@ian-bartholomew first proposal for discussion. There's couple of areas where the spec is a bit fuzzy/unclear to me (and I made some minor adjustments based on some other comments).
On indicator and objectives I had a couple of questions thus did not include them in the spec yet.

indicator optional, represents the Service Level Indicator (SLI). Currently this only supports one Metric, thresholdMetric, with ratioMetric supported in the objectives stanza.

Why do we need to spread the different metrics over various spec parts, e.g. one in indicator, one in objectives?
This also leads to some tough validation requirements e.g.

If thresholdMetric has been defined, only one Threshold can be defined. However if using ratioMetric then any number of Thresholds can be defined.

and

indicator.ratioMetric Metric {Good, Total}, if ratioMetric is defined then thresholdMetric should not be set in indicator

Agreed as I mentioned this here: https://github.com/OpenSLO/OpenSLO/issues/29
Whats the best mechanism for suggesting the recommended change to the spec?

Why do we need to spread the different metrics over various spec parts, e.g. one in indicator, one in objectives?

@embano1 this has come up a few times, and I agree, it leads to some issues, and should get addressed.  This is an artifact of us open sourcing our internal spec
@its02003 I think a good way of doing is it is a PR here with changes in the spec, and then pinging the OpenSLO Slack channel where we can discuss it.
Thanks both!


Rancher docker upgrade lost settings

What kind of request is this (question/bug/enhancement/feature request):
Question or bug
Steps to reproduce (least amount of steps as possible):
Upgrade rancher to latest version using watch tower.
Result:
All of my cluster settings and longhorn volume settings are gone. Actually, the nodes are still running so for now and everything looks OK, only that the rancher docker that was managing the cluster is no longer doing so.
So, first thing, is there any way I can re-connect to the existing Rancher cluster so it can be managed as it was before?
Secondly, if not, if I start again, can I somehow use my existing longhorn volumes?
Finally and maybe most importantly, I was persisting "/var/lib/rancher" and also "/var/log/auditlog" but my existing cluster data still seems to have been wiped. Did something go wrong here or is there something I missed in terms of folders/data to persist outside the rancher container?
Environment information
Latest version from docker hub in HA on bare metal

For future reference, please supply the exact commands used to run and upgrade Rancher. Did the persisted directories contain the data before and after the upgrade? Did you get prompted for setting a password and server-url as it were a fresh install?
Let me know if you can still reproduce this.


healthy food predictor

💥 Proposal
a model used to predict whether or not the food that we are going to consume is healthy or not. on the basis of the sugar, fat, proteins, mineral levels
i am a gssoc'23 contributor could you please assign me this issue

@barkhaaroraa Please provide the dataset and also mention the model which you will be using. All the best :)

so i'll be using https://www.kaggle.com/datasets/trolukovich/nutritional-values-for-common-foods-and-products dataset and logical regression model

@barkhaaroraa cool

you can go ahead! We are assigning you 21 days for this project, after which it will be assigned to someone else if not completed. All the best!  Name the file as: algorithm_dataset.ipynb and link it in the readme of the labeled directory as algorithm - dataset.


Tachiyomi to Paperback Backup Converter

This pull request add a Tachiyomi to Paperback Backup Converter page to the website.
The page use a Vue component BackupConverter which allow the user to upload a backup file and download the converted backup.
The conversion is done by Vibrant tool: Tachiyomi to Paperback Backup Converter.
Website side of the tool proccess
BackupConverter component renders an upload component.
When the user add a file, the method sendRequest is called. This method send a POST request to the conversion server which return a converted backup which is displayed in a dialog windows. If an error occur, an alert is shown with the error content.

The tool is available here: https://deploy-preview-65--paperbackios.netlify.app/tools/backup-converter/
TODO

[x] Put the tool in a better place. /tools/backup-converter?
[x] Fix dark mode style
[ ] Remove extra logging and open dialog button
[x] Improve small screen layout
[x] Make the download button work on an iOS device
[x] Insert the backup in the downloaded file...

Potential issue
Timeout should not happen as the converter tool was modified to return an error when given an incompatible file.
A timeout lead to the error Uncaught (in promise) TypeError: can't access property "data", error.response is undefined

Thanks Vibrant. The Tool menu was added in 7cd1698.
We are still experimenting with the table and the dark theme. After that, it will be ready!

The tool should now work on iOS and iPadOS. This pull request should be ready for review.


LocalTimestamp field is empty

Perhaps the control should populate the LocalTimestamp field when sending activities. The field is designed to be supplied by the client and can contain timezone/offset information if available.

Hi,
Do we have any update on this issue. I am using webchat and i want to post the localtimestamp in reply of a message.
Thanks,
Kalyani

We can try out the time zone library at https://www.npmjs.com/package/time-zone
.

Note that we have localTimezone in addition to localTimestamp as well now


corrected display problems in MoveSelectedTool and LivePreviewManager

changing ctx.Operator before a call to layer.Draw(...) has no effect because the BlendMode is overwritten by layer.Draw(...).
The error can be seen e.g. when having a colored semi-transparent image and apply a black and white filter. In the regions of the image where alpha is != 255 there remain colored parts.

Layerproperties are corretly applied if "MoveSelectionTool" is active, but not if "MoveSelectedTool" is active.

MoveSelectedTool does not react on changes in Opacity, Visibility and BlendMode

I no longer feel confident about making decisions on things not not directly related to addins, so @cameronwhite will have to make an opinion here I think. But I can say that there is a problem with indentation caused by tabs vs. spaces here too, which will need correcting. :ok_hand:

Updated intends (by replacing 4 spaces with tab, don't know why mono used spaces...)

@cameronwhite
Are there still obstacles preventing you from merging this? If so I will try to improve :-)

Looks good - I just didn't see the new commit.

no problem. Thank you for merging it :-)


uucore (re)integration

Splitting off uucore into a separate repository was a mistake.  Making changes to uucore as it exists right now is painful as generally these changes also affect utilities in the coreutils repository.  Thus, this PR reintegrates uucore into coreutils as a subtree (see git-subtree) and updates the utilities accordingly.

I just noticed the subtree commit isn't signed.  That's a little annoying, but I don't think I'll bother to fix it.

Kudos for keeping the history!
I do think it should be done.
@rivy wdyt?

we will have some clippy warnings to fix

BTW, I don't know if it's the same for you, but GitHub seems to be defaulting to "squash and merge" rather than "create a merge commit" after I used it for #1540.  I'd really hate to accidentally squash all the history into one commit (as I assume that's what would happen), so be careful when merging.

Yeah, as I am using both features often, I am always careful :)

@rivy is there anything you would like changed?  If not, I’d like to get this merged sooner rather than later.

I'll look at it later today.

Overall, it looks good; but, cargo publish --dry-run is failing. It's likely because of the OsString/arg_os() updates done since uucore-0.0.4 was published. I'd probably fix that prior to merging (ie, commit and publish a 0.0.5 version of uucore + update deps to 0.0.5).
Syncing versions between at least coreutils, uucore, and uucore_procs might be a good idea as well so that we can continue to simply tag published "touchstone" versions.

Okay, I’ll see if I can publish 0.0.5 later today.

Do you have any update?
This blocks https://github.com/Homebrew/homebrew-core/pull/55987.

@uutils/maintainers , I'm going to try to land a version of this merge this weekend as a straight code merge (no complicating git-subtree management; wip => d11551c3d15860c4466cdecb33a7f0ac44b62313). History is still preserved, just filtered into the proper location in 'coreutils'.
I prefer this to adding a 'git-subtree' complication. And it's simple enough that I should be able to get it done by the end of the weekend for review.
Any objections? If not, I'll close this in deference to the new PR (#1627).

Works for me, thanks!

Closed by alternate PR #1627.


Implement websockets in client and nodejs server

Open to suggestions / improvements. What this PR implements:

Client side support of data requests via websocket (any backend can implement websockets and have the client use them)
Fallback to XHR if websockets are not supported by the browser
Fallback to XHR if the linux-dash server does not support websockets (for Go & PHP currently)
Automatic websocket reconnection on disconnect
NodeJS server websocket implementation

The websocket messages are UTF8 strings of JSON data.

Awesome PR!
I might not have a chance to do full testing of this until this weekend. Looking at the code, I see nothing wrong.
Thanks, @Afforess !

@Afforess: Merged into master. Thanks again!


cilium-dbg: New encrypt flush --stale flag

First commit changes how we handle errors. Second commit refactors the confirmation logic. Last commit introduces the new flag.
Introduce `cilium-dbg encrypt flush --stale` flag to remove XFRM states and policies with stale node IDs.

/test


Languages with standard ISO abbreviations not working

Update the records in the DB to use the ISO format (e.g. pt-BR instead of pt_BR). Then start the server and try to change the locale via the UI menu. There is no error but the language does not change.
Update the DB record to the underscore version of the abbreviation and restart the application. Then try switching the language again. It works in this scenario.
We likely just missed a spot in the applicationController for using the new functions that swap between the I18n and FastGettext versions.

languages appear to be working as expected. will keep a lookout when testing on dmptool stage too @briri . closing issue.

Translations work well


URI handling on Ubuntu launches extra window

The Issue
When clicking on LBRY links, a new instance of the application is launched rather than using the already existing one.
Steps to reproduce

Click a LBRY link (ie. lbry://what )
wait for the application to open
Click the link again

Expected behaviour
The application simply opens the new link
Actual behaviour
a new application is launched (and the link is not navigated to)
System Configuration
{
  "id": null,
  "jsonrpc": "2.0",
  "result": {
    "build": "release",
    "ip": "*************",
    "lbrynet_version": "0.10.3",
    "lbryschema_version": "0.0.4",
    "lbryum_version": "2.7.22",
    "os_release": "4.8.0-52-generic",
    "os_system": "Linux",
    "platform": "Linux-4.8.0-52-generic-x86_64-with-Ubuntu-16.10-yakkety",
    "processor": "x86_64",
    "python_version": "2.7.12"
  }
}

Screenshots
https://scrn.storni.info/2017-05-31_21-09-02-722953507.png

The part about it launching a second copy of the app is known. Electron has a built-in system for making single instance apps, and it's not behaving as expected (see #122). It's almost certainly a bug on the Electron side, and we may have to write our own system to get around it.
As to not navigating to the URI, we also got a report about that happening on Windows, so it's probably something to do with the conversion to Redux. Will check it out.

@alexliebowitz any updates? @nikooo777 still having this issue.

Fxed in the last version v1.7.8 :

Linux: Fixed app.makeSingleInstance hanging. #10586

https://github.com/electron/electron/releases/tag/v1.7.8

Nice! @alexliebowitz does this just require an electron update to get working?

@kauffj: Yep. But I'm not positive that it actually fixes our problem. In the bug they fixed, app.makeSingleInstance() was just hanging for 30-60 seconds, with no mention of shouldQuit returning the wrong value. On the other hand, there's an issue more similar to ours that was merged into the same issue. So hopefully it's all the same bug. I'll try upgrading Electron and see what happens.


Global Navigation

Description
Global navigation used across all pages on the public site.
user need
Provides users with an easy and consistent way to navigate to the main sections of the website
Navigation is greedy so links that show depend on the screen size, see an example of a greedy nav
Small screens, 0 - 768px
Small screen menu closed

Small screen menu open

Menu slides down from the top
When it's open the more button changes to close
Tapping the close button hides the menu (slide up)
'Debt & money' shows menu focus state
'Family' shows menu hover state
Links from the header (sign in etc) move to the bottom of the menu

Large screens, 768px and above
Menu closed

Menu open

Global nav link hover

Global nav link focus

Global nav link Hover menu

Only show on the large screen breakpoint
Only show for global nav link items that are visible in the main navigation bar (not in the 'more' menu)
Show on Hover
Size of the hover menus does not change depending on screen size
Top links show as a separate column
If there are no top links the menu is one column
Top links are manually set in the CMS
If there are only top links the menu is one column
A view all link is always visible at the bottom of the menu, this takes the user to the landing page.

@shakiradamji Where do we get the little up/down arrow icon for the Cloes button?

up/down arrow icon for the Cloes button?

We need to work on icons. You can use the fontawesome SVG for now https://fontawesome.com/icons/chevron-down?style=solid. @soniaturcotte mentioned making the arrow using CSS?


Include LOINC descriptions in FHIR bundle

Background
RS would like the long LOINC description name to be included in the FHIR bundle where possible. They enrich our messages with these values in the Covid pipeline but are not doing it for the UP and some receivers are asking for it.
Action requested
Include LOINC long names in FHIR bundle for both single-entry and bulk uploaded test results.
Populate Observation.code.coding.display for result observations with the test performed LOINC long name. There may be multiple Observations per bundle. If there is no test performed LOINC long name, Observation.code.coding should not have a display element added (don't send null).
Populate DiagnosticReport.code.coding.display with the test ordered LOINC long name. We currently don't populate this. If there is no test ordered LOINC long name, DiagnosticReport.code.coding should not have a display element added (don't send null).
For bulk upload:
The behavior for the bulk uploaded results is that we enrich the FHIR bundle with device data if there is a match in our table based on the model name and test performed code.
Include the LOINC long names in the data that we now enrich.
Heads up that the test ordered LOINC long name needs to match the test ordered code that we use, which might be inferred or it might be input by the user.
Acceptance criteria
Observation.code.coding.display (for result observations, not AOE) and DiagnosticReport.code.coding.display have values populated if we have them, and are otherwise not included in the FHIR bundle.
Observation.code.coding.display and DiagnosticReport.code.coding.display values match the LOINCs in Observation.code.coding.code and DiagnosticReport.code.coding.code, respectively.

Within the Fhir converter we have logic to account for not knowing exactly which device we're working with.  Is that something we need to account for with these new fields?
cc @mehansen

Within the Fhir converter we have logic to account for not knowing exactly which device we're working with. Is that something we need to account for with these new fields?
https://github.com/CDCgov/prime-simplereport/blob/b8529695f646418c12d728f972d26b012e35eae4/backend/src/main/java/gov/cdc/usds/simplereport/api/converter/FhirConverter.java#L720-L725
cc @mehansen

I don't think we should use the getCommonDiseaseValue logic here because we could end up sending a long name that doesn't match the loinc
we should use the same logic that we're using to get the code to get the long name. put differently, loinc and its long name should come from the same DeviceTypeDisease


wip: Import all remaining syscalls

note: this takes ages to compile

This change is

What about splitting those somehow? E.g. use some categories maybe? Or even alphabetically?


feat: update to puppetdb 8.8.1

New Puppetdb version is available. Interested in it being used in container-puppetdb

If it is not to much of a hassle may you please sign your commit? https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Thanks @rwaffen  for your kindness and patience! I've gone ahead and signed my commit


Only publish to Maven Central for functional changes

https://github.com/mockito/mockito-kotlin/commit/bcbea6a9c9689742e82c9c511ad1cb06fcdf842f was published to Maven Central (https://github.com/mockito/mockito-kotlin/runs/2174606136#step:4:185) but made no functional changes. To avoid spamming the Maven Central directory, we should only publish new versions that contain meaningful changes.

Sounds good. I started iterating on this (some progress here: #421)


Infix to postfix expression

Infix to Post fix expression  written in c.

sure looking forward towards it.

I added the apache liscene header. Can you please once look at the changes and comment if more changes are required.


Integrations documentation improvements

What is this PR doing?
Adding improvements to docs based on conversations with developers integrating bls-wallet in web3well.
Edit: Added #500 to this change as a quick win.
How can these changes be manually tested?

Visit each modified readme and inspect with cmd+shift+v

Does this PR resolve or contribute to any issues?
#437
#500
Checklist

[x] I have manually tested these changes
[x] Post a link to the PR in the group chat

Guidelines

If your PR is not ready, mark it as a draft
The resolve conversation button is for reviewers, not authors

(But add a 'done' comment or similar)

@jacque006 everything should be updated. Also felt like a quick win so added #500 to these changes


When monitoring SSH (tcp/22), the monitored server logs "key_exchange_identification" errors.

📑 I have found these related issues/pull requests
N/A
🛡 Security Policy

[X] I agree to have read this project Security Policy

Description
After setting up a "TCP Port" monitor for a hardened SSH service (tcp/22), every check is logged with an error for the key exchange, and though the service does show as up - it leaves behind a lot of log entries of connection errors:
---log---
Jun 29 20:30:53 ociph01 sshd[633660]: error: kex_exchange_identification: Connection closed by remote host
Jun 29 20:30:53 ociph01 sshd[633660]: Connection closed by 199.xxx.xxx.xxx port 52688
---log---
(to note, the masked IP is my Uptime-Kuma server host)
👟 Reproduction steps
Add the following lines to the monitored server's /etc/ssh/sshd_config file, and restart OpenSSH (My host is running Ubuntu 22.04):
Ciphers aes256-ctr
MACs<EMAIL_ADDRESS>KexAlgorithms ecdh-sha2-nistp521
Monitor /var/log/auth.log for the error messages with the source IP of the Uptime-Kuma server.  To note, the Key Exchange error does not have the IP of the offending host, but it is immediately followed by a "Connection closed" message from the source server.
👀 Expected behavior
There are a couple of options:

If it is just purely a "is this port open" check, it should not try to negotiate any ciphers, KEX or MAC algorithms.
If, based on the port being tcp/22, it actually attempts a cipher negotiation, that an SSH library would be used which supports all modern cipher, KEX and MAC algorithms.

For #1, if I use a port scanner such as NMAP, when I test only to see if  tcp/22 is open, there are no error messages logged because it doesn't attempt to negotiate SSH.  I would expect uptime-kuma to only test if it returns a SYN-ACK, if it is looking to see of a port is open, and then send a FIN packet back to close the connection.
The alternative would be a full TCP handshake (if running as an unprivileged user), but still hang-up before an SSH negotiation occurs - standard practice for a port scanner.
For #2, if uptime-kuma is attempting things like cipher, KEX and MAC negotiations, it should be able to support all implemented encryption algorithms - in this case, the Key Exchange Algorithm "ecdh-sha2-nistp521".
😓 Actual Behavior
---log---
Jun 29 20:30:53 ociph01 sshd[633660]: error: kex_exchange_identification: Connection closed by remote host
Jun 29 20:30:53 ociph01 sshd[633660]: Connection closed by 199.xxx.xxx.xxx port 52688
---log---
(to note, the masked IP is my Uptime-Kuma server host, and otherwise is not making connections to TCP/22 to host "ociph01")
🐻 Uptime-Kuma Version
Version: 1.23.13
💻 Operating System and Arch
Ubuntu 22:04  x64
🌐 Browser
Librewolf 127.0.2-2
🖥 Deployment Environment

Runtime: Docker version 24.0.7, build 24.0.7-0ubuntu2~22.04.1

📝 Relevant log output
No response

I think I am missing something.
We are not doing a ssh keyexchange via the TCP Port monitor (nor should we).
=> the log is accurate that the connection is closed during that part.
For the behaviour: we are using https://www.npmjs.com/package/tcp-ping

as soon as connection gets accepted, it's dropped and a new measure is conducted immediately

You can try if #4806 changes this via https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests


Blog posts for Bits premiere

Hello,
Please schedule a blog post about dbachecks that we will promote for Bits.
You can talk about anything - @Tonyw72 will be sharing code that he uses to time his CMS Groups
Duplicate topics are totally acceptable. If I have time, I'll try to talk about each topic on the readme, one by one.

THANK YOU so very much for all the posts :-)


build on windows

What is missing to enable windows builds?

openmpi ? would it be possible to build without mpi?
openblas: https://anaconda.org/conda-forge/openblas/files

@ocefpaf I have been wondering about a serial version of trilinos.  How would we do this? Could none be one of the mpi variants? Seems unlikely to work, even if none is a valid option. Would we need a completely different trilinos-serial package? How could we make it exclusive to the trilinos package? Thx

@ocefpaf I have been wondering about a serial version of trilinos.  How would we do this?

I don't know how to do that b/c I'm not a trilinos user, sorry.

Could none be one of the mpi variants?

It should be an option if that is not possible already. Pinging @minrk who may have already thought about this.

actually-none null seems to be scrubbed from the matrix by conda-build, so I've been using the string "nompi" e.g. in hdf5. If you want to have a 'default' install, then the gist is to have a track_features for trilinos_mpich or trilinos_nompi for only the non-preferred variants.


Update api-list.go

If value of delimiter in urlValues is empty, http request to ctyun (电信天翼云OOS对象存储) will be failed with error 400 (Bad Request) and error message "The length of delimiter must be 1."

This is incompatible with AWS S3, fix your storage vendor to handle this properly. delimiter can be set and it can be empty string according to AWS S3 specs.


Support multiline in templates variables

In template creation, we can user the variable ${line_selection}.
It works fine to replace selected lines with a template code using those lines.
Is there a way to match the templace for each line selected, instead of using lines as one block?
For exemple, I would like to setup a template with this :
'${line_selection}',
So, if I have multiple lines like this :
id1
id2
id3
the result would be
'id1',
'id2',
'id3',
Can be very usefull when you want to make a query like this :
select * from MyTable where id in (
'id1',
'id2',
'id3',
);
In my job, I often have to select datas where Ids come from listings in excel files.
So I copy/paste the ids, and having a template to add {' ',} around each Id would be a big time saver :)
Why not adding foreach() for the selected lines in template ?
Could be usefull in many ways :)
${foreach $line in $line_selection}'{$line}',${endfor}
Or may be it is already possible because the syntaxe say :
${id:line_selection}
but I don't find any information in help for this.
Thanks in advance

thanks for suggestion


Example for updating toolbars periodically?

I'm new to python-prompt-toolkit, but can see many exciting use cases! As a first I want to build some simple toolbar-like thing, showing a sparkline of a data series, see:

https://github.com/kablamo/git-spark
http://python-prompt-toolkit.readthedocs.org/en/stable/pages/building_prompts.html#adding-a-bottom-toolbar

Now the last example updates the toolbar only after a key press, but I'd like it to be updated periodically, after every five seconds, say. Is there a way to do this, using threads or async? I'd appreciate if an example for that would be added to the documentation.

Hi @deeplook,
Have a look at this example:
https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/examples/clock-input.py
This updates the clock in the prompt every second. The key is to call cli.request_redraw() when the UI needs to be updated. The same thing can be done for the bottom toolbar.
Jonathan

Thanks, I'm trying to wrap my head around it (not quite seeing how to add a toolbar to the Application layout, yet).
Another immediate encoding issue I have is that adding anything like real Unicode chars, say '€', in this line will result slightly garbled on screen, despite the import line from __future__ import unicode_literals:
https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/examples/clock-input.py#L23

What terminal and Python version are you using? On my system it works without issues.

The issue with Unicode chars has disappeared after moving to version 1.0. Thanks!
Now I only need to get the auto-redrawing right. I'd be glad to contribute this code below as an example. Instead of random numbers it could show something more meaningful like CPU load using the psutil package.
#!/usr/bin/env python
# -*- coding: utf-8 -*-

from __future__ import unicode_literals

import random
import subprocess

from prompt_toolkit import prompt
from prompt_toolkit.styles import style_from_dict
from prompt_toolkit.token import Token

def sparkline(numbers=[]):
    "Calculate a 'sparkline' for a list of input numbers, handle Nones, too."

    if len(numbers) == 0:
        return ''

    # find min/max values, ignoring Nones
    filtered = [n for n in numbers if n is not None]
    min_ = min(filtered)
    max_ = max(filtered)
    dv = max_ - min_

    # below X is only a dummy character used for convenience
    if dv > 0:
        ticks = 'X▁▂▃▄▅▆▇█'
        num_ticks = len(ticks) - 1
        values = [round((num_ticks - 1.)/(dv)*x + (max_*1. - min_ * num_ticks)/(dv)) if not x is None else None
            for x in numbers]
    else:
        ticks = 'X▄'
        values = [1 for x in numbers]

    res = [u' ' if v is None else ticks[int(v)] for v in values]
    return ''.join(res)

toolbar_style = style_from_dict({
    Token.Toolbar: '#0000ff bg:#ffffff',
})

def get_bottom_toolbar_tokens(cli):
    ## todo: make this redraw itself every second...
    values = [random.randint(0, 9) for i in range(80)]
    line = sparkline(values)
    return [(Token.Toolbar, line)]

def main():
    while True:
        try:
            text = prompt('> ',
                get_bottom_toolbar_tokens=get_bottom_toolbar_tokens,
                style=toolbar_style)
        except KeyboardInterrupt:
            break
        if not len(text):
            pass
        try:
            subprocess.check_call(text.split())
        except:
            print('?')
            pass

if __name__ == '__main__':
    main()

Hi @deeplook,
I'm working on a patch for prompt-toolkit to make this significantly easier. Hopefully, I can finish and push this later this week. I'll keep you posted.
Jonathan

@jonathanslenders, thanks! I was using Mac OS X with the built-in terminal or iterm2 and Python 2.7 in this case.

Hi @deeplook
Have a look at this example. (Requires the latest github version)
https://github.com/jonathanslenders/python-prompt-toolkit/blob/master/examples/clock-input.py

Hi @jonathanslenders!
Looks wonderful! Will test more early next week in combination with my https://pypi.python.org/pypi/sparklines. So far it seems that I'm not expected to use escape codes like those introduced by termcolor. But for now: thanks so much!

You're welcome.
If you want more color. Use different Tokens, and give them a style. termcolor-like escape sequences don't work. (They are also not platform independent.)


Ignore option not working as expected

I have a page showing a list of items. At runtime, each row has either an 'odd' or an 'even' css class applied. This is the relevant css:
#fileItemWrapper .even,
#fileItemWrapper .odd {
height: 80px;
width: 95%;
}
#fileItemWrapper .even {
background-color: #eee;
}
I.e. the list items have colours alternating between white and #eee. The .even and .odd classes never appear in my html files, so I added then to my uncss ignore list:
options: {
ignore: ['.odd', '.even']
}
However, the css was still deleted by uncss. To get the desired behaviour, I had to set my ignore list like so:
options: {
ignore: ['#fileItemWrapper .odd', '#fileItemWrapper .even']
}
Is this the intended behaviour? My concern is that I am working on a huge web project and there may be many similar occurrences of this situation in the codebase.
Thanks,
Barry

This is the intended behaviour - if you pass a string, UnCSS will ignore selectors that match exactly that string. However, if you use a regex instead, you can be less specific:
options: {
    ignore: [
        /\.(odd|even)/
    ]
}

Thanks Ben. So I could string all of my classes into a single regex like this:
options: {
ignore: [
/.(odd|even|yes|no|otherClass|andAnotherClass)/
]
}
Thanks,
Barry

Yes, but you can also pass an array of regexes too. :smile:

Thanks Ben. I now have it working the way I want :-)

Awesome! :+1:


Update version in setup.py

to work with cuvis.python.examples

no longer necessary, published as 3.2.1beta3


Add class-leak to composer scripts

to increase its visibility
to fix errors locally instead of seeing on GH Actions

Originally found here: https://github.com/rectorphp/rector-phpunit/pull/319#issuecomment-2017405159

Thank you @maks-rafalko


[ReferenceIntegrity] Get class from meta in ReferenceIntegrityListener

Get class from meta to get real document class instead of its proxy.
Fixes: #1077

Thank you @Jean-Beru 👏


【FIRDynamicLink】How to add custom parameters?

FIRDynamicLink
I have created a Dynamiclink in the FIRDynamicLink Console, for example
https://xxx.page.link/XktS
But if I want the user to pass a custom parameter when user click, for example https://xxx.page.link/XktS?a=b,
I want to get the value of the parameter named a, value b, how to do it? I checked all the relevant documentation and instructional videos and didn't get an answer.
I know that I can set parameters through my own domain （https://www.xxx.com/index.html?a=b）, but once this parameter is set in the console, it can't be modified. But I want the user to pass some custom information.
Sorry for using the wrong format, thank you.

When building a custom dynamic link, your user can attach normal parameters to the end of the link that can then be fetched from the query in iOS's universal link handler.
func application(_ application: UIApplication, continue userActivity: NSUserActivity, restorationHandler: @escaping ([Any]?) -> Void) -> Bool {
    if userActivity.activityType == NSUserActivityTypeBrowsingWeb {
        guard let url = userActivity.webpageURL,
              let components =  URLComponents(url: url, resolvingAgainstBaseURL: false) else {
            // Unable to parse URL components.
            return false
        }

        if let queryItems = components.queryItems {
            // Fetch the custom parameters from the URL's query items.
            // See Apple's docs: https://developer.apple.com/documentation/foundation/urlcomponents/1779966-queryitems
        } else {
            // No query items for this URL.
        }
        return true
    }

    return false
}

It's worth noting this is all non-Firebase functionality, just iOS's default universal links functionality.

@morganchen12
Thank you , I know user can attach normal parameters to the end of the link that can then be fetched from the query in iOS's universal link handler.
But when user launch app first time (https://xxx.page.link/XktS?a=b,),
this method will be called.
- (BOOL)application:(UIApplication *)application
            openURL:(NSURL *)url
  sourceApplication:(NSString *)sourceApplication
         annotation:(id)annotation {

  FIRDynamicLink *dynamicLink = [[FIRDynamicLinks dynamicLinks] dynamicLinkFromCustomSchemeURL:url];

  if (dynamicLink) {
    if (dynamicLink.url) {
      // Handle the deep link. For example, show the deep-linked content,
      // apply a promotional offer to the user's account or show customized onboarding view.
      // ...
    } else {
      // Dynamic link has empty deep link. This situation will happens if
      // Firebase Dynamic Links iOS SDK tried to retrieve pending dynamic link,
      // but pending link is not available for this device/App combination.
      // At this point you may display default onboarding view.
    }
    return YES;
  }
  return NO;
}

I can not grab custom(a=b)  parameters this time.
Only the following parameters can be obtained
{
    "deep_link_id" = "https://xxx.com/index.html?d=1";
    "match_message" = "Best (of many) pre-install links matched for this device.";
    "match_type" = weak;
    "request_ip_version" = "IP_V4";
    "utm_medium" = "dynamic_link";
    "utm_source" = firebase;
}

I tried using a full link, similar
https://xxx.page.link/?link=https://xx.com/index.html?d%3D1&isi=234324234&ibi=com.xx.xxx&efr=1&a=b

When using the full link, as you said, I can get the custom parameter of a=b through the universal link, but the first time app launch  I still can't get it (a=b).

I have a solution.
First, give the user a webpage that we developed ourselves. When the user clicks into the webpage, use the restful api to dynamically create a specific dynamic link. Then the user clicks on the link and then opens the AppStore to download the app.

In either case, is the full deep link (including parameters) stored in deep_link_id?

If the app is not installed, then when the user clicks on full link or short link, firebase will record user feature information. When the app is first installed and opened, firebase will collect the same user information to compare with google server. If the comparison is successful, Then it means the same user, then call [sourceApplication:(NSString *)sourceApplication] .. method. At this time, other parameters cannot be carried because the comparison is not 100% accurate.
When the app is already installed, if the user clicks on the full link, then the iOS's universal link is actually working. If you add other parameters after the full link, you can get it by the app handle.
If the app is already installed, when the user clicks on the short link, the same is true, iOS's universal link is working, but if you add a custom parameter after the short link, it cannot be obtained by the handle because When the short link is passed to the app, the firebase sdk will get the parameters through the short link path to the firebase, so it don't include our custom parameters.
If you want to add a custom parameter to the short link, you need an intermediate page, use the restful api to generate a short link for the information related to the user who clicked. Then place a button in the middle page to guide the user to click, click on the button The short link generated by the restful api will be called, so that when the user downloads the app, the custom parameter can be obtained.
Hope to help

@dmandar is there a more direct way to achieve the same functionality?


the after-open setTimeout is now more resilient to synchronous testing

We were running into issues in automated testing of drop, where we synchronously run a lot of events that open and close drop instances. This makes the case we kept hitting go away, and is probably(?) what drop should be doing anyway.

Sorry for the delay. Not entirely sure how this makes setTimeout more resilient. It may be something I'm missing, but if you don't mind explaining a little more, that'd be great :smiley_cat: _cat:

Hey!  Each time one was opened, it would register on the next tick that handler.
But then said drop instance would be synchronously destroyed, so when the next tick came around, this.drop would be undefined and cause drop to throw an error.
That's all!

Ah, I think that's valid a point. Would you like to open a new PR and add that change (since the repository has changed quite a bit since this was opened). Or if you don't care about contribution commits :sweat_smile: I can just add that change for you.

Done https://github.com/HubSpot/drop/pull/77 , thanks!


Typing

Still work in progress, if only because of two things:

[x] Just as on main this returns an empty string on misses
[ ] The as_literal syntax will need to be supported on the limitador end too
[ ] Still working on adding support for the more complex types which are afaict protobuff encoded

Superseded by #60


search-ui: grammatical pedantry

Quick grammar fix - should be "1 more version exists" in the singular / "n more versions exist" in the plural

I give up, why does that fail? :(

I think the linter wants "this" to be on the following line because the line is too long now :/ .

Closing as with comment on #2188 as it deals with i18n side of this issue.


GSAGH-139-Ability-to-create-Gridlines

It would be cool to add preview, draw the lines as dotted lines with labels (A) at the ends, as well as baking method.

Do we want to replicate Gsa graphics or expose it in the API?

It would be cool to add preview, draw the lines as dotted lines with labels (A) at the ends, as well as baking method.

Do we want to replicate Gsa graphics or expose it in the API?

I think we just recreate it, perhaps make it a tad prettier than GSA even?


Portable Terminal Animations

Sometimes when others are using the portable terminal it seems that it can sometimes disappear from their hands.
It usually happens when someone else has the portable terminal open, and then I equip and unequip it.
What is expected to happen is the portable terminal to obviously well, not disappear from someone's hands.
I currently do not have screenshots.
I do not have any mods that mess with animations.

Had same thing today, terminal sometimes forget to appear and players look like touching empty air while using terminal

Fixed in 148


`require': cannot load such file -- guard/rspec_defaults (LoadError)

I'm using Guard for gem testing without requiring it in gemspec and getting error:
/home/luna/.rvm/gems/ruby-2.3.0/gems/guard-rspec-4.6.4/lib/guard/rspec_formatter.rb:10:in `require': cannot load such file -- guard/rspec_defaults (LoadError)
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/guard-rspec-4.6.4/lib/guard/rspec_formatter.rb:10:in `<top (required)>'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1280:in `require'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1280:in `block in requires='
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1280:in `each'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration.rb:1280:in `requires='
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration_options.rb:109:in `block in process_options_into'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration_options.rb:108:in `each'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration_options.rb:108:in `process_options_into'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/configuration_options.rb:21:in `configure'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:101:in `setup'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:88:in `run'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:73:in `run'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/lib/rspec/core/runner.rb:41:in `invoke'
	from /home/luna/.rvm/gems/ruby-2.3.0/gems/rspec-core-3.3.2/exe/rspec:4:in `<top (required)>'
	from /home/luna/.rvm/gems/ruby-2.3.0/bin/rspec:23:in `load'
	from /home/luna/.rvm/gems/ruby-2.3.0/bin/rspec:23:in `<main>'
	from /home/luna/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `eval'
	from /home/luna/.rvm/gems/ruby-2.3.0/bin/ruby_executable_hooks:15:in `<main>'

I think require "guard/rspec_defaults" need to be changed to require_relative "rspec_defaults"

Does it work? You can submit a PR.
Or you can create a repository reproducing the problem.
That part of the code is a bit brittle and hard to test, so I'd like to reproduce the problem first.

git clone https://github.com/1v/torckapi.git && cd torckapi

Guardfile:
guard :rspec, cmd: "bundle exec rspec" do
  watch(%r{^spec/.+_spec\.rb$})
  watch(%r{^lib/(.+)\.rb$}) { "spec" } #     { |m| "spec/lib/#{m[1]}_spec.rb" }
  watch('spec/spec_helper.rb')  { "spec" }
end

Thanks! I wouldn't have been able to reproduce it without the repository (because I have shell aliases linking to bundler).
This will be fixed here: https://github.com/guard/guard-rspec/pull/354


Private constructors utils

#6087 was slightly "controversial" due to having its main goal being intertwined with a bunch of JavaDoc stuff.
This PR is to:

Ensure that all utility classes have a private constructor to prevent users from instantiating those classes needlessly. (Basically, I replaced the implicit no-arg constructor by a private one.)
Ensure that all utility classes are final to prevent users from needlessly extending them.

I'm not quite sure why the very first commit's diff ended up being calculated as if I had redone the whole classes: all I did was use Alt+Insert in IntelliJ to get the constructors to be generated automatically before changing the public modifiers to private ones.

I think that the diffs are big because you have changed line endings. I suspect that this may happen because IntelliJ does a partial refactor of the class, which changes it, but I'm not sure. The PR with whitespace changes ignored looks OK. It would be great if you managed to fix that whitespace issue, so that it does not mess with file history.

To support my claim, here is the diff for the GeometryUtils class as seen in IntelliJ:

Yet GitHub says I made over 500 modifications in the file...

Try git diff command. Or maybe your git linebreak settings are wrong, somehow. This whole linebreak thing is a mess.

@Darkyenus confirmed to be a problem with linebreaks.

On my editor, it's configured to be CRLF. Not sure what it should be in the libGDX context...
Anyways, I merged master to pull changes from the 1.9.11 release. Took the time to create the new CHANGES section and fixed a typo in there too.
I'm not sure how I'm suppose to revert the commit properly. I tried to do it from within IntelliJ but that lead to many other issues.  Any ideas?

Create a commit that reverts the lineendings. Use git rebase -i to move that commit one after your initial change commit and squash / fixup those two together.

Usually my go to command is git rebase -i for those sort of issues. E.g. drop the Merge, create a commit that reverts the lineendings, move the commit down to your initial changes and squash / fixup the commits together. However as the PR is already open, I don't know how github handles a history rewrite.

So I can't avoid this "pollution" of the logs?
(Will git blame point to me for those files? That would be rather unfortunate in terms of historical tracebacks.)

(Will git blame point to me for those files which has their line-endings modified? That would be rather unfortunate in terms of historical tracebacks.)

AFAIK yes, but there's no way around this and we had this before. The only thing we could do is convert every file to lf file endings in a single commit.

Ouch.

The only thing we could do is convert every file to lf file endings in a single commit.

Maybe do that before, and then if I merge the commit, then I won't specifically be on that git blame. It'd allow you guys to potentially finally run a "Code Formatter" on the whole codebase, and have a meaningful commit message associated with it.

Looks like it's set, you can either clean up conflicts (addition to CHANGES not needed in my opinion) or close this PR @payne911 :)

addition to CHANGES not needed in my opinion

Oops. Just did that. Were you commenting because you saw it?


Add Czech language to i18n

Hey there!
We would like to start using Geekdoc for our docs, but unfortunatelly we need strict support for Czech language. So that's why I've decided to contribute to your project!
It should be pretty straight-forweard. I've used strictly formal language, but balanced the translations so it doesn't sound like a robot translated it.

Thanks for your contribution!


"BUZIAȘ is listed in the drop-down menu

Description:
"BUZIAȘ " is listed in the drop-down menu alongside its corresponding county and commune, according to the law
Precondition:
The website is up an running.

Step 1
Type "BUZIAȘ" in the search bar.
Expected results
The location is listed in the drop-down menu as "Oras BUZIAȘ, TIMIȘ (BUZIAȘ)".


Teckin sp22 tuyaconvert problem .................................

Hello friends, first of all congratulate on this great community.
Two days ago I bought 4 Teckin SP22 plugs on Amazon, I am trying to convert you https without success, I put the pairing mode (blue fast blinking) and I only get on the screen ............. ..........................
Say I have looked in the smart life app and version appears
Device: Teckin SP22
WIFI Firmware v1.0.1
MCU Firmware v1.0.1
Does this mean that I have a device from You or Realtek? Any way to know unopened? Any alternative to solve my problem? Or do I have to return to Amazon / Teckin? Thanks in advance, I put some images so you can see my screen as it is. Sorry for my English since I am from Spain and I use some translator.

Also say that when I press enter on the command line and teckin sp22 is flashing blue, it immediately turns off after entering and remains off.
If I do the same process but blinking purple / red, immediately after pressing enter on the command line then relay sounds and teckin sp22 goes off.
Logs:
smarthack-wifi.log
smarthack-mqtt.log
smarthack-psk.log
smarthack-smartconfig.log
smarthack-web.log
Thanks for your time
@kueblc thanks

Unfortunately this device is using a Realtek chip instead of ESP82xx, so you will not be able to run custom firmware, whether by tuya-convert or direct wire.
Also your tuya-convert is out of date, so if you have other devices to flash I recommend updating first.

oh, thanks ... how can you tell what realtek has? and how can i update yours convert? thank you!
Finally there is the same problem with the sp21? or these would be correct to buy and be able to make yours convert and not realtek. Thanks again @kueblc

You can tell because it calls /d.json not /gw.json in your web log.
I do not know what the status of the SP21 is.

To update, assuming you installed with git, do git pull.
If you did not install with git, you should.
git clone https://github.com/ct-Open-Source/tuya-convert.git

Thanks friend, I think I'm going to ask for Blitzwolf shp2 or shp8.  what do you think?

I tried to flash yours convert a hyleton 314 switch, I started putting ......... online commands and LED indicator plug is off, now the switch does not work, LED stays off and a Wi-Fi appears that puts vtrus recovery, which  have i done wrong?  How do I recover?
@kueblc

Check "Troubleshooting" wiki page

You need to configure the device, you can seek help for that from Sonoff-Tasmota

Sorry i can't understand, I put Wi-Fi configuration and Wi-Fi pass and now I am not able to enter the plug configuration again, the LED and button do not work and I cannot put ap mode.
@kueblc

LEDs and button will do nothing until you configure it.
Check your router to see if the device has connected. Then you'll need to go to that IP address to finish configuration. I can't provide support for that, you'll need to seek help from Tasmota.
If it hasn't, you may have entered the wrong password. There is support for that in the wiki.

ok, this is solved, it was the router assigned mac with random ip.  I'm missing the part of running led and button I have only seen hyleton 313 I have set the same configuration but those gpios do not work
@kueblc thanks!!

The only problem I have now with the hyleton 314 after moving to Tasmota is that it does not work LED or button on manual off ... I have put the GPOI that puts on the page:
https://github.com/ct-Open-Source/tuya-convert/wiki/Compatible-devices-(HTTP-firmware)

Hyleton 314
EU
wifi smart plug
HLT-314
GPIO0 = LED2i, GPIO2 = LED1i,GPIO13 = Button1,GPIO15 = Relay1

But it doesn't solve the problem, I don't know what to do, if with ESPhome it would be solved or is there any other configuration? Thanks in advance.
thanks for all @kueblc

Is it possible to get correct GPOIS for HYLETON 314 EU? the ones on the page seem to be incorrect nothing works when you put them in and it is automatically restored to factory values after ... Thanks

@roberdlv yes it is possible to find the correct GPIO, but you need to seek support from Tasmota. I am a volunteer maintaining tuya-convert on my own time, I can not help with unrelated matters.

Thanks friend, I already managed to fix it GPIO was wrong.
I put the configuration that I managed to make work for if someone has HYLETON 314 can also solve their problem.
Thanks for everything.


addHeader/noHeader doesn't work

Type: Bug
Version: 0.5.0
It seems that addHeader/noHeader doesn't work (which one is it supposed to be? It seems to exist with 2 names: CommandLineParser.ts)
Steps to reproduce the issue

npm install --g --upgrade typescript-to-lua
Create an empty directory and cd into it
Create tsconfig.json

{
    "include": [
        "./**/*.ts"
    ],
    // doesn't seem to affect compiliation, dontRequireLuaLib still works
    "luaLibImport": "none",
    "luaTarget": "5.1",
    "noHeader": true,
    "addHeader": false,
    "dontRequireLuaLib": true
}

create an empty TypeScript file (any name) and save it
tstl -p ./tsconfig.json
Notice the header comment in the resulting .lua file

Hey! noHeader was added with some refactoring of the runtime lib. It is not released yet thats why it wont work with npm install --g --upgrade typescript-to-lua no Header will replace addHeader.

Hey, thanks for the quick response. Keep up the good work!

Should be solved now 0.7.0 is published.


I cannot find the code for office dataset? I just got a code for office data set preparation. Can you tell me that how can I get results for office dataset?

We did do some experiments using the Office dataset but they weren't that successful, so there is no code included for running the experiments, yet.


Use actions in FlowView instead of built-in shortcuts

This changes no behavior, just adds flexibility.
This allows for

Changing shortcuts/removing shortcuts
Adding these actions to a KActionCollection
Easily attaching them to buttons

That's good, thanks


Handling of  element in output

In the XHTML output by default text inside the "q" element is surrounded in dumb double quotes.
But in the PDF output the same text is surrounded in smart double quotes.
Maybe we should have consistency in these outputs.

There exist OpenQuote and CloseQuote strings (xsl/common/strings-en-us.xml), which I assume are being used for XHTML and to facilitate both internationalization and house style preferences for "straight" or "curly" quotes. Are you saying we should simply change the default values for some languages to the curly quote symbols?

...and that assumption seems to have been incorrect. 😦

This should be fixed in SASS.

Right now as @shaneataylor says the "strings-en-us.xml" generates actual characters for those elements. So @jelovirt, are you suggesting giving up the  "strings-en-us.xml" approach for this case and style the spans via the CSS?

Long ago when these quote strings were added + used in XHTML, the browsers did not have reliable formatting for <q> (some showed quotes, some did not, and I think there were also issues with localization).
I tested this a couple of months ago when somebody's validation tool complained about the quotes, and all of the browsers I tried with correctly displayed quotes for something like <q>test</q> in the HTML. I think it's time to stop pulling in the string variables for X/HTML and instead just use the native <q> element.

Fixed with https://github.com/robander/dita-ot/commit/d5db3f2a2697f2bebce5f6a92527c9678480cd62