@auth does not work for update mutations with owner and group combo

Describe the bug
If a @model has @auth rules of "allow: owner" and "allow: groups, groups: ["Manager"], mutations: [update]", updates won't actually work when a user belonging to the Manager group performs an update mutation. Instead you get following dynamo error: The conditional request failed (Service: AmazonDynamoDBv2; Status Code: 400; Error Code: ConditionalCheckFailedException
To Reproduce
Steps to reproduce the behavior:
Create model in graphql as follows:
type Task
  @model
  @auth(rules: [
  {allow: owner},
  {allow: groups, groups: ["Manager"], mutations: [update], queries: [get, list]}
])
  {
    id: ID!
    title: String!
    description: String
    status: String
  }

Then as a user belonging to the Manager group try to do an update mutation, you'll get the error.
Expected behavior
If a user belongs to an authorized group for updates then owner check should be skipped.
Additional context
The reason this bug is happening is because the ownership condition is appended to the dynamodb query on updates regardless of what group the user belongs to. To fix, static group authorization code on the vtl should run first, then ownership condition should only be added if $isAuthorized is false. Actually the more I look at the resolver code, even the actual owner (who may not belong to Managers group) wont be able to update the model. $isAuthorized is set to true only if user belongs to the defined group. So it seems this scenario of combo owner and groups @auth rule was not tested and is not currently supported.
This is the start of Mutation.updateTask.request:
## START: Prepare Ownership Condition. **
#if( !$authCondition )
  #set( $authCondition = {
  "expression": "#owner = :username",
  "expressionNames": {
      "#owner": "owner"
  },
  "expressionValues": {
      ":username": {
          "S": "$ctx.identity.username"
    }
  }
} )
#else
  #set( $authCondition.expression = "($authCondition.expression) AND #owner = :username" )
$util.qr($authCondition.expressionNames.put("#owner", "owner"))
$util.qr($authCondition.expressionValues.put(":username", { "S": "$ctx.identity.username"}))
#end
## END: Prepare Ownership Condition. **

## START: Static Group Authorization. **
#set( $userGroups = $ctx.identity.claims.get("cognito:groups") )
#set( $allowedGroups = ["Manager"] )
#set($isAuthorized = $util.defaultIfNull($isAuthorized, false))
#foreach( $userGroup in $userGroups )
  #foreach( $allowedGroup in $allowedGroups )
    #if( $allowedGroup == $userGroup )
      #set( $isAuthorized = true )
    #end
  #end
#end
## END: Static Group Authorization. **

## START: Throw if Unauthorized. **
#if( !$isAuthorized )
$util.unauthorized()
#end
## END: Throw if Unauthorized. **

#if( $authCondition )
  #set( $condition = $authCondition )

And this is the dynamo query:
{
  "version": "2017-02-28",
  "operation": "UpdateItem",
  "key": {
      "id": {
          "S": "$context.args.input.id"
    }
  },
  "update": $util.toJson($update),
  "condition": $util.toJson($condition)
}

To fix, I modified the update resolver code like below. Basically I changed $isAuthorized flag to $isGroupAuthorized, removed the $util.unauthorized(), and instead only add the owner $authcondition if $isGroupAuthorized is false.
## START: Static Group Authorization. **
#set( $userGroups = $ctx.identity.claims.get("cognito:groups") )
#set( $allowedGroups = ["Seema"] )
## This generated code is modified to workaround https://github.com/aws-amplify/amplify-cli/issues/305 bug
##set($isAuthorized = $util.defaultIfNull($isAuthorized, false))
#set($isGroupAuthorized = $util.defaultIfNull($isGroupAuthorized, false))
#foreach( $userGroup in $userGroups )
  #foreach( $allowedGroup in $allowedGroups )
    #if( $allowedGroup == $userGroup )
##      #set( $isAuthorized = true )
      #set( $isGroupAuthorized = true )
    #end
  #end
#end
## END: Static Group Authorization. **

## START: Throw if Unauthorized. **
##if( !$isAuthorized )
##$util.unauthorized()
###end
## END: Throw if Unauthorized. **
##if( $authCondition )
#if( !$isGroupAuthorized && $authCondition )
  #set( $condition = $authCondition )

@hisham This has been fixed in https://github.com/aws-amplify/amplify-cli/pull/285

Great, thank you @mikeparisstuff for this and the rest of your work. :)


What should be the StartTime for sonyflake initialization to ensure that the parsed ID corresponds to the UTC creation time?

Any StartTime is OK. You can get the UTC time for a Sonyflake ID:
st.StartTime.Add(ElapsedTime(id)).UTC()


System-Search_Station-Search-By-System

Add two endpoints, find System by substring to match exploration, find Stations by SystemName to return a station list.

shelving


Work Package wp-fm.csv

Results of Phase 1
wp-fm-results.csv

I would like to work on this please!

Results of Phase 1
wp-fm-results.csv

I completed this work package.

Result of phase 2
wp-fm-results.csv

Results of phase 2 :
wp-fm-results.csv

I would like to work on this please!

wp-fm-results.csv
Results of Phase 1

I completed this work package.


Update ESLint to be less strict for Frontend

Description
Currently the ESLint config that's been set up is very strict. Team would like to loosen the rules to ease developer pain.. Also to change config to JS
Acceptance Criteria

[ ] ESLint lints JS files
[ ] ESLint rules less strict
[ ] Optional: VS Code settings updated

Implementation details

n/a
Testing notes

n/a

@hajineats please review issue

approved


OutputAgent Digestion / Delay

As a former Yahoo Pipes user, I arranged my Agents' workflow similar to the Pipes Modules for most Scenarios I am using:
WebsiteAgent / RSSAgent (grab data) -> EventFormattingAgent (split/format data) -> TriggerAgent (remove certain items) -> DeDuplicationAgent (unify output) -> DataOutputAgent (output data as RSS feed)
Now there are data sources (Websites / RSS feeds) which constantly output new data, even in the range of minutes, so I had to set the WebSiteAgent / RSSAgent at the beginning of the workflow to run every few minutes (or so) in order to not miss any input.
However, I would prefer to have this data output once every hour or so, instead of having one new item every two minutes (or so).
Alternatively / additionally it would be great to have the OutputAgent "release" data if there are more than X items queued up.
Is it possible to implement such functionality with existing agents or would that be a new feature? If it would be a new feature, would it be feasible to implement? What do you guys thing?

DelayAgent? wouldnt solve the problem...
RollUpAgent? RollUp like riemann.io would be cool.

Few questions:

If you have a DeDuplicationAgent, why does it matter how often it sources the feed?
Does the PeakDetector help?  It may not be sufficient, though.

I use Thunderbird for mails, as a calendar and as an RSS Reader (via TinyTinyRSS). I often need to reply to mails in a timely fashion but when I switch to TB because of a "new mail" notification, I see that some feeds have a few new entries. So I go ahead and read them, instead of reading them once per hour or so.
I know that this could be alleviated by self control, just was wondering if someone else would find this useful.
By the way, I would call it SpoolerAgent.

I don't think this is possible yet (although probably could be done with the JavaScriptAgent).  It'd be an interesting contribution.

ok, so how does the email digest agent "cache" entries?

It pushes incoming events into a queue here, then pulls them back out when check is called here.

Couldn't that part of code just be copied to create an agent which queues events and propagates them to other agents based on the "Schedule" setting?

Yes, this is definitely possible if someone wants to work on it.  If you'd like to give it a try, I'm happy to help you get your environment setup.  You'll want to use git on the command line to make branches on your fork on Huginn so that you can make pull requests with multiple files.

Which part of the code exactly propagates event output to the next agent? Could you point out an example in one of the existing agents?

What do you think about this?
module Agents
  class SpoolAgent < Agent

    default_schedule "every_12h"

    description <<-MD
      The Spool Agent collects any Events sent to it and outputs them all when scheduled.
    MD

    def receive(incoming_events)
      incoming_events.each do |event|
        self.memory['queue'] ||= []
        self.memory['queue'] << event.payload
        self.memory['events'] ||= []
        self.memory['events'] << event.id
      end
    end

    def check
      if self.memory['queue'] && self.memory['queue'].length > 0
        self.memory['events'].each do |event|
        #log("Propagating event '#{event}'.", :inbound_event => event )
        create_event payload: event
        self.memory['queue'] = []
        self.memory['events'] = []
      end
    end
  end
end

You probably don't need both the 'queue' and 'events' sets.  I'd suggest keeping just 'events' and using those ids in check to re-find the events and emit them.  Something like events.where(id: memory['events'])
But does it functionally work for you?

I wanted to run it by you before I put some code in a language I don't speak onto my server :)
That being said, here's my next try:
module Agents
  class SpoolerAgent < Agent

    default_schedule "every_12h"

    description <<-MD
      The Spooler Agent collects any Events sent to it and outputs them all when scheduled.
    MD

    def receive(incoming_events)
      incoming_events.each do |event|
        self.memory['events'] ||= []
        self.memory['events'] << event.id
      end
    end

    def check
      if self.memory['events'] && self.memory['events'].length > 0
        create_event payload: events.where(id: memory['events'])
        self.memory['events'] = []
      end
    end

  end
end

btw: if you don't need to store the actual payloads in the memory, but can just refer to them by storing their ids, then why does the email digest agent actually store the payload in the memory, too?

You should definitely set Huginn up locally so that you can try this out in development.  Our README should take you through that process.
Do you want it to re-emit a single event, or all of the received ones?  If you wanted all of them, you could do:
def check
  if self.memory['events'] && self.memory['events'].length > 0
    events.where(id: memory['events']).each do |event|
      create_event payload: event.payload
    end
    memory['events'] = []
  end
end

I know how to do that and I meant that I don't want to throw anything in a language I don't speak, even onto a development server.
However, the agent doesn't work as it doesn't emit any events to agents down the line. Are you sure your idea about just storing the id is correct? If we just store the events' id then how can you access the payload of that id by just referring to the id, instead of the actual event somewhere inside the database?
Maybe that is the reason why the EmailDigestAgent stores both the id and payload in memory!?

Can I see your whole code?

module Agents
  class SpoolerAgent < Agent

    default_schedule "every_12h"

    description <<-MD
      The Spooler Agent collects any id sent to it and outputs them all when scheduled.
    MD

    def default_options
      { "no options" => "are needed" }
    end

    def working?
      true
    end

    def receive(incoming_id)
      incoming_id.each do |event|
        self.memory['events'] ||= []
        self.memory['events'] << event.id
      end
    end

    def check
      if self.memory['events'] && self.memory['events'].length > 0
        events.where(id: memory['events']).each do |event|
          create_event payload: event.payload
        end
        memory['events'] = []
      end
    end

  end
end

I think I see the problem.  events here is the current Agent's events, which won't contain the incoming ones.  Try received_events.where(id: memory['events']).each do |event|
Also, be sure to clear the memory of your agent in it's summary page if you change the innards.
Also, receive is getting an array of Events, not ids.  Try this:
module Agents
  class BufferAgent < Agent
    default_schedule "every_12h"

    description <<-MD
      The Buffer Agent stores received Events and emits copies of them on a schedule.

      `expected_receive_period_in_days` is used to determine if the Agent is working. Set it to the maximum number of days
      that you anticipate passing without this Agent receiving an incoming Event.
    MD

    def default_options
      {
        'expected_receive_period_in_days' => "10"
      }
    end

    def validate_options
      unless options['expected_receive_period_in_days'].present? && options['expected_receive_period_in_days'].to_i > 0
        errors.add(:base, "Please provide 'expected_receive_period_in_days' to indicate how many days can pass before this Agent is considered to be not working")
      end
    end

    def working?
      last_receive_at && last_receive_at > options['expected_receive_period_in_days'].to_i.days.ago && !recent_error_logs?
    end

    def receive(incoming_events)
      incoming_events.each do |event|
        memory['events'] ||= []
        memory['events'] << event.id
      end
    end

    def check
      if memory['events'] && memory['events'].length > 0
        received_events.where(id: memory['events']).each do |event|
          create_event payload: event.payload
        end
        memory['events'] = []
      end
    end
  end
end

If this works, I can make a PR for it.  I tested and it works for me.

Thanks for the help. I will only be able to test this once https://github.com/cantino/huginn/issues/1036 is resolved though.

I will be adding this Agent in #1055.

I've merged #1055 into master now.


Consuming MSGraphClient. Cannot read property 'PROD_OAUTH_TOKEN_URL' of undefined

Category
Question
Bug
Expected or Desired Behavior
I added code from this documentation https://github.com/SharePoint/sp-dev-docs/blob/master/docs/spfx/use-msgraph.md
Observed Behavior
When it hit line
const client: MSGraphClient = this.context.serviceScope.consume(MSGraphClient.serviceKey);
i get this exception

sp-client-preview.js:128 Uncaught (in promise) TypeError: Cannot read property 'PROD_OAUTH_TOKEN_URL' of undefined
at MSGraphClient._configureGraphSDK (sp-client-preview.js:128)
at sp-client-preview.js:94
at e._processPendingCallbacks (sp-webpart-workbench-assembly_en-us_c62a811b76aa07bcefefad77b22b5dde.js:283)
at e.consume (sp-webpart-workbench-assembly_en-us_c62a811b76aa07bcefefad77b22b5dde.js:283)
at e.consume (sp-webpart-workbench-assembly_en-us_c62a811b76aa07bcefefad77b22b5dde.js:283)
at e.consume (sp-webpart-workbench-assembly_en-us_c62a811b76aa07bcefefad77b22b5dde.js:283)

Steps to Reproduce
Create a new web part project with SharePoint Framework 1.4.1 and add MSGraphClient by this acrticle https://github.com/SharePoint/sp-dev-docs/blob/master/docs/spfx/use-msgraph.md

I've been having the same issue with the documentation mentioned above and with this tutorial https://docs.microsoft.com/en-us/sharepoint/dev/spfx/use-aad-tutorial

Have you tried deploying the solution and not running it in the workbench. That worked for me.

That solved the problem. Thanks Wictor.

Now it works somehow even with workbench running. Don't know what was the case

There's an unfortunately known issue that Online workbench does not work regardless of the given permission s in the AAD application. We are working on getting this resolved. We'll also check if we can clarify that in the tutorial doc.

@VesaJuvonen any progress on this? Developing without the workbench to test Graph calls is quite the pain. And no rush, we're in preview :)

@aslanovsergey  Thanks for bringing this issue to light. This issue has been fixed and will be made available in the next release.


Uncapitalize errors

See: https://github.com/golang/go/wiki/CodeReviewComments#error-strings

Codecov Report

Merging #18915 (81526a1) into main (fa0e2d6) will increase coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #18915      +/-   ##
==========================================
+ Coverage   46.62%   46.64%   +0.02%
==========================================
  Files         854      854
  Lines      122561   122561
==========================================
+ Hits        57144    57171      +27
+ Misses      58521    58493      -28
- Partials     6896     6897       +1

Impacted Files
Coverage Δ

routers/web/repo/issue.go
37.81% <0.00%> (ø)

routers/web/repo/lfs.go
0.00% <0.00%> (ø)

routers/web/repo/webhook.go
1.00% <0.00%> (ø)

modules/process/manager.go
81.36% <0.00%> (-1.87%)
:arrow_down:

services/pull/pull.go
40.24% <0.00%> (+0.46%)
:arrow_up:

modules/queue/workerpool.go
55.35% <0.00%> (+2.08%)
:arrow_up:

modules/queue/queue_channel.go
81.13% <0.00%> (+2.83%)
:arrow_up:

modules/queue/queue_bytefifo.go
52.72% <0.00%> (+5.81%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa0e2d6...81526a1. Read the comment docs.


RAM requirements

Very nice library and I can't wait to get everything up and running. Thank you for sharing!!!!
I have installed the conda env and run the initial conversion as outlined in Koala.md.
Once that was done, I wanted to recover the model using the diff and that is where I ran out of memory.
I watched the system monitor steadily climb until my virtual memory and physical memory were 95% full and that is when the process was killed by the system.
I have a Dell Precision workstation with 32GB of RAM and Quadro P6000 with 24GB VRAM.

Unfortunately diffing the weights requires loading the entire weights into the RAM, which can be very demanding. Have you tried using the 7b model?

Unfortunately diffing the weights requires loading the entire weights into the RAM, which can be very demanding. Have you tried using the 7b model?

This is using the 7B model. I increased the size of my virtual memory and it seems to go half/half into virtual and physical until it reaches 94.6% of the physical and the process is killed by the system. I wonder if there is a workaround in either my system or jax/flax... do you have any ideas?
I would like to force it to use virtual memory if physical memory is at say 90%...

Im trying on Ubuntu Server 20, 32 GB Ram, 12 GB VRAM.
Running script diff_checkpoint.py, the process is killed after reaching 99% usage of Ram.
Any fixes out there or suggestions? Or do I need to upgrade the RAM to 64 GB?

Here what worked for me,
Ubuntu Server 22
128 GB Ram
12 GB VRAM -Nvidia GPU
Had to upgrade my Ram from 32 GB to 128 GB
During the diff_checkpoint.py process the ram usage reached to about 50% so about 64GB of RAM

Sharing my experience: Running the script in WSL on a windows machine with 64 GB of RAM, I had to increase WSL swap to 50 GB (it used 48.4 GB of swap during the operation). This is on top of it using all available RAM (approx. 55 GB).
I guess the virtualization had a negative effect on RAM requirements which explains the higher required RAM + swap.
Here were the settings I used in C:\Users\username.wslconfig:
'''.wslconfig:
memory=90GB
swap=50GB
'''

Try setting environment variable in .bashrc
XLA_PYTHON_CLIENT_ALLOCATOR=platform
Also try using -1 in mesh truple, second or third vector position .

To prevent VRAM OOMs in small single node mesh (dev box):

Try setting environment variable in .bashrc
-- XLA_PYTHON_CLIENT_ALLOCATOR=platform
Try using -1 in mesh truple, second or third vector position (for data vs model parallelism)
Also you may need to quantize any model of 7B params or larger (dtype param)
This framework is for grid computing, single node mesh is a hardware challenge (slow, if at all)
64GB DRAM 12GB (combined) VRAM seems to be min spec for an EasyLM dev box.


Image being converted to 32 bit color

I'm resizing a file that's at 24 bit color but the new file is saved as 32 bit.  I've tried to adjust with limitColors but no luck.  I'm not very familiar with image manipulation like this.  What should I use to set this or other bit rates?

Did you fix it? Also having trouble with it.


Issue with loading fixture

Hi,
I'm having some issue with loading fixture. Below is my code
$(function() {

    beforeEach(function(){
       loadFixtures("categories.html");

       keywordsListView = new KeywordsListView({
          el: $("#keywords_list")
       })
    })

   it("should ...", function() {
      expect(keywordsListView.el.attr("id")).toEqual("keywords_list");
   })

})

For some reason keywordsListView.el is undefined even though the fixture file exists and #keywords_list exist in the file. However, if I have loadFixtures before "beforeEach" then everything works fine. In other words, this will work
$(function() {

      loadFixtures(...) //having this makes everything works

      beforeEach(function() {
         loadFixtures(...)
      })

})

I also have this issue. I will try your last code block.
Currently I am using preloadFixtures() instead, but it doesn't work:
preloadFixtures("index.html");
beforeEach(function () {
  loadFixtures("index.html");
});


3scale response times for authorization

I'm working on a NodeJS application that calls 3scale to see if the calling client is authorized to call our endpoint. This is a simple as calling the client.authorize function. However, I've measured it, and it takes about 300-400 ms. Only then can my code continue. We're very focussed on performance now and business wants to achieve speeds of 300-500 ms. As you can see, this leaves little room for our application logic.
This is how I measured it:
console.time('Authorize');
client.authorize({
    'app_id': appId,
    'app_key': appKey
},
(response) => {
    console.timeEnd('Authorize');
    // ...
});

We also report endpoint usage (via the separate function, not yet via authrep), and those calls are significantly faster (12ms for example).
Is the 300-400 ms for authorizing something expected? Or could I be doing something wrong?
If it's something expected, do you see workarounds to increase performance? One option would be to cache the authorization responses, so we don't need to request it every time the endpoint is called.

This response time varies mainly depending on the network connection between your location and the 3scale data center running on AWS-East. The actual authorization service itself is very fast.
You are correct that it would be good to cache the auth responses. This is a reason that many customers choose to go with the APIcast Gateway because we integrate an eventual consistency cache by default.
At the end of the day the choice is yours.

Great, thanks for the quick reply. I will look into these options.


Remove yarn installation step for AppVeyor

All AppVeyor builds seem to be failing at the step where we try to install yarn through chocolatey. After some investigation (primarily from here), I found out that this was because yarn is preinstalled ever since this update.
Hence, the installation step is not only unnecessary, but it also results in guaranteed build failure, hence we should remove it.

https://github.com/SimulatedGREG/electron-vue/pull/575


add messages to docs

Codecov Report

Merging #154 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master     #154   +/-   ##
=======================================
  Coverage   75.32%   75.32%
=======================================
  Files          22       22
  Lines         993      993
=======================================
  Hits          748      748
  Misses        245      245

Impacted Files
Coverage Δ

bowtie/feedback/message.py
0% <0%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d7f596...11abef1. Read the comment docs.


Pilot config sidecar to enforce authentication policy

Enforcement of authentication policy will be done by:

[x]  Configuring SSL connection for mTLS method as described by policy.
[ ]  Adding JwtFilter for Jwt method(s) as described by policy.
[ ]  Adding AuthN filter to apply logic (tracking issue for this new filter )

https://github.com/istio/istio/pull/3915
https://github.com/istio/istio/pull/4089
https://github.com/istio/istio/pull/4122

Depends on
https://github.com/istio/proxy/issues/1212
https://github.com/istio/proxy/issues/1213
https://github.com/istio/proxy/issues/1214


Is there a way to start the bot via Batch?

I'm trying to figure out if there's a way to automate the integration setup, because it's rather annoying to set this up every time I start the bot.
This seems like a rather simple task, but I am having difficulty running more than one "set" command before my program stops. Open to input.

I think you've overthinking this. Here's my batch program
`set TWILIO_ACCOUNT_SID=XXXXXXXXXXXXXXXXXXXXXXXXX
set TWILIO_TOKEN=XXXXXXXXXXXXXXXXXXXXXXX
set TWILIO_SOURCE_NUMBER=+1XXXXXXXXXX
set TWILIO_DESTINATION_NUMBER=+1XXXXXXXXXX
nvidia-clerk-windows.exe -region=USA -delay=750`
The issue you're facing is that every time you run start cmd, it opens up a new command window and that's just gonna blow things up. just add all your values to one file, then run that file with the start cmd command

Ah. Yes, it seems I way over complicated it. Thanks for the assistance! 😄


Feature Request: add ability to change live stream visibility

We schedule a weekly YouTube stream several days to a week in advance, but we want it to remain invisible until about 24 hours before we go live.
I'd like to automate the last step of changing our stream from "unlisted" to "public" for two reasons:

eliminates some potential user error, e.g. forgetting to update the visibility setting
someone doesn't have to do extra work on a Saturday to prepare for a Sunday stream

~My intuition tells me that it's not possible since it seems that "unlisted" videos don't show up anywhere in the module, which makes me think they are invisible to the API. But maybe the developers just didn't see any reason (until now!) to query unlisted scheduled videos.~ deleted for its incorrectness

Hello @mark-epstein,
I just checked on my configuration, and I can see my unlisted videos. So you should see yours in the variable list of the module.

I can see my unlisted videos. So you should see yours in the variable list of the module
You are correct, I do. I was relying on apparently faulty memory when I suggested that YouTube might hide the unlisted streams from the API.

As an alternative or additional suggestion, maybe add a variable such as $(YT:unfinished_0_visibility)
So I can make Companion take an action at a given time if the scheduled stream isn't public.


Enums are not localized

basic case is checked:
used locale is "ru" on the server-side and client-side


Errors in outbound lambda function

These 2 errors are repeating multiple times within the Outbound Lambda function.  SMS messages from mobile to cpp is showing up on the cpp window. However, messages from the cpp window do not show up on the mobile phone.
{
"errorType": "NotFoundException",
"errorMessage": "Resource not found",
"code": "NotFoundException",
"message": "Resource not found",
"time": "2021-12-07T14:56:01.705Z",
"requestId": "a3a8aa46-1539-4ec1-9c6b-41c8eb989314",
"statusCode": 404,
"retryable": false,
"retryDelay": 15.976111499447732,
"stack": [
"NotFoundException: Resource not found",
"    at Object.extractError (/var/task/node_modules/aws-sdk/lib/protocol/json.js:52:27)",
"    at Request.extractError (/var/task/node_modules/aws-sdk/lib/protocol/rest_json.js:49:8)",
"    at Request.callListeners (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:106:20)",
"    at Request.emit (/var/task/node_modules/aws-sdk/lib/sequential_executor.js:78:10)",
"    at Request.emit (/var/task/node_modules/aws-sdk/lib/request.js:686:14)",
"    at Request.transition (/var/task/node_modules/aws-sdk/lib/request.js:22:10)",
"    at AcceptorStateMachine.runTo (/var/task/node_modules/aws-sdk/lib/state_machine.js:14:12)",
"    at /var/task/node_modules/aws-sdk/lib/state_machine.js:26:10",
"    at Request. (/var/task/node_modules/aws-sdk/lib/request.js:38:9)",
"    at Request. (/var/task/node_modules/aws-sdk/lib/request.js:688:12)"
]
}
{
"errorType": "ReferenceError",
"errorMessage": "CUSTOMER is not defined",
"stack": [
"ReferenceError: CUSTOMER is not defined",
"    at validateRecord (/var/task/index.js:72:57)",
"    at Runtime.exports.handler (/var/task/index.js:29:10)",
"    at Runtime.handleOnce (/var/runtime/Runtime.js:66:25)"
]
}

More Info: Hopefully we can get this issue resolved soon as its delaying the launch of our contact center.
Following this AWS blog exactly will provide a broken solution that allows only for the customer to send sms messages to the agent but the agent cannot reply.
Please fix. Much appreciated.
I contacted AWS Support regarding this issue, and this is what I received, I hope it helps:
"After further analysis of the code that caused the error (/var/task/index.js:75:56) I observed that the variable “CUSTOMER” and “ALL” have not been instantiated and that line 72-74 are incorrect. I also could see that a similar issue was raised in this repository [4] and I have reached out to one of the engineers regarding this. Please note that as Premium Support, I do not have visibility into code changes and roadmaps and would thus not be able to provide you with an ETA on when a fix will be implemented. The best way would be to monitor the issue on the Github page."
References
AWS Blog - sms-through-amazon-connect
https://aws.amazon.com/blogs/contact-center/building-personalized-customer-experiences-over-sms-through-amazon-connect/ms-through-amazon-connect/

I had similar issue , and found that its related to the access resource in outboundMessageFunction.addToRolePolicy within lib> chat-message-streaming-examples-stack.ts file. Updated to below resolved the issue.
outboundMessageFunction.addToRolePolicy(
  new iam.PolicyStatement({
    actions: ['mobiletargeting:*'],
    effect: iam.Effect.ALLOW,
    resources: [
      '*',
    ],
  })
);


[Feat]: Adding password validation on signup page

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description
Password validation is crucial for ensuring user accounts are secure. Weak passwords can be easily compromised, leading to unauthorized access and potential data breaches.
Password strength is a measure of how resistant a password is to being guessed or cracked. Strong passwords typically:
Are at least 8-12 characters long.
Include a mix of upper and lower case letters.
Contain numbers and special characters.
Avoid common words and easily guessable patterns.
This can be added with proper UI for representing strength based on colour like red, orange, green
Record

[X] I agree to follow this project's Code of Conduct
[X] I want to work on this issue
[X] I'm willing to provide further clarification or assistance if needed.

@kartikayasijaa I am a GSSoC Ext '24 contributor and Hactoberfest contributor too
I am ready to work on this issue

@jvkousthub Go ahead

@jvkousthub I wanna tell I am mentor of this repo if u face any problem just tell me

@jvkousthub I wanna tell I am mentor of this repo if u face any problem just tell me

I created a PR on this issue and it gave me some unknown response
https://github.com/kartikayasijaa/talk-trove/pull/32

It's only telling that vercel needs authorization from maintainer It's our part to handle


Support for static analysis tools

the location of the configuration files for codenarc and checkstyle should follow the default conventions (
<root>
└── config
    └── checkstyle
        └── checkstyle.xml
        └── suppressions.xml

and
<root>
└── config
    └── codenarc
        └── codenarc.xml

[ ] init task to generate recommended checkstyle configuration
[ ] init task to generate recommended codenarc configuration
[ ] automatically apply checkstyle task for java and groovy projects if the configuration is present
[ ] automatically apply codenarc task for groovy projects if the configuration is present
[ ] add an aggregate task for checkstyle (or maybe just declare one checkstyle task for all/each sourcesets in the project instead of adding checkstyle to each subproject), the individual tasks should not fail if aggregate tasks is running
[ ] add an aggregate task for codenarc (or maybe just declare one codenarc task for all/each sourcesets in the project instead of adding codenarc to each subproject), the individual tasks should not fail if aggregate tasks is running
[ ] the preferred output location of the tasks should be report/codenarc|checkstyle/<subproject name>
[ ] the default output format should be just html
[ ] the minimal configuration inside config.checkstyle|codenarc should contain toolVersion, maxWarnings, maxErrors resp. maxPriority[1|2|3]Violations

Similar support for Pmd would be great too

Support for detekt would also be great.


scrollTo is not always executed properly

Hi malihu,
i think there is an issue with the proper execution of the scrollTo method.
I trigger the method when an input element is focused.
If i focus an input by clicking it only the first time the scrollTo is working.
If i use tab to focus the next input it seems to work but sometimes it also fails.
Example:
http://jsfiddle.net/3xg9w2o5/14/
Thanks

Hello,
The way your app works, you don't have to disable autoScrollOnFocus option, so you can remove advanced:{ autoScrollOnFocus: false }, from the function call.
I think that the focusin event has some native delay which is greater(?) than 60 milliseconds (which is the default delay for scrollTo method). I'll have to check further of course what exactly happens between focusin, the method etc. (when I click an input and switch from another browser tab back to the fiddle tab, it does scroll).
Anyway, you could normally solve the issue by either increasing the method's default timeout:
$(".scroll").mCustomScrollbar('scrollTo', actPos, {timeout:100});
or using both focusin and click events on inputs:
$(".scroll input, .scroll textarea, .scroll select").on("focusin click",function(event){
    // your code...
    $(".scroll").mCustomScrollbar('scrollTo', actPos<0 ? 0 : actPos ); //don't scroll below zero!
});

In either case, use actPos<0 ? 0 : actPos (instead of actPos) as the position parameter to avoid negative scroll-to numbers.
Hope this helps
PS. I didn't experience the tab-focus fail at all...

Hi,
thank you for your fast response.
The timeout option works great. Didn't expected that.
Thanks


feat(rippling): debug store produce event logs

Pull Request Test Coverage Report for Build<PHONE_NUMBER>8
Details

97 of 97 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build<PHONE_NUMBER>4:
0.0%

Covered Lines:
653

Relevant Lines:
653

💛  - Coveralls


Replace Self Signed Certificate

Is it possible to pass a Let's Encrypt certificate to the container while it is being created?
The creation of the cert is not a problem, I just need a way to tell the containerhelper to use my cert instead of the self-signed one.

Yes, if you use http://aka.ms/getnav that is exactly what happens.
The code for that is in the nav-arm-templates on GitHub or you can deploy an azure vm and disassemble.

Looks like I can use that. Thanks for the quick help!


Frontstage maintenance banner

Motivation and Context

Creating a page that allows the team to easily set the maintenance banner on frontstage.
Previously this was achieved by manually updating the redis database
What has changed

There is a new route /admin/banner which renders a new admin screen. In this screen you should be able to set the banner, update the banner and remove the banner.
How to test?

Deploy to kubernetes
Port forward to both frontstage and response ops
Browser to /admin/banner on the response ops application
Set the banner
Browser to the sign in page on frontstage and check the banner is present
Update the banner
Check the banner is updated
Delete the banner
Check the banner is removed.

Links

Screenshots (if appropriate):

Travis passed but hasn't reported: https://travis-ci.org/github/ONSdigital/response-operations-ui/builds/687090739
Merging


Version 1.6 isn't available.

Going to the maven repo for the plugin, we have three versions, 1.0, 1.1 and af35481, but not 1.6, as the documentation says.
Just thought I'd let you know so it can be sorted out :)

Thanks, this is because I've been neglecting to publish releases at https://github.com/PikaMug/LocaleLib/releases
Please check again.

Still says it's not available. Might take some time though?

Yup! There we go, thanks!


lock CanRemoveMember to avoid potential race

avoid the situation of running CanRemoveMember and RemoveMember concurrently.
Not sure whether this case exists. If it never happens, I would close this PR.
ping @abronan
Signed-off-by: runshenzhu<EMAIL_ADDRESS>

I don't understand what scenario this protects against. If the concern is that CanRemoveMember could return a stale result, then holding a lock to block RemoveMember from altering the member list just delays the invalidation of the result until CanRemoveMember returns.
Also, I don't believe it's possible for both functions to run at the same time, because membershipLock in raft.go prevents this.

[Current coverage][cc-pull] is 53.89%

Merging [#1060][cc-pull] into [master][cc-base-branch] will decrease coverage by 0.10%

@@             master      #1060   diff @@
==========================================
  Files            75         75
  Lines         11686      11682     -4
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
- Hits           6310       6296    -14
- Misses         4477       4482     +5
- Partials        899        904     +5

[][cc-pull]

Powered by Codecov. Last updated by [5667c2d...5612299][cc-compare]
[cc-base-branch]: https://codecov.io/gh/docker/swarmkit/branch/master?src=pr
[cc-compare]: https://codecov.io/gh/docker/swarmkit/compare/5667c2d89c53ba3cc7ee3c6107a2aad003df7455...561229916476ad5d247eb76a3f30f58e031a18e5
[cc-pull]: https://codecov.io/gh/docker/swarmkit/pull/1060?src=pr

But this PR may be a good idea anyway, because using c.Members() is an unnecessary copy and makes the code a little less clear.

Oh, I see that this problem is solved by membershipLock.


Update keyboard tag to meet new style guidelines

Why:
Closes #13892

What's being changed:

Check off the following:

[ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
[x] For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

[ ] This pull request impacts the contribution experience

[ ] I have added the 'writer impact' label
[ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@AnilSeervi Thanks so much for opening this PR ✨
I just spoke with the team and the issues on keyboard shortcuts are for the Campus Experts + GitHub Docs program. At the moment, these issues are not available to be assigned, so we are saving rest of the issues with Campus Experts + Docs program label for this program 🐬
You are welcome to work on any other issues that have help wanted label ✨
Thanks so much for your passion in contributing to the GitHub docs 💖

@AnilSeervi Thanks so much for opening this PR ✨
I just spoke with the team and the issues on keyboard shortcuts are for the Campus Experts + GitHub Docs program. These issues are not available to be assigned, so we are saving rest of the issues with Campus Experts + Docs program label for this program 🐬
You are welcome to work on any other issues that have help wanted label ✨

Thanks for informing me about it as soon as possible 😅
I'll stop taking on the Campus Experts + Docs Program labelled issues.

Thanks so much for your passion in contributing to the GitHub docs 💖

NP, Happy to help until I'm unemployed 🙁


hctl shutdown --force

The hctl shutdown command takes a long time to shutdown all the services properly. It is not at all helpful to troubleshoot the cluster. What is desirable is a --force option so that
hctl shutdown --force

can be used for re-bootstraping a cluster. This option can be disabled in the final release version to prevent accidental data losses.

@mssawant would it be appropriate to close this issue since no work has been done on it for sometime?

@nezzzu do you think we can close this issue? Hare team may not be able to schedule in any time soon and with containerized CORTX, we may not need it any more. cc @SunilSavanurSeagate @mssawant

Vaibhav Prakash Paratwar commented in Jira Server:

[~519680] - Can we close this ticket? Commented on respective Github issue. cc [~520513] [~520478]

ganesan umanesan commented in Jira Server:

[~534380] has this been implemented? We wanted this feature a long time ago, I am not sure if this is implemented.

Vaibhav Prakash Paratwar commented in Jira Server:

[~519680] No this is not implemented and right now we do not see any plan in near future to implement this. cc [~520513] [~520478]

ganesan umanesan commented in Jira Server:

[~534380], in that case, please do NOT close and mark as resolved as we will loose important information. Same goes for other unfixed/unresolved EU R&D tickets.

Vaibhav Prakash Paratwar commented in Jira Server:

Improvment cc [~520513]

Vaibhav Prakash Paratwar commented in Jira Server:

Moving this to story JIRA instead of Bug JIRA as this is new request. cc [~520513] [~520478]

Closing as an obsolete


Custom variables

Hi,
Is there any chance to use custom variables in yml?
Like:
variables:
  PYTHON27: '${C:\\Python27\\python.exe}'
  PYTHON34: "{{C:\\Python34\\python.exe}}"

And then you can use each in whole build:
cmd: '{PYTHON27}'
Or sometthing.
Reading yaml documentation - it gives some examples of that. But nothing worked in this case.
Thanks,

Some buggy workaround:
https://stackoverflow.com/questions/5484016/how-can-i-do-string-concatenation-or-string-replacement-in-yaml
PYTHON27: &PYTHON27 C:\Python27\python.exe
CHECK: &CHECK "C:\\Python34\\python.exe D:\\TPL_IDE_Module\\check_active\\check.py"

Working example:
cmd: *PYTHON27
args:
  - *PREPROC
  - '-f {FILE_ACTIVE}'

AND
  - tplpreSyntaxCheckSolo:
    cmd: *CHECK
    args:
      - '-full_path {FILE_ACTIVE}'
      - '-l info'
    cwd: '{FILE_ACTIVE_PATH}'

I think you could better use an (external) build script in this case, instead of trying to do it with atom-build.

Yes, but this is core functionalily for build system. Implementing hardcoded paths to build-programm is not a user-oriented way. In other words - those vars can be different for each user, and will be great to have them as local vars in build yml.
But anyway, yaml has this feature by default.


Info.plist file missing

Build input file cannot be found: '/CollectionViewPagingLayout/Info.plist'

Thanks for reporting this issue, I've added the missing file


Broken on Rails 2.3

https://github.com/danpal/attr_encryptor/blob/master/lib/attr_encryptor/adapters/active_record.rb#L17
This method will never get called. It's provided in a module, but because attr_encryptor is already defined in the class it extends, that method will take priority. Example:
class Foo
  def self.ponies
    'ponies'
  end
end

class Bar
  def ponies
    super + '  rock'
  end
end

Foo.extend Bar
Foo.ponies # => 'ponies'

Since the Foo::ponies method already exists, the one in Bar is never delegated to. This needs to be wrapped around the original via alias_method_chain or similar.

This happens to you in Rails 2.3?
I wish I could support Rails 2.3, but it's too old, I don't even have a copy of ruby 1.8 anymore, but if you send me a pull request I'll merge it.

Thanks for the pull request. I tested on ruby 1.9 and Rails 3.1. I have not checked if this works on Rails 2.3 (or ever will), but hopefully it does.


Linter not installing or running.

Hello I am getting the following prompt depicted in attachments.
Also, when I attempt to update the Linter mypy it does not install.
when I attempt to install, i get there following:
C:/Users/2power/AppData/Local/Microsoft/WindowsApps/python.exe c:/Users/2power/.vscode/extensions/ms-python.python-2020.9.111407/pythonFiles/pyvsc-run-isolated.py pip install -U pylint --user
-bash: C:/Users/2power/AppData/Local/Microsoft/WindowsApps/python.exe: No such file or directory root@LAPTOP-FFAPOC6C:/mnt/c/Users/2power/OneDrive/Desktop/Python Programming#

Thanks for the bug report! We investigate issues in order based on priority and severity, which includes the impact it has on your ability to use the extension to do productive work, and the number of people affected. If other users come forward and leave a comment demonstrating they are seeing/reproducing the problem then we will raise this issue's priority.
If you think your issue is more of a question or configuration problem rather than a bug, please ask on Stack Overflow with the visual-studio-code and python labels for help.
Thanks for your understanding and patience!

In the meantime:

there are no attachments on this issue
please provide a copy of your settings.json
please provide the content of the "Python" output panel.

Because we have not heard back with the information we requested, we are closing this issue for now. If you are able to provide the info later on then we will be happy to re-open this issue to pick up where we left off.


Where can i see the uploaded images in my imgur account ?

I checked in my Imgur account. But, couldn't get them.
Is it possible to see the uploaded images in my account?

To upload to a specific imgur account, you need to follow the OAuth authentication and authorization process outlined here. Otherwise the image will just be uploaded without being attached to a user.


Compute direct reach and frequency in EDP simulator

This change is

src/test/kotlin/org/wfanet/measurement/loadtest/dataprovider/EdpSimulatorTest.kt line 612 at r1 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
are the frequencies for 4L and 5L not expected to be included?

Yes 4L and 5L are being reached one time so they are included in 1 reach?
Code snippet:
// 1 reach -> 0.6(3/5)(VID 3L, 4L, 5L), 2 reach -> 0.2(1/5)(VID 2L), 3 reach -> 0.2(1/5)(VID 1L)

src/test/kotlin/org/wfanet/measurement/loadtest/dataprovider/EdpSimulatorTest.kt line 619 at r1 (raw file):
Previously, matthewclegg (Matthew Clegg) wrote…
Please add a unit test for fullfillDirectReachAndFrequencyMeasurement.

Test is updated in FrontendSimulator.kt

src/main/kotlin/org/wfanet/measurement/loadtest/dataprovider/EdpSimulator.kt line 432 at r1 (raw file):
Previously, matthewclegg (Matthew Clegg) wrote…
I spoke too soon as well.  Each event needs to be labeled by its eventId, not by its eventGroupKey in the formulation I gave.  Suppose we have two publishers A and B, and each event is represented by a pair (e, v), where e is the event ID and v is the VID.  Example data might be as follows:
A: (1, 1), (2, 2), (3, 3), (4, 1), (5, 2)
B: (1, 1), (6, 3), (7, 4)
Then, the pipeline should proceed as follows:
(1, 1), (2, 2), (3, 3), (4, 1), (5, 2), (1, 1), (6, 3), (7, 4) ->
(1, 1), (2, 2), (3, 3), (4, 1), (5, 2), (6, 3), (7, 4) ->
1, 2, 3, 1, 2, 3, 4

@matthewclegg Where do we get eventId from? The eventGroupList looks like this:
Code snippet:
[key: "dataProviders/BNKDQy5gCHs/eventGroups/RDHoadGf-Ig"
value {
  collection_interval {
    start_time {
      seconds:<PHONE_NUMBER>
    }
    end_time {
      seconds:<PHONE_NUMBER>
    }
  }
  filter {
    expression: "video_ad.age.value == 1 && privacy_budget.gender.value == 1"
  }
}
]

src/main/kotlin/org/wfanet/measurement/loadtest/dataprovider/EdpSimulator.kt line 432 at r1 (raw file):
Previously, iverson52000 (Albert Hsu) wrote…
@matthewclegg Where do we get eventId from? The eventGroupList looks like this:

Actually I checked the synthetic dataset and there's a column of event id. So we should be getting event id from eventQuery. I can put a TODO here to implement that later

src/main/kotlin/org/wfanet/measurement/loadtest/dataprovider/EdpSimulator.kt line 432 at r1 (raw file):
Previously, iverson52000 (Albert Hsu) wrote…
Actually I checked the synthetic dataset and there's a column of event id. So we should be getting event id from eventQuery. I can put a TODO here to implement that later

Update the code based on @sanjayvas suggestion

src/main/kotlin/org/wfanet/measurement/loadtest/dataprovider/EdpSimulator.kt line 554 at r5 (raw file):
Previously, stevenwarejones (Steven Ware Jones) wrote…
i don't see any changes

Here's the commit. I add comments in several places
https://github.com/world-federation-of-advertisers/cross-media-measurement/pull/672/commits/ff38336341ab12ea7b1b71a12676a0bbc8da7d46


URI Template test coverage

URI Templates need better test coverage, particularly around matching.

Thanks to some great contributions by @mexx this is not too bad at all now, so closing.


Add host tag to `tags in .ci.yaml targets

Target tags are being used to collect/analyze build stats. Existing host only targets are missing the host tag.
E.g. for Linux gradle_java8_compile_test:
      tags: >
        ["devicelab", "hostonly"]

=>
      tags: >
        ["devicelab", "hostonly", "linux"]

We should add the host tag for all Linux/Mac/Windows host only builder targets.

I want to work on this issue assign this issue to me please

@GautamSharma05 Are u still working on this?
If not I would like to take this one

@GautamSharma05 Are u still working on this?
If not I would like to take this one

No

@keyonghan
I wanted to confirm that we have to add the host tag(Linux for example under Linux) in tags array right ?

Hello! I would like to contribute to this as it is still open. Please let me know

I wanted to confirm that we have to add the host tag(Linux for example under Linux) in tags array right ?

My apologizes for missing this question @vedant-z ! Yes, we want to add the corresponding host in the tags.

Hello! I would like to contribute to this as it is still open. Please let me know
@sdkdeepa I will wait for @vedant-z to confirm if this is still on their plate. If not, I will assign this to you. Thanks for you interest!

Hi @keyonghan, if this issue is still open I would like to contribute. Thanks.

Hi, if this issue is still open, i would like to contribute. Thanks. I am just starting out :)

@keyonghan  Please mark this close.


[Parent,SP roles] If you follow hyperlink-workshop's name from "Заявки" section, information about workshop is displayed incorrectly

Environment: Windows 11, 64 bit
Chrome 117.0.5938.89
Reproducible: always.
Preconditions

Parent has at least 1 child, credentials: login -<EMAIL_ADDRESS>password - Qwert1!
SP has at least 1 workshop, credentials: login -<EMAIL_ADDRESS>password - Qwerty1!
At least one application with any status is in Parent's cabinet.
Log in as Parent

Steps to reproduce

Click on arrow or Last name at top right corner of the page
Select the 'Заявки' line from the drop-down list
Choose any hyperlink-workshop's name in the list of applications

Actual result

Flexbox isn't reproduce
Unable to switch between tabs
https://app.screencast.com/ihb7XI1tZUetg
Expected result

User can switch between tabs
User story and test case links
[Test case]#612

Labels to be added
"Bug", Priority ("High"), Severity ("High"), Type ("Functional")

Bug fixed on backend


Find edges shared between polygons and simplify them individually

@ericfischer this looks interesting, as does the incoming 1.14.4 PR (https://github.com/mapbox/tippecanoe/pull/310)
When you get a moment, could you please cut a GH release for 1.14.3 or, if 1.14.4 is imminent, for that instead? I'll update the Homebrew formula.

Thanks @timiyay! Tagged https://github.com/mapbox/tippecanoe/releases/tag/1.14.3. Hopefully 1.14.4 will be ready soon.


Have a better behaviour with the filters.

https://github.com/jabrena/spring-boot-user-beans/pull/58


Documentation Issue, Dagre positioning unclear!

Describe the Bug
There are two examples of how to layout something, both with sample code:

https://reactflow.dev/learn/layouting/layouting#dagre
https://reactflow.dev/examples/layout/dagre

However, option number 1, has a critical difference from option number two, it is missing the following:
    // We are shifting the dagre node position (anchor=center center) to the top left
    // so it matches the React Flow node anchor point (top left).
    node.position = {
      x: nodeWithPosition.x - nodeWidth / 2,
      y: nodeWithPosition.y - nodeHeight / 2,
    };

This is important because if you copy and past the code from option number one, you probably won't realize there is an issue until much later on.
I would suggest
Thank you for such an awesome library!
Your Example Website or App
No response
Steps to Reproduce the Bug or Issue
Go to the docs and see that the example for here https://reactflow.dev/learn/layouting/layouting#dagre has a bug that is addressed here https://reactflow.dev/examples/layout/dagre
Expected behavior
the code example should have the fix:
    // We are shifting the dagre node position (anchor=center center) to the top left
    // so it matches the React Flow node anchor point (top left).
    node.position = {
      x: nodeWithPosition.x - nodeWidth / 2,
      y: nodeWithPosition.y - nodeHeight / 2,
    };

Screenshots or Videos
No response
Platform
NA
Additional context
Thank you!

Yep keeping these two consistent is definitely better, thanks for the heads up!


Add preset save button #118

This PR includes the complete preset feature set.
You can now create and select presets, which are stored inside the backend

(The dropdown list is just empty because of not running backend during the screenshot)

This PR is still a draft :) So you probably checked out a work in progress.
It should be fixed now, I only need to fix the test cases

I see, sorry. I thought you already want it to be reviewd :)

I cannot close your conversion.


[Feature Request] New side Panel (tab) look-and-feel for embedding the new Segmentation mode panels

What feature or change would you like to see made?
The new side panels should follow the design from @dan-rukas as presented below...

Left panel (tab) design to follow later.
Why should we prioritize this feature?
A better user experience and consistent design with the new Segmentation mode sub-panels.

PR #3657


Disable 2fa button

2fa buttons for disabling if not able to login

Option to disable 2fa if one has lost their personal 2fa codes via the Google authenticator app disable button allowing a user access to the platform for a confirmation to email and telephone for security it's not possible

@brunoski1 let me know if you need the 2fa disabled, I'll also ask the dev working on the website about possible solutions to this problem.

Dear MonyX team,
I have also lost my mobile and do not have a backup of the 2fa code. My MonyX account in<EMAIL_ADDRESS>Can you please help me as well with disabeling 2fa for my account.

@brunoski1 done

Thanks!


Added a new class TargetReturnMinimumVariance which calculates the minimum variance portfolio for a given target rate of return.

There are conflicting files in the PR, this happens when you changed something from the original code instead of adding new code that doesnt break the old one

Fixed it, somehow there was a new class in the middle of my PR, which then broke my earlier class. This class is not visible on my local repository, so I don't know how it got there :D


Deprecate public window.qt_viewer (remove in 0.5.0)

Description
This PR closes #1878 and closes #3066 ...
It puts a FutureWarning on public access of viewer.window.qt_viewer, and slates it for removal in 0.5.0.
While the QtViewer class itself is certainly still open for use by third parties (e.g. PartSeg uses it directly maybe?)... napari's viewer.window.qt_viewer should be considered an implementation detail of the napari application, and was never designed for "public consumption".  Making this private will allow us to develop and improve the napari application with less fear of breaking patterns (i.e. you know if you're using a private attribute that it's a bit risky), and there's been general support for this (at least from @sofroniewn, @jni, and myself) for quite a while.  Specific hooks will be made available to add things like menus via plugins and npe2.
Type of change

[ ] Bug-fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

References

How has this been tested?

[ ] example: the test suite for my feature covers cases x, y, and z
[ ] example: all tests pass with my change

Final checklist:

[ ] My PR is the minimum possible work for the desired functionality
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] If I included new strings, I have used trans. to make them localizable.
For more information see our translations guide.

fails here are unrelated

oh shoot, i was supposed to wait to merge this until we fixed examples. sorry @jni @tlambert03 - complete memory fail. i saw @jni approve and i just went for it. i think it's ok to press on, i just saw #3765 which reminded me

No worries, will follow up


route query string

Hi,
Im trying to test fermyon/spin-sdk with ts but i cannot find any document about routing and query string samples.
I just see that sample in js routing page,
localhost:3000/home/param
but i need this
localhost:3000/home?param1=value1&param2=value2.....&paramN=valueN
i need query string routing and handle the params.. i saw itty-route link on there too.. but its not working with spin-sdk
have any sample or solutions for that?

Good question.  @karthik2804 Do you know if the query object on the itty-router Request needs to be plumbed through the SDK?  Or should it work already?

Hey @rhcndrsn you can find a full-fledged CRUD implementation using different capabilities from the router at https://github.com/fermyon/enterprise-architectures-and-patterns/tree/main/http-crud-js-sqlite.
On top of those could you elaborate a bit about the query string requirements? It's not 100% clear to me what you wanna achieve:

Do you wanna invoke different handlers based on the presence of a particular query string parameter?
Do you wanna access query string parameters within a handler?

Hi,
actually i need the query parameters for filtering the data. I mean, if i asking localhost:3000/users page and i want to filter them with params;
localhost:3000/users?age=30&location=Turkey
like that. I hope i can tell what i need.
thank you,

Thanks for coming back to this one @rhcndrsn
You can access the query string from within your Spin App. When adding your handlers to the Router.
With the recently released new JavaScript SDK for Spin (see https://www.fermyon.com/blog/introducing-the-new-js-sdk)
This could look like this
import { Router } from "@fermyon/spin-sdk";

const router = Router();
router.get("/users", ({ query }, _, res) => getUsers(query, res));

export async function handler(req, res) {
    return await router.handleRequest(req, res);
}

function getUsers(query, res) {
    console.log(`Received query string: ${JSON.stringify(query)}`);
    res.set({ "content-type": "application/json" })
    res.send(JSON.stringify({
        baz: query["foo"]
    }));
}

Although the part of pulling values from the query string is hardcoded, you can see how the value of foo (from the query string) is pulled and sent back as the value of baz. This would result in the following
curl -iX GET http://localhost:3000/users\?foo\=bar
HTTP/1.1 200 OK
content-type: application/json
content-length: 13
date: Mon, 12 Aug 2024 09:05:43 GMT

{"baz":"bar"}%

@rhcndrsn I'll close this issue. Feel free to open it again, if you've further questions in regards to accessing query parameters using the Spin SDK for JavaScript.


Keymapping issues with ctrl+z VSC

I am having issues with my Undo, Key Mapping function. It's default is ctrl+z which is exactly what I want but the shortcut key does not work. The same goes for the Redo key (which is ctrl+y/ctrl+shift+z). When i tried remapping the key, it does not even let me type in ctrl+Z respectively. I am able to type them separately, but when i try together it does not work. My ctrl+Z function works with literally every other application i have, so its not a keyboard issue.
FYI, my installed extensions are; Jupyter, Jupyter Keymap, Jupyter Notebook Renderers, Live Server, Pylance, and Python. I've already tried disabling Jupiter Keymap to see if that was the issue and it didn't make a difference
I've looked everywhere for an answer but no solution has been appropriate for me. Any help will be appreciated. I really don't want to have to switch to a different editor.
Below i have also attached the Developer: Inspect key mappings for review.
Dev Kep Mapping Inspect.txt

@alexdima any help

Could you please try the following:

Run the command Developer: Toggle Keyboard Shortcuts Troubleshooting
This will activate logging of dispatched keyboard shortcuts and will open an output panel with the corresponding log file.
Press exactly the keybinding you desire.
check what VS Code detects and what command is invoked.

If you are having trouble understanding the output, please feel free to paste here and I can try to help.


[Parse Server] clientKey is optional if using Parse Server

A client key does not need to be configured in order to deploy a Parse Server. The Parse JavaScript SDK's Parse.initialize() method, however, requires a client key to be passed in. This parameter should be made optional.

Actually, I just walked through the network path for the SDK, and it looks like the parameter is already optional from an operational perspective

Yes, I think you can initialize the SDK with a blank string as the client key, but having a initialize() method that does not even have that parameter would make for nicer Getting Started examples.

So, is this just a docs / docblock change? initialize('x') is the same as initialize('x', undefined), which is supported / doesn't throw. Unlike the other platforms, I don't think we need a change here.

Updated in 9095e346edd06632cc755fafd377d930b81762df :)


push live

Docs Build status updates of commit 250a495:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/templating/content/2019-08-01-12-08-13.png
:white_check_mark:Succeeded

AdaptiveCards/templating/content/2019-08-01-13-58-27.png
:white_check_mark:Succeeded

AdaptiveCards/templating/index.md
:white_check_mark:Succeeded

AdaptiveCards/templating/language.md
:white_check_mark:Succeeded

AdaptiveCards/templating/sdk.md
:white_check_mark:Succeeded

AdaptiveCards/templating/service.md
:white_check_mark:Succeeded

AdaptiveCards/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Docs Build status updates of commit 52cd081:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

AdaptiveCards/templating/content/2019-08-01-12-08-13.png
:white_check_mark:Succeeded

AdaptiveCards/templating/content/2019-08-01-13-58-27.png
:white_check_mark:Succeeded

AdaptiveCards/templating/index.md
:white_check_mark:Succeeded

AdaptiveCards/templating/language.md
:white_check_mark:Succeeded

AdaptiveCards/templating/sdk.md
:white_check_mark:Succeeded

AdaptiveCards/templating/service.md
:white_check_mark:Succeeded

AdaptiveCards/toc.yml
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


Context is read by components regardless of contextTypes definition

Consider the following, simplified example:
class NotGonnaRead extends Component {
  render() {
    return (

My favorite color is {this.context.favoriteColor}

    );
  }
}

class WillRead extends Component {
  render() {
    return (

My favorite color is {this.context.favoriteColor}

    );
  }
}

WillRead.contextTypes = {
  favoriteColor: PropTypes.string,
}

class FavoriteColorProvider extends Component {
  getChildContext() {
    return {
      favoriteColor: 'purple',
    };
  }
}

If we render it like so:
<FavoriteColorProvider>
    <NotGonnaRead />
</FavoriteColorProvider>

then the output is going to be My favorite color is .
Rendering this, however:
If we render it like so:
<FavoriteColorProvider>
    <WillRead />
</FavoriteColorProvider>

will correctly output My favorite color is purple.
Current behavior
If we would like to test if NotGonnaRead component is behaving properly (which it isn't), we would need to do something along the lines:
shallow(
  <NotGonnaRead />,
  { context: { favoriteColor: 'purple' } }
);

This will render
My favorite color is purple
.
Expected behavior
This example should render
My favorite color is
 as contextTypes are not correctly defined.
Your environment
API

[x] shallow
[ ] mount
[ ] render

Version

library
version

Enzyme
3.3.0

React
16.2.0

Adapter

[x] enzyme-adapter-react-16 1.1.1
[ ] enzyme-adapter-react-15
[ ] enzyme-adapter-react-15.4
[ ] enzyme-adapter-react-14
[ ] enzyme-adapter-react-13
[ ] enzyme-adapter-react-helper
[ ] others ( )

This is probably related to #664 - but may also be distinct.
It's possible that enzyme isn't filtering context by contextTypes, but I'd also expect React to do that for us. Can you check in react 15, and see if the same thing occurs?


[pool-manager] Solve how to query native decimals (this is needed for the stableswap though, ship without it in v2 if not possible to do it in a decentralized way?)

For the stableswap, it is needed to know the decimal places of the tokens.
Factory tokens can register metadata, in which case you could extract it from there. Otherwise, you can't.
Native tokens on the other hand, could or could not have metadata attached to it. If so, the DenomMetadata returns an error.
Alternatively, one could have a contract registering all the decimals, but then it needs to be gated. Perhaps a dao could own that? the migaloo gov address so people would vote for it on chain? But if so, how to do in other chains? 😓

Great idea, let's allow the user to pass the decimals itself on create_pair.


Depend on supported node engine for ES6

I updated uglifycss to 0.0.28 on an engine which does not support ES6, would be good to add that dependency to packages.json.
See https://docs.npmjs.com/files/package.json#engines

Thanks for catching this


Add experimental path to use transformer dialect only in the codegen

Add a new option so that we can run transformer dialect after tile and
distribute on workgroup. This allows bypassing the problem of setting
the number of workgroups. For now we just pass a tile size through
command line.
This will then allow writing transform dialect pipelines decided by
KernelConfig. Later the transform dialect can evolve to do the tile and
distribute to workgroup.

This is a little bit of a hack. If you really want to go down this path, thats fine, but this is probably very short term....

Yes, definitely a hack. That would allow me to get the first step to have some transformer based codegen we can use by default though. Once we can replace TileAndDistributeToWorkgroup by a transformer based conversion we can remove the flag.
What do you think? Do you see a better way?

Then even the first level tile + distribute (with interchange, etc.) can be handled through the transform dialect. If you want this for short term evaluation thats one thing, but this needs to be fixed and if someone can help with it, that would be great.

Yes that makes sense, I was proposing that mainly to workaround the discussion about computing the number of workgroup causing problems. I believe Nicolas has plan to be able to use foreach_thread at the workgroup level along with the transform dialect, that would remove the need for this workaround.
I'll let Nicolas decides what he thinks is the best next step. I don't have a strong opinion as long as there is a way for me to use transforms for codegen only.

Let's have something that we can iterate on.
Atm the alternative is https://github.com/iree-org/iree/pull/10131 which is still flagged as having issues.

Then even the first level tile + distribute (with interchange, etc.) can be handled through the transform dialect.
This is what https://github.com/iree-org/iree/pull/10131 does but the materialize the code for workgroup count calculation is still missing. I do not have a good comprehension of the assumptions of the linked code and how things connect to values passed to stream.dispatch.

At this point I consider that these 2 PRs narrow down the problem significantly (i.e. this does not have tiling happening at the Flow level) and we'll need @MaheshRavishankar to dig in to bring this home and spell the Flow / Transform Dialect Codegen boundary the way he thinks it should be.

Let's have something that we can iterate on.
Atm the alternative is #10131 which is still flagged as having issues.

Then even the first level tile + distribute (with interchange, etc.) can be handled through the transform dialect.

This is what #10131 does but the materialize the code for workgroup count calculation is still missing. I do not have a good comprehension of the assumptions of the linked code and how things connect to values passed to stream.dispatch.
At this point I consider that these 2 PRs narrow down the problem significantly (i.e. this does not have tiling happening at the Flow level) and we'll need @MaheshRavishankar to dig in to bring this home and spell the Flow / Transform Dialect Codegen boundary the way he thinks it should be.

Ok, if this is on my plate, I'd rather get this out of the way sooner rather than later... I havent blocked this PR, neither have I blocked the other PR (which really I didnt even get a chance to review before it landed, but thats secondary).. Personally I am having trouble following the cadence of things here since they are various different things being done in ways I cant fully connect to what the end state being worked towards is. I'd really appreciate if I am given a starting point to start digging into this, it will just be much faster for me.  If the pointer is just "start from the test" then that's what I will do from next week.
Just to clarify, there is no grand vision on the boundary between Flow/Transform DIalect/Codegen boundary. Anything within hal.executable.variant is within what can be part of Transform dialect. Anyone working in IREE should be able to connect the pieces. Like everyone here, I am over-subscribed too. I was trying to avoid dropping everything else (which also need to land) to prioritize this, but if that needs to be done, then I can look into it next week.


Add new Slack link (and perhaps autoinvite link)

We have a new slack team name and auto-invite link...
https://openwhisk-team.slack.com
auto-invite: https://csantanapr.github.io/openwhisk-slackinvite/

Ah, great @mrutkows.
Was just about to open a similar issue when I found yours.
I assume we will also fix the link the Slack icon at the very top of our site currently points to with this issue as well?

I proposed we move the url and repo to OpenWhisk Organization, This will change the url from https://csantanapr.github.io/openwhisk-slackinvite to => https://openwhisk.github.io/openwhisk-slackinvite

In case someone wants me to apply changes to the NS just let me know.

@nauerz-ibm I think would be nice to have slack.openwhisk.org map to => https://openwhisk.github.io/openwhisk-slackinvite in the NS

Will make this happen asap and let you know once done.

Can it be configured in a way that the url sticks on slack.openwhisk.org and it doesn't show  the full url with github.io?

@nauerz-ibm I think since our main host openwhisk.github.io is already configured with CNAME for openwhisk.org, then any our repos the gh-page will be published to openwhisk.org/$repo
In this case the new Slack Invite Location is
https://openwhisk.org/openwhisk-slackinvite/
If I use http and routes to https for some reason.
This cause a problem since we don't have ssl certs in place to serve https properly
Currently we serve the main host over http://openwhisk.org/

@jlengstorf do you know how can serve http instead of https http://openwhisk.org/openwhisk-slackinvite ?
Maybe just adding the CNAME in the repo?

Nevermind this is working now, I think it was my browser acting up http works
http://openwhisk.org/openwhisk-slackinvite

OK last Try I think I got, since I think @nauerz-ibm did the CNAME change
This is the link
http://slack.openwhisk.org

I view the invite link as a convenience, should we not just supply the actual link to the Slack team?  i.e., http://openwhisk-team.slack.com (sign in page, also has a "Create account" link)

@mrutkows I having slack.openwhisk.org is better and more open anyone can join, and we don't have to manage the email domains that are allowed to join.
The current Slack icon link I think it should take people to slack.openwhisk.org
The email they get from Slack, will guide them to create a Slack account if they don't already have one.
But again I don't have any problem if you want to add the link to http://openwhisk-team.slack.com in slack.openwhisk.or or in the main site. Just want to avoid someone trying to join and hitting the link and they can only join if they have an email from the current whitelist.


added better stemming support

Based on http://wiki.apache.org/solr/AnalyzersTokenizersTokenFilters#Stemming

Thanks John! Looks like we should just cherry pick 791c2f965d7822b087062a4873d1dd25bf8090df from this pull request, right? The other commits look unrelated and unmergeable.
@hafriedlander This only works with Solr 4.3 onwards, which was released over two years ago. I know we have a Solr3Service class in the codebase, but don't declare specific Solr version support anywhere. Should we drop support for Solr releases prior to 4.3? What version are we running in CWP?

That's correct. Note that the update only applies to the solr 4 conf file so won't break anyone running 3.
Sent from my iPhone

On 5/05/2015, at 11:31 pm, Ingo Schommer<EMAIL_ADDRESS>wrote:
Thanks John! Looks like we should just cherry pick 791c2f9 from this pull request, right? The other commits look unrelated and unmergeable.
@hafriedlander This only works with Solr 4.3 onwards, which was released over two years ago. I know we have a Solr3Service class in the codebase, but don't declare specific Solr version support anywhere. Should we drop support for Solr releases prior to 4.3? What version are we running in CWP?
—
Reply to this email directly or view it on GitHub.

Do you want me to redo this PR will just that commit? Or happy to cherry pick @chillu @hafriedlander ?

@pitchandtone If you can open a new PR with just that commit, that'd be most helpful to allow discussion around it, thanks

Yeah agree that a new PR is easier - it means we can see the tests passing without having to run them locally.


Creating subcommands

Hi,
Thanks for a very useful tool!
I can't seem to figure out how to create subcommands like $ docker container rm <containerName>.
If i try adding the path: /container/rm/{containerName}, the command will be created as $ docker container-rm <containerName>
This is the first time that I am using both OpenAPI and this tool, so I am in no way an expert.
Thanks!

@AhmadHamid looks like your use case could be fulfilled by this PR: #32 </shameless plug>


Avoid having to create custom entry point just to specify cli name and version

:tada: This issue has been resolved in version 1.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


how to set charset of generator:execute?

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

Go to '...'
Click on '....'
Scroll down to '....'
See error

Expected behavior
A clear and concise description of what you expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):

OS: [e.g. iOS]
Browser [e.g. chrome, safari]
Version [e.g. 22]

Smartphone (please complete the following information):

Device: [e.g. iPhone6]
OS: [e.g. iOS8.1]
Browser [e.g. stock browser, safari]
Version [e.g. 22]

Additional context
Add any other context about the problem here.

Setting charset is currently not supported, this will be considered as an argument in the next version.
By the way, does this issue solved? #3


Allow blank password with username option (resolves #285);

As discussed in https://github.com/Topshelf/Topshelf/issues/285.

Cherry-picked into develop. Thanks!


cksum/hashsum: refactor the common code.

Summary of the change:

Move the common code into checksum
Create a structure HashAlgorithm to handle the algorithm (instead of the 3 variables)
Use the same function for cksum & hashsum for --check (perform_checksum_validation)
Use the same for function for the hash generation (digest_reader)
Add unit tests
Add integration tests
Fix some incorrect tests

Sorry for the big commit but as you can imagine, it wasn't possible to split it :(

@cakebaker it is ready for review. :)
thanks

Good work :)


Different Convention in Docs & Repo

The DialogFlowDocumentation referenced in this repo uses a different convention when naming variables than this codebase does.
As a developer, I became frustrated at the docs when I couldn't debug my errors and had to go to the source code itself to find my solution. Wouldn't it be better for the docs & the codebase to show the same information?
The difference in convention is that the documentation uses snake_case while the codebase uses camelCase.
Examples:
entity_type is actually entityType in the code.
user_defined is userDefined in the code; and display_name is displayName
There are many others

Hi the RPC docs are general docs for the API in general across languages rather than specifically for Node.js


Fix saving and exporting in Pale Moon

Saving and exporting does not work in Pale Moon browser due to mxXmlRequest.simulate not working. Apply the same workaround as already done for Safari.
See: https://forum.palemoon.org/viewtopic.php?p=135614#p135614

Thanks for the submission. The mxclient change would actually go in the core project, in Bitbucket, that's the built mxclient.js.
The reason for determining browsers by user agents is legacy. We've set a bad example here by doing it, so we shouldnt really complain when PRs do it. However, I'd love to see this done as a capability check, instead. Maybe it can't actually be done, but I'd prefer it to be tried before we resort to this method.

Thanks, this will be fixed in the next release.


Add support for AbstractBufferedFile for PDF filenames

Description
The FP attribute can be either a TextIOWrapper or a AbstractBufferedFile. The first has the name attribute, but the latter does not, causing an error
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes #12173
Version Bump?
Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

[x] Yes
[ ] No

Type of Change
Please delete options that are not relevant.

[X] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

[ ] Added new unit/integration tests
[ ] Added new notebook (that tests end-to-end)
[ ] I stared at the code and made sure it makes sense

Suggested Checklist:

[X] I have performed a self-review of my own code
[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added Google Colab support for the newly added notebooks.
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[X] New and existing unit tests pass locally with my changes
[X] I ran make format; make lint to appease the lint gods

Hey @thiagosalvatore sorry, I just realized I merged a very similar fix
https://github.com/run-llama/llama_index/pull/12186
Going to go with that, but if something is missing, please do open another PR


Use local hook for ESLint pre-commit

Fixes

Fixes #2200 by @sarayourfriend
cc @dhruvkb who was involved in the original discussion that prompted that issue.
Description

Includes moving ESLint dependencies to the workspace root and hositing all configurations (except the test/unit one, as it is covered in a separate PR) into the root configuration. This also prepares for ESLint "flat config" changes as it unifies the configuration in a way that more closely mirrors how the flat config works. Hositing ESLint configuration to the root along with its dependencies removes the burden of ESLint dependencies on each individual package (if we add additional packages, but also in automations, which does not define any eslint dependencies despite having a "root" config that extends the parent root configuration [which works separately from how ESLint merges cascading configurations]) and makes it possible to share a single ESLint configuration for all JavaScript in all our projects without ever needing to duplicate dependencies or configuration variables.
Testing Instructions

Run just lint eslint locally. CI should pass. ESLint rules should continue to be picked up by your editor if you have them configured and show correctly in the expected places (i.e., overrides should be working).
Checklist

[x] My pull request has a descriptive title (not a vague title likeUpdate index.md).
[x] My pull request targets the default branch of the repository (main) or a parent feature branch.
[x] My commit messages follow best practices.
[x] My code follows the established code style of the repository.
[N/A] I added or updated tests for the changes I made (if applicable).
[x] I added or updated documentation (if applicable).
[x] I tried running the project locally and verified that there are no visible errors.
[N/A] I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

This should probably get merged (and rebased) after #2199 so that the ESLint configuration can be fully merged once this PR is applied. I'll leave this as a draft until then.

Thank you for working on this! To be honest, I find the current configuration very complicated and difficult to understand, so this is a great improvement.

I think the FlatConfig will be a big improvement. Needing to juggle between passing explicit files to include in the command line, plus overrides, plus the displaced eslintignore file is all very confusing! With FlatConfig I think we'd be able to more easily just apply rules to specific directories we actually want ESLint running in rather than having to use three different methods to specify where we want what rules to apply.
I'm pushing one more change to this PR to add some of the root JS configuration files, but otherwise I will merge as is.


Script installation on OCP

Nice! Maybe down the road we factor out the common stuff into a shared, sourced script?

Definitely. I just wanted to start simple and don't mess up your stuff


Document 'ref' folder

Please document how and when a 'ref' folder is used for providing reference assemblies, especially when AnyCPU 'ref' assemblies must be provided with both x86 and x64 assemblies in the 'runtimes' folder.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f35f4267-e5e3-ddcf-d3e4-479fb233ce9f
Version Independent ID: 6d49d66f-f777-7e44-3a45-723e3ad09a59
Content: How to create a NuGet package
Content Source: docs/create-packages/Creating-a-Package.md
Product: nuget
GitHub Login: @karann-msft
Microsoft Alias: karann

Appears to be fixed in #7316


Errors when running "Desktop" tweaks on windows 11

Describe the bug
When I run the tool on a Windows 11 machine and I choose the "Desktop" tweaks to be applied, I get a message saying that the tweaks were applied, however I see some errors on the console.
To Reproduce
Steps to reproduce the behavior:

I open PowerShell 7 in Administrator Mode
I run iwr -useb https://christitus.com/win | iex
Click on the Tweaks on the left bar
I select and apply the "Desktop" tweaks
I get a message saying that tweaks are finished, but there are some errors in PowerShell (see win-tweaks.txt for the full PowerShell output).

Expected behavior
The command to not run with any errors.
Screenshots

Additional context
OS: Windows 11
Terminal: Windows Terminal (Version: 1.13.11432.0)
Shell: PowerShell 7.2.5 (in Admin Mode)
I was also able to reproduce the bug just opening PowerShell in Admin Mode without Windows Terminal.

I have t he same issue too, but on windows 10

You can ignore these errors for now, but I will address this in my next update as they are harmless.

Fixed in latest update


Add Dependabot updates

Just adds a basic Dependabot config to check for npm package and GitHub Actions updates daily (although there's no GitHub Actions here yet!). Creates PRs, etc.
See: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates

Hmm... looks like I got this PR wrong because it's to merge master from my fork rather than a branch that contains just the change so it consists of both PRs... 🤔


FORGE_DB_CREATION_REQUIRED unclear

I've set this to 'true' but it's never making a new database.
It seems that it might only do it when a site is first created, which... OK.  I can deal with that, except, it's not creating a database even on a new site creation.
And... there's no guidance on how the new site's database name, user and password would get injected in to an .env or somehow passed to the new site config area.
I'm expecting that each site-per-branch created would have a new database created, with a corresponding randomized(?) user/pass that the new site needs to know about.
Unfortunately, I can't get this to work yet.  I don't think this is just me not understanding docs yet, but I'm happy to be wrong.  Thanks.

You're right, each new site should automatically have a new database, with the credentials inserted into the .env file.
This issue appears to be connected to issue #24, and the database creation process should now be functioning properly (I would give it a test in a short time and getting back to you soon).
I understand the documentation needs to be more transparent, and I'm committed to enhancing it this week for improved clarity. Thanks for highlighting this matter.

I don't think the db creation is directly tied to #24 but... maybe it is?  It's a bit hard to follow all this at the moment, but I will run a test tomorrow.
BTW, thanks for the patience in my learning.  I've done this sort of branch-per-pr before, more as a set of scripts in a forge deployment triggered by the URL, not using the forge SDK.  I think this approach is generally a bit cleaner, but i'm hitting these stumbling blocks.  :)

Today finally got the chance to test out the provision command, and I confirm the DB CREDS have got inserted to the ,env successfully.
With enhancement PR I created today, it shows the validation error messages 🚀, while replacing those long stack-trace with a more clear one. ⚡🛠 Could you please review it?. I'd appreciate your insight and am open to adding you as a contributor.

I'm pleased to see this tool being utilized since its beta release.
Today, I finally had the opportunity to test the 'provision' command and can confirm that the database credentials have been successfully inserted into the .env file.
Reviewing a sample of your env keys might help me identify the issue more quickly.

I was seeing that keys were being created/merged, but the process doesn't always seem to trigger.  If there are no 'envkeys' to merge, the merging is skipped (or so it seems).  Was getting a bit lost in this today.

Got it! An early return due to missing envKeys could be the culprit. Let's address that.

I would probably write required tests for this process later as well, but with the new changes, I made sure it inserts the DB CREDS to the .env whether any value exists for envKeys or not. 🚀
I would be happy to help further in case there was any related issue left here.


feat: add rotate logger support

rotate logger support added after certain days
/claim
#775

Read the issue carefully before submitting the changes.
I ma sorry, but this is not we are looking for


Dropdown accessibility considerations

meta-issue to discuss some of the points raised by http://www.slideshare.net/maxdesign/front-end-frameworks-are-they-accessible/45

Problem 1: [...] there is often no assistance given to explain what they are being asked to do (such as choose from a range of options) when they arrive at the button

this will depend on specific use/context. if the dropdown is used for navigation, it should be fairly self-evident what the user can do. if it's more like application menus, titled in a similar way (e.g. "View", "Edit", "Help"), again it should make sense. It would be good to get a specific example in the wild of where this is not the case...but also, there's probably little advice we can give/example we can create beyond "make sure the trigger for your dropdown makes sense..." which is not something we can mandate at framework level.

Problem 2: these elements are announced as buttons, so Screen Reader users often assume these are action orientated.

And they are - the action they perform is to open/close the dropdown menu?

However, when these buttons are activated, Screen Reader users are then presented with silence. There is nothing to tell them that the dropdown has now visually opened...

Depending on screen reader, the change in aria-expanded from false to true will be communicated. Also, the presence of aria-haspopup should have already had some effect in the way the button was announced to indicate it has a menu.
However, the proposed solution of moving focus to the first item when the dropdown is opened is good...for keyboard users. For mouse users, it may look odd, and doesn't match known behavior of something like an actual application menu. May require different code paths for "opened with a mouse" vs "opened with keyboard", which gets ugly. May need to make a proof of concept to see how jarring it may be.

Problem 3: for keyboard-only users, these dropdowns look similar to select menus, however the dropdown options cannot be accessed by standard select menu keystrokes - like the arrow keys

Although we're not strictly following this pattern, it may be worth adding functionality that opens the menu also for up/down arrow (a la http://www.w3.org/TR/wai-aria-practices/#menu). Once we go down this road, though, other similar keyboard interactions typicially associated with ARIA menus (like arrows to move between menu items etc) will probably also be expected ... but we shied aways from the pattern as dropdowns can be used for things that aren't just traditional ARIA menus.
I also wonder how prominent a problem this would be, and likely depends again on specific implementation/usage. if the dropdown is part of a navigation bar, users likely won't think it's a select. if it's added as part of a form though, they certainly may...hmmm

Problem 4: when keyboard-only users activate the dropdown, then tab through the dropdown, the dropdown remains "open" even after they leave. These dropdowns only close via the button element.

Fair point, something we should address. However, once you try and just prevent user from TAB-ing out, what's to stop them using other means of jumping around the page (if they're AT users, e.g. using landmark navigation or similar)? Do we cater for that as well, or just the simple scenario of non-AT sighted keyboard user? any implications as well for sighted non-AT touchscreen users?

Problem 5: [...] when users choose an item from the dropdown list, this choice is not reflected in the button [...]

So this is more to do with using dropdowns as faked selects? We don't encourage (or even show any examples of) this use, but I don't doubt that some people do (though I think it would need extra third party plugin/custom code to actually work)?

Yeah, not really a framework problem.
Yeah, my understanding was that our aria-* attributes should already take care of the screenreader presentation. As to moving the focus, I've no opinion.
I'll leave this to the experts. :wink:
The slides propose merely closing the dropdown when the user tabs away from it (which I interpreted as "when the user focuses an element that's outside of the dropdown"), not trying to hold the focus hostage. That seems within the realm of reasonable.
Yeah, agreed. The most I could see here is a note like "If you're making this into a <select>, you're opening a can of worms which is beyond our scope. There Be Dragons, but here are some links: [...]"

Closing this, as in relation to 3. we specifically document now that dropdowns are not really ARIA-style menus, and for 4. our dropdowns now close once focus shifts away from them.


net: GODEBUG=netdns=go massive DNS lookups crash w/ "runtime/cgo: pthread_create failed: Resource temporarily unavailable"

This happens on darwin 21d781070cea6001ee541933ed76dc6da96bde4c and doesn't happen on darwin go1.6, and not sure whether darwin-specific issue.
Caution: TestLookupIPDeadline in lookup_test.go is a bad test in bad manner. It generates massive DNS queries to confirm that the net package doesn't create system threads extravagantly. Before testing, you need to make sure whether the flood is acceptable to your circumstances.
When we run go test -v -run=TestLookupIPDeadline -dnsflood -count=10, the expected result is that probably the test may fail but not crash. On tip, TestLookupIPDeadline crashes unfortunately.
# export CGO_ENABLED=1
# go build

# export GODEBUG=netdns=cgo
# go test -v -run=IPDeadline -dnsflood -count=10
=== RUN   TestLookupIPDeadline
(snip)
ok  	net	30.542s

# export GODEBUG=netdns=go
# go test -v -run=IPDeadline -dnsflood -count=10
=== RUN   TestLookupIPDeadline
runtime/cgo: pthread_create failed: Resource temporarily unavailable
SIGABRT: abort
PC=0x7fff84223f06 m=2
(snip)
rax    0x0
rbx    0x6
rcx    0x700000080bd8
rdx    0x0
rdi    0xd03
rsi    0x6
rbp    0x700000080c00
rsp    0x700000080bd8
r8     0x40
r9     0x7fff74c4b1e0
r10    0x8000000
r11    0x206
r12    0xc9001070bc281990
r13    0x30
r14    0x700000081000
r15    0x700000080c58
rip    0x7fff84223f06
rflags 0x206
cs     0x7
fs     0x0
gs     0x0
exit status 2

Not sure the reason why GODEBUG=netdns=go DNS lookups on tip require the functionality of runtime/cgo.

The program requires cgo because the net package is compiled with
cgo support. It doesn't matter the runtime choice is to use the pure
Go resolver.
If the program uses cgo, then Go cannot create threads on its own,
and it must use pthread_create to create threads in order to
cooperate with cgo (actually, dynamically linked programs on
Darwin can't create threads without pthread.)

The problem is, I guess, in go1.6 GODEBUG=netdns=go never invokes C.getaddrinfo and friends via cgo, but looks like tip uses them.

but looks like tip uses them.

Nope, the series of cgoLookup are not called during the test. Who is the main culprit?

Whether the program calls cgo functions doesn't matter.
If the program is built with cgo, then it will use pthread
to create threads.

Okay, I now understand why I'm confused; simply, a) Darwin consumes various kernel resources more than I expect because of probably bridging cosumer thread cancelation stuff and Mach stuff, b) there was no -test.count flag in go1.4 and I used -test.cpu flag when I added TestLookupIPDeadline. There is no big difference about the # of cosumed Ms via runtime.newm between go1.4 and tip. Thanks.


[Bug]-[50]:Table Filter - Removing where clause does not rightly update the input text value but filtered result is fine

Is there an existing issue for this?

[X] I have searched the existing issues

Description
https://user-images.githubusercontent.com/91450662/162014415-d2238737-a184-4563-9c91-d46dd5ad2904.mov
Steps To Reproduce

Drag drop table with some table data
Filter table with some input text
Add one more filter with different input text
Remove 1st filter added
Observe : Where clause input text is now not updated rightly
Expected:  Where clause input text should show respective filter value

Public Sample App
No response
Version
Cloud/Release v1.6.17

Great catch @Aishwarya-U-R 🏅 , we wouldn't have caught it. Probably there are some other items here which are undetected.

Stats

Stat
Values

Reach
50

Effort (months)
0.5

Fixed in PR
https://github.com/appsmithorg/appsmith/pull/16904