I pulled the Docker image and used it, but I can not synchronize the wallet.

Hello. Please do not hesitate to contact me because my private network connection is not good.
I docker pull  Ver: 0.8.3 image and use it.
https://hub.docker.com/r/cityofzion/neo-privatenet?ref=login
After I run the image, I copy the local Smart contract to the container and erase the old block chain data.
docker cp localFilePath / compileSmartContract.avm neo-privatenet: /neo-python/filename.avm
rm -rf /root/.neopython/Chains/privnet*

Then start the interface with the neopy command.
When opening the wallet with the following command and checking the wallet with the wallet command, it seems that it is "percent_synced": 0 "and it is not possible to synchronize the wallet.
open wallet neo-privnet.wallet
Progress of PriveteNet is displayed as 1/1.
If you connect immediately after PC start up, you may be able to synchronize well in rare cases.
Do you know for why this phenomenon is caused? Thank you very much.

neo-python ver: 0.8.3
Docker Desktop ver: Version <IP_ADDRESS>-win81 (29211)
OS: Windows10

The docker image you refer to is not neo-python, but a private blockchain docker image. I don't know why it includes neo-python in the image, but it is not neo-python version 0.8.3 but 0.8.2.

(venv) Eriks-Air:neo-python erik$ docker exec -it neo-privatenet /bin/bash

Consensus nodes are running in screen sessions, check 'screen -ls'
neo-python is installed in /neo-python, with a neo-privnet.wallet file in place
You can use the alias 'neopy' in the shell to start neo-python's prompt.py with privnet settings
Please report issues to https://github.com/CityOfZion/neo-privatenet-docker

root@2ccf9742661a:/neo-python# cat /neo-python/neo/init.py
version = '0.8.2'

With the limited neo-python resources we have at th moment I cannot spent time on debugging 0.8.2 issues. My recommendation is to install neo-python 0.8.3 from git and connect that to your private network by running e.g. np-prompt -p. If you insist on using a docker image then pull 0.8.3 from here https://hub.docker.com/r/cityofzion/neo-python/

@ixje
Thank you for your kindness.
I'm sorry, apparently I seem to have made a mistake in the place.
Report it to the following URL.

https://github.com/CityOfZion/neo-privatenet-docker

Thank you very much.

No problem. If the 0.8.3 version gives you problems, please report them and I'll try to help/resolve.


[Removal]: Joyful Cedar Armadillo

Hotspot Name
Joyful Cedar Armadillo
Hotspot b58 Address
11rrnpFy66e2NiHABfGBd7wVFkjWfNMhEwZ8VZty1Nrm7dJTkhh
Discord Handle
ukfab#3739
Hotspot Manufacturer
senseCAP
Removal Reason
I purchased 21 Sensecap miners from a secondhand seller thru Fbook. Seller was migrating to US and those miners were not fit for USA region hence he wanted to sell it quick and at reasonable price. He was very convincing and there was no obvious reason for me to doubt.  Ofcourse there was some delays but he delivered all miners. At the time of purchase I thought it was plug and play thing. All looked legit and right.  so I brought them and paid in full ( see bank Transaction). Seller assured me that he will help me set up and it is easy to understand.  After the setup provess and installing, I started looking to how to use helium and went to exploere and it was a shock to see that  all HS are on denylist. I when thru the set up and installed antennas too but as there was no earning happening so I looked further into it and realised that I am fooled and now seller is not responding at all.  would request you to removed these HS from denylist. I am happy to give evidence that each of the HS is physically insta
Modifications
No
Extra forwarders
No
Extra antennas
No
Additional Information
Physical images of miner and antenna

interesting, why you have a box attach the antenna? what is the function of that?

the box is used to put miner inside it and to weather proof it.  i can send you image of the installation and any other details required. thanks

I don't think he is moving, just to throw useless hotspots that have been caught cheating.

We have taken into account this removal request in the next iteration of the denylist. It may take some time before it's processed. This is an automated comment due to the volume of addition and removal requests. A future tool is in the works to provide more insight into the analysis approach made by the Helium team and community members that maintain this list.


[bug] No "currentValue" update when Fibaro Roller Shuter FGR223

Hi,
I am migrating from openhab zwave implementation via zwave2mqtt to zwavejs2mqtt (I was pointed to here via an other issue).
My environment:
I am running zwavejs2mqtt ("patched" dev image see #15) in a docker (podman) container on my linux pc.
For testing purposes i've removed one of my Firabro Roller Shutter 3 units (FGR223) from the wall and put it next to me.
I have a Aeotec Z‐Stick Gen5 USB Controller, and paired to only one FGR223 for the moment.
My problem:
No 38/1/currentValue update when movement stops when:

I send a level request to the "zwavejs2mqtt/2/38/1/targetValue/set" topic i only get one position update back in the "zwavejs2mqtt/2/38/1/currentValue" topic when movement starts.
I send a UP or DOWN or STOP (false) to the corresponding topics, i also don't see a current value beeing reported (also no update when movement starts).

See logs:

Level change from position 99 -> 80 -> 60 -> 40, the next level request is send some seconds after i hear the relay click to stop.
99-80-60-40.log

Sending "UP" and STOP to the UP topic.
log-up-stop.log

My analysis:
My feeling is that this might be a OpenZwave issue since it seems like the same behavior i have in openhab (not sure if that is actually OpenZwave, but looks pretty similar with the zwave-xml files), but never the less.
Or maby the device just not reports when it is done, but do see a electricity report update after a second or two after the relay clicks.
Question:
I was also wondering if there is an work-around available by the means of a "/get" on the topic so that the controller will re-request the value from the device.
Why, because if i restart the zwavejs2mqtt container, i do get the correct value in the currentValue topic.
Thnx!

My feeling is that this might be a OpenZwave

zwavejs2mqtt does not use OpenZWave.

Level change from position 99 -> 80 -> 60 -> 40

14:44:49.381 DRIVER « [Node 002] [REQ] [ApplicationCommand]
                      └─[MultiChannelCCCommandEncapsulation]
                        │ source:      1
                        │ destination: 0
                        └─[SupervisionCCReport]
                            session id:          35
                            more updates follow: false
                            status:              Fail
                            duration:            [Duration: 0seconds]

I didn't see a single SupervisionCCReport that had status Success in that log, so something is fishy. Might be worth to request an update in the failure case too - the driver doesn't do this yet.

Sending "UP" and STOP to the UP topic.

AFAIK with StartLevelChange it is not possible to get automatic reports when the level change is completed. For StopLevelChange, it could make sense to request an update after the success report.

zwavejs2mqtt does not use OpenZWave.
Ah good to know!, i do like the new log format as well.

From the zwave2mqtt issue:

That's Roller Shutter 3, isn't it? AFAIK it should be controlled with the Supervision CC which lets us know when the motor has stopped. If that's not working, something must have broken it, because it 100% worked a while back.

And this issue:

I didn't see a single SupervisionCCReport that had status Success in that log, so something is fishy

I think I've found the fish .. well in my (test) case there is no motor ..
So i've also disabled the Motor operation detection (112/0/155) parameter.., which did work with the zwave2mqtt version, to have at least my sliders updated in openhab..
to 0..
I'd reconnect the FGR223 to the blind and put that back to the original 10 watt value..
And now i do see the Supervision reports and it now works like a charm!
I think that is called a user error?
It could be improved, but in i guess also not a valid use case (at least in Roller blind mode when the motor has build in end switches..)
Thanks for Fishing at least..

Closing this so :+1:


[microNPU] Remove remaining UnsupportedLayout checks

In #9508 the decision was made to remove the UnsupportedLayout exception
and the checks that throw it, this PR is cleaning up some that remained.
cc @ekalda @dchauhan-arm @manupa-arm @mbaret @NicolaLancellotti

friendly ping for comment/approval

The decision : https://github.com/apache/tvm/pull/9508#pullrequestreview-854502204


WIP: Consume command

Closes #
Verification Steps

Do x
Do y

Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation change
[ ] Other (please specify)

@jackdelahunt Do you plan to have consume/produce separated.
Wondering if would it be better to have them both as one PR for better verification/end to end experience?

@wtrocki as I was going through this I was thinking having them together would probably be better I can bundle these together now

Closing in favour of https://github.com/redhat-developer/app-services-cli/pull/1598


ensure all popovers have aria-describedBy

Why was this change made? 🤔
Fixes one accessibility item in #3171
Note, after looking at https://inclusive-components.design/tooltips-toggletips/#inclusivetoggletips will leave this as aria-describedby tags, but have now moved the element they are attached to, in some cases to the form input.  In some cases, the tip is describing a section, so left on the label or legend in those cases.
How was this change tested? 🤨
Localhost

Also, can you add comments to PopoverComponent describing the accessibility-correct way to use it.

I added a comment to the top of PopoverComponent explaining how to use it.

Note, after looking at https://inclusive-components.design/tooltips-toggletips/#inclusivetoggletips will leave this as is with aria-describedby tags, but have now moved the element they are attached to in some cases.  Where it made sense, I moved to the form input being described. In some cases the tip is describing a section, so left on the label or legend in those cases.


Question - constructor in setup() function?

Hi there,
I would like to use an I2C scan to find the address of my module then run the constructor. As far as I can tell this would have to be done inside the setup() function (scan then constructor) and if I do this the constructor is then not visible outside the setup() function as it would not be a global variable. Any suggestions as to how I could do this (i.e. not know the address of the module until the setup() function is run)?
Thanks,
Pete.

so I think I have figure it out.
PCF8574 *pcf8574;

setup() {
     pcf8574 = new PCF8574(0x27);
     pcf8574->pinMode(0, INPUT);
}

loop() {

         Serial.println(pcf8574->digitalRead(0));

}

something like this?
#include "PCF8574.h"

PCF8574 PCF_01(0x38);  // just give it an address as placeholder

void setup()
{
  Serial.begin(115200);
  Serial.println(__FILE__);
  Serial.print("PCF8574_LIB_VERSION:\t");
  Serial.println(PCF8574_LIB_VERSION);

  Wire.begin();

  // knowing the address is in the range 0x20..0x3F
  bool found = false;
  uint8_t address = 0x20;
  for (; address <= 0x3F; address++)
  {
    PCF8574 test(address);
    if (test.begin())
    {
      found = true;
      break;
    }
  }

  if (! found)
  {
    Serial.println("address not found, check hardware and reboot");
    while (1);
  }
  else
  {
    Serial.print("found\t");
    Serial.println(address, HEX);
  }

  PCF_01 = PCF8574(address);
  PCF_01.begin();
}

void loop()
{
  Serial.println(PCF_01.read8());
  delay(100);
}

// -- END OF FILE --

It will trigger on the first address found, not necessary an PCF8574 .
most I2C devices do not have a signature / ID register.
An elaborated model can scan the whole range and will indicate the addresses found.
it would be better to use core Wire commands (code of the isConnected function) to find the address
and not create N PCF8574 objects.
Hope this helps.

so I think I have figure it out.
PCF8574 *pcf8574;

setup() {
     pcf8574 = new PCF8574(0x27);
     pcf8574->pinMode(0, INPUT);
}

loop() {

         Serial.println(pcf8574->digitalRead(0));

}

With a pointer one does not create the dummy object. Think that is better,👍


Error generating speech for dialogue with

https://i.imgur.com/QVQ2Q0A.png
https://i.imgur.com/nmEr2JK.png

This can be closed once https://github.com/goatcorp/DalamudPlugins/pull/911 is merged.


Update SolarSailNavigator.netkan

I am the author of the mod. I have recompiled it to work with KSP 1.3.0.

This will disappear from the client until Persistent Thrust is available for 1.3


Spelling update

The title of "How this effects extensions" should read "How this affects extensions."
https://learn.microsoft.com/en-us/windows-server/manage/windows-admin-center/understand/modernized-gateway#how-this-effects-extensions

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: bf6c9fe6-8e87-5e85-3da3-ac0bc14e78a0
Version Independent ID: bf6c9fe6-8e87-5e85-3da3-ac0bc14e78a0
Content: Windows Admin Center modernized gateway (Preview)
Content Source: WindowsServerDocs/manage/windows-admin-center/understand/modernized-gateway.md
Product: windows-server
Technology: windows-admin-center
GitHub Login: @davannaw-msft
Microsoft Alias: dawhite

Hey @rinseaid,
Thanks again for contacting Microsoft, we value your feedback.
A documentation change has been made correcting the 6th header (effects > affects) and will be live after the next business day. We will now be closing this thread.
Thank you and have a most pleasant day.


Decentraland images and profile screen layout

Issue link

https://github.com/tasitlabs/tasit/issues/339
https://github.com/tasitlabs/tasit/issues/327
Auto-close the issue?

Closes #339
Closes #327
Types of changes

Bug fix (non-breaking change that fixes an issue)
Docs (modified documentation or code comments)
Technical debt (a code change that doesn't fix a bug or add a feature but makes something clearer for devs)
Notes

The text on the "My profile" screen is wrapping now:

@marcelomorgado This is how the decentraland dir README looks in this feature branch:
https://github.com/tasitlabs/tasit/tree/feature/decentraland-images/decentraland

@marcelomorgado This is how the decentraland dir README looks in this feature branch:
https://github.com/tasitlabs/tasit/tree/feature/decentraland-images/decentraland

Niiiiice!!!!!

@marcelomorgado This also made me think that we might want to prioritize a landing page for this app at somet point with these screenshots at tasit.io/decentraland or tasit.io/apps


Example

Hey,
I have this array of ECG signal from which I'd like to compute HRV. Do you have any example on how to use your package?
Thanks!

Hi Dominique,
can you send me an ECG example array? There are some python modules for R peaks detection. After the R detection, you can calculate de RR intervals and use the HRV module.
Cheers!


Rename NotificationRestApi to RestAPi

What current issue(s) does this address, or what feature is it adding?
RestApi is a more fitting name, because this thing is already evolving to be the standard REST API for notifications and much more ^^
How did you solve this problem?
Rename
How did you make sure your solution works?
Test
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:

[ ] Did you add any tests?
[X] Did you run make lint?
[X] Did you run make test?
[X] Are you making a PR to a feature branch or development rather than master?
[X] Did you add an entry to CHANGELOG.rst? (if not, please do)

@localhuman - good to go or other thoughts?


List Everything

Hello trying to setup alerts in terraform. How do I list everything for a resource like an app insights instance? Examples seem overly complex vs kubectl commands.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: c722777b-9914-5c57-b869-a92bb16e159e
Version Independent ID: 19b7e250-35b0-6e41-6662-b86791cf4c78
Content: az monitor metrics
Content Source: latest/docs-ref-autogen/monitor/metrics.yml
Service: monitoring-and-diagnostics
GitHub Login: @rloutlaw
Microsoft Alias: routlaw

@kairu-ms for awareness

Hi @kbocock-krg, please try az monitor metrics list -h for list command help.


Update flip cards, fixed console errors.

Updated flip animation while hovering over cards.
Fixed console errors arising due to missing key attributes in some list components.
Reduce Scroll to Top btn sizing a bit.

Good work


17548: Personal details push to page

Details

Updated dropdowns fields to be MenuItems which sends the user to another page to pick the option
Standarized the spaces between Inputs, created a new FormSpace component.
Fixed Issues

$ https://github.com/Expensify/App/issues/17548
PROPOSAL: https://github.com/Expensify/App/issues/17548#issuecomment-1521510794
Tests

Errors on Empty State

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Save
All the Inputs even the Menu Items should show a required field error

Update the menu Country item (no USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select a new country (no USA)
The Country Item should show the selected Country
The State Input should be an input component
You can select new ones and the Menu Item should be updated

Update the menu Country item (USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select United State
Should send you back and the Country Item should show the selected Country
The State Input should be a Menu Item

Update the menu State item (USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select United State
The Country Item should show the selected Country
Clicking on the State menu should send you to a new Page
You can select any State
Should send you back to and show you the updated State

Autocomplete address

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Start filling the Address Line 1, a suggestion menu should shows up
Clicking on any address should autocomplete, menu items and inputs

[ ] Verify that no errors appear in the JS console

Offline tests

Errors on Empty State

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Save
All the Inputs even the Menu Items should show a required field error

Update the menu Country item (no USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select a new country (no USA)
The Country Item should show the selected Country
The State Input should be an input component
You can select new ones and the Menu Item should be updated

Update the menu Country item (USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select United State
Should send you back and the Country Item should show the selected Country
The State Input should be a Menu Item

Update the menu State item (USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select United State
The Country Item should show the selected Country
Clicking on the State menu should send you to a new Page
You can select any State
Should send you back to and show you the updated State

QA Steps

Errors on Empty State

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Save
All the Inputs even the Menu Items should show a required field error

Update the menu Country item (no USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select a new country (no USA)
The Country Item should show the selected Country
The State Input should be an input component
You can select new ones and the Menu Item should be updated

Update the menu Country item (USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select United State
Should send you back and the Country Item should show the selected Country
The State Input should be a Menu Item

Update the menu State item (USA)

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Click on Country item
Should send you to a new page, select United State
The Country Item should show the selected Country
Clicking on the State menu should send you to a new Page
You can select any State
Should send you back to and show you the updated State

Autocomplete address

Sign in using an User that doesn't have address
Go to the Address Page (No inputs should be filled)
Start filling the Address Line 1, a suggestion menu should shows up
Clicking on any address should autocomplete, menu items and inputs

[ ] Verify you can update the Menu Items or you can go back to from the selection and the last selection should be in place
[ ] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

https://user-images.githubusercontent.com/1676818/236286530-2cba05a5-b1f3-4550-8eb6-7bfeb1a6ccad.mp4
https://user-images.githubusercontent.com/1676818/236286664-d3535992-d042-4ac8-95df-d86fd00a50c3.mp4
https://user-images.githubusercontent.com/1676818/236287012-a34543bc-5eef-4a3e-84eb-e729cbca918f.mp4

Mobile Web - Chrome

https://user-images.githubusercontent.com/1676818/236286832-11326a15-dddb-4913-8b1e-9039649358bd.mp4

Mobile Web - Safari

https://user-images.githubusercontent.com/1676818/236286951-f0fa8418-21f1-405d-973b-d52a5b5d3eab.mp4

Desktop

https://user-images.githubusercontent.com/1676818/236287076-1aeeb693-63da-4983-9610-0fff50b804bb.mp4

iOS

https://user-images.githubusercontent.com/1676818/236287166-05ae59ac-8df6-4454-b64b-3373c3fb22ce.mp4

Android

https://user-images.githubusercontent.com/1676818/236287217-78af4814-55cf-4051-8eea-e16f4d346019.mp4

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

except for minor corrections that the guidelines are in the process of clarifying, overall, LGTM 👌

@best-lucky1030 No, is ready for Expensify review

@venture1981 all solved

bump @mananjadhav

Taking longer than expected, reviewed half the files, reviewing the other half and will test it as well.

I reviewed and I am fine with the changes, but I see an outstanding comment on making it DRY - StateSelector and CountrySelector. Are we looking to fix this right now ? or follow up in another PR.

I just thought now that it would be a great if @shawnborton has some time to review this from the design standpoint 🙏

Hover background area is not familiar to me. Is this design approved? I'd expect to cover full width and enough vertical padding like other menu items.

I agree, that does not look great. I agree that the hover styles should match full width like places in the app.

For these push-to-page rows, are we using a global component? I was surprised to see that the label font size is smaller when there is no value:

For that "emtpy state" of the push row when there is no value set, the font size should be 15px. Can we make sure that is the case for all of these rows, everywhere? cc @cristipaval
Then once a value is set, the label size goes to 13px and it rests above the value, which is at 15px.

For the list selection views, @cristipaval where do we stand with updating the styles there? we shouldn't have the lines go edge-to-edge, and I thought we had an issue open to make sure the list selection is consistent everywhere.

It feels weird to me that state comes before City here:

Hey, I will review the next bugs:

Hover style making it full width
Will take a look at shouldSaveDraft
State should be Name and not code

The rest is already happening probably will be good to take it into another issue?

Why can't we reuse that component?

I did it like that the first time but got the review to Don't Repeat Yourself, so I made them use one component

For the list selection views, @cristipaval where do we stand with updating the styles there? we shouldn't have the lines go edge-to-edge, and I thought we had an issue open to make sure the list selection is consistent everywhere.

Here is the plan to do the massive refactor. So it might take a while for this refactor to be finished. Do you think we should fix the lists which have lists that go edge to edge before the refactoring? We could do this if you think that this can't be held by the refactor.

Ah, so just to make sure I understand, the list style in this PR already existed and wasn't implemented as part of this PR? If so, that's probably fine and we can wait until the refactor to fix it.

the list style in this PR already existed and wasn't implemented as part of this PR?

Ah, you're right! The picker screen was implemented as part of this PR. Even if the component for the list item is not yet refactored, we should make it look as per the requirement.
Thanks a lot for the review @shawnborton 🙇
@gedu Could you please address the @shawnborton feedback?

Yes, working on it today

@cristipaval pushed the fixes listed
https://github.com/Expensify/App/assets/1676818/d9a55faa-0070-4f94-8a09-66e329b20429
https://github.com/Expensify/App/assets/1676818/c0bd84ab-4116-42c9-83d7-d026b5d61bff
Note: didn't wanna add too much vertical padding to the menu items because when not hovered seems that there is a lot of space between items

For this here:

It feels like the label is too far away from the value. And it doesn't quite look like there is enough padding on the top/bottom. Can you make sure this looks identical to the profile page here:

Any reason why these aren't all using the same component either? I feel like we keep rewriting this same pattern.

For list views, we want the style to look like this:

@shawnborton updated, I overridden the common style because I was seeing too much space between the items, but I just remove it

All pushed

The label for Country is too small when there is no value set - can you take a look at that? It should be the same size as our normal font, and then it becomes smaller once there is a value set.

@shawnborton done

Much better, thank you!

@cristipaval should be good now

@gedu Could you please resolve the conflicts?

@gedu Could you please resolve the conflicts?

Yes, working on it

@gedu Could you please resolve the conflicts?

Yes, working on it

Thank you!

@cristipaval @0xmiroslav Conflicts solved

@0xmiroslav I'm having some issues trying to sign previous commits, I tried many commands also some shared into slack but no luck. can I create a new PR? what do you think?

@gedu we don't recommend force-push once review started but try only this time

@0xmiroslav  what do you mean by a force-push? That won't sign the old commits, there are 3 commits that need to be signed, I could sign one of the last ones but those that are from May are getting hard

Maybe you can push all of work so far in one commit. You're about to do this in new PR, right?

Yeah, I will create a new PR, because one of the unsigned commits is from May, and rebasing is really complicated

@0xmiroslav pushed, sorry for the inconvenience, my main Mac is broken so using my backup Mac I forgot to sign the commits

@0xmiroslav any updates?

@0xmiroslav

pre-populate search input and auto-scroll to selected item: FIXED
BUG: weird transition animation (the entire page flickers): New Nav bug, not related with this happens in other screens
BUG: after saving state, country is reverted: This happens in production, I would create another issue to solve this
BUG: space between address line 1 and line 2 is bigger than others: FIXED
BUG: after selecting address from auto-complete menu: FIXED

https://github.com/Expensify/App/assets/1676818/3cd25be0-6332-4009-bf44-c2910b805e65
Navigation bug in another screen
https://github.com/Expensify/App/assets/1676818/a6d5e4f3-2e9d-4063-858e-e5458ea9ef35


channel-verify broken?

PrincessLuna and IIRC some others are saying the mechanism we have in place for joining Teams is not operating properly. Is it broken or turned off on purpose?
https://chat.stackexchange.com/transcript/message/43811163#43811163

It looks like it's still broken (and yes, with the new system). It never arrives in the /channels/link/ endpoint.

@Undo1 needs to check configurations


Create feature

IN this PR I had;

display Comments on the popup.
make changes to the style.

Make the Required Changes

Thanks @ahmedeid6842 for your help and make my project be more professional

Thanks @ahmedeid6842 for your help and make my project be more professional

You're welcome to reach out for help at any time! 🙌 It always makes me happy to be able to assist and support you. 😊


update vsphere-csi-driver to min 2.5.4

To use persistent storage with eksa, we lack the latest version (min 2.5.4) of the vsphere-csi-driver.
Problem: If a pv is attatched to a node and this node is deleted, the existing volume cannot be attatched to a new node. There is a fix for this in the vsphere-csi-driver, which was merged into version 2.5.4
issue: https://github.com/kubernetes-sigs/vsphere-csi-driver/issues/359
fixed with PR: https://github.com/kubernetes-sigs/vsphere-csi-driver/pull/1879
VMware vSphere Container Storage Plug-in 2.5 Release Notes: https://docs.vmware.com/en/VMware-vSphere-Container-Storage-Plug-in/2.5/rn/vmware-vsphere-container-storage-plugin-25-release-notes/index.html

cat ../eks-anywhere-build-tooling/projects/kubernetes-sigs/vsphere-csi-driver/GIT_TAG
v2.2.0


RetinaNet ValueError: Dimensions must be equal

While running RetinaNet object detection model with KerasCV
ValueError                                Traceback (most recent call last)
[<ipython-input-24-f1ccc1110a56>](https://localhost:8080/#) in <module>
      3     validation_data=val_ds,
      4     epochs=EPOCHS,
----> 5     callbacks=callbacks,
      6 )
      7 model.save_weights(CHECKPOINT_PATH)

2 frames
[/usr/local/lib/python3.7/dist-packages/keras/engine/training.py](https://localhost:8080/#) in tf__train_function(iterator)
     13                 try:
     14                     do_return = True
---> 15                     retval_ = ag__.converted_call(ag__.ld(step_function), (ag__.ld(self), ag__.ld(iterator)), None, fscope)
     16                 except:
     17                     do_return = False

ValueError: in user code:

    File "/usr/local/lib/python3.7/dist-packages/keras/engine/training.py", line 1160, in train_function  *
        return step_function(self, iterator)
    File "/usr/local/lib/python3.7/dist-packages/keras/engine/training.py", line 1146, in step_function  **
        outputs = model.distribute_strategy.run(run_step, args=(data,))
    File "/usr/local/lib/python3.7/dist-packages/keras/engine/training.py", line 1135, in run_step  **
        outputs = model.train_step(data)
    File "/usr/local/lib/python3.7/dist-packages/keras_cv/models/object_detection/retina_net/retina_net.py", line 354, in train_step
        loss = self._backward(y_training_target, y_pred)
    File "/usr/local/lib/python3.7/dist-packages/keras_cv/models/object_detection/retina_net/retina_net.py", line 335, in _backward
        y_pred,
    File "/usr/local/lib/python3.7/dist-packages/keras_cv/models/object_detection/retina_net/retina_net.py", line 317, in compute_losses
        tf.equal(ignore_mask, 1.0), 0.0, classification_loss

    ValueError: Dimensions must be equal, but are 49104 and 20 for '{{node SelectV2}} = SelectV2[T=DT_FLOAT](Equal_1, SelectV2/t, FocalLoss/weighted_loss/Mul)' with input shapes: [?,49104], [], [?,49104,20].
    ```

@doncarlos999 @satpalsr

ValueError: Dimensions must be equal, but are 49104 and 20 for '{{node SelectV2}} = SelectV2[T=DT_FLOAT](Equal_1, SelectV2/t, FocalLoss/weighted_loss/Mul)' with input shapes: [?,49104], [], [?,49104,20].

The issue may be more close to colab environment. I tested the code on GCP with TF 2.9.2, the model run successfully.

Thanks for the suggestion @innat but I just tried on colab with TF==2.9.2 and I get the same error. It must be another package causing the problem.

As mentioned, this main issue is more related to colab env. Even if TF 2.9.1+ is installed, there may be other depencides which causing such conflict. I think it's better to create vm locally with necessary packages to run this model at the moment until colab gets upgrade.

Fair point @innat  and I could do that but the authors have a run in colab badge on the tutorial webpage so I would expect it to work there too.

I'm using notebook-api. Here is the req.txt file. Please note, there are many unnecessary packags inside the .txt which you may not needed at all.

And here is the tf and cuda version this gcp instance provided.
TF System Cuda V.  :  11.2
TF System CudNN V. :  8

cc. @LukeWood

@doncarlos999
I've sucessfully run retinanet on colab by installing following at the beginning. First install TF (<=2.9.1) and restart the runtime. Next, install keras-cv and the following packages. Rest of the code should run flawlessly.
pip install tensorflow==2.9.1

Restart may or may not required.
!pip install git+https://github.com/keras-team/keras-cv.git
!apt install --allow-change-held-packages libcudnn8=<IP_ADDRESS>-1+cuda11.2

@innat this works perfectly thank you very much.

Thanks for the bug report!  Hopefully as Colab gets newer TF versions this will work out of the box.


[BUGFIX] fix valid candidates issue

Description
Fix the dynamic mask sampling strategy. Fix Issue #1321
Checklist
Essentials

[x] PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
[x] Changes are complete (i.e. I finished coding on this PR)
[ ] All changes have test coverage
[x] Code is well-documented

Changes

[ ] Feature1, tests, (and when applicable, API doc)
[ ] Feature2, tests, (and when applicable, API doc)

Comments

If this change is a backward incompatible change, why must this change be made.
Interesting edge cases to note here

cc @dmlc/gluon-nlp-team

@liuzh91 Would you try to fix this along with the other Gumbel-topk issue? (So there is no need for me to merge twice).

@liuzh91 Would you try to fix this along with the other Gumbel-topk issue? (So there is no need for me to merge twice).

OK, I'll work on that


yarn test do not work with symlink inside node_modules

I am setting a project with create-react-app.
In order to use absolute import, I make some symlink from my directories into node_modules so my project structure looks like this.
node_modules/
  _components/ (symlink from the directory in src/)
src/
  _components/
    Input/
       index.js
    Icon/
       index.js

where inside src/_components/Input, I import Icon by using:
  import Icon from '_components/Icon';

and inside src/_components/Icon, I import React by using:
  import React from 'react';

When running yarn start, everything is fine.
However, when running yarn test, I have this error:
  ● Test suite failed to run

    project/node_modules/_components/Icon/index.js:2
    import React from 'react';
    ^^^^^^

    SyntaxError: Unexpected token import

      at ScriptTransformer._transformAndBuildScript (node_modules/jest-runtime/build/ScriptTransformer.js:289:17)
      at Object.<anonymous> (src/_components/Input/index.js:4:13)
      at Object.<anonymous> (src/_components/Input/__tests__/Input.js:2:14)

I am experiencing a similar issue - seems to be an issue with jest that needs to get a version bump


Add options for custom exe paths and extension messages

If appendWindowsPath = false, then wsl2-ssh-agent will fail to start, you can add options to allow custom ·ssh.exe· and powershell.exe paths.
If the Windows ssh-agent is manually upgraded to OpenSSH 8.9+, or a different SSH Agent implementation is used, extended messages are available and we can add options to control it.

I think it's good to have. Is the following strategy good?

If a user explicitly gives a command-line option (e.g., -ssh-command /path/to/ssh.exe or -powershell-command /path/to/powershell.exe), use it.
If not given, look for ssh.exe in the PATH. If not found, check if /mnt/c/Windows/System32/OpenSSH/ssh.exe and /mnt/c/Windows/System32/WindowsPowerShell/v1.0/PowerShell.exe" are available.

It would be great if you could send me a PR. Or, I'll probably do it myself a little later.


shpPath paramater in Shapefile.WriteAllFeatures does not work

No matter what is supplied for shpPath the files are always written to the same directory the executable is in.

can you add some sample code that reproduces the error?

When a path is specified for the shpPath parameter, WriteAllFeatures does not write the files to that path.
Instead, it seems to use the last folder in the path and use this as the filenames, it then writes the files to the same directory the executable is running from.
So there is no way to control where the files are written.

Cheers

The path you uses basically means that you want to create a file named "test" in the CurrentDirectory. This is the expected behaviour because the path parameter must be the path to a file.
You can immedately fix this problem using this procedure:

The path you use must be the path of the shapefile, so don't use Directory.GetCurrentDirectory() + "\\test but use Directory.GetCurrentDirectory() + "\\test\\myshapefile (even better, use Path.Combine to make file paths)
Be sure that the folder exists, before writing a file on it, so something like if !DirectoryExists(Directory.GetCurrentDirectory() + "\test) Directory.Create(Directory.GetCurrentDirectory() + "\\test)

Thanks @DGuidi , an oversight on my part when tired.
I feel a bit silly.

welcome to the team 😉


Use enhanced argo deps

From @bnemanich

It looks like argo DOES support booleans within the depends field: https://argoproj.github.io/argo-workflows/enhanced-depends-logic/. So at some point we could have the graph say that it only requires some variant of tensorflow-base to build tensorflow-estimator

Codecov Report

Merging #58 (775af56) into main (1caec9d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.63%   -0.02%
==========================================
  Files          23       23
  Lines        1937     1957      +20
==========================================
+ Hits         1872     1891      +19
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.63% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.21% <100.00%> (+0.16%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...775af56. Read the comment docs.

Codecov Report

Merging #58 (775af56) into main (1caec9d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.63%   -0.02%
==========================================
  Files          23       23
  Lines        1937     1957      +20
==========================================
+ Hits         1872     1891      +19
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.63% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.21% <100.00%> (+0.16%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...775af56. Read the comment docs.

Codecov Report

Merging #58 (775af56) into main (1caec9d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.63%   -0.02%
==========================================
  Files          23       23
  Lines        1937     1957      +20
==========================================
+ Hits         1872     1891      +19
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.63% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.21% <100.00%> (+0.16%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...775af56. Read the comment docs.

Codecov Report

Merging #58 (c3c83ca) into main (1caec9d) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.52%   -0.12%
==========================================
  Files          23       23
  Lines        1937     1956      +19
==========================================
+ Hits         1872     1888      +16
- Misses         65       68       +3

Flag
Coverage Δ

unittests
96.52% <100.00%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.21% <100.00%> (+0.16%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/utils.py
94.33% <0.00%> (-0.81%)
:arrow_down:

open_ce/conda_utils.py
98.63% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...c3c83ca. Read the comment docs.

Codecov Report

Merging #58 (c3c83ca) into main (1caec9d) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.52%   -0.12%
==========================================
  Files          23       23
  Lines        1937     1956      +19
==========================================
+ Hits         1872     1888      +16
- Misses         65       68       +3

Flag
Coverage Δ

unittests
96.52% <100.00%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.21% <100.00%> (+0.16%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/utils.py
94.33% <0.00%> (-0.81%)
:arrow_down:

open_ce/conda_utils.py
98.63% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...c3c83ca. Read the comment docs.

Codecov Report

Merging #58 (c3c83ca) into main (1caec9d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.63%   -0.02%
==========================================
  Files          23       23
  Lines        1937     1957      +20
==========================================
+ Hits         1872     1891      +19
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.63% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.21% <100.00%> (+0.16%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...c3c83ca. Read the comment docs.

Codecov Report

Merging #58 (fa2a034) into main (1caec9d) will decrease coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.54%   -0.11%
==========================================
  Files          23       23
  Lines        1937     1963      +26
==========================================
+ Hits         1872     1895      +23
- Misses         65       68       +3

Flag
Coverage Δ

unittests
96.54% <100.00%> (-0.11%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.24% <100.00%> (+0.19%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/utils.py
94.35% <0.00%> (-0.79%)
:arrow_down:

open_ce/conda_utils.py
98.63% <0.00%> (-0.02%)
:arrow_down:

open_ce/build_env.py
95.92% <0.00%> (ø)

open_ce/build_feedstock.py
100.00% <0.00%> (ø)

open_ce/inputs.py
96.77% <0.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...fa2a034. Read the comment docs.

Codecov Report

Merging #58 (fa2a034) into main (1caec9d) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

:exclamation: Current head fa2a034 differs from pull request most recent head 8add26d. Consider uploading reports for the commit 8add26d to get more accurate results

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.64%   -0.00%
==========================================
  Files          23       23
  Lines        1937     1964      +27
==========================================
+ Hits         1872     1898      +26
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.64% <100.00%> (-<0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.24% <100.00%> (+0.19%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/build_env.py
95.92% <0.00%> (ø)

open_ce/build_feedstock.py
100.00% <0.00%> (ø)

open_ce/utils.py
95.16% <0.00%> (+0.02%)
:arrow_up:

open_ce/inputs.py
96.77% <0.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...8add26d. Read the comment docs.

Codecov Report

Merging #58 (c0f12bc) into main (1caec9d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.64%   -0.01%
==========================================
  Files          23       23
  Lines        1937     1962      +25
==========================================
+ Hits         1872     1896      +24
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.64% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.22% <100.00%> (+0.17%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/build_env.py
95.92% <0.00%> (ø)

open_ce/build_feedstock.py
100.00% <0.00%> (ø)

open_ce/utils.py
95.16% <0.00%> (+0.02%)
:arrow_up:

open_ce/inputs.py
96.77% <0.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...c0f12bc. Read the comment docs.

Codecov Report

Merging #58 (c0f12bc) into main (1caec9d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.64%   -0.01%
==========================================
  Files          23       23
  Lines        1937     1962      +25
==========================================
+ Hits         1872     1896      +24
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.64% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.22% <100.00%> (+0.17%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/build_env.py
95.92% <0.00%> (ø)

open_ce/build_feedstock.py
100.00% <0.00%> (ø)

open_ce/utils.py
95.16% <0.00%> (+0.02%)
:arrow_up:

open_ce/inputs.py
96.77% <0.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...c0f12bc. Read the comment docs.

Codecov Report

Merging #58 (c0f12bc) into main (1caec9d) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.64%   96.64%   -0.01%
==========================================
  Files          23       23
  Lines        1937     1962      +25
==========================================
+ Hits         1872     1896      +24
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.64% <100.00%> (-0.01%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.22% <100.00%> (+0.17%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/build_env.py
95.92% <0.00%> (ø)

open_ce/build_feedstock.py
100.00% <0.00%> (ø)

open_ce/utils.py
95.16% <0.00%> (+0.02%)
:arrow_up:

open_ce/inputs.py
96.77% <0.00%> (+0.04%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1caec9d...c0f12bc. Read the comment docs.

Codecov Report

Merging #58 (ca38c6d) into main (de6e25c) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.65%   96.53%   -0.12%
==========================================
  Files          23       23
  Lines        1941     1961      +20
==========================================
+ Hits         1876     1893      +17
- Misses         65       68       +3

Flag
Coverage Δ

unittests
96.53% <100.00%> (-0.12%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.22% <100.00%> (+0.17%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

open_ce/utils.py
94.35% <0.00%> (-0.81%)
:arrow_down:

open_ce/conda_utils.py
98.63% <0.00%> (-0.02%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23c448...ca38c6d. Read the comment docs.

Codecov Report

Merging #58 (ca38c6d) into main (de6e25c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.65%   96.64%   -0.02%
==========================================
  Files          23       23
  Lines        1941     1962      +21
==========================================
+ Hits         1876     1896      +20
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.64% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.22% <100.00%> (+0.17%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23c448...ca38c6d. Read the comment docs.

Codecov Report

Merging #58 (ca38c6d) into main (de6e25c) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   96.65%   96.64%   -0.02%
==========================================
  Files          23       23
  Lines        1941     1962      +21
==========================================
+ Hits         1876     1896      +20
- Misses         65       66       +1

Flag
Coverage Δ

unittests
96.64% <100.00%> (-0.02%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

open_ce/build_tree.py
97.22% <100.00%> (+0.17%)
:arrow_up:

open_ce/validate_config.py
97.14% <0.00%> (-2.86%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a23c448...ca38c6d. Read the comment docs.


Saving a dataset takes forever

Uploading a dataset from an xlsx file results in a minute long 'Saving dataset...' view on OS X.

Doesn't this have to do with issue #22?

I think not, it was one of your test files.
Sent from my phone

On 01 Jun 2016, at 13:01, Enrico Werkema<EMAIL_ADDRESS>wrote:
Doesn't this have to do with issue #22?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.


Message in stderr is breaking django-mjml

Mjml v4.2.1 was released with a change that moves all messages from stdout to stderr to prevent these being mixed with the resulting html.
This is breaking django-mjml command here https://github.com/liminspace/django-mjml/blob/9dd6bf1b124e1e0dadf6700edf46ead56d144aa2/mjml/tools.py#L39
For example, if you are still using v3 of mjml syntax, with version 4.2.1 you will get the following error in stderr:
MJML v3 syntax detected, migrating to MJML v4 syntax. Use mjml -m to get the migrated MJML.

This will make _mjml_render_by_cmd raise a RuntimeError

@rosacris, have you tried to use MJML-option --mjml.validationLevel=stric or --mjml.validationLevel=skip?

I have tried all levels, but the warning is still appearing in stderr.

@rosacris
What do you expect? Django-mjml should render warnings in result? I thing it is not a good idea.
We can't distinguish between errors and warning as we have only one pipe -- stderr.
I think it's MJML's part and if some error or warning is happend you will get error and can fix it. Or you can disable mjml-validation by using --mjml.*-parameters.
Moreover, using cmd-mode is not a good practice. It can be used only for test. But even for testing and developing I use docker and mjml-tcpserver.
So, give me more information about problem you have and how we can resolve it.

I do not expect anything, it is no longer a problem for me because I have updated my MJML templates to V4.
I just wanted to inform you that after a minor version update of MJML the API has changed and now there are way many more things being reported through stderr that are not actual errors. Perhaps it is useful for someone.

I can report this.

I can report this.

Hi, what do you mean?

Hey guys, just wanted to let you know that we're going to revert this change, please see https://github.com/mjmlio/mjml/issues/1439#issuecomment-470137461.


syz-fuzzer: make it possible to ignore/suppress episodic executor failures

Currently hard executor failures are fatal for syz-fuzzer. This serves an important role of making frequent executor failures due to bugs clearly visible. If we ignore all of them frequent executor failures will be completely invisible.
We need to resolve #318 first and then maybe make executor non-fatal for fuzzer. Manager will still see them in output and detect as failure. But then it becomes possible to ignore some failures in manager config.
Or maybe ignore all executor failures, but provide some other clear diagnostic of frequent executor failures (and possibility to capture failure output, how?).

We now report them, so they can be suppressed. Situation also become better over time.


Renaming/Re-exporting infix raises Maximum call stack size exceeded error

I discovered recently that the infix operators behaviours had changed. It seems that it is now impossible to redefine an operator, and "re-exporting" an operator may compile, but raises a runtime error as follows:
module Infix exposing (..)
import Json.Decode exposing ((:=))
(:=) = (:=)

When using (:=) from Infix, there is a Maximum call stack size exceeded error at runtime.

Seems to be another dupe of #873...


how to change remote url from github to another?

I'm in an internal network domains.
Vundle shows me a hint like"Failed to connect to github.com port 443: Connection timed out".
So,what can I do to solve this?
(I can upload the git repo to internal gitlab)

You don't have any access to github from the machine?
Part of the idea of vundle is to just point to a repo and be done. If it's necessary to manually upload repositories, it seems reasonable to me that you just go ahead and manually install the plugins. (Of course that's just my opinion).
It appears that right now vundle doesn't allow pointing to generic urls. If you were inspired to modify your own vundle, then I think the place to start would be the function parse_name in autoload/vundle/config.vim.

it works for me,thanks,davidlowryduda.


Allow for ssm invoke without client creation

In line with the #797, I had a use case for not creating a client with the other SSM error functions. This PR should keep in line with current functionality, but extend additional WithClient functions to allow for some flexibility.

It appears TestDoInBackgroundUntilStopped failed, but trying to read through some of the code I’m not sure if that relates back to this PR. Can you confirm if any action is required on my part for this @brikis98 ?

I'm not sure, TBH! I know we recently merged some fixes for flaky tests to master. Would you mind pulling the latest from master and I can kick off tests again?

Rebased

Thanks! I'll kick off tests again.

Darn, looks like that broke more than the last time!

Yes, sorry about that. I think it might be caused by some new validate tests we added that, when run all concurrently, was overloading the CircleCi servers, and causing sporadic test failures. We fixed that in https://github.com/gruntwork-io/terratest/pull/938. Apologies for all the back and forth, but would you mind pull in in the latest from master once more?

No worries. We've all been there. Just thankful for the fast feedback. Rebased and squashed.

Thanks! Re-running tests now.

https://github.com/gruntwork-io/terratest/releases/tag/v0.36.3


support cairo 1.0 abi.

Feature Request
I have found a contract writtern by cairo 1.0, its abi is diffrent from cairo 0.
abi type like core::felt252 core::integer::u8 core::starknet::contract_address::ContractAddress
can not parse by starknet python , or json .
when I use
contract = Contract(address=contract_address, abi=abi, provider=account)
it will raise
"{'outputs': {0: {'name': ['Missing data for required field.']}}}"
error.

Hi, it's an issue we're working on (#825). However, you can interact with Cairo1 contracts by creating calls and sending them, more info here and here.


Detected dependencies should be qualified to the project directory

We now support multiple directory builds.  So the included files and other modules and service programs will likely be in a different directory.
For example when building ART300.MODULE in  https://github.com/edmundreinhardt/bob-recursive-example
the .evfevent that is generated is
TIMESTAMP  0<PHONE_NUMBER>2044
PROCESSOR  0 000 1
FILEID     0 001 000000 076 /home/REINHARD/bob-recursive-example/QRPGLESRC/ART300-Function_Article.RPGLE<PHONE_NUMBER>5716 0
FILEID     0 002 000005 063 /home/REINHARD/bob-recursive-example/qprotosrc/article.rpgleinc<PHONE_NUMBER>5716 0
But the current algorithm doesn't take the relative path up to the project root which should be:

QRPGLESRC/ART300-Function_Article.RPGLE
qprotosrc/article.rpgleinc

instead it generates
ART300.MODULE: ARTICLE.RPGLEINC
ART300.MODULE: ART300-FUNCTION_ARTICLE.RPGLE
ART300.MODULE:   ARTICLE1.FILE
At make time, there is no target for these dependencies and so it fails.

we now qualify the INCDIR paths in the VPATH and it seems to work for CLLE but not yet for RPGLE as seen above
TO reproduce touch vat.rpgleinc and build

Works for CLLE thanks to pull 142


The content of latest-tag-button and list-prs-for-file is not aligned

Please ensure:

[X] The bug is caused by Refined GitHub. It doesn't happen if I disable the extension.

Include in this issue:

[X] Screenshots/video/gif demonstrating the bug, if it’s visual
[ ] Console errors, if any

Description

Example URL
https://github.com/refined-github/refined-github/blob/main/source/refined-github.ts
https://github.com/timolins/react-hot-toast/blob/main/src/core/store.ts
Browser(s) used
Safari 15.1

Is the issue that the icons are misaligned with the text? Or that the buttons are too narrow compared to the native branch picker? (Or both?)

The icons are too high. The sup should probably also be lowered

The alignment seems fine for me on Firefox:

It's very subtle... I guess this is the outcome of using smaller buttons. I don't think it's an issue since they are not of the same size anyway.

Not they're misaligned to the text, not just the button

Maybe I misunderstood, are you referring to the two buttons RGH added are misaligned, or all of the three?
And to be honest, I didn't really see the issue here. For comparison, this is what I got on Chrome:

Look closer. Compare the padding above the tag icon with the one below. They're all closer to the top edge


Add a Postgis server with South Australia data

[x] Add a postgis service to docker-compose.yml.
[x] Add South Australia data and docker-entrypoint-scripts which load that data into the Postgis database on startup.
[ ] Add a README explaining where data lives in Atlas v2 and how to add more.
[x] Make docker-compose-prod.yml work with new frontend setup.

Related to #15.

README explanation of how to add more data and how to manage vector tiles can wait for another PR.


Stop respecting VSCode space config for extension formatter

TBD if we want that
Problem is that vscode defaults to 4 spaces and this then override the default TypeSpec behavior(even though it wasn't explicitly set to 4 by the user)
There is no way to see if vscode explicitly configured it for TypeSpec I think.
Removing this will just have people go through prettier config instead which is what they need to do anyway for tsp format

:x: There is undocummented changes. Run chronus add to add a changeset or click here.
The following packages have changes but are not documented.

:x:@typespec/compiler

Show changes

You can try these changes here

🛝 Playground
🌐 Website
📚 Next docs


Web API implementation using FastAPI and Pydantic

This PR implements the Web API interface using FastAPI ^fastapi and Pydatic ^pydantic for Schema Modeling and data validation.
Puporse
Implement a reliable Web API, so we will be able to request poems from web-pages, making Propoe installation-free for the final user.
What I've done

Created Schemas for the WebAPI

Those schemas can convert from or to the domain API
Validates user's entry
Keeps style compatibly, by accepting or returning JSON's keys in kebab-case

Created endpoints

/poem (POST): returns the Poem and gets the parameters from a JSON object
/sample (GET): returns a random poem (no parameters are passed)

How to run it
poetry install
poetry shell
fastapi dev src/web

Then open:
http://<IP_ADDRESS>:8000/docs

Usage
Valid Data:

Invalid Rhyme Pattern:

Mismatching Pattern and Rhythm:

I need to see how to create integration tests for this later. :wink:


router.afterEach guard is not called when another route is cancelled with next(false)

The router.afterEach() hook is not called when I cancel the route with next(false) inside beforeRouteEnter()
https://jsfiddle.net/zxfs1x7s/
Is this a bug or a feature? I want to stop the progressbar that runs beforeEach and stops afterEach route.

Well, afterEach() is supposed to run when a route transition finishes. Since you canceled, there was no transition to finish, so I would not consider this to be a bug.

what @LinusBorg said

@gholol - What'd you do to stop the progress bar? Is there a 'route cancelled' mechanism?

since v2.4.0+
i do so https://jsfiddle.net/74ak9w5e/

Hi guys, how do you handle back then resolving to same route through redirect?
let's say this:
login => home => browser back button => login guard activates that redirects it to home
in this case, afterEach is not called


Slow down when Redis master switching (sentinel)

Hi,
We have detect an issue on our redis (sentinel) cluster when there is a redis master switching .
During a performance test, we use PriorityQueue (~ 10 calls / seconds). All transaction are closed on 20-50 milli-seconds.
When master switching, on JConsole we have seen Redisson place some locks on redis databases, and all application are slow down... All transaction are closed on 3-10 seconds !
On our Redis cluster we have, 1 master, 5 slaves.
This is our using components versions :

redis 3.2.11
redisson 2.11.0

Also, we have test, redisson 2.11.1, we have the same issue.
We have issue with this config :
{
   "sentinelServersConfig":{
      "sentinelAddresses":[
         "redis://***.92:26379","redis://***.93:26379","redis://***.94:26379","redis://***.95:26379","redis://***.96:26379","redis://***.97:26379"
      ],
      "clientName":"***",
      "readMode":"MASTER",
      "timeout":"10000",
      "masterName":"***",
      "database":1,
      "password":null
   }
}

And we have apply a fix (work around), it's better running, but it's a huge configuration (on system : lot of connection and open file issue)
{
   "sentinelServersConfig":{
      "sentinelAddresses":[
         "redis://***.92:26379","redis://***.93:26379","redis://***.94:26379","redis://***.95:26379","redis://***.96:26379","redis://***.97:26379"
      ],
      "clientName":"***",
      "readMode":"MASTER",
      "timeout":"10000",
      "masterName":"***",
      "database":1,
      "password":null,
      "masterConnectionPoolSize":1024,
      "masterConnectionMinimumIdleSize":256,
      "slaveConnectionPoolSize":256,
      "slaveConnectionMinimumIdleSize":24
   }
}

Can you help us please ?
Thanks you

Could you check also with 2.11.2 version. I did improvement - failedAttempts setting should be applied to Slave nodes only it should help.

Redisson place some locks on redis databases

Please clarify here, since Redisson doesn't use locks on redis database during failover.


ux: Improve delete message warning.

Adds details about the author, stream, topic in the modal for delete
message warning.
Also adds a warning saying that this message will be permanantly
deleted.
Fixes: #16426
Signed-off-by: Adwait Thattey<EMAIL_ADDRESS>
Testing Plan: no tests added or modified

Please add a screenshot.

Screenshot:

@Gittenburg any update?

I don't currently have time to review PRs. Looking at the screenshot, "Please Note ..." should be "Please note...".

@Gittenburg made the change

I merged 5bfafae764742d2ebc512ab2c3dc2a9d35724035 to cover the documentation linking piece that I wanted for this issue.

I'm wondering if there's a better way to do the indication than duplicating message content in the popover, which is fundamentally not super clear -- could we make the "delete a message" popover work like the "emoji reactions" popover in pointing to the message in question, visually?

@adwait-thattey huge thanks for working on this!  After seeing this prototype, I think it's the wrong path forward for solving the issue; I encourage you to work on the revised proposal I posted in the issue thread.
Please consider your work here to be a valuable contribution -- a PR that reveals a strategy isn't great is just as valuable as a merged PR in helping the project move forward.


Polling watcher

It's often preferable to poll for file system changes instead of using FileSystemWatcher. There are many samples on the internet showing how to do such polling. All the ones I looked at allocate memory on every polling internal. This library only allocates when actual changes are detected.
It is an early prototype and so does not support several important features: watching subfolders, discriminating between different change types, watching UNC paths, and some others.

OK, I am going to merge this prototype and keep working on it. Right now it does not support watching subfolders, so I cannot actually try it on node_modules, but node_modules has ~2500 files and so I think I can make it work in under 10ms.


Update JamfUploaderBase.py

skip escaping ampersands in substituted keys if the key is an int
fixes #115

Thanks, looks sensible. I don't think I'd come across a profile with an <int> before.


doesn't auto go to the next game

I'm running it on chrome
it just finishes the game I'm on and I have to manually go to the next game

i'm going to be redoing some state changes soon which will have cooldowns and stuff, then i'd like you to try again

200 https://community.steam-api.com/ITerritoryControlMinigameService/ReportScore/v0001/
{"response":{"old_score":"701235","old_level":9,"new_score":"702405","new_level":9,"next_level_score":"1200000"}}
200 https://community.steam-api.com/ITerritoryControlMinigameService/GetPlayerInfo/v0001/
(not headless version) After the game ends there's only "Reporting Score to Salien High Command" and no button to continue.
Looks like a Steam issue, but the game is stuck at End screen indefinitely now.

When a planet ends, the whole game lags. If you afk on it, it will be back to normal soon.


Random stops responding

I have noticied that SkyDNS2 after perhaps the machine is suspended randomly stops responding to queries and has to be restarted because it simply no longer resolves queries. I don't know how to go about debugging this issue, but I have noticed it more than once.

Without a lot more context and information this is impossible for me to fix.

Is there any way to turn on a logging system or debug log ?

[ Quoting<EMAIL_ADDRESS>in "Re: [skydns] Random stops respondin..." ]

Is there any way to turn on a logging system or debug log ?

You can log queries with the -verbose flag. Anything important will be logged
anyhow, so if there isn't any logging Skydns will just thing it is running fine.
One thing that just pops in my head right now: could it be related to caching?
I.e. skydns thinks it has something in the cache, but due to being suspended
something fishy happens there...
Or it may fail to re-connect to etcd - which might be even more likely, but OTOH
skydns will just requery.
I think you might need th' old tcpdump for this.
/Miek
--
Miek Gieben


W-11210924-fixBuildErrorsFromGary-v37-duke

Writer's Quality Checklist
Before merging your PR, did you:

[ ] Run spell checker
[ ] Run link checker to check for broken xrefs
[ ] Check for orphan files
[x] Perform a local build and do a final visual check of your content, including checking for:

Broken images
Dead links
Correct rendering of partials if they are used in your content
Formatting issues, such as:

Misnumbered ordered lists (steps) or incorrectly nested unordered lists
Messed up tables
Proper indentation
Correct header levels

[ ] Receive final review and signoff from:

Technical SME
Product Manager
Editor or peer reviewer
Reporter, if this content is in response to a reported issue (internal or external feedback)

[ ] If applicable, verify that the software actually got released

trying to trigger the d*$! checks


fix: reconciler fail/timeout as error for destroy

This change updates the WaitEvent processing to treat a reconcile failure or timeout as an error for Destroyer. This ensures that the finalizer waits until all objects are NotFound before exiting.
The behavior is left unchanged for the Applier.

/assign @karlkfi


Add files via upload

@anushkashukla92 ggits.txt I am sorry, I have to close the request without merging, because you made a mistake in a request and did not specify any filepath. Please ensure that you are familiar with this repository rules located at the bottom of this page and make a new correct request. Thank you for your understanding!


[FEATURE] Register-PnPManagementShellAccess without graphical console

Is your feature request related to a problem? Please describe.
I'm trying to script creation of folders in our Sharepoint document library on a Rocky Linux host which does not have a graphical console.
Describe the solution you'd like
A new parameter to open a URL on another host and return a generated token.
Describe alternatives you've considered
Additional context

@cctgteddy - closing this because we are not going to be supporting PnP Management shell multi-tenant app from 9th September.
https://pnp.github.io/blog/post/changes-pnp-management-shell-registration/
Would suggest you to use Register-PnPEntraIDApp and use your own Entra ID app. You can use NoPopup parameter to complete the flow in a browser.


Screen flicker on first start

Please consult the issue guidelines at
https://github.com/vaxerski/Hyprland/blob/main/docs/ISSUE_GUIDELINES.md
BEFORE submitting.
I've recently switched to Hyprland (tried both yay -S hyprland-git and compiling myself) but I can't seem to be able to launch Hyprland correctly. Upon start, screen flickers until a key (any key) that corresponds to something in my hyprland.conf (e.g. SUPER+Return for terminal).
Here is my Hyprland.log (uploaded to termbin for convenience)
This is a laptop with a discrete NVIDIA card, however, it should be using the integrated Intel GPU by default as I have configured EnvyControl for that purpose. And even with EnvyControl removed, the issue continues to occur.
Any help would be appreciated!
P.S.

is that an issue? if doing anything fixes it, it shouldn't really be.
I've noticed it on my poopy laptop too, it's probably an issue with either of those two:
some laptops have 2 active outputs, for some reason, you should prolly disable one cuz it doesnt technically exist
it might be an issue with double-buffered damage state, doing a rollback on the second buffer being empty

is that an issue? if doing anything fixes it, it shouldn't really be.
I would argue it should not be happening in the first place. While do I admit it's not significant as it can be fixed by simply doing something you basically have to do on a window manager; it could result in something significant. But what do I know?

some laptops have 2 active outputs, for some reason, you should prolly disable one cuz it doesnt technically exist
I don't know what you mean by 2 active outputs. Are you referring to xrandr outputs, as if there are two monitors? If not, how can I check and disable the second output?

check the debug:overlay

issue is resolved by replacing eDP-1 with DP-1 in hyprland.conf
thank you for your time


Optional AWS Route53 region

When you install cert-manager on EKS and use IAM Roles for Service Accounts or Pod Identity,
an AWS mutating webhook will add AWS_REGION and AWS_DEFAULT_REGION environment variables to the controller Pod. There's no need to specify the region in the Issuer config so it should not be a required field.

📖 Read Grant Kubernetes workloads access to AWS using Kubernetes Service Accounts to learn more about these two mechanisms.

AWS Route53 is a global service and does not have regional endpoints.
The AWS SDK for Go V2 uses the region (whether supplied or detected from environment variables) as a hint,
with which to compute the AWS partition domain name (i.e. route53.amazonaws.com / amazonaws.com.cn  / route53.us-gov.amazonaws.com) and the credential scope (us-east-1 / cn-northwest-1 / us-gov-west-1).
Here is the metadata that the SDK uses for Route53.

Updated the webhook validation tests, to demonstrate that all the Route53 fields are now optional.
Removed the webhook validation for region, which was being used if the user supplied an empty string for region.
OpenAPI validation was also being used, if the region field was omitted from the supplied JSON.
So I marked annotated the  field with omitempty and +optional and regenerated the CRDS.

Fixes:  https://github.com/cert-manager/cert-manager/issues/6175
Fixes: https://github.com/cert-manager/website/issues/56
/kind bug
The Route53 DNS01 solver of the ACME Issuer can now detect the AWS region from the AWS_REGION and AWS_DEFAULT_REGION environment variables, which is set by the IAM for Service Accounts (IRSA) webhook and by the Pod Identity webhook.
The `issuer.spec.acme.solvers.dns01.route53.region` field is now optional.
The API documentation of the `region` field has been updated to explain when and how the region value is used.

Testing
API Documentation
$ kubectl explain issuer.spec.acme.solvers.dns01.route53.region
GROUP:      cert-manager.io
KIND:       Issuer
VERSION:    v1

FIELD: region <string>

DESCRIPTION:
    Override the AWS region.

    Route53 is a global service and does not have regional endpoints but the
    region specified here (or via environment variables) is used as a hint to
    help compute the correct AWS credential scope and partition when it
    connects to Route53. See:
    - [Amazon Route 53 endpoints and
    quotas](https://docs.aws.amazon.com/general/latest/gr/r53.html)
    - [Global
    services](https://docs.aws.amazon.com/whitepapers/latest/aws-fault-isolation-boundaries/global-services.html)

    Region is not needed if you use [IAM Roles for Service Accounts
    (IRSA)](https://docs.aws.amazon.com/eks/latest/userguide/iam-roles-for-service-accounts.html).
    Instead an AWS_REGION environment variable is added to the cert-manager
    controller Pod by:
    [Amazon EKS Pod Identity
    Webhook](https://github.com/aws/amazon-eks-pod-identity-webhook),

    Region is not needed if you use [EKS Pod
    Identities](https://docs.aws.amazon.com/eks/latest/userguide/pod-identities.html).
    Instead an AWS_REGION environment variable is added to the cert-manager
    controller Pod by:
    [Amazon EKS Pod Identity
    Agent](https://github.com/aws/eks-pod-identity-agent),

    Region is not used for computing STS regional endpoints.
    If you configure the `role` field, cert-manager will always use the
    global STS endpoint to make AssumeRole and AssumeRoleWithWebIdentity
    requests.

    Region is ignored if ambient credentials mode is disabled, by
    `--cluster-issuer-ambient-credentials` or `--isssuer-ambient-credentials`
    controller flags.

/kind feature


fix parsing backends.paths

fix parsing backends.paths

This is resolved in #672. Additionally, please make sure to copy over the elements of slices/maps, and not by reference; this can cause some undesired behavior when modifying either copy. Marking as duplicate for now--will leave open for a moment in case you have other thoughts on the issue.


chore: Do not import order theory in Data.Int.Cast.Lemmas

Split off the lemmas about OrderedRing from Data.Int.Cast.Lemmas to a new file Algebra.Order.Ring.Cast.

bors d+


Forking/parallelism tracking

Allows forking/parallelism. Part (1) of this: https://github.com/DAGWorks-Inc/burr/issues/52. In this PR we allow the user to do their own.
See https://github.com/DAGWorks-Inc/burr/issues/52
Changes

[x] Adds the __context input for nodes to declare
[x] Enables __context to be nullable

TODO:

[x] Add spawning parent pointer to the application builder
[x] Get the tracker to work with multiple apps (so we can use the same tracker).
[x] Wire info through to hooks
[x] Add it to data tracking model for local client
[x] Show in UI

[x] App list
[x] Step list

[x] Add tests for tracking
[ ] Add documentation

How I tested this
Notes
Checklist

[x] PR has an informative and human-readable title (this will be pulled into the release notes)
[x] Changes are limited to a single goal (no scope creep)
[x] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
[x] Any change in functionality is tested
[ ] New functions are documented (with a description, list of inputs, and expected output)
[ ] Placeholder code is flagged / future TODOs are captured in comments
[ ] Project documentation has been updated if adding/changing functionality.

Killing this on in favor of the mega-one (easier to iterate on): https://github.com/DAGWorks-Inc/burr/pull/225


Long cache of names in Mattermost

Hello.
I have trouble with the cache names in Desktop client. I have a script which changes the last name with absence status, like "Out of office". it helps us to clearly understand that this employe now absents and why.
My script changing the last name via API with the patch method. All works fine. But if the computer with Mattermost client is offline when the script has been worked, old name displaying. How could I ask the client to force drop their own cache when I am patching users?
Or maybe I could disable cache on the client-side?

Hi @swood. What version of the Mattermost server are you using? We've made some recent improvements to have clients reload any updated users when Mattermost reconnects, but they might not be on the version you're using

hi @hmhealey.
Thank you for your answer. My current server version is 5.12.0 but my issue grows since version 5.6 or something like that.
In which version you have done your improvements and how could I check it?

I just double checked, and the fix actually hasn't been released yet. It should be fixed in 5.14 which is scheduled for release on August 16th.


[Discussion] Tech Stack for the Community Website

Tech stack discussion for the official website of the community.

Can you please tell me which purpose you need to create a website?

Hey @codewithvk We are creating this site for sharing the resources. So if you look at this repo, we are storing all the resources in the form of broadcast which we send in our private HITK TECH Community channel. so the purpose of creating this site will make those available for everybody.

Greate !!


Added namespace updates too examples

Per this issue: https://github.com/kubeflow/website/issues/1686 I added updating the namespace too the hyperparameter tuning examples.
First PR, :) so I'm sorry if this is missing more info needed here! please just let me know! It's only WIP because I want to see it's preview first but I think it is all there!

This change is

/ok-to-test
/assign

Preview: https://deploy-preview-1813--competent-brattain-de2d6d.netlify.com/docs/components/hyperparameter-tuning/hyperparameter/

/lgtm
/approve


Security Vulnerability detected

Hello,
we use the alert manager in version v.0.24.0 in our productions clusters. When scanning with trivy, these two vulnerabilities were found. It is urgent that the leaks are closed. Many thanks !
Trivy-Scan:

"Results": [
{
"Target": "bin/alertmanager",
"Class": "lang-pkgs",
"Type": "gobinary",
"Vulnerabilities": [
{
"VulnerabilityID": "CVE-2022-27191",
"PkgName": "golang.org/x/crypto",
"InstalledVersion": "v0.0.0-20210616213533-5ff15b29337e",
"FixedVersion": "0.0.0-20220314234659-1baeb1ce4c0b",
"Layer": {
"Digest": "sha256:eff15e454e36aa140fab50241f2e21d9c9613b4f17336f7fcc4ece1492d5a81e",
"DiffID": "sha256:1fab62a9c3e2a608d838762e10844d7c277a855700f7b91c0aa73036209641ec"
},
"SeveritySource": "nvd",
"PrimaryURL": "https://avd.aquasec.com/nvd/cve-2022-27191",
"DataSource": {
"ID": "go-vulndb",
"Name": "The Go Vulnerability Database",
"URL": "https://github.com/golang/vulndb"
},
"Title": "golang: crash in a golang.org/x/crypto/ssh server",
"Description": "The golang.org/x/crypto/ssh package before 0.0.0-20220314234659-1baeb1ce4c0b for Go allows an attacker to crash a server in certain circumstances involving AddHostKey.",
"Severity": "HIGH",
"CweIDs": [
"CWE-327"
],
"CVSS": {
"nvd": {
"V2Vector": "AV:N/AC:M/Au:N/C:N/I:N/A:P",
"V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H",
"V2Score": 4.3,
"V3Score": 7.5
},
"redhat": {
"V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H",
"V3Score": 7.5
}
},
"References": [
"https://access.redhat.com/security/cve/CVE-2022-27191",
"https://github.com/advisories/GHSA-8c26-wmh5-6g9v",
"https://go.dev/cl/392355",
"https://go.googlesource.com/crypto/+/1baeb1ce4c0b006eff0f294c47cb7617598dfb3d",
"https://groups.google.com/g/golang-announce",
"https://groups.google.com/g/golang-announce/c/-cp44ypCT5s",
"https://groups.google.com/g/golang-announce/c/-cp44ypCT5s/m/wmegxkLiAQAJ",
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>"https://nvd.nist.gov/vuln/detail/CVE-2022-27191",
"https://pkg.go.dev/vuln/GO-2021-0356",
"https://security.netapp.com/advisory/ntap-20220429-0002/"
],
"PublishedDate": "2022-03-18T07:15:00Z",
"LastModifiedDate": "2022-08-17T04:15:00Z"
}
]
},
{
"Target": "bin/amtool",
"Class": "lang-pkgs",
"Type": "gobinary",
"Vulnerabilities": [
{
"VulnerabilityID": "CVE-2022-27191",
"PkgName": "golang.org/x/crypto",
"InstalledVersion": "v0.0.0-20210616213533-5ff15b29337e",
"FixedVersion": "0.0.0-20220314234659-1baeb1ce4c0b",
"Layer": {
"Digest": "sha256:c7c947db7a9ad516d2010d087af49d58bd2d9ea3bf622d2e5f4801f513a4850c",
"DiffID": "sha256:43ac410b5fc47e7689e6a028b7658f15e5a0a846c3cecedb96058751461bd1cd"
},
"SeveritySource": "nvd",
"PrimaryURL": "https://avd.aquasec.com/nvd/cve-2022-27191",
"DataSource": {
"ID": "go-vulndb",
"Name": "The Go Vulnerability Database",
"URL": "https://github.com/golang/vulndb"
},
"Title": "golang: crash in a golang.org/x/crypto/ssh server",
"Description": "The golang.org/x/crypto/ssh package before 0.0.0-20220314234659-1baeb1ce4c0b for Go allows an attacker to crash a server in certain circumstances involving AddHostKey.",
"Severity": "HIGH",
"CweIDs": [
"CWE-327"
],
"CVSS": {
"nvd": {
"V2Vector": "AV:N/AC:M/Au:N/C:N/I:N/A:P",
"V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H",
"V2Score": 4.3,
"V3Score": 7.5
},
"redhat": {
"V3Vector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:U/C:N/I:N/A:H",
"V3Score": 7.5
}
},
"References": [
"https://access.redhat.com/security/cve/CVE-2022-27191",
"https://github.com/advisories/GHSA-8c26-wmh5-6g9v",
"https://go.dev/cl/39[235](https://git.tech.rz.db.de/serviceteam-lso/container/core_architecture/applications/monitoring/iat/alertmanager-service/-/jobs/87187913#L235)5",
"https://go.googlesource.com/crypto/+/1baeb1ce4c0b006eff0f294c47cb7617598dfb3d",
"https://groups.google.com/g/golang-announce",
"https://groups.google.com/g/golang-announce/c/-cp44ypCT5s",
"https://groups.google.com/g/golang-announce/c/-cp44ypCT5s/m/wmegxkLiAQAJ",
<EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS><EMAIL_ADDRESS>"https://nvd.nist.gov/vuln/detail/CVE-2022-27191",
"https://pkg.go.dev/vuln/GO-2021-0356",
"https://security.netapp.com/advisory/ntap-20220429-0002/"
],
"PublishedDate": "2022-03-18T07:15:00Z",
"LastModifiedDate": "2022-08-17T04:15:00Z"
}
]
}
]
}

Always send this issue as e-mail to<EMAIL_ADDRESS>

Neither alertmanager nor amtool import the golang.org/x/crypto/ssh package. I believe that the scanner reports a false positive because they import other packages from the golang.org/x/crypto module.

These reports should disappear with the next minor release of the Alertmanager (as we routinely upgrade dependencies for a minor release). However, if these CVEs are all in code that is not actually used in the Alertmanager, there will be no bugfix release for it.
As @M4rkus- said, please don't report security issues via a GH issue. (It could be a real issue, and then it should be fixed first before it is publicly announced.) Please follow the Prometheus security policy (also linked from SECURITY.md).

@beorn7

As @M4rkus- said, please don't report security issues via a GH issue. (It could be a real issue, and then it should be fixed first before it is publicly announced.) Please follow the Prometheus security policy (also linked from SECURITY.md).

had a email contact with apache security team to same circumstance in one of their projects, they told me:

We regularly get reports sent to us from scanning tools that look at
dependencies out of context on how they are actually used in the
projects. As such we initially reject this report as a security issue.
Nonetheless, we'd warmly welcome ... if you'd contribute this finding as a normal bug
report and/or patch to the project. Since outdated dependencies
without further analysis are quite public, there is no need to use this
private reporting mechanism in that case.

with this a report like this or https://github.com/prometheus/alertmanager/issues/3117  filed as a normal issue would be perfectly fine for Apache projects (since every vulnerability with CVE is already puplic)
=> should it be handled in a different way for Prometheus?

Dependencies are generally updated automatically. Therefore, each minor release should include all pending dependency updates. (And chances are that the dependencies your security scan has listed are already updated in the main branch.)
If there are reasons to expedite the release of a version with updated dependencies, we can cut a bugfix release. If those reasons are actually security issues, then please use the non-public reporting mechanism discussed above. If there are other reasons, feel free to report them as an issue.

many thanks for detailing it.
Yes there are already some updates fixing CVEs within main.
Since usage of dependabot who found and triggers these updates was introduced on Jul 6
(https://github.com/prometheus/alertmanager/pull/2914)
while the last release (v0.24) was in March
maybe it's not a bad time to think about a new v0.24.1...

closed by #3187


Poor parsing for inline comments

I am trying to toggle commenting on and off for a disabled attribute within a <button> element, in my HTML Handlebars template. Unfortunately, when I do this the resulting button name becomes >Register instead of Register.
Can we fix comment parsing so that the comment terminator is not included with the rest of the HTML output?
Not sure if this is an Express Handlebars issue, a Handlebars issue, or perhaps a Google Chrome issue.

Closing due to inactivity. Please provide a jsfiddle or any other working example to demonstrate the issue.