Character count fails if ID starts with a number.

Description of the issue
When character count is used on a textarea with id which start with a number, it fails with an exception:
all.js:1501 Uncaught DOMException: Failed to execute 'querySelector' on 'Element': '[id=1_details-info]' is not a valid selector.
    at new CharacterCount (http://localhost/submissions/assets/lib/govuk-frontend/govuk/all.js:1501:34)
    at http://localhost/submissions/assets/lib/govuk-frontend/govuk/all.js:2515:5
    at NodeList.forEach (<anonymous>)
    at nodeListForEach (http://localhost/submissions/assets/lib/govuk-frontend/govuk/all.js:14:18)
    at Object.initAll (http://localhost/submissions/assets/lib/govuk-frontend/govuk/all.js:2514:3)
    at http://localhost/submissions/form/test/page?se=t&ff=t:1012:34

Steps to reproduce the issue
Having a textarea with id which start with a number:
<textarea
    class="govuk-textarea govuk-js-character-count govuk-input--width-30"
    id="1_details"
    name="1_details"
    rows="5"
    aria-describedby="1_details-info"></textarea>

Current behaviour
querySelector in character-count.js crashes when id starts with a number:
https://github.com/alphagov/govuk-frontend/blob/9b320cece2177f3a9749d8150e250fe8978e7eef/src/govuk/components/character-count/character-count.js#L8-L10
(This is a minimal reproduction of the issue)
> document.querySelector('[id=1_details-info]');
VM711:1 Uncaught DOMException: Failed to execute 'querySelector' on 'Document': '[id=1_details-info]' is not a valid selector.
    at <anonymous>:1:10

The reason for the crash is that id selector is not being quoted.
Expected behaviour
querySelector works when id starts with a number:
> document.querySelector('[id="1_details-info"]');
<div id="1_details-info" class="govuk-hint govuk-character-count__message" aria-live="polite">
  You can enter up to 1000 characters
</div>

It works when id selector is quoted: id="1_details-info".

As the above issue has been fixed long back. May we please know when it will be released?

@SandipKhedekar this was fixed in v3.11.0 which has just been released this afternoon.


docs: update example in README

This is to avoid confusion. aws-serverless-express does not need to return anything in the handler unless using Promise mode.
Please ensure all pull requests are made against the develop branch.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

:tada: This PR is included in version 3.3.6 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


(BUG) Redirect to the "Learn more" screen after clicking the "Claim" button at the bottom

Precondition:
*The "Claim" page is opened
*The face verification isn't passed
Steps to reproduce:

Click the "Claim" button at the bottom
Pay attention to the redirect to the "Learn more" screen

Actual result: Redirect to the "Learn more" screen after clicking the "Claim" button at the bottom. It works like a double-click
Expected result: Redirect to the "Face Verification" screen after clicking the "Claim" button at the bottom
Checked on DEV env V0.22.1-0
Reproduced on:
LG V30+ // Android 8.0 // Google Chrome 81.0.4044.138
Desktop: Windows 10 // Google Chrome 83.0.4103.61
Video: https://www.screencast.com/t/Ib0f9zHZ

Checked on the Dev env. v0.22-1.0
The issue isn't reproduced

@serdiukov-o-nordwhale see my comment in the PR
need to add preventDefault not the mount test

need to re-check it

The issue isn't reproduced
Checked on the Dev env. v0.22.1-0
LG V30+ // Android 8.0 // Google Chrome 81.0.4044.138
Desktop: Windows 10 // Google Chrome 83.0.4103.61
Video: https://www.screencast.com/t/2hAHeOBmxSl


Build demos with CMake

This might include moving some code around to better segment "library" code from the entrypoint programs.

if this is not taken, I would like to work on this.

By all means! That's really nice of you to offer. Please let any of us know (either here or on the mailing list) if you're having trouble -- although if I'm honest we aren't necessarily that experienced with CMake since we come from the land of Bazel.

The only known issue is that MSVC must use Release builds, not Debug builds.


Update RELEASING.md

What: A new "Step 2" needs to be added.
Why: The step for merging the release branch into develop is missing.
Text:
"2) A release branch will be created and pushed automatically. Open a PR from the release branch to develop."
All steps following the addition remain but the step numbers increase by 1.
This new step will need to be removed once the develop branch is deleted.

@gregdeane let's redefine our release process, automate what we can automated (as you suggested) and discuss when we should build the distribution files.


Fix #254: Fixed responsiveness of the Story page

Issue Number
fixes #254
Describe the changes you've made
I have modified the media queries to fix responsiveness of the Story page.
Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)
NA
Checklist

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[x] All new and existing tests passed.
[x] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review

Story page responsiveness breaking for 412px, 280px and 540px

@mharshita I have pushed the changes


Islands were being forced to POINT geometry

The DB table osm_island_polygon does not in fact contain polygons, but points. I've been asked to figure out why newly-drawn islands aren't appearing, and this is certainly one piece of that.
Relevant to #57 which came later than this, about styling islands.
┆Created By: Dan Rademacher

https://github.com/OpenHistoricalMap/openmaptiles/commit/b9b0786a8cf86b01f2237ed7d8bb7ba3f93cbd96
Confirmed that this was an intentional behavior in OpenMapTiles:  update_osm_island_polygon()
I removed this, and later confirmed when diffs were ingested, that islands are now kept as polygons.

Still to do, though:

I wonder if there's some reason these were being forced to points in OpenMapTiles. Looking at this, https://github.com/openmaptiles/openmaptiles/commits/master/layers/place/update_island_polygon.sql, almost seems like they were focused on getting points on which to hang labels or something. But dropping the geometry from all islands... can't imagine that was the intention. Strange.
So as you point out to get the geoms here, we'd have to prompt some special case re-ingestion of these. Hmm

Seems like this should roll into #64

Or maybe not re Carto work in #64, as Gregor just pointed out to me, it’s a database/sync/diff issue in the data and not in the map style. Though there’s some overlap, as islands are a style.

So this is more challenging than I realized:

Islands were being forced to points for some time, and 33,000+ islands still are. Could an update be forced so they send diffs, and thus fix drawing islands as vector tiles?

So even if we change how we consume islands, the only way we'd reconsume them is if they are somehow edited and thus become part of a diff.
Gregor:

Hopefully they can do something as simple as an UPDATE query to set the records to last-updated-right-now, and let nature take its course.

Hmm, sounds easy but I wonder about ancillary impacts of an edit that's really only for the purpose of our renderer...

The alternative is to purge our entire database and start over. Which is possible, but time consuming and maybe best done after we do some carto implementation and isolate and account for any other issues we might not be consuming.
But the more I think about the idea of a force change upstream, the more I worry we’ll regret it later. Things Jeff might look at down the road, like average edits per month/year etc would have this huge artificial spike when every island in the world was changed
We're guessing a day’s work in generating a world file, purging the DB, and reloading from scratch. Plus a bit of time remembering how we did it the first time...

There are actually many reasons for looking at a re-import of the entire
planet's set of natural features. The first time I did this was rather
messy and probably too rushed. So, please don't dismiss that too quickly...
it might be the right move.
Also, you're guessing far too little time, imho. Closer to a week of
careful:

building the appropriate filters to extract the features you want
doing the actual planet.osm filtering
reconstructing OSM object IDs
testing in a separate staging environment that the basic planet has worked
testing the merge with existing DB data
deploying

Just my guess, but maybe I'm too slow at these things!! High risk for
screwing things up, so just want to be careful. : )
On Mon, Sep 30, 2019 at 9:39 AM Dan Rademacher<EMAIL_ADDRESS>wrote:

The alternative is to purge our entire database and start over. Which is
possible, but time consuming and maybe best done after we do some carto
implementation and isolate and account for any other issues we might not be
consuming.
But the more I think about the idea of a force change upstream, the more I
worry we’ll regret it later. Things Jeff might look at down the road, like
average edits per month/year etc would have this huge artificial spike when
every island in the world was changed
We're guessing a day’s work in generating a world file, purging the DB,
and reloading from scratch. Plus a bit of time remembering how we did it
the first time...
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/59?email_source=notifications&email_token=AALM4EWCQQS5QFUCOQ4A5PTQMITUDA5CNFSM4IUN4LMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD76JAIA#issuecomment-536645664,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALM4EXSGSKW3KU7ZIIFCGTQMITUDANCNFSM4IUN4LMA
.

--
Jeff Meyer
206-676-2347
osm: Open Historical Map (OHM)
http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page
http://www.openstreetmap.org/user/jeffmeyer
t: @OpenHistMap

I'm fully behind any effort to get the other 4 great lakes imported ;-)

Hmm I think we’re talking about different things. GreenInfo is referring to dropping the database that renders vector tiles and reimporting the full planet from OHM. But still whatever is in OHM is what we get.
Sounds to me like you’re talking about actually updating the source OHM data... from OSM? Don’t really want to go there for our map rendering work

Also I don’t really understand the history of dealing with licensing in the case of importing from OSM To OHM. But in any case that’s a quite different project from what we’re taking about

I think what Bert is saying is that:

There are a bunch of Great Lakes (not to mention the Great Salt Lake)
that are not in OHM proper right now.
They show up when rendering at low zoom levels (e.g. 0->12, or close
thereto) because rendering currently pulls from Natural Earth shapes at
that level
We need to get the lakes back in at higher zooms by reimporting some
better lake coastlines from OSM
For copyright issues, we should just plan to tag licensing info at the
object level and also attribute it to OSM

I think this is more of an end user (i.e. me or others) task, rather than a
GreenInfo task, as it relates to data & imports.
On Tue, Oct 1, 2019 at 11:27 AM Dan Rademacher<EMAIL_ADDRESS>wrote:

Also I don’t really understand the history of dealing with licensing in
the case of importing from OSM To OHM. But in any case that’s a quite
different project from what we’re taking about
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/OpenHistoricalMap/openhistoricaltiles/issues/59?email_source=notifications&email_token=AALM4EWJYIFBNDF7FCOT3CDQMOJCRA5CNFSM4IUN4LMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEACIMQY#issuecomment-537167427,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALM4EQWMYAR54T5N6NFZKTQMOJCRANCNFSM4IUN4LMA
.

--
Jeff Meyer
206-676-2347
osm: Open Historical Map (OHM)
http://wiki.openstreetmap.org/wiki/Open_Historical_Map / my OSM user page
http://www.openstreetmap.org/user/jeffmeyer
t: @OpenHistMap


net/http: TestDontCacheBrokenHTTP2Conn flakes

Several instances on the dashboard. One example:
https://build.golang.org/log/1aa3681cf8816e6e95b24dddb3a9a47922fbc235
cc @bcmills @matloob although I don’t see how either of your changes could have caused this

Duplicated of https://github.com/golang/go/issues/35113
There’s CL under review


hyp0f1 and struveh/struvel test failures

With the 0.18.0rc2 32-bit Linux wheel from PyPI:
======================================================================
FAIL: test_mpmath.TestSystematic.test_hyp0f1_complex
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/rgommers/.local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/rgommers/.local/lib/python2.7/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/tests/test_mpmath.py", line 1198, in test_hyp0f1_complex
    [Arg(-25, 25), ComplexArg(complex(-120, -120), complex(120, 120))])
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 225, in assert_mpmath_equal
    d.check()
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 212, in check
    reraise(*sys.exc_info())
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 208, in check
    param_filter=self.param_filter)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_testutils.py", line 125, in assert_func_equal
    fdata.check()
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_testutils.py", line 344, in check
    assert_(False, "\n".join(msg))
  File "/home/rgommers/.local/lib/python2.7/site-packages/numpy/testing/utils.py", line 75, in assert_
    raise AssertionError(smsg)
AssertionError:
Max |adiff|: 4.98453e+25
Max |rdiff|: 1.16226e+14
Bad results (2 out of 5491) for the following points (in output 0):
                   (-1e-30+0j)                      (1e-30+0j) =>    (-5.811323644522354e-17+0j) !=                    (-5e-31+0j)  (rdiff<PHONE_NUMBER>90446.06)
                    (1e-30+0j)                     (-1e-30+0j) =>    (-5.811323644522253e-17+0j) !=                     (5e-31+0j)  (rdiff<PHONE_NUMBER>90446.06)

======================================================================
FAIL: test_mpmath.TestSystematic.test_struveh
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/rgommers/.local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/rgommers/.local/lib/python2.7/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/tests/test_mpmath.py", line 1609, in test_struveh
    rtol=5e-10)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 225, in assert_mpmath_equal
    d.check()
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 212, in check
    reraise(*sys.exc_info())
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 208, in check
    param_filter=self.param_filter)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_testutils.py", line 125, in assert_func_equal
    fdata.check()
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_testutils.py", line 344, in check
    assert_(False, "\n".join(msg))
  File "/home/rgommers/.local/lib/python2.7/site-packages/numpy/testing/utils.py", line 75, in assert_
    raise AssertionError(smsg)
AssertionError:
Max |adiff|: 6.00153e+281
Max |rdiff|: 1.04376e-06
Bad results (17 out of 2610) for the following points (in output 0):
                         -10.0              27.825594022071243 =>            0.08538849163456759 !=             0.0853885807600122  (rdiff         1.0437630396775024e-06)
        -1.584893192461111e-07               16.68100537200059 =>          0.0030327868849725037 !=          0.0030327868586599417  (rdiff          8.676034012477932e-09)
        -2.511886431509572e-13               16.68100537200059 =>           0.003032859340241818 !=           0.003032859357762292  (rdiff         5.7768831831575855e-09)
       -3.9810717055349853e-19               16.68100537200059 =>          0.0030328593642341573 !=          0.0030328593578771955  (rdiff         2.0960292192322536e-09)
        -6.309573444801943e-25               16.68100537200059 =>           0.003032859386511313 !=          0.0030328593578771955  (rdiff           9.44129425983736e-09)
                        -1e-30               16.68100537200059 =>           0.003032859382870125 !=          0.0030328593578771955  (rdiff          8.240714999191768e-09)
                           0.0               16.68100537200059 =>           0.003032859337594946 !=          0.0030328593578771955  (rdiff          6.687500807317889e-09)
                         1e-30               16.68100537200059 =>          0.0030328593420661386 !=          0.0030328593578771955  (rdiff           5.21325093752338e-09)
         6.309573444801943e-25               16.68100537200059 =>          0.0030328593496474253 !=          0.0030328593578771955  (rdiff          2.713535048232232e-09)
        3.9810717055349853e-19               16.68100537200059 =>          0.0030328593802469183 !=           0.003032859357877196  (rdiff          7.375786264466402e-09)
         2.511886431509572e-13               16.68100537200059 =>          0.0030328593792583133 !=          0.0030328593579920992  (rdiff          7.011935450985688e-09)
         1.584893192461111e-07               16.68100537200059 =>          0.0030329318165232045 !=          0.0030329318571076067  (rdiff         1.3381244310934225e-08)
                           0.1               16.68100537200059 =>           0.051432929176759075 !=           0.051432929221421814  (rdiff          8.683685619545708e-10)
           0.10000000000000009               16.68100537200059 =>            0.05143292918322988 !=           0.051432929221421855  (rdiff          7.425588613477252e-10)
              77.4263682681127                77.4263682681127 =>             124408928.42117062 !=             124408929.01600471  (rdiff          4.781281327505454e-09)
<PHONE_NUMBER>0318823<PHONE_NUMBER>014884 =>          2.449041958118309e-22 !=         2.4490419531540947e-22  (rdiff         2.0270025182055675e-09)
<PHONE_NUMBER>189409<PHONE_NUMBER>0318823 =>         6.090078970541256e-190 !=          6.09007895879149e-190  (rdiff         1.9293290039418937e-09)

======================================================================
FAIL: test_mpmath.TestSystematic.test_struvel
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/rgommers/.local/lib/python2.7/site-packages/nose/case.py", line 197, in runTest
    self.test(*self.arg)
  File "/home/rgommers/.local/lib/python2.7/site-packages/numpy/testing/decorators.py", line 147, in skipper_func
    return f(*args, **kwargs)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/tests/test_mpmath.py", line 1627, in test_struvel
    ignore_inf_sign=True)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 225, in assert_mpmath_equal
    d.check()
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 212, in check
    reraise(*sys.exc_info())
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_mptestutils.py", line 208, in check
    param_filter=self.param_filter)
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_testutils.py", line 125, in assert_func_equal
    fdata.check()
  File "/home/rgommers/.local/lib/python2.7/site-packages/scipy/special/_testutils.py", line 344, in check
    assert_(False, "\n".join(msg))
  File "/home/rgommers/.local/lib/python2.7/site-packages/numpy/testing/utils.py", line 75, in assert_
    raise AssertionError(smsg)
AssertionError:
Max |adiff|: 6.00153e+281
Max |rdiff|: 1.34067e-08
Bad results (2 out of 2612) for the following points (in output 0):
            -599.4842503189409<PHONE_NUMBER>0318823 =>         7.496028765368905e+182 !=         7.496028788983548e+182  (rdiff          3.150287113158528e-09)
           -215.44346900318823<PHONE_NUMBER>014884 =>         1.8527173939362396e+16 !=          1.852717369097493e+16  (rdiff          1.340665727773665e-08)

The hyp0f1 is not specific to this wheel I think, but the struve ones I've never seen before.

I added the mpmath tests to the wheel build / test repo, and get the same failures : https://travis-ci.org/MacPython/scipy-wheels/jobs/143830834

Can you check the compiler flags for C code from the build log. E.g. no
"-O3" or "-ffast-math". Do the errors go away if compiling with export  OPT="-O1"?

The other suspect is bugs in libc math routines (if I understand
correctly, these wheels use old libc versions):
.
https://sourceware.org/bugzilla/buglist.cgi?bug_status=RESOLVED&component=math&order=changeddate DESC%2Cpriority%2Cbug_severity&product=glibc&query_format=advanced&resolution=FIXED

I added `export OPT='-01' to the build flags :
https://github.com/MacPython/scipy-wheels/commit/2d79afdba7d493ef5919dd4e67c17b622e2fc934
The 32-bit error is the same:
https://travis-ci.org/MacPython/scipy-wheels/jobs/143854017
Aren't the glibc routines blacklisted by numpy?  Can we blacklist extra glibc routines from scipy?

Numpy has special implementations only for complex functions. What it
would take to get to the bottom of this, is to run the code (compiled
with OPT="-ggdb -O0") in debugger (breakpoint at struve_hl for python -c
'import scipy.special as s; s.struve(-10.0, 27.825594022071243)'),
compare the run with a build on a working platform, and then determine
what part was miscompiled.

Sorry for my ignorance, but I am not familiar with gdb.  Is there anything I can to help someone who is?

No repro on master with Ubuntu 16.04 32 bit, so going to blame it on old versions of glibc and say there's not much to do about it now.


Current version seems pretty easy to crash for me.

What steps will reproduce the problem?
Well, all I did was try to open a favorites or two, once this version of grabber was opened or even after waiting a couple minutes and trying to get atleast one to load, repeatedly if necessary.
What is the expected behavior? What do you get instead?
I did this up to version 4.7.0 since that was the version I last had working on my system and it caused no problems and would all I clicked near immediately. Once I clicked a tag in this version, in this case my favorites, the program would freeze for a few seconds and open it in a tab. Once opened, attempting to either reload that tab or open new tags well freeze the program again or just crash it.
What version of the program are you using? On what operating system?
Version 4.8.2 this happening on. I'm on Windows 8.
Please provide any additional information below
This is more off topic, but I've notice that the more recent installers no longer give the option to pick your location to install grabber and uses the last set location from my old installs. Can the option be re-implemented?

Just look at the RAM usage. At about 1.900MB it will crash. That happens if there are many image search results in the open tabs (in total) and if the download query is very long. It reminds me of the 1.900MB margin that crashed firefox in the past, when it was only available in its 32-bit version. But in this case 64-bit wouldn't help much. Somewhere there is a lot of memory wasted. Unfortunately I'm not a C++ dev so I can't help much.
If you want to pick a new location, just uninstall the old installation before installing the new version. If you didn't do the portable method, than the old settings should remain in C:\Users\UserName\AppData\Local\Bionus\Grabber after uninstalling (at least it did so for me).

About crashes, as said on issue #618 this version introduced a few big leaks that I'm currently working on. I'll upload a new version as soon as I get satisfying results. About the freezes, it's also related to the leak issue and I have already a fix on develop, so it should also be fixed as soon as the new version is released.
Sorry about this, this new version introduces some big internal changes, which caused these leaks to appear. I'm currently working on it as fast as I can to get it fixed, so it shouldn't take more than a few days.

This is more off topic, but I've notice that the more recent installers no longer give the option to pick your location to install grabber and uses the last set location from my old installs. Can the option be re-implemented?

I didn't change anything in the installer, so I guess it just doesn't prompt for the install folder if you have it already installed on your system. So as MrCrackR said, uninstall first. If you want to have multiple versions installed at the same time, you'd be better off using the portable mode.

Just look at the RAM usage. At about 1.900MB it will crash. That happens if there are many image search results in the open tabs (in total) and if the download query is very long. It reminds me of the 1.900MB margin that crashed firefox in the past, when it was only available in its 32-bit version. But in this case 64-bit wouldn't help much. Somewhere there is a lot of memory wasted. Unfortunately I'm not a C++ dev so I can't help much.

That's also my conclusion for all these crashes, that's why I'm currently re-doing most of the program's memory management. There's currently a 5mo leak per page since version 4.8.0 (my bad), and there has been a 200ko leak per image since a long time ago (causing the crashes on big batch downloads).

After a few fixes, I managed to get rid of the 5mo/page leak, and reduce the 200ko/image one to around 60ko/image.

With the new version, it's still not perfect but already a lot better, as you can see below (stats were done with the Windows task manager on windows 10, using version 4.8.3).
Sorry for the inconvenience! I just uploaded version 4.8.3. Please tell me if it fixed your issues, so that I can know if I still have to investigate or not.
Download of 2,000 images

Before download: 21.5 mo
Beginning of the download: 86.1 mo
End of the download: 112 mo
After download: 69.8 mo

10 pages and 2,000 images took 65 mo to store in memory (32 ko per image).
Each image downloaded "leaked" 13 ko.
In the end, 45 mo were leaked.
Download of 20,000 images

Before download: 17.4 mo
Beginning of the download: 458 mo
After 1,000 images: 487 mo
After 3,000 images: 506 mo
After 5,000 images: 508 mo (down from some peaks at 550 mo)
After 6,000 images: 470 mo
After 8,000 images: 471 mo
After 10,000 images: 383 mo
After 15,000 images: 378 mo
After 18,000 images: 311 mo
End of the download: 359 mo
After download: 239 mo

100 pages and 20,000 images took 440 mo to store in memory (22 ko per image).
In the end, 220 mo were leaked.
What can be easily noticed is that except for the initial storage in RAM of the images' data, the download itself did not need much more even though we had 10 times more images. The further in the download we were, the less it ate RAM (even getting some back each time it recycled the already downloaded images).
In conclusion, there shouldn't be issues as long as you don't go above 100,000 images for now (after which the storage itself of the data will eat all your RAM).

You didn't change the installer? That's strange. But from version 4.5.3 back, still ask you to pick an install location regardless of if it was already installed. Most be the older versions were bugged for still asking then!

Just checked version 4.8.3. It no longer freezes and moves like normal with crashes, but no longer downloads. It just ignores all in batch downloads. A matter of fact, nothing saves in the new version. Even using 'save' or 'save and close' for me on the image itself produces a file with 0 bytes.

For me it now works perfectly except for images from the source rule34.paheal.net, where it doesn't save the images but some HTML-files.

For me it now works perfectly except for images from the source rule34.paheal.net, where it doesn't save the images but some HTML-files.

Yeah, they broke their RSS API and for some reason it's above the Regex API in the new version. A workaround is to change the site's source order to put the Regex on top (requires a restart).

version 4.8.3 [...] no longer downloads. It just ignores all in batch downloads. A matter of fact, nothing saves in the new version. Even using 'save' or 'save and close' for me on the image itself produces a file with 0 bytes.

I can confirm now as well, that there are some files, that end up as 0-byte-files on my HDD. Not all of them, but a few.

I'll investigate, but I think some logs may help for this, until I can reproduce the issue. Is it totally random? (all of Falord's image seem to break, while only a few of MrCrackR's have this issue)

The batch downloads are work now. After restarting my computer they started working. But all images that are saved using "save" and "save and close" all produce 0 byte files for me still on version 4.8.3.  Hope these are the right logs.
main.zip

The only error I get is:

[17:33:33.254] Error parsing RSS file: letter is expected (4 - 53).
[17:33:33.254] Loading using Rss failed. Retry using Html.

This log is written, when the 0-byte file is created:

[17:41:13.950] Loading image from http://simg4.booru.com//images/86/9d/.jpg
[17:41:14.156] Image received from http://simg4.booru.com//images/86/9d/.jpg
[17:41:14.156] Saving image in D:\Files\*\*booru.com\3192782.jpg

They are only created when directly viewing them inside Grabber (on every source), not when downloading them with the function in the Downloads-Tab.

I'm also having this issue while testing with safebooru.

The issue should be fixed in the develop branch, and the fix will be included in the next release. :smile:


Updated Changes

Created new NFT wizard contract based on PSP34 contracts
Implemented mint NFT on course completion
Added e2e tests
Fixed frontend to implement new contract's function

How do I start frontend?
The following is from the task description:
Deploy your finished frontend on any of the free services like as Github.io page, Vercel or Netlify
Swanky Magink School template already supports github.io. You will just need to change the homepage in package.json to point to your repository. To deploy it, run yarn deploy and on your github repo configure Settings→Pages to point to gh-pages branch after you have deployed the project.

How do I start frontend? The following is from the task description:
Deploy your finished frontend on any of the free services like as Github.io page, Vercel or Netlify
Swanky Magink School template already supports github.io. You will just need to change the homepage in package.json to point to your repository. To deploy it, run yarn deploy and on your github repo configure Settings→Pages to point to gh-pages branch after you have deployed the project.

How do I start frontend? The following is from the task description:
Deploy your finished frontend on any of the free services like as Github.io page, Vercel or Netlify
Swanky Magink School template already supports github.io. You will just need to change the homepage in package.json to point to your repository. To deploy it, run yarn deploy and on your github repo configure Settings→Pages to point to gh-pages branch after you have deployed the project.

I just added a Vercel integration for preview and deployment. I hope this passes now @Maar-io

Does frontend work for you? I get an empty page

Does frontend work for you? I get an empty page

It works for me, I made this video after seeing this comment. https://www.loom.com/share/a133717acba54d9d8b45c8482f690d43?sid=e73540dc-8b00-4a78-8ff1-8fa48e85fd26
Please check this?

I was using link from the About section of the repository. Please update it

During minting you have message Claiming your badge.... This should be different message
MInting is stuck
2.1 error on the console during minting

##### badges earned count 9
useSubmitHandler.ts:48 send mint wizard transaction
useSubmitHandler.ts:32 {image: File}
lib.js:130 Uncaught (in promise) Error: missing token
    at BN.auth (lib.js:130:23)
    at BN.storeCar (lib.js:176:21)
    at BN.store (lib.js:302:22)
    at async i (useSubmitHandler.ts:39:5)
    at async useSubmitHandler.ts:49:13
auth @ lib.js:130
storeCar @ lib.js:176
store @ lib.js:302
await in store (async)
onSubmit @ FormContainer.tsx:96
(anonymous) @ Formik.tsx:848
(anonymous) @ Formik.tsx:1200
(anonymous) @ Formik.tsx:755
Promise.then (async)
(anonymous) @ Formik.tsx:730
(anonymous) @ Formik.tsx:1200
(anonymous) @ Formik.tsx:822
(anonymous) @ Formik.tsx:1200
Be @ react-dom.production.min.js:54
Ue @ react-dom.production.min.js:54
(anonymous) @ react-dom.production.min.js:55
Lr @ react-dom.production.min.js:105
Dr @ react-dom.production.min.js:106
(anonymous) @ react-dom.production.min.js:117
lu @ react-dom.production.min.js:274
Me @ react-dom.production.min.js:52
qr @ react-dom.production.min.js:109
Zt @ react-dom.production.min.js:74
Wt @ react-dom.production.min.js:73
FormContainer.tsx:35 ##### blocks until claim 0
FormContainer.tsx:41 ##### badges count 9

2.2 Screenshot of stuck transaction

Token is missing from env variables, or more like the Dapp could not read it. I have renamed it and it works now.

have you deployed it?  I still get
##### badges earned count 9
useSubmitHandler.ts:48 send mint wizard transaction
useSubmitHandler.ts:32 {image: File}
lib.js:130 Uncaught (in promise) Error: missing token
    at BN.auth (lib.js:130:23)
    at BN.storeCar (lib.js:176:21)
    at BN.store (lib.js:302:22)
    at async i (useSubmitHandler.ts:39:5)
    at async useSubmitHandler.ts:49:13
auth @ lib.js:130
storeCar @ lib.js:176
store @ lib.js:302
await in store (async)
onSubmit @ FormContainer.tsx:96
(anonymous) @ Formik.tsx:848
(anonymous) @ Formik.tsx:1200
(anonymous) @ Formik.tsx:755
Promise.then (async)
(anonymous) @ Formik.tsx:730
(anonymous) @ Formik.tsx:1200
(anonymous) @ Formik.tsx:822
(anonymous) @ Formik.tsx:1200
Be @ react-dom.production.min.js:54
Ue @ react-dom.production.min.js:54
(anonymous) @ react-dom.production.min.js:55
Lr @ react-dom.production.min.js:105
Dr @ react-dom.production.min.js:106
(anonymous) @ react-dom.production.min.js:117
lu @ react-dom.production.min.js:274
Me @ react-dom.production.min.js:52
qr @ react-dom.production.min.js:109
Zt @ react-dom.production.min.js:74
Wt @ react-dom.production.min.js:73
FormContainer.tsx:35 ##### blocks until claim 0
FormContainer.tsx:41 ##### badges count 9

Hi @Maar-io , Yes I have deployed it. I was making a mistake before because I was pushing my changes to a separate branch while expecting the changes on this branch. But it is working now, I have also tested it from my end.


[ASCII-2387] Remove flake marker in windows e2e test

What does this PR do?
Remove the flake marker in Windows e2e tests.
Motivation
They are marked as flaky due to a bug in the windows agent restart logic.
The framework had a workaround, which was reverted, but now the revert has been reverted so they should be reliable again https://github.com/DataDog/test-infra-definitions/pull/1179.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes

/merge


Create service and controller deployment specs for v2.

The minion controller is gone, of course. To keep things simple,
there is no separate controller for debug mode.
The controller spec presumes that a Docker image will appear soon
at kubernetes/cluster-insight:v2.0-alpha.
Note that the setup shell script is not current.

@rimey - if you can upload the cluster-insight image v2.0-alpha, I can test the new controller/service specs.
Thanks.

Wait on merging this pull request. I'll update the README. You can test the new instructions while you're at it.

Sure.
On Thu, Aug 27, 2015 at 3:24 PM, Ken Rimey<EMAIL_ADDRESS>wrote:

Wait on merging this pull request. I'll update the README. You can test
the new instructions while you're at it.
—
Reply to this email directly or view it on GitHub
https://github.com/google/cluster-insight/pull/115#issuecomment-135529433
.

kubernetes/cluster-insight:v2.0-alpha has been uploaded to Docker Hub.
I appreciate the simplicity of ISO dates as version names, but now that we have two incompatible major versions, we should adopt semantic versioning as the Kubernetes projects have done.


[Task]: Improvements for Statistics (Charts) page

Task description

Make the first two graphs also StackedLineChart
Fix the labels to now be days but months on (all time)
Add zooming support to charts

Requirements
N/A
Acceptance criteria
N/A
Creation checklist

[X] I have assigned this task to the correct people
[X] I have added the most appropriate labels
[X] I have linked the correct milestone and/or project

Check open external issues about this:
https://github.com/iotaledger/explorer/issues/742
https://github.com/iotaledger/explorer/issues/740


francisca bug

Minecraft Version
1.19.x
Mod Loader Version
0.14.21
Mod Version
1.4.5
Describe the Issue
i cant throw the francisca
latest.log
https://drive.google.com/file/d/1fN5Se2Le_zZfH8AFig08ofFRBIiei2nA/view?usp=sharing
Do you use any other mods except the required ones?
yes

the drive is empty. Reopen with the latest log.


feat: use ws-tool support deflate

Codecov Report
Attention: 110 lines in your changes are missing coverage. Please review.

Comparison is base (59edb6d) 70.46% compared to head (6df0a74) 70.34%.

Files
Patch %
Lines

taos-ws/src/client/mod.rs
62.96%
60 Missing :warning:

taos-ws/src/query/asyn.rs
72.30%
36 Missing :warning:

taos-ws/src/lib.rs
89.70%
14 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #306      +/-   ##
==========================================
- Coverage   70.46%   70.34%   -0.13%
==========================================
  Files         114      115       +1
  Lines       34777    35183     +406
==========================================
+ Hits        24507    24750     +243
- Misses      10270    10433     +163

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Remaining features will be implemented with another pr.


`ValueError: n_components=100 must be between 0 and min(n_samples, n_features)=16 with svd_solver='full'

i am trying to training a new pose, i run the s4_train.py, but i got the error message below:
ValueError: n_components=100 must be between 0 and min(n_samples, n_features)=16 with svd_solver='full'
about number of data:
After train-test split: Size of training data X:     (16, 314) Number of training samples:  16 Number of testing samples:   8
where can i change the number of n_components? or is there another way to solve it? Please reply.
我嘗試訓練一個新的姿勢，在跑s4_train.py時出現了以下錯誤訊息:
ValueError: n_components=100 must be between 0 and min(n_samples, n_features)=16 with svd_solver='full'
有關於資料的數量
After train-test split: Size of training data X:     (16, 314) Number of training samples:  16 Number of testing samples:   8
請問應該從哪裡調整 n_components的數量，或有無其他解決方法?再麻煩回覆了

Hi, you have only 16 training samples, which is smaller than the n_components=100, and this causes the error.
I think it would be better if you can collect more data.
Or, you may change the n_components to a value smaller than 16 (The relevant code snippet is shown below with n_components highlighted).

(utils/lib_classifier.py)

thanks for your help, i solve this by modify the "settings"


lexicon: 3.4.3 -> 3.5.2

Motivation for this change
Update to latest upstream release 3.5.2.
Changelog: https://github.com/AnalogJ/lexicon/blob/master/CHANGELOG.md
Should fix the build issue that came up during update for msgpack.
  ERROR: Could not find a version that satisfies the requirement tldextract<3,>=2 (from dns-lexicon)
  ERROR: No matching distribution found for tldextract<3,>=2

Things done

[x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[x] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.


[!] Error in launcher command generation.

Empire Version
2.0
OS Information (Linux flavor, Python version)
Kali linux
Expected behavior and description of the error, including any actions taken immediately prior to the error. The more detail the better.
[!] Invalid listener: http
[!] Error in launcher command generation.
Screenshot of error, embedded text output, or Pastebin link to the error
http://imgur.com/a/hQ6pu
Any additional information

Have you started the listener yet?
On Thu, May 18, 2017 at 12:10 PM Nyxw0rm<EMAIL_ADDRESS>wrote:

Empire Version
2.0
OS Information (Linux flavor, Python version)
Kali linux
Expected behavior and description of the error, including any actions
taken immediately prior to the error. The more detail the better.
[!] Invalid listener: http
[!] Error in launcher command generation.
Screenshot of error, embedded text output, or Pastebin link to the error
http://imgur.com/a/hQ6pu
Any additional information
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/EmpireProject/Empire/issues/519, or mute the thread
https://github.com/notifications/unsubscribe-auth/AJ8ssKDpNQvDHTIXT4XtrZ1d2nOCsbpKks5r66iTgaJpZM4Nepcq
.

ok , I do not notice that jajaja thanks


GROOVY-7618 Parameterless closure to SAM Type argument coercion cause…

…s NPE during instruction selection (STC)

Hi @shils !
I am really impressed with your pull requests. That part of the codebase is not the easiest. Would you be interested in joining the team?

Hi @melix ,
Thanks for reviewing my code. I'd love to join the team; what would the next steps be?

@shils The existing committers have to vote. @melix I guess you will start the vote?

I just started the vote. It will last for 72 hours. @shils Sorry for the delay.

@PascalSchumacher That's alright, thanks for letting me know. There have been more important things to vote on recently anyway.


[#42], [#44] Replace hardcoded paginator template, add value attr to the search field

It seems that paginator twig template is hardcoded, hence config setting does not do anything.

You're absolutely right. Thanks for this PR.
Best regards,
Philippe


Fix streaming endpoints

Fixes an issue where requests to an endpoint that returns StreamingResponse would never finish.

@0e4ef622 so i thought more about this, and ended up implementing the Transfer-Encoding alternative since it's more "correct" -- see here, along with properly using the aiohttp-serialized http message


Unexpected error in provider addic7ed

Hi,
I'm using subliminal version 0.8.0-dev. When I try to use 'addic7ed' as provider, I get this message:
INFO     [subliminal.api] Listing subtitles for < Episode [u'Hart of Dixie', 4x9] >
INFO     [subliminal.providers.addic7ed] Logged in
INFO     [subliminal.providers] Listing subtitles with provider 'addic7ed' and languages set([ < Language [nl] > ])
ERROR    [subliminal.providers] Unexpected error in provider 'addic7ed'
Traceback (most recent call last):
File "build/bdist.macosx-10.10-intel/egg/subliminal/providers/__ init __.py", line 224, in list_subtitles
provider_subtitles = provider.list_subtitles(video, provider_languages)
File "build/bdist.macosx-10.10-intel/egg/subliminal/providers/addic7ed.py", line 194, in list_subtitles
return [s for s in self.query(video.series, video.season, video.year)
...
The login seems to work, so any idea what goes wrong here?
Thanks in advance,
Jeroen

Found it! Looks like the problem is an invalid cache-file after my "subliminal -c" option


Don't work this product when appering validation in error tag "field_with_errors" on Ruby on Rails.

I have used radio buttons of "Awesome bootstrap checkbox".
My enviroment is Ruby on Rails(ver.4.2.6).
If radio buttons having validation and following label when occasioned error than included "" tag.
Than "Awesome bootstrap checkbox" not works.
Please tell me advice at this problem. Thank you.
example:
This pattern don't work. ("span.field_with_errors" tag is Ruby on Rails error appering point)

    <input value="1" checked="checked" name="status" id="status" type="radio">

This case, this code was changed after it could worked.
Could I send this project my pull request?
file: awesome-bootstrap-checkbox/awesome-bootstrap-checkbox.css
Before :
.radio-success input[type="radio"] + label::after {
  background-color: #5cb85c;
}
.radio-success input[type="radio"]:checked + label::before {
  border-color: #5cb85c;
}
.radio-success input[type="radio"]:checked + label::after {
  background-color: #5cb85c;
}

After:
.radio-success input[type="radio"] ~ label::after {
  background-color: #5cb85c;
}
.radio-success input[type="radio"]:checked ~ label::before {
  border-color: #5cb85c;
}
.radio-success input[type="radio"]:checked ~ label::after {
  background-color: #5cb85c;
}


Passing TensorBoard callback to Model.fit() throws 'Sequential' object has no attribute 'run_eagerly' error

System information

OS Platform and Distribution:  Windows 10 Insider Preview 18965.1005
TensorFlow backend (yes / no):  Yes
TensorFlow version:  1.14.0
Keras version:  2.2.5
Python version:  3.7.3
GPU model and memory:  NVIDIA GTX 1050 Ti 4GB

Describe the current behavior
So I'm trying to get TensorBoard to work with a model. I create the model as follows:
model = Sequential([
            Dense(fc1_dims, input_shape=(input_dims,)),
            Activation('relu'),
            Dense(fc2_dims),
            Activation('relu'),
            Dense(n_actions)])

model.compile(optimizer=Adam(lr=lr), loss='mse')

Then, when it comes to fitting, I do it as follows:
model.fit(state, q_target, verbose=0)

This works fine.
Now, I want to add TensorBoard to it so I can see how things change over time.
I create the TensorBoard callback:
from time import time
from tensorflow.python.keras.callbacks import TensorBoard
tensorboard = TensorBoard(log_dir="logs\{}".format(time()), histogram_freq=0)

and I pass it to the fit method, so instead of the previous fit call, I do:
model.fit(state, q_target, verbose=0, callbacks=[tensorboard])

When I try to run the code this time, when it reaches the fit call, it throws the following error:
Traceback (most recent call last):
  File ".\main_keras.py", line 54, in <module>
    agent.learn(tensorboard_cb=tensorboard)
  File "C:\Projects\<PROJECT_DIR>\<FILENAME>.py", line 105, in learn
    _ = self.q_eval.fit(state, q_target, verbose=0, callbacks=[tensorboard_cb])
  File "C:\Users\<USER_DIR>\Anaconda3\lib\site-packages\keras\engine\training.py", line 1039, in fit
    validation_steps=validation_steps)
  File "C:\Users\<USER_DIR>\Anaconda3\lib\site-packages\keras\engine\training_arrays.py", line 117, in fit_loop
    callbacks.set_model(callback_model)
  File "C:\Users\<USER_DIR>\Anaconda3\lib\site-packages\keras\callbacks.py", line 54, in set_model
    callback.set_model(model)
  File "C:\Users\<USER_DIR>\Anaconda3\lib\site-packages\tensorflow\python\keras\callbacks.py", line 1509, in set_model
    if not model.run_eagerly:
AttributeError: 'Sequential' object has no attribute 'run_eagerly'

If I go to keras\callbacks.py and modify the set_model method:
  def set_model(self, model):
    """Sets Keras model and writes graph if specified."""
    self.model = model
    with context.eager_mode():
      self._close_writers()
      if self.write_graph:
        with self._get_writer(self._train_run_name).as_default():
          with summary_ops_v2.always_record_summaries():
            if not model.run_eagerly:
                summary_ops_v2.graph(K.get_graph(), step=0)

            summary_writable = (
                self.model._is_graph_network or  # pylint: disable=protected-access
                self.model.__class__.__name__ == 'Sequential')  # pylint: disable=protected-access
            if summary_writable:
              summary_ops_v2.keras_model('keras', self.model, step=0)

    if self.embeddings_freq:
      self._configure_embeddings()

to this:
  def set_model(self, model):
    """Sets Keras model and writes graph if specified."""
    self.model = model
    with context.eager_mode():
      self._close_writers()
      if self.write_graph:
        with self._get_writer(self._train_run_name).as_default():
          with summary_ops_v2.always_record_summaries():
            # if not model.run_eagerly:
            summary_ops_v2.graph(K.get_graph(), step=0)

            summary_writable = (
                # self.model._is_graph_network or  # pylint: disable=protected-access
                self.model.__class__.__name__ == 'Sequential')  # pylint: disable=protected-access
            if summary_writable:
              summary_ops_v2.keras_model('keras', self.model, step=0)

    if self.embeddings_freq:
      self._configure_embeddings()

the callback works fine for my case.
Why is this happening though? Am I doing something wrong? Is there a better way to go for this? What are your thoughts and suggestions about it?
Describe the expected behavior
Have the TensorBoard function properly without having to edit any of the internal Keras files.
Code to reproduce the issue
Here's some bare minimum code that reproduces the above mentioned behavior:
from keras.layers import Dense, Activation
from keras.models import Sequential, load_model
from keras.optimizers import Adam
import numpy as np

from time import time
from tensorflow.python.keras.callbacks import TensorBoard
tensorboard = TensorBoard(log_dir="logs\{}".format(time()), histogram_freq=0)

model = Sequential([
            Dense(256, input_shape=(8,)),
            Activation('relu'),
            Dense(256),
            Activation('relu'),
            Dense(4)])

model.compile(optimizer=Adam(lr=0.0005), loss='mse')

_ = model.fit(np.zeros((1000, 8)), model.predict(np.zeros((1000, 8))), verbose=0, callbacks=[tensorboard])

I have this same issue:
tensorflow 2.1.0
tensorboard 2.1.0
keras 2.3.1
My solution was the following change in callbacks.py:
-     self._log_write_dir = distributed_file_utils.write_dirpath(
-         self.log_dir, self.model._get_distribution_strategy())  # pylint: disable=protected-access
+    self._log_write_dir = self.log_dir

I'm not using a distributed file system, so this is no issue for me.

Same issue with
def create_network(network_input, n_vocab):
    model = keras.models.Sequential()

    print(network_input.shape)

    model.add(

        keras.layers.LSTM(512,
                          input_shape=(network_input),
                          recurrent_dropout=0.3,
                          return_sequences=True))

    model.add(
        keras.layers.LSTM(
            512,
            return_sequences=True,
            recurrent_dropout=0.3,
        ))

    model.add(keras.layers.LSTM(512))

    model.add(keras.layers.BatchNormalization())

    model.add(keras.layers.Dropout(0.3))

    model.add(keras.layers.Dense(256))

    model.add(keras.layers.Activation('relu'))

    model.add(keras.layers.BatchNormalization())

    model.add(keras.layers.Dense(n_vocab))

    model.add(keras.layers.Activation('softmax'))

    model.compile(loss="categorical_crossentropy", optimizer="rmsprop")

    return model


'maxminddb.h' not found

Not sure if this is the right repo to post this issue.
I'm getting the following when running pip3 install maxminddb --force-reinstall --verbose.
I checked /usr/local/include/ as recommended in another issue and it does contain the header file.
  creating build/temp.macosx-12-x86_64-3.9/extension   clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk<EMAIL_ADDRESS>-c extension/maxminddb.c -o build/temp.macosx-12-x86_64-3.9/extension/maxminddb.o -Wall -Wextra   extension/maxminddb.c:3:10: fatal error: 'maxminddb.h' file not found   #include <maxminddb.h>            ^~~~~~~~~~~~~   1 error generated.
Running MacOS 12.1

This is probably a more appropriate question for StackOverflow. You likely need to set your library and include search paths to include /usr/local.

Thanks. In case somebody gets here with the same issue. The problem is that the compile command is
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk<EMAIL_ADDRESS>-c extension/maxminddb.c -o build/temp.macosx-12-x86_64-3.9/extension/maxminddb.o -Wall -Wextra
instead of
clang -Wno-unused-result -Wsign-compare -Wunreachable-code -fno-common -dynamic -DNDEBUG -g -fwrapv -O3 -Wall -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX12.sdk<EMAIL_ADDRESS>-c extension/maxminddb.c -o build/temp.macosx-12-x86_64-3.9/extension/maxminddb.o -Wall -Wextra
A fix is to install maxminddb with the following flags
 pip install maxminddb --force-reinstall --verbose --no-cache-dir --global-option=build_ext --global-option="-I/usr/local/include/" --global-option="-L/usr/local/lib"


update docs for lrn

@mli, @zackchase, @madjam, @Roshrini , @indhub @jiajiechen
Please review

No but they don't saturate! I'm referring specifically to the comment about
normalization. Perhaps it was copied from the doc for a different
activation function that actually does saturate?
On Thu, Apr 20, 2017 at 1:49 PM, Naveen Swamy<EMAIL_ADDRESS>wrote:

@nswamy commented on this pull request.
In src/operator/lrn.cc
https://github.com/dmlc/mxnet/pull/5913#discussion_r112517847:

.add_arguments(LRNParam::FIELDS())
-.describe("Apply convolution to input then add a bias.");
+.describe(R"code(Applies Local Response Normalization to the input.

+Normalization helps in generalization and used to prevent neurons from
LRN is applied on a ReLU neuron. Are ReLU neurons also considered
squashing neurons ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/dmlc/mxnet/pull/5913#discussion_r112517847, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACR4zrbe7IwspDGuuM0ht0jeT7bLBgvyks5rx5qYgaJpZM4NC5_0
.


NaN not colorized as number in debug console

Testing #35324
Repo

In a js debug session, type NaN in the debug console

Bug
NaN is not colorized as a number:

What the heck, the node2 version packaged in the vscode build is not the right version.

@joaomoreno or @sandy081, this is because Matt and I have the previous version of node2 in ~/.vscode-insiders/extensions. It shouldn't be there since this is a built-in extension. Do you have any idea whether vscode could have copied it there for some reason?
Another symptom is that when I look for it in the extensions viewlet, it shows a "Reload" button.

I can install it to that folder with ext install. I don't know if there's a legit use case but if someone types in the extension id, they probably know what they're doing.

@roblourens I do not think VS Code would have copied it. May I know if you would have installed by mistake?
I am not sure if ext install should support it or not. IMO it should not.
@joaomoreno what's your opinion?

It was a version that was only there for a short period a couple weeks ago, and I don't remember installing it manually.

I probably put it there for some reason.


Introduce unit tests

After the first functionality is ready, it is time to introduce unit tests to ensure correct functionality.

In this issue what is only relevant is to provide the basic structure, not full coverage. Tests should be boyscouted or implemented in parallel to new features.
Issues in which one has to create only tests are not working very well in my experience...


Fall back to object storage later for worker hashtrees.

The initial call to GetChunk for worker clients will succeed even if the
requested chunk isn't present. Since we don't rely on streaming
behavior, just read the whole chunk before deciding whether to fall back
to object storage.

I think this should probably be restructured so that we read directly into the cache instead of into an in-memory buffer. The cache Put call should delete the entry if an error occurs during the read.


Fixes #5235 Stock Visual Terrain

#5235 not sure if this is an appropriate identifier for the mod? Guidance would be appreciated.

I see Ive been beaten to the punch by a day, should have checked both Issues AND Pull Requests... looks like @linuxgurugamer s version is better than mine, covers the mac as well.


Expose way to configure RollingSummary

RollingSummary was internally introduced here https://github.com/metrics-rs/metrics/pull/306
But there is currently no way for the user to configure how long data is held onto for high level users of metrics/metrics-exporter-prometheus

Yeah, this is a reasonable request. I would accept a PR adding methods to the builder that allow configuring the bucket width and count.

It looks like this was already done in https://github.com/metrics-rs/metrics/pull/444

Yep, just awaiting a release of metrics-exporter-prometheus, which should hopefully be doable somewhere between today and the next seven days. I've been queueing up a lot of changes to bundle together.

Released in<EMAIL_ADDRESS>


Update steering members

Ref: https://github.com/kubernetes/steering/pull/157
/hold
until https://github.com/kubernetes/steering/pull/157 has merged

/lgtm

/lgtm

/hold cancel
https://github.com/kubernetes/steering/pull/157 has merged

/approve


Fix the error in Doc: How to Open a Homebrew Pull Request

The Doc How to Open a Homebrew Pull Request has some errors, which may mislead user contributors. To be specific,

--build-from-source is for formula only.
brew test is for formula only.

This pull request is to separate the tests for formulae/cask related changes.

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[x] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?

https://github.com/Homebrew/brew/pull/17236#issue-2280961635


🌐 Update English translation for docs/en/docs/tutorial/first-steps.md

Apologies for the previous pull request! Still getting used to using git/github...
A recap of the changes to this doc:

Simplified language and combined sentences to improve readability
Re-ordered and re-named headers to improve clarity
Restructured explanations to focus on the core function of the doc (to help users get started rather than learning about something)

I'm not a programmer, so I would appreciate any and all feedback!
In response to discussion #11636

Thanks! I prefer to preserve the current version, so I'll close this one. But thanks for the interest! :coffee:


Add value in result filter is not possible inside an variable

In a variable, if we add an example filter contains, it is not possible to enter a value.
(It's the same for equals, contains ....)

Version Details:

Grafana version : 9.1.6
Plugin version : last version

+1


Support Negativo17 Fedora Packaging

Support the Negativo17 Nvidia driver packaging for Fedora. libdevice libraries are under /usr/share/cuda, includes are under /usr/include/cuda and libraries are under /usr/lib64. This PR should help #8264 too.
In addition, the gcc 5.3 in the Negativo17 repository (installed as /usr/bin/gcc53) only has a static non-PIC version of libgomp.a, so I have this local patch to force Tensorflow to link to the global (/usr/lib64) shared version:
diff --git a/tensorflow/contrib/cmake/tf_stream_executor.cmake b/tensorflow/contrib/cmake/tf_stream_executor.cmake
index 91ca33f4c4..7719ee096d 100644
--- a/tensorflow/contrib/cmake/tf_stream_executor.cmake
+++ b/tensorflow/contrib/cmake/tf_stream_executor.cmake
@@ -75,7 +75,7 @@ endif()
 #list(REMOVE_ITEM tf_stream_executor_srcs ${tf_stream_executor_test_srcs})

 if (NOT WIN32)
-  set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -lgomp")
+  set (CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -l:libgomp.so.1")
 endif (NOT WIN32)
 add_library(tf_stream_executor OBJECT ${tf_stream_executor_srcs})

diff --git a/third_party/gpus/cuda/BUILD.tpl b/third_party/gpus/cuda/BUILD.tpl
index b752734a08..0ce972291e 100644
--- a/third_party/gpus/cuda/BUILD.tpl
+++ b/third_party/gpus/cuda/BUILD.tpl
@@ -109,7 +109,7 @@ cc_library(
         ".",
         "cuda/include",
     ],
-    linkopts = ["-lgomp"],
+    linkopts = ["-l:libgomp.so.1"],
     linkstatic = 1,
     visibility = ["//visibility:public"],
 )
diff --git a/third_party/toolchains/gpus/cuda/BUILD b/third_party/toolchains/gpus/cuda/BUILD
index 39136de99c..6f697919fd 100644
--- a/third_party/toolchains/gpus/cuda/BUILD
+++ b/third_party/toolchains/gpus/cuda/BUILD
@@ -114,7 +114,7 @@ cc_library(
         ".",
         "cuda/include",
     ],
-    linkopts = ["-lgomp"],
+    linkopts = ["-l:libgomp.so.1"],
     linkstatic = 1,
     visibility = ["//visibility:public"],
 )

Building with clang is a lot more difficult, as it'd require making Tensorflow's CUDA symlink repo look enough like the unpacked tarball to pass this detection logic!
My .tf_configure.bazelrc (for FC 26) looks like:
build --action_env PYTHON_BIN_PATH="/home/nicholas/miniconda3/bin/python"
build --action_env PYTHON_LIB_PATH="/home/nicholas/miniconda3/lib/python3.6/site-packages"
build --force_python=py3
build --host_force_python=py3
build --python_path="/home/nicholas/miniconda3/bin/python"
build --define with_jemalloc=true
build:gcp --define with_gcp_support=true
build:hdfs --define with_hdfs_support=true
build:s3 --define with_s3_support=true
build:xla --define with_xla_support=true
build:gdr --define with_gdr_support=true
build:verbs --define with_verbs_support=true
build --action_env TF_NEED_OPENCL_SYCL="0"
build --action_env TF_NEED_CUDA="1"
build --action_env CUDA_TOOLKIT_PATH="/usr"
build --action_env TF_CUDA_VERSION="8.0"
build --action_env CUDNN_INSTALL_PATH="/usr"
build --action_env TF_CUDNN_VERSION="7"
build --action_env NVVMIR_LIBRARY_DIR="/usr/share/cuda"
build --action_env TF_CUDA_COMPUTE_CAPABILITIES="6.1"
build --action_env TF_CUDA_CLANG="0"
build --action_env GCC_HOST_COMPILER_PATH="/usr/bin/gcc53"
build --config=cuda
test --config=cuda
build --define grpc_no_ares=true
build:opt --copt=-march=native
build:opt --host_copt=-march=native
build:opt --define with_default_optimizations=true
build --copt=-DGEMMLOWP_ALLOW_SLOW_SCALAR_FALLBACK
build --host_copt=-DGEMMLOWP_ALLOW_SLOW_SCALAR_FALLBACK
build:mkl --define using_mkl=true
build:mkl -c opt
build:monolithic --define framework_shared_object=false
build --define framework_shared_object=true
build:android --crosstool_top=//external:android/crosstool
build:android --host_crosstool_top=@bazel_tools//tools/cpp:toolchain
build:android_arm --config=android
build:android_arm --cpu=armeabi-v7a
build:android_arm64 --config=android
build:android_arm64 --cpu=arm64-v8a

Can one of the admins verify this patch?

I am not sure about if the added complexity warrants the benefit we will get with the new code.
We can rely on LD_LIBRARY_PATH to find most of the binaries for cuda anyway, if you add /usr/lib64 to your library path, do you still need all the patches?
If we are to add support for these drivers, I think this needs to be done the following way:

The code needs more comments (for example, what is nvvm).
It needs to be written into cuda_configure.bzl.
Most importantly, rather than adding specific logic for this driver, we should add support for this specific driver package by making cuda_configure.bzl more flexible. What I mean by this is rather than hardcoding all the locations for the specific package, the cuda configuration code should search for more alternate locations for the libraries it needs.

@martinwicke @zheng-xq to comment on support for this unofficial driver package
@davidzchen to comment on cuda_configure code.
After we receive comments, I would probably clsoe this PR, and maybe we can start a github issue and continue conversation on that.


simultaneous view of incoming and outgoing calls

Hi falks,
You are awesome!
I was wondering about the python call hierarchy feature and when it would land in vs code,
after digging into documentation and publications -
https://code.visualstudio.com/updates/v1_33#_call-hierarchy
and https://devblogs.microsoft.com/python/announcing-pylance-fast-feature-rich-language-support-for-python-in-visual-studio-code/
I'm able to utilize in the call hierarchy for python - incoming and outgoing calls,
cool, thank you for this nice addition to vscode capabilities.
Maybe it's possible to setup the view of call hierarchy in a manner that the user will be able to see both incoming and outgoing calls simultaneously?
For example split the view/panel into two sections: incoming and outgoing.
Thank you very much
Elia.
versions details -
VS Code Version: 1.49.2
<EMAIL_ADDRESS><EMAIL_ADDRESS>

This is entirely on VS Code to implement; we'll respond to any request given to us by the editor and there's nothing stopping is from answering both. It's just that VS Code's UI is written in a specific way where it's one panel. You'd need to suggest this change on their repo.
Unfortunately, we don't have the permission to transfer the issue there, but opening a new feature request there (or maybe finding an existing one) would be the best idea anyway because their templates ask for different information than ours.


Update rds data service

Please help keep the CHANGELOG up to date by providing a one sentence summary of your change:
updates rds data service with most recent botocore version

Just noting this comes after https://github.com/rusoto/rusoto/pull/1436

@softprops can you want to rebase this after the crate regen done in the other PR? Thanks! 😄

This can be closed. Regenerating all services in https://github.com/rusoto/rusoto/pull/1436#issuecomment-501253964 would have picked up these changes


Replacing with string that contains quotation

Suppose that I want to replace a string with a json object.
original file:
<key>old_value</key>
using this json:
"key" : "$(my_value)"
where my_value is a env variable. Suppose that my_value is a string that contains quotation mark, something like
my_value = string"string"maybeJson
When doing the replacement, the json replacement is no longer valid json. I tried escaping the value of my_value but that didn't work because TFS adds double escape. Any idea how to do this?

In the example above, the following transformations do not work:
{ "key" : "value with ""}
{ "key" : "value with """}
When instead, the usual transformation works out-of-the-box:
{ "key" : "value without quotes"}

Found the workaround:
{ "key" : "value with \u0022"}

+1. Same situation. I got $x = '<bla"blabla"bla>'
{
"parameter" : "$(x)"
}
and got the same error.
@sergeyzwezdin Any option to escape quotes in json transformation?


fixed an error when using pjax with google analytics

options.analytics() didn't have any param. so ga("send", "pageview", {"page": options.url, "title": options.title}) got an error Cannot read property 'url' of undefined.
I fixed it by replaced with ga("send", "pageview", {"page": location.pathname, "title": document.title}).

@MoOx, Could you merge this and make a release? I have the same issue.

Better than nothing. Thanks !


Add telemetry to see what percentage of users do not have Python 3 installed

As more Python code comes out that is Python 3-only this may start to become an important thing to know for running services within the extension like mypy and black which are Python 3-only but work on Python 2 code.

@brettcannon
I'm capturing the following telemetry as well:

Version of python in workspace
Number of workspace folders (lets us know how many people are using multi-root setups).

Do let me know if this is unnecessary or if we need some other info.
FYI - The version info does not contain any PII, its built using sys.version_info and folder count, is a number


Add policy and definition of what should be included in the POI layer

I believe there is an almost endless range of POIs that could be included in the POI layer.
If the shortbread schema is going to be used more, I predict lots of feature requests to add this or that POI to the list of POIs that should be present, plus of course discussions whether or not it satisfies any loosely or not loosely defined policy for inclusion. This will be hard.
So from the perspective of keeping the maintenance and also the possible points of contention low, the following solutions might be the best, though of course, they come each with obvious drawbacks:

don't include POIs at all in the shortbread schema. This means no maintenance at all, but then, shortbread could not be a complete map as far as end user usage is concerned.

policy-wise, only include POIs that are included in another OSM project, i.e. move the decision somewhere else. The most obvious would be the iD tagging schema and since it's maintenance is sponsored by OSMF, the current maintainer is very cautious to seek or wait for consensus on doubtful cases. JOSM presets or osm-carto (if it is then still maintained) would be options, too. All these options (except osm-carto) though do not solve the classification which map feature exactly should classify as a POI and which not. E.g. a traffic sign is certainly a map feature for which a preset exists or could exist, but it is not really a POI.
We had a long discussion about this in StreetComplete. In the end, we settled towards having an overlay for "Places", roughly defined as "Map features like shops or amenities that usually have a name and can be entered". These are separate from "Things" shown in another overlay, like benches, bins, trees, lanterns, recycling, flagpoles. Anyway, policy-wise, we chose to write that places and things are only added to the list if they are already contained in the iD presets, to save us the prefiltering and discussion.
EveryDoor, by the way, has a similar separation between places and things.

Do look at the links to the "Places" (and maybe "Things"), they contain many POIs I would consider should go into the POI overlay anyway. I just recently thoroughly researched this list via osm wiki and taginfo.
I could... create a feature request or PR for these, but I think it is important to settle on some form of inclusion policy and definition what exactly falls under a POI first.

I could... create a feature request or PR for these

Any PR is going to have to go against a separate set of files for version 1.1 of the schema. I don't think we're ready to create that yet, and I know I'd like to get the bugs fixed in 1.0 before copying it to start 1.1


⚠ ClamAV has degraded performance

In 827ccaf, ClamAV (https://spamassassin.apache.org/) experienced degraded performance:

HTTP code: 200
Response time: 83 ms

Resolved: ClamAV performance has improved in 0ea5d8e after 5 minutes.


[DO NOT MERGE] Move pv-like from cl

Refer to https://github.com/obophenotype/brain_data_standards_ontologies/issues/231
@shawntanzk will handle merging etc.

totally forgot that this needed all the declarations etc.
probably easier to just do it in protege and all
will close this ticket


Flaky test covering update in src dir in cli_test

https://github.com/denoland/fresh/pull/1353 introduced a flaky test. I didn't note the first time I saw it fail, but the second and the third.
The issue is something liike:
error: NotFound: No such file or directory (os error 2): rename '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/e8b1d7f8/src/fresh.gen.ts' -> '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/e8b1d7f8/fresh.gen.ts'

or
error: PermissionDenied: Access is denied. (os error 5): rename 'C:\Users\RUNNER~1\AppData\Local\Temp\7a5dd5d2\src\fresh.gen.ts' -> 'C:\Users\RUNNER~1\AppData\Local\Temp\7a5dd5d2\fresh.gen.ts'

For context, the test is:
await t.step("execute update command src dir", async () => {
  const names = [
    "components",
    "islands",
    "routes",
    "static",
    "dev.ts",
    "main.ts",
    "fresh.gen.ts",
  ];
  try {
    Deno.mkdirSync(tmpDirName + "/src");
    names.forEach((x) => {
      Deno.rename(path.join(tmpDirName, x), path.join(tmpDirName, "src", x));
    });
    await updateAndVerify(
      /The manifest has been generated for (?!0 routes and 0 islands)\d+ routes and \d+ islands./,
    );
  } finally {
    names.forEach((x) => {
      Deno.rename(path.join(tmpDirName, "src", x), path.join(tmpDirName, x));
    });
    await retry(() => Deno.remove(tmpDirName + "/src", { recursive: true }));
  }
});

I'll see if I can reproduce this by running deno task test a bunch locally.

I've reproduced it locally.
deno run --unstable --allow-run flaky_test_tester.ts
Run #1
Run #2
Run #3
Run #4
Run #5
Run #6
Run #7
Test failed with error: Task test deno test -A --parallel && deno check --config=www/deno.json www/main.ts www/dev.ts && deno check init.ts
error: Uncaught NotFound: No such file or directory (os error 2): rename '/var/folders/k1/2hmcgqk93w5flb8ky_cfxc200000gn/T/406f50f9/src/islands' -> '/var/folders/k1/2hmcgqk93w5flb8ky_cfxc200000gn/T/406f50f9/islands'
    at async Object.rename (ext:deno_fs/30_fs.js:216:3)

Run #8
Run #9
Run #10
Test run completed. 10 runs, 1 failures.

I've applied a fix and I've cranked the iterations up to 100. I'll come back in about an hour and open a PR if there are no failures.

Deno.rename on line 379 should be either awaited or changed to Deno.renameSync. I'd change both (yours and on L379) to sync and remove retry, as it'll be most likely fixed whe moved to sync version.

Thanks, this is probably better than what I did. I will retest it now...

The issue is moving it out of the src directory, in the finally block.

Exactly, which is caused by the missing file, as it was not properly moved on time by the L379 😅
L379 scheduled: /tmp/foo.js => /tmp/src/foo.js
L386 triggered: /tmp/src/foo.js => /tmp/foo.js (might still be called `/tmp/foo.js` at this point as L379 was not awaited)

🤦 I see, thanks.


Extend to not just pkgs/by-name

Recently there was an automated mass removal of lib.mdDoc which now requires subsequent PRs whenever a PR that introduces more instances gets merged.
The approach used by nixpkgs-check-by-name makes sure that this problem doesn't happen. We should consider integrating such treewide removals to benefit from that. This will also be relevant for the upcoming automated pkgs/by-name migration.
In particular, while this tool currently only has infrastructure for detecting when new instances of deprecated patterns are introduced, I've been planning to add infrastructure to also do automated replacements of such deprecated patterns.
For now I haven't gotten to that, but let's use this issue to track such developments.

In particular, while this tool currently only has infrastructure for detecting when new instances of deprecated patterns are introduced, I've been planning to add infrastructure to also do automated replacements of such deprecated patterns.

how would that look like? i have little idea of how the (i assume) relevant github APIs look like, nor of the check-by-name tool, but as I'm at fault for the mass-mdDoc removal & wrote the tool which did it, I could probably (if desired) write some kind of interface for it that's useful to this, either as a cli tool that can be called by this checker, or even as a rust crate, as it can already search for syntactic patterns & "edit" (read: currently only remove) them.

@stuebinm Thanks for the interest! I just took the time to write it down in a high level here: https://github.com/NixOS/nixpkgs-check-by-name/issues/56. Turned out a bit long, but it's important context.
I think the nixpkgs-check-by-name tool is really on a good path towards becoming super useful for various future deprecations of Nixpkgs patterns. And the codebase is in a really good place right now, with clean code, lots of comments, documentation, tests and automation. Since moving it to this separate repo, I've also onboarded @philiptaron and @willbush with commit access and am very open to extending that. So if you're interested, please consider joining the effort in making this the best CI tool for Nixpkgs :D
While we primarily work asynchronously via GitHub, we sometimes use the Nixpkgs Architecture Matrix room or my weekly office hours to synchronise. Would be great if you could join those!


Allow angular5

Hi,
angular 5 is almost out (currently at RC7)
Codelyzers peerDependencies still state <5.0.0 though.
Any reasons not to bump it?
We were working with a fork of yours, so far everything is stable.
https://github.com/kurier/codelyzer/commit/3c18cff13e5d8af258425d93a4d6f15e526bb995
Thank you!

https://github.com/mgechev/codelyzer/pull/439


Feat:Make Navbar disappear on scrolling upwards

Describe the feature
I would like to request the addition of a feature where the navbar disappears when scrolling upwards and reappears when scrolling downwards. This feature will enhance the user experience by providing more screen space when reading content and ensuring easy access to navigation when needed.
Add ScreenShots
.
Record

[X] I agree to follow this project's Code of Conduct
[X] I'm a GSSOC'24 contributor
[X] I want to work on this issue

Assigned!
Make sure to attach before & after screenshots in your PR and include the issue number.
Also, please star the repo before working on it.
I am the project mentor so you can always reach out to me for any help!
Happy open-source contributing!

@kashnx , are u still working on this issue , or I would i to work on

I am working.


Dropdown not working

Expected Behavior
Opening a simple dropdown like in the docs.
Current Behavior
Dropdown doesn't open, it shows an error:
Uncaught TypeError: Cannot read property 'getBoundingClientRect' of null
Steps to Reproduce (for bugs)

Copy the exact code from the docs
Get the error

Context
I was trying to create a dropdown.
Your Environment

Version used: 1.0.0 (jQuery 3.4.1)
Browser Name and version: Opera Developer 63.0.3353.0
Operating System and version (desktop or mobile): Desktop Windows 10 64 Bits

Try using the following fiddle as a reference: [https://jsfiddle.net/omqks6ge/1/]


feat: add exclude parameter that defines exclusion patterns

It works much like struct_patterns, but only excludes structs from check.

@mbilski ping again


Replace proc-macro-error proc-macro2-diagnostics

Fixes #61

@bash, would you be able to investigate what the nightly error is in CI?

Sure thing :)
From a quick glance it seems that the difference comes from the fact that on nightly proc-macro's built-in diagnostics are used whereas on stable a shim is used instead. The two impls format slightly differently.
Would you be ok with separate "expected" files for stable vs. nightly?

I would dislike that very much. What is the difference? Could we solve it using a less strict comparison in those tests?
and is there really no way to have it behave the same on both stable and nightly?

That's fair enough :) I think it's some minor differences (indentation, prefix). I'll take a closer look though

That's fair enough :) I think it's some minor differences (indentation, prefix). I'll take a closer look though

The difference just boils down to indentation if we just look at the help.
Relaxing the duplicate_macrotest to ignore leading/trailing whitespace on each line makes the tests pass :)
stable
error: Wrong argument count for substitution identifier.
       = help: The same substitution identifier must take the same number of argument across all substitution groups.
       Example:
           [
               ident1(arg1, arg2)  [sub1 arg1 arg2]
                      ^^^^^^^^^^
           ]
           [
               ident1(arg1, arg2)  [arg1 arg2 sub2]
                      ^^^^^^^^^^
           ]

  --> tests/tests.rs:15:3
   |
15 |         name     [sub1]
   |         ^^^^

nightly
error: Wrong argument count for substitution identifier.
  --> tests/tests.rs:15:3
   |
15 |         name     [sub1]
   |         ^^^^
   |
   = help: The same substitution identifier must take the same number of argument across all substitution groups.
           Example:
               [
                   ident1(arg1, arg2)  [sub1 arg1 arg2]
                          ^^^^^^^^^^
               ]
               [
                   ident1(arg1, arg2)  [arg1 arg2 sub2]
                          ^^^^^^^^^^
               ]

@bash thank you for all the work on this PR. Everything seems to be working now, so I will merge this.
I don't know exactly when I'm going to be able to release a version including these changes, but I'll do my best.

I don't know exactly when I'm going to be able to release a version including these changes, but I'll do my best.

Take your time 😊
I'm just happy that syn 1.x will disappear from my dependency tree eventually :)


Variable naming conventions in Java

Many classes are having variable names in lower case with hyphens. Shall I mind changing them to lowerCamelCase (according to Java Conventions)?

ok. you can proceed.

Closed via #359


Xnero: Watch (?-i:ynp8Ndh)(?#cutt.ly)

Xnero requests the watch of the watch_keyword (?-i:ynp8Ndh)(?#cutt.ly). See the MS search here and the Stack Exchange search in text, in URLs, and in code.

(?-i:ynp8Ndh)(?#cutt.ly) has been seen in 1 true positive, 0 false positives, and 0 NAAs.

Rejected by cigien in Charcoal HQ. Reason: 'accidentally watched this already, didn't realize a PR had been made'


[Event Parameter change] codeunit 22 "Item Jnl.-Post Line" - OnBeforeFlushOperation and PostFlushedConsump

In our addon we are in dire need of some extra critical component flushing with item tracking when flushing is manual and the first operation starts with a particular component "Lot No.".
The event OnBeforeFlushOperation needs the global variable LastOperation as a new parameter and more importantly the property IncludeSender = true set. We all know what happens if you are not in possession of the last item ledger entry no. or current item register etc.
We would like to reuse procedure PostFlushedConsump in that case and for it to work it must be set to local = false. In a subscriber codeunit we can then us:
sender.PostFlushedConsump(ProdOrder, ProdOrderLine, ProdOrderComponent, ProdOrderRoutingLine, ItemJnlLine);
local procedure FlushOperation(ProdOrder: Record "Production Order"; ProdOrderLine: Record "Prod. Order Line")
var
    ProdOrderRoutingLine: Record "Prod. Order Routing Line";
    ProdOrderComp: Record "Prod. Order Component";
    OldItemJnlLine: Record "Item Journal Line";
    OldTempSplitItemJnlLine: Record "Item Journal Line" temporary;
    OldItemTrackingCode: Record "Item Tracking Code";
    OldItemTrackingSetup: Record "Item Tracking Setup";
    xCalledFromInvtPutawayPick: Boolean;
begin
    //OnBeforeFlushOperation(ProdOrder, ProdOrderLine, ItemJnlLine); A200F0000.Event.o
    OnBeforeFlushOperation(ProdOrder, ProdOrderLine, ItemJnlLine, LastOperation); //A200F0000.Event.n

Event Signature:
[IntegrationEvent(true, false)]
local procedure OnBeforeFlushOperation(var ProdOrder: Record "Production Order"; var ProdOrderLine: Record "Prod. Order Line"; var ItemJnlLine: Record "Item Journal Line"; LastOperation: Boolean);
begin
    //A200F0000.Event Parameter LastOperation; IncludeSender = true
end;

procedure PostFlushedConsump(ProdOrder: Record "Production Order"; ProdOrderLine: Record "Prod. Order Line"; ProdOrderComp: Record "Prod. Order Component"; var ProdOrderRoutingLine: Record "Prod. Order Routing Line"; OldItemJnlLine: Record "Item Journal Line")
var
    ...
    IsHandled: Boolean;
begin
    //A108F0000.Event18.03 local=false

Please create a dedicated request for making PostFlushedConsump global


Ver0.71.1 Chinese translation for TilDeath, _fallback, and Rebirth

Tested with newest 0.71.1 executable

Wasnt expecting this so quickly. I planned on adding full translation support to Rebirth at some point and I guess it needs to be done now. Some strings are a little non-trivial to have translated for now

Wasnt expecting this so quickly. I planned on adding full translation support to Rebirth at some point and I guess it needs to be done now. Some strings are a little non-trivial to have translated for now

In this case I can hold back from translating Rebirth. I don't use Rebirth so I don't have a good idea of what everything is doing.

ok this literally took forever for me to get to but I've finished translation support for Rebirth on the latest develop as of now. go ahead and redo/rebase this PR on that if you want

Finally get back to this, not sure I if did this correctly tbh

after switching the target branch to develop, its looking good. i can tell it isnt finished, but it would work in its current state

gonna merge this so we can have a good point to pick up and continue these changes from


plexus-interactivity-api 1.0-alpha-4

Type: Missing
Summary:
plexus-interactivity-api 1.0-alpha-4
Details:
ClearlyDefined pom no license info found
Maven license field is Apache-2.0: https://mvnrepository.com/artifact/org.codehaus.plexus/plexus-interactivity-api/1.0-alpha-4
Maven pom does not have license info
Resolution:
Apache-2.0
Affected definitions:

plexus-interactivity-api 1.0-alpha-4

The source file headers have the MIT license. I am not able to find anything in the contents that declares Apache. mvnrepository.com is not a canonical license source.
Updated to MIT.


[Improvement] Fullfill Roll requests from chat with User Main Actor when Party Token is selected

First things first: Foundry v11.315, PF2 5.15.1, verified in a empty PF2 test world without active Modules (Active Module count: 0!)
When you request rolls from players from chat (for example with the system included "Generate Check Prompt" Macro) the system seem to use the following options to determine which Actor is used to roll the Check Prompt for the player:
If you have selected a token, the stats from that token are used to roll.
If you have not selected a token on the actual scene the stats from the "Main Character" selected in the User configuration seem to be used.  This, up to this point, seem to make total sense for me.
If you use the Party Token and give your users access to that token (for example: let the user move around the token on a map to indicate where the Party is located) and the Party Token is selected the Check Prompt Rolls does not work out since the system seem not to be able to do the roll with that special actor (which, absolutely, make sense as this is a special actor). On the UI side nothing seem to happen, on the Javascript Console you get the message "PF2e System | Skip rolling unknown statistic athletics".
My wish for improvement: Could you include a "special" rule for the selected party actor token (since Party Actor is anyway build-in special this should be possible to simple hard code) to act like "if you have the party token selected act like no token is selected and just roll with the main character of the user".
This seem to make totally sense for me to behave that way since, meanwhile, it will get a little bit annoying to remind your players continously with "you must deselect the party token first before you try to role that check, that's the reason why nothing happens".
(And yes, I know I could unpack the party token or directly place only user tokens or don't give users access to that token and only move it by myself. But I just want let my users control the party token and they should still be able to roll checks uncomplicated :) ).

(And in general just default to User's Character when no token selected and user has Ownership of multiple actors)

This occurs because of Kingmaker. I'll try to find a way to fulfill this without breaking kingmaker. EDIT: Fixing this one is incredibly risky due to the code's fragility. I will wait till after V12 for this, given its not a major bug.

Maybe this is at least possible to look at the Kingmaker Campaign Feature setting in a way like "ok if the Kingmaker feature is not activated then.." to decide to handle the Party Token special. That make it work for most games then (but yes, as a developer myself I understand the inner struggle that the system starts to behave differently depending on a setting that the user will never connect to that one Kingmaker checkbox in the settings is awful, too).
And v12 is totally fine, as said would be a nice improvement 🙂

I will have to rework the actor selection code to handle this scenario is the thing. And its kinda scary to do something like that when we're wrapping up the final releases for v11.
What I'll likely end up doing is filtering out all tokens that are a party that do not own that statistic (or if the statistic is flat). And if this occurs and the list is now empty, fall back to the assigned character.


Show the title of the component along with the component name in the content tree.

As of now, the content tree only shows the component name, so if we have nested instances of the same component, it looks a bit hard in some cases to identify the specific component from the content tree. If we just added some unique user-friendly titles for all the components along with the component name, it would be helpful to identify the components easily.

Some components does not have visible titles, maybe we could even allow to add a title only to be able to mark it here.
The same title could be displayed in the component marker in the editor. @paweljozwicki I think the ticket is very valid.

Totally agree. The possibility to add a title for each component definitely should help, but I think we should consider some automation whenever it will be possible.

You could easily check for title property and if thats not there use node name, as its always helpfull to know that. Maybe even as the tooltip for the title.


Are events delivered to all origins at once?

There's some discussion about whether delivering a global event to all origins at once is wise over at w3c/mediacapture-main#402 (in particular https://github.com/w3c/mediacapture-main/issues/402#issuecomment-251655134).
The counter argument is that the discovery that userx@origin1 and usery@origin2 is actually the same device is probably relatively easy to make if you were looking to make that connection.

@martinthomson could you elaborate on what type of correlation might be problematic for memory pressure signal?
Let's say we send the memory pressure signal to both the foreground and background tab within a short time interval. What privacy-related correlation problems are anticipated.

I would suggest to fire event only for active tabs. Inactive tabs usually get managed by browser if memory is problem, and theirs best time to react is on visibilitystate.
For security concerns I would suggest to fire events from the most memory consuming to the lowest with unspecified delay in between. Many implementations might be async thus require some time before the save will actually occurs.


How to implement this in Apollo Server 2

Hello,
I'm just wondering given the new syntax of Apollo Server 2:
const server = new ApolloServer({ typeDefs, resolvers });
server.applyMiddleware({ app });

how would one apply this middleware?

You don't need to, it's built in 🎉
You can see the docs here: https://www.apollographql.com/docs/apollo-server/v2/features/file-uploads.html

Mm, ok. I do seem to be able to find anything about this in the documentation from this plugin. So to be clear, since Apollo 2.0, this plugin is no longer necessary or is it loaded automatically? Can you elaborate on this?

This project is not a plugin. It is Express and Koa middleware, along with a GraphQL scalar, to add upload support to most GraphQL servers (I've used it with 3 different kinds).
apollo-server v2 uses this package built in, so yes, it is "loaded automatically". You will need to handle uploads appropriately in your resolvers of course. Keep in mind that apollo-server uses a version of this project that is several versions out of date, and has since-fixed vulnerabilities.


Issue using 20.10

I noticed the other day that because we parse the renderman version as a float, i.e float(20.10) the mantissa gets set to .1  We should split the major and minor version parsing in util get_rmantree so that 20.10 is found as the latest version.  As is 20.10 gets parsed as 20.1, i.e < 20.9

Checked in.


Possible to pass fastlane a .app or .zip?

Good Day,
I would like to know if it's possible to pass fastlane a .app or .zip file that contains the app instead of passing a .ipa file through for the App Store side of things?
This would be awesome if it's possible would solve so many of my problems...
Regards

Hey @darkreaper101, an ipa file is just a compressed .app folder. You can easily add this to your Fastfile:
lane :beta
  `zip .....` # your custom shell command to prepare the ipa file
  deliver
end

Ah okay cool thanks sorry still new to the whole IOS thing. :smile:


Commit in 3.0 introduces bug, using "id" instead of "pk" for django models.

Describe the bug
skip_row has stopped working for us because in this commit https://github.com/django-import-export/django-import-export/commit/0ba35826da51f437f91c87a90029c17a928c921e a check has been introduced in skip_row that uses v.id, v being a django model instance. In our project, as in many, id does not exist, it's been replaced by a field called uuid that is used as primary key. The intended code should use v.pk which works regardless of the name of the primary key.
The error I get is:
Line number: 1 - 'SSPFilter' object has no attribute 'id'

The erroneous code is:
if sorted(v.id for v in instance_values) != sorted(v.id for v in original_values):
    return False

Versions (please complete the following information):

Django Import Export 3.0
Python 3.10
Django 4.0

Expected behavior
Nothing is thrown.
PR to fix: https://github.com/django-import-export/django-import-export/pull/1436

Thanks for raising (and for PR) - I'll look into it.


Reset scan results on scan start and remove connected vehicles out of scan results

This PR does 2 things:

It resets the scan results when a new scan is started to avoid getting a very long list (of possibly duplicate results)
When a connection is established the device is removed from the scan result list

Please test it with multiple cars. Until now it could only be tested locally with a single car

Force push due to rebase

Already implemented in other way. thank you for your work


Add resources readiness checks for helm/manifest

How to categorize this PR?

/area quality
/kind enhancement
/priority normal
What this PR does / why we need it:
This commit adds Readiness checks for workload resource types based
on the resource status provided by Kubernetes.
It fixes a bug for the helm and manifests deployers that occurs when
trying to update resources with immutable field that are set on the
server side like ClusterIP or the ResourceVersion.
It fixes a bug for the helm and manifests deployers that
could occur during the deletion of the deploy items if the managed
resources in status have never been updated due to errors in the
Kubernetes manifests.
For the helm deployer, it removes the decoding of the status
when deleting the files because it is already done during the
creation of the new Helm struct.
Signed-off-by: lcavajani<EMAIL_ADDRESS>Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
This is the first part of https://github.com/gardener/landscaper/issues/21 to keep the PR smaller.
Release note:

Add resources readiness checks for helm/manifest

Thank you @lcavajani for your contribution. Before I can start building your PR, a member of the organization must set the required label(s) {'reviewed/ok-to-test'}. Once started, you can check the build status in the PR checks section below.

I've addressed the requested changes, PTAL, Thanks :smile:

sry but I think you need again a rebase
/rebase

/ok-to-test

@schrodit I've addressed the changes, PTAL
hope this is good this time :sweat_smile:

/test

@lcavajani Thank you for all the changes so far. Currently, integration tests fail for the Helm deployer and Helm charts that have a NOTES.txt in them. I heard that you may be busy with other, more important tasks atm, so I may take over and open a PR from my fork (and cherry-pick your changes over) if this is OK to you.

@MrBatschner no problem, thanks for taking over :wink:

close in favor of https://github.com/gardener/landscaper/pull/134


Acceleration bands

Implementation of the Acceleration bands. #1066

Nice work @Jay-Jay-D, thanks for the review @MartinMoli !