[Addition]:

Hotspot b58 Addresses
13JCMzrRUzhLyhB7vy1dqHLiwtSW7fQtbZCDjEmCrcnrQj3HwXE          wallet
113rB5WvBwsN6V1cjjEWW9HQRATuGriJ4zS3tgkNVDACcjJxjSz
11eQuKF7YTK8DyYM25aQ9iUqfHC89Ch73MbUEkjstiN9yG3683X
11Hp3PoRypLwdbNW37ntniRQyy49qMe3DL3oyfF31vjkLmVRnYf
112hkJ3UsNwGS2wcMR79aTDbULRfwiVTJTznasJXUWqCxHaFfaBK
112N2NGYgp38f7aqbKQDZLYXYyquTgqs9XvdjaR5FELvqucxnTQH
1126pCaHs4xt73UH7yJyT4d1EWZAXX55AaxZoRuZE1so1wodnj2Y
112Ea3NmfMtKEN1e2hvkvE6FHinyQvwA13WYrPtQtGtu9z15cnUD
11gPTvzwvTFMcCp9UrnacUjmDGFe6VRHYVkLSKo6THCjCiYHwa3
112Tb38SCnvL6tjMq9D7HKECpGTt7e45SjSXjCJx4AJQctmYPbVo
112iJUYN66PNKwy5vhuUsuqWcFEkVPq1U2dCmogPxfo8L3NdWxAx
112ByfF2QJKFYTxrMZZTsZWw2jjDeBWkiR7zyij6YGK9BuG4hto7
119PW7VGczmNrtMQqxcYdHAFbdKQAtbr3kj9vijjvjnbrRbaCNx
112rN2FJR5HpzugYdLTZjzkH6hpLWcX1U76xfEfE82DjgDs2QSi4
11h9DYcnNsBUg8jrbRUJyeB9DobS3q1N4RSz99cfn8R3mbdQGrq
Discord Handle
No response
Reason(s)
these spots are set in my environment and in a field I know well. They were all set up in western France and turned on in one day in the vicinity of my city. This wallet and hotspots is set in the woods and along the river near my home. Gaming anyway
I just post one wallet but in area around Zagreb they sets few wallet with around 100 Pisces Miner hotspots

Thank you for your submission. This has been reviewed and may be considered for a future change to the denylist. If any change will be made, it'll likely be in the next 1-2 weeks assuming (1) it is proposed to be added, (2) denylist signers agree on the change, and (3) the release is published to all Hotspots. Please do not open additional issues regarding these Hotspots.

Today that gaming cluster  pisces minees around Zagreb start again to recive rewards.
Nothing has been done from helium side.


[Bug] Worker pods crash unexpectedly when gcs_server on head pod is killed

Search before asking

[X] I searched the issues and found no similar issues.

KubeRay Component
Others
What happened + What you expected to happen
TODO
Reproduction script
TODO
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

cc @sihanwang41 @shrekris-anyscale
re: The potential impact on Ray Serve FT

This might be because worker health check failed which results in the worker failure.
GCS failure -> worker raylet failure -> Kuberay detected health problem and restarted worker.

Ah, then we should look into the worker health check. Probably @iycheng is the most knowledgeable there?


autoconf: missing runtime dependency on /bin/sed, /bin/expr, basename,...

Describe the bug
autoconf is a shell script that uses /bin/sh interpreter and some utilities like sed inside, both of which are breaking out of nixpkgs to /bin/sed or other default locations.
Note: it could be tricky to resolve if there are circular bootstrap dependencies.
Steps To Reproduce
Steps to reproduce the behavior:

nix why-depends nixpkgs.autoconf nixpkgs.gnused

'nixpkgs.autoconf' does not depend on 'nixpkgs.gnused'

grep "\<sed\>" $(nix-build '<nixpkgs>' -A autoconf)/bin/autoconf

    sed '/^.*\/\([^/][^/]*\)\/*$/{
	 *\'*) arg=`$as_echo "$1" | sed "s/'/'\\\\\\\\''/g"` ;; #'
	 *\'*) arg=`$as_echo "$2" | sed "s/'/'\\\\\\\\''/g"` ;; #'
       traces="$traces --trace='"`$as_echo "$optarg" | sed "s/'/'\\\\\\\\''/g"`"'"
       traces="$traces --trace='"`$as_echo "$2" | sed "s/'/'\\\\\\\\''/g"`"'"

head -n 1 nix-build '' -A autoconf/bin/autoconf

#! /bin/sh

strace -f $(nix-build '<nixpkgs>' -A autoconf)/bin/autoconf -W "'foobar'" 2>&1 | grep exec

execve("/nix/store/f85bcv4kdmknxwpi175vnfmrr0f4xvgs-autoconf-2.69/bin/autoconf", ["/nix/store/f85bcv4kdmknxwpi175vn"..., "-W", "'foobar'"], 0x7ffe683d9da8 /* 58 vars */) = 0
[pid 29411] write(1, "noexec         \toff\n", 20 <unfinished ...>
[pid 29409] <... read resumed>"noexec         \toff\n", 512) = 20
[pid 29424] execve("/usr/bin/expr", ["expr", "a", ":", "\\(a\\)"], 0x55bcd4c67a20 /* 61 vars */) = 0
[pid 29425] execve("/usr/bin/expr", ["expr", "00001", ":", ".*\\(...\\)"], 0x55bcd4c67a20 /* 61 vars */) = 0
[pid 29426] execve("/usr/bin/basename", ["basename", "--", "/"], 0x55bcd4c67a20 /* 61 vars */) = 0
[pid 29428] execve("/usr/bin/basename", ["basename", "--", "/"], 0x55bcd4c67a20 /* 61 vars */) = 0
[pid 29430] execve("/usr/bin/basename", ["basename", "--", "/nix/store/f85bcv4kdmknxwpi175vn"...], 0x55bcd4c67a20 /* 61 vars */) = 0
[pid 29431] execve("/usr/bin/expr", ["expr", "x-W", ":", "x\\(--[^=]*\\)", "|", "x-W", ":", "x\\(-.\\)"], 0x55bcd4c704a0 /* 61 vars */) = 0
[pid 29432] execve("/usr/bin/expr", ["expr", "x-W", ":", "x--[^=]*=\\(.*\\)", "|", "x-W", ":", "x-.\\(.*\\)"], 0x55bcd4c704a0 /* 61 vars */) = 0
[pid 29435] execve("/bin/sed", ["sed", "s/'/'\\\\''/g"], 0x55bcd4c704a0 /* 61 vars */) = 0

Expected behavior
Runtime dependencies of autoconf should be captured in nixpkgs, it should be using nixpkgs utilities (ideally applies to both sh and sed). Some tricks may be required to make nixpkgs bootstrapping work.
Notify maintainers
@andir
Metadata
Please run nix-shell -p nix-info --run "nix-info -m" and paste the result.
[user@system:~]$ nix-shell -p nix-info --run "nix-info -m"
 - system: `"x86_64-linux"`
 - host os: `Linux 5.4.80-gentoo-r1, Gentoo, noversion`
 - multi-user?: `yes`
 - sandbox: `yes`
 - version: `nix-env (Nix) 2.3.15`
 - channels(divanorama): `"nixgl, nixpkgs-21.11pre312229.08ef0f28e3a, stable2009-20.09.4393.068984c00e0, stable2105-21.05.2873.6bfe71f2a4e, nixos-18.03-18.03.133402.cb0e20d6db9"`
 - nixpkgs: `/nix/var/nix/profiles/per-user/root/channels/nixpkgs`

Maintainer information:
# a list of nixpkgs attributes affected by the problem
attribute:
- autoconf
# a list of nixos modules affected by the problem
module:

since autoconf should always be used in nix-shell, so with what stdenv provides in the $PATH, we could eschew potential bootstrapping issues by replacing /bin/sed by sed etc.

While you're working on this, I learned something in the last few weeks that might be relevant ( maybe not ). autoconf is written such that the scripts it generates with autom4te using the m4sh macros become runtime dependent on these scripts as well. In theory very few projects actually install things that include m4sugar or m4sh; but I know some do.
I searched over all of the autom4te files that are packaged with autotools; and from what I can tell share/aclocal/libtool.m4 is the only file which attempts to find sed at /bin/sed ( on my copy it's line 8238 ). This works by hard coding the absolute path to sed into libtool - this will cause autoconf to depend on "out of scope" paths. This would only occur in cases where the user explicitly has PATH=/bin:... ( which I suspect is common outside of NixOS environments ) so its not surprising that this wasn't detected earlier.
My recommendation is to actually focus a patch on autom4te and autoconf by wrapping them explicitly to purify PATH and ACLOCAL_PATH which may contain .m4 files with uncontrolled inputs. Wrapping autom4te in particular is important because it is often called to generate scripts that may be installed in rare cases.


DownloadDistmapResult fails with many parts

Hi Daniel, we had now some problems when downloading results with many parts. The download would fail claiming that a file did not exist.  The part exists and is ok, though, and can also be downloaded manually and looked at without problems.  It also will not necessarily fail on the same part again, e.g., we had failure on parts 179, 165, 167, 178 on four subsequent download attempts.  TMP_DIR was set to a partition that had plenty of space and -Xmx8g.  We have never seen a problem with sets smaller than 150 or so parts.  What do you make of that?  (Debug output of one download attempt attached.)
download+merge.out.gz

@robmaz - thanks for the report. I think that the error is related more with the HDFS and the cluster configuration and network overload than with ReadTools itself. My conclusion comes from the fact that:

If a part is considered to download, it was already tested to be existant. Thus, at startup ReadTools already detected the file there although downstream cannot read it.
Re-running does not fail in the part again. That suggest a problem with the network connection - how many people is using the cluster?

Maybe an option is to decrease the --numberOfParts argument, to access less number of batches. That is a temporary solution, but I recommend you to look at the network and hdfs configuration to try to fix it. Let me know if that works.
From the ReadTools side, I will dig more where the problem is happening and I might add an option to retry the read operation if it fails; nevertheless, I am afraid that it won't work if the network failure happen in the middle of the process of a single file (which might be the case sometimes, as it looks like a non-deterministic thing).


Not working over all

I installed it on my mac but it's not working even I am not able to open its toggle

Duplicate of https://github.com/icetee/remote-ftp/issues/839#issuecomment-313857979


[Wallet] Fixing fatal error when escrow gas estimation fails

Description
Gas estimation failure throws with a string rather than an error object, which was causing the app the to crash.
This PR just addresses the fatal error. The root cause is that that the doFetchSentPayments saga is sometimes getting disrupted by geth connectivity issues. When geth connection is reestablished, the saga is not continued. This results in redeemed escrow payments erroneously showing up as reclaimable for the user, which in turn was causing the fatal error.
It appears to only be happening with doFetchSentPayments rather than tokenFetchFactory, which implies the issue may be with getContractKit.
Other changes
N/A
Tested
Yes
Related issues

Sentry: https://sentry.io/organizations/celo/issues/1890055944/?environment=co.clabs.valora&project=1250733&query=c.error.message.include

Partially addresses #5086

Backwards compatibility
Yes

@tarikbellamine I have verified this task on latest Android internal build v1.1.0(1004294311) & iOS test flight build v1.1.0(23) and observed the following

Escrow payment received notification is not shown after pasting invite code.
Escrow payment Received notification is shown after verifying phone number.
Please let me know if i need to verify any thing else?
Thanks!

@Lss-Ankit I think that is good for now!


Add docker-compose for configV2

We have one under /demos/traces for legacy config. It serves users both as an example and quick way to run tests. We should include the metrics in the composer too (with a prometheus server).

Several PRs have done this already.


How can I install Graphite in Windows?

How can I install Graphite in Windows and how can I connect my JVM instance to be monitored in a Windows machine? Would much appreciate it if someone can help with the steps.

As per the official docs, Graphite is not supported natively on Windows. However, you can run Graphite in a virtual machine on Windows. The Graphite website has a quickstart guide for doing precisely this using the Synthesize project.


Error when get metrics Hypervisor

2018-10-25 08:56:22,440:ERROR:'HypervisorStats' object has no attribute 'extra_config'
2018-10-25 08:56:22,441:ERROR:failed to get data for cache key hypervisor_stats
                free = ((int(self.extra_config['cpu_ratio'] *
                             m_vcpus)) -
                        m_vcpus_used)

nova_aggregates[agg]['metrics']['free_vcpus'] += free

To fix this issue you will need to change the variable extra_config['cpu_ratio'] to self.cpu_overcommit_ratio
We can see that a similar code is being called with correct variables;
ree = (int(self.cpu_overcommit_ratio * m_vcpus)) - m_vcpus_used             cache_stats.append({                 'stat_name': 'free_vcpus',                 'stat_value': free,                 'host': host,             })
So if we match that, and produce:
for agg in nova_aggregates.keys():                 agg_hosts = nova_aggregates[agg]['hosts']                 if host in agg_hosts:                     free = ((int(self.cpu_overcommit_ratio  *                                  m_vcpus)) -                             m_vcpus_used)                     nova_aggregates[agg]['metrics']['free_vcpus'] += free
We find that the code is working properly. I will be submitting a patch for this to att-comdev, but until then this is the fix.

Thank a lot!


Type error when following @pothos/plugin-prisma instructions

Hello!
I'm running on node v20.5.1 with typescript 5.3.3 and I'm seeing the following type error when I try to build the example of @pothos/plugin-prisma. I've been trying to understand why the plugin type isn't satisfied but I'm banging my head against the wall and i think there might be a problem😅.
Here's the error:
src/index.ts:18:13 - error TS2322: Type 'typeof PrismaPlugin' is not assignable to type 'keyof Plugins<SchemaTypes>'.

18   plugins: [PrismaPlugin, SmartSubscriptionsPlugin],

The example:
import { createServer } from "node:http";

import { createYoga } from "graphql-yoga";
import SchemaBuilder from "@pothos/core";
import SmartSubscriptionsPlugin, {
  subscribeOptionsFromIterator,
} from "@pothos/plugin-smart-subscriptions";
import pubsub from "./pubsub";
import { PrismaPlugin } from "@pothos/plugin-prisma";
import type PrismaTypes from "@pothos/plugin-prisma/generated";
import { PrismaClient } from "@prisma/client";

const prisma = new PrismaClient({});

const builder = new SchemaBuilder<{
  PrismaTypes: PrismaTypes;
}>({
  plugins: [PrismaPlugin, SmartSubscriptionsPlugin],

  prisma: {
    client: prisma,
    // defaults to false, uses /// comments from prisma schema as descriptions
    // for object types, relations and exposed fields.
    // descriptions can be omitted by setting description to false
    // exposeDescriptions: boolean | { models: boolean, fields: boolean },
    // use where clause from prismaRelatedConnection for totalCount (will true by default in next major version)
    filterConnectionTotalCount: true,
    // warn when not using a query parameter correctly
    onUnusedQuery: process.env.NODE_ENV === "production" ? null : "warn",
  },
  smartSubscriptions: {
    ...subscribeOptionsFromIterator((name) => {
      return pubsub.asyncIterator(name);
    }),
  },
});

builder.queryType({
  fields: (t) => ({
    hello: t.string({
      smartSubscription: true,
      subscribe() {
        pubsub.asyncIterator("hello");
      },
      args: {
        name: t.arg.string(),
      },
      resolve: (parent, { name }) => `hello, ${name || "World"}`,
    }),
  }),
});

const yoga = createYoga({
  schema: builder.toSchema(),
});

const server = createServer(yoga);

server.listen(3000, () => {
  console.log("Visit http://localhost:3000/graphql");
});

Here are my dependencies:
"dependencies": {
    "@graphql-yoga/node": "^3.9.1",
    "@pothos/core": "^3.41.0",
    "@pothos/plugin-prisma": "^3.63.0",
    "@pothos/plugin-smart-subscriptions": "^3.7.1",
    "@prisma/client": "^5.7.1",
    "graphql": "^16.8.1",
    "graphql-subscriptions": "^2.0.0"
  },
  "devDependencies": {
    "@types/node": "^20.10.6",
    "prisma": "^5.7.1",
    "ts-node": "^10.9.2",
    "typescript": "^5.3.3"
  }

Here is my tsconfig:
{
  "compilerOptions": {
    "target": "es2016",
    "module": "commonjs",
    "esModuleInterop": true,
    "forceConsistentCasingInFileNames": true,
    "strict": true,
    "strictNullChecks": true,
    "skipLibCheck": true
  }
}

You need to use the default export of the Prisma plugin


Pilot does not remove old endpoints from Envoy

Bug description
Repeat of https://github.com/istio/istio/issues/9480
The bug was fixed (https://github.com/istio/istio/pull/9805) on 1.0 branch and never made it to 1.1 branch. 😞
TL;DR: Endpoints are removed from k8s but never removed from envoy.
Expected behavior
Endpoints should be removed from envoy very quickly after they are removed from k8s.
Steps to reproduce the bug
Run helloworld sample. Scale down the deployment to 0 replicas and watch the endpoints (istioctl proxy-config endpoints sleep-57f9d6fd6b-8lx6p.sample --cluster outbound|5000||helloworld.sample.svc.cluster.local) and notice that they take many minutes to go away.
Version
1.1.2
How was Istio installed?
helm template + kubectl apply
Environment where bug was observed (cloud vendor, OS, etc)
GKE

I'm pretty worried about the fact we're not porting bug fixes across branches, resulting in regressions during upgrades.

Should leave this open until this is fixed on master

@dwradcliffe I think we can close this as #13470 cherry picked the change to master.

Yep, thanks for that!


what If the recognized noise samples are removed

Did you do any experiment if the recognized noise samples are removed, and train model with "clean" samples with CE loss?
if not, do you think this will work somehow?
Many thanks!

Hi
Nice idea, we tried, but the issue is that 1. this requires two times of training, 2. this would result in a very small dataset when the noise level is high. Empirically it always results in worse performance than other methods, but of course, better performance than CE perhaps especially when the noise level is low.
Please let me know if you have other questions.
Sheng

Thanks for your prompt reply!


question: demo rvm files

Since you have been working with RVM files Im wondering if you have any demo RVM files of different sizes you can share?
All files I have is company files, so I can't really show anyone videos from a web viewer I've been working on that use your rvm parser result

Unfortunately not, the only public model I know of is pmuc's sample data file:
https://github.com/benvautrin/pmuc/tree/master/data

ok, thank you.
Was hoping to find model on 500-1000mb size

Thanks, that is very interesting!

Nice.
Finally a rvm file I can share some of my weird stuff Ive been doing at work/private :-)
@Strepto thx

Finally got around to try the RVM files

Nice!

Even made a small video: https://www.youtube.com/watch?v=FzTHbogfr5k

Very impressive video!

@Strepto
Thx, Im lucky @cdyk made this RVM parser, tried to use E3D ifc export, but was easier to use RVM part so we could reused already exported files.
I just need to learn more c++ so I can optimise it a little for my weird needs for my custom format I need in backend.


Resize and automatically hide attachment carousel arrows

Details

Resized the attachment carousel arrows smaller and will automatically hide if there is no interactions.
Fixed Issues

$ https://github.com/Expensify/App/issues/15896
PROPOSAL: https://github.com/Expensify/App/issues/15896#issuecomment-1478163372
Tests

Same as QA Steps

[x] Verify that no errors appear in the JS console

Offline tests

Same as QA Steps
QA Steps

Android/iOS/mWeb

Open any chat
Send an image, a protected pdf, and another image
Open the protected PDF
Verify the arrows don't cover the text
Verify the arrows are hidden after 3 seconds
Press the attachment to show the arrows
Hold down the arrows
Verify the arrows don't hide even after 3 seconds (not possible in mWeb because holding down the arrow will select a text)
Keep pressing the arrows (next/prev)
Verify the arrows don't hide even after 3 seconds
Stop and wait for 3 seconds
Verify the arrows now are hidden

[x] Verify that no errors appear in the JS console

PR Author Checklist

[x] I linked the correct issue in the ### Fixed Issues section above
[x] I wrote clear testing steps that cover the changes made in this PR

[x] I added steps for local testing in the Tests section
[x] I added steps for the expected offline behavior in the Offline steps section
[x] I added steps for Staging and/or Production testing in the QA steps section
[x] I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
[x] I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).

[x] I included screenshots or videos for tests on all platforms
[x] I ran the tests on all platforms & verified they passed on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
[x] I followed proper code patterns (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method

[x] If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:

[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I followed the guidelines as stated in the Review Guidelines
[x] I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] I verified that if a function's arguments changed that all usages have also been updated correctly
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

https://user-images.githubusercontent.com/50919443/231655913-4217daa3-0330-432c-a3b2-77799e4cf2bb.mov

Mobile Web - Safari

https://user-images.githubusercontent.com/50919443/231656228-91f53c6d-8852-4968-a7a6-4542d3e1c91c.mov

Desktop

iOS

Android

https://user-images.githubusercontent.com/50919443/231656040-52f2d921-bda3-4356-ab83-7598b0dc60ea.mov

PR is ready @parasharrajat.
Because automatically hide arrows is only available on mobile, I don't know what test steps to write that QA can verify the resized arrow for both Desktop/Web. I want to write "verify the arrows size are smaller then the current arrows", but it sounds confusing, so I just write a test step for mobile.
Here is how it looks on resized desktop when the attachment is hovered.

size 40

size 44

I personally prefer 40, but you can see the arrow is misaligned. To solve it, we can apply this style:
alignItems: 'center',
paddingHorizontal: 0,
paddingTop: 0,
paddingBottom: 0,

We want to clear the padding that comes from small button style, but we can't just set padding: 0 because it does not work (ref).
40 after correcting the alignment style

What is your take on this?

On desktop/web, we need to resize it very small which I think real user won't use the app with the small window.
For Android Chrome (which the only platform that still resize the modal), I don't think it would disturb the user as the arrows will be automatically hidden now.

updated

BUG: The button should not hide when the user is long pressing over hovering over the icons themselves.

Solved when the user long press. I don't get the hovering part. The auto hide arrow is only for mobile screen, so we can't hover over it, except when we use emulator.

BUG: it feels weird when the user is navigating between images via arrow keys and they auto-hide after an image switch.

Solved.

Suggestion: let's keep the same margin from edges on Web| desktop displays.

Do you mean a different style for web? I also thinks the arrow is really near the edge in web/desktop.

done!

BUG: mweb: Even if arrows are hidden clicking on their position triggers image navigation.

I found that onMouseEnter event is called even on touch screen, but not always. When we press the hidden button, it will trigger the onMouseEnter and show the arrow and at the same time will trigger the onPress. This bug only happen on Android Chrome. So, I disable the enter and leave event on touch screen device.

BUG: mWEB: It takes two clicks to see the arrow buttons after autoHide.

I can't reproduce this issue. Can you test again? Maybe it will be resolved after the new changes.

Conflict solved!
Don't forget to take a look at this one @parasharrajat
Btw, I think we can ignore my comment https://github.com/Expensify/App/pull/17269#issuecomment-1507885722 for now because looks like we are planning to change canUseTouchScreen to hasHoverSupport based on the concern here https://github.com/Expensify/App/issues/15988#issuecomment-1514845649

Bump on here too @parasharrajat

[x] I have verified the author checklist is complete (all boxes are checked off).
[x] I verified the correct issue is linked in the ### Fixed Issues section above
[x] I verified testing steps are clear and they cover the changes made in this PR

[x] I verified the steps for local testing are in the Tests section
[x] I verified the steps for Staging and/or Production testing are in the QA steps section
[x] I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
[x] I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)

[x] I checked that screenshots or videos are included for tests on all platforms
[x] I included screenshots or videos for tests on all platforms
[x] I verified tests pass on all platforms & I tested again on:

[x] Android / native
[x] Android / Chrome
[x] iOS / native
[x] iOS / Safari
[x] MacOS / Chrome / Safari
[x] MacOS / Desktop

[x] If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
[x] I verified proper code patterns were followed (see Reviewing the code)

[x] I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
[x] I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
[x] I verified that comments were added to code that is not self explanatory
[x] I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
[x] I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
[x] I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
[x] I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
[x] I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
[x] I verified the JSDocs style guidelines (in STYLE.md) were followed

[x] If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
[x] I verified that this PR follows the guidelines as stated in the Review Guidelines
[x] I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
[x] I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
[x] I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
[x] If a new component is created I verified that:

[x] A similar component doesn't exist in the codebase
[x] All props are defined accurately and each prop has a /** comment above it */
[x] The file is named correctly
[x] The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
[x] The only data being stored in the state is data necessary for rendering and nothing else
[x] For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
[x] Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
[x] All JSX used for rendering exists in the render method
[x] The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions

[x] If any new file was added I verified that:

[x] The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory

[x] If a new CSS style is added I verified that:

[x] A similar style doesn't already exist
[x] The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)

[x] If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
[x] If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
[x] If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
[x] If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
[x] If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
[x] I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

@parasharrajat looks like you may have to update your review checklist w/ the latest checklist please 🙏

:hand: This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.8-0 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.8-8 🚀

platform
result

🤖 android 🤖
success ✅

🖥 desktop 🖥
success ✅

🍎 iOS 🍎
success ✅

🕸 web 🕸
success ✅


Potentially outdated default value for RestrictDriverInstallationToAdministrators

Multiple rule lists define the Point and Print driver installation restriction with the default value of 0:
https://github.com/scipag/HardeningKitty/search?q=RestrictDriverInstallationToAdministrators
Meanwhile, according to the documentation:
"Windows updates released August 10, 2021 and later will, by default, require administrative privilege to install drivers."
I don't know if HardeningKitty can take into account the current update level of the target system. If it can't, maybe the updated default could be reflected in lists used for builds released after the above date?

HardeningKitty has (for the moment) no feature to use version or patch level information for finding lists. Therefore I decided setting the default value to NULL.
I recommend setting this value in any case, and if it is not explicit set this will be a finding. This issue is addressed in the development repo and will be updated here in the next update.


[fix][ci] Increase Pulsar IO job timeout to 90 minutes

Motivation

the tests in Pulsar IO are extremely slow and could cause the current 75 minute limit to exceed.

Modifications

increase timeout from 75 minutes to 90 minutes

Additional context
Pulsar IO should be moved from the main apache/pulsar repository to it's own repository.
This was decided already in 2020 with PIP-62, but the progress on that has stalled.
Documentation

[ ] doc
[ ] doc-required
[x] doc-not-needed
[ ] doc-complete

recent example of a timeout: https://github.com/apache/pulsar/actions/runs/5062670222/jobs/9092430926?pr=20379

For example, PulsarSinkTests takes over 22 minutes to execute: https://ge.apache.org/scans/tests?search.rootProjectNames=Pulsar&search.timeZoneId=Europe/Helsinki&tests.container=org.apache.pulsar.tests.integration.io.sinks.PulsarSinksTest&tests.sortField=MEAN_DURATION
That is the slowest test class that we have in apache/pulsar: https://ge.apache.org/scans/tests?search.rootProjectNames=Pulsar&search.timeZoneId=Europe/Helsinki&tests.sortField=MEAN_DURATION

Elasticsearch tests took over 12 minutes here: https://ge.apache.org/s/ge3kvi7torsxq/performance/execution#goal-mlju2z5u77bvw . Also seen here: https://ge.apache.org/s/ge3kvi7torsxq/tests/overview .#20382
It would be helpful to split Elasticsearch Pulsar IO unit tests to it's own test group.

I'll close this PR and instead split Elasticsearch tests to a new group (build job).

New PR #20384


Rename "Azure Cognitive Search" to "Azure AI Search".

There are few places, but in labs/03-orchestration/README.md we need to rename it.

done

I think you forgot a couple of places under 04 Python.
Caused some confusion for us.

Ok we will take a look, but we will also gladly accept a PR ;-)

Was just helping a friend, but I might spend some time going through the lab myself - if so I'll send a PR to correct as I see fit :)

I think all references to Cognitive Search are gone now.


UI Changes

This is built off of CJ's PR #341 which added a theming library that added dark mode if the user's OS theme was set to dark mode. I've expanded this as well as adding and updating many UI features.
Additions:

Added an option to set the theme of the randomizer to Light, Dark, or Auto
Added an option to set a theme preset to Default, High Contrast, or Readability. This is independent of the theme option and each preset has a light and dark variant
Added an option to set a custom theme. This is done via a popout window and saved to custom_theme.json just like settings.txt
Added an option to set the curved edges of the randomizer to be sharp and pointy
Added an option to set the font family used by the randomizer
Added an option to set the font point size used by the randomizer (6-14pt; default is 10pt)
Added a "Copy Settings String" button (uses a library that supports Linux, Windows, and Mac)
Added OpenDyslexic3 font family and enables it when using the Readability

Changes:

Updated and standardized option help text (now with bold emphasis)
Moved Lightning Skyward Strike option up above Starry Skies
Removed leftover Hero Mode toggle
Standardized the spacing between the include/exclude, remove/add, and disable/enable buttons for excluded locations, starting items, and tricks
Fix UI scaling - the randomizer will now scale when resized

Converted to draft as the underlying dependent PR is still unmerged

Bri'ish go brrrr xD
Yep, sounds like a good organization choice (nudge nugde root directory)
Yep, same again
Yeah, I can see your point here. I just used options.yaml since it already existed and there's already a mechanism that backs-up the options to settings.txt.

I still feel like settings.txt is the right place for the UI options to live, I'll have a look at getting the parsing of it and see if I can get it to ignore the UI options for the main rando and ignore the rando options for the UI stuff.
I don't think a separate file is necessary. Integrating this directly into the rando seems like the simpler solution - at least for right now.

Interesting you mention the Accessibility tab since I was thinking of either moving everything to the separate window or moving the theme picker stuff into the empty space on that tab. My only concern is, if we move all the UI options into the separate window, where should the button to open that window live?

I haven't looked at the Menu widgets yet so I don't understand the appeal. Sounds like it might solve the "where should the button live" issue tho. Again, something for me to look at xD

Yep, makes sense

Converted to draft as the underlying dependent PR is still unmerged

I originally created a PR on to the underlying PR. However, this has deviated significantly from the original PR and includes bug fixes for it. This PR can stand alone separate from the original PR.

I've thought and actively tried to move the GUI settings out of options.yaml. I now, however, think this is unwise as I have found that I am merely duplicating code that already exists to make the other randomizer options work. It would be marginally nicer to have the UI options separated from the rest of the more core randomizer options however, in practice, all this does is creates a near identical system that needs to be maintained.

Menus don't seem hidden away to me, I'd even argue that they're more visible than any particular option on a given tab, since they're always visible (they're rendered at the window level rather than the UI level like other widgets). Technically, I used the wrong name, I was referring to specifically a Toolbar (Menus are one of the types of widgets within the Toolbar). Like I said in the original comment - toolbars offer a lot of potential flexibility in placing common actions within reach from every tab.
Further, putting customization/accessibility options behind a menu in a toolbar in desktop is extremely common, and apps often follow similar patterns in placement (i.e. File -> Settings) in order to make the experience more consistent for users with accessibility challenges, which makes it easier for them to find and activate the features they need. Even if it not the perfectly ideal placement, maintaining status quo is more important here, since diverging (somewhat counterintuitively) can actually decrease accessibility.
If we elect not to use a toolbar, I think a simple "Customize" button on the lower segment of the UI (outside of the tab region) will be more than sufficient for launching the full dialog. I'm not particularly pressed about precisely where the button goes, it could even be on the Setup tab, although I'm more partial to having it be accessible from all tabs.

 Needs testing :p

Tested:
-Cancelling a colour change doesn't set colour to black: works
-Scrolling the font list doesn't print warnings in the console: works
-Search functionality: works
-Multiselect in item/location/trick lists: works
-Nothing gets cut off when resizing the screen: works
-Copy settings string button: works
-Dark/light toggle: works
-High contrast and readability toggle: works
-Sharp corners button: works
-Font and font size changes: works
-Custom theme changes and saves on reopen: works
-Updated tooltip text: looks good

General question - does having separate light and dark themes really make sense, rather than having light and dark just be presets?

Each of the Default, High Contrast, and Readability presets have light and dark variants. This would make 6 presets by default. It would also mean the user would have to define light and dark custom presets separately and couldn't use the auto option with their custom presets

Menus don't seem hidden away to me, I'd even argue that they're more visible than any particular option on a given tab, since they're always visible (they're rendered at the window level rather than the UI level like other widgets). Technically, I used the wrong name, I was referring to specifically a Toolbar (Menus are one of the types of widgets within the Toolbar). Like I said in the original comment - toolbars offer a lot of potential flexibility in placing common actions within reach from every tab.

It's an interesting idea but one that adds a new way users interact with the rando program. Adding a new place for things to live, just for the accessibility options, is confusing. If there are other things to populate a toolbar/menu with, it's worth looking into but definitely as a separate PR.

Further, putting customization/accessibility options behind a menu in a toolbar in desktop is extremely common, and apps often follow similar patterns in placement (i.e. File -> Settings) in order to make the experience more consistent for users with accessibility challenges, which makes it easier for them to find and activate the features they need. Even if it not the perfectly ideal placement, maintaining status quo is more important here, since diverging (somewhat counterintuitively) can actually decrease accessibility.

A counter example would be Discord. Accessibility is another tab in the settings window. The rando program is one big settings window so having the accessibility options as another tab makes sense to me.

If we elect not to use a toolbar, I think a simple "Customize" button on the lower segment of the UI (outside of the tab region) will be more than sufficient for launching the full dialog. I'm not particularly pressed about precisely where the button goes, it could even be on the Setup tab, although I'm more partial to having it be accessible from all tabs.

The main reason I've chosen not to move the accessibility options is that it is a very high effort change for very minimal gain. If there were a framework in place for having options in a dialog, it might be worth it (although it still boils down to aesthetics). Without a framework, there would need to be significant time and energy spent creating a system that allowed the accessibility settings to change while the dialog is open (so the user can see what they have changed) but also so it resets if the dialog is cancelled. The tricks dialog already has several exceptions made to make sure the options are saved correctly.
It doesn't make sense to me to delay this PR for what is essentially an aesthetic choice.

Looks really good, however I currently get an error when trying to change a color in the theme:
Traceback (most recent call last):
  File "ssrando/gui/components/color_button.py", line 31, in change_color
    options=QColorDialog.ShowAlphaChannel & self.showAlpha,
TypeError: unsupported operand type(s) for &: 'ColorDialogOption' and 'bool'

Could that be related to the recent dependency updates?

Seems the most likely cause, yeah. I'll have a look later.

Yep, it was a dependency thing :p

Tested: -Cancelling a colour change doesn't set colour to black: works -Scrolling the font list doesn't print warnings in the console: works -Search functionality: works -Multiselect in item/location/trick lists: works -Nothing gets cut off when resizing the screen: works -Copy settings string button: works -Dark/light toggle: works -High contrast and readability toggle: works -Sharp corners button: works -Font and font size changes: works -Custom theme changes and saves on reopen: works -Updated tooltip text: looks good

Redid same tests after dependency update- everything still works as it did


Add support for weight support of official stylegan2-ada

Hello resinality, thank you for your implementation, it helped me a lot.
Current Nvidia released the official implementation of stylegan2-ada(https://github.com/NVlabs/stylegan2-ada), but when I was trying to convert the weight trained by this repo, I got the following error:
Traceback (most recent call last):
  File "convert_weight.py", line 220, in <module>
    generator, discriminator, g_ema = pickle.load(f)
  File "/mnt/wfs/mmcommwfssz/project_mm-base-vision/secretwang/stylegan2_weight_convert/dnnlib/tflib/network.py", line 297, in __setstate__
    self._init_graph()
  File "/mnt/wfs/mmcommwfssz/project_mm-base-vision/secretwang/stylegan2_weight_convert/dnnlib/tflib/network.py", line 154, in _init_graph
    out_expr = self._build_func(*self.input_templates, **build_kwargs)
  File "<string>", line 439, in G_synthesis
  File "<string>", line 392, in layer
  File "<string>", line 105, in modulated_conv2d_layer
  File "<string>", line 50, in apply_bias_act
TypeError: fused_bias_act() got an unexpected keyword argument 'clamp'

I would like to know if you would add support for converting the weight for the official implementation, thank you!

I would have to look at this, but it seems like that it is the error related to official implementation.

Thank you for you quick reply, I will try to modify the code myself, thouch training script of the official repo works fine with me.

Does model structure or variable naming is different from the original stylegan2? I thought it will be similiar or same.

@rosinality it seems to be the environment problem, I can convert the aboved mentioned model in another mechine with my modified codes. Thank you for you kind help!


Is it possible to use WanaKana within a "contenteditable div", instead of an "input", or "textarea"?

Question
As the title says, can I bind WanaKana to a

, instead of an <input>, or a <textarea> element?
I would like the users to be able to style the text (bold, italic and underline). Hence, the preference for a contenteditable div.

It might be possible, though I can envision a few potential problems occurring such as wanakana attempting to convert any markers within the div for styling. If you only bound to inner elements it might be okay (e.g. if a user sets italic, you move the binding to within the styled element rather than the parent div which contains mixed content (text and styling markers). Depends how your text styling is handled I guess.
You could disable this early exit and give it a try.
https://github.com/WaniKani/WanaKana/blob/master/src/bind.js#L21
You could also ignore binding and handle the input conversion yourself with the methods provided, though you'll lose the benefits in the provided input handler (cursor repositioning etc).

I'm sorry if it is a dumb question, (I am just a hobbyist programmer) but how do I "disable that early exit"?
I saved the code at https://unpkg.com/wanakana as a file called wanakana.js.
Next, I linked it to my .html by putting  in the head of my .html document.
Then I opened the wanakana.js, looked for and deleted this part:
if (!Xf.includes(t.nodeName)) throw Error("Element provided to Wanakana bind() was not a valid input or textarea element.\n Received: (" + JSON.stringify(t) + ")");
But I still cannot use WanaKana inside a div. I guess I am doing this wrong...

That was the right code to remove based on my suggestion.
Looking deeper though, I see we convert the text that is contained within an element's value - which is not a property that exists on plain elements like divs. We could possibly switch to textContent.
Even if that was changed, you might still run into other issues using a plain element that is masquerading as an input. Although setting contentEditable does allow you to modify the contents of a div, and causes it to emit input events - it's still missing other aspects that come baked in with an input (for example composition events) which we rely on. TL;DR it becomes a pseudo-input, but not really.
This is probably outside the scope of the package's intent for real-time conversion, at least I don't personally have time to implement this at the moment.
You could go the other route of letting users enter their text, and only convert when they are finished / on submit.
You can use the Wanakana methods manually outside of bind.
const text = document.getElementById('wanakana-input').textContent;
const converted = wanakana.toHiragana(text);
// do what you want with converted text

I understand. Thank you for all your help!


Sub-Graph Example improvements after synthetic transactions support

Description:
Changes to Documentation:

added steps for HTS FT and NFT Tokens
Removed outdated relay and mirror node versions and changed it for a recommended local-node version
Updated GraphQL query URL to fix issue

Improvements to Task:

Avoid error when running transferHtsFT task for second time, error of account already associated.
Changed initial mint amount from 10 to 1000 to allow for much more transfer interactions of HTS FT Token.

Related issue(s):
Fixes #1628
Notes for reviewer:
Checklist

[x] Documented (Code comments, README, etc.)
[x] Tested (unit, integration, etc.)

Codecov Report
Patch coverage: 75.00% and project coverage change: -0.09% :warning:

Comparison is base (596f365) 78.60% compared to head (2b05a78) 78.52%.
 Consider uploading reports for the commit df3e048 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1630      +/-   ##
==========================================
- Coverage   78.60%   78.52%   -0.09%
==========================================
  Files          36       23      -13
  Lines        2674     2123     -551
  Branches      534      429     -105
==========================================
- Hits         2102     1667     -435
+ Misses        416      328      -88
+ Partials      156      128      -28

Files Changed
Coverage Δ

.../lib/services/ethService/ethFilterService/index.ts
94.28% <0.00%> (-5.72%)
:arrow_down:

packages/relay/src/lib/precheck.ts
58.53% <76.92%> (-28.05%)
:arrow_down:

packages/relay/src/lib/eth.ts
84.66% <100.00%> (+0.10%)
:arrow_up:

... and 15 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

SonarCloud Analysis is failing on code duplication on a expected.json file used in tests. I think a exception is valid in this case.


[Feature] New message notifications

Feature request from user:
"Once the chat window is minimized that the 3 little dots would turn from white to example green with a little bounce effect once there is a reply."
Also there is needed notification in the favicon in main SimpleChat.Support admin panel.

Update: from version 1.2.0 there are notifications in the title of simplechat.support app


XYZ-52: Adapts 'Enable Team Creation' on 'Users and Teams' page to re…

…ad/update permissions.
Summary
Similar to the Policy page permissions changes, this change updates a permission on a role based on the value of the radio input labelled "Enable Team Creation" in System Console -> General -> Users and Teams.
Ticket Link
XYZ-52
Checklist

[x] Ran make check-style to check for style errors (required for all pull requests)
[x] Ran make test to ensure unit and component tests passed
[x] Added or updated unit tests (required for all new features)

@jespino Updated.


feat: Finngen R10 harmonisation and preprocessing

Update Finngen to ingest R10 release.
Several enhancements on the way finngen studies are processed.
These changes have been used to harmonise (~4h) and preprocess [study index + window-based + ld clump + pics] (<30min)

Codecov Report
Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (42b366c) 85.67% compared to head (3860353) 85.66%.
Report is 23 commits behind head on dev.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #370      +/-   ##
==========================================
- Coverage   85.67%   85.66%   -0.02%
==========================================
  Files          89       91       +2
  Lines        2101     2141      +40
==========================================
+ Hits         1800     1834      +34
- Misses        301      307       +6

Files
Coverage Δ

src/airflow/dags/finngen_preprocess.py
100.00% <100.00%> (ø)

src/otg/dataset/l2g_feature_matrix.py
82.92% <ø> (+7.31%)
:arrow_up:

src/otg/datasource/finngen/study_index.py
100.00% <100.00%> (ø)

src/otg/datasource/finngen/summary_stats.py
100.00% <100.00%> (ø)

src/otg/method/l2g/evaluator.py
38.70% <100.00%> (ø)

src/otg/finngen_studies.py
91.66% <91.66%> (ø)

src/otg/finngen_sumstat_preprocess.py
91.66% <91.66%> (ø)

src/otg/method/l2g/model.py
58.33% <50.00%> (+0.50%)
:arrow_up:

src/airflow/dags/finngen_harmonisation.py
61.29% <61.29%> (ø)


Smart rockets implementation in CodePen

Demo can be found here: https://codepen.io/leimapapa/full/QJwjwE

Duplicate of #1551


Fixes PY2 compatibility

Hi Patvdleer, this fix works and has helped me. Hoping this gets merged already since you put this in back last year Sep 5, 2017. Thanks!


add base classes to init file

closes #134

you can just add more classes and review once done @vhirtham


Monday always first, even when start of week is sunday.

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior
When changing the start week to Sunday, all numbers and events on calendar move, coloring adjusts in boxes, but the names of the days never changes with it, so it's always wrong. Other calendars show fine just none of my revives. Any advice advice?
Expected behaviour
Monday header should be moved to the second column, etc.
Steps To Reproduce
Change start day.
See changes.
Day name header remains.
Mode
Event (default)
Card Version
Atmoic- calendar- revive
Home Assistant Version
Docker
Configuration
No response
Relevant log output
No response
Code of Conduct

[X] I agree to follow this project's Code of Conduct

Its not a bug with Atomic calendar. it appears to be a bug with the grid card or something else, as it works on a new revive calendar i just made..


Mobile VR: Bad tracking

Tested versions
Reproducible in 4.2.2 ---> MobileVrInterface docs
Not reproducible on 3.2 (working fine out of the box)
System information
Linux pop-os 22.04  I5 5200U - GT940M
Issue description
Phone: Redmi Note 8
Deploying on android native (cardboard-like phone thing) results in broken tracking, maybe it's using the wrong phone sensors, the Godot sensors demo project works almost fine, there, the left cube is very shaky (similar to the XR tracking result)  while the right one (Gyro + Grav) is smooth.
Additionally, in the XR, the yaw doesn't work at all.

In Godot 3.2 the (same code) works fine out of the box

https://github.com/godotengine/godot/assets/10299707/f6d572ff-4b85-41df-a1f8-c9f3c8d3d2df
Steps to reproduce
Build a simple 3d scene with a XROrigin3D and XRCamera3D, activate the MobileVRinterface as the docs say, deploy to android using the default export options and see the tracking issues.
Minimal reproduction project (MRP)
MRP.zip

a sidenote, the docs need some update due to get_viewport().xr = true becoming get_viewport().use_xr = true, if there are other changes then it might be very outdated

Please test this in 4.3 beta2, it is likely already fixed, I remember working on this awhile back.

Closing as assumed fixed, if you can still reproduce this in 4.3 please comment and this can be reopened


Provide a way to override default_plugins_host for all plugins at one time

https://issues.jenkins-ci.org/browse/INFRA-1060

Gaw - I will kick travis when the cert issue is sorted out.

👍 This looks good.  I'm going to merge it even though the acceptance tests are failing over the tls cert.  Lets switch to updates.jenkins.io in a separate PR.

Are we able to override the download for the swarm plugin? At the moment it's unable to be changed, and is still dependent on the main update server
https://github.com/jenkinsci/puppet-jenkins/blob/master/manifests/master.pp#L9-L11

@cam-itv , i think the PR https://github.com/jenkinsci/puppet-jenkins/pull/728 do the job


SMS support clarification / help

What is the current state of SMS support?  Particularly, I'm wondering how to receive 'new-message' webhook events from (& consequently respond to) non iMessage phone numbers.  My usecase is for the API/webhook, not necessarily the UI, though that would be nice too.
I noticed incoming SMS messages are not emitting webhooks, and I'm a bit confused giving the following PRs:
#109 Add enable SMS option so the listeners can emit SMS
#114 Add toggle for SMS support
#245 Removes SMS restrictions
#100 Adds withSMS params to messages enpoints
The first 2 of these cryptically refer to:
          My branch

Originally posted by @zlshames in https://github.com/BlueBubblesApp/bluebubbles-server/issues/114#issuecomment-739509496
Is there a branch I should be looking at as the above mentioned branches have been deleted since?  Is there a canonical branch to checkout the SMS Toggle feature?
I totally understand if SMS is not currently supported, if so, any pointers on how to do so would be a huge help!

I noticed the service field available in the chat/new API endpoint in chatRouter.ts. If I set service to SMS, the server always responds with 500 internal server error.

The BlueBubbles server only supports SMS forwarding. Which is used when you have a phone number linked to your iMessage account. When that's the case, SMS messages can go to your Mac which the BlueBubbles server can forward to clients. And clients can send SMS via the server. But you need a linked phone number.
Native SMS support in the client app is not yet supported. If you have a phone number linked and want to use SMS forwarding, don't use the service field, just set the SMS prefix for the Chat GUID when sending a message. For example: SMS;-;<address>

I had tried the SMS;-; prefixed GUIDs, turns out my issue was with the linked iPhone.
I was able to get SMS Forwarding working by:

on the iPhone of the linked phone number, enabling Text Message Forwarding for the mac running BlueBubbles
ensuring the iPhone was connected to Internet or cellular

If the iPhone is not online, the SMS messages will be queued and eventually fail to send unless the iPhone comes back online before the timeout. I didn't realize that this was also how the Messages app on MacOS functioned.
Are the iPhones the clients you refer to here that send SMS?:

SMS messages can go to your Mac which the BlueBubbles server can forward to clients. And clients can send SMS via the server.

What would be the functional difference between SMS forwarding & Native SMS? I mean, is it possible for the Messages app to send SMS without forwarding through an iPhone? That would be black magic!
@zlshames, thanks for the tips!

Native SMS wouldn't require the server at all technically. You'd be able to set BlueBubbles as your SMS app on Android too. But we don't do that


fix(dspy): prompt_eval_count occasionally is None and causes TypeError

References https://github.com/stanfordnlp/dspy/issues/293#issuecomment-2270834347
Approach provided and used  by @INF800   (https://github.com/stanfordnlp/dspy/issues/293#issuecomment-1921965485  , https://github.com/stanfordnlp/dspy/pull/325 )

Thanks @371258 !


unable to merge

kindly give us write access to merge the pull request

hey friend , don't worry , it was only an example to show you about how to commit and make changes.

I understand , this is due to it need to be reviewed before merge. I will merge it soon


Document that this project is inactive.

Like ribbon is https://github.com/Netflix/ribbon#project-status-on-maintenance and https://github.com/Netflix/ribbon/blob/master/OSSMETADATA

if this project is not being maintained then how would issues with this be resolved? As many would be using turbine application to have an aggregated view of hystrix circuit breaker dashboard.
Or is there any way to get the same functionality without using Turbine anymore?

@JagmohanSharma  I'm also wondering this — perhaps there are other implementations?


Adds --target-arch flag

Summary
Adds a --target-arch flag which causes the tool to only create a build pack for the target architecture. By default, it builds all architectures. It still supports the old format of buildpack which does not include arch information in the include-files field.
Use Cases
Resolves #330
I'm moving:

In addition, filter the metadata dependencies and only include those for the specified arch.

into #326 because it'll be easier to add there, cause it's not doing dependencies for multi-arch yet.
Checklist

[ ] I have viewed, signed, and submitted the Contributor License Agreement.
[ ] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[ ] I have added an integration test, if necessary.
[ ] I have reviewed the styleguide for guidance on my code quality.
[ ] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@braunsonm - Yes. For now, it will download everything that is in the metadata in buildpack.toml. You can filter dependencies with create-package, but presently it only works by id and by version, not by arch. That's what's going to be added as part of #326.
You could do something like the yj command I shared with you on Slack to apply a filter to buildpack.toml prior to running and create-package and that might help. I'm hoping to get #326 wrapped up in the next week or so. Then we can cut a release and get this shipped.

From your description on the issue it looks like it still wouldn't work unless you manually move the dependencies to the right directory as well.
I think we'll wait until that issue is also fixed before adopting this... for now we are going to have to keep pinning to old versions.


add text defs

addresses #350

Should be related to Uberon:'vagal neural crest'  @cmungall - is part_of the right relationship here?  Not clear to me from Uberon defs if they  apply to only prior to migration.   Seems this is a general issue with missing Uberon mappings between CL & Uberon NC terms.

Moved uberon - cl link issue to #638


Code Suggestion

Is your feature request related to a problem? Please describe.
Continuous topics from https://github.com/darccyy/mousr-old/issues/2
Describe the solution you'd like
I found a similar old repository https://github.com/4strid/mouse-control.autohotkey which has better cursor movement. I'm wondering if you could get the logic implemented the same way but better (key customisation).
Describe alternatives you've considered

The repository I mentioned above has a mode that intercepts keys to control the mouse and another to act like a regular keyboard (all keys disabled). I figured it'll be a good idea to have this implemented as well Nevermind! I completely forgot Alt+Insert exists.

I'm not an expert in AutoHotKey and am unable to open a PR but the best I can do is open an issue. Thanks again :)

Thanks for the suggestion! Version 1.1.0 has been released and might fix the mouse movement. I'm not too sure what is causing the stiffness... 👍

Thanks for the update! Unfortunately, the stiffness of the mouse still occurring.
https://user-images.githubusercontent.com/73813638/182976372-b1d1384a-1b12-4285-9ffd-5f51377e833f.mp4
Here's a video of how https://github.com/4strid/mouse-control.autohotkey works mouse movement works. I think you can search around in the repo's code and have them implemented.

Do you think that acceleration and deceleration are better that static speed? If so that should be pretty easy to add 👍

Yeah, they seem better to me.


Wrong mutation request

When I send a POST to /query with
{
	"mutation": "{ addCampaign(title: \"blub\"){id} }"
}

I get a 200 OK with
{
	"errors": [
		{
			"message": "no operations in query document"
		}
	]
}

What is wrong here?

To make a GraphQL request via http is a bit strange (at least for me). You have to send a json-object like
  "query": "{mutation: { addCampaign(title: \"blub\"){id} }",

(have not tested this example)
See https://graphql.org/learn/serving-over-http/#post-request
I find this very annoying. There for I recommend using a graphQL client. See https://github.com/normanjaeckel/Meier/blob/main/server/README.md#server
After installing it, call gq http://localhost:8080/query -i. It will open a nice web-application in your browser that makes sending request easy

Looks good now


Fix KaaS teams

Address root cause of https://github.com/giantswarm/giantswarm/issues/20460
This PR:

Send SE alerts to correct KaaS teams.
Use a template definition for KaaS team templating.

Checklist

[x] Update changelog in CHANGELOG.md.
[x] Request review from oncall area, as well as team (e.g: oncall-kaas-cloud GitHub group).
[x] Alerting rules must have a comment documenting why it needs to exist.

Not sure if anyone care to look, but here is the diff between provider being set to "aws" and then "kvm": diff.txt


Use default arguments for NullStatus initialization

this prevents an ArgumentError when NullStatus#new is called in lib/rspec/sidekiq/batch.rb:71

Coverage remained the same at 97.093% when pulling 454b6d510fe06c8470b962f666497da181ed5be8 on briansharon:use-default-args-for-NullStatus-init into 3ef52ce9ae7b3b5214a9b479318ad3c244ab7c65 on philostler:develop.

Coverage remained the same at 97.093% when pulling d9cb6a57305ca7b346113751c9fa7ce9a49b2911 on briansharon:use-default-args-for-NullStatus-init into 3ef52ce9ae7b3b5214a9b479318ad3c244ab7c65 on philostler:develop.

Coverage remained the same at 97.093% when pulling d9cb6a57305ca7b346113751c9fa7ce9a49b2911 on briansharon:use-default-args-for-NullStatus-init into 3ef52ce9ae7b3b5214a9b479318ad3c244ab7c65 on philostler:develop.

Coverage remained the same at 97.093% when pulling d9cb6a57305ca7b346113751c9fa7ce9a49b2911 on briansharon:use-default-args-for-NullStatus-init into 3ef52ce9ae7b3b5214a9b479318ad3c244ab7c65 on philostler:develop.


Call paddle.incubate.nn.functional.fused_gate_attention and set use_flash_attn to true.

rt

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


add attributes to mj-carousel for positioning

Is your feature request related to a problem? Please describe.
In the carousel, I wish I could position (1) the left and right icons from the sides of the top picture, (2) the three thumbnails from the bottom of the top picture, and (3) the horizontal spacing of the three thumbnails.
Describe the solution you'd like
(1) A solution equivalent to providing a parameter to replace "20px" in this:
<mj-style inline="inline" > {
	.mj-carousel-previous {
	  	  padding-right:20px !important;
	}
	.mj-carousel-next {
	  	  padding-left:20px !important;
	}
}

The first moves the left icon 20px to the left of its default position left of the top photo. The second similarly moves the right icon 20px to the right.
(2) A solution equivalent to providing a parameter to replace "20px" in this:
<mj-style inline="inline" > {
	  .mj-carousel-main {
	  	  padding-bottom: 20px !important;
	  }
}

This one moves the row of three thumbnails 20px lower from the top picture than their default position.
(3) A solution to widen the spacing between the three thumbnails below the top picture.
Describe alternatives you've considered
(1) I foresee wanting to displace the icons about 10px to 50px from the top picture. I don't foresee wanting to displace one side by a different amount than the other, so a single parameter would satisfy my request. The team might consider whether some designers/developers would want both left and right offset parameters.
(2) I foresee wanting to use offsets of about 10px to 50px.
(3) I foresee wanting to use offsets of about 10px to 50px. The team might consider whether some designers/developers would want settings for (a) splitting available white space into four equal-sized gaps,

and (b) splitting available white space into two equal-sized gaps.

I intend both pictures to show relative position. I didn't intend either to be in scale.

Not every element in carousel have wrapping table to support properly padding/margin everywhere.
If you find a workaround with css-class/mj-style you should better use it instead.

Good response. And, might we add more information?
I'm unfamiliar with the particulars of "wrapping table". Perhaps .mj-carousel-previous, .mj-carousel-next, and .mj-carousel-main are examples?
I'll respond in the context of all three suggestions above.
As to (1) and (2): These wrapping tables exist and are useful. Are they documented for use by our authors, other than in source code?
If they're not documented, they are available to only the small percentage of authors who are also capable of reading the source code and understanding the significance of these classes (a fairly demanding process for mere mortals; iRyusa: you're not a mere mortal in this respect!) And only to the portion of those motivated to read the source code.
In lieu of documenting the wrapping tables themselves, my suggestion is to put attributes in the language to abstract to tables from our authors. With the attributes, those tables become available for our general authors. MJML becomes more useful. Well, that's my theory.
A valuable alternative is documenting the wrapping tables and providing demo code, also making the tables more available.
As to (3): Perhaps your comment most directly applies here; perhaps there is no wrapping table for this aspect of the accordion. My suggestion is to add it. Perhaps your response is a terse way of saying that's not possible or advisable.
I consider it valuable to document more here before considering this closed.

We don't really want to document the HTML produced by MJML as it would clearly goes against abstracting component. All image lives in label and not table element, so padding can't work for clients like outlook here.

If they're not documented, they are available to only the small percentage of authors who are also capable of reading the source code and understanding the significance of these classes

Well I don't agree with this if you use such a tool, you need to have basic knowledge of CSS, and HTML to at least know what is produced. Everyone can just inspect the DOM with any browser built-in developer tools now.
mj-carousel use case is really limited and it's a "hack" of css usage because we can't have any JS involved in email, so we don't want to push too much attribute on it.


[e2e]: go schedule main noldflags-multi-uses slsa3

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7705304163
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Jan 30 02:12:48 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7705304163
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Tue Jan 30 02:12:58 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7720225817
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Jan 31 02:15:24 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7720225817
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Wed Jan 31 02:15:40 UTC 2024

Repo: https://github.com/slsa-framework/example-package/tree/main
Run: https://github.com/slsa-framework/example-package/actions/runs/7735263502
Workflow file: https://github.com/slsa-framework/example-package/tree/main/.github/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Workflow runs: https://github.com/slsa-framework/example-package/actions/workflows/e2e.go.schedule.main.noldflags-multi-uses.slsa3.yml
Trigger: schedule
Branch: main
Date: Thu Feb  1 02:18:17 UTC 2024
Tests are passing now. Closing this issue.


Crash Report: update failed for AnAction with ID=texify.sumatra.ForwardSearch

Description
Stacktrace
Please paste the full stacktrace from the IDEA error popup

Fixed in PR #443 for b0.6.


How can I change the authority of user account in contract?

I'm trying to change the authority of user account in my contract. I found that there is an updateauth function in contract/eosio.system/native.hpp, but the definition of the function is empty. Is this function not finished yet? Is there any other method to change the authority?

updateauth function is a native eosio function and its implementation could be found inside libraries/chain/eosio_contract.cpp. Anything that is written inside native.hpp is the extra handler after the handler inside eosio_contract.cpp is executed. You can find the corresponding abi structure for updateauth and other native eosio function inside libraries/chain_eosio_contract_abi.cpp.
If you are using cleos, you can just use cleos set account permission ... instead since it will help you to wrap the updateauth function nicely so you don't need to construct it by yourself. Otherwise you can still use cleos push action eosio updateauth ... if you want  to construct it by yourself.


Multiple Sanic Workers Bugfix

Proposed changes:
Check for user using 'in_memory' lock store when setting multiple Sanic workers. This change will not block users who are using a custom lock store
Status (please check what you already did):

[ ] added some tests for the functionality
[x] updated the documentation
[x] updated the changelog (please check changelog for instructions)
[x] reformat files using black (please check Readme for instructions)

Thanks for submitting a pull request 🚀 @b-quachtran will take a look at it as soon as possible ✨

Hi @b-quachtran! Is there anything that I need to get this PR merged?

Updated from the review comments @b-quachtran. Let me know if this is what you had in mind, thanks!

@b-quachtran Any updates on this? Really need this change in

Hi @ricwo, thank you so much for the comments! My apologies for not updating the tests. Please let me know if I need to update anything else

@joeriess the debug message in line 502 of rasa/core/utils.py needs to be updated as well. also, it seems that the code quality checks are not passing due to https://github.com/RasaHQ/rasa/pull/6676/checks?check_run_id=1242304298#step:11:139
An isinstance(lock_store, EndpointConfig) check before calling lock_store.type would fix this

@ricwo code quality issue and comment both addressed

+1 to this issue and fix! We're hitting this too!

Hi @ricwo! Do you know when this will be apart of a release? Thanks!

cc @wochinge would you mind taking this over?

@joeriess This will be part of the Rasa Open Source 2.1 release on November 17th.

@wochinge This is a big blocker for our team and we are currently in Production -- is there anyway you can release this change as a patch release sooner so we can update our code sooner? It would really help us out! :)

Two options:

You backport this to 2.0.x (tag me there, I'd do the release then)
I assume you're using docker images right? In that case you can simply clone master and run docker build and push that to your registry.

@wochinge Not sure what you mean by option 1. In response to option 2, we are using poetry and pulling the public rasa python module v2.0.0.

@tatianafrank I am backporting it in https://github.com/RasaHQ/rasa/pull/7223 and will cut a patch release for Rasa Open Source 2.0 later today. Sounds good?

Yes thank you! please leave a comment when its ready :) @wochinge

Will do . I need an approval of my team and then another CI run, then it should be there 👍

@tatianafrank Release should be there in about half an hour / hour

thank you!! @wochinge


bp: Rename MetaData to Metadata

Summary of the changes / Why this improves CrateDB
Rename remaining MetaData to Metadata and META_DATA to METADATA.
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

retest this please


Fix label depedencies of d rules.

Bazel @HEAD do not include the d package anymore so use
the repository relative label instead.
This fix the breakage on ci.bazel.io

@googlebot ping

LGTM


Calibration loading

The .. to virtualreality. is because pycharm runs everything from the root directory, and I can't run some of the command line files directly without that.
the base to examples.base is a bit more iffy.

looks good


Make the plugin be compatible with SonarQube 5.2

Caused by: java.lang.NoSuchMethodError: org.sonar.api.component.ResourcePerspectives.as(Ljava/lang/Class;Lorg/sonar/api/component/Component;)Lorg/sonar/api/component/Perspective;
at com.iadams.sonarqube.puppet.checks.ProjectChecks.addIssue(ProjectChecks.java:146)
at com.iadams.sonarqube.puppet.checks.ProjectChecks.checkTestsDirectoryPresent(ProjectChecks.java:130)
at com.iadams.sonarqube.puppet.checks.ProjectChecks.checkTestsDirectoryPresent(ProjectChecks.java:135)
at com.iadams.sonarqube.puppet.checks.ProjectChecks.checkTestsDirectoryPresent(ProjectChecks.java:135)
at com.iadams.sonarqube.puppet.checks.ProjectChecks.reportProjectIssues(ProjectChecks.java:64)
at com.iadams.sonarqube.puppet.PuppetSquidSensor.save(PuppetSquidSensor.java:125)
at com.iadams.sonarqube.puppet.PuppetSquidSensor.analyse(PuppetSquidSensor.java:106)
at org.sonar.batch.phases.SensorsExecutor.executeSensor(SensorsExecutor.java:58)
at org.sonar.batch.phases.SensorsExecutor.execute(SensorsExecutor.java:50)
at org.sonar.batch.phases.PhaseExecutor.execute(PhaseExecutor.java:98)
at org.sonar.batch.scan.ModuleScanContainer.doAfterStart(ModuleScanContainer.java:192)
at org.sonar.core.platform.ComponentContainer.startComponents(ComponentContainer.java:100)
at org.sonar.core.platform.ComponentContainer.execute(ComponentContainer.java:85)
at org.sonar.batch.scan.ProjectScanContainer.scan(ProjectScanContainer.java:258)
at org.sonar.batch.scan.ProjectScanContainer.scanRecursively(ProjectScanContainer.java:253)
at org.sonar.batch.scan.ProjectScanContainer.doAfterStart(ProjectScanContainer.java:243)
at org.sonar.core.platform.ComponentContainer.startComponents(ComponentContainer.java:100)
at org.sonar.core.platform.ComponentContainer.execute(ComponentContainer.java:85)
at org.sonar.batch.bootstrap.GlobalContainer.executeAnalysis(GlobalContainer.java:153)
at org.sonar.batch.bootstrapper.Batch.executeTask(Batch.java:110)
at org.sonar.batch.bootstrapper.Batch.execute(Batch.java:76)
at org.sonar.runner.batch.IsolatedLauncher.execute(IsolatedLauncher.java:48)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at org.sonar.runner.impl.BatchLauncher$1.delegateExecution(BatchLauncher.java:87)
... 9 more

Fixed in https://github.com/iwarapter/sonar-puppet/commit/3a6412475a65ff0d91b0738576f1e633956e3cd7

I have merged, this i'll extend the functional tests to cover the various versions.

i'll extend the functional tests to cover the various versions

Good idea!

After further testing, need todo more to support 5.2

OK. Any detail about the other issues?

The decorator we were using for the puppet_resource metric needs to be re-implemented with a Measure Computer. I have also been cleaning out some old code thats no longer used.

The decorator we were using for the puppet_resource metric needs to be re-implemented with a Measure Computer.

Yep but only when we want to make the plugin be compatible with version 5.2+. I believe that'll be when version 5.x becomes the LTS. What do you think?

I have also been cleaning out some old code thats no longer used.

OK

This has now been resolved.


[2.0] Groups disappears

If i try to remove and add Groups via
Remove:
SubjectData data = _permission.getUserSubjects().get(_player.getIdentifier()).getSubjectData();         data.removeParent(SubjectData.GLOBAL_CONTEXT, _permission.getGroupSubjects().get(group));
Add:
SubjectData data = _permission.getUserSubjects().get(_player.getIdentifier()).getSubjectData();         data.addParent(SubjectData.GLOBAL_CONTEXT, _permission.getGroupSubjects().get(group));
_permission is an Sponge provided PermissionService
somtimes the new group disappears from users cached Subject.
The parent entry for the group still exists inside permissions.json and returns back after /pex reload.
PermissionsEx: 2.0-SNAPSHOT Build 123
SpongeAPI: 4.1.0-SNAPSHOT-3e39b9c
MinecraftForge: <IP_ADDRESS>8

Unfortunately PermissionsEx is currently unmaintained and no further updates are planned. Because of this, all pull requests are being closed. If you are looking for an actively maintained permissions plugin, take a look at LuckPerms. It is compatible with major server platforms and can import data from PEX.


Add missing setLogLevelForType TypeScript definition

Hi! setLogLevelForType () was forgotten in 390b561 that updated the TS definitions, adding it with this PR.

:tada: This PR is included in version 7.2.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Parsing the output to PortSniffer

launched
*]0;c:\Users\fruit\OneDrive\Desktop\SoundUnited\SoundUnitedEngineersTestTool\PortSniffer-Tool.exe**********************************************************************

ENLYZE PortSniffer Tool 2.1 (acc298dbb4a387e03b3404c1812f60e245738d2b)

Co
Copyright 2020-2022 Colin Finck, ENLYZE GmbH<EMAIL_ADDRESS>

**********************************************************************

UTC TIMESTAMP           | T |  LEN | DATA

2

2022-11-16 18:22:58.297 | W |  678 | AA 00 00 05 00 00 00 A9 80 28 AA 00 00 05 0

0 00 00 39 B8 60 AA 00 00 05 00 00 00 61 80 70 AA 00 00 05 00 00 00 62 80 6F AA

00 00 05 00 00 00 FB F
00 00 05 00 00 00 FB F8 5E AA 00 00 05 00 00 00 04 F8 55 AA 00 00 05 00 00 00 63

 80 6E AA 00 00 05 00 00 00 70 80 61 AA 00 00 05 00 00 00 64 80 6D AA 00 00 05 0

0 00 00 65 80 6C AA 00 00 05 00 00 00 66 80 6B
0 00 00 65 80 6C AA 00 00 05 00 00 00 66 80 6B AA 00 00 05 00 00 00 6F 80 62 AA

00 00 05 00 00 00 7C 80 55 AA 00 00 05 00 00 00 8C 80 45 AA 00 00 06 00 00 00 A0

 80 00 30 AA 00 00 05 00 00 00 67 80 6A AA 00 00 05 00 00 00 68 80 69 AA 00 00 0

5 00 0
5 00 00 00 73 80 5E AA 00 00 05 00 00 00 6D 80 64 AA 00 00 05 00 00 00 6B 80 66

AA 00 00 05 00 00 00 69 80 68 AA 00 00 06 00 00 00 A4 80 00 2C AA 00 00 06 00 00

 00 A4 80 01 2B AA 00 00 06 00 00 00 A4 80 02
 00 A4 80 01 2B AA 00 00 06 00 00 00 A4 80 02 2A AA 00 00 06 00 00 00 A4 80 03 2

9 AA 00 00 06 00 00 00 A4 80 04 28 AA 00 00 06 00 00 00 A4 80 05
 27 AA 00 00 06

00 00 00 A4 80 06 26 AA 00 00 06 00 00 00 A4 80 07 25 AA 00 00 06 00 00 00 A4 80

 08 24 AA 00 00 06 00 00 00 A4 80 09 23 AA
 08 24 AA 00 00 06 00 00 00 A4 80 09 23 AA 00 00 06 00 00 00 A4 80 0A 22 AA 00 0

0 06 00 00 00 A4 80 0B 21 AA 00 00 06 00 00 00 A4 80 1E 0E AA 00 00 06 00 00 00

A4 80 1F 0D AA 00 00 06 00 00 00 A4 80 20 0C AA 00 00 06 00 00 00 A4 80 21 0B AA

 00 00 06 00 00 00 A4 80 2
 00 00 06 00 00 00 A4 80 22 0A AA 00 00 06 00 00 00 A4 80 23 09 AA 00 00 06 00 0

0 00 A5 80 00 2B AA 00 00 06 00 00 00 A5 80 01 2A AA 00 00 06 00 00 00 A5 80 02

29 AA 00 00 06 00 00 00 A5 80 03 28 AA 00 00 06 00 00 00 A5 80 04 27 AA 00 00 06

 00 00 00 A5 80 05 26 AA 00
 00 06 00 00 00 A5 80 06 25 AA 00 00 06 00 00 00 A5 8

0 07 24 AA 00 00 06 00 00 00 A6 80 00 2A AA 00 00 05 00 00 00 77 80 5A AA 00 00

05 00 00 00 47 80 8A AA 00 00 05 00 00 00 87 80 4A AA 00 00 05 00 00 00 AF 80 22

 AA 00 00 05 00 00 00 B1 80 20 AA 00 00 05 00 00 00 B2 80 1F AA 00 00 05 00 00 0

0 B3 80 1E AA 00 00 05 00 00 00 79 80 58 AA 00 00 05 00 00 00 F7 F8 62 AA 00 00

05 00 00 00 F2 F8 67 AA 00 00 05 00 00 00 83 80 4E AA 00 00 05 00 00 00 89 80 48

 AA 00 00 05 0000 00 58 F8 01 AA 00 00 05 00 00 00 03 F8 56 AA 00 00 05 00 00 0

0 01 FE 52 AA 00 00 05 00 00 00 C0 80 11 AA 00 00 05 00 00 00 C1 80 10

2022-11-16 18:22:58.313 | R |   26 | AB 00 00 07 00 00 00 A9 80 00 01 24 AB 00 0

0 06 00 00 00 39 B8 00 5E AB 00 00

2022-11-16 18:22:58.331 | R |   32 | 06 00 00 00 61 80 24 4A AB 00 00 07 00 00 0

0 62 80 1E 00 4E AB 00 00 07 00 00 00 FB F8 FF 19 43

2022-11-16 18:22:58.346 | R |   49 | AB 00 00 21 00 00 00 04 F8 00 00 01 00 02 0

0 03 00 0E 00 10 00 13 00 14 00 15 00 16 00 17 00 18 00
1F 00 23 00 51 AB 00 00

06 00 00 00 63 80 00 6C

2022-11-16 18:22:58.362 | R |   22 | AB 00 00 06 00 00 00 70 80 00 5F AB 00 00 0

600 00 00 64 80 00 6B

2022-11-16 18:22:58.378 | R |   30 | AB 00 00 06 00 00 00 65 80 00 6A AB 00 00 0

6 00 00 00 66 80 01 68 AB 00 00 06 00 00 00 6F

2022-11-16 18:22:58.393 | R |   53 | 80 00 60 AB 00 00 14 00 00 00 7C 80 EB EB E

B EB EB EB 10 10 10 10 10 10 19 00 00 4A AB 00 00 14 00 00 00 8C 80 FF 00 FF 00

FF 00 00 00 00 00 00 00 19 00 00 1F

2022-11-16 18:22:58.409 | R |   41 | AB 00 00 19 00 00 00 A0 80 00 8C 0A 00 D0 0

2 8A 00 10 00 3E 00 E0 01 2D 00 09
00 06 00 BF AB 00 00 06 00 00 00 67 80 02 66

2022-11-16 18:22:58.409 | W |   11 | AA 00 00 06 00 00 00 A0 80 01 2F

2022-11-16 18:22:58.424 | R |   22 | AB 00 00 06 00 00 00 68 80 00 67 AB 00 00 0

6 00 00 00 73 80 09 53

2022-11-16 18:22:58.440 | R |   31 | AB 00 00 06 00 00 00 6D 80 09 59 AB 00 00 0

6 00 00 00 6B 80 00 64 AB 00 00 07 00 00 00 69 80

2022-11-16 18:22:58.456 | R |   49 | 01 00 64 AB 00 00 29 00 00 00 A4 80 00 FF F

F FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

00 00 00 00 00 00 00 0B

2022-11-16 18:22:58.503 | R |  184 | AB 00 00 29 00 00 00 A4 80 01 FF FF FF 00 0

0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

00 00 00 00 0A AB00 00 29 00 00 00 A4 80 02 FF FF FF 00 00 00 00 00 00 00 00 00

 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 09 AB 00 0

0 29 00 00 00 A4 80 03 FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

0000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 08 AB
00 00 29 00 00 00 A4 80 04

 FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0

0 00 00 00 00 00 00 00 00 07

2022-11-16 18:22:58.518 | R |   54 | AB 00 00 29 00 00 00 A4 80 05 FF FF FF 00 0

0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

00 00 00 00 06 AB 00 00 29 00 00 00 A4

2022-11-16 18:22:58.549 | R |  176 | 80 06 FF FF FF 00 00 00 00 00 00 00 0      0 00 0

0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 05 AB 00 00

29 00 00 00 A4 80 07 FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 04 AB 00 00 29 00 00 00 A4 80 08 F

F FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

0
0 00 00 00 00 00 00 00 03 AB 00 00 29 00 00 00 A4 80 09 FF FF FF 00 00 00 00 00

 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0

0 02

2022-11-16 18:22:58.596 | R |  184 | AB 00 00 29 00 00 00 A4 80 0A FF FF FF 00 0

0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

00 00 00 00 01 AB 00 00 29 00 00 00 A4 80 0B FF FF FF 00 00 00 00 00 00 00 00 00

 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 AB 00 0

0 29 00 00 00 A4 80 1E FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ED AB 00 00 29 00 00 00 A4 80 1F

 FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0

0 00 00 00 00 00 00 00 00 EC

2022-11-16 18:22:58.612 | R |   52 | AB 00 00 29 00 00 00 A4 80 20 FF FF FF 00 0

0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

00 00 00 00 EB AB 00 00 29 00 00

2022-11-16 18:22:58.659 | R |  132 | 00 A4
 80 21 FF FF FF 00 00 00 00 00 00 00 0

0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 EA AB

00 00 29 00 00 00 A4 80 22 FF FF FF 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 E9 AB 00 00 29 00 00 00 A4 8

0 23 FF FF FF 00 00 00 00 00 00 0000 00 00 00 00 00 00 00 00 00 00 00 00 00 00

00 00 00 00 00 00 00 00 00 00 E8

2022-11-16 18:22:58.690 | R |   35 | AB 00 00 38 00 00 00 A5 80 06 01 01 01 22 1

2 EF 00 01 56 69 64 65 6F 43 6C 69 70 31 87 01 1A A4 02 00 C2

2022-1
1-16 18:22:58.706 | R |   26 | 33 C4 86 4C 1D B8 0B D0 84 80 3E 13 3D 42 4

0 10 27 01 00 10 27 FA 00 00 01 1A

2022-11-16 18:22:58.721 | R |   22 | AB 00 00 06 00 00 00 77 80 07 51 AB 00 00 0

6 00 00 00 47 80 FF 89

2022-11-16 18:22:58.737 | R |   26 | AB 00 00 06 00 00 00 87 80 00 48 AB 00 00 0

6 00 00 00 AF 80 00 20 AB 00 00 06

2022-11-16 18:22:58.753 | R |   29 | 00 00 00 B1 80 01 1D AB 00 00 06 00 00 00 B

2 80 01 1C AB 00 00 06 00 00 00 B3 80 01 1B

2022-11-16 18:22:58.768 | R |   27 | AB 00 00 07 00 00 00 79 80 00 00 55 AB 00 0

0 06 00 00 00 F7 F8 00 60 AB00 00 09

2022-11-16 18:22:58.784 | R |   32 | 00 00 00 F2 F8 C0 A8 01 EF 0A AB 00 00 06 0

0 00 00 83 80 00 4C AB 00 00 06 00 00 00 89 80 00 46

2022-11-16 18:22:58.784 | W |   10 | AA 00 00 05 00 00 00 F3 F8 66

2022-11-16 18:22:58.793 | R |   25 | AB 00 00 09 00 00 00 58 F8 01 00 5C 11 8E A

B 00 00 06 00 00 00 03 F8 02 52

2022-11-16 18:22:58.809 | R |   36 | AB 00 00 13 00 00 00 01 FE 84 01 0A 53 11 0

D 00 00 00 00 00 00 00 00 43 AB 00 00 07 00 00 00 C0 80 00 00 0E

2022-11-16 18:22:58.824 | R |   42 | AB 00 00 07 00 00 00 C1 80 00 00 0D AB 00 0

0 19 00 00 00 A0 80 018C 0A 00 D0 02 8A 00 10 00 3E 00 E0 01 2D 00 09 00 06 00

BE

2022-11-16 18:22:58.824 | W |   11 | AA 00 00 06 00 00 00 A0 80 02 2E

2022-11-16 18:22:58.840 | R |   44 | AB 00 00 09 00 00 00 F3 F8 C0 A8 01 01 F7 A

B 00 00 19 00 00 00 A0 80 02 8C 0A 00 D0 02 8A 00 10 00 3E 00 E0 01 2D 00 09 00

06 00 BD

2022-11-16 18:22:58.840 | W |   21 | AA 00 00 05 00 00 00 F4 F8 65 AA 00 00 06 0

0 00 00 A0 80 03 2D

2022-11-16 18:22:58.854 | R |   41| AB 00 00 09 00 00 00 F4 F8 FF FF FF 00 63 A

B 00 00 19 00 00 00 A0 80 03 8C 0A 00 D0 02 8A 00 10 00 3E 00 E0 01 2D 00 09 00

2022-11-16 18:22:58.854 | W |   10 | AA 00 00 05 00 00 00 F6 F8 63

2022-11-16 18:22:58.870 | R |   19 | 06 00 BC AB 00 00 0B 00 00 00 F6 F8 18 8A 6

A 00 53 10 ED

2022-11-16 18:22:
58.870 | W |   21 | AA 00 00 06 00 00 00 A0 80 04 2C AA 00 00 0

5 00 00 00 F5 F8 64

2022-11-16 18:22:58.891 | R |   30 | AB 00 00 19 00 00 00 A0 80 04 8C 0A 00 D0 0

2 8A 00 10 00 3E 00 E0 01 2D 00 09 00 06 00 BB

2022-11-16 18:22:58.891 | W |11 | AA 00 00 06 00 00 00 A0 80 05 2B

2022-11-16 18:22:58.907 | R |   42 | AB 00 00 07 00 00 00 F5 F8 17 00 4A AB 00 0

0 19 00 00 00 A0 80 05 8C 0A 00 D0 02 8A 00 10 00 3E 00 E0 01 2D 00 09 00 06 00

BA

2022-11-16 18:22:58.907 | W |   11 | AA 00 00 06 00 00 00 A0 80 06 2A

2022-11-16 18:22:58.922 | R |   30 | AB 00 00 19 00 00 00 A0 80 06 8C 0A 00 D0 0

2 8A 00 10 00 3E 00 E0 01 2D 00 09 00 06 00 B9

2022-11-16 18:22:58.922 | W |   11 | AA 00 00 06 00 00 00 A0 80 07 29

2022-11-16 18:22:58.938 | R |   30 | AB 00 00 19 00 00 00 A0 80 07 8C 0A 00 D0 0

2 8A 00 10 00 3E 00 E0 01 2D 00 09 00 06 00 B8

2022-11-16 18:22:58.938 | W |   11 | AA 00 00 06 00 00 00 A0 80 08 28

2022-11-16 18:22:58.954 | R |   30 | AB 00 00 19 00 00 00 A0 80 08 8C 0A        00 D0 0

2 8A 00 10 00 3E 00 E0 01 2D 00 09 00 06 00 B7

2022-11-16 18:22:58.954 | W |   11 | AA 00 00 06 00 00 00 A0 80 09 27

2022-11-16 18:22:58.969 | R |   30 | AB 00 00 19 00 00 00 A0 80 09 8C 0A 00 D0 0

2 8A 00 10 00 3E 00 E0 01 2D 00 09 00 06 00 B6

This is me just using pywinpty's PtyProcess.spawn() on the PortSniffer-Tool.exe in order to monitor, and printing everything I get back with PtyProcess.read().  It's the only way that I can seem to read the output of it (latest version of PortSniffer is being used).   As you can see I'm getting stuff like:
00 00 05 00 00 00 FB F
00 00 05 00 00 00 FB F8 5E AA 00 00 05 00 00 00 04 F8 55 AA 00 00 05 00 00 00 63

where the square represents an ASCII "ESC" character in my IDE's console IDE pane.   Now I'm assuming that that means the line is not yet fully rendered, and so the next line is what I want (my current thinking).  As you can see however, in general this is really really hard to parse, and it's causing major errors in my user's experience - they're not seeing the right commands that were sent or received.  Any chance we could get something that works with regular Python subprocess.Popen and that is parseable?

Currently, I've found the only way to do this is to redirect stdout to file:
from subprocess import Popen, PIPE, CREATE_NEW_CONSOLE

#process = Popen(['./PortSniffer-Tool.exe', '/install'], stdout=PIPE, stderr=PIPE)

#stdout, stderr = process.communicate()

#print("(DEBUG) INSTALL OUT:", stdout.decode())
#print("(DEBUG) INSTALL ERR:", stderr.decode())

#process.kill()

process = Popen(['./PortSniffer-Tool.exe', '/attach', 'COM3'], stdout=PIPE, stderr=PIPE)

stdout,stderr = process.communicate()

print("(DEBUG) ATTACH OUT:\n", stdout.decode())
print("(DEBUG) ATTACH ERR:\n", stderr.decode())

process.kill()

with open("PortSniffer-Output.txt", "wb") as out, open("PortSniffer-Err.txt", "wb") as err:
   process = Popen(['./PortSniffer-Tool.exe', '/monitor', 'COM3', 'RW'], stdout=out, stderr=err)

while True:
   i = input(">")

   if i == "q":
      process.kill()
      break
   #stdout, stderr = process.communicate()
   #if stdout:
      #print("(DEBUG) MONITOR OUT:\n", stdout.decode())
   #if stderr:
      #print("(DEBUG) MONITOR ERR:\n", stderr.decode())