Issue with forward keymap (alt-_) when used along atom-keyboard-localization

I also created issue 129 in atom-keyboard-localization because I suppose they are the ones how should fix this (as it's probably affecting other extensions too). But I think having an issue in here might help others with a similar problems as I found a workaround.
Workaround (until atom-keyboard-localization is fixed?):

Go to Atom Seetings > Packages > last-cursor-position and disable the Keybindings

Go to Atom Seetings > Keybindings click the your keymap file link (this will open your keymap.cson file) and add this at the bottom of that file:

'atom-workspace':
  'alt--': 'last-cursor-position:previous'
  'alt-shift-_': 'last-cursor-position:next'

Notice that I only added -shift to the original binding that has "_".

The atom-keyboard-localization package was deprecated. So this issue shouldn't happen anymore.


Split into submodules

The single-module architecture is starting to look a bit crowded. Some suggestions for (future) modules: bdd, model, attractors, fixed_points, trap_spaces, control, ...

Currently, this is postponed. The reason is that it is very hard to make native submodules work with Python documentation engines correctly.
Plan for v2.0 would be:

Include Python bindings directly into native libraries (data transfer between native libraries would have to be through copying).
Make AEON.py a pure Python library that calls into the native libraries.

Then, we could use all the normal documentation tools and type annotations without major compatibility problems..


Add overview diagrams for "Requesting Certificates" section

Quick overview diagrams on each of the "Requesting Certificates" pages.
eg. on https://deploy-preview-1329--cert-manager-website.netlify.app/docs/usage/certificate/

Nice. The unrelated boxes (CSI driver etc) are now greyed out. It is much less confusing. The diagram now clearly shows a Certificate in the center: that's great because this page is about the Certificate resource.
As a first-time reader of this page, I would probably still skip the diagram entirely because this diagram because it looks confusing:

The top of the page talks about the Certificate and Issuer resources, but the Issuer resource doesn't show on the diagram; that's surprising.
Do I need to create an "Annotated Ingress" to create a Certificate? That's what the diagram alludes to.
Although I know what is an Ingress, what is an "Annotated Ingress"?
Since I didn't know what was an Annotated Ingress, I did ctrl+F but didn't find any reference to "Annotated Ingress".
I know about Istio's Gateway resource, but what is an "Annotated Gateway"?

One way of making it much clearer would be to write a legend to this diagram to explain what the reader should understand from the diagram

Nice. The unrelated boxes (CSI driver etc) are now greyed out. It is much less confusing. The diagram now clearly shows a Certificate in the center: that's great because this page is about the Certificate resource.
As a first-time reader of this page, I would probably still skip the diagram entirely because this diagram because it looks confusing:

The top of the page talks about the Certificate and Issuer resources, but the Issuer resource doesn't show on the diagram; that's surprising.
Do I need to create an "Annotated Ingress" to create a Certificate? That's what the diagram alludes to.
Although I know what is an Ingress, what is an "Annotated Ingress"?
Since I didn't know what was an Annotated Ingress, I did ctrl+F but didn't find any reference to "Annotated Ingress".
I know about Istio's Gateway resource, but what is an "Annotated Gateway"?

One way of making it much clearer would be to write a legend to this diagram to explain what the reader should understand from the diagram

The diagram does not really apply to issuers, each resource references the issuer resource (annotated Ingresses, Certificates, CertificateRequests, ...). So I did not include that to not overwhelm the diagram.
There are multiple ways to create a Certificate resource, I updated the diagram with a set of letters (indicating the different paths/ options) and a legend that explains what the different arrows mean.
3&4&5. On the Ingress and Gateway page, we talk about adding annotations to your ingress resource, so I think this should be clear to the user?

This is an improvement over the existing page, so let's go with that!
My concerns are:

The grey stuff isn't needed to understand each page. It makes things confusing.
The "a", "b", "c" on the arrows should say the actual action (e.g., "creates").
It's not clear which resources are created by cert-manager, "automated action" doesn't really say that; using a line separation between "created by the user" and "created by cert-manager" would help.
The "Secret" should show on the diagram too since the point is to explain what Kubernetes resources are at play. I would even show the Issuer, but that's less important.

/lgtm
/approve


Please clarify effect of enabling storage account firewall when connecting via Private Endpoint

When a storage account has been enabled with a Private Endpoint, and clients connect to that storage account only via that Private Endpoint:

Does enabling the storage account firewall have any impact on inbound connections via the Private Endpoint?
To disable public access, but allow access via the Private Endpoint only, what steps need to be taken?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 2632af75-7664-b79b-ac5b-c7c17e6a609a
Version Independent ID: 6ecf71b6-77c4-3ab6-8ec9-353ea407d70f
Content: Configure Azure Storage firewalls and virtual networks
Content Source: articles/storage/common/storage-network-security.md
Service: storage
Sub-service: common
GitHub Login: @normesta
Microsoft Alias: normesta

@kahawai-sre Thanks for your question! This is noted in the document:
"Storage firewall rules apply to the public endpoint of a storage account. You don't need any firewall access rules to allow traffic for private endpoints of a storage account. The process of approving the creation of a private endpoint grants implicit access to traffic from the subnet that hosts the private endpoint."
There is a separate document about enabling private endpoint which is linked at the bottom.
https://docs.microsoft.com/en-us/azure/storage/common/storage-private-endpoints

Thanks @DerekHerman-MSFT
SO for this "The process of approving the creation of a private endpoint grants implicit access to traffic from the subnet that hosts the private endpoint", given it explicitly states "from the subnet that hosts the private endpoint", does that also include traffic originating from another subnet or peered/remote vnet?


Map Tour fails to allow Image Upload when supportsSceneServices is false

When using Story Map Tour against a 10.5.0 (and 10.5.1) Portal which has a relational data store but not a tilecache datastore, the Portal's /self call reports "supportsSceneServices":false and "supportsHostedServices" : true.
The Map Tour template currently checks in two locations for the supportsSceneServices property, disabling image load if it is not found:
https://github.com/Esri/storymap-tour/blob/a9067802157ccd73dddd874f1208c08f230fee2d/MapTour/src/app/storymaps/core/Core.js#L282
https://github.com/Esri/storymap-tour/blob/c2721004f5b6c50f15869f7be7eaa8ba1120f45e/MapTour/src/app/storymaps/maptour/builder/InitPopupViewHome.js#L31
Which results in this error message being displayed:

This check needs to be updated to either check supportsHostedServices for newer Portals (I believe this was introduced sometime after 10.3.1) or add another conditional which allows supportsHostedServices or supportsSceneServices to be true.

This will be addressed in the next release of the application.


Handle async response from CC /state endpoint

Q
A

Bug fix?
yes

New feature?
no

API breaks?
no

Deprecations?
no

Related tickets
fixes #828

License
Apache 2.0

What's in this PR?
When the request on /state endpoint of CC takes longer than webserver.request.maxBlockTimeMs,
then CC will convert the request into an async task and will respond with the taskID instead
of the result.
The Koperator should handle this case by waiting for CC to complete the task.
Additional context
In order to reproduce the issue, it's sufficient to set webserver.request.maxBlockTimeMs to a small value (e.g.: webserver.request.maxBlockTimeMs=10)
Checklist

[ ] Implementation tested
[ ] Error handling code meets the guideline
[x] Logging code meets the guideline
[x] User guide and development docs updated (if needed)

To Do

[ ] Still need to decide how to write tests

I will reopen the pr as this seems to be out of sync


image size problem

hello, it is a wonderful project! But i am wondering that i must input a fixed image to the project? say 6363? How can i input a 600480 image to the project? thanks a lot !

OK！looking forward to it, especially the training code!

@yuke93 It looks very interesting. Before see this issue I think in the following simple idea:
1 - Generate many patches sharing (in some way) common pixels.
I thought in something like: If a patch cover a 63*63 pixel square from  (x_0,y_0) to (x_0+62,y_0+62), the next horizontal patch going from (x_0+31,y_0+31) to (x_0+31+62,y_0+31+62) ...  And something analogous for the y coordinate.
2 - Then reconstruct the image using some kind of interpolation. For example, weighting the patch contribution depending on the distance to the patch center.
In your experience, do you think that this could work? If it is plausible, how can I choose "the best" output image for the patch? I see in the output something like:
mano_in_11_13_13.png  mano_in_11_13.png  mano_in_11.png
8_in_5_11_13.png  8_in_5_11.png  8_in_5.png
but I am unsure about the naming convention.
Regards

Hi @hernan3009 ,
I have tried some similar interpolation approaches as you said but the results are sometimes not pleasant because there is not any constraint about the selected toolchains between adjacent patches. When the selected toolchains are different, the interpolated image might look strange, and the PSNR is not as good as the voting method as I described above.
The number after 'in' stands for the indices of sequentially selected tools. Please see the table below:

Index
Distortion Type
Distortion Level Interval

1
Gaussian blur
[0, 1.25]

2
Gaussian blur
[1.25, 2.5]

3
Gaussian blur
[2.5, 3.75]

4
Gaussian blur
[3.75, 5]

5
Gaussian noise
[0, 12.5]

6
Gaussian noise
[12.5, 25]

7
Gaussian noise
[25, 37.5]

8
Gaussian noise
[37.5, 50]

9
JPEG compression
[60, 100]

10
JPEG compression
[35, 60]

11
JPEG compression
[20, 35]

12
JPEG compression
[10, 20]

13
None
N/A

Hello, it is a exciting work, I want to know whether the test stage have the ability of arbitrary size input.
In the code, I don't see the related features. I am looking forward to your reply.

Hi @lvzhengyi0204,
I haven't added this feature yet. I will implement the heuristic method, as discussed above, to support arbitrary size input, by the end of this week.

Dear all,
Thanks for your advice and comments. Now we support arbitrary input size while inference. Put your images in data/test/mine/ and then run
python main.py --dataset mine

Thank you! Works here under Python3.

Thank you very much！ It helps a lot for my research work.

I am very glad that you like it :smiley:

I really liked this project. I recently faced an issue while using this project in Google Colab. absl.flags._exceptions.DuplicateFlagError: The flag 'log_dir' is defined twice. First from absl.logging, Second from /content/RL-Restore/main.py. Description from first occurrence: directory to write logfiles into
Could you please explain how to get rid of this issue. Thanks in advance :) @yuke93

I also have the same question, hope to get a reply! Thanks a lot!


Reworked sensor and RC acquisition

Previously, sensors and RC hardware would collect and store data at a rate that was independent of how often the core rosflight code checked for sensor data. This commit changes that, making the core rosflight code be dependent on the hardware's aquisition rate, syncronizing the two.
This is part of AeroVironment's development effort and is not my own work.

This will be easier to push in with the varmint firmware, since this breaks the f1 and f4 firmware.

This pull request breaks the F1 and F4 firmware builds, but these builds will be replaced immediately by the H7 varmint pull request.


Update lists.livemd

Based on the context, this example should be [1] -- [2] and then become [1] which shows the different calculation order there.
[1, 2] -- [1] -- [2]
first [1] -- [2]
[1]
then [1, 2] -- [1]
[2]

The example is explaining how you might intuitively think about the problem, then corrects it to show how the calculation is actually performed.
I think this could be simplified/improved, but I don't believe it's incorrect based on the context. It might be better to remove the example entirely if it's confusing 🤔

The example is explaining how you might intuitively think about the problem, then corrects it to show how the calculation is actually performed.
I think this could be simplified/improved, but I don't believe it's incorrect based on the context. It might be better to remove the example entirely if it's confusing 🤔

No, I understand the example, it is just a typo here. plz read the full snippet.
For example, what do you think the result of [1, 2] -- [1] -- [2] should be? Intuitively, you might think it would be an empty list []. Because
[1, 2] -- [1] -- [2]
Becomes [2] when you subtract [1]
[2] -- [2]
And then becomes [] when you subtract [2]
[1, 2] -- [1] -- [2]
However, this is not the case. It's actually [2]. Why? because list operations evaluate from right to left.
[1, 2] -- [1] -- [2]
attention the bold part. I correct the bold part.

Oh, I think I understand the logic here. Then I think the explanation here should be changed. Since readers will focus on [1, 2] -- [1] -- [2]. But the example [2] -- [2] is a totally different example. It is strange here.

I agree. Raising an issue.


How to allow multiple type of draggable item to be dropped?

I don't understand how we can set the drop area to allow multiple types of draggable items.
I've taken a look at the doc and I understand that it's defined here: https://github.com/gaearon/react-dnd/blob/master/examples/01 Dustbin/Multiple Targets/Dustbin.js
@DropTarget(props => props.accepts, dustbinTarget, (connect, monitor) => ({
  connectDropTarget: connect.dropTarget(),
  isOver: monitor.isOver(),
  canDrop: monitor.canDrop()
}))

But I don't understand what that does. I think that's mainly unfamiliar with ES6 yet. It looks like the property props.accepts contains all the accepted types. Then it returns an object.
Here is how I did it for another of my app:
collectDrop = (connect, monitor) ->
    return {
        connectDropTarget: connect.dropTarget()
        isOver: monitor.isOver()
        canDrop: monitor.canDrop()
    }

...

module.exports = DragSource(TYPE_PATTERN, patternDrag, collectDrag)(
    DropTarget('RESOURCE', patternDrop, collectDrop)(PatternEditor)
)

Could you explain to me using ES5 or similar? (Without the @)
Thanks :)

By writing the question, I actually understood my issue x)
It was so simple I hadn't thought of it. I just have to write:
module.exports = DragSource(TYPE_PATTERN, patternDrag, collectDrag)(
    DropTarget(['PATTERN', 'RESOURCE'], patternDrop, collectDrop)(PatternEditor)
)

It's basically an array of possible types.

@Vadorequest  are you using typescript. This work for me in jsx but not in typescript. If time permits can you look into https://github.com/react-dnd/react-dnd/issues/785#issuecomment-368897599
Thank you.

@abelkbil No, I'm not using typescript, and I'm not using react DnD nowadays anymore so I won't be much help, sorry.


Missing cachedInt32Memory0/cachedUint8Memory0 Definitions

In paritytech/capi, we utilize wasmbuild to create three separate wasm+binding pairs. Here is the scripts that triggers this generation. For two of the three builds, this works just fine. The third build's JS bindings (sr25519 utils)––however––lack initialization of cachedInt32Memory0/cachedUint8Memory0, which results in a runtime error. We currently get around this by manually appending the variable declarations to the JS bindings file (as seen here). This is of course not ideal.
I suppose this also raises questions regarding creating multiple builds. Will open another issue.

I ran into this the other day and this is fixed now.


Changing referenced version in example documentation

Have tested tag with example.

@Eascen can you address the comments so we could merge the PR?


#1184 fixes

fixes #1184

Jenkins job failed with following error:
[2019-04-07T12:36:27.196Z] [ERROR] Failed to execute goal on project strongbox-authentication-api: Could not resolve dependencies for project org.carlspring.strongbox:strongbox-authentication-api:jar:1.0-SNAPSHOT: Could not transfer artifact org.apache.logging.log4j:log4j-api:jar:2.11.1 from/to carlspring (http://repo.carlspring.org/content/groups/carlspring/): /cache/jenkins-strongbox-strongbox-PR-1186/.m2/repository/org/apache/logging/log4j/log4j-api/2.11.1/log4j-api-2.11.1.jar.part (No such file or directory) -> [Help 1]
I guess this is not due my code changes :)

@akhil10x5,
Thank you for your contribution!
Would you mind signing the ICLA, as described in the Contributing page?
Also, the username under which you're committing and pushing to Github seems to be mis-configured. You will have to look into how to configure your git settings properly, amend the author of the commits and then force push back to the branch. (When your user is properly set up, you see your avatar when against your commits in the commit history, otherwise it's a default grey avatar).

@akhil10x5 ,
Thanks for fixing the build! Could you now please sort out your git/github username/avatar and amend the author for the commits in this pull? Thanks! :)

Thank you for your help and congratulations on your first pull request!


Inconsistent cursor size

System Info and Version
 System/Version info
Hyprland, built from branch  at commit cba1ade848feac44b2eda677503900639581c3f4  (props: bump version to 0.40.0).
Date: Sat May 4 15:42:32 2024
Tag: v0.40.0, commits: 4606

flags: (if any)

System Information:
System name: Linux
Node name: syn-2603-8080-3200-1fef-0000-0000-0000-168e.res6.spectrum.com
Release: 6.6.30-gentoo-dist
Version: #1 SMP PREEMPT_DYNAMIC Thu May 23 11:46:34 CDT 2024

GPU information:
c1:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD/ATI] Phoenix1 [1002:15bf] (rev c1) (prog-if 00 [VGA controller])

os-release: NAME=Gentoo
ID=gentoo
PRETTY_NAME="Gentoo Linux"
ANSI_COLOR="1;32"
HOME_URL="https://www.gentoo.org/"
SUPPORT_URL="https://www.gentoo.org/support/"
BUG_REPORT_URL="https://bugs.gentoo.org/"
VERSION_ID="2.15"

plugins:

Bug or Regression?
Bug
Description
My cursor changes size when it's placed over certain parts of the Steam and Firefox UIs. It also changes size when playing any type of game (either with proton via Steam like with Minecraft).
Firefox doesn't have this issue when nwg-look is used with HYPRCURSOR_THEME and HYPRCURSOR_SIZE, though the issue persists with Steam and games.
How to reproduce
Playing any game and placing cursor over certain Steam UI parts.
Crash reports, logs, images, videos

hyprland.txt
I'm sorry for taking pictures instead of screenshots — I'm still trying to figure out grim and slurp. All pictures were taken from the same distance to demonstrate cursor size changes.

sad reality of cursors on linux. https://wiki.hyprland.org/Hypr-Ecosystem/hyprcursor/
play with xcursor_size until it's good enough

I tried to use a different cursor and now the cursor is distorted. Is this an issue with converting xcursors to hyprcursors?

converting xcursors to hyprcursors with the util works 90% of the time without issues. For best result, you should manually replace pngs with svgs. You can also use a pre-made theme, of course.
Try using hyprctl setcursor, or in your config env = XCURSOR_SIZE,24 (24 or any other size)

To ensure that I don't take up too much of your time and to give you the full context of the problem, here's the full scope of the issue:
I'm using phinger-cursors-dark from https://github.com/phisch/phinger-cursors. I changed it into hyprcursors via hyprcursor-util -x phinger-cursors-dark and hyprcursor-util -c extracted_phinger-cursors-dark. The hyprcursors were renamed to "phinger-cursors" and the xcursors to "phinger-cursors-X" (not just the directories, but in manifest.hl and index.theme). I placed both in ~/.icons and ~/.local/share/icons so that I can be sure that there are no discrepancies.
These lines are in my hyprland.conf:
env = HYPRCURSOR_THEME,phinger-cursors env = HYPRCURSOR_SIZE,24 env = XCURSOR_THEME,phinger-cursors-X env = XCURSOR_SIZE,24
env = XCURSOR_SIZE,24 doesn't fix the distortion nor the size issues. hyprctl setcursor phinger-cursors-X 24 sets the cursor to a small adwaita cursor. hyprctl setcursor phinger-cursors 24 has the same distortion issue.
It seems that the distortion is a problem with the xcursor to hyprcursor issue, but none of this addresses the size issue.
It's likely that I did something wrong due to this being my first venture into hyprland, though I'm not sure where that could be.

distortion is IIRC a reported issue in hyprcursor, it's a bug in the util I believe. Try some of the SVG themes from the #hyprcursor-themes channel in discord.

I'll try that, thank you. Is there anywhere else I can get feedback on this problem? I tried posting about it in the discord but I have yet to get a reply. I feel bad bothering the lead dev with such a mundane problem.

This problem just keeps getting more complicated. I set my theme to https://github.com/ndom91/rose-pine-hyprcursor and now hyprpaper doesn't work. My cursor is now different for my desktop, firefox, and steam. The small cursor and big cursor on steam have different themes (in a different permutation than before, but that's unneeded context). I think the actual solution is to not use hyprland since  nothing seems to solve this problem. Unless you have any ideas or anyone else I can talk to about this, I think that I'm just going to try a different wm.

you can also not use hyprcursor. I feel like this is a misconfiguration of some sort on your end though as it seems to work just fine for me and many others

I just tried using just xcursor without making any changes to anything else, but it's distorted, which makes me think that the original distortion isn't because of hyprcursor-util. At this point I'm just confused, and the lack of help (not referring to you) or documentation is making this increasingly frustrating.

I had a similar issue as this Reddit post here, where the

cursor size smaller on desktop than everywhere else

A related issue might be "Cursor size with HiDPi #2448"
The most consistent way I've managed to get the cursors working is to install a cursor theme that exists for both XCursor and Hyprcursor, then set their sizes with nwg-looks and in hyprland config.
For example, choosing rose-pine cursor on Arch linux (just so the instructions can be simplified using an AUR helper), here are the steps:

Install rose-pine/cursor from the AUR:
yay -S rose-pine-cursor

Install rose-pine-hyprcursor from the AUR:
yay -S rose-pine-hyprcursor

Install nwg-look
yay -S nwg-look

Open nwg-look and set your preferred Xcursor and size:

Open your ~/.config/hypr/hyprland.conf and use the same configuration for Hyprcursor:
env = HYPRCURSOR_SIZE,28
env = HYPRCURSOR_THEME,rose-pine-hyprcursor

Either reboot or restart Hyprland

https://github.com/hyprwm/Hyprland/issues/6320#issuecomment-2243109637
This worked !!, so i need to find xcursor theme of same hyprcursor theme got it ! Thank you :)

The most consistent way I've managed to get the cursors working is to install a cursor theme that has both Xcursor and Hyprcursor variants, then set their sizes using nwg-look and in hyprland environment variables respectively.

Finally a solution for this that has been haunting me ever since.


Static assets are not copied

Hi,
Today i've noticed that with the latest version of this plugin, static assets from components are not copied to the static storybook folder.
Webpack is loading them like <img src="img/ic-forward.f9f0c5c8.svg"> but within the storybook-static folder there are no images copied. This prob has to do with the new webpack config that was added in the latest release.

To clarify, this happens in dev mode. Building storybook seems to work fine.

This page contains the following errors:
error on line 1 at column 1: Document is empty

Below is a rendering of the page up to the first error.

@leovanhaaren I am working on releasing a new version (probably today). I am not sure whether this particular issue will be fixed or not. The new version will completely use your vue project's webpack config. If you are interested, we could chat on Vue discord #webpack channel once I publish the next version

Cool! I'll wait for the new version then, if the issue still persist we can indeed have a chat. Thanks for the fast reply!

@leovanhaaren 0.3.0 is released. It should be a completely good version (except for typescript and lint)

@pksunkara I can now confirm that it works. Thanks for the fast update!

@leovanhaaren Np. Don't mind to open issues for any thing you think is wrong.


Example to show P2TR or Taproot address

It seems that this library can support taproot receiving address, can there be example on how to generate a P2TR receiving address using this library?

The time we added support for Taproot, BitcoinJS (which we fork from) didnt yet agreed on a payments.p2tr interface, so you have to generate it low-level so to speak.
This is an example of how to build a Taproot address with
https://github.com/vulpemventures/liquidjs-lib/blob/master/test/integration/taproot.spec.ts#L38-L73
The key-path spend is simply passing a public key as the first argument of bip341.taprootOutputScript and the taproot tree as second.
You can then get the taproot address from the script passing the network object
const unconfidentialAddress = address.fromOutputScript(
      output,
      networks.regtest,
    );
    const confidentialAddress = address.toConfidential(
      unconfidentialAddress,
      bob.publicKey,
    );

Let me know if it's enough, I keep it open in case, will close later


Custom Frames Size

Hi guys, just wondering if there's any way to customize a size of generated frames? I tried changing sizes in DiT and VAE, but then I got a bunch of errors due to shapes unmatching (I think it comes from the PatchEmbed layer).

Edit: Unfortunately, it's impossible to use pre-trained models with different resolution (any other resolution than a default one results in a pixel mess). But it's possible to fine-tune the or retrain the model with a new resolution (the DiT part). But with default model patching the resolution must be divisible by 40.


Updated list of Azure tenants and prospects

Describe the issue
We need a report on the subscriptions in use in Azure currently and anything that has been promised to prospective tenants.
Which Sprint Goal is this issue related to?

Note: 'Milestone' is a ZenHub term that we use synonymously with 'Sprint'.

The 'Milestone' description (created in ZenHub) should clearly list Sprint Goals. This section should indicate which 'goal' this issue is related to.
Additional context

Jon M likely has this information
We are scoping this to application related subscriptions only (Visual Studio, components are out of scope)
Reach out to Audra for access to the funnel on Airtable

Definition of done

Get familiar with Airtable at the same time
Airtable entries from the intake funnel, or Excel in Teams partnering with Audra

This is top priority to provide to Audra, takes priority over all other Azure activities please

Completed and sent last week.  Closing.


chore: move packages out of source

Summary
External libraries are currently submoduled in the source tree which leads to more complex builds and makes maintaining and debugging more difficult.
This PR moves external libraries to extern in the root dir and drops submodules in favor CMake methods of fetching dependencies.
Specifically, this PR does the following:

removes all git submodules.
adds CMake configs to get extern libs.
updates CMake configurations and naming.
makes building tests optional.
updates build scripts.
updates Actions/CI scripts and workflow.
updates PIO configuration files.
updates the Arduino IDE helper script.
updates the changelog.

Checklist

[ ] Documentation (if necessary)
[ ] Tests (if necessary)
[x] Ready to be merged

Additional Comments
PIO build failure is resolved in #139

@sleepdefic1t platformio failing


Sporadic error during apply -  no matches for kind "Certificate" in version "certmanager.k8s.io/v1alpha1"

When running ks apply repeatedly, I am getting a sporadic error: no matches for kind "Certificate" in version "certmanager.k8s.io/v1alpha1"
$ ks apply apps/ksonnet-site/dev
ERROR handle object: patching object from cluster: merging object with existing state: unable to recognize "/var/folders/gl/9th4vs815bv_bwgkxs9rmgr40000gn/T/ksonnet-mergepatch440889523": no matches for kind "Certificate" in version "certmanager.k8s.io/v1alpha1"

$ ks apply apps/ksonnet-site/dev
INFO Applying serviceaccounts default
INFO Creating non-existent serviceaccounts default
ERROR handle object: creating object: creating object: namespaces "ksonnet-site" not found

Version information
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.2", GitCommit:"81753b10df112992bf51bbc2c2f85208aad78335", GitTreeState:"clean", BuildDate:"2018-05-12T04:12:12Z", GoVersion:"go1.9.6", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"10", GitVersion:"v1.10.0", GitCommit:"fc32d2f3698e36b93322a3465f63a14e9f0eaead", GitTreeState:"clean", BuildDate:"2018-03-26T16:44:10Z", GoVersion:"go1.9.3", Compiler:"gc", Platform:"linux/amd64"}

$ minikube version
minikube version: v0.28.0

$ ks version
ksonnet version: 0.12.0-rc1
jsonnet version: v0.10.0
client-go version:

This is likely caused because you created a controller and CRD that uses a GVK that controller. The controller will have to be fully initialized before using the CRD. If this is the case, you'll have to create the controller and ensure it is running first.

@shomron can you reduce this to a test case that reproduces this error message?


bump nodejs/npm dependencies

This pull request is now managed with CodeReviewHub. Refresh.

Nice

hmmmm ... though it passed the test, seems there is a problem in browser console, and I can't click the "play button" now:
SyntaxError: export declarations may only appear at top level of a module

Interesting... might be a breaking change in the Babel 5 -> 6 upgrade

Seems so, so sent #430 first.


[Devops] using docker-compose

Create a docker-compose.yml, using instead of shell script file

In another devices, using command to pull my image

docker pull lcaohoanq/snake_game_app:latest


Fix wego quality content attachments

Wego quality content currently doesn't work with attachments

Duplicate of https://github.com/rickklaasboer/wego-overseer/issues/93


Add a cop to check for consistent method usage in feature specs.

I started down the path of making this ConfigurableEnforcedStyle, with rspec and capybara options.
If someone were to set capybara, we'd have to make sure to only check:

Files in spec/features
Files with type: :feature (and possibly just :feature?) metadata

I wasn't sure of the best way to handle those two conditions, so I'm open to feedback on making this configurable.

I’ve been trying to find out why capybara provides these aliased methods. The README just says that “Capybara also comes with a built in DSL for creating descriptive acceptance tests […] feature is in fact just an alias for describe ..., :type => :feature, background is an alias for before, scenario for it, and given/given! aliases for let/let!, respectively.” without any explanation for why this DSL should be preferable.
Also, I just want to note that these aliases are only available if Capybara (or rspec-rails) is loaded. Which puts this cop in the same category as RSpec::FactoryGirl::DynamicAttributeDefinedStatically as “not really an RSpec cop, but close”. Perhaps we should have an RSpec::Capybara module?

@bquorning I believe they're just syntactic sugar to make feature specs read more like Cucumber features.

Yup, this should be in RSpec::Capybara module. There are few other things we could implement for capybara (like #378 for example)

Moved the copy to a new Capybara namespace.

Can't see what the build failures are since they're private.

@rspeicher you can run rake on your local machine to check the build. I think you should add Capybara to the namespaces in ConfigFormatter and fix the build_config script to include capybara
-cops = '{*.rb,factory_girl/*.rb}'
+cops = '{*.rb,factory_girl/*.rb,capybara/*.rb}'

Ahh, I think you need to add ,capybara/*.rb to bin/build_config for the confirm_config test to pass.

Back to green, thanks y'all!

Rebased since 1.16.0 was released.

I think it's ready for merge. @backus final words?

LGTM. @rspeicher or @Darhazer (whoever does the merge) can you squash down the commits?


Bosh CPI does not support uploading of full stemcells from bosh.io

The bosh.io published stemcells can't be uploaded and used by bosh cpi.
Please review below PR suggestions with potential fix for this issue:
https://github.com/cloudfoundry-incubator/bosh-alicloud-cpi-release/pull/50

Fixed by release v20.


Change to Static Transforms for camera

Changes proposed in this pull request:

Switch to using a static transform for the camera as the data does not change.
Fixes the warning generated when the dynamic transform was used.

You may want to remove this from the README or update it with a command relevant to static transforms. https://github.com/intel-ros/realsense/tree/782b2a5261c3f8063287c6cb747193e7f41581ab/realsense_camera#transform-frames
On a side note, not related to this PR, the current description for "tf_monitor" is incorrect. It prints on screen instead of generating a pdf. It is "view_frames" that generates the pdf.

@reaganlo README updated; good catch.

Looks good to me. Approved.

Approved :+1:


Convention for services: quick question

I'm using sails with passport generator and ember-data generator. Is the convention for services to capitalize the service like Ember.js or lowercase it like passport.js? There just seems to be a discrepancy.

I typically capitalize my my service filenames, and suffix them with "Service". e.g. MinerService: https://github.com/hashpanel/server/tree/master/api/services.
If you have globals on, then you'll want these names to be unique, which is why suffixing with Service is a good idea. This convention is also used in the official sails.js documentation: http://sailsjs.org/#!/documentation/concepts/Services?q=how-do-i-create-a-service

@tjwebb Thanks so much


create volume mount hostdir if it does not exist

In the case where the host dir of a volume mount does not exist, we
should create it.  We use 0755 permissions on the dir creation.  This
mimics docker behavior.
Resolves: #1324
Signed-off-by: baude<EMAIL_ADDRESS>

I don't like this.  I believe this behaviour is wrong, and allows users to have a typo and get unexpected behaviour.  I think we should vary from docker and report this as an error, if the source dir/file does not exist.

Ok closing


Create assets folder while installing

Create the public asset folder to prevent error while installing the
barclamps for the first time. This case happens only when setting up the
development envoiremt or installing from git.

envoiremt == environment
Small typo in commit message, otherwise I'm fine with that.

@tboerger done

LGTM


How I can use the refined types pratically with other languages.

Hello, I am pretty new to the Ocaml type system but I'll like to use the refined type. So please, can you give me a small walkthrough on how I can go about to use this system or the code in your repository? The latest version of Ocaml is installed in my machine already.
Thanks.

@Ayoya22
Check this link, https://www.google.com/search?client=ubuntu&hs=gVG&channel=fs&sxsrf=ACYBGNQlCeO7d2_X0G14vtUuVm1615V1CQ%3A1572380317083&ei=nZ64XbzfBMeGhbIPi42z-As&q=refined+type+ocaml&oq=refined+type+OCa&gs_l=psy-ab.1.1.33i21l2.2998.5235..8222...0.4..0.614.1402.2-3j5-1......0....1..gws-wiz.......0i71j0i10j0i22i30j33i160.d1TFHSsPKMo


Captcha Challenge

After submitting one anonymous review, submitting another requires a captcha to be solved. The challenge is to bypass this captcha and create multiple anonymous reviews e.g. in a short time period. This could be coupled with a Rate Limiting for submitting reviews allowing two tiers for the challenge:

Captchas Tier 1: Submit more than one anonymous product review within 10 seconds

Difficulty: :star::star::star::star: or :star::star::star::star::star:

Captchas Tier 2: Submit 10 or more product reviews within 10 seconds

Difficulty: :star::star::star::star::star: or :star::star::star::star::star::star:

For the actual captcha either an existing library with known vulns could be used, or one that can be misconfigured. Alternatively a proprietary weak captcha could be written, e.g. relying on cookies or some session/local storage.
Possible Libs

https://github.com/VividCortex/angular-recaptcha
https://www.npmjs.com/package/angularjs-captcha

Is it not possible to post more than 1 product review within 10 seconds even if we have captcha ?

Yeah, you're right, we can't really measure the Captcha bypass by reviews per time, can we? Other ideas?

As captchas are used for defeating automated scripts after attacker have some way to bypass rate limit in real life and as we already have rate limit bypass fun, I suggest we just implement captcha bypass and check the solution based on the method to bypass instead of implementing Tier 2 challenge. I was looking into some recent bug reports like :

https://hackerone.com/reports/229584
https://hackerone.com/reports/124173

In realistic scenario if someone is not using Google reCaptcha, this type of vulnerabilities occur. First flaw occurs many times and will be good to for us. What do you think?

Also we can implement classic front-end check flaw by sending captcha answer to client.

I like https://hackerone.com/reports/229584 a lot. Gives us a good 3- or 4-star challenge.

and we will verify the solution based on reviews per time? 10 reviews per 5 second will be fine. I will have to check time taken for python requests module for 1 request. Other languages will do fine. Right?

Other language? For what? You mean to actually perform the attack? There people can use what they want. For e2e testing we should stick to Javascript/Protractor.

Yea I meant to say , is 10 or more reviews per 5 sec a good solution? Because they will also have to request review page for the captcha 10 times and issue the req. That will take time more than 5 sec maybe.

Well, the idea is to force them to automate/script that, so it should be no problem, right? Alternatively someone could open 10 tabs and prepare everything and send them really quickly in 0,5sec per tab... :rofl:

Stuck at captcha verification at backend !. POST request containing feedback and captcha answer goes to /api/Feedbacks/ and which is handled by epilogue and directly inserted in DB I guess. Am not familiar with epilogue. Any suggestion on how it can be done ? or front end check of captcha answer is also good if its not possible with epilogue ?

I think you could put another route handler before the definition for epilogue, similar to the access control handlers for the models. If that blocks, the request won't reach epilogue so nothing ends up in database.

But then I will have to put the reviews in DB myself after confirming captcha?

Added captcha in #467. Will add challenge soon. Any suggestions on way to verify the solution of this challenge ?

No, if your route doesn't send a response it will basically tumble through to the next responsible handler. And that should be epilogue then!

Added Challenge in #480.


BE Feature - master state in py file

Will probably tackle #6 as well with this one as well. Main things to solve:

Need a schema for default args - need to check if airflow already has a schema for this, otherwise will need to roll our own
Every operator needs a start date - need to validate what other fields need to be required here
We need a way of handling default args in an elegant way in the front end.
Conversion for dag object to daghandler object

For now the quick fix is probably to default start_date to DAG creation date or something similar


Add suggestion to run gpt --update after installing

To try to avoid this for new users: https://github.com/mattvr/ShellGPT/issues/18

Hm, this shouldn't be necessary. @nicobrenner The recommended install flow implicitly installs the latest version. (deno run -rA https://deno.land/x/shellgpt/install.ts)
When you tried earlier, you ran into a bug with 0.3.6 only that's now been fixed.
I just tested a fresh install and there wasn't a need to manually run --update.

Excellent. Thank you
On Sat, Mar 9, 2024 at 12:19 PM mattvr @.***> wrote:

Hm, this shouldn't be necessary. @nicobrenner
https://github.com/nicobrenner The recommended install flow implicitly
installs the latest version. (deno run -rA
https://deno.land/x/shellgpt/install.ts)
When you tried earlier, you ran into a bug with 0.3.6 only that's now been
fixed.
I just tested a fresh install and there wasn't a need to manually run
--update.
—
Reply to this email directly, view it on GitHub
https://github.com/mattvr/ShellGPT/pull/19#issuecomment-1986966748, or
unsubscribe
https://github.com/notifications/unsubscribe-auth/AARQXNGGXL6V4BPOJNDIIQTYXNVDVAVCNFSM6AAAAABEOLM7G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBWHE3DMNZUHA
.
You are receiving this because you were mentioned.Message ID:
@.***>


Updating libtorrent for deluge

I am not an expert user of linux so have been using this toolkit to install and update most of my htpc software. Tried using the instructions on the deluge website to update the libtorrent version used with torrent to the lastest version. So far was unable to so would like if such an update can be added to atomic tookit

Hi, Sorry i've not got back to you sooner.
Currently Deluge is installed via the official  Deluge repository for most Linux distributions. This also includes the latest stable version of libtorrent that they recommend using with Deluge. I've noticed that the repository also supports Debian which Atomic-Toolkit should be taking advantage of so I will work on getting that added. If you want to try and get the very latest version of libtorrent then it has to be built from source with different parameters required depending on the hardware etc it was being built for. This would also require manually updating as apposed to automatically updating via the repository.  However quickly looking through the Deluge forums, it appears to be suggesting that your better off sticking with the version available from their repository.
For those reasons I feel its best to stick with how it currently installs and I will add Debian\Raspbian to use the official repository as well in future.
Hope that explains it but if you want to ask anymore questions then feel free to contact me on Gitter
thanks
Tom

Thanks for the detailed explanation. I understand why you would not want to make it the default but I get better upload speeds and am able to connect to more peers by using the latest version of libtorrent. I was able to find an easy way to get the latest version without compiling myself by adding qbittorent unstable ppa and using that to update libtorrent.
https://launchpad.net/~qbittorrent-team

Hi,
Sorry I've not got back to you sooner again, but I've been away on a much needed holiday!
That is a super spot that they use a newer more up to date version in that repo. I'll look at adding this, I'm thinking the best way would be to add the repo separately at the install stage when we add the Deluge repo..
Thanks for your time and investigation work!
Tom
If you want to discuss anything with me please don't hesitate to contact me on Gitter.
Don't forget to vote for new features on Feathub and help drive the focus of AtoMiC-ToolKit!


Fix Typo in First Steps

@brian-brazil
Fix typo in First Steps documentation

Can you add the DCO please?

By DCO, @brian-brazil means git commit -s --amend.

Added

Thanks!


"Code that traverses element fails on comment node"--Ray

Type of issue [REQUIRED]
Bug
Uploader type [REQUIRED]
traditional
Bug details [DELETE EVERYTHING IN THIS SECTION IF THIS IS A FEATURE REQUEST]
Per my question on stack overflow
The bug is that the code breaks on candidates = element.getElementsByTagName("*") in this getByClass: function(className, first) method. The element variable's value is a #comment. It fails when I try to upload a file with a valid extension. It failed on className is .qq-upload-file-selector.
It turned out I had a comment node right after that class, which fine-uploader failed on.  I'm filing a bug report per Ray's answer on SO.
Fine Uploader version [REQUIRED]
Fine Uploader v5.10.1
Browsers where the bug is reproducible [REQUIRED]
Chrome, IE9, Firefox
Operating systems where the bug is reproducible [REQUIRED]
Windows 10
Exact steps required to reproduce the issue [REQUIRED]
For example:

Add a commented out div inside the .qq-upload-file-selector class.
Create an angular directive as per linked SO above.
Attempt to add a file with a valid extension.

All of your Fine Uploader initialization JavaScript code [REQUIRED]
 angular.module("myApp").directive('fineUploader'), function(){
    return{
        restrict: "A",
    scope: {
        uploadedFilesModel: '='
    },

    link: function ($scope, element, attrs) {
     $scope.uploader = new qq.FineUploader({
            debug: true,
            element: document.getElementById('fine-uploader-manual-trigger'),
           // element: element[0],
            multiple: false,
            text:{
                 uploadbutton: ' upload file'
            },
            template: document.getElementById('qq-template-manual-trigger'),
            request: {
                endpoint: attrs.endpoint,
                customHeaders: {
                    "AuthorizationToken": localStorage.token
                }
            },
            validation: {

                allowedExtensions: allowedExtensions
                sizeLimit: sizeLimit
            },
            classes: {
                success: 'alert alert-success',
                fail: 'alert alert-error'
            },
            callbacks: {
                onComplete: function (id, fileName, response) {
                    if (response.success) {
                        $scope.uploadedFilesModel = response;
                        $scope.$apply();
                        $('li.alert-success').delay(500).fadeOut('slow',                    function () {
                            $(this).remove();
                        });
                    }
                }
            }
    }
    };

Your Fine Uploader template markup (if using Fine Uploader UI and the issue is UI-related)

Upload a file

Select files

          <button type="button" id="trigger-upload" class="btn btn-primary">
                 Upload
           </button>

          Processing dropped files...

            <input class="qq-edit-filename-selector qq-edit-filename" tabindex="0" type="text">

            <button type="button" class="qq-btn qq-upload-cancel-selector qq-upload-cancel">Cancel</button>
            <button type="button" class="qq-btn qq-upload-retry-selector qq-upload-retry">Retry</button>
            <button type="button" class="qq-btn qq-upload-delete-selector qq-upload-delete">Delete</button>

Detailed explanation of the problem [REQUIRED]
When uploading a file with a valid extension, the call failed and would not upload the file.  After discussing the issue with Ray on SO, he saw that the code is failing on a comment div.  I included the commented out div that I had on my html above.  It's located right below the .qq-upload-list-selector.

Thanks for filing this. I adjusted your question formatting a bit. This should be an easy fix. If you'd like to give it a try, feel free and open up a pull request. Otherwise, I'll get to this when I can.


can we change black background with clear color or semi transparant black color?

Expected behavior
it allowed to change background colour based on app theme
Actual behavior
it showing in only Black color
Steps to reproduce the behavior
Add Colour type variable in configuration so user can change the colour based on his requirements

I think this would be a nice addition to the library ;) Feel free to open a PR where the backgroundColor/theme is configurable 👍

@LcTwisk maybe you could check out the pull request #47? The background colour can be changed now (see updates in example project).


How to use this in my android studio project?

I want to use your yuv to rgb function but simply copy pasting your code into a kotlin file seems to not work as I get errors. How do I use this project?

Okay, so I managed to compile and add it to my project but now I get an error when I try to use IntrinsicYuvToRgb.kt
Unresolved reference: YuvFormat
I am unable to add YuvFormat, there is no such object

I fixed the issue by copying the renderscript-toolkit folder into the same folder as my android studio project


CASMPET-7117: iSCSI SBPS provision and DNS config fails when HSN is not configured/ CASMPET-7126: CFS play for k8s labelling fails when it is already applied

Summary and Scope

CASMPET-7117: iSCSI SBPS: LIO provision and DNS records config fails when HSN is not configured

fixed iSCSI LIO provisioning to exclude HSN portal config when HSN n/w is not configured
fixed to avoid DNS "SRV" and "A" records creation for HSN when HSN is not configured

CASMPET-7126: iSCSI SBPS: k8s labelling fails when it is already applied

fixed to avoid applying k8s label when it already exists

Issues and Related PRs
Original EPIC: https://jira-pro.it.hpe.com:8443/browse/CASMPET-6797
Testing
Tested on bare metal systems with multi worker nodes
Tested on:
"starlord" and "Odin"
Test description:

verified LIO provisioning where HSN n/w is not configured, where it does not fail the overall config instead ignores HSN and creates rest of the portals (NMN and CMN).

verified LIO provisioning where HSN n/w is configured, it creates all three n/w portals HSN, NMN and CMN.

verified DNS "SRV" and "A" records creation where HSN n/w is not configured, it creates “SRV” and “A” records for NMN without any failure.

verified DNS "SRV" and "A" records creation where HSN n/w is configured, it creates “SRV” and “A” records for both HSN and NMN without any failure.

verified k8s node labelling fresh and also when it is already applied. K8s node labelling is successful without any failure in both cases.

Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)?

Were continuous integration tests run? If not, why?

Was upgrade tested? If not, why?

Was downgrade tested? If not, why?

Were new tests (or test issues/Jiras) created for this change?

Risks and Mitigations
None
Pull Request Checklist

[] Version number(s) incremented, if applicable
[x] Copyrights updated
[] License file intact
[x] Target branch correct
[x] CHANGELOG.md updated
[x] Testing is appropriate and complete, if applicable
[ ] HPC Product Announcement prepared, if applicable

Previously I didn't notice all the hard-coded references to hpc.amslabs.hpecorp.net.  Those all need to be fixed to dynamically determine the host's domain name and use that instead.

Please run the shell scripts through shellcheck and address the issues it finds (yes, I know some of the issues were there before, but it'd be good to clean them up)

Please run the shell scripts through shellcheck and address the issues it finds (yes, I know some of the issues were there before, but it'd be good to clean them up)

I have addressed all the "shellcheck" thrown warnings except the one below from file apply_k8s_label.sh
Line 29:
if [[ ! $(kubectl get nodes -l $LABEL | grep "$HOST_NAME") ]]
        ^-- SC2143 (style): Use grep -q instead of comparing output with [ -n .. ].
$

It is suggesting to use "-q" (quite option) but that does not work since the cmd returns "0" always (for both the cases where label is present / not present. Just that it won't print the output to stdout).  Also, not opting to use "--overwrite" option just for the sake of avoiding this warning from "shellcheck". Since ansible is idempotent, just don't want to overwrite config.

Please run the shell scripts through shellcheck and address the issues it finds (yes, I know some of the issues were there before, but it'd be good to clean them up)

I have addressed all the "shellcheck" thrown warnings except the one below from file apply_k8s_label.sh
Line 29:
if [[ ! $(kubectl get nodes -l $LABEL | grep "$HOST_NAME") ]]
        ^-- SC2143 (style): Use grep -q instead of comparing output with [ -n .. ].
$

It is suggesting to use "-q" (quite option) but that does not work since the cmd returns "0" always (for both the cases where label is present / not present. Just that it won't print the output to stdout). Also, not opting to use "--overwrite" option just for the sake of avoiding this warning from "shellcheck". Since ansible is idempotent, just don't want to overwrite config.

It works fine for me:
ncn-m001:~ # kubectl get nodes -l $LABEL
NAME       STATUS   ROLES                  AGE   VERSION
ncn-m001   Ready    control-plane,master   13d   v1.22.13
ncn-w001   Ready    <none>                 13d   v1.22.13
ncn-w002   Ready    <none>                 13d   v1.22.13
ncn-w003   Ready    <none>                 13d   v1.22.13
ncn-w004   Ready    <none>                 13d   v1.22.13
ncn-m001:~ # kubectl get nodes -l $LABEL | grep -q ncn-w001
ncn-m001:~ # echo $?
0
ncn-m001:~ # kubectl get nodes -l $LABEL | grep -q ncn-m002
ncn-m001:~ # echo $?
1
ncn-m001:~ #

so, the change should be to simplify to just:
if ! kubectl get nodes -l $LABEL | grep -q "$HOST_NAME"

@ravikanth-nalla-hpe, this looks good.  Fix the final shellcheck error and this is ready to be merged, please squash everything down to a single commit.

@mharding-hpe Can you please merge this PR to master branch?

@mharding-hpe Can you please merge this PR to master branch?

First we will need to merge it into develop, once we resolve the couple of small review comments. Then we can merge it to master.

You'll also need to rebase on top of the changes that have been made to develop


Can't create resource in GCP

What happened?
Hello Team ,
I am trying to create a GCS bucket using pulumi as backend code which is serving via a fast api server .
Here's the request i am using to create the resource:
curl -X POST "http://<IP_ADDRESS>:8000/create-bucket" -H "Content-Type: application/json" -d '{
"bucket_name": "fastapi-pulumi-bucket",
"location": "europe-west3",
"force_destroy": true
}'
I have even setup the gcp project using pulumi config set gcp:project $projectname.
And below is the error i am facing:
{"detail":"\n code: 255\n stdout: Updating (aws):\n\n@ updating....\n    pulumi:pulumi:Stack aws-aws running warning: unable to detect a global setting for GCP Project.\n@ updating....\n +  gcp:storage:Bucket fastapi-pulumi-bucket creating (0s)\n +  gcp:storage:Bucket fastapi-pulumi-bucket creating (0s) error:   sdk-v2/provider2.go:520: sdk.helper_schema: project: required field is not set<EMAIL_ADDRESS>+  gcp:storage:Bucket fastapi-pulumi-bucket creating (0s) error: 1 error occurred:\n +  gcp:storage:Bucket fastapi-pulumi-bucket creating failed error: 1 error occurred:\n    pulumi:pulumi:Stack aws-aws running error: update failed\n@ updating......\n    pulumi:pulumi:Stack aws-aws failed 1 error; 1 warning\nDiagnostics:\n  pulumi:pulumi:Stack (aws-aws):\n    warning: unable to detect a global setting for GCP Project.\n    Pulumi will rely on per-resource settings for this operation.\n    Set the GCP Project by using:\n        pulumi config set gcp:project <project>\n    error: update failed\n\n  gcp:storage:Bucket (fastapi-pulumi-bucket):\n    error:   sdk-v2/provider2.go:520: sdk.helper_schema: project: required field is not set<EMAIL_ADDRESS>  error: 1 error occurred:\n    \t* project: required field is not set\n\nResources:\n    1 unchanged\n\nDuration: 3s\n\n stderr: "}%
Example
from fastapi import FastAPI, HTTPException
from pydantic import BaseModel
import pulumi
from pulumi_gcp import storage
from pulumi.automation import select_stack, Stack
import os
app = FastAPI()
os.environ['PULUMI_CONFIG_PASSPHRASE'] = "******"
class BucketRequest(BaseModel):
bucket_name: str
location: str
force_destroy: bool = False
def create_gcs_bucket(bucket_name: str, location: str, force_destroy: bool):
bucket = storage.Bucket(
bucket_name,
location=location,
force_destroy=force_destroy
)
pulumi.export("bucket_name", bucket.name)
@app.post("/create-bucket")
async def create_bucket(request: BucketRequest):
# Use an existing stack
stack_name = "aws"
try:
# Select the existing stack
stack = select_stack(
stack_name=stack_name,
project_name="aws",
program=lambda: create_gcs_bucket(request.bucket_name, request.location, request.force_destroy)
)
    up_result = stack.up()

    return {
        "message": f"Bucket '{request.bucket_name}' created successfully",
        "output": up_result.outputs,
    }

except Exception as e:
    raise HTTPException(status_code=500, detail=str(e))

Output of pulumi about
CLI
Version      3.138.0
Go Version   go1.23.2
Go Compiler  gc
Plugins
KIND      NAME        VERSION
resource  automation  0.1.0
resource  gcp         8.9.1
language  python      unknown
Host
OS       darwin
Version  15.1
Arch     x86_64
This project is written in python: executable='/Users/chaitanyavats/IdeaProjects/pulumi/venv/bin/python' version='3.12.4'
Current Stack: organization/aws/aws
TYPE                  URN
pulumi:pulumi:Stack   urn:pulumi:aws::aws::pulumi:pulumi:Stack::aws-aws
pulumi:providers:gcp  urn:pulumi:aws::aws::pulumi:providers:gcp::default_8_9_1
pulumi:providers:gcp  urn:pulumi:aws::aws::pulumi:providers:gcp::default_8_8_1
Found no pending operations associated with aws
Backend
Name           abc
URL            file://~
User           chaitanyavats
Organizations
Token type     personal
Dependencies:
NAME               VERSION
fastapi            0.115.5
Flask              3.1.0
pip                24.3.1
pulumi-automation  0.1.0
pulumi_gcp         8.9.1
setuptools         75.4.0
uvicorn            0.32.0
wheel              0.45.0
Additional context
No response
Contributing
Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

Hi @cvatsops. Thanks for posting your problem here.
The error message suggests you need to set a project for your bucket. Did that not work?

Hi @VenelinMartinov I have already set the gcp project using pulumi config set gcp:project project_name.
Is there any other way to set it?

Hi @cvatsops. Thanks for posting your problem here.
The error message suggests you need to set a project for your bucket. Did that not work? EDIT: I see that you are using Automation API, did you try setting the config on the Automation API stack like the example here: https://www.pulumi.com/docs/iac/packages-and-automation/automation-api/getting-started-automation-api/#configure-your-provider-plugins?

Can you instead provide the example for GCP.

Yeah, it looks like you are using Automation API. Please take a look at https://www.pulumi.com/docs/iac/packages-and-automation/automation-api/getting-started-automation-api/#configure-your-provider-plugins
Also, a great place to find help with questions related to pulumi is the pulumi community slack channel: https://slack.pulumi.com/

You'd need to adapt the instructions for the GCP provider: https://www.pulumi.com/registry/packages/gcp/installation-configuration/#authenticate-using-the-cli to work with the automation API: https://www.pulumi.com/docs/iac/packages-and-automation/automation-api/getting-started-automation-api/#configure-your-provider-plugins
Note that the Automation API is a somewhat advanced feature, you might have an easier time starting off with one of the "Getting Started" guides.


Add out_ch param to models

The out_ch param was doing nothing!
repaired this.
I would also recommend removing the sigmoid calls at the end, and use BCE with Logits.

Thanks for the comments. We also realized that. Will update that later.


Updated index.md

Updated index.md to include a table of contents for easier file navigation, now the user can jump to the relevant section.

[x] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[x] My pull request targets the master branch of freeCodeCamp.
[x] None of my changes are plagiarized from another source without proper attribution.
[x] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

HI @GunnerJnr
It seems that similar changes have already been accepted earlier for this article you're editing, sorry about that. 😓
If you feel you have more to add, please feel free to open up a new PR.
Thanks again! 😊

If you have any questions, feel free to reach out through Gitter or by commenting below. 💬


test: add IAM integration test

This PR adds an integration test for the IAM authenticator.

:tada: This PR is included in version 3.16.3 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Fixed integration problem

Even though SupeiorSkyblock2 is soft depend, it is loading after the Farmer because of the “loadbefore: wildstacker” option in the plugin yml. I scheduled a BukkitTask to load integrations right after the server is fully loaded.
Logs: https://mclo.gs/NXuEGSM

thank you


Show/list runnable stored procedure on query page

As titled

fixed: https://github.com/GraphScope/portal/pull/425


Remove data_path or input_dir in model train

It seems like in ilab model train, there are two arguments --data-path and --input-dir which seemingly do the same thing:
@click.option(
    "--data-path",
    type=click.Path(file_okay=True),
    help="Base directory where data is stored.",
    default=DEFAULT_DATASET_DIR,
)

@click.option(
    "--input-dir",
    type=click.Path(),
    show_default=True,  # TODO: set to None and change help message
    help="Path to generated files to use as input.",
)

We should remove one of these as they seem to complicate the logic for picking training data.

It seems to me it makes sense to keep --data-path over --input-dir - it's a clearer description and it is also pulling from DEFAULT_DATASET_DIR whereas --input-dir is not


Look through defer bodies in actor isolation checking

Fixes rdar://88200899

@swift-ci Please test

Build failed
Swift Test OS X Platform
Git Sha - 67ec6995fb7535ab8cee19084251aea059d1333e

@swift-ci Please test macOS


fix typo in api go mod path

fix typo in api go mod path

Pull Request Test Coverage Report for Build<PHONE_NUMBER>9
Details

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 68.301%

Totals

Change from base Build<PHONE_NUMBER>5:
0.0%

Covered Lines:
989

Relevant Lines:
1448

💛  - Coveralls


Overriding peer dependency @vue/runtime-core@"> 3"

Error: Overriding peer dependency @vue/runtime-core@"> 3"
Cannot install on newly created Vue-3 App created by Vue-cli
To Reproduce

From the Vue-cli (@vue/cli version 4.5.13) create a new application
Choose the following:
1. Vue version 3
2. Vuex
3.       C:\Users\ghass\AppData\Local\npm-cache_logs\2022-02-20T22_17_53_021Z-debug.log
My system
When I try to show the existing @vue/runtime-core, it gives me this
npm list @vue/runtime-core

<EMAIL_ADDRESS>C:\code\mycode\js\vue\myvue3
`--<EMAIL_ADDRESS>  `--<EMAIL_ADDRESS>    `--<EMAIL_ADDRESS>
Version of vue-chart-3
3.1.0
Version of Vue

[x] Vue 3

That's strange! I will look at it

Can you try 3.1.1 ? :)

Yes that worked
Thanks


x/tools/gopls: no diagnostics for invalid package name

What version of Go are you using (go version)?

$ go version
go version go1.14.4 darwin/amd64

Does this issue reproduce with the latest release?
Yup
What operating system and processor architecture are you using (go env)?
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/m/Library/Caches/go-build"
GOENV="/Users/m/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/m/Go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.14.1/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.14.1/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/m/Code/duo/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4f/tcxcr6_55v9bp38d8g4hjlf80000gn/T/go-build332848045=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

https://play.golang.org/p/f3j9wyeeVMO
What did you expect to see?
An error or something. I first noticed gofmt stopped working when I hit save, so I restarted the Go server and tried again. No luck. Eventually I figured out that maybe default was a reserved keyword in Go.
What did you see instead?
No indication of error, just gofmt not working.

Thanks for the report. I am able to reproduce this, and we'll look into it.

Looks like this is another case that could be handled by https://github.com/golang/go/issues/39986. I'll add a work-around in the meantime.


Use OS specific file separator when printing out devc messages

Dev mode prints out messages like below on Windows, which uses a mixture of \ and /. We should ensure these messages have the correct file separator at all times.
-v C:\Users\TREVORCrawford\Git\demo-devmode/target/liberty/wlp/usr/servers/defaultServer/bootstrap.properties:/config/bootstrap.properties

Also consider when local paths are Windows and container paths are Linux style. e.g. ...usr\servers\defaultServer\something\bootstrap.properties:/config/something/bootstrap.properties


GH-35941: [Dev][MATLAB] Add clang-format configuration to pre-commit

Rationale for this change
If we use formatter, we don't need to check style manually.
What changes are included in this PR?

Add clang-format configuration to pre-commit
This uses the same style as C++/Python/R uses

We can format by pre-commit run -a.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.

GitHub Issue: #35941

@kevingurney @sgilmore10 What do you think about this style?
If you don't like this style, which is the same style C++/Python/R use, we can use our style by creating matlab/.clang-format like c_glib/.clang-format does: https://github.com/apache/arrow/blob/main/c_glib/.clang-format

Thanks @kou! This is a nice improvement and looks really good!
One minor nitpick is that I feel factory.cc is easier to read and extend when Proxy registrations are on one line. If we could have clang-format ignore just factory.cc, that would be nice. However, if this isn't possible, then I am fine with this change.

One minor nitpick is that I feel factory.cc is easier to read and extend when Proxy registrations are on one line. If we could have clang-format ignore just factory.cc, that would be nice. However, if this isn't possible, then I am fine with this change.

We can disable a file entirely and partially. Which is preferred? https://github.com/apache/arrow/pull/40588/commits/53c6ae1b4152c55f79fcfd361a40f1685593c493 is the partially disabled approach. (We can control by clang-format off/clang-format on comments.)

The partially-disabled version looks great. Thanks for making this change!

+1 to Kevin's comment! Thanks for doing all this work Kou!

+1


RST-4673 Updating session timeout for logged in users

Jira
https://tools.hmcts.net/jira/browse/RST-4673

not relevant


Test protobuf failure

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protobuf) have been updated in this PR. Please review the changes.

this proved it was broken, fixing in https://github.com/bazelbuild/bazel-central-registry/pull/1809
users can keep using this version if they don't hit this issue, it depends on the codepaths they need


Error: 'option is undefined' on import

Getting this error on one character:

Consol output:
....
DDB Importer | DEBUG > Searching for Hit Points choices main.js:5203:29
DDB Importer | DEBUG > Searching for Sentinel choices main.js:5203:29
DDB Importer | DEBUG > Feature parse complete main.js:5203:29
DDB Importer | ERR > TypeError: option is undefined main.js:5224:29
DDB Importer | ERR > Error during parse: option is undefined main.js:5222:29
DDB Importer | ERR > JSON Fetch and Parse Error main.js:5224:29
DDB Importer | ERR > TypeError: option is undefined main.js:5224:29
DDB Importer | ERR > parseClasses/</</smallChosen<@https://<my_domain>/modules/ddb-importer/dist/main.js:11489:108 parseClasses/</<@https://<my_domain>/modules/ddb-importer/dist/main.js:11489:92 parseClasses/<@https://<my_domain>/modules/ddb-importer/dist/main.js:11487:7 parseClasses@https://<my_domain>/modules/ddb-importer/dist/main.js:11420:25 parseJson@https://<my_domain>/modules/ddb-importer/dist/main.js:15666:31 getCharacterData/</<@https://<my_domain>/modules/ddb-importer/dist/main.js:17219:38 promise callback*getCharacterData/<@https://<my_domain>/modules/ddb-importer/dist/main.js:17214:8 getCharacterData@https://<my_domain>/modules/ddb-importer/dist/main.js:17184:10 activateListeners/<@https://<my_domain>/modules/ddb-importer/dist/main.js:17629:39 dispatch@https://<my_domain>/scripts/jquery.min.js:2:43090 add/v.handle@https://<my_domain>/scripts/jquery.min.js:2:41074 main.js:5224:29
DDB Importer | ERR > TypeError: option is undefined main.js:5224:29
DDB Importer | ERR > parseClasses/</</smallChosen<@https://<my_domain>/modules/ddb-importer/dist/main.js:11489:108 parseClasses/</<@https://<my_domain>/modules/ddb-importer/dist/main.js:11489:92 parseClasses/<@https://<my_domain>/modules/ddb-importer/dist/main.js:11487:7 parseClasses@https://<my_domain>/modules/ddb-importer/dist/main.js:11420:25 parseJson@https://<my_domain>/modules/ddb-importer/dist/main.js:15666:31 getCharacterData/</<@https://<my_domain>/modules/ddb-importer/dist/main.js:17219:38 promise callback*getCharacterData/<@https://<my_domain>/modules/ddb-importer/dist/main.js:17214:8 getCharacterData@https://<my_domain>/modules/ddb-importer/dist/main.js:17184:10 activateListeners/<@https://<my_domain>/modules/ddb-importer/dist/main.js:17629:39 dispatch@https://<my_domain>/scripts/jquery.min.js:2:43090 add/v.handle@https://<my_domain>/scripts/jquery.min.js:2:41074

Can you confirm your own the latest version (or give the version number), a url for the character, and check that the character has all their options selected before importing.

Can you confirm your own the latest version (or give the version number), a url for the character, and check that the character has all their options selected before importing.

I am using the lates version 0.2.31, could you maybe specifiy what "options" are? I will send you a charakter link in Discord.

I am using the lates version 0.2.31, could you maybe specifiy what "options" are? I will send you a charakter link in Discord.

The issue was an unselected proficiency option!
Thanks for the help, its fixed now.

The issue was an unselected proficiency option!
Thanks for the help, its fixed now.


Glossary: Add headers to text boxes in "new entry" page

While it should be obvious which column is for the original and which is for the translated text, adding a title above those text boxes may be a good idea. Should be the same as on the actual Glossary index page. There it is now "Text" and "Translation".
Maybe those can be changed to "Original text" and e.g. "Polish translation", to make add another indicator in which Glossary we are.

Textareas have placeholders to indicate their purpose, is that not enough?

Indeed it is. I could've sworn that I didn't see those when going to that page... Closing then.


Fix ApplicationModuleDetectionStrategy's package name in reference documentation

Use correct ApplicationModuleDetectionStrategy package name. Reference - https://github.com/spring-projects-experimental/spring-modulith/blob/main/spring-modulith-integration-test/src/test/resources/META-INF/spring.factories

That's merged, thanks!


Next release

Are there any plans when you will publish the next release? I prefer to install the modules via npm which still has 1.0.3.

Bump.

Probably better to mention someone. @matthew-andrews @rowanbeentje ?

:+1:

friendly ping :smile:  @mattcg @matthew-andrews @triblondon @georgecrawford

There's not been any new features or breaking changes so this will be a patch version.
$ npm version patch
v1.0.4
$ g push --tags
Counting objects: 4, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 412 bytes | 0 bytes/s, done.
Total 4 (delta 2), reused 0 (delta 0)
To git@github.com:ftlabs/fastclick.git
 * [new tag]         v1.0.4 -> v1.0.4
$ g push
Total 0 (delta 0), reused 0 (delta 0)
To git@github.com:ftlabs/fastclick.git
   17135ad..c4060d4  master -> master
$ npm publish
+<EMAIL_ADDRESS>

Thx :+1:

Thanks @matthew-andrews!


Handle Service disappeared RPC error in run/attach outer layers

Rather than crashing the tool of course

For context, this is currently the top tool crasher on the release branch.


touch something

Type of change
Select the type of your PR

Bugfix
Enhancement / new feature
Refactoring
Documentation

Description
Please describe your pull request
Additional Context
Why are you making this pull request?

/perf

/perf

/perf

/perf

/perf

/perf

/perf

/perf


pysam: 0.15.3 -> 0.15.4

Motivation for this change
Version 0.15.4 fixes a couple of segfaults and cython compatibility issues.
See also: https://github.com/NixOS/nixpkgs/issues/79548
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[ ] NixOS
[ ] macOS
[x] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[x] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

@ofborg  build python37Packages.pysam

Somewhat surprising that this builds fine on my current system (not NixOS) but fails here.
Closing this for now. Discussion ongoing at #79548


chore: add memo and update to fix cosmos-sdk update #ntrn-433

https://p2pvalidator.atlassian.net/browse/NTRN-433

https://github.com/neutron-org/neutron-tests/actions/runs/4670335612


Merge changes from master to live to reflect doc fixes for find patterns

There are some bugs in the find patterns docs for 1.0 related to our removal of enums for targeting and replacing with just string values.  This PR fixes them.

:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

prosepy/docs-ref-conceptual/findpatterns.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


i cant access debuging features

when i power wash and click on debugging features it says there was a issue and debugging features wasn't finished setting up completely

@PlasmonPlayz,
There was a known crbug #890898 for this issue but it's been fixed and merged in R70-11021.B.
-DennisLfromGA


Updated kernel to 4.5 with Mali.R6P0 drivers

The updated Kernel enables the latest Mali drivers.
The Kernel recipes are cleaned up so it is
more alligned with the structure we have on the
Dragonboard.

also, please add signed-off-by tag in your commits.

Thanks for the review. I will update the patch as requested. I forgot to add the defconfig file..

FWIW, we agreed with the 96board folks to use the 4.4 kernel, does that also work with MALI? The goal is to use the same kernel (tree) for debian and OE.

It may be doable but there will be some backporting work on the DRM/KMS hikey drivers. With Weston/DRM/KMS we had some issues on earlier Kernels which where not affecting the X11 based builds: lack of vblank support in the DRM driver, problem with async page flip and lack of cursor implementation.

Issues resolved in 9470520

"Resolved reviewer comments" is not a proper commit message. Have a look at http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines

Do you prefer squashed and a generate a new pull request?

Either way is fine

Squashed.

"Updated kernel to 4.5 with Mali.R6P0 drivers" is also not a valid commit message, have a look at http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
And if you're touching a machine.conf, those change need to go into a seperate commit. Also, the tense to use is 'update', not 'updated' in OE commit messages. The wiki above should cover that.

Updated

The defconfig is the result of 'make savedefconfig', not a copy of .config. Can you update it?

Fine to have it 4.5 atm, we can then compare and see if we can also get it supported in the common 4.4 kernel later (since that would be a better target).


Document outline parameter of Font.draw_char()

Resolves #64256
See https://github.com/godotengine/godot/issues/64256#issuecomment-1212661513 for description.

Thanks, that makes sense!


Align 10.56

Features

add kind prop to ProgressBar to support inline, indented variants

Documentation

add ProgressBar examples "Inline variant" and "Indented variant"

Housekeeping

upgrade carbon-components to v10.56.0

Released in v0.63.0. If using carbon-preprocess-svelte, upgrade to version 0.9.0.


"Expected exactly 1 fields, but got 0"

Hello
I recently downloaded this editor and i tried to use it on a modded module but right after i select the savegame and the module.ini the following error pops up:
https://imgur.com/a/fx5fiKH
I was hoping to get a little help, thanks in advance

Can you share item_kinds1.txt for that module?

item_kinds1.txt

Sorry for the late response mate

I don't know it'll helped but i had the same problem with Perisno 1.20 and it worked when i restarted my pc.

So this is kind of a broken-by-design issue...
When I wrote the parser for those files, I mostly reverse-engineered it from the files themselves using Native module as a reference (and to some extent also by looking at https://github.com/Kushulain/MnBSaveGameEditor). They seemed like they have meaningful line breaks, with multiple lines per record, but of well-defined structure in terms of those breaks that clearly identifies the records. This is nice, because it means that the parser doesn't have to understand each record entirely - only the fields that the app needs. So that's how I coded it.
After carefully reading the process_*.py files in the Warband module system that generate those .txt files, turned out it's not actually the case. So far as I can tell, the .txt files are actually meant to be read scanf-style, with all whitespace treated largely the same; line breaks in the output are just making it more readable. The records themselves are, effectively, variable-length, and values of some fields specify how many other fields follow, or, sometimes, whether a field appears or not. Thus, to properly parse the file, the parser needs to read each record in its entirety, field by field.
Now, it just so happened that in Native, the ad-hoc scheme that I devised around using line breaks to parse records worked - largely by accident. On the other hand, in this module (and, presumably, any other that is affected), some slight difference made it so that a line break is inserted at one point where it never occurred in Native. And so, here we are.
Unfortunately I don't see any easy hack here that might make it work "good enough" with the current implementation. It just needs to be redone - LineReader needs to be replaced completely with a scanf-style field reader, and all the ...Definitions classes under /WarBender/Modules need to be rewritten on top of that. This is quite a lot of work, because the way those classes are implemented currently, they often skip over entire lines without even trying to parse them, when they expect to see no relevant data there - now they'll have to parse those, too. In some cases, they might be able to just skip a predetermined number of fields; but whenever there's any variable-length data there, it has to parse at least the length to skip the fields correctly after. Similarly, when there's a flag that affects whether another field is present or not, it must parse the flag before it can skip (or not) the field.
Basically, one has to strictly follow the logic in the corresponding process_*.py - for example, TroopDefinitions must follow process_troops.py.
This is one of those things that I will try to gradually fix when I have time to spare. But, given Bannerlord, maintaining https://github.com/int19h/csx is a priority for me, so it probably won't be done anytime soon. If someone wants to take a crack at it to fix it sooner, I will be happy to help them figure out the codebase and do a pull request.

So this is kind of a broken-by-design issue...
When I wrote the parser for those files, I mostly reverse-engineered it from the files themselves using Native module as a reference (and to some extent also by looking at https://github.com/Kushulain/MnBSaveGameEditor). They seemed like they have meaningful line breaks, with multiple lines per record, but of well-defined structure in terms of those breaks that clearly identifies the records. This is nice, because it means that the parser doesn't have to understand each record entirely - only the fields that the app needs. So that's how I coded it.
After carefully reading the process_*.py files in the Warband module system that generate those .txt files, turned out it's not actually the case. So far as I can tell, the .txt files are actually meant to be read scanf-style, with all whitespace treated largely the same; line breaks in the output are just making it more readable. The records themselves are, effectively, variable-length, and values of some fields specify how many other fields follow, or, sometimes, whether a field appears or not. Thus, to properly parse the file, the parser needs to read each record in its entirety, field by field.
Now, it just so happened that in Native, the ad-hoc scheme that I devised around using line breaks to parse records worked - largely by accident. On the other hand, in this module (and, presumably, any other that is affected), some slight difference made it so that a line break is inserted at one point where it never occurred in Native. And so, here we are.
Unfortunately I don't see any easy hack here that might make it work "good enough" with the current implementation. It just needs to be redone - LineReader needs to be replaced completely with a scanf-style field reader, and all the ...Definitions classes under /WarBender/Modules need to be rewritten on top of that. This is quite a lot of work, because the way those classes are implemented currently, they often skip over entire lines without even trying to parse them, when they expect to see no relevant data there - now they'll have to parse those, too. In some cases, they might be able to just skip a predetermined number of fields; but whenever there's any variable-length data there, it has to parse at least the length to skip the fields correctly after. Similarly, when there's a flag that affects whether another field is present or not, it must parse the flag before it can skip (or not) the field.
Basically, one has to strictly follow the logic in the corresponding process_*.py - for example, TroopDefinitions must follow process_troops.py.
This is one of those things that I will try to gradually fix when I have time to spare. But, given Bannerlord, maintaining https://github.com/int19h/csx is a priority for me, so it probably won't be done anytime soon. If someone wants to take a crack at it to fix it sooner, I will be happy to help them figure out the codebase and do a pull request.

Hi, is this issue still being worked on? I have the same issue with the Between Empires mod.

Not at the moment, no. I'll happily accept pull requests to fix this, though.


Tests refactoring

No new tests were added, only refactored existing ones.

Ok, so for some reason magul's comments have not shown up here

I'm still writting them @arturtamborski :/

@magul please do a review one last time for this because from what I saw all your comments were addressed pretty carefully. I think that this PR is ready to be merged (hence three approvals :smiley:)


Android 8 Channel Sounds

Expected Behaviour
Play a custom sound when a push notification is received.
Actual Behaviour
Default sound is played.
Platform and Version (eg. Android 5.0 or iOS 9.2.1)
Android 8.0.0
(Android) What device vendor (e.g. Samsung, HTC, Sony...)
Samung Galaxy S8 Edge
Cordova CLI version and cordova platform version
cordova --version                                    8.1.2<EMAIL_ADDRESS>cordova platform version android           android 7.1.4

Plugin version
cordova plugin version | grep phonegap-plugin-push   2.2.3

Sample Push Data Payload

{
"to": "TOKEN",
"priority": "high",
"data": {
"title": "Intruder Alert test",
"message": "Test 3",
"android_channel_id": "accesscontrolmessage",
"sound": "accesscontrolmessage"
}
}

Sample Code that illustrates the problem

this.push.createChannel({
id: 'accesscontrolmessage',
description: 'Access Control Message',
sound: 'accesscontrolmessage',
importance: 4,
vibration: true
})

Logs taken while reproducing problem

12-03 09:45:40.666 13172 13172 I SEMS:EasySignUp: [EnhancedAccountWrapper] =====addAccountPushListener=====
12-03 09:45:42.769  1774  5947 D Push_FCMService: onMessage - from:<PHONE_NUMBER>66
12-03 09:45:42.772  1774  5947 D Push_FCMService: sender id =<PHONE_NUMBER>66
12-03 09:45:42.774  1774  5947 D Push_FCMService: normalize extras
12-03 09:45:42.774  1774  5947 D Push_FCMService: key = android_channel_id
12-03 09:45:42.776  1774  5947 D Push_FCMService: replace key android_channel_id with android_channel_id
12-03 09:45:42.777  1774  5947 D Push_FCMService: key = sound
12-03 09:45:42.777  1774  5947 D Push_FCMService: replace key sound with sound
12-03 09:45:42.777  1774  5947 D Push_FCMService: key = title
12-03 09:45:42.777  1774  5947 D Push_FCMService: replace key title with title
12-03 09:45:42.782  1774  5947 D Push_FCMService: no locale found for key = title, error Value Intruder of type java.lang.String cannot be converted to JSONObject
12-03 09:45:42.782  1774  5947 D Push_FCMService: key = message
12-03 09:45:42.782  1774  5947 D Push_FCMService: replace key message with message
12-03 09:45:42.783  1774  5947 D Push_FCMService: no locale found for key = message, error Value Test of type java.lang.String cannot be converted to JSONObject
12-03 09:45:42.783  1774  5947 D Push_FCMService: background
12-03 09:45:42.783  1774  5947 D Push_FCMService: message =[Test 3]
12-03 09:45:42.784  1774  5947 D Push_FCMService: title =[Intruder Alert test]
12-03 09:45:42.784  1774  5947 D Push_FCMService: contentAvailable =[null]
12-03 09:45:42.784  1774  5947 D Push_FCMService: forceStart =[null]
12-03 09:45:42.784  1774  5947 D Push_FCMService: create notification
12-03 09:45:42.785  1774  5947 E Push_FCMService: Number format exception - Error parsing notId: s == null
12-03 09:45:42.807  1774  5947 D Push_FCMService: stored icon=null
12-03 09:45:42.807  1774  5947 D Push_FCMService: stored iconColor=null
12-03 09:45:42.808  1774  5947 D Push_FCMService: stored sound=true
12-03 09:45:42.808  1774  5947 D Push_FCMService: stored vibrate=true
12-03 09:45:42.808  1774  5947 D Push_FCMService: no icon resource found - using application icon
12-03 09:45:42.811  1774  5947 D Push_FCMService: android.resource://com.xxxxx.xxxxx/raw/accesscontrolmessage
12-03 09:45:42.817  1774  5947 D Push_FCMService: create actions: with in-line
12-03 09:45:47.182  1774  1774 D Push_DismissedHandler: PushDismissedHandler = Bundle[mParcelledData.dataSize=444]
12-03 09:45:47.182  1774  1774 D Push_DismissedHandler: not id = 0

Hi,
I've created a new channel on my app but cannot get the custom sound to play when receiving a notification. I have tried both .mp3 and .wav files with the same result.
To make sure that the sound file is installed correctly, I have also ran the app on an Android 7 device so that it doesn't use channels. The sound is played as expected.
I have also tried using Ionic Native's Push plugin as well as using this plugin directly. Same result with both methods.
Finally, I went into Settings > Apps > My App > Notifications on the Android device. I can see the channel I've created in there, but the sound is set to 'Default notification sound (On Time)'.

Try the following code snippet:
PushNotification.createChannel( 	function() { 		console.log('success'); 	}, 	function() { 		console.log('error'); 	}, { 		id: 'YOUR ID', 		description: 'YOUR DESCRIPTION', 		importance: 5, 		sound: 'YOUR SOUND', 		vibration: true 	} );
I've had the same issue, but I can't say for sure why this solution above works .... maybe someone could explain it.


Fix a bug where Server.stop/close() never finishes

Motivation:
The CompletableFuture returned by Server.stop/close() is completed
when all accepted connections are closed. To get notified when an
accepted connection is closed, it listens to the Netty ChannelPromise
returned by Channel.close().
In HTTP/2, the ChannelPromise returned by Channel.close() is
completed by GracefulConnectionShutdownHandler. However,
GracefulConnectionShutdownHandler can fail to complete the
ChannelPromise when the task scheduled by
GracefulConnectionShutdownHandler is cancelled before it completes the
ChannelPromise.
Modifications:

Ensure the ChannelPromise is always completed when a connection is
closed.

No need to pass around the promise anymore.

Miscellaneous:

Respect the return value of drainFuture.cancel().
Prefer try{Success,Failure} to set{Success,Failure} because
set{Success,Failure} can throw an exception.
Short-circuit when the connection is already closed.

Result:

Fixes #3746

/cc @alexc-db

Nice fix, thanks @trustin!


make screensize full

edit file src/constants.js
add following line
exports.DefaultOptions = {
puppeteer: {
headless: false,
defaultViewport: null
},
session: false,
authTimeout: 10000,
}

not all want full screen, since all time run with headless
and if you want full screen you can passing the option like this
const client = new wa({
    puppeteer: {
       headless: false,
       defaultViewport: null
    },
    authTimeout: 30000,
});


Complete integration with database

Add methods to save and load configurations. Add also a method to get all configuration by name in Manager

It should be done, but we have to test it more

No need anymore! We use json files


Update README.md

Fixed 2 typos

Hi, thanks for the PR! I need to wait for you to sign the CLA. Is that ok?

I think you need to tell @googlebot

Thanks again!


Add makemkv profile for controlling makemkv audio/subtitle selection

I am currently using parts of this in my own setup. I've implemented this in my own setup so I could customize the profile used by Makemkv to ensure HD audio is selected when ripping to non-compressed MKV rips. This needs to be thoroughly tested... The part that is untested is using variables to pass the config file path and the augmentation of the makemkvcon command using variables. I currently have this working in my setup strictly using the intended output without any configuration via variables.

Thanks for the PR @RandomNinjaAtk  I'll try to test it out later this week.

I've updated my own branch and currently testing the combination of both pull requests with a couple other minor changes to file moves to automate it further. I will submit a new pull request from my branch when its complete! I'm doing my final testing now :D


Changes for 0.3.2 release

Updates build and readme files only.
Due to some bugs and performance issue, I am going to publish a release.

Current coverage is 89.82%

Merging #87 into master will not affect coverage as of 7500a65

@@            master     #87   diff @@
======================================
  Files           14      14
  Stmts          629     629
  Branches        82      82
  Methods          0       0
======================================
  Hit            565     565
  Partial          0       0
  Missed          64      64

Review entire Coverage Diff as of 7500a65

Powered by Codecov. Updated on successful CI builds.


No Bitrate output for files listed under 'media library' in Volumio

Hi dhrone,
I have a slight issue, that I cannot figure out. I have configured my pages file to display what I need to and it works well apart from one minor issue. I can display the bitrates for spotify tracks (have to use 'samplerate' in the widgets for this one for some reason), web radio, and when playing files directly from my NAS via the 'Media Servers' link in volumio.
However, when I select music from the 'Music Library' link in volumio that I have mounted and has been scanned, the bitrate does not show on my display.  Both of these music sources are using the same canvas which is based on the conditions not db['stream']=='spotify' and not db['stream']=='webradio'" . For reference the tracks are the same and are from the same source just access by the two different links in volumio.  Looking at the status via the 'localhost/api/v1/getState' web page and using the volumio status command in the CLI terminal replicates the same issue in that the 'bitrate' attribute is not even listed for music played via the 'Media Library' link.
The only difference I can see is that the 'stream' output differs between the two methods. For music played from the 'Media Server' link, the 'stream' output is 'false', for music played via the 'Music Library' link, the 'stream' output is listed as the filetype, e.g. mp3 or flac.
I see that you had updated musicdata_volumio2.py in response to issue #92, which I assume was the inclusion of line 134, and I see that the pydpiper.py script references the script in line 125, which matches my pydpiper script and I have the musicdata_volumio2.py script in my sources folder.
Do you have any ideas what it might be? I have tried looking at the various scripts, but I have to be honest, I am lower than novice level when it comes to coding.
For info I am currently running volumio (v3.198) on my pi4 (2GB rev 1.5) and the latest branch of pydpiper (used 'sudo git clone https://github.com/dhrone/pydPiper' and then ran the install_docker and install_volumio scripts).
Apologies for the long post.
Thanks

Hi dhrone
Closing this as its a volumio issue.
For information, I managed to get it working briefly by editing the statemachine.js file in root/volumio/app; however, it must be causing an issue elsewhere as it caused volumio to stop working until I removed my edits.