Unable to load the plug-in correctly

As shown in the figure, it doesn't seem to work properly

me too

I recommend you follow the instruction in the one click installation section.
And only use the uxp installation method if you are a developer and want to modify the code.
Also, you will need Photoshop v24.0 or higher.

@annasophiachristianahahn it's a one-click installer. no other installations or modifications are necessary as long as you can run ccx file.
Read the following issue if you are unable to run the .ccx file https://github.com/AbdullahAlfaraj/Auto-Photoshop-StableDiffusion-Plugin/issues/119

When I click the ccx file with the latest version of photoshop + cc installed nothing happens- where can I find the zip for manual installation? When I put the ccx file manually in the plugins folder nothing happensOn Mar 7, 2023, at 11:47 AM, Abdullah Alfaraj @.***> wrote:
@annasophiachristianahahn it's a one-click installer. no other installations or modifications are necessary as long as you can run ccx file.
Read the following issue if you are unable to run the .ccx file #119
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

@annasophiachristianahahn I've updated the readme page for instruction on how to install using the Unzip method:
https://github.com/AbdullahAlfaraj/Auto-Photoshop-StableDiffusion-Plugin#method-2-the-unzip-method


broken im2bw in dev branch

run julia test/runtests.jl
gets

Warning: could not import Base.Text into Tk
foo test
setting true tests results
testing im2bw()
ERROR: test error during sum((reinterpret(Float32,float32(im2bw(img,trueThreshold))))[:]) == trueBWSum
Image not defined
 in im2bw at /home/yy/.julia/v0.3/MatlabCompat/src/MatlabCompat/imagetools.jl:118
 in anonymous at test.jl:62
 in do_test at test.jl:37
 in include at ./boot.jl:245
 in include_from_node1 at loading.jl:128
 in process_options at ./client.jl:285
 in _start at ./client.jl:354
while loading /home/yy/dev/julia/MatlabCompat.jl/test/runtests.jl, in expression starting on line 40

Fixed in https://github.com/MatlabCompat/MatlabCompat.jl/commit/bd98108749d1e5212f675eafa6b0b58c9e37286a
for both julia 0.3 and 0.4


Block producer compliance pass/fail

Aloha have been doing some great work on their bp research portal https://www.alohaeos.com/vote#validate I believe the majority of the community would like to see non compliant block producers made visible on voting portals.  Please show at least a simple compliance pass/fail next to each bp in the voting section.

Alohaeos scan the bp.json files for the information.  Nate D.  mentioned a json feed if you need it.   https://t.me/AlohaEOS/1449


Merge taskinfo and jobinfo under an interface

I'm hoping this is the only big refactor I will have to do for JobService in 2.2.
This is in preparation for a new type.
Some highlight files to look at:
grpc/job_master.proto:

JobInfo and TaskInfo have been merged into PlanInfo with type information to distinguish between the 2 types.
job/wire/PlanInfo.java:
This is the new interface. JobMasterClient (for client)'s getStatus will start returning these.
Note that as a result taskId is also a long. Later, this id may also become unique in the future to be referenced using the JobService. This will be especially when doing things like log capturing of a task.
ParentId is yet a thing for JobInfo but that'll change soon.

client/job/JobMasterClient.java:

Note that getStatus now returns PlanInfo though the current implementation only returns JobInfo (this will change soon)

main/java/alluxio/job/wire/JobInfo.java:

Now immutable object
Result is now bytes in proto object because it's Serializable in TaskInfo.java so it is deserialized.
In reality though, there is not a single job that returns anything but an empty list and you can see that toProto() has an isEmpty() shortcut as a result so nothing gets deserialized.

Nice to Have future refactors:
Make TaskInfo immutable object.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6657/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6658/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6659/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6660/
Test FAILed.

feedback addressed.

jenkins, test this please.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6670/
Test FAILed.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.19.1:test (default-test) on project alluxio-core-base: ExecutionException The forked VM terminated without properly saying goodbye. VM crash or System.exit called?
???

jenkins, test this please

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6674/
Test FAILed.

Looks like I broke something in the Job <-> Plan switch. Will check.

Fix.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6704/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6705/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6709/
Test FAILed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6710/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6711/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6714/
Test FAILed.

Tests in error:
alluxio.server.ft.journal.MultiMasterJournalTest.testCheckpointReplay(alluxio.server.ft.journal.MultiMasterJournalTest)
Run 1: MultiMasterJournalTest.before:53 » IO java.lang.RuntimeException: alluxio.exce...
Run 2: MultiMasterJournalTest.before:53 » IO java.lang.RuntimeException: alluxio.exce...
alluxio.server.ft.journal.MultiMasterJournalTest.testTtl(alluxio.server.ft.journal.MultiMasterJournalTest)
Run 1: MultiMasterJournalTest.before:53 » IO java.lang.RuntimeException: alluxio.exce...
Run 2: MultiMasterJournalTest.before:53 » IO java.lang.RuntimeException: alluxio.exce...
alluxio.server.ft.journal.MultiProcessCheckpointTest.test(alluxio.server.ft.journal.MultiProcessCheckpointTest)
Run 1: MultiProcessCheckpointTest.test:63 » Timeout Timed out waiting for all nodes r...
Run 2: MultiProcessCheckpointTest.test:63 » Timeout Timed out waiting for all nodes r...

jenkins, test this please.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6719/
Test FAILed.

Results :
Tests in error:
alluxio.client.fs.FileInStreamIntegrationTest.asyncCacheAfterSeek(alluxio.client.fs.FileInStreamIntegrationTest)
Run 1: FileInStreamIntegrationTest.asyncCacheAfterSeek » Runtime java.lang.RuntimeExc...
Run 2: FileInStreamIntegrationTest.asyncCacheAfterSeek:508 » TestTimedOut test timed ...
Sigh....

jenkins, test this please.

Everywhere that's using TaskInfo specifically should be fine. Where it's using PlanInfo is a little more questionable.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6725/
Test PASSed.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6726/
Test FAILed.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/Alluxio-Pull-Request-Builder/6727/
Test PASSed.


Load/Save - Take 2

Overview
Redo of #1861
Test Notes/Sample Code

Connected Issues

Closes #XXX

@jwildfire, @lauramaxwell - load/save has been removed from this branch so it's ready to review.

tests and checks are passing now! i think everything looks good, but i'll give it another look before merging.


typings: support Raw types for insert, where, update

Closes https://github.com/knex/knex/issues/3652

@kibertoad this can be merged, since this is not breaking change

@maximelkin Thanks for this PR. The changes look good :)
The only minor comment I have is on the naming: DbRecordSet -> DbRecordArr to convey that it is not actually a Set.

Set in name means not data structure, but some amount of items
And this is not always array

also, what do you think about renaming DbColumn to DbAttribute?

@lorefnon Is this good enough to be merged already?

Yeah, I think the current set of changes look good.
I don't have a preference around DbColumn vs DbAttribute.


Fix macos subprocess execution

This fixes the execution of subprocesses on macOS which could sometimes
prevent actions like SpawnNewProcess or custom commands from launching
their processes correctly.
This fixes #2259.

Right, of course it has already forked once.
Would it make sense to exit with a non-zero value when fork() fails? Or is that ignored by Command().
I'm thinking it would be nice to let the user know it failed...
On April 10, 2019 8:17:46 PM GMT+02:00, Christian Duerr<EMAIL_ADDRESS>wrote:

chrisduerr commented on this pull request.

     .before_exec(|| unsafe {

       #[allow(deprecated)]

       libc::daemon(1, 0);

       if ::libc::fork() != 0 {

           ::libc::_exit(0);

       }

This executes in the context of the new process, so it should never
lead to Alacritty quitting.
As far as I can tell, if fork() doesn't succeed it would just prevent
the subprocess from spawning.
I'm not sure exactly how std::process::Command works, but I'm
assuming it forks already. So what we do here is just a second fork to
get the double-fork child process zombie fix behavior.
If you don't trust me, it should be possible to test this by just
putting ::libc::_exit(0); in the before_exec closure. That should
just lead to no subprocess spawning, not to Alacritty quitting.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jwilm/alacritty/pull/2293#discussion_r274093881

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Unfortunately I'm not sure if there's any way to talk to the user after the process has been spawned. Since we explicitly redirect all stdin/stdout/stderr to /dev/null.
Exiting with a status of -1 would be possible, but I doubt it would actually help anyone. Since nobody's going to know either way.

It should be possible to propagate that back up to the main process.
Surely std::process::Command  is (or can be made to) wait():ing for the (first) child process? If so, the exit code should be available, somehow, allowing you to log, or write to stderr.

Don't know how difficult it is, but seeing that fork() rarely fails, maybe it's not worth it.
What would be nice though, is to detect and report exec() failures (maybe the user misspelled a command etc). But that is a bit difficult even in plain C. Doable, but not straight forward.
Sent from my Android device with K-9 Mail. Please excuse my brevity.

I've decided to report the last os error when setsid or fork fails. That should hopefully be good now. Thanks for the idea!

Nice!
Are you sure reporting setsid() works though? I would expect it to be as difficult as reporting exec() failure, since it is executing in the context of the double-forked child.
Unless I'm mistaken, std:: process:: Command will only see the result of it's direct child (i.e the explicit _exit()-calls). What happens in the grand-child shouldn't be visible in the main process.
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Are you sure reporting setsid() works though? I would expect it to be as difficult as reporting exec() failure, since it is executing in the context of the double-forked child.

That is correct and I do not expect it to report back to Alacritty. However it might prevent errors that are caused by just going on after the setsid call fails. This way it should explicitly bail when that is the case.

Ah! All good then! (y)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.


CPP-1001 Remove CentOS 7 as a tested platform

And also remove references to Ubuntu Bionic while we're in here.

Thanks @lukasz-antoniak.  I'm calling this good for now.


4.x: Fix timed delay hangs with dotCover and the DefaultScheduler

For some reason, dotCover would hang in various timed test which use the DefaultScheduler. I don't know why, but removing that empty try-catch along with the atomic dispose management solves the issue.
In addition, the Virtual_ThreadSafety() was running extremely slow in its original form (more than 5 minutes). The reduced time amount and a more close thread-synchronization should be faster now while preserving the behavior under test.

Do you know anything about the issue or bug here? Seems that the SpinWait would loop forever?

I don't know, I can't switch to debug while running with coverage enabled. Maybe there is a way to trigger a thread dump externally?

I could give it a try.

Do you know what process will eventually host our code? Everything I debug doesn't run anything form System.Reactive.

I can't reproduce the hanging tests under coverage. Virtual_ThreadSafety() running slow is understandable, it takes a lot of loops and AdvanceBy to actually trigger the virtual scheduler.

Were you running dotCover or microsoft's own coverage tool of VS Enterprise?

DotCover within VS

There could be a probabilistic signal loss from the timer.
You could try and add a loop around the body of Delay_TimeSpan_DefaultScheduler for example, usually 1.000 - 10.000 iterations.
        [Fact]
        public void Delay_TimeSpan_DefaultScheduler()
        {
            for (int i = 0;  i < 10000; i++)
                Assert.True(Observable.Return(1).Delay(TimeSpan.FromMilliseconds(1))
                   .ToEnumerable().SequenceEqual(new[] { 1 }));
        }

Can't really reproduce it but the fix is straightforward and the SpinWait-solution is wacky enough that this should be merged.


Use cacheable-response for ssr

Hello,
I have been using next.js for a while in a bunch of projects, so first for all thanks for all the vibrant effort around the project 🖤.
Always I see the server side next.js approach as an advantage, but also a weakness for the extra resources you need to have, specially comparing how cheap is a client side app.
In order to do my things cheaper, I started using the SSR pattern you suggested in your examples, so useful! It saves time and resources.
However, it was too simple. In a real production scenario, you need a bit more, specially related with send the right response headers to keep the rest of external network agent updated of your cache state.
I started a tiny script code for doing that; basically, I copy/paste it on my ssr projects.
Now, after a time, I think it's worth it publish it as cacheable-response module.
The PR is for adding the module leverage into the next.js ssr example.
It's doing the same, plus:

be possible use a multi storage cache (memory by default; mongodb, redis, mysql, supported).
sending cache-control response headers.
sending X-Cache-Expired-At, just a humanize way to see the expiration time.
support for forcing invalidation via force=true query parameter.

I hope you like it 🙂

Should the state-while-revalidate be configurable here: https://github.com/Kikobeats/cacheable-response/blob/master/index.js#L25

@timneutkens good catch!
I shipped<EMAIL_ADDRESS>that support it, also added etag response header.


Archiving issue

Projects using SRG Analytics cannot be properly archived.
Issue type
Incorrect behavior
Environment information

Library version: 7.0.2
iOS / tvOS version: Any
Device: -

Reproducibility
Always reproducible
Steps to reproduce

Add SRG Analytics to an app with SPM.
Attempt to archive the app.

The workaround can be quite surprising, as we test canImport(Combine) instead of the expected canImport(SwiftUI). But testing for SwiftUI import works, so we reused the same trick as for SRG Data Provider. This is safe as Combine and SwiftUI were introduced at the same time.
SRG Analytics will soon be iOS 12+ anyway and we'll likely be able to remove this workaround.


Not saving ckpt converted module in my google drive

Describe the bug
I did everything and I can use the moduoe.ckpt in google colab.
I can see the module.ckpt (converted for automatic1111) in the sks folder but only in folder directory on the left side of Colab. When I go to my google drive I can see all the folder but not the module.ckpt in the sks fokder. There is module.json file only.
When I try to download I receive an error after few minutes, I can't download it in my local pc.
I'm going crazy...
thank you
Reproduction
No response
Logs
No response
System Info
windows 11, colab

same issue as #27

same issue as #27

did you fixed ?

fixed ?

No, otherwise I would have closed it

you have to wait, try the day after, I've found it.


Thank you for this gem.

Not an issue. Just wanted to thank you, @chrismo, for creating this gem. I have been using a pre-commit hook for a while now, but this gem seems like a better option than:
git ls-files -m | xargs ls -1 2>/dev/null | xargs rubocop -x

Feel free to close this.

🎉 yay - thanks for the kind word!


Netlist optimization

This pull request adds a netlist optimization stage that allows to pack large designs. Requires the Yosys script to be integrated to operate correctly: https://github.com/QuickLogic-Corp/yosys-symbiflow-plugins/pull/4
The optimization is based on mapping of excessive cells that occupy C_FRAGs into F_FRAGs. In particular:

Mapping of LUT2 to a single mux2x0 whenever the LUT configuration allows it,
Mapping of LUT3 to a single mux2x0 when the lookup table resembles a single 2:1 MUX,
Splitting mux4x0 to 3x mux2x0 and if needed mapping LUT2 to mux4x0 prior to that.

The optimization is implemented as a TCL script run by Yosys. The script takes advantage of the custom get_count plugin to retrieve number of cells of particular type in the design. With that knowledge it is possible to determine whether mapping them to different ones would decrease the overall design size.

There is also an upcoming change to the Yosys synthesis flow that allows to infer wide muxes and do more optimizations.


Go to reference is not working for a relative import *

I have the following in my main module: file_1
#file_1.py
from ...scenarios import *
module_1.method_1()
Where I have a module called 'module_1' in the scenarios package which has a method defined 'method_1'
and I cannot seem to F12 in to any of these modules or methods.

Closing in favour of https://github.com/microsoft/python-language-server/issues/730


First line of metadata file should have column names

Done. Also, consistently output
metadata1.csv
metadata2.csv
metadata3.csv
and
native1.zip
native2.zip
native3.zip


Fix assets not loading correctly due to GitHub Pages URL bug

Why remove the per-post asset folders?

They're not removed; I restructured it so that each post has its own assets folder. This fixes the issue of URLs by allowing posts to use relative URLs. Also IMO it makes more sense for each post to have everything it needs in its own folder


Confidence Interval calculator

A calculator that calculates confidence interval when Sample size, Sample Mean and Standard Deviation is given.
I would like to add this tool

@sairish2001 Shall i work on this as the deadline for the same is over

@khareyash05 , I'm working on this. It's delayed due to some health issues. I'll raise the PR in the Evening


Make a video explaining absolutely all available features

Could you please make a video where you explain all the features that this plugin has ?
It could help all of us to understand how it works, whats is included and what is not.
This could also help PR contributors to consider all possible scenarios of a new feature, which will prevent potential bugs in the future
Specifically I see there is something in the code called "RebaseEditor" and "MergeEditor" but I can't find information about how they look or exactly what they do, I don't want to assume anything.
Thanks

First off, I love the enthusiasm. Thing is - if I made video's, they'd be crap. Not my thing. However, the good thing is that there are already TONS of videos on how to use Magit, and since we're basically a poor-man's version of that emacs package, it should translate almost perfectly.
I've also been chipping away at finishing the docs, so :h neogit should be a good place to check.
But RebaseEditor, MergeEditor, etc are internal abstractions, so... I wouldn't put them in a video. It's just the buffer-name for when we open up the editor during an interactive rebase, or while editing a merge message. Or the commit message, that's CommitEditor. All of them are basically wrappers around this nifty client-server thing we use to trick git into thinking it opened up the $EDITOR, when in fact it's just the same instance of neovim. The reason for different names, despite being the same thing, is... config, mostly. It's got a different filetype, so you can do different things to them.
I'm happy to answer any more questions, but I'm going to close this as it's not really an "issue" ;)


api: rename runTemplateRef to runTemplateName

Description of problem
tl;dr: inconsistency with core resources.
those who might already be used to looking at fields that have *Ref  might expect that runTemplateRef is namespace-scoped reference (i.e., one that allows name and namespace), like, pipelineRef in the case of a PipelineRun.
transitioning RunTemplate to ClusterRunTemplate we went from having runTemplateRef properly allowing you to specify name and namespace to just a name (as it's now cluster-wide), but didn't change the Ref there in the name of the field to indicate the lack of namespace (i.e., we didn't change to runTemplateName, which might not be very consistent).
Proposed solution
ps.: I'm not entirely sure if we even should do this or not (please let me know what you think!)
Given I want to point at a cluster-wide runtemplate
When I discover the `spec.runTemplateRef` field
Then I don't get confused about the possibility of having a namespace specified in that object

I believe that the way to go here is to mimic what, e.g, statefulsets do when it comes to pointing at a cluster-wide resource storageclass: use name (string field), like, storageClassName (i.e., we could go with runTemteName).
Example
kind: ClusterRunTemplate
metadata:
  name: foo

---

kind: Pipeline
spec:
 runTemplateName: foo

We should remove kind from TemplateReference
Agreed

At which point we'll need the namespace field and we'd have to change back to the current runTemplateRef
Let's defer until this is asked for.

Even if you only need the name field. I'd recommend using a LocalObjectReference-like struct. The key advantage is that it's more clearly a reference and it's much easier to introduce new fields as the api evolves in a backwards compatible way.

@scothis So are you advocating for keeping runTemplateRef (and just removing kind)?

Wont fix for 0.1.x as it introduces a breaking change to customers. At least one customer has a runTemplateRef.Kind.


FirstPaymentFailed event not triggered using EventSubscriber

I'm  using an Event Subscriber to trigger FirstPayment events. The success handler is triggered on success but the failed handler is not unfortunatly. What's wrong here? When should the FirstPaymentFailed event trigger?
<?php

namespace App\Listeners;

use Illuminate\Support\Facades\Log;
use Laravel\Cashier\Events\FirstPaymentPaid;
use Laravel\Cashier\Events\FirstPaymentFailed;

class FirstPaymentSubscriber
{
    /**
     * Handle first payment paid events.
     *
     * @param FirstPaymentPaid $event
     * @return void
     */
    public function handleFirstPaymentSuccess(FirstPaymentPaid $event)
    {
        Log::notice('first payment success');
    }

    /**
     * Handle first payment failed events.
     *
     * @param FirstPaymentFailed $event
     * @return void
     */
    public function handleFirstPaymentFailed(FirstPaymentFailed $event)
    {
        Log::alert('first payment failed');
    }

    /**
     * @param $events
     * @return void
     */
    public function subscribe($events)
    {
        $events->listen(
            FirstPaymentPaid::class,
            'App\Listeners\FirstPaymentSubscriber@handleFirstPaymentSuccess'
        );

        $events->listen(
            FirstPaymentFailed::class,
            'App\Listeners\FirstPaymentSubscriber@handleFirstPaymentFailed'
        );
    }
}

The event is triggered by the Cashier\Http\Controllers\FirstPaymentWebhookController. According to mollie, the webhook will be called when the payment fails and cannot be completed with a different method. Check this out: https://docs.mollie.com/payments/status-changes

Thanks for mentioning that, I've read it and I can't recreate the problem with Mollie. I've tried all the options the test payment screen gives me but in no case I can trigger the FirstPaymentFailed Event.
I was wondering if I did something wrong or if it's an issue the package has and needs to be fixed.

@jstam89 can you verify that Cashier\Http\Controllers\FirstPaymentWebhookController::handleWebhook() gets called?

Closing this for now, let me know if it should be reopened.


Change && to ??

Sometimes, && not return false but null. Example: https://github.com/mzaini30/app/blob/master/src/layout/base.astro#L27

What kind of changes does this PR include?

Minor content fixes (broken links, typos, etc.)
New or updated content
Translated content
Changes to the docs site code
Something else!

Description

Closes #
What does this PR change? Give us a brief description.
Did you change something visual? A before/after screenshot can be helpful.

Thanks for this @mzaini30! I think in this case we want to stick to the more common use of && as the example is showing usage with a boolean value but thanks for the suggestion nonetheless 🙌


Other Language Support

How can I install the other language support? It seems only support English. Thanks!

In my case, I simply add the " -v /usr/share/fonts:/usr/share/fonts" bind mount to docker run, as my command given below.
docker run -d   -e PULSE_SERVER=tcp:$PULSE_SERVER  --name=firefox     -p 5800:5800     -v /docker/appdata/firefox:/config:rw   -v /dev/shm:/dev/shm    --security-opt seccomp=unconfined -v /usr/share/fonts:/usr/share/fonts jlesage/firefox

Setting the ENABLE_CJK_FONT environment variable to 1 could also do the trick.

This is cool!

将ENABLE_CJK_FONT环境变量设置为1也可以解决问题。

Setting the ENABLE_CJK_FONT environment variable to 1 could also do the trick.

The ENABLE_CJK_FONT dosen't seems to work.

Can you provide more details ? The container's log should show that the fonts are installed.

In my case the environment variable will attempt to install the font but will fail because it can't reach the download location at that point in the container startup.  I am using this container within a QNAP NAS container station environment and I believe it doesn't bridge the network quick enough on container startup so it fails.
If I go into the container shell afterwards and run the /etc/cont-init.d/10-cjk-font.sh file manually, then it installs the font just fine.  It's annoying because every time I have to update the container image or re-create it I have to go in and do it again.
My current solution is I map the directory /usr/share/fonts/wenquanyi to a host location, restarted container, ran the 10-cjk-font.sh script to re-install (into the mapped host volume), and so it will persist.  When I re-create the container now, it will see the font already installed and everything works then.


fix:Failed to correctly judge whether the subnets of the two IP pools overlap each other

Signed-off-by: iiiceoo<EMAIL_ADDRESS>

rebase 下 main 解决下 pr check 问题


bug:  Hover styles not working on Firefox

1. What version of daisyUI are you using?
v3.9.2
2. Describe your issue
Hover style on buttons are not working, not even in the official documentation. I'm using 118.0.1 version of Firefox.
3. What browsers are you seeing the problem on?
Firefox
4. Reproduction URL
https://daisyui.com/components/button/

I see some errors related to CSP (Firefox 118.0.1)

@arondx Buttons with brand colors (primary, secondary, etc) have a hover style:
https://daisyui.com/components/button/#buttons-with-brand-colors
Active buttons won't change on hover because they are already in active style (see the color difference)
https://daisyui.com/components/button/#active-buttons
And state colors don't have a focus color (soon they will have. In version 4.0)
@leodip This is not related to the issue. And I think it's fixed now. I don't see these errors.

Hover styles on buttons with brand colors are not working.
I'm using Firefox 121.0 on Windows 10.
I also found that daisyui v2.52.0 works correctly, but v3.x and v4.x have this bug.
https://github.com/saadeghi/daisyui/assets/20185342/36705ef4-6106-49f7-908e-90fe95f94a7b


Feature request: Detect the GAP / slice automatically.

When wanting to do this within ProtonMail App (even harder then on the web), it's not possible to get the shape individually, the entire captcha is one image.
Because the shape is in the top-right corner, it should be relatively easy to obtain it, but my in-experience in the use of OpenCV is probably insufficient to solve this 'puzzle' :)
Any luck being able to provide just a single input image to solve the puzzle itself? Perhaps with an extra argument as to what shape to look for?
Obviously a suggestion to obtain the puzzle piece before processing is also welcome.

_, thresh_image = cv2.threshold(gray_image, 220, 255, cv2.THRESH_BINARY)

Another example:

@Ruud-cb  Hi!
Thank you for your question and for your interest.
All you need to do is to split the initial image into two parts (the slide and the background).
You can take a look at how to do it here.


Node module output only

Right now, the boilerplate at the top of the output looks like this:
(function(fn, deps, name) { function obj() { return {} } if (typeof exports !== 'undefined') fn(require, exports, module); else if (typeof define === 'function' && define.amd) define(['require', 'exports', 'module'].concat(deps), fn); else if (typeof self !== 'undefined' && name) fn(obj, name === '*' ? self : (self[name] = {}), {}); else fn(obj, {}, {}); })(function(require, exports, module) { 'use strict'; function __load(p, l) { module.__es6 = !l; var e = require(p); if (e && e.constructor !== Object) e.default = e; return e; }

Not sure if the AMD stuff is needed. could there be an option to assume that we want to compile ES6 modules down to commonJS modules?

The whole thing looks like:
    // CommonJS:
    "if (typeof exports !== 'undefined') " +
        "fn(require, exports, module); " +

    // AMD:
    "else if (typeof define === 'function' && define.amd) " +
        "define(['require', 'exports', 'module'].concat(deps), fn); " +

    // DOM global module:
    "else if (typeof self !== 'undefined' && name) " +
        "fn(obj, name === '*' ? self : (self[name] = {}), {}); " +

    // Hail Mary:
    "else " +
        "fn(obj, {}, {}); " +

I'm fine with taking out the AMD and the "Hail Mary" branches altogether.

Actually I was thinking that there should be an option to only use commonJS. the rationale is that I'd like to use browserify which assumes commonJS format and doesn't need all of the other branches.

Ah, cool.  Yeah, that seems like a good idea.

I'll need to modify the output to make it browserify-friendly.  Should be ready in the next couple of days.

:+1:

New module wrapper is better.  It does away with the AMD thing and only includes the wrapper if you've specified the "global" export name.  Otherwise, it's plain CJS.


Empty view message: links should have some kind of aria-label

It looks like the links in empty view messages do not have any form of aria-label that would assist a user that is using a screen reader from explaining what the link does. It should probably read something like "Open Reference: the reference..." e.g. for the references view.

Looks like this is already possible with providing a title to the links, closing.


fixed typo, revised invertibility conditions

Regarding the special case with DIVU that is invertible, but should not occur according to the assumption: target != current output value.
So far this case is handled as not invertible. This is just a suggestion to handle it as invertible.
Also added parenthesis in REMU.
Summery of invertible, not invertible:
DIVU Lhs:
s = 0, t = ones      => invertible, but should not happen as this means currently t = ones already
s = 0, t != ones     => not invertible
t = ones, s != {0,1}  => not invertible, overflow
DIVU Rhs:
t = s = 0             => invertible, but again should not happen
t = 0, s != ones      => invertible
t = 0, s = ones       => not invertible
t = ones, (s = ones)  => invertible
t = ones, (s != ones) => invertible
s < t                 => not invertible

I overlooked the case s == t => invertible in REMU the first time.


Validate RTW user config file

Description

Closes #3392.
FYI - Examples of how what he users output looks like for valid/invalid files here:  https://github.com/ESMValGroup/ESMValTool/issues/3392#issuecomment-2127014496

Before you get started

[X] ☝ Create an issue to discuss what you are going to do

Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.

[x] 🛠 This pull request has a descriptive title
[x] 🛠 Code is written according to the code quality guidelines
[x] 🛠 Documentation is available
[x] 🛠 Tests run successfully
[x] 🛠 Any changed dependencies have been added or removed correctly
[x] 🛠 All checks below this pull request were successful

To help with the number of pull requests:

🙏 We kindly ask you to review two other open pull requests in this repository

Wow - great stuff @chrisbillowsMO! Clearly written and a nice choice of tests.
I've tested on Jasmin and it runs cleanly.

Hi @alistairsellar - great! 😁 I'm so pleased you're pleased.  @ehogan didn't want to miss out on all the fun so I'll await her final feedback and merge once she bequeaths her seal.

As an aside, I've warmed to @ehogan's suggestion of an esmvaltool config validate command: #3392 (comment). But makes sense I think to merge this to RTW now, and then discuss moving the functions to Core for a new command.

Great! I was working with this in mind with a view to having a crack at the issue raised against it in ESMValCore:

https://github.com/ESMValGroup/ESMValCore/issues/2246

One point to consider: it may be a bigger job to implement this in core.
CFG/Configure() objects are specifically designed to throw an error on the first invalid value.  I had to write a workaround to collect multiple errors (i.e. to save the user multiple runs/failures).
I wrote it up a little here: https://github.com/ESMValGroup/ESMValTool/issues/3392#issuecomment-2124795203 but the tldr; for core we'd probably want a different, more holistic solution than what I've written. Indeed, it might mean re-shaping a lot of the validation code in ESMValCore - probably not ideal! A decorator might offer a solution but I need to fully understand the validation code first.  I'm hoping to continue exploring when/if time allows.
Also, you're probably already aware, but also to bear in mind are the broader changes afoot in the user config file arena:

https://github.com/ESMValGroup/ESMValCore/issues/2371


Guzzle version dependency - guzzle ~6.0

Currently this package is locked to guzzle version 5, do you have any thoughts concerning updating to guzzle v6?

Found this to be an error on my end, closing.


Support web components

@ixti For the next release, have you though about adding web component support? This is really the future of the web. Maybe this deserves its own issue, or maybe it's beyond the scope of this project. Either way I believe it's a very much needed solution.
Since this uses sprockets as a backend, maybe others have solved a similar problem with https://github.com/ahuth/emcee or https://github.com/alchapone/polymer-rails. Looks like this might even be a sprockets level plugin that can be supported directly: https://github.com/nevir/hackish-sprockets-htmlimports. There are a lot of options here it seems. Probably related to #139.
I don't know any easy way to add components into the asset pipeline with Jekyll or other static generators without using something separately and manually like Grunt or Gulp, etc. Even then, there is no obvious way to handle concatenation or asset name hashing.
It seems that Vulcanize is the official way to handle this process, so maybe the answer lies in hooking into that, or maybe we need a jekyll-vulcanize gem. If so, probably best to use as much of Vulcanize as possible rather then reinvent it.
Components are installed as bower packages as a collection of html, css, and js (I don't think they are distributed with any preprocessor languages yet). The real issue is you will have something like
<link rel="import" href="components/google-map/google-map.html">

That html file will be in bower_components and may reference additional js and css files via relative paths. The issue is there is no way to use Jekyll assets to tell Jekyll to add the html file and the associated assets into the _site build.
See the Polymer Project and an example web component: https://github.com/Polymer/paper-dialog/blob/master/paper-dialog.html

I'm wondering if this isn't already supported in Sprockets 3, when debugging the new jekyll-assets I noticed that there is something about bower and all that, I'll play with this over the weekend and see what I can find out.

Cool. It's all pretty new at this point. Polymer 1.0 was just announced at I/O this yeas (https://github.com/polymerelements/polymer-starter-kit) and other frameworks are starting to support web-components in various ways.
I think that ideally this would be handled by Sprockets and all one would need (after adding the elements to bower.json or in the Sprockets path) is something like
{% import components/google-map/google-map.html %}

The only issue with this sort of approach is that google-map.html will import other .html components using <link> and the expected result after processing with Sprockets might be a google-map.html file with the imports all inlined. The issue here is that once you start importing more then one component you have a lot of duplication as polymer, etc. will be inlined in each file.
An alternative might avoid inlining things and just process and move each nested resource independently. Thus you would expect to end up with many html, css, and js files all refercning each other. This is how the system works "in the wild". The issue here is 1) if you want like have features like  cache-busting hashed names, you need to make sure all the processed files get updated references and 2) you loose all the performance optimizations that come from concatenation and minimizing http requests.
I think these two issues is what https://github.com/polymer/vulcanize is meant to address.

After further research @razor-x we don't need to do anything special, it looks like we have support for this out of the box, you just need to add this to your .bowerrc
{
  "directory": "_assets/javascripts"
}

And boom, Sprockets will do the rest, that is what is implied here: http://crypt.codemancers.com/posts/2014-12-10-bower-with-rails/

@envygeeks I'm not sure we are talking about the same thing here. :smile: The components discussed in that post are just Bower managed dependencies (typcially installed to bower_components by default). Generally they could be any type of asset, not just JavaScript. I would actually recommend against using .bowerrc like that. Instead just add bower_components to the sources list,
assets:
  sources:
    - bower_components

For example, I've been doing this with jekyll-assets version 1.0.0 and before for a while now. You can then include assets from bower components normally
See for example:

bower.json
_config.yml
app.css.sass.erb

The web components I'm referring to are an upcoming standard (see https://en.wikipedia.org/wiki/Web_Components and https://developer.mozilla.org/en-US/docs/Web/Web_Components). Supporting them in an asset pipeline presents some interesting challenges, some of which I noted earlier. For example, take a look at one example on how ember-cli can load them: https://gist.github.com/dnegstad/eee660aa32efd906082c. The broccoli-vulcanize package is doing the heavy lifting there via https://github.com/polymer/vulcanize. That example is a little outdated, but the key elements are there. I was able to get it working recently with a few changes here.
Anyway, ideally, Sprockets or a Sprockets plugin would handle most of the work, and jekyll-assets would provide corresponding liquid tags and such for components. Alternatively, I could imagine having a pre-compile step handled by some node-based asset pipeline which would produce compiled assets consumable by Sprockets. But then one has to maintain a separate build system outside of Jekyll.

What exactly do you want out of Jekyll Assets, your argument jumps all over the place and is a goose chase, I'm not chasing the goose.  I want to know exactly and with clarity what you are banging on about.

Ok, first off, it was not my intent to aggravate you. Let me attempt to outline my last post to clarify what is going on here.

The reason you gave for closing this ticket is that web components are already supported. However, the post you linked to as an example of that actually shows Bower components are already supported. These are completely different things.

I illustrated this by giving an example on how I was already using Bower components. I then gave an example of what another assets pipeline does in order to support web components.

Since web components are so new, there is not an obvious way to handle them yet. Thus, this issue could serve as a discussion about how, and at what level, jekyll-assets should support them. (I then gave some ideas to that effect.)

If you do not want to support them, or want to close this ticket for a different reason, that is certainly your right. I just didn't want to see the issue closed with "this works," when it doesn't. That would be misleading to users and contributors.

Finally, regarding,

What exactly do you want out of Jekyll Assets

If you feel previous posts lacked such clarity, again I am mostly brainstorming ideas on what I've seen other people doing to support this new web standard in order to open a discussion on how jekyll-assets might choose to implement support for web components.

@razor-x I'm not aggravated, I just don't get what you want, it seems somebody else thought when I said "banging on" it was a bad thing but that just means "going on" or "talking about".  I just want clarity :cry:

Trust me, I do want to support your feature, I just want to know exactly what you want out of the feature so I can support it.  I deal with hundreds of tickets a day across multiple platforms so I generally don't like to click links and do research, so it would be great if you could provide examples and encapsulate everything you linked to for me to look at here.

@razor-x so I looked at the very first link, and I see what you are talking about.  Let me see what I can work out today based on the Polymer documentation, I actually had a client ask about that not to long ago and it just dawned on me they are using the same technology.
I'll start a web-components-wip and see and what I can work out to handle that kind of stuff.

Totally understandable. I will make another post summarizing the two examples I linked to with abbreviated code blocks that get the important ideas across without having to click the links. I figured this would be a longer-term feature as it may depend on Sprockets or Sprockets plugins to support it first.
As to a detailed explanation of what web components are: that's a bit beyond the scope of this thread. For anyone looking to learn more, there have been some excellent Google I/O talks every year on this and Polymer.

@razor-x if you have links to videos or audio I can listen to while working on other stuff, that kind of stuff I will for sure listen to and watch on my free time so feel free to link to any you have on hand so I can learn more about it.

@envygeeks I'll link a playlist in the next post. Here is the bower components stuff. I just noticed some of this was added to the README, but I'll post it anyway as I've already written it up.
Using Bower components with jekyll-assets
package.json
{
  "scripts": {
    "install": "bower install"
  },
  "private": true,
  "dependencies": {
    "bower": "^1.6.5"
  }
}

bower.json
{
  "name": "jekyll-site",
  "private": true,
  "dependencies": {
    "fastclick": "1.0.6",
    "normalize-css": "3.0.3"
  }
}

_config.yml
assets:
  sources:
    - bower_components

Run $ npm install. Then include normally, e.g.,
main.sass
//= require normalize-css/normalize.css

or use @import or in a template: {% stylesheet normalize-css/normalize.css  %}. Same sort of thing for javascript or image assets. The Bower components just become assets you can pull like any others.
Note that sometimes you only need to use the name of the component and Sprockets seems to use the main file specified by that components bower.json. The extension is also sometimes optional (if no name conflict), but this all varies by component.

Web component videos from I/O

Good intro: Google I/O 2014 - Polymer and Web Components change everything you know about Web development
How they built apps with Polymer: Google I/O 2015 - Polymer and modern web APIs: In production at Google scale

How an Ember.js project can use web components

Add webcomponentsjs and any web components, e.g., polymer elements, as Bower dependences.

Put all html imports in app/elements.html, e.g.,
<link rel="import" href="../bower_components/core-elements/core-elements.html">
<link rel="import" href="../bower_components/paper-elements/paper-elements.html">

Include webcomponentsjs and the vulcanized import in app/index.html
 <script src="vendor/webcomponentsjs/webcomponents.js"></script>
 <link rel="import" href="assets/vulcanized.html">

Add webcomponentsjs to the pipeline and create the vulcanized file from elements.html
(note you need to install the appropriate broccoli plugins for this)
webcomponents = new Funnel('bower_components/webcomponentsjs', {
  destDir: '/vendor/webcomponentsjs',
  include: ['webcomponents.js']
});

vulcanized = Vulcanize('app', {
  input: 'elements.html',
  output: 'assets/vulcanized.html',
  stripExcludes: false,
  stripComments: false,
  inlineScripts: false,
  inlineCss: true,
  implicitStrip: false,
  excludes: [/^data:/, /^http[s]?:/]
});

return app.toTree([
  webcomponents,
  vulcanized
]);

So you end up with webcomponentsjs.js loaded like any other js lib and a single html import, vulcanized.html, which is generated by Vulcanize (using the specified compile options) from all of the individual imports listed in elements.html.

Well, I know we probably won't handle it like ember though it seems like we don't need to, but we will probably be adding an {% component %} that will let you create a link with the import stuff with us handling the rest of the stuff.
I don't know exactly how it will work but we can never work like ember, that's just too tightly coupled, we will more than likely end up just giving you access to them, writing them for you and creating a helper for you to include them.
Does that seem okay?

I think the key is that web components really want to be Vulcanized, but it's definitely beyond the scope of jekyll-assets to do that. In the ember example, app/elements.html and vulcanized.html are both valid html imports, the main difference being one has been optimized and the other has not.
I believe that if {% component %} handled html imports similar to how the other tags handled js and css, that should be enough (at least for now). Since one is already using bower (a Node package), one can easily use Vulcanize to generate a vulcanized.html which could then be used like {% component vulcanized %}.
However, the big difference between an html import and a normal js or css asset is that an html import can reference other assets (js, css, img, fonts, etc.) using normal html tags. It can even (and will in more cases) import other html imports! It's :turtle: all the way down. This is where the challenge comes in.
Say you do {% component my-button %} which generates the asset assets/my-button/my-button-cachebust.html  but the my-button element expects my-button.png either via <img> or a css rule. Lets assume in my-button.html there is a line like
<img src="my-button.png">

Then how do we ensure that we create assets/my-button/my-button-cachebust.png and the line in my-button-cachebust.html gets updated to point to the right path?
Now, I know Vulcanize can be set to inline and dudupe a lot of this, maybe even to the extent that nothing is referenced externally, but for a general html import, this nested asset referencing will exist. You could just decide to copy each entire component directory over to _site/assets and not touch the references, but then the subassets loose out on all the nice things like cachebust and minification.
The main point is that however you decide to implement it, the 'nesting problem' has to be addressed somewhere.

That's going to be the hardest part, but you already pointed to a library that works with polymer and supports Sprockets (whether it supports Sprockets 3 I don't know) and I can chop that up and see how they do it, and it seems that Google's own programmers even chipped in some code so that might be a good place for me to see how they manage to handle all that (if they even do.)

One thing I might end up doing is just offloading it onto nodejs, I'm not afraid to make it a requirement of a feature if the feature demands it (we have a few of those already) and even if I do it doesn't matter because you'll already have it and expect it anyways so we can always work around this complex issue by handling it both inside and outside of Ruby and Sprockets to chop together easy support.  Ultimately I'll play around with multiple implementation on trials and see what works the cleanest for both our sustainability and your usability.

I'm just finishing up a new minimal Jekyll skeleton using this plugin, and I wanted to include the new version of modernizr which must be generated from a config file. The way I ended up including it gave me an idea for how to deal with web components.
Here is a minimal demo with a single button and no special arguments to vulcanize. Honestly, it's probably fastest to just look at the diff to see exactly what needs to be added for a typical project, but I'll summarize the required steps here. Adjust the paths where appropriate to match your project structure.

Add polymer and other web components as Bower requirements.

Add vulcanize to the npm devDependencies and do something like this in package.json:
"scripts": {
  "install": "npm run bower",
  "postinstall": "npm run vulcanize",
  "bower": "bower install",
  "vulcanize": "vulcanize src/_assets/elements/elements.html > src/_assets/elements/vulcanized.html"
}

Create src/_assets/elements/elements.html with imports like
<link rel="import" href="../bower_components/paper-button/paper-button.html">

Make sure src/_assets/elements is added to the Jekyll Assets sources. Add vulcanized.html to .gitignore.

Include this in your <head>:
{% javascript webcomponentsjs/webcomponents-lite %}
<link rel="import" href="{% asset_path vulcanized %}">


Update multiple ImageCore compat from 0.7 to 0.8

@timholy Hopefully this reduces the pain.. Replaces and expands https://github.com/JuliaRegistries/General/pull/389
All add-able to a blank slate package environment, except Caesar.jl due to https://github.com/JuliaLang/Pkg.jl/issues/1169
Ians-MacBook-Pro:.julia ian$ JULIA_DEPOT_PATH=/tmp/pkgs julia
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.1.0 (2019-01-21)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(v1.1) pkg> add ImageCore
... etc.
(v1.1) pkg> st
    Status `/private/tmp/pkgs/environments/v1.1/Project.toml`
  [a09fc81d] ImageCore v0.8.2
  [d8c32880] ImageInTerminal v0.4.0
  [bc367c6b] ImageMetadata v0.7.0
  [787d08f9] ImageMorphology v0.2.0
  [02fcd773] ImageTransformations v0.7.2
  [e94cdb99] MosaicViews v0.1.0
  [dca85d43] QuartzImageIO v0.6.0

Passing local tests on MacOS 10.14.4 (except for Caesar.jl which is untested due to above)

[x]   [a09fc81d] ImageCore v0.8.2
[x]   [d8c32880] ImageInTerminal v0.4.0
[x]   [bc367c6b] ImageMetadata v0.7.0
[x]   [787d08f9] ImageMorphology v0.2.0
[x]   [02fcd773] ImageTransformations v0.7.2
[x]   [e94cdb99] MosaicViews v0.1.0
[x]   [dca85d43] QuartzImageIO v0.6.0
[ ] Caesar -> Not tested due to above

Should we leave Caesar unchanged, given not tested?

Things worth noting..

Where there were multiple ImageCore compat bounds per package, I just edited the last
I didn't look for upper bounds <0.7

This is probably the right way to do it. In retrospect I was being silly by not just nuking the upper bounds as soon as the bottlenecks started becoming apparent.
Looks like this will need a rebase.

Ok. I've rebased. Apologies, I shouldn't have brought the ImageMorphology changes in here without closing the other PR

Thanks for doing this!

Can you rebase on the master branch @ianshmean?

Hi @ianshmean , I just noticed this thread now (I'm a maintainer of Caesar.jl) -- is this issue still a problem?  I'm a little worried if you are indeed seeing the p0 != p1 assertion error?  Issue #1169 was resolved 2 days after your initial post in #455 so the issue should already be resolved.

The p0 != p1 assertion issue was related to bad compat in IncrementalInference.jl tomls, which is a dependency used by Caesar.jl.

A new version of Caesar (v0.3.1) was tagged yesterday but it's compat only goes up to ImageCore = "0.7".  I just tried to install ImageCore with regular package add and it seems to work fine:
(testimagecorecaesar) pkg> status
    Status `~/.julia/environments/testimagecorecaesar/Project.toml`
  [62eebf14] Caesar v0.3.0
  [a09fc81d] ImageCore v0.8.2

ASIDE: Tests are running for new Caesar.jl with ImageCore 0.8 compat, if interested JuliaRobotics/Caesar.jl#326


Survey on Pull Request Prioritization

Dear Pull Requests integrators,
We are an international group of researchers investigating Pull Requests management activities. We implemented an automated approach, named CARTESIAN, for prioritizing Pull Requests (PRs) received by an open-source project according to the likelihood of acceptance/response. We would like to evaluate whether CARTESIAN can help integrators when reviewing PRs.
As we noticed that your project receives many PRs daily, we have taken the liberty of contacting you. Thus, we experimented CARTESIAN on Your projects, to help you in prioritizing PRs. To know more about these results, please fill in the form below.
Survey form link: https://forms.gle/bGkj3nRH9i6ArjUx8
Your participation is voluntary and confidential. We kindly request you, ONLY to INTEGRATORS, to participate in this study which is expected to take about 15 minutes of your time. You might withdraw at any time.
Best regards,
Muhammad Ilyas Azeem, National Engineering Research Center of Fundamental Software, Chinese Academy of Sciences, China
Andrea Di Sorbo, University of Sannio, Italy
Sebastiano Panichella, Zurich University of Applied Science, Switzerland
Alexander Serebrenik, Eindhoven University of Technology, The Netherlands

Thank you for note. We generally respond to all PRs (except obviously fraudulent ones) so I am not sure we'd deliver meaningful input data. TensorFlow is also too large to deal with for a single person, so we have a hierarchical triage process that identifies the best person to decide on any specific PR.
Consequently, I could not properly fill out your survey, and I don't know that anyone else can.
I will close this issue. This is fantastic research!


[1.20.1] Can't create singleplayer world

Mod Name
Sinytra Connector
Mod Homepage
https://www.curseforge.com/minecraft/mc-mods/sinytra-connector
Minecraft version
1.20.1 (LTS)
Describe the bug
I can't create a singleplayer world
Steps to reproduce

I go on minecraft menu (everything working fine)
I click singleplayer
It says creating world
Then it says saving world and closes minecraft

Logs
https://pastebin.com/b3XbQWp0
Additional context
I downloaded the BetterMC modpack from curseforge and haven't changed anything from it

Report crash to LunaPixelStudio discord server instead

okay


mTLS support in ApiGatewayV2Api construct

Following up on a conversation (in https://github.com/sst/sst/issues/3616) with @jayair regarding having an mTLS option for the ApiGatewayV2Api. I started the conversation under SST v2, whereas it should be managed here for Ion.
So: It would be good to have mTLS support in ApiGatewayV2Api (https://sst.dev/docs/component/aws/apigatewayv2).
There's an optional mtls property on aws-cdk-lib/aws_apigatewayv2/DomainName: - see https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_apigatewayv2.DomainName.html
This allows the provision an S3 bucket reference and key (plus optional S3 version) to the PEM-encoded public key file used to validate client certificates.

Interested in having this too. In the meantime - is there a suggested workaround to use SST v3 to enable mTLS for  ApiGatewayV2?

@danielsharvey  this is the closest I've gotten so far. @jayair  @thdxr  - curious if there's other "hooks" we can tap into to help setup mTLS.
    const bucket = new sst.aws.Bucket("mtls-truststore", {
      versioning: true
    });

    const api = new sst.aws.ApiGatewayV2("ApiV2", {
      link: [bucket],
      domain: {
        name: "my-test.domain.com"
      },
      transform: {
        domainName: {
          mutualTlsAuthentication: {
            truststoreUri: `s3://<generated-bucket-name>/truststore.pem`, // this doesn't work: `s3://${bucket.name}/truststore.pem`
            truststoreVersion: "<version ID>",
          }
        }
      }
    });

I was able to make this work by running 2 deploys - one to create the bucket and a 2nd to setup the domainName config, which I found in Pulumi Docs.

Create the bucket
Upload the truststore.pem file
Configure the api gateway with the mutualTlsAuthentication transform.

This article helped me a bit with creating the truststore.


[Feature request] VNDB Official Links and Release Dates - Add digital shop links and platform icon list

Currently the only links included are ones that marked as "Official website". But to find a Steam link for example, you have to search closely through the releases. I recently discovered a nice script that adds VNDB links to Steam, but nothing to do the reverse yet.
I think it could be very useful to add a Digital Shops section to the main infobox, with existing links to digital downloads like Steam, Nintendo, PlayStation Store, App Store, Google Play (a full list of store names is available in the edit form of any release).
This way we can know at a glance whether we can purchase the title digitally for our preferred platform. It could be similar to the existing Shops section with PlayAsia etc, but in format "Edition name @ Store name (demo/trial indicator)". Icons (store website favicons like https://www.google.com/s2/favicons?sz=12&domain=steampowered.com) could be added too. And you'll have to differ demos from free games (maybe a word check by Demo/Trial), and only process the release rows that contain the Internet download icon.
Not sure if necessary, but prices could be added for Steam platform using this public API. Don't know about other platforms.
It would also be useful to add SteamDB links (usually found next to the Steam links) to the main Links list (the one which usually includes VNStat, IGDB, HowLongToBeat, etc).
And another idea - you could collect unique platform icons from the release rows, and add them as a new Platforms section to the main infobox. And there could be an indication (red border?) for titles with future/TBA release dates, when the port is not out yet.
Also, thank you for the userscripts!

Added the other links in kind of a messy way for now, will probably think about making them look less dumb later. Probably will work on platform release dates first, if I do.

Thanks a lot! I tested it a bit, it is a good start.
A few thoughts:
You can collect visible links from Shops section of the main infobox (PlayAsia etc) to an array, and then exclude them from the Other Links, so there won't be any duplicates.
You can check if any languages in release tables are collapsed by default, which means user configured to hide them, and they could be put at the bottom of the Other Links list, or even skipped over completely. I think the same probably can be applied to the Official links, maybe even adding a collapse arrow too.
You can get full list of supported links here https://api.vndb.org/kana/schema - under extlinks, but looks like they can often change. Sadly there are no indicators for a global platform store vs publisher store, so if you want to give platform stores a priority, manual list will need to be constructed from those. Adding favicons of platform stores will also help with visibility of specific links.
As for the platforms, I meant a simple separate platforms listing, like a row of platform icons, added above the whole Release dates block. Adding platforms for release dates is a more complex task, but this could be even more useful in the future.

Added favicons for all links and skipped over collapsed languages, open to changing how the favicons look as it could be a bit messy (I know they're broken for sites that don't have a /favicon.ico, not going to bother for now). I figure it's enough to be able to easily narrow down the link you want.
For platforms listing, I added them by language. Unofficial patches can expand platform support so I included those, but unofficial ones will be greyscale and have that specified in the mouseover.

Thanks. It's already much easier to find specific links, but I have some ideas for the future to make it look more neat - you could group (and even collapse) multiple links by the same edition name (links with no special edition specified could go first), and maybe even remove the game title from the edition names at all to reduce the clutter (but it looks like that might require checking for all possible titles from Titles and Aliases block).
Looks like some language flags are shrinking for Other Links, flex-shrink: 0; style could be added to the abbr elements.
For the broken favicons a quick fix would be making alt="" (and also flex-shrink: 0; so it would be aligned to the rest), and later some default icon could be added via onerror or something.

For platforms listing, I added them by language. Unofficial patches can expand platform support so I included those, but unofficial ones will be grayscale and have that specified in the mouseover.

Thanks, grayscale is a nice touch. Looks like the platforms are currently skipped for TBA and incomplete releases? Adding some whitespace and "Upcoming:" text or some in-progress icon (like ⏳ or 🚧) with platforms listed after it could indicate upcoming support (currently some language rows in platforms are displayed while being empty cause all releases there incomplete or TBA).

Thanks for the all the feedback!

you could group (and even collapse) multiple links by the same edition name

That could make sense on pages where there are a ton of links, but I think for most vns there will be fewer than five other links. The code is bad enough right now that I'd want to rewrite the script first before trying that😂

remove the game title from the edition names

Great idea! I'll definitely do this when I can.

Looks like some language flags are shrinking
For the broken favicons

Didn't catch the shrinking issue, thanks for the CSS advice.

Looks like the platforms are currently skipped for TBA and incomplete releases?

Yep

Adding some whitespace and "Upcoming:" text or some in-progress icon (like ⏳ or 🚧) with platforms listed after it

Good idea, I'll probably try to implement these things to show the status of TBA releases soon. Then price fetching after that.

Did all of those things and added price fetching for a few stores, let me know if you have any feedback!

Thank you! I'll try to test more in the future, but for now a few things I noticed:

If the same store link appears in multiple languages, it has only the first language listed in the Other Links (i.e. https://vndb.org/v2002 - Steam version exists in the English section, but only Japanese flag appears).

Looks like $ is always added to the Steam prices? Steam API returns currencies based on location and account, which currently can lead to prices like $2000 displayed for some users. Using price_overview.final_formatted (that includes the currency) should fix that.
A bit of info - it is still possible to force-fetch US prices, when specifically needed, by adding &cc=us to URL and anonymous: true to the GM_xmlhttpRequest (to avoid fallback to the account region)  - I did that when I needed to compare regional vs US prices.

Not all info icons inside the links are obvious to me (like the red X), having a text tooltip would be appreciated.

I use Tampermonkey and since there are a lot of websites the script requests, the extension asks to allow to connect to every site for the first time (not sure how Violentmonkey etc behave). This can be avoided by listing known domains in the @connect https://www.tampermonkey.net/documentation.php#meta:connect
Domains can be taken from https://api.vndb.org/kana/schema extlinks, but then you should also add @connect * to cover any future links that might be added to the vndb (otherwise non-listed domains are blocked without a prompt). With all known domains and * in @connect, new users would be asked only one time total (with an option to Always allow all domains). But in the future it's better to update the @connect domains from time to time, in case some users did not opt in to allow non-listed domains.

I also noticed you've added some settings, and got another idea - could you possibly add a domain multiselect there? You can fetch up-to-date domain list from schema.extlinks, and ignore domains that the user unchecked there. By the way, thanks for an example of how to do script settings with UI, I don't often see that done in scripts. I'm just learning and I needed that for some of my scripts but wasn't even sure where to begin.

Thank you so much, you did a pretty good job!

If the same store link appears in multiple languages
I coded myself into a corner with bad code, I'll rewrite it and support multiple flags probably next week when exams are over 😅

Looks like $ is always added to the Steam prices?
Yeah, hardcoded that. Changed it and made it return the final_formatted value, but added the price in USD as well next to it if the currency isn't USD. Couldn't test it though since it seems the API blocks VPNs.

Not all info icons inside the links are obvious to me (like the red X), having a text tooltip would be appreciated.

Good point, added tooltips.

listing known domains in the @connect
I tried adding them manually but gave up and just added @connect * so you can whitelist all domains.

domain multiselect
Good idea, will probably maybe do it after I rewrite. #8

thanks for an example of how to do script settings with UI
Glad it helped! I just used the GM_config library, lol.


No preview on upload

In Silverstripe 4.4.4 when you upload a file, it does not show the preview of the file unless you publish the file.
It puts the image in protected and returns a 403 forbidden error when it should let you see the file preview so you know what file you are editing.

it says this on the preview box:
The request signature we calculated does not match the signature you provided. Check your key and signing method.
But on the focus point it shows.

This appears to only be happening in the Asset Admin - https://github.com/silverstripe/silverstripe-asset-admin
So not sure what would be causing this as if you try it on say an UploadField on a page or object it works just fine.  Will see what we can find out though but guessing it is some post processing or thumbnail generation issue with asset admin

Okay so I think I know what the issue is, as to how to fix it not sure.  It is definitely related to the components of asset admin/ cms admin and the form fields (react rendering) which is causing the issue.
When looking at our code - we simply use the S3 client to generate the url.  This is then returning  the following in the graphql -

Example url returned - is a signed url
In the cms on the preview, and image tags you will see that it is appending ?vid={theversion} on to the end of the signed url.  That appended text is then breaking the link.  If you remove that from the ?vid=... from the end of the signed url via dev tools you will see that the image loads just fine.  Due to this being more of an issue with the react components and not this we will need to open a new issue in the appropriate repos.  Will see if I can track those down and open an issue there.

@jamieduck - a workaround that you can implement till the issue with asset-admin is resolved -

Create a JS file with the following code and place it in your public folder - this is a simple mutation observer that looks for images and thumbnail previews being added to the dom as well as looking for any on initial load and removes the ?vid=X for the image url.
 (function(window) {
     var listeners = [],
     doc = window.document,
     MutationObserver = window.MutationObserver || window.WebKitMutationObserver,
     observer;

     function domready(selector, fn) {
         // Store the selector and callback to be monitored
         listeners.push({
             selector: selector,
             fn: fn
         });
         if (!observer) {
             // Watch for changes in the document
             observer = new MutationObserver(check);
             observer.observe(doc.documentElement, {
                 childList: true,
                 subtree: true
             });
         }
         // Check if the element is currently in the DOM
         check();
     }

     function check() {
         // Check the DOM for elements matching a stored selector
         for (var i = 0, len = listeners.length, listener, elements; i < len; i++) {
             listener = listeners[i];
             // Query for elements matching the specified selector
             elements = doc.querySelectorAll(listener.selector);
             for (var j = 0, jLen = elements.length, element; j < jLen; j++) {
                 element = elements[j];
                 // Make sure the callback isn't invoked with the
                 // same element more than once
                 if (!element.ready) {
                     element.ready = true;
                     // Invoke the callback with the element
                     listener.fn.call(element, element);
                 }
             }
         }
     }

     var regex = /(\?vid=[0-9]+)/g;

     //checkForAWS and vid
     function checkForAWS(el){
         if(el.src && el.src.indexOf('AWS4') !== false){
             el.src = el.src.replace(regex, '');
         } else if(el.style && el.style.backgroundImage && el.style.backgroundImage.indexOf('AWS') !== false){
             el.style.backgroundImage = el.style.backgroundImage.replace(regex, '');
         }
     }
     domready('img', function(el) {
         checkForAWS(el);
     });

     domready('.gallery-item__thumbnail', function(el) {
         checkForAWS(el);
     });

     var images = document.querySelectorAll('img');
     for(var i = 0; i < images.length; i++){
         checkForAWS(images[i]);
     }

     var thumbnails = document.querySelectorAll('.gallery-item__thumbnail');
     for(var i = 0; i < thumbnails.length; i++){
         checkForAWS(thumbnails[i]);
     }
 })(window);

Once that is saved into your public folder (example /public/awsimagecheck.js) you then just need to have LeftAndMain include this new custom js - add the following to your projects YML config -
 SilverStripe\Admin\LeftAndMain:
 extra_requirements_javascript:
 	- awsimagecheck.js

Hopefully this can help in the mean time.

@obj63mc
Thank you so much this has helped a lot. Thanks

Related to #39 however in that issue the opposite is occurring when usings SilverStripe API to add the file.
The image/thumbnail is visible while unpublished/protected but not visible when published/public.

This should be resolved now with the latest updates to #43

just a minor change to the regex:
var regex = /((\&|\?)vid=[0-9]+)/g;
Now you can have the preview on the asset detail sidebar when you select a file.


Pressure Pen (e.g. Wacom) API

Hi, I've been monitoring this project for a while but have yet to do anything with it.  Though, I've been working on a drawing app, currently made in C# and GtkSharp, and I'm kinda tempted to change the UI framework over to Avalonia.
A key thing about any drawing app is that you should be able to work with a pressure sensitive pen, such as a Wacom device.  In GtkSharp, I have been able to leverage some of the Gdk APIs (https://developer.gnome.org/gdk3/stable/GdkDeviceManager.html) to get info from my laptop's built in stylus.
I'm wondering if Avalonia has any pre-existing APIs for this, or not.  It would be a really handy feature.  If not, is it possible for an app developer like me to write some native extensions in Avalonia, and create my own API for this?

It's planned to be implemented as a part of PointerPointProperties, just like in UWP. The general intent is to completely mirror UWPs PointerPointProperties.
Unfortunately we have no Wacom hardware, that's the main reason why it's not implemented yet.
In case of X11 we are currently using XInput2, so the relevant info should come along with XI_TouchBegin/XI_TouchUpdate events somewhere in XIDeviceEvent struct which is parsed here. Most likely it's in some of the Valuators. It would be nice if you've started xinput test-xi2 and done some stuff with your tablet, so we could figure out how it looks like.
On Windows we are using WM_TOUCH with GetTouchInputInfo. I don't know how to pressure data from there. There are cxContact and cyContact fields, but I'm not sure if those are relevant. We might need to use some extra APIs to get required info.
No idea how that would work on OSX.

Apparently Win8 has introduced the new pointer input API. We should probably use it when available and just leave Win7 without Wacom support since it has reached the end of life anyway.

OSX Wacom documentation
https://developer-docs.wacom.com/display/DevDocs/macOS+Developer's+Guide+to+the+Wacom+Tablet

Apparently pressure could be extracted directly from NSEvent

For the X11 stuff:
I can run that command and get some info for you.  Check back later tomorrow
Win:
There's also the Ink API, but I think that's for explicit tablet only PCs.  I'm not sure how it would work if someone plugged in a USB tablet and tried to use it.
OS X:
I think it might be best to steer away from any Wacom specific APIs, as there are now more drawing tablet makers (e.g. Huion, XP Pen, etc.).  Apple also has the PencilKit API, but AFAICT, I think that's only for their pencil device (though this may be useful for the iOS support).
As for hardware, I do have about three things:

My laptop (Lenovo X1 Carbon Yoga) w/ built-in stylus (runs Windows & Linux)
A "Bamboo Ink" pen (which works very nicely on the above).
One of those tiner sub-$100 intuos tablets you plug in via USB.

I will to test anything that you need me to.

Newest Windows API reference: https://docs.microsoft.com/en-us/windows/win32/api/_inputmsg/

x-input-pen.txt
With that, I ran the command (used tee to grab output).  I did 3 figure eights with the pen, the moved (with the trackpad) to close the window.
If I wanted to start working on this module myself (at least for linux), what would I need to do to get started?

If I wanted to start working on this module myself (at least for linux), what would I need to do to get started?

You need to get lists of pressure and tilt valuators there. It can be done by comparing XIValuatorClassInfo.Label with the value returned by XInternAtom for the corresponding valuator name  (Abs Pressure, Abs Tilt X and Abs Tilt Y, note that XInternAtom involves a roundtrip to the display server, so call it only once in XI2Manager constructor). Once you have valuator ids, you need to update OnDeviceEvent. The current code updates cached valuator values with _pointerDevice.UpdateValuators(ev.Valuators); only at the end of the handler, so you probably need an additional to call that method in XI_Motion branch after getting scroll delta, so you can read all of the values from the cache.
Then RawPointerEventArgs have to be changed to accommodate extra pressure and tilt info. Then pass those to PointerPointProperties.

Is there any update for this?

@haruby511 nobody working on this feature right now.
If someone wants to contribute, we will be happy to help with details (most of them were discussed already in this thread).


No training scripts and event models as well as inference scripts !

Hello,
I was going through the repo, I checked the examples. The demo and work surprised me. HPE on event data of this level is really astonishing with high accuracy. I wanted to replicate the work. Are those movenet examples of the examples for the move event net. Also, there isn't any training script as well as model and any discription about the data formats. Also it would be great if there was an example to inference your model on a single data instance.
Can you please update this?
Regards
Amit

Hi @amitpant7 ! Thanks for your interest. I'll ask @gaurvigoyal to give you some more information!

Hey Amit! Thanks for your interest. They are in the example folder movenet (here). There are instructions and a docker for the environment as well. We also provide all of our own models discussed in the ablation study, to support replication.
But I saw that it's a bit stale, since we published it over a year ago. So, I'm checking things, and adding a python-only inference. I'll link the pull request here.

Thanks for the update. I will check the examples.

Hey @amitpant7 , we've merged the pull request (link) with one more option for inference and better instructions.
We'd like to ensure others can also reach the right folder for this in the future, so I've tried to clarify this in the first Readme.md on this page. Would you mind having a look and telling me if it's clear?

Thanks, the inference is now easy to follow but I couldn't find any scripts to train or refine the networks .

Hey @amitpant7,
The code here is only for inference. There is a separate repository with the training code. It's not as clean and as of now the instructions are outdated. If you think access to the training code would benefit your work, we can update that repository and link it to this one.
Let us know!

Hello @gaurvigoyal
Thank you for the update! I’d be happy to go through the training script. Additionally, if there are any specific documents outlining the training methods and processes used, I’d greatly appreciate the opportunity to go through those as well.
Looking forward to your response!


Feature/csi 1165 iscsi login svc

Add automatic iSCSI login

This change is

common/config.yaml, line 12 at r1 (raw file):

   publish_context_array_iqn : "PUBLISH_CONTEXT_ARRAY_IQN"
   publish_context_fc_initiators : "PUBLISH_CONTEXT_ARRAY_FC_INITIATORS"
#  "<array_iqn>" keys (with value of iscsi target IPs)

I'm not sure we need this here but if so better to do it this way:
#<array_iqn_1>  : comma-separated list of  iqn_1 iscsi target ips
#<array_iqn_2>  : comma-separated list of  iqn_2 iscsi target ips
#...
#<array_iqn_k>  : comma-separated list of  iqn_k iscsi target ips

Are all changes specific to this svc iscsi login feature? If not, please don't introduce any code refactor in this pr.

Then please review this small PR first

controller/array_action/array_mediator_ds8k.py, line 294 at r3 (raw file):

    def get_iscsi_targets_by_iqn(self):
        return {}

Needs to raise some sort of UnsupportedException. Is there some parallel exception in python?

controller/array_action/array_mediator_svc.py, line 403 at r3 (raw file):

    def _list_ip_ports(self):
        try:
            return self.client.svcinfo.lsportip(filtervalue='state=configured:failover=no')

what is failover? Are you sure this filter is must?

controller/array_action/array_mediator_svc.py, line 409 at r3 (raw file):

    @staticmethod
    def _extract_ips_by_node_id(ports):

I don't like the word exract.
maybe  _create_ips_by_node_id_map ?

controller/array_action/array_mediator_svc.py, line 437 at r3 (raw file):

        ips_by_iqn = self._unify_ips_by_iqn(iqns_by_node_id, ips_by_node_id)

        if ips_by_iqn and any(ips_by_iqn.values()):

Can there be a situation of iqn with ports and an other iqn without?
If so better to write warning to log for each iqn without ports.

node/pkg/driver/driver.go, line 115 at r3 (raw file):

		Publish_context_array_iqn              string
		Publish_context_fc_initiators          string
		// "<array_iqn>" keys (with value of iscsi target IPs)

same comment as for yaml
#iqn1 : .;.;
#iqn2 : ..
...

node/pkg/driver/node.go, line 137 at r3 (raw file):

	if err := osDeviceConnectivity.EnsureLogin(ipsByArrayInitiator); err != nil {
		return nil, status.Error(codes.Internal, err.Error())

Do we wan t to return error if login fails?
User will still be able to do login manually (except RHCOS). Lets discuss this.

node/pkg/driver/node.go, line 244 at r3 (raw file):

	}

	if connectivityType == "iscsi" {

If I'll push before you use constant I added in device_connectivity.

node/pkg/driver/node_utils.go, line 99 at r3 (raw file):

func (n NodeUtils) GetInfoFromPublishContext(publishContext map[string]string, configYaml ConfigFile) (string, int, map[string][]string, error) {
	// this will return :  connectivityType, lun, ipsByArrayInitiator, error
	ipsByArrayInitiator := make(map[string][]string)

isn't it ips by iqn?

node/pkg/driver/device_connectivity/device_connectivity_fc.go, line 35 at r3 (raw file):

}

func (r OsDeviceConnectivityFc) EnsureLogin(_ map[string][]string) error {

add comment: // FC doesn't require login

node/pkg/driver/device_connectivity/device_connectivity_iscsi.go, line 52 at r3 (raw file):

	}

	output, err = r.iscsiCmd("-m", "node", "-p", targetPortal+":3260", "-T", targetName, "--login")

create constant with value 3260 and use it here

node/pkg/driver/device_connectivity/device_connectivity_iscsi.go, line 69 at r2 (raw file):
Previously, oriyarde wrote…
True, but I was thinking - if a user decides to manually configure their multipath to allow a single session (per iqn), should we really prevent them?
We already have an indicative message in MultipleDeviceNotFoundError later in the code

I would anyway log warning if there are less than  2 successful logins.

controller/array_action/array_mediator_ds8k.py, line 294 at r3 (raw file):
Previously, oriyarde wrote…
This is a comment for ds8k support PR (I only changed [] to {})

you still can add exception.

controller/array_action/array_mediator_svc.py, line 403 at r3 (raw file):
Previously, oriyarde wrote…
I think it means "passive" nodes. This filter avoids transmission of a lot of irrelevant items.
see pysvc branch

You sure we don't want to login passive anyway?

controller/array_action/array_mediator_svc.py, line 437 at r3 (raw file):
Previously, oriyarde wrote…
It is possible for a single iqn to fail on all portal logins, but there is already an error for every login failure.
I don't think the failure distribution between iqns is significant enough for an additional warning.

but what you say is in node level. Warning here will e helpful.

node/pkg/driver/node.go, line 137 at r3 (raw file):
Previously, oriyarde wrote…
Depends on the error reason.
What is the scenario which automatic login fails, but manual succeeds?

Some "unexpexcted" problem related to ruNning login from pod in the code) VS  manually (on the node)

node/pkg/driver/node_test.go, line 184 at r5 (raw file):

						PublishContextParamArrayIqn:     "iqn.1994-05.com.redhat:686358c930fe",
					},
					StagingTargetPath: "/test/path",

use stagingPath variable

node/pkg/driver/node_test.go, line 162 at r5 (raw file):

				req := &csi.NodeStageVolumeRequest{
					PublishContext:    publishContext,
					StagingTargetPath: "/test/path",

use stagingPath variable
My bad. Forgot to replace this one.

node/pkg/driver/node_utils.go, line 110 at r5 (raw file):

	connectivityType := publishContext[configYaml.Controller.Publish_context_connectivity_parameter]
	if connectivityType == device_connectivity.ConnectionTypeISCSI {
		iqns := strings.Split(publishContext[configYaml.Controller.Publish_context_array_iqn], ",")

create constant for iqns separaror "," and use it here

node/pkg/driver/node_utils.go, line 113 at r5 (raw file):

		for _, iqn := range iqns {
			if ips, iqnExists := publishContext[iqn]; iqnExists {
				ipsByArrayInitiator[iqn] = strings.Split(ips, ",")

create constant for initiators separaror "," and use it here

node/pkg/driver/node_utils.go, line 120 at r5 (raw file):

	}
	if connectivityType == device_connectivity.ConnectionTypeFC {
		wwns := strings.Split(publishContext[configYaml.Controller.Publish_context_fc_initiators], ",")

use initiators separator constant here

node/pkg/driver/device_connectivity/device_connectivity_iscsi.go, line 47 at r5 (raw file):

}

func (r OsDeviceConnectivityIscsi) iscsiDiscoverAndLogin(targetName, portal string) error {

We need unitest for this method

@igorgonibm @27149chen Thank you for your comments, they are very valuable.
If you don't have any more comments, please resolve your open conversations and approve.

node/pkg/driver/node.go, line 137 at r3 (raw file):
Previously, oriyarde wrote…
So you think we should always continue to rescan even if all logins fail?

yes

node/pkg/driver/device_connectivity/device_connectivity_iscsi.go, line 68 at r6 (raw file):

	var err error
	for targetName, portals := range portalsByTarget {
		for _, portal := range portals {

I didn't saw it before.
Discover should be done only with one ip per iqn (loop util on e succeeds).
Only login should be to all ips.


Cleanup match after #8000. Also add proper nuking of enterprise profiles (related #8065)

Note that the cleanup reveals what appears to be a broken test

@lacostej see felix last comment i think it slipped through

@hjanuschka where? I think github was a bit slow to update the PR state.

yep - seemed to be github cache or whatever.


Tool path veers off the working area.

with the .svg file I downloaded from somewhere, the job path tries too veer off the working area as there are some dots/points in the drawing(on meerk40t) which is apparently not noticeable on inkspace. Is it possible to limit the tool path within the working area and show warnings/error if there are drawings beyond the working area when executing the job?
Thanks
Base.zip

Yeah, there was a plan to make it show an those in red text if they existed and I could certainly add them to the 0.7.0 list. There's some cases where it might be valid, but mostly it would just ram the laserhead into the wall.


chore: refactoring and rearrangement.

Description
More DRY code. Also moving some dirs to completely separate non-hooks from hooks.
Type of change

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[x] Breaking change (fix or feature that would cause existing functionality to not work as before)

Checklist

[x] Read the Contributing Guide
[x] Perform a code self-review
[x] Comment the code, particularly in hard-to-understand areas
[x] Add documentation
[x] Add hook's story at Storybook
[x] Cover changes with tests
[x] Ensure the test suite passes (yarn test)
[x] Provide 100% tests coverage
[x] Make sure code lints (yarn lint). Fix it with yarn lint:fix in case of failure.
[x] Make sure types are fine (yarn lint:types).

:tada: This PR is included in version 16.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

:tada: This PR is included in version 16.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


[FF-3] - Base Layout

This PR closes #3
There is plenty of other minor things in here but it's mostly "learning" of things that just ended up working and should be added any way!

Looks like there is an issue with github where sometimes a PR review is getting dismissed for no reason. That said I'm going to bypass the requirements for now so as not to keep bothering for the a branch that has not changed 😢


Added packages and asmdef files

Added packages and asmdef file to make this plugin compatible with Unity Package Manager.

Added in cb1d4846e8853612d2facfd29e80ccdce061fac9 thanks!


Spec missing translation.

Hi,
On the last example of https://golang.org/ref/spec#Struct_types a translation is missing, it says:
"ceci n'est pas un champ de structure"
and it should say:
"This is not a struct field".
Or is this a pun?

Considering that AFAIK the spec wasn't originally written in French, I'd say this is not a missing translation, it must be intentional.

Il n'y a pas de plaisir à écrire tout dans la même langue.


Update LLVM

Also, strip device-enque features from the header file.
A recent change to Clang accidentally removes the predeclaration
of the queue_t and clk_event_t types for OpenCL 2.0 flows.
A compile error results in opencl-c.h if we don't strip the offending
declarations of the enqueue-related builtins.

This is the offending upstream change:
https://github.com/llvm/llvm-project/commit/a5de66c4c50b5dec085ffbcd2afefd47f3f18d7f#diff-c538f45bf941ec180ae164adeaa4d749520101359503af9373076feecfb88228R337
The overall change adds OpenCL 3.0 support for feature macro __opencl_c_device_enqueue.
That's fine. But in Sema, it accidentally turns off predeclaration of queue_t and clk_event_t.
But the opencl-c.h header depends on those definitions existing.
So compilation fails with -cl-std=CL2.0  because the __opencl_c_device_enqueue is enabled by opencl-c-base.h but then fails at the first declaration that uses queue_t or clk_event_t.

As luck would have it, I can't reproduce the problem independenltly on upstream clang.
I expected a trivial source file would fail to compile with these options:
clang -cc1 -cl-std=CL2.0 foo.cl -emit-llvm -o -

But I get no problem.
On the other hand, I'm also unable to compile the 'ctz' function, which was introduced in OpenCL 2.0, I think.
$ ./bin/clang -cc1 -cl-std=CL2.0 a.cl
a.cl:2:8: error: implicit declaration of function 'ctz' is invalid in OpenCL
  *A = ctz(*A);
       ^
1 error generated.


getting started tutorial doesn't work in 2017.2.0f3

I'm brand new to UMA so I might be missing something, but I just started going through the Getting Started section and the first example errs out.  It looks very similar to https://github.com/umasteeringgroup/UMA/issues/33 but just in case here's the whole log I get. This error and the following warning occur on every frame after pressing play.
SkinnedMeshRenderer: Trying to set a mesh ("") that is unfit for use with SkinnedMeshRenderer. Most likely it doesn't have Skin information and/or is only assigned to the renderer during runtime, in which case Unity isn't aware of its use with SkinnedMeshRenderer. Mark the mesh as Readable or assign it to the renderer in the Editor before building.
UnityEngine.SkinnedMeshRenderer:set_sharedMesh(Mesh)
UMA.UMADefaultMeshCombiner:MakeRenderer(Int32, Transform) (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMADefaultMeshCombiner.cs:105)
UMA.UMADefaultMeshCombiner:EnsureUMADataSetup(UMAData) (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMADefaultMeshCombiner.cs:44)
UMA.UMADefaultMeshCombiner:UpdateUMAMesh(Boolean, UMAData, Int32) (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMADefaultMeshCombiner.cs:126)
UMA.UMAGeneratorBuiltin:UpdateUMAMesh(Boolean) (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:282)
UMA.UMAGeneratorBuiltin:HandleDirtyUpdate(UMAData) (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:226)
UMA.UMAGeneratorBuiltin:OnDirtyUpdate() (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:265)
UMA.UMAGeneratorBuiltin:Work() (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:132)
UMA.UMAGeneratorBuiltin:Update() (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:97)

This warning that happens every frame as well.
Exception in UMAGeneratorBuiltin.OnDirtyUpdate: System.NullReferenceException: Object reference not set to an instance of an object
  at UMA.UMADefaultMeshCombiner.MakeRenderer (Int32 i, UnityEngine.Transform rootBone) [0x000e4] in /Users/mistermashu/games/PlagueKnight/Assets/UMA/Core/StandardAssets/UMA/Scripts/UMADefaultMeshCombiner.cs:108
  at UMA.UMADefaultMeshCombiner.EnsureUMADataSetup (UMA.UMAData umaData) [0x0010f] in /Users/mistermashu/games/PlagueKnight/Assets/UMA/Core/StandardAssets/UMA/Scripts/UMADefaultMeshCombiner.cs:44
  at UMA.UMADefaultMeshCombiner.UpdateUMAMesh (Boolean updatedAtlas, UMA.UMAData umaData, Int32 atlasResolution) [0x00034] in /Users/mistermashu/games/PlagueKnight/Assets/UMA/Core/StandardAssets/UMA/Scripts/UMADefaultMeshCombiner.cs:126
  at UMA.UMAGeneratorBuiltin.UpdateUMAMesh (Boolean updatedAtlas) [0x00026] in /Users/mistermashu/games/PlagueKnight/Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:282
  at UMA.UMAGeneratorBuiltin.HandleDirtyUpdate (UMA.UMAData data) [0x0016b] in /Users/mistermashu/games/PlagueKnight/Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:226
  at UMA.UMAGeneratorBuiltin.OnDirtyUpdate () [0x0005c] in /Users/mistermashu/games/PlagueKnight/Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:265
UnityEngine.Debug:LogWarning(Object)
UMA.UMAGeneratorBuiltin:OnDirtyUpdate() (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:274)
UMA.UMAGeneratorBuiltin:Work() (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:132)
UMA.UMAGeneratorBuiltin:Update() (at Assets/UMA/Core/StandardAssets/UMA/Scripts/UMAGeneratorBuiltin.cs:97)

Steps to reproduce:

Create a new scene
drag & drop the "Environment" prefab into the scene view
drag & drop the UMA_DCS onto the Hierarchy
drag & drop the UMADynamicCharacterAvatar into the scene view
reposition the camera so it's looking at the CharacterAvatar
press play

I have Unity version 2017.2.0f3 Personal and UMA 2.6.2

Yes, that is the same issue.  Please try 2017.2.0p4, it is fixed in that version.
https://unity3d.com/unity/qa/patch-releases

yep, works for me in 2017.2.0p4. thanks!

great, have fun! :)
message me at<EMAIL_ADDRESS>if you'd like an invite to the uma slack channel.


feat(note): add new endpoint

change cluster-missing endpoint to include basic PD token stuff
(rewritten 4 times already)
errors were renamed/data changed for easier use
makefile change to fix a build error
moved to use fmt.Fprint instead of w.Write as it's cleaner and
doesn't require to cast to a byte array
refactored the common errors together

related to OSD-9777

/lgtm

/hold
I need to change this and commit

/unhold

@ramonbutter another lgtm?

/lgtm


TestOperatorIDFiltering/Operators_can_handoff_scoped_integrations test failing

Since some time the following test is no longer working.
    --- FAIL: TestOperatorIDFiltering/Operators_can_handoff_scoped_integrations (0.14s)

I think it can be related to some upgraded dependency.
Originally posted by @squakez in https://github.com/apache/camel-k/issues/3535#issuecomment-1211941523

@christophd mind having a look?


Emulator usability updates

The final step of emulation-based tests is currently run like this:
pytest -s -k test_6 --ffe_length 10 --ser_port SER_PORT --emu_clk_freq EMU_CLK_FREQ

However, it could simply be run like this
pytest -s -k test_6

This should work because ffe_length and emu_clk_freq are already stored in YAML files, while ser_port can now be determined automatically by anasymod using one of its new features.

This is now addressed in the zcu106 branch, but I'll leave the issue open until the changes are merged into the master branch.


showcase: use shared GWT props + tweak resource config

@pefernan could you please take a look? I've tested this locally and everything seems to work.

+1

@psiroky +1

We should wait with this one as it currently break integration with IDEA as found by @manstis and @Rikkola. Will keep you posted.

I fixed the SDM in IDEA similarly as in guvnor and drools-wb repos - the showcase now contains only single GWT module, no FastCompiled thing anymore. This should make the maintenance easier. You will need to update your configs if you use FastCompiled* somewhere (like the IDEA GWT launcher).

Thanks.
master: 94fd4ae107cf9cc6a3a667d207e06243af7a9f1e


Pass the context in a webpack-friendly way

https://github.com/webpack/webpack/issues/1028#issuecomment-103987676

Done as of @50097e8181c5d0e14f1066961a114ce8e37cd524