🐛 [FIREBASE_AUTH] twitter signin ios simulator app crashed

Bug report
Hi,
The scenario is something like that:
if user is logged in using google provider. And then tried to login using twitter provider with same email. app crashed on ios simulator with the following error.
Unsupported value: <FIROAuthCredential: 0x600001ea9450> of type FIROAuthCredential

but working perfectly fine on android emulator.
Steps to reproduce

Login to the app using google provider.
then logout
Login to the app using twitter provider with the same email used to login using google provider.
App will crash on ios simulator.

Expected behavior
Expecting Result:
An account already exists with the same email address but different sign-in credentials. Sign in using a provider associated with this email address.

Actual Result:
Unsupported value: <FIROAuthCredential: 0x600001ea9450> of type FIROAuthCredential

Flutter doctor
Click To Expand
Flutter (Channel stable, 3.13.3, on macOS 12.6.6 21G646 darwin-x64, locale en-AE)
    • Flutter version 3.13.3 on channel stable at /Users/mac/Documents/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision<PHONE_NUMBER> (7 days ago), 2023-09-06 14:32:31 -0700
    • Engine revision b8d35810e9
    • Dart version 3.1.1
    • DevTools version 2.25.0

[✓] Android toolchain - develop for Android devices (Android SDK version 33.0.1)
    • Android SDK at /Users/mac/Library/Android/sdk
    • Platform android-34, build-tools 33.0.1
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 14.2)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 14C18
    • CocoaPods version 1.12.1

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2022.3)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231)

[✓] VS Code (version 1.81.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.52.0

[✓] Connected device (4 available)
    • sdk gphone64 x86 64 (mobile) • emulator-5554                        • android-x64    • Android 13 (API 33) (emulator)
    • iPhone 14 Pro Max (mobile)   • 362D19F3-892B-4FAC-8856-4E668B131DFF • ios            • com.apple.CoreSimulator.SimRuntime.iOS-16-2 (simulator)
    • macOS (desktop)              • macos                                • darwin-x64     • macOS 12.6.6 21G646 darwin-x64
    • Chrome (web)                 • chrome                               • web-javascript • Google Chrome 117.0.5938.62

[✓] Network resources
    • All expected network resources are available.

• No issues found!

Flutter dependencies
Click To Expand
dependencies:
- app_settings 5.0.0 [flutter plugin_platform_interface]
- cached_network_image 3.2.3 [flutter flutter_cache_manager octo_image cached_network_image_platform_interface cached_network_image_web]
- camera 0.10.5+4 [camera_android camera_avfoundation camera_platform_interface camera_web flutter flutter_plugin_android_lifecycle quiver]
- capitalize 0.0.1 [flutter]
- carousel_slider 4.2.1 [flutter]
- country_code_picker 3.0.0 [flutter collection]
- crypto 3.0.3 [typed_data]
- device_info_plus 9.0.3 [device_info_plus_platform_interface ffi file flutter flutter_web_plugins meta win32 win32_registry]
- device_preview 1.1.0 [flutter flutter_localizations provider device_frame freezed_annotation json_annotation shared_preferences collection]
- dio 5.3.2 [async http_parser meta path]
- dots_indicator 3.0.0 [flutter]
- dotted_line 3.2.2 [flutter]
- draggable_bottom_sheet 1.0.2 [flutter]
- easy_localization 3.0.2 [flutter shared_preferences intl args path easy_logger flutter_localizations]
- expandable 5.0.1 [flutter]
- file_picker 5.5.0 [flutter flutter_web_plugins flutter_plugin_android_lifecycle plugin_platform_interface ffi path win32]
- firebase_auth 4.8.0 [firebase_auth_platform_interface firebase_auth_web firebase_core firebase_core_platform_interface flutter meta]
- firebase_core 2.15.1 [firebase_core_platform_interface firebase_core_web flutter meta]
- firebase_crashlytics 3.3.5 [firebase_core firebase_core_platform_interface firebase_crashlytics_platform_interface flutter stack_trace]
- firebase_messaging 14.6.7 [firebase_core firebase_core_platform_interface firebase_messaging_platform_interface firebase_messaging_web flutter meta]
- flutter 0.0.0 [characters collection material_color_utilities meta vector_math web sky_engine]
- flutter_launcher_icons 0.13.1 [args checked_yaml cli_util image json_annotation path yaml]
- flutter_local_notifications 15.1.1 [clock flutter flutter_local_notifications_linux flutter_local_notifications_platform_interface timezone]
- flutter_localizations 0.0.0 [flutter intl characters clock collection material_color_utilities meta path vector_math web]
- flutter_otp_text_field 1.1.1 [flutter]
- flutter_rating_bar 4.0.1 [flutter]
- flutter_riverpod 2.3.7 [collection flutter meta riverpod state_notifier]
- flutter_svg 2.0.7 [flutter vector_graphics vector_graphics_codec vector_graphics_compiler]
- geocoding 2.1.0 [flutter geocoding_platform_interface geocoding_android geocoding_ios]
- google_maps_flutter 2.4.0 [flutter google_maps_flutter_android google_maps_flutter_ios google_maps_flutter_platform_interface google_maps_flutter_web]
- google_sign_in 6.1.4 [flutter google_sign_in_android google_sign_in_ios google_sign_in_platform_interface google_sign_in_web]
- im_stepper 1.0.1+1 [flutter]
- image_picker 1.0.4 [flutter image_picker_android image_picker_for_web image_picker_ios image_picker_linux image_picker_macos image_picker_platform_interface image_picker_windows]
- intl 0.18.1 [clock meta path]
- location 5.0.3 [flutter location_platform_interface location_web]
- map_launcher 2.5.0+1 [flutter]
- package_info_plus 4.1.0 [ffi flutter flutter_web_plugins http meta path package_info_plus_platform_interface win32]
- pinput 3.0.1 [flutter smart_auth universal_platform]
- pull_to_refresh 2.0.0 [flutter]
- riverpod_annotation 2.1.2 [meta riverpod]
- share_plus 7.1.0 [cross_file meta mime flutter flutter_web_plugins share_plus_platform_interface file url_launcher_web url_launcher_windows url_launcher_linux url_launcher_platform_interface ffi win32]
- shared_preferences 2.2.0 [flutter shared_preferences_android shared_preferences_foundation shared_preferences_linux shared_preferences_platform_interface shared_preferences_web shared_preferences_windows]
- sign_in_with_apple 5.0.0 [flutter meta sign_in_with_apple_platform_interface sign_in_with_apple_web]
- url_launcher 6.1.14 [flutter url_launcher_android url_launcher_ios url_launcher_linux url_launcher_macos url_launcher_platform_interface url_launcher_web url_launcher_windows]

dev dependencies:
- build_runner 2.4.6 [analyzer args async build build_config build_daemon build_resolvers build_runner_core code_builder collection crypto dart_style frontend_server_client glob graphs http_multi_server io js logging meta mime package_config path pool pub_semver pubspec_parse shelf shelf_web_socket stack_trace stream_transform timing watcher web_socket_channel yaml]
- custom_lint 0.5.2 [analyzer analyzer_plugin args async ci cli_util collection freezed_annotation json_annotation meta package_config path pub_semver pubspec_parse rxdart uuid yaml]
- flutter_lints 2.0.2 [lints]
- flutter_test 0.0.0 [flutter test_api matcher path fake_async clock stack_trace vector_math async boolean_selector characters collection material_color_utilities meta source_span stream_channel string_scanner term_glyph web]
- riverpod_generator 2.2.6 [analyzer build build_config collection crypto meta path riverpod_analyzer_utils riverpod_annotation source_gen]
- riverpod_lint 2.0.1 [analyzer analyzer_plugin collection custom_lint_builder meta path riverpod riverpod_analyzer_utils source_span yaml]

transitive dependencies:
- _fe_analyzer_shared 64.0.0 [meta]
- _flutterfire_internals 1.3.5 [collection firebase_core firebase_core_platform_interface flutter meta]
- analyzer 6.2.0 [_fe_analyzer_shared collection convert crypto glob meta package_config path pub_semver source_span watcher yaml]
- analyzer_plugin 0.11.3 [analyzer collection dart_style pub_semver yaml]
- archive 3.3.7 [crypto path pointycastle]
- args 2.4.2
- async 2.11.0 [collection meta]
- boolean_selector 2.1.1 [source_span string_scanner]
- build 2.4.1 [analyzer async convert crypto glob logging meta package_config path]
- build_config 1.1.1 [checked_yaml json_annotation path pubspec_parse yaml]
- build_daemon 4.0.0 [built_collection built_value http_multi_server logging path pool shelf shelf_web_socket stream_transform watcher web_socket_channel]
- build_resolvers 2.2.1 [analyzer async build collection crypto graphs logging package_config path pool pub_semver stream_transform yaml]
- build_runner_core 7.2.10 [async build build_config build_resolvers collection convert crypto glob graphs json_annotation logging meta package_config path pool timing watcher yaml]
- built_collection 5.1.1
- built_value 8.6.2 [built_collection collection fixnum meta]
- cached_network_image_platform_interface 2.0.0 [flutter flutter_cache_manager]
- cached_network_image_web 1.0.2 [flutter flutter_cache_manager cached_network_image_platform_interface]
- camera_android 0.10.8+8 [camera_platform_interface flutter flutter_plugin_android_lifecycle stream_transform]
- camera_avfoundation 0.9.13+4 [camera_platform_interface flutter stream_transform]
- camera_platform_interface 2.5.2 [cross_file flutter plugin_platform_interface stream_transform]
- camera_web 0.3.2+3 [camera_platform_interface flutter flutter_web_plugins stream_transform]
- characters 1.3.0
- checked_yaml 2.0.3 [json_annotation source_span yaml]
- ci 0.1.0
- cli_util 0.4.0 [meta path]
- clock 1.1.1
- code_builder 4.5.0 [built_collection built_value collection matcher meta]
- collection 1.17.2
- convert 3.1.1 [typed_data]
- cross_file 0.3.3+5 [js meta]
- csslib 1.0.0 [source_span]
- custom_lint_builder 0.5.2 [analyzer analyzer_plugin collection custom_lint custom_lint_core glob hotreloader meta path pubspec_parse rxdart]
- custom_lint_core 0.5.2 [analyzer analyzer_plugin collection custom_lint matcher meta path pubspec_parse source_span yaml]
- dart_style 2.3.2 [analyzer args path pub_semver source_span]
- dbus 0.7.8 [args ffi meta xml]
- device_frame 1.1.0 [freezed_annotation flutter]
- device_info_plus_platform_interface 7.0.0 [flutter meta plugin_platform_interface]
- easy_logger 0.0.2 [flutter]
- fake_async 1.3.1 [clock collection]
- ffi 2.1.0
- file 6.1.4 [meta path]
- file_selector_linux 0.9.2+1 [cross_file file_selector_platform_interface flutter]
- file_selector_macos 0.9.3+2 [cross_file file_selector_platform_interface flutter]
- file_selector_platform_interface 2.6.1 [cross_file flutter http plugin_platform_interface]
- file_selector_windows 0.9.3+1 [cross_file file_selector_platform_interface flutter]
- firebase_auth_platform_interface 6.17.0 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_auth_web 5.7.0 [firebase_auth_platform_interface firebase_core firebase_core_web flutter flutter_web_plugins http_parser js meta]
- firebase_core_platform_interface 4.8.0 [collection flutter flutter_test meta plugin_platform_interface]
- firebase_core_web 2.7.0 [firebase_core_platform_interface flutter flutter_web_plugins js meta]
- firebase_crashlytics_platform_interface 3.6.5 [_flutterfire_internals collection firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_platform_interface 4.5.6 [_flutterfire_internals firebase_core flutter meta plugin_platform_interface]
- firebase_messaging_web 3.5.6 [_flutterfire_internals firebase_core firebase_core_web firebase_messaging_platform_interface flutter flutter_web_plugins js meta]
- fixnum 1.1.0
- flutter_blurhash 0.7.0 [flutter]
- flutter_cache_manager 3.3.1 [clock collection file flutter http path path_provider rxdart sqflite uuid]
- flutter_local_notifications_linux 4.0.0+1 [dbus ffi flutter flutter_local_notifications_platform_interface path xdg_directories]
- flutter_local_notifications_platform_interface 7.0.0+1 [flutter plugin_platform_interface]
- flutter_plugin_android_lifecycle 2.0.15 [flutter]
- flutter_web_plugins 0.0.0 [flutter characters collection material_color_utilities meta vector_math web]
- freezed_annotation 2.4.1 [collection json_annotation meta]
- frontend_server_client 3.2.0 [async path]
- geocoding_android 2.1.2 [flutter geocoding_platform_interface]
- geocoding_ios 2.1.0 [flutter geocoding_platform_interface]
- geocoding_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- glob 2.1.2 [async collection file path string_scanner]
- google_identity_services_web 0.2.1 [js meta]
- google_maps 6.3.0 [js js_wrapping meta]
- google_maps_flutter_android 2.5.0 [flutter flutter_plugin_android_lifecycle google_maps_flutter_platform_interface stream_transform]
- google_maps_flutter_ios 2.3.0 [flutter google_maps_flutter_platform_interface stream_transform]
- google_maps_flutter_platform_interface 2.4.0 [collection flutter plugin_platform_interface stream_transform]
- google_maps_flutter_web 0.5.4 [collection flutter flutter_web_plugins google_maps google_maps_flutter_platform_interface sanitize_html stream_transform]
- google_sign_in_android 6.1.18 [flutter google_sign_in_platform_interface]
- google_sign_in_ios 5.6.2 [flutter google_sign_in_platform_interface]
- google_sign_in_platform_interface 2.4.1 [flutter plugin_platform_interface quiver]
- google_sign_in_web 0.12.0+3 [flutter flutter_web_plugins google_identity_services_web google_sign_in_platform_interface http js]
- graphs 2.3.1 [collection]
- hotreloader 3.0.6 [collection logging path stream_transform vm_service watcher]
- html 0.15.4 [csslib source_span]
- http 1.1.0 [async http_parser meta]
- http_multi_server 3.2.1 [async]
- http_parser 4.0.2 [collection source_span string_scanner typed_data]
- image 4.0.17 [archive meta xml]
- image_picker_android 0.8.7+5 [flutter flutter_plugin_android_lifecycle image_picker_platform_interface]
- image_picker_for_web 3.0.1 [flutter flutter_web_plugins image_picker_platform_interface mime]
- image_picker_ios 0.8.8+2 [flutter image_picker_platform_interface]
- image_picker_linux 0.2.1+1 [file_selector_linux file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_macos 0.2.1+1 [file_selector_macos file_selector_platform_interface flutter image_picker_platform_interface]
- image_picker_platform_interface 2.9.1 [cross_file flutter http plugin_platform_interface]
- image_picker_windows 0.2.1+1 [file_selector_platform_interface file_selector_windows flutter image_picker_platform_interface]
- io 1.0.4 [meta path string_scanner]
- js 0.6.7 [meta]
- js_wrapping 0.7.4 [js]
- json_annotation 4.8.1 [meta]
- lints 2.1.1
- location_platform_interface 3.1.2 [flutter plugin_platform_interface]
- location_web 4.2.0 [flutter flutter_web_plugins http_parser js location_platform_interface]
- logging 1.2.0
- matcher 0.12.16 [async meta stack_trace term_glyph test_api]
- material_color_utilities 0.5.0 [collection]
- meta 1.9.1
- mime 1.0.4
- nested 1.0.0 [flutter]
- octo_image 1.0.2 [flutter flutter_blurhash]
- package_config 2.1.0 [path]
- package_info_plus_platform_interface 2.0.1 [flutter meta plugin_platform_interface]
- path 1.8.3
- path_parsing 1.0.1 [vector_math meta]
- path_provider 2.1.0 [flutter path_provider_android path_provider_foundation path_provider_linux path_provider_platform_interface path_provider_windows]
- path_provider_android 2.1.0 [flutter path_provider_platform_interface]
- path_provider_foundation 2.3.0 [flutter path_provider_platform_interface]
- path_provider_linux 2.2.0 [ffi flutter path path_provider_platform_interface xdg_directories]
- path_provider_platform_interface 2.1.0 [flutter platform plugin_platform_interface]
- path_provider_windows 2.2.0 [ffi flutter path path_provider_platform_interface win32]
- petitparser 5.4.0 [meta]
- platform 3.1.1
- plugin_platform_interface 2.1.5 [meta]
- pointycastle 3.7.3 [collection convert js]
- pool 1.5.1 [async stack_trace]
- provider 6.0.5 [collection flutter nested]
- pub_semver 2.1.4 [collection meta]
- pubspec_parse 1.2.3 [checked_yaml collection json_annotation pub_semver yaml]
- quiver 3.2.1 [matcher]
- riverpod 2.3.7 [meta stack_trace state_notifier]
- riverpod_analyzer_utils 0.3.3 [analyzer collection crypto custom_lint_core freezed_annotation meta path source_span]
- rxdart 0.27.7
- sanitize_html 2.0.0 [html meta]
- share_plus_platform_interface 3.3.0 [cross_file flutter meta mime plugin_platform_interface path_provider uuid]
- shared_preferences_android 2.2.0 [flutter shared_preferences_platform_interface]
- shared_preferences_foundation 2.3.3 [flutter shared_preferences_platform_interface]
- shared_preferences_linux 2.3.0 [file flutter path path_provider_linux path_provider_platform_interface shared_preferences_platform_interface]
- shared_preferences_platform_interface 2.3.0 [flutter plugin_platform_interface]
- shared_preferences_web 2.2.0 [flutter flutter_web_plugins shared_preferences_platform_interface]
- shared_preferences_windows 2.3.0 [file flutter path path_provider_platform_interface path_provider_windows shared_preferences_platform_interface]
- shelf 1.4.1 [async collection http_parser path stack_trace stream_channel]
- shelf_web_socket 1.0.4 [shelf stream_channel web_socket_channel]
- sign_in_with_apple_platform_interface 1.0.0 [flutter plugin_platform_interface meta]
- sign_in_with_apple_web 1.0.1 [flutter flutter_web_plugins sign_in_with_apple_platform_interface js]
- sky_engine 0.0.99
- smart_auth 1.1.1 [flutter flutter_web_plugins]
- source_gen 1.4.0 [analyzer async build dart_style glob path source_span yaml]
- source_span 1.10.0 [collection path term_glyph]
- sqflite 2.3.0 [flutter sqflite_common path]
- sqflite_common 2.5.0 [synchronized path meta]
- stack_trace 1.11.0 [path]
- state_notifier 1.0.0 [meta]
- stream_channel 2.1.1 [async]
- stream_transform 2.1.0
- string_scanner 1.2.0 [source_span]
- synchronized 3.1.0
- term_glyph 1.2.1
- test_api 0.6.0 [async boolean_selector collection meta source_span stack_trace stream_channel string_scanner term_glyph]
- timezone 0.9.2 [path]
- timing 1.0.1 [json_annotation]
- typed_data 1.3.2 [collection]
- universal_platform 1.0.0+1
- url_launcher_android 6.1.0 [flutter url_launcher_platform_interface]
- url_launcher_ios 6.1.5 [flutter url_launcher_platform_interface]
- url_launcher_linux 3.0.6 [flutter url_launcher_platform_interface]
- url_launcher_macos 3.0.7 [flutter url_launcher_platform_interface]
- url_launcher_platform_interface 2.1.5 [flutter plugin_platform_interface]
- url_launcher_web 2.0.19 [flutter flutter_web_plugins url_launcher_platform_interface]
- url_launcher_windows 3.0.8 [flutter url_launcher_platform_interface]
- uuid 3.0.7 [crypto]
- vector_graphics 1.1.7 [flutter vector_graphics_codec]
- vector_graphics_codec 1.1.7
- vector_graphics_compiler 1.1.7 [args meta path_parsing xml vector_graphics_codec]
- vector_math 2.1.4
- vm_service 11.10.0
- watcher 1.1.0 [async path]
- web 0.1.4-beta
- web_socket_channel 2.4.0 [async crypto stream_channel]
- win32 5.0.7 [ffi]
- win32_registry 1.1.1 [ffi win32]
- xdg_directories 1.0.2 [meta path]
- xml 6.3.0 [collection meta petitparser]
- yaml 3.1.2 [collection source_span string_scanner]

Hi @abubakarmvp, is it only with the twitter provider? Or you get this issue when you try to sign in with an existing email from any provider?

App contains google and twitter signin only. With Google signin i did not face any issue. but with twitter app is crashing.
But if i enable "Create multiple accounts for each identity provider" option from console. then there is no crash.

I used email/password sign in and google sign in but I don't get a proper error message although the application didn't exactly crash. This is worth investigating.
cc @Lyokone

Hi @danagbemava-nc,
As you can see in the video, On twitter signin app is crashed.
https://github.com/firebase/flutterfire/assets/103175184/ac3b4bab-0454-49fd-ad68-266fe23e1f47

I think this might've been fixed with this PR, but I would like to confirm. Can you provide a repro code sample for me to test, please, @abubakarmvp

Getting this exact same error while linking a Google provider after an initial sign up with SMS. I have 100% reproduction rate (did not have this problem initially tho, I had some successful linking, I will now try to clean simulator data and report back)
Unsupported value: <FIROAuthCredential: 0x600001ea9450> of type FIROAuthCredential

Unfortunately I do not have reproducible code to share as the code at stake is too deep in my app logic.
I also get this:
Lost connection to device.
Exception: Unable to terminate com.redacted.redacted on BD5A0...................DF0D:
ProcessException: Process exited abnormally:
An error was encountered processing the command (domain=NSPOSIXErrorDomain, code=3):
Simulator device returned an error for the requested operation.
found nothing to terminate
Underlying error (domain=NSPOSIXErrorDomain, code=3):
	The request to terminate "com.oneappatatime.top" failed. found nothing to terminate
	found nothing to terminate
  Command: /usr/bin/arch -arm64e xcrun simctl terminate BD5A0...................DF0D: com.redacted.redacted

I managed to replicate again, to me the way to fix is NOT to clean the iPhone simulator (i.e. Device > Erase All Contents and Settings) but
The solutions is to stop the Firebase emulator and then start it again with firebase emulators:start

I'm seeing the same issue on simulator when attempting to convert Firebase email password users to Microsoft sign in. This has been reported by our production users on physical devices as well. As far as I've tested the 4.11.1 updates haven't fixed this problem.

Looks like this issue is only happening for me on iOS simulators or devices (tested with the 4.12.0 firebase_auth package). No issue found on Android device. @russellwheatley

Also tested this with email enumeration turned on/off and that didn't change anything.

Looks like this issue was introduced in 4.7.0 as downgrading to 4.6.3 works fine for me, but upgrading to 4.7.0 causes the crash to start appearing. @mariopepe @danagbemava-nc

Very interesting thanks so much for sharing @deffs
I also downgraded firebase_auth, firebase_core, etc. because the newest version with pigeon crashes when using the firebase emulator and hot restarting the app 😞

Hi 👋 On the latest version, I cannot reproduce; Can you provide a full reproduction project?

I will test this again today. To confirm, what is the latest version you are using? Auth 4.12.1?

@Lyokone this is still crashing for me on iOS simulators & devices when using firebase_auth 4.12.1 with the latest Firebase Flutter packages. What I am trying to do is sign in to a previously created email/password user and convert them to a Microsoft provider user.
First, sign in to the user with the signInWithEmailAndPassword method (that works successfully).
Second, I attempt to sign the user in with a provider signInWithProvider(getMicrosoftProvider()) (Microsoft provider in my case). When I attempt to sign in with provider that causes an exception and then crash due to Unsupported value: <FIROAuthCredential: 0x60000217bf70> of type FIROAuthCredential. As far as I've tested when I try to signInWithProvider(getMicrosoftProvider()) it crashes.
Microsoft provider is set to:
MicrosoftAuthProvider getMicrosoftProvider() {
    final microsoftProvider = MicrosoftAuthProvider();
    microsoftProvider.setCustomParameters({
      'tenant': 'xxx',
      'login_hint': enteredEmail
    });
    return microsoftProvider;
  }

Looks like linkWithProvider(getMicrosoftProvider()) works successfully and returns the expected credential. Thus I think I can work around this crash using the link instead of signIn method. @mariopepe @abubakarmvp.

@deffs I'm wondering if it's due to this setting in the console:

If the user has already created an account, you might have to link it.

Hi @Lyokone,
My major concern is app should not crash on IOS even the accounts are not linked successfully. Because on Android, i am getting exception but the app is not crashing.

Ya I agree with @abubakarmvp on Android it's not crashing and it wasn't previously crashing on iOS. This crash is blocking me from turning on email enumeration protection since we can no longer use "fetchSignInMethodsForEmail" @Lyokone

As noted here, I cannot reproduce the issue, do you mind providing a full reproduction example so I can check what's going on? Thanks

It's a very simple example, but I'm having the same issue today. It seems to only be occurring if the email I'm signing in with to Microsoft already has an account created in Firebase using another provider (in my case I had signed in already with Google using the same email).
Once I delete the user from Firebase, I can successfully log in using Microsoft.
Under the Settings tab in Firebase Auth, I also have set "Link accounts that use the same email".
    try {
      final microsoftProvider = MicrosoftAuthProvider();
      final UserCredential userCredential =
          await FirebaseAuth.instance.signInWithProvider(microsoftProvider);
      return await _mapFirebaseUser(userCredential.user);
    } on FirebaseAuthException catch (e) {
      print(e);
    }

Ya I was seeing the issue the same way on iOS devices and simulators.

Create a new email/password user
Attempt to sign-in as that user using signInWithProvider with a Microsoft provider.

I can try to create an example Flutter project that replicates this issue.

@Lyokone I tried creating a sample project that replicates the issue, but I was only able to get it to crash when attempting to sign-in to Microsoft using my company's "tenant" and Microsoft Active Directory setup. If I use a generic Microsoft provider (like one I created for the exmaple project it doesn't crash). The only differences in our Azure setup is my project supports "All Microsoft Account Users" and my company's is "My Organization Only". I'm not sure how to replicate the scenario exactly, but for whatever reason the credential is coming back differently and cannot be parsed correctly by Firebase Auth. Sign in works fine after a user has been successfully linked to Microsoft.

Hi @deffs, thanks for the investigation, that is probably why I wasn't able to reproduce this issue with our own Microsoft account. I'll see if I can find a way to reproduce this issue.

Sometimes I do get this error when I just call  await FirebaseAuth.instance.currentUser?.linkWithProvider(...) so even before Google can make any evaluation regarding my email etc. Deleting the app and trying again fixes it, I wonder in production what happens.

@Lyokone any updates on this one? I don't want to the google bot to close this or mark it as stale.

any updates on this crash?

I had the same issue with Microsoft login, I downgraded to version 4.6.3 and it worked normally.
This problem occurs from version 7.0 onwards.

do you mean version 4.6.3 of the "firebase_auth" package?

@Lyokone any updates on this issue; looks like other users are reporting the same issue.

This is still happening.

@Lyokone my co-worker said we could create an account for you on our Microsoft tenant to further debug this issue. Let me know if this would help.

Hey @deffs - if you have an issue on Microsoft, it would be helpful if you could open a fresh issue with a full repro, please. This issue is for twitter sign in crashing iOS. We would like to keep Issues specific, not a general catch all for auth issues 😄. Thanks.

@russellwheatley will do, this was the most closely related issue to the one I was experiencing. Will open a new issue when time allows. I don't have a full repro at the moment because this issue is specific to my company's Microsoft provider setup.

Hello, this is still happening

@abubakarmvp can you open it again

for me this happens when I tried to log with twitter provider when the email already exist. But does not happen on all Iphones

Hey @unacorbatanegra - could you open a new issue with a full reproduction so we can observe and fix the bug you are seeing? Thank you.

Facing the same issue with firebase_auth: ^4.16.0. Does anyone has solution for this ?

Facing the same issue with firebase_auth: ^4.16.0 on real iPhone (Works fine on Android). Does anyone has solution for this ?

Not sure how much use it is to you but we needed up just setting up the flow for the user to manually link their account using either FirebaseAuth.instance.currentUser!.linkWithPopup or FirebaseAuth.instance.currentUser!.linkWithProvider so accounts can still be linked

Facing the same issue with firebase_auth: ^4.16.0 on real iPhone (Works fine on Android). Does anyone has solution for this ?

Not sure how much use it is to you but we needed up just setting up the flow for the user to manually link their account using either FirebaseAuth.instance.currentUser!.linkWithPopup or FirebaseAuth.instance.currentUser!.linkWithProvider so accounts can still be linked

@KarlDaw Thank for your suggestion. But can you share more details about this ? Because I'm using the code below to sign in with Twitter. And at this point there is no currentUser to fetch. The currentUser only return when successfully signed in
if (kIsWeb) {
      return  FirebaseAuth.instance.signInWithPopup(_xFirebaseProvider);
  } else {
    return  FirebaseAuth.instance.signInWithProvider(_xFirebaseProvider);
  }


AttributeError: 'PandasArray' object has no attribute '_str_len'

Hello,
I try to run SigProfilerExtractor with this command: sig.sigProfilerExtractor("matrix", outputfile, inputcatalog, opportunity_genome="GRCh37", exome=True, minimum_signatures=1, maximum_signatures=7, cpu=24)
The input catalog I give is a mutational catalog taken from ftp://ftp.sanger.ac.uk/pub/cancer/AlexandrovEtAl/mutational_catalogs/exomes/Breast/Breast_exomes_mutational_catalog_96_subs.txt
The tool seems to correctly compute the 7 signatures and create all related files. But it fails after the extraction of the last signature with this error message:
Time taken to collect 500 iterations for 7 signatures is 1461.99 seconds
Optimization time is 3.104848623275757 seconds
The reconstruction error is 0.0411, average process stability is 0.91 and
the minimum process stability is 0.63 for 7 signatures

Traceback (most recent call last):
  File "/home/u/u232133/Scripts/mutational_signatures/sigprofiler_denovo_bis.py", line 39, in <module>
    main(sys.argv[1:])
  File "/home/u/u232133/Scripts/mutational_signatures/sigprofiler_denovo_bis.py", line 35, in main
    sig.sigProfilerExtractor("matrix", outputfile, inputcatalog, opportunity_genome="GRCh37", exome=exome, minimum_signatures=1, maximum_signatures=7, cpu=24)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/SigProfilerExtractor/sigpro.py", line 997, in sigProfilerExtractor
    initial_remove_penalty=initial_remove_penalty, refit_denovo_signatures=refit_denovo_signatures, de_novo_fit_penalty=de_novo_fit_penalty, sequence=sequence)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/SigProfilerExtractor/subroutines.py", line 1989, in make_final_solution
    lognote.write("{}\n".format(exposures.iloc[:,exposures.to_numpy().nonzero()[1]]))
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/core/frame.py", line 687, in __repr__
    show_dimensions=show_dimensions,
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/core/frame.py", line 820, in to_string
    return formatter.to_string(buf=buf, encoding=encoding)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/io/formats/format.py", line 914, in to_string
    return self.get_result(buf=buf, encoding=encoding)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/io/formats/format.py", line 521, in get_result
    self.write_result(buf=f)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/io/formats/format.py", line 833, in write_result
    max_len = Series(lines).str.len().max()
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/core/strings/accessor.py", line 2579, in len
    result = self._data.array._str_len()
AttributeError: 'PandasArray' object has no attribute '_str_len'
srun: error: chugen005: task 0: Exited with exit code 1

I looked into the code of subroutines.py and sigpro.py but was not able to find a potential error. My SBS96_De-Novo_refit_Signature_Assignment_log.txt file is filled with:
************************ Stepwise Description of Signature Assignment to Samples ************************

                    ################ Sample 1 #################
############################# Initial Composition ####################################

The 1989 line in subroutines.py is the one in this block:
else:

        # when refilt de_novo_signatures
        if refit_denovo_signatures==True:
            exposureAvg=denovo_exposureAvg
            for g in range(allgenomes.shape[1]):

                # Record information to lognote
                lognote = open(layer_directory+"/Solution_Stats/"+solution_prefix_refit+"_Signature_Assignment_log.txt", "a")
                lognote.write("\n\n\n\n\n                    ################ Sample "+str(g+1)+ " #################\n")

                lognote.write("############################# Initial Composition ####################################\n")
                exposures = pd.DataFrame(exposureAvg[:, g],  index=allsigids).T
                lognote.write("{}\n".format(exposures.iloc[:,exposures.to_numpy().nonzero()[1]]))

                #remove signatures
                exposureAvg[:,g],L2dist,cosine_sim = ss.remove_all_single_signatures(processAvg, exposureAvg[:, g], allgenomes[:,g], metric="l2", \
                           solver = "nnls", cutoff=de_novo_fit_penalty, background_sigs= [], verbose=False)
                if verbose==True:
                    print("############################## Composition After Remove ############################### ")
                    print(pd.DataFrame(exposureAvg[:, g],  index=allsigids).T)
                    print("L2%: ", L2dist)
                lognote.write("############################## Composition After  Remove ###############################\n")
                exposures = pd.DataFrame(exposureAvg[:, g],  index=allsigids).T
                lognote.write("{}\n".format(exposures.iloc[:,exposures.to_numpy().nonzero()[1]]))
                lognote.write("L2 Error %: {}\nCosine Similarity: {}\n".format(round(L2dist,2), round(cosine_sim,2)))
                lognote.close()

        # when use the exposures from the initial NMF

It seems to be the block when cosmic_sigs==False but in sigpro.py, the line calling make_final_solution gives cosmic_sigs=True so I'm a bit lost.
Could you help me to find my error please?
Thanks

public_test.zip
Hello,
I was not able to reproduce the error on my side. Let's try that on your side. Please install the latest version of SigProfilerExtractor in your system. Then download the zip file, extract that and navigate to the folder. Then run the python file inside the folder. Please let me know what happens on your side.
Thanks,
Mishu

Hello,
Thank you for your response.
I tried what you ask and I got this error message:
'''
Traceback (most recent call last):
File "/home/u/u232133/public_test/sigpro.py", line 28, in
run()
File "/home/u/u232133/public_test/sigpro.py", line 22, in run
nnls_add_penalty=nnls_add_penalty, nnls_remove_penalty=nnls_remove_penalty, initial_remove_penalty=initial_remove_penalty, make_decomposition_plots=True, get_all_signature_matrices=False, cpu=-1)
TypeError: sigProfilerExtractor() got an unexpected keyword argument 'cosmic_version'
'''
Also, here are versions I use:
'''
-------Python and Package Versions-------
Python Version: 3.7.6
Sigproextractor Version: 1.1.0
SigprofilerPlotting Version: 1.1.11
SigprofilerMatrixGenerator Version: 1.1.26
Pandas version: 1.0.4
Numpy version: 1.19.2
Scipy version: 1.4.1
Scikit-learn version: 0.23.1
'''
Thank you

Can you please remove the 'cosmic_version' argument in the python file and test it again?

Of course, I got the same error message than before:
Time taken to collect 10 iterations for 3 signatures is 20.56 seconds
Optimization time is 3.9050021171569824 seconds
The reconstruction error is 0.5113, average process stability is 0.96 and
the minimum process stability is 0.9 for 3 signatures

Traceback (most recent call last):
  File "/home/u/u232133/public_test/sigpro.py", line 28, in <module>
    run()
  File "/home/u/u232133/public_test/sigpro.py", line 22, in run
    nnls_add_penalty=nnls_add_penalty, nnls_remove_penalty=nnls_remove_penalty, initial_remove_penalty=initial_remove_penalty, make_decomposition_plots=True, get_all_signature_matrices=False, cpu=-1)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/SigProfilerExtractor/sigpro.py", line 997, in sigProfilerExtractor
    initial_remove_penalty=initial_remove_penalty, refit_denovo_signatures=refit_denovo_signatures, de_novo_fit_penalty=de_novo_fit_penalty, sequence=sequence)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/SigProfilerExtractor/subroutines.py", line 1989, in make_final_solution
    lognote.write("{}\n".format(exposures.iloc[:,exposures.to_numpy().nonzero()[1]]))
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/core/frame.py", line 687, in __repr__
    show_dimensions=show_dimensions,
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/core/frame.py", line 820, in to_string
    return formatter.to_string(buf=buf, encoding=encoding)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/io/formats/format.py", line 914, in to_string
    return self.get_result(buf=buf, encoding=encoding)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/io/formats/format.py", line 521, in get_result
    self.write_result(buf=f)
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/io/formats/format.py", line 833, in write_result
    max_len = Series(lines).str.len().max()
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/core/strings/accessor.py", line 2579, in len
    result = self._data.array._str_len()
AttributeError: 'PandasArray' object has no attribute '_str_len'

I can't reproduce the issue. Could you please download and install the package from the git repository and see if it helps using the following commands:
"""
$git clone https://github.com/AlexandrovLab/SigProfilerExtractor.git
$ cd SigProfilerExtractor
$pip install .
"""

This is working in local on my computer but not remotely on a HPC. I'm going to do a container with sigprofiler for the HPC because I'm not able to identify the problem on the HPC.
Thank very much you for your help.
Would it be possible for you to take a look at my issue on SigProfilerSingleSample?

I had the same error message when using the .describe() method. I fixed the same problem with the following:
pd.set_option("display.max_columns", None)
Possibly something broke with the latest version of pandas whereby the '_str_len' attribute seems to no longer exist.
Before I discovered this fix, I also solved the problem by editing line 844 in the Anaconda3\Lib\site-packages\pandas\io\formats\format.py file (in Windows) from:
max_len = Series(lines).str.len().max()
to:
max_len = len(str(Series(lines).values.max()))
which avoids use of the .len() method, which is the cause of the error being thrown. However I am relatively new to python coding and perhaps editing a package file in this way is considered bad practice!
I am running python 3.8 with anaconda, my version of pandas is 1.2.3.

Hi @Marozi2
Reading the error message, I see the same line of code appearing that caused me problems:
  File "/home/u/u232133/miniconda3/lib/python3.7/site-packages/pandas/io/formats/format.py", line 833, in write_result     max_len = Series(lines).str.len().max()
Try replacing this with
max_len = len(str(Series(lines).values.max()))
This seems to have worked for others who are having the same problem.

Hi @niall0
A big thank you for the solutions you mentioned. I also think it is a bad practice to edit a package file of python so I prefer to avoid that. The weird thing is that I had this issue only when running the tool on a HPC but not on my computer with same config.
Eventually, I've made a docker container with SigProfilerExtractor for the HPC and it works.
Thanks again!


WIP: david/1359-seed words process

Closes #1359
Description:
To be done:

[ ] Use better pathname to gaiacli
[ ] Explain why Next button is disabled when it is
[ ] Make close button work
[ ] Do something with new account information when received in main process
[ ] implement Import with Seed window

[ ] Added entries in CHANGELOG.md with issue # and GitHub username
[ ] Reviewed Files changed in the github PR explorer

Closing the PR until doing it. Leaving the branch


no-input-rename should be configurabile

Sometimes you want to align an input name with a common, well-known HTML attribute, such as aria-. There are two ways I see this can be configured to allow some (sensible) freedom.
Allow a certain prefix
We could allow users to list prefixes (such as "aria") in their config file which would allow all @Input('aria-*') renames.
Allow change to kebab-case
This might make even more sense, and my vote goes to this one (unless we decide to do both). We allow renaming the input when all it does is changing from camelCase to kebab-case:
@Input('aria-label') ariaLabel: string; // should be allowed with this config

This seems like a pretty sensible solution to me and doesn't clash with the rationale behind the rule:

Two names for the same property (one private, one public) is inherently confusing.

Here's another related issue https://github.com/mgechev/codelyzer/issues/224.

Allow change to kebab-case

Since the Angular compiler is case sensitive and the recommendation for naming attributes (from directive selectors) is to use camelCase literals, I'm not sure we should go this way.
Maybe, developers can provide key-value pairs of propertyName: rename as a whitelist. Ones the property name matches the propertyName value and the new name matches the rename, we can ignore the rule. This covers both cases from above with a bit more explicitness.
What do you think?

Personally, I dislike too much lint configuration. If you think you have a valid reason to break the rule a lot, you should just disable it in my opinion.
Whitelisting renames is pretty much disabling a next line with a source code comment. Otherwise it would require changing the lint configuration a lot during development, which shouldn't be the case. Config should stay more or less the same and not change frequently.

Whitelisting renames is pretty much disabling a next line with a source code comment. Otherwise it would require changing the lint configuration a lot during development, which shouldn't be the case. Config should stay more or less the same and not change frequently.

Yep, I agree. Let's keep the rule as it is for now.

I think it should configurable, too. Best example is a component having the input class which sets class in html. But variable class is reserved.
@Input() src: string;
@Input('class') classes: string;
@Input() alt = '';

<img [src]="src" [class]="classes" [alt]="alt">


Add built-in support for HF transformers models

Hey @salvaRC et al! First of all, thanks for your amazing work and making it publicly available + providing very decent documentation on how to use and extend it :) I think @dvsrepo already spoke to you about our intention to add built-in support for HF transformers model to your amazing project, so here comes the PR.
It is basically based on our weak supervision guide, with a few improvements and using a lightning data module. I tested the new implementation with our guide and the results are identical, so it should be working alright. Needless to say, that with this new implementation our guide looks a lot slicker!
Please let me know if you have any questions about the implementation, or if you have ideas/comments on how to improve it. Actually, I am unsure about what to return in the DownstreamBaseModel.get_encoder_features() method. For now, I simply return the token IDs, but maybe the embeddings (if possible) would be more helpful for weasel's encoder, even though they change during training. What do you think?
Looking forward to working with you!

Hi @salvaRC sorry for pinging you again! Just wondering if you got a chance to look into this?

Hi David! Yes, this is great! Thanks for this very nice addition and documentation (+ for the follow-up)! :).
DownstreamBaseModel.get_encoder_features() is an optional function (only used when the flag/h-param use_aux_features_for_encoder is set to True) that may return any sample/datapoint-dependent information that could be useful for the encoder model (e.g. to differentiate between samples which might have received the same labeling function outputs). This could be the same features used by the downstream model, or some intermediate representation of it. Currently it needs to be 1D/a vector, as the encoder is an MLP.


Unable to publish Kover code coverage report as a comment in pull requests

Running into this issue and wondering if any recent changes has caused this.
My action is available here
HttpError: Resource not accessible by integration
    at /home/runner/work/_actions/mi-kas/kover-report/v1/webpack:/kover-report/node_modules/@octokit/request/dist-node/index.js:86:1
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Hi @xxfast! Thanks for bringing this issue up. I think this is related to some missing permissions for the action in your repo. Could you try to add the "pull-request: write" permission to your check job and let me know if this solves the issue?
jobs:
  check:
    runs-on: ubuntu-latest
    permissions:
      pull-requests: write

Yup, that worked 🙌
I wonder if this is a recent change. This could also be because I recently added permissions to the top level.
Either way - this is now solved!


[merge] inconsistent diff chunk calculation between left and right side

When the the following 3 files are used in the 3-way merge view, inconsistent alignment is seen when connect='align' and with a missing diff on the right side when connect is not set to 'align'.
Line 3 on the left corresponds to line 5 in the middle and line 3 on the right. But in the 3-way view, with connect=align, line 3 on the left is aligned with line 3 in the middle, but line 3 on the right is aligned with line 5 in the middle. Without connect=align, line 3 on the left matches to lines 3-5 in the center, and line 3-4 in the middle matches to an empty chunk just before line 3 on the right.
It seems to me that this layout is occurring because the diff isn't noticing that line 5 in the middle is the same as line 3 on both the left and right; it only sees it on the right side.
20161129-left.txt
20161129-middle.txt
20161129-right.txt

This appears to be a bug in the diff_match_patch library. It goes away if I avoid calling the diff_cleanupSemantic, which I mostly did because it sounded like the right thing, so attached patch drops that call.

This might related to https://code.google.com/p/google-diff-match-patch/issues/detail?id=67

Probably. That project seems quite dead now, but unfortunately it's still much faster than any alternatives I could find, so switching isn't easy.

I know, just as a reminder 😄


DNSMasq service start/restart policy

I’m running this playbook to service DNS on a VPN server. I’m binding DNSMasq to the VPN interface. This works as expected until I reboot the server. The interface for the VPN is not always up before the DNS service is started.
The easiest thing I could come up with is to just set the restart policy to always restart. Another solution would be to allow us to set the dependencies for the service file (after: wg-quick@whatever).
This would require a custom service file I imagine.
What’s your opinion on this? Should I just edit the service file on disk and be done with it? Or is this something you would consider adding to the role?

Dear @Miesvanderlippe!
I have a similar problem with openVPN and SSH ...
In general, this should be integrated into the role, as manual changes should be unnecessary due to automation.
I will probably create a custom service file here and publish it as a new release.

Hi  @Miesvanderlippe
Please try the latest release!


Further corrections to level arc reading

Turns out my formula was slightly off - 180° corresponds to playerLevel+2 (the highest Pokemon level allowed by the server), not playerLevel+1.5 (the highest normally reachable in the game without cheating). This was masked by a 178-to-180 degree conversion in the level angle feedback.
The code for detecting the white spot on the arc was also rewritten, as the old code tended to bias upwards from the real angle after correcting for the extra server-side powerup.

Cool, I've fixed the CI. The test passes now.


Incoming offers are not accepting

I changed only these lines in the example (storehouse), because I need to accept all offers:
...
if (offer.trade_offer_state == 2){
offers.acceptOffer({tradeOfferId: offer.tradeofferid});
console.log('Ok!');
}
...
it worked perfectly, but now no longer.
It is written in the console OK, but the offer is not accepted

Use the callback. Your code will always print 'Ok!', event if it fails.
https://github.com/Alex7Kom/node-steam-tradeoffers#acceptofferoptions-callback

I'm noob at this , please write the code , if not difficult, thanks!

https://github.com/Alex7Kom/node-steam-tradeoffers/issues/121

i edit my code like this:
if (offer.trade_offer_state == 2){
          offers.acceptOffer({tradeOfferId: offer.tradeofferid}, callbackoffer);
		  console.log( callbackoffer );

      }

and received this:

sorry if i'm wrong, but i think steam is changin somthing in trade api ...

getOffers returns an error for a reason. USE IT!
offers.getOffers({
    get_received_offers: 1,
    active_only: 1,
    time_historical_cutoff: Math.round(Date.now() / 1000)
}, function(err, body) {
    if (err) throw err;
    // your code here...


Add a substring modification

I sometimes get "yes" or "no" inputs, but I'm only interested in the first character ("y" or "n"). I think substring will be a handy addition, as it'll allow users of this library to discard or keep a certain amount of characters of their input.
I implemented substring with the following rules:
Tag syntax: substr:start[-end]

start and end is 0-indexed
If end is left unspecified, the substring will be taken from start to the end of the input.
If neither values are specified, the tag does nothing.
If start is greater than or equal to the length of the input, an empty string is returned.
The same happens if start is greater than or equal to end.
If end is greater than or equal to the length of the input, the substring is taken from start to the end of the input.

I think these rules are robust, intuitive, and simple for the client code to use.

Coverage decreased (-0.7%) to 95.161% when pulling 81088fece2dfb62a990e504a04c2eda025903549 on arieroos:master into 9a50f08cad9037372bb68c33285e5ffeafb59cde on go-playground:master.


Wild card search doesn't highlight a matching word.

For the below snippet, I can search with abc* to find abc.def.xyz.Util, but I don't see a highlight for the matching area.
```java
import abc.def.xyz.Util;

class InternationalPriceService implements PriceService {
    private static void LongJavaInterfaceNameWithSuperFactory createMegaAbstractFactory(final ExchangeCalendarLongerThanLife calendar) {
        ...
    }
}
```

Are you talking about search in the docs? I didn’t realize it supports *.

Yes, for the example, I can't search with "abc", "def", or "xyz" to find abc.def.xyz.Util, but I can use a wild card as described in https://lunrjs.com/guides/searching.html.

Got it. We probably should fix the problem of lunr not splitting/tokenizing dotted code right.

Debugged a bit more - the current issue is the code snippets have tokens split in different <span> block. Current highlight logic only highlight within a single html node.

@byc1234 did some changes, could you please check?


apktool build "-d" option (Sets android:debuggable to "true") does not work

Information

Apktool Version (apktool -version) - 2.2.4
Operating System (Mac, Linux, Windows) - Windows
APK From? (Playstore, ROM, Other) - N/A

The option that is not working is:
usage: apktool [-q|--quiet OR -v|--verbose] b[uild] [options] <app_path>
...
 -d,--debug              Sets android:debuggable to "true" in the APK's compiled manifest
...

When the option is specified in the apktool arguments, it is processed at:
apkOptions.debugMode = true;
Ref: https://github.com/iBotPeaches/Apktool/blob/212330e0c990b69a948aff4027190177fe217f81/brut.apktool/apktool-cli/src/main/java/brut/apktool/Main.java#L203
This value is used at:
ResXmlPatcher.removeApplicationDebugTag(new File(appDir, "AndroidManifest.xml"));
Ref: https://github.com/iBotPeaches/Apktool/blob/212330e0c990b69a948aff4027190177fe217f81/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java#L461
This method is in fact removing the "android:debuggable" item from the AndroidMAnifest.xml file, rather than setting it to "true".
Ref: https://github.com/iBotPeaches/Apktool/blob/212330e0c990b69a948aff4027190177fe217f81/brut.apktool/apktool-lib/src/main/java/brut/androlib/res/xml/ResXmlPatcher.java#L69
Steps to Reproduce

apktool d app.apk
apktool b -d <app_dir>

Questions to ask before submission

Have you tried apktool d, apktool b without changing anything? Yes
If you are trying to install a modified apk, did you resign it? N/A
Are you using the latest apktool version? Yes

So, we remove the element yes, but thats because we apply the debuggable trait at the aapt level. If you leave the property in, aapt fails. So we strip it out in debug mode, so that we know aapt can properly add.
I'm not sure if you discovered this in a code audit, but I tested with an actual application and could not replicate this.
I did a simple decode/build to test this and it worked.
➜  dist aapt d xmltree app-debug.apk AndroidManifest.xml
    E: application (line=3)
      A: android:theme(0x01010000)=@0x7f0900a6
      A: android:label(0x01010001)=@0x7f070022
      A: android:icon(0x01010002)=@0x7f030000
      A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff

Closing as I couldn't duplicate. Thanks for the detailed report, makes my life a lot easier when digging into tickets.
You can see the line responsible here - https://github.com/iBotPeaches/Apktool/blob/master/brut.apktool/apktool-lib/src/main/java/brut/androlib/res/AndrolibResources.java#L365

Hi @iBotPeaches:
I have been able to reproduce this issue based on your explanation. The debuggable flags is not added when the APK is decoded first with the "-r" flag, as the resources are not decoded and, therefore, "aapt" cannot add the flag during the build process.
I think it would be very useful to be able to use the "-d" flag during the build process even when the "-r" (and "-s") flags are used during the decoding process, with the goal of minimizing the changes performed over the APK.
I was originally expecting this, assuming that apktool was simply and directly modifying the AndroidManifest.xml file, rather than using "aapt".
Do you think this could be considered as a potential future request for apktool to be able to run "apktool d -r -s app.apk" and "apktool b -d <app_dir>"?

@raulsiles @iBotPeaches this would be just what I am looking for. For some reason repackaging without -r fails

after I use Apktool v2.2.1 When change manifest and add android:debuggable="true" and build again, the manifest not change? why
1.apktool d main.apk
2.change manifest and add android:debuggable="true"
3.apktool b main


Docker container fails to start when mapping /home/node/app/tmp to a directory

Which version are you using?
latest/docker hub digest fa47c9c4c054
Which operating system are you using?

[ ] Linux amd64 standard
[x ] Linux amd64 Docker
[ ] Linux arm64 standard
[ ] Linux arm64 Docker
[ ] macOS amd64 standard
[ ] macOS amd64 Docker
[ ] Other (please describe)

Describe the issue
When mapping /home/node/app/tmp to a directory, the container will fail to start with the following error:
node:events:497
      throw er; // Unhandled 'error' event
      ^

Error: listen EACCES: permission denied /home/node/app/tmp/ipc.sock
    at Server.setupListenHandle [as _listen2] (node:net:1880:21)
    at listenInCluster (node:net:1945:12)
    at Server.listen (node:net:2054:5)
    at IPCService.boot (file:///home/node/app/app/services/ipc.js:58:22)
    at async AppProvider.boot (file:///home/node/app/providers/app_provider.js:75:13)
    at async ProvidersManager.boot (file:///home/node/app/node_modules/@adonisjs/application/build/chunk-WIOBO4NG.js:884:9)
    at async Application.boot (file:///home/node/app/node_modules/@adonisjs/application/build/chunk-WIOBO4NG.js:1266:5)
    at async HttpServerProcess.start (file:///home/node/app/node_modules/@adonisjs/core/build/src/ignitor/http.js:101:9)
Emitted 'error' event on Server instance at:
    at emitErrorNT (node:net:1924:8)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  code: 'EACCES',
  errno: -13,
  syscall: 'listen',
  address: '/home/node/app/tmp/ipc.sock',
  port: -1
}

Describe how to replicate the issue

Run the app using docker with /home/node/app/tmp mapped to a directory. The container will fail to run with the above error.
Setting the permissions on the dir to something wide open (e.g. 777) allows the container to launch.
Did you attach the server logs?

yes

Further info:
$ docker exec -it nestmtx /bin/sh
~/app $ cat /etc/passwd
...
node:x:1000:1000:Linux User,,,:/home/node:/bin/sh

The uid/gid of the node user within the container appears to be 1000. Unsure if this is reliably persistent across instances.
However, setting the owner to my own user (which is uid/gid 1000 on my local system) allowed the container to launch without error.

Confirmed that using a non-bind mount also resolved the permissions issue:
services:
...
  nestmtx:
    container_name: nestmtx
    restart: unless-stopped
    image: nestmtx/amd64:latest
    volumes:
      - nestmtx:/home/node/app/tmp
...
volumes:
  nestmtx:

I'm unsure if there's an easy way to use a bind volume instead due to mismatched uid/gids, but a non-bind volume is fine for my use case - I'll just have to be careful not to rm the volume.

In the updated documentation there will be a section which describes how to integrate the folder permissions correctly in both the Docker and Docker Compose instructions.


remove authentication code

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

17 of 20 (85.0%)  changed or added relevant lines in 5 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+9.9%) to 39.153%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

grpcutil/middlewares/gerr/gerr_middleware.go
1
2
50.0%

grpcutil/middlewares/tracing/tracing_middleware.go
0
2
0.0%

Totals

Change from base Build<PHONE_NUMBER>:
9.9%

Covered Lines:
148

Relevant Lines:
378

💛  - Coveralls


Update to use react-relay-network-modern/es?

Would it be possible to release a new version that has ES6 modules, perhaps under react-relay-network-modern-ssr/es? These could use the equivalent modules from react-relay-network-modern/es.

This would be very helpful.


Link profile
<EMAIL_ADDRESS>

Link to<EMAIL_ADDRESS>

`> Link to<EMAIL_ADDRESS>`


Remove verbose warnings in test output

A fix for issue #976.
This removes most of the verbose warnings shown when running rake test.

Thanks!

Hey @asartalo thanks for your PR. Can you paste a screenshot of how many warnings are showing now? This is a really small commit so if we're going to a pay a bounty on this ticket, we'd want to have almost all warnings removed.

@zachfeldman we can just check the travis output.
Looks like there are still a couple of outstanding issues.
In this case it's logging an omniauth failure when we are testing the handling of the failure:
E, [2017-12-22T23:06:04.822416 #5994] ERROR -- omniauth: (facebook) Authentication failure! invalid_credentials encountered.

It would be nice to silence the omniauth warnings.
The other warning is an actual issue that we should fix:
DEPRECATION WARNING: Locking a record with unpersisted changes is deprecated and will raise an exception in Rails 5.2. Use `save` to persist the changes, or `reload` to discard them explicitly. (called from update_auth_header at /home/travis/build/lynndylanhurley/devise_token_auth/app/controllers/devise_token_auth/concerns/set_user_by_token.rb:105)

Should be an easy fix.

Thanks @lynndylanhurley ! @asartalo I'd use that comment as a guideline for how to proceed.

Thanks! I actually got here through the bounty system and it's my first time. After finding out how to go about this, I didn't know if I should even claim the bounty because the fix may have been too small. I'll work on it right away.

There should no longer be unnecessary messages after this. Should I squash all commits into 1?

Should I squash all commits into 1?

I think the commits look great. Thanks @asartalo!

@asartalo much better! If we remove silencing warnings though, are there still a lot of warnings?

@asartalo to clarify....does the silencing line silence any legit warnings? Would there be ways to remove those warnings entirely rather than just silencing them?

If we remove the t.warning = false on the Rakefile then these are all the warnings that appear (sorted, removing duplicates):
~/.rvm/gems/ruby-2.4.2/bundler/gems/omniauth-facebook-19634473820d/lib/omniauth/strategies/facebook.rb:79: warning: instance variable @authorization_code_from_signed_request_in_cookie not initialized
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old api_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old api_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old api_v2_scoped_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old api_v2_scoped_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_api_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_api_v2_scoped_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_evil_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_lockable_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_mang
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_nice_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_only_email_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_unconfirmable_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_unregisterable_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old current_user
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old evil_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old evil_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old lockable_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old lockable_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old mang_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old mang_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old nice_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old nice_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old only_email_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old only_email_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old render_authenticate_error
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old unconfirmable_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old unconfirmable_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old unregisterable_user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old unregisterable_user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old user_session
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old user_signed_in?
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of api_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of api_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of api_v2_scoped_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of api_v2_scoped_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_api_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_api_v2_scoped_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_evil_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_lockable_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_mang was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_nice_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_only_email_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_unconfirmable_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_unregisterable_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of current_user was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of evil_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of evil_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of lockable_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of lockable_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of mang_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of mang_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of nice_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of nice_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of only_email_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of only_email_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of render_authenticate_error was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of unconfirmable_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of unconfirmable_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of unregisterable_user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of unregisterable_user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of user_session was here
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: previous definition of user_signed_in? was here
~/.rvm/gems/ruby-2.4.2/gems/activesupport-5.1.4/lib/active_support/core_ext/class/attribute.rb:90: warning: previous definition of default_url_options was here
~/.rvm/gems/ruby-2.4.2/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292: warning: loading in progress, circular require considered harmful - /Users/wayne/.rvm/gems/ruby-2.4.2/gems/guard-2.14.1/lib/guard.rb
~/.rvm/gems/ruby-2.4.2/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292: warning: loading in progress, circular require considered harmful - /Users/wayne/.rvm/gems/ruby-2.4.2/gems/guard-2.14.1/lib/guard/guardfile/evaluator.rb
~/.rvm/gems/ruby-2.4.2/gems/activesupport-5.1.4/lib/active_support/dependencies.rb:292: warning: loading in progress, circular require considered harmful - /Users/wayne/.rvm/gems/ruby-2.4.2/gems/guard-minitest-2.4.6/lib/guard/minitest.rb
~/.rvm/gems/ruby-2.4.2/gems/attr_encrypted-3.0.3/lib/attr_encrypted/adapters/active_record.rb:61: warning: shadowing outer local variable - options
~/.rvm/gems/ruby-2.4.2/gems/devise-4.3.0/lib/devise/failure_app.rb:27: warning: method redefined; discarding old default_url_options
~/.rvm/gems/ruby-2.4.2/gems/devise-4.3.0/lib/devise/models/confirmable.rb:297: warning: instance variable @reconfirmation_required not initialized
~/.rvm/gems/ruby-2.4.2/gems/devise-4.3.0/lib/devise/rails/routes.rb:486: warning: previous definition of set_omniauth_path_prefix! was here
~/.rvm/gems/ruby-2.4.2/gems/devise-4.3.0/lib/devise/rails/warden_compat.rb:2: warning: method redefined; discarding old request
~/.rvm/gems/ruby-2.4.2/gems/devise-4.3.0/lib/devise/rails/warden_compat.rb:6: warning: method redefined; discarding old reset_session!
~/.rvm/gems/ruby-2.4.2/gems/faker-1.7.3/lib/faker/omniauth.rb:290: warning: mismatched indentations at 'end' with 'class' at 14
~/.rvm/gems/ruby-2.4.2/gems/hashie-3.5.5/lib/hashie/mash.rb:86: warning: instance variable @disable_warnings not initialized
~/.rvm/gems/ruby-2.4.2/gems/omniauth-1.6.1/lib/omniauth/failure_endpoint.rb:28: warning: previous definition of redirect_to_failure was here
~/.rvm/gems/ruby-2.4.2/gems/omniauth-1.6.1/lib/omniauth/strategy.rb:282: warning: previous definition of mock_callback_call was here
~/.rvm/gems/ruby-2.4.2/gems/warden-1.2.7/lib/warden/mixins/common.rb:18: warning: previous definition of request was here
~/.rvm/gems/ruby-2.4.2/gems/warden-1.2.7/lib/warden/mixins/common.rb:39: warning: previous definition of reset_session! was here
~/Projects/ruby/devise_token_auth/app/controllers/devise_token_auth/concerns/set_user_by_token.rb:68: warning: instance variable @resource not initialized
~/Projects/ruby/devise_token_auth/app/controllers/devise_token_auth/omniauth_callbacks_controller.rb:113: warning: previous definition of omniauth_window_type was here
~/Projects/ruby/devise_token_auth/app/controllers/devise_token_auth/omniauth_callbacks_controller.rb:123: warning: method redefined; discarding old omniauth_window_type
~/Projects/ruby/devise_token_auth/app/controllers/devise_token_auth/omniauth_callbacks_controller.rb:175: warning: instance variable @oauth_registration not initialized
~/Projects/ruby/devise_token_auth/app/models/devise_token_auth/concerns/user.rb:222: warning: assigned but unused variable - expiry
~/Projects/ruby/devise_token_auth/app/models/devise_token_auth/concerns/user.rb:64: warning: instance variable @raw_confirmation_token not initialized
~/Projects/ruby/devise_token_auth/app/views/devise_token_auth/omniauth_external_window.html.erb:18:in `___sers_wayne__rojects_ruby_devise_token_auth_app_views_devise_token_auth_omniauth_external_window_html_erb__3797081075666656403_70270696309080': warning: URI.escape is obsolete
~/Projects/ruby/devise_token_auth/devise_token_auth.gemspec:19: warning: character class has duplicated range: /[.log|.sqlite3]$/
~/Projects/ruby/devise_token_auth/lib/devise_token_auth/controllers/helpers.rb:134: warning: method redefined; discarding old render_authenticate_error
~/Projects/ruby/devise_token_auth/lib/devise_token_auth/controllers/helpers.rb:134: warning: previous definition of render_authenticate_error was here
~/Projects/ruby/devise_token_auth/lib/devise_token_auth/engine.rb:57: warning: method redefined; discarding old redirect_to_failure
~/Projects/ruby/devise_token_auth/lib/devise_token_auth/engine.rb:71: warning: method redefined; discarding old mock_callback_call
~/Projects/ruby/devise_token_auth/lib/devise_token_auth/rails/routes.rb:110: warning: method redefined; discarding old set_omniauth_path_prefix!
~/Projects/ruby/devise_token_auth/test/controllers/devise_token_auth/omniauth_callbacks_controller_test.rb:21:in `get_parsed_data_json': warning: URI.unescape is obsolete
~/Projects/ruby/devise_token_auth/test/controllers/devise_token_auth/registrations_controller_test.rb:180:in `block (3 levels) in <class:RegistrationsControllerTest>': warning: URI.unescape is obsolete
~/Projects/ruby/devise_token_auth/test/controllers/devise_token_auth/registrations_controller_test.rb:260: warning: instance variable @fav_color not initialized
~/Projects/ruby/devise_token_auth/test/controllers/overrides/confirmations_controller_test.rb:37:in `block (2 levels) in <class:ConfirmationsControllerTest>': warning: URI.unescape is obsolete

We can probably work on stuff on the devise_token_auth side but the rest is on the libraries.

Thanks @asartalo ! @lynndylanhurley what do you think of these warnings?

It looks like they should all be ignored. I'll just go through some of the different types:
~/.rvm/gems/ruby-2.4.2/gems/attr_encrypted-3.0.3/lib/attr_encrypted/adapters/active_record.rb:61: warning: shadowing outer local variable - options

^ this is a code-smell thing that should be fixed, but it's in another gem and completely outside of our control. There are several issues like this that are caused by external dependencies.
~/.rvm/gems/ruby-2.4.2/gems/actionpack-5.1.4/lib/abstract_controller/helpers.rb:67: warning: method redefined; discarding old api_user_session

^ a method was redefined (intentionally). There are a ton of these warnings, and in each case it's intentional.
~/Projects/ruby/devise_token_auth/app/controllers/devise_token_auth/concerns/set_user_by_token.rb:68: warning: instance variable @resource not initialized

^ an instance variable was not initialized before it was used. The result is that it evaluates to nil, which is what we're expecting in each case. I fixed several of these by setting the initial value to nil, but I'm not sure if there is any benefit to doing so.
~/Projects/ruby/devise_token_auth/test/controllers/devise_token_auth/omniauth_callbacks_controller_test.rb:21:in `get_parsed_data_json': warning: URI.unescape is obsolete

^ I've looked into this, and from what I can tell this warning is due to the method not following some kind of spec. It seems like this will eventually be resolved internally by the URI library, but the way we call the method will remain the same. So there's nothing we can do. Someone please correct me if I'm wrong about this.
And from what I can tell that's it. These warnings seem like they should be ignored. Am I missing anything?

Nope sounds good! Gonna merge this @lynndylanhurley


Updated Localization

Take 2!
Original:
I've updated the localization for the built-in plugins. It uses resource files like the other strings.
I've also translated the wiki, which is located at my own repo here:
https://github.com/veroxzik/Ched/wiki
(Git link: https://github.com/veroxzik/Ched.wiki.git)
I would appreciate it if you could review and merge into yours :)

Thank you for re-opening #39, I really appreciate it!
I've just merged this PR and the Wiki.
I rebased commits that you created on the Wiki into current my master branch.
The author of them has your data :)


Setting 'Cisco ISE' for splashPage in updateNetworkWirelessSsid

In code documentation says this is a valid option but I get;
AssertionError: "splashPage" cannot be "Cisco ISE", & must be set to one of: ['None', 'Click-through splash page', 'Billing', 'Password-protected with Meraki RADIUS', 'Password-protected with custom RADIUS', 'Password-protected with Active Directory', 'Password-protected with LDAP', 'SMS authentication', 'Systems Manager Sentry', 'Facebook Wi-Fi', 'Google OAuth', 'Sponsored guest']
Tried first with updateNetworkWirelessSsidSplashSettings with splashMethod = 'Cisco ISE' first and same issue.
Running this version;
(base) [z3roCoo1@machine]$ pip freeze | grep meraki meraki==1.0.0

Ignore this. Upgraded to 1.10.0 and the issue went away, imagine that!


Road to CalendarView

For the last week or so, ive been working on a Calendar/Datepicker component for fluent-svelte. It's being developed in an isolated repo here. There are a few things that need to be ironed out, notably some a11y insights and page transitions, as well as some missing functionality. Thought I might track that here:

[x] Complete reliance on the Intl.DateTimeFormat API and no additional date libraries.
[x] Localization quirks. (controlling first day of week)
[x] Minimum/Maximum dates.
[x] Multiple values/selections.
[x] Keyboard navigation.
[x] Option to label each item as the start of a new month.
[x] Excluding certain dates (believe WinUI calls these "blackout" dates).
[x] Standalone CalendarViewItem component.
[x] Remove the temporary styling and integrate it with fluent styles.
[ ] Paging stuff and animations.

Stretches - Very likely won't happen.

Non-gregorian calendar layouts Probably not possible due to how the Dates work atm.
Eventual Temporal support? Probably shouldn't even include this due to the spec not being supported anywhere.
Progressive enhancement. Probably won't happen since date inputs don't map to what i'm trying to accomplish here.

So everything except for the page slide animation is done. I had a prototype of it working, although it was janky when switching between pages and the other solutions aren't especially easy. I think I might look into how svelte-calendar handles their infinite scroller, although that might come along later.

I might put a temporary animation in place for now, then track this in a separate issue.


Document insert scaling of UUID (well distributed) vs Serial

Distribution of workload affecting scaling.  This is a simple example of insert.  UUID is well distributed.  Serial is sequentially increasing.  Serial will cause localized hotspot that will prevent scaling at high concurrency.  Below is a short sample of the scaling.

TODO: sysbench script procedure used to produce the result set above.

@robert-s-lee
What workload is the performance degradation on the graph you shared? If you let me know, I'll take a closer look.

At first, I thought the speed of the 'GenerateUniqueInt' function was a problem, but I don't think so.

To reproduce the graph you shared, I changed the code and measured the performance as below.
builtins.go:
func GenerateUniqueID(nodeID int32, timestamp uint64) tree.DInt {
...
id := (uint64(nodeID) << TimestampBits) ^ timestamp

But there has been no significant result, and @bdarnell's comment will remains valid.

Performance Measurement Results

insert 1600 row with 16 goroutine.
machine: AWS c5d.4xlarge(16 vCPU) X 3
mesure code: https://github.com/hueypark/swarm/blob/master/benchmark/issue4234_test.go

current
BenchmarkIssue4234/100-16         	       2	 769922108 ns/op
BenchmarkIssue4234/100#01-16      	       2	 740884949 ns/op
BenchmarkIssue4234/100#02-16      	       2	 794033482 ns/op
BenchmarkIssue4234/100#03-16      	       2	 778814176 ns/op
BenchmarkIssue4234/100#04-16      	       2	 734334384 ns/op
BenchmarkIssue4234/100#05-16      	       2	 732287343 ns/op
BenchmarkIssue4234/100#06-16      	       2	 718965703 ns/op
BenchmarkIssue4234/100#07-16      	       2	 750783191 ns/op
BenchmarkIssue4234/100#08-16      	       2	 717592265 ns/op
BenchmarkIssue4234/100#09-16      	       2	 754199910 ns/op
BenchmarkIssue4234/100#10-16      	       2	 779262461 ns/op
BenchmarkIssue4234/100#11-16      	       2	 742781762 ns/op
BenchmarkIssue4234/100#12-16      	       2	 755679509 ns/op
BenchmarkIssue4234/100#13-16      	       2	 760276421 ns/op
BenchmarkIssue4234/100#14-16      	       2	 752905362 ns/op
BenchmarkIssue4234/100#15-16      	       2	 740751411 ns/op
BenchmarkIssue4234/100#16-16      	       2	 753700862 ns/op
BenchmarkIssue4234/100#17-16      	       2	 732161154 ns/op
BenchmarkIssue4234/100#18-16      	       2	 762167341 ns/op
BenchmarkIssue4234/100#19-16      	       2	 781000318 ns/op
BenchmarkIssue4234/100#20-16      	       2	 728199898 ns/op

changed
BenchmarkIssue4234/100-16         	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#01-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#02-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#03-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#04-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#05-16      	       2	 995622749 ns/op
BenchmarkIssue4234/100#06-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#07-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#08-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#09-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#10-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#11-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#12-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#13-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#14-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#15-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#16-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#17-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#18-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#19-16      	       1<PHONE_NUMBER> ns/op
BenchmarkIssue4234/100#20-16      	       1<PHONE_NUMBER> ns/op

@hueypark yes, the issue is not the speed of generating the numbers, but the sequential nature of the generated numbers tend to create a rolling CPU hotspot when the row is inserted into the database.  This behavior can be observed in AdminUI's hardware tab CPU usage.  Even though the application is connected to all 3 nodes CRDB nodes, one node's CPU will be higher than other nodes.  this can be seen when even using 4 vCPUs systems.   All of the inserts will be performed on a single node.
the original curve was created by modifying sysbench to use uuid and serial.
https://github.com/cockroachdb/docs/issues/4221 has a small script to run sysbench.  CRDB serial is mostly sequential.
When using uuid, alter table t1 split at select gen_random_uuid() from generate_series(1, 16);   alter table t1 scatter; can be used to pre-split the ranges so that ranges can be evenly distributed.
When using serial, the split will still group the range of keys generated at the same time to a single node creating the hotspot.  with the nodeid is the significant bits, the split can be run on the  (uint64(nodeID) << TimestampBits) so that inserts going to that node are localized to that node.
For testing the modified serial, try the following alter table t1 split at select generate_series(1, 16)<<TimestampBits::bigint; alter table t1 scatter; .  replace TimestampBits with the number of bits shifted to match the code.   With the modified serial, all of the inserts will be performed on separate nodes and the CPU usage should be even across the nodes.
More advanced usage to try later is with geo-partitioned data.  CRDB partition command can be used to control the ranges created by the node.  This strategy is used to scale opensource YCSB Copy and paste shown below of YCSB.    The partition command requires an enterprise license.
ALTER TABLE PARTITION BY RANGE (ycsb_key) (
  PARTITION user0 VALUES FROM (MINVALUE) TO ('user001'),
  PARTITION user1 VALUES FROM ('user001') TO ('user002'),
  PARTITION user2 VALUES FROM ('user002') TO ('user003'),
  PARTITION user3 VALUES FROM ('user003') TO ('user004'),
  PARTITION user4 VALUES FROM ('user004') TO ('user005'),
  PARTITION user5 VALUES FROM ('user005') TO ('user006'),
  PARTITION usermaxvalue VALUES FROM ('user006') TO (MAXVALUE)
);

@robert-s-lee I see! Your intention was not to change the implementation of unique_rowid, but to provide scaling of UUID(well distributed) vs Serial document. Thank you for your response.

Closing this since we have guidance in our docs on this topic at this point:

https://www.cockroachlabs.com/docs/v21.1/sql-faqs#how-do-i-auto-generate-unique-row-ids-in-cockroachdb
https://www.cockroachlabs.com/docs/v21.1/sql-faqs#how-do-i-generate-unique-slowly-increasing-sequential-numbers-in-cockroachdb
https://www.cockroachlabs.com/docs/v21.1/sql-faqs#what-are-the-differences-between-uuid-sequences-and-unique_rowid

@awoods187, @mwang1026, if you think it's important to supplement our docs with a demonstration, please reopen.


➖ Move nbproject to extra dependencies

subj
This requires releases of https://github.com/laminlabs/lnschema-core and https://github.com/laminlabs/readfcs

Thank you! This is great!


Log changes

Hi @Mkatari3700 , Does this change replace all occurrences of console.writeLine in sdk to logger?

Hi @Mkatari3700 , Does this change replace all occurrences of console.writeLine in sdk to logger?

Yes, Manan we changed all writeline to loggers


xrdb colors not being set by wal -r in xinitrc

Pywal is working well when I login and run wal -R. However, I'm having trouble getting it to work automatically on startx. I have wal -R in my xinitrc, however, things like polybar which trys to set colors from xrdb are not receiving the wal colors and instead are using the fallback colors. Similarly, my wallpaper is not being set (feh is installed).
.xinitrc
wal -R &

xset +fp /home/david/.local/share/fonts
xset fp rehash

picom -b

exec /usr/bin/i3

I'm running ubuntu 20.04 on a dell XPS 9500

Try not sending wal to the background: wal -R not wal -R &.


Error when trying to grab object with mesh collider

I'm using VRTK with Unity 2017.1.1f1, SteamVR and my HTC Vive.
I want to grab objects with a mesh collider, therefore I added the "VRTK_InteractGrab" script to the controllers and the "VRTK_InteractableObject" script, "VRTK_FixedJointGrabAttach" script, a kinematic rigid body (gravity off) and a non-convex mesh collider to the game object.
When I try to grab an object, I get the error "Non-convex MeshCollider with non-kinematic Rigidbody is no longer supported in Unity 5."
The collider has to be non-convex, so what can I do about it? Are the controllers kinematic?

You haven't followed the issue template. This will be closed if the template isn't followed.


Reminder dialog display for RNAScope/IHC template

My reading of Katy's request is that she just wants the message changing to "If you have submitted an RNAScope/IHC request, please complete the template for probes/antibody and fluorophore here, and upload it to STAN on the file management page linked to your request number."

My reading of Katy's request is that she just wants the message changing to "If you have submitted an RNAScope/IHC request, please complete the template for probes/antibody and fluorophore here, and upload it to STAN on the file management page linked to your request number."

So, you mean it is not required to display as a pop-up dialog(modal)?

I don't think so.

I don't think so.

Please check the changes committed to devel  https://github.com/sanger/stan-client/commit/f11146e16f3851b8639f8f9a8a5c48f02985f999


fix: update connect to canary version

Update @stacks/connect version for Canary

This is taken care of in my sandbox pr, closing


Build OSTree with curl support

libsoup has issues with mutual TLS authentication

Tested with a full update (adding man) on qemu
Review Score: 11/11


No DataTransfer files on drop when using Linux

I'm using Manjaro 15.12 and Electron 0.35.5
When I'm creating example from https://github.com/atom/electron/blob/master/docs/api/file-object.md
on Windows everything works great, but on Manjaro Linux there is no files on event.

It looks like it is problem with default Manjaro file manager - Dolphin, not Electron.


CICD: adding environment variable at synth stage

According to the AWS documentation, I need to add a an environment variable during the synthesis stage, to use aws-lambda-python. However I'm not noticing an obvious way to do so.
Is there another place where I am meant to put this variable? Or has this not yet been implemented?

At the moment there is an escape hatch that allow you to pass your own synth action to the pipeline
.addSynthAction({synthAction: ...})

I believe the snippet in the docs is outdated as I can't find any construct titled CdkPipeline()
const pipeline = new pipelines.CdkPipeline(this, 'MyPipeline', {
  cloudAssemblyArtifact,
  synthAction: pipelines.SimpleSynthAction.standardNpmSynth({
    sourceArtifact,
    cloudAssemblyArtifact,
    environment: {
      privileged: true,
    },
  }),
});

However, we should be able to pass env as a parameter to the CodeBuildStep created within our construct. I'll get started on a PR to get that working tomorrow. Above is the workaround for now.

I checked it out further, it might be in the .build_pipeline() function where you can parse docker_enabled_for_synth, which is the variable to use when making use of a CodeBuildStep construct.

If that's the property you need you should able to pass that into .build_pipeline() with the current construct.
API Docs


docs: Update svgo path in integrations docs.

I have updated the path for the svgo module in the integrations
documentation as the other path would error out as svgo wasn't in
PATH, so have updated to use the full path to the svgo command.

Testing plan:
Ran linters
GIFs or screenshots:

Merged, thanks @adambirds!


Update CSDiag to use the proper InOutType convention

A quick spot fix for some CSDiag code that didn't get updated in the big sweep.  This caused a crash that @practicalswift's fuzzer managed to find.

@swift-ci please smoke test and merge


Better host handling in CompilationConfig & debug printing

(This is a bit of a grab bag in preparation for #9326
which I'm trying to minimize)
While switching the device planner to use SEScopes I had a lot
of trouble with Target's not matching up.

If no explicit host target is given but the given
TargetMap has targets with hosts, try to use those
to establish the host_target.
Make sure both the 'legacy' TargetMap representation
and the newer representation agree to pointer equality on
their targets.
Make sure the Interpreter uses the target from CompilationConfig
since it's been normalized.

To debug the above:

When in pretty printing with show_meta_data_ false give as much
detail on SEScopes, Targets and call attributes as possible.
That needed some rework in the relay_text_printer.cc.
Ditto for critical 'target' attribute on PrimFuncs.
Also added a Target::ToDebugString so I could see the
host fields along with everything else since a lot of problems
were caused by a mismatch of 'the same' Target with and without
a host. (Tried using that for the ReprPrinter but broken unit
tests.)

Note that the codebase assumes Targets are compared by ObjectPtrEquality,
yet CheckAndUpdateHostConsistency (I count 65 call sites) changes the targets.
Ultimately CompilationConfig or it's ultimate replacement should ensure we munge
targets only once at the 'main' entry points.

cc @jroesch @areusch  Please help this PR get through.


GEODE-7563: eliminate home-grown ConcurrentHashSet

GEODE-7563
For all changes:

[x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

[x] Has your PR been rebased against the latest commit within the target branch (typically develop)?

[x] Is your initial contribution a single, squashed commit?

[x] Does gradlew build run cleanly?

[ ] Have you written or updated unit tests to verify your changes?

[ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

Note:
Please ensure that once the PR is submitted, check Concourse for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to<EMAIL_ADDRESS>

Since I had to remove the ConcurrentHashSet entry from geode-core/src/main/resources/org/apache/geode/internal/sanctioned-geode-core-serializables.txt the next thing I have to do is analyze the places where ConcurrentHashSet was used (Java classes) to see which, if any, were actually serialized (and which, therefore, might break as a result of the changes in this PR)


Add service resource for the controller manager

This PR is a

[x ] Feature Implementation
[ ] Bug Fix
[ ] Documentation

What this PR does / why we need it:
This PR enables to use Prometheus Operator ServiceMonitor to scrap metrics on the controller manager.
This PR adds a service resource for the controller manager in the Helm chart.
Merge Checklist:

[ ] New feature

[ ] Tests
[ ] Documentation

[ ] SVCat CLI flag
[ ] Server Flag for config

[ ] Chart changes
[ ] removing a flag by marking deprecated and hiding to avoid
breaking the chart release and existing clients who provide a
flag that will get an error when they try to update

Hey @sebastien-prudhomme, thanks for the PR.   I've got a couple questions/thoughts.
Instead of creating a Service for the Controller, have you tried enabling enablePrometheusScrape in values.yaml?   https://github.com/kubernetes-incubator/service-catalog/blob/58b88f4d33cb708e4b22c39ccbe498b00738488e/charts/catalog/values.yaml#L161-L162
This will cause the the annoation prometheus.io/scrape to be added to each pod.  To my knowledge this annotation works with most Prometheus deployments enabling the Controller pods to be scraped.  I have not tried it with the Prometheus Operator myself.
If we create the Service to enable Prometheus scraping, is there additional configuration required in the Prom Operator to cause it to scrape services?
Is the NodePort required for Prometheus?  This has side effects such as exposing the Catalog Controller to external access.
If we do merge this PR I'd like to get some documentation around it including any assumptions with regards to the Operator configuration.  Perhaps update https://github.com/kubernetes-incubator/service-catalog/tree/master/contrib/examples/prometheus ?

Hi @jboyd01 Sure you can have automatic scrape directly on pods by using the right annotations but this is not compatible with the prometheus operator and have some limitations, that's why the prometheus operator dev team introduced the ServiceMonitor resource.
You need the Service resource AND a ServiceMonitor resource that have a selector for the service. The service just need an IP, so ClusterIP service type is enough, no need to expose the service in the external world. My fault as i just copy paste what was done for the other service. Will correct it.
The advantage of the prometheus operator is that you can also declare alert rules in your YAML kubernetes files.

/ok-to-test
I'm not certain we need this on by default.

/lgtm

/approve