Theme API Audit

I'm currently working through, reviewing all the open (and many closed) issues & PRs with the themes label. In doing this, I'm collecting together a set of quick wins & bigger changes I want to make as part of the alpha process.
This should feed into a set of subtasks/issues, and ultimately into a blog post about what's changing.

[x] review open issues w/ theme label

Known things which need extended reviews:

[ ] asset helper + envs
[ ] excerpts?
[ ] deprecations

Other tasks:

[ ] write up the new package.json spec
[ ] create a validator for the new package.json spec in gscan
[ ] write a blog post about all the changes

The plan is that, with the exception of features that have been deprecated for over a year, like some of the body classes and page_url,  although some changes may be required for a theme to work with Ghost 1.0.0, themes that work with 1.0.0 should also work on the 0.11 LTS branch. E.g, themes can be prepared in advance of the release of Ghost 1.0.0.

[x] Remove the deprecated features
[x] Get rid of validateActiveTheme
[ ] scan themes with gscan when copied themes manual to themes folder (we could scan the active theme on the first http request to ensure it's 100% valid or similar ideas)

Error handling:

[ ] Revisit stack printing
[x] Simplify logic for finding the error template
[ ] https://github.com/TryGhost/Ghost/issues/6894#issuecomment-221700724
[ ] Split templates for error rendering in themes (see comment here

Some things in this issue are a little unclear to me, but let me write down tasks and questions.
This comment can contain misinterpreted facts - can be corrected/updated.
Questions:

remove deprecations is marked as finished - when and how was this done?
should we require a package.json for 1.0 themes?We could release a gscan 1.0, which contains this breaking change. LTS need's to use the 0.X gscan version. But a 1.0 theme can be still used in an LTS version.

Required Tasks:

[ ] excerpt: https://github.com/TryGhost/Ghost/issues/5060 - i need help with this for sure: what is the state, there are open PR's and lot's of comments. We can discuss via DM to bring me up-to-date with this and then i will update this TODO
[ ] finish packagejson documentation https://themes.ghost.org/v1.0.0/docs/packagejson
[ ] add packagejson validation (see comment https://github.com/TryGhost/gscan/issues/15#issuecomment-242033448)
[ ] scan themes with gscan when copied themes manual to themes folder (we could scan the active theme on the first http request to ensure it's 100% valid or similar ideas) - security task

Optional Tasks:

[ ] Revisit stack printing (https://github.com/TryGhost/Ghost/blob/master/core/server/middleware/error-handler.js#L21)
[ ] improve the asset helper https://github.com/TryGhost/gscan/issues/32
[ ] error-404.hbs and error-500.hbs (https://github.com/TryGhost/Ghost/issues/6894#issuecomment-221700724)

The work for this issue expanded a bit, because all of the code that currently makes themes work is split across config & settings in awkward ways. It was time to solve these problems so that we can move forward cleanly.

[ ] Move the settings cache out of the settings API #8057, fixes #8037
[x] Use a GET /themes/ endpoint for the theme list
[ ] Remove availableThemes from BOTH settings & config (PR coming when #8057 is merged)
[ ] Change theme loading to NOT load all files (LTS + alpha, fix #8056, PR coming today)
[ ] Separate out asset helper for admin & themes (fixes #7958)

Two other new items:

[ ] New concept of "theme config", move posts per page setting there (new issue coming)
[ ] Change get helper as described in #7242

I have an open PR for everything now except for

[ ] Change get helper as described in #7242
[ ] Remove content=0 hack

As I forgot about these 😞 they are small at least.
All the stuff to do with the package.json spec & gscan will be part of the migration path work I think?
I am not sure what "Revisit stack printing" was?

All the stuff to do with excerpts was not scheduled for 1.0

I would also have liked to have made more progress with the asset helper, at least we have a plan for not sharing it between themes and admin again. More improvements can come in future without breaking changes, I think.

Further update - this is mostly as done as it will be for 1.0. Some cleanup work to do around the asset helper now that the admin-server split is done and lots of documentation to do along with updates to gscan.

@ErisDS Could we raise one or two separate issues with the missing pieces and close this big issue?
Let me know 👍

Have raised #8219, #8221 & #8222 to capture what's left here.


Should PlTracks just be Songs?

Is there a reason that a Playlist is a list of PlTracks, rather than a list of Songs?
It looks like a PlTrack just pulls a few select attributes from the corresponding Song referenced by a Playlist, but you can't convert a PlTrack to a dict the way you can with a Song.
There might be a technical reason, but otherwise if I were to compile a list of dicts of all the tracks in a playlist, I would have to reinvent the wheel by going back to the original XML and getting track IDs, looking them up.

That's a great point. I think that playlists should be lists of song objects. Makes a lot more sense.

On Apr 28, 2015, at 6:57 PM, Roger Filmyer<EMAIL_ADDRESS>wrote:
Is there a reason that a Playlist is a list of PlTracks, rather than a list of Songs?
It looks like a PlTrack just pulls a few select attributes from the corresponding Song referenced by a Playlist, but you can't convert a PlTrack to a dict the way you can with a Song.
There might be a technical reason, but otherwise if I were to compile a list of dicts of all the tracks in a playlist, I would have to reinvent the wheel by going back to the original XML and getting track IDs, looking them up.
—
Reply to this email directly or view it on GitHub.

I'll submit a pull request this week
On Tue, Apr 28, 2015, 10:21 PM mbramson<EMAIL_ADDRESS>wrote:

That's a great point. I think that playlists should be lists of song
objects. Makes a lot more sense.

On Apr 28, 2015, at 6:57 PM, Roger Filmyer<EMAIL_ADDRESS>wrote:
Is there a reason that a Playlist is a list of PlTracks, rather than a
list of Songs?
It looks like a PlTrack just pulls a few select attributes from the
corresponding Song referenced by a Playlist, but you can't convert a
PlTrack to a dict the way you can with a Song.
There might be a technical reason, but otherwise if I were to compile a
list of dicts of all the tracks in a playlist, I would have to reinvent the
wheel by going back to the original XML and getting track IDs, looking them
up.
—
Reply to this email directly or view it on GitHub.

—
Reply to this email directly or view it on GitHub
https://github.com/liamks/pyitunes/issues/17#issuecomment-97285667.

Sounds like a great idea - thanks @rfilmyer!

Well isn't that classic.
At least I made the change today in my fork. With my change, playlists are now composed of Songs with an additional self.number property, corresponding to their location in the playlist.
For a class with self.track_number and self.disc_number, "number" might be a bad choice, but we have to choose whether to break backwards compatibility with old PlTrack objects or having a bad variable name.

Why not add order to denote their location in the playlist. Or even playlist_order?

Good idea. I just wasn't sure whether to do a breaking change or keep a
possibly confusing name.
I'll do playlist_order then.
On Thu, Jun 25, 2015, 9:23 AM Liam Kaufman<EMAIL_ADDRESS>wrote:

Why not add order to denote their location in the playlist. Or even
playlist_order?
—
Reply to this email directly or view it on GitHub
https://github.com/liamks/pyitunes/issues/17#issuecomment-115256905.

playlist_order now exists on songs pulled from playlists. Closing.


Google Analytics is not working/reporting

Describe the bug
I am using the correct GA tag, but, the website doesn't seem to be reporting data in the last 24hours (since the new website's deployment)
I was earlier on Gatsbyjs and the same GA tag was working fine.
To Reproduce
Steps to reproduce the behavior:

Setup GA tag in siteMetadata
Observe the metrics on Google Analytics Dashboard

Expected behavior
Google Analytics should report latest analytics
Screenshots

System Info (if dev / build issue):

OS: Windows11
Node version: v16.13.1
Npm version: 8.4.1

Hi bozzmob,
Please make sure you have Google Analytics sources added to Content Security Policy
https://github.com/timlrx/tailwind-nextjs-starter-blog/blob/5f59018fa3a98ab8409f1d0b57d4808707463d0f/next.config.js#L5-L15

Thank you so much! It worked.

Hi,
I had a similar issue. I finally got Google Analytics to work, but then Giscus stopped working. I don't think the two work together. If I am wrong, please let me know, because I had the worst time with getting GA going. I think I might have to trash it altogether. But then the challenge will be: what will replace it? Any feedback would be very much appreciated. Thanks!

Hi,
I just deployed my changes with all reference to Google Analytics removed, and low and behold, Giscus worked again. Just thought I would share in case if anyone else was was banging their heads against the wall because of (big) issues with Google Analytics. And in this case, especially with Giscus. They don't play nicely together. But then Google Analytics does not play nicely with anyone!

@interglobalmedia Thanks for updating. Hmm... will have to take a look in more detail. With so many external integrations included, it is a little difficulty to test that they all work fine with one another. Just to confirm you are using the GA and Giscus code from the main branch in this repository?

Well I cloned the repository. Yes.And I even checked the status of Giscus via the app when I did have Google Analystics running, and it had bumped me off. Then, when I removed Analytics, Giscus was up and running again. I think I did read somewhere that it does not work with Google Analytics. I think it's a privacy thing. But that's ok. They are becoming more and more difficult to work with when it comes to some of their products. I just have to find an alternative!
I did have to create a hack in the next.config file in order to get it to work. Because out of the box, when you have Giscus enabled, you can't get Google Analytics going. Chrome does not allow it, and neither does Safari or Firefox. A script src self error is thrown. Then when I added the hack in next.config.js, GA worked, and Giscus was disabled. Just FYI. I didn't want to lose the Giscus functionality, so I turned off Analytics. I am sure I am not the first to have such (or similar) experience.

Hi,
I am back again. I tried using plausible with and without the script that I was told to use by plausible. With script, I get the same error. Chrome does not allow the script to be loaded. Same with the other browsers. Because of the CSP.
Then, I tried to add GA again only using the starter blog config. The problem with that (now I recall why I added scripts and hacks in the first place) is that it only records the home page. So one cannot avoid adding scripts to _document.js. And then one adds code to _app.js so that changes in the route (switching from one page to another) is recorded so that not only the home page is recorded. There is no value in that. So that essentially is the issue that anyone trying to add some kind of analytics is going to encounter. I come from GatsbyJS and we had to add a script there too. Of course we had plugins for that that took care of the heavy lifting.

Hi,
I finally got plausible analytics to work with Giscus. So far so good. But it involves more than just adding the plausible domain in siteMetadata.js. When I simply did that, I got the CSP error. However, I found that there is a nice little next.js plugin called next-plausible, and when I added that and followed the instructions for adding it to my code, and THEN also adding plausible.io to script src along with giscus, the error went away, and plausible also works. And this plugin makes it possible to track all page views. Not just the home page. I will be writing a post about it, in case if anyone is interested in the process. It will save a lot of time and headache. The only thing is, that there is a 30 day trial and then it is 9 a month. There is no API key as far as I currently know (I will find out), and to me it is worth the avoidance of headaches!


[Feature]: Add paymentstatuses paramtert to Get-HaloInvoice

Contact Details
discod xasz
What happened?
There is no way to get unpaid invoices only.
Version
1.0.1
Which operating systems have you tested on?

[ ] Windows 10
[ ] Windows 11
[ ] Mac OS
[ ] Linux

What PowerShell version are you running?
7.2.0-preview.8
Halo Product
Halo PSA
Halo Version
2.135.4
What command did you run?
This would be a valid HaloAPI request to show unpaid invoices

    api/Invoice?invoicedatestart=2023-01-04T07%3A55%3A24.050Z
    &invoicedateend=2024-01-04T23%3A00%3A00.000Z
    &paymentstatuses=0%2C-1
    &pageinate=true
    &page_size=50
    &page_no=1
    &includeinactive=undefined
    &includeinvoices=true
    &includecredits=false
    &includepoinvoices=false
    &order=invoice_date
    &orderdesc=true
    &order2=id
    &orderdesc2=true

What was the output of the command?
None

Resolved with 1.18.0 - update your PowerShell version to the latest 7.3.x release - we generally only support the current stable PowerShell 7 - with the exception of 7.4.0 until Halo fix a bug.

thanks. my powershell version is up2date or at least on 7.39, but i cannot choose 7.39 in your bug report

7.3.10 is the latest - I'll have to check the form :-)

Fixed the bug report form - thanks!


Segmentation fault on Alpine WSL

Hi!
Getting a segmentation fault when running  cargo install-update --list or other libraries that have network requests, i.e. pricedb.
I've posted the details at SO:
https://stackoverflow.com/questions/75033989/how-to-resolve-a-segmentation-fault-in-a-multithreaded-rust-application-in-alpin/75034701
It turns out that the culprit is reqwest, more precisely the OpenSSL 1.1 dependency.
Alpine has OpenSSL v3.0.7 and some v1.1 compat packages but these conflict the newer ones.
I've resolved the issue in pricedb crate by using
reqwest = { version = "0.11.13", default-features = false, features = ["json", "rustls-tls"] }

as mentioned in the answer on SO. However, posting here to check if it is possible to fix this by installing the correct packages on Alpine and not to have to change the app dependencies. Especially since this method does not fix 3rd-party apps and libraries.

I don't have the time or resources to debug Alpine. If someone else kindly would like to, I'm happy to merge non-breaking fixes.
I kind of think this is more an issue for rust-native-tls, and don't see much for reqwest to do itself. So I'm going to close this issue. We can reopen if there is something reqwest itself is doing wrong.


Fix SecurityFunctions Implementation

Better implementation and storage of salts may be needed, may lose backwards compatibility when exporting .subject files.

Tasks to be completed:

[ ] Fix SecurityFunctions Implementation (Better implementation and storage of salts may be needed, maintain old methods for backwards compatability)

[ ] Implement .subject2 file format (Different encryption method, more secure than .subject)

[ ] Encrypt database for notes (May lose backwards compability)

[ ] Encrypt database for projects

[ ] Use C++ file to obfuscate certain String constants

Client-server communications not needed for now as bug reports and user feedback are now handled by Sentry

Implement EncryptedSharedPreferences is only available for devices with Android Marshmallow (23) and above.


Certain Jaeger tag searches on badger backed storage result in "No trace results. Try another query." despite the entry existing in badger.

VERSION: v1.14.0
EXPECTATION: single trace response in UI for tag search guid:x-request-id=628d36f4-9072-c587-3b00-804c10a63000

ACTUAL:  No trace results. Try another query.
SETUP:

To easily get data populated I modified this file plugin/storage/badger/spanstore/writer.go to add tags to any span write that occurred.  I added the code below to method func (w *SpanWriter) WriteSpan(span *model.Span) error
insert at line 73 (with one import for uuid) based on commit  commit fb5505005a21f007792dedbcd2ad49484d1d587e (HEAD, tag: v1.14.0)

	genId,_ := uuid.GenerateUUID()
	runes := []rune(genId)
	span.Tags = append(span.Tags,
		model.KeyValue{Key: "guid:x-request-id", VStr: genId },
		model.KeyValue{Key: "xrequestid", VStr: genId },
		model.KeyValue{Key: "request", VStr: string(runes[1:7]) },
	)

NOTE in some rare cases this change alone was enough to allow search to work, however it was highly inconsistent
2. the variations xrequestid and request were just experimentation, not essential.
3. I then ran github.com/jaegertracing/jaeger/cmd/all-in-one with the following env vars to activate badger
export BADGER_EPHEMERAL="false"
export SPAN_STORAGE_TYPE="badger"
export BADGER_DIRECTORY_VALUE="/depot/github/src/github.com/jaegertracing/jaeger/cmd/all-in-one/badger/data"
export BADGER_DIRECTORY_KEY="/depot/github/src/github.com/jaegertracing/jaeger/cmd/all-in-one/badger/key"

I ran this test cmd/all-in-one/all_in_one_test.go method func TestAllInOne(t *testing.T) (as is; without modification) in order to prime the jaeger instance with data.
I was able to browse and see the traces with forced populated span tags as the code above indicates and the image here shows >
PROOF ENTRY EXISTS:

I then confirmed that searching for that tag did not return results.

CODE CHANGE THAT RETURNS THE TRACE

I did some debugging and found that the results of mergeJoinIds(left, right [][]byte) [][]byte { from file plugin/storage/badger/spanstore/reader.go was an empty array despite both arrays left and right having content.
I found that this switch statement never entered the case 0:

switch bytes.Compare(left[l], right[r]) {
		case 0:
			// Left matches right - merge
			merged = append(merged, left[l])
			// Advance both
			l++
			r++
		case 1:
			// left > right, increase right one
			r++
		case -1:
			// left < right, increase left one
			l++
		}

and as a result the merged array was empty.
3. Inspecting the arrays showed that one of the arrays contained my trace.
4. I crafted this code (probably not code you want to use) to prove something.
5. file plugin/storage/badger/spanstore/reader.go and method func sortMergeIds(query *spanstore.TraceQueryParameters, ids [][][]byte) []model.TraceID {
		if len(merged) == 0 {
			if len(ids[0]) == 1{
				merged = append(merged, ids[0][0])
			} else if len(ids[1]) == 1 {
				merged = append(merged, ids[1][0])
			}
		}

to line 388
Which basically just checks to see if the merged result is empty, if so check for either of the input arrays having nested array length of 1 and append that entry to the merged result.
6. I can now search for any guid:x-request-id=... value I want and I get back the correct trace.
7. Example

SPECULATION
Since I don't understand how those two id arrays are populated nor do I understand why one of them doesn't contain the entry i'm interested in I can't say what the actual fix is, but my guess is that it was expected that the second array would have contained the entry that was in the 1st array and the merge would have collapsed it down and returned a valid entry. Maybe something about the search is failing?
git diff below
diff --git a/plugin/storage/badger/spanstore/reader.go b/plugin/storage/badger/spanstore/reader.go
index 5d0e156..542839e 100644
--- a/plugin/storage/badger/spanstore/reader.go
+++ b/plugin/storage/badger/spanstore/reader.go
@@ -386,6 +386,13 @@ func sortMergeIds(query *spanstore.TraceQueryParameters, ids [][][]byte) []model
                for i := 2; i < len(ids); i++ {
                        merged = mergeJoinIds(merged, ids[i])
                }
+               if len(merged) == 0 {
+                       if len(ids[0]) == 1{
+                               merged = append(merged, ids[0][0])
+                       } else if len(ids[1]) == 1 {
+                               merged = append(merged, ids[1][0])
+                       }
+               }
        } else {
                merged = ids[0]
        }
diff --git a/plugin/storage/badger/spanstore/writer.go b/plugin/storage/badger/spanstore/writer.go
index af204d2..2d63f0a 100644
--- a/plugin/storage/badger/spanstore/writer.go
+++ b/plugin/storage/badger/spanstore/writer.go
@@ -19,6 +19,7 @@ import (
        "encoding/binary"
        "encoding/json"
        "fmt"
+       "github.com/hashicorp/go-uuid"
        "io"
        "time"

@@ -69,6 +70,13 @@ func NewSpanWriter(db *badger.DB, c *CacheStore, ttl time.Duration, storageClose

 // WriteSpan writes the encoded span as well as creates indexes with defined TTL
 func (w *SpanWriter) WriteSpan(span *model.Span) error {
+       genId,_ := uuid.GenerateUUID()
+       runes := []rune(genId)
+       span.Tags = append(span.Tags,
+               model.KeyValue{Key: "guid:x-request-id", VStr: genId },
+               model.KeyValue{Key: "xrequestid", VStr: genId },
+               model.KeyValue{Key: "request", VStr: string(runes[1:7]) },
+       )

        // Avoid doing as much as possible inside the transaction boundary, create entries here
        entriesToStore := make([]*badger.Entry, 0, len(span.Tags)+4+len(span.Process.Tags)+len(span.Logs)*4)

@Heraclitus nice detective work on this one! I'm not quite sure about the fix, as I'd have to dig deeper into the code to better understand it, but perhaps @burmanm still remembers about this and would be interested in taking a look?

I can take a look. It shouldn't go to the merge if there's a single index request (there's no results to merge).

@Heraclitus One thing that I didn't ask is that are you sure you didn't filter by serviceName? Because:
3. Inspecting the arrays showed that one of the arrays contained my trace.
If your trace did not match, it should have been in the both arrays. If it's only in the one array, that means one search query never matched your trace. Sadly I can't tell from the screenshots since those parts are cut.

@burmanm on your question about serviceName. The "Find Traces" button is grey'd out unless the service drop down is populated and selecting a service is required.

@burmanm here is more of the screenshots, three examples, first without tag search, I am required to select a service to show anything and the second with tag search populated. Third, with service name removed and tags, but "Find Traces" is grey'd out so I can't search. This is still running on my modified version for 1.14.0.

@Heraclitus The service name is the only required field for the search. Based on the screenshots above, I don't see an evidence of a problem: your second screenshot shows that the filter did work as expected, from what I understand.

Isn't this test pretty close to what's trying to be achieved here? https://github.com/jaegertracing/jaeger/blob/master/plugin/storage/badger/spanstore/read_write_test.go#L669
If you can replicate the issue by modifying that test, then that would be very helpful. Obviously that wouldn't catch if there's a mistake from some refactoring between UI <-> badger-storage-plugin, but at least it would help narrow the search scope.

@jpkrohling those screenshots were taken from my altered version so the search works only because of the changes I made.

@burmanm I'll give that a try today

@burmanm my day job interfered yesterday but what I'm first seeing is that my tag level 1.14.0 of that file doesn't have that test, func TestRandomTraceID(t *testing.T) {
Since I'm on 1.14.0 I see  https://github.com/jaegertracing/jaeger/blob/v1.14.0/plugin/storage/badger/spanstore/read_write_test.go
However, I'm going to try porting that test from master -> v1.14.0.
Now this could be a fools errand if the api changed.  I'll see if I can manage.  Maybe this is something got fixed in a later version past 1.14.0.  Will do some investigation.

And, my concern materialized quickly... for file plugin/storage/badger/spanstore/writer.go
master func (w *SpanWriter) WriteSpan(ctx context.Context, span *model.Span) error {
v1.14.0 func (w *SpanWriter) WriteSpan(span *model.Span) error {
https://github.com/jaegertracing/jaeger/blob/v1.14.0/plugin/storage/badger/spanstore/writer.go#L71

Turned out; not so hard after all. Stash, then sync to release branch release-1.17 and get sub modules in alignment.
the test in question does in fact exist on that branch and I was able to add the following code
			Tags: model.KeyValues{
				model.KeyValue{
					Key:   "http.request_id",
					VStr:  "second",
					VType: model.StringType,
				},
// made up tags for this bug
				model.KeyValue{Key: "guid:x-request-id", VStr: genId },
				model.KeyValue{Key: "xrequestid", VStr: genId },
				model.KeyValue{Key: "request", VStr: string(runes[1:7])},
			},

then to the assertion portion of the test
               // Try guid search
		params = &spanstore.TraceQueryParameters{
			StartTimeMin: time.Now().Add(-2 * time.Minute),
			StartTimeMax: time.Now(),
			ServiceName:  "nginx",
			Tags: map[string]string{
				"guid:x-request-id": genId,
			},
		}
		traces, err = sr.FindTraces(context.Background(), params)
		assert.NoError(t, err)
		assert.Equal(t, 1, len(traces))

and the result is that the unit tests passes.

The next test was to see if a local running instance from release branch v.1-17 of all_in_one with the obligatory tags added like I did for 1.14.0
func (w *SpanWriter) WriteSpan(span *model.Span) error {
   genId,_ := uuid.GenerateUUID()
   runes := []rune(genId)
   span.Tags = append(span.Tags,
			   model.KeyValue{Key: "guid:x-request-id", VStr: genId },
			   model.KeyValue{Key: "xrequestid", VStr: genId },
			   model.KeyValue{Key: "request", VStr: string(runes[1:7]) },
	   )

that ensured that any span write gets the offending tags written.
Then use the local UI to browse to find a generated guid

then a search for that guid

and confirmation that the trace found matches

I'll do some more testing to verify i'm not false-positiving this, but initially it looks like whatever bug existed was fixed after 1.14.0

k, I stashed again, checked out tag v1.15.0 and was able to use the existing badger state files to see previously populated traces both with and without my obligatory tags and I can confirm that v1.15.0 works without any changes to the source.
redacted@redacted-lu:/depot/github/src/github.com/jaegertracing/jaeger$ git status
HEAD detached at v1.15.0
Untracked files:
  (use "git add <file>..." to include in what will be committed)

	cmd/REDACTED... ... a bunch of files I created to help me think about this problem ...
nothing added to commit but untracked files present (use "git add" to track)

Yep, I'm good. This was probably fixed in 1.15.0
here is my test loop in essence...

git checkout v1.14.0
git submodule update --init --recursive
git status
# stop all_in_one, restart all_in_one
# force browser refresh at root path
# search for guid:x-request-id=86cddff7-2a6a-b17b-5d25-eeb1ff720499
# NO RESULTS FOUND
git checkout v1.15.0
git submodule update --init --recursive
git status
# stop all_in_one, restart all_in_one
# force browser refresh at root path
# search for guid:x-request-id=86cddff7-2a6a-b17b-5d25-eeb1ff720499
# RESULT FOUND

Good to hear, thanks for the investigation.


HBASE-24742 Improve performance of SKIP vs SEEK logic.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m  7s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
3m 54s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 15s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m  4s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 29s
the patch passed

-0 :warning:
checkstyle
1m 13s
hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
19m 31s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 14s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

42m 41s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux be47be3cbaa4 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / c582fb5d11

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 45s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
3m 38s
branch-2.3 passed

+1 :green_heart:
compile
0m 53s
branch-2.3 passed

+1 :green_heart:
shadedjars
4m 59s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 11s
the patch passed

+1 :green_heart:
compile
0m 55s
the patch passed

+1 :green_heart:
javac
0m 55s
the patch passed

+1 :green_heart:
shadedjars
4m 58s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 35s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
134m 26s
hbase-server in the patch passed.

158m 12s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux ad112d1a7932 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / c582fb5d11

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/testReport/

Max. process+thread count
4057 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 26s
Docker mode activated.

-0 :warning:
yetus
0m  6s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
5m  2s
branch-2.3 passed

+1 :green_heart:
compile
1m  8s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 27s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 20s
the patch passed

+1 :green_heart:
compile
1m  9s
the patch passed

+1 :green_heart:
javac
1m  9s
the patch passed

+1 :green_heart:
shadedjars
6m 20s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
191m 10s
hbase-server in the patch failed.

220m 23s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 279ca8c9cacb 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / c582fb5d11

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/testReport/

Max. process+thread count
2635 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/1/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
2m 49s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
5m 47s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 24s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m 27s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 53s
the patch passed

-0 :warning:
checkstyle
1m 21s
hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
25m 55s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 43s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 16s
The patch does not generate ASF License warnings.

58m 17s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 1d8e3308c9c8 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 5432ba6eac

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 44s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
5m 11s
branch-2.3 passed

+1 :green_heart:
compile
1m 15s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 42s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 45s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 44s
the patch passed

+1 :green_heart:
compile
1m 12s
the patch passed

+1 :green_heart:
javac
1m 12s
the patch passed

+1 :green_heart:
shadedjars
7m  5s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 52s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
218m  4s
hbase-server in the patch passed.

249m 16s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux d0e4c8b9e367 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 5432ba6eac

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/testReport/

Max. process+thread count
2666 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 46s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m 21s
branch-2.3 passed

+1 :green_heart:
compile
0m 57s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 37s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 46s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
5m 33s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
the patch passed

_ Other Tests _

-1 :x:
unit
235m 13s
hbase-server in the patch failed.

261m 12s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a8e91f3d9578 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 5432ba6eac

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/testReport/

Max. process+thread count
2552 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/2/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 33s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
3m 37s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m  9s
branch-2.3 passed

+1 :green_heart:
spotbugs
1m 56s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m  8s
the patch passed

-0 :warning:
checkstyle
1m  6s
hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
17m  3s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m  3s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

37m 54s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux e11b2f520279 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 5432ba6eac

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
94 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  5s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m 42s
branch-2.3 passed

+1 :green_heart:
compile
1m  7s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 22s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
4m 16s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

+1 :green_heart:
shadedjars
6m 24s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 40s
hbase-server in the patch failed.

_ Other Tests _

-1 :x:
unit
180m 20s
hbase-server in the patch failed.

207m 47s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 37f8b076150e 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 5432ba6eac

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/testReport/

Max. process+thread count
3072 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/3/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Can't seem to get a passing test run, and yet failures always look unrelated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 37s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m  0s
branch-2.3 passed

+1 :green_heart:
checkstyle
1m 16s
branch-2.3 passed

+1 :green_heart:
spotbugs
2m  6s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 36s
the patch passed

-0 :warning:
checkstyle
1m 15s
hbase-server: The patch generated 1 new + 21 unchanged - 0 fixed = 22 total (was 21)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 44s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2 3.2.1.

+1 :green_heart:
spotbugs
2m 15s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

42m 38s

Subsystem
Report/Notes

Docker
Client=19.03.9 Server=19.03.9 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 3fb1ee8a4736 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 965a4a0ae7

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
84 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 40s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
3m 51s
branch-2.3 passed

+1 :green_heart:
compile
1m  5s
branch-2.3 passed

+1 :green_heart:
shadedjars
5m 41s
branch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in branch-2.3 failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 52s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
5m 40s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 38s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
129m 31s
hbase-server in the patch passed.

154m 33s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a0a9f8c7b65d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 965a4a0ae7

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/testReport/

Max. process+thread count
4350 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 34s
Docker mode activated.

-0 :warning:
yetus
0m  7s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ branch-2.3 Compile Tests _

+1 :green_heart:
mvninstall
4m 38s
branch-2.3 passed

+1 :green_heart:
compile
1m  8s
branch-2.3 passed

+1 :green_heart:
shadedjars
6m 16s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 38s
branch-2.3 passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
3m 46s
the patch passed

+1 :green_heart:
compile
1m  2s
the patch passed

+1 :green_heart:
javac
1m  2s
the patch passed

+1 :green_heart:
shadedjars
6m  9s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 42s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
205m 35s
hbase-server in the patch passed.

232m 13s

Subsystem
Report/Notes

Docker
Client=19.03.12 Server=19.03.12 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/2081

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bdd3ffc4639c 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
branch-2.3 / 965a4a0ae7

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/testReport/

Max. process+thread count
2263 (vs. ulimit of 12500)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-2081/4/console

versions
git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Test suite eventually passed.


Is this theme now compatible to Q2A 1.7??

Hi @gurjyot please read the other post before create one new...

Cleanstrap and Q&A 1.7 + Bootstrap 3.3.1](https://github.com/Towhidn/CleanStrap/issues/24)
Mobile menu not work with the lastest Q&A version

@JoZ3 I am not having enough time to go through all the commits done before. I have not raised an issue, but just a question. I know that this question should be raised on q2a official forum but Towhidn is not coming on q2a from some time that's why that question is raised here.

@gurjyot spends more time writing the post that looking and especially when the list is small.
Please is not a good idea create duplicate commits, remember is only a developer behind this template...

navigation issue is addressed and I checked theme both on Q2A 1.6 & 1.7

Thanks for your reply @towhidn, now I will upgrade my site to q2a 1.7
Just one more thing, this theme is still having some unsolved issues, will you fix them soon??

I'm checking issues that was submitted here and some that I dug up. there are still 7 issues to fix. I'm planning to fix them by tomorrow(if everything goes well).


.toBeA('array')

How about it? It would be nice to have a wrapper around expect(Array.isArray(list)).toEqual(true) (yuck).
For reference, chai.js has expect(list).to.be.a('array').

You can already do expect([]).toBeAn(Array).

that does x instanceof Array though, not Array.isArray(x) or equivalent.

ok, let's add it


pablodraw: init at 3.3.13-beta

Description of changes
Closes https://github.com/NixOS/nixpkgs/issues/88615 (4 years later, lol)
(This is ascii art editor, not yet another drawing app)
./result
├── bin
│   └── PabloDraw
├── lib
│   └── pablodraw
│       ├── PabloDraw
│       ├── PabloDraw.pdb
│       ├── Pablo.Interface.pdb
│       └── Pablo.pdb
└── share
    ├── applications
    │   └── PabloDraw.desktop
    └── icons
        └── hicolor
            ├── 512x512
            │   └── apps
            │       └── pablodraw.png
            └── 64x64
                └── apps
                    └── pablodraw.png

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)

[ ] sandbox = relaxed
[ ] sandbox = true

[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Add a :+1: reaction to pull requests you find important.

Why  dotnet passthru.fetch-deps doesn't fetch for all platforms?


context time_remaining does not work

class Service(service_pb2.ServiceServicer):
    def Method(self, request, context):
        log.info('%s', context.time_remaining())

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/grpc/_server.py", line 364, in _call_behavior
    return behavior(argument, context), True
  File "/usr/local/lib/python2.7/dist-packages/grpc/beta/_server_adaptations.py", line 100, in adaptation
    return unary_request_inline(request, _FaceServicerContext(servicer_context))
  File "/usr/local/lib/python2.7/dist-packages/prozess/alerting_metric_query/core.py", line 40, in Evaluate
    log.info('%s', context.time_remaining())
  File "/usr/local/lib/python2.7/dist-packages/grpc/beta/_server_adaptations.py", line 69, in time_remaining
    return self._servicer_context.time_remaining()
  File "/usr/local/lib/python2.7/dist-packages/grpc/_server.py", line 229, in time_remaining
    return max(self._rpc_event.request_call_details.deadline - time.time(), 0)
TypeError: unsupported operand type(s) for -: 'grpc._cython.cygrpc.Timespec' and 'float'

protobuf==3.0.2
grpcio==1.0.0

Workaround:
def time_remaining(context):
    deadline = context._servicer_context._rpc_event.request_call_details.deadline
    return (deadline.seconds + deadline.nanoseconds / 10**9) - time.time()

Update:
In 1.0.1, context object was refactored. This will work:
def time_remaining(context):
    deadline = context._rpc_event.request_call_details.deadline
    return (deadline.seconds + deadline.nanoseconds / 10**9) - time.time()

Was this closed because there was a fix? time_remaining() is still part of the API and this is still broken on 1.0.4.

what error do you get if you use time_remaining()?

The same one:
ERROR:root:Exception calling application: unsupported operand type(s) for -: 'grpc._cython.cygrpc.Timespec' and 'float'
Traceback (most recent call last):
  File "/Users/guilherme.fernandesraphanelli/miniconda2/lib/python2.7/site-packages/grpc/_server.py", line 364, in _call_behavior
    return behavior(argument, context), True
  File "greeter_server.py", line 45, in SayHello
    print "time {}".format(context.time_remaining())
  File "/Users/guilherme.fernandesraphanelli/miniconda2/lib/python2.7/site-packages/grpc/_server.py", line 229, in time_remaining
    return max(self._rpc_event.request_call_details.deadline - time.time(), 0)
TypeError: unsupported operand type(s) for -: 'grpc._cython.cygrpc.Timespec' and 'float'

(This is reproduced by accessing context.time_remaining() on the helloworld example.)

I'm having a hard time reading this issue's history. @ctiller: is there a record of why it got the to close label? @hsaliak: is there a record of why it was closed?
I am working on a fix...

(... and this bug likely wouldn't have happened if our coverage story were better...)

Yes - this was marked as to close during our semi-regular bug scrub where we triage all issues. However, I think this particular issue was a false positive, especially due to the existence of the workaround.
We expected a few false positives when we did the scrub and unfortunately this is an important issue that we tagged wrong.
As an aside: This is a clear indicator for us to focus on improving the process - for example, we should stage the issues marked for closure ensure that they get the appropriate labels and close them pending a closer look, with a smaller group.

Following the integration of pull request 9420 all that's left to do here is replace the smoke test with a real test.

No action here for 9+ months. Remove P1 label?

Fair enough. It felt important at the time...


Support doctrine/dbal ^3.0

@krowinski
Could you please take a look at this?
Thanks.

@krowinski
Could you please take a look at this?
Thanks.

I don't know why the PHP_CodeSniffer was broken...
Could you please deal with it ?

I don't know why the PHP_CodeSniffer was broken...
Could you please deal with it ?

Looking good I don't thing that ping need interface but still great job

Looking good I don't thing that ping need interface but still great job


token refresh example

Hey there! I took out the minimum amount of code from our token refresh implementation and tried to come up with a straight-forward example. Maybe after a bit of back and forth, when you're happy with the code in client.ex, I can proceed to write up the tutorial and tests to go with it.
Let me know what you think!

I've added a pretty basic test. Any ideas of how to test it further? 🤷

I was fiddling with adding an assert_connect helper to Slipstream.SocketTest (https://github.com/NFIBrokerage/slipstream/commit/9e0c360b3a79f3308ee9a926f2cf5024b31b13ca) for testing reconnect behavior. I think that would help out here but I'm not sure yet how it should interact with the similar Slipstream.SocketTest.accept_connect/1 (maybe they should be consolidated into one helper?). I'll swing back around to this example if that ends up making its way into the API.

Thanks for working on this @cadebward!


Request: Quay Enterprise with Tectonic Ingress

User reached out inquiring about Using Quay Enterprise behind Tectonic Ingress. This would be a great addition to the documentation.
Creating issue here to keep track.

This will likely will require the proxy protocol being enabled which must be done on the ingress-controller.


Improved performance with large scrollback

Improved performance for terminal will large scrollback values (over 10000 lines), so memory will not be allocated for buffers that are not used

Implemented optimisation for BufferLine, so data array will not be allocated until it is needed
modified resize method to be more efficient if data are not allocated yet

Problem background:
During initialization and window resize Terminal will call resize method for each buffer line during which triggers memory reallocation of BufferLine.data. This operation becomes bottleneck with terminal scrollback > 10000.

Implemented fix takes into account that most of the buffers will contains only blank charactes (until something useful will be printed into it) and can be lazy allocated using known fillCharacter and expectedDataSize. In this case resize method will be as simple as updating expectedDataSize value.

Note: Further optimization is possible since most of the lines in CircularList will be empty ones and we don't really need to allocated those BufferLines before they contain anything useful.

Thank you very much, this is great!
Another option is to only allocate the rows on demand, rather than allocating up-front and having the the scroll back be a limit to how much it grows, rather than a startup allocation size.
But I will merge your change until the day I fix that


Publish VSIX and overriding may cause publish failure if extension contains a dot file

If you vsix file contains a file that starts its name with a ".", then that file may get lost when repackaging your vsix file. In that case publishing the extension will fail with a cryptic error message:
error: Failed Request: Bad Request(400) - Specified part does not exist in the package.
tfx failed with error: Error: D:\a\r1\a\node_modules\.bin\tfx.cmd failed with return code:<PHONE_NUMBER>

Experimenting with a new version which replaces archiver and adm-zip with 7zip binaries.


java.lang.NoSuchFieldError: Companion on DefaultHttpEngine$execute$2$httpRequest$2$2

Question.
This is related to #4048 .
I managed to fix that error by upgrading Spring Boot to 2.6.6. Now i have a different error on the HTTP request.
java.util.concurrent.CompletionException: java.lang.NoSuchFieldError: Companion
	at org.springframework.aop.interceptor.AsyncExecutionAspectSupport.lambda$doSubmit$3(AsyncExecutionAspectSupport.java:281)
	at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1700)
	at org.springframework.cloud.sleuth.instrument.async.TraceRunnable.run(TraceRunnable.java:64)
	at com.equinix.crh.asset.common.config.ThreadConfig$ContextDecorator.lambda$decorate$0(ThreadConfig.java:84)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at java.base/java.lang.Thread.run(Thread.java:829)
Caused by: java.lang.NoSuchFieldError: Companion
	at com.apollographql.apollo3.network.http.DefaultHttpEngine$execute$2$httpRequest$2$2.contentType(OkHttpEngine.kt:56)
	at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.java:53)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.java:88)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:142)
	at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.java:117)
	at okhttp3.RealCall.getResponseWithInterceptorChain(RealCall.java:229)
	at okhttp3.RealCall.execute(RealCall.java:81)
	at com.apollographql.apollo3.network.http.DefaultHttpEngine.execute(OkHttpEngine.kt:75)
Caused by: java.lang.NoSuchFieldError: Companion

This looked like an error with the okhttp library that is being used. I generated the gradle dependencies for my app and noticed that the version being served is old:

I don't know why the version is being changed from 4.9.3 to 3.14.9, especially when apollographql is the first package to import this dependency. I managed to fix it and get things running by adding this to my build.gradle:
implementation("com.squareup.okhttp3:okhttp") {
        version {
            strictly("4.9.3")
        }
    }

Is there a different way to solve this issue?

Hi 👋

I don't know why the version is being changed from 4.9.3 to 3.14.9, especially when apollographql is the first package to import this dependency.

For what it worth, the order of the dependencies declaration shouldn't matter

Is there a different way to solve this issue?

Hard to tell from the screenshots. Looks like a plugin or another dependency forces 3.14.9. Can you share the complete :app:dependencies output?

Hi @adsiddiqui-equinix anything else we can help with here?

@adsiddiqui-equinix I'm going to go ahead and assume you found a solution. I'm closing this issue for now. Feel free to reply to this thread and we can keep investigating.


suggest 'make dev' flow in a more explicit way

Not really adding much, but it makes more explicit that we have a "fast" local dev flow.
It may help people that are just skimming over the docs.

Actually I think we should suggest
ENABLED_SPIES=none make dev
as well.


Paging does not work

Paging does not work. It did not work on my example_app before last night merges either. I could  not verify with live demo on appspot because no datatable over there have more than 1 page.
I suspect it is because of the new parameter scheme. 1.10 parameters, paging come as follows:
{ ...
'length': ['2'],
'start': ['4'],
... }

One more thing:
From the datatables parameter conversion chart:
iDisplayStart -> displayStart: Initial paging start point
That seems to be for initial setup only. and datatableview makes no reference to the 'start' I mentioned in the original post. It is not on the conversion chart either. weird.

Can this be tagged "bug" as well? And, it might need priority over most other issues here, since it is one of the most basic features of the datatable.

See #157

I am not sure that the paging problem has to deal with the parameters name. In my working branch I still have the names iDisplayStart and iDisplayLength and paging works with the latest version of Datatables.
In my latest project I tried going back to the official master branch from @tiliv and paging was not working. I then switched to @doganmeh working branch and it was still not working. It turns out that the problem with the paging was that in this particular instance I was using a proxy model as the model for the DataTableview. As soon as I switched to the regular model paging started working, so I am wondering if the paging problem is related to using proxy models and not the parameter names.

@jangeador when you switched to regular modal where still on doganmeh or tiliv/master? when I fixed the parameters it did not work for a few times, and then worked (probably after fresh loading of the page or resetting of the local storage cache)

@doganmeh I stand corrected. I must've been using a cached version. I can now confirm that the fixes on your branch work with regular models as well as with proxy models. Thanks for those fixes and thanks for that helper you added.

I could not find its reference on the datatables.net site, but it is not recommended to mix and match old and new parameters. Once you use some of old parameters, it triggers logic to expect other parameters also same kind.

Perfect :)

Bu problemi ben de yasiyorum. kesin bir cozumu var mi @doganmeh

@sanfirat check out my working branch it should work.
translation: benim repo'nun 'working' dalini dene, calismasi lazim.

By the way, I am looking forward to version 1.0 (where you clean old configuration). I would like to take a more thorough look at the code, but as it is now, it is a little complicated for me. I am hoping, it will get simpler once the old configuration stuff removed. Regards,

Hey !
Sorry I am late to the party but I ran into some issues with the pagination at work. We pulled your pull-request @doganmeh and it broke our non-paginated datatable views. Please see the comment I put here https://github.com/pivotal-energy-solutions/django-datatable-view/pull/157/files
Cheers

Resolved via #171 and #170


Add data to ob/listings response

Two things:

The Vendor's peerID. Already discussed with you Chris why this is important and a time-saver.
Date created. This will be useful in sorting listings by the time they were created/published.

@cpacia @hoffmabc update?


Add Display implementation to DebugName.

Objective

When writing "in game" debugging tools, quite often you need the name of an entity (for example an entity tree). DebugName is the usual way of doing that.
A recent change to Entity's Debug implementation meant it was no longer a minimal {index}v{generation} but instead a more verbose auto generated Debug.
This made DebugName's Debug implementation also verbose

Solution

I changed DebugName to derive Debug automatically and added a new (preferred) Display implementation for it which is the preferred name for an entity. If the entity has a Name component its the contents of that, otherwise it is {index}v{generation} (though this does not use Display of the Entity as that is more verbose than this).

Testing

I've added a new test in name.rs which tests the Display implementation for DebugName by using to_string.

Migration Guide

In code which uses DebugName you should now use the Display implementation rather than the Debug implementation (ie {} instead of {:?} if you were printing it out).

Additionally (more controversial maybe) I have returned the Display implementation in Entity to just be {index}v{generation} rather than also having |{bits} on (where {bits} is a 64-bit decimal version of generation << 32 | index).

I don't like this change personally, but we should definitely split this off to make sure the other work doesn't get blocked.

I've updated to no longer change the Display implementation for Entity and instead use {index}v{generation} directly in DebugName.

@eidloi, does this solve https://github.com/bevyengine/bevy/issues/13980 for you?

@eidloi, does this solve #13980 for you?

No, because it needs querying an additional component which may not be possible in some contexts. I mean it's not a bad thing to have but I find it somewhat redundant.

Part of the original change was to make Display on an entity simpler (get rid of the redundant bit), but that change was I think more controversial than this. I’d support doing that, so this change is just a switch between two displays.

@alice-i-cecile will this automatically go into 0.15 or can it go into an update to 0.14?

Looks like this will be in 0.15 :)


请问，执行python脚本报错？？

ERROR Request engine failed, possibly due to insufficient resources or background process error(请求引擎失败，可能是由于资源不足或后台进程错误)!

You can see the log error of python-engineManager

thanks,
there is also a problem,
when i run python with  import module
error code(错误码): 20071, error message(错误信息): can not use os moudle.

Yes, we restrict the use of dangerous syntax, including os, sys and other modules


Add validation to Dropdown form

Implemented form submission handling for dropdowns.
Added validation to ensure selections are made.
Initialized state for tracking dropdown values.
Wrapped dropdowns in a form for structured submission.

for issue#1789


Add cash flow list to main page

Adds a list of cash flow entries, and their frequencies, to the main page.
Also fixes casing for multi-word models & json-api response.

okaydokay :ship: :it:


Update an account in the service

As a user of the application
I need to update an account in the service
So that I can modify account information
Details and Assumptions

The service allows for the modification of existing account data.

Acceptance Criteria
Given I have a valid request to update an account
When I make a request to update the account
Then the account information is successfully updated


Can we bring back timber's qtySelectors?

Or it there a reason they're not being used anymore?
(https://github.com/Shopify/Timber/blob/master/assets/ajax-cart.js.liquid)

@zomars I think the best solution would be for you to make your own custom starter theme! 😬


I follow the steps but no result

That's just the default landing page, the main application is the "search" page, but it looks like your ICC config dumps are in a different format to what I'm dealing with so there will be no data. The files I've designed it to parse are in a file structure like icc_git_dumps/<CP name>/<compound name>/<block name>.txt and have contents like this, for example:
NAME   = COMPOUND_NAME:BLOCK_NAME
  TYPE   = AIN
  DESCRP =
  PERIOD = 2
  PHASE  = 1
  LOOPID =
  IOMOPT = 1
  IOM_ID = IOM001
  PNT_NO = 1
  SCI    = 3
  HSCO1  = 55
  LSCO1  = 45
  DELTO1 = .1
  EO1    = HZ
  OSV    = 2.0
  EXTBLK = 0
  MA     = 1
  INITMA = 1
  BADOPT = 3
  LASTGV = 1
  INHOPT = 0
  INHIB  = 0
  INHALM = 0x0
  MANALM = 0
  MTRF   = 1.0
  FLOP   = 0
  FTIM   = 0.0
  XREFOP = 0
  XREFIN = 0.0
  KSCALE = 1.0
  BSCALE = 0.0
  BAO    = 0
  BAT    =
  BAP    = 5
  BAG    = 1
  ORAO   = 0
  ORAT   =
  ORAP   = 5
  ORAG   = 1
  HLOP   = 0
  ANM    =
  HAL    = 100.0
  HAT    =
  LAL    = 0.0
  LAT    =
  HLDB   = 0.0
  HLPR   = 5
  HLGP   = 1
  HHAOPT = 0
  HHALIM = 100.0
  HHATXT =
  LLALIM = 0.0
  LLATXT =
  HHAPRI = 5
  HHAGRP = 1
  PROPT  = 0
  MEAS   = 49.954101562
  AMRTIN = 0
  NASTDB = 0
  NASOPT = 0
END

This may be site specific, it is a set of scripts from Foxboro which generates these configuration files. I've not worked on any other Foxboro I/A control system to know for sure, but this may have been something they have only delivered for this specific customer which is operating with an old unix version of ICC.
Are the contents of your .icc files in plain text? I may be able to modify the parser to work with them for you.

Yes, it is a plain text but the in my case there is a file per each CP, and inside this file are the blocks.

If you update your script to read the CP file icc, this will be much easier.

The control system I work with does not have .icc files, can you post a sample?


New release is needed to fix Xcode compiler warnings

Pull Request #75 fixed the compiler warnings, and was merged into master back on 1 April, 2016.
However there hasn't been a release since 23 September, 2015.
Time for a new release I think 😊

You are right. I should do that. I will try to make some time this weekend!

Great, thanks Tom!

Hey is this still happening?

Bump

I just released 1.2.0! Sorry it took so long. I have been very very busy...

I just released 1.2.0! Sorry it took so long. I have been very very busy...

Yay!!! Thank you

Thank you Tom!


Error: 3 [ERROR] Couldn't find project #7 for owner 'My-Org'.

I'm having a problem running the action, getting this error:
Error: 3 [ERROR] Couldn't find project #7 for owner 'My-Org'.
As you can see below with the link and code, the project_number is correct? Or is the project_number something else? Or are there something else that is not correct?
This is my code
    steps:
      - name: Sync issue states
        uses: dasmerlon/project-issue-state-sync@v2
        with:
          github_token: ${{ secrets.PROJECT_ISSUE_SYNC_TOKEN }}
          owner: My-Org
          project_number: 7
          closed_statuses: Done
          open_statuses: Product Backlog,Ready,On hold,In progress

and the link to my project looks like this:
https://github.com/orgs/My-Org/projects/7/
And here is the defined scopes for my PAT:

Ps. I have replaced the name of my org to "My-Org" in above text.

Hey @arvesolli, sorry for the late reply.
I tried several things to get this error, but I couldn't reproduce this issue at first.
But finally, I found a setup where I got the same error.
Your PAT and workflow appear to be correct, but there might be conflicting access permissions that are causing this error.
It seems that this error can occur if some users have at least read permission to the repository but no access to the project.
Even if you have full access to the repository and project, you will receive this error.
I guess GitHub handles it this way so that no user can see in the repository actions that there is a project that they don't have access to and therefore shouldn't know about.
Weirdly enough, a public repository seems to work with a private project which should have the same issue. So I'm not entirely sure what's going on here.
My other guess would be that your project isn't a ProjectV2 but a classic project and therefore the client cannot find a ProjectV2 with number 7. If that's the case you could migrate to ProjectV2. But I don't know if this could affect other things since I've never seen a classic project.
Let me know if any of this applies to your case. :)

Didn't do any changes to my code, but today it worked 👍


There's a javascript error in the AWS Amplify console

Before opening, please confirm:

[X] I have checked to see if my question is addressed in the FAQ.
[X] I have searched for duplicate or closed issues.
[X] I have read the guide for submitting bug reports.
[X] I have done my best to include a minimal, self-contained set of instructions for consistently reproducing the issue.

App Id
none
Region
ap-southeast-2
Amplify Hosting feature
Not applicable
Describe the bug
I can't access the console at all because you have a javascript error in your web page.

Expected behavior
Open the AWS Amplify console by navigating to https://ap-southeast-1.console.aws.amazon.com/amplify/home?region=ap-southeast-2
Reproduction steps
Open https://ap-southeast-1.console.aws.amazon.com/amplify/home?region=ap-southeast-2
Build Settings
No response
Additional information
No response

Hi @mxswd 👋🏽  thanks for raising this issue. Can you try clearing your cache and refreshing the page?

@hloriana Hello, thanks for the quick response. I tried Empty Caches, private browsing and Edge on Windows and the problem still occurs. I can't access the Amplify console in the ap-southeast-2 region anymore. ap-southeast-1 works fine.

Same issuehere , seeing the error: this.props.preferences is undefined when trying to view Amplify console in us-east-2 and the page does not load.
Other regions work fine, us-east-2 is the only one not working and is also the only region I have an existing app in.

I'm syncing with the team to further investigate. @DavidRalph can you provide a screenshot of the error as well?

can you please also share the content of the preferences key in your browser's local storage to help with debugging.
You can run the following in chrome dev tools while Amplify console is open.
localStorage.getItem("preferences")

@mxswd @DavidRalph I previously suggested clearing the cache but can you try clearing the local storage as well? You can do that by navigating to developer tools -> applications -> storage -> local storage.

Thanks I think that fixed it!
This was my local storage preferences before I deleted them:
"{\"releaseFlashBarDismissed\":{\"2_0_5\":true},\"clusterList\":{\"pageSize\":10,\"custom\":\"cards\"},\"capacityProvidersTable\":{\"pageSize\":5,\"visibleContent\":[\"name\",\"type\",\"asgData\",\"managedScaling\",\"managedInstanceProtection\",\"currentSize\",\"desiredSize\",\"minSize\",\"maxSize\",\"updateStatus\"]}}"

Thanks, clearing local storage fixed it for me also.
Here are the preferences and a screenshot of the issue prior to clearing local storage:
"{\"releaseFlashBarDismissed\":{\"2_0_5\":true},\"taskLogs\":{\"custom\":\"ABSOLUTE_LOCAL\"},\"serviceEvents\":{\"pageSize\":10,\"custom\":\"ABSOLUTE_LOCAL\"},\"serviceLogs\":{\"custom\":\"ABSOLUTE_LOCAL\"}}"


Multiline text shows on a single line

Describe the bug
Multiline text shows on a single line.
Versions
Ray version (you can see this in "About Ray"): <IP_ADDRESS>
You can use composer show to get the version numbers of:

spatie/ray package version: 1.21.2

PHP version: 7.4
To Reproduce
Steps to reproduce the behavior:

Dump any text with newlines (\n or \r\n)

Expected behavior
Text should be properly displayed
Screenshots
Text shows on a single line.

When I dump to console (with Symfony dump()), it shows correctly:
"""
<?php\n
\n
    public function show(BadWord $badword)\n
    {\n
        return $badword;\n
    }\n
"""

Desktop (please complete the following information):

OS: Windows 10

The standard ray(); log will not attempt to display HTML anymore, unless a Symfony dump script is present in the payload.
ray('hi<br />\n \r\n foobar'); will display

I just needed the same behavior and the answer is text() function of Ray
ray()->text($contents)


[Feature]: Think of adding concept of session

Is your feature request related to a problem? Please describe.
There are couple of cases where we need the idea of session and context.
Let me quickly go through some examples:

Another use case is the langchain SQL demo, see (https://python.langchain.com/en/latest/modules/chains/examples/sqlite.html)
The chain did follow:

Based on the query, determine which tables to use.
Based on those tables, call the normal SQL database chain.
The chain request context so it won't hit the second time

Describe the solution you'd like.
No response
Describe an alternate solution.
No response
Anything else? (Additional Context)
No response

session: #294
context: #305 #316


Added support for user patterns with a new 'zhmc userpattern' command group

Manually tested on HMC <IP_ADDRESS> (A224 HMC)

coverage: 36.916% (-0.1%) from 37.044%
when pulling e9c59fb677ad39e19dd96678a969ec68cc3f91cd on andy/add-userpattern
into 876380addd04e8ed695befea9a267786faedb737 on master.


Acunetix parser

Hi,
i noticed that an Acunetix parser was integrated in this version but it does not work ( for me )
i get a Server Error (500) when i try to upload an acunetix scan report .
i used to use this parser in the previous version of DefecDojo and its working very fine for me
https://github.com/code4innerpeace/DefectDojoAcunetixParsers

@40R40L we are unable to investigate without a sample scan.

hello i got the sample for this one
please re open it


docs(channels): Fix subsriber examples

Fix outdated usage of the channels.subscribe method; The channel.start_subscription method should be used instead.

Probably. This would also have been caught by mypy, which we stopped using a while ago because the error suppression needed polluted the examples quite a bit.
Now I'm thinking though that it would be relatively straightforward to strip the # type: ignore comments from the examples. Maybe we could make sure the examples are nicely typed and then implement the stripping on top to get rid of the remaining things.


[Fix][NVIDIA] fix MultiThreadedAugmenter issue

Fix issue where MultiThreadedAugmenter is not accessible anymore and making preprocessing failing on brats for 3d-unet benchmark
https://github.com/mlcommons/inference_results_v1.0/issues/11

recheck

recheck


Installing Amplitude.js on Joomla

Good day!
Version Amplitude.js - 4.0.0
Installation instructions studied. I'm trying to install the player on Joomla by the third method - manual installation (while on the local server). What am I doing wrong?
I downloaded Amplitude.js from GitHub. The amplitude.js file added to the   area -
Result: the player does not even appear. In the console, such a picture - https://prnt.sc/meo2ix

Good day!
I want to install a player with a playlist.
What do your words mean: "it is Necessary to mark the player on the page to make it appear"?
From the archive that I download from GitHub, I only need the file " amplitude.js" or any other files and folders need to be added to the site?

@NesteA88 So you will need AmplitudeJS included on your page and you will need the HTML of the player that you wish to use. When I looked at the screenshot, it looks as if AmplitudeJS was configured correctly, but nothing was being bound to it. Do you have a public facing link with the code available?

Good day!
I have created the page you are trying to add player - https://armymusic.ru/pesni-pro-pv.html.
At this point it should be player - http://prnt.sc/mli34d.
It still does not appear. Something else needs to be added, but I don't know what it is.

Hi @NesteA88,
So you need to add the actual HTML to the page. AmplitudeJS just activates the HTML on init. So with your player, you have to add the HTML and with all of your songs and then run Amplitude.init(); Right now I don't see the HTML appearing in your page. Let me know how that works!

Dan, good day!
I have already understood that it is necessary to add HTML-construction. But I can't figure out what she's supposed to look like! Can you use at least one song as an example to show what the HTML code will look like?

Ahh, gotcha! So for a single song, you could do something like this:

            <progress class="amplitude-song-played-progress" id="song-played-progress"></progress>

                :

                :

This is a fully functioning HTML markup for AmplitudeJS. You can activate it with the script:

I have some more JS in there than the necessary just for a few features custom to the player. Hope that helps! You can find more examples here of tons of different types of players: https://github.com/521dimensions/amplitudejs/tree/master/examples

Hi @NesteA88 Did this help solve the problem? If so I'll close the issue.

Yes! Thank you!


Easy redux usage + Doc

Hi,
I added an easy use for redux to handle the App orientation seamlessly with an usage little example. I left the whole other scope intact.
Check it, we can discuss if you want.

@bberthelemy thank you for the update. Could you maybe refactor it and create a new examples folder in the root of the package so that we can have a demo and a redux-demo app showing how to use it programmatically with Redux/setState?

Also need to resolve merge conflicts

could u plz merge this PR ?

@nimamyscreen this PR has merge conflicts and I don't believe it is in the package's best interests to have Redux-specific code in the source code. You can also easily use the code implemented in this PR in your own codebase, which would solve the need for merging this. If what you are after is a Redux application that uses React Native Orientation, we can have a redux-demo folder on the source code that would resolve this issue.


refactor: improve error handling in LoadTxInfo

Description
Improve error handling in LoadTxInfo
Replace panic with proper error returns in LoadTxInfo function to follow Go's
error handling conventions. This change:

Adds input validation for empty transaction hash
Returns descriptive error messages instead of panicking
Wraps underlying errors with context
Maintains backward compatibility with nil returns for not found cases

This is part of an ongoing effort to improve error handling patterns in the
codebase.
PR checklist

[x] Tests written/updated
[ ] Changelog entry added in .changelog (we use
unclog to manage our changelog)
[ ] Updated relevant documentation (docs/ or spec/) and code comments

What motivated this PR? Is this related to a GitHub issue in the repo?
Yeah,  i want to improve codebase

Hi @rootulp can you review this PR

Hi @rootulp, thank you for reviewing my PR.
I've updated the error msg in case of not found. Please check


NEW - RDM-1240 - search cases by metadata

JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/RDM-1240
Change description

Definition import process changed to add metadata fields to the parser context to support defining metadata fields in excel tabs.
State is added as a dynamic metadata field during import as it depends on case type
Introduced validations not to allow metadata fields in case field tab and should be read-only on case event fields tab
When retrieving case type information, the metadata fields will be added to the case type - case fields with fixed list values if a field is a fixed list

Does this PR introduce a breaking change? (check one with "x")
[ ] Yes
[ x] No

separated PR

Codecov Report

Merging #94 into master will increase coverage by 0.09%.
The diff coverage is 90.85%.

@@             Coverage Diff              @@
##             master      #94      +/-   ##
============================================
+ Coverage     88.83%   88.93%   +0.09%
- Complexity     1606     1655      +49
============================================
  Files           238      247       +9
  Lines          4255     4400     +145
  Branches        312      316       +4
============================================
+ Hits           3780     3913     +133
- Misses          423      431       +8
- Partials         52       56       +4

Impacted Files
Coverage Δ
Complexity Δ

...tore/domain/service/EntityToResponseDTOMapper.java
100% <ø> (ø)
0 <0> (ø)
:arrow_down:

...el/parser/StateMetadataCaseFieldEntityFactory.java
100% <100%> (ø)
7 <7> (?)

...d/definition/store/excel/parser/ParserFactory.java
100% <100%> (ø)
6 <1> (ø)
:arrow_down:

...eld/CaseFieldEntityMetadataFieldValidatorImpl.java
100% <100%> (ø)
5 <5> (?)

.../store/repository/model/WorkBasketResultField.java
100% <100%> (ø)
9 <2> (+2)
:arrow_up:

...definition/store/excel/parser/CaseFieldParser.java
100% <100%> (ø)
6 <0> (ø)
:arrow_down:

...cts/ccd/definition/store/FactoryConfiguration.java
100% <100%> (ø)
2 <2> (?)

...ion/store/repository/model/SearchResultsField.java
100% <100%> (ø)
9 <2> (+2)
:arrow_up:

...e/domain/service/casetype/CaseTypeServiceImpl.java
100% <100%> (ø)
10 <2> (+1)
:arrow_up:

...d/definition/store/repository/model/CaseField.java
100% <100%> (ø)
25 <2> (+2)
:arrow_up:

... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0518ca...f6716d0. Read the comment docs.


Add a one-click-try-out button

Describe the feature
something like:

we can use stackblitz.
Additional information
No response

I like the work going on here!
I will say you already have a one-click try-out button.

Thanks @j-wil -> awesome point ❤
Something else to add: With npm create sidebase@latest it has already become easier to try sidebase out locally (: But ofc. the one-click-tryout experience is still better / different (:

closing this for now, as I think the need is not super big atm + we already have a good option (see @j-wil 's comment)


fix CLI help for pack install

tiny change.

Shakes fist. LGTM. Will cherry pick to 2.1 once merged.

Current coverage is 77.54% (diff: 100%)

Merging #3065 into master will increase coverage by 0.19%

@@             master      #3065   diff @@
==========================================
  Files           430        430
  Lines         22017      22017
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits          17032      17073    +41
+ Misses         4985       4944    -41
  Partials          0          0

Diff Coverage
File Path

•••••••••• 100%
st2client/st2client/commands/pack.py

Powered by Codecov. Last update 6bd5706...0fc5d53


Updated pom.xml to remove mina-core additional dependency

Thanks for the PR @aniket0788. I think you may need to remove the dependency on the quickfixj-spring-boot-starter module too.

@esanchezros - My Bad, missed it ! Created another commit ..

Thanks @aniket0788


Reentrancy

ribosomes.

Included in https://github.com/nox/mitochondria/commit/90bf10dd66b7dfbe02a7527b5f7407a400bd28dd. Thanks!


[Improve][Connector-v2] The hive connector support multiple filesystem

Purpose of this pull request

Hive connector support multiple filesystem for issue #6641
Does this PR introduce any user-facing change?

How was this patch tested?

Check list

[ ] If any new Jar binary package adding in your PR, please add License Notice according
New License Guide
[ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/seatunnel/tree/dev/docs
[ ] If you are contributing the connector code, please check that the following files are updated:

Update change log that in connector document. For more details you can refer to connector-v2
Update plugin-mapping.properties and add new connector information in it
Update the pom file of seatunnel-dist

[ ] Update the release-note.

cc @EricJoy2048

cc @EricJoy2048

Thanks, I will have a look.

Please add e2e test for this pr.

Please add e2e test for this pr.

The hive connector has no e2e tests before. And there doesn't seem to be any mirrors that can support this e2e test. I can provide e2e test cases, but I don't have test environments for cos, oss, and s3.

Please add e2e test for this pr.

The hive connector has no e2e tests before. And there doesn't seem to be any mirrors that can support this e2e test. I can provide e2e test cases, but I don't have test environments for cos, oss, and s3.

You can add e2e test case and then test in your local and upload a screenshot of successful testing. Before you push code, you can add @Disable to disable the e2e.

HDFS:

EMR(Hive on s3):

write:

read: