Multiple modals won't open reliably

If I have 2 modals, one of them won't open reliably. In this example if I repeatedly click Open Second it will stop opening after a few tries. Opening the first modal then opening the second will work again (at least once).
Edit: The second modal will always open when I press esc to dismiss, if I click to dismiss it will stop opening.
I'm currently avoiding this by calling dismissAll() on the BsModalService before opening a modal.
import { Component, OnInit, ViewChild } from '@angular/core';
import { BsModalComponent } from 'ng2-bs3-modal';

@Component({
  selector: 'ng-test',
  templateUrl: './test.component.html',
  styleUrls: ['./test.component.css']
})
export class TestComponent {

  @ViewChild('firstModal')
  firstModal: BsModalComponent;

  @ViewChild('secondModal')
  secondModal: BsModalComponent;

  constructor() { }

  openFirst() {
    this.firstModal.open();
  }

  openSecond() {
    this.secondModal.open();
  }
}

<button (click)="openFirst()">Open First</button>
<button (click)="openSecond()">Open Second</button>

<bs-modal #firstModal>
    <bs-modal-body>
        First Contents
    </bs-modal-body>
</bs-modal>

<bs-modal #secondModal>
    <bs-modal-body>
        Second Contents
    </bs-modal-body>
</bs-modal>

Same problem here. Any fix or workaround available?

Yes, from my original post:

I'm currently avoiding this by calling dismissAll() on the BsModalService before opening a modal.

Sorry. Already tried it, but your fix is not working for me.


[BPR alignment] [Utilities] Align CARML and BPM tooling (Readme generator)

The main concern is to align our tooling (e.g., Set-ModuleReadMe.ps1) and the BPM tool. Areas to consider area

The BPM Tool not only updates the ReadMes, but also boostraps files & folders that we must align on
The resulting ReadMe must align (all sections)

Resource Types
Parameters
Examples
Considerations
Outputs

Section
CARML
BPR
Note

Title
Generated from folder hierarchy. e.g., Analysis Services Servers [Microsoft.AnalysisServices/servers]
Taken from metadata.json

Description
Located below title – but without header

Navigation

NA

Resource Types

NA

Parameters
Organized in sub-tables based on parameter category (Required, Optional, Generated,…)  Links parameters to other readme’s (e.g., child-modules)  Parameter NameTypeDefault ValueAllowed ValuesDescription
Single table  NameTypeRequiredDescription

Considerations
Optional, manual
NA

Outputs
Output NameTypeDescription
NameTypeDescription

References
'Cross-referenced modules'  List of local references outside of the module
Not present since not used

Examples
'Deployment Examples'  Generated from test cases (be it from ARM or Bicep)  Displays parameters alphabetically & grouped into required & non-required
'Examples'

Note: https://github.com/Azure/bicep-registry-modules/issues/350

Not relevant anymore. Tooling was updated


Blur Active Element

When closing a modal or clicking a link, blur the activeElement so the browser retains no state of focus.

Automated message from Dropbox CLA bot
@brockwhittaker, it looks like you've already signed the Dropbox CLA. Thanks!

This looks good; merged, thanks @brockwhittaker!

Actually one question -- should we do the same thing when exiting the other overlays?


sql: add Native value to Type.

Native converts a value of Type into a driver.Value.
This is required for compatibility with the database/sql API.

Converting any of our values to a driver.Value is a requirement to implement the standard database/sql interface.

Current coverage is 60.50% (diff: 0.00%)

Merging #104 into master will decrease coverage by 0.51%

@@             master       #104   diff @@
==========================================
  Files            40         40
  Lines          1652       1666    +14
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
  Hits           1008       1008
- Misses          585        599    +14
  Partials         59         59

Powered by Codecov. Last update b66aa93...c3b268c


Add/Edit/remove property on node.

It would be a nice feature if it was possible to add, change and remove properties from nodes.
This could then be used to perform content jobs on aem instances.

Essentially you can do this already -- though there may not be a proper example for this the sling post servlet does allow for this: https://sling.apache.org/documentation/bundles/manipulating-content-the-slingpostservlet-servlets-post.html#setting-property-values


Issue installing extension

Thanks for pushing out that feature so fast!
Unfortunately, I can't seem to download the extension now:
    at Q.downloadExtension (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:83:169038)
    at async Q.doRun (vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/sharedProcess/sharedProcessMain.js:83:168169)

Restarting vscode a few times fixed this.


CacheWarmer and CacheClearer are not compatible with Symfony 3 and Syfmony 4

This is due to Contentful\ContentfulBundle\Cache\Delivery\CacheWarmer::warmUp Contentful\ContentfulBundle\Cache\Delivery\CacheClearer::clear using string typehints for arguments, thus causing fatal errors, while said methods in Symfony 3.4 and 4.4 miss the typehint.
Removing typehints would be enough, since you can remove parameter typehints in extending classes (contravariance), but you cannot add them if parent doesn't have them.
https://3v4l.org/Xl2Oc
I haven't tested all parts of the bundle, so there may be more instances of issues like this.

Thanks @emodric makes sense. We just pushed a patch release to address this issue.

Thanks!


Update microsoft-defender-endpoint-android.md

Updated the document with the license requirement (intune license)

@JohanFreelancer9 Please copy review

issue#https://github.com/MicrosoftDocs/microsoft-365-docs/issues/8340

@Dansimp Please merge this PR. thanks


.allowInClientCode() unexpectedly applies to all rules of that type

I've just noticed that .allowInClientCode() applies to all the rules of that type instead of just the rule to which it was chained. So in the following example, somebody with the "user" role will also be able to insert or remove documents for Collection from the client-side, even though the .allowInClientCode() method was only called for the rule concerning the "administrator" role (he still cannot update though):
Collection
  .permit( [ "insert", "update", "remove" ] )
  .ifHasRole( {
    role: "administrator",
  } )
  .allowInClientCode();

Collection
  .permit( [ "insert", "remove" ] )
  .ifHasRole( {
    role: "user",
  } );

Is this by design? If so, maybe it should probably be made clear in the documentation because it definitely caught me by surprise.

This package is no longer being updated or supported by Reaction.


Add GIOU loss

Implementation of GIOU loss

Hi @fsx950223 thank you for this contribution and #493 . Just wanted to let you know that we'll review ASAP, but are a bit backed up given the work that has been going into building packages for newly released TF2 packages.
Also, just for the future.. if you wouldn't mind opening an issue to discuss before submitting a PR that'd be much appreciated.

Hi @fsx950223 thank you for this contribution and #493 . Just wanted to let you know that we'll review ASAP, but are a bit backed up given the work that has been going into building packages for newly released TF2 packages.
Also, just for the future.. if you wouldn't mind opening an issue to discuss before submitting a PR that'd be much appreciated.

OK

@Squadrick Hi, Dheeraj, could you take a look if you have time? Thanks :-)

Hi @fsx950223 , sorry for the late reply. I have taken a deeper look into the paper, but want to give you some general feedback on this. Also, if it's possible, could you elaborate how to compute GIoU in test cases or any other places? Thanks!

I will modify the code on the weekend.

Changed. @WindQAQ

Changed.

only works on match bboxs, still have a lot of work to do.

There are some tricks by using broadcasts to calculate unmatched gious.


Upgrade to DJL 0.7.0

Issue #, if available:
Description of changes:
Upgrade to DJL 0.7.0 version, integrated BOM
mxnet.native.version, pytorch.native.version, tensorflow.native.version could be sourced from BOM as well, shall I remove them?
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Let me release 0.6 and you will need to rebase. Other than that looks good and thank you for your contribution!

This is done, the PR is approved.


Can't cancel frames processing right after capturing a gif

Hey there!
Sometimes I would like to cancel recorded frames processing which happens right after capture. I see red cross icon, press it but it still keeps processing and cancels only when processing is finished.
I'm using version 2.33.1

I'll have a look at this

What I could find that was not working was that the first processing action didn't update the UI (so no progress - fixed that) but it was correctly responding to the cancel. What was not working correctly was in the automated tasks (mouse click, key stokes, etc.) and I've added a check to stop them when the request was made.


Consuming dropped files is too cumbersome

Currently there are three separate ways to consume dropped content

File URI (desktop)
Actual content (desktop, mobile)
Virtual files (mac, windows, iOS)

Which of these (or a combination) need to be handled depends on platform and source application.
This needs to be streamlined. There should be unified API to consume dropped content that would provide the highest possible fidelity by default.

Fixed via https://github.com/superlistapp/super_native_extensions/pull/47.


regex-redux benchmark is not #1

I'm trying to improve regexredux.rust-4.rust at Benchmark Games, but, as I can see, AhoCorasickBuilder uses major share of the CPU. IMHO,  this is a bug.
[vlisivka@localhost src]$ cargo profiler callgrind --release <regexredux-input50000000.txt

Compiling rust-regex-redux in release mode...

Profiling rust-regex-redux with callgrind...

Total Instructions...8,272,585

2,353,140 (28.4%) ???:aho_corasick::ahocorasick::AhoCorasickBuilder
-----------------------------------------------------------------------
740,239 (8.9%) ???:_int_malloc
-----------------------------------------------------------------------
681,110 (8.2%) ???:_int_free
-----------------------------------------------------------------------
458,461 (5.5%<EMAIL_ADDRESS>-----------------------------------------------------------------------
369,736 (4.5%) ???:<aho_corasick::nfa::State<S>>
-----------------------------------------------------------------------
308,696 (3.7%) ???:malloc
-----------------------------------------------------------------------
240,444 (2.9%) ???:realloc
-----------------------------------------------------------------------
229,390 (2.8%) ???:aho_corasick::dfa::Builder::build
-----------------------------------------------------------------------
182,489 (2.2%) ???:free
-----------------------------------------------------------------------
172,837 (2.1%) ???:regex_syntax::hir::literal::Literals

Sorry, but this bug report is not actionable. Please do not file bugs based simply on the output of a profile. Instead, provide a complete program that clearly shows the performance bug.
In particular, if you run perf, then the profile results are completely different from your output, and I'm much more inclined to trust perf than I am callgrind:

Moreover, the results shown by perf are generally what I'd epxect. Most of the time is being spent in Teddy and iterating over matches.

AhoCorasickBuilder is not optimized

That's wrong. It is optimized. It's likely it could be micro-optimized a bit more, but generally speaking, its construction time will be dwarfed by search time and/or overall compilation time of a regex.

Here is the whole program. I converted it from bytes to strings and replaced macros by function, to make it less scary. I turned off unicode support (except for 3 regex'es). Currently, I'm out of ideas, while C version is about 30% faster. Any suggestions?
// The Computer Language Benchmarks Game
// https://salsa.debian.org/benchmarksgame-team/benchmarksgame/
//
// contributed by Tom Kaitchuck
// contributed by Volodymyr M. Lisivka

extern crate regex;
use regex::Regex;

use std::io::{self, Read};
use std::thread;

fn regex(re: &str) -> Regex {
    regex::RegexBuilder::new(re).unicode(false).build().unwrap()
}

fn count_reverse_complements(sequence: String) -> Vec<String> {
    // Search for occurrences of the following patterns:
    let variants = vec![
        "agggtaaa|tttaccct",
        "[cgt]gggtaaa|tttaccc[acg]",
        "a[act]ggtaaa|tttacc[agt]t",
        "ag[act]gtaaa|tttac[agt]ct",
        "agg[act]taaa|ttta[agt]cct",
        "aggg[acg]aaa|ttt[cgt]ccct",
        "agggt[cgt]aa|tt[acg]accct",
        "agggta[cgt]a|t[acg]taccct",
        "agggtaa[cgt]|[acg]ttaccct",
    ];
    variants
        .iter()
        .map(|variant| {
            format!(
                "{} {}",
                variant,
                regex(variant).find_iter(&sequence).count()
            )
        })
        .collect()
}

fn find_replaced_sequence_length(sequence: String) -> usize {
    // Replace the following patterns, one at a time:
    let substs = vec![
        ("tHa[Nt]", "<4>"),
        ("aND|caN|Ha[DS]|WaS", "<3>"),
        ("a[NSt]|BY", "<2>"),
        ("(?u)<[^>]*>", "|"),
        ("(?u)\\|[^|][^|]*\\|", "-"),
    ];
    let mut seq = sequence;

    // Perform the replacements in the sequence:
    for (re, replacement) in substs {
        seq = regex(re).replace_all(&seq, regex::NoExpand(replacement)).into_owned();
    }
    seq.len()
}

fn main() {
    // Read whole input into String.
    let mut input = String::new();
    io::stdin().read_to_string(&mut input).unwrap();
    let input_len = input.len();

    // Erase comments, e.g. '>ONE Homo sapiens alu', and new line symbols.
    let sequence = regex("(?u)>[^\n]*\n|\n")
        .replace_all(&input, regex::NoExpand(""))
        .into_owned();

    // Length of cleared input.
    let clen = sequence.len();

    // Create copy of the input to perform replacements at.
    let seq_clone = sequence.clone();

    // Run two functions in separate threads, because they are independent.
    let result = thread::spawn(|| find_replaced_sequence_length(seq_clone));
    let counts = thread::spawn(|| count_reverse_complements(sequence));

    // Print results
    for variant in counts.join().unwrap() {
        println!("{}", variant)
    }
    println!("\n{}\n{}\n{:?}", input_len, clen, result.join().unwrap());
}

Any suggestions?

Nothing simple, no. I'm pretty sure you can't micro-optimize your way out of this one. In particular, none of your changes should really have any impact, and in particular, switching to strings is likely to make things slower since you end up needing to do a UTF-8 validation check on the input for no good reason.
The path to glory on this particular benchmark is likely a clever optimization in the regex engine. In particular, this benchmark, IIRC, iterates over a fair number of matches. For each match, the regex engine must scan the matched text in reverse to find the starting location of the match, where as PCRE2 does not (since it's a backtracking engine). This additional scan, IIRC, is a key reason for the performance difference. Figuring out how to remove this scan is non-trivial and it's not clear to me that it's possible. The regex engine internals are not amenable to it, so not only would I not want to attempt this until the internals have been refactored to be more flexible to particular types of optimizations, but I'd also want to see a good argument for why the complexity is worth it. Scoring a few points on the benchmark game on ancient hardware isn't enough.
It is possible you might be able to make up the match overhead somewhere else, but I'm not sure where. Maybe making Teddy faster is the path to glory. Not sure. You also might consider figuring out how to benchmark on the same hardware used by the game, since optimizations like Teddy depend on specific CPU features that might not be available in the game.
Of course, I could be wrong about all of this and maybe there is something simple. But you asked for my suggestions, and these are my current opinions based on my recollection.

Yep, Unicode support slows down code by about 1/40. Not a big deal for me, while code looks much cleaner.
Yep, I currently sittings at my parents Core2 Duo.
I had success with minor change to binary-trees. Now it faster than C.
As I see, most of the time reredux program spends at replace. When I commented out call to count_reverse_complements(), execution time dropped by about 5%. Here is report for perf -F 99 -g :
+   49,12%    49,12%  rust-regex-redu  rust-regex-redux    [.] <regex::re_trait::Matches<'t, R> as core::iter::traits::iterator::Iterator>::next
+   13,33%    13,33%  rust-regex-redu  libc-2.26.so        [.] __memcpy_ssse3
+    9,27%     9,27%  rust-regex-redu  rust-regex-redux    [.] regex::literal::teddy_ssse3::imp::Teddy::find_impl
+    8,10%     0,00%  rust-regex-redu  [unknown]           [.] 0x0000000000000001
+    7,56%     7,56%  rust-regex-redu  rust-regex-redux    [.] regex::re_unicode::Regex::replace_all
+    5,25%     0,00%  rust-regex-redu  [unknown]           [.] 0x4347475447474347

It looks like code can be improved a bit by spending less on copying of data and by grouping of multiple regex-es into single regex with a smart closure, which will return correct replacement for a match.

and by grouping of multiple regex-es into single regex with a smart closure

It is not obvious to me that this change would be accepted by the game maintainer, but you can try.


brooklyn-tosca can be disabled

Either give -Dbrooklyn.experimental.feature.tosca=false or set the property in brooklyn.properties.

Can you update the README too, please

LGTM; merging


vk_video_encoder: define VULKAN_HPP_NO_TO_STRING

Mismatch version between 1.3.238 and 1.3.243 leads to issues with vk::to_string

here is a workaround to fix #38

Thank you, Stephan!


Add ability to switch spaces using the menubar buttons

Currently the app only shows which space I'm on but I already know which space I'm on. I'd love to have the ability to switch spaces using the menubar buttons.

First off-- Thanks a ton for this nifty little tool. It's supremely useful.
To add to the OP's comment -- I keep clicking on the named spaces as if they were buttons. I know they're not. I know the keyboard shortcuts to toggle between spaces. I know that three fingers on a trackpad will do the same thing.
I know it's my fault.
Doesn't change the fact that this would be a super useful enhancement. Even if to make me feel better about clicking on dummy buttons.
(really, thanks again for this little tool).


Can we include this extension in the debugging view (current insider feature)

I do wonder if it is possible to register this extension to include the "show definition" command to the navigation group in the variable context menu or if this must be done from the debugging extension - see https://github.com/microsoft/vscode/issues/70377 for details.

Reading the link, it most certainly will need to be done in each COBOL debugger extension.

Thanks for the check.


use ssl.create_default_context and SNI if available

I ran into a ssl certificate verification problem using buildout and a private package index using SNI.
The usual workaround to make sure that the ssl cert of the private registry server defaults to the package index hostname was not possible this time, so I thought I'll fix it at the core and use SNI when connecting to a ssl server.
Happy to ammend this pull request in any way, but I do believe that something like this would be good to have as it also uses good practice ssl settings maintained in python core ssl.py module, and sticks to officially document methods in ssl module.

Ok


Simplifying the structure of val_set, and using a consistent strategy when lazy-loading val_set

What does this PR do?

fixing #271;
fixing #270;

Before submitting

[x] This PR is made to fix a typo or improve the docs (you can dismiss the other checks if this is the case).
[x] Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have written necessary tests and already run them locally.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

263 of 319 (82.45%)  changed or added relevant lines in 31 files are covered.
10 unchanged lines in 4 files lost coverage.
Overall coverage increased (+0.5%) to 82.883%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

pypots/data/checking.py
9
10
90.0%

pypots/imputation/brits/model.py
8
9
88.89%

pypots/imputation/csdi/model.py
9
10
90.0%

pypots/imputation/gpvae/model.py
8
9
88.89%

pypots/imputation/mrnn/model.py
8
9
88.89%

pypots/imputation/saits/model.py
7
8
87.5%

pypots/imputation/timesnet/model.py
7
8
87.5%

pypots/imputation/transformer/model.py
7
8
87.5%

pypots/imputation/usgan/model.py
8
9
88.89%

pypots/data/utils.py
6
9
66.67%

Files with Coverage Reduction
New Missed Lines
%

pypots/classification/base.py
1
74.07%

pypots/classification/brits/model.py
3
95.31%

pypots/cli/env.py
3
61.22%

pypots/data/saving/h5.py
3
81.48%

Totals

Change from base Build<PHONE_NUMBER>:
0.5%

Covered Lines:
4934

Relevant Lines:
5953

💛  - Coveralls


Protostar deployment issues

Protostar version

Name
Version

Protostar
0.3.1

Cairo-lang
0.9.1

Git
2.37.1

Current Behavior

after updating my protostar to 0.3.1, my deployed contracts to alpha-goerli testnet using the protostar deploy command no longer shows up on Voyager
Expected Behavior

Right before the update, after deploying my contracts, it takes about few minutes to show up on voyager, but its over 12 hours now, and my deployments are not showing up yet. Confused as to if its an issue with Voyager or Protostar
Steps to Reproduce

run the protostar deploy command
protostar deploy ./build/main_ex1.json --network alpha-goerli --inputs<PHONE_NUMBER>96<PHONE_NUMBER> 5 0<PHONE_NUMBER>58309430053914102603121793915440959967340882752864723702445055560<PHONE_NUMBER>00000000000 0

copy the link to the deployed link on voyager to check if it shows up.

Possible Solution

Same problem when trying to deploy on a local dev-net. Use to be done in a few seconds, still waiting for it to happen.

Hello @Darlington02, @tdelabro
Does this issue still occur?
If yes can you provide more details? We are currently unable to replicate this behaviour.

Yes it still ver much occurs @Radinyn
i am trying to deploy a simple ERC20 contract using openzeppelin's library, contract can be found here.
https://github.com/Darlington02/starknet-edu-ERC20/blob/master/src/ERC20_ex1.cairo
here's how my constructor looks
func constructor{
        syscall_ptr : felt*,
        pedersen_ptr : HashBuiltin*,
        range_check_ptr
    }(name: felt, symbol: felt, decimals: felt, totalSupply: Uint256, owner: felt):
    alloc_locals
    # initialize an owner
    Ownable.initializer(owner)

    ERC20.initializer(name, symbol, decimals)
    ERC20._mint(owner, totalSupply)
    return ()
end

so during the deployment, i provide input arguments of name(in felt), symbols (in felt), decimals (in felt), totalSupply and owner(in felt). my deployment command looks like this
protostar -p testnet deploy ./build/main_ex1.json --inputs<PHONE_NUMBER>96<PHONE_NUMBER> 18 0<PHONE_NUMBER>00000000000<PHONE_NUMBER>58309430053914102603121793915440959967340882752864723702445055560

when i run the command, it throws no error and says successfully deployed
18:03:47 [INFO] Deploy transaction was sent.
Contract address: 0x01684b594a8b9c8c6341d562d9a0314d28867def3a2bb5d0af1ffb1d029e586f
Transaction hash:<PHONE_NUMBER>590418255238645330081822482805330561623597172601516111667613133063

https://goerli.voyager.online/contract/0x01684b594a8b9c8c6341d562d9a0314d28867def3a2bb5d0af1ffb1d029e586f

but when i open the contract, on voyager, it throws a 404 contract not found, even after waiting for long hours.
P.S i noticed, i'm able to deploy simple contracts with no constructor, like the boiler contract that comes with protostar, and view them on voyager,  but having issues with contracts that accept constructor arguments.
Lastly, im new to cairo, and might probably be doing something wrong, but i think if my deployment command was wrong, protostar should have thrown an error or something.

Thank you @Darlington02,
We are still working on reproducing this behaviour.
Could you check what happens when you run it with the --wait-for-acceptance flag?
Also, what OS are you using?

Wil try that now.
I use macos, m1 chip

Hi @Radinyn
Finally found a solution to the deployment issues. turns out i was trying to assign a felt to a Uint256 in the constructor.
But what i'm curious about is why didn't protostar throw an error of some sort? but rather deployed a non-existent contract?
I hope this can be fixed in future versions🙏🏽
Thanks for your assistance.


feat(array): introduce DataChunkBuilder and split chunks in HashJoinExecutor

The PR introduces DataChunkBuilder, which is responsible for two things:

Ensure that all columns are pushed with the same size.
Ensure that the size of the DataChunk should not be greater than capacity.

Signed-off-by: TennyZhuang<EMAIL_ADDRESS>

Don't consume the builder when the size reaches the limit, so that users will no longer need to rebuild it by themselves.

But it can force users to handle the finished DataChunk correctly by compiler error instead of just lint (

Provide a helper macro to simplify the usage.

Unfortunately, macros does not work well with yield.

@wangrunji0408 PTAL


fix(project-link-centered): centered links in the project card

Centered the links in the project cards
Before:

After:

Great job @Nishaaaanth!! I'll check it out and get back to you.

@tobySolutions yeah sure no problems!


[Question] app_auth at begin delete db data,then search db, need db not empty,what this mean?

Question

@seetbw I think it's a bug. This has to be search from db before it's deleted. Can you fix it?


@graphql-mesh/cross-helpers has unmet peer dependency "react-native@*"

Issue workflow progress

Progress of the issue based on the Contributor Workflow

[ ] 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.

[ ] 2. A failing test has been provided
[ ] 3. A local solution has been provided
[ ] 4. A pull request is pending review

Describe the bug
GraphQL mesh expects react-native to be installed. Can we move this to optionalDependencies or something?
warning "workspace-aggregator-3164c39f-ca88-4079-a857-5ad31379d5f2 > @graphcommerce/cli > @graphql-mesh/cli > @graphql-mesh/cross-helpers ><EMAIL_ADDRESS>has unmet peer dependency "react-native@*"

To Reproduce
Steps to reproduce the behavior:
Install graphql-mesh

Expected behavior
No unmet peer dependency errors.

Environment:

OS:
@graphql-mesh/...:
NodeJS:

Additional context

@ardatan any update on this?

Solved in the latest release!


Non-applyDynamic-based Rec constructor for use with varargs

I'd like to be able to manipulate the key-value tuples before creating a Rec rather than passing in literals, but this compiler bug is preventing me from accomplishing this with Rec(tuples: _*).
Is there a way to create a record from a Seq[(String, Any)] or a Map[String, Any] that I'm missing, or is this use case not supported?

Depends, if you have the values for Seq[(String, Any)] or a Map[String, Any] at compile time it would be possible. However, if you need to do computations on record fields it is impossible to achieve this as the record types that are computed during type checking would only be available at runtime.
The only way to achieve this would be to do all your computations at compile time. Scala records support only literals because they are always known at compile time. For the rest you would have to use the macros that provided by the library.

That makes sense. Using a macro that calls Macros.apply_impl worked well for my use case, since I ended up needing to use eval anyway. But it might still be nice to be able to do something like:
def myRecWrapper(v: (String, Any)*): Rec[Any] = {
  println(v)
  Rec(v: _*)
}

myRecWrapper("literals" -> "like usual")

without needing to write a custom macro.

Yes, for something like this you would need  inline which is proposed as a SIP.


tf-nightly container has CUDA error on 'docker run'

Please make sure that this is a build/installation issue. As per our GitHub Policy, we only address code/doc bugs, performance issues, feature requests and build/installation issues on GitHub. tag:build_template
System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Ubuntu 16.04.6 LTS
TensorFlow installed from (source or binary): Docker
Docker image: tensorflow/tensorflow:nightly-gpu-jupyter
GPU model and memory: GeForce GTX 108 / 261MiB / 11178MiB

Describe the problem
Error regarding CUDA>=11.0 when running most recent nightly container
Provide the exact sequence of commands / steps that you executed before running into the problem
Dockerfile
FROM tensorflow/tensorflow:nightly-gpu-jupyter

RUN pip install -U pip

# install packages
RUN apt-get update -qq && apt-get install --no-install-recommends -y \
    libsm6 \
    libxext6 \
    libxrender-dev \
 && apt-get clean \
 && rm -rf /var/lib/apt/lists/*

COPY requirements.txt /tmp/
RUN pip install --requirement /tmp/requirements.txt
COPY . /tmp/

WORKDIR /tf/

CMD jupyter lab --ip=<IP_ADDRESS> --notebook-dir=/tf --allow-root

requirements.txt
tensorflow-hub
imbalanced-learn==0.7.0
jupyterlab==2.1.2
opencv-python==<IP_ADDRESS>
pandas==1.0.3
Pillow==7.1.2
ptvsd==4.3.2
scikit-learn==0.23.2
scipy==1.4.1
seaborn==0.11.0
sklearn==0.0
xlrd==1.2.0

Build image
$ docker build --no-cache=true -t tf:tf-nightly .

Run container:
$ nvidia-docker run --rm -d -v /home:/tf -p 9896:8888 tf:tf-nightly

Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.
Error:
docker: Error response from daemon: OCI runtime create failed: container_linux.go:345: starting container process caused "process_linux.go:430: container init caused \"process_linux.go:413: running prestart hook 1 caused \\\"error running hook: exit status 1, stdout: , stderr: nvidia-container-cli: requirement error: unsatisfied condition: cuda>=11.0\\\\n\\\"\"": unknown.

@tjdurant,
The latest TF-nightly release required CUDA 11 and cuDNN 8.
Could you please specify the CUDA and cuDNN version installed on your machine and check if you are facing the same error with CUDA 11 and cuDNN 8 as well? Thanks!

@amahendrakar , i'm sorry because I may have had a knowledge gap on this one. Is the CUDA version you're looking for the version on the local machine or in the Docker container? Or both?


Updating from 0.3.3 to 0.4.0 fails

Attempting to update from v0.3.3 to v0.4.0 fails with the following log error:  Attempts made from within Atom and from ``apm``` CLI:
Updating to<EMAIL_ADDRESS>failed.Hide output…

><EMAIL_ADDRESS>install /private/var/folders/z_/0v_4k9nn3cd0stvnkwrx1bm00000gp/T/apm-install-dir-115120-54452-1pve1q1/node_modules/geojson-preview/node_modules/pathwatcher/node_modules/runas
> node-gyp rebuild

  CXX(target) Release/obj.target/runas/src/main.o

In file included from ../src/main.cc:1:
../../nan/nan.h:623:19: error: no type named 'ExternalAsciiStringResource' in 'v8::String'; did you mean 'ExternalStringResource'?
      v8::String::ExternalAsciiStringResource *resource) {
      ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
                  ExternalStringResource
/Users/.../.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1936:19: note: 'ExternalStringResource' declared here
  class V8_EXPORT ExternalStringResource
                  ^
In file included from ../src/main.cc:1:
../../nan/nan.h:622:36: error: redefinition of 'NanNew'
  NAN_INLINE v8::Local<v8::String> NanNew(
                                   ^
../../nan/nan.h:617:36: note: previous definition is here
  NAN_INLINE v8::Local<v8::String> NanNew(
                                   ^
../../nan/nan.h:1993:12: error: no member named 'IsExternalAscii' in 'v8::String'; did you mean 'IsExternal'?
  if (str->IsExternalAscii()) {
           ^~~~~~~~~~~~~~~
           IsExternal
/Users/.../.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1900:8: note: 'IsExternal' declared here
  bool IsExternal() const;
       ^
In file included from ../src/main.cc:1:
../../nan/nan.h:1994:23: error: no type named 'ExternalAsciiStringResource' in 'v8::String'; did you mean 'ExternalStringResource'?
    const v8::String::ExternalAsciiStringResource* ext;
          ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
                      ExternalStringResource
/Users/.../.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:1936:19: note: 'ExternalStringResource' declared here
  class V8_EXPORT ExternalStringResource
                  ^
In file included from ../src/main.cc:1:
../../nan/nan.h:1995:16: error: no member named 'GetExternalAsciiStringResource' in 'v8::String'; did you mean 'GetExternalOneByteStringResource'?
    ext = str->GetExternalAsciiStringResource();
               ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
               GetExternalOneByteStringResource
/Users/.../.atom/.node-gyp/.node-gyp/0.21.0/deps/v8/include/v8.h:2003:40: note: 'GetExternalOneByteStringResource' declared here
  const ExternalOneByteStringResource* GetExternalOneByteStringResource() const;
                                       ^
In file included from ../src/main.cc:1:
../../nan/nan.h:1995:9: error: assigning to 'const v8::String::ExternalStringResource *' from incompatible type 'const v8::String::ExternalOneByteStringResource *'
    ext = str->GetExternalAsciiStringResource();
        ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../nan/nan.h:1996:11: error: assigning to 'const char *' from incompatible type 'const uint16_t *' (aka 'const unsigned short *')
    *data = ext->data();
          ^ ~~~~~~~~~~~
7 errors generated.
make: *** [Release/obj.target/runas/src/main.o] Error 1
gyp ERR! build error
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/lib/build.js:267:23)
gyp ERR! stack     at ChildProcess.emit (events.js:98:17)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (child_process.js:820:12)
gyp ERR! System Darwin 14.1.0
gyp ERR! command "node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /private/var/folders/z_/0v_4k9nn3cd0stvnkwrx1bm00000gp/T/apm-install-dir-115120-54452-1pve1q1/node_modules/geojson-preview/node_modules/pathwatcher/node_modules/runas
gyp ERR! node -v v0.10.35
gyp ERR! node-gyp -v v1.0.2
gyp ERR! not ok
npm ERR! Darwin 14.1.0
npm ERR! argv "/Applications/Atom.app/Contents/Resources/app/apm/bin/node" "/Applications/Atom.app/Contents/Resources/app/apm/node_modules/npm/bin/npm-cli.js" "--globalconfig" "/Users/.../.atom/.apm/.apmrc" "--userconfig" "/Users/.../.atom/.apmrc" "install" "/private/var/folders/z_/0v_4k9nn3cd0stvnkwrx1bm00000gp/T/d-115120-54452-1gepn8y/package.tgz" "--target=0.21.0" "--arch=x64"
npm ERR! node v0.10.35
npm ERR! npm  v2.3.0
npm ERR! code ELIFECYCLE

npm ERR<EMAIL_ADDRESS>install: `node-gyp rebuild`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the<EMAIL_ADDRESS>install script 'node-gyp rebuild'.
npm ERR! This is most likely a problem with the runas package,
npm ERR! not with npm itself.
npm ERR! Tell the author that this fails on your system:
npm ERR!     node-gyp rebuild
npm ERR! You can get their info via:
npm ERR!     npm owner ls runas
npm ERR! There is likely additional logging output above.

npm ERR! Please include the following file with any support request:
npm ERR!     /private/var/folders/z_/0v_4k9nn3cd0stvnkwrx1bm00000gp/T/apm-install-dir-115120-54452-1pve1q1/npm-debug.log

Atom v0.179.0.  I uninstalled and attempted to reinstall and received the same error:
$ apm install geojson-preview
Installing geojson-preview to /Users/.../.atom/packages ✗

I should also add that v0.3.3 was no longer working with the latest versions of Atom (latest v0.179.0)

:+1:

same here. I guess this project is dead?

I guess this project is dead?

I havent had time to look into this, atom has changed a lot, looks will require some bigger changes. I'll try to find some time to look into it, but PRs are also appreciated :)


chore(main): release 1.1.1

:robot: I have created a release beep boop
1.1.1 (2024-09-23)
Bug Fixes

dhis2: do not raise authentication errors for old versions (3e0eb93)

This PR was generated with Release Please. See documentation.

:robot: Release is at https://github.com/BLSQ/openhexa-toolbox/releases/tag/v1.1.1 :sunflower:


DDOS protection dissconnect client

Hello. Established not long ago, protection against DDOS attacks. But there was a problem with the worker.
The connection began to stupidly close after 5 minutes of inactivity. Are there any methods to fix this? JS keep alive timeout - did not help for some reason.

Try to  send  "heartbeat" message to workerman every specified time interval for example every 50 seconds.
If the connection still closed unexpected try to shorten the time interval by 25 seconds.

Hello. I tried this option:
$worker->onWorkerStart = function($worker)
{
    $time_interval = 10;
    $timer_id = Timer::add($time_interval,
        function() use ($worker)
        {
            foreach($worker->connections as $connection) {
                $connection->send(pack('H*', '890400000000'), true);
                //echo "Heartbeat...";
            }
        }
    );

All the same, websockets are closed.
Tried through js, works ... But periodically also closes the connection.
Why is that?

Try to connect workerman directly. Do not use DDOS protection.


Tighten the sample aggregation threshold

Improves the speedscope exporter for compatibility with speedscope 1.6.0 or above (https://github.com/jlfwong/speedscope/pull/273).
This is a workaround for https://github.com/microsoft/perfview/issues/1178#issuecomment-638664301. Since I don't know the reason for the original value (1.2), the new value is a simple compromise between 1.0 and 1.2.
@adamsitnik Could you test if you agree with this change?

Hi @swift-kim
Please excuse me for the delay.
I've started testing your fix today and I wanted to extend it with some validation logic that ensures that the output is correct (every close event is preceded by an open event with the same depth and frame id).
Code: https://github.com/adamsitnik/perfview/commit/f5415222a6400ccbb434579eab7549b96bdf61b1
Unfortunately, I've found some cases for very big trace files where even with aggregation threshold = 1.0 the exporter is producing invalid results. I need to wrap my head around it and figure out a proper solution. It might require rewriting the exporter from scratch.

@adamsitnik Yes, I've also found such cases (Weather.6625.zip/VoiceMemo.13755.zip - I haven't yet investigated the files though) and been thinking about a proper way to validate outputs.
If you manage to do so, it will preclude the need for this request to the speedscope side. I really appreciate all your help!


Fix configs and add them to the test workflow

We have a lot of configs in the net_configs, but most of them are not working. We should fix all of them and add them to the https://github.com/vegaprotocol/vegacapsule/blob/main/.github/workflows/start-stop-network-test-configs.yml

closed as complete


TS-611: Fix typo. Add missing card payment statuses

Documentation has a typo, platform team confirmed that. I added missing card payment statuses additionally

Open question, do we want to have payment statuses defined as enum instead of a string? If new payment status is introduced, it breaks the library

At the moment, library throws exception if enum is not found. Are we good with this serialisation behaviour? Perhaps it would be good to make each enum property in models nullable?

@grantas33 it is a legit comment. Is it possible to fallback to unrecognized enum property?

The coerceInputValues property in the serializer helps

I did unknown enum handling in my way. A default enum value for a fallback is also an option, but not sure how good it is.
I also noticed that enum nullability in the list has some issues: https://github.com/Kotlin/kotlinx.serialization/issues/1113

@grantas33 I cannot add you as a reviewer, so I tag you in the comments

@grantas33 @saltanovas I think it's not right to mark variables as optional when they are not optional. Fallback to some default "unrecognized" enum value could be an option.

I would probably go with fallback to UNKNOWN_VALUE value for each enum. We could use a generic enum fallback serializer like https://gist.github.com/arberg/e20db05e018c61f37f1d274a254657c3. Unknown values could also be logged there for debugging purposes

I tried to do suggested changes, but now I get compile exception somehow and I cannot figure out what is wrong 😭
Caused by: java.lang.AssertionError: SyntheticAccessorLowering should not attempt to modify other files!
While lowering this file: FILE fqName:eu.kevin.api.serializers.enums fileName:/kevin-jvm/src/main/kotlin/eu/kevin/api/serializers/enums/BankStatusSerializer.kt
Trying to add this accessor: CONSTRUCTOR SYNTHETIC_ACCESSOR visibility:public <> (value:kotlin.String, $constructor_marker:kotlin.jvm.internal.DefaultConstructorMarker?) returnType:eu.kevin.api.models.payment.BankStatus

While trying to do some magic with a custom serializer and fix the issue, I got to an idea if a new enum constant is a breaking change? It might be an indication of a poor code architecture at first, but let's imagine that the Platform team introduce a new StatusGroup. I believe that client code cannot interpret a new value correctly.
Since the library already assume that external kevin. API cannot make any mistakes as most of the properties are not nullable, perhaps we can make another assumption that kevin. enums are highly stable? Additionally, I would have enums only where it makes sense. I don't think that error codes as an enum in a good option here, library already miss many error codes
What is your opinion?

I also don't see it as a breaking change. Also code architecture-wise marking mandatory fields as optional is not a good choice. Fallback would be the most correct solution here.

@grantas33 I see that @edgar-zigis is on vacation. Are we good with the pull request?

Yes we can merge

Could you merge and release it then? I do not have any rights to do it


Update view after ajax-form request

I have a view which insert data to a table of database and show the list of data in div.
I would like to do is to update list after ajax-form request is finished.
There are two actions view-request-action and request-action.
I have tried the following.

add :syncing.sync, :handle-parsing to div same as the ajax-form.
set viewTemplatePath: on exists of request-action.
other possible ways I think it should work.

Could you kindly suggest any possible way how I can update the list after updating the database?
This is my first time using Sailsjs framework and I really appreciate any kind of helps & suggestions.
Thank you!

Sails version: 1.0
Node version: 8.11.1
NPM version: 5.2.0
DB adapter name: sails-mysql
DB adapter version: N/A
Operating system: Windows 10

I have found my problem. But still do not know how to solve.
My second action request-action return json data for showing list in frontend.
First input is successful but not update to UI.
Second input is successful and update UI for the first input.
I am missed to update when the action return json.
But still do not know where to update the UI on Json return from ajax-form.
Any suggestions or advice is welcome.
Thank you!

I have solved my problem.
I am returning json too early.
I need to return json within callback of data insert function by promise.
Thank you!


refactor(project): convert repo to upm package

This was done to make it easier to install and update the package.

Task linked: CU-85ztuuk07 Convert repo to UPM package


Changed Tile, set query begin date off end date if provided.

Updated to always set the XLD task query begin date  minus X number of days.  Also removed the exception for number of days being out of range 1-90 days.  If a number larger than 90 is provided for number of days, the value is truncated to 90 days.

the codacy/pr finding is not really an issue, the synthetic.xml always sets a value for numberOfDays.


⚠ Bofrost.de has degraded performance

In c5d70a8, Bofrost.de (https://www.bofrost.de) experienced degraded performance:

HTTP code: 200
Response time: 1248 ms

Resolved: Bofrost.de performance has improved in f63da45.


Annotations are missing from get rule

CLI does not show annotations on a rule with rule get command:
wsk rule get lib_rule -v
REQUEST:
[GET]<EMAIL_ADDRESS>RESPONSE:Got response with code 200
Response body size is 438 bytes
Response body received:
{"name":"lib_rule","publish":false,"annotations":[{"key":"managed","value":{"__OW_FILE":"tests/usecases/relationships/manifest.yml","__OW_PROJECT_HASH":"3e519a9c5c23da0f5fa7e428d5d29c5c8a3788ee","__OW_PROJECT_NAME":"LIB"}}],"version":"0.0.1","status":"active","action":{"path":"namespace/lib_package","name":"lib_greeting_1"},"namespace":"namespace","trigger":{"path":"namespace","name":"lib_trigger"}}
ok: got rule lib_rule
{
    "namespace": "namespace",
    "name": "lib_rule",
    "version": "0.0.1",
    "status": "active",
    "trigger": {
        "name": "lib_trigger",
        "path": "namespace"
    },
    "action": {
        "name": "lib_greeting_1",
        "path": "namespace/lib_package"
    },
    "publish": false
}

@pritidesai good catch. Whisk deploy needs this also for our export/report commands.


View log messages where there is no exception

I love how log messages are shown when there is an exception in the logs tab.
Is there a way to view all the log messages that have been logged even if a exception has not been thrown? Being grouped by request would be great, but just a list of them would be super useful.

try this code in controller
ElmahExtensions.RiseError(new Exception("your msg"));


netstandard2.0 breaks Generator

I've targeted netstandard2.0 with my generator in private project and it took some time before I realized that this was the change that broke my builds. I've created separate issue although I see #48 - I think that I generalized the issue since the other one is about the example from this repo. It may very well be closed as duplicate if it's not separate enough.
I've created a repro repo https://github.com/amis92/CodeGenerationBugDemo
Repro steps:

Change CodeGenerationBugDemo.Generator target to netstandard2.0 (as opposed to netstandard1.5 or netstandard1.6).
Observe that:
a. CodeGenerationBugDemo.Library.DemoClass doesn't compile since the invoked method was not generated.
b. CodeGenerationBugDemo.GeneratorTests.DemoGeneratorTests.GivenTestClass_CanInvokeGeneratedMethod test fails because the method was not generated.

Expected: netstandard2.0 target for Generator is supported.

I've forked the repo and tried to pinpoint where in the generator framework (this repo) is the error happening and successfully found the original source:
https://github.com/amis92/CodeGeneration.Roslyn/commit/d5c7e176b5e55c4327aaa0303c689a5bf775a765
The exact exception caught on assembly.GetTypes() is logged as follows:
          codegen: Generator 'CodeGeneration.Roslyn.Tests.Generators.DuplicateWithSuffixGenerator' from assembly 'CodeGeneration.Roslyn.Tests.Generators, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=null' failed to load.
            codegen: Exception listing assembly types: System.Reflection.ReflectionTypeLoadException: Unable to load one or more of the requested types. Retrieve the LoaderExceptions property for more information.
     at System.Reflection.RuntimeModule.GetTypes(RuntimeModule module)
     at System.Reflection.Assembly.GetTypes()
     at CodeGeneration.Roslyn.DocumentTransform.GetCodeGeneratorTypeForAttribute(INamedTypeSymbol attributeType, Func`2 assemblyLoader)
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'
            codegen: Exception listing assembly types: System.IO.FileNotFoundException: Could not load file or assembly 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.
  File name: 'netstandard, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'

Tracking further, it may have to do with https://github.com/dotnet/standard/issues/481

This is by design for now. MSBuild Tasks must target either .NET Core or .NET Framework -- they cannot target .NET Standard and expect to run on the .NET Framework version of MSBuild because MSBuild.exe does not guarantee all the .NET Standard contract assemblies are discoverable.
One issue tracking the general problem is here: https://github.com/Microsoft/msbuild/issues/1940
So you should compile your generator for .NET Framework. If you want to run on dotnet build you can also build your generator for netcoreapp by multi-targeting with this xml in your project:
  <TargetFrameworks>net46;netcoreapp1.0</TargetFrameworks>


Convert-WindowsImage not handling arrays for Edition

When passing a string to Convert-WindowsImage, it works:
Convert-WindowsImage -Edition "ServerDataCenter"
When passing an array to Convert-WindowsImage, it errors:
Convert-WindowsImage -Edition @("ServerDataCenter","ServerDataCenterCore")
ERROR : The property 'Count' cannot be found on this object. Verify that the property exists.

Assuming this has been resolved with TP5 revision. Will re-open if necessary.


update scale-down/scale-up store function

Current coverage is 45.34% (diff: 100%)

Merging #110 into master will increase coverage by 1.60%

@@             master       #110   diff @@
==========================================
  Files            16         16
  Lines          8919       8919
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits           3901       4044   +143
+ Misses         4000       3845   -155
- Partials       1018       1030    +12

Powered by Codecov. Last update 6e04533...c6ffdf4

LGTM


PHOENIX-4917 Fix ClassCastException when projecting array elements in hash join

cc @twdsilva @JamesRTaylor @joshelser Ready for review. Thanks.

@geraldss
I tried running your test without the fix and it still passes. The compiler optimizes the query to use SKIP-SCAN-JOIN so the hash cache is not sent to the server. The explain plan is
CLIENT PARALLEL 1-WAY FULL SCAN OVER UNSALTED_N000001
SERVER ARRAY ELEMENT PROJECTION
SKIP-SCAN-JOIN TABLE 0
DYNAMIC SERVER FILTER BY UNSALTED_N000001.ID IN ($1.$3)
I will just commit your original PR without the test since it doesn't add anything.
You can file a separate JIRA to fix ProjectArrayElemAfterHashJoinIT to actually test HashJoin.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
5m 32s
Docker mode activated.

_ Prechecks _

+1 :green_heart:
dupname
0m  0s
No case conflicting files found.

+1 :green_heart:
hbaseanti
0m  0s
Patch does not have any anti-patterns.

+1 :green_heart:
@author
0m  0s
The patch does not contain any @author tags.

-1 :x:
test4tests
0m  0s
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.

_ master Compile Tests _

+1 :green_heart:
mvninstall
21m  1s
master passed

+0
hbaserecompile
32m 23s
HBase recompiled.

+1 :green_heart:
compile
1m  4s
master passed

+1 :green_heart:
checkstyle
0m 56s
master passed

+1 :green_heart:
javadoc
0m 53s
master passed

+0 :ok:
spotbugs
3m  5s
phoenix-core in master has 972 extant spotbugs warnings.

-0 :warning:
patch
3m 14s
Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.

_ Patch Compile Tests _

-1 :x:
mvninstall
0m 30s
root in the patch failed.

+0
hbaserecompile
15m 25s
HBase recompiled.

-1 :x:
compile
0m 20s
phoenix-core in the patch failed.

-1 :x:
javac
0m 20s
phoenix-core in the patch failed.

+1 :green_heart:
checkstyle
0m 55s
the patch passed

-1 :x:
whitespace
0m  0s
The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply

-1 :x:
whitespace
0m  0s
The patch 30 line(s) with tabs.

+1 :green_heart:
javadoc
0m 50s
the patch passed

-1 :x:
spotbugs
0m 18s
phoenix-core in the patch failed.

_ Other Tests _

-1 :x:
unit
0m 19s
phoenix-core in the patch failed.

+1 :green_heart:
asflicense
0m 15s
The patch does not generate ASF License warnings.

60m 17s

Subsystem
Report/Notes

Docker
ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/phoenix/pull/358

Optional Tests
dupname asflicense javac javadoc unit spotbugs hbaserebuild hbaseanti checkstyle compile

uname
Linux 7704385c681c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev/phoenix-personality.sh

git revision
master / bfc4621

Default Java
Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08

mvninstall
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt

compile
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

javac
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-compile-phoenix-core.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/whitespace-eol.txt

whitespace
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/whitespace-tabs.txt

spotbugs
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-spotbugs-phoenix-core.txt

unit
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt

Test Results
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/testReport/

Max. process+thread count
94 (vs. ulimit of 30000)

modules
C: phoenix-core U: phoenix-core

Console output
https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-358/1/console

versions
git=2.7.4 maven=3.3.9 spotbugs=4.1.3

Powered by
Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.


Add basic monitoring

What this PR does / why we need it:
/kind enhancement
A basic monitoring stack is installed in the prow cluster consisting of:

prometheus-operator
alertmanager (cluster with 3 replicas for HA)
prometheus (2 replicas for HA)
blackbox-exporter
kube-state-metrics
grafana

Alertmanager will send Slack alerts in #gardener-prow-alerts (SAP-internal workspace).
Grafana is available publicly at https://monitoring.prow.gardener.cloud.
This is based on what kube has as well in https://github.com/kubernetes/test-infra/tree/master/config/prow/cluster/monitoring (grafana dashboards and alerts are generated and copied from there) and slightly adapted to our instance (dropped a few unneeded things, etc.)

/area monitoring


adding premium packs explanation docs

Status
Ready
Description
Adding a detailed description about the contribution process of premium packs

@guykeller @ronykoz I don't like the direction we took here.
I think we need the docs for how to setup the environment in the repo itself. It should be self explanatory.
We can refer to the repo docs from here.
But for the rest, we should explain in bullets what must happen in order for paid pack to be released into marketplace.

Hey @ronykoz the name of the file has a typo (preimum_packs instead of premium_packs), can you please rename it?

@fvigo Done

@kirbles19 preview available at: https://deploy-preview-236--demisto-content-docs.netlify.app/docs/integrations/premium_packs . Please see if you can add an intro paragraph.

@ronykoz Done.

@guykeller can we merge?


Add hash test vectors

Added test vectors from here: https://csrc.nist.gov/projects/cryptographic-algorithm-validation-program/secure-hashing#shavs
Tested empty message, same size message and longer message

@amanusk please resolve conflicts and remove the annoying old tests for bitlength of hash outputs


Test compatibility with page builders

[ ] Elementor
[ ] Beaver Builder
[ ] Divi Builder
[ ] Thrive Architect
[ ] SiteOrigin Page Builder
[ ] WPBakery Page Builder
[ ] Themify Builder
[ ] Brizy
[ ] Visual Composer
[ ] Tailor
[ ] Fusion Builder

Currently the plugin is not compatible with WPBakery.
The main issue that comes up is that WPBakery uses the ID of the media to generate the html. This plugin uses the ID from the main site_id which then prevents WPBakery from finding the correct image in the current subsite.
@johnbillion will there be any update in the near future to accommodate for this ?


Location parameter inside request path couldn't be properly generated

e.g.
"/subscriptions/{subscriptionId}/providers/Microsoft.KeyVault/locations/{location}/deletedVaults/{vaultName}"
Should be resolved after https://github.com/Azure/autorest.csharp/pull/1565

Fixed in latest Keyvault release


GH-4978 Index geosparql points using geo field

GitHub issue resolved: #4978
Briefly describe the changes proposed in this PR:
I added the indexing of the points using the geo prefix and not only the point prefix.

PR Author Checklist (see the contributor guidelines for more details):

[x] my pull request is self-contained
[x] I've added tests for the changes I made
[x] I've applied code formatting (you can use mvn process-resources to format from the command line)
[x] I've squashed my commits where necessary
[x] every commit message starts with the issue number (GH-xxxx) followed by a meaningful description of the change

I want to mention that this PR is only fixing the Q1 case in #4978.

I've create a duplicate issue so that we don't forget about Q2: https://github.com/eclipse-rdf4j/rdf4j/issues/4996


Incompatible with rootless docker

The current docker image of dive does not seem to work with rootless docker (https://docs.docker.com/engine/security/rootless/)

have a working rootless docker daemon running
docker pull mcr.microsoft.com/dotnet/aspnet
=>

latest: Pulling from dotnet/aspnet
Digest: sha256:ebcebd8458aa8ed89cade72ba2d3f5978a7568056a54904c31df859b20a8d371
Status: Downloaded newer image for mcr.microsoft.com/dotnet/aspnet:latest
mcr.microsoft.com/dotnet/aspnet:latest```

* `docker run docker.io/wagoodman/dive:latest mcr.microsoft.com/dotnet/aspnet`
=>
```Image Source: docker://mcr.microsoft.com/dotnet/aspnet
Fetching image... (this can take a while for large images)
Handler not available locally. Trying to pull 'mcr.microsoft.com/dotnet/aspnet'...
Using default tag: latest
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
cannot fetch image
exit status 1

docker version
=>

 Version:           20.10.8
 API version:       1.41
 Go version:        go1.16.6
 Git commit:        3967b7d
 Built:             Fri Jul 30 19:54:44 2021
 OS/Arch:           linux/amd64
 Context:           default
 Experimental:      true

Server: Docker Engine - Community
 Engine:
  Version:          20.10.8
  API version:      1.41 (minimum version 1.12)
  Go version:       go1.16.6
  Git commit:       75249d8
  Built:            Fri Jul 30 19:52:30 2021
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          1.4.9
  GitCommit:        e25210fe30a0a703442421b0f60afac609f950a3
 runc:
  Version:          1.0.1
  GitCommit:        v1.0.1-0-g4144b63
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker run bash bash --version
=>

Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Rootless docker also means that the DOCKER_HOST environment variable needs to be set, i.e. from my env
DOCKER_HOST=unix:///run/user/1000/docker.sock
as the result of (.bashrc):
DOCKER_HOST=unix://$XDG_RUNTIME_DIR/docker.sock
export DOCKER_HOST


bitbox02: update to v5.2.0

Updated pyproject.toml and setup.py, then: poetry update bitbox02 --lock.

Support for antiklepto
Small function signature change in restore_from_mnemonic
Add version upper bound following semver

There seem to be a lot of unnecessary changes to poetry.lock. You can you do poetry lock?

Seems I had a slightly outdated poetry which formats the file differently. I upgraded it and re-ran poetry update bitbox02 --lock, resulting in a much smaller diff.

ACK 7844bfada6f0e464764db650f3661ce93c6c192e


Fix missing anchors and 404 errors.

/CC @mdo

Why the new #content?

Ohhh, my bad. I see.

It's for the skip content link.
On Sep 2, 2015 10:35, "Mark Otto"<EMAIL_ADDRESS>wrote:

Merged #17435 https://github.com/twbs/bootstrap/pull/17435.
—
Reply to this email directly or view it on GitHub
https://github.com/twbs/bootstrap/pull/17435#event-398614939.


composer

After add library to required
I see error
Could not find package xero/xerooauth-php at any version for your minimum-stability (stable). Check the package spelling or your minimum-stability

That's because Xero ignored all advice to release it properly: https://github.com/XeroAPI/XeroOAuth-PHP/issues/39
For the mean time you will have to specify dev-master as the version and cross your fingers something doesn't change in the future.


Proposed modification to EIP spec

Pull Request Test Coverage Report for Build 10

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 100.0%

Totals

Change from base Build 9:
0.0%

Covered Lines:
30

Relevant Lines:
30

💛  - Coveralls


chore: [CHAOS-2722]: Add the pod api block kubernetes fault to block the api request

Harness Developer Pull Request
Thanks for helping us make the Developer Hub better. The PR will be looked at
by the maintainers.
What Type of PR is This?

[ ] Issue
[ ] Feature
[ ] Maintenance/Chore

If tied to an Issue, list the Issue(s) here:

Issue(s)

House Keeping
Some items to keep track of. Screen shots of changes are optional but would help the maintainers review quicker.

[ ] Tested Locally
[ ] Optional Screen Shoot.

Please check the Execution Link of the Pipeline for the Website Draft URL. This is located in the Preview Step and also is available in #hdh_alerts. E.g Website Draft URL: https://unique-id--harness-developer.netlify.app


Move the max_duration from state into state.timer

It would help simplify the API -- especially in the schedulers -- if the timer was aware of the max_duration. Specifically, calls like this currently fail:
if state.timer < Time(0.5, "dur"): do_something().
Instead, these calls have to look like the following

time = Time(...)

if time.unit == TimeUnit.DURATION:
  if state.get_elapsed_duration() < time: do_something()
else:
  if state.timer < time: do_something()

If the Timer was aware of max_duration, then it could respond to the above queries.
The get_elapsed_duration helper method should also be moved from the state into the timer.

Sounds good, would you be amenable to still keeping a max_duration property on state that links to state.timer.max_duration ?

Sounds good, would you be amenable to still keeping a max_duration property on state that links to state.timer.max_duration ?

Sure, though that would be the only timer property directly on the state.

I think that's OK, its a unique property in Timer compared to the others that track time.

Closing this issue as #879 removed the Timer class. Instead, the current timestamp is bound directly to the state.


WIP feat: Permalinks in Dataverse

Status: draft
Open issues:

[ ] how does this work for already created datasets with fake DOIs?
I did not find an API to generate a new PID using a new provider for already existing datasets.
I checked here and here
Maybe we need to edit the existing datasets in the database?

[ ] how can we run the SQL script as part of the init job? I attempted to include the SQL script in the bootstrap job, but the configbaker image doesn't have psql installed and cannot connect to the DB to run it.
When executing the SQL script manually, correct Permalinks are generated:

We can open a ticket in dataverse and ask them to add psql into the config baker image. Most likely it will be added quite fast.

Note that any datasets or files created using a test configuration cannot be directly migrated to a production PID provider and would need to be created again once a valid PID Provider(s) are configured.
I found this information here: https://guides.dataverse.org/en/latest/installation/config.html#persistent-identifiers-and-publishing-datasets

We can open a ticket in dataverse and ask them to add psql into the config baker image. Most likely it will be added quite fast. Concerning the migration we need to ask Phil!

Done https://github.com/IQSS/dataverse/issues/10487

Note that any datasets or files created using a test configuration cannot be directly migrated to a production PID provider and would need to be created again once a valid PID Provider(s) are configured.

I found this information here: https://guides.dataverse.org/en/latest/installation/config.html#persistent-identifiers-and-publishing-datasets

Hm :/ I am wondering whether moving the dataset to a new collection maybe counts as "created again". Otherwise, I am also unsure if & how our idea with moving datasets to a DOI collection to create a DOI for them works. I can do a quick test of this.

I am wondering whether moving the dataset to a new collection maybe counts as "created again"
Short answer: nope. The association of a dataset to a collection is just metadata.

Besides the one-time migration from FAKE DOIs to Permalinks. The process flow I envision is the following:

A dataset is created within a dataverse (with configured PermaLink provider) and is not published.
2.A.1) The dataverse is moved into another dataverse with a configured DOI Provider, and still not published.
2.A.2) The datset is published, and as configured for the dataverse, a correct DOI will be minted.
2.B.1) The datset is published, and as configured for the dataverse, a correct PermaLink will be created.

Besides the one-time migration from FAKE DOIs to Permalinks. The process flow I envision is the following:
1`) A dataset is created within a dataverse (with configured PermaLink provider) and is not published. 2.A.1) The dataverse is moved into another dataverse with a configured DOI Provider, and still not published. 2.A.2) The datset is published, and as configured for the dataverse, a correct DOI will be minted. 2.B.1) The datset is published, and as configured for the dataverse, a correct PermaLink will be created.

The difficulty I see with this is that Permalinks and DOIs are created/reserved by Dataverse when a dataset is created, not when it is published. As far as I understand, it is not currently intended by Dataverse to change the PID afterwards. But we could work on a PR for this.

Besides the one-time migration from FAKE DOIs to Permalinks. The process flow I envision is the following:
1`) A dataset is created within a dataverse (with configured PermaLink provider) and is not published. 2.A.1) The dataverse is moved into another dataverse with a configured DOI Provider, and still not published. 2.A.2) The datset is published, and as configured for the dataverse, a correct DOI will be minted. 2.B.1) The datset is published, and as configured for the dataverse, a correct PermaLink will be created.

The difficulty I see with this is that Permalinks and DOIs are created/reserved by Dataverse when a dataset is created, not when it is published. As far as I understand, it is not currently intended by Dataverse to change the PID after the inital creation. But we could work on a PR for this.

This means we need to adapt the move dataset functionality to also alter the reserved but no yet registers PID so it's consistent with the configured PID provider?

This means we need to adapt the move dataset functionality to also alter the reserved but no yet registers PID so it's consistent with the configured PID provider?

Yes I think so.
We could also implement, at least for the direction "Permalink/FAKE -> X" as a special case, that the PID of an already published dataset is replaced when moving. (see the Zulip discussion linked by Oliver)
If we implement the "FAKE -> X" case, it could also help us do the transition away from FAKE PIDs.

First, as we only migrate once from FAKE to permalink, I'd rather do some easy SQL magic to improve our situation. I'm concerned about the needed resources.
Second, when I can create a dataset in one dataverse, move it to another and publish it there. Assuming that both dataverse have different PID providers configured, the dataset will be minted with the wrong PID provider, right? That's unexpected behavior and should be resolved. The fix should be a rather small addition to the https://github.com/IQSS/dataverse/blob/develop/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/MoveDatasetCommand.java and will likely requires less resources than developing PID transition feature.

Second, when I can create a dataset in one dataverse, move it to another and publish it there. Assuming that both dataverse have different PID providers configured, the dataset will be minted with the wrong PID provider, right? That's unexpected behavior and should be resolved. The fix should be a rather small addition to the https://github.com/IQSS/dataverse/blob/develop/src/main/java/edu/harvard/iq/dataverse/engine/command/impl/MoveDatasetCommand.java and will likely requires less resources than developing PID transition feature.

I think we need a PID transition feature if we want to implement the use case of minting DOIs for already published datasets. If we only want to mint DOIs for unpublished datasets, yes it would be easier to implement (but incomplete).

@johannes-darms I think this is ready to merge.
I found some more anomalies/studies that seem to be in the wrong collection: In the ICTRP collection, there are

18 entries with NCT ID. I assume these are all cases of studies where Germany was previously entered as a study location, but later removed (https://github.com/nfdi4health/csh-ui/issues/889). Example: NCT04777734 https://clinicaltrials.gov/search?cond=NCT04777734
11 entries with DRKS ID, apparently these were not included in the DRKS import for some reason, only included in the ICTRP import. Example: DRKS00029657 https://drks.de/search/de/trial/DRKS00029657

We might think about how to handle these

@johannes-darms I think this is ready to merge.

Great!

I found some more anomalies/studies that seem to be in the wrong collection: In the ICTRP collection, there are
* 18 entries with NCT ID. I assume these are all cases of studies where Germany was previously entered as a study location, but later removed ([Special cases of imported studies: how to handle them? csh-ui#889](https://github.com/nfdi4health/csh-ui/issues/889)). Example: NCT04777734 https://clinicaltrials.gov/search?cond=NCT04777734

For now, keep them.

* 11 entries with DRKS ID, apparently these were not included in the DRKS import for some reason, only included in the ICTRP import. Example: DRKS00029657 https://drks.de/search/de/trial/DRKS00029657

That could be the case. Let's wait and see what changes once we update the WHO ICTRP data.

We might think about how to handle these

We can discuss this in October during our meeting.


AsciiFormatter use async all the way down (#520)

The issue or feature being addressed

#520

Details on the issue fix or feature implementation
.NET Core 3.0 block sync operations by default. I've changed the implementation of App.Metrics.Formatters.Prometheus.Internal.AsciiFormatter to use async all the way down.
Confirm the following

[ ] I have ensured that I have merged the latest changes from the dev branch
 I've branched from features/4.0.0 where the fix was already started
[X] I have successfully run a local build
[ ] I have included unit tests for the issue/feature
[X] I have included the github issue number in my commits

I'm preparing an PR for my comments


Fix being able to expunge a VM through destroyVirtualMachine even when role rule does not allow

Description
This PR adds a role access check to the expungeVirtualMachine command when calling destroyVirtualMachine with the expunge parameter.
Currently, if you are an admin (even if not Root), it bypasses the allow.user.expunge.recover.vm verification and you are always allowed to expunge when calling for destroyVirtualMachine.
The use case that called for this change was a need for a role of type domain admin to be unable to expunge VMs. It was then found that even with the DENY rule, the user could still expunge through destroyVirtualMachine (even on already destroyed VMs, with an API call) and the setting allow.user.expunge.recover.vm did nothing.
Types of changes

[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] New feature (non-breaking change which adds functionality)
[X] Bug fix (non-breaking change which fixes an issue)
[ ] Enhancement (improves an existing feature and functionality)
[ ] Cleanup (Code refactoring and cleanup, that may add test cases)
[ ] build/CI

Feature/Enhancement Scale or Bug Severity
Bug Severity

[ ] BLOCKER
[ ] Critical
[X] Major
[ ] Minor
[ ] Trivial

Screenshots (if appropriate):
How Has This Been Tested?
I created a role, based on the default Domain Admin, and changed the expungeVirtualMachine rule to DENY. I then created an account with said role.
I created two VMs and destroyed one of them, verifying that the expunge option did not show up on the GUI.
I then ran destroy virtualmachine on cloudmonkey with expunge = true on both VMs and both returned the error Account does not have permission for expunging.  Calling the same command without the parameter destroyed the running VM successfully.
I repeated the tests with a role based on default User:
With allow.user.expunge.recover.vm = true, it behaved the same as the DomainAdmin-based one.
With allow.user.expunge.recover.vm = false, it did not allow the expunge action, no matter the role rules. Without the expunge parameter, the destroy action worked as expected.

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✖ el8 ✖ el9 ✔ debian ✖ suse15. SL-JID 8745

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8755

@gpordeus , this sounds like a good use case for an integration test. Will you considder that?

@blueorangutan package

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el7 ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 8764

Packaging result [SF]: ✖ el7 ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 8780

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 8787

I manually tested, lgtm.

@blueorangutan package

@blueorangutan test alma9 kvm-alma9

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[SF] Trillian Build Failed (tid-9434)

@DaanHoogland I've added the integration test.

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 9091

@blueorangutan test alma9 kvm-alma9

@DaanHoogland a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests

[SF] Trillian test result (tid-9650)
Environment: kvm-alma9 (x2), Advanced Networking with Mgmt server a9
Total time taken: 54702 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8689-t9650-kvm-alma9.zip
Smoke tests completed. 129 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

@weizhouapache are all your concerns met?

Codecov Report
Attention: Patch coverage is 50.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 23.13%. Comparing base (592038a) to head (007f1e1).
Report is 221 commits behind head on main.

Files
Patch %
Lines

.../src/main/java/com/cloud/vm/UserVmManagerImpl.java
38.46%
4 Missing and 4 partials :warning:

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8689      +/-   ##
============================================
- Coverage     23.14%   23.13%   -0.02%
- Complexity    23348    23485     +137
============================================
  Files          5219     5234      +15
  Lines        353412   355729    +2317
  Branches      50883    51238     +355
============================================
+ Hits          81805    82294     +489
- Misses       259762   261540    +1778
- Partials      11845    11895      +50

Flag
Coverage Δ

simulator-marvin-tests
24.80% <50.00%> (-0.02%)
:arrow_down:

uitests
4.34% <ø> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

@blueorangutan package

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el7 ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 9816

Packaging result [SF]: ✖ el7 ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 9817

not sure why the bot removed the conflict sticker, but you still have some @gpordeus

@weizhouapache, are your concerns met?
@DaanHoogland, could you trigger the CI one last time?

 It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✔ el7 ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10459

@blueorangutan package

@JoaoJandre a [SL] Jenkins job has been kicked to build packages. It will be bundled with  KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Packaging result [SF]: ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 10642

Packaging result [SF]: ✖ el8 ✖ el9 ✖ debian ✖ suse15. SL-JID 10661

Packaging result [SF]: ✔ el8 ✔ el9 ✔ debian ✔ suse15. SL-JID 10680

@blueorangutan LLtest

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[LL] Trillian Build Failed (tid-6968)

@blueorangutan test

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[SF] Trillian test result (tid-11094)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 52183 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8689-t11094-kvm-ol8.zip
Smoke tests completed. 137 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test
Result
Time (s)
Test File

test_DeployVmAffinityGroup
Error
1.45
test_affinity_groups.py

test_01_non_strict_host_anti_affinity
Error
2.63
test_nonstrict_affinity_group.py

test_02_non_strict_host_affinity
Error
1.58
test_nonstrict_affinity_group.py

@weizhouapache are you alright with this one, now?

@DaanHoogland
code lgtm
not tested

@DaanHoogland code lgtm
not tested

good, @lucas-a-martins has: https://github.com/apache/cloudstack/pull/8689#pullrequestreview-2015694745


CMAKE_VS_DEVENV_COMMAND is empty

1> Command line: C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2017\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe  -G "Visual Studio 15 2017" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\zhujie\AppData\Local\CMakeBuild\877c8177-4761-4033-89b6-882311601906\build\install"  --DCMAKE_BUILD_TYPE="Debug" "D:\projects\metapp"
1> Working directory: C:\Users\zhujie\AppData\Local\CMakeBuild\877c8177-4761-4033-89b6-882311601906\build\x86-Debug
1> -- [hunter] Calculating Config-SHA1
1> -- [hunter] Calculating Toolchain-SHA1
1> -- [hunter] HUNTER_ROOT: D:/program/hunter_root
1> -- [hunter] [ Hunter-ID: 50eaca2 | Config-ID: a9b8ca2 | Toolchain-ID: 5ae8cae ]
1>
1> [hunter ** INTERNAL **] CMAKE_VS_DEVENV_COMMAND is empty
1> [hunter ** INTERNAL **] [Directory:D:/projects/metapp]
1>
1> ------------------------------ WIKI -------------------------------
1>     https://github.com/ruslo/hunter/wiki/error.internal
1> -------------------------------------------------------------------
1>
1> CMake Error at D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_wiki.cmake:12 (message):
1> Call Stack (most recent call first):
1>   D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_internal_error.cmake:13 (hunter_wiki)
1>   D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_setup_msvc.cmake:117 (hunter_internal_error)
1>   D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_finalize.cmake:104 (hunter_setup_msvc)
1>   D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_add_package.cmake:23 (hunter_finalize)
1>   CMakeLists.txt:11 (hunter_add_package)
1>
1>
1> -- Configuring incomplete, errors occurred!
1> See also "C:/Users/zhujie/AppData/Local/CMakeBuild/877c8177-4761-4033-89b6-882311601906/build/x86-Debug/CMakeFiles/CMakeOutput.log".
1> C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2017\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe  -G "Visual Studio 15 2017" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\zhujie\AppData\Local\CMakeBuild\877c8177-4761-4033-89b6-882311601906\build\install"  --DCMAKE_BUILD_TYPE="Debug" "D:\projects\metapp" returned with exit code: 1

D:\projects\metapp>cmake -H. -B_builds -DHUNTER_STATUS_DEBUG=ON -DCMAKE_BUILD_TYPE=Release
-- [hunter *** DEBUG *** 2017-04-05T22:30:54] HUNTER_ROOT detected by environment variable
-- [hunter *** DEBUG *** 2017-04-05T22:30:54] HUNTER_ROOT: D:/program/hunter_root
-- [hunter *** DEBUG *** 2017-04-05T22:30:54] Settings (initialize):
-- [hunter *** DEBUG *** 2017-04-05T22:30:54]   HunterGate done (NO)
-- [hunter *** DEBUG *** 2017-04-05T22:30:54]   Cache init (YES)
-- The C compiler identification is MSVC 19.10.25017.0
-- The CXX compiler identification is MSVC 19.10.25017.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- [hunter *** DEBUG *** 2017-04-05T22:31:07] Single-configuration generator
-- [hunter *** DEBUG *** 2017-04-05T22:31:07] List of cache servers:
-- [hunter *** DEBUG *** 2017-04-05T22:31:07]   * https://github.com/ingenue/hunter-cache
-- [hunter *** DEBUG *** 2017-04-05T22:31:07] Settings (finalize):
-- [hunter *** DEBUG *** 2017-04-05T22:31:07]   HunterGate done (NO)
-- [hunter *** DEBUG *** 2017-04-05T22:31:07]   Cache init (NO)
-- [hunter *** DEBUG *** 2017-04-05T22:31:07] Variables from HunterGate:
-- [hunter *** DEBUG *** 2017-04-05T22:31:07]   HUNTER_GATE_ROOT: D:/program/hunter_root
-- [hunter *** DEBUG *** 2017-04-05T22:31:07]   HUNTER_GATE_VERSION: 0.18.36
-- [hunter *** DEBUG *** 2017-04-05T22:31:07]   HUNTER_GATE_SHA1: 50eaca2a8083ac266bdec6655c64f352c380b784
-- [hunter] Calculating Config-SHA1
-- [hunter *** DEBUG *** 2017-04-05T22:31:08] Set CMAKE_DEBUG_POSTFIX to: d
-- [hunter] Calculating Toolchain-SHA1
-- [hunter *** DEBUG *** 2017-04-05T22:31:08] [D:/projects/metapp/_builds/_3rdParty/Hunter/toolchain] > "D:/program/cmake-3.7.2/bin/cmake.exe" "-DTOOLCHAIN_INFO_FILE=D:/projects/metapp/_builds/_3rdParty/Hunter/toolchain/toolchain.info" "-DHUNTER_SELF=D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked" "-GNMake Makefiles" "-HD:/projects/metapp/_builds/_3rdParty/Hunter/toolchain" "-BD:/projects/metapp/_builds/_3rdParty/Hunter/toolchain/_builds" "-DCMAKE_MAKE_PROGRAM=nmake" "-DCMAKE_RELEASE_POSTFIX=" "-DCMAKE_DEBUG_POSTFIX=d"
-- The C compiler identification is MSVC 19.10.25017.0
-- The CXX compiler identification is MSVC 19.10.25017.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/HostX64/x64/cl.exe -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: D:/projects/metapp/_builds/_3rdParty/Hunter/toolchain/_builds
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Locking directory: D:/program/hunter_root/_Base/50eaca2/a9b8ca2/8e315c1
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Lock done
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Locking directory: D:/program/hunter_root/_Base/50eaca2/a9b8ca2/8e315c1
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Lock done
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Toolchain info: D:/program/hunter_root/_Base/50eaca2/a9b8ca2/8e315c1/toolchain.info
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Toolchain SHA1: 8e315c18780bb31b76e5f482e5932d2e111f3da7
-- [hunter] HUNTER_ROOT: D:/program/hunter_root
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] HUNTER_TOOLCHAIN_ID_PATH: D:/program/hunter_root/_Base/50eaca2/a9b8ca2/8e315c1
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] HUNTER_CONFIGURATION_TYPES: Release;Debug
-- [hunter] [ Hunter-ID: 50eaca2 | Config-ID: a9b8ca2 | Toolchain-ID: 8e315c1 ]
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Locking directory: D:/program/hunter_root/_Base/50eaca2/a9b8ca2/8e315c1
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] Lock done
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_C_SIZEOF_DATA_PTR = 8
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_C_COMPILER_ABI =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_C_IMPLICIT_LINK_LIBRARIES =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_C_IMPLICIT_LINK_DIRECTORIES =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_C_IMPLICIT_LINK_FRAMEWORK_DIRECTORIES =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_C_LIBRARY_ARCHITECTURE =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_C_ABI_COMPILED = TRUE
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_CXX_SIZEOF_DATA_PTR = 8
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_CXX_COMPILER_ABI =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_CXX_IMPLICIT_LINK_LIBRARIES =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_CXX_IMPLICIT_LINK_DIRECTORIES =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_CXX_IMPLICIT_LINK_FRAMEWORK_DIRECTORIES =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_CXX_LIBRARY_ARCHITECTURE =
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] ABI forwarding: CMAKE_CXX_ABI_COMPILED = TRUE
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] HUNTER_MSVC_VERSION: 15
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] HUNTER_MSVC_YEAR: 2017
-- [hunter *** DEBUG *** 2017-04-05T22:31:14] HUNTER_MSVC_ARCH: amd64
[hunter ** INTERNAL **] vcvarsall.bat not found in C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC
[hunter ** INTERNAL **] [Directory:D:/projects/metapp]
------------------------------ WIKI -------------------------------
https://github.com/ruslo/hunter/wiki/error.internal
CMake Error at D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_wiki.cmake:12 (message):
Call Stack (most recent call first):
D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_internal_error.cmake:13 (hunter_wiki)
D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_setup_msvc.cmake:143 (hunter_internal_error)
D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_finalize.cmake:104 (hunter_setup_msvc)
D:/program/hunter_root/_Base/Download/Hunter/0.18.36/50eaca2/Unpacked/cmake/modules/hunter_add_package.cmake:23 (hunter_finalize)
CMakeLists.txt:11 (hunter_add_package)
-- Configuring incomplete, errors occurred!
See also "D:/projects/metapp/_builds/CMakeFiles/CMakeOutput.log".
See also "D:/projects/metapp/_builds/CMakeFiles/CMakeError.log".

1> [hunter ** INTERNAL **] CMAKE_VS_DEVENV_COMMAND is empty

It means the version of CMake is old and have no such variable defined.

[hunter ** INTERNAL **] vcvarsall.bat not found in C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC

I've added extra debugging info (it's not fixed yet), please try this toolchain:

https://github.com/ruslo/hunter/releases/tag/v0.18.38

this the version of CMake which comes with VS2017. Seems like it doesn't set CMAKE_VS_DEVENV_COMMAND, but does set CMAKE_VS_MSBUILD_COMMAND.
See https://github.com/Microsoft/CMake/blob/cmake-daemon/Source/cmGlobalVisualStudio15Generator.cxx#L216
Maybe you can check for this variable as well?

Seems like it doesn't set CMAKE_VS_DEVENV_COMMAND, but does set CMAKE_VS_MSBUILD_COMMAND

Sounds like an issue for me, it should be fixed in this version of CMake, not in Hunter. This variable is available in CMake 3.0:

https://cmake.org/cmake/help/v3.0/variable/CMAKE_VS_DEVENV_COMMAND.html

VS2017 is incompatible right now with Hunter, it may be an issue with the CMake in VS2017, but it still means that we cannot use just out of the box Hunter on VS2017 because of some trivial variable name.

VS2017 is incompatible right now with Hunter

It's not true Hunter works fine in general with Visual Studio 15 2017 generator.

it may be an issue with the CMake in VS2017
use just out of the box Hunter on VS2017 because of some trivial variable name

Exactly, this is an issue in non-standard version of CMake. It should be fixed in there, not in Hunter.

It's not true Hunter works fine in general with Visual Studio 15 2017 generator.
Then we live in alternate realities, because every time I try Hunter on VS2017 with automatic generation it just fails with this error.

https://ci.appveyor.com/project/ingenue/hunter/build/1.0.1996:
`cmake`
`-HC:\projects\hunter\examples\GTest`
`-BC:\projects\hunter\_testing\_builds\vs-15-2017`
`-GVisual Studio 15 2017`
...
-- [hunter *** DEBUG *** 2017-07-22T06:36:28] HUNTER_MSVC_VERSION: 15
-- [hunter *** DEBUG *** 2017-07-22T06:36:28] HUNTER_MSVC_YEAR: 2017
-- [hunter *** DEBUG *** 2017-07-22T06:36:28] HUNTER_MSVC_ARCH: x86
-- [hunter *** DEBUG *** 2017-07-22T06:36:28] Environment 'VS150COMNTOOLS': ''
-- [hunter *** DEBUG *** 2017-07-22T06:36:28] CMAKE_VS_DEVENV_COMMAND: 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community/Common7/IDE/devenv.com'
...
-- The C compiler identification is MSVC 19.10.25019.0
-- The CXX compiler identification is MSVC 19.10.25019.0
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/Hostx86/x86/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/Hostx86/x86/cl.exe -- works
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/Hostx86/x86/cl.exe
-- Check for working CXX compiler: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.10.25017/bin/Hostx86/x86/cl.exe -- works
...

PS @ShikiGami Sorry, I don't have a portal gun to your reality, you have to find it yourself.

Hey i have got exactly the same problem as reported here with brand new windows 10 install and visual studio 2017 installed
Microsoft Visual Studio Community 2017
Version 15.2 (26430.16) Release
Visual Studio tools for CMake   1.0

You can try replace the cmake from visual studio with the latest cmake 3.9
I have replaced it and this error went away. seems that microsoft are compiling different version of cmake, which is 3.7.20170106-gd3236-dirty-MSVC_2
I guess somebody should report this to the visual studio devteam somehow, otherwise hunter will not compile. i think they are compiling with different arguments there or do not distribute a script or something

Yep, they are using their own version of CMake which doesn't implement these variables.
I don't know what environment @ruslo has, but it obviously isn't the pure last release of VS2017.

seems that microsoft are compiling different version of cmake

I've said it twice already in this thread.

Release https://github.com/ruslo/hunter/releases/tag/v0.19.38 contains link to wiki page with explanation and workarounds: https://github.com/ruslo/hunter/wiki/error.vs.devenv
Closing.

Setting VS150COMNTOOLS to "D:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\Tools" in my case, as written in https://github.com/ruslo/hunter/wiki/error.vs.devenv, really works.

Could hunter check the MSBuild key as well?

Not sure about details, but feel free to send pull request, if it will look good and tests for other toolchains will pass then we can do merge.
Also please avoid adding new comments to closed issues:

https://docs.hunter.sh/en/latest/contacts.html#please-don-t