Adapters are missing files generated by Vite plugins

Describe the bug
Adapters are missing files generated by Vite plugins
Reproduction
Run:
git clone git@github.com:benmccann/531.git
pnpm install
pnpm build

It says:
files generated
  .svelte-kit/output/client/service-worker.js
  .svelte-kit/output/client/workbox-30e9d199.js

But those files aren't contained in .svelte-kit/cloudflare/_routes.json
Logs
No response
System Info
npmPackages:
    @sveltejs/adapter-cloudflare: ^2.0.0 => 2.0.0
    @sveltejs/kit: ^1.3.7 => 1.3.7
    svelte: ^3.55.1 => 3.55.1
    vite: ^4.0.4 => 4.0.4

Severity
blocking an upgrade
Additional Information
No response

adapter-cloudflare is using the list of files returned from builder.writeClient. Somehow those files are ending up in .svelte-kit/output/client after the adapter is called

I'm thinking this is not a bug in SvelteKit


Ubuntu notifications

Hi, after the newest update every time I receive a message, while whatsie is minimized and I'm doing something else on my pc, the app just closes itself

Which version of ubuntu are you using?
You clicked the notification popup before th app crashed?
Was it native notification or custom notification?
Please try to run the app from terminal and provide logs.
Thanks

Hi, thanks for reaching out so fast.
So, my ubuntu version is Ubuntu 24.04.1 LTS
I don't even get a notification popup, it just closes the second i receive a message (if whatsie is not minimized and I'm in the app itself I can still send and receive normally).
This is ss from terminal:

After I got a message and the app closed, this is what I got in terminal:

(let me know if it's easier for you to copy paste you the log itself)
This bug started happening after the newest update, the app was working normally before.

Confirming same issue, same build.  Linux Mint 22

I had the same issue (Ubuntu 24.04), when using the custom notifications (which iirc were set as default). Switching to the native Gnome notifications solved the issue, in case people want a stopgap solution!

This actually work for me, thank you for the idea. Still it's just a band-aid solution and I hope the fix is coming. But, great catch, thanks again.

Yeah, I also thought it would be useful to know for debugging!

I had the same issue (Ubuntu 24.04), when using the custom notifications (which iirc were set as default). Switching to the native Gnome notifications solved the issue, in case people want a stopgap solution!

Sorry, where you do that exactly?
I'm having the same issue as the others here.

You right click on the Whatsie logo in the menu bar on the top-right (at least for OOB Gnome under Ubuntu) and select Settings, which allows you to setup Whatsie itself.

The issue was caused due to Custom notification popup widget life-cycle. It is fixed in dde6e02

Thanks!


API access to open file's original encoding

This is a request for API access to the original encoding of a file.  i.e.:

(If this is already possible, please let me know. I couldn't find it.)
If I understand correctly, VS Code represents the content of open files to extensions as UTF-8.  In the C/C++ Extension, there are scenarios in which IntelliSense should reflect how the compiler would interpret the file, which may depend on the files actual encoding. i.e. MSVC and string literal contents.

In addition to the original encoding, it would also be very helpful to have access to (a bool indicating) whether or not the file was re-encoded from the encoding specified by the files.encoding setting (meaning that the file encoding was not able to be auto-detected).  The C/C++ Extension indexed files in the workspace, honoring the files.encoding setting when reading directly from disk (if unable to detect the encoding).  When that setting changes we should reparse files, preferably only the ones impacted by that change. We can determine ourselves for files read directly from disk.  However, if open in the editor, we use the file buffer provided by VS Code. A change to files.encoding could indicate that the buffer we had used (from VS Code) may not have been translated correctly and should be reparsed.

Related: https://github.com/microsoft/vscode/issues/824


Paket convert-from-nuget adds paket.dependencies incorrectly to the solution file

Description
When using Paket 5.6.6, after running conversion from nuget on a solution with one project, the reference to the paket.dependencies is added in a way that the solution file fails to load.
Repro steps
Create a solution with one project.
Create a .paket directory and put Paket 5.6.6 there.
Run .paket\paket convert-from-nuget
Run .paket\paket auto-restore on
Try loading the solution in VS or Rider. Solution is not loaded.
Expected behavior
Solution should load and there should be a .paket solution folder added, with paket.dependencies file link in the solution folder.
The solution file section should look like:
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".paket", ".paket", "{3AC709DB-BDCA-4965-9004-52FC24A2425B}"
	ProjectSection(SolutionItems) = preProject
		..\paket.dependencies = ..\paket.dependencies
	EndProjectSection
EndProject

Actual behavior
The solution file is broken. It looks like this:
Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = ".paket", ".paket", "{3AC709DB-BDCA-4965-9004-52FC24A2425B}"
		..\paket.dependencies = ..\paket.dependencies
	ProjectSection(SolutionItems) = preProject
	EndProjectSection
EndProject

Known workarounds
Edit the solution file and move the line with paket.dependencies file inside the ProjectSection

I bet it's related to https://github.com/fsprojects/Paket/pull/2484 /cc @fsoikin

Indeed. I'll send another pull reqfefe.

I wonder though, @forki: after my fix, why did all tests pass?

because this is probably untested ...


It seems that prerender does not forward Accept-Language header correctly.

I made sure that the Accept-Language is sent, but my API receives the wrong Accept-Language (which seems to be same as the locale of the server running prerender.)

Right now, the Prerender server doesn't forward any headers through. That might be something worth adding though.


Error code "User input malformed" when seting up Nuki Lock 3.0 Pro without bridge

I'm using home assistant version 2021.10.6 as a container.
When I try to install a Nuki 3.0 Pro without a bridge but with web access and web token as described in your tutorial, I receive the following error message:

Can you advise what to do?
regards

Hi,
I think it's because you're using HA 2021.10 version, see this issue
it's fix in 2021.11 version

Hi,
after update HA to 2021.11.5 same behaviour.
Any other idea?

Hi,
The error is misleading, I know, but it says there were no devices fetched via Web API.
Do you have any other errors in logs? @rectangular-starchaser

Hi,
I changed my log level to debug and verified my api token externally with curl which works flawlessly. No further error logs are reported within hass logs. When setting up the integration the "user input is malformed" error remains until I fill in the form "Nuki bridge hostname or IP Address"
This behavior seems unexpected because in the setup method this parameter is set as optional: https://github.com/kvj/hass_nuki_ng/blob/16193216929746f8910ef46168404a1a60764781/custom_components/nuki_ng/config_flow.py#L78
So I assume this error is raised by hass and not by the integration itself?
Best Regards!

@rectangular-starchaser

and verified my api token externally with curl which works flawlessly

Could you please share the output?
The integration should work without a bridge, but something is missing in the output

HI, thanks for coming back on this one:
That's my curl command

curl -X GET --header 'Accept: application/json' --header 'Authorization: Bearer API_KEY_HERE' 'https://api.nuki.io/smartlock'
which yields:
[{"smartlockId":$id,"accountId":$accountid,"type":4,"lmType":0,"authId":$authid,"name":"Haustuer","favorite":false,"config":{"name":"Haustür","latitude":%lat_data,"longitude":$long_data,"autoUnlatch":true,"liftUpHandle":false,"pairingEnabled":true,"buttonEnabled":true,"ledEnabled":false,"ledBrightness":1,"timezoneOffset":0,"daylightSavingMode":0,"fobPaired":false,"fobAction1":4,"fobAction2":0,"fobAction3":0,"singleLock":false,"advertisingMode":0,"keypadPaired":false,"homekitState":1,"timezoneId":37,"deviceType":4,"wifiEnabled":true},"advancedConfig":{"totalDegrees":696,"singleLockedPositionOffsetDegrees":0,"unlockedToLockedTransitionOffsetDegrees":0,"unlockedPositionOffsetDegrees":0,"lockedPositionOffsetDegrees":0,"detachedCylinder":false,"batteryType":1,"autoLock":false,"autoLockTimeout":300,"autoUpdateEnabled":true,"lngTimeout":20,"singleButtonPressAction":1,"doubleButtonPressAction":5,"automaticBatteryTypeDetection":true,"unlatchDuration":3},"webConfig":{"batteryWarningPerMailEnabled":false},"state":{"mode":2,"state":3,"trigger":0,"lastAction":3,"batteryCritical":false,"batteryCharging":false,"batteryCharge":60,"keypadBatteryCritical":false,"doorsensorBatteryCritical":false,"doorState":0,"ringToOpenTimer":0,"nightMode":false},"firmwareVersion":196648,"hardwareVersion":2817,"serverState":0,"adminPinState":0,"virtualDevice":false,"creationDate":"2021-11-25T18:49:46.524Z","updateDate":"2021-12-10T15:53:02.527Z"}]

I've censored all privacy related date by replacing it with $var_name

Great, thanks for the output, very helpful. Nuki reports a new device type, which wasn't supported/expected. The value isn't documented yet, but other values look good.
I've pushed the change adding support of a new type. Please update to the latest version and try again

After updating I receive 2 devices and 15 entiteties:
Device 1: Nuki Haustuer
Device 2: Nuki Web API
Device 1:

Device 2:

In Device 1 some sensores are not available. Is there a possibility to open and close the device with the help of the  integration?
regards

@rectangular-starchaser Please update the integration once again. I've pushed some extra changes. It's a bit tough to add support without having a real device and with missing documentation

Thank's a lot for your support!! If you need more or more precise input from our side let us know.
I have updatetd the integration, some sensors are available others still not.

The real state at this time was locked. "Control" and "Sensor" section fine, "State" of "Diagnostic" section wrong. Door Open sensor or control not available.
And still an additional remark to the initial setup: I had to insert at least one character in the field: "Nuki Bridge Host Name or IP Adress". Without this character I received the reported error code "User input malformed".
Regards

@rectangular-starchaser

Door Open sensor or control not available

Now I better understand what's happening. Do you actually have the door sensor installed and configured?
In the JSON output you've shared, "doorState":0 state means that the door sensor is unavailable. Do you get this value every time you call the API?

@kvj
The additional external door sensor to validate if the door is realy closed or opened is not installed.  So if doorState is triggerd by the external sensor it is logical  that is not available. If "Door Open" in the "Sensor" section and "Door Stae" and "State" in the "Diagnostic" section depend on this externel door sensor then it is clear.
With the "Lock" switch in the "Controles" section, I am able to lock and unlock the door. But there is no way to realy open the door. Is this "Open" switch missing or is this functionality not given in the integration or over the web API. With the Android APP connected to the Nuki Wep API it is possible.
Regards

@rectangular-starchaser
Ok, got it. In case of Nuki 2.0, door sensor (quite unreliable) was included into package. With Nuki 3.0, it's optional and pricey. Your setup doesn't have it, therefore those entities should not be added. I've pushed some changes, please update the component and re-add it. I've also adjusted optional config input handling, you won't need to add any chars to make Web API only setup working.
Regarding the open/unlatch function, it's supported, but unfortunately there's no Lovelace UI for that. I've adjusted the README.md with workarounds https://github.com/kvj/hass_nuki_ng#openunlatch-nuki-lock-via-ui

@kvj
I updated in HACS; Deleted the former integration and did a new setup. I still had to enter a character in the field: "Nuki Bridge Host Name or IP Adress". Without this character I received the reported error code "User input malformed" again.
Result of new set up:

Next mission is to test the workaround.
Regards


⚠ main has degraded performance

In a26b4f8, main ($MAIN_API_URL) experienced degraded performance:

HTTP code: 200
Response time: 26272 ms

Resolved: main performance has improved in 64450d4.


feat: Create Tasks Sample in Kotlin

Add Kotlin Support

Create interface to keep both java and kotlin Activities in sync

Update Java Activity to implement the interface and override their methods

Create Kotlin Activity

Add Kotlin Activity to AndroidManifest

Second PR for #24

This one looks perfect, merging!


[integrations/fastify] Add documentation to enable SSE subscriptions

Discussed in https://github.com/dotansimha/graphql-yoga/discussions/3273

Originally posted by santino May 15, 2024
Hello folks, as mentioned by the title, I am looking to setup subscriptions in my Yoga implementation.
I am not using Yoga as a full server, but instead I am integrating it with my fastify instance.
The useGraphQLSSE plugin only seems to work if Yoga is executed as a server.
Do you have any example for writing up a plugin that only handles subscription requests received on my single /graphql endpoint?

I ended up building this plugin to handle subscriptions in my Fastify setup
import { EOL } from 'os'

export const useSubscription = () => {
  return {
    async onSubscribe () {
      return {
        async onSubscribeResult ({
          result,
          args: {
            contextValue: { req, reply }
          }
        }) {
          req.socket.on('end', () => {
            result.return()
            reply.hijack() // tell Fastify to skip the automatic invocation of reply.send()
          })
          req.socket.on('close', () => {
            reply.log.info(
              {
                res: reply,
                responseTime: reply.elapsedTime
              },
              'request completed'
            )
            reply.raw.end() // tell the server that all of the response headers and body have been sent
          })

          for await (const data of result) {
            reply.raw.write(
              `event: next${EOL}data: ${JSON.stringify(data)}${EOL}${EOL}`
            )
          }
        }
      }
    }
  }
}

Hopefully this is useful to other devs as well.

GraphQL Yoga doesn't need an extra plugin for SSE except single connection mode. You can see Fastify tests below that use the same path for subscriptions. Maybe you can help us reproducing your issue here;
https://github.com/dotansimha/graphql-yoga/blob/main/examples/fastify/__integration-tests__/fastify.spec.ts
GraphQL SSE plugin only handles single connection mode of GraphQL SSE protocol, and you can configure the path of that listens the subscriptions;
https://github.com/dotansimha/graphql-yoga/blob/main/packages/plugins/graphql-sse/src/index.ts#L17

You are absolutely right.
Thanks for your comment. I looked at the test and decided I had to make my implementation work in the correct way.
The issue I had initially was related to how I was setting an initial value for my subscription.
I was doing a pubSub.subscribe and then used a process.nextTick to create the first event for my subscription topic.
It was a convoluted solution with some drawbacks (had to make sure the "artificial" event would be issued only to the new subscriber), but it worked.
After migrating to Yoga the process.nextTick was somehow issued before the subscriber was actually subscribed to the pubSub. Not sure why, but this caused my "artificial" event to not be delivered. Because of this I wrongly assumed that this setup wasn't working.
Now I spent more time into this and figured all this out.
So I removed my custom useSubscription plugin entirely and switched to a much better solution to deliver my initial data to the subscription with this:
Repeater.merge([
  initialData,
  pubSub.subscribe(topic)
])

I think I would probably add something to the documentation that documents simple subscriptions without any need for the SSE plugin. Maybe make it more explicit.
In any case, this issue can be closed.

Thank you for your feedback!
It seems our documentation still need some update on this ? If it's the case, I will let this issue open to not forget about it :-)


Unable to upload Grafana dashboards

I believe I have followed the instructions but and are able to start both TeslaMate and Grafana Add-on. However, when I change the config on TeslaMate add-on to import dashboards I get the following error when trying to start TeslaMate add-on:
[s6-init] making user provided files available at /var/run/s6/etc...exited 0.
[s6-init] ensuring user provided files have correct perms...exited 0.
[fix-attrs.d] applying ownership & permissions fixes...
[fix-attrs.d] done.
[cont-init.d] executing container initialization scripts...
[cont-init.d] done.
[services.d] starting services
[services.d] done.
[15:28:29] INFO: Checking for Grafana folder: TeslaMate
jq: error (at :1): Cannot index string with string "title"
s6-svscanctl: fatal: unable to control /var/run/s6/services: supervisor not listening
[cont-finish.d] executing container finish scripts...
[cont-finish.d] done.
[s6-finish] waiting for services.
[s6-finish] sending all processes the TERM signal.
Any idea where to start looking?

Hi, i have a fresh install here and experience exactly the same issue. I checked my settings and credentials for more than three times and cannot find any deviation in the config so far.

Hi, i have a fresh install here and experience exactly the same issue. I checked my settings and credentials for more than three times and cannot find any deviation in the config so far.

I reinstalled everything (TeslaMate, Postgre, Grafana) and now the dashboards are imported. I don't know what I did differently this time though.


add setuptools to setup_requires

Due to issues discussed in #374, colcon-core setup requires setuptools 46.4.0 to install correctly.

Wouldn't this fail in the case of packaging into a Debian package since the targeted Ubuntu distros don't have a new enough version?

Wouldn't this fail in the case of packaging into a Debian package since the targeted Ubuntu distros don't have a new enough version?

I don't know. On Debian, how do we resolve Python versioned dependencies anyway? I didn't think there was any way to cleanly map Python package dependencies to system dependencies, much less one that respects the version.

On Debian, how do we resolve Python versioned dependencies anyway?

A Debian package can only depend on other Debian packages. So the generated python3-colcon-core Debian package must run with the Debian package python3-setuptools available. Therefore the Debian package can't have a minimum version number for setuptools which exceeds the version available from Debian.
Why does the minimum version in install_requires also need to be bumped? I would expect that a newer version is only necessary when invoking the setup.py file of colcon-core but not when the package is later used.
If only setup_requires is added it needs to be checked that this change doesn't affect the generated deb.

By definition, the version in install_requires is the one setup.py needs to run appropriately. setup.py relies on a new version of setuptools in order to determine the package version, so attempting to run setup.py with a lesser version will result in failures.
I think it also makes sense to bump the install_requires version, since all colcon packages rely on newer setuptools, so I did. If you want to hold that back for some reason, I'm okay with reverting that change, provided all downstream colcon versions also update their setup_requires for correctness.
Because the Debian package installation does not use setup.py, yes, I don't think this will affect deb-based installation. But this package is published on PyPI. So on Debian if you pip install colcon-core, or install in an isolated virtual environment, or try to use this on a non-Debian platform, the setup_requires key is a must (at least until this packages switches to pep-518).

By definition, the version in install_requires is the one setup.py needs to run appropriately.

Isn't your point that this is what setup_requires is for - not install_requires?

I think it also makes sense to bump the install_requires version, since all colcon packages rely on newer setuptools, so I did.

The install_requires defines what is needed to use a package. It shouldn't be misused to declared what downstream packages need to be setup - that is what setup_requires in those downstream packages is for.

Because the Debian package installation does not use setup.py, yes, I don't think this will affect deb-based installation. But this package is published on PyPI. So on Debian if you pip install colcon-core, or install in an isolated virtual environment, or try to use this on a non-Debian platform, the setup_requires key is a must (at least until this packages switches to pep-518).

We are on the same page here. That is why setup_requires should be added. And if it would pose a problem for the Debian package it could be removed with a Debian patch file (like other dependencies already).

Isn't your point that this is what setup_requires is for - not install_requires?

Oops! Yes, I meant “By definition, the version in setup_requires is the one setup.py needs to run appropriately.”

We are on the same page here. That is why setup_requires should be added

And CI should be running with an older version of setuptools as well. Does colcon run properly under an older setuptools when installed with an newer one? Won’t package identification misidentify the version of packages in the colcon workspace?

Does colcon run properly under an older setuptools when installed with an newer one? Won’t package identification misidentify the version of packages in the colcon workspace?

A package might or might not use the attr syntax and if it does it should probably declare that it needs a new enough setuptools version. I don't think it is colcons responsibility to do that.

Backed out the change to install_requires. I still think it belongs there, but you're the project maintainer so it's your call.

This field is deprecated in favor of PEP 517.


feat: adds retries for HTTP errors

Now we retry certain HTTP errors up to three times as per https://github.com/octokit/plugin-retry.js/

Some js module conversion mumbo-jumbo needed to make it work. Will research how to fix.


Fix null pointer in FoldInsertWithConstants.

Struct types are not supported in constant folding yet.

I was trying to reproduce the issue with a small test, but so far it only occurred with one of our large Niagara shaders and I can't add them to this repository.
I can point you to the null pointer, though:
https://github.com/KhronosGroup/SPIRV-Tools/blob/main/source/opt/constants.cpp#L412

I don't think it should be all that hard to reproduce in a folding test.
You will want to add a test to https://github.com/KhronosGroup/SPIRV-Tools/blob/0994ca45b663296d733e89c5d89dbd4347e065c1/test/opt/fold_test.cpp#L7088
The new tests will be similar to https://github.com/KhronosGroup/SPIRV-Tools/blob/0994ca45b663296d733e89c5d89dbd4347e065c1/test/opt/fold_test.cpp#L7297.
You will want to have an insert that is something like:
%4 = OpCompositeInsert  %struct_v2int_int_int %int_1 %struct_v2int_int_int_null 2

I believe that should reproduce your problem.

Thanks for your feedback. I don't have a proper workflow for the test cases yet, but will do that for the next PR.


Play Audio Clip from code

Can I play sound from code?

You can rely on the documentation to get information about this.
You need to create a new class and inherit from the "SoundPocketManager" class. In your class, you can implement the logic you need and use the methods declared in the "SoundPocketManager" class as "xxxxHandler", these methods control the "SoundPocket" class (or several classes if there is more than one on the object) that will be received from the GameObject assigned in the "SoundPocket" field. This class will be derived from the "MonoBehaviour" class, so you can assign it to the GameObject and perform the operations you need.
In addition, you can also directly affect the "SoundPocket" class through public methods (for example, the "Play" method to start playing a queue of clips assigned to this "SoundPocket" class) and changing the values of public variables.


Games manually added to the Steam are not automatically imported

Games manually added to the steam are not automatically imported together with the games bought on steam, so GOG Galaxy 2.0 did not add any of the manually added games from outside of steam, when the steam games were imported.

I cannot add manually covers to some games. It does not allow it anymore. I have almost 2000 steam games

This is nothing to do with the plugin API. Please report this issue directly to the plugin developer.


GOT SIGTERM, shutting down home bridge issue

Added a keypad to my previously working radiora1/homebridge integration. and then this started...
[12/30/2021, 9:31:21 AM] TypeError: Cannot read properties of undefined (reading 'toString')
at new KeypadButton (/homebridge/node_modules/homebridge-radiora2/lib/accessories/keypadbutton.js:15:72)
at RadioRA2Platform.addKeypadButtonAccessory (/homebridge/node_modules/homebridge-radiora2/index.js:141:44)
at RadioRA2Platform. (/homebridge/node_modules/homebridge-radiora2/index.js:281:34)
at Array.forEach ()
at RadioRA2Platform. (/homebridge/node_modules/homebridge-radiora2/index.js:272:26)
at RadioRa2.emit (node:events:390:28)
at incomingData (/homebridge/node_modules/homebridge-radiora2/lib/radiora2.js:97:20)
at Socket. (/homebridge/node_modules/homebridge-radiora2/lib/radiora2.js:27:92)
at Socket.emit (node:events:390:28)
at addChunk (node:internal/streams/readable:315:12)
[12/30/2021, 9:31:21 AM] [Hubitat-v2] Temperature Unit is Now: (F)
[12/30/2021, 9:31:21 AM] [Hubitat-v2] Updating Global Values | HubIP: <IP_ADDRESS> | UsingCloud: false
[12/30/2021, 9:31:21 AM] [Hubitat-v2] Devices to Remove: (0)
[12/30/2021, 9:31:21 AM] [Hubitat-v2] Devices to Update: (4)
[12/30/2021, 9:31:21 AM] [Hubitat-v2] Devices to Create:
[12/30/2021, 9:31:41 AM] Got SIGTERM, shutting down Homebridge...
[12/30/2021, 9:31:41 AM] [RadioRA2] Disconnecting

the button isn't named in your config. handled with the pull request which makes those optional

the button isn't named in your config. handled with the pull request which makes those optional

Thank you for the prompt response. Can you explain a little further I don’t
see where I had to name it and I’m not exactly sure what a pull request is
or how to use that.
Thanks.
On Fri, Dec 31, 2021 at 5:27 PM senorshaun @.***> wrote:

the button isn't named in your config. handled with the pull request which
makes those optional
—
Reply to this email directly, view it on GitHub
https://github.com/senorshaun/homebridge-radiora2/issues/12#issuecomment-1003481067,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHS7I7J655SQVR4UJKCJY3UTZKBNANCNFSM5LAB37UQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

Thank you for the prompt response. Can you explain a little further I don’t
see where I had to name it and I’m not exactly sure what a pull request is
or how to use that.
Thanks.
On Fri, Dec 31, 2021 at 5:27 PM senorshaun @.***> wrote:

the button isn't named in your config. handled with the pull request which
makes those optional
—
Reply to this email directly, view it on GitHub
https://github.com/senorshaun/homebridge-radiora2/issues/12#issuecomment-1003481067,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAHS7I7J655SQVR4UJKCJY3UTZKBNANCNFSM5LAB37UQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>

I just published 1.3.4 to npm. update your copy of the plugin. @cariacou modified some code to make parameters, like the name of buttons, optional.
here's an example config where it shows buttons and keypads using names
"keypads": [                         {                                 "name": "Lutron Buttons",                                 "id": 1,                                 "model": "RR-MAIN-REP-WH",                                 "serial": "xxxxxxxxx",                                 "stateless": false,                                 "buttons":[                                         {                                                 "name": "Normal Light Level",                                                 "id": 1,                                                 "led": 101                                         },                                         {                                                 "name": "Low Light Level",                                                 "id": 2,                                                 "led": 102                                         }, ...

I just published 1.3.4 to npm. update your copy of the plugin. @cariacou modified some code to make parameters, like the name of buttons, optional.
here's an example config where it shows buttons and keypads using names
"keypads": [                         {                                 "name": "Lutron Buttons",                                 "id": 1,                                 "model": "RR-MAIN-REP-WH",                                 "serial": "xxxxxxxxx",                                 "stateless": false,                                 "buttons":[                                         {                                                 "name": "Normal Light Level",                                                 "id": 1,                                                 "led": 101                                         },                                         {                                                 "name": "Low Light Level",                                                 "id": 2,                                                 "led": 102                                         }, ...


Default AP SSID name not working (IDFGH-7141)

Environment

Development Kit:      ESP32-S2 MINI-1 custom board
Module or chip used:  ESP32-S2 MINI-1
IDF version (run git describe --tags to find it): v4.4
Build System:         idf.py
Operating System:     Windows 10
(Windows only) ESP Command Prompt
Using an IDE?: VSCode
Power Supply:         USB

Problem Description
Using an AP SSID where ssid[0] is 0xFF and ssid[1] is 0xFF I do not obtain the default SSID generated by the ESP32.
Here my code
esp_err_t
wifi_ap_init (const uint8_t ap_ssid[SSID_LENGTH],
              const uint8_t ap_password[PSWD_LENGTH])
{
    int valid_credential = 0;
    esp_err_t ret = ESP_OK;

    esp_netif_ip_info_t ipInfo;

	ESP_ERROR_CHECK(esp_netif_dhcps_stop(g_p_wifi_ap));
    IP4_ADDR(&ipInfo.ip, 192, 168, 1, 1);
    IP4_ADDR(&ipInfo.gw, 192, 168, 1, 1);
	IP4_ADDR(&ipInfo.netmask, 255, 255, 255, 0);

	ESP_ERROR_CHECK(esp_netif_set_ip_info(g_p_wifi_ap, &ipInfo));

	ESP_ERROR_CHECK(esp_netif_dhcps_start(g_p_wifi_ap));
    ESP_LOGI(g_p_tag, "AP - IP: " IPSTR, IP2STR(&ipInfo.ip));
    ESP_LOGI(g_p_tag, "AP - GW: " IPSTR, IP2STR(&ipInfo.gw));
    ESP_LOGI(g_p_tag, "AP - Mask: " IPSTR, IP2STR(&ipInfo.netmask));

    g_wifi_event_group = xEventGroupCreate();

    ESP_ERROR_CHECK(esp_wifi_stop());

    ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_NULL));

    wifi_config_t wifi_access_point_config = {
        .ap = {
            .max_connection = MAX_STA_CONNECTED,
            .authmode = WIFI_AUTH_WPA_WPA2_PSK
        },
    };

    valid_credential = wifi_check_ssid_validity((char *) ap_ssid);
    if (0 == valid_credential)
    {
        ESP_LOGI(g_p_tag, "SSID AP OK");
        (void) strcpy((char *) wifi_access_point_config.ap.ssid,
                      (char *) ap_ssid);
    }
    else
    {
        ESP_LOGW(g_p_tag, "SSID AP non ok");
        wifi_access_point_config.ap.ssid[0] = 0XFF;
        wifi_access_point_config.ap.ssid[1] = 0XFF;
    }
    ESP_LOGI(g_p_tag, "AP SSID = %s", wifi_access_point_config.ap.ssid);

    valid_credential = wifi_check_password_validity((char *) ap_password);
    if (0 == valid_credential)
    {
        ESP_LOGI(g_p_tag, "PASSWORD AP OK");
        (void) strcpy((char *) wifi_access_point_config.ap.password,
                      (char *) ap_password);
    }
    else if (1 == valid_credential)
    {
        ESP_LOGW(g_p_tag, "PASSWORD AP non inserita");

        wifi_access_point_config.ap.authmode = WIFI_AUTH_OPEN;
    }
    else
    {
        ESP_LOGW(g_p_tag, "PASSWORD AP non ok");
        (void) strcpy((char *) wifi_access_point_config.ap.password,
                      "defaultvalue");
    }
    ESP_LOGI(g_p_tag, "AP PSWD = %s", wifi_access_point_config.ap.password);

    ESP_ERROR_CHECK(esp_wifi_set_mode(WIFI_MODE_AP));

    ESP_ERROR_CHECK(esp_wifi_set_config(WIFI_IF_AP, &wifi_access_point_config));

    ESP_ERROR_CHECK(esp_wifi_start());

    ESP_LOGI(g_p_tag, "Created ap with SSID:%s password:%s",
             wifi_access_point_config.ap.ssid,
             wifi_access_point_config.ap.password);

    return ret;
}

It's not important how I check if the SSID is valid, because after I see a not valid SSID it set the first two bytes.
Here the problem: I saw that, instead of creating the default ESP32's SSID, it used the previous (valid) stored SSID.
Below I attach what I see on terminal.
You can see the two question marks that are the 0xFF.
On my PC I look at the APs detected and I see ABCDEFGH that correspond to the previous (saved in NVS?)  SSID. The password corresponds to what I choose.
Expected Behavior
From the official description of the Wi-Fi driver here, I read:

SSID of AP; if the ssid[0] is 0xFF and ssid[1] is 0xFF, the AP defaults the SSID to ESP_aabbcc, where “aabbcc” is the last three bytes of the AP MAC.

Debug Logs
W (1483) wifi_manage: SSID AP non ok
I (1493) wifi_manage: AP SSID = ��
W (1493) wifi_manage: PASSWORD AP non ok
I (1503) wifi_manage: AP PSWD = 1234ABCD
....
I (5603) wifi_manage: Created ap with SSID:�� password:1234ABCD

I was just having this same problem. I think the problem is the compiler optimizing the wifi_config_t struct with null values or some mysterious stack related issue. I used: wifi_config_t wifi_config = {0}; and then filled in each parameter manually like this:
wifi_config.ap.channel = EXAMPLE_ESP_WIFI_CHANNEL;
wifi_config.ap.ssid_len = asprintf(&SSID, "esp32c3%x%x%x", mac[3], mac[4], mac[5]);
memcpy(wifi_config.ap.ssid, SSID,wifi_config.ap.ssid_len);
and so on.
Make sure to flash the NVS before changing the SSID or it won't broadcast properly.
ESP_ERROR_CHECK(nvs_flash_erase());
If you will be changing the SSID often and need to keep the rest of the NVS intact find the storage tag that the WIFI API uses and erase it like that instead.

I was just having this same problem. I think the problem is the compiler optimizing the wifi_config_t struct with null values or some mysterious stack related issue. I used: wifi_config_t wifi_config = {0}; and then filled in each parameter manually like this: wifi_config.ap.channel = EXAMPLE_ESP_WIFI_CHANNEL; wifi_config.ap.ssid_len = asprintf(&SSID, "esp32c3%x%x%x", mac[3], mac[4], mac[5]); memcpy(wifi_config.ap.ssid, SSID,wifi_config.ap.ssid_len); and so on. Make sure to flash the NVS before changing the SSID or it won't broadcast properly.

So you force an SSID in a manner it behaves like the default one. But I think, seen what's happening, that this is a bug!

ESP_ERROR_CHECK(nvs_flash_erase()); If you will be changing the SSID often and need to keep the rest of the NVS intact find the storage tag that the WIFI API uses and erase it like that instead.

I can't erase the entire NVS because I use it to store other variables. Yes, I could delete only the Wi-Fi reserved area of NVS. However I'm pretty sure there is a bug..

How about:
wifi_access_point_config.ap.ssid[0] = 0X0;

wifi_access_point_config.ap.ssid[0] = 0X0;

I can confirm that, by doing in this way, it sets the following SSID! ESP_E45453
So it doesn't follow the specs in the documentation, there is a different behaviour. However now it's fine, thanks!

you have to get config: esp_wifi_get_config

It works, here the log:
I (6234) wifi_manage: Created ap with SSID:ESP_E45453 password:1234ABCD

I'm encountering another bug related to the previous problem: ESP32 creates the SSID expected BUT I'm not able to connect to it anymore.
I tried to switch back to a known SSID and I can connect to it with the provided password 1234ABCD.
Connecting to ESP_E45453 my PC tries some connections but nothing to do.. Turning off the ESP I see an error message on my PC such as "Not valid credentials". But I didn't change them.

@filgra96 can you try to forget the network on your PC and try connecting again.Pls provide the console logs of the DUT when your are trying to connect

I'm having similar connection issues. With connections beeing unstable or not even possible to connet. Another symtom I see is that the SSID is not picked up by Windows and its showen as if it was hidden, while on android everything is semi fine (still having problems with stabilitiy...).

Thanks for reporting, fix is available https://github.com/espressif/esp-idf/commit/88f79ca9caed2b3f2fc673995c1269ef6d1fd744, feel free to reopen. Thanks.

@Alvin1Zhang
should this code work ?
or should we do the Story with the 2 times FF like in the Documentation ?
    wifi_config_t wifi_config = {
        .ap = {
            .ssid = "",
            .ssid_len = 0,

OK, i use ESP-IDF 5.1, and there is still a Bug:
if i use it with
 .ssid = "",
  .ssid_len = 0,

i generates the Default SSID, but i still cannot connect, like https://github.com/espressif/esp-idf/issues/8744#issuecomment-1092555592
if i make a
    wifi_config_t wifi_config = {
        .ap = {
            .ssid = "XX",
            .ssid_len = 2,
            .channel = EXAMPLE_ESP_WIFI_CHANNEL,
            .password = EXAMPLE_ESP_WIFI_PASS,
            .max_connection = EXAMPLE_MAX_STA_CONN,
            .authmode = WIFI_AUTH_WPA_WPA2_PSK,
            .pmf_cfg = {
                    .required = false,
            },
        },
    };

    wifi_config.ap.ssid[0] = 0XFF;
    wifi_config.ap.ssid[1] = 0XFF;

it is fine.

Hi @diplfranzhoepfinger,
Setting the ssid to blank and ssid_len to 0 will also set the ssid to default. We tried reproducing the issue at our end, but we are unable to do so.
Can you please send the example code you are using along with debug logs showing default ssid is generated? please also share sniffer capture.
Here is how to enable debug logs from menuconfig.
In "idf.py menuconfig" goto Component config->Log output and select default log verbosity to debug/verbose.
To capture sniffer, you can go through this.
Thanks.

i will do so, as soon as i can.
Thanks for your Answer.


Add Java 17 build test to GitHub action

We are planning to upgrade the JDK to JDK 17 due to the performance issue:
https://bugs.openjdk.org/browse/JDK-8159720
This PR add Java 17 build test to GitHub action.

cc @xerial


Correct the function names in SSL_CTX_set_stateless_cookie_generate_c…

…b.pod
Although the synopsis used the correct function names, the description did
not. Also the description of the equivalent DTLSv1_listen() callbacks was
missing, so these have been added.
Fixes #10030

Pushed. Thanks.


Feature: Increase the number of blocks for reporting uptime %

Right now Station reports uptime on the last 10K blocks, which is the current signing window. However, this is only about a 16 hour time period and it is actually a useless metric for users. For example, see this validator which reports 100% on Station but has missed 12354 votes in the past Oracle Slash window: https://lcd.terra.dev/oracle/voters/terravaloper1grgelyng2v6v3t8z87wu3sxgt9m5s03x2mfyu7/miss
So I suggest we increase the block uptime reported to the Oracleslash window which I think will be more indicative of validator performance and more useful to users since they care about not getting slashed. There is some confusion here, since the docs says the SlashWindow is BlocksperWeek (100,800) but the API reports the slash_window as BlocksperMonth (432,000) (from: https://lcd.terra.dev/oracle/parameters). Either way, we should update that block uptime to whichever number is correct.
I would propose a pull request but I was am not experienced enough to figure out how to make this change.

Good suggestion. We will do this.

I think the missed oracle votes returned by  https://lcd.terra.dev/oracle/voters/operator_add/miss is cumulative, not per slashing window period.
Also, the current code fix seems to only use missed oracle votes only, that doesn't seem correct.
https://github.com/terra-money/fcd/blob/86f54be7214fd1c4b0f7941f1b9e472f4e9a9ea8/src/collector/staking/validatorDetails.ts#L102


Adapt latest changes from TrustSDK

Now we have error handling and it's all wrapped into Result object. Can you adjust it?
https://github.com/TrustWallet/TrustSDK-iOS

done via 4ac19dfb89f1f06cb5969b1ca508d848ed3c20c2


Serialization for custom classes

Here's my code for getting custom data types to work.

Closing because this is ancient


Reuse of ISPD contest codes

Great work!
I'm also happy to see that the ISPD contest and scripts enabled your research. However, I'm not happy with the fact that you didn't provide any credit and reference to that. I'd like to kindly request you to add credit and references to the ISPD paper and website to the main README as well as all the files you utilized.
Thanks and best regards,
Johann

For the record, this is the website I'm referring to: https://wp.nyu.edu/ispd_22_contest/ In particular, the scripts released at https://drive.google.com/file/d/1oz-qoB13UM_LmZcEjIV9gMuinNlxothd/view?usp=sharing are reused here.

Hi Johann,
Thank you for bringing this to my attention. I apologize for the oversight. Your work and the resources from the ISPD22 contest have indeed been instrumental in my research, and it was not my intention to neglect giving proper credit.
I have now updated the README file and the relevant source files to include the appropriate acknowledgements and references to the ISPD paper, website, and the scripts. You can find the changes in the latest commit.
I appreciate your understanding and contribution. I hope this resolves the issue, but please let me know if there's anything more I can do.
Best regards,
Xinming

Thanks Xingming, much appreciated!
Best, Johann


If remove core layout

Not for merging yet. Opening early for discussion.
Hotels and waldorf both still use the core layout which basically is a fixed width version of the site scaffold. Now that most of the site is responsive we really want to deprecate any notion of building to a fixed width so this PR removes that layout.
Fixed width sites in these apps would set an instance variable to toggle that 'mode'. They essentially get the same media query treatment as old IE. As we pick off the last few pages we can remove the variable and, eventually, remove the core_fixed.css file in this PR.
The main benefit to this is that we can remove the responsive class from the body as it will no longer act as a toggle. The next PR would remove all mentions of that class in the css, simplifying it a lot.

looks good to me +1


Protection against possible XXE with XML parsers

The parser used in the RI is not hardened against a possible XXE attack. It depends on the parser being offered by the platform if the parser is by default not hardened against this attack. It is better to make this part of the RI code base to protect users against this.
See https://www.owasp.org/index.php/XML_External_Entity_(XXE)_Processing for more information.

Dear Sender,
Please be aware that I will be out of office until Monday 4 December 2017. I will read and answer your email less frequently during my absence.
Best regards,
Jeroen Bode,
Director USEF.
www.usef.energy

See pull request for a possible fix


fix 'Script that worked in version 1.5.0 but no longer works in 1.9.4. (close #5600)

@testcafe-build-bot retest

FPR


Error

Command "python setup.py egg_info" failed with error code 1 in C:\Users\XXX\AppData\Local\Temp\pip-build-uwp4gwn7\win32gui\

Which python version you are using, recommended to use python 3.7.4 32bit
Also run this command : python -m pip install pywin32
This is link of Offline pywin32 module, in case you are unable to install pywin32
https://www.lfd.uci.edu/~gohlke/pythonlibs/#pywin32


What should print search on an empty search?

I often chain several searches with pipes:
$ echo -e "foo,bar\nbli,blo" | xsv search -s foo bla | xsv search -s bar blo
Selector name 'bar' does not exist as a named header in the given CSV data.

Here, the first search does not find any result, so nothing is sent to the second one, which will issue a warning because the column bar is not defined any more. Isn't it a bit strange, semantically? Especially in comparison to stats or frequency which always print a header line even on an empty input. Shouldn't search always print the headers line of the input file as well?

Maybe this is just a theoretical folly, but if you define the type of a CSV file by its header, then you can also type the functions search, frequency and stats.  While frequency and stats take any type and return respectively the field,value,count type and the field,[...],stddev type, it is reasonable to think that search should conserve the type of its argument: search: 'a -> 'a.  I guess then that the question boils down to the highly fundamental issue of the type of the empty CSV file. :smile:

I think practical considerations and consistency trump type theory in the case of this tool. I do think xsv search should probably print something sensible to enable what you're trying to do.

I do think xsv search should probably print something sensible to enable what you're trying to do.

Like the header row even if the search is unsuccessful?

@Armavica This should be fixed. Headers are always shown even if there were no matching rows. (Amusingly, the code was going out of its way to not show the headers when no results were found.)


Html element like Iframe,  support

Description
Hi,
Looks in roadmap there is plan for supporting html export. I wonder if it's possible to support html element.  For example, iframe element. If it's possible, it's really very helpful for writing online technical tutorial/blog/notes. We can easily embed online videos/interactive figures like wandb/dash-plot/......
It's really very exciting if you would like to support html element embedding.
Use Case
For example, embed html video like markdown language.
(Though github issues not support iframe yet.)

This belongs here I think
https://github.com/typst/typst/issues/721

Typst will not have special support for iframe elements. We might have some way to export arbitrary raw HTML although this also once more needs security consideration. Can be discussed in #721.


[Snyk] Security upgrade org.springframework.boot:spring-boot-starter-web from 3.0.0 to 3.0.1

This PR was automatically created by Snyk using the credentials of a real user.Snyk has created this PR to fix one or more vulnerable packages in the `maven` dependencies of this project.
Changes included in this PR

Changes to the following files to upgrade the vulnerable dependencies to a fixed version:

pom.xml

Vulnerabilities that will be fixed
With an upgrade:

Severity
Priority Score (*)
Issue
Upgrade
Breaking Change
Exploit Maturity
Reachability

440/1000  Why? Recently disclosed, Has a fix available, CVSS 4.8
Improper Input Validation SNYK-JAVA-ORGAPACHETOMCATEMBED-3225086
org.springframework.boot:spring-boot-starter-web:  3.0.0 -> 3.0.1
No
No Known Exploit
No Path Found

(*) Note that the real score may have changed since the PR was raised.
Check the changes in this PR to ensure they won't cause issues with your project.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
🛠 Adjust project settings
📚 Read more about Snyk's upgrade and patch logic

Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.

Fixed on fb7d402


WIP Release 0.2.0

Ringkasan Pull Request
Perubahan signifikan dari 0.1.3 ke 0.2.0.
Perbaikan/Fitur
close #.

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e1eb5fc). Click here to learn what that means.
The diff coverage is 13.04%.

@@           Coverage Diff            @@
##             master     #42   +/-   ##
========================================
  Coverage          ?   8.21%
========================================
  Files             ?       5
  Lines             ?     146
  Branches          ?      32
========================================
  Hits              ?      12
  Misses            ?     134
  Partials          ?       0

Impacted Files
Coverage Δ

hidrokit/prep/excel.py
0% <0%> (ø)

hidrokit/prep/timestep.py
0% <0%> (ø)

hidrokit/viz/table.py
0% <0%> (ø)

hidrokit/viz/graph.py
0% <0%> (ø)

hidrokit/prep/read.py
100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1eb5fc...99ed302. Read the comment docs.


Use CSS definition of line height

Builds on top of https://github.com/linebender/parley/pull/76 which should be merged first to preserve history.
Implements CSS style line height computation.
The actual change here (just the last commit) is ready, but will conflict with https://github.com/linebender/parley/pull/76 which isn't. If we land https://github.com/linebender/parley/pull/67 then we can swap the order of this and #76 so that this lands first if we want to.

The actual change here is ready, but will conflict with https://github.com/linebender/parley/pull/76 which isn't. If we land https://github.com/linebender/parley/pull/67 then we can swap the order of this and #76 so that this lands first if we want to.

I'll take a look at this again after we get InlineBox in. I think that there's some question as to whether this is correct to do at this layer, since it introduces questions about rounding.

I've rebased this to be directly on top of main (so we can potentially land it before https://github.com/linebender/parley/pull/76).
I don't see how we'd do this outside of this layer as it controls the spacing between lines (a key part of layout!). And without this change parley doesn't let the user control that as it computes it from the font metrics (in a slightly different way to this - letting ascent + descent + leading control the line height, rather than letting line_height - (ascent + descent) control the leading).

I took a look and I think it's fine the way it is, except the comment on the line_height property seems to say that it can be a ‘px value’ which is incorrect.


V0.7.0 Add S3 support

The English version has one less link because of historical reasons. Blogs did not have an English version at the moment.


Remove scrollbar

📃 Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.
Related Tickets & Documents
Fixes #178
What type of PR is this? (check all applicable)

[ ] 💡 Feature
[x] 🐛 Bug Fix
[ ] 📃 Documentation Update
[ ] 🎨 Style Changes
[ ] 💻 Code Refactor
[ ] 🔥 Performance Improvements
[ ] ✅ Test

🔰 Type of change
Please delete options that are not relevant.

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

❓ How Has This Been Tested?
NIL
🔰 Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] My changes generate no new warnings
[ ] Any dependent changes have been merged and published in downstream modules

@obere4u if your pull request is aimed at addressing an already stated issue, please try to mention that in the description.


Commands documentation

Add documentation for commands and ddd
Mostly from the Bifrost docs, with some additions to Commands introduction

Wrong repo


Danny delete bucket

Explain the changes

delete bucket and content in the background

added to bucket api delete_bucket_and_objects, which marks the bucket as deleting. the bucket is renamed to allow new buckets to reuse the name.
deleting buckets are not returned in lists, and are excluded in some internal operations on buckets.
deleting buckets are iterated in the background by buckets_reclaimer which deletes all objects in batches of 1000
when the bucket is empty it is deleted completely

added a way to disable sensitive string using env DISABLE_SENSITIVE_STRING. Intended to be used in dev envs only.

Issues: Fixed #xxx / Gap #xxx

Fixes #5460

Testing Instructions:

@nimrod-becker I did miss md_aggregator, fixed now.
as to nodes_client, I am not sure we need to fileter deleting buckets there, so we won't get to a situation where a bucket is missing (seems that we assume there that a bucket is always found).
aws_usage_metering is not relevant anymore. I will remove it in a differnet PR

I have 700+ empty buckets that need to be deleted. Is there any easy way to do this?

@tommyhargroves can you please open an issue with your question. This PR is not relevant for your question


AttributeError: 'Dataset' object has no attribute 'value'

Hi!
I'm trying to open a Cloudsat file. I've been able to install the environment and run some code of the "Quickstart" notebook, but when I want to run In[23]:
cloudsat_lons, cloudsat_lats, cloudsat_height, cloudsat_time, elev = get_geodata(fname, return_list=True) elev = elev * 1e-3
it throws the following error:

AttributeError                            Traceback (most recent call last)
 in
----> 1 cloudsat_lons, cloudsat_lats, cloudsat_height, cloudsat_time, elev = get_geodata(fname, return_list=True)
2 elev = elev * 1e-3
~/cloudsat_polarlows/cloudsat_read.py in get_geodata(h5name, varnames, proftime2datetime, return_list)
22
23         var_dict = {}
---> 24         for ivar in varnames:
25             fld_dtype = f[topkey]['Geolocation Fields'][ivar].value[0][0].dtype
26             var_dict[ivar] = (f[topkey]['Geolocation Fields'][ivar].value.sastype(fld_dtype))
AttributeError: 'Dataset' object has no attribute 'value'
I don't know why this happends, I haven't modified the cloudsat_read.py script.
I'll be very thankfull if you could help me.

Hi @paula-rj
This error is caused by the h5py library deprecating the value property of Dataset. I have updated the cloudsat_read module now (and the environment.yml file). So if you git-pull the changes and (optionally) update your conda environment, it should work.

Hi @paula-rj
This error is caused by the h5py library deprecating the value property of Dataset. I have updated the cloudsat_read module now (and the environment.yml file). So if you git-pull the changes and (optionally) update your conda environment, it should work.

Thanks! Now it works

Thanks! Now it works


Add native dependencies to doctest

This will traverse all native dependencies and add them to the rustdoc command when running tests.
Fixes #1245

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.
If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.
Please see CONTRIBUTING.md for more information.

Oh good catch! Does this also fix https://github.com/rust-lang/cargo/issues/1469? Also, could this pass -L native= instead of just a bare -L?

The 'native=' is already present in the native_dep variable.
Also #1469 and #1245 look very similar, so I believe that it does.

Oh right, good point!
@bors: r+ 55d7086012de36c9101013545dc0901932e0173d
Thanks!

:hourglass: Testing commit 55d7086 with merge 74da5e2...

:sunny: Test successful - cargo-linux-32, cargo-linux-64, cargo-mac-32, cargo-mac-64, cargo-win-32, cargo-win-64

Still fails for me (cargo 0.3.0-nightly (a2dd2ac 2015-06-24) (built 2015-06-23)).
I have OpenSSL libraries installed via LinuxBrew and build cargo test is failing on doctest ("normal" test are passing all green.
cargo test --verbose output:
https://gist.github.com/hauleth/7ca65dd5d046f2528910
When I manually run rustdoc --test <rest flags> -L native=$HOME/.linuxbrew/Cellar/openssl/1.0.2c/lib then everything passes green.
Project: https://github.com/hauleth/ucl-rs


dts: bindings: document nordic SPI pins

Document the meaning of the pin numbers by providing a reference to
the underlying HAL function used to decode them.

@anangl as an alternative, would you be willing to consider using GPIO specifiers instead?
Something like:
miso-gpio = <&gpio1 PIN FLAGS>;

We could continue to support the old bindings indefinitely, but I would find this a bit more readable personally. Not sure if "flags" is meaningful to this IP though (I kind of suspect not since we don't have this information in the binding currently).

@anangl as an alternative, would you be willing to consider using GPIO specifiers instead?
Something like:
miso-gpio = <&gpio1 PIN FLAGS>;

@mbolivar-nordic Sure. This would be more readable to users and I recall it was suggested several times. The question is how can this be converted into the number we need to write into the peripheral register. I guess we'll need some special handling for this in dts scripts.

We could continue to support the old bindings indefinitely, but I would find this a bit more readable personally. Not sure if "flags" is meaningful to this IP though (I kind of suspect not since we don't have this information in the binding currently).

I can't see any use for flags in this context.

@mbolivar-nordic Sure. This would be more readable to users and I recall it was suggested several times. The question is how can this be converted into the number we need to write into the peripheral register. I guess we'll need some special handling for this in dts scripts.

OK, I will think about this. In the meantime I think we can try to get this merged by documenting the existing bindings.

I'd suggest adding a macro that does something like:
#define DT_NRF_SPI_PINS(port, pin) (port & 0x1) << 5 | (pin & 0xf)

Where should we put this? include/dt-bindings/spi/spi-nrf.h?

I'd suggest adding a macro that does something like:
#define DT_NRF_SPI_PINS(port, pin) (port & 0x1) << 5 | (pin & 0xf)

Where should we put this? include/dt-bindings/spi/spi-nrf.h?

Perhaps dts/arm/nordic/nrf_common.dtsi would be a good place for such macro? And I think we should use a more generic name for this macro, as it will be useful for other peripherals as well. Maybe  DT_NRF_PSEL then (as the peripheral registers to which we write those values are named PSEL.*)?

Where should we put this? include/dt-bindings/spi/spi-nrf.h?

Perhaps dts/arm/nordic/nrf_common.dtsi would be a good place for such macro? And I think we should use a more generic name for this macro, as it will be useful for other peripherals as well. Maybe DT_NRF_PSEL then (as the peripheral registers to which we write those values are named PSEL.*)?

If you think it will be shared with the driver than put it in include/dt-bindings/...
However, it sounds like it will not be, so I'd maybe create a nordic.h or nrf.h in dts/arm/nordic and stick the macro there.

OK, the requests are clear. This is going to be more work than just adding documentation to a single SPI binding, though.
The extended scope means we will need to also change all the uses in .dts files and overlays for the relevant properties to use DT_NRF_PSEL(). This choice of name also applies to additional bindings, such as the serial "tx-pin" property.
I will need more time to do this. I am not sure I'll get to it this week.


vcpkg can't be used on a system with only VS2015 installed

I cannot install any library, not even the one at the readme page

PS C:\Development Softwares\vcpkg> .\vcpkg install sdl2 curl
Computing installation plan...
The following packages will be built and installed:
curl[core,non-http,ssl,sspi,winssl]:x86-windows
sdl2[core]:x86-windows

zlib[core]:x86-windows
Additional packages (*) will be modified to complete this operation.
Starting package 1/3: zlib:x86-windows
Building package zlib[core]:x86-windows...
-- Using cached C:/Development Softwares/vcpkg/downloads/zlib1211.tar.gz
-- Extracting source C:/Development Softwares/vcpkg/downloads/zlib1211.tar.gz
-- Applying patch cmake_dont_build_more_than_needed.patch
-- Using source at C:/Development Softwares/vcpkg/buildtrees/zlib/src/1.2.11-deec42f53b
-- Configuring x86-windows
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:72 (message):
Command failed: ninja -v
Working Directory: C:/Development Softwares/vcpkg/buildtrees/zlib/x86-windows-rel/vcpkg-parallel-configure
Error code: 1
See logs for more information:
C:\Development Softwares\vcpkg\buildtrees\zlib\config-x86-windows-out.log

Call Stack (most recent call first):
scripts/cmake/vcpkg_configure_cmake.cmake:297 (vcpkg_execute_required_process)
ports/zlib/portfile.cmake:22 (vcpkg_configure_cmake)
scripts/ports.cmake:90 (include)

Error: Building package zlib:x86-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with .\vcpkg update, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
Package: zlib:x86-windows
Vcpkg version: 2020.02.04-nohash

[1/2] cmd /c "cd .. && "C:/Development Softwares/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/bin/cmake.exe" "C:/Development Softwares/vcpkg/buildtrees/zlib/src/1.2.11-deec42f53b" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=C:/Development Softwares/vcpkg/downloads/tools/ninja/ninja-1.10.0/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_TARGET_ARCHITECTURE=x86" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Development Softwares/vcpkg/packages/zlib_x86-windows""
FAILED: ../CMakeCache.txt
cmd /c "cd .. && "C:/Development Softwares/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/bin/cmake.exe" "C:/Development Softwares/vcpkg/buildtrees/zlib/src/1.2.11-deec42f53b" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=C:/Development Softwares/vcpkg/downloads/tools/ninja/ninja-1.10.0/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_TARGET_ARCHITECTURE=x86" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Release" "-DCMAKE_INSTALL_PREFIX=C:/Development Softwares/vcpkg/packages/zlib_x86-windows""
CMake Warning at C:/Development Softwares/vcpkg/scripts/buildsystems/vcpkg.cmake:157 (message):
There are no libraries installed for the Vcpkg triplet x86-windows.
Call Stack (most recent call first):
C:/Development Softwares/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/share/cmake-3.17/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:4 (project)

-- The C compiler identification is unknown
CMake Error at CMakeLists.txt:4 (project):
No CMAKE_C_COMPILER could be found.

Tell CMake where to find the compiler by setting either the environment
variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
the compiler, or to the compiler name if it is in the PATH.

-- Configuring incomplete, errors occurred!
See also "C:/Development Softwares/vcpkg/buildtrees/zlib/x86-windows-rel/CMakeFiles/CMakeOutput.log".
See also "C:/Development Softwares/vcpkg/buildtrees/zlib/x86-windows-rel/CMakeFiles/CMakeError.log".
[2/2] cmd /c "cd ../../x86-windows-dbg && "C:/Development Softwares/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/bin/cmake.exe" "C:/Development Softwares/vcpkg/buildtrees/zlib/src/1.2.11-deec42f53b" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=C:/Development Softwares/vcpkg/downloads/tools/ninja/ninja-1.10.0/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_TARGET_ARCHITECTURE=x86" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-DSKIP_INSTALL_HEADERS=ON" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Development Softwares/vcpkg/packages/zlib_x86-windows/debug""
FAILED: ../../x86-windows-dbg/CMakeCache.txt
cmd /c "cd ../../x86-windows-dbg && "C:/Development Softwares/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/bin/cmake.exe" "C:/Development Softwares/vcpkg/buildtrees/zlib/src/1.2.11-deec42f53b" "-DSKIP_INSTALL_FILES=ON" "-DSKIP_BUILD_EXAMPLES=ON" "-DCMAKE_MAKE_PROGRAM=C:/Development Softwares/vcpkg/downloads/tools/ninja/ninja-1.10.0/ninja.exe" "-DBUILD_SHARED_LIBS=ON" "-DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/toolchains/windows.cmake" "-DVCPKG_TARGET_TRIPLET=x86-windows" "-DVCPKG_SET_CHARSET_FLAG=ON" "-DVCPKG_PLATFORM_TOOLSET=v140" "-DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON" "-DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON" "-DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DVCPKG_APPLOCAL_DEPS=OFF" "-DCMAKE_TOOLCHAIN_FILE=C:/Development Softwares/vcpkg/scripts/buildsystems/vcpkg.cmake" "-DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON" "-DVCPKG_CXX_FLAGS=" "-DVCPKG_CXX_FLAGS_RELEASE=" "-DVCPKG_CXX_FLAGS_DEBUG=" "-DVCPKG_C_FLAGS=" "-DVCPKG_C_FLAGS_RELEASE=" "-DVCPKG_C_FLAGS_DEBUG=" "-DVCPKG_CRT_LINKAGE=dynamic" "-DVCPKG_LINKER_FLAGS=" "-DVCPKG_TARGET_ARCHITECTURE=x86" "-DCMAKE_INSTALL_LIBDIR:STRING=lib" "-DCMAKE_INSTALL_BINDIR:STRING=bin" "-DSKIP_INSTALL_HEADERS=ON" "-G" "Ninja" "-DCMAKE_BUILD_TYPE=Debug" "-DCMAKE_INSTALL_PREFIX=C:/Development Softwares/vcpkg/packages/zlib_x86-windows/debug""
CMake Warning at C:/Development Softwares/vcpkg/scripts/buildsystems/vcpkg.cmake:157 (message):
There are no libraries installed for the Vcpkg triplet x86-windows.
Call Stack (most recent call first):
C:/Development Softwares/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/share/cmake-3.17/Modules/CMakeDetermineSystem.cmake:93 (include)
CMakeLists.txt:4 (project)

-- The C compiler identification is unknown
CMake Error at CMakeLists.txt:4 (project):
No CMAKE_C_COMPILER could be found.

Tell CMake where to find the compiler by setting either the environment
variable "CC" or the CMake cache entry CMAKE_C_COMPILER to the full path to
the compiler, or to the compiler name if it is in the PATH.

-- Configuring incomplete, errors occurred!
See also "C:/Development Softwares/vcpkg/buildtrees/zlib/x86-windows-dbg/CMakeFiles/CMakeOutput.log".
See also "C:/Development Softwares/vcpkg/buildtrees/zlib/x86-windows-dbg/CMakeFiles/CMakeError.log".
ninja: build stopped: subcommand failed.

I have visual studio 2015 update 3 installed, cmake runs perfectly outside of vcpkg.

PS C:\Development Softwares\vcpkg\downloads\tools\cmake-3.17.2-windows\cmake-3.17.2-win32-x86\bin> .\cmake.exe "C:\Development Softwares\vcpkg\buildtrees\bzip2\src\1.0.6-8838f21f8e"
-- Building for: Visual Studio 14 2015
-- Selecting Windows SDK version  to target Windows 10.0.17763.
-- The C compiler identification is MSVC 19.0.24215.1
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/cl.exe
-- Check for working C compiler: C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/cl.exe - works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: C:/Development Softwares/vcpkg/downloads/tools/cmake-3.17.2-windows/cmake-3.17.2-win32-x86/bin

It just cannot find the compiler at all when run from inside vcpkg

Silimar issue: #6724. You can try the steps from #6724.

It works after i changes the following:
vcpkg_configure_cmake.cmake
Add

if(DEFINED VS_PLATFORM_TOOLSET)
   list(APPEND _csc_OPTIONS
       "-T${VS_PLATFORM_TOOLSET}"
   )

endif()

after

if(DEFINED ARCH)
list(APPEND _csc_OPTIONS
"-A${ARCH}"
)
endif()

set these two to OFF

set(NINJA_CAN_BE_USED ON) # Ninja as generator
set(NINJA_HOST ON) # Ninja as parallel configurator

x64-windows-static-cmake
Add

set(VS_PLATFORM_TOOLSET "v140,host=x64")

Hi, @dan-shaw, I can't confirm if this issue is a bug, and I can't reproduce this issue locally. Could you help to confirm this? Thanks.


Sort the order of network driver list for docker info

- What I did
While playing with docker info I noticed that the output of the network may change randomly with different runs. For example, below are the two consecutive runs of docker info:
ubuntu@ubuntu:~/docker$ sudo docker info
...
Plugins:
 Volume: local
 Network: host bridge overlay null
...

ubuntu@ubuntu:~/docker$ sudo docker info
...
Plugins:
 Volume: local
 Network: null host bridge overlay
...

I think it might make sense to sort the list so that the output of the docker info is predictable.
- How I did it
This fix sorts the order of network driver for docker info.
- How to verify it
Tested manually, below is the output (predictable):
ubuntu@ubuntu:~/docker$ sudo docker info
...
Plugins:
 Volume: local
 Network: bridge host null overlay
...

- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Yong Tang<EMAIL_ADDRESS>

It seems that the order has already been addressed by other pull requests.


Write Tests

This is to remind me that I must write tests when the API is stable or there will be no breaking change.
I was thinking to write tests for the sample application & check if their behaviors are expected because testing each edge case with the navigator might take a lot of time. This maybe a good idea but will see!

At this point, I have tested each & every cut corner of the library via instrumented test. Any more tests will be implemented as a reproducer to any bugs or issues.


Removing long value of static member in class of test_composities fro…

What is the change?
This PR adds a doco meta field in reactor.tests.test_composities.MockBP that tells sphinx to not display the value of a couple static members.
Why is the change being made?
These members were essentially listing every nuclide in our library, which isn't very useful from a documentation point of view. It was also preventing a PDF build of the documentation.

Checklist

[ ] This PR has only one purpose or idea.
[ ] Tests have been added/updated to verify that the new/changed code works.

[ ] The code style follows good practices.
[ ] The commit message(s) follow good practices.

[ ] The release notes (location doc/release/0.X.rst) are up-to-date with any important changes.
[ ] The documentation is still up-to-date in the doc folder.
[ ] No requirements were altered.
[ ] The dependencies are still up-to-date in pyproject.toml.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.zprince seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.You have signed the CLA already but the status is still pending? Let us recheck it.


Make the number of threads in the fixed thread pool match the number …

…of unit test cases.

fyi @robzienert
I think this was the issue with the intermittent Travis failures. The number of threads in the fixed thread pool was too small and I'm thinking the requested jobs were still queued up when the comparison was made in the when: clause.

Relates to the Travis CI unit test failure on: https://github.com/spinnaker/scheduled-actions/pull/9

@lwander PTAL

The thread pool size from the test fixture ends up being used to create a LocalThreadPoolBlockingExecutor here: https://github.com/spinnaker/scheduled-actions/blob/master/scheduled-actions-core/src/main/java/com/netflix/scheduledactions/ActionsOperator.java#L67
LocalThreadPoolBlockingExecutor in turn create a fixed thread pool Executor here: https://github.com/spinnaker/scheduled-actions/blob/master/scheduled-actions-core/src/main/java/com/netflix/scheduledactions/executors/LocalThreadPoolBlockingExecutor.java#L39
As per javadocs (https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/Executors.html#newFixedThreadPool(int)), if no capacity remains, this happens: "If additional tasks are submitted when all threads are active, they will wait in the queue until a thread is available."

The failure we see intermittently on Travis CI can be consistently provoked locally by shrinking the size of the test fixture thread pool to 1.

Nice catch, LGTM


[FEATURE_REQUEST] Choose status dot position

Is your feature request related to a problem? If so, please describe.
The colored dot that presents the state of the service is on the upper right corner, next to the name of the service. With long titles it covers some letters.

Describe the solution you'd like
An option (global or for each service) to choose the position of the dot (lower-right, lower-left, etc.)
I'd love to help, but I'm not a developer. :)
Priority
Low (Nice-to-have)
Is this something you would be keen to implement
No response

You should be able to change this with CSS, if your unsure how I can send you a snippet when I get back to my PC this evening

You're amazingly fast, there was no urgency. :)
I'll try to do it by myself, in case I will ask for your help, is there a single CSS file?

I guess I'll wait for your help...don't know what to look for. :(
No urgency at all...low-priority.

Yup, that's the correct place to put any custom CSS. But you can also put it in your config file, under appConfig --> customCss, which is probably better, as it'll definitely stay backed up.
Here are some CSS snippets which will force the status indicator into different positions:

Top-Left: .indicator { left: 0; }
Top-Right: .indicator { top: 0; right: 0; }
Bottom-Left: .indicator { bottom: 0; left: 0; top: unset; }
Bottom-Right: .indicator { bottom: 0; right: 0; top: unset; }

If you need to set different positions for just certain items it's a bit more complicated. You'll need to find the ID for that item (visible in the edit item menu), then you can target it specifically with: #link-1_1302_pihole .indicator { bottom: 0; right: 0; top: unset; } (replace with actual ID, keep the #). Although moving an item can cause it's ID to change.
And if you need to force-override a CSS property, you can use !important before the semi colon, but use sparingly or things can get messy.

In the future, I will consider adding this as a config option
But have a few other things to get done first
If/ when it gets done, I will update you here :)
Feel free to reach out if there's anything else

Yup, that's the correct place to put any custom CSS. But you can also put it in your config file, under appConfig --> customCss, which is probably better, as it'll definitely stay backed up.

It didn't work when I edited the config file directly, don't know why. In the end, I used the integrated "Edit App Config" in Edit Mode:

I saved to disk and it updated the config file too. Refreshed and it worked beautifully:

Thank you Lissy, you're awesome, like Dashy. :)


[5.4] Fix MySQL deletes with JOIN while using table Aliases

Fixes https://github.com/laravel/framework/pull/18098

@fernandobandeira I'm not familiar with SqlServer, do you mind if you point me to the right place in docs?

Docs
DELETE spqh
  FROM
               Sales.SalesPersonQuotaHistory AS spqh
    INNER JOIN Sales.SalesPerson             AS sp  ON spqh.BusinessEntityID = sp.BusinessEntityID
  WHERE
    sp.SalesYTD > 2500000.00;

Basically the same, just edit this function when testing you'll need to use [users] instead of `users`, just change that the query should be the same...

Merged.


[proj4] build failure

Host Environment

OS: ubuntu20.04
Compiler: g++

To Reproduce
Steps to reproduce the behavior:
./vcpkg install proj4:x64-linux
i also changed triplets/x64-linux.cmake
set(VCPKG_LIBRARY_LINKAGE static) to set(VCPKG_LIBRARY_LINKAGE dynamic)
Failure logs
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:155 (message):
    Command failed: */vcpkg-master/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake --build . --config Debug --target install -- -v -j7
    Working Directory: */vcpkg-master/buildtrees/proj4/x64-linux-dbg
See logs for more information:
      */vcpkg-master/buildtrees/proj4/install-x64-linux-dbg-out.log
Call Stack (most recent call first):
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:102 (vcpkg_execute_build_process)
  installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:41 (vcpkg_cmake_build)
  ports/proj4/portfile.cmake:55 (vcpkg_cmake_install)
  scripts/ports.cmake:140 (include)

install-x64-linux-dbg-out.log:
[1/207] cd */vcpkg-master/buildtrees/proj4/src/7.2.1-8a72a3c582.clean/data && *vcpkg-master/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake -DALL_SQL_IN=*/vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/all.sql.in -P */vcpkg-master/buildtrees/proj4/src/7.2.1-8a72a3c582.clean/data/generate_all_sql_in.cmake
[2/207] cd */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data && */vcpkg-master/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake -E remove -f */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/proj.db && */vcpkg-master/installed/x64-linux/tools/sqlite3 -init */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/all.sql.in */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/proj.db .quit && */vcpkg-master/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake -E copy */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/proj.db */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/for_tests
FAILED: data/proj.db */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/proj.db
cd */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data && */vcpkg-master/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake -E remove -f */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/proj.db && */vcpkg-master/installed/x64-linux/tools/sqlite3 -init */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/all.sql.in */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/proj.db .quit && */vcpkg-master/downloads/tools/cmake-3.21.1-linux/cmake-3.21.1-linux-x86_64/bin/cmake -E copy */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/proj.db */vcpkg-master/buildtrees/proj4/x64-linux-dbg/data/for_tests
SQLite header and source version mismatch
ninja: build stopped: subcommand failed.

SQLite header and source version mismatch

thanks for your comment, not working, re-installed sqlite3 to version 3.35.5 in system, still get this error message.

Can you please provide the config log config-x64-linux-dbg-out.log ?

@snakegis I have a similar problem, and it's due to linking sqlite3 as a shared library where the linker is picking the system installed one rather than the one built by vcpkg

This issue hasn’t been updated in 3 month, if it is still an issue, please reopen this issue.


Reportback ie behavior

Fixes #3699
This script provides a fallback interface for the file upload on the Reportback 2.0 when a browser does not support the File API.
The fallback interface will show a more streamlined interface (AFTER activating the input to add a photo) with the file name selected along with a link to change photo if the user would like to select a different image before submitting.

:+1: aside from the one code style comment.

Cooool! Fire away!


Never pass down state, only ids

Just thinking out loud.
One of the main things with relay (as far as I understand) is that parents do not decide what data the children need, i.e. minimal coupling.
What if we only pass down ids and parent props (no state) down to children and then each component has to build its state from the stores themselves. Gives a nice way to switch over to relay later on. Might have some performance impact.
We kind of achieve the same thing with immutable where the reference is the "id". However, it doesn't lend it self as nicely to a database backed application.

I'm doing that. https://gist.github.com/steida/1452bc7a1b0c2d6bf221#file-gistfile1-js-L32
As you can see, higher order component initiate loading when component is mounted (and clean everything when component is unmounted). You can pass props into component https://gist.github.com/steida/1452bc7a1b0c2d6bf221#file-gistfile1-js-L38 or even into parent component.


Resolve request kwargs while defining MenuItem

related to #19
I struggled also about the issue to catch the current pk attribute from the current request and pass it into the menu.
I've got the following urls.py for example:
app_name = 'structure'
urlpatterns = [
   ...
    path('groups', MrMapGroupTableView.as_view(), name='group_overview'),
    path('groups/new', NewMrMapGroup.as_view(), name='group_new'),
    path('groups/<pk>', MrMapGroupDetailView.as_view(), name='group_details'),
    path('groups/<pk>/members', MrMapGroupMembersTableView.as_view(), name='group_members'),
    path('groups/<pk>/edit', EditGroupView.as_view(), name='group_edit'),
   ...
]

How can i resolve the current requested pk from the request kwargs for example in the menus.py:

# Define children for the group menu
group_details_children = (
    MenuItem("Edit Group",
             reverse('structure:group_edit', args=pk), # pk not resolved here for now
             weight=10,
             icon="user"),
    MenuItem(_("Members"),
             reverse('structure:group_members', args=pk), # pk not resolved here for now
             weight=20,
    MenuItem(_("Publishers"),
             reverse('structure:group_publishers', args=pk), # pk not resolved here for now
             weight=30,
)

# Add a My Account item to our user menu
Menu.add_item("group_details", MenuItem(_("Details"),
                                        reverse('structure:group_details', args=pk), # pk not resolved here for now
                                        weight=10,
                                        children=group_details_children))

I made it by customizing the MenuItem class as shown in the code snippet below.
from django.http import HttpRequest
from django.urls import reverse
from menu import MenuItem, Menu
from django.utils.translation import gettext as _

def resolve_url(request: HttpRequest, view_name: str):
    return reverse(view_name, args=[request.resolver_match.kwargs.get('pk'), ])

class CustomMenuItem(MenuItem):

    def process(self, request):
        # evaluate our url
        if callable(self.url):
            self.url = self.url(request, self.view_name)
        super().process(request)

children = (
    CustomMenuItem(_("Edit Group"),
                   resolve_url,
                   weight=10,
                   view_name='structure:group_edit'),
    CustomMenuItem(_("Delete Group"),
                   resolve_url,
                   weight=20,
                   view_name='structure:group_remove',),
    CustomMenuItem(_("Members"),
                   resolve_url,
                   weight=30,
                   view_name='structure:group_members',),
    CustomMenuItem(_("Publishes for"),
                   resolve_url,
                   weight=40,
                   view_name='structure:group_publisher_overview'),
)

Menu.add_item('group_details', CustomMenuItem(_("Details"),
                                              resolve_url,
                                              weight=10,
                                              children=children,
                                              view_name='structure:group_details'))

I'm wondering about that this isn't already implemented. Maybe a PR with the enhancement of  a simple check if self.url callable would be enough to add this feature by default. Or do i misunderstood the documentation somewhere?

I tried to do something similar, and ran into the same issue that url won't accept a callable (but really should).  However, children can accept a callable which takes request, so you can just replace the tuple with a function:
def children(request):
    pk = request.resolver_match.kwargs.get('pk')
    return [
        CustomMenuItem(_("Edit Group"),
                   reverse('structure:group_edit', args=[pk]),
                   weight=10,
                   view_name='structure:group_edit'),
    ...
    ]

I think your custom class is required for callable URLs at the top of the hierarchy, though.

@timnyborg
Nice. Pretty good solution to define the children's, cause you could also drop the subclass CustomMenuItem.

I think your custom class is required for callable URLs at the top of the hierarchy, though.

Yep - Cause there is no callable check. If so, we could adapt your solution again, without defining the view_name attr.

I've adapted your code into pull request #71, which works on parent and child nodes alike.


phpmyadmin - 503 service unavailable

That's the last one to fix for now I think.

Happens quite rarely and usually becomes ready eventually.


Alert when near or at max pins

ugh I didn't mean to do that. This feature is not ready yet

I'm going to close this PR and write the feature by checking out to a new local branch.
Something is off and I don't want to mess things up.


Install steps in Nexus

How to install the plugin in Nexus?

How to install the plugin in Nexus?

In case you mean nexus repository manager - answer is "like any other public npm package".
In case I have found correct info around the internet, you should configure npm proxy for public packages in nexus and then use .npmrc file with your nexus url as registry and provide access token.
Both parts could be done on your side only.


Enabled scrolling on new container

Somehow we lost the ability to scroll on the New/Search Container page. This adds some overflow magic.
Signed-off-by: FrenchBen <me(at)frenchben.com>

@FrenchBen good catch! Thanks!


Support grouping sets parsing for GenericDialect

Part of https://github.com/apache/arrow-datafusion/issues/2469
To allow GenericDialect to parse Grouping sets.
Note that will also now parse rollup & cube as their Expr enum variant now, instead of as Expr::Function

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

4 of 4 (100.0%)  changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 86.336%

Totals

Change from base Build<PHONE_NUMBER>:
0.0%

Covered Lines:
12770

Relevant Lines:
14791

💛  - Coveralls


Add missing HTTP options to example config

Additional Notes
Also moved them below integration-specific options

Related PR https://github.com/DataDog/integrations-core/pull/4100


Auto scroll page when moving content items up and down

When I have a lot of content items, and I add a new one it goes to the bottom of the list. I have to click the little up arrow many times to get it near the top, and ever time I click the error the item jumps away and I have to scroll to find it and click again. This is very tedious.
It would be great if fluent-contents included some JS in the placeholder editor admin to auto-scroll the page so that content item being moved is still in the same position, with the same arrow button perfectly aligned under the mouse cursor, so I can just click it again :)

Fully agreed. I've been thinking about the same thing. Some nicer moving of items (like the django-admin-tools dashboard, osx dock or many other jQuery plugins provide) would be welcome.

Alternatively (or additionally), and I think FeinCMS might do this, we could show a "+" icon in between each content item, so that new content items can be inserted at a particular location instead of at the bottom of the list. The "+" icon should be small, and expand when clicked to show the select list for available content items to add.

Great addition, I'd like to have both options!


Consolidated list of platform content updates

@billhimmelsbach
I will use this issue to collect miscellaneous content changes to the platform. Some are specific changes and others are content consistency or change buckets.
Content updates
Home (unauthenticated)

[x] https://github.com/cfpb/sbl-frontend/issues/1057
Update text to:
Confirm that your financial institution has a Legal Entity Identifier (LEI)
In order to begin using the platform you must have an LEI for your financial institution. If your organization does not have an LEI, visit the Global LEI Foundation (GLEIF) to get an LEI.

Home (authenticated)

[x] https://github.com/cfpb/sbl-frontend/issues/1058
Update text block to:
You are required to provide certain identifying information about your associated financial institutions as part of your filing. Follow the link(s) below to view or update your financial institution profile(s).

Complete your user profile (email domain match)

[x] https://github.com/cfpb/sbl-frontend/issues/1059

Change section heading to:
Select the financial institution(s) for which you are authorized to file

Change text in gray well to:
We can associate your user profile with the following financial institution(s). Only select the financial institution(s) for which you are authorized to file.

Higher level of effort content work (will require some auditing and additional thinking)
Conditional language for one or many

[x] https://github.com/cfpb/sbl-project/issues/301
Currently we are using "(s)" to capture one or many. There has been talk of instead having content be conditional based on whether there are one or many things being referenced.
Appears in the context of "associated financial institution(s)," for example.

Replace instances of "click" or "check" with more inclusive language

[x] https://github.com/cfpb/sbl-project/issues/299

To complete your filing, check the box and submit your filing

Check the box to confirm that the information is accurate and complete.

Write guidelines for spelling out acronyms

[x] https://github.com/cfpb/sbl-project/issues/300
Standard CFPB approach: Spell out the full name and put the acronym in parenthesis on first mention

For example: Legal Entity Identifier (LEI) -- first mention; LEI second mention

I want to create an exception to the rule for acronyms that may be less well-known to users, for example LOU, where we spell them out in the form context so that they don't have to go looking to the beginning of a form for the spelled out name.
Identify which terminology/acronyms would need this special treatment

Acronyms currently used in the platform: LEI, GLEIF, RSSD-ID, TIN, LOU, CFPB

I have mapped all of these updates to story or frontend task issues so I am closing this issue.


redirect 4 files from tutorial to KB

What

move 4 files from tutorial to KB

Why

Dev Portal maintenance

Refs

(optional: include links to other issues, PRs, tickets, etc)

Can't see any changes to the left nav and index file in the KB section

Replaced by #810


usage example

Hi,
Can you provide a usage example? thanks

Thank you for your reply. I’m just getting started and still need to learn.