Proxy support

Pull Request Template
Description
Proxies are now supported for scraping the job websites.
The most important change is that all JobFunnel objects do now have a session member s. Therefore, all scrapings for a provider is done within one requests.Session.
Furthermore, I added an optional proxy configuration to the settings.yaml. Unlike all other settings, the proxy settings can be commented out.
Context of change
Please add options that are relevant and mark any boxes that apply.

[x] Software (software that runs on the PC)
[ ] Library (library that runs on the PC)
[ ] Tool (tool that assists coding development)
[ ] Other

Type of change
Please mark any boxes that apply.

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] This change requires a documentation update

How Has This Been Tested?
Running the jobfunnel without a proxy works as expected.
Checklist:
Please mark any boxes that have been completed.

[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[ ] I have made corresponding changes to the documentation.
[x] My changes generate no new warnings.
[ ] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[ ] Any dependent changes have been merged and published in downstream modules.

Resolved the minor issues. I also added unit tests for the url tools. Now that I'm thinking about it I think it's a good idea to check the config dictionary after the argparse. I will create an issue for this.


How to recognize user by Authorize token

Thank you for reading this issue, the scenario is below.
User send a request by jwt.Token belong to Cogntio User Pool to API Gateway which is authorized but cannot recognize the request belonge to which user.
The "events.APIGatewayProxyResponse"  doesn't provide information by default like there openId, email, etc.
How could I recognize user by Authorize token?

As you know, in the payload of the AWS Lambda event there isn't much data about who exactly was trying to get some resource from your API while identifing via Authorization header. Thanks to that Lambda "acts" universally, I mean you are not obliged to use AWS Cognito service or API key. If you are using Cognito with a JWT token, in my opinion you should parse it in your lambda handler, verify it and check claims for more data. Sadly, right now I cannot provide you code snippet for easy copy&paste but I think it will be quite easy for you to develop own algorithm using https://github.com/dgrijalva/jwt-go package when you follow instruction on AWS Knowledge Center https://aws.amazon.com/premiumsupport/knowledge-center/decode-verify-cognito-json-token/
tl;dr: bolded


No Payment Callback

I have a problem with payment but I cannot identify the error that is occurring because it is not visible

I have the same problem. were you able to solve it?

check that the email used to create the preferenceId is not the same as the used to create the MarcadoPago account

I do not know why ML libraries does not show the error. As the other comment says, the most common reason for that red alert is that the email is invalid in the preference. You can report to px-android or px-ios if need more information, there is not much I can do from the flutter plugin


Wait for at least 1 replica for Deployments and Daemonsets

The wait logic for Deployments and Daemonsets subtracts their
maxUnavailable value from the amount of replicas they should
have ready. This can lead to waiting for 0 pods to be ready.
This change ensures at least 1 replica is ready, unless there
are 0 desired replicas.
Fixes #8660.
This is based on https://github.com/helm/helm/pull/8671 which
was never merged.
Signed-off-by: Chris Friesen<EMAIL_ADDRESS>
What this PR does / why we need it:
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

See https://github.com/helm/helm/pull/8671 for the original context, but basically this is a rebase of the original fix from that pull request.  I contacted Sean Eagan privately and he said that he had given up on getting it merged.

This issue is causing problems for FluxCD currently: https://github.com/fluxcd/helm-controller/issues/81

Just wondering if any of the maintainers have had a chance to look at this yet...

For those who need this PR, I think the below is the easiest way to build a custom helm binary with the version of your choice with this PR applied.
$ cat <<'EOF'
FROM golang:1.19.3 AS helm

WORKDIR /go/src

ARG HELM_VERSION=3.9.4
RUN curl -fsSL https://github.com/helm/helm/archive/refs/tags/v${HELM_VERSION}.tar.gz | tar -xz --strip-components=1

# Apply patch for PR https://github.com/helm/helm/pull/10831
RUN curl -fsSL https://github.com/helm/helm/commit/4e21723a0c1f4fcb92df40c89b9c7b36e47a15e1.patch | git apply

# Build helm
RUN make build

FROM scratch

COPY --from=helm /go/src/bin/helm /helm
EOF

$ docker buildx build . --output=.

Which after its execution will place the helm binary in your current directory.

I'm going to go ahead and close this based on the last response.


Fix missing import in the hello world example

Before submitting a pull request, please make sure the following is done:

Fork the repository and create your branch from master.

Run the build.py and test.py scripts.

If you are fixing something, add tests that fail in the current version and pass in yours.

If you're developing a new feature open an issue first to discuss it. Some features may be useful to you but harmful to others be it because of performance, new dependencies or different perspectives.

One more time: Don't forget to add tests.

Ensure the entire test suite is passing and overall performance is not degraded.

Duplicate of https://github.com/vibora-io/vibora/pull/81

Already fixed in master branch. Anyway, thanks!


mcu/nxp: Update NXP SDK and add Kinetis common HAL.

This PR comprises:

Updated NXP SDK to 2.9.0
Common HAL for Kinetis chips.
Improved GPIO driver, with interrupt support.
I2C and SPI drivers.
QSPI driver.

I'll follow up witth another PR adding K8xf support.

@mlaz I am fine with this now, please force-push again to check if not RAT issues remain, for some reason it was no updating the message.


How to select highest resolution up to 1440p with preference to VP9 over AVC and OPUS over VORBIS over AAC?

Hi!
I think I crammed everything I want to achieve into the title. Can I do this with a single command line?
Basically I want only up to 1440p because my machine tends to have trouble playing videos above.
Unfortunately VP9/opus/vorbis streams are often missing. In which case the fallback is necessary to AVC/AAC. But only when, and only for which stream is missing. And I most certainly never want VP8.
Also sometimes DASH formats are completely missing. In which case non-dash AVC formats come into play.
Also resolution is more important than format. So if for some weird reason the 1080p VP9 streams are missing AVC should be downloaded.

This is as far as I got:
youtube-dl -f "bestvideo[height<=1440,ext=webm]+bestaudio[ext=webm]/best[height<=1440]" --write-description --write-sub --write-thumbnail --embed-thumbnail --embed-subs --sub-lang en,hu --merge-output-format mkv -o "%(title)s.%(ext)s" <url>
It has several issues. Doesn't differentiate between vp9/vp8 opus/vorbis. So I don't even know what will happen, probably some cases I would get vp8, which is bad. Probably it would fall back to AVC if both the opus and vorbis streams were missing. (I don't know how likely that is)
It cannon embed the thumbnail into mkv, only mp4. But mp4 doesn't support the webm codecs as far as I know. So no thumbnail, or no vp9/opus/vorbis.
For whatever weird reason it changes the file modification date to god knows what date, certainly not the date the video was uploaded, or the date current date which I would expect. Something I certainly never configured.

-f '(bestvideo[vcodec=vp9]/bestvideo[vcodec^=avc]/bestvideo[vcodec!=vp8])[height<=1440]+(bestaudio[acodec=opus]/bestaudio[acodec=vorbis]/bestaudio[acodec^=m4a]/bestaudio)/(best[vcodec=vp9]/best[vcodec^=avc]/best[vcodec!=vp8])[height<=1440]'

Thanks!
Do you have any idea while the last modified date of the resulting file is screwed up?
For example for this video: https://www.youtube.com/watch?v=BnXXuDl30JY I get the date "2014.08.05" for unkown reasons. The date of the description or thumbnail image is not screwed up.

--no-mtime.

Thanks again!
That solves everything that seems solvable.

Can I prevent deleting stuff that were embedded? (I only want embed subs or artwork as a safety measure so that I won't loose them)

-k.

@dstftw commented on 2017. jan. 30. 18:25 CET:

-k.

Not quite what I wanted. I don't want the video, audio streams. Oh, well...

--write-thumb --write-sub --write-auto-sub.

@dstftw commented on 2017. jan. 30. 18:31 CET:

--write-thumb --write-sub --write-auto-sub.

Indeed. But if I also use "--embed-subs" the external subtitle is deleted.


fix(csp): chrome 96 regression breaks argon2

Try out this version of the Hiro Wallet - download extension builds.

Chromium v96 introduces a regression where WebWorkers are evaluated against the CSP incorrectly https://bugs.chromium.org/p/chromium/issues/detail?id=1268576. If released currently, all wallets will break.
Error [RuntimeError]: abort(CompileError: WebAssembly.instantiate(): Wasm code generation disallowed by embedder). Build with -s ASSERTIONS=1 for more info.
  at abort (chrome-extension://eecnpiikplhmnkkfjdnlmhjfhalcnohl/decryption-worker.js:18:7620)
    at chrome-extension://eecnpiikplhmnkkfjdnlmhjfhalcnohl/decryption-worker.js:18:9491

Can reproduce this installing the Chrome Beta release channel.
We can reintroduce the 'wasm-eval' rule to prevent this from happening, without any significant security concerns (we had this directive on previously, before the Worker was added).
Discovered via Playwright issue, and timely flagging by @markmhx

@kyranjamie need me to test this in my Chrome install?

I've tested already, but feel free to validate in latest dev release: https://github.com/hirosystems/stacks-wallet-web/releases/tag/v2.20.1-dev.12

Works for me 👍


Change empty list label to something more user-friendly

I agree with Mike - I assume such a test would be time consuming to write;  ow LGTM

A test for this would essentially be testing the 3rd-party component functionality: https://github.com/ericgio/react-bootstrap-typeahead/blob/6b45fbb7fc09a5694851fab616a21a023af8f399/test/utils/getAccessibilityStatusSpec.js#L16


npm installation fails

Description
Cloning the repo from Github and running:
npm i

returns this error:
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving<EMAIL_ADDRESS>npm ERR! Found<EMAIL_ADDRESS>npm ERR! node_modules/ethers
npm ERR!   dev<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   packages/protocol-kit
npm ERR<EMAIL_ADDRESS>npm ERR!     node_modules/@safe-global/protocol-kit
npm ERR!       workspace packages/protocol-kit from the root project
npm ERR!       5 more (@safe-global/account-abstraction-kit-poc, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR<EMAIL_ADDRESS>npm ERR!   dev @safe-global/safe-contracts-v1.4.1@"npm<EMAIL_ADDRESS>from<EMAIL_ADDRESS>npm ERR!   packages/protocol-kit
npm ERR<EMAIL_ADDRESS>npm ERR!     node_modules/@safe-global/protocol-kit
npm ERR!       workspace packages/protocol-kit from the root project
npm ERR!       5 more (@safe-global/account-abstraction-kit-poc, ...)
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR!
npm ERR! For a full report see:
npm ERR! /Users/<user>/.npm/_logs/2023-08-02T15_24_40_733Z-eresolve-report.txt

npm ERR! A complete log of this run can be found in: /Users/<user>/.npm/_logs/2023-08-02T15_24_40_733Z-debug-0.log

This is due to NPM v7+ installing peerDependencies by default. This is not the case with previous versions NPM
<EMAIL_ADDRESS>has a peer using ethers 5.4.0. This should be addressed there for avoiding workarounds. Anyway you can do this:

npm install --legacy-peer-deps
npm install --force

Or we can
3) Forcing resolution to 5.7.2  => @dasanra ?

I was also checking this issue. Forcing resolution to v5.7.2 won't work. Also it's probably going to add issues when we migrate to ethers v6.
Original issue here may be adding safe-contracts with all versions as dependencies of the protocol-kit when we only need the contracts for type generation. This adds plenty of dependencies that are becoming outdated to the project and will create more problems specially trying to support more than one package manager.


Flow cannot derive correct type when sole return is within infinite loop

function foo(): string {
    for (;;) {
        return "str";
    }
}

Playground link
Error
1: function foo(): string {
                   ^ string. This type is incompatible with an implicitly-returned undefined.

One workaround is to throw new Error(); at the end of the method, but then the eslint complains about unreachable code and must be suppressed. :(

I was about to report this as an error as well, but came across this as well as https://github.com/facebook/flow/issues/3793.
It's unfortunate because if you have the no-unreachable eslint rule (which does detect this correctly), you have to disable one of flow or the eslint rule to remove the errors.

Detecting, whether the loop is infinite or not is impossible in general.  To work around this limitation you can add an unreachable throw statement:
function foo(): string {
    for (;;) {
        return "str";
    }

  throw new Error;
}

@vkurchatkin Would it be reasonable for flow to detect it in the more obvious cases (like an explicitly infinite loop) as eslint does?


Error while running locally an hydrogen app for first time on Windows

What is the location of your example repository?
No response
Which package or tool is having this issue?
Hydrogen
What version of that package or tool are you using?
^2024.7.9
What version of Remix are you using?
^2.10.1
Steps to Reproduce
npm create @shopify/hydrogen@latest  => shopify hydrogen dev
Expected Behavior
server is running, on localhost:3000/
Actual Behavior
MiniOxygen: Error during evaluation: MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. There is likely additional logging output above.
at #assembleAndUpdateConfig (\node_modules\miniflare\dist\src\index.js:9842:13)
at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
at async Mutex.runWith (C:\Users\alimo\Desktop\brandjung\Stretta-Music-GmbH-frontend\node_modules\miniflare\dist\src\index.js:3627:16) {
code: 'ERR_RUNTIME_FAILURE',
cause: undefined
}

I found the issue
on windows I should update "visual studio c++ redistributable" to the newset version


Adding highlighting #if blocks

What do you want to see added to the extension?
Add highlighting #if blocks when moving the cursor (#if, #else, #elseif, #endif), because when there are many conditions, the code becomes difficult to read. And even better, automatically add #endif with a comment, where the beginning of the block will be indicated. This is in Visual Studio and I would really like to see it in your extension.

How would it help you?
This will make writing code much easier for me and many users.
How often would you use this feature?
Is always.

Good idea!

Genius!


run async serdes on thread pool thread

Consumer.Consume and Producer.BeginProduce both block on async serdes. There was a deadlock problem with the previous implementation when used in a single threaded context (WinForms, WPF, WebAPI...). This PR forces async serdes to be run on a different thread (my understanding was that the previous implementation was supposed to do this, but it doesn't). All of this is considered an anti-pattern, but it is well considered and i believe appropriate here. Note: there are only performance implications for async serdes (i.e. currently just avro, which is slow anyway), and this is of similar order to doing async 'properly'. Justification of API:
BeginProduce

There is a fully legit async-all-the-way-down alternative ProduceAsync. This is most likely what people actually want when they're writing async code.
The alternative to blocking in BeginProduce is to add a BeginProduceAsync method in addition to the BeginProduce method. We'd want both because making the method async has performance implications for the non-async serde case (vanilla BeginProduce is much faster than ProduceAsync). But:

typical usage will be to just block on the BeginProduceAsync method anyway (note: it is extremely infrequent that a call will block, as communication with schema registry is very infrequent).
so making this sync internally makes the external API simpler for typical usage.
BeginProduceAsync is going to confuse people, and increases the surface area of the API.
We can always add BeginProduceAsync later if needed.

Consume

The alternative is to add a ConsumeAsync method in addition to Consume.
But this pointless (consume blocks anyway, and the additional blocking due to communication with SR is extremely infrequent).
It's also going to confuse users - they'll think ConsumeAsync doesn't block.
In the future, we can add a fully legit ConsumeAsync method (though i don't believe this is high priority - i'm not aware of high-priority use cases).

I guess this workaround is okay for now, as long as the blocking behaviour is documented in the API docs.


Replace existing machine checker with new operator controller Machine

Which issue this PR addresses:
User Story 8749435. Removes machinechecker.go, adds a new operator controller Machine.

What this PR does / why we need it:
We need to ensure customers have at least two worker nodes (or three) to ensure that the cluster is supported,  upgrades are able to complete, and the OpenShift operators are not degraded. As detailed in the user story, the first step to this is to remove the machinechecker.go logic from the Checker controller and add it into a new controller Machine. This new checker validates VMs and outputs a status to the cluster object.
The next step will be to PR a new controller MachineSet that will scale up worker MachineSets if it detects less than a minumum of two (or three) worker nodes.

Test plan for issue:
Steps taken to test:
Ran the operator master locally with kubeconfig, and confirmed that the new controller was loaded.
Ensured that a status was outputted to the cluster object.
Ensured that the code passed make test-go.
Ran test in machine_controller_test.go.

Is there any documentation that needs to be updated for this PR?
No, however we may need to update the operator E2E tests.

The recently added azurensg operator controller adds a const.go file that is identical to the one in this PR. I believe that may be why lint is failing after rebase, but tests are passing on my end. Let me know the preferred way to resolve this.

Update the README with the new controller name and it's function.

Most recent push should have addressed all comments - let me know if there's anything else needed, or if I have missed something from the review history.

@mjudeikis and @nilsanderselde you previously requested changes here. Are you happy for this to get merged?

@cadenmarchese please address @nilsanderselde comment in separate small nit PR! Thanks!


Cannot find EAllowedDOFs::All

Hmm, I can't seem to find a corresponding All of EAllowedDOFs enum. Is it not exposed? I tried to use Jolt.All, but it seems to be something else. Should I use number 1 to represent it?

Yes this is missing indeed. Emscripten doesn't properly scope enums and the name All was already taken. I have since writing this figured out a way to deal with this so I will create a fix. In the meantime you can use the integer 31.

Hmm, setting it to 31, give give me some strange results:
https://github.com/jrouwe/JoltPhysics.js/assets/5677782/c747055e-966d-4bfa-a9c7-6cc1cfbdf591
I will better wait for your fix and skip this option for now.

v0.7.0 has the new enum value. Please note this is a breaking change, see: https://github.com/jrouwe/JoltPhysics.js/releases/tag/0.7.0

You are awesome, thank you! Since the lib is still in sub 1.0.0, I don't mind breaking changes. In fact I welcome them, as this is the best time to introduce those.


Add helpful information to the SETUP.md

The contents of the SETUP.md file gets included in
the README.md that gets delivered when a user runs the exercism fetch
command from their terminal.
At the very minimum, it should contain a link to the relevant
language-specific documentation on
help.exercism.io.
It would also be useful to explain in a generic way how to run the tests.
Remember that this file will be included with all the problems, so it gets
confusing if we refer to specific problems or files.
Some languages have very particular needs in terms of the solution: nested
directories, specific files, etc. If this is the case here, then it would be
useful to explain what is expected.

Thanks, @tejasbubane for suggesting that we add this documentation everywhere.
See exercism.io#2198.

Sounds like a good idea, you want the starting experience to be a seamless as possible.
I'll have a go at writing something unless someone else beats me to it.
What's the best way to see how the final README.md looks when running exercism fetch? I haven't really stepped outside the xerlang and xocaml repos.

There's no real easy way to do this at the moment. I tend to run a local version of the x-api server and then request the /problems/:track_id/:problem_slug endpoint. I'll try to come up with a handier way of doing that.


Product options should deal with prices differently

Hi Ryan and others,
When creating product options and setting them so that each has a different price, we end up in a strange situation.
Say I'm selling shirts and I create 2 options for size and gender.
* Size has XL, L, M, and SM as choices. Each has a different price
* Gender has 2 options F and M and each has a price
Now if I select Male and then L the price I am given is the price for Large, the gender option is not taken into account anymore. The last option selected sets the price.
Wouldn't it be better if instead of setting a price for each option, we could set an amount to add or withdraw from the original price?
Say my product price is $15 and for the size option I have
XL => +2
L => +1.5
M => +1
Also, I wouldn't remove the possibility to just set a price as it is now. I would just make the code recognize that if the amount starts with a + sign, it should be taken as an added amount.
If the amount doesn't start with a + sign, take it literally.
Same reasoning could be applied to have minus (-) amounts
When selecting different options, javascript could read the value of each available option and show the price accordingly.
When going to check out, the calculation could easily be done as well.
Do you think this is reasonable and needed?

What can I say, I talked too fast... please don't waste your time here, I'm closing


Password management in script

Hello,
I have made an automation that uses visual automation and in my script i have stored the credentials for loging in the application. what would be the best approach to mitigate this?
Thanks

Hi Alket, try the following google search, hopefully there is something suitable from Python ecosystem for your use case -
python password management
python credentials management


Fix missing libyaml-0.so.2

Seems that ver. 0.2 of yaml package doesn't contains an symbolic link for libyaml-0.so.2. And uwsgi doesn't work without this DLL.
Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

Related issue on yaml-feedstock: conda-forge/yaml-feedstock#13

@conda-forge-admin, please rerender

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Let's try to fix https://github.com/conda-forge/yaml-feedstock/issues/13 instead. I misread the problem as an ABI conflict but it is just a missing symlink (like you described in the issue).


Use FlashCat's personal access token for pushing docs

Instead of using my (or @Gankro's) personal access token as the value of the GH_TOKEN environment variable on Travis CI, we should create one from @FlashCat's GitHub account. This will limit the consequences of the token being compromised.
Whoever has FlashCat's GitHub credentials should do the following:

Log in to GitHub as FlashCat, and create a new personal access token with only the public_repo permission.
Copy the token to the clipboard.
Delete the current GH_TOKEN environment variable by visiting https://travis-ci.org/contain-rs/compare/settings/env_vars.
Re-create the GH_TOKEN environment variable with the token that was copied, ensuring that the "Display value in build logs" settings is "OFF" (which it is by default).
Repeat for each of the other contain-rs repos.

Done

Just making sure: This has been done for all the repos? (So I can delete the tokens I created with my account.)

Everything but admin and rust-highfive

Awesome, thanks!


Add SvelteKit preset to the Static Web App create flow

Is your feature request related to a problem? Please describe.
When creating a Static Web App via the VS Code extension, I have to choose "Custom" when building a SvelteKit app and enter the following settings:

property
value

app_location
./

api_location
build/server

output_location
build/static

Describe the solution you'd like
SvelteKit is listed as a preconfigured build preset:

Describe alternatives you've considered
Continue to use the "Custom" option.
Additional context
I maintain the SvelteKit adapter for Azure SWA. Currently, I need to specify the build configuration in my project's README. I've had issues raised in the past where people have configured this incorrectly.
It would be great if SvelteKit could be a preset instead, so it is more likely to be set up properly. SvelteKit supports zero-config deployments to Azure SWA, so if you can create a SWA with a SvelteKit preset, no other setup will be needed.

Thanks geoffrich, I've added this ask to the vscode extension backlog

This has been completed by the VSCode extension team 🎉 https://github.com/microsoft/vscode-azurestaticwebapps/issues/789


Feature Request: Navigation (Scene) hotpoints that can be applied into a floorplan

Love the navigation, was wondering if it was possible to add a feature where you could put the hotspots to the scene also outside the pano display block, like a floor plan?

Ok, I'll try those options, seems a way to do it.

Ok, I was able to do a imgmap, and then on the areas use the api (loadScene) as an onclick call for each map to make it change, it's working precisely as I would want it to!


JSON.stringify on computed gives error about cyclic value

Version
3.2.31
Reproduction link
sfc.vuejs.org/
Steps to reproduce
Call JSON.stringify on any computed (without .value)
What is expected?
Not actually sure if this should be expected to work or not ...
What is actually happening?
You get "TypeError: cyclic object value" (Firefox)/"TypeError: Converting circular structure to JSON" (Chrome)

Seems similar to https://github.com/vuejs/core/issues/1916, but affects recent Chrome/Firefox on PC

Yeah well, it's never a good idea to pass a complex/stateful object to stringify.
I would not cosndier this a bug. You want to stringify the value, not the computed itself.


Serializers improvements and refactoring

Add Frontmatter serializer with hybrid header, like JSON, YAML and others.
Add serializers settings under flextype settings instead of defining them inside encode and decode methods.
Research and add other serializers: Neon, PHPArray.

New settings added:
# Serializers
#
# json.decode.cache: Cache result data or no. Default is true.
# json.decode.assoc: Decode assoc. When TRUE, returned objects will be converted into associative arrays.
# json.decode.depth: Decode Depth. Set the maximum depth. Must be greater than zero.
# json.decode.flags: Bitmask consisting of decode options.
# json.encode.options: Bitmask consisting of encode options
# json.encode.depth: Encode Depth. Set the maximum depth. Must be greater than zero.
#
# yaml.decode.cache: Cache result data or no. Default is true.
# yaml.decode.native: Use native php pecl parser or symfony parser.
# yaml.decode.flags: A bit field of DUMP_* constants to customize the dumped YAML string.
# yaml.encode.inline: The level where you switch to inline YAML.
# yaml.encode.indent: The amount of spaces to use for indentation of nested nodes.
# yaml.encode.flags: A bit field of DUMP_* constants to customize the dumped YAML string.
#
# frontmatter.decode.cache: Cache result data or no. Default is true.
# frontmatter.decode.header_serializer: Header serializer.
# frontmatter.encode.header_serializer: Header serializer.
#
# neon.decode.cache: Cache result data or no. Default is true.
# neon.encode.flags: The flag can be 1, which will create multiline output.
serializers:
  json:
    decode:
      cache: true
      assoc: true
      depth: 512
      flags: 0
    encode:
      options: 0
      depth: 512
  yaml:
    decode:
      cache: true
      native: true
      flags: 0
    encode:
      inline: 5
      indent: 2
      flags: 0
  frontmatter:
    decode:
      cache: true
      header:
        serializer: yaml
        allowed: ['yaml', 'json', 'neon']
    encode:
      header:
        serializer: yaml
        allowed: ['yaml', 'json', 'neon']
  neon:
    decode:
      cache: true
    encode:
      flags: 1


Updating backend api chapters with mocks/ directory instructions.

Updating as mentioned from https://github.com/AnomalyInnovations/serverless-stack-com/issues/25

Thanks for putting it together @ryanjcruz. Appreciate the contribution. I'll update the backend source and merge this in soon.

No probs @jayair happy to contribute. Enjoying your tutorial btw!

Merged 2e53ff7d36e4c2709f83b576144d4434d5c1edbc


How to Compile the project(0.154) in windows 10

I wanna use it on my Company,but I can not Complie it in windows

I can't help you

This is header only project, you needn't compile it. Just include the headers in your project. The only thing you should do is compiling libuv and uSocket yourself.


[Sprint 55] [1.2.x] XD-3321 - Added property to disable hash file requirement

Added to master (1.3.x) as 631f6d56437eb5c279cda3ca19112ad1aa52670d


PHP-CS-Fixer

Add a basic .editorconfig file
Use the cache feature so that we only try to fix files that I've changed since the last fix
Ensure this .php_cs.cache files is not commited

Please squash to one commit.


Fix rpc, settlement integration tests

Can we add a description to this PR? Some thing like: "Tests of settlement was not working", or add a little desc to this?


TestRunFInishedEvent does not change stop icon to play after second iteration

Hi,
I am making below call to make testrun finish event after test execution or in cancel().
this.testStatesEmitter.fire({ type: 'finished' });
First time when I run entire suite(root), the play icon changes to stop(red coloured) and then again to play icon once execution finishes or cancelled.
But, if I execute suite(root) multiple times, then from second time the icon gets stuck in stop(red coloured) and hence I am not able to execute entire suite third time.
I am using
 "vscode-test-adapter-api": "^1.5.0", "vscode-test-adapter-util": "^0.6.3",
Do I need to make any extra emit call for marking finish of testrun properly?

It sounds like you're doing everything right. I guess that under some circumstances an event is not sent or sent twice (e.g. if you send the { type: 'finished' } event in cancel() and then send it again as a reaction to the child process exiting).

You are right @hbenl.
I was calling this.testStatesEmitter.fire({ type: 'finished' }); multiple times which was setting runningCount to negative values and then it was never going in condition where you have checked (this.runningCount===0) and hence it was not setting context value.
Thanks for your reply.


Multiple String selection bottleneck

Although perhaps uncommon to most, I use the Multiple String selection quite a bit and noticed that it can choke quite easily/quickly when the same string is used multiple times.
For example take the following CSV:
https://gist.github.com/TeckniX/ddcacc78ce235d7702c0
Trying to do a multiple string selection on , and then typing out changes will be un-bearably slow (aka lagg and app seems frozen). Using the same file, Sublime barely breaks a sweat, yet the technique is the same.

I believe this is covered by #5025. Also, we think that multi-cursor editing performance will be improved by the refactoring going on as part of #307. Thanks!


Resolve syncing conflicts from repo_sync_working_branch to public

Pull request opened by Docs to resolve syncing conflicts from repo_sync_working_branch to public.

close/reopen


fix makemigrations get_models call args

The args before was incorrect, it was interpreted as a boolean. This should use the correct method to call the models for that app.
ticket: https://code.djangoproject.com/ticket/27200

buildbot, add to whitelist.

ohhh it doesn't have any other apps in the system, I'll need to register a model with a different app. I thought the django models would have been registered.

Testing against Django installed in '/vagrant/src/django-repo/django' with up to 4 processes
Creating test database for alias 'default'...
Cloning test database for alias 'default'...
Cloning test database for alias 'default'...
Cloning test database for alias 'default'...
Creating test database for alias 'other'...
Cloning test database for alias 'other'...
Cloning test database for alias 'other'...
Cloning test database for alias 'other'...
.............F................................................
======================================================================
FAIL: test_makemigrations_consistency_checks_respect_routers (migrations.test_commands.MakeMigrationsTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib64/python3.5/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/lib64/python3.5/unittest/case.py", line 638, in run
    testMethod()
  File "/vagrant/src/django-repo/django/test/utils.py", line 378, in inner
    return func(*args, **kwargs)
  File "/vagrant/src/django-repo/tests/migrations/test_commands.py", line 656, in test_makemigrations_consistency_checks_respect_routers
    self.fail("Attempting to get model on wrong app: {}".format(e.args[0]))
  File "/usr/lib64/python3.5/unittest/case.py", line 703, in fail
    raise self.failureException(msg)
AssertionError: Attempting to get model on wrong app: App 'contenttypes' doesn't have a 'ModelWithCustomBase' model.

----------------------------------------------------------------------
Ran 62 tests in 2.066s

FAILED (failures=1)
Destroying test database for alias 'default'...
Destroying test database for alias 'default'...
Destroying test database for alias 'default'...
Destroying test database for alias 'default'...
Destroying test database for alias 'other'...
Destroying test database for alias 'other'...
Destroying test database for alias 'other'...
Destroying test database for alias 'other'...

that was pre-the fix.

There, that should do it.

I skimmed the review guidelines and I'm assuming I should sign the cla and add myself to the contributors. I'll do that within the next few days since I'll also need to get my employer to sign.

Looks good. I pushed a few cosmetic edits and squashed commits if you'd like to check it.

yup LGTM @timgraham


Signature cannot be verified for the 6.3.0 release

Steps required to reproduce the problem
phive install friendsoftwig/twigcs

Expected Result
twigcs is installed.
Actual Result
Phive 0.15.2 - Copyright (C) 2015-2023 by Arne Blankerts, Sebastian Heuer and Contributors
Downloading https://api.github.com/rate_limit
Downloading https://github.com/friendsoftwig/twigcs/releases/download/6.3.0/twigcs.phar
Downloading https://github.com/friendsoftwig/twigcs/releases/download/6.3.0/twigcs.phar.asc
Downloading key C00543248C87FB13
Trying to connect to keys.openpgp.org (<IP_ADDRESS>)
Downloading https://keys.openpgp.org/pks/lookup?op=get&options=mr&search=0xC00543248C87FB13
Successfully downloaded key.

        Fingerprint: 0FDE 18AE 1D09 E19F 60F6 B1CB C005 4324 8C87 FB13

        Andreas Möller<EMAIL_ADDRESS>
        Created: 2019-12-25

Import this key? [y|N] y
[ERROR]    Signature could not be verified
[ERROR]    General error

I have uploaded updated release assets, @jakzal - can you confirm that it works now?
Running
phive install friendsoftwig/twigcs

yields
Phive 0.15.2 - Copyright (C) 2015-2023 by Arne Blankerts, Sebastian Heuer and Contributors
Downloading https://api.github.com/rate_limit
Downloading https://github.com/friendsoftwig/twigcs/releases/download/6.3.0/twigcs.phar
Downloading https://github.com/friendsoftwig/twigcs/releases/download/6.3.0/twigcs.phar.asc
Downloading key C00543248C87FB13
Trying to connect to keys.openpgp.org (<IP_ADDRESS>)
Downloading https://keys.openpgp.org/pks/lookup?op=get&options=mr&search=0xC00543248C87FB13
Successfully downloaded key.

	Fingerprint: 0FDE 18AE 1D09 E19F 60F6 B1CB C005 4324 8C87 FB13

	Andreas Möller<EMAIL_ADDRESS>
	Created: 2019-12-25

Import this key? [y|N] y
Linking /Users/am/.phive/phars/friendsoftwig/twigcs-6.3.0.phar to /Users/am/Sites/friendsoftwig/twigcs/tools/twigcs

for me now.


drive ISA to power up calculator sometimes does not work

When using the command system poweron to momentarily drive ISA the calculator does not always start.

Will be investigated, but low priority, this is not yet used for any functions in the TULIP


merge from arlac77/npm-package-template

package.json

chore(package): add ^7.1.1 remove ^7.1.0 (devDependencies.@rollup/plugin-node-resolve)

.gitignore

chore(git): merge from template .gitignore

:tada: This PR is included in version 2.1.14 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Python security 1.23.1 - Pycharm 2021.1 - Incompatible requires IDE BUILD 203.* or older

Summary: ubyntu 20.4.2 LTS - Pycharm 2021.1 - Python security 1.23.1 - Incompatible requires IDE BUILD 203.* or older

to reproduce:

updated Pycharm
received plugin error

observation

Changes in Pycharm often break Plugins
Python security 1.23.1 is broken on Pycharm 2021.1

further details on Pycharm affected

PyCharm 2021.1 (Professional Edition)
Build #PY-211.6693.115, built on April 6, 2021
Runtime version: 11.0.10+9-b1341.35 amd64
VM: Dynamic Code Evolution 64-Bit Server VM by JetBrains s.r.o.
Linux 5.4.0-70-generic
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Non-Bundled Plugins: com.intellij.javafx (1.0.3), R4Intellij (211.6693.2), com.intellij.bigdatatools (0.5.44)
Current Desktop: ubuntu:GNOME

intent: sharing this information

Same with Intellij 2021.1

I just shipped a release with 211.* support. IT should be in the plugin store shortly.

Hi @tonybaloney,
You fixed it.
Thank you.
Regards Bart,


Unable to start sickrage

Hi,
Im running SickRage, but now im not able to run the application anymore.
Im running it on a fully updated Synology NAS.
Is this due to the DMCA?
It doesnt state anything in the log available through the Synology NAS gui.
Thanks in advance
Sent from my OnePlus ONEPLUS A3003 using FastHub

Setup
Package Name:
Package Version:
_NAS Model: Synology DS1515+
_NAS Architecture: x86
_DSM version: DSM 6.1.3-15152 Update 1
Expected behavior
Application should start
Actual behavior
Application wont start, fails with "Failed to run the package service"
Steps to reproduce
_1. Start application from Package Center
Package log
Check Package Center or /usr/local/{package}/var/
Insert the package log here
Nothing valuable, just searches for episodes (old logs)
Other logs
E.g. /var/log/messages or /var/log/synopkg.log
Insert log here
2017/07/25 20:53:59 start sickbeard-custom: begin to start version 20151220-4
2017/07/25 20:53:59 start sickbeard-custom 20151220-4 Begin pre-load apparmor
2017/07/25 20:53:59 start sickbeard-custom 20151220-4 End pre-load apparmor ret=[0]
2017/07/25 20:53:59 start sickbeard-custom 20151220-4 Begin start-stop-status start
Starting SickBeard Custom ...
Traceback (most recent call last):
File "/usr/local/sickbeard-custom/var/SickBeard/SickBeard.py", line 548, in
SickRage().start()
File "/usr/local/sickbeard-custom/var/SickBeard/SickBeard.py", line 247, in start
sickbeard.CFG = ConfigObj(sickbeard.CONFIG_FILE, encoding='UTF-8')
File "/usr/local/sickbeard-custom/var/SickBeard/lib/configobj.py", line 1219, in init
self._load(infile, configspec)
File "/usr/local/sickbeard-custom/var/SickBeard/lib/configobj.py", line 1302, in _load
raise error
configobj.ConfigObjError: Parsing failed with several errors.
First error at line 1051.
2017/07/25 20:54:04 start sickbeard-custom 20151220-4 End start-stop-status start ret=[1]
2017/07/25 20:54:04 (system) trigger sickbeard-custom 20151220-4 Begin start-stop-status stop
SickBeard Custom is not running
2017/07/25 20:54:04 (system) trigger sickbeard-custom 20151220-4 End start-stop-status stop ret=[0]
2017/07/25 20:54:04 (system) trigger sickbeard-custom 20151220-4 Begin unload apparmor
2017/07/25 20:54:04 (system) trigger sickbeard-custom 20151220-4 End unload apparmor ret=[0]
2017/07/25 20:54:05 stop sickbeard-custom: begin to stop version 20151220-4
2017/07/25 20:54:05 stop sickbeard-custom: stop version 20151220-4 successfully, result 0
2017/07/25 20:54:05 start sickbeard-custom: start version 20151220-4 failed, result 1

Issue resolved.


🔧 Update Stylelint Rules

After updating the dependencies, Stylelint began to mark some rules as deprecated.
Deprecation warnings:

The "block-opening-brace-space-before" rule is deprecated.
The "color-hex-case" rule is deprecated.
The "declaration-block-semicolon-newline-after" rule is deprecated.
The "declaration-block-trailing-semicolon" rule is deprecated.
The "declaration-colon-space-after" rule is deprecated.
The "declaration-colon-space-before" rule is deprecated.
The "function-comma-space-after" rule is deprecated.
The "number-leading-zero" rule is deprecated.
The "selector-combinator-space-after" rule is deprecated.
The "selector-combinator-space-before" rule is deprecated.
The "selector-list-comma-newline-after" rule is deprecated.
The "string-quotes" rule is deprecated.
The "indentation" rule is deprecated.

We need to get rid of these warnings.

This problem occurred on new versions of dependencies. We rolled them back because there were problems with them. Now this problem does not exist.


Handle github and manifest data fetch

Description
Relates to https://github.com/chanzuckerberg/napari-hub/issues/861
Depends on: https://github.com/chanzuckerberg/napari-hub/pull/1062
Changes introduced:

Creates metadata json from github and pypi data if it does not already exist
Invokes plugin lambda if distribution data does not already exist

Changes from this PR have been merged into the main as a part of https://github.com/chanzuckerberg/napari-hub/pull/1108


pub should have additional verbosity levels to show only warnings/errors

This issue was originally filed by @zoechi

What steps will clearly show the issue / need for enhancement?
1.
especially pub serve produces too much log output
for example the logging of each GET request
Build errors and warnings scroll out of view almost immediately because of a bunch of following log messages and it's also hard to see the warnings/errors between the log messages when scrolling back.
2.
3.
What is the current output?
What would you like to see instead?
pub should have additional log levels

warn: show only warnings and errors
error: show only errors

What version of the product are you using? On what operating system?
Dart VM version: 1.6.0-edge.39490 (Fri Aug 22 04:32:33 2014) on "linux_x64"
Please provide any additional information below.
see also the discussion here https://code.google.com/p/dart/issues/detail?id=20118
It also should be considered changing the log level for the get requests log output.
It might be helpful to see some normal log messages that show that pub (serve) is working and some progress messages (build succeeded, ...)
This way keeping the default log level would only print a reasonable amount of log output. For specific debugging purposes it is always possible to increase the log level.

This issue has been moved to dart-lang/pub#1109.


[UT] moving test cases to specific files to avoid the too long file

https://rbcommons.com/s/OpenH264/r/1415/

42ac53b -- https://rbcommons.com/s/OpenH264/r/1430/
420778f -- https://rbcommons.com/s/OpenH264/r/1431/


No warning about change in behavior within the virtualenv segment

I noticed while testing #119 that the virtualenv segment seems to be broken.  I tried it against master and next, with master working fine but next being broken.
Never mind: it seems that instead of being broken, the condition changed.  While it used to check to see if $VIRTUAL_ENV_DISABLE_PROMPT was set, it now checks to see if it is not set to true before rendering the segment, and only renders it if is it not true.  There doesn't seem to be any documentation about the change, so this might confuse people that upgrade (like me).

Nevermind: it seems that instead of being broken, the condition changed.  While it used to check to see if $VIRTUAL_ENV_DISABLE_PROMPT was set, it now checks to see if it is not set to true before rendering the segment, and only renders it if is it not true.  There doesn't seem to be any documentation about the change, so this might confuse people that upgrade.

I think we need a changelog..
Sorry for the inconvenience. :(

A changelog would really be perfect.  Since the dev flow nowadays seems to be merging a bunch of things into next and then from there into master it would be great if that commit got tagged as a release, where you can add notes about changes in there.

A CHANGELOG is now part of the project. Thanks, guys!

:tada:


eclint: 0.3.4 -> 0.3.6

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/eclint/versions.
meta.description for eclint is: "EditorConfig linter written in Go"
meta.homepage for eclint is: "https://gitlab.com/greut/eclint"
meta.changelog for eclint is: ""
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.5 in filename of file in /nix/store/5rbg4yfbi3vg8izar79dhalaizmk710b-eclint-0.3.5

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
eclint

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/5rbg4yfbi3vg8izar79dhalaizmk710b-eclint-0.3.5 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A eclint https://github.com/r-ryantm/nixpkgs/archive/c2d609df266bcb642b9cf2d99475de4010ecd0c6.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/5rbg4yfbi3vg8izar79dhalaizmk710b-eclint-0.3.5
ls -la /nix/store/5rbg4yfbi3vg8izar79dhalaizmk710b-eclint-0.3.5/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

eclint

Maintainer pings
cc @lucperkins for testing.

Result of nixpkgs-review pr 189068 run on x86_64-linux 1

1 package built:

eclint

Version is wrong:

No version test.

@lucperkins Can you fix it?

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/eclint/versions.
meta.description for eclint is: "EditorConfig linter written in Go"
meta.homepage for eclint is: "https://gitlab.com/greut/eclint"
meta.changelog for eclint is: ""
Updates performed

Golang update

To inspect upstream changes
Impact

Checks done (click to expand)

built on NixOS
The tests defined in passthru.tests, if any, passed
found 0.3.6 in filename of file in /nix/store/47fjxism47f3k5w79nymhb1iy34z0hqx-eclint-0.3.6

Rebuild report (if merged into master) (click to expand)

1 total rebuild path(s)

1 package rebuild(s)

First fifty rebuilds by attrpath
eclint

Instructions to test this update (click to expand)

Either download from Cachix:
nix-store -r /nix/store/47fjxism47f3k5w79nymhb1iy34z0hqx-eclint-0.3.6 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.
Or, build yourself:
nix-build -A eclint https://github.com/r-ryantm/nixpkgs/archive/ee77645fff3be43d97d0416afde148944f845932.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:
ls -la /nix/store/47fjxism47f3k5w79nymhb1iy34z0hqx-eclint-0.3.6
ls -la /nix/store/47fjxism47f3k5w79nymhb1iy34z0hqx-eclint-0.3.6/bin

Pre-merge build results
We have automatically built all packages that will get rebuilt due to
this change.
This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.
Result of nixpkgs-review run on x86_64-linux 1

1 package built:

eclint

Maintainer pings
cc @lucperkins for testing.

Result of nixpkgs-review pr 189068 run on x86_64-linux 1

1 package built:

eclint


Adding paths without including the root folder

Hi there,
I really like your plugin!  Thanks for your great work.
However, I have an issue I can't figure out, hoping you can help, please.
Our project structure has nested projects, something like:
- main project root folder
    - app
    - lib
    - test
    - nested project 1 root
       - src
       - test
    - nested project 2 root
       - src
       - test

I'd like to be able to insert paths from folders under the main project root, & subfolders of the nested projects -- but without including the relevant root folder.
e.g.  I want to insert a path selectors/someFile (note no leading slash or dot) where selectors lives under nested project 1 root/src.
To do this, I've been trying to create multiple root folders (for main root & nested roots), but they seem need a name or something to trigger them:
"path-autocomplete.pathMappings": {
    "$root": "${workspace}/src",
    "/z": "${workspace}/nested1/src",
    "/w": "${workspace}/nested2/src"
}

with this I can type /z/selectors/someFile & it's auto-completed, however /z/ remains.
I've tried using transformations to then remove the /z/ but it doesn't work:
"path-autocomplete.transformations": [{
    "type": "replace",
    "parameters": ["\/z\/", ""]
}

The only other thing I can think of is to add explicit path mappings for every subfolder of each src -- but there are heaps of them, & we have duplicate folder names across projects, so I'd need to differentiate them somehow..  which all seems a bit hard.
Suspect I'm doing something wrong?  Any help appreciated, thank you!
Karen

Path autocomplete provides information only from 1 folder at the time.
The transformations only apply to the newly inserted characters (file or folder name). That /z needs to remain in the path otherwise it won't be able to build the full path.
If I understand this correctly you are looking for is the possibility to combine multiple root folders ?
something like:
"$root": ["${workspace}/p1/src", ""${workspace}/p2/src""]

And then when you type data/ it should search for the data/ path in both p1/src and p2/src.
Is that correct ?

Support for this has been added in 1.10.0.
Please try it out and let me know if it addressed your use case


e2e: Add test for invalid ip as control plane endpoint

Description of changes:
Adds an e2e test for an invalid IP as the control plane endpoint
Testing performed:
When the specified resource does not exist
  Should fail due to the public IP can not be found
  /home/djumani/lab/capi/test/e2e/invalid_resource.go:103
STEP: Creating a namespace for hosting the "invalid-resource" test spec
INFO: Creating namespace invalid-resource-jhnl3a
INFO: Creating event watcher for namespace "invalid-resource-jhnl3a"
STEP: Configuring a cluster
INFO: clusterctl config cluster invalid-resource-0acsir --infrastructure (default) --kubernetes-version v1.23.3 --control-plane-machine-count 1 --worker-machine-count 1 --flavor invalid-public-ip
STEP: Applying...
kubeadmconfigtemplate.bootstrap.cluster.x-k8s.io/invalid-resource-0acsir-md-0 created
cluster.cluster.x-k8s.io/invalid-resource-0acsir created
machinedeployment.cluster.x-k8s.io/invalid-resource-0acsir-md-0 created
kubeadmcontrolplane.controlplane.cluster.x-k8s.io/invalid-resource-0acsir-control-plane created
cloudstackcluster.infrastructure.cluster.x-k8s.io/invalid-resource-0acsir created
cloudstackmachinetemplate.infrastructure.cluster.x-k8s.io/invalid-resource-0acsir-control-plane created
cloudstackmachinetemplate.infrastructure.cluster.x-k8s.io/invalid-resource-0acsir-md-0 created

STEP: Waiting for "no public addresses found in available networks" error to occur
STEP: Found "no public addresses found in available networks" error
STEP: PASSED!
STEP: Dumping logs from the "invalid-resource-0acsir" workload cluster
Failed to get logs for machine invalid-resource-0acsir-md-0-5f4956b6f4-hh458, cluster invalid-resource-jhnl3a/invalid-resource-0acsir: error creating container exec: Error response from daemon: No such container: invalid-resource-0acsir-md-0-5f4956b6f4-hh458
STEP: Dumping all the Cluster API resources in the "invalid-resource-jhnl3a" namespace
STEP: Deleting cluster invalid-resource-jhnl3a/invalid-resource-0acsir
STEP: Deleting cluster invalid-resource-0acsir
INFO: Waiting for the Cluster invalid-resource-jhnl3a/invalid-resource-0acsir to be deleted
STEP: Waiting for cluster invalid-resource-0acsir to be deleted
STEP: Deleting namespace used for hosting the "invalid-resource" test spec
INFO: Deleting namespace invalid-resource-jhnl3a

• [SLOW TEST:21.420 seconds]
When the specified resource does not exist
/home/djumani/lab/capi/test/e2e/invalid_resource_test.go:27
  Should fail due to the public IP can not be found
  /home/djumani/lab/capi/test/e2e/invalid_resource.go:103
------------------------------
------------------------------
STEP: Dumping logs from the bootstrap cluster
Failed to get logs for the bootstrap cluster node capi-test-control-plane: exit status 2
STEP: Tearing down the management cluster

JUnit report was created: /home/djumani/lab/capi/_artifacts/junit.e2e_suite.1.xml

Ran 1 of 1 Specs in 90.893 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
PASS

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Codecov Report

Merging #140 (08b827b) into main (99cda28) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #140   +/-   ##
=======================================
  Coverage   28.87%   28.87%
=======================================
  Files          27       27
  Lines        2248     2248
=======================================
  Hits          649      649
  Misses       1521     1521
  Partials       78       78

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cda28...08b827b. Read the comment docs.

/approved

/lgtm

/retest

/test

Just going to manually merge since the jobs won't remove themselves...

Fixed the issue. Can you pl have a look @rejoshed

/lgtm
It just passed for me locally.


Move CSV Asset Importer to use MCP

awwwwww yeah.  But by the time you do that it's virtually the same as the asset ingestor example.  Almost.  (except CSV import is better-tested)

That is the major difference between the two, yes.  But isn't it possible to run CSV without any metadata being imported?

Sure - but why would you do that! :)

+1 to this marriage, though retaining CSV Importer pre-import parameters & features is key!
I'm currently working with a 6.0 customer that heavily depends upon CSV Importer for ongoing consolidation from several legacy DAM(-like) systems into AEM (across many business units). The ability to define the incoming assets' metadata -- using, specifically, Excel (for its familiarity and ease of use for biz users) -- is pretty much required at this point. We are in the process of planning a 6.3 upgrade, so now I'm stoked about the possibility of this feature request materializing!

This was implemented via URL Asset Import earlier this year.

We should review(close as needed) the functionality gap, and then deprecate CSV Asset Importer.
It would be good to support the CSV header format as well (especially since it follows the products metadata import/export format)


Error with NERDTreeMinimalMenu=1

Self-Diagnosis

[x] I have searched the issues for an answer to my question.
[x] I have reviewed the NERDTree documentation. :h NERDTree
[x] I have reviewed the Wiki.
[x] I have searched the web for an answer to my question.

Environment (for bug reports)

[x] Operating System: MacOS 10.15.2
[x] Vim/Neovim version :echo v:version: NeoVim v0.4.3
[x] NERDTree version, found on 1st line in NERDTree quickhelp ?:  6.4.2
[x] vimrc settings

[x] NERDTree variables

let NERDTreeShowHidden=1
let NERDTreeMinimalUI=1
let NERDTreeCascadeSingleChildDir=0
autocmd StdinReadPre * let s:std_in=1
autocmd VimEnter * if argc() == 1 && isdirectory(argv()[0]) && !exists("s:std_in") | exe 'NERDTree' argv()[0] | wincmd p | ene | exe 'cd '.argv()[0] | endif
autocmd BufWinEnter * NERDTreeMirror

Other NERDTree-dependent Plugins

[x] ryanoasis/vim-devicons
[x] Xuyuanp/nerdtree-git-plugin

Steps to Reproduce the Issue

Open a directory in vim
Set :let NERDTreeMinimalMenu=1
Execute :NERDTreeToggle

Current Result (Include screenshots where appropriate.)
Error detected while processing function nerdtree#ui_glue#invokeKeyMap[1]..78[33]..77[3]..<SNR>41_showMenu[2]..51[13]..52:
line    5:
E54: Unmatched \(
Error detected while processing function nerdtree#ui_glue#invokeKeyMap[1]..78[33]..77:
line    3:
E171: Missing :endif
Error detected while processing function nerdtree#ui_glue#invokeKeyMap[1]..78:
line   33:
E171: Missing :endif

Expected Result
Should not throw any errors.
It works fine if I set  NERDTreeMinimalMenu=0

Great! Thanks so much


FlatList inverted prop ordering of elements causes copy/paste issues

Description
When the inverted prop is applied to FlatList the elements remain in the order given and are reversed via styling rather than by reversing the order in which they are rendered. This makes it so that, for example, if react-native-web is used, when the list elements are copied, they end up pasting in reverse order.
React Native version:
0.63.3
Steps To Reproduce

Create a list using FlatList
Apply the inverted prop
Note the order of some list items and copy them
Paste them and note that the order is backwards from what was displayed

Expected Results
I would expect that when pasted the list would retain the order that is shown on the screen.
Snack, code example, screenshot, or link to a repository:
https://codesandbox.io/s/cold-wave-grzpj?file=/src/App.js

https://github.com/facebook/react-native/issues/30373 Linking in this other issue which is another symptom of how the inversion is carried out.

FYI a fix for this was submitted to React Native for Web by @azimgd
https://github.com/necolas/react-native-web/pull/2151
...and it looks like it should work for React Native once this associated bug is also fixed.
https://github.com/facebook/yoga/issues/866#issuecomment-797548962


Add Feature: Sprite cloning

mySprite.clone()
//returns the cloned sprite's Sprite object

Clone should work by copying mySprite into a new variable, then setting its .element property to a DOM element clone of mySprite.element

Seems simple enough. What should the clone be called? Should that be a parameter in the function? Something like
mySprite.clone("myNewSprite") // Copies sprite and names it "myNewSprite"

And if the parameter isn't filled, it will set the name to mySprite1 or something.

What do you mean by "what should it be called"?
Sprites don't really have names, they just have optional variables
Technically, this works perfectly fine
whenPageLoads {
    new Sprite(0, 0, "spriteImage.png")
}

ok


Populate static content in raw data store

As a developer I want to retire WP and create a sustainable way to store and retrieve static content
Static content and platform pages need to be processed into the appropriate files in the git data repo.
####### ACCEPTANCE CRITERIA #######

[x] Static content create and place into template
[x] platform pages have been fit into the two sections of the platform_web workbook
[x] all images are in web folder
[x] loader tsv is retired
[x] provider_name, provider_abbreviation and project are removed from metadata.xlsx workbooks

[] ./CRL
[] ./IRCC-CRC
[] ./PPTC
[] ./NKI
[] ./UOC-BC
[] ./JAX
[] ./PMLB
[] ./LIH
[] ./UOM-BC
[] ./Curie-LC
[] ./IRCC-GC
[] ./PDMR
[] ./SJCRH
[] ./WUSTL
[] ./Wistar-MDAnderson-Penn
[] ./VHIO-PC
[] ./VHIO-CRC
[] ./VHIO-BC
[] ./UMCG
[] ./TRACE
[] ./MDAnderson
[] ./HCI-BCM
[] ./DFCI-CPDM
[] ./Curie-OC
[] ./Curie-BC

Dosing studies have platform pages, but they were never included in the "sampleplatform" workbooks. A decision on how these should be handled needs to be made.

These providers do no have logo images
{'CMP',
'Curie-BC',
'Curie-LC',
'Curie-OC',
'HCI-BCM',
'MDAnderson',
'WUSTL',
'Wistar-MDAnderson-Penn'}

https://app.zenhub.com/files/78657127/365ca064-92ed-4c31-a4a8-e16bc1eb6c9a/download

Static content is provided in the source.yaml, logo.png, and the molecular-metadata-platform-web.tsv sheet. The former two are placed in the web content directory of every provider ( some do not have logo's)

Jax will need to be placed on a separate ticket for correspondence

@CsabaHalmagyi done. I need to make a ticket for JAX

Done


Ending BandwidthRtc call disables onStreamAvailable on JS library

I have the following scenario in the JS library context that seems like a bug:

Start a video call using bandwidthRtc.connect().
Call flows successfully and application ends it by calling disconnect, removing the session, deleting the participants.
Start a new call by creating a new session, without refreshing the browser.
Participant joins with the same flow as in 1. OnStreamAvailable is not fired this time. We can see in the backend that the participant joins, and when it leaves. But the handler is not fired.

I'd like to know if this is a known issue and what could be a solution to it (if we refresh the browser it works).
It seems like the BandwidthRtc is not freeing the resources even though we do each time we call the view:
var bandwidthRtc = new BandwidthRtc()
Might be that the handler keeps tied to the old session.
Things I tried:

Setting bandwidthRtc.streamAvailableHandler to null when ending video assist and re registering the handler each time.
As mentioned, doing var bandwidthRtc = new BandwidthRtc() each time the view is accessed.

Only thing that fixes it is refreshing the browser.
Thoughts?

Closed as not a bug, the issue was on the other end sending an outdated session token.


UI issue in the SOAP message tracer

Type: Bug
Priority: High
Severity: Major
Release: 5.4.0
Browser: Firefox Quantum 57.0.1 (64-bit)
Steps

Go to Monitor -> Soap tracer in the management console

Issue
Overlap messages as seen in the attached screen shot

Thank you for your contribution!
We are closing this issue since it has not been prioritized for a long time. Chances are that it has already been solved in more recent versions. If not, we will be re-evaluating this when it becomes a priority.


"burmilla" user does not exist

BurmillaOS Version: (ros os version) v2.0.1 release
Where are you running BurmillaOS? (docker-machine, AWS, GCE, baremetal, etc.) Proxmox 8.1.4
Which processor architecture you are using? x86
Do you use some extra hardware? (GPU, etc)? No
Which console you use (default, ubuntu, centos, etc..) Default
Do you use some service(s) which are not enabled by default? Docker compose
Have you installed some extra tools to console? No
Do you use some other customizations? No
Please share copy of your cloud-init (remember remove all sensitive data first) Not applicable
I couldn't login via SSH after installing BurmillaOS. I followed the official instructions. After some digging around, I discovered that "burmilla user", which is mentioned in the Install to Disk instructions, doesn't exist. Logging in with "rancher" user, however, worked just fine. Is this expected?

Because of backward compatibility with RancherOS username “rancher” is used. Any references to user “burmilla” are mistakes documentation and would need to be fixed in https://github.com/burmilla/burmilla.github.io
There is also a lot of other documentation issues which are labeled here but which potentially are already closed because lack of contributors.


demo for squeeze

Hi,
I try to understand the algorithm squeeze and someone recommend your project. But I can't understand the detail of how each function works, especially the meaning of the input of def squeeze(df, attributes, delta_threshold=0.9, debug=False), line 124 in squeeze.py. Could you provide a demo in the future? Thank you.
Best,
YYL

Hi,
you can take a look at the evaluate.py file to see an example of how the algorithms are run. The data is available at https://github.com/NetManAIOps/Squeeze.
You should also note that I'm still in the process of trying to reproduce the results given in the paper. As of right now, the results of my implementation are worse (especially on the harder datasets). So please tell me if you find any inconsistencies with the paper or other issues.
Best regards

hi did the squeeze code run successfully?

Yes, it's possible to run it however, I haven't managed to replicate the results in the paper. You can see here: https://github.com/NetManAIOps/Squeeze/issues/3 for some related discussion on parameter settings and details not included in the paper itself.


Update getting started to point at a real build.

Worked for me.

Docs only, so bypassing the (queued) CI.


License updates for dependabot/github_actions/actions/cache-3

This PR was auto generated by the licensed-ci GitHub Action.
It contains updates to cached github/licensed dependency metadata to be merged into dependabot/github_actions/actions/cache-3: (branch, PR).
The licensed-ci action will add comments to this PR with the status of license checks.  Please make any changes needed to fix any status failures on this branch, then merge license updates into your branch.
If updates are unexpected, please check the github/licensed changelog for recent updates.

The licensed-ci GitHub Action updated cached license metadata based on changes to dependabot/github_actions/actions/cache-3: (branch, PR).
licensed status result: SUCCEEDED
All status checks succeeded, please merge when ready.
Checking cached dependency records for licensed
.............................
29 dependencies checked, 0 errors found.

/cc @dependabot[bot]


Could not get the autoscalig group name using the following endpoint

Hosts failed to publish metrics to correct ASG because of  error
"Could not get the autoscalig group name using the following endpoint: 'https://ec2.ap-northeast-2.amazonaws.com/"
I think the root cause is that the total retry of the EC2 agent is 1 https://github.com/awslabs/collectd-cloudwatch/blob/master/src/cloudwatch/modules/client/ec2getclient.py#L25
Probably makes sense to increase it?

Error code: "Exception: 503 Server Error: Service Unavailable for url: https://ec2.ap-northeast-2.amazonaws.com/?Action=DescribeTags&Filter.1.Name=key&Fil"

You have verified that you're instance is in fact in an ASG correct?


Channel search

Thanks for your excellent work!
I seem to only see the block search, no channel search found.

Thanks for your excellent work!
I seem to only see the block search, no channel search found.

Thanks for your attention. We will release the channel search later.

@githubgzc Hi, any updates about channel search?

@wlguan @pawopawo  If you just want to implement channel search in SPOS, then the following code from Slimmable may help.
https://github.com/JiahuiYu/slimmable_networks/blob/master/models/slimmable_ops.py
After reading these papers, I found that the way to search #channels in SPO is similar to the way in Slimmable.

@wlguan @pawopawo A snippet of representative code from Slimmable is as follows:
    def forward(self, input):
        idx = FLAGS.width_mult_list.index(self.width_mult)
        self.in_channels = self.in_channels_list[idx]
        self.out_channels = self.out_channels_list[idx]
        self.groups = self.groups_list[idx]
        weight = self.weight[:self.out_channels, :self.in_channels, :, :]
        if self.bias is not None:
            bias = self.bias[:self.out_channels]
        else:
            bias = self.bias
        y = nn.functional.conv2d(
            input, weight, bias, self.stride, self.padding,
            self.dilation, self.groups)
        return y

@githubgzc
Thanks for your excellent work! I'm very interesting in how to search channel.  When will release the channel search? looking forward your reply, Thank you!

I implement the channel search using slimmable network but found the model is difficult to converge on CIFAR100. The model I used is ResNet20.
I also train the same model on MNIST and it speed 300 epochs to make sub-network converge.
I tried batch normal calibration but find the training loss is dropping while the validtion accuracy is also dropping 😢


[#45] Implement support for fish shell

This is not totally ready for merge into master yet.
I created a pull-request to receive feedback from reviewers, as well as to encourage testers to find bugs.

Hmmm it seems string command is not available for fish versions less than 3.
Will need to find alternative.


Document: to declare the support timeline schedular

Hello, would you please provide us the .net support timeline as detail as possible.
like Ubuntu release table

Hi @cnmade
Does https://dotnet.microsoft.com/platform/support/policy/dotnet-core answer your question?

Yes, looks forward .net 6, .net 7, .net 8 road map. any detail plan for that ? i can see the table for .net 5.
and https://github.com/dotnet/core/blob/main/releases.md  these page should update the same?

Yes, looks forward .net 6, .net 7, .net 8 road map. any detail plan for that ? i can see the table for .net 5.

@richlander could you please answer this question?

Yes, the releases.md file is a good place to look. It includes .NET 6. We don't include releases we haven't started yet, which seems to match the Ubuntu table you shared.
That said, the future plan will be:

Current release (like .NET 7), supported for 18 months.
LTS release (like .NET 8), supported for 3 years.

Our plan is to continue repeating out that model forever. You could write a program that writes the rest of the table for you, as many years as you want to go out.


Bypass NeverBounce validation when page loads with a EN Session and the email field value has not changed before form submit

Many organizations use Campaign Links in their email blasts which pre-populate a supporters information into the Engaging Networks page. The user's email does not need to be revalidated with NeverBounce and we can bypass that check completely for them. If the user does change their email, then the normal NeverBounce validation behavior will begin again.

Fixed on v0.10.13


Test building code that uses BigInt math in the example subgraph

This makes sure we at least test building the changes added in graph-ts and graph-node:

https://github.com/graphprotocol/graph-ts/pull/20
https://github.com/graphprotocol/graph-node/pull/574

I'm going to be a naughty boy and merge this, so we can cut new releases for graph-ts, graph-cli and graph-node.


Proper Creative Commons attribution of cards

The EoP cards are distributed, but not attributed correctly. These images are licensed under CC-BY-3.0. A link to the license and to the author should maybe be added

On the board, we should add the following on the bottom right:
Elevation of Privilege
by
Adam Shostack (Microsoft)

is licensed under
CC-BY-3.0
.

And one should also extend the sentence in readme.md that the game was invented by Microsoft with the info that the card game is CC-BY-3.0 licensed.


nfc: nfc tag api

High level API definition for NFC Tag emulators.
This change partially covers the scope of feature request described in #5703 issue.

CC: @carlescufi, @grochu

Codecov Report

Merging #10117 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #10117   +/-   ##
=======================================
  Coverage   52.48%   52.48%
=======================================
  Files         213      213
  Lines       26135    26135
  Branches     5633     5633
=======================================
  Hits        13718    13718
  Misses      10160    10160
  Partials     2257     2257

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79e8f79...3528ee3. Read the comment docs.

@sameo FYI

Hi @sameo! Thank you for taking the time to review it.
As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

Hi @sameo! Thank you for taking the time to review it.
As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

Hi @sameo! Thank you for taking the time to review it.
As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

Hi @sameo! Thank you for taking the time to review it.
As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

Hi @sameo! Thank you for taking the time to review it.
As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

Hi @sameo! Thank you for taking the time to review it.
As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

Hi @sameo! Thank you for taking the time to review it.

Sure, anytime.

As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

Ok, so this API is basically about emulating NFC tags with Zephyr, right?
I think this should be more clearly described from the documentation itself. I don't think Zephyr as an RTOS should be limited to emulating tags, and could very well extend to tag reading/writing and even p2p (it would certainly make sense for BT handover use cases), so I'd suggest to make it clear that this is only part of a potentially larger Zephyr NFC API and that it only covers tag emulation.

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

I understand now. This API is basically loading an NDEF that the poller will read. And the poller could also write into our emulated NFC tag.
How do you specify which type of tags you want to emulate?

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

That's the idea, yes. NDEF is a more complex spec than it looks and you don't want your API callers to all have their own implementation/interpretation of the spec.

Hi @sameo! Thank you for taking the time to review it.

Sure, anytime.

As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

Ok, so this API is basically about emulating NFC tags with Zephyr, right?
I think this should be more clearly described from the documentation itself. I don't think Zephyr as an RTOS should be limited to emulating tags, and could very well extend to tag reading/writing and even p2p (it would certainly make sense for BT handover use cases), so I'd suggest to make it clear that this is only part of a potentially larger Zephyr NFC API and that it only covers tag emulation.

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

I understand now. This API is basically loading an NDEF that the poller will read. And the poller could also write into our emulated NFC tag.
How do you specify which type of tags you want to emulate?

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

That's the idea, yes. NDEF is a more complex spec than it looks and you don't want your API callers to all have their own implementation/interpretation of the spec.

Hi @sameo! Thank you for taking the time to review it.

Sure, anytime.

As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

Ok, so this API is basically about emulating NFC tags with Zephyr, right?
I think this should be more clearly described from the documentation itself. I don't think Zephyr as an RTOS should be limited to emulating tags, and could very well extend to tag reading/writing and even p2p (it would certainly make sense for BT handover use cases), so I'd suggest to make it clear that this is only part of a potentially larger Zephyr NFC API and that it only covers tag emulation.

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

I understand now. This API is basically loading an NDEF that the poller will read. And the poller could also write into our emulated NFC tag.
How do you specify which type of tags you want to emulate?

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

That's the idea, yes. NDEF is a more complex spec than it looks and you don't want your API callers to all have their own implementation/interpretation of the spec.

Hi @sameo! Thank you for taking the time to review it.

Sure, anytime.

As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

Ok, so this API is basically about emulating NFC tags with Zephyr, right?
I think this should be more clearly described from the documentation itself. I don't think Zephyr as an RTOS should be limited to emulating tags, and could very well extend to tag reading/writing and even p2p (it would certainly make sense for BT handover use cases), so I'd suggest to make it clear that this is only part of a potentially larger Zephyr NFC API and that it only covers tag emulation.

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

I understand now. This API is basically loading an NDEF that the poller will read. And the poller could also write into our emulated NFC tag.
How do you specify which type of tags you want to emulate?

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

That's the idea, yes. NDEF is a more complex spec than it looks and you don't want your API callers to all have their own implementation/interpretation of the spec.

Hi @sameo! Thank you for taking the time to review it.

Sure, anytime.

As a general note, this API proposal is only intended for NFC tags (the NFC Forum Device in Listen Mode). It means that it cannot be used with NFC pollers (the NFC Forum Device in Poll Mode).

Ok, so this API is basically about emulating NFC tags with Zephyr, right?
I think this should be more clearly described from the documentation itself. I don't think Zephyr as an RTOS should be limited to emulating tags, and could very well extend to tag reading/writing and even p2p (it would certainly make sense for BT handover use cases), so I'd suggest to make it clear that this is only part of a potentially larger Zephyr NFC API and that it only covers tag emulation.

As an application, how do I read an NFC tag? Is that handled through nfc_tag_cb_register() and then anytime a tag is detected, it gets automatically read and registered applications get notified?

How do I write an NDEF into a tag? How do I write several different ones

As I pointed out, you cannot read an NFC tag using this API - reading and writing operations can only be performed by the NFC poller.

I understand now. This API is basically loading an NDEF that the poller will read. And the poller could also write into our emulated NFC tag.
How do you specify which type of tags you want to emulate?

Do we expect application to know what an NDEF is? i.e. is this API going to be extended to provide an NDEF parsing and building API?

I imagine that we can have a separate module/library that would provide an API (i.e. ndef.h) for NDEF manipulation (building and parsing).
After receiving NDEF data in the callback (i.e. ndef_data_written()), the user could parse it at the application level using such a module.
Similarly, the user could build the NDEF message with the NDEF module and then pass the generated NDEF data to nfc_tag_setup() to start NFC tag emulation or just update the current NDEF data when the emulation is already running (nfc_tag_ndef_msg_set() function).

That's the idea, yes. NDEF is a more complex spec than it looks and you don't want your API callers to all have their own implementation/interpretation of the spec.

Yes, that's right.

I think this should be more clearly described from the documentation itself. I don't think Zephyr as an RTOS should be limited to emulating tags, and could very well extend to tag reading/writing and even p2p (it would certainly make sense for BT handover use cases), so I'd suggest to make it clear that this is only part of a potentially larger Zephyr NFC API and that it only covers tag emulation.

I defined a Doxygen group called "NFC Tag API" to indicate that the API is intended for Tag emulation only, but docs improvements are always welcome. Any particular suggestions?
I imagine that additional API for NFC poller (or p2p) can be added later on to the existing NFC API. The current API can be viewed as its Bluetooth gatt.h counterpart without the GATT Client support.

How do you specify which type of tags you want to emulate?

Hopefully, this API is generic enough to be compatible with any type of tag. When coming up with this proposal, I mostly analyzed Type 2 & 4 Tag platforms, because they are the most popular ones.
I imagine that user will choose the required tag platform via the Kconfig option, so future TxT (T2T, T4T, etc..) stack libraries need to implement this API.

stale, closing


Human APP backend - 1st milestone

Description
This PR adds the code from 1st milestone for Human App backend-for-frontend

Summary of changes

project configuration
worker signup
operator signup
worker signin

How test the changes
There are end to end tests that can be run by running yarn run test:e2e

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.3 out of 5 committers have signed the CLA.:white_check_mark: basit511:white_check_mark: portuu3:white_check_mark: leric7:x: MWBlocky:x: macnablockyYou have signed the CLA already but the status is still pending? Let us recheck it.

Is there a reason for doing 2 mappings of the DTO since the request is received until it is by passed to the Reputation Oracle? I think technically is good, but it is kind of redundant. Just wonder if it has been done for following best practices guidelines or for any other reason.

We need additional test cases apart from the positive ones currently in use. It's important to include tests for error handling as well.

@portuu3

We need additional test cases apart from the positive ones currently in use. It's important to include tests for error handling as well.

There are tests for errors in both unit and e2e layers. Can you be more specific about where you think it's not covered?

@portuu3

We need additional test cases apart from the positive ones currently in use. It's important to include tests for error handling as well.

There are tests for errors in both unit and e2e layers. Can you be more specific about where you think it's not covered?

You are right, I was looking at service level. Looks good to me