BGP metrics support

Is your feature request related to a problem? Please describe.
We use kube-vip to announce via BGP the k8s Control Plane IP.
Unfortunately, there is no metrics regarding BGP, thus we can not alert if there is an issue.
For example: a BGP connection is not established.
Describe the solution you'd like
Based on other projects that have BGP metrics, the following metrics would be required:

bgp_session_up

Metrics snippet:
bgp_session_up{} 0 <-- BGP Connection NOT established
bgp_session_up{} 1 <-- BGP Connection established

The following metrics could be interesting for other operational modes, but make no sense IMO in static install mode, since only 1 single IP can be announced.

bgp_announced_prefixes_total
bgp_pending_prefixes_total
bgp_updates_total

If it is not too complex, maybe we can implement these metrics too.
Metrics snippet:
Feedback is welcomed!

Describe alternatives you've considered
We could scrape the kube-vip logs and extract metrics, but this would make the solution more complex IMO.
Additional context
We would like to sponsor and implement this feature request, all feedback is welcomed.

Should be relatively straight forward to implement!

@thebsdbox Please let me know your opinion on this.
Also is it planned to make the peers port configurable? I wanted to include the peer address and port in the metric, but it is only available after the session is established and when I went looking for it, I found it to be hard coded.

fwiw, gobgp upstream has added metrics support here. Maybe it is possible to reuse it?

@mrueg This sounds like a nice idea.
I am currently not planning on adding more metrics, because we don't need them for ourselves currently. This is a task I would like to hand off to whoever wants to do it.
When I have some spare time, I am going to have another look at this.
The issue should stay open for someone to take it and implement @mrueg's idea or more kube-vip-custom metrics.


[TheWitcher] incorporate crit into roll and add fumble to rolltemplate

Changes / Comments
Roll20 Requests
Comments are very helpful for reviewing the code changes. Please answer the relevant questions below in your comment.

[ ] Does the pull request title have the sheet name(s)? Include each sheet name.
[ ] Is this a bug fix?
[ ] Does this add functional enhancements (new features or extending existing features) ?
[ ] Does this add or change functional aesthetics (such as layout or color scheme) ?
[ ] If changing or removing attributes, what steps have you taken, if any, to preserve player data ?
[ ] If this is a new sheet, did you follow Building Character Sheets standards ?

If you do not know English. Please leave a comment in your native language.

Character Sheet Info Roll20 Internal Use only.

@mperes if the change to translation.json is necessary please inform me

@Stexinator I believe it was something to do with changing the individual translation files. Do you remember what happened? Because (and I am not an expert), I think you just change the very base translation.json file, and the service automatically edits/changes the others. Doing it any other way causes an error/conflict.

It was merged and then reverted. So I have no clue what exactly the problem is. I still have the changes to the translation.json locally so I can re-apply them anytime.
This https://wiki.roll20.net/Character_Sheet_Translation opts for changing the translation.json, but I want to wait for clarification, due to it being in the old wiki

@Stexinator this one is good, it is fine to makes changes to the translation.json file, which is not allowed is making changes to the language files, like pt.json, en.json, etc. I am gonna merge this one. Thanks for all the work you've put into this!


Possible to use React components in chart text?

Bug or Feature Request?
Feature request, I think.
Description
Maybe this already exists or maybe it's not possible.
Allow use of react components in chart where text or html now goes. Bonus if it can call functions from the current context.
Example use 1 (pretend it's actually useful code):
var XTitle = function (title) {
  var clickHandler = function () { return true };
  return (
{title}
);
}

// ...
<XAxis.Title useReact = { true }>{ <XTitle title='My title' /> }</XAxis.Title>

Example use 2 (pretend it's actually useful code):
var PlotLineLabel = function (children) {
  var clickHandler = function () { return true };
  return ({ `I'm a ${children}` });
}

// ...
<PlotLine
  useReact = { true }
  value     = { 5 }
  label     = {{ text: <PlotLineLabel>Plot Line</PlotLineLabel> }} />

It might be possible using React Portals.
For instance, you could target the XAxis title with
ReactDOM.createPortal(

Something
,
  document.querySelector('.highcharts-xaxis .highcharts-axis-title')`
)

I think there might be some issues with rendering though, i.e. wait for Chart to render, then render custom components into created DOM elements
Needs some investigation, I'll have a think.

See suggestion here, but this is not something we plan to support going forward


Short solution needed: "Using internal redirects" (nginx)

Please help us write most modern and shortest code solution for this issue:
Using internal redirects (technology: nginx)
Fast way
Just write the code solution in the comments.
Prefered way

Create pull request with a new code file inside inbox folder.
Don't forget to use comments to make solution explained.
Link to this issue in comments of pull request.

Using internal redirects


Feature: ability to fuzzy filter options by 'required' status

It would be awesome to use fuzzy filtering on the aws cli commands to see which options are required.
For example, when running ec2 create-key-pair, the --key-name option is required.  I can filter the list of auto-completed options by typing name and getting just the --key-name option:

However, I can't fuzzy filter by using required:

This would be an awesome feature, as you could immediately know which options are required for any command you are running.

Interesting. While I don't know if we'd go for this exact implementation I do think it would be useful to make required parameters more discoverable. Marking as a feature request.


[release-1.12] Fix: make sure actors is locally hosted before executing reminder or timer

Rebase of #6960 into release-1.12
Original description:

There's currently a race condition that may cause an actor to be activated on two separate hosts when a reminder or timer is being executed.

When the placement state changes, evaluateReminders begins its loop. (Placement state changes every time a Dapr sidecar that can host actors of a given type comes online or offline)
One of the first steps it to load the list of reminders from persistent storage. This is a very costly I/O operation which can take some non-insignificant amount of time.
Now, assume that after the placement state changes, the sidecar needs to deactivate the actor "type1/id1". evaluateReminders will stop all reminders currently active on the sidecar for "type1/id1". However, this happens after the costly I/O operation.
If in the meanwhile a reminder for actor "type1/id1" reaches its execution time, that could trigger the execution of the reminder (<-nextTimer.C()) before the reminder is stopped (<-stopChannel).
This means that the reminder is executed on the current sidecar even though the actor is supposed to be running on a separate sidecar. This could cause the actor to be active in two sidecars at the same time.

The fix involves:

Changing doExecuteReminderOrTimer so it performs a lookup in the placement tables to make sure the actor is actually hosted locally before invoking it.

Actor invocation goes through a different path and was already doing that

Changing placement.LookupActor to perform retries with resiliency within the method itself. Currently resiliency is performed by the caller, which meant more duplicate code in this case.

The remaining changes are due to changes needed in unit tests

/ok-to-test

/test-sdk-all

/test-sdk-python

The failure in the E2E test, as well as the Python Workflow SDK test, seems to be due to a race condition (surprise!).

If the actors service is initialized before the app tries to connect to the WF engine, everything is fine.
On the other hand, if the app tries to connect to establish the WF engine connection, it fails.

This can be seen in the logs:

In tests that succeed, the line Actor runtime started appears before the API log for /TaskHubSidecarService/Hello. This indicates that Dapr's actor runtime enabled actors before the app tried to establish a connection to the WF engine.
In tests that fail, the opposite happen.

This race condition is not new and this PR doesn't change anything related to the order. However, it is surprising that the error didn't appear (or didn't appear frequently enough) before. It may be due to the order of goroutines changed.
I believe this issue (the race condition) should be a separate P0 issue. I can see 2 options:

Just like @JoshVanL suggested earlier today in an unrelated PR, we could delay making /healthz (or at least /healthz/outbound which the .NET SDK uses) respond with 200 until actors have been activated (or at least attempted to activate, since not all apps may want to do that)
Alternatively, we could make calls to workflow endpoints block while the actor runtime hasn't completed the initialization (either successfully or not).

I am neutral to which option to pursue. The first one is more clear-cut but potentially slows down the entire Dapr runtime even for users who don't care about actors. The second one is a bit more ad-hoc, in good and bad senses.

The failure in the E2E test, as well as the Python Workflow SDK test, seems to be due to a race condition (surprise!).

If the actors service is initialized before the app tries to connect to the WF engine, everything is fine.
On the other hand, if the app tries to connect to establish the WF engine connection, it fails.
This scenario describes that this race condition is occurring for Worflows consistently. But since this is based on actors runtime, there is a high possibility of it also occurring during actors init, create flow? Can this be reproduced in an E2E if so?
I really believe we need to have E2E/IT for these scenarios so that we do not cause regressions in later refactors of code if any.

Yes, the current problem is that the app checks for readiness by invoking /healthz/outbound, which is essentially testing that the HTTP server is ready.
But, actor readiness requires a few more things. Most notably, Dapr needs to invoke /dapr/config on the app and get a response.
The race condition happens when the app receives a positive response from /healthz (or /healthz/outbound) but Dapr hasn’t started the actors engine.
Again, I am not sure why this PR makes the race condition appear (or appear more frequently). It may be because it uses goroutines differently and so the timing changed. But nevertheless with or without this PR, there’s a race condition and the issue can happen regardless.

Yes, the current problem is that the app checks for readiness by invoking /healthz/outbound, which is essentially testing that the HTTP server is ready.
But, actor readiness requires a few more things. Most notably, Dapr needs to invoke /dapr/config on the app and get a response.
The race condition happens when the app receives a positive response from /healthz (or /healthz/outbound) but Dapr hasn’t started the actors engine.
Again, I am not sure why this PR makes the race condition appear (or appear more frequently). It may be because it uses goroutines differently and so the timing changed. But nevertheless with or without this PR, there’s a race condition and the issue can happen regardless.

I am touching the init startup to fix a race condition for service invocation: https://github.com/dapr/dapr/pull/6969

Yes, the current problem is that the app checks for readiness by invoking /healthz/outbound, which is essentially testing that the HTTP server is ready.
But, actor readiness requires a few more things. Most notably, Dapr needs to invoke /dapr/config on the app and get a response.
The race condition happens when the app receives a positive response from /healthz (or /healthz/outbound) but Dapr hasn’t started the actors engine.
Again, I am not sure why this PR makes the race condition appear (or appear more frequently). It may be because it uses goroutines differently and so the timing changed. But nevertheless with or without this PR, there’s a race condition and the issue can happen regardless.

I am touching the init startup to fix a race condition for service invocation: #6969

Based on the issue description https://github.com/dapr/dapr/issues/2918
Both initActors() and initDirectMessaging() seems to be something that should probably be done after the App is ready.
Based on the discussion in that issue, there are cases where app will load secrets, which is what MarkStatusAsOutboundReady() should ideally be used for.
Dapr is still initialising and not completely ready for outbound if the change in #6969 is merged, as in service invocation outbound calls will fail till DirectMessaging is initialised.
Maybe the naming for the MarkStatusAsOutboundReady() is misleading? As outbound for Actors based on the above conversation and for service invocation based on #6969 are not truly ready at this point.
Should the /healthz endpoint be more granular, based on building blocks? With the overall /heatlhz endpoint returning success only after all building blocks that are necessary are initialized but the individual ones returning success as soon as they are init, if they are being used by the app?

Yes, the current problem is that the app checks for readiness by invoking /healthz/outbound, which is essentially testing that the HTTP server is ready.
But, actor readiness requires a few more things. Most notably, Dapr needs to invoke /dapr/config on the app and get a response.
The race condition happens when the app receives a positive response from /healthz (or /healthz/outbound) but Dapr hasn’t started the actors engine.
Again, I am not sure why this PR makes the race condition appear (or appear more frequently). It may be because it uses goroutines differently and so the timing changed. But nevertheless with or without this PR, there’s a race condition and the issue can happen regardless.

I am touching the init startup to fix a race condition for service invocation: #6969

Based on the issue description #2918
Both initActors() and initDirectMessaging() seems to be something that should probably be done after the App is ready.
Based on the discussion in that issue, there are cases where app will load secrets, which is what MarkStatusAsOutboundReady() should ideally be used for. Dapr is still initialising and not completely ready for outbound if the change in #6969 is merged, as in service invocation outbound calls will fail till DirectMessaging is initialised.
Maybe the naming for the MarkStatusAsOutboundReady() is misleading? As outbound for Actors based on the above conversation and for service invocation based on #6969 are not truly ready at this point.
Should the /healthz endpoint be more granular, based on building blocks? With the overall /heatlhz endpoint returning success only after all building blocks that are necessary are initialized but the individual ones returning success as soon as they are init, if they are being used by the app?

I think so. See this proposal to have a /healthz sub-path only for app channel: https://github.com/dapr/dapr/issues/6976

/ok-to-test

/ok-to-test

/test-sdk-all

/ok-to-test

/ok-to-test

/test-sdk-all

/test-sdk-python

/test-sdk-java

/ok-to-test

/test-sdk-all

/test-sdk-all

/ok-to-test

Added integration test that confirms the issue is fixed. #7006 has the test but without the fix, and it fails

@JoshVanL I made the changes you requested, PTAL


docs: right menu for Getting Started & Think Qwik

What is it?

[ ] Feature / enhancement
[ ] Bug
[X] Docs / tests

Description
Fixes #2238
In the documentation, the following 3 pages do not have a menu on the right (ON THIS PAGE, MORE, Edit this page, etc):

Guides -> Overwiew
Guides -> Getting Started
Guides -> Think Qwik

After discussion, here is the solution
Use cases and why
nope
Checklist:

[X] My code follows the developer guidelines of this project
[X] I have performed a self-review of my own code
[X] I have made corresponding changes to the documentation
[ ] Added new tests to cover the fix / functionality

might need: pnpm fmt

@manucorporat Sorry, it is fixed.

Merged! thank you!


Differentiate contributors by internal vs external

@thinkingserious what so you mean by internal and external ?

Hi @rahulbajaj0509,
Internal to your organization. In our case, we would be checking if people belonged to the sendgrid team. This should be configurable.
With Best Regards,
Elmer

Hi @thinkingserious,
I want to take on this PR. Can you give more detailed requirement? My current understanding:

This is only for Github repo.
There should be a config in config.yml to choose whether to differentiate by internal vs external or not.
If the config at (2) is set, update number_of_internal_contributors and number_of_external_contributors.


Rust credential callback being invoked too much/hanging?

I'm not entirely sure what the issue is here, or if there really is an issue. This could be a possible issue with my implementation.
I'm trying to fetch from a remote with the git2 crate. In order to do this, we need to set up the authentication callback function, which I do.
When I run it, it invokes the authentication callback a lot, and my program hangs because there are so many auth callbacks being invoked. This only seems to happen with SSH keys.
The code that's causing this hang is below:
/// Callback function for libgit2 that retrieves the proper credentials for a repository for
/// remote access.
pub fn git_credentials_callback(
    url: &str,
    username: Option<&str>,
    cred_type: git2::CredentialType,
) -> Result<git2::Cred, git2::Error> {
    debug!("git credential callback activated");
    debug!("credential type: {:?}", cred_type);
    let user = username.unwrap_or(consts::DEFAULT_SSH_USERNAME);

    if cred_type.contains(git2::CredentialType::USERNAME) {
        return git2::Cred::username(user);
    } else {
        return git2::Cred::ssh_key_from_agent(username.unwrap_or(consts::DEFAULT_SSH_USERNAME));
    }
}

And the function that invokes that:
/// Given a valid git repository, pull for a particular branch. If
/// there are local changes that have not been committed, they will be stashed
/// and popped after the git repository is updated.
fn git_pull(path: &PathBuf, remote: &str, branch: &str, stash: bool) -> Result<(), git2::Error> {
    let repo = git2::Repository::open(path)?;
    let mut upstream = repo.find_remote(remote)?;

    // set up authentication callbacks so that credentials can be resolved
    let mut cbs = git2::RemoteCallbacks::default();
    cbs.credentials(&git_credentials_callback);

    // set up the fetch to use the auth callback
    let mut fetch_opts = git2::FetchOptions::default();
    fetch_opts.remote_callbacks(cbs);

    debug!("(git pull): fetching {}/{}", remote, branch);
    upstream
        .fetch(&[branch], Some(&mut fetch_opts), None)
        .unwrap();
    Ok(())
}

The repo it's being invoked on is a valid repo and uses SSH authentication. When I look at the debug output, it seems like git_credentials_callback is being constantly invoked, causing my program to hang.

There's a pretty particular protocol for how libgit2 invokes the authentication callback which is a bit wonky. Cargo has a good deal of documentation about how it works around this wonkiness, which may help out here?

@alexcrichton , do you know if it is still valid for nowadays? My callback already asks directly SSH_KEY, but is called a bunch of times, then the response is Failed to retrieve list of SSH authentication methods


Update cmake_minimum_version to 2.8.12

In the most recent release of cmake (3.19), they have started deprecating cmake versions < 2.8.12.
Example cmake warnings
https://ci.ros2.org/view/nightly/job/nightly_win_rel/1760/cmake/
Build all of ros2, testing up to rcutils

Linux
Linux-aarch64
macOS
Windows

Signed-off-by: Stephen Brawner<EMAIL_ADDRESS>

CI https://github.com/ros/urdfdom_headers/pull/67#issuecomment-733042583

Rerun ci jobs

Linux
Linux-aarch64
macOS
Windows

This PR doesn't actually impact warnings. I don't think kdl_parser_py is run with cmake.


What path to open a gist?

When opening a gist, I am asked for a path.  I'm not sure what to enter.  I enter / or space and I get:
error "null is not an object (evaluating 'delete e.history')"

I get: Cannot convert undefined or null to object when using the Gist URL and entering the file name manually.

Have you guys found a way to open an existing gist?

I haven't tried since. It's a shame, because the way StackEdit syncs to new documents to newly created Gists is great.
Hopefully someone will find a way, or this is a bug that'll one day be fixed.

I haven't tried since. It's a shame, because the way StackEdit syncs to new documents to newly created Gists is great.
Hopefully someone will find a way, or this is a bug that'll one day be fixed.


performance: Use CONSTRUCT query for dimension values metadata

This PR aims at improving the performance of dimension values fetching by replacing several SELECT queries with one CONSTRUCT query.
Observations
I compared the performance of the old and new way of fetching and included the results below. I based these measurements on four datasets:

Einmalvergütung für Photovoltaikanlagen,
Gebäudeprogramm - CO2-Wirkungen je Massnahmenbereich,
State accounts - Function,
NFI: Topics by stage of stand development,

opening each one in the editing mode and triggering fetching of dimension metadata values the same number of times for each dataset.

Key
Value

Number of queries
510

Avg. time SELECT
242ms

Avg. time CONSTRUCT
249ms (+3%)

I've also removed the conditions to limit inclusion of some properties based on scale type, as I am not 100% sure if they are needed anymore (e.g. if dimension values description can really only be present when scale type is either ordinal or nominal). Also, when they were added to the data, I think it makes sense to include them even when scale type is mapped wrongly. When they were removed, the performance of CONSTRUCT queries based on 406 new queries was better than SELECT queries by 0.04%.
cc @adintegra @RDataFlow

Closed in favor of #1378.


How to remove all rider animations for 2 Wheeled vehicles ?

Hello Carla Team, I would like that all riders of two wheeled vehicles stay static without any animations. How can I remove all the animations of riders ? Thank you.

Hi @Anna492,
I will take a look. As soon as possible I'll tell you something.

Hi @Anna492,
I will take a look. As soon as possible I'll tell you something.

Hello @XGodina, do you have any solution to this question? Thank you in advance.

Hi @Anna492,
In order to enable the two wheels animations, you have to go inside CARLA's UnrealEngine project, find "BP_Base2wheeledNew", select the mesh and change the Anim Class to 'None'

Thank you @Madecu.


Doesn't download videos from foxnews.com

When trying to download from video.foxnews.com, falls back on the generic extractor, which fails.
Sample video: http://video.foxnews.com/v/3583285787001/dr-carson-fires-up-the-view-over-welfare-comments/#sp=show-clips

youtube-dl has a FoxNews extractor now, and it works with the URL given here. I believe this issue can be closed.

FoxNews is supported since youtube-dl 2<IP_ADDRESS>.


When retrying, Pydantic validation errors are included in the prompt twice in Mode.TOOLS

[X] This is an actually a bug report.
[ ] I am not getting good LLM Results
[ ] I have tried asking for help in the community on discord or discussions and have not received a response.
[ ] I have tried searching the documentation and have not found an answer.

What Model are you using?

[X] gpt-3.5-turbo
[ ] gpt-4-turbo
[ ] gpt-4
[ ] Other (please specify)

Describe the bug
When a retry happens, the text "Recall the function correctly, fix the errors" is included in the prompt twice together with the whole Pydantic exception message.
To Reproduce
Use Mode.TOOLS.
Make a Pydantic model such that the LLM fails to respond to it correctly and a retry happens.
Observe OpenAI logs and note that the error message is included twice.
Expected behavior
I'd expect the exception message to only be included once.
Possible easy fix?
Is it possible that the "if" in this line should be an "elif"?
https://github.com/jxnl/instructor/blob/main/instructor/retry.py#L39
The current logic is:
if mode == Mode.TOOLS:
    ...

if mode == Mode.MD_JSON:
    ...
else:
    ...

With this logic, the execution goes through the first if: as well as through else:, serializing the exception twice.

shoot can you PR a fix?


Wifi(init): Unexpected behavior when initializing subsystems (IDFGH-12651)

Answers checklist.

[x] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
This line  is misleading because it expects initialization with the config attached, but if the subsystem is already initialized it simply returns ESP_OK. From which it is not clear whether the attached config was applied or not. But the API does not provide the ability to check whether the subsystem was initialized earlier.
Perhaps we should return a code that signals that the subsystem is already running?

#8745 Welcome to the club

Hi @KaeLL
It is recommended that if you want to reapply the new configuration in WiFi init, you first need to do WiFi deinit. Adding new error codes may damage certain applications. And we will update the document to describe this.

Hi @KaeLL It is recommended that if you want to reapply the new configuration in WiFi init, you first need to do WiFi deinit. Adding new error codes may damage certain applications. And we will update the document to describe this.

The esp_wifi_deinit function will return ESP_ERR_WIFI_NOT_INIT when wifi is not inited. From which it follows that without knowing whether Wi-Fi was launched earlier, it is not clear whether esp_wifi_deinit can be used or not.
https://github.com/espressif/esp-idf/blob/636ff35b52f10e1a804a3760a5bd94e68f4b1b71/components/esp_wifi/src/wifi_init.c#L234

Maybe we should introduce a bool wifi_is_inited() check function?
bool wifi_is_inited(){ return s_wifi_inited; }

Hi @safocl
Yes，you can introduce a bool wifi_is_reset_init_config(const wifi_init_config_t *new_config) to check.
bool wifi_is_reset_init_config(const wifi_init_config_t *new_config) {   if(global_old_config same as new_config) {     return true;   } else {     return false;   } }
Change in the esp_wifi_init function
    if (s_wifi_inited && wifi_is_reset_init_config(config)) {         return ESP_OK;     } else {     /*Prompt call deinitit then return. Or directly call deinit to continue the subsequent process*/     }
We suggest that users do not modify the init config.

@mhdong Did you really mean to reply to me? I don't care about reapplying configurations to an already initialized component. What I want is for init functions in IDF to be idempotent (like esp_wifi_init) but also to return a new esp_err_t code signaling that the component has already been initialized.
It's interesting how IDF can be inconsiderate of this issue, given that some components are global, like the default event loop or the GPIO interrupt, and also how inconsistent it can be, given that some components can be lazy-initialized and others can't, esp_wifi_init is idempotent while esp_event_loop_create_default isn't.


fix(chunjun-connector-hive) [chunjun-1350]

Purpose of this pull request

修复了没有读取配置的index而直接for循环用当前元素下标做index
Which issue you fix
Fixes # (issue).
#1350
Checklist:

[x] I have executed the 'mvn spotless:apply' command to format my code.

[x] I have performed a self-review of my own code.
[x] I have commented my code, particularly in hard-to-understand areas.
[x] I have made corresponding changes to the documentation.
[x] I have added tests that prove my fix is effective or that my feature works.
[x] New and existing unit tests pass locally with my changes.
[x] I have checked my code and corrected any misspellings.
[x] My commit is only one. (If there are multiple commits, you can use 'git squash' to compress multiple commits into one.)

You need to execute './mvnw spotless:apply' to format the code.

You need to execute './mvnw spotless:apply' to format the code.

好的 谢谢提醒，以按要求修改

DNM.


Add CI tests

Need to add automated build tests such as:

URL checks
Dictionary
Markdown roles

Need to add automated build tests such as:

URL checks
Dictionary
Markdown roles

URL checks:
we already use html proofer:  the html-proofer gem lets you build and then test links on the built site, both external and internal, https://github.com/gjtorikian/html-proofer

URL checks:
We use html proofer:  the html-proofer gem lets you build and then test links on the built site, both external and internal, https://github.com/gjtorikian/html-proofer

I meant in the repo for CITravis
Le jeu. 14 mars 2019 13 h 51, Imade Zarrari<EMAIL_ADDRESS>a
écrit :

URL checks:
We use html proofer: the html-proofer gem lets you build and then test
links on the built site, both external and internal,
https://github.com/gjtorikian/html-proofer

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/canada-ca/ore-ero/issues/102#issuecomment-472987287,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABnJ5Y-pnQs8zM-3hWSOsCxnFSVzMMlXks5vWow0gaJpZM4bwE9G
.


bug: the select component does not scroll if there are lots of items

Describe the bug
If a select includes many items it does not add up/down arrows, or scroll the way a native select element would (or how the original shadcn behaves, which would be a better comparison).
If you scroll down this page you can see the Scrollable part which demonstrates this:
https://ui.shadcn.com/docs/components/select

Reproduction
https://ui.shadcn.com/docs/components/select
Logs
No response
System Info
System:
    OS: macOS 14.1.1
  Binaries:
    Node: 20.11.0 - /usr/local/bin/node
    npm: 10.2.4 - /usr/local/bin/npm
  Browsers:
    Chrome: 122.0.6261.129
  npmPackages:
    @sveltejs/kit: ^2.5.4 => 2.5.4
    bits-ui: ^0.20.0 => 0.20.0
    cmdk-sv: ^0.0.15 => 0.0.15
    formsnap: ^0.5.1 => 0.5.1
    mode-watcher: ^0.3.0 => 0.3.0
    svelte: ^4.2.12 => 4.2.12
    sveltekit-superforms: ^2.10.5 => 2.10.5
    vaul-svelte: ^0.3.0 => 0.3.0

Severity
annoyance

Set "max-height" "overflow-y-auto" into <Select.Content> will solve this problem for right now.
<Select.Root>   <Select.Trigger class="w-[180px]">     <Select.Value placeholder="Theme" />   </Select.Trigger>   <Select.Content class="max-h-[200px] overflow-y-auto">     <Select.Item value="light">Light</Select.Item>     <Select.Item value="dark">Dark</Select.Item>     <Select.Item value="system">System</Select.Item>   </Select.Content> </Select.Root>
But yes, this isn't the default behavior. It needs a quick fix ASAP.


portico: Replace "Find accounts" button with "Log in" button.

This pull request includes changes to update the navigation links in the zerver templates. The most important changes involve modifying the URLs for the "Find accounts" links to now point to the "Log in" page.
Navigation link updates:

templates/zerver/landing_nav.html: Changed the URL in the "Find accounts" link to point to the "Log in" page.
templates/zerver/portico-header.html: Updated the "Find accounts" link to direct users to the "Log in" page instead.

Fixes: #32199.

Screenshots and screen captures:

Self-review checklist

[ ] Self-reviewed the changes for clarity and maintainability
(variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

[ ] Explains differences from previous plans (e.g., issue description).
[ ] Highlights technical choices and bugs encountered.
[ ] Calls out remaining decisions and concerns.
[ ] Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

[ ] Each commit is a coherent idea.
[ ] Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

[ ] Visual appearance of the changes.
[ ] Responsiveness and internationalization.
[ ] Strings and tooltips.
[ ] End-to-end functionality of buttons, interactions and flows.
[ ] Corner cases, error conditions, and easily imagined bugs.

Thanks! Please go through our guide on submitting a pull request to learn how to present your proposed changes to Zulip, so that your work can be reviewed.


Issue 13302 - Inline ASM grammar is not left-associative

https://issues.dlang.org/show_bug.cgi?id=13302

@WalterBright Does this seem reasonable?

@WalterBright @yebblies @ibuclaw @klickverbot  It's an easy review.  Please take a look.

This lack of attention is why I can't fix the language spec.

Seems reasonable.  Not something I implement though.


Issue with header when refresh and load

I applied new version 7/7/2016 and see:

When I disable header (ULSItem) with setDisplayHeadersAtStartUp(false) => refresh => ULSItem showed
Load more item with expandable => seem to expandItemsAtStartUp not work. New item not expanded.

Hi @mdtuyen, for the first point, in the current build, I do not have that behavior: ULSItem is marked done in the Singleton and so cannot be displayed anymore, it is added in the ExampleAdapter.updateDataSet(), there's is a check if it has to be added or not. I think there's no issue.
The second point, for the moment, I removed the auto-expand in combination with loadMore, ie. all addItems: Developer has to manually expand new items.

@davideas Thanks for your reply. I want to ask about sticky header in my project after i use new version of FlexibleAdapter Stickyheader have been disable. What is the condition of header to sticky ? enablesticky for Adapter, Header item extend of IHeader or anymore ?
And must i put adapter.expand(i) when I add element to position i of adapter to expand that item ?

Hi @davideas, I want to ask some Layout Item to top of recyclerview and them don't change when refresh or load more. What is the best solution to implement it ?

@mdtuyen, I wrote it in the release note of the snapshot, to avoid the bugs you need to pass also a new paramter true to the super constructor of the ViewHolder for the header view. This creates a new middle layout that will become sticky avoiding all those crashing bugs.
For the second question, if the layout remains fixed, it is not part of the RV, therefore the Adapter is not involved it's not an item but a simple layout on the top of the RV. It cannot be otherwise

With second question I think it is same with header, footer of listview. In your demo, you need re add them when refresh or init data. Is there simpler solution ?

Yes there is!
You need to add that special header item to the collection before this is passed to the adapter, so that, the animateTo is able to recognize its presence and it doesn't change position.
Override updateDataSet() and before calling super() add the header item at position 0.
animateTo has been revisited, now it works quite well, but don't abuse it for large 500/1000+ items it makes 3 times the calculation to check if all items has to be removed/added/moved from the original list.


Etcdkeeper always timeout when saving a file (Run with -h -p)

Etcdkeeper works well at local startup, but if you save a value with the - H - P parameter, timeout occurs, and HTTP put requests are sent only after timeout occurs. Specific phenomena can be seen in this link operation video.
http://download.voicecloud.cn/opps/20190828154845/VID_20190828_153704.mp4

额 不知道怎么了又不复现了，可以正常使用了。不好意思。

OK，我还没来的及测试问题。如果有问题再讨论吧。


Layer2 mode - advertised node (MAC) going down is not detected.

Describe the bug
We had the node that was used as the advertised MAC for a service via Layer2 mode be removed from the cluster, and openelb did not notice this and continued to advertise the MAC address of the node for the LoadBalanced Services.
To Reproduce
Remove or pull the NIC of the node that is being advertised for a service in Layer2 mode.  Observe that the service is unreachable (or watch tshark -n arp or some such to see mac still being advertised).
Expected behaviour
High Availability should detect this condition and move the advertised MAC to another node.
Output
87 74.760951381 08:c0:eb:b8:e0:ae → 76:5e:48:5d:7c:3b ARP 60 <IP_ADDRESS> is at 08:c0:eb:b8:e3:7e
The node with 08:c0:eb:b8:e3:7e was no longer up or part of the cluster.
Version Info

Version of Kubernetes: v1.
Version of OpenELB: v0.5.1

The cause is similar to https://github.com/openelb/openelb/issues/137


Fill the (sub)modules with detailed content

[x] OHM basics
[x] 1. Welcome to OHM
[ ] 2. Staging your project
[ ] 3. Building open projects
[ ] 4. OH specifics
[ ] 5. Roadmapping
[ ] 6. Licenses and standards
[ ] 7. Community and communication
[ ] 8. OHM Outro

I suggest that we work on the curriculum right here in the repository and not in the google doc of the expert review.
@amchagas already worked on the content of:

Building open projects

Licenses and standards

which has to be finalized and be transferred into the curriculum (sub)modules

I added a "work in progress" banner to all modules except "OHM basics" and "Welcome to OHM"
I adjusted the description of "Staging your project"
Added the assignments and some more content bullet points for the following (sub)modules

Staging your project
Building open projects
OH specifics
Roadmapping

This means the following modules still need some :heart:

Licenses and standards
Community and communication
OHM Outro

@thessaly

updated licenses and standards as a different branch... PR in a minute

Updated community and communication

OK I reviewed everything, added bullets when missing, made all headers coherent, etc. Work is in https://github.com/ohwmakers/OHM-curriculum/pull/13/

Closing this issue now. We decided to create issues for each submodule to track our progress.


xkb deadkeys not working despite registering

Hyprland Version
 System/Version info
Hyprland, built from branch  at commit fe7b748eb668136dd0558b7c8279bfcd7ab4d759  (props: bump version to 0.39.1).
Date: Tue Apr 16 16:01:03 2024
Tag: v0.39.1, commits: 4460

flags: (if any)

System Information:
System name: Linux
Node name: davtoo
Release: 6.6.21-gentoo-dist
Version: #1 SMP PREEMPT_DYNAMIC Wed Mar  6 20:25:11 '00 2024

GPU information:
03:00.0 VGA compatible controller [0300]: Advanced Micro Devices, Inc. [AMD-ATI] Navi 23 [Radeon RX 6650 XT / 6700S / 6800S] [1002:73ef] (rev c1) (prog-if 00 [VGA controller])

os-release: NAME=Gentoo
ID=gentoo
PRETTY_NAME="Gentoo Linux"
ANSI_COLOR="1;32"
HOME_URL="https://www.gentoo.org/"
SUPPORT_URL="https://www.gentoo.org/support/"
BUG_REPORT_URL="https://bugs.gentoo.org/"
VERSION_ID="2.14"

plugins:

Bug or Regression?
Bug
Description
Despite having set xkb_layout=us xkb_variants=altgr-intl with xkb_options=compose:menu,lv3:ralt_switch dead keys don't work while Ralt +  key do.
Although wev registers dead keys correctly, they just don't get typed on any window/program/terminal.
I tried changing settings like xkb_options=level3:ralt_switch, xkb_options=<empty>, even modifying /usr/share/X11/xkb/symbols/us directly without luck.
How to reproduce
Set any us keyboard variant with dead keys
Crash reports, logs, images, videos
No response

Hmm shouldn't it be kb_layout and kb_variant and not xkb_layout? :thinking:

You're right, I misremembered with all of that troubleshooting. My configs are correct however

That's weird, dead keys work for me on default us intl and my own custom layout.

this is not a hyprland issue, thats handled by xkb


Adding color on the icon with SCSS

Hello, my project is in SCSS and I would like to configure the color of the icon with the parameter "color=" with variables. Like this :
<Github color="$primary-color" :size="16" />

It's possible?

You have to use stroke, I believe.

I assume you're using the React Package.
I think you can accomplish to write it in your scss file:
.lucide-github {
  color: $primary-color
}

or if you want to do it application wide:
.lucide{
  color: $primary-color
}

Other solution is export you sass variables to javascript with:
/* My scss variables file*/
:export {
  primary: $primary-color
}

And then import sass file in you javascript file to access the variables.


CMP_ConvertTexture(...) is not thread-safe

CMP_ConvertTexture(...),  as mentioned in the Example1 here is not thread safe. If one calls the function in a multi-threaded fashion, crashes in the BlockEncoder.
As suggested by David Wilkinson @ AMD, one work around is to wrap the call with mutexes. I used a std::lock_guard<std::mutex>.

I would like to highlight the importance of this. We manage parallelism ourselves outside of Compressonator by processing textures in parallel so currently all of our texture compression runs ~40 times slower (48 LP machine) when one has to serialize all the compression work to work on an individual face/mipmap for a single texture at a time. So this is a must fix

We are working on the issue and will provide an updated example sample and fix asap.

We have a working solution for BC7 today, that is been tested with a number of multithreaded samples. If you prefer we can submit or attach the changes; while we continue the testing for publication in the next release of the code

Attaching the changes would be awesome. Thanks!! :)

BC7Multuthread issue.zip
The file changes are attached - The code may have issues and needs to run through qualification.
The Sample Example code has been updated : You can use example 2 to test the multithreading of BC7 The command line arguments should be repeated twice to test two concurrent image compressions
Assistance or changes in further code changes are welcome.

Some minor changes to Quant_Init() (Aviod using locks to keep code performance!)
3dquant_vpc.zip
Continuing tests... Will post changes to repo when stable.

Notes: To avoid memory access issues in BC7 Codec when used in parallelism
Call CMP_InitializeBCLibrary() prior to using the BC7 Codecs when Multithreading CMP_ConvertTexture() calls and then clenup with CMP_ShutdownBCLibrary(); when done, this will guard the global memory variables used by the codec and improve performance for multiple calls to the BC7 codec classes.

Sounds good. Will try your latest changes.

zigguratvertigo: Did you try the latest changes, Are there any issues that need our attention?

Just got back from vacation. Will try those today.

Tried it this was, issuing 28 compression requests at the same time, and unfortunately still crash:
CMP_InitializeBCLibrary(); cmp_status = CMP_ConvertTexture(&srcTexture, &dstTexture, &options, nullptr, 0, 0); CMP_ShutdownBCLibrary();
Callstack:

Quant_DeInit(void)
CCodec_BC7::~CCodec_BC7(void)
CCodec_BC7::vector deleting destructor'(unsigned int)
CompressTexture(struct CMP_Texture const *,struct CMP_Texture *,struct CMP_CompressOptions const ,bool ()(float,unsigned __int64,unsigned __int64),unsigned __int64,unsigned __int64,enum _CodecType)
CMP_ConvertTexture()

Same callstack if I remove the calls to initialize/shutdown the BC library.
Will investigate more but right now that's what I have.

CMP_InitializeBCLibrary(); // Used only once
// Then CMP_ConvertTexture called by threads or serially like this
cmp_status = CMP_ConvertTexture(&srcTexture1, &dstTexture1, &options1, nullptr, 0, 0);
...
cmp_status = CMP_ConvertTexture(&srcTexture2, &dstTexture2, &options2, nullptr, 0, 0);
...
cmp_status = CMP_ConvertTexture(&srcTexture3, &dstTexture3, &options3, nullptr, 0, 0);
etc..
CMP_InitializeBCLibrary(); // Used only once

Pretty much. Currently something in the form of:
uint32 threadCount = std::thread::hardware_concurrency();
uint32 useThreadCount = threadCount / 2; // run on 50% of the logical processors by default (skip hyperthreads essentially)
Concurrency::SchedulerPolicy policy(1, Concurrency::ContextPriority, THREAD_PRIORITY_LOWEST);
policy.SetConcurrencyLimits(1, useThreadCount);
Concurrency::CurrentScheduler::Create(policy);
CMP_InitializeBCLibrary();
Concurrency::parallel_for_each(...)
{
CMP_ConvertTexture(...)
});
CMP_ShutdownBCLibrary();

This is very interesting. The examples test code does a similar test, diff code same idea... Will try using your code in the example to see if I can get the same error.

The Quant_Deinit should not be doing any deletes, until CMP_ShutdownBCLibrary();
Try this change in 3dquant_vpc.cpp
void Quant_Init(void)
{
if (g_Quant_init > 0)
{
g_Quant_init++;   // add this
return;
}
if (amd_codes[0][0])  return;
for ( int ...) { ... }
g_Quant_init++;
}
only when g_Quant_init count reaches 0 should it delete!

Seems to work so far! :)

A bit of a request here, but ultimately it would be amazing if there was a way to not rely on such Initialize()/Shutdown() methods at all, and simply call the CMP_Convert(...) to compress. Or some other kind of mechanism where we can contain calls to CMP_ locally, per thread. In our case we have to call such init/shutdown functions at the very beginning of our execution model, where we can spawn a chain of operations that might include compression (or not), so it's a bit unfortunate to have to initialize Compressonator at such a level, where we might compress stuff or not.

A mutex on Quant_Init() is required to guarantee that dynamic memory initialization is done on the first thread call and no other thread is attempting to call Quant_Deinit() at the same time. Muxtex will initially reduce performance and then resume back when done. It’s best to avoid these where possible.
The other approach is to not have the memory dynamically allocated. This will avoid the issue, however the memory allocation is large and will always be present in you code.
To enable this simply build the code by commenting out #define USE_TRACE_WITH_DYNAMIC_MEM
I have added a mutex to Quant_Init() and so far it seems to be working without the need for
CMP_InitializeBCLibrary() and CMP_ShutdownBCLibrary();
A newer more compute compliant version of BC7 and BC6H are been developed and should be more suitable towards your needs. A feature notification will be updated when these codecs are scheduled for release.

Any idea / quick workarounds for the cause of this multi-threaded related crash? In this case, related to BC6H.

As mentioned here, did pass bDisableMultithreading==true and mNumThreads==1. Might be related?

If I disable our multi-threading code, where everything go through the same parallel_foreach loop (just like mentioned previously), then everything is fine.

Looking into this, suggest trying a quick fix sucha as:
CodecError CCodec_BC6H::CFinishBC6HEncoding(void)
{
if(!m_LibraryInitialized)
{
return CE_Unknown;
}
if (m_EncodeParameterStorage)
{
    if (m_Use_MultiThreading)
    {
        // Wait for all the live threads to finish any current work
        for (DWORD i = 0; i < m_LiveThreads; i++)
        {
            // If a thread is in the running state then we need to wait for it to finish
            // its work from the producer
            while (m_EncodeParameterStorage[i].run == TRUE)
            {
                Sleep(1);
            }
        }
    }
}
return CE_OK;

}
Since it seems that codec has already deleted the storage prior!

Is your BC6H Codec the latest code? seems like its an older revision!


[Feature Request] - Support active mode

Description
suppaftp currently supports passive mode only, which is the most commonly used. Sometimes active mode is needed, for example with servers behind a firewall that doesn't open port for data connections.
I have already started implementing it because I needed it, but it would be great to add the feature to suppaftp! I will be happy to make any changes to fit in.
Changes
Support active mode

It's okay for me!
Regarding the implementation in the client structure, I would make a method like this
pub fn active_mode(mut self) -> Self {
    self.mode = Mode::Active;
}

and by default mode is set to Mode::Passive

Merged into 0.4.2
Thanks again for the amazing contribution!


Update bundle download to link to filestore (fixes #277)

Codecov Report

Merging #285 into master will increase coverage by 0.02%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #285      +/-   ##
==========================================
+ Coverage   83.23%   83.26%   +0.02%
==========================================
  Files          37       37
  Lines        1724     1733       +9
==========================================
+ Hits         1435     1443       +8
- Misses        289      290       +1

Impacted Files
Coverage Δ

hca/dss/__init__.py
88.4% <94.44%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e4430...ab77bd5. Read the comment docs.

The coverage failures come from two sources:

windows specific code that deals with hard links
refactored variables in logging statements that weren't covered in the first place

I'm not sure how we will handle coverage of windows specific code.
I think the other coverage misses are excusable.


Matter hub not picking up certain entities

Only one of the light entities from home assistant are discovered by the home-assistant-matter-hub. I tried both pattern and entity match but neither are able to pick up my fans and one of my lights.

These are 4 entities that I have in my home assistant setup. I saw there was some logic in packages/backend/src/matter/devices/light-device.ts that filters based on color modes, as far as I can tell my my light should have been picked up.

Do they have a unique id?
You can check it by opening the entity‘s settings (where you assign labels or change the entity_id).
it will tell you you cannot change its settings because its missing an unique id.
I am aware of this and will improve it, but as of now those cannot be included.

Ah yes you're right. All of the devices that were not discovered do not have a unique id since i configured them through the yaml.
Thanks you! Is there already an issue created for this so I can keep track on any developments?

Works if I manually add a unique_id in the home assistant yaml config

This should have been fixed with the latest version. Can you please validate?


System state sensor shown as integer

System state is shown as integer i graphs.
Is there any way of translating these into actual state, Running, Stopped, Fault mode etc?
Or is the documentation lacking?

Documentation is lacking as you say. If we know what each bit means we could translate it as we do with a couple of other sensors.

Documentation is lacking as you say. If we know what each bit means we could translate it as we do with a couple of other sensors.

I can do a little research, Running Mode, Measuring, and Stopped should be easy to pin down.
Fault mode would is a little bit tricker

I can confirm that the doc is lacking this information and it is by design.
The codes is different status of the EH and is used by the developers at Ferroamp internal only.
I got some undocumented status codes and the code should be not be read as an integer, it should be read in HEX
example:
4097 - is 1001 in HEX and means that you are running  PV in active power automatic mode
4101 - is 1005 in HEX and means that PV and ACE in active power mode
These different setups is defined in the system configuration area in the portal and generates different HEX codes.
Perhaps change the datatype to HEX if it makes sense @argoyle and create a mapping of different codes to text as we did for the SSO status codes if there is a real need for it.

I can confirm that the doc is lacking this information and it is by design. The codes is different status of the EH and is used by the developers at Ferroamp internal only. I got some undocumented status codes and the code should be not be read as an integer, it should be read in HEX example: 4097 - is 1001 in HEX and means that you are running PV in active power automatic mode 4101 - is 1005 in HEX and means that PV and ACE in active power mode
These different setups is defined in the system configuration area in the portal and generates different HEX codes. Perhaps change the datatype to HEX if it makes sense @argoyle and create a mapping of different codes to text as we did for the SSO status codes if there is a real need for it.

No apparent need I would say, just for completeness sake 🚀
In addition to the modes you mentioned are (at least) Measuring mode, Inactive modeandFault mode`.

@bj00rn if you do the HEX mapping of the different states and add the output here then I can perhaps we can together do something about it.
My workaround regarding this "issue".
I made an automation that checks all SSO states, ESM state, and EH state to make sure that the system works as expected.
If the values are not what they should be then I generate an alarm and sent it as push notice to my phone.

ping of the different states and add the output here then I can perhaps we can together do something about it.

Nice! Sure, I will look into it!

hmm not as straightforward as i imagined
When stopping and starting the EH (PV & ACE) it goes through:
Stopping
4101  -> Shows "Running" in Portal
2381 -> Shows "Measuring" in Portal
1374 -> Shows "Stopped" in Portal
Starting
4098 -> Shows "Measuring" in Portal
4101  -> Shows "Running" in Portal

We don't have any official doc from ferroamp and I don't think that we will get any because theses codes har for internal use for ferroamp for now.
Shall we close this issue @bj00rn @argoyle

I think we can close it for now and either reopen och just PR if/when we get any official docs.


good pr test

jenkins: depends on https://github.com/RackHD/RackHD/pull/890

BUILD on-dhcp-proxy #9 : FAILURE

BUILD on-dhcp-proxy #11 : FAILURE

BUILD on-dhcp-proxy #18 : FAILURE

BUILD peter-test » on-dhcp-proxy-test #27 : FAILURE

BUILD on-dhcp-proxy #6 : FAILURE


[SUGGESTION] CI/CD check #{issueID} when submit pr

first submit issue, then submit pr to solve this issue.
and the PR should refer the corresponding issueID

done


[SPARK-13506] [MLlib] Fix the wrong parameter in R code comment in AssociationRulesSuite

JIRA: https://issues.apache.org/jira/browse/SPARK-13506
What changes were proposed in this pull request?
just chang R Snippet Comment in  AssociationRulesSuite
How was this patch tested?
unit test passsed

Can one of the admins verify this patch?

LGTM cc @mengxr

Jenkins test this please

Test build #52186 has started for PR 11387 at commit e1e0156.

Test build #52186 has finished for PR 11387 at commit e1e0156.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/52186/
Test PASSed.

Merged to master


Rewards with not yet activated validators

add rewards/penalty tests with not yet activated validators to ensure their balances don't affect base_rewards

@hwwhww @protolambda cleaned up a bit. could use a final review from one of you. thanks!


refactor to private with getters

The puzzle 67-45e76fc0 from #67 has to be resolved:
https://github.com/ammaratef45/Attendance/blob/b7cf719a727f8994adf0d4e4942f48e010118f7a/attendance/lib/backend/attend_model.dart#L20-L20
The puzzle was created by Ammar Atef on 30-Apr-19.
If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

@ammaratef45/z please, pay attention to this issue

The job #78 assigned to @ammaratef45/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be no monetary reward for this job

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @ammaratef45/z

The puzzle 67-45e76fc0 has disappeared from the source code, that's why I closed this issue.

Job was finished in 5 hours, bonus for fast delivery is possible (see §36)

The job #78 is now out of scope

Order was finished: +35 point(s) just awarded to @ammaratef45/z


Problems using log4cplus & anyrpc with unicode

Hi,
if I figured it correctly, anyrpc-logging is not working with unicode enabled.
Log4cplus itself supports unicode, for example I was building (on Win7 64bit, VS2015) with

cmake -DBUILD_SHARED_LIBS:BOOL=TRUE  -DWITH_UNIT_TESTS=OFF -DLOG4CPLUS_BUILD_TESTING=OFF -DUNICODE=ON -DLOG4CPLUS_BUILD_LOGGINGSERVER=OFF -DLOG4CPLUS_SINGLE_THREADED=ON

However setting up anyrpc via

cmake -DBUILD_EXAMPLES=OFF -DBUILD_WITH_LOG4CPLUS=ON -DBUILD_WITH_WCHAR=ON -DBUILD_WITH_THREADING=ON -DUNICODE=ON -DLOG4CPLUS_LIBRARY_RELEASE=..\..\log4cplus\build\src\Release\log4cplusU.lib -DLOG4CPLUS_LIBRARY_DEBUG=..\..\log4cplus\build\src\Debug\log4cplusUD.lib

leads to a project file, that can't be compiled (note that I provided the correct libs from log4cplus, however you might need to manually add the UNICODE preprocessor define to anyrpc project).
When compiling the anyrpc-project one gets multiple errors like

binary operator '<<': no operator found which takes a right-hand operand of type 'std::string' (or there is no acceptable conversion)

or

'TimeLogger::TimeLogger(const TimeLogger &)' : cannot convert argument n from 'const char [1]' to 'log4cplus::tstring &'.

These errors are caused by calling log4cplus-macros, which obviously expect wchar (or corresponding strings) when compiled with UNICODE-preprocessor define. However the calls by anyrpc are done with simple chars, often fixed strings like "this is an example".
One solution for this problem would be, to use something like TCHAR  and  _T("my example") (these two only exist in Visual Studio as far as I know), but one would need to change all the logs accordingly.
For myself I found another "solution": In fact I don't really want unicode-logging, but I need the unicode-define enabled in my main project, because it is working with QT and QT needs unicode. So I just compile the dlls for anyrpc & log4cplus without UNICODE-preprocessor defined. In order to include correct headers in my main project, I changed the following lines in logger.h:

#ifdef UNICODE
#undef UNICODE
#define UNICODE_DISABLED_BECAUSE_ANYRPC_LOGGING_WITH_UNICODE_NOT_SUPPORTED
#endif
#include <log4cplus/log4cplus.h>
#define InitializeLogger()
log4cplus::Initializer initializer;
log4cplus::PropertyConfigurator config(LOG4CPLUS_TEXT("log4cplus.properties"));
config.configure();
#ifdef UNICODE_DISABLED_BECAUSE_ANYRPC_LOGGING_WITH_UNICODE_NOT_SUPPORTED
#undef UNICODE_DISABLED_BECAUSE_ANYRPC_LOGGING_WITH_UNICODE_NOT_SUPPORTED
#define UNICODE
#endif

Obviously this is neither the cleanest nor a general solution, but this way UNICODE is defined everywhere (where QT needs it) except for the anyrpc / log4cplus part.
Any comments on this topic? Maybe I missed a point or there is a better way to get anyrpc running with unicode?

This seems like a reasonable short term fix.  This issue can be left open until a more complete investigation and solution can be determined.


Identify where the change comes from

When a change is commited, is it possible to identify if a changes is made via ADT or via visual code?
Reason why i am asking is that if the code is not checked in via ADT, then it needs to be loaded into SAP to make sure that all stays consistent. If it can be detected, then this pull can be automated.
Related Question: Can the pull be done for just one specific commit?

disregarding editor, it is possible for all developers to make errors, example of active program below
for abapGit development itself, the changes are proposed via pull requests which are checked by abaplint, which provides a small assurance that the ABAP code is consistent.  Consistent changes are then merged to master

there's only so much one can do on the development side. syntax checks, linting, and unit tests - all can be integrated in AG - should catch most inconsistencies in your dev box, no matter where the code came from.
if you really must know, logging the HTTP requests into dev might give you some indication.

Let me rephrase the question.
When an Abap is not changed via ADT (where AbapGit resides) but via other means, then a complete syntax check can only be done by importing the change into the AbapGit system. If a pipeline/workflow can determine this, then the import / pull can be automated.

I would run ATC as a nightly job to check things independent of abapgit.

thanks for the help. Closing


Added option to add callables to attribute map

There are some cases where post-processing of the returned shibboleth values are necessary before saving them to the CAS application. This PR adds a way to pass a callable as the third element of the attribute map tuple to perform arbitrary mutations of the returned values.

@blarghmatey Thanks for the PR. Could you please change "callable" to something else, so it's not shadowing a built-in function? Then I'll merge.

Thanks @bcail that has been updated now.


Dummy raw and epochs objects

A small wrapper function to quickly create and populate a raw or epochs object with any available data.
This is helpful if the data is in a different format or from different sources.

Fixed in the PR above.


Is it possible to get a random port assigned by the OS?

Informations

Type
Version

Question
3.7.x

Description
Is it possible to get a random port assigned by the OS, while using the @ServerSettings() decorator ?
Todos

[x] Example (log, usecase, etc...)
[x] Ts.ED version (question)

Something like this example:

var app = module.exports = express();
var server = http.createServer(app);

var start = function() {
    //listen to a random port that the OS assigns
    server.listen(0, function() {
        app.set('port', server.address().port);
    });
}

@Szauka currently not. This new feature can be added.

PR ready


Open Hive ACID txn only for transactional resources

What changes were proposed in this pull request?

Open ACID txn only when transactional resources are present in a query
Why are the changes needed?

Backend db calls optimization
Does this PR introduce any user-facing change?

No
Is the change a dependency upgrade?

No
How was this patch tested?

mvn test -Dtest=ITestDbTxnManager -Dtest.metastore.db=postgres

Is there an apache jira about this change?

Is there an apache jira about this change?

created https://issues.apache.org/jira/browse/HIVE-28238


Fix slow first request to dev server

The development server takes quite a while to serve its first response because it waits to compile until it's received its first request. Investigate the cause of this and find a solution that either reduces the compilation time or does it on initial server start and gets it out of the way.
Done when: serving the first request request does not require waiting for recompilation

There doesn't seem to be an easy config change to fix this, or at least I haven't found one.
See this Stackoverflow question. The given answer is to write a warmup task that automatically sends a request to server upon startup. That works but is not an elegant fix.

Yeah, I'm just gonna close this.  All we could really do is make the compilation happen before the server starts, which would at best be the same and at worst add time.


add cli flags for resource-group and workspace-name

The commands don't work without the required flags.

Don't need these because we run this template at the begining of each devops pipeline:
https://github.com/Azure/mlops-templates/blob/main/templates/aml-cli-v2/connect-to-workspace.yml
which configures the defaults


Open with: allow to open the same file in different editors

I find it confusing today that an editor is being replaced when I select "Open with...". I would expect that the original editor remains when I open with another editor.
Maybe there is a limitation I am not aware of but I think this should be supported. This is especially weird when the file to reopen is dirty and I am being asked to save it.
//cc @mjbvz

Especially in cases where a custom editor is text based, this works pretty cool actually because the same model is shared:

The general conversation has been Reopen with.... is opening the current file in a different editor and therefore it's replaced. Where if you right click in the explorer and do Open With.... it should keep the current tab.

Yes I do agree about that statement.

Related code (I think): https://github.com/microsoft/vscode/blob/fc191749834ceea13e1be76c81c14430ce152dc6/src/vs/workbench/services/editor/browser/editorOverrideService.ts#L299-L311

I believe this was fixed when I fixed https://github.com/microsoft/vscode/issues/121793. If you can still reproduce this issue please feel free to reopen it.

👏

Any chances to have "Open with..." as alternative action for "Reopen Editor with..." in context menu?
So I'll be able to open custom editor for current tab side by side instead of looking for same file in Explorer to open it again.
Or is there a command to open current editor in new tab with different custom editor?

@IllusionMH I don't believe there is anything right now besides the explorer context menu and extension APIs that allow for Open With.... However, when you focus a tab it should focus the respective explorer item so you don't have to go looking for it.


Install docs improvements

Migrated from https://rnabio.org/module-08-appendix/0008/08/01/Proposed_Improvements/

Consolidate all install/configuration documentation to the AWS setup page. Change the student Tool Installation section to be a more didactic section. Demonstrate different kinds of tool installations and have some exercises but it isn’t about the students install all the tools they need.

This is a bit of a mess right now.

We have started to improve the student tool installation section: https://rnabio.org/module-00-setup/0000/08/01/Installation/
Next step would be to choose a subset of tools that demonstrate the various install types/patterns.
But we want to keep the complete install instructions so that we know how to set up the AWS instances.  These would logically live here: https://rnabio.org/module-08-appendix/0008/08/01/AWS_Setup/
But currently that location is describing setup for the CSHL course (more than just RNA-seq).  And worse than that the actual install instructions for RNA-seq course are held by Zhibin.

We need a proper home for the CSHL Advanced Seq Tech AWS cloud setup docs.  Then we can use this place for the RNA-seq AWS cloud setup docs.  Then both of those should reflect was is actually done for those two courses respectively.

https://rnabio.org/module-08-appendix/0008/08/01/AWS_Setup/ currently has the latest AWS instructions for the SEQTEC 2019.

Now https://rnabio.org/module-08-appendix/0008/08/01/AWS_Setup/ currently has the latest AWS instructions for the SEQTEC 2020.

The correct link is: https://rnabio.org/module-09-appendix/0009/09/01/AWS_Setup/


fix: allow context lock renewal in plain progress

Context locks were introduced (in #7272) as a way to prevent needless switching between two spans: e.g. suppose that span A and span B were running at the same time producing logs. If they both produce high volumes of logs, we want to ensure that we switch between them at a "reasonable" rate, and not switch back and forth immediately as they become available (which is significantly harder to read).
However, this initial implementation was slightly flawed: once a span acquired a lock, it would only be able to hold it for a maximum of a second - after that, another span would be immediately able to acquire the lock, even if it was actively being used.
 This next span is able to acquire the lock, and we start with that. But eventually, initialize gets the lock back, and finishes printing, interrupting the currently ongoing span.
This problem is fixed by adding the concept of lock re-acquiry. If a span that holds the lock attempts to render it's context, it re-acquires the lock, refreshing the lock's timestamp, so it can continue to hold it. This prevents the above case, since initialize is still attempting to complete, and we can time from the last usage instead of the first usage.
There is one issue with the above though - a very noisy span could easily stifle the results of a span beneath it, which is annoying. To attempt to prevent this, we impose a max possible lock time (10 seconds) - this should be sufficient to avoid the issue we see in initialize and similar, but should be low enough to avoid the noisy span problem.

I found this and tried to fix this as part of https://github.com/dagger/dagger/issues/7954, but I don't actually think the issue is related.


Error on cilium context when $KUBECONFIG requires root privileges

Bug report

Hi I'm having issues to install cilium on a k3s node.
By default, the kubeconfig in /etc/rancher/k3s/k3s.yaml is created with 700 permissions.
That's why for running stuff like kubectl it's required to run with sudo, which works perfectly fine in the case of kubectl.
cilium context/install on the other hand won't work like this.
I know a simple workaround would be changing the file's permissions, but I thought it might be good to report anyway since it works for kubectl and I think it's valid to have restricted access to the kubeconfig.
General Information

Cilium CLI version (run cilium version)

cilium-cli: v0.9.3 compiled with go1.17.3 on linux/amd64
cilium image (default): v1.10.5
cilium image (stable): v1.10.5
cilium image (running): unknown. Unable to obtain cilium version, no cilium pods found in namespace "kube-system"

Platform / infrastructure information (e.g. AWS / Azure / GCP, image / kernel versions): k3s

How to reproduce the issue

sudo chmod 700 $KUBECONFIG
sudo cilium context

output on my machine
ubuntu@node1:~$ echo $KUBECONFIG
/etc/rancher/k3s/k3s.yaml
ubuntu@node1:~$ cilium context
unable to create Kubernetes client: error loading config file "/etc/rancher/k3s/k3s.yaml": open /etc/rancher/k3s/k3s.yaml: permission denied

ubuntu@node1:~$ sudo echo $KUBECONFIG
/etc/rancher/k3s/k3s.yaml
ubuntu@node1:~$ sudo cilium context
Context:
❌ Context  not found in configuration

Thanks for your report @brumhard.
Is $KUBECONFIG set in root's environment? I think in the command you posted involving $KUBCONFIG, the variable is evaluated before running sudo. By default, environment variables are not inherited when using sudo, so I assume $KUBECONFIG to be empty when you run sudo cilium context. Does it work if you run cilium using sudo KUBECONFIG=$KUBECONFIG cilium context or sudo --preserve-env=KUBECONFIG cilium context?

Hi @tklauser,
thank you very much.


node_redis / examples / file.js is not working

the file given back from redis is not the same as the one stored (data corruption)
node version :  0.6.16
redis server version: 2.4.13
osx: 10.7.3
using this file:
https://secure.gravatar.com/avatar/f2602cabcccbe70f6e73e0c86379921d?s=140&d=https://a248.e.akamai.net/assets.github.com%2Fimages%2Fgravatars%2Fgravatar-140.png
original file size: 5457
% file original.jpg
original.jpg: JPEG image data, JFIF standard 1.01, comment: "CREATOR: gd-jpeg v1.0 (using IJ"
file size after getting it back from redis: 9996
% file duplicate_original.jpg            data
redis reports the serialized length to : 5438

Fixed with ddbb94b598ea204d3aeb7c4a79ec6900d037bde8


What is the loss mask for special tokens in SFFTrainer

System Info
latest transformers
Who can help?
@muellerzr and @pacman100
Information

[X] The official example scripts
[ ] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction
I'm training with SFTTrainer and want to ensure that the model is including the loss on predicting an EOS token (< /s >).
What is the default handling of special tokens for the loss computation in SFTTrainer? Can I change this?
from transformers import Trainer
from trl import SFTTrainer

trainer = SFTTrainer(
    peft_config=config,
    dataset_text_field="text",
    max_seq_length=context_length,
    tokenizer=tokenizer,
    model=model,
    train_dataset=data["train"],
    eval_dataset=data["test"],
    args=transformers.TrainingArguments(
        max_steps=60, # comment this out after the first time you run. This is for testing!
        num_train_epochs=epochs,
        output_dir=save_dir,
        evaluation_strategy="steps",
        do_eval=True,
        per_device_train_batch_size=batch_size,
        gradient_accumulation_steps=4,
        per_device_eval_batch_size=batch_size,
        log_level="debug",
        optim="paged_adamw_8bit",
        save_steps=0.2,
        logging_steps=1,
        learning_rate=1e-4,
        eval_steps=0.2,
        fp16=True,
        max_grad_norm=0.3,
        warmup_ratio=0.03,
        lr_scheduler_type="linear",
    ),
    callbacks=[logging_callback],  # Add custom callback here
)
model.config.use_cache = False  # silence the warnings. Please re-enable for inference!
trainer.train()

Note that in my dataset I have included EOS tokens where appropriate
Expected behavior
The output of my fine-tuning is not emitting EOS tokens, which leads me to believe that the loss mask is zero for special tokens with SFTTrainer, but I'm unsure if that's true.

Could this be related to #696?

See https://github.com/huggingface/trl/issues/696 for closure


Agora 2.0 - Minor fixes for ADS connections and Reports

Please fix the merge conflict @chintalavr


Terraform plan should detect invalid CNAME record values, like https://some.domain

Confirmation

[X] This is a bug with an existing resource and is not a feature request or enhancement. Feature requests should be submitted with Cloudflare Support or your account team.
[X] I have searched the issue tracker and my issue isn't already found.
[X] I have replicated my issue using the latest version of the provider and it is still present.

Terraform and Cloudflare provider version
I use https://github.com/pulumi/pulumi-cloudflare which uses this Terraform provider behind the scenes.
I'd think Terraform plan would catch invalid CNAME record values, but it does not. https://<fqdn> went through plan, but fails at deploy as it's not a valid CNAME value (notice the https://).
Affected resource(s)
See https://github.com/pulumi/pulumi-cloudflare/issues/748.
Terraform configuration files
See https://github.com/pulumi/pulumi-cloudflare/issues/748.
But given example https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/examples/resources/cloudflare_record/resource.tf:
resource "cloudflare_record" "example_cname" {
  zone_id = var.cloudflare_zone_id
  name    = "terraform"
  value   = "https://some.domain"
  type    = "CNAME"
  ttl     = 3600
}

Link to debug output
See https://github.com/pulumi/pulumi-cloudflare/issues/748.
Panic output
No response
Expected output
Invalid CNAME record value should not go through plan.
Actual output
https://<fqdn> is a valid CNAME record value.
Steps to reproduce
See https://github.com/pulumi/pulumi-cloudflare/issues/748.
Additional factoids
No response
References
No response

thanks for the issue! unfortunately, we don't apply strict validation for record types as the value field is used for multiple types (for any operation) given it needs additional context and internal logic to determine what is an is not valid. instead, we leverage the API to perform the more stricter validation. that's all to say, we don't support this today and unlikely to add more client side logic to support it in the future. sorry!

What Cloudflare API endpoint is used to do "the more stricter validation" in this case?

we are intentionally not duplicating the server side logic (and have no intention of doing so).
there is not dedicated validation endpoint; it is performed at creation time by the DNS endpoint.

Got it, output of plan can't be trusted.

The only built in way to know for sure the value you want to set is valid is to try to deploy it. Which means plan does not validate, and thus gives a invalid feedback saying it will be deployed/go through.
The setup here is a brach protected repo with checks that must go through before a reviewer can approve. The reviewer can't trust built in checks (plan), is what I'm saying.
Currently, to give the reviewer info about whether a CNAME value is valid we'd have to deploy it to a dummy domain as part of the checks. Could be doable.
What we do instead is to write a linter that checks for things terraform plan / pulumi preview won't catch. Valid CNAME value is now part of said linter.


domain and partition

Is there a fundamental difference between establishing multiple domains isolated communications and establishing multiple partitions isolated communications in the same domain? Is there a difference between them in the efficiency of transferring large amounts of data?

Hi ZTY-star,
Please go through below link to understand the difference between domain and partitions:
http://download.prismtech.com/docs/Vortex/html/ospl/DDSTutorial/topics-etc.html#scoping-information

We are now thinking of establishing multiple domains or multiple partitions to isolate communications, but we don't know much about the difference in efficiency between the two? how to choice?

To choose multiple domains or multiple partitions depends on the requirement. Partition provides a better way to control the communication in a singe domain, so to use multiple partitions are more optimal.
In the DDS-standard, there are different means for data-partitioning, one is the concept of a ‘Domain’ and the other is a ‘Partition’.
Domains completely separate DDS-instantiations meaning that information (Topics/types/instances/samples) can have a completely different meaning between domains even if their names suggest otherwise.
In OpenSplice DDS, a Domain is characterised by a shared memory segment that holds

All the data of that domain in a node.
A set of applications that have created Domain Participants for that domain
A set of pluggable services that aid in realising the required and configured functionality that is needed in that domain (with services such as for networking, durability, SOAP-connector, DBMS connector, etc.).

A DDS ‘Partition’ is a more granular, dynamic and therefore powerful concept in DDS in that any Publisher and/or Subscriber is always related / connected to one or more DDS-partitions.
A DDS-Partition is a QoS policy of Publishers and Subscribers and all readers/writers that belong to a publisher/subscriber share information that is written in those partitions.
Partitions can be created on-the-fly, are characterised by a ‘name’ and subscribers and publishers (but typically subscribers) can even use wildcards in the partition-name to allow connection to dynamic sets of partitions.
To know more about multiple domains you can use below link:
https://istkb.adlinktech.com/article/how-can-i-connect-to-multiple-dds-domains/

Domains are Administrative boundaries that isolate and config the data definition ( i.e Topic Names ,data types and data dissemination) . Topic data types and names need to be unique in a given domain, Domains are identified by a unique ID that is used to compute the multicast address DDS will use underneath. Use multiples domains for fragmented sub-systems that do not need to exchange data,  To force communication using multiple domains , you need to build a sort of application bridge with one domain participants in each domain, then read data from a given domain to explicitly sent it to the other domain. This bridging approach comes to a cost as data as exchanged fundamentally at the application level. It has also the drawback to be rigid as you need to know in advance the domains you are going to be involved into. The support of multiple-domains in the same application is available only in the so-called federated architecture available in the commercial edition. Using the opensource edition you can still use multiple domains as far as there is no application that needs to belong to multiple domains.
Partition is a more agile concept that you can use to gather publisher and subscribers in the same logical group. from the engineering perspective partition is a logical name made by a regular expression, you can use it for instance to represent a logical hierarchy or geography repartition (a network partition ) of your system. Partitions can be defined at the runtime.
The support of partitions is available in both commercial and opensource edition,
In OpenspliceDDS when using the Extended DDSi Service implementation, you can map the concept of Logical Partition on the concept of Network partition. (The network partition is a set of IP addresses ( unicast and/or multicast ). ) by doing so you're physically confining the data traffic dissemination where it needs really to go, while remaining in the scope of the same DDS domain, so you are enjoying the flexibility of the partition concept and the physical traffic confinement of the domains.


grunt transpile-raw task fails: bundle.generate now returns a Promise instead of a { code, map }

Description of the Issue and Steps to Reproduce:
I just cloned the repository, checkout develop, npm install, npm install -g grunt and executed grunt.
I got the following output:
Running "jshint:all" (jshint) task
>> 399 files lint free.

Running "jscs:all" (jscs) task
>> 399 files without code style errors.

Running "transpile" task

Running "clean:build" (clean) task
>> 0 paths cleaned.

Running "transpile-raw" task
>> error transpiling Error: bundle.generate(...) now returns a Promise instead of a { code, map } object
>>     at Promise.get (/Users/ntag/Projets/moment/node_modules/rollup/src/rollup.js:81:9)
>>     at /Users/ntag/Projets/moment/tasks/transpile.js:75:26
>>     at process._tickCallback (internal/process/next_tick.js:103:7)
Warning: bundle.generate(...) now returns a Promise instead of a { code, map } object Use --force to continue.

Aborted due to warnings.

Environment:
I use macOS, tried with node v0.12.18 (npm v2.15.11), node v6.9.15 (npm v3.10.10), and also with node v7.10.0 (npm v4.2.0), all failed.
grunt --version gives grunt-cli v1.2.0 grunt v0.4.5.
But I see that travis has the same issue, so you might already know about!

I'm getting this message using Rollup.js. Any idea what the relation may be?


Added capability to sort IFS files and Members by name or date

Changes
A new submenu has been added to the IFS directories and Physical Source File items in the explorers:

It allows to sort the content of the selected directory/SPF by name or date.
Checklist

[x] have tested my change
[x] eslint is not complaining

@sebjulliand Before I do this I think it might be worth fixing the conflicts here. Sorry about that!

All done @chrjorgensen, you can now sort from members, files and shortcuts.

@chrjorgensen yes, that makes perfect sense. I'll see what can be done 😁

@chrjorgensen, reversing the sort order is easy, but displaying a ⬇ or ⬆ in the command name requires to create separate commands and display one or the other depending on the clicked item's context value which will impact every when clause using those items in package.json. I'm not quite sure I want to go down this path just to display the current sorting order 😅
Can you think of a better place to display the sorting order? (item description, tooltip...)

@chrjorgensen , you're on.
Sorting is now reversed when re-executed and asking to sort on a closed branch will expand the branch.
Let me know what you think 😊

@chrjorgensen there you go:

The sorting order will show in the description (only if changed...otherwise it shows on every directory/SPF and the UI gets bloated 😁).
And the file name comparison uses localCompare now.
Let me know how it goes!

Thanks @chrjorgensen !

One question: Why change instance into a function? Just curious...

That's because instance used to be a constant and it is now a variable (since https://github.com/halcyon-tech/vscode-ibmi/pull/1142). And I found out that if we require the instance field outside of a function (at least in JavaScript...I didn't have a problem when importing in TypeScript), we sometimes get the un-initialized variable (depending when the script gets loaded). So to avoid this, I put a function here and there to get the "correct" instance field. It won't be necessary once everything will be converted to TS though. 😁

One small issue: Each time I sort on a directory, a counter and the directory name appears in DEBUG CONSOLE

This console.log has been here since before I made this change:

Maybe we can remove it @worksofliam ?

@worksofliam Absolutely we can remove it.

Removed! @chrjorgensen feel free to approve and merge whenever you want!

Thanks @chrjorgensen!
Indeed, recent changes broke the action opening the filter editor.
So that's fixed and now sorting by name on a closes node will sort by name by default.

@sebjulliand Is this something I can review in place of Christian? Is this really just needed some user testing? That is something I can do :)

@worksofliam sure, it just need a final test round 😀

Hmmm... I pulled and ran npm i, started it and it didn't crash. I'd expect
ObjectBrowser to crash as well then, since it's still JS. I'll dig deeper 😉
Le ven. 7 avr. 2023, 23:17, Christian Jorgensen @.***>
a écrit :

@.**** requested changes on this pull request.
@sebjulliand https://github.com/sebjulliand Just gave your last update
a spin - but the extension wouldn't even start, but gave this error:
[image: billede]
https://user-images.githubusercontent.com/13275072/230680059-a420a827-3fc0-4e79-8994-d0c274700251.png
See suggested fix...
In src/extension.ts
https://github.com/halcyon-tech/vscode-ibmi/pull/1151#discussion_r1160968760
:

@@ -19,6 +19,8 @@ import { CompileTools } from "./api/CompileTools";
import { HelpView } from "./views/helpView";
import { ProfilesView } from "./views/ProfilesView";
import * as Debug from './api/debug';

Aren't a line like the following missing here?
⬇ Suggested change

+import IFSBrowser from "./views/ifsBrowser.js";
—
Reply to this email directly, view it on GitHub
https://github.com/halcyon-tech/vscode-ibmi/pull/1151#pullrequestreview-1376590259,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACUVGOVMJEZN5C5GXDIFP7LXAB77BANCNFSM6AAAAAAWDAABUI
.
You are receiving this because you were mentioned.Message ID:
@.***>

@chrjorgensen you were right; I guess I wasn't really awake yesterday 😅
Anyway, it's working now!

Thanks a lot @worksofliam!
Conflicts have been resolved. I'll let you merge and a test PR will follow shortly 😉

The comparison tests (SQL vs no SQL) for getMemberList fails, but to be expected as each types returns a unique changed property. I am ok with this, but something to keep in mind when writing new tests @sebjulliand.


Release 1.0

We should release 1.0! While there's an awful lot of stuff we could potentially fix before shipping a "1.0" release, I think the biggest thing we can do is ship the Actor/Cell split as 0.16 (#357) and work to fix everything that breaks as a result :wink:
What about the rest of the stuff? Well, that's what 2.0 is for!

With a lot having changed lately, and some soulsearching having happened regarding some refactoring projects needing done, here's a tentative schedule suggestion to get us up to 1.0 in achievable time:
https://groups.google.com/d/msg/celluloid-ruby/xUFSTGX1sKY/OoQI-jivoAIJ

I did a sweep of the open issues and closed this one accidentally

All has been quiet in Gitter and here since January - has the second wind died down?    Is there hope of this being revived?

#789 is the place to start, unfortunately of all of the prospective interested people who said they'd triage that release, no one has seen it through so far

I've been looking at the angle of reworking the actor system by implementing a RINA messaging system between actors. We also have an approved Open Collective organization. Am here, watching

I think the main thing Celluloid could benefit from, provided anyone wants to keep it going, is another release, followed by several other releases of minor changes and bugfixes.
Where things started to wrong before was with changes that were too invasive, creating too many bugs.

Especially since I introduced most of those changes, I can start to budget a couple hours a week to Celluloid soon. Will start to make time as soon as I can


Stable Diffusion extension won't install

When I click Install for FaceChain on the Extensions tab of Automatic1111 it does a never-ending "Processing..." step. That step normally takes a few seconds but I've let it sit for 10+ minutes and it never finishes. It builds a FaceChain folder in my extensions folder, but whenever that folder exists my .bat startup gets stuck and my Stable Diffusion won't startup unless I delete that FaceChain folder. I've also tried installing via .zip file and that didn't work either. My A1111 is up to date. Anyone got any ideas of what I can try?

can you provide some installing logs?

can you provide some installing logs?

I don't get any errors and nothing shows up in the log. It just says "processing | 500/0.1s" or whatever, with the 500 number being however many seconds I let it run and 0.1 being the expected time. It seems like the extensions/facechain folder fills up with everything it's supposed to, but for some reason it just completely breaks my A1111 SD to the point where I can't use it again until I delete that facechain folder.

during facechain installation, in Windows platform mmcv-full will be needed and built for very long time,  it may be stucked here?
you can  try to execute C:\stable-diffusion-webui-v13\venv\Scripts\pip list |grep mmcv to see whether it has been successfully installed，  if not please wait until mmcv to be built

during facechain installation, in Windows platform mmcv-full will be needed and built for very long time, it may be stucked here?
you can try to execute C:\stable-diffusion-webui-v13\venv\Scripts\pip list |grep mmcv to see whether it has been successfully installed， if not please wait until mmcv to be built

That was it. I didn't have mmcv in my pip list so I did   pip install mmcv   and that took about 20-25 minutes to finish. Installing the extension took about 10 seconds after that and I'm seeing the FaceChain tab after restarting. Thanks!

during facechain installation, in Windows platform mmcv-full will be needed and built for very long time, it may be stucked here?
you can try to execute C:\stable-diffusion-webui-v13\venv\Scripts\pip list |grep mmcv to see whether it has been successfully installed， if not please wait until mmcv to be built

That was it. I didn't have mmcv in my pip list so I did pip install mmcv and that took about 20-25 minutes to finish. Installing the extension took about 10 seconds after that and I'm seeing the FaceChain tab after restarting. Thanks!

I also resolved it by waiting for more than 20min.Thanks for your practice.


issue with 9.2 partial downgrade

so I downgraded to 9.2 from my new 3ds on 10.7, but the menuhax didn't work afterward when I tried to access homebrew, I just get a must update message for browserhax and my OOT hax also seems to not work on what I assume is a partial downgrade, albeit I may have the wrong setup on OOTHAx now that the firmware is partial.
I am not really sure what to do at this point, so if you are able to help that would be great.

you need to setup oothax for 9.2. it should then work


Require activity type docs

Every activity type should be required to have some documentation in order for the activity type to be recognized by the loader. An error message should be thrown by the loader indicating to the developer what to do in order to fix the issue, including the specific file name that is needed.
Related to #24
originally filed as https://github.com/engineblock/engineblock/issues/2

If driver adapter docs are missing completely, then compilation fails with an appropriate message. This doesn't ensure the quality of the provided doc files, but is enough to set the expectation when the error occurs.


[FLINK-24986][tests] Replace anonymous StreamStateHandle class

Anonymous StreamStateHandle classes are not allowed by the StateHandleSerializationTest.

The test failure is related to FLINK-23525


add trtllm container build

Description
add trtllm container initial commit

https://github.com/deepjavalibrary/djl-serving/actions/runs/6620374975/job/17982662998


Replaced DDoS Standard with DDoS Network Protection

Overview/Summary
As per ADO User Story 24459, performing a replacement of "DDoS Standard" with "DDoS Network Protection" in all the ALZ-Bicep repo.
This PR fixes/adds/changes/removes

Closes Issue #395

Breaking Changes
NA
Testing Evidence
NA
As part of this Pull Request I have

[X] Read the Contribution Guide and ensured this PR is compliant with the guide
[X] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
[ X] Checked for duplicate Pull Requests
[ X] Associated it with relevant GitHub Issues
[X ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
[X ] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[ ] Updated one or more of the following tests (if required)

Unit
Linting
E2E (End-To-End)
ValidateAzCloud (Base validation in Azure Cloud)
ValidateMcCloud (Base validation in Azure China Cloud)

[X ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
[ ] If relevant, created or updated Code Tours here

@jtracey93 I believe it should now be ready for merging as I rolled back the changes in both files. Please check and let me know if still missing something.

/azp run validateazcloud


Automatic Request History and Management

Currently, Api Dash requires users to manually save each API request. This can be cumbersome, especially when working with multiple requests or iterating through different configurations.  Postman, a popular API testing tool, offers automatic request history with the ability to name and organize requests for easier access and reference.
Implementing automatic request history and management in Api Dash would significantly improve its usability. This feature could include:

Automatically saving past API requests with timestamps.
Allowing users to name and organize saved requests for better management.
The ability to filter and search through saved requests.

This functionality would make Api Dash a more efficient and user-friendly tool for developers and testers working with multiple APIs.

Thank you for your feedback. I have added your comments to the original thread for this feature - https://github.com/foss42/apidash/issues/184#issuecomment-2075218364
Closing this issue as a duplicate, but I will update the progress of this feature in this thread once it is live.


wireless

Aim
This script is a menu-driven program that provides various options for wireless network reconnaissance and cracking
Details
Allows  to change the MAC address of a specified network interface enables monitor mode on a specified network interface. Stops monitor mode on a specified network interface.
Do I want to work on this:

[x]  Yes
[ ] No

hey can you pls assign me this issue i really want to contribute on it.

hey can you pls assign me this issue i really want to contribute on it.

Bro find issue yourself and raise your are not going to assign this issue

Go Ahead @shraddha761


Node v4 update

Resolve #5
This updates JSDom to v7 and requires Node v4+.
I'm not sure there's a good way to support legacy node / JSDom and the new stuff.

amazing. thank you @paulfalgout! will merge tmrw

I'm not sure there's a good way to support legacy node / JSDom and the new stuff.

I think there won't be any maintenance, but it will still be supported by just installing an older version of this project. How's that sound to you?

:+1:

updated


AJ-1012 allow tdr import to azure workspaces

Jira Ticket: AJ-1012
For azure workspaces, find and call the appropriate wds app when importing from TDR instead of calling rawls.  This only works for format tdrexport and pre-existing azure workspaces.  If you select the 'create a new workspace' option, WDS will not be booted up in time to receive the import request.   This is expected to be available in later iterations when the tdr import API is asynchronous.

From a catalog/data-explorer team perspective, this looks fine. It isn't going to negatively affect our flow at all. Currently, this is only for tdrexport - is there a plan to support this for other exports? And if so, what is the timeline on that? (I know for updating catalog, we are going to need to make the changes on the backend, is that something we should have on our roadmap?)
@s-rubenstein
We're looking at PFB imports next, although I'm not sure yet of the timeline.

with this PR, what happens when performing an import to a newly-created Google workspace? Does it erroneously try to contact WDS?

No, in my testing it still calls rawls.