Upgrade find command

Find student by fields

name
phone
email
parent phone
parent email
address
tags

UG: https://github.com/AY2122S1-CS2103T-F13-3/tp/pull/108
todo (I'll do in separate PR after this one):

I''ll add school, acad stream, acad level
replace NameContainsKeywordsPredicate

Just a few questions:
1. Should tag allow matching of individual words like other fields?
Currently other fields allow matching of individual keywords.
e.g. find n/John tan consists of 2 keywords John and tan and it matches John Lee and Ben Tan
For the implementation of tag search at the moment, the whole phrase is considered as one keyword
i.e. find t/sec school will not match tag sec or school.
2. Should tag be exact word match rather than allowing substring.
Currently, find t/paid will match tag unpaid.

Decision:

Fields should match all keywords
e.g. find n/John tan

can match john tan, johnny tan, john tang
cannot match ben tan , john
this is so to make the find more restrictive to make it easier to find a particular student

Tags should be exact

find t/paid cannot match unpaid

Command: find n/ice yu
Is this supposed to not match the student named "ice yo"?

Since a keyword must be provided for the search, does this mean users will not be able to search for/filter students without a parent phone for example?

Codecov Report

Merging #107 (2622536) into master (14cbfc9) will increase coverage by 1.65%.
The diff coverage is 85.57%.

@@             Coverage Diff              @@
##             master     #107      +/-   ##
============================================
+ Coverage     65.02%   66.68%   +1.65%
- Complexity      570      656      +86
============================================
  Files            91       92       +1
  Lines          2053     2245     +192
  Branches        272      325      +53
============================================
+ Hits           1335     1497     +162
- Misses          612      620       +8
- Partials        106      128      +22

Impacted Files
Coverage Δ

.../java/seedu/address/logic/commands/AddCommand.java
94.11% <ø> (ø)

...s/model/person/PersonMatchesKeywordsPredicate.java
77.31% <77.31%> (ø)

...in/java/seedu/address/commons/util/StringUtil.java
92.00% <87.50%> (-2.74%)
:arrow_down:

.../seedu/address/logic/parser/FindCommandParser.java
94.28% <97.05%> (-5.72%)
:arrow_down:

...java/seedu/address/logic/commands/FindCommand.java
100.00% <100.00%> (ø)

...ain/java/seedu/address/logic/parser/CliSyntax.java
94.73% <100.00%> (+0.29%)
:arrow_up:

...in/java/seedu/address/logic/parser/ParserUtil.java
95.53% <100.00%> (+1.21%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14cbfc9...2622536. Read the comment docs.


Tmux script

Tmux script
What user problem are we solving?
Not a user problem, it's an internal solution.
What solution does this PR provide?
This solution provides a tmux script that seamlessly spins up both the backend and frontend instances. The instances will run in the background.
Testing Methodology
How did you test your changes and verify that existing
functionality is not broken
Started with a fresh repo pull and fresh install of WSL and ran through instructions to deploy the script. No issues with on my machine. Currently working on both Mac and PC.
Any other considerations
When deploying on Windows, since there's more steps there's more room for package issues and problems with WSL. But the script itself isn't faulty.

looks good. for the tmux instructions, can you put it in the form of a readme.md file. would be nice to centralize? @noah-iversen

can u also add instructions on how to set convenient tmux shortcuts for shifting btwn windows in a given tmux session?

The script is good; like Karthik said, it would be helpful to add instructions (like in the README) on how to actually run the tmux script and what does it do. Conditionally approved


Create Quicksends for Procedure Lists to the Todo system automation API endpoint

(this can also be streamlined further in Python to reduce frontend work)

The Geological Sampling Component already has a system of automating this, and you can take a look there for inspiration

Completed by Abhi during in-person work session on 3/25


"/" incorrectly required before ">", RWD Beta

Affected page
https://www.freecodecamp.org/learn/2022/responsive-web-design/learn-basic-css-by-building-a-cafe-menu/step-17

Your code

<meta charset="utf-8" />
*note the extra space and the slash shouldn't be there*

solution also requires an extra slash near the end:
<link rel="stylesheet" type="text/css" href="styles.css"/>
*note that the forward slash is required to pass the challenge*

Expected behavior
A) Expected not to see a space and forward slash before the closing less than sign of the meta element.
B)Expected to clear the stage without having to insert a forward slash.
Screenshots

System

Device: LG G6 and Samsung Tablet
OS: Android 9
Browser: Firefox Nightly
Version: 97

Additional context
See the forum for a screenshot and Roma's solution:
https://forum.freecodecamp.org/t/rwd-beta-colored-markers-need-help-or-to-verify-bug/490422/11

meta is self-closing element, / is not required in it, but that don't seem to be an error per se. As far as I can tell both versions with / and without are accepted by tests.
Similarly link is self-closing, so it appears that both with / and without it should be fine. Some tests don't allow version without /.  Apparently, you use a /> closing tag with link if you're using HTML5. The thing is up until this point, all self-closing elements we've worked with (like img and meta) have not required it. Perhaps what is needed here is further explanation on the instruction portion of the exercise.

Weird that prettier auto-closes meta tags with />.
I'd be fine with making the / optional in these tests.

If they're both valid, ideally, they would both pass.
This PR should be getting in soon, which can help us with these tests. The reason they're all in regex is cause some of these elements weren't being rendered as hoped. link elements, for example, were rendering in the body of the preview, not the head. When that PR gets in, it should render those as they appear in the code. Then, we can use JavaScript to check the DOM on where these element live and don't have to worry about the syntax. I wouldn't oppose a PR to fix the regex tests, but it might be easier to wait for that PR and fix these after that using JS.

The above referenced PR has been merged. We should be good to move forward with updating the tests to move away from Regex and use DOM queries.

I was trying to implement this today and ran into an issue. It looks like the link tag is removed from the DOM in this piece of code. This makes it impossible to do DOM test cases when it requires including styles.css. As a test, I removed line 222, and the new DOM test cases I wrote passed without a problem
https://github.com/freeCodeCamp/freeCodeCamp/blob/06071cfbcf7c3a3a25f84fdf17777d8d87b59f76/client/src/templates/Challenges/rechallenge/transformers.js#L210-L222
A few questions:

What was the purpose of removing link tags from the DOM? (Original PR: #42205)
Can we modify / remove the code in the addImportedFiles to work with the DOM-style test cases?

FYI @moT01 @nhcarrigan

There's some context in that PR you linked @Ne0nWinds. "They were causing 404 errors to appear in the console, so I figured it was simpler just to remove them entirely"
I guess a few console errors might not be the worst thing, but I think we probably want to leave it how it is (remove them) if we can. It looks like we've been using regex on those few tests elsewhere.

Okay, I can start working on making these regex tests better. Though, I think, if there's a way we can do it through DOM queries, we should definitely do that, because they're going to be more reliable and easier to maintain

I had an idea that would potentially solve this. What if instead of removing the link tag, we change the href to a data:href property (more on this here). Without an href property, the link tag won't make an actual http request, so this would solve the problem of 404 errors. However, we still have access to the link tag for DOM query test cases
The only weird part would be this one test case:
// Your `link` element should have an `href` attribute with the value `styles.css`.
const element = document.querySelector('link');
assert.equal(element.dataset.href, 'styles.css');

The rest of the test cases can use the standard getAttribute function

While that does neatly solve the 404 issue, it is no longer realistic - it's not how to add css to a page.
As much as possible, we want to keep the experience of working in the editor equivalent to working with raw html, css and JavaScript.

While that does neatly solve the 404 issue, it is no longer realistic - it's not how to add css to a page.
As much as possible, we want to keep the experience of working in the editor equivalent to working with raw html, css and JavaScript.

So the user would still put in this in the code editor:
<link rel="stylesheet" type="text/css" href="styles.css" />

but the code transformer could do something like this:
link.removeAttribute("href");
link.dataset.href = "styles.css";

So the code the user puts in is still exactly the same as in real code, but behind the scenes, it's transformed to something we can use for the test cases

Thanks for explaining, it's an interesting idea. Would be interested in creating a PR so we can test this out?

Yeah! I'll get a PR out this weekend

Hey @ojeytonwilliams, if you can look at the PR I just referenced, that would be great!


Machine linux-11 went dead from network monitoring website.

Is there an existing issue for this?

[X] I have searched the existing infra issues

Type of Request
infra task
Infrastructure Environment
LUCI, Github, Cocoon scheduler, Autosubmit, etc...
What is happening?
Machine linux-11 went dead from network monitoring website.

Steps to reproduce
Step 1:
Step 2:
..
Step n:
Expected results
I expect to see X when Y is finished.

linux-11 is up and running fine, I can login remotely from my desk. Will look into more details.
flutter@flutter-devicelab-linux-11:~$ uptime
09:07:26 up  1:41,  1 user,  load average: 0.40, 0.08, 0.03

Machine linux-11 was hung and require power recycle machine.


add confirm prompt for some profiler actions

This PR fixes #12171

also rearrange the actions to move 'clear data' next to the start/stop group

Pull Request Test Coverage Report for Build 481942041

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.213%

Totals

Change from base Build 481550643:
0.0%

Covered Lines:
24388

Relevant Lines:
51754

💛  - Coveralls

Pull Request Test Coverage Report for Build 481942041

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 43.213%

Totals

Change from base Build 481550643:
0.0%

Covered Lines:
24388

Relevant Lines:
51754

💛  - Coveralls


time condition

Hi,
how can i use trigger for pre-defined time, once a day?
thanks :)

You mean you don't want define the exact time but only want something be triggered once in a day, am i right?

I want that something will happen in exact time, onca a day.

OK, I got it. So I think u don't need trigger at all, AlarmManager can do it well.
Set a alarm via AlarmManager for sending a custom broadcast, and then register a receiver for this broadcast, while you receive the broadcast, do the thing. Just set the interval time to 24h then you will got it once a day. How about this?

I wanted to avoid using AlarmManager...
Never mind, thank you :)


plot_lcmv_beamformer.py isn't working

I ran the examples plot_lcmv_beamformer.py but it fails with this error:
RuntimeError: label and stc must have same subject names, currently "lcmv-free-lh.stc" and "sample"

@yousrabk also got the same error.

I think @yousrabk has found the solution.

Ow nothing huge... we were changing the subject name for the label but not for stc (done only in save)


Upload progress not working in 2.20.0

Please describe the bug in detail
With the upgrade from 2.19.2 to 2.20.x the Upload progress hook is no longer working.
uploading is not refreshing the uploading.total and uploading.loaded.
 const { uploading } = useRequest(uploadPoster);
  return (
    <>

File size: {uploading.total}B

Uploaded: {uploading.loaded}B

Progress: {(uploading.loaded / uploading.total) * 100}%

   </>

I made a remark on Discord  earlier.
My code follows the https://alova.js.org/tutorial/combine-framework/download-upload-progress.
I could make a Sandbox for this, but it isn't easy as it requires backend code to upload the file stream.
Reproduce link
No response
steps to reproduce
try the code at https://alova.js.org/tutorial/combine-framework/download-upload-progress/
expected performance
No response
alova version
2.20.0 and 2.20.1
device/browser/browser version
No response
additional content
No response

@JOU-amjs  fixed, waiting for PR merge #340

@proddy Sorry, It's my mistake. And it happens that the upload function cannot be unit tested.😂 Now it was fixed at v2.20.2

Thanks for the fix. Could you also fix the loaded and total - you have them inverted. loaded is showing the total file size of the upload data and total is showing the progress :-)

cheers!

Thanks for the fix. Could you also fix the loaded and total - you have them inverted. loaded is showing the total file size of the upload data and total is showing the progress :-)

Now that was fixed. please update @alova/adapter-axios or @alova/adapter-xhr to latest version.

all fixed now, thanks!


tests: add capi test for json->gif saver

https://github.com/thorvg/thorvg/pull/2417 has to be merged first, will rebase after it's merged


Open mails inline

In my opinion, this was the best feature of Inbox by Google - opening messages inside the mail list.
Perhaps it can be replicated by modifying the horizontal split layout a bit?

@Madis0 if you would like this feature please form the code and do a pull request.


Harbormaster build results in 404 when tried to trigger Jenkins URI

Harbormaster build step: Make HTTP Request
URI: https://my.ci.example/buildByToken/buildWithParameters?job=my-project-name&DIFF_ID=${buildable.diff}&PHID=${target.phid}&token=secret
Result:
Jenkins didn't give any responses, build failed with 404

I tried to do "Build with Parameters" in Jenkins by filling DIFF_ID and PHID manually from the failed build and it worked.
I'm not sure, but seems like something wrong with the URI.

In Jenkins job, navigate to "Build Triggers" --> "Trigger builds remotely" --> insert the token
Problem solved

Is there anything we could do to help clarify this in the documentation?
On Wed, Feb 1, 2017 at 9:45 AM Tesar Gusmawan<EMAIL_ADDRESS>wrote:

In Jenkins job, navigate to "Build Triggers" --> "Trigger builds remotely"
--> insert the token
Problem solved
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/uber/phabricator-jenkins-plugin/issues/202#issuecomment-276727526,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAF7P9QDu2kI0xdcERz5qgCo8UaL48_mks5rYMS7gaJpZM4L0JAT
.

In Jenkins job, navigate to "Build Triggers" --> "Trigger builds remotely" --> insert the token
Problem solved

also make sure "Build Authorization Token Root" plugin has installed in Jenkins

Shouldn't that bit of information be part of the README? Yes, I can submit a PR, but I'm astonished nobody has done so before.


Create Docker-compose to make it easier

Create Docker-compose to make it easier to upload the container with Face Recognition. With volume for photo persistence.

Feel free to create a pull-request as soon as you're ready :)


[DOC] Double Trouble

Refer to transfer() function explanation within - https://github.com/lukso-network/LIPs/blob/main/LSPs/LSP-7-DigitalAsset.md
You'll see duplicate text:

hey @Heisenburgirs - one is with SenderNotification and the other bullet point is with RecipientNotification

or is it confusing?

Ohh... you're right, didn't notice it, I was going through it quickly.
Maybe have distinction between them:
When token recipient supports LSP1 interface:
....
When token sender supports LSP1 interface
...

@CJ42

I will close this issue here. I opened a PR in the LIPs repo:
https://github.com/lukso-network/LIPs/pull/286


alsa-scarlett-gui: add alsa-utils to PATH

alsa-scarlett-gui tries to call alsactl when saving a configuration, which fails, when alsa-utils is not on the PATH
Description of changes

Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[ ] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[ ] Fits CONTRIBUTING.md.

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:
https://discourse.nixos.org/t/prs-already-reviewed/2617/1083


look up default region_params

Looks up the default region params from settings.toml every time the main gateway  is swifched. Then swithc back as soon as the assserted parameters come back into play from the region_params stream

Do we want proto branch to be merged before this goes in?

Yeah this isn't quite complete as a PR yet..


Logging bug

Fixed logging to work properly in the MC (Issue #80).  Now both MPFMC logging entries and entries originating in the Kivy code are contained in the same log file.  The default Kivy logging code has been overridden.
Also fixed a sound library priority issue (couldn't diagnose what was happening without logging functioning properly).

Coverage decreased (-0.06%) to 70.621% when pulling 504d0f4693f88e92f87ea5c11f31bfa08e34a684 on logging-bug into 35f0b277c0bfaf4e87e046af3579d7eff8f6fd3f on dev.

Coverage decreased (-0.06%) to 70.621% when pulling c189a069013e16157523b819b2d694aa5f1afc9f on logging-bug into 35f0b277c0bfaf4e87e046af3579d7eff8f6fd3f on dev.

Coverage decreased (-0.06%) to 70.621% when pulling c189a069013e16157523b819b2d694aa5f1afc9f on logging-bug into 35f0b277c0bfaf4e87e046af3579d7eff8f6fd3f on dev.

Coverage decreased (-0.1%) to 70.588% when pulling a51c0e81ab4e969bb61384ffad490310c97cc8b3 on logging-bug into 35f0b277c0bfaf4e87e046af3579d7eff8f6fd3f on dev.

Coverage decreased (-0.2%) to 70.528% when pulling 5bcf3098ce05e0c29569591f87f560aa2e99c3b4 on logging-bug into 35f0b277c0bfaf4e87e046af3579d7eff8f6fd3f on dev.

Coverage decreased (-0.2%) to 70.496% when pulling 534718e2ab667f069dac16645d1a8f6f0c1b3895 on logging-bug into 35f0b277c0bfaf4e87e046af3579d7eff8f6fd3f on dev.

Coverage decreased (-0.2%) to 70.528% when pulling 9d2b7adcd738b778f278a71023d3d6f804c850bc on logging-bug into 35f0b277c0bfaf4e87e046af3579d7eff8f6fd3f on dev.


CFDev suddenly stops working with EOF

CFDev suddenly stops working with EOF
Hey, so as part of an E2E test suite I have a client which communicates with cfdev and frequently creates/deletes organizations, asserts the existance of organizations, service-brokers and service offerings.
A problem that I've stumbled upon is that I can run my test suite only one, max 2 times, because cfdev stops working at some point so my calls eventually fail.  This is very inconvenient, because the only solution I've found so far is to restart cfdev, which costs me at least 20min.
I'd be happy to get some pointers as to where to look, why cfdev might be crashing, any logs I can check..
Thanks!

@NickyMateev Depending on how rigorous your test suite is, your CF Dev instance might be running out of RAM. If your workstation has some to spare, it might be worth starting CF Dev with the -m flag  in order to allocate more memory to the VM.

@aemengo They really aren't that rigorous. I also had that assumption so I tried executing only one of the tests which only creates 3 organizations and registers a couple of service-brokers. Everything seems okay on the first run, but on the second I start getting this error.
I even tried setting the memory parameter to 12GB, alas it did not help..

Certainly a bit odd...
Well the VM is still up and kicking if you even get that response at all but the internal deployment is in a bad state. There's really isn't much to go on, plus we've never really seen the phenomenon that you're describing. If you're able to give us some reproduction steps, we'll be happy to look further into it.

Well I had some assumptions and theories what might be causing the issue and tried deriving smaller code samples which attempt to prove my assumptions, but I couldn't really reproduce the issue in an isolated context. So I'm still not sure what might be the issue.
I'm closing this issue, since it's so high-level and not concrete and when I do have some progress I can post an update here.
It would be helpful if I knew where I could look at some logs related to the CF deployment itself so that I can inspect it in different scenarios.


Suggested Changes

I am new to GitHub and code-sharing in general, so I am not sure how to go about suggesting edits, but I'll take a shot at it.
First of all, this set of code has been TREMENDOUSLY helpful. Previously we had been opening .tdms files in excel, and saving them as text files from there for importing into MATLAB. This was a very tedious process. So thank you!
I changed quite a bit of the 'simpleConvertTDMS' to fit the specific needs of our research lab at Brigham Young University. Along the way, I noticed several things that may, in my opinion, make this cleaner and/or more general.
One of these is to remove lines 112:116, replacing them with the MATLAB function 'matlab.lang.makeValidName()' and 'matlab.lang.makeUniqueStrings()'. As in:
safeChannelNameValid = matlab.lang.makeValidName(channelNames,'ReplacementStyle','delete','Prefix','d');
safeChannelName = matlab.lang.makeUniqueStrings(safeChannelNameValid);
The first would be used for calling structure fields, while the second would be used for making the new ones later on.
There are several other general changes I've made as well, but not sure how to go about suggesting them, as typing them all out here seems a bit of a hassle.
Let me know if I could submit all of my changes for review.
Thanks.

Thanks - I will take a look at your suggestion.  for github, what you
would do is:

Create a "Pull Request" with any comments or suggestions instead of
emailing them.  Then when I incoprate the changes, I reference the pull
request.
If you want to make the changes, you first clone and then fork my
repository.  Once you have made the changes, you or I merge the changes
back into the repository.

I will take a look at your suggestion below.  If you have others, please
feel free to do the pull request or fork.
Regards,
Brad
On 05/07/2015 11:30 AM, bradybus wrote:

I am new to GitHub and code-sharing in general, so I am not sure how
to go about suggesting edits, but I'll take a shot at it.
First of all, this set of code has been TREMENDOUSLY helpful.
Previously we had been opening .tdms files in excel, and saving them
as text files from there for importing into MATLAB. This was a very
tedious process. So thank you!
I changed quite a bit of the 'simpleConvertTDMS' to fit the specific
needs of our research lab at Brigham Young University. Along the way,
I noticed several things that may, in my opinion, make this cleaner
and/or more general.
One of these is to remove lines 112:116, replacing them with the
MATLAB function 'matlab.lang.makeValidName()' and
'matlab.lang.makeUniqueStrings()'. As in:
safeChannelNameValid =
matlab.lang.makeValidName(channelNames,'ReplacementStyle','delete','Prefix','d');
safeChannelName = matlab.lang.makeUniqueStrings(safeChannelNameValid);
The first would be used for calling structure fields, while the second
would be used for making the new ones later on.
There are several other general changes I've made as well, but not
sure how to go about suggesting them, as typing them all out here
seems a bit of a hassle.
Let me know if I could submit all of my changes for review.
Thanks.
—
Reply to this email directly or view it on GitHub
https://github.com/humphreysb/ConvertTDMS/issues/4.


[SURE-9358] Downstream AKS cluster shows credential error

SURE-9358
Rancher EU dev was upgraded to 2.9.2.
After failed attempts to upgrade downstream AKS cluster due to the bug reported via case# 01557031, the cluster has an error in Rancher UI regarding failed client secret connecting to Azure.
More information in JIRA.

Troubleshooting steps have been shared with customer and now waiting for feedback.


Allow protocol 0

Hi,
thanks for pointing me to your fork, regarding Smart Card Resource Manager not running errors that I encountered in Windows. It seems to work now.
However, the original library allows me to perform DIRECT connection to the reader for perhipherals control. The requirements are following: SCARD_SHARE_DIRECT for mode and 0 for protocol.
Now your fork overrides protocol 0 in https://github.com/pokusew/node-pcsclite/blob/master/lib/pcsclite.js#L117
I propose to merge from original repo so that the changes in https://github.com/santigimeno/node-pcsclite/blob/master/lib/pcsclite.js#L92 are in effect.
Boris

Hi @boris-savic
Thank you for your proposal.
I merged the proposed changes into my fork and released new version 0.4.17 to npm.
Now my fork includes all the features from the original library and on top of that it fixes the errors on Windows.
I would like to recommend you my another library for working with NFC.
Take a look at nfc-pcsc. It offers easy to use high level API for detecting, reading and writing NFC tags and cards, also supports Promises and sync/await.
Hope it helps.


[BEAM-11308] Update deprecated Google GitHub action

GoogleCloudPlatform/github-actions/setup-gcloud became deprecated and it is recommended to use google-github-actions/setup-gcloud

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

cc @aaltay @kamilwu @potiuk

Thank you!


Email sign up doesn't clear after submit

The input field for the email sign up should clear itself out after someone clicks the submit button.
https://github.com/drewclem/protege/blob/master/src/components/Footer.js

I can work on this if that's ok

That'd be fantastic. Ping me if you need anything

Thanks! I had a couple of min and I'm ready to submit the pull request. Quick question, should I request to merge to Master or Development branch?

PR to development

Sounds good. PR (#67) submitted!


Synchronize triage configuration

This pull request was created automatically by the sync-triage-config workflow.

User stole some of my actions


ToC Munger not exactly the same as github bookmarks

Strip disallowed characters such as = from heading, prior to converting to bookmark name.

Can you give an example? the munger strips all chars that match '[A-Za-z0-9-]' from bookmarks which should include =

#11611

It should be solved by #11420

Ya, it should be fixed on github markdown at least. #11611 bookmarks work on github markdown before and after. Was it not working on k8s.io?

@mikedanese I found that on k8s.io, the bookmark of Type = LoadBalancer should be #type-loadbalancer instead of #type--loadbalacer
Looks like it works differently on github markdown versus k8s.io

@johndmulhausen Any idea whether this is still an issue?


What are the long term plans for this project?

As a heavy user of SlackTextViewController, I came here immediately after reading about your project in iOS Dev Weekly. The goal is ambitious: "A SlackTextViewController replacement written in Swift for the iPhone X." Sounds fantastic, but the reality isn't up to the hype quite yet 😄
I'm not trying to be an ass; what you have so far looks great. Could you maybe update the home page or comment on this issue to give some more details on what you hope to accomplish? The version number is pretty low so I imagine it is a work in progress. Do you see this as a total replacement for STVC and the majority of its features or is it more narrowly focused? Is more of the messaging-related functionality in GitHawk going to be migrated into MessageViewController? Do you have a roadmap in mind for things like input buttons / toolbar, typing indicator, Edit mode, gestures, animations? Are you looking for contributors or do you intend to get closer to a 1.0 release before you open it up more?
-Eli

App great questions! And ones that I haven’t put a lot of thought into. I’ll try to work on a vision doc sometime to express my thoughts.
It’s definitely not a total STVC replacement yet. There are missing features like edit mode and left buttons. But for a simple resizing text view for messaging, this is pretty much all you need.
I don’t plan on adding any messaging functionality to this project as I think that implementing table or collection views should be completely decoupled from an input text view (prob my biggest gripe with STVC).
Really great questions, I’m glad you asked!
Sent with GitHawk

Love this project already, love this issue too. I was looking for a lightweight replacement for slacktextviewcontroller. Will be interested to see the vision for the project! <3

@eliburke If you are looking for something with more buttons/functionality I suggest you take a look at my repo https://github.com/nathantannar4/InputBarAccessoryView It is what we use at MessageKit

@nathantannar4 InputBarAccessoryView looks great - so why doesn't this project leverage that work considering you are a collaborator on this project? If I use InputBarAccessoryView now for the extra buttons functionality that I need, will I be wanting to migrate across to MessageViewController in a few months when that's added here in this project? I also need an edit mode, so if I develop that, which project is most likely to take a merge request?

@enhancient both had different beginnings. I started mine for MessageKit and Ryan did his for GitHawk. Ryan has many more followers than me though so this library gained a large following quickly so I wanted to contribute with something I would find useful in GitHawk.
Aside from different origin stories, both have quite different architectures. MessageViewController is a UIViewController subclass where was InputBarAccessoryView is an InputAccessoryView.
Ryan is really nice about PRs and I'm happy to have one on mine to. If you had to make a choice between the two you would have to look at what you project needs and which is better for it.
Sent with GitHawk

@nathantannar4 thanks, that's useful 👍


Compilation with compilation options not working

I'm trying to use nvcc4jupyter under Google Colab, using nvcc compilation options, but unsuccessfully.
If I use %%cuda -c "-l curand", the Colab's code box says:
usage: colab_kernel_launcher.py [-h] [-t] [-p] [-l PROFILER] [-a PROFILER_ARGS] [-c COMPILER_ARGS]

%%cuda magic that compiles and runs CUDA C++ code in this cell. See
https://nvcc4jupyter.readthedocs.io/en/latest/magics.html#cuda for usage details.

options:
  -h, --help            show this help message and exit
  -t, --timeit
  -p, --profile
  -l PROFILER, --profiler PROFILER
  -a PROFILER_ARGS, --profiler-args PROFILER_ARGS
  -c COMPILER_ARGS, --compiler-args COMPILER_ARGS
usage: colab_kernel_launcher.py [-h] [-t] [-p] [-l PROFILER] [-a PROFILER_ARGS] [-c COMPILER_ARGS]
colab_kernel_launcher.py: error: argument -c/--compiler-args: expected one argument

Normal compilation without options works correctly.

Hello! That indeed does not work and I'll try to figure out why as soon as I find some time.


Unsupported --include-verbatim argument

I'm not entirely sure whether it's better to open the issue here or with lychee itself: it relates a little to the release process for both. But I encountered it here, so opening here.
From this repository's README:

See lychee's documentation for all possible arguments.

As a user, I diligently read the docs and see --include-verbatim listed. On trying that flag:

error: Found argument '--include-verbatim' which wasn't expected, or isn't valid in this context

and then get puzzled :thinking:
Then I realise it's because --include-verbatim was added after the current latest versioned release of lychee (0.9.0). And this action uses the 0.9.0 release.
This inconsistency would be fixed by a new release of lychee and then updating the image here.

(I'm trying lychee out for one or two projects and it looks really good, by the way; thanks! :heart:)

You're right. I was waiting for https://github.com/lycheeverse/lychee-action/issues/115, but I guess it's fine if we just create a new release right away.

Version 1.5.0 with lychee v0.10.0 was just released. ☺


Module Warning

FVTT is generating one warning for this module.

I will remove that with the next update


[FR] SW Licence and BOM

Please verify that this feature request has NOT been suggested before.

[X] I checked and didn't find a similar feature request

Problem statement
Hi i could not find any other matching item.
In my products we sometimes require a SW lic to be solled along the product. hence i have added it to the BOM. this is not a stock item but we need to keep track of them and pay royalties at the end of each quarter. so it would be nice if we could keep track on the amount of licences sold.
is there any way to do this or could something like this be implemented
Suggested solution
allow a part to be part of a bom and have no stock but still be able to sell the product.
I have also been playing with purchase order. an thought of keeping the order open for a quarter and make partial deliveries or something but not sure if that would work.
Describe alternatives you've considered
see above. made the part a consumable but i have no idea how i can track it per quarter or what ever other periode
Examples of other systems
No response
Do you want to develop this?

[ ] I want to develop this.

as a note i have also played with the Virtual part, as i think this is what i am looking for.

but i could not close the order when using virtual parts. perhaps this type of item requires more eplanation in the docs??

I don't think that the "no stock" is consistent with "keep track of number sold". It sounds like you need to keep stock, perhaps tracked based on serial number?

Tallying up usage after a certain period sounds more like the job of a plugin IMO. @mabroens would that be a solution or can you be more specific on what (usage flow, how the part type would act in certain situations) you would want to see implemented to close this FR?


execution MlkitOcr.detectFromFile(path) or MlkitOcr.detectFromFile(path) produce an error

Hello , thanks for your help.
i try to use this library and i have an error when a try to use the principal methods :
const resultFromUri = await MlkitOcr.detectFromUri(uri);
const resultFromFile = await MlkitOcr.detectFromFile(path);
result : ---> error : [TypeError: null is not an object (evaluating 'MlkitOcr.detectFromFile')]
thanks for your help.
i use expo .

It looks like it not detect the package
Did you run npm install react-native-mlkit-ocr ??
Did you run build again?

@epoq see https://github.com/agoldis/react-native-mlkit-ocr/tree/main/example for setup example, not clear what's your setup like

@agoldis, thank you for making this package!
There is no example using detectFromFile in this repository, there's only for detectFromUri.
I'm getting "No image path provided" even though I absolutely am
No image path provided
at node_modules/react-native/Libraries/BatchedBridge/NativeModules.js:104:50 in promiseMethodWrapper
at node_modules/react-native-mlkit-ocr/src/index.tsx:76:18 in MLKit.detectFromFile
at node_modules/react-native-mlkit-ocr/src/index.tsx:76:18 in MLKit.detectFromFile


Fix Invalid value for 'cursor' for partition index '0'

Fix invalid cast of 'None' to String
Re-enabled skipped tests

All tests pass

lgtm

paired with @wbevans on review, tested and all test passed


feat: liquid readonly wallets

feat: liquid readonly
refactor: static build by default

Superseded by https://github.com/BoltzExchange/boltz-client/pull/203


BUG: OKIT 0.60.0 and 0.61.0 generates incorrect TF code for DRG

OKIT generates Terraform (TF) scripts that attempt to set the default route pointing to the DRG attachement which is wrong, it should be pointing to the DRG itself. See examples below from network.tf file.
 Not being able to generate TF code for DRGs is a big limitation of the tool.

Reverted functionality to DRGv1 in release 0.63.0


Error at boot but the plugin still seems to work

I get this error at when the server is booting -
[15:01:48] [Server thread/WARN]: java.lang.NullPointerException: Cannot invoke "de.maxhenkel.voicechat.voice.server.ServerVoiceEvents.getServer()" because "de.maxhenkel.voicechat.Voicechat.SERVER" is null [15:01:48] [Server thread/WARN]: 	at voicechat-bukkit-1.19.2-2.3.1.jar//de.maxhenkel.voicechat.plugins.impl.VoicechatServerApiImpl.registerVolumeCategory(VoicechatServerApiImpl.java:171) [15:01:48] [Server thread/WARN]: 	at custom-discs-2.1.1.jar//me.Navoei.customdiscsplugin.VoicePlugin.onServerStarted(VoicePlugin.java:63) [15:01:48] [Server thread/WARN]: 	at voicechat-bukkit-1.19.2-2.3.1.jar//de.maxhenkel.voicechat.plugins.PluginManager.dispatchEvent(PluginManager.java:70) [15:01:48] [Server thread/WARN]: 	at voicechat-bukkit-1.19.2-2.3.1.jar//de.maxhenkel.voicechat.plugins.PluginManager.onServerStarted(PluginManager.java:101) [15:01:48] [Server thread/WARN]: 	at voicechat-bukkit-1.19.2-2.3.1.jar//de.maxhenkel.voicechat.voice.server.ServerVoiceEvents.<init>(ServerVoiceEvents.java:36) [15:01:48] [Server thread/WARN]: 	at voicechat-bukkit-1.19.2-2.3.1.jar//de.maxhenkel.voicechat.Voicechat.lambda$onEnable$0(Voicechat.java:127) [15:01:48] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftTask.run(CraftTask.java:101) [15:01:48] [Server thread/WARN]: 	at org.bukkit.craftbukkit.v1_19_R1.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:483) [15:01:48] [Server thread/WARN]: 	at net.minecraft.server.MinecraftServer.v(MinecraftServer.java:1156) [15:01:48] [Server thread/WARN]: 	at net.minecraft.server.MinecraftServer.lambda$spin$1(MinecraftServer.java:310) [15:01:48] [Server thread/WARN]: 	at java.base/java.lang.Thread.run(Thread.java:833) [15:01:48] [Server thread/INFO]: Done (34.491s)! For help, type "help"

Thats a bug from the Simple Voice Chat developer. Im pretty sure there is a new update that fixes it.

Yup that was the problem, I didn't realize that the plugin was being hosted on CurseForge and not Spigotmc.org, because on Spigotmc.org it says last updated "Aug 7" so I didn't click on the download button since first installing the plugin.
Thanks and I don't know if that is a side effect but the audio quality of my custom disc has increased now that I updated.


CCSDS APID Name Space Expansion

Expand the cFS Software Bus topic name space using extensions to the CCSDS Space Packet secondary header. Within the cFS architecture the CCSDS Primary Header APID is used as a unique system-wide topic identifier.
This ticket is intended to address several issue with the current CCSDS Space Packet APID topic name space

Difficulties allocating and managing the limited number of APIDs during development
Insufficient number of APIDs for large systems
APID allocations for formation flying, distributed systems, multi-core, and partitioned systems
Loss of spacecraft and subsystem identifying information as packets traverse the network stacks

Implementation of the extended header will include a compile time directive to include or disable extended header support. See attached file for header format.

Trac comment by glimes on 2016-11-08 14:17:08:
Current crop of cfe-next are all going into CFE 6.6

Imported from trac issue 175.  Created by jwilmot on 2016-10-24T13:48:13, last modified: 2019-03-05T14:58:28

Trac comment by jwilmot on 2017-03-20 13:42:18:
Pushed commit [changeset:96270e9] ready for CCB review

Trac comment by cdknight on 2017-02-28 14:49:29:
Consider making functions like CFE_SB_GetMsgId into #define macros.
For example, the CFE_SB_GetMsgId function only does one thing--it calls CCSDS_RD_SID (which is a macro itself.)
This will improve performance of these calls (effectively in-lining, although some optimizers might be inlining this code anyways.)
Disadvantage is it makes debugging a touch trickier, as you can't put a breakpoint on a macro.
(This might be better as a separate ticket, as the current smaller APID-space could benefit from this as well.)

Trac comment by mdeschu on 2017-10-12 16:26:06:
Commit [changeset:07374ea]  - Original Implementation - Rebased on 10/10 development branch at [changeset:19ff113]
Action Items
Commit [changeset:00cf20d] - AI 1,6,19,20,21
Commit [changeset:ac5baec] - AI 2
Commit [changeset:a12a5d8] - AI 3
Commit [changeset:e7e7f0b] - AI 5
Commit [changeset:85a62db] - AI 7
Commit [changeset:124691e] - AI 9, 13
Commit [changeset:d880345] - AI 10, 11
Commit [changeset:035040a] - AI 12
Commit [changeset:63af1d0] - AI 14
Commit [changeset:05956a4] - AI 17
Commit [changeset:72986ec] - AI 18
Commit [changeset:a2d0698] - AI 23 and 24
Commit [changeset:393d15d] - AI 22
Issues found during unit testing
Commit [changeset:b003bae]
Cleanup
Commit [changeset:a08f91c]

Trac comment by cdknight on 2017-03-21 15:17:01:
I suggest we have a compile-time option to allow for a hash for the routing table. I think this could be considered independently of this ticket, so I've created another ticket #217 but thought I'd mention it here.

Trac comment by mdeschu on 2017-10-13 12:50:16:
Changesets related to unit tests
Commit [changeset:f4b36cc]

Trac comment by mdeschu on 2017-10-20 10:06:07:
Remaining action item changes and squashed everything into a single commit on mjd-ic-trac175-merge branch.
Commit [changeset:b68417f]

Trac comment by glimes on 2017-10-22 11:06:00:
Mike D's merge is now in testing. This requires coordinated
changes outside the CFE project:

cfs_test: update sample_defs to match CFE cmake sample_defs
cfs_tools: update SB unit test Makefile to include the new source file

With those updates in place, we have GREEN status from Bamboo.

Trac comment by mdeschu on 2017-10-23 18:32:41:
Follow-up cleanup commit [changeset:21dcfbb] submitted for review

Trac comment by mdeschu on 2017-10-23 18:33:53:
Replying to [comment:6 mdeschu]:

Commit [changeset:07374ea]  - Original Implementation - Rebased on 10/10 development branch at [changeset:19ff113]
Action Items
Commit [changeset:00cf20d] - AI 1,6,19,20,21
Commit [changeset:ac5baec] - AI 2
Commit [changeset:a12a5d8] - AI 3
Commit [changeset:e7e7f0b] - AI 5
Commit [changeset:85a62db] - AI 7
Commit [changeset:124691e] - AI 9, 13
Commit [changeset:d880345] - AI 10, 11
Commit [changeset:035040a] - AI 12
Commit [changeset:63af1d0] - AI 14
Commit [changeset:05956a4] - AI 17
Commit [changeset:72986ec] - AI 18
Commit [changeset:a2d0698] - AI 23 and 24
Commit [changeset:393d15d] - AI 22
Issues found during unit testing
Commit [changeset:b003bae]
Cleanup
Commit [changeset:a08f91c]

Squashed above changes into [changeset:b68417f]

Trac comment by jphickey on 2017-10-24 08:49:05:
I have pushed a branch trac-175-proposed-id-key-fixes commit [changeset:a5b0b4d] which addresses the mismatches between msgkey and msgid among other things.
Please review so we can discuss this today.

Trac comment by sstrege on 2017-10-24 12:50:48:
Mike's follow up clean-up commit addressing the new actions assigned at the 10/20/17 CCB is ready for review: [changeset:21dcfbb]

Trac comment by jphickey on 2017-10-24 13:00:31:
Another strongly recommended commit to add on:
[changeset:f94c96b] branch trac-175-apidq-cleanup
With the way the APIDQ header was defined, it was repeated in both the primary and secondary headers.  This is incorrect.  The other issue with this is that code which instantiated their headers based on sizeof(CFE_SB_CmdPkt_t) would not actually allocate enough space for the APIDQ header.
This cleans it up and addresses the issues by including the APIDQ header within in CFE_SB_Msg_t.

Trac comment by jphickey on 2017-10-24 13:24:51:
Updated commits:
[changeset:c00a11a] First set

Trac comment by glimes on 2017-10-24 14:14:54:
Commit [changeset:f94c96b] just went through a quick Bamboo test. Looks good, aside from a cppcheck style note that should be in Quarantine.
{{{
cfe/fsw/cfe-core/src/sb/cfe_sb_priv.h:424: style: Redundant condition:
If MsgId <= 8191, the comparison MsgId != 65535 is always true.
}}}

Trac comment by jphickey on 2017-10-24 14:16:12:
Second set: [changeset:76b6d2a4]

Trac comment by glimes on 2017-10-24 14:17:17:
Triggered Bamboo testing for the second set.

Trac comment by glimes on 2017-10-24 14:20:45:
Triggered bamboo for second set with mjd ccsds v2 config

Trac comment by mdeschu on 2017-10-24 15:21:43:
Modified changeset of 21dcfbb is now [changeset:a6e3d70]
Moved function header CFE_SB_MsgHdrSize comment along with function prototype

Trac comment by jhageman on 2019-03-05 14:58:28:
Milestone renamed

Trac comment by glimes on 2017-10-27 14:33:28:
integrated 2017-10-25


Most enjoyable font for Colorduino Scrolling Text

Greetings
My question does not concern your library but directly the fonts of the sketch "Colorduino Scrolling Text" that you have part.
I would like to use a more beautiful font in the project but I do not know how to do it;
Maybe, include in the sketch header, like this: #include <Fonts \ etc., .h>
But you already have included in the arduino library "glcdfont" in the folder "Adafruit_GFX" with this program.
Could you please give me a hint how to do it?  My thanks in advance

Could you please provide me with the font file you wish to use

Here: https://github.com/adafruit/rpi-fb-matrix/blob/master/glcdfont.c
She comes to the Adafruit_GFX library
Thanks a lot

It appears to be due to the fact that that is a 5x7 font whereas the colorduino uses an 8x7 font. You could try appending 3 0x0 at the beginning of ever line. Its also very possible that the order of the characters in their font is not the same as the colorduino font. I have a python3 script here for you that can decode the byte strings into pretty output so you can see what each line is.
import sys
byte_string = sys.argv[1].split(", ")
binary_string = []
transposed_string = ["","","","","","","",""]
for byte in byte_string:
	binary_string.append(bin(int(byte, 16))[2:].zfill(8))
for binbyte in binary_string:
	for i in range(0,len(byte_string)-1):
		transposed_string[len(byte_string)-1-i] += binbyte[i]
for line in binary_string:
	for i in range(0,8):
		if(line[i] == '1'):
			print('\033[91m1\033[0m', end='')
		else:
			print('0',end='')
	print('')

Sorry, I could not understand what you instructed me, but I'll try to add the 3 0x0 at the beginning of each line in font 5x7.
And about updating 'ColorduinoScrollerLibrary' for Arduino 1.8.5 seems cool.
But it's a pity that it only works with a Colorduino; Would not I have a way to add an I2C slave (not Master) to work with 2 or 3 Colorduino? Most users like to use various Colorduino, especially for scrolling text;  Thank you++

For the new code, add two 0x00 to the front, and 1 to the end of that font library. You will also have to match up the order to be the same as font.c
In regards to working for other boards, it should be relatively easy to change as long as you have a function that sets a pixel at a specific x and y for your display
In regards to multiple displays, I will be adding that feature back in shortly through the use of a starting delay. I currently do not have 2 colorduinos in order to test, but I will endeavour to borrow one in the coming weeks. You are welcome to try and introduce i2c signaling between boards, but keep in mind that i2c is also being used to drive the display.

Adding 3 0x0 at the beginning of each line did not work; I'll be waiting for you to upgrade your last library to 'multiple displays' because I do not have enough knowledge for this. Thanks again


Crash

I get this Crash with the newest Open Mods lib version 405.
Crashlog:
https://gist.github.com/Dream-Master/5239f236f1279edf1cd0#file-openmodslib

Expected. I'm currently in middle of rewriting part of code. Also OpenMods/OpenBlocks#722.
Also, not "version". Snapshot. Only official releases are guaranteed to work.

It is not a complain only a crash i post.


backend function benchmark

c.py, cuda.py, and opencl.py

returning the times array would offer more flexibility than returning the mean of times[1:-1], e.g. when you're interested in the distribution of the times required.
variable iterations seems to be more at home as .benchmark(self, func, gpu_args, threads, grid, iterations=7) than as an instance variable (self.iterations)
if the times[1:-1] construct is to remain, we should add a check that assert len(times) >= 3, "not enough iterations."
it is currently not possible to adjust the number of iterations of a benchmark using the public interface

yeah I agree, I also had that at some point in branch, but never merged those changes.
true, except for the fact that it does not make sense to use a different number of iterations every time you call benchmark.
when we return an array of times removing the fastest and slowest runs can be something that the user may want to do themselves.
I'm fine with adding an option to tune_kernel for this.

What I want for this issue is to return the average as we have now as 'time' in the tuning results. But in addition to that we can return all measured execution times using for example the name 'times'.
The iterations option has been added to public interface. Checking that it's at least 3, or not compute the average in that way if it's less than three is still a good idea.

As part of the sprint, I would like to check this issue and see if I can work on it.

Made a branch with the change. All tests are passing, and I added two tests for the times.


setInterval and other browser APIs are not defined

Not sure if it's related but localStorage, window, document, setInterval, etc have a weird behavior too.
view: render error ReferenceError: setInterval is not defined

when wrapped inside a if (typeof document != "undefined") or anything that v8 will appreciate, everything is fine, console.log included
Originally posted by @ldlac in https://github.com/livebud/bud/issues/87#issuecomment-1140170072

Hey, thanks for pointing this out @ldlac. I definitely need better docs here, but views are server-side rendered with V8, the hydrated on the client, so your top-level statements in Svelte have the same restrictions as you would have in SvelteKit, Next.js, etc.
The difference is that they use Node.js to do SSR, so it has things like setInterval, while Bud uses V8. So TL;DR:

localStorage, window, document cannot be used top-level right now and no plans currently to support them. Your views need to work outside of the browser environment for the initial render [^1]
setInterval: should be supported. Getting this working should be pretty easy thanks to this excellent library which looks like it has an interval library.

[^1]: I have thought about adding a minimal DOM implementation to V8 via https://www.npmjs.com/package/undom. I'm not sure if this is a good idea though because it may hide errors. At the same time it would be quite a bit more convenient for people that understand what's happening, you wouldn't need to wrap your addEventListener in a typeof document != undefined for example.


test(frontend): use absolute path for src imports

CATEGORY

[x] Refactor
[x] Build / Development Environment

SUMMARY
This changes all JS imports in specs to use absolute path, which makes the code a little bit easier to read and shall make rearranging the test files easier.
Added a jsconfig.json for VS Code so that intellisense can still work.
Also upgraded prettier to fix lint.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TEST PLAN
Make sure CI passes and other IDEs also have no problem using JS features.
ADDITIONAL INFORMATION

[ ] Has associated issue:
[ ] Changes UI
[ ] Requires DB Migration.
[ ] Confirm DB Migration upgrade and downgrade tested.
[ ] Introduces new feature or API
[ ] Removes existing feature or API

REVIEWERS
@kristw @rusackas @villebro

Codecov Report

Merging #9761 into master will decrease coverage by 0.01%.
The diff coverage is 89.65%.

@@            Coverage Diff             @@
##           master    #9761      +/-   ##
==========================================
- Coverage   70.81%   70.80%   -0.02%
==========================================
  Files         586      586
  Lines       30445    30444       -1
  Branches     3121     3120       -1
==========================================
- Hits        21559    21555       -4
- Misses       8772     8775       +3
  Partials      114      114

Flag
Coverage Δ

#cypress
53.65% <42.10%> (-0.08%)
:arrow_down:

#javascript
59.06% <75.86%> (-0.01%)
:arrow_down:

#python
70.93% <ø> (ø)

Impacted Files
Coverage Δ

...rontend/src/SqlLab/components/QueryAutoRefresh.jsx
65.90% <ø> (-6.82%)
:arrow_down:

...erset-frontend/src/SqlLab/components/SqlEditor.jsx
55.12% <ø> (ø)

superset-frontend/src/explore/AdhocFilter.js
97.26% <ø> (ø)

...set-frontend/src/explore/actions/exploreActions.js
44.77% <50.00%> (ø)

.../explore/components/controls/DateFilterControl.jsx
56.36% <75.00%> (ø)

superset-frontend/src/SqlLab/actions/sqlLab.js
66.81% <85.71%> (ø)

superset-frontend/src/SqlLab/components/App.jsx
77.77% <100.00%> (ø)

...set-frontend/src/SqlLab/components/QuerySearch.jsx
57.54% <100.00%> (ø)

...rset-frontend/src/SqlLab/components/QueryTable.jsx
59.25% <100.00%> (ø)

superset-frontend/src/chart/chartAction.js
59.50% <100.00%> (ø)

... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b430ea...93aeede. Read the comment docs.

Jeez... I keep spending forever looking at these things, and then when I'm done, I look up and see Merged 🤣Again, this looks great, and thanks.


Appstudio update hacbs-test-project-chns

Pipelines as Code configuration proposal
To start the PipelineRun, add a new comment with content /ok-to-test
For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun
To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

Pipelines as Code CI has failed.There was an error creating the PipelineRun: hacbs-test-project-chns-on-pull-request-
cannot patch pipelinerun hacbs-test-project-chns-on-pull-request-: failed to patch pipelinerun rhtap-demo-prjc-tenant/logURL with hacbs-test-project-chns-on-pull-request-fznsk: pipelineruns.tekton.dev "hacbs-test-project-chns-on-pull-request-fznsk" not found


Discussion: UsedOnTable extension design would make more sense on the DataObjects themselves

Affected Version
4.7+
Description
https://docs.silverstripe.org/en/4/developer_guides/files/file_usage/
The current design for declaring ancestor objects, excluded and replaced classes on the UsedOnTable class is confusing. It doesn't make much sense to extend the UsedOnTable class to describe specific data objects; these methods make more sense on the data objects themselves. When you have lots of different classes to report ancestors for, for instance, the method size grows massively or you need multiple extensions each doing instanceof checks just to do something that could be declared very cleanly and simply on each data object class.
Before:
    public function usage(HTTPRequest $request)
    {
        $usage = ArrayList::create();

        $record = $this->getRecord() ?: DataObject::create();
        if ($record->canView()) {
            $excludedClasses = [];
            $this->extend('updateUsageExcludedClasses', $excludedClasses);

            $usage = $record->findAllRelatedData($excludedClasses);

            $this->extend('updateUsage', $usage, $record);
        }

        $usageData = [];
        foreach ($usage as $dataObject) {
            $this->extend('updateUsageDataObject', $dataObject);
            if (!$dataObject) {
                continue;
            }

            $tableRowData = [
                'id' => $dataObject->ID,
                'title' => $dataObject->getTitle() ?: _t(__CLASS__ . '.UNTITLED', 'Untitled'),
                'type' => ucfirst($dataObject->i18n_singular_name()),
                'link' => $dataObject->hasMethod('CMSEditLink') ? $dataObject->CMSEditLink() : null,
                'ancestors' => []
            ];

            $ancestorDataObjects = [];
            $this->extend('updateUsageAncestorDataObjects', $ancestorDataObjects, $dataObject);
            foreach ($ancestorDataObjects as $ancestorDataObject) {
                $tableRowData['ancestors'][] = [
                    'title' => $ancestorDataObject->getTitle() ?: _t(__CLASS__ . '.UNTITLED', 'Untitled'),
                    'link' => $ancestorDataObject->hasMethod('CMSEditLink') ? $ancestorDataObject->CMSEditLink() : null,
                ];
            }
            $usageData[] = $tableRowData;
        }
        $response = HTTPResponse::create(json_encode(['usage' => $usageData]));
        $response->addHeader('Content-Type', 'application/json');
        return $response;
    }

After:
    public function usage(HTTPRequest $request)
    {
        $usage = ArrayList::create();

        $record = $this->getRecord() ?: DataObject::create();
        if ($record->canView()) {
            $excludedClasses = $record->getUsageExcludedClasses();

            $usage = $record->findAllRelatedData($excludedClasses);
        }

        $usageData = [];
        foreach ($usage as $dataObject) {
            $dataObject = $dataObject->updateUsageDataObject();
            if (!$dataObject) {
                continue;
            }

            $tableRowData = [
                'id' => $dataObject->ID,
                'title' => $dataObject->getTitle() ?: _t(__CLASS__ . '.UNTITLED', 'Untitled'),
                'type' => ucfirst($dataObject->i18n_singular_name()),
                'link' => $dataObject->hasMethod('CMSEditLink') ? $dataObject->CMSEditLink() : null,
                'ancestors' => []
            ];

            $ancestorDataObjects = $dataObject->getUsageAncestorDataObjects();
            foreach ($ancestorDataObjects as $ancestorDataObject) {
                $tableRowData['ancestors'][] = [
                    'title' => $ancestorDataObject->getTitle() ?: _t(__CLASS__ . '.UNTITLED', 'Untitled'),
                    'link' => $ancestorDataObject->hasMethod('CMSEditLink') ? $ancestorDataObject->CMSEditLink() : null,
                ];
            }
            $usageData[] = $tableRowData;
        }
        $response = HTTPResponse::create(json_encode(['usage' => $usageData]));
        $response->addHeader('Content-Type', 'application/json');
        return $response;
    }

This much cleaner (IMO) implementation passes the power to the data object and removes the ugly instanceof checks shown in the documentation. It also makes much more sense to someone digesting the concept for the first time because it's more logically similar to how other things are done in SilverStripe.
If you're worried about losing the ability to extend this functionality, then you can simply add to the method a little:
Before:
    // ...
        $excludedClasses = $record->getUsageExcludedClasses();
    // ...
        $dataObject = $dataObject->updateUsageDataObject();
    // ...
        $ancestorDataObjects = $dataObject->getUsageAncestorDataObjects();
    // ...

After:
    // ...
        $excludedClasses = $record->getUsageExcludedClasses();
        $record->extend('updateUsageExcludedClasses', $excludedClasses);
    // ...
        $dataObject = $dataObject->updateUsageDataObject();
        $record->extend('updateUsageDataObject', $dataObject);
    // ...
        $ancestorDataObjects = $dataObject->getUsageAncestorDataObjects();
        $record->extend('updateUsageAncestorDataObjects', $ancestorDataObjects);
    // ...

It doesn't make much sense to extend the UsedOnTable class to describe specific data objects

I'm a bit confused by this, I don't think the intention is to ever extend the UsedOnTable class (which is actually a FormField)
My main issue with this recommendation is that we've gone from a single standardised way to define the ancestor objects to two ways, which I'm not a fan of.  I've tweaked your code example a little to add a method_exists check
        if (method_exists($dataObject, 'getUsageAncestorDataObjects')) {
            $ancestorDataObjects = $dataObject->getUsageAncestorDataObjects();
        }
        $record->extend('updateUsageAncestorDataObjects', $ancestorDataObjects);

There's also another issue that some project out there may by chance have already defined a getUsageExcludedClasses  / getUsageDataObject / getUsageAncestorDataObjects method independently on subclass of DataObject.  We have no way of detecting this.  This would cause the used on table to mysteriously break on their projects.

This much cleaner (IMO) implementation passes the power to the data object and removes the ugly instanceof

I'll be upfront and say the likelihood that we'll look to refactor this code in order to add a second way to configure the used on table, which is adding complexity, is pretty low.


kernel/x86_64/interrupts: print more information regarding unhandled interrupts

https://github.com/CascadeOS/CascadeOS/blob/4559ee625d1d5575896fa0407e7d5337cbb03300/kernel/arch/x86_64/interrupts/interrupts.zig#L46-L55

Part of the problem with the current code is it only walks the backtrace within the interrupt context and provides no information about what was executing when the interrupt was generated when that is meaningful (exceptions).

I tried to do a simple stack walk but using the RBP from the exception did not work.
More investigation is required.


Cake in offline environment.

Hi Team,
I am setting up cake script in Jenkins CI system in offline environment ,(i.e. : no connection to the outside internet )
I was able to do so with editing few steps in the build.ps1 script. I am still have some issue when the script does not check if the build need to restore nugets , although it needs. ( SkipToolPackageRestore,)
I was wondering Is there a manual on how to do it as best practice.
Thanks

@eldadc this needs to be written up into an article, but i recorded a video about this here:
https://youtu.be/wkPN9CZCZFM

THANKS .

Thanks on the detailed session.
I have 2 issues that were not cover.
What are the changed in the script I put the package.config and nuget in UNC folder in the network. ?
Today my package.config is part of the project i notice that the SkipToolPackageRestore is set always skipping nuget restore.

@Eldadc you should not need to make any changes to the packages.config file.  For using a UNC path, the required changes should be similar to those that were made in the video.  In the video I had assumed that the source would need to be changed to be an internal NuGet Server, for example Nexus.  If using a UNC path, you should be able to switch to using that, rather than the http address of the NuGet server.
I am not sure what you mean by this part:

Today my package.config is part of the project i notice that the SkipToolPackageRestore is set always skipping nuget restore.

Can you elaborate?
If you wanted to, I would be happy to talk about this further: https://officehours.io/people/gep13

Hi,
Thanks on the detailed answer and follow up.
UNC - got it ,  Do I need any adjustment with the PS syntax ?
I debug my build.ps1 and I noticed that SkipToolPackageRestore will skip the restore package commands although there are no packages.  I store my tools\package.config file in my source control.
Do I need to edit also the SkipToolPackageRestore switch ? , Can I remove the "if" check statement and always restore nuget packages.
Thanks In Advanced,

Have a look here:
https://blog.nuget.org/20150922/Accelerate-Package-Source.html
For further information.
No, you shouldn't need to edit any of that.  In order for your build to work, you will still need to restore things, it is just that you are restoring from an internal location, rather than from the internet.


The website and documentation are inaccessible and showing error page

I can't open the website http://camaleon.tuzitio.com/

Fixed, thanks for reporting!


Allow cast from bigint to regclass

Summary of the changes / Why this improves CrateDB
Casts from int to regclass are already supported. We can allow casts
from bigint to regclass as well - as long as the values fall into int
range.
Closes https://github.com/crate/crate/issues/12648
Checklist

[x] Added an entry in CHANGES.txt for user facing changes
[x] Updated documentation & sql_features table for user facing changes
[x] Touched code is covered by tests
[x] CLA is signed
[x] This does not contain breaking changes, or if it does:

It is released within a major release
It is recorded in CHANGES.txt
It was marked as deprecated in an earlier release if possible
You've thought about the consequences and other components are adapted
(E.g. AdminUI)

Does it worth adding tests for other types (Int, String)?
Also for RegoprocType?

https://github.com/crate/crate/blob/9a857e3204467365f0163f204eab51e9cdb1c212/server/src/test/java/io/crate/types/TypeConversionTest.java#L47 covers the number conversions if it's allowed. Not sure why I would add string now, as I didn't touch that?

https://github.com/crate/crate/blob/9a857e3204467365f0163f204eab51e9cdb1c212/server/src/test/java/io/crate/types/TypeConversionTest.java#L47

covers the number conversions if it's allowed.
Thx!

Not sure why I would add string now, as I didn't touch that?

I know, just mentioned for completeness of testing all the casts.


golang transition: osd debug pod reports success without actually deploying pod

The debug pod deployment seems not to wait for OSD debug pod to come up in golang version
[root@centos-16gb-fsn1-1 kubectl-rook-ceph]# ./bin/kubectl-rook-ceph debug start rook-ceph-osd-0
Info: fetching the deployment rook-ceph-osd-0 to be running

Info: deployment rook-ceph-osd-0 exists

Info: setting debug command to main container
Info: deployment rook-ceph-osd-0 scaled down

Info: waiting for the deployment pod rook-ceph-osd-0-6ff4845cf5-scmsg to be deleted

Info: ensure the debug deployment rook-ceph-osd-0 is scaled up

when used krew published rook-ceph module current version:
[root@centos-16gb-fsn1-1 ~]# kubectl rook-ceph debug start rook-ceph-osd-0
setting debug mode for "rook-ceph-osd-0"
Info: setting debug command to main container
Info: get pod for deployment rook-ceph-osd-0
Info: scale down the deployment rook-ceph-osd-0
deployment.apps/rook-ceph-osd-0 scaled
Info: waiting for the deployment pod "rook-ceph-osd-0-debug-6565559576-g9g56" to be deleted
error: timed out waiting for the condition on pods/rook-ceph-osd-0-debug-6565559576-g9g56

Info: deployment rook-ceph-osd-0 scaled down

Info: waiting for the deployment pod rook-ceph-osd-0-6ff4845cf5-scmsg to be deleted

Looks like code error

@travisn looks like a blocking issue,
Will test tmr

i see debug pod deployed now, not able to reproduce locally.


some bugfixes to be compatible with latest goshimmer cliwallet

bump :)

Sorry for the late merge. But thanks for your contribution ❤


Update sphinx to 4.1.2

Newest version, lots of bug fixes and improvements:
https://pypi.org/project/Sphinx/

LGTM, though we may want to merge this after the release just in case there are problems that are not caught.

sounds good!


Update artifactory.md > Artifactory is a registry

linked to

https://github.com/endoflife-date/endoflife.date/pull/4250

See https://github.com/endoflife-date/endoflife.date/pull/4253#issuecomment-1850953453.


Many messages types fail to parse to JSON due to message database errors.

As currently released (d212681f1952704e50e9c8977891dd024c3338ae), the library is unable to parse many of the most widely used OEM log messages.  The root cause appears to be duplicate field names in the message database file. These duplicate names result in fields being overwritten as the JSON output is generated.
The follow message types are incompletely parsed:
ALIGNBSLNENU
ALIGNBSLNXYZ
BESTGNSSPOS
BESTGNSSVEL
BESTPOS
BESTUTM
BESTVEL
BESTVELX
BESTXYZ
BSLNXYZ
CLOCKMODEL
DATUMTRANSFORMATIONS
DUALANTENNAHEADING
GLOEPHEMERIS
GPGGA
GPGGALONG
GPGRS
GPGSA
GPHDT
GPHDTDUALANTENNA
HEADING2
HEADINGRATE
INSCONFIG
INSPVAX
INSVELUSER
MASTERPOS
MATCHEDPOS
MATCHEDXYZ
PDPPOS
PDPVEL
PDPXYZ
PPPPOS
PSRPOS
PSRVEL
PSRXYZ
QZSSEPHEMERIS
ROVERPOS
RTKPOS
RTKVEL
RTKXYZ
SATEL9INFO
SATXYZ2
SBAS25
TILTSTATUS
TSS1

Example
BESTXYZ is a good example of a message that fails to parse completely.  Given this input message from an OEM7 receiver:
#BESTXYZA,COM2,0,83.0,FINE,2224,420105.000,02a40000,44cf,16407;SOL_COMPUTED,SINGLE,-1286545.8180,-4720990.4770,4079927.8880,1.8344,3.8956,3.7563,SOL_COMPUTED,DOPPLER_VELOCITY,-0.0088,0.0278,-0.0261,0.2193,0.4656,0.4490,"",0.000,0.000,0.000,9,7,7,7,0,06,00,03*710498e8

EDIE produces the following JSON outputs for the header and body of the message.
Header: (this looks fine)
{"IdleTime":83.0,"MessageFormat":1,"MessageId":241,"MessageLength":276,"MessageName":"BESTXYZ","MessageSource":0,"MessageTime":420105000,"MessageTimeStatus":160,"MessageWeek":2224,"ReceiverSWVersion":16407,"ReceiverStatus":44302336,"ReponseID":0,"SequenceNumber":0,"port":0}

Body: (this has errors)
{"eMyPositionStatus":"SOL_COMPUTED","eMyPositionType":"SINGLE","dMyX":-0.0088,"dMyY":0.0278,"dMyZ":-0.0261,"fMyXStdDev":0.21930000185966492,"fMyYStdDev":0.46560001373291016,"fMyZStdDev":0.4490000009536743,"eMyStatus":"SOL_COMPUTED","eMyType":"DOPPLER_VELOCITY","acMyBaseID":"","fMyLatency":0.0,"fMyDifferentialLag":0.0,"fMySolutionAge":0.0,"ucMyNumTracked":0,"ucMyNumInSolution":0,"ucMyNumInSolutionSingleFreq":0,"ucMyNumInSolutionDualFreq":0,"cCharAsInt":0,"ucMyExtendedSolutionStatus":0,"ucMyGALandBDSSignals":0,"ucMyGPSandGLOSignals":0}

Note that the ECEF XYZ position components have switched from "-1286545.8180,-4720990.4770,4079927.8880" to "-0.0088, 0.0278, -0.0261".  Those are the ECEF velocity parameters and the position parameters are completely lost. This appears to stem from reuse of field names in the message definition database.
This problem is widespread and affects 45 different message types. Here is a list of the messages with duplicate fields, which was generated with this simple Python script:
import json
import sys

def check_db(fn):
    with open(fn, 'r') as f:
        db = json.load(f)
    print("Loaded {} message definitions".format(len(db)))
    for msg in db:
        has_dupes = False
        s = "Msg {} has duplicate fields\n".format(msg["name"])
        fields = set()
        field_num = 0
        for f in msg["fields"]:
            name = f["name"]
            if name in fields:
                has_dupes = True
                s += "  field {:2}: {}\n".format(field_num,name)
            fields.add(name)
            field_num += 1
        if has_dupes:
            print(s)

if __name__ == "__main__":
    if len(sys.argv) != 2:
        print("Usage: {} <JSON DB>".format(sys.argv[0]))
        sys.exit(1)
    check_db(sys.argv[1])

I suspect the novatel_message_definitions.json file is machine generated, so I am going to hold off on issuing a pull request with manual fixes.

Thank you for your contribution and effort in this issue. I wanted to update you that this issue has already been addressed in the latest version of EDIE.


Does use translations

I can't get forms rendered with fieldnames, help_text etc translated.
Seems as if it doesn't use any of it

Sorry, I missed using gettext_lazy in one location.


NoBlackBars.js patching with same byte

NoBlackBars is replacing the push 01 with 01

I always wondered why the bars still show...

The correct mod seems to be 00. Not sure if I should pull, you probably already did it

xD I went the 74 to jmp method but should I even make a pull? Seeing as its redundant with HideNPCCurtains functioning, hmm regardless I'll make a pull, Kanan you decide xD

The transcription error was mea culpa. Sorry about that!
It was indeed supposed to be:
// Hide NPC Curtains During NPC Conversations And Cutscenes (Step29)

var pattern = scan('8B 8E F8 00 00 00 85 C9 74 07 6A 01 E8 ?? ?? ?? ?? 8B 0D');

patch(pattern.add(11), 0x00);

On a somewhat related note, was this one ever released here, maybe under a different guise?:
// Disable Anamorphic Widescreen in Cutscenes (Step29)

var pattern1 = scan('38 06 74 1B');
var pattern2 = scan('0F B7 ?? ?? 50 57 57 57 E8 ?? ?? ?? ?? 84 C0 0F 84');

patch(pattern1.add(2), 0xEB);
patch(pattern2.add(15) [0x90, 0xE9]);

NoMatteBox.js.zip

So, we have two scripts that do essentially the same exact thing. HideNPCCurtains.js patches the function that gets called, and NoBlackBars.js patches one of the six places that function gets called...
Since HideNPCCurtains.js patches the actual function I think it's the one we should keep.
Thoughts?

Function:

Works for all cases using that function.
More likely to survive updates in general.

May cause issues where it's called when not intended.

Call:

Works for just one specific use case instead of all.

Less likely to survive updates.

So if all cases are desired and there's no graphical issues with it always being the modified copy, I vote stick with the function patch for people who want this removed in general.

I thought to myself maybe HideNPCCurtains only applies it to NPCs and skips over the ones in cutscenes, nope, looks like they do the same thing.
I'd go for function too based on Rydian's facts.

Went with removing the script that patched the call and kept the script that patched the function.
Let me know if this causes any issues but I don't think it will.


Can RewardCriterion backward() get the correct gradient?

Hi Ruotian,
I read your notes in Zhihu as well. Your note helps me a lot.
Thank you so much.
One concern for me is, as formulation (9) in "Self-critical Sequence Training for Image Captioning" indicates the way to calculate the gradient, can the default Pytorch backward() function get the correct gradient?  The formulation (9) directly calculates the gradient of S_t which is the input of softmax layer, while in my mind the default Pytorch backward() is for the gradient of the output of softmax layer.
Cheers,
Jiaying

The input of the rewardcriterion is the output of logsoftmax. This loss itself doesn't have theoretical meaning; the loss is defined in this way so that if you take backward on the loss, the gradient got is exactly equation 9.

Thank you for your reply.

For this gradient(differentiating L(theta) with log(p_theta)), will the -(r-b) updates every index in the dict-dimension vector or only the index of sampled word in the dict-dimension vector?
P.S. 为了防止英文说不清楚。
想请教下，L(theta)对 logp_theta求导的话，-(r-b)会更新到softmax输出向量的每一维度，还是类似于cross-entropy只更新target_index那一维度呢？


[Feature Request]: Global Error Handler with Custom Errors

Preflight Checklist

[X] I have read the Contributions.md for this project.
[X] I agree to follow the Code of Conduct that this project adheres to.
[X] I have searched the feature for a feature request that matches the one I want to file, without success.

Problem Description
We don't have a global error handler in the code base right now.
Proposed Solution
Use proper error handler which can be replaced by default express error handler.
Also need all catch blocks to redirect to that error handler.
And have multiple error classes for different errors like validation error, Login Error, etc.
Alternatives Considered
NA
Additional Information
No response

Assign me this mentor @Shubham-Kumar-2000 ...Participant from gssoc'22

Sure Assigned

Hi @anipaul2 any update on this?

Sorry mentor my exams will finish tomorrow and after that will give full time to it. Just give me three more days mentor.

Hi @anipaul2 any update on this?

Will start from today, working on this mentor..Thanks for letting me do this till now.

Hi @anipaul2  any update on this??

Hi @anipaul2 any update on this??

Working on it. facing some issue so didn't raised a pr.

@Shubham-Kumar-2000 raised a pr. please review!


Invalid prop activeComponent of type object

I have upgraded styled-components to version 4.1.1 and using<EMAIL_ADDRESS>with<EMAIL_ADDRESS>and now I'm getting a warning about invalid prop passed down to the components tree:
Warning: Failed prop type: Invalid prop `activeComponent` of type `object` supplied to `Feature`, expected `function`

I'm using clean-tag as well:
export const StyledWrapper = styled(tag.div)<StyledWrapperProps>`
  ${space}
  ${width}
  ${fontSize}
  ${fontWeight}
  ${fontFamily}
  ${textAlign}
  ${color};
  ${bgColor};
  ${border};
  ${borderColor};
  ${borderRadius};
  ${lineHeight};
`;

Apparently it doesn't clean up  activeComponent prop for some reasons. Do you have an idea about the potential fix?

Any new on this topic?


No such file or directory: '/tmp/build/80754af9/numpy_and_numpy_base_1603487797006/work'

@lixiangMindSpore Has the issue been resolved?


Restructured conditionals

Restructuring in an attempt to fix problem with constantly trying to repair 100% durability items

Added some restructuring as low level characters in particular constantly try to repair 100% durability items (such as self repairing ones, or low durability ones), this seems to alleviate it in my case


Link to docs in README is broken

A link to the documentation in README is broken:
https://paritytech.github.io/pwasm-std/pwasm_std/index.html
When opened it shows 404 error

fixed


fix: don't replace err variable in nested check

We can use := to make err local to the if-scope instead of overwriting the err in outer scope.

This bug also exists in 1.17 (so I guess also in 1.18) -- worth backporting


HSEARCH-4204 Expose the Elasticsearch index names in the metamodel API

https://hibernate.atlassian.net/browse/HSEARCH-4204

Feel free to merge when they are solved. And don't forget to apply the same changes to the backport :)


A poll on the Embedding class

    def __init__(self, d_model, vocab):
        super(Embeddings, self).__init__()
        self.lut = nn.Embedding(vocab, d_model)
        self.d_model = d_model

    def forward(self, x):
        return self.lut(x) * math.sqrt(self.d_model)

Do you know why return the look up table by multiplying a constant d_model?

In our model, we share the same weight matrix between the two embedding layers and the pre-softmax linear transformation, similar to (cite). In the embedding layers, we multiply those weights by  $\sqrt{d_{\text{model}}}$.

Thanks, does this paper explained why to multiply the constan d_model mathematically?

Not sure but in my DL lectures said "for numerical stability" :)


Probleme with 'cacheEnabled' parameter and Amazon S3

Hi guys, I use Imager-Craft and it's awesome !
However, I've got a problem with the cache.
I use an Amazon S3 to upload my transformed files (everything works like a charm), but when I put the parameter 'cacheEnabled' to 'false', Imager still generates local cached images.. And I dont want to.
If someone can help me, thank you a lot !

Even if you choose to upload the transformed files to S3, Imager will still create the image transform on the server, and put it in the imagerSystemPath. Those files act as a file-based cache, and also makes it possible to turn S3 integration off, and still have the transformed files available.
The cacheEnabled setting doesn't really have anything to do with this, by setting it to false you're just telling Imager to do the transform on every single load, which is rarely necessary even in development.

Hi @aelvan, I think I'm in a similar boat here.  Hoping to only upload the images to S3 and not to save locally since I only plan on serving them from S3..  I figured this would be useful for cutting down transform processing times a little and also I wouldn't need to worry about space on my server..
Is this possible?


vscode: fix tmGrammar issues around non-controlflow keywords

Addresses some of the issues mentioned here: https://github.com/dustypomerleau/rust-syntax/issues/5.
In sync with https://github.com/dustypomerleau/rust-syntax/issues/6.

bors r+
Happy with these changes. For those themes that make a storage/keyword distinction it adds consistency.


Upgrade node version

When using this action, the jest tests are failing now in CI after I upgraded to  webpacker 5 with error like...
<EMAIL_ADDRESS>The engine "node" is incompatible with this module. Expected version ">=10.17.0". Got "10.14.1"
Can you please upgrade the node version in your docker file by changing this: FROM node:10.14.2-alpine

I got the same error.

Have you check the README? You probably don't need this action!

I got the same error.


limit the max size of raft entry

If entry exceed the max size, reject to propose it.
@disksing Should we handle the new error(RaftEntryTooLarge) in TiClient?
@siddontang @BusyJay @disksing PTAL

Looks like we should handle it particularly. For unknown region errors the default behavior is clear cache and retry.

Please add a test.

LGTM

PING

LGTM


Find a better USB-C connector

In the box construction, mounting the USB connector is a huge pain in the backside because of the need to use a Dremel to make the box thinner.  At some point, I should try to find a pass-through connector with a round hole, which would be easier to work with, and recommend that instead.

Found a better one from Adafruit, but currently out of stock.  Still good enough to offer it as a more ideal alternative.


bin folder renamed to _ after update, breaking all shortcuts?

Type: Bug
I went to open VS Code today, but all of the shortcuts were invalid, and attempting to run it from command line also failed. (I am running Windows 10)
When I investigated further, I found that previously, the Code.exe was located in ~/AppData/Local/Programs/Microsoft VS Code/bin/ but as of this morning, it is now located in ~/AppData/Local/Programs/Microsoft VS Code/_/.
The only thing that has changed is the update to 1.89.1. Unfortunately I have no steps to reproduce this.
 For example, the path of my files icudtl.dat, resources.pak and so on has changed from ~/AppData/Local/Programs/Microsoft VS Code/ to ~/AppData/Local/Programs/Microsoft VS Code/_/, which causes my VS Code fail to start. I resolved this by coping all the files located in ~/AppData/Local/Programs/Microsoft VS Code/_/ into ~/AppData/Local/Programs/Microsoft VS Code/. But I don't know if this will cause other problems and I keep the folder "_". I want to know how to deal with the folder "_".

Happened to me now after updating to 1.96.0
Version: 1.96.0 (user setup)
Commit: 138f619c86f1199955d53b4166bef66ef252935c
Date: 2024-12-11T02:29:09.626Z
Electron: 32.2.6
ElectronBuildId: 10629634
Chromium: 128.0.6613.186
Node.js: 20.18.1
V8: 12.8.374.38-electron.0
OS: Windows_NT x64


Add task to restart lsync after repo-build

(cherry picked from commit 5bd4eee9f8e6d018182ee391acec77e3cea6a347)

:+1:

rebase


while trying to run training on custom dataset [Rolodex] for detection, it is failing with signal 6 abort , please help me resolve this.

To report a bug, please provide the following:

the output of the darknet version command

Darknet v2.0-226-g39868921
CUDA runtime version 12020 (v12.2), driver version 12020 (v12.2)
cuDNN version 12020 (v8.9.6), use of half-size floats is ENABLED
=> 0: Tesla T4 [#7.5], 14.7 GiB
OpenCV v4.5.4

the exact command you ran

!darknet detector train  Rolodex.data rolo.cfg yolov4-tiny.weights Rolodex.names

the operating system you are using

Google colab/kaggle notebook with GPU enabled Linux
If relevant, please attach a screenshot showing the problem.
please find the below screen shot of same error .

Note the command you ran is invalid.  The proper training command is documented in the FAQ and in the README.  See:  https://www.ccoderun.ca/programming/yolo_faq/#training_command

Thanks for your quick response @stephanecharette , it was because -dont_show argument missing in train command .
Thanks again !! 😄

Thanks for your quick response @stephanecharette , it was because -dont_show argument missing in train command . Thanks again !! 😄

No, that is not the problem.  Please see the training command as documented in the readme or in the FAQ.

I already told you -- twice! -- that you are running an invalid command.  I cannot help you if you refuse to read.
Please read the FAQ and/or read the README which tells you the command you should be running.

Thanks again @stephanecharette  ,training is successful ..second issue was because of corrupt dataset .Request you to add a feature to export  it to onnx format .💐


Publish doc updates

Docs Build status updates of commit 1461bef:
:white_check_mark: Validation status: passed

File
Status
Preview URL
Details

docs/add-ins/addin-tutorial.md
:white_check_mark:Succeeded

docs/add-ins/quick-start.md
:white_check_mark:Succeeded

docs/includes/note-yeoman-generator-bug-201908.md
:white_check_mark:Succeeded

For more details, please refer to the build report.
Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.


IAM UseIdTokenHttp example flakes

GCB: https://console.cloud.google.com/cloud-build/builds;region=us-east1/2a73162a-0e6f-4b0c-962c-5efb2f6ba6cc;tab=detail?project=cloud-cpp-testing-resources
Raw: https://storage.googleapis.com/cloud-cpp-community-publiclogs/logs/google-cloud-cpp/main/83fd2b6c234ae4dd9c492d0e8328404e72949ef8/fedora-36-xsan/log-2a73162a-0e6f-4b0c-962c-5efb2f6ba6cc.txt

//examples:grpc_credential_types                                         FAILED in 63.3s

Running UseIdTokenHttp() example
Standard exception raised: Could not contact server after 3 attempts

The gRPC call to generate the id token was successful. We throw away the Status from HttpGet though.

This has not repeated in 90d, but I am tempted to remove the test, I am not sure it adds enough value.


Add a logging BreachHandler

Thank you for contributing to naz.
Every contribution to naz is important.
Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.
Now,
What(What have you changed?)

Why(Why did you change it?)

References:

Codecov Report

Merging #149 into master will increase coverage by 0.01%.
The diff coverage is 89.28%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   86.33%   86.34%   +0.01%
==========================================
  Files          14       14
  Lines        1295     1318      +23
==========================================
+ Hits         1118     1138      +20
- Misses        177      180       +3

Impacted Files
Coverage Δ

naz/logger.py
89.88% <89.28%> (-1.03%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d18dd96...4b77fa4. Read the comment docs.


closes #1293. allows aliases that start with @ to be caught as internal

@ljharb as we talked about in the issue, here is the fix. Please let me know if there are any issues. Or if you think we need more tests for this case. I added one. There were already a ton that didn't pass and didn't think I should fix them in this PR.

Coverage decreased (-0.5%) to 93.651% when pulling 91a439c54f9087cd6ced89d32bc3d8f296f8478e on jeffshaver:master into bdc05aa1d029b70125ae415e5ca5dca22250858b on benmosher:master.

Coverage decreased (-0.5%) to 93.651% when pulling 91a439c54f9087cd6ced89d32bc3d8f296f8478e on jeffshaver:master into bdc05aa1d029b70125ae415e5ca5dca22250858b on benmosher:master.

Coverage decreased (-0.5%) to 93.651% when pulling 91a439c54f9087cd6ced89d32bc3d8f296f8478e on jeffshaver:master into bdc05aa1d029b70125ae415e5ca5dca22250858b on benmosher:master.

Coverage decreased (-0.5%) to 93.651% when pulling 91a439c54f9087cd6ced89d32bc3d8f296f8478e on jeffshaver:master into bdc05aa1d029b70125ae415e5ca5dca22250858b on benmosher:master.

Coverage decreased (-0.5%) to 93.651% when pulling 91a439c54f9087cd6ced89d32bc3d8f296f8478e on jeffshaver:master into bdc05aa1d029b70125ae415e5ca5dca22250858b on benmosher:master.

Coverage decreased (-0.5%) to 93.651% when pulling 91a439c54f9087cd6ced89d32bc3d8f296f8478e on jeffshaver:master into bdc05aa1d029b70125ae415e5ca5dca22250858b on benmosher:master.

@ljharb updated per your comments. Appreciate you looking at this!

@ljharb anything I can do to help unbreak master?

@jeffshaver open another PR that fixes the tests? :-D

@ljharb. I'll take a look later today to see if I can fix some

@ljharb since my other pr got merged (thanks! sorry we couldn't fix that one test), i rebased my branch with upstream master. just wanted to let you know

@jeffshaver oh we fixed it! thanks for the PR, and the ping.

@ljharb appreciate it! When do you think a new version will be released with these changes?

Probably not super quickly; ping me again in a week if it’s not done by then.

Have the PR been released? My '@' alias imports are still 'unknown' type with the latest eslint-plugin-import.

@laozhu yes, if you click on the commit https://github.com/benmosher/eslint-plugin-import/commit/651829d6a2862b8fa2e33426421a5dba526e4cdb you can see it's in 2.17.0 and higher.


fix merge list of structured class

Closes #327 .
I added test for testing ListConfig and DictConfig(only ListConfig failed). Also added a test for test_merge and one for test_error with the introduced new error to fix this issue.
I followed the same strategy to validate_set as dictconfig.py config with issubclass(value_type, target_type).

don't forget to test the new error.

Oh what, I thought I commited it wtf.


Fix exports typo

Fixes #168
Can't find the module because it's mispelled

I verified by:

fork and build qstash
In my personal project, install npm i ../qstash-js
Run my script: tsx script/qstash
Error
change spelling, rebuild
run script
Success

Hi @mozeryansky,
We decided to revert the recent changes we made to package.json.
https://github.com/upstash/qstash-js/issues/167 should be resolved in 2.7.6. We may revisit the change we wanted to make, but we will make sure that we don't cause any issues.


feat: Add WebSocket Transport

Codecov Report
Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (f8746fd) 55.26% compared to head (7781029) 55.41%.
Report is 14 commits behind head on main.

Files
Patch %
Lines

...ightyear/src/transport/websockets/client_native.rs
0.00%
2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   55.26%   55.41%   +0.15%
==========================================
  Files         130      131       +1
  Lines        8507     8512       +5
==========================================
+ Hits         4701     4717      +16
+ Misses       3806     3795      -11

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Bengali version of the book

Hey @astaxie  I am going to translate the book in Bengali language. It seems it'll take some time to translate it and I am going to send PR every time I translate a chapter. Please let me know if there is any rules & guide to send PR.

Thanks