Comparing numpy arrays with a sparse matrix inside fails

Comparing numpy arrays with a sparse matrix inside fails.
numpy.testing.assert_array_equal seems to go to this line inside __eq__()
https://github.com/scipy/scipy/blob/4b6f71ab37bda20687ff493669a53cb15fb0b35f/scipy/sparse/compressed.py?utf8=✓#L234
and the return line seems to call bool() which results in
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all().

The execution continues but then the comparison returns False when it should be True
Reproducing code example:
from numpy.testing import assert_array_equal
from scipy import sparse

t_grid = sparse.csc_matrix(np.array([[1, 2, 3],
                                         [2, 3, 4],
                                         [5, 2, 3]]))

arr1 = np.array([[t_grid, None, None, None],
                     [None, t_grid, None, None],
                     [None, None, t_grid, None],
                     [None, None, None, t_grid]])
arr2 = np.array([[t_grid, None, None, None],
                     [None, t_grid, None, None],
                     [None, None, t_grid, None],
                     [None, None, None, t_grid]])

assert_array_equal(arr1, arr2)

It might be the case that this issue should be filed in numpy instead? let me know please
Error message:
there is an exception before the error, like mentioned above
ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all().

but it keeps going and then the comparison fails with this error
E       AssertionError:
E       Arrays are not equal
E
E       (mismatch 100.0%)
E        x: array([[<3x3 sparse matrix of type '<type 'numpy.int64'>'
E               with 9 stored elements in Compressed Sparse Column format>,
E               None, None, None],...
E        y: array([[<3x3 sparse matrix of type '<type 'numpy.int64'>'
E               with 9 stored elements in Compressed Sparse Column format>,
E               None, None, None],...

Scipy/Numpy/Python version information:
>>> import sys, scipy, numpy; print(scipy.__version__, numpy.__version__, sys.version_info)
('1.0.1', '1.14.2', sys.version_info(major=2, minor=7, micro=13, releaselevel='final', serial=0))

This would be a numpy.testing feature, but I don't think this is worth supporting as a special case. Please just unpack the object arrays if you want to test this case.


feat(modal): add validation modals

close jiras 506 et 573
https://www.loom.com/share/5a4244c3dd644f3794a3a746afaa40e3

:tada: This PR is included in version 1.9.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Recall

Hey! Thank for your mod, work like a charm!
By the way, i can't use the recall command, is there any way to make it working ?
(i'm on the last steam update, using a local PC as a server)

The latest version added tp command. It should work.


CDF-5 Development

Merge the CDF-5 development branch into master.

Have to correct some issues in the travis-ci config.


Can we have reportFormat "RDF" as well for sbomType "SPDX_22"

sbomType "SPDX_22" allows reportFormat values of "JSON", "RDF", "TAGVALUE" or "YAML".

Related to: https://github.com/philips-software/blackduck-report-action/issues/1

Implemented in #18


Bring back filter by upvoted

Multiple users have expressed that filter by upvoted was crucial for how they use the site. Example: https://www.metaculus.com/notebooks/28734/#comment-199652

Thanks. Filtering by upvote was always kind of a hack. I'd rather introduce filtering questions you follow. It wouldn't be backwards compatible, unfortunately.

Is there a downside to having it? Given people have relied on it and built the way they interact with the site around it, seems like it wouldn't add much complexity and would be valuable for some users.

Well, downside is compexity-death-by-a-thousand-cuts. But yeah, I'm making the call to have it anyway. See #893.


Implementing perfect number in Go

💥 Proposal
Implementing perfect number in Go.
Have you read the Contributing Guidelines on Pull Requests?
Yes

/assign


Fix typos in variable and protected method names

variable: packagComparers -> packageComparers

This variable is internal, it is safe to be renamed

protected method: exludeFilesToString -> excludeFilesToString

This method is protected, only accessible to within the same package and by subclasses
If there is a known subclass of org.spdx.tools.compare.PackageSheet accessing this method, outside of this package, it may not safe to be renamed
The file method is available since 23 Sep 2020

protected method: exludeFilesToString -> excludeFilesToString

This should be safe - I don't know of anyone extending the protected compare classes.  Since we are introducing a lot of breaking changes with the spec 3 update, this is a good time to make these changes.


very slow runtime for keras compiler on CPU

Thanks for participating in the TVM community! We use https://discuss.tvm.ai for any general usage questions and discussions. The issue tracker is used for actionable items such as feature proposals discussion, roadmaps, and bug tracking.  You are always welcomed to post on the forum first :)
Issues that are inactive for a period of time may get closed. We adopt this policy so that we won't lose track of actionable issues that may fall at the bottom of the pile. Feel free to reopen a new one if you feel there is an additional problem that needs attention when an old one gets closed.
For bug reports, to help the developer act on the issues, please include a description of your environment, preferably a minimum script to reproduce the problem.
For feature proposals, list clear, small actionable items so we can track the progress of the change.

I am following 'Compile Keras Models' (https://tvm.apache.org/docs/tutorials/frontend/from_keras.html).
Instead of gpu, I set up target as 'llvm' and ctx as cpu.
Then, I executed the following code. It takes about 12,000 millseconds.
The warning message is 'Cannot find config for 'dense_nopack.x86' and 'conv2d_NCHWc.x86'.
Is there any solution to make better performance?

target = 'llvm'
ctx = tvm.cpu(0)
with tvm.transform.PassContext(opt_level=3):
executor = relay.build_module.create_executor('graph', mod, ctx, target)
dtype = 'float32'
tvm_out = executor.evaluate()(tvm.nd.array(data.astype(dtype)), **params)

Could you please open a thread in the discussion forum https://discuss.tvm.ai? We generally use the forum to such discussions. Thanks.


Improved functionality for determining a users preferred language

Hi!
We have been lacking proper support for determining the preferred language of first time users.
The implementation today does not work for us as it always selects the language of the OS(or similar).
In our fork we have implemented so that we use the language list that the user have in the browser.
It is the same languages that are sent in the accept language headers.
Regards,
Stefan

Merged 3289af1d516161f594747ab8d6a72917fd2f0917
@finnlake For future reference, please be aware when creating a PR submit only the necessary code changes. (i.e. no distribution updates or travis.yml edits) Thanks!

Ok! Sorry I will think of that the next time!


Try first utf-8 encoding by default on reading .kv files. Fixes #5154

Add optional 'encoding' parameter loading .kv files, defaulting
to None. If not passed, also tries native system encoding
if file fails loading as utf-8.
rebasing of #5649

I haven't looked at the code and I like this, but I wanted to comment that perhaps we should only support utf8. You can read more about why I think this at https://www.python.org/dev/peps/pep-0540/. In particular the abstract.
Sticking to only utf8 would make things simpler to document and implement and is consistent with the general flow of things, I think.

that sounds sensible, i think we can probably remove that logic indeed, most editors will save to utf8 these days anyway.


Creating a new application using npm init @open-wc creates an application that does not work

After creating an application using TS all features turned on with the initializer the result is an application what then started using npm run start outputs:
[tsc] 4:10:12 PM - Starting compilation in watch mode...
[tsc]
[tsc] ../node_modules/@types/yeoman-generator/index.d.ts(36,46): error TS2689: Cannot extend an interface 'NodeJS.EventEmitter'. Did you mean 'implements'?
[tsc]
[tsc] 4:10:18 PM - Found 1 error. Watching for file changes.

These are the values used in the application setup:
npm init @open-wc --destinationPath /Users/my-user/my-app --type scaffold --scaffoldType app --features linting testing demoing building --typescript true --scaffoldFilesFor testing demoing building --tagName my-app --writeToDisk true --installDependencies npm

I'm not able to reproduce this error. We don't install or use yeoman-generator. After running the generator, did you cd into the my-app directory?

After running the generator, did you cd into the my-app directory?

Yes I did.
I tried, updating the local version of yeoman-generator clean and install and got the same error. I uninstalled yeoman-generator and tried creating a new app, same error.

For some reason the node_modules in my home directory contains a version of @types that has the yeoman-generator.  I'm not sure why the application would pull the dependencies from there tho.
¯(°_o)/¯


Indonesian Translation

This is a complete id folder for Indonesian translation in content.
Review comment is encouraged, Thank you.

Dear maintainers, can someone review this PR? Thank you.

Hi @mars do you know someone who can review this PR? #noturgent


Update sample to beta 4

Specifically (for now), I am interested in the change to
app.UseOAuthBearerAuthentication(options =>
            {
                options.Audience = Configuration.Get("AzureAd:Audience");
                options.Authority = String.Format(Configuration.Get("AzureAd:AadInstance"), Configuration.Get("AzureAd:Tenant"));
            });

I know that it is now UseOAuthAuthentication and I think I have to import the Microsoft.AspNet.Builder namespace, but the parameters/options names have changed and I'm not sure what maps to what.

Just wanted to correct myself - It is still UseOAuthBearerAuthentication with the same signature and options as beta3 but that got split out into a new package for beta4 Microsoft.AspNet.Authentication.OAuthBearer


[TRIVIA][ANDROID] Setup navigation for screens

I suggest to make separate files for routes and navigation class which will contain NavHost() constructor

I saw new Compose Navigation and it looks much better than normal navigation. I suggest to use the new approach for this issue.
Check this link to see how this look in code: https://www.youtube.com/watch?v=AIC_OFQ1r3k


farm station bug?

Issue Description:
Delete this line after reading it: If this bug occurs in a modpack, please report this to the modpack author first. If you are using an unreleased version of Ender IO (a.k.a development/nightly version), please don't open an issue for features that have not been announced as "finished" or "working". Expect to be ignored if you ignore this template.
What happens:
I had ran into an issue.  Then you use another mod called "Thaumic Additions: reconstructed" and it has seeds but with all the same ID (thaumadditions:vis_seeds) but with different NBT
You then place an certain seed within the mod into the farming station gui. The farming station begin to plants all seeds regardless of the NBT data
What you expected to happen:
A simple fix that farming station will listen out for any changes to the nbt not just ID/meta
Steps to reproduce:

Setup a basic farm station, I'd used for power the creative capactior. Also, used Octadic capacitor and any hoe
Select one Vis Seeds, I'd used Ignis Vis Seeds
put the seed you'll selected into the farm station gui
You can check what actually farm and you'll see it's not the seed you'll selected but all seeds within the mod

GIF: https://gyazo.com/614387ef6045b79610aa4dd6afa18f2f
here in the gif I had middle click the farmed seeds showing you that it's not the seed that i put
...

Affected Versions (Do not use "latest"):

EnderIO: 1.12.2-5.1.55
EnderCore: 1.12.2-0.5.75
Minecraft: 1.12.2
Forge:  <IP_ADDRESS>54
SpongeForge? no
Optifine? no
Single Player and/or Server? both

Your most recent log file where the issue was present:
[pastebin/gist/etc link here]

That's a limitation of Forge's plant system.
====
References:

https://gitlab.com/DragonForge/ThaumicAdditions/-/blob/1.12.2/src/main/java/com/zeitheron/thaumicadditions/items/seed/ItemVisSeeds.java

Is there a way to blacklist the seeds from being put into the farm station?

If they are registered as IPlantable the farming station will allow them into the gui.

this ^ may or may not work

Yeah it didn't work I'd used this https://ci.tterrag.com/job/EnderIO-Modules/job/EnderIO-Hourly/1182/
EnderIO-1.12.2-5.1.1182-nightly.jar

I had just saw the issue
Farming Station: 'Thaumic Additions: reconstructed' integration for farming not loaded
i think it's wrong here https://github.com/SleepyTrousers/EnderIO/blob/1d60e56d7106c37644890917aac4f12851a5daec/enderio-base/src/main/java/crazypants/enderio/base/integration/thaumicadditions/ThaumicadditionsUtil.java#L18
and the item id it's this https://gyazo.com/e69f24c522e8aa4940938b7bab27cbee

I don't see the difference

He put "item:thaumadditions:vis_seeds" that the item id right, but in game it's
"thaumadditions:vis_seeds" without the item:

Please try again with EnderCore 0.5.76.
(The isValid() check on the item container did not compensate for being called during registry events.)

Yes it work very good! Thank you


Closure conversion

From @peter-ahe-google on October 5, 2016 8:56
Meta issue for tracking known issues in closure conversion.

[x] VM assertion error: expected: !is_cycle_free()
[x] for loops
[x] capture this
[x] static tear-off methods
[x] super calls
[x] type variables
[ ] tear-off methods
[x] use VM context and function pointers

Copied from original issue: dart-lang/kernel#33

We don't care to ever transform tear-offs, since their implementation in a backend uses much the same machinery as the MakeClosure primitive we are transforming to, and converting them requires whole-program transformation.

The current blocking factor in closure conversion is a variety of failing fringe tests, from debugging to hot reload.

Is this still an issue?


[P0] [Umbrella] Publicly-accessible Sui Network

Details
Goals

Four validators.
One gateway.
Gateway capable of serving latest transaction data.

Notes on Gateway transaction-serving here (Xun's approach).
Used by Sui Explorer.

Non-Goals

Replica / full-read service.
Strict backwards compatibility at the protocol level.

i.e. We're not targeting full-node support for DevNet.
P1 Stretch

Seven nodes

Dependent Tasks

TODO add these
#1393
#1161
#1351
#1350
#1349
#1279

This is now done


Change title and description of WIT filter

See openshiftio/openshift.io#2972

Ike Plugins (test-keeper)
Thank you @kwk for this contribution!

It appears that no tests have been added or updated in this PR.
Automated tests give us confidence in shipping reliable software. Please add some as part of this change.
If you are an admin or the reviewer of this PR and you are sure that no test is needed then you can use the command /ok-without-tests as a comment to make the status green.
For more information please head over to official documentation. You can find there how to configure the plugin.

Codecov Report

Merging #2118 into master will increase coverage by 0.05%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2118      +/-   ##
==========================================
+ Coverage   68.99%   69.04%   +0.05%
==========================================
  Files         162      162
  Lines       15113    15113
==========================================
+ Hits        10427    10435       +8
+ Misses       3738     3730       -8
  Partials      948      948

Impacted Files
Coverage Δ

controller/filter.go
98.11% <100%> (ø)
:arrow_up:

remoteworkitem/scheduler.go
60.97% <0%> (+7.31%)
:arrow_up:

remoteworkitem/jira.go
100% <0%> (+25%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ee8c18...79ae45f. Read the comment docs.

/ok-without-tests


ebiten: enable to pass a regular image.Image to DrawImage and so on

This is still a draft.

Ebitengine can have an internal *ebiten.Image cache for image.Image
If there is the same size *ebiten.Image as the given image.Image, pick it, call ReplacePixels, and then use it as a rendering source

Unfortunately ReplacePixels should be called every time even if the image is not modified.

If there is not, create a new *ebiten.Image
Check the lifetime of the cached *ebiten.Image objects. If one is too old, dispose it and remove it from the cache.

Probably the concern is that this could cause a performance issue that is hard to investigate...

/CC @eihigh

If the composition mode is 'Copy', DrawImage would work as 'ReplacePixels'.

The concern is that users might abuse DrawImage with image.Image even though we warn such usages are slow. Actually Set was used more often than I expected... Set didn't have such warnings so this is my responsibility, but basically we cannot control how often they are used.

This would contribute to the API's easiness, but make simplicity worse. This is opposite to my policy unforutnately.


fix groomer info not displaying on initial render

Description
Groomer info now properly displaying on initial render.  useEffect needed to be added to call to the API on render for the info.
Type

[ ] This is a bugfix.
[ ] This is a new feature.
[ ] This is part of a feature.

Organization

[ ] Have you linked this pull request to a Trello card?
[ ] Have you named the branch in the format of feature/describe_feature_or_change OR bug/describe_bug_this_is_fixing

Review

[ ] Is this a work in progress?
[ ] Is this ready to be reviewed?
[ ] Have you added two reviewers to this pull request?

 BUG: The groomer info does not load on up initial render, only after something triggers re render

 BUG: The groomer info does not load on up initial render, only after something triggers re render


Typings command not found

I had typings installed, but since yesterday i am getting typings command not found issue on mac like below:

-bash: typings: command not found

Even after uninstalling and installing it again as global npm dependency the issue is not resolved.
below is the erro log of npm install typings --global command

npm ERR! Darwin 15.3.0
npm ERR! argv "/usr/local/Cellar/node/5.1.0/bin/node" "/usr/local/bin/npm" "install" "typings" "--global"
npm ERR! node v5.1.0
npm ERR! npm  v3.7.2
npm ERR! path /usr/local/bin/typings
npm ERR! code EEXIST
npm ERR! Refusing to delete /usr/local/bin/typings: ../lib/node_modules/typings/dist/bin/typings.js symlink target is not controlled by npm /usr/local
npm ERR! File exists: /usr/local/bin/typings
npm ERR! Move it away, and try again.
npm ERR! Please include the following file with any support request:
npm ERR!     /Users/ankit/npm-debug.log

@kambojankit This is an NPM issue and isn't related to typings. However, I know this issue - it appears you've used npm link in the past and now it won't override it again (it's an issue with your NPM version). To fix this, follow the error instructions and remove the linked file and reinstall. rm /usr/local/bin/typings.

thanks @blakeembrey for the quick resolution.. It works for me now.

I reinstalled only in the project I needed it, worked for me. Thanks


viewdidLoad lifecycle method calling each time I open a screen

Hi , On selecting any option from sidemenu, that vc's viewdidLoad is calling each time. How can I fix it?

Answer is in the README.


Technical debt: Remove filtering of node_params

We should be able to have all node_params right, without having to filter them.

Done. This is now the case with the new Python API.


Create a Dockerfile for the Project

Title: Create a Dockerfile for the Project
Description:
We need to create a Dockerfile to containerize the project for easier deployment and consistency across different environments. The Dockerfile should:

Set up the appropriate base image (e.g., node:alpine or python:slim depending on the tech stack).
Install necessary dependencies.
Copy the source code into the container.
Expose the required port (if applicable).
Define the entry point or command to run the application.

Level: GSSOC_EXT Level 3
")

I would like to work on this. Can you assign me this under GSSOC-ext and hacktoberfest

@jinx-vi-0  can you assign this with labels

Assigned @rishyym0927


Allow WithError to be called with a nil error

Fixed nil pointer error in WithError when err is nil.

hmm what's the case where you'd hit this? I always have:
if err != nil {
  log.WithError(err).Error("...")
}

You wouldn't want an Error() call if there's no error

Basically, in cases where I'm using it for simple debugging. I make a call to log.WithError(err).Info("is there an error?") and look in the logs to see what's going on. I could, of course wrap it in if err != nil, but it's simpler not to have to do that. I don't really think there should be the possibility left open for nil pointer exceptions anyway, when is so easy to avoid them, but you may have a different opinion on that..

Ah yea my opinion on that stuff is generally just to avoid defensive programming, and handle real-world use-cases. In this case I'd just use a snippet in my editor for the if or a quick snippet for fmt.Printf("error: %v", err) when debugging.
Closing for now


Fix nesting of language_ids

This PR fixes the nesting of the language_ids field so it is underneath the biome language server entry.
The current top-level language_ids is not valid according to the extension manifest schema: https://github.com/zed-industries/zed/blob/b6857ca469293112a89784817fba0685b1553892/crates/extension/src/extension_manifest.rs#L107-L108

Oh thank you.
I just caught it too :) I will merge this though.


Set Up SAP Cloud Platform Launchpad Service

Tutorial URL: https://developers.sap.com/tutorials/cp-portal-cloud-foundry-getting-started.html
Please specify the step you are referring to:
In step 2.3 The statement "Click sap.default to select the SAP ID Service." needs to be changed to "Click Default identity provider to select the SAP ID Service." The screenshot also needs to be updated. As it might create confusion for the new user.
Expected:

Actual:

Label:
Landscape Labels - trail1,trail2,trail3
Sprint Label: SCPTest-2011A
Scenario Label: SCPTest-psite
Priority: High

Updated - will publish today.
Thanks
Lindsay

@LindsayBert Is this published?


Add script to archive folder

Bring archive script to common-pyutils

The original script name of archive_to_lts was more apt and suggest retaining that..
I changed it because it is not limited to this and could be archiving anywhere. I didn't want to limit it to the actions we're currently doing.


Release file naming

The release file names should have the pattern  "ResourceType-id.json"  and the "id" portion has to be an exact string match to the value in the "id" filed in the JSON object.  "ResourceType" is CodeSystem, ValueSet, etc.
Also, the "id" value has to pass: http://hl7.org/fhir/datatypes.html#id
CodeSystem-CompLOINC.json in the 1-9 release does not follow this pattern.

@joeflack4 I still see an issue with file names vs resource id.
For example: CodeSystem-so.json   has resource id "CodeSystem-so".  The resource id in this case should be "so".


jmemansi is missing from ios build

For the iOS build, part of libjpeg (jmemansi.o) is being deliberately removed from the final static lib.
In 2.4.x its here:
https://github.com/Itseez/opencv/blob/2.4/modules/world/CMakeLists.txt#L106
and for 3.x its here:
https://github.com/Itseez/opencv/blob/master/3rdparty/libjpeg/CMakeLists.txt#L13
Why is this file being filtered out?  (The commit that made this change is here.)  jmemmgr.c uses functions in jmemansi.c, so leaving it out is going to cause linker errors.  In fact, that's what's causing #4877 and #4941.
The iOS downloads of 2.4.10 and 2.4.11 are unusable because of this, but 2.4.9 works because it includes jmemansi.

As I can see jmemansi.c is replaced with jmemnobs.c on these platforms, both files contains same functions implemented.
Probably iOS linking problems are related to missing static 3rdparty libraries.

Any update on this? The iOS version of 2.4.13 is still giving linker errors:
Undefined symbols for architecture arm64:
  "_jpeg_free_small", referenced from:
      _free_pool in opencv2(jmemmgr.o)
      _self_destruct in opencv2(jmemmgr.o)
  "_jpeg_mem_available", referenced from:
      _realize_virt_arrays in opencv2(jmemmgr.o)
  "_jpeg_free_large", referenced from:
      _free_pool in opencv2(jmemmgr.o)
  "_jpeg_open_backing_store", referenced from:
      _realize_virt_arrays in opencv2(jmemmgr.o)
  "_jpeg_get_large", referenced from:
      _alloc_large in opencv2(jmemmgr.o)
      _realize_virt_arrays in opencv2(jmemmgr.o)
  "_jpeg_mem_term", referenced from:
      _jinit_memory_mgr in opencv2(jmemmgr.o)
      _self_destruct in opencv2(jmemmgr.o)
  "_jpeg_mem_init", referenced from:
      _jinit_memory_mgr in opencv2(jmemmgr.o)
  "_jpeg_get_small", referenced from:
      _jinit_memory_mgr in opencv2(jmemmgr.o)
      _alloc_small in opencv2(jmemmgr.o)
ld: symbol(s) not found for architecture arm64
clang: error: linker command failed with exit code 1 (use -v to see invocation)

I've tried to build opencv2.framework (2.4.13) using python opencv/platforms/ios/build_framework.py as well, and jmemnobs.c is nowhere to be found within the build directory, but jmemansi.c is included...

Update: removed  ocv_list_filterout(objlist jmemansi) # <<= dirty fix from modules/world/CMakeLists.txt and it's linking properly.
Note: you have to remove the build directory then re-run the python command to get a new opencv2.framework.

Considering this issue obsolete.


Custom Element Type Logging

Hi,
Is there a hook which I can use to log in custom elements? I know there is a hook to add sources but wondering if we can extend the plugin to log custom elements?
Many thanks

Just copy one of the services to a new plugin and modify it. That should be enough.


Check that the generated pb.rs file matches

What does this PR do?
Adds a check that the auto-generated pb.rs file in trace-protobuf matches the definitions in build.rs.
Motivation
The pb.rs file is auto-generated from the protobuf files and the definitions in build.rs and it's easy to only edit the pb.rs file and forget the definitions in the build.rs file.
Additional Notes
Anything else we should know when reviewing?
How to test the change?
Describe here in detail how the change can be validated.

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #501   +/-   ##
=======================================
  Coverage   69.39%   69.39%
=======================================
  Files         201      201
  Lines       26745    26745
=======================================
  Hits        18560    18560
  Misses       8185     8185

Components
Coverage Δ

crashtracker
16.70% <ø> (ø)

datadog-alloc
98.76% <ø> (ø)

data-pipeline
51.30% <ø> (ø)

data-pipeline-ffi
0.00% <ø> (ø)

ddcommon
85.97% <ø> (ø)

ddcommon-ffi
74.15% <ø> (ø)

ddtelemetry
56.37% <ø> (ø)

ipc
84.66% <ø> (ø)

profiling
78.63% <ø> (ø)

profiling-ffi
58.19% <ø> (ø)

serverless
0.00% <ø> (ø)

sidecar
36.26% <ø> (ø)

sidecar-ffi
0.00% <ø> (ø)

spawn-worker
54.98% <ø> (ø)

trace-mini-agent
69.36% <ø> (ø)

trace-normalization
97.79% <ø> (ø)

trace-obfuscation
95.75% <ø> (ø)

trace-protobuf
48.71% <ø> (ø)

trace-utils
90.79% <ø> (ø)


Failed on pystol ClusterServiceVersion

Got this error:
Error: Invalid block definition

  on pcl-764300749.pp line 0:
   1: resource pystolPystol.v0.8.17ClusterServiceVersion "kubernetes:operators.coreos.com/v1alpha1:ClusterServiceVersion" {

Either a quoted string block label or an opening brace ("{") is expected here.

When I tried using the kube2pulumi web app on this ClusterServiceVersion

This is due to the object name containing periods, eg. pystol.v0.8.17 when converting the intermediary PCL to target language. We'll need to normalize the name to prevent this.

Development for converting Kubernetes manifests to Pulumi programs has moved over to: https://github.com/pulumi/pulumi-converter-kubernetes.
This bug has been addressed in the Kubernetes converter plugin.


3 create metadata table

Code to parse directory of xml files.
The path assumes you have unzipped the data in the project directory. It will also generate a folder in the current directory named data with the output file; this folder is ignored via gitignore.

Currently working on finishing this task; I have some more commits to add before it'll be ready to merge.


Issue with enabling TLS

HI,
I am trying to enable TLS with Portus, here is the procedure I used:

Clone the Portus code

git clone https://github.com/SUSE/Portus.git

Create self-signed TLS key and certificate

openssl req -newkey rsa:4096 -nodes -sha256 -keyout ./compose/registry/registry.key -x509 -days 365 -out ./compose/registry/registry.crt

Modify configuration files with the TLS key and certificate

cd Portus/
Modify compose/docker-compose.yml.template to add the volumes for the registry.crt and registry.key
registry:
  image: library/registry:2.3.1
  volumes:
    - /registry_data
    - ./compose/registry/portus.crt:/etc/docker/registry/portus.crt:ro
    - ./compose/registry/config.yml:/etc/docker/registry/config.yml:ro
    - ./compose/registry/registry.crt:/etc/docker/registry/registry.crt:ro
    - ./compose/registry/registry.key:/etc/docker/registry/registry.key:ro

Modify ./compose/registry/config.yml.template to add the tls section, and use registry.crt as the rootcertbundle
http:
  addr: <IP_ADDRESS>:5000
  debug:
    addr: <IP_ADDRESS>:5001
  tls:
    certificate: /etc/docker/registry/registry.crt
    key: /etc/docker/registry/registry.key
auth:
  token:
    realm: http://EXTERNAL_IP:3000/v2/token
    service: EXTERNAL_IP:5000
    issuer: EXTERNAL_IP
    rootcertbundle: /etc/docker/registry/registry.crt

Run compose-setup.sh

./compose-setup.sh -e <IP_ADDRESS>
However, when I tried to create the admin user with TLS enabled, it complains "SSL error while communicating with the registry, check the server logs for more details. You can skip this check by clicking on the "Skip remote checks" checkbox."
Any suggestion on what additional configuration I need to do to enable TLS communication between the Portus and the registry? Thank you.

I figured it out, the tricks are:

Add the self-signed TLS certificate into Portus containers

docker exec -it portus_crono_1 /bin/bash
cd /usr/local/share/ca-certificates
scp <IP_ADDRESS>:/root/Portus/compose/registry/registry.crt .
update-ca-certificates
docker exec -it portus_web_1 /bin/bash
cd /usr/local/share/ca-certificates
scp <IP_ADDRESS>:/root/Portus/compose/registry/registry.crt .
update-ca-certificates

Set correct "auth.token.issuer" in compose/registry/config.yml

The auth.token.issuer attribute should be set to the FQDN of the machine on which the Portus containers are run, here is my example:
auth:
  token:
    realm: http://portus.domain.com:3000/v2/token
    service: registry.domain.com:5000
    issuer: portus.domain.com
    rootcertbundle: /etc/docker/registry/portus.crt


Set cert location based on where they actually are in the filesystem

This works, but will search the FS on every request.
Looking for guidance on the idiomatic way in a DuckDB extension to store this between calls.

In the Azure extension we use the ClientContext::registered_state for this, see here
This is likely the cleanest way to solve this, but perhaps a little overkill for the prototyping state of the extension and might lead to double work if we end up refactoring.
Alternatively perhaps for now its fine to search the FS on every request or perhaps doing it once on extension load storing the resulting path in a global variable. Note that because the extension initialization function is guaranteed to be the first thing that is called and will never be called again, this is safe to do without locking.


Make liveness and readiness probes configurable (#29)

Resolves https://github.com/provectus/kafka-ui-charts/issues/29
Helm template diff of the generated chart (helm template "kafka-ui" charts/kafka-ui):
diff --git a/old b/new
index cf6bb91..ab19b95 100644
--- a/old
+++ b/new
@@ -84,6 +84,8 @@ spec:
             initialDelaySeconds: 60
             periodSeconds: 30
             timeoutSeconds: 10
+            successThreshold: 1
+            failureThreshold: 3
           readinessProbe:
             httpGet:
               path: /actuator/health
@@ -91,5 +93,7 @@ spec:
             initialDelaySeconds: 60
             periodSeconds: 30
             timeoutSeconds: 10
+            successThreshold: 1
+            failureThreshold: 3
           resources:
             {}

The newly added successThreshold and failureThreshold correspond to the kubernetes probe defaults.

Take a look at https://github.com/kafbat/helm-charts, feel free to submit a PR there instead


fs.readFileSync() expects a string

In this snippet from the homepage, when I tried using it as is for a custom theme on my blog, in getStaticProps, Next.js throws an error as shown in this issue title.
https://github.com/atomiks/rehype-pretty-code/blob/1c627dc05802ca4c4cce49150e6ce2f0d9fdc2c8/website/src/app/index.mdx#L243-L246
But, when I passed the file path as a string to my custom theme, the error was gone. Maybe this needs revision? If yes, I'd love to make the necessary changes and send a PR.

Oh! Okay then.
Should I submit a PR that addresses it?

Sure


Add ZPlug installation instructions

This PR updates the documentation to include installation via ZPlug plugin.
The plugin at https://gitlab.com/RiverGlide/zsh-rbenv.git is pretty straightforward, and would be a good candidate for bringing under the rbenv organisation.
It uses git submodules to checkout rbenv and ruby-build, and the plugin file itself adds rbenv and rbenv-install to the path as well as calling eval $(rbenv init -)
For ZPlug users, this is a clean, portable, easy way to install
There is also a plugin for rbenv-vars at https://gitlab.com/RiverGlide/zsh-rbenv-vars.git

Hi, I haven't heard of ZPlug, and I don't usually give prominent README placement to projects I have no experience with.
Our regular installation instructions will work for users of zsh as well.

Hi @mislav, thanks for responding.
If you decide to revisit this in the future, I can raise another PR.
In the meantime, here are some of the reasons that I thought that it was worth including.
ZPlug is a plugin manager for zsh. There are other shell managers for zsh, such as oh-my-zsh/prezto, but like RVM, these managers can be quite invasive under the covers as well as coming packaged with a lot of optional functionality.
ZPlug is closer to the UNIX philosophy of doing one thing well; ZPlug only installs and activates the plugins, it doesn't try to do anything else on top.
ZPlug feels similar to the (sadly, rarely used) installation of UNIX packages to the /opt directory, where everything related to one package is stored in the same place.
It also feels very similar to rbenv in the way that the plugins are self-contained, much like each version of Ruby has it's own set of gems
Why use ZPlug to install rbenv?

ZPlug does not require elevated privileges to install. Both brew (for initial installation) and apt-get/yum etc require super-user access
Each plugin is installed in isolation. They are responsible for adding their binaries to the path and calling any initialisation functions. This means that the .zshrc is entirely intention revealing. There is no additional noise of extending the PATH variable or calling init functions. (my current .zshrc - the main noise is configuration for the powerlevel9k prompt)
It's portable. The same zshrc works on any operating system (as long as git is installed)
It's a great compromise between automatic installation via system tools and manual installation via git. You get the benefits of both.
It's easy to temporarily disable (remove the line from .zshrc and start a new shell) or remove (remove the line and call zplug clean)
It's easy to upgrade (zplug update)

Downsides (and mitigations)

The RiverGlide rbenv plugin relies on git submodules, which means it has to be kept in step with the rbenv release. This is no different to the rbenv brew recipe or OS packages, and could be automated through github actions if the plugin was brought under the rbenv organisation
It's zsh specific
It's not the common way to do things (but once upon a time, neither was rbenv or bundler)


Ignore the logs folder

In my opinion i don't see nobody wanting to push log files to their repo or having anything else then log files in it.
Reasons for making this change:
It doesn't really make sense to write code in the logs/ directory, nor does it make sense to upload log files to github.

Storing program logs in a folder called logs isn't universal, and it'd be trivial for people who do store logs in logs to add it to their own project's .gitignore. *.log is also already in Python.gitignore, which is a common suffix for log filenames.


Onboarding shows wrong screen

From AP-4342
How is the user affected? And what is the expected behavior?
After running my first build in a fresh project as part of the "happy path" onboarding (Storybook 8.0.0-rc.2, VTA 1.2.7, I see the following screen:

The contents of the addon panel look wrong to me. I would expect it to say something to the effect of "congrats on running your first build, now let's check out the changes. Next >".
When I click the "Done" button, it takes me to the next step of the tour--which is blocked by the "Storybook 8 enters beta" notification. A separate bug, I think.
How many and/or what class of users does this impact?
All VTA users? I'm not sure.
Is there a workaround?
Yes, if you click "Done" it will take you to the next step of the tour.
What are the steps for reproducing the issue?
To get to this step, I:

Created an empty directory
Ran npx storybook@next init in the directory and selected react-vite-ts option
Set up git
Ran through the onboarding
Changed the story text of the Button.Secondary story to "Buttoon"
Ran my first build

This is how that view should look. The copy needs to be updated:

It looks like the design you are seeing in the issue above should only be visible to users who already completed onboarding once.

Possible duplicate to #252 ?

@MichaelArestad This looks like you're not in the onboarding state (you skipped/finished the walkthrough already). The vtaOnboarding query param may not be sufficient. You can reset it through the API like so:
mutation {
  updateUserPreferences(input: { vtaOnboarding: UNSET }) {
    updatedPreferences {
      vtaOnboarding
    }
  }
}

@ghengeveld Does that mean our users won't see this?

I just verified, this is what I see on a clean project after running the first build:

This looks like the correct screen to me.

I opened #283 to fix the background color on the thumbnail container (the image should be on a white background, not transparent).


Add a public validate form method

Grabbed this from https://github.com/morgrowe/aspnet-validation

Whoops, wrong repo.


Add magic login endpoint.

What's this PR do?
This PR adds a little Northstar wrapper around the Phoenix magic login link endpoint, which allows users to create Phoenix login links using their Northstar authentication token.
How should this be reviewed?
👀! 🚥!
Checklist

[x] Documentation added for changed endpoints.
[x] Tests added for new features/bug fixes.

For review: @angaither @weerd

🚢


Error when use volumes_from in docker_compose.yml

Hi
Im just make some test's in your tutorial but when i edit docker_compose.yml to be like this
 i get an error saying volumes_from is not a valid command.
.
what i want to do is create a data container only that will be able to share a volume with all container in the cluster independently wich host are they running

Hi,

Unfortunately at this point in time we only support a subset of the compose language.
The way we would probably want to do this requirement is to have a dataset that can be shared by all containers in the cluster, rather than using volumes_from. And while that is theoretically possible in some storage backends (though none we support currently), it is not currently supported by our software.

Our product team will note your specific requirements as part of the planning process for future releases, so thanks for filing the issue and explaining your motivation.
What sort of data would you want to store in this volume, and what applications would be running in the container and accessing it?
What kind of data would you be putting in a volume

@itamarst I have the same use case as @fernandoneto.  I would like to store imagery in a volume which is shared by two or more containers.  Let's say one container is a web-app which needs read-only access to /data.  Another container is a backend service which runs long-running image processing tasks to create derived images written to /data.

Closing as we do not plan to support the Container API after 1.11. Continent can safely be shutdown and you should use Docker CLI and our Docker Plugin instead.


Add a flag in cchost.py to run with GDB.

The cchost infra (and start.sh) can now be given a --with-gdb argument, which will start the cchost process in a debugger. This can be a handy way to get stack traces when debugging crashes or exceptions.
While pytest cannot start a cchost process inside of GDB, most tests can still be used while connecting to an external service (as used in our Docker CI). This allows pytest to be using together with ./start.sh --with-gdb, if trying to run tests under a debugger.
For now, using GDB probably only works on virtual builds. It might require a bit more setup to function on SGX builds.

When we were still using CCF's sandbox script in start.sh it was possible to add a -d <node_idx> flag which then printed out the gdb command that has to be manually run (in another terminal), waited for key press, and then continued with network setup etc. Apart from printing the gdb command it also wrote a file to /tmp/vscode-gdb.sh which allowed to start debugging directly from VS Code with launch configurations in the .vscode/ folder.
See also:

https://github.com/microsoft/CCF/pull/1444
https://github.com/microsoft/CCF/pull/1650
https://github.com/microsoft/scitt-ccf-ledger/blob/6d4a136cc814b6e995ea0a4a21f7e6c73e95bb55/.vscode/launch.json

I'm mentioning this just to give some context and ideally we'd want to restore the VS Code debugging option somehow. Do you think this PR is the right direction to do that eventually?


Need a way to get the focus on search filed

Is there a way to open the keyboard and have the focus by default / programatically. ?
If not can you please expose a way to get the editor / edit text so that we can have some control over it.
Thanks!
Manju

It is definitely important to be able to set the focus of the search indeed, so I'll add it in the next release. I do not want to expose the EditText at this moment though.
Thanks for suggestions.

Perfect!
Just so that you know, I am going launching the search view in fragment so I need to open the keyboard when we launch the fragment.
Thanks for your help!
Manju

I would like to ask you opinion about https://github.com/arimorty/floatingsearchview/blob/master/library/src/main/java/com/arlib/floatingsearchview/suggestions/model/SearchSuggestion.java.
Do you thing it is useful to have full access the the ImageView or the TextView for the SearchSuggestions? I am thinking of removing the ability to modify them because if client is changing certain attributes it could cause undesired results.

I am glad you asked. I was wondering why we have the data and view mix up here.
Well here is my opinion. Please feel free to correct me / debate with me if you don't agree for certain points noted down here

Quick fix

I see the approach you have taken, This lib does not allow to set the Adapter from outside which I assume is the design choice.  Assuming you would go ahead with this approach further, I would recommend to have clear distinguish between view and data model. We should not mix up data to view model in anytime. It's always better to keep data model to be view agnostic.
To fix the style / theme problem I would get the style / theme pre defined when the view is initialized or inflated in XML using the  app:floatingSearch_suggestion_text_size, app:floatingSearch_suggestion_text_typeface app:floatingSearch_suggestion_text_color etc.
We should be able to set these programmatically too using some kind of setters methods.
This would be much faster approach for now considering the amount of work you have put out there.

Refactor the design choice

Since this lib is in it's initial stage I think you should reconsider to refactor a little bit to get the suggestion adapter from the outside. This is how other android view works. Its gives a way to set the different Adapter based on the user needs. All you have to do a way to give a set the text to search view and couple of wrapper listener on text change listener.
Hope this helps!
If you feel to discuss more, you have my email id. Please feel free to contact me anytime.
I think this library has huge potential to grow provided it has ability configure easily.
Thanks!
Manju

Thanks, I really appreciate your thoughts and your contributions to the library! This helps make the library better.
Best regards,
Ari


like ng-change on fileinput

Hi! I am trying to detect when the input state changes, for example when it is undefined or when it has an image, something like "ng-change", is there any function like this?
Thanks for your time.

+1

For now, you can just use $watch against your $scope variable defined with the lf-files attribute (I watch the .length property of that object).

I got the same problem here, I cant watch the $scope.files

$scope.$watch('files.length',function(newVal,oldVal){
   if ( $scope.files && $scope.files[0] && $scope.files[0].lfFileName) {
      // files has changed and has a valid entry to act on
   }
});


Support ArchiveRecord creation

This PR adds a new createArchiveRecord method to the SDK which allows the creation of Archive Records within a given archive.

@Fenn-CS I think this is ready for your re-review!


Add a badge for an irc channel

I don't want to start badge collecting on the README.  How about we just point users to the chat room like they do in https://github.com/rust-lang/rust?

I am not sure if I deserve a vote. I appreciate the courtesy. I'm sure it's
just as easy for you to just add it.
On Wed, Jul 13, 2016 at 7:16 PM Adam Crume<EMAIL_ADDRESS>wrote:

I don't want to start badge collecting on the README. How about we just
point users to the chat room like they do in
https://github.com/rust-lang/rust?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/tensorflow-rust/pull/12#issuecomment-232538847,
or mute the thread
https://github.com/notifications/unsubscribe/AAxN2-O5fv6XyD6Z4RDMWV296-SlwToFks5qVZvmgaJpZM4JLsTg
.

--
Sent from my mobile<PHONE_NUMBER>
Alex Newman

I'm the project lead, but this is open source, and I'd rather give everyone a say.  I'll go ahead and add a link to the channel.  (A bit later, though, after I've had a chance to eat. :) )

P.S.  I meant to say that I want everyone to have a say and a chance to contribute.

project!  That's pretty neato.
On Wed, Jul 13, 2016 at 7:32 PM Adam Crume<EMAIL_ADDRESS>wrote:

P.S. I meant to say that I want everyone to have a say and a chance to
contribute.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/tensorflow-rust/pull/12#issuecomment-232540895,
or mute the thread
https://github.com/notifications/unsubscribe/AAxN21ga4oMogItweylQUMXjmyuKcFYnks5qVZ-7gaJpZM4JLsTg
.

--
Sent from my mobile<PHONE_NUMBER>
Alex Newman

Well, when I say project, I mean that in general terms.  This isn't an official Google offering.  I don't have an official title or anything; I'm just the guy with admin rights on the GitHub repo.

Understood
On Wed, Jul 13, 2016 at 7:40 PM Adam Crume<EMAIL_ADDRESS>wrote:

Well, when I say project, I mean that in general terms. This isn't an
official Google offering. I don't have an official title or anything; I'm
just the guy with admin rights on the GitHub repo.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/google/tensorflow-rust/pull/12#issuecomment-232542031,
or mute the thread
https://github.com/notifications/unsubscribe/AAxN26hSpI-RzF9G4aHVfZqofDKMnG_Eks5qVaG0gaJpZM4JLsTg
.

--
Sent from my mobile<PHONE_NUMBER>
Alex Newman

Added a reference to the IRC channel in fd62233.


Added codecov.io integration

Coverage remained the same at 93.71% when pulling e930d70755db681fe6d687ac5cba1c3607681bb0 on kielabokkie:master into af65337677f695572ca53f7e98f1658966d20f57 on pixelfusion:master.

Coverage remained the same at 93.71% when pulling e930d70755db681fe6d687ac5cba1c3607681bb0 on kielabokkie:master into af65337677f695572ca53f7e98f1658966d20f57 on pixelfusion:master.


BUG: Warning about pip when creating conda environment

Describe your issue.
When creating a conda environment with either environment.yml or environment_meson.yml, there is a warning about pip-installed dependencies in the environment file but no explicit requirement that pip is installed.
Both the environment.yml and the environment_meson.yml files should be updated to include an explicit pip requirement.
Reproducing Code Example
$ git clone https://github.com/scipy/scipy.git
$ cd scipy/
$ conda env create -f environment.yml

Error message
Warning: you have pip-installed dependencies in your environment file, but you do not list pip itself as one of your conda dependencies.  Conda may not use the correct pip to install your packages, and they may end up in the wrong place.  Please add an explicit pip dependency.  I'm adding one for you, but still nagging you.

SciPy/NumPy/Python version information
1.9.0.dev0+1.1a945ca 1.22.3 sys.version_info(major=3, minor=10, micro=4, releaselevel='final', serial=0)

Good one. Actually I think doit should be pulled by Conda-forge. IIRC this was done like that because doit was not released yet on Conda-forge with the version we wanted to have.


Document how to add SSL Certificate

Add documentation for adding an SSL certificate to a Sync Endpoint. Probably should include links to other docs for things like generating them.
From the 2019 convening: https://docs.google.com/document/d/1_4x9x3eHxo4qevBRlpmCC9L2bVlUkAQuAlidT8wJDzI/edit#heading=h.264josm5lg7

Process improved to add certbot to sync-endpoint

Docs update: https://github.com/odk-x/docs/pull/10

This appears to be at least in part underway but looks like it needs further work and probably is worth pursuing.

@elmps2018  Can I try to work on this issue. This will help me to learn more about the documentation of odk-x as a contributor and will research to make this issue done.

Hi @khushishikhu, it looks like you already have a number of open issues. We ask folks to focus on working on a few issues -- if you can finish off some of the other ones then can ask again for this one!

@elmps2018 yes sure I understand, that is why I asked it now because recently my PR got merged of one issue and one more is about to done. So I thought I am allowed to take a one now and start working.

@khushishikhu, looking at assignees quick it looked like you still have more than one open issue assigned. Are there some you are no longer working on?

@khushishikhu our general limit is normally two open with more issues allowed with completed PRs in waiting for reviewer. This means @elmps2018 answered correctly,
This means the following PRs should have some movement before getting a third, we allowed a higher number sometimes because of interrelated like (#225 and #110).
However currently, the mentors have answered on:
#225 (and thus related to #110)
#250
This means you have two to work on.
I see you are waiting on @elmps2018 #229

@elmps2018 @wbrunette okay sure I got your point. Thank you for making me consern I will take care of this thing from next time.

@elmps2018 can I take this issue?

Hi @khushishikhu! Appreciate your enthusiasm for working on issues! It looks like you still have two open issues

Are you awaiting review on any of those?

@elmps2018 (those two are combined) so it's fine for her to have a third.

@wbrunette @khushishikhu Great thanks for clarifying!

@khushishikhu since this issue was created we have revised the default setup to automatically obtain a encryption certificate using letsencrypt. However, sometimes people still have their own certificate already and they simply want to add an instance sync-endpoint to an existing domain (e.g., odkx.mydomain.com and mydomain already has a registered SSL certifcate). Alternatively some people do not want to use letsencrypt. Therefore how to have sync-endpoint reference the correct TLS certifacte is important.

@wbrunette I was reading this document https://docs.odk-x.org/sync-endpoint-manual-setup/ and then this https://gist.github.com/chrismclarke/32a0b7331c6027a3e7be4d0d2c0866d3  and found out that there isn't the documentation for creating SSL certificate in this .does the instructions given here are with using letsencrypt

The sync-endpoint-default-setup automatically uses letsencryt and does this for the user in the setup script.
Therefore, we have the use case of starting from nothing covered/documented, what we are looking for is if you already have an TLS/SSL certificate how do you setup sync-endpoint with a previously obtained certificate. Does that make sense? It's good that you did some investigating as it helps to understand the system.

@wbrunette  what does here domain mean, like do I have to create my own one or we have some specified domains that are to be written here?

and I was trying to create a certificate for testing purpose so that I can know about how things work. but then I run this command sudo certbot certificate in which if I have to add SSL/TLS certificate it will be saved into letsencrypt file. so if anyone add the SSL certificate to an existing domain will get save to this letsencrypt file? and is this what has to be documented because I think certificates in letsencrypt file doesn't mean that lstsencrypt is automatically generating the certificate.

You have to own the domain for certbot to work. The domain traffic must be directed to the machine that is running certbot must be on that domain. Certbot uses it's remote servers to verify that you actually own the domain then issues the certificate.
Let's encrypt is a provider of TLS/SSL certificates. The nice thing is that the certificates are free; https://letsencrypt.org/
There are lots of companies that you can obtain a TLS/SSL certificate from, but you have to pay money. Examples include Microsoft, Amazon, GoDaddy, DigiCert, etc.
I produces a PEM file. Perhaps @matt9j has some good references for you to look at.

@wbrunette I think this https://phoenixnap.com/kb/install-ssl-certificate-nginx can be the way to add an owned  SSL certificate in a nginx server ( HTTPS port:443 ) and an existing domain. what say?

Hi @khushishikhu ! That could be a possible approach, but the main challenge I think will be integrating that with how the nginx config and certificates are handled in docker right now. In addition to importing the certificate, the certbot functionality will need to be disabled.

@matt9j good point. I think the main issue is to document how to get the certificate working with nginx. I think secondary is to open an issue to add to disable certbot. I just created https://github.com/odk-x/tool-suite-X/issues/264. Feel free to comment here.
@khushishikhu write the instructions assuming the certbot can be disabled.

@wbrunette @matt9j  Thank you for clearing out my doubts, It really helped me a lot.


[BUG] Input field behavior

All Input fields should have the same feedback behaviors for basic, active, disabled and error behaviors. Additionally, all inputs should be able to use the ESC key to cancel the current input action (either new or edit).
UX Design:
Input Field Behaviors

@fabric8io/uxd - as discussed


Big Docs Mistake..?

Docs say to use:
policy.csv: |-
  p, role:readonly, extensions, invoke, httpbin, allow

And I get No metrics available .. check my logs, says I'm not authorized to use extension metrics (even though I'm admin)
so I go hmm...
policy.csv: |-
  p, role:admin, extensions, invoke, httpbin, allow

Still no go.. so I go hmmmmmmmmmmm........
policy.csv: |-
  p, role:admin, extensions, invoke, metrics, allow

annnnnnd whatdoyaknow?! BAM

so where did httpbin come from? I'm using basically exactly the default config..?
The docs also show:
extension.config: |-
  extensions:
    - name: metrics
      backend:
        services:
          - url: <METRICS_SERVER_URL>

and https://argo-cd.readthedocs.io/en/stable/developer-guide/extensions/proxy-extensions/ shows:
apiVersion: v1
kind: ConfigMap
metadata:
  name: argocd-cm
  namespace: argocd
data:
  extension.config: |
    extensions:
    - name: httpbin
      backend:
        connectionTimeout: 2s
        keepAlive: 15s
        idleConnectionTimeout: 60s
        maxIdleConnections: 30
        services:
        - url: http://httpbin.org
          headers:
          - name: some-header
            value: '$some.argocd.secret.key'
          cluster:
            name: some-cluster
            server: https://some-cluster

as an example for proxy extensions...... Did someone just copy/paste and forget to update RBAC to metrics or something?

Thank you @mcanevet for fixing that doc.


story(deployment): update arctic chain id in config (#829)

Closes #ISSUE-NUMBER
Checklist:

[x] I have performed a self-review of my own code
[x] I have documented my code in accordance with the documentation guidelines
[x] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have run the unit tests
[x] I only have one commit (if not, squash them into one commit).
[x] I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Pending review before merge to main


Why is it not possible to use MovePause while using MoveLine.srv but its possible for MoveHome.srv?

Is there any reason why it is not possible to use MovePause on MoveLine or MoveJoint.srv?
and is there a way how i can make it work?

Nvm got it, my mistake was the ref value.

@Dorianproject Can you please let us know how you could be able to use the ros services, since I am using A0509 cobot and when I am launching with emulator I could be able to access all the service call but when I am launching gazebo with real mode. I couldn't be able access the service calls. What could be  wrong going on ..


Warn about deactivated battery optimization on main screen

Current situation
Over at CCTG, we have talked to users who had problems with background exposure notifications. In a lot of cases, the underlying issue was simply that users had forgotten to disable battery optimizations for the app.
Since CWA is also not able to sync reliably in the background when battery optimizations are enabled, I feel this is a topic that could be dealt with in CWA.
Suggestion
Show a warning on the main screen that informs users that they should change their device's settings to disable battery optimization.
Expected benefits
Users might read the text and be more aware of the cause of issues they might encounter, and might try to fix them themselves accordingly, reducing workload for technical support.

For the CWA the battery optimization is not so critical because we are whitelisted from the battery optimization from all vendors and the Google Play Service wakes all 6hours the CWA up.

Perhaps if the deadman notification is triggered (after 36 hours) there could be a check done to see if battery optimization is enabled (or to use CWA app terminology, Prioritized Background Activity is disabled)? If so, the user could additionally be given the hint to disable battery optimization (enable Prioritized Background Activity) if possible.

I had the same issue with CCTG on my phone recently and I found out the reason why it was not working because of the contact overview screen which is not available for CWA. If the CWA does not work, I won't recognize at all.
My feeling is that disabling the battery optimization is too complex for most users. It is not so clear what to do and how important it is to do it. For the user it is not obvious that the app will work for some days but may stop working later because of this battery optimization setting.
My suggestion:
Add an algorithm to check if the app is working. If the user does not collect any new Ids anymore the app may not work anymore. By using the number of Ids that were collected in recent days it can be forcasted how likely it is that the user doesn't have had any contacts or if the app is not working.
If this algorithm detects that the app may not work anymore it should:

Add a hint or notification to the main screen that advises the user to disable Battery Optimization for that App
Add a possibility to the user so that she/he can manually reset the app herself/himself

If the user does not collect any new Ids anymore the app may not work anymore.

As mentioned in the CCTG issue, this is not technically possible with Google's Exposure Notifications API.

@di-sc @fynngodau
Fynn is right, CWA can't do anything about it, because it already went to sleep and is not having enough processor time anymore, and also the ENS Api does not provide an function to check the amount of collected RPIs (= contacts). Also, as long as the device/bluetooth is not switched off, the phone will continue to receive beacons.
If at all, then the Google Exposure Notification System would need to add such a feature: if there is a contact tracing app installed, but it stopped to provide diagnosis keys for matching for some time (more than 36 hours for example), then the ENS could notify the user, that user should open the contact tracing app to wake it up again. How's this?


Mixed-in field in class inside lazy val rhs is erroneously immutable in the IR -> IR checking error

Reproduction
Reproducible in 0.6.x and 1.x, in 2.12 and 2.13. In 2.11, things work correctly. Full repro:
package helloworld

class Apply {
  def testTraitMixinInLocalLazyVal(): Unit = {
    trait TraitMixedInLocalLazyVal {
      val foo = "foobar"
    }

    lazy val localLazyVal = {
      class ClassExtendsTraitInLocalLazyVal extends TraitMixedInLocalLazyVal
      val obj = new ClassExtendsTraitInLocalLazyVal
      assert(obj.foo == "foobar")
    }
    localLazyVal
  }
}

object HelloWorld {
  def main(args: Array[String]): Unit = {
    new Apply().testTraitMixinInLocalLazyVal()
  }
}

In 2.12 and 2.13, trying to link the above program will cause the following errors:
[info] Fast optimizing .../helloworld-fastopt.js
[error] .../HelloWorld.scala(10:13:Assign): Assignment to immutable field foo.
[error] There were 1 IR checking errors.
[error] (helloworld2_12 / Compile / fastOptJS) There were 1 IR checking errors.

Workaround
A workaround is given down below at https://github.com/scala-js/scala-js/issues/3918#issuecomment-577273675.
Analysis
The IR of the inner class is:
class helloworld.Apply$ClassExtendsTraitInLocalLazyVal$1 extends java.lang.Object implements helloworld.Apply$TraitMixedInLocalLazyVal$1 {
  val foo: java.lang.String
  val $outer: helloworld.Apply
  def foo;Ljava.lang.String(): java.lang.String = {
    this.helloworld.Apply$ClassExtendsTraitInLocalLazyVal$1::foo
  }
  def helloworld$Apply$TraitMixedInLocalLazyVal$_setter_$foo_$eq;Ljava.lang.String;V{helloworld$Apply$TraitMixedInLocalLazyVal$_setter_$foo_=}(x$1: java.lang.String) {
    this.helloworld.Apply$ClassExtendsTraitInLocalLazyVal$1::foo = x$1
  }
  def helloworld$Apply$TraitMixedInLocalLazyVal$$$outer;Lhelloworld.Apply{$outer}(): helloworld.Apply = {
    this.helloworld.Apply$ClassExtendsTraitInLocalLazyVal$1::$outer
  }
  constructor def <init>;Lhelloworld.Apply;V(outer{$outer}: helloworld.Apply) {
    if ((outer === null)) {
      throw mod:scala.scalajs.runtime.package$.unwrapJavaScriptException;Ljava.lang.Throwable;Ljava.lang.Object(null)
    } else {
      this.helloworld.Apply$ClassExtendsTraitInLocalLazyVal$1::$outer = outer
    };
    this.java.lang.Object::<init>;V();
    this.helloworld.Apply$TraitMixedInLocalLazyVal$1::$init$;V()
  }
}

in which the field foo is immutable. This is incorrect because it is assigned to in the trait setter def helloworld$Apply$TraitMixedInLocalLazyVal$_setter_$foo_$eq;Ljava.lang.String;V. One problem is that, for scalac, that field is not marked as MUTABLE. This has always been an issue for val fields in traits, so we have logic that patches up fields that are "unexpectedly" mutated. They are recorded as such in case Assign(...) => at
https://github.com/scala-js/scala-js/blob/043912f8baca36843ea1d31853930c5cd0cfc18a/compiler/src/main/scala/org/scalajs/nscplugin/GenJSCode.scala#L2359-L2360
and patched up in genClassFields at
https://github.com/scala-js/scala-js/blob/043912f8baca36843ea1d31853930c5cd0cfc18a/compiler/src/main/scala/org/scalajs/nscplugin/GenJSCode.scala#L1130-L1133
However, when all the following conditions are met:

Scala 2.12+
The class that does the mixin is in the rhs of a lazy val
That lazy val is inside a def (so it's a local lazy val, not a field)

then scalac ends up creating 2 different Symbols for that field. One is used in the Assign node, and the other is listed a member of the class, and hence used by genClassFields.
This causes our patching up to fail to process that field, since it is not the same symbol (but they have the same name/owner/etc.).

I discovered this while trying to upgrade https://github.com/lihaoyi/sourcecode to Scala.js 1.0.0-RC2. There are two tests (Apply.scala and Implicits.scala) that exhibit this pattern and hence fail. In 0.6.x, this did not show up because we do not enable the IR checker by default.
I do not think this is a blocker for 1.0.0.

It does not reveal any issue with the structure of the IR; only with the IR produced by the compiler for some patterns of code.
It does not endanger the ecosystem, because problematic code will fail to pass unit tests and hence should not end up being published on Maven.

An ideal fix would be to fix scalac upstream not to create two different symbols.
A workaround in Scala.js would be to use the Names of the symbols in unexpectedMutatedFields instead of the symbols themselves.

Is this reported as a bug upstream already?

No, not yet.

/cc @lrytz

This is -Xprint:mixin -uniqid with 2.12.10.
[[syntax trees at end of                     mixin]] // HelloWorld.scala
package helloworld#14 {
  class Apply#5004 extends Object#419 {
    def testTraitMixinInLocalLazyVal#5011(): Unit#2093 = {
      lazy <artifact> val localLazyVal$lzy#9299: scala#7.runtime#2160.LazyUnit#2763 = new scala#7.runtime#2160.LazyUnit#2763();
      Apply#5004.this.localLazyVal$1#6485(localLazyVal$lzy#9299)
    };
    final <artifact> private[this] def localLazyVal$lzycompute$1#9306(localLazyVal$lzy$1#12994: scala#7.runtime#2160.LazyUnit#2763): Unit#2093 = localLazyVal$lzy$1#12994.synchronized#4047[Unit#2093](if (localLazyVal$lzy$1#12994.initialized#9302())
      ()
    else
      {
        {
          val obj#6490: helloworld#15.Apply$ClassExtendsTraitInLocalLazyVal$1#6489 = new helloworld#15.Apply$ClassExtendsTraitInLocalLazyVal$1#6489(Apply#5004.this);
          scala#6.Predef#1566.assert#4631(obj#6490.foo#6487().==#4042("foobar"))
        };
        localLazyVal$lzy$1#12994.initialize#9303()
      });
    final lazy private[this] def localLazyVal$1#6485(localLazyVal$lzy$1#12995: scala#7.runtime#2160.LazyUnit#2763): Unit#2093 = if (localLazyVal$lzy$1#12995.initialized#9302())
      ()
    else
      Apply#5004.this.localLazyVal$lzycompute$1#9306(localLazyVal$lzy$1#12995);
    def <init>#5010(): helloworld#15.Apply#5004 = {
      Apply#5004.super.<init>#892();
      ()
    }
  };
  object HelloWorld#5006 extends Object#419 {
    def main#6527(args#6529: Array#1076[String#698]): Unit#2093 = new helloworld#15.Apply#5004().testTraitMixinInLocalLazyVal#5011();
    def <init>#6526(): helloworld#15.HelloWorld#5006.type = {
      HelloWorld#5006.super.<init>#892();
      ()
    }
  };
  abstract trait Apply$TraitMixedInLocalLazyVal$1#6484 extends Object#419 {
    <accessor> <sub_synth> protected[this] def helloworld$Apply$TraitMixedInLocalLazyVal$_setter_$foo_=#9292(x$1#9293: String#698): Unit#2093;
    <stable> <accessor> <sub_synth> def foo#6487(): String#698;
    <synthetic> <stable> <artifact> def $outer#12955(): helloworld#15.Apply#5004;
    def /*Apply$TraitMixedInLocalLazyVal$1*/$init$#6486(): Unit#2093 = {
      Apply$TraitMixedInLocalLazyVal$1#6484.this.helloworld$Apply$TraitMixedInLocalLazyVal$_setter_$foo_=#9292(("foobar": String#698));
      ()
    }
  };
  class Apply$ClassExtendsTraitInLocalLazyVal$1#6489 extends Object#419 with helloworld#15.Apply$TraitMixedInLocalLazyVal$1#6484 {
    override <stable> <accessor> def foo#9295(): String#698 = (Apply$ClassExtendsTraitInLocalLazyVal$1#6489.this.foo#9294: String#698);
    private[this] val foo#9294: String#698 = _;
    override <accessor> protected[this] def helloworld$Apply$TraitMixedInLocalLazyVal$_setter_$foo_=#9296(x$1#9298: String#698): Unit#2093 = Apply$ClassExtendsTraitInLocalLazyVal$1#6489.this.foo#9294 = (x$1#9298: String#698);
    <synthetic> <paramaccessor> <artifact> private[this] val $outer#12957: helloworld#15.Apply#5004 = _;
    <synthetic> <stable> <artifact> def $outer#12958(): helloworld#15.Apply#5004 = Apply$ClassExtendsTraitInLocalLazyVal$1#6489.this.$outer#12957;
    def <init>#6491($outer#12959: helloworld#15.Apply#5004): helloworld#15.Apply$ClassExtendsTraitInLocalLazyVal$1#6489 = {
      if ($outer#12959.eq#4038(null))
        throw null
      else
        Apply$ClassExtendsTraitInLocalLazyVal$1#6489.this.$outer#12957 = $outer#12959;
      Apply$ClassExtendsTraitInLocalLazyVal$1#6489.super.<init>#892();
      Apply$ClassExtendsTraitInLocalLazyVal$1#6489.super./*Apply$TraitMixedInLocalLazyVal$1*/$init$#6486();
      ()
    }
  }
}

The relevant parts are (field def and field setter).
private[this] val foo#9294: String#698 = _;
override <accessor> protected[this] def helloworld$Apply$TraitMixedInLocalLazyVal$_setter_$foo_=#9296(x$1#9298: String#698): Unit#2093 =
    Apply$ClassExtendsTraitInLocalLazyVal$1#6489.this.foo#9294 = (x$1#9298: String#698);

printing symbol and ID when we assign / define yields this:
assign: value foo #9294
assign: value $outer #12957
define: value foo #9320
define: value $outer #12957
We conclude that the symbol in classSym.info.decl is not the same than the one in the trees (which all use a consistent symbol).

So it seems the tree looks correct (as posted above by @gzm0). But looking at the  symbol of class K$ClassExtendsTraitInLocalLazyVal$1 at the cleanup phase, sym.info.decls has
constructor K$ClassExtendsTraitInLocalLazyVal$1 - (arg$outer: K): K$ClassExtendsTraitInLocalLazyVal$1
value foo - (): String
value foo - String
variable foo - (x$1: String): Unit
value $outer - K
method $outer - (): K

So there's a variable foo (looks good), a getter foo (looks also good), and onther value foo which i don't know what it is or where it comes from.

FTR:

This is still an issue with Scala 2.12.14 and 2.13.6
The workaround still works
The bug does not exist in Scala 3 (which is expected, since in Scala 3 we don't need to do the patching-for-mutable-fields thing: dotc correctly marks mixed in fields as mutable)

So, I had it working on 2.12 by storing and comparing the names of the unexpectedly mutated fields. However, that still failed on 2.13. The fun fact is that 2.13 does mark mixed-in fields as MUTABLE. But it only does so for the field referenced in the trees. So now it is recognized by isSuspectedMutable as being mutable, and therefore not recorded as unexpectedly mutated at all. But then the symbol that we find in the decls is still not MUTABLE, and so we still emit invalid IR.
I can try a few more things, but this is getting uglier than expected.

I was considering using the tree's ValDefs as the source of symbols to fix the issue. Since that would deviate from what the JVM back-end does, I was suspicious. I added the following to genClassFields:
      val fieldSyms = cd.impl.body.collect {
        case vd: ValDef => vd.symbol
      }.toSet
      val fieldSyms2 = classSym.info.decls.filter(f => !f.isMethod && f.isTerm && !f.isModule).toSet
      if (fieldSyms != fieldSyms2) {
        System.err.println("---")
        System.err.println(classSym.fullName)
        System.err.println(fieldSyms.toList.sortBy(_.name.toString()).mkString(", "))
        System.err.println(fieldSyms2.toList.sortBy(_.name.toString()).mkString(", "))
      }

The idea being to identify differences in the list of symbols that we get from trees and from the decls.

With all that, I propose that we close this issue as Won't Fix, on the grounds that:

It happens only in obscure cases
There exists a simple workaround, which does not affect the public or protected API
The core issue is clearly in scalac
It seems very hard to work around it in the Scala.js back-end
It is fixed in Scala 3

The only thing that holds me back is that a library could publish artifacts where this problem appears, and that they wouldn't notice because they only test in fastOpt, which doesn't check the IR anymore. And then users trying to use that library would get IR checking errors when trying to fullOpt. But that is already a problem today.
I still have hope that we could fix the root issue in scalac, but I have not been able to do that so far.
@gzm0 WDYT?

Stupid question: is there any real downside to always marking fields as mutable? And if there is, wouldn't it be super easy to properly detect whether a field is mutable in the analysis pass?

Yes, there is a very real downside: the optimizer does a much poorer job with mutable fields of inlined class instances than with immutable ones. When inlining (stack allocating) a class instance, its val fields become immutable LocalDef, with a refined type, aliasing, constant folding, etc. Mutable fields become local vars, which always keep their declared type, are not aliased and do not do constant folding.
We could decide that in the analysis, but it would be quite a lot of work. Now, that does make me think that we could simply do that "analysis" in the compiler. In addition to storing the names of unexpectedly mutated fields, we could simply store the names of all mutated fields. That way we wouldn't miss the ones that were missing in my 2.13 situation above. I will try that.


Meilisearch config file

Summary
We want a way to configure Meilisearch with config files. The format of the file has not yet been decided upon, but it will be one of JSON, toml, or yaml.
Motivations
This file will serve to consistently launch MeiliSearch instances, as executable options list grows bigger and bigger.
Explanation
The options in the file mirror these already present in the executable options and the environment variables.
We will be able to launch with a configuration file with:
meilisearch -c config.json

or
meilisearch --config config.json

all settings in the config file are overridden if on option or an environment variable is present for the same setting.
Related

[ ] Validated by the team (@people needed)
[ ] Test added
[ ] Documentation //Change xxx or remove the line
[ ] SDK/Integrations //Change xxx or remove the line

Great feature!!!
What would be allowed in the config file?

settings?
flags? (--no-analytics)
indexes uid?
...

I think we could maybe choose TOML for the same reasons Patrick Walton does for Cargo.

Perhaps adding "env override" to specs may be of help.
Override
Override props specific to one instance
meilistart-mysitesearch.sh
#  'predictable pattern' environment variables to override
#
DB_PATH = /mnt/datastorage/mysite/meili/data/instance1
PORT_BIND = 9191
#CONFIG_FILE=
# config files can be refered also from a http url (github/other)?
/my/bin/meilisearch --config-file file:///path/to/common-config.toml

To put common defaults in a toml file
Encourages org wide standard setting, while individual instance can use.
common-config.toml
#One may have all keys in small letters, hyphenated.
[search]
db-path = /mnt/disks/datadisk/apps/meilisearch/data/default
db-size = 1
host-bind = <IP_ADDRESS>
#db-update-size = #Perhaps can avoid exposing?
port-bind = 7700

[logging]
log-dir = /var/tmp/logs/apps/meilisearch/default
log-rotation = daily|weekly|monthly ?

[security]
meili-env = production
master-key = test123
ssl-authentication-path =
ssl-certificates-path=
ssl-key-path =
ssl-ocsp-path =
ssl-require-auth = true

[additional]
#Perhps may use a uniform "enable" prefix. Perhaps may avoid mixed enable/disable/ no-xx no-sentry etc.
enable-analytics = true
enable-sentry=true
#perhaps if log dirs / data dir is absent this may create. default to false?
create-missing-dirs = false

As stated in #958, clap (therefore structopt) fails to correctly parse  flags when used with an env variable. This force the user to input true to flags to activate them. We need to parse env another way, and merge the config from file/env/args with the correct precedence (and default values).


Update big5 workload config to use the ordered documents snapshot

Description
The big5 workload by default uses 8 ingestion clients to ingest the data.
During our analysis we understood that the order of data based on timestamp is not maintained during ingestion process and this causes skew in query latencies that use time filters.
We have re-created the snapshots for big5 after ingesting using 1-client to maintain the timestamp order of the
Related Issues
Resolves #[Issue number to be closed when this PR is merged]

Check List

~[ ] Functionality includes testing.~
~[ ] API changes companion pull request created, if applicable.~
~[ ] Public documentation issue/PR created, if applicable.~

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rishabh6788 Can you check if this need to be backfilled to the 2.x branches?

Not required as workflows that start on comment add only run for default branch, main in our case.


Update the new provider API script template with the model_3d provider

Problem

"Create a new provider API script" template only has audio and image provider templates.
Description

We need to update the new provider API script template with the model_3d provider.
Additional context

This template can be used to create and pre-fill a new provider script. This is done to make the process of script creation easier for new contributors.
Implementation

[ ] 🙋 I would be interested in implementing this feature.

Closing as 3d models are indefinitely on hold and no work should be done on them until we re-plan this project.


Refresh device-list and manual entry

Hi!
When I try to refresh device-list nothing happered but I need to use manual entry because "Failed to request device-list!" but sometimes the node forbidden user-friendly name and stop working after deploy.
I use Home Assistant OS 6.1 on RPi 4 with Node-RED Add-on 9.2.1 and latest version of this plugin (0.19.2)
https://user-images.githubusercontent.com/10048197/126401846-667c448f-7724-4670-892d-b88681154a52.mp4

It should work after your first deployment, if this is the correct name that is used in the mqtt messages. Unfortunately i havn't had a chance to look at the problem that it does not fetch in Home Assistant. I only know that HA host the http endpoint on a different base URL but without testing gear I was not able to resolve the issue.
You could host node-red standalone and than you should be able to fetch the device names.

No no, it works the first time when deployed, but if you make a mistake and open the node (without modifying it like the video), the node forgets the device that I entered manually and when you deploy nodes stop working

Fix for querying the device list is implemented in #119 and should be shipped with the 0.19.5 release in the next few days.
For the broken fallback, I opened a new issue: #119


feat: add attach_stub function to load imports from type stubs

following on the discussion at https://github.com/scientific-python/specs/pull/139, here is an implementation that loads imports from type stubs for your consideration

I like it! Does this then address all type checker concerns, or are there other outstanding ones?
I'd love for @jni and @tupui to cast an eye over this PR and share their impressions.

Does this then address all type checker concerns, or are there other outstanding ones?

I think this does it.  With the pyi file being the source of truth, it’s sort of a  “type checking first” approach, that also works at runtime.  Really I think the only downside here is that note I included about making sure the stub gets included in the wheel/sdist.  I can imagine someone missing that note in the readme, having it work locally, then shipping an unimportable package (lacking the stubs)

Thanks very much for this @tlambert03. I'm going to merge for now, since @jni liked the implementation in https://github.com/scientific-python/specs/pull/139#issuecomment-1181635145
It would be the cherry on top if you could also update the high level description of https://github.com/scientific-python/specs/blob/main/spec-0001/index.md (feel free to add yourself as co-author there).


Command Palette should show "Go to Symbol in File" and "Go to Symbol in Workspace"

VSCode Version: 1.6 insiders
OS Version: any

With #11494 the Go menu now includes Go to Symbol in File and Go to Symbol in Workspace. The command palette only includes Go to Symbol which is Go to Symbol in File. There is no command for Go to Symbol in Workspace. We should add the command and make sure they are called the same in the command palette and the Go menu.

Makes sense for consistency.

Verifying.
The action is now shown in the command palette, but it doesn't show the keybinding CTRL-T on windows.

The key binding is shown in the Go menu:

@egamma weird, not for me:

I suspect you changed the keybinding and did not restart? The menu needs a restart to show a change.

Issue resolved. Alex's Lcov extension steals 'CTRL+T', easily tracked down thanks to the Contributions tab


📝 Update 'Indicating availabilty' secion

Adding the ways to indicate availability that we discussed during our 2023-12-12 team agreement meeting.

Adding @Rosi-D as a reviewer in light of the question here


Modified rancher testcases to get cluster name

What this PR does / why we need it:
1)Modified the rke testcases to get cluster name got project creation
2)Modified rke token and URL variable according to latest jenkins changes
Which issue(s) this PR fixes (optional)
Closes #https://purestorage.atlassian.net/browse/PB-7330
Special notes for your reviewer:
Pass log: https://aetos.pwx.purestorage.com/resultSet/testSetID/686405

@snigdha-px I'm merging my testcase PSALowerPrivilegeToHigherPrivilegeWithProjectMapping also. Please change the source & destination cluster names.

sure


Fix the swarm manager container creation (using docker-machine ssh)

Modified the step (on the "Evaluate Swarm in a sandbox" page) which tells the user how to set up the Swarm container on the manager. Running the command from the docs as it stands causes the user's machine's /var/lib/boot2docker directory to be mounted into the Swarm manager container, instead of the manager VM's /var/lib/boot2docker directory.
I'm new to this, so if I've made a mistake, all good - my apologies.

@jacobmarshall did you have issues running through the tutorial? Since docker-machine has limited access to the host (Mac or Windows) file systems (/Users directory), all other paths come from the VM's file system, as stated here: https://docs.docker.com/engine/userguide/containers/dockervolumes/
So I'm not sure that this change is needed.
cc @nathanleclaire can you confirm?

If that is indeed the case, which I do not doubt, I can only assume my issue was to do with a change I made to the commands when I ran them. I did however run into an error at one point, which I will grab off the computer I ran the set up on later, which stated it was unable to load the certs (after doing a docker logs on the swarm manager container).

I just reconfirmed, and the current way of mounting works for me. I have a Gist of all commands if you want to run it quickly: https://gist.github.com/nishanttotla/e4b623ce47e944086ebc

Cheers @nishanttotla, I appreciate your time.


About QR code and other thoughts

Hello again
I've been testing Thorium (https://github.com/Alex313031/Thorium-Win/releases/tag/M114.0.5735.134) alongside Ungoogled chromium and Bromite - buildtools for a few days now.
First. I like that in Thorium there is an option to enable the built-in google translate. And the built-in translator works flawlessly, while this menu - google translate is permanently disabled in Ungoogled chromium and in Bromite - buildtools with no option to enable.
In Ungoogled chromium there is a flag chrome://flags/#sharing-qr-code-generator. But in Thorium there is no way to disable "QR code".
On Bromite – buildtools is disabled, not even an enable flag. I didn't even find where it was disabled.
And second: Where do I remove the "Enable featured Thorium experiments" button to remove it from the ribbon?!
Third: I found that the "Secure Preferences" file ruins the transfer of settings from the "User Data" folder. Without this "Secure Preferences" file, only the bookmarks are transferred. No extensions transfer successfully, nor any other settings. The situation is the same when moving the "User Data" folder to Bromite – buildtools. I had to install each extension one by one, but I have extensions that have specific settings (which extensions don't have the ability to export/import settings).
And "Secure Preferences" breaks all personal settings in chrome://flags/. And this further complicates when trying to test between different Chromium browsers by carrying over your personal settings. Unfortunately no one has suggested export/import on chrome://flags/.
And one more thing - suggest an option to use https://github.com/henrypp/chrlauncher/ when using Thorium.
Because @uazo has proposed his own option to use chrlauncher because @henrypp doesn't want to update his program by adding other Ungoogled chromium projects as well as Thorium.
@Alex313031, look here: https://github.com/uazo/bromite-buildtools/ at the bottom.
Create a chrlauncher.ini

[chrlauncher]
Custom Chromium update URL (string):
ChromiumUpdateUrl=https://github.com/uazo/bromite-buildtools/releases/latest/download/updateurl.txt

Command line for Chromium (string):
See here: http://peter.sh/experiments/chromium-command-line-switches/
ChromiumCommandLine=--user-data-dir=".\User Data" --no-default-browser-check

Chromium executable file name (string):
ChromiumBinary=chrome.exe

Chromium binaries directory (string):
Relative (to chrlauncher directory) or full path (env. variables supported).
ChromiumDirectory=.\bin

Quite a long opinion turned out...

Because Thorium browser has enabled Google's services, it can use a series of functions such as translation normally.
Regarding the Disable QR code generator feature, this feature is not introduced in Thorium browser at the moment, so it is not available in Thorium browser now, and the decision of whether to introduce this feature will be made by Alex in the future.
Regarding Enable featured Thorium experiments, you can find Chrome Labs in chrome://flags and turn it off.
For User data, you can find Disable Encryption and Disable Machine ID in chrome://flags, turning them on will make User data more portable. For more information about these two features, you can get more information in the issues section of the Thorium repo
Regarding the chrlauncher issue, again Alex needs to make a decision.
@Rusenche

@Alex313031?!

@gz83
The concept is popularized as "user experience".
It is extremely convenient to remove them.
You advise me to turn off chrome labs... (I wrote that it is off by default).
I'm catching on to your start of your sentence, @gz83, "if you don't like"... @gz83, advise how to turn them off if I don't like the QR CODE and avatar above?
And a few months ago I wrote and listed how many Chromium-based browsers have turned off QR code, but here it is not even taken into account.
..........
I found a problem. Not sure which version of Thorium it originated from, but https://github.com/NeverDecaf/chromium-web-store/releases is no longer functional. This extension had features to visualize if the installed extensions have updates available and the user decides whether to install them or not. When porting the profile - all extensions were updated, although the extension does not allow this to be done automatically. There are problematic extensions whose developers push malicious fixes into new versions, and you just want to stick with the version that isn't affected. A typical example is the extension: https://chrome.google.com/webstore/detail/save-image-by-right-click/hhmnengcgekecnlielgcfcbjanjlnifg/. And now no version of the chromium-web-store extension works or prevents any extension from auto-updating, although I have marked a few extensions not to check for updates. It's too bad that the chromium-web-store extension doesn't work as intended in Thorium.

It's not difficult to turn off the chrome labs, just need Alex to turn it off in the code, or turn it off as I mentioned above, but since the code for the 116 version of the feature has been frozen and the new 116 version has been released to the public, there will be no modification to the code of the feature part for the time being.
As for disabling the QR code generator and hiding the avatar, the code will need to be reworked, and combined with the above chrome labs, I will copy this issue to Alex again and let him make the final decision.
Is there anything bad about the QR code generator and the avatar in the top right corner, I'd like to know what you think of these two features and if it really affects your use?
Regarding the chromium-web-store extension, does it work properly in version 116 of chrome/chromium?
@Rusenche @Alex313031

@gz83 and @Alex313031, thanks for the replies.
 With Thorium, you have no control over extensions. What do I mean? If an extension has an update available - Thorium updates it automatically without asking us if we want to. What if we don't want to install the available update?!
As a user, I wait at least a week for every single update and read user reviews. And in the case of the extension I mentioned above (https://chrome.google.com/webstore/detail/save-image-by-right-click/hhmnengcgekecnlielgcfcbjanjlnifg/) - it installs a malicious search engine and such in its latest version. I mean that Thorium does not provide a choice - whether I want to update an extension or I want to stay with the current version of the extension. Because Thorium still doesn't provide any option for the extensions in terms of available updates. What if we don't want to install the available update?!
chromium-web-store has exactly such a function and it worked successfully in Thorium, but I don't know from which version it no longer works correctly.
chromium-web-store should work again in new Thorium versions so we can choose - whether to update available updates to installed extensions; we also have the option to ignore an extension from checking for available updates and such at all. That's my idea. Chromium-web-store features are perfect and provide prevention for users. Please consider restoring the proper functioning of the chromium-web-store in Thorium. I'm not parting with this extension unless you suggest an alternative extension that performs the functions of chromium-web-store.
@Alex313031, agree that even you as a developer want to have control over even just choosing whether to update extensions or not.
@Alex313031, it's the same with Thorium - it's up to the user to update the Thorium version or not. So you've made Thorium not check for updates, nor install them automatically. It's the same with extensions, but so far they (the extensions) don't have that feature that you did on Thorium. There is an extension ready for this purpose… (chromium-web-store).
I hope you understood my point correctly.

Will the chromium-web-store extension work properly in version 116 of chrome/chromium?
@Rusenche

@gz83 @Rusenche It might be interesting to make a flag to control auto update behavior of extensions. There is an enterprise policy for this, so if I can just find where in the code it is controlled by the policy, I can put an if else statement behind a commandline flag, something like --no-extension-updates

@gz83
I confirm that chromium-web-store extension works successfully and flawlessly in Ungoogled Chromium and in Cromite, I don't know about Brave, I haven't tested it recently. But I don't know why Thorium ignores the features of this extension...
@gz83 and @Alex313031 I suggest you both test the extension in question in Ungoogled Chromium by bringing your profiles over to see if there are updates available for given extensions it shows updates available (currently mine says 6 available new updates but not installing them) and you have the choice to install, to ignore an extension update, or to choose which extension to update - or to install all available updates. Exactly such features, @Alex313031, it wouldn't offer it the primary idea you share. It's more convenient to check which in Thorium ignores the features of the mindblowing extension in question and Thorium updates everything…

I still want to ask the question mentioned above, does this extension work properly on Chrome/Chromium version 116 (not Ungoogled Chromium, Cromite, etc. browsers)?
@Rusenche

@gz83
I tested with GoogleChromePortable_116.0.5845.188.
The bookmarks were transferred, but not the extensions.
The extension (chromium-web-store) installs as crx but doesn't work because:

no chromium-web-store flag;
in a red inscription on the extension it says: "This extension is not listed in the Chrome Web Store and may have been added without your knowledge.".

It's practically a completely impossible test in Chrome.

OK, thanks for the test results. As Alex said earlier, there may be a new experimental flag for the Thorium browser, and either Alex or I may look into this further
@Rusenche

I tested https://github.com/Alex313031/Thorium-Win/releases/tag/M117.0.5938.157 for the presence of the specified flag (chrome://flags/#sharing-qr-code-generator), but unfortunately again it was not added.

why is there no feature to download and install the crx extension without the chrome web store?

why is there no feature to download and install the crx extension without the chrome web store?

You can package the extension through developer mode, or search for other solutions on the Internet.  Additionally, the Google Web Store is not hosted by us.
@candrapersada

but why is there a flag chrome://flags/#extension-mime-request-handling in thorium-legacy
but in thorium there is no flag chrome://flags/#extension-mime-request-handling?

but why is there a flag chrome://flags/#extension-mime-request-handling in thorium-legacy but in thorium there is no flag chrome://flags/#extension-mime-request-handling?

thorium-legacy currently cooperates with supermium and uses part of supermium's code. This flag may also come from this.
If you keep Google Suite, I guess you don't need to enable this flag.
@candrapersada


xClusterDisk: Should check if disk is actually available for use

Problem
https://github.com/PowerShell/xFailOverCluster/blob/c5702cac81a46a844c7d903c56be7ae8a90ad9f0/DSCResources/MSFT_xClusterDisk/MSFT_xClusterDisk.psm1#L90
Because this is using availabledisk and then just adding them, it's assuming the cluster can use the disk in the next procedure. The disk does not exist so it errors out incorrectly
The property 'Name' cannot be found on this object. Verify that the property exists and can be set.
Possible Solution:
Check if the disk actually exists
$clusterdDisk = Get-ClusterAvailableDisk | Where-Object -FilterScript {
    $_.Number -eq $Number
}

if($clusterdDisk)
{
    $clusterdDisk | Add-ClusterDisk
}
else
{
    throw error
}

It should definitely return the correct error as per your suggestion.
Curious though, why does it not have the disk available? Should we have a WaitForClusterDisk resource? 🤔

Essentially that's correct. Basically, the cluster is created already, the disk was added over iscsi, but the other node didn't have the disk yet, so it won't allow you to add the disk until that disk is shared between the two.
If I go to node2 and refresh the iscsi target, then it works afterwards

Ah, I understand. So Get-ClusterAvailableDisk does not see the disks until they exist on both nodes? I was wondering if it would say Add-ClusterDisk -ErrorAction ‘Stop’ It would it throw the correct error, but won’t work if the disk aren’t even visible yet. So I like your suggested solution.

Correct. Just comes back empty