Allow extensions to have return values on trigger

This is needed for DTF to do return values. We should also be able to leverage it for Http.
This shrinks usage of IResultProcessingBinding and the hack we have here:
https://github.com/Azure/azure-webjobs-sdk-script/blob/dev/src/WebJobs.Script/Binding/GeneralScriptBindingProvider.cs#L129
_applyReturn = attribute.GetType().GetMethod("ApplyReturn", BindingFlags.Static | BindingFlags.Public | BindingFlags.NonPublic);
This is basically the script side for consuming https://github.com/Azure/azure-webjobs-sdk/issues/1104

VS tooling depends on this, see https://github.com/Azure/azure-webjobs-sdk-script/issues/1508

We have support for return values in the SDK, this part now means:

removing the CanProcessResult stuff in Script.
script's IL gen wrapper today converts return values to 'out T'. Instead, it should convert to return value and let SDK bind against that.
This will need an update from HttpBinding. (I have a branch with that)

JFYI, the Durable Functions issue blocked on this is here: https://github.com/Azure/azure-functions-durable-extension/issues/13

@cgillum Afaik this issue has been fixed, except possibly HttpBinding.

@lindydonna you may be confusing this issue with https://github.com/Azure/azure-webjobs-sdk/issues/1104, which was fixed. This issue specifically tracks adding support to the scripts repo - i.e. for non-VS projects. Right now, only HttpBinding supports return value processing via some hacks. Mike can provide the details since I regularly bug him about this. :)

Right. Remaining work is described in my previous comment on this thread, https://github.com/Azure/azure-webjobs-sdk-script/issues/1422#issuecomment-316556686

@MikeStall @cgillum Thanks for the clarification. It's hard to keep track of all these details, so I appreciate these explanations. :)

This is a breaking change, so we're just checking into Core (not dev).
The reason it's a break is that before, unused return parameters are ignored. That was mostly a side-effect of the implementation and not an explicit design choice.
Now, unused return parameters are an indexing error.  This is behavior inherited from SDK's binding rules.
For example, before this would succeed, even through it's most likely a user bug (mismatched httpresponse and queue trigger)
  HttpResponseMessage Func ([QueueTrigger] Foo x)

Fixed in /Core.


AWS Storage

Soon Django will change the 'AWS_DEFAULT_ACL' to None as default.
As a consequence all images uploaded to production will be not accessible.
Now it is a warning, and to solve it you should set this line:
https://github.com/EncontrosDigitais/bootcamp/blob/master/config/settings/production.py#L87
I promise get back to fix it if no one catch before.
My branch is way to modified, I am rushing to fix other issues now before launching.


PpowerLauncher Closed for No Reason

Microsoft PowerToys version
0.45.0
Running as admin

[X] Yes

Area(s) with issue?
PowerToys Run
Steps to reproduce
turn on powertoys run and press hotkey, nothing happens
go to task manager check there is no PowerLauncher.exe open
✔ Expected Behavior
PowerToys Run opening and PowerLauncher process open
❌ Actual Behavior
PowerToys Run hotkey does nothing and PowerLauncher process disappears after a few seconds when I turn on Run
Other Software
No response

Thank you for reporting that!
Could you please send us a bug report?

How to generate the report:
1. Right-click on the PowerToys icon in the tray menu and select Report Bug.

2. The report is saved on your desktop. Please drag and drop the report into a GitHub comment.

got the same issue and here's my bug report
PowerToysReport_2021-09-24-21-57-29.zip
,

Hi @trans19 ,
Thank you for the logs.
Everything seems to be fine in PowerToys Run logs, but the module interface logs are clean.
If you try to open PowerToys Run through OOBE, does it work?
"Settings" -> "Welcome to PowerToys" -> "PowerToys Run".
Click the "Launch PowerToys Run" and verify PowerToys Run gets activated.

Hi @jaimecbernardo
Got nothing from OOBE, no search bar, the PowerLauncher.exe is also not launched.
I also tried to reopen the PowerToys, at first, I can see the PowerLauncher.exe launched in Task Manager's Details, but then it closes by itself after 5 sec or so

Hi @trans19 ,
While PowerToys Run logs don't directly contain anything, I do notice some event viewer errors mentioning "amdxn64.dll".
Any idea what it might be?
Sounds like some graphics cards driver or application dll from AMD.


Eliminate pylama.ini; replace with setup.cfg

Add requirements-dev.txt
Implement version solution
Enable pylama checking

I assume that it is known that there are no unit tests for this driver?

+1


Is there a way to globally change the locale?

It's not very DRY if I override the locale on every instance. Something like this would be great, but maybe not feasible to have all instances update their props.
    VueTimeago.locale = 'ja';

That would be cool 👍

I also need that~
Specific case： Vue   &   SSR  &   runInNewContext: false
Thanks ~

:tada: This issue has been resolved in version 5.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:

https://github.com/egoist/vue-timeago#update-locale-globally This may be what you want.


Enable a repository of anonymized schemas

This task is two-fold:

Create a folder/repository where people can contribute their anonymized schemas (through PRs).
Add a Helm config to let people choose which schema they want to use when running Adelphi.

┆Issue is synchronized with this Asana task by Unito

Should we perhaps move the second part of this (select a schema when running Adelphi) to https://github.com/datastax/adelphi/issues/53?  Thoughts @grighetto ?

@absurdfarce yeah, sounds good, since we agreed to separate the "contribution" effort from the "processing" effort, I think it makes sense.

Schema has now been created at https://github.com/datastax/adelphi-schemas and made public


Xiaomi Philips Eyecare 2: Fixed "translate" method when "value" is None

Description:
It's a very quick and dirty fix for that issue. Final solution should be to find out why those parameters are gone. In the meantime, this patch brings that device back to life.
Related issue (if applicable): fixes #
Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for configuration.yaml (if applicable):

Checklist:

[x] The code change is tested and works locally.
[ ] Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

[ ] Documentation added/updated in home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[ ] New dependencies have been added to the REQUIREMENTS variable (example).
[ ] New dependencies are only imported inside functions that use them (example).
[ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
[ ] New files were added to .coveragerc.

If the code does not interact with devices:

[ ] Tests have been added to verify that the new code works.

Hi @miguelgilmartinez,
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!

This PR addresses issue #16269, correct?

Please open an issue. We can discuss a proper solution.

Not exactly. This issue is about a part of that device, composed by two
bulbs and one of them is not working. My patch is about complete device
discovering.
On Mon, Oct 8, 2018 at 5:09 PM Sebastian Muszynski<EMAIL_ADDRESS>wrote:

This PR addresses issue #16269
https://github.com/home-assistant/home-assistant/issues/16269, correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/home-assistant/home-assistant/pull/17210#issuecomment-427871809,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEo6PC-a_U3nlSFNor4VmpdCcuH99X51ks5ui2qugaJpZM4XLxS2
.

The yeelight API has a set of different calls for what they call a background light (https://www.yeelight.com/download/Yeelight_Inter-Operation_Spec.pdf), which is not completely supported by the python-yeelight. So in order to support those two, this needs to be fixed in python-yeelight (please open an issue https://gitlab.com/stavros/python-yeelight).


fix: Skip non-existent optional fields in objects

Fixes #50

Bundle size comparison

size comparison

browser
uncompressed 4.73 kB  ▶ -13 B (-0.27% ▼) gzipped 1.91 kB  ▶ +1 B (+0.05% :small_red_triangle:)

main
uncompressed 4.62 kB  ▶ -13 B (-0.28% ▼) gzipped 1.83 kB --

module
uncompressed 4.48 kB  ▶ -13 B (-0.29% ▼) gzipped 1.83 kB  ▶ +2 B (+0.11% :small_red_triangle:)

Speed comparison
PR

library
relative speed
operations per second
avg. operation time

@typeofweb/schema@base-branch
0%
(1,465,702 rps)
(avg: 682ns)

@typeofweb/schema@pr-branch
-1.04%
(1,450,479 rps)
(avg: 689ns)

<EMAIL_ADDRESS>-94.58%
(79,477 rps)
(avg: 12μs)

<EMAIL_ADDRESS>-96.45%
(52,038 rps)
(avg: 19μs)

<EMAIL_ADDRESS>-96.92%
(45,182 rps)
(avg: 22μs)

<EMAIL_ADDRESS>-99.78%
(3,166 rps)
(avg: 315μs)


Submit Member Account at the JetBrains Open Source Support Program

Member Account at the JetBrains Open Source Support Program
Thank you for taking the time to submit your membership form. The review board will evaluate your request over the next few days. We will make every effort to take care of this promptly and will notify you as soon as the review board has come to a decision.
If you experience any problem receiving our response in a timely way, please contact JetBrains Team at<EMAIL_ADDRESS>

Change to http://www.appveyor.com/

https://ci.appveyor.com/project/milesibastos/nhibernate-aspnet-identity


Simplify Connect Dialog layout and sizing

I noticed that Connect Dialog is bigger than necessary and while trying to fix it I noticed that there's some weirdness about how the size is defined. The PR cleans it up a bit:

remove setting minsize when toggling advanced mode
only define vertical minimum size of the dialog
add horizontal minimum size to the main VBox containers
remove unnecessary VBox root

As a result, the horizontal minimum size is now automatically determined from the left content and right (advanced) content fields, making the logic simpler.
I also made the dialog more compact.
Before:

After:

Thanks!


Add support for custom local directories and wildcard versions

This adds support for two additional features:
Custom Local Directories
haxelib dev enables the use of a custom local directory, but forces an "override always" behavior that can be undesirable. This adds support for custom named directories, with the default being called "local". The current syntax is as follows:
haxelib install path/to/mylib
haxelib install path/to/mylib custom_name

haxelib install path/to/mylib will install "local" with a path to "path/to/mylib", while adding the optional "custom_name" argument installs it as "custom_name"

1.0.0 1.0.1 [local:path/to/mylib]

You should be able to remove, set and path similar to other types of versions
Wildcard Versions
There is also added support for wildcard versioning:
haxelib version mylib
haxelib version mylib:1.0.0
haxelib version mylib:1.*
haxelib version mylib:1.0*
haxelib version mylib:1.0.0-*
haxelib version mylib:1.0.0-beta*

This should work for "install" and "path", there may be some commands (such as "set") that still need to have support added
I would be happy to discuss these features, and how they can be polished to fit in best

Closing. "Local" versions are no longer needed as dev no longer overrides when specific versions passed into path (7bd9263) or run (63baf8a), and installing locally from zip is also available. The remaining changes would probably require a new PR.


Remove refresh of Exec[systemd-daemon-reload] for every service

Hi,
I have a strange issue which I believe is caused by this
Exec['systemd-daemon-reload'] -> Service<| |> in the main manifest.
https://github.com/justin8/justin8-systemd/blob/master/manifests/init.pp#L14
In one of my profile manifests I have the following:-
service { 'pxp-agent':
ensure => stopped,
enable => false,
}
With this included I get the following dependency cycle:-
==> dashboard: (Exec[systemd-daemon-reload] => Service[pxp-agent] => Class[Profile::Puppet] => Class[Profile] => Profile::Service[dashboard] => Systemd::Service[dashboard] => File[/etc/systemd/system/dashboard.service] => Exec[systemd-daemon-reload])
This is probably an issue with my particular setup but I was a bit confused as to why the Exec is included as from my understanding you only need to refresh systemd when the unit files change and this is already done as part of the defined type in https://github.com/justin8/justin8-systemd/blob/master/manifests/service.pp#L42
Hope this makes sense and feel free to reject if I'm wrong :)
Perhaps @alexiri will be able to help?
Thanks,
Trevor

Hi @trevorrea,
That's strange, I don't have that issue with my manifests. What's special about your particular setup that you think may be causing it?
Cheers,
Alex

Hi @alexiri
Apologies for delay coming back to you.  I've had a look and the issue is that in the main manifest of my profile module there is a require for profile::puppet which contains
service { 'pxp-agent':
ensure => stopped,
enable => false,
}
and which is creating the dependency cycle.    So yes it's a stupid issue on my side so can probably be closed except that I still don't really understand why this line exists.
refresh systemd before every service
Exec['systemd-daemon-reload'] -> Service<| |>
Thanks,
Trevor

I guess that line is there in case someone puts a custom systemd unit file and forgets to exec systemd-daemon-reload.

OK.. I've forked this into my own private version and changed the defined type to:-
file { "${unit_path}/${servicename}.service":
ensure  => 'present',
owner   => 'root',
group   => 'root',
mode    => '0644',
content => template('profile/systemd/service.erb'),
notify  => Exec["systemd-daemon-reload-${name}"],
}
exec { "systemd-daemon-reload-${name}":
  command     => 'systemctl daemon-reload',
  refreshonly => true,
}

Not sure if that is better than having it in the main class but I'll close this MR anyway.  Thanks!


Quickstarts slack channel and hero rotation

Description
As we head to launch, we need to get some support stuff setup. This includes a help channel and hero rotation.
Acceptance criteria

[x] Create the slack channel
[ ] Define a hero rotation that can span multiple teams

dup of this https://github.com/newrelic/newrelic-observability-packs/issues/212 so closing


Add option to just generate the run configuration instead of running the analysis code

Add another button to the DVC Run panel to do this.
The dvc_interface.py generates the appropriate pointclouds for a bulk run and then it creates a json config file which contains the locations of the pointcloud file and other run parameters. This is passed to the dvc_runner.py.
The dvc runner loops through each of the pointclouds and for each it crops the pointcloud file to just the chosen number of points, in order of distance from point 0, and it loops through the number of sampling points in the subvolume. For each, it generates a config file for the dvc code and then runs the DVC.
The dvc runner needs modifying so that the cropped pointcloud file is saved - currently this is overwritten in each run.
It also needs modifying to have an option to only save the run config files instead of running the dvc as well. We then need to make a version which works without displaying a progress bar, so a bulk run could be performed remotely on a server.
It would be useful to make a directory struture so we have a folder for each pointcloud and within that a folder for each number of sampling points in the subvolume, so the files for each run are saved in their own separate folders.

I'm thinking at a flat structure though, where we create N directories for all the runs we need to do. In each directory there needs be all the necessary files.
I guess I need to understand how the interface then graphs the results.

A flat structure sounds good


Explicitly hint the data source config about the postgresql driver

Description:
It seems that in some environments the postgresql driver is not available on the mta controller classpath, thus causing connection to the postgre datatabase fail with java.lang.RuntimeException: Failed to get driver instance for jdbcUrl=<some-valid-url>. Here is a separate slack conversation on the issue: https://cloudfoundry.slack.com/archives/C9V0Z8ZPF/p1680505547626489
This PR introduces an explicit dependency to the postgresql driver, its latest is currently 42.6.0. This seems to solve the issue.
However, one should keep in mind that doing that prevents a buildpack from managing the driver version, e.g. it would not be able to bring potential security fixes without changing this dependency.

Thanks for the PR!
It is worth to having it in place but for the time being we will refrain from having it in master. It is good for testing purposes only

@boyan-velinov this would be useful for us in the Autoscaler team. Is there a reason for not having it in the master version ?


What does mean "Your image should be 100 pixels wide. Browser zoom should be at 100%."

Challenge Size your Images has an issue.
User Agent is: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.87 Safari/537.36.
Please describe how to reproduce this issue, and include links to screenshots if possible.
My code:

<link href="https://fonts.googleapis.com/css?family=Lobster" rel="stylesheet" type="text/css">

CatPhotoApp

Kitty ipsum dolor sit amet, shed everywhere shed everywhere stretching attack your ankles chase the red dot, hairball run catnip eat the grass sniff.

Purr jump eat the grass rip the couch scratched sunbathe, shed everywhere rip the couch sleep in the sink fluffy fur catnip scratched.

I use with Chrome and the Browser Zoom is 100%. but I cannot finish this page

@mrdostory
Thanks for the report. Have you sought assistance in the chat room, before reporting?
The issue tracker is for reporting bugs only.
Please use the chat rooms:

HTML/CSS help chat room
JavaScript help chat room
Other Official Rooms

or try looking through our forum for help with a specific challenge.
Happy Coding!

i have the same problem i have tried refreshing and resetting my code and it still doesn't make the first task green I got the browser zoomed up to 100% and the  in the only img src tag there like in the above example by raisedadead.i've checked the forums and this was the first one i found. any ideas if there is a bug in the program?


Remove use of Rack::BodyProxy

Rack::BodyProxy allows deferring execution until after the response has sent to the client. It's intended for expensive cleanup (after the response is rendered, but before it's sent) that could delay delivering the response to the client. Cleaning up memoization is not an expensive operation, and I suspect this use of BodyProxy is the source for warnings in https://github.com/jnunemaker/flipper/issues/604.
I haven't studied it closely, but my guess is that after this middleware returns the rendered response body, puma (or possibly  any threaded web server) delivers the response to the client in another thread, returning execution of the app thread to Rails to start the next request. If the next request starts before the previous one is finished sending, then the next request will produce the warning.
Updated to added more details.

@canderson-activatecare It looks like this does not fix the underlying issue in #604, so I'm not sure there's a good reason to merge it right now.

After thinking about this some more, I think this should still be merged. It may not be the only cause of #604, but I don't see how it can't be one cause. The Rails app should be done with execution by the time the block returns, so I think it's safe to stop memoization at that time.
Merging!


json: cannot unmarshal object into Go value of type []string

Hi,
I’ve got a json: cannot unmarshal object into Go value of type []string error only when I’m trying to run a new container with Docker-PHP.
Here is my Docker version:
Docker version 1.7.1, build 786b29d

I’m running my application in a Docker container which use the docker socket as volume.
    "Volumes": {
        "/data": "/var/www/littleship",
        "/var/run/docker.sock": "/run/docker.sock"
    },
    "VolumesRW": {
        "/data": true,
        "/var/run/docker.sock": true
    },

And here is my Symfony action to create a container (https://github.com/ambroisemaupate/littleship/blob/master/src/AM/Bundle/DockerBundle/Controller/ContainerController.php#L144):
    public function addAction(Request $request)
    {
        if (!$this->isGranted('ROLE_SUPER_ADMIN')) {
            throw $this->createAccessDeniedException();
        }

        try {
            $docker = $this->get('docker');
            $cManager = $docker->getContainerManager();
            $iManager = $docker->getImageManager();

            $form = $this->createForm(new ContainerType($iManager, $cManager));

            $form->handleRequest($request);

            if ($form->isValid()) {
                $data = $form->getData();
                $newCont = new Container([
                    'HostConfig' => [
                        'Links' => $data['links'],
                        'VolumesFrom' => $data['volumes_from'],
                        'PublishAllPorts' => (boolean) $data['publish_ports'],
                        'RestartPolicy' => [
                            'Name' => $data['restart_policy'],
                            'MaximumRetryCount' => 0
                        ]
                    ]
                ]);
                $newCont->setImage($data['image']);
                $newCont->setExposedPorts($this->getExposedPorts($data['ports']));
                $newCont->setName($data['name']);
                $newCont->setEnv($data['env']);
                $cManager->run($newCont, null, [], true);

                return $this->redirect($this->generateUrl('am_docker_container_list'));
            }

            $assignation['form'] = $form->createView();
        } catch (RequestException $e) {
            $assignation['error'] = $e->getMessage();
        }

        return $this->render('AMDockerBundle:Container:add.html.twig', $assignation);
    }

This action perfectly worked before Docker 1.7.1 upgrade, and other actions still work (stop, restart  and remove containers). Do you have any idea ? Do you need more informations ?
Thanks!
Sincerely,
Ambroise

I had the same issue when calling container controller with array arguments, eg:
$container = new Container([
        'HostConfig' => [
          'Links' => ['db' => 'db'],
        ]
      ]);

// I think correct form should be:

    $container = new Container([
        'HostConfig' => [
          'Links' => ['db:db'],
        ]
      ]);

Now when I inspect container in console I get
docker inspect -f "{{ .HostConfig.Links }}" web
[/db:/qw/db]

So I guess that you messed something in array that is passed to the constructor

I have the same issue:
$container = new Container([  'Image' => 'tutum/mysql',  'Volumes' => [ '/var/lib/mysql'],  'Env' => ['MYSQL_PASS=pass', 'MYSQL_USER=user'] ]);

This has just happened to me when creating containers, after upgrade docker 1.6 to 1.7.1.
Quick analysis:
Something has changed in how docker handles volumes. If $manager->create($container) is called without volumes  no error happens.
In my instance the error happens on Http/Adapter/DockerAdapter line 77, whiich is the catch after
            RequestEvents::emitBefore($transaction);
            if (!$transaction->getResponse()) {
                $this->createResponse($transaction);
                RequestEvents::emitComplete($transaction);
            }

I dont see any volume formatting changes on http://docs.docker.com/reference/api/docker_remote_api/#what-s-new

I think I’ve understood where the problem comes from.
https://github.com/ambroisemaupate/littleship/commit/decefe1d29c372dd16919c9eba29cb41d49e4d0a#diff-12d54e6d79b2203970e6c68aa78be01bR139
With new Docker API, you cannot set empty arrays to your container configuration.
I’ve checked if env, links, exposedPorts and volumes_from data were not empty before setting them in Container object and running it. It solved my issue.

@ambroisemaupate Thanks for the update..good to know!!

My issue was slight different from @ambroisemaupate  it seems.
One has to send empty arrays sometimes. To create a countainer that mounts, for example,  /opt/server/foo as /data in the container.
@boonkerz indicates how to send an empty array above..
When creating a container one does a create() and then start().
On create() send a config array, with a Volume array of index '/data' containing an empty array.
['Image'=> $contimage, 'Hostname' => $fqdn,  'Env'  => $dockerenv,  'Volumes'  => [ '/data' => array() ],    ];
Then for start(), send an array  containing a Binds array with one entry "/opt/server/foo:/datal:rw"
At least that works for me...

if this is a breaking change in the Docker API, please open an issue in the Docker issue tracker.
It's possible that this has already been fixed in Docker 1.8-rc2, so it could be worth testing against that version. Details can be found here: https://github.com/docker/docker/pull/15091#issuecomment-127461032

I don't consider that it changes the API, it's just more precise in what is expects.  A string like "/data =>{}" probably should never have worked. We can close this issue at this stage?

There is still a bug in the library we don't differentiate an empty array and an empty object as our library will do this by default :
Json::encode(array()) => "{}"
but sometimes we need to have
Json::encode(array()) => "[]"
Thanks for the report, i will try to have a look at it (certainly moving from array to stdClass for json object and use array as json array and not object)

closed in #147


Python access?

Could you document how to access Ollama API with bearer authentication using python?

Could you document how to access Ollama API with bearer authentication using python?

Hi, thanks for your message. There's actually nothing different about accessing this compared to how you'd access Ollama. Ollama supports the OpenAI API, which makes things pretty straightforward. You can find all the details in the Ollama documentation on GitHub.
https://github.com/ollama/ollama/blob/main/docs/openai.md
All you need to do is add your API key, and you're good to go. It's a simple process that should get you up and running quickly.

试了下，不设置api key 也能访问啊

Could you document how to access Ollama API with bearer authentication using python?

Hi, thanks for your message. There's actually nothing different about accessing this compared to how you'd access Ollama. Ollama supports the OpenAI API, which makes things pretty straightforward. You can find all the details in the Ollama documentation on GitHub.
https://github.com/ollama/ollama/blob/main/docs/openai.md
All you need to do is add your API key (api_key), and you're good to go. It's a simple process that should get you up and running quickly.
Example:
client = OpenAI(
    base_url='http://localhost:11434/v1/',

    # add your api key
    api_key='sk-ollama-xxxxxxxxxxxxxxxxxxx',
)

While this works for some APIs, Ollama still does not support all of them. For example this

model = ChatOpenAI(
    model="mistral",
    api_key='sk-ollama-6c325b118f435a5b3ac6539481a537d1')

model.invoke("hello")

won't work. Is there a way to make it work?


Dynamically register scheme and start corresponding controllers

We register scheme for all frameworks and  start all controllers in current version. Ideally, it should accepts a list of framework user want to enable.
https://github.com/kubeflow/tf-operator/blob/b8d5d3cd6e824865de196388c2c2a4e852b709e7/main.go#L50-L56
https://github.com/kubeflow/tf-operator/blob/b8d5d3cd6e824865de196388c2c2a4e852b709e7/main.go#L91-L106
/good-first-issue
/help-wanted

/assign @zw0610  Feel free to unassign if you are overhelmed by other stuff/

I think I can take it this weekend.

btw, because the scheme registration is defined in init(){} function, it may not be easy to let user choose what schemes to be registered. Meanwhile, registering unused schemes seems no harm.
The reconciler setup could be configured based on the command line input.

btw, because the scheme registration is defined in init(){} function, it may not be easy to let user choose what schemes to be registered. Meanwhile, registering unused schemes seems no harm.
The reconciler setup could be configured based on the command line input.

Agree. We just need to make sure scheme registration won't break if CRD is not installed.

Great job. This can be closed


toggl timer on desktop (app) not populating

I restarted my computer tonight and my AVG detected a threat from my Toggle desktop. This threat was removed but then my desktop toggl was also gone.    I downloaded a new exe file and when I went to run it the same threat came up.
I had already uninstalled toggl desktop, made sure there were no processes still running in the task manager and also cleared all the files from apptdata/local/toggldesktop so I could start with the new exe install.
Any ideas?  Is this a problem you have been having from other users?
I use this each day so I'd appreciate a solution, thanks, Michele

We have had few similar issues with Norton Security. The users have whitelisted the app or have contacted the AntiVirus software developer and have gotten instructions on how to whitelist the app.

How is it possible to be using this for months with no issue and then no change to versions and I restart my computer and it's all of a sudden got a virus detection from AVG?  Seems like you might be passing me off on this one.  I'll be in touch with AVG but would have appreciated more help on this if possible.

It seems that AVG has updated it's database and declared all Toggl products a threat. We got a similar report about our Android app.

I have successfully added the folder for Toggl desktop as an exception in AVG in advanced settings.  Thanks.


Migrate platform tip debts to their own kind

We decided with @znarf that platform tip debts should have their own PLATFORM_TIP_DEBT kind. The rationale is:

Debts are fundamentally different from the transactions they initially represent, using the same kind can be messy
They won't be many kinds of debts, so having {INITIAL_KIND}_DEBT for all of them should be ok

Resolved in https://github.com/opencollective/opencollective-api/pull/6156


bugfix(technical integration): error message fix

Description
Fixed error message for technical integration
Why
to enable error message properly
Issue
Ref: CPLP-1522
Checklist
Please delete options that are not relevant.

[x] I have followed the contributing guidelines
[x] I have performed a self-review of my own code
[x] I have successfully tested my changes locally

@lavanya-bmw  can you please recheck once the linked ticket. CPLP-1522 seems to be wrong

@lavanya-bmw can you please recheck once the linked ticket. CPLP-1522 seems to be wrong Furthermore can you please explain the fix. Ticket TEST-1522 (in case this is the defect which is getting fixed) talks about a typo. But I dont see a fix of the typo, it rather looks like code updates

Fixed typo error


CI: Enable clippy check

Nah, not ready for this, which is a drastic step.  I like the current setup and manual clippy fix PRs, to review carefully.

I just want to add: this PR only adds a check (like cargo fmt check). The code in the repository will not be fixed automatically.


Update azure-security-disk-encryption-faq.md

add a recommended ADE for Linux workflow to FAQ

@ejarvi,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@ejarvi : Thanks for your contribution to the Azure documentation! The author, @deventiwari, has been notified to review your proposed change.

Since the author is OOF, @ejarvi reached out to me to approve this request. Change is okay, approved. #sign-off

@ejarvi - Your changes have been approved. Please resolve the merge conflict so the changes can be merged. Thanks

#sign-off

Just noticed that you're referring to "server side encryption (SSE)". That should read "storage service encryption (SSE)".

Thanks Lars for noticing that!  Updated in https://github.com/MicrosoftDocs/azure-docs/pull/2959


High difference between values from vanilla attention and flash_mha

Hi, I observed that my language model wasn't converging (it did converge with vanilla_att) so ran the below
B = 128; h = 6; T = 256; dim = 288//6; shape=(B, h, T, dim)
q = jrand.uniform(jrand.PRNGKey(2323), shape=shape, dtype=jnp.float16) # (B, h, T, dim)
k = jrand.uniform(jrand.PRNGKey(323232), shape=shape, dtype=jnp.float16)
v = jrand.uniform(jrand.PRNGKey(2323221111), shape=shape, dtype=jnp.float16)

def vanilla_att(q, k, v, is_causal=True):
    att_wei = (q @ jnp.matrix_transpose(k))/(dim**0.5) # (B, h, T, T) <= (B, h, T, dim) @ (B, h, T, dim).transpose(2, 3)
    # causal mask
    if is_causal:
        att_wei + jnp.triu(jnp.full(shape=(1, 1, T, T), fill_value=-jnp.inf), k=1)[:, :, :T, :T] # (B, h, T, T)
    att_wei = jax.nn.softmax(att_wei, axis=-1) # (B, h, T, T)
    # apply attention weights to v
    att_out = att_wei @ v # (B, h, T, T) @ (B, h, T, dv) => (B, h, T, dv)
    return att_out

diff = abs(flash_mha(q, k, v, is_causal=True, softmax_scale=dim**-0.5)-vanilla_att(q, k, v))
>>> jnp.max(diff), jnp.min(diff), jnp.mean(diff)
(Array(0.5703, dtype=float16),
 Array(0., dtype=float16),
 Array(0.146, dtype=float16))

mean difference is 0.146 which is a lot.

Oh! I see the problem. This confused me for a bit. Flash attention accepts inputs in NTHD order (aka [n, l, h, d] as I wrote in the readme). You're comparing it against a NHTD vanilla attention. You need to put some transpose (or remove some) in your model.

After Transposing...
diff = abs(flash_mha(
    q.transpose((0,2,1,3)), # (B, T, h, dim)
    k.transpose((0,2,1,3)), # (B, T, h, dim)
    v.transpose((0,2,1,3)), # (B, T, h, dim)
    is_causal=True, softmax_scale=dim**-0.5
    ).transpose((0,2,1,3) # (B, h, T, dim) <= (B, T, h, dim)
                )-vanilla_att(q, k, v)) # (B, h, T, dim)

>>> jnp.max(diff), jnp.min(diff), jnp.mean(diff)
(Array(0.551, dtype=float16),
 Array(0., dtype=float16),
 Array(0.02173, dtype=float16))

Oh, you also have a bug here:
 att_wei + jnp.triu(jnp.full(shape=(1, 1, T, T), fill_value=-jnp.inf), k=1)[:, :, :T, :T] # (B, h, T, T)

this should be
att_wei += jnp.triu(jnp.full(shape=(1, 1, T, T), fill_value=-jnp.inf), k=1)[:, :, :T, :T] # (B, h, T, T)

your test passes on my desktop with this

The authors of the paper didn't implement it for float32, probably mainly because it would need 2x more sm memory and is also slower (memory is in pretty short supply afaik). You could probably use it in a float32 model by casting to bf16 and back?

Thanks for your interest in my repo btw!

And should I learn C++ Cuda or can I implement Flash Attention from scratch using the Python version of Cuda and what's the best learning resource to learn it (python or C++ version)? Thanks!
(BTW are you a student?)

Join the cuda mode discord and watch the recorded lectures! I'm not sure that i can say what you should learn but i think c++ cuda is quite interesting and a good way to understand the hardware.
I'm not a student. I'm, errr, a researcher (neet, lol).

Hi @nshepperd, I was training a 15 Million parameter model on the TinuStories dataset, and I observed that the loss started increasing after about 30K steps. I observed the same thing in my 280K model and fixed it by changing the momentum beta_2 hp to 0.975 from 0.99. But in the 15M model, I'm using a momentum of 0.95 which most models (gpt, llama) use, but the loss increases after 30k. Could you please help me? Thanks. Repo link with training logs


There is no such entity as cosyvoice.utils.common.ras_sampling

Traceback (most recent call last):
File "webui.py", line 190, in
cosyvoice = CosyVoice(args.model_dir)
File "/root/autodl-tmp/CosyVoice/cosyvoice/cli/cosyvoice.py", line 29, in init
configs = load_hyperpyyaml(f)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/hyperpyyaml/core.py", line 188, in load_hyperpyyaml
hparams = yaml.load(yaml_stream, Loader=loader)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/yaml/init.py", line 81, in load
return loader.get_single_data()
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 116, in get_single_data
return self.construct_document(node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 120, in construct_document
data = self.construct_object(node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 147, in construct_object
data = self.construct_non_recursive_object(node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 188, in construct_non_recursive_object
for _dummy in generator:
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 633, in construct_yaml_map
value = self.construct_mapping(node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 429, in construct_mapping
return BaseConstructor.construct_mapping(self, node, deep=deep)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 244, in construct_mapping
value = self.construct_object(value_node, deep=deep)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 147, in construct_object
data = self.construct_non_recursive_object(node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 183, in construct_non_recursive_object
data = constructor(self, tag_suffix, node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/hyperpyyaml/core.py", line 480, in _construct_object
args, kwargs = _load_node(loader, node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/hyperpyyaml/core.py", line 434, in _load_node
kwargs = loader.construct_mapping(node, deep=True)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 429, in construct_mapping
return BaseConstructor.construct_mapping(self, node, deep=deep)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 244, in construct_mapping
value = self.construct_object(value_node, deep=deep)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 147, in construct_object
data = self.construct_non_recursive_object(node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/ruamel/yaml/constructor.py", line 183, in construct_non_recursive_object
data = constructor(self, tag_suffix, node)
File "/root/miniconda3/envs/cosyvoice/lib/python3.8/site-packages/hyperpyyaml/core.py", line 491, in _construct_name
raise ImportError("There is no such entity as %s" % callable_string)
ImportError: There is no such entity as cosyvoice.utils.common.ras_sampling

The same issue is currently being encountered by me.

me too! what can i do to fix it？

In the model file (https://www.modelscope.cn/models/iic/CosyVoice-300M/files/121c883104db335799d20e8c1fe7f4963c5a8058#diff_view_cosyvoice.yaml), a sampler was added to the LLM section, but this was not included in the code open-sourced on GitHub. Before open-sourcing, the model can be reverted to a previous version to resolve this

@sincerity711 thank you, but how can we change the version of the model?

comment ras_sampling in yaml, we will update the code by the end of the month

How can I solve this problem?

update your code, it should be fixed by now

comment ras_sampling in yaml, we will update the code by the end of the month

thanks, it works!

Error occurred when executing CosyVoiceNode:
name 'pseg' is not defined
File "E:\ComfyUI-aki-v1.3\execution.py", line 317, in execute
output_data, output_ui, has_subgraph = get_output_data(obj, input_data_all, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "E:\ComfyUI-aki-v1.3\execution.py", line 192, in get_output_data
return_values = _map_node_over_list(obj, input_data_all, obj.FUNCTION, allow_interrupt=True, execution_block_cb=execution_block_cb, pre_execute_cb=pre_execute_cb)
File "E:\ComfyUI-aki-v1.3\execution.py", line 169, in _map_node_over_list
process_inputs(input_dict, i)
File "E:\ComfyUI-aki-v1.3\execution.py", line 158, in process_inputs
results.append(getattr(obj, func)(**inputs))
File "E:\ComfyUI-aki-v1.3\custom_nodes\CosyVoice-ComfyUI\nodes.py", line 170, in generate
for out_dict in output:
File "E:\ComfyUI-aki-v1.3\custom_nodes\CosyVoice-ComfyUI\cosyvoice\cli\cosyvoice.py", line 52, in inference_sft
for i in self.frontend.text_normalize(tts_text, split=True):
File "E:\ComfyUI-aki-v1.3\custom_nodes\CosyVoice-ComfyUI\cosyvoice\cli\frontend.py", line 211, in text_normalize
text = normalize_zh(text)
File "E:\ComfyUI-aki-v1.3\custom_nodes\CosyVoice-ComfyUI\cosyvoice\cli\frontend.py", line 119, in normalize_zh
return process_ddd(text_normalize(remove_chinese_punctuation(text)))
File "E:\ComfyUI-aki-v1.3\custom_nodes\CosyVoice-ComfyUI\cosyvoice\cli\frontend.py", line 130, in process_ddd
word_list = [(word, flag) for word, flag in pseg.cut(text, use_paddle=False)]
关闭

thank you，it works!

comment ras_sampling in yaml, we will update the code by the end of the month

thanks, it works!

which file should be modified?

mark， I met the same problem

If you use the CosyVoice on mac with the https://github.com/v3ucn/CosyVoice_for_MacOs, and hard to upgrade the code to match the model. You could use 'git checkout 46b5c06a21fe6dfc3deedf7fc8fea4abe9c71e9b' in the folder 'pretrained_models/CosyVoice-300M' to fix it.


Team Grade

Team Grading
Group Breakdown:

Total Grade: 0.9/1.0

Individual
Team

Overview
N/A
0.9 - Had specific introduction with 10 word phrase, to explain context and project

Demo
N/A
0.92 - Had numerous working elements all clearly explained in later segments with lots of backend integration modification, appealing frontend, user interaction, etc.

Plan/CPT
N/A
0.9 - Had clear CPT requirements, breakdown (initiatives, etc.)

Process
N/A
0.83 - Speed was main factor, didn't follow 3-7 rule. In future, will prioritize core elements. Didn't showing figma in video, lacked time due to poor prioritization

Average
N/A
0.89

Improvements:

Focus on 3 to 7 main ideas, make sure voice is clear and specific. Don't attempt to force to much information in video (slower makes technical language standout)
Will maintain video at regular pace.
Use familiar keywords and terminology to increase word efficiency and reduce speaking time.
For editing will utilize more obvious longer transitions, keep closed captions, and show clear connection between code and associated feature.

You could make it easier for me to put two scores together.   I believe we had a problems with clarity for me but it seemed to be less than a .90.    On the way you put information together it is a lot of work for me, perhaps a comment for each person on this issue.


[SPARK-32517][CORE] Add StorageLevel.DISK_ONLY_3

What changes were proposed in this pull request?
This PR aims to add StorageLevel.DISK_ONLY_3 as a built-in StorageLevel.
Why are the changes needed?
In a YARN cluster, HDFS uaually provides storages with replication factor 3. So, we can save the result to HDFS to get StorageLevel.DISK_ONLY_3 technically. However, disaggregate clusters or clusters without storage services are rising. Previously, in that situation, the users were able to use similar MEMORY_AND_DISK_2 or a user-created StorageLevel. This PR aims to support those use cases officially for better UX.
Does this PR introduce any user-facing change?
Yes. This provides a new built-in option.
How was this patch tested?
Pass the GitHub Action or Jenkins with the revised test cases.

Test build #126955 has started for PR 29331 at commit 0cf67c4.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31580/
Test PASSed.

Test build #126955 has finished for PR 29331 at commit 0cf67c4.

This patch fails due to an unknown error code, -9.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126955/
Test FAILed.

retest this please

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31594/
Test PASSed.

Test build #126970 has started for PR 29331 at commit 0cf67c4.

Test build #126970 has finished for PR 29331 at commit 0cf67c4.

This patch fails PySpark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126970/
Test FAILed.

Thanks, @HyukjinKwon and @maropu . Yes. The official support is more beneficial to the users. DISK_ONLY_3  is better than some magic code like new StorageLevel(true, false, false, false, 3). Also, this PR includes a test coverage for DISK_ONLY_3 which makes the customer feel safe.

Test build #126996 has started for PR 29331 at commit 480a480.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31620/
Test PASSed.

Test build #126996 has finished for PR 29331 at commit 480a480.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/126996/
Test FAILed.

Rebased to the master.

Test build #127006 has started for PR 29331 at commit cc1a7a3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31630/
Test PASSed.

Test build #127006 has finished for PR 29331 at commit cc1a7a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127006/
Test FAILed.

Interesting. Since the last commit only changes R/Python/Doc and one Java file, CachedTableSuite should not be affected . I'll take a look what is the different from last run.

I found the root cause of random failures in the master branch. Here is the PR.

https://github.com/apache/spark/pull/29344

Retest this please

Test build #127054 has started for PR 29331 at commit cc1a7a3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31676/
Test PASSed.

Test build #127054 has finished for PR 29331 at commit cc1a7a3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127054/
Test PASSed.

All test passed again. Could you review this, @HyukjinKwon , @maropu , @viirya , @dbtsai , @holdenk ?

I get the value of 3x replication for persistent data; this is in theory persistence for data that is already recreateable right?

Right, @srowen .

cached data? or am I totally forgetting where else this can be used?

Yes. This cut the lineage and works like HDFS replacement. Previously, this can be achieve when you store the RDD into HDFS back. For now, it's difficult in the disaggregated cluster.

If so this doesn't seem as necessary, and even DISK_ONLY_2 feels like overkill.

It's not overkill. HDFS replication is not only for reliability. 3x HDFS replication improves the throughput 3x times. Are you sure one executor can serve that traffic, @srowen ?

I suppose one argument we've made in the past is that the 2x replication is to make the cached data available as local data in more places, to improve locality. That could be an argument.

Improving locality is just a small fraction. The throughput improvement and reduced FetchFailedException is the real benefit. If we don't have HDFS, this is the only viable option.

But would MEMORY_AND_DISK_3 then make sense?

MEMORY_AND_DISK_3 is not recommended here because it has another assumption to have all the data into the memory. It turned out that has a severe side effect when the memory is not enough on the executors. Why do we need to load the data into the memory if it goes down disk back due to Spark operation.
This PR aims to serving the data like HDFS conceptually inside Spark to support HDFS-service-free ecosystem.

I think here the motivation was to try and deal with a workload with a lot of failures on the executors and avoiding a lot of recomputes more than the locality.

Thank you, @holdenk !

The throughput improvement and reduced FetchFailedException is the real benefit. If we don't have HDFS, this is the only viable option.

IIUC, FetchFailedException only raised when we try to fetch shuffle blocks, while StorageLevel is only related to RDD blocks. So I have no idea how DISK_ONLY_3 could help reduce FetchFailedException.
And how do we get the throughput improvement by using DISK_ONLY_3? Higher task parallelism? Or something else?

I think here the motivation was to try and deal with a workload with a lot of failures on the executors and avoiding a lot of recomputes more than the locality.

If that's the case, I think we should care more about shuffle data, which only has one single copy in the disk. And shuffle data loss would lead to stage recompute, which is more terrible compares to task recompute caused by RDD block loss.
I don't object to the change here, but just want to figure out what's the real case it tires to improve.

Thank you, @Ngone51 . The user scenario looks like this. The job has a very long lineage. In a disaggregated cluster, the executor dies sometime due to various reason (including maintenance and preemption) and causes bad effects like FetchFailedException and frequently retries (not only the direct parent, but also the ancestor, too). The is the same as you wrote. So, the user is trying to cut the lineage by using cache after the shuffle stage. But, it turns out that cache can cause memory competition as a side-effects. Although Spark can spill the disk, they don't want to load the data into the memory from the beginning. They inevitabliy decided to choose DISK only. In short, they are using DISK_ONLY_1 and DISK_ONLY_2 and currently asking DISK_ONLY_3.
The rational of DISK_ONLY_3 is they want to have the same concept of the existing HDFS service.

Hi, @HyukjinKwon , @maropu , @srowen , @Ngone51 .
Please let me know if you guys have any other concerns.

Retest this please.

Test build #127208 has started for PR 29331 at commit cc1a7a3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31829/
Test PASSed.

Test build #127208 has finished for PR 29331 at commit cc1a7a3.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127208/
Test PASSed.

cc @tgravescs too

Thank you, @HyukjinKwon .

Retest this please.

Test build #127242 has started for PR 29331 at commit cc1a7a3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31862/
Test PASSed.

Test build #127242 has finished for PR 29331 at commit cc1a7a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127242/
Test FAILed.

Retest this please.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31864/
Test PASSed.

Test build #127244 has started for PR 29331 at commit cc1a7a3.

Test build #127244 has finished for PR 29331 at commit cc1a7a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127244/
Test FAILed.

Retest this please

Test build #127257 has started for PR 29331 at commit cc1a7a3.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/31877/
Test PASSed.

Thank you so much, @Ngone51

Test build #127257 has finished for PR 29331 at commit cc1a7a3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test FAILed.

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/127257/
Test FAILed.

Do we consider writing out the DataFrame as parquet/orc/... to reliable storage to cut the RDD lineage?

Thank you for review, @cloud-fan . No, this approach doesn't not consider additional reliable storage. This PR depends on pure Spark's features only.

Do we consider writing out the DataFrame as parquet/orc/... to reliable storage to cut the RDD lineage?

Since we already have DISK_ONLY_2, I'm fine adding DISK_ONLY_3.
I'm just giving a different proposal for this use case. The RDD lineage model relies on recomputing so that Spark can cache data on unreliable storage. I think caching with multiple copies is diverging from the original idea. If you don't want to trigger recomputing, you can save data to reliable storage, which is usually better than 3 hard copies (object store is cheaper, HDFS has Erasure Coding to save space).

Thank you for advice, @cloud-fan . Of course, we know that the architectural goal of Apache Spark is not aiming a reliable storage system. reliable storage will be always considered as the first solution if it's available.

Thank you all. This is nothing new, but an alias of the existing Spark feature. This will not make much confusions what Apache Spark aims. Merged to master.


KL gradient doesn't work with SIRF data/image objects

https://github.com/TomographicImaging/CIL/blob/cd37de8e3d757674f61236f9943792d106bab428/Wrappers/Python/cil/optimisation/functions/KullbackLeibler.py#L352
This line only works on CIL objects
For SIRF objects, you need to get the array, change the array and then put the array back into the object:
array = image.as_array()
array = #make some changes to array
image.fill(array)

This bug is present in the gradient using numba as well
@zeljkozeljko

thank you @samdporter , actually working on it atm. This cause problems when it is used in the stochastic algs.

Great. Thanks!

replacing:
out.as_array()[tmp_sum_array>0] = \
     1 - self.b.as_array()[tmp_sum_array>0]/tmp_sum_array[tmp_sum_array>0]

with
out_array = out.clone().as_array()                 out_array[tmp_sum_array>0] = \                     1 - self.b.as_array()[tmp_sum_array>0]/tmp_sum_array[tmp_sum_array>0]                 out.fill(out_array)
seems to work

Me neither tbh. I couldn't figure it out so I've been setting self.use_numba=False
I've just tried  self.use_numba=True, but numba still isn't being used
I think this must be a separate issue or a mistake on our part
This is the nb we're using:
https://github.com/TomographicImaging/Hackathon-000-Stochastic-Algorithms/blob/main/contrib/Iexample.ipynb

Closed by https://github.com/TomographicImaging/CIL/pull/1272


Update http-cache-semantics to 4.1.1

Description
Update http-cache-semantics from 3.8.1 and 4.1.0 to 4.1.1
Check List

[ ] New functionality includes testing.
[ ] New functionality has been documented.
[x] All tests pass

[x] yarn lint
[x] yarn test-unit

[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@BSFishy we could close this one, because I remove nodegit completely here

Closing in favor of #541


Helm Chart requires ClusterRoles for Pulsar Functions, Promotheus, etc.

ClusterRoles for Pulsar Functions, Promotheus, etc. This is related to issue #173
rbac.limit_to_namespace: true
only limits required pulsar pieces (broker, bookie, etc.) to the namespace, but not Pulsar function workers, Promotheus.
Error is:
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: could not get information about the resource ClusterRole "test-prep-pulsar-functions-worker" in namespace "": clusterroles.rbac.authorization.k8s.io "test-prep-pulsar-functions-worker" is forbidden: User "..." cannot get resource "clusterroles" in API group "rbac.authorization.k8s.io" at the cluster scope
Error: INSTALLATION FAILED: rendered manifests contain a resource that already exists. Unable to continue with install: could not get information about the resource ClusterRole "test-prp-pulsar-prometheus" in namespace "": clusterroles.rbac.authorization.k8s.io "test-prp-pulsar-prometheus" is forbidden: User "..." cannot get resource "clusterroles" in API group "rbac.authorization.k8s.io" at the cluster scope

The problem is fixed. Please test with latest release of the helm chart.


Can't seem to install anymore

Hello, for some reason now when i try to install it does not create any pvc, and I can't login to the mysql.
I made it work in the past, I tried re-creating the whole cluster same thing?
is there anything new I should know?
where should I start looking?

Hi @dlebee,
Can you please give me more details(e.g. logs, describe on pod/sts)?
Thank you!

Sorry I can't I moved on to another package and got rid of the pods.


Auto-suggestion appearing in normal color as text, rather than the more discrete gray.

How should I fix this? The default color is just the normal white text for the auto-suggestion, and I really want the more muted gray as in the demo. For now, I am using fg=4, as that is the best I can find that isn't the nice gray.

By the way, I am running Linux Mint 17.2 Cinnamon, and my Terminal Emulators are Guake and Gnome-Terminal with a slightly modified Solarized Dark color scheme. Though color scheme does not affect the issue.

Take a look at #171 and #172. This is very likely a color scheme issue.


how to scroll vertically

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.

Hi @myomyintaung1411 This component doesn't support vertical scrolling at the moment. I can take a look at it in the future to see if I can implement this.


Shunt calibration register 15 Bit instead of 16?

Hi Rob Tillaart,
I am a physicist at the Universität Heidelberg. In our experiment, we are using the INA 236 chip. It is similar to the INA 226 but has two selectable ranges (~ 80 mV/20 mV). By implementing the range selection in your code, I encountered a possible mistake in the code.
In the function "setMaxCurrentShunt," during normalisation, the minimal current_lsb is calculated (lines 244-247). This value is based on the shunt_register size and some internal factors. You assumed the register to be 16 Bits, but according to the datasheet, only 15 Bits are writable.
In Line 294, at the auto scale calibration, the shunt calibration value is compared to 16 bits rather than 15 Bits.
This has only consequences if the optimal current_lsb is larger than 15Bit.
Thank you for the effort you put into this project.
Best regards
Josef

Thanks for this issue. Need to investigate this asap probably coming week.

@josef929

Bug confirmed!

@josef929
Created develop branch for 0.6.0 version which should fix this.
Changed the max calibration value from 65535 => 32767.
If you have time, can you confirm the develop branch works for you?

Yes, I implemented the selectable range. I rewrote the code for the INA 236 (changed the names and checked the registers), but most of the code is basically the same. I can sent you the code for the INA 236 class if you want.

@josef929 Created develop branch for 0.6.0 version which should fix this. Changed the max calibration value from 65535 => 32767.
If you have time, can you confirm the develop branch works for you?

Yes I can do that.

I can sent you the code for the INA 236 class if you want.

Please do, so I can make it available for the larger audience if you agree
(either as derived class or as separate repository)

documents-export-2024-5-27.zip
Thats the version I am using right now. I did some calibration and everything worked for me.

Quick look shows a few differences, two functions a number of constants.
to be continued

@josef929
small bug in your code
  //  auto scale calibration if needed.
  uint32_t calib = round(0.00512 / (_current_LSB * shunt*pow(4,adcrange)));
  while (calib > 32768)  <<<<<<<< should be >  32767
  {
    _current_LSB *= 2;
    calib >>= 1;
  }
  _writeRegister(INA236_CALIBRATION, calib);

@josef929
Estimate is that 200-250 of the 700 lines of non-equal functions exist in the .cpp file, mostly setMaxCurrentShunt();
With current insight making a separate library for the INA236 will be easiest way to publish.
(in terms of maintenance it is hardly more work as the library is pretty stable).
Furthermore I think it will be the most clear to the users of the library.

Yes, thats fine with me.

OK, I will set up a new repo, add your name - credits where credits are due.

@josef929 Created develop branch for 0.6.0 version which should fix this. Changed the max calibration value from 65535 => 32767.
If you have time, can you confirm the develop branch works for you?

I tested the 0.6.0 version. The returned current values were all as expected, especially for small maximal currents, where the 15 Bit shunt calibration register limits the resolution. I checked both true and false option for the normalization of the calibration.

Thanks for testing!
Created a develop branch + PR - https://github.com/RobTillaart/INA236
build is running
documentation is work in progress.

@josef929
found another minor point, can you confirm that it makes sense?
When calling setADCRange(..), the value of _voltage_LSB must change as the next reading will be done with a different voltageLSB.

Yes and No.
It is true that the variable voltage LSB has to change when setADCRange is called. However, I implemented the range so that the best range (depends only on the max current input) is selected based on the max current in the setMaxCurrentShunt function. In that function, the voltage_lsb is then updated to the chosen range. Changing the range manually would require a new calibration. I saw no benefit or situation where this would be useful.

Exactly,
However if the user decides to call setRange() - for whatever reason - and changes the value in the device, the next measurement will be affected. So to guarantee the correctness of that new measurement, the voltage_LSB must be changed too.
And yes, if that setting is not optimal or even out of range (setting 20 mV while actual voltage is higher) is the risk of the user.
Maybe a warning must be added in the documentation.

BTW, your decision to set the best range in setMaxCurrentShunt is 100% right (imho).

Exactly, However if the user decides to call setRange() - for whatever reason - and changes the value in the device, the next measurement will be affected. So to guarantee the correctness of that new measurement, the voltage_LSB must be changed too.
And yes, if that setting is not optimal or even out of range (setting 20 mV while actual voltage is higher) is the risk of the user. Maybe a warning must be added in the documentation.

Understood. In such scenarios, the value of the shunt register also needs to be updated (either by a factor of 4 or 1/4, depending on the previous Range ).

The build doesn't cooperate 100%, it fails on I2C somehow.
To be continued tomorrow.

@josef929
Thanks for your code and testing so far.
As this issue is solved I have closed it,
If new problems occur please open an issue under the appropriate repo (INA226/236) ,
(still investigating the build CI which works for the 226 and fails for the 236 although they are nearly identical)

@josef929
FYI,  INA236 initial version released - https://github.com/RobTillaart/INA236


GitHub: Create config.yml

This will prevent any blank issues to be created. As seen in https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository#configuring-the-template-chooser
Resolved / Related Issues

in order to properly manage the issues, we have to close issues that don't follow the issue templates.

https://github.com/files-community/Files/issues/12312#issuecomment-1540577114
Validation
How did you test these changes?

Neither needed or possible :)

Screenshots (optional)
Add screenshots here.

Having that said: What if there is an issue that really does not fit into one of the three [bug, code, feature] templates? For example: I would like to polish MD files, with help of MS Learn Authoring Pack (for VS Code). What to do then?

You're welcome. I am curious what you would advise for my question above here, though.

Having that said: What if there is an issue that really does not fit into one of the three [bug, code, feature] templates? For example: I would like to polish MD files, with help of MS Learn Authoring Pack (for VS Code). What to do then?

Feature is best


Scoped states

What problem does this feature solve?
when we want to do something like hide / show password input we should add state called "IsVisible" in our data but actually this data is specific for this input not relate to our app so we shoud put it on a scope of the element to prevent our data's pollution
What does the proposed API look like?
<div class="field" v-data="{ isVisible : false }">
   <button @click="isVisible = !isVisible">isVisible ? 'hide' : 'show'</button>
   <input :type=" isVisible ? 'text' : 'password' " />
</div>

Please search v-scope in issues and PR to see this was already asked

@posva where can I find the existing pr/issue? I’ve tried searching it in both but cannot find it. This is actually how I stumbled upon this issue as this is the one thing I can do in petite vue that I can’t do in vue without having to create a component.

Duplicate of https://github.com/vuejs/vue/pull/7325


Looks like some potentially usable changes in this one..

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.


Dual curation pipeline

Hi,
I was looking into the dual curation pipeline for pretext to assemble an autotetraploid, I noticed that I need the AGP_correct.py, and hap_split.py scripts, however I can't seem to find these scripts in this repository? I am just wondering if this has been removed or if I should be looking elsewhere?
Thank you for any advice! :)

Where did you see these scripts referenced?

@jgrg @Rhia15
The hap_split.py script was one from Rockefeller. I don't know the repository, but I do know the person has since left.

I don't know where to find out what these scripts do. What is the "dual curation pipeline"?


add script to detect upstream refs

Signed-off-by: Will Kutler<EMAIL_ADDRESS>for https://github.com/stolostron/backlog/issues/21794
still a work in progress - need to move the job out of the KIND folder and fix the upstream issues it is flagging so the PR can actually merge

We might also need an "exceptions" system... it looks like it's flagging the "addon-framework" import, but I don't know if the stolostron version has been updated with things we might need... so in the meantime, we might be ok with that upstream import.

Closing this in favor of https://github.com/stolostron/governance-policy-framework/pull/384


Revisit transaction handling

in case of commitOnEventLevel=false transaction might be rolled back even the status for certain events in the same batch is done
possible solution could be to extend the event configuration for a transaction mode

commitOnEventLevel --> write status after every processEvent
commitChunk --> commit status at the end --> if one event is reported as erroneous set all events on error
independedOfProcessingStatus --> commit status at the end as reported by processEvent --> all events in the chunk get the same transaction

check also status status exceeded is being rolled back --> not only error

add additional flag:

atomic status commit

  - type: Fiori
    subType: Task
    impl: ./test/asset/EventQueueTest
    load: 40
    parallelEventProcessing: 5
    runAutomatically: true
    processAfterCommit: true
    transactionHandling:
      commitOnEventLevel: false
      atomicStatusHandling: false

--> to address the issue the new section transactionHandling could be added

  - type: Fiori
    subType: Task
    impl: ./test/asset/EventQueueTest
    load: 40
    parallelEventProcessing: 5
    runAutomatically: true
    processAfterCommit: true
    transactionMode: commitOnEventLevel || http

--> new flag is transactionMode

done with 0.1.50


VoiceOver: it isn't possible to tell if an item is completed

You can if you bring up the context menu, but that sucks.

I added a accessibility label to fix this.


Add statement action

coverage: 90.667% (+2.7%) from 87.931%
when pulling aac7d5cc34b608ea0157c244bd22e08e0576db78 on feat/add-statement-action
into c7b96b14994cd4f5b5f42db4513c1dc6b417829f on main.


I get _this4.myfunc is not a function calling this.myfunc() from onPress() of a TouchableHighlight in an item

I've got a carousel like this:
  render() {
    <Carousel
      ref={(carousel) => { this._carousel = carousel; }}
      renderItem={this._renderCarouselItem}
      data={this.state.person.imagesList}
      sliderWidth={this.state.viewport.width}
      itemWidth={this.state.viewport.width}
    >
    </Carousel>
  }

  _renderCarouselItem({item, index}) {
    return (
      <TouchableHighlight key={item.key} onPress={() => this.setFullscreen(item.key)}>
        <Image
          source={{uri: item.uri}}
        />
      </TouchableHighlight>
    );
  }

  setFullscreen(index) {
    ...
  }

The problem is I don't know how to bind to this in _renderCarouselItem function, since when pressing on an image I get a reddish _this4.setFullscreen is not  a function... Any clue?

renderItem={()=>
    <TouchableHighlight key={item.key} onPress={() => this.setFullscreen(item.key)}>
        <Image
          source={{uri: item.uri}}
        />
      </TouchableHighlight>
}

@marcolino Did you make sure to bind this to your function in your constructor? Something along those lines:
    constructor (props) {
        super(props);
        this.setFullscreen = this.setFullscreen.bind(this);
    }

Thanks! I understand this is not a react-native-snap-carousel issue, but simply a lack of understanding bind functioning of mine... :-(
This is the working code, for me:
  _renderCarouselItem = ({item, index}) =>
    <TouchableHighlight onPress={() => this.setFullscreen(item.key)}>
      <Image
        source={{uri: item.uri}}
      />
    </TouchableHighlight>
  ;

@bd-arc: I did try that too, but it wasn't clear to me how to pass parameters afterwards, since the I should use this.setFullscreen and not this.setFullscreen(params) ... :-(

@marcolino Just for your information, parameters are kept when binding to a function; the purpose is only to provide the context of this.
You can absolutely do something along those lines:
export default class MyPureComponent extends PureComponent {

    constructor (props) {
        super(props);
        this.exampleString = 'Example';
        this.myBindedFunction = this.myBindedFunction.bind(this);
    }

    myBindedFunction (param1, param2) {
        alert(`${this.exampleString} ${param1} ${param2}`);
    }

    render () {
        return (
            <TouchableHighlight onPress={() => this.myBindedFunction('string1', 'string2')} />
        );
    }
}

Thanks @NicholasBertazzon  its working for me


schema(cdc): refactor schema snapshot to reduce memory usage

What problem does this PR solve?
Issue Number: close https://github.com/pingcap/tiflow/issues/1386
What is changed and how it works?
Ticdc keeps all versions of schema snapshot for each DDL, and it can only GC them after its checkpoint is advanced. If there are too many DDLs, the checkpoint advancing can be very slow so that all versions of schema snapshot are kept in memory.
Without the PR schema snapshots are deep cloned from the previous one. With the patch all schema snapshots share one MVCC tree to avoid deep clone. This is why memory usage is reduced in the PR.
Check List
Tests

Unit test

Create 12K tables WITH THE PATCH:

Create 12K tables WITHOUT THE PATCH:

Code changes
Side effects
Related changes
Release note
None

/run-verify

Codecov Report

Merging #5144 (56fd03a) into master (687e248) will decrease coverage by 0.0162%.
The diff coverage is 54.7116%.

Flag
Coverage Δ

cdc
60.8641% <54.7116%> (+0.2655%)
:arrow_up:

dm
52.2995% <ø> (-0.1700%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.
@@               Coverage Diff                @@
##             master      #5144        +/-   ##
================================================
- Coverage   56.1240%   56.1077%   -0.0163%
================================================
  Files           522        527         +5
  Lines         65325      68397      +3072
================================================
+ Hits          36663      38376      +1713
- Misses        25094      26310      +1216
- Partials       3568       3711       +143

/run-all-tests

Could you describe the difference of schemastaorge between this PR and master?

@overvenus @nongfushanquan I have updated the PR description. Please take a look again, thanks.

/run-all-tests

/run-all-tests

/merge

@overvenus please take a look again and /merge it if you are free.

/merge

/run-leak-test


Fix upgrade tests in release-1.1.

Ported various fixes from release-1.0 and also
https://github.com/istio/istio/pull/9939.

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai: The following test failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2eae238c2badb54b720cc1f6270f677dda9a6293
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/istio-unit-tests.sh
2eae238c2badb54b720cc1f6270f677dda9a6293
link
/test istio-unit-tests

prow/e2e-mixer-no_auth-mcp.sh
2eae238c2badb54b720cc1f6270f677dda9a6293
link
/test e2e-mixer-no_auth-mcp

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/lgtm

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: hklai, ostromart
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

tests/OWNERS [hklai]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai: The following tests failed, say /retest to rerun them all:

Test name
Commit
Details
Rerun command

prow/e2e-mixer-no_auth-mcp.sh
2eae238c2badb54b720cc1f6270f677dda9a6293
link
/test e2e-mixer-no_auth-mcp

prow/istio-unit-tests.sh
e2e199067456fa2e22b57f09db53fc41e39f7f8e
link
/test istio-unit-tests

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

/test istio-unit-tests


GPU to CPU memcpy is consuming huge time

Hi,
I have implemented the alexnet using the armcompute-cl apis.
Alexnet execution is faster  , but the time taken to transfer softmax output to CPU is pretty huge(if entire network takes 10 ms GPU to CPU transfer takes 100ms).
This doesnt seem to be justified ,Is there anyway we could reduce this overhead?
Thank you,
G. Praveen.

Hello @uu-praveeng,
We need more information about how your pipeline looks like. Are you sure you wait for your opencl queue to finish before you collect the timings of the network run?

Thank you George. I was missing the sync. Now the numbers appear reasonable.


Add error handling for writing out to Google Sheets

There seems to sometimes be issues with Google Sheets.
In those cases, ideally, there would be a graceful fail whereby the HTML file would still get generated and the underlying data would all get written out to an .rda file (or something) so that a separate script could read in that file and just write it out to Google Sheets.
There is the ability to switch a flag (use_local_files: change from FALSE to TRUE) to populate the Google Sheet using locally stored data rather than re-querying. This is a partial fix--just speeds up subsequent runs if the only issue was that the hang-up happened on writing to Google Sheets.

Handy to get the google sheets id
how to get google sheet id


TimePicker in ReactiveForms crashes when the input is a string representation of a Date.

Reproduction link
https://stackblitz.com/edit/ng-zorro-antd-start-6psoqi
Steps to reproduce

Create Reactive Form
Add TimePicker with formControlName
Set FormGroup data with patchValue, where the input for TimePicker is a string representation of a Date (new Date().toJSON())
Click on TimePicker and pick something else.

What is expected?
Should convert the string to the Date
What is actually happening?
Tries to call Date related functions on a string, like getHour, getMinutes which leads to crash.

Environment
Info

ng-zorro-antd
8.5.2

Browser
Firefox Developer Edition, Chrome

Fixed it by #4949.


Update README (depreciation)

Add depreciation warning in README

I edited the file myself thanks to your suggestion! I will archive the repository soon. Thanks again!


Fix delete / cleanup of kind cluster when standalone-cluster or management-cluster delete fails

Fix delete / cleanup of kind cluster when standalone-cluster or management-cluster delete fails. Currently this is not being done, for example -
https://github.com/vmware-tanzu/community-edition/blob/0bf658cbbb3ce8b5469f2ff76a04bbdb8ce2aa4a/test/azure/deploy-standalone-cluster.sh#L63-L70
https://github.com/vmware-tanzu/community-edition/blob/0bf658cbbb3ce8b5469f2ff76a04bbdb8ce2aa4a/test/azure/deploy-management-and-workload-cluster.sh#L278-L281
Also, as part of this issue, we can also fix unnecessary kind cluster delete processes. For example I made a mistake adding this extra delete_kind_cluster here -
https://github.com/vmware-tanzu/community-edition/blob/0bf658cbbb3ce8b5469f2ff76a04bbdb8ce2aa4a/test/vsphere/run-tce-vsphere-standalone-cluster.sh#L63-L68
Ideally, if tanzu standalone-cluster create is working correctly, it would have deleted the kind bootstrap cluster once the standalone cluster creation is done. So, when it comes to check-tce-cluster-creation.sh, the kind bootstrap cluster would ideally not be present, but I added the delete_kind_cluster due to some confusion with #2457 issue and it's PR #2459 . So the delete_kind_cluster after check-tce-cluster-creation.sh but it doesn't cause any problems in a clean CI environment, no failures etc, as we use xargs -
https://github.com/vmware-tanzu/community-edition/blob/0bf658cbbb3ce8b5469f2ff76a04bbdb8ce2aa4a/test/util/utils.sh#L10-L13
But yeah, in local (dev machine) it would unnecessarily delete some kind bootstrap clusters, which is also a generic problem mentioned here - #1270 with a possible solution but it hasn't been implemented yet, so I guess that's a separate issue but I just wanted to call it out here. But in any case, the delete_kind_cluster just right after check-tce-cluster-creation.sh failure is not necessary

Till now we haven't seen any problems due to the issue, so there's no evidence to show that the kind cluster cleanup didn't happen, say in CI. Maybe in local this can be simulated. But it's important to cleanup things to not bloat up the environment - be it in CI (ephemeral or non-ephemeral) or dev.

I missed to simulate the scenario and test it. Looks like there are still some problems in the PR #2548 that I created, causing the cleanup to not happen while other failures happen, for example, pod ready timeout and not during deletion failure

Some pipelines that got affected and failed -
https://github.com/vmware-tanzu/community-edition/runs/4289831772?check_suite_focus=true - test-mc-9355
https://github.com/vmware-tanzu/community-edition/runs/4289904215?check_suite_focus=true - test-mc-18356

Due to this issue, there were many Azure TCE clusters lying around that weren't cleaned up 😅 . Cluster unique names that can be found in the pipelines -
test-mc-5871
test-mc-4786
test-mc-201
test-mc-25169
test-wld-25169
test-mc-13798
test-wld-13798
test-mc-23235
test-wld-23235
test-mc-4801
test-mc-4604


feat: implement map to mesh serialization

implement CMap2::to_vtk_file method, used to generate a VTK file of the mesh represented by a combinatorial map
add an example io_generate_vtk, which generates the mesh represented by the map built in render_squaremap_split_some

Example
Using honeycomb-render:

Using Paraview to read the generated vtk file:

Scope

[x] Code: honeycomb-core, honeycomb-examples

Type of change

[x] New feature(s)

Necessary follow-up

[x] Testing: for all of the io module
[x] Other: handle corner detection?

Codecov Report
Attention: Patch coverage is 0% with 115 lines in your changes are missing coverage. Please review.

Project coverage is 76.84%. Comparing base (8c1454b) to head (4303e12).
Report is 1 commits behind head on master.

Files
Patch %
Lines

honeycomb-core/src/cmap2/io.rs
0.00%
115 Missing :warning:

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   80.83%   76.84%   -4.00%
==========================================
  Files          17       17
  Lines        2072     2207     +135
==========================================
+ Hits         1675     1696      +21
- Misses        397      511     +114

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Make get_fptr_shape public and a bug fix

Types of change(s)

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
[ ] Trivial change (affects only documentation or cleanup)
[ ] Refactor (no functional changes, no api changes)

Checklist

[ ] Tested this change with a run of GEOSgcm
[ ] Ran the Unit Tests (make tests)

Description

Excluding negative values of gridToFieldMap
Making mapl3g_FieldCondensedArray::get_fptr_shape public

Related Issue

I would still like to see a unit test that guards against this issue. This is the 2nd bug that has been found in this interface. First was that the gridToFieldMap was not even being allocated, and the unit tests only covered the lower level procedures. (@darianboggs)

Created issue #3127

I'm not sure what the use case for get_fptr_shape being public is, but I'm not opposed.

I think you are out of date.  That was removed.


Tables!

Adding tables!

Additions

Added cf-tables
Added macro for table creation

Removals

Removed old conflicting table styles

Testing

Visit /sublanding-page-2/ and any other tables we might have to revisit

Review

@anselmbradford
@jimmynotjim
@sebworks

Preview

Preview this PR without the whitespace changes
Notes

:+1:, just wondering if there should be a full-width modifier for the table.

Minor comments but overall looks good.
Side note, I think @KimberlyMunoz wins the CFPB PR Gifslinger award

Just wondering if there should be a full-width modifier for the table.

I think for mobile styles, we probably want the full-width to be the default. I'll open a PR on cf-tables for that.

:+1:

:+1:


fix(formly-form): validateOnModelChange now copes when field.formControl is an array #523

What
Fix for issue #523
Why
Bug fix
How

If field.formControl is an array, then call $validate method of each element
Checklist:

[x] Follows the commit message conventions
[x] Is rebased with master
[x] Is only one (maybe two) commits

Current coverage is 96.00%

Merging #641 into master will not affect coverage as of 439d581

@@            master   #641   diff @@
=====================================
  Files           16     16
  Stmts         1150   1152     +2
  Branches         0      0
  Methods          0      0
=====================================
+ Hit           1104   1106     +2
  Partial          0      0
  Missed          46     46

Review entire Coverage Diff as of 439d581

Uncovered Suggestions

+0.35% via ...alidationMessages.js#25...28
+0.26% via src/test.utils.js#38...40
+0.26% via ...s/formlyUsability.js#18...20
See 7 more...

Powered by Codecov. Updated on successful CI builds.

Looks good to me. But I would like someone else to merge this: @formly-js/angular-formly-collaborators

Anyone in @formly-js/angular-formly-collaborators-read who feels confident they can have commit access, I'll add you to @formly-js/angular-formly-collaborators :-)

@kentcdodds @ckniffen Is there a way to check if bug #594 still happens? It was a similar bug that happened with repeat sections.. If a release was out we could check it on this bin.

Unfortunately it looks like it's not fixed

Actually, it looks like this wasn't auto-released for some reason :-( Filing an issue.

That's the reason I asked if there is a way to check the updates on that version.. sorry for not being clear on my previous message.

Yeah, it hasn't yet been released because there's a problem. So no, there's not really a way... Feel free to help out here: #643


ui issue in delete all button in compare in velocity (mobile view

Bug Report

Issue Description

Preconditions

Bagisto Version

[ ] master branch
[ ] 1.3.3
[ ] 1.3.2
[ ] 1.3.1
[ ] 1.3.0

Steps To Reproduce

Actual Result

Expected Result

duplicate https://github.com/bagisto/bagisto/issues/5698


Please ignore. This is for testing.

Commit IDs
98d5d5, https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, a2b775
Category
team-OSS, team-Bazel
Reviewers
@Pavank1992, @iancha1992

The following commits were cherry-picked in https://github.com/bazelbuild/bazel/pull/19775: https://github.com/iancha1992/bazel/commit/79a0dc276cc81717ac2951d575e19f6a54d71e43, https://github.com/iancha1992/bazel/commit/a2b775.
Failed commits (likely due to merge conflicts): https://github.com/iancha1992/bazel/commit/98d5d5
The failed commits are NOT included in the PR. Please resolve manually.
cc: @bazelbuild/triage


Timeout variable not precise enough?

Over the past 2 months I have had 7 "Unknown errors" that actually seem to be timeouts.
When inspecting my response headers, each of these cases have a "total" time value of 9.99....

Is there a way to resolve this?

I'm not quite sure what you're asking here.

You can ignore this issue. Looking at my question now, I am not sure where my head was at at that time 😏
This is a cURL issue.


invalid doc

https://github.com/glensc/node-cached_property/runs/5083199199?check_suite_focus=true

Error: Unable to resolve action<EMAIL_ADDRESS>unable to find version v1.2.0

Same here. Did you find a workaround?

yes. not using this action at all:

https://github.com/glensc/node-cached_property/pull/4/files

Thank you very much.

@pubkey the release should actually be<EMAIL_ADDRESS>just without the beginning v


Use Asterisks for omitted values in k3s node config

omitted values such as tokens, secrets, etc. should be omitted and replaced with ***** in the node config annotations

Verified using k3s version v1.17.4-alpha1+k3s1


Add support for findRecord() and query() without any listeners

There may be some cases where having listeners in findRecord() and query() doesn't make sense. To solve this, the referenceId param will be optional.
Once this change lands, here's what the new usage will look like.
let firebaseUtil = this.get('firebaseUtil');

// With listeners
firebaseUtil.findRecord('users/foo', 'referenceId');
firebaseUtil.query('post', 'userFeeds/foo', { limitToLast: 1 }, 'referenceId');

// Without listeners
firebaseUtil.findRecord('users/foo');
firebaseUtil.query('post', 'userFeeds/foo', { limitToLast: 1 });

In addition, the old usage will be supported alongside the new one but a deprecation warning will be shown if the script detects that you're using the former. Once the next major version lands, the old usage will break and you'll have to migrate it if you haven't yet.
For the controversial part, how will the script know if a user is using the old vs new usage? There might not be a clean and efficient way to do this. For now, the only thing I could think of is to check if the 1st param in a findRecord() has a / char. This would mean that the first param is a Firebase path and that the user is using the new usage. Same thing goes for query() except that we're checking the 2nd param intead. The drawback here is that what if the user is pointing to a root node where a / char is unnecessary? Well, with the small user base of this addon, I'm gambling that not a single person is doing that since that would be anti-pattern.
EDIT:
Specs are not finalized yet.

Closed in favor of #27


second try: just testing with the chunk size and gc tunning

Check List:

[V ] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
[V ] All formatting changes by the build are committed
[V ] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
[ V] Output matches that of calculate_average_baseline.sh

Execution time: 14 seg
Execution time of reference implementation: 3m30s

00:11.405 now, nice. Thx for participating!


Improve support for transparent embedding on HTML5

The Stage object is always instantiated with a background colour, this prevents transparency as the canvas always filled with said colour.
See this commit from way back: https://github.com/openfl/openfl/commit/dda7305a3d0c7bfb26533c883a2b8e2d948096e1
However, reverting back won't fix the issue. I've done some tests, the config.background can never be null. Nor 'unset' as the CLI always provides white as the default colour.
Thus, there is no way to pass null to allow transparency. For now, I can manually enable transparency by @:privateAccess stage.__transparent = true; at the start of my app.
Not sure what the best approach would be, maybe to add a new window parameter transparent : Bool or by passing a special -1 value to allow the passing of null to the Stage instantiation.
Let me know what you think. Happy to help implement something. :)

Lime 4 (and subsequently OpenFL 4.9) revised the default HTML template, I believe you should be able to override the background color now, by adding background: null to the config object in the lime.embed call.
Also, I believe you may also be able to do it in XML using <window background="" />
Please let me know if these solutions don't work for you :smile:

Using OpenFL 4.9 and currently it keeps setting the background to black.
This is what I tried to do:
	<script type="text/javascript">
		lime.embed ("::APP_FILE::", "openfl-content", ::WIN_WIDTH::, ::WIN_HEIGHT::, {parameters: {background: null}});
	</script>

	<window background="" fps="60" />

Many thanks. :)


Accessible label missing of the Send button in SendBox.tsx

Describe the bug; what happened?
Button to send a chat message is missing discernable text / an accessible label. Button is an interactive element and doesn't have readable text (only an icon SendBoxSend), so a programmatic text / accessible label is needed to convey programmatic meaning, e.g. to screen readers.
What are the steps to reproduce the issue?
Open de chat pane, open Dev Tools and find '<button type="button" class="ms-Button ms-Button--icon root-173" id="sendIconWrapper"', or Accessible Insights > Fast Pass > see the button-name issue.
What behavior did you expect?
The button to have a title or aria-label, so that screen reader users understand the function of the button.
If applicable, provide screenshots:

In what environment did you see the issue?

OS & Device: Windows 11 on Surface Laptop 4
Browser: Microsoft Edge
Version 103.0.1264.77

Is there any additional information?
N.A.

Thanks for filing this @josalomo , we'll take a look as soon as possible and get back to you

HI @josalomo, can you verify you are seeing this issue in the latest version of @azure/communication-react (version 1.3.0 or greater).
We recently pushed an accessibility fix in this area that should ensure an aria-label is correctly set #2004

Thanks @JamesBurnside, Think we're indeed using a previous version. Looking at the merged commit of #2004, it indeed looks like an aria-label is present. Will give it a try with version 1.3.0 or newer, and follow-up with the findings.

@josalomo marking this issue as closed. Please leave a comment if you still hit this issue


Create search function to return dataset UUIDs

Datasets should be searchable according to a variety of metadata current present in datasets.json, as well as additional meta-data that have not yet been added (see https://github.com/ccodwg/Covid19CanadaArchive/issues/116). Currently the only way to discern a dataset's UUID is to read datasets.json directly.

Solved by Covid19CanadaArchive-data-explorer.


As per rebrand

Description

Urgency

[ ] Blocker
[ ] High
[ ] Medium

Requirements

See the contribution guidelines.
Build content locally and test for formatting/links.

@pleia2 ^^