To get the result of mae and rmse

Hi，I want to know the result of mae and rsme after new dataset was added to the test. In utils.py you define a function named imputation_accuracy but you don‘t use it in the example using heart dataset . When I try to use this function in mydataset to get mae，I got some error！Could you tell me the usage of the function to get the result of mae and rmse？Thanks！

Hi! MAE and RMSE can be computed on artificially induced missing values of course. The function imputation_accuracy takes 3 arguments, the original dataset, the imputed one and the mask indicating where are the missing values. This mask is the second output of degrade_dataset.

Thanks！I knew what the three parameters refer to. The main problem is the dimension of imputed dataset varies from that of the original dataset.It seems that some one-hot codes were added to the imputed dataset. Could you tell me how to make the imputed dataset have the same dimension and format as the original dataset? Only in this condition that the calculation of mae and rmse is meaningful.

这是来自QQ邮箱的自动回复邮件。您好，您的邮件我已收到，我会尽快处理并且给您回复，祝您生活愉快。

这是来自QQ邮箱的自动回复邮件。您好，您的邮件我已收到，我会尽快处理并且给您回复，祝您生活愉快。


How to reverse One hot encoding

Hello,
How to get the data in the original form (reverse dummies). We receive the imputed dataset in one hot encoded form. But how to convert it into the original dataset (the categorical data).
Thank you

Hi @khanwa,thanks for raising this issue!
I have now updated the example notebook to demonstrate how the imputed one hot data can be transformed back into categorical variables. I hope that helps, but do feel free to reopen this issue if not.
Tom


Fix height of params text window

It should scale with the height of the image, [ .. configure -height] / height of character in the font = # lines.

Fixed in 9175a2e666c8a9c9a4e46b51d145005cf556bb85


Add checkpoint save interval variable.

What?
Add an option in all the systems to set the time interval in minutes between checkpoint saving.
Why?
Helps address an issue where the default interval value of 15 minutes is too long when trying to debug if checkpoint loading is working.
How?
Made minor changes in each system's system.py, builder.py and trainer.py files.
Extra
.

The failing checks seem to be an AutoRom issue, so we should be able to get this in once Kale-ab's manual install PR is in.

Thanks @DriesSmit , this is useful! Any reason to set the default for checkpoint_minute_interval to 5, as opposed to 15? Do you think 15 minutes between checkpoints is too long?
I also pushed a commit removing system tests from github actions on this PR branch. @arnupretorius I think that automatically made your review stale on github :( _

Thanks @DriesSmit , this is useful! Any reason to set the default for checkpoint_minute_interval to 5, as opposed to 15? Do you think 15 minutes between checkpoints is too long?
I also pushed a commit removing system tests from github actions on this PR branch. @arnupretorius I think that automatically made your review stale on github :( _

Thanks @DriesSmit , this is useful! Any reason to set the default for checkpoint_minute_interval to 5, as opposed to 15? Do you think 15 minutes between checkpoints is too long?
I also pushed a commit removing system tests from github actions on this PR branch. @arnupretorius I think that automatically made your review stale on github :( _

Hey. I chose 5 minutes because the issue was that the person was not seeing saved results when training. So I thought a smaller save interval might circumvent this problem in the future. We can change the default back to 15 minutes if you think 5 minutes is not little time?

Thanks @DriesSmit , looks good 👍 Personally, I think 15 minutes might be a better default, striking a balance between writing to disk performance and restoring the latest model, but I am happy to leave this decision up to you :)

I think let's leave it at 5 for now, to cover the debugging env case that brought this up. If we feel we need to change it, we can update it in a separate PR.


Convert access=public to access=yes

See

dropping this tag in iD https://github.com/openstreetmap/iD/issues/2280
dropping this tag in JOSM https://josm.openstreetmap.de/ticket/10007
JOSM deprecation ticket https://josm.openstreetmap.de/ticket/18007
deprecation sanity check on mailing lists https://lists.openstreetmap.org/pipermail/tagging/2019-July/046871.html
https://wiki.openstreetmap.org/wiki/Tag:access%3Dpublic describing it as deprecated
https://taginfo.openstreetmap.org/keys/access#values
https://taghistory.raifer.tech/

@matkoniecz Sounds fine. Thanks for going through the diligence of discussing this kind of deprecation in other channels.


Add run the Rollup build command on every build

This was present in a .NET5, it got lost during .NET6 migration.
It's still in  .net5 branch:
https://github.com/vb-consulting/RazorSvelte/blob/net5/RazorSvelte/RazorSvelte.csproj#L82
However, U don't think it's necessary for Debug builds and it slows down builds significantly.
It might be better to do it only for Release build when you doing publish operation.
So this should be constrained only for Release configuration like this:
  <PropertyGroup Condition="'$(Configuration)' == 'Release'">
    <PreBuildEvent>npm run build-all --color=always</PreBuildEvent>
  </PropertyGroup>

Also, I'm not sure why I've deleted the build outputs from wwwroot/build.
I think it's better to have them in the source.
If they are removed, they should be ignored by git in .gitignore.

Closing this PR. You can find this build on Release change in following change:
https://github.com/vb-consulting/RazorSvelte#2021-10-02


Questions about Hue light types and configuration

Thank you very much for your excellent script!
I have a few questions to clarify the details. Could you please confirm if the mapping between my Philips Hue model IDs and the bulb types in your PicoC program is correct? Specifically, I'm uncertain whether to select TYPE_SINGLE_DIM or TYPE_SINGLE_TUNABLE, as I don’t fully understand the difference.

Model ID
Product
Type
Type in PicoC program

LCA001
Hue color lamp
Extended color light
TYPE_SINGLE_RGB

LCL001
Hue lightstrip plus
Extended color light
TYPE_SINGLE_RGB

LCT015
Hue color lamp
Extended color light
TYPE_SINGLE_RGB

LOM002
Hue smart plug
On/Off plug-in unit
TYPE_SINGLE_ONOFF

LWA004
Hue filament bulb
Dimmable light
TYPE_SINGLE_DIM

LWO001
Hue filament bulb
Dimmable light
TYPE_SINGLE_DIM

For the Lighting Controller in Loxone Config, could you please confirm if we should use "Lumitech DMX" as the lighting type, or is there a different setting we should apply?
Lastly, I noticed that the Hue smart plug is listed among the lights on the Hue bridge. Does this mean we can also control it through your program?
Thank you for your help!

I would also like to know. Since all difers with the values.. LIke X/Y/BRI , CT/BRI ....


Review and edit services.md

What I changed
Takes a crack at #148. @vincentsarago can you provide some feedback on if it matches your expectations? I'm not sure if you wanted to remove the custom mentions for each service below. They still seem relevant. I'm also unsure on how much detail we want to provide; the API documentation of each service seems to be the best-detailed view, while services.md is meant as an overview.
Edit mentions of custom functionality and detail services to match README.md.
How I tested it

Run mkdocs serve
Visit the live site and read through content

I'm not sure if you wanted to remove the custom mentions for each service below. They still seem relevant. I'm also unsure on how much detail we want to provide; the API documentation of each service seems to be the best-detailed view, while services.md is meant as an overview.

Yeah I think we should remove any mention to the the custom runtime and focus on the goal of each service (mention that they are build on stac-fastapi/titiler-pgstac ... ) and what user can expect from the service
Ideally we would have 4 components:

Database (Postgres with PgSTAC) to host the STAC Catalog and Public vector datasets
Metadata Service (stac-fastapi)
Raster (titiler-pgstac)
Features/Vector (tipg)


bitwise or (pipe symbol) in property declaration breaks file documentation

When running this file through phpdoc 2.8.5
<?php
/**
 * description file
 */

/**
 * description class c
 */

class c {
 /**
 * description property a
 */
 public $a = 1 | 2;
}

?>

the result is this error:
Parse Error: Syntax error, unexpected '|', expecting ',' or ';' on line 14  No summary was found for this file
Removing the pipe symbol the documentation process works without a problem:
<?php
/**
 * description file
 */

/**
 * description class c
 */

class c {
 /**
 * description property a
 */
 public $a = 1;
}

?>

This seems to be a bug.

The error message "No summary was found for this file" is wrong
a bitwise or at this property declaration works fine in php.

please try version 2.9.0 and let me know if this problem still exists.

The issue has been resolved in Version 2.9.0. Thanks.


Improve test coverage for raw decoder

Missed this method in #4183, fixes error when getting value from RawValueProvider more than once. Need to "reset" the position each time a get method is called.
Thought I missed getSlice but I did not. Instead I've just improved the test to cover every combination of presto/java types.

added columns for each different combination of data types

Merged, thanks!


[FLINK-36077][Connectors/Google PubSub] Implement table api support for SinkV2

Description

Add Table Api support for PubSubSinkV2 [FLINK-36077]
Added credential providers options for Json Credentials and Access token credentials

Testing

Added Unit tests
Tested against GCP pubsub

Documentation

https://issues.apache.org/jira/browse/FLINK-36078

@snuyanzin Could you please take a look?

@snuyanzin Could you please review or nominate a reviewer please?

@snuyanzin thanks for the review, I refactored the factory tests and removed unnecessary public access modifiers, PTAL

CI is failing,
i guess the reason is dependency convergence since at some point commons-codec in Flink main repo was bumped to 1.16.1

@snuyanzin yeah, good idea. Fixed now


Protect handle_close to prevent closing an already closed fd

Hi,
This PR is to protect handle_close to prevent closing an already closed fd, especially when gc is called afterwards.
Let me details the sequence of events that :

create a new inotify handle in scope A
close the handle, handle_close is called, which calls the POSIX close on the fd.
exit scope A, the handle has no reference pointing to it
wait / force Lua garbage collection cycle
the inotify handle needs to be collected, the handle__gc func is called, it calls handle_close which calls the POSIX close on the fd.

Two possible outcomes:

the fd value has been re-assigned to another file descriptor (socket, io.open etc), then the later close call is done on a fd that now points to something else, so that's bad
the fd value has not been re-assigned,  then the later close call is done on a "bad" fd so that's bad too.

The fix here is just to use a predefined value to be able to tell if the close needs to be done or not.
Another improvement could be to check for INVALID_FD in get_inotify_handle func, or the callers of  get_inotify_handle, and maybe throw an error.
Regards,

Nice catch!  Thanks for the fix!

Thank you for the quick merge!


beta 3 does not seem to honor pre and post hooks on dependencies

Hello,
I am trying to build our app that lists bcrypt as second order dependency (used by erlpass). It used to build correctly with beta 2, but now it seems the C sources are not built. If I cd directly to bcrypt and try rebar3 again, the C sources are properly built.
Same thing for rebar3 clean -a, the C binary products are not removed, though a rule is specified as a post_hook.
Best,
Cam

Forget about that, it happends my definitions of pre and post hooks were slightly different than in the manual. Now it works.


oc-client 0.41.15 does not properly compile some dependencies

Today I've found our CI environment failing on OC deploy, due to the following error:

We didn't change anything from the previous working deploy to this, but the oc-client version changed. Using oc-client 0.41.13 works as expected, but the current doesn't allow us to properly publish to the registry.

Thanks @elboletaire - I am looking into this.

BTW, is this dependency check/installreally needed? The way we work, we previously compile all the required dependencies and when we do oc publish we already have everything ready to be uploaded, so this is redundant for us, and even buggy as seen in #591


Missing type for Command.options

Command has a property options which seems to be missing in this repo.

Yes, thanks for report.
Have have not caught up with these changes: https://github.com/tj/commander.js/pull/1827

Added in v11.1.0


Pr old cpuid is back

dep ensure
old cpuid is back

These changes are already present in #14. Closing this one as stale.


Cannot refresh state

Bug Description:
When we try to remove an item from our suggestion list, then already opened suggestion box cannot understand that so it didn't update.
However, FieldSuggestion's BoxController should have a refresh functionality to refresh widget after local changes.
Reported by: @g-scota
To Reproduce
Steps to reproduce the behavior:

Make a field suggestion widget (by builder).
Add remove functionality to Suggestion Item. and try that functionality

Great! Thanks for the fast fix!

@g-scosta  You're welcome! Okay, then I'll merge it and release a new version 😄


ENG-3537: Add batch payment status

JIRA
ENG-3537

Description
Add batch payment status
Checklists
Development and testing:

[x] The code changed/moved as a part of this PR has been covered with tests
[x] All tests related to the changed code pass in development

Pre-release and code review:

[x] CI build is green
[x] CodeClimate does not see any new issues
[x] "Ready for review" label attached to PR and reviewers mentioned in a comment
[ ] Changes have been reviewed by at least one Senior Engineer
[x] JIRA issue has a link to this pull request

how about adding specs?

thanks @hari-eligible, added specs


DRM preview unavailable - not master

I have attached a new LCD screen to my RPI4:
https://botland.com.pl/wyswietlacze-raspberry-pi/5337-ekran-dotykowy-pojemnosciowy-lcd-ips-7-c-1024x600px-hdmi-usb-rev-41-do-raspberry-pi-obudowa-czarno-biala-waveshare-11303-5904422371340.html
Connecting this screen required adding to /boot/config.txt:
max_usb_current=1
hdmi_group=2
hdmi_mode=87
hdmi_cvt 1024 600 60 6 0 0 0
hdmi_drive=1

Then I tried to show frames from my IMX477 on such LCD screen but I ended up with an exception thrown from drm_preview.cpp: DRM preview unavailable - not master.
I disconnected this LCD screen and switched to my monitor but I also ended up with DRM preview unavailable - not master. This exception was not thrown until I tried to use another LCD screen.
Things I did e.g.:

reverted modifying /boot/config.txt
rebuilding libcamera and libcamera-apps
rebooting of course

It seems like another device/process became DRM master and I cannot preview frames from the camera?

hdmi_group=2
hdmi_mode=87
hdmi_cvt 1024 600 60 6 0 0 0
hdmi_drive=1

Are all largely irrelevant if using vc4-kms-v3d (the default on Bullseye).
Your screen is HDMI, so as long as it has a valid EDID, vc4-kms-v3d should adopt that resolution. You may need to add disable_fw_kms_setup=1 to stop the firmware trying to persuade KMS what resolution to use.
Waveshare's instructions will often tell you to remove dtoverlay=vc4-kms-v3d from config.txt. This is bad advice and would likely cause issues to those you are seeing.
What environment are you using? Raspberry Pi OS with desktop, or Lite / booting to CLI?
DRM only supports a single master at any one time, therefore if you have Xserver or other window manager running then it will claim that role and stop libcamera-apps from requesting it.
Trying to run two instances of libcamera-[still|vid|hello] on a CM will also cause that error, as the first one will claim the master role and hence block the second.

Adding disable_fw_kms_setup=1 instead of
hdmi_group=2
hdmi_mode=87
hdmi_cvt 1024 600 60 6 0 0 0
hdmi_drive=1

also allows the LCD screen to work, so thanks for this tip.
But the initial problem with DRM remains. How can I check which process is current DRM master so maybe I can try to kill it?
I am using RPI OS with desktop:
Distributor ID: Raspbian
Description: Raspbian GNU/Linux 11 (bullseye
Release: 11
Codename: bullseye

Okay, I fixed it when reading once again that Window Manager might be the master of DRM. I switched to terminal mode and tried to run libcamera-hello and it started previewing frames.
But the preview was working even when I was using desktop mode, so it's strange.

But the preview was working even when I was using desktop mode, so it's strange.

You hadn't said that the preview worked before.
libcamera-apps have 3 different routes for rendering - EGL, DRM, and QT.

EGL requires Glamour and an X environment
DRM needs to be able to acquire the master role, so no X.
QT is the worst performing, but requires the least from the installed environment.

At a guess you've managed to disable EGL rendering and it's falling back to QT, but I could be totally wrong there.

I am using only DRM. Command cmake prints that EGL and QT is disabled.

I am closing becuase the solution was to switch to terminal mode (Ctrl + Alt + F1) and launch previewing without Window Manager.


Introduce listener TCP connection buffer configuration and implement …

…read buffer limits (#150).
Baby steps towards flow control. This patch plumbs the TCP connection buffer limits to the listener
and enforces it on the read buffer only. Later patches will also plumb to the upstream cluster
connection and cover the write buffer (which requires the watermark API).

I'm trying to unbury myself. I will look at this later today or this weekend.


error

hello so when i use the thing it works fine but then i have to anthenticate myself and when i do it crashes and gives me this error

You don't have valid environment variables. Cross check them


ImportError

python producer.py /home/work/qbusbridge/config/kafka.ini mini_spider_struct_data groupid_test ip1:port1,ip2:port2,ip3:port3
Traceback (most recent call last):
File "producer.py", line 1, in
import qbus
File "/home/work/qbusbridge/python/examples/qbus.py", line 26, in
_qbus = swig_import_helper()
File "/home/work/qbusbridge/python/examples/qbus.py", line 22, in swig_import_helper
_mod = imp.load_module('_qbus', fp, pathname, description)
ImportError: /home/work/qbusbridge/python/examples/_qbus.so: undefined symbol: _ZTVN6snappy22UncheckedByteArraySinkE

It looks like you're using an outdated snappy. Tips, the default snappy on CentOS 7 is too old. You should install a newer snappy as the dependency.

It looks like you're using an outdated snappy. Tips, the default snappy on CentOS 7 is too old. You should install a newer snappy as the dependency.


Promises

Introduces promise base processing:

Removes old isReady method
Implements custom initialisation methods for locale loading

Still needs changes to documentation.

Implements custom initialisation methods for locale loading

Can a custom method work synchronously?


fix logical_not cn doc test=develop test=document_fix

fix logical_not cn doc

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


How can i set number of threads for Optimum exported model?

System Info
optimum==1.2.3
onnxruntime==1.11.1
onnx==1.12.0
transformers==4.20.1
python version 3.7.13

Who can help?
@JingyaHuang @echarlaix
Information

[ ] The official example scripts
[X] My own modified scripts

Tasks

[ ] An officially supported task in the examples folder (such as GLUE/SQuAD, ...)
[X] My own task or dataset (give details below)

Reproduction
Hi!
I can't specify the number of threads for inferencing Optimum ONNX models.
I didn't have such a problem with the default transformers model before.
Is there any Configuration in Optimum?
Optimum doesn't have a config for assigning the number of threads
from onnxruntime import SessionOptions
SessionOptions().intra_op_num_threads = 1

also limiting  on OS level doesn't work:
taskset -c 0-16 python inference_onnx.py

taskset -c 0 python inference_onnx.py

Hello @MiladMolazadeh , by coincidence I run into the same issue today!
Would https://github.com/huggingface/optimum/pull/271 solve your issue?
I propose the following workflow:
from functools import partial

from optimum.onnxruntime import ORTQuantizer
from optimum.onnxruntime.modeling_ort import ORTModelForSequenceClassification, ORTModel
from optimum.onnxruntime.configuration import AutoQuantizationConfig

import onnxruntime

import time
import torch
from tqdm import tqdm

model_name = "distilbert-base-uncased-finetuned-sst-2-english"
optimum_model_path = "/path/to/optimum_model.onnx"
optimum_quantized_model_path = "/path/to/optimum_quantized_model.onnx"

quantizer = ORTQuantizer.from_pretrained(model_name, feature="sequence-classification")

# Inference with Optimum
qconfig = AutoQuantizationConfig.avx512_vnni(is_static=False, per_channel=False)

quantizer.export(
    onnx_model_path=optimum_model_path,
    onnx_quantized_model_output_path=optimum_quantized_model_path,
    quantization_config=qconfig,
)

options = onnxruntime.SessionOptions()
options.intra_op_num_threads = 1
ort_session = ORTModel.load_model(optimum_quantized_model_path, sess_options=options)

ort_model_eval = ORTModelForSequenceClassification(ort_session, config=quantizer.model.config)

transformers_model_eval = AutoModelForSequenceClassification.from_pretrained(model_name)

inputs = {}
inputs["input_ids"] = torch.randint(high=1000, size=(8, 128))
inputs["attention_mask"] = torch.ones(8, 128, dtype=torch.int64)

print("Running ONNX Runtime.")
for i in tqdm(range(10)):
    ort_model_eval(**inputs)

start = time.time()

for i in tqdm(range(20)):
    ort_model_eval(**inputs)

print("Time using ONNX Runtime:", time.time() - start)

With this, you may use taskset to pin to specific core number, otherwise onnxruntime assigns freely.
Note that this would not solve the issue in the example scripts, that make use of an older ORTModel class. If needed we could modify this one as well and add an arguments in the example scripts.

Hello @MiladMolazadeh , by coincidence I run into the same issue today!
Would #271 solve your issue?
I propose the following workflow provided the above code is merged:
from functools import partial

from optimum.onnxruntime import ORTQuantizer
from optimum.onnxruntime.modeling_ort import ORTModelForSequenceClassification, ORTModel
from optimum.onnxruntime.configuration import AutoQuantizationConfig

import onnxruntime

import time
import torch
from tqdm import tqdm

model_name = "distilbert-base-uncased-finetuned-sst-2-english"
optimum_model_path = "/path/to/optimum_model.onnx"
optimum_quantized_model_path = "/path/to/optimum_quantized_model.onnx"

quantizer = ORTQuantizer.from_pretrained(model_name, feature="sequence-classification")

# Inference with Optimum
qconfig = AutoQuantizationConfig.avx512_vnni(is_static=False, per_channel=False)

quantizer.export(
    onnx_model_path=optimum_model_path,
    onnx_quantized_model_output_path=optimum_quantized_model_path,
    quantization_config=qconfig,
)

options = onnxruntime.SessionOptions()
options.intra_op_num_threads = 1
ort_session = ORTModel.load_model(optimum_quantized_model_path, sess_options=options)

ort_model_eval = ORTModelForSequenceClassification(ort_session)

transformers_model_eval = AutoModelForSequenceClassification.from_pretrained(model_name)

inputs = {}
inputs["input_ids"] = torch.randint(high=1000, size=(8, 128))
inputs["attention_mask"] = torch.ones(8, 128, dtype=torch.int64)

print("Running ONNX Runtime.")
for i in tqdm(range(10)):
    ort_model_eval(**inputs)

start = time.time()

for i in tqdm(range(20)):
    ort_model_eval(**inputs)

print("Time using ONNX Runtime:", time.time() - start)

With this, you may use taskset to pin to specific core number, otherwise onnxruntime assigns freely intra_op_num_threads cores.
Note that this would not solve the issue in the example scripts, that make use of an older ORTModel class. If needed we could modify this one as well and add an arguments in the example scripts.

Not Worked For me!
I have trouble with specifying the number of cores with/without taskset!


what is "from" field?

'from' => '' // A valid email where the domain should be the same when the form is hosted.
Is there an example?

@hgati,
For example: If I have a xpto.com domain, the field needs from an email with the xpto.com domain for e-mail clients do not reject emails.

ok, thanks.


1.13 sound latency is too big

What is the output link of /viaversion dump?
https://dump.viaversion.com/853be840152de9abfdcbe954a2be3668c4505ca8eda1e1f955addddafd62302f
Are you using any additional software like BungeeCord? If so, what software and version?  Using an item?
Just use anything to play a sound.
Is there an error in the console? Use pastebin.com. Is there a kick message?
Nope.

Unable to replicate this, try latest dev build as we've modified some sound stuff. Otherwise please provide minimal configuration to replicate and we'll reopen. (As we're unable to replicate with just VV)


privateKey option can't be set in the "options" object

Hello,
This works:
    crx: {
      example: {
        options: {
          baseURL: 'http://...'
        },
        privateKey: 'key/chrome.pem',
        src: dir,
        dest: dir,
        filename: 'example.crx'
      }
    },

This does not work: (and your docs are like this)
    crx: {
      example: {
        options: {
          baseURL: 'http://...',
          privateKey: 'key/chrome.pem',
        },
        src: dir,
        dest: dir,
        filename: 'example.crx'
      }
    },

Hi, I can also confirm the bug using 0.3.4.

i think this bug is resolved in the pull request: https://github.com/oncletom/grunt-crx/pull/47

Hello guys!

in 0.3.x: you have to use grunt.target.privateKey;
in 1.x: you have yo use grunt.target.options.privateKey

The last one did not work but #47 fixed it :-) The v1 branch is not yet the latest one in term of npm because of a critical bug (files are not excluded and it can be a severe security breach).
npm install --save grunt-crx // installs<EMAIL_ADDRESS>npm install --save grunt-crx@beta // installs<EMAIL_ADDRESS>


feat(common): Add a method to merge swc_common::Globals

Description:
This is required for turbopack.

Blocked by https://github.com/swc-project/swc/issues/9346

Closing as this was a wrong approach


[xstate-wallet] Factory reset does not work in production

#2160 sadly did not fix this :-(
If we fix this, we should add a link in the web3torrent FAQ. It's a useful feature for anyone with an indexedDb from the ropsten days.

Fixed in #2177


pulley: Move fp/lr out of XReg set

This commit moves the fp and lr registers out of the XReg register set and into the MachineState per-VM. These are automatically modified and read with push_frame and pop_frame. Dedicated xmov_{fp,lr} instructions were added for use in Wasmtime's trampolines which directly read these registers.
cc #9747

I'd like to get there with sp as well too but that'll require more special care since it's used in memory-related instructions as a base for stack loads/stores.


Added Cabal flags for benchmark suite

There is one flag for each effect library. Those flag control whether
that benchmark is included or not.

Why do you want such granularity? Wouldn't one flag for all 3 libraries be enough?

I used those flags to compare effectful to X one by one. But I guess one flag is sufficient.
BTW: Should we run the other benchmarks by default or not?

BTW: Should we run the other benchmarks by default or not?

Yes.
Please don't gate mtl behind a flag, it's unnecessary as it's a GHC boot dependency.
Actually, what is the advantage of having this flag? It's not like the other effect libraries pull in tons of dependencies, they're pretty lightweight.

The primary motivation behind this flag is the following: When working on effectful I'd like to spot performance regression. The other benchmarks are not interesting (unless one is working on the benchmark suite itself); They just add some noise to the benchmark outputs and lead to longer development cycles. I don't care so much about the dependencies.
That's why I gated mtl as well.

When working on effectful I'd like to spot performance regression

Fair enough :+1:


[SPARK-20377][SS] Fix JavaStructuredSessionization example

What changes were proposed in this pull request?
Extra accessors in java bean class causes incorrect encoder generation, which corrupted the state when using timeouts.
How was this patch tested?
manually ran the example

Test build #75919 has started for PR 17676 at commit 797f0ec.

LGTM pending tests.

Test build #75919 has finished for PR 17676 at commit 797f0ec.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Merged build finished. Test PASSed.

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75919/
Test PASSed.


DOC: rm links to python documentation

@QB3 let's just wait until CI builds the doc, it should be lighter colorwise now
at the moment all floats, lists, etc are in orange and point to not very useful python doc IMO:

Codecov Report

Merging #18 (f455aad) into master (05df374) will decrease coverage by 1.82%.
The diff coverage is 32.55%.

@@            Coverage Diff             @@
##           master      #18      +/-   ##
==========================================
- Coverage   60.93%   59.11%   -1.83%
==========================================
  Files          11       11
  Lines         919      944      +25
  Branches      198      208      +10
==========================================
- Hits          560      558       -2
- Misses        302      322      +20
- Partials       57       64       +7

Impacted Files
Coverage Δ

andersoncd/lasso.py
54.13% <30.76%> (-4.72%)
:arrow_down:

andersoncd/logreg.py
53.98% <31.25%> (-2.70%)
:arrow_down:

andersoncd/tests/test_enet.py
100.00% <100.00%> (ø)

andersoncd/group.py
75.00% <0.00%> (+0.80%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 557dd13...f455aad. Read the comment docs.


[BUG] "Face recognition failed: Invalid input" Error: Face recognition failed: Invalid input

Description:  "Face recognition failed: Invalid input" Error: Face recognition failed: Invalid input.
Steps to reproduce:

Open https://goodqa.netlify.app/
Go to the Face verification page
Click on the "Ok, verify me" button
Click on the "Got it" button
Scan a face
Pay attention to the Error in the console

Expected result:
The face verification is completed without any errors after scanning the face
Actual result: "Error: Face recognition failed: Invalid input" is displayed in the console after scanning the face
The user is new: no
Wallet address: 0x280e7fCABa19c2Af9423beD404C32f0f4bA63542
Environment: QA 1.18.0-0
Devices list: Desktop // Windows 10 // Chrome v.87.0.4280.88
Additional info:
email<EMAIL_ADDRESS>Password: Qwerty_11111
Attachment:

pushed hotfix, FV now working

pushed hotfix, FV now working

@sirpy @serdiukov-o-nordwhale The issue is not reproduced. The face verification is completed without errors.
Checked on the QA 1.18.0-0
Devices list: Desktop // Windows 10 // Chrome v.87.0.4280.88
Video: https://www.dropbox.com/s/s78c3sqvx9qnutg/The face verification is working.mp4?dl=0

@sirpy @serdiukov-o-nordwhale The issue is not reproduced. The face verification is completed without errors.
Checked on the QA 1.18.0-0
Devices list: Desktop // Windows 10 // Chrome v.87.0.4280.88
Video: https://www.dropbox.com/s/s78c3sqvx9qnutg/The face verification is working.mp4?dl=0


Ability to purchase with Apple|Google|PayPal

Description
We need to add the ability to purchase product(s) with Apple Pay.
In Shopify storefronts with Liquid, there are two use cases for the Apple Pay button:

On the product page

When clicked, it opens the Apple Pay flow for purchasing just the product from the product page

On the cart page

When clicked, it open the Apple Pay flow for purchasing the entire cart

Requirements

[ ] The button should only be visible when the merchant has Apple Pay enabled and the buyer is using a supported device for Apple Pay
[ ] When clicked, the Apple Pay checkout flow should be initiated

[ ] On the product page: for purchasing just that product
[ ] On the cart page: for purchasing the entire cart

[ ] The button should be rendered by the DynamicCheckoutButton component when appropriate

Notes

The DynamicCheckoutButton component has a really rough first pass on displaying the ApplePay button (see code here. We'll likely want to extract this code into its own component ApplePayButton and iterate on it from there.

Hi guys! Is there any update here? Is there any way to add apple pay into hydrogen?

@frehner is there any ETA on this or some documentation on what payment options are available in hydrogen checkout?

@frehner is there any ETA on this or some documentation on what payment options are available in hydrogen checkout?

Any update on this?

Any update on this?

Any update? Is the team still blocked via the Storefront API?

Any news guys?

It sounds like apple pay support is in active development and should release by the end of this year. Hopefully it will be available before
Checkout APIs have been deprecated. https://github.com/Shopify/storefront-api-feedback/discussions/225#discussioncomment-10226249


Corrected freeCodeCamp.org description under Youtube channels

Changes done,

Corrected freecodecamp.org description under Youtube channels category
changed ans to and in the description

Fix #13
Kindly Review.

Please if you have any more open source projects you could recommend or any advice, I'm new to open source

Please if you have any more open source projects you could recommend or any advice, I'm new to open source


add university virginias

@Amirnajafi This domain is blacklisted because the college allows to register an email address there even if you are not a student of the college. If you are the student of this college, please apply with official document ("OFFICIAL DOCUMENT" tab at https://www.jetbrains.com/shop/eform/students).


libva: populate bin output

The full build was not populating the bin output correctly because of
the use of make DESTDIR=$(out).
/cc @vcunat

Oh, I'm confident I had fixed this in a less hacky way, but it seems I've lost the commit somewhere. I'll look again.

No, actually I confused it with libvdpau bd2ca1e539.

I investigated changing the --with-drivers-path configure option, but unfortunately that doesn't just set the installation path, it also changes the default runtime search path.

I'll test a solution analogical to what I did with libvdpau.

I changed this on staging now: 8ea5563011e. (There is a mass rebuild waiting anyway.)


In C++, when building using cmake, got fatal error: absl/synchronization/mutex.h: No such file or directory

What version of gRPC and what language are you using?
grpc v1.37.0
C++
cmake version: 3.20.1
What operating system and version?
Inside Docker container (using GCC image pulled from https://hub.docker.com/_/gcc)
Linux version 5.8.8-1.el7.elrepo.x86_64 (mockbuild@Build64R7) (gcc (GCC) 9.3.1 20200408 (Red Hat 9.3.1-2), GNU ld version 2.32-16.el7
What runtime / compiler are you using (e.g. python version or version of gcc)
GCC version: gcc (GCC) 10.3.0
Issue description
In C++, When building using cmake, got fatal error: absl/synchronization/mutex.h: No such file or directory
Steps to reproduce the issue
Follow the steps as shown in https://grpc.io/docs/languages/cpp/quickstart/
In the below step:-

Error:

Solution:
I copied the absl folder from grpc/third_party/abseil-cpp/absl and pasted it into /usr/local/include/ as shown below:
cp -r /grpc/third_party/abseil-cpp/absl /usr/local/include/
Later, it worked fine:

Please fix this bug (So that we need not manually copy-paste the absl folder)

I also saw this when attempting to update the grpc package for Void Linux; we have a sysdig dependant that fails to build against the new version because the abseil headers are a hard dependency of grpcpp/impl/codegen/sync.h but are not installed alongside the grpc headers.

@ahedberg It looks like gRPC repo doesn't have submodules that it requires to build. Can you try to run git submodule update on grpc directory? If this doesn't solve your answer, can you share exact commands you run when building it?

I'm also having this issue. I just updated a forked repository to the latest commit, and this popped up.
I can reproduce on a blank install of Debian by cloning this repo, then running
cd grpc git submodule update --init mkdir -p cmake/build cd cmake/build cmake ../.. cmake ../.. -DgRPC_INSTALL=ON                \               -DCMAKE_BUILD_TYPE=Release       \               -DgRPC_ABSL_PROVIDER=package     \               -DgRPC_CARES_PROVIDER=package    \               -DgRPC_PROTOBUF_PROVIDER=package \               -DgRPC_RE2_PROVIDER=package      \               -DgRPC_SSL_PROVIDER=package      \               -DgRPC_ZLIB_PROVIDER=package make make install

Yes, this is not an issue with the gRPC build process, but the fact that a public gRPC header depends on an abseil header that is not installed. The Void build system (xbps-src) does not handle git submodules in this template, but instead downloads a tarball of the specific abseil commit referenced by the gRPC release and replaces the third_party/abseil-cpp subdirectory with the contents of the tarball. For other third-party libraries, we prefer the system version. (Void does not attempt to provide a system package for abseil, mostly because it is only used by gRPC and would need its version pegged to whatever gRPC requires.)
The Void build process is described in the template at https://github.com/void-linux/void-packages/blob/master/srcpkgs/grpc/template. The only non-standard change to the build process is to disable BUILD_SHARED_LIBS because we prefer static linking for this vendored library.

@ahedberg Oh I see. As a reference, gRPC uses the LTS version of Abseil so it might be reasonable to install it because it's carefully written not to interfere with other versions of Abseil.
@Puneethgr Can you share exact commands you run when building it for the reproduction?

@veblush You might want to double-check who you're tagging; I (ahedberg) and ahesford are not the same person, and I have no context for this issue. Thanks!

@ahedberg Oops my bad. Sorry about that.

@veblush
I used GCC docker image as base image and installed GRPC as per the documentation (https://grpc.io/docs/languages/cpp/quickstart/)
docker pull gcc
docker run -itd --name gcccpp gcc
docker exec -it gcccpp /bin/bash

export MY_INSTALL_DIR=$HOME/.local
mkdir -p $MY_INSTALL_DIR
export PATH="$PATH:$MY_INSTALL_DIR/bin"

wget -q -O cmake-linux.sh https://github.com/Kitware/CMake/releases/download/v3.19.6/cmake-3.19.6-Linux-x86_64.sh
sh cmake-linux.sh -- --skip-license --prefix=$MY_INSTALL_DIR
rm cmake-linux.sh

apt-get update
apt install -y build-essential autoconf libtool pkg-config

git clone --recurse-submodules -b v1.37.0 https://github.com/grpc/grpc

cd grpc
mkdir -p cmake/build
pushd cmake/build
cmake -DgRPC_INSTALL=ON \
      -DgRPC_BUILD_TESTS=OFF \
      -DCMAKE_INSTALL_PREFIX=$MY_INSTALL_DIR \
      ../..
make
make install
popd

cd examples/cpp/helloworld

mkdir -p cmake/build
pushd cmake/build
cmake -DCMAKE_PREFIX_PATH=$MY_INSTALL_DIR ../..
make

@Puneethgr Thanks for the commands to reproduce it. I saw the same error and it turns out that the doc needs to update. In the meantime, you can fix it by installing abseil in advance.
Before building example on grpc directory,
mkdir -p "third_party/abseil-cpp/cmake/build"
pushd "third_party/abseil-cpp/cmake/build"
cmake -DCMAKE_INSTALL_PREFIX=$MY_INSTALL_DIR -DCMAKE_POSITION_INDEPENDENT_CODE=TRUE ../..
make -j4 install
popd

Does this mean that the hard dependency on abseil headers in gRPC is not going away?

@ahesfold Yes it will keep the abseil dependency. gRPC C++ will use more Abseil features in future.

Hi @veblush when I try to install abseil using the commands you put here, I got the following long error.
error.log do you know what the problem could be here?

this happen again on v1.39 ref https://grpc.io/docs/languages/cpp/quickstart/#install-grpc

I'm getting this error too. Maybe we can consider re-opening this issue, it took me ages to find it 😩

Looks like it might be related to this https://github.com/abseil/abseil-cpp/issues/703 ?


Collect recorded messages on all managed entities even not dirty ones

Coverage remained the same at 100.0% when pulling a00a243624c7b6aff26e4522acdadae7988317df on GeoffroyR:master into 3e93d5d7bbf2f3a4365dd5705cadfae04c9f1e76 on SimpleBus:master.

Coverage remained the same at 100.0% when pulling a00a243624c7b6aff26e4522acdadae7988317df on GeoffroyR:master into 3e93d5d7bbf2f3a4365dd5705cadfae04c9f1e76 on SimpleBus:master.

It seems that the identity map in the postFlush event in v2.2 and 2.3 of doctrine was missing some entities.
I can add old events back in but then we would have duplicates checks for the newer versions.

It seems that the identity map in v2.2 and 2.3 of doctrine was missing the not dirty entities.

Could you explain this a bit more i'm not sure why the tests are failing know.

I added a new test to cover the new feature to collect events of "not dirty" entities.
But this test is failing in odler versions 2.2 & 2.3.
After checking out the tests in these version, it's because Doctrine only triggers the PreFlush event when nothing needs to be committed to the db. In later versions this has been fixed and the OnFlush and PostFlush are triggered in any case.

Coverage remained the same at 100.0% when pulling 70f098a64177f332f4958d0d87a90682e6d2203f on GeoffroyR:master into 3e93d5d7bbf2f3a4365dd5705cadfae04c9f1e76 on SimpleBus:master.

Coverage remained the same at 100.0% when pulling 70f098a64177f332f4958d0d87a90682e6d2203f on GeoffroyR:master into 3e93d5d7bbf2f3a4365dd5705cadfae04c9f1e76 on SimpleBus:master.

@GeoffroyR So if i'm correct this is ready to be merged. I only think we should create a major release for this to not break old implementations. What do you think?

why not listening "postFlush" ?

@cmodijk should it be considered a major release? It might break existing implementations, but only because they didn't work in the first place. I think this is more a bugfix than a major, but heh, that's only my opinion :)
Anyway, I'm looking forward seeing this merged, as I'm currently facing this exact same issue.
Thanks for this!

Sorry but this still needs some more testing.

I had an issue with some entities not being in the UOW in the preflush but only in the postflush so we should also subscribe to the postflush event and collect the event form the UOW entities.
I think collection should also be checked and see if we collect the events of these.

I have no time right now but will try to find some time next month to add a series of tests.
@docteurklein "postFlush" os not called if nothing is committed in previous versions of Doctrine 2.2 & 2.3

I have another issue related to this PR:
it will trigger Lazy Loading to check if an Entity contains recorded messages - or require all Entities in an object graph to be hydrated beforehand.
Scenario:
Entity1 (E1) and Entity2 (E2) are both instances of ContainsRecordedMessages - E1 has a ManyToOne relation to E2.
I fetch the E1 from the repository (E2 is not hydrated for the current task), change something on the E1 and record an Event. E2 is still just a Doctrine Proxy object and can per se not contain any messages.
The check at collectEventsFromEntity will no iterate over the managed entities, see E2 and try to fetch the messages from the Entity. This will trigger Doctrine Lazy Loading - which is not required since a uninitialised proxy object will not be able to contain any messages.
Suggestion:

check if the object is a proxy or not
verify that it is initialised if it is a proxy object

private function collectEventsFromEntity($entity)
{
   if ($entity instanceof ContainsRecordedMessages
        && ( !$entity instanceof Proxy
             || ($entity instanceof Proxy && $entity->__isInitialized__)
       )
   ) {
      foreach ($entity->recordedMessages() as $event) {
          $this->collectedEvents[] = $event;
      }
      $entity->eraseMessages();
   }
}

@cmodijk should it be considered a major release? It might break existing implementations, but only because they didn't work in the first place. I think this is more a bugfix than a major, but heh, that's only my opinion :)

@docteurklein You are right but that also means that if someone already implemented a workaround this (like i did myself) is going to be surprised if it is fixed without  a major bump i think. And i'm working on the next major versions of al packages to drop support for php 5.4 and 5.5 and I hope i can use this in that.

I had an issue with some entities not being in the UOW in the preflush but only in the postflush so we should also subscribe to the postflush event and collect the event form the UOW entities.

Do you know why these entities where not in the preflush ?

I think collections should also be checked and see if we collect the events of these correctly.

I'm not sure but about this do you have a test case for this?

check if the object is a proxy or not verify that it is initialised if it is a proxy object

@patrickjahns tnx for the suggestion.
@GeoffroyR Are you able to finish this or should i try to make the final changes in the coming weeks?

@cmodijk

Do you know why these entities where not in the preflush ?
I checked back why I had to add the PostFlush and it is related to the lifecycle events. I recorderded some events based on lifecycle events and these were not collected on preFlush.

About the collections, I was a bit concerned about cascade events but I did some tests and could not find any caveat.

Hey everyone, great that this issue receives attention! I do think it requires a major version bump, since otherwise the behavior will be too subtle for people simply upgrading. It's something that needs to be documented well too.
With regard to collections: I assumed that entities in collections are themselves registered in the identity map by their ID.
Lazy loading is an interesting case, I don't have anything to add really.

I agree with @matthiasnoback regarding collections: I don't think you have anything to check manually.

I checked back why I had to add the PostFlush and it is related to the lifecycle events. I recorderded some events based on lifecycle events and these were not collected on preFlush.

Oke, but I think the pull request is fine then right know right? I should be able to merge this now?

Sorry, wrong button.

I might be wrong (I didn't make the test but I looket at a generated doctrine proxy) and I don't think checking on initialized proxy has any effect because proxies only initialize if you call methods that touch persisted properties.
Can you confirm this behavior?
Anyway, I would personnally be OK with merging this as it provides a correct and useful behavior.

I might be wrong (I didn't make the test but I looket at a generated doctrine proxy) and I don't think checking on initialized proxy has any effect because proxies only initialize if you call methods that touch persisted properties.

From my testing, any method invocation on a unitiliazed proxy object will trigger initialization. (Anything otherwise would cause problems / inconsistencies)

@docteurklein When you retrieve a Entity with a reference to a other Entity but only fetch the date of the first one the second one still gets a instance with a proxy implementation. When we then in our listener call the recordedMessages() on the method these proxy objects they get loaded but we did not do any work on them so that is unnecessary and could resolve into other problems.

ha ok thanks for the explanations!

@docteurklein No problem :-)

Ping @GeoffroyR i think this can get merged right?

I tested the basic concept today i'm merging this now and releasing in a bit later today.


need change in SimulationConfiguration.java

Hi
I think we should replace CBR_FAILURE_BLOCK_SIZE_DISTRIBUTION_FOR_CONTROL_NODE values with CBR_FAILURE_BLOCK_SIZE_DISTRIBUTION_FOR_CHURN_NODE values.
thanks

Hi, zsharifian.
Thank you for opening this issue.
I fixed this bug.


Fix to Cosmos DB Quickstart templates url

When clicking clickstart link it would go to the quickstart page but not find Cosmos DB resources. Have updated the url and variables to the correct naming/ casing and left in the pagenumber and sorting options that was previously there.

@retracement : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Merging per email from Hassan Rasheed.


The storage class was not correctly carried over from PVCConfig structs into derived PVC objects.

Description
Fixes #411
Adds copying of storageclass from PVCConfig into derived PVC objects.
Signed-off-by: Sönke Liebau<EMAIL_ADDRESS>
Review Checklist

[ ] Code contains useful comments
[ ] (Integration-)Test cases added (or not applicable)
[ ] Documentation added (or not applicable)
[ ] Changelog updated (or not applicable)
[ ] Cargo.toml only contains references to git tags (not specific commits or branches)

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

bors r+


Couple of copy contructor and/or assignment operator missing.

The rule of three:
https://en.wikipedia.org/wiki/Rule_of_three_(C%2B%2B_programming)

Thanks for you propose. Because the RocksDB project is forked from facebook/rocksdb, so I think you'd better send pull request to facebook/rocksdb firstly.


Add Home View & Skeleton Views

This PR contains the following changes:

Add assets for home view.
Add home view and related components.
Update folder structure to follows subdirectories.

Screenshots / Video Recording

@tachyons please check !!

Can you add screen shot to PR ?

Can you add screen shot to PR ?

Yes Sure!

Can you add screen shot to PR ?

Yes Sure!

@tachyons are any more changes required here ?

@nitin10s Can you please review ux aspects

Yes, I was planning to, there needs a lot of refining to be done. I think we should set up a call for it.

@tachyons please review this..


chore: remove unused setting

Following this comment
This setting seems to not be used anymore, introduced here, removed here

End to end tests: :hourglass_flowing_sand: STARTING


Error in downloading data with a search Query

I ran the command:
python ENCODE_downloader.py "https://www.encodeproject.org/search/?type=Experiment&assay_title=ChIP-seq&target.investigated_as=transcription+factor&files.file_type=bed+narrowPeak&replicates.library.biosample.donor.organism.scientific_name=Homo+sapiens&biosample_type=immortalized+cell+line&assembly=GRCh38&biosample_term_name=K562&assay_title=ChIP-seq" --dir ./ --file-types narrowPeak --assemblies GRCh38 --assembly-map Homo+sapiens:GRCh38

and got the following error
Traceback (most recent call last):
  File "ENCODE_downloader.py", line 414, in <module>
    main()
  File "ENCODE_downloader.py", line 381, in main
    max_num_files = max( [len(all_file_metadata[acc_id]) for acc_id in all_file_metadata] )
ValueError: max() arg is an empty sequence

I got messages on the screen seeming like downloads were happening, but the download folder is empty

Please try with --file-types bed:narrowPeak.

Thanks, this worked


Add Dockerfile and supporting script

This adds a Dockerfile to build a docker image for running the web interface and supporting scripts.
All dynamic data is saved in the data directory, and symlinks are created from their normal location to this directory, so that no existing scripts need to be changed. At runtime, if a user chooses to mount a host directory as the data directory, a user is created with the same user id and group id of the owner of the directory; this ensures that all files are written with the proper owner.
If no command is specified at run time, the server starts on port 8080. If a command is specified, it will be run after the user is created, again to ensure the correct file ownership. In either case, both the secret key and the database are created if they don't yet exist in the data directory.

@bskaggs I run into an issue when I use your fork:
$ git clone https://github.com/bskaggs/arxiv-sanity-preserver
$ cd arxiv-sanity-preserver/
$ docker image build -t arxiv-sanity .
$ docker container run arxiv-sanity
Changing to root
/usr/local/lib/python2.7/site-packages/flask_limiter/extension.py:113: UserWarning: Use of the default `get_ipaddr` function is discouraged. Please refer to https://flask-limiter.readthedocs.org/#rate-limit-domain for the recommended configuration
  " for the recommended configuration", UserWarning
/usr/local/lib/python2.7/site-packages/flask_limiter/extension.py:640: UserWarning: global_limits was a badly name configuration since it is actually a default limit and not a  globally shared limit. Use default_limits if you want to provide a default or use application_limits  if you intend to really have a global shared limit
  " if you intend to really have a global shared limit", UserWarning
Namespace(num_results=200, port=8080, prod=True)
loading db.p...
Traceback (most recent call last):
  File "serve.py", line 380, in <module>
    db = pickle.load(open('db.p', 'rb'))
IOError: [Errno 2] No such file or directory: 'db.p'

Can you provide advice on getting your fork working within Docker (version 18.06.1-ce, build e68fc7a)?

I'm sorry, I haven't touched this in years. I think you have to run the processing pipeline to populate some files that are missing: https://github.com/karpathy/arxiv-sanity-preserver/blob/1682975ccca50f1a0582c806aacd07266f689061/README.md#processing-pipeline


docs: Add contributing guide for easier access

The current guide is a bit hidden and we need to rely on links. Users will find it more easily in the source code, which is where I'd search for it anyway.
We are currently using the dagger/.github repo to share the guidelines amongst the organization, but there's also an argument for moving the guide here and reference this one in other places instead. Just not sure about the automatic "Contributing" links that GitHub adds automatically in some places.
Signed-off-by: Helder Correia
/cc @gerhard

By the way, if we find this dagger/dagger & dagger/.github separation problematic, then we should merge those repositories.
The only reason why we added dagger/.github is to not duplicate content between dagger/dagger & dagger/examples, but since the examples repository got folded into dagger/dagger & archived, maybe this is less of a concern.

Originally posted by @gerhard in https://github.com/dagger/dagger/issues/2017#issuecomment-1087454027

Contribution.md has already a link in the README.md so I'm not sure it is relevant.

Indeed it's there, but some people may look for the CONTRIBUTING.md file directly (I would, the same way I look for CHANGELOG.md files when updating python packages). It's more visible.
Additionally, github automatically adjusts based on the existence of this file by showing links like this:

On the other hand, these links alone aren't visible enough so what I'd prefer is to move the guide to this repo (instead of just a link), and do this link in other repositories. That's what I mean in https://github.com/dagger/dagger/pull/2023#issuecomment-1087566465.

Agreed, should we merge it @helderco @gerhard ?

I'd rather move from .github to here, and update this PR, if it's ok with @gerhard. Otherwise let's merge this 🙂

Makes sense to me.

Sorry, I messed up the branch. Follow up in:

https://github.com/dagger/dagger/pull/2134


core(private-modules): SSH_AUTH_SOCK env loading seems to break with shell expansion characters

Bug found: https://discord.com/channels/707636530424053791/1280527928861655112/1280958016144932885
I believe it is linked to the lexical relative path function: https://github.com/dagger/dagger/blob/main/engine/client/pathutil.go#L9-L12

Looking at the thread, it looks like we need to expand ~ in the SSH_AUTH_SOCK. However it most cases, it's expected to be an absolute path (at least ssh-agent does it).


Update Melos and CD/CI

Description
Addressing a few issues and add more jobs in our CD/CI
Related Issues
fixes #488
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

[x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
[ ] My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
[x] All existing and new tests are passing.
[ ] I updated/added relevant documentation (doc comments with ///).
[x] The analyzer (flutter analyze) does not report any problems on my PR.
[x] I read and followed the Flutter Style Guide.
[x] I am willing to follow-up on review comments in a timely manner.

Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?

[ ] Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
[x] No, this is not a breaking change.

FYI, you can mark a PR as a draft so it can't be merged yet 😉

FYI, you can mark a PR as a draft so it can't be merged yet 😉

haha, I know, but it was ready to merge actually.

Will this also update the CI street to flutter 2.5(.2)? Right now #442 is failing because i've already migrated some tests to 2.5.2.

Yes, it will
however, I have not updated tests in main branch yet.

@Elias8 let me know if this sounds good to you.
There are a few things we need to fix later
1- fixing integration tests
2- fixing build on Linux and windows
3- add running tests on all three platforms.

There are a few things we need to fix later
1- fixing integration tests
2- fixing build on Linux and windows
3- add running tests on all three platforms.

Sounds good @mhadaily

This PR added google-java-format formatting, however this is not default in android studio. Maybe it's a good idea to add a section to the readme explaining on how to format files correctly since it's not really straight forward.


get tags fails with reg server but succeeds with reg tags

I am trying to use reg server with my private registry. The images are listed on the UI but when I click on any of the images it gives me the following error in the console:
INFO[0000] executing the template repositories
INFO[0000] adding clair handlers...
INFO[0000] Starting server on port "8080"
INFO[0013] fetching tags                                 URL=/repo/busybox/tags func=tags method=GET
ERRO[0016] getting tags for busybox failed: getting v1 manifest for busybox:latest failed: missing signature key  URL=/repo/busybox/tags func=tags method=GET
When I do reg tags for the same image, it returns all the tags.
Am I missing anything in the configuration??
Thanks,

same problem here

In my environment I was able to trace this down to OCI manifests. The actual pulling of tags to gather information for the tags template succeeds, but there is also a created date on that page.
To get the created date, the code then loops through the tags to pull the manifest. This code assumes a docker manifest v1. For OCI images this will fail for three reasons:

The backend registry needs an accept header for OCI images
The format and shape of the manifest is different for OCI
There is no create date anywhere in the resultant JSON. This is likely available at another backend endpoint, but I haven't investigated that yet.

There may be multiple causes for this issue, but that's what I'm seeing in my setup.

I created a PR #202 that addresses the cause for this issue in my scenario.


Spyder 2.3.6 says PySide 1.2.0+ is required, but I have PySide 1.2.2 installed

Description
What steps will reproduce the problem?

Use pip to install Spyder 2.3.6
Start up Spyder from the command line

What is the expected output? What do you see instead?
I expect Spyder to launch, but instead I get the following error:
"Please check Spyder installation requirements: PyQt4 4.6+ (or PySide 1.2.0+) is required."
Please provide any additional information below
As you can see below, I have PySide 1.2.2 installed, so this error doesn't make a lot of sense.  Also, once I downgraded back to Spyder <IP_ADDRESS> using pip, Spyder launches without any problems.  In case it matters, I am using Enthought Canopy for my python installation.  Finally, the exact same issue occurs on my home computer (also a Mac), and it is also resolved by downgrading to Spyder <IP_ADDRESS>.
Version and main components

Spyder Version: 2.3.6
Python Version: 2.7.6
Qt Versions:  4.8.6, PySide 1.2.2 on Darwin

Optional dependencies
pyflakes >=0.5.0:  0.9.2 (OK)
pep8 >=0.6      :  1.6.2 (OK)
IPython >=1.0   :  3.2.1 (OK)
zmq >=2.1.11    :  14.7.0 (OK)
pygments >=1.6  :  2.0.2 (OK)
pandas >=0.13.1 :  0.16.2 (OK)
sphinx >=0.6.6  :  1.3.1 (OK)
psutil >=0.3    :  2.2.1 (OK)
rope >=0.9.2    :  0.9.4 (OK)
jedi >=0.8.1    :  None (NOK)
matplotlib >=1.0:  1.4.2 (OK)
sympy >=0.7.3   :  0.7.6 (OK)
pylint >=0.25   :  0.25.1 (OK)

This was already reported in issue #2649 and fixed in pull request #2650 (to be part of Spyder 2.3.7).

Anaconda Launcher reports I have ver 2.3.7 installed and when I start it I am seeing an error:
Please check Spyder installation requirements: PyQt4 4.6+ (or PySide 1.2.0+) is required.
I am on Windows 7.
Starting Spyder from the Start menu makes it run, but it is ver. 2.3.6
Note: I attempted to conda update -all and was getting linking errors I ignored.

This issue is not fixed at least not on the Windows Spyder release in the Anaconda package.
I got this problem after updating conda (conda update) to the latest version today on a Win 7 machine.  Everything has worked OK up until the update this morning.
I already had PyQt 4.11.4 installed so it should have worked, right.
But it did not.
The solution was to also install pyside which is not by default in the Anaconda release
conda install pyside
After the pyside installation everything works again.
Have fun,
/Per


Feature: allow user to select/deselect repos when org is selected

@JamesKunstle I think so but something on very low priority for now


NOISSUE - Update CoAP docs

Signed-off-by: Dusan Borovcanin<EMAIL_ADDRESS>What does this do?
This PR adds CoAP docs to getting-started section.

Codecov Report

Merging #468 into master will increase coverage by 0.25%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #468      +/-   ##
==========================================
+ Coverage   87.26%   87.52%   +0.25%
==========================================
  Files          54       54
  Lines        2372     2372
==========================================
+ Hits         2070     2076       +6
+ Misses        199      194       -5
+ Partials      103      102       -1

Impacted Files
Coverage Δ

ws/api/transport.go
87.05% <0%> (+7.05%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f01c0a...df7801b. Read the comment docs.


Race Results json not public

The route /results/download should be public, but instead the requestor is redirected to the login page, which makes it impossible to use simresults.
I am using the Docker Image with traefik as loadbalancer with forced https-redirect, if that's important.

The Championship Signup Page is also not public:
/championship/8eaa10ac-2ca7-45e4-aaa8-cd6573148c92/sign-up
is that intended or a configuration issue on my server?

This is probably due to your server not having open read access without an account. You can configure this on the Server -> Accounts page.

Thanks

aaah found it, thanks!
I just startet to use it, so may be not my last issue, but I already find it's agreat piece of software and will definitely donate a bunch of beers when I basically got all working :-)


sys: move WAIT_FOR into time_units.h

WAIT_FOR uses k_us_to_cyc_ceil32, which is defined in time_units.h, so right now time_unitss.h and util.h include each others, potentially causing issues due to inconsistent include ordering.
Fix this by moving WAIT_FOR into time_units.h and dropping the time_units.h include from util.h.

I see no problem with the code change but I tested this commit and it does NOT fix #62464 so please remove "Fixes #62464" from the commit message. You can still mention #62464 in the commit message to provide background information of course! Just don't say it fixes it because it makes no difference one way or the other.

Cool, dropped the reference.

Hey, lost momentum on this and it looks like it's not causing problems now and there's no obvious solution, I'll close this down, we can reopen if we have something more concrete to justifying putting more time into it.


Handle deprecation of apiextensions.k8s.io/v1beta1 in K8s 1.19

Describe the bug
apiextensions.k8s.io/v1beta1 will be deprecated in favor of apiextensions.k8s.io/v1 in K8s 1.19: https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG/CHANGELOG-1.19.md#deprecation.
Its removal of beta level will be in 1.22.
apiextensions.k8s.io/v1 API is available in v1.16.
I'm not proposing simply switching to v1 in latest deployment yaml as it won't work for clusters that are using prior to K8s v1.16.
Opening this to track the issue and for discussion of appropriate solutions.
CRDs to update:
antreacontrollerinfos

[ ]   version #1009
[ ]   validation

antreaagentinfos

[ ]   version #1009
[ ]   validation

traceflows

[ ]   version #1009
[ ]   validation #1009

clusternetworkpolicies

[ ]   version #1009
[ ]   validation #1009

networkpolicies

[ ]   version #1009
[ ]   validation #1009

externalentities

[ ]   version #1009
[ ]   validation #1009

tiers

[ ]   version #1009
[ ]   validation #1009

CRDs to update:

[ ] antreacontrollerinfos
[ ] antreaagentinfos
[ ] traceflows
[ ] clusternetworkpolicies
[ ] networkpolicies
[ ] externalentities

We no longer use apiextensions.k8s.io/v1beta1


How does gen work?

Hi
Do you mind explaining how tch-rs/gen work? and when does it kick in?
Why not binding against c-api in $LIBTORCH/include/torch/csrc/api/include/torch/ directly?
Thanks

tch-rs/gen/gen.ml generates:

The C wrapper around the libtorch C++ api, libtch/torch_api_generated.{cpp.h,.h}.
The rust wrapper using this C api, src/tensor/c_wrapper_generated.rs.
It uses the Declarations.yaml file generated when compiling libtorch from source.

The generated files are also stored in git so there is no need to run this code generation in the normal build process.
It's only useful to execute it when updating to a new major libtorch version but this is rather infrequent (there was no need to rerun it between 1.0.0 and 1.0.1).
The code generation is in ocaml as it's adapted from the ocaml-torch bindings. To run it you will need a working ocaml install including the dune, base, stdio, and yaml packages, the Declarations.yaml file and you could run dune exec gen/gen.exe.
Binding to the library directly would be a bit tricky: it's in C++ so bindgen does not work very well, writing manual wrappers is a bit of a pain as there are more than a thousand functions to expose.

Very interesting! thanks for the clarifications. Absolutely makes sense to reuse what you've made before.
Would it be able to support more than one major libtorch versions (in the future)?

With the current release cycle of PyTorch, I hope for that not to be necessary.
However if this becomes a concern, we could certainly consider generating the code in the build process at some point.


Turn Postgres Json upgrade into a breaking change

Tool
Type

Prisma 1 Type
Json

Postgres Database Type
String

Introspected Prisma 2 Type
String

Upgrade tool suggests changing it to jsonb:
ALTER TABLE "p1$dev"."Company" ALTER COLUMN "meta" SET DATA TYPE JSONB USING "meta"::TEXT::JSONB;

Prisma 1 client fails at runtime when this SQL is used:
org.postgresql.util.PSQLException: ERROR: column "meta" is of type jsonb but expression is of type character varying

Solution:
Change type of the field in schema.prisma
model Company {
  id   String @default(cuid()) @id
-  meta string?
+  meta Json?
}

Thanks @divyenduz! To give background context, this is what we currently do.
Given Prisma 1 Datamodel
type User {
  id: ID! @id
  meta: Json
}

Before prisma.schema (introspected)
type User {
  id       String    @id
  meta String?
}

Upgrade SQL
ALTER TABLE "postgres-alias$dev"."User" ALTER COLUMN "meta" SET DATA TYPE JSONB USING "meta"::TEXT::JSONB;

After prisma.schema (introspected)
type User {
  id   String @id
  meta Json?
}

I'll probably just turn this operation into a breaking change for postgres.

While this is indeed a breaking change if the database type is changed to JSON (using the generated SQL statements from the Upgrade CLI), there's a non-breaking workaround for this problem that can be applied purely in the Prisma schema. I want to explain the workaround here for everyone who is facing the issue and rather wants to use the manual workaround.
Problem
** Prisma 1 Datamodel**
type User {
  id: ID! @id
  meta: Json
}

prisma.schema (introspected)
type User {
  id   String    @id
  meta String?
}

The known problem is that Prisma 1 represents Json types as TEXT in the database. Changing this TEXT column to JSON or JSONB is breaking the Prisma 1 client.
Workaround
While this can't be solved on the database-level, you can manually change the type of the field in the introspected Prisma 2 schema:
type User {
  id   String    @id
  meta Json?
}

The main drawback of this approach is that with each invocation of prisma introspect, your Prisma 2 schema will be reset to the previous state (turning the type of meta back to String) which requires a manual adjustment after each introspection run.


Fixing "Submit new resource" workflow

I renamed all instances of "gallery" or "external links gallery" to "resource gallery". Updating this to match!
Related to https://github.com/ProjectPythia/projectpythia.github.io/issues/244

I would love to get this merged before I present at the ESDS forum at 2 PM Mountain today. This is higher priority than the others IMO!


Probably found a fix for you.

in Creature_UE4/CreatureEditorAndPlugin/CreaturePlugin/Source/CreaturePlugin/Private/
You have this
// Possible regression bug in UE4.24, the line below no longer compiles. However the definition for FSlateDataPayload::ResourceManager does exist in the Master branch
//FSlateShaderResourceProxy* ResourceProxy =  FSlateDataPayload::ResourceManager->GetShaderResource(*MyBrush);
FSlateResourceHandle Handle = FSlateApplication::Get().GetRenderer()->GetResourceHandle(*MyBrush);
Well, I'm a stuborn bastard and here you go
FSlateBrush * MyBrush = render_brush;
FSlateResourceHandle Handle = FSlateApplication::Get().GetRenderer()->GetResourceHandle(MyBrush);
const FSlateShaderResourceProxy ResourceProxy = Handle.GetResourceProxy();
Dunno if that does what you intended, but I;m getting no compiler errors now.
(Also this definition no longer exists in master, atleast it didn't when I looked XD)

Well that's interesting... it ate two asterisks in
*MyBrush and FSlateShaderResourceProxy* Still getting new to that GitHub stuff.

Thanks, will take a look.
On 13 January 2020 12:52:26 AM SGT, Dorian<EMAIL_ADDRESS>wrote:

in
Creature_UE4/CreatureEditorAndPlugin/CreaturePlugin/Source/CreaturePlugin/Private/
You have this
// Possible regression bug in UE4.24, the line below no longer
compiles. However the definition for FSlateDataPayload::ResourceManager
does exist in the Master branch
//FSlateShaderResourceProxy* ResourceProxy =
FSlateDataPayload::ResourceManager->GetShaderResource(*MyBrush);
FSlateResourceHandle Handle =
FSlateApplication::Get().GetRenderer()->GetResourceHandle(*MyBrush);
Well, I'm a stuborn bastard and here you go
FSlateBrush * MyBrush = render_brush;
FSlateResourceHandle Handle =
FSlateApplication::Get().GetRenderer()->GetResourceHandle(MyBrush);
const FSlateShaderResourceProxy ResourceProxy =
Handle.GetResourceProxy();
Dunno if that does what you intended, but I;m getting no compiler
errors now.
(Also this definition no longer exists in master, atleast it didn't
when I looked XD)
--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/kestrelm/Creature_UE4/issues/27

--
Sent from my Android device with K-9 Mail. Please excuse my brevity.

Hello,
I just submitted an update/fix thanks to your hard work:
https://github.com/kestrelm/Creature_UE4/commit/b44e82e3f527c664f69d505947b7ced14fe8a9f0
Acknowledged you in the commit.
Cheers


fix: horizontal scrolling overflow

Issue: A component (In my use case a table with fixed th, td widths) does not overflow when the content of the storybook does not fit de viewport.
What I did
I added the property overflow: auto to the inner div of the centered add-on.
How to test
This should be tested by setting a viewport width smaller than the width of the component being rendered.
If your answer is yes to any of these, please make sure to include it in your PR.

this is a feature request :)

@shilman how to proceed from here? Is anything that can be done from my end?

Hi @casvil thanks for your contribution!!
Two requests:

attach a picture of before & after to the PR to make it easier to review, or better yet, add a story that demonstrates this behavior to the official-storybook
update the storyshots snapshots by running yarn test --core --update and committing the results?

Much appreciated 🙏

Sure!

@shilman failed tests after running yarn test --core --update. Can't update storyshots

Ah @casvil sorry for the slow reply. Try running yarn bootstrap --core first.

@shilman what else should be done in order to make TeamCity builds pass and not fail? thanks!


feat(mobilitybox): adds relevant routes mvt endpoint

:tada: This PR is included in version 3.1.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Creating custom characters for LCD or translate to standard

I am asking for instructions on how to create and where to save the definition of your own custom character for the LCD.
Or how to make Polish letters: "ą, ć, ó, ł, ż, etc." be displayed as "a, c, o, l, z"?
Now, where there is a letter I have a sign "?".
I'm using 20x4 Winstar WEH on i2c with driver HD44780

Good effort but the font system has evolved over time and the file you are editing does not directly get used any longer.
I'm assuming given that you are using the HD44780 driver with a 20x4 display that you are using the pages_lcd_20x4.py page file.  That page file uses three fonts (latin1_5x8_lcd.fnt, BigFont_10x16_fixed.fnt, and upperasciiwide_3x5_fixed.fnt).  We could add the polish characters to any of these fonts but the only one that is likely to matter is the latin1_5x8_lcd as this is the font used for all of the song metadata.
There are two files that make up a normal font in pydPiper.  These are the .fnt file and the .png file.  The .png file contains a bitmap that contains glyphs for every character contained within the font.  The .fnt file provides the metadata for each character so that pydPiper knows what part of the bitmap to use to extract the glyph for the character from the bitmap and the size of the character's glyph.  Each character in the *.fnt file is described using the following format.
char id=99 x=18 y=48 width=5 height=8 xoffset=0 yoffset=0 xadvance=5 page=0 chnl=0
char id is the unicode value in decimal of the character that is being added.  In this case unicode 99 is the 'c' character.
x, and y are the coordinates within the .png file where the character's glyph is located
width and height are the size of the glyph in pixels
The rest of the values can be ignored (for the purposes of this issue) though xadvance should equal width in most cases.
So to add a new character to the font, you need to add a glyph to the .png file and add a character to the .fnt file. Unfortunately, drawing characters that look acceptable in a 5x8 pixel grid is not that easy so if all you'd like to do is replace the correct orthography with a similar character that lacks the diacritics, you can copy the line for the character you want to leverage and just change the char id to the appropriate unicode value.  As example, if you want to replace the Ą with an A...
The 'A' character is added to the latin1_5x8_lcd.fnt file using the following line:
'char id=66 x=12 y=32 width=5 height=8 xoffset=0 yoffset=0 xadvance=5 page=0 chnl=0'
To use the 'A' as the 'Ą' add the following line to the latin1_5x8_lcd.fnt file.
'char id=260 x=12 y=32 width=5 height=8 xoffset=0 yoffset=0 xadvance=5 page=0 chnl=0'
Note: The unicode value for Ą is 0x0104.  However char id's are decimal values so the char id for Ą is 260.
Once you have added the characters that you want to the .fnt file, you also need to correct the chars count on the third line of the .fnt file.  The chars count value should equal the total number of char definitions contained within the file.
I've added a new font file named latin1_5x8_lcd_polish.fnt to the fonts directory.  This file uses the closest ascii character to replace all of the Polish orthography characters.  To give it a try pull the latest copy of the pydpiper from the repo and modify the FONTS definition for the small font in the pages file you are using.  E.g. where you see latin1_5x8_lcd.fnt, replace with latin1_5x8_lcd_polish.fnt.

dhrone... You are my Guru!
I have no words to thank you!

That's exactly what I expected.
Now I have instructions, so I have time to create my own characters.
Thank you again.
Best regards!

Full success! Thank you again for the instruction!

You work fast.  Congratulations.  You seem to have a talent for small resolution font editing.  Would you be willing to provide your updated font back to the repo?  It may be useful for other pydPiper users.
Could you also confirm that you are using the hd44780_i2c.py driver?  I've been meaning to refactor the display driver code to allow more display types and i2c backpacks to work.  I could probably give you a rough hack of the winstar_weg code pretty quickly while I work on a more elegant solution for all of the current display types.

Today, I made only a few letters. When I do all I will send.
Yes, I am using the hd44780_i2c.py driver for the WEH002004BL display (initialize problem after soft restart). The converter (very popular & low cost) is on the PCF8574 chip.

There is one issue that you may want to be aware of when using the hd44780 driver with custom characters. As you are aware, the hd44780 controller supports the creation of custom characters.  pydPiper leverages this feature to auto-create new characters as needed to render whatever screen is requested.  However, the hd44780 only supports a maximum of 8 custom characters at a time.  If you try to display a screen with more than 8 custom characters, the remaining custom characters will be displayed as a '?'.

only supports a maximum of 8 custom characters at a time. If you try to display a screen with more than 8 custom characters, the remaining custom characters will be displayed as a '?

That problem has just arisen. Look at the 4th line: video

If I can get the winstar_weg driver to support the PCF8574/I2C backpack, that limitation goes  away.

This is very good news. I will be waiting impatiently.

I've been working with the Luma.OLED project to move all of my driver code over to them.  We've got the ws0010 driver supported and there is a pcf8574 interface available.  I do not have a pcf8574 available to wire to a winstar display.  If you'd be interested trying.  Let me know and I'll send some instructions.

@dhrone , did you ever find a way to overcome the 8 character limitation on the hd44780_i2c displays that use the pcf8574 chip?
If so, would you mind pointing me (us) in the right direction?

There is no way to get beyond the 8 character limit on any of the hd44780 devices that I am aware of.  The pcf8574 interface is not relevant to that limitation.  It exists regardless of which interface style you are using.


Add Kubernetes unit tests

Add Kubernetes unit tests from the backend-frontend refactor. Not all functionality is validated and some integration tests with a real Kube server are still required to validate construction and retrieval of Hardware resources.
Closes #162

The coverage drop here stems from the /internal/backend package I believe. This package just masks over multiple possible backends providing a convenient way to construct a backend without caring too much about the specifics in the root command.
Maybe we'll add tests one day, maybe we won't 🤷🏻 .


TRM-29172: idmapping missing statistics of ID mapping results

TRM-29172: idmapping missing statistics of ID mapping results and suggested id to UniParc

Thanks for the review. The reasoning behind the code change is in the Jira: TRM-29172


Make out-of-order imports fail the CI profile (better approach?)

Type of change
Select the type of your PR

Enhancement / new feature

Description
Make out-of-order imports fail the CI profile.
I realised that there was a way to avoid the duplication, if you like this approach, I'll update kroxylicious-junit5-extension to work in the same way.
Additional Context
Why are you making this pull request?
Checklist
Please go through this checklist and make sure all applicable tasks have been done

[ ] Write tests
[ ] Make sure all tests pass
[ ] Review performance test results. Ensure that any degradations to performance numbers are understood and justified.
[ ] Make sure all Sonar-Lint warnings are addressed or are justifiably ignored.
[ ] Update documentation
[ ] Reference relevant issue(s) and close them after merging
[ ] For user facing changes, update CHANGELOG.md (remember to include changes affecting the API of the test artefacts too).

Hmm there is probably less code now but it's the first time I've ever seen a property used to specify a goal, so possibly a bit surprising.

Yeah, I hadn't tried it before and I didnt know what to expect. I did google about just to see if I was doing something terrible. I didn't find anything.   It saves repeating the executions block on the CI profile.

Having said that I've nothing against it


Problem when working with loc using Dask

I have a large csv file. I wanted to load this csv file via Dask. I could load it successfully and confirmed some row of the dataset to make sure the dataset has been loaded correctly. I was supposed to select one column of dataset (last column ) with "loc" but I couldn't do so because of the error below. '131094' is the name of last column. How is it possible to do label based indexing for a data-frame with Dask?
import dask.dataframe as dd
df = dd.read_csv('filename.csv', header=None)
y = df.loc[:, [131094]]
File "/usr/local/dask-2018-08-22/lib/python2.7/site-packages/dask-0.5.0-py2.7.egg/dask/dataframe/core.py", line 180, in _loc "Can not use loc on DataFrame without known divisions") ValueError: Can not use loc on DataFrame without known divisions

Duplicate: https://stackoverflow.com/questions/52022211/how-to-use-loc-for-column-selection-of-a-dataframe-in-dask
Recommend close.


Switch from Endure errors to the Spiral errors package

Switch from Endure errors to the Spiral errors package
Add makefile to run tests (make test) with debug tag (to have stack trace in errors)

linked #368


Reorganise the repo

discuss about reorganizing the repo or not....

there are "2 versions"....
1- original version with minor modification... just enough for the code to be used in the bgnn snakemake workfow with Docker image generate by github action. The version is in a a branch named release https://github.com/hdr-bgnn/drexel_metadata/pulls with a pull request..
2- BGNN version,  major refactoring with imprve documentation and functions description, simplification of code sections and clean up of a large amount of cruft... need to be reviewed (I don't know how/by whom. I suggest this version should be used if Drexel abandon their version. https://github.com/thibaulttabarin/BGNN_metadata
Next step I want to mirror this BGNN_metadata fork to hdr-BGNN.


Unsaved tabs don't get recovered

Issue Type: Bug
Open a new tab and close the app unexpectedly (like when the PC goes off without shutting down or using Task manager for simulation). Open the app again. You would realise that some of the tabs would open but empty - without the contents in them.
Azure Data Studio version: azuredatastudio 1.5.2 (f74080c96310354bc92211f1826c0fdce78ca2f6, 2019-03-22T06:25:26.627Z)
OS version: Windows_NT x64 10.0.17134

System Info

Item
Value

CPUs
Intel(R) Core(TM) i7-4710HQ CPU @ 2.50GHz (8 x 2494)

GPU Status
2d_canvas: enabledchecker_imaging: disabled_offflash_3d: enabledflash_stage3d: enabledflash_stage3d_baseline: enabledgpu_compositing: enabledmultiple_raster_threads: enabled_onnative_gpu_memory_buffers: disabled_softwarerasterization: enabledvideo_decode: enabledvideo_encode: enabledwebgl: enabledwebgl2: enabled

Memory (System)
11.94GB (7.86GB free)

Process Argv

Screen Reader
no

VM
50%

Extensions: none

Closing as a duplicate of https://github.com/microsoft/azuredatastudio/issues/3304.  Please add any additional context to that issue.  Thanks for reporting!


Make the passwd file not world readable

We need that permissions for:
table passwd                    passwd:/etc/mail/passwd
@fobser are you using that? or another method? On my setup I shared that file between dovecot and smtpd

yes, I'm sharing that password file with opensmtpd and dovecote, too:
/etc/mail/smtpd.conf:table passwd passwd:/etc/mail/passwd
/etc/dovecot/conf.d/auth-passwd-static-user.conf.ext:   args = scheme=blf-crypt /etc/mail/passwd
On Wed, Mar 21, 2018 at 01:49:46PM +0000, Gonzalo wrote:

We need that permissions for:
table passwd                    passwd:/etc/mail/passwd
@fobser are you using that? or another method? On my setup I shared that file between dovecot and smtpd
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
https://github.com/gonzalo-/ansible-role-mailserver/pull/1#issuecomment-374942892

--
I'm not entirely sure you are real.

@tdm4 can you confirm that the playbook without the change on the passwd file works for you?


Feat: Add support for "Improve this page" and "Report issue" shortcuts

In jenkins.io we offer links that help users to quickly report issues or suggest fixes in the documentation. It has proven to be handy for pages and small patches. We keep issues in the footer, but Keptn could do better and add some JavaScript that provides a popup with a suggest fix / report issue.
Suggested behavior:

"Improve this page" link opens GitHub editor for the page containing content. Any user with GitHub account will be able to edit the page, preview changes, and submit a pull request in a few clicks
"Report issue" opens a new issue GitHub dialog with the issue report template (see #858 for the templates suggestions)

Sample screenshot
See the footer:

connected PR is closed


Use auto-refilling addresses where necessary

Clarification and motivation
Some network tests are currently failing because some addresses' account in them run out of funds, for example see this pipeline.
However, after morley/#638, cleveland is now able to have addresses with auto-refilling balances, which are exactly meant to solve this problem,
Acceptance criteria
Auto-refilling addresses are used to avoid "out of balance" failures in network tests.

Uhhh... are you sure the pipeline you liked didn't fail because the moneybag ran dry? Because it seems like that's exactly what happened...

:thinking: you may be right, I restarted the job there (same pipeline), the funds you sent the address should be plenty, let's see how it goes.

That seems to have helped, but oof, I've thrown in 10ktz, and now it sits at 3.7ktz after two runs. Which means it eats about 3.2 ktz per run. I've thrown in some more, but at this rate it'll run out in less than a month.

Yes, sadly it it quite expensive to run all those tests, perhaps it's time to reduce their frequency.
I added some more, but sadly I don't think that there's any way to automate the refilling of moneybags
Anyway the problem seemed to have been that, so I'm closing this issue.


[Feature][python] Add local dev mod runing python integate tests

Add local dev mod runing python integate tests
fix:#10974

Codecov Report

Merging #11362 (cb59f9e) into dev (3061bbc) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev   #11362      +/-   ##
============================================
- Coverage     40.26%   40.23%   -0.03%
+ Complexity     4843     4838       -5
============================================
  Files           974      974
  Lines         37323    37316       -7
  Branches       4142     4135       -7
============================================
- Hits          15029    15015      -14
- Misses        20748    20752       +4
- Partials       1546     1549       +3

Impacted Files
Coverage Δ

...erver/master/processor/queue/TaskEventService.java
69.64% <0.00%> (-10.72%)
:arrow_down:

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
:arrow_down:

...e/dolphinscheduler/remote/NettyRemotingClient.java
50.00% <0.00%> (-2.78%)
:arrow_down:

...dolphinscheduler/remote/future/ResponseFuture.java
81.96% <0.00%> (-1.64%)
:arrow_down:

...r/plugin/task/sqoop/parameter/SqoopParameters.java
55.12% <0.00%> (-1.29%)
:arrow_down:

...rver/master/runner/task/BlockingTaskProcessor.java
75.60% <0.00%> (-0.30%)
:arrow_down:

...eduler/api/service/impl/DataSourceServiceImpl.java
28.47% <0.00%> (ø)

.../dolphinscheduler/plugin/task/datax/DataxTask.java
0.00% <0.00%> (ø)

...phinscheduler/plugin/task/chunjun/ChunJunTask.java
0.00% <0.00%> (ø)

...cheduler/plugin/task/api/ShellCommandExecutor.java
0.00% <0.00%> (ø)

... and 3 more

:mega: Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Well done and thanks for your help @hiSandog


US-10435 - GDS Info panel updating text for important panel

Minor update to the text - updating references of "Information" to "Important"

There is no dependency on a Pega deployment for this PR


Library starter bugs

Qwik Version
0.0.112
Operating System (or Browser)
windows, ubuntu
Node Version (if applicable)
16
Which component is affected?
Starters / CLI
Expected Behaviour
Library starter should work as before.
Actual Behaviour
After the recent Qwik changes, the Library starter is broken:

missing lib "WebWorker" in tsconfig (build fails)
missing in package.json: (the whole repo ends up in the package as is with npm pack)

version
exports
files
main
module
types

Additional Information
I take advantage of this issue to report other small issues of the previous versions:
Final package ended up with:

typescript definition files for the sample app files as well
the contents of the public folder

Also, since some different configuration between app and library is almost always needed, I ended up creating a different Vite file and tsconfig file:

vite.config.ts (for app)
ts.config.json (for app)
vite.config.lib.ts (for library)
ts.config.lib.json (for library)

This is because it is very bad practice to publish a package with useless files.
Greetings

Having a different configs for app and library I think is a good idea, we'll probably try that instead. Thanks!

Thanks a lot! should be fixed in the latest release!


Update architecture-concepts.md

Fixed a typo: publshers to publishers

Description

Related Issues

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.