[Bug] AltGr as last character keeps it locked

Expected behavior
To be able to use modifier keys (AltGr, Alt, Ctrl, Shift) for the last character of the keyword.
Actual behavior
If the last character use AltGr on a french keyboard (for example to type @) than AltGr stays locked.
Steps to reproduce the behavior
Create new combo with keyword t@ and snippet test and try to use it with AZERTY (French) keyboard.
Beeftext version (e.g. Beeftext v7.0 Portable Edition).
Beeftext v7.1 Portable Edition and v7.2 Portable Edition
Operating system version (e.g Windows 10)
Windows 10
This issue seems to be related to #296.

As far as I know, AltGr is equivalent to Ctrl+Alt. Do you experience the same issue if you use Ctrl+Alt?

As far as I know, AltGr is equivalent to Ctrl+Alt. Do you experience the same issue if you use Ctrl+Alt?

As far as I know, AltGr is equivalent to Ctrl+Alt. Do you experience the same issue if you use Ctrl+Alt?

As far as I know, AltGr is almost equivalent to Ctrl + Alt but not exactly equivalent. Like the left and the right Ctrl are in general equivalent, but you can also make a distinction between them.
I have made some tests with combo keyword finishing with @ (AltGr + à) :

If I use Left Ctrl + Left Alt + à the snippet is inserted buth the keyword is not erased. After that everything works as usual (no key is considered "down").
If I use AltGr + à nothing happens and the Ctrl is considered "down" I think. For example if hit Alt + e it displays € like if I have used Ctrl + Alt + e. To go back to normal I have to click one more time Left Ctrl key.

As far as I know, AltGr is equivalent to Ctrl+Alt. Do you experience the same issue if you use Ctrl+Alt?

As far as I know, AltGr is almost equivalent to Ctrl + Alt but not exactly equivalent. Like the left and the right Ctrl are in general equivalent, but you can also make a distinction between them.
I have made some tests with combo keyword finishing with @ (AltGr + à) :

If I use Left Ctrl + Left Alt + à the snippet is inserted buth the keyword is not erased. After that everything works as usual (no key is considered "down").
If I use AltGr + à nothing happens and the Ctrl is considered "down" I think. For example if hit Alt + e it displays € like if I have used Ctrl + Alt + e. To go back to normal I have to click one more time Left Ctrl key.

I have the same issue with Right Shift modifier. (QWERTY, UK/EU Keyboard, English language)
The key (ostensibly) remains hold down until I press it again.
It appears when using emoji shortcodes


Possible buffer over-read in RewriteDriver::ParseTextInternal

When RewriteDriver::ShouldSkipParsing returns true, Write is called with content without size. This results in conversion of content to StringPiece and relying on strlen to determine size. This could result in buffer over-read if content is not NULL-terminated.
https://github.com/pagespeed/mod_pagespeed/blob/32de3d0e12ff357b7a75e1e7e04507d2ccb560c7/net/instaweb/rewriter/rewrite_driver.cc#L2181

Thanks for the report!

@cellscape Addressed in https://github.com/pagespeed/mod_pagespeed/pull/1591, let me know if that looks good to you

Looks good, thanks!


I am experiencing a hard time trying to get ng2-bootstrap package to work

Hello...
For my project I need pagination support so I decided to give ng2-bootstrap a chance. But I am running into a series of problems trying to add the dependency ranging from compile errors to incorrect placement of TS output js files. I am using TS 1.7.4. At this point I am not sure where the blame should be placed, either with ng2-bootstrap, TS compiler, or myself. Here's what I did:
In my package.json file I added the following dependency: "ng2-bootstrap": "1.0.7". As a result of doing so the corresponding package is downloaded and placed in my "node_modules" folder. Great, so far so good.
Then I added the following code to the top of one of my TS classes:
import {PAGINATION_DIRECTIVES} from 'ng2-bootstrap/ng2-bootstrap';

Now after doing this is when problems begin to appear. At this point when I try to compile I get the following errors:
Severity	Code	Description	Project	File	Line	Suppression State
Error	TS2307	Cannot find module 'moment'.	TypeScript Virtual Projects	C:\MyProject\src\MyProject\node_modules\ng2-bootstrap\components\datepicker\date-formatter.ts	1	Active
Error	TS2307	Build: Cannot find module 'moment'.	MyProject	C:\MyProject\src\MyProject\node_modules\ng2-bootstrap\components\datepicker\date-formatter.ts	1

So now I am scratching my head wondering why this is happening. I take a look at the offending file (date-formatters.ts) and see that it has the following code at top:
import * as moment from 'moment';
OK so I say to myself must be a missing reference or something so I better go find it. But before I do that my first question is: Why is the TS compiler trying to compile this TS file which resides in an excluded folder? My tsconfig file is located in the root of my project and it has the following:
"exclude": [
    "node_modules",
    "wwwroot"
  ]

Because of this my expectation is that the TS compiler should not compile anything inside the node_modules folder but apparently it is. Otherwise why would I get this error? So this is my first question. One thing I noticed about this particular node package is that it contains not only js and d.ts files but also ts files. Plus it also contains a tsconfig file. I am not sure if this has something to do with the problem.
Despite this question I proceeded to investigate the error looking for answers. I ran across the following post: "https://github.com/valor-software/ng2-bootstrap#with-webpack-angularclassangular2-webpack-starter". It basically states that I need to install moment.js including its typings. So I went ahead and did that. I installed the typings using the following command:
typings install moment --save

At this point in time I notice that my project now has a "typings" folder with a bunch of stuff in it. I also notice a new typings.json file at the root. OK great so then I proceed to compile. 	TypeScript Virtual Projects	C:\MyProject\src\MyProject\typings\main\definitions\moment\index.d.ts	496	Active
Severity	Code	Description	Project	File	Line	Suppression State
Error	TS2300	Duplicate identifier 'export='.	TypeScript Virtual Projects	C:\MyProject\src\MyProject\typings\browser\definitions\moment\index.d.ts	496	Active

At this point I am 5 seconds away from blowing my head off with no idea whatsoever what's going on. I sort of understand the issue. Basically two TS files exporting the same thing I guess. So I am thinking to myself is this typings package buggy? Or is this a TS compiler issue/bug? No idea. So this is my second question.
So then I proceeded to investigate the above dup identifier error. I ran into the following: “https://github.com/Microsoft/TypeScript/issues/7369”. It basically states that I have to exclude various files when compiling. So I did that by adding some items to exclude in my tsconfig file:
"exclude": [
        "node_modules",
        "wwwroot",

        "typings/browser.d.ts",
        "typings/browser"
    ]

Specifically I added the last 2 entries above. So then I proceeded to compile again. This time I was able to compile with NO errors! Yay! I’m thinking to myself problem solved. But no…
Right before I was about to pat myself on the back for having gotten the compile errors to go away, I noticed that now the output structure of my js files is totally messed up!!!!! In other words after compiling, the js files generated by the TS compiler are not in the correct location anymore. Here’s what I have in my tsconfig file:
"outDir": "wwwroot/Scripts"
In my project all of my TS files are located inside a “Scripts” folder that is located on the root. Inside this folder I have various subfolders with TS files inside of them. So my directory structure looks something like this:
wwwroot
---Scripts
------Module1
---------File1.js
---------File2.js
------Module2
---------File1.js
---------File2.js
Scripts
---Module1
------File1.ts
------File2.ts
---Module2
------File1.ts
------File2.ts
Above is how things were working before I embarked on this journey. The above is correct. Now however after making all these changes the output looks like this:
wwwroot
---Scripts
------Scripts
---------Module1
------------File1.js
------------File2.js
---------Module2
------------File1.js
------------File2.js
---node_modules
------ng2-bootstrap
-----------...a whole bunch of js files and subfolder with js files
At this point I am basically 1 second away from blowing my head off. If you notice above suddenly my Scripts folder is nested inside the previous Scripts folder. And not only that there’s now a “node_modules” folder that contains an ng2-bootstrap folder that in turn contains a whole bunch of js files and subfolders with js files. Why is this happening? Again as I mentioned previously this particular ng2-bootstrap package ships with a bunch of ts files which is not something I have seen before. Most packages I have seen distribute only js and d.ts files. This package also includes a tsconfig file as well which is also not something I have seen before either. Just for the heck of it I manually deleted every ts file that comes with the package and sure enough the above problem with the directory structure goes away. In other words the presence of the ts files causes the problem to surface and their absence fixes the issue. Why is this happening? Is this a problem with the ng2-bootstrap package? Should it NOT contain ts files? Or is this a problem with the TS compiler? Why would the output structure change? Is it a problem with my project?
Any help with this would be greatly appreciated. Thank you

Error   TS2307  Cannot find module 'moment'.    TypeScript Virtual Projects C:\MyProject\src\MyProject\node_modules\ng2-bootstrap\components\datepicker\date-formatter.ts

this tells me that the author of the ng2-bootstrap package is including sources in the definition, which is generally a very bad idea, both for you having to deal with compilation errors, as well as compilation time.
All the files exported by a package should be definition files, i.e. .d.ts files

Because of this my expectation is that the TS compiler should not compile anything inside the node_modules folder but apparently it is.

see https://github.com/Microsoft/TypeScript/wiki/FAQ#why-does-a-file-in-exclude-list-is-still-picked-up-by-the-compiler for more information.

At this point I am 5 seconds away from blowing my head off with no idea whatsoever what's going on. I sort of understand the issue. Basically two TS files exporting the same thing I guess.

I have reported this issue to @blakeemberly a few times already. i believe he intends to fix it, https://github.com/typings/typings/issues/151

@mhegazy ... thanks for the responses... and thanks for fixing the formatting... I will make sure to be more careful next time...
Do you happen to have any ideas on why the output directory structure changes?

 If you notice above suddenly my Scripts folder is nested inside the previous Scripts folder. And not only that there’s now a “node_modules” folder that contains an ng2-bootstrap folder that in turn contains a whole bunch of js files and subfolders with js files. Why is this happening?

Well. the main issue here is again that ng2-bootstrap ships source files (i.e. .ts) files. from the compiler perspective, these are just input files, that you meant to compile, and then it will try to put them in your output folder...

@mhegazy ... thanks for the responses... and thanks for fixing the formatting... I will make sure to be more careful next time...

no worries, your formatting is jsut fine, i jsut got used to it, and it makes it easier for me to read :D

Do you happen to have any ideas on why the output directory structure changes?

The compiler does something fairly stupid to know what is the root of your project. i.e. where to start mirroring the input to the output directory in outDir. it tries to find the longest common path prefix of all input files. usually this is not what want.
use --rootDir to tell it where is the "root". in your case, i would expect it to be "outDir" : "scripts"

one more thing, i just want to say thanks for sharing this information. I do not believe setting up a package and consuming it should be that hard.
We are currently working on streamlining the whole process of producing and consuming external typings files, as there is a lot of confusion around it now, see https://github.com/Microsoft/TypeScript/issues?q=is%3Aopen+is%3Aissue+label%3ATypings; but that is not untill the next release. let me see what i can do in the meantime.

@mhegazy ... thanks for all the help... I've learned a lot today from your responses... I will go ahead and close this issue... I also plan on contacting the ng2-bootstrap team and let them know about the issue with distributing sources... thanks again

I agree that I should hide ts files for now, but in general ts compiler should exclude excluded files :)

I agree that I should hide ts files for now, but in general ts compiler should exclude excluded files :)

This is not about excluded files. this is about an import statement. it points to a module, using the node module resolution, it is located in node_modules, the file found is a source file.
You can find more information in https://github.com/Microsoft/TypeScript/wiki/FAQ#why-does-a-file-in-exclude-list-is-still-picked-up-by-the-compiler
and more information about module resolution in general in http://www.typescriptlang.org/docs/handbook/module-resolution.html

ok, so basically if file is resolved from node_modules it is meant to be .js.d.ts
soo, is there are a chance to have different resolution order for files from project and from modules?

Source files are always given higher precedence, as they are considered "closer" to truth, than a build output like .d.ts.
Originally we only resolved .d.ts from node_modules, and ppl have found that too restrictive, there are different ways to setup a project, and some user use npm packages to link to sources, and would like to import at design time to point to the source.

what about giving to an author of module an option to set resolution precedence of .d.ts over .ts
with fallback to .ts files
my idea behind it:

if consumer installs module from npm, he gets .d.ts + .js version
if consumer installs module from git (via npm) he will be able to consume .ts files

right now this is not really possible
what do you think? @mhegazy

should that be transitive? or only for one module? does that apply with path mapping or now? The process is already complicated. i would not want to through another option there.
@vladima had a validation tool that library authors can run. @vladima can you share your tool?

not one for sure https://github.com/valor-software?utf8=✓&query=ng2

for now I have gotten around the issue by:

changing my tsconfig from ["outDir": "wwwroot/scripts"] to ["outDir": "wwwroot"]. at least now my TS scripts folder is not nested.

for now just live with the presence of a "node_modules\ng2-bootstrap" folder with a bunch of stuff in it that's produced by the TS compiler because the ng2-bootstrap package contains source TS files.

again... thanks all for your input...
@mhegazy ... thanks again...

check again, ts files now in ts folder

@valorkin ... thank you... work great now...

Awesome :)


Support newly added test in the TCK

SPI Issue: Include TCK tests using Parameters refer: Include TCK tests using Parameters
This issue is to support SPI 1.0.0.RELEASE

Resolved by commit 42045c5


contentctl v4.2.0

~Prep for release v4.2~
This branch has been remapped to 4.3. 4.2 will contain only the release version of the data_source implementation

Making a note here: This branch contains dashboard updates

With the latest pushes, I have manually DIFFED the conf files and the API JSON files and believe they are correct.
Diffing some of the API JSON files is challenging because some of the fields come out in a different order. In the future, we should consider applying SORTS to these fields so that their order is deterministic.


removing white space between license file name

Hello coreyti,
I had some difficulties due to white space between this license file name during build process.
If possible, can we use proposed file name instead of the original file which has "white space"?
Thanks.

Hello. The perl src code has been removed from the repository in the new versions.

Fixed at eae5f0e


A plugin that implements token parsing and authentication function based on wasm-go

Ⅰ. Describe what this PR did
A plugin that implements token parsing and authentication function based on wasm-go
Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

可以参考这个：https://github.com/alibaba/higress/tree/main/plugins/wasm-go#e2e测试
写一个e2e测试示例呢

已添加E2E测试 @johnlanni


Get Started Overview: remove id from page metadata

👋👋 Hello there! Welcome. Please follow the instruction below.
Click the Preview tab and select a PR template:

@SahajCyberHawk I would be inclined to close this PR categorically — because I can't see a reason why we would remove the "machine readable" id: tag from this, or any, article metadata — but first please would you explain your rationale for requesting this change?

Closing due to absence of background/effort (which kinda makes sense if looked at account activity )


Adding Open-API configuration

I've made some research and do sample for automatization of getting sonar api. It builds open api configuration from sonar assemblies. I've added sample and it's result to rep

Do you have any update, guys? I would like to just switch audio device in GG in my script.


pathname should be a required prop for Blocks/Block/Edit.jsx component

The Listing block depends on it. See for more required props: https://github.com/plone/volto/blob/master/src/components/manage/Blocks/Block/BlocksForm.jsx#L244

Hello @tiberiuichim ,
Could you explain what exactly is the issue??
Do we need to add pathname as a required prop in Edit.jsx??

@KartikBudania yes, it should be marked as a required propType.

Can i work on this? @tiberiuichim

@akshatgarg12 Yes. Please see also https://6.dev-docs.plone.org/volto/developer-guidelines/contributing.html#create-a-pull-request

@tiberiuichim There are other props also which are not present in prop types of Edit block https://github.com/plone/volto/blob/master/src/components/manage/Blocks/Block/Edit.jsx#L42 other than pathname,  should all those be added as a required prop ?

@akshatgarg12 only if we know for sure that they're really required, if, for example, there's a block edit component that uses them.

@tiberiuichim EditDefaultBlock uses onChangeBlock and block from props, which are not present in prop types of edit block, https://github.com/plone/volto/blob/master/src/components/manage/Blocks/Block/DefaultEdit.jsx#L10, also blockConfig is used in EditBlock https://github.com/plone/volto/blob/master/src/components/manage/Blocks/Block/Edit.jsx#L69, should these also be added as required props?


"Documentation and Resources" readme links return 404s

please identify and fix

Thank you, should be fixed.


webview detection

Hi @mileusna, is there a way to detect if it's a webview or a browser? thank you

with some (few) search, it looks like it can be detected with X-Requested-With header. Please close the ticket if you confirm this approach

another approach would be to detect:
   // if it says it's a webview, let's go with that
  'WebView',
  // iOS webview will be the same as safari but missing "Safari"
  '(iPhone|iPod|iPad)(?!.*Safari)',
  // Android Lollipop and Above: webview will be the same as native but it will contain "wv"
  // Android KitKat to lollipop webview will put {version}.0.0.0
  'Android.*(wv|.0.0.0)',
  // old chrome android webview agent
  'Linux; U; Android'

check here

No user agent string provided.

No user agent string provided.


chunkingcookiemanager leaks unused chunks

There seems to be a bug in Microsoft.AspNetCore.Authentication.Cookies.ChunkingCookieManager when used in conjunction with CookieAuthentication.  What I've seen is that as the size of the Authentication cookie changes the number of chunks needed to the accommodate the cookie data will change as well.  If the number of cookies needed decreases, then chunks that are no longer needed are not being cleaned up.
Normally this isn't a big deal, but I'm currently running in a system that has a hard limit on the header size of 10240 bytes.  The specify scenario I'm running into has the Authentication cookies going from 2 chunks (3 total cookies) to 1 chunk (1 cookie).  This has the added bonus of replacing the value in the cookie that previously stored the chunk count (really small), to now storing the entire Authentication Ticket (relatively large), in turn nearly doubling the amount of header space consumed by the Authentication cookie.
It seems like it could be beneficial to have ChunkingCookieManager  expire these "vestigial" as it's setting the new chunks on the response.

What triggers the resize, a direct call to SignIn? The workaround would be to preceed that with a call to SignOut.

I haven't actually been able to diagnose that yet, because it doesn't happen consistently.  What I can say is that it's not tied to a SignIn or SignOut action because the users are in the middle of an active session using the application.  This leads me to believe/fear, that something else in one of the middle-ware's is manipulating and dropping some of the claims in the Authentication Ticket, but I can't see where.  If that's the case this becomes a different issue for me, though it doesn't necessarily take away from this issue.

I've figured out why the Authentication Cookie is changing size.  We're using OIDC and OAuth in our application, OIDC to manage login, and OAuth to call services outside the application.  For this to work, we had to implement code to perform sliding expiration on the Access Token used in the OAuth flow so that we would always have a valid access token during a valid application session.
The service we're calling to get and refresh the tokens doesn't always return tokens of the same size.  Now, it's entirely possible that such behavior is invalid, but I don't have control over that service so it is what it is at this time.  This combined with the fact that our Authentication cookie is right on the boarder of being 4K in size means that as the size of the tokens changes it could push us above or below the threshold for needing to chunk the Authentication Cookie.

As far as I know SignIn doesn't come into play.  The refresh logic happens in the OnValidatePrincipal event of the CookieAuthenticationOptions.  The tokens are then updated on the AuthenticationProperties of the CookieValidatePrincipalContext using the StoreTokens method.

Ah, you set CookieValidatePrincipalContext.ShouldRenew?

No.  We're not explicitly renewing the cookie in the event because we set SlidingExpiration to true when we setup the Cookie Authentication Middleware.  Keeping in mind that we're using OIDC to log in via an identity provider then using the AccessToken provided by that identity provider to call Api's that are external to the application, but secured by the same IdentityProvider.  The application is not using the AccessToken in the cookie to secure itself, because it doesn't need to.  We're only keeping it around to facilitate the Api calls.  As such I'm not aware of a way to tell the Oidc Middlware to maintain an unexpired cookie.  Thus why we implemented our own code inside OnValidatePrincipal.  Here's what that looks like
//properties is of type Microsoft.AspNetCore.Authentication.AuthenticationProperties passed in from the HttpContext
var refreshToken = properties.GetTokenValue(OidcConstants.TokenTypes.RefreshToken);
var expiresAt = GetExpiresAtUtc(properties);
var utcNow = DateTime.UtcNow;

if (!string.IsNullOrWhiteSpace(refreshToken) &&
    expiresAt.GetValueOrDefault(DateTime.MaxValue).Subtract(utcNow) < _renewTimespan)
{
    var tokenResponse = await RefreshAccessToken(refreshToken);

    //The initial token we get at login has an expiration that's precise to the second, so for consistency we'll do the same for renewals
    var utcNowTrimmed = new DateTime(utcNow.Ticks - (utcNow.Ticks % TimeSpan.TicksPerSecond), utcNow.Kind);
    var newExpiration = utcNowTrimmed.AddSeconds(tokenResponse.ExpiresIn).ToString(DateFormat);

    properties.StoreTokens(new List<AuthenticationToken> {
        new AuthenticationToken
        {
            Name =  OidcConstants.TokenTypes.AccessToken,
            Value = tokenResponse.AccessToken
        },
        new AuthenticationToken
        {
            Name = OidcConstants.TokenTypes.RefreshToken,
            Value = tokenResponse.RefreshToken
        },
        new AuthenticationToken
        {
            Name = OidcConstants.TokenTypes.IdentityToken,
            Value = tokenResponse.IdentityToken
        },
        new AuthenticationToken
        {
            Name = OidcConstants.TokenResponse.TokenType,
            Value = tokenResponse.TokenType,
        },
        new AuthenticationToken
        {
            Name = ExpiresAtTokenName,
            Value = newExpiration
        }});

If we've gone off the rails on the implementation here, then we're open to ways to simplify the code as well.

Updating properties is fine, but those changes arn't saved anywhere unless you call SignIn or ShouldRenew. You could get lucky and make this change on a request that naturally triggers a sliding refresh, but don't count on it.

Ah, I did find where we're calling ShouldRenew, it's just one layer up in the stack from where the code above was.  Anyway, I think we've gotten a little side tracked.  Thinking about the SingOut + SignIn workaround you mentioned, I assume SignOut will expire the old cookie followed by SignIn to issue a new one.  Are there other side effects we should be aware of if we go that route?

Note SignOut will apply a redirect in some scenarios.
I guess you could also call DeleteCookie directly:
https://github.com/aspnet/Security/blob/42dd66647dd389c242ff796a530b880c7b9d7a90/src/Microsoft.AspNetCore.Authentication.Cookies/CookieAuthenticationHandler.cs#L363-L366

This certainly sounds like a bug. It would make sense for the cookie manager to clean up unnecessary cookies as part of setting the new cookies.

Quick follow up.  For a workaround I did try using DeleteCookie prior to calling AppendCookie, I actually ended up wrapping ChunkingCookieManager in a new implementation to do this inside the new classes AppendCookieMethod and setting the new class as the CookieManager in startup.  Anyway, This worked great locally, but when we deploy to our AWS env's it caused issues.  It appears the order in which the Set-Cookie headers is sent back may not be guaranteed, or was manipulated by the AWS infrastructure.  So Calling Delete followed by Append could create multiple Set-Cookie headers for the same cookie leading to unexpected events.
So instead I created a helper method that would inspect the Request cookies and the Response cookies for a given key and remove any that existed in the Request but not the Response.   I think called this helper method in the wrapper class after calling the base AppendCookie Method.  This worked across all our envs:
public class CleanChunkingCookieManager : ICookieManager
{
	private const string ChunkSuffix = "C";

	private readonly ChunkingCookieManager _innerCookieManager = new ChunkingCookieManager();

	public void AppendResponseCookie(HttpContext context, string key, string value, CookieOptions options)
	{
		_innerCookieManager.AppendResponseCookie(context, key, value, options);
		RemoveVestigialChunkCookies(context, key, options);
	}
       ...
	private static void RemoveVestigialChunkCookies(HttpContext context, string key, CookieOptions options)
	{
		var deleteOptions = new CookieOptions
		{
			Domain = options.Domain,
			Path = options.Path,
			HttpOnly = options.HttpOnly,
			IsEssential = options.IsEssential,
			Expires = DateTime.UnixEpoch,  //Jan 1, 1970 forces deletion
			MaxAge = TimeSpan.Zero,  //Max age is zero.  Secondary value to force deletion
			SameSite = options.SameSite,
			Secure = options.Secure
		};

		string searchString = $"^{key}({ChunkSuffix}\\d+)?";
		var requestChunkNames = context.Request.Cookies.Keys.Where(k => Regex.IsMatch(k, searchString));

		var responseCookies = context.Response.Headers["Set-Cookie"];
		var responseChunkNames = responseCookies.Where(v => Regex.IsMatch(v, searchString)).Select(v => Regex.Match(v, searchString).Value);

		var vestigialChunks = requestChunkNames.Except(responseChunkNames);
		foreach (var chunkName in vestigialChunks)
		{
			context.Response.Cookies.Append(chunkName, string.Empty, deleteOptions);
		}
	}
}


CI: debug info to check /build is mounted

This update is to fix the CI to produce the artifacts in the artifacts/ directory (they still have different owner, but it'd not a big deal for now).

Thanks for checking it, @johngedell! Sometimes, there can be repeating lines, so sort -u sorts and outputs the unique lines.

This addition is straightforward and obvious to me now. We are removing privileges from root and giving it to the user.

Actually, in the running Docker container, the generated files were owned by the conda user with the id=9001, so it wasn't possible to add the files to the cloned repo in the CI from the container, which is read-only for non-runner users. So, the solution was to create a world-writable artifacts directory (with 777, or rwxrwxrwx permissions), and to place the files within the Docker container to that directory, and finally, when the build is over, change the ownership from the "unknown" to the CI environment user (with the id=9001) to the actual user that runs the CI build (runner).


Recommendation: Use the OS-provided random number generator

This project uses its own CSPRNG and deals with gathering entropy to seed it. I strongly recommend against this. This is work that is already done for you by any decent operating system, and the OS kernel is in a much better position to do so:

It has access to many more sources of entropy, including making use of hardware randomness generators if they are present
The kernel's random number generator code is incredibly well-studied, reviewed and audited
It's more convenient to use (doesn't need seeding!)

On Unix and Linux systems, the right answer is to read from /dev/urandom (or use the getrandom() syscall on newer Linux kernels - but urandom is still fine to use). On Windows, you can use CryptGenRandom.
Citations:
How To Safely Generate Random Numbers - citation to use /dev/urandom, this is very biased towards Linux but makes a small mention of OS X and BSD
Myths About /dev/urandom - goes into a lot more detail about how /dev/(u)random works and dispells many common falsehoods about it
Thomas Ptacek telling me to use CryptGenRandom on Windows - best citation I have to hand for what to use on Windows

Doesn't /dev/urandom work from a 256-bit entropy pool by default?
As I understand it, the seif web is interested in seeding from much larger entropy pools, which could only be obtained quickly from hardware RNGs, of which cameras and microphones are the most popular and widespread variants.

@zofrex thanks for your input -- our first choice was to just use the OS random number generator. However we are looking at using this to generate 521-bit ECC public keys and 256-bit AES secrets (possibly longer).
Taking that into consideration and the fact that we use the bytes mainly for crypto services we needed a random number generator with a long period and large state space. We therefore decided to use a CPRNG enabling our requirements.
The CPRNG in use needs 16MB of random data to seed -- The OS entropy does not meet this requirement and hence we need other hardware sources to enable such a pool.

As far as I know, the OS random number generator is suitable for those applications. It's standard to generate public keys using /dev/urandom, and urandom is most definitely suitable for crypto services in general.

from the link:
What about entropy running low

The underlying cryptographic building blocks are designed such that an
attacker cannot predict the outcome, as long as there was enough
randomness in the beginning. A usual lower limit for “enough” may
be 256 bits. No more.

also from the link:
About 256 bits of entropy are enough to get computationally secure
numbers for a long, long time

I don't know if these are compelling answers. It sounds like the author is arguing that 256 bits of entropy is enough, and that may not be true for 521-bit ECC keys.

(NB: In this comment I'm using the term "true random" to include both true randomness such as nuclear decay, and the pretty-close-to-true-randomness signals commonly used by computers, such as those that seed urandom and indeed the CSPRNG in seif)
It's important not to mix up the amount of (actual, true random) entropy needed to seed the RNG (256 bits) and the amount of (cryptographically secure pseudo random) entropy needed to generate a key (which doesn't actually bear any resemblance to the amount of bits the key itself is, incidentally).
Unless you are using something like a one-time pad, you don't benefit from using true random numbers - you only need numbers that are unpredictable enough for cryptographic purposes. Seeding a CSPRNG with sufficient true random bits (the 256 bits you mention) means we can keep using that CSPRNG until the cows come home for things like ECC - we get unlimited useful pseudorandom bits from it!
It doesn't matter if we're talking about 256-bit AES keys, 521-bit ECC keys, or 2048-bit RSA keys - you can get enough bits from urandom. The numbers are the same dimensions (bits) but there isn't a relation such as "you need 2048 bits of true randomness seeding your CSPRNG to generate a 2048 bit RSA key".

It sounds like the author is arguing that 256 bits of entropy is enough

Yes, 256 bits read from a random device would not be enough to create a 521-bit ECC key, but that's not what they're arguing it's enough for. They're arguing that 256-bits of true entropy is enough to generate much, much more than 256 bits of computationally secure random numbers, and you use those bits to create your keys.
Slightly tangential, but also from the article:

while appeal to authority is usually nothing to be proud of, in cryptographic issues you're generally right to be careful and try to get the opinion of a domain expert

Many of the cryptographic choices made by this project are extremely unusual. As a first-order approximation, unusual is not good when it comes to crypto. Cryptography is an area which absolutely needs input from domain experts. I am not an expert on cryptography, but this project needs one involved if it is going to make its own crypto decisions and achieve its aims of security.

Why was this closed? This is a massive issue that urgently needs fixing.

@SN4T14 see #3

@mreinstein #3 is suggesting using a different user-space CSPRNG, not removing the user-space CSPRNG altogether, which is the correct course of action.

see the comment from Aashish on Nov 3rd earlier in this thread.

@mreinstein @zofrex already responded to that, with very valid criticism, Aashish just closed the issue without further comment after that.

zofrex argues that any decent operating system will provide all of the random services that we need. My concern is not with any, but with every. zofrex and SN4T14 are insisting that I fully trust every operating system to provide all of my random services, including operating systems from all vendors, in all configurations, including all versions, including versions which do not exist yet.
I am unable to trust that which I cannot possibly test.
So I will use the randomness provided by the operating systems, because it is generally very good, but I cannot not trust it completely. And by blending other sources, I do not need to.

So I will use the randomness provided by the operating systems, because it is generally very good, but I cannot not trust it completely. And by blending other sources, I do not need to.

There is a discussion ongoing here that says otherwise.

There is a discussion ongoing here that says otherwise.

And none of the core node maintainers seem to be on board with it. In fact, they seem to reinforce what @douglascrockford  has already mentioned: randomness services on some OSes are broken, and can't be trusted completely:
http://lwn.net/Articles/633805/rss

@mreinstein You have not read the thread carefully enough.

And to clarify, the people suggesting that node not use OpenSSL's PRNG (which is at least in part the work of experienced cryptographers, and is absolutely regularly reviewed by experienced cryptographers for flaws) are also not experienced cryptographers.


Support LTS related stuff to convert

Before:
./convert-artifacts-layout.sh apt
./convert-artifacts-layout.sh yum
After:
./convert-artifacts-layout.sh apt
./convert-artifacts-layout.sh yum
./convert-artifacts-layout.sh apt lts
./convert-artifacts-layout.sh yum lts
Then
artifacts/5 or artifacts/lts/5 will be used for output.

Thanks!
Will this file be needed separately?
https://github.com/fluent/fluent-package-builder/blob/447ec25ff18f2353f2f46bbdb37a48a72f6692a7/fluent-lts-apt-source/convert-artifacts-layout.sh

Will this file be needed separately?

I think that no need to fix them.

Added one more fix for dry-downloa,upload

I think we should add some usage here.
https://github.com/fluent/fluent-package-builder/blob/bb096998e5b7ad71c9fdf3edae4b490a8087ecae/fluent-package/convert-artifacts-layout.sh#L3-L7

manage-fluent-repositories.sh for Amazon 2023 should be modified a bit,  but create another PR for it.


Your web-page is ready along with short video and logo.

My laptop do not support screenshot so I have taken a picture from my phone
and attached. Please forgive me for poor picture quality.
On Thu, Oct 7, 2021, 12:49 AM Jinesh Kanjiya @.***>
wrote:

@singhshobhit12a https://github.com/singhshobhit12a you need to add
your logo in the homepage.html itself and then take a screenshot of it and
attach the screenshot while commenting in the PR. You don't have to make a
separate html file for that. I hope this is clear
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MSTC-DA-IICT/We-demy/pull/15#issuecomment-936950320,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AVOMKMEA5PPQ5EFX4LDXXVTUFSOMNANCNFSM5FK6E3KA
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


chore: list all needed packages on the Dockerfile

At the moment, we only install the packages that we need but that are
missing from the base Docker image that we use.
For safety purposes (and to make it easier to switch to another base
image), we list all the needed packages, even if they usually come
pre-installed, since that would only be a no-op in the worst case.
See: https://github.com/resin-io/etcher/commit/296a55463714194d15c28eb79bb2939908f8cffd#commitcomment-22358869
Signed-off-by: Juan Cruz Viotti<EMAIL_ADDRESS>

Linux CI builds are failing because libsass0 isn't available on Ubuntu. I think if you remove that one package then the Linux docker builds should work again.

@alexandrosm is suggesting we don't do this, so I'll let you close this @jviotti

Sounds good, I don't have any strong opinions, so let's close it!


With cloudflare images preloader gone missing

With recent #2143 we lost preloader bc images are already there
check out on https://beta.kodadot.xyz

Continue to #2193


Clean css html

Fix issue from review
Fixed the tag issue and the background issue to follow exact  Figma UI

Alright correction noted.  Thanks alot ..
On Wed, 24 Nov 2021, 10:53 pm Leonardo P., @.***> wrote:

@.**** approved this pull request.
Hi @Ginohmk https://github.com/Ginohmk ,
Your project is complete!
Congratulations! 🎉🎉
Important
In the future please do not create another branch or open another pull
request, all the re-reviews should be in the same branch and the same pull
request, this avoids confusion and makes reviewing the code a lot easier.
To highlight:

Congrats on implementing suggested by the previous reviewer.

Now there is nothing left to do but to merge it! 🏆
https://camo.githubusercontent.com/6ada59f6189497c1c2cae6d06f8154b7307a58643f232340e288140ed469eb28/68747470733a2f2f6d65646961322e67697068792e636f6d2f6d656469612f6c3366516333614356304871707a5763552f67697068792e676966
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something
is not 100% clear.
As described in the Code reviews limits policy
https://microverse.zendesk.com/hc/en-us/articles/1500004088561 you have a
limited number of reviews per project (check the exact number in your
Dashboard). If you think that the code review was not fair, you can request
a second opinion using this form https://airtable.com/shrQAqnBwek5a0O0s.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/Ginohmk/My-portfolio/pull/2#pullrequestreview-815401019,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AOAMQM4WP2SIQ37H6G4GIW3UNVNEZANCNFSM5IXBL3IQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.


Large play button

Integrate large play button

:tada: This PR is included in version 1.0.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Navigation menu Sample crash

Press on the hamburger menu, it asserts out:
Exception = {"The text associated with this error code could not be found.\r\n\r\nA TargetPropertyPath for a Style Setter cannot specify an explicit Target object. [Line: 55 Position: 49]"}

This should have been fixed by 664e4916e43d85d019f37d6f070549df8e140385.  Can you check if you have that fix in your drop of the sample?

Just checked via file compare, I do have the most up to date source code.  I did notice that you did fix the problem (I didn’t report this) where the page header was overlapping on top of the hamburger menu when the window was resized.  However not matter what size the window is, I press the hamburger menu, I assert out.

Ok.  Using the VisualState.Setters in a control template applied as part of a style on the hamburger toggle button was causing an issue.  Change 82bba56abf8cf294b05ec9a5089b0e8bfde2c279 should resolve it.


Provide details how to configure development IDE for working with plus_plugins monorepo

Use case
The section "5.1 Getting started" of the CONTRIBUTING.md simply says "git fetch, git checkuput, hack away".
That is not enough details to get the project's code into an IDE, especially when the contributor's intent to look only at individual plugins and some subset of platforms (e.g. mobile ones).

Unlike may other open-source plugins and packages, I can't see an obvious way to get parts of the code imported into the IDE to allow the "hack away" part on this large monorepo.
For example, this is how one of the projects opens in AS after running the prescribed melos bootstrap:

Proposal

Please provide details how to get to code into IDE, be able to compile it there and run the tests from the common Flutter IDEs, e.g. VS Code and Android Studio.

Could you explain what you exactly mean by "get code into IDE"?

Could you explain what you exactly mean by "get code into IDE"?

See screenshot illustrating it in the issue description. You don't expect contributors to "hack away" in a Notepad, or do you?

I use VS code for flutter. To check on Android Studio I opened this folder, it worked fine there. I have not installed anything other than Flutter plugin. It's something to do with the IDE, this isn't how its supposed to look out of the box.

That is what I'd have expected to see but it doesn't look like that here. Either some steps are missing or you "opened this folder" in AS somewhat differently.

After running melos bootstrap in the terminal, I selected "Open project", then navigated to packages-> package_info_plus -> package_info_plus and that's it.


Admin Icons

Please note that some Admin items have incorrect icons:

https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/content.php#L3
The cog icon at Content should be replaced with document.

https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/users.php#L3
The person icon at Users should be replaced with people.

https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/about.php#L3
The person icon at About should be replaced with info.

https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/themes.php#L3
The puzzle-piece icon at Themes should be replaced with eye.

https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/configure-plugin.php#L3
The person icon at Configure Plugin should be replaced with wrench.

https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/new-content.php#L67
The tags icon at Category should be replaced with tag.

https://github.com/bludit/bludit/blob/master/bl-kernel/admin/views/new-content.php#L68
The tags icon at Description should be replaced with tag.

Tested on https://github.com/bludit/bludit/commit/47e5994c94eae158249f0d7e19324c66c1caadcd

Hi, I made the changes, the only I'm not sure is for Content, I put the icon layers


Port ArrayResize to function-arrays subcrate

Is your feature request related to a problem or challenge?
ArrayResize function needs to be ported to new function-arrays subcreate in terms of https://github.com/apache/arrow-datafusion/issues/9285.
Describe the solution you'd like
Port ArrayResize to function-arrays subcrate
Describe alternatives you've considered
No response
Additional context
No response

take


About "Your requirements could not be resolved to an installable set of packages"

Hello good afternoon all right ?
As images I can not install your module in Magento 2.3, can you help me?

	Your requirements could not be resolved to an installable set of packages.

	  Problem 1
		- ultimatemodulecreator/umc-base dev-master requires magento/framework 100.*.* -> satisfiable by magento/framework[100.0.2, 100.0.3, 100.0.4, 100.0.5, 100.0.6, 100.0.7, 100.0.8, 100.0.9, 100.1.0, 100.0.10, 100.0.11, 100.1.1, 100.0.12, 100.1.2, 100.1.3, 100.0.13, 100.1.4, 100.0.14, 100.1.5, 100.0.15, 100.1.6, 100.1.7, 100.0.16, 100.0.17, 100.1.8, 100.1.9, 100.0.18, 100.0.19, 100.1.10, 100.1.11, 100.0.20, 100.1.12, 100.1.13, 100.1.14, 100.1.15, 100.1.16].
		- ultimatemodulecreator/umc-base dev-master requires magento/framework 100.*.* -> satisfiable by magento/framework[100.0.2, 100.0.3, 100.0.4, 100.0.5, 100.0.6, 100.0.7, 100.0.8, 100.0.9, 100.1.0, 100.0.10, 100.0.11, 100.1.1, 100.0.12, 100.1.2, 100.1.3, 100.0.13, 100.1.4, 100.0.14, 100.1.5, 100.0.15, 100.1.6, 100.1.7, 100.0.16, 100.0.17, 100.1.8, 100.1.9, 100.0.18, 100.0.19, 100.1.10, 100.1.11, 100.0.20, 100.1.12, 100.1.13, 100.1.14, 100.1.15, 100.1.16].
		- magento/framework 100.1.16 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6|~7.1.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.15 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.14 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.13 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.12 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.20 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.11 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.10 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.19 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.18 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.9 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.8 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.17 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.16 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.7 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.6 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.15 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.5 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.14 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.4 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.13 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.3 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.2 requires php ~5.6.5|7.0.2|7.0.4|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.12 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.1 requires php ~5.6.0|7.0.2|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.11 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.10 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.1.0 requires php ~5.6.0|7.0.2|~7.0.6 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.9 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.8 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.7 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.6 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.5 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.4 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.3 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- magento/framework 100.0.2 requires php ~5.5.0|~5.6.0|~7.0.0 -> your PHP version (7.2.14) does not satisfy that requirement.
		- Installation request for ultimatemodulecreator/umc-base dev-master -> satisfiable by ultimatemodulecreator/umc-base[dev-master].

I'm sorry I sent you to the wrong Repository,


Annotation tasks break old 0.1.0 task behaviour

VSCode Version: 1.13
OS Version: Windows.

Tasks.json
{
  // See https://go.microsoft.com/fwlink/?LinkId=733558
  // for the documentation about the tasks.json format
  "version": "0.1.0",
  "_runner": "terminal",
  "command": "yarn",
  "suppressTaskName": true,
  "isShellCommand": true,
  "echoCommand": true,
  "tasks": [
    {
      "taskName": "clean - clean built content",
      "args": ["run", "clean"],
      "showOutput": "never"
    }, {
      "taskName": "build - build project",
      "args": ["run", "build"],
      "isBuildCommand": true,
      "problemMatcher": ["$tsc"]
    }, {
      "taskName": "copy statics - copy static content to the build",
      "args": ["run", "copystatics"]
    }, {
      "taskName": "lint - check code conventions",
      "args": ["run", "lint"],
      "problemMatcher": ["$tslint5"]
    }, {
      "taskName": "lint & fix - check and fix code conventions",
      "args": ["run", "lint:fix"],
      "problemMatcher": ["$tslint5"]
    }
  ]
}

Steps:

F1 > Run task

Observe: the list only contains one generic yarn task although it should contain 5 tasks.
This is caused by the new feature we added to allow annotating tasks in the tasks.json that come from an extension. To not break to many users we need to address this. I see the following options:

we make the annotation more explicit with a taskAnnotation section.
we make the annotation algorithm more complex. A task only annotates if a extension really contributes a task with the same name or id. If no such task exists we try to treat it as a 0.1.0 task definition.
We officially support a runner attribute: The following combination would be valid:
version: 0.1.0 & (runner: output | runner: terminal) and version: 2.0.0 & runner: terminal). This allows users to use the terminal runner with the old syntax. The 2.0.0 syntax will can be breaking (for example no global task definition, ...) and is only supported with the terminal runner.

@egamma any preferences. I personally would opt for 3 (you suggested this for a different reason end of last week. Should have listened :-)) and then 2. 3 would give us the most flexibility in the future.

@dbaeumer option 3 is also my preference.

To verify take the above tasks.json and change _runner to runner and make sure that F1 > Run Task lists the tasks defined in the tasks.json


Fix image show/edit

We need to ensure the value we push is a bool and not an integer.
Signed-off-by: Stéphane Graber<EMAIL_ADDRESS>

jenkins: please retest

jenkins: retest this please


Change JsonDebugException to Responsable interface

In all other exceptions, when a Response is supposed to be returned, the Responsable interface is used instead of render.
It's a simple small issue that only regards code quality.

Thanks @devdot!


Execute raw query / filter

Is your feature request related to a problem? Please describe.
I want to be able to execute range queries and I noticed this issues https://github.com/elastic/elasticsearch-net/issues/7050 so I tried to find how to execute raw query but, I don't see a way to do it in v8.
Describe the solution you'd like
Can you please add the ability to add raw query / filter like it used to be in previous version so we can easily go around problems like that?
Describe alternatives you've considered
The only alternative so far is to fork the repository.

I think we have to use Transport:
https://github.com/elastic/elasticsearch-net/blob/4ff277ebca2c731c8450f1d537fe175fe12d9edc/src/Elastic.Clients.Elasticsearch/Client/ElasticsearchClient.cs#L83

@abeninski Thanks for your feedback. I have a PR in to implement this fallback option.

@meriturva It's best to ask questions on discuss.elastic.co and not an unrelated issue, as they may be missed. You are correct; there is no specific low-level client, and using Transport directly is the correct option if you want to send raw JSON requests and responses to a cluster.


Cannot use javascript MouseEvent on checkbox button in 4.5

After upgrading from 4.4.1 to 4.5, the checkbox button no longer allows an onclick event on the checkbox. Reverting back to 4.4.1 fixes it. I believe the issue is from the event.preventDefault() (line 163) added in this pull request: https://github.com/twbs/bootstrap/pull/30388.
Here is a repro comparison with checkbox button test1 and regular checkbox test2.
4.4.1 (works): https://www.codeply.com/p/9DhKAgjsCP
4.5: https://www.codeply.com/p/v1lNDIWenF
OS: macOS 10.15.4
Browsers: Chrome 81.0.4044.138, Safari 13.1

I've tried to avoid preventing the event onclick onto the input, as a workarround you could catch the onclick event onto the label instead of the input waiting for the next release


"two fold" -> twofold

"The process of injecting a driver into the kernel is two fold." But correct is "twofold". See:
http://www.dictionary.com/browse/twofold?s=t

Thank you


Benefits of "Connection String" setting over "Application Settings"

While all app settings are encrypted, I can define an app setting for connection string also and refer it from my app using environment variable. Why there is a separate setting for "Connection Strings" and what benefit it offers? Thanks.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 1e25899c-1ed8-7cfc-2c37-73bb010a87f0
Version Independent ID: 8b366c42-43f8-d5eb-b619-b356e75a9916
Content: Configure apps in the portal - Azure App Service
Content Source: articles/app-service/configure-common.md
Service: app-service
GitHub Login: @cephalin
Microsoft Alias: cephalin

@gpj1 Thanks for the feedback! We are currently investigating and will update you shortly.

@gpj1 Thanks for asking question! The basic difference between appsettings and connectionstrings, In .NET 2.0 and above is a connectionString object is an XML node that has specific attributes to set and semantically it refers to a database connection string where as appSettings is just a user-defined key-value pair that allows you to set your application settings and it can be anything that will be used within your website. Also you could use AppSettings key for storing anything that you would like to configure later, without making any changes to the code but ConnectionStrings are used for storing the complete ConnectionStrings. as example - the ConnectionString of SQL Server.
For more details you may refer to https://stackoverflow.com/questions/3055349/what-is-the-difference-between-connectionstrings-and-appsettings

@gpj1 Since We didn’t hear back from you. We will now close this out but if you feel you need more information please just let us know.

Thanks @SnehaAgrawal-MSFT for clarifying. So if I understand this correctly, for a Java app, I don't find any difference between these 2. Please correct me if there is something for java app as well.


Add Turkish language

I translated Strings.resx to Turkish. I compared with completed translations and everything should be fine. Please check and advise if any problem occurs. Thank you.

Thanks for this @fatihmeh ! Sorry for the delay, I'll get that added to the settings options in a moment

The corresponding build is now available here: https://dev.azure.com/fernandreu-public/OfficeRibbonXEditor/_build/results?buildId=1049&view=artifacts&pathAsName=false&type=publishedArtifacts


Always focus the viewerContainer when entering PresentationMode (bug 1787456)

This fixes the regression in bug 1787456, assuming that it should be handled on the PDF.js side.

/botio-linux preview

Don't you think that, in general, the buttons shouldn't steal the focus ?
Anyway, the other buttons grab the focus when they're clicked but the keyboard callbacks are correctly executed, so there is something specifically wrong  with the fullscreen mode.

Don't you think that, in general, the buttons shouldn't steal the focus ?

That might depend on the exact circumstances, since they definitely need to do that when navigation with the keyboard. When using a mouse, I suppose that in general it may or may not be what you want depending on the exact situation.
Trying to handle both the mouse and keyboard correctly may be difficult/messy, I don't really know, so probably not something we want to worry about here (or even at all)...

Anyway, the other buttons grab the focus when they're clicked but the keyboard callbacks are correctly executed, so there is something specifically wrong with the fullscreen mode.

Yes, this is specifically a regression in Firefox related to Fullscreen-mode (as mentioned in the bug). However, based on https://bugzilla.mozilla.org/show_bug.cgi?id=1787456#c6 it seems that we should take this patch since it's very simple and should also safe to uplift.


Replace old google analytics information

Need to replace old measurement_id and api_secret to new google analytic information prior to closing old google analytics collection information

canceling as not used


Support: build time issue

This is more of a support question than an actual issue.
I wanted to adopt css modules, but without webpack, so I wanted to generate the json map to each file, which I could later use to reference the original classesnames.
Now, my original setup was to have a folder, in which there's only one main.less file, which includes everything else in the folder.
Only this main got compiled, which also imported dependencies (like bootstrap grid, variables, etc...)
In order to make css modules work, I need to run the compilation process for each file, and have the files @import their dependencies.
Then I would have the json for each file, and at the end I could just concatenate everything together.
Unfortunately as I suspected this significantly increased build times, from ~200ms to ~2s.
My question is whether there's a better solution to achieve the same?
Am I approaching the problem completely wrong?
Because as it is the impact on dev experience might be too great for me to adopt this otherwise great project. :/

This is a real problem, thank you for the reporting it. I'll think how to make the processing faster. Unfortunately, I have no free time for one or two next months. So, the issue won't be resolved as fast as I would like it to be.

I see, thanks for responding!
I'll think about solutions in the meantime, but unless this is addressed I don't think the solution is viable yet.
Which is probably the reason I don't really hear about css-modules.
Even if I use it through webpack, the same thing would happen.

I have an idea, but I'm not sure it's compatible with the current architecture, or how easy would it be to add.
Could you check it out @outpunk , depending on your opinion I might decide to do a custom implementation instead.
I'll outline the idea using Gulp as an example.
Assume we have something like : gulp.src('./css-modules/**/*').
Now after this, we could have a preprocessing call, which would just add a comment at the top of each css module, something like this: /* === css-module: {"path": "/the/absolute/path/to/the/module.css"} === */
After that, everything can be concatenated and then processed as normal by less/sass whatever.
So now we would have a big css file, with a separator for modules.
Now this plugin as it currently stands, just converts all classes, using the css file's hash.
However if it had these comments, it could instead calculate the hash from comment-to-comment to get the actual module's hash instead of the concatenated one's.
Then instead of a single json argument in getJson, we could receive an array of path/json pairs for further processing.
So in Gulp, it would look like this:

gulp.src('./css-modules/**/*')
    .pipe(cssModulesPreprocess()) // or cssModulesAnnotate
    .pipe(concat('main.css'))
    .pipe(less())
    .pipe(postcss([
        cssModules({
            getStats: function (stats) {
                // `moduleStats` example:
                // [
                //     {
                //         path: 'css-modules/global/avatar.css',
                //         json: { /* some JSON */ }
                //     },
                //     {
                //         path: 'css-modules/home/custom-module.css',
                //         json: { /* some JSON */ }
                //     }
                //     /* etc */
                // ]
            }
        }),
        autoprefixer()
    ]))
    .pipe(gulp.dest('./web/js'));

The hashing could even be done in the preprocessing step, and added to the comment, so that later on it's already available, and you don't have to deal with getting the module string from comment-to-comment.
Rather, you could just read the annotation and apply it to all classes after that until it encounters a different annotation, signaling the beginning of the next module.
Thought?

nvm, I started working on a custom implementation instead

@ZeeCoder did you manage to solve this issue?

Honestly I don't remember what exactly I was trying to achieve, but I've moved on from this styling pattern to import styles on a per-component basis, which sort of goes around this problem.
I'm also not using css-modules as the projects I work on nowadays aren't that complicated in terms of styling that you'd need the unique classname guarantee css-modules gives you.
Just BEM in itself works for me tbh 🤷♂

@ZeeCoder yeah, I’m currently in BEM/SUIT camp myself and it works great, but I’m looking for more isolated approach without too much headeches regarding tooling and methodology. I’m trying to settle on BEM/SUIT naming scheme with CSS Modules benefits.

Well once you start using css modules, you don't need to do BEM at all. Unfortunately I'm not able to comment on whether build time changed at all since. 🤷♂


Remove random read from Fuse IO stress bench

Remove all random read related stuff from Fuse IO stress bench since we don't have a plan for implementing it.

@LuQQiu PTAL. Thanks!

alluxio-bot, merge this please


Files tab is always there

We want to hide the files tab when there are no files

Is this really useful? Maybe it is more confusing if it is hidden

I would find that VERY useful. Our participation rules show a download location which is much easier to mainting via git, so the Files tab is empty and I think having the empty tab is then actually more confusing as it could make some people believe there are no files yet, when actually the download location is explained in the participation text.

@bbearce I assign you to this enhancement if that works for you. It should be quite straightforward to develop.


Fix build failure.

some cleanups
dep updates
sync with SAP GitHub

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: jerome-benoit:x: gochaxYou have signed the CLA already but the status is still pending? Let us recheck it.

Integrated in the angular-11 branch and PR.


IIP support

Just like noflo-runtime-msgflo, would be great to support initial information packets for msgflo-python

Implemented in https://github.com/msgflo/msgflo-python/commit/48233358959ad6b0be733dce011334c1e190d691
Only needed when not running via the coordinator, but when starting the process independently (like a Heroku Procfile).


ValueError: Unknown pipeline: tadgan.json

0.1.5:
Python version: 3.6.2 64 bit (AMD64)
Operating System: Windows 64

Description
when I try to create an Orion object I get the error:
orion = Orion (pipeline = 'tadgan.json')
sample code took from here
although creating an Orion object with such parameters does not give an error
orion = Orion (pipeline = 'tadgan')
where I get a strange warning:

WARNING: tensorflow: From C: PycharmProjects \ test_orion \ venv \ lib \ site-packages \ tensorflow_core \ python \ ops \ resource_variable_ops.py: 1630: calling BaseResourceVariable .__ init__ (from tensorflow.python.ops.resource_variable_ops) with constraint is deprecated and will be removed in a future version.
Instructions for updating:
If using Keras pass * _constraint arguments to layers.

Where can I find a comprehensive up-to-date guide to the library API?
And another question: is the library production ready? Errors like these raise doubts about it.

Hi @Shanginre!
Loading tagan
In the tulog code (medium post), we have a dedicated folder that contains the tadgan.json which you can find here. You can dump the tadgan.json into your working directory and it should run smoothly from there. Or alternatively give your path to the json file orion = Orion(pipeline='/path/to/tadgan.json').
It is not different from using orion = Orion(pipeline='tadgan') except that the hyperparameter settings are different. In this case, you are running the pipeline maintained in the repo here.
Guides
We're working on the documentation of this library extensively right now. You can see the latest documentation here: https://signals-dev.github.io/Orion/. You can find our user guides and API references there as well.
Warnings
The warnings you see can be safely ignored as they do not interfere with the proper behavior of the pipeline. The pipeline will produce the desired output. I also want to emphasize that this is a maintained repo and we're continuously updating it. If you have any trouble, please don't hesitate to raise an issue and reach out
I hope this addresses your concerns, let me know if you have any further questions!

Hi @Shanginre!
Loading tagan
In the tulog code (medium post), we have a dedicated folder that contains the tadgan.json which you can find here. You can dump the tadgan.json into your working directory and it should run smoothly from there. Or alternatively give your path to the json file orion = Orion(pipeline='/path/to/tadgan.json').
It is not different from using orion = Orion(pipeline='tadgan') except that the hyperparameter settings are different. In this case, you are running the pipeline maintained in the repo here.
Guides
We're working on the documentation of this library extensively right now. You can see the latest documentation here: https://signals-dev.github.io/Orion/. You can find our user guides and API references there as well.
Warnings
The warnings you see can be safely ignored as they do not interfere with the proper behavior of the pipeline. The pipeline will produce the desired output. I also want to emphasize that this is a maintained repo and we're continuously updating it. If you have any trouble, please don't hesitate to raise an issue and reach out
I hope this addresses your concerns, let me know if you have any further questions!


Make Apostrophe integer field accept commas

Currently the field only saves the digits up until the commas – 8,637 saves as 8
We can strip the integer of commas before handing it off

This can be fixed in the launder module.
On Wed, Sep 27, 2017 at 2:08 PM, mtthwmnc<EMAIL_ADDRESS>wrote:

Currently the field only saves the digits up until the commas – 8,637
saves as 8
We can strip the integer of commas before handing it off
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/punkave/apostrophe/issues/1029, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAB9fT1KccfRLC-TTfKfIJTEyIKnAuirks5smo8ngaJpZM4PmLTX
.

--
*THOMAS BOUTELL, *SUPPORT LEAD
P'UNK AVENUE |<PHONE_NUMBER>  |  punkave.com


Ruby: Add missing step def for the newest feature - Attach a PDF with a filename

👓 What did you see?

✅ What did you expect to see?

📦 Which tool/library version are you using?

🔬 How could we reproduce it?

Steps to reproduce the behavior:

Install '...' version '...'
Create a file called '....'
Run command '....'
See error '....'

📚 Any additional context?

This text was originally generated from a template, then edited by hand. You can modify the template here.

This is blocked by a chicken and egg scenario where we need to enhance the cucumber-ruby repo with the ability to attach things with a filename.
I'm making some progress but it's likely both things will need merging and/or we'll have some red tests for a while.


⚠ Faculté génie website (prod) has degraded performance

In b1bb615, Faculté génie website (prod) (https://www.usherbrooke.ca/genie/) experienced degraded performance:

HTTP code: 200
Response time: 1171 ms

Resolved: Faculté génie website (prod) performance has improved in 57b775a.


chore: mender.conf update for the Gateway mTLS ambassador

Ticket: None
External Contributor Checklist

🚨 Please review the guidelines for contributing to this repository.

[ ] Make sure that all commits follow the conventional commit specification for the Mender project.

The majority of our contributions are fixes, which means your commit should have
the form below:
fix: <SHORT DESCRIPTION OF FIX>

<OPTIONAL LONGER DESCRIPTION>

Changelog: <USER-FRIENDLY-CHANGE-DESCRIPTION> or <None>
Ticket: <TICKET NUMBER> or <None>

[ ] Make sure that all commits are signed with git --signoff. Also note that the signoff author must match the author of the commit.

Description
Please describe your pull request.
Thank you!

Hey @lluiscampos could you please take a look at this. I am not sure if the solution is update the docs or a mender-client regression. Either way this is the fix that Luis I found.

Hey @lluiscampos could you please take a look at this. I am not sure if the solution is update the docs or a mender-client regression. Either way this is the fix that Luis I found.

I am not sure neither. I asked a review from @alfrunes who wrote this guide and it is up to date with mender-gateway status.

@mender-test-bot cherry-pick to:

hosted


test_browsingContext_create_withUserGesture_eventsEmitted is failing with<EMAIL_ADDRESS>

https://github.com/GoogleChromeLabs/chromium-bidi/pull/2197

The test receives only 4 messages:

browsingContext.contextCreated for about:blank
Command success
browsingContext.domContentLoaded for http://localhost:60517/200
browsingContext.load for http://localhost:60517/200


opt make fragment id in explain get inline with profile

Proposed changes
Nereids assign fragment ID in its own way. The fragment Id in explain is different from the fragment id in profile.
This difference makes trouble to understand profile.
This pr aims to print fragment id in explain the same as that in profile.
Issue Number: close #xxx
Problem summary
Describe your changes.
Checklist(Required)

Does it affect the original behavior:

[ ] Yes
[ ] No
[ ] I don't know

Has unit tests been added:

[ ] Yes
[ ] No
[ ] No Need

Has document been added or modified:

[ ] Yes
[ ] No
[ ] No Need

Does it need to update dependencies:

[ ] Yes
[ ] No

Are there any changes that cannot be rolled back:

[ ] Yes (If Yes, please explain WHY)
[ ] No

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.5 seconds
load time: 436 seconds
storage size:<PHONE_NUMBER>3 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221120074309_clickbench_pr_49273.html

@morrySnow PTAL


Swift3

Updating to swift-3 branch to swift 3 codebase.

Current coverage is 80.82% (diff: 69.44%)

Merging #157 into swift-3 will decrease coverage by 8.01%

@@            swift-3       #157   diff @@
==========================================
  Files            24         26     +2
  Lines           421        485    +64
  Methods           0          0
  Messages          0          0
  Branches          0          0
==========================================
+ Hits            374        392    +18
- Misses           47         93    +46
  Partials          0          0

Powered by Codecov. Last update 3dc5b79...2c68d3d

@jpotts18 @ed-mejia Sorry about the long wait but I got travis to work with swift 3.

Nice work Dave! 🤘
On Oct 5, 2016 12:07 AM, "David Patterson"<EMAIL_ADDRESS>wrote:

Merged #157 https://github.com/jpotts18/SwiftValidator/pull/157.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/jpotts18/SwiftValidator/pull/157#event-812786644, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ACWjqUyyhnU2XoKUTANEDASyPZkRcJuZks5qwz6pgaJpZM4KOcdL
.


C#. Tests are not recognized if put in subfolders of main test folder

I cannot reproduce this, so closing until given an example.


Creation script

@Ayoralol please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
@microsoft-github-policy-service agree [company="{your company}"]

Options:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

@microsoft-github-policy-service agree

(when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.

@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Wrong repo, didnt realise the PR opened to this one and not my forked one


[Objc] Mac tests failure due to assembly missing.

In the Objc branch the tests on the mac fail due to possible some API changes with XM’s runtime:
Failure examples: https://jenkins.mono-project.com/job/embeddinator-4000/492/

Fixed with https://github.com/mono/Embeddinator-4000/commit/f7f9b267d3c4a0041377684ba25968f8b866d015


PutObjectRequest withMetadata() not implemented

https://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/services/s3/model/PutObjectRequest.html#withMetadata-com.amazonaws.services.s3.model.ObjectMetadata-
When I use the PutObjectRequest.builder().metadata(...) and retrieve the object, the metadata is empty.

The PutObjectRequest.builder().metadata(...) method sets the user-defined object metadata. Hope this PR could resolve this issue.

Fantastic - that seems to do what we need. Thanks for the fast turnaround. Once you have released a version containing that code, we can close this issue.


SpdxTool Version information added to SBOM Creator should strip commit hash

SpdxTool is adding the following to the creator Tool: DemaConsulting.SpdxTool1.4.0+f64493d4757222b30e62f46b4ca98c1491604ae3

Closing for now as the additional githash may be useful


vue-router 4.2.0 breaks vue-tsc

I have project with vue 3.3.1, vue-router 4.1.6, vuetify 3.2.4 and vue-tsc 1.6.4 (same with 1.7.1). I get this https://github.com/vuejs/language-tools/issues/3122 but everything else is fine.
When I upgrade vue-router to 4.2.0, all the vuetify components errors with Property 'VBtn' does not exist on type 'Pick<IntrinsicElements, "div"> & Pick<{ $: ComponentInternalInstance; $data: {}; $props: { key?: string | number | symbol | undefined; ... 18 more ...; "onUpdate:sessionClip"?: ((sessionClip: SessionClipRequest | null) => any) | undefined; }; ... 10 more ...; $watch<T extends string | ((...args: any) => any)>(source...'.
I don't think it's a vuetify issue, but I'm not sure how to check what's happening here.

Reproduction: https://stackblitz.com/edit/vitejs-vite-iefwye
vue-router v4.2.0 augments ComponentCustomOptions via declaring vue while I (or other libraries) augment this interface with @vue/runtime-core. Then this error happens.


FIX Sessions must be destroyed on logout

Sessions must be destroyed on log out. Currently they are retained and just the "logged in user" identifier is removed.
See: https://www.owasp.org/index.php/Session_Management_Cheat_Sheet#Logout_Button
This is a regression from the new auth work (#6829)

See also https://github.com/silverstripe/silverstripe-framework/issues/6320. I’m not sure it should be up to SessionAuthenticationHandler to decide that everything in the session must be destroyed with no way of opting out of that behaviour - the session can be used as a store for non-sensitive data.
It could be argued that if you add something sensitive to the session manually then you also need to make sure it’s removed when appropriate, rather than assuming that it will disappear when the user logs out. Of course we need to weigh that against the “secure by default” argument, which is about as heavy an argument as it’s possible to get.
I’m leaning towards merging but keen to hear what others think.

I think nothing has changed regarding the comments in #6320
If you need to retain some information after hitting logout (you shouldn't - logging out is analogous to starting a brand new session), then you can preserve this through an extension by making use of onbefore/after logout hooks.

@kinglozzer regarding your points, I understand your thinking but it's not quite right. It is exactly the responsibility of SessionAuthenticationHandler to assume the entire session is sensitive and not to be shared. It doesn't make much sense that if I log out that the session state I built up should then be passed onto the next user to login or use the site after me. Just because this data isn't sensitive doesn't mean it should be shared with others.
I don't agree that if you add something sensitive to the session you're responsible for its removal, standard practice is to destroy sessions when users logout and devs should be able to rely upon that behaviour.

I'm wondering here... the session should be destroyed no matter what AuthenticationHandler is being used... maybe there's somewhere more central we should be destroying the session on logout...

Whoops, those tests are broken.

@dhensby ,move it to RequestAuthenticationHandler instead; It's the parent to SessionAuthenticationHandler. That is the main entry point to "logout" actions.

Oh, let's use restart; It destroys the session, and restarts a new one (so the application can continue).

Oh look I found out that BasicAuth hasn't been working properly, due to bad test design. =(

Shifted ->destry() to ->restart(), and fixed up BasicAuth at the same time (since those all regressed).

Rebased


Encoding on connected peers is wonky

This is a cross-post of https://github.com/OpenBazaar/openbazaar-go/issues/1045 for visibility.

Fixed on the server.


Create manifest wizard

I want a wizard to aid in the creation of a manifest.

Initially this could work like the PowerShell script in the Tools directory. The longer term vision would be depending on the installer type.
If I have an MSIX installer, it likely contains the majority of the metadata so a user wouldn't have to provide much more than the URL to the installer.

We are working on this tool now. It accepts a URL and optionally an existing package ID. It will also take GitHub credentials to create the fork, and submit the PR.

We are working on this tool now. It accepts a URL and optionally an existing package ID. It will also take GitHub credentials to create the fork, and submit the PR.

Here is the link to the new wingetcreate tool designed to help build manifests. The PR is in progress so soon you will be able to winget install wingetcreate.


Fixes https://github.com/dtolnay/cxx/issues/88

This commit reworks how files are placed so that anyone who overrides
CARGO_TARGET_DIR or the associated cargo config setting will be able
to use the crate. It is a breaking change because the cargo manifest
directory is now included by default, not the directory that is the
parent of the target directory. It also places the rust/cxx.h file in
$OUT_DIR/cxxbridge instead of inside of $TARGET_DIR/cxxbridge.
This also removes the need to symlink it.

@dtolnay I'd appreciate you looking at this. We use a docker container with the target directory set to /target which is mapped to the host, so it isn't where the current cxx crate can use it and run successfully. It can't even get the demo to build. This makes it so that anyway a target directory is set will work. It also makes it so that includes can be relative to the workspace or to the manifest directory, which may be too permissive, but feels a lot more intuitive to me (I have no c++ experience) especially for crates that have all the c++ code embedded in them that is being used to interface with a library.

+1 on this - I have a local hack to do the same thing for integration with another C++ build system in a totally separate build directory tree.

After a little bit of testing, this works with cargo run, however when I run cargo test it complains that the cxx functions aren't being provided. (The project I'm using this on is cross-compiling, but it was working fine with my branch.)
As a side note, the generated code still has #ifndef CXXBRIDGE03_TYPE_CxxType

cxx-build 0.4.0 definitely shouldn't be writing output containing CXXBRIDGE03_TYPE_{Type}. That was changed to CXXBRIDGE03_STRUCT_{Type} in 57003b0e78e240315fa12742fd42a252d3da7206, and then CXXBRIDGE04_STRUCT_{Type} in https://github.com/dtolnay/cxx/commit/591dcb647d711d252519c61249116c13f06a3fa1#diff-9b5e6af74d9c67d96e5c6429528e3233L316-L322, which are both in 0.4.0 (https://github.com/dtolnay/cxx/blob/0.4.0/gen/src/write.rs#L319).
Could you try cargo clean followed by cargo test?

If that doesn't fix it: when you "say cxx functions aren't being provided", can you be more specific about which ones? Is it functions and types defined by the rust/cxx.h header, or is it ones related to the functions in your cxx::bridge module? Are they missing when the C++ compiler runs or when the linker runs?

I was able to reproduce the issue and I see what's failing, stay tuned for 0.4.1.

I didn't run cargo clean, but I have removed all generated code several times and I'm guessing you found that rust is expecting cxxbridge04$func and it is being defined as cxxbridge03$func in the <crate>/src/lib.rs.cc file?

That's still old generated code if it contains cxxbridge03. I think the problem was something different (fixed by a55c39460fac5e6b4c96c2b2414eaf2928c43809). I published cxx-build 0.4.1 -- could you check whether things work following a cargo update?
If not, would you be able to share:

What target you are building on and cross compiling for?
As much of the error message as you are able to share?

It works on 0.4.1 and probably did on 0.4.0 since I forgot to update the build dependency which explains what I was seeing, however I'm glad you found the other bug.


Crashed when using Portable teleporter

I crashed when I used a portable teleporter to someone else's base(server). Is that mekanism issue? Crashlog: http://pastebin.com/P1N5eNmG
EDIT: It could've been the resource pack I had, had Mekanism7 GUI in it.

Update to the latest Mekanism, this was indeed an issue on my end.


about examples.

example:https://www.mapbox.com/blog/geotaggers-world-atlas/.data is png format, not mvt?

The underlying data is vector tiles, but it is being rendered to bitmaps by the Mapbox tile servers. I should make a Mapbox GL style for the same data.

It's now a Mapbox GL style, from the same vector tiles.

excuse me, i want to know how to convert mvts into pngs,do you konw how?

I haven't tried it myself, but https://github.com/mapnik/node-mapnik/issues/346#issuecomment-62632193 contains an example of a Mapnik script that reads a vector tile and writes it out as a JPEG.


Duplicate action in floating menu

Hi;
I have a very slight problem, my smartphone (Google Pixel 6 pro) is under GrapheneOS, in fact, I have no google service installed, so I don't normally have a translation service in the floating menu when I select a text.
What is great is that Deepl totally replaces google when calling the "translate" action, but it creates a duplicate in the floating menu (I attach a screenshot)
Here the "translate" button (Traduire in french) which uses Deepl (instead of google translate)

The second button, useless without the google services

Would it be possible to add an option to hide the "Deepl" action to keep only "translate" in the floating menu?
(they both lead to Deepl)
Thanks a lot in any case, this is the safest and easiest way to have a privacy friendly translation service, it's wonderful 💘

Thank you very much, the new parameter works perfectly, thank you for solving this little problem


Option to make task list text wrapped in a label

It would be great to have an option of adding a  element which wraps the task list text. Example html of that would be:

  <input id="checkbox1" class="task-list-item-checkbox" type="checkbox">
  checkbox text

This may be hard I am not sure but it would make this plugin the ultimate task list plugin.
P.S. Maybe you could take the implementation idea from https://github.com/mcecot/markdown-it-checkbox where this is the default behavior.
Thanks in advance.

I'm trying to keep the scope of this plugin pretty small overall, but I think adding a  could be unobtrusive enough.
However, if I have to start calculating unique element IDs, then it requires a lot more work because I have to process the entire markdown document's token list. Would it be sufficient for your case if the  element actually wrapped the <input>?

        <input class="task-list-item-checkbox" type="checkbox">

Should do the same thing from a UX perspective, without the extra computation.
If that works for you, I can add support for a {label: true} option.

Yeah absolutely.
Just for clarification you would put the task-list-item text inside the label right? This will also include bold, links, etc?

        <input class="task-list-item-checkbox" type="checkbox">
        list item text link

ok, this is published in 1.4.0. Please test and reopen if you have issues. Thanks!

Just tried it out and everything works perfectly. Thanks a lot for the help. You are awesome.


fix bug #5105 yarn state is FINISHED，but FinalStatus is UNDEFINED，will cause task still in running

fix [Bug][Common] when yarn state is FINISHED，but FinalStatus is UNDEFINED，will cause task can not stop ,will still in running #5105

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:

Codecov Report

Merging #5106 (9a0f25f) into dev (91c29e6) will decrease coverage by 0.05%.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##                dev    #5106      +/-   ##
============================================
- Coverage     47.21%   47.15%   -0.06%
+ Complexity     3683     3682       -1
============================================
  Files           570      570
  Lines         23909    23913       +4
  Branches       2751     2752       +1
============================================
- Hits          11288    11277      -11
- Misses        11587    11604      +17
+ Partials       1034     1032       -2

Impacted Files
Coverage Δ
Complexity Δ

.../org/apache/dolphinscheduler/common/Constants.java
81.81% <ø> (ø)
1.00 <0.00> (ø)

...che/dolphinscheduler/common/utils/HadoopUtils.java
27.80% <25.00%> (-0.06%)
21.00 <0.00> (ø)

...olphinscheduler/rpc/remote/NettyClientHandler.java
41.86% <0.00%> (-9.31%)
7.00% <0.00%> (ø%)

...er/master/dispatch/host/assign/RandomSelector.java
77.77% <0.00%> (-5.56%)
3.00% <0.00%> (-1.00%)

...inscheduler/service/zk/CuratorZookeeperClient.java
70.73% <0.00%> (-4.88%)
9.00% <0.00%> (-1.00%)

...eduler/server/worker/runner/TaskExecuteThread.java
58.53% <0.00%> (-4.88%)
13.00% <0.00%> (-1.00%)

...er/master/processor/queue/TaskResponseService.java
67.12% <0.00%> (-4.11%)
8.00% <0.00%> (ø%)

...dolphinscheduler/service/zk/ZookeeperOperator.java
40.19% <0.00%> (+3.92%)
16.00% <0.00%> (+2.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c29e6...9a0f25f. Read the comment docs.

@597365581 Hi, sorry for too late to review, could you please pass the SonarCloud Code Analysis at first? Thanks for you contribution!

This pr will be closed because no update for a long time.


docs(cookbook - aot compiler)

This is a WIP - do not merge.
The prose and sample are ready, but there are some challenges with e2e and node_modules that I have to figure out.
For some reason I can only get this to work if I install node_modules directly in the sample. Symlinking to the shared node_modules folder does not work.

Alex has fixed the issue in tsc-wrapped that caused problems with symlinked node_modules

This cookbook is now ready for review.
The basic idea behind this cookbook is to show a simple application where we do AOT and rollup based tree shaking.
@wardbell @robwormald

Run the sample using npm run build:aot && npm run lite

Spoke with @robwormald . We should definitely incorporate the closure compiler into this instead of using babel. The potential improvements from switching could be significant.

I think it is important to show JIT and AOT for the same sample. Start with JIT working, then show it working for AOT. index.html, main.ts and tsconfig.json are different for JIT vs AOT.
Also, we should show module.id in the source files for these samples because JIT needs it, and with AOT we can fake it.

Here is my feedback after reading it:

We should make this guide to work with the Quickstart. I tried and it works, it just needs some tweaks:

The number of dependency to install coming from a quickstart project.
Where are the aot stuff generated. (I get it at /aot and not /app/aot)
Most problematic is having to modify the index.html to use the bundle.js

The prose itself is good, but I feel like it is too rushed in some parts, like wanting to make it as small as possible but not explaining some stuff:

It is missing all the rollup dependencies (rollup, the plugins, the babel es2015...).
In the Rollup section you talk about tsconfig and I feel like that should be in its own section.

Also I would put an snippet showing the tsconfig more immediately than forcing the user to scroll down to see the final result.

I don't like how the Rollup section is structured. You show the final rollup.js and then you start explaining the plugins like if it were "something extra to add" and well, it isn't.

On this latter point, I would personally explain what is rollup, why we want it, create a basic rollup.js (where you explain the default export) and then you explain the plugins and then you show the entire file.
One important step that is completely missing is: Ok, I have the rollup.js now what? How is that connected to my app because you mention a dist/build.js that I don't have. So you need to explain how to run rollup.
I learnt a lot in here, but I feel like the different sections are loosely connected and there is some gaps in the prose. Also, te example is not really an example, is just theory.
I would say to get the quickstart, perhaps add some basic heroes' code (to show something, you know) and from there create a story, where we have our app, we explain the JiT vs AoT (that you did nicely) and from there we explain step by step (with snippets, instructions) how can we get our application from the quickstart to use AoT. Installing all the dependencies we don't have already (we assume that we will have TS 2 and @types), explain why we need them, show them how this ngc works, the tree shaking... Once we are there, we install all the rollup dependencies, we create the file with the proper explanations, we explain how to run it and lastly, we use that build to run our app.
On the other hand, I guess that we would need more content / cookbooks to explain AoT with lazy loading and other advanced topics.

@johnpapa

Before we tell them to run ngc it may be good to have them set the gen folder so the files do not go side by side.

I totally agree. We can show this after the tsconfig.json configuration.

I think it is important to show JIT and AOT for the same sample. Start with JIT working, then show it working for AOT. index.html, main.ts and tsconfig.json are different for JIT vs AOT.

If we go the quickstart path, the user should be familiar enough with JiT to having to show it yet again.

@robwormald I converted to use the Closure compiler and removed the dependency on Babel. Closure integration with Rollup works for this simple sample, but I have seen a few issues in larger projects. Basically I've seen the process either run out of memory or hang. Would appreciate any feedback on whether or not the Closure code is correct.

small nitpick -- per dev guide editing recommendations, could we use "just-in-time (JiT) compiler" and "ahead-of-time (AoT) compiler" please? I'll make the change if it's a pita... let me know.
@kwalrath

@naomiblack No problem. I will sweep the doc for that change

We have not had time to incorporate all of the excellent suggestions. We need to factor them into a revision.
More importantly, I have not been able to get the sample to work AND there are some small disconnects between the instructions (e.g., what packages to install) and the text. I'm hoping those can be ironed out in the morning.
Finally, I am concerned that the presence of example-config.json will cause our tooling to accidentally wipe out one or more files (e.g., package.json). This seems a bit fragile.
All of that said, we intend to merge this tomorrow morning even if in its present state. Hoping someone can fix a few things before we do. We will certainly improve it soon.

@wardbell Where did the sample break?
I did a clean npm and it worked for me:
After npm install I do the following:
From the cb-aot/ts folder I run 1) npm run build:aot 2) npm run lite
@Foxandxss Do you have time to give it a try to see if it works for you?

I made some changes of my own, so please double check it.
Important bits are:

I removed the compiler from the dependencies to install (it exist already) and instead of doing --save-dev I do --save only.
Changed the rollup stuff to --save only too.

Our package.json is a bit of a mess right now. In a good world, we would have all the dependencies needed to do a build in dependencies and the ones not needed for a build at devDependencies. Since all the rollup & AoT stuff is needed for build, it is better to save it there.
At the moment we have typescript in the devDependencies and it should be on dependencies too, but that is a sweep for another day.

Ah, I tested it. Works like a charm and the es5 target is a brilliant idea @wardbell