Bug when using multiprocessing

System Info
python: 3.10.12
torch: 2.1.1
accelerate: 0.20.3 -> 0.25.0

Information

[ ] The official example scripts
[x] My own modified scripts

Tasks

[ ] One of the scripts in the examples/ folder of Accelerate or an officially supported no_trainer script in the examples folder of the transformers repo (such as run_no_trainer_glue.py)
[x] My own task or dataset (give details below)

Reproduction
Translation: When I upgraded the version of accelerate from 0.20.3 to 0.25.0, I encountered issues with multiprocessing:

When starting a process using the spawn method of multiprocessing, the process can run inference normally.
When starting two identical processes using the spawn method of multiprocessing, an error occurs.

Considering that it works normally when I roll back the version to 0.20.3, it should not be a problem with torch.
Exception:
CUDA call failed lazily at initialization with error: device >= 0 && device < num_gpus INTERNAL ASSERT FAILED at "../aten/src/ATen/cuda/CUDAContext.cpp":50, please report a bug to PyTorch. device=1, num_gpus=^A

CUDA call was originally invoked at:

  File "<string>", line 1, in <module>
  File "/usr/lib/python3.10/multiprocessing/spawn.py", line 116, in spawn_main
    exitcode = _main(fd, parent_sentinel)
  File "/usr/lib/python3.10/multiprocessing/spawn.py", line 125, in _main
    prepare(preparation_data)
  File "/usr/lib/python3.10/multiprocessing/spawn.py", line 236, in prepare
    _fixup_main_from_path(data['init_main_from_path'])
  File "/usr/lib/python3.10/multiprocessing/spawn.py", line 287, in _fixup_main_from_path
    main_content = runpy.run_path(main_path,
  File "/usr/lib/python3.10/runpy.py", line 289, in run_path
    return _run_module_code(code, init_globals, run_name,
  File "/usr/lib/python3.10/runpy.py", line 96, in _run_module_code
    _run_code(code, mod_globals, init_globals,
  File "/usr/lib/python3.10/runpy.py", line 86, in _run_code
    exec(code, run_globals)
  File "main.py", line 5, in <module>
    import torch.multiprocessing
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 992, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/local/lib/python3.10/dist-packages/torch/__init__.py", line 1332, in <module>
    _C._initExtension(manager_path())
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/usr/local/lib/python3.10/dist-packages/torch/cuda/__init__.py", line 244, in <module>
    _lazy_call(_check_capability)
  File "/usr/local/lib/python3.10/dist-packages/torch/cuda/__init__.py", line 241, in _lazy_call
    _queued_calls.append((callable, traceback.format_stack()))

Expected behavior
Newer version of accelerate working normally under multiprocessing.

Hi @ttbachyinsda , can you provide a minimal reproducer ?

Hi @ttbachyinsda , can you provide a minimal reproducer ?
Thank you for your reply, I am currently working on making a minimal reproducer.
And I have a question: is transformers==4.31.0 compatible with accelerate==0.25.0?


chatall: init at 1.51.79

Description of changes
https://github.com/sunner/ChatALL
Things done

Built on platform(s)

[x] x86_64-linux
[ ] aarch64-linux
[ ] x86_64-darwin
[ ] aarch64-darwin

[ ] For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
[ ] Tested, as applicable:

NixOS test(s) (look inside nixos/tests)
and/or package tests
or, for functions and "core" functionality, tests in lib/tests or pkgs/test
made sure NixOS tests are linked to the relevant packages

[ ] Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
[x] Tested basic functionality of all binary files (usually in ./result/bin/)
23.11 Release Notes (or backporting 23.05 Release notes)

[ ] (Package updates) Added a release notes entry if the change is major or breaking
[ ] (Module updates) Added a release notes entry if the change is significant
[ ] (Module addition) Added a release notes entry if adding a new NixOS module

[x] Fits CONTRIBUTING.md.

Forced it to think it's packaged and in production (similar to how it's done in youtube-music), so the message is gone now.

I'm surprised the "Help" menu is empty though. Is that expected for this program?

I don't know the reasons why it's like that, but I just checked their AppImage, and it's the same there.


Suggestion: Keep Examine option if entity has no other options [No Examine]

I love this plugin for reducing the noise in the right click menu. One reason I sometimes disable it is when I am curious what something is, but it has no interaction options. For example: decorative Objects like flowers and decorative NPCs like little rabbit or other critters.
I would love if there is a config option (similar to the checkboxes for NPCs & Objects) that can allow leaving the Examine option if an NPC or Object has no other options. Preferably a separate checkbox for each, as I would like this for NPCs but I would probably not care for Objects.

This was added in plugin version 1.5 as config options Keep lonely NPC examines and Keep lonely object examines

Thank you!! awesome I love it <3


Keyboard focus is lost after clicking in map viewport

Keyboard navigation functions as expected if the user has clicked on an openlayers control, but upon clicking on the map canvas itself, the keyboard pan/zoom shortcuts no longer function.
Steps to reproduce:

Load an openlayers demo. (http://openlayers.org/en/v3.13.0/examples/regularshape.html works)
Click a zoom button in or out.
Pan/zoom around using keyboard arrow keys and +/-
Click on the map content itself.
Attempt to pan/zoom using keyboard shortcuts.

It looks like the way to fix this behavior is to give a tabIndex to the canvas, otherwise the canvas is not focusable by default. http://stackoverflow.com/questions/1829586/how-do-i-give-an-html-canvas-the-keyboard-focus-using-jquery
I've tested this in my project and on the example page, and it seems to give the desired result. Perhaps tabIndex for the canvas should be a configurable property at map creation time, since it could create problems to assume a value for it, putting it in the middle of someone's tabbing order.

It works with the accessible example

Oh, hrm. Didn't realize you could set the tabindex on the parent div and get the same effect. Since you can get this working without reaching in and modifying the canvas created by OL, I guess this isn't really an issue. My mistake. Thanks.


force user to use node 8.x to use util.promisify

since 8.x is the LTS version for node, why not change the promisify function to require('util').promisify

@aelbore — What would be the benefit from a user's perspective? I'm guessing some people still use node v6. What would be the benefit of forcing them to use node v8? Thanks in advance!

@jvandemo i notice that your using promisify to make the fs.readfile to promise, and also since node v8 is the LTS version in a few months theres no support for v6.
async/await to make code shorter.

@jvandemo by the way i got lightweight cli to bundle angular as a package. you might consider this also.
https://github.com/ngx-devtools/cli
or just npm install -g @ngx-devtools/cli
then ngx run bundle
thanks.

I wouldn't see any problems about dropping the support for node v6

@aelbore — Would you be interested in creating a PR to update the code to node v8? Thanks!

@jvandemo sure will create a PR :)


BREAKING CHANGE: xSQLServer: Implement all suggested fixes from issue 851

Pull Request (PR) description
This pull request includes renaming of all resources as suggested in Issue 851, which also satisfies Issue 713.
The work for Issue 308 has not been implemented, although this would be a good time to do it, to minimize churn.
See the table at the beginning of Issue 851 for a detailed list of changes.
Test results are available in AppVeyor.  Not that I had to temporarily rename my fork in order for the test automation to work, based on discussion that this project would be renamed if this PR is accepted by maintainers.
Look forward to discussing in Community Call on 11/8.
This Pull Request (PR) fixes the following issues:
Fixes #851
Fixes #713

Task List:

[ ] Change details added to Unreleased section of CHANGELOG.md?
[ ] Added/updated documentation, comment-based help and descriptions in .schema.mof files where appropriate?
[ ] Examples appropriately updated?
[ ] New/changed code adheres to Style Guidelines?
[ ] Unit and (optional) Integration tests created/updated where possible?

This change is

Codecov Report

Merging #902 into dev will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##            dev   #902   +/-   ##
===================================
  Coverage    96%    96%
===================================
  Files        32     32
  Lines      3508   3508
===================================
  Hits       3388   3388
  Misses      120    120

@johlju, @mgreenegit
I thought we were going to use Pascal Case in the resource name per our discussion in #851. It should be SqlServerDsc as opposed to SqlServerDSC.

@randomnote1 Yes, I think we concluded that. I will make a review comment on that.
@randomnote1 you are more than welcome to help review this one. 😄

Yeah, I started. I asked because I didn't want to comment on each line with the resource name unless I had to :)

Reviewed 1 of 383 files at r1.
Review status: 1 of 199 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

CONTRIBUTING.md, line 1 at r1 (raw file):

# Contributing to SqlServerDSC

Should be SqlServerDsc per #851

CONTRIBUTING.md, line 3 at r1 (raw file):

# Contributing to SqlServerDSC

If you are keen to make SqlServerDSC better, why not consider contributing your work

Should be SqlServerDsc per #851

CONTRIBUTING.md, line 13 at r1 (raw file):

so please review these as a baseline for contributing.

## SqlServerDSC specific guidelines

Should be SqlServerDsc per #851

CONTRIBUTING.md, line 35 at r1 (raw file):

[Microsoft life cycle site](https://support.microsoft.com/en-us/lifecycle/search?alpha=SQL%20Server).

### Naming convention

Can we add the naming convention structure from the first comment in #851?
<Module Identifier>[<Component>][<Action>]<Scope>{<Feature> | <Property>}

CONTRIBUTING.md, line 283 at r1 (raw file):

`Write-Verbose` and `Write-Warning`, and also for creating a terminating error
message.
The localized strings are placed in a file named 'SqlServerDSCHelper.strings.psd1'

Should be SqlServerDscHelper per #851

CONTRIBUTING.md, line 308 at r1 (raw file):

be used by more than
one resource, then the functions can also be placed in the common
[SqlServerDSCHelper.psm1](https://github.com/PowerShell/xSQLServer/blob/dev/SqlServerDSCHelper.psm1)

Should be SqlServerDscHelper per #851

CONTRIBUTING.md, line 343 at r1 (raw file):

Before the test runs in AppVeyor the module will be copied to the first path of
`$env:PSModulePath`.
To run this test locally, make sure you have the SqlServerDSC module

Should be SqlServerDsc per #851

CONTRIBUTING.md, line 349 at r1 (raw file):

#### Using SMO stub classes

There are [stub classes](https://github.com/PowerShell/SqlServerDSC/blob/dev/Tests/Unit/Stubs/SMO.cs)

Should be SqlServerDsc per #851

Comments from Reviewable

Review status: 1 of 199 files reviewed at latest revision, 22 unresolved discussions, some commit checks failed.

README.md, line 1 at r1 (raw file):

# SqlServerDSC

Should be SqlServerDsc per #851

README.md, line 3 at r1 (raw file):

# SqlServerDSC

The **SqlServerDSC** module contains DSC resources

Should be SqlServerDsc per #851

README.md, line 15 at r1 (raw file):

### master

[![Build status](https://ci.appveyor.com/api/projects/status/mxn453y284eab8li/branch/master?svg=true)](https://ci.appveyor.com/project/PowerShell/xsqlserver/branch/master)

Update to SqlServerDsc

README.md, line 16 at r1 (raw file):

[![Build status](https://ci.appveyor.com/api/projects/status/mxn453y284eab8li/branch/master?svg=true)](https://ci.appveyor.com/project/PowerShell/xsqlserver/branch/master)
[![codecov](https://codecov.io/gh/PowerShell/xSQLServer/branch/master/graph/badge.svg)](https://codecov.io/gh/PowerShell/xSQLServer/branch/master)

Update to SqlServerDsc

README.md, line 23 at r1 (raw file):

### dev

[![Build status](https://ci.appveyor.com/api/projects/status/mxn453y284eab8li/branch/dev?svg=true)](https://ci.appveyor.com/project/PowerShell/xsqlserver/branch/dev)

Update to SqlServerDsc

README.md, line 24 at r1 (raw file):

[![Build status](https://ci.appveyor.com/api/projects/status/mxn453y284eab8li/branch/dev?svg=true)](https://ci.appveyor.com/project/PowerShell/xsqlserver/branch/dev)
[![codecov](https://codecov.io/gh/PowerShell/xSQLServer/branch/dev/graph/badge.svg)](https://codecov.io/gh/PowerShell/xSQLServer/branch/dev)

Update to SqlServerDsc

README.md, line 46 at r1 (raw file):

* If you want to submit an issue or take part in discussions,
  please browse the list of [issues](https://github.com/PowerShell/xSQLServer/issues).

Update to SqlServerDsc

README.md, line 51 at r1 (raw file):

* If you want to review pull requests,
  please first check out the [Review Pull Request guidelines](https://github.com/PowerShell/DscResources/blob/master/CONTRIBUTING.md#reviewing-pull-requests),
  and the browse the list of [pull requests](https://github.com/PowerShell/xSQLServer/pulls)

Update to SqlServerDsc

README.md, line 58 at r1 (raw file):

  * The [Contributing to the DSC Resource Kit](https://github.com/PowerShell/DscResources/blob/master/CONTRIBUTING.md)
    guidelines.
  * The specific [Contributing to xSQLServer](https://github.com/PowerShell/xSQLServer/blob/dev/CONTRIBUTING.md)

Update to SqlServerDsc

README.md, line 77 at r1 (raw file):

To manually install the module,
download the source code and unzip the contents
of the '\Modules\SqlServerDSC' directory to the

Should be SqlServerDsc per #851

README.md, line 84 at r1 (raw file):

```powershell
Find-Module -Name SqlServerDSC -Repository PSGallery | Install-Module

Should be SqlServerDsc per #851

README.md, line 91 at r1 (raw file):

```powershell
Get-DscResource -Module SqlServerDSC

Should be SqlServerDsc per #851

README.md, line 103 at r1 (raw file):

## Examples

You can review the [Examples](/Examples) directory in the SqlServerDSC module

Should be SqlServerDsc per #851

README.md, line 121 at r1 (raw file):

* [**SqlAlwaysOnService**](#sqlalwaysonservice) resource to enable
  always on on a SQL Server.
* [**SqlAGListener**](#sqlaglistener)

Should be sorted to alphabetical order

Comments from Reviewable

Reviewed 3 of 383 files at r1.
Review status: 3 of 199 files reviewed at latest revision, 23 unresolved discussions, some commit checks failed.

SqlServerDSCHelper.psm1, line 6 at r1 (raw file):

                               -ChildPath 'CommonResourceHelper.psm1')

$script:localizedData = Get-LocalizedData -ResourceName 'SqlServerDSCHelper' -ScriptRoot $PSScriptRoot

Should be SqlServerDscHelper per #851

Comments from Reviewable

Reviewed 11 of 383 files at r1.
Review status: 9 of 199 files reviewed at latest revision, 29 unresolved discussions, some commit checks failed.

Review status: 12 of 199 files reviewed at latest revision, 35 unresolved discussions, some commit checks failed.

Tests/Unit/SqlServerDSCHelper.Tests.ps1, line 7 at r1 (raw file):

'SqlServerDSCHelper'

Should be Pascal Case 'SqlServerDscHelper'. Throughout.

Tests/Unit/Stubs/SMO.cs, line 545 at r1 (raw file):

MSFT_SqlAGDatabaseMembership

Should be 'MSFT_SqlAGDatabases' per issue #851

Tests/Unit/Stubs/SMO.cs, line 700 at r1 (raw file):

SqlServerAG

Should be 'SqlAG' per issue #851

Tests/Unit/Stubs/SMO.cs, line 859 at r1 (raw file):

SqlAGDatabaseMembership

Should be 'SqlAGDatabases' per issue #851

Tests/Unit/Stubs/SMO.cs, line 867 at r1 (raw file):

SqlAGDatabaseMembership

Should be 'SqlAGDatabases' per issue #851

Tests/Unit/Stubs/SMO.cs, line 950 at r1 (raw file):

MSFT_SqlServerServiceAccount.Tests.ps1

Should be 'MSFT_SqlServiceAccount.Tests.ps1' per issue #851

Comments from Reviewable

Reviewed 8 of 383 files at r1.
Review status: 16 of 199 files reviewed at latest revision, 39 unresolved discussions, some commit checks failed.

Tests/Unit/MSFT_SqlServerServiceAccount.Tests.ps1, line 2 at r1 (raw file):

MSFT_SqlServerServiceAccount

Should be 'MSFT_SqlServiceAccount' as per #851

Tests/Unit/MSFT_SqlServerServiceAccount.Tests.ps1, line 3 at r1 (raw file):

$script:DSCModuleName      = 'SqlServerDsc'
$script:DSCResourceName    = 'MSFT_SqlServerServiceAccount'

The filename should be renamed to 'MSFT_SqlServiceAccount' as per #851

Tests/Unit/MSFT_SqlWaitForAvailabilityGroup.Tests.ps1, line 2 at r1 (raw file):

'MSFT_SqlWaitForAvailabilityGroup'

Should be 'MSFT_SqlWaitForAG' as per #851. Throughout.

Tests/Unit/MSFT_SqlWaitForAvailabilityGroup.Tests.ps1, line 3 at r1 (raw file):

$script:DSCModuleName      = 'SqlServerDsc'
$script:DSCResourceName    = 'MSFT_SqlWaitForAvailabilityGroup'

The file name should be renamed to 'MSFT_SqlWaitForAG' as per #851

Comments from Reviewable

Reviewed 28 of 383 files at r1.
Review status: 30 of 199 files reviewed at latest revision, 41 unresolved discussions, some commit checks failed.

Tests/Unit/MSFT_SqlDatabaseRole.Tests.ps1, line 1 at r1 (raw file):

'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Unit/MSFT_SqlScript.Tests.ps1, line 23 at r1 (raw file):

'SqlServerDSC'

This should be 'SqlServerDsc' as per #851

Comments from Reviewable

Reviewed 22 of 383 files at r1.
Review status: 41 of 199 files reviewed at latest revision, 49 unresolved discussions, some commit checks failed.

Tests/Unit/MSFT_SqlAG.Tests.ps1, line 15 at r1 (raw file):

$TestEnvironment = Initialize-TestEnvironment `
    -DSCModuleName 'SqlServerDSC' `

This should be 'SqlServerDsc' as per issue #851

Tests/Unit/MSFT_SqlAGDatabases.Tests.ps1, line 12 at r1 (raw file):

'SqlServerDSCHelper.psm1'

This should be 'SqlServerDscHelper.psm1'

Tests/Unit/MSFT_SqlAGDatabases.Tests.ps1, line 19 at r1 (raw file):

$TestEnvironment = Initialize-TestEnvironment `
    -DSCModuleName 'SqlServerDSC' `

This should be 'SqlServerDsc' as per issue #851

Tests/Unit/MSFT_SqlAGListener.Tests.ps1, line 96 at r1 (raw file):

SqlServerDSCAvailabilityGroupListener

Should be 'SqlAGListener' as per issue #851. Throughout.

Tests/Unit/MSFT_SqlAGReplica.Tests.ps1, line 16 at r1 (raw file):

$TestEnvironment = Initialize-TestEnvironment `
    -DSCModuleName 'SqlServerDSC' `

This should be 'SqlServerDsc' as per issue #851

Tests/Unit/MSFT_SqlDatabaseDefaultLocation.Tests.ps1, line 16 at r1 (raw file):

$TestEnvironment = Initialize-TestEnvironment `
    -DSCModuleName 'SqlServerDSC' `

This should be 'SqlServerDsc' as per issue #851

Tests/Unit/MSFT_SqlDatabasePermission.Tests.ps1, line 1 at r1 (raw file):

$script:DSCModuleName      = 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Unit/MSFT_SqlDatabaseRecoveryModel.Tests.ps1, line 1 at r1 (raw file):

$script:DSCModuleName      = 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Comments from Reviewable

Reviewed 38 of 383 files at r1.
Review status: 60 of 199 files reviewed at latest revision, 69 unresolved discussions, some commit checks failed.

Examples/Resources/SqlSetup/1-InstallDefaultInstanceSingleServer.ps1, line 38 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851.

Examples/Resources/SqlSetup/2-InstallNamedInstanceSingleServer.ps1, line 38 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851.

Examples/Resources/SqlSetup/3-InstallNamedInstanceSingleServerFromUncPathUsingSourceCredential.ps1, line 42 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851.

Examples/Resources/SqlSetup/4-InstallNamedInstanceInFailoverClusterFirstNode.ps1, line 62 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851.

Examples/Resources/SqlSetup/5-InstallNamedInstanceInFailoverClusterSecondNode.ps1, line 58 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851.

Examples/Resources/SqlWaitForAvailabilityGroup/1-WaitForASingleClusterGroup.ps1, line 15 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851.

Examples/Resources/SqlWaitForAvailabilityGroup/1-WaitForASingleClusterGroup.ps1, line 19 at r1 (raw file):

SqlWaitForAvailabilityGroup

This should be 'SqlWaitForAG' as per issue #851. Throughout.

Examples/Resources/SqlWaitForAvailabilityGroup/2-WaitForMultipleClusterGroups.ps1, line 1 at r1 (raw file):

<#

The folder name for this resource examples should be renamed to 'SqlWaitForAG' as per issue #851.

Examples/Resources/SqlWaitForAvailabilityGroup/2-WaitForMultipleClusterGroups.ps1, line 15 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlWaitForAvailabilityGroup/2-WaitForMultipleClusterGroups.ps1, line 19 at r1 (raw file):

SqlWaitForAvailabilityGroup

This should be 'SqlWaitForAG' as per issue #851. Throughout.

sv-SE/SqlServerDSCHelper.strings.psd1, line 1 at r1 (raw file):

SqlServerDSCHelper

This text and the filename should be renamed to 'SqlServerDscHelper'

Tests/SqlServerDSCCommon.Tests.ps1, line 1 at r1 (raw file):

[CmdletBinding()]

The filename should be renamed to 'SqlServerDscCommon'

Tests/SqlServerDSCCommon.Tests.ps1, line 8 at r1 (raw file):

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851. Throughout.

Tests/Integration/MSFT_SqlAlwaysOnService.config.ps1, line 29 at r1 (raw file):

    Import-DscResource -ModuleName 'PSDscResources'
    Import-DscResource -ModuleName 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Integration/MSFT_SqlAlwaysOnService.config.ps1, line 154 at r1 (raw file):

    )

    Import-DscResource -ModuleName 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Integration/MSFT_SqlDatabaseDefaultLocation.config.ps1, line 33 at r1 (raw file):

    Import-DscResource -ModuleName 'PSDesiredStateConfiguration'
    Import-DscResource -ModuleName 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Integration/MSFT_SqlDatabaseDefaultLocation.config.ps1, line 71 at r1 (raw file):

    Import-DscResource -ModuleName 'PSDesiredStateConfiguration'
    Import-DscResource -ModuleName 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Integration/MSFT_SqlDatabaseDefaultLocation.config.ps1, line 109 at r1 (raw file):

    Import-DscResource -ModuleName 'PSDesiredStateConfiguration'
    Import-DscResource -ModuleName 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Integration/MSFT_SqlRS.config.ps1, line 55 at r1 (raw file):

    Import-DscResource -ModuleName 'PSDscResources'
    Import-DscResource -ModuleName 'xStorage'
    Import-DscResource -ModuleName 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Tests/Integration/MSFT_SqlSetup.config.ps1, line 58 at r1 (raw file):

    Import-DscResource -ModuleName 'PSDscResources'
    Import-DscResource -ModuleName 'xStorage'
    Import-DscResource -ModuleName 'SqlServerDSC'

This should be 'SqlServerDsc' as per issue #851

Comments from Reviewable

Reviewed 17 of 383 files at r1.
Review status: 71 of 199 files reviewed at latest revision, 94 unresolved discussions, some commit checks failed.

CHANGELOG.md, line 5 at r1 (raw file):

## Unreleased

- Significant rename to reduce length of Resource names

Could we please expand this a bit explaining that the resource module has been renamed to SqlServerDsc. Also please link to the issue #851 and tell users they can find the resource rename mapping table there.
Could we start the line with 'BREAKING CHANGE:'?

CHANGELOG.md, line 8 at r1 (raw file):

xSQLServer

Should be 'SqlServerDsc'

CHANGELOG.md, line 11 at r1 (raw file):

xSQLServerDatabase

Should be 'SqlDatabase'

CHANGELOG.md, line 13 at r1 (raw file):

- Changes to xSQLServerDatabase
  - Added parameter to specify collation for a database to be different from server
    collation ([issue #767](https://github.com/PowerShell/xSQLServer/issues/767)).

Non-blocking: All these path will need to be changed once the resource module is renamed. But we can do that in a PR after this has been merged and the resource renamed.

CHANGELOG.md, line 16 at r1 (raw file):

xSQLServerAlwaysOnAvailabilityGroup

Should be 'SqlAG'

CHANGELOG.md, line 29 at r1 (raw file):

xSQLServerAlwaysOnAvailabilityGroupDatabaseMembership

Should be 'SqlAGDatabases'

CHANGELOG.md, line 33 at r1 (raw file):

xSQLServerAlwaysOnAvailabilityGroupReplica

Should be 'SqlAGReplica'

CHANGELOG.md, line 40 at r1 (raw file):

xSQLServerMemory

Should be 'SqlServerMemory'

CHANGELOG.md, line 44 at r1 (raw file):

xSQLServerNetwork

Should be 'SqlServerNetwork'.

CHANGELOG.md, line 52 at r1 (raw file):

xSQLServerRSConfig

Should be 'SqlRS'.

CHANGELOG.md, line 55 at r1 (raw file):

xSQLServerDatabaseDefaultLocation

Should be 'SqlDatabaseDefaultLocation'.

CHANGELOG.md, line 57 at r1 (raw file):

xSQLServerEndpointPermission

Should be 'SqlServerEndpointPermission'

CHANGELOG.md, line 60 at r1 (raw file):

xSQLServerAvailabilityGroupListener

Should be 'SqlAGListener'

CONTRIBUTING.md, line 35 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Can we add the naming convention structure from the first comment in #851?
<Module Identifier>[<Component>][<Action>]<Scope>{<Feature> | <Property>}

Agree that we should do this. And then we can expand that later with more text.

README.md, line 133 at r1 (raw file):

#sqlserverrecoverymodel

Should be '#sqldatabaserecoverymodel'

README.md, line 161 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount', and the link as well (but with lower-case).

README.md, line 164 at r1 (raw file):

SqlWaitForAvailabilityGroup

Should be 'SqlWaitForAG', and the link as well (but with lower-case).

README.md, line 1311 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount'

README.md, line 1338 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount'

README.md, line 1339 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount'

README.md, line 1493 at r1 (raw file):

xSQLServer

Should be 'SqlServerDsc'

README.md, line 1501 at r1 (raw file):

SqlWaitForAvailabilityGroup

Should be 'SqlWaitForAG'

README.md, line 1540 at r1 (raw file):

SqlWaitForAvailabilityGroup

Should be 'SqlWaitForAG'

README.md, line 1541 at r1 (raw file):

SqlWaitForAvailabilityGroup

Should be 'SqlWaitForAG'

SQLServerDSC.psd1, line 3 at r1 (raw file):

@{
# Version number of this module.
ModuleVersion = '<IP_ADDRESS>'

Katie changes this version number on release. So keep it as '<IP_ADDRESS>', unless she says differently.

SQLServerDSC.psd1, line 148 at r1 (raw file):

  - Added localization support for all strings
  - Added examples for usage
- Changes to SqlRS

I think we can leave this entire file untouched. These release note will be replace upon release.

Comments from Reviewable

@mgreenegit could you help us by making a search and replace for 'SqlServerDSC' -> 'SqlServerDsc'. It would speed up the review. 😄

Reviewed 148 of 383 files at r1.
Review status: 145 of 199 files reviewed at latest revision, 117 unresolved discussions, some commit checks failed.

DSCResources/MSFT_SqlSetup/MSFT_SqlSetup.psm1, line 2 at r1 (raw file):

SqlServerDSCHelper

Should be 'SqlServerDscHelper'

DSCResources/MSFT_SqlWaitForAvailabilityGroup/MSFT_SqlWaitForAvailabilityGroup.psm1, line 1 at r1 (raw file):

Import-Module -Name (Join-Path -Path (Split-Path (Split-Path $PSScriptRoot -Parent) -Parent) `

The filename and resource folder name should be named 'MSFT_SqlWaitForAG' as per issue #851

DSCResources/MSFT_SqlWaitForAvailabilityGroup/MSFT_SqlWaitForAvailabilityGroup.psm1, line 2 at r1 (raw file):

SqlServerDSCHelper

Should be 'SqlServerDscHelper'

DSCResources/MSFT_SqlWaitForAvailabilityGroup/MSFT_SqlWaitForAvailabilityGroup.schema.mof, line 1 at r1 (raw file):

SqlWaitForAvailabilityGroup

Should be 'SqlWaitForAG' as per issue #851

DSCResources/MSFT_SqlWaitForAvailabilityGroup/MSFT_SqlWaitForAvailabilityGroup.schema.mof, line 1 at r1 (raw file):

[ClassVersion("<IP_ADDRESS>"), FriendlyName("SqlWaitForAvailabilityGroup")]

The filename should be named 'MSFT_SqlWaitForAG' as per issue #851

DSCResources/MSFT_SqlWaitForAvailabilityGroup/MSFT_SqlWaitForAvailabilityGroup.schema.mof, line 2 at r1 (raw file):

MSFT_SqlWaitForAvailabilityGroup

Should be 'MSFT_SqlWaitForAG'.

DSCResources/MSFT_SqlWindowsFirewall/MSFT_SqlWindowsFirewall.psm1, line 2 at r1 (raw file):

SqlServerDSCHelper

Should be 'SqlServerDscHelper'

en-US/SqlServerDSCHelper.strings.psd1, line 1 at r1 (raw file):

SqlServerDSCHelper

Should be 'SqlServerDscHelper', in the text, and also in the filename.

Examples/Resources/SqlAlias/1-AddSqlAlias.ps1, line 15 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlAlias/2-RemoveSqlAlias.ps1, line 15 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlScript/1-RunScriptUsingSQLAuthentication.ps1, line 14 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlScript/2-RunScriptUsingWindowsAuthentication.ps1, line 15 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpoint/1-CreateEndpointWithDefaultValues.ps1, line 16 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpoint/2-CreateEndpointWithSpecificPortAndIPAddress.ps1, line 15 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpoint/3-RemoveEndpoint.ps1, line 16 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpointPermission/1-AddConnectPermission.ps1, line 21 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpointPermission/2-RemoveConnectPermission.ps1, line 21 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpointPermission/3-AddConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1, line 46 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpointPermission/4-RemoveConnectPermissionToAlwaysOnPrimaryAndSecondaryReplicaEachWithDifferentSqlServiceAccounts.ps1, line 46 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpointState/1-MakeSureEndpointIsStarted.ps1, line 24 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerEndpointState/2-MakeSureEndpointIsStopped.ps1, line 15 at r1 (raw file):

    )

    Import-DscResource -ModuleName SqlServerDSC

Should be 'SqlServerDsc' as per issue #851

Examples/Resources/SqlServerServiceAccount/1-ConfigureServiceAccount-UserAccount.ps1, line 18 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount' as per issue #851

Examples/Resources/SqlServerServiceAccount/2-ConfigureServiceAccount-VirtualAccount.ps1, line 1 at r1 (raw file):

<#

Example folder name should be 'SqlServiceAccount' as per issue #851

Examples/Resources/SqlServerServiceAccount/2-ConfigureServiceAccount-VirtualAccount.ps1, line 21 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount' as per issue #851

Comments from Reviewable

Reviewed 118 of 383 files at r1.
Review status: all files reviewed at latest revision, 143 unresolved discussions, some commit checks failed.

DSCResources/MSFT_SqlAlias/MSFT_SqlAlias.psm1, line 1 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlAlwaysOnService/MSFT_SqlAlwaysOnService.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlDatabase/MSFT_SqlDatabase.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlDatabaseDefaultLocation/MSFT_SqlDatabaseDefaultLocation.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlDatabaseOwner/MSFT_SqlDatabaseOwner.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlDatabasePermission/MSFT_SqlDatabasePermission.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlDatabaseRecoveryModel/MSFT_SqlDatabaseRecoveryModel.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlDatabaseRole/MSFT_SqlDatabaseRole.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlRS/MSFT_SqlRS.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlRSSecureConnectionLevel/MSFT_SqlRSSecureConnectionLevel.psm1, line 5 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlScript/MSFT_SqlScript.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerConfiguration/MSFT_SqlServerConfiguration.psm1, line 3 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerEndpoint/MSFT_SqlServerEndpoint.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerEndpointPermission/MSFT_SqlServerEndpointPermission.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerEndpointState/MSFT_SqlServerEndpointState.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerLogin/MSFT_SqlServerLogin.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerMaxDop/MSFT_SqlServerMaxDop.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerMemory/MSFT_SqlServerMemory.psm1, line 1 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerNetwork/MSFT_SqlServerNetwork.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerPermission/MSFT_SqlServerPermission.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerRole/MSFT_SqlServerRole.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerServiceAccount/MSFT_SqlServerServiceAccount.psm1, line 2 at r1 (raw file):

'SqlServerDSCHelper.psm1'

Should be 'SqlServerDscHelper' as per issue #851

DSCResources/MSFT_SqlServerServiceAccount/MSFT_SqlServerServiceAccount.schema.mof, line 1 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount' as per issue #851

DSCResources/MSFT_SqlServerServiceAccount/MSFT_SqlServerServiceAccount.schema.mof, line 2 at r1 (raw file):

MSFT_SqlServerServiceAccount

Should be 'MSFT_SqlServiceAccount' as per issue #851

DSCResources/MSFT_SqlServerServiceAccount/en-US/MSFT_SqlServerServiceAccount.strings.psd1, line 1 at r1 (raw file):

SqlServerServiceAccount

Should be 'SqlServiceAccount' as per issue #851

DSCResources/MSFT_SqlServerServiceAccount/en-US/MSFT_SqlServerServiceAccount.strings.psd1, line 1 at r1 (raw file):

# Localized resources for SqlServerServiceAccount

The folder name should be 'MSFT_SqlServiceAccount' as per issue #851

Comments from Reviewable

@mgreenegit So that you don't need to go a write 'Done' on each review comment, I will withdraw the review comment (which resolves the comment) when I see them been fixed.

Reviewed 1 of 20 files at r4.
Review status: 114 of 199 files reviewed at latest revision, 133 unresolved discussions, some commit checks failed.

CHANGELOG.md, line 5 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could we please expand this a bit explaining that the resource module has been renamed to SqlServerDsc. Also please link to the issue #851 and tell users they can find the resource rename mapping table there.
Could we start the line with 'BREAKING CHANGE:'?

Could we please expand this text a bit explaining that the resource module has been renamed as well?

CHANGELOG.md, line 1 at r4 (raw file):

xSQLServer

This should be SqlServerDsc

Comments from Reviewable

Reviewed 3 of 399 files at r1, 2 of 92 files at r2, 3 of 10 files at r3, 3 of 20 files at r4.
Review status: 120 of 199 files reviewed at latest revision, 121 unresolved discussions, some commit checks failed.

Comments from Reviewable

@mgreenegit just a few more review comments. Please go into Reviewable and write 'Done' on the comments that are left once they are resolved so that I and @randomnote1 can acknowledge them. Thanks!

Reviewed 71 of 399 files at r1, 71 of 92 files at r2, 6 of 10 files at r3, 16 of 20 files at r4.
Review status: all files reviewed at latest revision, 37 unresolved discussions, some commit checks failed.

Tests/Unit/MSFT_SqlAGListener.Tests.ps1, line 96 at r4 (raw file):

SqlServerAGListener

Should be 'SqlAGListener' as per issue #851. Throughout.

Comments from Reviewable

Review status: all files reviewed at latest revision, 38 unresolved discussions, some commit checks failed.

DSCResources/MSFT_SqlAGDatabases/MSFT_SqlAGDatabases.psm1, line 4 at r4 (raw file):

        -ChildPath 'SqlServerDscHelper.psm1') `
    -Force

As per new discussion in issue #851 we should rename this resource to 'SqlAgDatabase' (singular) to align with all other resources.
Would you be up to do this change in this PR as well? If so, all filenames, folder names and references to 'SqlAGDatabases' should be changed to 'SqlAGDatabase'.

Comments from Reviewable

Yep, I’ll get this done tomorrow.

Review status: 188 of 199 files reviewed at latest revision, 38 unresolved discussions.

CONTRIBUTING.md, line 1 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

OK

CONTRIBUTING.md, line 35 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Agree that we should do this. And then we can expand that later with more text.

OK

DSCResources/MSFT_SqlAGDatabase/MSFT_SqlAGDatabase.psm1, line 2 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper.psm1

OK

Comments from Reviewable

Latest build looks good, and includes commit for rename to singular SqlAGDatabase as mentioned above.
https://ci.appveyor.com/project/mgreenegit/sqlserverdsc/build/tests

Review status: 183 of 199 files reviewed at latest revision, 38 unresolved discussions.

CHANGELOG.md, line 5 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
Could we please expand this text a bit explaining that the resource module has been renamed as well?

Done

CHANGELOG.md, line 1 at r4 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

xSQLServer

This should be SqlServerDsc

Done

CONTRIBUTING.md, line 1 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
OK

Done

CONTRIBUTING.md, line 3 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

CONTRIBUTING.md, line 13 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

CONTRIBUTING.md, line 35 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
OK

Done

CONTRIBUTING.md, line 283 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper per #851

Done

CONTRIBUTING.md, line 308 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper per #851

Done

CONTRIBUTING.md, line 343 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

CONTRIBUTING.md, line 349 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

README.md, line 1 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

README.md, line 3 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

README.md, line 15 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Update to SqlServerDsc

Done

README.md, line 16 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Update to SqlServerDsc

Done

README.md, line 23 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Update to SqlServerDsc

Done

README.md, line 24 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Update to SqlServerDsc

Done

README.md, line 46 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Update to SqlServerDsc

Done

README.md, line 51 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Update to SqlServerDsc

Done

README.md, line 58 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Update to SqlServerDsc

Done

README.md, line 77 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

README.md, line 84 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

README.md, line 91 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

README.md, line 103 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDsc per #851

Done

README.md, line 121 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be sorted to alphabetical order

Done

README.md, line 278 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlAGDatabases

Done

SqlServerDscHelper.psm1, line 6 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper per #851

Done

DSCResources/CommonResourceHelper.psm1, line 207 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper

Done

DSCResources/MSFT_SqlAG/MSFT_SqlAG.psm1, line 2 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper.psm1

Done

DSCResources/MSFT_SqlAGDatabase/MSFT_SqlAGDatabase.psm1, line 4 at r4 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
As per new discussion in issue #851 we should rename this resource to 'SqlAgDatabase' (singular) to align with all other resources.
Would you be up to do this change in this PR as well? If so, all filenames, folder names and references to 'SqlAGDatabases' should be changed to 'SqlAGDatabase'.

Done

DSCResources/MSFT_SqlAGListener/MSFT_SqlAGListener.psm1, line 2 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper.psm1

Done

DSCResources/MSFT_SqlAGReplica/MSFT_SqlAGReplica.psm1, line 2 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Should be SqlServerDscHelper.psm1

Done

DSCResources/MSFT_SqlWaitForAG/MSFT_SqlWaitForAG.schema.mof, line 1 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
The filename should be named 'MSFT_SqlWaitForAG' as per issue #851

Done

Examples/Resources/SqlSetup/2-InstallNamedInstanceSingleServer.ps1, line 38 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

SqlServerDSC

This should be 'SqlServerDsc' as per issue #851.

Done

Tests/Integration/MSFT_SqlSetup.config.ps1, line 58 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This should be 'SqlServerDsc' as per issue #851

Done

Tests/Unit/MSFT_SqlAGListener.Tests.ps1, line 96 at r4 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

SqlServerAGListener

Should be 'SqlAGListener' as per issue #851. Throughout.

Done

Tests/Unit/MSFT_SqlDatabaseDefaultLocation.Tests.ps1, line 16 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This should be 'SqlServerDsc' as per issue #851

Done

Tests/Unit/MSFT_SqlDatabaseRecoveryModel.Tests.ps1, line 1 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This should be 'SqlServerDsc' as per issue #851

Done

Comments from Reviewable

Review status: 183 of 199 files reviewed at latest revision, 37 unresolved discussions.

DSCResources/MSFT_SqlAGDatabase/MSFT_SqlAGDatabase.psm1, line 2 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
OK

Done.

Comments from Reviewable

Reviewed 7 of 407 files at r1, 14 of 19 files at r5.
Review status: 190 of 199 files reviewed at latest revision, 38 unresolved discussions, some commit checks failed.

CHANGELOG.md, line 1 at r4 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

Missed this one

CONTRIBUTING.md, line 1 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

CONTRIBUTING.md, line 3 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

CONTRIBUTING.md, line 13 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

CONTRIBUTING.md, line 35 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

CONTRIBUTING.md, line 283 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

CONTRIBUTING.md, line 308 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

CONTRIBUTING.md, line 343 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

CONTRIBUTING.md, line 349 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 1 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 3 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 15 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

Will the AppVeyor URL be updated when the repo is renamed?

README.md, line 16 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 23 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

Will this URL be updated after the repo is renamed?

README.md, line 24 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 46 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 51 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 58 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 77 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 84 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 91 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 103 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 121 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

README.md, line 278 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

SqlServerDscHelper.psm1, line 6 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

DSCResources/CommonResourceHelper.psm1, line 207 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

DSCResources/MSFT_SqlAG/MSFT_SqlAG.psm1, line 2 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

DSCResources/MSFT_SqlAGDatabase/MSFT_SqlAGDatabase.psm1, line 2 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done.

OK

DSCResources/MSFT_SqlAGListener/MSFT_SqlAGListener.psm1, line 2 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

DSCResources/MSFT_SqlAGReplica/MSFT_SqlAGReplica.psm1, line 2 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

OK

Comments from Reviewable

Review status: 190 of 199 files reviewed at latest revision, 13 unresolved discussions.

CHANGELOG.md, line 1 at r4 (raw file):

# Change log for xSQLServer

Corrected

Comments from Reviewable

Reviewed 8 of 407 files at r1, 17 of 19 files at r5, 7 of 7 files at r6.
Review status: all files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

CHANGELOG.md, line 1 at r4 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Corrected

OK. @mgreenegit you have to acknowledge this one to resolve.

README.md, line 15 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Will the AppVeyor URL be updated when the repo is renamed?

After rename the "new" repo needs to be connected to AppVeyor again, unless AppVeyor handles that automatically, unsure. Either way, this link will not be updated, so I think this need to be changed to the new name.

README.md, line 23 at r1 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Will this URL be updated after the repo is renamed?

After rename the "new" repo needs to be connected to AppVeyor again, unless AppVeyor handles that automatically, unsure. Either way, this link will not be updated, so I think this need to be changed to the new name.

Tests/Integration/MSFT_SqlSetup.config.ps1, line 58 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

This one was missed; should be 'SqlServerDsc'.

Tests/Unit/MSFT_SqlAGListener.Tests.ps1, line 96 at r4 (raw file):

'SqlServerAGListener\Get-TargetResource'

This one was missed; should be 'SqlAGListener\Get-TargetResource'.

Tests/Unit/MSFT_SqlDatabaseDefaultLocation.Tests.ps1, line 16 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

This was missed; should be 'SqlServerDsc'

Tests/Unit/MSFT_SqlDatabaseRecoveryModel.Tests.ps1, line 1 at r1 (raw file):
Previously, mgreenegit (Michael Greene) wrote…
Done

This was missed; should be 'SqlServerDsc'

Comments from Reviewable

@randomnote1 some tips on the review process. To resolve a review comment after it's done, you can just click the 'Acknowledge'-button to resolve (and it should collapse as resolved). There is no need for you to type 'OK' on all of them. :) When you have acknowledge all your comments, and you have no other comments, then just type :lgtm: in conversation at the top (there might be a button for it as well) and click on the 'Publish'-button. You can do that even if other review comments exist (from me or others), then I know that you think "it looks good to me now". 😄

Just to follow up, the very latest changes did build successfully (I'm posting this because it requires the repo to have a different name, which is not practical yet).
https://ci.appveyor.com/project/mgreenegit/sqlserverdsc/build/tests

@mgreenegit there is a lot of commits from Katie on this PR, looks like you didn't rebase against dev (?) but instead have did a merge? Could you do a git rebase PowerShell/dev to see if we get rid of the old commits? 'PowerShell' is remote name that points to the PowerShell/xSQLServer repo.

@mgreenegit I gather we rename this repo just before we merge this PR so we can make sure the tests passes?
Is this the order we should do the rename and merge this PR?

Rename repository to xSQLServer
Connect AppVeyor if needed
Connect CodeCov if needed
Close and reopen this PR to kick of the tests again.
Merge the PR into dev when tests passes.

@johlju, thanks for the tips! Reading the help seemed to indicate typing OK would resolve it.

@randomnote1 yes it did resolve, so you did all correct, but with acknowledging you don’t have to publish  a lot of comments :) But either way is good.
Btw thanks for reviewing! Really appreciate you helping! :smile:

@johlju sure thing! Looking forward to this PR being completed. It should add a ton of structure to the project and make it much more usable.

The rebase has a lot of conflict errors that don't make sense.  It's possible the change is so large that previous incoming changes are no longer applicable?  The one file to watch out for is the MaxDrop resource.

I’m working on renaming parameters and using your PR as a base. I rebased against origin dev and it worked, but as you said MaxDop did look like it changed a lot but actually when comparing changes in VS Code (during rebase) it was actually just one row that was the problem it was easy conflict to resolve, so if I remember correctly I kept “current” and manually changed  one row from “incoming”, but had to be resolved in two steps. It looked bigger than it was.
If you check “Allow edits from maintainers” I can look into it.

It is checked, if you are able to get to this before me

that should be a correct rebase, if you could please validate?

Reviewed 1 of 407 files at r1, 1 of 10 files at r3, 2 of 3 files at r7.
Review status: 198 of 199 files reviewed at latest revision, 6 unresolved discussions.

Comments from Reviewable

So... It like version <IP_ADDRESS> was just released. I think you'll have to rebase again and adjust changelog.

Review status: 197 of 199 files reviewed at latest revision, 8 unresolved discussions, some commit checks failed.

CHANGELOG.md, line 9 at r8 (raw file):

- Significant rename to reduce length of Resource names
  - BREAKING CHANGE
  - Impact to all resources

Move into the Unreleased section

SQLServerDsc.psd1, line 3 at r8 (raw file):

@{
# Version number of this module.
ModuleVersion = '<IP_ADDRESS>'

Need to rebase again.

Comments from Reviewable

@mgreenegit There was slight problem with the rebase.

Reviewed 2 of 407 files at r1, 1 of 10 files at r3, 2 of 3 files at r7, 1 of 1 files at r8.
Review status: all files reviewed at latest revision, 9 unresolved discussions, some commit checks failed.

DSCResources/MSFT_SqlServerMaxDop/MSFT_SqlServerMaxDop.psm1, line 620 at r8 (raw file):

}

Export-ModuleMember -Function *-TargetResource

There was a problem when the conflicts was resolved. After rebase, you got the resource code three times in this file.
The code below this row seems to be the correct code, it includes the new merged changes and your changes.
Please remove all the code for this row to the top, and I think we will be good. :smile:

Comments from Reviewable

I'm fixing the rebase aginst dev - and cleaning up MaxDop resource

Reviewed 1 of 407 files at r1, 2 of 4 files at r9.
Review status: all files reviewed at latest revision, 9 unresolved discussions.

CHANGELOG.md, line 9 at r8 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Move into the Unreleased section

Done.
Also changed the resource names in the change log back to the same as they was released in <IP_ADDRESS>.

DSCResources/MSFT_SqlServerMaxDop/MSFT_SqlServerMaxDop.psm1, line 620 at r8 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
There was a problem when the conflicts was resolved. After rebase, you got the resource code three times in this file.
The code below this row seems to be the correct code, it includes the new merged changes and your changes.
Please remove all the code for this row to the top, and I think we will be good. :smile:

Done

Comments from Reviewable

Ok thanks.  I can put time towards this today if you need me to take any of it.

@mgreenegit You can take over from here if you like. It took an hour to rebase against dev this time.
My chnages was tested OK here:
https://ci.appveyor.com/project/johlju/sqlserverdsc/build/<IP_ADDRESS>

@mgreenegit If you continue with this one, I continue with the work on issue #308. Now I can rebase against your fork directly, that was my goal. 😄

Review status: all files reviewed at latest revision, 10 unresolved discussions.

SQLServerDsc.psd1, line 3 at r8 (raw file):
Previously, randomnote1 (Dan Reist) wrote…
Need to rebase again.

@mgreenegit seems I messed this one up in the rebase. :disappointed:  Can you please change this to '<IP_ADDRESS>'?

SQLServerDsc.psd1, line 111 at r10 (raw file):

    the resource will only determine if a change is needed if the target node
    is the active host of the SQL Server instance ([issue 882](https://github.com/PowerShell/xSQLServer/issues/882)).
  - Fixed the formatting for the AvailabilityGroupNotFound error.

@mgreenegit I messed up here as well. The text from this row and below is form the prior release.

Comments from Reviewable

@mgreenegit I have finished work on issue #308, so I thought I give this PR an hour of coding. I thought I cleanup what I messed up yesterday. Let me know if you are working on this now.

@mgreenegit I think I got all the last changes with this one.

Reviewed 8 of 407 files at r1, 4 of 10 files at r3, 10 of 10 files at r11, 1 of 1 files at r12.
Review status: all files reviewed at latest revision, 8 unresolved discussions.

README.md, line 15 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
After rename the "new" repo needs to be connected to AppVeyor again, unless AppVeyor handles that automatically, unsure. Either way, this link will not be updated, so I think this need to be changed to the new name.

Done

README.md, line 23 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
After rename the "new" repo needs to be connected to AppVeyor again, unless AppVeyor handles that automatically, unsure. Either way, this link will not be updated, so I think this need to be changed to the new name.

Done

SQLServerDsc.psd1, line 3 at r8 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
@mgreenegit seems I messed this one up in the rebase. :disappointed:  Can you please change this to '<IP_ADDRESS>'?

Done

Tests/Integration/MSFT_SqlSetup.config.ps1, line 58 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This one was missed; should be 'SqlServerDsc'.

Done

Tests/Unit/MSFT_SqlAGListener.Tests.ps1, line 96 at r4 (raw file):
Previously, johlju (Johan Ljunggren) wrote…

'SqlServerAGListener\Get-TargetResource'

This one was missed; should be 'SqlAGListener\Get-TargetResource'.

Done

Tests/Unit/MSFT_SqlDatabaseDefaultLocation.Tests.ps1, line 16 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This was missed; should be 'SqlServerDsc'

Done

Tests/Unit/MSFT_SqlDatabaseRecoveryModel.Tests.ps1, line 1 at r1 (raw file):
Previously, johlju (Johan Ljunggren) wrote…
This was missed; should be 'SqlServerDsc'

Done

Comments from Reviewable

@randomnote1 Can you please do a last review and acknowledge all the review comments that you can?

Reviewed 1 of 1 files at r13.
Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

Comments from Reviewable

I think we're good to go! Is it time to rename the resource?

Six review comments that are done, but I can't acknowledge them. But this one is looking good to me now as well.

Reviewed 1 of 1 files at r13.
Review status: all files reviewed at latest revision, 6 unresolved discussions, some commit checks failed.

Comments from Reviewable

@mgreenegit @kwirkykat How do we go about merging this one? I made suggested steps in this comment https://github.com/PowerShell/xSQLServer/pull/902#issuecomment-343991881 that I have updated with things I could think of. I paste the comment here so it is easier to comment on it.
I gather we rename this repo just before we merge this PR so we can make sure the tests passes. Is this the order we should do to rename the repository and merge this PR?

Update xSQLServer on PowerShell Gallery that it is obsolete.

Can we change the item in PowerShell Gallery without a new release? If not, should we release a new minor version with a release note saying it is obsolete and we are moving to SqlServerDsc on PowerShell Gallery?

Rename repository to SqlServerDsc
Connect AppVeyor if needed
Connect CodeCov if needed
Document in CHANGELOG.md that repository have been renamed (could be done in this PR).
Close and reopen this PR to kick of the tests again
Merge the PR into dev when tests passes

/cc @randomnote1

@johlju We should be able to update the release notes on xSqlServer without doing a release. I just need to find the right person here who knows the login credentials to the PowerShell Team PS Gallery account... But I think ideally that step should actually go last when we have the first version of SqlServerDsc ready to point people to. I can do steps 2, 3, & 4 whenever you are ready.

@kwirkykat Updated the steps, so please do the first three steps as soon as you can.

@kwirkykat hope you had a great thanksgiving! Just a gentle reminder that we are ready for you to rename the repo (for you to do steps 1, 2 and 3 in the updatee list above). 😄

@johlju Steps 1-3 are done. Let me know if AppVeyor or CodeCov start acting up

Closing and re-opening this PR to test new AppVeyor

@kwirkykat Thanks a lot! AppVeyor seems to work at least. I will let you know if I run into any problems.

I will add a not to the change log about the rename after the merge of this PR. All tests passed.


Fix at-rule-no-unknown end positions

Part of #652
This change also adds a test helper function to make testing multiline strings easier.

Don't mind. Thanks for the merge!


owner(cdc): Revert aysnc sink initialization

What problem does this PR solve?

Issue Number: close #4245
What is changed and how it works?
revert #3598 from release-5.4
Check List
Tests

No code

Code changes
Side effects
Related changes
Release note
`None`.

@3AceShowHand Can we close it now?


windows-latest => windows-2022

I think that the information about vmImages is not correctly anymore.
Are you sure that "windows-latest" is still "windows-2019"? and not "windows-2022"?
Because our builds are failing with "windows-latest", but with "windows-2019" there are still working
So this part is wrong in the table I think:
windows-latest OR windows-2019
Should be:
windows-2019
and for 2022:
windows-latest OR windows-2022

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 61db3371-6395-88a2-fb78-09f98790ab1b
Version Independent ID: ef6f1bf7-02b8-9093-b84e-c9bde7d98e57
Content: Microsoft-hosted agents for Azure Pipelines - Azure Pipelines
Content Source: docs/pipelines/agents/hosted.md
Product: devops
Technology: devops-cicd-agents
GitHub Login: @steved0x
Microsoft Alias: sdanie

@EenPOOL -- Maciej, thank you for your feedback.  This issue is being tracked in #12120.
I am closing this issue now.  You are welcome to @ mention me for any followup.  We hope to hear from you again.


Make overflow of add-modal auto/scrollable

What the title says, issue is for documentation purposes. I'll probably fix it with my latest PR

I'm not sure if I understand you correctly. As of now, the modals are scrollable when they exceed the height of the viewport. The strategy currently implemented also makes sure (large) modals are accessible on mobile both in standalone and when the app is embedded within the website. I decided against making the content of a modal scrollable as it often leads to a worse user experience (e.g. bad experience on touch devices, users not recognizing that content is scrollable). I don't intend to make changes here if there's no important reason for it (e.g. accessibility or buggy behavior). I'll close this issue. Please reopen it if you still think you found a bug or if you want to make your case for changing the way modals are scrolled right now.


[BUG 1.16.5] NO STARTING SERVER

please update mixin for your mod, as I can't start the server with your mod on the new Forge.
i use core: Lolliserver 1.16.5
log: https://paste.ubuntu.com/p/X4jCnqjGbd/

Hi! Unfortunately we don't support any other environments than Minecraft Forge, you're using unsupported server software.
See: Issue #158 Comment


Fetch oci-spec-rs from crates.io.

Fetch oci-spec-rs from git, not from crates.io.
We are using git hash to modify the version of oci-spec-rs.
This is because a version incorporating this PR (https://github.com/containers/oci-spec-rs/pull/69) has not yet been released.
We will update the minor version of oci-spec-rs as soon as it is released.
ref: #303

@utam0k I was thinking may be we should maintain git commit hash for this until oci-spec-rs is stable? It seems that we constantly are finding kinks to iron out between the spec repo and youki.

I agree with you :+1:


Hide tray icon

Please provide a setting so I can disable the tray icon even when I want to keep Whatsie open.

@mendez8 as a temporary workaround, you can try hiding/disabling the tray icon in your DE settings[^1] and turning off the Minimize in tray in start option in whatsie.
[^1]: KDE has this option, don't know about other DE's though

Thanks @lightproof! please feel free to resolve this issue


QHY support

Hi,
I'm in the process of building an all-sky camera and plan to use either an ASI290MC or a QHY5-III 462C that is currently on order. Of course, there is no QHY-specific capture command. I created the native QHY driver in NINA and am willing to create the necessary catpure command that is specific for QHY cameras and uses their Linux/ARM ports of their SDK.
Looking at the capture command, it is specific to ZWO and there is a separate source file for the RPi HQ camera as well. Would you be open to the idea of creating a single-source capture command where hardware support is modularized, so that one command can be complied and the user selects which camera type they wish to use via the existing camera settings?

Hi Dale,
I started working on something like this last night. The idea is to have a capture_QHY.cpp file. I started a branch here https://github.com/thomasjacquin/allsky/tree/qhy-camera
The camera selection happens in config.sh CAMERA="QHY". It's not functional yet but I don't think it would take too long. I'll have to clean up that branch and remove all the unused files at some point... still experimenting!
I'll try to get the capture working tonight but feel free to try it on your side.

Oh wow! How fortuitous. If you'd like, I can look the QHY code over, test it with my cameras, and submit any changes or suggestions.

Oh yeah for sure! Go ahead. Last night I managed to get a compilation with no failure but when I start it manually with allsky.sh It wasn't connecting to the camera. Could be because there were 2 others cams plugged to the Pi.
Anyways, I've had the CPP file capture an image at some point in the past but the RG and B channels were side by side on the image... it's definitely a work in progress. Let me know how it goes.

Ok. My two QHY cameras are a QHY600M and QHY183M, so I don't have a color sensor on hand at the moment but I should get the 462C later this week, which will get me a OSC to work with.
Is your plan to have a distinct capture command for each camera, including all non-camera-specific supporting logic? I was thinking that the camera-specific bits could be on their own but share all the common code so as to minimize duplication

I agree, It would be nice to avoid duplication and have a code base more INDI like. Although I think the capture_RPiHQ is quite different since it's using raspistill and doesn't support the same camera settings.
ZWO and QHY could probably share a lot of code in common.

Well, at the end of the day, each camera must provide a specific thing - an image bitmap or other image-y thing. That's really what we need, right? There are is always going to be differences amongst SDKs and even the hardware that will make it impossible to 1:1 map every command line option to capture to a function on the camera... but that's alright. Depending on the camera, some options will be no-ops, or take slightly different parameters. Each camera driver can advertise what it's capable of and we would match the logic accordingly, as best as we can. I'll see if I can work out a PoC, though my C++ is a little rusty, I should be able to manage.

That's right, all we need is a binary that produces an image.
I created separate camera_options_XXX.json files specific to the camera model. These get used in the GUI to display the appropriate options. It would be too hard to keep one file that applies to all brands (different options, different default values, different ranges).
e.g. https://github.com/thomasjacquin/allsky-portal/blob/master/camera_options_RPiHQ.json

I've been finding some time to work on this branch locally. A few things:

I talked to QHY and they are currently working on actual auto-exposure in the SDK. The QHY_3A_AUTO* controls currently don't actually do anything, so I guess we look for it in a future SDK release. This really only affects daytime shooting anyway since nighttime shots are a pinned exposure length.

Regarding SDKs in general, I've worked on creating a SDK download and installation script that allows the user to choose which SDK(s) they want to install onto their system. The various allsky utilities are compiled using them, with the binaries being linked to the SDK's shared objects. This allows the user to upgrade the SDK in the future without having to recompile the utilities as well (modulo any API/ABI-breaking changes in the SDKs themselves, with is a very rare event)

I have capture_QHY properly debayering color images now and exposing correctly. When time allows, I'm going to suss out the options mapping. As I'm doing this, I'm looking at ways to turn the ZWO, QHY, and RPI camera stuff into modules that are usable by a single capture executable.

Hi Dale, these are great news. It will definitely be a nice addition to the family of cameras supported by the software. I haven't spent too much work on the QHY code so there shouldn't be any issues merging your code in. I have just been fixing bug reports from users after releasing v0.7. There are still minor quirks but it should be stable soon and it'll be a good code base to use when merging your QHY work.

I am just wondering if this is a thing now, with the QHY camera support?
I only have a QHY5P-II Coloe camera but willing to at least help testing....

Has there been any progress in utilising the QHY cameras for the allsky setup...??

I am interested as well. Is the QHY branch working at the moment?
I also have sort of a weird question - I have an old QHY5 that I have resurrected (it was producing black images) by desoldering the main image sensor and soldering in a new one. However, I soldered a colour one instead of the original B&W.
Working great but I imagine using this branch would produced a B&W image. Where in the code should I look if I want to debayer the image to display it as colour one? or is that done by the SDK for colour images?
Thanks!

I am interested as well. Is the QHY branch working at the moment?
I also have sort of a weird question - I have an old QHY5 that I have resurrected (it was producing black images) by desoldering the main image sensor and soldering in a new one. However, I soldered a colour one instead of the original B&W.
Working great but I imagine using this branch would produced a B&W image. Where in the code should I look if I want to debayer the image to display it as colour one? or is that done by the SDK for colour images?
Thanks!

Is the QHY branch still usable?
I would try to use it with a QHY5L-II Colour camera.
Thanks

@daleghent,  any update on this?  FYI, the version 0.8 capture.cpp has a lot of changes from 0.7, and a newer version I'm working on has even more changes.
@ckuethe, see the posts above - perhaps you can work with Dale on QHY support?


I use matplotlib.pyplot.imshow to plot "Test_026.npy", but something go wrong, can u explain how to transpose "Test_026.npy"?

I have solved this problem by "np.expand_dims", Thanks for your solid work!

Hey, I think I met something wrong like u, can you share your code about transpose&plot the test_026_probs_map.npy?
thx


Steam and proton-ge-custom-bin

Hi, I use conty for a few months with the following PKGBUILD (nothing fancy there):

PKGBUILD
pkgname=conty-lite
pkgver=1.16
pkgrel=1
pkgdesc="Easy to use unprivileged Linux container as a single squash'ed executable"
arch=(x86_64)
url="https://github.com/Kron4ek/Conty"
license=(MIT)
provides=(steam wine winetricks)
conflicts=(steam wine winetricks)
depends=(fuse2)
optdepends=(squashfuse bubblewrap)
source=("$pkgname-$pkgver.sh::$url/releases/download/$pkgver/conty_lite.sh")
sha256sums=('f068a41786d26a39bcf24e049a3d832ca1ad0de825dcec8628c4ecae5f84a3b3')
noextract=("$pkgname-$pkgver.sh")
options=(!strip)

package() {
    install -Dm 755 "$pkgname-$pkgver.sh" "$pkgdir/usr/bin/conty_lite"

    for exe in steam steam-runtime steam-native wine wine64 wineserver winetricks; do
        ln -s "/usr/bin/conty_lite" "$pkgdir/usr/bin/${exe}"
        chmod 755 "$pkgdir/usr/bin/${exe}"
    done
}

I also have AUR package for Proton GE installed - proton-ge-custom-bin (it installs Proton to /usr/share/steam/compatibilitytools.d/proton-ge-custom)
However, Steam (launched with /usr/bin/steam-runtime) won't see Proton GE as a compatibility tool. Maybe you can spot some glaring omissions in this setup?

If I remember correctly it was fine when I used usual Arch's Steam + multilib.

Also If I copy /usr/share/steam/compatibilitytools.d/proton-ge-custom to ~/.steam/steam/compatibilitytools.d/, Steam sees Proton GE.

Hi,
Your setup is fine, it's just that Conty doesn't see system-wide directories, except for the ones i specifically allowed it to see (/tmp, /home, /mnt, /opt, /media, /var, /run), so it just doesn't see /usr/share/steam/compatibilitytools.d.
Mounting /usr/share/steam/compatibilitytools.d will be added in the next release (https://github.com/Kron4ek/Conty/commit/2ed0ca2eada30132606319578aec95314c8a4407), so Conty will see it.

Here is a new build, it identical to the current release except that it include the aforementioned commit. Check if it fixes your problem.
SHA256: acf0c53bfcae8d5490db0b4e6d91717f29de49e7cd0085ad11e09ec21d83e672

Yeah, id did fix the issue, system-wide Proton GE is now visible :tada:
Glad I've asked, thanks for the help :heart:

I'll leave the issue open so that you can close it with the next release.

New release is out, closing the issue.


Request multiple android permissions in same dialog

Feature Request
Allow to request multiple android permissions in one dialog.

Why it is needed
Common pattern in android is request multiple permissions in one dialog. For example, if you need to take a photo, you need to access CAMERA and EXTERNAL_STORAGE. This is already implemented in PermissionsAndroid RN module: https://facebook.github.io/react-native/docs/permissionsandroid#requestmultiple

Possible implementation
We can dig into RN module to get code from that.

@Strate A recipe already exists for this: https://github.com/react-native-community/react-native-permissions#request-multiples-permissions
The only difference is that it will not display the total numbers of permissions (2 of 2 on this screenshot)

But it works on iOS.

@zoontek yes, sequentially requesting permissions is solution for now.
But this FR addressed to display total number of permissions in android.

I understand this is not always a good UI pattern, I just wanted to mention that I have had a project where I was specifically asked to pop a request for all the permissions at once.  So I think it's a valid feature request if that's worth anything. Cheers

Shipped in the last version 🎉


APIv5 Delivery Service updates for Traffic Portal

Primarily the motivation of this PR was to support the change of the "Active" property of Delivery Services from a boolean to an enumerated constant. More generally, though, that means using APIv5 for requests that include DS representations in either the request or response body(ies). The structure of responses changed in APIv5 for certain requests - not just because of "active".  POST requests, for example, used to return a response that was an array where the length was always one and the only element was the created DS; instead they now just return the DS without wrapping it in an array.
Also, the service was returning the entire HTTP response, so I had to go track down all the places it was used. To make it easier for both me and anyone else who ever has to do anything similar, I added typings to the Delivery Service and Delivery Service Request API services. I also eliminated like half the lines of code by just using async/await instead of .then chains and callbacks.

Which Traffic Control components are affected by this PR?

Traffic Portal

What is the best way to verify this PR?
Make sure existing tests still pass, filter Delivery Services on the basis of their "Active" property, create, update, and delete DSes and DSRs
PR submission checklist

[x] This PR uses existing tests
[x] This PR doesn't need documentation
[x] This PR doesn't need a CHANGELOG.md entry since the change to the DS structure is already in the changelog
[x] This PR DOES NOT FIX A SERIOUS SECURITY VULNERABILITY

Getting a 400 when attempting to update a DS with DSRs enabled. Looks like it's not sending the delivery_service_id with the request.


Tests revert in an if branch

This is a test that was posted in #2876
This test case now runs without causing the internal error mentioned in the issue.
Pushing this test case which appears not to be covered in the existing ones.
Closes #2876

Hey, it seems like the test is built without fetching https://github.com/FuelLabs/sway/commit/76b1ee9d4cd2500898f702e4725d483e71b23a46, so it fails as the lock file is outdated. Building forc from master and rebuilding the test should fix the CI failure

Hey, it seems like the test is built without fetching 76b1ee9, so it fails as the lock file is outdated. Building forc from master and rebuilding the test should fix the CI failure

Thank you for letting me know what the issue was.

I bet https://github.com/FuelLabs/sway/pull/3210 fixed it :) Thanks!


Added Components Folder

Components folder -
added init
Robot.py
Added Shifters

Looks good. Still no drive class, but I assume that is coming.


Allow roll over negative balances

I know it breaks "YNAB" style budgeting rules as Im essentially budgeting money I don't have yet , but is there a way to allow a negative balance to roll over? I often have to buy things for work that get reimbursed later, so I let that specific bucket sit negative for a week or two until I get the reimbursement. That works fine until the payment and reimbursement fall in different calendar months. Then the amount is pulled out of the "To be budgeted for month" field. I can work around it for now by budgeting -XXX USD at the start of the month, but that throws the "Budgeted for month" field off.
That or have a way leave to a bucket out of the budget completely, as this account has truly no affect on the budget.

I will look into maybe adding a option to do this. with the warnings that you may not have the funds to cover this bucket.

I just wanted to add that this is important on my end - I used that feature of YNAB to deal with overspending over future months when officially I don't have the capacity to at the current point in time. I might look into doing a hack myself for the time being, but this probably needs further thought on how to handle  user settings for whether a bucket can be negative or not.


Mitsubishi Heavy SRK40HBE work with code 1682

Home Assistant version
0.108.3
SmartIR version
1.7.4
Hello!
Mitsubishi Heavy SRK40HBE work with code 1682
Thank you for your work!

Nice! Thank you


Build daala only once

The current script logs into each machine and does a build. Instead, a single static Daala build should be done, and the x86_64 binary should be copied to each machine.

Fixed


FIX: Handle plotting only one MELODIC component

This addresses https://github.com/poldracklab/tacc-openneuro/issues/40.
It's a rare case, but if the series can be 3D, we should be handle it.

Codecov Report
Base: 63.34% // Head: 63.33% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (ba3f28b) compared to base (1555d2b).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff               @@
##           maint/1.7.x     #775      +/-   ##
===============================================
- Coverage        63.34%   63.33%   -0.02%
===============================================
  Files               49       49
  Lines             5945     5948       +3
  Branches          1167     1168       +1
===============================================
+ Hits              3766     3767       +1
- Misses            1999     2000       +1
- Partials           180      181       +1

Flag
Coverage Δ

reportlettests
?

unittests
50.57% <0.00%> (-0.03%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files
Coverage Δ

niworkflows/viz/utils.py
77.80% <50.00%> (-0.38%)
:arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Add ciscocloud and asteris yum repos

See #1182 #1188.
We'll have to remove direct mantl package installs.

DO and GCE passing, AWS failed unrelatedly.


Remove all reliance on incremental IDs

In Ghost 1.0 we set out to get rid of incremental IDs. We didn't quite achieve it, as the migrations table still uses it, and I believe there is still some hardcoded expectations around the Ghost owner ID.
Regarding incremental IDs in the migrations table I raised an issue on knex migrator: https://github.com/TryGhost/knex-migrator/issues/91
We need to also try to get rid of reliance on IDs inside of Ghost itself.
This issue needs more detail really - raising it as a starting point.

I believe there is still some hardcoded expectations around the Ghost owner ID.

Yeah, we had multiple places where we relied on the owner ID being 1, which allows us to not query the database, that's why it was very hard to get rid of this pattern. Not sure how hard/easy it is to get rid of this because of permissions (for example here), the importer and tests. Everything should depend on the owner role and not on the owner ID being 1.

as the migrations table still uses it

As you pointed out in the raised issue, it would be good to tell the migrator to use a different ID value and type. Did we ran into any problems with having incremental ID's in this table?

Everything should depend on the owner role and not on the owner ID being 1

FYI: https://github.com/TryGhost/Ghost/issues/9548#issuecomment-378888362
If we start with this, it would be great:

to get rid of all usages of owner being 1 (!) - in tests, in the code base (e.g. internalUser)
add a sanitise check in the model layer and compare incoming data types (fn sanitizeData)
generate an ObjectId for the owner
if we have to figure out if a user is an owner, please use isOwnerUser - check is based on the role and not on the id
probably a 2-3 day task


chore: misc clean up in forest_crypto

Summary of changes
Changes introduced in this pull request:

[x] verify_bls_sig is the same as fvm_shared::crypto::signature::ops::verify_bls_sig.
[x] All JSON serialization helpers should be moved to forest_json.
[x] There's no need to distinguish the error enum. It can be replace with anyhow::Error.
[x] The Signer trait should be deleted. It is only used for testing with DummySigner. SignedMessage will require a new method: new_unchecked(message: Message, signature: Signature) -> SignedMessage. It is similar to new_from_parts but doesn't verify the signature. All DummySigners should be removed.
[x] Merge the duplicate JSON serializers for Ticket and VRFProof.

Reference issue to close (if applicable)

Closes  https://github.com/ChainSafe/forest/issues/2113
Other information and links

I feel it would be better to get rid of DummySigner altogether. You can manually create a dummy signature in the tests (and even generate an arbitrary one in the quickchecks).


Create tests for memoized and non-memoized IO

The non-memoised version is added only as counter-example to memoised behaviour

@leigh-perry Thank you, and nice work! 👍


Validation: Fix multiple changes

This PR addresses the following validation issues and includes an updated ms.date:
missing description
missing column headings

Docs Build status updates of commit 33a7fbb:
:warning: Validation status: warnings

File
Status
Preview URL
Details

docs/schema/property-element-featurepropertydefinitions-complextypeapphostwebfeatures.md
:warning:Warning
View
Details

docs/schema/property-element-featurepropertydefinitions-complextypeapphostwebfeatures.md

Line 2, Column 1: [Warning: ms-prod-and-service - See documentation] Only one of the following attributes can exist: 'ms.prod', 'ms.service'. Use ms.prod for on-premise products, or ms.service for cloud services.

For more details, please refer to the build report.
If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.
Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.
Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.
For any questions, please:Try searching the docs.microsoft.com contributor guidesPost your question in the Docs support channel

This PR addresses the following validation issues and includes an updated ms.date:
missing description
missing column headings
Global effort to fix build validation errors
@-repo owner
The Content & Learning team is fixing build validation errors on docs.microsoft.com for the rest of H2. This will eliminate potential accessibility, security, and usability issues. This PR includes only build validation fixes and does not change other content. Please review within five business days and merge or comment in the PR with any changes you'd like to see. Thank you!


refactor: make acocunt id usize

This sets up the upcoming separation between account ids, which is a UX
artifact for users of the tx generator that represents an index (hence
usize) in the initialization array of accounts; and instance ids, which
is a u16 that is part of an implementation detail of FeatureContracts.
More on this in susequent PRs.

Stack:

#477
#476 ⬅

⚠ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.55%. Comparing base (9852d18) to head (2f208e6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #476   +/-   ##
=======================================
  Coverage   83.55%   83.55%
=======================================
  Files          37       37
  Lines        1770     1770
  Branches     1770     1770
=======================================
  Hits         1479     1479
  Misses        212      212
  Partials       79       79

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Possible solution for non-JSON references support relying on schemaFormat

This issue aims to kinda summarize idea mentioned dunring Adding support for non-JSON schemas (April 18th 2023) that could be a good solution for using JSON Reference for non-JSON structures like Protobuf or XSD.
JSON Reference spec
Current JSON Reference used in AsycAPI spec is JSON Reference v0.3.0.
In general, JSON Reference focuses on defining how a reference object should look like and requires only the following:

that it should have property $ref
that $ref is a string value of URI
that other properties in reference object must be ignored

Key words used to describe requirements, like SHALL or SHOULD follow https://datatracker.ietf.org/doc/html/rfc2119
Even thought the JSON Reference says in the intro
This specification defines a JSON [RFC4627] structure which allows a JSON value __to reference another value in a JSON document__

Later in spec in Resolution section it says in only SHOULD:
Resolution of a JSON Reference object SHOULD yield the referenced JSON value

Also, for fragments that start after #, JSON Pointer is not required but recommended:
If the representation of the referrant document is JSON, then the fragment identifier SHOULD be interpreted as a [JSON-Pointer].

Conclusion is

We can have a $ref pointing to .proto or .xsd for example
We can have a custom solution for fragments resolution in case of .proto for example, because JSON Pointer is just a recommended solution. So we can for example follow:

For .proto, when there are nested types that need to be referenced, we can follow standard Protobuf approach for pointing to nested types. So for $ref: "https://gist.githubusercontent.com/shankarshastri/c1b4d920188da78a0dbc9fc707e82996/raw/49e733499bfb302d9ecf320f2eca2f752f7e257b/LearnXInYMinProtocolBuffer.proto" if someone wants to reference FirstLevelNestedMessage type, fragment would look like, probably :smile:, #NestedMessages.FirstLevelNestedMessage. So the final reference would be:{
    "$ref": "https://gist.githubusercontent.com/shankarshastri/c1b4d920188da78a0dbc9fc707e82996/raw/49e733499bfb302d9ecf320f2eca2f752f7e257b/LearnXInYMinProtocolBuffer.proto#NestedMessages.FirstLevelNestedMessage"
}

For .xsd it is much easier, as there is already a XPath in place that allows to create a fragment pointing to a specific part of the XML/XSD. That requires further exploration and some input from experts but in theory, if we have https://www.w3.org/2001/XMLSchema schema, the xpath fragment to formChoice simple type would probably be xs:schema/xs:simpleType[@name='formChoice'] so the resulting reference is something like:{
    "$ref": "https://www.w3.org/2001/XMLSchema#xs:schema/xs:simpleType[@name='formChoice']"
}

Now the question is how on a spec level specify that dereferencing for given $ref should not use JSON Pointer but XPath or some other solution
Solutions on a speck level
schemaFormat based
As discussed during Adding support for non-JSON schemas (April 18th 2023) meeting, we can say that dereferencing mechanism depends on the schemaFormat.

If schemaFormat specifies AsyncAPI Schema, JSON Schema, Avro or any other JSON structure, we follow JSON Reference + JSON Pointer in fragments
If schemaFormat specifies Protobuf, we follow JSON Reference + Protobuf Nested Types Reference in fragments
If schemaFormat specifies XSD, we follow JSON Reference + XPath in fragments

Alternative
Something I mentioned before somewhere in an issue or Slack, but can't find reference.
We can just follow example from the JSON reference resolver that we use, that explains how custom resolvers work -> https://apitools.dev/json-schema-ref-parser/docs/plugins/resolvers.html. So for example they had a use case that someone keeps schemas in a MongoDB and want to reference directly to the database. The solution is that $ref value starts with "mongodb://" because plugins can discover that like canRead: /^mongodb:/i.
so we can do:

XSD like "$ref": "xsd|https://www.w3.org/2001/XMLSchema#xs:schema/xs:simpleType[@name='formChoice']"
Proto like "$ref": "proto|https://gist.githubusercontent.com/shankarshastri/c1b4d920188da78a0dbc9fc707e82996/raw/49e733499bfb302d9ecf320f2eca2f752f7e257b/LearnXInYMinProtocolBuffer.proto#NestedMessages.FirstLevelNestedMessage"

Neverheless, sharing just for reference as when I thought about it, I did not take schemaFormat into consideration. So relying on schemaFormat is better imho.
Tooling
json-schema-ref-parser that we use is pretty flexible:

you can have custom resolvers: https://github.com/APIDevTools/json-schema-ref-parser/tree/main/lib/resolvers
you can have custom parsers: https://github.com/APIDevTools/json-schema-ref-parser/tree/main/lib/parsers

And writing them is not hard same using. So, again in theory, in current JS Parser we can do $RefParser.dereference(mySchema, { resolve: { proto: ourProtoResolver }}); whenever we encounter a proto reference. This will of course require some refactor in Parser as dereferencing happens once, globally for entire AsyncAPI document, and in new approach that should be done one by one, applying different resolver depending on schemaFormat

I think I covered entire discussion and summary. Lemme know if something is missing
pinging meeting participants: @GreenRover @jonaslagoni @fmvilas

I really like it and would go with relying on schemaFormat as well

How do you think about this Szenario:
components:
  messages:
    firstLevelNestedMessage:
      payload:
        $ref: '#components/schemas/LearnXInYMinProtocolBuffer#NestedMessages.FirstLevelNestedMessage'
  schemas:
    LearnXInYMinProtocolBuffer:
      schemaFormat: application/vnd.google.proto;version=3
      schema:
        $ref: https://gist.githubusercontent.com/shankarshastri/c1b4d920188da78a0dbc9fc707e82996/raw/49e733499bfb302d9ecf320f2eca2f752f7e257b/LearnXInYMinProtocolBuffer.proto

components.schemas.LearnXInYMinProtocolBuffer pointing to a whole proto|xsd file containing multiple schemas.
components.messages.firstLevelNestedMessage pointing to components.schemas.LearnXInYMinProtocolBuffer  and picking NestedMessages.FirstLevelNestedMessage
Do a schema needs to be distinct or can it be multiple schemas.  My opinion is it should be distinct. Either needs to contain an anchor pointing to a single schema or the file is only allowed to contain a single root level schema

A "root level schema" would i define as:  A schema that is not used by other schemas.

Do a schema needs to be distinct or can it be multiple schemas. My opinion is it should be distinct. Either needs to contain an anchor pointing to a single schema or the file is only allowed to contain a single root level schema

sorry I do not get what you mean by distinct in this context. Not sure how it relates to your example
payload:
      $ref: '#components/schemas/LearnXInYMinProtocolBuffer#NestedMessages.FirstLevelNestedMessage'

this will not work, right? according to your PR, afaik, payload.$ref means it is pointing to AsyncAPI Schema. So normal resolution will be applied and fail
you would need to do
payload:
      schemaFormat: application/vnd.google.proto;version=3
      schema: '#components/schemas/LearnXInYMinProtocolBuffer#NestedMessages.FirstLevelNestedMessage'

@dalelane @char0n @smoya can you have a look 🙏🏼
basically the understanding is that this is a non breaking change that we could introduce in 3.0 and release as 3.1
but if it is breaking, then better know it sooner 😆

I'm not super confident in making statements on this, as this is getting much deeper into the weeds of JSON specs than I've got before!
If I've understood the description above correctly, then it seems reasonable to do this in 3.x as adding behaviour for new schemaFormat values.
Has anyone tried spiking a prototype along the lines of the custom resolvers described above to convince ourselves that this is workable?

Still valid? @derberg @dalelane @GreenRover

Yes, definitely a 3.1 candidate forme.


Disallow expression with type parameters as left side of property access

Cherry-pick of #49293
Fixes #49293 for 4.7

This never got merged and 4.8 is approaching. Should I just close this and maybe we mention this break in 4.8 compared to 4.7?

Yeah likely fine.


Feat - Upload json as test set

Issue #337 support upload a testset from a json file :

Added capability to handle json on the back-end.
Added functionality switch from csv to json on the front end and add json files.

@mmabrouk what is the right wat to run black?

@mmabrouk what is the right wat to run black?

Where x is the version you have installed.

@aybruhm thanks for the reply. I have done exactly that in my last commit! any other ideas?

@aybruhm thanks for the reply. I have done exactly that in my last commit! any other ideas?

You should run the black command in agenta-cli and the examples directory.


Make alignment of logs a visualizer selection that is dynamic

That way users can toggle on and off alignment of the logs.

could implement as a toolbar button which forces a reload / re-parsing / re-plotting of the logs (maybe can make this more efficient?


Modify classification accuracy functions to work over subset of dataset

Is this you also implementing a test set?

Yup (/what we discussed in person)

Think this is obsolete