FunctionDeclSyntax with TokenSyntax.binaryOperator leads to different a trailing trivia space on 5.10 and 6.0.

Description
I'm seeing some different behavior between 5.10 and 6.0 when declaring a function with a TokenSyntax.binaryOperator.
Here is a macro:
DeclSyntax(
  FunctionDeclSyntax(
    modifiers: [DeclModifierSyntax(name: .keyword(.public)), DeclModifierSyntax(name: .keyword(.static))],
    name: TokenSyntax.binaryOperator("=="),
    signature: FunctionSignatureSyntax(
      parameterClause: FunctionParameterClauseSyntax(
        parameters: FunctionParameterListSyntax {
          FunctionParameterSyntax(firstName: TokenSyntax.identifier("lhs"), colon: .colonToken(), type: TypeSyntax("String"))
          FunctionParameterSyntax(firstName: TokenSyntax.identifier("rhs"), colon: .colonToken(), type: TypeSyntax("String"))
        }
      ),
      returnClause: ReturnClauseSyntax(
        type: IdentifierTypeSyntax(name: TokenSyntax.identifier("Bool"))
      )
    ),
    bodyBuilder: {
      ReturnStmtSyntax(
        expression: SequenceExprSyntax(
          elements: ExprListSyntax {
            DeclReferenceExprSyntax(baseName: .identifier("lhs"))
            BinaryOperatorExprSyntax(operator: .binaryOperator("<"))
            DeclReferenceExprSyntax(baseName: .identifier("rhs"))
          }
        )
      )
    }
  )
)

Here is the 5.10 expansion:
public static func == (lhs: String, rhs: String) -> Bool {
    return lhs < rhs
}

Here is the 6.0 (and main) expansion:
public static func ==(lhs: String, rhs: String) -> Bool {
    return lhs < rhs
}

Any ideas about that different syntax (the missing space) between the two versions? My belief here is that the Swift convention for a function like this (a static function on a binary operator) should come with a space before the round brace. This was the 5.10 behavior.
Should we consider the 6.0 behavior to be the "correct" behavior of this macro? Should we consider the 5.10 behavior to have been a bug? Should we consider the 5.10 behavior to have been correct and the 6.0 behavior is just a temporary regression that we should fix before release? Any more ideas about that? Thanks!
Steps to Reproduce
Here is a diff on swift-syntax to repro:
diff --git a/Tests/SwiftSyntaxBuilderTest/FunctionTests.swift b/Tests/SwiftSyntaxBuilderTest/FunctionTests.swift
index c18f22f6..3ad61eeb 100644
--- a/Tests/SwiftSyntaxBuilderTest/FunctionTests.swift
+++ b/Tests/SwiftSyntaxBuilderTest/FunctionTests.swift
@@ -208,7 +208,7 @@ final class FunctionTests: XCTestCase {
         DeclSyntax(
           FunctionDeclSyntax(
             modifiers: [DeclModifierSyntax(name: .keyword(.public)), DeclModifierSyntax(name: .keyword(.static))],
-            name: TokenSyntax.identifier("=="),
+            name: TokenSyntax.binaryOperator("=="),
             signature: FunctionSignatureSyntax(
               parameterClause: FunctionParameterClauseSyntax(
                 parameters: FunctionParameterListSyntax {
@@ -234,7 +234,7 @@ final class FunctionTests: XCTestCase {
           )
         ),
         """
-        public static func ==(lhs: String, rhs: String) -> Bool {
+        public static func == (lhs: String, rhs: String) -> Bool {
             return lhs < rhs
         }
         """

This change is intentional and not having a space between the operator name and the ( is the intended behavior. This was changed by https://github.com/apple/swift-syntax/pull/2595 in release/6.0 and https://github.com/apple/swift-syntax/pull/2592 on main.

@ahoppen Sounds good. Thanks!


Conflicting routes when declared with prefix keyword

I have written this piece of code
const Koa = require("koa");
const Router = require('koa-router');
const app = new Koa();

const parentRouter = new Router()
const router = new Router({ prefix: '/countries'})

router.get('/', async(ctx) =>{
    console.log('countries called');
    ctx.body = {}
})

parentRouter.use(router.routes())

app.use(parentRouter.routes())

app.listen(3000);

console.log('Listening on port 3000')

When I call
localhost:3000/countries  then it prints countries called
But it is conflicting with other routes also
localhost:3000/some_route_1/countries prints countries called
localhost:3000/some_route_1/some_route_2/countries prints countries called
localhost:3000/some_route_1/some_route_2/some_route_3/countries  prints countries called
and so on
I guess it is adding it as suffix instead of prefix

Please turn to https://github.com/alexmingoia/koa-router/issues instead

ok I realised that...


Video: Software Engineering is Overwhelming

Here's a video I came across which resonates with me. This guy explains how software engineer looks complicated and confusing in the beginning, and how it is common for everyone to feel the same initially, and how to get to the stage of understanding it.
Two questions he mentions. For each tech you come across ask,

what is it
why does it exist

Break down big components into fundamentals. Everything can be broken into standards and fundamentals. Once you understand these you will see through all the marketing stuff and then everything will start to be simpler.
If you watch it, please share your takeaways as comments here.
https://www.youtube.com/watch?v=MbDjrztWtX4
If this is useful for many people, maybe add into resources section.

@johnjacobkenny I concur with you. The 5 whys is a blanket rule that could be applied any a problem of varied complexity. Instead of just bandwagoning, should ask why do we want to use a particular tech and what are we trying to achieve is important.
Recently, big banking companies i.e., Bank Of America announced that they're building their db using NoSQL (MongoDB) to leverage the performance. NoSQL comes with its own trade-off i.e., data accuracy, integrity and duplication. Only time will tell if its a great move or just bandwagoning. I feel traditional SQL still has its place in the document based db

@johnjacobkenny please move to docs section

Done!


Feature request: Download by part

Hi !
Thanks a lot for your great work !
I use it a lot while travelling to download league of legend games, but it can last 4-6 hours.
So i usually make part of each video so if a download failed i don't have to wait hours again to download the entire game, I just have to redownload a part of it.
Another good point is that I can start to watch quickly as soon as the first part is downloaded, while the other part are downloaded in background. And last usage is that i can delete files as soon as i watch them.
But actually it's a bit annoying to do it manually because i need to watch when does the game start, set is as start time, set an end time and remember it. Then doing the second part beginning at the end of first one and so on...
So i imagined two easy way to do it, either by setting length of part wanted :

Or setting the number of parts :

And when you click to download it create 4 independents download task in chronological order.
I'm web software developer and i may have some time next weeks, if you seems this feature seems great i will try to do a pull request ;)
Thanks a lot and do not hesite if you have question :)

It's kinda sad that I have absolutely no time for the new downloader because that would have pause/reconnect capabilities and you would not have to download everything again if it fails.
The split-thingy is a cool idea, but if one part in the middle fails you still need to re-download it manually with the current downloader. The new downloader should also provide a simple "try again" button.

Hello!  Is it Right that this issue is blocked by  https://github.com/Franiac/TwitchLeecher/issues/46 (it is mentioned in  @Franiac  last message), or can be done separately?
Also, if your have some time, can your provide some more info please? Main question - what should be the result? When i confirm download splited by N parts, then in downloads queue should appear N tasks? Then it's runs synchronously (as now)?
In summary. As a result,  need to implement calculation start and end time of each part, create new download request (as if manually added from current UI by user action), end push it to download queue?
Sorry for my english.

"Pause / Resume" is quite equal to "download by part" from a technical point of view. As both target the download process/ management I wouldn't wonder about #335 is being blocked by #46. But it's only an educated guess, so please don't quote me on that.

I almost finish the development of this feature, I will do a pull request tomorrow or friday ;)
Then we will see if the pull request is accepted until the #46 is implemented :)

#803


[ENHANCEMENT] Open Keyword by name

It would be nice to have possibility to navigate to keyword simply by typing it's name (part of the name) using Go to Symbol in Workspace functionality as described here

yep, this is an open thing, I have to implement the WorkspaceSymbols feature, see here


Input.set_mouse_mode(Input.MOUSE_MODE_HIDDEN) hides cursor even on window chrome

Operating system or device:
Windows 10 Pro x64
Issue description (what happened, and what was expected):
Using Input.set_mouse_mode(Input.MOUSE_MODE_HIDDEN) hides the system cursor not only inside the client area where the game is displayed, it also hides it on top of the window chrome / border / frame / non-client area. This makes it hard to hit minimize / maximize / close buttons. Maybe this can be optimized.

Can't reproduce this on Linux X11, so I'll assume it's a bug in the Windows platform code.

I guess the problem resides in the call to the Win32API ShowCursor(p_mode==MOUSE_MODE_VISIBLE); which actually hides the cursor globally and not only for the client area.
It seems that for hiding the cursor a call to SetCursor(NULL) must be done. This function also returns the last cursor that was used when called so I guess we can keep it in a variable to restore it later with SetCursor(old_cursor).
I do not know how this will behave in fullscreen.
https://msdn.microsoft.com/en-us/library/windows/desktop/ms648393(v=vs.85).aspx

Some progress has been made here in my fork: https://github.com/mattiascibien/godot/tree/hide-cursor-fix


Errors mention removed fluxctl status command

ErrorDeprecated and APINotFound both mention to create a GH issue and include the output of fluxctl status which has been removed in #572.

Deuplicate of #827.


Failed job

Hi @kimrutherford
This job failed:
https://github.com/pombase/allele_qc/actions/runs/6445032677/job/17520758110
I don't immediately see why. If you can quickly identify why let me know, otherwise I will dig into it.

Hi Manu.  It looks like a temporary GitHub or Ubuntu problem:
Err:28 mirror+file:/etc/apt/apt-mirrors.txt focal-updates/universe amd64 libnode64 amd64 10.19.0~dfsg-3ubuntu1.1
  404  Not Found [IP: <IP_ADDRESS> 80]
Ign:38 http://archive.ubuntu.com/ubuntu focal-updates/universe amd64 nodejs amd64 10.19.0~dfsg-3ubuntu1.1

So I suggest trying again in a few hours.

Alrightt thanks! I thought maybe it had to do with apt-get.

Hi @kimrutherford, the script failed again. It says to include apt-get update, would that make a difference you think? Not familiar with linux dep managers.

Hi Manu.

It says to include apt-get update, would that make a difference you think?

I think it would help.  I suggest adding this on the line before sudo apt-get install subversion -y:
sudo apt-get update

It works now. Thanks!


Add a developer signature to the windows package

Would be helpful if you sign the installation package for windows.

Signature added starting in 0.1.6! Hopefully windows defender/etc stop complaining as soon as all the authorities recognize the signature.


Cherrypick PRs from cordova-plugin-firebase

There remains plenty of unmerged open PRs for cordova-plugin-firebase.
They need going through and any useful bug fixes/features merging into this fork.
Suggestions most welcome.

PRs to merge (feel free to suggest more):

Added API method enableForegroundNotifications()
Added support for notification channels so sound, lights and vibratio ncan be supported on devices running Android 8 Oreo and later
Fix handling of data-message once grantPermission is done
Add ability to send imageUrl and iconBigUrl in data payload Android
fix: correct the resource target location for android


Can't initialize grouped tableView programatically

I believe the fix is to change line 148 of SDStateTableView.swift to override public init(frame: CGRect, style: UITableViewStyle).

@rkotzy Thanks for the suggestion, though it's late but found a scope to integrate on this last weekend of the year. Fixed on 0.0.3.


test(quick-install): Fix quick-install flanky test in github action

Change IPAM to kubernetes instead of cluster-pool
Closes #12279
Signed-off-by: Tam Mach<EMAIL_ADDRESS>test(quick-install): Fix quick-install flanky test in github action

Coverage decreased (-0.01%) to 37.155% when pulling d47b2696df3a0ae01f0ddd581e45964ee04d8cac on sayboras:feature/gh-action-install into dc2c1611ab4e69a58f280063526abeedec26c387 on cilium:master.


Don't use deprecated distutils module.

tests/__init__.py still uses the deprecated distutils which will be removed in Python 3.12.
From What’s New In Python 3.10:

The entire distutils package is deprecated, to be removed in Python 3.12. Its functionality for specifying package builds has already been completely replaced by third-party packages setuptools and packaging, and most other commonly used APIs are available elsewhere in the standard library (such as platform, shutil, subprocess or sysconfig). There are no plans to migrate any other functionality from distutils, and applications that are using other functions should plan to make private copies of the code. Refer to PEP 632 for discussion.

Porting from Distutils suggests using packaging.version instead of distutils.version.

Thanks @sebastic


wmutils-core: 1.1 -> 1.5

Motivation for this change
Bringing wmutils-core up to its most recent release.
Things done

[ ] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
Built on platform(s)

[x] NixOS
[ ] macOS
[ ] other Linux distributions

[ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
[ ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
[ ] Tested execution of all binary files (usually in ./result/bin/)
[ ] Determined the impact on package closure size (by running nix path-info -S before and after)
[ ] Ensured that relevant documentation is up to date
[x] Fits CONTRIBUTING.md.

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.
Result of nixpkgs-review pr 112229 run on x86_64-darwin 1

1 package built:

wmutils-core


Systray icon double (or single) click not working (show / hide window) (Ubuntu MATE 16.04)

When i double clicked the systray icon then nothing don't happens.

MATE Desktop Environment 1.12.1 based ubuntu 16.04  (gnome 2)

Same happens in Windows 10 v1607.  However, if I right click on the tray icon and then left click on "Toggle minimize to tray" the window exhibits the show/hide functionality.

Also, if "Close to tray" is enabled, when you close the app, it closes from tray too, when it should remain on the tray. Happens on Ubuntu and Windows.

Yes, it would be nice if a single click on the tray icon opened/closed the main window.

"if "Close to tray" is enabled, when you close the app, it closes from tray too, when it should remain on the tray" - the following patch helps for Linux (it is probably wise to remove "if (process.platform...)" at all to work on Windows too):
diff -ur app.orig/main.js app/main.js
--- app.orig/main.js    2016-09-20 10:55:40.000000000 +0300
+++ app/main.js 2016-09-21 16:57:11.160924016 +0300
@@ -236,6 +236,10 @@
       reconnectCount = 0;
       return client.disconnect();
     });
+    mainWindow.on('minimize', function(ev) {
+      ev.preventDefault()
+        mainWindow.hide();
+    });
     mainWindow.on('resize', function(ev) {
       return ipcsend('resize', mainWindow.getSize());
     });
@@ -454,7 +458,7 @@
       });
     });
     return mainWindow.on('close', function(ev) {
-      if (process.platform === 'darwin') {
+      if (process.platform !== 'win32') {
         if (mainWindow.isFullScreen()) {
           mainWindow.setFullScreen(false);
         }

Also it hides window to tray instead of minimizing.

As for the left click, it seems to be Electron on Linux limitation - https://github.com/electron/electron/issues/6773

Let's hope there's a fix soon :)

Found it. This patch lets tray left click on Linux (could be except on Ubuntu) to activate window:
diff -ur app.orig/ui/views/trayicon.js app/ui/views/trayicon.js
--- app.orig/ui/views/trayicon.js       2016-09-20 10:55:40.000000000 +0300
+++ app/ui/views/trayicon.js    2016-09-22 16:11:24.829826470 +0300
@@ -44,7 +44,7 @@
   create = function() {
     tray = new Tray(trayIcons["read"]);
     tray.setToolTip('YakYak - Hangouts client');
-    return tray.on('clicked', function() {
+    return tray.on('click', function() {
       return action('showwindow');
     });
   };

And this patch lets left click to toggle window:
diff -ur app.orig/ui/views/trayicon.js app/ui/views/trayicon.js
--- app.orig/ui/views/trayicon.js       2016-09-20 10:55:40.000000000 +0300
+++ app/ui/views/trayicon.js    2016-09-22 16:36:47.927195129 +0300
@@ -44,8 +44,8 @@
   create = function() {
     tray = new Tray(trayIcons["read"]);
     tray.setToolTip('YakYak - Hangouts client');
-    return tray.on('clicked', function() {
-      return action('showwindow');
+    return tray.on('click', function() {
+      return action('togglewindow');
     });
   };

@nerijus can you work with src/ui/views/trayicon.coffee instead of app/ui/views/trayicon.js ?

 Because it's a pain to test this way, and it won't go master unless you pr first (which means you committed, which means you worked with coffee, see ? :p ).

I never did pr before, could you please check if I did it correctly?

@nerijus are you sure you commited all your changes?

Not all, only 2 for now.

Well, it looks good so far then, i see 2 commit in your PR, with one file change in each. If you keep committing on your fork, it will add to your PR.

@mizuapo @pmsobrado @rippetoej can you check if latest beta fixes this problem?
see #451 for download link
credits to @nerijus for the fix :)

Now it hides to tray, but double (or single) click on tray to close/open
doesn't seem to work.
Anyway, good job!

Pablo Manuel Sobrado Gómez*
Projects area - Devops
Emergya Consultoría*
Tfno: +34 954 51 75 77
Fax: +34 954 51 64 73
www.emergya.es

2016-11-29 20:27 GMT+01:00 André Veríssimo<EMAIL_ADDRESS>
@mizuapo https://github.com/mizuapo @pmsobrado
https://github.com/pmsobrado @rippetoej https://github.com/rippetoej
can you check if latest beta fixes this problem?
see #451 https://github.com/yakyak/yakyak/issues/451 for download link
credits to @nerijus https://github.com/nerijus for the fix :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yakyak/yakyak/issues/338#issuecomment-263672130, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ4TmyrG3-5BEUO8K1jHIX3znaEd7UI8ks5rDHydgaJpZM4Jh8us
.

Works here on Fedora. Could be Ubuntu/Unity problem.

I'm on Ubuntu with KDE installed. But is not a major issue to me. I'll
check on Windows when I have the time.
Thanks!

Pablo Manuel Sobrado Gómez*
Projects area - Devops
Emergya Consultoría*
Tfno: +34 954 51 75 77
Fax: +34 954 51 64 73
www.emergya.es

2016-11-30 12:51 GMT+01:00 Nerijus Baliūnas<EMAIL_ADDRESS>
Works here on Fedora. Could be Ubuntu/Unity problem.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yakyak/yakyak/issues/338#issuecomment-263855275, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ4TmwlSr1DlPAhyA0X9sR7BcXZ994YKks5rDWNCgaJpZM4Jh8us
.

I've tested in Xfce and seems to work flawlesly
There are some specifics on the window manager, for instance it fails miserably in unity, but that's an unity problem.
It would be awesome if you could give feedback in windows :)

I'll check on Windows as soon as I can :)

Pablo Manuel Sobrado Gómez*
Projects area - Devops
Emergya Consultoría*
Tfno: +34 954 51 75 77
Fax: +34 954 51 64 73
www.emergya.es

2016-11-30 15:43 GMT+01:00 André Veríssimo<EMAIL_ADDRESS>
I've tested in Xfce and seems to work flawlesly
There are some specifics on the window manager, for instance it fails
miserably in unity, but that's an unity problem.
It would be awesome if you could give feedback in windows :)
[image: outsxu67pu8ax]
https://cloud.githubusercontent.com/assets/211358/20756572/13b1f612-b70b-11e6-8071-2caed49d5250.gif
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/yakyak/yakyak/issues/338#issuecomment-263890285, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AQ4Tm51k6jY0-45D4mu_kexEyHrLRc2Hks5rDYuKgaJpZM4Jh8us
.

All tray features appear to work correctly on windows 10 v1607

Single click on try icon toggles window
Close to tray works
Pressing the minimize button on the window minimizes to task bar instead of tray (I assume this is the intended action)

Is the "Toggle minimize to tray" item in the tray suppose to activate/deactivate the minimize to tray action or is it meant as another way of toggling the window between maximized/minimized? It currently toggles the window so I am guessing it is just another method for doing so.

It's another method, as single click toggle does not work on Ubuntu.

included in 1.4.0 release


Publish 8.2-20230522124337+0000

Publish 8.2-20230522124337+0000

@bot-gradle test and merge

I've triggered a build for you.

Pre-tested commit build failed.

I've triggered a build for you.


[Enhancement] fix duplicated properties is not reported

Proposed changes
Issue Number: close #32577

Further comments
If this is a relatively large or complex change, kick off the discussion at<EMAIL_ADDRESS>by explaining why you chose the solution you did and what alternatives you considered, etc...

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall

run buildall


Fixed @param typo in __constructor(), fixed parameter check in Application::route()

If you have a look at Application::route() documentation you will see that the $path can be either a string or an object with Router\Route instance. However, at line 220 the parameter check was only to see if $path has an instance of Router\Route.

Closing. I've opened #22 for the change to the constructor docblock (more changes were necessary), and the refactor on the route() method is unnecessary.


'Assign-to Type' shows incorrect value

1. Describe the bug
The field 'Assign-to Type' on Sales Price Lists and Purchase Price Lists pages doesn't show the correct value.
2. To Reproduce

Go to the pages Sales Price Lists and Purchase Price Lists
Open a Price List Header record and set 'Assign-to Type' to any value
Open the Page Inspection and see that the value you chose has been assigned to the field 'Source Type'
Go back to the list page and the 'Assign-to Type' field has not been updated
Open the Page Inspection and you will see that the 'Source Type' field has been updated

3. Expected behavior
The 'Assign-to Type' field on the list page should match the 'Source Type' field on the record.
4. Actual behavior

5. Versions:

AL Language: v11.0.827766
Visual Studio Code: 1.79.2
Business Central: 22.2 (Platform 22.0.57579.0 + Application 22.2.56969.57617)
List of Visual Studio Code extensions that you have installed: Only AL Language Extension

Let's get the issue to a team who will fix and backport it, as this repository is only for issues related to the AL compiler in latest developer preview environment for Dynamics 365 Business Central. We suggest that you open a support case or file a bug in Collaborate, to ensure that all Business Central users benefit from your catch as soon as possible.
To open a support case, you can:

Open a support request to CSS through the PartnerSource portal
Contact your Service Account Manager (SAM) in your local subsidiary to understand what is included in your contract as of support incident and PAH (Partner Advisory Hours). Your SAM might also direct you "step by step" how to open a support request or how to get credentials, if this is the first time for you or your company

If you file the bug in Collaborate, remember to include steps to reproduce the issue, and the Business Central build number and country version you're using.
If it is in the application and you already know how to fix the issue go to https://github.com/microsoft/ALAppExtensions and submit your suggestion for a fix.


#67 #68 Fix double spaces

Code Pulled from issue thread

Code Pulled from issue thread

Thanks for your PR :-)


Extract validation logic into trin-validation

What was wrong?

trin_core::types::validation::HeaderOracle -> trin_validation::oracle::HeaderOracle
trin_core::types::validation::Validator -> trin_validation::validator::Validator
trin_core::types::accumulator::MasterAccumulator -> trin_validation::accumulator::MasterAccumulator
consolidated ethportal_api::OverlayContentKey & trin_core::..::OverlayContentKey definitions into trin_types::content_key::OverlayContentKey definition

blocked by #593
How was it fixed?

[x] move associated test assets

To-Do

[ ] Add entry to the release notes (may forgo for trivial changes)
[ ] Clean up commit history

@ogenev w/ regards to the question of whether we keep ethportal-api standalone or not... imo, for the sake of moving forward let's ignore that question for this particular pr - since it's not the primary focus of this pr. We'll continue the discussion, and we can move types back into ethportal-api in a future pr if that's the course we decide upon


Click Html Missing Property Reference to Create field in TypeScript Component

Scenario:  An Angular Component property is referenced in the HTML template, but that property has not yet been created in the Angular Component.  The missing property appears underlined in the HTML.
Desired Functionality:  Provide functionality to create the property in the Component from the Context Menu or by clicking the underlined HTML. Upon this action the Component.ts file would open in the editor to allow user to complete the property definition.

This problem marker comes from an external Angular extension. Can you file the issue against the extension that you are using?

Ok thanks
On Thu, Sep 13, 2018, 2:33 AM vscodebot[bot]<EMAIL_ADDRESS>wrote:

We try to keep VS Code lean and we think the functionality you're asking
for is great for a VS Code extension. Maybe you can already find one that
suits you in the VS Code Marketplace https://aka.ms/vscodemarketplace.
Just in case, in a few simple steps you can get started writing your own
extension https://aka.ms/vscodewritingextensions. See also our issue
reporting https://aka.ms/vscodeissuereporting guidelines.
Happy Coding!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/58521#issuecomment-420899011,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEQ6guPn8sRiY16PCxrJsl1PUeHJInyLks5uafxJgaJpZM4WlfM4
.

I'll look into that.  Thanks.
On Thu, Sep 13, 2018, 2:33 AM Martin Aeschlimann<EMAIL_ADDRESS>wrote:

This problem marker comes from an external Angular extension. Can you file
the issue against the extension that you are using?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/Microsoft/vscode/issues/58521#issuecomment-420898927,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEQ6gmig6esP5x28GPGepned14EQjcXmks5uafxIgaJpZM4WlfM4
.


Setup backend

Project requirements
Create a new Rails API app called 'hello-rails-back-end'.
Initialize your project with Git.
Make sure that your project has a Postgres database set up.
Create a table for storing your messages and create 5 different greetings.
Create an API endpoint that selects a random greeting from your table (you will need a controller with an action and rails route).
Frontend PR

Hi @souad988
Excellent project 🥇 Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
STATUS: APPROVED 🟢
Congratulations! 🎉
Highlight
🔆 The API endpoint for returning a random greeting was created 🔆 A database table for storing different greetings was created 🔆 A message.rb model was created 🔆 The two apps work together
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me @Whoistolu in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

thanks for reviewing my work


ZED not detected in Ubuntu 16.04

Hi, I stuck on this problem all the day.... /(ㄒoㄒ)/~~
My laptop has two systems, Ubuntu 16.04 and Windows pro 10. I tested ZED camera in windows 10 and it works properly.
But in ubuntu, it says 'ZED not detected'.  I tried cuda9.0+ZED_v2.2.1 and cuda8.0+ZED_v2.2.0(CUDA8).
( I successfully installed cuda9.1 but failed to change the GPU device to NVIDIA GPU in NVIDIA X Server device settings. )
Is there anyone encountered this problem?
This is the kernel information:
Linux T470p 4.13.0-39-generic #44~16.04.1-Ubuntu SMP Thu Apr 5 16:43:10 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

The output of ZED Diagnostic:
ZED Diagnostic Tool

Running ZED SDK Components Diagnostic : OK

Running hardware Diagnostic : OK

Running cuda Diagnostic : OK

Running usb Diagnostic : Failed
Error:
    ZED not detected, check your USB 3.0 drivers and avoid hubs or cable extension.

Running zed Diagnostic : Failed
Error:
    ZED not detected. Connect it to an USB 3.0 port. (Blue USB ports)

Diagnostic finished, a file has been generated : ZED_Diagnostic_log.json

And the contents of ZED_Diagnostic_log.json:
{
    "ZED SDK Components": {
        "DiagnosticZEDSDKVersion": "2.2.0"
    },
    "cuda": {
        "CUDA Toolkit version": "V8.0.61",
        "SMI": "(SMI) :     Performance State               : P0",
        "deviceCount": 1,
        "deviceDriverVersion": 9000,
        "devices": [
            {
                "arch": "Maxwell",
                "computeCapability": "5.0",
                "cores": 384,
                "name": "GeForce 940MX",
                "totalMemoryBytes": "2100232192",
                "totalMemoryMB": 2002.9375
            }
        ],
        "initResult": 0,
        "loaded": true
    },
    "hardware": {
        "OS": "Ubuntu 16.04.4 LTS ",
        "PCName": "T470p",
        "avxSupported": true,
        "coreCount": "8",
        "cpu": " Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz",
        "datetime": "2018-05-02 17时57分59秒",
        "hyperThreading": "0",
        "ramCapacity": "16.552747",
        "ramUsage": "",
        "ramUsed": "1.769091",
        "threadCount": "0"
    },
    "usb": {
        "USBList": [
            {
                "idProduct": 62850,
                "idVendor": 11011
            },
            {
                "idProduct": 3,
                "idVendor": 7531
            },
            {
                "idProduct": 46528,
                "idVendor": 1266
            },
            {
                "idProduct": 2603,
                "idVendor": 32903
            },
            {
                "idProduct": 151,
                "idVendor": 5002
            },
            {
                "idProduct": 2,
                "idVendor": 7531
            }
        ],
        "ZEDDetected": false,
        "errors": [
            "ZED not detected, check your USB 3.0 drivers and avoid hubs or cable extension."
        ]
    },
    "zed": {
        "ZEDCount": 0,
        "errors": [
            "ZED not detected. Connect it to an USB 3.0 port. (Blue USB ports)"
        ]
    }
}

The output of lsusb:
Bus 002 Device 002: ID 2b03:f582
Bus 002 Device 001: ID 1d6b:0003 Linux Foundation 3.0 root hub
Bus 001 Device 004: ID 04f2:b5c0 Chicony Electronics Co., Ltd
Bus 001 Device 003: ID 8087:0a2b Intel Corp.
Bus 001 Device 002: ID 138a:0097 Validity Sensors, Inc.
Bus 001 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub

I can figure out that Bus 002 Device 002: ID 2b03:f582  is actually the ZED camera but there is no more detail information about it. I can read video stream using opencv VidoeCapture form ZED. It seems like ZED SDK can't recognize the ZED camera or the driver of ZED camera doesn't work properly.

Hi,
Yes this is a known issue with recent kernels and older ZED SDK (For more details : https://github.com/stereolabs/zed-examples/issues/53).

Thanks for your quickly replay.
I noticed you said one possible solution is upgrade to CUDA 9 and use a ZED SDK >= 2.2.1.
But I just tried CUDA 9.0 and ZED SDK 2.2.1, and it reported the same problem.
Since CUDA 9.1 seems not work properly in my environment.
Is that means I have to downgrade the kernel to 4.4?

Ok actually I missed it at first but it looks like you upgraded the camera firmware.
The firmware you are currently using requires the ZED SDK 2.4.0.
So either upgrade to the latest ZED SDK or downgrade your firmware to v.1142. For the downgrade, you'll need to be able to open the ZED (using the same SDK installation to upgrade for instance)

I am able to open ZED in windows 10 and I can downgrade the firmware.
Thanks very much!

It finally works with firmware v.1142.
:)

hello ,I have the same problem,can you tell me how to downgrade the firmware? Thanks!

@adujardin can you tell me how to downgrade the firmware.Thanks

First, you have to make sure that you can open ZED normally (I can access ZED in windows10).
Then, the firmware update option can be found in settings of ZED Explorer, choose the right firmware and click OK.

see here :
https://github.com/stereolabs/zed-examples/issues/63#issuecomment-387938044

Facing the same issue.
ZED SDK 2.4.0, Firmware 1523, Cuda 9
Works with windows 7 but Camera isn't detected in Linux(Ubuntu 16.04)
Also tried with SDK version 2.8, doesn't work. Any help?

Facing the same issue.
ZED SDK 2.4.0, Firmware 1523, Cuda 9 , Ubuntu kernel version 4.15.0-51-generic
Works with windows 7 but Camera isn't detected in Linux(Ubuntu 16.04)
Also tried with SDK version 2.8, doesn't work. Any help?

I think this is an issue with the kernel version. Can someone please mention the correct kernel version to be used? I am facing the same issue.

I can't put the fireware button down.
Could you tell me any other method to update the fireware to v.1142


Adding smcpp to fsc dadi pipeline

Adding smc++ to the pipeline started by Chris Kyriazis. After running this pipeline we will get results from fastsimcoal2, dadi and smc++. This version of the pipeline only works when the chromosome 22 is the only chromosome specified in the json file. I will work on fixing this later. However, I got the first results from running this whole pipeline using the Gutenkunst model:

In the case of SMC++ I only report the values of N1 and N2 using the harmonic mean. I also report the divergence time for SMC++. Those values are underestimated compared to the true values. SMC++ assumes a model where there is no post-divergence gene flow, so the violation to this assumption is probably the culprit behind the underestimations. The review "Inference of population history using coalescent HMMs: review and outlook" from Spence et al (2018) reports: "Users should also be careful about model choice. As an example, SMC++ infers population splits in the absence of gene flow. If there has been pervasive migration between the populations of interest, then the model inferred by SMC++ will not be reflective of reality." The amount of gene flow postdivergence in the Gutenkunst model is sufficient to be a violation of this assumption. It would be good to have a model in stdpopsim where there is no post-divergence gene flow to confirm that SMC++ is working well on that setting.
I also have a plot with the output of 10 SMC++ runs, shown here below. @petrelharp you mentioned that you had a way to combine the results from the SMC++ runs. Let me know what is your suggestion to present these results.

This looks promising, @dortegadelv! Thanks. I don't recall the method you're talking about, maybe it was someone else (@andrewkern maybe?)?
About the plots: the first one would be easier to see if the different methods were offset and not overlapping, or maybe as boxplots. And, what's the vertical blue lines in the second one?

Thanks for your comments @petrelharp ! That makes sense, I will play a little bit with the boxplots.
The vertical blue lines are the split times in the second plot are the split times.
I will work on making this pipeline work with more chromosomes, and I will do tests with some alternative demographic models.

The pipeline now gets demographic parameter estimates from fastsimcoal, dadi and smc++ using any arbitrary number of chromosomes. Previously it only worked when a single chromosome was specified. I just tested the pipeline by doing simulations under the Gutenkunst model using chromosomes 21 and 22. Some results are shown below:
EstimatesParameters.pdf
The pipeline should work when using the Drosophila demographic model, @ckyriazis . If someone  finds problems when testing the pipeline, please let me know.

Awesome, thanks Diego! I will try to run this with Drosophila this week.

okay we are going to need some reviewers on this. Any volunteers? tagging people in hopes they have time @ckyriazis @jradrion @cjbattey @jgallowa07

I'll have a look at it @andrewkern.

Hey @dortegadelv, I'm getting this error during the run_scmpp step:
smc++ estimate: error: argument mu: invalid float value: 'treespop1.smc.gz'
Any idea what might be causing this?

Let me check! Can i get a look at your json file?

Yes - here it is:
{     "seed" : 12345,     "num_sampled_genomes_per_replicate" : 50,     "replicates" : 10,     "species" : "drosophila_melanogaster",     "model" : "LiStephanTwoPopulation",     "genetic_map" : "Comeron2012_dm6",     "chrm_list" : "chr2R",     "generation_time" : "0.1" }

Quick question, what is the value of the variable "mutation_rate" in the "LiStephanTwoPopulation" model? I think smc++ is complaining about the value of that variable not being a float value. If that is not the problem, I will think a little bit more about what is going on.

the mutation_rate parameter isn't a property of most demographic model in stdpopsim, so it gets set at the time of simulation on the analysis side of things.
for instance in the single population case we set the mutation using the default_mutation_rate variable associated with the drosophila genome here https://github.com/popgensims/analysis/blob/607772593ef8042a18d72dea2098e4d55f87dcc0/n_t/simulations.py#L16

I see! Yes, I am using the following line to assign the value to the mutation_rate parameter in the Snakemake file:
mutation_rate = species.genome.mean_mutation_rate
I wonder if "species.genome.mean_mutation_rate" is undefined in the "LiStephanTwoPopulation" model. Maybe switching the past line to the following one should do the trick if the definition of the mutation_rate parameter is the problem:
mutation_rate=chrom.default_mutation_rate

no, what you are doing should work. for instance here are a few lines from the interpreter
>>> import stdpopsim
>>> stdpopsim.drosophila_melanogaster.genome.mean_mutation_rate
8.400000000000002e-09
>>> stdpopsim.homo_sapiens.genome.mean_mutation_rate
1e-08
>>> stdpopsim.arabidopsis_thaliana.genome.mean_mutation_rate
7e-09

i'll take a look through your code

i took a quick look and your Snakefile looks fine to me in how you are handling mutation_rate

So following up on this - I thought maybe the error had something to do with subprocess trying to feed 'treespop1.smc.gz' as the mutation rate to smc++. I havent really used either subprocess or smc++ though, so I'm not in the best position to debug.

I'll take a look at this. I am going to run the program using your json file to see what is going on.

I am trying to run the "LiStephanTwoPopulation" model using @ckyriazis json file and I am getting these errors:
TypeError in line 48 of /Users/vicentediegoortegadelvecchyo/Dropbox/Documents/LIIGH/Proyectos/PopSim/AlternativeBranch/analysis-2fcf02fccca7ff2f21073fedbc66d65b73c873d5copy/two_population_analysis/Snakefile:
init() got an unexpected keyword argument 'metadata'
File "/Users/vicentediegoortegadelvecchyo/Dropbox/Documents/LIIGH/Proyectos/PopSim/AlternativeBranch/analysis-2fcf02fccca7ff2f21073fedbc66d65b73c873d5copy/two_population_analysis/Snakefile", line 48, in
File "/Users/vicentediegoortegadelvecchyo/miniconda3/envs/popsim_env_test/lib/python3.6/site-packages/stdpopsim-0.1.dev149+gfe658a2-py3.6.egg/stdpopsim/drosophila_melanogaster.py", line 138, in init
ERROR:snakemake.logging:TypeError in line 48 of /Users/vicentediegoortegadelvecchyo/Dropbox/Documents/LIIGH/Proyectos/PopSim/AlternativeBranch/analysis-2fcf02fccca7ff2f21073fedbc66d65b73c873d5copy/two_population_analysis/Snakefile:
init() got an unexpected keyword argument 'metadata'
File "/Users/vicentediegoortegadelvecchyo/Dropbox/Documents/LIIGH/Proyectos/PopSim/AlternativeBranch/analysis-2fcf02fccca7ff2f21073fedbc66d65b73c873d5copy/two_population_analysis/Snakefile", line 48, in
File "/Users/vicentediegoortegadelvecchyo/miniconda3/envs/popsim_env_test/lib/python3.6/site-packages/stdpopsim-0.1.dev149+gfe658a2-py3.6.egg/stdpopsim/drosophila_melanogaster.py", line 138, in init
Has anyone bumped into these errors before? Is there a quick way to fix them?

I'm fairly certain this is a version issue with the stdpopsim repo.

Just tried doing that:
__popsim_env_test) vicente-diego-ortega-del-vecchyos-macbook-pro-3:stdpopsim vicentediegoortegadelvecchyo$ git fetch upstream master
warning: no common commits
remote: Enumerating objects: 285, done.
remote: Total 285 (delta 0), reused 0 (delta 0), pack-reused 285
Receiving objects: 100% (285/285), 1.28 MiB | 1.32 MiB/s, done.
Resolving deltas: 100% (135/135), done.
From https://github.com/popgensims/analysis

branch            master     -> FETCH_HEAD
[new branch]      master     -> upstream/master
(popsim_env_test) vicente-diego-ortega-del-vecchyos-macbook-pro-3:stdpopsim vicentediegoortegadelvecchyo$ git pull upstream master
From https://github.com/popgensims/analysis
branch            master     -> FETCH_HEAD
Auto-merging README.md
CONFLICT (add/add): Merge conflict in README.md
Auto-merging LICENSE
CONFLICT (add/add): Merge conflict in LICENSE
Automatic merge failed; fix conflicts and then commit the result.
(popsim_env_test) vicente-diego-ortega-del-vecchyos-macbook-pro-3:stdpopsim vicentediegoortegadelvecchyo$ python setup.py install
running install
..._

And I ran the snakemake file again and got the same error. Let me know if I am doing something wrong here or I am not following correctly your suggestion @andrewkern . Thanks.

Hey @dortegadelv -
I've mostly caught up to speed with how your analysis pipeline is working (I had to change msp to tsk as the sample labels in smc.py because of the vcf output from the updated msprime), and I'm now getting the same error as @ckyriazis with smc++. It seems to be an issue with the --base flag, which lets you set the output file name something other than the default. I think that was a more recent change to the smc++ code, so this could be a smc++ version issue? What version do you have installed? (conda says mine is updated, with version SMC++ v1.13.1, but if you installed it differently, maybe you have a more recent version?)
Removing the --base flag and changing the relevant output copying lines in the Snakefile looks to have gotten around that issue for me.

Hey @apragsdale , thanks for helping me debug this. My current version of smc++ is v1.15.2 , that might be the problem. I am going to check if I can run smc++ without the --base flag in the newest version of smc++.

I think I fixed the problems with smc++ based on @apragsdale 's input in this new commit. Now smc.py does not use the --base flag. I did not have to change the msp to tsk as the sample labels in smc.py since the vcf files I was getting had msp as the sample labels. The updated Snakefile and smc.py files are ready to be tested @ckyriazis . Hope everything runs smoothly this time.

Running it now @dortegadelv - seems to be working but I also had to change msp to tsk. If I dont run into any other issues, I'll merge this in with my updated pipeline with masking and then run that on the human and drosophila data.

Hey @dortegadelv, I've been working on folding in your pipeline with smc++ with some updates I made to implement masking for dadi and fsc and everything seems to be working.
The main thing left to do is implement masking for smc++. Would you be able to do that? @andrewkern has already done that for the the n_t pipeline here so it should be relatively simple to translate what he did to the two population case.

Hey @ckyriazis , I am on it. I just modified the pipeline to mask regions in smc++ following @andrewkern 's pipeline. I am running a test example. If things work well, I will update the pipeline in one day or two.

let me know if i can help at all along the way guys!

I have implemented masking for smc++ following @andrewkern 's code. I think it is ready for you to take a look, @ckyriazis . You might need to change the labels msp to tsk.
@andrewkern : I copied your code in the function 'write_smcpp_file' from the smc.py file to update the function 'write_smcpp_file_twopops'. If you have a chance to take a look at my function to make sure I did not make a mistake, that would be very appreciated.

I will look at this in a bit, but just a heads up @dortegadelv and @ckyriazis-- @jeromekelleher has done a major refactor of stdpopsim that we are currently reviewing so we will need to do a bit of a rewrite on the simulation side of the two population pipeline once that is merged.

Sounds good @andrewkern. I have an updated pipeline incorporating @dortegadelv's progress with smc++ and the masking I added for fsc and dadi that I am nearly ready to push.
Also, just a note that I realized the problems I was having on my laptop (but not our lab computer) doing the masking was a pandas version issue - it worked with 0.24.2 but not 0.25.0. So perhaps we should specify that in requirements.txt

The changes upstream in stdpopsim mean that this branch won't work now @dortegadelv and @ckyriazis. I've opened a PR with changes in #48 show the updates needed to work with the new stdpopsim API. Ideally, you should work with the CLI (as in the two population analysis), but the Python API is also reasonably convenient.
If you like, I can create a PR against this branch with the required changes to make your simulations work again. However, it would be good to do this after #48 is merged and you have rebased your branch.

Sounds good @jeromekelleher. I have a PR I'm nearly ready to send through with some updates on the analysis pipeline, so I can add the needed changes to that.

@ckyriazis is this PR ready for us?

Hey @andrewkern - I made a new PR with a bunch of more recent updates called "updates for compatibility with stdpopsim changes" that needs review. Would be great if you could have a look at it (and perhaps try to run it) to see if everything looks ok.

closing this down as resolved with https://github.com/popgensims/analysis/pull/49


Question: gyp & Python?

During my npm install -g ldapjs I get several lines of errors starting with
gyp ERR! find Python
gyp ERR! find Python Python is not set from command line or npm configuration
gyp ERR! find Python Python is not set from environment variable PYTHON
gyp ERR! find Python checking if "python" can be used.....
is Python a requirement for the installation/use of ldapjs?

That's a node-gyp message. Please see https://github.com/nodejs/node-gyp for information on node-gyp.
I suspect this is only showing up in ldapjs@1. It is unlikely that<EMAIL_ADDRESS>shows this issue. Feel free to reopen if you are experiencing otherwise.

⚠ This issue has been locked due to age. If you have encountered a recent
problem that seems to be covered by this issue, please open a new issue.
Please include a minimal reproducible example
when opening a new issue.


Coverage work on InMemoryEmbeddingStore.

@crutcher please check https://github.com/langchain4j/langchain4j/pull/513/files, there might be conflicting changes


fix missing comma for issue 318

What type of PR is this?

Uncomment one (or more) /kind <> lines:

/kind bug

/kind cleanup

/kind design

/kind documentation

/kind failing-test

/kind feature

If this PR will release a new chart version please make sure to also uncomment the following line:

/kind chart-release

Any specific area of the project related to this PR?

Uncomment one (or more) /area <> lines:
/area falco-chart

/area falco-exporter-chart

/area falcosidekick-chart

What this PR does / why we need it:
Fixes https://github.com/falcosecurity/charts/issues/318 - missing comma in the allowed_kube_namespace_image_list list
Which issue(s) this PR fixes:
Fixes https://github.com/falcosecurity/charts/issues/318

Special notes for your reviewer:
Checklist

[X] Chart Version bumped
[X] Variables are documented in the README.md
[X] CHANGELOG.md updated

Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:

e64cf86 fix missing comma for issue 318
20f7f5d update changelog, bump chart

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Kostavro
To complete the pull request process, please assign bencer after the PR has been reviewed.
You can assign the PR to them by writing /assign @bencer in a comment when ready.
The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

falco/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Welcome @Kostavro! It looks like this is your first PR to falcosecurity/charts 🎉

[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: cpanato, Kostavro
The full list of commands accepted by this bot can be found here.
The pull request process is described here

Needs approval from an approver in each of these files:

falco/OWNERS [cpanato]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

LGTM label has been added.  Git tree hash: c0396e27d912ee5745b0d415ac53ce8eee591aee


Cache is not working on app start

Describe the bug
When I use the Query() widget right at the start of the app, the cache is not working.  But after i press on a button to execute a refetch, everything works... So the cache is available, but somehow not right at the start of the app.
Expected behavior
The cache should be available right at the start of the app.
Maybe if there are reasons why it takes some time for the cache to come up, the Query() widget should wait for it?
Desktop (please complete the following information):

OS: Windows
Version 10

Smartphone (please complete the following information):

Device: Xiaomi Mi 9T Pro
OS: Android
Version 10

Actually I found out, that it is kind of working in release mode, but I am not sure if I can say that for every device.. because clearly something is off with this and its still not working perfectly..
So when I open the app without internet its working fine in release mode, but if I open it with network on I don't see any cache but a progress bar until the network request is finished..
Thats not how it should be.

Same issue for me. It gives host look up error rather than loading data from cache itself

You can try to overcome this by applying the cache only fetch policy in case the internet connection is missing
https://github.com/zino-app/graphql-flutter/blob/42d010c177f7fa752b9a0b5ca57548dd1cd3ad8f/packages/graphql/lib/src/core/query_options.dart#L21

There could also be the case when cache hydrates without awaiting to finish...
This requires additional investigation...

if I use cache only I get CacheMissException

Okay so in my case cacheOnly works. Thats kind of interesting 🤔
Now the question is, why is the cache working if you use cacheOnly, but not if you use cacheAndNetwork when starting the app?

Actually I have to take back what I said.
So after playing around a bit more it turned out, that also cacheOnly isn't working all the time.
It's definitely better than cacheAndNetwork but its far from perfekt.
When I use a FutureBuilder to wait until getApplicationDocumentsDirectory() succeeds I get it working all the time on my device, but thats a weird hack and I have no idea if that would work on every device as this seems to be some kind of a performance thing? "If you wait long enough you might just get the cache " or something ...
So this really still is a huge bug and the seems to be no real workaround right now.

It seems the built in approach to launch 'getApplicationDocumentsDirectory()' is not working as expected)
If you could prepare the reproducible github repo I'll take a look and may be will be able to create PR

Thats very nice of you thanks.
My current project is closed source, but I will try to build a small version for demonstration purposes ASAP :)

Just as a small update:
Even with the FutureBuilder waiting for getApplicationDocumentsDirectory()
I get a CacheMissException 1 out of 10 tries or something like that.

Thanks for your active help in investigating this issue!

You are welcome :) But my intentions are purely egoistic, as I need this bug to be fixed :D
So I created a simple app that showcases my issue:
https://github.com/lazylazyllama/graphql_flutter-cache-on-start-issue
By default I configured the cache to be cacheAndNetwork so that you can see something by launching the app first. As the cache needs to be created anyways at some point.
You can easily change that to cacheOnly here

Thanks I’ll take a look!

That's cool thanks you a lot :)
While playing around I also noticed, that there is a similar issue that happens at runtime and it might be related.
So what I did was:
final result = await graphql.GraphQLProvider.of(context).value.query(graphql.QueryOptions(
    documentNode: SchoolQuery().document,
));

And right after that I tried to read that value with a Query() Widget and cacheOnly as the FetchPolicy. But what I get is a CacheMissException. But after a restart its working except on those 1 out of 10 or 20 or 30 .. :D times
Context: This is part of my logging in process. I do the first fetch to put the School into the cache and after that I navigate to the main page, which uses cacheOnly.

You are welcome :) But my intentions are purely egoistic, as I need this bug to be fixed :D
So I created a simple app that showcases my issue:
https://github.com/lazylazyllama/graphql_flutter-cache-on-start-issue
By default I configured the cache to be cacheAndNetwork so that you can see something by launching the app first. As the cache needs to be created anyways at some point.
You can easily change that to cacheOnly here

Tried to run your example. Seems to be throwing CacheMissException every single time.
Ran the app with cacheAndNetwork policy, and then changed it to cacheOnly but no success

I don't get this issue anymore using Hive Storage in 4.0.0 alpha


[HOLD for payment 2024-10-25] [Wave Control] [QBD] Advanced settings main page

Will be worked on by an external contributor (see https://expensify.slack.com/archives/C03SLTAEULW/p1726876645021139).
Design doc link: https://docs.google.com/document/d/1LQNlTBlHjFqRdru_4UkqVr0QRseNNDq2IhFFpXcgfwY/edit#bookmark=id.vnq8rnmobwkj

👋 checklist time!

Ah, @lakchote will the QBD regression tests get added centrally once the project launches?
Payment summary as follows:

$250 to @hoangzinh for the C+ review (go ahead and request)
$250 to @ZhenjaHorbach for the fix (offer sent!)

Ah, @lakchote will the QBD regression tests get added centrally once the project launches?
Yes an issue has been created for it.

$250 approved fro @hoangzinh

Perfect. Paid @ZhenjaHorbach, closing!


Javascript via src

Hello!
Is it possible to inject multiply javascripts to pages via src, instead of writing javascript code in phishlet js_inject.
And maybe there is possability to choose where to put it in landing page? For example before  and/or after .
If it is not possible without you customazing the core, please say where i should to dig and search.
Thank you.

Currently it is only possible to inject via js_inject in the phishlet as you saw.
For specifics please refer to the wiki: https://github.com/kgretzky/evilginx2/wiki/Phishlet-File-Format-(2.3.0)


Let SQLite use pread/pwrite

With current settings SQLite was using lseek/read syscalls to read data, e.g.:
20:43:17.640660 fcntl(3, F_SETLK, {l_type=F_UNLCK, l_whence=SEEK_SET, l_start=0, l_len=0}) = 0
20:43:17.640683 fcntl(3, F_SETLK, {l_type=F_RDLCK, l_whence=SEEK_SET, l_start=1073741824, l_len=1}) = 0
20:43:17.640705 fcntl(3, F_SETLK, {l_type=F_RDLCK, l_whence=SEEK_SET, l_start=1073741826, l_len=510}) = 0
20:43:17.640725 fcntl(3, F_SETLK, {l_type=F_UNLCK, l_whence=SEEK_SET, l_start=1073741824, l_len=1}) = 0
20:43:17.640744 stat(".../neo.sqlite-journal", 0x7ffef2c91080) = -1 ENOENT (No such file or directory)
20:43:17.640764 lseek(3, 24, SEEK_SET)  = 24
20:43:17.640779 read(3, "\0\0\0\33\0\0\10\235\0\0\10]\0\0\0\27", 16) = 16
20:43:17.640795 stat(".../neo.sqlite-wal", 0x7ffef2c91080) = -1 ENOENT (No such file or directory)

but if we allow it to use pread it will be only 1 system call instead of 2 and
reading this way can also be done in parallel because there is no global to
file seeking:
20:48:42.668466 fcntl(3, F_SETLK, {l_type=F_UNLCK, l_whence=SEEK_SET, l_start=0, l_len=0}) = 0
20:48:42.668501 fcntl(3, F_SETLK, {l_type=F_RDLCK, l_whence=SEEK_SET, l_start=1073741824, l_len=1}) = 0
20:48:42.668522 fcntl(3, F_SETLK, {l_type=F_RDLCK, l_whence=SEEK_SET, l_start=1073741826, l_len=510}) = 0
20:48:42.668542 fcntl(3, F_SETLK, {l_type=F_UNLCK, l_whence=SEEK_SET, l_start=1073741824, l_len=1}) = 0
20:48:42.668561 stat(".../neo.sqlite-journal", 0x7ffdbc1f22c0) = -1 ENOENT (No such file or directory)
20:48:42.668580 pread64(3, "\0\0\0\33\0\0\10\235\0\0\10]\0\0\0\27", 16, 24) = 16
20:48:42.668597 stat(".../neo.sqlite-wal", 0x7ffdbc1f22c0) = -1 ENOENT (No such file or directory)

(if needed this enablement can be done per OS)

Coverage remained the same at 68.639% when pulling f675967c5485302062dbe18c8e0f9146cb1cc81c on navytux:y/preadwrite into 3c6eef45ff2de301fee18d11cd8727f65754eeb5 on mattn:master.

Thank you

Thanks for merging.


Improve experience when deploying a zip file directly

Allow users to right click on a zip file and "Deploy to Web App..."
Allow users to select "zip" file when they select "Browse..." in the workspace quick pick
Don't prompt for "Always deploy workspace" when deploying a zip (The check for the ".deployment" file doesn't work in this case)

This issue has become stale and is at risk of being closed. The community has 60 days to upvote the issue. If it receives 5 upvotes we will keep it open and take another look. If not, we will close it. To learn more about how we handle issues, please see our documentation.
Happy Coding!

:slightly_frowning_face: In the last 60 days, this issue has received less than 5 community upvotes and we closed it. Still a big Thank You to you for taking the time to create it! To learn more about how we handle issues, please see our documentation.
Happy Coding!


yaks upload does not work

I have downloaded and executed the extension example but I got following error message:
Error: error while creating deployment for source code: exit status 1
I tried it also with the -v flag but the output was the same. How can I get more information or find the root cause of this problem?

The extension upload feature uses a library called Snap (https://github.com/container-tools/snap) which is in alpha state and most probably needs an update to work on later Kubernetes platforms.
Which Kubernetes version and platform are you working with (Minikube?)
For more information about the error you can have a look into the YAKS operator log output.
kubectl logs -l app=yaks -n <operator -namespace> --tail 1000

We are using AWS EKS, but we have stopped using YAKS and have removed the YAKS operator.


GameUserSettings.ini from /ark/config is not well linked

Image Setup Details

Image Tag: latest
Docker Host OS: linux, Ubuntu 20.04

Description of Issue
GameUserSettings.ini located in volume ark at
/ark/config/GameUserSettings.ini
is first symbolic linked by run.sh but then is overwritten by arkmanager at startup
The only solution seems to use env variables.
How can i set an env variable for this?
[MessageOfTheDay]
Duration=30
Message="Blah"

Hey @caporalesimone, looking into this one. Could you provide your docker run statement or your docker-compose.yml and an example of a GameUserSettings.ini that you would be using, just so I can make sure to accurately reproduce the issue?

Hi,
i prefer to use podman instead of docker but i don't think is the problem.
This is my actual run
podman run -it --name ark --env-file ./env.list -v steam:/home/steam -v ark:/ark -p 27015:27015 -p 27015:27015/udp -p 7778:7778 -p 7778:7778/udp -p 7777:7777 -p 7777:7777/udp thmhoag/arkserver
and this is the restart command
podman start -ai ark
env.list:
`am_arkflag_crossplay=True
am_arkflag_NoBattlEye=True
am_serverMap=TheIsland
am_arkwarnminutes=15
am_ark_SessionName=Terraria Team
am_ark_ServerAdminPassword=#######
am_ark_MaxPlayers=70
am_ark_MaxPlayers=70
am_ark_QueryPort=27015
am_ark_Port=7778
am_ark_RCONPort=32330
am_ark_ServerCrosshair=True
am_ark_ServerPassword=
am_ark_RCONEnabled=True
am_ark_RCONServerGameLogBuffer=600.000000
am_ark_alwaysNotifyPlayerJoined=True
am_ark_alwaysNotifyPlayerLeft=True
am_ark_allowThirdPersonPlayer=True
am_ark_globalVoiceChat=True
am_ark_AutoSavePeriodMinutes=5.0
am_ark_ShowMapPlayerLocation=True
am_ark_serverPVE=True
am_ark_DisableStructureDecayPvE=True
am_ark_DisableDinoDecayPvE=True
am_ark_AllowFlyerCarryPvE=True
am_ark_bAllowPlatformSaddleMultiFloors=True
am_ark_AllowCaveBuildingPvE=True
am_ark_StructureDamageMultiplier=2.0
am_ark_PerPlatformMaxStructuresMultiplier=2.0
am_ark_ResourcesRespawnPeriodMultiplier=0.2
am_ark_DinoCharacterFoodDrainMultiplier=0.001
am_ark_DinoCharacterStaminaDrainMultiplier=0.1
am_ark_TribeNameChangeCooldown=1
am_ark_ItemStackSizeMultiplier=10
am_ark_MaxTamedDinos=20000
am_ark_TheMaxStructuresInRange=30000.000000
am_ark_OxygenSwimSpeedStatMultiplier=2.000000
am_ark_PlatformSaddleBuildAreaBoundsMultiplier=1.000000
am_ark_KickIdlePlayersPeriod=3600.000000
am_ark_AllowHitMarkers=True
am_ark_StructurePreventResourceRadiusMultiplier=1.0
am_ark_AlwaysAllowStructurePickup=True
am_ark_StructurePickupTimeAfterPlacement=90.0
am_ark_StructurePickupHoldDuration=0.5
am_ark_AllowIntegratedSPlusStructures=True
am_ark_NightTimeSpeedScale=1.5
am_ark_DayTimeSpeedScale=0.5
am_ark_PlayerDamageMultiplier=1.5
am_ark_PlayerResistanceMultiplier=0.7
am_ark_XPMultiplier=1.75
am_ark_TamingSpeedMultiplier=2.0
am_ark_HarvestAmountMultiplier=3.5
am_ark_HarvestHealthMultiplier=3.0
am_ark_PlayerCharacterWaterDrainMultiplier=0.001
am_ark_PlayerCharacterFoodDrainMultiplier=0.001
am_ark_PlayerCharacterStaminaDrainMultiplier=0.1`
With this setup all is working as expected because params are all passed in command line.
if i shorten the env.list in this way:
am_arkflag_crossplay=True am_arkflag_NoBattlEye=True am_serverMap=TheIsland am_arkwarnminutes=15 am_ark_SessionName=Terraria Team am_ark_ServerAdminPassword=####### am_ark_MaxPlayers=70 am_ark_MaxPlayers=70 am_ark_QueryPort=27015 am_ark_Port=7778 am_ark_RCONPort=32330 am_ark_ServerCrosshair=True am_ark_ServerPassword= am_ark_RCONEnabled=True
and i put all other settings in GameUserSettings.ini in /ark/config (removing am_ark_ prefix)
i don't have any effect of those variables.
As run.sh do, i expect should be a symbolic link in /ark/server/ShooterGame/Saved/Config/LinuxServer/GameUserSettings.ini but instead there is a real file  that is quiet different from che /ark/config.
`
steam@ee4dba28afca:/ark/server/ShooterGame/Saved/Config/LinuxServer$ ls -la
total 40
drwxr-xr-x 2 steam steam 4096 Jun 21 20:30 .
drwxr-xr-x 4 steam steam 4096 Jun 20 00:20 ..
-rw------- 1 steam steam    1 Jun 21 20:29 Compat.ini
-rw------- 1 steam steam    1 Jun 21 20:29 DeviceProfiles.ini
-rw------- 1 steam steam    1 Jun 21 20:29 Engine.ini
lrwxrwxrwx 1 steam steam   20 Jun 21 20:28 Game.ini -> /ark/config/Game.ini
-rw------- 1 steam steam 5922 Jun 21 20:32 GameUserSettings.ini
-rw------- 1 steam steam    1 Jun 21 20:29 Input.ini
-rw------- 1 steam steam    1 Jun 21 20:29 Scalability.ini
-rw------- 1 steam steam    1 Jun 21 20:29 Lightmass.ini
`
i think that somehow arkmanager substitute symlink with an other GameUserSettings.ini
Game.ini is correcly symlinked and works as expected
Tnx
Simone

Hey @caporalesimone, completely agree about podman, just want to make sure I'm getting as close as I can to reproducing the exact issue.
For this one in particular, could you add the following environment variables to your container and see if it resolves the issue for you:

am_arkGameUserSettingsIniFile=/ark/config/GameUserSettings.ini
am_arkGameIniFile=/ark/config/Game.ini

If the above values to resolve the issue I'll make a change to have those set as the default.

@thmhoag i did what you asked but does not change.
I don't see any setting that i wrote in /ark/GameUserSettings.ini
env.list was:
`
am_arkflag_crossplay=True
am_arkflag_NoBattlEye=True
am_serverMap=TheIsland
am_arkwarnminutes=15
am_arkGameUserSettingsIniFile=/ark/config/GameUserSettings.ini
am_arkGameIniFile=/ark/config/Game.ini
am_ark_SessionName=Terraria Team
am_ark_ServerAdminPassword=######
am_ark_MaxPlayers=70
am_ark_QueryPort=27015
am_ark_Port=7778
am_ark_RCONPort=32330
am_ark_ServerCrosshair=True
am_ark_ServerPassword=
am_ark_RCONEnabled=True
am_ark_RCONServerGameLogBuffer=600.000000
`

Hey @caporalesimone, was your file located at /ark/GameUserSettings.ini or /ark/config/GameUserSettings.ini?
The image will generally expect it to be in /ark/config/GameUserSettings.ini.

Sorry my mistake while wrinting previous message. It was in correct path /ark/config/GameUserSettings.ini

Hey @caporalesimone, sorry for the delay here. I've attempted to reproduce this with my own servers but I am seeing the file get linked properly. Based on your original podman command, it looks like you're using a named volume for the /ark mount? If so, how did you end up getting the GameUserSettings.ini into the named volume?
I used docker cp, but that's about the only other thing that I can think of that might be different between our setups at this point.


[IconButton] Tooltip ripple redraws as I mouse over SVG icon

Problem description
I have a Toolbar containing a ToolbarGroup which in turn contains some IconButtons, all of which have tooltips. Each button has an SVG icon as its child. When I mouse over the icon, the tooltip ripples nicely into place as expected. However, as I move my mouse around over the icon, the ripple keeps animating repeatedly. At first I thought it was random, but it looks like it keep animating when the mouse enters or leaves the SVG path itself. The expected behavior, and the behavior seen here, is that the tooltip stays in place as long as the mouse is over the IconButton itself.
Steps to reproduce
The minimum case where I observed this behavior is this:
<Toolbar>
  <ToolbarGroup>
    <IconButton tooltip="Tooltip text here">
      <SomeIcon />
    </IconButton>
  </ToolbarGroup>
</Toolbar>

where SomeIcon is an SVG icon imported like this:
import SomeIcon from 'material-ui/svg-icons/action/home';

Versions

Material-UI: 0.15.4
React: 15.3.2
Browser: Chrome 53.0.2785.92

We have been porting the component on the v1-beta branch. We reimplemented it from the ground-up. While we haven't tested it, I think that the issue is most likely fixed on that branch. Hence, I'm closing it.
Still, we will accept PR fixes until v1-beta takes over the master branch.


Airlocks sound weird

Description
It kind of sounds like their sounds play 2x, when I'm throwing the crowbar at the doors, it sometimes sounds normal but other times does not. I'm guessing that stuff is colliding with it twice? for some reason? @metalgearsloth
https://user-images.githubusercontent.com/19853115/116831051-01c89780-ab62-11eb-9fe6-55d65607789a.mp4

Dupe. Animation is playing twice.


Disappearing items

Sometimes, placing items in an auto sort enabled chest will disappear, (i.e you place an item in a chest and it vanishes 1-2s later)
and cannot be found in any other chest, including attempting to summon them with a high priority chest. Some of the items that have disappear have never been configured on any auto sort chest. (E.g. the advanced scarecrow & trade coins). There is no consistency to which items disappear but it doesn't appear to happen to items which are configured to be picked up by other chests.
Other loaded mods just in case this is a mod conflict (Note, none of the other mods interact with chests)

Advanced Basic Cultivation
Arashi's Raft Fishing Expansion
BetterFPS
BiggerPlots
Craft Plant Seeds
Diagonal Pillars
Dissociation Dissimulation
Lantern Shadows
Mirrored Engines
Modutils
Recursive placement
Renewable Farms
Where is my dishes

That is rather strange. The whole transfer logic should not kick in at all for items not set to be transferred. I cannot think of a way the auto sorter would touch those items as they are ignored. It could be a specific issue with your world setup which creates a corner case for the mod.
I know it has been a while, but if you happen to experience that issue again and you can reproduce it, make sure you enable "Debug" mode for the mod in the settings. Wait for items to disappear and send me your log file afterward.
You can find the log file @ %userprofile%\AppData\LocalLow\Redbeet Interactive\Raft\Player.log

Thanks Peettee,
We never got to the bottom of this, but as we spent more time on the raft additional issues started popping up like the chests would show as upgraded for some players and not for other players, sometimes only the host could upgrade the chests.
We have since move onto another game and in the end our raft was a little over 500 foundations so possibly we just asked too much of the game.
Happy for you to close the issue given no one else seems to be having it.

I will leave the issue open for now in case someone else stumbles upon the same issue in the future.
If you still have your saved world I'd be curious to try it out myself though and see if I can get things reproduced, if not I will have to wait for someone else to have that issue.
Thanks for reporting.


Remove base64 from snap and use binary from the core snap

In snapd 2.35, the default apparmor profile will allow base64 access from the core snap:
https://github.com/snapcore/snapd/pull/5642/files#diff-a34e166c5b3016c122430c5884f41e9bR110
Once 2.35 is promoted to stable, we can stop staging the base64 binary in the snap and use it from the core snap.

2.35 has been promoted to stable, so we can remove this base64 part from the snap.
Also unclear if the base64 command is still needed by the security services or not with the new implementation written in go instead of the shell scripts.

This has been resolved in cali, and just needs to be merged to master before we can close this.
See PR: https://github.com/edgexfoundry/edgex-go/pull/587


Step 10 Deep Linking - Up button not showing

Step 10 "Deep Linking to a destination" contains the following screen shot at the end of the page. Notice the Up button on the upper-left corner.

I can't speak for others, but the Up button never showed up for my case, even when I reach the screen from the widget in the home screen. The only way to make it show is to remove R.id.deeplink_dest in MainActivity.kt.
class MainActivity : AppCompatActivity() {
    ...
    // TODO STEP 9.5 - Create an AppBarConfiguration with the correct top-level destinations
    // You should also remove the old appBarConfiguration setup above
    val drawerLayout : DrawerLayout? = findViewById(R.id.drawer_layout)
    appBarConfiguration = AppBarConfiguration(
            setOf(R.id.home_dest, R.id.deeplink_dest),    // <-- Remove "R.id.deeplink_dest".
            drawerLayout)

But if I do, the Up button always shows up in "Deep Link" screen, even when I reach the screen from Navigation Drawer or Bottom Navigation.
Is the Up button supposed to show up only when I reach it from the "Deep Link" widget? If so, how do I make it show up, but not show up when reaching it from Navigation Drawer or Bottom Navigation?

Thanks for reporting this and the feedback! Apologies for the confusion - in an older version of the codelab (which this screenshot was taken from) I did not teach about different top level destinations, so the screenshots were out of date.
The up button is not supposed to show up conditionally based on whether you got to the destination via deep link. Instead, this behavior is controlled by whether or not it's a top level destination, which is determined by passing in the id R.id.deeplink_dest to AppBarConfiguration. If it is top level, the up button shows. If it's not top level, the up button doesn't show (and either nothing or a nav drawer menu button shows). Hope that clarifies things and I am updating these screenshots so others will not be confused by this.


miss batch method

i found that kernel code has been supporting bpf batch update for a while, and i found bpf_map_update_batch and other methods  in iovisor/bcc, when using objdump to locate symbol in the libbcc, i also find symbols which contain 'batch'
objdump -S usr/lib/libbcc.so | grep  batch

bcc has released v0.23.0

i commit one patch into bcc, adding the batch methods into libbpf.h, so bindgen can generate correct batch methods will the newest libbpf.h

We only generate bindings for released versions of bcc, so if your change is going to be in 0.24.0, that would be the soonest we will support it in this crate.

got it
On Thu, Nov 25, 2021 at 5:52 AM Brian Martin @.***>
wrote:

We only generate bindings for released versions of bcc, so if your change
is going to be in 0.24.0, that would be the soonest we will support it in
this crate.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/rust-bpf/bcc-sys/issues/71#issuecomment-978292159,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ALXUAFRGQTP34CYXQUTYJA3UNVNCBANCNFSM5IGRUEJQ
.


self-hosted multiplayer version for kind of a private lan party?

I just got a silly idea, to set up some opensource web based worms clone into an intranet of a small company, to surprise the co-workers with a nice game they can play in their free-time. almost the first hit in google was your project, and i was happy to see, you have published the client part of the source. Soon i realized, that the game has a server part, which would enable the "LAN-Party" feeling what i have envisioned.
As the live demo says the "multiplayer server is down" which is totally understandable, but may i ask you about the sources of the server part?

Yea I should really spark up the server again somewhere. Just was costing me 5 euro a month so shut it down. Though if you want to host your own you should check out /src/networking the Server.ts once compiled to Js should run in basically any environment with Node.js. I think it might need some updating to compile with the lastest Typescript, so maybe an older version from like 5 years ago :D  - I would accept any pull requests


Issue found in/using golangci-lint, about warnings not processing properly

Please see this issue:
https://github.com/golangci/golangci-lint/issues/4550
We have concluded it's an issue in contextcheck but I do not know specifically what is going on. There is example code and changes made that can reproduce the issue:
https://github.com/golangci/golangci-lint/issues/4550#issuecomment-2009738678

it's fix: https://github.com/golangci/golangci-lint/pull/4552

It's a contextcheck bug, I just provided a workaround.


Updated nsmbot message

Signed-off-by: Mikhail Avramenko<EMAIL_ADDRESS>part of https://github.com/networkservicemesh/cmd-template/issues/64

CI is red and it is not related to this PR.
So merging.


chore: update .npmignore

Excludes karma.conf.js, and any previously generated *.tgz files from the package generated by npm pack. Also removes the outdated appveyor.yml from the list of ignores.

Codecov Report

Merging #236 (ffac174) into master (e22633f) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
- Coverage   84.23%   84.17%   -0.06%
==========================================
  Files          14       12       -2
  Lines         539      537       -2
==========================================
- Hits          454      452       -2
  Misses         85       85

Impacted Files
Coverage Δ

test/test-platform-modules/platform.js

test/test-platform-modules/exec.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e22633f...ffac174. Read the comment docs.


Fix SwitchToTab build break

#8420 removed SwitchToTab() as a responsibility of TabBase and replaces _mruTabActions with _mruTabs (conceptually). This PR fixes the build break by...

replacing TerminalPage's reference to the SettingsTab's SwitchToTab command, with a reference to the tab itself
using that reference to maintain existing tab switching behavior

References
#1564 - Settings UI
#8420 - Command Palette + SwitchToTab refactoring
PR Checklist

[X] Closes #8538

Validation Steps Performed
✅ Open SUI --> switch to a different tab --> try opening SUI again --> switches to existing SUI
✅ Open SUI --> switch to a different tab --> reorder tabs --> try opening SUI again --> switches to existing SUI

The new SA failures are due to VS 16.8.
I am comfortable with an admin override for now.

The fix is perfect! Please let me know if I can help somehow :blush:


Meta: Alloy migration

Tracking issue for the Alloy Migration.
Migration progress per-crate:

[x] debugger https://github.com/foundry-rs/foundry/pull/5854
[x] fmt https://github.com/foundry-rs/foundry/pull/5851
[x] cli
[x] common
[x] config partially migrated
[x] cast

[x] primitive types migrated
[x] signer/provider types migrated

[x] macros
[x] abi
[x] evm

[x] Cheatcodes migrated
[x] ABI-related types migrated
[x] primitive types migrated https://github.com/foundry-rs/foundry/pull/5768

[x] anvil-core

[x] https://github.com/foundry-rs/foundry/issues/6715

[x] anvil

[x] txpool/executor logic migrated to alloy
[x] RPC types migrated
[x] primitive types migrated (partially migrated so far) https://github.com/foundry-rs/foundry/pull/5768
[x] RLP related types migrated
[x] Tests migrated to alloy

[x] utils

[x] primitive types migrated

[x] forge

[x]  primitive types migrated https://github.com/foundry-rs/foundry/pull/5873
[x] forge-script migrated

[x] `test-utils migrated https://github.com/foundry-rs/foundry/pull/5874
[x] chisel

provider/rpc types migration progress per-crate (only ones with usage of these are mentioned):

[x] debugger
[x] fmt
[x] cli
[x] common
[x] config
[x] cast
[x] abi
[x] evm
[x] anvil
[x] forge

done with https://github.com/foundry-rs/foundry/pull/6219
Reth-related milestones

[x] Yank reth revm inspectors into their own repo to remove a dependency on reth: https://github.com/paradigmxyz/reth/issues/5956

soft/hard Blockers

[x] Log alloy-primitives implementation, needed for a complete anvil & evm migration. https://github.com/alloy-rs/core/pull/271 (Soft blocker)
[x] ethers-solc needs to move to its own standalone repo. (Soft blocker for now)
[x] ethers-etherscan and other verification/etherscan related utilities need to either move to their own repo or integrate into an existing one. (Soft blocker)

Followups

#6104
#6102
#6098
https://github.com/foundry-rs/block-explorers/issues/8

I am interested in the migration for forge bind . Would be curious to learn more about what all is needed for it.

@0xJepsen
Forge bind will be deprecated and removed once this migration is done. Bindings generation is no longer needed or possible with the abigen! replacement, sol!, as you can either maintain a Solidity interface or a JSON ABI in tree and point the macro to that directly.

Marking as complete as Foundry has fully migrated to Alloy :100:
Leftover code aided in the transition, like https://github.com/foundry-rs/foundry/issues/7048, will be cleaned up in standalone tickets or whenever we encounter it.


Fix typo in expected output

The output from the flask app is "Hello from Python!" from the code on line 46 but the expected output message has a typo.

/check-cla


MigrateXmlToJavaConfigurationAction:Cannot invoke "java.nio.file.Path.toFile()" because "path" is null

Describe the bug
Action [MigrateXmlToJavaConfigurationAction] 'Migrate xml bean configuration to Java bean configuration.' failed: Cannot invoke "java.nio.file.Path.toFile()" because "path" is null
To Reproduce
Steps to reproduce the behavior:

a initialize-spring-boot-migration
a migrate-spring-xml-to-java-config
stacktrace

Expected behavior
A clear and concise description of what you expected to happen.
Applying recipe 'migrate-spring-xml-to-java-config'
[X] Migrate xml bean configuration to Java bean configuration.
Action [MigrateXmlToJavaConfigurationAction] 'Migrate xml bean configuration to Java bean configuration.' failed: Cannot invoke "java.nio.file.Path.toFile()" because "path" is null
Details of the error have been omitted. You can use the stacktrace command to print the full stacktrace.
usercenter-migration:> stacktrace
Stacktrace
org.springframework.sbm.engine.recipe.ActionFailedException: Action [MigrateXmlToJavaConfigurationAction] 'Migrate xml bean configuration to Java bean configuration.' failed: Cannot invoke "java.nio.file.Path.toFile()" because "path" is null
at org.springframework.sbm.engine.recipe.Action.applyWithStatusEvent(Action.java:43)
at org.springframework.sbm.engine.recipe.Recipe.apply(Recipe.java:101)
at org.springframework.sbm.engine.commands.ApplyCommand.execute(ApplyCommand.java:61)
at org.springframework.sbm.shell.ApplyShellCommand.apply(ApplyShellCommand.java:61)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:568)
at org.springframework.shell.command.invocation.InvocableShellMethod.doInvoke(InvocableShellMethod.java:306)
at org.springframework.shell.command.invocation.InvocableShellMethod.invoke(InvocableShellMethod.java:232)
at org.springframework.shell.command.CommandExecution$DefaultCommandExecution.evaluate(CommandExecution.java:158)
at org.springframework.shell.Shell.evaluate(Shell.java:208)
Additional context
spring4.3 xml config web project
mybatis-spring:1.3
spring-jdbc
spring-web
lombok
guava
xml:
<context:component-scan
<tx:annotation-driven
aop:config
<beans profile=
<bean id=

HI @liyunde
Thank you for reporting this 🚀
...and sorry for my late reply, I was on vacation.
The whole XML to JavaConfig stuff is very(!) experimental and incomplete.
It is the result of a spike and since I coded this (let's say hacked, I remember the code to be quite ugly) nothing happened.
It is technically possible to migrate XML to Java bean configuration but would need much more love to be of use for any non-example application.
The code was good enough to migrate an example application but problems for all other cases are expected.
I am afraid it is currently out of scope as we are focusing on Spring Boot 3 upgrades which take up all our time.
But, If you want to look into this and provide a PR, I am more than happy to assist you?

Closing as this functionality is out of scope for now. Feel free to reopen in case you want to look into this and contribute.


Custom emoji picker component

Slack and similar tools have an emoji component:

On Mac, we're used to pressing Command + Control + Space, but Windows and Linux users don't have this.
Could we add one?

@lukejacksonn I would like to take this on however is it ok if I use a third-party library?

Which one were you thinking about using?

I was thinking this one. It looks pretty solid https://github.com/ealush/emoji-picker-react

Is this still open? If so I would like to take it

Technically still open. However, I do have a pull request up for it https://github.com/pusher/react-slack-clone/pull/55 @ReaganMcF1059

Is it still open? I would like to add emoji picker.


Fixing a bug in Message::isJSON

Fixes the bug pointed out in a comment on #3719.
Description
Fixed an issue in isJSON that was breaking it if the content type header had the encoding in it as well.
Checklist:

[x] Securely signed commits
[ ]N/A Component(s) with PHPdocs
[x] Unit testing, with >80% coverage
[ ]N/A User guide updated
[x] Conforms to style guide

@MGatner  I did notice that you put a deprecated flag on this function. I'm wondering why that is when you were the one that suggested the creation of the function. Given the change needed in this PR, I am wondering if it might be a better idea to keep it?

@MGatner  I did notice that you put a deprecated flag on this function. I'm wondering why that is when you were the one that suggested the creation of the function. Given the change needed in this PR, I am wondering if it might be a better idea to keep it?

I'm okay with this PR since it is a bugfix, but we did decide to deprecate that. I know I recommended it but since I have spent a lot of time with the HTTP layer. One of the goals is to incorporate a PSR-7 HTTP layer into the framework, and a corollary to that is relocating functionality to their proper locations.

I'm okay with this PR since it is a bugfix, but we did decide to deprecate that. I know I recommended it but since I have spent a lot of time with the HTTP layer. One of the goals is to incorporate a PSR-7 HTTP layer into the framework, and a corollary to that is relocating functionality to their proper locations.

Thank you @caswell-wc

Thank you @caswell-wc

You're welcome @samsonasik.

You're welcome @samsonasik.


Fee is not calculating, when the Debug mode is ON

Expected Behavior
Fee should be calculating, when the Debug mode is ON
Current Behavior
Fee is not calculating, when the Debug mode is ON

Couldn't find a quick fix, but created this issue to track: https://github.com/celo-org/celo-monorepo/issues/2187
Going to close this for now as it will be fixed with the above issue


Only applicable to Commercial Cloud

The purchase process only works for users with a Commercial Cloud tenant. I have yet to figure out how to obtain a license for GCC, neither Basic nor Pro.

Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: b79d13d8-9f2e-ef35-0459-c3430e5b05a7
Version Independent ID: b79d13d8-9f2e-ef35-0459-c3430e5b05a7
Content: Step 1 - Purchase a license for the Teams Rooms console - Microsoft Teams
Content Source: Teams/hybrid-meetings-device-config-license.md
Service: msteams
GitHub Login: @dstrome
Microsoft Alias: dstrome

Hello @jhall-conp I am looking into this

Please contact your Microsoft representative or partner about purchasing GCC licenses.

Please contact your Microsoft representative or partner about purchasing GCC licenses.

We spent several months trying to do just that, but they were never able to help. A few weeks ago we tried following the posted instructions again and it was available! It looks like the ability to purchase licenses in AAD was added to GCC recently.


Correct previously incorrect globalvars, TICK_INTERVAL set value

Realized a previous pull request I made for globalvariables were incorrect. Had completely forgotten about it.
Seeing how global variables no longer have a tick interval var and how valve is currently using a constant variable.
I decided to change TICK_INTERVAL to the same value as Valve uses

Thx!


Remove ARMC5 note and compile log

Compilation log will change from target, toolchain, and release. Better to remove then have outdated or incorrect logs.
@AnotherButler
@SenRamakri

@AnotherButler Updooted

+1


Added Data Cleaning and EDA notebooks

Hi,
Based on the suggestions received I updated the structure
I have performed The data cleaning and preprocessing ref. to issue https://github.com/mlsanigeria/nigeria-crime-trends/issues/2 , and I have also done the Exploratory Data Analysis and visualization ref. to issue https://github.com/mlsanigeria/nigeria-crime-trends/issues/3 .
I have included the necessary notebooks , and the cleaned and processed Dataset under a new folder as mentioned in your updated contributing guidelines.
Please take a look at the changes , and merge my pull request under the tag "hacktoberfest-accepted" if everything is ok.
Thank you .

@Sammybams
sorry to bother but on my hacktoberfest  profile it shows that my contribution will not count towards hacktoberfest because the repo doesn't have the topic - hacktoberfest or my pull request  was not tagged as "hacktoberfest-accepted" .
Would you mind doing either of these ?

Thank you for considering!

Thank you very much @AntareepDey. It was an oversight on our end. We had done that for the second project we have in place and missed it for this repo. I have done that now. Thank you.


feat(app): add run failed modal for desktop

Overview
add run faild modal for desktop

Test Plan

Changelog

add RunFailedModal component and test
update ProtocolRunHeader component and test for displaying the modal

Review requests

Risk assessment
low

[ ] fix ProtocolRunHeader.test.tsx errors


BufferWriterFormat: add handling for 'p'/'P' pointer type override.

This sets up other formatters to use 'p' or 'P' to mean "print as a pointer, not the referenced type".
Should be merged after #3340, #3408.

Why add this if there is nothing that is using it?

Because I have Oath internal work I want to contribute to open source that uses this. I also have much future work that will use this extensively. My long range plan is to replace things like TSDebug() to (1) avoid having to provide all of those ancillary structures and declarations to generate useful error messages and (2) improve performance by not doing the required text conversions until after it has been verified the debug message should be generated (now, almost all the time the conversions are doing every time, even in release mode).

@SolidWallOfCode The text conversions shouldn't be done in release mode.  I have never seen Debug come up in performance profiling.  Sounds like there would be better things to spend time on rather than try to increase performance on something that has no impact on performance.


The file named _octopress.yml doesn't worked.

When I used octopress to create a post, I found it seems like using the default config.
So I move all contents from _octopress.yml to _config.yml.
The octopress command worked good.
Sorry for my poor english.

Very useful.
Apparently with octopress 3.0 the configuration is read from _config.yml  as shown here https://github.com/octopress/octopress


plugin can't find plugin after installation

I tried to install plugin like it described in readme.
I work in WIndows 10 Enterprise Build  10586.1295
I added this code to pom.xml:
<dependency>
                <groupId>com.google.googlejavaformat</groupId>
                <artifactId>google-java-format</artifactId>
                <version>1.5</version>
            </dependency>

<build>
<plugins>
<plugin>
                <groupId>com.cosium.code</groupId>
                <artifactId>maven-git-code-format</artifactId>
                <version>1.16</version>
                <executions>
                    <execution>
                        <goals>
                            <goal>install-hooks</goal>
                        </goals>
                    </execution>
                </executions>
            </plugin>
</plugins>
</build>

After mvn install (maven 2.5.3) and build success I saw in the .git/hooks/ these files:
artemc@ARTEMC01 MINGW64 /c/ws/ncso/.git/hooks (GIT_DIR!)
$ ll
total 48
-rwxr-xr-x 1 artemc 1049089  478 Apr  2 13:16 applypatch-msg.sample*
-rwxr-xr-x 1 artemc 1049089 4693 Apr  2 13:20 commit-msg*
-rwxr-xr-x 1 artemc 1049089  896 Apr  2 13:16 commit-msg.sample*
-rwxr-xr-x 1 artemc 1049089 3327 Apr  2 13:16 fsmonitor-watchman.sample*
-rwxr-xr-x 1 artemc 1049089  176 Apr 11 14:38 nfvo.maven-git-code-format.post-commit.sh*
-rwxr-xr-x 1 artemc 1049089  412 Apr 11 14:38 nfvo.maven-git-code-format.pre-commit.sh*
-rwxr-xr-x 1 artemc 1049089   71 Apr 11 14:37 post-commit*
-rwxr-xr-x 1 artemc 1049089  189 Apr  2 13:16 post-update.sample*
-rwxr-xr-x 1 artemc 1049089  424 Apr  2 13:16 pre-applypatch.sample*
-rwxr-xr-x 1 artemc 1049089   70 Apr 11 14:37 pre-commit*
-rwxr-xr-x 1 artemc 1049089 1642 Apr  2 13:16 pre-commit.sample*
-rwxr-xr-x 1 artemc 1049089 1492 Apr  2 13:16 prepare-commit-msg.sample*
-rwxr-xr-x 1 artemc 1049089 1348 Apr  2 13:16 pre-push.sample*
-rwxr-xr-x 1 artemc 1049089 4898 Apr  2 13:16 pre-rebase.sample*
-rwxr-xr-x 1 artemc 1049089  544 Apr  2 13:16 pre-receive.sample*
-rwxr-xr-x 1 artemc 1049089 3610 Apr  2 13:16 update.sample*

$ cat nfvo.maven-git-code-format.pre-commit.sh
#!/bin/bash
# Retrieve staged files
STAGED_FILES_FILE=$(mktemp)
git diff --cached --name-only > "${STAGED_FILES_FILE}"
# Process the files
"C:/apache-maven-3.5.3/bin/../bin/mvn" git-code-format:on-pre-commit -DstagedFilesFile=${STAGED_FILES_FILE}
# Add the files to staging again in case they were modified by the process
while read file; do
  git add ${file}
done <${STAGED_FILES_FILE}

rm ${STAGED_FILES_FILE}

$ cat pre-commit
#!/bin/bash
"./.git/hooks/nfvo.maven-git-code-format.pre-commit.sh"

when I tried to perform commit I got this message before editing commit message:
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 18.026 s
[INFO] Finished at: 2018-04-11T14:51:04+03:00
[INFO] ------------------------------------------------------------------------
[ERROR] No plugin found for prefix 'git-code-format' in the current project and in the plugin groups [org.apache.maven.plugins, org.codehaus.mojo] available from the repositories [local (C:\Users\ArtemC\.m2\repository), 80_snapshots (http://aeenexus:8081/content/repositories/snapshots/), 70_releases (http://aeenexus:8081/content/repositories/releases/), 65_staging (http://aeenexus:8081/service/local/repositories/ThirdParty/content/), 60_staging (http://aeenexus:8081/content/repositories/staging/), central (https://repo.maven.apache.org/maven2)] -> [Help 1]
[ERROR]

What did I do wrong? I use corporate proxy to connect https://repo.maven.apache.org/maven2 and it usually works.
Thanx in advance

And can you try to call any other plugin by its prefix?

Thank you for your help. It was very important information that "mvn build install" should be performed for the first time only in linux envinronment (works not only in "cygwin" but in "git bash" as well). I think you should add this note to your documentation.  Another thing that I understand that changes should be added only to root pom.xml of every project. Not it works.

What do you mean?
None of my windows coworker had to do that.
The mvn command can be runned under windows cmd without issue.
Can you give me details about the step followed to make it work?

No answer for 4 months.
Closing.


PayPal Debug ID showing also for non PayPal payments

This happens when the extension is installed. It's probably due to some too aggressive deface override.
See this screenshot of an order made with the Bogus Credit Card payment method

I guess we might need specialized partials for log entries as well 😒

@elia coff coff: https://github.com/solidusio/solidus/issues/4867 😎