MINOR: Handle lastFetchedEpoch/divergingEpoch in FetchSession and DelayedFetch

In 2.7, we added lastFetchedEpoch to fetch requests and divergingEpoch to fetch responses. We are not using these for truncation yet, but in order to use these for truncation with IBP 2.7 onwards in the next release, we should make sure that we handle these in all the supporting classes even in 2.7.
Committer Checklist (excluded from commit message)

[ ] Verify design and implementation
[ ] Verify test coverage and CI build status
[ ] Verify documentation (including upgrade notes)

@hachikuji Thanks for the review, have addressed the comments

@hachikuji Thanks for the reviews. Test failure not related (kafka.network.ConnectionQuotasTest.testNoConnectionLimitsByDefault). Merging to trunk and 2.7.


ActivityImageUtils.getScaledScreenshot crash

Hi!
I'm noticing some crashes on the 5.8.7 android sdk, mainly on Android 8 devices.
`Fatal Exception: java.lang.IllegalArgumentException
width and height must be > 0
com.mixpanel.android.util.ActivityImageUtils.getScaledScreenshot (ActivityImageUtils.java:16)`
Possibly related to https://github.com/mixpanel/mixpanel-android/issues/711

hi @matteinn , sorry for the inconvenience and thanks for providing the PR. I will do a patch release for this.


Add support for --devices argument to docker.

This PR adds support for the "--devices" argument, in order to share raw device files with the guest.
My intended purpose is to be able to use VirtualBox inside a test-kitchen environment, and that mostly works.

No problem.  Requested changes made, commits squashed.

Thank you :boom:


WIP: Templated text for manpages

#10153
I'm doing something wrong, this doesn't work.  So it's WIP.

this doesn't work.

Yup
The way things work is that you need a GENERATE line in some appropriate build.info to trigger file generation, like this:
https://github.com/openssl/openssl/blob/e78253f2d0c1a9fe6b023d867ee02342b4560150/build.info#L21
Now, .in at the end of the generator (the first token in the value) is significant, it triggers automatic call of util/dofile.pl, in this example with doc/man7/openssl_user_macros.pod.in as the argument and doc/man7/openssl_user_macros.pod as the output file.
You also need to hook the generation of the intended file to something.  In the top build.info, there's a "magic" depend line:
https://github.com/openssl/openssl/blob/e78253f2d0c1a9fe6b023d867ee02342b4560150/build.info#L12-L13
The empty [] is "magic" insofar that it makes the whole build depends on those files being generated.  It's kind of a last resort when you can't easily figure another way to have them automatically built.
As for loading perlvar, there's a whole world of complication trying to add that to util/dofile.pl.  It would be better to be explicit in your .in file, like this:
{- use File::Spec::Functions;
    do catfile($config{sourcedir}, 'doc/perlvars.pl');
    "" -}

Oh sorry (it was late), when I said "it doesn't work" I meant by doing it manually, I haven't hooked it up to the build system yet:
perl -Mconfigdata util/dofile.pl -s doc/perlvars.pl doc/man1/openssl-smime.pod

Doing that gives me no output.
I can figure out the build stuff.  I'd like to put all the stuff in dofile.pl, not add three magic lines, so I might muddle through it a bit more.  Even if I change openssl-mime.pod to have "print yes" I get no output, so clearly I'm doing something wrong in the invocation.

When I replace the pathname with /tmp/x it works  /tmp/foo.in it does not.  Something strange in the invocation of dofile that I need to understand.

Argh.  I had (- in my "real" file, not {-  I think dofile should have a way to signal processing errors :)
Conceptually, this is ready to go.  I added a few other sample files so you can see the changes.
I will make a new PR with just the infrastructure.

not add three magic lines

?????  I'm not sure I understand what's magic about those lines, they're actually quite explicit.
The real magic would be for you to figure out how to pass the -s option with its value.

#10159 does it right.  You just need to put
{- $OpenSSL::safe::do_not_edit -}

for example at the start of any pod.in files.
Closing this.


Fix compilation warning and linkage error with MSVC due to struct mismatch

Hi @guolinke , I noticed there was an issue with MSVC when linking against the .so file. This was because I was declaring PredictionEarlyStopInstance to be a class when it is a struct. It's fixed now.

@cbecker
can you also remove these two warning-ignore ?  https://github.com/Microsoft/LightGBM/blob/master/include/LightGBM/prediction_early_stop.h

@cbecker
can you also remove these two warning-ignore ? https://github.com/Microsoft/LightGBM/blob/master/include/LightGBM/prediction_early_stop.h

can you send me what the warning is about and the exact text?

@cbecker
remove the two #pragma warning(disable : 4099)  in that file.

remove the two #pragma warning(disable : 4099) in that file.

Thanks, done.


Dialect

Variables connect dialect 2005, but there are still CONCAT query sql function not found

        [DisplayName("FullName"), Expression("CONCAT(T0.[FirstName], CONCAT(' ', T0.[LastName]))"), QuickSearch]
        public String FullName
        {
            get { return Fields.FullName[this]; }
            set { Fields.FullName[this] = value; }
        }

Search and replace these with +

Expression("T0.[FirstName]+T0.[LastName]") ,thank you

You write Serenity too good

Serene has to support a variety of database engines, including MySQL, Postgress etc. These databases don't have a string plus (+) operator like MsSqlServer. Thus, in Northwind, CONCAT function is used in place of '+' operator:
[Expression("CONCAT(T0.[FirstName], CONCAT(' ', T0.[LastName]))")]
public String FullName
{
    get { return Fields.FullName[this]; }
    set { Fields.FullName[this] = value; }
}

CONCAT is available after Sql Server 2012. So if you are going to use an older version of SQL server, e.g. 2005 or 2008, replace these expressions with such:
[Expression("T0.[FirstName] + ' ' + T0.[LastName]")]
public String FullName
{
    get { return Fields.FullName[this]; }
    set { Fields.FullName[this] = value; }
}

Added this to guide, sorry i didn't understand problem at first.

God

I can not speak English,My fault

No, it's fine. Not my native language either :)


Does this work with Xamarin Forms 2?

Yes this should. Are you having any issues?

No...not yet anyway. I'm starting a Xamarin Forms 2 project, building android first. I'm thinking of using this for MVVM and a better DI system (maybe use TinyIOC).
Currently I'm just using Xamarin Forms doing unit tests and I have to reference the Xamarin.Forms in my Unit test project, which causes more issues.
Could you tell me some differences between this and mvvmcross?

@rid00z Looks like this is using an old version of xamarin forms.

Generally, it should be forwards compatible.
Michael Ridland | Technical Director | Xamarin MVP
XAM Consulting - Mobile Technology Specialists
www.xam-consulting.com
Blog: www.michaelridland.com
On Tue, Nov 24, 2015 at 5:00 PM, Robert Baker<EMAIL_ADDRESS>wrote:

@rid00z https://github.com/rid00z Looks like this is using an old
version of xamarin forms.
—
Reply to this email directly or view it on GitHub
https://github.com/rid00z/FreshMvvm/issues/21#issuecomment-159158394.

FreshMvvm is based on MvvmCross conventions but takes into account Xamarin.Forms has 90% of what's needed for Mvvm. FreshMvvm is only the extra 10% that's required, while MvvmCross and Xamarin.Forms have a huge amount of duplicated functionality.

I have been using FreshMvvm in a Forms 2 project and didn't run into any problems as of yet!

Op 24 nov. 2015 om 07:07 heeft Michael Ridland<EMAIL_ADDRESS>het volgende geschreven:
FreshMvvm is based on MvvmCross conventions but takes into account Xamarin.Forms has 90% of what's needed for Mvvm. FreshMvvm is only the extra 10% that's required, while MvvmCross and Xamarin.Forms have a huge amount of duplicated functionality.
—
Reply to this email directly or view it on GitHub.


Unrecognized plugin format; can't find plugin.id {src: 'external.js'}

Adding the plugin gives me the following errror in the console of chrome devtools:
plugins.js:195 Unrecognized plugin format; can't find plugin.id {src: 'plugin/external/external.js', condition: ƒ}

I'm running Reveal.js fresh from git, and updated gulp to v4.x.x as I'm running on Node v16:
$ node -v
v16.15.1

The result is that an empty slide is added to my deck:

Did you copy the plugin file node_modules/reveal_external/external/external.js to plugin/external/external.js?


Document macros

Macros should appear in the docs site and be documentable

I would love this! We've resorted to self-documenting in the repo https://gitlab.com/gitlab-data/analytics/blob/master/transform%2Fsnowflake-dbt%2Fmacros%2FREADME.md
Key features for us here:

Code source (of course)
Description of what it does
Models it's used in

Additional thought - unit tests on these would be great 😄

see https://github.com/fishtown-analytics/dbt/pull/2103/


Add yams 5.1.0

Released here: https://github.com/jpsim/Yams/releases/tag/5.1.0

I guess I need a maintainer to approve this:
BcrValidationResult.NEED_BCR_MAINTAINER_REVIEW: The presubmit.yml file of<EMAIL_ADDRESS>doesn't match its previous version<EMAIL_ADDRESS>the following presubmit.yml file change should be reviewed by a BCR maintainer.
    --- modules/yams/5.0.6/presubmit.yml
    +++ modules/yams/5.1.0/presubmit.yml
    @@ -9,7 +9,7 @@
         platform: ubuntu2004
         environment:
           CC: "clang"
    -      SWIFT_VERSION: "5.8.1"
    +      SWIFT_VERSION: "5.10"
           SWIFT_HOME: "$HOME/swift-$SWIFT_VERSION"
           PATH: "$PATH:$SWIFT_HOME/usr/bin"
         shell_commands: *shell_commands

Btw you submitted here as well: https://github.com/bazelbuild/bazel-central-registry/pull/1679

Btw you submitted here as well: https://github.com/bazelbuild/bazel-central-registry/pull/1679

Ah I forgot this repo has the bot enabled. Some of my other modules don’t have that integration working.

Can a BCR maintainer please trigger CI? Maybe @brentleyjones ?

I think I need to make more changes upstream for Bazel 7.x support. For now I've updated the presubmit file to use Bazel 6.x.

This needs another maintainer approval to run (sorry to bug @brentleyjones, but that seems to be the intended process here?)


Processing Code [3]..............................NaN

Dear Juks,
thanks for all the efforts in this project
please note after implement the code, while the POS is trying to connect i got the below Error
2021-04-15 12:26:29 - verbose: ::ffff:<IP_ADDRESS>:61152: Warning! Iso8583 packet contains errors. Won't queue!
 [ <faulty>]

 Message Type Indicator [0].......................0074
 Bitmap [1].......................................30***03072340580
 Processing Code [3]..............................NaN
 Amount, Transaction [4]..........................5***97200000
 System Trace Audit Number [11]...................032800
 Time, Local Transaction [12].....................000000000001
 Date, Expiration [14]............................4
 Track 2 Data [35]................................122509015568210
 Response code [39]...............................415
 Amount, Fees [46]................................121221200051400009990001595             368
 Additional amounts [54]..........................

================================================================================================
Errors:
Field 3 expected to be numeric

your support is highly appreciated

thanks

Zar

Hi!
You need to adjust the headers format and the iso8583 setup (https://github.com/juks/iso-8583-socket-queue/blob/master/lib/iso8583/lib/packager/smartVista.js) according to your system configuration.


No mention about Geo Restore limitation

This page should also mention about limitations on geo restore and also restore for SQL MI in general.
For example,

Geo restore can be done only on a SQL MI that is in the same subscription as the source SQL MI
You cannot restore a SQL MI database backup to a SQL VM (gives compatibility error)
You cannot restore a SQL MI database backup (non geo replicated) to another SQL MI instance, it gives issues due to TDE encryption and you have to turn off TDE before taking copy only back but that does not work too.

These are important so people can plan before using SQL MI.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: de79f464-39dc-a5ad-0d9d-fab2ed248222
Version Independent ID: 6cf17fc7-3bdd-c419-8d9d-7d3067bb86ae
Content: Restore a database from a backup - Azure SQL Database & SQL Managed Instance
Content Source: articles/azure-sql/database/recovery-using-backups.md
Service: sql-db-mi
Sub-service: service
GitHub Login: @anosov1960
Microsoft Alias: sashan

@ahujtarun Thank you for taking the time to detail this feedback. This is being reviewed and an update will be made as applicable to any current, pending updates.

Hi @ahujtarun ,
Thank you so much for contacting Microsoft and our apologies for the delay in response! We beg for your patience as we're working through a long backlog of Git Issues.
Let me see what I can do to get this addressed for you.
Thanks!
Masha from the SQL Docs team
#assign:MashaMSFT

@MashaMSFT:

I have addressed #1 above on the mentioned how-to page (articles/azure-sql/database/recovery-using-backups.md), so consider the first point taken care of.
I will need you (or please work with Milan Lazic) to please address the other two comments (2 and 3) which are also valid, but these should be addressed on the main backup page. These two comments refer to the situation are NOT related to automated backups, but rather when customer is manually performing native backup using T-SQL to Azure blob storage. Such backup file can't be restored back on in-merket SQL Servers (this will change with SQL Server 2022), and cannot be restored on another MI unless decrypted, OR it can be in case of TDE customer managed keys when customer copies the same keys in the Key Vault on both MIs.

Hi @DevPointers , thanks so much for contacting Microsoft and helping improve our docs! My apologies for the delay as we've been working through a large backlog of Issues. I've processed a change to update this that should be live later this week. I'll go ahead and close out this Git Issue but please feel free to comment should you need anything further.
Thanks again and I hope you have a wonderful rest of your day!
Masha from the SQL Docs team
#please-close


Add explanative sentence for volumes option

What did you implement:
Added a documentation for the volumes option.
Closes: #163
How did you verify your change:
Generated documentation locally

Thanks @keirlawson


Merge feature/172_missing_readme_handling into #171 WCCFL Qualtrics

This is to ensure the WCCFL feature includes handling for deposits without README.txt

@damian-romero this is ready to merge into the WFCCL branch to work with deposits that do not have README form responses.


wasm-mutator-fuzz: disable fast interpreter by default

our interpreters' SIMD support is not complete.

we want to keep SIMD enabled for this fuzz target because, llvm-jit and aot, which support SIMD, use wasm_loader.c to load and validate the input module.
well, we probably should test wasm_loader.c with the configuration actually used by llvm-jit and aot. (WASM_ENABLE_JIT/WASM_ENABLE_WAMR_COMPILER) but we ignore the difference for now.

fast interpreter is not compatible with llvm-jit/aot.

cf. https://github.com/bytecodealliance/wasm-micro-runtime/issues/3580
an alternative:
https://github.com/bytecodealliance/wasm-micro-runtime/pull/3592

cf. https://github.com/bytecodealliance/wasm-micro-runtime/pull/3611


it says no headset found on steamVR wean it lanchs

You need to open ALVR and 'start server' there, opening SteamVR any other way will result in failure.


Fix fix outof range exception after calling function eleme…

…nt_at for variant type
src subcolumns empty but src row count may not be 0, so need to padding rows to at least src.size() and finlize at last
Proposed changes
Issue Number: close #xxx

run buildall


Failed to load Info.plist from bundle

Sorry, I don't know what caused the problem.
First, my enviroment:
Xcode 8.0
cocoapods 1.2.beta1
  pod 'Alamofire', ' ~> 4.1'
I can run the application after clean the project, ie ( Shift + Cmd + K).
It's really depressing to clean the project before every time I run the app.
Could anyone give me some advice? I have already googled a lot, while nothing useful was founded.
Failed to load Info.plist from bundle at path /Users/banxi/Library/Developer/CoreSimulator/Devices/5CF30C37-0F3B-4DF1-B3A7-55647DF85F4E/data/Library/Caches/com.apple.mobile.installd.staging/temp.mIhBqB/extracted/Payload/App.app/Frameworks/Alamofire.framework

the xcode Locations preference as follows.

May be it's the simulator's problem.
I changed the simulator then the problem is dismissed.
So I can close the issue now.

Clean before build resolves the issue too. It could be a red herring 🐟 that it's alamofire specific - Alamofire is usually the first in the alphabet in our projects. We've just started getting it without a switch of version number which suggests a project change not a library issue.

I had the same issue here. You can also reset your simulator instead to changing it only, so it remains available for testing.

Thanks @rickytribbia . As you said, on the right-top of Simulator, there is a menu named 'Reset Content and Settings'. Click it and problem fixed.

You're welcome 👍

Following the below steps solved the issue for me:
Update the cocoapods by brew upgrade cocoapods
Clean the build folder using cmd+shift+k
Delete the derived data folder using cmd+shift+alt+k
Erase content and setting of simulator
Remove the pods completely and reinstall by rm -rf Pods\ Podfile.lock && pod install
run the project by Xcode and the app installed successfully


Automated download retries [ただよし]

When the book is complete with remaining errors, put it back in the queue automatically up to X times, and stop if errors remain the same or memory is full (X%)
Off by default
3 retries by default
Full 95% by default

This issue was moved to avluis/Hentoid#197


PIV: use se050 backend and trussed-auth for key wrapping

Depends on
Waiting for merge before updating the patch section of the cargo.toml.

https://github.com/trussed-dev/trussed-staging/pull/25
https://github.com/Nitrokey/trussed-se050-backend/pull/36
https://github.com/Nitrokey/trussed-se050-backend/pull/37
https://github.com/Nitrokey/piv-authenticator/pull/57

metric
value

change

binary-size-nk3am-test
1,973,332
:white_check_mark:
-78,841 (-3.84%)

binary-size-nk3xn-test
566,124
:white_check_mark:
-25,900 (-4.37%)

Insignifcant changes

metric
value

change

binary-size-nk3am
1,446,135
:red_circle:
+3,899 (+0.27%)

binary-size-nk3xn
518,652
:red_circle:
+1,352 (+0.26%)

binary-size-nkpk
754,257
:red_circle:
+5,567 (+0.74%)


textChange(CoreSettings): remove redundancy

Description of the Change
Just a text change, VCS (VersionControlSystem) already includes "system" :)
"Files and directories ignored by the current project's VCS system will be ignored by some packages, ..."

Thanks!


Make "copy balance directive" feature available everywhere (feature extension request)

This is the feature that copies the balance directive to the clipboard when the green/yellow/red dot is clicked on. This works from the table in the Statistics page, but it would be great if it worked from everywhere i.e., the balance/income statement pages, etc.
Reason 1: I find myself frequently focusing on a certain account, and having to go to the statistics page just to copy the directive is not as easy just clicking on the dot. Reason 2: consistency.
Thanks!

Good idea!


Optimizing images

This issue raised by the GTMetrics #6 is to mainly reduce the size of the jpeg images for it to be more web oriented.
There a couple of ways to improve the size of the images depending on the usage. In my case I can't just transform the "decorative" pictures into .gif or .svg because I would lose too much quality

After reading through this topic:

How to optimize web images
Google - Optimisation de l'image
Optimazing images for web
10 must known image optimization tips

I figured out that I were going to compress my file either manually or with Compressor.io a free image compressor.
I will be able to tick one more thing on the #8

Pull request merged


[Feature] Allow for failures to be a float instead of integer

Is there an existing feature request for this?

[X] I have searched the existing issues

Describe the Feature
In a test config , we can assign custom failure calculation with fail_calc. Suppose, with the custom failure calculation, we want to identify the number of records that have failed the test, we can just set fail_calc: count(*), which is the default behaviour. Now instead of the number, we want the proportion of records that have failed, with a similar logic we can set  fail_calc: count(*) / (select count(*) as total_records from dataset_name`.`table_name`). But doing so, results in a error:
0.00125 is not of type 'integer'

Failed validating 'type' in schema['properties']['failures']:
    {'type': 'integer'}

On instance['failures']:
    0.00125

A user should have an option to  return failures of type float instead of the type integer constraint.
Workaround: convert float to integer by modifying it to a percentage.

Hey @rahulbaid, thanks for submitting this! We believe in having the failure be the count of failed records hence the int constrain. To make sure I understand your purpose correctly, you would want the test to warn/fail if a certain percentage of records doesn't meet requirements right? There's an improvement we want to add that looks like this
models:
  - name: my_view
    columns:
      - name: id
        tests:
          - unique:
              config:
                warn_if: "> 10%"
                fail_if: "> 20%"

which would be able to config warning/failure based on percentage but still keep the same failures as int. This is not implemented yet but I am wondering will this feature resolve your issue?
Also, this is the code where that int constrain is being defined.

I wonder what's up with that. still impossible to test on floats?


fix: skip normalizing empty file paths

This PR fixes a quite niche Windows bug where quickly changing popup windows could cause Neo-tree to try and follow (and thus normalize) an empty file path. This causes an error message to be printed, despite not actually being an issue for Neo-tree.
Essentially the problem is:

Some form of popup window (like NuiInput) closes, changing the active buffer
This causes the "follow" event to be fired from Neo-tree, but it is debounced: https://github.com/nvim-neo-tree/neo-tree.nvim/blob/7d3b02073e59ed9ef271795787de76d0de8f5294/lua/neo-tree/sources/filesystem/init.lua#L105
A toggleterm floating window is opened (triggered from the previous NuiInput by on_submit) and changes the active buffer to be a term:// path before the debounce timer finishes
The follow_internal function does not include term:// paths when calling manager.get_path_to_reveal() so it returns nil and passes that directly into normalize_path: https://github.com/nvim-neo-tree/neo-tree.nvim/blob/7d3b02073e59ed9ef271795787de76d0de8f5294/lua/neo-tree/sources/filesystem/init.lua#L33
On Windows, this path value is indexed here, but the function does not check for nil (note the doc comment states the argument is a string not string?): https://github.com/nvim-neo-tree/neo-tree.nvim/blob/7d3b02073e59ed9ef271795787de76d0de8f5294/lua/neo-tree/utils/init.lua#L763
Thus an error occurs before the follow_internal can gracefully exit early from an empty path here: https://github.com/nvim-neo-tree/neo-tree.nvim/blob/7d3b02073e59ed9ef271795787de76d0de8f5294/lua/neo-tree/sources/filesystem/init.lua#L34

The check is only added after the M.is_windows branch, so this will not change behavior for any non-Windows users. Windows users will have the exact same behavior (no file will be followed), just without the error message.

After looking at this again, I realized there was a more correct fix, e.g., not passing nil to a function that only accepts string arguments. This fixes the same problem, but is more "correct" (and doesn't add an extra branch check to every Windows call to normalize_path).


Look into organizing jib-maven-plugin and jib-core dependency.

Currently, jib-core needs to be published to the local Maven repo and jib-maven-plugin imports jib-core as a dependency. This can be restructured such that jib-maven-plugin can directly use the jib-core classes.
Possible solution:

Add root project pom that has jib-core and jib-maven-plugin as dependencies
It can run the Gradle build for jib-core.

Fixed via #45


WARNING:absl:Failed to converge after 99 steps: err_norm=0.0107458

HI, when I using the default reacher_easy env to train the sac agent, the error raises.
It seems that the code can work but I don't what happended. Is there anyone meet the same error?
WARNING:absl:Failed to converge after 99 steps: err_norm=0.0107458

TL;DR: this warning is not something you usually need to worry about.
During episode initialization we sample a random initial position for the end effector of the arm, and then use inverse kinematics (IK) to try to find a configuration of the arm joints that places the end effector at the desired position and orientation. Sometimes IK will fail to converge on the desired position, in which case it will log the warning that you're seeing.
However this is not normally a problem, since we repeatedly sample random initial positions for the end effector until we find one for which IK converges (and that doesn't result in collisions). If we fail to find one within 10 attempts then we raise a RuntimeError. In theory this could happen if you're very unlucky, but in practice such failures are extremely rare.


Move all pollDocMapIndex workflows to scheduled workflows

This maps how this is used in deployed environments, and allows us to remove pollDocMapIndex workflow from import

This branch requires stabilising the test as shown in this PR: https://github.com/elifesciences/enhanced-preprints-e2e/pull/271
Once that's merged into master and then in here, the tests should stabilise.

I'm going to merge this now - It's been stable for a while, and at least you all know it has changed.


fix: depth calculation for MipMap views of 3D textures

PR Details
When creating a single MipMap slice view of a Texture3D the Depth is calculated correctly.
Types of changes

[ ] Docs change / refactoring / dependency upgrade
[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist

[ ] My change requires a change to the documentation.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.
[x] I have built and run the editor to try this change out.

Thanks !


fontUrl: path.join() does not work well with URL's

Hi!
I found that when fontUrl is directly set as an URL (in my case S3 bucket) then CSS font has one slash truncated due to how path.join() works.
For example:
https://my-statics.example.com/icons is rendered in CSS file as https:/my-statics.example.com/icons.
Relevant line:
https://github.com/tancredi/fantasticon/blob/4e706c16aa5a6887368a96931c19359c5fa12cc6/src/utils/css.ts#L34
I know that it was probably designed to work with directory path's (like /static/icons) but i think it is considerable to make it work with valid URL addresses.

Fixed in 1.0.21


Retina Images

Hi,
I was wondering if there was a way to generate a srcset that responded to the 1x, 2x of retina images?
Thank you!

I'd be interested in this too!

The idea of making images tailored to the pixel density of the screen (ie 2x, 3x, 3.14x, 4x, etc), really is an anti-pattern and not something you should use in 2018 unless you have some very specific use-case where it makes sense. What you should do instead is use srcset and sizes per the responsive images spec. I still find this article by Eric Portis from 2014 being one of the best primers as to why this is the way to go.
In short, by using sizes and srcset, the browser will be given the task to pick the most appropriate image from a range of images supplied by the srcset. Given the following img tag:

Let's say you're on a legacy mobile phone with a screen resolution of 320x540px and a 1x pixel density, the browser will look at the supplied images and go, "Aha, the smallest image that is still bigger than the size of teh screen, is... img1.jpg, which is 400px wide".
Then, let's say you're on a more modern mobile with a screen resolution of 360x620px, and something like a 2x pixel density. The browser goes, "Aha, 360px, but the density is 2x, so we ideally want an image that's 720px wide... Let's pick img3.jpg, which is 800px!".
But, you may also have a scenario like the last one, where the user in addition is on a slow connection, or maybe have turned on a setting in the browser to save bandwidth where possible, and the browser goes, "Hmm, ideally I would like to pick the 800px image, but seeing as that file probably is four times bigger than the 400px one... I'll pick the 400px one.".
So yeah, let the browser decide. :)
(And if you really want to create 1x and 2x images, you can with Imager, but you have to tell it what the 1x and 2x size should be. That's not something Imager would know, that's wholly dependant on your design.)

@aelvan - I know this answers was wrote a little while ago but I have a continuation to this question (its been driving me mad so any help would be great).
What if (and in my case) you have different art directions for larger screens and smaller screens i.e. on a smaller screen you need the full zoomed out image, but on larger screens a zoomed in image (to fill space) example below.

From the example above, you can see there is a lot of difference in visible space on the image and I'm trying to crop them so pixels that are not going to be seen (i.e. the whole cat on desktop) are not loaded.
I've used a few variations of code below to try and achieve this (including transforming the image twice - one using mode: 'fit' for mobile and one using mode: 'crop' - but retina display devices (Iphones...) always use the cropped desktop version.
    {% set headerImg = entry_dev.headerImage.image.one() %}

      {% set transformedheaderImg = craft.imager.transformImage(headerImg, [
      { width: 2000, ratio: 16/3, jpegQuality: 96 },
      { width: 1301, ratio: 16/3, jpegQuality: 95 },
      { width: 1025, ratio: 16/3, jpegQuality: 93 },
      { width: 769, ratio: 16/9, jpegQuality: 90 },
      { width: 569, ratio: 16/9, jpegQuality: 85 },
      { width: 401, ratio: 16/9, jpegQuality: 85 },
    ], { allowUpscale: false, mode: 'crop' }) %}

        <picture class="background-image careers-header-img">
          <source sizes="
          (max-width: 401px) 401px,
          (max-width: 569px) 569px,
          (max-width: 769px) 769px
          (max-width: 1025px) 1025px,
          (max-width: 1301px) 1301px,
          2000px"
          srcset="{{ craft.imager.srcset(transformedheaderImg) }}">

        </picture>

Do you know of a way around this type of issue, I can see the benefit of the devices picking pixel density images to display, but this logic fails when you have a set image to show at different screen sizes.
Thanks W


Updated dependency versions to eliminate high impact vulnerabilities

The clap version is unmaintained, but I got rid of all the other cargo audit findings, seven of which were high impact.  The tests all pass.  I reved the patch number.

Oops, unit tests passed, didn't run pipeline. Sorry, I'll go work on it.


Extract Directo-related code from "registry" project

https://github.com/internetee/registry/issues/509

@vohmar We can publish this gem in 2 ways:

Let others download our gem via Ruby standard dependency manager by publishing it to rubygems.org. For us it means some additional effort managing version numbers
Use it directly from Github. This means we can just always use master branch

I would prefer the latter, since it's very unlikely that someone else will use it at all. This gem is more for our convenience.


Android Studio 'Pub Get' needs an 'offline' mode.

Running Pub Get from Android Studio doesn't work when you are offline even if you've created the project in offline mode. Running flutter pub get --offline from a terminal does get Android Studio to pick up dependencies and references now if the relevant libraries are in pub cache, but this only works in Dolphin and not in previous Chipmunk builds.
Flutter Plugiun 70.0.4
Android Studio Electric Eel | 2022.1.1 Canary 10
Build #AI-221.6008.13.2211.8963757, built on August 18, 2022
Runtime version: 11.0.15+0-b2043.56-8887301 aarch64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
macOS 11.6.8
GC: G1 Young Generation, G1 Old Generation
Memory: 2048M
Cores: 8
Registry:
external.system.auto.import.disabled=true
ide.text.editor.with.preview.show.floating.toolbar=false
Non-Bundled Plugins:
Dart (221.6008.17)
io.flutter (70.0.4)
Jetbrains TeamCity Plugin (2022.4.108706)
flutter_doctor.txt

Hello @strangedreamsNY. This issue is related to the IntelliJ plugin for Flutter, therefore, it might be better if it was raised in flutter-intellij. Closing as this is not an issue with Flutter itself.


Consider publishing to pypi?

This code is useful when batching process something about stable diffusion webui.
So do you consider publishing this code to pypi for more developer to use this as dependency? If so, I can provide necessary support.

Thank you for the suggestion. I never published a python package. I'll try it tomorrow :)

Ciao peeps! I'm a bit unfamiliar with Python and, funny enough, I couldn't figure out how to properly import this webuiapi.py to my Jupyter. I get the following error when I attemp to run the cell. What should I do before running the Jupyter? :pray: this will be extremely useful in my project. Thank you @mix1009 mix1009

I just published the package to pypi.
https://pypi.org/project/webuiapi/
now you can install with
pip install webuiapi

If you are in jupyter notebook:
!pip install webuiapi

If you have any problem using the python package, please report here.
Thank you.


Write new docs for WRC diagnostics

Since our diagnostics do what Winmdexp used to do, we should make a new version of this webpage

There is a link used in WinRTRules.cs that needs to be updated when we get our new webpage

There is a link used in WinRTRules.cs that needs to be updated when we get our new webpage

I'll be updating this branch and will cut a pr into @angelazhangmsft 's branch when I've made all my changes

I'll be updating this branch and will cut a pr into @angelazhangmsft 's branch when I've made all my changes

Authoring diagnostics docs have been published here - https://docs.microsoft.com/en-us/windows/uwp/csharp-winrt/authoring-diagnostics


Minor changes to binwalk error handling

Added a BinwalkError struct with a message field to store error messages.
Stored error messages during binwalk initialization.
Display error message when binwalk initialization fails.

Very minor changes, I was just getting some initialization errors when implementing the API in my own project. When binwalk failed to initialise I was catching the BinwalkError but it did not provide any indication as to what went wrong.

Awesome, thank you!


Separate entity URI/identity from hosting URL

(...) [F]or features I think it will be good in future update to separate the uri/identity of the entity and the url of the hosting service, as we will need to host entities created elsewhere with different namespaces. (...)

Originally posted by @quaat in https://github.com/SINTEF/entities-service/pull/67#pullrequestreview-1843544465

This will be done in a separate DataSpaces-dedicated entity service. This repository should then be split up as also mentioned in #137. One part of this repository will focus around the service-part, specifically the onto-ns.com-specific entity service.


[Feature request] Add "dynamic" option for the rule "linebreak-style"

Problem encountered
While using a VS Code extension juanblanco.solidity (repository: https://github.com/juanfranblanco/vscode-solidity) on a Windows platform, the default rule of linebreak-style is unable to determine the OS platform it's running on, when the extension runs the Solium linter.
Reference
More info at: https://github.com/juanfranblanco/vscode-solidity/issues/86
Ideal feature/improvement
According to implementation in https://github.com/duaraghav8/Solium/blob/master/lib/rules/linebreak-style.js
Ideally add another option string "dynamic" and detect the OS platform using process.platform to determine whether the linebreak style should be LF or CRLF?
Disclaimer: I'm not a JS expert, reference found from https://stackoverflow.com/a/8684009/4003061

@jackycjh Actually this rule (or the whole of Solium) doesn't require the dynamic option. Ideally, Solium's rules should detect the platform and modify their behaviour.
There are currently bugs in Solium (related to linebreak style) causing it to be incompatible with Windows at the moment. I'd highly recommend you use Solium in a Unix or Darwin environment for now. These bugs are going to take some time to get fixed, since they're all part of legacy code.

Noted, thanks for the explanation.
Will look forward for getting Solium works nicely in Windows, hopefully also works in the ideal fashion that it could detect and modify the rule preferences.

Please feel free to re-open the issue in case you face any other related problem :)


Which folder should put the new system?

If I want to create a blog system base on your yii2-advanced-start, which models folder should put the new system? common\models or modules\blog\models ?

If you follow the modular system, then modules / blog.

Thanks!!


ci: optimise macOS run times

Currently, our use of Docker dominates CI runs. This is true for macOS too.
The rate limiting step on macOS however is that by default Docker for Desktop uses half the available number of CPU cores and a fraction of the memory.
To remove these limits we need to be able to alter the configuration of Docker for Desktop in a headless way.
https://github.com/docker/for-mac/issues/2359#issuecomment-702055818

https://github.com/tmc/d4mctl might help

Thanks @tmc - your project certainly fills in the missing blank with respect to how/where this is configured.


Ran clang-tidy with performance-faster-string-find

Running clang-tidy over the 7.1.x branch to make things easier to backport

[approve ci clang-analyzer]

[approve ci autest]


optionTemplate and optionView not working anymore

optionTemplate,itemTemplate,optionCreateTemplate,optgroupHeaderTemplate,optgroupTemplate, optionView,itemView,optionCreateView,optgroupHeaderView and optgroupView
basically using the above-mentioned properties would cause ember throw an error saying view.renderToBuffer() is no longer available. we should find a workaround for this. Maybe get the string representation of rendered view this way:
      _getStringFromView:function(view){
           view.createElement();
           return view.element.outerHTML
      },

i can get it done if you want

I suggest using the function variants, currently rendering templates and views in an ad hoc manner is not exposed in a public API.

well createElement() is part of the public API : http://emberjs.com/api/classes/Ember.View.html#method_createElement

the last two paragraphs.  But Even if you get it running all you get back is the html of the view and not any behaviours attached to the view, so it could be less efficient. you can try if you like.

Well, there is another issue with function variants. Check this out.
{{ember-selectize
content=controller.items
optionValuePath="content.id"
optionLabelPath="content.selectize_display"
sortField= "display_name"
optionFunction=controller.offn
itemFunction=controller.itmf
... }}
Now in controller, you have this:
offn: function(i){
    if (!Ember.isEmpty(i.label)){
        return i.label.toHTML();
    }
},
itmf: function(i){
    if (!Ember.isEmpty(i.label)) {
        return i.label.toHTML();
    }
},

So far all is ok. As you can see content is binded to controller.items ... but if this items is changed and you come back second time, the functions do not pick up the added items.
I tried making these properties dependent on items, but that means when a new item is added offn and itmf gets called and they do not have values for "i" parameter.
What is wrong here?

If only selectize could support DOM nodes... : https://github.com/brianreavis/selectize.js/pull/617

New progress, maybe: https://github.com/emberjs/ember.js/issues/5534#issuecomment-81818954

@miguelcobain seems like DOM nodes are now supported ? that pull-request is merged

Looks like its still open: https://github.com/brianreavis/selectize.js/pull/617

Is there a possibility to have a component render as itemFunction?
{{some-component text=label}}

Is it possible to render component inside the itemFunction?
{{some-component text='Lorem'}}

Rendering a component inside the itemFunction is exactly what I'm looking for, that or using itemView and passing a component, however that doesn't seem to be working right now.

The PR to allow DOM nodes was successfully merged yesterday :+1:

I was watching that thread. Great news!
In theory, we can now:

make ember-cli-selectize install selectize master from bower (not master branch, but a fixed sha, of course)
lookup a component/template and pass selectize the rendered DOM

I accept PR's and can offer some guidance at ember's slack, if needed.

Closed by https://github.com/miguelcobain/ember-cli-selectize/commit/47bfcaa9a8470b3f3b845a6e7b64f9272a4cad71
Latest Selectize bower version doesn't include @topaxi's PR yet. Currently using my fork of selectize. Will change to selectize's when it bumps.

Awesome news!
Just curious, does this fully support component in the ember way? That is, with actions and computed properties? Or is it a one-time rendering of a component?

Yes. Normal components. Bindings, actions, everything.


Support for hierarchical checkbox selection

A feedback on Vaadin Directory:
One addition to improve its role within many admin GUIs would be to allow easy support for hierarchical checkbox selection, so that a checkbox can be displayed next to each parent and/or child and when ticked/unticked the selection is recursively placed on all sub parents/children.

It's related to this issue: https://github.com/vaadin/vaadin-grid/issues/1704


170 add show methods

Looks like we might need to extend our classes or the show method implementations to know when the outcome model is not set yet, and also when the outcome model is not fitted yet. @darkgoldenrod-cherry

I wrote a small helper function to get a dataframe of all existing classes and whether a show method exists for them or not. This might be helpful down the line for planning.
                               class show_method_exists
1                            te_data               TRUE
2                      te_data_unset              FALSE
3                       te_datastore              FALSE
4                   te_datastore_csv              FALSE
5             te_datastore_datatable              FALSE
6                te_datastore_duckdb              FALSE
7                       te_expansion              FALSE
8                 te_expansion_unset              FALSE
9                    te_model_fitter              FALSE
10                   te_outcome_data              FALSE
11                 te_outcome_fitted              FALSE
12                  te_outcome_model               TRUE
13                te_stats_glm_logit              FALSE
14 te_stats_glm_logit_outcome_fitted               TRUE
15                 te_weights_fitted               TRUE
16                   te_weights_spec               TRUE
17                  te_weights_unset               TRUE
18                    trial_sequence               TRUE
19                 trial_sequence_AT              FALSE
20                trial_sequence_ITT              FALSE
21                 trial_sequence_PP              FALSE

Now it works partially, though te_outcome@model and te_outcome@summary get printed when they're empty.

Should I make a new class again or should I go for an ifstatement?

Also for some strange reason that I can't figure out it prints show(object@switch_weights) twice, the first time where it should be and the second time at the very end like it was specified with the child class methods that were deleted (also according to my helper method there isn't currently a show method for any of the child classes). I restarted R, reloaded the package, it didn't help. If I just run the last line of the show method, the switch_weights don't show up, so the problem is not in there.
Trial Sequence Object
Estimand: Per-protocol
Data
N: 321 observations from 89 patients
Key: <id>
        id period treatment    x1           x2    x3        x4   age      age_s outcome censored eligible time_of_event
     <int>  <int>     <num> <num>        <num> <int>     <num> <num>      <num>   <num>    <int>    <num>         <num>
  1:     1      0         1     1  1.146148362     0 0.7342030    36 0.08333333       0        0        1          9999
  2:     1      1         1     1  0.002200337     0 0.7342030    37 0.16666667       0        0        0          9999
 ---
320:    99      1         1     0 -1.106480738     1 0.5752681    66 2.58333333       0        0        0             7
321:    99      2         0     0  1.650478074     1 0.5752681    67 2.66666667       0        0        0             7
      first  am_1  cumA switch regime_start time_on_regime eligible0 eligible1
     <lgcl> <num> <num>  <num>        <int>          <num>     <num>     <num>
  1:   TRUE     0     1      0            0              0         1         0
  2:  FALSE     1     2      0            0              1         0         1
 ---
320:  FALSE     1     2      0            0              1         0         1
321:  FALSE     1     2      1            2              2         0         1

IPW for informative censoring:
 - No weight model specified

IPW for treatment switch censoring:    <----------------------
 - No weight model specified

TE Outcome Model Object
Formula: outcome ~ assigned_treatment + followup_time + I(followup_time^2) + trial_period + I(trial_period^2)
Treatment_var: assigned_treatment
Adjustment_vars:

An object of class "te_outcome_fitted"
Slot "model":
list()

Slot "summary":
list()

IPW for treatment switch censoring:    <----------------------
 - No weight model specified

@darkgoldenrod-cherry Can we have one more snapshot where we see the printed model summary? eg add a test_snapshot to one of the tests in test-modelling.R

I don't know what to do with this one failing check, everything works on my PC. Any Ideas? @gravesti

@darkgoldenrod-cherry It turns out the example we used was not so good, so it was numerically unstable so we saw the tiny differences between platforms being blown up. I have changed the test so it is more stable

Ah, okay. Thank you


feat: add protobuf 4.29.0RC1 release

update protobuf with release 4.29.0RC1

:tada: This PR is included in version 1.370.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:


Allow execution time modification of the global action delay

At the moment the constant value -20 is added to every action to counterbalance the fact that sending a keystroke takes a not insignificant amount of time. This time usually remains roughly constant on a given system but obviously fluctuates between systems. Thereby it should be modifiable.

Since I was working on an unrelated feature in the my mania analytics project  anyways, I added a little paragraph that shows the average and median time offset of a replay.

Should come in handy once this is implemented.

Alright, just pushed the change:
  -c, --compensation arg  Add static offset in milliseconds to every action
                          to compensate for the time it takes maniac to send a
                          keypress. Defaults to -20.

Here's how it looks on my laptop (which has an unimpressive CPU) with c -40

and with -c -20 (the default)

I might adjust the default as I get feedback from others in regards to what works best for them.

Keeping this open for a bit in case someone wants to give feedback/suggest a different default.

It looks like this option was lost in the config refactor that happened a while ago, this kind of stuff really shouldn't happen. I've just added it again, the interface is the same.
Closing.


Runtime error [linux/wayland]

Running on wlroots/wayfire nightly
UI thread spawned thread 'main' panicked at 'Failed to create renderer: CreateInstanceError(InstanceError(VkError(ERROR_EXTENSION_NOT_PRESENT)))', src/libcore/result.rs:1165:5
Not really sure how to interpret that
Excited to try this out :)
Backtrace:
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/libunwind.rs:88
   1:     0x560b765965c4 - backtrace::backtrace::trace_unsynchronized::hd4f479d7150ec4a0
                               at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.40/src/backtrace/mod.rs:66
   2:     0x560b765965c4 - std::sys_common::backtrace::_print_fmt::h015072984a2b172c
                               at src/libstd/sys_common/backtrace.rs:77
   3:     0x560b765965c4 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h6df05d3335f32194
                               at src/libstd/sys_common/backtrace.rs:61
   4:     0x560b765bc94c - core::fmt::write::h1f444f4312eb6c27
                               at src/libcore/fmt/mod.rs:1028
   5:     0x560b76593707 - std::io::Write::write_fmt::h8d147888220078ef
                               at src/libstd/io/mod.rs:1412
   6:     0x560b76598b1e - std::sys_common::backtrace::_print::h8a6df0fa81d6af62
                               at src/libstd/sys_common/backtrace.rs:65
   7:     0x560b76598b1e - std::sys_common::backtrace::print::h6f05b4733407e509
                               at src/libstd/sys_common/backtrace.rs:50
   8:     0x560b76598b1e - std::panicking::default_hook::{{closure}}::h0d0a23bd02315dd8
                               at src/libstd/panicking.rs:188
   9:     0x560b76598811 - std::panicking::default_hook::h8d15a9aecb4efac6
                               at src/libstd/panicking.rs:205
  10:     0x560b7659921b - std::panicking::rust_panic_with_hook::hbe174577402a475d
                               at src/libstd/panicking.rs:464
  11:     0x560b76598dbe - std::panicking::continue_panic_fmt::h4d855dad868accf3
                               at src/libstd/panicking.rs:373
  12:     0x560b76598ca6 - rust_begin_unwind
                               at src/libstd/panicking.rs:302
  13:     0x560b765b8f2e - core::panicking::panic_fmt::hdeb7979ab6591473
                               at src/libcore/panicking.rs:139
  14:     0x560b765b9027 - core::result::unwrap_failed::h054dd680e6fcd38b
                               at src/libcore/result.rs:1165
  15:     0x560b75acebc8 - core::result::Result<T,E>::expect::hc1839edd54c6f838
                               at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libcore/result.rs:960
  16:     0x560b75b268ce - neovide::window::ui_loop::hf489ea8a4c132419
                               at src/window.rs:33
  17:     0x560b75b58869 - neovide::main::hb173d805ca0cff3b
                               at src/main.rs:91
  18:     0x560b75b159b0 - std::rt::lang_start::{{closure}}::hd2e582def15a1f35
                               at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libstd/rt.rs:61
  19:     0x560b76598c43 - std::rt::lang_start_internal::{{closure}}::h6ea535ec5c50fc3e
                               at src/libstd/rt.rs:48
  20:     0x560b76598c43 - std::panicking::try::do_call::h631c6408dfccc6f5
                               at src/libstd/panicking.rs:287
  21:     0x560b765a0f9a - __rust_maybe_catch_panic
                               at src/libpanic_unwind/lib.rs:78
  22:     0x560b765996fd - std::panicking::try::hab539b2d1255d635
                               at src/libstd/panicking.rs:265
  23:     0x560b765996fd - std::panic::catch_unwind::hd5e0a26424bd7f34
                               at src/libstd/panic.rs:396
  24:     0x560b765996fd - std::rt::lang_start_internal::h3bdc4c7d98181bf9
                               at src/libstd/rt.rs:47
  25:     0x560b75b15989 - std::rt::lang_start::hd66b798f2bf5a03c
                               at /rustc/73528e339aae0f17a15ffa49a8ac608f50c6cf14/src/libstd/rt.rs:61
  26:     0x560b75b588ea - main
  27:     0x7f51819ba153 - __libc_start_main
  28:     0x560b75ac3f8e - _start
  29:                0x0 - <unknown>```

I suspect this is due to the rendering library I use which depends on Vulcan to run properly. I don't know what the support story is like for running skia with Vulcan in Linux/wayland. Do you have any ideas?

Not sure, almost thought it would just work but I may be mistaken

I think Vulcan support on Linux is slightly shaky but Im really not familiar. Maybe make an issue on the skulpin GitHub project? I use that library to do the skia Vulcan interop so maybe they might be able to help

Forgot to install intel-vulkan (thought it was installed by default), getting an error somewhere else in the stack now but I think this can be closed as just a configuration issue my side


Deployment to Azure

Pipeline Deliver to AppSource
Error: Unexpected error when running action. Error Message: Cannot bind argument to parameter 'authContext' because it is null., StackTrace: at , D:\a_actions\microsoft\AL-Go-Actions\v4.1\Deliver\Deliver.ps1: line 450 <- at , D:\a_temp\516994d0-0925-41c9-b71c-9f8428c936e4.ps1: line 4 <- at , : line 1
Error: Process completed with exit code 1.
I created AppSourceContext... what is missing?

Well well well... I think It was my issue...
My AppSourceContext is not correct. I used our Entra ID in stead of the application ID for the ClientID setting.
Everything is fine now 👍 🥇

Ups... need to close the track 💯


On ESP32 fade the backlight

This creates a smooth but fast backlight transition, fading to the new level in 200 milliseconds.  Tested on sunton-8048s050c_16MB.

I've been testing this feature, but it doesn't seem to work on my ESP32. I had to disable the fade parameter for my backlight to work properly.
I need to send multiple commands for the backlight to dim or power on/off to the set level, which is quite confusing. It seems to be related that the fade cannot be set when another fade is already in progress. This leads to an unpredictable state.
More testing and a fix is needed for this to be enabled by default in the firmware.

I've been testing this feature, but it doesn't seem to work on my ESP32. I had to disable the fade parameter for my backlight to work properly.

What display are you testing with?

I need to send multiple commands for the backlight to dim or power on/off to the set level, which is quite confusing.

I'm not sure what you mean, is this something that your particular hardware needs?  So you are sending multiple backlight commands in quick succession?

It seems to be related that the fade cannot be set when another fade is already in progress. This leads to an unpredictable state.

I read that the ESP32 hardware does not support cancelling a fade while in progress.  But also I read that setting the level to the end-level of the fade in progress will end the fade; maybe this is not working correctly.
Another option is to have a callback for when the fade is complete, which could check if the requested backlight level has changed in the mean time.  Maybe this is a more robust approach.

The branch below has the changes with the callback.  I tested this with a really slow fade time and sent multiple backlight commands.  Once the in progress fade completed it then started the latest fade command. I believe it should handle any number of successive commands.  If it works for you I could do another pull request?
https://github.com/presslab-us/openHASP/tree/backlight_fade_cb

Yes, please do a new Pull request. I will test it.


Prevent max call stack size error; Fixes #801

only copy objects. See https://github.com/Netflix/falcor/issues/801 for more details

Coverage decreased (-0.03%) to 91.531% when pulling ff431bca7b3506449dc1d6d6b82faa39390f5f07 on kevnk:patch-1 into 09d9b64c22372e88848b4eaae66e1ebf5b4562f0 on Netflix:master.

Are you able to reproduce this error? Any chance you could add a test case?

@lrowe, much as I'd like a test case, in reading the code this looks like a legit bug. I'd like to merge it regardless, as the PR is quite stale. Objection?

LGTM.
@jhusain @lrowe your thoughts?

I'd recommend seeing if we can set up a test case which hits the failure case (as in defining a valid cache state which would cause the issue), if we can't get one. That way if the code gets moved around in the future we don't regress.

I don't think this fix is complete as current since Object.keys(null) throws a TypeError.

Coverage increased (+0.4%) to 91.942% when pulling a4d3f097685489cd023207650f26babec4186443 on kevnk:patch-1 into 09d9b64c22372e88848b4eaae66e1ebf5b4562f0 on Netflix:master.

Coverage increased (+0.4%) to 91.942% when pulling 5bbfd7656d7c578cf761766deec0857cbd0aa6d9 on kevnk:patch-1 into 09d9b64c22372e88848b4eaae66e1ebf5b4562f0 on Netflix:master.

Website team saw this happen as well when they had an extra custom field on their cache nodes (legacy reasons). i think this PR is not needed, instead simply avoid setting any custom fields on cache nodes.


Add dotenv support

Motivation
Developing locally is difficult to configure since the app is looking for hardcoded paths for .conf and .ztsd files in /assets directory that are moved to a directory named /app during container build.
Solution
By introducing support of .env files we can allow easier manipulation of these paths in addition to other config vars.  Primary motivation for use is making developing locally easier and eventually decoupling the api and dogecoind.

@solo-fish

I am not aligned with this "optional enhancement" as you call it; adding more redundant configuration just adds to the problems discussed in #24.
[..]

Makefile,
configuration/configuration.go,
dogecoin/configuration.go,
dogecoin/params.go,
dogecoin/types.go,

There are 3 types of "configuration":

Dogecoin chain parameters and encoding rules. Those are rather static for this repository as deviating from dogecoin/dogecoin would essentially create a not-Dogecoin chain. So these can be safely hardcoded. This applies to params.go, genesis.go and types.go and these can stay as-is.
Configuration that changes the behavior of internals. Many of these are in configuration.go, some of them can be overridden with environment variables, some cannot. Defaults can be hardcoded, but ALL should be able to be overridden with environment vars. The question is do we put those in a default .env file, or do we put them in the .go source code. We can make a choice here, but I like the .env approach as a "default configuration file" that we can package (all config in there can then be overridden by actual environment vars with the same name) and then build into the standard container. This allows for the tightly coupled, single container, approach that Coinbase wants for rosetta deployments, yet allows other deployments to be much more flexible by creating a .env for whatever the deployment scenario is?

Example: I run ~60 dogecoind deployments right now, some of them fully private for back-end services. Do I really want to run another node inside a massive container? I don't think so. I want to run a container w/ rosetta processes that hook into my existing node fleet. I also want to be able to put a reverse TCP proxy (w/ Kubernetes / haproxy) between my node(s) and be able to failover. Currently I am severely constrained with that because I'd have to change the hardcoded stuff in bitcoin/*.go. This PR would be a first step towards enabling much more flexible deployments, while retaining the default build process into one singular container for compliance with Coinbase requirements.

Operational mode selection: eg testnet/mainnet, online/offline. These are currently mandatory env variables. I don't think they need to be. Having a default operational mode for each, using the same .env file, would be nice. Eg the stuff that is now shorthanded in Makefile, but to be honest, I don't necessarily want to use makefiles for deployments.

Dogecoin chain parameters and encoding rules. Those are rather static for this repository as deviating from dogecoin/dogecoin would essentially create a not-Dogecoin chain. So these can be safely hardcoded. This applies to params.go, genesis.go and types.go and these can stay as-is.

This SGTM

Configuration that changes the behavior of internals. Many of these are in configuration.go, some of them can be overridden with environment variables, some cannot. Defaults can be hardcoded, but ALL should be able to be overridden with environment vars.

IMO coupling environment variables to configuration overrides isn't a great call (emphasis on my opinion..)
Looking closer at...

Many of these are in configuration.go, some of them can be overridden with environment variables, some cannot.

How is a new developer supposed to understand this? Are you going to document it? How is somebody supposed to know what subset of configuration  values set in .env gets overridden by environment variables? What if I want to run all four permutations ([mainnet, online], [mainnet, offline], [testnet online], [testnet, offline]) in a single container where environment variables are shared? How will people clearly understand this configuration hierarchy?
Why not just move all configurable values to.. a config?  -  If you want to store these in environment variables then part of your deployment process can be writing your environment variables to the configuration file.

This allows for the tightly coupled, single container, approach that Coinbase wants for rosetta deployments, yet allows other deployments to be much more flexible by creating a .env for whatever the deployment scenario is?

Sure - I think there are a ton of ways to go about this... I mean all it involves is not baking constants into your go binary...
I think my opinion is less valuable here though as you folks have more experience, like I mentioned, so if you guys are all aligned that don't hold up on me! Like you stated this will align us with the rosetta-specifications requirements as well.

Sorry to be slow on this, I get 6 million notifications per day because of Elon-sponsored dogecoin/dogecoin spam, so I have NO idea what I miss.

what subset of configuration values set in .env gets overridden by environment variables?

ALL. As soon as something is in .env, it out of the box can get overridden with env vars.

What if I want to run all four permutations ([mainnet, online], [mainnet, offline], [testnet online], [testnet, offline]) in a single container where environment variables are shared? How will people clearly understand this configuration hierarchy?

Why would you want to do that?
You cannot do this right now?

How will people clearly understand this configuration hierarchy?

Everything that is in .env can be overridden by environment vars.
.env can be changed
Anything that makes sense to be changed and still be Dogecoin MUST be in .env, so we cool?

Is this reasonable?

@patricklodder @xanimo
ACK! Approved on my end (Apologies as well on this hold-up!)

Why would you want to do that?
You cannot do this right now?

tldr; a "full deployment" is two instances of the same container running within the same "environment" (or really the same subnet).
One online container to service public-facing traffic, which, is coupled with an offline container that only accepts requests from the subnetwork (ideally only from its "parent" container) - this is how they specifically outlined in the docs I linked above.
Take a look at these "containers" I have deployed - they share a segregated root filesystem & unprivileged namespace (showing as you asked for an example of multi-container same environment).
+-------------------+---------+----------------------+------------+
| mnet-doge-offline | RUNNING | <IP_ADDRESS> (dog0)  | CONTAINER  |
+-------------------+---------+----------------------+------------+
| mnet-doge-online  | RUNNING | <IP_ADDRESS> (dog0)  | CONTAINER  |
+-------------------+---------+----------------------+------------+
| tnet-doge-offline | RUNNING | <IP_ADDRESS> (dog1)  | CONTAINER  |
+-------------------+---------+----------------------+------------+
| tnet-doge-online  | RUNNING | <IP_ADDRESS> (dog1)   | CONTAINER  |
+-------------------+---------+----------------------+------------+

Is this reasonable?

YES! I'm sorry as well - I mentioned please don't block on me! D:

Take a look at these "containers" I have deployed - they share a segregated root filesystem & unprivileged namespace (showing as you asked for an example of multi-container same environment).

That's how I often run things too. When I'd do it with Kubernetes, this would mean I have 4 deployments of the same container image, with different container.env specs. On docker compose, I'd add different environment content for each, with docker cli I'd start them with differing -e arguments.
Summarizing this PR:

One use-case MUST need only 1 (generic) image which configuration can be manipulated by passing environment variables to it. This is achievable with this code, at least for starters. ✅
There SHOULD be a default configuration. That was already there and doesn't change with this, but the .env makes it more configurable. ✅
There COULD be a default mode selection. Currently implemented as TESTNET, ONLINE (we could discuss whether this is better as MAINNET instead of TESTNET, raise an issue if you think it's better as mainnet, and why.)

This PR makes configuration more user-friendly and gives us a vehicle to pull hard coded configuration out of .go files, into environment vars, per 1. Reducing the need for custom code and custom images.

Sounds good.
On Sun, May 30, 2021 at 1:52 PM Patrick Lodder @.***>
wrote:

@.**** commented on this pull request.
In dogecoin/configuration.go
https://github.com/rosetta-dogecoin/rosetta-dogecoin/pull/40#discussion_r642127049
:

if configurationDirectory == "" {

configurationDirectory = "/app"

}

To me it's just about consistency. If we change it at one place, we can
change it at the other.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/rosetta-dogecoin/rosetta-dogecoin/pull/40#discussion_r642127049,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AHTBONDZURKOOWXIJIR3C2TTQKQP3ANCNFSM43YLGO4A
.


No Random Encounters after installing FF6 version

Title, turning on speed with F1 works fine. F2 will trigger 'e' to appear on screen, and remove it, but always has no encounters

Having the same issue. Installed Memoria after starting the game and then "random encounters" were gone. Toggling with F2  makes no difference. Deleting the FF6 mod turns "random encounters" back on.

Happening here as well. If it is at all helpful, I've attached my log.
LogOutput.log

Having the same issue. Log attached.
LogOutput.log

[Error  :    Detour] System.BadImageFormatException: Method with open type while not compiling gshared
File name: 'Assembly-CSharp'
  at (wrapper dynamic-method) MonoMod.Utils.DynamicMethodDefinition.(il2cpp -> managed) CheckEncount(intptr,intptr,intptr*,UnhollowerBaseLib.Runtime.Il2CppMethodInfo*)

Same issue.
LogOutput.log

https://github.com/BepInEx/BepInEx/issues/366


K9 emaile receive plugin for tasker doesn't work anymore

It seems this functionality got disabled. Tried to downgrade K9 app but issue persists. Any workaround for using the plugin?

Please use the forum for support requests.
For this particular question, see:
https://forum.k9mail.app/t/tasker-k9-email-received-event-no-longer-working/1218


[FEAT] Building an API for the resources instead of just fetching from json data

Is your feature request related to a problem? Please describe.
We are fetching JSON data from a js file and rendering it using React but how about we create separate APIs for each type of resource and fetch data using that API!
Describe the solution you'd like
We can build a REST API for each type of resource and fetch data from those APIs also we can let users post their own suggested resources instead of displaying hand-coded resources. This solves the problem of hand-coding the resources or we can get an already-built third-party API and use it.
Describe alternatives you've considered
described in the solution.
Additional context
Add any other context or screenshots about the feature request here.
Just like how we fetch weather data from Example.

want to work on it?


@Callable function with default parameter values breaks at runtime if parameter isn't supplied

Describe the bug
I get a runtime index out of range error in a @Callable function with default parameters (see screenshots). This only happens if I call the function from GDScript with findPlayers(2, 2) and not when filling out all the parameters findPlayers(2, 2, 0, 0)
Also tested this with just one default parameter.
To Reproduce

Create a @Callable function with one parameter that has a default value
Call that function from GDScript without a parameter
See index out of range error

Expected behavior
Default values should be used if they are not supplied
Screenshots
Original function:

Runtime error:

Additional context
I've only tested this on iOS but I don't see why it would be device exclusive

Thank you for this bug report!
The issue is that SwiftGodot does not currently register methods with default argument values.
The following fixes need to take place:

[ ] Extend ClassServices.registerMethod to take an array of Default values, and pass this to classdb_register_extension_class_method, currently, we hardcode this to zero
[ ] Make the MacroGodot code that finds @Callable pass the values to the registration method


Cannot edit a script once uploaded

I uploaded a script and now when I go to the view page and press the edit button nothing happens. Dev tools shows the following messages:
At startup:
serviceWorker.ts:105 Error during service worker registration: TypeError: Failed to register a ServiceWorker for scope ('file:///C:/Users/gpduck/AppData/Local/UniversalAutomationDesktop/app-1.0.0/resources/app/.webpack/renderer/main_window/undefined/') with script ('file:///C:/Users/gpduck/AppData/Local/UniversalAutomationDesktop/app-1.0.0/resources/app/.webpack/renderer/main_window/undefined/service-worker.js'): An unknown error occurred when fetching the script.

And then I've attached the errors from clicking the view button as the stack trace is a bit verbose. No additional errors are generated when clicking the edit button.
I checked and my renderer/main_window/ folder only has index.html, index.js, and index.js.map in it.

Resolved in next version.


Display the progress of zip downloads in Pharo

Anyone to review/merge?

if the fact that pharo-6.1 is failing is okay, I can press the button

As I said in the other PR, I think that the fact that P6.1 is failing is not due to this PR.
About this error on P6.1 job, it will probably be taken care with the PR from Esteban here: https://github.com/Metacello/metacello/pull/490
The Pharo 6.1 job is green and when gemstone and squeak will be too it will resolve the problem.

@dalehenrich Thank you very much!


Help!

Hello,
i need help. Is there someone that has a reference for this library?
TNX

All processing libraries ship with the reference files.
So you can access  it via (processing sketchbook location)/libraries/pixelflow/reference

The reference material can also be accessed here: https://freshfork.github.io/PixelFlow/reference/


Support updates to Marketplace-related webhooks and REST APIs

GitHub Developer API announcement:
https://developer.github.com/changes/2018-10-31-improved-experience-for-marketplace-pending-changes/
This would be a great PR for any new contributor to this repo or a new Go developer.
All contributions are greatly appreciated!
Feel free to volunteer for any issue and the issue can be assigned to you so that others don't attempt to duplicate the work.
Please check out our CONTRIBUTING.md guide to get started.
Thank you!

@gmlewis New contributor here. Interested in working on this, could you assign this issue to me?

Thank you, @srmocher!
I'm no longer able to send a repo contributor invite to you, but please consider yourself assigned. :smile:

@gmlewis : I am also interested to work on this issue. It seems @srmocher working on this one. Can you please assign me other issues/bugs ?

Thanks for your interest, @dreamer-89!
My recommendation to you is to go through the list of open issues in this repo and choose one that interests you... then add a comment that you want to work on it.
If someone is already listed on it, chances are high that they have forgotten about it and you can ask to take it over from them.

Thank you so much @gmlewis :) :)

@gmlewis : Please review
https://github.com/google/go-github/pull/1041

@dreamer-89 - sorry I wasn't clear before... you apparently misunderstood me. This issue is assigned to @srmocher and so you should not be submitting PRs against this issue. I started to review your PR and came across a number of issues (both with the PR and with the GitHub documentation), then came back here and realized that this issue is not yours (currently) to be working on.
As a result, I'm going to close your PR and let's give @srmocher a chance to submit a PR against this issue.
Thank you very much for your enthusiasm, but please go back through the list of other open issues and chose one of those to start contributing to. If it is already assigned (like this one... you have to read the comments to determine that, unfortunately, as I no longer have permissions in this repo to send contributor invites), please first ask if you can take  over the issue, but only if they've had a fair amount of time (a week or two maybe) to work on it.

(invites sent to @srmocher and @dreamer-89.  sorry about the delay)

@gmlewis requesting assignment :hand:

If this issue is resolved by #1042 then we could close it. Or is there something that still needs doing here?

Thank you, @sinisterstuf - I believe you are correct that this can be closed.
Feel free to reopen if anyone disagrees.


[DevTask] Support detail transfer

https://github.com/kijai/ComfyUI-IC-Light added a detail transfer node which can be helpful to people who want to preserve high freq channel information on their fg image, such as small character on product.

Done in #24


Publish Gherkin package with netstandard 1.5 support

Since the csproj files have been migrated to new format and you've added support for netstandard 1.5, do you mind publishing it to nuget?

Some PRs (#7, #9, #10) needs to be merged and then we can think about a release to NuGet.org.
@aslakhellesoy Any timeframe when this is happening?

A beta or rc version (without those enhancements) would be enough for me.

Hi @SabotageAndi please feel free to merge those PRs. If I give you NuGet access, can you make an rc release and also tag this repo with v4.1.4.rc1?
I've added you to the gherkin core team!

I can add you to NuGet if you tell me your NuGet user name @SabotageAndi

I can do the merging of the PRs and  making the release in the next days.
But I am not sure how merging back to the mono repo works. Is there any doc for that?
NuGet username is: AndreasWillich

Great I'll let you know when I get you set up. I'll take care of the monorepo sync and CHANGELOG update. Sorry, I need to document that process so anyone in core can do it.

@jorgebay Sorry, didn't had yet anytime for it. Too much other work to do.
I will have a look at it on the weekend.

@aslakhellesoy I made some last fixes in the package info and activated strong name signing.
Release Build of the NuGet package can be found here: https://www.dropbox.com/s/xl5w87yym8c79s1/Gherkin.4.1.4-rc1.nupkg?dl=0
Could you upload it on NuGet.org as long as I don't have the permissions for that? Thanks!

Has this 4.1.4-cr1 release fixed the NETSTANDARD1_5 || NETCOREAPP1_0 || NETCOREAPP1_1 check? When I use NET Standard 2, it defaults to .NET 4.5 and breaks my code looking for NET 4.5 libraries.
It would solve the issue I reported.

-#if (NETSTANDARD1_5 || NETCOREAPP1_0 || NETCOREAPP1_1)
+#if (NETSTANDARD1_5 || NETSTANDARD2_0 || NETCOREAPP1_0 || NETCOREAPP1_1 || NETCOREAPP2_0)

Move the project to NET Standard 2.0 is indeed not necessary, or recommended, but this change, that was part of the rejected PR 6 in Gherkin/GherkinDialectProvider.cs and Gherkin/GherkinLine.cs, would fix my issue and allow the parser to be used by NET Standard 2.0 projects.

No idea. Please try it and report back.
From the nuspec the package targets NetStandard 1.5 and .net 4.5.
I would assume,that in case of a NetStandard 2.0 lib, it would take the NetStandard 1.5 assembly.

That are compile time ifs. The code is already baked when you reference the assembly.

I just tested the 4.1.4-rc1 and it works with NET Standards 2.
I guess https://github.com/cucumber/cucumber/issues/259 can be closed when this version gets published.
Thanks

@SabotageAndi I have uploaded your package to nuget.org... (also added you to the owners for next time) Thank you!

@gasparnagy Thanks!

Thanks @gasparnagy and @SabotageAndi!


Add new constructor for ScriptPurpose members

We can construct a spending ScriptPurpose as follow:
const output_id: TxOutputId = ...
const spending_sp: ScriptPurpose = ScriptPurpose::Spending::new(output_id)

Everything looks correct.
Until now all the builtin enum variant constructors have been implemented differently though. For example:
DCert::new_register(...)

The reason for that is that user-defined enum methods (static and non-static) can only be defined on the enum type, not on the variant (that is also how it works in rust).
I suggest changing the constructors for consistency:
ScriptPurpose::new_minting()
ScriptPurpose::new_spending()
ScriptPurpose::new_rewarding()
ScriptPurpose::new_certifying()

new Helios version: v0.8.4

Nice contribution. Thanks!

Much appreciated boss, keep up the great work!


Add more options in server configuration

I recommend that they add more options on the server such as editing the maximum number of players, adding that the server photo can be edited, etc.

Hey @DavyCraft648 Here I made some changes to add a maximum number of players. I haven't tried it yet but I think it works.
config.yml: https://github.com/Trollhunters501/Barrel/blob/main/src/main/resources/config.yml#L6
org/barrelmc/barrel/config/Config.java: https://github.com/Trollhunters501/Barrel/blob/main/src/main/java/org/barrelmc/barrel/config/Config.java#L37
org/barrelmc/barrel/server/ProxyServer.java: https://github.com/Trollhunters501/Barrel/blob/main/src/main/java/org/barrelmc/barrel/server/ProxyServer.java#L151


Add a Swagger Spec for the API subset required by JupyterHub

Fixes #39
Not sure exactly if this belongs here - it's only the subset that's strictly required for jupyterhub
to work properly.

If the goal is to document what JupyterHub requires and nothing else, it wouldn't belong here. But I think we should have a swagger doc here for this. If we want to keep track of the subset that JupyterHub relies upon, we can make a minimal reference on the JupyterHub repo that points to the complete spec here (e.g. JupyterHub uses Configurable HTTP Proxy's API, but does not require host-routing support).

Ok, so only the host support is something that CHP has but jupyter doesn't use, right?

Probably also need to add info about the Authorization header.

Rebased, squashed them around - is generic enough now, I think.

Awesome!


Fix pip "extras" names

I was getting an error when using the onnx functionality and I found the error was a mismatch between setup.py and the README.

Thank you!


NVM tool does not create an environment variable

Describe the bug
The tool nvm is supposed to create an environment variable called NVM_DIR which points to the directory where the tool is installed.
On the latest mac agent this works, but on ubuntu 19 or 20 this environment variable doesn't work. I have to relly on $HOME/.nvm to make the tool work
Question, Bug, or Feature?:
Bug
Virtual environments affected

[ ] macOS 10.15
[?] Ubuntu 16.04 LTS
[x] Ubuntu 18.04 LTS
[x] Ubuntu 20.04 LTS
[?] Windows Server 2016 R2
[?] Windows Server 2019

Expected behavior
NVM_DIR env variable should point to /home/vsts/.nvm
Actual behavior
NVM_DIR env variable does not exist

Hello,
Default shell doesn't load bashrc and this variable is not initialized properly.
Could you please try to invoke bash as
- run: printenv | sort
  shell: bash -l {0}

Hi,
The issue is in Azure Classic Pipelines with the Command Line Task element. I can not pass arguments to it

Could you please try to add source $HOME/.bash_profile as a first line to Command Line Task element? It will be the same like -l argument in GitHub Actions

Sure!
If I only put the source $HOME/.bash_profile, I get:
`N/A: version "10.20.1 -> N/A" is not yet installed.
You need to run "nvm install 10.20.1" to install it before using it.
`
(10.20.1 is the version stated at my project's .nvmrc). So it seems, the nvm tool is wrongly installed in the virtual-environment to begin with. Because it should not execute anything (the rest of the tools don't do that).
The output part for the printenv | sort is:
AGENT_ACCEPTTEEEULA=True AGENT_BUILDDIRECTORY=/home/vsts/work/1 AGENT_DISABLELOGPLUGIN_TESTFILEPUBLISHERPLUGIN=true AGENT_DISABLELOGPLUGIN_TESTRESULTLOGPLUGIN=true SYSTEM_JOBIDENTIFIER=Job_1.__default SYSTEM_JOBNAME=__default SYSTEM_JOBPARALLELISMTAG=Private SYSTEM_JOBPOSITIONINPHASE=1 SYSTEM_PHASEATTEMPT=1 SYSTEM_PHASEDISPLAYNAME=Agent job 1 SYSTEM_PHASEID=2f97f1d8-1234-abcd-8782-cbcebf2b3d67 SYSTEM_PHASENAME=Job_1 SYSTEM_PIPELINESTARTTIME=2020-06-20 09:32:40-04:00 SYSTEM_PLANID=147fe45a-1234-5678-a477-c91d5013597d SYSTEM_PULLREQUEST_ISFORK=False SYSTEM_SERVERTYPE=Hosted SYSTEM_STAGEATTEMPT=1 SYSTEM_STAGEDISPLAYNAME=__default SYSTEM_STAGEID=96ac2280-1234-5678-99de-dd2da759617d SYSTEM_STAGENAME=__default SYSTEM_TASKDEFINITIONSURI=https://mycompany.visualstudio.com/ SYSTEM_TASKDISPLAYNAME=Command Line Script SYSTEM_TASKINSTANCEID=40b1ee41-1234-5678-aa04-4b76a5c732e5 SYSTEM_TASKINSTANCENAME=CmdLine SYSTEM_TEAMFOUNDATIONCOLLECTIONURI=https://mycompany.visualstudio.com/ SYSTEM_TEAMFOUNDATIONSERVERURI=https://mycompany.visualstudio.com/ SYSTEM_TEAMPROJECT=SelfValidationEngine SYSTEM_TEAMPROJECTID=8251b8fb-1234-5678-af95-bbacc17d7c1e SYSTEM_TIMELINEID=147fe45a-2321-1234-5678-c91d5013597d SYSTEM_TOTALJOBSINPHASE=1 SYSTEM_WORKFOLDER=/home/vsts/work TASK_DISPLAYNAME=Command Line Script TF_BUILD=True USER=vsts VCPKG_INSTALLATION_ROOT=/usr/local/share/vcpkg VSTS_AGENT_PERFLOG=/home/vsts/perflog VSTS_PROCESS_LOOKUP_ID=vsts_0f30466a-1234-5678-9b97-32b49a0eb6b5 _=/usr/bin/printenv agent.jobstatus=Succeeded
*I have edited all the GUIDs and private stuff
I hope this information is useful to understand the issue.

Yep, I have reproduced issue from my side.
NVM tries to resolve version from nvmrc automatically during call . "$NVM_DIR/nvm.sh if .nvmrc file exists in current directory.
Also, I have found the root cause. It is because default alias for NVM is not specified during image-generation. I will prepare PR with fix. Thank you for your report.

Thanks for your help Maxim!

@ritmos , PR with fix is merged.
We are expecting these changes to be deployed next week. I will keep issue opened for now

@ritmos , image was deployed. Could you please test that everything works as expected?

I have confirmed that issue is resolved. Closing the issue.

Thanks Maxim and sorry for the late feedback. I was off. It seems to work 👏


[SPARK-35971][SQL] Rename the type name of TimestampNTZType as "timestamp_ntz"

What changes were proposed in this pull request?

Rename the type name string of TimestampNTZType from "timestamp without time zone" to "timestamp_ntz".
Why are the changes needed?

This is to make the column header shorter and simpler.
Snowflake and Flink uses similar approach:
https://docs.snowflake.com/en/sql-reference/data-types-datetime.html
https://ci.apache.org/projects/flink/flink-docs-master/docs/dev/table/concepts/timezone/
Does this PR introduce any user-facing change?

No, the new timestamp type is not released yet.
How was this patch tested?

Unit tests

Test build #140508 has started for PR 33173 at commit 5fd930d.

Test build #140515 has started for PR 33173 at commit 43ed780.

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45021/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45021/

Test build #140508 has finished for PR 33173 at commit 5fd930d.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140508/

Thanks for the review. Merging to master

Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/45028/

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/45028/

Test build #140515 has finished for PR 33173 at commit 43ed780.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/140515/


Conceptual design of dry-fruits-website

Home page design(asside,navbar,menubar).
login page desing.
register page design.
contact us page design.
footer page design.
about us page design.

thanks


first pass at adding in the expose flag. needs tests

Coverage decreased (-0.3%) to 95.6% when pulling b7ec2969dceb84bdf2f392d4c7a8fde8cfecb6b9 on lholmquist:206-expose-route-flag into a2b1deb5040e26a6f3be98cadad8ec62f4102ba4 on bucharest-gold:master.


homepage: functionality

under the Food recall; I like it better when you clicked on the link and it forced you to register or login in.  It's slightly unintuitive in its current state.

if you are a returning user you can login or you have the opportunity to sign up now.


SVG Support

Hi @geemi725,
I added a new method insert_svg which can be used as a post-plot step to replace mol images with SVG versions. This enables us to have vector figures. Please review PR and then make a new one where we replace paper figures with vectorized versions.
Also, either you or me needs to add info to README in this PR or yours about doing this.

Should we refactor to use skunk?