non-embedded font using identity encoding error leads to hebrew text not displayed correctly

Attach (recommended) or Link to PDF file
4454c98b88d37d5dad779b60a3f35e6e.pdf
Configuration:

Web browser and its version: 102.0
Operating system and its version: Mac OS 12.1
PDF.js version: latest stable
Is a browser extension: no

Steps to reproduce the problem:

Open pdf file with pdf.js demo

What is the expected behavior?

What went wrong? (add screenshot)

When operating with file using various cli tools we have next errors reported
non-embedded font using identity encoding: Arial
My understanding is that file uses non-embeded Arial font encoded with identity-H encoding which uses symbol codes from font and then needs CMap to translate those to unicode and display.
My implementation has CMaps attached  and desktop viewer is able to render pdf properly so its unclear where the issue emerges
Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

Please note that all PDF documents should be embedding their fonts (according to the specification), since otherwise it generally cannot be guaranteed that the document renders correctly.

Hi @Snuffleupagus
Thats what we would expect from all PDFs but thats not what the evidence suggests.
My concern is that system pdf viewer supports unembeded fonts while pdfjs doesnt.
How can we ensure there is no setup that will  enable normal rendering? How can we investigate the reason for that?

My concern is that system pdf viewer supports unembeded fonts while pdfjs doesnt.

Note that the PDF.js library does support non-embedded fonts, to the best of our ability. However, as can be seen in this issue there'll sometimes be PDF documents that require smaller tweaks in order to work (the same applies to all PDF viewers).

How can we ensure there is no setup that will enable normal rendering with non-embeded fonts?

Generally speaking, and this applies to all PDF viewer, you simply can't. If you want guarantees, please embed the font data in the PDF document.

My concern is that system pdf viewer supports unembeded fonts while pdfjs doesnt

Only if the fonts are available on the system, but you can't assume them to be available forever or to all users!

Thanx for your reply @Snuffleupagus
Can someone please clarify what changes did you guys provide in related PR caz for regular library user like me its hard to identify the concept behind those changes?
thanx much for fast and meaningful feedback!


replaced merge with old mergeInPlace

This change makes merge() act like other collections {{merge}} methods and update the item in place.  The mergeInPlace() method is removed.  Any previous use of merge should be replaced with
BloomFilter bf = bf1.copy();
bf.merge( thing );

fixes https://issues.apache.org/jira/browse/COLLECTIONS-829

Any issues with merging this?


Don't rely on the time-descending order of the "required-tasks" data

Add sort_by and rank functions
Adds lib.arrays package with sort_by and rank functions.
Add time.newest function
Use the newest task instead of first by order
Ref. https://issues.redhat.com/browse/HACBS-1507

I think we also want to call time.newest when processing acceptable bundles, right? https://github.com/hacbs-contract/ec-policies/blob/main/policy/lib/bundles.rego#L98

I think we also want to call time.newest when processing acceptable bundles, right? main/policy/lib/bundles.rego#L98

I think it's bit more involved than that, that function ends up calling time.acceptable_items which uses time.future_items and time.most_current, so I think the change is needed to time.most_current.

Codecov Report

Merging #277 (68a5dea) into main (e3cbf07) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##              main      #277    +/-   ##
==========================================
  Coverage   100.00%   100.00%
==========================================
  Files           60        62     +2
  Lines         1629      1738   +109
==========================================
+ Hits          1629      1738   +109

Impacted Files
Coverage Δ

policy/lib/tekton/task.rego
100.00% <ø> (ø)

policy/lib/array_helpers.rego
100.00% <100.00%> (ø)

policy/lib/array_helpers_test.rego
100.00% <100.00%> (ø)

policy/lib/time.rego
100.00% <100.00%> (ø)

policy/lib/time_test.rego
100.00% <100.00%> (ø)

policy/lib/bundles.rego
100.00% <0.00%> (ø)

policy/release/java.rego
100.00% <0.00%> (ø)

policy/release/tasks.rego
100.00% <0.00%> (ø)

policy/lib/bundles_test.rego
100.00% <0.00%> (ø)

... and 13 more

Going to merge this, I think it is addressing what we need at the moment.


Add documentation site

Create a GitHub Pages site for CoreWF. WF has lots of documentation in MSDN but only a certain portion will work in CoreWF. The topics to cover are:

Getting started tutorial
Roadmap
Limitations

Also update the .NET Foundation description to include a link to the documentation site.


fix extraEnvs in values.yaml

some 'extraEnvs' don't have a default value, and are missing '{}'. This prevents helm from setting those values with a key/value.

This is due to the DCO bot requiring your git commits to be signed.  This is required by the CNCF to ensure that the committer's name can not be spoofed.

If you hit details on this, it will tell you how to sign your commits.

I set DCO to pass manually here.  Thanks for the quick contribution!


License could not be resolved from https://raw.github.com

Nuget package example: Newtonsoft.Json 10.0.1
https://raw.github.com/JamesNK/Newtonsoft.Json/master/LICENSE.md

released in 2.1.2


add links to bugtracker and github

update links, this is was callum suggested in the other PR. I think this is a good idea. Maybe we can find something better then other ?

The way the qujax extension looks is not bad.


Add enabled as an option to log4j2 appender

I am looking for the ability to "enable/disable" rollbar from Log4j2's appender xml. Currently, it is always enabled by default. Looking to add the option of being able to turn off Rollbar.
        <Rollbar name="ROLLBAR">
            <accessToken>${rollbar.access.token}</accessToken>
            <environment>${environment}</environment>
            <enabled>${rollbar.enabled}</enabled>
        </Rollbar>

Released in https://github.com/rollbar/rollbar-java/releases/tag/v1.6.0


Misuse of FreeRTOS task notifications as semaphores without give/take API

Right now there seems to be race conditions in places where we wait for a task to do something because I've somehow failed to notice that FreeRTOS has a separate semaphore API for task notifications (i.e. for waiting on notification state >= 0) that would solve a significant number of problems.
Fixes required in:

[ ] servicer (stm)
[x] serial (esp)

[x] to grabber
[x] to dupm

[x] matrix refresh (stm)

(apparently the FreeRTOS on the ESP8266 is too old to use them in esp-land, but the recent mutex should totally alleviate the problem)


Cover mutations with no id

A lot of changes in the UI don't have an ID, TR should record these too.
Will be on by default, with config option.

done in 0.4


Redis Setup flow

Create a method in ShellService to setup redis

Estimate (hours): 8
Uncertainty factor: 2

Estimate (hours): 8
Uncertainty factor: 2

Estimate (hours): 2
Uncertainty factor: 2

Estimate (hours): 2
Uncertainty factor: 2


listWebhooks function definition incorrect

    Spark.prototype.listWebhooks = function(callback)

should be
    Spark.prototype.listWebhooks = function(accessToken, callback)

I think.

The accessToken is stored on the spark object. Is it expecting you to call login first before calling any other methods. Check out https://docs.particle.io/reference/javascript/#logging-in for more information.


Generating a PDF includes a white border on the downloaded PDF

Minimal, reproducible example
const pdf = await page.pdf({
            path: './pdf/white_border_3.pdf',
            printBackground: true,
            preferCSSPageSize: true,
            height: '800px',
            width: '650px',
            scale: 1,
            margin: {top: '0px',right: '0px',bottom: '0px',left: '0px'}
          })

Error string
A white border is added on my PDF when generated using Puppeteer.
Bug behavior

[ ] Flaky
[X] PDF

Background
No response
Expectation
Puppeteer cover the entire page with HTML content without extra white borders
Reality
white_border_3.pdf
Puppeteer configuration file (if used)
No response
Puppeteer version
21.3.8
Node version
16.13.0
Package manager
npm
Package manager version
8.1.0
Operating system
Linux

Hello, can you please provide the HTML used to generate the PDF?
That will make debugging this much easier on our end.

@Lightning00Blade  please check https://codepen.io/Annu-Valand/pen/RwEzpOd?editors=1111 for HTML

I'm facing the same issue

I'm having the same issue, the PDF generated has a white border on the right and on the bottom. Any fix ?

Been experiencing the same problem, turns out it was a part of the background ending up in the document due to page format miscalculation (296mm for A4 paper instead of 297mm), noticed it because it was pushed around by margins. Might be something to look out for, hope this helps someone.


Fix unused lambda capture warnings with clang-5

Codecov Report

Merging #311 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #311   +/-   ##
=======================================
  Coverage   95.73%   95.73%
=======================================
  Files          61       61
  Lines        3538     3538
=======================================
  Hits         3387     3387
  Misses        151      151

Impacted Files
Coverage Δ

packages/Search/test/tstLinearBVH.cpp
100% <100%> (ø)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201fedb...6ce897f. Read the comment docs.


chore(deps): upgrade configuration

Upgrades project dependencies. See details in workflow run.

Automatically created by projen via the "upgrade-configuration-2.x" workflow

⚪ Backport skipped
The pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually.
Manual backport
To create the backport manually run:
backport --pr 2326

Questions ?
Please refer to the Backport tool documentation


SwitchTo make taiko unable to interact with the page

Expected behavior
After using SwitchTo() taiko should be able to find elements on the current page
Actual behavior
taiko is unable to find any element on the page using any selector until goto is called
Steps to reproduce

click on a link opening a new tab
use switchto() to switch to this tab
use click() on any element with any selector (throw element not found)
go back to step 2
use goto() with the same URL as the current tab
repeat step 3 (element is found and taiko click on it)

Versions
taiko: 1.0.2
node: 12.13.0.

@RBLG I could replicate the issue with below scripts.
Works :
const { openBrowser, goto, link, click, closeBrowser } = require('taiko');
(async () => {
    try {
        await openBrowser();
        await goto('https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_target');
        await click(link('Visit W3Schools.com!'));
        await goto('https://www.w3schools.com/');
        await click(link('LEARN HTML'));
    } catch (error) {
        console.error(error);
    } finally {
        await closeBrowser();
    }
})();

Doesn't work :
const { openBrowser, goto, link, click, closeBrowser } = require('taiko');
(async () => {
    try {
        await openBrowser();
        await goto('https://www.w3schools.com/tags/tryit.asp?filename=tryhtml_link_target');
        await click(link('Visit W3Schools.com!'));
        await switchTo('https://www.w3schools.com/');
        await click(link('LEARN HTML'));
    } catch (error) {
        console.error(error);
    } finally {
        await closeBrowser();
    }
})();

We will work on fixing this soon. Thanks for reporting.

This works as expected on Taiko release 1.0.0 in case you want, you can revert to 1.0.0 for the fix.
We will be fixing this soon.

This maybe related to https://github.com/getgauge/taiko/issues/940 as electron apps also work on 1.0.0

Fix available in commit aa29668ca7266d7f46b90c5143bd9f4259579d8f

After switching to url we are able to perform the required action on webelement successfully.
Based on the observation this issue has been verified and found fixed.
Tested version:
d9a4b6a65628db44301305757a3a5c5ad412c2ce

This issue has been tested and verified against the master.
Tested version: 9a89e88d65df8744055716483f349b103976784c

I think its didn't work in
Version: 1.0.4 (Chromium: 81.0.3994.0) 3c0e34ecf36d90bdb0d329a139ae64e0d0a306e3
switchTo make taiko unable to interact with the page. However when you change the tab using openTab() and goto(), it makes elements clickable.

@JakubSzpak there's a fix for this on the master branch. Can you please install the latest version from master using
npm install https://github.com/getgauge/taiko

And check if this works?


Mouse support

OS: Windows 10 Creators Update
Terminus version: Alpha 15
From my testing with micro and htop, it looks like Terminus does not support mouse input, both in a Bash on Windows session and a SSH session inside Bash on Windows (Windows CMD and PowerShell don't feature the concept of mouse input, to my knowledge).
Are there any plans to support it? This would be really appreciated to make text editing much more convenient, especially over SSH (where GUI editors may not be an option).

Confirming the same, I just hit this myself.

Mouse input seems to be working in micro with the new xterm back-end on Linux, but I haven't tested it on Windows yet.

I'd love to see mouse support too!

Still broken on latest version.

Duplicate of #290


How to set defaultValues for two nested multipliers? Possible bug

Hello, i have problem with setting default values into two multipliers (second multiplier is inside first one).
i have this kind of array with default values:
$defaultValues = array(
                    0 => array(
                        'input1' => 'val1',
                        'input2' => 'val2',
                        'multiplier_child' => array(
                            0 => array(
                                'input3' => 'val3'
                            ),
                            1 => array(
                                'input3' => 'val4'
                            )
                        )
                    ),
                    1 => array(
                        'input1' => 'val5',
                        'input2' => 'val6',
                        'multiplier_child' => array(
                            0 => array(
                                'input3' => 'val7'
                            )
                        )
                    )
                );

Default values are set into input1 and input2 correctly, but input3 is empty at both containers.
Do i have right array for default values?

Wow, thank you for light speed fix :-) Its working now


Updating dependencies

I've identified 2 unnecessary dependencies: marked and markdown-extra.
Both dependencies were removed.
The below dependencies were updated to its latest version:
"babel-runtime": "^4.7.13",
"cli-color": "^0.3.2",
"co-prompt": "^1.0.0",
"commander": "^2.7.1",
"less": "^2.4.0",
"marked-metadata": "0.0.6",
"mkdirp": "^0.5.0",
"ncp": "^2.0.0",
"node-static": "^0.7.6",
"nunjucks": "^1.2.0",
"open": "0.0.5",
"permalinks": "^0.3.1",
"rimraf": "^2.3.2",
"stylus": "^0.50.0",
"underscore": "^1.8.2"

I tried to update co to its latest version but it breaks the config command.
co version must to stay in ~3.0.5 until we remove it.
The below dev-dependencies were updated to its latest version:
"chalk": "^1.0.0",
"glob-manipulate": "^1.1.1",
"gulp": "^3.8.11",
"gulp-babel": "^4.0.0",
"gulp-batch": "^1.0.5",
"gulp-filter": "^2.0.2",
"gulp-jscs": "^1.4.0",
"gulp-jshint": "^1.9.2",
"gulp-load-plugins": "^0.8.1",
"gulp-mocha": "^2.0.0",
"gulp-rename": "^1.2.0",
"gulp-src-ordered-globs": "^1.0.3",
"gulp-util": "^3.0.4",
"gulp-watch": "^4.2.0",
"jshint-stylish": "^1.0.1",
"lazypipe": "^0.2.2",
"merge-stream": "^0.1.7",
"reversepoint": "^0.2.1",
"should": "^5.2.0",
"through": "^2.3.6",
"unique-stream": "^2.0.2",
"vinyl-paths": "^1.0.0"

All Harmonic features were well tested and it seems to be working just fine with the update.
Perhaps some review will be necessary //cc @UltCombo
This PR partially closes #121 as we still need to add the badges.

Nice work! But isn't the marked module that parses our markdown (posts, pages) files?

I have a full day tomorrow so I probably won't be able to test this throughout soon.

The package marked-metadata does the job.

Oh I see, nice!

Now I have time to test. Looks like everything is working fine indeed, nice work @jaydson!
I'll add the badges and merge this. =]

:+1:

wow awesome!


Note: the code by cog can be different from what is currently generated, I'd need some help to review these changes and determine if they are correct/acceptable.
I followed the issue tracker tutorial and the results seem to make sense to me but I'm far from being an expert :sweat_smile:

Rebased, everything still looks green :)


Dev mode reloads TS changes twice, leaving the user with an empty screen

Description of the bug
When I make a change to a TS view in React, the update gets displayed correctly. But after a while, the screen refreshes and shows an empty page.
Minimal reproducible example
Create a project with npx @hilla/cli --init react, change a view
Expected behavior
It should work.
Actual behavior
It doesn't. The following gets displayed in the console. I have cleared all service workers etc from the domain.

Versions:
- Vaadin / Hilla version: 2.1.4
- Node version: 19.5
- Java version: 17
- OS version: MacOS
- Browser version (if applicable): Chome latest

I think the issue here is that Vite restarts and the browser refresh happens during the restart. Then you get 500 for all resources.
The Vite restart issue is fixed in https://github.com/vaadin/flow/pull/17433
What remains strange here is why you get the restart when changing a TS file because the whole chain of events start from Spring Boot restarting, which happens when changing a file on the classpath, not when changing a TS file


Add a StructLike class that extends Error.

Description
Exception classes should extend this so that they derive from Error.
Motivation and Context
As mentioned in the thrift-typescript GitHub issue, it's useful for exceptions to derive from Error so they have stack traces and because some frameworks expect it. The GitHub issue mentions graphql-js. Jest's toThrow() function would also benefit from this. See the related thrift-typescript PR for more details.
How Has This Been Tested?
Tested locally.
Possible remaining work:

Add a test?
Bump version number so end users can require the new version.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[x] All new and existing tests passed.

I can clean this up a little (fix tests, update documentation as needed, read the CONTRIBUTING document), but wanted to get feedback from Credit Karma folks to make sure I'm heading in the right direction before spending more time on it.


MAINT, TST: CuPy skip ndimage test

Fixes gh-21486

scipy/ndimage/tests/test_filters.py::TestNdimageFilters::test_correlate_convolve_axes was causing 240 test failures on main with CuPy backend because the CuPy ndimage equivalents of convolve and correlate don't have an axes kwarg, even in the latest stable release.

So, skip these tests with CuPy for now.

[skip cirrus] [skip circle]

Sounds like Lucas is happy here. The CI is as well. Given that this just skips a test on GPU/CuPy while we wait for upstream CuPy release with new feature, and avoids 240 CuPy-based test failures with a single test marker, the self-merge can be forgiven I think.


Dialogs showMessageBox and showSaveDialog blocks each other

Hello. I use autoUpdater module in my app. I was saving file by showSaveDialog when message about update had appeared. It turned out that i could not submit neither of the dialogs. Even by keyboard.

You should pass callbacks to the dialog APIs to turn them into asynchronous mode.


Hang during Connecting.await for incoming connections

Running my previous test case further surfaces two more issues:

ConnectionError::Reset on line 82. This seems possibly a bug but like the ApplicationClosed error in my previous example it doesn't block progress so is ignored;
Hanging in Connecting.await on line 103. strace shows packets are being sent and received, but this .await never returns.

I used the following to simulate an unreliable network on Linux:
tc qdisc add dev lo root netem delay 5ms 10ms 25% distribution normal loss 5% duplicate 5% reorder 40% 50%

Note this seems to be buggy on kernels < 4.18.

ConnectionError::Reset on line 82. This seems possibly a bug but like the ApplicationClosed error in my previous example it doesn't block progress so is ignored

This is expected behavior if the receiver's CONNECTION_CLOSE frames are all lost and its close timeout expires, at which point the connection's state is discarded on the receiver. On the sender's next retransmit, the receiver will be unable to associate the incoming packet with a connection, and will respond by resetting the connection. If this happens rarely and only when simulating packet loss, this is probably working as intended.

Hanging in Connecting.await on line 103. strace shows packets are being sent and received, but this .await never returns.

This sounds like a bug. If you add tracing-subscriber = "0.2.2" to your dependencies, call tracing_subscriber::fmt::init, and set RUST_LOG=quinn=trace in your environment, you'll get diagnostics that will describe the packets being sent/received, which may give us some useful insight into the failure to make progress.

I've just re-run it with some of quinn's anti-amplification logic (which shows up in the above trace) disabled.  I'm going to try to get us updated to draft 27 and then revisit.

The draft 27 update has been merged.

I'm still seeing the same hang on current master. From running the test case a few times I believe it is less frequent, though I could be wrong and I'll test more tomorrow. I'm also seeing #670.

Thanks for checking. I haven't been able to reproduce either case using the current reduced-hang branch, having ran up to 100k iterations; updated traces could be helpful.

Reviewing the above traces, it looks like the server is functioning normally on the -proto level (i.e. it deems the connection established and processes the client's stream frames), so there must be something wrong with the pathway that wakes up Connecting.

In the second-to-last trace above, I believe id=4 represents the server's side of the connection in question. The line
Mar 01 19:15:17.654 TRACE drive{id=4}:recv{space=Handshake pn=0}: quinn_proto::connection: established

indicates that control has reached a point which must pass through self.events.push_back(Event::Connected);. That queue is drained in Connection::forward_app_events, which is always called after process_conn_events, in which packets are handled and the event is generated. forward_app_events always signals self.on_connected when it encounters a Connected event. That's the oneshot that Connecting is waiting on.
I'm having trouble seeing how that chain could malfunction. Do I recall correctly you mentioning you suspected a tokio issue previously?

@alecmocatta would be cool if you can investigate some more with current master (which includes some fixes). Please also make sure to run the latest tokio, and then maybe add some debugging based on @Ralith's pointers above? Let me know if you have more questions.

The issue that I suspected was related to tokio I saw only when spawning onto a multi-threaded runtime, and it involved two threads busy-looping. I don't think it's likely to be triggering this as well but it's not impossible.
Under my setup - a 1-core linux 4.18 VM running under VirtualBox, after having run the above netem command to simulate an unreliable network - I get about 20 iterations per second, and ~99% of the time I see either the hang or #670 within a minute. Adding RUST_LOG=quinn=trace seems to make the hang less likely to occur, and extends that time to ~3 minutes. I've added my Cargo.lock to the branch, and an updated trace of the original hang here, and the #670 error here.

Ah, but that repository is still using the sync-defragmented branch? Should try with master.

@djc Check out the reduced-hang branch.

Thanks for verifying! I forgot about the netem stuff, will investigate further today. Given the above investigation, I'm sure I can at least find an assumption getting invalidated somewhere, assuming I was looking at the right ID.

With netem I'm able to reproduce both issues very consistently--always in the first iteration, in fact. Thanks!

I'm pretty sure I see what's happening with the hang:

The client's first packet is being duplicated over a significant time period (about 22ms in one example). The first packet creates a connection which goes through the full life cycle and is ultimately closed and forgotten.
The duplicate arrives. The server has no way to distinguish it from a genuine fresh connection attempt, so it proceeds with the full handshake procedure, including yielding a new Connecting future to the application.
The client endpoint no longer has state for this connection, so it rejects the server's handshake packets with a stateless reset.
The server doesn't have a current reset token from the client, so it cannot recognize the stateless resets, and responds with its own stateless resets. This cycle continues until the stateless reset size drops below the critical threshold and no longer prompts a response.
Having received no acknowledgement, the server retransmits the handshake messages. This restarts the above cycle.
The server's retransmits add up until they're halted by anti-amplification.

At this point the server cannot take any further action on the connection initiated by the duplicated packet. Because you've disabled the idle timeout, the connection is permanently hung. This is working as intended.
In summary, the idle timeout must not be disabled in environments where a client might disappear unexpectedly or packets may be duplicated and no other mechanism exists to clean up zombie connections. I'll prepare a PR to update the documentation to clarify this.

Thanks for that comprehensive explanation @Ralith!


_similar() methods do not check for single instances found

_similar() methods do not verify that there is multiple instances found.

Upon further review, pan-os-python is behaving properly, there is no update needed.
Closing this issue.


Warning - 12200  Schema validation warning

I am not able to get the response as SMS. The Twilio Debugger shows:

It seems like the Body is enclosed in double quotes. See step #11 and #12 under the API Gateway section of the blogpost: https://aws.amazon.com/blogs/ai/integrate-your-amazon-lex-bot-with-any-messaging-service/


merge from template-arlac77-github

package.json

chore(deps): add ^6.12.93 remove ^6.12.92 (devDependencies.npm-pkgbuild)

:tada: This PR is included in version 1.10.31 :tada:
The release is available on:

v1.10.31
GitHub release
npm package (@latest dist-tag)

Your semantic-release bot :package::rocket:


fix(bug): Propagate MaxMsgSizeSetting to roxctl client

Description
The roxctl export API for images was failing and getting retried. This would occur after an image sent was 4MB, so we need to propagate the max message size to the roxctl clients as well.
Checklist

[ ] Investigated and inspected CI test results
[ ] Unit test and regression tests added
[ ] Evaluated and added CHANGELOG entry if required
[ ] Determined and documented upgrade steps
[ ] Documented user facing changes (create PR based on openshift/openshift-docs and merge into rhacs-docs)

If any of these don't apply, please comment below.
Testing Performed
Here I tell how I validated my change
Ran this against the scale test and context cancels stopped and had a reproduction locally
Reminder for reviewers
In addition to reviewing code here, reviewers must also review testing and request further testing in case the
performed one does not seem sufficient. As a reviewer, you must not approve the change until you understand the
performed testing and you are satisfied with it.

@connorgorman I have a related proposal for sensor on #9926. Rather than having to set the same environment variable everywhere (which causes confusion) my proposal is that Central has a new gRPC preferences API. This API would communicate the maximum value to clients, who would then use this value to configure their gRPC connections.


Update temporal null section

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3bf55fc) 99.89% compared to head (a5531c0) 99.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #110   +/-   ##
=======================================
  Coverage   99.89%   99.89%
=======================================
  Files          46       46
  Lines         940      940
  Branches       93       93
=======================================
  Hits          939      939
  Partials        1        1

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Namespace of attributes and relationship

It seems implied from rules of forming references (e.g., articles.author and articles.title), but it is not  stated anywhere explicitly.

I would like to request to consider this for 1.0.

I'm +1 on this!
I might change the wording a bit, but this does seem like a good thing to state.

:+1:

Good to be explicit about this - thanks @hhware :shipit:


[Scala 3] Macro.anns throws IllegalAccessError when used on parameters with Java types on JDK17+

Hi there 👋
There seems to be an issue when using Macro.anns on case class parameters that are Java types on JDK17+ (works fine on JDK11). I created a small reproduction via scatsie here.
The fix to the issue is quite straightforward, and it's to add the following condition to the filterAnnotation method: a.tpe.typeSymbol.owner.fullName != "jdk.internal". Please let me know if you'd like me to create a PR for it and I'll do so
Please note that AFAICT, Macro.paramAnns works as intended, although I thought to let you know since the fix is relatively simple and there might be edge cases where a user will want to extract the param annotations manually as in the repro above

Yes, please do create a PR :)


win32->master merge

merging win32 into master so that all my branches can branch off of master

merging win32 and master so that all the branches can come off of master


login form doesn't recognise password array key

Hi Dave I've gotten stuck and I don't know how to overcome this after trying for some time now.
The form is sending data to my user table with the signup being successful the issue is the login form doesn't work due to the password array key not being identified.
Warning: Undefined array key "password" in C:\xampp\htdocs\login-form\login.php on line 17
16           if ($user) {
17               if (password_verify($_POST["password"], $user["password_hash"])) {
18                  die("Login Successful");
19              }
20          }
the repository is below.
https://github.com/Tashfinz/signup

Your password input is missing the name attribute, which is what is used to identify it in the $_POST array. So instead of this:
<input type="password">
it should be this:
<input type="password" name="password">

Thank you very much. I tried commenting on YouTube...however my comment wouldn't post for some reason?


[bugfix] Segment download URI is invalid after same CRC refresh using tar push

This is a corner case:

push a segment using metadata push: so the download url is remote;
push the same segment using tar push: since the crc is the same, the push only update download uri, but not copied the segment to final location.

Fix the issue by copying the segment to final location when download uri got changed.
This is detected during testng 7.8 ugprade, https://github.com/apache/pinot/pull/11462
Interestingly, this issue is not triggered often in current code.

Codecov Report

Merging #11720 (57d9155) into master (ae16812) will decrease coverage by 48.69%.
The diff coverage is 0.00%.

@@              Coverage Diff              @@
##             master   #11720       +/-   ##
=============================================
- Coverage     63.11%   14.42%   -48.69%
+ Complexity     1117      201      -916
=============================================
  Files          2342     2342
  Lines        125802   125802
  Branches      19336    19337        +1
=============================================
- Hits          79395    18149    -61246
- Misses        40745   106118    +65373
+ Partials       5662     1535     -4127

Flag
Coverage Δ

integration
?

integration1
?

integration2
?

java-11
14.42% <0.00%> (-48.64%)
:arrow_down:

java-17
?

java-20
?

temurin
14.42% <0.00%> (-48.69%)
:arrow_down:

unittests
14.42% <0.00%> (-48.68%)
:arrow_down:

unittests1
?

unittests2
14.42% <0.00%> (-0.06%)
:arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files
Coverage Δ

...apache/pinot/controller/api/upload/ZKOperator.java
61.74% <0.00%> (-0.69%)
:arrow_down:

... and 1519 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xiangfu0 : I had recently fixed the same issue: https://github.com/apache/pinot/pull/11536
Are you still seeing it after that PR?

@xiangfu0 : I had recently fixed a related issue: #11536
I guess you are targeting only that scenario where copy to final segment location is enabled?

yes, the fix #11536 triggered this issue, when the upload sequence is first metadata push then tar push.
The download url is updated, but segment is not stored in controller.


Add nosniff header and other improvments related to installation

…OWSER_XSS_FILTER in some files

add header "X-Content-Type-Options: nosniff" with DD_SECURE_CONTENT_TYPE_NOSNIFF
fix value of SECURE_BROWSER_XSS_FILTER : in some files it was "on" but should be "True" to be activated (sets header "X-XSS-Protection: 1; mode=block")

to test with docker, edit the docker-compose.yml (or an ovverride) for the uwsgi container, section environment) :
      DD_SECURE_BROWSER_XSS_FILTER: 'True'
      DD_SECURE_CONTENT_TYPE_NOSNIFF: 'True'

I'v actually added the secure values as default.
by the way I noticed that most parameters appear in configuration files as on/off whereas django actually expects True/False!
see https://www.bedjango.com/blog/how-debug-django-useful-tips/
I've tried to fix everything; i can only guess that people have fixed it in their configuration files when they needed it but it's pretty error-prone
note that in python both "on" and "off" are truthies :)

I have just pushed another change on the configuration: the parameters DD_SECRET_KEY and DD_CREDENTIAL_AES_256_KEY were hardcoded in the Dockerfile which means that they were fixed after image building (and not configurable at all other than changing the dockerfile)
I have moved them to the docker-compose.yml so that users can configure them upon startup.
It is advised to set them and keep them secret (not keeping the ones from github then)
more info:

SECRET_KEY
https://docs.djangoproject.com/en/2.2/ref/settings/

The secret key is used for:
All sessions if you are using any other session backend than django.contrib.sessions.backends.cache, or are using the default get_session_auth_hash().
All messages if you are using CookieStorage or FallbackStorage.
All PasswordResetView tokens.
Any usage of cryptographic signing, unless a different key is provided.

DD_CREDENTIAL_AES_256_KEY
DD_CREDENTIAL_AES_256_KEY seems to be more specific to defectDojo cf readthedoc:

DD_CREDENTIAL_AES_256_KEY
AES 256 key for encrypting sensitive data such as passwords in DefectDojo. Set to at least a 256-bit key and should be set to a unique, unpredictable value.

in both case they should be in the docker-compose so that we can generate them and put them in the environment when starting the application

@mtesauro would you review this please?

@madchap variables in .env file will be picked up and used in the yml.
this article explains the various ways to configure a docker-compose.yml:
https://vsupalov.com/docker-arg-env-variable-guide/#the-dot-env-file-env


Store auth token in a cookie

Description:
Store auth token in a cookie.
We implemented the login in https://github.com/yorkie-team/yorkie-house/pull/31 but we store the auth token in localStorage.
Since localStorage can be referenced by JavaScript, storing the token in a cookie is recommended.
Let's store the auth token in a cookie.
Why:

LocalStorage/SessionStorage is vulnerable to XXS attacks.

There are additional considerations in this issue.
The current Dashboard network structure is as follows.
(ref: https://github.com/yorkie-team/dashboard#how-dashboard-works)

The auth token is transmitted as a cookie from the gRPC server. At this point, set the httpOnly and secure options.
The gRPC-web client checks that the cookie is transmitted correctly.
After checking that the cookie is set in the browser, Change the login status in the homepage header.


Integrate Faucet + ASK Token Interface on Televideo

7 million ASK tokens have been airdropped to wallet with recovery seed phrase:
pudding creek mercy elephant only turkey family review cattle soccer hospital inform

ASK tokens are in live production on Ethereum Mainnet with smart contract: 0xB48097b592e689fe113d2ac3633327e12Cc60734

Please claim some tokens (easiest through Trust Wallet):

Goals:
Gamification
Incentivization
AI Punishment/Reward
Televideo Value Tracking
Philanthropy Token
AI Credits
Physician Charity Token

Got it. We'll work on the integrations this week.

For the faucet, do we want to do an across the board drip of say 5 satoshi (player) and 10 satoshi (doctor) per minute? Or, should we make the drip rate variable based on the meeting difficulty (ex. regular check up is less stressful than potential covid diagnosis)?

Interesting question. If not too complex, we could try variable based on meeting difficulty.

We'll need a way to measure/determine the difficulty. What do you think of using the 1-10 Pain Scale as a difficulty setting in the doctor's control panel? Or, is there a better way of determining difficulty?

@raynman1 is the token also available on a testnet?


A small error in instructions given

The Building guidelines on the page state that use
git clone https://github.com/edx/edx-mobile-android
But actually link to the repo is https://github.com/edx/edx-app-android
So you should use
git clone https://github.com/edx/edx-app-android
Thanks,
Shrey

Thanks! This should now be fixed.


fix: prevent cocurrent running pipeline

Summary
Implement #3286 [Feature][framework] Prevent concurrent pipelines for a specific blueprint
We defined a new error type variable services.ErrBlueprintRunning.  When creating a new pipeline, the table _devlake_pipelines is checked first, if there is a running pipeline with the specified blueprint_id, the error services.ErrBlueprintRunning will be returned.
Does this close any open issues?
Closes #3286
Screenshots

Other Information
Any other information that is important to this PR.

LGTM


[FEATURE]add debug mode to the harvester

Is your feature request related to a problem? Please describe.

currently, the debug mode configuration is missing in the harvester.
Describe the solution you'd like

add debug mode to the harvester config
Describe alternatives you've considered

N/A
Additional context

N/A

user is able to enable and view the debug logs via set env HARVESTER_DEBUG: true.
user is able to view golang profiling with http://server_url:6060/debug/pprof/

user is able to enable and view the debug logs via set env HARVESTER_DEBUG: true.
user is able to view golang profiling with http://server_url:6060/debug/pprof/

Validated case 1 on master-head, added the variable HARVESTER_DEBUG: true to the harvester, the debug log is available

Validated case 1 on master-head, added the variable HARVESTER_DEBUG: true to the harvester, the debug log is available

Validation steps:
After the harvester pod is running, users can either run kubectl port-forwad $harvester_pod 9060:6060 and access via localhost:9060 to check it or manually expose port 6060 via a service.

Validated on master-head


Pass custom kubectl binary

Description of the problem / feature request:
Pass custom kubectl binary to k8s_deploy commands.
Feature requests: what underlying problem are you trying to solve with this feature?
We use k3s in Docker for development, and up until now we wrapped kubectl with docker run k3s kubectl, since the k3s image ships in the container.
What operating system are you running Bazel on?
macOS
What's the output of bazel info release?
release 3.4.1

I'm thinking of adding a kubectl option to k8s_deploy, but I saw a bunch of stuff related to custom kubectl binaries so I'm not sure.

In rules_gitops we assume that host kubectl is available and has appropriate configuration to access the cluster. It is the same assumption made by Bazel rules_k8s.
Is docker run k3s kubectl a literally the command you want to run instead of host kubectl or it is just a way of saying "run some other command"?
Does the Bazel downloaded kubectl binary is an acceptable solution?

In rules_k8s, it is possible to override the kubectl binary https://github.com/bazelbuild/rules_k8s/tree/master/toolchains/kubectl#download-a-custom-kubectl-binary:
load("@io_bazel_rules_k8s//toolchains/kubectl:kubectl_configure.bzl", "kubectl_configure")

kubectl_configure(
    name = "k8s_config",
    kubectl_path = "@myrepo//my:kubectl",
)

This has the advantage for easy swapping of the kubectl binary, either by downloading or wrapping (as we do).
Actually, I was wrong, it's not run but exec: we run kubectl in the same container as the k3s node.
Here is our wrapper:
#!/bin/bash
set -eu
use_tty=""
if tty -s; then
    use_tty="-t"
fi

docker exec -i ${use_tty} k3s kubectl "${@}"

The added advantage over a downloaded kubectl binary is that kubectl is always compatible with the k3s node.
That said, it is of course incompatible with deploying on a remote node.
Finally, we used to extract of the kubeconfig.yaml from the container, but the only way was to inject the container id as stamp, so that the genrule would get re-run when the container restarts.


Responsive for Mobile screen.

Description
Fixes #45
Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have performed a self-review of my own code
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

Screenshots

Hi @Rishav1707 Thank you for making the PR. But, issue #45 was related to just the pagination component, and the PR doesn't make any change to that.

Also in issue #45 it mention about responsive for mobile screen.
I am only worked on responsiveness in mobile screen that's why I requested this PR.

Hi @Rishav1707 Thank you for making the PR. But, issue #45 was related to just the pagination component, and the PR doesn't make any change to that.

Also in issue #45 it mention about responsive for mobile screen. I am only worked on responsiveness in mobile screen that's why I requested this PR.

That responsiveness was also related to pagination component actually.

Hi @Rishav1707 Thank you for making the PR. But, issue #45 was related to just the pagination component, and the PR doesn't make any change to that.

Also in issue #45 it mention about responsive for mobile screen. I am only worked on responsiveness in mobile screen that's why I requested this PR.

That responsiveness was also related to pagination component actually.

Ok I will try to solve it...

Hi @Rishav1707 Thank you for making the PR. But, issue #45 was related to just the pagination component, and the PR doesn't make any change to that.

Also in issue #45 it mention about responsive for mobile screen. I am only worked on responsiveness in mobile screen that's why I requested this PR.

That responsiveness was also related to pagination component actually.

Done @ashutoshkrris

Did you delete the OpportunityList.vue file?

Did you delete the OpportunityList.vue file?

Yes, because I only want to commit style.css file

Did you delete the OpportunityList.vue file?

Sorry, by mistake it was deleted.
But I recovered it...

@ashutoshkrris Please review my changes...

@ashutoshkrris Please review my changes...

?? @ashutoshkrris

Hi @Rishav1707 The mobile version still doesn't look as expected.

I think you have deployed the wrong link...

See above it's quite better now for mobile screen

Hi @Rishav1707 The mobile version still doesn't look as expected.

I think you have deployed the wrong link...  See above it's quite better now for mobile screen

Could you try going to page number 4?

Hi @Rishav1707 The mobile version still doesn't look as expected.

I think you have deployed the wrong link...  See above it's quite better now for mobile screen

Could you try going to page number 4?

Yaah now I see changes

Ok trying to fix this soon...

How's this?

Hi @Rishav1707
Since I changed the way pagination was working, there's no need to make any changes now in terms of responsiveness


feat: add BluetoothAdvertisementStream

The goal is to move the remote advertisement stream handler
out of the HA codebase

this ended up being more complex so will need to rethink this


Add telnet template crud and alarms functions

addresses issue Feature request alarm API #20 as well as telnet CRUD operations. Requires IMC 7.3 to support

LGTM


Autocomplete for Alias stop working inside {}

Describe the bug
Autocomplete for alias types doesn't work when wrap around table brackets '{}'
To Reproduce
1 - Create an alias type
2 - Try to autocomplete inside {}
Expected behavior
I believe that the alias should autocomplete even inside brackets
Screenshots
If applicable, add screenshots to help explain your problem.

Environment:

OS:  Windows
Is WSL remote? No
Client: VSCode

Additional context
It would be great to fix this issue because working on creating documentation for BMD's Fusion Fuses lua api and this type of style of table declaration is part of the course. 😭😭

local tmp is not {tmp}, I think what you want is:
---@class A
---@field a '"hello"'|'"world"'

---@param t A
local function api(t)
end

api({
    a = -- privide 'hello' and 'world' here
})

Yeah that works. Thanks.

It would be nice if "hello" and "world" would autocomplete as well. Can you provide some guidance in how to achieve this?

Also autocomplete doesn't work with globals.
---@class A
---@field a '"hello"'|'"world"'
---@param t A
function api(t) end
api({
--intellisense doesn't display the fields
})

I'm sorry I forgot to reply to you, this feature is already in my plan.
You could find code around script\core\completion.lua:1293.


Refactor Quint class

The Quint class currently contains all of the translation-related code, including
def/expr translation, type translation, and unique name generation.
Some of this functionality is contained in nested classes + companion objects, both on the Quint class and the Quint companion object.
With recent issues, it has become hard to debug where these classes / objects are instantiated, what (parent) state they access, and where that is instantiated.
This refactoring PR splits off unique name generation and type conversion into separate classes / files. It also replaces implicit class instantiation in apply with explicit constructor calls via new, and renames / moves some methods to arrive at a more uniform interface.
The refactor is all mechanical; the only remarkable commit is f1a38d5afc5d00cdd8667ab536f45de40ddd3568, which constructs one translator per module (rather than per definition).
I think its easiest to review the entire code at once, by checking out the branch and diffing sans-whitespace with git diff -w main.

Codecov Report

Merging #2628 (f2bdaa2) into main (c2dcffc) will decrease coverage by 0.02%.
The diff coverage is 88.41%.

@@            Coverage Diff             @@
##             main    #2628      +/-   ##
==========================================
- Coverage   78.50%   78.49%   -0.02%
==========================================
  Files         445      447       +2
  Lines       15658    15654       -4
  Branches     2589     2553      -36
==========================================
- Hits        12293    12288       -5
- Misses       3365     3366       +1

Impacted Files
Coverage Δ

...e/apalache/tla/passes/imp/SanyParserPassImpl.scala
50.00% <0.00%> (-2.95%)
:arrow_down:

...n/scala/at/forsyte/apalache/io/quint/QuintIR.scala
81.03% <ø> (ø)

...ain/scala/at/forsyte/apalache/io/quint/Quint.scala
85.17% <87.84%> (-1.14%)
:arrow_down:

...forsyte/apalache/io/quint/QuintTypeConverter.scala
97.36% <97.36%> (ø)

...la/at/forsyte/apalache/io/quint/QuintNameGen.scala
100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more


Under what conditions can RtmpClient.read() return 0 bytes?

Most Java APIs for reading data (e.g. InputStream and all subclasses) are blocking, meaning they either (a) read at least one byte, (b) fail by throwing an exception, (c) return -1 to indicate the end of the data has been reached.
It's undocumented whether RtmpClient.read() can return 0 or not, meaning that no bytes have been read. It appears that it can, from experimentation. Please could:

The behaviour of read() be clearly documented. It's unclear whether returning 0 is allowed just by looking at the documentation.
Ideally read() would have behaviour like InputStream. If it is allowed to return 0 then a caller may end up needing to implement a while loop that basically polls (and consumes CPU) until data can be read. Which is far from ideal.

read function is documented.

It would be more standard to return -1 instead of 0 for the end-of-stream case, since that matches what Java's InputStream class does. Whether you want to change it I guess depends on how you feel about changing the API, although given you're already making some API changes for the next release, it would be a good time to make this change also if you ever intend to do so :).

hi @ojw28, please check this commit https://github.com/ant-media/LibRtmp-Client-for-Android/commit/5371bf782a4a909cfa3514886ee978a1cb5ff7b5


Allow for a pending condition as a step in a workload

For workloads which have condition-based phases, these should be auto-detected by tooling.
In order for this to work with existing machinery, a couple pieces need to work together:

HTTP adapter needs to allow (actually implement) variable capture in thread-local context

use direct member access in general
consider https://github.com/json-path/JsonPath for some cases

A condition check (expression evaluation) needs to be allowed in a evaluator based on this variable.
Evaluator outcomes need to be itemized around verbs:

throw verifier error (if result type is boolean, implied by false)
indicate verifier success (if result type is boolean, implied by true)
restart sequence
restart operation
others as needed in the future

To make this robust:

The outcomes of a verifier should be itemized in an enum including the above meanings
If possible, when a verifier code block is compiled, it should be asserted that the result is either boolean, of the enum type, or void. Any other type should throw an error.

With these in place, a blocking condition might look like:
# This version uses the capture capability
ops:
 op1:
  driver: http
  url: "https://....."
  capture:
      var1: pending.result
  verifier:
      if (var1>0) {
         // delay or ensure rate limiter is going at a reasonable polling speed
         return RESTART_CYCLE
      }
      else return CONTINUE

# This version acts on the result directly
ops:
 op1:
  driver: http
  url: "https://....."
  verifier:
      if (result.pending.varname && result.pending.varname >0) {
         // delay or ensure rate limiter is going at a reasonable polling speed
         return RESTART_CYCLE
      }
      else return CONTINUE

This may need to be re-thought according to nb 5.21+ internal APIs, but the scenario is still a valuable one to streamline tests.


The unit of measurement

Hi,
Iam trying to configure daily sensor on HA.
The entity is ok, i use one of the netatmo sensor
my doubt is the unit of measurement - what i add here?
refresh interval i add 5 min

I choose "C" but i cannot get any value on the max temperature

weird, I am using very similar configuration:
"interval": 1,
"name": "Maximum Temperature",
"operation": "max",
"sensor": "sensor.smartweather_temperature",
"unit_of_measurement": "F"

you should be able to just enter whatever you want for unit_of_measurement.
Are you sure the input sensor you use is of the right data type? any errors in the log?

Iam using the input sensor of netatmo that stopped working, temperature maximum and minimum:
And if i use those sensors it will continue not working. So, how can i fix this?
Correct, it works if i use the sensors that are working, fact

I am not sure if I understand what you mean.


introduce mail_on_failure class to setup helpers

The helpers allow mail notifications on failing units.

@bastelfreak & @raphink anything left to be done? The failures are totally unrelated to what I changed...

@bastelfreak & @raphink anything left to be done? The failures are totally unrelated to what I changed...

@ekohl / @bastelfreak ping

I've no merge powers here anymore :(

This seems reasonable and I'm happy to help move it along but I wanted to ask if anyone wanted to move the script out of files and into a template so that it works more easily with Bolt + PE.

Oh, you may also want to rename the systemd services to something prefaced with puppet or the like since users may already have something with this name in systemd.

@duritong can you address @trevor-vaughan's latest comments please? Then I'll merge.

Yes, I can give it a shot


[Kotlin nostr] Include proguard rules

Describe the enhancement

Include proguard rules that will allow users to build their Android app in release mode with minify enabled.
Use case

As an Android dev you usually set isMinifyEnabled = true in your build options to reduce the apk size but doing so will break the app. Some classes should be excluded from the minify process or rust-nostr will not work. It would be nice if the lib would work from the get-go without having to figure out proguard rules.
Additional context

I don't know if this is the best solution but it works for me and it's what I'm currently using:
-keep class com.sun.jna.** { *; }
-keep class * implements com.sun.jna.** { *; }
-dontwarn java.awt.Component
-dontwarn java.awt.GraphicsEnvironment
-dontwarn java.awt.HeadlessException
-dontwarn java.awt.Window

Here the file: https://github.com/dluvian/voyage/blob/master/app/proguard-rules.pro

Those rules are already included here: https://github.com/rust-nostr/nostr/blob/master/bindings/nostr-sdk-ffi/bindings-android/lib/proguard-rules.pro
Not sure if I have to do something else. Are also included in the buildTypes.release: https://github.com/rust-nostr/nostr/blob/master/bindings/nostr-sdk-ffi/bindings-android/lib/build.gradle.kts#L30

Yeah, I have no idea how to set this up correctly...


SkipNetwork and SkipToLoadSave not working

Set the above settings to true in the .ini file but they have no effect on boot up.

Can you post your log file (P3RFix.log) please?

I figured out that I was editing the .ini file under


Parser implementation for Unassign

Child task of #72
This issue only implements the parser and the relevant parser tests without the execute logic

Closed by #99


Refactor API design of lib

The API of the lib should be refactored when it's scope is clear.

Will be fixed in #30


Fix telemetry docs for 0.5.1 Prometheus

0.5.1 config for Prometheus is missing the namespace #3139
Added in instructions to modify prometheus.yaml file.
I'll revert this change once 0.6.0 is out

so this should go in the release-0.5 branch then?
cc @geeknoid

@geeknoid   Is this ok to merge in or if  0.6.0 is coming out next week, i can abandon this PR. LMK

I think might as well abandon at this point. 0.6 is actually done at this point, we're just waiting for the release notes to be finished before sending out the announcement.

SGTM.  i'll review the GKE install istio docs next week and see if there is a way to provide a self-contained 'copy-paste' command set like this


dclexperience: places and events on board do not get highlighted as they do in regular explorer when selecting them

Explorer Alpha build version:
(Version 0.3.335-g8f637032-main
(windows))
Issue Description:
Places and events on boards in DCL EXP do not get highlighted as they do in regular explorer when selecting them.
As such, the 'SELECT' functionality which appears when hovering over the mouse seems not to work.
Notice the difference:
Alpha:
https://github.com/decentraland/unity-explorer/assets/146749313/56e0949d-d839-4e05-b5e2-b94ac100ebf1
Regular explorer:
https://github.com/decentraland/unity-explorer/assets/146749313/c5465471-3662-4c1e-9b5f-bab6889103a3
Steps to reproduce:

Go to DCL EXP in alpha
Go to any of the three events boards
Select 1 place or event

Expected behaviour:
As per regular explorer, event or place should be highlighted when selecting it
Current behaviour:
Event or places isn't highlighted when selecting it
Reproduction rate:

[ ] < 10%
[ ]  < = 25%
[ ]  50%
[ ]  < = 75%
[X ]  100%

Severity:

[ ] Cosmetic
[ ] Minor
[ X] Medium
[ ] High
[ ] Critical
[ ] Blocker

Priority:

[ ] High
[X ] Medium
[ ] Low

Platforms / OS:

[X ] Windows 11
[ ] Windows 10
[ ] Mac Sonoma
[ ] Mac (specify the version on Additional Notes)

Still happening on latest build 0.3.402-g7a23dc7e-main


Tearsheet

Tearsheet component
Dev maintainer: Dave Clark (@dcwarwick)
Brief description
The Tearsheet component facilitates rich modal interactions such as resource creations that require multiple steps. It is akin to a dialog that is anchored to the bottom of the viewport. They come in 2 sizes, narrow and wide, each with specific layouts. They can be stacked, facilitating nested interactions.

Details
Link to INTERIM Design
Links to other materials
The Tearsheet is a pre-req for issue #52.
Design Maintainer(s)

Owner/main maintainer(s): Mitchell Bernstein
Second/backup maintainer(s)

Tasks

[x] Initial review of design/existing code

Working in experimental package

[ ] Create a shell component which

[x] Create ComponentName/ComponentName.js component file that renders props
in raw form (no styling or sub components, plain text OK)
[x] Adds prop-types with comments for DocGen to
ComponentName/ComponentName.js
[x] Add Doc file e.g. ComponentName.mdx with a brief description of the
component.

[ ] First engineering review/playback

Continuing in experimental package

[ ] Storybook - stories to cover design scenarios, story with long, min and
max content, story to demonstrate right-to-left support, etc.
[x] Doc tab in storybook derived from design docs with embedded stories where
appropriate
[x] Code to include prop-types with comments for automated DocGen
documentation
[ ] Tests (written in React Test Library) to cover behavior from the
documented in the components mdx file.

Review and promote

[ ] Design review
[ ] Add design review issues addressed, issues raised or discounted.
[ ] Engineering review - Submit PR to promote component to production package
[ ] All engineering issues addressed, issues raised or discounted.

Pattern guidance for tearsheet published: https://pages.github.ibm.com/cdai-design/pal/components/tearsheet/usage

@lee-chase  CPD (on-prem) is scoping priorities for 4.0 release. Several experience are looking to utilize the tearsheet component. Do you have a ball park time-line for when it will be completed?

@lee-chase CPD (on-prem) is scoping priorities for 4.0 release. Several experience are looking to utilize the tearsheet component. Do you have a ball park time-line for when it will be completed?

The tearsheet is currently under active development. Almost all of the functionality is already available in the version in the experimental package. There is work to do on keyboard enabling, docs, and automated tests, prior to it being ready for design and engineering review. I hope it will be ready for those reviews in a couple of weeks, then it depends on the outcome as to how soon it can be promoted to production.

Review for release
Readiness

[ ] One or more scenarios for a design pattern have been identified as a useful unit of functionality to publish.
[ ] A functioning component or components delivering those scenarios have been delivered and merged to master.
[ ] Design maintainer has approved the implementation for those scenarios (via a comment on the relevant issue/epic).

Engineering review

[ ] Breaking changes have only been introduced with prior approval, discussion and documented in release notes. Ideally deprecation notices in the prior major version must have been added in a timely fashion.
[ ] The implementation takes into account, and does not impair, remaining and anticipated design scenarios.
[ ] Public component features (names, props, etc) are consistent with Carbon-defined conventions and are consistent internally. Where there isn't an existing convention to apply, ensure robust precedents are being established.
[ ] The UI produced is accessible, responsive, translatable, cross-browser, and responds to the currently set Carbon theme.
[ ] Components are functional components using hooks.
[ ] Public components which produce DOM structures support className.
[ ] Public components support a ref (via React.forwardRef).
[ ] All significant DOM elements have meaningful classes.
[ ] Additional attributes that are not identified as props (such as title, aria-*, etc) are passed through to an appropriate DOM node of the component as HTML attributes.
[ ] No warnings, errors or log messages in the console.

Standards

[ ] No linter warnings or errors are produced.
[ ] Carbon tokens (theme, layout, motion) are used unless the design specifies otherwise.
[ ] Code is formatted according to prettier rules (no use of //prettier-ignore).
[ ] Code is clear, maintainable and follows standard React practices and the code guidelines.
[ ] Copyright header in every source file (js, css, scss etc.) with the appropriate years.

Testing

[ ] There is a set of test cases for the components.
[ ] The tests exercise all inputs (props, slots, etc) and verify appropriate outputs.
[ ] The tests validate the behaviors and interactions defined in the design where practical.
[ ] The tests achieve 100% coverage.
[ ] No warnings, errors or log messages in the test output.

Documentation

[ ] Source code is satisfactorily commented and provides DocGen comments for all public components and their props.
[ ] There is a story for each design scenario. The stories expose all relevant props and actions, and additional usage documentation and code samples are available on the 'Docs' tab along with the props table.
[ ] There is a sandbox (or multiple sandboxes if appropriate) on CodeSandbox for the components.


[Arith] Handle likely in IRMutatorWithAnalyzer

For if (likely(x)), x rather than likely(x) should be fed into the analyzer as a constraint.
This changes helps tir.transform.Simplify simplify
// attr [iter_var(threadIdx.x, , threadIdx.x)] thread_extent = 32
// attr [iter_var(threadIdx.y, , threadIdx.y)] thread_extent = 32
if (likely((((threadIdx.x*32) + threadIdx.y) < {n|n>=0}))) {
  if (likely((((threadIdx.x*32) + threadIdx.y) < {n|n>=0}))) {
    A[threadIdx.x] = C[((threadIdx.x*32) + threadIdx.y)]
  }
}

into
// attr [iter_var(threadIdx.x, , threadIdx.x)] thread_extent = 32
// attr [iter_var(threadIdx.y, , threadIdx.y)] thread_extent = 32
if (likely((((threadIdx.x*32) + threadIdx.y) < {n|n>=0}))) {
  A[threadIdx.x] = C[((threadIdx.x*32) + threadIdx.y)]
}

I added this case as a new test.
@tqchen

Please try to retrigger as the error was a flaky one

Thanks @roastduck !


Expand/Collapse not working on Firefox-esr-91.0.1 (WS)

In GitLab by @ggcr on Dec 5, 2022, 09:10
Hi,
Problem
First of all, sorry. I am not used to the WS and I didn't test the app within the Workstation environment.
As far as I've seen this problem only occurs on the Firefox browser on WS and it is due to the version of node.js that it uses.
Some users already prompted this problem on the NextJS github which is a framework from Vercel, very much related to React.js:

Object.hasOwn is not supported on Firefox ESR out of box #36422

So we are basically using a very recent Javascript feature that is still not widely supported: Object.hasOwn(...)

Solution
One-line solution using a more supported feature, now using the Object.hasOwnProperty(...)
This is already working on Firefox-esr-91.0.1.

I will push and merge this with a new hot-fix branch @ jberlin
Can anyone specify the other browsers versions currently in the WS so that I can test it out?
FYI: @mcastril

In GitLab by @ggcr on Dec 5, 2022, 13:11
Sadly not that I know. The JS ecosystem is very diverse and we have a lot of different big collaborators such as Node.js, Vercel with Next.js, etc...
Should I merge this one-line hot-fix? as well as this Issue #55 ? it's also a one-line add of code and it should be worth. @ jberlin

In GitLab by @ jberlin on Dec 5, 2022, 15:13
mentioned in commit b243d2cfd2a49d71de211498af8fb46fd93c4c6e

In GitLab by @ jberlin on Dec 5, 2022, 14:03
Hi @ggcr , yes please go ahead and merge these hot fixes so I can put them in PROD, thanks

In GitLab by @ jberlin on Dec 5, 2022, 09:39
Hi @ggcr , perfect! I was thinking the same, does ReactJS offer primitives for handling these kinds of things?  since if we use the ReacJS functions I think we will not run into cross-browser compatibility issues.

In GitLab by @ggcr on Dec 5, 2022, 09:54
mentioned in commit 788c5e1a7ccf04dfd62c716b2fc2299ef79530ec


fix: LSDV-4757: Fix brush crashing

PR fulfills these requirements

[x] Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
[ ] Tests for the changes have been added/updated (for bug fixes/features)
[ ] Docs have been added/updated (for bug fixes/features)
[x] Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
[x] Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)
(check all that apply)

[ ] Product design
[x] Frontend

Describe the reason for change
LSDV-4757
What does this fix?
Fixes a case when Labeling UI crashes if Brush tool is defined earlier than an Image in the config
What is the new behavior?
Labeling UI doesn't crash anymore
What is the current behavior?
Labeling UI crashes completely
What libraries were added/updated?
None
Does this change affect performance?
No
Does this change affect security?
No
What alternative approaches were there?
None
What feature flags were used to cover this change?
None
Does this PR introduce a breaking change?

[ ] Yes, and covered entirely by feature flag(s)
[ ] Yes, and covered partially by feature flag(s)
[x] No
[ ] Not sure (briefly explain the situation below)

What level of testing was included in the change?
(check all that apply)

[ ] e2e
[ ] integration
[ ] unit

Which logical domain(s) does this change affect?
Labeling UI, Image Segmentation, Brush Segmentation

Codecov Report
Patch coverage: 100.00% and project coverage change: -0.08 :warning:

Comparison is base (d847f70) 65.51% compared to head (0a050d0) 65.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1248      +/-   ##
==========================================
- Coverage   65.51%   65.44%   -0.08%
==========================================
  Files         402      402
  Lines       25215    25215
  Branches     6455     6455
==========================================
- Hits        16520    16501      -19
- Misses       8695     8714      +19

Impacted Files
Coverage Δ

src/tools/Brush.js
89.52% <100.00%> (ø)

src/tools/Erase.js
35.38% <100.00%> (ø)

src/tools/Zoom.js
82.75% <100.00%> (ø)

... and 3 files with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


singletap recognized as double-tap on really quick press time

When working on Windows 10, (Chrome) a very quick tap is recognized as a double-tap -- I used this example ( http://codepen.io/jtangelder/pen/pBuIw ) from https://github.com/hammerjs/hammer.js/issues/912.
Specifically, the event.tapCount is always double the actual tap count.  So a double-tap is registered as 4, a triple-tap as 6, and a single-tap as 2.

Do you resolve this problem? @abrin

I hacked around this problem by adding external logic to track what browser + OS and then divide / 2. So, not really.


Merge contribution guide

The contribution guide is finished. Read through it and accept if it looks good!

A missing .gitignore caused some build fails (should not fail due to not committing source files).
This will be included in main as of this PR.


can't work with Textarea?

like <textarea id="editor">adsf</textarea>
How to enable textarea?

Hi, Today it really not works with textarea, I do not know why, you really need it?

ping @xaero7

This plugin is built on top of Ace editor which uses a <div> element. That's the reason you need to put something like this in the submit event of your form
$('#myForm').submit(function(){
    var markdownContent = $('#myEditor').markdownEditor('content');
    $('#myTextarea').val(markdownContent);
});

@mageddo Yes, I need it.
For my APP, it automaticly generates the form(including the textarea), and fill the form's value.
inacho gives a solution, but I think bootstrap-markdown-editor could work both for div and textarea.

I think I can improve the plugin to work with a <textarea> instead of a <div> and also sync the editor with the <textarea> automatically.
I'll keep you updated.

Released version 2.0.0
It works with a <textarea> instead of <div> and the text is synced automatically in the <textarea>.


Clang-Format LoaderAndValidationLayers Source Code

Standardized the repo .clang-format files
Updated the repo using the single standard with the existing LLVM style
Changed to Google style and updated the repo

Also worked around a problem in core_validation that resulted in vk_validation_stats.py failing.  Added a TODO for a proper script fix.


Imporved UI of Blog and Registry

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 2 committers have signed the CLA.:white_check_mark: mohab-sameh:x: siamakYou have signed the CLA already but the status is still pending? Let us recheck it.


Add a section in WSL's documentation about how API objects and WSL interact

Migrated from https://bugs.webkit.org/show_bug.cgi?id=177089:
At 2017-09-18T17:47:05Z<EMAIL_ADDRESS>wrote:
Add a section in WSL's documentation about how API objects and WSL interact

At 2017-09-18T17:54:24Z<EMAIL_ADDRESS>wrote:
Created attachment 321109
Patch

At 2017-09-18T18:17:13Z<EMAIL_ADDRESS>wrote:
Created attachment 321114
Patch

At 2017-09-18T18:24:58Z<EMAIL_ADDRESS>wrote:
Comment on attachment 321114
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=321114&action=review

Tools/WebGPUShadingLanguageRI/WSL.md:402
+WSL is designed to be useful as both a graphics shading language and as a computation language. However, these two environments have
+slightly different semantics.
+
+When using WSL as a graphics shading language, there is a distinction between entry-points and non-entry-points. Entry points are
+top-level functions which have either the vertex or fragment keyword in front of their declaration. Entry points may not be forward
+declared. An entry point annotated with the vertex keyword may not be used as a fragment shader, and an entry point annotated with the
+fragment keyword may not be used as a vertex shader. No argument of an entry point may be a pointer. Entry points must not accept type arguments (also known as "generics").

For the rest of the document, I was ensuring that paragraphs were all on one text line without wrapping.
I know that's unusual, but it's intentional: the way that wordpress is configured on the webkit.org blog, newlines inside paragraphs will break the paragraph.
Can you format it the way the rest of the document does it, to make it easier to turn this into a webkit.org blog post if we want?

At 2017-09-18T20:42:01Z<EMAIL_ADDRESS>wrote:
Created attachment 321125
Patch

At 2017-09-27T19:24:51Z<EMAIL_ADDRESS>wrote:
rdar://problem/34693222

At 2017-09-18T21:04:14Z<EMAIL_ADDRESS>wrote:
Committed r222179: http://trac.webkit.org/changeset/222179


Disabling  mc_att_control, mc_pos_control and vtol_att_control in nuttx_px4fmu-v2_default.cmake is causing build to fail in FW v1.8.0

I am using FW v1.8.0 on Ubuntu 16.04. I do not want to build all the modules in nuttx_px4fmu-v2_default.cmake especially the controllers. Hence I am disabling mc_att_control, mc_pos_control and vtol_att_control. However upon doing this firmware build is failing with error in navigator.cpp

Feel free to send a PR to untangle these. Yes, we want modules to not interdependent but right now it is not something we will focus the core dev team on. Happy to accept pull requests or discussing specific changes.


Update shebang to use /usr/bin/env for better compatibility

This change updates the shebang line in the build script from #!/bin/bash to #!/usr/bin/env bash. Using #!/usr/bin/env bash ensures better compatibility across different environments. This is particularly useful in systems where bash might not be located in the /bin directory, like NixOS.

Got it.
thanks for your contribution!!


fixed typo in read the doc description

:warning: Please install the  to ensure uploads and comments are reliably processed by Codecov.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.69%. Comparing base (d79835a) to head (294d643).
Report is 59 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   85.69%   85.69%
=======================================
  Files          47       47
  Lines        1237     1237
=======================================
  Hits         1060     1060
  Misses        177      177

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Address problem downloading the cli image in the OPP policyset

The openshift CLI image sometimes can't be downloaded.  In one scenario
I recreated the issue and noticed one pod successfully downloaded the
image and another pod didn't.  Both pods were on the same node so I
deleted the pod that failed to download and when the pod restarted it
worked find.  My guess is there may be a permissions or timing issue
that caused the problem so I have re-ordered some resources to change
the timing.
Currently this is a guess so it may turn into some job configuration.
Signed-off-by: Gus Parvin<EMAIL_ADDRESS>

@gparvin I've tested this PR against deploying OPP on OCP 4.10.26 on AWS using m4.xlarge as my instance type and we did not hit the same image pull authentication issue as before. Prior to this PR this same deployment configuration led to that issue.
I'll be running additional deployments and will update again here once I have more data but so far so good.

Thanks for the feedback
/unhold


Fixed issue when PROXY_REFERER has a query string

I had an issue when the PROXY_REFERER variable had a query string already in the URL. This threw errors when generating a token (AGS 10.3.1) . I added some code to parse out the URL if a query string is present in the PROXY_REFERER variable.

Hi @cgishack, thanks for your PR! We are working on merging this PR. Can you provide a test case so that we could verify this? Thanks!

This problem cannot be reproduced anymore.  I think it's gotten fixed in one of the other pull requests over the last month.

Sorry I could not find the time to re-test or provide a test case. I was not able to find any spare time. I will test the latest code and see if it fixed the issue I was having.  Thanks.


Tracking issue for Issue 1

Issue 1 will be released with at most 10 articles end of January 2023. Here is the article list:

[x] Announcing Rust Magazine
[x] VecDeque::resize() optimization #7
[ ] MiniLSM: A Tutorial of Building Storage Engine in a Week using Rust #9
[ ] Interview with weihanglo #10
[ ] How I Contribute to Rust Compiler #16
[ ] Rust for Linux Brief Introduction #19
[ ] 2022 Review | The adoption of Rust in Business #22
[ ] 40x Faster! We rewrote our project with Rust #23
[ ] Added the hidden control flow #24

We'll release the first issue soon, please take a look at those articles whenever you get a chance. Much appreciation to our editors.  @LCrossman @dmosc @ZhangHanDong @macko76

Sg! All articles look great!
I'm going to work on one for the next issue.
Thanks for the summary.


Change database link so it can consume cf-mysql-release

This change allows a MySQL instance from cf-mysql-release to be consumed by the notifications release. It changes the link type to internal-database, which matches the link type provided by cf-mysql-release.

@oppegard This breaks the ability to consume the link from the proxy job from cf-mysql-release, which seems like a much more common practice. CC @joerodriguez

@davewalter Thanks for that info! We reverted and cut a new release.


[stable/ipfs] add configmap to ipfs

What this PR does / why we need it:
Allow the user to provide custom config
Special notes for your reviewer:
Some users might use custom config

/ok-to-test

/assign @yuvipanda

/assign @foxish

/ok-to-test

/ok-to-test
@YuviPanda Can you review this change?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

The pull request is still actual

@mattfarina @foxish
Could you please say what is next with my PR


add mcd_id and mcd_token to final request

This was failing due to forgetting to pass required auth info into bulkImporTagsFromCSV

@bheltzel plz

Ha!  I just made the same change after hitting the errors.


Tmp doc review

Description
Brief description of what this PR is about

If this change is a backward incompatible change, why must this change be made?
Interesting edge cases to note here

this didn't work how i wanted it to


Add partition filters Testing to all Formats

Important Read

Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request
Add tests for testing partition filter behavior
Brief change log

Add tests for partition filters work for all formats.
Basic filters for Iceberg & Delta while more advanced filters for Hudi

Verify this pull request
This change added tests and can be verified as follows:

I dug a bit more and commented at relevant places. Both iceberg and Delta uses hive partitioning by default and reflected that in DataLayoutStrategy.


Results

Thanks for sharing this interesting work. I would like to ask if there is more details on the architecture, please?

Hi, architecture can be found in base model repository (Florence-2-base)
https://huggingface.co/microsoft/Florence-2-base/blob/main/modeling_florence2.py


Removed 'field' check from diag_script

Removed 'field' check from diag_script ipcc_ar5/tsline.ncl, as there is no 'field' attribute anymore.

Will test soon, I'm busy with a another PR.


Cannot compile with musl (gentoo) [ Fatal error: execinfo.h: No such file or directory ]

Hi I am having trouble compiling this package on gentoo using the musl libc, and a lot of other people have been as well see here https://bugs.gentoo.org/716346. The error is Linux/XnLinuxDebug.cpp: fatal error: execinfo.h: No such file or directory.

This has been fixed with the updated ebuild


git.exc.InvalidGitRepositoryError when running train.py

Hello!  I followed the instruction of the training command, but it has thrown an error about GitRepositoryError.

I used command : CUDA_VISIBLE_DEVICES=0,1 OMP_NUM_THREADS=4 python -m torch.distributed.launch --master_port 1842 --nproc_per_node=2 train.py --id s2m --load_deeplab ./deeplab_resnet50/best_deeplabv3plus_resnet50_voc_os16.pth, and I have 2 GPUs.
Could you give me some suggestions?

Is the code in the valid git repository?

Thanks for your reply! I have solved this problem using git clone to download this repository.


Bubble chart doesn't work

test case

There still some bugs in Bubble chart.
Tooltip is not full.
Strange Undefined member in Legend.
See the example:
http://<IP_ADDRESS>/dsw/index.html#!/d/Test/BubbleChart.dashboard?ns=SAMPLESTEST#%2F%3Fns=SAMPLES

Add "V" switcher to show/hide captions of Row Elements inside Bubbles

doesn't work in 2.1.12


Multiple cells actions

Description
Select multiple cells and run cell actions altogether, such as moving up / hide etc.
Suggested solution
Add a checkbox or something between the Create cell above and Create cell below button

Alternative
No response
Additional context
No response

Great idea!
It would be nice to be able to drag and select multiple cells with your cursor. Once multiple cells were selected, then ...

clicking and dragging in the selection area would move the cells up/down
cell hotkeys like hide code, etc would be applied to each cell in the selection group

Hello, @akshayka can I pick this up?

Hi @Abhinavcode13 , yes, we would appreciate a contribution! Let us know if you need help getting started, have design questions, or anything else.


Add 1.22 for EKS v2 clusters

Detailed Description

Add 1.22 for EKS v2 clusters

Dashboard related issue: https://github.com/rancher/dashboard/issues/5716

A script that can be used to get the default AMIs with the aws CLI.
#!/bin/bash

_aws_regions="us-east-2 us-east-1 us-west-2 us-west-1 af-south-1 ap-east-1 ap-south-1 ap-northeast-1 ap-northeast-2 ap-northeast-3 ap-southeast-1 ap-southeast-2 ca-central-1 cn-north-1 cn-northwest-1 eu-central-1 eu-west-1 eu-west-2 eu-south-1 eu-west-3 eu-north-1 me-south-1 sa-east-1"

_ami_list=ami.txt

> $_ami_list

for _version in $@
  do
    echo "\"$_version\": {" >> $_ami_list
    for _region in $_aws_regions
      do
        _eks_ami=`aws ssm get-parameter --no-cli-pager --name /aws/service/eks/optimized-ami/$_version/amazon-linux-2/recommended/image_id --region $_region --query "Parameter.Value" --output text`
        echo "        \"$_region\": \"$_eks_ami\"," >> $_ami_list
        sleep 1
      done
    echo "}," >> $_ami_list
  done

AMIs from the script need to be updated in https://github.com/rancher/rancher/blob/release/v2.6/pkg/kontainer-engine/drivers/eks/eks_driver.go (not just for 1.22, but for previous versions - if there is a newer version of EKS-optimized AMI).

Root cause
EKS-optimized AMIs are not present in EKS v1 configuration for k8s 1.22. Also, AMIs are outdated for other versions 1.18-1.21 (though this is not critical).
What was fixed, or what changes have occurred
AMIs were updated by querying AWS with the script posted above.
Areas or cases that should be tested
Creation of EKS v1 clusters of k8s 1.22 (primarily) as well as previous versions.
What areas could experience regressions?
Potentially provisioning of any EKS v1 cluster based on region / k8s version combination, but chances of this are low since values were retrieved by script directly from AWS CLI.
Are the repro steps accurate/minimal?
No repro steps are specified on the issue, however UI to provision EKS v1 cluster can be invoked by navigating to /g/clusters/add/launch/amazoneks URL.

Ticket #37534 - Test Results
Verified on rancher v2.6-98da58b9c8fe544ed3068ad9fa8176ccdb947862-head:

Fresh install of rancher v2.6-head
Provision a downstream EKS cluster with k8s version v1.22
Provision a downstream EKS cluster with k8s version v1.21
Provision a downstream EKS cluster with k8s version v1.20
Provision a downstream EKS cluster with k8s version v1.19
Verified - All EKS clusters successfully provision;
Deploy a workload on EKS cluster with k8s version v1.22
Deploy a workload on EKS cluster with k8s version v1.21
Deploy a workload on EKS cluster with k8s version v1.20
Deploy a workload on EKS cluster with k8s version v1.19
Verified - All EKS clusters successfully deploy workload
Delete EKS cluster with k8s v1.22
Delete EKS cluster with k8s v1.21
Delete EKS cluster with k8s v1.20
Delete EKS cluster with k8s v1.19
Verified - All EKS clusters successfully deleted

Screenshot:


Provide easier ways of installing the client

It would be very cool if you could provide easier/more convenient ways of installing the sechub client binary.
Specifically, it would be very cool if you could provide a

Homebrew formula for macOS
winget manifest for Windows
Snap for Ubuntu/Linux (or maybe a Flatpak version) or if it makes more sense a .deb or .rpm package.

This would greatly increase the developer experience around the sechub cli.

Hi @Okeanos
Great idea!
We already thought about building packages:

It's a high effort to learn each packaging system and to maintain the packages
Usually, for each you will have to create and handle signing keys and get them approved
A big question for some formats is: Where we can host the package?
Basically, the package only contains the sechub binary - so there's almost no additional gain besides the convenient installation.

I just have created #2337. This is relatively easy to add to our release workflow. We will implement this in the future.
Besides that:
If you can contribute code for building one/more package formats locally, feel free to provide a PR with your solution.
See CONTRIBUTING.MD for details.
If you have knowledge on how to build and publish one of the above mentioned package formats:
We would be happy when you build and publish a SecHub client package. :-)
Please inform us and we will mention it in our documentation.

At least for brew and winget the only thing that would have to be maintained additionally are the manifests/formula files – they usually refer to the official release binaries that are attached to the GitHub releases.
Snap/deb/rpm etc. – yeah that's gonna be tricky but I didn't want to leave the Linux fraction unmentioned here.

@Okeanos as a FOSS project we welcome you to contribute a brew and/or winget package. As @sven-dmlr already pointed out.

The problem with brew: None of our developers has a macOS or experience with brew.
The problem with winget: None of our developers has experience with winget. In addition, what is the difference between winget and Chocolatey?

Please feel free to open a pull request for brew and winget.
Regarding Snap and Flatpak. What would be the benefit of supporting those? We already provide the sechub binary as a single executable binary. Soon, we will provide a public docker image in addition to that: #2337.
I understand the benefit of .deb and .rpm packages, but how would you suggest should they be distributed? In case of Debian/Ubuntu as PPA? What about .rpm?

The difference between Chocolatey and Winget is easy: Winget is provided & maintained by Microsoft and part of Windows 10 and beyond by default. It even comes pre-installed on enterprise Windows (to my knowledge) and requires very little in terms of setup to get to work (even on enterprise editions). Whereas Chocolatey (and scoop) is a third party offering of a package manager and definitely has problems in enterprise environments – in the end they do very similar things, though.
I'll see whether I do have time to create a Manifest/Formula for winget and brew respectively. No promises, though. Before I can do that there's some input from you desired, though. Especially for winget a rather complete manifest is likely in your own interest, specifically with official input in the data that will go in there. Please have a look at e.g. yq, Eclipse Temurin or jq manifest files and tell me what would be respective values for sechub concerning stuff like "Publisher" or "PublisherSupportUrl". A lot can be omitted (see jq) but … eh, better you give input beforehand. For brew none of that is really required, they don't store these things in the formulae.
Snap and Flatpak (and to some degree .deb, .rpm) were merely mentioned by me for reference – as in: they are established distribution mechanisms for (pre-packaged) software in their respective Linux distributions (Ubuntu, Fedora, etc.) that facilitate better access to updates and more streamlined installation mechanisms. (Not necessarily better mind you).
The goal behind my issue is mainly making consuming the client binaries easier in some ways. I understand that "just download it and put it onto the $PATH" works wonders and is … as easy as it gets. There's just a few situations (updates for example or scripting a local development setup) where it's not as convenient as an established package manager.
I am perfectly fine with out-scoping Linux (in all its flavours) because of the inherent complexity, though. Especially once you also offer the docker image.


Fetch room data in message source

Rather than just initializing a room object, this will ensure the room belonging to a message Source is fetching from the database. This provides access to room metadata that you would otherwise have to look up after the fact.
See discussion https://github.com/litaio/lita/commit/f507bb0b02940b35b1d9ce3218714a0a5046c460#commitcomment-15466157
cc @jimmycuadra

I would have liked to have implemented this without having to add another interface, but I didn't feel confident enough to change an existing interface. I'm happy to change this as needed to make it acceptable :)

:eyes: @chaeokay

Thanks for the PR! Let's just inline the logic instead of adding a new method to Lita::Room for now. If that operation proves necessary to repeat in more places later, then adding it as a method may be a good refactoring.

That makes sense :). I've updated the PR. Check out my comment on the second commit. I'm not a huge fan of the test, but it feels desirable to cover that case...

Thanks a lot! Nice improvement.


Treat kramdown as an optional dependency?

I use maildown with the redcarpet renderer, but because maildown depends on kramdown bundler insists on installing both gems. As far as I am aware this is ultimately a shortcoming of bundler itself: It does not support optional dependencies or allows me to override dependencies.
As far as I know the "normal" way of handling this is to not specify these "sort of optional" dependencies at the gem level. Rails for example does not specify all sorts of database drivers, although at least one of them will have to be used. Would you consider to do the same for maildown?

I opened this issue some years ago https://github.com/rubygems/rubygems/issues/1811

Would you consider to do the same for maildown?

The usual pattern is to include the default gem so that it works out of the box. If you removed the kramdown requirement then people who's apps had been working would break as most of them likely are not specifying to include kramdown as well.
Even worse, it likely wouldn't be caught until production time, since many people do not render or view emails in development. Lots don't actually test rendering of emails either.
I would not accept removing kramdown as a dependency, however if there's a patch to perhaps defer requiring kramdown so it doesn't get loaded in memory somehow, I might be open to it.


Export internal functions

In our codebase we use multiple extensions that implement $allModels.$allOperations.
They need to be chained and work together so we need to access the internal functions.

Heya, thanks for trying out the library!
I just want to understand what your use case is for using these new exported functions. From your description it sounds like you want to chain $allOperation hooks, what is preventing you from using chained extensions directly? The expected way of chaining extensions is like so:
const client = new PrismaClient()
  .$extends(extensionOne)
  .$extends(extensionTwo)

Each extension can have it's own $allOperations hook so it is effectively achieving what you have described.


2D barcode not decoding properly

I have multiple imgs which are not decoding we have used DataMatrix detection for That some barcode get decoding perfectly but others are not and this is frequently done With same barcodes, can I know the reason ( this non decoding barcode decoded by mobile app without any issue )

To be able to say anything about the reason why a particular symbol was not detected, I need to have the image itself for inspection.

Images.zip
We have these images that we aren't able to decode but when we use any mobile app, they are decoded

we are using python zxing-cpp for this and we are unable to decode We have also done object detection for better output but this exceptional images are not decoding

I had a quick look at the image set and a closer look at one of the samples and the reason zxing-cpp does not currently detect those samples is mainly because they are printed on a curved surface, which is captured from some angle. This results in a distortion within the symbol that can't be dealt with the current approach of using only a perspective transformation.
That said, I noticed that at least two forks exist, where someone experimented with other ideas regarding datamatrix detection, see here and here. Maybe you find something that works for you. Please consider providing feedback to @chorbier and @epoch8.

but when we use any mobile app, they are decoded

I tried 2 different ones and none worked. Can you give me an example for one that works for you?

I have used barcode Scanner by cognix
On Mon, 3 Jun, 2024, 4:37 pm axxel, @.***> wrote:

but when we use any mobile app, they are decoded
I tried 2 different ones and none worked. Can you give me an example for
one that works for you?
—
Reply to this email directly, view it on GitHub
https://github.com/zxing-cpp/zxing-cpp/issues/794#issuecomment-2144917328,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGKHEOOPIGROPL2LGJ5UDQDZFRFABAVCNFSM6AAAAABIVGRIWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBUHEYTOMZSHA
.
You are receiving this because you authored the thread.Message ID:
@.***>

is there any solution ?

Well, I gave you 2 pointers to potential solutions. Have you tried them? I am currently not working on this problem myself.

Which solution you are asking for ?
On Thu, 13 Jun, 2024, 11:42 am axxel, @.***> wrote:

Well, I gave you 2 pointers to potential solutions. Have you tried them? I
am currently not working on this problem myself.
—
Reply to this email directly, view it on GitHub
https://github.com/zxing-cpp/zxing-cpp/issues/794#issuecomment-2164541364,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/BGKHEOMAVE6WMQTNWFSYEUDZHEZ5NAVCNFSM6AAAAABIVGRIWWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRUGU2DCMZWGQ
.
You are receiving this because you authored the thread.Message ID:
@.***>

Which solution you are asking for ?

https://github.com/zxing-cpp/zxing-cpp/issues/794#issuecomment-2144901272

We have decoded bot images in mobile app of cognex barcode decoder app


[BUG CLIENT]: faulty logic in the function_calling.py examples

Python -VV
N/A

Pip Freeze
N/A

Reproduction Steps
I just read examples/function_calling.py and it appears that both functions have the else clause return the error case in the first iteration.
https://github.com/mistralai/client-python/blob/c2bfb767f2222f4efc798f3cb9c19c9ab20b9029/examples/function_calling.py#L23
https://github.com/mistralai/client-python/blob/c2bfb767f2222f4efc798f3cb9c19c9ab20b9029/examples/function_calling.py#L31
Expected Behavior
This seems clearly broken; the loop should iterate over all the records.
Additional Context
No response
Suggested Solutions
It seems to me that the else/return lines should be unindented one level (creating a Python for/else statement) or better, remove the else line and unindent the error case return to the function body level.

Thanks a lot for your report. Indeed it seems that our documentation has been updated a long time ago but we did not update this example. I fixed it in #116!


Fullscreen bug

If I go to full screen the window is slightly bigger than the screen so the borders get cut away and I don't know how to fix that.

You can see it on the stats panel bottom left.

Fixed: https://github.com/MohitSethi99/ArcGameEngine/commit/b68282850d4b395319296d6d708c80b0749de5fc


Support PubSub topic resolution from message header

Header would have precedence over PubSubTemplate's topic field.
Some good examples are the Kafka and Kinesis adapters:
https://github.com/spring-projects/spring-integration-aws/blob/master/src/main/java/org/springframework/integration/aws/outbound/KinesisMessageHandler.java#L93
https://github.com/spring-projects/spring-integration-kafka/blob/master/src/main/java/org/springframework/integration/kafka/outbound/KafkaProducerMessageHandler.java#L147
More discussion here.

The topicExpression should be as an option as well. The same Kinesis and Kafka sample.
All that is based on the SpEL and its support in Spring Integration.