(kMeans, cosine) wrong number of centroids (?)

I'm trying to cluster sentences using TF-IDF, cosine similarity and k-means algorithm. I calculate TF-IDF using natural library then I prepare vectors that look like:
[0, 0, 0, 0, 0, 1.24225242, 0, 0, 0, 0, 0] where every value represents a word and the whole vector represents a sentence (in case of this example it would be a sentence with one word).
Then I try to use talisman library to make clusters using created vectors and metrics/distance/cosine. The problem is that I get:
TypeError: Cannot read property 'length' of undefined
    at KMeans.cosine [as distance] (.../node_modules/talisman/metrics/distance/cosine.js:29:21)
    at KMeans.iterate (.../node_modules/talisman/clustering/k-means.js:164:22)
    at KMeans.run (.../node_modules/talisman/clustering/k-means.js:224:12)
    at kMeans (.../node_modules/talisman/clustering/k-means.js:243:21)
    at Object.<anonymous> (.../lev-kmeans.js:39:22)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

I tried looking into the code and the reason it fails is this piece of code (https://github.com/Yomguithereal/talisman/blob/master/src/clustering/k-means.js#L148).
for (let j = 0, m = this.dimensions; j < m; j++) {
     const d = this.distance(vector, this.centroids[j]);

     if (d < min) {
         min = d;
         minIndex = j;
     }
}

It tries to enter cosine.js functions using undefined as the second vector. For example for k equal 2 it should generate 2 centroids. It does. But this loop is trying to access centroids with very high indices like 181 (this.dimensions and thus m is equal 182).
It works fine when I tested it for simpler stuff using Euclidean distances.
To be complete I add the way I initialize the kMeans:
const clusters = kMeans({
    distance: cosine,
    k: 6,
}, vectors)

Where cosine is a const cosine = require('talisman/metrics/distance/cosine').

Hello @galkowskit. I guess you're right. m should probably be this.k no? It's really weird that my tests passed. Vector dimensions should be equal to k in my tests...
On a side note, I have a little undocumented helper to build tf/idf vectors from documents if you ever need it.

Just published a v0.18.0 with a fix. Can you tell me whether this fix your issue please?
Out of curiosity, what are you trying to cluster?

I will test it in a moment, but when I applied the changes from 5ea30a753d7f2fc7cee46e0f88e3b5cb06e9bb04 it seems to fail from time to time on generating new centroids.
I'm trying to cluster around 1000 strings based on similar keywords.

it seems to fail from time to time on generating new centroids.

What do you mean? Is an Error thrown? Is there a syntax error?

Yes, when I try to cluster those using v0.18.0 the problem I described above is still present. It works in k-means.js but fails from time to time (not always, so it might be a bug with randomizing centroids) on helpers/vectors.js.
TypeError: Cannot read property 'length' of undefined
    at mean (.../node_modules/talisman/helpers/vectors.js:77:27)
    at KMeans.iterate (.../node_modules/talisman/clustering/k-means.js:201:47)
    at KMeans.run (.../node_modules/talisman/clustering/k-means.js:221:12)
    at kMeans (.../node_modules/talisman/clustering/k-means.js:240:21)
    at Object.<anonymous> (.../lev-kmeans.js:39:22)
    at Module._compile (module.js:570:32)
    at Object.Module._extensions..js (module.js:579:10)
    at Module.load (module.js:487:32)
    at tryModuleLoad (module.js:446:12)
    at Function.Module._load (module.js:438:3)

Can I ask you for your data and your k to be able to reproduce and fix? It seems to be an issue with empty centroids and the fact we have to pluck random vectors to populate them.

On a side note: this is the undocumented function I was speaking about here.

https://github.com/galkowskit/talisman-issue-103
I created a small repository with the data and the code I am using to cluster things. You can reproduce the problems by npm install and then npm start a few times. It randomly fails.
The data.js contains raw input data (one that I am expecting) and then in index.js I transform it to vectors and start clustering. Hope it helps.
(And thanks for the function I will give it a try!)

Thanks @galkowskit. I should be able to find some time this afternoon to fix this issue (I will also mostly rewrite the clusterer's code because it can be more efficient).

Ok @galkowskit. I just committed a fix (plus a performance rewrite). Can you test the code and tell me if we're reaching a finally correct implementation so I can release a new version on npm please?

I have tested the version on the master branch and it seems to be working fine on the data I gave you. Out of twenty times I ran it, it didn't crash even once. So I believe the problem with randomized centroids is solved. Thanks a lot!
I still need to figure out some things about my own implementation (I might have some errors in the way I generate results) but it's out of the scope of this issue and the bug seems to be solved. :)

I also did similar tests on my end (with cosine similarity etc.) and find it painful to require a Map to trace back to the original docs etc. I think I will add an option named vector that is a function returning the vector on which to work in a collection. So you can work with something like this for instance:
[
  {data: 'whatever', vector: [...]},
  ...
]

kMeans({..., vector: item => item.vector}, data);

My other (undocumented, sigh...) clusterer can work like this by tweaking only the distance function used but in this case, since I need to "mean" the vectors, I cannot, hence the vector option.
What do you think?

On a side note: are you trying to cluster your documents to find fuzzy duplicates? Or is it rather to group them?

I am trying to create groups of documents that are similar/have similar tags on one of their keys (description). Currently I'm struggling with the correct approach and can't really get it to work the way it should. I even created a SO question if you/anyone is interested (http://stackoverflow.com/questions/42245050/nlp-bag-of-words-tf-idf-for-clustering-and-classifying-short-sentences) in details.

For your n°2, naive bayes classifier really seems to be the way to go. There is one undocumented one in this library but I am not sure it is fitting in your case since it is not the variant that exist to specifically classify text documents.
For n°1, if you just need to cluster, I have some ideas I can try. Will put some ideas in a gist later.

Ok so the issue with your data is that the description is quite terse and seems to be consisting of only 3 tokens each time, which is not a lot. Using Jaccard coefficient, I can gather some of your documents together but this is not ideal:
const data = require('./data.js');

const jaccard = require('talisman/metrics/distance/jaccard');
const naiveClusterer = require('talisman/clustering/record-linkage/naive');

const documents = data.map(item => item.description.split(' '));

const clusters = naiveClusterer({
  similarity: (a, b) => jaccard(a, b) >= 0.5
}, documents);

clusters.forEach(cluster => {
  console.log('Found a cluster with ' + cluster.length + ' items:');

  cluster.forEach(doc => {
    console.log('   ' + doc.join(' '));
  });
});

Note that all the docs not in a cluster are just not linked to no other doc and that produced clusters are fuzzy (meaning that one doc can be in several clusters).

description can be anywhere from 1 to 7-12 words. It's basically a single sentence, maybe two (rarely). What I am aiming at is getting very strict groups that could contain only several elements. Most of the docs could be totally non-clustered.
...which seams to be nearly exactly what happens if I run it with the gist above. 😮

Ok, the thing was that in the data you provided in the repo, the description key seems to always yield only three tokens.
So are we going in the good direction?

Yes, I haven't even considered using Jaccard but it seems to work perfectly. When I added a tokenizer and some stopwords and used it on some actual data it is working perfectly even on non-English language. The only thing that I miss is getting the ID/index of the original document (to make a lookup for the object itself). Or even passing the whole objects into the clusterer with syntax like:
const clusters = naiveClusterer({
  similarity: (a, b) => {
      return jaccard(a.description, b.description) > 0.2
  }
}, data);

But that would require too many changes I believe. And would hit the performance.

No. This would actually work. I often do that and this really won't hurt performance too much. However, know that this clusterer is called naive for a reason: it works in quadratic time (O(n * (n - 1) / 2) to be precise. So if this is fine for not too much docs, it will start being really slow if you have a lot of docs. But I have other techniques to perform this kind of work in a scalable fashion if you ever have performance issues.

And beware, because this method may possibly put a single vector in two separate clusters.

Yes, it does work fine with objects being pushed into the clusterer. It manages to cluster 5000 documents in around 55 seconds.
If you have any other idea for improving performance etc. those will always be welcomed. As for the vectors that happen to be in two clusters - it's not a big issue, I will assign only the first one.
I have one more question though: how would you approach classification of new data into an existing clusters?
eg.
First time the data is clustered it creates some clusters.
Second time new data is clustered it should take existing clusters in consideration (ie. in database) from the first clustering.
After clustering I was thinking about auto-tagging those clusters using TF-IDF.

If you have any other idea for improving performance etc.

I have two ideas that we can try one after the other (the last one might not give us an edge here because we have too few documents). But I'll need some time to write a gist.

I have one more question though: how would you approach classification of new data into an existing clusters?

I would probably use a naive bayes classifier (I think the one from natural is pretty decent for this kind of tasks) using the number of the cluster as label.
Else you can also "summarize" each of the cluster by taking a random document in it and then compare the new document to each of those "fingerprint" documents to see whether it can fit in one. However this will run in a time linear to the number of clusters.

After clustering I was thinking about auto-tagging those clusters using TF-IDF.

Interesting. Do you mean to keep, for instance, the top n tokens of your document using TF-IDF score?

Interesting. Do you mean to keep, for instance, the top n tokens of your document using TF-IDF score?
Yes. Basically each cluster would be summarized by top n TF-IDF tokens and those would be saved. Just for auto-tagging. I was thinking that those could also be useful for classification.


EROFS Error in SoundRecorder Component

Hello,
when i tried to use the SoundRecorder component, can not record sound in android devices, it popup "cannot start recording: *.amr:open failed:erofs(read-only file system)" error message. Anyone can help to advise how to fix it?

@wangiv2 Try adding a Screen1.AskForPermission block in Screen1.Initialize with the permission name android.permission.WRITE_EXTERNAL_STORAGE and see if you can start a recording afterward (you may be prompted for permission).

Hi Ewpatton,
Thanks for your help. But after trying, still the same error popup, below is my setting in block, if there is any wrong? i can not find the android permission so just add as text value. Can you help to advise? Many thanks.

@wangiv2 That looks right. Did you get prompted for storage permissions when the app started? If not, does everything work if you go to Settings>Applications and then turn the permission on manually?

@wangiv2
Hello, I recently found the same issue, is it solved with any solution ?

@wangiv2 That looks right. Did you get prompted for storage permissions when the app started? If not, does everything work if you go to Settings>Applications and then turn the permission on manually?

Same issue. I already set the permission of AI2 companion Allow to access storage...

I'm closing this for now as a potential fix is part of companion 2.65. If the issue persists we can revisit it.


fix: config.yaml in docker collector example

I don't believe this is necessary since ["env", "system" "gcp", "ec2", "azure"] and [env, system, gcp, ec2, azure] are equivalent YAML.

system, gcp,

I don't believe this is necessary since ["env", "system" "gcp", "ec2", "azure"] and [env, system, gcp, ec2, azure] are equivalent YAML.

the issue is that there is a comma missing between system and gcp

the issue is that there is a comma missing between system and gcp

Got it! Thanks.


Add 'Stars on Github' display in the site

Add option like this to get the live starts count of this repo in the board website

Sure, I'll try to pick this up.

I can do this.

Hey i can create one like this : If thats okay please assign me this so i can create a PR


torch.cat failes in apply_rotary_emb when freqs.shape[-1] == t.shape[-1], and start_index = 0

Two issues into one, as they seemingly come from the same function.
Right now, if I torch.jit.trace a module that uses rotate_queries_or_keys(), I hit the following TracerWarning:
TracerWarning: Converting a tensor to a Python boolean might cause the trace to be incorrect. We can't record the data flow of Python values, so this value will be treated as a constant in the future. This means that the trace might not generalize to other inputs!
  assert rot_dim <= t.shape[-1], f'feature dimension {t.shape[-1]} is not of sufficient size to rotate in all the positions {rot_dim}'

Adding to this, if you try to use torch.neuron.trace to trace the same module, I've been hitting this error:
MultiheadAttentionRoPE_8/aten_slice_14/StridedSlice", begin=[0, 0, 0, 0], end=[1, 8, 2, 0], strides=[1, 1, 1, 1]) // an internal invariant was violdated while typechecking your program [21:33:36] /opt/brazil-pkg-cache/packages/DmlcTvm/DmlcTvm-<IP_ADDRESS>/AL2_x86_64/generic-flavor/src/src/relay/op/tensor/transform.cc:2111: Check failed: begin_v < end_v (0 vs. 0) : strided_slice get empty slice at axis 3

The tracing works when I comment out the lines that use the rotate_queries_or_keys call.
UPDATE
I did more debugging into this issue, and it looks like it occurs when t_left and t_right end up with a 0-length axis. For example, I have a starting t tensor of shape [1, 8, 2, 80], and a freqs shape of [x, 80]. This means that rot_dim == t.shape[-1]. After the slicing, I end up with:
t.shape = [1, 8, 2, 80]
t_left.shape = [1, 8, 2, 0]
t_right.shape = [1, 8, 2, 0]

This ends up breaking the torch.cat neuron trace posted above.

UPDATE 2
The fix was to only run torch.cat when t_left or t_right had all non-zeros in their Size tensors


Metadata incompatible error when loading extension

I compiled the project with make and it successfully created the DuckDB CLI and a loadable extension <extension-name>.duckdb_extension.
Now I downloaded the latest DuckDB CLI binary from https://github.com/duckdb/duckdb/releases/download/v0.10.2/duckdb_cli-linux-amd64.zip and tried to load the extension file with install '<path-to-extension>/<extension-name>.duckdb_extension'; + load <extension-name>;, I get:
Invalid Input Error: Extension "<home-dir>/.duckdb/extensions/v0.10.2/linux_amd64_gcc4/<extension_name>.duckdb_extension"
do not have metadata compatible with DuckDB loading it (version v0.10.2, platform linux_amd64_gcc4)

I checked the version of the binary, and it's v0.10.2 1601d94f94 & I compiled my extension against the same version of DuckDB.
What am I doing wrong? :thinking:

Hey @freddie-freeloader I think you may have an old version of the extension installed, can you try FORCE INSTALL '<path-to-extension>/<extension-name>.duckdb_extension'; ?
running install with an already installed extension of that name is a NOP

Thank you @samansmink, that helped.
Now, I get the following error:
Invalid Input Error: Extension "<home-dir>/.duckdb/extensions/v0.10.2/linux_amd64_gcc4/<extension-name>.duckdb_extension" (version v0.10.2, platfrom linux_amd64) does not match DuckDB loading it (version v0.10.2, platform linux_amd64_gcc4)

I guess the issue is, that my extension is linux_amd64 and expected is linux_amd64_gcc4.
So I added -DCMAKE_C_COMPILER=/usr/bin/gcc -DCMAKE_CXX_COMPILER=/usr/bin/g++  to the appropriate CMAKE invocations in extension-ci-tools/makefiles/duckdb_extension.Makefile to compile with gcc & g++. But I still get the above error.
Any ideas, what the problem might be?

Now, I set up the S3-Bucket workflow, and have it build the extension + push to S3-Bucket.
My repository is: https://github.com/freddie-freeloader/duckdb-extension-test
When I run
D SET custom_extension_repository = 'http://duckdb-sheetreader-extension.s3.eu-central-1.amazonaws.com';
D force install sheetreader;
D load sheetreader;

I get
Invalid Input Error: Extension "/home/jub/.duckdb/extensions/v0.10.2/linux_amd64_gcc4/sheetreader.duckdb_extension"
do not have metadata compatible with DuckDB loading it
(version v0.10.2, platform linux_amd64_gcc4)

As you can see in my repository, I use 1601d94f94a7e0d2eb805a94803eb1e3afbbe4ed of the duckdb repository -- so it's unclear to me, what causes the metadata to be incompatible.

My current workaround is to truncate the last 256 byte, that contain the metadata AFAIK (https://github.com/duckdb/duckdb/pull/11515):
truncate -s -256 sheetreader.duckdb_extension

Hey @samansmink ,
I now updated my repository (https://github.com/freddie-freeloader/duckdb-extension-test) to use duckdb 1.0 and the appropriate extension-ci-tools.
When I do
D SET custom_extension_repository = 'http://duckdb-sheetreader-extension.s3.eu-central-1.amazonaws.com';
D FORCE INSTALL sheetreader;

I now get
IO Error: Failed to install 'sheetreader'
The file is not a DuckDB extension. The metadata at the end of the file is invalid

I tried ExtensionHelper::ParseExtensionMetaData and there indeed seems to be a problem with the metadata -- it seems to be misaligned:
parsed_metadata:
  magic_value:"ature\200\004\070\071\063\071\062\061\071v1.0.0linux_amd644"
  platform: "\000\000\001", '\000' <repeats 15 times>, "\223\004\020duckdb_sign"
  ...

Do you have any pointers, when/where the metadata is written and how I could debug the problem?


Use lru_cache to suppress memory usage of commutation analysis

Summary
Use lru_cache to suppress memory usage of commutation analysis. It also simplifies the code a little.
This might be oversimplification because it does not take care of qargs.
Details and comments

Do you have memory profiles for this change?  The current cache only stores a single boolean per key, so I'm surprised it has too large a memory footprint as it is.
I'm also very surprised that DAGOpNode is hashable in the general case.  This seems a little dangerous; they store mutable values within themselves, and they allow themselves to be mutated, so by the normal Python rules, they shouldn't be hashable.

Hi, @jakelishman. Thank you for your comment. @ewinston has the memory profile data with large number of qubits.
I saw #6982 after I made this PR. This oversimplified the code, so it is not likely to run. I will close it.


Release/v0.3.0 snapshot

Snapshot release branch.
Small improvements regarding versions in integration tests.

ci not happy

out of curiosity - why are changes in commited schemas done?

upstream update :)


Seed data for testing

As we keep building out, using a production mirror becomes more and more unwieldy. We should spec out a set of test data that can easily be generated/regenerated with some manage.py tasks. This is actually mostly taken care of already given the importers that already exist, so we should probably just tack everything together.

This should probably also power a dev instance that we can use for user testing.


TS-4853 : Parent Consistent Hash Selection - add parent selection URL and API.

Adds a parent selection URL to be used in generating the hash in the Parent Consistent Hash Selection feature.
Also adds the related TS and Lua API calls to set/get the parent selection URL.

[approve ci]

Linux build successful! See https://ci.trafficserver.apache.org/job/Github-Linux/681/ for details.

FreeBSD build successful! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/785/ for details.

@pbchou - could you squash the 2 commits to one.  If you wouldn't mind, while you're at it, could you also rename the 'const char *tmp' pointer  to something more meaningful in ParentConsistentHash::getPathHash().  It's alway been called 'tmp' but there was a comment suggesting a name change.

@jrushford -- Please pardon me for asking, but I am curious. Is there a reason we can't use "squash and merge" https://help.github.com/articles/about-pull-request-merges/ instead of squashing the branch before merging? It just seems that is the more typical git work-flow. Apologies if I missed some past discussion about this.


Determine link target for RAC research stipend application

Link will go live on January 2nd in order to avoid confusion for current-year grant applicants.


Support for Persian and Arabic text

Hello,
I modified the code to support right-to-left languages such as Persian and Arabic. I thought it may be useful for anybody who is interested in these languages.
https://github.com/adavoudi/SynthText

Thank you for sharing! I will link to your repo from the readme.

@ankush-me
Do you consider merging this to the main repo?

@sslavian812 Yes, I do; hopefully will find some time soon.


Repositories is reinstantiated every access?

There's a bit of code I don't understand, on https://github.com/madsodgaard/vapor-auth-template/blob/fc3f4a7d8a6c3f74305c38718f0798728d46fda1/Sources/App/Services/Repositories.swift#L60
    var repositories: Repositories {
        .init(app: self)
    }

This results in Repositories being instantiated on every access.

@JetForMe It's only Application.Repositories that is instantiated, that type is just a helper type for accessing the actual factory methods for repositories. The actual factory methods/closures are stored in app.storage with the Application.Repositories.Storage type, so they are persistent across the entire Application

That's not what I see when I put a breakpoint there. It gets called multiple times.


instancemap: add 'X' button on the interface to close map

Adds a button at the top right of the instance map for closing the map.

Also you could maybe use instead the orange version of the close button (what is used in world map)

Updated

Updated


Feature/uplink authorization

Type: feature
Description:
Allowing to use NPM_TOKEN (or token assign in process.env) in uplink see http://blog.npmjs.org/post/118393368555/deploying-with-npm-private-modules in headers is also allowed, but it is better to assign in process . env much safer(allow make in CI)

The tests have to pass, please check them.

@juanpicado done

Related #124

@juanpicado adjusts done, thanks!

Perfect @ramonornela great contribution !! Close #124


Passes main update

This update merges latest main to the passes feature.

Closing as this is a replica


Docs tidying

for initial presentation

[x] ~fix versioning~ now [[#36]]
[x] ~review docs + docstrings for obsolete names (e.g. "cubes_to_dataset" should be "cubes_to_xarray")~ now #38
[x] ~fix release notes section~ now https://github.com/pp-mo/ncdata/commit/e8005146e56c8f346c0764d3b7b2ddfebf940483

Think this is all done now


Lightbox gallery error "cannot read properties of undefined (reading 'MEDIUM')"

https://design.undp.org/?path=/story/components-ui-components-gallery-lightbox-gallery--lightbox-gallery

Hi @theadamparker, is this error still occurring for you? I'm not sure how to reproduce. The component seems to load fine locally.

verified in storybook


ci is failing due to clippy error on doctest signature in gh but not locally. root cause and fix.

Clippy is now failing on main when it passed on a previous PR. See here.

Clippy passes locally on main and even though the versions of cargo and clippy are identical between my macos and the GitHub action runner.

I don't know why clippy doesn't fail locally even though the commands are the same. I will address the error directly:
error: bound is defined in more than one place
  --> test-util/src/test_utils.rs:20:22
   |
20 | pub fn doctest<'ctx, Fn: 'ctx, Fut: 'ctx>(func: Fn) -> DoctestResult
   |                      ^^
21 | where
22 |     Fn: FnOnce(String, CredentialProvider) -> Fut,
   |     ^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations
   = note: `-D clippy::multiple-bound-locations` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::multiple_bound_locations)]`

error: bound is defined in more than one place
  --> test-util/src/test_utils.rs:20:32
   |
20 | pub fn doctest<'ctx, Fn: 'ctx, Fut: 'ctx>(func: Fn) -> DoctestResult
   |                                ^^^
...
23 |     Fut: Future<Output = DoctestResult>,
   |     ^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#multiple_bound_locations

error: could not compile `momento-test-util` (lib) due to 2 previous errors
make: *** [Makefile:11: lint] Error 101

I will adjust the trait bounds and see if that fixes it on GH.


[SPARK-44613][CONNECT] Add Encoders object

What changes were proposed in this pull request?
This PR adds the org.apache.spark.sql.Encoders object to Connect.
Why are the changes needed?
To increase compatibility with the SQL Dataframe API
Does this PR introduce any user-facing change?
Yes, it adds missing functionality.
How was this patch tested?
Added a couple of java based tests.

Merging.


[CacheWithRedis] Fix double unlock

Description
Fixes an issue from #8077 related in this thread
In some cases, lock was released twice (one in the finally, one outside it)
Risks
na
Deploy
connectors

PMRR

LGTM

Happy we scoped the new behavior :p

Yep true, thanks for that


chore(ci): add skip-ci for main-cron

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Add ci/main-cron/skip-ci for main-cron as well. It can be used to debug and fix main-cron tests.
Rather than reuse ci/skip-ci for both pull-request and main-cron workflows, we add ci/main-cron/skip-ci.
ci/skip-ci will skip pull-request tests, but all of them should be run before merging. So it should only be used for draft PRs.
On the other hand, ci/main-cron/skip-ci can be used to run some main-cron tests relevant to the PR. Not all main-cron tests must be run before merging a PR. We can just select those we want to test, e.g. failing steps and their dependencies.

Checklist

[ ] I have written necessary rustdoc comments
[ ] I have added necessary unit tests and integration tests
[ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
[ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
[ ] All checks passed in ./risedev check (or alias, ./risedev c)
[ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

[ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

[ ] My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Failing test is expected. The test fails in main-cron as well.


basic test coverage

I think it's best if we meet in the middle here. I've set up two tests, a single PCAP test and a directory test.
First, a PCAP test:
nml -a index -L labels.txt -P test.pcap -4 -t
I ran it from this directory, which contains the labels and the single pcap.
should take about 15 seconds to run.
Second, a directory test:
nml -a pcap --pcap_dir pcaps/ -L labels.txt -4 -t
Takes ~8 ish seconds to run.
Ran from this directory.


[LUIS/.NET SDK] LuisResult only returns 1 intent

In the list intent property, my LuisResult only returns 1 intent instead of a list of intents

@yfan183, can you try using the following code when creating your LuisModel?
[LuisModel("XXXXXXXX-XXXX-XXXX-XXXX-XXXXXXXX", "XXXXXXXXXXXXXXXXX", Verbose = true )]

The verbose flag will request that LUIS send back a list of intents as opposed to just the top scoring intent.

Closing as duplicate of https://stackoverflow.com/questions/47684559/c-sharp-luis-chatbot-extract-all-intents-from-luisresult please refer to my answer there

Problem not solved

Going off of your edit to your Stack Overflow question (your edit indicating that the problem was solved), I'm going to leave this closed.


Customize BluBracket scanner for EdgeX's needs

Issue:
LFX security dashboard is finding thousands of "code secrets" in the EdgeX repository.  However, BluBracket themselves imported edgex-go and there are no active findings at all on main branch.  Dashboard seems to be triggering on edgex-go/docs (which hasn't existed in years) and jakarta/vendor
Issue:
LFX inclusive language filter is triggering hundreds of times on the EdgeX code base.  Upon further examination, a major source of of the alerts is Attribution.txt, which is triggering on "/master" in URL's
For example:
https://github.com/edgexfoundry/device-virtual-go/blob/c9d1bc531ce8d239853a83473b53448fb6f2334c/Attribution.txt#L148
Trigger text:
https://github.com/go-playground/locales/blob/master/LICENSE
LFX response:

The team is working on implementing a feature for dismissing/ignoring non-inclusive alerts. I know there are quite a few of these, but in the meantime, you could add an ignore.yaml file to any repo with these type attribution files https://support.blubracket.com/hc/en-us/articles/4408108989076-Repository-ignore-yaml-file You could use the - path option to ignore these.

BluBracket issues are being worked offline and has been moved into a LFX support ticket:
https://jira.linuxfoundation.org/plugins/servlet/desk/portal/4/SUPPORT-16475
(sorry, not visible to public)


state of session authentication in djoser

As a DRF newbie, using djoser, but also wanting to use session auth, as my application is only browser based, I wonder why session auth is not supported by djoser, as seen here:
https://djoser.readthedocs.io/en/latest/getting_started.html#supported-authentication-backends
Then according to #320, I found the CREATE_SESSION_ON_LOGIN setting, that seems undocumented? I would gently help to improve docs, but I am wondering what exactly the current state with session auth is?

for example, could I disable Token auth in DRF, and enable CREATE_SESSION_ON_LOGIN in djoser, and there we go? Or is this too simple thinking?

The main point of RESTful APIs is to provide unified solution for web and mobile apps. Session handling on mobile is problematic - it is far more convenient to just

Also, djoser will receive a cleanup and refactor in near future, stay tuned.

Thank you. I dont have a mobile to be supported. Session auth is easy and works out of the box, with expire and other functionality built in by django. And is a good solution, for a plain web SPA, IMHO. Also, DRF itself supports it in core. And, it works with djoser.
Would you accept a PR that clarifies things in docs, and officialy adds support (maybe after refactor)?

I can tell you if I can accept the PR only after seeing it :wink: But you are welcome to propose any changes that you see fit.

sure ;-) any (non final) timeline for the refactor? for me it's not urgent, as it works as it is now.

Probably mid-June 2019.

Did you solve it ？ friend

@dekoza I guess the refactor is done? any changes for session auth? would you still accept a PR? :-)

i solved
add config：
DJOSER = {
  ......
    'CREATE_SESSION_ON_LOGIN': True,
....
}

yes. that's the current solution. officialy supporting session auth, with up to date docs, and cleaned up code, is another. let's see if I can invest some time someday

i solved
add config：
DJOSER = {
  ......
    'CREATE_SESSION_ON_LOGIN': True,
....
}

@stfenjobs what end point did you use with these? /token/login/ and /token/login/ look like the only ones for login/logout but use tokens.

Has this been solved already ?

solved with
DJOSER = {
  ......
    'CREATE_SESSION_ON_LOGIN': True,
....
}

this will create an auth token, though, and give it back in the response, if you dont override that serializer.


[Feature] Option to redirect immediatelly from authorize screen

After successful authorization there's currently a 10 second mandatory timeout before page redirects back to redirect_uri. Add a url parameter to skip the waiting, and redirect immediately.

What's the point?

Reliability of the process.
Users can navigate away from the screen during the mandatory 10s timeout making it  unreliable to use as part of any authorization process.

In our particular use case, the authorize screen sits in a popup. Once the authorization is complete, we redirect back to a specific url on our website, which then closes the popup window, fetches changes and refreshes the user's view.
If there's a time gap where users can close the popup window, they will get stuck with stale UI. We have no way of knowing if they completed the authorization step without ugly hacks.

We an user broadcast an operation he should be able to get confirmation and have time to read it, that would not be possible if we remove the 10sec timeout. Even if we remove the 10sec before the redirection, user could close the page before redirection. There is no garantee that the user will comeback to your site, it's anyhow a behavior that your app should handle.

We are not looking for perfect solution, but at least let's try to fix the obvious. Having that timeout feels like a bug from UX perspective, and it increases likehood of users getting stuck in stale state.
Also consider that sometimes no broadcast is made at all, for example when user tries to authorize an account he already has given authorization to, then popup is just unnecessary delay.
We should have the option to display the feedback to the user ourselves, once they are redirected to redirect_url, and you could pass any status or broadcast transaction id as a parameter to redirect_url, you don't need to make it default, just add a parameter so we can choose to display 10s timeout on steemconnect or redirect immediately.

Tested and works great! thank you


Added second argument to WriteByteArrToFile

WriteByteArrToFile was missing the byte array as second input argument

Thank you for correcting this!


Harmonize license headers of script files and go files using multi-line comments

How to categorize this PR?

/area compliance
/kind enhancement
What this PR does / why we need it:
This PR harmonizes license headers of script files and go files using multi-line comments by removing the (c) similar to what was done in PR #7680.
Which issue(s) this PR fixes:
Part of #6016
Special notes for your reviewer:
Release note:

NONE

/lgtm
/approve

/retest


feat: Implement relative integration check

Closes #33

I'm wondering if it wouldn't be better to update the existing hasIntegration utility, like so:
hasIntegration("name", {
	position: "before" // after
})

With position undefined by default

That is also an option. I'll change it :)

Since it needs to be in relation to something else, I'm gonna make a slightly different API.

@florian-lefebvre what do you think of the new API?

Can you also update the changeset to reflect the new API?

Damm it, I always forget the changeset. I'm not used to it 😁


Add JaCoCo configuration to check minimum coverage

This will help checking coverage locally when developing jhlite: a first feedback without the need to wait for CI build and Codecov report.

After more investigation, some tests are only ran on Linux, using @EnabledOnOs(OS.LINUX), that's why the build fails on Windows.
I'm inclined to move this specific jacoco configuration to a maven profile that would be activate only for Linux.

@murdos : I checked out this pull request branch, ran the command ./mvnw verify, and failed. It should pass, isn't it? Am I doing something wrong?

@murdos : I checked out this pull request branch, ran the command ./mvnw verify, and failed. It should pass, isn't it? Am I doing something wrong?

Hmm... it works fine for me, and in CI... Maybe try to clean before, to be sure: ./mvnw clean verify


missing link for generate-loggregator-certs

hello,
i try to upgrade my cf-release to v270 and in this release note, we have link to for generate certificates for loggregator  ( /loggregator/scripts/generate-loggregator-certs => https://github.com/cloudfoundry/loggregator/blob/develop/scripts/generate-loggregator-certs)  but seem to be deleted/moved since
(404)
can you fix that with the good link ?
https://github.com/cloudfoundry/cf-release/releases/tag/v270
thanks
edit :
same on Loggregator release note link :( :
Loggregator 92 => https://github.com/cloudfoundry/loggregator/releases/tag/v92  (404)
must use : https://bosh.io/releases/github.com/cloudfoundry/loggregator?version=92

the good one ?
https://github.com/cloudfoundry/cf-release/blob/master/scripts/generate-loggregator-certs

Hi @jyriok. This repo is being deprecated this week: https://www.pivotaltracker.com/story/show/154853409. If you're trying to set up a new deployment, I'd recommend using cf-deployment.

ok thanks for this information :) i will try to migrate to cf-deployment


DBZ-2620 Adding open graph tags

Nice one; can you push this to the preview branch (see README) so we can take a look?

Nice one; can you push this to the preview branch (see README) so we can take a look?

@uidoyen, kinda forgot about this one; is it good to go from your PoV?

@uidoyen, kinda forgot about this one; is it good to go from your PoV?

@uidoyen, kinda forgot about this one; is it good to go from your PoV?
Yes, I think it's good to go.


reopen libpod/issues/4900

hello,
could you please reopen the issue 4900: https://github.com/containers/libpod/issues/4900
the problem is still there and (afaiu) the issue was closed because just one suggested way to resolve was denied.

Let's keep the discussion over at #4900 (now reopened)


Add 3d object parse functions to timeline parser

@VisualSJ Please review it

@xiaofeng11 Please fix the conflict

Merge confliction fixed

Thank you @xiaofeng11


Flip reverse and forward for second-order AD

It looks like the Forward and Reverse backends had been switched

I don't think so, the goal is to always have a forward-over-reverse second order backend, so if the other half is not provided this code completes the SecondOrder it with default choics

A few problems with this

How do I then accomplish forward over forward mode? My problem has 3 variables, the overhead of reverse mode makes it far worse than forward over forward
Using Optimization.AutoForwardDiff() will now error with "ReverseDiff not loaded", which is really unexpected, I haven't requested any use of ReverseDiff

That's a fair point, I just wanted to point out that the problem isn't really a flip between modes.
I'm not familiar with the internals of OptimizationBase (just trying to help Vaibhav adopt DifferentiationInterface), but for the first point maybe passing SecondOrder(AutoForwardDiff(), AutoForwardDiff()) could work?

Optimization.jl does not appear to handle that at the moment
julia> res = solve(prob, solver)
ERROR: MissingBackendError: Failed to use SecondOrder(AutoForwardDiff(), AutoForwardDiff()).
Please open an issue: https://github.com/gdalle/DifferentiationInterface.jl/issues/new
Stacktrace:
  [1] _prepare_pushforward_aux(f::Function, backend::SecondOrder{…}, x::Vector{…}, tx::DifferentiationInterface.Tangents{…}, ::DifferentiationInterface.PushforwardFast)
    @ DifferentiationInterface ~/.julia/packages/DifferentiationInterface/FTGtS/src/first_order/pushforward.jl:120
  [2] prepare_pushforward(f::OptimizationBase.var"#_f#22"{…}, backend::SecondOrder{…}, x::Vector{…}, tx::DifferentiationInterface.Tangents{…})
    @ DifferentiationInterface ~/.julia/packages/DifferentiationInterface/FTGtS/src/first_order/pushforward.jl:93
  [3] _prepare_pullback_aux(f::OptimizationBase.var"#_f#22"{…}, backend::SecondOrder{…}, x::Vector{…}, ty::DifferentiationInterface.Tangents{…}, ::DifferentiationInterface.PullbackSlow)
    @ DifferentiationInterface ~/.julia/packages/DifferentiationInterface/FTGtS/src/first_order/pullback.jl:104
  [4] prepare_pullback(f::OptimizationBase.var"#_f#22"{…}, backend::SecondOrder{…}, x::Vector{…}, ty::DifferentiationInterface.Tangents{…})
    @ DifferentiationInterface ~/.julia/packages/DifferentiationInterface/FTGtS/src/first_order/pullback.jl:93
  [5] prepare_gradient(f::OptimizationBase.var"#_f#22"{…}, backend::SecondOrder{…}, x::Vector{…})
    @ DifferentiationInterface ~/.julia/packages/DifferentiationInterface/FTGtS/src/first_order/gradient.jl:56
  [6] instantiate_function(f::OptimizationFunction{…}, x::Vector{…}, adtype::SecondOrder{…}, p::Tuple{…}, num_cons::Int64; g::Bool, h::Bool, hv::Bool, fg::Bool, fgh::Bool, cons_j::Bool, cons_vjp::Bool, cons_jvp::Bool, cons_h::Bool, lag_h::Bool)
    @ OptimizationBase ~/.julia/packages/OptimizationBase/3r1wm/src/OptimizationDIExt.jl:42
  [7] instantiate_function
    @ ~/.julia/packages/OptimizationBase/3r1wm/src/OptimizationDIExt.jl:28 [inlined]
  [8] #instantiate_function#48
    @ ~/.julia/packages/OptimizationBase/3r1wm/src/OptimizationDIExt.jl:294 [inlined]
  [9] instantiate_function
    @ ~/.julia/packages/OptimizationBase/3r1wm/src/OptimizationDIExt.jl:287 [inlined]
 [10] OptimizationMOI.MOIOptimizationNLPCache(prob::OptimizationProblem{…}, opt::Ipopt.Optimizer; mtkize::Bool, callback::Nothing, kwargs::@Kwargs{…})
     Use `show(err)` to see complete types.

Yeah this combination works, you can disregard the message in this case. It's probably due to OptimizationBase not having a special case for passing SecondOrder. We can discuss it together @Vaibhavdixit02 if you like.

I'll handle explicit second order and conditional checking of loaded modules before choosing Reverse mode in #110


fix JetPack 5.x NVMM problem

tried to fix JetPack 5.x NVMM problem, with help of NVIDIA forum user @dl1
https://forums.developer.nvidia.com/t/extractfdfromnvbuffer-fails-with-nvmap-ioc-get-fd-failed-invalid-argument/228859

Sorry for the delay - merged this in https://github.com/dusty-nv/jetson-utils/commit/da9db893db1c529edb4aacec7fb5060d9aaaac53

Hi, I have tried the newest version, 8K video cannot be shown correctly. Only green image.
https://user-images.githubusercontent.com/29222415/220300499-ab00cfd3-ec7f-401d-8a02-b928eda16137.mp4
Meanwhile, 2k/4k OK.
And the last edited version in this post (https://github.com/dusty-nv/jetson-utils/pull/137/commits/f0a9e416ccf5268d36f366ea61a78643cf5cf7a0) can show 8k video with some frame lost.

It turns out this didn't work at all for me on JetPack 5.1, so I backed out the change...still investigating

My yesterday's result was tested on JetPack 5.0.2.


Add a nixpacks report command

Feature request
This command should include the following:

nixpacks version
docker info
os info
anything else useful for debugging

Motivation
This would provide folks with a single command to include debugging information for bug reports, standardizing and simplifying bug reporting.
Contribution
I'm not super familiar with Rust so probably not.

This is a great idea!

@coffee-cup instead we can make the command open the create-an-issue page of nixpacks, Will require adding webbrowser dependency


Updated Defi dex logo

What kind of PR is this?:

/kind feature
What this PR does / why we need it:
Changed defi dex logo to match recent design
Which issue(s) does this PR fixes?:

Fixes #277
Additional comments?:
Developer Checklist:

[x] Read your code changes at least once
[x] Tested on multiple web browsers
[x] Tested responsiveness (e.g, iPhone, iPad, Desktop)
[x] No console errors
[x] Unit tests*
[x] Added e2e tests*

Codecov Report

Merging #278 (537e9b2) into main (e5e2931) will not change coverage.
The diff coverage is n/a.

:exclamation: Current head 537e9b2 differs from pull request most recent head f0eafac. Consider uploading reports for the commit f0eafac to get more accurate results

@@           Coverage Diff           @@
##             main     #278   +/-   ##
=======================================
  Coverage   82.14%   82.14%
=======================================
  Files          52       52
  Lines         588      588
  Branches      130      130
=======================================
  Hits          483      483
  Misses         99       99
  Partials        6        6

Impacted Files
Coverage Δ

src/pages/blocks/index.tsx
90.90% <0.00%> (-9.10%)
:arrow_down:

src/components/prices/PriceTickerDetail.tsx
75.00% <0.00%> (ø)

src/components/prices/PriceOracleTable.tsx
93.33% <0.00%> (+6.66%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e2931...f0eafac. Read the comment docs.

@jtlntno-cake , have made the changes accordingly. Please check and let me know your thoughts.

Looks better and cleaner. Thanks @siradji


[BugFix] Fix two window with cte bug

What type of PR is this：

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：

Fixes https://github.com/StarRocks/starrocks/issues/13798
Problem Summary(Required) ：

when Window Node enforce sort & distribute, replace ANY property lose CTE propery
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[ ] I have checked the version labels which the pr will be auto backported to target branch

@mergify rebase

[FE PR Coverage Check]
:heart_eyes: pass : 1 / 1 (100.00%)
file detail

path
covered_line
new_line
coverage
not_covered_line_detail

:large_blue_circle:
com/starrocks/sql/optimizer/task/EnforceAndCostTask.java
1
1
100.00%
[]

run starrocks_admit_test

@Mergifyio backport branch-2.5


Reduce the horizontal space between prompt and response chats

There is a lot of margin between the (user's) prompt and the bot's response. Whereas this space can be better utilised by having wider chat "containers", and thus allowing for the prompt and the response to take up fewer lines. One could think of drastically/completely remove this margin and have another way to show a distinction between the user and the chat (e.g., a slightly different background)
The current layout is, for example, when the user/bot provides a long piece of code or a long text, problematic since it creates a lengthy chat containers on the Y axis. Other LLM interfaces don't have any (noticeable) horizontal margins between the user and the bot: ChatGPT, Bard, Cohere. Although i.e., ChatGPT doesn't have a drastically wider Chat "container", they have a very small header that disappears when scrolling, allowing them to show more content this way.

Thank you for reporting this.  Are you referring to this gap:

Sorry for being unclear. Hope this screenshot helps with some ideas (a combination of these two ideas would also be a viable option in my humble opinion):

As copilot also has a pretty sizeable header, there is little room left currently for the chat to be displayed. Other chats (e.g. ChatGPT) either use a combination of a different background for user-bot and/or hiding the header when scrolling. Hiding/collapsing the header is also a viable option but I think increasing the width of the chatbox is the easiest solution right now.

Ok, got it.  Thank you for the clarification.  I do understand that messaging apps (such as teams) do offer various layouts (some more compact than others).  There is certainly an opportunity here.   Looking at this on a large monitor, I'm seeing more wasted space.  The UX here could be certainly be more reponsive.


[zh] Sync /feature-gates/a*.md

Related to issue https://github.com/kubernetes/website/issues/44410
Add the new 'stages' metadata to all zh feature gate filename prefixed with "a" in
content/zh-cn/docs/reference/command-line-tools-reference/feature-gates/

accelerators.md
admission-webhook-match-conditions.md
advanced-auditing.md
affinity-in-annotations.md
aggregated-discovery-endpoint.md
allow-ext-traffic-local-endpoints.md
allow-insecure-backend-proxy.md
any-volume-data-source.md
api-list-chunking.md
api-priority-and-fairness.md
api-response-compression.md
api-self-subject-review.md
api-server-identity.md
api-server-tracing.md
apparmor.md
attach-volume-limit.md

Please copy the existing translations into these files. Thanks. @dipesh-rawat

@tengqm Thanks for the review. I have just added the metadata in the front matter of these files. The rest of the (localized) content which is below is untouched and remains present in the files as before.

Ah, I see. Those unchanged lines were folded.
/approve

/lgtm


Software information

Name: Dogfight 1942
Settings: All Max

System information

GPU: AMD Radeon RX 570
Driver: 2.0.179
OS: Windows 10

Apitrace file(s)

Dogfight1942_windows_10_dxvk1.9_iwo_jima.trace.tar.xz
Dogfight1942_windows_10_dxvk1.9_midway.trace.tar.xz

Screen Recordings

Dogfight1942_windows_10_dxvk1.9_iwo_jima.mp4
Dogfight1942_windows_10_dxvk1.9_midway.mp4

Log files

Dogfight1942_d3d9_windows_10_dxvk1.9.log

Note

Happens on Linux with Proton too. See: https://github.com/ValveSoftware/Proton/issues/3910
I played a bit with the Game Settings, but no luck.

Cannot reproduce on my NVIDIA system.

The game is multiplying inf by some number in a fragment shader which results in NaN. So it's the same issue as #1619 .

Should be fixed by c13395db970d16a5631a7c0926e2c4529d2710c3

Should be fixed by c13395d

Thanks, but on the "Iwo Jima" Map the artifacts are still present.
Midway: looks good.

Iwo Jima:

Does RADV_DEBUG=nodcc fix those?

Does RADV_DEBUG=nodcc fix those?

Sorry for the late reply, but i wasn't able to test this option. At the moment i can´t get the game running with Wine/Proton (i tried several versions), it looks like there is some regression.

is this still an issue with 1.10.1?

no, it's fine now. Thanks


Provide custom dependecy configuration for test suits

I would like to declare test suit dependencies inside "main" dependency block similar to nebula.facet plugin
Expected Behavior
dependencies {
    archTestImplementation("com.tngtech.archunit:archunit:0.22.0") // declare dependency here
}

testing {
    suites {
        val test by getting(JvmTestSuite::class) {
            useJUnitJupiter()
        }

        val archTest by registering(JvmTestSuite::class) {
            targets {
                all {
                    testTask.configure {
                        shouldRunAfter(test)
                    }
                }
            }
        }
    }
}

tasks.named("check") {
    dependsOn(testing.suites.named("archTest"))
}

Current Behavior
testing {
    suites {
        val test by getting(JvmTestSuite::class) {
            useJUnitJupiter()
        }

        val archTest by registering(JvmTestSuite::class) {
            dependencies {
                implementation("com.tngtech.archunit:archunit:0.22.0") // currently I need to add dependencies here
            }

            targets {
                all {
                    testTask.configure {
                        shouldRunAfter(test)
                    }
                }
            }
        }
    }
}

tasks.named("check") {
    dependsOn(testing.suites.named("archTest"))
}

This is intentional to provide a consistent naming convention (implementation, runtimeOnly, compileOnly).
If you know the configuration's name, you can still use the top-level dependencies {} block; however, these names may change as the test suite plugin evolves.


Support for non-login watching inside some room number / category

描述

As you may know, there's some live can not be viewed if you aren't logged in. The image of live stream will appear at first and then disappear very quickly. So maybe there's a possibility to remove that kind of restriction I guess.

The official bilibili has been updated, now some live (like APEX) must be logged in to get the live feed.

I tried to block https://s1.hdslb.com/bfs/static/blive/blfe-live-room/static/js/app.33bcae1698c519adbc38.js and the steam continues playing without interrupts. So, for solving this problem, I think that we might to modify some function inside this script.

I don't think there are many users who need this feature, after all, it's not that hard to login a bilibili account. And predictably, to do this feature would require fighting against some of the anti-cheat logic on bilibili, which would be a hard work.
By the way, modifying or hijacking a function in a js file is not easy since we usually don't have direct access to the variables in it.

Thank you for your reply and your great work on this useful project. Have a good day!


Experiment Versioning | Model changes

From the original PR, this is just the model changes + migrations.
Spec
Description

The model changes.
User Impact

No user impact. Since this is just a DB + some backend code changes with no user interfacing changes, things should continue working as usual.
Demo

The closest to a demo is the tests.
Docs

N/A

🌟🚀


Revert "*: add glide install options"

Reverts coreos/etcd-operator#646
The build becomes flaky today. I tried that reverting this will make build stable again. Let's not break the master first.
As mentioned in https://github.com/coreos/etcd-operator/issues/649, it's still broken.

I do not understand this. why glide options can affect our build? Can you confirm this commit is the bad one?

@xiang90
Yes.
With this commit https://github.com/coreos/etcd-operator/commit/ca626ece46a52605c5de5c40f4d38dfb33d4e80f, CI test turned green: https://jenkins-etcd.prod.coreos.systems/job/etcd-operator-flaketest/

LGTM. But we need to figure out why glide does not work well.


Typing Mistake

[Enter feedback here]
The Program.cs file contains the following code:
should be
The Startup.cs file contains the following code:
Document Details
⚠ Do not edit this section. It is required for learn.microsoft.com ➟ GitHub issue linking.

ID: ab408035-6313-a183-9940-32de00e0e977
Version Independent ID: ab408035-6313-a183-9940-32de00e0e977
Content: Tutorial: Create a minimal API with ASP.NET Core
Content Source: aspnetcore/tutorials/min-web-api.md
Product: aspnet-core
Technology: aspnetcore-tutorials
GitHub Login: @wadepickett
Microsoft Alias: wpickett

Since .NET 6, there is no Startup.cs anymore by default – the docs correctly refer to the Program.cs.


executor: Don't repull image if pinned by digest

If the image reference in the spec uses a digest, and an image with that
digest already exists locally, avoid an unnecessary repull.
cc @nishanttotla @stevvooe @aluzzardi @tonistiigi

@aaronlehmann I'm not sure this is the right component to handle this. The format of the image ref should be opaque to the the controller. Shouldn't the engine make this determination?

@stevvooe: Do you mean that the pull implementation should short-circuit if a pull by digest was requested and the image with that digest already exists?
I'm not completely sure I agree with that, as it means we would skip the flow that normally happens when you run docker pull. If the registry is down or your credentials are bad, you would have no way of knowing if you pulled by digest (or with content trust on) and the image already existed. But that said I'm not sure this matters because pulling an image by digest that already exists is a silly thing to do. So maybe it does make sense to move this to the pull code.

I see why this optimization could be problematic in the push/pull code. Let's just move this into the adapter for now.

@stevvooe: Moved to the adapter. This ended up being cleaner than the original approach.
PTAL

LGTM

LGTM

LGTM


Create comments

Create comments, first part of the issue Add comments

[x] Init route and schema
[x] Implement controller and services
[x] Write tests
[x] Does not show comment form if user not logged in

Maybe it would make sense to work in #138 in this PR :)


describe how to add stable repo

Is this a new chart
No.
What this PR does / why we need it:
Helm 3 does not install stable repo by default, and so user must run command:
helm repo add stable https://kubernetes-charts.storage.googleapis.com

However, I can't remember the URL.
Which issue this PR fixes
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)

fixes #19279

Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

[x] DCO signed
[ ] Chart Version bumped
[ ] Variables are documented in the README.md
[ ] Title of the PR starts with chart name (e.g. [stable/mychartname])

/ok-to-test


feat: add es and zh translation to the feedback form

Closing issues
closes #202 202
...
Description
Adds feedback form translations to es and zh.

...
Changes

Import i18next to the feedback component.
Created a new translation grupo into rightSidebar for es and zh
Replaced the hardcoded texts with the t function.

Spanish translation lgtm 👍
Good to see known faces contributing 😄

@ChuhanJin can you take a look at the Chinese translation?
Also, can we check on why the deployment is failing @brolag

@emilyJLin95
I'm getting this error from the develop branch as well. Seems to be related to the @astro/preact package. It seem to be unrelated but I'll try to fix it.

 generating static routes
09:59:47 ▶ src/pages/404.astro
09:59:47   └─ /404.htmlCannot convert undefined or null to object
  Stack trace:
    at Function.keys (<anonymous>)
    at Object.renderToStaticMarkup$1 (file:///~/scroll/scroll-documentation/dist/renderers.mjs:130:3)
    at async renderComponent (file:///~/Sites/scroll/scroll-documentation/dist/chunks/astro/server_DiIDKlgx.mjs:1515:10)
    ```

Hi @emilyJLin95 this should be fine now.


Replace sync/atomic with uber-go/atomic + Ensure sync/atomic is not being directly imported

Following https://github.com/prometheus/prometheus/pull/7659, this fully addresses https://github.com/prometheus/prometheus/issues/7647 and adds a mechanism to make sure that we are not using the restricted package.
PTAL @codesome 🙏

Thanks for the review @codesome, I have addressed your points, hope its ready to ship now.

Can you make the ci changes in another pr?

@roidelapluie sure thing, lets keep 1 change per PR.

@roidelapluie sure thing, lets keep 1 change per PR.

This is because the Makefile change per se it more complex and I don't want to block the atomic/ part.

Let me know if you would like me to rebase the branch to get rid of the commits that address the Makefile/CI part.

We will probably just squash the PR in github

I wonder why did unit tests no run. Hoping after fixing the nit it will run again.


Convert an ImageData to a numpy array

Hi I'd like to first thank you for developing pyglet. It is an awesome library!
My question is the same as a stackoverflow question, but no one answers that question. This is why I am posting this question here.  I apologize if this is an inappropriate question on Github. Below is the link. (https://stackoverflow.com/questions/55742197/how-to-change-a-pyglet-image-into-a-numpy-array)
I'd like to take a screenshot and change it to a numpy array while running a game. I used pyglet.image.get_buffer_manager().get_color_buffer().get_image_data(), which returns an ImageData. Get_data() returns a pyglet.image.c_ubyte_Array.   If you don't mind, I'd like to ask how to convert an ImageData object or c_ubyte_Array to a numpy array?
Thank you,
Bohan Yang

Is anything wrong with the following approach?
import pyglet
import numpy as np
ibar = pyglet.image.get_buffer_manager().get_color_buffer().get_image_data()
np.asanyarray(ibar.get_data())

Hi Agricolab, thank you I appreciate your help. Problem solved!


import order matters when running as marimo edit my-notebook.py vs python my-notebook.py on the same environment

Describe the bug
First of all, this is an amazing framework and I'm actively working on porting my notebooks to it. Congrats and thank you for this incredible contribution to the community.
In porting one of my notebooks, I kept running into an error importing faiss which didn't happen on jupyter.
I was able to strip it down to a very minimal example which currently fails when I run it as marimo edit ... but runs fine when I run python ....
Basically if I import pandas before faiss I get a missing library error:
This cell raised an exception: ImportError('/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /opt/conda/lib/python3.12/site-packages/faiss/_swigfaiss.so)')

I was able to see that when I import faiss after pandas I get to this point in faiss's init logic, whereas if I run it with python ... OR if I import pandas after faiss this try-except block is succesful and that prevents me from arriving at the previously linked spot.
If I turn logging on, I can tell that when I get to the error the two try-except blocks in the code linked above also err because of the same library not found:
INFO:faiss.loader:Loading faiss with AVX512 support.
INFO:faiss.loader:Could not load library with AVX512 support due to:
ImportError("/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /opt/conda/lib/python3.12/site-packages/faiss/_swigfaiss_avx512.so)")
INFO:faiss.loader:Loading faiss with AVX2 support.
INFO:faiss.loader:Could not load library with AVX2 support due to:
ImportError("/lib/x86_64-linux-gnu/libstdc++.so.6: version `GLIBCXX_3.4.29' not found (required by /opt/conda/lib/python3.12/site-packages/faiss/_swigfaiss_avx2.so)")
INFO:faiss.loader:Loading faiss.

It's really strange to me that importing pandas before faiss ultimately is what triggers this, but that it doesn't happen outside of marimo edit ... in the exact same environment...
Any guidance is highly appreciated
Environment
{
  "marimo": "0.8.18",
  "OS": "Linux",
  "OS Version": "5.14.0-427.33.1.el9_4.x86_64",
  "Processor": "x86_64",
  "Python Version": "3.12.6",
  "Binaries": {
    "Browser": "--",
    "Node": "--"
  },
  "Dependencies": {
    "click": "8.1.7",
    "importlib-resources": "6.4.5",
    "jedi": "0.19.1",
    "markdown": "3.7",
    "pygments": "2.18.0",
    "pymdown-extensions": "10.9",
    "ruff": "0.6.6",
    "starlette": "0.38.5",
    "tomlkit": "0.13.2",
    "typing-extensions": "4.12.2",
    "uvicorn": "0.30.6",
    "websockets": "12.0"
  },
  "Optional Dependencies": {
    "pandas": "2.2.3",
    "pyarrow": "17.0.0"
  }
}

Code to reproduce
import logging
logging.basicConfig(level="DEBUG")

import pandas as pd
import faiss

@colobas thanks for reporting and the detailed issue. this is definitely an odd bug. we will look into this next

Additional context (versions):
$ micromamba list | grep faiss
  faiss-gpu           1.8.0      py3.12_hedc54c9_0_cuda11.4.4  pytorch
  libfaiss            1.8.0      h5aaf3ed_0_cuda11.4.4         pytorch

$ uv pip show pandas
Name: pandas
Version: 2.2.3
Location: /opt/conda/lib/python3.12/site-packages
Requires: numpy, python-dateutil, pytz, tzdata
Required-by: anndata, cell-gears, datasets, geoparse, mlflow, sangha, scanpy, scgpt, scib, seaborn, statsmodels

@colobas , thanks for reporting. I couldn't reproduce this on macOS, but there may be platform-specific issues. This weekend I can try on linux with faiss-gpu.
In the meantime, in case you haven't already, can you try this is a brand new environment?
I think this StackOverflow thread has the answer in there somewhere: https://stackoverflow.com/questions/77939924/importing-pandas-and-cplex-in-a-conda-environment-raises-an-importerror-libstdc

@akshayka this was a fresh env inside a docker (apptainer actually) container.
And you're right that StackOverflow thread definitely seems to be getting at the issue. And indeed setting LD_LIBRARY_PATH resolves the issue. So it seems that the different behavior of python ... and marimo edit ... boils down to how each of them is influencing RPATH?

It's peculiar, I'm not sure. marimo edit runs the notebook in a separate process. If you try marimo run without setting the environment variable, do you get the same issue?
We don't have any logic related to PATH/RPATH/environment variables. And marimo edit itself should be the same as python -m marimo edit.

Just tried marimo run and python -m marimo run and python -m marimo edit and they all fail, vs just python ....
I added code to print the env vars from inside the script and here's what I get for python ... vs marimo ...
python test-import.py
UV_CACHE_DIR=/tmp
MAMBA_USER_ID=57439
ENV_NAME=base
MAMBA_USER=mambauser
SINGULARITY_NAME=container.sif
SINGULARITY_ENVIRONMENT=/.singularity.d/env/91-environment.sh
PWD=/home/gpires
CONDA_PREFIX=/opt/conda
MAMBA_ROOT_PREFIX=/opt/conda
APPTAINER_ENVIRONMENT=/.singularity.d/env/91-environment.sh
APPTAINER_APPNAME=
HOME=/home/gpires
LANG=C.UTF-8
APPTAINER_COMMAND=exec
SINGULARITY_CONTAINER=/home/gpires/net-seq-gpires/compbio-containers/containers/scGPT/container.sif
UV_LINK_MODE=copy
APPTAINER_CONTAINER=/home/gpires/net-seq-gpires/compbio-containers/containers/scGPT/container.sif
MAMBA_USER_GID=57439
MAMBA_EXE=/bin/micromamba
TERM=screen
SHLVL=1
MAMBA_PKGS_DIR=/tmp/mamba-pkgs-cache
APPTAINER_NAME=container.sif
SINGULARITY_BIND=
APPTAINER_BIND=
LD_LIBRARY_PATH=/.singularity.d/libs
PS1=Apptainer>
LC_ALL=C.UTF-8
PATH=/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
_=/opt/conda/bin/python

marimo run test-import.py
UV_CACHE_DIR=/tmp
MAMBA_USER_ID=57439
ENV_NAME=base
MAMBA_USER=mambauser
SINGULARITY_NAME=container.sif
SINGULARITY_ENVIRONMENT=/.singularity.d/env/91-environment.sh
PWD=/home/gpires
CONDA_PREFIX=/opt/conda
MAMBA_ROOT_PREFIX=/opt/conda
APPTAINER_ENVIRONMENT=/.singularity.d/env/91-environment.sh
APPTAINER_APPNAME=
HOME=/home/gpires
LANG=C.UTF-8
APPTAINER_COMMAND=exec
SINGULARITY_CONTAINER=/home/gpires/net-seq-gpires/compbio-containers/containers/scGPT/container.sif
UV_LINK_MODE=copy
APPTAINER_CONTAINER=/home/gpires/net-seq-gpires/compbio-containers/containers/scGPT/container.sif
MAMBA_USER_GID=57439
MAMBA_EXE=/bin/micromamba
TERM=screen
SHLVL=1
MAMBA_PKGS_DIR=/tmp/mamba-pkgs-cache
APPTAINER_NAME=container.sif
SINGULARITY_BIND=
APPTAINER_BIND=
LD_LIBRARY_PATH=/.singularity.d/libs
PS1=Apptainer>
LC_ALL=C.UTF-8
PATH=/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
_=/opt/conda/bin/marimo

LD_LIBRARY_PATH=/opt/conda/lib:$LD_LIBRARY_PATH marimo edit test-import.py
LD_LIBRARY_PATH=/opt/conda/lib:/.singularity.d/libs
UV_CACHE_DIR=/tmp
MAMBA_USER_ID=57439
ENV_NAME=base
MAMBA_USER=mambauser
SINGULARITY_NAME=container.sif
SINGULARITY_ENVIRONMENT=/.singularity.d/env/91-environment.sh
PWD=/home/gpires
CONDA_PREFIX=/opt/conda
MAMBA_ROOT_PREFIX=/opt/conda
APPTAINER_ENVIRONMENT=/.singularity.d/env/91-environment.sh
APPTAINER_APPNAME=
HOME=/home/gpires
LANG=C.UTF-8
APPTAINER_COMMAND=exec
SINGULARITY_CONTAINER=/home/gpires/net-seq-gpires/compbio-containers/containers/scGPT/container.sif
UV_LINK_MODE=copy
APPTAINER_CONTAINER=/home/gpires/net-seq-gpires/compbio-containers/containers/scGPT/container.sif
MAMBA_USER_GID=57439
MAMBA_EXE=/bin/micromamba
TERM=screen
SHLVL=1
MAMBA_PKGS_DIR=/tmp/mamba-pkgs-cache
APPTAINER_NAME=container.sif
SINGULARITY_BIND=
APPTAINER_BIND=
PS1=Apptainer>
LC_ALL=C.UTF-8
PATH=/opt/conda/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
_=/opt/conda/bin/marimo

Yea, they're the same, thanks for investigating. So the issue is not the environment variables.
It's very perplexing that it works on Jupyter but not marimo.
To the extent we do anything special, it's here (patching the main module): https://github.com/marimo-team/marimo/blob/main/marimo/_runtime/patches.py#L119-L169
I wonder if at some point it would be appropriate to file an issue with conda, at least to get help

@alefminus everything looks correct to me. the main difference is I'm using faiss-gpu=1.8.0 and I think the cpu version isn't built with avx2 support by default (see e.g. this)
I'll provide the output with LD_DEBUG=all shortly


There was an error running tdjson. example. py!

[os]: win11 x64
[python]: 3.12.4
[cmd]: python tdjson. example. py
[commit]: 91aa6c9e4d0774eabf4f8d7f3aa51239032059a6
[console] :
Traceback (most recent call last):
  File "D:\works\td\example\python\tdjson_example.py", line 63, in <module>
    print(str(td_execute({'@type': 'setLogVerbosityLevel', 'new_verbosity_level': 1, '@extra': 1.01234})).encode('utf-8'))
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "D:\works\td\example\python\tdjson_example.py", line 55, in td_execute
    result = _td_execute(query)
             ^^^^^^^^^^^^^^^^^^
OSError: exception: access violation reading 0x0000000000000000

Everything works correctly for me with Python 3.11.9 and I doubt that something was changed with ctypes in 3.12.
Could you run the command dir -l . from the directory D:\works\td\example\python and send its output?

Everything works correctly for me with Python 3.11.9 and I doubt that something was changed with ctypes in 3.12.
Could you run the command dir -l . from the directory D:\works\td\example\python and send its output?

Everything works correctly for me with Python 3.11, thanks!


Fix javadoc and reenable Javadoc doclint verification

@joel-costigliola It took me a while to figure it out, but I think the nested list error is not a bug in Javadoc. The usage of list tags was actually "incorrect" (browsers do not care, but Javadoc is more strict).
With the change below the error disappeared when using Javadoc on Java 11.0.1.

Thanks Pascal, that's great!


add label for "not seen recently" to user list

coverage: 88.195% (-0.02%) from 88.211%
when pulling 73e9227f8589768434a96b2a491d2c6a1358877f on user-not-seen-recently
into b725fb92e019ed1a49e509afcffcf81aa6b61e8f on main.


Update needed

This section should be updated as the fix is being rolled out
Cached logon on Hybrid Azure AD joined devices
Cached logon with FIDO2 keys fails on hybrid Azure AD joined devices on Windows 10, version 20H2. As a result, users will not be able to login when line of sight to the on-premises domain controller is unavailable. This is currently under investigation.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 78c66f8a-1c40-e31c-5c7e-7870b7d65e0c
Version Independent ID: 3e8301bc-8e4d-ee23-8770-2f75e170e01a
Content: Passwordless security key sign-in - Azure Active Directory
Content Source: articles/active-directory/authentication/howto-authentication-passwordless-security-key.md
Service: active-directory
Sub-service: authentication
GitHub Login: @Justinha
Microsoft Alias: justinha

@Chrniel Thanks for the feedback. We will engage the content development team for further investigation, they will verify and perform necessary changes in the document as needed.

@Chrniel sorry for delay. if this is still an issue can you submit a pull request to the troubleshooting topic with guidance? https://docs.microsoft.com/en-us/azure/active-directory/authentication/howto-authentication-passwordless-troubleshoot

#please-close


fix: set option

What this PR does / why we need it:
Fixes: https://github.com/helm/helm/issues/12450
Please let me know if these needed . \t、\n、\r、\f.
and if it's not a bug, you can close it.
Special notes for your reviewer:
If applicable:

[ ] this PR contains documentation
[ ] this PR contains unit tests
[ ] this PR has been tested for backwards compatibility

@naruse666 please add some unit tests for this case.


Record Sidekiq stats with collectd

In order to help diagnose excessive memory usage of worker tasks,
this change collects Sidekiq process data with collectd, for monitoring
in Graphite.

 Memory issues in Sidekiq jobs

@cbaines does this look alright now?

@cbaines does this look alright now?

Yep, I think that will work better.


use node v20 in github workflow (replacing v19)

additional:

update deps
suppress more unwanted log errors in e2e tests

Codecov Report

Merging #3093 (153718d) into develop (7e58b38) will increase coverage by 0.04%.
The diff coverage is n/a.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
@@             Coverage Diff             @@
##           develop    #3093      +/-   ##
===========================================
+ Coverage    25.94%   25.98%   +0.04%
===========================================
  Files           53       53
  Lines        11572    11572
===========================================
+ Hits          3002     3007       +5
+ Misses        8570     8565       -5

see 1 file with indirect coverage changes
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.


Change Request: Only require the use of a Client suffix on "entry point" types for C#/All

Only require the use of a Client suffix on "entry point" types
The Basics

Which design guideline is affected?
5.2 in the C# section which states

DO name service client types with the Client suffix, e.g. ConfigurationClient.

Which target languages are affected?
C#, though other languages may want to adopt similar guidance

Describe the change:
Instead of requiring a Client suffix on every type a user can construct to make service calls, we should relax the guideline to only require a Client suffix on the types we want to guide users to when getting started.

Reasoning
The current guideline asserts every type a user can create and use to make service calls should be suffixed with Client.  It's a crisp, black and white rule that's easy to follow and enforce from a guidelines perspective.
Some services, like Storage, have an object hierarchy with many similar looking names that can make getting started harder.  If we follow the current guideline, intellisense will be filled with BlobServiceClient, BlobContainerClient, BlobClient, BlockBlobClient, PageBlobClient, and AppendBlobClient.  We want users to start with BlobServiceClient.  It's the root of the conceptual hierarchy and works with the connection string provided in the portal.  We've also seen plenty of evidence that developers look for something with the name Client when getting started.  Only using the suffix on BlobServiceClient and leaving BlobContainer, BlockBlob, etc., alone sends a very clear message to developers inexperienced with the service.
I propose the following amended guidelines:

DO name service client types with a Client suffix if you expect most users to start with them (per connection strings in the portal, via code snippets in your documentation, conceptually if you provide a hierarchy of related services, etc.)
CONSIDER adding a Client suffix to other service client types if it aids discoverability or comprehension

Please chime in with suggestions to tighten the language and make it crisper.

I thought of another way to write the guideline that may work better for everyone:

Either

DO name service client types with a Client suffix, e.g. ConfigurationClient, or
DO ensure service client types are reachable via GetFoo(string name) accessors from a root service client type suffixed with Client,
e.g. a root BlobServiceClient with a GetBlobContainer(string name) method returning a BlobContainer service client type with a GetBlockBlob(string name) method returning BlockBlob service client type.

This is easy to verify and enforce while still driving customers to the root of a service hierarchy (where their portal connection strings will work, etc.) when that's appropriate for a specific service.

DO name service client types with a Client suffix, e.g. ConfigurationClient, or

I am not sure if this guideline was meant to accomplish your goal of allowing BlobClient to drop the “client” suffix, but it does not seem to do it. BlobClient is a service client, as today, “service client” is defined as a type that calls into a REST endpoint.

DO ensure service client types are reachable via GetFoo(string name) accessors from a root service client type suffixed with Client, e.g. a root BlobServiceClient with a GetBlobContainer(string name) method returning a BlobContainer service client type with a GetBlockBlob(string name) method returning BlockBlob service client type.

This reinforces what I said above, i.e. you call the types returned from these Get methods “service client types”

DO name service client types with a Client suffix if you expect most users to start with them (per connection strings in the portal, via code snippets in your documentation, conceptually if you provide a hierarchy of related services, etc.)
CONSIDER adding a Client suffix to other service client types if it aids discoverability or comprehension

These are very vague. It's basically equivalent to saying "use client suffix to alert customers that this is a type they should look into"

... and so, what about:

There are hierarchical services and "flat" services.
Types that call services are call clients.
Client types in flat services must be called with "Client" suffix.
Root client types in hierarchical services must be called with "Client" suffix.
Non-root client types in hierarchical services TBD (either must or must not).

Sure, I think that works fine if the 5th line allows us to call it BlockBlob instead of BlockBlobClient since it's a non-root client type in the conceptual hiearchy.

Architectural Board Decision: Hold off on this until user study data has confirmed details.

BOARD DECISION:

The current guidelines are ok.  (Storage is explicitly ok, per @tg-msft )
There is an issue around guidelines for things like ChangeFeedProcessor (cosmos) and EventProcessor (event hubs), TransferManager (Storage) that still need to be dealt with.
We should have a specific issue / discussion on where you CAN call Client
We should also have a specific issue on what other entry points (non-service-calling) can be called

For example, a Spring Repository implementation.


more request than an issue

can i request a feature please ?
when I open up Powershell core, if an update exists then i am advised by the "A new Powershell stable..." message. can you possibly add a Follow link option that does the update in the same vain as the https://aka.ms/PowerShell-... or make the "Upgrade now" in the second line of the banner text into a hot link to run the upgrade
I'm thinking something along the line's of a Thomas Maurer style one liner
e.g. iex "& { $(irm https://aka.ms/install-powershell.ps1) } -UseMSI"
Thanks Thomas for that one but having to search for "Thomas Maurer oneliner update powershell" is becoming tedious now

That's a good idea, but I think the better solution would be to implement an Update-PowerShell cmdlet, as proposed in #12678, which could then be mentioned in the notification message.

That's a good idea, but I think the better solution would be to implement an Update-PowerShell cmdlet, as proposed in #12678, which could then be mentioned in the notification message.

Current intention is #14217


Should the payload always be struct?

or class?

Hello! As with all things .Net memory management, the answer tends to come down to "maybe?" The general guidance we give is to start with struct. The logic behind it is that internally to Trill we batch data into groups of up to 80 thousand. Having the data co-located like that is likely to increase throughput at least a little. However, it's not free, because the initial batching will also need to copy the structs into the payload batch.


APT whitelist request for libdbus-1-dev

Duplicate of #434 and #66, would be nice to have it since I'm working on the Google's implementation of WebRTC, it requires some Chromium dependencies such as that one.

We expect this one to do test on D-Bus code in libpcap.

libdbus-glib-1-dev is dependent on libdbus-1-dev so there is a workaround. Until it gets fixed.

@Nonius Great, Thank you!


Inheritance check dataconverter

Depends on #90 for some CI tests. But this branch has reader tests failing. These can be handled here. Once #90 has been merged to master, I'll pull in the changes.

Pull Request Test Coverage Report for Build<PHONE_NUMBER>

171 of 179 (95.53%)  changed or added relevant lines in 5 files are covered.
1 unchanged line in 1 file lost coverage.
Overall coverage increased (+0.8%) to 56.717%

Changes Missing Coverage
Covered Lines
Changed/Added Lines
%

nexusutils/nexus/nexus.py
70
78
89.74%

Files with Coverage Reduction
New Missed Lines
%

nexusutils/nexus/nexus.py
1
74.26%

Totals

Change from base Build<PHONE_NUMBER>:
0.8%

Covered Lines:
4285

Relevant Lines:
7555

💛  - Coveralls


config: update version regex to support Go's initial minor releases

Go doesn't really follow semver here: the initial release of a new
minor series does not end with .0, which means there's no Go 1.16.0,
it's actually Go 1.16.
This is me trying to fix actions/setup-go#105, not sure if this is
correct.

wait nevermind this isn't the correct fix x)


fixed tenant information

The behavior of az account set has changed to now automatically change the active tenant.

Additional changes made are...

Rewrite of Terminology H2
BUllet list given to Change the active tenant H2
More examples using --query in Get subscription information H2
New Troubleshooting H2

@bebound , I went through several of the H2s and gave them a "freshness pass".  A list of updates is in the top comment of this PR.  Please rereview if you wish.


Upload sources to pypi

Right now pypi contains only wheel. Is it possible to upload sources as well?

Hi @RayeN , thanks for submitting an issue.
I have just uploaded to PyPi the 1.1.12 version containing both wheel and sources.


MINOR: Fix order of compression algorithms in upgrade note

LGTM.

Thanks for the patch. LGTM

Merged to trunk and 0.10.0.


support array_agg(distinct)

support array_agg(distinct)
What type of PR is this：

[ ] BugFix
[ ] Feature
[x] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Which issues of this PR fixes ：
support array_agg(distinct)
Problem Summary(Required) ：
StarRocks already support array_agg and array_distinct. However, if user want to implement array agg with distinct value, they need to use array_distinct(array_agg()). So the better way is to support DISTINCT in array_agg.
Checklist:

[x] I have added test cases for my bug fix or my new feature
[ ] This pr will affect users' behaviors
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

Bugfix cherry-pick branch check:

[ ] I have checked the version labels which the pr will be auto backported to target branch

[ ] 2.5
[ ] 2.4
[ ] 2.3
[ ] 2.2

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.


[Task - Server]: Create a terminate workflow API

Please add your planning poker estimate with Zenhub @nsarupr

Please add your planning poker estimate with Zenhub @nsarupr


Can you share the training code

Can you share the training code

We will publish the training code for ALIKED (the subsequent work of ALIKE, which we are working on). Then you can refer to the training code of ALIKED, they have the same training pipeline.

We will publish the training code for ALIKED (the subsequent work of ALIKE, which we are working on). Then you can refer to the training code of ALIKED, they have the same training pipeline.

when to release the training code of ALIKED?

Can you share the ALIKE training code? email<EMAIL_ADDRESS>Thanks a lot

Hi, could you please the training code with me as well?
<EMAIL_ADDRESS>Thanks!

Hi, could you share the training code with me as well?
<EMAIL_ADDRESS>Thank you in advance :)

Hi, could you share the training code with me as well?
<EMAIL_ADDRESS>Thank you in advance :)

Hi, could you share the training code with me as well?
<EMAIL_ADDRESS>Thank you in advance :)

Hi, could you share the training code with me as well?
<EMAIL_ADDRESS>Thank you in advance :)

Hi, could you share the training code with me as well?
<EMAIL_ADDRESS>Thanks!

Hi, could you share the training code with me as well?
<EMAIL_ADDRESS>Thank you very much!

Hi, could you please share the training code with me as well?
<EMAIL_ADDRESS>Thanks!

Please refer to https://github.com/Shiaoming/ALIKE/raw/main/assets/ALIKE_code.zip.


Migrate some jade to pug

since jade is rename to pug, we have lots of jade warnings when npm build/npm run dev. they are really annoying me.
so i fix them again.
this time i don't use a batch script to rename file names. but look for a minimized modification to prevent all warnings. each file i changed has been tested manually to see if the webpage has been changed. and i think now everything is fine.
i think this pr use minimized change to prevent every jade warnings

Looks like a great change! Haven't tested it locally, but read through and looks good.


add support for RedHat

If we get the tests running, would it still be merged?

@butlern please give a comment. Thanks! I'm currently using it from the fork...

yep, for sure. One note though and this might impact tests. I recently pushed changes to master which remove support for puppet3, vastly simplifying the test matrix. So the tests might just pass w/out any code changes if you rebase. However, if you need puppet3, that will be a problem.


Question: Pointing to an external stylecop.json file for header information

When using the rule SA1633, there is a stylecop.json file created/added to the project.  Is there a way to reference this file external to the project?  Meaning, if you have many projects/solutions over time, you would begin to get several stylecop.json files that define your header info.  This would create a maintenance issue on having to manually updating each stylecop.json when needing to update.
It would be nice to:

Reference a specific location knowing each project is generating consistent info.

It would also be nice to have another analyzer that could compare the current header with a specific stylecop.json to warn there are parts of the header missing and/or in addition to.
Is this possible with this project?
Good job team on the project's progress so far.  This has been very helpful.

We use the Add as Link functionality in Visual Studio to make sure the same stylecop.json file on disk is used by all of the projects.

It would also be nice to have another analyzer that could compare the current header with a specific stylecop.json to warn there are parts of the header missing and/or in addition to.

Could you provide an example of what you mean by this?

Thanks.  I think the Add as Link is what I was looking for.
So if the approach is to use Add as Link to stylecop.json (or preferably another specific file name based on certain projects I might have; blahstylecop.json), let's say I use the basic info in the header for a few projects.  Later, I add another variable to be included in the header (Created By, etc.).
This change would make future projects include the updated variables in header, but the older projects with headers would not.  So the question is, would it be possible to have an analyzer check if the file headers include the same variables that are set in the referenced stylecop.json file?  In this example, it would produce a warning stating the header didn't include createdBy.
Hope this helps explain a little better.  Thanks again for your time.


TiCon Smeltery Automation

So i'm trying to autocraft using the TiCon smeltery, I have most of it working but either i'm stupid, or TiCon isn't giving outputs like it should, or RS isn't seeing things like it should.
Playing Dungeons, Dragons, and Space Shuttles (1.12 pack).
In the pack, I want to make Terrax, it is made of 3 fluids, Jauxum, Karmesine, and Ovium.
Jauxum Ingot = 144mB
Karmesine Ingot = 144mB
Ovium Ingot = 144mB
1mB of each of the 3 creates 2mB of Terrax.
I have a pattern set up to do: 1 of each ingot when alloyed = 244mB of Terrax Fluid.
I put a crafter onto the smeltery controller, put the pattern in it, and requested terrax fluid, all good, everything works.
I put an external storage onto the smeltery drain, and I crafted a new pattern that takes 144mB of Terrax Fluid and turns it into 1 Terrax ingot, I put that pattern in another crafter and put it on a NuclearCraft ingot former, which turns the fluid into an ingot.
Now, when I request that the network makes a terrax ingot, it correctly deals with the smeltery, but it never sees the final terrax fluid in the smeltery (despite having an external storage), if I cancel the task and then tell it to make the ingot again, it correctly sucks out the fluid and sends it to the NC ingot former.
So it can see that the alloy is in the smeltery, it just can't see that it is in there during the overall task of going from 3 ingots to 1 alloy to 1 ingot.
Is there something i'm missing?

In autocrafting the output of the recipe needs to make its way into the network through an Importer or an Interface. Using an external storage will bypass that system.
Please do not use Github for anything that is not a bug. Join us on discord for discussion all around RS https://discordapp.com/invite/VYzsydb.

I don't understand Discord at all :( Have never used it before.


add java options to buildpack configuration

Didn't work, still have to specify the environment variables at runtime


Self Healing nodepools

Verified following:

[x]    Cluster created with cloud provider passed in (AWS). Check that the node is gone from Kubernetes only when it is removed from the cloud provider.
[x]   Cluster created without cloud provider option. Check at which point the node gets removed form Kubernetes.

Main concerns:

https://github.com/rancher/rancher/pull/13047
We are annotating all nodes on update now
https://github.com/rancher/rancher/pull/14617/files
We should not lose any performance

lgtm

lgtm

Issues https://github.com/rancher/rancher/issues/15737 https://github.com/rancher/rancher/issues/14184

It seems this PR will be able to address a lot problems in custom cluster with spot instance setup.
I don't see this commit in v2.2.7, just wondering if anyone know when it will get released?

New features are not generally backported.. this will be in 2.3.


MediaStore Uri not supported

Hi, i'm trying to use this library and it seems like a great work 👍
I want to download file to shared storage (Movies/myVideo.mp4). Currently Fetch supports file:///files/ and content://com.contentprovider.provider/ URIs.

file:///files/ this is for (app-private directories + getExternalStoragePublicDirectory)
content://com.contentprovider.provider/, i think this is for Files created by other apps + SAF (ask user file dir. location explicitly)

If app wants to create file on shared storage

< API 29, they have to use getExternalStoragePublicDirectory
>= API 29 they need to use MediaStore

When getting URI from MediaStore, it returns something like content://media/external/video/media/148 which does not work with Fetch. This line throws FileNotFoundException: No item at content://media/external/video/media/148
Starting from Android 11, only choices seem to be (to create file on shared storage)

Use MediaStore implicitly
Ask user to choose file location explicitly. (SAF)

Imho best way to deal with File/Uri:

Not using raw File
Not opening FileDescriptor unless necessary (e.g: reading size). You have to close it when done (here it is not closed)
Pass Uri till the end, then open InputStream/OutputStream using AssetFileDescriptor.AutoCloseOutputStream(contentResolver.openAssetFileDescriptor) (for file://, content://) or contentResolver.openOutputStream (for content://media/)

Same issue am trying to update my apps to supports android 11, but facing this issue for android 10, and 11, any quick solution ???

How i converted Uri to OutputStream.

@jemshit
Hi,
I have a same issue, would you please say that how did you solve this issue? I'll be thankful if you help me

@saeedata either download using okhttp without this library. Or use fetch to download to app private directory first, then copy to shared storage and delete temp file.

@jemshit yeah I thought about these answers. BTW, thank you so much bro.

I could integrate this library with Media store and sdk 30 without changing the library, Actually there are two bugs in the library, the first is in requesting to get storage permission in android 30, and the other is in creating file in Mediastore because the library seems that supports uri, however by implementing these problems in my app, I could integrate it with sdk 30.
I also want to say, as I checked and reviewed the library full code, I want to raise another bug that is: if you pause a downloading file and reinstall the app, the library doesn't check the file size  if it's available in path, download from the beginning.


RFC: consider dropping support for old MSYS/MinGW

If anyone sees this and is currently using winpty with old MSYS/MinGW (not MSYS2 or MinGW-w64), please let me know!
The old MSYS/MinGW environment is lacking relative to MSYS2/MinGW-w64 and MSVC in various ways.  It would be convenient for me if winpty did not support it anymore.
Issues with native compilation ("MinGW"):

winpty uses DACLs to secure its named pipes, and Windows provides functions to convert between SIDs/SDs and strings.  winpty doesn't actually use these functions (because they're slow), but it has convenience C++ wrappers for the APIs to aid in debugging.  MinGW (a) doesn't define the SD functions, (b) doesn't define SDDL_VERSION, and (c) defines ConvertStringSidToSidW incorrectly.  [src]

MinGW does not define the "LVB" console cell attributes.  [src1] [src2]

MinGW provides an swprintf matching VC6's prototype.  Unlike the other compilers, its swprintf doesn't conform to C99.  vsnprintf is provided, but requires passing -std=g++11 even though vsnprintf is part of C99 (and therefore C++11).  [src]

MinGW lacks PIPE_REJECT_REMOTE_CLIENTS. [src]

MinGW lacks MAPVK_VK_TO_VSC. [src]  [added 2017-01-31]

MinGW lacks the new version-checking APIs that MSVC and MinGW-w64 provide.[src]

Parallel make hangs -- parallel mingw32-make works better but tends to interleave output on a byte-by-byte basis.  [src]

Issues with the UNIX adapter ("MSYS"):

While the MinGW project updates its native-targeting (the "MinGW") toolchain, the MSYS-targeting toolchain is permanently locked at GCC 3.4.x, which lacks support for things like std::wstring and modern C++.

The native code uses pre-compiled headers, but the UNIX adapter must compile without them because MSYS GCC doesn't support them.

select can return EAGAIN.  Contemporary Cygwin/MSYS2 can return EINTR, but not EAGAIN.  [src]

At some point after MSYS forked Cygwin, the path conversion APIs were deprecated, and new ones were introduced.  The winpty UNIX adapter supports both APIs.  [src]

MSYS does not support the static-libstdc++ compiler option.  [src]

MSYS lacks the pipe2 API.  [commit]

Miscellaneous bugs in MSYS:

[cygwin_internal]
[mb<->wcs conversions]
[printf %ls]

MSYS errno isn't thread-local.  [added 2017-02-01]

MSYS lacks wcscpy and wcscat.  [added 2017-02-01]

I've noticed recently that MSYS winpty tends to crash:
rprichard@ATOM-W10 /c/rprichard/proj/winpty
$ ./build/winpty ls
error reading from internal wakeup pipe: error 0
      0 [sig] winpty 4908 open_stackdumpfile: Dumping stack trace to winpty.exe.stackdump
LICENSE   README.md    VERSION.txt  config.mk  misc  src          winpty.exe.stackdump
Makefile  RELEASES.md  build        configure  ship  vcbuild.bat
Aborted (core dumped)

I think this is a race condition involving errno -- read fails and sets errno to something, but errno is reset to 0 by another thread.  errno is thread-local on all non-obsolete systems.    To start, I'll probably omit the MSYS package from the next release.


Add command line parameters to start.sh

Maybe adding some ~parameters~ arguments like --no-fullscreen, --quality 90, --size 720x1280 and others could be quite useful.
Maybe this could have prevented #1 and #2.

Sure would be nice to have that, but this application was intended to run from the non-interactive environment. However, feel free to make PR


Remove event listener on document when the editor is removed.

This partially addresses https://github.com/Voog/wysihtml/issues/109
There're probably more leaks, but this one was producing lots of WRONG_DOCUMENT_ERR and was adding another listener each time an editor was created, which is quite unfortunate for a single page application.

:+1:


[libuv] Update to 1.43.0

Describe the pull request

What does your PR fix?
Updates libuv to 1.43.0

Which triplets are supported/not supported? Have you updated the CI baseline?
As before, Yes

Does your PR follow the maintainer guide?

Yes

LGTM, thanks for the update!