nan-only thresholding

This adds supporting for thresholding on nans. It surfaces some curious behavior/issue which still needs fixing.
@NicolasHug @ogrisel

It surfaces some curious behavior/issue which still needs fixing.

can you describe them?

The test I've added passes, but I think the test before that, needs to have n_bins_non_missing=9, but it fails with that (that's why I left the comment on your PR)

can you add a test for infinite values as input and see if we can still support them when we set the threshold to +- inf (hope it doesn't add too much code)

If we "split on nan", missing values go to the right node.
It is slightly confusing that a sample with missing value may go to the right child, despite missing_go_to_left being True. Ideally, only missing_go_to_left should decide where these samples go. We could get rid of the sample_goes_left function.
I think that this can be solved by scanning from right to left first, instead of the current version which is scanning from left to right first.

This test passes on the PR branch but fails here:
        ([8, 0, 1, 8, 2, 3, 4, 5, 6, 7],  # 8 <=> missing
         [1, 1, 1, 1, 5, 5, 5, 5, 5, 5],
         True,  # missing values
         8,  # n_bins_non_missing
         1,  # cut on bin_idx=1
         True),  # missing values go to left

Note that the missing bin is 8 here (not 9).
That seems like a regression

For some reason I can't push to your branch.
I fixed the previous issues and added a few more tests. I hope they make more sense and avoid confusion. Here's the patch.
diff --git a/sklearn/ensemble/_hist_gradient_boosting/splitting.pyx b/sklearn/ensemble/_hist_gradient_boosting/splitting.pyx
index f444248ae..b08b580e6 100644
--- a/sklearn/ensemble/_hist_gradient_boosting/splitting.pyx
+++ b/sklearn/ensemble/_hist_gradient_boosting/splitting.pyx
@@ -565,7 +565,7 @@ cdef class Splitter:
             Y_DTYPE_C sum_gradient_right
             Y_DTYPE_C negative_loss_current_node
             Y_DTYPE_C gain
-            unsigned int start = self.n_bins_non_missing[feature_idx] - 1
+            unsigned int start = self.n_bins_non_missing[feature_idx] - 2

         sum_gradient_right, sum_hessian_right = 0., 0.
         n_samples_right = 0
diff --git a/sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py b/sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py
index 859c6ccdb..77bae28a4 100644
--- a/sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py
+++ b/sklearn/ensemble/_hist_gradient_boosting/tests/test_splitting.py
@@ -286,10 +286,18 @@ def test_min_gain_to_split():
          3,  # expected_bin_idx
          'not_applicable'),

-        # We replace 2 samples by NaNs (bin_idx=9)
+        # We replace 2 samples by NaNs (bin_idx=8)
         # These 2 samples were mapped to the left node before, so they should
         # be mapped to left node again
         # Notice how the bin_idx threshold changes from 3 to 1.
+        ([8, 0, 1, 8, 2, 3, 4, 5, 6, 7],  # 8 <=> missing
+         [1, 1, 1, 1, 5, 5, 5, 5, 5, 5],
+         True,  # missing values
+         8,  # n_bins_non_missing
+         1,  # cut on bin_idx=1
+         True),  # missing values go to left
+
+        # same as above, but with non-consecutive missing_values_bin
         ([9, 0, 1, 9, 2, 3, 4, 5, 6, 7],  # 9 <=> missing
          [1, 1, 1, 1, 5, 5, 5, 5, 5, 5],
          True,  # missing values
@@ -297,7 +305,15 @@ def test_min_gain_to_split():
          1,  # cut on bin_idx=1
          True),  # missing values go to left

-        # Same, this time replacing 2 samples that were on the right.
+        # this time replacing 2 samples that were on the right.
+        ([0, 1, 2, 3, 8, 4, 8, 5, 6, 7],  # 8 <=> missing
+         [1, 1, 1, 1, 5, 5, 5, 5, 5, 5],
+         True,  # missing values
+         8,  # n_bins_non_missing
+         3,  # cut on bin_idx=3 (like in first case)
+         False),  # missing values go to right
+
+        # same as above, but with non-consecutive missing_values_bin
         ([0, 1, 2, 3, 9, 4, 9, 5, 6, 7],  # 9 <=> missing
          [1, 1, 1, 1, 5, 5, 5, 5, 5, 5],
          True,  # missing values
@@ -368,21 +384,40 @@ def test_splitting_missing_values(X_binned, all_gradients,
     'X_binned, all_gradients, has_missing_values, n_bins_non_missing, '
     ' expected_bin_idx, split_is_nan, expected_go_to_left', [

-        ([0, 1, 2, 3, 7, 8, 9, 9, 9, 9],  # 9 <=> missing
+        ([0, 1, 2, 3, 4, 5, 6, 6, 6, 6],  # 6 <=> missing
          [1, 1, 1, 1, 1, 1, 5, 5, 5, 5],
          True,  # missing values
-         9,  # n_bins_non_missing
-         8,  # cut on bin_idx=max_bins - 1
+         6,  # n_bins_non_missing
+         5,  # cut on bin_idx=max_bins - 1
          True,  # split_is_nan
          False),  # missing values go to right

-        ([9, 9, 9, 9, 9, 9, 1, 3, 8, 6],  # 9 <=> missing
+        # same as above, but with non-consecutive missing_values_bin
+        ([0, 1, 2, 3, 4, 5, 9, 9, 9, 9],  # 9 <=> missing
          [1, 1, 1, 1, 1, 1, 5, 5, 5, 5],
          True,  # missing values
-         9,  # n_bins_non_missing
-         8,  # cut on bin_idx=max_bins - 1
+         6,  # n_bins_non_missing
+         5,
          True,  # split_is_nan
          False),  # missing values go to right
+
+        ([4, 4, 4, 4, 4, 4, 0, 1, 2, 3],  # 4 <=> missing
+         [1, 1, 1, 1, 1, 1, 5, 5, 5, 5],
+         True,  # missing values
+         4,  # n_bins_non_missing
+         3,  # cut on bin_idx=max_bins - 1
+         True,  # split_is_nan
+         False),  # missing values go to right
+
+        # same as above, but with non-consecutive missing_values_bin
+        ([9, 9, 9, 9, 9, 9, 0, 1, 2, 3],  # 9 <=> missing
+         [1, 1, 1, 1, 1, 1, 5, 5, 5, 5],
+         True,  # missing values
+         4,  # n_bins_non_missing
+         3,  # cut on bin_idx=max_bins - 1
+         True,  # split_is_nan
+         False),  # missing values go to right
+
     ]
 )
 def test_splitting_missing_values_edge_case(
@@ -433,5 +468,6 @@ def test_splitting_missing_values_edge_case(
     samples_left, samples_right, _ = splitter.split_indices(
         split_info, splitter.partition)

-    nan_idx = np.flatnonzero(np.array(X_binned) == n_bins_non_missing)
-    assert set(samples_right) == set(nan_idx)
+    missing_samples_indices = np.flatnonzero(
+        np.array(X_binned) == missing_values_bin_idx)
+    assert set(samples_right) == set(missing_samples_indices)

Awesome, thanks @NicolasHug! @ogrisel had some ideas for some other tests, but I guess we can merge this into your branch now, and continue the discussion on the main PR?

Cool yeah I'll merge


🧙 [Shard Request] -

Shard Name
UO Elemental
Shard admins
Mrrrr#7156 , UO Elemental#3054
Shard ip/port
login.uoelemental.com
Shard description
UO Elemental is a Latin American server with 2 years ONLINE.
We use ServUO but limited to the ML version, with some newer expansion features.
We also have our own customizations on the map and dungeons.
Always encouraging the use of Classic UO: recently we have removed access to old clients directly from our Launcher.
We will always bet on this beautiful project!
Shard type
PvM, PvP
Shard era
ML
What customisations does your shard currently have?
Assets (modified UOP/MUL etc)
Link to shard files
https://drive.google.com/file/d/1o8PvX2TUP_CRnIPwWiFWyv7Ur4iAYovU/view?usp=sharing
Version used for the basis of you shard files
<IP_ADDRESS>
List of modified UO assets
We have modified all the files, Gumps, Clilocs, Muls, Everything.

We have a launcher created by Vorspire, we configure and the players update directly.

LINK Launcher: http://uoelemental.com/descargas/Elemental.exe

ClassicUO Customisations
No CUO Customisations
Comments/Requests
Thanks for everything!!
Code of Conduct

[X] I agree to be patient and acknowledge that the CUO devs are working on their own free time to help me.

we have many custom things!

Hi! Thanks very much! I think there is a problem with some file.

some things don't look right, maybe missing gumpartLegacyMUL.uop or artLegacyMUL.uop?


[RNN] models cannot run in TFLite with delegates

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Qualcomm Snapdragon 865
TensorFlow installed from (source or binary): Source
TensorFlow version (or github SHA if from source): Nightly

Command used to run the converter or code if you’re using the Python API
If possible, please share a link to Colab/Jupyter/any notebook.
tf_model = tf.keras.models.load_model('./my_model.h5')

for i in range(4):
    tf_model.inputs[i].shape._dims[0] = tf_python.framework.tensor_shape.Dimension(1)

model_func = tf.function(lambda a: tf_model(a))
concrete_func = model_func.get_concrete_function([tf.TensorSpec(tf_model.inputs[0].shape, tf_model.inputs[0].dtype), tf.TensorSpec(tf_model.inputs[1].shape, tf_model.inputs[1].dtype), tf.TensorSpec(tf_model.inputs[2].shape, tf_model.inputs[2].dtype), tf.TensorSpec(tf_model.inputs[3].shape, tf_model.inputs[3].dtype)])

tf_out = concrete_func([input_1, gru0_1_h_in, gru1_1_h_in, out_quats_gru1_h_in])
converter = tf.lite.TFLiteConverter.from_concrete_functions([concrete_func])
tflite_model = converter.convert()

The output from the converter invocation
2021-01-14 11:16:28.325520: I tensorflow/core/grappler/optimizers/meta_optimizer.cc:933] Optimization results for grappler item: graph_to_optimize
  function_optimizer: Graph size after: 389 nodes (195), 590 edges (225), time = 6.75ms.
  function_optimizer: Graph size after: 389 nodes (0), 590 edges (0), time = 3.64ms.
Optimization results for grappler item: while_body_2339
  function_optimizer: function_optimizer did nothing. time = 0.004ms.
  function_optimizer: function_optimizer did nothing. time = 0.001ms.
Optimization results for grappler item: while_cond_2338
  function_optimizer: function_optimizer did nothing. time = 0.004ms.
  function_optimizer: function_optimizer did nothing. time = 0.001ms.
Optimization results for grappler item: while_cond_2708
  function_optimizer: function_optimizer did nothing. time = 0.003ms.
  function_optimizer: function_optimizer did nothing. time = 0ms.
Optimization results for grappler item: while_body_2709
  function_optimizer: function_optimizer did nothing. time = 0.003ms.
  function_optimizer: function_optimizer did nothing. time = 0.001ms.
Optimization results for grappler item: while_body_1969
  function_optimizer: function_optimizer did nothing. time = 0.003ms.
  function_optimizer: function_optimizer did nothing. time = 0.001ms.
Optimization results for grappler item: while_cond_1968
  function_optimizer: function_optimizer did nothing. time = 0.003ms.
  function_optimizer: function_optimizer did nothing. time = 0.002ms.

2021-01-14 11:16:28.851727: W tensorflow/compiler/mlir/lite/python/tf_tfl_flatbuffer_helpers.cc:332] Ignored output_format.
2021-01-14 11:16:28.851756: W tensorflow/compiler/mlir/lite/python/tf_tfl_flatbuffer_helpers.cc:335] Ignored drop_control_dependency.
2021-01-14 11:16:28.895692: I tensorflow/compiler/mlir/tensorflow/utils/dump_mlir_util.cc:194] disabling MLIR crash reproducer, set env var `MLIR_CRASH_REPRODUCER_DIRECTORY` to enable.

Also, please include a link to the saved model or GraphDef
My Keras model contains a GRU layer, here is what the Keras layer converts to in TFLite:

![Screenshot from 2021-01-14 06-12-45](https://user-images.githubusercontent.com/67419721/104586228-348e6480-5633-11eb-9558-047cd559280b.png)

Failure details
Model conversion was successful. and runs on CPU. However, when I try to initialize an OpenCL delegate, I get the following run time error:
ERROR: Attempting to use a delegate that only supports static-sized tensors with a graph that has dynamic-sized tensors.
interpreter->ModifyGraphWithDelegate failed
I suspect the problem is with those While ops generated by the converter. My GRU layer is stateless, where I manually manage the layer state (tf.keras.layers.GRU is defined with arguments: return_sequences=True, stateful=False, unroll=False. It is called with one of the model's inputs passed to the initial_state argument), and with the sequence dimension of 1. Is it possible to tell the TFLite converter to generate a graph that doesn't contain a while loop? Since in my situation I don't actually need to have a loop in my GRU.
RNN conversion support
If converting TF RNN to TFLite fused RNN ops, please prefix [RNN] in the title.
Any other info / logs
Include any logs or source code that would be helpful to diagnose the problem. If including tracebacks, please include the full traceback. Large logs and files should be attached.

Yeah, this is a question to the TFLiteConverter folks.  Un-assigning myself.

Yeah, this is a question to the TFLiteConverter folks.  Un-assigning myself.

Hi, I think our gpu delegate does not support control flow yet, you probably can try with unroll the GRU.
thanks

Hi, I think our gpu delegate does not support control flow yet, you probably can try with unroll the GRU.
thanks

Hi, have you tried GRU with unroll?

I ended up breaking up the GRU layer into its constituent matrix and elementwise ops. Closing this issue as I have found a workaround.


Concatenate / Combine JS

I am new to webpack and i'm trying to figure out to to concat/combine JS files. I see a few plugins that can be used but I cant figure out how to fit it into the Tonik workflow. Any guidance would be appreciated!

When working with javascript ES6 you have to structure your js files a little differently. An overall workflow can be roughly compared to SASS. You have one main file where you import all other used components and this single main file is passed to the webpack to be compiled.
Of course, you can have multiple main files which import different components.
You give really a little description what you want to achieve, so I can't give you any of concrete recommendations.

Thanks for the help. I understand the modular part of ES6 but not how to combine third party JS libraries. Say i'm using Foundation, Fontawesome. and ScrollMagic. Right now the JS folder looks like:
app.js
foundation.js
fontawesome.js
scrollmagic.js
Is there a way to "import" those third party scripts into the main app.js?

Another way to ask this question:
How can we have webpack output two files:
app.js
vendor.js
Where vendor.js is one file that concats all the third party libraries. My concern is to limit the amount of HTTP requests if we are using a large number of libraries. (My impression is many libraries can't be imported/required with ES6 i.e. Foundation)

You can create a single file for third party libraries and import them as modules inside. It sometimes gets a little tricky because not all scripts support ES6.
Then you can register these files in config/app.json in assets property. Items listed here will be outputted as separated files. More info in docs
Offcourse you can customize webpack config to your needs. It's impossible to cover every use case from the start.

Thanks again, the problem i was running into was the scripts i was using aren't es6 compatible so i was not able to import/export them in app.js. The answer was simple:
  "assets": {
    "app": [
        ...
    ],
    "vendor": [
      "./resources/assets/js/foundation.js",
      "./resources/assets/js/fontawesome.js",
      "./resources/assets/js/scrollMagic.js",
    ]
  },


Not updating the pr with a comment

Hi
I used pipeline scan action in my github workflow as below and when I am using it with 'fail_on_severity' option it will not show any output in pipeline it self or as a comment in PR
Here is my github workflow
- name: pipeline-scan action step
id: pipeline-scan
uses<EMAIL_ADDRESS>with:
vid: ${{ secrets.VID }}
vkey: ${{ secrets.VKEY }}
file: "file.zip"
fail_on_severity: 'true'
If I run without fail_on_severity: 'true' it will add a comment to pr like this

The syntax for fail_on_severity according to the documentation in action.yaml is:
fail_on_severity:
    description: 'Fail the pipeline job if the scan finds flaws of the specified severities. Enter a comma-separated list of severities in quotation marks.'

So, if you want the build to fail only when High or Very High issues are found, you'd do this:
- name: 🛡 Run Veracode Pipeline Scan
        uses<EMAIL_ADDRESS>        with:
          vid: ${{ secrets.VID }}
          vkey: ${{ secrets.VKEY }}
          file: app.zip
          fail_on_severity: "Very High, High"
          fail_build: true

However, there's currently a parsing bug and fail_on_severity doesn't work. I have PR #30 for it.


[Helm] Initializer pod remains and becomes OutOfSync in Argo CD

Hi.
I'm using DefectDojo Helm chart and deploy it via Argo CD
Whenever it’s synchronized on Argo CD, initializer pod starts up
The pod remains after the job completion, so when it gets synchronized again, it generates another job pod and that makes the old job pod OutOfSync
I tried adding Argo CD resource hook annotations, but the chart doesn’t allow me to change metadata.annotations of the initializer job
(Although spec.template. metadata.annotations are customizable)
There are a few solutions I can think of

Add Helm chart hooks to the job
Enable to customize metadata.annotations of the job

Thanks in advance!

Hi @ryok-0319 I have a the same problem with our deployment, can you see if my change would fix it ?

Thank you for your PR!
I think something like that would work, but I'm wondering if it's ok to add something like this
"helm.sh/hook": post-install,post-upgrade

ref: https://helm.sh/docs/topics/charts_hooks/#the-available-hooks

And would we want to add this as well:
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
?
Or would we leave the default “before-hook-creation” behavior and add the “optional” argoCD hooks for those that use it.
From: ryok-0319 @.>
Date: Wednesday, 17 August 2022 at 10:32
To: DefectDojo/django-DefectDojo @.>
Cc: Lars Meijers @.>, Comment @.>
Subject: Re: [DefectDojo/django-DefectDojo] [Helm] Initializer pod remains and becomes OutOfSync in Argo CD (Issue #6727)
Thank you for your PR!
I think something like that would work, but I'm wondering if it's ok to add something like this
"helm.sh/hook": post-install,post-upgrade
ref: https://helm.sh/docs/topics/charts_hooks/#the-available-hooks
—
Reply to this email directly, view it on GitHubhttps://github.com/DefectDojo/django-DefectDojo/issues/6727#issuecomment-1217682544, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ATBZOAQ4FI5QI6SKQUQN4CTVZSPQ7ANCNFSM56XZ3A6Q.
You are receiving this because you commented.Message ID: @.***>

Thank you!
Having jobAnnotations should be enough, let me close this issue


eager scatter_nd forward works with incorrect code

System information

Have I written custom code (as opposed to using a stock example script provided in TensorFlow):
code, see below
OS Platform and Distribution (e.g., Linux Ubuntu 16.04):
OSX 10.12.6
TensorFlow installed from (source or binary):
binary
TensorFlow version (use command below):
v1.7.0-3-g024aecf414 1.7.0
Python version:
3.6.1
CUDA/cuDNN version:
NA
GPU model and memory:
NA
Exact command to reproduce:
see code below

Source code / logs
import tensorflow as tf
import tensorflow.contrib.eager as tfe

tfe.enable_eager_execution()

x_var = tfe.Variable(tf.random_uniform([10]))
y_var = tfe.Variable(tf.random_uniform([10]))

with tfe.GradientTape() as tape:
    dot = tf.scatter_nd(indices=[0],  # this should be indices=[[0]]
                        updates=[tf.einsum('i,i->', x_var, y_var)],
                        shape=[1])
print(dot)
gradient = tape.gradient(dot, [x_var, y_var])
print(gradient)

Error traceback:
Traceback (most recent call last):
  File "/Users/m/workspace/bug/experimental/bug.py", line 31, in <module>
    gradient = tape.gradient(dot, [x_var, y_var])
  File "/Users/m/workspace/bug/venv/lib/python3.6/site-packages/tensorflow/python/eager/backprop.py", line 764, in gradient
    output_gradients=output_gradients)
  File "/Users/m/workspace/bug/venv/lib/python3.6/site-packages/tensorflow/python/eager/imperative_grad.py", line 65, in imperative_grad
    tape._tape, vspace, target, sources, output_gradients, status)  # pylint: disable=protected-access
  File "/Users/m/workspace/bug/venv/lib/python3.6/site-packages/tensorflow/python/eager/backprop.py", line 141, in grad_fn
    op_inputs, op_outputs, orig_outputs)
  File "/Users/m/workspace/bug/venv/lib/python3.6/site-packages/tensorflow/python/eager/backprop.py", line 109, in _magic_gradient_function
    return grad_fn(mock_op, *out_grads)
  File "/Users/m/workspace/bug/venv/lib/python3.6/site-packages/tensorflow/python/ops/array_grad.py", line 39, in _PackGrad
    return array_ops.unstack(grad, num=op.get_attr("N"), axis=op.get_attr("axis"))
  File "/Users/m/workspace/bug/venv/lib/python3.6/site-packages/tensorflow/python/ops/array_ops.py", line 1084, in unstack
    return gen_array_ops.unpack(value, num=num, axis=axis, name=name)
  File "/Users/m/workspace/bug/venv/lib/python3.6/site-packages/tensorflow/python/ops/gen_array_ops.py", line 8741, in unpack
    _six.raise_from(_core._status_to_exception(e.code, message), None)
  File "<string>", line 3, in raise_from
tensorflow.python.framework.errors_impl.InvalidArgumentError: axis = 0 not in [0, 0) [Op:Unpack] name: unstack

Describe the problem
This is erroneous code which runs half-way. It will still calculate the forward pass, but fail on the backward pass. This does not happen with static graph tensorflow, where you get a correct error that tensor shapes are not matching.

Thank you for your post. We noticed you have not filled out the following field in the issue template. Could you update them if they are relevant in your case, or leave them as N/A? Thanks.
Bazel version

It has been 14 days with no activity and the awaiting response label was assigned. Is this still an issue?

Checked tf1.8, it's still there.


502 Error on Lambda

Hi,
i have a Problem, when i deploy the project to my aws account.
Local -> Everything works fine.
AWS -> i get back 502 Internal Server Error.
When i test the AWS Lambda in the online console i get:
Execution log for request test-request Sun May 07 00:24:12 UTC 2017 : Starting execution for request: test-invoke-request Sun May 07 00:24:12 UTC 2017 : HTTP Method: POST, Resource Path: /graphql Sun May 07 00:24:12 UTC 2017 : Method request path: {} Sun May 07 00:24:12 UTC 2017 : Method request query string: {} Sun May 07 00:24:12 UTC 2017 : Method request headers: {} Sun May 07 00:24:12 UTC 2017 : Method request body before transformations: {viewer{id}} Sun May 07 00:24:12 UTC 2017 : Endpoint request URI: https://lambda.eu-central-1.amazonaws.com/2015-03-31/functions/arn:aws:lambda:eu-central-1:000000000:function:serverless-myapp-production-api/invocations Sun May 07 00:24:12 UTC 2017 : Endpoint request headers: {x-amzn-lambda-integration-tag=test-request, Authorization=*******************************************************************************************************************************************************************************************************************************************************************************************************************************************39966f, X-Amz-Date=20170507T002412Z, x-amzn-apigateway-api-id=000000000, X-Amz-Source-Arn=arn:aws:execute-api:eu-central-1:000000000:wmxk0au92f/null/POST/graphql, Accept=application/json, User-Agent=AmazonAPIGateway_wmxk0au92f, X-Amz-Security-Token=000000000 [TRUNCATED] Sun May 07 00:24:12 UTC 2017 : Endpoint request body after transformations: {"resource":"/graphql","path":"/graphql","httpMethod":"POST","headers":null,"queryStringParameters":null,"pathParameters":null,"stageVariables":null,"requestContext":{"accountId":"000000000","resourceId":"000000000","stage":"test-invoke-stage","requestId":"test-invoke-request","identity":{"cognitoIdentityPoolId":null,"accountId":"000000000","cognitoIdentityId":null,"caller":"000000000","apiKey":"test-invoke-api-key","sourceIp":"test-invoke-source-ip","accessKey":"abcd","cognitoAuthenticationType":null,"cognitoAuthenticationProvider":null,"userArn":"arn:aws:iam::00000:user/abcd","userAgent":"Apache-HttpClient/4.5.x (Java/1.8.0_112)","user":"000000000"},"resourcePath":"/graphql","httpMethod":"POST","apiId":"000000000"},"body":"{viewer{id}}","isBase64Encoded":false} Sun May 07 00:24:13 UTC 2017 : Endpoint response body before transformations: {"errorMessage":"RequestId: 000000000 Process exited before completing request"} Sun May 07 00:24:13 UTC 2017 : Endpoint response headers: {x-amzn-Remapped-Content-Length=0, x-amzn-RequestId=000000000, Connection=keep-alive, Content-Length=107, X-Amz-Function-Error=Unhandled, Date=Sun, 07 May 2017 00:24:12 GMT, X-Amzn-Trace-Id=root=000000000;sampled=0, Content-Type=application/json} Sun May 07 00:24:13 UTC 2017 : Execution failed due to configuration error: Malformed Lambda proxy response Sun May 07 00:24:13 UTC 2017 : Method completed with status: 502
Any ideas?
My api folder is pretty the same, as in the example - i only changed the s3 bucket and the region in my serverless.yaml
Greetings
Tobias

hey Tobias, sadly I don't know that issue and don't have an idea why it's happening :(

+1
Managed to solve this using
    events:
         - http:
             path: purchase
             method: post
             cors: true
             integration: LAMBDA <----- // this is what fixed it

This leads me to believe that it is to do with the lambda proxy expecting a different response.
And therefore getting a malformed lambda proxy response error.

Same error for me, changing the integration: LAMBDA throws an error for me:
{
    "errorMessage": "RequestId: 4fa0da14-82c1-11e7-bd64-4f290e9f76d3 Process exited before completing request"
}

I followed this article and seems to be working http://davin.ninja/using-aws-lambda-with-amazon-api-gateway/
The key point is not using callback(null, createResponse(200, response)))

@jona7o good to go?

If a method is  Lambda proxy integration  then the response body is expected to be JSON object. I had the same issue as I was using JSON.stringify(result) where result was a JSON object.  I don't explicitly specify the integration on the serverless.yml  however test run on aws shows :100:
Endpoint request headers: {x-amzn-lambda-integration-tag=test-request
After changing request to result my method started working for the endpoints:
  logger.debug(typeof result); //  Object
  logger.debug(typeof JSON.stringify(result));  // string

  const repsonse = {
    statusCode: 200,
    headers: {
      "Access-Control-Allow-Origin" : "*",
      "Access-Control-Allow-Credentials" : true
    },
    body: result

I suggest to add @kevupton's solution as a big red flag somewhere and in the official examples for simple http endpoints. I spent nearly 5 hours debugging this CORS issue.

+1
Managed to solve this using
    events:
         - http:
             path: purchase
             method: post
             cors: true
             integration: LAMBDA <----- // this is what fixed it

This leads me to believe that it is to do with the lambda proxy expecting a different response.
And therefore getting a malformed lambda proxy response error.

I use python as a runtime for Lambda. I got the same error and once I added integration: LAMBDA it worked.
So any idea how can I handle this with Lambda-proxy?

Can someone please tell me where do I add this integration lambda? I'm facing the same problem here. My template is
  UserDetailFunction:
    Type: AWS::Serverless::Function
    Properties:
      Description: "User Detail Fetch, Update, Check Api"
      CodeUri: ./user_detail
      Handler: main.lambda_handler
      Runtime: python3.8
      FunctionName: !Sub "UserDetail-${AppName}"
      PackageType: Zip
      Timeout: 60
      Policies:
        - DynamoDBCrudPolicy:
            TableName: !Ref PatientProfileTable
        - DynamoDBCrudPolicy:
            TableName: !Ref DoctorProfileTable
        - DynamoDBCrudPolicy:
            TableName: !Ref ClinicProfileTable
        - DynamoDBCrudPolicy:
            TableName: !Ref UserTable
      Environment:
        Variables:
          DOCTOR_PROFILE_TABLE_NAME: !Ref DoctorProfileTable
          CLINIC_PROFILE_TABLE_NAME: !Ref ClinicProfileTable
          PATIENT_PROFILE_TABLE_NAME: !Ref PatientProfileTable
          USER_TABLE_NAME: !Ref UserTable
          SEARCH_ENDPOINT: !ImportValue "SearchEndpoint"
      Events:
        UserDetailUpdate:
          Type: Api
          Properties:
            RestApiId: !Ref Api
            Path: /user/{user_id}
            Method: PUT
            RequestParameters:
              - method.request.header.Authorization
        UserDetailFetch:
          Type: Api
          Properties:
            RestApiId: !Ref Api
            Path: /user/{user_id}
            Method: GET
            RequestParameters:
              - method.request.header.Authorization
        UserDetailCheck:
          Type: Api
          Properties:
            RestApiId: !Ref Api
            Path: /user/detail/{user_id}
            Method: GET
            RequestParameters:
              - method.request.header.Authorization


DOC: Remove caveat on maximum_bipartite_matching

The original wording was created when maximum_bipartite_matching still only solved a certain special case of the general maximum matching problem; since this is no longer the case with GH #10641, there's no reason to leave the caveat in the documentation here.

Merged, thanks @fuglede.
CI failures were unrelated, not sure what this is about - looks very odd:
____________________________ test_isolve_gmres[COO] _______
...
E   pkg_resources.ContextualVersionConflict: (numpy 1.14.6 (/home/travis/virtualenv/python3.6.7/lib/python3.6/site-packages), Requirement.parse('numpy>=1.15'), {'numba'})

@fuglede thanks for continuing to improve the csgraph module, much appreciated!


[Key Vault] Generate Certs code for 7.6-preview.1, add basic support

Description
Part of https://github.com/Azure/azure-sdk-for-python/issues/35252. This PR regenerates code for the new 7.6-preview.1 API version, wires up the version (without any new features) to the client, and updates metadata and tests. Future PRs will add support for new features.
All SDK Contribution checklist:

[x] The pull request does not introduce [breaking changes]
[x] CHANGELOG is updated for new features, bug fixes or other significant changes.
[x] I have read the contribution guidelines.

General Guidelines and Best Practices

[x] Title of the pull request is clear and informative.
[x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

[x] Pull request includes test coverage for the included changes.

API change check
APIView has identified API level changes in this PR and created following API reviews.
azure-keyvault-certificates


The bullet position is incorrect in the Chiappa Rhino

Describe the bug
The bullet position is incorrect in the Chiappa Rhino
Reproducibility

[X] I reproduced this issue with as few other mods as possible installed.
[ ] I am unable to reproduce this issue consistently.

Screenshots and/or videos
No response
Logs
no logs
Debug Logs
No response
Crash Reports
No response
MWC Version
0.1.3
Forge Version
1.12.2 forge <IP_ADDRESS>60
Red Core Version
0.6 dev 3
MixinBooter Version
9.1
Java Version
1.8
Java Virtual Machine
Hotspot
Operating System
windows 11
GPU Vendor
NVIDIA
Code of Conduct

[X] I agree to follow this project's Code of Conduct

https://github.com/Cubed-Development/Modern-Warfare-Cubed/assets/130232431/e2530910-d6bc-4f59-a3f6-3f8f9fce3fa8

Please do not provide feedback on V1 weapon issues, all V1 weapons will be redone


ipam/allocator: set missing v4 or v6 podCIDR in CiliumNode

In case the user has a CiliumNode running without a v4 podCIDR and
enables IPv6 the cilium-operator should start giving v6 podCIDRs to
nodes without a v6 podCIDR.
Fixes: 30c0d1a70a85 ("pkg/ipam: allocate CiliumNode podCIDR once all CiliumNodes are synced")
Signed-off-by: André Martins<EMAIL_ADDRESS>

test-me-please

revoking my LGTM it needs a couple updates

Coverage increased (+0.006%) to 37.151% when pulling 00635a77a0b5becda505f6cf14b7e5c54996fb71 on aanm:pr/set-addresses-for-running-pods into 93d32ddf211a157f33a73731f2ab02ae8c69a721 on cilium:master.

blocking as John will be working on this

tested and fix is working now. Thanks! .. reinstate LGTM ;)

test-me-please

@aanm missed a test case it looks like,
vet: pkg/ipam/allocator/podcidr/podcidr_test.go:1153:24: cannot initialize 2 variables with 3 values

test-me-please

@jrfastab added


meta:preference value

Preferred Vertical Rate united with the frame width and height makes a Constraint Set and SHOULD have a urn:x-nmos:cap:meta:preference value [of] 50

Why recommend fifty? BCP-004-01 allows values between -100 and 100, vs. a default of 0, so that an implementation has a concise way to indicate a preference for or against a small proportion of its Constraint Sets.

Preferred Vertical Rate should become grain_rate.

And then I guess it should say something like: The Preferred Vertical Rate SHOULD be indicated by using a higher urn:x-nmos:cap:meta:preference value in constraint set(s) describing this value vs. other Supported Vertical Rates.


Fix #3659 regression introduced in #3832

PR #3832 caused a partial regression on #3659: despite splitting Qt-dependent code into separate instances of the drawing libraries, it reverted the MolDraw2D Python wrappers to be linked against Qt GUI libraries, which is not desired.
Also, Code/GraphMol/MolDraw2D/Qt/Wrap/CMakeLists.txt is only used if Qt support is enabled, so no need for the extra check.

thanks for catching and fixing that @ricrogz


added support for JumpCloud tags

added support for JumpCloud tags. tested with create, update, delete and import.
currently only the name field is supported.

Hi, don't merge this yet, there's an issue with it, I'm looking into it.

Ok, basically there's a bug when you import a tag.  It imports successfully but if you then execute a subsequent "terraform apply" it will try to destroy and recreate it and fail.
I'm not sure why yet, everything else works as intended eg if you create the tag initially with terraform and re-execute apply there's no problem.

Not sure why this is happening.  This is the state after an import:
http://a.rkw.io/terraform.tfstate.json
and this is after a subsequent terraform apply that destroys and recreates the tag:
http://a.rkw.io/terraform.tfstate-2.json
(This is after a local change to ReadTag to remove the additional fields other than "name").
Main differences seem to be:
The "path" is different after the apply
The "provider" gets changed from "jumpcloud" to a blank string after the apply


Log GraphQLErrors automatically

The new errors returned in const {data, errors} = await storefront.query(...) are likely to be missed because they are not breaking the flow.
This PR adds an auto-logger for this type of error and enhances it with the query name.

Aside from that, I realized we were not showing the GraphiQL link anymore for this kind of error. This is fixed now:

like this https://github.com/Shopify/hydrogen/pull/1729

@wizardlyhel What about boolean | ((error: Error) => boolean)? I can revert it if it's no good 👍


SEARCH - display only nodes matching the search query (hide others)

I'm using SEARCH -> nodes are highlighted - Is there a possibility to hide all other leaves?
When I have very large tree and I'm searching if particular node - all others that do not match the search query are obscuring the view. (imagine that I have tens or hundreds nodes that do not fit into one screen - it is not easy to identify parents)
Thank you

@szilderus  you can kind of get around this issue by utilizing searchFinishCallback and storing the filtered values in a separate state from the treeData and replace treeData with the filteredDate if there is filtered values

@szilderus @fritz-c Ill work on this over the weekend :)

@szilderus @lifejuggler added in #256!

Thanks for adding this but what I've ment is something little bit different - imagine for example that you have 'needle' in the list of 1000 'hay' elements that are ON THE SAME LEVEL - you need to scroll 1000 elements to view the 'needle'. Is it possible to HIDE all 'hay' elements? And leave on the tree only 'needles'. Display only branches that contains 'needle'.
Regards!

@szilderus yeah, hide-no-matching-node not close-no-matching-node, this is really useful for tree search with large nodes, I have more than 8000 nodes in my project

Hi Guys! Do you have any plans/updates on this feature? It's pretty useful.


scrollParentSelector optional

Hello,
I think it would be better to define this property as optional, because sometimes, you will want to use the parent of parent or something else.
I just ran into the case where the ngx-image-zoom is inside a nested and collapsable div inside a modal. When the div is opened, the scrollbar appears and the zoom position is wrong when I scroll down.
Good job though!

This looks like it should be a safe enough addition, being an optional addition. I just want to play around with it a bit before merging it. I got lots of travels this month but hopefully in December I'll get a chance to revisit this project.

Merging this but I will overwrite all the files since I had to restructure the module some to get it working nicely in my dev environment. But I'll merge so you get the contributor flag as I've incorporated most of the things done in this PR in the new files.

Thank you for your contribution!

Hi @tkint - I just released a beta version 0.6.0 to npm where I rewrote a big chunk of how I calculate the zooming position. This update removed th eneed for the scrollParentSelector completely. Would you mind giving it a test and see if it works in your use case as well and let me know?


Creating the concept of RedirectChannel and use it before the DefaultChannel when we are redirecting the user

Summary
Change the concept of DEFAULT_CHANNEL to RedirectChannel
Ticket Link
MM-14639
Device Information
This PR was tested on: [Device name(s), OS version(s)]

This issue has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!
/cc @jasonblais @hanzei


use signed transaction with chainID of 0 for local deployment instead of private key

abandoned because requires hardcoding gasPrice => recommend switching to alternative universal deploy method


The demo included does not work on Firefox 34.0.5

I downloaded the zip, and it seems like the polyfill doesn't get activated for Firefox.

Closing this now as initial bug isn’t reproducible and IE bug has its own issue.


Allow register indices in addition to ABI names

This PR is for issue #51.
I have added a function to parse the arguments of an instruction, that is used to canonicalize the register names. This function could be expanded to do other things with the arguments in the future, if needed.
The canonicalization is done using a dict, that is used replace register-index-names with the according ABI-name.
Additionally I have added a file-check, that is just like the "hello world"-check but uses register-indices instead of ABI-names.

@AntonLydike I think you didn't see my PR. I'd appreciate if you could review it.


Don't trap SIGPIPE

Trapping SIGPIPE will make ssh/http connections sometimes skip their own error handling because an exception is not raised.

Wondering if it is possible to figure out if the broken pipe came from something like pharos-cluster version | head -1 or a socket error. The later would benefit from non-silent exit.


Performance drop AOT linux-armv7hf on DartMicroBenchHmac.MD5

A recent AOT inline heuristics gave a nice overall 10-500% improvement on many benchmarks.
There was one regression, however, on linux-armv7hf on DartMicroBenchHmac.MD5 (which is interesting, since the same benchmark improved overall elsewhere).
| DartMicroBenchHmac.MD5 | +17.8 % | RunTime | dart-aot | Intel Core i5 | linux-x64 | 7.14 x noise
  | DartMicroBenchHmac.MD5 | -10.7 % | RunTime | dart-aot | Odroid-C2 | linux-armv7hf | -1.71 x noise
  | DartMicroBenchHmac.MD5 | +32.1 % | RunTime | dart-aot | Odroid-C2 | linux-armv8 | 3.83 x noise
Please investigate what happened.

The armv7 version is a bit more sensitive to code size than the others. Recent improvements brought the performance back up a bit again. Since getting more performance is still actively tracked with https://github.com/dart-lang/sdk/issues/34473, closing this bug.


Riven R bug

Riven during R in the Broken Covenant skin does not change completely

use some skin that changes in ultimate like riven emissary of light

#1


Problem with multi-GPU training

Hello,
I have successfully built maskrcnn_benchmark on Ubuntu 16.04. My workstation has 4x1080Ti (CUDA 9.2, cuDNN 7, Nvidia drivers 410.48) and I tried to train on COCO dataset on multiple GPUs. I used the script provided in "Perform training on COCO dataset" section.
One GPU worked fine with:
python tools/train_net.py --config-file "configs/e2e_mask_rcnn_R_50_FPN_1x.yaml" SOLVER.IMS_PER_BATCH 2 SOLVER.BASE_LR 0.0025 SOLVER.MAX_ITER 720000 SOLVER.STEPS "(480000, 640000)" TEST.IMS_PER_BATCH 1

Then I used
export NGPUS=2
python -m torch.distributed.launch --nproc_per_node=$NGPUS tools/train_net.py --config-file "configs/e2e_mask_rcnn_R_50_FPN_1x.yaml" SOLVER.IMS_PER_BATCH 4 SOLVER.BASE_LR 0.0025 SOLVER.MAX_ITER 720000 SOLVER.STEPS "(480000, 640000)" TEST.IMS_PER_BATCH 1

(the same train_net.py file and the same config, changed images per batch to 4) and everything worked fine.
Next I tried the same thing for 3 GPUs (changed NGPUS=3, images per batch to 6) and the training gets stuck during the first interation. I have the following logging information and it does not change:
2018-10-29 17:20:55,722 maskrcnn_benchmark.trainer INFO: Start training
2018-10-29 17:20:58,453 maskrcnn_benchmark.trainer INFO: eta: 22 days, 18:04:18  iter: 0  loss: 6.7175 (6.7175)  loss_classifier: 4.4688 (4.4688)  loss_box_reg: 0.0044 (0.0044)  loss_mask: 1.4084 (1.4084)  loss_objectness: 0.7262 (0.7262)  loss_rpn_box_reg: 0.1097 (0.1097)  time: 2.7304 (2.7304)  data: 2.4296 (2.4296)  lr: 0.000833  max mem: 1749

The GPU memory is used, the temperature goes up, but nothing is happening (I tried multiple times and then gave up).
Any ideas? I'd be grateful for help.

I met the same issue. I'm using an 8GPU machine and it works fine with NGPUS=2, but stuck after first iteration when using NGPUS=4 or 8.
torch (1.0.0a0+ff608a9)
torchvision (0.2.1)
CUDA 9.2

Hi,
@robpal1990 So the training get's stuck once you use 3 GPUs, is that right? Did you try using 4 GPUs as well?
In the past we had hangs as well, but those were due to a driver bug that was fixed in versions 384, 390 and 396.
The driver versions with the fix are >=384.139 (for cuda 9.0)  and >=396.26 (for cuda 9.2). They are out already. If you can, it's better to move to 396, if not, update 384
Could you check that your drivers satisfy those requirements?

I also met the same issue, I am using 3 GPUs machine. It works fine when I use 2GPUs, but stuck when using 3 GPUs.
PyTorch version: 1.0.0.dev20181029
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Ubuntu 16.04.4 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.9) 5.4.0 20160609
CMake version: Could not collect
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 9.0.176
GPU models and configuration:
GPU 0: TITAN V
GPU 1: TITAN V
GPU 2: TITAN V
Nvidia driver version: 390.59
cuDNN version: Could not collect

I'll try reproducing this and report back

Hi,
@robpal1990 So the training get's stuck once you use 3 GPUs, is that right? Did you try using 4 GPUs as well?
In the past we had hangs as well, but those were due to a driver bug that was fixed in versions 384, 390 and 396.
The driver versions with the fix are >=384.139 (for cuda 9.0) and >=396.26 (for cuda 9.2). They are out already. If you can, it's better to move to 396, if not, update 384
Could you check that your drivers satisfy those requirements?

I tried using 4 and run into the same issue.
As I mentioned in the first post, I have the 410.48 version of the drivers. I will try downgrading to a 396.xx version.
Thanks a lot for your help.

@robpal1990 thanks a lot for the info.
So this seems to be related to the hangs that we were facing in the past. They were due to a problem with the driver when some cudnn convolution was selected.
@slayton58 @ngimel Are you aware of this hang with 410.48 drivers?

A follow-up, since it seems that the issue is still present is some settings.
I haven't mentioned in my first post that I have everything installed without conda (simply with pip3, python3). Training on 3 GPUs works.
Then, I created a Docker build, extending the image pytorch/pytorch:nightly-devel-cuda9.2-cudnn7 (this one has conda inside). I followed the instruction as before, but in the docker container training on 3 GPUs gets stuck on the first iteration again and as of now I don't know how to fix it. From what I know, Docker shares the drivers with host machine, so it's surprising.

Well, in my situation, training on 3 GPUs works fine, while training on 4 GPUs stucks. The codes are run on a   server with 4 Titan Xp cards. I hope this issue can be fixed soon.

I think this is a bad mix with CUDA / CUDNN and the NVidia driver, and I'm not sure there is anything we can do. You might need to update a few things in your system.
For info, here is the setup I use and which works fine:
PyTorch version: 1.0.0a0+dd2c487
Is debug build: No
CUDA used to build PyTorch: 9.0.176

OS: Ubuntu 16.04.4 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
CMake version: version 3.5.1

Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 9.2.88
GPU models and configuration: 8 Tesla V100
Nvidia driver version: 396.51

CUDNN 7.0

Isn't CUDA and CUDNN built in pytorch? I thought the version I installed on my server manually would have no influence on that built in pytorch itself. Here is my setup info.
@fmassa
`PyTorch version: 1.0.0.dev20181108
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Ubuntu 16.04.5 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
CMake version: version 3.5.1
Python version: 3.5
Is CUDA available: Yes
CUDA runtime version: 9.0.176
GPU models and configuration:
GPU 0: TITAN Xp
GPU 1: TITAN Xp
GPU 2: TITAN Xp
GPU 3: TITAN Xp
Nvidia driver version: 390.87
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.2.1
/usr/lib/x86_64-linux-gnu/libcudnn_static_v7.a
Versions of relevant libraries:
[pip] Could not collect
[conda] Could not collect`

So, I think that 390.87 is a driver for CUDA 9.1, and it might be prior to the fix that I mentioned.
Updating the nvidia driver to the latest release should fix the issue.

So, I think that 390.87 is a driver for CUDA 9.1, and it might be prior to the fix that I mentioned.
Updating the nvidia driver to the latest release should fix the issue.

It's weird. I did not touch the driver but only installed all patches of my CUDA(9.0). After that was done, this issue was gone. I installed pytorch by using pip and I thought CUDA is built in pytorch if I installed it in that way. If that is true, how would my own local CUDA patches influence the behavior of pytorch codes?

hi @robpal1990
how do manually degrade the driver ?

hi @robpal1990
how do manually degrade the driver ?

I had it installed via apt on Ubuntu, so simply type sudo apt remove nvidia-3xx nvidia-3xx-dev (fill xx with your version.
Then I downloaded and installed the drivers from Nvidia website (https://www.nvidia.com/Download/index.aspx). In my case I also had to build CUDA with these drivers. Download the one from Nvidia website since the one in apt repo will overwrite your drivers with 410 version.

hi @fmassa
right now support cuda 10?

PyTorch supports CUDA 10, but you need to compile PyTorch from source I think

hi @chengyangfu  @fmassa
i find that after installing the new version of nccl, the hang doesn't occur. it seems to be solved.

May I ask what CUDA and driver version are you using? I'm stuck with this issue in CUDA8.0.61,  cudnn 7102 , driver 390.97 even with 2 1280ti cards. I tried both nightly and stable version pytorch.

I solved my case. When no positive example is presented in training, it blows up. :disappointed:  I think it's related to the following issue.
One tricky solution is to increase you batch size. :imp:

@fmassa My env is almost same as yours, but when I use 2 GPUS， program still stucks randomly.
PyTorch version: 1.0.0.dev20190324
Is debug build: No
CUDA used to build PyTorch: 9.0.176

OS: Ubuntu 16.04.5 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
CMake version: version 3.5.1

Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 9.2.148
GPU models and configuration:
GPU 0: TITAN X (Pascal)
GPU 1: TITAN X (Pascal)
GPU 2: TITAN X (Pascal)
GPU 3: TITAN X (Pascal)

Nvidia driver version: 396.82
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.1.4

hi @chengyangfu @fmassa
i find that after installing the new version of nccl, the hang doesn't occur. it seems to be solved.
could you tell me the version of those packages? pytorch, cuda, nvidia driver and nccl, thank you!


Implement pipeline pattern

Signed-off-by: Dennis Meister<EMAIL_ADDRESS>Implement pipeline pattern for extracting needed code snippet blocks

Logger statements are missing f-strings, look at example_output_1.py line 91

Hi @doosuu
Unfortunately our linter has problems with using this.
"Use lazy % formatting in logging functionspylint(logging-fstring-interpolation)"
I would propose we do not change it within this PR


Extension: User can't hit the "Confirm" button on the ToS screen of the Swap feature

Version test : http://file.cdmteck.com/s/tcAoKtAxSTxkKna
Validation passed in case ( on Chrome, Firefox, Brave) :

Install version
Update version
Reload extension
Zoom-in/ zoom-out extension

@Sokol142196 @ThaoNguyen998  , please check for me on your device


kodadot

Is there an existing issue?

[X] I have searched the existing issues

What happened?
Hola! No funciona teleport bridge en KSM
Please reproduce in steps
teleport no funcciona
Expected Behavior
teleport no funcciona
What browsers are you seeing the problem on?
Desktop Chrome
At which address did you encounter bug?
kodadot.xyz
Are you logged in?
None
Which wallet you are using?
PolkadotJS
At which chain did you encounter bug?
Kusama
Screenshots

Wallet Address & Transaction hash
No response
Relevant log output
No response
Payment link for reward
https://canary.kodadot.xyz/dot/transfer/?target=<My_Polkadot_Address_check_https://github.com/kodadot/nft-gallery/blob/main/REWARDS.md#creating-your-dot-address>
Code of Conduct

[X] I agree to follow this project's Code of Conduct

@soltansergey79 no es que no funcione
la opción esta desactivada temporalmente , ya que hay un bug que te hace perder los fondos si haces bridge
estamos a la espera de que el bug se arregle y tal cual el bug este arreglado  pondremos la opcion de ksm de vuelta


md-core mixin not found when building 2.0.0-beta.2

Using
@angular/material 2.0.0-beta.2
webpack 2.3.0
sass-loader 6.0.0
postcss-loader 1.3.0
I get a build error:
Module build failed:
@include md-core();
^
No mixin named md-core
Backtrace:
stdin:7
in R:\fb_wp\sass\angular-material.scss (line 7, column 10)
@ ./sass/angular-material.scss 4:14-174

Try using mat-core instead.

After the release '2.0.0-beta.2', some prefixes replaced with md- to mat-
For example:
Old theming guide code
`
@import '~@angular/material/core/theming/all-theme';
@include md-core();
$candy-app-primary: md-palette($md-indigo);
$candy-app-accent:  md-palette($md-pink, A200, A100, A400);
$candy-app-warn:    md-palette($md-red);
$candy-app-theme: md-light-theme($candy-app-primary, $candy-app-accent, $candy-app-warn);
@include angular-material-theme($candy-app-theme);
`
The same code after release '2.0.0-beta.2'
`
@import '@angular/material/core/theming/all-theme';
@include mat-core;
$candy-app-primary: mat-palette($mat-indigo);
$candy-app-accent:  mat-palette($mat-pink, A200, A100, A400);
$candy-app-warn:    mat-palette($mat-red);
$candy-app-theme: mat-light-theme($candy-app-primary, $candy-app-accent, $candy-app-warn);
@include angular-material-theme($candy-app-theme);
`

Sorry, this was my mistake. I hadn't updated the scss code that I got from https://github.com/angular/material2/blob/master/guides/theming.md
Everything works now when using the updated code from the link above. And yes, the solution was to exchange the 'md-' prefix to 'mat-'.
Thanks all for your help!


[WIP]Support IPv6 for delegated IPAM

TODOs: add ipv6 tests

cc @rjdenney

I'll make sure to add the correct helm values.
Also I noticed that you added a change in your previous PR that made it so that the routes would only be created if conf.InstallUplinkRoutesForDelegatedIPAM is set to true. Is this something that is done in Cilium or using helm values?

I'll make sure to add the correct helm values.
Also I noticed that you added a change in your previous PR that made it so that the routes would only be created if conf.InstallUplinkRoutesForDelegatedIPAM is set to true. Is this something that is done in Cilium or using helm values?

@rjdenney conf.InstallUplinkRoutesForDelegatedIPAM is controlled by helm value ipam.installUplinkRoutesForDelegatedIPAM


Support "trusted profile assume" with a go authenticator.

Is your feature request related to a problem? Please describe.
missing feature I believe at least in the go sdk
Describe the solution you'd like
Essentially do this:
curl -X POST "https://iam.cloud.ibm.com/identity/token"\
  --header "Content-Type: application/x-www-form-urlencoded"\
  --data-urlencode 'grant_type=urn:ibm:params:oauth:grant-type:assume'\
  --data-urlencode 'access_token=ACCESS-TOKEN'\
  --data-urlencode 'profile_id=ProfileId-123123123'

Describe alternatives you've considered
unable to see how to do this with the SDK publisjed
Additional context
I could not find a way with the provided SDK to assume a trusted profile.
I ended up writing an authenticator to wrap and IAMAuthenticator (containing service apikey) which generates a token for the trusted profile that the apikey is allowed to assume. I think this should be provided.

Looking into this... will consult with IAM team for more info.

@sjhx Stuart, could you please describe your particular use-case in a bit more detail?  I assume you have a Go application that uses a Go SDK and you need to use this new IAM feature to "assume" the identity of the trusted profile (sort of like sudo on linux).


Add Search functionality to Interface Assignment area of /ipam/ip-addresses/add/?address=x.x.x.x/xx

There used to be a way to search the device name and assign to the interface of the searched device once an IP was created. It appears that recent changes have removed that capability and now require a drill down approach to assigning IP's to an interface.
As it appears the logic behind this may have changed, might I suggest just adding a search field here that will prevent having to drill down for every IP add?
A search field above the Site dropdown should be sufficient. I believe it would be a good idea to have a successful search selection populate the Site, Rack and Device fields leaving the Interface field to be selected by the user.

Closing this out in favor of #1512 now that virtualization modeling has been added.


Production build without compression

Is there a way to make a production build without compression, or at least without uglifying the code?

As far as I know ng build will build app without uglyfing and compression.

That will do a dev build so there will be other differences as well. For global stylesheet handling, you're going to get a js bundle instead of css.  Output filenames will have no hashes.  Probably some others as well.
Also, your builds will be significantly larger without the minification step.

Basically I want the JS bundled, but no uglifying on the index HTML or the CSS.

The CLI is meant to be an opinionated build system.   So if you're interested in full control, it's probably not what your looking for.
In regards to what you want, index.html is not minifying or compressed currently.  Component CSS is bundled with their respective component's JS.  Global CSS will be combined and minifying in production builds.  (In development builds they will be combined into a JS bundle).

What @clydin said is very accurate. I can also say that as far as future plans are concerned, we aren't looking specifically at adding this toggle but it might happen if we end up giving more granular build control overall.

It would be good if the files could at least be in folders or something. Most clients complain about having one folder full of fonts, images, scripts, and styles. If they were at least broken into folders it would be less of a mess. Is there anyway to have it keep the folder structure or have a folder structure?


Allow the solr url to be set in data payload

This allows the payload to determine the solr endpoint. If not found in payload, behavior is as before and based on config value.
The purpose is to allow erchef to set solr url based on darklaunch data and allow us to orchestrate a move to solr4 live by org via darklaunch.
/cc @sdelano @danielsdeleo

I believe we solved this differently for the actual solr4 migration.  Can we close this?

Solr4 migration occurred so this probably isn't relevant any longer.


Ideate metrics to collect

Ahead of our systems going live, let's align on how we can collect metrics to continually measure how our systems are meeting user needs.
Acceptance Criteria:

[ ] Review this Miro board of past ideas
[ ] Brainstorm overall goals of our system that can be measured with metrics
[ ] For each goal identified, brainstorm individual metrics that can be collected (record these in one colour of sticky note)
[ ] Ask the program if they would like any metrics collected (record these in a different colour of sticky notes)
[ ] Prioritize metric sticky notes on a matrix of impact & effort to implement
[ ] Discuss governance strategy around metrics - who will collect, analyze, and oversee?
[ ] Make a plan to evaluate differrent metric collection tools/dashboards (incl. Snowplow, other tools used across BC Gov, and developing our own)

Goal of this ticket:

Gain collective clarity on what metrics should be collecting to ensure we're getting ongoing feedback on our systems

@NicoleGovvy is this different than Ticket #17 ? Would love to dig into this more to understand the difference :)

@patriciarussellCAS they're essentially the same - I think I'd flagged #17 as being able to be closed. KPIs can be bigger or different than metrics - but are usually measured by metrics.


update js cdn link to 1.3.5

updated to
//cdnjs.cloudflare.com/ajax/libs/wavesurfer.js/1.3.5/wavesurfer.min.js

are there more cdn links that need to updated in the docs @entonbiba?

@thijstriemstra I only found two references.

I suppose this is blocked till the file's actually online?

@thijstriemstra yes

I think 1.3.7 is the latest now.

@thijstriemstra updated


Fix comment typo

Objective

Fix some typos

Solution
For the first time in my life, I made a pull request to OSS.
Am I right?

@rparrett
The problem was that English was not my first language and I did it messily using the editor's proofreading function.
Thank you for the detailed instructions🥰

Agree with the comments from @rparett :) @eiei114, thanks, and welcome to OSS 🎉  On the "Files changed" tab you can commit suggestions directly :)

Oops, I didn't add "github suggestions" for the comments where things were okay as-is. So you'll want to:

Pull the suggestion commit that github made in your branch for you to your local branch
Make those other changes manually
Push the branch back

I've added suggestions for those reversions now, in case that's easier for you :) You can "add suggestions to batch", and get a slightly nicer commit history too. It's not a big deal here though, this is a tiny PR and we squash commits on merge.

Sorry🤦♂ I forgot that you only raised the suggestion and no changes were made 😂

Looks great! You're now officially a contributor to Bevy ;)
bors r+


How can we use it for ads inside the app view

We have a view in which we want to load videos from remote server by giving its url. How can I use it inside my app specific view which I have for showing ads.
One more question is that if it  supports cache or It will always load ads from url if I want to repeat them ?

This version of the SDK does not support video, but we have a newer SDK which is available to the public, but is still in a beta form.
https://github.com/adbutler/adbutler-android-mraid-sdk
This would allow you to display video ads in the form of VAST ads.  (You would configure them in the AdButler admin panel)
They would not be cached unless the browser caches the video.  You have to request the ad each time because otherwise we couldn't know your statistics (impressions)


I123 tidying, debug and error squashing

closes #123 whilst trying to remove the number of warning / errors produced.
Temporarily include a curl replacement for the dataverse R replace file call to see if it improves issues with not all files transmitting.
Includes some unit tests and a new dataset for testing - "test". There is a sinusoidal data generator that powers this - utils::generate_clean_cases that works on a periodicity of max(start-peak, peak-end) days where the data length, peak position and amplitude are configurable (amplitude = 1/2 peak_cases, offset = 1/2 peak_cases.
example (peak_cases = 2k, days_since_peak = 40, number_of_days = 90):

Testing against canada before confirming PR as ready


net/http needs cgo to be disabled on macos?

What version of Go are you using (go version)?

$ go version

go version go1.14.2 darwin/amd64

Does this issue reproduce with the latest release?
yes
What operating system and processor architecture are you using (go env)?
macos 10.13.6
go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/nick2/Library/Caches/go-build"
GOENV="/Users/nick2/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/nick2/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="/Users/nick2/opt/miniconda3/bin/x86_64-apple-darwin13.4.0-ar"
CC="x86_64-apple-darwin13.4.0-clang"
CXX="x86_64-apple-darwin13.4.0-clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/dm/2w2btgwj4f38934mhkm7w4700000gp/T/go-build530020094=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?
Ran this very simple script which uses the net/http package
package main
import (
"flag"
"log"
"net/http"
)
func main() {
port := flag.String("p", "8080", "port to serve on")
directory := flag.String("d", ".", "the directory of static file to host")
flag.Parse()
http.Handle("/", http.FileServer(http.Dir(*directory)))

log.Printf("Serving %s on HTTP port: %s\n", *directory, *port)
log.Fatal(http.ListenAndServe(":"+*port, nil))

}

What did you expect to see?
Serving  on HTTP port 8080
What did you see instead?
runtime/cgo
ld: warning: ld: warning: ignoring file /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/lib/libpthread.tbd, file was built for unsupported file format ( 0x2D 0x2D 0x2D 0x20 0x21 0x74 0x61 0x70 0x69 0x2D 0x74 0x62 0x64 0x2D 0x76 0x33 ) which is not the architecture being linked (x86_64): /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/lib/libpthread.tbdignoring file /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/lib/libSystem.tbd, file was built for unsupported file format ( 0x2D 0x2D 0x2D 0x20 0x21 0x74 0x61 0x70 0x69 0x2D 0x74 0x62 0x64 0x2D 0x76 0x33 ) which is not the architecture being linked (x86_64): /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/lib/libSystem.tbd
Undefined symbols for architecture x86_64:
"___stack_chk_fail", referenced from:
_x_cgo_init in _x004.o
__cgo_sys_thread_start in _x004.o
"___stack_chk_guard", referenced from:
_x_cgo_init in _x004.o
__cgo_sys_thread_start in _x004.o
"___stderrp", referenced from:
__cgo_sys_thread_start in _x004.o
_x_cgo_sys_thread_create in _x005.o
_x_cgo_thread_start in _x008.o
"_abort", referenced from:
__cgo_sys_thread_start in _x004.o
_x_cgo_sys_thread_create in _x005.o
_x_cgo_thread_start in _x008.o
"_fprintf", referenced from:
__cgo_sys_thread_start in _x004.o
_x_cgo_sys_thread_create in _x005.o
"_free", referenced from:
_threadentry in _x004.o
"_fwrite", referenced from:
_x_cgo_thread_start in _x008.o
"_malloc", referenced from:
_x_cgo_thread_start in _x008.o
"_nanosleep", referenced from:
_x_cgo_sys_thread_create in _x005.o
__cgo_try_pthread_create in _x005.o
"_pthread_attr_destroy", referenced from:
_x_cgo_init in _x004.o
"_pthread_attr_getstacksize", referenced from:
_x_cgo_init in _x004.o
__cgo_sys_thread_start in _x004.o
"_pthread_attr_init", referenced from:
_x_cgo_init in _x004.o
__cgo_sys_thread_start in _x004.o
"_pthread_cond_broadcast", referenced from:
_x_cgo_notify_runtime_init_done in _x005.o
"_pthread_cond_wait", referenced from:
__cgo_wait_runtime_init_done in _x005.o
"_pthread_create", referenced from:
_x_cgo_sys_thread_create in _x005.o
__cgo_try_pthread_create in _x005.o
(maybe you meant: __cgo_try_pthread_create)
"_pthread_detach", referenced from:
_x_cgo_sys_thread_create in _x005.o
__cgo_try_pthread_create in _x005.o
"_pthread_mutex_lock", referenced from:
__cgo_wait_runtime_init_done in _x005.o
_x_cgo_notify_runtime_init_done in _x005.o
_x_cgo_set_context_function in _x005.o
__cgo_get_context_function in _x005.o
"_pthread_mutex_unlock", referenced from:
__cgo_wait_runtime_init_done in _x005.o
_x_cgo_notify_runtime_init_done in _x005.o
_x_cgo_set_context_function in _x005.o
__cgo_get_context_function in _x005.o
"_pthread_sigmask", referenced from:
__cgo_sys_thread_start in _x004.o
"_setenv", referenced from:
_x_cgo_setenv in _x006.o
(maybe you meant: _x_cgo_setenv)
"_strerror", referenced from:
__cgo_sys_thread_start in _x004.o
_x_cgo_sys_thread_create in _x005.o
"_unsetenv", referenced from:
_x_cgo_unsetenv in _x006.o
(maybe you meant: _x_cgo_unsetenv)
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
=============================
It works if I disable CGO in the terminal.
CGO_ENABLED=0 go run serve.go
I'm confused because I don't use cgo in any of the code as far as I can tell.

this is not a solution. libpthread.tbd is mentioned in error.
ld: warning: ld: warning: ignoring file /Library/Developer/CommandLineTools/SDKs/MacOSX10.14.sdk/usr/lib/libpthread.tbd, file was built for unsupported file format ( 0x2D 0x2D 0x2D 0x20 0x21 0x74 0x61 0x70 0x69 0x2D 0x74 0x62 0x64 0x2D 0x76 0x33 ) which is not the architecture being linked (x86_64)

These sorts of failures on macOS typically indicate a corrupted or otherwise-broken C toolchain, typically something involving Anaconda
I note the following in your go env output, which indeed suggests a broken Anaconda toolchain:
AR="/Users/nick2/opt/miniconda3/bin/x86_64-apple-darwin13.4.0-ar"
CC="x86_64-apple-darwin13.4.0-clang"
CXX="x86_64-apple-darwin13.4.0-clang++"

What happens if you uninstall miniconda3 and/or reinstall the default macOS clang toolchain?
What happens if you explicitly set CC=/usr/bin/clang (as described in https://github.com/golang/go/issues/32559#issuecomment-501038659)?

(This looks like a duplicate of #29597.)


Cursor bracket highlights Adjust Color Placement

Great idea!
Here’s a short video of the error: http://cl.ly/0O0y22203j3b

Thanks! Glad you like it, I initially discovered that feature in FDT in my AS3 days and I just pushed the concept a bit further.
I haven't noticed that behavior with my current setup, so my guess is that there is some styles pollution at some point.
Can you try something for me? I would like you to compare the styles applied to the color marker in the two states to see if there's a rule that cause this offset.
Also, can you tell me if the offset appears for every color markers in the buffer or only for the one between the bracket?
And for the record, I'll need your version of Atom and the plugin's one.

So, having looked at it a bit more, it looks like there’s an weird line at the top of the doc that might be causing the displacement. I would imagine it just moves the point that is considered 0,0 for rendering with CSS positioning. Short video here.
To answer your questions: it seems the styling on the color markers doesn’t change; all color markers move, not just the one most directly associated; Atom v0.186.0, plugin v3.0.8.

Oh, interesting, have you tried to inspect this blue line to see where it comes from?

Huh. Good point! Perhaps it’s a theme issue and not a plugin issue. I’ll check its out origin.


VScode is not openning in Windows10

Does this issue occur when all extensions are disabled?: Yes/No

VS Code Version: 1.78.2
OS Version: windows 10

When you run VScode, it turns off immediately. When I ran vcode, it turned off just before the screen opened properly. I've reinstalled it more than 5 times and I've set up compatibility, but it didn't help. The only way to use vscode is if you run code --verbose on CMD, the vscode runs without shutting down. However, it may not run when the log 'update#ctor - updates disabled by admin in user setup' is displayed. What should I do?

Steps to Reproduce:

vscode icon click

I fixed this issue by reinstalling the version of vscode to 1.63.2.


weird zero rows in the output of both data and sigma. Probably coming from TrueModel evaluation return structure inside Data class.

https://github.com/danOSU/Taweret/blob/02897a27264ca5948a0a2098af76f600c67ef438/Taweret/models/samba_models.py#L474C5-L474C5

Fixed. Was returning the empty std_dev accidentally, hence the zeros (since it uses the TrueModel function).


Resolving issue #59 ("None" displayed when it shouldn't be)

@lounagen, @lukas-gitl
Wanted to touch base after this has sat idle for an unreasonably long time.
Any thoughts on what you'd like to do with this PR?
It seems there is an alternate solution, rather than modifying the default values, but I'm open to hearing out all ideas.

I haven't heard anything else on this, I'm a bit tempted to close this issue off as is, to merge in a set of unittests that have been prepared for this application. Do you have any objections?


Export Keyframed Shapekey Animation

Hello,
I created two different Shape Keys and set them to non-Relative in Blender so they play one after another. I tried to get them exported into a glb or gltf but they wouldn't appear connected. Only as usual as two morphTargetInfluencers.
My second thought was to keyframe the animation into the animationtimeline which might make them appear as animation in the gltf but it also doesn't work.
In blender 2.79 the gltf exports without any issues (just without the animation) and in blender 2.8 it throws the following error:

Here's a basic animation of a cube via two Shape Keys that produces the error:
animationTest.blend.zip

Thanks!

I've moved this issue to the glTF-Blender-IO repository, as we won't be adding new features in the older one.

Here's another example, without anything eval-time related, that ideally should work but doesn't:
CurveMod.blend.zip
It exports without error, but the shape keys all seem to be identical, and the animation only cycles between the first two of them.

I've created this model by applying a "Curve Modifier" to animate a cylinder along a path, exporting that animation to MDD, then importing it back in. This creates one shape key per keyframe, and an animation cycling through them. There's no reason that final result shouldn't be able to be exported to glTF, but something isn't working correctly.

^If I select Animation --> Always Sample Animations the file above does export correctly. I don't think that should be necessary, so this is probably still a bug, but that workaround may help others.

The second case ( tube on curve modifier --> MDD) seems to export correctly. Closing this ticket.
I will open a new one for enhancement about evaluation time


Sparse generation failure

Entry 1,1 seems to get corrupted by the sparse method in Julia...  Odd....
julia> [i j v]
18x3 Array{Int64,2}:
 1  1   1
 1  2   2
 1  3   3
 1  4   4
 1  5   5
 1  6   6
 1  1   1
 2  1   7
 3  1   9
 4  1  11
 5  1  13
 6  1  15
 1  1   1
 2  2   8
 3  3  10
 4  4  12
 5  5  14
 6  6  16

julia> sparse(i,j,v,length(row),length(col),(+))
6x6 sparse matrix with 16 Int64 entries:
	[1, 1]  =  3
	[2, 1]  =  7
	[3, 1]  =  9
	[4, 1]  =  11
	[5, 1]  =  13
	[6, 1]  =  15
	[1, 2]  =  2
	[2, 2]  =  8
	[1, 3]  =  3
	[3, 3]  =  10
	[1, 4]  =  4
	[4, 4]  =  12
	[1, 5]  =  5
	[5, 5]  =  14
	[1, 6]  =  6
	[6, 6]  =  16

Fixed,  redundant entry in string input cause the initilizer to add them together.  Adding a case for string input to get the duplicate entry with value infront in alphabetical order instead.


Fix propagation of user attribute in request

There are a couple problems with how we set and query the user attribute of the tasks.  This is supposed to get set to the requesting user so that the tasks can be queried by user.

The Redis state manager needs to add this parameter to get_task_data() (see https://github.com/google/turbinia/issues/358 for more details)
The actual user as set in the task is actually the user where the server is being run (because Tasks are instantiated there).    The user needs to be propagated in the request.
The cloud function itself seems to also have a bug because it's not actually filtering properly on the user.

Fixed in #381


add database type gene2phenotype

Requirements
Description
We introduced a new ensembl database type gene2phenotype a few years ago. We have now setup a test database which we want to patch like our other ensembl databases before branch.
Use case
Patch gene2phenotype test database before branch.
Benefits
Use established system for updating the gene2phenotype test database.
Possible Drawbacks
None
Testing
I ran the schema_patcher.pl to patch ensembl-gene2phenotype database to 105 which worked successfully after adding the updates described in this PR.

Coverage decreased (-0.2%) to 82.165% when pulling eec531f516ec0186028c88e7073230a1bdf2471b on at7:add_type_to_schema_patcher into 5b3e0ee73da2e78de9f2e7816d367cec0b26e3d8 on Ensembl:master.


Standardized & simplified & updated build & test infrastructure

Wanted to try consuming https://github.com/jenkinsci/scm-api-plugin/pull/180 but that first requires having basic dependencies be reasonably up to date, which they are not and the reliance on the analysis-pom parent makes it far harder to do routine maintenance like we do typical Jenkins plugins. The use of the plugin-util-api test dependency also causes serious structural problems making it hard to update the POM. (https://github.com/jenkinsci/bom/pull/1521#issuecomment-1339717547 for context)
Would supersede #306 & #305 & #304 & #302 & #265.

https://github.com/jenkinsci/plugin-util-api-plugin/blob/00a7b80b6fb464da24eeff8d984ccf20a641cc12/src/test/java/io/jenkins/plugins/util/IntegrationTest.java#L51 is causing all sorts of errors. Should not be using this dep at all.

@timja any advice here?

@timja any advice here?

or is the question more about the deleting of all of the integration tests in the plugin?

is the question more about the deleting of all of the integration tests in the plugin?

Yeah, that is the only thing I found that would work. Do you have a better idea?

Yeah, that is the only thing I found that would work. Do you have a better idea?

Switch to the default parent pom but leave the plugin-util-api dependency? Can drop the architecture test if needed but not sure if we should drop all integration tests...

After trying this myself I see that the issue is that plugin-util-api now uses junit5 for all it's tests.
It would be non-trivial to re-write to junit5 I think.
Likely easier to rewrite to JTH without the plugin-util-api wrapper.
I'll give that a quick go and if that's not something I have time for I'll merge this.
fyi @uhafner

Why are you requesting a review and then merge such a change?

Shouldn't this be done by the author of this PR?

Later equals never! 👎

😄 I've made good progress in here:
https://github.com/jenkinsci/github-checks-plugin/pull/332
I found another complexity is that github-branch-source has had some changes which has broken some of the mocking assumptions in this plugin.
I've fixed all but one test in that test class and just need to do some debugging to finish it off. Hopefully other tests will be straightforward to port.


Fixes path for odo create interactive

fixes #2163
How to test:
Trigger odo create in a directory, enter response of Location of path component, relative to ... and check if the correct response is stored by odo config view

@mik-dass If instead of hitting the "Return" key, I choose to provide the full path to the component directory, it fails:
$ odo create
? Which component type do you wish to create nodejs
? Which version of 'nodejs' component type do you wish to create latest
? Which input type do you wish to use for the component local
X Sorry, your reply was invalid: path '~/src/nodejs-ex' does not exist on the file system
? Location of path component, relative to '/home/dshah/src/nodejs-ex' /home/dshah/src/nodejs-ex
? What do you wish to name the new component nodejs
? Which application do you want the commponent to be associated with app
? Which project go you want the component to be created in myproject
? Do you wish to set advanced options No
 ✓  Validating component [25ms]
Please use `odo push` command to create the component with source deployed

$ odo push
Validation
 ✓  Checking component [7ms]

Configuration changes
 ✓  Initializing component
 ✓  Creating component [192ms]

Pushing to component nodejs of type local
 ✓  Checking files for pushing [794780ns]
 ✗  open /home/dshah/src/nodejs-ex/home/dshah/src/nodejs-ex: no such file or directory

? Location of path component, relative to '/home/dshah/src/nodejs-ex'

@dharmit  we are informing the user that the path should be relative to the directory

[odo]  ✗  Waiting for build to finish [30s]
[odo]  ✗  Failed to create component with name testcmp. Please use `odo config view` to view settings used to create component. Error: unable to wait for build testcmp-e2e-xyzk-1 to run: timed out waiting for the condition

/retest

? Location of path component, relative to '/home/dshah/src/nodejs-ex'

@dharmit we are informing the user that the path should be relative to the directory

Ack. My bad on missing that piece of info.
/hold cancel

/lgtm

/retest
level=warning msg="Found override for release image. Please be warned, this is not advised"
level=info msg="Consuming \"Install Config\" from target directory"
level=info msg="Creating infrastructure resources..."
level=error
level=error msg="Error: Error retrieving Listener: timeout while waiting for state to become 'success' (timeout: 1m0s)"
level=error
level=error msg="  on ../tmp/openshift-install-774646207/vpc/master-elb.tf line 142, in resource \"aws_lb_listener\" \"api_external_api\":"
level=error msg=" 142: resource \"aws_lb_listener\" \"api_external_api\" {"
level=error
level=error


Do nothing when ctx.value is empty

If ctx.value is undefined or null (or any falsy value) the developer doesn't want to scroll.
So don't preventDefault and do nothing and let the default to do its work.

:tada: This PR is included in version 2.18.0 :tada:
The release is available on:

npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


Optionally create sensor for whether a device is connected at all

This helps build automations like in https://github.com/DouweM/homebridge-unifi-occupancy/issues/9#issuecomment-1415863290:

I could also include guest sensors if I want (example):
When me and my wife (both) leave the house, the house turns off (lights, heating, etc.)
But sometimes we have a babysitter that stays in the house and we want everything to remain on.
I now have to disable the "leave" automation, but I could add an extra step to check if the babysitter ('s device) is connected.

It should be configurable per device type if it creates AP/room sensors, a home sensor, or both.

Done in v1.2.0!


Start the setup process start in the language that the iPhone is set to

Based on user feedback
The current version of Soundscape starts the setup process in English when the app is first installed.
Then the user could change the language in the middle of the setup.
I'd like to have the setup process start in the language that the iPhone is set to, but I feel that the language question to choose another language should not be eliminated in case the user is bilingual.
The app should default to English only if the phone is already set to English or if the iPhone is set to a language not supported by Soundscape.
Also, the Soundscape Language screen is missing from the U.S. English version of the App Setup in the help documentation but it's there in the U.K. English version.

I'll look into this

It seems like depending on language region the user chooses the language won't update. For example if I put Spanish U.S. as my default language in the simulator, this won't be picked up and will start the app in english. However, if I use Spanish (Spain) it will change the startup language.


microphone test failed

IMPORTANT: Before you create an issue, please take a look at our Issue Reporting Guide.
Briefly summarize your issue:

Microphone test failed.
What is the expected behavior?

rec test.wav should work, and arecord -l should output the record devices.
What behavior are you observing?

When I run rec test.wav, the following errors were output:
ALSA lib pcm_hw.c:1713:(_snd_pcm_hw_open) Invalid value for card
rec FAIL formats: can't open input `default': snd_pcm_open error: No such file or directory
And arecord -l output nothing.
Provide the steps to reproduce the issue, if applicable:

I just followed https://github.com/alexa/avs-device-sdk/wiki/Raspberry-Pi-Quick-Start-Guide.
Tell us about your environment:

What version of the AVS Device SDK are you using?
  <1.7.0>

Tell us what hardware you're using:

[ ] Desktop / Laptop
[x] Raspberry Pi
[ ] Other - tell us more:

Tell us about your OS (Type & version):

[ ] Linux
[ ] MacOS
[x] Raspbian Stretch
[ ] Raspbian Jessy
[ ] Other - tell us more:

Hi @bill-lzb,
Am closing this issue as we haven't heard back from you. If you still see the issue feel free to open another issue.
Thanks
Priya

Hi Priya
After connecting a USB microphone, it became OK.
Thanks
Bill


OMP Sentinels

Some code contains:
!$ USE compute_chunk_size_mod, ONLY: compute_chunk_size  ! Note OpenMP sentinel

These dependencies are missed atm.
There is a work-around already merged into bom_master, but the next fparser release will provide support for omp conditional sentinels. Once this release is done, we only need to update the required fparser version, and provide the flag when parsing to enable handling of sentinels. THis will require the config object to 'know' if a build is using OpenMP or not.

Migrated to https://github.com/MetOffice/fab/issues/362


Add package alut

An informative readme would be nice - what does this package do, how to use it, etc.


Add timestamps to groups table in migration generator template

Default Group memberships table has rails default timestamps included but groups table does not.
This should fix the discrepancy.

👍


[ISSUE-#1931] Add a reset Nacos Log Config listener.

Describe what this PR does / why we need it
Listens for ApplicationEnvironmentPreparedEvent, reload nacos-client log config
Does this pull request fix one issue?
Fixes #1931
Describe how you did it
Describe how to verify it
Special notes for reviews

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

LGTM


Figure out if Marketplace update can be turned off

Looks like marketplace release is adhoc with openshift release and even we do latest z stream release and try that after an new marketplace release then it start pulling images from the internet and which is around ~500Mb data. We need to figure out if there is a way to turn off that auto update on marketplace operator side so it will not update automatic and use whatever we have at time of bundle creation.

After digging in the maketplace pod side looks like it using imagePullPolicy: Always which force to go to network and pull the metadata or images.
      imagePullPolicy: Always
      volumeMounts:
        - name: certified-operators-token-64gg9
          readOnly: true
          mountPath: /var/run/secrets/kubernetes.io/serviceaccount
      terminationMessagePolicy: File
      image: 'registry.redhat.io/redhat/certified-operator-index:v4.7'


[Feature Request]: Add Social media icon in footer

Is there an existing issue for this?

[X] I have searched the existing issues

Feature Description

To add social media icons in the footer, include the icons for platforms like Facebook, Twitter, and Instagram at the bottom of your webpage. Make sure they are clickable and link to your social media profiles.

something like this
Use Case
Adding social media icons in the footer allows visitors to easily find and follow your social media profiles, enhancing your online presence and engagement. It also provides a professional touch to your website, showcasing your active participation on social platforms.
Benefits
No response
Add ScreenShots
No response
Priority
High
Record

[X] I have read the Contributing Guidelines
[X] I'm a GSSOC'24 contributor
[X] I have starred the repository

@heli0707, thank you for your contribution! At this time, we do not need social icons in the footer. However, I encourage you to raise new issues or suggest other improvements. I welcome your contributions to my project.


Scale things so text doesn't overlap other objects

Sometimes a facet label text overlaps its bounding box or two scales have text that touch. These fonts could be scaled down to fit inside the container or the box could be scaled up to fit the text or both.

Is this issue a better fit for here or for AbstractPlotting?

In this example, the legend goes over the edge. An improvement would be

shrinking the legend to fit, or
expanding the plot boundary to fit

data(diamonds) * mapping(:Price, :Price, color=:Color, size=:Clarity, marker=:Cut) * visual(Scatter) |> draw


Support Target Structs

Make it so that you can diff structs using serde's remote target struct feature (into/from the same struct):
#[derive(SerdeDiff, Serialize, Deserialize, Clone, PartialEq, Debug)]
#[serde(from = "MySimpleStruct", into = "MySimpleStruct")]
#[serde_diff(target = "MySimpleStruct")]
struct MyComplexStruct {
    // This field will be serialized
    a: u32,
    // This field will not be serialized, because it is not needed for <some reason>
    b: u32,
}

#[derive(SerdeDiff, Serialize, Deserialize, Default, PartialEq, Debug)]
#[serde(rename = "MyComplexStruct", default)]
struct MySimpleStruct {
    a: u32,
}

impl From<MySimpleStruct> for MyComplexStruct {
    fn from(my_simple_struct: MySimpleStruct) -> Self {
        MyComplexStruct {
            a: my_simple_struct.a,
            b: 0, // this value wasn't serialized, so we'll just default it to zero
        }
    }
}

impl Into<MySimpleStruct> for MyComplexStruct {
    fn into(self) -> MySimpleStruct {
        MySimpleStruct { a: self.a }
    }
}

@kabergstrom Ready for the first real review!

The test I added isn't particularly thorough -- do you think we should add more?
Should I add this functionality to the "opaque" side of things as well?
Should we update the Readme or any other docs?  (I did update the doc comment in lib.rs)

/cc @jlowry

Gentle nudge.

I'll have a go at running this against the Transform struct in Amethyst tomorrow.
Is it necessary to have:
#[serde_diff(target = "MySimpleStruct")]

It would be nice if it could use the information that is already passed to serde macro.

Reading through the code, it looks good.

@jlowry Thanks! 😄

With regards to testing, the Transform struct in Amethyst is what caused the need to have the feature. Would it be worth adding a test that has a two transforms that differ by a field such as a rotation and the try to apply the diff?

The test I wrote is intended to simulate exactly that sort of situation. MyComplexStruct is analogous to Transform where field a is a field that needs to be preserved (like rotation) and field b is a field that does not need to be preserved (like the global matrix). MySimpleStruct is analogous to TransformValues, which only has the fields that need to be preserved (a in this case).  Does that address the testing case that you were thinking about?

Should I add this functionality to the "opaque" side of things as well?

What functionality would adding it give us?

I'll take that as "No".  If this functionality will only ever be used for this one use case, then it gives us nothing.

Is it necessary to have:
#[serde_diff(target = "MySimpleStruct")]

It would be nice if it could use the information that is already passed to serde macro.

As far as I can see with my experimentation, extracting the into or from attributes from #[serde(...)] requires me to handle (and ignore) all serde container attributes that occur in tandem with a #[derive(SerdeDiff)].  Do we intend for this code to be generally useful, or only specifically solve Amethyst's use-case?  For a general design, I feel that having a single, explicit #[serde_diff(target = ...)] is superior to maintaining a list of serde's possible attributes to ignore. If this is only ever going to be used by Amethyst, then I don't think the design particularly matters.  I'm willing to make the change if folks think that would be better. Let me know!

I'm willing to make the change if folks think that would be better. Let me know!

I think it's worth noting that #[derive(SerdeDiff)] needs to be added to any components that are used in prefabs including user defined ones. So any users that use the same pattern (from=, into=) as Transform would also have to add the #[serde_diff(target = ...)].
Maybe we should keep the explicit #[serde_diff(target = ...)] and see how poeple find using it?

Maybe we should keep the explicit #[serde_diff(target = ...)] and see how people find using it?

Alrighty. 👍🏼


add syntax highlight for Vim

Hi Matt, thanks for contributing this change.  I'm not sure yet where this feature belongs as it doesn't relate specifically to the Go implementation of Skylark, but various possible alternatives are equally unnecessarily tied to the Java implementation.  It seems we need a place for implemenation-language agnostic helper programs like this one.  I'm discussing it with the Bazel team and will let you know what we conclude.
More specifically, I wonder whether this change is necessary at all.  Skylark is (syntactically) a strict subset of Python, so I would expect Skylark to be well supported by all existing editors if they simply treat it as Python.


Rocket Unturned isuse Rocket <IP_ADDRESS> (#732) for Unturned <IP_ADDRESS>

It ruined everything  players could not use the /i command even when i congigured the premmsions file  could not use tpa message announcer and also i would see a red long text like a lot of times.

Can you post the error? because we cannot tell you how to fix it if you dont tell us the exact error

It's because nelson removed vote-kicking.
Go ahead and download this and put it in your Unturned Managed folder where the server is located.
https://github.com/cartman-2000/Rocket.Unturned/releases/tag/<IP_ADDRESS>

@michael5323 this didnt work for me. i get no error, either. ran update.sh, copied all the normal rocket stuff, then your update on top of that. any ideas? thanks for your effort.

You may have tried to download it while I was updating the build with the fix for the /p command, you should be able to download it now.

@cartman-2000 i dont think so. now I'm getting "Steam: Updating"
steps:
run update.sh
download linux package from site
download Rocket.Unturned.dll
move to the correct folders
run start.sh
md5's below:
4addabb2e40a4d2904a18c1607858673  RocketLauncher.exe e8bf5ca1b453fe11b38b6a071cc1c1b8  Assembly-CSharp.dll b25a066fe6b7f1c154bfc63f51a7c7f8  Rocket.API.dll 6c84a8d16316f0e1e1a7d4308ed10409  Rocket.Core.dll 76af37653f3584a8e6c448da6d5ab8b8  Rocket.Unturned.dll

@cartman-2000 Hello, just sayin my server(<IP_ADDRESS>) is having the same issue atm. The server is pretty much cracked as the permisson config doesnt seem to be working thus I cant save the server unless I'm on admin. (Before the update I'm in a permission group with 'save' and other command, now none of them are working.)
I've checked the log and found my log flooded with this error
'[Exception] Rocket.Unturned >> Exception in TriggerSend: System.NullReferenceException: Object reference not set to an instance of an object
at Rocket.Unturned.Events.UnturnedPlayerEvents.TriggerSend (SDG.Unturned.SteamPlayer s, System.String W, ESteamCall X, ESteamPacket l, System.Object[] R) [0x00000] in :0 '
Hope you can help to solve this, appreciated.


It looks like creating Action Package fails if the folder is not empty on version 0.5.3.

Target components
action_server
What is wrong
It looks like creating Action Package fails if the folder is not empty on version 0.5.3. I see the notification Action created succesfully but nothing happens, the Action is not being created.
System info

Example script
No response

This issue has been moved here, under Sema4AI/actions repository.


create_ap and connectivity on Ubuntu 18.04

On Ubuntu 18.04 - If I use the create_ap command on our router to setup the WiFi interface and connect to it with multiple devices, here is what happens:

I can connect from any client device to the external internet.
I can ping the router from any client.
I can ping any client from the router.
I cannot ping one client from another client.

So it seems like there is some issues with routing within the subnet. When I try to ping from one client to another I can see that the ARP request makes its way to the router but is not propagated to the other client device. Any tips on what to look for would be appreciated.

I meet the same-like trouble.


Can't control the strip

Hi @jim-sokoloff ,
I finally got boards and the strip, but I fail to control it. Any ideas how can I further debug it? (I got BM235 multimter and that's all, no scope)
The wiring picture is below. I simplified the code down to the bare minimum, tried two different nano boards and it still no lights are coming up. Couple of things:

The strip is probably fine, since when I mounted a vanilla nano and powered the strip + nano, lights came up randomly (some noise turned them on probably)
I checked clock/data pins and I see that +5v on clock pin.

What have I tried:

Double-checking that yellow is connected to DI and green to CI
Double-checked wiring from arduino pins down to the strip.

Here is the minimal code that I use:
#include <Adafruit_DotStar.h>
#define NUMPIXELS 60 // Number of LEDs in strip

// Here's how to control the LEDs from any two pins:
#define DATAPIN    6
#define CLOCKPIN   7
Adafruit_DotStar strip(NUMPIXELS, DATAPIN, CLOCKPIN, DOTSTAR_BRG);

void setup() {
  // put your setup code here, to run once:
  Serial.begin(115200);
  Serial.println("Hello");

  strip.begin();
  strip.show();
  strip.setPixelColor(10, 255, 127, 0);
  strip.show();

}

void loop() {
  // put your main code here, to run repeatedly:
  strip.show();
  delay(50);
}

Here is the strip I use: https://www.aliexpress.com/item/32878004298.html, 60 leds/m, IP67 white PCB if that matter.

It looks like you're maybe using pins D8 and D9 physically and D6 and D7 in the code. Hard to be sure with the picture...

Sorry; zooming in more, it looks like it's a parallax thing.

On the Aliexpress photo, it looks like maybe green is data in and yellow is clock in. Perhaps try switching those (or looking closely at the ones you have; I can't tell from your photo above which wires are going where).

I also would not use two power supplies. Use just the computer power supply to drive the Nano, then pull power off the 5V and GND from there to the LED strips. You have two USB supplies in the mix and it's not clear if they're sharing a common ground potential (and even if they are, I don't like to see a USB supply "fighting" the output of the regulator on the Nano).

If none of that helps, post a clear shot of the flex PCB where the input power comes from (so I/we can see which color is going to which line on the APA segment).

That's very interesting. I did all of what you suggest back on Sunday already. I figured out that common ground is a must. Then after your replies I checked everything again and still nothing helped.
Eventually, I decided to cut out a small strip of just 5 leds, solder 4-core wire to it and have a try. I thought maybe with my early tests something went wrong with the first LED and not it blocks traffic to the rest.
With the new stip it worked! I cut of the first led, resoldered the strip of 50 and they all worked! I reprogrammed nano it to drive just a single led and tried again with that originally-first led and it didn't work as assumed.
So here I have it. All good! I even managed to write some moving rainbow code. In action: https://www.youtube.com/watch?v=Dl4kCLGTWSw
Still, I wonder what could've gone wrong with that first led - I only plugged usb-sourced power, and my usb wart does not have quick-charge, so no way it could've zapped it with 9 volts or something. Do you have any ideas? Could have reverse polarity kill it?
Thanks again for your help!


usb: device: cdc_acm: Prevent recursive logging loop

Allow enabling CDC ACM logging only if CDC ACM is not used as logging backend. This prevents endless recursive logging loop, especially visible when minimal footprint logging is enabled.
Fixes: #52981
Signed-off-by: Tomasz Moń<EMAIL_ADDRESS>

This change seems to be causing a number of regressions.

This change seems to be causing a number of regressions.

Does the regression here essentially mean "warns about the issue at build time instead of sweeping the issue under the rug and waiting for crash at runtime"?