HBASE-23741 Data loss when WAL split to HFile enabled

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 32s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  0s
the patch passed

+1 :green_heart:
checkstyle
1m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m  6s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
findbugs
2m 58s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
asflicense
0m 14s
The patch does not generate ASF License warnings.

42m 31s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle

uname
Linux d4ad92fb7362 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1f77b1ffa5

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt

findbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 35s
master passed

+1 :green_heart:
compile
0m 57s
master passed

+1 :green_heart:
shadedjars
4m 48s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 37s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  6s
the patch passed

+1 :green_heart:
compile
0m 58s
the patch passed

+1 :green_heart:
javac
0m 58s
the patch passed

+1 :green_heart:
shadedjars
4m 46s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
the patch passed

_ Other Tests _

-1 :x:
unit
64m 17s
hbase-server in the patch failed.

90m 46s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 64e17fdcd638 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 1f77b1ffa5

Default Java
1.8.0_232

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/artifact/yetus-jdk8-hadoop2-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/testReport/

Max. process+thread count
9460 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/1/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m  2s
the patch passed

+1 :green_heart:
checkstyle
1m 12s
the patch passed

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
16m  5s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
findbugs
2m 54s
hbase-server in the patch failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 59s
the patch passed

+1 :green_heart:
compile
1m 17s
the patch passed

+1 :green_heart:
javac
1m 17s
the patch passed

+1 :green_heart:
shadedjars
5m 34s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in the patch failed.

_ Other Tests _

+1 :green_heart:
unit
77m  2s
hbase-server in the patch passed.

110m  4s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux cfdb8259849a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/2/testReport/

Max. process+thread count
6131 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/2/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Mind explaining what is the problem here?
Thanks.

Mind explaining what is the problem here?
Thanks.

The problem is that the new OutputSink didn't write seqid to cells of the recoved hfiles. So when read cell with same timestamp, the recovered hfile's cell's seqid is 0. Then the ut failed when write with same timestamp data.

Rethought this. This "load recovered hfiles" is more like commit a "flushed hfile", not bulkload. Because it doesn't need to assign a new seqid for the hfile. And there are many "bulkload" logic when read...

Mind explaining what is the problem here?
Thanks.

The problem is that the new OutputSink didn't write seqid to cells of the recoved hfiles. So when read cell with same timestamp, the recovered hfile's cell's seqid is 0. Then the ut failed when write with same timestamp data.

Why not write seqid to cells?

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
7m 28s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 46s
the patch passed

-0 :warning:
checkstyle
1m 19s
hbase-server: The patch generated 3 new + 213 unchanged - 0 fixed = 216 total (was 213)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
18m 25s
Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.

-1 :x:
findbugs
3m 15s
hbase-server in the patch failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m  9s
the patch passed

+1 :green_heart:
compile
1m  8s
the patch passed

+1 :green_heart:
javac
1m  8s
the patch passed

+1 :green_heart:
shadedjars
4m 56s
patch has no errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Other Tests _

-0 :warning:
unit
68m 59s
hbase-server in the patch failed.

98m 19s

Subsystem
Report/Notes

Docker
Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux a79445a23e4e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 31484f007f

Default Java
2020-01-14

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/3/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/3/testReport/

Max. process+thread count
9848 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/3/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 31s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 11s
the patch passed

-0 :warning:
checkstyle
1m 11s
hbase-server: The patch generated 3 new + 213 unchanged - 0 fixed = 216 total (was 213)

+1 :green_heart:
whitespace
0m  0s
The patch has no whitespace issues.

+1 :green_heart:
hadoopcheck
10m 58s
Patch does not cause any errors with Hadoop 2.10.0 or 3.1.2.

+1 :green_heart:
spotbugs
2m  9s
the patch passed

_ Other Tests _

+1 :green_heart:
asflicense
0m 13s
The patch does not generate ASF License warnings.

36m  8s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/4/artifact/yetus-general-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle

uname
Linux 9399785b34e8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 44b3ac6457

spotbugs
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/4/artifact/yetus-general-check/output/branch-spotbugs-hbase-server-warnings.html

checkstyle
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/4/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt

Max. process+thread count
93 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/4/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z) spotbugs=3.1.12

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
7m 26s
master passed

+1 :green_heart:
compile
1m 14s
master passed

-1 :x:
shadedjars
0m 10s
branch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 42s
hbase-server in master failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 59s
the patch passed

+1 :green_heart:
compile
1m 14s
the patch passed

+1 :green_heart:
javac
1m 14s
the patch passed

-1 :x:
shadedjars
0m  9s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 41s
hbase-server in the patch failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m  7s
the patch passed

+1 :green_heart:
compile
1m  7s
the patch passed

+1 :green_heart:
javac
1m  7s
the patch passed

-1 :x:
shadedjars
0m 10s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

_ Other Tests _

-0 :warning:
unit
61m 27s
hbase-server in the patch failed.

80m 22s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 358d22331f19 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 080d8645ed

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/testReport/

Max. process+thread count
5943 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 39s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
6m 13s
master passed

+1 :green_heart:
compile
0m 59s
master passed

+1 :green_heart:
shadedjars
5m 21s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 36s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 53s
the patch passed

+1 :green_heart:
compile
1m  1s
the patch passed

+1 :green_heart:
javac
1m  1s
the patch passed

+1 :green_heart:
shadedjars
5m 20s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
87m 58s
hbase-server in the patch passed.

116m 21s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 34e63a6d55b4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 080d8645ed

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/testReport/

Max. process+thread count
4515 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/5/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:broken_heart: -1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
0m 30s
Docker mode activated.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 12s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

-1 :x:
shadedjars
0m 10s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
6m 10s
the patch passed

+1 :green_heart:
compile
1m  6s
the patch passed

+1 :green_heart:
javac
1m  6s
the patch passed

-1 :x:
shadedjars
0m 10s
patch has 7 errors when building our shaded downstream artifacts.

-0 :warning:
javadoc
0m 39s
hbase-server in the patch failed.

_ Other Tests _

-0 :warning:
unit
63m  9s
hbase-server in the patch failed.

82m  4s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux bdde8d7dae15 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2a60a61a73

Default Java
2020-01-14

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/artifact/yetus-jdk11-hadoop3-check/output/branch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt

shadedjars
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/artifact/yetus-jdk11-hadoop3-check/output/patch-shadedjars.txt

javadoc
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt

unit
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/testReport/

Max. process+thread count
5843 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

:confetti_ball: +1 overall

Vote
Subsystem
Runtime
Comment

+0 :ok:
reexec
1m 12s
Docker mode activated.

-0 :warning:
yetus
0m  3s
Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck

_ Prechecks _

_ master Compile Tests _

+1 :green_heart:
mvninstall
5m 43s
master passed

+1 :green_heart:
compile
1m  1s
master passed

+1 :green_heart:
shadedjars
5m 22s
branch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
master passed

_ Patch Compile Tests _

+1 :green_heart:
mvninstall
5m 55s
the patch passed

+1 :green_heart:
compile
1m  0s
the patch passed

+1 :green_heart:
javac
1m  0s
the patch passed

+1 :green_heart:
shadedjars
5m 23s
patch has no errors when building our shaded downstream artifacts.

+1 :green_heart:
javadoc
0m 34s
the patch passed

_ Other Tests _

+1 :green_heart:
unit
93m 32s
hbase-server in the patch passed.

122m  3s

Subsystem
Report/Notes

Docker
Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile

GITHUB PR
https://github.com/apache/hbase/pull/1254

Optional Tests
javac javadoc unit shadedjars compile

uname
Linux 8c623561863e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux

Build tool
maven

Personality
dev-support/hbase-personality.sh

git revision
master / 2a60a61a73

Default Java
1.8.0_232

Test Results
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/testReport/

Max. process+thread count
4374 (vs. ulimit of 10000)

modules
C: hbase-server U: hbase-server

Console output
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1254/7/console

versions
git=2.17.1 maven=2018-06-17T18:33:14Z)

Powered by
Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.


Update mode.md

Added possible values for mode at the beginning.
Replaced provides with sets, sounds better imo.

@Legends Your fork is gone, we can't merge it :(

@Legends Yes please

@montogeek Just wanted to commit my local changes to the forked repo, but I get:

Didn't know how to exclude the modified package.json...
Therefore I've edited the file in the repo directly.
--> New PR is here


fix: allow license directive input with undefined license

Issue
n/a
Description
allow license directive input with undefined license
Additional context

🧪  Gravitee.io Automatic Prerelease @gravitee/ui-policy-studio-angular
npm install<EMAIL_ADDRESS>
yarn add<EMAIL_ADDRESS>

🧪  Gravitee.io Automatic Prerelease @gravitee/ui-particles-angular
npm install<EMAIL_ADDRESS>
yarn add<EMAIL_ADDRESS>

📚  View the storybook of this branch here

:tada: This PR is included in version 11.0.1 :tada:
The release is available on:

npm package (@latest dist-tag)
npm package (@latest dist-tag)
npm package (@latest dist-tag)
GitHub release

Your semantic-release bot :package::rocket:


ES6

Convert code to ES6. For bundling were used babel and rollup.
Ref #34

thank you for the contribution. i'm in the process of porting url-pattern to typescript instead


how add context menu for row?

how add context menu for row?

Would you like to utilize the onRowSecondaryTap callback in PlutoGrid 's constructor?


Let's encrypt certificates stop working for Android 7.0 and earlier beginning Feb 8th, 2024

Let's encrypt is phasing out their certificate cross-signing that allowed Android Devices prior to 7.1.1 to establish TLS connections.
They've announced that it will phase out begining Feb 8th, 2024.
This will result in a java.security.cert.CertPathValidatorException: Trust anchor for certification path not found. exception for every domain that renewed their certificate after that date or creates a new one.
We need to change to a trust store that trusts ISRG Root X1.

@Benno-K Waiting for 1 sync round should also inform you of the problem. I eventually get notifications for every account about being unable to fetch mail due to an error, which I can tap to bring up the server settings for that account. Note that this is on Android 14, so it's not just an issue for older versions (anymore). My phone does in fact know the ISRG Root X1 and X2 certificates so it should be able to trust my mail server just fine.
Little log excerpt:
10-23 20:47:57.317 25501 25527 E MessagingController: Caused by: com.fsck.k9.mail.CertificateValidationException: javax.net.ssl.SSLHandshakeException: java.security.cert.CertPathValidatorException: Trust anchor for certification path not found.

Not quite sure if this is actually related to the original issue, but seeing as the error is still the same I would presume it is. Does TB on Android use its own cert store like the desktop edition?


[v6.1] bash: /usr/bin/node: Operation not permitted

After upgrading jscontroller  from v3.3.x to v4.0.15, i get EPERM on logs for starting instances.
When trying manually starting node from root bash in container i get bash: /usr/bin/node: Operation not permitted

I', using ghcr.io/buanet/iobroker:v6.1.0@sha256:d8c2abe61385cd0a1462f3a8d9a001de33d58df43cc724e59283545a8cb080b6

OK, deleting and recreating container (with existing mounts/config) seems to fix the issue 😕

I have a similar issue which is reproducable. When I'm starting a v5.2.0 image in my microk8s environment with an empty volume, everthing works as expected. I can install adapters and communicate with devices.
Now I do the same with a v6.1.0 - the one you've pushed 4 hours ago - as well with an empty volume. In this case I can run the welcome/setup wizzard and finish it, but the expected device discovery dialog does not appear. Instead I get this in the logs:
Cannot get NPM version: Error: Command failed: npm -v /usr/bin/env: ‘node’: Operation not permitted
Restarting the host with the GUI does not bring back the web server. After deleting the pod k8s brings up a new container based on the previously created volume. Now I can install adapters and communicate with devices.
So just the first start is a problem.

which js-controller ist used?

js-controller 4.0.21 is used

the node capabilities need to be set anew ... so iob fix should be executed

ok I stopped admin adapter via WebUI and executed from within the container as root iob fix from /opt/iobroker. The output of the script looks fine for me:
root@iobroker-67cf4877f5-przqj:/opt/iobroker# iob fix
library: loaded
Library version=2022-02-10

==========================================================================

    Welcome to the ioBroker installation fixer!
    Script version: 2022-02-13

==========================================================================

==========================================================================
    Installing prerequisites (1/3)
==========================================================================

Get:1 http://deb.debian.org/debian bullseye InRelease [116 kB]
Get:2 http://security.debian.org/debian-security bullseye-security InRelease [44,1 kB]
Get:3 http://deb.debian.org/debian bullseye-updates InRelease [39,4 kB]
Get:4 https://deb.nodesource.com/node_14.x bullseye InRelease [4.586 B]
Get:5 http://deb.debian.org/debian bullseye/main arm64 Packages [8.070 kB]
Get:6 http://deb.debian.org/debian bullseye-updates/main arm64 Packages [2.596 B]
Get:7 http://security.debian.org/debian-security bullseye-security/main arm64 Packages [121 kB]
Get:8 https://deb.nodesource.com/node_14.x bullseye/main arm64 Packages [773 B]
Fetched 8.398 kB in 4s (2.271 kB/s)
Reading package lists... Done
Installed gcc-c++
Installed python-dev

==========================================================================
    Checking ioBroker user and directory permissions (2/3)
==========================================================================

Created /etc/sudoers.d/iobroker
Fixing directory permissions...
This system does not support setting default permissions.
Do not use npm to manually install adapters unless you know what you are doing!

==========================================================================
    Checking autostart (3/3)
==========================================================================

Unsupported init system, cannot enable autostart!

==========================================================================

    Your installation was fixed successfully
    Run iobroker start to start ioBroker again!

==========================================================================

Then i tried to execute iob commands. But again the following errors occured:
root@iobroker-67cf4877f5-przqj:/opt/iobroker# iob start
sudo: unable to execute /usr/bin/node: Operation not permitted
root@iobroker-67cf4877f5-przqj:/opt/iobroker# iob
sudo: unable to execute /usr/bin/node: Operation not permitted

What is the result of getcap $(eval readlink -f `which node`)??
@DizzelPopitzel Do you use a raspberry pi 4 with arm64v8 image too??

Yes,  raspberry pi 4 with arm64v8 image

Output of getcap is:
/usr/bin/node cap_net_bind_service,cap_net_admin,cap_net_raw=eip

Just for note, running the docker image in a kubernetes cluster is not supported so far, as I did not tested it.
So it might work, but you also can face issues like this one :)
BUT
After some testing, I think I figured out the root cause. As @Apollon77 said your capabilities are not set correctly.
As long as cap_net_admin is set on node, but not set for the container you will get the "Permission denied" issue.
So there are two ways to hopefully get your setup working:

Set cap_net_admin to your container (docker docs link)
Correct the capabilities (removing cap_net_admin)  inside your container with

sudo setcap 'cap_net_bind_service,cap_net_raw=eip' `which node`

Can you try if this workaround works?
@Apollon77 @AlCalzone I think we have to talk about our capabilities check in js-controller to detect kubernetes as we detect docker. As far as I could determine this works for docker but not for kubernetes.
Regards,
André

Great! Adding cap_net_admin makes it run as expected. Thanks for your support.

@buanet Yes I know that this is not officially supported and I appreciate the support here ;)
Both proposed workarounds fix the issue. Thank You

We did some tweaks to the Docker detection of ioBroker. Hopefully this prevents us from wrong capabilities settings as docker is detected more reliable.
However, I'll close this at this point.
Thank you.
Regards,
André


Angular Storybook's 'Centered' stories are broken.

Describe the bug
Console shows issue with styles.
To Reproduce
Steps to reproduce the behavior:
买澳洲大学毕业证文凭/代办墨尔本毕业证 WX：jywenping购买墨尔本大学毕业证成绩单\墨尔本大学学历认证\墨尔本大学使馆认证\国外文凭办理→国外学历学位认证

Looks like a spam bot.


update locales/pt_BR.json translate

Hey. Please check if it need some more modifications, thank you.

Looks good to me. Thanks!


Extension build step is broken on MacOS

Due to the differences between the behaviour of the sed command in Linux and MacOS, the current build script is broken on MacOS devices that use the default sed command
sed: 1: "./dist/chrome/manifest. ...": invalid command code .
error Command failed with exit code 1.

One possible fix that works for MacOS is to add one extra argument to the sed command in build.sh that replaces the version placeholder with the actual value, after the -i flag. Another change needed to make this work, is to replace the single quotes around the substitution with double quotes in order for string interpolation to work correctly
Changing this
sed -i 's/%VERSION%/'$version'/g' $DIST_DIR/manifest.json

with this
sed -i "" "s/%VERSION%/$version/g" $DIST_DIR/manifest.json

~Testing is needed to see if the proposed solution works in Linux~
It doesn't work with Linux, more robust solution would probably be detecting the OS and changing the args of sed accordingly

Fixed in #454


Problem to yarn start

I am trying to work with react-image-annotate library and got this error.
How to fix it? Thank you very much!

@TrongNhan30520 Try to add this configurations on the resolvers of webpack
  resolve: {
    fallback: {
      fs: false,
      tls: false,
      net: false,
      path: false,
      zlib: false,
      http: false,
      https: false,
      stream: false,
      crypto: false,
    },
  },

thank you so much

Are there any solution without using webpack ? Thank you.

@seveibar, This library providing all we required but there is an issue after installing regarding webpack version <5 config.
is there any plan to upgrade the react-scripts and other legacy versions?

I am trying to work with react-image-annotate library and got this error. How to fix it? Thank you very much!

@TrongNhan30520
Can you please tell me which solution is worked for you?

same problem. why so many dependencies?

@parthpatel303 @Dogancan94 I use react 17.0.2 so i don't get error

@TrongNhan30520 Try to add this configurations on the resolvers of webpack
  resolve: {
    fallback: {
      fs: false,
      tls: false,
      net: false,
      path: false,
      zlib: false,
      http: false,
      https: false,
      stream: false,
      crypto: false,
    },
  },

after add this settings the component renders correctly for me

After adding these settings in webpack.config.js, i'm getting below error:


Mapping Checkbox field in Jira to a Boolean field in Azure DevOps

I have been trying to map a checkbox field in JIra to a Boolean field in ADO without success. I get the following error message:
[E][15:54:47] Error mapping field 'Custom.XXXXOptions' on item 'LIC-99'.
[System.NullReferenceException] System.NullReferenceException: Object reference not set to an instance of an object.
at JiraExport.JiraMapper.<>c__DisplayClass14_01.<IfChanged>b__0(JiraRevision r)    at JiraExport.JiraMapper.MapFields(JiraRevision r):    at JiraExport.JiraMapper.<>c__DisplayClass14_01.b__0(JiraRevision r)
at JiraExport.JiraMapper.MapFields(JiraRevision r)
I am using the below in my config file:
{
"source": "XXXX Options",
"source-type": "name",
"target": "Custom.XXXXOptions"
},
I have searched the FAQ but have not found anything that seems to solve my problem.
Is what I am doing possible?

@C-F-Palmer What version of Jira is this?
I did a test against Jira Cloud with the below field map:
      {
        "source": "alexander-testar-custom-checkboxes",
        "source-type": "name",
        "target": "Custom.CustomCheckboxes"
      },

Here I have defined a custom field of the standard type "Checkboxes", and set the value only on the first revision:

As you can see, the resulting work item contains the correct mapped value on the first revision:
    {
      "Author"<EMAIL_ADDRESS>      "Time": "2023-12-22T19:29:46.337+01:00",
      "Index": 0,
      "Fields": [
        {
          "ReferenceName": "System.Title",
          "Value": "[AGILEDEMO-43] [Jira smoke tests] Task with custom checkboxes"
        },
        {
          "ReferenceName": "Microsoft.VSTS.Common.Priority",
          "Value": "3"
        },
        {
          "ReferenceName": "Custom.Reference",
          "Value": "AGILEDEMO-43"
        },
        {
          "ReferenceName": "Custom.CustomCheckboxes",
          "Value": "Option 1;Option b"
        },
        {
          "ReferenceName": "System.State",
          "Value": "New"
        }
      ],

Check if there are any major differences between our cases and let me know if you find anything significant!

Just a gut feeling: before v3.0.310 and to be precise PR #901, you would get a null reference exception if the mapping contains a custom field that does not exist in Jira. Can you try this again with the latest version?

@Jbekker I trust your gut feeling 😆
Do you know right now where in the code this null reference exception would arise?

For sure! please see https://github.com/solidify/jira-azuredevops-migrator/blob/v3.0.308/src/WorkItemMigrator/JiraExport/JiraMapper.cs#L400
Variable customFieldName can be null when the field with the specified name in the configuration can't be found. In that case customFieldName.toLower() would give the null reference exception.

Just a gut feeling: before v3.0.310 and to be precise PR #901, you would get a null reference exception if the mapping contains a custom field that does not exist in Jira. Can you try this again with the latest version?

Hi Alexander and Jelle,
Happy New Year to you both!!
Jelle was correct. I upgraded to the latest version (3.0.328) and I no longer get the error message.
However the field is not being mapped.
Jira Field:

Azure Field:

Export Log:
====================================================================
Jira Export Log
Tool version : 3.0.328
Start time   : 03/01/2024 11:35:16
Telemetry    : Enabled
Session id   : 6d02e98a-d3c6-4186-bdde-eb1db77808fa
Tool user    : IKONSCIENCE\cpalmer
Config       : config-scrum.json
Force        : yes
Log level    : Debug
Machine      : xxxxxxxx
System       : Microsoft Windows 10.0.22621
Jira url     : http://xxxxxxxxxx
Jira user    : chris.palmer
Jira version : 7.11.1
Jira type    : Server
[I][11:35:15] Connecting to Jira...
[I][11:35:15] Retrieving Jira fields...
[I][11:35:16] Retrieving Jira link types...
[D][11:35:16]    Get item count using query: 'project = LIC AND key = LIC-52'
[I][11:35:16] Export started. Selecting 1 items.
[W][11:35:16] User mapping file 'C:\Jira Export 3.0.328\users.txt' not found, ignoring mapping user identities.
[I][11:35:16] Initializing Jira field mapping...
[W][11:35:16] Could not find the field id for 'XXX Options', please check the field mapping!
[W][11:35:16] Could not find the field id for 'XX Options', please check the field mapping!
[W][11:35:16] Could not find the field id for 'XXXXXXXXX Options', please check the field mapping!
[W][11:35:16] Could not find the field id for 'XXXXX Options', please check the field mapping!
[W][11:35:16] Could not find the field id for 'Flag Options', please check the field mapping!
[W][11:35:16] Could not find the field id for 'XXXXXXX Options', please check the field mapping!
[W][11:35:16] Could not find the field id for 'XXXX Options', please check the field mapping!
I am using this format in my mapping file:
{
"source": "XXXX Options",
"source-type": "name",
"target": "Custom.XXXXOptions"
},
Not sure what I am doing wrong now?

Please hold off investigating my above comments. I think I know where I am going wrong. Although the JIra field is a checkbox when you edit/select it, it does however add the name of the checkbox to the field and therefore using a boolean field in ADO will probably not work for this.

Happy new year @C-F-Palmer ! :)
Check the FAQ section for mapping custom fields maybe if you haven't already? There are some recommendations and troubleshooting guides there: https://github.com/solidify/jira-azuredevops-migrator/blob/master/docs/faq.md#3-how-to-map-custom-field

I have this working now. Thanks for your help. I changed the ADO field from a Boolean field type to a text single line field type.

Perfect.
I will address the nullreference exception mentioned here as soon as I have time: https://github.com/solidify/jira-azuredevops-migrator/issues/935#issuecomment-1875166578

Looks like the problematic line was already removed in v3.0.310. I'm closing this issue now, as all works seems to be done. Feel free to reopen the issue if the problem persists or if you have any questions or concerns.


Use shared-secret hmac to authenticate messages

Expected behavior
After creating a shared secret with an HMAC we should use it to authenticate incoming/outgoing messages.
Actual behavior
Every message is signed and verified with the ecdsa Public/Private key pair.
Why ?
It is much cheaper using a shared symmetric key.
handshake and session code is found inside p2p/net/network.go, p2p/net/handshake.go, p2p/net/session.go
messages are sent (signed) are received  (auth) in swarm.go. signing and authentication should be replaced to be using the session HMAC.

#210  will replace this


created index.md for hyperledger

created index.md for hyperledger

[ ] I have read freeCodeCamp's contribution guidelines.
[ ] My pull request has a descriptive title (not a vague title like Update index.md)
[ ] My pull request targets the master branch of freeCodeCamp.
[ ] None of my changes are plagiarized from another source without proper attribution.
[ ] My article does not contain shortened URLs or affiliate links.

If your pull request closes a GitHub issue, replace the XXXXX below with the issue number.
Closes #XXXXX

Hi,
Thanks for this pull request (PR).
Unfortunately, we are closing this PR, because many parts appear to be plagiarized from https://medium.com/swlh/hyperledger-chapter-1-foundation-7ad5bd94d452
Feel free to submit another PR though.
Thank you


Adding Beeceptor's CRUD APIs.  Cleanup of deprecated tools.

Thank you for taking the time to work on a Pull Request for this project!
To ensure your PR is dealt with swiftly please check the following:

[x] Your submissions are formatted according to the guidelines in the contributing guide
[x] Your additions are ordered alphabetically
[x] Your submission has a useful description
[x] The description does not end with punctuation
[x] Each table column should be padded with one space on either side
[x] You have searched the repository for any relevant issues or pull requests
[x] Any category you are creating has the minimum requirement of 3 items
[x] All changes have been squashed into a single commit

Removed two tools that are not accessible.
Added Beeceptor's CRUD APIs which are stateful, and you can store JSON object and retrieve using ID.


Copy error, page 1, second paragraph

Guessing this ...

"The first line — import Text — imports the Graphics.Element module"

should actually save something like "The first line imports the Graphics.Element module."

Thank you. Leftover from a previous version. Corrected.


Single Planning Calendar selection period button not shown

OpenUI5 version:
1.109.0 and above
Browser/version (+device/version):
Chrome on Windows 10 --> Fail
Firefox on WIndows 10 --> Fail
Any other tested browsers/devices(OK/FAIL):
none
URL (minimal example if possible):
https://openui5.hana.ondemand.com/1.109.0/#/entity/sap.m.SinglePlanningCalendar/sample/sap.m.sample.SinglePlanningCalendar
And every newer ui5 Version of the sample (change 1.109.0 to the Version in URL)
Steps to reproduce the problem:

Open the URL

Over next to the Date navigator and it will highlight an empty button
What is the expected result?
It should work like the sample with version 1.108.4 and Versions below (haven't tested all e.g. in 1.71.46 it works)
https://openui5.hana.ondemand.com/1.108.4/#/entity/sap.m.SinglePlanningCalendar/sample/sap.m.sample.SinglePlanningCalendar
If you hover next to the date selector it should show a button with the date that is currently display. (e.g. 6 July 2018 - when the view is set to day, or the time period 09. July 2018 - 15. July 2018) in the users locale format

What happens instead?
As described above a blank button is displayed.

Cf. https://github.com/SAP/openui5/issues/3695#issuecomment-1424141056

Hello @NKN30,
As already mentioned above, the issue is known and already fixed with the following commit: https://github.com/SAP/openui5/commit/110708f296bd592407af43984c1f286ada5a65ca
You can test here: https://openui5nightly.hana.ondemand.com/entity/sap.m.SinglePlanningCalendar/sample/sap.m.sample.SinglePlanningCalendar
As 1.109 is not a maintenance version, we are not able to downport the fix there.
Kind Regards,
Niya


Add check for LogicalFile without files

LogicalFiles without files on the system are invalid and can cause problems in a HydroShare resource.  Because the file system is our source of truth, we are safe to remove these LogicalFiles with the logical_delete method

Fileset (logical file) by design can exists without any files.

We have not seen problems caused by this since and the move towards file-based aggregations will  change this behavior.


Add disable attribute

I am using this rule in a multi-platform environment where it's internals are not necessarily properly supported everywhere. In such a case it would be nice if we can actually "deactivate" the rule so that is generates a simply empty JSON list instead.
This can then be used with a select statement:
compilation_database(
    name = "my_compilation_database",
    targets = [
        "//:bar",
        "//:foo",
    ],
    disable = select({
        "@bazel_tools//platforms:windows": True,
        "//conditions:default": False,
    }),
)

I don't know about the failure of the diff in CI. I can't reproduce it locally.

Sorry for the delay in my response. The build failure you were observing was because of buildifier reordering the struct values, and because the latest bazel version is dropping some flags in the default CROSSTOOL.
I have pushed updated to fix the test.
As for disabling the rule on Windows, I think we should make it seamless. Can you try 115925a22f6d3549682ad85131c331c9193152cb and see if it works for you? If it does not, we can add the attribute as in this PR.
Thanks for your patience.

Hello @siddharthab. No worries for the delay.
As much as I understand and appreciate the proposed solution in 115925a22f6d3549682ad85131c331c9193152cb it does not really work for my use-case. I use Bazel in a professional capacity for a great number of platforms beyond Windows and the compilation_database rule does not work on some of them but does on others. Hence the fine-grained control that I would like to expose with the disable attribute.


Support Firebase Cloud Messaging

Firebase Cloud Messaging (FCM) is new version of GCM.
Support FCM endpoint and add tests for it.

Pull request can't get environment variable from travis, so I can't pass the check.

As stated by Google on its documention, FCM shouldn't be used for websites, but only for Chrome apps and extensions. Because this library is specifically designed for Web Push (and thus websites), I wonder if this belongs here.
Note that GCM is supported by WebPush only because it was the only way to support Chrome browsers in the past. And the bare minimum of GCM features are implemented here.
Can you explain why you would need this? Does Firebase support other browsers such as Safari, Opera, Edge?

@Minishlink Chrome started to use FCM for Web Push too, but not in the way implemented in this PR. FCM for Chrome supports the Web Push standard.
See https://github.com/web-push-libs/web-push/pull/180 and https://github.com/web-push-libs/web-push/pull/183 for more details.

Hello, my original requirement is migration from GCM to FCM and push notification by php. Because subscribe id in GCM is supported in FCM, I replace endpoint url in server side directly. Chrome support the Web Push protocol from Chrome 52. I might misunderstand how to use it.
https://github.com/web-push-libs/web-push/pull/70 for more details

I migrated my website to Firebase in order to test this and I noticed that the API key stayed the same. We're going to make a quick and more simple solution since GCM/FCM will use VAPID in the future: WebPush will add the Authorization header with the GCM API key if it detects a GCM or FCM URL.


Add RTL text to pdf

Hi, I tried to add RTL (Arabic) text to pdf, but the text added flipped
could you please help me to correct it?

@TomRoush PDFTextStripper does not support RTL languages?


Remove allocatable attributes of help_text, version_text arguments in set_args subroutine?

First of all, thank you @urbanjost  for writing this library, it's very cool.
In the process of using the M_CLI2 library, I found that the allocatable attributes of help_text and version_text do not seem to be so necessary.
Removing the allocatable attributes makes the set_args interface more lenient, allowing the user to enter an array of constant strings (character(*), parameter :: help_text(*) = [...]).
I made such a modification (a commit), and it looks like there are no apparent issues.
program main

    use M_CLI2
    character(*), parameter :: help_text(*) = [character(10) :: "help1", "help2"]
    character(:), allocatable :: version_text(:)

    version_text = [character(10) :: "version1", "version2"]
    call set_args("", help_text, version_text)

end program main

Before:
>> fpm run -- --help
M_CLI2.F90                             done.
libdemo.a                              done.
main.f90                               failed.
[  75%]Compiling...
app\main.f90:8:22:

    8 |     call set_args("", help_text, version_text)
      |                      1
Error: Actual argument at (1) to allocatable or pointer dummy argument 'help_text' must have a deferred length type parameter if
and only if the dummy has one
<ERROR> Compilation failed for object " app_main.f90.o "
<ERROR>stopping due to failed compilation
STOP 1

After:
>> fpm run -- --help
M_CLI2.F90                             done.
libdemo.a                              done.
main.f90                               done.
demo.exe                               done.
[100%] Project compiled successfully.
help1
help2

Had a little trouble with the github merge, but it appears to have worked this time. This makes M_CLI2 usage more general, which is a main focus of the package.  Thanks!


Is there a way to adjust the merging ratio?

In diffusers lora documentation, you can adjust the merging ratio through cross_attention_kwargs
is there a way to do that with this safetensor approach?
If not, do you know how to convert lora safetensor to diffusers weights? I tried to use scripts that convert ckpt/safetensor to diffusers, none of them worked

(1) Yes, you can adjust the merging ratio (see here). The alpha is the ratio. I will update README.md to make it more clear.
(2) What do you mean by do that with this safetensors approach? What we have done is to insert or merge a small LoRA layer into existing models in diffusers. What is your LoRA safetensors, could you provide it and what is the error message? We have provided this example to help converting. You can also check this PR in diffusers.
If you have further questions, just pin me here.
@zhuofengli

Thank you. alpha should be what I was looking for
My other question was do you know how to convert safetensor to diffusers weights? (Such as this one)

I see what you mean. It seems that many others (https://github.com/haofanwang/Lora-for-Diffusers/issues/1) are getting confused about different saving formats. Don't worry, Let me give more explanations here.
(1) LoRA and safetensors are two different things. LoRA is a training strategy where you usually train an extra small model, while safetensors is a saving format just like .pth or .ckpt.
(2) LoRA can be saved into different formats, which sometimes can drive us crazy.  In model platforms like civitai, LoRA is saved in .safetensors; In the training example from diffusers, it is saved in .bin.
(3) Converting from .safetensors to .bin is not very common actually, and we cannot support it now. Could you describe a bit more about in what cases you need it? If you just want to use it in diffusers, pipe.unet.load_attn_procs() should already be fine. If you want to use such format in AUTOMATIC1111/stable-diffusion-webui, I suggest to save the full model after loading LoRA as pipe.unet.load_attn_procs(), which may be not very flexible, but should work. For now, this repo is mainly targeting for diffusers.
(4) In summary, what we can do are as below

If you train your LoRA using diffusers example, you will get the new added LoRA weights in .bin. If so, diffusers has already supported to load it via pipe.unet.load_attn_procs(). No need to do any converting.
If you have your LoRA weights in .safetensors from other platforms (cititai), you can use our code (see Lora model only part) to merge it into existing stable-diffusion model. Then, you will get a full model in diffusers format as runwayml/stable-diffusion-v1-5. You can load it via pipe.from_pretrained()
If you have the full model (basemodel + LoRA) in .safetensors or .ckpt from other platforms (cititai, huggingface), you can use our code (see Full model part) to convert it to regular diffusers format as runwayml/stable-diffusion-v1-5. You can load it via pipe.from_pretrained().

@zhuofengli Please let me know if this helps.

Thanks for the detailed explanation
What I wanted to achieve is:

download .safetensor from civitai
convert it to the format that can be used by diffusers (seems it's the .bin file)
at run time, use pipe.unet.load_attn_procs() to load the .bin lora file with a base model (this could be any SD based model)
note that we don't want to produce a merged model here, as there could be tens of loras and tens of models for user to select from

basically just trying to follow the official diffusers example here
Now I realize the approach above might not necessarily be more optimal than your convert_lora_safetensor_to_diffusers.py in this repo, which basically skips the 2nd step.

I'm trying to map the keys in safetensors to bin. I will pin you once I finish. In fact, it is very similar to the script provided.

@zhuofengli
Try this https://github.com/haofanwang/Lora-for-Diffusers/blob/main/format_convert.py#L161. I'm not sure whether it works, but the converting is fine. pipe.unet.load_attn_procs() only works on UNet in diffusers, while .safetensors files from civitai are usually of text encoder LoRA weights (not support in diffusers yet), for now, I just directly skip these weights. So it would be problematic if the given .safetensors contains some unsupported LoRA weights.
One more thing I wanna mention is that the naming rule is not uniform in .safetensors, thus the converting script is not generalized to all. But at least, it can give you some insights and you can speed less time to fit our need.

@haofanwang Thanks for the explanation, but I'm still having issues with adjusting the weight with alpha. Some LORAs that work fine on AUTOKATIC1111's WebUi with weights just below 1 need a very low weight with your code.  How does the weight scale? If I use the tag lora:modelname:1 in WebUi, does it correspond to alpha=1? If I use two LORAS, let's say  lora:modelname1:0.5 and lora:modelname2:0.5, does it correspond to running your code twice sequentially with alpha=0.5?


free clusterer fixed a memory leak. TODO: free protolists referenced in normprotolist

cntraining clusterer's are deleted, the last one is saved and used during final write, it seems. However there are still leaks with the protolists.. we still store the old protolists in the NormProtoList. This needs to be fixed somehow.
mftraining memory leaks are fixed.

I think I fixed this issue with the code I pushed in 4.00.


HTML rev-ing

Currently you rev all files except html.
Is there any reason why not to do it?
I think the best would be to have all the files (except index.html) rev-ed.

Rev-ing html files will break the file that reference it (the component)
HTML files in component are templates to the component, and can be precompiled with ngc

I'll implement it if it's ready


Add helper method to get snet.Addr from any service of a SVCType

currently we have this code repeated in many places:
	svcInfo, err := topo.GetSvcInfo(proto.ServiceType_ps)
	if err != nil {
		log.Error("..Failed to get svcInfo for PS", "err", err)
		return
	}
	topoAddr := svcInfo.GetAnyTopoAddr()
	if topoAddr == nil {
		log.Error("...No PS found in topology")
		return
	}
	a := &snet.Addr{
		IA:      topo.ISD_AS,
		Host:    topoAddr.PublicAddr(topo.Overlay),
		NextHop: topoAddr.OverlayAddr(topo.Overlay),
	}

we should have a helper method for this.

fixed in #2666


added coset_diff

This change is

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.93%. Comparing base (51f227b) to head (b96a949).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #583      +/-   ##
==========================================
+ Coverage   93.90%   93.93%   +0.03%
==========================================
  Files          67       67
  Lines        8419     8465      +46
  Branches     8419     8465      +46
==========================================
+ Hits         7906     7952      +46
  Misses        449      449
  Partials       64       64

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

#588
#583  👈
dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @ohad-starkware and the rest of your teammates on  Graphite


Not able to install extensions

I followed the instructions here (https://github.com/zaggino/brackets-npm-registry) and I can now see the list of extensions when I click on the 'npm' icon in the right toolbar. However, when I click on 'Install' on one of the extensions, I get this error:

Any pointers on where I went wrong? Thanks a lot.

What OS are you on?

Seems like the extension has problems creating a symlink: https://github.com/zaggino/brackets-npm-registry/blob/f724ba47d85947df254f66af94b45588e8cd5dd5/src/node/node-ensure.js#L30-L51
Do you have nodejs installed on your machine?

Yes I do. node -v gives me v4.2.2

What's the node's location? What does which node give you?


fix(declarative) fix memory leaks when loading a declarative config that

fails schema validation
When a declarative config fails schema validation, we attempts to
re-load the config again after populating the foreign keys
(see kong.db.schema.others.declarative_config.flatten).
Inside flatten we call the kong.db.schema.others.declarative_config.load
function, which reloads the schema objects and insert them into
the all_schemas global table without first clearing it.
The result is that the all_schemas table will keep growing
indefinitely and eventually causes Nginx to be OOM killed.
This PR attempts to fix the issue by clearing the all_schemas table
every time load is called, which according to my test indeed prevents
the memory from leaking anymore.
closes #5732

This should have been targeted for master.
Can we cherry pick to master to include this in 2.0.4?


Remove NuGet configs of several submodules

https://github.com/dotnet/installer/pull/16386
https://github.com/dotnet/source-build/issues/3152
https://github.com/dotnet/source-build/issues/3230

@MichaelSimons this one is needed as well

I see this auto-merged.  Isn't that a potential issue given https://github.com/dotnet/installer/pull/16386 is not yet merged?  If another installer PR is merged before https://github.com/dotnet/installer/pull/16386 is merged then the NuGet.configs will get mirrored again.

Only problem could happen if there was a change to one of the NuGet.config files in between that. And I don't think that's likely.

As in, we'd have to merge a change from SB externals that would also be changing a submodule that just changed a config


enforce linting / formatting standards (#80)

@dillionverma
I think the Pull Request unit is too large. We need to verify if it working

agreed I would prefer smaller PRs, but this gave me a lot of ideas of what to potentially try and how to setup prettier / linting

HI @abdrahmanES1 ,
If your changes are independent, please could you cherry-pick  your commits and open pull requests with small changes.
I know the files changes are affected by the linter but a detailed description can be very helpful for the maintainers.
@dillionverma , what do you think about changing the target branch to dev and verify the changes through code spaces.


tcp listener

#5 TCP Listener example.

Can you also add link to Deno.listen API at https://deno.land/api?s=Deno.listen by @resource tag?

Sure thing.

In general, the code LGTM. I think almost every single line should have a comment explaining it since this is relatively technical stuff.
I would also point users to the http examples because I would imagine that as a beginner you wouldn't really know the difference between the http and tcp. Most people really should be dealing with stuff at the http level imo.


Is raven_compat needed anymore?

All the docs seem to reference imports as e.g.:
from raven.contrib.django.raven_compat.models import sentry_exception_handler

While:
from raven.contrib.django.models import sentry_exception_handler

Seems to work just fine.  Is raven_compat strictly needed, or is it a backward compatability fix that just never got updated?  If it isn't needed it would be great to cleanup the docs.

Django doesn't (or didn't) support apps with the same trailing name. We created raven_compat as a 'unique' app name for Django.


--validate/-V option loads unrelated rules files (regression in 0.32.0)

I noticed that when running falco 0.32.0 with -V that falco reads falco.yaml and additionally loads any rules files named in falco.yaml:
$ falco --version
Falco version: 0.32.0
Driver version: 39ae7d40496793cf3d3e7890c9bbdc202263836b
mstemm@mstemm-ubuntu-2004:~/work/oss-falco-build$ falco -V /mnt/sf_mstemm/Documents/work/src/falco/test/rules/invalid_missing_rule_name.yaml
Wed Jun 22 10:27:15 2022: Falco version 0.32.0 (driver version 39ae7d40496793cf3d3e7890c9bbdc202263836b)
Wed Jun 22 10:27:15 2022: Falco initialized with configuration file /etc/falco/falco.yaml
Wed Jun 22 10:27:15 2022: Loading rules from file /etc/falco/falco_rules.yaml:
Wed Jun 22 10:27:15 2022: Loading rules from file /etc/falco/falco_rules.local.yaml:
Wed Jun 22 10:27:15 2022: Validating rules file(s):
Wed Jun 22 10:27:15 2022:    /mnt/sf_mstemm/Documents/work/src/falco/test/rules/invalid_missing_rule_name.yaml
1 errors:
Rule name is empty
---
- rule:
  desc: some desc
  condition: evt.type=execve
  output: some output
---
Error: 1 errors:
Rule name is empty
---
- rule:
  desc: some desc
  condition: evt.type=execve
  output: some output
---

However, falco 0.31.1 only reads any rules files from -V options:
$ falco --version
Falco version: 0.31.1
Driver version: b7eb0dd65226a8dc254d228c8d950d07bf3521d2
mstemm@mstemm-ubuntu-2004:~/work/oss-falco-build$ falco -V /mnt/sf_mstemm/Documents/work/src/falco/test/rules/invalid_missing_rule_name.yaml
Wed Jun 22 10:28:30 2022: Validating rules file(s):
Wed Jun 22 10:28:30 2022:    /mnt/sf_mstemm/Documents/work/src/falco/test/rules/invalid_missing_rule_name.yaml
1 errors:
Rule name is empty
---
- rule:
  desc: some desc
  condition: evt.type=execve
  output: some output
---
Wed Jun 22 10:28:30 2022: Runtime error: 1 errors:
Rule name is empty
---
- rule:
  desc: some desc
  condition: evt.type=execve
  output: some output
---
. Exiting.

This is probably a regression I introduced in https://github.com/falcosecurity/falco/pull/1953.

Falco version: 0.32.0

System info:

{
  "machine": "x86_64",
  "nodename": "mstemm-ubuntu-2004",
  "release": "5.4.0-90-generic",
  "sysname": "Linux",
  "version": "#101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021"
}

Cloud provider or hardware configuration: N/A
OS:

NAME="Ubuntu"
VERSION="20.04.4 LTS (Focal Fossa)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 20.04.4 LTS"
VERSION_ID="20.04"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=focal
UBUNTU_CODENAME=focal

Kernel:

Linux mstemm-ubuntu-2004 5.4.0-90-generic #101-Ubuntu SMP Fri Oct 15 20:00:55 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux

Installation method:
via apt-get

Additional context

I think we can fix this by playing around with the ordering of the app actions.

Yeah I believe I fixed it in https://github.com/falcosecurity/falco/pull/2088.


Better error message when up.json is missing

Prerequisites

[x] I am running the latest version. (up upgrade)
[x] I searched to see if the issue already exists.
[x] I inspected the verbose debug output with the -v, --verbose flag.
[ ] Are you an Up Pro subscriber?

Description
I came across an error message which could possibly be improved, while I was trying to trying to set up CI on my project. My project is a mono repo, and the up project is in a subdirectory. I was being daft, and running up in the root directory, instead of the subdirectory with up.json. It took me quite a while to find out what the problem was, because of the error message.
Steps to Reproduce
docker run -ti node:6.10 /bin/bash
# inside the docker container
curl -f https://up.apex.sh/install | sh
mkdir ./empty-dir
cd ./empty-dir
up

# error message:
Error: Cannot find credentials, visit https://up.docs.apex.sh/#aws_credentials for help.

# expected something like
No up.json found ...

Note, if I run up [0.4.10] on my OS X 10.12.6, I get the expected:
No up.json found, create a new project? (Y/n)

Hi, I just hit this again today, in a Semaphore CI build, the up.json file was missing on this specific branch. I was confused and it took me a while to figure out what the problem was, so I'm reopening. Hope that's okay.


Chore/readme-updates

Hey @XVincentX,
Made a few upgrades to the readme by adding visuals and a few subtle references to Stoplight. It also adds contract testing as a major use case in the header. @marbemac suggested we update our docs to write more about the contract testing use case and link it here.
Let me know what you think. Happy to make changes and help with docs.

@XVincentX Thanks for the review! Made a few changes based on the comments:

Removed the HTML to use markdown only

Added an alt text to the header. Moreover, the image used is an SVG so its indexable by search engines. See how it looks now in the terminal:

Removed the license file and picture from Ecologi (Agree, it was too much)

For the use case, removed the pull request part. What we are looking to do is get a few case studies for prism to put in a list here much like the list of people using OpenAPI code generator

Added an overview section as that is what shows up as the heading in table of contents in Stoplight. Also, this should make it a little easier to navigate through the readme on GitHub.

For CircleCI link, you mean the build status? That's a common practice i believe.

The Stoplight links i added should mostly be useful for people. Like somebody looking for a hosted version or Studio's integration. Any particular links that you think we should remove?

P.S. This is the analog that I mostly used for some of the design changes: https://github.com/segmentio/evergreen

If I can offer an opinion, I think this is a good PR which adds consistency with how things look in Spectral. Previous spectral had a logo and Prism didnt so they were lacking consistency.
I think the ToC is fine (can be updated automatically with a VS Code plugin) and yeah there are some bugs you're noticing Nauman, can you make sure you make GitHub Issues for them in platform-internal and @ me in them or DM them over so I can chase them through?
Emojis are everywhere but its a current trend, and we dont wanna be old men shaking their walking sticks at the youths complaining about their skateboards and their hippety hop. Let's just go along with the trend for now. :)

Thanks @philsturgeon! I'll keep an eye out and make issues where required.
@XVincentX Think it's in a good spot to get it merged?


bugfix/emoji-delete-bug-issue-61

Converted string of emojis into array of emojis.
This is a functionality fix, unaffected by upcoming UI changes. Can delay PR merge till after the UI change, will not cause merge conflicts either.

It also has some merge conflicts, please resolve them too

Please look into the preview

@Substancia when you are done, please leave a comment.
Thanks

@Rudresh-pandey can you please confirm on the latest commit whether this problem persists? I can't reproduce this.
@aditya-singh9 The footer seems to be not appropriately coded, and has an individual library used just for the footer into which I'll have to look into first. I think we can take it up under the footer issue or an entirely new issue maybe?
New commits have been made merging the UI changes, resolving merge conflicts, and reapplying changes. Please take a look.

Sorry it was my mistake , i added the website footer code in mobile view

Can we shift the footer conversation to the footer issue? That way we can decouple the problems and close (or discuss) only this bug here.

My bad on the footer issue, somehow a position attribute got added accidentally while rebasing my branch. I've put it back to how it was.

Looks like originally the footer won't stick to the bottom when the emojis list is empty. Do we want it that way?

@Substancia  , @aditya-singh9 , @ArunBohra12
plz try to run this #72 in your local server and check whether it's working or not

@Rudresh-pandey the desktop/mobile view switching is working on mine, but the footer isn't sticking when width < 1400px.

Everythings working iguess
Preview

@Rudresh-pandey @aditya-singh9 the footer in big screen is on right side, is that intentional?

My bad on the footer issue, somehow a position attribute got added accidentally while rebasing my branch. I've put it back to how it was.

Looks like originally the footer won't stick to the bottom when the emojis list is empty. Do we want it that way?

yes we want the footer at the bottom when list is empty in mobile view and tablet view

I guess we should address these somewhere else.


Initial sample htm refactors

Slow / Vanishing Pages added.
Next step is to integrate these in and put the home / section_experiments page on a massive diet!
Then from there hopefully we're pretty much sorted.

ping @mnohai-mdsol / @tgaff

LGTM, nice job


configgentest: avoid running kubecontroller 2x

It seems we're calling the kubecontrollers Run method 2x  in our tests.

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
5f2c76c9ea8b1937c143dfec2661ce96048686f1
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
5f2c76c9ea8b1937c143dfec2661ce96048686f1
link
true
/test gencheck_istio

lint_istio
5f2c76c9ea8b1937c143dfec2661ce96048686f1
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
5f2c76c9ea8b1937c143dfec2661ce96048686f1
link
true
/test gencheck_istio

lint_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test lint_istio

gencheck_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test lint_istio

gencheck_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test gencheck_istio

unit-tests_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test gencheck_istio

unit-tests_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test unit-tests_istio

lint_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
09aeaac145d076dcb03ec1fba020011ad6678145
link
true
/test unit-tests_istio

lint_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test lint_istio

gencheck_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test lint_istio

gencheck_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test gencheck_istio

unit-tests_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

gencheck_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test gencheck_istio

unit-tests_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test unit-tests_istio

lint_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test lint_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
d14ba5e5ddec3beb17682e09988f83d4edde58d2
link
true
/test unit-tests_istio

lint_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test lint_istio

gencheck_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test gencheck_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test lint_istio

gencheck_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test gencheck_istio

unit-tests_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

lint_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test lint_istio

gencheck_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test gencheck_istio

unit-tests_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test unit-tests_istio

integ-security-multicluster-tests_istio
4f07415b153c1310a50b483a99cc99d1006fa4dd
link
true
/test integ-security-multicluster-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
73e317fbeacec79c41e3284a28226c3f9714e580
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@stevenctl: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name
Commit
Details
Required
Rerun command

unit-tests_istio
8e2eb5646c191ea23f397dcf60ccfe517cc6f47c
link
true
/test unit-tests_istio

Instructions for interacting with me using PR comments are available here.  If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.


WPD-142

https://kindergarten.stxnext.pl/browse/WDP-142

Ur build is broken, u've added aps which u don't have in confg file. There fore u can't build project from scratch. Correct it.


Feat resource registration

This PR adds the resource registration api. Refer to the implementation of an image registry, use http POST seems a good choice.
However, as confidential resource insertion is different from retrievement, it should ensure the caller is either the owner of the KBS or the owner of the repository. For test, This pr wraps all registration-related code into a feature unsafe, meaning this is only for test.

This way seems a little weird that the API is open to all people. Another choice is to also open an gRPC server only listening to localhost requests to handle registration requests, in this way to avoid unexpected access from the anonymous remotely. I'm not sure about this, plz share your views and let me do some change.

cc @sameo @jialez0

Maybe we can add a very simple signup and login API, for example:
type UserMap = HashMap<String, String>;
struct UserInfo {
    username: String,
    password: String,
}

/// POST /signup
pub(crate) async fn signup(
    user_info: web::Json<UserInfo>,
    users_list: web::Data<UserMap>,
    timeout: web::Data<i64>,
) -> HttpResponse {}

/// POST /login
pub(crate) async fn signup(
    user_info: web::Json<UserInfo>,
    users: web::Data<UserMap>,
    sessions: web::Data<SessionMap<'_>>,
    timeout: web::Data<i64>,
) -> HttpResponse {}

If users want to register resources, they must first log in and get cookie, and then post their resources with cookie.

@Xynnn007 Maybe we can add a simple signup and login API, for example:
type UserMap = HashMap<String, String>;
struct UserInfo {
    username: String,
    password: String,
}

/// POST /signup
pub(crate) async fn signup(
    user_info: web::Json<UserInfo>,
    users_list: web::Data<UserMap>,
    timeout: web::Data<i64>,
) -> HttpResponse {}

/// POST /login
pub(crate) async fn login(
    user_info: web::Json<UserInfo>,
    users: web::Data<UserMap>,
    sessions: web::Data<SessionMap<'_>>,
    timeout: web::Data<i64>,
) -> HttpResponse {}

If users want to register resources, they must first log in to get cookie, and then post their resources with cookie.
Each user can only modify the resources in the repository with username as the name. For example, user {username: Alice, password: 123456} can only post resources like /kbs/v0/resource/Alice/<type>/<tag>.

That's a good idea at my first impression. In my understanding user cookie is a kind of user token to show the identity of the user. Maybe we should talk about the user token here furthur, about how it can co-work with KBS/Pod/Tenant identity machinism to let only specific pod/user can access specific repo (like policy.json, etc)

@Xynnn007 Can we hold on this PR until we get HTTPS (#41) support in?
Then with HTTPS enabled by default, we can start thinking about authenticated APIs, and I suggest we use JWT for that purpose. Then we can add an experimental or insecure feature gating the ability to use any random JWT to provision a secret resource.

Sorry to make the async in a single commit seems a hard operation. Let me rewrite this PR and reorganize into little commits

Hi @sameo @jialez0 , as this PR seems huge enough, I'd rather another PR to add a insecure feature to switch JWK verification and the user_public_key launch parameter. How do you like?


Test on Python 3.8

Codecov Report

Merging #233 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   98.68%   98.68%   +<.01%
==========================================
  Files         145      145
  Lines        3346     3356      +10
==========================================
+ Hits         3302     3312      +10
  Misses         44       44

Impacted Files
Coverage Δ

python/turbodbc/exceptions.py
100% <0%> (ø)
:arrow_up:

python/turbodbc/connection.py
100% <0%> (ø)
:arrow_up:

python/turbodbc/cursor.py
99.01% <0%> (+0.01%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ec4104...a837030. Read the comment docs.


Update skeleton.js

fix: #70 make Skeleton  not to be affected by wrapper's line-height so that vertical-align looks well :)
(no need to change your wrapper's line-height to be 1)

Sorry we did not get to this in a timely manner. Will be reviewing all the styles for v3. Feel free to contribute again the future!


Cannot Start Application - Application Validation Did Not Succeed

This had been working up to last week.   But then this week the webstarter download gets to 18.8 of 18.9MB and then errors. In the log it points to:
Activation of http://boxstarter.org/launch/Boxstarter.WebLaunch.Application?package=z:\Boxstarter\server.ps1&z:\Boxstarter\server.ps1 resulted in exception. Following failure messages were detected:
+ File, Boxstarter.Chocolatey.psd1, has a different computed hash than specified in manifest.
There is no AV or Firewall blocking the download.  I've attached the log file.
Any help would be greatly appreciated.
Thanks
7FBBM1H9.txt

Just fixed this and my apologies for this.


Center Node's Name When Hovering

When hovering over a node, the name doesn't display centered. This PR centers the node's name when hovering.

Isn't it cleaner if the name is offset from the center as it currently is? Even in your screenshot the name overlaps with the node's graphics.

Yeah, I think the current positioning is cleaner too, because it does not overlap with the position itself.
Also, you probably did not realized that the hovering system can stack up nodes names when there are several nodes under the cursor, displaying a list that is far more readable when left-aligned.

I agree that centering doesn't seem to make things more readable.
Any other input in favor of a change, or should we close this PR?


[webhook] hostNetwork

Hello,
Is it possible to add  a "hostNetwok: true" inside spec (line 35)
https://github.com/banzaicloud/bank-vaults/blob/master/charts/vault-secrets-webhook/templates/webhook-deployment.yaml
I need this feature for my EKS cluster as I need node ip address to go outside my cluster (architectural constrainght)
Thanks in advance,
Cyril

Hi @cpoule23, yes please open up a PR with a configurable value for with default hostNetwork: false. We are happy to pull that in.

Fixed by #1154


refactor: sync-docs

Fixes: #961
Changes:
Handle the problem of copying files without deleting the leftover files from the previous operation.
The time to synchronize documents is reduced to <10s
Screenshots of the change:

@juzhiyuan Hi, Please help me to check the synchronized documents for errors.  https://626e6e9027fc403e38356140--full-build-apache-apisix.netlify.app/

Don't care about the netlify CI failures


Add socket timeout configuration in gRPC client and server

Purpose
Resolves #11276

Codecov Report

:exclamation: No coverage uploaded for pull request base (release-0.990.0@f63c590). Click here to learn what that means.
The diff coverage is 70%.

@@                Coverage Diff                 @@
##             release-0.990.0   #12845   +/-   ##
==================================================
  Coverage                   ?   59.99%
  Complexity                 ?      659
==================================================
  Files                      ?     2068
  Lines                      ?   101681
  Branches                   ?    12936
==================================================
  Hits                       ?    61007
  Misses                     ?    35501
  Partials                   ?     5173

Impacted Files
Coverage Δ
Complexity Δ

...java/org/ballerinalang/net/grpc/GrpcConstants.java
100% <ø> (ø)
0 <0> (?)

...lang/net/grpc/nativeimpl/serviceendpoint/Init.java
74.04% <50%> (ø)
0 <0> (?)

...alang/net/grpc/nativeimpl/clientendpoint/Init.java
81.57% <62.5%> (ø)
0 <0> (?)

...va/org/ballerinalang/net/grpc/MessageDeframer.java
67.24% <77.77%> (ø)
0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f63c590...2735104. Read the comment docs.


[Feature]<EMAIL_ADDRESS>Video Player 1.10.6

@cloudinary-util/types was updated to 1.0.1 which simply includes a new prop to add picture-in-picture to the CldVideoPlayer
This requires an update to the Cloudinary Video Player script to 1.10.6

This assumes that the @cloudinary-util/types has already been pulled in to manage CldVideoPlayer types, if not that's a prerequisite
https://github.com/cloudinary-community/next-cloudinary/pull/421/files

Would be great to:

Pull in the new type to make it available to the component
Add an example for CldVideoPlayer that shows it in action

Related:

https://github.com/cloudinary-community/next-cloudinary/pull/456
https://next.cloudinary.dev/cldvideoplayer/examples#picture-in-picture

Will be released in #112


Exporting a dataset from shared dataset view has wrong filename

Go to the builder read-only view of a dataset that has been shared with you
Export the dataset
The downloaded file has the name of the dataset owner. The download link is:
https://<your_user>.carto.com/api/v2/sql?filename=<dataset_owner>.<dataset_name>&q=SELECT+*+FROM...

It should have the name of the dataset. It appears the SQL API drops everything after the dot in the filename parameter.

Still an issue. cc @ivanmalagon @ramiroaznar
It can be annoying for some big organizations which use dataset sharing a lot, since the downlaoded files all have the name of the owner of the dataset, which makes it very confusing.

Stale issue. Closing 👋


deprecate electron-prebuilt after it is published

I realized today that any time a new version of electron-prebuilt is published, users running npm install electron-prebuilt will no longer see a deprecation message, because that new version is not deprecated.
This updates the service to run npm deprecate immediately after publishing a new version.
cc @electron/maintainers

Looks good to me, it looks like this repo isn't configured to auto-deploy to Heroku so you'll have to deploy regular style.

✅  Deployed


Integration with IdentityManager and IdentityServer4 : question

Hi In past I have used this repo to build Identity Manger
https://github.com/IdentityManager/IdentityManager
Now we are moving to Identity server4. So just wondering to be in sync do we need to update anything with Identity manager as it used some reference of Identityserver3.core ? Or it doesn't matter? Or best bet to build our own new account admin/
Also I don't find recent updates or any new build for Identity Manger. Do you guys still support?

There's no port (from me) to ASP.NET Core of this project. There is a commercial version available: https://www.identityserver.com/products/


Revert "Complete Paper Overhaul (under reflow branch)"

Reverts NASA-MARTI/MagnePlane#152

what's going on here?

@jcchin I merged in your request before I read your message saying that you wanted to hold off on merging it. I then created a "revert' request, in case you wanted to roll back the changes.

I think I know what happened, I issued a PR, then later added these minor changes to the PR. The revert only reverted the addendum commits... this PR can be deleted


bibxml7: organizations as "authors" when authors are already listed

Describe the issue
bibxml7 entries list the organization as a separate "author" even when there are authors listed. For example:
      <author fullname="J. Jones" surname="Jones">
        <organization>Acme Corp.</organization>
      </author>
      <author fullname="J. Smith" surname="Smith"/>
      <author>
        <organization>NIST</organization>
      </author>

However, if a document has one or more authors, the organization should not be listed as a separate author in the reference entry. That is, the author info should look like this (organization information for the authors themselves is optional):
      <author fullname="J. Jones" surname="Jones">
        <organization>Acme Corp.</organization>
      </author>
      <author fullname="J. Smith" surname="Smith"/>

If the document does not list authors or editors, then organization information can be used:
      <author>
        <organization>NIST</organization>
      </author>

Some more info can be found in the Style Guide: https://www.rfc-editor.org/rfc/rfc7322#section-<IP_ADDRESS>
See the following for bibxml7 examples where both authors and organizations are listed:
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.6028/NIST.FIPS.180-4.xml
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.1145/2208917.2209336.xml
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.1145/99517.99553.xml
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.1145/242896.242897.xml
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.1109/PV.2013.6691439.xml
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.1109/INFCOMW.2014.6849240.xml
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.1007/3-540-60865-6_43.xml
Code of Conduct

[X] I agree to follow the IETF's Code of Conduct

@ajeanmahoney is this only about bibxml7 (DOI conversion), or across all bibliographic data sets?
One small issue: the citation of "NIST.FIPS.180-4" should really be using the proper NIST bibliographic item instead of the DOI:

https://bib.ietf.org/public/rfc/bibxml-nist/reference.NIST.FIPS.180-4.xml

It does have the same issue though.
<author fullname="Quynh H. Dang" surname="Dang">
  <organization>Information Technology Laboratory</organization>
</author>
<author>
  <organization abbrev="NIST">National Institute of Standards and Technology</organization>
  <address>
    <postal>
      <country>US</country>
      <city>Gaithersburg</city>
    </postal>
  </address>
</author>

Some more info can be found in the Style Guide: https://www.rfc-editor.org/rfc/rfc7322#section-<IP_ADDRESS>

I wonder if this is a presentation vs semantic issue -- technically, this functionality of selecting individual vs organizational authors according to the criteria can be implemented in xml2rfc instead of in bibxml-service.

is this only about bibxml7 (DOI conversion), or across all bibliographic data sets?

I found this issue in bibxml7; however, it could be an issue in other datasets.
I recently learned of one reference entry where the editor and the organization are listed on purpose (https://bib.ietf.org/public/rfc/bibxml/reference.RFC.4844.xml). I'll be checking with the RPC team about whether we would ever construct a reference like that in the future.

the citation of "NIST.FIPS.180-4" should really be using the proper NIST bibliographic item instead of the DOI

I see that the page for this document (https://bib.ietf.org/get-one/by-docid/?docid=NIST+FIPS+180-4&doctype=NIST&query=FIPS 180-4&query_format=docid_regex&page=1) lists both the bibxml-nist and bibxml7 entries. Should it only list the bibxml-nist entry? They also have slightly different information:
https://bib.ietf.org/public/rfc/bibxml-nist/reference.NIST.FIPS.180-4.xml
https://bib.ietf.org/public/rfc/bibxml7/reference.DOI.10.6028/NIST.FIPS.180-4.xml
For this particular reference, where does the author information come from? The author name cannot be found in the document itself. Is this metadata that NIST provides?

technically, this functionality of selecting individual vs organizational authors according to the criteria can be implemented in xml2rfc instead of in bibxml-service

I'm thinking about this suggestion.

For this particular reference, where does the author information come from? The author name cannot be found in the document itself. Is this metadata that NIST provides?

The bibxml-nist dataset provides authoritative metadata directly from NIST (source: https://github.com/usnistgov/NIST-Tech-Pubs).
References from bibxml7 contain DOI metadata obtained from CrossRef.
If there are issues with NIST metadata, please file them at https://github.com/usnistgov/NIST-Tech-Pubs which is run by the NIST Information Service Office.

I see that the page for this document (https://bib.ietf.org/get-one/by-docid/?docid=NIST+FIPS+180-4&doctype=NIST&query=FIPS 180-4&query_format=docid_regex&page=1) lists both the bibxml-nist and bibxml7 entries. Should it only list the bibxml-nist entry? They also have slightly different information:

This is something we should consider -- whether to go with "full disclosure" for the user, or go with "minimal necessary" to not confuse the author with unnecessary (too many) choices.


Deal with empty active version (object was never activated)

When the object has never been activated and there is no correct active version to be serialised, then we uploaded an empty file. This is fixed by this correction.

I think for the other object types, in case an object is deleted, zif_abapgit_object~exists should return false, and then the serialize method is never called?

The zif_abapgit_object~exists method returns true in the use case when the object exits but only in inactive state. This flag is_deleted is set by AFF framework internally and we just evaluate it in order to not serialize an empty active version.

@schneidermic0 any additional comments? if not, add the "Approved" via review feature


Voice bots on react-native

The chatbot tutorial here https://aws.github.io/aws-amplify/media/interactions_guide#create-your-chatbot doesn't have support for a voice bot, even though Amazon Lex does. I couldn't find this in the docs either, are voice bots explicitly not supported by Amplify?

Hi @siddhantg-cbre, currently only text bots are supported. Voice support is in the roadmap.


Natural Neighbor Interpolator fails at borders of problematic TIN

The Natural Neighbor interpolation can fail near the borders of a mesh with problematic positioning of vertices near the borders of the TIN.  For example,  the following test set was contributed by a user who was having problems with interpolation.  It gives rise to a mesh which has very thin triangles located along three edges of the mesh.  Those triangles lead to the computation of circumcircles with very large radius values.  In these cases, numerical issues lead to incorrect interpolations.
index, x,y,z
0,<PHONE_NUMBER>3333333,<PHONE_NUMBER>666667,  28.0
1,<PHONE_NUMBER>6666666,<PHONE_NUMBER>333333,  23.0
2,<PHONE_NUMBER>9999994,<PHONE_NUMBER>6666663, 18.0
3,<PHONE_NUMBER>333333,<PHONE_NUMBER>333333,   4.0
4,<PHONE_NUMBER>6666663,<PHONE_NUMBER>6666663,  0.0
5,<PHONE_NUMBER>6666666,<PHONE_NUMBER>666667,  12.0
6,  287.5,<PHONE_NUMBER>3333331,  5.0
7,<PHONE_NUMBER>333333,<PHONE_NUMBER>6666663,  9.0
8,  287.5,<PHONE_NUMBER>6666666,  0.0

The following images show the layout of the vertices and the resulting interpolation.  Vertices 2 and 5 are just inside the line segments that would be formed by Vertices 0,4 and Vertices 0,8.  The resulting triangles 2,4,0 and 5,8,0 have very small areas and are almost degenerate.  In the picture below, the triangles are so flattened that their three points appear to be lying on a single line.  Numerical issues result.

Here are the color-coded results from interpolation.  Numerical issues lead to erratic behavior.

A code change for the Natural Neighbor Interpolator class has been posted to the Tinfour code base. This change corrects the behavior of the interpolator.

In a related development, I noticed that the getArea() method for the SimpleTriangle class  (see Triangle Collector Techniques ) was computing a small-magnitude negative area for triangle 5,8,0.  This glitch violates the rule that all triangles produced by Tinfour are oriented counterclockwise and have a positive area.
This unfortunate result was due to numeric round-off issues arising from the nearly-degenerate geometry of the triangle. However, when I used the extended-precision logic from the GeometricOperations class, I confirmed that the triangle was, in fact, constructed correctly and did have a positive area.
I am looking at the best way to incorporate extended-precision logic into the SimpleTriangle class.  The extended-precision logic is slower than simple floating-point operations but does produce more accurate results.
This change will be integrated into the upcoming 2.1.5 release of Tinfour.  Once it is addressed, I will be closing this issue.

I have updated the area calculation for the SimpleTriangle class (now not quite so simple as it was).
Previously, triangle 5,8,0 was computed to have an area of -1.818989e-12.  While the formula in the code was correct, numerical issues resulted in the incorrect value.  The current version uses extended-precision arithmetic to find an area of 1.752672e-13

The code changes for this issue are now complete.
I would like to thank Michael Kemper for identifying this problem and providing such an excellent set of test data.  Those 9 vertices in his sample set exercise the Tinfour logic with admirable thoroughness.

The code changes for this issue are now complete.
I would like to thank Michael Kemper for identifying this problem and providing such an excellent set of test data.  Those 9 vertices in his sample set exercise the Tinfour logic with admirable thoroughness.

This issue in now fully addressed.  Fixes are included in the 2.1.5 release which was issued 10 Jan 2021.

This issue in now fully addressed.  Fixes are included in the 2.1.5 release which was issued 10 Jan 2021.