Driver Filter altitude why reuse the on of AppVMon.sys???

In https://github.com/winsiderss/systeminformer/blob/fc8f1e12ff0e2649b93c3cf05996d62bcd225fc3/SystemInformer/settings.c#L335C8-L335C8
i see that SI is using altitude 385400 which according to https://learn.microsoft.com/en-us/windows-hardware/drivers/ifs/allocated-altitudes is allocated to AppVMon.sys Microsoft.
Why not request your own?
May this be one of the reasons for problems?

Why not request your own?

Haven't gotten around to it. I'll put in a request soon. I honestly forgot to go back and make a request after the initial changes went in. Thanks for bringing this up to remind me 😄.

May this be one of the reasons for problems?

I wouldn't think so, there's plenty of filters out there that exist without formal registration. Obviously there is the possibility of a collision with the default today. It's configurable option so the user can easily rectify it if it does collide.
When we were choosing one, I did reference this list to choose one close to procmon, however it seems I just overlooked there is already one at that altitude.

The Microsoft File System Filter team has allocated the altitude 385210.5 for your : SystemInformer.sys minifilter.

Their website hasn't been updated yet. But we've been assigned the altitude and I've updated it here: https://github.com/winsiderss/systeminformer/commit/46fff2e2bcc95b03976e50c47cabe167e6f7725c


Added filtering by log level

When query, you can now specify also option.level which will filter the items.

Thank you for your contribution.


.Net: Prompty Code cleanup

Adding more tests to cover the new code in PromptTemplate.Prompty and Function.Prompty
### Tasks
- [x] Add more test for PromptTemplate.Prompty and FunctionPrompty
- [ ] As far as the spec is concerned, the name is strictly considered metadata - if we need to extract a useful function name, my sense is that the filename (sans extension) would be a better candidate.
- [ ] Test with IAIServiceSelector, see https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1578726198
- [ ] We support some additional properties, IsRequest, JsonSchema, AllowUnfaceContent https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579262436
- [ ] Add input fields in chat.prompty https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579154292
- [ ] Supporting additional models https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579170026
- [ ] Support model specific execution settings https://github.com/microsoft/semantic-kernel/pull/5961#discussion_r1579164960
- [ ] Add logging to LiquidPromptTemplate https://github.com/microsoft/semantic-kernel/pull/6048#discussion_r1589796510

Closing as stale


Test PR Update README.md

Progress / Closed on issue #
What it Does

Adds really bad code. It should not be approved

How I Tested

I did not

Notes

Anything else that should be noted about how you implemented this feature?
🤷

Screenshot

Add a screenshot of your new feature! OR show a screen recording of it in action

How could you not test it?


fc_reflect visit() requires visitor's operator() to be const

This is an FC deficiency.  When visiting members of a class, sometimes we want to build up state on all the members as we process it.  It is ideal to store this state in the visitor object, however because of const e.g. here the visitor is not allowed to modify its own fields in operator().
Why does the reflection force visitors to be const?

It enforces it to avoid ambiguity in calls. Mark the members variables on the visitor as "mutable" and C++ will allow them to be modified by a const method.

I don't like it but I guess I can live with it.


menu entry swapper: Swaps wield/release option for salamanders.

The option is disabled by default.
Not sure if there is already another way to do this, but i couldn't find one. Makes hunting salamanders a bit more chill.

you can sticky keys shift

you can sticky keys shift

Couldn't you then customize shift click to bury bones (for example) and then sticky key shift. I don't think many people know you can do that, it's quite unintuitive.
Another solution would be to have a "customize left click" that works like customize shift click. But idk if that would be possible/allowed by jagex.

For this we have shift-click configuration. Most of remaining options in menu-entry swapper that swap inventory are mostly from before we had shift-click.

8944eb9be6d62ec8384e29484dab14c4c2858d9d was added to master, which sufficiently covers this use case.


Go / macOS CoreFoundation link error when building gnark-ffi

I am unable to build the crate sp1-recursion-gnark-ffi in recursion/gnark-ffi on macOS because of (what appears to me to be) an issue with the object files built by Go / CGo.
System information:

macOS 14.5
SDK (xcrun --show-sdk-path): /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk
Rust installed via Rustup (cargo 1.79.0-nightly (48eca1b16 2024-04-12))
Go installed via Homebrew (go version go1.22.3 darwin/arm64)

Steps to reproduce:
$ git clone git@github.com:succinctlabs/sp1.git
$ cd sp1/recursion/gnark-ffi
$ cargo test --release
... omitted ...
            _SecTrustGetCertificateAtIndex, referenced from:
                _runtime.text in libsp1gnark.a[2](go.o)
            _SecTrustGetCertificateCount, referenced from:
                _runtime.text in libsp1gnark.a[2](go.o)
            _SecTrustSetVerifyDate, referenced from:
                _runtime.text in libsp1gnark.a[2](go.o)
          clang: error: linker command failed with exit code 1 (use -v to see invocation)

error: could not compile `sp1-recursion-gnark-ffi` (lib test) due to 1 previous error

Hey @Baltoli, this PR: https://github.com/succinctlabs/sp1/pull/842 should fix that in the next official release!
We're also working on using Docker for PLONK proving so developers won't need to have Go installed on their machine to do the PLONK proving.
You should be able to build the crate and use the sp1-sdk with no issues, as the PLONK proving is gated behind the plonk feature flag.


Integration stopped working after update to v0.0.5

After update, the all Dolphin entities are unavailable
Logger: homeassistant.components.sensor
Source: custom_components/dolphin/sensor.py:27
Integration: Sensor (documentation, issues)
First occurred: 12:21:49 PM (1 occurrences)
Last logged: 12:21:49 PM

Error while setting up dolphin platform for sensor
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/entity_platform.py", line 281, in _async_setup_platform
    await asyncio.shield(task)
  File "/config/custom_components/dolphin/sensor.py", line 27, in async_setup_entry
    for device in coordinator.data.keys():
AttributeError: 'NoneType' object has no attribute 'keys'

same here.. same error...
i really hope the author will fix it soon.. its critical !

deleting the integration and reinstalling it seems to fix the issue
thanks !

@synlink thxThanks
I think it's worth mentioning it in the change log @0xAlon


No auto highlight and no summary

Hello.
I reinstalled windows. So I reinstalled ST3 and your awesome plugin. But it doesn't auto highlight and doesn't show summary like it used to =( I didn't change any settings

@KlayaR , To support multiple log types, the settings are chagned. Please, change your settings like this : https://github.com/poucotm/Log-Highlight/blob/master/Log Highlight.sublime-settings
And summary panel has been deprecated.

It didn't change anything with those configs

Are you sure that your user settings look like this ?
	"log_list" : {
		"example" : // specify name as yours
		{
			"type"         : "compile", // "compile" - link, bookmark (icon) are usable, "system" - only for highlight
			"extension"    : [ "*.log", ".vcs.log", ".cp

I copied/pasted the exact settings that you sent

Did you see any error messages on sublime console (ctrl + `) ?

unable to auto detect encoding for C:\Users\Klayar\Desktop\2020-04-16-3.log, using fallback encoding Western (Windows 1252)

So it's ST3 who doesn't see a .log file as a log file?

It doesn't look like the cause.


Configuration Based Subpanel Location

For the development environment, it would be nice to have a configuration based subpanel location instead of using the default directory.

So after thinking about this for about a month, I think that the best way to go is a total redesign for finding subpanels.
This is what I envision:

And to get their references:

Re: To get their references:
Unless I know the process name (which could be a clone name) then the SMO name is not the name I am looking for. This way of doing it is actually what I am looking for, although with both things being SMOs I am heavily abusing the idea of protected scope I am sure (it should only work inside of the subpanel class, but since they are both SMOs, it can work in the Maui class but use the child wire)

Another note, I can even have the user input a name for the section in the configuration file with the built in stuff for the Open G VIs:

Unintentionally, these ended up being wrapped around one another which is good (I think):

Implemented in Maui 2.0


Add startRecording and stopRecording function

@Subhi-Khalife Hi, can you check this?

Hello @sampaiopedrodev
it's greate changes
i will merge it and then i will make test for it then i will upload new version to pubDev
Thanks bro


Added Union of Arrays code in java

@tanishksaraswat contribute here https://github.com/Ishaan28malik/Get-Dev-Resources


Adds test for enableAvailabilityZones not re-inherited

Prior to @drigodwin's fix in https://github.com/apache/brooklyn-server/pull/919, this test would have failed. The child clusters are each passed a sub-location (i.e. a SimulatedLocation). However, because they also re-inherited the ENABLE_AVAILABILITY_ZONES=true, it tried to get the availability zone extension for the location it was given. This failed because SimulatedLocation does not have that extension.
With the fix in #919, the config key is not re-inherited, so the child DynamicClusters do nottry to lookup the availability zone extension, and instead just create their children in the given location.

Thanks for the detailed description @aledsage.
LGTM, merging


JBPM-4664:advanced and baisc mode for process instance include: new d…

…etails tab page and create module jbpm-console-ng-generic-preferences

@Salaboy hi i updated this PR, as we discuss content.(include: refacing Dataset Process instance list)
Update to bootstrap3.
The PR dependency on PR droolsjbpm/droolsjbpm-build-bootstrap#64
Please review it.

Can one of the admins verify this PR? Comment with 'ok to test' to start the build.

@porcelli @Salaboy @cristianonicolai @nmirasch
I think the PR to large, So separate it to two PR.
1 https://github.com/droolsjbpm/jbpm-console-ng/pull/210
add jbpm-console-ng-generic-preferences for multiple view mode and enable multiple view mode for process definition
2 I will raise it.
advanced and basic mode for process instance

@bxf12315 Is this PR to be closed, replaced by #210 and another (to follow)?

@manstis yes, this PR will be closed.


Add Systemverilog Queue support #1496

Add Systemverilog Queue support #1496

Merged for the next release, thanks!


Added description of results folder and results.xml

Based on feedback from Intune customers, added description of results folder and results.xml, and powershell examples of working with the results.

cc @JohanFreelancer9

cc @JohanFreelancer9

Hi all. Sorry I am unfamiliar with the process. What do I do next? Do I take some action to incorporate the suggested changes and submit a new PR--- or maybe the suggested changes are automatically applied?

Hi all. Sorry I am unfamiliar with the process. What do I do next? Do I take some action to incorporate the suggested changes and submit a new PR--- or maybe the suggested changes are automatically applied?

@MatthewMWR : That seems to be quite correct to me. In the future, whenever you are in doubt, feel free to ask a question in the next comment box below the suggestion, in case you would like to amend or adjust the suggested change. Moreover, the suggestions from @JohanFreelancer9 are usually quite correct, unless you find some kind of deviation from what you find to be the most accurate description in the related paragraph or sentence. So far, so good. Thank you.

@MatthewMWR : That seems to be quite correct to me. In the future, whenever you are in doubt, feel free to ask a question in the next comment box below the suggestion, in case you would like to amend or adjust the suggested change. Moreover, the suggestions from @JohanFreelancer9 are usually quite correct, unless you find some kind of deviation from what you find to be the most accurate description in the related paragraph or sentence. So far, so good. Thank you.

#sign-off

#sign-off

Is this ready to go live on docs.microsoft.com? Do I need to do anything?

Is this ready to go live on docs.microsoft.com? Do I need to do anything?

No changes requested, this is confirmed "good to go" from our side (JohanFreelancer9 and me, us reviewers). We are simply waiting for the final review & merge from the document author (@ManikaDhiman), or the team manager Daniel Simpson, or anyone on the MS Docs team with merging rights & deciding rights to review & merge.

No changes requested, this is confirmed "good to go" from our side (JohanFreelancer9 and me, us reviewers). We are simply waiting for the final review & merge from the document author (@ManikaDhiman), or the team manager Daniel Simpson, or anyone on the MS Docs team with merging rights & deciding rights to review & merge.

@e0i (for your information, in case I have overstepped my user boundaries)

@e0i (for your information, in case I have overstepped my user boundaries)

I will need to review with the product team. More soon.

I will need to review with the product team. More soon.

Thanks Dan. I was/am the feature PM for DiagnosticArchive. This current editing effort is focused on filling a gap in the original docs.

Thanks Dan. I was/am the feature PM for DiagnosticArchive. This current editing effort is focused on filling a gap in the original docs.

Great! Thanks for your contributions here, Matthew. Merging...

Great! Thanks for your contributions here, Matthew. Merging...


fix: forgotten async deleted

Hi,
it seems that there was forgotten async in close_non_blocking function.

Hello and thanks for opening this PR. Before I can even review it, I must ask you to sign our CLA (Contributor License Agreement).
This is also the reason for the red build-pipeline.

Done.


Run go vet and tests in all subpackages in CI

go vet and go test without any package arguments runs only
on the go files in the repo root directory. It should run on all
non-vendored packages.
Fixes following go vet failure:

./scylla_test.go:180:4: call to (*T).Fatal from a non-test goroutine

nit: the first commit name misses : after UPSTREAM

nit: the first commit name misses : after UPSTREAM

good catch, thanks. Fixed


Only run selenium tests when build java is specified

Addresses https://github.com/aspnet/AspNetCore/issues/10504

More Ubuntu inotify failures in Helix runs ☹

Yea there are a few tracking issues on the inotify issue already. cc @javiercn are you looking into those?

Yes, I have a PR out, although looking at my changes I don’t know how they caused it.

I'm doing the egregious sin of commenting on a closed PR. But with this change, I can't do dotnet test on the Component's E2E tests anymore since BuildJava isn't defined by default. Should the test here be:
``$(BuildJava) != "false" so it's only skipped when we explicitly say we do not require Java? Right now, there's a risk that the tests never run if the flag isn't set. What do you folks think?

dotnet test /p:BuildJava=true


Forecast models

Fields for: 1) Original budget and 2) Remaining budget are required fields and should include valid values for Project Forecast Models.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: aba05e0c-0cb4-b9c1-ddca-f0b2c1ae44c5
Version Independent ID: 0a0487ab-70d9-2705-7468-56d6d29804a5
Content: Submit and approve project budget - Finance & Operations | Dynamics 365 | #MSDyn365FO
Content Source: articles/supply-chain/procurement/tasks/submit-approve-project-budget.md
Service: dynamics-ax-applications
GitHub Login: @mkirknel
Microsoft Alias: mkirknel

Thank you for your comment. @MaiKirknel, can you please review this feedback and update the topic if needed?

Bug 347812 created to track.

Bug 437964 created.

Closing as I have worked through this procedure and the fields mentioned are automatically filled with the information. If this is not what is being referred to, please reopen and provide more information. For example, which FastTab has the fields you are referring to as the Original budget field is shown on multiple FastTabs on the same page.


yepnopejs.com seems to have been hacked

Just an FYI that http://yepnopejs.com/ seems to have been hacked and is instantly redirecting when I visit it

More than 10 days?

It’s not hacked, we let go of the domain when we deprecated the library 8
years or something ago.
On Mon, Jul 27, 2020 at 5:03 PM rudwolf<EMAIL_ADDRESS>wrote:

More than 10 days?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/SlexAxton/yepnope.js/issues/239#issuecomment-664661153,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAXSKQOBJJSLRIAWYULZKDR5X2SLANCNFSM4HXGNGZA
.

--
Alex Sexton

Any other solution to use to fallback to local files if CDN fails?
I've seen some on the web, but nothing so easy as yepnope...
Can someone please give me an alternative?


Fix links in README

This pull request makes various corrections to the links in the README.

There is an annoying situation where fork prs do not get repo secrets for security concerns. Thats why this pr failed CI

There is an annoying situation where fork prs do not get repo secrets for security concerns. Thats why this pr failed CI

thx @dnicolson <3


Run Docker build if config changed

The Docker build workflow defined in .github/workflows/docker.yml should not be built on pushes to branches or for general PRs. However, it should run if changes are made to that file.
This would avoid temporary hacks such as https://github.com/mesh-adaptation/mesh-adaptation-docs/pull/30/commits/d0d888228bf3ef286fb2c8427909a7afe62b9ccb.

Would you mind taking a look at this @ddundo?

Will do! Sorry for neglecting this :)

Thanks. No rush.


disable this please

can't work if qolmod enabled
i want to use this mod with qolmod

I cant go ask QOLmod dev or use somth else


pip install fails

Hello all,
I tried to install the python-pkcs11 package into my Anaconda 3 environment, but was not able to finalize this task.  I did make some progress with all the errors, I was facing, but got stuck at a certain point.
I am using Anaconda 3 as 64 bit version on a Windows 7 that is installed on a HP laptop with an i5 CPU.
Due to the fact that the compilation failed, I installed first the recommended Visual Studio Builder Tools, but this did not help, so that I at the end installed the full visual studio 2019 environment.
But even with this the installation fails with the error:

pkcs11_loader.c(596): fatal error C1083: Datei (Include) kann nicht ge"ffnet werden: "dlfcn.h": No such file or directory

Attached you will find what the console-output told me during the installation in verbose mode.
pip-installation-output.txt
Could you please tell me, how I can solve the issue, so that the package will be installed?
Kind regards,
Manfred

Hi @mbenten, try installing master, this should include the Windows fixes you need. Let me know.

Hi @danni,
thank you for the fast answer, but I don't know exactly what you mean with installing master?
Is this an anaconda or a python or a visual studio or a windows installation.
I tried o use conda install master and pip install master, but both mechanisms did not find packages.
I tried to search with google for some combinations of "windows 7 install mastar pyton anacona", but the results were also not helping.
Could you please navigate me to propper place from where I can get the package/installer?
Thank you,
Manfred

I mean install the master branch of this package. Check out this Stack Overflow:
https://stackoverflow.com/questions/20101834/pip-install-from-git-repo-branch
On 31 May 2019 at 17:18:53, mbenten (notifications@github.com(mailto:notifications@github.com)) wrote:

Hi @danni(https://github.com/danni),
thank you for the fast answer, but I don't know exactly what you mean with installing master?
Is this an anaconda or a python or a visual studio or a windows installation.
I tried o use conda install master and pip install master, but both mechanisms did not find packages.
I tried to search with google for some combinations of "windows 7 install mastar pyton anacona", but the results were also not helping.
Could you please navigate me to propper place from where I can get the package/installer?
Thank you,
Manfred
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub(https://github.com/danni/python-pkcs11/issues/55?email_source=notifications&email_token=AAA7TQBNBG4GAUVPGUZXXYDPYDGN3A5CNFSM4HROLIUKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWUNLLI#issuecomment-497604013), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAA7TQAAAJKDHX7WJDS2URLPYDGN3ANCNFSM4HROLIUA).

Hi @danni,
thank you for this answer and the link.  That helped indeed.
I was able to installed the package on both python 2.7.12 and python 3.7.3 in my anaconda environment by using the following command:
pip install git+https://github.com/danni/python-pkcs11
Can you already assess, why it did not run by just using the command:
pip install python-pkcs11
Will this question drive some fixes to the code?
Thanks again for the support.
I think that the question itself can be closed since I was able to install...
Kind regards from Hamburg in Germany,
Manfred

Hi @mbenten,
It definitely will not function in Python 2.7. If it builds at all, it will crash upon execution. This code has not been written to function in Python 2.7.
The version you installed originally did not work because of Windows compatibility errors, these are only fixed in master and not the release version.

I just came across this issue today, why is this issue closed if pip install python-pkcs11 is still broken on Windows?


Windows Server 2019 supported?

According to the supported client, it seems that Windows Server 2019 has been supported. Is my understanding correct?
If so, it would be better to omit the supplement below.
(Including Windows Server 2012 and 2016)
https://docs.microsoft.com/en-us/azure/automation/automation-update-management#supported-client-types

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: db47901d-1664-058d-9407-47e932dc9661
Version Independent ID: e90ec9ee-e7da-4f19-248f-4c825aaa8b9f
Content: Update Management solution in Azure
Content Source: articles/automation/automation-update-management.md
Service: automation
Sub-service: update-management
GitHub Login: @bobbytreed
Microsoft Alias: robreed

@akiyoshi Thanks for the comment. We will investigate on the issue and get back to you shortly.

Assigning to @bobbytreed for visibility and document enhancement considerations.

Update the doc, #please-close


Error on registration

Registration is successful but I still get the following in the console:

RegistrationPage.js:36 Uncaught TypeError: Cannot read property 'then' of undefined

I will take a look at it next week

I was getting this same error.  To fix it, go to authActions.js and update line 58.
From:

To:
return firebaseApi.createUserWithEmailAndPassword(user).then(user => {

It was just missing the return.

thanks @drewrawitz could you create a Pull Request for it? :)

@douglascorrea Sure thing. Do I have access to do that? I'm trying to push up my branch but I'm getting some permission errors.

@drewrawitz you need to fork this repo, then clone the forked repo in your machine, then change and push to your fork repo, then open a PR from your fork to this repo:
https://gist.github.com/Chaser324/ce0505fbed06b947d962
:)

Thanks @douglascorrea! This is my first pull request 😄 I went ahead and submitted it.

Perfect! Thanks @drewrawitz  :) 👍 👍 👍


Remove commas at the end of "containerPort"

"containerPort": 8000, should be "containerPort": 8000

@jaredbhatti Thanks for chipping in!


rubocops/text: improve test descriptions

[x] Have you followed the guidelines in our Contributing document?
[x] Have you checked to ensure there aren't other open Pull Requests for the same change?
[x] Have you added an explanation of what your changes do and why you'd like us to include them?
[ ] Have you written new tests for your changes? Here's an example.

[ ] Have you successfully run brew typecheck with your changes locally?
[x] Have you successfully run brew tests with your changes locally?
[ ] Have you successfully run brew man locally and committed any changes?

Continuation of https://github.com/Homebrew/brew/pull/10124
This PR improves the test descriptions of text_spec.rb so that the error messages are more coherent.
Before:
RuboCop::Cop::FormulaAudit::Text When auditing formula text with `require "formula"` is present
After:
RuboCop::Cop::FormulaAudit::Text when auditing formula text reports an offense if `require "formula"` is present
(I'm not sure if my extensive use of single quotes ['] and percent literals [%Q(...)] is recommended; please tell me if it isn't)

Review period will end on 2021-01-18 at 02:18:16 UTC.

Review period will end on 2021-01-18 at 02:18:16 UTC.

Review period ended.

Review period ended.


TIME_FORMAT could rather be what we store the time as

Value of TIME_FORMAT didn't really make sense in any other context
Relevant: https://github.com/LeanderGangso/goc/pull/4
I would rather want to use TIME_FORMAT here instead of hardcode time.RFC3339

change is implemented


Major-release candidate

Changes

[x] Remove scoped threads.
[x] Remove chase_lev as it is too complex to be in the crossbeam core crate (I plan making a side crate with this).
[x] Get rid of Owned<T> in favor of Box<T>.
[x] Give every single item detailed documentation.
[x] Write nontrivial code in semi-literate style.
[x] Refactor all the code to go from decent code to well above average code.
[x] Fix several bugs.
[x] Allow creation of Shared<T> from Guard.
[x] Add owned guards through Pinned.
[x] Remove the mem module, moving its items to the crate root.
[x] Remove ArcCell (eventually moved to the secondary crate).
[x] Quad-double the GC threshold to improve performance.
[x] Audit all the code.
[x] Rename CAS and CAS prefixed methods to compare-and-set.
[x] Get rid of cas().
[x] Add real compare-and-swap.
[x] Remove AtomicOption, which basically mirrored epoch::Atomic.
[x] Remove all the deprecated methods.
[x] Follow the naming conventions of libstd, renaming try_pop to pop.
[x] Rename pop/push on queues to queue/dequeue to mark that queues are queues, not stacks.
[x] Remove 3 use-after-frees in Atomic<T>.
[x] Remove several memory leaks all around the code.
[x] Remove the Scala benchmark, which seem to have no relavancy other than comparison.
[x] Import modules over direct items.
[x] Add Default to most of the types.
[x] Add map to Shared<T>, allowing internal referencing with owning_ref.
[x] Use lazy_static rather than manual implementation of it.
[ ] Get rid of CachePadded

(was that all?)
Right now, I'm going to get some sleep. I don't have much time tomorrow, so I request someone to help me with this: The tests are broken, from what I suspect to be a simple bug in CachePadded, but I'm too tired to figure it out.

Great work on all this.

Nice! Thanks @ticki!
One note though: I don't think we should jump directly to 1.0. We can put out a new major release, but I feel like the library needs much more time to bake and grow before we give it 1.0 status. In particular, several people have talked about pulling out some of what's currently in the library into separate crates. And there are still segfaults and other problems in the issue tracker.

@aturon How else will we justify the breakage?

@ticki I'm not sure I understand? The current published version is 0.2. If we make this 0.3, that's considered a new major semver release (as per the rules about pre-1.0 versions), so it won't break anyone.

(as per the rules about pre-1.0 versions)

Ah, didn't know that convention were common in the Rust community.

On another note, I also don't think we should rush to publish a new version to crates.io. It'd be good for people to get some experience with the new APIs, and to put some time into tracking down some of the pending issues. But I'll let others weigh in too.

What about releasing 0.3.0-rc to crates.io?

I got to bed now, and won't be active before tomorrow afternoon. I encourage people to review changes and give feedback while.

"Remove scoped threads" why is this? I thought this was a major feature of this crate

@djzin: AFAIK the idea is to split them into a separate crate in rust-lang-nursery, since they are a feature used quite often and make crossbeam focus on data structures and lock-free algorithms.

I have two general comments to make about the Atomic type:

Consider basing the CAS function on the newer compare_exchange API instead of the deprecated compare_and_swap one. The newer API allows you to specify a memory ordering on CAS failure and allows for weak CAS (compare_exchange_weak) which can be more efficient on certain architectures.
Could we maybe rename Atomic to something more descriptive like AtomicSharedPtr? The name Atomic somewhat conflicts with my atomic crate which provides a generic Atomic type.

Given the size and complexity of this whole thing, I've come to think that it might be better if @ticki could split this into several smaller PRs. It's barely been reviewed and we're already crawling through an 80-comment thread. A potential organisation:

Changes to EBR. Especially this need explanation, did you just refactor it and add documentation or did you make changes to algorithms? This PR should not include moving the module and merging/splitting files, since the lack of diffs makes this especially difficult to review.
Move epoch module, after above
Add compare-and-swap, rename cas
Add ability to create Shared from Guard, add Pinned
Remove Owned and AtomicOption
Remove ArcCell, Chase-Lev Deque and Scala benchmark
Other fixes and addition I missed

What do people think?

@Vtec234 I like that. It's definitely a mistake of mine to make such a big PR with a lot of unrelated changes.

btw, I've enabled such that all with write access can add comments

If checked, users with write access to crossbeam-rs/crossbeam can add new commits to your master branch. You can always change this setting later.

Please feel free to use.

Are the test running with the thread sanitizer already on CI by default already?

I strongly agree with @Vtec234 's suggestion to split this PR (https://github.com/crossbeam-rs/crossbeam/pull/122#issuecomment-285875721).  I would like someone to close this PR, and make a tracking issue for each change item mentioned above.
Having said about "someone", I feel this project currently lacks a proper decision making procedure, even for closing issues and merging PRs :\  For now I would like to ask if @ticki could provide leadership for this PR (which happens to be currently the most important one).  If you are in short of time, please kindly tell me what you want me to do :)  Of course, for a longer term, we eventually need to establish some institution.

@jeehoonkang

If you are in short of time, please kindly tell me what you want me to do :) Of course, for a longer term, we eventually need to establish some institution.

I really want some help with one thing in particular: The bug in CachePadded<T>, which causes most tests to fail.  I'd like someone to help me figure out why it is that assert_valid panics. The CachePadded is pretty hacky, so maybe it's just some change in memory layout.
Either way it's hard for me to do alone.

@jeehoonkang

Having said about "someone", I feel this project currently lacks a proper decision making procedure, even for closing issues and merging PRs

See https://github.com/crossbeam-rs/crossbeam/issues/124 for the time being. We'll have to play it a bit by ear for a while, I think, and gradually formalize a procedure.

I spend a few hours on this with no success, most commits left the build broken and then a latter commit fixes it. So git bisect was useless. I tried getting each commit compiling but after a few hours I gave up, but that's probably the only way to find it without eyeballing.

Use lazy_static rather than manual implementation of it.

Why? lazy_static blocks in its implementation. Using a locking algorithm to implement lock-free data structures seems counter-intuitive, even if it is unlikely to cause an issue. The manual implementation was optimistic and lock-free, which matches the ideology of the crate a lot better I think.

Get rid of Owned<T> in favour of Box<T>

Not sure I agree with this. Owned<T> is currently implemented as a Box<T> but that's an implementation detail that I find worrying. Realistically, Owned<T> is akin to Box<ManualDrop<T>>. I'd much rather the code work with this rather than just assume that Vec<T> with len 0 and cap 1 is the same as just freeing the memory of Box<T>. It feels hacky and confusing in a codebase that is already difficult to follow (not anybody's fault, concurrency is hard).

Add owned guards through Pinned.

I feel like this is a mistake. It's not unsafe or anything, I just think people will use it incorrectly.

Add map to Shared<T>, allowing internal referencing with owning_ref.

Not sure about this either. guard::unlinked will be just plain wrong with a mapped Shared<T>. Seems like a potential footgun. &T can be mapped just fine and Shared<T> will deref into that anyway.

@arthurprs

I spend a few hours on this with no success, most commits left the build broken and then a latter commit fixes it. So git bisect was useless. I tried getting each commit compiling but after a few hours I gave up, but that's probably the only way to find it without eyeballing or some magical debug powers.

It's my horrible habit: Just write and then fix when you're done.
@whataloadofwhat

Why? lazy_static blocks in its implementation. Using a locking algorithm to implement lock-free data structures seems counter-intuitive, even if it is unlikely to cause an issue. The manual implementation was optimistic and lock-free, which matches the ideology of the crate a lot better I think.

The previous implementation blocked as well. AFAICS there is no non-blocking way of doing this, and the blocking part is only during initialization and even then is rare.

Not sure I agree with this. Owned is currently implemented as a Box but that's an implementation detail that I find worrying. Realistically, Owned is akin to Box<ManualDrop>. I'd much rather the code work with this rather than just assume that Vec with len 0 and cap 1 is the same as just freeing the memory of Box. It feels hacky and confusing in a codebase that is already difficult to follow (not anybody's fault, concurrency is hard).

That is, well, very weird thing. Like, of course it calls the inner destructor, and even the free is more sensical than the vector hack. If you want a changed destructor, you can just wrap your T in a newtype.

I feel like this is a mistake. It's not unsafe or anything, I just think people will use it incorrectly.

I see literally no way of 'misusing' this?

Not sure about this either. guard::unlinked will be just plain wrong with a mapped Shared. Seems like a potential footgun. &T can be mapped just fine and Shared will deref into that anyway.

This one is interesting. I don't think it is an issue in reality, as unlinked is already unsafe.

The previous implementation blocked as well. AFAICS there is no non-blocking way of doing this, and the blocking part is only during initialization and even then is rare.

Maybe blocking was the wrong word? I'm sorry. The manual implementation is lock-free. lazy_static is not.

I see literally no way of 'misusing' this?

Pinned<T> is lifetime free which makes it very tempting to just pass around and store, but doing so is going to inhibit garbage collection. Like I say, it's not unsafe, it's just ... encouraging bad patterns, I think. You shouldn't really be storing a Guard for a long period of time and Pinned<T> kind of encourages you to do so.

This one is interesting. I don't think it is an issue in reality, as unlinked is already unsafe.

This is true, but it's expanding the scope in which it can be used incorrectly. I don't think it should be done idly, but I don't see much of a benefit to it either. The old invariant is "only used on Shared<T> where no new readers are going to be created". You've now created a new invariant, "ensure the Shared<T> has not been mapped".

That is, well, very weird thing. Like, of course it calls the inner destructor, and even the free is more sensical than the vector hack. If you want a changed destructor, you can just wrap your T in a newtype.

I think I may have caused some confusion here so I'll drop this point. Sorry.

Pinned is lifetime free which makes it very tempting to just pass around and store, but doing so is going to inhibit garbage collection. Like I say, it's not unsafe, it's just ... encouraging bad patterns, I think. You shouldn't really be storing a Guard for a long period of time and Pinned kind of encourages you to do so.

That's a good point. It can be tempting to store, say, in a struct.

I am closing this, as (1) we decided to split this PR into smaller ones, and (2) there is not so much traffic on this PR these days.
As a follow-up, I will make the smaller PRs of the changes made in this PR.  As noted above, the commits are quite mixed so that it will be hard to maintain the commits as-is.  I will make new commits based on the diffs.

@jeehoonkang thanks for picking this up. I'll do my best to review in a timely manner.


Replacing   to \n by SaxLtx parser

I have left the comment here https://github.com/node-xmpp/ltx/commit/bb8980eed61a479397084883c483a4a613615679

@lloydwatkin any idea?

https://github.com/node-xmpp/ltx/pull/79

fixed in https://github.com/node-xmpp/ltx/pull/79

@sonnyp I still have a problem in lib/parsers/ltx.js. Please check https://github.com/node-xmpp/ltx/blob/master/lib/parsers/ltx.js#L171

https://github.com/node-xmpp/ltx/pull/84

fixed, released as version 2.2.1

Thank you!


[GdkPixbuf] bind types needed for implementing a pixbuf loader

In https://gitlab.gnome.org/GNOME/librsvg/-/merge_requests/457 I am experimenting with porting rsvg's gdkpixbufloader to rust.
As can be seen in that patch, I had to manually bind various types (GdkPixbufModulePattern, GdkPixbufFormat, GdkPixbuf.Module, etc).
The first question is: does these bindings belong in gdk_pixbuf_sys? In other words, is implementing a pixbuf loader in scope for this crate or we want to only expose api for applications using the gdkpixbuf API?
If the answer is yes, I am available to try to provide a patch, but I will need some guidance :)
Should I just add those types to manual.rs or do we expect gir generation to be able to deal with those and the fixes need to be in the annotations?

The first question is: does these bindings belong in gdk_pixbuf_sys?

Yes but the bigger question would be why that API is not in the .gir file. If it was then it would already be in gdk-pixbuf-sys.
Best to check that first with the gdk-pixbuf maintainers. If that's all intentional and correct then you'd have to add manual -sys bindings for this.

The first question is: does these bindings belong in gdk_pixbuf_sys?

Yes but the bigger question would be why that API is not in the .gir file. If it was then it would already be in gdk-pixbuf-sys.
Best to check that first with the gdk-pixbuf maintainers. If that's all intentional and correct then you'd have to add manual -sys bindings for this.

well, the "api" is a bunch of C structs with public fields, some of which are strings and function pointers... no idea if gir can support any of that :)

well, the "api" is a bunch of C structs with public fields, some of which are strings and function pointers... no idea if gir can support any of that :)

Works for other libraries :)

Works for other libraries :)

https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/167

https://gitlab.gnome.org/GNOME/gdk-pixbuf/-/issues/167

https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/blob/fc2d7fc4d06152517d77ad6049ea4ec943ceb268/gstreamer/sys/src/lib.rs#L2319-2334 is an example for such a struct in GStreamer that is used for exactly the same purpose.
In https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/blob/fc2d7fc4d06152517d77ad6049ea4ec943ceb268/gstreamer/src/subclass/plugin_1_12.rs it's wrapped in safe API for defining a GStreamer plugin.

https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/blob/fc2d7fc4d06152517d77ad6049ea4ec943ceb268/gstreamer/sys/src/lib.rs#L2319-2334 is an example for such a struct in GStreamer that is used for exactly the same purpose.
In https://gitlab.freedesktop.org/gstreamer/gstreamer-rs/-/blob/fc2d7fc4d06152517d77ad6049ea4ec943ceb268/gstreamer/src/subclass/plugin_1_12.rs it's wrapped in safe API for defining a GStreamer plugin.

The .gir changes have been merged upstream. How does it work? Shall we wait for a release or I can generate from gir locally and then open a MR?

The .gir changes have been merged upstream. How does it work? Shall we wait for a release or I can generate from gir locally and then open a MR?

Create a PR here and once that is merged update the submodule here.

Create a PR here and once that is merged update the submodule here.

done... not sure why formatting is so different

done... not sure why formatting is so different

Ok, I think I fixed things... I see regen check still failing, but I guess that is normal?
This required two extra changes

in the gir files I had to add a fix in fix.sh to replace usage of GModule with a plain gpointer
in the test files I had to #define GDK_PIXBUF_ENABLE_BACKEND so that the test could check the size of the structs

Ok, I think I fixed things... I see regen check still failing, but I guess that is normal?
This required two extra changes

in the gir files I had to add a fix in fix.sh to replace usage of GModule with a plain gpointer
in the test files I had to #define GDK_PIXBUF_ENABLE_BACKEND so that the test could check the size of the structs

I see regen check still failing, but I guess that is normal?

Yes until the gir-files PR is merged this is normal.

This required two extra changes
1. in the gir files I had to add a fix in `fix.sh` to replace usage of `GModule` with a plain `gpointer`

This seems fine until we add gmodule bindings :)

in the test files I had to #define GDK_PIXBUF_ENABLE_BACKEND so that the test could check the size of the structs

That's a bit annoying as that change will be overridden again when running generator.py or not?

I see regen check still failing, but I guess that is normal?

Yes until the gir-files PR is merged this is normal.

This required two extra changes
1. in the gir files I had to add a fix in `fix.sh` to replace usage of `GModule` with a plain `gpointer`

This seems fine until we add gmodule bindings :)

in the test files I had to #define GDK_PIXBUF_ENABLE_BACKEND so that the test could check the size of the structs

That's a bit annoying as that change will be overridden again when running generator.py or not?

No, the define is in manual.h so I assume it will not be overwritten

No, the define is in manual.h so I assume it will not be overwritten

Ah, not a problem then :)

Ah, not a problem then :)


Redirection of country to region page not working properly

Redirection from country page to region page doesn't work when there is an additional parameter (e.g: operations) in the URL
https://go.ifrc.org/countries/283/operations

Deployed to production in v7.0.19 release.


Is there any ongoing attempt to support reading RSA public/private keys from external files?

Not in ironclad proper, no.


Still maintained ?

Hello,
Do someone know if this project is still maintained ?
Seeing 48 PR is sad ^^'
Cheers !

50 now. And 245 issues. =/

Do we have any alternative to this library?

How about we fork it and find some new maintainers? So the PRs would go through and we could build this great module into a even greater one? :)

No @mdelclaro ^^
Well, if someone has the time to do it, would be great @slavikdenis . But in this case, it can be great to talk directly with the author.

What do you think @marcshilling ?

I was the original author but the repo got too popular for me to keep up with unfortunately. There's just so many different use cases for image selection in apps, it's very difficult to give everyone what they want. I turned it over to react-community in hopes that it would be in better hands, but it really needs a dedicated maintainer. I would be happy to invite anyone who is up to the task!

So folks, any candidates? :)

Well, I would like to help on this. But I'm not sure if I can handle it, since I'm a newbie in open source and react native as well :-)
Em 30 de ago de 2018, às 11:17, Denis Slávik <notifications<EMAIL_ADDRESS>escreveu:
So folks, any candidates? :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com/react-community/react-native-image-picker/issues/914#issuecomment-417335803, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AfbylHdPluQG83rcBeTJ4srGLRPvq9SLks5uV_QPgaJpZM4WBvkw.

👋 @marcshilling, I don't have the bandwidth to be the dedicated maintainer, but I can handle some PRs and issues related to Android (recent gradle issues).
If you want you can send me an invitation on GitHub & npm, and I should be able to do a release in the next few days.
If you have any questions, you can reach me out on the React Native Core Slack.

I can help with JS parts and handle some PR's too. I really love this
project and will be a pleasure to return the favor!
Em qui, 30 de ago de 2018 às 16:34, Nicolas Charpentier <
<EMAIL_ADDRESS>escreveu:

👋 @marcshilling https://github.com/marcshilling, I don't have the
bandwidth to be the dedicated maintainer, but I can handle some PRs and
issues related to Android (recent gradle issues).
If you want you can send me an invitation on GitHub & npm, and I should be
able to do a release in the next few days.
If you have any questions, you can reach me out on the React Native Core
Slack.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/react-community/react-native-image-picker/issues/914#issuecomment-417440833,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFu6HUXpxfmI9s4AZGdukwAONRXV06Dsks5uWD4rgaJpZM4WBvkw
.

--
Bruno Oliveira - Desenvolvedor Web
+551699173-1135

@charpeni welp, I invited you on npm but it seems as if my admin rights have been removed for this on GitHub. Not sure why...
@haitaoli can you help out? Would like to add @charpeni as a maintainer on this.

@marcshilling I guess your access became "write" when the project was migrated. I restored your admin permission.
@charpeni thanks for the help. I added you as admin too. As Airbnb is deprecating React Native from mobile code base, I don't have bandwidth to work on this project either. If you are willing to take the ownership I'd be glad to hand it over.

@haitaoli thanks!

@charpeni now that you have got permissions, can we just upgrade this lib to use latest Android Gradle settings as used in React-Native v0.57.0. So, that we could upgrade our project. For example, using rootProject.ext. This change should be small and already some PR's solve this.

Totally, that's what I was planning initially, but I got stuck with other issues. I should have more time soon.

In iPhone 6+ when tap on the camera icon. The app is getting crashed.Any one have the same issue.please let me know and how to solve this issue.

Hey everyone, I do have some free time and I would like to contribute. I someone wants to, I can help with JS and Android. Sadly I dont have iOS background. Maybe there is a Slack team that can be created?

I am willing to help if you add me as a collaborator on the github repo and the npm package.

I'm still there. Unfortunately, I don't have much dedicated time to this library.
The first step to help would be to review and QA pull requests.


Use credentials keystore, not clear passwords. Fix #108

use credentials keystore. fixes #108

Thanks @rigazilla


Handle adding reactions to messages from users who have blocked the bot

Completes the bot-side of #2486.
NB: In draft state since I'm not sure how to get the handling to work for schedules. Any help on this is appreciated.
What
When the bot fails to add a reaction to a message because the user has the bot blocked (e.g. creating an incident, editing an eval invocation, etc.) the bot handles this via a log.debug statement, and if a message is passed to the handler then will also send a message to the message's channel in discord (which deletes after 30 seconds -- long enough to give the user a chance to unblock the bot from that message).
Works For:

[x] Commands
[x] Events
[x] Schedules

Testing:
To test this, simply block the bot and then either create an incident, or edit an eval command (or anything else that causes the bot to react to your message).
Example:

scheduling is something that is handled by bot-core, so the fix would need to be there. The error handler should probably be ported there first, so we don't have to duplicate this in multiple places.

So are you suggesting to merge this PR as-is, and add the schedule handling to bot-core at a later time? I'd be okay with this, as long as the exceptions raised aren't going to cause sentry alerts etc.

For the record, @ChrisLovering and I have come up with a solution for handling errors in the schedules (see python-discord/bot-core#177).

I don't understand how the bot-core PR would help. Would we have to change all uses of create_task to add an error handler? That doesn't seem great, compared to just handling it there directly.

I don't understand how the bot-core PR would help. Would we have to change all uses of create_task to add an error handler? That doesn't seem great, compared to just handling it there directly.

Yeah, you're right, in reality we'd want the handle_forbidden_from_block function to be in bot-core ,and automatically added in create_task. I'll make that change to the bot-core PR :+1:

This is essentially stalled by python-discord/bot-core#177 now. Once that's merged, I can remove handle_forbidden_from_block from here, and migrate to importing from bot-core.

python-discord/bot-core#177 has now been merged, so will be continuing on with this.

This PR is now ready for review! :tada:


please update CHANGELOG.md?

hi,
your CHANGELOG.md has not been updated since your v0.1.0, and you're now on 0.2.4.
could you please update the CHANGELOG.md so we can see what changes are added to each release? thank you in advance.
best,
—  faddah
 portland, oregon, u.s.a.

Thank you for your advice.


Misaligned col header and table

Hello,
first of all very nice script. It completely solves my problem of visualizing big tables in limited screen space.
Unfortunately when I run it on my table the column headers are misaligned with the rest (see attached picture). The script (as downloaded from your site) is run on a table created using the Django template tag system. I'll upload both of them to help troubleshooting.
Also I would like to know whether it is possible to specify column alignment (vertical and horizontal) & width only for the first column, letting the others with default settings (for rendering different tables with a variable number of columns).
Cheers!
Filippo
Update: I can tell that the problem happens when the headers are cloned. Apparently the cloned ones have a different width from the original, from here the misalignment.

The HTML template
`

	{% load static %}
	Fixed Table Header & Column Sample

<style>
	html, body {font-family: Arial,sans-serif; font-size: 13px; margin: 0; padding: 0; background-color: #f2f2f2;}
	div.container {padding: 5px 15px; width: 1330px; margin: 10px auto;}
	.ft_container table tr th {background-color: #DBEAF9;
	}
</style>
<script>
$(function () {
	$('#fixed_hdr1').fxdHdrCol({
		fixedCols: 1,
		width:     '75%',
		height:    400,
		colModal: [
		   { width: 600, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' }
		]
	});
});

{% for q in matrix2 %}
{% if forloop.first %}
{% for y in q %}
 {{ y }}
{%endfor%}
{%else%}

{% if not forloop.first %}

{% for y in q %}
{{ y }}
{% endfor %}
{% endif %}
{% endif %}
{% endfor %}

`

single2.txt

Could you please attach the HTML code?

The text file attached above has the html code. I tried to copy paste it in this windows without much success.

`

	{% load static %}
	Fixed Table Header & Column Sample

<style>
	html, body {font-family: Arial,sans-serif; font-size: 13px; margin: 0; padding: 0; background-color: #f2f2f2;}
	div.container {padding: 5px 15px; width: 1330px; margin: 10px auto;}
	.ft_container table tr th {background-color: #DBEAF9;
	}
</style>
<script>
$(function () {
	$('#fixed_hdr1').fxdHdrCol({
		fixedCols: 1,
		width:     '75%',
		height:    400,
		colModal: [
		   { width: 600, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' }
		]
	});
});

{% for q in matrix2 %}
{% if forloop.first %}
{% for y in q %}
 {{ y }}
{%endfor%}
{%else%}

{% if not forloop.first %}

{% for y in q %}
{{ y }}
{% endfor %}
{% endif %}
{% endif %}
{% endfor %}

`

	{% load static %}
	Fixed Table Header & Column Sample

<style>
	html, body {font-family: Arial,sans-serif; font-size: 13px; margin: 0; padding: 0; background-color: #f2f2f2;}
	div.container {padding: 5px 15px; width: 1330px; margin: 10px auto;}
	.ft_container table tr th {background-color: #DBEAF9;
	}
</style>
<script>
$(function () {
	$('#fixed_hdr1').fxdHdrCol({
		fixedCols: 1,
		width:     '75%',
		height:    400,
		colModal: [
		   { width: 600, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' }
		]
	});
});

{% for q in matrix2 %}
{% if forloop.first %}
{% for y in q %}
 {{ y }}
{%endfor%}
{%else%}

{% if not forloop.first %}

{% for y in q %}
{{ y }}
{% endfor %}
{% endif %}
{% endif %}
{% endfor %}

<

`"

	{% load static %}
	Fixed Table Header & Column Sample

<style>
	html, body {font-family: Arial,sans-serif; font-size: 13px; margin: 0; padding: 0; background-color: #f2f2f2;}
	div.container {padding: 5px 15px; width: 1330px; margin: 10px auto;}
	.ft_container table tr th {background-color: #DBEAF9;
	}
</style>
<script>
$(function () {
	$('#fixed_hdr1').fxdHdrCol({
		fixedCols: 1,
		width:     '75%',
		height:    400,
		colModal: [
		   { width: 600, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' },
		   { width: 100, align: 'center' }
		]
	});
});

{% for q in matrix2 %}
{% if forloop.first %}
{% for y in q %}
 {{ y }}
{%endfor%}
{%else%}

{% if not forloop.first %}

{% for y in q %}
{{ y }}
{% endfor %}
{% endif %}
{% endif %}
{% endfor %}

"`

Sorry I think I closed this by error!

I need to see the complete HTML table code which is not available in the text file.

I suspect the root cause may be in the line
lc.ft_r.width(lc.tableWidth);
which scales the fixed row to the table's width. And though this resizes the individual th elements it does not do so in relation to the table body. This seems to me to be where the disconnect lies. For some column widths I think they just luckily seem to stretch to the appropriate size, but other's aren't so lucky.
I think the fixed row needs to be corrected for widths just like the set of corrections done for the row heights in the code following
//set height of fixed_rc and fixed_c


Windows 10: Watching a dir prevents moving/renaming its content in explorer

Hello there, first thank you very much for such a nice lib!
My config:

node 6.10.2
npm 3.10.10
chokidar 1.7.0

When I run the following script...
var chokidar = require('chokidar');
var fs = require('fs')
var path = require('path')

var dir = path.resolve('./tmp')
if (!fs.existsSync(dir)) fs.mkdirSync(dir)
var watcher = chokidar.watch('.', {
  cwd: dir
})
watcher.on('raw', (event, path, details) => {
  console.log('Raw event info:', event, path, details);
});

... and I start adding content in the Windows file explorer, it seems that as soon as a directory has a subdir, I cannot move/rename it anymore: Windows shows a popup saying the directory may be busy.
When I stop the watching script, I can move/rename everything again.
The issue doesn't occur when passing usePolling: true to chokidar.
Any idea of the best way to debug this?
Thanks

Example output before failing at renaming foo to foo2:
PS C:\Users\Seb\src\windows-busy> node .\index.js
Raw event info: rename Nouveau dossier { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp' }
Raw event info: rename Nouveau dossier { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp' }
Raw event info: rename foo { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp' }
Raw event info: rename Nouveau dossier { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp\\foo' }
Raw event info: change foo { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp' }
Raw event info: rename Nouveau dossier { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp\\foo' }
Raw event info: rename bar { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp\\foo' }
Raw event info: change foo { watchedPath: 'C:\\Users\\Seb\\src\\windows-busy\\tmp' }

Nothing we can do here afaik, seems to just be a side effect of the ReadDirectoryChangesW system API provided by Windows that fs.watch() utilizes. To avoid it, use polling, or turn off the watcher when making the sorts of changes that are in conflict.

Ok, thanks for the explanation!

I can do the same creation/renaming/move actions from a node script and it seems to work... Also it doesn't occur for a directory containing only files... Isn't it strange? (sorry for bothering you again with this)

Yes, it's strange. You're not the first one to report it. But it's something the Windows OS is responsible for.

I know it's old and propably already solved. But I stumbled over the same issue. I found out that I created the directory handle only with FILE_SHARE_READ since the HANDLE did not allow write I couldn't move files in.
I changed the handle creation to:
CreateFile(path,
        FILE_LIST_DIRECTORY,
        FILE_SHARE_READ| FILE_SHARE_WRITE| FILE_SHARE_DELETE,
        nullptr,
        OPEN_EXISTING,
        FILE_FLAG_BACKUP_SEMANTICS | FILE_FLAG_OVERLAPPED,
        nullptr)

So it is less an OS problem then a porblem of the library that calls the OS API.

Update your chokidar to v3


How to use ripgrep

Hi,
I have ripgrep installed on my machine.
How can I configure fzf-lua to just use ripgrep under the hood?

Excellent, thank you!


[BUG] Fix preview on scalingo

Les preview sont cassées depuis la migration Github.

@XavierJp can you do the link process on this page :
https://dashboard.scalingo.com/apps/osc-fr1/annuaire-entreprises-site/deploy/config
Thanks !

Weird, I dont have our new orga in the drop down

Does it work now ?

It does on Scalingo side, I'm waiting for a new PR to see if the deploy appears in the check section of PRs.


[TEP-0050] Add OnError field and documentation

Changes
In TEP-0050, we proposed to add an OnError API field under PipelineTask to configure error handling strategy.
This commits add the new OnError API field and the related documentations. The validation and business logic will be added in the follow-up PRs.
Note: OnError is in preview mode and not yet supported.
/kind feature

Submitter Checklist
As the author of this PR, please check off the items in this checklist:

[ ] Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
[ ] Has Tests included if any functionality added or changed
[ ] Follows the commit message standard
[ ] Meets the Tekton contributor standards (including functionality, content, code)
[ ] Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
[ ] Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
[ ] Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes
Add `OnError` field to PipelineTask (preview mode)

/assign

Thanks for the PR @QuanZhang-William. I think the v1beta1 types will also require relevant conversion functions. I suppose you are going to add that in a follow-up PR?
 I would recommend adding the type completely in a single PR (i.e. conversion, defaults and empty validations ). And then in the followup PR, you can add  actual validation followed by controller logic. WDYT?

why don't we add the docs when the feature is implemented?

Thanks for the PR @QuanZhang-William. I think the v1beta1 types will also require relevant conversion functions. I suppose you are going to add that in a follow-up PR? I would recommend adding the type completely in a single PR (i.e. conversion, defaults and empty validations ). And then in the followup PR, you can add actual validation followed by controller logic. WDYT?

Hi @chitrangpatel, sure I can put them in a single PR. I don't think we need to apply default values for this field though (which is same for step.OnError).

why don't we add the docs when the feature is implemented?

Hi @Yongxuanzhang. Seems like this the pattern we follow recently:

https://github.com/tektoncd/pipeline/pull/6188
https://github.com/tektoncd/pipeline/pull/7055

I feel users could be confused if we add an API field but has no documentation on it. I have called out in the doc that the feature is WIP and do not use it.

Could you also link the issue to track all the work plan? Thanks!

Could you also link the issue to track all the work plan? Thanks!

Sure, tracking issue added: https://github.com/tektoncd/pipeline/issues/7165

Thanks for the PR @QuanZhang-William. I think the v1beta1 types will also require relevant conversion functions. I suppose you are going to add that in a follow-up PR? I would recommend adding the type completely in a single PR (i.e. conversion, defaults and empty validations ). And then in the followup PR, you can add actual validation followed by controller logic. WDYT?

Hi @chitrangpatel, I have added validation and conversion logic in the PR, PTAL :)

/cc @pritidesai, please take a look if you are interested :)

@QuanZhang-William I think we should remove the release note - release notes are aimed towards users and since the feature doesn't work yet, I think it is confusing to add it
otherwise, LGTM

/lgtm

/retest

/lgtm

/test pull-tekton-pipeline-integration-tests
due to timeout


Add pattern\example for Stepper with validation

💬 Description
Currently on the site there is some brief text for stepper validation. However there is no example of how this might be implemented and there have been questions from users as to how you could do this.
💰 Use value
An example (possibly under the "Patterns") would be very useful to users to show how this should be implemented. The example should show not proceeding to the next step until validation errors have been resolved

an image on the stepper guidance would be good too


Using  this plug-in with "Checklists plugin (Light version)"

First of all, Thanks of all,,
When I use this plug-in with Checklists plugin (Light version),
It has the little issue for editing the description.
The 'enter' key mode can change to  "p" or "br" mode in Checklists plugin (Light version).
But, this plug-in supports only "p" mode.
How can I change the mode to 'br"  mode?
Thanks,

Hello
Thank you for your kind words !
I don't think if there's a solution for your specific case. Have you tried to press shift + enter (new line) instead of just enter (new paragraph) ?
Regards


Add systemd socket support and switch excepted for FreeBSD

Use galera::status_check to switch between xinetd and systemd support
Rename status_xinetd_service_name to status_service_name

Contain the rebased changes by @PopiBrossard and @TwizzyDizzy from #176
Breaking change because of:

galera::status_check fails on Boolean[True] usage
Rename galera::status_xinetd_service_name to galera::status_service_name
Uses systemd per default and only removes xinetd file which could result in the case that the port is already be used

Closes #176

Hi @fraenki - is something blocking this PR or do you need additional information from us?
Cheers
Thomas

Thanks for all the effort you put into this! We really appreciate this contribution. However, it took us some time to look into this... sorry for that.
I've reimplemented this in a backwards-compatible way in https://github.com/markt-de/puppet-galera/commit/975e1886dbcf876176cecc9772ad0f0839b87879. So instead of renaming variables and repurposing existing variables, I've introduced two new variables. Besides that I've enabled the systemd-based status check only on new distributions: RHEL 9+, Debian 12+, Ubuntu 24.04+. All older distributions will keep the xinetd status check (unless configured otherwise).
We still have some open issues on our list before we can issue a new release, but we're getting there...

Well... it won't surprise you that this makes us think twice, before contributing in the future. In hindsight we should've also inquired, whether a breaking change is acceptable or not.
From our POV, you should 1) read changelogs and 2) be in control of your data layer to adjust data, where it is needed to accomodate for breaking changes.
Since I (switching from "we" here on purpose) am not really satisfied with your solution we will likely need to implement this in our wrapper code instead of using that part of this module.
Shall we all learn from this to better clarify what is wanted and what is not wanted for PRs.
Cheers
Thomas

Apologies for not communicating this upfront.
I've copied the code from this PR.  It's the systemd-handling that was provided in this PR, and I've only made minor modifications to make it a non-breaking change for most of us.
Although the new systemd-handling is not enabled on older distributions by default, it's pretty easy to enable it using the class parameter:
class { 'galera':
  status_check_type => 'systemd',
  ...

Of if you're not satisfied with the defaults that this modules provides, then use Hiera (e.g. in your puppet-control repo) to override them:
puppet-control> cat data/os/RedHat-8-family.yaml
galera::status_check_type: 'systemd'

I'm sorry, I really don't understand the complaint.

I have to apologize here: my aggravation was mainly caused by internal stuff (and a tiny bit by the missed communication regarding the backwards-compatibility) and was misdirected towards you. Next time, I will do better.
Cheers
Thomas


Setting transport class in logging dict config

Hello, I have encountered a problem after upgrading from raven 5.x and not sure how to deal with it better.
In older raven versions it was allowed to set Transport in DSN parameter. Since my applications make use of logging dict config, I used to set Transport there. From now on it produces a warning Transport selection via DSN is deprecated. I was not able to set Transport class explicitly in logging dict config:
handlers:
  default:
    level: DEBUG
    class: logging.StreamHandler
    formatter: default
    stream: ext://sys.stdout
  sentry:
    level: INFO
    class: raven.handlers.logging.SentryHandler
    dsn<EMAIL_ADDRESS>    transport: raven.transport.threaded_requests.ThreadedRequestsHTTPTransport
    environment: development

Judging by the code, SentryHandler won't be instantiated if transport is of type str and not callable.
I wonder if there is an other way to set Transport class in logging dict config? Might an extra parameter transport_class be implemented in next versions so as to instruct SentryHandler to load the desired type of Transport by its string identifier?

This code block in RemoteConfig __init__ seems to solve the problem, but I guess it only works in Python 2.7:
        self.store_endpoint = store_endpoint

        # begin
        if isinstance(transport, basestring):
            transport_class_module = '.'.join(transport.split('.')[0:-1])
            transport_module = importlib.import_module(transport_class_module)
            transport_class_name = transport.split('.')[-1]
            if hasattr(transport_module, transport_class_name):
                transport = getattr(transport_module, transport_class_name)
        # end

        self._transport_cls = transport or DEFAULT_TRANSPORT


Basic field not populated - don't know where to start

It seems that it only imports the email, nothing else...
Also the docs state that

The Sendgrid Connector sends event and emails data from PostHog into Sendgrid whenever a user is identified in PostHog.

But I don't see event data anywhere on Sendgrid... Also I could not find any tutorial on how to setup/use.
I am trying to do some onboarding email automation. Any help/clarification would be greatly appreciated :)

Same issue happened to me.


Error: 'userData' as NULL when using DynamoDB config

I'm submitting a...

[X] Bug report
[x] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Expected Behavior
DynamoDB connection to update table with userData
Current Behavior
I receive the error log on the launch request of my Alexa app. It throws again on the request timeout.
The local DB file works for testing.
When including the database object in config settings of app.js the error pops up when calling a launch request
db: {
        type: 'dynamodb',
        tableName: 'NewTable'
    }

Error log
TypeError: Cannot read property 'userData' of null
    at platform.jovo.db.loadObject (C:\~\node_modules\jovo-framework\lib\user.js:39:33)
    at DynamoDb.checkResourceNotFound (C:\~\node_modules\jovo-framework\lib\integrations\db\dynamoDb.js:328:13)
    at Response.<anonymous> (C:\~\node_modules\jovo-framework\lib\integrations\db\dynamoDb.js:209:22)

Your Environment

Jovo Framework version used: 1.2.0
Operating System: Windows 10
Deployed to AWS Lambda

Hi @availit. Thanks, we're taking a look at this

Hey @availit !
How did you create your table?
Could you please log the error after line 34 in  /node_modules/jovo-framework/lib/user.js
...
this.platform.jovo.db().loadObject((error, data) => {
console.log(error);
...

Hi @aswetlow!
I was trying to create my table by giving it a name in the config and having jovo create it for me, at least that's what @jankoenig had mentioned to me is possible. The local DB file works great btw..
Here is the error I got to log after making a launch request:
ConfigError: Missing region in config
    at Request.VALIDATE_REGION (C:\Users\~\node_modules\aws-sdk\lib\event_listeners.js:91:45)
    at Request.callListeners (C:\Users\~\node_modules\aws-sdk\lib\sequential_executor.js:105:20)
    at callNextListener (C:\Users\~\node_modules\aws-sdk\lib\sequential_executor.js:95:12)
    at C:\Users\~\node_modules\aws-sdk\lib\event_listeners.js:85:9
    at finish (C:\Users\~\node_modules\aws-sdk\lib\config.js:320:7)
    at C:\Users\~\node_modules\aws-sdk\lib\config.js:338:9
    at SharedIniFileCredentials.get (C:\Users\~\node_modules\aws-sdk\lib\credentials.js:126:7)
    at getAsyncCredentials (C:\Users\~\node_modules\aws-sdk\lib\config.js:332:24)
    at Config.getCredentials (C:\Users\~\node_modules\aws-sdk\lib\config.js:352:9)
    at Request.VALIDATE_CREDENTIALS (C:\Users\~\node_modules\aws-sdk\lib\event_listeners.js:80:26)
  message: 'Missing region in config',
  code: 'ConfigError',
  time: 2018-05-29T15:35:40.998Z

Hi @availit, are you sure you're running it on Lambda? The paths (C:\Users\~\node_modules\aws-sdk\lib\event_listeners.js:91:45)  indicate that you're running it on your computer.
If you're running it on your computer, you need to add the AWS credentials, like this:
let awsConfig = {
    accessKeyId: 'yourAccessKeyId',
    secretAccessKey: 'yourSecretAccessKey',
    region:  'yourRegion',
};

// Using the constructor
const config = {
    db: {
        type: 'dynamodb',
        tableName: 'TableName',
        awsConfig: awsConfig,
    },
    // Other configurations
};

Take a look here https://www.jovo.tech/framework/docs/databases#dynamodb-for-apps-not-hosted-on-aws-lambda

Okay I just tested it on AWS and it's not creating a table.
No matter what I ask or say to my skill it just hits the Unhandled function until I comment out the DB config in the app.js file.
I can't find the log inside AWS for the user.js @aswetlow mentioned earlier? Sorry I'm a noob at aws lambda

You can find them in Cloudwatch https://console.aws.amazon.com/cloudwatch

Another interesting thing, I thought it was going to Unhandled but it just goes to the LAUNCH intent no matter what I say..
The Request:
{
    "type": "IntentRequest",
    "requestId": "amzn1.echo-api.request.e6517939-caa8-42c4-be83-920a14326244",
    "timestamp": "2018-05-29T16:50:42Z",
    "locale": "en-US",
    "intent": {
        "name": "SelectLocationIntent",
        "confirmationStatus": "NONE",
        "slots": {
            "store": {
                "name": "store",
                "value": "pla",
                "resolutions": {
                    "resolutionsPerAuthority": [
                        {
                            "authority": "amzn1.er-authority.echo-sdk.amzn1.ask.skill.cda18187-d800-4c43-b382-c080898dba79.centerCode",
                            "status": {
                                "code": "ER_SUCCESS_MATCH"
                            },
                            "values": [
                                {
                                    "value": {
                                        "name": "PLA",
                                        "id": "a9ae8dcc04ef529de1153d5731c4d65c"
                                    }
                                }
                            ]
                        }
                    ]
                },
                "confirmationStatus": "NONE"
            }
        }
    },
    "dialogState": "STARTED"
}

The Response:
2018-05-29T16:50:42.258Z	6c64ddc7-6360-11e8-bb62-0980c87d606c
{
    "version": "1.0",
    "response": {
        "shouldEndSession": false,
        "outputSpeech": {
            "type": "SSML",
            "ssml": "<speak>hello! welcome! what would you like to do?</speak>"
        },
        "reprompt": {
            "outputSpeech": {
                "type": "SSML",
                "ssml": "<speak>please say a command.</speak>"
            }
        }
    },
    "sessionAttributes": {}
}

We added some additional info here: https://www.jovo.tech/guides/add-dynamodb-database Let us know if your issue "persists" (pun intended)


bug: conda and mamba are not 100% exchangeable

Description

we supported micromamba in #891

Currently, we cannot replace miniconda with micromamba because:

their command-line interfaces are not exactly the same

micromamba create -n envd python=3.7 --file env.yaml v.s. conda env create -n envd python=3.7 --file env.yaml
micromamba update -n envd --file env.yaml v.s. conda env update -n envd --file env.yaml
micromamba update --file env.yaml won't install new packages from the YAML file

Additional Info

Message from the maintainers:
Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

According to my observation, micromamba update -f env.yaml doesn't install anything from the YAML file. Instead, it only updates all the existing packages.

We'd better use conda update because it requires mounts, which means it cannot be cached.

Originally posted by @kemingy in https://github.com/tensorchord/envd/issues/933#issuecomment-1265166042


Update MFA configuration within profile editing user flow

Hello,
I am wondering if it is possible to let the user update / edit the configuration related to the MFA after the first / initial configuration triggered by B2C tenant, according to the MFA settings.
User is forced to configure the MFA at first logon. Is it possible for the user to change these settings by himself, same as profile editing ?
Thank you very much for your help

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d1b2f352-2d04-bda7-fafd-2f2ce1f85aa3
Version Independent ID: ad0ee7de-8679-6387-1f52-b45b24a99cf4
Content: Set up a profile editing flow - Azure AD B2C
Content Source: articles/active-directory-b2c/add-profile-editing-policy.md
Service: active-directory
Sub-service: b2c
GitHub Login: @msmimart
Microsoft Alias: mimart

@fbasco81 Thank you for your query . We will investigate and update the thread.

@fbasco81 For this purpose, you need to use custom policy as provided here Azure AD B2C: Edit MFA phone number.
Note: This feature is not Generally Available and is currently in private preview which is why it is not documented under the official B2C documentation. Please test it in dev environment before deploying this policy to production.

@fbasco81 For this purpose, you need to use custom policy as provided here Azure AD B2C: Edit MFA phone number.
Note: This feature is not Generally Available and is currently in private preview which is why it is not documented under the official B2C documentation. Please test it in dev environment before deploying this policy to production.


Flesh out ProtoMat S103 SOP

Currently mostly blank.

Please assign an issue to me to review the SOP when you are done.


fix the bug: kube-batchd can not aware of the changes of gpu resources when scale up cluster.

fix the issue: kube-batchd can not aware of the changes of gpu resources when scale up cluster.

when scale up cluster, AddNode does not contain gpu info, as node register to kube-apiserver
prior to nvidia device plugin successfully register gpu deivces.
So UpdateNode should set the Idle Resouces for gpu to Allocatable gpu resouces.

/close


Ndvi clim ds

Proposed changes
Add a datasets notebook for NDVI climatology
Checklist (replace [ ] with [x] to check off)

[X] Remove any unused Python packages from Load packages
[X] Remove any unused/empty code cells
[X] Remove any guidance cells (e.g. General advice)
[X] Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended)
[X] Include relevant tags in the first notebook cell and re-use tags if possible
[X] Ensure appropriate colour schemes  have been used to maximise accessibility for vision impairment. Test your images or learn more with Coblis or TPGI
[X] Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated

Phenology example analysis is cool! I added some details to markdown + the odd typo, otherwise ready for final review, I think.


Table should not be migrate

In Connection.php line 664:
SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed: No such host is known.  (SQL: insert into oauth_clients (user_id, name, secret, redirect, personal_access_client, password_client, revok   ed, updated_at, created_at) values (, Laravel API Personal Access Client, nBN4Cssau7Xbbe6bDJVbqpN50LrooVB9OdHWB8dn, http://localhost, 1, 0, 0, 2018-08-24 11:15:44, 2018-08-24 11:15:44))
In Connector.php line 68:
SQLSTATE[HY000] [2002] php_network_getaddresses: getaddrinfo failed: No such host is known.
In Connector.php line 68:
PDO::__construct(): php_network_getaddresses: getaddrinfo failed: No such host is known.

It seems to be a database configuration issue. What is the database "host" configured ?

Where is the Admin Panel?

laravel-api is an http api project based on Laravel framework. To configure a database, please refer to the Laravel official documentation.


boards: rename Hex -> CubePilot

@proficnc as requested
The boards are organized by vendor and model.

Hex/Cube-Yellow (hex_cube-yellow_default) -> CubePilot/Yellow (cubepilot_yellow_default)
Hex/Cube-Orange (hex_cube-orange_default) -> CubePilot/Orange (cubepilot_orange_default)

FYI @JacobCrabill @mirkix @dakejahl

Thanks guys.

Take 2.

Vendor
Model

CubePilot
CubeOrange

CubePilot
CubeYellow

Hex/Cube-Yellow (hex_cube-yellow_default) -> CubePilot/CubeYellow (cubepilot_cubeyellow_default)
Hex/Cube-Orange (hex_cube-orange_default) -> CubePilot/CubeOrange (cubepilot_cubeorange_default)

I tried to get the yellow and orange board configs into sync. There were some concerning differences like GPIO_nVDD_3V3_SENSORS_EN instead of GPIO_VDD_3V3_SENSORS_EN that have been rectified.


fix(experimentalIdentityAndAuth): add strict check for token in HttpBearerAuthSigner

Issue #, if available:
N/A.
Description of changes:
Add strict check for token in HttpBearerAuthSigner.
If one or more of the packages in the /packages directory has been modified, be sure yarn changeset add has been run and its output has
been committed and included in this pull request. See CONTRIBUTING.md.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.


Add device specific screenshot tests

A simple parameterized base class to make adding screenshot tests simple.
to run use ./gradlew recordRoborazziDebug  and ./gradlew recordRoborazziDebug
TODO in later PR

setup Github workflows for testing, recording
setup Github LFS?
re-record in Ubuntu runner

Thank you, looking nice!
I wish it was easy to test with the Google Fonts, but it's not AFAIK.
I added a commit to have a single place to update roborazzi, you can check it.


Lilybin on Android phone

Hi,
Thanks for this great tool, I can work with Lilypond everywhere. But i have a problem on my 5 inch Android phone with Chrome Browser : I've no access to the code panel because of the size of the preview panel that I cannot reduce . The best will be to have a button at right to hide/show preview panel and a button at left to hide/show dropbox panel.
Christophe

This bug is also true on Firefox for android.  It renders the bin unusable as copy and paste also do not work (tm). Thanks for the great work.

lilybin uses cursor: e-resize to resize the code window which is not available on mobile browsers. I'll dig around for options.


Fix networkMap construction in ListServices

This PR fixes #719
The problem is due to a moving pointer reference. The networkMap lists network IDs all with the same network information.

@vincentlepot could you rebase on the v1.1 branches :angel: (we'll merge it back to master after the release)

Rebase done


[captureWithOrientation()] Load SHUTTER_CLICK sound to reduce latency…

… while playing during capture
Found this micro improvement in the docs while I was searching for a way to fix an issue with my on-capture sound response being halved by an unapparent latency issue. Preloading the media sound and only playing it during capture solved the issue for me.
Perhaps this initial set and load regardless of the boolean value of playSoundOnCapture is worth the micro bits of improvement down the road for applications that do require sound.

Thanks!


Cannot Open Specter-Desktop Wallet

Just tested on 0.9.6 to see how progress is coming on #18 and this has gotten much worse :(
File > Open Wallet... > Choose file:

File for reference:
$ cat any_recovery.json
{ "label": "Any Recovery", "blockheight": 1863986, "descriptor": "wsh(sortedmulti(1,[c7d0648a/48h/1h/0h/2h]tpubDEpefcgzY6ZyEV2uF4xcW2z8bZ3DNeWx9h2BcwcX973BHrmkQxJhpAXoSWZeHkmkiTtnUjfERsTDTVCcifW6po3PFR1JRjUUTJHvPpDqJhr/0/*,[12980eed/48h/1h/0h/2h]tpubDEkXGoQhYLFnYyzUGadtceUKbzVfXVorJEdo7c6VKJLHrULhpSVLC7fo89DDhjHmPvvNyrun2LTWH6FYmHh5VaQYPLEqLviVQKh45ufz8Ae/0/*,[3a52b5cd/48h/1h/0h/2h]tpubDFdbVee2Zna6eL9TkYBZDJVJ3RxGYWgChksXBRgw6y6PU1jWPTXUqag3CBMd6VDwok1hn5HZGvg6ujsTLXykrS3DwbxqCzEvWoT49gRJy7s/0/*,[f7d04090/48h/1h/0h/2h]tpubDF7FTuPECTePubPXNK73TYCzV3nRWaJnRwTXD28kh6Fz4LcaRzWwNtX153J7WeJFcQB2T6k9THd424Kmjs8Ps1FC1Xb81TXTxxbGZrLqQNp/0/*))#tatkmj5q" }

--
Btw, File > Import Wallet... is worse. The file is greyed out and I can't select anything. I can hit Scan but then Sparrow immediately crashes.

Even if the functionality worked all of these UIs would be confusing. I just want to copy-paste in a descriptor, there's no reason for me to be saving files or scanning QR codes (if Specter is on my local machine).
--
There's also creating a new wallet and then hitting Edit..., but this also doesn't work with SD's copy-paste formatting (it adds \s that Sparrow can't parse):

If I manually edit the wsh entry from SD to look like what's in any_recovery.json I'm able to make it to this error message:

I don't see anywhere to tell sparrow that tpub is testnet, is testnet supported?

Testnet is supported. In fact, the majority of these issues are caused by simply not enabling testnet, which can be done in a number of ways and is documented in the project root README.md: https://github.com/sparrowwallet/sparrow#configuration
With testnet running, I have:

Opened the file above
Cut and pasted the output descriptor into the dialog presented by the Edit descriptor button on the Wallet Settings page

Both of the above worked without issues.
There is a minor bug in the current release with the file selection dialog with the 'All files' filter selected - it was a fix for Linux but unfortunately that fix caused a regression in OSX. The workaround until the next release later this week is to choose the JSON/TXT file filter in that dialog.
I wasn't aware the Specter was adding (illegal) \ characters - I have removed those from the output descriptor when copy pasting in https://github.com/sparrowwallet/sparrow/commit/13a486597c3f6410e222c33707e8a946bc1846b7.
I'd appreciate it if you can share any errors in sparrow.log in the Sparrow home folder regarding the crash you experienced with the Scan button - I imagine this may have something to do with the native webcam library.


Use support design navigation drawer

In the google support design lib is a navigation drawer included : http://developer.android.com/reference/android/support/design/widget/NavigationView.html?utm_campaign=io15&utm_source=dac&utm_medium=blog

Added in Atarashii version 2.2.1


fix(cli): tell user of missing lockfile or manifest during info

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] New Binding Issue #___
[ ] Code style update
[ ] Refactor
[ ] Build-related changes
[ ] Other, please describe:

Does this PR introduce a breaking change?

[ ] Yes. Issue #___
[x] No

The PR fulfills these requirements:

[x] It's submitted to the dev branch and not the master branch
[x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

[ ] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Expands on the fix in #674.  It will handle any error (like it did before the original change for #610) except it won't swallow them.  The original block was wrapped in an empty try { ... } catch(_) {} which I didn't replicate in the code replacing it.  This new fix will handle any read error for toml files, and communicate when the expected files are missing when attempted to be read.

It will also now read the manifest along with the lockfile so that it can communicate a missing manifest even if there is a lockfile.

Awesome PR as always, thank you!


[Post /data-decoder] 400 bad request - 42  "Validation failed"

Request: Post https://safe-client-nest.staging.5afe.dev/v1/chains/137/data-decoder
Status code  : 400 Bad Request
Payload : {"data":"0x42842e0e000000000000000000000000b412684f4f0b5d27cc4a4d287f42595ab3ae124d000000000000000000000000b412684f4f0b5d27cc4a4d287f42595ab3ae124d0000000000000000000000000000000000000000000000000000000000000001"}
Response : {"message":"Validation failed","code":42,"arguments":[]}
Steps from the Web client side:

go to the https://test_new_cgw_url--walletweb.review-wallet-web.5afe.dev/balances/nfts?safe=matic:0xb412684F4F0B5d27cC4A4D287F42595aB3ae124D
try to send NFT
Go to the Review NFT transaction

Response from the old CGW: {"method":"safeTransferFrom","parameters":[{"name":"from","type":"address","value":"0xb412684F4F0B5d27cC4A4D287F42595aB3ae124D"},{"name":"to","type":"address","value":"0xb412684F4F0B5d27cC4A4D287F42595aB3ae124D"},{"name":"tokenId","type":"uint256","value":"1"}]}

Same for the next payload  (this is add spending limits details): 0x8d80ff0a000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000001eb00b412684f4f0b5d27cc4a4d287f42595ab3ae124d00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024610b59250000000000000000000000001fb403834c911eb98d56e74f5182b0d64c3b3b4d001fb403834c911eb98d56e74f5182b0d64c3b3b4d00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024e71bdf410000000000000000000000004c3c38a459f0baabb763290111b66ed01b5fefa2001fb403834c911eb98d56e74f5182b0d64c3b3b4d000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a4beaeb3880000000000000000000000004c3c38a459f0baabb763290111b66ed01b5fefa20000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000002386f26fc1000000000000000000000000000000000000000000000000000000000000000005a00000000000000000000000000000000000000000000000000000000001ac4d6c000000000000000000000000000000000000000000
response : validation failed
Expected response :
{     "method": "multiSend",     "parameters": [         {             "name": "transactions",             "type": "bytes",             "value": "0x00b412684f4f0b5d27cc4a4d287f42595ab3ae124d00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024610b59250000000000000000000000001fb403834c911eb98d56e74f5182b0d64c3b3b4d001fb403834c911eb98d56e74f5182b0d64c3b3b4d00000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000024e71bdf410000000000000000000000004c3c38a459f0baabb763290111b66ed01b5fefa2001fb403834c911eb98d56e74f5182b0d64c3b3b4d000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000a4beaeb3880000000000000000000000004c3c38a459f0baabb763290111b66ed01b5fefa200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000de0b6b3a764000000000000000000000000000000000000000000000000000000000000000005a00000000000000000000000000000000000000000000000000000000001ac4d6f",             "valueDecoded": [                 {                     "operation": 0,                     "to": "0xb412684F4F0B5d27cC4A4D287F42595aB3ae124D",                     "value": "0",                     "data": "0x610b59250000000000000000000000001fb403834c911eb98d56e74f5182b0d64c3b3b4d",                     "dataDecoded": {                         "method": "enableModule",                         "parameters": [                             {                                 "name": "module",                                 "type": "address",                                 "value": "0x1Fb403834C911eB98d56E74F5182b0d64C3b3b4D"                             }                         ]                     }                 },                 {                     "operation": 0,                     "to": "0x1Fb403834C911eB98d56E74F5182b0d64C3b3b4D",                     "value": "0",                     "data": "0xe71bdf410000000000000000000000004c3c38a459f0baabb763290111b66ed01b5fefa2",                     "dataDecoded": {                         "method": "addDelegate",                         "parameters": [                             {                                 "name": "delegate",                                 "type": "address",                                 "value": "0x4c3c38a459F0bAABB763290111B66ed01b5fEfA2"                             }                         ]                     }                 },                 {                     "operation": 0,                     "to": "0x1Fb403834C911eB98d56E74F5182b0d64C3b3b4D",                     "value": "0",                     "data": "0xbeaeb3880000000000000000000000004c3c38a459f0baabb763290111b66ed01b5fefa200000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000de0b6b3a764000000000000000000000000000000000000000000000000000000000000000005a00000000000000000000000000000000000000000000000000000000001ac4d6f",                     "dataDecoded": {                         "method": "setAllowance",                         "parameters": [                             {                                 "name": "delegate",                                 "type": "address",                                 "value": "0x4c3c38a459F0bAABB763290111B66ed01b5fEfA2"                             },                             {                                 "name": "token",                                 "type": "address",                                 "value": "0x0000000000000000000000000000000000000000"                             },                             {                                 "name": "allowanceAmount",                                 "type": "uint96",                                 "value": "1000000000000000000"                             },                             {                                 "name": "resetTimeMin",                                 "type": "uint16",                                 "value": "1440"                             },                             {                                 "name": "resetBaseMin",                                 "type": "uint32",                                 "value": "28069231"                             }                         ]                     }                 }             ]         }     ] }

Unfortunately I am having the same issue as Lili after the fix was merged 😢
https://github.com/safe-global/safe-client-gateway-nest/assets/92332710/20b7239c-8fc0-442d-a93c-239edb35b3ed
Will reopen this for further 👀

Unfortunately I am having the same issue as Lili after the fix was merged 😢
issue.mp4
Will reopen this for further 👀

@JagoFigueroa can you share the request and response?


attempt to port quantum_causal_cone to rust

Summary
This is almost a line-by-line port of the quantum_clausal_cone function from  #12668.
Except that I got really confused how to return the computed set of qubits, the code
let elements : Vec<_> = qubits_in_cone.iter().map(|&qubit| qubit.0.into_py(py)).collect();
Ok(PySet::new_bound(py, &elements)?.unbind())

seems wrong on many levels. First, I could get it to compile only by collecting qubits into a vector and then passing this into PySet. And second, this currently returns the set of qubit indices, and not of the actual Qubits.
My other question if there were more ergonomic ways to implement some of the functionality, such as checking whether a given set of qubits intersects the set of node's qubits. In Python, this was something like
if qubits_in_cone.isdisjoint(set(pred.qargs))

and in this Rust implementation it's something like
if !qubits_in_cone.is_disjoint(&HashSet::<&Qubit>::from_iter(self.qargs_cache.intern(pred_packed.qubits_id).iter(),))

Details and comments

Thanks @kevinhartman, I have applied your suggestions. I am especially happy to see that the function now returns the actual Qubit objects, matching the Python implementation. For posteriority, I have been using the following Python code to see that the old and the new results match:
from qiskit.dagcircuit import DAGCircuit as PristineCircuit
RustyCircuit = qiskit._accelerate.circuit.DAGCircuit

qreg = QuantumRegister(5)
creg = ClassicalRegister(5)

rdag = RustyCircuit()
rdag.add_qreg(qreg)
rdag.add_creg(creg)
rdag.apply_operation_back(CXGate(), qreg[[1, 2]], [])
...

udag = PristineCircuit()
udag.add_qreg(qreg)
udag.add_creg(creg)
udag.apply_operation_back(CXGate(), qreg[[1, 2]], [])
...

for i in range(5):
    rres = rdag.quantum_causal_cone(qreg[i])
    ures = udag.quantum_causal_cone(qreg[i])
    assert rres == ures

@alexanderivrii

For posteriority, I have been using the following Python code to see that the old and the new results match:

I believe I've actually already wired things up such that the DAGCircuit exposed from qiskit.dagcircuit is actually the Rust one, so you will likely need to run two branches to compare these 😅