libs not found in kts file using apply(from = starting in 8.1

Expected Behavior
I have a common ktlint.gradle.kts file in my root directory to apply ktlint to multiple projects. It is applied using a line of the form:
apply(from = "$rootDir/ktlint.gradle.kts")
The start of that file looks like this (which is enough to show the change in behavior):
val ktlintConfig: Configuration by configurations.creating

dependencies {
    ktlintConfig(libs.ktlint) {
        attributes {
            attribute(Bundling.BUNDLING_ATTRIBUTE, objects.named(Bundling.EXTERNAL))
        }
    }
}

This is referencing a ktlint library I have defined in libs.versions.toml.
That works up through version 8.0.2.
Current Behavior
Starting with version 8.1 this no longer works and fails with an error:
Script compilation error:

  Line 4:     ktlintConfig(libs.ktlint) {
                           ^ Unresolved reference: libs

1 error

Context (optional)
Prevents upgrading past 8.0.2
Steps to Reproduce
Reference libs in a kts file included using apply
Gradle version
8.1
Build scan URL (optional)
No response
Your Environment (optional)
Mac OS

Triage

Accessing version catalogs from applied scripts via names was working by accident in Gradle < 8.1.
For sharing logic you should prefer using convention plugins instead of applied scripts.
In applied scripts you should use the API to access version catalogs as demonstrated above.
We do not plan to fix this.

I have a similar use case as original poster:
val ktlint: Configuration by configurations.creating

configurations {
    ktlint
}

dependencies {
    ktlint(libs.ktlint)
}
...

Gives me an error.  If I try the workaround you posted above I get an error:
FAILURE: Build failed with an exception.

* Where:
Script '<path_to_file>'/ktlint.gradle.kts' line: 8

* What went wrong:
Extension with name 'libs' does not exist. Currently registered extension names: [ext, npm, devNpm, optionalNpm, peerNpm]

@eskatos just to be clear, something like https://github.com/gradle/gradle/issues/24426 is no longer valid then?  It sounded like this was supposed to address issues accessing libs values in applied kotlin scripts - exactly what I'm doing here unless I am mistaken!
I appreciate any assistance with this matter, still learning about Gradle :) thank you!

Applied scripts don't get accessors, see https://docs.gradle.org/current/userguide/kotlin_dsl.html#kotdsl:accessor_applicability
For sharing logic you should prefer using convention plugins instead of applied scripts.
In applied scripts you should use the API to access version catalogs as demonstrated above.
We do not plan to fix this.


conformance changes in earlier versions

The introduction text links to a few pages with information regarding "conformance changes in earlier versions". However, none of the links point to a table similar to the table on this page but for earlier versions. Is it possible to add a link to the page "Support For C++11/14/17 Features (Modern C++)" in the sentence starting with "For conformance changes in earlier versions, see" and in the "See also" section?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: d606e0aa-36fd-97f2-6e65-af0f9b05b24c
Version Independent ID: 207d361a-397e-d687-8828-a152ebc4e572
Content: Microsoft C++ language conformance table
Content Source: docs/overview/visual-cpp-language-conformance.md
Product: visual-cpp
Technology: cpp-language
GitHub Login: @corob-msft
Microsoft Alias: corob

@TSlivede
We generally prefer not to link to pages we can't update. The page you're referring to was split into the two current pages, C++ conformance improvements in Visual Studio and Microsoft C++ language conformance table. The current table does have all the info for what's supported by version, it's just not in an easy tabular format.

I can fully understand, that you don't want to link to pages, that are no longer updated. However, the information on that page can currently not found on any of the following pages:
https://docs.microsoft.com/en-us/cpp/overview/visual-cpp-language-conformance
https://docs.microsoft.com/en-us/cpp/overview/cpp-conformance-improvements
https://docs.microsoft.com/en-us/cpp/overview/what-s-new-for-visual-cpp-in-visual-studio
https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-change-history-2003-2015
https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-what-s-new-2003-through-2015

For example: In what version of Visual Studio was the Exception specification noexcept added? The table on https://docs.microsoft.com/en-us/previous-versions/hh567368(v=vs.140) clearly shows, that it was added in Visual Studio 2015, but I can't find any information about that in the above mentioned pages.
Another example: In what version of Visual Studio was Extended sizeof added? The "old" table shows, that it was added in Visual Studio 2015, but again I can't find any information about that in the above "up to date" pages.

Suggestion:
Could the table from https://docs.microsoft.com/en-us/previous-versions/hh567368(v=vs.140) be added to https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-what-s-new-2003-through-2015?
Alternatively: Could a new page (for example) https://docs.microsoft.com/en-us/cpp/porting/visual-cpp-language-conformance-2010-through-2015 be created with the contents of https://docs.microsoft.com/en-us/previous-versions/hh567368(v=vs.140)? The reasoning
This information is provided as a convenience in case it might be useful when upgrading from earlier versions of Visual Studio.
could apply to that page as well.

@corob-msft Or should I open a new Issue with that suggestion?


Publish: Description section is confusing

The Issue
When publishing, the title/thumbnail/description section is grouped and you need to scroll to add a description - this is confusing it's not clear that you need to scroll down

Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else

Screenshots

Already created an issue for this one
On Wed, Mar 28, 2018, 10:13 AM Thomas Zarebczan<EMAIL_ADDRESS>wrote:

The Issue
When publishing, the title/thumbnail/description section is grouped and
you need to scroll to add a description - this is confusing it's not clear
that you need to scroll down
[image: des]
https://camo.githubusercontent.com/8763b08bfbef2324cb1c24b5ff9b415b8855ea83/68747470733a2f2f7777772e73637265656e636173742e636f6d2f742f317045357563734e344c35
Steps to reproduce

Expected behaviour
Tell us what should happen
Actual behaviour
Tell us what happens instead
System Configuration

LBRY Daemon version:
LBRY App version:
LBRY Installation ID:
Operating system:

Anything Else Screenshots
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/lbryio/lbry-app/issues/1201, or mute the thread
https://github.com/notifications/unsubscribe-auth/AQGcjsy6fGvgCmxXrGH5X7exDPBslcxhks5ti8SfgaJpZM4S_B3S
.

#1195

@seanyesmunt my bad, I should check those first :p


Basic sanity test integration test for HDFS

Copied over basic sanity test (install hdfs) from dcos_hdfs_service project. @NimaVaziri

@susanxhuynh Once that one comment is addressed, this should be good to merge.


Cannot get new Crashlytics instance after deleting and recreating default FirebaseApp

Description
We need to change default firebase app configuration at some point in our application, and want to get a Crashlytics instance for this new default app (which has a different configuration than the previous one).
So we start by deleting current default application doing FirebaseApp.app()?.delete().
Looking at code it should clear the associated container that keeps the Crashlytics cached instance:
// Remove all cached instances from the container before deleting the app.
[self.container removeAllCachedInstances];

But after configuring the new default app with custom configuration using FirebaseApp.configure(options: newOptions) we cannot get the associated new Crashlytics instance. We have this error message instead:

11.6.0 - [FirebaseCrashlytics][I-CLS000000] Cannot instantiate more than one instance of Crashlytics.

It seems related to this part of code:
    if (!atomic_compare_exchange_strong(&_hasInitializedInstance, &expectedCalled, YES)) {
      FIRCLSErrorLog(@"Cannot instantiate more than one instance of Crashlytics.");
      return nil;
    }

Meaning that _hasInitializedInstance is not resetted to false when the first FirebaseApp was deleted, and it's container cleared.
Reproducing the issue
FirebaseApp.configure()
Crashlytics.crashlytics().setCrashlyticsCollectionEnabled(true)
await FirebaseApp.app()?.delete()
FirebaseApp.configure(options: newOptions) // Set new options, maybe the problem occurs with default options too
Crashlytics.crashlytics().setCrashlyticsCollectionEnabled(true)
// Logs: 11.6.0 - [FirebaseCrashlytics][I-CLS000000] Cannot instantiate more than one instance of Crashlytics.

Firebase SDK Version
11.6.0
Xcode Version
16.0.0
Installation Method
N/A
Firebase Product(s)
Crashlytics
Targeted Platforms
iOS
Relevant Log Output
11.6.0 - [FirebaseCore][I-COR000003] The default Firebase app has not yet been configured. Add `FirebaseApp.configure()` to your application initialization. This can be done in in the App Delegate's application(_:didFinishLaunchingWithOptions:)` (or the `@main` struct's initializer in SwiftUI). Read more: https://firebase.google.com/docs/ios/setup#initialize_firebase_in_your_app
11.6.0 - [FirebaseCore][I-COR000001] Configuring the default app.
11.6.0 - [FirebaseCore][I-COR000033] Data Collection flag is not set.
11.6.0 - [FirebaseCrashlytics][I-CLS000000] [Crashlytics] Running on iOS Simulator (iPhone), 18.0.0 (23H124)
11.6.0 - [FirebaseCrashlytics][I-CLS000000] Registering Sessions SDK subscription for session data
11.6.0 - [FirebaseCrashlytics][I-CLS000000] Session ID changed: ***
11.6.0 - [FirebaseCrashlytics][I-CLS000000] Root: ***
11.6.0 - [FirebaseCrashlytics][I-CLS000000] [Crashlytics:Crash:Reports:Event] Firebase Analytics SDK not detected. Crash-free statistics and breadcrumbs will not be reported
11.6.0 - [FirebaseCrashlytics][I-CLS000000] Automatic data collection is disabled.
11.6.0 - [FirebaseCrashlytics][I-CLS000000] [Crashlytics:Crash] 0 unsent reports are available. Waiting for send/deleteUnsentReports to be called.
11.6.0 - [FirebaseCrashlytics][I-CLS000000] Sending unsent reports.
11.6.0 - [FirebaseCore][I-COR000006] Deleting app named __FIRAPP_DEFAULT
11.6.0 - [FirebaseCore][I-COR000003] The default Firebase app has not yet been configured. Add `FirebaseApp.configure()` to your application initialization. This can be done in in the App Delegate's application(_:didFinishLaunchingWithOptions:)` (or the `@main` struct's initializer in SwiftUI). Read more: https://firebase.google.com/docs/ios/setup#initialize_firebase_in_your_app
11.6.0 - [FirebaseCore][I-COR000001] Configuring the default app.
11.6.0 - [FirebaseCrashlytics][I-CLS000000] Cannot instantiate more than one instance of Crashlytics.
11.6.0 - [FirebaseCrashlytics][I-CLS000000] Cannot instantiate more than one instance of Crashlytics.

If using Swift Package Manager, the project's Package.resolved

Expand Package.resolved snippet

Replace this line with the contents of your Package.resolved.

If using CocoaPods, the project's Podfile.lock

Expand Podfile.lock snippet

Replace this line with the contents of your Podfile.lock!

Thanks for reporting, @ybasset. Per checking, this seems to be an expected behavior. Crashlytics only works on Firebase default app. During initialization, we only register the Crashlytics component to default app (with the name __FIRAPP_DEFAULT). As this default app is being deleted, it is causing the issue that you're encountering. See the related code here.

I've seen that Crashlytics is tied to Firebase default app, but if we delete the Firebase default app Crashlytics shouldn't be stuck. We should be able to get Crashlytics for the newly configured Firebase default app that replaces the previous one, using the same name __FIRAPP_DEFAULT. It won't lead to multiple instances of Crashlytics since the previous one has been destroyed when deleting the Firebase app when the cache container was cleaned. Moreover the single instance check could be made on the cache container instead of an external boolean.
In my code example the second call to FirebaseApp.configure() isn't specifying the app name so it will be the new Firebase default app named __FIRAPP_DEFAULT.

Hi @ybasset, is it possible for you to provide an MCVE to reproduce the issue?

Hi @rizafran, sorry I'm currently on hollidays for the end of the year.
I'll provide a working example when I'll be back at work.

@ybasset does Crashlytics continue to work if you hold on to the instance of Crashlytics returned by Crashlytics.crashlytics()?


Add declare namespace

This allows user to use the  import * as Promise from 'any-promise';

https://github.com/palantir/tslint/pull/1016#discussion_r58152504
@JKillian, I tried to do what you suggested back in the extends feature here, but in this case it doesn't work.
After the change, I can do import * as Promise from 'any-promise';
but when I try to use it:

Any idea?

If you can do import * as Promise from 'any-promise';, you should definitely be able to use the Promise identifier in your code... maybe an IDE issue?

Interesting. I do see it is working like you said.
Will file an issue on vscode and likely tsc

I don't intend to support this, it's a hack and not valid ES6.

Argee to your direction.
For reference, currently the only way to import this library in ES6 syntax is either:

module: "commonjs" + allowSyntheticDefaultImports: "true", or
module: "system"

and Thus connects to https://github.com/Microsoft/TypeScript/issues/7398

@unional Sorry that previous post was a little brief/harsh, I know we've had the discussion before 😄 I don't think we should be forcing non-ES6 imports into an ES6 syntax, it's just not possible unless TypeScript intends to emit the correct transformations at the JavaScript level (E.g. emit x = require('x') instead of x = require('x').default). For the correct transformations to be emitted, we'd need accurate type definitions anyway, and that's not the ES6 construct you'd be using.

It's all good. I said in the past that I was trying to setup the environment / framework in my company and one thing I tried to avoid is forcing them to understand and use both require() and import ... from ....
But as you know we discover the issue of the interop and today I'm "officially" abandoning that idea:
https://github.com/unional/typescript/blob/master/style-guide/default/modules.md#import-keyword
:tulip:


BUG:  useless

Did you check docs and existing issues?

[X] I have read all the docs.
[X] I have searched the existing issues.
[X] I have searched the existing discussions.

Neovim Version (nvim -v)
NVIM v0.10.0 Build type: Release LuaJIT 2.1.1713484068
Operating System / Version
macos 14.5 (23F79)/Fedora 40
Describe the Bug
 doesn't work on both linux and macos.
Screenshots, Traceback
No response
Steps to Reproduce

open neovim-tree
press  then press
 doesn't work.

Expected Behavior
 should work

This issue exists for a long time. I locate the bad commit by git, find it should be 6e20108c4a8128782f534f5fe90c757b44212ef6

After applay this patch, it works:
diff --git a/lua/neo-tree/defaults.lua b/lua/neo-tree/defaults.lua
index 733dcc0..1e5f278 100644
--- a/lua/neo-tree/defaults.lua
+++ b/lua/neo-tree/defaults.lua
@@ -28,7 +28,7 @@ local config = {
                        -- Anything before this will be used. The last items to be processed are the untracked files.
   },
   hide_root_node = false, -- Hide the root node.
-  retain_hidden_root_indent = false, -- IF the root node is hidden, keep the indentation anyhow.
+  retain_hidden_root_indent = false, -- IF the root node is hidden, keep the indentation anyhow.
                                      -- This is needed if you use expanders because they render in the indent.
   log_level = "info", -- "trace", "debug", "info", "warn", "error", "fatal"
   log_to_file = false, -- true, false, "/path/to/file.log", use :NeoTreeLogs to show the file
@@ -211,8 +211,8 @@ local config = {
     },
     name = {
       trailing_slash = false,
-      highlight_opened_files = false, -- Requires `enable_opened_markers = true`.
-                                      -- Take values in { false (no highlight), true (only loaded),
+      highlight_opened_files = false, -- Requires `enable_opened_markers = true`.
+                                      -- Take values in { false (no highlight), true (only loaded),
                                       -- "all" (both loaded and unloaded)}. For more information,
                                       -- see the `show_unloaded` config of the `buffers` source.
       use_git_status_colors = true,
@@ -368,8 +368,8 @@ local config = {
       -- ["<cr>"] = { "open", config = { expand_nested_files = true } }, -- expand nested file takes precedence
       ["<esc>"] = "cancel", -- close preview or floating neo-tree window
       ["P"] = { "toggle_preview", config = { use_float = true, use_image_nvim = false } },
-      ["<C-f>"] = { "scroll_preview", config = {direction = -10} },
-      ["<C-b>"] = { "scroll_preview", config = {direction = 10} },
+      -- ["<C-f>"] = { "scroll_preview", config = {direction = -10} },
+      -- ["<C-b>"] = { "scroll_preview", config = {direction = 10} },
       ["l"] = "focus_preview",
       ["S"] = "open_split",
       -- ["S"] = "split_with_window_picker",

Was hit by this myself. Kept trying to figure out why my <C-b> toggle mapping would open the browser window and then wouldn't close it again. Debugging :map shows it is being set by neo-tree.
Is there any way to override this without having to wait for a PR with a fix?

you can use 3.25 version

So a couple things here.
<C-b> isn't useless, the patch you applied tells you exactly what its doing. Its bound to the scroll_preview function. Specifically "scroll down" (that is why the direction is negative). Notice that the other part of your patch is removing the "scroll up" functionality of scroll_preview
Your "patch" is simply commenting out this behavior. Which I mean... Does work but is not how you solve this "problem".
If you don't like the behavior here, you can just set <C-b> to noop, or bind <C-b> to whatever functionality you want it to be. There is no need to apply a patch against the source code.
This is actually called out in the helpdoc as well.
Try that out and see if it works for you.
A final note. This is not a bug

yes, you're right.  scroll down, and  scroll up. This is not a bug. But it's possible only map these key when preview is visible?

That's a great question that I do not have an answer for. I will have to dig about a bit in the code to see if there is a way to bind the keymap only during previews.
That said, that does seem counterintuive, what would you expect to happen if you bind <C-b> to something and then both that thing and the preview are available at the same time?
I would recommend simply remapping as suggested or using a different shortcut for what you are looking for. Optional binding seems like a big mess (though it is worth checking the source to see if that is currently available)


Wrong redirect URLs being shown

In cases where server rewrites are not being used the 'Allowed Redirect URLs' are not valid. Merchants without rewrites will have to white list URLs like so (note the added index.php):
https://www.example.com/index.php/amazon_payments/checkout/authorize/
Can we somehow detect if they are using rewrites (I assume for SEO reasons) and display the correct URLs?

Added detection for mod_rewrite (if not enabled, will add index.php). Also fixed URLs based on current store view scope. (1.4 branch.)


HOWTO decode a serialized protobuf (in C) within Rust (prost crate)?

Greetings,
We attempt to do the following:

serialize proto message (google/protobuf/struct.proto) in C
pass the serialized message to Rust via FFI
deserialize from Rust (via proto::Message::merge)

However, this throws an exception: "buffer underflow.
What is the best way to achieve this?
Humbly thank everyone in advance!
C:
...
std::string serialized__protobuf__plugin__configuration;
        protobuf__plugin__configuration->SerializeToString(&serialized__protobuf__plugin__configuration);

        auto* plugin = Rust__plugin__input__http_poller__constructor(serialized__protobuf__plugin__configuration.c_str());  // Beware of memory leak here !!!
...

Rust:
#[no_mangle]
pub unsafe fn Rust__plugin__input__http_poller__constructor(serialized__protobuf__plugin__configuration: *const ::libc::c_char) -> *mut SofiaPlugin__input__http_poller {
    let mut ctx: Box<context::Context> = context::Background();

    let serialized__protobuf__plugin__configuration: &str = match ::std::ffi::CStr::from_ptr(serialized__protobuf__plugin__configuration).to_str() {
        Err(_) => return ::std::ptr::null_mut(),
        Ok(serialized__protobuf__plugin__configuration) => serialized__protobuf__plugin__configuration,
    };

    info!("[constructor] serialized__protobuf__plugin__configuration: {}", serialized__protobuf__plugin__configuration);

    let buffer: &[u8] = serialized__protobuf__plugin__configuration.as_bytes();

    let mut protobuf__plugin__configuration: Box<::prost_types::Struct> = Box::new(Default::default());
    match protobuf__plugin__configuration.as_mut()
                                         .merge(serialized__protobuf__plugin__configuration.as_bytes())
    {
        Ok(protobuf__plugin__configuration) => { info!("[OK] protobuf__plugin__configuration - {:#?}", protobuf__plugin__configuration); },
        Err(err) => { info!("[SHIT] err -{:#?}", err)},
    }
    ... ... ...

Greetings again!
Let me answer my own question above.
It turns out that the serialized protobuf contains a lot of '\0', which obviously would mess up your C-string.
(To confirm, you can verify using your-cxx-string.size() with std::strlen(your-c-string))
The following code would then circumvent this situation...
#[no_mangle]
pub unsafe fn Rust__plugin__input__http_poller__constructor(serialized__protobuf__plugin__configuration: *const u8,
                                                            sizeof__serialized__protobuf__plugin__configuration: usize)
        -> *mut SofiaPlugin__input__http_poller
{
    let serialized__protobuf__plugin__configuration: &[u8] = ::std::slice::from_raw_parts(serialized__protobuf__plugin__configuration,
                                                                                sizeof__serialized__protobuf__plugin__configuration);

    let protobuf__plugin__configuration: ::prost_types::Struct = match ::prost_types::Struct::decode(serialized__protobuf__plugin__configuration) {
        Err(_) => return ::std::ptr::null_mut(),
        Ok(protobuf__plugin__configuration) => protobuf__plugin__configuration,
    };

    ... ...

You would then see that Prost (Rust) desearializing your C-serialized protocol-buffers correctly!
Cheers!
Tama MA

@tamama I am glad to see you solved your own issue. Please close the issue when you have no further questions.


NextJS initial Build

Signed-off-by: Jan Lauber<EMAIL_ADDRESS>

First Dashboard look and feel


add GUI API

basically we want a GUI API...
you can create GUIs and click around through them and they do actions and stuff
related:
we already have an API for doing actions when people right click on items? maybe expand upon this? unsure if this pattern is good or not... but we want players to be able to right click items and it opens an inventory GUI where players can click on items to use their points, etc
https://github.com/andrewgazelka/hyperion/blob/0bf0af78a0cfdb2277fa6a76ffcfffa39e7cb97f/crates/hyperion-item/src/builder.rs#L153-L162
https://github.com/andrewgazelka/hyperion/blob/5400609658bf051dc842c2d159ab8556a1e27c5c/crates/hyperion-rank-tree/src/lib.rs#L69-L76

this issue is done as well. unless something else is needed


Add missing JSDoc tags

Thank! Please merge.

Travis says you missed one.

Thanks for the review


Issue Title:   Merge Main Branch into All Other Branches to Prevent Conflicts

Describe the Bug
When trying to merge changes from the main branch into other branches, conflicts may arise. This is because all branches are different from the main branch, and they might have diverged significantly.

To Reproduce
Steps to reproduce the behavior:

Switch to any branch other than main.
Attempt to merge the main branch into the current branch.
Observe whether any merge conflicts appear during the process.

Expected Behavior
The merge should complete successfully, or if conflicts arise, they should be identified and resolved properly to maintain consistency between branches.

Screenshots
If applicable, add screenshots of the conflict messages or merge errors.

Desktop (please complete the following information):

OS: Ubuntu 22.04
Browser: N/A
Version: N/A

Smartphone (please complete the following information):

Device: N/A
OS: N/A
Browser: N/A
Version: N/A

Additional Context

The purpose of merging the main branch into all other branches is to synchronize changes and prevent future conflicts.
Ensure that each branch is properly tested after the merge to verify nothing is broken.

Hello @pranaydarmapuri ,
Please give me call tomorrow and let's discuss about the issue. How you can address this issue and resolve it
Thank you

I have followed up and updated all branches


[type: refactor] fix upgrade: rename plugin.

Codecov Report

Merging #2294 (4e4482c) into master (cb3f229) will decrease coverage by 0.23%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #2294      +/-   ##
============================================
- Coverage     58.43%   58.20%   -0.24%
+ Complexity     3972     3961      -11
============================================
  Files           626      626
  Lines         18056    18053       -3
  Branches       1711     1709       -2
============================================
- Hits          10551    10507      -44
- Misses         6644     6685      +41
  Partials        861      861

Impacted Files
Coverage Δ

...ache/shenyu/plugin/grpc/cache/GrpcClientCache.java
64.70% <0.00%> (-29.42%)
:arrow_down:

...henyu/plugin/grpc/resolver/ShenyuNameResolver.java
50.52% <0.00%> (-13.69%)
:arrow_down:

...che/shenyu/sync/data/http/HttpSyncDataService.java
63.10% <0.00%> (-11.66%)
:arrow_down:

...a/org/apache/shenyu/common/utils/VersionUtils.java
67.85% <0.00%> (-10.72%)
:arrow_down:

...henyu/admin/service/impl/UpstreamCheckService.java
23.57% <0.00%> (-4.07%)
:arrow_down:

...yu/plugin/grpc/resolver/ShenyuServiceInstance.java
96.42% <0.00%> (-3.58%)
:arrow_down:

...henyu/plugin/httpclient/NettyHttpClientPlugin.java
58.00% <0.00%> (-2.00%)
:arrow_down:

...che/shenyu/admin/model/vo/SelectorConditionVO.java
96.07% <0.00%> (-1.97%)
:arrow_down:

...elimiter/handler/RateLimiterPluginDataHandler.java
69.69% <0.00%> (-1.52%)
:arrow_down:

...rg/apache/shenyu/plugin/hystrix/HystrixPlugin.java
74.07% <0.00%> (-0.93%)
:arrow_down:

... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb3f229...4e4482c. Read the comment docs.


⚠ Bofrost.lu has degraded performance

In 638d87f, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2372 ms

Resolved: Bofrost.lu performance has improved in a624333 after 38 minutes.


SoS Joystick game integration

Make a translation layer that converts SoS buttons (Confirm, Graplou, etc.) to abstract joystick crate buttons.

[x] Create SoS-actions interface
[x] Map actions to buttons
[ ] Load mappings from file (in case button mappings have been changed in game)
[x] Write tests verifying the SoS actions

Note that there are potentially multiple mappings depending on context.

In #47 I try to implement something that can get us the action interface and mapping. It doesn't implement loading a mapping from file yet. The tests verify that the mappings work.
The way it would work in the game would be that we would have a single hashmap with all the actions, and map them to buttons. Multiple actions could map to the same button (for example, Action::MenuConfirm and Action::Interact could both refer to Button::A).

#47 is merged. Tasks remaining is to create the actual mappings for SoS (should be in the main crate rather than joystick crate), and possibly adding read-from-yaml to create the mapping HashMap.

#50 changes interface slightly, to not use HashMap internally. For configurable button mapping, the Action type needs to implement Into<Button>. There would have to be some kind of load from file around there.

I made an attempt at implementing this, but it seems like the new revision above makes it difficult to add mappings.
I don't think we should support this for now and instead just recommend default bindings for the tas.


Win10/11 Multi-Session Support - Clarification required

Please clarify in this article the support for Windows 10/11 multi-session.
As mentioned in the below article Win10/11 multi-session should be considered a separate OS edition, so it should be made clear what scenario's are and aren't support for multi-session.
https://docs.microsoft.com/en-us/mem/intune/fundamentals/azure-virtual-desktop-multi-session
[Enter feedback here]

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: f31e7b39-b7c3-188a-0b2a-02ff10a5be6d
Version Independent ID: 44940a13-0a2d-e281-560b-cb4d8a5d1ccf
Content: Protect security settings with tamper protection
Content Source: microsoft-365/security/defender-endpoint/prevent-changes-to-security-settings-with-tamper-protection.md
Product: m365-security
Technology: mde
GitHub Login: @denisebmsft
Microsoft Alias: deniseb

@RichardvanNuland Thank you for your feedback. I have made changes via PR#https://github.com/MicrosoftDocs/microsoft-365-docs/pull/7200
Once the Author approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @RichardvanNuland Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Hi,
Apologies, but I don't believe this update addresses the issue fully.
For example microsoft-365-docs/prevent-changes-to-security-settings-with-tamper-protection.md at public * MicrosoftDocs/microsoft-365-docs (github.com)https://github.com/MicrosoftDocs/microsoft-365-docs/blob/public/microsoft-365/security/defender-endpoint/prevent-changes-to-security-settings-with-tamper-protection.md#requirements-for-managing-tamper-protection-in-the-microsoft-365-defender-portal now still shows this only applies to Win10 / Win11 without mentioning Win10/11 multi-session. That makes it still very unclear what options you have to enable Tamper Protection on Win10/11 multi-session.
This is just one example, all sections in this article should make clear if that section applies to Win10/11 multi-session.
Regards,
Richard
From: Yogesh Kumar @.>
Sent: maandag 20 december 2021 05:24
To: MicrosoftDocs/microsoft-365-docs @.>
Cc: Nuland van, R (Richard) @.>; Mention @.>
Subject: Re: [MicrosoftDocs/microsoft-365-docs] Win10/11 Multi-Session Support - Clarification required (Issue #7147)
@msbembahttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmsbemba&data=04|01|Richard.van.Nuland%40rabobank.com|874a8a4f096f4c58768008d9c3708853|6e93a6268aca4dc19191ce291b4b75a1|0|0|637755710354308115|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=9e4z36zJcTxZZU8Dw%2BAUHeEvp5ALXG1S4OySs8Vb7MQ%3D&reserved=0 Thank you very much for the contribution and updating the documentation with PR. @RichardvanNulandhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FRichardvanNuland&data=04|01|Richard.van.Nuland%40rabobank.com|874a8a4f096f4c58768008d9c3708853|6e93a6268aca4dc19191ce291b4b75a1|0|0|637755710354308115|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=AzXcpDzHhuO3CFQPEtesHGNbNclYT8j4zZ18wNMp9zA%3D&reserved=0 Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.

Reply to this email directly, view it on GitHubhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMicrosoftDocs%2Fmicrosoft-365-docs%2Fissues%2F7147%23issuecomment-997584273&data=04|01|Richard.van.Nuland%40rabobank.com|874a8a4f096f4c58768008d9c3708853|6e93a6268aca4dc19191ce291b4b75a1|0|0|637755710354308115|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=ru1CubAFBXnytIQ1AMNmGl7SCWzoN%2FYEF8fJTcIMo5I%3D&reserved=0, or unsubscribehttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMAQWVWX33U5HW4DKJMER63UR2VVTANCNFSM5JYP5LCQ&data=04|01|Richard.van.Nuland%40rabobank.com|874a8a4f096f4c58768008d9c3708853|6e93a6268aca4dc19191ce291b4b75a1|0|0|637755710354308115|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=V1XMT%2F9N59FyjtO2a8u2R4X6NoKSnN649nxZbt5Dg%2B4%3D&reserved=0.
Triage notifications on the go with GitHub Mobile for iOShttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fapps.apple.com%2Fapp%2Fapple-store%2Fid1477376905%3Fct%3Dnotification-email%26mt%3D8%26pt%3D524675&data=04|01|Richard.van.Nuland%40rabobank.com|874a8a4f096f4c58768008d9c3708853|6e93a6268aca4dc19191ce291b4b75a1|0|0|637755710354308115|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=EqyAhiN%2FcJtKwV%2BUcECIqnlYVxPOryb%2BuokjN28he4A%3D&reserved=0 or Androidhttps://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fplay.google.com%2Fstore%2Fapps%2Fdetails%3Fid%3Dcom.github.android%26referrer%3Dutm_campaign%253Dnotification-email%2526utm_medium%253Demail%2526utm_source%253Dgithub&data=04|01|Richard.van.Nuland%40rabobank.com|874a8a4f096f4c58768008d9c3708853|6e93a6268aca4dc19191ce291b4b75a1|0|0|637755710354308115|Unknown|TWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D|3000&sdata=KCic1lxXrPALwU2h2PFbZJV%2BH23z3IsniWbBKKpCwXU%3D&reserved=0.
You are receiving this because you were mentioned.Message ID<EMAIL_ADDRESS>
This email (including any attachments to it) is confidential, legally privileged, subject to copyright and is sent for the personal attention of the intended recipient only. If you have received this email in error, please advise us immediately and delete it. You are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited. Although we have taken reasonable precautions to ensure no viruses are present in this email, we cannot accept responsibility for any loss or damage arising from the viruses in this email or attachments. We exclude any liability for the content of this email, or for the consequences of any actions taken on the basis of the information provided in this email or its attachments, unless that information is subsequently confirmed in writing. <#rbnl#1898i>

@msbemba

@RichardvanNuland I have made some additional changes via PRhttps://github.com/MicrosoftDocs/microsoft-365-docs/pull/7248
Once the author verifies and approves, the changes will be live.
Thanks
Sri

@msbemba Thank you very much for the contribution and updating the documentation with PR. @RichardvanNuland Hope this update is helpful for you. Thanks for taking out some time to open the issue. Appreciate and encourage you to do the same in future also.


gnu(8820)=672

GAP      e403849e47a7bdf008c9406a15912559fe2e9f8c
GrpConst 2.5
Runtime: 63168 ms
Isomorphic groups eliminated

Whups. This is already known from the smallgroups library. I don't know how this ended up in my queue.

This is known: try
gap> Gnu(8820);
672

or
gap> GnuExplained(8820);
[ 672, "using NrSmallGroups and the GAP Small Groups Library" ]

It is cube-free, and Small Group Library has all groups of cubefree order n<50 000.

Looked a bit more on this:
gap> Factors(8820);
[ 2, 2, 3, 3, 5, 7, 7 ]
gap> NumberCFGroups(8820);time;
672
1
gap> NumberCFGroups(8820,false);time;
672
14223

So the number in the small groups library agrees with the number produced by ConstructAllGroups and (in the last calculation) with the number calculated using the cubefree package. Hence I've added the "reproduced" label.
Even more consistency checks for groups of cubefree orders could be performed with CubefreeTestOrder from the cubefree package:
gap> CubefreeTestOrder(8820);
true
gap> time;
132955


Fix the potential double delegate call per request

We've been facing a situation when both requestDidTimeout and didReceiveResponse were called for a single request. This might result in a crash when used e.g. with DispatchGroups to wait for the request completion.

@mbarnach @0xKayvan take a look at this PR, please


Allied Vision camera first read always fails

Describe the bug
After connecting to the camera (creating an ImageAcquirer), the first access always fails, no matter what it is. Subsequent io works, whether it is the same request or something else.
To Reproduce
Using an Allied Vision ALVIUM camera:
from harvesters.core import Harvester

h = Harvester()
h.add_file('/opt/mvIMPACT_Acquire/lib/x86_64/mvGenTLProducer.cti')
h.update()
ia = h.create_image_acquirer(0)
print(ia.remote_device.node_map.DeviceSerialNumber.value)

Expected behavior
The serial number should be printed
Observed Behavior
A GenTL io exception is raised:
Traceback (most recent call last):
  File "../test-harvesters.py", line 11, in <module>
    ia.remote_device.node_map.DeviceSerialNumber.value
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/genapi.py", line 2676, in _get_value
    return self._primal_get_value()
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/genapi.py", line 2652, in _primal_get_value
    return _genapi.IString__primal_get_value(self, Verify, IgnoreCache)
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/harvesters/_private/core/port.py", line 57, in read
    buffer = self.port.read(address, length)
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/gentl.py", line 5003, in read
    return _gentl.Port_read(self, address, buffer)
_gentl.IoException: GenTL exception: Communication error, read or write to remote device failed. (Message from the source: Could not read data from 0x144(64 bytes). System error: 0x00000000, bytes received: 0) (ID: -1010)

Desktop

OS: Ubuntu 18.04
Python: 3.7.6
Harvester: 1.2.0
GenTL Producer: mvImpact-Acquire
Camera: Allied Vision Alvium

Additional context

All subsequent camera io works, whether the same address or different addresses:
>>> from harvesters.core import Harvester
>>> h = Harvester()
>>> h.add_file('/opt/mvIMPACT_Acquire/lib/x86_64/mvGenTLProducer.cti')
>>> h.update()
>>> ia = h.create_image_acquirer(0)
>>> ia.remote_device.node_map.DeviceSerialNumber
<genicam.genapi.IString; proxy of <Swig Object of type 'GENAPI_NAMESPACE::IString *' at 0x7f4e515d0210> >
>>> ia.remote_device.node_map.DeviceSerialNumber.value
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/genapi.py", line 2676, in _get_value
    return self._primal_get_value()
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/genapi.py", line 2652, in _primal_get_value
    return _genapi.IString__primal_get_value(self, Verify, IgnoreCache)
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/harvesters/_private/core/port.py", line 57, in read
    buffer = self.port.read(address, length)
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/gentl.py", line 5003, in read
    return _gentl.Port_read(self, address, buffer)
_gentl.IoException: GenTL exception: Communication error, read or write to remote device failed. (Message from the source: Could not read data from 0x144(64 bytes). System error: 0x00000000, bytes received: 0) (ID: -1010)
>>> ia.remote_device.node_map.DeviceSerialNumber.value
'003G0'
>>> ia.remote_device.node_map.DeviceVendorName.value
'Allied Vision'

The first camera io fails, whatever it is. So DeviceVendorName.value, Height.get_access_mode(), or ia.start_acquisition will trigger the io error, if it is the first attempted io (but then everything will work afterwards). Note that the second start_acquisition call works.
>>> from harvesters.core import Harvester
>>> h = Harvester()
>>> h.add_file('/opt/mvIMPACT_Acquire/lib/x86_64/mvGenTLProducer.cti')
>>> h.update()
>>> ia = h.create_image_acquirer(0)
>>> ia.start_acquisition()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/harvesters/core.py", line 2298, in start_acquisition
    buffer_size = self.remote_device.node_map.PayloadSize.value
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/genapi.py", line 2357, in _get_value
    return self._primal_get_value()
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/genapi.py", line 2273, in _primal_get_value
    return _genapi.IInteger__primal_get_value(self, Verify, IgnoreCache)
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/harvesters/_private/core/port.py", line 57, in read
    buffer = self.port.read(address, length)
  File "/home/jmilloy/miniconda3/envs/lmt/lib/python3.7/site-packages/genicam/gentl.py", line 5003, in read
    return _gentl.Port_read(self, address, buffer)
_gentl.IoException: GenTL exception: Communication error, read or write to remote device failed. (Message from the source: Could not read data from 0x20008(8 bytes). System error: 0x00000000, bytes received: 0) (ID: -1010)
>>> ia.start_acquisition()
>>> ia.is_aquiring()
True

Identical code for the FLIR BlackFly cameras does not have this problem. Those are the only two cameras I have here to test with.

Is there just one more initialization step that I am missing?

@jmilloy Hi, thank you for trying out Harvester. As far as I hear the symptom, I do not see any issue in your usage of Harvester. So I would suggest you the following idea: If you are involving cameras from several manufacturers, then try another version of MV's GenTL Producer. They have a website where you can download any version that they have released. Perhaps older versions do not reproduce the phenomenon but in general, they produce great software so I would not think they easily regress. However, sometimes it's cumbersome to tame USB3 host controllers or USB3 Vision devices/cameras in the transport layer level. Perhaps your host controller could be exposing an issue that MV has. If so, I would encourage you to report the issue to MV as a user; it's not bad deal, you use their software for free and they get an exposed issue that should be fixed. /Kazunari

Ok, after some more testing, I can see that I have errors independent of harvesters. VimbaViewer can enumerate, connect, and configure, but not acquire; mvDeviceConfigure can enumerate and connect, but not configure or acquire; harvesters with the vimba cti file can enumerate, configure, and acquire, but can't connect using the serial number; and harvesters with the mv cti file can enumerate and connect, but is unstable (different errors at different times). I'll keep digging, but it seems that harvesters is not the problem. Thanks!

Maybe this helps: I was using an Allied Vision camera sucessfully with the Matrix Vision GenTL producer
(IIRC I installed mvGenTL_Acquire-x86_64-2.37.1.exe from http://static.matrix-vision.com/mvIMPACT_Acquire/)

@StefanD986 Yeah, that's what I'm using originally, but then I also tested the vendor producer and even the vendor GUI and still had problems. I'm going to try everything on Windows instead of Ubuntu Linux today.

Closing. Please feel free to re-open this when you get a clue the issue is caused by Harvester.


Measure and document app size impact

There have been several requests to measure and document the app size increases of flutter_eval, e.g. https://github.com/flutter/flutter/issues/14330#issuecomment-1228095445. This data should also be periodically updated once added.

Done in https://github.com/ethanblake4/flutter_eval/commit/0d219e33c07b66e12c6d427e5e615e7875ef5f4b


Empty function

https://github.com/hashgraph/guardian/blob/94d689982cf3b50e24b3d2810b317bc75f76ecb1/mrv-sender/public/script.js#L3

For these (and similar situations) not to occur, please apply linting rules and linting pre-checks on git deployment/CI.


Prevent NullPointerException when using generated schemas

The current implementation of SchemaInfo sets the schema data to null by default, which gives me this exception:
java.lang.NullPointerException:
   at org.apache.pulsar.shaded.com.google.protobuf.v241.ByteString.copyFrom(ByteString.java:99)
   at org.apache.pulsar.common.api.Commands.getSchema(Commands.java:491)
   at org.apache.pulsar.common.api.Commands.newProducer(Commands.java:520)
   at org.apache.pulsar.client.impl.ProducerImpl.connectionOpened(ProducerImpl.java:915)
   at org.apache.pulsar.client.impl.ConnectionHandler.lambda$grabCnx$0(ConnectionHandler.java:65)
   at java.util.concurrent.CompletableFuture.uniAccept(CompletableFuture.java:656)
   at java.util.concurrent.CompletableFuture$UniAccept.tryFire(CompletableFuture.java:632)
   at java.util.concurrent.CompletableFuture.postComplete(CompletableFuture.java:474)
   at java.util.concurrent.CompletableFuture.complete(CompletableFuture.java:1962)
   at org.apache.pulsar.client.impl.BinaryProtoLookupService.lambda$null$2(BinaryProtoLookupService.java:136)

I'm pretty sure it's up to our schema to decide how to use (or not use) this field, so it's not a great API, but it seems reasonable to work around by putting a dummy value there.

Good idea.


[v1.20] unable to close collection - an error occurred while closing collection

I have checked the following:

[X] I use the newest version of bruno.
[X] I've searched existing issues and found nothing related to my issue.

Describe the bug
Try to delete a collection

an error occurred
no console errors

electron | : 21.1.1
chrome | : 106.0.5249.103
node | : 16.16.0
v8 | : <IP_ADDRESS>-electron.0
os x: 12.2.1
macbook air m1 2020, macbook pro m1 2021
.bru file to reproduce the bug
No response
Screenshots/Live demo link
Best I can do as there's no other debugging information. This also happens with fresh collections.
https://github.com/usebruno/bruno/assets/1226920/ede96772-3a8f-4284-a0a4-b168577111f6
https://github.com/usebruno/bruno/assets/1226920/798920ae-08cb-4ea2-8ca4-251c52f06689

I just tested this by cloning Bruno and worked fine so maybe issue was fixed in a recent commit.

I just tested this by cloning Bruno and worked fine so maybe issue was fixed in a recent commit.

The released version of Bruno includes the proprietary "Golden Edition" code and is not the same as the publicly available source code. Previous versions also had some bugs that were not present in the public source, like the code generator not working.

Thank you for taking the time to report the issue, @darylteo. We merge the open-source Bruno with the proprietary closed-source code. Changes in the closed-source code caused the bug, but it has been fixed. You can expect the fix in the next patch release.

I'll keep that in mind in the future, thank you.


Added no subscription support

This PR includes the support to allow az login with --allow-no-subscription flag.With this the action can also support az login for SPNs created at a Management group level scope

Add an L0 as well

Add an L0 as well

Yes, please add an L0.

Add an L0 as well

Yes, please add an L0.

Done

@aksm-ms Can you please review and approve this PR? We have to move this to production quickly to support one of our critical flows.Thanks!
cc: @ammohant @ds-ms

@Ganeshrockz , if the service principal in question has access over a subscription (read or higher) in addition to any other access it needs to execute your use case, you would still be able to run the action as is and achieve your use case.
As for this change, if a subscription id isn't passed in and we continue ahead with the login, then a subsequent action like web app deploy or sql deploy will fail (because, after all, we did not specify a subscription at login time). This will make it harder to use most of the typical actions. @N-Usha @aksm-ms and I discussed how we can support such scenarios and came to the conclusion that we will need to come up with a more detailed spec before we can commit to anything here.

@arjgupta What do you recommend for logging into an azure context with a management scope alone then?
Given that subscriptionId is kind of mandatory in the current state of action, I'll have to do an extra role-binding to some subscription so that the login works for me, right?

I disagree with this, --allow-no-subscriptions is not a default. It's conditional based on the inputs, right? If the user consciously wants to use their SPN without binding it to any subscription, we should let them right?

@ds-ms Yes, --allow-no-subscription is not a default at login action level.  Lets take an example of Azure Mysql.
Azure Mysql action currently needs subscriptionId to call some ARM APIs. If a user is able to login using a service principal with management scope and his mysql action fails, it means that we are supporting a backward compatible feature in login but not across the end to end flow for all other azure actions.
I have created a SP at management scope and tried the changes in this PR with Azure Mysql action, it failed. Please find the logs:
Workflow:

Logs:

Yes, --allow-no-subscription is not a default at login action level. Lets take an example of Azure Mysql.
Azure Mysql action currently needs subscriptionId to call some ARM APIs. If a user is able to login using a service principal with management scope and his mysql action fails, it means that we are supporting a backward compatible feature in login but not across the end to end flow for all other azure actions.

That means the user consciously changed things. The mysql action failed because you, as a user, haven't provided a subscription id in your Azure CREDS, so we didn't even set a subscription context. I feel that this expectation is fair.

That means the user consciously changed things. The mysql action failed because you, as a user, haven't provided a subscription id in your Azure CREDS, so we didn't even set a subscription context. I feel that this expectation is fair.
@N-Usha Please provide your inputs

That means the user consciously changed things. The mysql action failed because you, as a user, haven't provided a subscription id in your Azure CREDS, so we didn't even set a subscription context. I feel that this expectation is fair.

User may have consciously or unconsciously omitted the subscription ID in the Creds w/o expecting the consequences that most of the other actions would fail. In most enterprises, SPNs are created by IT admins and are passed on to the developers who may or may not understand the scope of the SPN until they actually use it.  My main concern here is that the error messages thrown by the failing actions are not meaningful or actionable to let the user know how the user could fix the error. And fixing the error messages across all existing actions is simply unscalable.
And hence we believe that we need to make it more explicit an action from user than simply omitting the subscription ID from SPN JSOn object. Potentially by including a new input parameter in the action.yml for login action called "scope" which by default takes "subscription scope". User would then need to explicitly change its value to "Management Scope" and can then omit the subscription ID from SPN. However we also need to understand what is needed for supporting rest of the scopes like RG or resource aswell. Which is why we need to spec this comprehensively before making any changes.

As discussed in the meeting today,

We will add a new input allow-no-subscriptions which will take boolean values. By default the value will be false.  Whenever it is true, the action will pass this flag while logging into Azure.
This will be a minor update to the action version.
@ds-ms @Ganeshrockz to update the PR accordingly.

@arjgupta / @asranja / @aksm-ms  I have made the changes as discussed. Please review the PR
cc: @ds-ms @raiyanalam

LGTM. @arjgupta please take a look.


chore(build): fix build on macOS by using rlp by value

Purpose
taraxa-node/src/consensus/pbft_chain.cpp:119:20: error: loop variable 'dag_block_rlp' binds to a temporary value produced by a range of type 'dev::RLP' [-Werror,-Wrange-loop-bind-reference]
  for (auto const& dag_block_rlp : *it++) {
                   ^
taraxa-node/src/consensus/pbft_chain.cpp:119:8: note: use non-reference type 'dev::RLP'
  for (auto const& dag_block_rlp : *it++) {

prnet cleaned-up successfully


Set change color by susnset

Check out astral. Here's a slightly modified example from their docs:
>>> from astral import Astral
>>> city_name = 'London'
>>> a = Astral()
>>> a.solar_depression = 'civil'
>>> city = a[city_name]
>>> sun = city.sun(date=datetime.date(2009, 4, 22), local=True)

>>> if (sun['sunrise'] < T < sun['sunset']) and (light < threshold):
>>>    notifyUser()

If you use something like this example, please remember to change the city_name and date provided to city.sun.

Done by d2e059a.


Added typing information for pc.Asset's type property

Enhancement: Add typing info for the type of pc.Assets
In addition to the documented types, 'template' is now a valid string too from what I see when looking at a template asset's type value.

Update - possibly this is a bit more nuanced than I first thought; there were a few types (sprite, template, container) that were not documented in the text. Poking a bit into the editor revealed a longer list than I realised:
0: "animation"
1: "animstategraph"
2: "audio"
3: "bundle"
4: "binary"
5: "container"
6: "cubemap"
7: "css"
8: "font"
9: "folder"
10: "json"
11: "html"
12: "material"
13: "model"
14: "render"
15: "scene"
16: "script"
17: "shader"
18: "sprite"
19: "template"
20: "text"
21: "texture"
22: "textureAtlas"
23: "wasm"

I'm not sure which of these Playcanvas would deem internal/undocumented though. So this PR contains ones we've been using in code when the type was just a string. Perhaps you would prefer to have this as a plain string, though it is useful for type-safety to know we're using the right values...?

I confirm I have signed the Contributor License Agreement.

Thanks!

No worries @willeastcott - just wanted to highlight that the list is probably incomplete from the 20+ that seem to be present in the editor, but wasn't sure if there was a more formal subset? Anyway, this gives us the types we're using today 👍


bump TibberLink stable to 1.4.2

Would be fine to get this earlier to stable, because of included fix for axios vulnerability

1.4.2 created 03.11.2023
OK


MKL is not enabled after building from source

System information

OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 18.04
Mobile device (e.g. iPhone 8, Pixel 2, Samsung Galaxy) if the issue happens on mobile device: NA
TensorFlow installed from (source or binary): source
TensorFlow version: 1.15
Python version: 3.6.8
Installed using virtualenv? pip? conda?:
Bazel version (if compiling from source): 0.26.1
GCC/Compiler version (if compiling from source): 7.4.0

Describe the problem
MKL is not enabled after building from source with -config=mkl. I have checked with the function tensorflow.pywrap_tensorflow.IsMklEnabled(). It returns "False".
Provide the exact sequence of commands / steps that you executed before running into the problem
I followed the installation guide on https://www.tensorflow.org/install/source. I build with:
bazel build -c opt --copt=-march=native --copt=-mfpmath=both --config=mkl //tensorflow/tools/pip_package:build_pip_package
How can I build correct with mkl enabled. Thank you in advance

TensorFlow version: 1.15
yes  "" | python configure.py
bazel build -c opt --copt=-march=native --copt=-mfpmath=both --config=mkl //tensorflow/tools/pip_package:build_pip_package

Test Code
import tensorflow
print(tensorflow.pywrap_tensorflow.IsMklEnabled())

which returns true.

@leslie-fang-intel Thanks, after several tries I finally built with MKL.


Fix interference with ReSharper extension. (#50)

This should fix #50. I couldn't completely build and test the extension, but manipulating while debugging worked okay.

Still seeing this issue, would be awesome if it could be resolved.

Just FYI: https://blog.jetbrains.com/dotnet/2018/04/09/stylecop-code-style-settings-inspections/ Maybe this is of interest.

I'll take a look, my current issue is with a separate third party service that I'd like to use that could make use of the standard StyleCop settings, and not resharpers. I can edit how it displays in visual studio, but without a proper StyleCop settings file my third party service will act differently.

@ThatOhio this is using the standard stylecop config.


Signature extraction failed

Checklist

[x] I'm reporting a broken site support issue
[x] I've verified that I'm running youtube-dl version 2021.06.06
[x] I've checked that all provided URLs are alive and playable in a browser
[x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
[x] I've searched the bugtracker for similar bug reports including closed ones
[x] I've read bugs section in FAQ

Verbose log

$ youtube-dl -f 18 --verbose https://www.youtube.com/watch?v=PgHiXkbvNZQ
[debug] System config: []
[debug] User config: ['--restrict-filenames', '-o', '~/Downloads/%(title)s.%(uploader)s.%(id)s.%(format_id)s-%(height)sp.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: ['-f', '18', '--verbose', 'https://www.youtube.com/watch?v=PgHiXkbvNZQ']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.5.3 (CPython) - Linux-4.9.0-16-686-pae-i686-with-debian-9.13
[debug] exe versions: ffmpeg N-96573-g73aab08d9d, ffprobe N-96573-g73aab08d9d, rtmpdump 2.4
[debug] Proxy map: {}
[youtube] PgHiXkbvNZQ: Downloading webpage
[youtube] PgHiXkbvNZQ: Downloading player 204bfffb
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1349, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1349, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1349, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1623, in _real_extract
    signature = self._decrypt_signature(sc['s'][0], video_id, player_url)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1359, in _decrypt_signature
    'Signature extraction failed: ' + tb, cause=e)
youtube_dl.utils.ExtractorError: Signature extraction failed: Traceback (most recent call last):
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1349, in _decrypt_signature
    video_id, player_url, s
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "/usr/local/bin/youtube-dl/youtube_dl/extractor/youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "/usr/local/bin/youtube-dl/youtube_dl/jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.",)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type  youtube-dl -U  to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Description

New error message not seen before, failing to work.

duplicate of https://github.com/ytdl-org/youtube-dl/issues/30363

Checklist

[X]  I'm reporting a broken site support issue
[X]  I've verified that I'm running youtube-dl version 2021.06.06
[X]  I've checked that all provided URLs are alive and playable in a browser
[X]  I've checked that all URLs and arguments with special characters are properly quoted or escaped
[X]  I've searched the bugtracker for similar bug reports including closed ones
[X]  I've read bugs section in FAQ

Verbose Log
C:\Users\jvu90\Music>youtube-dl -f bestaudio -x --audio-format mp3 --audio-quality 0 -o "/Jack Stauber - Pop Food/%(playlist_index)s%(title)s.%(ext)s" https://www.youtube.com/playlist?list=OLAK5uy_nkGfAD3M3C_N5qmIsHzTe2hoXD0vepSIQ  --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', 'bestaudio', '-x', '--audio-format', 'mp3', '--audio-quality', '0', '-o', '/Jack Stauber - Pop Food/%(playlist_index)s%(title)s.%(ext)s', 'https://www.youtube.com/playlist?list=OLAK5uy_nkGfAD3M3C_N5qmIsHzTe2hoXD0vepSIQ', '--verbose']
[debug] Encodings: locale cp1252, fs utf-8, out utf-8, pref cp1252
[debug] youtube-dl version 2021.06.06
[debug] Python version 3.9.9 (CPython) - Windows-10-10.0.19044-SP0
[debug] exe versions: ffmpeg 2021-09-11-git-3e127b595a-full_build-www.gyan.dev, ffprobe 2021-09-11-git-3e127b595a-full_build-www.gyan.dev
[debug] Proxy map: {}
[youtube:tab] OLAK5uy_nkGfAD3M3C_N5qmIsHzTe2hoXD0vepSIQ: Downloading webpage
[download] Downloading playlist: Pop Food
[youtube:tab] playlist Pop Food: Downloading 11 videos
[download] Downloading video 1 of 11
[youtube] e2qG5uwDCW4: Downloading webpage
[youtube] e2qG5uwDCW4: Downloading player 204bfffb
ERROR: Signature extraction failed: Traceback (most recent call last):
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1348, in _decrypt_signature
    func = self._extract_signature_function(
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.")); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1348, in _decrypt_signature
    func = self._extract_signature_function(
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1348, in _decrypt_signature
    func = self._extract_signature_function(
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\YoutubeDL.py", line 815, in wrapper
    return func(self, *args, **kwargs)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\YoutubeDL.py", line 836, in __extract_info
    ie_result = ie.extract(url)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\common.py", line 534, in extract
    ie_result = self._real_extract(url)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1623, in _real_extract
    signature = self._decrypt_signature(sc['s'][0], video_id, player_url)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1358, in _decrypt_signature
    raise ExtractorError(
youtube_dl.utils.ExtractorError: Signature extraction failed: Traceback (most recent call last):
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1348, in _decrypt_signature
    func = self._extract_signature_function(
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1262, in _extract_signature_function
    res = self._parse_sig_js(code)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\extractor\youtube.py", line 1331, in _parse_sig_js
    initial_function = jsi.extract_function(funcname)
  File "C:\Users\jvu90\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.9_qbz5n2kfra8p0\LocalCache\local-packages\Python39\site-packages\youtube_dl\jsinterp.py", line 245, in extract_function
    raise ExtractorError('Could not find JS function %r' % funcname)
youtube_dl.utils.ExtractorError: Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
 (caused by ExtractorError("Could not find JS function 'na'; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.")); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; see  https://yt-dl.org/update  on how to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.

Duplicate of #30363, with fix.


Restructuring OSC

This pull request includes the restructuring of the OSC importer code into a class, will be merged after proper testing.

I have merged this branch into the master, and at the same time divorced the supernova module into its own repo: https://github.com/astrocatalogs/supernovae


21 checkout add address

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 4 committers have signed the CLA.:white_check_mark: mass-gueye:x: zlorgoncho:x: dofbi:x: zlorgoncho1You have signed the CLA already but the status is still pending? Let us recheck it.

 Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.1 out of 4 committers have signed the CLA.:white_check_mark: mass-gueye:x: dofbi:x: zlorgoncho:x: zlorgoncho1You have signed the CLA already but the status is still pending? Let us recheck it.

I believe this was PR was not intentional


Prerequisites

[X] I have searched all issues/PRs to ensure it has not already been reported or fixed.

Criteria

[X] Reasonably well-known and widely used (e.g. if it's a GitHub project, it should have at least 100 stars and/or 50 forks)
[X] English interface (or at least English documentation)
[X] Latest stable version
[X] Full version (i.e. not a trial version)
[X] Fairly standard install (e.g. uses a version-specific download URL, no elaborate pre/post install scripts)

Name
ytdownloader
Description
A modern GUI App for downloading Videos and Audios from hundreds of sites
Homepage
https://ytdn.netlify.app
Download Link(s)
https://github.com/aandrew-me/ytDownloader/releases/latest
Some Indication of Popularity/Repute
Github URL: https://github.com/aandrew-me/ytDownloader
⭐Stars : 215+
https://www.softpedia.com/get/Internet/Download-Managers/YtDownloader.shtml

@aandrew-me Looks like you could easily raise PR with your version of manifest (looks good, only fix order of fields is recommended). But it's completely up to you, of course.


Install RBS on second content database

Hi there,
Today I have run out steps to install RBS on a second content database. Just notice on the note on this post saying that:
> [!NOTE]
> If you attempt to install SQL Server 2012 Remote Blob Store for an additional database on the same instance of SQL Server, you will receive an error. For more information, see KB2767183.
After receiving this error, copy and paste the following command into the Command Prompt window without the  /qn switch. This opens the RBS installer window where you can change only the database name and then follow the default options. You will then see the RBS tables are created in the second database.
msiexec  /lvx* rbs_install_log.txt /i RBS.msi TRUSTSERVERCERTIFICATE=true FILEGROUP=PRIMARY DBNAME="WSS_Content_RBS" DBINSTANCE="SQL2012SERVER" FILESTREAMFILEGROUP=RBSFilestreamProvider FILESTREAMSTORENAME=FilestreamProvider
I realized I have to remove the "DBNAME" parameter in this command in order to able to change the content database name in the installation wizard.
Appreciate if you can verify and correct the document (if I'm correct).
Best Regards

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 8c4bfb2a-e225-fad9-5970-ca30acf9d92d
Version Independent ID: 7cc3baec-8c7e-e5ee-cf16-812a4aa3c035
Content: Install and configure RBS with FILESTREAM in a SharePoint Server farm
Content Source: SharePoint/SharePointServer/administration/install-and-configure-rbs.md
Product: sharepoint-server-itpro
GitHub Login: @bentoncity
Microsoft Alias: stevhord

@mrdaipn Thank you for this feedback
I agree this should be verified and updated.
I was able to get this into the backlog for the SharePoint team. The team will get this prioritized into a sprint plan. Thank you for reporting and making the docs better. Much appreciated.
I made a note to request the team to update this when the work is complete.

@tseward is investigating this issue.


Run a test campaign before merging AMCBLDC_experimental and AMCLBDC

At the moment there are two projects that involve the AMCBLDC board, the official one and the Experimental one.
The Experimental project involves a major refactor of the supervisor and leverages the Common Simulink project to make the structure more modular.
While the first trials were successful (#84), the integration tests were not exhaustive.
This issue aims to track which tests need to be performed, before making Experimental the official project.

I was able to successfully restore operation of the setup, so I can lay out the integration tests:

Switch control mode any-to-any:

Idle -> current
Idle -> velocity
idle -> voltage
current -> idle
current -> velocity
current -> voltage
voltage -> idle
voltage -> current
voltage -> velocity
The switch between modes must be bumpless

Restoring the control mode from idle/fault should reset the setpoint

Velocity mode must be succesfully tested

If possible, depending on the Simulink driver, 4 CAN messages need to be processed in the same tick

This is a first list, other tests will be added as needed.

Could:
* If possible, depending on the Simulink driver, 4 CAN messages need to be processed in the same tick

The Simulink CAN driver is indeed able to send multiple messages in a Simulation tick. The messages though are not really parallel, but sequential and they are sent at 100us.
The board is indeed able to get them, and we can see that from a cold start it processes all the 4 messages since it switches to a control mode and sends its own messages.

We can see from the plot below that the bumpless transfer works, though since the PIDS are reset, the transitory spike is present:

This can be improved by updating the initial conditions of the integrators, and maybe tuning up a little bit the controllers.

Well done so far 👍🏻

This can be improved by updating the initial conditions of the integrators, and maybe tuning up a little bit the controllers.

We do employ Tracking Mode in our PID controllers, hence the bumpless switch should be guaranteed. Perhaps, we could check whether the tracking gain is ok. See:

https://www.mathworks.com/help/simulink/slref/bumpless-control-transfer-between-manual-and-pid-control.html#:~:text=To activate signal,gain%2C see [1].

From the Astrom's bible, it turns out that we can increase Kt in order to have more bumpless switches.

A first try of increasing the tracking coefficient by a factor of 100 seems to suggest that the PID parameters still dominate the response:

I might make more tests in simulation nonetheless.

Regarding

Restoring the control mode from idle/fault should reset the setpoint

All tests are successsful:
Voltage

Current

Velocity

I might make more tests in simulation nonetheless.

It seems that even in simulation the effect of the tracking coefficient Kt is irrelevant for the Iq controller, see the  comparison below.
In this scenario, I increased 10x the current PID:

There is a 3msec difference in the settling time to 99.5% of the target.
Note that this behaviour occurs with the current AMCBLDC architectural model as well.
Maybe we can track the developments on this front in a different issue.

Maybe we can track the developments on this front in a different issue.

Yes... and no 😃
Meaning I don't think it's worth spending too much time on this after having documented how it works so in detail.
The issue can be opened, but I'd be more in favor of continuing with the final switch.

I'm ready to create the PR to replace the current AMCBLDC architectural model, and in icub-firmware, but I found issues with the CMSIS, after upgrading to Matlab R2024a:

The files mw_cmsis.h and mw_cmsis_impl.h` (matlab headers containing defines used to call cmsis functions) would not be copied from the internal matlab folders to the codegen ones
The CMSIS function called by this version of matlab 2024a are the 5.9, not the latest version (6.1). Therefore, we would need to pin on the keil project a specific cmsis package and cmsis-dsp.
Even after pinning the version of the cmsis libraries and copying manually the files, I'm still having issues compiling the code.

I suggest for the time being to completely avoid calling cmsis functions, since we saw no benefit in the critical paths of the FOC in the past.

Do you have the latest MATLAB updates installed?
Let's go w/o CMSIS 👍🏻
However, I would really recommend filing a ticket on MathWorks about this bug.

Do you have the latest MATLAB updates installed?

Yes, Update 6.

Let's go w/o CMSIS 👍🏻 However, I would really recommend filing a ticket on MathWorks about this bug.

Will do 👍🏻

PR here for icub-firmware-models: https://github.com/robotology/icub-firmware-models/pull/94
Will request merging after successful tests on the wrist.

Booked the robot ergocub 000 for tomorrow.

The integration test on the robot could involve the following operations:

Test
Result

Put the boards in Current mode at startup
-

Move the motors by applying a Yaw setpoint
-

Move the motors by applying a Pitch setpoint
-

Move the motors by applying a Roll setpoint
-

Push the fault button, release it, restore control mode
-

Set a small overcurrent limit, trigger overcurrent fault, clear it, restore control
-

[!IMPORTANT]
Other control modes are not available because of the joint coupling

These are the first results coming from the robot.
I created a set of configuration files to launch only the left wrist joints, and dumped the data with yarpdatadumper, monitoring the port /wrist/mc/stateExt:o, so I could get the current and pwm info from the stateExt struct.
The tests were successful, the only one I could not run was the fault button press and release, because there is an issue with the robot.
I called the firmware 2.1
Here are the results of position control for all 3 joints, they work as expected:

Here are the resulting pwms (perc [0, 1]) and currents (Ampere). The values are quite chaotic, but I do not think they are caused by the refactored firmware.

Here is the result of the overcurrent test and the control mode switch, in which the behaviour is expected>
position -> fault -> idle > position
The control mode integer values are the result of the vocab32 creation:

mode
vocab
integer

position
pos
7.56e6

idle
idl
7.10e6

hardware fault
hwfa
1.63e8

Fantastic job @mfussi66, really 🚀
I will merge the PR.
These changes won't be delivered via distro 2024.08.0 though. They'll be available in devel.
Therefore, we ought to make sure that the corresponding generated source FW along with binaries won't land in the release.
cc @Nicogene

Though I must note that this new mbd firmware was not tested on the AMC board. We can schedule it with another issue.

Agree 👍🏻
Go ahead and open up an issue for that.
I'll merge the PR anyway as we have a copy of the old code.

PR merged ✅


Add support for rendering BitmapFonts in 3D

This branch is a crude (but nearly feature-complete) implementation to replace the Text entity.
The replacement of the sprite-indexed font rendering allows the engine to render 3D text with accented characters and other features of the BitmapFont class. It also sets precedent for rendering SpriteBatches in the 3D world.
The outstanding issue with this implementation is the lighting, which is currently bottlenecked at https://github.com/evrimoztamur/delverengine/blob/e86c4934f934daa15d073d86d6c1baf743796beb/Dungeoneer/src/com/interrupt/dungeoneer/gfx/GlRenderer.java#L812. I can't figure out how to correctly set the colour based on the 3D world light.
@Interrupt @joshuaskelly could you do a brief test of the existing featureset, and comment on lighting issues later?

The GlRenderer.java:GetLightmapAt function call will return the level's static lighting at a given point in space. Static sprites in the game will only look that up once at level load (unless the lighting in that part of the level gets refreshed) and dynamic sprites end up looking up that color every frame.

Added newline support, please review @Interrupt.

Replaced Text with NeoText and it looks like it has smoothly transitioned. There's a small issue with the entity ? being displayed, @Interrupt @joshuaskelly any help with getting rid of that?

This could be a way to upgrade older text entities to the new way of rendering: https://discordapp.com/channels/266998536632139776/707655151279931392/760967228220506174

Looks good to me, the conversion code from @Interrupt wasn't entirely correct in the sense that it was a catch-all for the new Text entities too.
I replaced this check with an instanceof against DrawableSprite which is a guaranteed determinant of legacy Text entities.


Fix tensordot broadcasting rules

The noncontracted axes do not broadcast together and do not need to be
broadcast compatible.

LGTM. Thanks, @asmeurer!


Add Suxior

New and Basic Server with Practice and Kitmap

Please close this pull request if you do not want your server to be added (I saw you reverted your commit).

if I want them to add it, just look at the one I added

if I want them to add it, just look at the one I added

@TulioTriste, if I approve and merge this PR, no changes will be applied due to you reverting the commit
Please push another commit if you'd like your mapping to be merged; You can also close this PR if you're no longer interested.


Secret key redesign and mnemonic validation

Try out this version of Leather — download extension builds.

This PR:

adds validation of mnemonic words to the key form
disables the
replaces the text input for that form with the radix TextField component
wraps that form with Formik
Applies the new design of New Key / Sign In / Show Key  and shares the same style
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/❖-Leather-–-Design-System?type=design&node-id=8109%3A81842&mode=dev

Here's a demo of the new flows:
https://github.com/leather-wallet/extension/assets/2938440/466bcf14-098b-49b6-b8cf-4d98f3d9244e

That doesn't look right to me, shouldn't the input fields fill that white space so it stretches two across that total width?

@pete-watters is this worth a full design review? If so, let's add @fabric-8 as a reviewer

That doesn't look right to me, shouldn't the input fields fill that white space so it stretches two across that total width?

Thanks! I'll fix that and make sure it looks OK everywhere

1024px breakpoint up hits content overflow

Looks good Pete, noted some small findings

Thanks @kyranjamie 👍 I'll work through them and update early next week and give it another test before merging

@mica000 to review once final touches in place

@pete-watters let me know when you are ready to have it reviewed

@pete-watters let me know when you are ready to have it reviewed

Hey @mica000 ,
It's ready to check now, thanks! I just need to push a code formatting fix but that won't effect the visual UI
If you spot any issues just let me know, thanks!

Input radius border seems to have different value

Space between copy content is missing or might be too small? Can we try making 32px to see if its better?
https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/❖-Leather-–-Design-System?type=design&node-id=8109-85980&mode=design&t=GWkPk0GFV2vMVala-4

Revert border radius to rounded 8px

@pete-watters the number on the input still moves on blur/focus. Recommend the pseudo element approach above.
IMO border-width shouldn't be changed on focus, as it causes a relayout, often responsible for slight shifts like this. Pesudo elements are super helpful for borders.

Input radius border seems to have different value
Space between copy content is missing or might be too small? Can we try making 32px to see if its better? https://www.figma.com/file/2MLHeIeL6XPVi3Tc2DfFCr/❖-Leather-–-Design-System?type=design&node-id=8109-85980&mode=design&t=GWkPk0GFV2vMVala-4
Revert border radius to rounded 8px

Thanks, I'll fix

@pete-watters the number on the input still moves on blur/focus. Recommend the pseudo element approach above.
IMO border-width shouldn't be changed on focus, as it causes a relayout, often responsible for slight shifts like this. Pesudo elements are super helpful for borders.

OK, let me change that. Thanks! I was changing the border width to help mask over the radix BG colour. I'll make it look better with pseudo

@mica000 : I have made the last changes to fix the spacing and border radius. Can you please re-check when you have time? Also, @fabric-8 can you please QA this to make sure it's working as you expect.
@kyranjamie:

I made your requested changes also, thanks for the psuedo element suggestion, it looks a lot better.
One suggestion I tried and then had to roll back was the use of the useFocus hook.

If I introduce that and spread ..bind to the input field it has un-desirable effects on Formik.
It stopped isTouched working correctly so it wasn't always showing errors for specific fields.
I think it's good to help indicate if something is focused but I think it doesn't mix well with Formik
Using setState to store focus isn't ideal I know but it allows us to change the field type between text + password whilst also keeping Formik happy
Maybe there's an easy change I can make to use it?

Looking at the codebase and there is only one other place we use the isFocused hook now - item-hover.tsx. We use the hook for useHover in other places but I believe even there we can do what we want from it by just using CSS. I looked at the library and it hasn't been updated for more than 3 years also

Very cool, looks like we're almost there!
Noticed that number labels are placed differently, depending on weather it's the read-only field version or not. Would be great if we can use the read-only version spacing for the regular input version as well so that the label numbers are placed consistently (and more nicely!)

From what I'm able to see, we're doing different things for the label span containing the number. If you:

Don't use left margin/padding of the label span
use space .01 for the right margin

as you already do in the the read-only version it should look good!

Very cool, looks like we're almost there!
Noticed that number labels are placed differently, depending on weather it's the read-only field version or not. Would be great if we can use the read-only version spacing for the regular input version as well so that the label numbers are placed consistently (and more nicely!)

From what I'm able to see, we're doing different things for the label span containing the number. If you:

Don't use left margin/padding of the label span
use space .01 for the right margin

as you already do in the the read-only version it should look good!

Thanks @fabric-8 . I've fixed it now here https://github.com/leather-wallet/extension/pull/4322


Staking rewards

Adds the APY as a bot named Current APY
A refactor of https://github.com/KlimaDAO/discord-bots/pull/8 to get the correct APY, please follow this PR for ENV setup instructions

I'd like to move forward with this, but with a couple of important changes:

Use the PolygonScan API to fetch the average block time for the past day and use that to calculate the expected number of rebases per day, rather than relying on a hard-coded value
Quote 5 day ROI first, then APY in the "Playing" text so we start emphasizing 5 day ROI over APY


Add a mechanism for user to know the availability of cucim.CuImage

Add cucim.is_available() method

Users can query if a specific module is available or not.
For example, if cucim.clara module which requires C shared library is not available:
>>> import cucim
>>> cucim.is_available()
False
>>> cucim.is_available("skimage")
True
>>> cucim.is_available("core")
True
>>> cucim.is_available("clara")
False

Resolves #104
Supports https://github.com/Project-MONAI/MONAI/pull/2987

@jakirkham Conda-related CI/CD failure happens again here.

Are we sure it is Conda related? Looks like it happens part way through the build. Please see snippet below:
15:35:06 [ 77%] Building CXX object CMakeFiles/cucim.dir/pybind11/filesystem/cufile_py.cpp.o

https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cucim/job/prb/job/cucim-cpu-python-build/CUDA=11.0,PYTHON=3.7/61/console

Would recommend increasing verbosity from cmake & make to get a better idea on why the build dies there

Would recommend increasing verbosity from cmake & make to get a better idea on why the build dies there

https://github.com/rapidsai/cucim/pull/106
https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cucim/job/prb/job/cucim-cpu-python-build/CUDA=11.2,PYTHON=3.7/61/console
Looks like the failure is because https://github.com/rapidsai/cucim/pull/106 is merged.
LINE 1123
15:34:17 /workspace/.conda-bld/cucim_1632954074303/work/python/pybind11/cucim_py.cpp: In function 'void cucim::pybind11_init__cucim(pybind11::module_&)':
15:34:17 /workspace/.conda-bld/cucim_1632954074303/work/python/pybind11/cucim_py.cpp:156:33: error: 'close' is not a member of 'cucim::CuImage'
15:34:17   156 |         .def("close", &CuImage::close, doc::CuImage::doc_close, py::call_guard<py::gil_scoped_release>()) //
15:34:17       |                                 ^~~~~
15:34:17 /workspace/.conda-bld/cucim_1632954074303/work/python/pybind11/cucim_py.cpp: In lambda function:
15:34:17 /workspace/.conda-bld/cucim_1632954074303/work/python/pybind11/cucim_py.cpp:168:24: error: 'using element_type = class cucim::CuImage' {aka 'class cucim::CuImage'} has no member named 'close'
15:34:17   168 |                 cuimg->close(); //
15:34:17       |                        ^~~~~
15:34:21 gmake[3]: *** [CMakeFiles/cucim.dir/pybind11/cucim_py.cpp.o] Error 1

Will rebase this on top of the latest change.

@gpucibot merge


add example with programmatic build

Adds an example programmatic build with multiple entry points. I tried to structure scripts/build.js so it could easily be repurposed for a single entry point.
ref #50

Amazing. Thanks again @maxbeatty


[BugFix] Fix drop partition in different db could not refresh MV

Why I'm doing:
MV could not refresh when dropping partition in different db.
What I'm doing:
What type of PR is this:

[x] BugFix
[ ] Feature
[ ] Enhancement
[ ] Refactor
[ ] UT
[ ] Doc
[ ] Tool

Does this PR entail a change in behavior?

[ ] Yes, this PR will result in a change in behavior.
[x] No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

[ ] Interface/UI changes: syntax, type conversion, expression evaluation, display information
[ ] Parameter changes: default values, similar parameters but with different default values
[ ] Policy changes: use new policy to replace old one, functionality automatically enabled
[ ] Feature removed
[ ] Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

[ ] I have added test cases for my bug fix or my new feature
[ ] This pr needs user documentation (for new or modified features or behaviors)

[ ] I have added documentation for my new feature or new function

[x] This is a backport pr

Bugfix cherry-pick branch check:

[x] I have checked the version labels which the pr will be auto-backported to the target branch

[x] 3.3
[x] 3.2
[ ] 3.1
[ ] 3.0
[ ] 2.5

@kevincai @LiShuMing PTAL.