Using WhisperX

Hello
How are you?
Thanks for contributing to this project.
Do you think it is possible to use WhisperX model instead of Whisper model in this audio stream processing pipe-line?

yes, but why? whisperX wraps faster-whisper which is already integrated


--debug option leads to a traceback

See original issue on GitLab
In GitLab by [Gitlab user @bochecha] on Aug 14, 2018, 22:15
Summary
Using bst show TARGET works fine, but adding --debug gives me a traceback.
Steps to reproduce
$ git clone https://gitlab.com/freedesktop-sdk/freedesktop-sdk.git
$ cd freedesktop-sdk
$ git checkout 18.08  # at the time of writing, that's 094c6d22f12af9e557c733aa59c9c996f5a54d5a
$ bst --debug show all.bst
pid:14063 id:000[--:--:--][][] START   Loading elements
pid:14063 id:000[00:00:07][][] SUCCESS Loading elements
pid:14063 id:000[--:--:--][][] START   Resolving elements
pid:14063 id:000[--:--:--][][] BUG     'StackElement' object has no attribute '_Element__cache_key'

    Traceback (most recent call last):
      File "/usr/bin/bst", line 8, in <module>
        sys.exit(cli())
      File "/usr/lib/python3.6/site-packages/click/core.py", line 721, in __call__
        return self.main(*args, **kwargs)
      File "/usr/lib/python3.6/site-packages/buildstream/_frontend/cli.py", line 162, in override_main
        standalone_mode=standalone_mode, **extra)
      File "/usr/lib/python3.6/site-packages/click/core.py", line 696, in main
        rv = self.invoke(ctx)
      File "/usr/lib/python3.6/site-packages/click/core.py", line 1065, in invoke
        return _process_result(sub_ctx.command.invoke(sub_ctx))
      File "/usr/lib/python3.6/site-packages/click/core.py", line 894, in invoke
        return ctx.invoke(self.callback, **ctx.params)
      File "/usr/lib/python3.6/site-packages/click/core.py", line 534, in invoke
        return callback(*args, **kwargs)
      File "/usr/lib/python3.6/site-packages/click/decorators.py", line 27, in new_func
        return f(get_current_context().obj, *args, **kwargs)
      File "/usr/lib/python3.6/site-packages/buildstream/_frontend/cli.py", line 549, in show
        except_targets=except_)
      File "/usr/lib/python3.6/site-packages/buildstream/_stream.py", line 114, in load_selection
        fetch_subprojects=False)
      File "/usr/lib/python3.6/site-packages/buildstream/_stream.py", line 856, in _load
        fetch_subprojects=fetch_subprojects)
      File "/usr/lib/python3.6/site-packages/buildstream/_pipeline.py", line 111, in load
        fetch_subprojects=fetch_subprojects)
      File "/usr/lib/python3.6/site-packages/buildstream/_project.py", line 322, in load_elements
        for meta in meta_elements
      File "/usr/lib/python3.6/site-packages/buildstream/_project.py", line 322, in <listcomp>
        for meta in meta_elements
      File "/usr/lib/python3.6/site-packages/buildstream/element.py", line 902, in _new_from_meta
        element = meta.project.create_element(artifacts, meta, first_pass=meta.first_pass)
      File "/usr/lib/python3.6/site-packages/buildstream/_project.py", line 233, in create_element
        return self.config.element_factory.create(self._context, self, artifacts, meta)
      File "/usr/lib/python3.6/site-packages/buildstream/_elementfactory.py", line 61, in create
        element = element_type(context, project, artifacts, meta, default_config)
      File "/usr/lib/python3.6/site-packages/buildstream/element.py", line 197, in __init__
        super().__init__(meta.name, context, project, meta.provenance, "element")
      File "/usr/lib/python3.6/site-packages/buildstream/plugin.py", line 170, in __init__
        self.debug("Created: {}".format(self))
      File "/usr/lib/python3.6/site-packages/buildstream/plugin.py", line 451, in debug
        self.__message(MessageType.DEBUG, brief, detail=detail)
      File "/usr/lib/python3.6/site-packages/buildstream/plugin.py", line 693, in __message
        self.__context.message(message)
      File "/usr/lib/python3.6/site-packages/buildstream/_context.py", line 425, in message
        self._message_handler(message, context=self)
      File "/usr/lib/python3.6/site-packages/buildstream/_frontend/app.py", line 677, in _message_handler
        text = self.logger.render(message)
      File "/usr/lib/python3.6/site-packages/buildstream/_frontend/widget.py", line 591, in render
        return self._render(message)
      File "/usr/lib/python3.6/site-packages/buildstream/_frontend/widget.py", line 626, in _render
        text += widget.render(message)
      File "/usr/lib/python3.6/site-packages/buildstream/_frontend/widget.py", line 228, in render
        _, key, missing = plugin._get_display_key()
      File "/usr/lib/python3.6/site-packages/buildstream/element.py", line 1148, in _get_display_key
        cache_key = self._get_cache_key()
      File "/usr/lib/python3.6/site-packages/buildstream/element.py", line 1001, in _get_cache_key
        return self.__cache_key
    AttributeError: 'StackElement' object has no attribute '_Element__cache_key'

What is the current bug behavior?
A traceback.
What is the expected correct behavior?
The same as bst show all.bst, but with additional debug input.
Other relevant information
I don't think it matters, but that's with the Fedora package I made.

BuildStream version affected: 1.1.6

In GitLab by [Gitlab user @tristanvb] on Aug 15, 2018, 10:20
Strange, it appears this should have been fixed in the 1.1.6 release; with !648
Probably a separate, but very related issue.

In GitLab by [Gitlab user @toscalix] on Aug 20, 2018, 09:16
assigned to [Gitlab user @valentindavid]

In GitLab by [Gitlab user @valentindavid] on Aug 22, 2018, 12:29
Can reproduce on 1.1.5. Not on 1.1.6. Probably a mistake in the report.

In GitLab by [Gitlab user @bochecha] on Aug 22, 2018, 12:33
Yeah, somehow I can't reproduce it any more either. Let's close this, I'll reopen if I figure out what went on.

In GitLab by [Gitlab user @bochecha] on Aug 22, 2018, 12:33
closed


[IMPROVEMENT] Improving contact us page to include validations before form submission

Describe the bug
Missing validations before the submission of contact us form.
The current code is allowing the user to submit the form even if the fields are empty and only the validation is applied for the length of the message. The validations are missing for first name,last name,email and phone number
Expected behavior
Input Validation: Add checks for all fields and email format.
Constants: Introduce a constant for the API URL.
Error Handling: Improved error handling with a dedicated function.
Separation of Concerns: Created separate functions for showing/hiding popups.
Accessibility: Considered accessibility in popup management.
Screenshots

@ANSHIKA-26 Please assign me this issue along the labels of hacktoberfest and gssoc extended and level

@ANSHIKA-26 My name is not displaying in the assignee. Kindly assign me the issue

you can assign this issue to me..

you can assign this issue to me..

I have created this issue and the issue is assigned on first come first serve basis so it will be assigned to me

@ushmita4 @ANSHIKA-26 Kindly assign this issue to me

@ushmita4 @ANSHIKA-26 Ma'am kindly assign this issue to me.....I would like to work on it...I have already worked upon similar tasks

/assign


External storage options

At the moment, if the containers are destroyed, information about scans are stored in the database (assuming a remote DB has been configured).  However, the original image will be lost.  It would be nice if the image could also be stored in a remote storage solution.  E.g., AWS, google cloud storage, ftp, etc.
Example usage:

Configure remote DB
Configure remote storage
Do some scans
Delete containers
Bring up new containers with same configuration
Still have access to original images and scan info

@cco3 sorry for the late reply... I missed this one.
How would you see this done?

a global feature with per-instance setting that would systematically safeguard a copy of any project input files using some file services
something to be configured on a per-pipeline basis?

The former.
I'm imagining it would be analogous to how you configure alternate DBs, except using standards for file storage. https://scancodeio.readthedocs.io/en/latest/scancodeio-settings.html#database

Adding this to the latest milestone as this needs some minimal design first. @cco3 could you help there?

Ideally what I would like is just to specify a URL to a google storage bucket in the config.  If I understand correctly, there are a number of services that have compatible apis so you can use the same clients on all of them.


Problems without column information are always shown as column 1,1

This happens always as it is in-built.
It was previously tracked in #110561.

The idea is to change the model to get a not-wrong column zero inserted - and the question is: What could the UI show in this case?

IMO UI shall show what the model has especially we have multiple UIs rendering diagnostics.
CCing @jrieken for model change
Originally posted by @sandy081 in https://github.com/microsoft/vscode/issues/110561#issuecomment-971427817

So, please either (preferably) reopen the currently locked issue or lets continue here...

@sandy081 I think there's still no way for problems in the problems view to have no column number. Is that correct? Before anything can be done on the tasks side markers would need to be allowed to have an undefined column number.

What is the internal column of we use a location match? In this case the whole line is marked as the intention for "no column" is.

I think there's still no way for problems in the problems view to have no column number. Is that correct?

Right

@jrieken assigning to you as the very first step if we want this is allowing the markers model to have no column.

very first step if we want this is allowing the markers model to have no column.

In the model surely not. However consumers of the marker service, such as tasks or extensions, can handle this, e.g select the whole line etc

In the model surely not. However consumers of the marker service, such as tasks or extensions, can handle this, e.g select the whole line etc

... which brings us back to: let's just define "column 0 in model means the consumer should use the whole line" ...

... which brings us back to: let's just define "column 0 in model means the consumer should use the whole line" ...

Just use a very large number instead and have what you want

If I understand this correctly the point is: the one that creates the model entry (for example the pattern matching task) should not add "1,1" or "0,0", but "1,INT_MAX" and the ones that show the model entry should limit the value to the actual line length?
... this would us bring back to the original point from the original issue that a match without a column should automatically set the column appropriate - which was moved to "the model should handle it"...

Using a very large number for the column should be fine from the tasks side. We'll have to try it out and see what the Problems view ends up doing with that.


Do not create order in gateways when checkout line variant is deleted

Update Adyen and Stripe plugins - do not create an order when some checkout line variants are removed during payment.
Get rid of duplicated refund and void calls in Adyen plugin.
Port changes from #8896

Impact

[ ] New migrations
[ ] New/Updated API fields or mutations
[ ] Deprecated API fields or mutations
[ ] Removed API types, fields, or mutations
[ ] Documentation needs to be updated

Pull Request Checklist

[ ] Privileged queries and mutations are guarded by proper permission checks
[ ] Database queries are optimized and the number of queries is constant
[ ] Database migration files are up to date
[ ] The changes are tested
[ ] GraphQL schema and type definitions are up to date
[ ] Changes are mentioned in the changelog

Task linked: SALEOR-4867 An order is created even if variant/product does not exists


Process crash from invalid JS

Thanks for filing a bug! To save time, if you're having trouble using the library, please check off the items you have tried. If you are just asking a question, skip right to the bottom.
Please verify these steps before filing an issue, and check them off as you go

[x] The relevant native JavascriptEngineSwitcher library packages are installed (such as JavaScriptEngineSwitcher.V8.Native.win-x64)
[x] The VC++ 2017 runtime is installed
[x] The value of SetUseReact and SetUseBabel is correct in ReactConfig.cs or Startup.cs
[x] I've looked at the sample projects in this repo to verify that my app is configured correctly

I'm using these library versions:

ReactJS.NET: React.AspNet 4.1.1
JavaScriptEngineSwitcher:
JavaScriptEngineSwitcher.ChakraCore 3.0.7
JavaScriptEngineSwitcher.ChakraCore.Native.win-x64 3.0.7
JavaScriptEngineSwitcher.Extensions.MsDependencyInjection 3.0.0
react and react-dom: (N/A if using bundled react, or version number)
<EMAIL_ADDRESS>+<EMAIL_ADDRESS>webpack: (N/A if using bundled react)
v4.29.6
node: (N/A if using bundled react)
v8.12.0

Runtime environment:

OS: (Mac, Windows, Linux flavor. Include 32-bit/64-bit and version)
Windows 10 64bit
.NET Framework or .NET Core Version:
4.7.2 (running asp.net core under full framework)

Steps to reproduce

Forget to rename .js to .jsx

I have been trying out ReactJS.NET to see if it is a solution for us in moving forward with serverside rendered React.
Short story is that I got it working in the end, but on the way I ran into a problem with it crashing the process completely. That's worrisome to put into production, to say it mildly, as our website  can't handle traffic without proper warm-up etc.
We are using WebPack - on the way getting it to work in the end, I forgot to rename my test component from .js -> .jsx, so webpack output invalid JS. This crashed the process completely with the following Windows error event:
Application: xxx.exe
Framework Version: v4.0.30319
Description: The process was terminated due to an unhandled exception.
Exception Info: exception code 8007000e, exception address 000001FBE121AC76
Stack:
   at JavaScriptEngineSwitcher.ChakraCore.JsRt.NativeMethods.JsGetAndClearExceptionWithMetadata(JavaScriptEngineSwitcher.ChakraCore.JsRt.JsValue ByRef)
   at JavaScriptEngineSwitcher.ChakraCore.JsRt.NativeMethods.JsGetAndClearExceptionWithMetadata(JavaScriptEngineSwitcher.ChakraCore.JsRt.JsValue ByRef)
   at JavaScriptEngineSwitcher.ChakraCore.JsRt.JsErrorHelpers.ThrowIfError(JavaScriptEngineSwitcher.ChakraCore.JsRt.JsErrorCode)
   at JavaScriptEngineSwitcher.ChakraCore.JsRt.JsContext.RunScript(System.String, JavaScriptEngineSwitcher.ChakraCore.JsRt.JsSourceContext, System.String, JavaScriptEngineSwitcher.ChakraCore.JsRt.JsParseScriptAttributes ByRef)
   at JavaScriptEngineSwitcher.ChakraCore.ChakraCoreJsEngine+<>c__DisplayClass25_0.<InnerEvaluate>b__0()
   at JavaScriptEngineSwitcher.ChakraCore.ScriptDispatcher+<>c__DisplayClass10_0`1[[System.__Canon, mscorlib, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089]].<Invoke>b__0()
   at JavaScriptEngineSwitcher.ChakraCore.ScriptDispatcher.StartThread()
   at System.Threading.ExecutionContext.RunInternal(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object, Boolean)
   at System.Threading.ExecutionContext.Run(System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.ThreadHelper.ThreadStart()

I'm not a "frontender", so I'm not sure I can put together a complete example, though I guess it shouldn't be to difficult from the "React.Sample.Webpack.CoreMvc" example project, if needs be.
But basically I need to know if this is expected and "just name of the game" for this, or if is a bug that can be fixed or whether I screwed up in the setup of the component?
(I tried setting SetExceptionHandler, but that is never hit.)
In advance, thanks for the help/advice.

Just tried V8 and that seems to "behave" better and my ExceptionHandler function is hit instead of a crash:
ReferenceError: props is not defined
   at render (reactComponents.js:24865:104) -> …s.length-1,n="https://reactjs.org/docs/error-decoder.html?invariant="+e,r=0;r<t;r++)n+="&args[]="+en…
   at i (React.Core.Resources.react.generated.min.js:39:11038)
   at he (React.Core.Resources.react.generated.min.js:39:11298)
   at e.render (React.Core.Resources.react.generated.min.js:39:13808)
   at e.read (React.Core.Resources.react.generated.min.js:39:13433)
   at renderToString (React.Core.Resources.react.generated.min.js:39:18190)
   at Script Document [3]:1:16

So I guess this is more likely an issue with JavaScriptEngineSwitcher.ChakraCore, than with ReactJS.NET?
The reason I preferred ChakraCore, was that V8 didn't have netstandard support and we plan to move away from full framework, so adding another full framework dependency seems moving in the wrong direction.

Hi @Reonekot can you try specify DisableFatalOnOOM setting for ChakraCore
.AddChakraCore(settings => { settings.DisableFatalOnOOM = true; });

cc @Taritsyn possible upstream issue with JS engine switcher?

@dustinsoftware I will deal with this problem later, because now I am working on solving errror #72 “(chakra) recursive evaluation”.

@Reonekot I would like to look at source code of the reactComponents.js file. In principle, a file with components that contains more than 24 865 lines of code could cause a out of memory, so still try to use the DisableFatalOnOOM option.

@Reonekot You can see from the stack trace that the error occurred during error handling:
…
Stack:
   at JavaScriptEngineSwitcher.ChakraCore.JsRt.NativeMethods.JsGetAndClearExceptionWithMetadata(JavaScriptEngineSwitcher.ChakraCore.JsRt.JsValue ByRef)
   at JavaScriptEngineSwitcher.ChakraCore.JsRt.NativeMethods.JsGetAndClearExceptionWithMetadata(JavaScriptEngineSwitcher.ChakraCore.JsRt.JsValue ByRef)
…

Moreover, the error handler is triggered 2 times. Most likely, this is some error in the original ChakraCore library, because such calls are impossible in the JavaScriptEngineSwitcher.ChakraCore module.
To send information about this error to developers of original library, I must first reproduce it.

Sorry for the long absence - been on a long Easter vacation and totally forgot I had this open. Thanks for the feedback and looking into it!
I tried setting DisableFatalOnOOM = true and this "fixes" my original issue, so my exception handler on IReactSiteConfiguration is now hit, which matches what I see with V8. This is much more what I expected and need before putting it in production, since killing the process due to an error in a "view" is a no-go for us. (Hopefully our frontend build tools, or test systems, will catch such an error, but still...)
And it seems you were spot on with the line count of reactComponents.js - this file for this unoptimized build is 24.877 lines.
Excuse my ignorance here, but how do I handle this? My reactComponent.js looks like this before webpack when running "unoptimized":
import React from 'react';
import ReactDOM from 'react-dom';
import ReactTestComponent from './reactmodules/reactTestComponent';

global.React = React;
global.ReactDOM = ReactDOM;
global.ReactTestComponent = ReactTestComponent;

reactTestComponent is 10 lines of code all inclusive, as it's just a very basic "hello world" component. This then becomes too big for the JS engine when unoptimized - is the only option here to always do some form of minifacition, which I'd rather not do in dev environment?
Again, thanks for looking into this issue and the help!

I tried setting DisableFatalOnOOM = true and this "fixes" my original issue, so my exception handler on IReactSiteConfiguration is now hit, which matches what I see with V8.

@Reonekot Looks like the problem is solved. In the next version I will make true as default value for the DisableFatalOnOOM option.

Yes, DisableFatalOnOOM solved the issue, so I'll close the issue.


material lab is not working

[ x] The issue is present in the latest release.
[ ] I have searched the issues of this repository and believe that this is not a duplicate.

Current Behavior 😯
Installed labs and got error when started app:
<EMAIL_ADDRESS>Attempted import error: 'createSvgIcon' is not exported from '@material-ui/core/utils'.
Expected Behavior 🤔
App works
Steps to Reproduce 🕹
install labs and start app
Context 🔦

Your Environment 🌎

Tech
Version

Material-UI
v4.8.0

Material-UI icons
v4.5.1

Material-UI lab
v4.0.0-alpha.49

React
16.12.0

Browser

TypeScript
3.6.5

etc.

Duplicate of #20482


Fix a link to sbt.Configuration docs in the Library Dependencies chapter...

....

Hi @admp,
Thank you for your contribution! We really value the time you've taken to put this together.
Before we proceed with reviewing this pull request, please sign the Typesafe Contributors License Agreement:
http://www.typesafe.com/contribute/cla

Apologies, but getting the contributors agreement approved by my employer feels like too much work to fix a single typo. Maybe next time.

Sorry about this. You bring up a good point about the CLA process. I'm guessing that it's trying to say that if you are contributing code that was written during your work hours (at least in the United States) the copyright belongs to your employer, and therefore we cannot accept the code without explicit agreement by them. That said, the boundary of what you did as part of your employment vs what you did on your own, is much more blurry for programmers who are not paid by the hours or those who have signed employment agreement stating that everything you write around the clock belongs to them (apparently many employment agreements are framed exactly that way). I'll bring this up to internal discussion.

Closing this via 1c4ced5


Revisit how splats and repeated URL parameters work

This is a follow-up to https://github.com/rackt/react-router/issues/2286 and https://github.com/rackt/react-router/pull/2421, and continues discussion from https://github.com/rackt/react-router/pull/2401.
The current API around splats and repeated URL parameters is pretty confusing and might lead to unexpected behavior. Two issues:

Repeated URL parameters are automatically converted into arrays: https://github.com/rackt/react-router/blob/v1.0.0-rc3/modules/matchRoutes.js#L33-L37, which can be quite surprising if it happens unexpectedly
Contra e.g. .gitignore usage, * and ** respectively mean non-greedy and greedy splats, rather than wildcards that match or don't match across path separators, leading to unintuitive behavior per the examples in https://github.com/rackt/react-router/pull/2401#issue-113730209

I think the best way to clean this up is:

Get rid of the behavior for converting repeated parameters to arrays - just throw an exception if a parameter is repeated
Make * and ** behave like in .gitignore - both should be greedy, but only * should match across path separators; this is significantly breaking, since it would mean that the recipe for a catch-all route would instead be <Route path="**" component={NotFound} />
Stop binding splats to parameter values; for patterns like *.* for matching e.g. file names, instead use a custom rule per https://github.com/rackt/react-router/issues/2286

I think this would make things simpler, eliminate potentially confusing edge cases, and make behavior more consistent with other places.

I don't think we need to make * and ** mean the same thing they mean in .gitignore. We're not trying to imitate git file-globbing syntax. We're just trying to match URL paths. Having a non-greedy * lets us do *.* really easily, and for the rare cases that someone wants * to be greedy (i.e. match across / characters), we use **. I guess I don't see what the problem is.

What's unintuitive to me is that * will also match across / characters, but only sometimes. Per the OP to #2401, I don't think there's a good reason to have:
/*/c matches /you/are/okay/c
/*/c does not match /you/are/cool/c

I don't know that this would ever be what I want.

You're right. The difference here is between greedy and non-greedy.
We need a non-greedy version of * in order to do stuff like /*/c. Otherwise the * would consume all the way to the end of that string. Apparently (per #2401) we also need a greedy version of *. That was the feature we were missing, and solved with **.

I think the point I want to make is that the relevant distinction shouldn't be greedy vs non-greedy - it should be whether the splat matches path delimiters.
At https://github.com/rackt/react-router/blob/fbc109c0218508a301caae36469c8fc5d70de5fa/modules/PatternUtils.js#L26-L31, the most straightforward approach would be to have the pattern for * just be: ([^\/])* (i.e. everything except for path separators).

I'm actually more bothered by the repeated parameter thing, BTW. If I have something like:
<Route path="/:foo" component={Parent}>
  <Route path=":foo" component={Child} />
</Route>

Then if I'm on /a, then Parent will receive params.foo as 'a', while if I go to /a/b, then Parent will receive params.foo as ['a', 'b'], assuming I'm not misunderstanding what the code does.
This example is contrived, but I'm afraid of users accidentally hitting this on e.g. deep, asynchronous routes where it's not as obvious that a route parameter name might be getting reused.

I'm afraid of users accidentally hitting this

Maybe outputting a warning when a parameter name is used twice?

I'd just throw while validating routes, once we have something in place for e.g. matching files with extensions so we don't need splats any more.

In our application, a given route component might be used as a sub-route in many different places, so it has no way of knowing in which parent routes it will be used. Consequently, there is always a chance of param name clashes between it and its parent routes.
Throwing an exception when a parameter name is used twice won't really help us. What I'd like to see instead is each route only receiving the params immediately following it, allowing params with identical names but different values to happily coexist.
To illustrate:
Let's say we have a route like a/:foo/:bar/b/:foo/:blubb and the path a/1/2/b/3/4. I'd like to get the following values:

params = { foo: ['1', '3'], bar: '2', blubb: '4' } (I normally wouldn't use those)
a.routeParams = { foo: '1', bar: '2' }
b.routeParams = { foo: '3', blubb: '4' }

I don't think we want to support that. It's quite nice to have params be globally consistent, and I don't think it'd be acceptable from a performance perspective to re-run matching just to get routeParams.
I do not think we should support repeated named params at all.

We should do what Express does for splats (&c.) – use numerical indices.

Closing this as part of https://github.com/reactjs/react-router/issues/2286.

The idea is – the choice of matching will affect splat handling anyway.


Fix validate_conditional_tuple spec

The second attribute is missing on the spec, causing an exception while compiling the lib.
PD: Great release! Hoping to see it soon live!

Thankyou!


Try running Catch2 shards in parallel

Superseded by https://github.com/Werni2A/OpenOrCadParser/pull/106


Modify hashing function if we choose to go with Compact Blocks

This serves as more of a reminder. I am not trying to presuppose that we will use compact blocks. However, in the case that we do, it's import that we modify the hash function outlined here:
https://github.com/celestiaorg/celestia-core/blob/e8724248c7d6a438ec08046e82525c83a2d64941/types/tx.go#L32-L40
Or at least modify the hashes used in the cat pool to return the entire hash of the data that is being transmitted. If we don't then someone could modify the contents of a BlobTx and we would not be able to notice that it is a different transaction from the one proposed.
Put another way, the hash over the complete data is needed in compact blocks for the integrity of what is being proposed and eventually committed

For Admin Use

[ ] Not duplicate issue
[ ] Appropriate labels applied
[ ] Appropriate contributors tagged
[ ] Contributor assigned/self-assigned

are we calling checktx on the returned data? if so, are we verifying the blobTx?
and is this only for versions of compact blocks that use the mempool to propogate missing portions of the block in the mempool? ie, in a more breaking version where we change the partsetheader do we have the same issue?

are we calling checktx on the returned data? if so, are we verifying the blobTx?

Yes we are still calling checktx. I wonder the fact that the blob commitments are in the PFB means that someone actually can't modify any of the contents of the blob


Fails to return VFPINJ table upon user request

User input should extract tables with tagname VFPINJ as well as VFPPROD with user input:
yaml
 datatypes:
  vfp:
    keyword:
    - VFPPROD
    - VFPINJ

in branch bugfix_vfping test data to reproduce the issue is added as tests/data/oscar with corresponding test file tests/test_w_oscar.py. Test uploads 9 tables with tagnames of the form VFPPROD_%d, and nothing else, but should upload one table with tagname VPFINJ_1 as well

#77 Should have solved.
Also, https://github.com/equinor/fmu-sumo-sim2sumo/pull/94 changed to default export of both VFPPROD and VFPINJ.


United Kingdom doesn't return the summer bank holiday

I'm looking into integrating this package with our businesses annual leave calendar, however for the UK it's missing the summer bank holiday
In the UK this holiday falls on the last Monday of August, and in Scotland it falls on the first Monday of the month

After forking the repo I can see that the master branch has the summer bank holiday included in the UK's holidays, however it's not included in the most recent packagist release. So when I install the package through composer, I'm mising the summer bank holidays

Yes, that's normal :) I haven't yet officially released recent changes, fixes, etc. in a new release. You are more than welcome to use the master branch in your project. In your Composer file, you can specify to use the master branch in stead of the latest official release.

Closing this issue as it has been addressed already in the master branch and will be included in the upcoming v1.7.0 release.


Automate the creation of draft GitHub releases

To accomplish this, create a node.js script that scrapes the latest content from the CHANGELOG and generates a valid request to the Create a Release API with draft set to true. The initial scope of work should be for this script to run locally on a dev machine. Later work will refactor this to run in CI and automatically attach release assets.
Resources:
https://developer.github.com/v3/repos/releases/#create-a-release
https://developer.github.com/v3/repos/releases/#upload-a-release-asset

Revisiting this issue, it seems that GitHub is making their v4 API GraphQL.


Extract unused contracts to an external repo

In reference to https://api3workspace.slack.com/archives/C02AYRX8D89/p1680698758234279
There are a lot of contracts in @api3/airnode-protocol that are not used in practice. Some of these are less viable alternatives to RequesterAuthorizerWithErc721. Once we have full RequesterAuthorizerWithErc721 support, we should remove these alternative user flows in favor of simplicity.

For issue tracking purposes, the RequesterAuthorizerWithErc721 support issue is here: https://github.com/api3dao/airnode/issues/1675


Helm chart outdated

Expected Behavior
To have an updated helm chart to use recent applications to deploy apps in a cluster with version controlled and provide to other tools like Jenkins X. Helm charts provide visibility through platforms such as artifact hub and make it easy to install and update.
Actual Behavior
Helm chart outdated
Additional Info
There are other tries to give visibility about this "problem"
https://github.com/tektoncd/pipeline/issues/5886#issuecomment-1358000244 and proposals to create one: https://github.com/tektoncd/pipeline/issues/5886#issuecomment-1552355412 https://github.com/tektoncd/pipeline/issues/5136
There's another Tekton helm chart from the CDF that's outdated: https://github.com/cdfoundation/tekton-helm-chart
Why don't you want to give a push to this even if there are proposals for collaboration?
Thank you

Helm chart outdated

By this you mean the chart in https://github.com/cdfoundation/tekton-helm-chart or another chart somewhere ? If yes, this is not maintained by us, and an issue about it being outdated would need to be there.
That said, yes, there are request for providing an helm chart, and the operator does provide one (for the operator).

Sorry for my lack of knowledge or doubt but, tekton operator helm chart include only pipeline component? Have the possibility to have the complete installation in a helm chart like these instructions? https://tekton.dev/docs/operator/install/ it seems only the pipeline (lite) is installed (no dashboard, no trigger...etc)

The helm chart in the operator installs the operator and let's you then do what you want with it. The operator itself manages most components in the tektoncd org.
cc @tektoncd/operator-maintainers


verbs & -ing form

Some verbs like eat and eating will convert to an emoji, but apparently running becomes an emoji, while run does not.
Same goes for die / dying.
Most of the verbs work fine though !

heh, yeah, i think i literally strip the ing and try to translate that, and runn or dy are not real words. I doubt I'll ever fix this, tbh, since it involves Dealing With English Grammar™

you could use the compromise library https://github.com/spencermountain/compromise


Docs for listdir

listdir needs a section in the Python and CLI API "creating and finding archives" sections

Add search and filter to the documentation for finding archives


Will fabrication have stubbing feature?

I really like the way to set up associated objects in Fabrication. But transitioning from Factory Girl, I was able to take advantage of its stubbing feature. (build_stubbed)
Will Fabrication implement this feature any time? Or is it already achievable?

I have no plans to implement a clone of build_stubbed. If you explain what you're trying to accomplish with it I can probably help you figure out how to pull it off though.


Is it possible to integrate it with jest-playwright-preset?

I'm using jest-playwright-preset to run playwright tests with the jest.
https://www.npmjs.com/package/jest-playwright-preset
But it has note in documentation:

Be sure to remove any existing testEnvironment option from your Jest configuration. The jest-playwright-preset preset needs to manage that option itself.

With jasmine2 reporter I used jest-allure which has different way to setup:
setupFilesAfterEnv: ["jest-allure/dist/setup"]
So is there any over options to setup allure reporter?

I suppose no, so I just forked the repo with playwright preset and update forked version for my needs


  I have been using this editor and it works well.  The app is in a git repo.  If I clone that repo somewhere else or edit the files on github itself, I then have to delete my project on my chromebook and clone it again.  I should at least be able to pull the code changes down. Ideally I would be able to merge too.

+1 - This is the biggest problem I have when using CDE on my Chromebooks. I have more than one and frequently will use a different Chromebook to work on a project, depending on where I am at the time. Being tied to a single device or forced to delete the project and reclone it (and wait for bower to reinstall all the packages!) kind of defeats the purpose of using github! The ability to pull the changes without having to clone the project again is a must have.

+1


Add option to not resize the window when a video starts

I like to use Spectacle app to place my windows, and when my first video started, the player moved and was resized. Adding an option to disable this behavior would be nice.
Maybe try to resize/replace centered on the current position, not larger than the current size?

I also use Spectacle! It's great software.
However, I do think the current the current behavior is correct for 99% of users.


is it possible to drag between slides?

Hi, is it possible to use drag gestures with this component?

I don't see why not, but it has been so long since I made this. If you want to add a PR I would review and merge it.


Added support for pkg-config

Supporting pkg-config will allow linking a whole bunch of native dependencies flexibly without specifying link flags for each and every one separately. Some *-sys crates support it in their build.rs scripts, but sadly not all. Trying to improve the situation bit by bit.

This appears to have broken https://github.com/sgrif/pq-sys/commit/3ad9f7b77a6c4f50d5d7277bce05c836a62a4398, and I don't see an easy way to fix it. Ultimately the problem is that given the setup that cause the problem that commit fixed in the first place, pkg_config will end up putting /usr/local/lib ahead of the native search path, breaking everything.
I'm honestly not entirely sure what this actually adds over what was there before, either. However, I don't want to flat revert just yet, so I'm going to put it behind a feature flag.

Indeed, it seems that there isn't an easy way to fix it.
Btw. I did what I could: I posted a suggestion to pkg-config to do the symlink-following thing (since that leads to the single-library-exclusive dirs which prevent conflicts. This works at least in the case of Homebrew, but I think some other packaging systems do this kind of namespacing too, so it should be generally a beneficial thing to do.) If they do that, it should prevent passing /usr/local/lib to Cargo. Here's the issue: https://github.com/alexcrichton/pkg-config-rs/issues/34
Also, I noticed that Homebrew .pc files were inconsistent: some declared the lib dir to be /usr/local/lib, and some declared directly the "private" install dir. The latter obviously causes less conflicts, so I sent an issue to Homebrew too. (However, I'm quite oblivious to their system so I don't know if it's going to help at all) https://github.com/Homebrew/homebrew-core/issues/8472


Fix cilium endpoint regenerate

There have recently been a few problems with cilium endpoint regenerate:

The update to swagger post-1.4 caused all cilium endpoint regenerate calls to return error 422, Unprocessable Entity because the client passes a nil structure for the config when it must be specified, and the server libraries now enforce that it must be non-nil (even if empty inside). This was always in our spec, but I strongly suspect that a library update caused this to now be enforced.
Sometimes, the cilium daemon logic would sidestep an attempt to manually regenerate the endpoint because the headerfiles didn't change. I believe the intent when someone is regenerating an endpoint is specifically to avoid this type of optimization logic and actually regenerate.

Fix these, and on the way, refactor the handling of the datapathRegenerationContext to properly handle the variety of regenerations we have today, which may be one of the following enumerations:
        // RegenerateWithoutDatapath indicates that datapath rebuild or reload
        // is not required to implement this regeneration.
        RegenerateWithoutDatapath DatapathRegenerationLevel = 0
        // RegenerateWithDatapathLoad indicates that the datapath must be
        // reloaded but not recompiled to implement this regeneration.
        RegenerateWithDatapathLoad DatapathRegenerationLevel = 1
        // RegenerateWithDatapathRebulid indicates the the datapath must be
        // recompiled and reloaded to implement this regeneration.
        RegenerateWithDatapathRebuild DatapathRegenerationLevel = 2

If you feel strongly that this should be backported, please comment on the issue and/or add the labels and we can discuss.
Fixes: #7264

This change is

test-me-please

test-me-please

This will conflict with #6618 , so if we intend to backport this PR then we should consider merging it first.

Coverage increased (+0.04%) to 43.246% when pulling 2fa0140efc903872085d9932577024c314728d69 on joestringer:submit/fix-regen-api into 5aba0b63a3efa8a49cdb526e4a6fa8a92b6d1c65 on cilium:master.

Hit #7105 yet again. Many PRs hit this, it should be unrelated to this PR.

test-me-please

Saved the output and documented the issues in the CI, will re-run CI now.

test-me-please

test-me-please

Only failure is istio issue above, which has affected other PRs too. Merging.


Flag default assignments should be lazily applied

Re: https://github.com/GoogleContainerTools/skaffold/issues/4129, https://github.com/spf13/cobra/issues/1047
In Skaffold we use cobra and pflags to define our CLI.  We have the flags toggle values directly in an options object. We have two commands that take the same flags but with different defaults.  The following snippet demonstrates the issue:
var blowup bool

cmd1 := cobra.Command{}
cmd1.Flags().BoolVar(&blowup, "blowup", false, "When set to false, blowup")

cmd2 := cobra.Command{}
cmd2.Flags().BoolVar(&blowup, "blowup", true, "When set to false, blowup")

cmd1.ParseFlags(os.Args[1:])
fmt.Printf("blowup = %v\n", blowup)

So even though we have two FlagSets, because they reference the same value, the default value for the last flag defined "wins" unless the option is explicitly defined on the command-line.
The issue here is that pflags applies the default value immediately.  BoolVar() just delegates BoolVarP(), and BoolVarP() uses newBoolValue():
https://github.com/spf13/pflag/blob/81378bbcd8a1005f72b1e8d7579e5dd7b2d612ab/bool.go#L47-L57
newBoolValue() allocates a container to map the provider pointer to the default value, but it immediately assigns the value:
https://github.com/spf13/pflag/blob/81378bbcd8a1005f72b1e8d7579e5dd7b2d612ab/bool.go#L15-L18

I also need a lazily applied default value in my command-line tool.
Now I write default value as zero value and fill them at runtime, then write default to flag usage manually.
Is there any way to resolve it?

I ran into this as well re-using an variable with two commands setting different defaults for the same variable as a convenience for the end user. I ended up isolating the variables and doing a small refactoring to make it work but it caught me off guard that a default value from a flag on a different command would be used based on essentially which one is configured last.

I ran into this as well re-using an variable with two commands setting different defaults for the same variable as a convenience for the end user. I ended up isolating the variables and doing a small refactoring to make it work but it caught me off guard that a default value from a flag on a different command would be used based on essentially which one is configured last.

I think this is user error. I would suggest using a lookup instead, and stop relying on passing a pointer around.
If someone can present some other use cases for lazy parsing, I'd maybe take a look at the issue on my fork.

I think this is user error. I would suggest using a lookup instead, and stop relying on passing a pointer around.
If someone can present some other use cases for lazy parsing, I'd maybe take a look at the issue on my fork.

It could be classed as user error, I'm coming to this via Cobra that provided examples using this and I kept following that pattern. I think for someone running the code in two different commands via Cobra this provides a hard to understand and debug behaviour. It doesn't do what I expected and provides a surprise because the challenge is that this can influence the behaviour of another part of the program which is additionally confusing.
I ran into this twice before really realising what was going on. Using lookup instead is an alternative but the library provides a feature, I don't think it's an unreasonable expectation that when paired with Cobra that defaults are lazily applied when their commands are actually invoked. The current behaviour is in a sense hard to decipher because it isn't apparent that the two commands are interacting to change the default value which isn't entirely deterministic to the programmer at the time of writing. For people who know better they won't hit it however this is also a trap that at least a few people seem to have run into and I personally feel that in terms of being user friendly it doesn't seem wrong to defer setting the default value whilst removing a pitfall for a developer new to the library.

It could be classed as user error, I'm coming to this via Cobra that provided examples using this and I kept following that pattern. I think for someone running the code in two different commands via Cobra this provides a hard to understand and debug behaviour. It doesn't do what I expected and provides a surprise because the challenge is that this can influence the behaviour of another part of the program which is additionally confusing.
I ran into this twice before really realising what was going on. Using lookup instead is an alternative but the library provides a feature, I don't think it's an unreasonable expectation that when paired with Cobra that defaults are lazily applied when their commands are actually invoked. The current behaviour is in a sense hard to decipher because it isn't apparent that the two commands are interacting to change the default value which isn't entirely deterministic to the programmer at the time of writing. For people who know better they won't hit it however this is also a trap that at least a few people seem to have run into and I personally feel that in terms of being user friendly it doesn't seem wrong to defer setting the default value whilst removing a pitfall for a developer new to the library.

@pasamio my point is that this is fundamental to golang, not an error with the package. You are passing around a pointer and expecting it to not be overwritten.

@pasamio my point is that this is fundamental to golang, not an error with the package. You are passing around a pointer and expecting it to not be overwritten.

I'm passing a pointer to a variable expecting that it will be filled with the value of my default argument for the flag that is currently being evaluated rather than it being filled with a value from a flag that is not currently being evaluated that is in another part of my Cobra application. I don't think it's an unreasonable expectation that when I hand the library a pointer to my variable that when my flags are evaluated that the variable is either populated with the value the user provided on the command line to the application or the default value I set for the flag in that command.
I think the challenge is the expectation between what pflag does and how that is used in Cobra.

I'm passing a pointer to a variable expecting that it will be filled with the value of my default argument for the flag that is currently being evaluated rather than it being filled with a value from a flag that is not currently being evaluated that is in another part of my Cobra application. I don't think it's an unreasonable expectation that when I hand the library a pointer to my variable that when my flags are evaluated that the variable is either populated with the value the user provided on the command line to the application or the default value I set for the flag in that command.
I think the challenge is the expectation between what pflag does and how that is used in Cobra.

You are passing the pointer twice. Don't do that. Make two variables, or use Lookup.

You are passing the pointer twice. Don't do that. Make two variables, or use Lookup.

I digged into the source code of pflag to fix this but the implementation is so strange that solving this would require rewriting of entire library

Assumption that value of pointer is overwritten immediately when flag is defined, not when Parse is called on FlagSet (here for example: https://github.com/spf13/pflag/blob/master/bool.go#L15) is really counter-intuitive. Pointer should be touched when flags are read, not earlier.
I started working on fixing this by storing default value separately and applying it in Parse and ParseAll before reading values from CLI. But Value interface (https://github.com/spf13/pflag/blob/master/flag.go#L187) has no method to copy current value from one Value to another. I thought that doing sth like value.Set(value.String()) may work but due to reaaaaaalllyyy bad design of pflag library it doesn't work this way for all the types (built-in and custom ones). It would require adding new method Copy to all the types which would break compatibility.
I have to say that: During my research I found that pflag is soo poorly designed that it should be reimplemented completely. Take logic of this function as an example: https://github.com/spf13/pflag/blob/master/flag.go#L538


No possibility to delete all snapshots for certain host/tag/path

Output of restic version
restic 0.9.6 compiled with go1.12.12 on linux/amd64
How did you run restic exactly?
restic forget --path /my/path

I also tried with --keep-last 0 without any effect.
What backend/server/service did you use to store the repository?
MinIO (S3)
Expected behavior
Remove all snapshots with path /my/path.
Actual behavior
no policy was specified, no snapshots will be removed

Steps to reproduce the behavior

Create a few snapshots
Run command as described above

Do you have any idea what may have caused this?
Security measure.
Do you have an idea how to solve the issue?
Option 1: Do allow any filter (host/path/tag) or (keep-x).
Option 2: Add --force parameter
Option 3: Approve setting of --keep-x 0 as policy.

Thanks for your input, but as you already hinted (when you wrote "Security measure") this is intentional and described here in the docs:
For safety reasons, restic refuses to act on an “empty” policy. For example, if one were to specify --keep-last 0 to forget all snapshots in the repository, restic will respond that no snapshots will be removed. To delete all snapshots, use --keep-last 1 and then finally remove the last snapshot ID manually (by passing the ID to forget).
Closing this issue because it works as intended ;)


Removed $ sign in the commands

Why:
$ sign in front of the token should be removed to avoid confusion. It is common that first-time users will spend time to realize $ sign is not necessary. (at least for the Windows OS).

@earik87
Thanks so much for opening a PR! I'll get this triaged for review :zap:


switch to chruby, ruby-install, and a binary ruby

Perfectly acceptable rails.     now with 100% less tests.
A very fast box using a premade ruby binary but has the ability to compile its own.

Great job @zcassini !!!
Please change the file-name of the second script to something more descriptive like gem-setup.sh or post-setup.sh, in lieu of provision2.sh


Upgrading Notebooks to Atoti Python API version 0.8.10

This PR updates the poetry.lock file using poetry update and upgrades all academy and technical use case guides, and one use case finance notebook to version 0.8.10. READMEs will also be updated accordingly.
Specifically, for this upgrade, the following fixes will be made:

Deprecated functions are updated to the current version counterparts.
Broken widget filters are fixed.
Broken doc links are fixed.
atoti-jupyterlab column widths are fixed/better spaced (so users can see full columns and not just ellipses).
MermaidJS diagrams are saved as PNGs and can be viewed in GitHub + browser (thanks @tibdex!).
Minor paragraph/text spacing adjustments to make things more visually clean (clustering text together rather than having too many line breaks, but not all the time — we must strike a balance).

Note: I used find . name "*.ipynb" | sort at the root of the repo to obtain the below list of notebooks.

Upgraded Notebooks

[x] ./01-atoti-academy/introduction-to-atoti/main.ipynb

[x] NEEDS FIX: Broken widgets
[x] NEEDS FIX: Broken doc + index links
[x] NEEDS FIX: Broken widget filters
[x] NEEDS FIX: Deprecated functions
[x] NEEDS FIX: Missing banners

[x] ./01-atoti-academy/storytelling-with-atoti/01-Storytelling.ipynb

[x] NEEDS FIX: Missing banners
[x] NEEDS FIX: Broken doc + index links
[x] NEEDS FIX: Deprecated functions

[x] ./01-atoti-academy/storytelling-with-atoti/02-Storytelling.ipynb

[x] NEEDS FIX: Missing banners
[x] NEEDS FIX: Broken doc + index links
[x]  NEEDS FIX: Deprecated functions

[x] ./01-atoti-academy/storytelling-with-atoti/03-Storytelling.ipynb

[x] NEEDS FIX: Missing banners
[x] NEEDS FIX: Broken doc + index links
[x]  NEEDS FIX: Deprecated functions

[x] ./02-technical-guides/aggregate-provider/main.ipynb

[x] NEEDS FIX: Broken doc + index links
[x] NEEDS FIX: Needs data files added to .gitignore

[x] ./02-technical-guides/auto-cube/main-advanced.ipynb

[x] NEEDS FIX: Broken doc + index links

[x] ./02-technical-guides/auto-cube/main.ipynb
[x] ./02-technical-guides/conditional-functions/main.ipynb

[x] NEEDS FIX: Broken doc + index links
[x] NEEDS FIX: Needs data files added to .gitignore

[x] ./02-technical-guides/currency-conv-with-weighted-ave/main.ipynb
[x] ./02-technical-guides/currency-conversion-with-lookup/main.ipynb

[x] NEEDS FIX: Deprecated functions
[x] NEEDS FIX: Broken doc + index links

[x] ./02-technical-guides/currency-conversion/main.ipynb

[x] NEEDS FIX: Deprecated functions

[ ] ./02-technical-guides/directquery-intro/main.ipynb <-- Skipping, see 0.8.9 PR
[ ] ./02-technical-guides/directquery-vector/main.ipynb <-- Skipping, see 0.8.9 PR
[x] ./02-technical-guides/excel-and-atoti/main.ipynb

[x] NEEDS FIX: Deprecated functions
[x] NEEDS FIX: Broken doc + index links

[x] ./02-technical-guides/internationalization/main.ipynb

[x] NEEDS FIX: Broken doc + index links

[x] ./02-technical-guides/introductory-tutorial/main.ipynb

[x] NEEDS FIX: Missing banners
[x] NEEDS FIX: Broken doc + index links
[x]  NEEDS FIX: Deprecated functions

[x] ./02-technical-guides/multidimensional-analysis/main.ipynb

[x] NEEDS FIX: Missing banners
[x]  NEEDS FIX: Deprecated functions

[x] ./02-technical-guides/rollup-hierarchies/main.ipynb <-- this works, but we link sample data from a Russian site??

[x] NEEDS FIX: Needs data files added to .gitignore

[x] ./02-technical-guides/security-implementation/01-Basic-authentication.ipynb

[x] NEEDS FIX: Broken doc + index links

[ ] ./02-technical-guides/security-implementation/02-OIDC-Auth0.ipynb <-- Skipping, see 0.8.9 PR
[ ] ./02-technical-guides/security-implementation/03-OIDC-Google.ipynb <-- Skipping, see 0.8.9 PR
[x] ./02-technical-guides/security-implementation/04-LDAP.ipynb

[x] NEEDS FIX: Broken doc + index links

[x] ./02-technical-guides/security-implementation/main.ipynb

[x] NEEDS FIX: Broken doc + index links

[x] ./02-technical-guides/table-creation-and-data-loads/main.ipynb
[x] ./02-technical-guides/topcount/atoti.ipynb

[x]  NEEDS FIX: Deprecated functions

[x] ./02-technical-guides/topcount/pandas.ipynb
[ ] ./02-technical-guides/var-benchmark/data_generator.ipynb <-- Skipping, see 0.8.9 PR
[ ] ./02-technical-guides/var-benchmark/main.ipynb <-- Skipping, see 0.8.9 PR
[ ] ./02-technical-guides/virtual-hierarchies/main.ipynb <-- Skipping, see 0.8.9 PR
[x] ./02-technical-guides/weighted-averages/main.ipynb

[x]  NEEDS FIX: Deprecated functions

[x] ./03-use-cases/01-finance/portfolio-management/cvar-optimizer/01_data_generation.ipynb

[x] NEEDS FIX: Needs data files added to .gitignore

[x] ./03-use-cases/01-finance/portfolio-management/cvar-optimizer/main.ipynb

[x] NEEDS FIX: Broken doc + index links

[x] ./03-use-cases/01-finance/quantitative-strategy/bucket-analysis/main.ipynb

[x] NEEDS FIX: Broken doc + index links
[x]  NEEDS FIX: Deprecated functions

[x] ./03-use-cases/01-finance/retail-banking/credit-card-analytics/cc_data_processing.ipynb
[x] ./03-use-cases/01-finance/retail-banking/credit-card-analytics/main.ipynb

[x]  NEEDS FIX: Deprecated functions

Don't forget about https://github.com/activeviam/atoti-python-api/pull/4807#discussion_r1493071409 ;)

I manually had to add 03-use-cases/01-finance/portfolio-management/cvar-optimizer to the test_exclusions.txt because this was failing our CI checks (https://github.com/atoti/atoti/actions/runs/8289148503/job/22685038382?pr=859#step:8:38). Therefore, we either need to set up our CI checks to use a license to test our "locked" Atoti Python API notebooks, or modify the README generator to exclude these notebooks automatically (leaning toward option 1).
Note: I know our README generator does automatically exclude notebooks, but looks like only ones that are not deemed as "latest version". Thus, in this case, I upgraded the notebook to 0.8.10 and it was added to the list of "testable notebooks".


[Deploy] Android Messages

New recipe that uses new Google service Android Messages
Service
Android Messages
Link to your repository
https://github.com/HatBeardMe/franz-android-messages
Additional Information
Currently missing official icon.svg

Just realized duped by #164

Duplicated by #192 and #170 . I personally like #192 approach best.


The predict result is diff between tfjs and python

@rwightman hi, I just use the same configuration model, the same input image, but the predict result is diff between original tfjs and this python one. Is there any clue? have you ever tried it? Thanks.
I mean the predict result [heatmaps, offsets, displacement_fwd, displacement_bwd] values are diff.

What is your input tensor resolution?
Can you try (257,257) first.
I've checked output offsets and displacement and found that it is directly predicted in pixel unit.


Provide mechanism to allow containers to run without CPU limits

Description of the feature or enhancement:
Provide a mechanism to allow containers to run without CPU or memory limits. Currently a default limit is applied to all containers in a Pod as a result of changes made in #1082 . You can specify higher limits, but you can't remove the limits altogether. I also recommend making "unlimited" the default for CPU.
Use Case:
Running containers with limits can, in certain causes, cause a nontrivial amount of time to be spent in the kernel maintaining that limit, due to bugs in older Linux kernels [1][2]. This typically happens with very large containers, e.g., 32 vCPU or higher, leading to decreased overall workload performance. The bugs have since been patched in newer kernel versions (in both 4.x and 5.x), but many customers may be unaware that they are running an impacted kernel.
Moreover, forcing a container to run with limits means it cannot take advantage of free CPU cycles to "burst" beyond its usual resource requirements. This leads to underutilized nodes in many cases, leading to economic waste and higher operational costs than otherwise might be required for a given workload.
A number of certain well-intended but misinformed "best practice" material and evaluation software state that CPU limits are the correct and proper way to prevent a container from becoming a "noisy neighbor" and impacting the performance of other containers running on a node [3][4]. However, this is is incorrect. Resource requests provide the same feature, but in reverse: If a "bursty" container is using more than its requested CPU, the Linux kernel will automatically throttle it back to its requested CPU allocation if another container needs access to the CPU resource (up to the latter's own requested value). That's why requests are also known as guarantees: they ensure the container can always get access to the resource, even if it's currently being used by something else. They set a floor, not a ceiling. And since every container is guaranteed the amount of CPU that it requests, limits aren't necessary to make that effective.
See also https://home.robusta.dev/blog/stop-using-cpu-limits for more background.
Proposed Solution:
Add a Cpu.UNLIMITED constant to cdk8s-plus that removes the CPU limit. And make this the default so that container performance is not unnecessarily throttled.
Other:
[1] https://static.sched.com/hosted_files/kccncna19/dd/Kubecon_ Throttling.pdf
[2] https://github.com/kubernetes/kubernetes/issues/67577
[3] https://github.com/zegl/kube-score/blob/master/README_CHECKS.md
[4] https://polaris.docs.fairwinds.com/checks/efficiency/

[ ] :wave: I may be able to implement this feature request
[ ] :warning: This feature might incur a breaking change

This is a :rocket: Feature Request

We have been using containers with no CPU Limit like this since the default was added, without having to use JsonPatch:
new Deployment(this, "default", {
    containers: [ {
        resources: {
            cpu: {
                request: Cpu.units(1),
            },
            memory: {
                request: Size.gibibytes(1),
                limit: Size.gibibytes(1),
            },
        },
    }],
});

But having no CPU Limit as the default would be great! On a side note, maybe also consider setting memory limit = memory request by default, to avoid pods getting OOM killed when a node gets full (see https://home.robusta.dev/blog/kubernetes-memory-limit).

@maybedino Are you sure there's no limit? Can you please check your Pod specs in your cluster to ensure that a default limit is not being applied for you?

consider setting memory limit = memory request by default, to avoid pods getting OOM killed when a node gets full

This is a good idea.

@maybedino Are you sure there's no limit? Can you please check your Pod specs in your cluster to ensure that a default limit is not being applied for you?

Sure, I checked. There are no CPU Limits, not in the generated YAML and not in the deployed pod. Using cdk8s-plus-25 2.4.23.
This is what I got:
> kubectl describe pod podname
(...)
Containers:
  (...)
    Limits:
      memory:  2Gi
    Requests:
      cpu:      1
      memory:   2Gi

Upon further review, I do not think a Cpu.UNLIMITED enum value is needed, since specifying only the CPU resource request has the effect of also removing any default CPU limit unless a limit is specified. So I would amend the request to remove the default CPU limit only.

Hi, any progress on this issue?
I am new to CDK8s but have several years of experience operating K8s.
I was a little confused by the cpu/mem default settings by CDK8s. IMO, it doesn't seems intuitive and natural that the default values do not match the pure K8s default values (nulls).
Slightly different from @otterley's perspective, but from the above, I agree with removing the default limits.

This is tricky because it is a breaking change. Perhaps we can have an App level setting to disable this, sort of a feature flag.


Select i18n mechanism

Choose which i18n mechanism we'll use for portal v2 (e.g. inbuilt/recommended mechanism or some external library). Whatever is best practice.

As we discussed on last Wednesday we will use ngx-translate
Reasons:

We have experience with it
Easy to configure
Organizing language keys and translations in nested JSON objects (angular/localize uses xuml)
Change language during runtime
Large community


zkey: use default benchmarked Argon2i with LUKS2

Argon2i is not only the winner of Password Hashing Competition,
it's meanwhile also officially recommended by RFC 9106.
So for Ubuntu we moved back from '--pbkdf pbkdf2' to the default (argon2i) a while ago.
The PR is to raise the discussion if this should not be generally the case?
More details can be found the rational can be found here:
https://bugs.launchpad.net/bugs/1820049
https://github.com/systemd/systemd/pull/14168
https://gitlab.com/cryptsetup/cryptsetup/-/issues/446
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=924560

The reason why we (still) use PBKDF2 here is documented within the comments you also remove with this PR:
Use PBKDF2 as key derivation function for LUKS2 volumes. LUKS2 uses Argon2i as default, but this might cause out-of-memory errors when multiple LUKS2 volumes are opened automatically via /etc/crypttab
Please also see here:

At the moment I would tend to not change this. The Out-of-memory errors mentioned above is 'real' , we have seen this in many situations. So I would like to keep the default as is, not forcing users to run into the memory failures by default.
For zkey use with secure keys, the password based key derivation function is of no or only very minimal relevance for security anyway. Secure keys are wrapped by the HSM master key, wich provides an much better protection that the wrapping by a key derived from a passphrase. So using a weaker password based key derivation function is no no security risk.

Hi, there is no doubt that there were real issues with "out-of-memory errors" - and we saw the reason and how it got faced in the code.
I think it's just worth discussing if these reasons still exist, or if were were meanwhile addressed, like esp. in:
https://github.com/systemd/systemd/pull/14168
https://gitlab.com/cryptsetup/cryptsetup/-/issues/446
With older (unpatched) versions, there is of course still a danger (and I assume that the latest code was not yet picked up by everyone), but we think if going with the latest, thinks should be fine.
(Btw, I haven't expected that this PR is accepted right away - it was opened as discussion item.
And "At the moment I would tend to not change this." is of course a fair statement ...)

Well, if the changes in cryptsetup and systemd really hinder this OOM from happening, then we might in deed consider changing zkey to no longer use PBKDF2, at least for upstream.
We then need to make sure that all distros that get this change (i.e. the s3909-tool version that includes the change), also have the changes for cryptsetup and systemd included. Can you tell which version of cryptsetup  and systemd got the changes?

Could you please also update the man page and explicitly mention why the low memory options are used? I would like to make sure users understand why we don't use the default. Maybe also re-add the comment in zkey/keystore.c to explain it there also.
Suggested man page update:
For LUKS2 volumes, the generated \fBcryptsetup luksFormat\fP contains
options \fB-\-pbkdf argon2i \-\-pbkdf\-memory 32 \-\-pbkdf\-force\-iterations 4
\fP for low memory and time requirements. Using the default \fBArgon2i\fP
options might cause out-of-memory errors when multiple encrypted volumes are
unlocked automatically at boot through /etc/crypttab. Because PAES uses secure
AES keys as volume keys, the security of the key derivation function used to encrypt
the volume key in the LUKS key slots is of less relevance.
.P

Suggestion for the comment in zkey7keystore.c:
			/*
			 * Use Argon2i as key derivation function for LUKS2
			 * volumes, but with options for low memory and time requirements.
			 * Using the default Argon2i options might cause out-of-memory
			 * errors when multiple LUKS2 volumes are opened automatically
			 * via /etc/crypttab
			 */

Also, please squash all commits together into just one single commit, and sign-off the commit properly (see https://github.com/ibm-s390-linux/s390-tools/blob/master/CONTRIBUTING.md).

Hi Ingo, I've just incorporated the outcome of the discussions and all the changes and force pushed.
Please have a look:
https://github.com/ibm-s390-linux/s390-tools/commit/dd6dd3f88dc26d6f3852edf089bed32b97af0397
https://github.com/ibm-s390-linux/s390-tools/compare/master...frank-heimes:argon2i?expand=1
Thx, Frank

Since @ifranzki approved, I've pulled the changes. Thanks for the contribution @frank-heimes.


Hololens 1 connecting on Rosbridge but not communicating both on topics and actions

[x] I am at the right place and my issue is directly related to ROS#. General technical questions I would post e.g. at ROS Answers or Stack Overflow. For library-specific questions I would look for help in the corresponding library forums.
[x] I have thoroughly read the Contributing Guideline and writing this issue is the right thing to do in my case.

I found a bug!

[x] I am using the latest ROS# version available here on the master branch.
[x] I am adding all required information, code and data files, screenshots and log files so that you can reproduce the problem.

I'm trying to communicate Hololens 1 with ROS. When I use the unity play everything is occuring as expected.When the project is build although the hololens are connected but there is no no communication,tried both topics and action messages.Both tried in build settings  .NET 2.0 and 4.x as well as VS2017 and VS2019.
I found a bug!

[ ] I am using the latest ROS# version available here on the master branch.

[ ] I am adding all required information, code and data files, screenshots and log files so that you can reproduce the problem.

My OS is:

My Unity Version is:

My ROS Distribution is:

My Build Target Platform is:

Hello @aioniosfoititis,
Have you tried the repo from @dwhit? Here is the link for UWP supported version for ROS#. Currently I am able to do two way communication of simple messages and action messages between ROS and a Unity application that is deployed to Hololens 1.

@berkayalpcakal Thanks for the quick reply.No I haven't noticed that that exists.Huge relief that there is actually support for that. I will test that  as soon as possible and come again to report if everything works fine.

Tried the modified version that you mentioned,but Im getting the following error when im trying to deploy the app to the hololens :"Failed to connect to device '<IP_ADDRESS>' using Universal Authentication".
That didnt happen before as with the default Unity3D Im deploying without a problem.

@berkayalpcakal Still the same result.Connection but no communication.
Is there any special step I should have done in order to make the system connect?
Im inserting Mixed Reality toolkit ,placing Ros Connector and eg fibonacci server and adding action name and ip address.
With the play button everything occurs with success.On the other hand when deployed in the hololens I can only notice a connection to the rosbridge but no subscribing to the fibonacci topics.

To anyone that listens,
As for the capabilities I'm using InternetClient, InternetClientServer and privateClientServer.
I also tried to not use the virtual machine and use an actual PC, but the problem still occurs.I can see message "one client connected" but no subscribing to any topics happens.
After that I tried the Export commands of ROS ( ip,hostname ,master uri ) but it didnt real overcome the problem.
Also tried the UWP version of the websocket in the RosConnector .
Anyone that has exei more suggestions please feel free to respond and I will give it a try.

To revive this a bit, ran into the same issues and was able to get around them by following this thread:
https://github.com/dwhit/ros-sharp/issues/3
Solution was to use @dwhit's fork and replace the Netwonsoft.json dll with the AOP one from the asset store here: https://assetstore.unity.com/packages/tools/input-management/json-net-for-unity-11347

I can also confirm the mentioned fix!

@helenol I tried exactly what you said and it does not work for me.

@aoboaten1 Can u name what are u using,unity version ,ros# version, ubuntu version?

@aoboaten1 Can u name what are u using,unity version ,ros# version, ubuntu version?
OS: WINDOWS 10
Unity Version : Unity 2019.2.20f1 (64-bit)
ROS Distribution : ROS Kinetic
I use use the @dwhit's fork and followed all instructions

Try 2019.3.1 for Unity as first debug step. I'm also using Kinetic. (Using
Hololens 2 though).
On Fri, Feb 28, 2020, 08:41 aoboaten1<EMAIL_ADDRESS>wrote:

@aoboaten1 https://github.com/aoboaten1 Can u name what are u
using,unity version ,ros# version, ubuntu version?
OS: WINDOWS 10
Unity Version : Unity 2019.2.20f1 (64-bit)
ROS Distribution : ROS Kinetic
I use use the @dwhit https://github.com/dwhit's fork and followed all
instructions
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/siemens/ros-sharp/issues/278?email_source=notifications&email_token=ABK3GCAA5PJ5YBOAREYTTX3RFC54LA5CNFSM4KFKBPU2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENHSSXI#issuecomment-592390493,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABK3GCCKR64UOLX4PKTCMT3RFC54LANCNFSM4KFKBPUQ
.

Try 2019.3.1 for Unity as first debug step. I'm also using Kinetic. (Using Hololens 2 though).
Yeah. I have used 2019.3.1 as well but it didnt work. I use hololens.
I went back to an old version of the Ros# I had downloaded and built with .net backend instead of  il2cpp and it worked

@aoboaten1  So if you are using .net backend you have probably used 2018.x version of unity as 2019.x does not support .net anymore ,If I recall correctly.

@aioniosfoititis Yes. I have about 4 versions on of unity on my laptop. I downloaded the newer version of the ros# and it wouldn't work so I went to my old laptop to use the old ros# i had and used 2018 unity version.

Hello, I am currently trying to do something like what has been discussed in this thread, however I have been having issues getting it to run properly. For reference I currently have my ROS nodes and topics running on a ubuntu computer connected to my network and running/building my unity in windows. Same thing as above, I get rosbridge connection, but no subcribing to topics. I'm running on windows 10 with Unity 2019.3.14f1 using ROS Melodic.
Thus far I have done the following:

Imported and set up the MRTK
Imported @dwhit version of ROS#
Imported JsonDotNet unity Package
Renamed initial ROS# Newtonsoft.Json.dll to NewtonsoftR.Json.dll to avoid dual file conflict
Moved AOT Newtonsoft.Json.dll and attached xml file into RosSharp/Plugins

In the MRTK build window I am using:
-build configuration: release

platform: x86

I am able to use the build and install method, However as stated previously, I get a rosbridge connection, but it does not subscribe to my image topic, and when run in Unity it works just fine. Any assistance would be greatly appreciated.

Hello @BloodRaine,
just asking for curiosity, have you tried .NET Serializer (preferably with WebSocketSharp protocol) instead of Newtonsoft serializer? You can see the corresponding settings in the RosConnector component.

@berkayalpcakal I have not, Any resources/ways to set that up?

I think the fork by @dwhit is old, so you need to adjust the new changes in the serialization interface (please see #292) to your code. Or, you can adjust the modifications done in that fork to the current ROS#, see my comment here. I hope this helps. I would be glad if you can comment your experiences regarding .NET Serialization tool with HoloLens here.

Just so that I am making sure I'm understanding you correcltly @berkayalpcakal, I can:

adjust the new serialization changes to @dwhit 's fork OR
reperform the modifications of the fork on the current ROS# master as a new fork
am I understaning that correctly? If so I will likely go with the second option as that would meke the most sense to me.

@berkayalpcakal after updating to the latest ros-sharp, and updating subscriber scripts to follow newer syntax for Messages -> MessageTypes and Subscriber -> UnitySubscriber, I get the error "ReflectionTypeLoadException ... etc" is this something that you have seen before?

This could help with the Reflection issue: https://github.com/siemens/ros-sharp/issues/201#issuecomment-646590687
I'm interested in your branch, could you upload it?

Yeah thats very true, after taking steps that were defined in some of the linked comment threads above, I managed to get around that issue using this fork of ros-sharp, however, I am running into some issues of certain namespaces not being found by the Newtonsoft.Json such as JsonConvert. @Jntzko  once I have a working system I plan to create my own fork/version, unless it would help in debugging what issues I am running into.

@Jntzko, have you managed to get a working connection with topic subscription/publishing? I think I have my dll's set properly, however, I am having other libraries throw issues. For my project I am using OpenCVForUnity and that seems to be having issues when my dll's are set properly. I haven't yet gone as far as to take ros-sharp and re-remove the reflection code as @EricVoll had previously done.

I didn't have it running yet, I use the current ros-sharp master branch and applied the changes from dwhits fork, but I can't connect to topics, even with the json-net-for-unity dll, independent of the serializer. I didn't applied the reflection fix yet, maybe that helps.

Hi guys,
I'll comment in 1-2 hours and give you some links. On mobile atm...
Maybe I can help :)

Thanks a lot for your detailed description, this definitely cleared up some things. ARbotics looks very interesting, I didn't new about that work.
Unfortunately, I can start integrating your suggestions in 2 weeks, but I'm pretty sure they will help a lot!

You were right @EricVoll, thanks a lot. I was able to publish to a topic from the HoloLens 2 emulator, I just copied the RosSharp and the plugin folder from the Assets of ARbotics. I don't have access to the real hardware right now.
My setup right now is:
Unity 2019.3.15f and MRTK 2.4.0

Happy to hear, that everything worked out so far. I exchanged a few messages today with @MartinBischoff who will probably/maybe add a link to the specific fork on the Ros# Readme under "Ros# for HoloLens" (or something similar)

I am still running into issues when trying to do the same. I am currently using the OpenCVForUnity Package and when I try the same method that @Jntzko tried, I get a sort of namespace or package error - 'Utils' does not contain defenition for (function name here) for multiple methods. I imagine it has something to do with dll's or plugins or something but I'm not certain.

I am still running into issues when trying to do the same. I am currently using the OpenCVForUnity Package and when I try the same method that @Jntzko tried, I get a sort of namespace or package error - 'Utils' does not contain defenition for (function name here) for multiple methods. I imagine it has something to do with dll's or plugins or something but I'm not certain.

I know the error. I guess you used my wrong ros-sharp fork by mistake.
In the meantime I updated the repository and also added a demo project. I'll edit the readme today with a full tutorial on how to start rosSharp on HoloLens

Oh thats perfect. My bad on using the wrong one. I got a bit confused with there being 2 in the Repo. Thanks for updating. I'll be sure to update to the new main. Thanks for the assistance!

Ok, I think it's mostly working. It is now successfully subscribing which is awesome progress! I'm hitting a Nullreference error that an object isnt instantiated, considering everything I have, and the amount of incoming nullReference messages, it is probably something in the subscriber that is trying to be accessed when the message is recieved. Have you run into something like this and have any tips for tracking it down further? Long shot on that one I know, just checking before I go digging for too terribly long.

Yes I experienced that as well but I forgot why.
Generally it's easy to find out that problem. Simply attach Visual Studio to Unity and start the Debugging Mode.
Or in the Unity-Console you'll see the NullReferenceException and double click it to get where the exception is thrown. It probably is obvious then.

I may be running it improperly as when I run it in debuggin gmode from VS on the device, I dont get any specifics like what object is Null or a line number, and Unity hasn't been giving me any errors when it is run.

So do you get the exceptions if the "game" is running on the holoLens, or while it is running in Editor Mode?
These NullReferenceExceptions usually also occur in Editor Mode.
I had them for some time somewhere in a Subscriber if I remember correctly.
What I did for another project was to do a "sneaky" thing: You can subscribe to the Unity Log-Output and add a string publisher that publishes the Log via a ROS-topic. Investing a bit of time upfront in things like this made our life much easier down the road while developing the app.
See the publisher and here is how to use it.
That way you can get Unity's Debug Logs while the app is deployed on the HoloLens.
Theoretically it is possible to attatch the VisualStudio Debugger to a running instance on HoloLens. But I keep forgetting how to do that - you might want to google that for a bit. Its easy once you found out how to...

So big picture I am using ROS to package up a Pointcloud as an image and send it to unity then render it, we need to do custom stuff with the point cloud so we cant just use the built in spacialization stuff. The app still works fin ine the Editor, and when I run it with "Start Debugging" in VS on the device, so on the hololense, In the bottom left here is a debug window. That was telling me there was a NullReference. But it still ran fine in the Editor. Subscribing to the Unity log might also be a useful thing for debugging for sure.

mhh that seems weird. But its a bit hard to help without the opportunity to look at the stuff myself.
I assume you thought of adjusting the IP-Adresses on the ROS-Connector to whatever your IP-adresses are right?
As I wrote above, try this: https://docs.microsoft.com/en-us/windows/mixed-reality/using-visual-studio#:~:text=Pairing your device,-The first time&text=On the HoloLens%2C generate a,HoloLens to dismiss the dialog.
With the steps explained in this article you can pair your HL with Visual Studio and live-debug with breakpoints etc.

Yep, I double checked the IP, I'll definately take a look at setting up the HL-VS debug with breakpoints Thanks for reminding me of the link to how to do that. I'll let you know the results

I was able to get my application working! The issue was that a shader I was using was registerred as Null. In my renderer, I attempt a Shader.find and that was coming back with nothing as I guess it may not be included in the build if nothing references it directly. The solution was to attach the shader to a material in the Resources folder. Thanks for the help. Looks like the data stream is a little slow so my next task will be to try to find a way to speed that up.

Great to hear! So in that case the issue wasn't Ros#.
If you have any further issues with ROS# please create issues over on the UWP fork.


Train all models before generated code

I've trained one model, and have 8 minutes of training left. We've already generated the code files, and have added the .zip file.

Expected Behavior: Code files should be generated once it's "Done" or when user click Stop Training and 1 or more models has been trained.

It should happen once it's "Done" or when they click Stop Training and 1 or more models has been trained.

Thanks! Will update the bug description to make clear it's a bug.

The code files should generate after the last model finishes training (when training is done).

@beccamc ,@JakeRadMSFT  @briacht   when we display the label for code behind ?

currently, we displayed all training results at the same time.

We should display after training is complete.

when does the user see generated files added to their project?

Generated files should be added to the project after training is done.

Start training
Training finishes
"Generated code behind files" label shows & generated code behind files are added to project

This issue not occurs on main branch: <IP_ADDRESS>7401


web: bool types are reported as "N/A" ?

e.g. https://github.com/vstakhov/libucl/blob/c8374381bab04f33f0000910acdf37593e343c99/include/ucl.h#L501
https://introspector.oss-fuzz.com/api/far-reach-but-low-coverage?project=libucl says:
"function-arguments":"['struct.ucl_object_s *', 'struct.ucl_object_s *', 'N/A']","function-name":"ucl_array_merge"

CC @DavidKorczynski


missing latest docker image of spotify_auth_proxy

Hello! I would like to use the latest spotify_auth_proxy codebase, would it be possible to upload a new version of the docker image please? I suppose it should be tagged as 0.2.7

It's been a while since I've looked into this. I think I wanted to move over to https://github.com/conradludgate/oauth2-proxy as a more generic and customisable solution. I no longer host it myself, however.
I will release a new image when your status handler is merged in


fix: detect autofill in chrome to enable login buttons

In #7024 @Koen-Nocore reported an issue about login submit buttons (next, submit) to shown as disabled when inputs are autofilled.
Indeed, I reproduced the issue with Chrome + Linux (not in Firefox + Linux). This question in Stack Overflow: https://stackoverflow.com/questions/11708092/detecting-browser-autofill explains the issue. It seems that if Chrome autofills an input the value of that input is empty until the user interacts with the page (e.g click) so Zitadel login JS helpers detect those inputs as empty and then the button is shown as disabled (but you can click on it).
I've added some of the suggested hack (https://gist.github.com/jonathantneal/d462fc2bf761a10c9fca60eb634f6977?permalink_comment_id=2901919) to the code. Now if a required input is autofilled an attribute isAutofilled is added to the input and the button is not disabled if that input is autofilled although its value is temporarily empty. Also that attribute is removed if we delete the autofilled input.
This is a video showing the proposed behavior:
https://github.com/zitadel/zitadel/assets/30386061/3c50a13e-bc29-46b2-971a-da0c17e76cc1
Hope this hack is good enough
Should close #7024
Definition of Ready

[X] I am happy with the code
[X] Short description of the feature/issue is added in the pr description
[X] PR is linked to the corresponding user story
[X] Acceptance criteria are met
[ ] All open todos and follow ups are defined in a new ticket and justified
[ ] Deviations from the acceptance criteria and design are agreed with the PO and documented.
[X] No debug or dead code
[X] My code has no repetitions
[ ] Critical parts are tested automatically
[ ] Where possible E2E tests are implemented
[ ] Documentation/examples are up-to-date
[ ] All non-functional requirements are met
[X] Functionality of the acceptance criteria is checked manually on the dev system.

thx a lot @doncicuto should we add -webkit-autofill to support the vendor prefixed version? 🤔

Hi @peintnermax, I agree I've added the -webkit-autofill to input_base.scss so we ensure the hack is applied to as much browsers as possible.

Hi @peintnermax, I agree I've added the -webkit-autofill to input_base.scss so we ensure the hack is applied to as much browsers as possible.

amazing thx 🙏


[BEAM-10402] Supress nullness and keyfor DoFnOperatorTest warnings.

Fixes broken compile from https://github.com/apache/beam/pull/13521

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[ ] Choose reviewer(s) and mention them in a comment (R: @username).
[ ] Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
[ ] Update CHANGES.md with noteworthy changes.
[ ] If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI.

Run Java PreCommit

Run Java PreCommit

R: @mxm

Merging without waiting for approval as this fixes master build.

Thanks for following up!


Update Quickstart for CC Free (beta)

Closes #9254, #8028.

This change is

This change is

@kannanlakshmi - adding you as the reviewer here but let me know if a different PM and/or eng should review. Not sure who should be reviewing for technical accuracy here.

@kannanlakshmi - adding you as the reviewer here but let me know if a different PM and/or eng should review. Not sure who should be reviewing for technical accuracy here.

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4a403874e7f9ec69d2fbeebbf696c2fc102afe6b/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/4a403874e7f9ec69d2fbeebbf696c2fc102afe6b/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/26a0e9ab40463698d0976ae265648f4c43965b59/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/26a0e9ab40463698d0976ae265648f4c43965b59/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8e8736661c2280043f6372029c2c3a813344cd63/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8e8736661c2280043f6372029c2c3a813344cd63/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e11be96518a4acb1f3bcd665efb77fe0d7d99098/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/e11be96518a4acb1f3bcd665efb77fe0d7d99098/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cb48117f952d786bb6ef50975f4f1a089e9a41c2/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/cb48117f952d786bb6ef50975f4f1a089e9a41c2/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8f7f5ce1cc24a6f238879c22c40aaae62bac7d99/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/8f7f5ce1cc24a6f238879c22c40aaae62bac7d99/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/68c2bef8ee4d63e14d4395a5e50668da4ba11e3e/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/68c2bef8ee4d63e14d4395a5e50668da4ba11e3e/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6212d8bfe34deba84b359eb4a9c0ec86a18d68a7/
Edited pages:

cockroachcloud/quickstart.md

Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6212d8bfe34deba84b359eb4a9c0ec86a18d68a7/
Edited pages:

cockroachcloud/quickstart.md


Update README.md

Adding Salish Sea Wiki to 'Environmental Knowledge Platforms'.

Thanks for adding this project. I was in this region 20 years ago and it was one of the most beautiful experiences in my life. Really inspiring.


input.Handler needs to keep track of edit offsets between calls to Apply

When Apply is called on input.Handler, another Apply can be called using old positions.  input.Handler should be more aware of the context of the edits and be careful to update any edits that are queued up based on old positions.

This actually appears to have been more related to gxui's built in caret management.  When I updated the input.Handler and cursor.Mover so that the cursor.Mover updates cursors in the input.Handler's Apply method, this stopped happening.
I'll reopen if it shows up again.


Update doc related to PulseAudio bug

Changes
Soften PulseAudio bug phrasing to be specific about pyglet < 2.0.10 since @Square789 seems to have fixed the bug in question.

The issue is not yet fixed in 2.0.10; I think it's enough to change mentions of the version to 2.0.11, assuming the PR makes its way into there successfully.


correct go-redis package url and update licenses

What does this PR do?
Per https://uptrace.dev/blog/go-redis-v9.html, go-redis package location changed with v9. This causes a problem when trying to use dependencies as a go module, which is required to use otel components like infraattributesprocessor as a external module.
Motivation
error when trying to create go module
Describe how to test/QA your changes
run unit/integration/pipeline tests
Possible Drawbacks / Trade-offs
possibility that the api being called was different than what is intended (this is for sure the correct go-redis package link, though)
Additional Notes

/merge


Unzip with overwrite existing files

What You Are Seeing?
i have folder with many files , then i want extract some dlls inside it
if files exist unzip failed
What is Expected?
i wanna unzip with options for decision override files
What version of Cake are you using?
Are you running on a 32 or 64 bit system?
64
What environment are you running on?  Windows? Linux? Mac?
windows
Output Log
the file xxxxxx already exists

Currently we just use the .NET Build in ZipFile.ExtractToDirectory, it doesn't have en overload that allows you to overwrite files.
something special like a ZipFile.OpenRead would have to be used and iterate over each entry in the archive and use the extension methods ZipFileExtensions.ExtractToFile(this ZipArchiveEntry source, 	string destinationFileName, bool overwrite) with overwrite set to true. So doable would need a bit of refactoring.

@MohsenAra I haven't checked, but it might be worth looking at this addin https://github.com/akordowski/Cake.Compression to see if it provides the functionality that you are looking for.

thanks  @gep13
its ok

I just hit this problem too.
@devlead An overload for overwriting was added to .NET 8 if that's helpful?
https://learn.microsoft.com/en-us/dotnet/api/system.io.compression.zipfile.extracttodirectory?view=net-8.0#system-io-compression-zipfile-extracttodirectory(system-string-system-string-system-text-encoding-system-boolean)


DO you have update on 6.45 mikrotik API

Sure, it works with new login method for 12 month already: https://github.com/Chupaka/Delphi-RouterOS-API/releases/tag/v1.3


⚠ Bofrost.fr has degraded performance

In 0d37bf9, Bofrost.fr (https://www.bofrost.fr) experienced degraded performance:

HTTP code: 200
Response time: 811 ms

Resolved: Bofrost.fr performance has improved in e6f2d4e after 6 minutes.


Some issue in scripts

I found that scripts in ChromGene is not suitable for nonmodel organism, liking plants and so on. I hope that the authors can improve these scripts.
In addition, when running the "chromgene_posteriors_to_components.py" scripts, some error happened as follows,
"Traceback (most recent call last):
File "./ChromGene/scripts/chromgene_posteriors_to_components_xma.py", line 146, in
main()
File "./ChromGene/scripts/chromgene_posteriors_to_components_xma.py", line 85, in main
component_assts = get_component_assts_from_posteriors(file_path, args.states_per_component)
File "./ChromGene/scripts/chromgene_posteriors_to_components_xma.py", line 22, in get_component_assts_from_posteriors
per_component_posteriors = posteriors_arr[:, :-1].reshape(len(posteriors_arr), -1, states_per_component).sum(axis=-1)
ValueError: cannot reshape array of size 1456462 into shape (104033,newaxis,3)".
Thanks for your help!

I found that scripts in ChromGene is not suitable for nonmodel organism, liking plants and so on. I hope that the authors can improve these scripts.

I'm sorry, how do you mean? The code should be agnostic of organism, and indeed does not use organism information anywhere. Are you having trouble?
Can you please provide the full length of commands you ran, and some example data so that I can reproduce the error?

Cannot reproduce error


Heat and Gnocchi check_http returns header x-openstack-request-id not found

I am getting failed http checks on Heat and Gnocchi.
When I manually run heat checks, I see:
/usr/lib/nagios/plugins/check_http -H REDACTED -p 8004 -u /v1 -e Unauthorized -d x-openstack-request-id
HTTP CRITICAL: Status line output matched "Unauthorized" - header 'x-openstack-request-id' not found on 'http://REDACTED:8004/v1' - 398 bytes in 0.005 second response time |time=0.004638s;;;0.000000;10.000000 size=398B;;;0
If I curl that same URL, I can see response will be Unauthorized since I do not have a keystone token, however header comes as 'X-Openstack-Request-Id' rather than 'x-openstack-request-id'.
$ curl -v -XGET http://REDACTED:8004/v1
Note: Unnecessary use of -X or --request, GET is already inferred.

Trying REDACTED...
TCP_NODELAY set
Connected to REDACTED port 8004 (#0)

GET /v1 HTTP/1.1
Host: REDACTED:8004
User-Agent: curl/7.58.0
Accept: /

< HTTP/1.1 401 Unauthorized
< Content-Type: application/json
< Content-Length: 114
< Www-Authenticate: Keystone uri='http://REDACTED:5000/v3'
< X-Openstack-Request-Id: req-c55aae88-633d-4e5f-a7cb-e4340abdc0c9
< Date: Mon, 13 May 2019 05:23:24 GMT
<

Connection #0 to host REDACTED left intact
{"error": {"message": "The request you have made requires authentication.", "code": 401, "title": "Unauthorized"}}

For Gnocchi, I see a different failure on check_http:
/usr/lib/nagios/plugins/check_http -H REDACTED -p 8041 -u / -e Unauthorized -d x-openstack-request-id
HTTP CRITICAL - Invalid HTTP response received from host on port 8041: HTTP/1.1 200 OK
Curl exchange shows that x-openstack-request-id does not come back on the response:
$ curl -v -XGET REDACTED:8041/v1
Note: Unnecessary use of -X or --request, GET is already inferred.

Trying REDACTED...
TCP_NODELAY set
Connected to REDACTED port 8041 (#0)

GET /v1 HTTP/1.1
Host: REDACTED:8041
User-Agent: curl/7.58.0
Accept: /

< HTTP/1.1 401 Unauthorized
< Date: Mon, 13 May 2019 05:29:24 GMT
< Server: Apache/2.4.29 (Ubuntu)
< WWW-Authenticate: Keystone uri='http://REDACTED:5000'
< Content-Length: 114
< Content-Type: application/json
<

Connection #0 to host REDACTED left intact
{"error": {"code": 401, "title": "Unauthorized", "message": "The request you have made requires authentication."}}

I suggest that, instead we look for WWW-Authenticate or only Unauthorized, which means we've found Heat/Gnocchi endpoints but have no right to access.

(by aluria)
Thank you for the report. There is another fix waiting to be reviewed and merged, which will split the endpoints checks when tls is enabled (we now check for TLS certificate expiration time).
Nevertheless, I verified what you mention and all other endpoints use lowercase except Heat. MP now fixes this, and I've also removed the heat-cnf which failed with error 400 due to not following AWS protocol.
I've asked for a review and I hope we will land this fix tomorrow.
Cheers,
-Alvaro.

(by afreiberger)
I've identified that xenial-ocata versions of heat do not return the X-Openstack-Request-Id.  I'm submitting a fix to remove the check for this header for heat.