Inst synthesis

The synthesis code base grows and I think it's time to review this patch so that others also understand the core algorithm and its peculiarities. Please comment on everything that is unclear so I can improve both the code and the documentation. Please read the commit message from 8b5e5fd that contains instructions for synthesis invocation and usage. The main difference from that commit is that now there is no API and the synthesis is iterative, i.e., it starts with zero components (nop synthesis) and proceeds until it reaches the max num of components specified via cmd or the LHS cost minus one. If no max components were specified, it will try to use the whole component library (or all components specified via cmd).

I also highly encourage to watch the synthesis in action using the -souper-debug-synthesis flag. For examples, have a look at test cases in test/Infer/*-syn.* and test/Infer/HackersDelight.

Google » souper #462 SUCCESS
This pull request looks good
(what's this?)

Fascinating! One silly question, what's nop synthesis? Thanks.

Yang, nop synthesis is what we call it when Souper finds an optimization that doesn't require adding any instructions at all because the required value is already available. For example:
%0:i32 = var
%1:i32 = lshr %0, 16:i32
%2:i64 = zext %1
%3:i64 = and 255:i64, %2
%4:i32 = lshr %0, 24:i32
%5:i64 = zext %4
%6:i64 = shlnw %5, 8:i64
%7:i64 = or %3, %6
infer %7
result %2

@regehr nitpicking: The synthesis in the example above found a sequence of two instructions that was in the original LHS too. For me, nop synthesis is rather the following opt where one of the inputs is wired to the output directly:
%0:i32 = var
%1:i64 = var
%2:i64 = lshr %1, 3:i64
%3:i32 = trunc %2
%4:i1 = ult %0, %3
%5:i32 = sub %0, %3
%6:i32 = select %4, 0:i32, %5
%7:i1 = slt 0:i32, %6
pc %7 1:i1
%8:i1 = ult %3, %0
%9:i32 = select %8, %0, %3
infer %9
result %0

In the synthesis code, this is how nop synthesis is defined, i.e., find an opt using zero components.

Well... I'm not sure it matters whether the result refers to a var or to an instruction -- either way, some LLVM instructions have been elided, as opposed to being expressed using a different instruction sequence.

@regehr ok, let's agree then when a sequence of synthesized instructions is in the LHS, it's a nop. It can be found using 0 or more components.

Well generally this looks great. Since it has minimal impact on Souper code that runs in non-synthesis mode, I don't see any reason not to take this patch. It would be good for @pcc and @chenyang78 to look it over as well.
Once this lands, I'll revive my synthesis code in the pass. I do not believe that will be a huge amount of work.

Thanks for the review @regehr, I'll address them on Monday.

Google » souper #463 SUCCESS
This pull request looks good
(what's this?)

Google » souper #464 SUCCESS
This pull request looks good
(what's this?)

Google » souper #465 SUCCESS
This pull request looks good
(what's this?)

Google » souper #466 SUCCESS
This pull request looks good
(what's this?)

Google » souper #467 SUCCESS
This pull request looks good
(what's this?)

Google » souper #468 SUCCESS
This pull request looks good
(what's this?)

Thanks for the comments @chenyang78 @pcc @regehr, I addressed all of them. If you have time, please have a look. If there are no further objections, we should merge it ASAP so that @regehr can add the Pass support.

I don't have any concern at the moment. Again, thanks for putting this together, Raimondas and John.

Thanks @chenyang78. @regehr hit a tricky bug yesterday, that I haven't seen so far. I'll have to do more testing.

Google » souper #469 SUCCESS
This pull request looks good
(what's this?)

@regehr I addressed the bug, you can start testing. Please let me know once you are LGTM with the patch, so I can merge.

Google » souper #470 SUCCESS
This pull request looks good
(what's this?)

Google » souper #471 SUCCESS
This pull request looks good
(what's this?)

@regehr I squashed the commits and ran tests in Debug/Release modes. Please have a final look and merge.

I am getting this from a Debug build:
regehr@ulam:build{inst-synthesis}$ make check
[  2%] Built target profileRuntime
[ 45%] Built target souperPass
[ 47%] Built target souperSMTLIB2
[ 50%] Built target souperInfer
[ 52%] Built target souperInst
[ 75%] Built target kleeExpr
[ 81%] Built target souperExtractor
[ 83%] Built target souperTool
[ 85%] Built target souperKVStore
[ 87%] Built target souperParser
[ 89%] Built target souper
[ 91%] Built target parser-test
[ 93%] Built target souper-check
[ 95%] Built target extractor_tests
[ 97%] Built target inst_tests
[100%] Built target parser_tests
FAIL: Souper :: Infer/signs-syn.opt (70 of 151)
******************** TEST 'Souper :: Infer/signs-syn.opt' FAILED ********************
Script:
--
/home/regehr/souper-rsas/build/souper-check -z3-path=/usr/bin/z3 -infer-rhs -souper-infer-inst -souper-synthesis-comps=const,slt,xor /home/regehr/souper-rsas/test/Infer/signs-syn.opt > /home/regehr/souper-rsas/build/test/Infer/Output/signs-syn.opt.tmp1
/home/regehr/souper-rsas/third_party/llvm/Debug/bin/FileCheck /home/regehr/souper-rsas/test/Infer/signs-syn.opt < /home/regehr/souper-rsas/build/test/Infer/Output/signs-syn.opt.tmp1
--
Exit Code: 1

Command Output (stderr):
--
/home/regehr/souper-rsas/test/Infer/signs-syn.opt:6:10: error: expected string not found in input
; CHECK: %9:i32 = xor %0, %2
         ^
<stdin>:1:1: note: scanning from here
; Failed to infer RHS
^
<stdin>:1:6: note: possible intended match here
; Failed to infer RHS
     ^

--

********************
Testing Time: 70.59s
********************
Failing Tests (1):
    Souper :: Infer/signs-syn.opt

  Expected Passes    : 134
  Unsupported Tests  : 16
  Unexpected Failures: 1
make[3]: *** [CMakeFiles/check] Error 1
make[2]: *** [CMakeFiles/check.dir/all] Error 2
make[1]: *** [CMakeFiles/check.dir/rule] Error 2
make: *** [check] Error 2
regehr@ulam:build{inst-synthesis}$

Weird, no failures here. z3 version?

Weird, I don't know. My z3 was a bit old (unstable from last fall) but I upgraded to unstable as of right now (it calls itself 4.4.0) and still run into the same problem.

Here's the raw command:
$ /home/regehr/souper-rsas/build/souper-check -z3-path=/usr/bin/z3 -infer-rhs -souper-infer-inst -souper-synthesis-comps=const,slt,xor /home/regehr/souper-rsas/test/Infer/signs-syn.opt
; Failed to infer RHS

I fetched a fresh copy of my branch and ran the same command:
$ ./souper-check -z3-path=`which z3` -infer-rhs -souper-infer-inst -souper-synthesis-comps=const,slt,xor ../test/Infer/signs-syn.opt
; RHS inferred successfully
%9:i32 = xor %0, %2
%10:i1 = slt %9, 0:i32
result %10

Z3 version 4.4.0 from unstable branch.

Did you update my 'inst-synthesis' branch?

I did a clean commit and a rebase to master. The only thing I'm not sure is the buildGEP part, see comment above. @regehr please do a fresh checkout of my inst-synthesis branch and run all test cases again. On my machine building and testing in Debug/Release modes didn't show any problems.

Google » souper #472 SUCCESS
This pull request looks good
(what's this?)

The test failure was from a fresh checkout and build of your branch on my Ubuntu 14.04 machine at work. I'm home now and will see what happens here.

I see the same thing at home. You've definitely tried a Debug build?

Google » souper #473 SUCCESS
This pull request looks good
(what's this?)

I got the same error in the Release build (haven't tried Debug version yet)
/home/chenyang/work/souper_fork/souper_ras/build_release/souper-check -z3-path=/home/chenyang/other_programs/z3/build/z3 -infer-rhs -souper-infer-inst -souper-synthesis-comps=const,slt,xor /home/chenyang/work/souper_fork/souper_ras/test/Infer/signs-syn.opt > /home/chenyang/work/souper_fork/souper_ras/build_release/test/Infer/Output/signs-syn.opt.tmp1
/home/chenyang/work/souper_fork/souper_ras/third_party/llvm/Release/bin/FileCheck /home/chenyang/work/souper_fork/souper_ras/test/Infer/signs-syn.opt < /home/chenyang/work/souper_fork/souper_ras/build_release/test/Infer/Output/signs-syn.opt.tmp1
--
Exit Code: 1

Command Output (stderr):
--
/home/chenyang/work/souper_fork/souper_ras/test/Infer/signs-syn.opt:6:10: error: expected string not found in input
; CHECK: %9:i32 = xor %0, %2
         ^
<stdin>:1:1: note: scanning from here
; Failed to infer RHS
^
<stdin>:1:6: note: possible intended match here
; Failed to infer RHS
     ^

I am using z3 4.3.1.

This test case is problematic, I removed it in my last squashed commit.

I see. Thanks!

Google » souper #474 SUCCESS
This pull request looks good
(what's this?)

Google » souper #475 SUCCESS
This pull request looks good
(what's this?)

Google » souper #476 SUCCESS
This pull request looks good
(what's this?)

Google » souper #477 SUCCESS
This pull request looks good
(what's this?)

Google » souper #478 SUCCESS
This pull request looks good
(what's this?)

Google » souper #479 SUCCESS
This pull request looks good
(what's this?)

Google » souper #480 SUCCESS
This pull request looks good
(what's this?)

Google » souper #481 SUCCESS
This pull request looks good
(what's this?)

other than issues just noted, LGTM -- please look over them and then squash and merge

@regehr thanks for the review! I addressed your comments in c7e4777. In addition, I removed addConstraints (I think it's better to have it in the main function) and introduced TrueConst in the main function to avoid redundant calls to IC.getConst(APInt(1, true)). All test cases in Debug/Release modes with both KLEE versions are passing. Please have a short look at the last commit and then I'll merge it.

Google » souper #482 SUCCESS
This pull request looks good
(what's this?)

Looks good, please squash and merge.

Google » souper #483 SUCCESS
This pull request looks good
(what's this?)


Availability of a 3.17 Community Edition ?

Hi,
When do you plan to release a 3.17 community edition ?
can we consider that the development branch is a valid solution to build a 3.17 version ?
Best regards,

Hi,
I just downloaded and install the community version at
https://community.meteorite.bi/
I made the usual changes in tomcat/webapps/ROOT/embed/embed.html

put valid card paths
add the following js line : 	$.post( "http://localhost:8080/saiku/rest/saiku/session/", { username: "admin", password: "admin" } ); before the execute() calls,

and it seems that embed is working again !
Thank you !
PS : without the post, embed works only when admin is already connected on the UI


boardd: Add new functions usb_read, usb_write

it seems that there are many inappropriate flag 0xc0 used for write operation. although it does not affect the result, their value should be 0x40
Add functions usb_read and usb_write to fix this problem and make the code clearer.

Indeed, bmRequestType is technically wrong, but not checked in the panda.


Initialiaze the time and stop

When I stop the timer it still count in the background and on resume it continues from that point and not at the stop time
function getReady() {
    return new Date(new Date().valueOf() + 60 * 60 * 1000);
  }
  var $clock = $('#clock');
  $('#clock').countdown(getReady(), function(event) {
    $(this).html(event.strftime('Time left to escape %H:%M:%S'));
  });

  $('#btn-pause').click(function() {
    $clock.countdown('stop');
  });
  $('#btn-resume').click(function() {
    $clock.countdown('start');
  });
  $('#btn-reset').click(function() {
    $clock.countdown(getReady());
  });

Thank you

Hello you can reproduce the same behaviour in the bootstrap example if you pause on resume skips the paused time.

Well I see where you heading, but in matter of fact the stop/start doesn't work that way, the function will only stop the interval and not update the final date! You should apply that logic yourself:
var startDate = new Date(2015, 12, 24),
    pauseDate;

var $clock = $('#clock').countdown(startDate);

$('#btn-pause').click(function() {
    pauseDate = new Date();
});
$('#btn-resume').click(function() {
    var timedelta = new Date().getTime() - pauseDate.getTime(); // Elapsed time since the pause
    var correctedDate = new Date(startDate.getTime() + timedelta);
    $clock.countdown(correctedDate);
});

A better answer than that is that I cannot stop the time we all are bound to it, so thats why the countdown "jumps" after resume :grin:

Ohhh!!! sorryy I thought you could ;-)
Great job hilios thank you very much for your help. :-)

$('#btn-pause').click(function() {
                    $clock.countdown('stop'); // add this
                    pauseDate = new Date();
                  });


Executing single commands from PowerToys Run

📝 Provide a description of the new feature
What is the expected behavior of the proposed feature?  What is the scenario this would be used?
The idea is to execute a command intered into the PowerToys Run box, much like when you type something in the Windows Search Bar and press enter. This would allow for quick single-command actions, such as quickly killing a frozen process by just typing a taskkill command, or to quickly shutdown by typing a shutdown command.
Once again, it's pretty much the same functionality the start menu's search bar has, just type, enter, executed.
If you'd like to see this feature implemented, add a 👍 reaction to this post.

I didn't realize the feature already existed by adding > in the front. My bad.


Rename SimpleObjectAdapter

Rename of SimpleObjectAdapter to ObjectAdapter (more in line with upcoming support for dynamic)

Hi @KevinDockx, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
The agreement was validated by Microsoft Open Technologies, Inc. and real humans are currently evaluating your PR.
TTYL, MSOTBOT;

Missing 2 changes - new PR will be created


renamed copy for exception's underlying term

#192

Codecov Report

Merging #194 (ae8b7da) into main (002821b) will decrease coverage by 0.03%.
The diff coverage is 95.49%.

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
- Coverage   96.22%   96.18%   -0.04%
==========================================
  Files          20       20
  Lines        6250     6243       -7
==========================================
- Hits         6014     6005       -9
- Misses        196      198       +2
  Partials       40       40

Impacted Files
Coverage Δ

engine/builtin.go
94.41% <91.71%> (-0.01%)
:arrow_down:

engine/exception.go
99.00% <98.55%> (-1.00%)
:arrow_down:

engine/clause.go
97.82% <100.00%> (ø)

engine/iterator.go
100.00% <100.00%> (ø)

engine/number.go
100.00% <100.00%> (ø)

engine/stream.go
100.00% <100.00%> (ø)

engine/vm.go
82.74% <100.00%> (ø)

interpreter.go
94.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 002821b...ae8b7da. Read the comment docs.


Repro-Build: jdk-18 jdk.javadoc not always deterministic due to missing element-list- txt files

A intermittent problem with the make dependencies means the jdk.javadoc element-list-.txt generation can remove the src defined element|package-list-<7,8,9,10>.txt files. Is easily recreatable by using --with-jobs=1 causing jdk.javadoc "gendata" to always occur after "java" module build dependency.
Fix: https://github.com/andrew-m-leonard/jdk-1/commit/dbc32c117238b329c2044d6e13aa92280ea7d47c

@andrew-m-leonard Oh, you found the cause for this! That's great! We just closed https://bugs.openjdk.java.net/browse/JDK-8276654. Do you think you can reopen it and offer your fix for it?

@andrew-m-leonard Oh, you found the cause for this! That's great! We just closed https://bugs.openjdk.java.net/browse/JDK-8276654. Do you think you can reopen it and offer your fix for it?

@magicus sure, in-progress: https://github.com/openjdk/jdk/pull/6278

Fixed upstream: https://github.com/openjdk/jdk/pull/6278


[bug]: Stacked Cli Unhandled exception from telemetry

Describe the bug
While running stacked create it throws the below exception.
 stacked create view -t web batch

Unhandled exception:
FileSystemException: lock failed, path = '/Users/henriquedn/.config/stacked/telemetry_config.lock' (OS Error: Resource temporarily unavailable, errno = 35)
#0      _checkForErrorResponse (dart:io/common.dart:55:9)
#1      _RandomAccessFile.lock.<anonymous closure> (dart:io/file_impl.dart:1023:7)
<asynchronous suspension>
#2      StorageBackendVm.initialize (package:hive/src/backend/vm/storage_backend_vm.dart:81:5)
<asynchronous suspension>
#3      HiveImpl._openBox (package:hive/src/hive_impl.dart:111:9)
<asynchronous suspension>
#4      HiveImpl.openBox (package:hive/src/hive_impl.dart:142:12)
<asynchronous suspension>
#5      PosthogService.init (package:stacked_cli/src/services/posthog_service.dart:44:12)
<asynchronous suspension>
#6      setupLocator (package:stacked_cli/src/locator.dart:27:3)
<asynchronous suspension>
#7      main (file:///Users/henriquedn/.pub-cache/hosted/pub.dev/stacked_cli-1.12.6/bin/stacked.dart:18:3)
<asynchronous suspension>

To reproduce
Run any of the stacked cli commands in the project
Additional Context
I normally solve it by deleting both the telemetry_config.hive & telemetry_config.lock files.
This works for the terminal session. But for some reason it keeps coming back.
This happens for both when you accept or decline  collect ion anonymous  usage statistics.
While I have been getting this error for a while now and solving it as above, thought it best to report it and hopefully it can be resolved.
Thank you for this awesome project.

Same issue here

@ferrarafer possible to look into this soon?

Hello @Henriquedn @raphasampaio , hope you are doing well.
Can you please provide me with the permissions of the following resources?
Folder: /Users/henriquedn/.config/stacked
File: /Users/henriquedn/.config/stacked/telemetry_config.lock

You can check them with ls -la command.

But for some reason it keeps coming back.

The reason is that we need to save in the local storage the decision you made about telemetry, if not is like starting again over and over.

@Henriquedn @raphasampaio we released a new version, please update stacked cli and let me know if you still have problems.

@Henriquedn @raphasampaio we released a new version, please update stacked cli and let me know if you still have problems.

I have tested this over the two weeks and I the issue seems to be fixed. Thank you very much.


Monitoring - the project monitoring should be auto-disabled after upgrading from v2.2.1 to v2.2.4-rc5

What kind of request is this (question/bug/enhancement/feature request):
Bug
Steps to reproduce (least amount of steps as possible):

run rancher v2.2.1
add an ec2 cluster
add a project and enable the project monitoring
upgrade to v2.2.4-rc5

Result:

the project monitoring is still enabled and the app project-monitoring still exits and  shows upgrade available

Expected Result:

the project monitoring should be auto-disabled

We will release note it for 2.2.4

Closing the issue; added to the ReleaseNotes TODOs


Excluding ResetPeakMemoryUsage on openj9

This PR is to exclude hotspot related jdk_management test on openj9.
java/lang/management/MemoryMXBean/ResetPeakMemoryUsage.java - exclusion on openj9 for jdk11

Thanks @psoujany, some initial questions:

is this specific to jdk11 (if applicable also to jdk16+, should also update those files)?
is there an open issue that can be referenced (as in future we will have automation to verify if issue is closed, and can re-include test.  If the URL is unreachable/internal, automation will not work)?

Is ResetPeakMemoryUsage a part of jdk_management  test? This test target is excluded for openj9 https://github.com/AdoptOpenJDK/openjdk-tests/blob/master/openjdk/playlist.xml#L753 as part of https://github.com/eclipse/openj9/issues/10757
Do we have a plan to re-enable jdk_management  after this PR? If not, maybe we do not need the problem list exclusion.

Hi @ShelleyLambert

This test exclusion is specific to openj9. So, yes this change would be applicable to other releases as well. I'll make changes to releases.
Yes, there's an open issue which is raised in internal repo i.e, openj9-openjdk-jdk11-zos/issues/454.

Thank you.

Hi @llxia
Yes, ResetPeakMemoryUsage is a part of jdk_management test. We don't have any plan to re-enable jdk_management after this PR. There's an open issue for this testcase in openj9-openjdk-jdk11-zos/issues/454, as part of fixing the issue we need this test exclusion.
This testcase is also not supported on openj9, so even in future enabling jdk_management this testcase would fail. Hence exclusion would be valid fix.

This testcase is also not supported on openj9, so even in future enabling jdk_management this testcase would fail. Hence exclusion would be valid fix.

So it sounds like in this case that this is a permanent exclude (the test case is not valid for openj9).  For permanent excludes, then please change the URL from the internal one (runtimes/openj9-openjdk-jdk11-zos/issues/454) that we have no visibility of to https://github.com/AdoptOpenJDK/openjdk-tests/issues/1297.
I see the confusion, when I referred to 'open issue' I meant an issue in an open-source repo (not an internal repo) that is visible to everyone (and can be queried by automation we will run from the open-source projects).  :)

Hi, @ShelleyLambert. I applied change as you mentioned to all releases i.e, jdk11+. Please review the changes. Thank you.

@llxia - anything further updates you would like to see on this PR, or are we good ?


dep fails if there is directories in repo for which I have no permissions for

The error looks like:
gps.ListPackages: open /home/moroz/project/workspace/src/github.com/docker/docker/bundles/1.14.0-dev/test-integration-cli/d138d4097b2cb/root: permission denied

Hm, yeah, I suppose there's not much we can do here. Better to just make it transparently ignore such directories.
The fix for this is going to be entirely over in gps (sdboyer/gps#154)

@sdboyer yeah, ignore would be ok(with warning).
Thanks!

Warnings are a tricky with this, as the work here is done by gps, and we can't print directly from the library. I've added it to the running list I have, though - sdboyer/gps#77

This is now fixed in gps. I'm going to try to finish the last things in the next gps milestone before updating dep, so that we can get off the branch dependency. Couple days, I think.

Should be fixed now (actually, back when #205 was merged). Do you mind retrying the case that gave you trouble?

I have no permission error now, but I think now it's not even reaching that point. Will try later.

It should just skip over a dir the user lacks access to. If the change is causing issues on directories you DO have access to, though, then there's certainly something wrong...let me know!

I think this is fixed, so closing it out. Please reopen if need be


pybot command on Windows8 showing 'C:\Python27\python.exe: cannot import name is_dict_like'

C:\Users\sbhargava>python --version
Python 2.7.9
C:\Users\sbhargava>pybot
C:\Python27\python.exe: cannot import name is_dict_like

C:\Users\sbhargava>rebot
C:\Python27\python.exe: cannot import name is_dict_like

C:\Users\sbhargava>jython
Jython 2.5.3 (2.5:c56500f08d34+, Aug 13 2012, 14:48:36)
[Java HotSpot(TM) 64-Bit Server VM (Oracle Corporation)] on java1.7.0_75
Type "help", "copyright", "credits" or "license" for more information.

quit()

Installation seems to be broken somehow. Which Robot Framework version you are using? How did you install it?

No new info in 8 days. Closing.


HingeJoint - Lower angular limit not taken in account

Godot 4.0.2
Windows 10
Intel(R) Core(TM) i7-7700K CPU
Nvidia 2080 Super
HI, I'm not 100% this is a bug or a misconfiguration from me.
The behaviour of hinge joints is quite different between the two physics engines, this is expected i guess.
The problem is that the lower angular limit does not seem to apply with the jolt engine.
Please check the MRP
test-hinge-godot-jolt.zip
Switch between the two engines

Thanks ! I didn't read the warning thouroughly and i thought it was the same as the one for the upper limit


Default selected_allen_id is entire brain, support None

It's not working consistently for me- initializing with selected_allen_ids=[] still shows all the regions, and then turning it off again still leaves the surfaces on. I've also noticed more crashing based on WebGL (maybe a coincidence though).  I'll take another look at it shortly.


[alpaka] Add alpaka WorkDiv helpers

Add Alpaka WorkDiv helpers, as directly suggested by @makortel at https://github.com/cms-patatrack/pixeltrack-standalone/pull/159#discussion_r556145889
NB 1: Sorry, this present PR is on top of the branch of https://github.com/cms-patatrack/pixeltrack-standalone/pull/159 actually, as this present PR modifies the constructions of WorkDiv in newly added AtomicPairCounter.
Hopefully, the diff should be automatically updated when the previous PR is merged anyway.
NB 2: To avoid a spam of small PRs, I will prepare a bigger PR which adds several more tests in [alpaka], and the port of the clusterizer (conveniently adding the tests which are needed for the clusterizer).
But it is good to see first if style is ok for now with few tests before propagating.

The workdiv helper functions are added in a  src/alpaka/AlpakaCore/alpakaWorkDivHelper.h file.

The workdiv helper functions are added in a  src/alpaka/AlpakaCore/alpakaWorkDivHelper.h file.

Hopefully, the diff should be automatically updated when the previous PR is merged anyway.

Seems that GitHub (still) does not update the diff when a PR contains commits that have been merged within another PR. Also, now there are conflicts, so a proper rebase would be good.

Hopefully, the diff should be automatically updated when the previous PR is merged anyway.

Seems that GitHub (still) does not update the diff when a PR contains commits that have been merged within another PR. Also, now there are conflicts, so a proper rebase would be good.

Weird that this conflict with src/kokkos/Makefile, this PR does not change it.
It is fine, will just do a rebase now.

Weird that this conflict with src/kokkos/Makefile, this PR does not change it.
It is fine, will just do a rebase now.

Just merged the latest master into this branch, the conflicts disappeared, and the diff is only the one introduced by this PR.

Just merged the latest master into this branch, the conflicts disappeared, and the diff is only the one introduced by this PR.


Added the userStory for Search Criteria

Yeah I was thinking we can have multiple different user stories for each part of the application.
So maybe we have a user story for just the individual meal page.


[stable/mysql] Validation fails when specifying a valid AKS PVC storage class

Describe the bug
I cannot specify a Persistent Volume Claim name that is acceptable for Azure (see here for the list of valid storage classes: https://kubernetes.io/docs/concepts/storage/storage-classes/#azure-disk
Version of Helm and Kubernetes:
Helm version:
Client: v2.9.1+g20adb27
Server: v2.15.1+gcf1de4f

Kubernets version:
Client Version: v1.14.3
Server Version: v1.11.10

Which chart:
stable/mysql
What happened:
Trying to install mysql helm chart on AKS cluster with this command:
helm install --name somename-mysql --namespace default --set mysqlDatabase=somename-database,livenessProbe.initialDelaySeconds=60,livenessProbe.periodSeconds=60,persistence.enabled=true,**persistence.storageClass=Standard_LRS** stable/mysql

The following validation error appears:
Error: release somename-mysql failed: PersistentVolumeClaim "somename-mysql" is invalid: spec.storageClassName: Invalid value: "Standard_LRS": a DNS-1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is 'a-z0-9?(.a-z0-9?)*')
What you expected to happen:
PVC is created
How to reproduce it (as minimally and precisely as possible):
Run install command mentioned above above on an Azure Kubernetes Cluster
Anything else we need to know:
When I install the chart with default value for persistence.storageclass (default), PVC cannot be created due to this error:
Events:
  Type       Reason              Age               From                         Message
  ----       ------              ----              ----                         -------
  Warning    ProvisioningFailed  1s (x4 over 46s)  persistentvolume-controller  Failed to provision volume with StorageClass "default": azureDisk - StandardSSD_LRS is not supported sku/storageaccounttype. Supported values are [Premium_LRS Standard_GRS Standard_LRS Standard_RAGRS]
Mounted By:  somename-mysql-967b9c54f-zkf2f

I changed the title and now the issue seems to be duplicated. Not sure how to proceed!

Turned out this is not a helm chart problem.
AKS cluster version  1.11.10 is deployed with already 'predefined' storage classes as shown with kubectl get storageclasses:
azurefile           kubernetes.io/azure-file   94d
azurefile-premium   kubernetes.io/azure-file   94d
default (default)   kubernetes.io/azure-disk   19h
managed-premium     kubernetes.io/azure-disk   19h

'default' (the default value of the helm chart) exists, but it gives an error. I think this is more a problem of AKS.
Will close this issue


Add blockResubmit feature to Cart Validation

1. Why is this change necessary?
Plugins may want to add cart validators which prevent a user from submitting the order, but don't stop him from retrying.
2. What does this change do, exactly?
It adds a error collector which collects cart errors with a blockResubmit option, just like blockOrder.
The error collector checks if the corresponding errors even own such a method, so it does not fail if a error does not have the attribute, it's purely optional and fully backwards compatible.
And it adds a check in the Twig template for the cart submit button for this very attribute.
3. Describe each step to reproduce the issue or behaviour.
Trigger a cart error (add a product, set shipping to country XYZ, go to checkout, before you checkout remove that country from your storefront, try to submit), add the method blockResubmit to the error which returns a boolean false, and you should see that the order is blocked, but you can retry.
E.g. ShippingAddressBlockedError.php
4. Please link to the relevant issues (if any).
#2898
5. Checklist

[X] I have rebased my changes to remove merge conflicts
[X] I have written tests and verified that they fail without my change
Yes 0727377
[X] I have created a changelog file with all necessary information about my changes
[X] I have written or adjusted the documentation according to my changes
https://github.com/shopware/docs/pull/800
[X] This change has comments for package types, values, functions, and non-obvious lines of code
[X] I have read the contribution requirements and fulfil them.

Hello,
thank you for creating this pull request.
I have opened an issue on our Issue Tracker for you. See the issue link: https://issues.shopware.com/issues/NEXT-25555
Please use this issue to track the state of your pull request.

Thanks for your contribution! Your PR got merged :tada: :blue_heart:


Fixed image create wizard

Description
Fixed image create wizard.
Type of change
What is it?

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Documentation update
[ ] Tests update

Checklist:

[ ] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] New and existing unit tests pass locally with my changes
[x] I run npm run lint:js:fix to check that my code is properly formatted

Codecov Report
Base: 30.43% // Head: 30.46% // Increases project coverage by +0.02% :tada:

Coverage data is based on head (4faaa26) compared to base (380439b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
+ Coverage   30.43%   30.46%   +0.02%
==========================================
  Files         125      125
  Lines        2740     2738       -2
  Branches      848      848
==========================================
  Hits          834      834
+ Misses       1743     1741       -2
  Partials      163      163

Impacted Files
Coverage Δ

src/Routes/ImageManager/steps/imageSetDetails.js
0.00% <ø> (ø)

src/components/ImageCreator.js
0.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


Improve Error Messages

This PR introduces context messages for each error message, providing additional information to help understand the cause of the error. Here's an example before/after:
Before:
[2023-01-02T13:15:03Z INFO  mmproxy::listener::tcp] listening on: <IP_ADDRESS>:25577
[2023-01-02T13:15:06Z INFO  mmproxy::listener::tcp] [new conn] [origin: <IP_ADDRESS>:53566 [src: <IP_ADDRESS>:0]
[2023-01-02T13:15:06Z ERROR mmproxy::listener::tcp] while handling a connection: Operation not permitted (os error 1)

After:
[2023-01-02T13:12:59Z INFO  mmproxy::listener::tcp] listening on: <IP_ADDRESS>:25577
[2023-01-02T13:13:16Z INFO  mmproxy::listener::tcp] [new conn] [origin: <IP_ADDRESS>:46780] [src: <IP_ADDRESS>:0]
[2023-01-02T13:13:16Z ERROR mmproxy::listener::tcp] failed to set ip transparent on the upstream socket: Operation not permitted (os error 1)

LGTM - feel free to merge if the PR is ready :slightly_smiling_face:


Add page for conference 29th January 2025

With this change, we are adding a new page for the in-person conference organised for the 29th January 2025.

The image will be as follows:

Further information in Slack.
https://ukgovernmentdigital.slack.com/archives/C06SQSSAFQD/p1729588370969229

The image doesn't work for me locally, does it for others? Not sure how to configure eleventy to serve static files @marcotranchino @sdh100shaun

The image doesn't work for me locally, does it for others? Not sure how to configure eleventy to serve static files @marcotranchino @sdh100shaun

Will pull and look now ... there is just a bypass


Unicorn randomly raising checksum errors

Well I wouldn't consider it entirely random but this happens relating to having multiple child component of the same type.
When an action is handled for one child component and then a second one, attempts to perform an action on the firs element fails.
In my particular case, it was a click event.

Can you give me some example code? I have multiple child row components in my nested example: https://github.com/adamghill/django-unicorn/blob/master/example/unicorn/templates/unicorn/nested/table.html#L31. The table component also might be useful to see what I ended up doing to make it all work correctly: https://github.com/adamghill/django-unicorn/blob/master/example/unicorn/components/nested/table.py.

Any update on whether this is still happening or any example code I can take a look at to investigate?

I'm going to close this for now, but feel free to re-open it if you have some sample code I can look at. Thanks!


[Concurrency] Fix ObjC weak references to actors.

Change actor destruction to call swift_deallocClassInstance instead of swift_deallocObject. When ObjC interop is enabled, swift_deallocClassInstance will check the "pure swift deallocation" bit and call into the ObjC runtime to destruct the instance when needed. This is what clears weak references and associated objects.
rdar://91270492

@swift-ci please test


Game broken

When attempting to access this at https://githubschool.github.io/github-games-akatz2, I am getting a 404. This could be caused by a couple things:

GitHub pages needs to be enabled on master. You can fix this in the repository settings.
the index.html file is incorrectly named inde.html. We will fix this together in class.

Can you please fix the first bullet @akatz2?

Fixed in settings


fixed the issue "AccumulateTarget: containers path is not of type []interface{} but map[string]interface" when installing postgres

Signed-off-by: myan<EMAIL_ADDRESS>When the installed kubectl version is lower than v0.21, the following error may occur when installing postgres
error: AccumulateTarget: containers path is not of type []interface{} but map[string]interface {}

maybe update the document to note that run this script requires kubernetes version v.1.21+

maybe update the document to note that run this script requires kubernetes version v.1.21+

Done

/lgtm

/hold

please update the operator installation document as well.

please update the operator installation document as well.

Yes, I will updated the csv description after this pr has merged.

/unhold


The buffer plays after waiting 20 seconds.

Hello friends;
I have streams from 3 URLs in the player.
When I change the broadcast, buffering starts and play starts after 20 seconds.
No matter what I did, I couldn't understand why there was so much waiting.

I thought it was relevant here and changed it, but the result is still the same, each broadcast waits for 15-20 seconds of buffer before playing.

Additionally, the buffering process continues even though I stopped the broadcast.

wasnt there a template for bug reports?
since buffering is the problem try disabling it first

refer to the docs
https://rntp.dev/docs/api/objects/player-options


Indicate when Evaluation would overwrite changes

The evaluation should store a timestamp or hash of when it was last saved in order to identify during saving if other changes occurred in the meantime. The UI can then warn accordingly.

I suppose that this issue is related to what we discussed on Monday (in which case the wording of the title is misleading).
Anyhow, I have added such a check to the UpdateEvaluationTemplateHandler. It now compares a modified timestamp to the one stored in the database. If they don't match, an update in rejected with a HTTP 409 error.

Will the user get a pop-up in this case, or is the error just shown in the toast message, the same as the success message would be?

It's a toast message as with all the other status indicators and errors.

That's maybe something we'd want to change in the future, as users might overlook those easily.


Azure monitor with diagnosticsettings does not output ContainerAppConsoleLogs for crashing containers

This issue is a: (mark with an x)

[x ] bug report
[ ] documentation issue or request
[ ] regression (a behavior that used to work and stopped in a new release)

Issue description
If i configure the logging on the App Environment with destination: 'azure-monitor' and configure it to have 'allLogs' and 'audit' (or just allLogs) forwarded to a Log Analytics Workspace, ContainerAppConsoleLogs is created, but no entries appear from containers that don't startup due to errors on startup. That makes it hard to figure out why the container isn't starting.
If I configure the Environment to directly log to the workspace instead ('log-analytics'), the ContainerAppsConsoleLogs_CL contains the output of the failing container's console log
Steps to reproduce

Configure azure monitor with a Log analytics workspace endpoint on an Apps Environment
Add a containerapp that has an image that crashes on startup and logs the error to the console
Wait for the error to appear in ContainerAppConsoleLogs

Expected behavior [What you expected to happen.]
Log the console output to ContainerAppConsoleLogs just as the target: log-analytics does for ContainerAppConsoleLogs_CL
Actual behavior [What actually happened.]
No logs for crashing containers in ContainerAppConsoleLogs

@csteeg, if you set your environment to use Log Analytics directly rather than Azure Monitor --> Log Analytics, do you see the console log output you expect?

@BigMorty indeed, then it gets written as expected in the ContainerAppConsoleLogs_CL

Thanks for confirming. @sanchitmehta, can you take a look at this please?


A typo

Is there an existing issue?

[X] I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

[X] This is not a support question.

What browsers are you seeing the problem on?
Chrome
Bug report for the website
https://docs.substrate.io/main-docs/build/libraries/
There is a typo in the core node libraries section.
For example, the sp_std libraris takes useful primitives
Steps to reproduce the problem
No response

@cuteOlaf - why not make a pr? https://github.com/substrate-developer-hub/substrate-docs/blob/main/content/md/en/docs/main-docs/build/libraries.md

made a PR.
fixed


Separate the hours from Pager

Idea Description
see #151

The hours is built in the Pager because of ScreenScrollState issues.
If possible, it is preferable that the Hours be separated from the Pager.

Hours is in the Pager, so when we switch pages (tabs), the hours moves with it.
We want to detach the Hours from the Pager.
To do this, I think we need to consider how to handle ScreenScrollState.
Reference images and links
#109
#151

I would like to give this a try 🙋♂

You can unassign me from this task. I tried several approaches but wasn't able to come up with a proper solution. Would love to see someone else attempt this.

Separate vertical scroll and horizontal scroll states.

share the vertical scroll state common with Hours and ViewPager
individual horizontal scroll states for each ViewPager page

Custom HorizontalPager behvaior

All 3 days TimeTable are combined to a single @Composable
adjust offset of the page when tabs are switched
layout the Hour and Timetable in a box (No need for a HorizontalViewPager @Composable)

@surajsau
First, thanks you so much for trying this issue and your contribution. I know it is challenging.
And thanks for sharing the approaches. This should help others. 👍

I think it has a tradeoff.
But, I'd like to share the scroll state because I want to see that!

I see. Thank you!
If I come up with something, I will request to have it assigned.

@Pon57 Would you like me to assign this issue to you?

@takahirom
I am not confident that I can solve it, but I would like to give it a try.
Please assign me!

@t-yusaku @takahirom
Sorry for repeating myself. I'm asking because the problem to be solved in this issue was not clear to me.
Does this issue mean that Hours should be shared like this video?
https://user-images.githubusercontent.com/15137243/189916205-0a6f5a36-d3f7-4737-85af-3f9d5df26216.mp4

@Pon57
Thanks for asking. 👍
The most important thing in this issue is to separate Hours from HorizontalPager.
In the current timetable, HorizontalPager contains Hours and each page have its own Hours.
In this issue, we want to stop them and Hours exits outside of HorizontalPager.
The next important thing is to share the Hours's position between the pages as you have shown.
It is prefereable to resolve both in this issue.
However, if it is difficult to resolve both, you can focus on the first thing only.

@t-yusaku
Thanks for the reply! My question was completely answered by your reply.
I will try to work on it 🙏

@Pon57 Can you have time to develop this? 👀

@takahirom
Sorry for the late response on this issue.
I am working on it a little bit, but I am not able to spend as much time on it as I would like.
I have been able to understand the source code, figure out how it works, and come up with a few ideas based on that. However, I am still trying to implement it and see if it works as intended or if it is even possible to implement it in the first place.
If this issue is urgent or very important, please remove my assignment. Sorry.

@Pon57 You can open PR with the work in progress.
You don't have to do all the things.
https://github.com/DroidKaigi/conference-app-2022/pull/807

@takahirom
I understand. 🙏
Since I have not been able to do most of the commits yet (not even a test implementation), I will work on it this Saturday and Sunday to create a PR. Can you wait until then?
I will also let you know if that work proves to be impossible with my ideas.

@Pon57 It's ok. All we can do is to do the best what we can do.


Fixed the issue of alignment of profile cards, long profile names and description

What type of PR is this?
/kind bug fix
What this PR does / why we need it:
This PR fixes the issue of alignment of profile cards and long names and description not displaying correctly.
This PR also fixes some custom css added to the component in the library. This has been moved from card.css to site.css
Which issue(s) this PR fixes:
Fixes #449
Test Report Added?:
/kind TESTED
Test Report:
Long name and card alignment fixed

Long description shown correctly

Long name in delete confirm shown correctly

Special notes for your reviewer:

@skdwriting Please review and merge


Add flags for res and different stuff

As the title already says I should add some flags for changing the screenshot resolution and lots of other stuff.

You can now use --host for a single host or --file for looping trough a file which is for bulk screenshotting


net : socket : make socket_tls depend on mbedtls

Socket_tls.c is depending on mbedtls.  If mbedtls is not configured, socket_tls gives compile issues
Signed-off-by: Wim Van Loocke<EMAIL_ADDRESS>

The change looks ok, you need to resubmit the PR and fix the commit message. It is not enough to edit the PR description. Just fix the commit msg and force push the branch.
So the commit msg should look something like this:
net: socket: Add dependency to mbedtls

Socket_tls.c is depending on mbedtls. If mbedtls is not configured, socket_tls gives
compile issues

Signed-off-by: Wim Van Loocke<EMAIL_ADDRESS>

Something went wrong here. Please do not do merge, but do rebase instead (so you should end up with one commit only), then force push you one commit branch do this.

Hi Robert, Hi Jukka,
I will do next steps:

enter new problem report
submit one commit with this info

"net: socket: Add dependency to mbedtls
Socket_tls.c is depending on mbedtls. If mbedtls is not configured,
socket_tls gives
compile issues
fixed : # ...
Signed-off-by: Wim Van Loocke<EMAIL_ADDRESS>with the solution proposed by Robert.
Hope it works then.
kr,
Wim
On Mon, Jan 13, 2020 at 10:53 AM Robert Lubos<EMAIL_ADDRESS>wrote:

@rlubos commented on this pull request.
In subsys/net/lib/sockets/Kconfig
https://github.com/zephyrproject-rtos/zephyr/pull/21834#discussion_r365716261
:

@@ -48,6 +48,7 @@ config NET_SOCKETS_DNS_TIMEOUT

config NET_SOCKETS_SOCKOPT_TLS
bool "Enable TCP TLS socket option support [EXPERIMENTAL]"

depends on MBEDTLS

Actually I'd make it: select MBEDTLS if NET_NATIVE
I saw that NET_SOCKETS_SOCKOPT_TLS option is also used in some offloaded
engines (SimpleLink for instance) as well as in some application protocols
(like LWM2M). mbedTLS is only needed for native implementation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zephyrproject-rtos/zephyr/pull/21834?email_source=notifications&email_token=AJH5EO72PHLWE4IH2W6HS7DQ5Q2ZFA5CNFSM4KFJLFGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRPF53I#pullrequestreview-341729005,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJH5EO4RQOHVOG6X4ODYU2LQ5Q2ZFANCNFSM4KFJLFGA
.

enter new problem report

There is no need to create a new issue, the existing #21768 is enough

Hi Robert,
if I make it select MBEDTLS if NET_NATIVE, it won't add mbedtls to the
configuration and it doesn't build.
I have read the documentation, but got confused as it is stated
The select statement is used to force one symbol to y whenever another
symbol is y.
In the .config is see
CONFIG_NET_NATIVE=y, so I expect CONFIG_MBEDTLS=y but got  # CONFIG_MBEDTLS
is not set
Any idea where it goes wrong?
envir :
samples/net/dhcpv4_client
west build -b stm32f746g_disco
branch zephyr master
Kr,
Wim
On Mon, Jan 13, 2020 at 10:53 AM Robert Lubos<EMAIL_ADDRESS>wrote:

@rlubos commented on this pull request.
In subsys/net/lib/sockets/Kconfig
https://github.com/zephyrproject-rtos/zephyr/pull/21834#discussion_r365716261
:

@@ -48,6 +48,7 @@ config NET_SOCKETS_DNS_TIMEOUT

config NET_SOCKETS_SOCKOPT_TLS
bool "Enable TCP TLS socket option support [EXPERIMENTAL]"

depends on MBEDTLS

Actually I'd make it: select MBEDTLS if NET_NATIVE
I saw that NET_SOCKETS_SOCKOPT_TLS option is also used in some offloaded
engines (SimpleLink for instance) as well as in some application protocols
(like LWM2M). mbedTLS is only needed for native implementation.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zephyrproject-rtos/zephyr/pull/21834?email_source=notifications&email_token=AJH5EO72PHLWE4IH2W6HS7DQ5Q2ZFA5CNFSM4KFJLFGKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCRPF53I#pullrequestreview-341729005,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJH5EO4RQOHVOG6X4ODYU2LQ5Q2ZFANCNFSM4KFJLFGA
.

Hi Wim,
Did you delete the build directory after modifying the Kconfig file? It's often the case that CMake keeps some stale configuration after the Kconfig/Cmake files are modified, so you need to give it a chance to re-create the project from scratch.
FYI, I've tested the configuration you've posted and it worked for me. I needed to enable NET_SOCKETS_POSIX_NAMES though, if you find this an issue it could be easily fixed by replacing recv call in sockets_tls.c file with zsock_recv.

Hi Robert,
I have done that.( I always do that as building is not taking a lot of
time).
My issue is have seen was indeed related to recv, If I add
NET_SOCKETS_POSIX_NAMES=y,
indeed it is building.
Should sockets_tls.c be changed then to
#if defined(CONFIG_NET_SOCKETS_POSIX_NAMES)
if (recv(pfd->fd, NULL, 0, ZSOCK_MSG_DONTWAIT) < 0 &&
errno != EAGAIN) {
pfd->revents |= ZSOCK_POLLERR;
goto next;
}
#else
if (zsock_recv(pfd->fd, NULL, 0, ZSOCK_MSG_DONTWAIT) < 0 &&
errno != EAGAIN) {
pfd->revents |= ZSOCK_POLLERR;
goto next;
}
#endif
I guess it is better no to have "hidden" configs,.. so I you want I can
make issue and send a merge request.
kr,
Wim
On Tue, Jan 14, 2020 at 9:31 AM Robert Lubos<EMAIL_ADDRESS>wrote:

Hi Wim,
Did you delete the build directory after modifying the Kconfig file? It's
often the case that CMake keeps some stale configuration after the
Kconfig/Cmake files are modified, so you need to give it a chance to
re-create the project from scratch.
FYI, I've tested the configuration you've posted and it worked for me. I
needed to enable NET_SOCKETS_POSIX_NAMES though, if you find this an
issue it could be easily fixed by replacing recv call in sockets_tls.c
file with zsock_recv.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/zephyrproject-rtos/zephyr/pull/21834?email_source=notifications&email_token=AJH5EO24ZRZXWW72QZ5PWB3Q5VZ6ZA5CNFSM4KFJLFGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI3X3MA#issuecomment-574062000,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJH5EO3TCTI6F4YV47IIJWTQ5VZ6ZANCNFSM4KFJLFGA
.

@DenvE There's no need to add extra complexity with #if defined. Simply replacing the existing recv call with zsock_recv is a safe operation - they're equivalent and the latter is always available. recv is more commonly used alias for zsock_recv, though it needs extra configs to be enabled (as it's a part of POSIX API).
IMO it's would be acceptable to have this change as well in this PR, as a separate commit. You 'd need to cleanup your commits in this PR though, I'd expect to see one commit adding mbedTLS dependency, and (optionally) one commit sorting-out the recv call. As @jukkar said, you need to rebase your branch towards master, not merge (or probably start fresh if you find this too complex).

Hi Robert,
I have submitted the change for recv.
I got a mail  with this content
Identity/Emails issues
390e703144698ee011d7f2ef60d5423023bc37a6: author email (wimvanloocke
<EMAIL_ADDRESS>needs to match one of the signed-off-by entries.
390e703144698ee011d7f2ef60d5423023bc37a6: author email (wimvanloocke
<EMAIL_ADDRESS>does not follow the syntax: First Last .
I don't understand what it means First Last? and how to correct.
kr,
Wim
On Tue, Jan 14, 2020 at 1:30 PM Robert Lubos<EMAIL_ADDRESS>wrote:

@DenvE https://github.com/DenvE There's no need to add extra complexity
with #if defined. Simply replacing the existing recv call with zsock_recv
is a safe operation - they're equivalent and the latter is always
available. recv is more commonly used alias for zsock_recv, though it
needs extra configs to be enabled (as it's a part of POSIX API).
IMO it's would be acceptable to have this change as well in this PR, as a
separate commit. You 'd need to cleanup your commits in this PR though, I'd
expect to see one commit adding mbedTLS dependency, and (optionally) one
commit sorting-out the recv call. As @jukkar https://github.com/jukkar
said, you need to rebase your branch towards master, not merge (or probably
start fresh if you find this too complex).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/zephyrproject-rtos/zephyr/pull/21834?email_source=notifications&email_token=AJH5EO6TSB2KMJTZIROMGZ3Q5WV5VA5CNFSM4KFJLFGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEI4N2XI#issuecomment-574152029,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AJH5EO7XXVDPNRZ65VVL6KLQ5WV5VANCNFSM4KFJLFGA
.

There is now two PRs #21834 and #21892, are you now working on the latter?
In that latter PR, the commit messages are empty for the two commits, you need to fix that. Easiest is just do git rebase -i HEAD~2 and edit the commit messages to be proper and force push.

@DenvE As Jukka say, you need to sort out the commit message. Zephyr has quite strict requirements in terms of commit format. You need a proper title, body and signoff entry.
As for the signoff, don't do this manually. Git will add this for you if you specify the --signoff option when creating or amending a commit. Note, that you need to configure your username/email correctly in your local git setup, in order to get correct entries:
https://help.github.com/en/github/using-git/setting-your-username-in-git
https://help.github.com/en/github/setting-up-and-managing-your-github-user-account/setting-your-commit-email-address


Add interfaces for retrieving separate linkable downstream binaries

The new interface needs to be marked as experimental, probably name it IModulePrecompileService_ and clearly state it as experimental and subject to removal or change in the comment.

The new interface needs to be marked as experimental, probably name it IModulePrecompileService_ and clearly state it as experimental and subject to removal or change in the comment.

I did already comment it as Experimental in slang.h.  I can additionally rename it.


Add optional hard shutdown (dumb kill) to srcds servers to fix auto reconnect addons not working

This is not for requesting support for new games/applications
To do this you should go to https://github.com/CubeCoders/AMPTemplates and first attempt to build a configuration yourself - otherwise you can request a template from this repo.
Feature Request
Add a dumb kill feature to srcds allowing for auto reconnect addons to work better, for instance this photo

Feature Information:
This would simply allow users to toggle between soft shutdowns and hard shutdowns of the source engine servers so that they can have more control on reconnecting users by simulating a "crash". Almost every other server hosting program out there already does this, and it would put amp on the industry standard in this category

I confirm:

[x] that I have searched for an existing feature request matching the description.
[x] that my checkboxes above look like the one on the left (remove this line when done)

@Greelan - now that you have taken over support of this module is there a chance you could implement this?

I would if I could - however atm the generic module doesn't allow for variable shutdown methods. It's actually something I want for other use cases too. Basically I would have an option in the UI that controls a variable that allows the shutdown method to be changed. Should be very doable as recently variables were introduced for things like executable name. If it was done properly it would also allow different methods to be selected between windows and Linux


Tag search and sort

The image view should offer a way to search for specific tags (could be all client-side filtering) and re-sort tags by different methods (alpha, parsed version numbers, date?).

Partially implemented by 0.19...


Provide umd compiled version of component

Hi, I am trying to use this library in a UMD Vue project and cannot find a way to compile it as a Web Component to use with VueJs3 on the browser. Could you please provide a compiled version of the component?
Thank you very much!

Hey @adrian-e, will look into this. Thanks!


Override Content-Type header key in send_file helper

This effectively overrides Content-Type header key instead of adding another one, what you can see on the screenshot below:

Nice catch 👍  Thanks


jfrog-docker-reg2.bintray.io/jfrog/artifactory-oss no longer starts

Sorry if this isn't the right forum, but I'm no longer able to run artifactory in docker. It has been running fine for last half of 2015 so I wonder if a recent image, java, or docker change has introduced the problem.
I'm seeing it in a new digitalocean docker server so it should be easy to reproduce.
$ docker run --name art1 -p 8081:8081  jfrog-docker-reg2.bintray.io/jfrog/artifactory-oss
nginx: unrecognized service
/usr/bin/java
Starting Artifactory tomcat as user artifactory...
Max number of open files: 524288
Using ARTIFACTORY_HOME: /var/opt/jfrog/artifactory
Using ARTIFACTORY_PID: /var/opt/jfrog/run/artifactory.pid
Creating directory /var/opt/jfrog/artifactory/logs/catalina
Creating directory /var/opt/jfrog/artifactory/temp
Creating directory /var/opt/jfrog/artifactory/work
Tomcat started.

** ERROR: Artifactory Tomcat server did not start in 60 seconds. Please check the logs

The container stops. Nothing seems wrong in /var/opt/jfrog/artifactory/logs.
artlogs.zip
catalina/catalina.out:
   sun.boot.library.path                                                 | /usr/lib/jvm/java-1.8.0-openjdk-<IP_ADDRESS>-0.b17.el6_7.x86_64/jre/lib/amd64
...
2016-01-06 18:03:14,575 [art-init] [INFO ] (o.a.s.ArtifactoryApplicationContext:406) - Artifactory application context is ready.
2016-01-06 18:03:14,578 [art-init] [INFO ] (o.a.w.s.ArtifactoryContextConfigListener:219) -
###########################################################
### Artifactory successfully started (10.290 seconds)   ###
###########################################################

artifactory.log:
 Version:  4.4.0                                   __/ |
 Revision: 40080                                  |___/
...
2016-01-06 18:03:14,575 [art-init] [INFO ] (o.a.s.ArtifactoryApplicationContext:406) - Artifactory application context is ready.
2016-01-06 18:03:14,578 [art-init] [INFO ] (o.a.w.s.ArtifactoryContextConfigListener:219) -
###########################################################
### Artifactory successfully started (10.290 seconds)   ###
###########################################################

PS: I used to use jfrog-docker-registry.bintray.io/artifactory/artifactory-oss but instructions at https://www.jfrog.com/confluence/display/RTF/Running+with+Docker recently changed?
Is there an older working version I can revert to? I don't know how to list the available image tags.
Thanks, let me know if you need any other information or want me to run a test.

jstack <java pid> finally worked once -- normally reports
82: Unable to open socket file: target process not responding or HotSpot VM not loaded
The -F option can be used when the target process is not responding

and

# jstack -F 82
Attaching to process ID 82, please wait...
Error attaching to process: sun.jvm.hotspot.debugger.DebuggerException: cannot open binary file
sun.jvm.hotspot.debugger.DebuggerException: sun.jvm.hotspot.debugger.DebuggerException: cannot open binary file
	at sun.jvm.hotspot.debugger.linux.LinuxDebuggerLocal$LinuxDebuggerLocalWorkerThread.execute(LinuxDebuggerLocal.java:163)

Anyway I saw the below thread, and searching on it shows that it can be a problem, causing slow / hanging tomcat startup.
"localhost-startStop-1" #16 daemon prio=5 os_prio=0 tid=0x00007fa90c002000 nid=0x81 runnable [0x00007fa9485e5000]
   java.lang.Thread.State: RUNNABLE
	at java.io.FileInputStream.readBytes(Native Method)
	at java.io.FileInputStream.read(FileInputStream.java:255)
	at sun.security.provider.SeedGenerator$URLSeedGenerator.getSeedBytes(SeedGenerator.java:539)
	at sun.security.provider.SeedGenerator.generateSeed(SeedGenerator.java:144)
	at sun.security.provider.SecureRandom$SeederHolder.<clinit>(SecureRandom.java:203)
	at sun.security.provider.SecureRandom.engineNextBytes(SecureRandom.java:221)
	- locked <0x00000000805a5740> (a sun.security.provider.SecureRandom)
	at java.security.SecureRandom.nextBytes(SecureRandom.java:468)
	- locked <0x00000000805a57a0> (a java.security.SecureRandom)
	at java.security.SecureRandom.next(SecureRandom.java:491)

So I tried the suggested workaround -e RUNTIME_OPTS="-Djava.security.egd=file:/dev/./urandom". Fingers crossed that this is a consistent fix!

Hi jamshid,
Thank you for your feedback.
As you mentioned Tomcat server start took longer than 60 seconds.
We have added "START_TMO" env variable to extend the init timeout of tomcat.
This timeout by default is 60 seconds.
You can extend the timeout as another protection for the container startup process.

Okay, thanks, found your https://www.jfrog.com/jira/browse/RTFACT-7842. Feel free to close this.
Minor issue: the error messages in /etc/init.d/artifactory are still hardcoded, they don't show the env variable values.
I still saw timeouts even at 120 seconds. Didn't test longer, since that also causes problems for monitoring tools and scripts. If SecureRandom is the most common culprit, seems good to document or even default the RUNTIME_OPTS workaround.
PS: thanks for providing this artifactory container, it sure makes Dockerfiles that use maven much faster.

Resolved in https://www.jfrog.com/jira/browse/RTFACT-7842

@jamshid thank! I had the same problem and your workaround solved it.
@matankatz RUNTIME_OPTS fix it, but with START_TMO the problem persisted.


bosh deploy - busy disk on unmount

Hello,
we finally had the time to check the cf-containers-brokers. Really nice extension to the current bosh capabilities.
We experience issues while testing the broker container, and trying a bosh update after a successfull first deployment.
It seems that the persistent disk is busy when bosh tries to unmount the disk from the original VM.
see logs below.
We use latest version:

bosh-vcloud-esxi-ubuntu-trusty-go_agent 2922, with vcloud CPI
bosh 148
cf-containers-broker v11

Any idea why the persistent disk cant be unmounted ?
Best regards
Pierre
Started updating job broker > broker/0. Failed: Action Failed get_task: Task c3dc2d78-19c4-4bfe-4f91-10b9f1246e21 result: Unmounting persistent disk: Running command: 'umount /dev/sdc1', stdout: '', stderr: 'umount: /var/vcap/store: device is busy.
(In some cases useful info about processes that use
the device is found by lsof(8) or fuser(1))
': exit status 1 (00:10:03)
Error 450001: Action Failed get_task: Task c3dc2d78-19c4-4bfe-4f91-10b9f1246e21 result: Unmounting persistent disk: Running command: 'umount /dev/sdc1', stdout: '', stderr: 'umount: /var/vcap/store: device is busy.
(In some cases useful info about processes that use
the device is found by lsof(8) or fuser(1))
': exit status 1
Task 1099 error

This has been reported previously (https://github.com/cf-platform-eng/docker-boshrelease/issues/13) and I'm still trying to figure out why this is happening.
My guess is that the service broker kills the container instead of stopping it and giving it a grace period. I've observed something similar when using just the docker bosh release, as it's also killing the containers.
What I've observed is that the container process is NOT able to stop correctly when Docker tris to kill it. Docker believes that the container has been destroyed, but the reality is that if you do a ps you'll see the process there, so if the process has a volume mounted, you won't be able to unmount the persistent disk.
Some time ago I added a hack to unmount all the container volumes, but seem it's not working properly.
So something I'd like to try is to replace the killing process by some kind of drain process and let the process die gracefully.

Hello,
@holgerkoser and I ran into the same issue and found a solution. Basically, what we did was to stop the containers in the monit stop routine implemented in https://github.com/cf-platform-eng/docker-boshrelease/blob/master/jobs/docker/templates/bin/docker_ctl. This helps for the plain broker+docker deployment and also for the more complex broker+swarm+dockers deployments (and is an autonomous solution/not issued by swarm, which is good/safe). Since the containers are started with restart=always, the containers will be restarted when the daemon is restarted.
Indeed, the manual unmount in the same file wasn't working for us either. It looks as if those lines could be deleted/replaced with (sorry for the pseudo code for now and no pull request instead):
get list of running docker containers
for each docker container do
  stop docker container
done
continue with kill of docker daemon

Interestingly, also the stop will terminate the container hard after (default) 10 seconds. However, after we implemented the the above loop before the docker daemon gets killed we had no issue anymore (may be by chance, not sure we already understand the mechanics well enough).
Best regards, Vedran
P.S.: That was the reason why we opened btw. https://github.com/cf-platform-eng/docker-boshrelease/issues/23 as we wanted to call the docker CLI to loop and stop the containers.

@vlerenc PR or it doesn't exists! :)

I know, I know, it's not my call - waiting for approval on our side. Should be coming soon, but it really isn't much code either and as I said, not sure if it will always work. However, we haven't had any issues since we changed this. At least docker now kills its containers and not monit is killing docker. ;-)

@frodenas How about https://github.com/cf-platform-eng/docker-boshrelease/pull/24?

Thanks @vlerenc!
@poblin-orange I'm going to cut a new release this weekend, until then I'll keep this issue open.

Thank you guys! Eager to test that new release :-)

New v13 release has the fix.
Reopen if still fails to unmount the pd.


typo

Hello, I found a typo on this doc: overriden should be overridden

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 7d9cfb97-d0f3-3cc1-a460-ff4e05530b92
Version Independent ID: 3db82b30-1d14-1613-e473-13310e855ab2
Content: Azure AD Connect: Seamless Single Sign-On - quick start
Content Source: articles/active-directory/connect/active-directory-aadconnect-sso-quick-start.md
Service: active-directory
GitHub Login: @billmath
Microsoft Alias: billmath

Thanks for the feedback, @josuvil. We are looking into this now.

We have fixed this. Thanks for your feedback!


Integration does not work after Homeassistant Upgrade to 2022.3.4 (March 11)

Which Model do you use from loxone? Miniserver? Gen1 or Gen2?
MiniServeer Gen1
Which software version does your loxone use?
<IP_ADDRESS>
How did you install HomeAssistant? Over Hassio oder manual install?
Docker container on RPi
Which Version do you use of HomeAssistant?
2022.3.4
Describe the bug
After upgrading to 2022.3.4 pyloxone intergration does not start.
It used to work without problems before.
Paste the error log with the following settings:
This error originated from a custom integration.
Logger: homeassistant.config_entries
Source: custom_components/loxone/api.py:77
Integration: PyLoxone (documentation, issues)
First occurred: 21:24:00 (2 occurrences)
Last logged: 21:39:03
Error setting up entry PyLoxone for loxone
Traceback (most recent call last):
File "/usr/local/lib/python3.9/site-packages/requests_async/api.py", line 6, in request
return await session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.9/site-packages/requests_async/sessions.py", line 79, in request
resp = await self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.9/site-packages/requests_async/sessions.py", line 136, in send
r = await adapter.send(request, **kwargs)
File "/usr/local/lib/python3.9/site-packages/requests_async/adapters.py", line 42, in send
ssl = httpcore.SSLConfig(cert=cert, verify=verify)
AttributeError: module 'httpcore' has no attribute 'SSLConfig'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/config_entries.py", line 335, in async_setup
result = await component.async_setup_entry(hass, self)
File "/config/custom_components/loxone/init.py", line 141, in async_setup_entry
if not await miniserver.async_setup():
File "/config/custom_components/loxone/miniserver.py", line 110, in async_setup
request_code = await self.lox_config.getJson()
File "/config/custom_components/loxone/api.py", line 77, in getJson
api_resp = await requests.get(
File "/usr/local/lib/python3.9/site-packages/requests_async/api.py", line 11, in get
return await request("get", url, params=params, **kwargs)
File "/usr/local/lib/python3.9/site-packages/requests_async/api.py", line 6, in request
return await session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python3.9/site-packages/requests_async/sessions.py", line 320, in aexit
await self.close()
File "/usr/local/lib/python3.9/site-packages/requests_async/sessions.py", line 311, in close
await v.close()
File "/usr/local/lib/python3.9/site-packages/requests_async/adapters.py", line 65, in close
await self.pool.close()
TypeError: object NoneType can't be used in 'await' expression

I had an older version of PyLoxone installed, after upgrading to the recent version the integration is working again.
Thanks and keep up the great work!


Add page for Gnome terminal

https://github.com/dracula/gnome-terminal

It's finally live! https://draculatheme.com/gnome-terminal/


i18n: add french translation

Also you need to add a fr line to package.json.

Also you need to add a fr line to package.json.

True, but what should I write ?
Just Générer des images à [Novel AI](https://novelai.net) ?

@shigma Voilà, it is ready to merge


Vue-Router breaks when reloading page

Version
2.7.0
Reproduction link
https://codepen.io/Juli0GT/pen/veEEpr
Steps to reproduce
Before reloading page thats my $route component:
$route:Object
fullPath:"/dashboard/customer-service?subnav=dashboard&activeClass=active"
meta:Object (empty)
name:“csDashboard"
params:Object (empty)
path:”/dashboard/customer-service"
query:Object
What is expected?
Having same $route component after reload
What is actually happening?
If I refresh the page my router doesn’t recognise anymore my route, and my $route object looks like this:
$route:Object
fullPath:"/“
meta:Object (empty)
params:Object (empty)
path:”/"
query:Object (empty)

when you reload the page and lose your router object... what is the URL in your browser?
is it still /dashboard/customer-service or is it just your base domain?

Hi, thanks for your interest but Github issues are for bug reports and feature requests only. You can ask questions on the forum, the Discord server, gitter or StackOverflow.

@posva I actually have the same error and has been reported as a bug to my plugin vue-analytics.
What I do is grabbing the route and automatically start tracking pages with Google Analytics, but when a component has been lazy loaded there's a moment when the currentRoute object has empty properties: like the one described in this ticket.
If you need some sort of reproduction you could check the one done in the issue reported to me (https://github.com/MatteoGabriele/vue-analytics/issues/149). The issue in vue-analytics is that I need a name property in the currentRoute when tracking, but the root route sometimes doesn't have it.
Let me know if it's all clear otherwise I'll try myself to create a better reproduction for here.
Thanks for your time

Yeah, I would need a repro I can play with (jsfiddle, codesandbox) without vue-analytics. Thanks 🙂

@posva I've crated a codesanbox for you https://codesandbox.io/s/742n0wow51
in the route.js file there are two kinds of imports: one with lazy loading and a normal one.
The one with lazy loading will render in the html an "empty" route object with no name etc..
the second one will render a route object with a name property as is expected.
Thanks a lot for your time and I hope will be enough otherwise I'll try something else

@MatteoGabriele I think you shared the wrong codesandbox

@posva Did I?

it renders the route before navigation. keep in mind $route is not serializable and therefore cannot be displayed inside HTML as well

but well the point tho is that for a "second" the $route object is empty, compared to the not lazy loaded and it is visible in this example.
I hoped that the concept was clear but I can think about something else even tho the main point is that the route on lazy loading has null values on the start and it breaks code that reads those values.

@posva  would you please answer the question of @MatteoGabriele  ?

mmh, but the route is empty while we wait for the component because navigation is completed once the component is fetched, and that's also when the $route object is updated
what question?

you can do this. Add this line to the route file
Route::get('/{vue_capture?}', function () { return view('welcome'); })->where('vue_capture', '[/\w.-]*');

I think this really is an issue, I've just encountered this as-well reloading a page from within a route redirects to the root path after page load.

Is this problem solved? How did it work out? please

i am facing the same problem.... how to resolve this.. help me

https://drive.google.com/file/d/1sft5EsESSWJxG-PGhKhDeazY1V9PpMXU/view

I am facing same issue did you solve?

Is there an update to this issue? I am facing the same problem.

I have a similar case happening. Posted here https://stackoverflow.com/questions/56382623/vue-router-does-not-stay-on-same-page-after-a-page-refresh?noredirect=1#comment99367061_56382623

@theorange7 Same problem here! Been struggling with it for a long time!

I'm also running into the same issue. If I try to query anything about the current route during a created/mounted hook, I get empty route objects if the component specified in the route is dynamically imported. This happens regardless of which descendent component I attempt to access this.$router from (i.e. it can be five levels of statically imported components down from the dynamically imported page component, and will still happen).
If I use a statically imported component for the page, the issue goes away. If I wait for an arbitrary amount of time (500-1000ms) with something like setTimeout, it (mostly) goes away. Neither of these is a particularly workable solution though.

I'm experiencing this as well on routes with lazy-loaded components. It seems likes since all the routes and their paths are defined ahead of time, it ought to be possible to $route.name to resolve to the correct route immediately.

After adding a name prop to route, It works for me.
 {path: '/store', component: Store, meta: {title: 'Store'}},
 {path: '/store', name: 'store', component: Store, meta: {title: 'Store'}},

P.S. I use vue-navigation with vue-router together

Not sure if this will solve other people's issues but I just wrapped the code that was checking the current route in a call to this.$router.onReady().
So, for example something like:
export default {
  ...,
  created () {
    this.$router.onReady(() => {
      if (this.$route.name === 'whatever') {
        this.doAThing()
      }
    }
  }
}

This will give a chance for async components to resolve and everything to get in order...I probably should have read the documentation more closely as it's all quite clearly explained 😅

didn't know vue-router has a hook, that's awesome!
onReady seems to be the best place to do things that relies on route/url stuff. thanks @mpbarlow for mentioning it

Doesn't it worked yet? When we'll be able to get id even page is refreshed?

After reloading the page from any path defined in the router, if I tried to access this.$route inside the mounted hook of the component, if returned path: / and name: undefined. With a computed property I was able to get the current route path and name correctly.
computed: {
  routeName() {
    return this.$route.name;
  },
},

Welp after some hours i found a solution.
Vue router got different modes for history saving. One of them is Hash mode.
At your index.js in router folder,
import { createRouter, createWebHashHistory } from "vue-router";
import { publicPath } from '../../vue.config'
/*...*/
const router = createRouter({
  history: createWebHashHistory(),
  base: publicPath,
};

Other modes are well listed in here: https://router.vuejs.org/guide/essentials/history-mode.html
Shorty,

Hash mode(createWebHashHistory):
It uses a hash character (#) before the actual URL that is internally passed. Because this section of the URL is never sent to the server, it doesn't require any special treatment on the server level. It does however have a bad impact in SEO. If that's a concern for you, use the HTML5 history mode.

HTML5 mode(createWebHistory):
When using createWebHistory(), the URL will look "normal," e.g. https://example.com/user/id. Beautiful!
Here comes a problem, though: Since our app is a single page client side app, without a proper server configuration, # the users will get a 404 error if they access https://example.com/user/id directly in their browser. Now that's ugly.
Not to worry: To fix the issue, all you need to do is add a simple catch-all fallback route to your server. If the URL doesn't match any static assets, it should serve the same index.html page that your app lives in. Beautiful, again! but it wont work in github LOL

Memory mode(createMemoryHistory)
The memory history mode doesn't assume a browser environment and therefore doesn't interact with the URL nor automatically triggers the initial navigation. This makes it perfect for Node environment and SSR. It is created with createMemoryHistory() and requires you to push the initial navigation after calling app.use(router).
While it's not recommended, you can use this mode inside Browser applications but note there will be no history, meaning you won't be able to go back or forward.

Route::get('/{pathName?}', function(){
return view('main');
})->where('pathName', ".*");


Help with the table

[Enter feedback here]
I'm sorry, I don't quite grock how to read the version table here.  Does this indicate that .Net Standard 2.1 supports EF Core 5.0? (I thought it supported EF Core 2.1)
And doe sit also indicate that you can use EF Core 3.1 with .Net Classic 4.7.2?

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: a720e16e-991f-6802-033c-63269ad8a435
Version Independent ID: 9d6e9856-615b-0eb0-bf04-6a7ee3d6949d
Content: Supported .NET implementations - EF Core
Content Source: entity-framework/core/miscellaneous/platforms.md
Product: entity-framework
Technology: entity-framework-core
GitHub Login: @bricelam
Microsoft Alias: avickers

Yes and yes

Thank you!
On Fri, Mar 4, 2022 at 12:25 AM Erik Ejlskov Jensen <
@.***> wrote:

Yes and yes
—
Reply to this email directly, view it on GitHub
https://github.com/dotnet/EntityFramework.Docs/issues/3753#issuecomment-1058873100,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AA424Z2MK7LZZQVVWVBEHC3U6GUFLANCNFSM5P4EKBGA
.
You are receiving this because you authored the thread.Message ID:
@.***>


Add support for .NET applications

New Relic has support for .NET application and it would be great if we could have support for the .NET New Relic agent added to this buildpack so that we can increase the feature set of this buildpack and allow for .NET developers to use New Relic with their applications.

If anyone in the community is interested in this feature, let us know. I've been trying to test the latest additions in #120 but I don't have a huge amount of New Relic experience, so I've been running into issues connecting my app. Any help testing would be much appreciated!


GraphQLContext annotation adds the query to the top-level query as well.

As in the SocialNetworkQuery sample I can attach the query to an existing domain without changing the class itself. It works, but it also adds the query to the top-level "QUERY_ROOT" also by default (as it sometimes make sense to pass the context explicitly).
It would be nice to have a way to control this behavior and disable if it's possible.

I can say that it would be nice to control this behavior. A nice-to-have indeed.

I have the same request. In my test code I have users with orders. My orders are listed using the user as argument. I don't want to expose this method in my root.

1 for this

Feels like the default behaviour should be to not add something to the QUERY_ROOT.
Or perhaps have a GraphQLContext which adds to the root and at GraphQLExtension annotation which doesn't?

I've finally fixed this in master, will be released in v0.9.4, likely tomorrow.
The nested operations will not be added to QUERY_ROOT any longer. For now, there's no automatic way to get the old behavior, so creating an additional method without @GraphQLContext is needed.
I was trying to add the ability to get the old behavior if the same argument has both @GraphQLContext and @GraphQLArgument, but it ended up causing too much complexity for relatively little gain so I decided against it. If you see this feature as useful/important, drop a line.


Update node deps

Two questions:

Should I check in the updated node_modules? It is common for Node.js projects to not check it in.
Should I merge this into release/3.3 or will the project do it?

Updating the dependencies is a somewhat complicated process, because we also need to support non-Node.js users.
If you explain which dependencies you want to update and why, I can take care of the updates.

@hegemonic By non-Node.js users, do you mean Rhino only? This PR doesn't actually work for Rhino for now but I have a patch for that (the shim needs some updating). If there is anything else needed to fix I can do that.
The main reason I did this was the way-too-old async version causing some conflicts in my system.

OK just fixed the issue on Rhino. All tests are passing again.

Fixed on master and the releases/3.3 branch by commit a2ce6a79ad314768cafa417a4fe02da3b33144a8. (As I said, it's faster to just update the dependencies than to explain exactly how to do it.)
Thanks for explaining the rationale, and for the process.platform fix.

@hegemonic Cool thanks.


Formatting not working as expected

I have made a discussion post about this without much traction.
My editor setup has been left at the bottom.
TLDR
Templ is formatting my html in a way that is  frustrating, and I cant seem to get around it. I assume that I have made a mistake somewhere, but if this is actually the formatting of templ fmt, I believe it is far too opinionated.
Take this snippet for example:
templ Development(d models.Development, isAdmin bool) {

        { d.Name }

            for _, img := range d.Images {

            }

        @DevelopmentDetails(d, isAdmin)

}

I have absolutely no Idea why it keeps forcing attributes onto the same line, even after I manually break it up.
What I have tried
I manually edit the following piece to have attributes on a single line:

But once I save, I get this back:

The formatting is the same when I use templ fmt on the file.
The formatting doesn't make any logical sense to me. Why break in the middle of the src attr?  The formatting rules seem extremely opaque and hard to understand.
Editor setup
I am using neovim with a Lsp-Zero setup. The LSP is installed with Mason and mason-lspconfig.
As per These Instructions I have specifically opted for lsp-zero to format templ files with only the templ LSP.
lsp_zero.format_on_save({
	format_opts = {
		async = false,
		timeout_ms = 10000,
	},
	servers = {
		["templ"] = { "templ" },
	},
})

This is my mason.lua file with my mason handlers:
local mason = require("mason")
local mason_lspconfig = require("mason-lspconfig")
local lsp_zero = require("lsp-zero")
local lspconfig = require("lspconfig")

-- Setup Mason for language servers
mason.setup({})

local mason_handlers = {
	-- Any language server not listed here will be handled by the default
	lsp_zero.default_setup,

	-- other lsp's here ...

	-- tailwindcss
	["tailwindcss"] = function()
		lspconfig.tailwindcss.setup({
			cmd = { "tailwindcss-language-server", "--stdio" },
			filetypes = {
				"html",
				"css",
				"scss",
				"javascript",
				"javascriptreact",
				"typescript",
				"typescriptreact",
				"svelte",
				"vue",
				"templ",
			},
			init_options = { userLanguages = { templ = "html" } },
			root_dir = lspconfig.util.root_pattern(
				"tailwind.config.js",
				"tailwind.config.cjs",
				"tailwind.config.ts",
				"tailwind.config.tsx",
				"tailwind.config.json",
				".git"
			),

			on_attach = function(client, bufnr)
				lsp_zero.async_autoformat(client, bufnr)
			end,
		})
	end,

	-- html
	["html"] = function()
		lspconfig.html.setup({
			filetypes = { "html", "templ" },
		})
	end,

	-- htmx
	["htmx"] = function()
		lspconfig.htmx.setup({
			filetypes = { "html", "templ" },
		})
	end,

	-- templ (https://github.com/a-h/templ)
	["templ"] = function()
		lspconfig.templ.setup({
			filetypes = { "templ" },
		})
	end,
}

-- Include templ file type
vim.filetype.add({ extension = { templ = "templ" } })

mason_lspconfig.setup({
	-- Replace the language servers listed here
	-- with the ones you want to install
	ensure_installed = {
		-- Web stuff
		"tsserver",
		"html",
		"htmx",
		"tailwindcss",
		"svelte",
		"eslint",
		-- Must have language servers
		"rust_analyzer",
		"lua_ls",
		"gopls",
		"pylsp",
	},
	handlers = mason_handlers,
})

@RafaelZasas What version of templ are you running? templ version you may find that this will be resolved in the new release.

@RafaelZasas What version of templ are you running? templ version you may find that this will be resolved in the new release.

I am running v0.2.543

@RafaelZasas Did you install it via go install ? If so you could try go install github.com/a-h/templ/cmd/templ@main, this is the latest unstable release, which is chock full of improvements.

Though we'll be cutting a stable release soon :)


x86/Win32 compilation and using boost json

What's your question?
How to compile jwt-cpp in an existing win32 c++ library, using boost json?
Additional Context
My c++ skills are really lousy, but I need to integrate jwt-cpp into an existing win32 library, preferably using boost json if possible. Can someone please help me into the right direction. I'm using Visual Studio 2022 and get weird compiler errors regarding openssl, like this:
1>C:\asd\Downloads\openssl-3.1.2\openssl-3.1.2\include\openssl\opensslconf.h(14,11): fatal  error C1083: Cannot open include file: 'openssl/configuration.h': No such file or directory

I downloaded the latest openssl code, and there is only a configuration.h.in file. Tried to rename it, but I get a million other errors after that.
Sorry about the noob question, but I've spent days on trying to verify jwt tokens in a win32 c++ library... In c# I did it in 5 minutes :/

From what I can tell just looking at your description and the error message, it seems like you didn't install openssl correctly (only copied the source files and not building it).
Unlike jwt-cpp, which is a header only library and can just be dropped into the project, you need to build openssl, during which the configuration.h.in file should get filled with information about your build and renamed to configuration.h.
Assuming you use visual studio for development the easiest way to get everything working would be to use the nuget package for both jwt-cpp and openssl.
If you don't use visual studio or don't want to use nuget, you can install a prebuilt version of it like this.

As this is a problem with installing dependencies, I am going to close this.
As Thalhammer mentioned, you should really look into using a package manager, given you need at least three it makes it a ton easier, Nuget, VCPKG, and Conan are great options to look into :)


Appending items from both sides of the list

How can I append new items to the list from both sides? For example, for messaging app, there is a need for appending items as from the top as history and from the bottom as new messages. How can one achieve this behavior?

duplicate of #56


z does not work on folder names with parantheses

Steps to reproduce

mkdir ~/\(whatever\)
z ~/\(whatever\)

Expected result
It changes directory to ~/(whatever)
Actual result
'/home/donjar/(whatever)' did not match any results⏎
Versions
$ fish -v
fish, version 2.7.1
$ fisher -v
fisherman version 2.13.2

Looks like awk prints out the result in single quotes if the string has brackets in it:
after tweaking z to print $target:
❯ z what                                                                                12:36:58 PM
'/home/jethro/(whatever)'

❯ z code                                                                                12:37:27 PM
/home/jethro/Documents/Code

not sure how to fix this properly.

What about running it though string escape?
❯ string escape -n '/home/jethro/(whatever)'
/home/jethro/\(whatever\)

how would you pass the quoted string to string escape? i.e.
set -l test "'test'"

how to transform $test into a string without quotes?

There's also:
❯ z ~\(
awk: illegal primary in regular expression ~( at
 input record number 1, file /Users/joe/.local/share/z/data
 source line number 51
``

Maybe the arg should be escaped before being passing into awk (I haven't looked the impl)?

Should be fixed now, closing.


Entities in a DataSource with clustering enabled disappear when the camera zooms in below ellipsoid

Sandcastle example: https://sandcastle.cesium.com/index.html#c=bVLBbuIwEP0VK5emUuKAFoqgAbWie1tppbbqKRfjDMHCsSN7QpdW/fedJISUXSwfPDNv3jw/W1rjkR0UvINjS2bgna3Bq7rkb20uzALZxmtrUCgDLgtu7zOTGdl25gLFi62dhMvude3Rlk/nanhTHuMGHPs2vmlIOorKeoXKGiLom4VDWzhR7ZTkaJuQCsKE1+pbR3OgcAA+jGdzPp9OJ+N5xCYjPrmbTmaziMXT22EcGFR4pGGDdN7mFHgu8jz8zAyj1ctanE9RX1AGF+wEazPqD+gX9QELNh5FQ15abd3ifKsm4s8/n06Ir8x8dVZ+UyI1GQdOmYJEiY2GnJSiq4GA3SvxAd3pHeKO7QTzEgzxiRKc4Nra/SOG55tcPFVv749wFDHa8XjU+nVBVGi7AZ5DhbtX8PhY0Gfw+ArO0YE0boX2jcggClKPRw2r3ocHVVbWIaudDjlPEMpKC5qYbGq5B+TS+2ZaA02T761prg5M5csrX5BJLbynyrbWrfNZsEoTwv/Xqq3Iyc3fB3BaHBvYbrz61SU552lC4fVOtFZvhPuH+S8
Initially, the red point is visible.  Zoom in a bit and it will disappear; zoom back out and it reappears.
Browser: Google Chrome, Version 115.0.5790.170 (Official Build) (64-bit)
Operating System: Ubuntu 20.04

Before:

After zooming in:

Thanks for the report @zachsussman! I can reproduce this.
I don't think this necessarily has to do with clustering. I see similar behavior when I comment out the line
dataSource.clustering.enabled = true;
Notably this only occurs when the entity is a a negative height. I beleive this is due to the depth plane. Some additional details and possible workarounds are detailed in https://github.com/CesiumGS/cesium/issues/7879.
I'm also going to close this as a duplicate of #7879, but will add your report there.

Thanks @ggetz! Unfortunately, it looks like clustering is related after adding depthPlaneEllipsoidOffset.  With clustering on, the issue still happens, while with clustering off, depthPlaneEllipsoidOffset fixes the issue.

Since this is specific to clustering, I'll reopen the issue. Thanks!


Test: q15_from_dbl()

Need test for validation and accuracy.  Note that the accuracy will probably change somewhat between platforms, so the environment needs to be specified.

Tested and working


Release the latest version to atmosphere

The v0.97.8 release doesn't include 2 important fixes:

Added _badges.scss
Changed fonts path in packages.js

It prevent from me to upgrade to the latest version that include a lot of meaningful fixes and enhancements.
Is it possible to publish new release?

We are planning on releasing a new version within the month

Ok, thanks for the update


docs: create separate changelog

This PR moves the README > Changelog section contents to a separate new file CHANGELOG.md in the root of the repository.
This is in preparation to add more details to the Changelog, which would make it overly long to be displayed directly in the README file itself. Once this PR is reviewed and merged, I will submit a follow-on PR to expand the details in the new CHANGELOG.md.
I also plan to submit a separate PR with new information about GitHub compatibility.

New file is https://github.com/MikeMcC399/github-action/blob/move/changelog/CHANGELOG.md
Changed sections start at https://github.com/MikeMcC399/github-action/blob/move/changelog/README.md#changelog


Update certificates.py

Regex expression update for email

Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context. List any dependencies that are required for this change.
Dependencies : N/A
Contribution Guidelines
Please Read through the Contribution Guidelines.
Fixed Issues
Please mention any issues fixed in the PR by referencing it properly in the commit message.
As per the convention, use appropriate keywords such as fixes, closes, resolves to automatically refer the issue.
Please consult official github documentation for details.
Fixes #(issue)
"BEFORE" and "AFTER" output
To verify that the change works as desired, please include an output of terminal before and after the changes under headings "BEFORE" and "AFTER".
BEFORE
Any Terminal Output Before Changes.
AFTER
Any Terminal Output Before Changes.
Contribution checklist

[x] I have read the Contributing Guidelines.
[ ] The commits refer to an active issue in the repository.
[ ] I have added automated testing to cover this case.

Notes
Please mention if you have not checked any of the above boxes.

Hi @RDxR10
We want to merge, just fix the linting issue:
flake8
./kube_hunter/modules/hunting/certificates.py:16:175: B950 line too long (174 > 120 characters)
Makefile:29: recipe for target 'lint-check' failed


Export all data as structured format

As an admin, I want export all my data from an instance, so that I can import the data to another product
Given I have an ZITADEL instance,
When I export all data,
Then I receive all users, organizations, projects, clients with all their standard data (no ZITADEL only information) as structured format

Isn't it a duplicate of this one: https://github.com/zitadel/zitadel/issues/3783 ?

I reckon most of this could be re-used. We could provide a "generic" way to export data as structured format.

A widely used solution would be scim: http://www.simplecloud.info


Give user a link to create PR after push

New Feature
This PR offers a link to create new pull request when we push to a branch which is not the default branch.
If a PR already exists, it just give the link to the existing PR.
Output of a push when no active PR exists:
[branch2/test be40717] test
 1 file changed, 1 deletion(-)
Counting objects: 3, done.
Writing objects: 100% (3/3), 255 bytes | 255.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0)
remote:
remote: Create a new pull request for 'branch2/test':
remote:   http://localhost:3000/test1/test/compare/master...branch2%2Ftest
remote:
To http://localhost:3000/test1/test.git
   0c5683f..be40717  branch2/test -> branch2/test

Output of a push when an active PR exists:
[branch2/test 453d638] test
 1 file changed, 1 insertion(+)
Counting objects: 3, done.
Writing objects: 100% (3/3), 255 bytes | 255.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0)
remote:
remote: Visit the existing pull request:
remote:   http://localhost:3000/test1/test/pulls/6
remote:
To http://localhost:3000/test1/test.git
   be40717..453d638  branch2/test -> branch2/test

Now i wanna talk about some technical decision i took :

In case of errors, I log but does nothing because I don't want this feature to block anything.
I created 2 internal endpoints, but I though about an option where i could make only one that gave me everything I needed : the PR default branch + the PR if it exists.
About the fork limitation, If you guys think it's better to create the PR in the "base" repository, then maybe it's better to consider to use what i described above to have the url generation out of the cmd/hook.go file

Codecov Report

Merging #4716 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #4716      +/-   ##
=========================================
- Coverage   20.71%   20.7%   -0.01%
=========================================
  Files         167     167
  Lines       32355   32355
=========================================
- Hits         6702    6699       -3
- Misses      24672   24674       +2
- Partials      981     982       +1

Impacted Files
Coverage Δ

modules/process/manager.go
69.56% <0%> (-4.35%)
:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc06ab4...37822e0. Read the comment docs.

gitea_no_gcc should be removed.
I think the PR should be in base repository.

And you also should check if user has permission to visit and create pull request.

I also agree that PR should be for base repository as that is default behaviour from UI

Ok I will first add the fork thing.

And you also should check if user has permission to visit and create pull request.
I'm not sure how to do that. I took a look at the "web" router to access to PR creation page and I found this :
https://github.com/go-gitea/gitea/blob/7781e8cef2dfe73d71be7804f4c5a7c5f1995d31/routers/repo/issue.go#L79

Is that what I must us implement ?

Forks are now created for the base repository.
Ensure that the "target" repository has enabled PR.

Hi guys, any news on this ?

@JulientTant it looks good, nice work but I want to test it first before I give my approval

Of course. I tried to lot of cases but if you find anything i'll be happy to fix/change things.

up?

We are feature freeze currently so need to wait until v1.6.0-rc1 is released