Outdated labels in the probability_map

Two e-type labels of the current probability_map have been updated in the SSCx/NCX taxonomy:

SLAC -> SAC
DLAC -> LAC

It has been asked to update the probability_map.csv (including the L1_ labels) to reflect such an update in the filename of the generated densities.
@HDictus @dkeller9

Are these mtypes or etypes?

m-types looking at
dict_BBP_mtypes = {
    'ChC': 'CHC',
    'DLAC': 'LAC',
    'SLAC': 'SAC'}

in https://bbpteam.epfl.ch/project/issues/browse/BBPP82-466?focusedCommentId=159057


Fixing the 'already downloaded' checking condition

This fixes the bug that the 'already downloaded' condition, which is in _shared.py, does not check the size of the downloaded file. When the network connection is extremely slow, the download operation prematurely finishes, and, in turn, the downloaded file is moved to its proper path. Since _shared.py simply checks the existence of the to-be-downloaded files to check whether they are already downloaded, executing udemy-dl again does not recognize such incomplete downloads so that they are skipped over in the retry of udemy-dl

@euiseong  i think this is not a proper fix and later on it breaks more functionalities so i 'm closing this PR. How can i reproduce this error.

Ok, I agree.
The problem I mentioned occurs when the network connection to Udemy is slower like a few KB/s.
While downloading an MP4 file, udemy-dl suddenly moves on to the next file after changing the temporary file to the permanent file even though it is not completed yet. You can reproduce this by limiting the network bandwidth and downloading a big MP4 or zip file. Just wait for a sufficiently long time.
By the way, I appreciate you for your program. I was struggling against the slow bandwidth and downloading MP4 files with udemy-dl solved my problem.
Euiseong.

On 15 Apr 2019, at 4:32 PM, Nasir Khan<EMAIL_ADDRESS>wrote:
@euiseong https://github.com/euiseong i think this is not a proper fix and later on it breaks more functionalities so i 'm closing this PR. How can i reproduce this error.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub https://github.com/r0oth3x49/udemy-dl/pull/371#issuecomment-483139844, or mute the thread https://github.com/notifications/unsubscribe-auth/AVR5gqla6hx4boqhpxPoIk9vcmhsbvYBks5vhCr8gaJpZM4cvIS5.


Walkthrough SVGs are not loading on web

SVGs don't show up at all.

Tested in Edge Dev both with tracking protection/adblockers enabled and disabled.

upstream fixed


when outputing only print works

when i try to output only  can work

Hi @adolyb 👋 Thank you for reaching out.
It looks like you are using the Code Runner extension, please reach out to them instead (link to their repo). Closing this.


Add and Remove Recognition Types

Add Recognition Type:

[x] Protected

Remove the following recognition types from the drop-down list. They had no legislative acts or sites associated with them:

[x] area designation
[x] covenant
[x] crown owned
[x]  heritage designation (was associated with act but now not)
[x] designated site (was associated with act but now not)

Emerald's list of legislative act changes
To Remove legislative Act:
Municipal, Municipal Act, s 977(1), Other (EeRb-157, EeRb-158) These sites were changed to existing legislative act Municipal, Municipal Act, s 977(1), Designation. Not sure if there is more testing to do before removing this because Acts appear as "Object Object" and are not definitive in record edit history - so I don't really see a point in keeping this?
Legislative Acts edited:
Provincial, Heritage Conservation Act, s 9, s 13(1)(a), Designated Site > changed to > Provincial, Heritage Conservation Act, s 9, s 13(1)(a), Designation (21 sites affected)
Municipal, Local Government Act, s 967, Heritage Designation > changed to > Municipal, Local Government Act, s 967, Designation (1055 sites affected)
Municipal, Local Government Act, s 611, Heritage Designation > changed to Municipal, Local Government Act, s 611, Designation (234 sites affected)

Emerald completed adding and removing recognition types in test in the Reference Data Manager. No issues resulted so proceeded with updating the following recognition types in Prod and added description for new "Protected" recognition type.


Build docker image for HA

Signed-off-by: cheyang<EMAIL_ADDRESS>
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews

Codecov Report

Merging #816 (15fd42d) into master (b5c9aab) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #816   +/-   ##
=======================================
  Coverage   13.12%   13.12%
=======================================
  Files         106      106
  Lines        4794     4794
=======================================
  Hits          629      629
  Misses       4103     4103
  Partials       62       62

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5c9aab...15fd42d. Read the comment docs.


[prerelease] panic with index out of range [1] when reading existing function

Terraform CLI and Provider Versions
Terraform v1.6.5
on darwin_arm64
Provider is built from current main branch (pre-0.86.0)
Terraform Configuration
I can reproduce the problem with just this
resource "snowflake_function" "my_function" {
  name            = "MY_FUNCTION"
  database        = "MY_DB"
  schema          = "MY_SCHEMA"
  return_type     = "VARCHAR"
  return_behavior = "IMMUTABLE"
  statement       = "SELECT PARAM"
  arguments {
    name = "PARAM"
    type = "VARCHAR"
  }
}

Expected Behavior
Based on the steps to reproduce, the last step should result in Your infrastructure matches the configuration.
Actual Behavior
terraform plan fails with the following stack trace:
Stack trace from the terraform-provider-snowflake plugin:

panic: runtime error: index out of range [1] with length 1

goroutine 3649 [running]:
github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk.NewSchemaObjectIdentifierFromFullyQualifiedName({0x1400026c230?, 0x0?})
    ~/code/Snowflake-Labs/terraform-provider-snowflake/pkg/sdk/identifier_helpers.go:208 +0x344
github.com/Snowflake-Labs/terraform-provider-snowflake/pkg/resources.ReadContextFunction({0x1065eef50, 0x14000898770}, 0x1400150a780, {0x1065aad00?, 0x14000e85790?})
    ~/code/Snowflake-Labs/terraform-provider-snowflake/pkg/resources/function.go:515 +0x1f4
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).read(0x14000cb3260, {0x1065eeea8, 0x140006d6d20}, 0xd?, {0x1065aad00, 0x14000e85790})
    ~/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.31.0/helper/schema/resource.go:795 +0xe8
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*Resource).RefreshWithoutUpgrade(0x14000cb3260, {0x1065eeea8, 0x140006d6d20}, 0x1400160eea0, {0x1065aad00, 0x14000e85790})
    ~/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.31.0/helper/schema/resource.go:1089 +0x430
github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema.(*GRPCProviderServer).ReadResource(0x14000cc84b0, {0x1065eeea8?, 0x140006d6bd0?}, 0x14000896b80)
    ~/go/pkg/mod/github.com/hashicorp/terraform-plugin-sdk/v2@v2.31.0/helper/schema/grpc_provider.go:663 +0x3e4
github.com/hashicorp/terraform-plugin-mux/tf5to6server.v5tov6Server.ReadResource({{0x106604458?, 0x14000cc84b0?}}, {0x1065eeea8?, 0x140006d6bd0?}, 0x14000896a00?)
    ~/go/pkg/mod/github.com/hashicorp/terraform-plugin-mux@v0.13.0/tf5to6server/tf5to6server.go:176 +0x228
github.com/hashicorp/terraform-plugin-mux/tf6muxserver.(*muxServer).ReadResource(0x1065eeee0?, {0x1065eeea8?, 0x140006d68d0?}, 0x14000896a00)
    ~/go/pkg/mod/github.com/hashicorp/terraform-plugin-mux@v0.13.0/tf6muxserver/mux_server_ReadResource.go:35 +0x184
github.com/hashicorp/terraform-plugin-go/tfprotov6/tf6server.(*server).ReadResource(0x14000b34820, {0x1065eeea8?, 0x14000f17ec0?}, 0x1400108c300)
    ~/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.20.0/tfprotov6/tf6server/server.go:787 +0x390
github.com/hashicorp/terraform-plugin-go/tfprotov6/internal/tfplugin6._Provider_ReadResource_Handler({0x106559360?, 0x14000b34820}, {0x1065eeea8, 0x14000f17ec0}, 0x1400150a500, 0x0)
    ~/go/pkg/mod/github.com/hashicorp/terraform-plugin-go@v0.20.0/tfprotov6/internal/tfplugin6/tfplugin6_grpc.pb.go:467 +0x164
google.golang.org/grpc.(*Server).processUnaryRPC(0x140000ded20, {0x1065eeea8, 0x14000f17e30}, {0x1065ffa60, 0x140001036c0}, 0x14000dcac60, 0x14000d93710, 0x1073dbb88, 0x0)
    ~/go/pkg/mod/google.golang.org/grpc@v1.60.0/server.go:1372 +0xb8c
google.golang.org/grpc.(*Server).handleStream(0x140000ded20, {0x1065ffa60, 0x140001036c0}, 0x14000dcac60)
    ~/go/pkg/mod/google.golang.org/grpc@v1.60.0/server.go:1783 +0xc44
google.golang.org/grpc.(*Server).serveStreams.func2.1()
    ~/go/pkg/mod/google.golang.org/grpc@v1.60.0/server.go:1016 +0x5c
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 43
    ~/go/pkg/mod/google.golang.org/grpc@v1.60.0/server.go:1027 +0x138

Steps to Reproduce

Install a currently released version of the provider (I started from 0.79.0)
Deploy the above configuration to create a function
Run terraform plan. You should see Your infrastructure matches the configuration..
Install the 0.86.0 version of the provider (I built this off the current main branch)
Run terraform plan.

How much impact is this issue causing?
Medium
Logs
No response
Additional Information
I am filing this issue about a pre-release version so it isn't a real issue yet. I am flagging in the off-chance that it hasn't already been noticed and ends up being released.

Hey @sonya. Thanks for bringing this to our attention.
I have fixed the behavior in #2503 by adding a state upgrader. We will release it today but you can check it prerelease if you want :)


Fix filters

General description
This PR fixes the analysis filters sometimes clearing themselves.
When a scenario changed, we checked those filter to remove those that don't belong in the scenario, but didn't filter them recursively. Hence, selecting a child would invalidate the selection.
While another state solution isn't used, the useQueryParam hook was refactored to allow multiple observers in the same page. Otherwise, observing the current scenario without entering a infinite loop was next to impossible.
https://vizzuality.atlassian.net/browse/LANDGRIF-1021
Checklist before merging

[x] Branch name / PR includes the related Jira ticket Id.
[ ] Tests to check core implementation / bug fix added.
[ ] All checks in Continuous Integration workflow pass.
[ ] Feature functionally tested by reviewer(s).
[ ] Code reviewed by reviewer(s).
[x] Documentation updated (README, CHANGELOG...) (if required)

LGTM!


Authentication errors using pyzotero

General
Platform:  MacOS Mojave
Python version:  3.7
Pyzotero version: 1.4.4
Problem description
I'm running the sample from the README:
from pyzotero import zotero
zot = zotero.Zotero(library_id, 'user', api_key)
items = zot.top(limit=5)
# we've retrieved the latest five top-level items in our library
# we can print each item's item type and ID
for item in items:
    print('Item: %s | Key: %s' % (item['data']['itemType'], item['data']['key']))

I got the library_id from here as per the README (the user ID) and create a new key here with all permissions.
If possible, paste the full traceback in a code block below, and fill in the summary

Traceback
Traceback (most recent call last):
  File "/usr/local/lib/python3.7/site-packages/pyzotero/zotero.py", line 426, in _retrieve_data
    self.request.raise_for_status()
  File "/usr/local/lib/python3.7/site-packages/requests/models.py", line 940, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 403 Client Error: Forbidden for url: https://api.zotero.org/users/1535871/items/top?limit=5&format=json

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "tt.py", line 3, in <module>
    items = zot.top(limit=5)
  File "/usr/local/lib/python3.7/site-packages/pyzotero/zotero.py", line 193, in wrapped_f
    retrieved = self._retrieve_data(func(self, *args))
  File "/usr/local/lib/python3.7/site-packages/pyzotero/zotero.py", line 428, in _retrieve_data
    error_handler(self, self.request)
  File "/usr/local/lib/python3.7/site-packages/pyzotero/zotero.py", line 1635, in error_handler
    raise error_codes.get(req.status_code)(err_msg(req))
pyzotero.zotero_errors.UserNotAuthorised:
Code: 403
URL: https://api.zotero.org/users/1535871/items/top?limit=5&format=json
Method: GET
Response: Forbidden

using
curl -H "Zotero-API-Version: 3" -H "Zotero-API-Key: the-api-key" "https://api.zotero.org/users/1535871/items/top?limit=5&format=json"

does work

as does
curl -H "Zotero-API-Version: 3" -H "Authorization: Bearer the-api-key" "https://api.zotero.org/users/1535871/items/top?limit=5&format=json"

To boil it down further: it looks like there's something odd going on in requests:
import os

api_key = os.environ['ZOTERO_API_KEY']
user_id = os.environ['ZOTERO_USER_ID']

url = f'https://api.zotero.org/users/{user_id}/items/top?limit=5&format=json'
headers = {'User-Agent': 'Pyzotero/1.4.4', 'Zotero-API-Version': '3', 'Authorization': f'Bearer {api_key}' }

# this succeeds
curl_headers = ' '.join([f'-H "{k}: {v}"' for k, v in headers.items()])
os.system(f'curl {curl_headers} "{url}"')
print('')

# this gets a 403 response
import requests
request = requests.get(
  url=url,
  headers=headers
)
print(request)

# this gets a 200 response
import urllib.request
req = urllib.request.Request(url)
for k, v in headers.items():
  req.add_header(k, v)
r = urllib.request.urlopen(req)
print(r.getcode())

Further check: this script works on Ubuntu 19.04, so it looks like it's a problem in the requests library that's specific to MacOS.

Hmm. I can't replicate this on High Sierra using Python 3.7.3 and Requests 2.22.0. What Requests version are you using?

2.20.1 (see also https://github.com/psf/requests/issues/5158)

Ah, OK. I've bumped the minimum version to 2.21.0 for v1.4.6.

Doesn't help for me. python3 -m requests.help now shows
{
  "chardet": {
    "version": "3.0.4"
  },
  "cryptography": {
    "version": "2.7"
  },
  "idna": {
    "version": "2.7"
  },
  "implementation": {
    "name": "CPython",
    "version": "3.7.3"
  },
  "platform": {
    "release": "18.7.0",
    "system": "Darwin"
  },
  "pyOpenSSL": {
    "openssl_version": "1010103f",
    "version": "19.0.0"
  },
  "requests": {
    "version": "2.22.0"
  },
  "system_ssl": {
    "version": "1000213f"
  },
  "urllib3": {
    "version": "1.25.3"
  },
  "using_pyopenssl": true
}

but requests still gets me 403 errors. So it looks like it's a Mojave thing.

Ugh. I wonder whether it's an SSL issue, although I'm just guessing at this point.

That's what I was thinking initially but the call to key_info succeeds without errors.

the call to key_info succeeds without errors.

That's very confusing.

Yeah I don't know what to make of this at all.

If you:
import logging
logging.basicConfig(level=logging.DEBUG)

after importing requests, do you see anything interesting when a call fails?

The current script is now
import os

import requests
import logging
logging.basicConfig(level=logging.DEBUG)

import urllib.request

api_key = os.environ['ZOTERO_API_KEY']
user_id = os.environ['ZOTERO_USER_ID']

urls = [
  f'https://api.zotero.org/users/{user_id}/items/top?limit=5&format=json',
  f'https://api.zotero.org/keys/{api_key}',
]
headers = {'User-Agent': 'Pyzotero/1.4.4', 'Zotero-API-Version': '3', 'Authorization': f'Bearer {api_key}' }

for url in urls:
  print(url)
  # this gets a 403 response
  request = requests.get(
    url=url,
    headers=headers
  )
  print(request)

  # this gets a 200 response
  req = urllib.request.Request(url)
  for k, v in headers.items():
    req.add_header(k, v)
  r = urllib.request.urlopen(req)
  print(r.getcode())

which gets me
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): api.zotero.org:443
DEBUG:urllib3.connectionpool:https://api.zotero.org:443 "GET /users/1535871/items/top?limit=5&format=json HTTP/1.1" 403 9
DEBUG:urllib3.connectionpool:Starting new HTTPS connection (1): api.zotero.org:443
DEBUG:urllib3.connectionpool:https://api.zotero.org:443 "GET /keys/APIKEY HTTP/1.1" 200 182
https://api.zotero.org/users/1535871/items/top?limit=5&format=json
<Response [403]>
200
https://api.zotero.org/keys/APIKEY
<Response [200]>
200

OK, so nothing particularly useful there. Bah.

Closing this, as it's not really a Pyzotero error.


I still see Statemine & Statemint, not AHK or AHP

Incognito canary.kodadot.xyz
https://canary.kodadot.xyz/stt/explore/collectibles

https://canary.kodadot.xyz/ahp/explore/collectibles

lol on https://main.nft-gallery-5ci.pages.dev/ it's oke

solved by https://github.com/kodadot/nft-gallery/issues/6697#issuecomment-1676456146


improve how branch images skips

It's difficult to tell if the branch images was skipped or not, making it hard to pick the SHA out of the output and do a deployment.
This moves the part where it figures out if the PR is approved to a first step, and if it's not approved it skips the entire push-updater-images which makes it really obvious.

Don't approve this yet, still working out the kinks.

That's crystal clear.

Ready for approval.


Check if there can be multiple burned URITokenIDs when deleting account

@richardAH Can you please answer this?


1.0.0

TODO List

[x] add disable mode
[ ] add fallback input
[ ] add no-color slot
[ ] add scrollbar for the menu in the documentation site
[ ] enhance usability through keyboard
[ ] refactor Tests in separated files
[ ] update dev-dependencies, especially vue-loader
[ ] remove custom exceptions and its tests
[ ] reduce the bundle size
[ ] migrate to Webpack 4

Coverage remained the same at 100.0% when pulling 8307bb50b31220d18e771b590da04a2bae64f978 on 1.0.0 into a653202a5b7a06562eb1d4833edad044b4bf1af9 on master.


fixes gif quality issue

Closes #14561

Pre-Submission Checklist

[x] Your pull request targets the staging branch of freeCodeCamp.
[x] Branch starts with either fix/, feature/, or translate/ (e.g. fix/signin-issue)
[x] You have only one commit (if not, squash them into one commit).
[x] All new and existing tests pass the command npm test. Use git commit --amend to amend any fixes.

Type of Change

[x] Small bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds new functionality)
[ ] Breaking change (fix or feature that would change existing functionality)
[ ] Add new translation (feature adding new translations)

Checklist:

[x] Tested changes locally.
[x] Closes currently open issue (replace XXXX with an issue no): Closes #XXXX

Description

@pporche87 can you update the closes tag in the opening post of this PR, like below:
Closes #14561
Also, edit the PR title and make it shorter (preferable no longer than 50 chars).

@raisedadead done!

:sparkles: :sparkles: LGTM. :sparkles: :sparkles:
Great job! Thanks a lot @pporche87 ! And congrats on your first contribution to freeCodeCamp.


handlerRelease open issues

[ ] excercise

[ ] add text in README

handler Release died a messy death and was reborn as the packaging scripts like a phoenix rising from tucson's ashes. Closing.


Remove brew installation steps from docs

https://github.com/unyt-org/uix/commit/86f4aa3d5c137ab946bcacba961e7990247c45bd


Add event-based notifications to email_queue

The current email_queue implementation we have polls every 60 seconds for pending emails. This works fine for cases where delivery time isn't noticeable/important (payday emails, for example).
In scenarios where users expect an email immediately (verification link when adding an email, email sign-in links), a delay anywhere between 0-60 secs will be observed. We can make this better by adding event-based notifications in addition to the current polling mechanism. i.e. every time we insert an email into the database, we fire an event. The email_queue listens for that event and processes accordingly. Postgres supports LISTEN/NOTIFY.

Note: this will require some thinking about throttling. Currently, we throttle based on how many emails are in the queue already. If queue processing becomes almost instantaneous, then throttling will become ineffective.

@Changaco had input on this when we implemented throttling. He implemented an alternative on Liberapay, I don't remember the details off hand but we could dig that up.

Actually I still haven't implemented a throttling mechanism in Liberapay: https://github.com/liberapay/liberapay.com/issues/61.


debug: Enable jquery-migrate plugin in development

This plugin warns us about our use of deprecated jQuery features in the console. It turns out we have a lot of them.
JQMIGRATE: jQuery.fn.keydown() event shorthand is deprecated
JQMIGRATE: jQuery.fn.keypress() event shorthand is deprecated
JQMIGRATE: jQuery.fn.click() event shorthand is deprecated
JQMIGRATE: jQuery.fn.resize() event shorthand is deprecated
JQMIGRATE: jQuery.fn.bind() is deprecated
JQMIGRATE: jQuery.fn.scroll() event shorthand is deprecated
JQMIGRATE: jQuery.fn.focus() event shorthand is deprecated
JQMIGRATE: jQuery.fn.keyup() event shorthand is deprecated
JQMIGRATE: jQuery.fn.blur() event shorthand is deprecated
JQMIGRATE: jQuery.fn.focusout() event shorthand is deprecated
JQMIGRATE: jQuery.fn.change() event shorthand is deprecated
JQMIGRATE: jQuery.fn.hover() is deprecated
JQMIGRATE: jQuery.isArray is deprecated; use Array.isArray
JQMIGRATE: jQuery.fn.delegate() is deprecated
JQMIGRATE: jQuery.fn.removeAttr no longer sets boolean properties: disabled

Although the warnings are deduplicated, they’re still pretty spammy since each one comes with a traceback. So maybe we should make a pass at fixing them before merging this.

Yeah, I think it's probably worth pre-fixing these warnings, rather than spamming everyone's development console.


rubocops/uses_from_macos: allow keg only berkeley-db

The macOS SDK contains headers for Berkeley DB (1.8-era).
I believe people with our Berkeley DB installed are getting errors compiling OpenJDK as the newer header is shadowing the older one in the SDK.
To fix this, we should make it keg only.

Review period skipped due to critical label.

@bayandin No, I want to ensure that these get reviewed in Homebrew/brew.


createServerData$ is broken since solid-start version 0.2.19. It returns HTML instead of JSON.

Setup

pnpm create solid
No SSR

Code:
import { Title, useRouteData } from "solid-start";
import { createServerData$ } from "solid-start/server";

export function routeData() {
  return createServerData$(async () => {
    return {
      testData: 'testData'
    };
  });
}

export default function Home() {
  const getRouteData = useRouteData<typeof routeData>();
  return (
    <main>
      <Title>Hello World</Title>
      RouteData: <div>{getRouteData()?.testData}</div>
    </main>
  );
}

Unexpected result
The routeData URL returns HTML instead of JSON.
The problem happens in dev mode and also in the built version.

The console looks like:

Affected versions
Reproducible with solid-start version 0.2.19 - 0.2.23.
Version 0.2.18 is the last version that works.

Are you using ssr: false? I'm having the same problem, seems like it might have been introduced here in 0.2.19. I'm not sure why server$ methods can't work without SSR mode, but a better error message would be nice.

Yes, I'm using ssr: false.

Yes this is related to ssr: false disabling the server functions

Yeah I had to do this for consistency. Because if you wrote components that have client side only side effects it could crash the server when it imported them. People using ssr: false were not expecting client code to be present on the server so it made it errors that made no sense. Until we can do smarter code separation it meant I needed to disable server$ functions for ssr: false.
I guess technically they aren't being disabled is the problem? And it is trying to fetch against a non-existent end point so its just responding with the catch all.

@ryansolid What I think is, I'm not sure if this has been disproven, that server$ function isn't registered in the server if the module it is located from is only loaded on the client?

Yes so technically if you put all your server functions in a file that you import from both the components that use it and from the root of the project it should work still.

Shouldn't there be at least some 404 error when the server function HTTP request is called from the client? There seem to be no indication that something is wrong when working on a project, it just doesn't work.

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed by mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.


[query] Query projector is not handling NULL for aggregates over 0 rows

I have a query that looks like:
[:find
 (max ?at) .
 :in
 ?id
 :where
 [?c :credential/id ?id]
 [?l :login/credential ?c]
 [?l :login/at ?at]
]

That gets turned into the following SQL:
SELECT max(`?at`) AS `(max ?at)` FROM (SELECT DISTINCT `datoms02`.v AS `?at` FROM `datoms` AS `datoms00`, `datoms` AS `datoms01`, `datoms` AS `datoms02` WHERE `datoms00`.a = 65537 AND `datoms00`.v = $v0 AND `datoms01`.a = 65543 AND `datoms02`.a = 65542 AND `datoms02`.tx > 268435461 AND `datoms00`.e = `datoms01`.v AND `datoms01`.e = `datoms02`.e) LIMIT 1

The ScalarProjector has the following spec:
FindScalar(Aggregate(Aggregate { func: QueryFunction(PlainSymbol("max")), args: [Variable(var(?at))] }))

I get
Error(ProjectorError(DbError(BadSQLValuePair(Null, 4)))

and I surmise that the scalar projector either isn't handling zero rows correctly, or isn't handling a NULL result for aggregates correctly.  Presumably NULL means no result for scalars, but it's less clear to me what should happen for a NULL aggregate for the other query types.

This one is a lot easier to actually run:
.q [:find [(the ?a) (max ?b)] :where [_ ?a _ ?c] [?c :db/txInstant ?b] [(< ?b #inst "2016-01-01T11:00:00.000Z")]]

Presumably NULL means no result for scalars, but it's less clear to me what should happen for a NULL aggregate for the other query types.

The issue is that SQL(ite) yields NULL for an aggregate over 0 rows.  Datomic either does or would yield nil in this situation, but Mentat doesn't expose the equivalent in TypedValue.  It's not clear to me what the set of ValueTypes are that Mentat will aggregate over, but it might be that there is a sensible unit (i.e. 0 for longs, perhaps the epoch for instants, perhaps TX0 for transaction refs) in each case that we can coalesce NULL to.

the is a special case, in that it itself is a kind of aggregate.
Can you provide a repro case using a standalone variable?

the is a special case, in that it itself is a kind of aggregate.
Can you provide a repro case using a standalone variable?

I haven't seen one yet, and both my understanding of the problem and my testing suggests that it's not possible -- we have to force an aggregate across 0 SQL rows and the rel and coll projectors handle that correctly in the general case.

I haven't seen one yet, and both my understanding of the problem and my testing suggests that it's not possible -- we have to force an aggregate across 0 SQL rows and the rel and coll projectors handle that correctly in the general case.

So my understanding is intact, but you can force the situation also with a second aggregate:
.q [:find [(count ?a) (max ?b)] :where [_ ?a _ ?c] [?c :db/txInstant ?b] [(< ?b #inst "2016-01-01T11:00:00.000Z")]]


⚠ Bofrost.lu has degraded performance

In adc0a67, Bofrost.lu (https://www.bofrost.lu) experienced degraded performance:

HTTP code: 200
Response time: 2690 ms

Resolved: Bofrost.lu performance has improved in 29c8c53 after 25 minutes.


cdc: bump semver to v1.0

Signed-off-by: hi-rustin<EMAIL_ADDRESS>
What problem does this PR solve?
Issue Number: None
Problem Summary:
What is changed and how it works?
What's Changed:
Bump the semver version to v1.0.
Related changes
None
Check List
Tests

No code

Side effects
None
Release note
None

/merge

/merge

/run-integration-cdc-test


Ability to set file permissions on config files

:warning: TBD  – not ready for work
see also #269


Cannot resolve module 'ballerina/io'

Description:
Getting the below errors with a simple main function with ballerina/ballerina:swan-lake-preview8.
Compiling source
	wso2/applinking_test:0.1.0
ERROR [main.bal:(1:1,1:21)] cannot resolve module 'ballerina/io'
ERROR [main.bal:(6:5,6:29)] undefined function 'println'
ERROR [main.bal:(6:5,6:29)] undefined module 'io'
error: compilation contains errors

Steps to reproduce:
main. bal content:
import ballerina/io;

# Prints `Hello World`.

public function main() {
    io:println("Hello Wor!");
}

command to run:
docker container run --rm -v "$(pwd)":/home/ballerina -u "$(id -u)":"$(id -g)" -e JAVA_OPTS="-Duser.home=/home/ballerina" ballerina/ballerina:swan-lake-preview8 ballerina build

Affected Versions:
swan-lake-preview8

I couldn't reproduce the issue with a service. But I was able to reproduce with a main program.
import ballerina/io;
import ballerina/http;

service on new http:Listener(8090) {
    resource function get .(http:Caller caller, http:Request request) {
io:println("Hello");
    }
}

This is fixed now.


make test fails on imagecreatefromstring()

Not sure what is going on here but cannot complete the installation steps because make test fails on  imagecreatefromstring() image.phpt.
Naturally, the first thing I checked is the presence of gd and it was present.  Next I copied the imagecreatefromstring() example from the PHP docs into a regular .php file and, oddly enough, it works as expected.
php_test_results_20160416_1939.txt
Most strange :S
-Peter

I have dug into this further, I think the issue has got to be GD not being loaded by tmp-php.ini for some reason because if I enable the extension anyway and run the tests manually it works fine.  I thought it might be something to do with using the PHP CLI but the imagecreatefromstring() example above works fine using the CLI.

Thanks for reporting! You were spot on, the tmp-php.ini was leaving GD out.


Upgrade pip in linux full image

ue4-cli fails to install inside image because it depends on cryptography and the later require pip to be upgraded.

Thanks for your contribution!


Android Basics: Introduction to Room and Flow - grammar

In the "Define the ViewModel" step, there is a sentence that reads
"As the ViewModel class BusScheduleViewModel needs from is meant to be lifecycle aware, it should be instantiated by an object that can respond to lifecycle events."
Should this instead be?
"As the ViewModel class BusScheduleViewModel is meant to be lifecycle aware, it should be instantiated by an object that can respond to lifecycle events."

I agree.  Similarly, the sentence after it reads:
If you instantiate it directly in one of your fragments, then your fragment object will have to handle everything all the memory management, which is beyond the scope of what your app's code should do.
and perhaps should be:
If you instantiate it directly in one of your fragments, then your fragment object will have to handle everything, including all the memory management, which is beyond the scope of what your app's code should do.

@nichojo89 , @shepardsn
Thank you for reaching out to us. Your typo fix suggestions were reviewed and will be published soon:


Dictionary concatenation

Expected Behavior
Expect that two dictionary files
a.dict
# Dictionary A
abc

and
b.dict
# Dictionary B
def

are successfully concatenated together.
Actual Behavior
It seems like if file A doesn't have an end new line, then https://github.com/bazelbuild/rules_fuzzing/blob/547127916d662d729ed62164bb88edbff27e215b/fuzzing/tools/validate_dict.py#L43 won't write one, so the resulting dictionary becomes
# Dictionary A
abc# Dictionary B
def

which isn't valid.
I originally saw the issue in oss-fuzz logs:
Step #14: ParseDictionaryFile: error in line 24
Step #14: 		"%HOSTNAME%"# Dictionary to populate HeaderValueOptions

Whoops, thanks for spotting this. Let me take a look.


chore: first pass at maintainer covenant, fix #586

First pass at a Maintainer Covenant.  This is pretty rough, but let's get this to a form where it's helpful to people and then we can iterate.
Goals:

Primary: Help users answer the question, "Can this project be trusted?"
Secondary: Document the steps we have and, more importantly, have not taken to insure the integrity of this project
Secondary: Provide inspiration and a template for other projects to do the same

A note about "criteria"
I found myself drawing inspiration from ESLint, of all things.  I felt it was important to have specific, measurable (or at least evaluatable) criteria by which to assess a project.  Giving these ESLint-like names (e.g. no-shared-accounts) makes it easy to refer to and discuss each specific point.  It also gives maintainers a way of easily enumerating what it is they do / don't comply with.
The criteria I've listed so far are pretty specific to security, but I can imagine other stuff outside of that.  E.g. unit-tests or typed-language that speak more to code quality.  A part of me thinks this would be useful, but another part of me feels that sort of thing should be out of scope.  Thoughts?
[Note: I accidentally pushed this to master then had to revert... and added the "no-main-commit" criterion as a result. 😂 ]

News: coa and rc packages compromised source

Funny thing, I maintain svgo, which depended on coa in v1 which I deprecated recently.
v1 still has 1M downloads. Interesting if anybody will upgrade.

Closing this, as I think there's a better approach (basically a separate site that projects can link to) and I'd rather not complicate this project further.


AppLovinMAX.initialize Crash

MAX Plugin Version
3.11.1
Flutter Version
3.24.3
Device/Platform Info
iOS
Current Behavior
Run app & it immediately crashes. I see this in my console:
[AppLovinSdk] [AppLovinMAX] Initializing AppLovin MAX Flutter v3.11.1...
Lost connection to device.

Expected Behavior
AppLovinSDK should initialize & app should run
How to Reproduce
Just start app from VSCode
Reproducible in the demo app?
Not Tested
Additional Info
class MyApp extends StatefulWidget {
  const MyApp({
    super.key,
  });
  @override
  State<MyApp> createState() => _MyAppState();
}

class _MyAppState extends State<MyApp> {

Future<void> initMAXLovin() async {
    MaxConfiguration? appLovinMAXConf =
        await AppLovinMAX.initialize('my_sdk_key');

    if (appLovinMAXConf != null) {
      AppLovinMAX.setHasUserConsent(true);
      AppLovinMAX.setIsAgeRestrictedUser(false);
      AppLovinMAX.setDoNotSell(false);
    }
 }

 @override
  void initState() {
    super.initState();

    // Init MAX App Lovin
    initMAXLovin();
 }
}

@lukeirvin, could you upload how you initialize it for us to investigate?

@alhiwatan Thank you for the response!
I have added how I initialize in the main comment above.
I follow the example app for setup.
Previously, iOS was working with 3.10.1 but I was seeing this issue occur on Android. Since then, I have updated my Android Studio, updated my Flutter version, and updated the package to 3.11.1. Now Android is working fine, but iOS crashes right at app launch.
I've tried to revert back to 3.10.1 but I seem to be stuck on 3.11.1

@alhiwatan
I have tested with 4.0.0 & I still get a crash, that occurs faster than the crash from 3.11.1.
Does 4.0.0 rely on the new version of Xcode that came out this week?

The method setIsAgeRestrictedUser() has been deprecated in our latest Android and iOS SDKs v13.0.0, which is compatible with version 4.0.0 (docs}.  Could you remove the following line and try again?
      AppLovinMAX.setIsAgeRestrictedUser(false);

@alhiwatan
When updating to 4.0.0 I received the error to remove that & did. Still no luck.
As I mentioned, the app crashes immediately with 4.0.0 - I don't even see my splash screen.
If I try to downgrade to any other version, I get stuck on 3.11.1 - which seems to work ok on Android but not iOS.
Here is my Flutter Doctor output as well:
[flutter] flutter doctor -v
[✓] Flutter (Channel stable, 3.24.3, on macOS 14.6.1 23G93 darwin-arm64, locale en-US)
    • Flutter version 3.24.3 on channel stable at /Users/Development/flutter
    • Upstream repository https://github.com/flutter/flutter.git
    • Framework revision 2663184aa7 (7 days ago), 2024-09-11 16:27:48 -0500
    • Engine revision 36335019a8
    • Dart version 3.5.3
    • DevTools version 2.37.3

[✓] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
    • Android SDK at /Users/Library/Android/sdk
    • Platform android-34, build-tools 34.0.0
    • Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)
    • All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 15.4)
    • Xcode at /Applications/Xcode.app/Contents/Developer
    • Build 15F31d
    • CocoaPods version 1.15.2

[✓] Chrome - develop for the web
    • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 2024.1)
    • Android Studio at /Applications/Android Studio.app/Contents
    • Flutter plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/9212-flutter
    • Dart plugin can be installed from:
      🔨 https://plugins.jetbrains.com/plugin/6351-dart
    • Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314)

[✓] VS Code (version 1.93.1)
    • VS Code at /Applications/Visual Studio Code.app/Contents
    • Flutter extension version 3.96.0

[✓] Connected device (6 available)
    • iPhone 15 Pro (mobile)          • D7C4C177-885B-4073-A73F-A145B6951838 • ios            • com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator)
    • macOS (desktop)                 • macos                                • darwin-arm64   • macOS 14.6.1 23G93 darwin-arm64
    • Mac Designed for iPad (desktop) • mac-designed-for-ipad                • darwin         • macOS 14.6.1 23G93 darwin-arm64
    • Chrome (web)                    • chrome                               • web-javascript • Google Chrome 128.0.6613.138

[✓] Network resources
    • All expected network resources are available.

• No issues found!

@lukeirvin - could you send over the adb or Xcode logs? We can't tell why it's crashing from the info provided.

@thomasmso
*** Terminating app due to uncaught exception 'NSInternalInconsistencyException', reason: 'Invalid initialization process: please remove the AppLovinSdkKey entry from your Info.plist and set your SDK key with the ALSdkInitializationConfiguration object.'
*** First throw call stack:
(
	0   CoreFoundation                      0x00000001804ae0f8 __exceptionPreprocess + 172
	1   libobjc.A.dylib                     0x0000000180087db4 objc_exception_throw + 56
	2   CoreFoundation                      0x00000001804ae008 -[NSException initWithCoder:] + 0
	3   AppLovinSDK                         0x00000001048af8e8 -[ALSdk initializeWithConfiguration:completionHandler:] + 356
	4   Runner                              0x0000000100dc2d14 -[AppLovinMAX initializeWithPluginVersion:sdkKey:andNotify:] + 384
	5   Runner                              0x0000000100dc980c -[AppLovinMAX handleMethodCall:result:] + 240
	6   Flutter                             0x0000000108db4df4 __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 164
	7   Flutter                             0x00000001087ef66c ___ZN7flutter25PlatformMessageHandlerIos21HandlePlatformMessageENSt3_fl10unique_ptrINS_15PlatformMessageENS1_14default_deleteIS3_EEEE_block_invoke + 108
	8   libdispatch.dylib                   0x0000000103777ec4 _dispatch_call_block_and_release + 24
	9   libdispatch.dylib                   0x000000010377973c _dispatch_client_callout + 16
	10  libdispatch.dylib                   0x00000001037893f8 _dispatch_main_queue_drain + 1228
	11  libdispatch.dylib                   0x0000000103788f1c _dispatch_main_queue_callback_4CF + 40
	12  CoreFoundation                      0x000000018040e960 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
	13  CoreFoundation                      0x0000000180409078 __CFRunLoopRun + 1936
	14  CoreFoundation                      0x00000001804084d4 CFRunLoopRunSpecific + 572
	15  GraphicsServices                    0x000000018ef2aae4 GSEventRunModal + 160
	16  UIKitCore                           0x00000001853d0a28 -[UIApplication _run] + 868
	17  UIKitCore                           0x00000001853d46b0 UIApplicationMain + 124
	18  UIKitCore                           0x00000001848736a8 __swift_destroy_boxed_opaque_existential_1Tm + 10048
	19  Runner                              0x0000000100569c14 $sSo21UIApplicationDelegateP5UIKitE4mainyyFZ + 120
	20  Runner                              0x0000000100569b8c $s6Runner11AppDelegateC5$mainyyFZ + 44
	21  Runner                              0x0000000100569c90 main + 28
	22  dyld                                0x0000000102635544 start_sim + 20
	23  ???                                 0x000000010272e154 0x0 +<PHONE_NUMBER>
	24  ???                                 0x9873000000000000 0x0 +<PHONE_NUMBER>6086771712
)
libc++abi: terminating due to uncaught exception of type NSException

@lukeirvin - that's perfect, and the error messages gives you the reason why. Please remove our SDK key from the app's Info.plist file.

@thomasmso do we need a different reference in the info.plist file? or not at all?

@thomasmso
I'm seeing this for 4.0.0:
*** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'Please update to the latest adapter versions. Incompatible adapter(s) found: (
    AdMob,
    "Google Ad Manager"
).'
*** First throw call stack:
(
	0   CoreFoundation                      0x00000001804ae0f8 __exceptionPreprocess + 172
	1   libobjc.A.dylib                     0x0000000180087db4 objc_exception_throw + 56
	2   CoreFoundation                      0x00000001804ae008 -[NSException initWithCoder:] + 0
	3   AppLovinSDK                         0x0000000106e946b0 -[ALSdk initializeSdkServices] + 2496
	4   AppLovinSDK                         0x0000000106e939e4 -[ALSdk initializeWithConfiguration:completionHandler:] + 864
	5   Runner                              0x000000010347ef2c -[AppLovinMAX initializeWithPluginVersion:sdkKey:andNotify:] + 384
	6   Runner                              0x000000010348599c -[AppLovinMAX handleMethodCall:result:] + 240
	7   Flutter                             0x000000010b398df4 __45-[FlutterMethodChannel setMethodCallHandler:]_block_invoke + 164
	8   Flutter                             0x000000010add366c ___ZN7flutter25PlatformMessageHandlerIos21HandlePlatformMessageENSt3_fl10unique_ptrINS_15PlatformMessageENS1_14default_deleteIS3_EEEE_block_invoke + 108
	9   libdispatch.dylib                   0x0000000106373ec4 _dispatch_call_block_and_release + 24
	10  libdispatch.dylib                   0x000000010637573c _dispatch_client_callout + 16
	11  libdispatch.dylib                   0x00000001063853f8 _dispatch_main_queue_drain + 1228
	12  libdispatch.dylib                   0x0000000106384f1c _dispatch_main_queue_callback_4CF + 40
	13  CoreFoundation                      0x000000018040e960 __CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 12
	14  CoreFoundation                      0x0000000180409078 __CFRunLoopRun + 1936
	15  CoreFoundation                      0x00000001804084d4 CFRunLoopRunSpecific + 572
	16  GraphicsServices                    0x000000018ef2aae4 GSEventRunModal + 160
	17  UIKitCore                           0x00000001853d0a28 -[UIApplication _run] + 868
	18  UIKitCore                           0x00000001853d46b0 UIApplicationMain + 124
	19  UIKitCore                           0x00000001848736a8 __swift_destroy_boxed_opaque_existential_1Tm + 10048
	20  Runner                              0x0000000102c25f78 $sSo21UIApplicationDelegateP5UIKitE4mainyyFZ + 120
	21  Runner                              0x0000000102c25ef0 $s6Runner11AppDelegateC5$mainyyFZ + 44
	22  Runner                              0x0000000102c25ff4 main + 28
	23  dyld                                0x0000000105345544 start_sim + 20
	24  ???                                 0x0000000104e5a154 0x0 +<PHONE_NUMBER>
	25  ???                                 0x2c71000000000000 0x0 +<PHONE_NUMBER>037133312
)
libc++abi: terminating due to uncaught exception of type NSException

That's due to you being on outdated adapters that is not compatible with our latest SDK, you can to the latest by following our docs here: https://developers.applovin.com/en/max/react-native/preparing-mediated-networks

@lukeirvin
Can you please share more details about your project dependencies and configurations to help us troubleshoot this problem in this issue?

@eli1stark As of right now I'm working off of 3.11.1, but I am experiencing the same crash in 4.0.0 for Google Ads (running 5.1.0 as well)


AssertionError:assert isinstance(cfg, dict) and 'type' in cfg

What caused this error..Is there any solution?

Traceback (most recent call last):
File "main.py", line 31, in
model_ensemble = get_model(config, model_dir)
File "main.py", line 6, in get_model
model = build_detector(config.model, test_cfg=config.test_cfg)
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/builder.py", line 43, in build_detector
return build(cfg, DETECTORS, dict(train_cfg=train_cfg, test_cfg=test_cfg))
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/builder.py", line 15, in build
return build_from_cfg(cfg, registry, default_args)
File "/home/tcexeexe/git/mmdetection-master/mmdet/utils/registry.py", line 79, in build_from_cfg
return obj_cls(**args)
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/detectors/cascade_rcnn.py", line 36, in init
self.backbone = builder.build_backbone(backbone)
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/builder.py", line 19, in build_backbone
return build(cfg, BACKBONES)
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/builder.py", line 15, in build
return build_from_cfg(cfg, registry, default_args)
File "/home/tcexeexe/git/mmdetection-master/mmdet/utils/registry.py", line 79, in build_from_cfg
return obj_cls(**args)
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/backbones/resnet.py", line 427, in init
gen_attention_blocks=stage_with_gen_attention[i])
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/backbones/resnet.py", line 284, in make_res_layer
(0 in gen_attention_blocks) else None))
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/backbones/resnet.py", line 168, in init
bias=False)
File "/home/tcexeexe/git/mmdetection-master/mmdet/models/utils/conv_module.py", line 33, in build_conv_layer
assert isinstance(cfg, dict) and 'type' in cfg
AssertionError

Please follow the Error report issue template.

Please follow the Error report issue template.

OK,but l've solve this problem by add  type='DCN' in config.py

I also meet the same problem  is any solution?

I also meet the same problem is any solution?

have you try add " type='DCN'  "?

where i add this type? is in the mmcv's config.py?

I also solve this problem by adding type='DCN' in config.py
before:
dcn=dict(
modulated=False,
groups=32,
deformable_groups=1,
fallback_on_stride=False),
after:
dcn=dict(
#modulated=False,
#groups=32,
type='DCN',
deformable_groups=1,
fallback_on_stride=False),

where i add this type? is in the mmcv's config.py?

before:
dcn=dict(
modulated=False,
groups=32,
deformable_groups=1,
fallback_on_stride=False),
after:
dcn=dict(
#modulated=False,
#groups=32,
type='DCN',
deformable_groups=1,
fallback_on_stride=False),

OK, thanks I will try.

I loaded the pretraining model of reppoints_moment_x101_dcn_fpn_2x_mt.py to train my dataset. Why can't I train DCN without type= 'DCN' in config, and can't I load DCN part of the pretrained model with type= 'DCN' @hellock


[request query.scope]: definition for this key is missing

Hi, i am trying to use open id connect with google.
I am running it with docker compose with image  1.10.1
When i go to kibana, it takes me to google, i login and return to kibana and get this message.
{"statusCode":400,"error":"Bad Request","message":"[request query.scope]: definition for this key is missing"}
it is getting me crasy.... so in try to see if was a config error, i use image 1.9.0 with exaclty de same configuraction and it works fine.
So i am if i am missing something form config that change from 1.9.0 to 1.10.1 someone can help me?
Best regards

in 1.11.0 it works


Service Stuck in Cancelling Upgrade

Upgrade Service and provide an non existing image
Cancel Upgrade
Service is stuck in cancelling and won't start again

Solution:

Clone service
Delete stuck service

I am unable to reproduce.
Steps I took:

Upgrade service to non-existent image
Cancel upgrade
Waited and eventually the state turned to "Cancelled-Upgrade".
Click on "Rollback" cause you are rolling back to your previous service settings since your new service is invalid.

Rolled back to previous service.

I am able to reproduce this issue by having a service and a sidekick. I update the tag on both service and sidekick. The sidekick service's tag doesn't exist. Cancelling the upgrade as soon as I realize the typo. Rancher stops all running, healthy instances and insists on recreating the unhealthy ones, which is now stuck in an "Finishing upgrade state"

I should mention that I had "Start before Stopping" turned on in the upgrade screen.

@withinboredom I tried to reproduce with your steps. I had a service with a sidekick for scale of 4. I tried to upgrade with an invalid sidekick image. When I go to cancel upgrade, if I wait, it will go into cancelled-upgrade state.
Did you try finish upgrade or rollback before or after you got into the cancelled-upgrade state?

@withinboredom Please re-open if you can provide more details as mentioned, I was unable to reproduce.


variant.d: Gated unittests behind version(StdDdoc)

Issue in focus: https://issues.dlang.org/show_bug.cgi?id=18818

Reabesd onto stable. Sorry about that :sweat_smile:
P.S. Looks like CircleCI test failed as it couldn't download dmd on the VM, Rebuild should definitely pass the test but it's good to confirm.

Thanks!

P.S. Looks like CircleCI test failed as it couldn't download dmd on the VM, Rebuild should definitely pass the test but it's good to confirm

Thats known, fixed in master, evidently wasn't back ported to stable.

Argh. This should have never been merged without more thought. Now these unittests won't be run ever. I hope I don't have to stress that this is bad.
I suggest copying them over to below the Variant declarations for now, but we should seriously consider reintroducing StdUnittest.


launches update with champion arts button

if possible launches update with manual button to update the images of champions, as in version 1.0, it is more viable than an update that is not entering the new images of new champions.

Fixed with newest version.


list buttons don't work in Firefox

The FF console error message is "NS_ERROR_FAILURE" in hallo.js:230. This is using Hallo 1.0.4. Lines 230-232 are:
if (document.execCommand(command, false, value)) {
    return this.element.trigger("change");
}

Have the same problem: NS_ERROR_FAILURE

I have the same issue in my website, but the demo (http://hallojs.org/) does work in the same browser. Does anyone have any idea what could be wrong? I try reproducing the environment to no avail.

:+1:


Bad error messages on incomplete patterns as function arguments

It turns out the current implementation will catch arguments that are incomplete, even if they are not in a case. While this is desired, I did not realize it was "implemented". Need to do some work to make these error messages acceptable.
-- MISSING PATTERN ----------------------------------- ./src/StartApp/Simple.elm

The following `case` does not handle all possible inputs.

91│         (\(Just action) model -> config.update action model)
                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^
The following patterns are not being handled:

    Maybe.Nothing

Did you add a new tag to a union type? Add how it should be handled here and
you will be all set!

Okay, that was pretty easy.
-- SNEAKY PATTERNS ----------------------------------- ./src/StartApp/Simple.elm

This argument does not cover all possible inputs.

91│         (\(Just action) model -> config.update action model)
               ^^^^^^^^^^^
Any of these patterns can cause a crash:

    Maybe.Nothing

Did you add a new tag to a union type? Add how it should be handled here and
you will be all set!

Just need to get the text of the message right and this should be all set.

Are we sure it's desirable? Sometimes this is a necessary "trust me I'm a doctor" escape hatch. Although the only concrete example I can think of right now, now that we have Signal.filtermap, is elm-lang/core#402.

I'd expect people to do this:
unsafe : Maybe a -> a
unsafe m =
  case m of
    Just x -> x
    Nothing -> Debug.crash "I'm clever, this won't happen."

And the error message will suggest this.

Alright, now here's the full message:
-- PARTIAL PATTERN ----------------------------------- ./src/StartApp/Simple.elm

This argument does not cover all possible inputs.

91│         (\(Just action) model -> config.update action model)
               ^^^^^^^^^^^
Any of these patterns can cause a crash:

    Maybe.Nothing

You probably want to switch to a `case` expression to handle all possible
patterns in a simple way. If you think some cases are impossible, you can use
`Debug.crash` to make that thinking explicit in your code.
<http://package.elm-lang.org/packages/elm-lang/core/latest/Debug#crash>

Sometimes you *know* a value will never be Nothing, though such cases are very
rare. If you are certain you are in that case and that there is no better way
to do things, I'd recommend creating a function `unsafe` that makes the danger
explicit in the code. <https://github.com/elm-lang/core/issues/215>

Not to nitpick, but it seems odd to talk about causing a crash when what you really mean is, "Yes, I can generate JS that implements this, but it would have the potential to crash, so I'm not going to generate it. So it can't cause a crash in any code that I generate for you."
Perhaps All of these patterns aren't handled? Which still sounds a bit odd when there's only one pattern.


Rendering property: value rules within

My use case is wanting to make a wrapping element I can apply various styles to [within media queries as well].

Or to put it another way...
const yo = 'background'
return (

)

@corysimmons can you put together a testcase that I can clone and try out?

Sorry @giuseppeg I would but I'm swamped right now and tbh will probably forget to do it later. I can go ahead and close this and if I bump into it again I'll reopen with a very clear test case.


Deprecate legacy excon instrumentation

Before contributing, please read our contributing guidelines and code of conduct.
Overview
We discovered prepend was not needed for excon instrumentation. Very old excon versions require method chaining, but we are removing these old versions from support. This PR deprecates the legacy method chaining instrumentation for these older unsupported versions.
Related Github Issue
closes #582

Is not conforming to our new configuration setup. Still references the :disable_excon for example. We need to honor
instrumentation:
  excon: disabled

To disable. Since we're auto-instrumenting via adding to excon's middleware stack, I suggest, "auto" is equivalently the same to "enabled". If "chain" or "prepend" are encountered, we effectively treat this as "enabled" and produced to install middleware accordingly. (i.e. there's no difference in what happens between these options). We may want to log a debug message saying as much.)

Alright, I added a check for the allowed_by_config? method for excon, which should check if it's enabled. I didn't make any other changes since we don't need to check if it's auto/chain/prepend since the behavior is the same for all of those anyways, I believe.


add tests

project dir contains a non-py file
delete graph at overwrite: ConnectionError

Codecov Report

Merging #12 (60beb3d) into main (e2144e3) will increase coverage by 1.12%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   90.58%   91.71%   +1.12%
==========================================
  Files          12       12
  Lines         531      531
  Branches       92       92
==========================================
+ Hits          481      487       +6
+ Misses         25       21       -4
+ Partials       25       23       -2

Impacted Files
Coverage Δ

pycograph/project.py
89.10% <0.00%> (+0.99%)
:arrow_up:

pycograph/parse_result_to_redisgraph.py
97.67% <0.00%> (+11.62%)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e2144e3...60beb3d. Read the comment docs.


Question about virtual properties

I'm on a user model, with simples hashing password.
My migration table is:
exports.up = function (knex) {
  return Promise.all([knex.schema
    .createTableIfNotExists(tableName, (table) => {
      table.increments('id').primary().notNullable()
      table.string('name').notNullable()
      table.string('email').notNullable()
      table.string('password_hash').notNullable()
    })])
}

And I want to post:
{
	"name": "myname",
	"email"<EMAIL_ADDRESS>	"password": "123"
}

with the key "password", to take that password and hash it, then query insert it to the database, like: password_hash = hash(password)
the code bellow try that logic, and get an error:
insert into "users" ("email", "name", "password", "password_hash") values ($1, $2, $3, $4) returning "id" - column "password" of relation "users" does not exist
how can I do it in the right way?
/* eslint-disable camelcase */
import { Model } from 'objection'
import bcrypt from 'bcryptjs'

interface UserInterface {
  name: string,
  email:string,
  password: string,
  password_hash: string
}

class UserModel extends Model {
   public static tableName = 'users'

   public static jsonSchema = {
     type: 'object',
     //  required: ['name', 'email', 'password'],

     properties: {
       id: { type: 'integer' },
       name: { type: 'string' },
       email: { type: 'string' },
       password: { type: 'virtual' },
       password_hash: { type: 'string' }
     }
   }

   async $beforeInsert (this: UserInterface, queryContext:any):Promise<any> {
     if (this.password) {
       this.password_hash = await bcrypt.hash(this.password, 8)
     }
   }

   checkPassword (this:UserInterface, password:string):any {
     return bcrypt.compare(password, this.password_hash)
   }
}

export default UserModel

You can just delete the password in $beforeInsert, or if you don't want to do that, you can implement $formatDatabaseJson method and delete it from the json object. That way you don't actually remove the password field from the original model instance.
$formatDatabaseJson(json) {
  json = super.$formatDatabaseJson(json)
  delete json.password
  return json
}


start pin title = track name

Enabling the track name to be propagated down to the actual start pin.
This may be a roundabout (or the wrong way entirely?) to do it; but at least it solved my problem:
List tracks where the trk element has the relevant name attribute + only showing the starting point.
There might be a better way, but I didn't find it seemed to only retrieve the first trk name for the "top" layer, not for all the actual tracks.
(working on a web app for listings hikes)

Thanks. I'll pursue that approach instead.


[Feature] Support for explicit versioning of definitions

Description
This feature request is to add the facility for component/trait etc definitions to explicitly specify a version as part of the definition.
The Application will then have the ability to refer to the definition version when using a definition.
Exisiting situation
Definitions currently have a version field but this is automatically assigned:
The Version Control for Definitions docs have:

When an OAM definition is updated, KubeVela will automatically generate a new revision of this definition.
[my emphasis]

This is a simple version number, being an integer.  Being auto-assigned causes problems in not being able to predict what version will need to be used in the Application file, and the version number may be different in different environments such as dev,staging,prod)
Possible Solutions
My preference as the originator would be to use semantic versioning for the definition version.
This could either be by repurposing the existing version field, or by adding a new version field.
Referencing the defintion within the Application could be allowed as follows:
    # latest (no version specified)
    type: wb-service

    # specific
    type<EMAIL_ADDRESS>
    # non-specific
    type<EMAIL_ADDRESS>
Alternatives

a current workaround is to call the definition e.g. "wbserver-v1.0.1" then "wbserver-v1.0.2" etc. This would meet requirements but has knock-on effects e.g. bloat of vela def list
During Kubevela Community call 4th-Jan-2024, @linaking-guidewire mentioned that the versioning could use the CRD alpha/beta/v1 format.

Additional considerations

is any form of old version cleanup wanted/possible? (could it automatically discover used and unused versions in the cluster)
what actions if any are to be taken regarding checking whether a given version is available?
can anything be done to easy deployment of a given defintion version to multiple clusters

References
This proposal originated from a slack thread created by Frederick Boismenu.
It was also discussed on the Kubevela Community call 4th-Jan-2024.

I'll admit I've not a great understanding of the CRD alpha/beta/v1 versioning - by which I mean how does the consumer identify breaking/non-breaking changes, patches etc?
Using it would obviously be "the kubernetes way".  @linaking-guidewire, care to pitch in here with a description and case for using that over semver 🙂  ?

I also like the idea of using CRD version like v1alpha, which probably gives us the space to add migration func from v1 to v2.

So @FogDong / @linaking-guidewire I get how v1alpha/v1beta/v1 works when taking a new definition through concept to full "v1" implementation.  But how does this work if we are adding a new feature to an already out there definition?
For example say I want to add a new feature to the cpuscaler resource to support scaleDown/scaleUp policies.  In semver world this would lead to a minor version bump e.g. to v1.1.0 - or if the implementation leads to a breaking change it might be v2.0.0.
How would this scenario be handled under v1alpha/v1beta/v1 approach? (genuine question, this is where I don't understand this approach).

Thanks @fboismenu . I'm mostly in agreement on your points.
One thing I'd like to note though is the proposal here to allow rollout of new definition versions (my emphasis).  I think this is a good feature but would need to be optional, I wouldn't favour it being done automatically.  I get it might be a good idea in dev, but would not want to do a bulk upgrade in prod, it would be akin to using :latest imho (not a good thing!).
If it is possible and if we choose semver, it should not allow bulk upgrade to a new major version number - the point of this in semver is that a major version number indicates a breaking (or at least very significant) change, and istm this should require review by teams.
Whilst a minor or patch version update is intended to be non-breaking there's no guarantees so personally I wouldn't see even just a patch version increment as a green light to bulk auto-upgrade a definition, I'd want to choose to do that, but I don't see a problem with it being an optional approach for those that want it.
Thoughts anyone?

I agree that versioning is an optional setting for definitions.
In semantic versioning, bumping the major version usually means there's a big change that could break things. Our current setup automatically increases the version with each update, and we're only tracking the major version at this point. To keep things smooth for KubeVela users, we're saying that a major version increase won't be a breaking change that requires manual intervention.
In practice, updating definitions often just means adding a few new fields, which doesn't cause any disruption. This suggests that the typical approach should be to update the minor version—it's not as critical as changes to CRDs. Given this, I think semantic versioning could be a better fit for versioning our definitions.

Semver is fine as long as we support specifying ranges, but I do think the Kubernetes API versioning would be a more standard approach for this case - "the Kubernetes way" as you mentioned @Kolossi.
From my perspective, although they are not CRDs, KubeVela definitions still behave as extensions to the Kubernetes API, so I would expect (as a user) for them to be versioned similarly to the Kubernetes API standards and deprecated/removed similarly to the Kubernetes deprecation policy.
This pattern does put more responsibility on the developer of the definition to make backwards-compatible changes, perform thorough regression tests, and possibly build in automated conversions, but then the user rarely needs to take any action and could easily uptake new features of a definition at their own pace. Just going off of the use cases I have seen at Guidewire so far, I can't think of a situation where we would want a user to explicitly specify minor or patch versions of a definition. I would fear that offering that as an option at all could result in us supporting many different versions of a definition at once in a cluster with many tenants. That is more concerning to me than bulk upgrade.

I like the proposal, but have some doubts on the options that are being proposed. In terms of calling component versions I think adding the version as proposed by @Kolossi will provide a user friendly approach for users deploying applications. To add an example of what I am understanding that would be:
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: app-with-comp-versioning
spec:
  components:
    - name: backend
      type<EMAIL_ADDRESS>
However, from the component definition side of things, and linking with @FogDong comment, we should also define where the version will be specified. Should we add an optional annotation such as definition.oam.dev/version which could be compatible with the existing v1beta1 component specification, or should we modify the ComponentDefinition to include a spec.version field which could require a new v1beta2 entity?
apiVersion: core.oam.dev/v1beta1
kind: ComponentDefinition
metadata:
  name: <ComponentDefinition name>
  annotations:
    definition.oam.dev/description: <Function description>
    # Option 1: using annotations
    definition.oam.dev/version: <semver>
spec:
  #Option 2: modifying the spec
  version: <semver>
  workload: # Workload Capability Indicator
    definition:
      apiVersion: <Kubernetes Workload resource group>
      kind: <Kubernetes Workload types>
  schematic:  # Component description
    cue: # Details of components defined by CUE language
      template: <CUE format template>

I have been giving this a second tough, and I have a doubt regarding the expected use case. Are we considering the possibility of having to versions of the same component available in the cluster? or is this just to enforce the fact that an application could only be deployed with a specific subset of component versions? @Kolossi which is the use you have in mind for this feature?
The main problem I see if we need to store two component definitions in the cluster at the same time is the naming of the CRDs, as it may require having a name for the CRD entity (e.g., metadata.name: my-component-vX.Y.Z), and another canonical name for the component definition matched by KubeVela (e.g., spec.name: my-component) since it is not possible to have two crd entities with the same name as one will be overwritten by the other.

Thanks for reminding me about this @dhiguero, I've got sidetracked lately.
Yes the scenario you have raised - of having multiple versions of the same definition (might be component, trait etc) - is what I'm after.  When using custom traits there's the usual same SDLC scenarios of issuing patches, enhancements, breaking changes but whilst not wanting to break existing items.
I'm still very curious as to how the alpha/beta/v1 proposal addresses this and no-one's posted how this could work?

Thanks for this proposal!

IMHO it would be ideal if Platform Eng could progressively rollout new component versions, for example by doing a progressive patching of all Application using the component(s) to update, without requiring users synchronization or just waiting for them to redeploy (some stable apps may redeploy only each month for example).

I personally agree with @fboismenu most. And I don't really care in which way we name the version, whatever it's semantic versioning or CRD alpha/beta/v1 versioning, they're actually tags which shouldn't be aware by app developers, they should be handled by platform builders internally.
The question here is how we can make it, a rolling upgrade for definition version. My proposal should be adding an annotation on App automatically and let the annotation to specify the real version.
apiVersion: core.oam.dev/v1beta1
kind: Application
metadata:
  name: app-with-comp-versioning
  annotations:
    oam.definition.versioning<EMAIL_ADDRESS><EMAIL_ADDRESS>spec:
  components:
    - name: backend
      type: my-component-type
    - name: frontend
      type: my-foo-def

Kubevela webhook can check extra rollout policy to add this kind of annotations automatically, other systems or users can also have the flexibility to specify it.
I personally think we'd better avoid deign the versioning feature to be too complex, it should be the platform builders capability to maintain the compatibility, or they can invent a new definition name. That means we shouldn't support fancy feature like "type<EMAIL_ADDRESS>

Yes, thanks @Kolossi for explanation, you fully get what I mean, while the app developer still has a chance to define the version through annotation by their own if they prefer.

Ah ok, so if I understand, your proposal to auto-update only applies if the developer has not specified a version number.  In this case they would get patch and new feature changes automatically, but not breaking changes (because component name has to be changed in application definition)?
If so, there's logic in that but that's essentially what we have at the moment, and having to have seperate component names with major versions in them was one thing this proposal was trying to address.
However another key one was the ability of the definition author to determine the applicable version number as opposed to the auto-increment numbering provided at present.  Whilst I'd prefer the semver approach (you got that, right? ;-) ) if we only added the ability for definition author to explicitly set the feature/patch version that would be of great benefit IMHO.

@Kolossi , yes, you have fully got my point. Just go ahead with semver.

Dear @FogDong   I am looking forward to work on this issue during LFX  mentorship program in your  guidance and Support. Thank You.

@Kolossi Thanks for the detail explanation, I like the idea of using semver to distinguish the minor patch and break change.
For anyone who's interested in this issue for LFX, feel free to discuss with the community in Slack Kubevela channel and DM me in Slack, my id is FogDong.
Cc @RohanMishra315 @Beastharsh970

Good proposal and the fact we can specify the versions as annotations in the application is very much needed.
In addition to this, I propose that we include a vela core configuration at the cluster level, which would specify the preferred versions for that specific cluster.
And versions would be used in this order of precedence:

user specified
cluster config
latest

Thanks @oanasc, a good thing to raise.
My only thought is what behaviour would we get if the cluster config version is changed?
For user-changed version the update would only happen on redeploy, until then the previous Application, with the previous version number will be current.
For "latest", as at present I would expect it wouldn't auto-update as soon as a latest version is available (how to poll etc?), so again only on redeploy.
So that leaves the cluster config - if this is updated do we expect the cluster to redeploy everything?  I would guess not, but then we end up with a situation where e.g. the workloads don't have a version configured, but when they were deployed it was v1.0.1, but since then the cluster config has been updated to v1.0.2 and then v1.0.3.  So the only version specification in the cluster says v1.0.3 but the only deployed version is v1.0.1 which leads to confusion.
But I can't really think of an easy way around that with cluster config that doesn't auto-update.  And as I said I'm not keen on auto-update! 🤔
Anyone got any ideas? 🙂

Currently when you publish a new definition version it isn't automatically applied. A redeploy is needed in order to apply.
Now as part of this proposal you'd like to auto-upgrade minor & patch versions, should that be a flag which you can have on/off very much like cloud providers have their minor auto upgrade options, and the behaviour should then be consistent if is on is on regardless where the version is coming from?
I agree otherwise will be very confusing

Actually, I'm not proposing the auto-upgrade, but others have 🙂. I do see that others may want it, particularly in dev environments, so happy to go along provided it's configurable as you say.
But in the particular case of an update to the cluster config which you have proposed, how would you see that working?

To elaborate and make sure there's clarity, I share some of the views that users shouldn't have to worry about the definition versions.
It could lead to a situation where teams have to coordinate and make updates across all repositories every time there's a definition update.
Additionally, I noticed we haven't considered how this approach will function in a multicluster setup; specifically, one in which a single
definition is installed in the main cluster and subsequently used across all connected clusters. Under this scenario, if we upgrade a definition,
it will instantaneously take effect across all clusters. The aim behind the definition upgrades is to initially test them in a separate environment;
however, these annotation methods aren't topology sensitive.
Therefore, I proposed setting up a hierarchy of configuration precedence as follows:

Start with the version defined by the user in the application.yaml annotations.
If the first option isn't set, and you have a cluster-level configuration for versions, use these versions instead. This is optional
Lastly, if neither the first nor the second options are set, then default to using the latest version.

And have the behaviour of auto-upgrade the same between for 1 and 2, and treat 2 as a central another way to set versions and choose to configure it or not on a cluster basis.

Following on yesterday's community meeting comments on this, one of the issues that needs to be designed is how the entities are going to named in Kubernetes to avoid overwritting previous versions. One approach, as discussed, could be to assume that entities are going to be named in kubernetes with a version suffix, they will have versioning labels to facilitate retrieving them from the KubeVela operator, and the application will be abstracted from the versioning if not required. With this approach we will have the following scenario:
Listing components:
$ kubectl get componentdefinitions.core.oam.dev
NAME            WORKLOAD-KIND   DESCRIPTION
...
task              Job             Describes jobs that run code or a script to completion.
webservice        Deployment      Describes long-running, scalable, containerized services that have a stable network endpoint to receive external network traffic from customers.
worker            Deployment      Describes long-running, scalable, containerized services that running at backend. They do NOT have network endpoint to receive external network traffic.
my-comp-v1.0.0    Deployment      My custom component (v1.0.0)
my-comp-v1.3.0    Deployment      My custom component (v1.3.0)
my-comp-v2.1.0    Deployment      My custom component (v2.1.0)

Getting a component:
$ kubectl get componentdefinitions.core.oam.dev my-comp-v2.1
apiVersion: core.oam.dev/v1beta1
kind: ComponentDefinition
metadata:
  annotations:
    definition.oam.dev/description: My custom component (v2.1)
  labels:
    custom.definition.oam.dev/ui-hidden: "true"
    definition.oam.dev/name: my-comp
    definition.oam.dev/major: 2
    definition.oam.dev/minor: 1
    definition.oam.dev/patch: 0
    definition.oam.dev/version: 2.1.0
  name: my-comp-v2.1
  namespace: vela-system
spec:
  schematic:
    cue:
    ...

To facilitate the adoption, we could modify also the vela def command so that labels are injected if not present:
$ vela def apply my-stateful.cue --version 1.2.3
ComponentDefinition my-stateful-1.2.3 created in namespace vela-system with version 1.2.3.

I like the component labels with semver 👍
Sorry I could not make for the community call, does the kubernetes naming convention changes the way it would be referenced from in the Application (meaning without version)?
From a user perspective in the Application, we have following scenarios, I would say:

I want the latest version of the component (not sure if its very sensitive choice in prod, but I think it makes sense while developping) - so no version explicitly specified by end user.
I want to specify constrains: pin the major or major.minor

As a platform eng, I would to be able to redeploy the users application, satisfying users contrains, but doing it as a progressive rollout, not a blunt auto update all and pray strategy, so it means being able to manipulate the patch and or minor version in accordance to 2.
The usual use case is I want to rollout a security update across the firm.

I personally think we'd better avoid deign the versioning feature to be too complex, it should be the platform builders capability to maintain the compatibility, or they can invent a new definition name. That means we shouldn't support fancy feature like "type<EMAIL_ADDRESS>Absolutely 👍

Hey folks,I previously discussed the proposal on slack with @Kolossi and @FogDonga. After reading in more depth I have the following observations -

I agree with semantic versioning(As CRD versioning could have issues like with version updates), also we could be with adding the version as a suffix in the end. (This could be discussed further as some people may not want version suffixing).
Auto version updates make sense as @Kolossi said, we could have it as an optional feature.
I agree with @dhiguero, OAM definitions would have versioning labels which the vela Operator can pick up.
Keeping a vela core config at global level without auto-update without auto-update could get confusing. I think we should prioritize handling auto-updates more carefully as it has operational effects.
Vela def can be modified to support labeling the Defs.


mozilla-plugins/trezor: remove applications/networking/browsers/mozilla-plugins/trezor

trezor-mozilla-plugin is no longer maintained software
package pkgs/servers/trezord should be used instead

You'll need to remove any references to this file as well.

(remember that they can appear simply as trezor and not just trezor/default.nix)

@prusnak Thanks, let's see if that makes ofborg CI happy this time. :)


NPC Missing For "Flute of the Pure Note"

The Thief NPC located behind the Music Store that's meant to be fought in Stage 2 of Flute of the Pure Note has disappeared, likely as part of the reset.

NPC has been added back and quest updated


Implement QuicFileUtils

Add QuicFileUtilsImpl using Envoy::FileSystem.
Risk Level: low
Testing: Added tests in test/extensions/quic_listeners/quiche/platform/quic_platform_test.cc and tested with --define quiche=enabled
Part of #2557

/assign @wu-bin

/assign @alyssawilk


Employee being matched with service accounts (HELP!!!)

How do we prevent icebreaker from pairing an employee with a service account?  Is there a way to use a security group to
"pull" valid employees for matching?
Please help...

Thank you for submitting this issue, as we work to ensure consistent responses with items logged in our issues list, we are working to address these items that did not get responses. Please let us know if you are still facing this issue and require assistance and we will be happy to discuss. If no further action is needed at moment and no response is received, we will close out the issue in 3 business days. You may also always open a new issue or respond here if something does come back up. Thank you!


real machine experiment

Hi,
I am a beginner in this area. Could you give some instructions on the real machine implementation in details?  Should I install this project on all robots or?  After I installed the drivers of each sensor, how could start this system? By the way, are there any 3D maps as output?
Thanks!

Hi! Sorry for the delayed answer.

There are some start-up instructions here https://lajoiepy.github.io/cslam_documentation/html/md_startup_instructions.html
Yes you need to install the system on each robots.
Create or modify a launch file among those within this repository. You need to make sure the configuration fits with your robots.
Not directly, internally Swarm-SLAM builds a keyframe map, but this is not a good visualization of the environment. However, you can run the cslam_visualization module which will build a map based on Swarm-SLAM trajectory estimates. https://github.com/lajoiepy/cslam_visualization


Added header to Install target

"websocket_plugin" is copied in APACHE_INCLUDE_DIR in order to be able to develop other plugin without using this repository.

Thanks for this! I also went ahead and removed the validate_utf8.h header comment, since it's an implementation detail only and not part of the API.
I've pulled this in with commit cae6d24b. (It's very annoying that Github won't let me mark a merge from the commit message; I end up having to manually close them.) Thanks again!


[uwebsockets] update to 0.14.0a4

This transitions from CMake to msbuild. It is tested with all 4 configurations (x64, Win32, Release, Debug) and can be a base for the upcoming 0.14.0 version. I had some issues with the builtin vcpkg_build_msbuild so I just called the msbuild tool directly and this works nicely. I think this should be portable?
You can squash this into one commit

@alexhultman,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.
It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@alexhultman, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, Microsoft Pull Request Bot

Hey alex, thanks for making this PR.
Sorry I wasn't able to get to your issue[1] quickly! I'll answer that issue here as well as address this PR.
The most common way that MSBuild projects use Vcpkg is via the User-wide integration (as you know). However, Vcpkg is designed to support multiple instances (of Vcpkg) on a single machine and does not require user-wide integration. This is why the vcpkg_build_msbuild() command was not working in your issue -- it explicitly ignores the user-wide integration (since we can never assume it is available).
However, the fix is not as simple as "forcing on" the user-wide integration, because that could cause the project to be built in the context of a different Vcpkg instance on the same machine. We need to force the project to specifically import scripts\buildsystems\msbuild\vcpkg.targets from the particular instance we're building inside.
Given that you're the author of the library, I think there are three reasonable options to proceed:

The portfile patches an import line into the project [2] right below the "Globals" PropertyGroup. We then use vcpkg_build_msbuild() in the portfile and set the path accordingly.
You could add [2] to the upstream MSBuild project (it has no effect if VcpkgTargetsFilePath is not defined). Then we do the same as in 1 with vcpkg_build_msbuild().
We keep a very simple CMakeLists.txt file inside Vcpkg which handles the build. We can use file(GLOB_RECURSE) to grab all the sources out of the tree easily. This is the option I believe is the easiest moving forward given your response that you'd like the buildsystem for users to simply be cl *.cpp. CMake is more easily customized externally, so this would correctly support things such as static linking the CRT (which I believe the MSBuild will not -- we'd need to patch the MSBuild file for that).

[1] #828
[2]
<Import Condition="'$(VcpkgTargetsFilePath)'!=''" Project="$(VcpkgTargetsFilePath)"/>

Right, I added that line: https://github.com/uWebSockets/uWebSockets/commit/6888c92691c0e8aaf65661a40c4a1f309a5d7eee

I still cannot get it to work. The only thing that I can get working is this PR.

Hrm, that's troublesome.
I went ahead and took a stab at the we-keep-a-copy-of-cmake approach:
https://github.com/Microsoft/vcpkg/blob/299776b5396d4f2dbdb490dca612d6bae84163de/ports/uwebsockets/CMakeLists.txt
It's the same length as the portfile itself (i.e. really short), plus it works for static linking against the CRT and potentially UWP in the future. I also did a dry run of upgrading to 0.14.0alpha5 and it compiled completely clean the first time through.

Okay that's fine, thanks


Create 2nd end-point (POST) + Test

Reopen for test in resource

The last commit is to delete a config used in local environment for the application to run in M1 Mac.


feature: Add time window for trace get method in span store interface

Which problem is this PR solving?
Part of https://github.com/jaegertracing/jaeger/issues/4150
Description of the changes
Refactor trace get method in span store interface:

use struct instead of literal trace id
add time window in the new struct

How was this change tested?

unit test

Checklist

[x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
[x] I have signed all commits
[x] I have added unit tests for the new functionality
[x] I have run lint and test steps successfully

for jaeger: make lint test
for jaeger-ui: yarn lint and yarn test

PR updated, please review, thanks @yurishkuro

@rim99 could you please resolve the conflicts?

@rim99 could you please resolve the conflicts?

Resolved. Could you please reivew?

TODOs added to

anonymizer/app/query/query.go
cmd/query/app/apiv3/http_gateway.go
cmd/query/app/http_handler.go (3 times)
plugin/storage/es/spanstore/reader.go


Dynamic segment sizing

This PR adds support for dynamic segment sizing based on the content size of the segment. Instead of fixing the number of visible cells, each cell is a different size based on the length of its title (plus the image in the case of the imageBefore and imageAfter styles). The way to use it is to pass a SegmentioPosition option in the initializer, either .dynamic or .fixed(maxVisibleItems: 3). The fixed option is the same behavior that exists currently.
Changes:

Add SegmentioPosition enum with fixed and dynamic options
Replace maxVisibleItems with maxVisibleItems property in fixed case eg. .fixed(maxVisibleItems: 3)
Update Points extension with more parameters for dynamic layout calculations
Replace scrollToItem at index path calls with scrollRectToVisible in scrollToItemAtContext
Update itemInSuperview method for dynamic and fixed position cases
Separated method for calculating segment width
Added width property to SegmentioItem
Update example project

There are quite a few changes in this PR so if you want anything updated, changed, done differently, etc. please let me know and I’m happy to do it!
Ty for the awesome framework.

@maxcampolo How can I download your version? I've downloaded your fork but it seems it doesn't include these changes

Hey @rmvz3 all these changes are in the branch called fix/label-layout. I'll just merge it over to my master eventually but you can use that branch for now.

@maxcampolo I've just realized. That's why I deleted my question.  My fault ¯_(ツ)_/¯
Thank you

No love for this PR?
Any plans to merge this with the master?

Hello @maxcampolo , thank you for a great work. I have tested your PR and found some issues with cell width

and also with wrong positioning of indicator

Can you fix them?

@Tykhonkov sure thing let me look at this. The first image looks correct, the cell sizes based on the size of the content contained in it, using the image width if there is no label. The second image indicator position is definitely wrong. Any specifics on reproducing? Thanks!

@Tykhonkov I pushed some updates that should fix these issues. I also updated the example project so to test you can just add the segmentioPosition: .dynamic option to the SegmentioBuilder call in ViewDidAppear(_:) of ExampleViewController.

Thanks for reviewing!

ill test it

Apologies for bothering, but may I ask if this PR is going to be merged any time soon?
I'll just use the specific branch for now in any case

@maxcampolo Could you please update your request by pulling last changes in our master branch ?

@AndrewPetrov okay I've merged the latest from master and updated the PR. Thanks for reviewing!

@maxcampolo I'm sorry but your fix still has some issues with highlighting http://joxi.ru/gmvjlP0FLgy41m

@AndrewPetrov sorry about that! This was just a bug calculating the position in the .fixed segment width option. Turned out to be misplaced if statement brackets. Should be fixed now. Thanks!

Could this please be merged?


matrix_triangular_solve has broken docstring

System information
not applicable (regards documentation)
Describe the problem
The docstring of matrix_triangular_solve is not clear, see https://www.tensorflow.org/api_docs/python/tf/matrix_triangular_solve. There are formatting issues, but moreover, it is not immediately clear what the effect of adjoint=True is. It would be helpful to describe the effect using linear algebra notation.
Source code / logs
not applicable (regards documentation)

What language would you suggest?
Contributions are welcome :) - you'd want to change the string here: https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/ops/linalg_ops.cc#L430
FYI @rmlarsen in case he has some comments.

It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging Awaiting TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Nagging TensorFlower: It has been 14 days with no activity and the awaiting tensorflower label was assigned. Please update the label and/or status accordingly.

Closing due to inactivity.
BTW the documentation for the op is now here https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/api_def/base_api/api_def_MatrixTriangularSolve.pbtxt.


Add PR template and update CONTRIBUTING.md

Maybe add: check if docs render properly on localhost (when moving modules, changing do strings etc)


[Pwsh7] Invoke-RestMethod/Invoke-WebRequest don't follow 302 redirects

Steps to reproduce
Invoke-RestMethod "http://api.zergpool.com/api/status"

(same problem happens with Invoke-WebRequest "http://api.zergpool.com/api/status" -UseBasicParsing)
Expected behavior
The functions should follow the 302 redirect to http://api.zergpool.com:8080/api/status and return a collection of objects. This works perfect with Powershell 5 and Powershell 6
Actual behavior
Instead, the command throws an Exception with the following error:
302 Found
Found
The document has moved here.

I already have tried to set -MaximumRedirection 5, just in case, but no change.
Environment data

Name                           Value
----                           -----
PSVersion                      7.1.1
PSEdition                      Core
GitCommitId                    7.1.1
OS                             Microsoft Windows 10.0.18363
Platform                       Win32NT
PSCompatibleVersions           {1.0, 2.0, 3.0, 4.0…}
PSRemotingProtocolVersion      2.3
SerializationVersion           <IP_ADDRESS>
WSManStackVersion              3.0

Close as a duplicate of #14531

Close as a duplicate of #14531


fix: field mandatory shipping_address_name

make shipping address mandatory in Transaction (Quotation, Sales Order, Sales Invoice)

Holding this back for now. I actually remember that we discussed with the customer earlier today that this might not be needed after all. Sorry for confusion

Noted

Noted


cli: Ensure regression tests is performed on Popper

It will really help to monitor performance issues of this tool if regression tests can be performed. However, can I get a list of possible tests that need to be performed before regression is done?

thanks Eddie, this is a great idea. One test could be to run popper run --dry run and see how long it takes. Do this repeatedly and get an average with some tolerance for variability, and use this as the basis for comparison. The issue is that we need to run these tests on the same platform always, otherwise the numbers might not be comparable between runs

Oh, it's nice to know popper has an inbuilt feature to know how long it takes. So I'm not totally sure but if this was written with Golang, I believe we would've used Go tests to be able to benchmark how long popper loads. So two things yeah:

What's your idea for the kinda system/platform that can be used to run this test? I thought of Weave but I'm not exactly familiar with their kinda services.
Also, when performing performance testing, would the number of steps in a workflow determine the speed?

it's nice to know popper has an inbuilt feature to know how long it takes

that's not available yet (see #869 ). However, we can create a test by having a fixed wf.yml file and then doing:
time popper run -f wf.yml

we can repeat the above X number of times and show the variability.

What's your idea for the kinda system/platform that can be used to run this test?

we can make use of a baremetal-as-a-service platform like packet.net or scaleway

when performing performance testing, would the number of steps in a workflow determine the speed?

yeah, so we need to have some fixed workflow and use that always


ECG API

Use case
Smartwatches (SW) with built-in electrocardiogram (ECG or EKG) are appearing always more often on our wrists and probably in a few years all watches would have basic ECG recording abilities. The interest for such abilities is increasing (for example: https://www.ahajournals.org/doi/10.1161/CIRCEP.118.006834)
Proposal
Flutter should be able to expose a common API to read ECG data from different brand of SW. This could be developed as a packages/plugins.
From wikipedia these are the OS we could find on our watches (as of 16/02/2020):

Wear OS
watchOS
Tizen
AsteroidOS
Sailfish OS
Ubuntu Touch

Not all the OS needs to be supported, but at least supporting wear OS would be mandatory.
If this feature request would be accepted at the beginning some simple function could be written, like:
import 'package:ecg/ecg.dart';

var heart_rate = await (ecg().getHR());

Also, in a further step we would need to discuss about which ECG file format to use, because there are many.
I am a doctor and i have some programming skills, i would be happy to contribute with advices, feasibility, code.

This sounds like a great package that the open source community could write and maintain. I don't think the Flutter team will take this on, though.

@goderbauer would you mind to give some hint about how this should be achieved?
is flutter able to take ecg data from smartwatches or does it need to communicate with an app that runs on the background in the watch?


Question: How to add custom validation rule?

Hello,
I've been using the "respect\validation" part of your skeleton.
I try to add my own custom rule (ie: check email's user is not already used into DB), but it fails.
I have this kind of Slim error:
"newRule is not a valid rule name".
I think the "with" attribute has no effect or my new classes are not loaded by Slim...
This is not my code, but it's pretty similar:
https://github.com/ArneAnka/slim-test/tree/master/app/Validation
Did you manage to do so with your skeleton?
Best regards,
Ben

It's hard to know without seeing your code.
Typically, I only validate input to make sure it's the right format. I normally do checks against the database inside of my controller/action/domain.
https://github.com/dupkey/slim3-api/blob/f386ba33f0d918f69795b53d6f93b74b388bb6e1/app/src/Actions/Users/CreateUser.php#L60

Thanks @dupkey for your quick answer.
I finally managed to make my own respect\validation rule works.
I misunderstood the usage of the "with" instruction documented here:
https://respect-validation.readthedocs.io/en/1.1/feature-guide/#custom-rules
In my case, these following instructions must be added globally inside my Slim "dependencies" file:
use Respect\Validation\Validator as v;
v::with('App\Validation\Rules');
I was trying to add them locally inside my controller but it was not enough.
See you,
Ben

That makes sense, glad you got it working.
I tend to forget that using Pimple for DI one must wire up all their dependencies. If you want autowiring you can check out PHP-DI