Cinder: Missing Scheduler stats Java SDK

Hi,
In Kilo version of Cinder, it is exposing new api scheduler-stats/get_pools which will help user to get the Pool information which has capacity/usage and other capabilities information of backend storage.
I have written the java SDK for it. I would like to know the process to submit it for review.

Sure!

Hi Saba,
Thanks for the pull request,
Two things:

Use underscore in constants SCHEDULERSTATS > SCHEDULER_STATS

Do not concatenate Strings with (+), instead use StringBuilder append

The other parts of your code looks good

Hello,
I have implemented the review comments. Thanks for your time.
Thanks,
Saba

Hello,
I have implemented recent review comments by Daniel. Let me know for any changes.
Thanks,
Saba

Daniel is who implemented all the cinder stuff, your changes looks fine but
let's wait for his comments
Thanks
On Thu, Apr 30, 2015 at 10:54 PM, ansaba<EMAIL_ADDRESS>wrote:

Hello,
I have implemented recent review comments by Daniel. Let me know for any
changes.
Thanks,
Saba
—
Reply to this email directly or view it on GitHub
https://github.com/woorea/openstack-java-sdk/issues/182#issuecomment-97963856
.

--
Luis Alberto Gervaso Martin
Woorea Solutions, S.L
CEO & CTO
mobile: (+34) 627983344
luis<EMAIL_ADDRESS>


Duplicacy of code in video card fixes

The code is duplicated each time we add a video, and as @angiejones suggested we should make the changes standardized in the Video component and then use the <Video> component in the blog posts.

I'd love to work on this one

@Pratham271 assigned

@EbonyLouis we can't directly import the react components in mdx file can you guide me for the approach

@Pratham271 you can add components to mdx files, here's an example: site/src/pages/open-source/contributing.mdx if you look at the top of the file and the end of the file you'll see how it's done. Lmk if that helps

Thanks for the help

@EbonyLouis Cool to close?


moment().fromNow() returns 'Invalid date'

Description of the Issue and Steps to Reproduce:
I'm using moment to get the age of a user's account, by using:
moment(user account created date here).fromNow() but it return 'Invalid date'. This worked before but it no longer works. The created date looks something like: 2018-06-07T22:54:07.310Z.
Using moment(date here).format() works fine.
Please include the values of all variables used.
The date I use to format and use fromNow is 2018-06-07T22:54:07.310Z
Environment:
Discord Bot
Examples: Chrome 49 on OSX, Internet Explorer 10 on Windows 7, Node.JS 4.4.4 on Ubuntu 16.0.4
I don't use moment for anything listed above.
Both the browser and the OS are important to us, particularly if you have an unsual environment like an IOT application.
Other information that may be helpful: https://i.imgur.com/4LFsZh3.png

The time zone setting of the machine the code is running on: PST
The time and date at which the code was run: 12:20PM, 10/7/18
Other libraries in use (TypeScript, Immutable.js, etc) None

If you are reporting an issue, please run the following code in the environment you are using and include the output:
console.log( (new Date()).toString())
console.log((new Date()).toLocaleString())
console.log( (new Date()).getTimezoneOffset())
console.log( navigator.userAgent)
console.log(moment.version)

Sun Oct 07 2018 12:29:05 GMT-0700 (Pacific Daylight Time)
2018-10-7 12:29:05
420
2.22.2
Ensure your issue is isolated to moment. Issues involving third party tools will be closed unless submitted by the tool's author/maintainer.

You said: "This worked before but it no longer works"
Has anything changed since it worked - e.g. have you updated the environment your discord bot runs on?  Has the format of 'user account created date' changed?
Are you able to modify your discord bot code to show the output of the below (specifically using hard-coded strings):
console.log('moment.format:', moment("2018-06-07T22:54:07.310Z").format());
console.log('moment.fromNow:', moment("2018-06-07T22:54:07.310Z").fromNow());

It was working before then just stopped. No code changed. No envirnoment changed with the bot. The way the dates are being parsed seem the same too.
And here's what the console outputted;
moment.format: 2018-06-07T15:54:07-07:00
moment.fromNow: Invalid date

and here's how I used it (this.client.moment is how I have moment defined):
 console.log('moment.format:', this.client.moment("2018-06-07T22:54:07.310Z").format());
console.log('moment.fromNow:', this.client.moment("2018-06-07T22:54:07.310Z").fromNow());

Not sure if I mentioned it or not, but here are the current versions I'm using:
"moment": "^2.22.2",
"moment-duration-format": "^2.2.2"
and I'm on v8.9.2 of node

I'm having similar issue with Angular 6 (ionic based app) and moment 2.22.2 returns invalid date for something as simple as this.
moment(new Date()).fromNow();
please advise.

I am also affected by this.
At first, I believed that providing an incomplete unix timestamp (how the data is provided to me) was the cause, but upon testing the example code provided in MomentJS' documentation, I found that any call to fromNow() returned Invalid Date.

Same problem here.
toString Tue Jan 07 2020 10:20:09 GMT+0100 (Central European Standard Time)
toLocaleString 1/7/2020, 10:20:09 AM
getTimezoneOffset -60
navigator.userAgent Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:71.0) Gecko/20100101 Firefox/71.0
moment.version 2.24.0


How to check if IPFS is online

Hi, thanks for this great library! I have a question, I want to do a check if IPFS is online, before I give a command like "cat". In the full IPFS.js there is ipfs.isOnline, but this is not available in this library. Is there another way to check? Of do I have to just do for  example a "cat" command, and see if it gives an error?

Ok thanks, I will look at it.


veth: fix report of veth peer on a different netns

When the veth peer is on a different netns, the ifindex counting start
from "1" again. That means, if the veth has ifindex 30 one could expect
the peer will have ifindex 31 but if it is on a different netns, the
ifindex could be completetly different, e.g "2".
Signed-off-by: Fernando Fernandez Mancera<EMAIL_ADDRESS>

We should skip the interface name lookup when the IFLA_LINK_NETNSID is defined.

We should skip the interface name lookup when the IFLA_LINK_NETNSID is defined.

It won't work because the LINK_NETNSID is the ID of the NETNS where the veth interface is.. not the peer. In nispor we do not have information about other netns interfaces yet. We need to support multi-netns state querying..
What do you think about this solution? It checks that the veth peer and the peer iface matches in name.

The IFLA_LINK_NETNSID is the NSID of veth peer. https://www.spinics.net/lists/netdev/msg317678.html You may try strace -s 1024 ip -d link to get it.

@cathay4t Take a look when you have time, thank you!


[Bug]: Parenthesis in folder name producing errors in bash script.

What happened?
I put a jest test inside of a folder with () in the name, and it failed.  Here's the error when I run bazel test:
/path/to/execroot/foo/bazel-out/k8-fastbuild/bin/path_to_nextjs_app/src/app/(group)/api/todos/jest_test.sh.runfiles/foo/path_to_nextjs_app/src/app/(group)/api/todos/jest_test.sh: line 408: syntax error near unexpected token `('

And the line its referring to the from the bash script is:
ALL_ARGS=(--no-cache --ci --config path_to_nextjs_app/src/app/(group)/api/todos/jest_test__jest.config.mjs --colors --runInBand "$@")

Version
Development (host) and target OS/architectures:
Output of bazel --version:
bazel 6.1.1

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:
http_archive(
    name = "aspect_rules_jest",
    sha256 = "098186ffc450f2a604843d8ba14217088a0e259ea6a03294af5360a7f1bcd3e8",
    strip_prefix = "rules_jest-0.19.5",
    url = "https://github.com/aspect-build/rules_jest/releases/download/v0.19.5/rules_jest-v0.19.5.tar.gz",
)

Language(s) and/or frameworks involved:

Next.js app directory with route groups

How to reproduce
Since this doesn't appear to be a next.js specific thing, I bet you can reproduce it by putting a jest test inside any folder with parenthesis in the name.

For example, I cloned this repo, ran `mv example/simple example/\(simple\)`, and I was able to reproduce the error with `bazel test ...`

Any other information?
I'm not 100% sure if this is the right spot, but it looks like this line might be the culprit? https://github.com/aspect-build/rules_jest/blob/main/jest/private/jest_test.bzl#L85

Closing since the PR got merged.


[5.4] add where weekofyear in query builder.

add a WEEKOFYEAR in query builder, user like
$users = User::whereWeek('created_at', 32)
    ->get()

or
$users = DB::table('users')
    ->whereWeek('created_at', 32)
    ->get();

It's quite a confusing by looking to syntax that it belongs to a week of year whereWeek what if I want to use it as a week of a month then?

It's quite a confusing by looking to syntax that it belongs to a week of year whereWeek what if I want to use it as a week of a month then?

@Modelizer Yes, renamed method name.

@Modelizer Yes, renamed method name.

@maldechavda Thanks!
What if I want to get by month? I know you will create a new method whereWeekOfMonth but let @taylorotwell view it first. Also, update the description to get more clarity.
Thanks.

@maldechavda Thanks!
What if I want to get by month? I know you will create a new method whereWeekOfMonth but let @taylorotwell view it first. Also, update the description to get more clarity.
Thanks.

@GrahamCampbell Thank you, removed unneeded changes.

@GrahamCampbell Thank you, removed unneeded changes.

Looks like you've actually targeted 5.5, rather than 5.4. Please can you target the 5.4 branch. :P

Looks like you've actually targeted 5.5, rather than 5.4. Please can you target the 5.4 branch. :P

@GrahamCampbell So sorry

@GrahamCampbell So sorry

Don't worry about it. :)

Don't worry about it. :)


Seg Fault

I g0t a segfolt while playing yur geim! This is unakseptable for a finale prodcut. Plise fix IMMEDIATELY.

Looks like you are invalid, sorry


Mute when volume = 0

Hello.
According to the RDA5807 documentation, the volume should be muted when set to 0.
"When 0000, output mute and output impedance is very large"
Do I understand correctly?

If I call setVolume(0), then the radio continues to play as if it is a minimum volume like setVolume (1)

I think there is a problem with the text of the Documentation.
DAC Gain Control Bits (Volume) -   0000=min; 1111=max. Volume scale is logarithmic.
When 0000, output mute and output impedance is very large.  Should be "output mutes"? . Or "Output mute" impedance is very large when  0000?

Logically, any radio will have silence in the most minimal position.

I see... well,  in this case, it is up to the developer to decide what best applies to the project. You have the mute function by using setMute(true). If you want total silence, I think the setMute function  this is more recommended than setVolume(0). Said that, consider, via programming, testing the volume. When it is 0 (getVolume() is 0)  then setMute(true), otherwise setMute(false). I think it will do what you want. Right?

Yes, I think you're right.

I fixed some bugs today.
The setMute function was modified. I also added the function setAudioOutputHigZ.  Both functions deal with audio output  and mute the receiver.

Thank you!
This is like an offtop, but can I suggest adding a choice of an antenna type?
Or make reg05-> refined.lna_port_sel = 3;

I have just implemented setLnaIcSel and setLnaPortSel.  I have not tested it so far. Also I did not selected 3 by default for while due to legacy applications (I need check it before).    Can you check these functions and share the results with me? Thanks.

Hello.
I tested Setlnaicsel and Setlnaportsel.
Setlnaportsel definitely works fine.
Setlnaicsel I could not understand the changes by ear. Can this affect the RSSI level?

To be honest I have no idea what the LNA IC SEL (Setlnaicsel) really do. I cound notice here that the LNA PORT affect the RSSI. I have the same opinion about the volume. I think it is not recommended for using in  a real application. I'm not sure. It is better to control the volume with a audio amplifier module. I mean, I think we should use a fixed volume in the RDA5807 or use its high impedance setup to be processed with a good audio amplifier.  Thanks for testing.

I'm closing this issue. Please, few free to open another one if you need. Thanks.

I'm closing this issue. Please, few free to open a new one if you need. Thanks.


EXSWHTEC-100 - Miscellaneous modifications to existing memory tests

Enable previously disabled tests for hipFree
Remove templated test cases for hipFree where they are unnecessary
Additional tests for hipHostGetDevicePointer
Additional tests for hipHostUnregister
Additional tests for hipMallocPitch.

@milos-mozetic
Will you please resolve the merge conflicts for this PR?


How to use YOLOX to detect polygon targets

Hello, professro:
Thanks for your yolox code, it's really helpful for me. I am a student, I will use yolox to detect  quadrangle targets, which means network need to output 4 coordinate points at the end. So I want to know which parts of the network I should change. Thanks for your answer.
Best regards.

@SiChuanJay You can modify the output channel for the regression head. And change the regression targets correspondingly.


Fix for #50

This fixes #50 by adding label.endsWith("*") check.
Unit test is also included using the word Gelb.

Codecov Report

Merging #54 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #54   +/-   ##
=========================================
  Coverage     75.99%   75.99%
- Complexity     1321     1322    +1
=========================================
  Files           101      101
  Lines          4629     4629
  Branches        801      801
=========================================
  Hits           3518     3518
  Misses          895      895
  Partials        216      216

Impacted Files
Coverage Δ
Complexity Δ

.../jwktl/parser/de/components/DEWordFormHandler.java
77.48% <100%> (ø)
74 <0> (+1)
:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db23009...a66af6c. Read the comment docs.

CLA not signed yet.

I've asked for a confirmation for CCLA, but this may take my employer very long time (huge corp).
Should I maybe sign the ICLA first?

Thanks for all your changes. ICLA would be fine for merging. CCLA is recommended, but it depends on what status the work has for your company and how they deal with OSS projects in general.

I'm working to get CCLA but it may take pretty long time.

I've signed and e-mailed the ICLA.


fix: handle optional parameters

LotusJson<Option<T>> is handled as an optional argument

nit: Does this fix an encountered issue? Perhaps a simple test is in order to verify that LotusJson<Option<T>> encodes/decodes the way we expect. It's a couple of lines of code, but goes a long way, especially if this code is ever touched by somebody else.


[Proposal] create a view for whoops errors instead of the currently hard coded

can you please 🙏  create a view for the whoops page like the included 503 view instead of the currently hard coded in vendor/symfony/debug/ExceptionHandler.php so the user can easily edit it without to much trouble ?

https://mattstauffer.co/blog/laravel-5.0-custom-error-pages

this doesn't fix the issue because most of the errors are handled through that view, so to override it you will have to write the error exception one by one, this error basically handle anything other than the 404.
if am wrong plz correct me 👍

You can write a different error page for each status code.
I thought that was what you wanted.
Otherwise you can just write your own exception handler and decide whether or not to pass it to the base class or handle it yourself, see (https://laravel.com/docs/5.2/errors#the-exception-handler)

what i wanted is to have a default error view that i can modify anyway it fits the app, and if i still need to make something in specific for one type of the errors then am still free to do so, but having that whoops page popping up in each app gets created with the framework is simply non-sense 😞 .

you could overrite the decorate function in the exception handler.php in youre app folder

How about overwriting the decorate method in the app/exceptions/handler.php?

i believe it wont make a difference because of the original method

vendor/symfony/debug/ExceptionHandler @ getContent

    /**
     * Convert the given exception into a Response instance.
     *
     * @param \Exception $e
     *
     * @return \Symfony\Component\HttpFoundation\Response
     */
    protected function convertExceptionToResponse(Exception $e)
    {
        $debug = config('app.debug', false);

        if (!! $debug) {
            $e = FlattenException::create($e);
            $handler = new SymfonyExceptionHandler(config('app.debug'));
            $decorated = $this->decorate($handler->getContent($e), $handler->getStylesheet($e));

            return SymfonyResponse::create($decorated, $e->getStatusCode(), $e->getHeaders());
        }

        return response()->view('errors.error', ['exception' => $e], 500);
    }

You can use something like https://github.com/GrahamCampbell/Laravel-Exceptions.

@GrahamCampbell am already using it in local, but in production am using bug snag which as far as i know doesn't have the same flexibility , or does it ?

It is very flexible in production too. https://styleci.io/ uses it in production.

We also use Bugsnag for logging errors.

In order to use Bugsnag, you don't need to use their laravel package. You can use https://github.com/AltThree/Bugsnag along with https://github.com/AltThree/Logger.

I'm working on getting their next laravel package to use psr loggers rather than overriding the exception handler actually.

My exception package is absolutely designed for production use. The fact it has application in development is purely a consequence of the design used. It's transformer and displayer system is very powerful.

actually the only reason am using bugsnag is to get notified when something happens and trace the error from their dashboard, if ur package offers the same i would be extremely happy to go with it instead 👍  ,
actually i thought u were the maintainer of the bugsnag package because of ur last commit,
anyhow can u make a small guide on how to implement the AltThree packages, specially i don't know where i would add the bugsnag key or should i replace the default exception handler with something else or not, etc...

actually i thought u were the maintainer of the bugsnag package because of ur last commit,

Well, actually, I am for now. I'm working for Bugsnag for 12 weeks. ;)

Getting the alt-three logging packages set up is pretty easy. Here is my config from StyleCI itself:

Make sure you regiser the alt-three service providers too. Note that you don't need the "logify" line. That's our private logging system. You'll just need "logger" and "bugsnag".

awesome 💯  and for the exception handler, should i use ur package or go with the default ?

Yes. :)

sweet, many thanx gc :metal:

No problem. :)


WARNING:root:Failed to load config file: [Errno 2] No such file or directory:

junlan@Junlan:~$ onedrived-pref drive set
WARNING:root:Failed to load config file: [Errno 2] No such file or directory: '/home/junlan/.config/onedrived/onedrived_config_v2.json'. Use default.
Reading drives information from OneDrive server...

All available Drives of authorized accounts:

#    Account Email    Drive ID    Type    Quota    Status
---  ---------------  ----------  ------  -------  --------

Can you double check if you have this file? /home/junlan/.config/onedrived/onedrived_config_v2.json

@derrix060 Don't have this file.

So what is the problem?

@derrix060 Hi there, I have the same issue. Installed using pip (recommended) and also added ngrok to the PATH, but I get the exact same error if I try to do anything with the daemon.
The reason is that I cannot correctly register ngrok backend. I get this:
root@onedrive-integration-test:~# onedrived-pref account add
WARNING:root:Failed to load config file: [Errno 2] No such file or directory: '/root/.config/onedrived/onedrived_config_v2.json'. Use default.
NOTE: To better manage your OneDrive accounts, onedrived needs permission to access your account info (e.g., email address to distinguish different accounts) and read/write your OneDrive files.
Paste this URL into your browser to sign in and authorize onedrived:
https://login.live.com/oauth20_authorize.srf?client_id=000000004010C916&response_type=code&redirect_uri=https%3A%2F%2Flogin.live.com%2Foauth20_desktop.srf&scope=wl.signin+wl.emails+wl.offline_access+onedrive.readwrite
The authentication web page will finish with a blank page whose URL starts with "https://login.live.com/oauth20_desktop.srf". Paste this URL after the prompt.
Paste URL here: https://login.live.com/oauth20_desktop.srf?code=XXXXX&lc=1033
Successfully authorized onedrived.
Failed to save account: No recommended backend was available. Install the keyrings.alt package if you want to use the non-recommended backends. See README.rst for details..
root@onedrive-integration-test:~#
I can confirm that ngrok is part of PATH and I can manually call it from the console:
root@onedrive-integration-test:~# ngrok
NAME:
ngrok - tunnel local ports to public URLs and inspect traffic
DESCRIPTION:
ngrok exposes local networked services behinds NATs and firewalls to the
public internet over a secure tunnel. Share local websites, build/test
webhook consumers and self-host personal services.
Detailed help for each command is available with 'ngrok help '.
Open http://localhost:4040 for ngrok's web interface to inspect traffic.
EXAMPLES:
ngrok http 80                    # secure public URL for port 80 web server
ngrok http -subdomain=baz 8080   # port 8080 available at baz.ngrok.io
ngrok http foo.dev:80            # tunnel to host:port instead of localhost
ngrok tcp 22                     # tunnel arbitrary TCP traffic to port 22
ngrok tls -hostname=foo.com 443  # TLS traffic for foo.com to port 443
ngrok start foo bar baz          # start tunnels from the configuration file
VERSION:
2.2.8
AUTHOR:
inconshreveable -<EMAIL_ADDRESS>COMMANDS:
authtoken    save authtoken to configuration file
credits      prints author and licensing information
http         start an HTTP tunnel
start        start tunnels by name from the configuration file
tcp          start a TCP tunnel
tls          start a TLS tunnel
update       update ngrok to the latest version
version      print the version string
help         Shows a list of commands or help for one command
root@onedrive-integration-test:~#
Please let me know if there's anything I am doing wrong and thanks for your help.

Fixed it with https://github.com/xybu/onedrived-dev/issues/37

Fixed it with solution discussed at the end of #37

emanuelstanciu, how did you solve this problem?

@Allexe :( apologies, cannot remember what I did to fix it - I think was just installing a keyring in Ubuntu.
However, I gave up on this implementation altogether - it was too buggy


Release v0.25.0

This includes two minor fixes (#222, #224) and a temporary package (#228) to facilitate short-term development goals. There are a number of PRs pending in collector-contrib that have to merge before we can actually remove the components here: this temporary package will be removed after these two merge upstream:
https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33688
https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/33579

NEVERMIND


Latest version of mini_al

Do you have any plan to upgare mini_al? It has some API changes and improvements (https://github.com/dr-soft/mini_al/blob/891258a5b0c463ada17c544c438fb6fe6d4f148c/mini_al.h#L13100-L13135)

Actually that's why I asked and pointed that link. The latest version of mini_al is v0.7 2018-02-25 vs malgo uses v0.5 - 2017-11-11.
btw - I tried to replace malgo/mini_al.h with the latest mini_al/mini_al.h file and seems like it works (shows a bunch of warnings tho).

Hey, I just remembered that I didn't explained best the issue here. API already changed, in v0.7, but new release is coming, with many changes (285 so far), and with some very cool ASM and hardware improvements (even on ARM arch).
So, I will just wait for that release, so I don't have to do the API changes two times. I do use this library in some projects and do care about it. Original mini_al C library is super cool, designed just to work, without worrying about linking any lib, maintaining Go wrapper for that should not be difficult I guess.
I had some plans before, to move this package to sub dir/package and to create reader/writer interface with mini_al, like https://github.com/hajimehoshi/oto lib has. Good example, but I don't know when will I find time for that.

@devfacet mini_al is updated to latest dev version. New release should follow soon but there will be no big changes.

Thanks, I appreciate it


Possible defect

Hi,
Using your plugin, I got some strange results when building the authorised roles list if the user is a 'system administrator'. I think there might be a defect on line# 104 in the validate function:
103:        if (isset($this->_acl[$controller][$this->_allSign])) {
104:            $authRoles = array_merge($this->_acl[$controller][$this->_allSign]);
105:        }

should possibly be:
103:        if (isset($this->_acl[$controller][$this->_allSign])) {
104:            $authRoles = array_merge($this->_acl[$controller][$this->_allSign], $authRoles);
105:        }

If not corrected the $authRoles array may get overwritten at this stage and not appended, which I don't think is the expected behaviour. Happy to be corrected :)
PS: Like your plugin btw and looking at extending at some point.
Cheerio,
Luuk

Ah, nice catch. Strange it never came up in my project.

Okay, fixed.


Fix for Issue 483

Fixes issue https://github.com/gregnb/mui-datatables/issues/483 (changedColumn was showing filtered value instead of column name).
When removing filters (TableFilterList.js), there is no information about column names, so null is supplied instead. We could default to the filter value removed in this case (as it was previously), but not sure what is best.
UPDATE:
The proper column name should now always be passed along with the filter information. This was done by passing the column names along to the filter list component, and correlating them with filter position (which matches column position).

Coverage decreased (-0.4%) to 71.509% when pulling 8760dfc0793f4b21e96c766a0df4e6a5ac4bad50 on gabrielliwerant:issue-483 into 247b6703015edb404730ef39a9c83a760a3225b8 on gregnb:master.

Alright let me think on this one maybe we can come up with a better solution to solve that null issue

I added a state value to pass into the TableFilterList in order to prevent the null after removing filters. Also added testing around the filtered column name in the callback in order to help prevent regressions. @gregnb

@gregnb Added a more elegant fix here which should solve the outstanding issues.

Looks great thanks @gabrielliwerant


Dependency on AGPL-licensed code

This project takes a dependency on an AGPL-licensed project (https://github.com/onflow/flow-go). This dependency was introduced with https://github.com/onflow/flow-go-sdk/pull/118 and effectively makes it impossible for any commercial projects to integrate this SDK without also agreeing to the AGPL. I'm guessing this was not intentional since this SDK is licensed as Apache 2.0.
I've forked this project and removed the dependency on the crypto package. However, because the crypto package is so fundamental to how this SDK works it reduces the usefulness. Here is an article that explains why projects (like us) don't want to link against AGPL-licensed code: https://opensource.google/documentation/reference/using/agpl-policy/.

Thanks for raising this issue.
Flow Go SDK only uses part of onflow/flow-go/crypto so we should work on moving the needed code to remove the import.

Dependency removed here https://github.com/onflow/flow-go-sdk/pull/418


[Meta] PHP 7.2 features

PHP 7.2.0 Alpha 3 is released , lets list the things we need to take care of or could support.

[ ] "object" (in any case) can no longer be used as a class name. RFC
[ ] It is now possible to remove argument type annotations when overriding an inherited method. RFC
[ ] It is now allowed to override an abstract method with another abstract method in a child class. RFC
[x] A trailing comma in group use statements is now allowed. RFC PR
[ ] The "object" type annotation is now supported. RFC
[ ] The (unset) cast has been deprecated. This does not affect the unset($var) language construct.

Sources:
https://github.com/php/php-src/blob/php-7.2.0alpha3/NEWS
https://github.com/php/php-src/blob/php-7.2.0alpha3/UPGRADING
Note: I've only listed the first bunch of items I spotted that might effect us, i.e. because we made assumptions on PHP behavor and/or syntax, and items we could write fixers for.
Please comment if I forgot anything (@ maintainers, feel free to update this issue with more details when needed)
Ps. Jun 18 should be the feature freeze; https://wiki.php.net/todo/php72 so in theory new items might be in Beta 1 (that are not listed here yet)

the freeze date is actually Jul 18 2017 | PHP 7.2 branched and feature freeze on the linked page

thanks :)  I either copy-pasted wrongly or the doc linked was updated, anyway I'll update the ticket :)

PHP 7.2.0 Beta 1 Released :)
PHP 7.2.0 Beta 1 builds on previous releases with:

The much anticipated Sodium extension
Opcache improvements
Countable support for DOMNodeList and DOMNamedNodeMap
Improved handling for invalid UTF8 in json_decode()

nothing related to this project...

iiuc, there's not yet a current/working branch that's php 7.2-friendly?
	    - friendsofphp/php-cs-fixer v2.3.2 requires php ^5.6 || >=7.0 <7.2 -> your PHP version (7.2.0-dev) does not satisfy that requirement.
	    - Installation request for friendsofphp/php-cs-fixer (locked at v2.3.2, required as ^2.3) -> satisfiable by friendsofphp/php-cs-fixer[v2.3.2].

just a bit confused between this, and other posts ...

there won't be fully compatible release with 7.2 until all 7.2 syntax changes (thus, for us, incompatibilities) will be handled.
you could execute app on 7.2 nevertheless by setting PHP_CS_FIXER_IGNORE_ENV env var

as @pgnd said,
- friendsofphp/php-cs-fixer v2.3.2 requires php ^5.6 || >=7.0 <7.2 -> your PHP version (7.2.0-dev) does not satisfy that requirement.

So, is it planned at any time to update composer.json requirements to allow to install with composer under php 7.2 beta?

as @keradus said,

there won't be fully compatible release with 7.2 until all 7.2 syntax changes (thus, for us, incompatibilities) will be handled.

So, is it planned at any time to update composer.json requirements to allow to install with composer under php 7.2 beta?

it's not about changing one composer.json file. requirement in composer states which syntax we understand and support. if software will be executed on 7.2 code, it could break it, and behaviour is unexpectable.
If you want to have PHP CS Fixer run on 7.2, please help with supporting 7.2 syntax changes.

Can we please discuss in detail what specific impact each new feature has on this project? I would like to help on this, but as a newcomer here I don't know enough stuff to start coding, I would love some pointers!
#3007 has demonstrated that the tests suite is currently green under 7.2, so no issues in the current state. As for what quoted in the opening message, I would like to summarize my conclusions. Please correct me if I'm wrong:

"object" (in any case) can no longer be used as a class name:
this has no impact on us, since no fixer exist for this, and no Object class is present in the project
It is now possible to remove argument type annotations when overriding an inherited method:
No impact here too, no fixer or no known issue in the current codebase
It is now allowed to override an abstract method with another abstract method in a child class:
No impact here too, no fixer and it's only a new possibility that works between two different (parent-child) classes
A trailing comma in group use statements is now allowed:
Already done in #2941
The "object" type annotation is now supported
This may need some testing? Do we have some test that needs a new fixture with an object $a annotation?
The (unset) cast has been deprecated. This does not affect the unset($var) language construct:
No test failure (due to deprecation) so no usage of this as far as I can tell

As I can see, only 5 may need some (small) work to allow PHP 7.2. Am I missing something?

Hi. not able to read whole of it now, will do it later (and I'm pinging @SpacePossum for time being), but one thing I could say now:

#3007 has demonstrated that the tests suite is currently green under 7.2, so no issues in the current state.

We need to add all new/changed syntax of PHP 7.2 to:
https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/2.5/tests/Fixtures/Integration/misc/PHP7_2.test
to claim we do support 7.2
It's not about "we change 7.2 syntax", but it's about "we understand and not break 7.2 syntax"
so first thing is to gather syntax changes in 7.2 integration test and fix whatever is needed, and then, if we want to, we could make new rules targeting 7.2 only (but that part is not obligatory to provide official 7.2 support)

First off, the tests prove the code runs fine on PHP7.2. However we need to prove we understand PHP7.2 code (as @keradus stated).
Looking at the items I've listed there are still a few TODO's. My view on things;

It is now possible to remove argument type annotations when overriding an inherited method. RFC

For this we should check the fixers that insert and/or remove type hints, either in code or in PHPDocs. Even if there are no issues, we still need tests to prove it.

"object" (in any case) can no longer be used as a class name. RFC
The "object" type annotation is now supported. RFC

Same as above. I expect additional work for this after that.

It is now allowed to override an abstract method with another abstract method in a child class. RFC

We should check all fixers dealing with abstract methods and add tests.

A trailing comma in group use statements is now allowed. RFC PR

One issue was fixed, however we should add tests to all fixers that deal with imports.
Include the ones that reorders, checks for unused imports etc., just to see those work as expected.

The (unset) cast has been deprecated. This does not affect the unset($var) language construct.

I looked into this, but I see no work to be done here for us.

For this we should check the fixers that insert and/or remove type hints, either in code or in PHPDocs. Even if there are no issues, we still need tests to prove it.
The only fixer that add/removes an argument that I could find is phpdoc_add_missing_param_annotation, but it doesn't care about parent/child classes, so it shouldn't be impacted by that change.

One issue was fixed, however we should add tests to all fixers that deal with imports.
Include the ones that reorders, checks for unused imports etc., just to see those work as expected.
Do you mean those in combination with the one already done? Or the tests should start with an input with the trailing comma?

For example the tests of OrderedImportsFixer should be extended to with PHP 7.2 test code with the trailing , in the imports to see if still works as expected. Same for other fixers that deal with imports.

You seem to have already done it! See https://github.com/Jean85/PHP-CS-Fixer/commit/b3b58f501a11d26e3e9b86fdecfdf06efa440d5f
That's funny :smile:

Nice!
From that PR the description stated:

This doesn't solve all issues for PHP 7.2 support, but it is a good first round I think :)

Wondering whether there's something more.

I'm getting old :)

Ahah :smile:
So, we can consider this issue done? :+1:

this meta-issue ? no
even if group-imports is tested,  we need to at least add other things to integration tests

Closing as https://github.com/FriendsOfPHP/PHP-CS-Fixer/pull/3038 provides the last of tests.
Enhancements and other implementation details can be discussed in dedicated issues and PR's.


Add Qualification unit-tests

Signed-off-by: Ahmed Hussein (amahussein<EMAIL_ADDRESS>Partially contribute to #36 by adding the following unit tests:

[x] failure_non_existing_cluster
[x] failure_on_spark2
[x] failure_non_running_cluster
[x] success_run - no output - run on non-gpu cluster - run on gpu-cluster

What is this file used for? tool_output_files.tar.gz

This file contains actual output from running Qualification tool on sample eventlogs.
To mock submitting successful Qualification job on dataproc, the unitest loads this tar.gz as if it was downloaded from the dataproc cluster.


remove pytz from test dependencies

Using pytz in tests risks us accidentally including references to it in the actual library, which is no longer included as a transitive dependency for the core Google libraries.

Based on current priorities and workload, downgrading this to a P3

Nishant did some experimentation and determined that there was a dependency on pytz via pyarrow.

Closing this PR for now.

Running into

pyarrow.lib.ArrowInvalid: Pytz package or Python>=3.8 for zoneinfo module must be installed
but this error message from pyarrow seems incorrect, since zoneinfo is introduced in Python 3.9.

Solutions would be to upgrade bigquery-sql-alchemy to Python 3.9 now or wait a year (when Python 3.8 is depreciated) to remove the pytz dependency.


Make env_servlets cache an instance field instead of global.

We don't need this to be global, it's only used in the object store.
In general, minimizing the amount of global stuff we have referencing important objects is better to avoid weird memory issues.

[!WARNING]
This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

#736  👈
#733 : 1 other dependent PR (#734 )
#735
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rohinb2 and the rest of your teammates on  Graphite

Merge activity

Apr 16, 2:02 PM EDT: @rohinb2 started a stack merge that includes this pull request via Graphite.


Cannot output null value in ResultPath

We cannot output the following JSON definition even if result_path is None.
{
  "Type": "Parallel",
  "ResultPath": null
}

If result_path is specified explicitly, user should expect to have it in the final statemachine definition.
from stepfunctions import steps

p = steps.Parallel('test', result_path=None)
assert 'ResultPath' in p.to_dict()

Hey @shunjd, I hope you're doing great man.
I faced the same behavior yesterday with a steps.Task, so I submitted #48 that I think fixes this error for any state type.
Let me know what you think.
Thanks!


Release v1.5.2

What version number is to be released?
v1.5.2
What is the estimated date for this release?
~06.11.2024~ 13.11.2024
Release procedure
Please refer to the Release Procedure doc.
Release notes
Please remember to create a pull request with a draft of the release notes in the Release Notes History doc.
Please make sure the notes render correctly on the website.
That includes swapping out GitHub-idiomatic @mentions of users, links to PRs, issues, etc.
You can do that using the regexes provided in this doc

It seems Scala CLI 1.5.2 will only be available as a JVM launcher on sonatype.
scala-cli --cli-version 1.5.2 --version
# Fetching Scala CLI 1.5.2
# Scala CLI version: 1.5.2
# Scala version (default): 3.5.2

A dependency is causing our tests to fail consistently, even though they were passing before.
Created a follow-up issue:

https://github.com/VirtusLab/scala-cli/issues/3271

And 2 hotfix PRs:

https://github.com/VirtusLab/scala-cli/pull/3272
https://github.com/VirtusLab/scala-cli/pull/3270

I will likely follow-up with a hotfix 1.5.3 release, which would be the last in the 1.5.x series.


Restoring klayout pcells for GF180MCU and fixing some issues in it

Restoring klayout pcells for GF180MCU and fixing some issues in it

@FaragElsayed2 I assume that is not done?

@atorkmabrains Yes, it still needs more modifications.

Will not merge


LLVM cannot be uninstalled in the background

Brief description of your issue
When running winget install -h -e --id LLVM.LLVM, LLVM is installed in the background, without the installer popping up.
When running winget uninstall -h -e --id LLVM.LLVM, the LLVM uninstaller pops up, and you need to interact with it to start the uninstallation!
Steps to reproduce

winget install -h -e --id LLVM.LLVM
winget uninstall -h -e --id LLVM.LLVM

Expected behavior

LLVM is installed in the background.
LLVM is uninstalled in the background.

Actual behavior

LLVM is installed in the background.
The LLVM uninstaller pops up, and you need to interact with it to start the uninstallation.

Environment
Windows Package Manager v1.3.2091
Windows: Windows.Desktop v10.0.22000.856
System Architecture: X64
Package: Microsoft.DesktopAppInstaller v1.18.2091.0

Some installers do not support silent uninstallation, or require custom switches to uninstall silently.
If they do not support silent uninstall, there isn’t anything we can do about it.
If they require custom switches, then we need #1885 to be implemented before support can be added


Hamburg Bug: White space

From Hamburg meeting 25/03/15.
Colleague from DONG had problem with whitespaces in the field names. They didn't appear in the box itself, but were present in the subsequent variable.

I think this method should fix this.
rstrip method


⚠ PrivateHD has degraded performance

In e40a8a4, PrivateHD ($PHD) experienced degraded performance:

HTTP code: 200
Response time: 1388 ms

Resolved: PrivateHD performance has improved in f7c2372.


Build process errors

Hi all, excellent project - but I tried using window_manager in my flutter app - both using the pub.dev copy and fresh off git; but I'm getting the below build errors building even the basic example in the docs.
Launching lib/main.dart on Linux in debug mode...
Building Linux application...
ERROR: ../../../snap/flutter/common/flutter/.pub-cache/git/window_manager-602e35e6467cb07528f319fae798dade67969d01/lib/src/window_manager.dart:558:32: Error: The getter 'name' isn't defined for the class 'Brightness'.
ERROR:  - 'Brightness' is from 'dart:ui'.
ERROR: Try correcting the name to the name of an existing getter, or defining a getter or field named 'name'.
ERROR:       'brightness': brightness.name,
ERROR:                                ^^^^
ERROR: ../../../snap/flutter/common/flutter/.pub-cache/git/window_manager-602e35e6467cb07528f319fae798dade67969d01/lib/src/window_manager.dart:585:34: Error: The getter 'name' isn't defined for the class 'ResizeEdge'.
ERROR:  - 'ResizeEdge' is from 'package:window_manager/src/resize_edge.dart' ('../../../snap/flutter/common/flutter/.pub-cache/git/window_manager-602e35e6467cb07528f319fae798dade67969d01/lib/src/resize_edge.dart').
ERROR: Try correcting the name to the name of an existing getter, or defining a getter or field named 'name'.
ERROR:         "resizeEdge": resizeEdge.name,
ERROR:                                  ^^^^
Exception: Build process failed

The package is conflicting with dart:ui. Import one of the two as something else.
I'm not sure where you get resizeEdge.name from. It doesn't exist. Here's the docs.

what is your dart sdk version?

@damywise I think his dart version doesn't support enum.name yet

Dart SDK version: 2.14.4 (stable) (Wed Oct 13 11:11:32 2021 +0200) on "linux_x64"
I did a clean project incase there was a weird legacy pubspec issue.... but still get the same errors.
This is the only code (pretty much identical to the example). Thanks!
import 'package:flutter/material.dart';
import 'package:window_manager/window_manager.dart';

void main() async {

  WidgetsFlutterBinding.ensureInitialized();
  // Must add this line.
  await windowManager.ensureInitialized();

  // Use it only after calling `hiddenWindowAtLaunch`
  windowManager.waitUntilReadyToShow().then((_) async{
    // Hide window title bar
    await windowManager.setTitleBarStyle('hidden');
    await windowManager.setSize(Size(800, 600));
    await windowManager.center();
    await windowManager.show();
    await windowManager.setSkipTaskbar(false);
  });

  runApp(const MyApp());
}

class MyApp extends StatelessWidget
{
  const MyApp({Key? key}) : super(key: key);

  @override
  Widget build(BuildContext context)
  {
    return const MaterialApp(
        title: 'Test',
    );
  }
}

I fixed it. you can try to run the example from the main branch.


UnicodeDecodeError when install from source.

🐛 Bug Description
Run python setup.py install in source code repo might cause unicode decode error in some Windows language(ex. Big5)
Error message.
UnicodeDecodeError: 'cp950' codec can't decode byte 0xe9 in position 3935: illegal multibyte sequence
To Reproduce
Steps to reproduce the behavior:

Install from source in a Big5 Windows OS.

Expected Behavior
No error message
Screenshot

Environment
Note: User could run cd scripts && python collect_info.py all under project directory to get system information
and paste them here directly.

Qlib version: <IP_ADDRESS>
Python version: 3.8
OS (Windows, Linux, MacOS): Windows
Commit number (optional, please provide it if you are using the dev version):
ef161715f7aeb33d46fd724c8c2cd0700e55637b

Additional Notes

Thank you  for solving this problem here https://github.com/microsoft/qlib/pull/773


Update configuration_metadata.go

Support added for the configuration-properties.names property.

Summary

Use Cases

Checklist

[x] I have viewed, signed, and submitted the Contributor License Agreement.
[x] I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
[x] I have added an integration test, if necessary.
[x] I have reviewed the styleguide for guidance on my code quality.
[x] I'm happy with the commit history on this PR (I have rebased/squashed as needed).

Hello @AamnaZahid !
Thanks for your contribution!
Can you please:

provide context / explain what those changes will enable?
add unit tests

So that we'll be able to review.
Thank you!

Context/Explanation of Changes
Before:
The function only processed the configuration-properties.classes field by splitting its values and appending them to the classes list. It then matched these classes against SourceType values in metadata groups and properties.
After:
In addition to classes, code now handle configuration-properties.names similarly, where the names values are also processed and stored in a names list.
Both classes and names lists are merged into a combined list, which is used to match against the SourceType or Name fields in metadata Groups and Properties.
This ensures that both properties (classes and names) are additive and provide more flexibility for users to define mappings based on either class or name.
What those changes will enable?

Support for configuration-properties.names:  Now, users can specify both classes and names in the dataflow-configuration-metadata.properties file. This makes the configuration process more intuitive and documented.

Expanded Mapping Capabilities: The new logic allows for mapping based on both SourceType and Name fields, rather than being restricted to just SourceType. This provides more flexibility in defining and processing configuration metadata.

Support for configuration-properties.names: Now, users can specify both classes and names in the dataflow-configuration-metadata.properties file. This makes the configuration process more intuitive and documented.

OK, interesting. This is what I was trying to figure out as well. Where do these files come from, what apps are depending on them.
Can you provide a doc link that explains these files a little more? I want to make sure that there is some context here so we, as maintainers, know how this feature is being used. That'll prevent regressions in the future. Thanks

is that enough @dmikusa ?
https://dataflow.spring.io/docs/applications/application-metadata/

Yes
On Wed, 23 Oct 2024, 07:22 Anthony Dahanne, @.***>
wrote:

is that enough @dmikusa https://github.com/dmikusa ?
https://dataflow.spring.io/docs/applications/application-metadata/
—
Reply to this email directly, view it on GitHub
https://github.com/paketo-buildpacks/spring-boot/pull/513#issuecomment-2430688216,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A324ALWFDQAOGPUCBZ4CVQDZ44B7FAVCNFSM6AAAAABPHAMSK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZQGY4DQMRRGY
.
You are receiving this because you were mentioned.Message ID:
@.***>

@AamnaZahid I fixed a test, and added another one in a separate commit.

Awesome, thanks for the update!
On Thu, 24 Oct 2024, 04:40 Anthony Dahanne, @.***>
wrote:

@AamnaZahid https://github.com/AamnaZahid I fixed a test, and added
another one in a separate commit.
—
Reply to this email directly, view it on GitHub
https://github.com/paketo-buildpacks/spring-boot/pull/513#issuecomment-2433787014,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/A324ALRRZ7EIIP5LRQ2G3KTZ5AXWVAVCNFSM6AAAAABPHAMSK2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZTG44DOMBRGQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

To elaborate a bit more on the link provided by @anthonydahanne .
Here is a little background on the Dataflow dedicated metadata. It is used to drive the UI/API during stream/task definition.
This describes why we have the dedicated metadata:
https://dataflow.spring.io/docs/applications/application-metadata/#dedicated-metadata-artifacts
This describes the metadata file:
https://dataflow.spring.io/docs/applications/application-metadata/#data-flow-configuration-metadata
This describes the metadata label:
https://dataflow.spring.io/docs/applications/application-metadata/#metadata-container-image-label
Here is a concrete example that uses 3 of the pre-built stream-applications (e.g. splitter used below that include said metadata.
The stream is defined as time | splitter | log and you can see in the UI the user is presented w/ only the properties that are in this resulting metadata (otherwise we would have to show them all N of the available Spring Boot config props).

I hope this helps w/ some more context.
Thanks


Doc Feedback: Documentation is empty

Location : https://is.docs.wso2.com/en/latest/guides/authorization/fine-grained-authorization/


Code updates for the next version of the manuscript

Revised version is submitted to biorXiv and should appear soon


issue cannot be opened and display

when we click the issues item . the content of the issue cannot display.

Dupe #609


what steps to get franc-most.js

how do I get browser version of franc-most.js that can be included via script tag?

Download it from Releases.

thanks


fix: prevent NullPointerException if targetPackageName is null

Thanks for submitting this @PLin2023 . However, the proposed change does not actually prevent any NPEs. It just changes the NPE to be more informative: telling you that "targetPackageName" is what caused the NPE. As of Java 17, NPEs automatically tell you what was null.  See https://openjdk.org/jeps/358 (or other articles explaining it, like https://dev.to/harsvnc/the-new-nullpointer-exception-in-java-17-4bcb).
If you'd like to resubmit a new PR that actually ignores null packages, please explain in what scenario you encounter a null package that you'd like to ignore, and include a test.  Thanks!


DS-3352 dependency version bumps

https://jira.duraspace.org/browse/DS-3352

Closing. These updates have mostly happened on master via other PRs.  Plus, the ticket was closed


BIGTOP-2802. Some packages don't create necessary groups on debian-based system if the users correspond to them already exist

Thanks! In addition to that, this fix also covers the case that a user already exists but its group is not created. In such a case, the original scripts don't create the groups, so the final state differs from the normal case. It's undesirable.

adduser on centos-7 does not have that flag '--ingroup'. Sadly.

IMHO ambari should be fixed. Why does it create broken user/group configs?

@sekikn I think the patch looks reasonable, @oflebbe did you mistype? This patch only applies on Debian side -- so if you know any caveats of using --ingroup on that platform -- please let us know. Otherwise -- I guess the patch can go in?

Oh yes, it was too late that night. The patch looks very good for debian. Please apply

@c0s @oflebbe @rvs thanks for the reviews! I'm going to check this in.


runtime/cgo: _cgo_sys_thread_start error: implicit declaration of function

Windows amd64 build of go1.5beta3 fails.
v% all.bat
...
cmd/pack
# runtime/cgo
runtime\cgo\gcc_windows_amd64.c: In function '_cgo_sys_thread_start':
runtime\cgo\gcc_windows_amd64.c:32:2: error: implicit declaration of function '_beginthread' [-Werror=implicit-function-declaration]
  thandle = _beginthread(threadentry, 0, ts);
  ^
cc1: all warnings being treated as errors
cmd/pprof/internal/profile
cmd/pprof/internal/tempfile
...

v% gcc --version
gcc (GCC) 4.9.2

Any idea why _beginthread is not declared in <process.h>?  Is your GCC a cygwin or mingw32 build?
CC @alexbrainman

Also, the line "cc1: all warnings being treated as errors" implies that something is passing -Werror to GCC.  Any idea where that is coming from?  As far as I can tell the Go build process does not add it.

Hi Ian,
I use the MSYS2 installer (https://msys2.github.io) which is a popular lightweight 64-bit POSIX environment. Bazel use it too (http://bazel.io/docs/windows.html).
I think it's a mingw-w64 gcc.

Hi. Windows ports of gcc vary wildly. As documented on https://github.com/golang/go/wiki/InstallFromSource#install-c-tools, building Go from source requires TDM-GCC. My understanding is that MSYS2 is the same kind of thing as Cygwin. I'm glad that works for Bazel, but Go expects to use the raw Windows libraries, not a POSIX wrapper. I don't believe we are going to support Go using POSIX wrapper utilities. Doing both is too hard, and the POSIX wrappers always eventually get in the way.


Add schematic

The schematic was drawn from the information list in CH582 and
my observation on my LED Badge version.
Since the pdf file is generated, I don't know if it is appropriate to
put it here. I will provide KiCAD files if required.

Thank you. Please also add the Kicad file here.

I have added the KiCad files. Please check it out.

Close this PR as it has been moved to fossasia/badgemagic-hardware#8


Doesn't work in WSL

This does not depend on whether extensions are installed in WSL or not.
Selecting bundles does not enable or disable extensions.
(npm and yarn are installed on both the Windows host and the WSL distribution)

Hi, yes i've got a problem on the package used to access the vs code sqlite database and I wonder if VS Code didn't changed the extensions system.


[docs] pixelData Uint16Array has 2 bytes/pixel

https://github.com/cornerstonejs/dicomParser/issues/73#issuecomment-404851437 fixed the RangeError I and others seem to have encountered.

Coverage remained the same at 52.759% when pulling 7b6b581054d417249f533386d1929105b8a05958 on shivasuri:patch-1 into 8b154e9c100304146fa96b2908ec242978b40921 on cornerstonejs:master.


@property tag in VSCode No Suggestion

The following code does not produce a suggestion in visual studio code. It should produce a suggestion according to PHP Doc block reflection:

/**

@property mixed $test
/
class Transaction extends Core\Model{
/*

@property mixed $test
*/

protected $customer = null;

}

$trans = new \Arevico\CB\Model\Transaction();
$trans->

2 years, nothing?


Color

Enhancements to color handling.
Improved algorithm for hex to rgb conversion.
All colors, including x11 colors are parsed to a Color object and converted to rgb/rgba internally. This is needed in order to make expandShorthands and createShorthand methods work with named (x11) colors.
New methods for color conversion to/from hsl and rgb.

I guess we can now reasonably says that this won't be merged.


EVN does not support Reactive Energy

Checklist

[X] I have filled out the template to the best of my ability.
[X] This only contains 1 feature request (if you have multiple feature requests, open one feature request for each feature request).
[X] This issue is not a duplicate feature request of previous feature requests.

Is your feature request related to a problem? Please describe.
EVN does not provide Reactive Power (1-0:<IP_ADDRESS> Blindenergie Bezug +R (varh), 1-0:<IP_ADDRESS> Blindenergie Lieferung -R (varh)), but the integration requires it.
Describe the solution you'd like
Check if values are available, and if not, do not create the entities.
Describe alternatives you've considered

Additional context
EVN description: https://www.netz-noe.at/Download-(1)/Smart-Meter/218_9_SmartMeter_Kundenschnittstelle_lektoriert_14.aspx

Some more details: I tested with a Sagemcom T210-D.
To make it work with EVN, the used python lib smartmeter_austria_energy needs some adaptions; see pull request. https://github.com/NECH2004/smartmeter_austria_energy/pull/4

update to new lib (1.4.6)


ZipCrawler.next(): ValueError: day is out of range for month

On Macintosh running OS/X operating system, ran across a zip file with a day value that doesn't work for the month.
ValueError.txt

fixed


Make it work without any client-side JavaScript

We're sorry but frontend2 doesn't work properly without JavaScript enabled. Please enable it to continue.

You are not sorry, if you were sorry, this website wouldn't have tried to coerce me into enabling JS.
Also https://osv.dev/docs/ don't work.

Hi,
Unfortunately we don't have the resources to devote to maintaining a JS-free frontend.
We will have an option for you to consume the data without having JS enabled, as our data will be exported to a repository as plain YAML files (see https://github.com/google/osv/issues/44).

Unfortunately we don't have the resources to devote to maintaining a JS-free frontend.
we = Google
Google doesn't have resources.

I don't beleive.

We will have an option for you to consume the data without having JS enabled, as our data will be exported to a repository as plain YAML files (see #44).

Thanks, how about also making the site with docs no-JS?


Update query-processing-architecture-guide.md

Minor typo correction: example image was run-time and not compile-time as it contains entries for actual number of rows and actual partition count etc.

@PhilB-MSFT : Thanks for your contribution! The author(s) have been notified to review your proposed change.

@ktoliver : Thanks for your contribution! The author(s) have been notified to review your proposed change.

Can you please change run-time to runtime?

@pmasl - I made the revision. Is the PR ready to merge? Thanks.

Yes, thank you

#sign-off


Accessing controller instance on before/after middlewares

I'm setting up a controller with awilix-express, it works well, but I have some doubts.
In this example below, is it possible to setup a middleware on before that access the instance TodoController?
const { createController } = require('awilix-express')

class TodoController {
  constructor ({ todosService, cacheService }) {
    this.todos = todoService
    this.cacheMiddleware = cacheService
  }

  getAll(req, res) => {
    return res.send(this.todosService.getTodos())
  }

}

module.exports = createController(TodoController)
  .get('/todos', 'getAll', {
    before: [ this.cacheMiddleware() ] // I know "this" doesn't work here, but I need to access cacheMiddleware, How?
  })

Is there a way to do that? Maybe changing approach and not using a class? Can you show an example please?
Thanks!

@IGZgustavomarin you can use inject to have Awilix build the middleware:
const { createController, inject } = require('awilix-express')
// Assuming `cacheMiddleware` is a factory function
const { cacheMiddleware } = require('./your/cache/middleware')

class TodoController {
  constructor ({ todosService }) {
    this.todos = todoService
  }

  getAll(req, res) => {
    return res.send(this.todosService.getTodos())
  }

}

module.exports = createController(TodoController)
  .get('/todos', 'getAll', {
    before: [ inject(cacheMiddleware) ]
  })

Ok, this way works, but my middleware gets created each time I call the endpoint. Even if I set the lifetime to SINGLETON. I'm doing this:
const cacheProducts = ({ config }) => {
   return (req, res, next) => {
     /** cache logic here, return memory data or return next() **/
  }
  return cache
}

cacheProducts[RESOLVER] = {
  lifetime: Lifetime.SINGLETON
}
module.exports = cacheProducts

Is is possible to inject the same middleware every time? Otherwise, it never hits my cache data.

Lifetimes only apply to registrations, not resolvers built directly with container.build (which is what inject does), so you want to wrap it to use the registration:
module.exports = createController(TodoController)
  .get('/todos', 'getAll', {
    // assuming your middleware registration is named "cacheService"
    before: [ inject(({ cacheService }) => cacheService) ]
  })

In fact, Awilix has a resolver for this called aliasTo which does exactly what the previous example does:
const { aliasTo } = require('awilix')

module.exports = createController(TodoController)
  .get('/todos', 'getAll', {
    // assuming your middleware registration is named "cacheService"
    before: [ inject(aliasTo('cacheService')) ]
  })

Hope this helps. 😄

Ok, now the middleware gets injected each time. But the cache layer makes some patching to the Response object that doesn't work with inject, meaning it never cache anything. I think the middleware function that inject actually adds, collides with the apicache (npm module) that I'm using.
Is there a way to create a controller and register the routes differently?

But the cache layer makes some patching to the Response object that doesn't work with inject, meaning it never cache anything

How so?
How do you register cacheService? It would have to be singleton. Also, that cacheProducts middleware has return cache as well as return (req, res) => ..., is that a typo in the example?
Could you try creating a minimal reproduction repository? That would make it way easier for me to help you, cause I'm certain we can make it work. 😄

Finally solve it. It turns out that the cache layer didn't work with HEAD request only and that was messing my example. It works as intended. Sorry about that!
I've separated the logic into two controllers, like this:
mainRouter
 .use(loadControllers('cache/*'))
 .use(loadControllers('products/*'))

Each of those folders contains a class wrapped with a createController call. But I noticed that on each request a new instance is created. This is too expensive for the cache layer (ex: connection, warmup, etc). Is it possible to make that instance a singleton?
My cache controllers is as this:

class ProductsCache {
  constructor ({ config }) {
    /** THIS IS CALLED ON EACH REQUEST **/
    this.cacheAll = apicache.options({
       ...(config.cache.defaultConfig),
       enabled: config.cache.defaultConfig.enabled === 'yes'
      })
      .middleware(config.cache.expiration.productList)
    }

	deleteAll = (req, res) => {
      res.send(apicache.clear('/api/products'))
    }

}

module.exports =  createController(ProductsCache)
  .get('/api/products', 'cacheAll')
  .delete('/api/products/_cache', 'deleteAll')

I tried as a function instead of class, but it also gets called on each request. Can that behavior be changed?

Thanks, I did something similar to that. :tada:


New notebook error output item mime type doesn't render.

VS Code Version: 1.54.0-insider
OS Version: Windows 10

Steps to Reproduce:

Construct and display a NotebookCellOutputItem with a mime type of application/x.notebook.error-traceback and a value of type string.

Result:
The error text is not displayed:

Expected:
The error text should be displayed.  Note that if the mime type text/plain is substituted, then the display appears:

The .NET Interactive extension currently sets the mime type to text/plain to force it to display, but by replacing this line with the following, the display disappears:
 const metadata = { mimeType };
-const newMimeType = mimeType === interfaces.ErrorOutputMimeType ? 'text/plain' : mimeType;
+const newMimeType = mimeType; // keep it as `application/x.notebook.error-traceback`
 return new vscode.NotebookCellOutputItem(newMimeType, value, metadata);

Does this issue occur when all extensions are disabled?: N/A

As discussed offline, the output value should be { ename, evalue, traceback }


Make "No values found" warning more obvious

Refs https://github.com/adieyal/sd-dynamic-prompts/issues/609#issuecomment-1867192837

Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ff47441) 97.43% compared to head (837d490) 97.43%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   97.43%   97.43%
=======================================
  Files          77       77
  Lines        3352     3352
=======================================
  Hits         3266     3266
  Misses         86       86

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


Homebridge widget layout

The widgets for uptime, CPU and Memory are centered within the widget.
I personally think that the three Homebridge Widget icons should be centered aswell. It would look much better.
Also the widget should be renamed to "Status" or maybe "Homebridge Status" to be more correct?

Thank you for amazing ui plugin! is there any plan to add widget with free space on sd card left? because I have a situation when if there no free space on sd card then HomeKit always show all homebridge accessories like "No Response" even after cleaning sd card.


[zh] Sync kube-proxy-config.v1alpha1.md

Sync with en upstream. Mainly moved 3 sections from bottom to top.
content/zh-cn/docs/reference/config-api/kube-proxy-config.v1alpha1.md

Thanks.
/lgtm
/approve


Appstudio update test-component-pac-vkom

Pipelines as Code configuration proposal

Pipelines as Code CI/test-component-pac-vkom-on-pull-request has successfully validated your commit.

StatusDurationName

✅ Succeeded
6 seconds
init

✅ Succeeded
13 seconds
clone-repository

✅ Succeeded
26 seconds
build-container

✅ Succeeded
14 seconds
sbom-json-check

✅ Succeeded
13 seconds
deprecated-base-image-check

✅ Succeeded
13 seconds
sanity-inspect-image

✅ Succeeded
3 minutes
clair-scan

✅ Succeeded
40 seconds
clamav-scan

✅ Succeeded
6 seconds
sanity-optional-label-check

✅ Succeeded
6 seconds
sanity-label-check

✅ Succeeded
14 seconds
show-summary


By-hand setup instructions do not mention installing phantomjs

PhantomJS is needed to run Casper tests. The Ubuntu and Debian By hand setup instructions in README.dev.md does not mention installing phantomjs.
Simply installing phantomjs using apt-get is not guaranteed to work, since Zulip depends on a specific version (1.9.8) of phantomjs. The version in Ubuntu 15.10's repositories is currently 1.9.0.
According to @timabbott, probably the right solution is to factor out the code in provision.py that installs phantomjs into a script, and then call that script in provision.py as well as in the list of by-hand commands.

The script already downloads phantomjs-1.9.8 from bitbucket I think:
        PHANTOMJS_PATH = "/srv/phantomjs"
        PHANTOMJS_BASENAME = "phantomjs-1.9.8-linux-%s" % (phantomjs_arch,)
        PHANTOMJS_TARBALL_BASENAME = PHANTOMJS_BASENAME + ".tar.bz2"
        PHANTOMJS_TARBALL = os.path.join(PHANTOMJS_PATH, PHANTOMJS_TARBALL_BASENAME)
        PHANTOMJS_URL = "https://bitbucket.org/ariya/phantomjs/downloads/%s" % (PHANTOMJS_TARBALL_BASENAME,)
        sh.mkdir("-p", PHANTOMJS_PATH, **LOUD)
        if not os.path.exists(PHANTOMJS_TARBALL):
            sh.wget(PHANTOMJS_URL, output_document=PHANTOMJS_TARBALL, **LOUD)
        sh.tar("xj", directory=PHANTOMJS_PATH, file=PHANTOMJS_TARBALL, **LOUD)

provision.py installs it, but the manual install instructions don't mention installing it.


Typo in mp.Image API Reference

Description of issue (what needs changing)
No response
Clear description
In the python documentation for mp.Image, in the code sample for creation examples, lines 3,5: it is unclear which module ImageFormat belongs to. From line 11 it becomes apparent that it belongs to mp, and I propose the following change:
import cv2
cv_mat = cv2.imread(input_file)[:, :, ::-1]
-rgb_frame = mp.Image(image_format=ImageFormat.SRGB, data=cv_mat)
+rgb_frame = mp.Image(image_format=mp.ImageFormat.SRGB, data=cv_mat)
gray_frame = mp.Image(
-    image_format=ImageFormat.GRAY,
+    image_format=mp.ImageFormat.GRAY,
    data=cv2.cvtColor(cv_mat, cv2.COLOR_RGB2GRAY))

from PIL import Image
pil_img = Image.new('RGB', (60, 30), color = 'red')
image = mp.Image(
    image_format=mp.ImageFormat.SRGB, data=np.asarray(pil_img))

Correct links
https://developers.google.com/mediapipe/api/solutions/python/mp/Image
Parameters defined
No response
Returns defined
No response
Raises listed and defined
No response
Usage example
No response
Request visuals, if applicable
No response
Submit a pull request?
No response

Accidentally submitted an incomplete issue. Fixed now.

@PVTejas-Yottaasys,
Thank you for pointing it out. The typo has been fixed in our internal codebase upstream, and will be pushed to GitHub once approved.

Closing this as it has been fixed internally and changes can be seen in https://developers.google.com/mediapipe/api/solutions/python/mp/Image. Thank you


[Bug] Make an option to disable npm certificate check

Describe the bug
If npm cannot verify certificates it fails. I'd like to see an option to disable certificate checking. Because i can't run Dockerfile on my workplace.
To disable ssl check set it in npm config
npm config set strict-ssl false

To Reproduce
Just set up a proxy or vpn that will inject its own certs or something like that.
Expected behavior
...
Screenshots
npm ERR! code UNABLE_TO_VERIFY_LEAF_SIGNATURE
npm ERR! errno UNABLE_TO_VERIFY_LEAF_SIGNATURE
npm ERR! request to<EMAIL_ADDRESS>failed, reason: unable to verify the first certificate

Since I can't replicate this and haven't gotten any more details, I'm going to close it. Feel free to re-open this with more details. I just don't know what you're trying to do to get to this error.


Incorrect weather on the terminal

Hi! Thanks for the mod. I've been having some trouble with it, unfortunately.
Conditions
Multiplayer, Modded (mainly moon additions)
My friends have exactly the same configurations and mods as I do
Description of the issue
When selecting a planet in Multiplayer with apparently no weather on the terminal, the screen resume of the map show a different weather. The actual weather on the planet is the one on the screen.
Could this be caused by a lack of configuration sharing or seed sharing?

Hi! Thanks for the mod. I've been having some trouble with it, unfortunately.
Conditions
Multiplayer, Modded (mainly moon additions) My friends have exactly the same configurations and mods as I do
Description of the issue
When selecting a planet in Multiplayer with apparently no weather on the terminal, the screen resume of the map show a different weather. The actual weather on the planet is the one on the screen.
Could this be caused by a lack of configuration sharing or seed sharing?

Hi! Sorry for the delay, I had finals. I noticed this too when playing with friends for the first time yesterday and am almost positive I know what the problem is. I'll fix it for the next update which should hopefully come out tonight :)

Hi! Thanks for the mod. I've been having some trouble with it, unfortunately.
Conditions
Multiplayer, Modded (mainly moon additions) My friends have exactly the same configurations and mods as I do
Description of the issue
When selecting a planet in Multiplayer with apparently no weather on the terminal, the screen resume of the map show a different weather. The actual weather on the planet is the one on the screen.
Could this be caused by a lack of configuration sharing or seed sharing?

Hi! Sorry for the delay, I had finals. I noticed this too when playing with friends for the first time yesterday and am almost positive I know what the problem is. I'll fix it for the next update which should hopefully come out tonight :)

Best of luck for your finals! I know how tough it can be.
I'd like to add that the desynchronization happens only after the first run, that might help uncover why it doesn't refresh itself.
Furthermore, I've noticed that with the mod RandomRoutes, the entries on the monitor are duplicated. I don't know if it is relevant or not, but I thought I'd mention it.

Hi! Thanks for the mod. I've been having some trouble with it, unfortunately.
Conditions
Multiplayer, Modded (mainly moon additions) My friends have exactly the same configurations and mods as I do
Description of the issue
When selecting a planet in Multiplayer with apparently no weather on the terminal, the screen resume of the map show a different weather. The actual weather on the planet is the one on the screen.
Could this be caused by a lack of configuration sharing or seed sharing?

Hi! Sorry for the delay, I had finals. I noticed this too when playing with friends for the first time yesterday and am almost positive I know what the problem is. I'll fix it for the next update which should hopefully come out tonight :)

Best of luck for your finals! I know how tough it can be. I'd like to add that the desynchronization happens only after the first run, that might help uncover why it doesn't refresh itself.
Furthermore, I've noticed that with the mod RandomRoutes, the entries on the monitor are duplicated. I don't know if it is relevant or not, but I thought I'd mention it.

Thanks! Last one was Friday so now I just have to wait, fingers crossed! Also that luckily confirms that the weather problem was exactly what I thought it was; in the last update, I added a setting for weather names that are too long to fit, but forgot to have them update each day instead of each session. For RandomRoutes, is it just my mod you've noticed it with? I've found a couple of different problems that causes the duplicates but only one is coming from terminalplus, so I just kind of have to hide the ones caused by other mods XD

Hi! Thanks for the mod. I've been having some trouble with it, unfortunately.
Conditions
Multiplayer, Modded (mainly moon additions) My friends have exactly the same configurations and mods as I do
Description of the issue
When selecting a planet in Multiplayer with apparently no weather on the terminal, the screen resume of the map show a different weather. The actual weather on the planet is the one on the screen.
Could this be caused by a lack of configuration sharing or seed sharing?

Hi! Sorry for the delay, I had finals. I noticed this too when playing with friends for the first time yesterday and am almost positive I know what the problem is. I'll fix it for the next update which should hopefully come out tonight :)

Best of luck for your finals! I know how tough it can be. I'd like to add that the desynchronization happens only after the first run, that might help uncover why it doesn't refresh itself.
Furthermore, I've noticed that with the mod RandomRoutes, the entries on the monitor are duplicated. I don't know if it is relevant or not, but I thought I'd mention it.

Thanks! Last one was Friday so now I just have to wait, fingers crossed! Also that luckily confirms that the weather problem was exactly what I thought it was; in the last update, I added a setting for weather names that are too long to fit, but forgot to have them update each day instead of each session. For RandomRoutes, is it just my mod you've noticed it with? I've found a couple of different problems that causes the duplicates but only one is coming from terminalplus, so I just kind of have to hide the ones caused by other mods XD

I don't think I've noticed it with any other mods that I'm using, only specifically with RandomRoutes.
Happy that you can fix everything!
I hope you will get good grades haha, what are you majoring in?


Streams freezing a jittery

streams are working but seems very jittery and freeze often anyway to improve this
i have it on an 19 with nvidea 2060 super and 32 gb ram with a 1gbps fiber line i tested the website and it plays fine

What OS is your host running? Can you see which processes are spiking (ffmpeg vs streamlink)?

I'm going to consolidate to #29


Methods with @QueryParam should accept nulls

Calling this method:
@GET
@Path("/someStuff")
public void getSomeStuff(@QueryParam("limit") Integer limit);

with null as a limit argument throws a NullPointerException (calls limit.toString() in generated code)
Probably the request should be generated as
/someStuff?limit=
Or omit the parameter all together. I'm not sure if that's the right semantics, but it would be useful for optional query parameters. You wouldn't have to define a method for each combination of query parameters (just like the server-side JAX-RS method).

After playing with this a bit, it seems that the proper semantics of passing null would be to omit the parameter from the request. This way, it maps correctly to the server-side service (at least with JAX-RS).
An absent QueryParam is set to null with JAX-RS whereas an empty one results in an empty String or a bad request if the server expected anything else (an Integer for example).

Agreed. This is precisely what pull request 78 fixes:  https://github.com/chirino/resty-gwt/pull/78

Would it be in the snapshot maven repo?


Implement Keccak to support cSHAKE256 again

Either solve this by using another crate that provides Keccak or wait until the issue gets fixed for tiny-keccak. Issue

As soon as this is resolved, the cSHAKE implementation should be tested on all platforms, not only on little-endian like it is currently.

The PR for fixing the issue for tiny-keccak has unfortunately gotten very little attention, and the issue is still present.
The long term plan was to eventually replace tiny-keccak with a pure-Rust implementation that didn't use unsafe, but since I don't have time for this currently, support for cSHAKE256 will be removed until this can be done.

Before I have more free time, someone volunteers to implement this or someone specifically requests it, this won't be re-implemented for orion. Until then, I'm closing this issue. AFAIK nobody has used the CSHAKE implementation before it was removed either.


General Issue: Make subject keys flexible in all functions

Background Information
@bundfussr did a review of the admiral functions and found 2 occurrences where STUDYID and USUBJID are hardcoded instead of using get_admiral_option("subject_keys") as per https://pharmaverse.github.io/admiral/reference/#admiral-options.
These are derive_vars_atc() and create_single_dose_dataset(), for example:
derive_vars_atc <- function(dataset,
                            dataset_facm,
                            by_vars = exprs(USUBJID, CMREFID = FAREFID),
                            value_var = FASTRESC)

Definition of Done
These functions should be flexible so as if ever set_admiral_options(subject_keys = exprs(STUDYID, USUBJID2)) was set by user then these variables would be used everywhere instead of USUBJID.

@ProfessorP-beep

Yea, I can grab this.

thanks @ProfessorP-beep - please also sanity check if any functions have examples of this within the assertion checks, such as:
  assert_data_frame(
    dataset,
    required_vars = exprs(STUDYID, USUBJID, ...etc)
  )

which should be replaced by:
  assert_data_frame(
    dataset,
    required_vars = exprs(!!!get_admiral_option("subject_keys"), ...etc)
  )

Can we also please review the vignettes and templates where this is applicable? From a cursory look I found cases in:

occds vignette
higer_order vignette
admiral vignette
visit_periods vignette
bds_finding vignette
bds_tte vignette
adsl vignette
bds_exposure vignette
questionnaires vignette
pk_adnca vignette
generic vignette
adppk vignette
adlbhy template
adsl template
adcm template
adpc template
adppk template
adae template
advs template
admh template
adlb template
adex template
adeg template
adpp template

I think when it appears in roxygen2 templates that's ok as our examples should be self-contained.

@ProfessorP-beep how is this going? If you would like to hand this over please feel free, as we know you are also working on this issue

Hi @ProfessorP-beep any progress?

We have a release planned for Monday, June 3rd

@ bms63 I got all the instances that were hard coded. I just ran into an error building the package on bds_exposure.Rmd
"```
Error:
! in callr subprocess.
Caused by error in map(.x, .f, ..., .progress = .progress):
! ℹ In index: 3.
Caused by error in render_rmarkdown():
! Failed to render RMarkdown document.
✖ Quitting from lines at lines 362-373
[unnamed-chunk-22] (bds_exposure.Rmd)
Caused by error:
! in callr subprocess.
Caused by error:
! Argument enexpr(analysis_var) must be
a , but is missing.
ℹ See $stdout and $stderr for standard output and error.

  That I was looking at yesterday. Looks like its in something with  admiral::derive_param_exposure(...)

@bms63 I got all the instances that were hard coded. I just ran into an error building the package on bds_exposure.Rmd
That I was looking at yesterday. Looks like its in something with admiral::derive_param_exposure(...)
Error:
! in callr subprocess.
Caused by error in `map(.x, .f, ..., .progress = .progress)`:
! ℹ In index: 3.
Caused by error in `render_rmarkdown()`:
! Failed to render RMarkdown document.
✖ Quitting from lines at lines 362-373
  [unnamed-chunk-22] (bds_exposure.Rmd)
Caused by error:
! in callr subprocess.
Caused by error:
! Argument `enexpr(analysis_var)` must be
  a <symbol>, but is missing.
ℹ See `$stdout` and `$stderr` for standard output and error.

Maybe something is wrong with the data source?  I think there has been some updates in pharmaversesdtm?

I may have fixed it. Going to try building again.

@manciniedoardo this got a little messy and we decided to close the PR.
Could we rethink the scope of this issue?  Looking at what Ross requested - it was just for the two functions.  The vignettes and template updates seem to open a can of worms.
Could we start by updating the functions first and then create separate issues for the templates and vignettes?

@bms63  Sounds good to me.


Make axis text size depend on width

Closes #89
This only affects the tick text. Let's discuss which other text should get smaller.
Wide:

Narrow:

@matthewsmawfield This is ready for review.


change friends' deadnames?

i used mine for school and i'm kind of sick of seeing my friends' deadnames all the time. is there an option to change theirs as well?

Unfortunately there isn't currently... this could probably be done though!
In the meantime, you could even install the extension from your local files, although I'm not sure how much it could slow down your browser and how much work it might take to setup

Unfortunately there isn't currently... this could probably be done though!
In the meantime, you could even install the extension from your local files, although I'm not sure how much it could slow down your browser and how much work it might take to setup


Improve model

Many changes that start to remove hacks from the app

Sorry, this is a large, somewhat tangled PR...

@joshuawilson removed that added code

New PR #40


NPSP Settings Admin Checks Using Visualforce Component

This includes the new Visualforce component we are introducing to display insufficient permissions messaging in NPSP Settings as well as references to the component in several of the NPSP Settings pages
@danielfuller0814 is this related to W-11034270 and Known Issue - Contact Merge can exceed the Visualforce maximum view state under certain conditions?
Critical Changes
Changes
Issues Closed
Community Ideas Delivered
Features Intended for Future Release
Features for Elevate Customers
New Metadata
Deleted Metadata

I want to call out that there were several VF pages that contained duplicated admin checks in the UI. Several of the pages contained calls to UTIL_Permission to perform object-level CRUD checks. This isn't needed since the Modify All Data permission is required to view any of these pages, and this system permission automatically grants CRUD for all standard and custom objects. I've removed these access checks anywhere they were used in the UI. For more info, see https://help.salesforce.com/s/articleView?id=000321298&type=1


Adding Django-Rules to django app breaks logout endpoint, even though it doesn't use Django-rules permissions

Cross-posting from: https://github.com/dfunckt/django-rules/issues/89
This is a bit weird, and after debugging for a while, I can say that django-rules is causing this, but I am not sure how or why.
I have the following ModelViewSet in DRF that does not implement any django-rules. All endpoints work as expected with django-rules installed EXCEPT logout. Django rules is used in other apps in my django site, like writings and comments for object permissions, but the members app does not use it at all.
When someone (anyone) tries to logout, they are rejected with a 403, stating "You do not have permission to perform this action" - which is a message from the DRF permission system, however the same user is able to retrieve their user object from the /data/ endpoint, which uses the same settings for DRF permissions.

class UserViewSet(ModelViewSet):
    """
    The User endpoint for settings, authentication and anything else.
    """
    authentication_classes = DEFAULT_AUTH
    permission_classes = (IsAdminUser,)
    serializer_class = UserSerializer
    queryset = Member.objects.all()

    @action(methods=['get', 'post'], detail=False, permission_classes=[IsAuthenticated],
            serializer_class=UserSerializer, authentication_classes=[TokenAuthentication],
            url_path='data', url_name='data')
    def data(self, request):
        """
        Logged in users data retrieval + token refresh and user update endpoint.
        :param request: DRF request object
        :return: DRF Response object
        """
        if request.method == 'GET':
            data = UserSerializer(self.request.user, context=self.get_serializer_context()).data
            return Response({
                "user": data,
            }, status=HTTP_200_OK)

        if request.method == 'POST':
            serializer = self.get_serializer(request.user, data=request.data, partial=True)
            serializer.is_valid(raise_exception=True)
            user = serializer.save()
            data = UserSerializer(user, context=self.get_serializer_context()).data
            data['token'] = AuthToken.objects.create(user)
            return Response({
                "user": data,
            }, status=HTTP_200_OK)

        return Response({"message": "Unsupported action"}, status=HTTP_404_NOT_FOUND)

    @action(methods=['post'], detail=False, permission_classes=[CSRFPermission],
            serializer_class=UserRegistrationSerializer, authentication_classes=[SessionAuthentication],
            url_path='register', url_name='register')
    def register(self, request):
        """
        Accept and verify userdata, save and return user with AuthToken if valid.

        :param request: DRF request object
        :return: DRF Response object
        """
        serializer = self.get_serializer(data=request.data)
        serializer.is_valid(raise_exception=True)
        user = serializer.create(serializer.validated_data)
        data = UserSerializer(user, context=self.get_serializer_context()).data
        data['token'] = AuthToken.objects.create(user)
        return Response({
            "user": data,
        }, status=HTTP_200_OK)

    @action(methods=['post'], detail=False, permission_classes=[CSRFPermission],
            serializer_class=UserLoginSerializer, authentication_classes=[SessionAuthentication],
            url_path='login', url_name='login')
    def login(self, request):
        """
        Verify the login request and return a user object and a token if valid.

        :param request: Request object generated by Django REST Framework
        :return: user info and token when successful
        """
        serializer = self.get_serializer(data=request.data)
        serializer.is_valid(raise_exception=True)
        user = serializer.validated_data
        data = UserSerializer(user, context=self.get_serializer_context()).data
        data['token'] = AuthToken.objects.create(user)
        return Response({
            "user": data,
        }, status=HTTP_200_OK)

    @staticmethod
    @action(methods=['post'], detail=True, permission_classes=[IsAuthenticated],
            authentication_classes=[TokenAuthentication], url_path='logout', url_name='logout')
    def logout(request):
        # pylint: disable=W0212
        """
        Accept token and expire related session if valid.
        :param request: DRF request object
        :return: DRF response object
        """
        request._auth.delete()
        return Response(None, status=HTTP_204_NO_CONTENT)

If I strip rules from the other apps, this works as expected again. Put rules back in, and it breaks.
Relevant settings:

AUTHENTICATION_BACKENDS = (
    'rules.permissions.ObjectPermissionBackend',
    'django.contrib.auth.backends.ModelBackend',
)

REST_FRAMEWORK = {
    'EXCEPTION_HANDLER': 'theden_django.apps.core.exceptions.core_exception_handler',
    'NON_FIELD_ERRORS_KEY': 'error',
    'DEFAULT_PERMISSION_CLASSES': (),
    'DEFAULT_PAGINATION_CLASS': 'theden_django.apps.core.serializers.EnhancedPageNumberPagination',
    'DEFAULT_RENDERER_CLASSES': DEFAULT_RENDERER_CLASSES,
    'DEFAULT_AUTHENTICATION_CLASSES': (
        'rest_framework.authentication.SessionAuthentication',
    ),
    'PAGE_SIZE': 10,
    'DEFAULT_PARSER_CLASSES': (
        'rest_framework.parsers.JSONParser',
        'rest_framework.parsers.FormParser',
        'rest_framework.parsers.MultiPartParser',
    ),
    'DEFAULT_FILTER_BACKENDS': ('django_filters.rest_framework.DjangoFilterBackend',),
}

Apparently all this behaviour was caused by having detail=True on the action decorator, which is odd. I think I either misunderstand the use of that flag on the new action decorator from DRF, or there's a bug in DRF with this.. but setting detail=False fixes all the extra actions that were not working.


Fallback when using web proxy

When librespot is configured with --proxy it instantly falls back to "ap.spotify.com:443". http://apresolve.spotify.com/ returns 400. Strangely the proxy logs consistently list the call to http://apresolve.spotify.com/ a few milliseconds later than to ap.spotify.com:443.
Here's my configuration (using librespot dev build e064f27:
librespot.conf
--name Test
--username user
--password pass
--backend pipe
--device /var/lib/spotify
--ap-port 443
--proxy http://proxy:3128

librespot log
librespot] librespot 0.3.1 e064f27 (Built on 2021-11-20, Build ID: sPNYe7OB, Profile: release)
librespot_core::apresolve] Failed to resolve Access Point: expected value at line 1 column 1
librespot_core::apresolve] Using fallback "ap.spotify.com:443"
librespot_core::session] Connecting to AP "ap.spotify.com:443"
librespot_core::connection] Using proxy "http://proxy:3128/"
librespot_core::session] Authenticated as "user" !
librespot_playback::mixer::softmixer] Mixing with softvol and volume control: Log(60.0)
librespot_playback::convert] Converting with ditherer: tpdf
librespot_playback::audio_backend::pipe] Using pipe sink with format: S16
librespot_core::session] Country: "DE"

squid log after three restarts of librespot
# TIME                  SOURCE            REQ URL                       METHOD  RETURN DESTINATION
2021-11-20T09:30:18:330 librespot_machine ap.spotify.com:443            CONNECT 200    ap.spotify.com
2021-11-20T09:31:04:882 librespot_machine http://apresolve.spotify.com/ GET     400    apresolve.spotify.com
2021-11-20T09:31:55:575 librespot_machine ap.spotify.com:443            CONNECT 200    ap.spotify.com
2021-11-20T09:31:55:605 librespot_machine http://apresolve.spotify.com/ GET     400    apresolve.spotify.com
2021-11-20T09:47:43:952 librespot_machine ap.spotify.com:443            CONNECT 200    ap.spotify.com
2021-11-20T09:47:44:23  librespot_machine http://apresolve.spotify.com/ GET     400    apresolve.spotify.com

Could you try compiling from the new-api branch? I rewrote the access point resolver there.

No dice. Here's the librespot log:
librespot] librespot 0.2.0 7a730f3 (Built on 2021-11-21, Build ID: Kbn4TfYZ)
librespot_core::apresolve] Failed to resolve access points, using fallbacks: expected value at line 1 column 1
librespot_core::session] Connecting to AP "ap.spotify.com:443"
librespot_core::socket] Using proxy "http://proxy:3128/"
librespot_core::session] Authenticated as "user" !
librespot_playback::mixer::softmixer] Mixing with softvol and volume control: Log(60.0)
librespot_playback::convert] Converting with ditherer: tpdf
librespot_playback::audio_backend::pipe] Using pipe sink with format: S16
librespot_core::session] Country: "DE"

The call to apresolve.spotify.com is now a specific URL in squid's access.log
2021-11-21T12:35:48:142 librespot_machine ap.spotify.com:443 CONNECT 200 ap.spotify.com
2021-11-21T12:35:48:207 librespot_machine http://apresolve.spotify.com/?type=accesspoint&type=dealer&type=spclient GET 400 apresolve.spotify.com

Btw, in case it wasn't clear: Playback works fine with the fallback. I've firewalled the librespot machine so it can only communicate via proxy, no problems so far.

I don't run a proxy and don't intend to, so this is a bit hard for me to debug.
What stands out is that http://apresolve.spotify.com/?type=accesspoint&type=dealer&type=spclient returns a 400 on Squid when it obviously shouldn't. Just try to open it in your web browser --when you do so via a proxy, can you confirm it loads fine? In that case can you also show the Squid log for comparison?
Another thing I notice is the difference in format between CONNECT ap.spotify.com:443 and GET http://apresolve.spotify.com/, the former specifies a port and the latter doesn't, but specifies a protocol.
Hope this helps you to diagnose a bit further.

 My original squid configuration had "forwarded_for off" configured, which will set X-Forwarded-For to "unknown". In that case apresolve answers with "Invalid IP address provided".
I've changed the config to "forwarded_for delete" which removes the header completely and now it works:
2021-11-21T13:05:31:667 librespot_machine http://apresolve.spotify.com/?type=accesspoint&type=dealer&type=spclient GET 200 apresolve.spotify.com

The same with dev:
2021-11-21T13:08:26:519 librespot_machine http://apresolve.spotify.com/ GET 200 apresolve.spotify.com

If you want to I could add a wiki page with my working squid config.

apresolve.spotify.com doesn't accept connections with "X-Forwarded-For" in the header.

Are you sure? Not even with forwarded_for on?

If you want to I could add a wiki page with my working squid config.

:+1:

I tested it with forwarded_for on and indeed it works. That kind of defeats the purpose of an intermediary proxy server though, so I would prefer removing the header completely.
Added Behind web proxy with some more details in the wiki.
Thanks for helping me out!

Thanks for that wiki addition, great stuff.


launch.json args spiting on commas inside strings

Does this issue occur when all extensions are disabled?: Yes/No
Yes

VS Code Version: 1.67.2
OS Version: ubuntu2004/x86_64

Steps to Reproduce:

create a launch.json with "args":[
"--arg1="{'a':'a','b':'b'}" "
]
run any python file with the above configuration.
the command-line passed into the terminal is:

cd <cwd? ; /usr/bin/env /usr/bin/python3 /root/.vscode-server/extensions/ms-python.python-2022.6.2/pythonFiles/lib/python/debugpy/launcher 36981 -- some_python_file.py arg1=\"{\'a\':\'a\',\'b\':\'b\'}\"

inside the python file

import sys
print(sys.argv)

the print out will be :
["some_python_file.py", 'arg1="\'a\':\'a\'"', 'arg1="\'b\':\'b\'"']

if I replace
\"{'a':'a','b':'b'}\"

with
\"{'a':'a'-'b':'b'}\"

I get something a bit more expected:
["some_python_file.py",'arg1="{\'a\':\'a\'-\'b\':\'b\'}"'

https://github.com/microsoft/vscode/issues/150774


typo crossorigin anonymouss

Pull request checklist
Make sure you:

[X] Signed the Contributor License Agreement
[ ] Followed the commit message guidelines (not checked because of dead link)

Short description of the change(s)
This should solve the easiest issue reported in #434.
Attribute "crossorigin" doesn't have a valid value, should "anonymous" or "use-credentials": crossorigin="anonymouss"

anonymouss replaced with anonymous

Thank you, @clslgrnc!

@clslgrnc You change is now live! 🎉


Tips for favicon caching behavior

favicons love to be cached which can cause them to not show up correctly a lot of time in the dev environment, it comes up fairly consistently in the discord
This can be worked around by appending the favicon with some info specifically related to the caching
- <link rel="icon" href="/favicon.ico"

+ <link rel="icon" href="/favicon.ico?"

or

+ <link rel="icon" href="/favicon.ico?v1"

One downside to this is that users have to manually update the path every time the favicon is updated.
Another way of doing this is using an imported image, which includes cache busting hashes automatically:
---
import favicon from '../favicon.svg';
---

<link rel="icon" type="image/svg+xml" href={favicon.svg} />

Although this does not work while in dev mode, the hash is only applied when building. To get this working in dev, you can use a hack like this:
---
import favicon from '../favicon.svg'

const faviconSrc = import.meta.env.DEV
	// Prevent caching in dev with a Unix time stamp
	? `${favicon.src}?${(new Date()).valueOf()}`
	// Prevent caching in production with the default cache busting hashes
	: favicon.src
---

<link rel="icon" type="image/svg+xml" href={faviconSrc} />


use of platform cryptography

SME note expressed a preference that applications rely on validated cryptographic services from the platform rather than implementing their own. As there is no way to express a preference in an SFR, is it acceptable if this is communicated to the reader via application note?

I don't think NIAP has officially stated this preference. No action at this time.

Believe this is resolved.


Fix circle ci badge

This change is

Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable