Set NGINX_STATS_URL correctly before starting opentelemetry collector.

Do we need to do the same for @BUILD_DATE@ and @IMAGE_NAME@?

They're already set in run.sh.


FadeInUpBig Causes Funky Scroll

Animation: FadeInUpBig
Whenever I load a URL directly it is animating fine, however there appears to be a bug when you click a link to the page. It causes the scroll to get all funky and the whole page/body scrolls out of the browser and all you can see is white. If you scroll a bit it will come back though. Any thoughts on this?

Where are you experiencing this issue?

Stale issue. Closing.


After update @endcanatleast do not work

After update all my @endcanatleast statements do not work any more
All menu itemas are hidden
@canatleast(['edit.event', 'create.event'])

{{tr("b/sidebar-right.reserve-lessons","Reserve lessons")}}

@endcanatleast
@canatleast(['show.event.index'])

{{tr("b/sidebar-right.open-lessons","Open all lessons")}}

@endcanatleast

All menus are hidden, eaven for admin.

Odd. I will look into this today.
Thanks for the report!

@kaidesu So I downgraded to  caffeinated/shinobi (v3.0.5)
And all went to normal!
Huu!!
Let me know, when you are able to fix, so I can update!
Thanks a lot, for this awesome package!
Can't wait for user premision enchantment, that will be awesome!


Add developer route to refresh bindings on demand

Summary
This PR adds an endpoint /api/v1/refresh_bindings that will send a refresh_bindings websocket message to a given user.
This is especially useful during a rapid development cycle. As soon as my App is redeployed locally after some change, the App's start-up sequence can ping the Apps plugin to refresh the client's bindings.
This criteria is required for this to occur:

EnableDeveloper is enabled
The request is coming from an App
A user id is provided in url params

Ticket Link
Fixes https://mattermost.atlassian.net/browse/MM-46901

This PR will allow for quicker dev cycles during App development. Please take a look when you have the chance, it should be a quick review


chore(ci): make PR checks workflow runnable for external contributors

What this PR does / why we need it:
It's hard to accept PRs from external contributors, e.g.

https://github.com/Kong/kubernetes-ingress-controller/pull/6450

because some tests need access to secrets. They can't access them due to GH design. This PR implements the approach described in @mheap blogpost to overcome this limitation. It also makes should-run-with-secrets redundant, thus it's removed.

Which issue this PR fixes:
Fixes #3745

I think it works like that @tao12345666333

outside contributor pushes code
CI fails (lack of permission)
someone from our team carefully reviews code and re-runs CI
it passes or fails (depends on the code)

For each code change from an outside contributor for a particular PR the whole cycle repeats.
Could you confirm @mheap?

Yes, I've done it. This is why I marked it as a draft for a moment again because I overlooked it before requesting a re-review. now it's done

This seems to break workflows that rely on code changes that generate changes themselves, e.g. version bump changes like https://github.com/Kong/kubernetes-ingress-controller/pull/6472. That PR was supposed to require the CRDs to get regenerated (to get the updated version https://github.com/Kong/kubernetes-ingress-controller/blob/2869b5b319bc7f043a1a823fc28ee739bc2740f3/config/crd/bases/configuration.konghq.com_kongplugins.yaml#L6) yet it didn't because pull_request_target executes in base branch context so it didn't detect those changes.
Now all PRs fail (example: https://github.com/Kong/kubernetes-ingress-controller/actions/runs/10833024315/job/30059016588?pr=6505#step:6:43) because we need to regenerate the CRDs with new version of kubernetes-sigs/controller-tools but for some reason even if that's submitted with the PR (https://github.com/Kong/kubernetes-ingress-controller/pull/6508/commits/0dd97a88e859d1214f9c736f0ee878e6ca98ddf8) the CI executes as if the version of kubernetes-sigs/controller-tools wasn't bumped 🤔


leak in the MinimalLib?

MinimalLib gets memory hungry when iterating
using the same code without generating the smiles: https://github.com/rdkit/rdkit/blob/master/Code/MinimalLib/simple.py
import ctypes

rdk = ctypes.cdll.LoadLibrary('./librdkitcffi.dylib')
rdk.get_mol.restype = ctypes.c_void_p
rdk.free_ptr.argtypes = [ctypes.c_void_p]

for i in range(1000000):
    sz = ctypes.c_size_t()
    mol = rdk.get_mol(b'CCC(O)C(C(=O)O)C', ctypes.byref(sz), b'')
    rdk.free_ptr(mol)

Yep, that's an oversight in get_mol() and get_qmol()

Thanks for the bug report!

@greglandrum any way this can be released as a patch sooner ?
I use it extensively and from time to time it makes the UI disappear because of an out-of-memory error.

@MichelML, Since this was a patch to unreleased code, I'm guessing you're asking if it's possible to do a new build of the CFFI wrappers? I just ran one and the binaries should be available here: https://dev.azure.com/rdkit-builds/RDKit/_packaging?_a=feed&feed=rdkit_cffi

Hi Michel,
If this is a Javascript thing, have you tried calling the molecule delete method?  I had out-of-memory problems in my RDKit JS app, and that cured it:
'''
let mol = rdkit.get_mol('c1ccccc1');
// do some stuff
mol.delete();
'''
HTH,
Dave

Sorry guys it was for JS usage.
Thanks @DavidACosgrove , that's probably what I needed. I was only nullifying the mol after // do stuff thinking it would be gargabe collected automatically, but I am probably wrong.
Thanks for all the feedback to the three of you.

@MichelML As David mentioned you need to explicitly delete each C++ object calling delete on it from JS or the heap will grow indefinitely:
https://emscripten.org/docs/porting/connecting_cpp_and_javascript/embind.html#memory-management

Thanks @ptosco , Learned something today!


doc: man page is unclear of the loglevel settings

The loglevel settings entry is unclear. LOG_INFO is not accepted as setting.

LOG_INFO refers to syslog log levels.
With rsyslog, *.info is going to match it. But there are many syslog systems (not to mention systemd) with a different syntax. LOG_INFO is the name as documented in syslog(3).


⚠ Bofrost.be has degraded performance

In 85ce6d0, Bofrost.be (https://www.bofrost.be) experienced degraded performance:

HTTP code: 200
Response time: 1924 ms

Resolved: Bofrost.be performance has improved in a951d01.


Fixes broken sourcemap generation

Couldn't begin to tell you what the fundamental root cause within the CSS was, but it addresses this (improperly filed) issue:
https://github.com/gruntjs/grunt-contrib-cssmin/issues/262
Addressing:
https://github.com/AmphibiaWeb/amphibian-disease-tracker/issues/72
The fundamental source of the issue should be somewhere in here:
https://github.com/AmphibiaWeb/amphibian-disease-tracker/blob/017885915f8526d659f1023db30cfaa5e087763d/css/main.css
but it's beyond the scope of this PR to find that!

Using try-catch is a code smell to me (and it can also hides some other bugs), so let's dig into the root case. I'll try it later today.

It was an issue with CSS variables. Fixed in 3.4.14!


Missing items: [ITEMS]

Links to Cataclysm Wowhead for each item:
https://www.wowhead.com/cata/item=22559/formula-enchant-weapon-mongoose

this enchantment is missing from the sim, and it is very difficult to understand how much worse or better it will be than the new enchantments that appeared in Cataclysm Classic


Related-blogs

Not rendering the page

Not rendering the page

It should be fine now.

 I queried this using the blog id and it gave me the same blog as related.
this maybe because it uses the slug for identification

@JimmyTron could this be a backend issue? I think querying the api using id should return a 404 error response and not the blog object.

 I queried this using the blog id and it gave me the same blog as related.
this maybe because it uses the slug for identification

@JimmyTron could this be a backend issue? I think querying the api using id should return a 404 error response and not the blog object.

Seems to be a backend issue.

 I queried this using the blog id and it gave me the same blog as related.
this maybe because it uses the slug for identification

@JimmyTron could this be a backend issue? I think querying the api using id should return a 404 error response and not the blog object.

@Ase020 Since you already have the id of the blog, can you just filter it out from the results of the related blogs on the frontend?

 I queried this using the blog id and it gave me the same blog as related.
this maybe because it uses the slug for identification

@JimmyTron could this be a backend issue? I think querying the api using id should return a 404 error response and not the blog object.

@Ase020 Since you already have the id of the blog, can you just filter it out from the results of the related blogs on the frontend?

@collinskasyoki I don't understand. Can you please explain further.

Spinner Loaders

 I queried this using the blog id and it gave me the same blog as related.
this maybe because it uses the slug for identification

@JimmyTron could this be a backend issue? I think querying the api using id should return a 404 error response and not the blog object.

@Ase020 Since you already have the id of the blog, can you just filter it out from the results of the related blogs on the frontend?

@collinskasyoki I don't understand. Can you please explain further?

Use a filter and get rid of the blog matching the currently selected blog. So if we are on the blog with id 1, and another list of related blogs with ids [1, 2, 3], we can filter out 1 to remain with only 2 and 3.

It's done that way.

 I queried this using the blog id and it gave me the same blog as related.
this maybe because it uses the slug for identification

@JimmyTron could this be a backend issue? I think querying the api using id should return a 404 error response and not the blog object.

@Ase020 Since you already have the id of the blog, can you just filter it out from the results of the related blogs on the frontend?

@collinskasyoki I don't understand. Can you please explain further?

Use a filter and get rid of the blog matching the currently selected blog. So if we are on the blog with id 1, and another list of related blogs with ids [1, 2, 3], we can filter out 1 to remain with only 2 and 3.

It's done that way.

Fixed. It doesn't show up now even when accessed through id.


"unknown error while trying to generate tree shape"

Is there any way to find more information in a log or something? I'd like to be certain that it's not another mod causing this error. This happens on version 1.0.0-b36 when added to the direwolf20 1.12 pack.

Do you have a log or anything? When does this happen? On startup? When you call the generate shapes command? Why would you not give any information with your issue report - I have no context for your error message, therefore I can not help you.
Anyway, this mod is not generating that error message.

Okay this is a screenshot of the message I get and the command that I used
https://imgur.com/a/ToUdw and here is a copy of the log https://gist.github.com/it-is-I-Pants/34d9548478ad54bb7d4846ddb7822e2f


App just refuses to open

When i try to open this app it refuses to open, I'm on Windows 11.

Same Here! This is my windows 11 info.

Try to check if your user.config configuration file is correct. It is located around:
C:\Users\%YOUR_USER_NAME%\AppData\Local\iTunesRichPresence_Rewrit\iTunesRichPresence-Rewrit_Url_koerkjn2umsmbtmlnsie2yfg14mzcaei\<IP_ADDRESS>
In my case it was corrupted: half of it was filled with NULs (so, I guess, XML parser didn't like it):

If it is corrupted, replace it either from the iTunesRichPresence-Rewrite.exe.config file in the directory, where you placed iTunesRichPresence or replace it with my config:
<?xml version="1.0" encoding="utf-8"?>
<configuration>
    <configSections>
        <sectionGroup name="userSettings" type="System.Configuration.UserSettingsGroup, System, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089" >
            <section name="iTunesRichPresence_Rewrite.Properties.Settings" type="System.Configuration.ClientSettingsSection, System, Version=<IP_ADDRESS>, Culture=neutral, PublicKeyToken=b77a5c561934e089" allowExeDefinition="MachineToLocalUser" requirePermission="false" />
        </sectionGroup>
    </configSections>
    <startup>
        <supportedRuntime version="v4.0" sku=".NETFramework,Version=v4.6.1"/>
    </startup>
    <userSettings>
        <iTunesRichPresence_Rewrite.Properties.Settings>
            <setting name="RunOnStartup" serializeAs="String">
                <value>False</value>
            </setting>
            <setting name="PlayingTopLine" serializeAs="String">
                <value>%artist - %track</value>
            </setting>
            <setting name="PlayingBottomLine" serializeAs="String">
                <value>%playlist_type: %playlist_name</value>
            </setting>
            <setting name="PausedTopLine" serializeAs="String">
                <value>%artist - %track</value>
            </setting>
            <setting name="PausedBottomLine" serializeAs="String">
                <value>Paused</value>
            </setting>
            <setting name="DisplayPlaybackDuration" serializeAs="String">
                <value>True</value>
            </setting>
            <setting name="Accent" serializeAs="String">
                <value>Orange</value>
            </setting>
            <setting name="ExperimentsEnabled" serializeAs="String">
                <value>False</value>
            </setting>
            <setting name="AppName" serializeAs="String">
                <value>iTunes</value>
            </setting>
            <setting name="ClearOnPause" serializeAs="String">
                <value>False</value>
            </setting>
            <setting name="MinimizeOnStartup" serializeAs="String">
                <value>False</value>
            </setting>
        </iTunesRichPresence_Rewrite.Properties.Settings>
    </userSettings>
</configuration>

Yeah lol eventually it worked.

Closing due to iTunesRichPresence no longer being maintained.


Add version: IObit.AdvancedSystemCare version 17.5.0

Checklist for Pull Requests

[x] Have you signed the Contributor License Agreement?
[x] Is there a linked Issue?

Manifests

[x] Have you checked that there aren't other open pull requests for the same manifest update/change?
[x] This PR only modifies one (1) manifest
[x] Have you validated your manifest locally with winget validate --manifest <path>?

[x] Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Resolves #162569

Microsoft Reviewers: Open in CodeFlow

https://github.com/microsoft/winget-pkgs/issues/142854


Full Screen Mode

There is no method related to Full-screen mode. There should be button simple at the bottom right corner so you should choose whether the fullscreen mode is portrait or landscape.
Please add this functionality or it you already added it and I don't know then sorry for my mistake and Could you please tell me whether this functionality is implemented or not?

Hi @rehannali,
Right now the video player changes from portrait to landscape when the ViewController changes orientation.
If you want to force it to be in Landscape in a Portrait only app, you can set up constraints for all 4 edges and use the following code in viewDidLoad():
//videoPlayer is an instance of ASPVideoPlayer positioned within the view of a ViewController
//view is the view of the ViewController
videoPlayer.transform = CGAffineTransform(rotationAngle: .pi / 2.0)

let padding = (view.bounds.height - view.bounds.width) / 2.0

rightConstraint.constant = -padding
leftConstraint.constant = -padding
topConstraint.constant = padding
bottomConstraint.constant = padding
view.layoutIfNeeded()

Orientation and layout changes should ideally be handled by your app, this way you can create whatever layout configuration and animation transition you like.
I will probably create a button for this in the UI and provide a closure that you can use to specify your own rotation logic.

Hi @andreipitis
Actually, I want like Youtube manual rotation i.e. When I pressed a button in little screen it forced player to rotate the view in full-screen mode automatically. That's why I need this to perform custom player. If this is possible now, can you please tell me how i can do it?

There is no builtin functionality for this, but as I said in my previous comment, you can implement that functionality yourself. There is no button to tap, but you could either implement your own UI (just copy the code for ASPVideoPlayerControls and add that button, or subclass ASPBasicControls and implement your custom UI with buttons, slider, etc.), or just use some kind of gesture to start the animation.
In the future I will add a button to the existing UI, but the rotation functionality will not be performed automatically. As I said before, the users of the component should implement their own rotation/fullscreen functionality because I can't know what kind of layout everyone has and this way everyone can create the exact layout and animation that fits their needs.

Thank you for creating this wonderful library.
can you please provide the full code how to make the videoPlayer to streched all over the screen in horizontal (even tho the app is portrait only) .
the following line does work:
videoPlayer.transform = CGAffineTransform(rotationAngle: .pi / 2.0)
but how can I make it stretch all over the screen ?
the constraint part is unclear.
BTW my play is 100width and 100height, and when i click on some button i want to make it stretch all over the screen, only the stretching is my problem...
thanks in advance.

Hi @moheny,
Unfortunately without knowing your exact layout I cannot provide the specific solution for your use case.
I am assuming that you have a similar layout to this one:

In this case, the containerView has a fixed height, and has a single child that fills the entire view (the videoPlayer).
With the above layout the folowing code works:
    var isExpanded: Bool = false
    var previousConstraints: [NSLayoutConstraint] = []

    func rotate() {
        let views: [String:Any] = ["videoPlayer": videoPlayer]

        if isExpanded == false {
            UIView.animate(withDuration: 0.25, delay: 0.0, options: [], animations: {
                self.containerView.removeConstraints(self.videoPlayer.constraints)
                self.view.addSubview(self.videoPlayer)

                let padding = (self.view.bounds.height - self.view.bounds.width) / 2.0

                let metrics: [String:Any] = ["padding":padding, "negativePadding":-padding]

                self.videoPlayer.transform = CGAffineTransform(rotationAngle: .pi / 2.0)

                var constraints: [NSLayoutConstraint] = []
                constraints.append(contentsOf: NSLayoutConstraint.constraints(withVisualFormat: "H:|-(negativePadding)-[videoPlayer]-(negativePadding)-|", options: [], metrics: metrics, views: views))

                constraints.append(contentsOf: NSLayoutConstraint.constraints(withVisualFormat: "V:|-(padding)-[videoPlayer]-(padding)-|", options: [], metrics: metrics, views: views))

                self.view.addConstraints(constraints)
                self.view.layoutIfNeeded()

                self.previousConstraints = constraints
            }, completion: { finished in
                self.isExpanded = true
            })
        } else {
            UIView.animate(withDuration: 0.25, delay: 0.0, options: [], animations: {
                self.view.removeConstraints(self.previousConstraints)
                self.containerView.addSubview(self.videoPlayer)

                self.videoPlayer.transform = CGAffineTransform(rotationAngle: 0.0)

                var constraints: [NSLayoutConstraint] = []

                constraints.append(contentsOf: NSLayoutConstraint.constraints(withVisualFormat: "H:|[videoPlayer]|", options: [], metrics: nil, views: views))

                constraints.append(contentsOf: NSLayoutConstraint.constraints(withVisualFormat: "V:|[videoPlayer]|", options: [], metrics: nil, views: views))

                self.containerView.addConstraints(constraints)
                self.view.layoutIfNeeded()

                self.previousConstraints = constraints
            }, completion: { finished in
                self.isExpanded = false
            })
        }
    }

Obviously it's not the cleanest code, and there may be some better solutions to achieve this functionality depending on the layout you use. This is just a quick test that I came up with.
Basically the rotation only affects the visual representation of the player, the constraints are kept as if the player were not rotated at all. In order to get the desired result, you have to change the constraints so that the player gets centred and stretched in such a way that the height is equal to the width of the screen and the width of the player is equal to the height of the screen.
This is how the animation would look without the rotation code:

Thank you of much for taking your time and answer.
The layout you have created is the exact layout i have, and i guess my problem is I didn't remove the constraint before I have tried to change it, i'll try to play with it and update you .
BTW, I think it's easier using an library for the layout instead of writing it :-) something like snapKit it 5 times easier ..

Hey @andreipitis this post helped me a lot. Only issue I'm facing is on the iPhone X with the safe area. for some reason I cannot see why the controls I have as part of the videoPlayer do not fit within the safe area. Do you have any suggestions for this? Many thanks.

Hi @andreipitis, apologies I didn't see you reply. This works really well. However outside the safe area on your second screenshot you have a white section. I get this same section with this added code. Is there anything you would suggest for filling this bit in black without the rotation looking odd?
Also I'm getting some constraint errors when rotating. I think this is purely down to the setup of my nib.  What constraints do you have applied to theContainer View?
Many thanks :-)

@kyazdani the easiest way would be to just set the background color of the superview to black.
If that is not an option, you could add another subview with a black background in the containerView so that it is a sibling of the videoPlayer with the same constraints. Then you would simply add the same animations and constraints to that view with a slight modification: instead of setting the negative padding to be equal to -(padding - bottomPadding) you would add a new metric for negative padding with the value -padding so that it fills the entire screen.
The code for this method looks like this:
    func rotate(isExpanded: Bool) {
        let views: [String:Any] = ["videoPlayer": videoPlayer,
                                   "backgroundView": videoPlayerBackgroundView]

        var constraints: [NSLayoutConstraint] = []

        if isExpanded == false {
            self.containerView.removeConstraints(self.videoPlayer.constraints)

            self.view.addSubview(self.videoPlayerBackgroundView)
            self.view.addSubview(self.videoPlayer)
            self.videoPlayer.frame = self.containerView.frame
            self.videoPlayerBackgroundView.frame = self.containerView.frame

            let padding = (self.view.bounds.height - self.view.bounds.width) / 2.0

            var bottomPadding: CGFloat = 0

            if #available(iOS 11.0, *) {
                if self.view.safeAreaInsets != .zero {
                    bottomPadding = self.view.safeAreaInsets.bottom
                }
            }

            let metrics: [String:Any] = ["padding":padding,
                                         "negativePaddingAdjusted":-(padding - bottomPadding),
                                         "negativePadding":-padding]

            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "H:|-(negativePaddingAdjusted)-[videoPlayer]-(negativePaddingAdjusted)-|",
                                               options: [],
                                               metrics: metrics,
                                               views: views))
            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "V:|-(padding)-[videoPlayer]-(padding)-|",
                                               options: [],
                                               metrics: metrics,
                                               views: views))

            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "H:|-(negativePadding)-[backgroundView]-(negativePadding)-|",
                                               options: [],
                                               metrics: metrics,
                                               views: views))
            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "V:|-(padding)-[backgroundView]-(padding)-|",
                                               options: [],
                                               metrics: metrics,
                                               views: views))

            self.view.addConstraints(constraints)
        } else {
            self.view.removeConstraints(self.previousConstraints)

            let targetVideoPlayerFrame = self.view.convert(self.videoPlayer.frame, to: self.containerView)
            let targetVideoPlayerBackgroundViewFrame = self.view.convert(self.videoPlayerBackgroundView.frame, to: self.containerView)

            self.containerView.addSubview(self.videoPlayerBackgroundView)
            self.containerView.addSubview(self.videoPlayer)

            self.videoPlayer.frame = targetVideoPlayerFrame
            self.videoPlayerBackgroundView.frame = targetVideoPlayerBackgroundViewFrame

            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "H:|[videoPlayer]|",
                                               options: [],
                                               metrics: nil,
                                               views: views))
            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "V:|[videoPlayer]|",
                                               options: [],
                                               metrics: nil,
                                               views: views))

            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "H:|[backgroundView]|",
                                               options: [],
                                               metrics: nil,
                                               views: views))
            constraints.append(contentsOf:
                NSLayoutConstraint.constraints(withVisualFormat: "V:|[backgroundView]|",
                                               options: [],
                                               metrics: nil,
                                               views: views))

            self.containerView.addConstraints(constraints)
        }

        self.previousConstraints = constraints

        UIView.animate(withDuration: 2.25, delay: 0.0, options: [], animations: {
            self.videoPlayer.transform = isExpanded == true ? .identity : CGAffineTransform(rotationAngle: .pi / 2.0)
            self.videoPlayerBackgroundView.transform = isExpanded == true ? .identity : CGAffineTransform(rotationAngle: .pi / 2.0)

            self.view.layoutIfNeeded()
        })
    }

There are probably better/cleaner ways to do this, but this is the first thing that came to mind.
For the constraints you can check the Main.storyboard file of the example project, but it's all very simple: top, leading and trailing of the containerView to the superview are 0 and it also has a fixed height of 300 in my example.
The above code should work even if you position the containerView with an offset from the top.

Hi that's great. However the other problem presents itself with this method. How would you be able to make the video fit the full size of the phone? For example YouTube when you double tap the screen would increase the size of the video to full size but the controls would stay where they are.

With the existing implementation, you can't. You can however create your own controls, by subclassing ASPBasicControls and setting the videoPlayerControls property of ASPVideoPlayer to use your custom class.
You could pretty much copy the implementation of ASPVideoPlayerControls and adjust the layout code for iPhone X according to your needs.


Add ways to customize outer loop flow

It should be possible to customize the loop flow without rewriting it. For instance, if a user wants to store some benchmarking information between iterations, they should be able to add it into the existing loop without redefining it.
Right now we have self.custom_step() at the end of each iteration, which does the job to some extent, but obviously isn't very flexible and does not cover for many scenarios.

We have 4 main steps in the grand loop: update model, run policy (collect points), evaluate objective and update the state. Maybe an idea is to have a custom call for each one of these components instead of having just one for the entire loop.

If the only need for this at the minute is to save benchmarking information, should we have an optional ModelScorer class as part of the outer loop that does this instead? I'm imagining:
class ModelScorer:
    def score_model(self, model)
        stuff here...

I'm not convinced about the name yet, I'll keep thinking about that

No, the idea was to give more flexibility in general. At the moment however benchmarking is the only thing that comes to mind.
Implementation-wise i was thinking of something like that:
   self.loop_starting()
   while not stopping_condition.should_stop(self.loop_state):
        self.loop_iteration_started()

        self.model_updating()
        self.model_updater.update(self.loop_state)
        self.model_updated()

        self.next_points_computing()
        new_x = self.candidate_point_calculator.compute_next_points(self.loop_state)
        self.next_points_computed()

        self.objective_executing()
        results = user_function.evaluate(new_x)
        self.objective_executed()

        self.loop_state_updating()
        self.loop_state.update(results)
        self.loop_state_updated()

        self.loop_iteration_finished()

    self.loop_finished()

And when users have a loop object, they would subscribe to these events, maybe with something as simple as my_loop.loop_state_updated = my_event_handler(). And these events may have arguments too, say loop state, maybe more.
Hopefully the idea is clear, although of course this is very verbose - we don't really need that many events. Let me know what you think.

First step in this direction is implemented by @marpulli  in #53 . We will add more customization to the loop as we find use cases for it.


removed image! and replaced with .img/

Tried the UI Explorer on 0.14 stable branch, this is what i had to do to get it working

Could you actually apply this commit to a branch based on master, and send a PR to merge it into master?

Thanks for doing this! Can you please provide a "Test plan"? This would be ideally screenshots from the Movies app and each example in the UIExplorer you're changing.

@vjeux would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.

I vieux!
Forget it, it was my first PR, ill send you better ones in the near future!
Cheers
A

On 22 Mar 2016, at 18:03, Facebook Community Bot<EMAIL_ADDRESS>wrote:
@vjeux https://github.com/vjeux would you mind taking a look at this pull request? It's been a while since the last commit was reviewed.
—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub https://github.com/facebook/react-native/pull/4066#issuecomment-199907577

No worries :) Let's close it for now since it's been a while


Remove Skype for Business Server 2019 from all the 'Applies To" sub-header/section.

The Persistent Chat role isn’t applicable for Skype for Business Server 2019 as it has deprecated. However, the articles still shows the several Persistent chat related cmdlets are applicable to Skype for Business Server 2019. This is incorrect, and the users will fall into confusion. Hence, I would suggest removing Skype for Business Server 2019 from the “Applies to” section or Add the Note within the articles saying as below.
Note : The Persistent chat in Skype for Business Server 2019 is deprecated and running this cmdlet will be applicable only to Lync Server 2013 / Skype for Business Server 2015 Persistent chat in the co-existence environment.

Document Details
⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

ID: 6322fc9e-8974-bde3-20c7-19fc98040aa3
Version Independent ID: b9234665-84a1-067c-29e4-d40c32c2a79a
Content: Remove-CsPersistentChatMessage (skype)
Content Source: skype/skype-ps/skype/Remove-CsPersistentChatMessage.md
Service: skypeforbusiness-powershell
GitHub Login: @kenwith
Microsoft Alias: kenwith

@NeeranjanShettar  This is a duplicate of issue https://github.com/MicrosoftDocs/office-docs-powershell/issues/1920. I am closing this issue as a duplicate.


Add Intermediate Data Types

@hansenms Upon further analysis, I'm not sure that AcquisitionBucket needs to be a public "intermediate" type.  In the Gadgetron, the Acquisition accumulation step is always followed immediately by the "Bucket to Buffer" step, which produces the ReconData buffers, which tells me the AcquisitionBucket is a triggering implementation detail. What do you think?

OK, I made final naming changes for now. One more set of eyes then we can merge and move on.


fixing condition not to run nightly on PR

Explain your changes:
Small maintenance for CI logic. Currently after #13802 pipeline on PullRequest runs also Jobs designed to run only on Nightly. This pr is fixing this problem
Explain how you tested your changes:
Run CI
Checklist:

[ ] Dependency versions are unchanged

Notify Velocity team if dependencies must change in CI

[ ] Modified the current draft of release notes with details on what is completed or incomplete within this project
[ ] Document code purpose, how to use it

Mention expected invariants, implicit constraints

[ ] Tests were added for the new behavior

Document test purpose, significance of failures
Test names should reflect their purpose

[ ] All tests pass (CI will check this if you didn't)
[ ] Serialized types are in stable-versioned modules
[ ] Does this close issues? List them

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!ci-build-me

!approved-for-mainnet


feat: Support simple model serving

What this PR does / why we need it:
Add your description
Which issue(s) this PR is related to (optional, link to 3rd issue(s)):
Fixes #
Reference to #

Special notes for your reviewer:
/cc @your-reviewer

Release note:

NONE

/cc @gaocegege

comments are addressed, PTAL. thanks

reviewing? can merge?
otherwise, the PR will be more huge.
@gaocegege

/lgtm


Add support for multiple readers

@mlesniew not sure if you have seen the updated, so just ping-ing you here.

Hey, sorry I haven't look into this for so long.
Thanks for applying the requested changes.  There were a few additional changes I wanted to introduce before merging, but since they were simple and this PR has been waiting for so long, I went ahead and applied them myself.
I have:

squashed your work into just two commits and reworded the description
removed nargs="?" from the --site parameter specification (surprisingly setting nargs this way doesn't make it work as intuitively expected)
made some cosmetic changes to the README and the help message.

The changes are now merged into master.  You're still the author of the two commits.  I will soon release a new version with these changes and push it to PyPI.
Thanks for your contribution!


no syntax highlighting for custom user defined types/classes

Issue Type: Bug
in c++ i can create classes and structs but when i make objects out of those classes, the user defined class types are not highlighted like they are in visual studio. please fix
VS Code version: Code 1.25.1 (1dfc5e557209371715f655691b1235b6b26a06be, 2018-07-11T15:43:53.668Z)
OS version: Windows_NT x64 10.0.17134
Extensions (3)

Extension
Author (truncated)
Version

code-gnu-global
aus
0.2.2

gnuplot
mam
1.0.4

cpptools
ms-
0.17.7

Isnt this already covered in your other issue #56199?

Duplicate of #56199


feat(embed-jsx): type the elements AND return type

Types the elements and return type, so with this example:
const embed = <embed>
    <title urk="hello">Hi!</title>
</embed>;

TypeScript would know that embed is a MessageEmbed, and would error, as the prop urk is unexpected with the element title

Pull Request Test Coverage Report for Build 780739853

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 91.454%

Totals

Change from base Build 770760515:
0.0%

Covered Lines:
791

Relevant Lines:
853

💛  - Coveralls


Stuck on "GroovyLint is analyzing code"

Hello, thanks for making this extension!
I am trying to use it (and it works great on some of my files) but on two it is stuck on this message:
[{
"resource": ****,
"owner": "GroovyLint0",
"code": "GroovyLintWaiting",
"severity": 2,
"message": "GroovyLint is analyzing code...",
"source": "GroovyLint",
"startLineNumber": 1,
"startColumn": 1,
"endLineNumber": 1,
"endColumn": 1
}]
Any idea why this is happening on only some files and how I can fix it?

Same issue. Any progress?

Hello
Please can you share what you see in VsCode  tab "Output", category GrooyvLint ?

Start analyzing file:///<File_Path>/<File_Name>.groovy
Completed analyzing file:///<File_Path>/<File_Name> in 1712 ms

Same here (bit faster though):
Start analyzing file:///Users/verheyenkoen/Projects/ugent/tools/groovy-linter/script.groovy
Completed analyzing file:///Users/verheyenkoen/Projects/ugent/tools/groovy-linter/script.groovy in 332 ms

Would it be possible to share the groovy files you try to analyze so I can try to reproduce the problem locally ?

Unfortunately I am unable to share the files

I'll email you the problematic script. It was the first file I opened upon installing on a cleanly installed laptop that caused this so I figured it was an installation problem but now I've opened a few more and then it works.

thanks to @verheyenkoen 's script, I succeeded to reproduce.
The issue that that diagnostics are well sent to VsCode extension, but they are not displayed like with the other files, so the previous "fake" diagnostic saying that the lint is in progress is not replaced by the real errors
I investigate...

Fixed it in v1.9.1 :) (you'll need to reload VsCode once the patch is automatically installed)

@verheyenkoen @kjr6721 please let me know if it's now ok on your side :)
If it is, don't hesitate to rate the extension -> https://marketplace.visualstudio.com/items?itemName=NicolasVuillamy.vscode-groovy-lint

@nvuillam That fixed it for me. Great work. Thanks very much!

Thanks for your feedback:)


Database Postgres

I have one database in postgres with many schemas and I would like uses gorm.
do you think it'd be possible to change gorm so that it takes  the schemes postgres ?

You should be able to use gorm with this already.  You just need to declare your models.  You can test by using the db.HasTable(&ModelName{})

@dlundergreen Can you provide an example of this? What if there are two tables in separate schemas that share the same name? I'm not sure how to apply your answer.

I didn't understand his solution, but I use the methode TableName() now.
Example:
type  Address struct {
Id		uint64	gorm:"primary_key"
CustomerId	uint64	sql:"index:idx_addres_customerid""
Street	string
}
func (Customer) TableName() string {
return "customer.Address"
}

yes, the table name method should works.


Fix clippy error

error: using clone on a double-reference; this will copy the reference instead of cloning the inner type
--> frame/support/procedural/src/storage/print_pallet_upgrade.rs:84:4
|
84 |             impl_gen.clone()
|             ^^^^^^^^^^^^^^^^
|
= note: #[deny(clippy::clone_double_ref)] on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
help: try dereferencing it
|
84 |             &(*impl_gen).clone()
|
help: or try being explicit if you are sure, that you want to clone a reference
|
84 |             <&str>::clone(impl_gen)
|
error: using clone on a double-reference; this will copy the reference instead of cloning the inner type
--> frame/support/procedural/src/storage/print_pallet_upgrade.rs:90:4
|
90 |             use_gen.clone()
|             ^^^^^^^^^^^^^^^
error: calls to std::mem::drop with a reference instead of an owned value. Dropping a reference does nothing.

If you want to fix clippy errors, please fix them properly.
The cloning of the &str is also wrong, you should just remove the drop. Given that as you already said that we should close it, I will close this pr.

If you want to fix clippy errors, please fix them properly.
The cloning of the &str is also wrong, you should just remove the drop. Given that as you already said that we should close it, I will close this pr.

If you want to fix clippy errors, please fix them properly.
The cloning of the &str is also wrong, you should just remove the drop. Given that as you already said that we should close it, I will close this pr.

If you want to fix clippy errors, please fix them properly.
The cloning of the &str is also wrong, you should just remove the drop. Given that as you already said that we should close it, I will close this pr.


creating a demo about debugging with monai bundle configparser

Is your feature request related to a problem? Please describe.
make a demo about how to debug monai bundle configs
follow up of https://github.com/Project-MONAI/MONAI/pull/5104, two ways to enter the debug mode:

adds _debug_: true to the component in the config
run with a system MONAI_DEBUG_CONFIG flag when starting a bundle.configparser from CLI:

MONAI_DEBUG_CONFIG=1 python -m my_test_5 run --config_file=my_test_5.yaml

Hi @wyli ,
I think you can just add a section in the notebook:
https://github.com/Project-MONAI/tutorials/blob/main/bundle/get_started.ipynb
Thanks.


Segfault (double free) on drop(PxShape)

let mut material = physics.create_material(0.5, 0.5, 0.6, ()).unwrap();
let geometry = PxBoxGeometry::new(1., 1., 1.);
let flags = ShapeFlag::SceneQueryShape | ShapeFlag::SimulationShape | ShapeFlag::Visualization;
let mut shape = physics.create_shape(&geometry, &mut [&mut material], false, flags, ()).unwrap();
drop(material);
drop(shape);

This code releases material twice. Material itself is an owned pointer. And then shape releases all its materials (see line 100 below):
https://github.com/EmbarkStudios/physx-rs/blob/f0495378d0215179d73976ec3684ecb291f42ec8/physx/src/shape.rs#L96-L106
Either create_shape should consume material (i.e. &mut [Owner<Material>] instead of &mut [&mut Material]) or PxShape shouldn't release its materials on drop. I believe it's latter, but not completely sure.

Doing a bit of spring cleaning, is this still relevant? I'm a bit unsure about the issue; release is a ref-count manipulator.

Yes. If I insert this exact code into the example, it crashes.
Maybe I'm wrong about the source of the issue.
@tgolsson, are you able to reproduce this?


easier to read-Kaushal

This change will help the user to read the program with much easy .
Also the use of FOR loop have improve the run time.

it has also made the code more concise


Amazon S3 sender will copy current filepath when action is move

❗ please do not add sensitive information in issues, you can provide extra information via email using issue number as reference ❗
Describe the issue
Lets say I have a bucket with the following structure

tests/
tests/processed/

When I place an item (test.pdf) in tests and later on I'd like to move the item to tests/processed/ using the following S3 sender configuration:
                <AmazonS3Sender action="move" bucketName="${aws.s3.bucket.name}" createFolder="true"
                                accessKey="${aws.accessKey}" secretKey="${aws.secretKey}" authAlias="${aws.authAlias}">

                    <Param name="filename"      value="tests/test.pdf" />
                    <Param name="destination"   value="tests/processed" />
                </AmazonS3Sender>

It moves the file to the following location tests/processed/tests/test.pdf whilst I'd expect tests/processed/test.pdf

Reporter
Laurens
Environment
FF! 7.7.3: XX
Running on X using Apache Tomcat/9.0.72
Java Version: Java(TM) SE Runtime Environment (1.8.0_341-b10)
Heap size: 955M, total JVM memory: 2175M
Free disk space: 265GB, total disk space: 476GB
Up since: 2023-03-20 10:00:27 (19m)

No, this issue report is about 7.7 release and it costs me too much time to upgrade to test if an issue is solved in a future release.
Besides that, I can tell from the source code that the issue has been resolved in the following 7.8 backport commit:
https://github.com/ibissource/iaf/commit/e1dab5b4f67e5e105d15f7892145c78b0082e66a
I am wondering why this never ever has been backported to the 7.7 release whilst the issue is also present there..


Forecast nb

update flaml_forecast.ipynb
add benchamarking and comparing flaml to alternatives

Thanks for the contribution! While the comparison between other approaches on MAPE is interesting, I think it may be more beneficial to provide a time series plot showing the predicted graph of FLAML's model versus the ground truth, and other baselines.


GCP cleanup

there are over 1000 gcp topics (https://console.cloud.google.com/cloudpubsub/topic/list?project=o1labs-192920), all created by the integration test at some point and never cleaned up, at the moment and they should be cleaned.  i'm not sure if setting a limited message retention helps, that might be unrelated
https://github.com/MinaProtocol/mina/pull/11473/files
there are also about 50 Log Router Sinks (https://console.cloud.google.com/logs/router?project=o1labs-192920) which need to be deleted
there should be cron jobs that clean up both of those things

https://github.com/MinaProtocol/mina/pull/11473
this PR helps but still need to do a one time cleanup

no need for a cron job really.
i just ran some commands to delete everything, and the aforementioned PR should install retention time limits so they delete themselves
gcloud pubsub topics delete $(gcloud pubsub topics list --limit 400 --uri --quiet)


aiyprojects - voice - other languages - please advise when available.

Hi, answering questions regarding how to use other languages by saying your working on it https://www.raspberrypi.org/forums/viewtopic.php?f=114&t=200520
Without hassling yourselves - any idea how long it might be.

Dear Sir,
I downloaded the voice branch zip file, but I found that the files remained as old version. For example, the requirements.txt is still being "google-assistant-grpc==0.0.2", rather than "google-assistant-grpc==0.1.0" .  would you like to check the download file to see if there is any problem.

@tei-chino Make sure you're downloading the latest version of the repository. You may want to use git clone instead of downloading a zip.

Thanks for your advice.
However, I tried to use
git clone https://github.com/google/aiyprojects-raspbian.git AIY-projects-python,
but the files still are old ones ( "google-assistant-grpc==0.0.2").

Only the voicekit branch has been updated so far - the aiyprojects branch will be updated soon.

Thanks for your information.
Would you like tell me when the the image file in the voice kie site
https://aiyprojects.withgoogle.com/voice
will be updated?

We're working on it, but we don't have a date yet. We'll update this issue once it has been released.

Thanks for your rapid response. We are looking forword to the updated image.

I think that the new update allow us to interact using languages other than english, not just TTS.
I checked the source file device_helpers.py, but I could not find any language settings for my device.  Would you like to tell me how we can switch the laungauge for Assistant dialogue.

@tei-chino You have to change the language on your phone. See this issue for more details: https://github.com/googlesamples/assistant-sdk-python/issues/150

Thanks for your information.
I found the following information.
https://stackoverflow.com/questions/48017507/how-do-i-change-the-language-locale-in-the-google-assistant-sdk
I understood that becuase the AIY use the Google Assistant Library , we have to change the language in the Google Assistant settings on the phone. It is not possible to change language programmatically

Hi , I understand that for now the only solution is to change the language in the APP on smartphone ...
I own a galaxy A3 2016 (this smartphone has the requierment for the assistant APP) but the app isn't avalaible for it.  Is there any way to run the assistant app on this phone, or in emulator ? or no news about change the language programmatically ?

@Tetsuo30 If you're using assistant_grpc_demo.py or cloudspeech_demo.py you can change the language programmatically, although you won't have hotwording. https://github.com/googlesamples/assistant-sdk-python/issues/150 tracks programmatically changing the language with the Assistant Library.

@Tetsuo30 If you upgrade your smartphone's OS to Android 6.0, maybe you can install the Assistant App to your smartphone.

Hi, before opening a new issue,
I want to know if you have a solution:
I change the language to french and now, to activate the Google assistant, i have to speak at 10cm from the mic or to yell...

@blandiant That sounds like an issue in the Assistant Library. If it hasn't already been reported here: https://github.com/googlesamples/assistant-sdk-python/issues then that is the place to report it.

Sorry but when I try to change language with the assistant_grpc_demo.py, it doesn't work .
I try this in the terminal : assistant_grpc_demo.py -- lang fr-FR but no effect ... maybe I'm wrong , but can't find how to do this ...

@Tetsuo30 You need to add aiy.i18n.set_language_code('fr-FR') to the demo file.

Yes thx, I tried this code in the assistant_library_demo.py but forgot to try it in the grpc_demo.py.  It works,. But now, when asking something ...the sound stop in the middle of the response ... after 3 or 4 seconds ...

I have the same pb as Tetsuo30.
Putting the locale code 'fr-FR' is working for recognizing but for the response it's truncated.
Removing the regional setting back to EN then everything works fine.
Dumping the audio data, at the end thre was a lot of "0x00". Some limitation from google ?

Hi Ihvo, try the code from Protovist in this post...it works for me ... The only issue for me now, is that I can't adjust the volume with the GRPC demo ... Impossible with the GUI or with the voice... when asking what's the volume the answer is always 50%, and can't lower it


Configure Azure Pipelines Code workflow

This pipeline configuration builds the application and produces a build for the Release configuration.

 Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.:x: georgestevens99 sign nowYou have signed the CLA already but the status is still pending? Let us recheck it.


add runtimeclass option for nimcache

Hi ,
can help to add runtimeclass on the nimcache and all others crd ?
got this error
Traceback (most recent call last):
File "/usr/local/bin/download-to-cache", line 5, in
from vllm_nvext.hub.pre_download import download_to_cache
File "/usr/local/lib/python3.10/dist-packages/vllm_nvext/hub/pre_download.py", line 20, in
from vllm_nvext.hub.ngc_injector import get_optimal_manifest_config
File "/usr/local/lib/python3.10/dist-packages/vllm_nvext/hub/ngc_injector.py", line 22, in
from vllm.engine.arg_utils import AsyncEngineArgs
File "/usr/local/lib/python3.10/dist-packages/vllm/init.py", line 3, in
from vllm.engine.arg_utils import AsyncEngineArgs, EngineArgs
File "/usr/local/lib/python3.10/dist-packages/vllm/engine/arg_utils.py", line 6, in
from vllm.config import (CacheConfig, DecodingConfig, DeviceConfig,
File "/usr/local/lib/python3.10/dist-packages/vllm/config.py", line 12, in
from vllm.model_executor.layers.quantization import QUANTIZATION_METHODS
File "/usr/local/lib/python3.10/dist-packages/vllm/model_executor/layers/quantization/init.py", line 3, in
from vllm.model_executor.layers.quantization.aqlm import AQLMConfig
File "/usr/local/lib/python3.10/dist-packages/vllm/model_executor/layers/quantization/aqlm.py", line 11, in
from vllm._C import ops
ImportError: libcuda.so.1: cannot open shared object file: No such file or directory

i add this line and rebuild the nim-operator, and it works

this happened also on nimservices kubectl patch deployment meta-llama3-8b-instruct --type='merge' -p='{"spec": {"template": {"spec": {"runtimeClassName": "nvidia"}}}}' -n nim

Thanks for the suggestion. We'll add it to our backlog. In the meantime, recommend adding webhooks to add runtimeclass.

Can i use the patch command for NIMCACHE ?

@jxdn thanks for catching this. We didn't hit this error as nvidia was configured as a default runtime with the gpu-operator. Will include this in the next patch.

This PR should fix for NIM Service deployments. For caching, we should not need to specify "nvidia" runtime class as that Job can be run on a non-gpu node. For the issue reported the fix should be in download-to-cache NIM tool which is loading cuda libs unnecessarily. Going to request to fix that instead.


Fix request batching not chunking the items of the operation

Change-type: patch
See: #1257
Signed-off-by: Thodoris Greasidis<EMAIL_ADDRESS>
Resolves: #
HQ:
See:
Depends-on:
Change-type: major|minor|patch

Contributor checklist

[ ] Includes tests
[ ] Includes typings
[ ] Includes updated documentation
[ ] Includes updated build output

@balena-ci I self-certify!


Update ism330dhcx_spi.c

fix ism330dhcx spi passing correct handle to ctx

Hello, can I check if this fix was tested with the actual sensor? I pulled the commit and ran into the following problem. Before I also had a ticket with the Noridic Dev Zone with not being able to work with the ISM330DHCX via SPI.
When i enable logging, this is the error.
`[00:00:00.250,488]  ISM330DHCX: chip id 0x0, chip id should be 0x6b
[00:00:00.250,518]  ISM330DHCX: ism330dhcx_init_chip: Invalid chip id 0x0
[00:00:00.250,549]  ISM330DHCX: ism330dhcx_init: failed to initialize chip
*** Booting Zephyr OS build v3.2.99-ncs2 ***
[00:00:00.250,640]  basic_IMU: Error: Device "ism330dhcx@0" is not ready; check the driver initialization logs for errors.
[00:00:00.250,640]  basic_IMU: Unable to retrieve IMU`

Hello, may i check if you were able to run SPI with the actual ISM330DHCX sensor? I've been facing problems trying to get the sensor to work with Zephy from a few days, and have raised a ticket here in the Noridc Dev Zone.
I faced this issue after pulling this fix
[00:00:00.250,488] <inf> ISM330DHCX: chip id 0x0, chip id should be 0x6b
[00:00:00.250,518] <dbg> ISM330DHCX: ism330dhcx_init_chip: Invalid chip id 0x0
[00:00:00.250,549] <dbg> ISM330DHCX: ism330dhcx_init: failed to initialize chip
*** Booting Zephyr OS build v3.2.99-ncs2 ***
[00:00:00.250,640] <inf> basic_IMU: Error: Device "ism330dhcx@0" is not ready; check the driver initialization logs for errors.

[00:00:00.250,640] <inf> basic_IMU: Unable to retrieve IMU

Are there any possible reasons why I could be running into this issue? Is it mainly a Zephyr Issue? I have rules out any electrical reasons, and was able to work with SPI using the same sensor on another framework(Arduino IDE)

Good catch! Thanks

my bad, didn't read the guidelines on commit formatting before pushing the PR so the CI failed.
is there a way to fix the comment in the previous commit or should I make a new PR? (sorry, I'm quite a noob contributing to large projects)
thanks for the help

Good catch! Thanks

my bad, didn't read the guidelines on commit formatting before pushing the PR so the CI failed. is there a way to fix the comment in the previous commit or should I make a new PR? (sorry, I'm quite a noob contributing to large projects)
thanks for the help

Usually I do changes locally and git push -f on the same branch.

[00:00:00.250,488]  ISM330DHCX: chip id 0x0, chip id should be 0x6b

I see the same behaviour on my end too.

Hello, may i check if you were able to run SPI with the actual ISM330DHCX sensor? I've been facing problems trying to get the sensor to work with Zephy from a few days, and have raised a ticket here in the Noridc Dev Zone.
I faced this issue after pulling this fix
[00:00:00.250,488] <inf> ISM330DHCX: chip id 0x0, chip id should be 0x6b
[00:00:00.250,518] <dbg> ISM330DHCX: ism330dhcx_init_chip: Invalid chip id 0x0
[00:00:00.250,549] <dbg> ISM330DHCX: ism330dhcx_init: failed to initialize chip
*** Booting Zephyr OS build v3.2.99-ncs2 ***
[00:00:00.250,640] <inf> basic_IMU: Error: Device "ism330dhcx@0" is not ready; check the driver initialization logs for errors.

[00:00:00.250,640] <inf> basic_IMU: Unable to retrieve IMU

Are there any possible reasons why I could be running into this issue? Is it mainly a Zephyr Issue? I have rules out any electrical reasons, and was able to work with SPI using the same sensor on another framework(Arduino IDE)

You mean that before this fix you had ism330dhcx working on spi and after it you had not? Should be the opposite... Please provide more info

@avisconti Not the OP commentor, but am facing a similar issue. Am on Zephyr 3.2 release and using the module with the SPI bus. Prior to the suggested fix, the application would crash, since an illegal pointer was being passed around. With the fix suggested, the SPI could initialise, but I see the reply for the version via the SPI bus is 0.

@avisconti Apologies for not being clearer.
My environment is nRF Connect SDK v2.3.0, which is based on Zephyr. Without this fix, as @dipakgmx mentioned, the program would crash before the main stage.
[00:00:00.376,464] <err> os: ***** BUS FAULT *****
[00:00:00.376,495] <err> os: Precise data bus error
[00:00:00.376,495] <err> os: BFAR Address: 0xff4672b5
[00:00:00.376,525] <err> os: r0/a1: 0x00005285 r1/a2: 0x00000010 r2/a3: 0xff4672b5
[00:00:00.376,525] <err> os: r3/a4: 0x2000286c r12/ip: 0x20002884 r14/lr: 0x0000d71b
[00:00:00.376,556] <err> os: xpsr: 0x01000000
[00:00:00.376,556] <err> os: Faulting instruction address (r15/pc): 0x0000d6be
[00:00:00.376,586] <err> os: >>> ZEPHYR FATAL ERROR 0: CPU exception on CPU 0
[00:00:00.376,617] <err> os: Current thread: 0x200008d0 (main)

This was due to a specific line in the ism330dhcx_spi.c file that is fixed by this pull request.
C:/ncs/v2.3.0/zephyr/drivers/sensor/ism330dhcx/ism330dhcx_spi.c:57

With this pull request, the problem appears to be fixed. However, when trying to use the actual ISM330DHCX sensor, the driver does not appear to detect that it is the correct sensor.
#define IMU0_NODE DT_NODELABEL(imu_1)
static const struct device *get_ism_device(void)
{
	const struct device *const dev = DEVICE_DT_GET(IMU0_NODE);

	if (dev == NULL) {
		LOG_ERR("\nError: no device found.\n");
		return NULL;
	}

	if (!device_is_ready(dev)) {
		LOG_ERR("\nError: Device \"%s\" is not ready; "
		       "check the driver initialization logs for errors.\n",
		       dev->name);
		return NULL;
	}
}

This leads to the error mentioned above. With some debugging, it seems that the chip id that is returned is not what the driver expects.
[00:00:00.250,488] <inf> ISM330DHCX: chip id 0x0, chip id should be 0x6b
[00:00:00.250,518] <dbg> ISM330DHCX: ism330dhcx_init_chip: Invalid chip id 0x0

It seems to arise from the ism330dhcx.c file and the driver is unable to read the sensor properly.

Please address the failed compliance check:
Error: Merge commits not allowed, rebase instead

Hi @cooked  -- are you able to fix your branch by removing the merge commits which shouldn't be there? It's perfectly fine to force push your amended commits to your PR branch.


Trace folding in vscode

Component
Forge
Describe the feature you would like
Trace folding
Format the traces in a format that vscode automatically recognises as collapsable. This way I could fold setup trace and only see the test function trace when I copy the trace to a file and open in vscode.
One option would be to use tabs instead of │   │ Vscode folds tabs automatically, but not the current │   │ format.

PS: It's easy to replace  │   │ with tabs manually, so this issue can be a reference for other people who look for this feature.
Additional context
No response

Just switching to tabs would make traces hard to read, so I don't think we should do this, especially since like you said it's easy to make the change manually when needed.
As part of #4440 we'd like to makes traces interactive, which includes being able to collapse them, so I'm going to close this in favor of that 🙂

+1 for this feature


Manual addition of column names to scripts

Need to identify a way to automatically read the new columns for

plotting - avoid using column numbers in plotting
descriptions  - have a separate file that checks and asks for a description in each build to be written to a json file
json files for technologies and categories - avoid the use of each word capitalization but ask separately to confirm the column names to display and write it to a json file required

Still a concern, but not a major one. Hence closing.

Still a concern, but not a major one. Hence closing.


Having lighter bundle alongside catching libraries in separated bundle file(s).

After many searches and studying a lot of ReactJS starters, I find out this Starter is awesome and scalable. but I have some questions/sights about bundling.
I implemented a starter and when I run yarn build in my starter, these files are  built:

server.js: a bundled file just for the node in the server-side
vendor.js: a vendor bundle that contains react, react-dom, redux, ... and etc.
client.js: a bundle file that contains just the application code.

Number One: in the react-cool-starter the ts-node read the server.tsx at the production moment and there isn't a bundled file for running codes from the node server.

suggestion: It could be better we have a server-side bundle that contains the whole application, so it will be clean JavaScript and there is no need to have ts-node in server and it will be easier to have pm2 for large scale projects

Number Two: It could be awesome, that we have a bundle that contains the libraries which we used in our project, we could use service worker to cache until the next version, when we have the next version? _when we update or add/remove packages. Even we can split the vendor.js file to several files, but still, all of them should be cached until the next version. this way could help us to have a lighter bundle of application because the application continuously is changing but the vendor changes happen over time.
Number three: by describing number two, this part became obvious. now with the decoupled application codes from vendors, we have a very light application bundle. and it will be great. because when we develop new features the application bundles will update in client service worker but the vendors remain and user have a better experience in interacting with the website.
So, Dear @wellyshen, what's your opinion about these concepts? Are you agreed, if yes I'm ready to make some critical changes to have these concepts in react-cool-starter.

@amerllica Please hold on I'm planning to migrate to Webpack v6, React-Refresh etc. I think they will have big impact to the configuration. So please hold on.

Dear Bro @Wellyshen, now you wanna keep open this issue?

@amerllica We can keep it for reference.

Dear bro @wellyshen, the Webpack version is now on 5 beta according to this link. but you said:

I'm planning to migrate to Webpack v6, React-Refresh etc. I think they will have big impact to the configuration.

It's my first question.
And also I wanna work on changing build scenario, if you don't have time right now, may I work on this current issue and send PR?

@amerllica I'm not sure if we need to do it at this phase because it's still in beta and I'm also concerning the compatibility of related Webpack plugins, how do you think about that?

@wellyshen, Dude, It's my bad describing, actually I have two questions:

Why did you say webpack v6? we even don't need version 5 and exactly right, compatibility may be the main issue.
May I work on this enhancement issue? I wanna use webpack-hot-server-middleware and webpack-hot-middleware to make a separated build file for the server and decouple vendor from app

@amerllica Sorry for typo I mean the v5. Sure, go ahead for your idea. If you can give me a minimal POC, I can better to understand it.


Fix vscode procol being converted to url

closes #564

Thank you! I really appreciate all of your fixes lately.


Rename to scrapy-splash?

What do you think about renaming this project to scrapy-splash to follow the standard naming convention of scrapy plugins?
In the past, we had another scrapy-splash repository (that could conflict with this) but that is now gone and removed for good.

+1 to scrapy-splash but may be scrapy-javascript we ever plan to have other backends

@kmike will correct me if I'm wrong but I don't think supporting other backends was ever the goal of this package.

I'm fine with it.

I renamed the github repo. hey! it is a start :golf:

Fixed!


image: Change the permissions for image

Change the group ownership for /usr/share/kata-containers
dir to kvm and allow this group to read, write to the image.
This is to help running rootless containers for users
that are part of the kvm group.
Fixes #855
Signed-off-by: Archana Shinde<EMAIL_ADDRESS>

@egernst @jcvenegas @jodh-intel Please take a look.
As I am no packaging expert, I would like someone with packaging knowlege to review this and let me know if this looks ok.

hmm, yeah, this will probably need some input and thought...

is it OK to let Kata create the kvm group if it does not already exist
I'm sort of presuming this would be the right thing to do for all current kata supported hypervisors (that all currently utilise kvm underneath I think).

/cc @devimc - for any input on the snap packaging side
/cc lsm5, c3d for views from the fedora side etc.

@lsm5 @c3d

That relies on the meaning of the group kvm being consistent across distros.
Are you sure you don't want to have a dedicated group for that, e.g. kata? Upside: you can select different policies for "normal" VMs and for container VMs. Downside: you need to manage two groups.

I am planning to close this PR. Plan is to instead pursue this on the qemu mailing list to support files without write access to be allowed to be used as memory backends.


add testcert option for nginx container

option to have testcert in case of ratelimit to debug with
flist: https://hub.grid.tf/waleedhammam.3bot/waleedhammam-nginx-certbot-latest.flist
PRs:https://github.com/threefoldtech/js-sdk/pull/497
https://github.com/threefoldtech/tf-images/pull/16
Usage: just pass test_cert=True in expose_and_create_certificate method

Commit_ID 0b5ca86c064b5115f09eb0f01775e7dd479ba31d , Branch development_capacitypool


bpf: nat: Make snat_v6_needed() get on par with snat_v4_prepare_state()

We recently implemented snat_v6_needed() in the datapath to determine whether we need SNAT for IPv6 masquerading; but the function was written long before it was merged and was based on snat_v4_needed(), which has since been consolidated and renamed as snat_v4_prepare_state(), and changed again to prepare for Egress Gateway.
This PR aims at bringing snat_v6_needed() as close to snat_v4_prepare_state() as possible.
Commits:

bpf: nat: Move check on dest being outside cluster in snat_v6_needed()
bpf: nat: Pass target directly to snat_v6_needed()
bpf: nat: Rename snat_v6_needed() into snat_v6_prepare_state()

bpf: Update IPv6 BPF masquerading code to bring it closer to IPv4's

/test

Is this really a kind/feature? What user-facing impact is there for this change?
At first I was a bit alarmed that a feature was being proposed two days before feature freeze, and still marked as draft the day before. But looking at the size of the change, the release note descrption, and the fact it's marked as release-note/misc, now I think maybe it's not actually a feature, just a nice-to-have code cleanup?
If you can get this into the tree tomorrow in coordination with the relevant code owners then I don't mind, but the window is starting to close on PR proposals for 1.14. We will be moving to a lower-churn phase of development shortly and at that point we'll be scrutinizing each change a bit more closely to determine whether it really matters to merge this ~now in time for 1.14 or in a couple of weeks' time (for 1.15 dev cycle).

Thanks @joestringer for your comment and explanations! Yes, I'm aware of the feature freeze and lower churn phase. Our current labels don't allow us to make the distinction between “we absolutely need this for the release”, and “this is maybe not essential, but important enough that I would like some careful consideration on whether we should include this, and not let it slip unnoticed”. This PR would fall into the second category, I'd say.
I do believe it's an enhancement worth having, as it would bring IPv4 and IPv6 paths closer and make it easier to maintain in the future.
One additional consideration is that I'm not currently sure of whether the check on local_ep in the PR should be moved outside of the #ifdef ENABLE_MASQUERADE_IPV6, like the PR currently does (and like we do on the IPv4 path); I'm trying to understand if we need this and what the consequences are, and whether this is a bug or not in the current version of the code that we would address by merging this - but then, if there's a bug, we'll backport anyway. This is why this PR is still in draft status, by the way.

/test

/test

/test

:wave: thanks! Not sure I will manage to get in a proper review today, but some notes:

when called with IS_BPF_OVERLAY, do we need a matching case for the SNAT with IPV4_GATEWAY? Looks like this is ROUTER_IP in the IPv6 world.
it's a bit suspicious that we don't need to set target->from_local_endpoint. Did we miss to update snat_v6_nat_can_skip() ?

* when called with `IS_BPF_OVERLAY`, do we need a matching case for the SNAT with `IPV4_GATEWAY`? Looks like this is `ROUTER_IP` in the IPv6 world.

Yes, I think you're right. Otherwise we won't have the gateway/router IP when leaving through the tunnel. I've added a commit to fix this.

* it's a bit suspicious that we don't need to set `target->from_local_endpoint`. Did we miss to update `snat_v6_nat_can_skip()` ?

It is. And yes you're right again, I think this is because the IPv6 masquerading PR didn't pick up the update in that function. I've also added a commit to fix this.
Thanks a lot for the preliminary comments, I'm looking forward to the review :smile:

Looks like I messed up when reordering commits, and I've got one that doesn't compile. I'll try to fix this in the evening.

[EDIT: Cleared it out with Gilberto, there's no bug, and we don't need this code to move outside of the #ifdef guard, so all is good.]

Given the fixes mentioned above, I'll change the type for this PR to kind/bug.

I'm a bit confused. This is a refactor to align code right? The release note and release note label don't indicate anything about a bug being fixed.
At this point I'm willing to ship this PR in v1.14 if it lands before I branch (some time in the next few days), but I think we should remove the release-blocker label. It's not obvious to me that it's making sufficient ongoing progress to guarantee it lands in time, and it's about time we consider v1.14 development done and move on. If it turns out that this is still a bugfix and it doesn't land before branching, then we can make a call about whether to prepare+backport a more targeted fix or backport this PR when it's ready.

Is this again for v4-only? :/

I thought so, because I only found IPV4_INTER_CLUSTER_SNAT and no IPv6 equivalent, plus I couldn't find where ENABLE_CLUSTER_AWARE_ADDRESSING and ENABLE_INTER_CLUSTER_SNAT were being set at first. But looking again, the IPv6 version was maybe missing only because IPv6 BPF masquerading was not here.
@YutaroHayakawa Could you please take a look and comment? Do we need the IPv6 equivalent to the IPv4 snippet quoted by Daniel now that we have IPv6 masquerading?


[Issue]: How does one build rocm-examples/HIP-Basic/assembly_to_executable for Windows?

Problem Description
I have installed HIP/ROCm 5.7.1 for Windows on Windows 10.  I have also installed make for Windows using winget.  However, I cannot build the assembly_to_executable example code under Windows 10.  I have tried modifying the Makefile to address the Windows-specific paths, etc.  I have also changed it to use hip_obj_gen_win.mcin.  However, even with these changes, it does not build cleanly.  The last error I received was the linker complaining that the format of main_device.o was unknown.
I have compiled the unchanged example code under Ubunto 22.04 and it builds and runs perfectly.
Can someone please provide the changes needed to build and run this example under Windows 10?
Thank you!
Operating System
Windows 10
CPU
AMD Threadripper with dual AMD graphics cards (6800 & 7900)
GPU
AMD Radeon Pro W6800, AMD Radeon RX 7900 XTX
ROCm Version
ROCm 5.7.1
ROCm Component
No response
Steps to Reproduce
No response
(Optional for Linux users) Output of /opt/rocm/bin/rocminfo --support
No response
Additional Information
No response

Hi, @Snektron!  Thank you for your reply.  I was able to get it to work by changing the -triple argument to "x86_64-pc-windows-msvc".  Where are these documented?

As described in the readme of the assembly_to_executable example, the offload bundle requires an empty entry for the host. This takes the form of host-<isa>-<vendor>-<os>-<abi>. For linux this is host-x86_64-unknown-linux-gnu, and for windows host-x86_64-pc-windows-msvc. Exactly how this works with the offload bundler is described on the clang offload bundler documentation page. This combination of parameters is generally called a target triple, and its documented on the clang cross compilation documentation page.


Multiple copies of icon appear at startup, issue seems to be fixed later

Oops, this is the same as #21


Search bar is needed at navigation bar

Hi @kanishak11-cyber, I'll be creating an Issue template for the repositories by tomorrow. I am closing this as of now.


Sequence fetch/asyncData for nested route pages

In a nested parent / child page relationship (using <nuxt-child />), it would be ideal if the parent's fetch/asyncData functions ran before the children. Currently, they all seem to fire at once (even if async/await is used).  Please correct me if I am wrong here.
For example, in the routing docs, we'd want category to complete its fetch before subCategory ran its fetch.  That would make the parent category data available to the subCategory (eg. via the store).
Without this sequence, if you deep link to the subCategory, the parent category data may not have been set yet; preventing route checks that depend on that parent data, and/or the ability to append more granular data (unless dummy placeholders are added to the store).  This essentially requires the subCategory to load the category data as part of the fetch; which results in the same data being loaded twice (once for the category and once for the subCategory).
Thoughts?

I was able to adjust the promise logic in the core files (client.js and server.js) found in node_modules/nuxt/lib/app which seem responsible for this, so far I couldn't see any side-effects.
Attached are the two files if you'd like to test it as well.
Archive.zip
Maybe someone from the core team can evaluate if this impacts some other part of the framework?

With this modification, how can we still run them in parallel?

Perhaps this sequential loading could be an opt-in option in nuxt.config in order to preserve the current behaviour. So far I have done this only for myself, once there is some feedback about this approach I can do a pull request for this feature.

How about you pass the promise of the mother page into the daughter page's method instead?
Then you can await it if you need, and ignore it if you don't.
Seems over 9 gorillion % more flexible than enabling it in global config.
You could even start some independent async shenanigans first, then await and do the rest.

I think of it somewhat how async.js does, in that there are multiple options to choose from.  What I am proposing for, would be described as "series":

Run the functions in the tasks collection in series, each one running once the previous function has completed. If any functions in the series pass an error to its callback, no more functions are run, and callback is immediately called with the value of the error. Otherwise, callback receives an array of results when tasks have completed.

Maybe Nuxt could one day support many options, but having "series" and "parallel" (default) would be a great start.
Per config, it'd be great if this could be set at the root page level.  You may not want the same behavior throughout the app.  If we borrow the async.js vocabulary, then we could add a "controlFlow" property on the page.  Example:
export default {
  controlFlow: 'series',
  fetch (context) {
    ...
  }
}

@qm3ster in async.js terminology, I believe that would be the "compose" option.

@bjunc pretty much, except unlike in the callback case, it would be almost literally childPageFetch(parentPageFetch()), wherein parentPageFetch() returns a Promise.
This way, every child decides when and if it cares about the parent Page's completion.
It can even depend on their params.

@qm3ster Works for me.  Is the idea that we'd assign the parent's promise to context as to not break backwards compatibility?  Any proposed attr names? context.parentPromise?

context is shared between the child and the parent IIRC, so that's way too globalicious.
I was thinking a second argument.
Whether that should be a stack of promises all the way up or just the immediate parent is a good question. (what do we do in the possibly very rare case of a grandchild wanting to wait for the top page?)

Smells a bit over-engineered.  If you run the page fetches in series, then the grandchild will have access to the parent and grandparent's data (assuming you assign to the store upon responses).
I'll run a test by using async.js for now, and see if it does what I'm looking for.  I'll report back.
Current thought is to modify nuxt/lib/app/server.js at line 63:
const beforeRender = async () => {
  // Call beforeNuxtRender() methods
  if (Components[0].options.controlFlow === 'series') {
    // TODO: fetch page data in series
  } else {
    // default: parallel
    await Promise.all(ssrContext.beforeRenderFns.map((fn) => promisify(fn, { Components, nuxtState: ssrContext.nuxt })))
  }
}

@bjunc if the child wants the grandparent's data, but the paren't returned without awaiting the grandparent, the child has nothing to await.

EASILY solved by the user by awaiting the grandparent at the end of the parent. But still more to write (for the user) than in my case.
I guess I'll try implementing my way.

HILARIOUS idea: what if we also give fetch and asyncData each other's promises?
That way they can rely on each other.
And bad users can then cause deadlocks by awaiting them both!
Amazing, if I do say so myself!

@ndamjan the logic you posted worked for me.  To @qm3ster's point, it replaces the parallel logic, so we'd need a switch for parallel vs series.  I was able use an option on the root page component to trigger series vs parallel (used controlFlow: 'series' as per above).  It's basically an if statement, so let asyncDatas needs to be set outside to allow for access in the later debug and ssrContext.nuxt.data = asyncDatas.map logic.
I think the logic could be cleaned up a bit, but overall heading in the direction I was hoping for.  Maybe use reduce instead of forEach?

I don't understand the advantage of this method. It just makes it too easy to damage performance, in addition to being inflexible. Promises are simple to add, we already have the source of the promises in the code.

I think that's a dramatized critique.  The phrase "damage to performance" implies unintentional consequence, when in-fact it's by design in order to accomplish the functional goal.  The whole point is to wait for the parent to load its data before the child starts loading theirs.  The worst performance is what we have now – as I can't wait for the parent to finish, so I have to redundantly load the data twice (once in the parent, and once in the child).
The "inflexibility" part doesn't make sense to me either, as you're not proposing a scenario that neither the current (parallel) or new (series) logic would accommodate.
All that said, I'll try your technique now that the first one has been prototyped and deemed feasible.  It's not immediately clear how the promises should be keyed, but I'll think that through.  Maybe their component names, but those can get pretty long.  Anyway, I'll take a stab at it, and report back.

Okay, so I hacked together the alternate method (Option B).  I added an app.context.fetchStack array.  The array consists of objects that use the following structure:
[
  {
    component: 'pages/grandparents/_grandparentId.vue',
    asyncData: null,
    fetch: null
  },
  {
    component: 'pages/grandparents/_grandparentId/parents/_parentId.vue',
    asyncData: null,
    fetch: null
  },
  {
    component: 'pages/grandparents/_grandparentId/parents/_parentId/children/_childId.vue',
    asyncData: null,
    fetch: null
  },
]

To await an ancestor's fetch method:
// _childId.vue
export default {
  fetch ({ fetchStack, params }) {
    let parent = fetchStack.find(x => x.component === 'pages/grandparents/_grandparentId/parents/_parentId.vue')
    await parent.fetch

    // Check if parent has children matching `childId`
    // No: error 404
    // Yes: fetch full child data
  }
}

Option A (setting series vs parallel for the whole stack) is cleaner in that you don't need to explicitly await in a child page.  My guess is that more often than not, where you need to await an ancestor, you probably want to await all ancestors.
Option B is potentially more performant in situations where an ancestor's page is not needed, so you can be more granular / selective with your series vs parallel in exchange for being more explicit in your code.
@qm3ster I think I know which option you prefer :)
Anyone else want to weigh in before I start hardening the logic?

@bjunc I was thinking about the same structure :)

My guess is that more often than not, where you need to await an ancestor, you probably want to await all ancestors.

To support above statement which I agree with as well, I propose we make it easier to do the series use case by having all of the ancestor promises also delivered additionally as a single promise.
In this case, the fetchStack would have an object with details (the structure from previous post which you can use to await on a specific grandparent) and another ancestorDataFetch promise which contains all of the promises from all ancestors.
Then in the child component we can simply do
fetch ({ fetchStack, params }) {
  await fetchStack.ancestorDataFetch
  // now all data is here...
}

We will need to implement this in all of the ancestors in order to get the series effect, but this kind of approach makes it explicit.

And what happens when you navigate to the context.fetchStack when you navigate to the next page? It's set to an empty array, then populated by the parts of the new page?
What if you navigate only the child page?

I'm not sure you'd need that.  Since you have access to an array of promises, you can use a combination of array methods and Promise.all() to accomplish different goals.  For instance, if you wanted to wait till all ancestor fetches completed:
{
  fetch ({ fetchStack }) {
    // all ancestors' fetch promises
    const fetchStackIndex = fetchStack.findIndex(x => x.component === this.name)
    await Promise.all(fetchStack.map((x, index) => index < fetchStackIndex ? x.fetch : null))
  }
}

That's not "series" per-se, but rather a group of parallel ancestor promises.  If you needed each page component to await it's ancestors, then you'd need to add that logic on every page component in the tree; which is why I was saying that I think that's a bit verbose for a scenario that is more likely to happen than cherry-picking.  However, I suppose it can be DRY'd up with a utility import.

@qm3ster I've been isolating this to process.server so far (start simple, demonstrate feasibility, then add layers of complexity).  When navigating between sibling pages the ancestor pages are already loaded, so I'm not sure that's an issue (unconfirmed).  It would however be an issue when "deep linking" across the site (new ancestor tree).  I'll look into it, but my initial thought it that the stack would be replaced with a new array as if this were a server request (also unconfirmed).

the stack would be replaced with a new array as if this were a server request

With the top pages already resolved?

I'm not an expert on Promises, so I'd have to confirm this, but my understanding is that if you reference an already resolved Promise, then the value is returned, and any calls to Promise.all() would behave as expected.  So you could replace the entire stack, and any child await calls would simply progress instantly for the ancestors that were already loaded from previous routing.  Can you confirm/deny this?

That's exactly how they work, yes. I meant that the ancestor's promises would be gone when you are replacing the stack, so new children wouldn't receive them.

Has anyone found a good solution for this that doesn't require core modifications (to be used now until this is implemented)?

This would be a really great feature to have as currently it makes working with rootState problematic in SSR, since the store mutations are called after the child's asyncData is called. With this implemented, it would make the store a lot more useful (and tidy).

@iddogino in the end I implemented an additional request queuing mechanism in the store. When I need to respect the order of API calls in my project, instead of using axios within fetch function I call await dispatch('request/get', { ... . This puts the parameters in an internal queue and executes requests one by one.

I ended up having to mothball this to focus on other things.  I'm still very interested in it though, and there are many places through our app that could greatly decrease initial server-rendered page load time by loading page data in series.
I think ultimately the best way to accomplish this is to modify the core to provide access to the page fetch stack promises, but I have admittedly fallen behind in keeping up with Nuxt edge releases and not sure if a pull request would conflict with (or be applicable to) Nuxt 2.0.  I'd have to really block out time for this; which I'm unfortunately not able to do right now.  Hopefully in a month or so I can really dig in.


build mlir-graphblas for different architectures

Pull Request Test Coverage Report for Build 681700585

0 of 0   changed or added relevant lines in 0 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 63.682%

Totals

Change from base Build 680218931:
0.0%

Covered Lines:
384

Relevant Lines:
603

💛  - Coveralls

Looks good!

wow, kind of amazed that worked....


Failed to build pyarrow

I haven't changed anything recently in my project, but when I tried to deploy it last, I received this error in the logs: ERROR: Could not build wheels for pyarrow, which is required to install pyproject.toml-based projects
See the full log here:
log-d20114fe-3eeb-4a8d-8926-3a971882894c.txt
This is my requirements.txt:
requirements.txt

Sorry to hear you have having trouble. From the build logs it looks like you are not specifying a Python version for your application so we are installing the latest available version, which is Python 3.11.0. It looks like pyarrow only recently landed support for 3.11, so it is likely not available in the version your app is using (see https://github.com/apache/arrow/pull/14499 and https://github.com/streamlit/streamlit/issues/5608). My advice is to add a .python-version file to your application root and pin to Python 3.10 for now:
3.10.x

@expressintegrations can you share a little bit about where you're deploying this container?

I am using cloud run and cloud build to deploy changes to my project synced with a git repository. I opted to use the cloud build inline yaml file to manage the build/deployment.

Thank you.


Add the activeParticipats event to the notification service iOS

Add following events to the notification service:

active participants

Only iOS work. RN and Android to be done in separate ticket.

Implemented in 3.8.0 Beta 1


Users cannot call rollback after a commit action fails.

Consider the following code
transaction {
    var result = commit;
    if (var is error) {
      rollback;
    }
}

This code should compile. But fails. Also the following BBEs need to be updated accordingly with these fixes
https://ballerina.io/swan-lake/learn/by-example/local-transactions.html
https://ballerina.io/swan-lake/learn/by-example/local-transactions-with-handlers.html
Right now, the result from the commit is not checked in these BBEs.

As clarified (ref: https://github.com/ballerina-platform/ballerina-spec/issues/569), according to spec, regardless of the result of the commit-action the strand is not in transaction mode. Hence, the compilation failure is expected.


Referer undefined validation - in requestOptions

If the referer is undefined in the requestOption headers, the plugin terminates with a crash. Tested in windows 7, 64 bit with nodejs 0.12.*.
Added validation for the same.

Can you provide a stack trace for the crash? I'd prefer to fix the crash itself than falsely inject a blank referrer value. (The undefined value can more accurately be used to determine that a referrer was not sent—as opposed to a blank referrer, which could be a header with no value.)

Actually, it throws an error stating
Fatal error: "name" and "value" are required for setHeader()
And it breaks at this line,
	// Get the resource! 		clientRequest = 			client.request(requestOptions,function(response) { 				crawler.handleResponse(queueItem,response,timeCommenced); 			});
exactly where it invokes client.request
As you rightly said, sending an empty string wouldn't be a good way. Sorry for that. But will it be fine to remove the referrer if it is undefined? If fine then I can submit one for the same.

I think the right solution would be to conditionally assign the referrer header, like so:
if (queueItem.referrer) {
    requestOptions.headers.Referer = queueItem.referrer;
}

That should stop the crash. Then we'll need to add a regression test for it!

Thanks cgiffard!
I did make the change and also tested the fix from my end. It works fine now. Have updated the commit either. May be it helps now

Thanks Krishna!
In order to ensure that I (or another contributor) don't accidentally reintroduce this bug, would you be able to assist by providing a regression test? I am happy to help you with this if required.

Sure cgiffard,
Let me know the process and I will try my best to help you with this. If you can point me, in what is expected from me, then I can definitely help you on this.

I've added a test here: https://github.com/cgiffard/node-simplecrawler/pull/111 . @cgiffard would you mind releasing a new version after this fix? Thanks!


Add support for raspbian platform

Add support for raspian (debian wheezy derivative used by Raspberry Pi)
Tested basic functionality (install system wide 1.9.3-p392, gems, etc.)  with latest raspbian image. Previous raspbian images identified themselves with a platform of debian, so should be backwards compatible.

Closing due to inactivity.
If this is still an issue please reopen or open another PR.
Alternatively drop by the #sous-chefs channel on the Chef Community Slack and we'll be happy to help!
Thanks,
Sous-Chefs


Ungroup Lark from EBNF

Part of language ungrouping a la #4979.
Ungroups Lark from EBNF as its syntax is quite different and other grammar languages like ABNF are left ungrouped.
Differences between Lark and EBNF are described in https://github.com/Alhadis/language-grammars/issues/4#issue-715263376 (I wouldn't use the word "only" to preface that list...)
Change colour from the blackish #0b130f to #2980B9 from docs; minor change as it didn't show up anyway due to being grouped. This color was added in OG PR #5049 but without explanation.

Ping @Alhadis for their opinion on ungrouping as they made the original PR

Yeah, that description gave me a rather skewed impression of what Lark in relation to EBNF, so I kinda just trusted the author's definition of it. 😁
As for the colour, if I didn't give an explanation, it was probably arbitrary. No idea why I chose black, though.


SAA-529 enabling feature for activities changed event and adding localstack example change message.

Codecov Report
Patch and project coverage have no change.

Comparison is base (8d79962) 84.95% compared to head (281c650) 84.95%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #333   +/-   ##
=========================================
  Coverage     84.95%   84.95%
  Complexity     1815     1815
=========================================
  Files           260      260
  Lines          7039     7039
  Branches        343      343
=========================================
  Hits           5980     5980
  Misses          879      879
  Partials        180      180

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.


css transition support for CustomMarker

Do you have any plans to add a transition option for the CustomMarker?
I want to move the marker position smoothly from its old location.
As far as we know, the native google.maps.Marker does not do that.
CustomMarker use custom overlays and can handle HTML elements, so I think that css transitions can be used to smoothly move element positions.
reference.
https://stackoverflow.com/questions/5892113/extend-google-maps-marker-to-animate-smoothly-on-update

@HusamIbrahim
Thank you for showing me how to do this.
I think I can achieve what I want to do this way.
I tried this way.
It seems that google.maps.OverlayView#draw method is called not only when the marker position changes, but also when the map bounds changes. In both cases, the transition seemed to take effect.
Therefore, some adjustments may be necessary
Anyway, I feel that my request do not need to be implemented by this library.


SNOW-828775: Get Scala session and Dataframe from Java

Our code relies on java(our own code) and scala libraries(ml, graph) and it would be very helpful to be able to convert the Java Dataframe and Session to Scala so that we can use both interoperably. I see the com.snowflake.snowpark_java.Dataframe already has getScalaDataframe() but it is package scoped. So is com.snowflake.snowpark_java.getScalaSession.
Is it possible to expose these methods publicly?

Hi @sonalgoyal , could you include a code snippet or psudeo-code to help describe your scenario? I'm not sure I follow. Since Java is the common denominator in your project, you should be able to use the Java Snowpark library throughout, no?

@sfc-gh-jfreeberg We use Java predominantly in our stack and transform it.  So we have a Java Dataframe. Now we have a graph library provided to us by the Snowflake team which is in scala and uses Scala Dataframes as input. We do not have a way to invoke the Scala library from Java, as the DFs can not be invoked directly. Hence we are writing the Java DF to a temp table, and then reading it in Scala to make Scala Dataframes.

@sonalgoyal Thanks to explain the use case for us. If these API are package scoped. I am assuming you can workaround it easily by introducing a utility class in the same name package and create a public function to return Scala DataFrame/Session for Java DataFrame/Session.

@sonalgoyal Which graph library is this? Do said it was provided by Snowflake?

We got it from Stuart Ozer and Robert Fehrmann from the Snowflake team.