Update starting.md

I am not at all clear on how well GitHub for Windows will handle multiple PRs pointing to the same work directory, but let's see what happens.
Let me know if this is formatted correctly - e.g., should it be building on base? Or on my other open PR?

One thing I'd really like some instruction on is the section about connecting to a database:
https://deploy-preview-2968--openrefine-docs.netlify.app/manual/starting#database-sql
I see from discussions on #1951 and etc. that local .db file loading is quite simple.
I didn't see instructions anywhere else about connecting to one online, so I tested and wrote those instructions from one of my own databases. Just because it worked for me doesn't mean it's the simplest way! So, if anyone with better experience here can offer some more details, I would appreciate it.
Also I'm not sure how secure this method is - putting any request that comes from my IP, for example, on the "safe" list.

In our chat today we talked about simplifying these database-access directions - presuming you have account access to a database, you can probably find your way around this part.
Just now in searching our user group I found:
https://groups.google.com/g/openrefine/c/GsHYuP1kXV8/m/rSbpK6EpAgAJ
... which brings up two things:

One, are there important SQL limitations/options that should be noted in the documentation?
https://github.com/OpenRefine/OpenRefine/blob/master/extensions/database/module/scripts/index/database-source-ui.js
excludes: DROP, TRUNCATE, DELETE, ROLLBACK, SHUTDOWN, INSERT, ALTER, UPDATE
which all seems fine to me, and not worth mentioning.
I haven't written any SQL guidance because I assume nobody needs it, but is there anything particular to OpenRefine that we should point out?

The user also links to https://docs.rfam.org/en/latest/database.html
which is a great public database that users can query. The page is pretty explanatory, and it even has example queries, which is great. Any interest in just pointing people to a resource like this? Not necessarily this one - I'll do some shopping around if there's interest.

I would not list the statements explicitly - you could just indicate that queries that modify the target database are not allowed (since the purpose of this importer is just to extract data from the database).

RFAM is a great example!

@allanaaa at the moment this PR includes some commits that are already in the master branch. I think if you rebase your docs-starting branch on master this problem should go away

I'm not sure that that rebase worked - rebasing goes fine, but when I push changes it asks me to pull origin, and then all ... that ... appears. I'm supposed to be rebasing from upstream/master, right?

It might be worth having a conversation about more general "documentation scope" principles. I feel like we might have a disconnect there.
The information I've left in the Database section truly feels useful to me, and not out of scope, so I'm going to hold the line for the time being. There will be more opportunities to revisit this of course. (It would be great if there was a generic guide we could link to here! I'm sure someone else has written it better, but I haven't seen it yet.)
I think a small "user group" of first-timers (2-3) working through database connections would be useful since there seems to be so much attention on this. But I also read elsewhere (https://groups.google.com/g/openrefine-dev/c/Ywj7BxCX72A/m/Eq-U7idMBQAJ) that "only 40 folks will use it" - so it may not be worth this much scrutiny. (Do we keep stats on this?)
Thanks for the other feedback. Are there other comments on the other sections of this page for the time being? I was expecting some feedback on the "Project management" section, tbh.

I've bumped the hierarchy a bit on this page so you can see all the "methods" in the TOC. It's better for readability I think.
I also removed "Overview" and then immediately put it back again. For navigation's sake I guess we should always open with an H2.

Yeah - that rebase definitely doesn't look right :( So I'd expect the workflow to be something like:

Fetch latest changes from upstream
merge upstream/master into your local master
rebase docs-starting on local master

With the command-line it would look like:
git checkout master
git fetch upstream
git merge upstream/master
git checkout docs-starting
git rebase master

It doesn't look like this is quite what has happened here - but I'm not entirely sure what's gone wrong tbh. Trying to rebase now I get a lot of conflicts which seem to be your own edits conflicting with themselves! Maybe we can try to work through this on the call tomorrow

I think a small "user group" of first-timers (2-3) working through database connections would be useful since there seems to be so much attention on this. But I also read elsewhere (https://groups.google.com/g/openrefine-dev/c/Ywj7BxCX72A/m/Eq-U7idMBQAJ) that "only 40 folks will use it" - so it may not be worth this much scrutiny. (Do we keep stats on this?)

I absolutely feel we've spent more time on it than is worthwhile tbh (although that "40 users" is a figure pulled out of thin air as far as I can tell, but the general point which is this is of interest to a small minority of users is fair).
The only reason its a focus is because its hard to get all this information - which really is specialised - succinctly and usefully into this documentation which is meant to be about getting started with OpenRefine :(
I'm really against spending any more time on this, but if we are going to include information I feel it needs to be accurate - and the comments I've left since last week when I said "I'm very happy for you to do what you think is best" are about accuracy and not scope which I'm leaving to you.

It might be worth having a conversation about more general "documentation scope" principles. I feel like we might have a disconnect there.

Very happy to do this on the call tomorrow - sorry if this is frustrating - I don't want to get in the way of progress here

Are there other comments on the other sections of this page for the time being? I was expecting some feedback on the "Project management" section, tbh.

The Project Management section seems OK to me. The only comment I'd really have is that it will need linking up to other areas of the documentation once they are written I think as it seems to contain lots of terms that aren't explained - but I assumed you were going to deal with that as you worked through. (this might point to the need for a glossary for some basic terms - like row/record, facet, filter etc?)
I'm sure we could extend this more, but this is an area where I think the idea of getting some user feedback would be useful - I think what you've already written is a good start and we can work from there

For navigation's sake I guess we should always open with an H2.
Agreed - I came to the same conclusion with the technical reference even though that sometimes meant an odd heading at the top of the page - but without it the navigation doesn't work so well (no way of jumping back to the top of the page via the righthand menu)

The issue with the rebase is likely due to the fact that you need to to "force push" just after rebasing - you should not pull from origin before that. We can try to fix this during the call today.

@ostephens thanks! if you could use the "Squash" option next time it would be great - that avoids pulling all the intermediate commits into master.

Sure - apologies!

Not a problem at all!


HTTP 200 is returned instead of 504

Hello,
When I do GET against https://httpstat.us/504 I get 200 in response code instead of 504.
Following abusive usage of that endpoint, we temporarily updated it the 504 endpoint to be a noop.
See https://github.com/Readify/httpstatus/issues/89#issuecomment-705978272


Update README.md to fix launch tracks on ios

@BenjaminAF Is this mandatory for Tracking to work correctly ?

hi @PimDeWitte what is the reason to add [[AppsFlyerTracker sharedTracker] trackAppLaunch];  inside applicationDidBecomeActive if its already called in RCT_EXPORT_METHOD(initSdk)?
And how did you integrate JS part that trackAppLaunch  doesn't work for you?


Update GridLayout logic

🐛 Bug Report
Possible GridLayout updates:

right now GridLayout uses static numbers for determining the vertical height of the card container, resulting in the row height being 300px (arbitrary value) even if the card doesn't have a footer + details and could fit in a 250px height

Since v3 cards can have a variety of things in the card that weren't in the v2 card, perhaps we should investigate making the layout do a second measurement to see what the true size of the row is

set the row height to be the height of the largest card in the row

scale support roughly handed via eyeballed values but requires spectrum feedback/actual values

🧢 Your Company/Team

🕷 Tracking Issue (optional)

Moved to s2


One-to-One relation inverse?

Introduction
I was investigationg a lot and didn't find needed asnwer.
So I have two tables
Partners
-id
-transportId
-a lot of other fields
Transports
-id
I need to work with Partner model, so I do something like this
var Partner = bookshelf.Model.extend({
  tableName: 'partners',
});

const Transport = bookshelf.Model.extend({
  tableName: 'transports',
  partner: function() {
    return this.belongsTo(Partner, 'transportId')
  }
});

Try to get result
findOne: async params => {
    return Partner.forge(params)
      .fetch({withRelated: ['transport']})
      .then(res => (res ? res.serialize() : null))
      .catch((err) => console.log(err))
  },

I wanted to put inside Partner block this function
transport: function(){
    return this.hasOne(Transport)
  },

But I don't have partner_id inside transport table.
What is the best way to make it work all together? I have the same problems with other tables that have one-to-one relation with partner, so I just need to figure out how to use partner with those related fileds?

Have you tried belongsTo?

Your Transport model is incorrect. According to your database structure it should be:
const Transport = bookshelf.Model.extend({
  tableName: 'transports',
  partner: function() {
    return this.hasMany(Partner, 'transportId') // or `hasOne` if you prefer
  }
});

The docs explain where the foreign keys are located for the various relation types: http://bookshelfjs.org/#Model-instance-belongsTo.

Closing this due to lack of response.


Fix esp32c3 build

fixed with #170

fixed with #170

Are we sure? I thought Anna said that it didn't compile for her or something

We should probably add a CI step for the C3 as well (just edit the JSON file in ci/)

Can you make this change?

Welp, as long as this doesn't compile you can forget about merging

Wow Anna CI-blocked Butlah :nya_a:

Its the -fpermissive bug, I thought you said that was fixed @unlogisch04

To be fair, the -fpermissive has been a problem for a while and its only showing up now due to the updated compiler

Wow Anna CI-blocked Butlah :nya_a:

the CI promises to fix esp32c3 builds but doesn't even build it in CI smh
if it doesn't compile in this PR it shouldn't get merged. as easy as that.

@TheButlah please rebase against main :)

I think that changing the types of the configuration file would've been smarter.
That way we:

Change the library, therefore making updating the lib easier
Have less changes in general

I did not find this bias function in a actual upstream lib. So not sure if this was added later anyway. I look at all sparkfun icm20948 forks, that where ahead of the original.


libconnector.so:  Operation not permitted in /TMP

java.lang.RuntimeException: java.lang.UnsatisfiedLinkError: /tmp/lava-jni-natives/1568318308672/libconnector.so: /tmp/lava-jni-natives/1568318308672/libconnector.so: failed to map segment from shared object: Operation not permitted
centos 7 on /tmp/
its mounted with tmpfs /tmp tmpfs rw,noexec,nosuid 0 0
and thats to prevent malicious peopl from executing scripts.
Is there anyway to avoid storing files from /tmp folder and let us choose a storage path?

You can set lava.native.connector.extractPath system property to specify the exact path where it should be extracted to.

Closing as answer was provided long ago.


[Add]  Adding a link in, category- frontend, sub-category - Icons

Site URL
https://evil-icons.io/
Description of the above provided site
Simple and clean SVG icon pack with the code to support Rails, Sprockets, Node.js, Gulp, Grunt and CDN.
Category
Frontend
Sub Category
Icons
Checklist

[X] I have checked the existing issues
[X] I have read the Contributing Guidelines
[X] I am willing to work on this issue (optional)
[X] I am participating in Hacktoberfest 2023

You've been assigned @Prakhar-Shankar! :)


No internet access

Can't connect to internet on my emulator when my MAC M1 is connected to personal hotspot on my iPhone.

help please

http request are failing, please response

getting the same issue...SOS

+1 Can't connect to internet on my emulator when my MAC M1 is connected to wi-fi or personal hotspot on my iPhone. Tried every method I can find to fix it

+1 Can't connect to internet on my emulator when my MAC M1 is connected to wi-fi or personal hotspot on my iPhone. Tried every method I can find to fix it

Try changing the dns of your MacBook, put the following: <IP_ADDRESS>.8 - <IP_ADDRESS>.1
It solved my connection problem with this emulator.

+1 Can't connect to internet on my emulator when my MAC M1 is connected to wi-fi or personal hotspot on my iPhone. Tried every method I can find to fix it

Try changing the dns of your MacBook, put the following: <IP_ADDRESS> - <IP_ADDRESS>
It solved my connection problem with this emulator.

I've tried this too.  You need to update android emulator on latest version.
My steps:
1 Delete android emulator in Android SDK - SDK tools
2 Change update site in Updates - Update channel, on Canary channel
3 Install android emulator in Android SDK - SDK tools
4 Change update site back on Stable channel
You can check you version here and it should be the latest:

@Artyom873 Even though I have updated the Android Emulator version to 30.7.4 from SDK Tools.

Emulator's about section still shows older version. How to update there? I tried creating the new emulator but it gets created on older version (30.3.5).

@Artyom873 Even though I have updated the Android Emulator version to 30.7.4 from SDK Tools.
Emulator's about section still shows older version. How to update there? I tried creating the new emulator but it gets created on older version (30.3.5).

You can try install Android Studio Canary (without removing your stable). Delete all old emulator's and create new one in Canary version. Maybe it help your studio "find" new version of emulator. I did this too when I updated the emulator, but I don't know what it gave. Maybe this is important and will help you.

 I had to delete all these files and then relaunch Android Studio and create a new emulator with Pixel 3a for Google Play support. Where before I had tried all the other suggestions (specifying DNS, disabling other network adapters, using the Canary update channel and even using Android Studio Preview) I was just unable to turn on WiFi and the no network icon showed up on the Status Bar (globe with a small x). Thanks rusakovic!
Now on to the new issue where Chrome keeps stopping in the emulator. Nevermind, it was because I was trying to use Android R api. With S it works fine!

@Artyom873 Even though I have updated the Android Emulator version to 30.7.4 from SDK Tools.
Emulator's about section still shows older version. How to update there? I tried creating the new emulator but it gets created on older version (30.3.5).

You can try install Android Studio Canary (without removing your stable). Delete all old emulator's and create new one in Canary version. Maybe it help your studio "find" new version of emulator. I did this too when I updated the emulator, but I don't know what it gave. Maybe this is important and will help you.

thank you so much, after 3 sad months android emulator on my m1 finally works correctly

On my machine, Wi-Fi doesn't get turned on.
https://imgur.com/a/xWgriwS

Me too, but today I fix it. You need to update android emulator on latest version.
My steps:
1 Delete android emulator in Android SDK - SDK tools
2 Change update site in Updates - Update channel, on Canary channel
3 Install android emulator in Android SDK - SDK tools
4 Change update site back on Stable channel
You can check you version here and it should be the latest:

thank you so much, after 3 sad months android emulator on my m1 finally works correctly

Has there been a proper fix for this yet?
My config is listed below and no love :(
Android Studio version - Artic Fox 2020.3.1
Emulator version - 30.7.4-7453540
Device - Pixel 4 API 31
System image - arm64-v8a

This combination is working for me on a Macbook Air M1:

ps: Chrome crashes sometimes, i know is a known issue

How did you get API 29? I am not able to download it

Yeah  absarrahman  I'm not able to get it either.  I think @ChristianParraCL is not on the stable release

Yeah absarrahman I'm not able to get it either. I think @ChristianParraCL is not on the stable release

I think we need to use canary builds for now. Cause stable ones are not working and without internet connection, it's gonna be a huge pain

@frankfuu Finally managed to solve it. Just use the latest canary version. It will do the job done

@frankfuu Finally managed to solve it. Just use the latest canary version. It will fix the issue

Did you use the lastest Canary Android studio? But I can't download the Canary 8 from the website because it always provides the windwows version for me.

Yeah absarrahman I'm not able to get it either. I think @ChristianParraCL is not on the stable release

oh yes, i forgot to mention i'm using Canary releases 💡

Is there anyway to run it without using the canary version?

Thanks @absarrahman, I downloaded android-studio-2<IP_ADDRESS>-mac_arm.zip from https://developer.android.com/studio/archive and gained internet connectivity. I used the Pixel 4 on API 30 arm64 image for the emulator.

same issue for me, I using Android Studio Arctic Fox | 2020.3.1

Same issue for me. Nothing worked have been on Canary the whole time (on Arctic Fox 2020.3.1). I have tried everything described above with no luck. And deleted and setup countless virtual devices.
Then I tried setting up a Pixel 4 on API 30 arm64 image. And it worked and had internet out of the box.
Thank you for highlighting your solutions @frankfuu and @edritech93

Has there been a proper fix for this yet?
My config is listed below and no love :(
Download file - android-studio-2<IP_ADDRESS>-mac_arm.zip
Android Studio version - Artic Fox 2020.3.1
Emulator version - 30.7.4-7453540
Device - Pixel 4 API 31
System image - arm64-v8a

Thanks so much, i solve it with your config

Delete Emulator and Update "Android Emulator" from SDK manager.
it is working fine for me

I just reinstalled the Android Studio, and now 30.7.4 is selected in emulator.
* rm -Rf /Applications/Android\ Studio.app
  rm -Rf ~/Library/Preferences/AndroidStudio*
  rm -Rf ~/Library/Preferences/com.google.android.*
  rm -Rf ~/Library/Preferences/com.android.*
  rm -Rf ~/Library/Application\ Support/AndroidStudio*
  rm -Rf ~/Library/Logs/AndroidStudio*
  rm -Rf ~/Library/Caches/AndroidStudio*
  rm -Rf ~/.AndroidStudio*
  rm -Rf ~/AndroidStudioProjects
  rm -Rf ~/.gradle
  rm -Rf ~/.android
  rm -Rf ~/Library/Android*

Thanks, this worked for me. and i installed new version. https://developer.android.com/studio/archive

Here is something which worked for me:

Wipe data
Cold boot now.

A workaround is :

Check for IDE update [ If Available update the IDE ],
Go to AVD -> Install the latest arm64 ( API32 release ) ,
Restart the IDE -> Open Android Emulator and BAM! [ Simply works ]

And if you're on hotspot from iphone then switch to iphoneUSB.

This is the one.  Changed back to their Wifi and it worked again. Very interesting. Thanks!

I tried the solution above but unfortunately, it didn't work.
I followed this article and added DNS <IP_ADDRESS> and <IP_ADDRESS> in System Preferences > Network.
The Internet is now working fine on the Emulator.

I tried the solution above but unfortunately, it didn't work.
I followed this article and added DNS <IP_ADDRESS> and <IP_ADDRESS> in System Preferences > Network.
The Internet is now working fine on the Emulator.

this works fine for me


Client JWT bug when polling import endpoints

The client is sending an expired JWT to import endpoints during ingest polling.  Temporary fix is in place.

Merged with #286


Disallow type error without code

I strengthen the mypy and ruff config a bit to disallow type: ignore with no code, found one case when the ignore can be removed

Thanks @tqa236 👍


Issue nr: 14594 - removing old implementation where fields where dot-…

…escaped due to old ELK not supporting it. But now this is supported, therefore there is no need to escape it anylonger.
What issue does this PR address?
Disable dot escaping for field names, as it is supported since long time ago in ELK.
Does this PR introduce a breaking change?
If the field name x.y was used, till now in kibana it would show as x/y, after this commit, it will show as x.y. But I think the breaking change is very small.
Please check if the PR fulfills these requirements

[x] The commit follows our guidelines
[ ] Unit Tests for the changes have been added (for bug fixes / features)

There was no need for new unit tests, since only old code was removed.
Other information:
Also changed a method from using recursion to a simple while loop.

Thanks for the PR and sorry for not responding sooner!


Color #000000

It is impossible to select the color #000000 when moving the marker

Chrome, Photoshop, Sketch

Fixed. Please upgrade to the latest version.


Retain substitution types through instantiation if possible

Fixes #29677
The alias lacked the correct constraint because the constraint was implied by the substitution type, which disappeared when the type alias was instantiated with the outer type parameters. The correct behavior is to retain substitution types through instantiation if their type variable is still a type variable upon instantiation.
This required correctly handling substitution types on the target side in inference (other tests needed the change to continue to work as expected), naturally, since, eg, an Extract<K, string>'s true branch is now going to look like a substitution of K instead of K directly.

@typescript-bot run dt & @typescript-bot test this

@typescript-bot test this & @typescript-bot run dt

@typescript-bot test this & @typescript-bot run dt

@typescript-bot test this & @typescript-bot run dt

@typescript-bot test this & @typescript-bot run dt

@typescript-bot test this & @typescript-bot run dt

@RyanCavanaugh the bot has learned how to run DT tests on PRs. It takes like an hour and a half; use it sparingly~

DT looks good~


Flesh out the README

It's not too early to start adding some (very basic) docs on installing and configuring this.
Probably the minimum things to call out are:

The dependency on Brigade 2 (currently in alpha)

Where to get the chart from (at this stage, it is fine to require users to clone this repository to obtain the chart)

How to set up a service account in Brigade with correct permissions and plug the token into brigade-prometheus at install (helm install) time

Added docs with steps on how to set everything up in the main README. Let me know if this works

Recent changes look good, with one minor issue...
It's been a major goal of Brigade 2 (in contrast to Brigade 1.x) to be useful to non-Kubernetes users. i.e. There is presumably a class of user who uses Brigade to automate things while having neither direct access to the underlying Kubernetes cluster nor (necessarily) any Kubernetes expertise.
In light of this, the following statement in the README, while true, could prove misleading:

Brigade Prometheus handles the provisioning and setup for all three components, so that any user of Brigade can get a monitoring solution for their Brigade jobs up with a simple helm installation.

While not intended this way, it's a reasonable interpretation of this that brigade-prometheus is something that individual Brigade users might install to access metrics for quote: "their Brigade jobs."
With the reality being that this add-on is something that should be installed once per Brigade, the documentation should probably be more specific that it is targeting "Brigade operators who wish to expose metrics to their users" (or something along those lines).

Made this change in the most recent commit to master. Also added new steps on login options, let me know if those look good!


docs: Correcting Coding Guide dependency injection example.

Hello,
I had found a few errors in the code example about dependency injection in the Coding Guide docs. I wanted to submit corrections in effort to reduce confusion for future potential contributors to the grid model project!
Thanks,
Verene

No problem! Thanks Daniel!
On Thu, Feb 24, 2022 at 9:50 AM danielolsen @.***>
wrote:

Merged #73 https://github.com/Breakthrough-Energy/docs/pull/73 into
master.
—
Reply to this email directly, view it on GitHub
https://github.com/Breakthrough-Energy/docs/pull/73#event-6133955896,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/ACQUXFMXBPKYKZRGOW6TPR3U4ZVWZANCNFSM5OY2TCGQ
.
Triage notifications on the go with GitHub Mobile for iOS
https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675
or Android
https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you authored the thread.Message ID:
@.***>


Open links in new tab by default

While playing with explorables on the Hub, we noticed that links are opened by default in the same tab. By adding <base target="_blank"> in the head, all links will open in a new tab by default. This works as long as <a> does not have a target attribute already. Is this a change you would be ok with?

Is this iframe detection code not triggering on in Hub embeds? It should be adding target="_blank" to all the links.
https://github.com/PAIR-code/ai-explorables/commit/822f766eee9d3c85aa58b68d24e3618d4c284550

I missed this was added, thanks for raising. I think the deployed version in Spaces might not be containing this added script code
cc @merveenoyan


chore: move specific deps to package

I noticed that the published pubsub package did not include its required dependencies. I have moved these to the pubsub package.json so they should be published along with the package from now on.

Rare houses roll 🤭

If we want to install a dependency in a specific package, we should use e.g. yarn workspace @sebspark/typed-router add is-even from now on.
PS. I'm thinking of adding workspace installs to supreme to reduce the amount of typing needed.

@believer I re-added the dependencies using that method.
The test and lint runs are broken right now but this change only affects dependencies so it should be safe to merge.

@alexanderczigler Yeah, but why are they broken? 🤔

@believer very good question 🤔
It might be a problem introduced in 1.10.6 according to https://github.com/vercel/turbo/discussions/5290

Oh! 😑
A package-lock.json has been added here. I thought it was just modified so I did not pay attention to it. That files seems to cause the problem.

Haha I didn't even notice that. Nice catch!


Move to upstream helm-unittest

Currently, we use our own fork of https://github.com/rancher/helm-unittest. From what I can find, primarily for:

Ability to set apiVersions to test with
s390x arch support

Upstream has the ability to set apiVersions now, and I am not sure if we strictly need s390x charts testing. If we do, we can close this issue as upstream does not have binaries for it.

https://github.com/rancher/rancher/pull/41469


RHMAP-12454 Added ability to generate tokens for a given variant

Motivation
We needed a way to generate tokens for an existing variant

ping @matzew @josemigallas

sweet! :+1:


No Audit being logged on AppsMan when this plugin is used

Expected Behavior
Audit should be there on AppsMan to backtrack actions of users
Actual Behavior
It just restarts the app with no audit on AppsMan
Steps to Reproduce (including precondition)
Do a cf rolling-restart of an app and see on Appsman
Screenshot on This Problem (if possible)
{Please write here}
Your Environment

OS: RHEL
cf-cli version: cf version 6.51.0+2acd15650.2020-04-07
cf-rolling-restart version: cf-rolling-restart 1.1.1

Hey @dhgarg, I will take a look into the issue this week and let you know what I find. It uses the official api+commands for Cloud Foundry to perform the restarts so it should provide all the same audit logs (if any) as running cf restart-app-instance.


TSE is being falsely detected

TSE is being falsely detected by TFOD due to its color

We spray painted the TFOD with yellow, white, and red. This made it more contrast to the background essentially, making the TSE easier to detect and less easy to be falsely detected. We also had to train a new tflite model after this.


BUG make sure to not munge prompt on zsh

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@conda-forge-admin, please rerender

@conda-forge-admin, please rerender

We should wait on this until the clang PR has been debugged.

We should wait on this until the clang PR has been debugged.

@isuruf the clang version of this is working great. This or can be merged.

@isuruf the clang version of this is working great. This or can be merged.

bump here @isuruf - I think we should merge this one.

bump here @isuruf - I think we should merge this one.

another bump, this fix works great already in the clang activation feedstock...

I am waiting on code review from @isuruf but am willing to merge in another week if we don't hear back.

thanks @isuruf!


[Pulsar transaction] Transaction coordinator metrics.

Motivation
Transaction coordinator metrics add.
implement
    /** The transaction coordinatorId. */
    private long transactionCoordinatorId;

    /** The transaction max sequenceId. */
    private long transactionSequenceId;

    /** The ongoing transaction count. */
    private int ongoingTransactionCount;

    /** The low water mark of this transaction coordinator. */
    private long lowWaterMark;

    /** The commit transaction rate of this transaction coordinator. */
    public double commitTransactionRate;

    /** The abort transaction rate of this transaction coordinator. */
    public double abortTransactionRate;

    /** The create transaction rate of this transaction coordinator. */
    public double createTransactionRate;

This is transaction coordinator metrics, if have another useful metrics, we can add in other PR.
Verifying this change
Add the tests for it
Does this pull request potentially affect one of the following parts:
If yes was chosen, please highlight the changes
Dependencies (does it add or upgrade a dependency): (no)
The public API: (no)
The schema: (no)
The default values of configurations: (no)
The wire protocol: (no)
The rest endpoints: (no)
The admin cli options: (no)
Anything that affects deployment: (no)

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

/pulsarbot run-failure-checks

@congbobo184 thanks for your work. Could you please help add docs accordingly? Thanks

@congbobo184 thanks for your work. Could you please help add docs accordingly? Thanks

OK, when transaction completely, I will add the docs.


Add throttleIdleCallback

From @jvanbruegge on April 16, 2017 8:47
As described here requestIdleCallback can be used to perform low priority work (like an infinite scroller).
It would be cool to be able to have a throttleIdleCallback function, kinda like this:
const distance$ = DOM.select('document').events('scroll')
    .map(ev => ev.view)
    .map(win => win.document.body.offsetHeight - win.innerHeight - win.scrollTop);

const append$ = xs.merge(
    //This will emit within the next 1.5 seconds when the browser has not much to do
    distance$.filter(d => d < 1500 && d > 500).compose(Time.throttleIdleCallback(1500)),

    //This will fire if we are getting to close to the bottom, so we can force it to happen
    distance$.filter(d => d <= 500)
).mapTo(/* HTTP request and insertion */)

I dont know if this is

possible
useful
better done in another way

What do you think @Widdershin?
Copied from original issue: cyclejs/time#29

From @jvanbruegge on April 16, 2017 8:53
Here is another article about it: https://developers.google.com/web/updates/2015/08/using-requestidlecallback
It could be very useful for something like analytics too

I like this idea 👍
How do you think it should work in the case where the browser has yet to implement requestIdleCallback? Schedule as per normal at the provided interval?

From @jvanbruegge on April 17, 2017 14:14
I would fall back to throttleAnimationFrame. It is still keeping the browser from overloading, but will be scheduled a lot earlier, I would not use the provided interval, as this means the maximum time it is allowed to take, normally you want it to be scheduled ASAP (when the browser is idle)

That makes sense. This feature won't just neatly slot in to the current architecture, it will take a little bit of work and thought to get it going.
Perhaps we could pair program on this at Cycle Conf 😸

From @jvanbruegge on April 17, 2017 19:53
We can try :D

I need to think a little bit more about how this should work with cycle-restart. Ideally it would be deterministic across runs, so we can't just call throttleIdleCallback during the restart process.


Likeliness of 368b7eb also impacting ESP32-S3? (IDFGH-13282)

Answers checklist.

[x] I have read the documentation ESP-IDF Programming Guide and the issue is not addressed there.
[X] I have updated my IDF branch (master or release) to the latest version and checked that the issue is present there.
[X] I have searched the issue tracker for a similar issue and not found a similar issue.

General issue report
How likely would it be that the fixes listed over here also apply to the ESP32-S3? We're currently having issues where we think the Wi-Fi stack fails to deinitialize (due to some reason) which is blocking the ESP32-S3 from entering deep-sleep. We've now updated to V5.1.4 (i.c.w. ESP-ADF V2.6) and are going to test if this doesn't happen anymore.

This fix is not for esp32s3, could you describe the detailed phenomenon when the error occurs?

We had an issue with application logic which didn't manage the case when there wasn't a wifi connection, but we also hadn't fired up the AP yet. This resulted in the Wi-Fi stack not being deinitialized when entering deep-sleep. Sometimes, deep-sleep wasn't entered but the main-loop appeared like it was no longer running. Some other tasks in the background were still active. The Wi-Fi connection sometimes was also still active.

Some other tasks in the background were still active. The Wi-Fi connection sometimes was also still active.

This situation should not happen. The software will ensure that the process of entering sleep is single-threaded. The core requesting sleep will enter the critical section and stop other cores, and then prepare for sleep. Even if entering sleep fails, esp_deep_sleep_start function will not return but trigger the watchdog.

Thanks for reporting, will close due to short of feedback, feel free to reopen with more updates.
Thanks for using our Espressif product!


Sig-Release/Eclipse-Tractusx: Add a label for the Agents Kit

Description

I would be great if you could add an additional label either named "knowledge-agents" or "agents-kit".
this label would tag any overarching feature/discussion/issue to the repos "knowledge-agents", "knowledge-agents-edc" and "knowledge-agents-aas-bridge".
Impact

Makes tagging of discussions and issues as well as planning release 24.03 easier
Team KA will move its complete planning to tractus-x for PI11/Release 24.03
Additional information

seems like labels can only be managed by the sig-release team. I would propose @FaGru3n to look at this.

Hi @drcgjung,
sure we can add multible label´s, created a general idea on our discussion section to find out which general compnent labels we want to use for all and should be clarified that we are not overwelmed by labels and there colours in our Planning Board.
see the discussion: https://github.com/eclipse-tractusx/sig-release/discussions/205
For that we need also a clear description maybe in the README, which label is used when if Relase Management, CX-ART Planning and Open Planning and Kit-Planning using their own lables.... 😉
Is it okay if we discuss it further in this section and i can close the issue?

additional info: every committer can add/change/modify lables within Eclipse Tractus-X Repositories

seems like labels can only be managed by the sig-release team. I would propose @FaGru3n to look at this.

https://www.eclipse.org/projects/handbook/#resources-github-access
https://docs.github.com/en/organizations/managing-user-access-to-your-organizations-repositories/managing-repository-roles/repository-roles-for-an-organization

@FaGru3n thanks for clearing the procedure!


Replace Jest with Karma

Decided it was time to replace Jest with Karma, as:

Karma seems way more stable/better maintained
Karma runs with mocha/sinon/chai which are way better maintained than the stuff jest comes with
Karma runs in browsers, which is cool!

lgtm


Need new 3d models for assets to display in the config tool

Replace PS3 EYE camera model with texture
Replace PSMove controller model with texture
DualShock 4 model with texture
Navi controller model with texture

Hi there, i actually modeled and textured a PSMove model to use it on SteamVR, texture work is not perfect and it probably needs some scaling too but you can check it out here (tried to upload it on github but it refused to accept .zip file)

Thanks a bunch for this. I'll incorporate this model this weekend.

Happy to help! I'm also planning modelling EYE Camera this weekend but i can't promise because of my exams.

Oh no rush. Exams come first :)

Finished EYE, You can see it from here and download it from here
UV Maps are fine when you download it but there is bug in sketchfab that messes up UV maps right now.

Thanks a bunch, looks great! Your timing is perfect. I was debugging the steam vr plugin last night and realized one of the things I needed was pseye model for the compositor view. As soon as I get the plugin working (which should be by the end of this weekend) i'll upload a movie of it in action with your new models.

That's good to hear, also i'm going to model Navi Controller next.

@InfinateXtremer So I've been trying to get the controller and ps3eye models to show up in steamvr and haven't been having any luck. After some investigation I found the problem in a steamvr log file (vrclient_vrcompositor.txt):
Mon Jun 06 2016 17:21:37.177 - RendermodelManager: Reading data from C:\Program Files (x86)\Steam\steamapps\common\SteamVR\drivers\psmove\resources\rendermodels\ps3eye_tracker\ps3eye_tracker.json
Mon Jun 06 2016 17:21:37.177 - RendermodelManager: name=body inputRouting=0 filename=ps3eye_tracker.obj
Mon Jun 06 2016 17:21:40.525 - Render model C:\Program Files (x86)\Steam\steamapps\common\SteamVR\drivers\psmove\resources\rendermodels\ps3eye_tracker\ps3eye_tracker.obj specifies multiple diffuse texture materials. Only one diffuse texture per model is supported.

It turns out each model can only have one texture. You can break the object up into multiple pieces and make a .json file that connects all of the pieces that have different textures, but if you want a single model it has to be a single texture. Would it be two much trouble to get the psmove controller and the ps3eye to have a single texture? They both currently have two.
Thanks a bunch.

So that's why i never managed to get them on steamvr, fixing it now.

@InfinateXtremer Hey sorry I haven't written back in a while about this. I got bogged down in fixing controller rumble and adding support for the dualshock4 the last few weeks. I finally got these models in tonight. You can see the models in action here: https://www.youtube.com/watch?v=xomIBMLvDEY. The updated steamvr plugin is now checked into latest. I still need to integrate the new models into the  client config tool. I'm going to try and do that this weekend.

Closing this issue to make individual issues for navi and ds4


Can you give me option cache cert ?

When staging or sometime, you recreate or deploy service many time. 'net-http01' recall api letsencrypt to get cert. letsencrypt will block you "too many certificates already issued for exact set of domains"
You can save it in the cache until a certain period of time, or until it expires ....
Thanks

The secret effectively is the cache today.  We could consider something more in-memory, but it will really only avoid this for a pretty narrow use case.

Do you want to give this a shot?

Do you want to give this a shot?

Yes, i want


Formatted changes for consistency karma.conf.js

Removed period from line 1 to be consistent with rest of file.
Changed first letter of the first word on lines 1, 2, 42 and 46 to be consistent with rest of file.

There's no official "style" for comments, but we tend to use full sentences that start with a capital and end with a period. Feel free to amend this pull request to add in the missing periods, if you'd like.


Fix race condition, missing animationend event when animationstart callback is slow to call.

fixes #35 built on top of the PR for https://github.com/aurelia/animator-css/pull/33

first of all, big thank you @ohjames for your great work. I'm not really a fan of the introduced variable verifyKeyframesExist and the additional complexity, but the removal of the timeouts for sure does make the plugin overall better.
Code looks good but not all tests seem to pass. There are 3 staggering unit tests that fail. Could you verify that on your machine as well? Perhaps the issue is related to my crappy old macbook. Maybe just give it a try with a small staggering demo. If that works I'm fine with merging this.
Again great work and thank you for the contribution. Also sorry for catching my while being abroad.

@zewa666 I'm not a fan of the verifyKeyframesExist work having to be done either, but the alternative is that if a user refers to an animation that doesn't exist... their animation promises will never get resolved. You could always document it well in the aurelia documentation though... that using non-existing keyframes will lead to catastrophy. You can disable the check with an option... so that people who know what they are doing can remove the keyframe check and accept responsibility.
The stagger tests work fine to me with both the race-condition-fix and race-condition2-fix branches. I assume you tested with race-condition2-fix since that's the PR you are commenting on, but if you were on the former branch then perhaps the latter could solve the issue.
Otherwise I'm not sure. This is chromium on mac os? I'm using chromium on Linux here and I've also tested with firefox. I've run these tests many times yet and they seem to reliably pass.

james@minchil animator-css % gulp build && gulp test
[17:02:19] Using gulpfile ~/projects/animator-css/gulpfile.js
[17:02:19] Starting 'build'...
[17:02:19] Starting 'clean'...
[17:02:19] Finished 'clean' after 34 ms
[17:02:19] Starting 'build-index'...
[17:02:19] Finished 'build-index' after 34 ms
[17:02:19] Starting 'build-es6'...
[17:02:19] Starting 'build-commonjs'...
[17:02:19] Starting 'build-amd'...
[17:02:19] Starting 'build-system'...
[17:02:20] Finished 'build-commonjs' after 1.09 s
[17:02:20] Finished 'build-amd' after 1.09 s
[17:02:20] Finished 'build-system' after 1.08 s
[17:02:20] Finished 'build-es6' after 1.09 s
[17:02:20] Starting 'build-dts'...
[17:02:20] Finished 'build-dts' after 8.17 ms
[17:02:20] Finished 'build' after 1.17 s
[17:02:21] Using gulpfile ~/projects/animator-css/gulpfile.js
[17:02:21] Starting 'test'...
07 12 2015 17:02:22.609:WARN [watcher]: Pattern "/home/james/projects/animator-css/node_modules/karma-jasmine-jquery" does not match any file.
07 12 2015 17:02:23.784:INFO [karma]: Karma v0.13.15 server started at http://localhost:9876/
07 12 2015 17:02:23.789:INFO [launcher]: Starting browser Chrome
07 12 2015 17:02:24.691:INFO [Chrome 46.0.2490 (Linux 0.0.0)]: Connected on socket uLT7Wd2wxYwO7UWsAAAA with id 60357629
Chrome 46.0.2490 (Linux 0.0.0): Executed 54 of 54 SUCCESS (20.055 secs / 20.03 secs)
[17:02:45] Finished 'test' after 24 s

all right, yeah looking forward to try it out on my PC when at home. In the meantime @EisenbergEffect if you could give this PR a testdrive and it passes, I'd definitely like to see the changes released asap. It will certainly have a big impact on other issues as well and maybe solve them too. So lets see what happens.

Could add a travis.yml/circle.yml to have the tests automatically run on a CI server? Some of them provide a running Xvfb instance so the graphical nature of the tests wouldn't be an issue.

Ok I've tried it now on my PC and everything works fine :+1:
Big thanks for your contribution @ohjames. let's get this released as soon as you can @EisenbergEffect


jquery-bootgrid onload function doesn't work

I am calling bootgrid on load function as follow:
gridNewLoans.bootgrid().on("load.rs.jquery.bootgrid", function (e) {
alert('on load - fires before loading data')
});
It doesn't prompt the alert message when I run the code, however if I changed "load" into "click", it works on grid data row click. I tried with "initialize" and "initialized". Those events are also not working!

These work for sure, but note that you have to add the "initialized" handler before you initialize it, for reasons which a little thought will make clear.
}).on("loaded.rs.jquery.bootgrid", function (e) {
}).on("initialized.rs.jquery.bootgrid", function (e) {


Figure out if there is ever a time we need to e-mail a security stakeholder at the CDC if the incident is security related.

DevEx/OpEx
Figure out if there is ever a time we need to e-mail a security stakeholder at the CDC if the incident is security related.  And find out who that is.  Our ISSO?  Update the communication documentation with findings.
Tasks

[x] Update who to notify.

Additional Context
Add any other context or screenshots about the work here.

Might get more info. on this with 1313

Notion updated with comments about who/when to contact people. See here:
https://www.notion.so/flexion-cdc-ti/Process-92fb2c124c4146faa69429ec017902b0?pvs=4#1185955365f5806ebcb3c48975818908

@pluckyswan There are some comments in this section in Notion.  I also added a comment.

@pluckyswan, yeah, your changes look good to me.


Invalid links to key encoders in default provider

On default provider manpage the links in section Asymmetric Key Encoder to OSSL_ENCODER_RSA(7) and similar are all invalid links.

would like to attempt this. can anybody provide guidance. Looks like the referenced man pages are not yet written.  ref:  https://github.com/openssl/openssl/tree/master/doc/man7.

Right, the man pages do not exist and need to be written. Incidentally, although this issue is specifically about the encoders, it looks like the decoders also do not exist, and in fact do not even have a section from them on the default provider manpage.
Each algorithm (RSA, DH, DSA, etc) needs a specific page written for it describing the specifics of the encoder for that algorithm including the parameters it understands along with (preferably) an example. There are no encoder pages at all but here's an example for the equivalent key management page:
https://www.openssl.org/docs/man3.1/man7/EVP_KEYMGMT-DH.html
The encoders themselves are implemented in providers/implementations/encode_decode in the various encode_*.c files.
There is some generic documentation on encoders in providers here:
https://www.openssl.org/docs/manmaster/man7/provider-encoder.html
You should also see the documentation on the various OSSL_ENCODER_* functions documented here:
https://www.openssl.org/docs/manmaster/man3/
Not sure I agree with the "good first issue" label on this. Getting a good enough understanding of the encoder framework in order to be able to write this documentation is non-trivial and quite a bit of work. But great if you want to do it. I've swapped the label to "help wanted" instead.

This  PR was closed by the system as the author did not respond within 90 days. One of the changes requested was documentation of the implemented pubic API. Is there any general guidelines how the APIs are documented. Appreciate any pointers.

All the documentation takes the form of .pod files in the man7/man5/man3/man1 sub-directories here:
https://github.com/openssl/openssl/tree/master/doc
man3 is for documentation of API functions, while man7 is more for overview type stuff. The documentation needed here is all man7. I'd suggest you take a look at the other man7 .pod files to get a general feel for how they are put together. If you add a new .pod file make sure you run "make update".
I'd recommend that you regularly run "make doc-nits" (having ensured "make update" was previously run if you have added new pod files) when you are writing the documentation. That complains about any documentation errors and looks for style issues. "make doc-nits" also gets run automatically by our CIs so a pull request adding documentation must have a "clean" output from that command.

Ref: doc/HOWTO/documenting-functions-and-macros.md


Update RBI for URI::WS

URI::WS inherits from URI::Generic: https://github.com/ruby/uri/blob/master/lib/uri/ws.rb#L22
Motivation

Tapioca correctly generated the RBI as class URI::WS < ::URI::Generic which clashes with this payload.
Test plan

See included automated tests.

We have a policy of testing changes to Sorbet against Stripe's codebase before
merging them. I've kicked off a test run for the current PR.  When the build
finishes, I'll share with you whether or how it failed. Thanks!
Stripe employees can see the build results here:
→ https://go/builds/bui_NH09SHabCJIm3r
→ https://go/builds/bui_NH09w8z3EuDAA9


[Bug]: Frontend error when clicking Cancel Process button

What happened?

Affects Versions
master
What engines are you seeing the problem on?
No response
How to reproduce
No response
Relevant log output
No response
Anything else
No response
Are you willing to submit a PR?

[ ] Yes I am willing to submit a PR!

Code of Conduct

[X] I agree to follow this project's Code of Conduct

cc @zhangmo8 @minteliuwm

Hi @tcodehuber .Think you for you feedback
It's worked in my local. Maybe you should sync you code to latest version


unable to connect to in-mesh TCP ports using pod ip directly

@terinjokes commented on Wed Jan 03 2018
Is this a BUG or FEATURE REQUEST?:
BUG
Did you review existing epics or issues to identify if this already being worked on? (please try to add the correct labels and epics):
Y
Bug:
I'm unable to connect to generic in-mesh TCP ports.
What Version of Istio and Kubernetes are you using, where did you get Istio from, Installation details
istioctl version
kubectl version

Istio version: 0.4, installed from the "install" directory of istio/istio at the 0.4 tag.
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T21:07:38Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"linux/amd64"}
Server Version: version.Info{Major:"1", Minor:"8", GitVersion:"v1.8.6", GitCommit:"6260bb08c46c31eea6cb538b34a9ceb3e406689c", GitTreeState:"clean", BuildDate:"2017-12-21T06:23:29Z", GoVersion:"go1.8.3", Compiler:"gc", Platform:"linux/amd64"}

Is Istio Auth enabled or not ?
Y
What happened:
A ClusterIP service was created with port name "tcp-test" pointing at deployments running a generic TCP service on the specified port. Connections from other containers in the Istio mesh were unable to connect to the TCP service.
There were no logs from any istio-proxy containers.
What you expected to happen:
TCP services were able to connect

@ldemailly commented on Sun Jan 07 2018
you have to use the release tar, not the source tree at the tag (the yaml in source tree were stale, now removed)

@terinjokes commented on Sun Jan 07 2018
@ldemailly Thanks. That change wasn't clearly communicated. Thanks for removing the files. I'll close this if using the release templates resolves the issue.

@terinjokes commented on Sun Jan 07 2018
@ldemailly There's no differences between what's in the 0.4 tarballs and what was in the repositories at the 0.4 tag.

@ldemailly commented on Sun Jan 07 2018
Ah you're right, somehow 0.4.0 was patched up
unlike https://github.com/istio/istio/blob/0.3.0/install/kubernetes/istio.yaml#L261
for instance
but where did you get istioctl from ?
can you do
istioctl version

as well as
istioctl kube-inject -f any.yaml | grep Image

@terinjokes commented on Sun Jan 07 2018
I'm not using istioctl, I'm using the auto-injection initializer.

@ldemailly commented on Sun Jan 07 2018
can you paste the output of
make -C samples/rawvm dump-images

@terinjokes commented on Mon Jan 08 2018
      3 boostport/kubernetes-vault
      3 boostport/kubernetes-vault:latest
     14 busybox:1.27.2
[internal images omitted]
      1 docker.io/istio/istio-ca:0.4.0
      1 docker.io/istio/mixer:0.4.0
      1 docker.io/istio/pilot:0.4.0
      8 docker.io/istio/proxy:0.2.12
      1 docker.io/istio/proxy_debug:0.2.12
     22 docker.io/istio/proxy_debug:0.4.0
      8 docker.io/istio/proxy_init:0.2.12
     19 docker.io/istio/proxy_init:0.4.0
      1 docker.io/istio/sidecar_initializer:0.4.0
      2 gcr.io/google_containers/addon-resizer:1.0
      2 gcr.io/google_containers/explorer:1.0
      2 grafana/grafana:4.5.2
      1 istio/istio-ca:0.4.0
      1 istio/mixer:0.4.0
      1 istio/pilot:0.4.0
      8 istio/proxy:0.2.12
      1 istio/proxy_debug:0.2.12
     22 istio/proxy_debug:0.4.0
      8 istio/proxy_init:0.2.12
     19 istio/proxy_init:0.4.0
      1 istio/sidecar_initializer:0.4.0
      2 jaegertracing/jaeger-collector:0.9
      2 jaegertracing/jaeger-query:0.9
      4 lyft/envoy:0408b98cd2b150cb26e4b81844788c46059a2dfa
      2 openpolicyagent/kube-mgmt:0.4
      2 openpolicyagent/opa:0.5.12
      2 prom/statsd-exporter
      3 prom/statsd-exporter:latest
      1 prom/statsd-exporter:v0.5.0
      2 quay.io/coreos/grafana-watcher:v0.0.8
      2 quay.io/coreos/kube-state-metrics:v1.0.1
      2 quay.io/coreos/prometheus-operator:v0.15.0
     14 quay.io/pires/docker-elasticsearch-kubernetes:6.1.1
     12 quay.io/prometheus/node-exporter:v0.15.0

@ldemailly commented on Mon Jan 08 2018
somehow you have a bunch of 0.2.12 left
did you upgrade from 0.2.12 ? it seems like the upgrade didn't work
if you check which pods do have 0.2.12 and redeploy those, it should help
about NodePort specifically though, you need to use the svcIp, you can't use the nodeIp directly, is that how you connect ?

@terinjokes commented on Mon Jan 08 2018
@ldemailly We're creating a new service and new deployments, so 0.2.12 sidecars shouldn't be part of the problem (the new deployments are getting 0.4 sidecars). We're rotating the remaining deployments, so that should clear up soon.
I'm attempting to connect to the Kubernetes Service IP created from a type: NodePort service.

@ldemailly commented on Mon Jan 08 2018
I assume you do have auth/mtls on ? any details on how it fails ? (connection closed ? hangs ? ...)

@ldemailly commented on Mon Jan 08 2018
I haven't personally tested TCP NodePort, though I believe it should work - can you try a regular TCP service first ? (that works and I personally tested it and we have the mysql/mongodb regression tests for those)
https://github.com/istio/istio/blob/master/samples/bookinfo/kube/bookinfo-mysql.yaml

@terinjokes commented on Mon Jan 08 2018
@ldemailly My apologies, I see where some of the confusion here is coming from. On Friday I said "A NodePort service was created" when I meant "A ClusterIP service was created". I've corrected the issue.

@terinjokes commented on Mon Jan 08 2018
@ldemailly It seems in this case, the multiple parts of the service are communicating over the Kubernetes Service IP long enough to exchange direct IP addresses. They then switch to attempting a connection directly to the pod IP.
My guess, since istio_proxy is silent, is that mTLS can't be established properly, and a proxy somewhere closes the connection.
Is mTLS supposed to handle this case?

@ldemailly commented on Mon Jan 08 2018
when you have the proxy injected all inbound traffic goes to the proxy
when you have mtls enabled, all traffic must present a certificate - and the outbound envoy capture makes it happen
but if you use the podip directly, instead of the clusterip, that traffic isn't processed properly as envoy looks at services (cluster ips)
edit: in theory envoy could find that is the case by checking the ip+port and reverse matching it to a service but it doesn't for now / this wasn't a need so far. I suggest you try to stick to svc ip ?

@terinjokes commented on Mon Jan 08 2018
@ldemailly Yeah, that's the behavior we assumed and feared. :frowning:
Unfortunately, this is behavior of the application we can't control. It will always attempt to switch to the pod IPs.

@ldemailly commented on Mon Jan 08 2018
how does it even know the podip ? maybe you can make whoever says that ip believe the pod's ip is the cluster ip ?
alternatively I think it should be possible to configure envoy to mtls secure pod-pod traffic within a k8s cluster maybe we can turn this into a feature request for pilot
@kyessenov, thoughts ? (and did I get the above mostly correct?)

@terinjokes commented on Mon Jan 08 2018
@ldemailly The services use the service IP to coordinate, and part of that coordination is the pod IP.
In fancier terms: the application has a master election over the service IP, and then they attempt to connect to the elected master's IP address.
The service will only announce an IP address if it can bind to it, and the pod doesn't have the service's IP address in the network namespace.

@kyessenov commented on Tue Jan 09 2018
I don't think we support mixed-case like this that uses both service VIP and pod IPs.
For pure VIP case, we don't create separate TCP routes per each pod, as that has a potential to blow up the routing tables.
For pure pod IP case (called headless), we require that the service port be chosen as unique in the cluster. A route is created for that port (<IP_ADDRESS>:PORT) that lets traffic go passthrough. This is to support rich client libraries like the one for kafka, to do their own network functions (like LB).

@terinjokes commented on Tue Jan 09 2018
@kyessenov It would be great if we could opt-in handling mixed cases like this: where only some subset of pods needs be mixed, and thus not every pod in the cluster needs the routing rule. One of our motivations for our move to Kubernetes is to avoid needing to allocate cluster-unique ports.
In the short-term, having the service working with some caveat is better than not working at all. I can create a headless service. Is the <IP_ADDRESS>:PORT rule an Istio route rule?

@rlguarino commented on Thu Jan 11 2018
Is this something that will be addressed in future releases of Istio? I'm trying to get Prometheus to work and having a tough time without disabling MTLS.

@terinjokes commented on Tue Jan 16 2018
@kyessenov Do you mind expanding on your kafka example? I searched the issues in a couple Istio repos, and I haven't seem anything similar.

I'm also hitting a wall trying to get Prometheus to scrape my deployments. It connects using pod IP directly.
Has someone been able to establish a work-around? I haven't been able to find one in my search.
This one surprised me due to the prevalence of Prometheus in the k8s world, and the fact that Istio itself expresses it's metrics through Prometheus.

The workaround that I've been using it so expose Metrics on a debug port
that has MTLS disabled
https://istio.io/docs/tasks/security/per-service-mtls.html#disable-mutual-tls-authentication-for-httpbin-service.
We only ever access these ports directly (not through a LB or Service IP)
so disabling mtls wasn't a huge issue. I'm not sure if there's a new way to
do this now. I'd love to know as well.
On Mon, Mar 12, 2018 at 2:24 PM Evan Digby<EMAIL_ADDRESS>wrote:

I'm also hitting a wall trying to get Prometheus to scrape my deployments.
It connects using pod IP directly.
Has someone been able to establish a work-around? I haven't been able to
find one in my search.
This one surprised me due to the prevalence of Prometheus in the k8s
world, and the fact that Istio itself expresses it's metrics through
Prometheus.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/istio/istio/issues/3398#issuecomment-372467457, or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABQraraeNPjeQEUBz028qeqk6jCsCZeHks5tdudvgaJpZM4SBNMF
.

@rlguarino Thank you! My deployment doesn't have a service; however, I created one for the sole purpose of exposing Prometheus with MTLS disabled. That's worked around this for me.
Ultimately our production requirements dictate that this too would be encrypted (our security requirements are substantial) but this will allow me to continue evaluating Istio for our needs.
Thank you!

@rshriram can you add some commentary on why this is closed?

Sorry, i thought you said your issue was resolved

Thank you! My deployment doesn't have a service; however, I created one for the sole purpose of exposing Prometheus with MTLS disabled. That's worked around this for me.

Either way, the solution as pointed out above is to use per-service mTLS. We are not exposing direct access to pod IP from a client's sidecar, due to scalability constraints..

Not sure I understand the solution.
I would like to provide a pod to pod communication for Akka cluster bootstrapping.

Yes, we have the same problem when we use prometheus to scrape metrics(business metrics, not service metrics) from pod directly, it just return 404(NOT FOUND) from the pod sidecar since we haven't exposed the metrics port to the service.
Currently the workaround is that we almost expose the metrics port to every service to make it work, it looks not very ideal for this case. So, @rshriram, do you think the passthrough mechanism for outbound should work for inbound in this case ? thanks.

After some deeper thought, we think expose the pod metrics port to each service will double the dynamic listener and route entries from pilot(especially we have several hundreds of k8s services) and not very elegant(we should not expose metrics port to k8s service just for this purpose).
And then we have two basic ideas:

custom the pod sidecar static_resource through pilot template to let each sidecar forward metrics request(/metrics for example) to pod business container through localhost(like /stats/prometheus).
let the metrics request bypass the envoy sidecar through iptables

Currently we adopt the second method, only capture and redirect normal service port to envoy sidecar and let the other traffic just bypass to the container.
So the configure looks like this before and after:
Before:
// k8s pod spec:
    ports:
    - containerPort: 8080 // normal service port other service call
      name: http
      protocol: TCP
    - containerPort: 12345 // internal standard business metrics port
      name: metrics
      protocol: TCP

// the corresponding init containers
  initContainers:
  - args:
    - -p
    - "15001"
    - -u
    - "1337"
    - -m
    - REDIRECT
    - -i
    - x.x.x.x/10
    - -x
    - ""
    - -b
    - 8080,12345
    - -d
    - ""

After:
// k8s pod spec:
    ports:
    - containerPort: 8080 // normal service port other service call
      name: http
      protocol: TCP

// the corresponding init containers
  initContainers:
  - args:
    - -p
    - "15001"
    - -u
    - "1337"
    - -m
    - REDIRECT
    - -i
    - x.x.x.x/10
    - -x
    - ""
    - -b
    - 8080
    - -d
    - ""

And now the prometheus can scrape each pod business metrics through podIP, hope this helps who needs:)


feat(THEME): add all-component-colors mixin

Feature Description
When adding multiple themes to one file... We are encouraged to only use the <component>-color() mixin.
However, in order to do this we have to reference every single component in the library.... If we are using every component.
Similar to the mat.all-component-themes($my-theme); can we get a mat.all-component-colors($my-theme);?
Use Case
@mixin all-component-colors($theme-or-color-config) {
    @include core-theme.color($theme-or-color-config);
    @include autocomplete-theme.color($theme-or-color-config);
    @include badge-theme.color($theme-or-color-config);
    @include bottom-sheet-theme.color($theme-or-color-config);
    @include button-theme.color($theme-or-color-config);
    @include button-toggle-theme.color($theme-or-color-config);
    @include card-theme.color($theme-or-color-config);
    @include checkbox-theme.color($theme-or-color-config);
    @include chips-theme.color($theme-or-color-config);
    @include table-theme.color($theme-or-color-config);
    @include datepicker-theme.color($theme-or-color-config);
    @include dialog-theme.color($theme-or-color-config);
    @include divider-theme.color($theme-or-color-config);
    @include expansion-theme.color($theme-or-color-config);
    @include form-field-theme.color($theme-or-color-config);
    @include grid-list-theme.color($theme-or-color-config);
    @include icon-theme.color($theme-or-color-config);
    @include input-theme.color($theme-or-color-config);
    @include list-theme.color($theme-or-color-config);
    @include menu-theme.color($theme-or-color-config);
    @include paginator-theme.color($theme-or-color-config);
    @include progress-bar-theme.color($theme-or-color-config);
    @include progress-spinner-theme.color($theme-or-color-config);
    @include radio-theme.color($theme-or-color-config);
    @include select-theme.color($theme-or-color-config);
    @include sidenav-theme.color($theme-or-color-config);
    @include slide-toggle-theme.color($theme-or-color-config);
    @include slider-theme.color($theme-or-color-config);
    @include stepper-theme.color($theme-or-color-config);
    @include sort-theme.color($theme-or-color-config);
    @include tabs-theme.color($theme-or-color-config);
    @include toolbar-theme.color($theme-or-color-config);
    @include tooltip-theme.color($theme-or-color-config);
    @include tree-theme.color($theme-or-color-config);
    @include snack-bar-theme.color($theme-or-color-config);
  }
}

We have this already. See https://github.com/angular/components/blob/master/src/material/_index.scss#L24

Closing since there hasn't been any feedback. The issue can be reopened if we get more information.


Rename OpenJDK Distribution to Xamarin OpenJDK

Given this distribution is specifically designed for Xamarin/Android apps and not a general purpose OpenJDK for any kind of Java application (e.g. server-side Java apps on Azure; desktop Java apps on Windows), it is important to name this as Xamarin OpenJDK Distribution.
See PR #586.

Thanks for your thoughts on this matter. As there is already a PR in place for this, I'm closing this issue off  so that the conversation will occur there.

This was fixed in commit 9d90c732


DOS line endings in some files

$ find aws-cpp-sdk-* -type f -name *.cpp -o -name *.h | xargs file | grep CRLF
aws-cpp-sdk-core/source/http/URI.cpp:                                                                           C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp:                                                           C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/source/http/standard/StandardHttpResponse.cpp:                                                 C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/source/http/standard/StandardHttpRequest.cpp:                                                  C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/source/utils/HashingUtils.cpp:                                                                 C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/source/utils/StringUtils.cpp:                                                      C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/source/utils/threading/Executor.cpp:                                               C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/source/client/ClientConfiguration.cpp:                                             C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/source/platform/windows/OSVersionInfo.cpp:                                         C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/source/auth/AWSAuthSigner.cpp:                                                     C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/source/auth/AWSCredentialsProvider.cpp:                                            C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/include/aws/core/utils/crypto/EncryptionMaterials.h:                               C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/include/aws/core/utils/crypto/Cipher.h:                                            C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/include/aws/core/utils/EnumParseOverflowContainer.h:                               C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/include/aws/core/utils/StringUtils.h:                                              C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/include/aws/core/utils/threading/ThreadTask.h:                                     C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/include/aws/core/utils/threading/Executor.h:                                       C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-core/include/aws/core/utils/stream/PreallocatedStreamBuf.h:                             C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core/include/aws/core/client/ClientConfiguration.h:                                     C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-core-tests/utils/StringUtilsTest.cpp:                                                   C source, UTF-8 Unicode text, with very long lines, with CRLF line terminators
aws-cpp-sdk-dynamodb-integration-tests/TableOperationTest.cpp:                                      C++ source, ASCII text, with CRLF line terminators
aws-cpp-sdk-identity-management/source/auth/STSAssumeRoleCredentialsProvider.cpp:                              C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-identity-management/include/aws/identity-management/auth/STSAssumeRoleCredentialsProvider.h:       C source, ASCII text, with CRLF, LF line terminators
aws-cpp-sdk-lambda-integration-tests/FunctionTest.cpp:                                                         C++ source, ASCII text, with CRLF line terminators
aws-cpp-sdk-polly/source/model/SynthesizeSpeechRequest.cpp:                                                                      C source, UTF-8 Unicode (with BOM) text, with CRLF, LF line terminators
aws-cpp-sdk-rds/include/aws/rds/RDSClient.h:                                                                                C source, UTF-8 Unicode (with BOM) text, with CRLF, LF line terminators
aws-cpp-sdk-s3-encryption/source/s3-encryption/modules/CryptoModule.cpp:                                 C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-s3-encryption/include/aws/s3-encryption/modules/CryptoModule.h:                              C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-sqs-integration-tests/QueueOperationTest.cpp:                                                C++ source, ASCII text, with CRLF line terminators
aws-cpp-sdk-text-to-speech/source/text-to-speech/windows/WaveOutPCMOutputDriver.cpp:                        C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-text-to-speech/include/aws/text-to-speech/TextToSpeechManager.h:                                C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-text-to-speech/include/aws/text-to-speech/windows/WaveOutPCMOutputDriver.h:                     C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-text-to-speech/include/aws/text-to-speech/PCMOutputDriver.h:                                    C source, ASCII text, with CRLF, LF line terminators

I have noticed the same problem and I am going to solve that

Solved

Not quite:
$ find aws-cpp-sdk-* -type f -name *.cpp -o -name *.h | xargs file | grep CRLF
aws-cpp-sdk-core/source/http/curl/CurlHttpClient.cpp:                                                           C source, ASCII text, with CRLF line terminators
aws-cpp-sdk-polly/source/model/SynthesizeSpeechRequest.cpp:                                                                      C source, UTF-8 Unicode (with BOM) text, with CRLF, LF line terminators
aws-cpp-sdk-rds/include/aws/rds/RDSClient.h:                                                                                C source, UTF-8 Unicode (with BOM) text, with CRLF, LF line terminators


Feature: Add Notional V2 Connector

[ ] Review and approve connector @pradyuman-verma @thrilok209
[ ] Deploy and comment addresses.
[ ] Add to dsa-connect
[ ] Build and deploy resolver
[ ] Add to docs

@jeffywu Are there any test cases for the connector?
If not, can you add them!

@pradyuman-verma we wrote the tests in brownie so @weitianjie2000 will have to port them over to hardhat and add them here.

@pradyuman-verma, we wrote the tests in brownie, so @weitianjie2000 will have to port them over to hardhat and add them here.

Sure, Convert them to typescript, and let us know!

@pradyuman-verma Hi, I've migrated all of the tests. Please let me know if you need anything else. Thanks!

@jeffywu The test cases are in js, We use ts. Can you migrate them to typescript?

@pradyuman-verma tests are in typescript now

@jeffywu Can you add the latest screenshot of the tests?

new test run,

@weitianjie2000 Thanks.
Can you resolve the conversations on which you have worked?

@jeffywu @weitianjie2000 We can proceed towards deployment.

@pradyuman-verma, @weitianjie2000 is going to add another method here to allow users to Stake NOTE tokens (we just launched this earlier this week) so I think that will be great for users.
What's the next step for deployment? Do you want us to deploy and verify this contract and send you back an address?

@pradyuman-verma, @weitianjie2000 will add another method here to allow users to Stake NOTE tokens (we just launched this earlier this week), so I think that will be great for users.
What's the next step for deployment?

Let's add the Stake NOTE tokens feature and then deploy the contract and comment the addresses here.

@pradyuman-verma I've added the staking tests + screenshot for the new test run. Would you like to take another look before I deploy the connector?

@pradyuman-verma I've added the staking functions and tests + screenshot for the new test run. Would you like to take another look before I deploy the connector?

Yes, I will review it and let you know if any changes are required.

@jeffywu @weitianjie2000 We can deploy it.

@pradyuman-verma @jeffywu connector is deployed and verified https://etherscan.io/address/0x0b7675e19d71a0c8953444f7f9913b8448186441#code


CLI: wandb.login() with custom host prints wrong link to wandb.ai/authorize

Describe the bug
On running following, it prompts to get token from wandb.ai/authorize instead of wand.mydomain.com/authorize
wandb.login(host="https://wandb.mydomain.com", relogin=False)
In colab notebook I had to run following, and this worked as expected
 !wandb login --host=https://wandb.mydomain.com
Here is the screenshot

Hi, thanks for flagging this!

will go out in 0.10.13 release


when file_drop ignores empty files, it needs to notify that it's being ignored

hmm, upon inspection, this is already in place. debugging why it's not working.


need example for form submit using wizard

Wizard standalone works great. with info and some html. Iam struck when trying to wrap it up with some form tags like text box. My goal is to get inputs of user and submit.
<wizard #wizard>

0 &&
            responsemsg === 'Username does not exist'
            ">{{responsemsg}}

I'm not sure, where the form tag or the input component comes in in your example?
A few weeks ago someone else asked a similar question I believe: #21.
Basically you need to wrap the content of the step inside a form. Afterwards you can just bind form.valid to the [canExit] property of the step.

wraping whole wizard inside a form tag throws errors. My goal is to get inputs from the form and submit to server.
specially forms like these when added inside the wizard step or outside wrapping both gives either compile time or run time errors.

Can we use this wizard for my usecase of form submit?

This Solved my issue:
"Basically you need to wrap the content of the step, the step itself or the whole wizard inside a form. "
You can close my issue.
One suggestion - As multi form or (wizard) based form value submit is a common usecase, example on it will greatly benefit the beginner guys like me.
thanks for the component. It has really saved a lot of time and frustration. Great!


chore: cleanup unused functions and parameters

Resolved issues:
https://github.com/aws/s2n-quic/issues/2204
Description of changes:

Call-outs:

Testing:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

combining with https://github.com/aws/s2n-quic/pull/2251


Add accessors for Snippet and HighlightSection

Add accessors for Snippet and HighlightSection, and add example of a custom highlighter.
fix #434 and #439 I think

LGTM. Added minor comments. Special thanks for completing the example.


Usage on a custom dataset

I intend to use this repo on a custom dataset of fashion images with weak labels (stored in a CSV file, row wise).. can you suggest which files would be the best choice to edit and use?

Hi! You can modify Train_clothing1M with your custom dataloader. Thanks!

Thanks!


Add license

Hi @sammcj and @jimmc414
that's a fantastic tool, thanks for sharing! I was just wondering under which conditions one could reuse the code provided here. Would you mind adding a license file? If you're new to licensing and/or wonder which license to use, you can read more in this blob post: https://focalplane.biologists.com/2023/05/06/if-you-license-it-itll-be-harder-to-steal-it-why-we-should-license-our-work/
Thanks!
Best,
Robert

Great advice and I'm thrilled you find it useful.  I have added a
permissive MIT license linked here:
https://github.com/jimmc414/1filellm/blob/main/LICENSE
Thank you!
Jim
On Fri, Feb 23, 2024 at 4:35 AM Robert Haase @.***>
wrote:

Hi @sammcj https://github.com/sammcj and @jimmc414
https://github.com/jimmc414
that's a fantastic tool, thanks for sharing! I was just wondering under
which conditions one could reuse the code provided here. Would you mind
adding a license file? If you're new to licensing and/or wonder which
license to use, you can read more in this blob post:
https://focalplane.biologists.com/2023/05/06/if-you-license-it-itll-be-harder-to-steal-it-why-we-should-license-our-work/
Thanks!
Best,
Robert
—
Reply to this email directly, view it on GitHub
https://github.com/jimmc414/1filellm/issues/2, or unsubscribe
https://github.com/notifications/unsubscribe-auth/ABQNOIOHIV3SQFWZGJUPBK3YVBWHTAVCNFSM6AAAAABDWPSXUCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGE2TAOBRGE3TAMQ
.
You are receiving this because you were mentioned.Message ID:
@.***>

awesome, thanks for the quick response!


QROM demo to master

New PR pointing to master
Some discussions were made in the other PR

[sc-63852]


Click effect on GroupView

Hi,
I noticed that when user clicks on a group in order to expand or collapse it, the "click effect" (for example ripple effect) is catched by something and it is not shown.
Instead, while keeping the item pressed, the ripple effect is shown.
This happens both in your example and in my application.
If I change "onCheckCanExpandOrCollapseGroup" in order  to return FALSE, the click effect is shown, but obviously the item is not expanded/collapsed.
Is there a way to fix it?
Thanks in advance

Hi. Thanks for your report.
Workaround:
Make onCheckCanExpandOrCollapseGroup returns false and set View.onClickLIstener for each group views. Then you can use these two methods to expand/collapse the group.

RecyclerViewExpandableItemManager.expandGroup(int groupPosition)
RecyclerViewExpandableItemManager.collapseGroup(int groupPosition)

see also.) Force expand/colapse #11

Hi,
Thanks for the answer.
I had found that workaround yet.
But unfortunately, using that workaround, when user clicks on the morphing arrow nothing happens, because it has not an "onclick" event and I think it is a bit bothering for user.
Groups expand/collapse only clicking on the group title...
Thanks in advance.

Found a workaround.

Do you mean in the standard implementation or in the one with the workaround?

Just a workaround for now. Because it seems like a bug of MorphButton class. MorphButton consumes touch event even if android:enable="false" and/or android:clickable="false" specified in xml.

Why do you intercept touch here: RecyclerViewExpandableItemManager.java#L242-L244 I think you should not do that and I think it's root of the problem.

@Kuci Thanks for your advice! I'll fix this issue tomorrow.

I confirm the bug is fixed in the latest version. Thank you.


Implement script to import e.me data (bug 1161871)

https://bugzilla.mozilla.org/show_bug.cgi?id=1161871
Goes with https://docs.google.com/spreadsheets/d/1CPrPQ4xVsbll_vp_Bca0iWkTgg2nx7WrhCprVHwS-6Y/edit#gid=304044273
Depends on #3090 (some rows in that spreadsheet reference the new categories, the code expect the new names to be present)

r+ I couldn't find anything after reading closely. Nice work. :+1:


Use specific Creator Plugin when multiple Creators exist for single family

Issue
When writing two Creator plug-ins that are targeted to the same resulting family there is unexpected behavior when using it with the Creator tool.
Both entries will individually show in the Creator, however whenever you trigger either of them both will be created. This is because the API triggers all Plugins based solely on the family matching, and it doesn't trigger a specific plugin
I recall the API was designed like this for a reason but can't remember why. Now, with the Creator tool built as it is the the resulting behavior is super confusing. Is there anyone relying on this behavior of it to trigger multiple Creator plugins for a specific family?
class CreateA(api.Creator):
    label = "A"
    family = "foobar"

    def process(self):
        print("A")

class CreateB(api.Creator):
    label = "B"
    family = "foobar"

    def process(self):
        print("B")

Now in the Creator tool create A or B, you will always see both plug-ins are triggered:
A
B

Proposal
I'd propose to have the first argument for api.Create to be the Creator plugin to trigger as opposed to the family name.
For backwards compatibility I'd then make it so whenever it does not get an instance of Creator but a string that it will keep the old behavior. This way any custom code built against the API will remain to work as is.
Then we'll just update the Creator tool to not trigger by family name but explicitly pass it the Plugin.
OR if the behavior is intended and we want to stick to it for specific reasons then likely we'd want to make the Creator UI less ambiguous that these double entries in the list are doing the exactly same thing - running both. Not sure what to do in that case, but it should at least be clearer what is going on then.

Cant see why you'd need to have two plugins triggered. Voting for passing the Creator plugin with backwards compatibility.

Just adding notes.

The api.create was originally from #291.
Only one last instance is returned from api.create no matter how many plugin been processed.

The api.create was originally from #291.

Actually the problem was there before too, the code had just moved.
Anyway... I'm still all for getting this corrected in the best way possible.


img2img doesn't appear to be working

img2img doesn't seem to be working. Clicking on Generate doesn't seem to do anything, but the standard txt2img seems to be working normally.

Update:
Seems to be working now. May have been some connection issues earlier today.


updating to 3.7.0 something broke

Description
Hi, just updated the newest version on Unbuntu 22.04 and it seems to have broke the bridge. Here what I see
Entities not reporting to Home Assistant anymore (all unavailable, which is different from this issue ) with this error in the core logs:

Logger: homeassistant.config_entries
Source: helpers/aiohttp_client.py:73
First occurred: 8:19:41 AM (1 occurrences)
Last logged: 8:19:41 AM

Error setting up entry Ubuntu (<IP_ADDRESS>) for system_bridge
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/config_entries.py", line 390, in async_setup
    result = await component.async_setup_entry(hass, self)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/system_bridge/__init__.py", line 71, in async_setup_entry
    if not await version.check_supported():
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/systembridgeconnector/version.py", line 40, in check_supported
    and (version := await self.check_version_3()) is not None
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/systembridgeconnector/version.py", line 71, in check_version_3
    response = await self._http_client.get("/api/data/system")
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/systembridgeconnector/http_client.py", line 40, in get
    response: ClientResponse = await self.request(
                               ^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/systembridgeconnector/http_client.py", line 118, in request
    "response": await response.json(),
                ^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/helpers/aiohttp_client.py", line 73, in json
    return await super().json(*args, loads=loads, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/local/lib/python3.11/site-packages/aiohttp/client_reqrep.py", line 1104, in json
    raise ContentTypeError(
aiohttp.client_exceptions.ContentTypeError: 0, message='Attempt to decode JSON with unexpected mimetype: text/plain; charset=utf-8', url=URL('http://<IP_ADDRESS>:9170/api/data/system')

When using the webinterface, headers are reporting...but its all blank when you expand:

The service seems to be running normally, however:

thanks for your help
What Platform / OS are you running?
Linux
What version are you running?
3.7.0
Anything in the logs or a references that might be useful?
No response
Additional information
No response

Hey @timmo001, any suggestions to get this working? thanks

Hi again,
I updated to 3.8.0 by this command
python3 -m pip install --upgrade systembridgeshared systembridgebackend systembridgecli systembridgefrontend systembridgegui
and it seemed to successfully update but now when I try to run the service
sudo python3.10 -m systembridgebackend --no-gui
I get this:
anto@anto-m8150n:~$ python3 -m systembridgebackend --no-gui
Traceback (most recent call last):
  File "/usr/lib/python3.10/runpy.py", line 187, in _run_module_as_main
    mod_name, mod_spec, code = _get_module_details(mod_name, _Error)
  File "/usr/lib/python3.10/runpy.py", line 146, in _get_module_details
    return _get_module_details(pkg_main_name, error)
  File "/usr/lib/python3.10/runpy.py", line 110, in _get_module_details
    __import__(pkg_name)
  File "/home/antonio/.local/lib/python3.10/site-packages/systembridgebackend/__init__.py", line 15, in <module>
    from .server import Server
  File "/home/antonio/.local/lib/python3.10/site-packages/systembridgebackend/server/__init__.py", line 19, in <module>
    from ..data import Data
  File "/home/antonio/.local/lib/python3.10/site-packages/systembridgebackend/data.py", line 10, in <module>
    from .modules.media import Media
  File "/home/antonio/.local/lib/python3.10/site-packages/systembridgebackend/modules/media/__init__.py", line 10, in <module>
    import winsdk.windows.media.control as wmc  # pylint: disable=import-error
ModuleNotFoundError: No module named 'winsdk'

any idea how to solve this one?

thanks @timmo001 both issues described above are now solved on 3.8.1.
Keep you updated on this issue and see if 3.8.1 solves it.
cheer


[API 8] Resolve removal of get prefix on certain methods that didn't accept the change too nicely

Aiming to use this issue as a general repository of method names in the API that, following the get prefix removal, received confusing renames.
Please append any issues you spot to this ticket rather than creating a new one, so we can have a global repository and one singular issue aimed at fixing the problem. Also, please provide possible renames of the methods so they can be properly discussed.

Known so far:
EconomyService

getOrCreateAccount --> orCreateAccount

accountOrCreate (zml) or createAccountIfAbsent (mbaxter)

Objective

getOrCreateScore --> orCreateScore

scoreOrCreate or createScoreIfAbsent

https://github.com/SpongePowered/SpongeAPI/commit/e5717aca256ffd1a1b9b87fac1cb701b4c14bf2a

https://github.com/SpongePowered/SpongeAPI/commit/aee5e7c7915d930914228538e2f100c8cfce60a5 for economy service.
Will leave this issue open for the time being for any other weird results from dropping get.

GameProfileCache now has methods such as byId, byName etc. I feel like these should be named find and overloaded if possible, or at least findById(...) etc. Thoughts?

GameProfileCache now has methods such as byId, byName etc. I feel like these should be named find and overloaded if possible, or at least findById(...) etc. Thoughts?

+1
Can we rename other similar methods for consistency ?
StateContainer#statePropertyByName
Scheduler#tasksByName
Scheduler#tasksById
State#statePropertyByName

We should - open for comments but I don't want to leave this proposal too long.

For GameProfileCache, how about a scheme like withName or named?

I'm more on the side of withX, as I can imagine id not coming across as straight as it should.

I'm not sure about with, as with is generally used to return an immutable copy of itself with a modified attribute.
Note that I have used find for the user manager - it's worth discussing that too as I'd argue is the same thing here. Also probably the same with account.
I've been thinking more about accountOrCreate and scoreOrCreate and I feel a little iffy about them because it doesn't seem natural to have nounOrVerb I think that's why I went find in the first place. I think this is somewhere that we need to have a consistent policy.
@Zidane @gabizou any thoughts on how you;d like to handle this?

We should - open for comments but I don't want to leave this proposal too long.

Famous last words.
I've spent some time thinking about this and the more I look at it, the more I really dislike nounOrVerb(...) methods - it's jarring. My preference remains to prefix these methods that grab a result from a collection or collection-like objects should be findX. It's what we have on other objects such as defaulted registries and such. This includes things that have been renamed as part of this issue already, scoreOrCreate (get a score or create?) should really be findOrCreateScore, for example. Similar case with the econ service. The methods should still make sense in English.
find would match the registry querying etc. and I think it makes the most sense here. We can omit the noun if the object's interface name makes it clear as to what you're getting (so find on UserManager makes sense without "User", but find on Objective doesn't make sense without Score as Objective#find() could be construed to get an objective and not a score towards the objective.)
I'll go ahead and use find and findOrCreate unless anyone has a good reason as to why we shouldn't use find in these scenarios.

Nothing else has come up in the past month so I'll close this. It can be re-opened if more comes to light.


JS error when using latest qTip with jQuery 1.4.4

I'm using qTip with the latest build of qTip v2 from the download on the site with jQuery 1.4.4.  I am using the unfocus event for the hide options and was getting an error like
q.replace is not a function
I then used the uncompressed versions of qTip and jQuery and traced the issue down to line 556 in my build, or this block of code:
// Hide tooltip on document mousedown if unfocus events are enabled
if(('' + options.hide.event).indexOf('unfocus') > -1) {
  targets.document.bind('mousedown'+namespace, function(event) {
    var $target = $(event.target),
      enabled = !tooltip.hasClass(disabled) && tooltip.is(':visible'),
      isAncestor = $target.parents(selector).filter(tooltip[0]).length > 0;

    if($target[0] !== tooltip[0] && !isAncestor &&
      !$target.closest(target).length && !$target.attr('disabled')
    ) {
      self.hide(event);
    }
  });
}

The jQuery method jQuery.fn.closest has changed to allow jQuery objects as a param in 1.6, however in 1.4.4, it expects a string as a first argument, which is what I suspect is the issue here.  If I remove the block:
!$target.closest(target).length &&

Then the error goes away.

This should now be fixed in the latest commit, great catch m4olivei!

Awesome, thanks!


TDI-38253:Some Azure storage queue components shouldn't support main row

Please check if the PR fulfills these requirements
https://jira.talendforge.org/browse/TDI-38253

[x] The commit message follows Talend standard
[ ] Tests for the changes have been added (for bug fixes / features)

What is the current behavior? (You can also link to an open issue here)
What is the new behavior?
Does this PR introduce a breaking change?

[ ] Yes
[x] No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:

Pull request test result: success :star:


routing: include htlc amount in bandwidth hint queries

This PR bubbles our htlc amount all the way down to MayAddOutgoingHtlc , implementing the full fix for #5468 (replacing the temporary fix introduced in #5478 to account for nodes that set a 0 minHtlc).
This change updates our bandwidth check to only check whether we can add a htlc to our channel when we're actually adding one; availableChanBalance queries for the total bandwidth of the channel do not check any flow constraints. I think this is ok because we just get our channel balance when we're doing a very quick getOutgoingBalance check our own channels. If we continue with pathfinding, the actual htlc addition check itself will kick in when we getPolicyLocal anyway. An alternative would be to continue to query using (potentially padded) minHtlc and calling MayAddOutoingHtlc on all bandwidth checks.

itests failing, removing request for review while I look into whether it's flakes vs this change

Rebased this on #5642 and itest flakes are totally resolved. If we're happy to block this on that merge (don't really see another option), I'll push the rebased version? cc @Roasbeef

Changes looking good, glad all the flakes are gone. Got a few nits and, is there an easy way for us to add itest for this change?

is there an easy way for us to add itest for this change?

We already have itest coverage for the validation in MayAddOutgoingHtlc in "max htlc pathfind", as for itest coverage for the specific change of passing the htlc amount in rather than using minimum htlc amount, I think that the unit tests are sufficient?